gdb/ChangeLog

   1 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
   2
   3         * defs.h (generic_load): Move from here...
   4         * symfile.h (generic_load): ... to here.  Rename name parameter
   5         to args.
   6         * symfile.c (generic_load): Add comment.
   7
   8 2019-07-01  Tom Tromey  <tromey@adacore.com>
   9
  10         * dwarf2read.c
  11         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
  12         declaration of without_params.  Fix formatting.
  13
  14 2019-07-01  Tom Tromey  <tromey@adacore.com>
  15
  16         * ada-exp.y (find_primitive_type): Update.
  17         * ada-lang.h (ada_lookup_symbol): Update.
  18         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
  19         parameter.
  20         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
  21
  22 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
  23
  24         PR breakpoints/24541
  25         * gdbarch.c: Regenerate.
  26         * gdbarch.h: Regenerate.
  27         * gdbarch.sh: Add 'stap_adjust_register'.
  28         * i386-tdep.c: Include '<unordered_set>'.
  29         (i386_stap_adjust_register): New function.
  30         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
  31         * stap-probe.c (stap_parse_register_operand): Call
  32         'gdbarch_stap_adjust_register'.
  33
  34 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
  35
  36         PR python/24742
  37         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
  38         * python/python.c (do_start_initialization): Use 'xmalloc'
  39         instead of 'PyMem_Malloc'.
  40
  41 2019-06-28  Tom Tromey  <tromey@adacore.com>
  42
  43         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
  44         for Ada.
  45
  46 2019-06-27  Tom Tromey  <tromey@adacore.com>
  47
  48         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
  49         objfile_key.
  50         (arm_find_mapping_symbol, arm_record_special_symbol)
  51         (_initialize_arm_tdep): Update.
  52         (arm_objfile_data_free): Remove.
  53
  54 2019-06-27  Tom Tromey  <tromey@adacore.com>
  55
  56         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
  57         to cp_print_static_field.
  58
  59 2019-06-26  Tom Tromey  <tromey@adacore.com>
  60
  61         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
  62         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
  63         declare.
  64
  65 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
  66
  67         * features/aarch64-core.c (create_feature_aarch64_core):
  68         Regenerate.
  69         * features/aarch64-core.xml: Add cpsr flags.
  70
  71 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
  72
  73         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
  74         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
  75
  76 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
  77
  78         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
  79         field.
  80         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
  81         use.
  82         (arm_record_special_symbol): Don't insert new symbol in sorted
  83         position, push it at the end.
  84
  85 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
  86
  87         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
  88         (arm_mapping_symbol_s): Remove.
  89         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
  90         (arm_mapping_symbol_vec): New typedef.
  91         (struct arm_per_objfile): Add constructor.
  92         <section_maps>: Change type to
  93         std::unique_ptr<arm_mapping_symbol_vec[]>.
  94         (arm_compare_mapping_symbols): Remove.
  95         (arm_find_mapping_symbol): Adjust to section_maps type change.
  96         (arm_objfile_data_free): Call delete on arm_per_objfile.
  97         (arm_record_special_symbol): Adjust to section_maps type change.
  98         Allocate arm_per_objfile with new.
  99
 100 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 101
 102         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 103         with the command prefix.
 104
 105 2019-06-25  Tom Tromey  <tom@tromey.com>
 106
 107         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 108         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 109
 110 2019-06-25  Tom Tromey  <tom@tromey.com>
 111
 112         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 113         type.
 114         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 115         protected.
 116
 117 2019-06-25  Tom Tromey  <tom@tromey.com>
 118
 119         * tui/tui-winsource.c
 120         (tui_source_window_base::set_is_exec_point_at): Add check against
 121         LOA_ADDRESS.
 122
 123 2019-06-25  Tom Tromey  <tom@tromey.com>
 124
 125         * tui/tui-source.c (tui_set_source_content): Don't check before
 126         xfree.
 127         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 128
 129 2019-06-25  Tom Tromey  <tom@tromey.com>
 130
 131         * tui/tui-winsource.h (tui_update_source_window_as_is)
 132         (tui_alloc_source_buffer, tui_line_is_displayed)
 133         (tui_addr_is_displayed): Change type of win_info.
 134         * tui/tui-winsource.c (tui_update_source_window_as_is)
 135         (tui_clear_source_content, tui_show_source_line)
 136         (tui_show_source_content, tui_source_window_base::refill)
 137         (tui_source_window_base::set_is_exec_point_at)
 138         (tui_source_window_base::set_is_exec_point_at)
 139         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 140         (tui_alloc_source_buffer, tui_line_is_displayed)
 141         (tui_addr_is_displayed): Change type of win_info.  Update.
 142         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 143         (tui_source_window_base::do_make_visible_with_new_height):
 144         Update.
 145         * tui/tui-source.c (tui_set_source_content)
 146         (tui_set_source_content_nil)
 147         (tui_source_window::do_scroll_vertical): Update.
 148         * tui/tui-layout.c (show_layout): Update.
 149         * tui/tui-disasm.c (tui_set_disassem_content)
 150         (tui_disasm_window::do_scroll_vertical): Update.
 151         * tui/tui-data.h (tui_win_content): Remove.
 152         (struct tui_gen_win_info) <content, content_size>: Remove.
 153         (struct tui_source_element): Add initializers and destructor.
 154         (union tui_which_element, struct tui_win_element): Remove.
 155         (struct tui_source_window_base) <content>: New field.
 156         (struct tui_data_window): Remove destructor.
 157         (tui_alloc_content, tui_free_win_content)
 158         (tui_free_all_source_wins_content): Don't declare.
 159         * tui/tui-data.c (tui_initialize_static_data): Update.
 160         (init_content_element, tui_alloc_content): Remove.
 161         (~tui_gen_win_info): Update.
 162         (~tui_data_window, tui_free_all_source_wins_content)
 163         (tui_free_win_content, free_content, free_content_elements):
 164         Remove.
 165
 166 2019-06-25  Tom Tromey  <tom@tromey.com>
 167
 168         * tui/tui-winsource.h (tui_clear_source_content)
 169         (tui_erase_source_content, tui_show_source_content): Change type
 170         of win_info.
 171         * tui/tui-winsource.c (tui_clear_source_content)
 172         (tui_erase_source_content, tui_show_source_content): Change type
 173         of win_info.
 174         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 175         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 176         win_info.
 177         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 178         win_info.
 179         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 180
 181 2019-06-25  Tom Tromey  <tom@tromey.com>
 182
 183         * tui/tui-winsource.c (tui_clear_source_content)
 184         (tui_source_window_base::set_is_exec_point_at): Update.
 185         * tui/tui-source.c (tui_set_source_content_nil): Update.
 186         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 187         a bool.
 188         * tui/tui-data.c (init_content_element): Update.
 189
 190 2019-06-25  Tom Tromey  <tom@tromey.com>
 191
 192         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 193         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 194         * tui/tui-layout.c (init_and_make_win): Update.
 195         * tui/tui.h (enum tui_win_type): Update.
 196         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 197         tui_win_is_auxillary.
 198         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 199         tui_win_is_auxillary.
 200
 201 2019-06-25  Tom Tromey  <tom@tromey.com>
 202
 203         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 204         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 205         (tui_delete_data_content_windows, tui_display_all_data)
 206         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 207         Update.
 208         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 209         * tui/tui-regs.c (tui_last_regs_line_no)
 210         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 211         (tui_show_registers): Update.
 212         (tui_show_register_group): Return void.  Update.
 213         (tui_display_registers_from, tui_display_reg_element_at_line)
 214         (tui_display_registers_from_line, tui_check_register_values):
 215         Update.
 216         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 217         member.
 218         (struct tui_data_window) <regs_content>: Now a std::vector.
 219         <regs_content_count>: Remove.
 220         (tui_add_content_elements, tui_free_data_content): Don't declare.
 221         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 222         (init_content_element): Remove DATA_WIN case.  Add assert.
 223         (tui_add_content_elements): Remove.
 224         (tui_data_window): Update.
 225         (tui_free_data_content): Remove.
 226         (free_content_elements): Remove DATA_WIN case.
 227
 228 2019-06-25  Tom Tromey  <tom@tromey.com>
 229
 230         * tui/tui-data.c (tui_data_item_window): Update.
 231         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 232         * tui/tui-windata.c (tui_display_all_data)
 233         (tui_display_data_from_line): Update.
 234         (tui_check_data_values): Remove.
 235         * tui/tui-regs.c (tui_show_register_group)
 236         (tui_display_reg_element_at_line): Update.
 237         * tui/tui-hooks.c (tui_register_changed)
 238         (tui_refresh_frame_and_register_information): Call
 239         tui_check_register_values.
 240         * tui/tui-data.h (struct tui_data_window) <data_content,
 241         data_content_count, data_type>: Remove.
 242         (enum tui_data_type): Remove.
 243
 244         * tui/tui-data.c (tui_data_window::clear_detail)
 245         (~tui_data_window): Update.
 246
 247 2019-06-25  Tom Tromey  <tom@tromey.com>
 248
 249         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 250         declare.
 251         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 252         Rename from tui_first_data_item_displayed.  Update.
 253         (tui_data_window::refresh_all)
 254         (tui_data_window::do_scroll_vertical): Update.
 255         * tui/tui-data.h (struct tui_data_window)
 256         <first_data_item_displayed>: Declare new method.
 257
 258 2019-06-25  Tom Tromey  <tom@tromey.com>
 259
 260         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 261         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 262         contents...
 263         (tui_initialize_static_data): ...here.
 264
 265 2019-06-25  Tom Tromey  <tom@tromey.com>
 266
 267         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 268         (tui_display_registers_from, tui_check_register_values): Update.
 269         (tui_display_register): Remove win_info parameter; update.
 270         (tui_get_register): Change type of parameters.
 271         * tui/tui-data.h (struct tui_data_element): Remove.
 272         (union tui_which_element) <data>: Remove.
 273         <data_window>: Change type.
 274         (struct tui_data_item_window): New.
 275         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 276         case.  Add assert.
 277         (~tui_data_item_window): New destructor.
 278         (free_content_elements): Remove DATA_ITEM_WIN case.
 279
 280 2019-06-25  Tom Tromey  <tom@tromey.com>
 281
 282         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 283         Remove.
 284
 285 2019-06-25  Tom Tromey  <tom@tromey.com>
 286
 287         * tui/tui-data.h (struct tui_command_element): Remove.
 288         (union tui_which_element) <command>: Remove.
 289         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 290         assert.
 291         (free_content_elements): Remove CMD_WIN case.
 292
 293 2019-06-25  Tom Tromey  <tom@tromey.com>
 294
 295         * tui/tui-layout.c (tui_set_layout): Update.
 296         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 297         * tui/tui-data.c (layout_def): Update.
 298
 299 2019-06-25  Tom Tromey  <tom@tromey.com>
 300
 301         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 302         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 303         (tui_source_window_base::set_new_height): Update.
 304         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 305         Update.
 306         (tui_set_locator_fullname, tui_set_locator_info)
 307         (tui_show_frame_info): Update.
 308         * tui/tui-source.c (tui_set_source_content)
 309         (tui_source_is_displayed): Update.
 310         * tui/tui-layout.c (show_source_disasm_command, show_data)
 311         (show_source_or_disasm_and_command): Update.
 312         * tui/tui-disasm.c (tui_set_disassem_content)
 313         (tui_get_begin_asm_address): Update.
 314         * tui/tui-data.h (struct tui_locator_element): Remove.
 315         (union tui_which_element) <locator>: Remove.
 316         (struct tui_locator_window): New.
 317         (tui_locator_win_info_ptr): Change return type.
 318         * tui/tui-data.c (_locator): Change type.
 319         (tui_locator_win_info_ptr): Change return type.
 320         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 321         (tui_alloc_content): Add assert.
 322
 323 2019-06-25  Tom Tromey  <tom@tromey.com>
 324
 325         * tui/tui-winsource.c
 326         (tui_exec_info_window::maybe_allocate_content): New method.
 327         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 328         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 329         (make_source_or_disasm_window): Add cast.
 330         * tui/tui-data.h (union tui_which_element) <simple_string>:
 331         Remove.
 332         (struct tui_source_info): New.
 333         (struct tui_source_window_base) <execution_info>: Change type.
 334         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 335         case, and add assert.
 336         (tui_alloc_content): Add assert.
 337
 338 2019-06-25  Tom Tromey  <tom@tromey.com>
 339
 340         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 341         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 342         * tui/tui-data.c (tui_alloc_win_info): Remove.
 343
 344 2019-06-25  Tom Tromey  <tom@tromey.com>
 345
 346         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 347         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 348         can_highlight.
 349
 350 2019-06-25  Tom Tromey  <tom@tromey.com>
 351
 352         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 353         make_visible_with_new_height method.
 354         (tui_win_info::make_visible_with_new_height): New method.
 355         (tui_source_window_base::do_make_visible_with_new_height)
 356         (tui_data_window::do_make_visible_with_new_height)
 357         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 358         (make_visible_with_new_height): Remove.
 359         (tui_resize_all, tui_adjust_win_heights): Use
 360         make_visible_with_new_height method.
 361         * tui/tui-data.h (struct tui_win_info)
 362         <do_make_visible_with_new_height, make_visible_with_new_height>:
 363         New methods.
 364         (struct tui_source_window_base, struct tui_data_window)
 365         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 366         methods.
 367
 368 2019-06-25  Tom Tromey  <tom@tromey.com>
 369
 370         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 371         method.
 372         (update_tab_width): Call update_tab_width method.
 373         * tui/tui-data.h (struct tui_win_info)
 374         (struct tui_source_window_base) <update_tab_width>: New methods.
 375
 376 2019-06-25  Tom Tromey  <tom@tromey.com>
 377
 378         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 379         parameter.
 380         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 381         parameter.
 382         (tui_gen_win_info::make_visible): Update.
 383         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 384         parameter.
 385         * tui/tui-data.h (enum tui_box): New enum.
 386         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 387
 388 2019-06-25  Tom Tromey  <tom@tromey.com>
 389
 390         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 391         init_and_make_win for EXEC_INFO_WIN.
 392         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 393         longer inline.
 394         (struct tui_win_info) <~tui_win_info>: Inline.
 395         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 396         Don't declare.
 397         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 398         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 399         Remove.
 400         (tui_initialize_static_data): Update.
 401         (~tui_gen_win_info): Handle more cleanup here.
 402         (~tui_source_window_base): Delete "execution_info".
 403         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 404
 405 2019-06-25  Tom Tromey  <tom@tromey.com>
 406
 407         * tui/tui-layout.c (make_command_window): Don't set
 408         can_highlight.
 409         (show_source_disasm_command): Call the reset method.
 410         (show_data): Don't set can_highlight.  Call the reset method.
 411         (tui_gen_win_info::reset): Rename from init_gen_win_info
 412         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 413         (show_source_or_disasm_and_command): Call the reset method.
 414         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 415         (struct tui_cmd_window): Set can_highlight.
 416
 417 2019-06-25  Tom Tromey  <tom@tromey.com>
 418
 419         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 420         from make_visible.
 421         (tui_make_visible, tui_make_invisible): Rewrite.
 422         (tui_win_info::make_visible): Remove.
 423         (tui_source_window_base::make_visible): Update.
 424         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 425         method.  Moved from...
 426         (struct tui_win_info) <make_visible>: ...here.
 427
 428 2019-06-25  Tom Tromey  <tom@tromey.com>
 429
 430         * tui/tui-winsource.c
 431         (tui_source_window_base::do_scroll_horizontal): Remove direction
 432         parameter.
 433         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 434         direction parameter.
 435         * tui/tui-win.c (tui_win_info::forward_scroll)
 436         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 437         (tui_win_info::right_scroll): Update.
 438         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 439         direction parameter.
 440         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 441         direction parameter.
 442         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 443         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 444         Remove direction parameter.
 445         (struct tui_source_window_base, struct tui_source_window)
 446         (struct tui_disasm_window, struct tui_data_window)
 447         (struct tui_cmd_window): Update.
 448
 449 2019-06-25  Tom Tromey  <tom@tromey.com>
 450
 451         * tui/tui-winsource.h (tui_set_exec_info_content)
 452         (tui_show_exec_info_content, tui_erase_exec_info_content)
 453         (tui_clear_exec_info_content, tui_update_exec_info): Change
 454         argument to tui_source_window_base.
 455         * tui/tui-winsource.c (tui_set_exec_info_content)
 456         (tui_show_exec_info_content, tui_erase_exec_info_content)
 457         (tui_clear_exec_info_content, tui_update_exec_info): Change
 458         argument to tui_source_window_base.
 459
 460 2019-06-25  Tom Tromey  <tom@tromey.com>
 461
 462         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
 463         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
 464
 465 2019-06-25  Tom Tromey  <tom@tromey.com>
 466
 467         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 468         check.
 469
 470 2019-06-25  Tom Tromey  <tom@tromey.com>
 471
 472         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
 473         type to void.
 474         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
 475         type to void.
 476         * tui/tui-source.c (tui_set_source_content): Update.
 477         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 478
 479 2019-06-25  Tom Tromey  <tom@tromey.com>
 480
 481         * tui/tui-win.c (window_name_completer, tui_set_focus)
 482         (tui_all_windows_info): Use name method.
 483         * tui/tui-data.h (struct tui_gen_win_info)
 484         (struct tui_source_window, struct tui_disasm_window)
 485         (struct tui_data_window, struct tui_cmd_window) <name>: New
 486         method.
 487         (tui_win_name): Don't declare.
 488         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
 489         (tui_win_name): Remove.
 490
 491 2019-06-25  Tom Tromey  <tom@tromey.com>
 492
 493         * tui/tui-winsource.h (tui_update_source_window)
 494         (tui_update_source_window_as_is): Change parameter type.
 495         * tui/tui-winsource.c (tui_update_source_window): Change win_info
 496         to be a tui_source_window_base.
 497         (tui_update_source_window_as_is): Likewise.
 498         * tui/tui-win.c (make_visible_with_new_height): Update.
 499
 500 2019-06-25  Tom Tromey  <tom@tromey.com>
 501
 502         * tui/tui-winsource.c (tui_erase_source_content)
 503         (tui_show_source_content, tui_show_exec_info_content)
 504         (tui_erase_exec_info_content): Use refresh_window method.
 505         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
 506         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
 507         from tui_refresh_win.
 508         (tui_data_window::refresh_window): New method.
 509         (tui_win_info::refresh, tui_source_window_base::refresh)
 510         (tui_refresh_all): Use refresh_window method.
 511         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
 512         method.
 513         * tui/tui-regs.c (tui_display_register): Call refresh_window
 514         method.
 515         * tui/tui-layout.c (show_source_disasm_command)
 516         (show_source_or_disasm_and_command): Call refresh_window method.
 517         * tui/tui-data.h (struct tui_gen_win_info)
 518         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
 519         New method.
 520
 521 2019-06-25  Tom Tromey  <tom@tromey.com>
 522
 523         * tui/tui.c (tui_rl_other_window, tui_enable)
 524         (tui_is_window_visible, tui_get_command_dimension): Update.
 525         * tui/tui-winsource.c (tui_update_source_window_as_is)
 526         (tui_clear_source_content, tui_erase_source_content)
 527         (tui_show_source_line, tui_source_window_base::refill)
 528         (tui_source_window_base::do_scroll_horizontal)
 529         (tui_source_window_base::set_is_exec_point_at)
 530         (tui_update_breakpoint_info, tui_set_exec_info_content)
 531         (tui_alloc_source_buffer, tui_line_is_displayed)
 532         (tui_addr_is_displayed): Update.
 533         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 534         (tui_check_and_display_highlight_if_needed)
 535         (tui_win_info::make_visible, tui_win_info::refresh)
 536         (tui_refresh_all): Update.
 537         * tui/tui-windata.c (tui_first_data_item_displayed)
 538         (tui_delete_data_content_windows, tui_erase_data_content)
 539         (tui_display_all_data, tui_data_window::refresh_all)
 540         (tui_check_data_values): Update.
 541         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
 542         (tui_set_win_focus_to, tui_win_info::forward_scroll)
 543         (tui_win_info::backward_scroll, tui_refresh_all_win)
 544         (tui_resize_all, tui_set_focus, tui_all_windows_info)
 545         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
 546         (tui_source_window_base::set_new_height)
 547         (tui_data_window::set_new_height)
 548         (make_invisible_and_set_new_height)
 549         (make_visible_with_new_height, new_height_ok)
 550         (parse_scrolling_args): Update.
 551         * tui/tui-stack.c (tui_show_frame_info): Update.
 552         * tui/tui-source.c (tui_set_source_content)
 553         (tui_set_source_content_nil, tui_source_is_displayed)
 554         (tui_source_window::do_scroll_vertical): Update.
 555         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 556         (tui_display_registers_from, tui_display_reg_element_at_line)
 557         (tui_check_register_values, tui_reg_command): Update.
 558         * tui/tui-layout.c (tui_default_win_height)
 559         (show_source_disasm_command, show_data, init_and_make_win)
 560         (show_source_or_disasm_and_command): Update.
 561         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 562         (tui_redisplay_readline, tui_mld_flush)
 563         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
 564         (tui_getc): Update.
 565         * tui/tui-disasm.c (tui_set_disassem_content)
 566         (tui_disasm_window::do_scroll_vertical): Update.
 567         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
 568         Now virtual.
 569         (struct tui_win_info): Derive from tui_gen_win_info.
 570         <~tui_win_info>: Mark as override.
 571         <generic>: Remove member.
 572         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
 573         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
 574         (~tui_data_window, ~tui_win_info)
 575         (tui_free_all_source_wins_content): Update.
 576         * tui/tui-command.c (tui_refresh_cmd_win): Update.
 577
 578 2019-06-25  Tom Tromey  <tom@tromey.com>
 579
 580         * tui/tui-layout.c (init_and_make_win): Use new.
 581         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
 582         destructor, initializers.
 583         (tui_alloc_generic_win_info): Don't declare.
 584         * tui/tui-data.c (_locator): Add argument to constructor.
 585         (source_win, disasm_win): New globals.
 586         (exec_info): Remove.
 587         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 588         Update.
 589         (tui_alloc_generic_win_info): Remove.
 590         (init_content_element): Use new.
 591         (tui_win_info::tui_win_info): Update.
 592         (free_content_elements) <case DATA_WIN>: Use delete.
 593
 594 2019-06-25  Tom Tromey  <tom@tromey.com>
 595
 596         * tui/tui-wingeneral.c (tui_refresh_win): Update.
 597         * tui/tui-windata.c (tui_first_data_item_displayed)
 598         (tui_delete_data_content_windows): Update.
 599         * tui/tui-win.c (tui_data_window::set_new_height): Update.
 600         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 601         (tui_display_registers_from, tui_check_register_values): Update.
 602         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
 603         pointer.
 604         * tui/tui-data.c (init_content_element): Update.  Allocate the new
 605         window.
 606         (tui_free_data_content): Update.
 607         (free_content_elements) <case DATA_WIN>: Free the window.
 608
 609 2019-06-25  Tom Tromey  <tom@tromey.com>
 610
 611         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
 612         Update.
 613         * tui/tui-layout.c (make_command_window)
 614         (show_source_disasm_command, show_data, init_and_make_win)
 615         (show_source_or_disasm_and_command): Update.
 616         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
 617         method.
 618         <can_highight, is_highlighted>: Now bool.
 619         (tui_set_win_highlight): Don't declare.
 620         * tui/tui-data.c (tui_set_win_highlight): Remove.
 621
 622 2019-06-25  Tom Tromey  <tom@tromey.com>
 623
 624         * tui/tui-wingeneral.c (make_visible): Remove check of window
 625         type.
 626
 627 2019-06-25  Tom Tromey  <tom@tromey.com>
 628
 629         * tui/tui-win.c (tui_win_info::max_height)
 630         (tui_cmd_window::max_height): New methods.
 631         (new_height_ok): Call max_height.
 632         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
 633         <max_height>: New method.
 634
 635 2019-06-25  Tom Tromey  <tom@tromey.com>
 636
 637         * tui/tui-win.c (tui_source_window_base::set_new_height)
 638         (tui_data_window::set_new_height): New methods.
 639         (make_invisible_and_set_new_height): Call set_new_height method.
 640         * tui/tui-data.h (struct tui_win_info)
 641         (struct tui_source_window_base, struct tui_data_window)
 642         <set_new_height>: New method.
 643
 644 2019-06-25  Tom Tromey  <tom@tromey.com>
 645
 646         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
 647         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
 648         tui_refresh_data_win.
 649         * tui/tui-win.c (tui_source_window_base::refresh_all): New
 650         method.
 651         (tui_refresh_all_win): Call the refresh_all method.
 652         (tui_set_focus): Likewise.
 653         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
 654         (struct tui_source_window_base, struct tui_data_window) <refresh>:
 655         Likewise.
 656
 657 2019-06-25  Tom Tromey  <tom@tromey.com>
 658
 659         * tui/tui-winsource.h (tui_refill_source_window)
 660         (tui_set_is_exec_point_at): Don't declare.
 661         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 662         (tui_source_window_base::refill): Rename from
 663         tui_refill_source_window.
 664         (tui_source_window_base::do_scroll_horizontal): Update.
 665         (tui_source_window_base::set_is_exec_point_at): Rename from
 666         tui_set_is_exec_point_at.
 667         (tui_update_all_breakpoint_info): Update.
 668         * tui/tui-stack.c (tui_show_frame_info): Update.
 669         * tui/tui-layout.c (show_data): Add cast.
 670         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
 671         * tui/tui-data.h (struct tui_source_window_base) <refill,
 672         set_is_exec_point_at>: New methods.
 673         (tui_source_windows, tui_add_to_source_windows): Update types.
 674         (tui_add_to_source_windows): Remove redundant declaration.
 675         * tui/tui-data.c (source_windows): Store tui_source_window_base.
 676         (tui_source_windows): Change return type.
 677         (tui_clear_source_windows_detail): Update.
 678         (tui_add_to_source_windows): Change type of parameter.
 679         (tui_free_all_source_wins_content): Update.
 680
 681 2019-06-25  Tom Tromey  <tom@tromey.com>
 682
 683         * tui/tui-wingeneral.c (tui_win_info::refresh)
 684         (tui_source_window_base::refresh): New methods.
 685         (tui_refresh_all): Call the refresh method.
 686         * tui/tui-data.h (struct tui_win_info)
 687         (struct tui_source_window_base) <refresh>: New method.
 688
 689 2019-06-25  Tom Tromey  <tom@tromey.com>
 690
 691         * tui/tui.h (tui_is_window_visible): Return bool.
 692         * tui/tui.c (tui_is_window_visible): Return bool.
 693         * tui/tui-wingeneral.c (tui_make_window, make_visible)
 694         (tui_make_visible, tui_make_invisible)
 695         (tui_win_info::make_visible)
 696         (tui_source_window_base::make_visible, make_all_visible)
 697         (tui_make_all_visible, tui_make_all_invisible): Update.
 698         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
 699         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
 700         bool.
 701         (struct tui_win_info, struct tui_source_window_base)
 702         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
 703         * tui/tui-data.c (tui_init_generic_part): Update.
 704
 705 2019-06-25  Tom Tromey  <tom@tromey.com>
 706
 707         * tui/tui-wingeneral.c (tui_win_info::make_visible)
 708         (tui_source_window_base::make_visible): New methods.
 709         (make_all_visible): Make method call.
 710         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
 711         (struct tui_source_window_base, struct tui_cmd_window): Override
 712         make_visible.
 713         (tui_win_is_source_type): Don't declare.
 714         * tui/tui-data.c (tui_win_is_source_type): Remove.
 715
 716 2019-06-25  Tom Tromey  <tom@tromey.com>
 717
 718         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
 719         NULL check.
 720
 721 2019-06-25  Tom Tromey  <tom@tromey.com>
 722
 723         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 724         Inline constructor.  Add initializers for members.
 725         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 726         constructors; now inline in class.
 727
 728 2019-06-25  Tom Tromey  <tom@tromey.com>
 729
 730         * tui/tui-regs.c (tui_show_registers): Update.
 731         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 732         bool.
 733         * tui/tui-data.c (tui_data_window::clear_detail)
 734         (tui_data_window): Update.
 735
 736 2019-06-25  Tom Tromey  <tom@tromey.com>
 737
 738         * tui/tui-windata.c (tui_display_all_data)
 739         (tui_display_data_from_line, tui_display_data_from)
 740         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 741         Update.
 742         * tui/tui-regs.c (tui_last_regs_line_no)
 743         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 744         (tui_show_registers, tui_show_register_group)
 745         (tui_display_registers_from, tui_display_reg_element_at_line)
 746         (tui_display_registers_from_line, tui_check_register_values)
 747         (tui_reg_next, tui_reg_prev): Update.
 748         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 749         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 750         tui_data_window.
 751         (struct tui_win_info) <detail>: Remove.  Add new fields from
 752         tui_data_info.
 753         (TUI_DATA_WIN): Add cast.
 754         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 755         (~tui_data_window): Simplify.
 756
 757 2019-06-25  Tom Tromey  <tom@tromey.com>
 758
 759         * tui/tui-layout.c (show_source_disasm_command)
 760         (show_source_or_disasm_and_command): Update.
 761         * tui/tui-io.c (update_cmdwin_start_line)
 762         (tui_redisplay_readline): Update.
 763         * tui/tui-data.h (struct tui_command_info): Remove.
 764         (struct tui_win_info) <detail>: Remove command_info member.
 765         (struct tui_data_window) <start_line>: New member, from
 766         tui_command_info.
 767         (TUI_CMD_WIN): Add casts.
 768
 769 2019-06-25  Tom Tromey  <tom@tromey.com>
 770
 771         * tui/tui-winsource.c (tui_update_source_window)
 772         (tui_refill_source_window)
 773         (tui_source_window_base::do_scroll_horizontal)
 774         (tui_update_breakpoint_info, tui_set_exec_info_content)
 775         (tui_show_exec_info_content, tui_erase_exec_info_content)
 776         (tui_clear_exec_info_content): Update.
 777         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 778         Update.
 779         * tui/tui-win.c (make_invisible_and_set_new_height)
 780         (make_visible_with_new_height): Update.
 781         * tui/tui-source.c (tui_set_source_content)
 782         (tui_show_symtab_source): Update.
 783         * tui/tui-layout.c (extract_display_start_addr)
 784         (show_source_disasm_command, show_data)
 785         (make_source_or_disasm_window)
 786         (show_source_or_disasm_and_command): Update.
 787         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 788         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 789         "gdbarch".
 790         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 791         to tui_source_window_base.
 792         (struct tui_win_info) <detail>: Remove source_info member.
 793         (struct tui_source_window_base) <has_locator>: Inline.
 794         Move contents from tui_source_info; rename has_locator member to
 795         m_has_locator.
 796         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 797         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 798         header file.
 799         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 800         Simplify.
 801         (tui_free_all_source_wins_content): Cast to
 802         tui_source_window_base.
 803
 804 2019-06-25  Tom Tromey  <tom@tromey.com>
 805
 806         * tui/tui-win.c (make_invisible_and_set_new_height)
 807         (make_visible_with_new_height): Call has_locator method.
 808         * tui/tui-layout.c (show_source_disasm_command, show_data)
 809         (show_source_or_disasm_and_command): Update for bool change.
 810         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 811         (tui_win_info) <has_locator>: New method.
 812         (struct tui_source_window_base) <has_locator>: New method.
 813         (tui_win_has_locator): Don't declare.
 814         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 815         from tui_win_has_locator.
 816         (tui_source_window_base): Use false, not FALSE.
 817
 818 2019-06-25  Tom Tromey  <tom@tromey.com>
 819
 820         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 821         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 822         clear_detail method directly.
 823         (tui_clear_win_detail): Remove.
 824
 825 2019-06-25  Tom Tromey  <tom@tromey.com>
 826
 827         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 828         "this", not TUI_DISASM_WIN.
 829
 830 2019-06-25  Tom Tromey  <tom@tromey.com>
 831
 832         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 833         declare.
 834         * tui/tui-winsource.c
 835         (tui_source_window_base::do_scroll_horizontal): Rename from
 836         tui_horizontal_source_scroll.
 837         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 838         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 839         from tui_vertical_data_scroll.
 840         * tui/tui-win.h (tui_scroll): Don't declare.
 841         * tui/tui-win.c (tui_win_info::forward_scroll)
 842         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 843         (tui_win_info::right_scroll): Rename and update.
 844         (tui_scroll_forward_command, tui_scroll_backward_command)
 845         (tui_scroll_left_command, tui_scroll_right_command): Update.
 846         (tui_scroll): Remove.
 847         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 848         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 849         from tui_vertical_source_scroll.
 850         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 851         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 852         from tui_vertical_disassem_scroll.
 853         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 854         do_scroll_horizontal>: New methods.
 855         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 856         Likewise.
 857         (struct tui_source_window_base): Add do_scroll_horizontal.
 858         (struct tui_source_window, struct tui_disasm_window): Add
 859         do_scroll_vertical.
 860         (struct tui_data_window, struct tui_cmd_window): Add
 861         do_scroll_horizontal and do_scroll_vertical.
 862         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 863
 864 2019-06-25  Tom Tromey  <tom@tromey.com>
 865
 866         * tui/tui-data.h (struct tui_source_window_base): New struct.
 867         (struct tui_source_window): Derive from tui_source_window_base.
 868         (struct tui_disasm_window): New struct.
 869         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 870         from tui_source_window::clear_detail.
 871         (tui_source_window_base): Rename from tui_source_window.
 872         (~tui_source_window_base): Rename from ~tui_source_window.
 873         (tui_alloc_win_info): Create a tui_disasm_window.
 874
 875 2019-06-25  Tom Tromey  <tom@tromey.com>
 876
 877         * tui/tui-data.h (struct tui_source_window)
 878         (struct tui_data_window): Declare destructors.
 879         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 880         destructors.
 881         (tui_win_info): Simplify.
 882
 883 2019-06-25  Tom Tromey  <tom@tromey.com>
 884
 885         * tui/tui-winsource.c (tui_display_main)
 886         (tui_update_source_windows_with_addr)
 887         (tui_update_all_breakpoint_info): Update.
 888         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 889         (new_height_ok, parse_scrolling_args): Update.
 890         * tui/tui-stack.c (tui_show_frame_info): Update.
 891         * tui/tui-data.h (struct tui_list): Remove.
 892         (tui_source_windows): Return a reference to a std::vector.
 893         * tui/tui-data.c (source_windows): Now a std::vector.
 894         (tui_source_windows): Change return type.
 895         (tui_clear_source_windows): Rewrite.
 896         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 897         (tui_free_all_source_wins_content): Rewrite.
 898
 899 2019-06-25  Tom Tromey  <tom@tromey.com>
 900
 901         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 902         (struct tui_data_window, struct tui_cmd_window): Declare
 903         clear_detail method.
 904         * tui/tui-data.c (tui_source_window::clear_detail)
 905         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 906         methods.
 907         (tui_clear_win_detail): Simplify.
 908
 909 2019-06-25  Tom Tromey  <tom@tromey.com>
 910
 911         * tui/tui-layout.c (make_source_window, make_disasm_window)
 912         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 913         Return the new window.
 914         (show_source_disasm_command, show_data)
 915         (show_source_or_disasm_and_command): Update.
 916
 917 2019-06-25  Tom Tromey  <tom@tromey.com>
 918
 919         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 920         parameter.  Return the new window.
 921         (show_source_disasm_command): Update and remove NULL check.
 922         (show_source_or_disasm_and_command): Update.
 923
 924 2019-06-25  Tom Tromey  <tom@tromey.com>
 925
 926         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 927
 928 2019-06-25  Tom Tromey  <tom@tromey.com>
 929
 930         * tui/tui-data.h (struct tui_win_info): Make constructor
 931         protected.  Make destructor virtual.  Add initializers.
 932         (tui_source_window, tui_data_window, tui_cmd_window): New
 933         classes.
 934         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 935         constructor.  Add "type" parameter.
 936         (tui_source_window, tui_data_window, tui_cmd_window): New
 937         constructors.
 938         (tui_alloc_win_info): Instantiate the appropriate subclass.
 939
 940 2019-06-25  Tom Tromey  <tom@tromey.com>
 941
 942         * tui/tui-win.c (tui_resize_all): Use delete.
 943         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 944         destructor.
 945         (tui_free_window): Don't declare.
 946         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 947         Update.
 948
 949 2019-06-25  Tom Tromey  <tom@tromey.com>
 950
 951         * tui/tui-data.h (struct tui_win_info): Add constructor.
 952         * tui/tui-data.c (tui_alloc_win_info): Use new.
 953         (tui_free_window): Use delete.
 954
 955 2019-06-22  Tom Tromey  <tom@tromey.com>
 956
 957         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 958         declare.
 959         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 960
 961 2019-06-22  Tom Tromey  <tom@tromey.com>
 962
 963         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 964         declare.
 965         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 966
 967 2019-06-22  Tom de Vries  <tdevries@suse.de>
 968
 969         * dwarf2read.c (create_addrmap_from_aranges)
 970         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 971         instead of '%zu'.
 972
 973 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 974
 975         * dwarf2read.h (dwarf2_section_info_def): Remove.
 976         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 977         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 978         std::vector<dwarf2_section_info>.
 979         (struct dwo_file) <~dwo_file>: Remove.
 980         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 981         types field.
 982         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 983         (dwarf2_read_debug_names): Likewise.
 984         (create_debug_types_hash_table): Change parameter type to
 985         array_view, adjust code accordingly.
 986         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 987         (partial_die_info::fixup): Likewise.
 988         (determine_prefix): Likewise.
 989         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 990
 991 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 992
 993         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 994         gdb_bfd_ref_ptr.
 995         <~dwo_file>: Remove call to gdb_bfd_unref.
 996         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 997         gdb_bfd_ref_ptr::get.
 998
 999 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1000
1001         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1002         type to htab_up.
1003         * dwarf2read.c (struct dwo_file): Initialize fields.
1004         <~dwo_file>: New.
1005         (free_dwo_file): Remove, move content to ~dwo_file.
1006         (struct dwo_file_deleter): Remove.
1007         (dwo_file_up>: Remove custom deleter.
1008         (free_dwo_files): Remove.
1009         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1010         dwo_files.
1011         (process_skeletonless_type_units): Call unique_ptr::get.
1012         (allocate_dwo_file_hash_table): Add deleter to created hash
1013         table.  Change return type to htab_up.
1014         (lookup_dwo_file_slot): Don't memset dwo_file, call
1015         unique_ptr::get.
1016         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1017         (create_dwo_unit_in_dwp_v2): Likewise.
1018         (open_and_init_dwo_file): Likewise.
1019         (free_dwo_file_from_slot): Remove.
1020
1021 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1022
1023         * dwarf2read.h (struct dwarf2_section_info) <readin,
1024         is_virtual>: Change type to bool.
1025         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1026         true instead of 1.
1027
1028 2019-06-19  Tom Tromey  <tom@tromey.com>
1029
1030         * tui/tui-data.h (tui_init_content_element): Don't declare.
1031
1032 2019-06-19  Tom Tromey  <tom@tromey.com>
1033
1034         * tui/tui-data.h (tui_init_win_info): Don't declare.
1035
1036 2019-06-19  Tom de Vries  <tdevries@suse.de>
1037
1038         * dwarf2read.h (abstract_to_concrete): Change type to
1039         std::unordered_map<sect_offset, std::vector<sect_offset>,
1040         gdb::hash_enum<sect_offset>>.
1041
1042 2019-06-19  Tom Tromey  <tromey@adacore.com>
1043
1044         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1045         EVAL_AVOID_SIDE_EFFECTS specially.
1046
1047 2019-06-19  Tom Tromey  <tromey@adacore.com>
1048
1049         * source-cache.c (highlighter): New global.
1050         (source_cache::get_source_lines): Create a highlighter on demand.
1051
1052 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1053
1054         * defs.h (deprecated_interactive_hook): Delete declaration.
1055         * interps.c (clear_interpreter_hooks): Remove use of
1056         deprecated_interactive_hook.
1057         * top.c (deprecated_interactive_hook): Delete definition.
1058         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1059
1060 2019-06-18  Tom de Vries  <tdevries@suse.de>
1061
1062         PR gdb/24515
1063         * dwarf2read.h (abstract_to_concrete): Change type from
1064         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1065         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1066         * dwarf2read.c (read_variable): Update.
1067         (dwarf2_fetch_die_loc_sect_off): Update.
1068
1069 2019-06-17  Tom de Vries  <tdevries@suse.de>
1070
1071         PR gdb/24617
1072         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1073         accessing parent[parent_len - 1].
1074
1075 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1076
1077         PR gdb/24364
1078         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1079         call dtrace_process_dof with NULL dof.
1080
1081 2019-06-16  Tom de Vries  <tdevries@suse.de>
1082
1083         PR gdb/24445
1084         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1085
1086 2019-06-16  Tom Tromey  <tom@tromey.com>
1087
1088         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1089         (make_all_visible): Use address of member.
1090
1091 2019-06-16  Tom Tromey  <tom@tromey.com>
1092
1093         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1094         (tui_free_window, free_content, free_content_elements): Remove
1095         unnecessary cast.
1096         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1097         cast.
1098         * tui/tui-regs.c (tui_show_register_group)
1099         (tui_display_registers_from, tui_display_reg_element_at_line):
1100         Remove unnecessary cast.
1101
1102 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1103
1104         * linux-nat.c (normal_mask): Delete.
1105         (_initialize_linux_nat): Don't initialise normal_mask.
1106
1107 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1108
1109         PR gdb/24445
1110         * dwarf-index-write.h (write_psymtabs_to_index): Add
1111         dwz_basename parameter.
1112         * dwarf-index-write.c (write_gdbindex): Move file writing to
1113         write_gdbindex_1.  Change return type void.
1114         (assert_file_size): Move up, remove filename parameter.
1115         (write_gdbindex_1): New function.
1116         (write_debug_names): Change return type to void, call
1117         assert_file_size.
1118         (struct index_wip_file): New struct.
1119         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1120         file logic to index_wip_file.  Write index for dwz file if
1121         needed.
1122         (save_gdb_index_command): Pass basename of dwz file, if present.
1123         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1124         build-id of dwz file, if present.
1125         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1126         (dwarf2_get_dwz_file): Likewise.
1127         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1128         (dwarf2_get_dwz_file): Likewise.
1129
1130 2019-06-16  Tom Tromey  <tom@tromey.com>
1131
1132         * coffread.c (process_coff_symbol): Use xstrdup.
1133         * value.c (create_internalvar): Use xstrdup.
1134
1135 2019-06-16  Tom Tromey  <tom@tromey.com>
1136
1137         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1138         * breakpoint.c (stopin_command, stopat_command)
1139         (until_break_command, decode_location_default): Remove unnecessary
1140         cast.
1141         * utils.c (subset_compare): Remove unnecessary cast.
1142         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1143         cast.
1144         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1145         cast.
1146         * infcmd.c (path_command): Remove unnecessary cast.
1147         * coffread.c (decode_type): Remove unnecessary cast.
1148         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1149         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1150         * tui/tui-stack.c (tui_show_locator_content)
1151         (tui_show_frame_info): Remove unnecessary cast.
1152         * tui/tui-win.c (tui_scroll_forward_command)
1153         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1154         (parse_scrolling_args): Remove unnecessary cast.
1155         * tui/tui-data.c (init_win_info, tui_del_window)
1156         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1157         (free_content_elements): Remove unnecessary cast.
1158         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1159         unnecessary cast.
1160         * tui/tui-source.c (tui_set_source_content)
1161         (tui_vertical_source_scroll): Remove unnecessary cast.
1162         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1163         cast.
1164         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1165         * tui/tui-regs.c (tui_display_registers_from)
1166         (tui_display_register): Remove unnecessary cast.
1167         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1168         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1169         (make_visible): Remove unnecessary cast.
1170         * tui/tui-winsource.c (tui_erase_source_content)
1171         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1172         unnecessary cast.
1173         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1174         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1175         * stabsread.c (read_type, read_array_type, read_range_type):
1176         Remove unnecessary cast.
1177         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1178         (parse_symbol, parse_type, upgrade_type, parse_external)
1179         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1180         unnecessary cast.
1181         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1182
1183 2019-06-16  Tom Tromey  <tom@tromey.com>
1184
1185         * tui/tui-data.c (tui_alloc_generic_win_info)
1186         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1187         checks.
1188
1189 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1190             Andrew Burgess  <andrew.burgess@embecosm.com>
1191
1192         * f-typeprint.c (f_print_type): Don't return early for not
1193         associated or not allocated types.
1194         (f_type_print_varspec_suffix): Add print_rank parameter and print
1195         ranks of array types in case they dangling.
1196         (f_type_print_base): Add print_rank parameter.
1197
1198 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1199
1200         * NEWS: Mention new MI commands.
1201         * break-catch-throw.c (enum exception_event_kind): Move to
1202         breakpoint.h.
1203         (print_mention_exception_catchpoint): Output text as a single
1204         message.
1205         (catch_exception_command_1): Rename to...
1206         (catch_exception_event): ...this, make non-static, update header
1207         command, and change some parameter types.
1208         (catch_catch_command): Update for changes to
1209         catch_exception_command_1.
1210         (catch_throw_command): Likewise.
1211         (catch_rethrow_command): Likewise.
1212         * breakpoint.c (enum exception_event_kind): Delete.
1213         * breakpoint.h (enum exception_event_kind): Moved here from
1214         break-catch-throw.c.
1215         (catch_exception_event): Declare.
1216         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1217         (mi_cmd_catch_throw): New function.
1218         (mi_cmd_catch_rethrow): New function.
1219         (mi_cmd_catch_catch): New function.
1220         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1221         'catch-catch' entries.
1222         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1223         (mi_cmd_catch_rethrow): Declare.
1224         (mi_cmd_catch_catch): Declare.
1225
1226 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1227
1228         * annotate.c (annotate_source_line): Change return type to void,
1229         update implementation to match.
1230         * annotate.h (annotate_source_line): Change return type to void,
1231         update header comment.
1232         * stack.c (print_frame_info): Don't change what frame information
1233         is printed based on whether annotations are on or not.
1234
1235 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1236
1237         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1238         (annotate_source): Make static.
1239         (annotate_source_line): Moved from source.c and renamed from
1240         identify_source_line.  Update the return type.
1241         * annotate.h (annotate_source): Delete declaration.
1242         (annotate_source_line): Declaration moved from source.h, and
1243         renamed from identify_source_line.  Return type updated.
1244         * source.c (identify_source_line): Moved to annotate.c and renamed
1245         to annotate_source_line.
1246         (info_line_command): Remove check of annotation_level.
1247         * source.h (identify_source_line): Move declaration to annotate.h
1248         and rename to annotate_source_line.
1249         * stack.c: Add 'annotate.h' include.
1250         (print_frame_info): Remove check of annotation_level before
1251         calling annotate_source_line.
1252
1253 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1254
1255         * source-cache.c (source_cache::get_plain_source_lines): Use
1256         open_source_file_with_line_charpos instead of just
1257         open_source_file, remove call to find_source_lines.
1258         (source_cache::get_source_lines): Likewise.
1259         * source.c (find_source_lines): Make static.
1260         (get_filename_and_charpos): Renamed into...
1261         (open_source_file_with_line_charpos): ..this along with changes to
1262         return a scoped_fd, and some other minor clean ups.
1263         (identify_source_line): Use open_source_file_with_line_charpos.
1264         (search_command_helper): Use open_source_file_with_line_charpos
1265         instead of just open_source_file, remove call to
1266         find_source_lines.
1267         * source.h (open_source_file_with_line_charpos): Declare new
1268         function.
1269         (find_source_lines): Delete declaration.
1270
1271 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1272
1273         * source.c (get_filename_and_charpos): Remove fullname
1274         parameter.
1275         (identify_source_line): Update call to get_filename_and_charpos.
1276
1277 2019-06-14  Tom Tromey  <tromey@adacore.com>
1278
1279         PR gdb/24502:
1280         * ui-style.h (skip_ansi_escape): Update comment.
1281         * ui-file.h (class no_terminal_escape_file): New class.
1282         * ui-file.c (no_terminal_escape_file::write)
1283         (no_terminal_escape_file::puts): New methods.
1284         * cli/cli-logging.c (handle_redirections): Use
1285         no_terminal_escape_file.
1286
1287 2019-06-14  Tom Tromey  <tromey@adacore.com>
1288
1289         * NEWS: Move convenience variable news above Python news.
1290
1291 2019-06-14  Tom Tromey  <tom@tromey.com>
1292
1293         * gnulib: Move directory to top-level.
1294         * configure.ac: Don't configure gnulib.
1295         * configure: Rebuild.
1296         * common/common-defs.h: Use new path to gnulib.
1297         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1298         (GNULIB_H): Remove.
1299         (INCGNU): Look in new gnulib location.
1300         (HFILES_NO_SRCDIR): Remove gnulib files.
1301         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1302         (generated_files): Remove GNULIB_H.
1303         ($(LIBGNU), all-lib): Remove targets.
1304         (distclean): Don't mention GNULIB_BUILDDIR.
1305         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1306
1307 2019-06-14  Tom Tromey  <tromey@adacore.com>
1308
1309         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1310         Warn if symbol file does not provide any symbols.
1311
1312 2019-06-14  Tom Tromey  <tromey@adacore.com>
1313
1314         * source.c (find_and_open_source): Respect basenames_may_differ.
1315
1316 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1317
1318         * annotate.c (annotate_breakpoints_invalid): Make use of
1319         scoped_restore_terminal_state.
1320         (annotate_frames_invalid): Likewise.
1321
1322 2019-06-14  Tom Tromey  <tromey@adacore.com>
1323
1324         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1325         allow assignment to an internalvar.
1326
1327 2019-06-14  Tom Tromey  <tromey@adacore.com>
1328
1329         * ada-lex.l: Allow "_" in attribute names.
1330
1331 2019-06-14  Tom Tromey  <tromey@adacore.com>
1332
1333         PR gdb/24653:
1334         * regcache.c (registers_changed): Don't call alloca.
1335         * top.c (execute_command): Don't call alloca.
1336
1337 2019-06-13  Pedro Alves  <palves@redhat.com>
1338
1339         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1340         'expression'.  When parsing an expression, error out if there's
1341         junk after "unlimited".
1342         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1343         (do_set_command): Adjust calls to is_unlimited_literal.
1344
1345 2019-06-13  Pedro Alves  <palves@redhat.com>
1346
1347         * compile/compile.c (make_compile_options_def_group): Add braces
1348         around array_view initializer.
1349         * thread.c (make_thread_apply_all_options_def_group)
1350         (make_thread_apply_all_options_def_group): Likewise.
1351
1352 2019-06-13  Pedro Alves  <palves@redhat.com>
1353
1354         * NEWS (New commands): Mention "maint test-options
1355         require-delimiter", "maint test-options unknown-is-error", "maint
1356         test-options unknown-is-operand" and "maint show
1357         test-options-completion-result".
1358         (New command options, command completion): New section.
1359         (Completion improvements): New section.
1360         Mention that you can abbreviate "unlimited".
1361
1362 2019-06-13  Pedro Alves  <palves@redhat.com>
1363
1364         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1365         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1366         * unittests/cli-utils-selftests.c (test_parse_flags)
1367         (test_parse_flags_qcs): Delete.
1368         (test_cli_utils): Don't call deleted functions.
1369
1370 2019-06-13  Pedro Alves  <palves@redhat.com>
1371
1372         * thread.c: Include "cli/cli-option.h".
1373         (tp_array_compar_ascending): Global.
1374         (tp_array_compar): Delete function.
1375         (tp_array_compar_ascending, tp_array_compar_descending): New
1376         functions.
1377         (ascending_option_def, qcs_flag_option_def)
1378         (thr_qcs_flags_option_defs)
1379         (make_thread_apply_all_options_def_group)
1380         (make_thread_apply_options_def_group): New.
1381         (thread_apply_all_command): Use gdb::option::process_options.
1382         (thread_apply_command_completer)
1383         (thread_apply_all_command_completer): New.
1384         (thread_apply_command): Use gdb::option::process_options.
1385         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1386         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1387         to generate help text of "thread apply".  Adjust "taas"'s help.
1388         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1389         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1390
1391 2019-06-13  Pedro Alves  <palves@redhat.com>
1392
1393         * thread.c (thread_apply_command): Check for invalid TID with
1394         isdigit instead of !isalpha.
1395
1396 2019-06-13  Pedro Alves  <palves@redhat.com>
1397
1398         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1399         (validate_flags_qcs): New.
1400         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1401         (validate_flags_qcs): Declare.
1402         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1403         (make_frame_apply_options_def_group): New.
1404         (frame_apply_command_count): Process options with
1405         gdb::option::process_options.
1406         (frame_apply_completer): New.
1407         (frame_apply_level_completer, frame_apply_all_completer)
1408         (frame_apply_completer): New.
1409         (_initialize_stack): Update help of "frame apply", "frame apply
1410         level", "frame apply all" and "faas" to mention supported options
1411         and install command completers.
1412         * stack.h (frame_apply_all_completer): Declare.
1413         * thread.c: Include "stack.h".
1414         (tfaas_command): Add "--".
1415         (_initialize_thread): Update help "tfaas" to mention supported
1416         options and install command completer.
1417
1418 2019-06-13  Pedro Alves  <palves@redhat.com>
1419
1420         * completer.c (complete_nested_command_line): New.
1421         (gdb_completion_word_break_characters_throw): Add assertion.
1422         * completer.h (complete_nested_command_line): Declare.
1423
1424 2019-06-13  Pedro Alves  <palves@redhat.com>
1425
1426         * stack.c (parse_backtrace_qualifiers): New.
1427         (backtrace_command): Use it.
1428         (backtrace_command_completer): Complete on qualifiers.
1429
1430 2019-06-13  Pedro Alves  <palves@redhat.com>
1431
1432         * frame.c: Include "cli/cli-option.h.
1433         (user_set_backtrace_options): New.
1434         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1435         Delete.
1436         (get_prev_frame): Adjust.
1437         (boolean_option_def, uinteger_option_def)
1438         (set_backtrace_option_defs): New.
1439         (_initialize_frame): Adjust and use
1440         gdb::option::add_setshow_cmds_for_options to install "set
1441         backtrace past-main" and "set backtrace past-entry".
1442         * frame.h: Include "cli/cli-option.h".
1443         (struct frame_print_options): Forward declare.
1444         (print_frame_arguments_all, print_frame_arguments_scalars)
1445         (print_frame_arguments_none): Declare.
1446         (print_entry_values): Delete declaration.
1447         (struct frame_print_options, user_frame_print_options): New.
1448         (struct set_backtrace_options): New.
1449         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1450         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1451         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1452         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1453         (list_args_or_locals): Add frame_print_options parameter.
1454         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1455         * python/py-framefilter.c (enumerate_args): Pass down
1456         USER_FRAME_PRINT_OPTIONS.
1457         * stack.c: Include "cli/cli-option.h".
1458         (print_frame_arguments_all, print_frame_arguments_scalars)
1459         (print_frame_arguments_none): Declare.
1460         (print_raw_frame_arguments, print_entry_values): Delete.
1461         (user_frame_print_options): New.
1462         (boolean_option_def, enum_option_def, frame_print_option_defs):
1463         New.
1464         (struct backtrace_cmd_options): New.
1465         (bt_flag_option_def): New.
1466         (backtrace_command_option_defs): New.
1467         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1468         (print_frame_arg, read_frame_arg, print_frame_args)
1469         (print_frame_info, print_frame): Add frame_print_options parameter
1470         and use it.
1471         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1472         (backtrace_command_1): Add frame_print_options and
1473         backtrace_cmd_options parameters and use them.
1474         (make_backtrace_options_def_group): New.
1475         (backtrace_command): Process command options with
1476         gdb::option::process_options.
1477         (backtrace_command_completer): New.
1478         (_initialize_stack): Extend "backtrace"'s help to mention
1479         supported options.  Install completer for "backtrace".
1480         Install some settings commands with add_setshow_cmds_for_options.
1481
1482 2019-06-13  Pedro Alves  <palves@redhat.com>
1483
1484         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1485         and that "set/show print raw frame-arguments" are now deprecated.
1486
1487         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1488         command.
1489         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1490         * stack.c (_initialize_stack): Install "set/show print
1491         raw-frame-arguments", and deprecate "set/show print raw
1492         frame-arguments".
1493         * valprint.c (_initialize_valprint): Deprecate "set/show print
1494         raw".
1495
1496 2019-06-13  Pedro Alves  <palves@redhat.com>
1497
1498         * compile/compile.c (struct compile_options): New.
1499         (compile_flag_option_def, compile_command_option_defs)
1500         (make_compile_options_def_group): New.
1501         (compile_file_command): Handle options with
1502         gdb::option::process_options.
1503         (compile_file_command_completer): New function.
1504         (compile_code_command): Handle options with
1505         gdb::option::process_options.
1506         (compile_code_command_completer): New function.
1507         (_initialize_compiler): Install completers for "compile code" and
1508         "compile file".  Mention available options in "compile code" and
1509         "compile code"'s help.
1510         * completer.c (advance_to_completion_word): New, factored out from
1511         ...
1512         (advance_to_expression_complete_word_point): ... this.
1513         (advance_to_filename_complete_word_point): New.
1514         * completer.h (advance_to_filename_complete_word_point): New
1515         declaration.
1516
1517 2019-06-13  Pedro Alves  <palves@redhat.com>
1518
1519         * compile/compile.c: Include "cli/cli-option.h".
1520         (compile_print_value): Scope data pointer is now a
1521         value_print_options pointer; adjust.
1522         (compile_print_command): Process options.  Scope data pointer is
1523         now a value_print_options pointer; adjust.
1524         (_initialize_compile): Update "compile print"'s help to include
1525         supported options.  Install a completer for "compile print".
1526         * cp-valprint.c (show_vtblprint, show_objectprint)
1527         (show_static_field_print): Delete.
1528         (_initialize_cp_valprint): Don't install "set print
1529         static-members", "set print vtbl", "set print object" here.
1530         * printcmd.c: Include "cli/cli-option.h" and
1531         "common/gdb_optional.h".
1532         (print_command_parse_format): Rework to fill in a
1533         value_print_options instead of a format_data.
1534         (print_value): Change parameter type from format_data pointer to
1535         value_print_options reference.  Adjust.
1536         (print_command_1): Process options.  Adjust to pass down a
1537         value_print_options.
1538         (print_command_completer): New.
1539         (_initialize_printcmd): Install print_command_completer as
1540         handle_brkchars completer for the "print" command.  Update
1541         "print"'s help to include supported options.
1542         * valprint.c: Include "cli/cli-option.h".
1543         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1544         here from cp-valprint.c.
1545         (boolean_option_def, uinteger_option_def)
1546         (value_print_option_defs, make_value_print_options_def_group):
1547         New.  Use gdb::option::add_setshow_cmds_for_options to install
1548         "set print elements", "set print null-stop", "set print repeats",
1549         "set print pretty", "set print union", "set print array", "set
1550         print address", "set print symbol", "set print array-indexes".
1551         * valprint.h: Include <string> and "cli/cli-option.h".
1552         (make_value_print_options_def_group): Declare.
1553         (print_value): Change parameter type from format_data pointer to
1554         value_print_options reference.
1555         (print_command_completer): Declare.
1556
1557 2019-06-13  Pedro Alves  <palves@redhat.com>
1558
1559         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1560         (COMMON_SFILES): Add maint-test-settings.c.
1561         * cli/cli-decode.c (boolean_enums): New global, factored out from
1562         ...
1563         (add_setshow_boolean_cmd): ... here.
1564         * cli/cli-decode.h (boolean_enums): Declare.
1565         * cli/cli-option.c: New file.
1566         * cli/cli-option.h: New file.
1567         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1568         factored out from ...
1569         (parse_cli_boolean_value(const char *)): ... this.
1570         (is_unlimited_literal): Change parameter type to pointer to
1571         pointer.  Adjust and advance ARG pointer.
1572         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1573         (parse_cli_var_enum): New, factored out from ...
1574         (do_set_command): ... this.  Adjust.
1575         * cli/cli-setshow.h (parse_cli_boolean_value)
1576         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1577         (parse_cli_var_enum): Declare.
1578         * cli/cli-utils.c: Include "cli/cli-option.h".
1579         (get_ulongest): New.
1580         * cli/cli-utils.h (get_ulongest): Declare.
1581         (check_for_argument): New overloads.
1582         * maint-test-options.c: New file.
1583
1584 2019-06-13  Pedro Alves  <palves@redhat.com>
1585
1586         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1587         parse a range if "-" is at the end of the string.
1588
1589 2019-06-13  Pedro Alves  <palves@redhat.com>
1590
1591         * cli/cli-setshow.c (parse_auto_binary_operation)
1592         (parse_cli_boolean_value): Don't allow "o".
1593
1594 2019-06-13  Pedro Alves  <palves@redhat.com>
1595
1596         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1597         * NEWS: Mention maint test-settings KIND.
1598         * maint-test-settings.c: New file.
1599
1600 2019-06-13  Pedro Alves  <palves@redhat.com>
1601
1602         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1603         completer.
1604         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1605         "set" completers.
1606
1607 2019-06-13  Pedro Alves  <palves@redhat.com>
1608
1609         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1610         after item.
1611
1612 2019-06-13  Pedro Alves  <palves@redhat.com>
1613
1614         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1615
1616 2019-06-13  Pedro Alves <palves@redhat.com>
1617
1618         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1619         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1620         call.
1621         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1622         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1623         calls.
1624         (check_for_argument): Skip spaces after argument.
1625
1626 2019-06-13  Pedro Alves  <palves@redhat.com>
1627
1628         * thread.c (thread_apply_command): Adjust TID parsing.
1629         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1630         detected before end of string.
1631         (tid_is_in_list): Error out if LIST is invalid.
1632
1633 2019-06-13  Pedro Alves  <palves@redhat.com>
1634
1635         * completer.c (complete_line_internal_1): Rewind completion word
1636         point.
1637         (completion_tracker::advance_custom_word_point_by): Change
1638         parameter type to int.
1639         * completer.h (completion_tracker::advance_custom_word_point_by):
1640         Likewise.
1641
1642 2019-06-13  Pedro Alves  <palves@redhat.com>
1643
1644         * completer.c (advance_to_completion_word): Handle delimiters.
1645
1646 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1647
1648         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1649
1650 2019-06-11  Tom Tromey  <tom@tromey.com>
1651
1652         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1653         (xmalloc_failed): Move to alloc.c.
1654         * alloc.c: New file.
1655         * Makefile.in (COMMON_SFILES): Add alloc.c.
1656
1657 2019-06-11  Tom Tromey  <tom@tromey.com>
1658
1659         * nat/linux-waitpid.c: Don't include server.h.
1660         (linux_debug): Remove.
1661         (my_waitpid): Update.
1662
1663 2019-06-11  Tom Tromey  <tromey@adacore.com>
1664
1665         * infcall.c (_initialize_infcall): Remove trailing newline from
1666         help.
1667         * user-regs.c (_initialize_user_regs): Remove trailing newline
1668         from help.
1669         * typeprint.c (_initialize_typeprint): Remove trailing newline
1670         from help.
1671         * reverse.c (_initialize_reverse): Remove trailing newlines from
1672         help.
1673         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1674         from help.
1675         * language.c (add_set_language_command): Remove trailing newline
1676         from help.
1677         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1678         help.
1679         * disasm.c (_initialize_disasm): Remove trailing newline from
1680         help.
1681         * top.c (init_main): Remove trailing newline from help.
1682         * interps.c (_initialize_interpreter): Remove trailing newline
1683         from help.
1684         * btrace.c (_initialize_btrace): Remove trailing newlines from
1685         help.
1686         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1687         from help.
1688         * python/python.c (_initialize_python): Remove trailing newline
1689         from help.
1690         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1691         help.
1692         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1693         from help.  Reformat some text.
1694         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1695         from help.
1696         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1697         newline from help.
1698
1699 2019-06-11  Tom Tromey  <tromey@adacore.com>
1700
1701         * darwin-nat.c (darwin_decode_exception_message)
1702         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1703
1704 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1705
1706         * valops.c (value_slice): Check for not allocated or not
1707         associated values.
1708
1709 2019-06-10  Tom de Vries  <tdevries@suse.de>
1710
1711         PR gdb/24618
1712         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1713         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1714         invalid.
1715
1716 2019-06-10  Tom de Vries  <tdevries@suse.de>
1717
1718         PR gdb/24611
1719         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1720         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1721
1722 2019-06-10  Tom de Vries  <tdevries@suse.de>
1723
1724         PR symtab/24545
1725         * symtab.c (struct demangled_name_entry): Add language field.
1726         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1727         static minimal symbol".  Set and use language field.
1728
1729 2019-06-10  Tom Tromey  <tromey@adacore.com>
1730
1731         * ada-lang.c (_initialize_ada_language): Update help text.
1732
1733 2019-06-10  Tom Tromey  <tromey@adacore.com>
1734
1735         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1736         with a newline.
1737         * guile/guile.c (handle_boot_error): Don't end warning with a
1738         newline.
1739         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1740         warning with a newline.
1741         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1742         newline.
1743         (s12z_frame_cache): Likewise.
1744         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1745         a newline.
1746         * solib-svr4.c (disable_probes_interface): Don't end warning with
1747         a newline.
1748         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1749         newline.
1750         * python/python.c (do_finish_initialization): Don't end warning
1751         with a newline.
1752
1753 2019-06-10  Tom Tromey  <tom@tromey.com>
1754
1755         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1756         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1757         gdbpy_enter.
1758
1759 2019-06-10  Tom Tromey  <tromey@adacore.com>
1760
1761         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1762         data.
1763         (elf_new_init): Don't call stabsread_new_init.
1764         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1765         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1766         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1767
1768 2019-06-10  Tom de Vries  <tdevries@suse.de>
1769
1770         PR symtab/16264
1771         PR symtab/24517
1772         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1773
1774 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1775
1776         * source.c (find_and_open_source): Also rewrite relative file
1777         names.
1778
1779 2019-04-26  Amos Bird  <amosbird@gmail.com>
1780
1781         * annotate.c (annotate_thread_exited): Add "thread-exited"
1782         annotation.
1783
1784 2019-06-06  Tom Tromey  <tromey@adacore.com>
1785
1786         * maint.h (class scoped_command_stats): Use
1787         DISABLE_COPY_AND_ASSIGN.
1788         <print_time>: New method.
1789         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1790         print_time.
1791         (scoped_command_stats::print_time): New method.
1792
1793 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1794
1795         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1796         instructions of lengths 6 or 8 bytes.
1797
1798 2019-06-04  Pedro Alves  <palves@redhat.com>
1799
1800         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1801
1802         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1803         * breakpoint.c (condition_completer): Likewise.
1804         * cli/cli-dump.c (scan_expression): Likewise.
1805         * common/filestuff.c (mkdir_recursive): Likewise.
1806         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1807         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1808         (gdb_abspath): Likewise.
1809         * compile/compile-cplus-types.c
1810         (compile_cplus_instance::decl_name): Likewise.
1811         * completer.c (complete_explicit_location):
1812         (signal_completer, reg_or_group_completer_1): Likewise.
1813         * cp-support.c (cp_remove_params_if_any): Likewise.
1814         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1815         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1816         * infcmd.c (strip_bg_char): Likewise.
1817         * linespec.c (copy_token_string): Likewise.
1818         * mi/mi-main.c (output_cores): Likewise.
1819         * psymtab.c (psymtab_search_name):
1820         * symfile.c (test_set_ext_lang_command): Likewise.
1821         * target.c (target_fileio_read_stralloc): Likewise.
1822         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1823         * value.c (complete_internalvar): Likewise.
1824
1825 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1826
1827         Add objfile property to gdb.Type.
1828         * NEWS: Mention Python API addition.
1829         * python/py-type.c (typy_get_objfile): New method.
1830
1831 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1832
1833         * NEWS: Mention the new set|show style [title|highlight].
1834         Mention changes to "show style", "help" and "apropos".
1835
1836 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1837
1838         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1839         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1840         instead of print_help_for_command.
1841         (print_doc_of_command): New function.
1842         (help_list): Add 'apropos -v word' suggestion.
1843         (print_help_for_command): Style the command name using title style.
1844         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1845         (_initialize_cli_cmds): Describe -v in apropos_command help.
1846
1847 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1848
1849         * cli/cli-style.h (cli_style_option): Add name in constructor,
1850         add m_name class member, add constructor with intensity,
1851         add name class function.
1852         (cli_style_option::add_setshow_commands): Remove name argument.
1853         (highlight_style, title_style): New styles.
1854         * cli/cli-style.c (do_show): New function that shows a style
1855         characteristic styling the style name with itself.
1856         (set_style_name): New function.
1857         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1858         Update all callers according to the changes in cli/cli-style.h.
1859         * utils.h (fputs_highlighted): New function.
1860         * utils.c (fputs_highlighted): Likewise.
1861
1862 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1863
1864         * NEWS: Mention new pipe command and new convenience variables.
1865
1866 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1867
1868         * cli/cli-cmds.c (pipe_command): New function.
1869         (_initialize_cli_cmds): Call add_com for pipe_command.
1870         Define | as an alias for pipe.
1871         (exit_status_set_internal_vars): New function.
1872         (shell_escape): Call exit_status_set_internal_vars.
1873         cli/cli-decode.c (find_command_name_length): Recognize | as
1874         a single character command.
1875
1876 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1877
1878         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1879         top.c (execute_command_to_ui_file): New function, mostly a copy
1880         of execute_command_to_string.
1881         (execute_command_to_string): Implement by calling
1882         execute_command_to_ui_file.
1883
1884 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1885
1886         * top.h (saved_command_line): Remove declaration.
1887         * top.c (previous_saved_command_line, previous_repeat_arguments):
1888         New variables.
1889         (saved_command_line): Make static, define together with other
1890         'repeat variables'.
1891         (dont_repeat): Clear repeat_arguments.
1892         (repeat_previous, get_saved_command_line, save_command_line):
1893         New functions.
1894         (gdb_init): Initialize saved_command_line
1895         and previous_saved_command_line.
1896         * main.c (captured_main_1): Remove saved_command_line initialization.
1897         * event-top.c (handle_line_of_input): Update to use
1898         the new 'repeat' related functions instead of direct access to
1899         saved_command_line.
1900         * command.h (repeat_previous, get_saved_command_line,
1901         save_command_line): New declarations.
1902         (dont_repeat): Add comment.
1903
1904 2019-05-30  Tom Tromey  <tromey@adacore.com>
1905
1906         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1907         Fix comment.
1908         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1909
1910 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1911
1912         PR cli/24587
1913         * completer.c (complete): Initialize variable word.
1914
1915 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1916
1917         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1918         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1919         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1920         'body' is NULL to the outter 'if', protecting the '!is_define'
1921         situation as well.
1922
1923 2019-05-29  Tom Tromey  <tromey@adacore.com>
1924
1925         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1926         (dwarf_unknown): New function.
1927         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1928         (dwarf_type_encoding_name): Use dwarf_unknown.
1929
1930 2019-05-29  Tom Tromey  <tromey@adacore.com>
1931
1932         PR c++/20020:
1933         * cp-valprint.c (cp_print_value_fields): Call
1934         cp_print_static_field inside "try".
1935
1936 2019-05-29  Tom Tromey  <tromey@adacore.com>
1937
1938         * inflow.c (struct terminal_info): Add default operator=.
1939         * configure: Rebuild.
1940         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1941         -Wdeprecated-copy-dtor, -Wredundant-move.
1942
1943 2019-05-29  Tom Tromey  <tromey@adacore.com>
1944
1945         * NEWS: Add entry.
1946         * infcmd.c (print_return_value_1): Handle finish_print
1947         option.
1948         (show_print_finish): New function.
1949         (_initialize_infcmd): Add "set/show print finish" commands.
1950         * valprint.c (user_print_options): Initialize new member.
1951         * valprint.h (struct value_print_options) <finish_print>: New
1952         member.
1953
1954 2019-05-28  Tom Tromey  <tromey@adacore.com>
1955
1956         * ada-lang.c (ada_remove_Xbn_suffix)
1957         (find_old_style_renaming_symbol)
1958         (parse_old_style_renaming): Remove.
1959         (ada_find_renaming_symbol): Don't call
1960         find_old_style_renaming_symbol.
1961         (ada_is_renaming_symbol): Rename from
1962         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1963         bool.  Now static.
1964         (ada_read_var_value): Update and simplify.
1965         * ada-exp.y (write_var_or_type): Remove old code.
1966
1967 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1968
1969         * event-top.c: Remove include comment.
1970         * inflow.c (class scoped_ignore_sigttou): Move from here...
1971         * inflow.h (class scoped_ignore_sigttou): ...to here.
1972         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1973         * top.c:  Remove include comment.
1974
1975 2019-05-27  Tom Tromey  <tom@tromey.com>
1976
1977         * NEWS: Fix typo.
1978
1979 2019-05-22  Tom Tromey  <tromey@adacore.com>
1980
1981         * target.c (target_follow_exec): Constify parameter.
1982         * target-delegates.c: Rebuild.
1983         * remote.c (remote_target::follow_exec): Constify parameter.
1984         * infrun.c (follow_exec): Constify parameter.
1985         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1986         (target_follow_exec): Likewise.
1987
1988 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1989
1990         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1991         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1992
1993 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1994
1995         * NEWS: Add debugredirect and testsuite sections.
1996
1997 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1998
1999         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2000         target descriptions using exclusively floating point register name
2001         aliases.
2002
2003 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2004
2005         PR gdb/18644:
2006         * f-lang.c (build_fortran_types): Handle the case where
2007         gdbarch_floatformat_for_type returns a nullptr.
2008
2009 2019-05-21  Tom de Vries  <tdevries@suse.de>
2010
2011         PR cli/24587
2012         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2013
2014 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2015
2016         PR gdb/18644:
2017         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2018         16-byte floats.
2019         * i386-tdep.c (i386_floatformat_for_type): Use
2020         floatformats_ia64_quad for the 16-byte floating point component
2021         within a fortran 32-byte complex number.
2022
2023 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2024
2025         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2026         delete default constructor.
2027         (find_partial_die): Update to return const struct.
2028         (partial_die_parent_scope): Move variable declaration into scope
2029         of its use and change its type to auto.
2030         (guess_partial_die_structure_name): Likewise.
2031         (partial_die_info::fixup): Likewise.
2032
2033 2019-05-17  Tom Tromey  <tromey@adacore.com>
2034
2035         * source.c (find_and_open_source): Remove cast.
2036
2037 2019-05-17  Tom Tromey  <tromey@adacore.com>
2038
2039         * annotate.c (annotate_source): Make "filename" const.
2040         * annotate.h (annotate_source): Use const.
2041
2042 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2043
2044         * disasm.c (set_disassembler_options): Send errors to stderr.
2045
2046 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2047
2048         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2049         (cli_interp_base::set_logging): Check debug_redirect.
2050         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2051         * cli/cli-logging.c (debug_redirect): Add static variable.
2052         (pop_output_files): Add default param.
2053         (handle_redirections): Print debug setting.
2054         (show_logging_command): Likewise.
2055         (_initialize_cli_logging): Add debugredirect command.
2056         * interps.c (current_interp_set_logging): Add debug_redirect
2057         parameter.
2058         * interps.h (set_logging): Add debug_redirect parameter.
2059         (current_interp_set_logging): Likewise.
2060         * mi/mi-common.h: Likewise.
2061         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2062
2063 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2064             Tom Tromey  <tromey@adacore.com>
2065
2066         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2067         directly.
2068         * cli/cli-interp.h (make_logging_output): Remove declaration.
2069         * cli/cli-logging.c (make_logging_output): Remove function.
2070         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2071         directly.
2072         * ui-file.c (tee_file::tee_file): Remove bools.
2073         (tee_file::~tee_file): Remove deletes.
2074         * ui-file.h (tee_file): Remove bools.
2075
2076 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2077
2078         * mi/mi-cmds.h (mi_cmd_complete): New function.
2079         * mi/mi-main.c (mi_cmd_complete): Likewise.
2080         * mi/mi-cmds.c: Define new MI command -complete.
2081         * NEWS: Mention new -complete command.
2082
2083 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2084
2085         * completer.h (complete): New function.
2086         * completer.c (complete): Likewise.
2087         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2088         function defined in completer.h.
2089
2090 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2091
2092         * MAINTAINERS (Write After Approval): Add myself.
2093
2094 2019-05-17  Tom de Vries  <tdevries@suse.de>
2095
2096         PR gdb/24094
2097         * dwarf2read.c (struct cu_partial_die_info): New struct.
2098         (find_partial_die): Return cu_partial_die_info.
2099         (partial_die_parent_scope, guess_partial_die_structure_name)
2100         (partial_die_info::fixup): Handle new return type of find_partial_die.
2101
2102 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2103
2104         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2105         "std::string", simplifying the algorithm.
2106
2107 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2108
2109         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2110         (stap_static_probe_ops::get_probes): Likewise.
2111
2112 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2113
2114         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2115         '-')" and "else if".
2116         (stap_parse_single_operand): Join checks for
2117         "gdbarch_stap_parse_special_token_p" and
2118         "gdbarch_stap_parse_special_token" in the same "if" statement.
2119         Invert check when verifying for operation on register
2120         displacement.
2121
2122 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2123
2124         * stap-probe.c (stap_get_opcode): Update comment.
2125         (stap_get_expected_argument_type): Likewise.
2126         (handle_stap_probe): Likewise.
2127
2128 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2129
2130         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2131         return type to 'bool'.  Adjust comment.  Use 'bool' when
2132         appropriate.
2133         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2134         * stap-probe.c (stap_parse_argument_1): Likewise.
2135         (stap_is_operator): Likewise.
2136         (stap_is_generic_prefix): Likewise.
2137         (stap_is_register_prefix): Likewise.
2138         (stap_is_register_indirection_prefix): Likewise.
2139         (stap_is_integer_prefix): Likewise.
2140         (stap_generic_check_suffix): Likewise.
2141         (stap_check_integer_suffix): Likewise.
2142         (stap_check_register_suffix): Likewise.
2143         (stap_check_register_indirection_suffix): Likewise.
2144         (stap_parse_register_operand): Likewise.
2145         (stap_parse_single_operand): Likewise.
2146         (stap_parse_argument_1): Likewise.
2147         (stap_probe::get_argument_count): Likewise.
2148         (stap_is_operator): Likewise.
2149
2150 2019-05-16  Tom Tromey  <tromey@adacore.com>
2151
2152         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2153         keyword to foreach.
2154
2155 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2156
2157         * linux-thread-db.c (try_thread_db_load_1): Change return type
2158         to bool.
2159         (try_thread_db_load): Likewise.
2160         (try_thread_db_load_from_pdir_1): Likewise.
2161         (try_thread_db_load_from_pdir): Likewise.
2162         (try_thread_db_load_from_sdir): Likewise.
2163         (try_thread_db_load_from_dir): Likewise.
2164         (thread_db_load_search): Likewise.
2165         (has_libpthread): Likewise.
2166         (thread_db_load): Likewise.
2167
2168 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2169
2170         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2171         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2172         NULL, and complain/return if that's the case.
2173
2174 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2175
2176         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2177         (advance, posn, abstract_read_memory): New functions.
2178         [struct mem_read_abstraction]: New struct.
2179         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2180
2181 2019-05-14  Tom Tromey  <tromey@adacore.com>
2182
2183         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2184         value is not lval_memory.
2185
2186 2019-05-14  Tom Tromey  <tromey@adacore.com>
2187
2188         * solib.c (info_sharedlibrary_command): Style the file name.
2189
2190 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2191
2192         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2193         (aarch64_vnv_type): Likewise.
2194         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2195         * common/tdesc.c: Likewise.
2196         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2197         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2198         * features/aarch64-fpu.xml: Add ieee half view.
2199         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2200         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2201         * gdbtypes.h (struct builtin_type): Likewise.
2202         (struct objfile_type): Likewise.
2203
2204 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2205
2206         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2207         typo.
2208         * location.h (string_to_event_location): Likewise.
2209
2210 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2211
2212         GDB 8.3 released.
2213
2214 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2215
2216         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2217         New variable declaration.
2218         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2219         New variable.
2220         (print_one_breakpoint): Use ui_out::test_flags and new global
2221         variable to compute use_fixed_output.
2222         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2223         Remove.
2224         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2225         (mi_multi_location_breakpoint_output_fixed): Remove.
2226         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2227         new variable.
2228         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2229         fix_multi_location_breakpoint_output flag if version >= 3.
2230         * ui-out.h (enum ui_out_flag)
2231         <fix_multi_location_breakpoint_output>: New enumerator.
2232
2233 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2234
2235         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2236
2237 2019-05-10  Tom Tromey  <tromey@adacore.com>
2238
2239         * ada-lang.c (catch_ada_completer): New function.
2240         (_initialize_ada_language): Use it.
2241
2242 2019-05-10  Tom Tromey  <tromey@adacore.com>
2243
2244         * thread.c (print_thread_info): Make "requested_threads" const.
2245         * gdbthread.h (print_thread_info): Make "requested_threads"
2246         const.
2247         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2248         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2249
2250 2019-05-08  Tom Tromey  <tom@tromey.com>
2251
2252         * gdbtypes.c (objfile_type_data): Change type.
2253         (objfile_type, _initialize_gdbtypes): Update.
2254
2255 2019-05-08  Tom Tromey  <tom@tromey.com>
2256
2257         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2258         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2259         (_initialize_dwarf2_frame): Update.
2260
2261 2019-05-08  Tom Tromey  <tom@tromey.com>
2262
2263         * objc-lang.c (objc_objfile_data): Change type.
2264         (find_methods): Update.
2265         (_initialize_objc_lang): Remove.
2266
2267 2019-05-08  Tom Tromey  <tom@tromey.com>
2268
2269         * stabsread.c (rs6000_builtin_type_data): Change type.
2270         (rs6000_builtin_type, _initialize_stabsread): Update.
2271
2272 2019-05-08  Tom Tromey  <tom@tromey.com>
2273
2274         * mips-tdep.c (mips_pdr_data): Remove.
2275         (_initialize_mips_tdep): Update.
2276
2277 2019-05-08  Tom Tromey  <tom@tromey.com>
2278
2279         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2280         (hppa_init_objfile_priv_data, read_unwind_info)
2281         (find_unwind_entry, _initialize_hppa_tdep): Update.
2282
2283 2019-05-08  Tom Tromey  <tom@tromey.com>
2284
2285         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2286         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2287         on obstack.
2288         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2289
2290 2019-05-08  Tom Tromey  <tom@tromey.com>
2291
2292         * mdebugread.c (basic_type_data): Change type.
2293         (basic_type, _initialize_mdebugread): Update.
2294
2295 2019-05-08  Tom Tromey  <tom@tromey.com>
2296
2297         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2298
2299 2019-05-08  Tom Tromey  <tom@tromey.com>
2300
2301         * nto-tdep.c (nto_inferior_data_reg): Change type.
2302         (nto_inferior_data): Update.
2303         (nto_inferior_data_cleanup, nto_new_inferior_data)
2304         (_initialize_nto_tdep): Remove.
2305         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2306
2307 2019-05-08  Tom Tromey  <tom@tromey.com>
2308
2309         * ada-lang.c (struct ada_inferior_data): Add initializers.
2310         (ada_inferior_data): Change type.
2311         (ada_inferior_data_cleanup): Remove.
2312         (get_ada_inferior_data, ada_inferior_exit)
2313         (struct ada_pspace_data): Add initializers, destructor.
2314         (ada_pspace_data_handle): Change type.
2315         (get_ada_pspace_data): Update.
2316         (ada_pspace_data_cleanup): Remove.
2317
2318 2019-05-08  Tom Tromey  <tom@tromey.com>
2319
2320         * coffread.c (struct coff_symfile_info): Add initializers.
2321         (coff_objfile_data_key): Move lower.  Change type.
2322         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2323         Update.
2324         (coff_free_info): Remove.
2325
2326 2019-05-08  Tom Tromey  <tom@tromey.com>
2327
2328         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2329         (fbsd_pspace_data_handle): Move lower.  Change type.
2330         (get_fbsd_pspace_data): Update.
2331         (fbsd_pspace_data_cleanup): Remove.
2332         (_initialize_fbsd_tdep): Update.
2333
2334 2019-05-08  Tom Tromey  <tom@tromey.com>
2335
2336         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2337         (get_ada_tasks_pspace_data): Update.
2338         (ada_tasks_pspace_data_cleanup): Remove.
2339         (_initialize_tasks): Update.
2340         (ada_tasks_inferior_data_handle): Change type.
2341         (get_ada_tasks_inferior_data): Update.
2342         (ada_tasks_inferior_data_cleanup): Remove.
2343         (struct ada_tasks_pspace_data): Add initializers.
2344
2345 2019-05-08  Tom Tromey  <tom@tromey.com>
2346
2347         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2348         * symfile-debug.c (debug_sym_get_probes): Change type.
2349         * stap-probe.c (handle_stap_probe):
2350         (stap_static_probe_ops::get_probes): Change type.
2351         * probe.h (class static_probe_ops) <get_probes>: Change type.
2352         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2353         (parse_probes_in_pspace): Update.
2354         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2355         Update.
2356         (any_static_probe_ops::get_probes): Change type.
2357         * elfread.c (elfread_data): New typedef.
2358         (probe_key): Change type.
2359         (elf_get_probes): Likewise.  Update.
2360         (probe_key_free): Remove.
2361         (_initialize_elfread): Update.
2362         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2363         Change type.
2364         (dtrace_process_dof_probe, dtrace_process_dof)
2365         (dtrace_static_probe_ops::get_probe): Change type.
2366
2367 2019-05-08  Tom Tromey  <tom@tromey.com>
2368
2369         * xcoffread.c (struct xcoff_symfile_info): Rename from
2370         coff_symfile_info.  Add initializers.
2371         (xcoff_objfile_data_key): Move lower.  Change type.
2372         (XCOFF_DATA): Rewrite.
2373         (xcoff_free_info): Remove.
2374         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2375         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2376         (xcoff_initial_scan): Update.
2377
2378 2019-05-08  Tom Tromey  <tom@tromey.com>
2379
2380         * solib-svr4.c (struct svr4_info): Add initializers and
2381         destructor.
2382         <probes_table>: Now an htab_up.
2383         (solib_svr4_pspace_data): Change type.
2384         (free_probes_table): Simplify.
2385         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2386         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2387         (probes_table_remove_objfile_probes, register_solib_event_probe)
2388         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2389         (_initialize_svr4_solib): Update.
2390
2391 2019-05-08  Tom Tromey  <tom@tromey.com>
2392
2393         * remote.c (remote_pspace_data): Change type.
2394         (remote_pspace_data_cleanup): Remove.
2395         (get_remote_exec_file, set_pspace_remote_exec_file)
2396         (_initialize_remote): Update.
2397
2398 2019-05-08  Tom Tromey  <tom@tromey.com>
2399
2400         * breakpoint.c (breakpoint_objfile_key): Change type.
2401         (get_breakpoint_objfile_data): Update.
2402         (free_breakpoint_objfile_data): Remove.
2403         (_initialize_breakpoint): Update.
2404
2405 2019-05-08  Tom Tromey  <tom@tromey.com>
2406
2407         * linux-tdep.c (struct linux_info): Add initializers.
2408         (linux_inferior_data): Move.  Change type.
2409         (invalidate_linux_cache_inf): Update.
2410         (linux_inferior_data_cleanup): Remove.
2411         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2412
2413 2019-05-08  Tom Tromey  <tom@tromey.com>
2414
2415         * auxv.c (auxv_inferior_data): Move.  Change type.
2416         (auxv_inferior_data_cleanup): Remove.
2417         (invalidate_auxv_cache_inf): Rewrite.
2418         (get_auxv_inferior_data, _initialize_auxv): Update.
2419
2420 2019-05-08  Tom Tromey  <tom@tromey.com>
2421
2422         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2423         (symfile_debug_objfile_data_key): Change type.
2424         (symfile_debug_installed, debug_qf_has_symbols)
2425         (debug_qf_find_last_source_symtab)
2426         (debug_qf_forget_cached_source_info)
2427         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2428         (debug_qf_print_stats, debug_qf_dump)
2429         (debug_qf_expand_symtabs_for_function)
2430         (debug_qf_expand_all_symtabs)
2431         (debug_qf_expand_symtabs_with_fullname)
2432         (debug_qf_map_matching_symbols)
2433         (debug_qf_expand_symtabs_matching)
2434         (debug_qf_find_pc_sect_compunit_symtab)
2435         (debug_qf_map_symbol_filenames)
2436         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2437         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2438         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2439         (debug_sym_read_linetable, debug_sym_relocate): Update.
2440         (symfile_debug_free_objfile): Remove.
2441         (install_symfile_debug_logging, _initialize_symfile_debug):
2442         Update.
2443
2444 2019-05-08  Tom Tromey  <tom@tromey.com>
2445
2446         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2447         allocate_on_obstack.
2448         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2449         (get_dwarf2_per_objfile): Update.
2450         (set_dwarf2_per_objfile): Remove.
2451         (dwarf2_has_info, dwarf2_get_section_info): Update.
2452         (dwarf2_free_objfile): Remove.
2453         (_initialize_dwarf2_read): Update.
2454
2455 2019-05-08  Tom Tromey  <tom@tromey.com>
2456
2457         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2458         initializers.
2459         <unsupported_script_warning_printed,
2460         script_not_found_warning_printed>: Now bool.
2461         (auto_load_pspace_data): Change type.
2462         (~auto_load_pspace_info): Rename from
2463         auto_load_pspace_data_cleanup.
2464         (get_auto_load_pspace_data, init_loaded_scripts_info)
2465         (clear_section_scripts, maybe_print_unsupported_script_warning)
2466         (maybe_print_script_not_found_warning, _initialize_auto_load):
2467         Update.
2468
2469 2019-05-08  Tom Tromey  <tom@tromey.com>
2470
2471         * objfiles.c (objfile_pspace_info): Add destructor and
2472         initializers.
2473         (objfiles_pspace_data): Change type.
2474         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2475         (get_objfile_pspace_data): Update.
2476         (objfiles_bfd_data): Change type.
2477         (get_objfile_bfd_data): Update.
2478         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2479
2480 2019-05-08  Tom Tromey  <tom@tromey.com>
2481
2482         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2483         Change type.
2484         (get_catch_syscall_inferior_data): Update.
2485         (catch_syscall_inferior_data_cleanup): Remove.
2486         (_initialize_break_catch_syscall): Update.
2487
2488 2019-05-08  Tom Tromey  <tom@tromey.com>
2489
2490         * inflow.c (struct terminal_info): Add destructor and
2491         initializers.
2492         (inflow_inferior_data): Change type.
2493         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2494         (get_inflow_inferior_data, inflow_inferior_exit)
2495         (swap_terminal_info, _initialize_inflow): Update.
2496
2497 2019-05-08  Tom Tromey  <tom@tromey.com>
2498
2499         * target-dcache.c (target_dcache_cleanup): Remove.
2500         (target_dcache_aspace_key): Change type.
2501         (target_dcache_init_p, target_dcache_invalidate)
2502         (target_dcache_get, target_dcache_get_or_init)
2503         (_initialize_target_dcache): Update.
2504         * dcache.h (struct dcache_deleter): New.
2505
2506 2019-05-08  Tom Tromey  <tom@tromey.com>
2507
2508         * symtab.c (struct symbol_cache): Add destructor and
2509         initializers.
2510         (symbol_cache_key): Move.  Change type.
2511         (make_symbol_cache, free_symbol_cache): Remove.
2512         (get_symbol_cache): Update.
2513         (symbol_cache_cleanup): Remove.
2514         (ALL_PSPACES, symbol_cache_flush)
2515         (maintenance_print_symbol_cache)
2516         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2517         Update.
2518
2519 2019-05-08  Tom Tromey  <tom@tromey.com>
2520
2521         * symtab.c (struct main_info): Add destructor and initializers.
2522         (main_progspace_key): Move.  Change type.
2523         (get_main_info): Update.
2524         (main_info_cleanup): Remove.
2525         (_initialize_symtab): Update.
2526
2527 2019-05-08  Tom Tromey  <tom@tromey.com>
2528
2529         * registry.h (DECLARE_REGISTRY): Define the _key class.
2530
2531 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2532
2533         * NEWS: Merge two 'New commands' sections.
2534
2535 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2536
2537         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2538         parameter and use Ada language definition instead.
2539         (ada_val_print_ptr): Remove unused language parameter.
2540         (ada_val_print_num): Remove language parameter and use Ada language
2541         definition instead.
2542         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2543         parameter.
2544         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2545         parameter and use Ada language definition instead.
2546         (ada_val_print_1): Update all ada_val_print_xxx calls.
2547         Remove language parameter.
2548         (ada_val_print): Update ada_val_print_1 call.
2549
2550 2019-05-08  Tom Tromey  <tromey@adacore.com>
2551
2552         * remote.c (remote_hw_watchpoint_limit)
2553         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2554         Now static.
2555
2556 2019-05-08  Tom Tromey  <tromey@adacore.com>
2557
2558         * maint.c (_initialize_maint_cmds): Move initialization code to
2559         remote.c.
2560         (watchdog, show_watchdog): Move to remote.c.
2561         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2562         "watchdog" static.
2563         (_initialize_remote): Move initialization code from maint.c.
2564         * defs.h (watchdog): Don't declare.
2565
2566 2019-05-08  Tom Tromey  <tromey@adacore.com>
2567
2568         * tui/tui-interp.c: Include main.h.
2569         * interps.c: Include main.h.
2570         * main.h (interpreter_p): Declare.
2571         * defs.h (interpreter_p): Don't declare.
2572
2573 2019-05-08  Tom Tromey  <tromey@adacore.com>
2574
2575         * dwarf2loc.c: Include dwarf2read.h.
2576         * defs.h (read_unsigned_leb128): Don't declare.
2577         * dwarf2read.h (read_unsigned_leb128): Declare.
2578
2579 2019-05-08  Tom Tromey  <tromey@adacore.com>
2580
2581         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2582         method.
2583
2584 2019-05-08  Tom Tromey  <tromey@adacore.com>
2585
2586         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2587         when no wrap column is set.
2588
2589 2019-05-08  Tom Tromey  <tromey@adacore.com>
2590
2591         * c-lang.c (c_get_string): Handle non-C-style arrays.
2592
2593 2019-05-08  Tom Tromey  <tromey@adacore.com>
2594
2595         * typeprint.c (print_offset_data::update): Print the bit offset,
2596         not the number of bits remaining.
2597
2598 2019-05-08  Tom Tromey  <tromey@adacore.com>
2599
2600         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2601         padding at end of comment.
2602
2603 2019-05-08  Tom Tromey  <tromey@adacore.com>
2604
2605         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2606         Compare main types.
2607
2608 2019-05-06  Tom Tromey  <tom@tromey.com>
2609
2610         * common/scoped_mmap.c: Include common-defs.h.
2611         * common/scoped_mmap.h: Don't include config.h.
2612
2613 2019-05-04  Tom Tromey  <tom@tromey.com>
2614
2615         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2616         (struct aarch64_call_info): Add initializers.
2617         <si>: Now a std::vector.
2618         (pass_on_stack, aarch64_push_dummy_call): Update.
2619
2620 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2621             Tom Tromey  <tom@tromey.com>
2622
2623         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2624         (ppc_threads): Now a std::vector.  Now static.
2625         (hwdebug_find_thread_points_by_tid)
2626         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2627         Update.
2628
2629 2019-05-04  Tom Tromey  <tom@tromey.com>
2630
2631         * arc-tdep.c (arc_tdesc_init): Return bool.
2632
2633 2019-05-04  Tom Tromey  <tom@tromey.com>
2634
2635         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2636         Use gdb_assert_not_reached.
2637
2638 2019-05-04  Tom Tromey  <tom@tromey.com>
2639
2640         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2641         "false".
2642
2643 2019-05-04  Tom Tromey  <tom@tromey.com>
2644
2645         * arc-tdep.c (arc_tdesc_init): Use bool.
2646
2647 2019-05-04  Tom Tromey  <tom@tromey.com>
2648
2649         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2650
2651 2019-05-04  Tom Tromey  <tom@tromey.com>
2652
2653         * cli/cli-cmds.c (valid_command_p): Return bool.
2654
2655 2019-05-04  Tom Tromey  <tom@tromey.com>
2656
2657         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2658         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2659
2660 2019-05-04  Raul Tambre  <raul@tambre.ee>
2661
2662         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2663         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2664         operator for comparison.
2665
2666 2019-05-04  Tom Tromey  <tom@tromey.com>
2667
2668         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2669         (lookup_partial_symbol, print_partial_symbols)
2670         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2671         (psymbol_compare): Update.
2672         (add_psymbol_to_bcache): Clear the entire psymbol.
2673         (maintenance_check_psymtabs): Update.
2674         * psympriv.h (struct partial_symbol): Don't derive from
2675         general_symbol_info.
2676         <obj_section, unrelocated_address, address,
2677         set_unrelocated_address>: Update.
2678         <ginfo>: New member.
2679         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2680         (debug_names::write_psymbols): Update.
2681
2682 2019-05-04  Tom de Vries  <tdevries@suse.de>
2683
2684         * contrib/cc-with-tweaks.sh: Support -n arg.
2685
2686 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2687
2688         * corelow.c (core_target::detach): Ensure frame cache and
2689         register caches are cleared.
2690         inferior.c (exit_inferior_1): Likewise.
2691
2692 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2693             Tom Tromey  <tom@tromey.com>
2694
2695         * dictionary.c (collate_pending_symbols_by_language): Remove
2696         "struct" from foreach.
2697         * symtab.c (lookup_global_symbol_from_objfile)
2698         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2699         foreach.
2700         * ser-tcp.c (net_open): Remove "struct" from foreach.
2701         * objfiles.c (objfile_relocate, objfile_rebase)
2702         (objfile_has_symbols): Remove "struct" from foreach.
2703         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2704         from foreach.
2705         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2706         foreach.
2707         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2708         "struct" from foreach.
2709         * ada-lang.c (create_excep_cond_exprs)
2710         (ada_exception_catchpoint_cond_string): Remove "struct" from
2711         foreach.
2712
2713 2019-05-03  Tom Tromey  <tromey@adacore.com>
2714
2715         * ada-exp.y (convert_char_literal): Check suffix of each
2716         enumerator.
2717
2718 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2719
2720         PR ada/21406:
2721         * ada-exp.y (yywrap): Don't define.
2722         * ada-lex.l (%option): Add noyywrap
2723         (yywrap): Remove.
2724
2725 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2726
2727         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2728         _WIN32_WINNT to the XP level, unless already defined to a higher
2729         level.
2730
2731         * unittests/parse-connection-spec-selftests.c:
2732         * ser-tcp.c:
2733         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2734         override.
2735
2736         * symfile.c (find_separate_debug_file): Remove colon from the
2737         drive spec of DOS/Windows file names of the target, so that the
2738         file name produced from DEBUGDIR and the target's directory will
2739         be valid on DOS/Windows systems.
2740
2741 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2742
2743         * rust-lang.c (val_print_struct): Handle printing structures
2744         containing strings.
2745
2746 2019-05-02  Tom Tromey  <tromey@adacore.com>
2747
2748         * valarith.c (_initialize_valarith): Remove.
2749
2750 2019-05-01  Tom Tromey  <tromey@adacore.com>
2751
2752         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2753         bitfields.
2754
2755 2019-05-01  Tom Tromey  <tromey@adacore.com>
2756
2757         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2758         for big-endian copies.
2759
2760 2019-04-30  Ali Tamur  <tamur@google.com>
2761         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2762         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2763         (read_3_bytes): New function.
2764
2765 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2766
2767         * windows-nat.c (main_thread_id): Delete.
2768         (handle_output_debug_string): Replace main_thread_id by
2769         current_event.dwThreadId.
2770         (fake_create_process): Likewise.
2771         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2772         Do not set main_thread_id.
2773         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2774         current_event.dwThreadId.
2775         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2776
2777 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2778
2779         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2780         Use current_event.dwThreadId instead of main_thread_id.
2781
2782 2019-04-30  Tom Tromey  <tromey@adacore.com>
2783
2784         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2785         (create_excep_cond_exprs): Iterate over program spaces.
2786         (ada_exception_catchpoint_cond_string): Examine all minimal
2787         symbols for exception types.
2788
2789 2019-04-30  Tom Tromey  <tromey@adacore.com>
2790
2791         PR c++/24470:
2792         * dwarf2read.c (process_structure_scope): Handle case where type
2793         has template parameters but no symbol was created.
2794
2795 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2796             Chris January  <chris.january@arm.com>
2797
2798         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2799         qualifier.
2800         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2801
2802 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2803
2804         * f-typeprint.c (f_print_type): Update rules for printing
2805         whitespace.
2806         (f_type_print_varspec_suffix): Likewise.
2807
2808 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2809             Chris January  <chris.january@arm.com>
2810
2811         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2812         function arguments.
2813
2814 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2815
2816         * f-lang.c (build_fortran_types): Change name of void type to
2817         lower case.
2818         * f-typeprint.c (f_type_print_base): Print the name of the void
2819         type, rather than a fixed string.
2820         * f-valprint.c (f_decorations): Use lower case void string.
2821
2822 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2823             Chris January  <chris.january@arm.com>
2824
2825         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2826         types for Fortran.
2827
2828 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2829             Chris January  <chris.january@arm.com>
2830             David Lecomber  <david.lecomber@arm.com>
2831
2832         * f-exp.y (BINOP_INTRINSIC): New token.
2833         (exp): New parser rule handling BINOP_INTRINSIC.
2834         (f77_keywords): Add new builtin procedures.
2835         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2836         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2837         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2838         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2839         (print_unop_subexp_f): New function.
2840         (print_binop_subexp_f): New function.
2841         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2842         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2843         (dump_subexp_body_f): Likewise.
2844         (operator_check_f): Likewise.
2845         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2846         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2847
2848 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2849
2850         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2851         UNOP_KIND.
2852         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2853         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2854         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2855         (operator_length_f): New fuction.
2856         (print_subexp_f): New function.
2857         (op_name_f): New function.
2858         (dump_subexp_body_f): New function.
2859         (operator_check_f): New function.
2860         (exp_descriptor_f): Replace standard expression handling functions
2861         with new functions.
2862         * gdb/fortran-operator.def: New file.
2863         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2864         * gdb/std-operator.def: Remove UNOP_KIND.
2865
2866 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2867
2868         * std-operator.def: Remove unbalanced, stray double quote
2869         character.
2870
2871 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2872             Chris January  <chris.january@arm.com>
2873             Daniel Everett  <daniel.everett@arm.com>
2874             Nick Forrington  <nick.forrington@arm.com>
2875             Richard Bunt  <richard.bunt@arm.com>
2876
2877         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2878         of depth when printing anonymous structs or unions.
2879         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2880         Don't print either the top-level value, or the children if the
2881         max-depth is exceeded.
2882         (ppscm_print_children): When printing the key of a map, allow one
2883         extra level of depth.
2884         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2885         print either the top-level value, or the children if the max-depth
2886         is exceeded.
2887         (print_children): When printing the key of a map, allow one extra
2888         level of depth.
2889         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2890         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2891         (user_print_options): Initialise max_depth field.
2892         (val_print_scalar_or_string_type_p): New function.
2893         (val_print): Check to see if the max depth has been reached.
2894         (val_print_check_max_depth): Define new function.
2895         (show_print_max_depth): New function.
2896         (_initialize_valprint): Add 'print max-depth' option.
2897         * valprint.h (struct value_print_options) <max_depth>: New field.
2898         (val_print_check_max_depth): Declare new function.
2899         * NEWS: Document new feature.
2900
2901 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2902
2903         * ada-lang.c (ada_language_defn): Initialise new field.
2904         * c-lang.c (c_is_string_type_p): New function.
2905         (c_language_defn): Initialise new field.
2906         (cplus_language_defn): Initialise new field.
2907         (asm_language_defn): Initialise new field.
2908         (minimal_language_defn): Initialise new field.
2909         * c-lang.h (c_is_string_type_p): Declare new function.
2910         * d-lang.c (d_language_defn): Initialise new field.
2911         * f-lang.c (f_is_string_type_p): New function.
2912         (f_language_defn): Initialise new field.
2913         * go-lang.c (go_is_string_type_p): New function.
2914         (go_language_defn): Initialise new field.
2915         * language.c (default_is_string_type_p): New function.
2916         (unknown_language_defn): Initialise new field.
2917         (auto_language_defn): Initialise new field.
2918         * language.h (struct language_defn) <la_is_string_type_p>: New
2919         member variable.
2920         (default_is_string_type_p): Declare new function.
2921         * m2-lang.c (m2_language_defn): Initialise new field.
2922         * objc-lang.c (objc_language_defn): Initialise new field.
2923         * opencl-lang.c (opencl_language_defn): Initialise new field.
2924         * p-lang.c (pascal_is_string_type_p): New function.
2925         (pascal_language_defn): Initialise new field.
2926         * rust-lang.c (rust_is_string_type_p): New function.
2927         (rust_language_defn): Initialise new field.
2928
2929 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2930
2931         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2932         New field.
2933         * ada-lang.c (ada_language_defn): Initialise new field.
2934         * c-lang.c (c_language_defn): Likewise.
2935         (cplus_language_defn): Likewise.
2936         (asm_language_defn): Likewise.
2937         (minimal_language_defn): Likewise.
2938         * d-lang.c (d_language_defn): Likewise.
2939         * f-lang.c (f_language_defn): Likewise.
2940         * go-lang.c (go_language_defn): Likewise.
2941         * language.c (unknown_language_defn): Likewise.
2942         (auto_language_defn): Likewise.
2943         * m2-lang.c (m2_language_defn): Likewise.
2944         * objc-lang.c (objc_language_defn): Likewise.
2945         * opencl-lang.c (opencl_language_defn): Likewise.
2946         * p-lang.c (pascal_language_defn): Likewise.
2947         * rust-lang.c (rust_language_defn): Likewise.
2948
2949 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2950
2951         * ada-lang.c (ada_is_character_type): Change return type to bool.
2952         (ada_is_string_type): Likewise.
2953         * ada-lang.h (ada_is_character_type): Update declaration
2954         (ada_is_string_type): Likewise.
2955
2956 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2957
2958         Support style in 'frame|thread apply'
2959
2960         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2961         * record.c (record_start, record_stop): Update callers of
2962         execute_command_to_string with false.
2963         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2964         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2965         methods.
2966         (class string_file): New constructor with term_out parameter.
2967         Override methods term_out and can_emit_style_escape.  New member
2968         term_out.
2969         (class stdio_file): Override can_emit_style_escape.
2970         (class tee_file): Override term_out and can_emit_style_escape.
2971         * utils.h (can_emit_style_escape): Remove.
2972         * utils.c (can_emit_style_escape): Likewise.
2973         Update all callers of can_emit_style_escape (SOMESTREAM) to
2974         SOMESTREAM->can_emit_style_escape.
2975         * source-cache.c (source_cache::get_source_lines): Likewise.
2976         * stack.c (frame_apply_command_count): Call execute_command_to_string
2977         passing the term_out characteristic of the current gdb_stdout.
2978         * thread.c (thr_try_catch_cmd): Likewise.
2979         * top.c (execute_command_to_string): pass term_out parameter
2980         to construct the string_file for the command output.
2981         * ui-file.c (term_cli_styling): New function (most code moved
2982         from utils.c can_emit_style_escape).
2983         (string_file::string_file, string_file::can_emit_style_escape,
2984         stdio_file::can_emit_style_escape, tee_file::term_out,
2985         tee_file::can_emit_style_escape): New functions.
2986
2987 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2988
2989         * NEWS: Mention the new set|show may-call-functions.
2990         * infcall.c (may_call_functions_p): New variable.
2991         (show_may_call_functions_p): New function.
2992         (call_function_by_hand_dummy): Throws an error if not
2993         may-call-functions.
2994         (_initialize_infcall): Call add_setshow_boolean_cmd for
2995         may-call-functions.
2996
2997 2019-04-25  Keith Seitz  <keiths@redhat.com>
2998
2999         PR c++/24367
3000         * cp-support.c (inspect_type): Don't attempt substitutions
3001         of symbol with the same name.
3002
3003 2019-04-25  Tom Tromey  <tromey@adacore.com>
3004
3005         PR gdb/24475:
3006         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3007         static.
3008
3009 2019-04-25  Tom Tromey  <tromey@adacore.com>
3010
3011         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3012         rvalue reference.
3013         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3014         (gdb_xml_parser::parse): Use std::move.
3015         * python/python-internal.h (gdbpy_convert_exception): Take a const
3016         reference.
3017         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3018         std::move.
3019         * python/py-utils.c (gdbpy_convert_exception): Take a const
3020         reference.
3021         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3022         Use std::move.
3023         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3024         Use std::move.
3025         * mi/mi-main.c (mi_print_exception): Take a const reference.
3026         * main.c (handle_command_errors): Take a const reference.
3027         * linespec.c (parse_linespec): Use std::move.
3028         * infcall.c (run_inferior_call): Use std::move.
3029         (call_function_by_hand_dummy): Use std::move.
3030         * exec.c (try_open_exec_file): Use std::move.
3031         * exceptions.h (exception_print, exception_fprintf)
3032         (exception_print_same): Update.
3033         * exceptions.c (print_exception, exception_print)
3034         (exception_fprintf, exception_print_same): Change parameters to
3035         const reference.
3036         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3037         * common/new-op.c: Use std::move.
3038         * common/common-exceptions.h (struct gdb_exception): Add move
3039         constructor.
3040         (struct gdb_exception_error, struct gdb_exception_quit, struct
3041         gdb_quit_bad_alloc): Change constructor to move constructor.
3042         (throw_exception): Change parameter to rvalue reference.
3043         * common/common-exceptions.c (throw_exception): Take rvalue
3044         reference.
3045         * cli/cli-interp.c (safe_execute_command): Use std::move.
3046         * breakpoint.c (insert_bp_location, location_to_sals): Use
3047         std::move.
3048
3049 2019-04-25  Tom Tromey  <tromey@adacore.com>
3050
3051         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3052         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3053         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3054         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3055         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3056         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3057         guile/scm-value.c: Use unpack.
3058         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3059         gdbscm_gdb_exception.
3060         (gdbscm_throw_gdb_exception): Likewise.
3061         (struct gdbscm_gdb_exception): New.
3062         (unpack): New function.
3063         (gdbscm_wrap): Use unpack.
3064
3065 2019-04-25  Tom Tromey  <tromey@adacore.com>
3066
3067         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3068         (gdb_rl_callback_handler): Use std::move.
3069         * common/common-exceptions.h (struct gdb_exception): Add move
3070         assignment operator.
3071         (throw_exception_sjlj): Change "exception" to const reference.
3072         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3073         (throw_exception_sjlj): Change "exception" to const reference.
3074
3075 2019-04-25  Tom Tromey  <tromey@adacore.com>
3076
3077         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3078         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3079         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3080         Update.
3081         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3082         Update.
3083         * mi/mi-interp.c (mi_interp::exec): Update.
3084         * linespec.c (parse_linespec): Update.
3085         * infcall.c (run_inferior_call): Update.
3086         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3087         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3088         (gdbscm_lookup_global_symbol): Update.
3089         * guile/scm-param.c (gdbscm_parameter_value): Update.
3090         * guile/scm-frame.c (gdbscm_frame_read_register)
3091         (gdbscm_frame_read_var): Update.
3092         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3093         * exec.c (try_open_exec_file): Update.
3094         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3095         (gdb_rl_callback_handler): Update.
3096         * common/common-exceptions.h (exception_none): Don't declare.
3097         * common/common-exceptions.c (exception_none): Don't define.
3098         (struct catcher) <exception>: Update.
3099         * cli/cli-interp.c (safe_execute_command): Update.
3100         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3101
3102 2019-04-25  Ali Tamur  <tamur@google.com>
3103
3104         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3105         (read_attribute_value): Likewise.
3106         (dwarf2_read_addr_index): Update comment.
3107         (read_str_index): Add DW_FORM_strx.
3108         (dwarf2_string_attr): Likewise.
3109         (dwarf2_const_value_attr): Likewise.
3110         (dump_die_shallow): Likewise.
3111         (dwarf2_fetch_constant_bytes): Likewise.
3112         (skip_form_bytes): Likewise.
3113         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3114
3115 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3116
3117         PR corefiles/11608
3118         PR corefiles/18187
3119         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3120         OFFSET.  Verify if current mapping contains an ELF header.
3121         (linux_find_memory_regions_full): Adjust call to
3122         dump_mapping_p.
3123
3124 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3125             Kang Li <kanglictf@gmail.com>
3126
3127         PR gdb/21600
3128
3129         * dwarf2-frame.c (read_initial_length): Be consistent about using
3130         unsigned representation of length.
3131         (decode_frame_entry_1): Likewise.  Check for wraparound of
3132         end pointer as well as buffer overflow.
3133
3134 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3135
3136         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3137         "vq".
3138
3139 2019-04-24  Tom Tromey  <tromey@adacore.com>
3140
3141         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3142
3143 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3144
3145         * s12z-tdep.c (s12z_unwind_pc): Delete.
3146         (s12z_unwind_sp): Delete.
3147         (s12z_gdbarch_init): Don't register deleted functions with
3148         gdbarch.
3149
3150 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3151
3152         * rl78-tdep.c (rl78_unwind_sp): Delete.
3153         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3154
3155 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3156
3157         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3158         (xstormy16_unwind_pc): Delete.
3159         (xstormy16_dummy_id): Delete.
3160         (xstormy16_gdbarch_init): Don't register deleted functions with
3161         gdbarch.
3162
3163 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3164
3165         * vax-tdep.c (vax_unwind_pc): Delete.
3166         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3167
3168 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3169
3170         * v850-tdep.c (v850_unwind_sp): Delete.
3171         (v850_unwind_pc): Delete.
3172         (v850_dummy_id): Delete.
3173         (v850_gdbarch_init): Don't register deleted functions with
3174         gdbarch.
3175
3176 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3177
3178         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3179         (tilegx_unwind_pc): Delete.
3180         (tilegx_unwind_dummy_id): Delete.
3181         (tilegx_gdbarch_init): Don't register deleted functions with
3182         gdbarch.
3183
3184 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3185
3186         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3187         (tic6x_dummy_id): Delete.
3188         (tic6x_gdbarch_init): Don't register deleted functions with
3189         gdbarch.
3190
3191 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3192
3193         * sparc-tdep.c (sparc_unwind_pc): Delete.
3194         (sparc32_gdbarch_init): Don't register deleted function with
3195         gdbarch.
3196
3197 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3198
3199         * sh-tdep.c (sh_unwind_sp): Delete.
3200         (sh_unwind_pc): Delete.
3201         (sh_dummy_id): Delete.
3202         (sh_gdbarch_init): Don't register deleted functions with
3203         gdbarch.
3204
3205 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3206
3207         * score-tdep.c (score_unwind_sp): Delete.
3208         (score_unwind_pc): Delete.
3209         (score_dummy_id): Delete.
3210         (score_gdbarch_init): Don't register deleted functions with
3211         gdbarch.
3212
3213 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3214
3215         * rx-tdep.c (rx_unwind_pc): Delete.
3216         (rx_unwind_sp): Delete.
3217         (rx_dummy_id): Delete.
3218         (rx_gdbarch_init): Don't register deleted functions with
3219         gdbarch.  Update comment.
3220
3221 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3222
3223         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3224         (rs6000_dummy_id): Delete.
3225         (rs6000_gdbarch_init): Don't register deleted functions with
3226         gdbarch.
3227
3228 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3229
3230         * or1k-tdep.c (or1k_dummy_id): Delete.
3231         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3232
3233 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3234
3235         * nios2-tdep.c (nios2_dummy_id): Delete.
3236         (nios2_unwind_sp): Delete.
3237         (nios2_gdbarch_init): Don't register deleted functions with
3238         gdbarch.
3239
3240 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3241
3242         * nds32-tdep.c (nds32_dummy_id): Delete.
3243         (nds32_unwind_pc): Delete.
3244         (nds32_unwind_sp): Delete.
3245         (nds32_gdbarch_init): Don't register deleted functions with
3246         gdbarch.
3247
3248 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3249
3250         * msp430-tdep.c (msp430_unwind_pc): Delete.
3251         (msp430_unwind_sp): Delete.
3252         (msp430_dummy_id): Delete.
3253         (msp430_gdbarch_init): Don't register deleted functions with
3254         gdbarch.
3255
3256 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3257
3258         * moxie-tdep.c (moxie_unwind_sp): Delete.
3259         (moxie_unwind_pc): Delete.
3260         (moxie_dummy_id): Delete.
3261         (moxie_gdbarch_init): Don't register deleted functions with
3262         gdbarch.
3263
3264 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3265
3266         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3267         (mn10300_unwind_pc): Delete.
3268         (mn10300_unwind_sp): Delete.
3269         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3270         mn10300_unwind_sp.
3271         (mn10300_frame_unwind_init): Don't register deleted functions with
3272         gdbarch.
3273
3274 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3275
3276         * mep-tdep.c (mep_unwind_pc): Delete.
3277         (mep_unwind_sp): Delete.
3278         (mep_dummy_id): Delete.
3279         (mep_gdbarch_init): Don't register deleted functions with
3280         gdbarch.
3281
3282 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3283
3284         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3285         (m68hc11_unwind_sp): Delete.
3286         (m68hc11_gdbarch_init): Don't register deleted functions with
3287         gdbarch.
3288
3289 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3290
3291         * m32r-tdep.c (m32r_unwind_sp): Delete.
3292         (m32r_unwind_pc): Delete.
3293         (m32r_dummy_id): Delete.
3294         (m32r_gdbarch_init): Don't register deleted functions with
3295         gdbarch.
3296
3297 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3298
3299         * m32c-tdep.c (m32c_unwind_pc): Delete.
3300         (m32c_unwind_sp): Delete.
3301         (m32c_dummy_id): Delete.
3302         (m32c_gdbarch_init): Don't register deleted functions with
3303         gdbarch.
3304
3305 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3306
3307         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3308         (lm32_unwind_pc): Delete.
3309         (lm32_dummy_id): Delete.
3310         (lm32_gdbarch_init): Don't register deleted functions with
3311         gdbarch.
3312
3313 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3314
3315         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3316         (iq2000_unwind_pc): Delete.
3317         (iq2000_dummy_id): Delete.
3318         (iq2000_gdbarch_init): Don't register deleted functions with
3319         gdbarch.
3320
3321 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3322
3323         * nds32-tdep.c (nds32_type_align): Delete.
3324         (nds32_push_dummy_call): Use type_align instead.
3325
3326 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3327
3328         * arm-tdep.c (arm_type_align): Only handle vector override case.
3329         (arm_push_dummy_call): Use type_align.
3330         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3331
3332 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3333
3334         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3335         case.
3336         (pass_on_stack): Use type_align.
3337         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3338         function.
3339
3340 2019-04-23  Tom Tromey  <tromey@adacore.com>
3341
3342         * dwarf2read.c (line_header::file_name_at): Remove unused
3343         overload.
3344
3345 2019-04-23  Tom de Vries  <tdevries@suse.de>
3346
3347         PR gdb/24438
3348         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3349         invocation.
3350
3351
3352 2019-03-27  Ali Tamur  <tamur@google.com>
3353
3354         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3355         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3356         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3357         (dwarf_expr_context::get_addr_index): Likewise
3358         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3359         (symbol_needs_eval_context::get_addr_index): Likewise
3360         (disassemble_dwarf_expression): Add DW_OP_addrx
3361         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3362         (read_cutu_die_from_dwo): Update comment
3363         (skip_one_die): Add DW_FORM_addrx
3364         (read_attribute_value): Likewise
3365         (var_decode_location): Add DW_OP_addrx
3366         (dwarf2_const_value_attr): Add DW_FORM_addrx
3367         (dump_die_shallow): Likewise
3368         (dwarf2_fetch_constant_bytes): Likewise
3369         (decode_locdesc): Add DW_OP_addrx
3370         (skip_form_bytes): Add DW_FORM_addrx
3371
3372 2019-04-22  Ali Tamur  <tamur@google.com>
3373
3374         * MAINTAINERS (Write After Approval): Add self.
3375
3376 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3377
3378         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3379         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3380         (open_symbol_file_object): Likewise.
3381         (svr4_default_sos): Add info parameter.
3382         (svr4_read_so_list): Likewise.
3383         (svr4_current_sos_direct): Adjust functions calls to pass down
3384         info.
3385         (svr4_current_sos_1): Add info parameter.
3386         (svr4_current_sos): Call get_svr4_info, pass info down to
3387         svr4_current_sos_1.
3388         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3389         get_svr4_info.
3390         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3391         get_svr4_info.
3392         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3393         to get_svr4_info.
3394         (probes_table_remove_objfile_probes): Likewise.
3395         (register_solib_event_probe): Add info parameter.
3396         (solist_update_incremental): Pass info parameter down to
3397         svr4_read_so_list.
3398         (disable_probes_interface): Add info parameter.
3399         (svr4_handle_solib_event): Pass current_program_space to
3400         get_svr4_info.  Adjust disable_probes_interface cleanup.
3401         (svr4_create_probe_breakpoints): Add info parameter, pass it
3402         down to register_solib_event_probe.
3403         (svr4_create_solib_event_breakpoints): Add info parameter,
3404         pass it down to svr4_create_probe_breakpoints.
3405         (enable_break): Pass info down to
3406         svr4_create_solib_event_breakpoints.
3407         (svr4_solib_create_inferior_hook): Pass current_program_space to
3408         get_svr4_info.
3409         (svr4_clear_solib): Likewise.
3410
3411 2019-04-22  Pedro Alves  <palves@redhat.com>
3412
3413         * solib-svr4.c (svr4_free_objfile_observer): New.
3414         (probe_and_action::objfile): New field.
3415         (probes_table_htab_remove_objfile_probes)
3416         (probes_table_remove_objfile_probes): New functions.
3417         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3418         in the new probe_and_action.  Don't store the probe in 'lookup'.
3419         (svr4_create_probe_breakpoints): Pass objfile to
3420         register_solib_event_probe.
3421         (_initialize_svr4_solib): Register a free_objfile observer.
3422
3423 2019-04-19  Tom Tromey  <tom@tromey.com>
3424
3425         * common/queue.h: Remove.
3426
3427 2019-04-19  Tom Tromey  <tom@tromey.com>
3428
3429         * event-loop.c: Don't include "common/queue.h".
3430
3431 2019-04-19  Tom Tromey  <tom@tromey.com>
3432
3433         * remote.c (remote_target): Use delete.
3434         * remote-notif.h: Include <list>, not "common/queue.h".
3435         (notif_client_p): Remove typedef.
3436         (remote_notif_state): Add constructor, destructor, initializer.
3437         <notif_queue>: Now a std::list.
3438         (remote_notif_state_xfree): Don't declare.
3439         * remote-notif.c (remote_notif_process, handle_notification)
3440         (remote_notif_state_allocate): Update.
3441         (~remote_notif_state): Rename from remote_notif_state_xfree.
3442
3443 2019-04-19  Tom Tromey  <tom@tromey.com>
3444
3445         * symfile.c (reread_symbols): Update.
3446         * objfiles.c (objfile_register_static_link)
3447         (objfile_lookup_static_link): Update
3448         (~objfile) Don't delete static_links.
3449         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3450
3451 2019-04-19  Tom Tromey  <tom@tromey.com>
3452
3453         * type-stack.h (struct type_stack) <insert>: Constify string.
3454         * type-stack.c (type_stack::insert): Constify string.
3455         * gdbtypes.h (lookup_template_type): Update.
3456         (address_space_name_to_int): Update.
3457         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3458         const.
3459         (lookup_template_type): Make name const.
3460         * c-exp.y: Update rules.
3461         (lex_one_token, classify_name, classify_inner_name)
3462         (c_print_token): Update.
3463         * p-exp.y: Update rules.
3464         (yylex): Update.
3465         * f-exp.y: Update rules.
3466         (yylex): Update.
3467         * d-exp.y: Update rules.
3468         (lex_one_token, classify_name, classify_inner_name): Update.
3469         * parse.c (write_dollar_variable, copy_name): Return std::string.
3470         * parser-defs.h (copy_name): Change return type.
3471         * m2-exp.y: Update rules.
3472         (yylex): Update.
3473         * go-exp.y (lex_one_token): Update.
3474         Update rules.
3475         (classify_unsafe_function, classify_packaged_name)
3476         (classify_name, yylex): Update.
3477
3478 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3479
3480         * configure.ac: add --enable-source-highlight switch.
3481         * configure: Regenerate.
3482         * top.c (print_gdb_version): plumb --enable-source-highlight
3483         status to "show configuration".
3484
3485 2019-04-19  Tom Tromey  <tromey@adacore.com>
3486
3487         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3488         Check ADA_TYPE_P.
3489         (empty_record, ada_template_to_fixed_record_type_1)
3490         (template_to_static_fixed_type)
3491         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3492         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3493         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3494         macros.
3495
3496 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3497
3498         PR symtab/24423:
3499         * source.c (print_source_lines_base): Advance "iter" when a
3500         control character is seen.
3501
3502 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3503
3504         * inferior.h (struct infcall_suspend_state_deleter):
3505         Catch exception in destructor to avoid crash.
3506
3507 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3508
3509         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3510         close to the add_com "shell".
3511
3512 2019-04-18  Tom Tromey  <tromey@adacore.com>
3513
3514         * process-stratum-target.h (class process_stratum_target)
3515         <stratum>: Add "final".
3516
3517 2019-04-17  Tom Tromey  <tromey@adacore.com>
3518
3519         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3520         against nullptr before use.
3521
3522 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3523
3524         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3525
3526 2019-04-17  Jim Wilson  <jimw@sifive.com>
3527             Andrew Burgess  <andrew.burgess@embecosm.com>
3528
3529         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3530         code read might fail, assume 4-byte breakpoint in that case.
3531
3532 2019-04-15  Leszek Swirski  <leszeks@google.com>
3533
3534         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3535         rather than a hand-rolled POD check when checking for forced MEMORY
3536         classification.
3537
3538 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3539
3540         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3541         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3542         function.
3543         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3544         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3545         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3546         declaration.
3547
3548 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3549
3550         * aarch64-linux-nat.c
3551         (aarch64_linux_nat_target::thread_architecture): Add override.
3552         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3553         each VQ.
3554
3555 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3556
3557         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3558
3559 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3560
3561         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3562         target types of size 96-bits, add some additional comments, and
3563         check that the builtin type we found was the correct size.
3564
3565 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3566
3567         * utils.c (prompt_for_continue): Don't restore the styling at the
3568         end, as applied_style has the wrong value.  This fixes styling in
3569         long lists of file names that are interrupted by the "Continue?"
3570         prompt.
3571
3572 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3573
3574         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3575         * c-lang.c (c_language_defn): Likewise.
3576         (cplus_language_defn): Likewise.
3577         (asm_language_defn): Likewise.
3578         (minimal_language_defn): Likewise.
3579         * d-lang.c (d_language_defn): Likewise.
3580         * f-lang.c (f_language_defn): Likewise.
3581         * go-lang.c (go_language_defn): Likewise.
3582         * language.c (unknown_language_defn): Likewise.
3583         (auto_language_defn): Likewise.
3584         * language.h (struct language_defn): Remove la_magic field.
3585         (LANG_MAGIC): Delete.
3586         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3587         * objc-lang.c (objc_language_defn): Likewise.
3588         * opencl-lang.c (opencl_language_defn): Likewise.
3589         * p-lang.c (pascal_language_defn): Likewise.
3590         * rust-lang.c (rust_language_defn): Likewise.
3591
3592 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3593
3594         * riscv-tdep.c (riscv_type_align): New function.
3595         (riscv_type_alignment): Delete.
3596         (riscv_arg_location): Use 'type_align'.
3597         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3598
3599 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3600
3601         * gdbtypes.c (type_align): A struct with no non-static fields also
3602         has alignment of 1.
3603
3604 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3605
3606         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3607         component to 0.
3608         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3609         member.
3610         (riscv_struct_info::analyse): New implementation using new
3611         analyse_inner member function.
3612         (riscv_struct_info::field_offset): New member function.
3613         (riscv_struct_info::m_offsets): New member variable.
3614         (riscv_struct_info::analyse_inner): New private member function,
3615         takes the old implementation of riscv_struct_info::analyse but
3616         extended to track field offsets.
3617         (riscv_call_arg_struct): Update the struct folding special cases
3618         to handle cases where empty C++ structs, which are non-zero
3619         length, are found.
3620         (riscv_arg_location): Initialise the length of each location, a
3621         non-zero length now indicates the location is in use.
3622         (riscv_push_dummy_call): Allow for the first location having a
3623         non-zero offset when setting up arguments.
3624         (riscv_return_value): Likewise, but for return values.
3625
3626 2019-04-11  Tom Tromey  <tromey@adacore.com>
3627
3628         * utils.c (internal_vproblem): Make "msg" const.
3629
3630 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3631
3632         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3633         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3634         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3635         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3636
3637 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3638
3639         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3640         function.
3641         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3642         of amd64_collect_native_gregset.
3643         (amd64_linux_nat_target::store_registers): Likewise.
3644
3645 2019-04-10  Tom Tromey  <tom@tromey.com>
3646
3647         * symtab.c (lookup_global_symbol_from_objfile)
3648         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3649         * objfiles.h (class separate_debug_iterator): New.
3650         (class separate_debug_range): New.
3651         (struct objfile) <separate_debug_objfiles>: New method.
3652         (objfile_separate_debug_iterate): Don't declare.
3653         * objfiles.c (separate_debug_iterator::operator++): Rename from
3654         objfile_separate_debug_iterate.
3655         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3656         iterator.
3657         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3658         iterator.
3659
3660 2019-04-10  Tom Tromey  <tom@tromey.com>
3661
3662         * symfile.c (reread_symbols): Remove old comment.
3663         * objfiles.c (free_all_objfiles): Fix a typo.
3664
3665 2019-04-10  Tom Tromey  <tom@tromey.com>
3666
3667         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3668         * minsyms.c (lookup_minimal_symbol): Use foreach.
3669         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3670         (lookup_minimal_symbol_solib_trampoline): Likewise.
3671         * symfile.c (reread_symbols): Use foreach.
3672
3673 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3674             Tom Tromey  <tromey@adacore.com>
3675
3676         PR rust/24414:
3677         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3678         (rust_lex_int_test): Change "value" to be LONGEST.
3679         (rust_lex_tests): Add test for long integer literal.
3680
3681 2019-04-09  Tom Tromey  <tromey@adacore.com>
3682
3683         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3684         to bool.
3685         (extended_remote_target::attach): Update.
3686         (remote_target::remote_notice_new_inferior): Update.
3687         (remote_target::add_current_inferior_and_thread): Update.
3688         * inferior.c (exit_inferior_1): Use "false".
3689         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3690
3691 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3692
3693         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3694         the "start" command.
3695
3696 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3697
3698         * python/py-inferior.c (infpy_thread_from_thread_handle):
3699         Adjust comments to reflect renaming of thread_from_thread_handle
3700         to thread_from_handle.  Adjust keywords.  Fix type error message.
3701         (inferior_object_methods): Add thread_from_handle.  Retain
3702         thread_from_thread_handle, but mark it as deprecated.
3703
3704 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3705
3706         * gdbthread.h (find_thread_by_handle): Revise declaration.
3707         * thread.c (find_thread_by_handle): Likewise.  Adjust
3708         implementation too.
3709         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3710         support for buffer objects as handles.
3711
3712 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3713
3714         * python/py-infthread.c (thpy_thread_handle): New function.
3715         (thread_object_methods): Register thpy_thread_handle.
3716
3717 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3718
3719         * gdbthread.h (thread_to_thread_handle): Declare.
3720         * thread.c (gdbtypes.h): Include.
3721         (thread_to_thread_handle): New function.
3722
3723         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3724         (target_thread_info_to_thread_handle): Declare.
3725         * target.c (target_thread_info_to_thread_handle): New function.
3726         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3727         * target-delegates.c: Regenerate.
3728
3729         * linux-thread-db.c (class thread_db_target): Add method
3730         thread_info_to_thread_handle.
3731         (thread_db_target::thread_info_to_thread_handle): Define.
3732         * remote.c (class remote_target): Add new method
3733         thread_info_to_thread_handle.
3734         (remote_target::thread_info_to_thread_handle): Define.
3735
3736 2019-04-08  Pedro Alves  <palves@redhat.com>
3737
3738         * common/common-exceptions.c (throw_exception): Don't create
3739         named object to throw; throw directly.
3740         (throw_it): Likewise.  Don't initialize gdb_exception::message
3741         here, with new; pass FMT and AP to the ctor instead.
3742         * common/common-exceptions.h: Include <string>.
3743         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3744         const char *, va_list)): New ctor.  Use std::make_shared.
3745         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3746         errors)): Delete.
3747         (gdb_exception_error::gdb_exception_error(enum errors, const char
3748         *, va_list)): New.
3749         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3750         Add assertion.
3751         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3752         errors)): Delete.
3753         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3754         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3755         Add assertion.
3756
3757 2019-04-08  Tom Tromey  <tom@tromey.com>
3758
3759         * valops.c (value_rtti_indirect_type): Replace throw_exception
3760         with throw.
3761         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3762         with throw.
3763         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3764         throw.
3765         * target.c (target_translate_tls_address): Replace throw_exception
3766         with throw.
3767         * stack.c (frame_apply_command_count): Replace throw_exception
3768         with throw.
3769         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3770         throw.
3771         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3772         with throw.
3773         * rs6000-tdep.c (rs6000_frame_cache)
3774         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3775         * remote.c: Replace throw_exception with throw.
3776         * record-full.c (record_full_message, record_full_wait_1)
3777         (record_full_restore): Replace throw_exception with throw.
3778         * record-btrace.c:
3779         (get_thread_current_frame_id, record_btrace_start_replaying)
3780         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3781         (cmd_record_btrace_start): Replace throw_exception with throw.
3782         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3783         throw.
3784         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3785         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3786         * linespec.c:
3787         (find_linespec_symbols): Replace throw_exception with throw.
3788         * infrun.c (displaced_step_prepare, resume): Replace
3789         throw_exception with throw.
3790         * infcmd.c (post_create_inferior): Replace throw_exception with
3791         throw.
3792         * inf-loop.c (inferior_event_handler): Replace throw_exception
3793         with throw.
3794         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3795         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3796         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3797         (get_prev_frame_always, get_frame_pc_if_available)
3798         (get_frame_address_in_block_if_available, get_frame_language):
3799         Replace throw_exception with throw.
3800         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3801         throw_exception with throw.
3802         * eval.c (fetch_subexp_value, evaluate_var_value)
3803         (evaluate_funcall, evaluate_subexp_standard): Replace
3804         throw_exception with throw.
3805         * dwarf2loc.c (call_site_find_chain)
3806         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3807         Replace throw_exception with throw.
3808         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3809         with throw.
3810         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3811         throw.
3812         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3813         * completer.c (complete_line_internal): Replace throw_exception
3814         with throw.
3815         * compile/compile-object-run.c (compile_object_run): Replace
3816         throw_exception with throw.
3817         * cli/cli-script.c (process_next_line): Replace throw_exception
3818         with throw.
3819         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3820         (btrace_enable, btrace_maint_update_pt_packets): Replace
3821         throw_exception with throw.
3822         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3823         throw_exception with throw.
3824         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3825         throw_exception with throw.
3826         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3827         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3828         * aarch64-tdep.c (aarch64_make_prologue_cache)
3829         (aarch64_make_stub_cache): Replace throw_exception with throw.
3830
3831 2019-04-08  Tom Tromey  <tom@tromey.com>
3832
3833         * common/common-exceptions.c (throw_exception): Rename from
3834         throw_exception_cxx.  Remove old copy.  Make argument const.
3835         (throw_it): Create and throw exception objects directly.
3836         * common/common-exceptions.h (throw_exception): Make argument
3837         const.
3838         (struct gdb_exception_error): Add constructor.
3839         (struct gdb_exception_quit): Add constructor.
3840
3841 2019-04-08  Tom Tromey  <tom@tromey.com>
3842
3843         * common/common-exceptions.h (exception_rethrow): Don't declare.
3844         (TRY_SJLJ): Update comment.
3845         (TRY, CATCH, END_CATCH): Remove.
3846         * common/common-exceptions.c (exception_rethrow): Remove.
3847
3848 2019-04-08  Tom Tromey  <tom@tromey.com>
3849
3850         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3851         Remove.
3852         (gdb_exception_error): Rename from
3853         gdb_exception_RETURN_MASK_ERROR.
3854         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3855         (gdb_quit_bad_alloc): Update.
3856         * aarch64-tdep.c: Update.
3857         * ada-lang.c: Update.
3858         * ada-typeprint.c: Update.
3859         * ada-valprint.c: Update.
3860         * amd64-tdep.c: Update.
3861         * arch-utils.c: Update.
3862         * break-catch-throw.c: Update.
3863         * breakpoint.c: Update.
3864         * btrace.c: Update.
3865         * c-varobj.c: Update.
3866         * cli/cli-cmds.c: Update.
3867         * cli/cli-interp.c: Update.
3868         * cli/cli-script.c: Update.
3869         * common/common-exceptions.c: Update.
3870         * common/new-op.c: Update.
3871         * common/selftest.c: Update.
3872         * compile/compile-c-symbols.c: Update.
3873         * compile/compile-cplus-symbols.c: Update.
3874         * compile/compile-object-load.c: Update.
3875         * compile/compile-object-run.c: Update.
3876         * completer.c: Update.
3877         * corelow.c: Update.
3878         * cp-abi.c: Update.
3879         * cp-support.c: Update.
3880         * cp-valprint.c: Update.
3881         * darwin-nat.c: Update.
3882         * disasm-selftests.c: Update.
3883         * dtrace-probe.c: Update.
3884         * dwarf-index-cache.c: Update.
3885         * dwarf-index-write.c: Update.
3886         * dwarf2-frame-tailcall.c: Update.
3887         * dwarf2-frame.c: Update.
3888         * dwarf2loc.c: Update.
3889         * dwarf2read.c: Update.
3890         * eval.c: Update.
3891         * event-loop.c: Update.
3892         * event-top.c: Update.
3893         * exec.c: Update.
3894         * f-valprint.c: Update.
3895         * fbsd-tdep.c: Update.
3896         * frame-unwind.c: Update.
3897         * frame.c: Update.
3898         * gdbtypes.c: Update.
3899         * gnu-v3-abi.c: Update.
3900         * guile/guile-internal.h: Update.
3901         * guile/scm-block.c: Update.
3902         * guile/scm-breakpoint.c: Update.
3903         * guile/scm-cmd.c: Update.
3904         * guile/scm-disasm.c: Update.
3905         * guile/scm-frame.c: Update.
3906         * guile/scm-lazy-string.c: Update.
3907         * guile/scm-math.c: Update.
3908         * guile/scm-param.c: Update.
3909         * guile/scm-ports.c: Update.
3910         * guile/scm-pretty-print.c: Update.
3911         * guile/scm-symbol.c: Update.
3912         * guile/scm-symtab.c: Update.
3913         * guile/scm-type.c: Update.
3914         * guile/scm-value.c: Update.
3915         * i386-linux-tdep.c: Update.
3916         * i386-tdep.c: Update.
3917         * inf-loop.c: Update.
3918         * infcall.c: Update.
3919         * infcmd.c: Update.
3920         * infrun.c: Update.
3921         * jit.c: Update.
3922         * language.c: Update.
3923         * linespec.c: Update.
3924         * linux-fork.c: Update.
3925         * linux-nat.c: Update.
3926         * linux-tdep.c: Update.
3927         * linux-thread-db.c: Update.
3928         * main.c: Update.
3929         * mi/mi-cmd-break.c: Update.
3930         * mi/mi-cmd-stack.c: Update.
3931         * mi/mi-interp.c: Update.
3932         * mi/mi-main.c: Update.
3933         * objc-lang.c: Update.
3934         * p-valprint.c: Update.
3935         * parse.c: Update.
3936         * ppc-linux-tdep.c: Update.
3937         * printcmd.c: Update.
3938         * python/py-arch.c: Update.
3939         * python/py-breakpoint.c: Update.
3940         * python/py-cmd.c: Update.
3941         * python/py-finishbreakpoint.c: Update.
3942         * python/py-frame.c: Update.
3943         * python/py-framefilter.c: Update.
3944         * python/py-gdb-readline.c: Update.
3945         * python/py-inferior.c: Update.
3946         * python/py-infthread.c: Update.
3947         * python/py-lazy-string.c: Update.
3948         * python/py-linetable.c: Update.
3949         * python/py-objfile.c: Update.
3950         * python/py-param.c: Update.
3951         * python/py-prettyprint.c: Update.
3952         * python/py-progspace.c: Update.
3953         * python/py-record-btrace.c: Update.
3954         * python/py-record.c: Update.
3955         * python/py-symbol.c: Update.
3956         * python/py-type.c: Update.
3957         * python/py-unwind.c: Update.
3958         * python/py-utils.c: Update.
3959         * python/py-value.c: Update.
3960         * python/python.c: Update.
3961         * record-btrace.c: Update.
3962         * record-full.c: Update.
3963         * remote-fileio.c: Update.
3964         * remote.c: Update.
3965         * riscv-tdep.c: Update.
3966         * rs6000-aix-tdep.c: Update.
3967         * rs6000-tdep.c: Update.
3968         * rust-exp.y: Update.
3969         * rust-lang.c: Update.
3970         * s390-tdep.c: Update.
3971         * selftest-arch.c: Update.
3972         * solib-dsbt.c: Update.
3973         * solib-frv.c: Update.
3974         * solib-spu.c: Update.
3975         * solib-svr4.c: Update.
3976         * solib.c: Update.
3977         * sparc64-linux-tdep.c: Update.
3978         * stack.c: Update.
3979         * symfile-mem.c: Update.
3980         * symmisc.c: Update.
3981         * target.c: Update.
3982         * thread.c: Update.
3983         * top.c: Update.
3984         * tracefile-tfile.c: Update.
3985         * tui/tui.c: Update.
3986         * typeprint.c: Update.
3987         * unittests/cli-utils-selftests.c: Update.
3988         * unittests/parse-connection-spec-selftests.c: Update.
3989         * valops.c: Update.
3990         * valprint.c: Update.
3991         * value.c: Update.
3992         * varobj.c: Update.
3993         * windows-nat.c: Update.
3994         * x86-linux-nat.c: Update.
3995         * xml-support.c: Update.
3996
3997 2019-04-08  Tom Tromey  <tom@tromey.com>
3998
3999         * xml-support.c: Use C++ exception handling.
4000         * x86-linux-nat.c: Use C++ exception handling.
4001         * windows-nat.c: Use C++ exception handling.
4002         * varobj.c: Use C++ exception handling.
4003         * value.c: Use C++ exception handling.
4004         * valprint.c: Use C++ exception handling.
4005         * valops.c: Use C++ exception handling.
4006         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4007         handling.
4008         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4009         * typeprint.c: Use C++ exception handling.
4010         * tui/tui.c: Use C++ exception handling.
4011         * tracefile-tfile.c: Use C++ exception handling.
4012         * top.c: Use C++ exception handling.
4013         * thread.c: Use C++ exception handling.
4014         * target.c: Use C++ exception handling.
4015         * symmisc.c: Use C++ exception handling.
4016         * symfile-mem.c: Use C++ exception handling.
4017         * stack.c: Use C++ exception handling.
4018         * sparc64-linux-tdep.c: Use C++ exception handling.
4019         * solib.c: Use C++ exception handling.
4020         * solib-svr4.c: Use C++ exception handling.
4021         * solib-spu.c: Use C++ exception handling.
4022         * solib-frv.c: Use C++ exception handling.
4023         * solib-dsbt.c: Use C++ exception handling.
4024         * selftest-arch.c: Use C++ exception handling.
4025         * s390-tdep.c: Use C++ exception handling.
4026         * rust-lang.c: Use C++ exception handling.
4027         * rust-exp.y: Use C++ exception handling.
4028         * rs6000-tdep.c: Use C++ exception handling.
4029         * rs6000-aix-tdep.c: Use C++ exception handling.
4030         * riscv-tdep.c: Use C++ exception handling.
4031         * remote.c: Use C++ exception handling.
4032         * remote-fileio.c: Use C++ exception handling.
4033         * record-full.c: Use C++ exception handling.
4034         * record-btrace.c: Use C++ exception handling.
4035         * python/python.c: Use C++ exception handling.
4036         * python/py-value.c: Use C++ exception handling.
4037         * python/py-utils.c: Use C++ exception handling.
4038         * python/py-unwind.c: Use C++ exception handling.
4039         * python/py-type.c: Use C++ exception handling.
4040         * python/py-symbol.c: Use C++ exception handling.
4041         * python/py-record.c: Use C++ exception handling.
4042         * python/py-record-btrace.c: Use C++ exception handling.
4043         * python/py-progspace.c: Use C++ exception handling.
4044         * python/py-prettyprint.c: Use C++ exception handling.
4045         * python/py-param.c: Use C++ exception handling.
4046         * python/py-objfile.c: Use C++ exception handling.
4047         * python/py-linetable.c: Use C++ exception handling.
4048         * python/py-lazy-string.c: Use C++ exception handling.
4049         * python/py-infthread.c: Use C++ exception handling.
4050         * python/py-inferior.c: Use C++ exception handling.
4051         * python/py-gdb-readline.c: Use C++ exception handling.
4052         * python/py-framefilter.c: Use C++ exception handling.
4053         * python/py-frame.c: Use C++ exception handling.
4054         * python/py-finishbreakpoint.c: Use C++ exception handling.
4055         * python/py-cmd.c: Use C++ exception handling.
4056         * python/py-breakpoint.c: Use C++ exception handling.
4057         * python/py-arch.c: Use C++ exception handling.
4058         * printcmd.c: Use C++ exception handling.
4059         * ppc-linux-tdep.c: Use C++ exception handling.
4060         * parse.c: Use C++ exception handling.
4061         * p-valprint.c: Use C++ exception handling.
4062         * objc-lang.c: Use C++ exception handling.
4063         * mi/mi-main.c: Use C++ exception handling.
4064         * mi/mi-interp.c: Use C++ exception handling.
4065         * mi/mi-cmd-stack.c: Use C++ exception handling.
4066         * mi/mi-cmd-break.c: Use C++ exception handling.
4067         * main.c: Use C++ exception handling.
4068         * linux-thread-db.c: Use C++ exception handling.
4069         * linux-tdep.c: Use C++ exception handling.
4070         * linux-nat.c: Use C++ exception handling.
4071         * linux-fork.c: Use C++ exception handling.
4072         * linespec.c: Use C++ exception handling.
4073         * language.c: Use C++ exception handling.
4074         * jit.c: Use C++ exception handling.
4075         * infrun.c: Use C++ exception handling.
4076         * infcmd.c: Use C++ exception handling.
4077         * infcall.c: Use C++ exception handling.
4078         * inf-loop.c: Use C++ exception handling.
4079         * i386-tdep.c: Use C++ exception handling.
4080         * i386-linux-tdep.c: Use C++ exception handling.
4081         * guile/scm-value.c: Use C++ exception handling.
4082         * guile/scm-type.c: Use C++ exception handling.
4083         * guile/scm-symtab.c: Use C++ exception handling.
4084         * guile/scm-symbol.c: Use C++ exception handling.
4085         * guile/scm-pretty-print.c: Use C++ exception handling.
4086         * guile/scm-ports.c: Use C++ exception handling.
4087         * guile/scm-param.c: Use C++ exception handling.
4088         * guile/scm-math.c: Use C++ exception handling.
4089         * guile/scm-lazy-string.c: Use C++ exception handling.
4090         * guile/scm-frame.c: Use C++ exception handling.
4091         * guile/scm-disasm.c: Use C++ exception handling.
4092         * guile/scm-cmd.c: Use C++ exception handling.
4093         * guile/scm-breakpoint.c: Use C++ exception handling.
4094         * guile/scm-block.c: Use C++ exception handling.
4095         * guile/guile-internal.h: Use C++ exception handling.
4096         * gnu-v3-abi.c: Use C++ exception handling.
4097         * gdbtypes.c: Use C++ exception handling.
4098         * frame.c: Use C++ exception handling.
4099         * frame-unwind.c: Use C++ exception handling.
4100         * fbsd-tdep.c: Use C++ exception handling.
4101         * f-valprint.c: Use C++ exception handling.
4102         * exec.c: Use C++ exception handling.
4103         * event-top.c: Use C++ exception handling.
4104         * event-loop.c: Use C++ exception handling.
4105         * eval.c: Use C++ exception handling.
4106         * dwarf2read.c: Use C++ exception handling.
4107         * dwarf2loc.c: Use C++ exception handling.
4108         * dwarf2-frame.c: Use C++ exception handling.
4109         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4110         * dwarf-index-write.c: Use C++ exception handling.
4111         * dwarf-index-cache.c: Use C++ exception handling.
4112         * dtrace-probe.c: Use C++ exception handling.
4113         * disasm-selftests.c: Use C++ exception handling.
4114         * darwin-nat.c: Use C++ exception handling.
4115         * cp-valprint.c: Use C++ exception handling.
4116         * cp-support.c: Use C++ exception handling.
4117         * cp-abi.c: Use C++ exception handling.
4118         * corelow.c: Use C++ exception handling.
4119         * completer.c: Use C++ exception handling.
4120         * compile/compile-object-run.c: Use C++ exception handling.
4121         * compile/compile-object-load.c: Use C++ exception handling.
4122         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4123         * compile/compile-c-symbols.c: Use C++ exception handling.
4124         * common/selftest.c: Use C++ exception handling.
4125         * common/new-op.c: Use C++ exception handling.
4126         * cli/cli-script.c: Use C++ exception handling.
4127         * cli/cli-interp.c: Use C++ exception handling.
4128         * cli/cli-cmds.c: Use C++ exception handling.
4129         * c-varobj.c: Use C++ exception handling.
4130         * btrace.c: Use C++ exception handling.
4131         * breakpoint.c: Use C++ exception handling.
4132         * break-catch-throw.c: Use C++ exception handling.
4133         * arch-utils.c: Use C++ exception handling.
4134         * amd64-tdep.c: Use C++ exception handling.
4135         * ada-valprint.c: Use C++ exception handling.
4136         * ada-typeprint.c: Use C++ exception handling.
4137         * ada-lang.c: Use C++ exception handling.
4138         * aarch64-tdep.c: Use C++ exception handling.
4139
4140 2019-04-08  Tom Tromey  <tom@tromey.com>
4141
4142         * xml-support.c (gdb_xml_parser::parse): Update.
4143         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4144         * value.c (show_convenience): Update.
4145         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4146         (test_parse_flags_qcs): Update.
4147         * thread.c (thr_try_catch_cmd): Update.
4148         * target.c (target_translate_tls_address): Update.
4149         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4150         (info_frame_command_core, frame_apply_command_count): Update.
4151         * rust-exp.y (rust_lex_exception_test): Update.
4152         * riscv-tdep.c (riscv_print_one_register_info): Update.
4153         * remote.c (remote_target::enable_btrace): Update.
4154         * record-btrace.c (record_btrace_enable_warn): Update.
4155         * python/py-utils.c (gdbpy_convert_exception): Update.
4156         * printcmd.c (do_one_display, print_variable_and_value): Update.
4157         * mi/mi-main.c (mi_print_exception): Update.
4158         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4159         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4160         * linux-nat.c (linux_nat_target::attach): Update.
4161         * linux-fork.c (class scoped_switch_fork_info): Update.
4162         * infrun.c (displaced_step_prepare): Update.
4163         * infcall.c (call_function_by_hand_dummy): Update.
4164         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4165         * gnu-v3-abi.c (print_one_vtable): Update.
4166         * frame.c (get_prev_frame_always): Update.
4167         * f-valprint.c (info_common_command_for_block): Update.
4168         * exec.c (try_open_exec_file): Update.
4169         * exceptions.c (print_exception, exception_print)
4170         (exception_fprintf, exception_print_same): Update.
4171         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4172         * dwarf-index-cache.c (index_cache::store)
4173         (index_cache::lookup_gdb_index): Update.
4174         * darwin-nat.c (maybe_cache_shell): Update.
4175         * cp-valprint.c (cp_print_value_fields): Update.
4176         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4177         (gcc_cplus_symbol_address): Update.
4178         * compile/compile-c-symbols.c (gcc_convert_symbol)
4179         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4180         * common/selftest.c: Update.
4181         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4182         a std::string.
4183         (exception_try_scope_entry, exception_try_scope_exit): Don't
4184         declare.
4185         (struct exception_try_scope): Remove.
4186         (TRY): Don't use exception_try_scope.
4187         (struct gdb_exception): Add constructor, operator=.
4188         <what>: New method.
4189         (struct gdb_exception_RETURN_MASK_ALL)
4190         (struct gdb_exception_RETURN_MASK_ERROR)
4191         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4192         (struct gdb_quit_bad_alloc): Update.
4193         * common/common-exceptions.c (exception_none): Change
4194         initializer.
4195         (struct catcher) <state, exception>: Initialize inline.
4196         <prev>: Remove member.
4197         (current_catcher): Remove.
4198         (catchers): New global.
4199         (exceptions_state_mc_init): Simplify.
4200         (catcher_pop): Remove.
4201         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4202         (try_scope_depth, exception_try_scope_entry)
4203         (exception_try_scope_exit): Remove.
4204         (throw_exception_sjlj): Update.
4205         (exception_messages, exception_messages_size): Remove.
4206         (throw_it): Simplify.
4207         (gdb_exception_sliced_copy): Remove.
4208         (throw_exception_cxx): Update.
4209         * cli/cli-script.c (script_from_file): Update.
4210         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4211         Update.
4212         * ada-valprint.c (ada_val_print): Update.
4213         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4214         (create_excep_cond_exprs): Update.
4215
4216 2019-04-08  Tom Tromey  <tom@tromey.com>
4217
4218         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4219         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4220         (TRY, CATCH, END_CATCH): Remove some definitions.
4221         * common/common-exceptions.c: Don't use GDB_XCPT.
4222         (catcher_list_size): Remove.
4223         (throw_exception, throw_it): Simplify.
4224
4225 2019-04-05  Tom Tromey  <tom@tromey.com>
4226
4227         Revert the header-sorting patch.
4228         * ft32-tdep.c: Revert.
4229         * frv-tdep.c: Revert.
4230         * frv-linux-tdep.c: Revert.
4231         * frame.c: Revert.
4232         * frame-unwind.c: Revert.
4233         * frame-base.c: Revert.
4234         * fork-child.c: Revert.
4235         * findvar.c: Revert.
4236         * findcmd.c: Revert.
4237         * filesystem.c: Revert.
4238         * filename-seen-cache.h: Revert.
4239         * filename-seen-cache.c: Revert.
4240         * fbsd-tdep.c: Revert.
4241         * fbsd-nat.h: Revert.
4242         * fbsd-nat.c: Revert.
4243         * f-valprint.c: Revert.
4244         * f-typeprint.c: Revert.
4245         * f-lang.c: Revert.
4246         * extension.h: Revert.
4247         * extension.c: Revert.
4248         * extension-priv.h: Revert.
4249         * expprint.c: Revert.
4250         * exec.h: Revert.
4251         * exec.c: Revert.
4252         * exceptions.c: Revert.
4253         * event-top.c: Revert.
4254         * event-loop.c: Revert.
4255         * eval.c: Revert.
4256         * elfread.c: Revert.
4257         * dwarf2read.h: Revert.
4258         * dwarf2read.c: Revert.
4259         * dwarf2loc.c: Revert.
4260         * dwarf2expr.h: Revert.
4261         * dwarf2expr.c: Revert.
4262         * dwarf2-frame.c: Revert.
4263         * dwarf2-frame-tailcall.c: Revert.
4264         * dwarf-index-write.h: Revert.
4265         * dwarf-index-write.c: Revert.
4266         * dwarf-index-common.c: Revert.
4267         * dwarf-index-cache.h: Revert.
4268         * dwarf-index-cache.c: Revert.
4269         * dummy-frame.c: Revert.
4270         * dtrace-probe.c: Revert.
4271         * disasm.h: Revert.
4272         * disasm.c: Revert.
4273         * disasm-selftests.c: Revert.
4274         * dictionary.c: Revert.
4275         * dicos-tdep.c: Revert.
4276         * demangle.c: Revert.
4277         * dcache.h: Revert.
4278         * dcache.c: Revert.
4279         * darwin-nat.h: Revert.
4280         * darwin-nat.c: Revert.
4281         * darwin-nat-info.c: Revert.
4282         * d-valprint.c: Revert.
4283         * d-namespace.c: Revert.
4284         * d-lang.c: Revert.
4285         * ctf.c: Revert.
4286         * csky-tdep.c: Revert.
4287         * csky-linux-tdep.c: Revert.
4288         * cris-tdep.c: Revert.
4289         * cris-linux-tdep.c: Revert.
4290         * cp-valprint.c: Revert.
4291         * cp-support.c: Revert.
4292         * cp-namespace.c: Revert.
4293         * cp-abi.c: Revert.
4294         * corelow.c: Revert.
4295         * corefile.c: Revert.
4296         * continuations.c: Revert.
4297         * completer.h: Revert.
4298         * completer.c: Revert.
4299         * complaints.c: Revert.
4300         * coffread.c: Revert.
4301         * coff-pe-read.c: Revert.
4302         * cli-out.h: Revert.
4303         * cli-out.c: Revert.
4304         * charset.c: Revert.
4305         * c-varobj.c: Revert.
4306         * c-valprint.c: Revert.
4307         * c-typeprint.c: Revert.
4308         * c-lang.c: Revert.
4309         * buildsym.c: Revert.
4310         * buildsym-legacy.c: Revert.
4311         * build-id.h: Revert.
4312         * build-id.c: Revert.
4313         * btrace.c: Revert.
4314         * bsd-uthread.c: Revert.
4315         * breakpoint.h: Revert.
4316         * breakpoint.c: Revert.
4317         * break-catch-throw.c: Revert.
4318         * break-catch-syscall.c: Revert.
4319         * break-catch-sig.c: Revert.
4320         * blockframe.c: Revert.
4321         * block.c: Revert.
4322         * bfin-tdep.c: Revert.
4323         * bfin-linux-tdep.c: Revert.
4324         * bfd-target.c: Revert.
4325         * bcache.c: Revert.
4326         * ax-general.c: Revert.
4327         * ax-gdb.h: Revert.
4328         * ax-gdb.c: Revert.
4329         * avr-tdep.c: Revert.
4330         * auxv.c: Revert.
4331         * auto-load.c: Revert.
4332         * arm-wince-tdep.c: Revert.
4333         * arm-tdep.c: Revert.
4334         * arm-symbian-tdep.c: Revert.
4335         * arm-pikeos-tdep.c: Revert.
4336         * arm-obsd-tdep.c: Revert.
4337         * arm-nbsd-tdep.c: Revert.
4338         * arm-nbsd-nat.c: Revert.
4339         * arm-linux-tdep.c: Revert.
4340         * arm-linux-nat.c: Revert.
4341         * arm-fbsd-tdep.c: Revert.
4342         * arm-fbsd-nat.c: Revert.
4343         * arm-bsd-tdep.c: Revert.
4344         * arch-utils.c: Revert.
4345         * arc-tdep.c: Revert.
4346         * arc-newlib-tdep.c: Revert.
4347         * annotate.h: Revert.
4348         * annotate.c: Revert.
4349         * amd64-windows-tdep.c: Revert.
4350         * amd64-windows-nat.c: Revert.
4351         * amd64-tdep.c: Revert.
4352         * amd64-sol2-tdep.c: Revert.
4353         * amd64-obsd-tdep.c: Revert.
4354         * amd64-obsd-nat.c: Revert.
4355         * amd64-nbsd-tdep.c: Revert.
4356         * amd64-nbsd-nat.c: Revert.
4357         * amd64-nat.c: Revert.
4358         * amd64-linux-tdep.c: Revert.
4359         * amd64-linux-nat.c: Revert.
4360         * amd64-fbsd-tdep.c: Revert.
4361         * amd64-fbsd-nat.c: Revert.
4362         * amd64-dicos-tdep.c: Revert.
4363         * amd64-darwin-tdep.c: Revert.
4364         * amd64-bsd-nat.c: Revert.
4365         * alpha-tdep.c: Revert.
4366         * alpha-obsd-tdep.c: Revert.
4367         * alpha-nbsd-tdep.c: Revert.
4368         * alpha-mdebug-tdep.c: Revert.
4369         * alpha-linux-tdep.c: Revert.
4370         * alpha-linux-nat.c: Revert.
4371         * alpha-bsd-tdep.c: Revert.
4372         * alpha-bsd-nat.c: Revert.
4373         * aix-thread.c: Revert.
4374         * agent.c: Revert.
4375         * addrmap.c: Revert.
4376         * ada-varobj.c: Revert.
4377         * ada-valprint.c: Revert.
4378         * ada-typeprint.c: Revert.
4379         * ada-tasks.c: Revert.
4380         * ada-lang.c: Revert.
4381         * aarch64-tdep.c: Revert.
4382         * aarch64-ravenscar-thread.c: Revert.
4383         * aarch64-newlib-tdep.c: Revert.
4384         * aarch64-linux-tdep.c: Revert.
4385         * aarch64-linux-nat.c: Revert.
4386         * aarch64-fbsd-tdep.c: Revert.
4387         * aarch64-fbsd-nat.c: Revert.
4388         * aarch32-linux-nat.c: Revert.
4389
4390 2019-04-05  Tom Tromey  <tom@tromey.com>
4391
4392         * ft32-tdep.c: Sort headers.
4393         * frv-tdep.c: Sort headers.
4394         * frv-linux-tdep.c: Sort headers.
4395         * frame.c: Sort headers.
4396         * frame-unwind.c: Sort headers.
4397         * frame-base.c: Sort headers.
4398         * fork-child.c: Sort headers.
4399         * findvar.c: Sort headers.
4400         * findcmd.c: Sort headers.
4401         * filesystem.c: Sort headers.
4402         * filename-seen-cache.h: Sort headers.
4403         * filename-seen-cache.c: Sort headers.
4404         * fbsd-tdep.c: Sort headers.
4405         * fbsd-nat.h: Sort headers.
4406         * fbsd-nat.c: Sort headers.
4407         * f-valprint.c: Sort headers.
4408         * f-typeprint.c: Sort headers.
4409         * f-lang.c: Sort headers.
4410         * extension.h: Sort headers.
4411         * extension.c: Sort headers.
4412         * extension-priv.h: Sort headers.
4413         * expprint.c: Sort headers.
4414         * exec.h: Sort headers.
4415         * exec.c: Sort headers.
4416         * exceptions.c: Sort headers.
4417         * event-top.c: Sort headers.
4418         * event-loop.c: Sort headers.
4419         * eval.c: Sort headers.
4420         * elfread.c: Sort headers.
4421         * dwarf2read.h: Sort headers.
4422         * dwarf2read.c: Sort headers.
4423         * dwarf2loc.c: Sort headers.
4424         * dwarf2expr.h: Sort headers.
4425         * dwarf2expr.c: Sort headers.
4426         * dwarf2-frame.c: Sort headers.
4427         * dwarf2-frame-tailcall.c: Sort headers.
4428         * dwarf-index-write.h: Sort headers.
4429         * dwarf-index-write.c: Sort headers.
4430         * dwarf-index-common.c: Sort headers.
4431         * dwarf-index-cache.h: Sort headers.
4432         * dwarf-index-cache.c: Sort headers.
4433         * dummy-frame.c: Sort headers.
4434         * dtrace-probe.c: Sort headers.
4435         * disasm.h: Sort headers.
4436         * disasm.c: Sort headers.
4437         * disasm-selftests.c: Sort headers.
4438         * dictionary.c: Sort headers.
4439         * dicos-tdep.c: Sort headers.
4440         * demangle.c: Sort headers.
4441         * dcache.h: Sort headers.
4442         * dcache.c: Sort headers.
4443         * darwin-nat.h: Sort headers.
4444         * darwin-nat.c: Sort headers.
4445         * darwin-nat-info.c: Sort headers.
4446         * d-valprint.c: Sort headers.
4447         * d-namespace.c: Sort headers.
4448         * d-lang.c: Sort headers.
4449         * ctf.c: Sort headers.
4450         * csky-tdep.c: Sort headers.
4451         * csky-linux-tdep.c: Sort headers.
4452         * cris-tdep.c: Sort headers.
4453         * cris-linux-tdep.c: Sort headers.
4454         * cp-valprint.c: Sort headers.
4455         * cp-support.c: Sort headers.
4456         * cp-namespace.c: Sort headers.
4457         * cp-abi.c: Sort headers.
4458         * corelow.c: Sort headers.
4459         * corefile.c: Sort headers.
4460         * continuations.c: Sort headers.
4461         * completer.h: Sort headers.
4462         * completer.c: Sort headers.
4463         * complaints.c: Sort headers.
4464         * coffread.c: Sort headers.
4465         * coff-pe-read.c: Sort headers.
4466         * cli-out.h: Sort headers.
4467         * cli-out.c: Sort headers.
4468         * charset.c: Sort headers.
4469         * c-varobj.c: Sort headers.
4470         * c-valprint.c: Sort headers.
4471         * c-typeprint.c: Sort headers.
4472         * c-lang.c: Sort headers.
4473         * buildsym.c: Sort headers.
4474         * buildsym-legacy.c: Sort headers.
4475         * build-id.h: Sort headers.
4476         * build-id.c: Sort headers.
4477         * btrace.c: Sort headers.
4478         * bsd-uthread.c: Sort headers.
4479         * breakpoint.h: Sort headers.
4480         * breakpoint.c: Sort headers.
4481         * break-catch-throw.c: Sort headers.
4482         * break-catch-syscall.c: Sort headers.
4483         * break-catch-sig.c: Sort headers.
4484         * blockframe.c: Sort headers.
4485         * block.c: Sort headers.
4486         * bfin-tdep.c: Sort headers.
4487         * bfin-linux-tdep.c: Sort headers.
4488         * bfd-target.c: Sort headers.
4489         * bcache.c: Sort headers.
4490         * ax-general.c: Sort headers.
4491         * ax-gdb.h: Sort headers.
4492         * ax-gdb.c: Sort headers.
4493         * avr-tdep.c: Sort headers.
4494         * auxv.c: Sort headers.
4495         * auto-load.c: Sort headers.
4496         * arm-wince-tdep.c: Sort headers.
4497         * arm-tdep.c: Sort headers.
4498         * arm-symbian-tdep.c: Sort headers.
4499         * arm-pikeos-tdep.c: Sort headers.
4500         * arm-obsd-tdep.c: Sort headers.
4501         * arm-nbsd-tdep.c: Sort headers.
4502         * arm-nbsd-nat.c: Sort headers.
4503         * arm-linux-tdep.c: Sort headers.
4504         * arm-linux-nat.c: Sort headers.
4505         * arm-fbsd-tdep.c: Sort headers.
4506         * arm-fbsd-nat.c: Sort headers.
4507         * arm-bsd-tdep.c: Sort headers.
4508         * arch-utils.c: Sort headers.
4509         * arc-tdep.c: Sort headers.
4510         * arc-newlib-tdep.c: Sort headers.
4511         * annotate.h: Sort headers.
4512         * annotate.c: Sort headers.
4513         * amd64-windows-tdep.c: Sort headers.
4514         * amd64-windows-nat.c: Sort headers.
4515         * amd64-tdep.c: Sort headers.
4516         * amd64-sol2-tdep.c: Sort headers.
4517         * amd64-obsd-tdep.c: Sort headers.
4518         * amd64-obsd-nat.c: Sort headers.
4519         * amd64-nbsd-tdep.c: Sort headers.
4520         * amd64-nbsd-nat.c: Sort headers.
4521         * amd64-nat.c: Sort headers.
4522         * amd64-linux-tdep.c: Sort headers.
4523         * amd64-linux-nat.c: Sort headers.
4524         * amd64-fbsd-tdep.c: Sort headers.
4525         * amd64-fbsd-nat.c: Sort headers.
4526         * amd64-dicos-tdep.c: Sort headers.
4527         * amd64-darwin-tdep.c: Sort headers.
4528         * amd64-bsd-nat.c: Sort headers.
4529         * alpha-tdep.c: Sort headers.
4530         * alpha-obsd-tdep.c: Sort headers.
4531         * alpha-nbsd-tdep.c: Sort headers.
4532         * alpha-mdebug-tdep.c: Sort headers.
4533         * alpha-linux-tdep.c: Sort headers.
4534         * alpha-linux-nat.c: Sort headers.
4535         * alpha-bsd-tdep.c: Sort headers.
4536         * alpha-bsd-nat.c: Sort headers.
4537         * aix-thread.c: Sort headers.
4538         * agent.c: Sort headers.
4539         * addrmap.c: Sort headers.
4540         * ada-varobj.c: Sort headers.
4541         * ada-valprint.c: Sort headers.
4542         * ada-typeprint.c: Sort headers.
4543         * ada-tasks.c: Sort headers.
4544         * ada-lang.c: Sort headers.
4545         * aarch64-tdep.c: Sort headers.
4546         * aarch64-ravenscar-thread.c: Sort headers.
4547         * aarch64-newlib-tdep.c: Sort headers.
4548         * aarch64-linux-tdep.c: Sort headers.
4549         * aarch64-linux-nat.c: Sort headers.
4550         * aarch64-fbsd-tdep.c: Sort headers.
4551         * aarch64-fbsd-nat.c: Sort headers.
4552         * aarch32-linux-nat.c: Sort headers.
4553
4554 2019-04-04  Tom Tromey  <tom@tromey.com>
4555
4556         * varobj.c (varobj_create): Update.
4557         * rust-exp.y (struct rust_parser) <update_innermost_block,
4558         lookup_symbol>: New methods.
4559         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4560         Rename.
4561         (rust_parser::rust_lookup_type)
4562         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4563         * printcmd.c (display_command, do_one_display): Update.
4564         * parser-defs.h (struct parser_state) <parser_state>: Add
4565         "tracker" parameter.
4566         (block_tracker): New member.
4567         (class innermost_block_tracker) <innermost_block_tracker>: Add
4568         "types" parameter.
4569         <reset>: Remove method.
4570         (innermost_block): Don't declare.
4571         (null_post_parser): Update.
4572         * parse.c (innermost_block): Remove global.
4573         (write_dollar_variable): Update.
4574         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4575         Remove "tracker_types" parameter.
4576         (parse_expression): Add "tracker" parameter.
4577         (parse_expression_for_completion): Update.
4578         (null_post_parser): Add "tracker" parameter.
4579         * p-exp.y: Update rules.
4580         * m2-exp.y: Update rules.
4581         * language.h (struct language_defn) <la_post_parser>: Add
4582         "tracker" parameter.
4583         * go-exp.y: Update rules.
4584         * f-exp.y: Update rules.
4585         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4586         parameter.
4587         * d-exp.y: Update rules.
4588         * c-exp.y: Update rules.
4589         * breakpoint.c (set_breakpoint_condition): Create an
4590         innermost_block_tracker.
4591         (watch_command_1): Likewise.
4592         * ada-lang.c (resolve): Add "tracker" parameter.
4593         (resolve_subexp): Likewise.
4594         * ada-exp.y (write_var_from_sym): Update.
4595
4596 2019-04-04  Tom Tromey  <tom@tromey.com>
4597
4598         * type-stack.h: New file.
4599         * type-stack.c: New file.
4600         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4601         type-stack.h.
4602         (insert_into_type_stack, insert_type, push_type, push_type_int)
4603         (insert_type_address_space, pop_type, pop_type_int)
4604         (pop_typelist, pop_type_stack, append_type_stack)
4605         (push_type_stack, get_type_stack, push_typelist)
4606         (follow_type_instance_flags, follow_types): Don't declare.
4607         * parse.c (type_stack): Remove global.
4608         (parse_exp_in_context): Update.
4609         (insert_into_type_stack, insert_type, push_type, push_type_int)
4610         (insert_type_address_space, pop_type, pop_type_int)
4611         (pop_typelist, pop_type_stack, append_type_stack)
4612         (push_type_stack, get_type_stack, push_typelist)
4613         (follow_type_instance_flags, follow_types): Remove (moved to
4614         type-stack.c).
4615         * f-exp.y (type_stack): New global.
4616         Update rules.
4617         (push_kind_type, f_parse): Update.
4618         * d-exp.y (type_stack): New global.
4619         Update rules.
4620         (d_parse): Update.
4621         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4622         Update rules.
4623         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4624         (HFILES_NO_SRCDIR): Add type-stack.h.
4625
4626 2019-04-04  Tom Tromey  <tom@tromey.com>
4627
4628         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4629         (rust_parser::convert_ast_to_expression, rust_parse)
4630         (rust_lex_test_completion, rust_lex_tests): Update.
4631         * parser-defs.h (struct expr_completion_state): New.
4632         (struct parser_state) <parser_state>: Add completion parameter.
4633         <mark_struct_expression, mark_completion_tag>: New methods.
4634         <parse_completion, m_completion_state>: New members.
4635         (prefixify_expression, null_post_parser): Update.
4636         (mark_struct_expression, mark_completion_tag): Don't declare.
4637         * parse.c (parse_completion, expout_last_struct)
4638         (expout_tag_completion_type, expout_completion_name): Remove
4639         globals.
4640         (parser_state::mark_struct_expression)
4641         (parser_state::mark_completion_tag): Now methods.
4642         (prefixify_expression): Add last_struct parameter.
4643         (prefixify_subexp): Likewise.
4644         (parse_exp_1): Update.
4645         (parse_exp_in_context): Add cstate parameter.  Update.
4646         (parse_expression_for_completion): Create an
4647         expr_completion_state.
4648         (null_post_parser): Add "completion" parameter.
4649         * p-exp.y: Update rules.
4650         (yylex): Update.
4651         * language.h (struct language_defn) <la_post_parser>: Add
4652         "completing" parameter.
4653         * go-exp.y: Update rules.
4654         (lex_one_token): Update.
4655         * expression.h (parse_completion): Don't declare.
4656         * d-exp.y: Update rules.
4657         (lex_one_token): Update rules.
4658         * c-exp.y: Update rules.
4659         (lex_one_token): Update.
4660         * ada-lang.c (resolve): Add "parse_completion" parameter.
4661         (resolve_subexp): Likewise.
4662         (ada_resolve_function): Likewise.
4663
4664 2019-04-04  Tom Tromey  <tom@tromey.com>
4665
4666         * parser-defs.h (struct parser_state) <start_arglist,
4667         end_arglist>: New methods.
4668         <arglist_len, m_funcall_chain>: New members.
4669         (arglist_len, start_arglist, end_arglist): Don't declare.
4670         * parse.c (arglist_len, funcall_chain): Remove global.
4671         (start_arglist, end_arglist): Remove functions.
4672         (parse_exp_in_context): Update.
4673         * p-exp.y: Update rules.
4674         * m2-exp.y: Update rules.
4675         * go-exp.y: Update rules.
4676         * f-exp.y: Update rules.
4677         * d-exp.y: Update rules.
4678         * c-exp.y: Update rules.
4679
4680 2019-04-04  Tom Tromey  <tom@tromey.com>
4681
4682         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4683         lex_operator, push_back>: New methods.
4684         Update all rules.
4685         (rust_parser::lex_hex, lex_escape): Rename and update.
4686         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4687         (rust_parser::lex_operator): Rename and update.
4688         (rust_parser::lex_number, rustyylex, rustyyerror)
4689         (rust_lex_test_init, rust_lex_test_sequence)
4690         (rust_lex_test_push_back, rust_lex_tests): Update.
4691         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4692         parameter.
4693         <lexptr, prev_lexptr>: New members.
4694         (lexptr, prev_lexptr): Don't declare.
4695         * parse.c (lexptr, prev_lexptr): Remove globals.
4696         (parse_exp_in_context): Update.
4697         * p-exp.y (yylex, yyerror): Update.
4698         * m2-exp.y (parse_number, yylex, yyerror): Update.
4699         * go-exp.y (lex_one_token, yyerror): Update.
4700         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4701         * d-exp.y (lex_one_token, yyerror): Update.
4702         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4703         (lex_one_token, yyerror): Update.
4704         * ada-lex.l (YY_INPUT): Update.
4705         (rewind_to_char): Update.
4706         * ada-exp.y (yyerror): Update.
4707
4708 2019-04-04  Tom Tromey  <tom@tromey.com>
4709
4710         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4711         * parser-defs.h (struct parser_state) <parser_state>: Add new
4712         parameter.
4713         <comma_terminates>: New member.
4714         (comma_terminates): Don't declare global.
4715         * parse.c (comma_terminates): Remove global.
4716         (parse_exp_in_context): Update.
4717         * p-exp.y (yylex): Update.
4718         * m2-exp.y (yylex): Update.
4719         * go-exp.y (lex_one_token): Update.
4720         * f-exp.y (yylex): Update.
4721         * d-exp.y (lex_one_token): Update.
4722         * c-exp.y (lex_one_token): Update.
4723         * ada-lex.l: Update.
4724
4725 2019-04-04  Tom Tromey  <tom@tromey.com>
4726
4727         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4728         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4729         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4730         * parser-defs.h (paren_depth): Don't declare.
4731         * parse.c (paren_depth): Remove global.
4732         (parse_exp_in_context): Update.
4733         * p-exp.y (paren_depth): New global.
4734         (pascal_parse): Initialize it.
4735         * m2-exp.y (paren_depth): New global.
4736         (m2_parse): Initialize it.
4737         * go-exp.y (paren_depth): New global.
4738         (go_parse): Initialize it.
4739         * f-exp.y (paren_depth): New global.
4740         (f_parse): Initialize it.
4741         * d-exp.y (paren_depth): New global.
4742         (d_parse): Initialize it.
4743         * c-exp.y (paren_depth): New global.
4744         (c_parse): Initialize it.
4745         * ada-lex.l (paren_depth): New global.
4746         (lexer_init): Initialize it.
4747
4748 2019-04-04  Tom Tromey  <tom@tromey.com>
4749
4750         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4751         (rust_parser::convert_ast_to_type)
4752         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4753         * parser-defs.h (struct parser_state) <parser_state>: Add
4754         parameters.  Initialize new members.
4755         <expression_context_block, expression_context_pc>: New members.
4756         * parse.c (expression_context_block, expression_context_pc):
4757         Remove globals.
4758         (parse_exp_in_context): Update.
4759         * p-exp.y: Update all rules.
4760         (yylex): Update.
4761         * m2-exp.y: Update all rules.
4762         (yylex): Update.
4763         * go-exp.y (yylex): Update.
4764         * f-exp.y (yylex): Update.
4765         * d-exp.y: Update all rules.
4766         (yylex): Update.
4767         * c-exp.y: Update all rules.
4768         (lex_one_token, classify_name, yylex, c_parse): Update.
4769         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4770
4771 2019-04-04  Tom Tromey  <tom@tromey.com>
4772
4773         * gdbarch.h, gdbarch.c: Rebuild.
4774         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4775         * stap-probe.h:
4776         (struct stap_parse_info): Replace "parser_state" with
4777         "expr_builder".
4778         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4779         (parser_state): New class.
4780         * parse.c (expr_builder): Rename.
4781         (expr_builder::release): Rename.
4782         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4783         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4784         (write_exp_elt_longcst, write_exp_elt_floatcst)
4785         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4786         (write_exp_string_vector, write_exp_bitstring)
4787         (write_exp_msymbol, mark_struct_expression)
4788         (write_dollar_variable)
4789         (insert_type_address_space, increase_expout_size): Replace
4790         "parser_state" with "expr_builder".
4791         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4792         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4793         "parser_state" with "expr_builder".
4794
4795 2019-04-04  Tom Tromey  <tom@tromey.com>
4796
4797         * rust-exp.y: Replace "parse_language" with method call.
4798         * p-exp.y:
4799         (yylex): Replace "parse_language" with method call.
4800         * m2-exp.y:
4801         (yylex): Replace "parse_language" with method call.
4802         * go-exp.y (classify_name): Replace "parse_language" with method
4803         call.
4804         * f-exp.y (yylex): Replace "parse_language" with method call.
4805         * d-exp.y (lex_one_token): Replace "parse_language" with method
4806         call.
4807         * c-exp.y:
4808         (lex_one_token, classify_name, yylex): Replace "parse_language"
4809         with method call.
4810         * ada-exp.y (find_primitive_type, type_char)
4811         (type_system_address): Replace "parse_language" with method call.
4812
4813 2019-04-04  Tom Tromey  <tom@tromey.com>
4814
4815         * rust-exp.y: Replace "parse_gdbarch" with method call.
4816         * parse.c (write_dollar_variable, insert_type_address_space):
4817         Replace "parse_gdbarch" with method call.
4818         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4819         call.
4820         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4821         call.
4822         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4823         "parse_gdbarch" with method call.
4824         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4825         with method call.
4826         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4827         "parse_gdbarch" with method call.
4828         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4829         "parse_gdbarch" with method call.
4830         * c-exp.y (parse_type, parse_number, classify_name): Replace
4831         "parse_gdbarch" with method call.
4832         * ada-lex.l: Replace "parse_gdbarch" with method call.
4833         * ada-exp.y (parse_type, find_primitive_type, type_char)
4834         (type_system_address): Replace "parse_gdbarch" with method call.
4835
4836 2019-04-04  Tom Tromey  <tom@tromey.com>
4837
4838         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4839         * stap-probe.c (stap_parse_argument): Update.
4840         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4841         initial_size parameter.
4842         * rust-exp.y (rust_lex_tests): Update.
4843         * parse.c (parser_state): Update.
4844         (parse_exp_in_context): Update.
4845         * parser-defs.h (struct parser_state) <parser_state>: Remove
4846         "initial_size" parameter.
4847
4848 2019-04-04  Tom Tromey  <tom@tromey.com>
4849
4850         * parser-defs.h (increase_expout_size): Don't declare.
4851         * parse.c (increase_expout_size): Now static.
4852
4853 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4854
4855         * gnu-nat.c (gnu_nat_target::wait): Fix
4856         target_waitstatus_to_string call.
4857
4858 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4859
4860         * eval.c (evaluate_subexp_standard): Handle internal functions
4861         during Fortran function call handling.
4862
4863 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4864
4865         * NEWS: Mention new internal functions.
4866         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4867         (read_base_type): Use dwarf2_init_complex_target_type.
4868         * value.c (creal_internal_fn): New function.
4869         (cimag_internal_fn): New function.
4870         (_initialize_values): Register new internal functions.
4871
4872 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4873
4874         * infrun.c (stop_all_threads): If debug_infrun, always
4875         trace the wait status after wait_one, using
4876         target_waitstatus_to_string and target_pid_to_str.
4877         (handle_inferior_event): Replace various trace of
4878         wait status kind by a single trace.
4879         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4880         wait status kind image by target_waitstatus_to_string.
4881         * target/waitstatus.c (target_waitstatus_to_string): Fix
4882         obsolete comment.
4883
4884 2019-04-01  Tom Tromey  <tromey@adacore.com>
4885
4886         PR symtab/23331:
4887         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4888
4889 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4890             Pedro Alves  <palves@redhat.com>
4891
4892         * top.c (quit_force): Call 'finalize_values'.
4893         * value.c (finalize_values): New function.
4894         * value.h (finalize_values): Declare.
4895
4896 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4897
4898         * NEWS: Announce $_gdb_major and $_gdb_minor.
4899
4900         * top.c (init_gdb_version_vars): New function.
4901         (gdb_init): Call init_gdb_version_vars.
4902
4903 2019-03-29  Tom Tromey  <tromey@adacore.com>
4904
4905         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4906         help text.  Remove dead code.
4907
4908 2019-03-29  Keith Seitz  <keiths@redhat.com>
4909
4910         From Siddhesh Poyarekar:
4911         * f-lang.h (f77_get_upperbound): Return LONGEST.
4912         (f77_get_lowerbound): Likewise.
4913         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4914         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4915         print them.
4916         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4917         plongest to format print it.
4918         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4919         (f77_get_upperbound): Likewise.
4920         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4921         LOWER_BOUND to LONGEST.
4922         (f77_create_arrayprint_offset_tbl): Likewise.
4923
4924 2019-03-29  Keith Seitz  <keiths@redhat.com>
4925
4926         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4927         %s/pulongest for TYPE_LENGTH instead of %d in format
4928         strings.
4929         * ada-typerint.c (ada_print_type): Likewise.
4930         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4931         * compile/compile-c-support.c (generate_register_struct): Likewise.
4932         * gdbtypes.c (recursive_dump_type): Likewise.
4933         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4934         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4935         instead of %d in format strings.
4936         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4937         to std::min to ULONGEST.
4938         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4939         instead of %d in format strings.
4940         * tracepoint.c (info_scope_command): Likewise.
4941         * typeprint.c (print_offset_data::update)
4942         (print_offset_data::finish): Likewise.
4943         * xtensa-tdep.c (xtensa_store_return_value)
4944         (xtensa_push_dummy_call): Likewise.
4945
4946 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4947
4948         * windows-nat.c (display_selector): Fixed format specifications
4949         for 64-bit Cygwin.
4950
4951 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4952
4953         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4954
4955 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4956
4957         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4958         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4959         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4960         (nios2_linux_init_abi): Install it.
4961
4962 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4963
4964         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4965
4966 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4967
4968         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4969
4970 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4971             Tom Tromey  <tromey@adacore.com>
4972
4973         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4974
4975 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4976
4977         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4978         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4979         method to compute the bounds of range types. Also print "[evaluated]"
4980         if the bounds' values come from a dynamic evaluation.
4981
4982 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4983
4984         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4985         whitespace when pretty printing is on.
4986
4987 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4988
4989         * ppc-linux-nat.c: Add include.
4990
4991 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4992
4993         * NEWS: Mention AArch64 Pointer Authentication.
4994
4995 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4996
4997         * arm-linux-nat.c: Add include.
4998
4999 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5000
5001         * source-cache.c (source_cache::get_source_lines): Re-read
5002         fullname after calling open_source_file.
5003
5004 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5005
5006         * NEWS: Mention TLS support for FreeBSD.
5007
5008 2019-03-25  Tom Tromey  <tromey@adacore.com>
5009
5010         * minsyms.c (BUNCH_SIZE): Update comment.
5011         (~minimal_symbol_reader): Remove old comment.
5012         (compact_minimal_symbols): Update comment.
5013         (minimal_symbol_reader::install): Remove old comment.  Update
5014         other comments.
5015
5016 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5017
5018         * s390-linux-nat.c: Add include.
5019
5020 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5021
5022         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5023         Call linux_get_hwcap.
5024         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5025         Likewise.
5026         (aarch64_linux_get_hwcap): Remove function.
5027         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5028         declaration.
5029         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5030         linux_get_hwcap.
5031         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5032         * linux-tdep.c (linux_get_hwcap): Add function.
5033         (linux_get_hwcap2): Likewise.
5034         * linux-tdep.h (linux_get_hwcap): Add declaration.
5035         (linux_get_hwcap2): Likewise.
5036         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5037         (ppc_linux_get_hwcap2): Likewise.
5038         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5039         linux_get_hwcap.
5040         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5041         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5042         (ppc_linux_nat_target::read_description): Likewise.
5043         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5044         * s390-linux-nat.c: Likewise.
5045         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5046
5047 2019-03-24  Tom Tromey  <tom@tromey.com>
5048
5049         * ada-lang.c (standard_lookup): Simplify initialization.
5050         (ada_lookup_symbol_nonlocal): Simplify return.
5051         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5052         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5053         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5054         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5055         initialization.
5056         * solib.c (solib_global_lookup): Simplify.
5057         * symtab.c (null_block_symbol): Remove.
5058         (symbol_cache_lookup): Simplify returns.
5059         (lookup_language_this): Simplify returns.
5060         (lookup_symbol_aux): Simplify return.
5061         (lookup_local_symbol): Simplify returns.
5062         (lookup_global_symbol_from_objfile): Simplify return.
5063         (lookup_symbol_in_objfile_symtabs)
5064         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5065         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5066         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5067         * cp-namespace.c (cp_lookup_bare_symbol)
5068         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5069         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5070         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5071         (cp_lookup_symbol_via_imports): Simplify initialization.
5072         (find_symbol_in_baseclass): Likewise.
5073         * symtab.h (null_block_symbol): Remove.
5074         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5075         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5076         (d_lookup_symbol_module): Likewise.
5077         (find_symbol_in_baseclass): Simplify initialization.
5078
5079 2019-03-24  Tom Tromey  <tom@tromey.com>
5080
5081         * expression.h: Don't include symtab.h.
5082         (struct block): Forward declare.
5083
5084 2019-03-24  Tom Tromey  <tom@tromey.com>
5085
5086         * c-exp.y (typebase): Remove casts.
5087         * gdbtypes.c (lookup_unsigned_typename, )
5088         (lookup_signed_typename): Remove cast.
5089         * eval.c (parse_to_comma_and_eval): Remove cast.
5090         * parse.c (write_dollar_variable): Remove cast.
5091         * block.h (struct block) <superblock>: Now const.
5092         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5093         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5094         (map_block): Make "block" const.
5095         * symfile.h (struct quick_symbol_functions)
5096         <map_matching_symbols>: Constify block argument to "callback".
5097         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5098         const.
5099         (find_pc_sect_compunit_symtab): Make "b" const.
5100         (find_symbol_at_address): Likewise.
5101         (search_symbols): Likewise.
5102         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5103         (dw2_debug_names_lookup_symbol): Likewise.
5104         (dw2_map_matching_symbols): Update.
5105         * p-valprint.c (pascal_val_print): Remove "block".
5106         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5107         (aux_add_nonlocal_symbols): Make "block" const.
5108         (resolve_subexp): Remove cast.
5109         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5110         const.
5111         (iterate_over_file_blocks): Likewise.
5112         * f-exp.y (%union) <bval>: Remove.
5113         * coffread.c (patch_opaque_types): Make "b" const.
5114         * spu-tdep.c (spu_catch_start): Make "block" const.
5115         * c-valprint.c (print_unpacked_pointer): Remove "block".
5116         * symmisc.c (dump_symtab_1): Make "b" const.
5117         (block_depth): Make "block" const.
5118         * d-exp.y (%union) <bval>: Remove.
5119         * cp-support.h (cp_lookup_rtti_type): Update.
5120         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5121         * psymtab.c (psym_lookup_symbol): Make "block" const.
5122         (maintenance_check_psymtabs): Make "b" const.
5123         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5124         (enumerate_locals, enumerate_args): Update.
5125         * python/py-symtab.c (stpy_global_block): Make "block" const.
5126         (stpy_static_block): Likewise.
5127         * inline-frame.c (block_starting_point_at): Make "new_block"
5128         const.
5129         * block.c (find_block_in_blockvector): Make return type const.
5130         (blockvector_for_pc_sect): Make "b" const.
5131         (find_block_in_blockvector): Make "b" const.
5132
5133 2019-03-23  Tom Tromey  <tom@tromey.com>
5134
5135         * varobj.c (varobj_create): Update.
5136         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5137         * printcmd.c (display_command, do_one_display): Don't reset
5138         innermost_block.
5139         * parser-defs.h (enum innermost_block_tracker_type): Move to
5140         expression.h.
5141         (innermost_block): Update comment.
5142         * parse.c (parse_exp_1): Add tracker_types parameter.
5143         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5144         tracker_types parameter.  Reset innermost_block.
5145         (parse_exp_in_context): Remove.
5146         (parse_expression_for_completion): Update.
5147         * objfiles.c (~objfile): Don't reset expression_context_block or
5148         innermost_block.
5149         * expression.h (enum innermost_block_tracker_type): Move from
5150         parser-defs.h.
5151         (parse_exp_1): Add tracker_types parameter.
5152         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5153         reset innermost_block.
5154
5155 2019-03-23  Tom Tromey  <tom@tromey.com>
5156
5157         * objfiles.h: Include bcache.h.
5158
5159 2019-03-23  Tom Tromey  <tom@tromey.com>
5160
5161         * linespec.c (get_current_search_block): Use
5162         scoped_restore_current_language.
5163         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5164
5165 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5166             Jiong Wang  <jiong.wang@arm.com>
5167
5168         * aarch64-linux-tdep.c
5169         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5170         section.
5171         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5172
5173 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5174             Jiong Wang  <jiong.wang@arm.com>
5175
5176         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5177         instructions.
5178         (aarch64_analyze_prologue_test): Add PACIASP test.
5179         (aarch64_prologue_prev_register): Unmask PC value.
5180
5181 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5182             Jiong Wang  <jiong.wang@arm.com>
5183
5184         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5185         (aarch64_dwarf2_prev_register): Unmask PC value.
5186         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5187         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5188         DW_CFA_AARCH64_negate_ra_state.
5189         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5190
5191 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5192             Jiong Wang  <jiong.wang@arm.com>
5193
5194         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5195         registers.
5196         (aarch64_pseudo_register_name): Likewise.
5197         (aarch64_pseudo_register_type): Likewise.
5198         (aarch64_pseudo_register_reggroup_p): Likewise.
5199         (aarch64_gdbarch_init): Add pauth registers.
5200         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5201         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5202         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5203         (struct gdbarch_tdep): Add regnum for ra_state.
5204
5205 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5206             Jiong Wang  <jiong.wang@arm.com>
5207
5208         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5209
5210 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5211             Jiong Wang  <jiong.wang@arm.com>
5212
5213         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5214         function.
5215         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5216         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5217         (aarch64_gdbarch_init): Add puth registers.
5218         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5219         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5220         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5221
5222 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5223             Jiong Wang  <jiong.wang@arm.com>
5224
5225         * aarch64-linux-nat.c
5226         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5227         * aarch64-linux-tdep.c
5228         (aarch64_linux_core_read_description): Likewise.
5229         (aarch64_linux_get_hwcap): New function.
5230         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5231         (aarch64_linux_get_hwcap): New declaration.
5232
5233 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5234             Jiong Wang  <jiong.wang@arm.com>
5235
5236         * aarch64-linux-nat.c
5237         (aarch64_linux_nat_target::read_description): Add pauth param.
5238         * aarch64-linux-tdep.c
5239         (aarch64_linux_core_read_description): Likewise.
5240         * aarch64-tdep.c (struct target_desc): Add in pauth.
5241         (aarch64_read_description): Add pauth param.
5242         (aarch64_gdbarch_init): Likewise.
5243         * aarch64-tdep.h (aarch64_read_description): Likewise.
5244         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5245         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5246         * features/Makefile: Add new files.
5247         * features/aarch64-pauth.c: New file.
5248         * features/aarch64-pauth.xml: New file.
5249
5250 2019-03-20  Tom Tromey  <tromey@adacore.com>
5251
5252         * infrun.c (handle_inferior_event): Rename from
5253         handle_inferior_event_1.  Create a scoped_value_mark.
5254         (handle_inferior_event): Remove.
5255
5256 2019-03-19  Tom Tromey  <tromey@adacore.com>
5257
5258         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5259         * infrun.h (print_stop_event): Add "displays" parameter.
5260         * infrun.c (print_stop_event): Add "displays" parameter.
5261
5262 2019-03-19  Pedro Alves  <palves@redhat.com>
5263
5264         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5265         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5266         to -1.  Fix TABs vs spaces.
5267         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5268         * tui/tui-out.h (tui_ui_out) Add intro comments.
5269         <m_line, m_start_of_line>: In-class initialize, and add describing
5270         comment.
5271
5272 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5273
5274         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5275         variable names.
5276         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5277
5278 2019-03-18  Pedro Alves  <palves@redhat.com>
5279             Eli Zaretskii <eliz@gnu.org>
5280
5281         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5282         m_line and m_start_of_line.
5283
5284 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5285
5286         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5287         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5288         it returns a newline.  This fixes a regression in TU mode, whereby
5289         the next line is output on the same screen line as the user input.
5290
5291 2019-03-18  Tom Tromey  <tromey@adacore.com>
5292
5293         * minsyms.c (minimal_symbol_reader::install): Remove call to
5294         obstack_blank.
5295
5296 2019-03-18  Pedro Alves  <palves@redhat.com>
5297
5298         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5299         New globals.
5300         (apply_style): New, factored out from ...
5301         (apply_ansi_escape): ... this.  Handle reverse video mode.
5302         (tui_set_reverse_mode): New function.
5303         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5304         * tui/tui-winsource.c (tui_show_source_line): Use
5305         tui_set_reverse_mode instead of setting A_STANDOUT.
5306         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5307         New setter methods.
5308
5309 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5310
5311         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5312         Handle tabs.
5313
5314 2019-03-18  Tom Tromey  <tromey@adacore.com>
5315
5316         * ada-lang.c (empty_array): Add "high" parameter.
5317         (ada_evaluate_subexp): Update.
5318
5319 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5320
5321         * unittests/string_view-selftests.c: Define
5322         _initialize_string_view_selftests unconditionally.
5323
5324 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5325
5326         PR gdb/24350
5327         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5328
5329 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5330
5331         PR gdb/24351
5332         * windows-nat.c (display_selector): Fix format specifiers.
5333
5334 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5335
5336         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5337         tui_refill_source_window instead of tui_refresh_win, to update the
5338         current execution line.  This fixes redisplay of the current line
5339         when stepping through the code with "next" or "step".
5340
5341 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5342
5343         * source-cache.c (source_cache::get_source_lines): Call
5344         find_source_lines to initialize s->nlines.  This fixes vertical
5345         scrolling of TUI source window when the DOWN arrow is pressed.
5346
5347 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5348
5349         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5350         linux-thread-db.c (_initialize_thread_db): Likewise.
5351
5352 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5353
5354         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5355         wclrtoeol in tui_show_source_line".  This reverts changes made in
5356         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5357
5358 2019-03-15  Tom Tromey  <tom@tromey.com>
5359
5360         * symtab.h (struct minimal_symbol): Derive from
5361         general_symbol_info.
5362         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5363         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5364         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5365         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5366         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5367         (MSYMBOL_SEARCH_NAME): Update.
5368         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5369         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5370         * minsyms.c (minimal_symbol_reader::record_full): Update.
5371
5372 2019-03-15  Tom Tromey  <tom@tromey.com>
5373
5374         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5375
5376 2019-03-15  Tom Tromey  <tom@tromey.com>
5377
5378         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5379         unique_xmalloc_ptr.
5380         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5381         Update.
5382         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5383         (build_minimal_symbol_hash_tables)
5384         (minimal_symbol_reader::install): Update.
5385
5386 2019-03-15  Tom Tromey  <tom@tromey.com>
5387
5388         * symtab.c (create_demangled_names_hash): Update.
5389         (symbol_set_names): Update.
5390         * objfiles.h (struct objfile_per_bfd_storage)
5391         <demangled_names_hash>: Now an htab_up.
5392         * objfiles.c (objfile_per_bfd_storage): Simplify.
5393
5394 2019-03-15  Tom Tromey  <tom@tromey.com>
5395
5396         * objfiles.h (struct objfile_per_bfd_storage): Declare
5397         destructor.
5398         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5399         New.
5400         (get_objfile_bfd_data): Use new.  Don't initialize
5401         language_of_main.
5402         (free_objfile_per_bfd_storage): Remove.
5403         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5404
5405 2019-03-15  Tom Tromey  <tom@tromey.com>
5406
5407         * symfile.c (reread_symbols): Update.
5408         * objfiles.c (objfile::objfile): Update.
5409         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5410         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5411         comment.
5412         (minimal_symbol_reader::install): Update.
5413         (terminate_minimal_symbol_table): Remove.
5414         * jit.c (jit_object_close_impl): Update.
5415
5416 2019-03-15  Tom Tromey  <tom@tromey.com>
5417
5418         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5419         initializations.
5420
5421 2019-03-15  Tom Tromey  <tom@tromey.com>
5422
5423         * objfiles.h (struct objfile_per_bfd_storage)
5424         <demangled_hash_languages>: Now a bitset.
5425         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5426         (lookup_minimal_symbol): Update.
5427
5428 2019-03-15  Tom Tromey  <tom@tromey.com>
5429
5430         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5431         Don't return the symbol.
5432         * coffread.c (record_minimal_symbol): Use record_full.
5433
5434 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5435
5436         The MS-Windows port of ncurses fails to switch to a color pair if
5437         one or both of the colors are the implicit default colors.  This
5438         change records the default colors when TUI is initialized, and
5439         then specifies them explicitly when a color pair uses the default
5440         colors.  This allows color styling in TUI mode on MS-Windows.
5441
5442         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5443         ncurses_norm_attr.
5444         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5445         colors in ncurses_norm_attr.
5446         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5447         "none", replace it with the default color recorded in
5448         ncurses_norm_attr.
5449
5450 2019-03-14  Tom Tromey  <tromey@adacore.com>
5451
5452         * source-cache.h (class source_cache) <get_source_lines>: Return
5453         std::string.
5454         * source-cache.c (source_cache::extract_lines): Handle case where
5455         first_pos==npos.  Return std::string.
5456         (source_cache::get_source_lines): Update.
5457
5458 2019-03-14  Tom Tromey  <tromey@adacore.com>
5459
5460         * NEWS: Add item for "style sources" commands.
5461         * source-cache.c (source_cache::get_source_lines): Check
5462         source_styling.
5463         * cli/cli-style.c (source_styling): New global.
5464         (_initialize_cli_style): Add "style sources" commands.
5465         (show_style_sources): New function.
5466         * cli/cli-style.h (source_styling): Declare.
5467
5468 2019-03-14  Pedro Alves  <palves@redhat.com>
5469             Tom Tromey  <tromey@adacore.com>
5470
5471         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5472         * tui/tui-winsource.c (tui_refill_source_window): New function,
5473         from...
5474         (tui_horizontal_source_scroll): ... here.  Move some logic.
5475         * cli/cli-style.c (set_style_enabled): Notify new observable.
5476         * tui/tui-hooks.c (tui_redisplay_source): New function.
5477         (tui_attach_detach_observers): Attach or detach
5478         tui_redisplay_source.
5479         * observable.h (source_styling_changed): New observable.
5480         * observable.c: Define source_styling_changed observable.
5481
5482 2019-03-13  Tom Tromey  <tromey@adacore.com>
5483
5484         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5485         (i386_gnu_nat_target::store_registers): Update.
5486         * target-debug.h (target_debug_print_std_string): New macro.
5487         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5488         * windows-tdep.c (display_one_tib): Update.
5489         * tui/tui-stack.c (tui_make_status_line): Update.
5490         * top.c (print_inferior_quit_action): Update.
5491         * thread.c (thr_try_catch_cmd): Update.
5492         (add_thread_with_info): Update.
5493         (thread_target_id_str): Update.
5494         (thr_try_catch_cmd): Update.
5495         (thread_command): Update.
5496         (thread_find_command): Update.
5497         * record-btrace.c (record_btrace_target::info_record)
5498         (record_btrace_resume_thread, record_btrace_target::resume)
5499         (record_btrace_cancel_resume, record_btrace_step_thread)
5500         (record_btrace_target::wait, record_btrace_target::wait)
5501         (record_btrace_target::wait, record_btrace_target::stop): Update.
5502         * progspace.c (print_program_space): Update.
5503         * process-stratum-target.c
5504         (process_stratum_target::thread_address_space): Update.
5505         * linux-fork.c (linux_fork_mourn_inferior)
5506         (detach_checkpoint_command, info_checkpoints_command)
5507         (linux_fork_context): Update.
5508         (linux_fork_detach): Update.
5509         (class scoped_switch_fork_info): Update.
5510         (delete_checkpoint_command): Update.
5511         * infrun.c (follow_fork_inferior): Update.
5512         (follow_fork_inferior): Update.
5513         (proceed_after_vfork_done): Update.
5514         (handle_vfork_child_exec_or_exit): Update.
5515         (follow_exec): Update.
5516         (displaced_step_prepare_throw): Update.
5517         (displaced_step_restore): Update.
5518         (start_step_over): Update.
5519         (resume_1): Update.
5520         (clear_proceed_status_thread): Update.
5521         (proceed): Update.
5522         (print_target_wait_results): Update.
5523         (do_target_wait): Update.
5524         (context_switch): Update.
5525         (stop_all_threads): Update.
5526         (restart_threads): Update.
5527         (finish_step_over): Update.
5528         (handle_signal_stop): Update.
5529         (switch_back_to_stepped_thread): Update.
5530         (keep_going_pass_signal): Update.
5531         (print_exited_reason): Update.
5532         (normal_stop): Update.
5533         * inferior.c (inferior_pid_to_str): Change return type.
5534         (print_selected_inferior): Update.
5535         (add_inferior): Update.
5536         (detach_inferior): Update.
5537         * dummy-frame.c (fprint_dummy_frames): Update.
5538         * dcache.c (dcache_info_1): Update.
5539         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5540         (btrace_fetch, btrace_clear): Update.
5541         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5542         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5543         type.
5544         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5545         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5546         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5547         * gdbarch.c, gdbarch.h: Rebuild.
5548         * gdbarch.sh (core_pid_to_str): Change return type.
5549         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5550         return type.
5551         (windows_nat_target::pid_to_str): Change return type.
5552         (windows_delete_thread): Update.
5553         (windows_nat_target::attach): Update.
5554         (windows_nat_target::files_info): Update.
5555         * target-delegates.c: Rebuild.
5556         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5557         return type.
5558         (sol_thread_target::pid_to_str): Change return type.
5559         * remote.c (class remote_target) <pid_to_str>: Change return
5560         type.
5561         (remote_target::pid_to_str): Change return type.
5562         (extended_remote_target::attach, remote_target::remote_stop_ns)
5563         (remote_target::remote_notif_remove_queued_reply)
5564         (remote_target::push_stop_reply, remote_target::disable_btrace):
5565         Update.
5566         (extended_remote_target::attach): Update.
5567         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5568         type.
5569         (gdbsim_target::pid_to_str): Change return type.
5570         * ravenscar-thread.c (struct ravenscar_thread_target)
5571         <pid_to_str>: Change return type.
5572         (ravenscar_thread_target::pid_to_str): Change return type.
5573         * procfs.c (class procfs_target) <pid_to_str>: Change return
5574         type.
5575         (procfs_target::pid_to_str): Change return type.
5576         (procfs_target::attach): Update.
5577         (procfs_target::detach): Update.
5578         (procfs_target::fetch_registers): Update.
5579         (procfs_target::store_registers): Update.
5580         (procfs_target::wait): Update.
5581         (procfs_target::files_info): Update.
5582         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5583         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5584         return type.
5585         (nto_procfs_target::pid_to_str): Change return type.
5586         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5587         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5588         return type.
5589         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5590         (exit_lwp): Update.
5591         (attach_proc_task_lwp_callback, get_detach_signal)
5592         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5593         (linux_nat_target::resume, wait_lwp, stop_callback)
5594         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5595         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5596         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5597         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5598         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5599         type.
5600         (inf_ptrace_target::attach): Update.
5601         (inf_ptrace_target::files_info): Update.
5602         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5603         type.
5604         (go32_nat_target::pid_to_str): Change return type.
5605         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5606         (gnu_nat_target::wait): Update.
5607         (gnu_nat_target::wait): Update.
5608         (gnu_nat_target::resume): Update.
5609         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5610         (fbsd_nat_target::wait): Update.
5611         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5612         type.
5613         (darwin_nat_target::attach): Update.
5614         * corelow.c (class core_target) <pid_to_str>: Change return type.
5615         (core_target::pid_to_str): Change return type.
5616         * target.c (normal_pid_to_str): Change return type.
5617         (default_pid_to_str): Likewise.
5618         (target_pid_to_str): Change return type.
5619         (target_translate_tls_address): Update.
5620         (target_announce_detach): Update.
5621         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5622         return type.
5623         (bsd_uthread_target::pid_to_str): Change return type.
5624         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5625         type.
5626         (bsd_kvm_target::pid_to_str): Change return type.
5627         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5628         return type.
5629         (aix_thread_target::pid_to_str): Change return type.
5630         * target.h (struct target_ops) <pid_to_str>: Change return type.
5631         (target_pid_to_str, normal_pid_to_str): Likewise.
5632         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5633         type.
5634         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5635         type.
5636         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5637         return type.
5638         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5639         type.
5640         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5641         type.
5642         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5643         return type.
5644
5645 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5646
5647         * NEWS: Mention that the new default MI version is 3.  Mention
5648         changes to the output of commands and events that deal with
5649         multi-location breakpoints.
5650         * breakpoint.c: Include "mi/mi-out.h".
5651         (print_one_breakpoint): Change output syntax if using MI version
5652         >= 3.
5653         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5654         New.
5655         (mi_multi_location_breakpoint_output_fixed): New.
5656         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5657         (mi_cmd_fix_multi_location_breakpoint_output): New.
5658         (mi_multi_location_breakpoint_output_fixed): New.
5659         * mi/mi-cmds.c (mi_cmds): Register command
5660         -fix-multi-location-breakpoint-output.
5661         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5662         interpreter "mi".
5663
5664 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5665
5666         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5667         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5668         instantiate mi_ui_out based on interpreter name.
5669         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5670         * mi/mi-main.c (mi_load_progress): Likewise.
5671
5672 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5673
5674         * NEWS: Combine separate "New targets" sections for 8.3.
5675
5676 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5677
5678         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5679         (ppcfbsd_init_abi): Install gdbarch
5680         "fetch_tls_load_module_address" and "get_thread_local_address"
5681         methods.
5682
5683 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5684
5685         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5686         (riscv_fbsd_init_abi): Install gdbarch
5687         "fetch_tls_load_module_address" and "get_thread_local_address"
5688         methods.
5689
5690 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5691
5692         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5693         (i386fbsd_init_abi): Install gdbarch
5694         "fetch_tls_load_module_address" and "get_thread_local_address"
5695         methods.
5696
5697 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5698
5699         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5700         (amd64fbsd_init_abi): Install gdbarch
5701         "fetch_tls_load_module_address" and "get_thread_local_address"
5702         methods.
5703
5704 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5705
5706         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5707         (struct fbsd_pspace_data): New type.
5708         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5709         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5710         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5711         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5712         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5713
5714 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5715
5716         * gdbtypes.c (lookup_struct_elt): New function.
5717         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5718         * gdbtypes.h (struct struct_elt): New type.
5719         (lookup_struct_elt): New prototype.
5720
5721 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5722
5723         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5724         remove disabled code block.
5725
5726 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5727
5728         * gdbarch.sh (get_thread_local_address): New method.
5729         * gdbarch.h, gdbarch.c: Regenerate.
5730         * target.c (target_translate_tls_address): Use
5731         gdbarch_get_thread_local_address if present instead of
5732         target::get_thread_local_address.
5733
5734 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5735
5736         * target.h (target::get_thread_local_address): Update comment.
5737
5738 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5739
5740         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5741         objfile->separate_debug_objfile_backlink if not NULL.
5742
5743 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5744
5745         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5746         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5747         (amd64bsd_store_inferior_registers): Likewise.
5748         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5749         Enable segment base registers.
5750         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5751         PT_GETFSBASE and PT_GETGSBASE.
5752         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5753         PT_SETGSBASE.
5754         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5755         segment base registers.
5756         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5757
5758 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5759
5760         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5761         Update calls to i386_target_description to add 'segments'
5762         parameter.
5763         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5764         add segment base registers.
5765         * arch/i386.c (i386_create_target_description): Add 'segments'
5766         parameter to enable segment base registers.
5767         * arch/i386.h (i386_create_target_description): Likewise.
5768         * features/i386/32bit-segments.xml: New file.
5769         * features/i386/32bit-segments.c: Generate.
5770         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5771         call to i386_target_description to add 'segments' parameter.
5772         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5773         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5774         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5775         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5776         if feature is present.
5777         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5778         Add 'segments' parameter to call to i386_target_description.
5779         (i386_target_description): Add 'segments' parameter to enable
5780         segment base registers.
5781         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5782         to call to i386_target_description.
5783         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5784         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5785         Define I386_NUM_REGS.
5786         (i386_target_description): Add 'segments' parameter to enable
5787         segment base registers.
5788
5789 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5790
5791         PR/24325
5792         * source-cache.c: #undef open and close, to avoid unresolved
5793         externals during linking.
5794
5795 2019-03-12  Tom Tromey  <tromey@adacore.com>
5796
5797         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5798         const.  Add initializers.
5799         (_initialize_remote): Don't initialize ptid globals.
5800
5801 2019-03-12  Pedro Alves  <palves@redhat.com>
5802
5803         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5804
5805 2019-03-12  Pedro Alves  <palves@redhat.com>
5806
5807         * cp-name-parser.y (main): Remove unused 'len' variable.
5808
5809 2019-03-12  Tom Tromey  <tromey@adacore.com>
5810
5811         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5812         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5813
5814 2019-03-12  Tom Tromey  <tromey@adacore.com>
5815
5816         * linux-nat.c (iterate_over_lwps): Update.
5817         (stop_callback): Remove parameter.
5818         (stop_wait_callback, detach_callback, resume_set_callback)
5819         (select_singlestep_lwp_callback, set_ignore_sigint)
5820         (status_callback, resumed_callback, resume_clear_callback)
5821         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5822         data parameter.
5823         (linux_nat_target::detach, linux_nat_target::resume)
5824         (linux_stop_and_wait_all_lwps, select_event_lwp)
5825         (linux_nat_filter_event, linux_nat_wait_1)
5826         (linux_nat_target::kill, linux_nat_target::stop)
5827         (linux_nat_target::stop): Update.
5828         (linux_nat_resume_callback): Change type.
5829         (resume_stopped_resumed_lwps, count_events_callback)
5830         (select_event_lwp_callback): Likewise.
5831         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5832         * arm-linux-nat.c (struct update_registers_data): Remove.
5833         (update_registers_callback): Change type.
5834         (arm_linux_insert_hw_breakpoint1): Update.
5835         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5836         parameter.
5837         (x86_linux_dr_set_addr): Update.
5838         (x86_linux_dr_set_control): Update.
5839         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5840         (iterate_over_lwps): Use gdb::function_view.
5841         * nat/aarch64-linux-hw-point.c (struct
5842         aarch64_dr_update_callback_param): Remove.
5843         (debug_reg_change_callback): Change type.
5844         (aarch64_notify_debug_reg_change): Update.
5845         * s390-linux-nat.c (s390_refresh_per_info): Update.
5846
5847 2019-03-11  Tom Tromey  <tromey@adacore.com>
5848
5849         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5850         redundant assignment to "this_cu".
5851
5852 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5853
5854         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5855
5856 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5857
5858         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5859         from...
5860         (rank_one_type): ... this.
5861
5862 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5863
5864         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5865         from...
5866         (rank_one_type): ... this.
5867
5868 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5869
5870         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5871         from...
5872         (rank_one_type): ... this.
5873
5874 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5875
5876         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5877         from...
5878         (rank_one_type): ... this.
5879
5880 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5881
5882         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5883         from...
5884         (rank_one_type): ... this.
5885
5886 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5887
5888         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5889         from...
5890         (rank_one_type): ... this.
5891
5892 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5893
5894         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5895         from...
5896         (rank_one_type): ... this.
5897
5898 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5899
5900         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5901         from...
5902         (rank_one_type): ... this.
5903
5904 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5905
5906         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5907         from...
5908         (rank_one_type): ... this.
5909
5910 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5911
5912         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5913         from...
5914         (rank_one_type): ... this.
5915
5916 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5917
5918         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5919         from...
5920         (rank_one_type): ... this.
5921
5922 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5923
5924         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5925         from...
5926         (rank_one_type): ... this.
5927
5928 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5929
5930         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5931         inferior-events' shows the example events.
5932
5933 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5934
5935         Support styling on native MS-Windows console
5936
5937         PR/24315
5938         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5939         on MS-Windows if $TERM is not defined.
5940
5941         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5942
5943         * posix-hdep.c (gdb_console_fputs):
5944         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5945         functions.
5946         * ui-file.h (gdb_console_fputs): Add prototype.
5947
5948         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5949         back to fputs only if the former returns zero.
5950
5951 2019-03-07  Tom Tromey  <tom@tromey.com>
5952
5953         * symmisc.c (print_symbol_bcache_statistics): Update.
5954         (print_objfile_statistics): Update.
5955         * symfile.c (allocate_symtab): Update.
5956         * stabsread.c: Don't include bcache.h.
5957         * psymtab.h (struct psymbol_bcache): Don't declare.
5958         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5959         (psymbol_bcache_init, psymbol_bcache_free)
5960         (psymbol_bcache_get_bcache): Don't declare.
5961         * psymtab.c (struct psymbol_bcache): Remove.
5962         (psymtab_storage::psymtab_storage): Update.
5963         (psymtab_storage::~psymtab_storage): Update.
5964         (psymbol_bcache_init, psymbol_bcache_free)
5965         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5966         (add_psymbol_to_bcache): Update.
5967         (allocate_psymtab): Update.
5968         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5969         macro_cache>: No longer pointers.
5970         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5971         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5972         * macrotab.c (macro_bcache): Update.
5973         * macroexp.c: Don't include bcache.h.
5974         * gdbtypes.c (check_types_worklist): Update.
5975         (types_deeply_equal): Remove TRY/CATCH.  Update.
5976         * elfread.c (elf_symtab_read): Update.
5977         * dwarf2read.c: Don't include bcache.h.
5978         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5979         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5980         (print_bcache_statistics, bcache_memory_used): Don't declare.
5981         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5982         methods.  Rename all data members.
5983         * bcache.c (struct bcache): Move to bcache.h.
5984         (bcache::expand_hash_table): Rename from expand_hash_table.
5985         (bcache): Remove.
5986         (bcache::insert): Rename from bcache_full.
5987         (bcache::compare): Rename from bcache_compare.
5988         (bcache_xmalloc): Remove.
5989         (bcache::~bcache): Rename from bcache_xfree.
5990         (bcache::print_statistics): Rename from print_bcache_statistics.
5991         (bcache::memory_used): Rename from bcache_memory_used.
5992
5993 2019-03-07  Pedro Alves  <palves@redhat.com>
5994
5995         * infrun.c (normal_stop): Also check for
5996         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5997
5998 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5999
6000         * f-lang.c (value_from_host_double): Moved to...
6001         * value.c (value_from_host_double): ...here.
6002         * value.h (value_from_host_double): Declare.
6003         * guile/scm-math.c (vlscm_convert_typed_number): Use
6004         value_from_host_double.
6005         (vlscm_convert_number): Likewise.
6006         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6007         * python/py-value.c (convert_value_from_python): Likewise.
6008
6009 2019-03-06  Tom Tromey  <tom@tromey.com>
6010
6011         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6012
6013 2019-03-06  Tom Tromey  <tom@tromey.com>
6014
6015         * utils.h (free_current_contents): Don't declare.
6016         * utils.c (free_current_contents): Remove.
6017
6018 2019-03-06  Tom Tromey  <tom@tromey.com>
6019
6020         * top.c (quit_force): Update.
6021         * main.c (captured_command_loop): Update.
6022         * common/new-op.c (operator new): Update.
6023         * common/common-exceptions.c (struct catcher)
6024         <save_cleanup_chain>: Remove member.
6025         (exceptions_state_mc_init): Update.
6026         (exception_try_scope_entry): Return nullptr.
6027         (exception_try_scope_exit, exception_rethrow)
6028         (throw_exception_sjlj, throw_exception_cxx): Update.
6029         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6030         (all_cleanups, do_cleanups, discard_cleanups)
6031         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6032         (restore_cleanups, restore_final_cleanups): Don't declare.
6033         (do_final_cleanups): Remove parameter.
6034         * common/cleanups.c (cleanup_chain, make_cleanup)
6035         (make_cleanup_dtor, all_cleanups, do_cleanups)
6036         (discard_my_cleanups, discard_cleanups)
6037         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6038         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6039         (null_cleanup): Remove.
6040         (do_final_cleanups): Remove parameter.
6041
6042 2019-03-06  Tom Tromey  <tom@tromey.com>
6043
6044         * remote.c (remote_target::remote_parse_stop_reply): Use
6045         unique_xmalloc_ptr.
6046
6047 2019-03-06  Tom Tromey  <tom@tromey.com>
6048
6049         * stabsread.c (struct stabs_field_info): Rename from field_info.
6050         <list, fnlist>: Add initializers.
6051         <obstack>: New member.
6052         (read_member_functions, read_struct_fields, read_baseclasses):
6053         Allocate on obstack.  Don't use cleanups.
6054         (read_one_struct_field, read_member_functions, read_struct_fields)
6055         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6056         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6057         (read_struct_type): Update.
6058
6059 2019-03-06  Tom Tromey  <tom@tromey.com>
6060
6061         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6062         * common/filestuff.h (make_cleanup_close): Don't declare.
6063         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6064         Remove.
6065
6066 2019-03-06  Tom Tromey  <tom@tromey.com>
6067
6068         * solib-aix.c: Use make_scope_exit.
6069
6070 2019-03-06  Tom Tromey  <tom@tromey.com>
6071
6072         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6073         Use make_scope_exit.
6074
6075 2019-03-06  Tom Tromey  <tom@tromey.com>
6076
6077         * solib-svr4.c (disable_probes_interface): Remove parameter.
6078         (svr4_handle_solib_event): Use make_scope_exit.
6079
6080 2019-03-06  Tom Tromey  <tom@tromey.com>
6081
6082         * remote.c (struct stop_reply_deleter): Remove.
6083         (stop_reply_up): Update.
6084         (struct stop_reply): Derive from notif_event.  Don't typedef.
6085         <regcache>: Now a std::vector.
6086         (stop_reply_xfree): Remove.
6087         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6088         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6089         (remote_target::discard_pending_stop_replies): Use delete.
6090         (remote_target::remote_parse_stop_reply): Update.
6091         (remote_target::process_stop_reply): Update.
6092         * remote-notif.h (struct notif_event): Add virtual destructor.
6093         Remove "dtr" member.
6094         (struct notif_client) <alloc_event>: Return a unique_ptr.
6095         (notif_event_xfree): Don't declare.
6096         (notif_event_up): New typedef.
6097         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6098         (notif_event_xfree, do_notif_event_xfree): Remove.
6099         (remote_notif_state_xfree): Update.
6100
6101 2019-03-06  Tom Tromey  <tom@tromey.com>
6102
6103         * infrun.c (displaced_step_clear_cleanup): Now a
6104         forward_scope_exit type.
6105         (displaced_step_prepare_throw): Update.
6106         (displaced_step_fixup): Update.
6107
6108 2019-03-06  Tom Tromey  <tom@tromey.com>
6109
6110         * inferior.h (class inferior): Update comment.
6111         * gdbthread.h (class thread_info): Update comment.
6112
6113 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6114             Tom Tromey  <tom@tromey.com>
6115
6116         * stabsread.h (struct stab_section_list): Remove.
6117         (coffstab_build_psymtabs): Update.
6118         * dbxread.c (symbuf_sections): Now a std::vector.
6119         (sect_idx): New global.
6120         (fill_symbuf): Update.
6121         (coffstab_build_psymtabs): Change type of stabsects parameter.
6122         Update.
6123         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6124         std::vector.
6125         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6126         (coff_locate_sections): Update.
6127         (coff_symfile_read): Remove cleanups.  Update.
6128         (init_stringtab): Add storage parameter.
6129         (free_stringtab, free_stringtab_cleanup): Remove.
6130         (init_lineno): Add storage parameter.
6131         (free_linetab, free_linetab_cleanup): Remove.
6132
6133 2019-03-06  Pedro Alves  <palves@redhat.com>
6134
6135         * linux-fork.c (fork_info::clobber_regs): Delete.
6136         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6137         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6138         comment.  Adjust.
6139         (scoped_switch_fork_info::scoped_switch_fork_info)
6140         (checkpoint_command, linux_fork_context): Adjust
6141         fork_save_infrun_state calls.
6142
6143 2019-03-06  Pedro Alves  <palves@redhat.com>
6144
6145         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6146         (inf_has_multiple_threads): Return 'bool' and rewrite using
6147         inferior_info::threads().
6148
6149 2019-03-06  Pedro Alves  <palves@redhat.com>
6150
6151         * linux-fork.c: Include <list>.
6152         (fork_list): Now a std::list instance.
6153         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6154         (forks_exist_p, find_last_fork): Adjust.
6155         (new_fork): Delete.
6156         (one_fork_p): New.
6157         (add_fork): Adjust.
6158         (free_fork): Delete, folded into fork_info::~fork_info().
6159         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6160         Adjust.
6161         (init_fork_list): Delete.
6162         (linux_fork_killall, linux_fork_mourn_inferior)
6163         (linux_fork_detach, info_checkpoints_command): Adjust.
6164         (_initialize_linux_fork): No longer call init_fork_list.
6165
6166 2019-03-06  Pedro Alves  <palves@redhat.com>
6167
6168         * linux-fork.c (new_fork): New, split out of ...
6169         (add_fork): ... this.  Return void.  Move "first fork" special
6170         case from here, to ...
6171         (checkpoint_command): ... here.
6172         * linux-linux.h (add_fork): Return void.
6173
6174 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6175
6176         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6177
6178 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6179             Chris January  <chris.january@arm.com>
6180             David Lecomber  <david.lecomber@arm.com>
6181
6182         * f-exp.y: New token, UNOP_INTRINSIC.
6183         (exp): New pattern using UNOP_INTRINSIC token.
6184         (f77_keywords): Add 'abs' keyword.
6185         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6186         (value_from_host_double): New function.
6187         (evaluate_subexp_f): Support UNOP_ABS.
6188
6189 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6190
6191         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6192         types.
6193
6194 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6195
6196         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6197         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6198         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6199
6200 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6201
6202         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6203
6204 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6205             Chris January  <chris.january@arm.com>
6206
6207         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6208         * f-exp.y: Define 'KIND' token.
6209         (exp): New pattern for KIND expressions.
6210         (ptype): Handle types with a kind extension.
6211         (direct_abs_decl): Extend to spot kind extensions.
6212         (f77_keywords): Add 'kind' to the list.
6213         (push_kind_type): New function.
6214         (convert_to_kind_type): New function.
6215         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6216         * parse.c (operator_length_standard): Likewise.
6217         * parser-defs.h (enum type_pieces): Add tp_kind.
6218         * std-operator.def: Add UNOP_KIND.
6219
6220 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6221
6222         * f-exp.y (f_parse): Set yydebug.
6223
6224 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6225
6226         * f-lang.c (evaluate_subexp_f): New function.
6227         (exp_descriptor_f): New global.
6228         (f_language_defn): Use exp_descriptor_f instead of
6229         exp_descriptor_standard.
6230
6231 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6232
6233         * f-exp.y (struct token): Add comments.
6234         (dot_ops): Remove uppercase versions and the end marker.
6235         (f77_keywords): Likewise.
6236         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6237         entries in the dot_ops array are case insensitive, and use
6238         strncasecmp to compare strings.  Also some whitespace cleanup in
6239         this area.  Similar for the f77_keywords array, except entries in
6240         this list might be case sensitive.
6241
6242 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6243
6244         * f-exp.y (struct f77_boolean_val): Add comments.
6245         (boolean_values): Remove uppercase versions, and end marker.
6246         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6247         and use strncasecmp to achieve case insensitivity.  Additionally,
6248         perform whitespace cleanup around this code.
6249
6250 2019-03-06  Tom Tromey  <tromey@adacore.com>
6251
6252         * remote-sim.c (gdbsim_target_open): Use result of
6253         gdb_argv::release.
6254
6255 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6256         Dirk Schubert  <dirk.schubert@arm.com>
6257         Chris January  <chris.january@arm.com>
6258
6259         * eval.c (evaluate_subexp_standard): Call Fortran argument
6260         wrapping logic.
6261         * f-lang.c (struct value): A value which can be passed into a
6262         Fortran function call.
6263         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6264         where appropriate.
6265         (struct type): Value ready for a Fortran function call.
6266         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6267         is needed.
6268         * f-lang.h (fortran_argument_convert): Declaration.
6269         (fortran_preserve_arg_pointer): Declaration.
6270         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6271
6272 2019-03-05  Tom Tromey  <tromey@adacore.com>
6273
6274         * python/py-prettyprint.c (print_string_repr): Remove #if.
6275         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6276
6277 2019-03-05  Tom Tromey  <tromey@adacore.com>
6278
6279         * target.c (the_dummy_target): Move later.  Change type to
6280         "dummy_target".
6281         (initialize_targets): Don't initialize the_dummy_target.
6282
6283 2019-03-05  Tom Tromey  <tromey@adacore.com>
6284
6285         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6286         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6287
6288 2019-03-05  Tom Tromey  <tromey@adacore.com>
6289
6290         * windows-nat.c (windows_nat_target::attach)
6291         (windows_nat_target::detach): Don't call gdb_flush.
6292         * valprint.c (generic_val_print, val_print, val_print_string):
6293         Don't call gdb_flush.
6294         * utils.c (defaulted_query): Don't call gdb_flush.
6295         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6296         * target.c (target_announce_detach): Don't call gdb_flush.
6297         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6298         * remote.c (extended_remote_target::attach): Don't call
6299         gdb_flush.
6300         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6301         * printcmd.c (do_examine): Don't call gdb_flush.
6302         (info_display_command): Don't call gdb_flush.
6303         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6304         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6305         * memattr.c (info_mem_command): Don't call gdb_flush.
6306         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6307         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6308         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6309         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6310         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6311         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6312         (gnu_nat_target::detach): Don't call gdb_flush.
6313         * f-valprint.c (f_val_print): Don't call gdb_flush.
6314         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6315         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6316         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6317         gdb_flush.
6318         * c-valprint.c (c_val_print): Don't call gdb_flush.
6319         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6320
6321 2019-03-05  Tom Tromey  <tromey@adacore.com>
6322
6323         * varobj.c (update_dynamic_varobj_children): Update.
6324         (install_default_visualizer): Use reset, not release.
6325         * value.c (set_internalvar): Update.
6326         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6327         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6328         ATTRIBUTE_UNUSED_RESULT.
6329
6330 2019-03-05  Tom Tromey  <tromey@adacore.com>
6331
6332         * remote.c (class scoped_remote_fd) <release>: Add
6333         ATTRIBUTE_UNUSED_RESULT.
6334
6335 2019-03-05  Tom Tromey  <tromey@adacore.com>
6336
6337         * macroexp.c (struct macro_buffer) <release>: Add
6338         ATTRIBUTE_UNUSED_RESULT.
6339
6340 2019-03-05  Tom Tromey  <tromey@adacore.com>
6341
6342         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6343         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6344         ATTRIBUTE_UNUSED_RESULT.
6345
6346 2019-03-05  Tom Tromey  <tromey@adacore.com>
6347
6348         * common/scoped_fd.h (class scoped_fd) <release>: Add
6349         ATTRIBUTE_UNUSED_RESULT.
6350
6351 2019-03-05  Tom Tromey  <tromey@adacore.com>
6352
6353         * parser-defs.h (struct parser_state) <release>: Add
6354         ATTRIBUTE_UNUSED_RESULT.
6355
6356 2019-03-05  Tom Tromey  <tromey@adacore.com>
6357
6358         * utils.h (class gdb_argv) <release>: Add
6359         ATTRIBUTE_UNUSED_RESULT.
6360         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6361
6362 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6363
6364         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6365         for-loop range, to avoid compiler warnings.
6366
6367         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6368         avoid compiler warnings about unused variables.
6369
6370         * NEWS: Mention end of support for native debugging on MS-Windows
6371         before XP.
6372
6373         PR gdb/24292
6374         * common/netstuff.c:
6375         * gdbserver/gdbreplay.c
6376         * gdbserver/remote-utils.c:
6377         * ser-tcp.c:
6378         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6379         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6380         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6381         'getaddrinfo' and 'freeaddrinfo' were not available before
6382         Windows XP, and mingw.org's MinGW headers by default define
6383         _WIN32_WINNT to 0x500.
6384
6385 2019-03-01  Gary Benson <gbenson@redhat.com>
6386
6387         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6388
6389 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6390             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6391
6392         PR gdb/8527
6393         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6394         set_sigint_trap, clear_sigint_trap.
6395
6396 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6397
6398         * target.c (target_detach): Clear the regcache and the
6399         frame cache.
6400
6401 2019-02-27  Pedro Alves  <palves@redhat.com>
6402
6403         * utils.c (set_screen_size): When we cap the height/width sizes,
6404         tweak the corresponding command variable to show "unlimited":
6405
6406 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6407             Pedro Alves  <palves@redhat.com>
6408
6409         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6410         before calling rl_set_screen_size.
6411
6412 2019-02-27  Tom Tromey  <tromey@adacore.com>
6413
6414         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6415         define.
6416         * python/py-value.c: Remove Python 2.4 workaround.
6417         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6418         workaround.
6419         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6420         Python 2.4 workaround.
6421         * python/python-internal.h: Remove Python 2.4 comment.
6422         (Py_ssize_t): Don't define.
6423         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6424         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6425         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6426         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6427         * python/python.c (do_start_initialization): Remove Python 2.4
6428         workaround.
6429         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6430         (print_children): Remove Python 2.4 workaround.
6431         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6432         workaround.
6433         (CHARBUFFERPROC_NAME): Remove.
6434         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6435         Python 2.4 workaround.
6436
6437 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6438
6439         * NEWS: Note minimum Python version.
6440
6441 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6442
6443         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6444         code from these functions.  Remove corresponding ifdefs.  Use
6445         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6446         Remove gotos and target of gotos.
6447         (infpy_search_memory): Likewise.
6448
6449 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6450
6451         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6452         (hppa_gdbarch_init): Don't register deleted functions with
6453         gdbarch.
6454
6455 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6456
6457         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6458         (h8300_unwind_sp): Delete.
6459         (h8300_dummy_id): Delete.
6460         (h8300_gdbarch_init): Don't register deleted functions with
6461         gdbarch.
6462
6463 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6464
6465         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6466         (ft32_unwind_pc): Delete.
6467         (ft32_unwind_sp): Delete.
6468         (ft32_gdbarch_init): Don't register deleted functions with
6469         gdbarch.
6470
6471 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6472
6473         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6474         (frv_unwind_pc): Delete.
6475         (frv_unwind_sp): Delete.
6476         (frv_gdbarch_init): Don't register deleted functions with
6477         gdbarch.
6478
6479 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6480
6481         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6482         (riscv_unwind_pc): Delete.
6483         (riscv_unwind_sp): Delete.
6484         (riscv_gdbarch_init): Don't register deleted functions with
6485         gdbarch.
6486
6487 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6488
6489         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6490         (csky_unwind_pc): Delete.
6491         (csky_unwind_sp): Delete.
6492         (csky_gdbarch_init): Don't register deleted functions with
6493         gdbarch.
6494
6495 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6496
6497         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6498         (cris_unwind_pc): Delete.
6499         (cris_unwind_sp): Delete.
6500         (cris_gdbarch_init): Don't register deleted functions with
6501         gdbarch.
6502
6503 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6504
6505         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6506         (bfin_unwind_pc): Delete.
6507         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6508
6509 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6510
6511         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6512         (arm_unwind_pc): Delete.
6513         (arm_unwind_sp): Delete.
6514         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6515
6516 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6517
6518         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6519         (arc_unwind_pc): Delete.
6520         (arc_unwind_sp): Delete.
6521         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6522
6523 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6524
6525         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6526         (alpha_unwind_pc): Delete.
6527         (alpha_gdbarch_init): Don't register deleted functions with
6528         gdbarch.
6529
6530 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6531
6532         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6533         (aarch64_unwind_pc): Delete.
6534         (aarch64_unwind_sp): Delete.
6535         (aarch64_gdbarch_init): Don't register deleted functions with
6536         gdbarch.
6537
6538 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6539
6540         * gdbtypes.c (type_align): Don't consider static members when
6541         computing structure alignment.
6542
6543 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6544
6545         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6546         return 0 for other types.
6547         * arch-utils.c (default_type_align): Always return 0.
6548         * gdbarch.h: Regenerate.
6549         * gdbarch.sh (type_align): Extend comment.
6550         * gdbtypes.c (type_align): Add additional comments, always call
6551         gdbarch_type_align before applying the default rules.
6552         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6553         generic code will then apply a suitable default.
6554         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6555         types, return 0 for other types.
6556
6557 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6558
6559         * NEWS: Create a new section for the next release branch.
6560         Rename the section of the current branch, now that it has
6561         been cut.
6562
6563 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6564
6565         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6566         * version.in: Bump version to 8.3.50.DATE-git.
6567
6568 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6569
6570         * aix-thread.c (ptid_cmp): Remove unused variable.
6571         (get_signaled_thread): Likewise.
6572         (store_regs_user_thread): Likewise.
6573         (store_regs_kernel_thread): Likewise.
6574         (fetch_regs_kernel_thread): Remove shadowed variable.
6575
6576 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6577
6578         * features/riscv/32bit-cpu.xml: Add register numbers.
6579         * features/riscv/32bit-fpu.c: Regenerate.
6580         * features/riscv/32bit-fpu.xml: Add register numbers.
6581         * features/riscv/64bit-cpu.xml: Add register numbers.
6582         * features/riscv/64bit-fpu.c: Regenerate.
6583         * features/riscv/64bit-fpu.xml: Add register numbers.
6584
6585 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6586
6587         * NEWS: Mention two argument form of gdb.Value constructor.
6588         * python/py-value.c (convert_buffer_and_type_to_value): New
6589         function.
6590         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6591         Add support for handling an optional second argument.  Call
6592         convert_buffer_and_type_to_value as appropriate.
6593         * python/python-internal.h (Py_buffer_deleter): New struct.
6594         (Py_buffer_up): New typedef.
6595
6596 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6597
6598         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6599         instead of releasing ownership.
6600
6601 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6602
6603         * dwarf2read.c (open_and_init_dwp_file): Call
6604         elf_numsections instead of bfd_count_sections to initialize
6605         dwp_file->num_sections.
6606
6607 2019-02-25  Tom Tromey  <tromey@adacore.com>
6608
6609         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6610
6611 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6612
6613         * gcore.in: Add '--readnever' option when invoking GDB.
6614
6615 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6616
6617         * MAINTAINERS: Update my email address.
6618
6619 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6620
6621         * build-id.c (build_id_to_debug_bfd_1): New function.
6622         (build_id_to_debug_bfd): Look for separate debug file in
6623         sysroot.
6624
6625 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6626
6627         * gdbarch.sh: Update the copyright year range that is placed into
6628         generated files.
6629
6630 2019-02-22  Keith Seitz  <keiths@redhat.com>
6631
6632         PR symtab/23853
6633         * linespec.c (create_sals_line_offset): Search for the default
6634         symtab's filename instead of its fullname.
6635
6636 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6637
6638         * NEWS: Update style defaults.
6639
6640 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6641
6642         * main.c (captured_main_1): Disable styling in batch mode.
6643
6644 2019-02-20  Tom Tromey  <tom@tromey.com>
6645
6646         * symtab.c (symtab_symbol_info): Fix typos.
6647
6648 2019-02-20  Tom Tromey  <tromey@adacore.com>
6649
6650         * findcmd.c (_initialize_mem_search): Use upper case for
6651         metasyntactic variables.
6652
6653 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6654
6655         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6656         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6657
6658 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6659
6660         * top.h (source_file_name): Change to std::string.
6661         * top.c (source_file_name): Likewise.
6662         (command_line_input): Adjust.
6663         * cli/cli-script.c (script_from_file): Adjust.
6664
6665 2019-02-19  Tom Tromey  <tromey@adacore.com>
6666
6667         * ravenscar-thread.c
6668         (ravenscar_thread_target::update_thread_list): Don't call
6669         ada_build_task_list.
6670         * ada-lang.h (ada_build_task_list): Don't declare.
6671         * ada-tasks.c (struct ada_tasks_inferior_data)
6672         <task_list_valid_p>: Now bool.
6673         (read_known_tasks, ada_task_list_changed)
6674         (ada_tasks_invalidate_inferior_data): Update.
6675         (read_known_tasks_array): Return bool.
6676         (read_known_tasks_list): Likewise.
6677         (read_known_tasks): Return void.
6678         (ada_build_task_list): Now static.
6679
6680 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6681
6682         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6683         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6684
6685 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6686
6687         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6688         variant for ada_tasks_pspace_data_handle and
6689         ada_tasks_inferior_data_handle.
6690         (ada_tasks_pspace_data_cleanup): New function.
6691         (ada_tasks_inferior_data_cleanup): New function.
6692
6693 2019-02-17  Tom Tromey  <tom@tromey.com>
6694
6695         * macrotab.h (macro_source_fullname): Return a std::string.
6696         * macrotab.c (macro_include, check_for_redefinition)
6697         (macro_undef, macro_lookup_definition, foreach_macro)
6698         (foreach_macro_in_scope): Update.
6699         (macro_source_fullname): Return a std::string.
6700         * macrocmd.c (show_pp_source_pos): Update.
6701
6702 2019-02-17  Tom Tromey  <tom@tromey.com>
6703
6704         * macrocmd.c (show_pp_source_pos): Style the file names.
6705
6706 2019-02-17  Tom Tromey  <tom@tromey.com>
6707
6708         PR tui/24197:
6709         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6710
6711 2019-02-17  Tom Tromey  <tom@tromey.com>
6712
6713         * ada-lang.c (user_select_syms): Use filtered printing.
6714         * utils.c (wrap_style): New global.
6715         (desired_style): Remove.
6716         (emit_style_escape): Add stream parameter.
6717         (set_output_style, reset_terminal_style, prompt_for_continue):
6718         Update.
6719         (flush_wrap_buffer): Only flush gdb_stdout.
6720         (wrap_here): Set wrap_style.
6721         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6722         treat escape sequences as a character.  Change when wrap buffer is
6723         flushed.
6724         (fputs_styled): Do not set the output style when the default is
6725         requested.
6726         * ui-style.h (struct ui_file_style) <is_default>: New method.
6727         * source.c (print_source_lines_base): Emit escape sequences in one
6728         piece.
6729
6730 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6731
6732         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6733         integers and enumeration types.
6734
6735 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6736
6737         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6738         instead of lookup_symbol_in_language
6739         (do_exact_match): New function.
6740         (ada_get_symbol_name_matcher): Return do_exact_match when
6741         doing a verbatim match.
6742
6743 2019-02-15  Tom Tromey  <tromey@adacore.com>
6744
6745         * ravenscar-thread.c (ravenscar_thread_target::resume)
6746         (ravenscar_thread_target::wait): Special case wildcard requests.
6747
6748 2019-02-15  Tom Tromey  <tromey@adacore.com>
6749
6750         * ravenscar-thread.c (base_ptid): Remove.
6751         (struct ravenscar_thread_target) <close>: New method.
6752         <m_base_ptid>: New member.
6753         <update_inferior_ptid, active_task, task_is_currently_active,
6754         runtime_initialized>: Declare methods.
6755         <ravenscar_thread_target>: Add constructor.
6756         (ravenscar_thread_target::task_is_currently_active)
6757         (ravenscar_thread_target::update_inferior_ptid)
6758         (ravenscar_runtime_initialized): Rename.  Now methods.
6759         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6760         (ravenscar_thread_target::update_thread_list): Update.
6761         (ravenscar_thread_target::active_task): Now method.
6762         (ravenscar_thread_target::store_registers)
6763         (ravenscar_thread_target::prepare_to_store)
6764         (ravenscar_thread_target::prepare_to_store)
6765         (ravenscar_thread_target::mourn_inferior): Update.
6766         (ravenscar_inferior_created): Use "new" to create target.
6767         (ravenscar_thread_target::get_ada_task_ptid): Update.
6768         (_initialize_ravenscar): Don't initialize base_ptid.
6769         (ravenscar_ops): Remove global.
6770
6771 2019-02-15  Tom Tromey  <tromey@adacore.com>
6772
6773         * target.h (push_target): Declare new overload.
6774         * target.c (push_target): New overload, taking an rvalue reference.
6775         * remote.c (remote_target::open_1): Use push_target overload.
6776         * corelow.c (core_target_open): Use push_target overload.
6777
6778 2019-02-15  Tom Tromey  <tromey@adacore.com>
6779
6780         * ravenscar-thread.c (is_ravenscar_task)
6781         (ravenscar_task_is_currently_active): Return bool.
6782         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6783         (_initialize_ravenscar): Remove "(void)".
6784         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6785         Return bool.
6786
6787 2019-02-15  Tom Tromey  <tromey@adacore.com>
6788
6789         * ravenscar-thread.c (ravenscar_runtime_initializer)
6790         (has_ravenscar_runtime, get_running_thread_id)
6791         (ravenscar_thread_target::resume): Fix indentation.
6792
6793 2019-02-15  Tom Tromey  <tromey@adacore.com>
6794
6795         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6796         from ravenscar_arch_ops.
6797         (sparc_ravenscar_ops::fetch_registers)
6798         (sparc_ravenscar_ops::store_registers): Now methods.
6799         (sparc_ravenscar_prepare_to_store): Remove.
6800         (sparc_ravenscar_ops): Redefine.
6801         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6802         methods and destructor.  Remove members.
6803         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6804         (ravenscar_thread_target::store_registers)
6805         (ravenscar_thread_target::prepare_to_store): Update.
6806         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6807         Remove.
6808         (struct ppc_ravenscar_powerpc_ops): Derive from
6809         ravenscar_arch_ops.
6810         (ppc_ravenscar_powerpc_ops::fetch_registers)
6811         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6812         (ppc_ravenscar_powerpc_ops): Redefine.
6813         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6814         (ppc_ravenscar_e500_ops::fetch_registers)
6815         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6816         (ppc_ravenscar_e500_ops): Redefine.
6817         * aarch64-ravenscar-thread.c
6818         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6819         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6820         (aarch64_ravenscar_fetch_registers)
6821         (aarch64_ravenscar_store_registers): Now methods.
6822         (aarch64_ravenscar_ops): Redefine.
6823
6824 2019-02-15  Tom Tromey  <tromey@adacore.com>
6825
6826         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6827         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6828         (ravenscar_thread_target::stopped_by_watchpoint)
6829         (ravenscar_thread_target::stopped_data_address)
6830         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6831
6832 2019-02-15  Tom Tromey  <tromey@adacore.com>
6833
6834         * ravenscar-thread.c: Fix some typos.
6835
6836 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6837             Tom Tromey  <tromey@adacore.com>
6838
6839         * ada-lang.c (ada_exception_sal): Change addr_string to a
6840         std::string.
6841         (create_ada_exception_catchpoint): Update.
6842
6843 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6844             Tom Tromey  <tromey@adacore.com>
6845
6846         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6847         (bp_location_ops): Remove.
6848         (base_breakpoint_allocate_location): Update.
6849         (free_bp_location): Update.
6850         * ada-lang.c (class ada_catchpoint_location)
6851         <ada_catchpoint_location>: Remove ops parameter.
6852         (ada_catchpoint_location_dtor): Remove.
6853         (ada_catchpoint_location_ops): Remove.
6854         (allocate_location_exception): Update.
6855         * breakpoint.h (struct bp_location_ops): Remove.
6856         (class bp_location) <bp_location>: Remove bp_location_ops
6857         parameter.
6858         <~bp_location>: Add destructor.
6859         <ops>: Remove.
6860
6861 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6862             Pedro Alves  <palves@redhat.com>
6863
6864         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6865         'PATH_MAX'.
6866
6867 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6868             Samuel Thibault  <samuel.thibault@gnu.org>
6869             Thomas Schwinge  <thomas@codesourcery.com>
6870
6871         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6872         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6873
6874 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6875
6876         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6877         (check_empty): Use "const char *".
6878
6879         * gnu-nat.c (gnu_nat_target::detach): Instead of
6880         'detach_inferior (pid)' call
6881         'detach_inferior (find_inferior_pid (pid))'.
6882
6883         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6884         'nat/fork-inferior.o'.
6885         * gnu-nat.c: #include "nat/fork-inferior.h".
6886
6887         * gnu-nat.c (gnu_nat_target::detach): Instead of
6888         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6889         * gnu-nat.h: #include "inf-child.h".
6890         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6891         'i386_gnu_nat_target::fetch_registers'.
6892         (gnu_store_registers): Rename/move to
6893         'i386_gnu_nat_target::store_registers'.
6894
6895         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6896         * gnu-nat.h (mach_thread_info): New function.
6897         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6898
6899         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6900
6901 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6902
6903         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6904
6905 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6906
6907         * windows-nat.c (windows_add_thread): Add new parameter
6908         "main_thread_p" with default value set to false.  Update
6909         function documentation as well as all callers.
6910         (windows_delete_thread): Likewise.
6911         (fake_create_process): Update call to windows_add_thread.
6912         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6913         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6914         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6915         call to windows_delete_thread.
6916
6917 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6918
6919         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6920
6921 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6922
6923         * symfile.c (find_separate_debug_file): Use canonical path of
6924         sysroot with child_path instead of gdb_sysroot if it is valid.
6925
6926 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6927
6928         * symfile.c (find_separate_debug_file): Use child_path to
6929         determine if an object file is under a sysroot.
6930
6931 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6932
6933         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6934         unittests/child-path-selftests.c.
6935         * common/pathstuff.c (child_path): New function.
6936         * common/pathstuff.h (child_path): New prototype.
6937         * unittests/child-path-selftests.c: New file.
6938
6939 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6940
6941         * symfile.c (find_separate_debug_file): Look for separate debug
6942         files in debug directories under the sysroot.
6943
6944 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6945
6946         * symtab.h (struct minimal_symbol data_p): New const method.
6947         (struct minimal_symbol text_p): Likewise.
6948         * symtab.c (output_source_filename): Use file name style
6949         to print file name.
6950         (print_symbol_info): Likewise.
6951         (print_msymbol_info): Use address style to print addresses.
6952         Use function name style to print executable text symbols.
6953         (expand_symtab_containing_pc): Use data_p.
6954         (find_pc_sect_compunit_symtab): Likewise.
6955
6956 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6957
6958         * breakpoint.c (describe_other_breakpoints): Use address style
6959         to print addresses.
6960         (say_where): Likewise.
6961
6962 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6963
6964         * ada-typeprint.c (print_func_type): Print function name
6965         style to print function name.
6966         * c-typeprint.c (c_print_type_1): Likewise.
6967
6968 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6969
6970         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6971         for execve.
6972
6973 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6974
6975         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6976         type_stack.
6977
6978 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6979
6980         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6981         TYPE_CODE_REF types.
6982
6983 2019-02-08  Jim Wilson  <jimw@sifive.com>
6984
6985         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6986         (riscv_linux_fregset): New.
6987         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6988
6989 2019-02-07  Tom Tromey  <tom@tromey.com>
6990
6991         * thread.c (thread_cancel_execution_command): Update.
6992         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6993         methods.
6994         (struct thread_fsm_ops): Remove.
6995         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6996         (thread_fsm_should_stop, thread_fsm_return_value)
6997         (thread_fsm_set_finished, thread_fsm_finished_p)
6998         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6999         Don't declare.
7000         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7001         * infrun.c (clear_proceed_status_thread)
7002         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7003         (print_stop_event): Update.
7004         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7005         Add constructor.
7006         (step_command_fsm_ops): Remove.
7007         (new_step_command_fsm): Remove.
7008         (step_1): Update.
7009         (step_command_fsm::should_stop): Rename from
7010         step_command_fsm_should_stop.
7011         (step_command_fsm::clean_up): Rename from
7012         step_command_fsm_clean_up.
7013         (step_command_fsm::do_async_reply_reason): Rename from
7014         step_command_fsm_async_reply_reason.
7015         (struct until_next_fsm): Inherit from thread_fsm.  Add
7016         constructor.
7017         (until_next_fsm_ops): Remove.
7018         (new_until_next_fsm): Remove.
7019         (until_next_fsm::should_stop): Rename from
7020         until_next_fsm_should_stop.
7021         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7022         (until_next_fsm::do_async_reply_reason): Rename from
7023         until_next_fsm_async_reply_reason.
7024         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7025         constructor.  Change type of breakpoint.
7026         (finish_command_fsm_ops): Remove.
7027         (new_finish_command_fsm): Remove.
7028         (finish_command_fsm::should_stop): Rename from
7029         finish_command_fsm_should_stop.
7030         (finish_command_fsm::clean_up): Rename from
7031         finish_command_fsm_clean_up.
7032         (finish_command_fsm::return_value): Rename from
7033         finish_command_fsm_return_value.
7034         (finish_command_fsm::do_async_reply_reason): Rename from
7035         finish_command_fsm_async_reply_reason.
7036         (finish_command): Update.
7037         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7038         Add constructor.
7039         (call_thread_fsm_ops): Remove.
7040         (call_thread_fsm::call_thread_fsm): Rename from
7041         new_call_thread_fsm.
7042         (call_thread_fsm::should_stop): Rename from
7043         call_thread_fsm_should_stop.
7044         (call_thread_fsm::should_notify_stop): Rename from
7045         call_thread_fsm_should_notify_stop.
7046         (run_inferior_call, call_function_by_hand_dummy): Update.
7047         * cli/cli-interp.c (should_print_stop_to_console): Update.
7048         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7049         Add constructor.  Change type of location_breakpoint,
7050         caller_breakpoint.
7051         (until_break_fsm_ops): Remove.
7052         (new_until_break_fsm): Remove.
7053         (until_break_fsm::should_stop): Rename from
7054         until_break_fsm_should_stop.
7055         (until_break_fsm::clean_up): Rename from
7056         until_break_fsm_clean_up.
7057         (until_break_fsm::do_async_reply_reason): Rename from
7058         until_break_fsm_async_reply_reason.
7059         (until_break_command): Update.
7060         * thread-fsm.c: Remove.
7061         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7062
7063 2019-02-07  Tom Tromey  <tom@tromey.com>
7064
7065         * yy-remap.h: Add include guard.
7066         * xtensa-tdep.h: Add include guard.
7067         * xcoffread.h: Rename include guard.
7068         * varobj-iter.h: Add include guard.
7069         * tui/tui.h: Rename include guard.
7070         * tui/tui-winsource.h: Rename include guard.
7071         * tui/tui-wingeneral.h: Rename include guard.
7072         * tui/tui-windata.h: Rename include guard.
7073         * tui/tui-win.h: Rename include guard.
7074         * tui/tui-stack.h: Rename include guard.
7075         * tui/tui-source.h: Rename include guard.
7076         * tui/tui-regs.h: Rename include guard.
7077         * tui/tui-out.h: Rename include guard.
7078         * tui/tui-layout.h: Rename include guard.
7079         * tui/tui-io.h: Rename include guard.
7080         * tui/tui-hooks.h: Rename include guard.
7081         * tui/tui-file.h: Rename include guard.
7082         * tui/tui-disasm.h: Rename include guard.
7083         * tui/tui-data.h: Rename include guard.
7084         * tui/tui-command.h: Rename include guard.
7085         * tic6x-tdep.h: Add include guard.
7086         * target/waitstatus.h: Rename include guard.
7087         * target/wait.h: Rename include guard.
7088         * target/target.h: Rename include guard.
7089         * target/resume.h: Rename include guard.
7090         * target-float.h: Rename include guard.
7091         * stabsread.h: Add include guard.
7092         * rs6000-tdep.h: Add include guard.
7093         * riscv-fbsd-tdep.h: Add include guard.
7094         * regformats/regdef.h: Rename include guard.
7095         * record.h: Rename include guard.
7096         * python/python.h: Rename include guard.
7097         * python/python-internal.h: Rename include guard.
7098         * python/py-stopevent.h: Rename include guard.
7099         * python/py-ref.h: Rename include guard.
7100         * python/py-record.h: Rename include guard.
7101         * python/py-record-full.h: Rename include guard.
7102         * python/py-record-btrace.h: Rename include guard.
7103         * python/py-instruction.h: Rename include guard.
7104         * python/py-events.h: Rename include guard.
7105         * python/py-event.h: Rename include guard.
7106         * procfs.h: Add include guard.
7107         * proc-utils.h: Add include guard.
7108         * p-lang.h: Add include guard.
7109         * or1k-tdep.h: Rename include guard.
7110         * observable.h: Rename include guard.
7111         * nto-tdep.h: Rename include guard.
7112         * nat/x86-linux.h: Rename include guard.
7113         * nat/x86-linux-dregs.h: Rename include guard.
7114         * nat/x86-gcc-cpuid.h: Add include guard.
7115         * nat/x86-dregs.h: Rename include guard.
7116         * nat/x86-cpuid.h: Rename include guard.
7117         * nat/ppc-linux.h: Rename include guard.
7118         * nat/mips-linux-watch.h: Rename include guard.
7119         * nat/linux-waitpid.h: Rename include guard.
7120         * nat/linux-ptrace.h: Rename include guard.
7121         * nat/linux-procfs.h: Rename include guard.
7122         * nat/linux-osdata.h: Rename include guard.
7123         * nat/linux-nat.h: Rename include guard.
7124         * nat/linux-namespaces.h: Rename include guard.
7125         * nat/linux-btrace.h: Rename include guard.
7126         * nat/glibc_thread_db.h: Rename include guard.
7127         * nat/gdb_thread_db.h: Rename include guard.
7128         * nat/gdb_ptrace.h: Rename include guard.
7129         * nat/fork-inferior.h: Rename include guard.
7130         * nat/amd64-linux-siginfo.h: Rename include guard.
7131         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7132         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7133         * nat/aarch64-linux.h: Rename include guard.
7134         * nat/aarch64-linux-hw-point.h: Rename include guard.
7135         * mn10300-tdep.h: Add include guard.
7136         * mips-linux-tdep.h: Add include guard.
7137         * mi/mi-parse.h: Rename include guard.
7138         * mi/mi-out.h: Rename include guard.
7139         * mi/mi-main.h: Rename include guard.
7140         * mi/mi-interp.h: Rename include guard.
7141         * mi/mi-getopt.h: Rename include guard.
7142         * mi/mi-console.h: Rename include guard.
7143         * mi/mi-common.h: Rename include guard.
7144         * mi/mi-cmds.h: Rename include guard.
7145         * mi/mi-cmd-break.h: Rename include guard.
7146         * m2-lang.h: Add include guard.
7147         * location.h: Rename include guard.
7148         * linux-record.h: Rename include guard.
7149         * linux-nat.h: Add include guard.
7150         * linux-fork.h: Add include guard.
7151         * i386-darwin-tdep.h: Rename include guard.
7152         * hppa-linux-offsets.h: Add include guard.
7153         * guile/guile.h: Rename include guard.
7154         * guile/guile-internal.h: Rename include guard.
7155         * gnu-nat.h: Rename include guard.
7156         * gdb-stabs.h: Rename include guard.
7157         * frv-tdep.h: Add include guard.
7158         * f-lang.h: Add include guard.
7159         * event-loop.h: Add include guard.
7160         * darwin-nat.h: Rename include guard.
7161         * cp-abi.h: Rename include guard.
7162         * config/sparc/nm-sol2.h: Rename include guard.
7163         * config/nm-nto.h: Rename include guard.
7164         * config/nm-linux.h: Add include guard.
7165         * config/i386/nm-i386gnu.h: Rename include guard.
7166         * config/djgpp/nl_types.h: Rename include guard.
7167         * config/djgpp/langinfo.h: Rename include guard.
7168         * compile/gcc-cp-plugin.h: Add include guard.
7169         * compile/gcc-c-plugin.h: Add include guard.
7170         * compile/compile.h: Rename include guard.
7171         * compile/compile-object-run.h: Rename include guard.
7172         * compile/compile-object-load.h: Rename include guard.
7173         * compile/compile-internal.h: Rename include guard.
7174         * compile/compile-cplus.h: Rename include guard.
7175         * compile/compile-c.h: Rename include guard.
7176         * common/xml-utils.h: Rename include guard.
7177         * common/x86-xstate.h: Rename include guard.
7178         * common/version.h: Rename include guard.
7179         * common/vec.h: Rename include guard.
7180         * common/tdesc.h: Rename include guard.
7181         * common/selftest.h: Rename include guard.
7182         * common/scoped_restore.h: Rename include guard.
7183         * common/scoped_mmap.h: Rename include guard.
7184         * common/scoped_fd.h: Rename include guard.
7185         * common/safe-iterator.h: Rename include guard.
7186         * common/run-time-clock.h: Rename include guard.
7187         * common/refcounted-object.h: Rename include guard.
7188         * common/queue.h: Rename include guard.
7189         * common/ptid.h: Rename include guard.
7190         * common/print-utils.h: Rename include guard.
7191         * common/preprocessor.h: Rename include guard.
7192         * common/pathstuff.h: Rename include guard.
7193         * common/observable.h: Rename include guard.
7194         * common/netstuff.h: Rename include guard.
7195         * common/job-control.h: Rename include guard.
7196         * common/host-defs.h: Rename include guard.
7197         * common/gdb_wait.h: Rename include guard.
7198         * common/gdb_vecs.h: Rename include guard.
7199         * common/gdb_unlinker.h: Rename include guard.
7200         * common/gdb_unique_ptr.h: Rename include guard.
7201         * common/gdb_tilde_expand.h: Rename include guard.
7202         * common/gdb_sys_time.h: Rename include guard.
7203         * common/gdb_string_view.h: Rename include guard.
7204         * common/gdb_splay_tree.h: Rename include guard.
7205         * common/gdb_setjmp.h: Rename include guard.
7206         * common/gdb_ref_ptr.h: Rename include guard.
7207         * common/gdb_optional.h: Rename include guard.
7208         * common/gdb_locale.h: Rename include guard.
7209         * common/gdb_assert.h: Rename include guard.
7210         * common/filtered-iterator.h: Rename include guard.
7211         * common/filestuff.h: Rename include guard.
7212         * common/fileio.h: Rename include guard.
7213         * common/environ.h: Rename include guard.
7214         * common/common-utils.h: Rename include guard.
7215         * common/common-types.h: Rename include guard.
7216         * common/common-regcache.h: Rename include guard.
7217         * common/common-inferior.h: Rename include guard.
7218         * common/common-gdbthread.h: Rename include guard.
7219         * common/common-exceptions.h: Rename include guard.
7220         * common/common-defs.h: Rename include guard.
7221         * common/common-debug.h: Rename include guard.
7222         * common/cleanups.h: Rename include guard.
7223         * common/buffer.h: Rename include guard.
7224         * common/btrace-common.h: Rename include guard.
7225         * common/break-common.h: Rename include guard.
7226         * cli/cli-utils.h: Rename include guard.
7227         * cli/cli-style.h: Rename include guard.
7228         * cli/cli-setshow.h: Rename include guard.
7229         * cli/cli-script.h: Rename include guard.
7230         * cli/cli-interp.h: Rename include guard.
7231         * cli/cli-decode.h: Rename include guard.
7232         * cli/cli-cmds.h: Rename include guard.
7233         * charset-list.h: Add include guard.
7234         * buildsym-legacy.h: Rename include guard.
7235         * bfin-tdep.h: Add include guard.
7236         * ax.h: Rename include guard.
7237         * arm-linux-tdep.h: Add include guard.
7238         * arm-fbsd-tdep.h: Add include guard.
7239         * arch/xtensa.h: Rename include guard.
7240         * arch/tic6x.h: Add include guard.
7241         * arch/i386.h: Add include guard.
7242         * arch/arm.h: Rename include guard.
7243         * arch/arm-linux.h: Rename include guard.
7244         * arch/arm-get-next-pcs.h: Rename include guard.
7245         * arch/amd64.h: Add include guard.
7246         * arch/aarch64-insn.h: Rename include guard.
7247         * arch-utils.h: Rename include guard.
7248         * annotate.h: Add include guard.
7249         * amd64-darwin-tdep.h: Rename include guard.
7250         * aarch64-linux-tdep.h: Add include guard.
7251         * aarch64-fbsd-tdep.h: Add include guard.
7252         * aarch32-linux-nat.h: Add include guard.
7253
7254 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7255
7256         * macrotab.c (macro_define_internal): New function that
7257         factorizes macro_define_object_internal and macro_define_function
7258         code.
7259         (macro_define_object_internal): Use macro_define_internal.
7260         (macro_define_function): Likewise.
7261
7262 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7263
7264         * macrocmd.c (extract_identifier): Return
7265         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7266         callers.
7267
7268 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7269
7270         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7271
7272 2019-02-05  Tom Tromey  <tom@tromey.com>
7273
7274         * target.c (target_stack::unpush): Move assertion earlier.
7275
7276 2019-01-30  Tom Tromey  <tom@tromey.com>
7277
7278         PR python/23615:
7279         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7280         (gdbpy_parse_and_eval): Likewise.
7281         * python/python-internal.h (gdbpy_allow_threads): New class.
7282
7283 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7284
7285         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7286         (aarch64_fbsd_fpregmap): Move earlier.
7287         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7288         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7289         instead of individual calls to trad_frame_set_reg_addr.
7290         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7291         earlier.
7292         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7293         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7294         instead of individual calls to trad_frame_set_reg_addr.
7295
7296 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7297
7298         * CONTRIBUTE: Replace contribution list with wiki link.
7299
7300 2019-01-25  Tom Tromey  <tom@tromey.com>
7301
7302         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7303
7304 2019-01-25  Tom Tromey  <tom@tromey.com>
7305
7306         * xtensa-linux-nat.c: Fix common/ includes.
7307         * xml-support.h: Fix common/ includes.
7308         * xml-support.c: Fix common/ includes.
7309         * x86-linux-nat.c: Fix common/ includes.
7310         * windows-nat.c: Fix common/ includes.
7311         * varobj.h: Fix common/ includes.
7312         * varobj.c: Fix common/ includes.
7313         * value.c: Fix common/ includes.
7314         * valops.c: Fix common/ includes.
7315         * utils.c: Fix common/ includes.
7316         * unittests/xml-utils-selftests.c: Fix common/ includes.
7317         * unittests/utils-selftests.c: Fix common/ includes.
7318         * unittests/unpack-selftests.c: Fix common/ includes.
7319         * unittests/tracepoint-selftests.c: Fix common/ includes.
7320         * unittests/style-selftests.c: Fix common/ includes.
7321         * unittests/string_view-selftests.c: Fix common/ includes.
7322         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7323         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7324         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7325         * unittests/rsp-low-selftests.c: Fix common/ includes.
7326         * unittests/parse-connection-spec-selftests.c: Fix common/
7327         includes.
7328         * unittests/optional-selftests.c: Fix common/ includes.
7329         * unittests/offset-type-selftests.c: Fix common/ includes.
7330         * unittests/observable-selftests.c: Fix common/ includes.
7331         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7332         * unittests/memrange-selftests.c: Fix common/ includes.
7333         * unittests/memory-map-selftests.c: Fix common/ includes.
7334         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7335         * unittests/function-view-selftests.c: Fix common/ includes.
7336         * unittests/environ-selftests.c: Fix common/ includes.
7337         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7338         * unittests/common-utils-selftests.c: Fix common/ includes.
7339         * unittests/cli-utils-selftests.c: Fix common/ includes.
7340         * unittests/array-view-selftests.c: Fix common/ includes.
7341         * ui-file.c: Fix common/ includes.
7342         * tui/tui-io.c: Fix common/ includes.
7343         * tracepoint.h: Fix common/ includes.
7344         * tracepoint.c: Fix common/ includes.
7345         * tracefile-tfile.c: Fix common/ includes.
7346         * top.h: Fix common/ includes.
7347         * top.c: Fix common/ includes.
7348         * thread.c: Fix common/ includes.
7349         * target/waitstatus.h: Fix common/ includes.
7350         * target/waitstatus.c: Fix common/ includes.
7351         * target.h: Fix common/ includes.
7352         * target.c: Fix common/ includes.
7353         * target-memory.c: Fix common/ includes.
7354         * target-descriptions.c: Fix common/ includes.
7355         * symtab.h: Fix common/ includes.
7356         * symfile.c: Fix common/ includes.
7357         * stap-probe.c: Fix common/ includes.
7358         * spu-linux-nat.c: Fix common/ includes.
7359         * sparc-nat.c: Fix common/ includes.
7360         * source.c: Fix common/ includes.
7361         * solib.c: Fix common/ includes.
7362         * solib-target.c: Fix common/ includes.
7363         * ser-unix.c: Fix common/ includes.
7364         * ser-tcp.c: Fix common/ includes.
7365         * ser-pipe.c: Fix common/ includes.
7366         * ser-base.c: Fix common/ includes.
7367         * selftest-arch.c: Fix common/ includes.
7368         * s12z-tdep.c: Fix common/ includes.
7369         * rust-exp.y: Fix common/ includes.
7370         * rs6000-aix-tdep.c: Fix common/ includes.
7371         * riscv-tdep.c: Fix common/ includes.
7372         * remote.c: Fix common/ includes.
7373         * remote-notif.h: Fix common/ includes.
7374         * remote-fileio.h: Fix common/ includes.
7375         * remote-fileio.c: Fix common/ includes.
7376         * regcache.h: Fix common/ includes.
7377         * regcache.c: Fix common/ includes.
7378         * record-btrace.c: Fix common/ includes.
7379         * python/python.c: Fix common/ includes.
7380         * python/py-type.c: Fix common/ includes.
7381         * python/py-inferior.c: Fix common/ includes.
7382         * progspace.h: Fix common/ includes.
7383         * producer.c: Fix common/ includes.
7384         * procfs.c: Fix common/ includes.
7385         * proc-api.c: Fix common/ includes.
7386         * printcmd.c: Fix common/ includes.
7387         * ppc-linux-nat.c: Fix common/ includes.
7388         * parser-defs.h: Fix common/ includes.
7389         * osdata.c: Fix common/ includes.
7390         * obsd-nat.c: Fix common/ includes.
7391         * nat/x86-linux.c: Fix common/ includes.
7392         * nat/x86-linux-dregs.c: Fix common/ includes.
7393         * nat/x86-dregs.h: Fix common/ includes.
7394         * nat/x86-dregs.c: Fix common/ includes.
7395         * nat/ppc-linux.c: Fix common/ includes.
7396         * nat/mips-linux-watch.h: Fix common/ includes.
7397         * nat/mips-linux-watch.c: Fix common/ includes.
7398         * nat/linux-waitpid.c: Fix common/ includes.
7399         * nat/linux-ptrace.h: Fix common/ includes.
7400         * nat/linux-ptrace.c: Fix common/ includes.
7401         * nat/linux-procfs.c: Fix common/ includes.
7402         * nat/linux-personality.c: Fix common/ includes.
7403         * nat/linux-osdata.c: Fix common/ includes.
7404         * nat/linux-namespaces.c: Fix common/ includes.
7405         * nat/linux-btrace.h: Fix common/ includes.
7406         * nat/linux-btrace.c: Fix common/ includes.
7407         * nat/fork-inferior.c: Fix common/ includes.
7408         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7409         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7410         * nat/aarch64-linux.c: Fix common/ includes.
7411         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7412         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7413         * namespace.h: Fix common/ includes.
7414         * mips-linux-tdep.c: Fix common/ includes.
7415         * minsyms.c: Fix common/ includes.
7416         * mi/mi-parse.h: Fix common/ includes.
7417         * mi/mi-main.c: Fix common/ includes.
7418         * mi/mi-cmd-env.c: Fix common/ includes.
7419         * memrange.h: Fix common/ includes.
7420         * memattr.c: Fix common/ includes.
7421         * maint.h: Fix common/ includes.
7422         * maint.c: Fix common/ includes.
7423         * main.c: Fix common/ includes.
7424         * machoread.c: Fix common/ includes.
7425         * location.c: Fix common/ includes.
7426         * linux-thread-db.c: Fix common/ includes.
7427         * linux-nat.c: Fix common/ includes.
7428         * linux-fork.c: Fix common/ includes.
7429         * inline-frame.c: Fix common/ includes.
7430         * infrun.c: Fix common/ includes.
7431         * inflow.c: Fix common/ includes.
7432         * inferior.h: Fix common/ includes.
7433         * inferior.c: Fix common/ includes.
7434         * infcmd.c: Fix common/ includes.
7435         * inf-ptrace.c: Fix common/ includes.
7436         * inf-child.c: Fix common/ includes.
7437         * ia64-linux-nat.c: Fix common/ includes.
7438         * i387-tdep.c: Fix common/ includes.
7439         * i386-tdep.c: Fix common/ includes.
7440         * i386-linux-tdep.c: Fix common/ includes.
7441         * i386-linux-nat.c: Fix common/ includes.
7442         * i386-go32-tdep.c: Fix common/ includes.
7443         * i386-fbsd-tdep.c: Fix common/ includes.
7444         * i386-fbsd-nat.c: Fix common/ includes.
7445         * guile/scm-type.c: Fix common/ includes.
7446         * guile/guile.c: Fix common/ includes.
7447         * go32-nat.c: Fix common/ includes.
7448         * gnu-nat.c: Fix common/ includes.
7449         * gdbthread.h: Fix common/ includes.
7450         * gdbarch-selftests.c: Fix common/ includes.
7451         * gdb_usleep.c: Fix common/ includes.
7452         * gdb_select.h: Fix common/ includes.
7453         * gdb_bfd.c: Fix common/ includes.
7454         * gcore.c: Fix common/ includes.
7455         * fork-child.c: Fix common/ includes.
7456         * findvar.c: Fix common/ includes.
7457         * fbsd-nat.c: Fix common/ includes.
7458         * event-top.c: Fix common/ includes.
7459         * event-loop.c: Fix common/ includes.
7460         * dwarf2read.c: Fix common/ includes.
7461         * dwarf2loc.c: Fix common/ includes.
7462         * dwarf2-frame.c: Fix common/ includes.
7463         * dwarf-index-cache.c: Fix common/ includes.
7464         * dtrace-probe.c: Fix common/ includes.
7465         * disasm-selftests.c: Fix common/ includes.
7466         * defs.h: Fix common/ includes.
7467         * csky-tdep.c: Fix common/ includes.
7468         * cp-valprint.c: Fix common/ includes.
7469         * cp-support.h: Fix common/ includes.
7470         * cp-support.c: Fix common/ includes.
7471         * corelow.c: Fix common/ includes.
7472         * completer.h: Fix common/ includes.
7473         * completer.c: Fix common/ includes.
7474         * compile/compile.c: Fix common/ includes.
7475         * compile/compile-loc2c.c: Fix common/ includes.
7476         * compile/compile-cplus-types.c: Fix common/ includes.
7477         * compile/compile-cplus-symbols.c: Fix common/ includes.
7478         * command.h: Fix common/ includes.
7479         * cli/cli-dump.c: Fix common/ includes.
7480         * cli/cli-cmds.c: Fix common/ includes.
7481         * charset.c: Fix common/ includes.
7482         * build-id.c: Fix common/ includes.
7483         * btrace.h: Fix common/ includes.
7484         * btrace.c: Fix common/ includes.
7485         * breakpoint.h: Fix common/ includes.
7486         * breakpoint.c: Fix common/ includes.
7487         * ax.h:
7488         (enum agent_op): Fix common/ includes.
7489         * ax-general.c (struct aop_map): Fix common/ includes.
7490         * ax-gdb.c: Fix common/ includes.
7491         * auxv.c: Fix common/ includes.
7492         * auto-load.c: Fix common/ includes.
7493         * arm-tdep.c: Fix common/ includes.
7494         * arch/riscv.c: Fix common/ includes.
7495         * arch/ppc-linux-common.c: Fix common/ includes.
7496         * arch/i386.c: Fix common/ includes.
7497         * arch/arm.c: Fix common/ includes.
7498         * arch/arm-linux.c: Fix common/ includes.
7499         * arch/arm-get-next-pcs.c: Fix common/ includes.
7500         * arch/amd64.c: Fix common/ includes.
7501         * arch/aarch64.c: Fix common/ includes.
7502         * arch/aarch64-insn.c: Fix common/ includes.
7503         * arch-utils.c: Fix common/ includes.
7504         * amd64-windows-tdep.c: Fix common/ includes.
7505         * amd64-tdep.c: Fix common/ includes.
7506         * amd64-sol2-tdep.c: Fix common/ includes.
7507         * amd64-obsd-tdep.c: Fix common/ includes.
7508         * amd64-nbsd-tdep.c: Fix common/ includes.
7509         * amd64-linux-tdep.c: Fix common/ includes.
7510         * amd64-linux-nat.c: Fix common/ includes.
7511         * amd64-fbsd-tdep.c: Fix common/ includes.
7512         * amd64-fbsd-nat.c: Fix common/ includes.
7513         * amd64-dicos-tdep.c: Fix common/ includes.
7514         * amd64-darwin-tdep.c: Fix common/ includes.
7515         * agent.c: Fix common/ includes.
7516         * ada-lang.h: Fix common/ includes.
7517         * ada-lang.c: Fix common/ includes.
7518         * aarch64-tdep.c: Fix common/ includes.
7519
7520 2019-01-25  Tom Tromey  <tom@tromey.com>
7521
7522         * common/create-version.sh: Use common/version.h.
7523
7524 2019-01-24  Pedro Alves  <palves@redhat.com>
7525
7526         * infrun.c (signal_stop, signal_print, signal_program)
7527         (signal_catch, signal_pass): Now arrays instead of pointers.
7528         (update_signals_program_target, do_target_resume)
7529         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7530         * linux-nat.c (linux_nat_target::pass_signals)
7531         (linux_nat_target::create_inferior, linux_nat_target::attach):
7532         Adjust.
7533         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7534         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7535         * procfs.c (procfs_target::pass_signals): Adjust.
7536         * record-full.c (record_full_target::resume): Adjust.
7537         * remote.c (remote_target::pass_signals)
7538         (remote_target::program_signals): Adjust.
7539         * target-debug.h (target_debug_print_signals): Now takes a
7540         gdb::array_view as parameter.  Adjust.
7541         * target.h (target_ops) <pass_signals, program_signals>: Replace
7542         pointer and length parameters with gdb::array_view.
7543         (target_pass_signals, target_program_signals): Likewise.
7544         * target-delegates.c: Regenerate.
7545
7546 2019-01-24  Pedro Alves  <palves@redhat.com>
7547
7548         * common/forward-scope-exit.h
7549         (forward_scope_exit::forward_scope_exit): Pass arguments to
7550         m_bind_function directly, instead of creating a std::bind and
7551         copying that.
7552
7553 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7554
7555         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7556         for static members.
7557         (pass_in_v_vfp_candidate): Likewise.
7558
7559 2019-01-23  Tom Tromey  <tom@tromey.com>
7560             Pedro Alves  <palves@redhat.com>
7561
7562         * regcache.c (class regcache_invalidator): Remove.
7563         (regcache::raw_write): Use make_scope_exit.
7564
7565 2019-01-23  Tom Tromey  <tom@tromey.com>
7566
7567         * ui-out.h (class ui_out_emit_type): Update comment.
7568
7569 2019-01-23  Tom Tromey  <tom@tromey.com>
7570
7571         * infrun.c (fetch_inferior_event): Update comment.
7572
7573 2019-01-23  Tom Tromey  <tom@tromey.com>
7574             Pedro Alves  <palves@redhat.com>
7575
7576         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7577         parameter.
7578         (fetch_inferior_event): Use SCOPE_EXIT.
7579
7580
7581 2019-01-23  Tom Tromey  <tom@tromey.com>
7582             Pedro Alves  <palves@redhat.com>
7583
7584         * infrun.c (disable_thread_events): Delete.
7585         (stop_all_threads): Use SCOPE_EXIT.
7586
7587 2019-01-23  Tom Tromey  <tom@tromey.com>
7588             Pedro Alves  <palves@redhat.com>
7589
7590         * symfile.c: Include forward-scope-exit.h.
7591         (clear_symtab_users_cleanup): Replace forward declaration with
7592         a FORWARD_SCOPE_EXIT.
7593         (syms_from_objfile_1): Use the forward_scope_exit and
7594         gdb::optional instead of cleanup_function.
7595         (reread_symbols): Use the forward_scope_exit instead of
7596         cleanup_function.
7597         (clear_symtab_users_cleanup): Remove function.
7598
7599 2019-01-23  Tom Tromey  <tom@tromey.com>
7600             Pedro Alves  <palves@redhat.com>
7601
7602         * linux-nat.c: Include scope-exit.h.
7603         (cleanup_target_stop): Remove.
7604         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7605         SCOPE_EXIT.
7606
7607 2019-01-23  Tom Tromey  <tom@tromey.com>
7608             Pedro Alves  <palves@redhat.com>
7609
7610         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7611         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7612
7613 2019-01-23  Tom Tromey  <tom@tromey.com>
7614             Andrew Burgess  <andrew.burgess@embecosm.com>
7615             Pedro Alves  <palves@redhat.com>
7616
7617         * infrun.c (fetch_inferior_event): Use scope_exit.
7618         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7619         * top.c (execute_command): Use scope_exit.
7620         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7621         * utils.c (do_bpstat_clear_actions_cleanup)
7622         (make_bpstat_clear_actions_cleanup): Remove.
7623
7624 2019-01-23  Tom Tromey  <tom@tromey.com>
7625             Pedro Alves  <palves@redhat.com>
7626
7627         * infrun.c: Include "common/scope-exit.h"
7628         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7629         (wait_for_inferior): Use SCOPE_EXIT.
7630         (fetch_inferior_event): Use scope_exit.
7631
7632 2019-01-23  Tom Tromey  <tom@tromey.com>
7633             Pedro Alves  <palves@redhat.com>
7634
7635         * breakpoint.c (create_breakpoint): Remove cleanup.
7636
7637 2019-01-23  Tom Tromey  <tom@tromey.com>
7638             Andrew Burgess  <andrew.burgess@embecosm.com>
7639             Pedro Alves  <palves@redhat.com>
7640
7641 2019-01-23  Pedro Alves  <palves@redhat.com>
7642
7643         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7644
7645 2019-01-23  Pedro Alves  <palves@redhat.com>
7646             Andrew Burgess  <andrew.burgess@embecosm.com>
7647
7648         * gdbthread.h: Include "common/forward-scope-exit.h".
7649         (scoped_finish_thread_state): Redefine custom class in terms of
7650         forward_scope_exit.
7651
7652 2019-01-23  Pedro Alves  <palves@redhat.com>
7653             Andrew Burgess  <andrew.burgess@embecosm.com>
7654
7655         * common/forward-scope-exit.h: New file.
7656
7657 2019-01-23  Pedro Alves  <palves@redhat.com>
7658             Andrew Burgess  <andrew.burgess@embecosm.com>
7659             Tom Tromey  <tom@tromey.com>
7660
7661         * common/scope-exit.h: New file.
7662
7663 2019-01-23  Pedro Alves  <palves@redhat.com>
7664
7665         * common/preprocessor.h (ESC): Rename to ...
7666         (ESC_PARENS): ... this.
7667         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7668         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7669
7670 2019-01-23  Tom Tromey  <tom@tromey.com>
7671
7672         * language.h (class scoped_switch_to_sym_language_if_auto):
7673         Initialize m_lang in both cases.
7674
7675 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7676
7677         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7678         with XCNEW.
7679
7680 2019-01-22  Tom Tromey  <tom@tromey.com>
7681
7682         * corelow.c: Do not include sys/file.h.
7683
7684 2019-01-22  Tom Tromey  <tom@tromey.com>
7685
7686         * tui/tui-wingeneral.h: Include gdb_curses.h.
7687
7688 2019-01-22  Tom Tromey  <tom@tromey.com>
7689
7690         * source-cache.h (class source_cache) <get_source_lines,
7691         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7692
7693 2019-01-22  Tom Tromey  <tom@tromey.com>
7694
7695         * remote-fileio.h (struct remote_target): Declare.
7696
7697 2019-01-22  Tom Tromey  <tom@tromey.com>
7698
7699         * python/py-arch.c: Do not include py-ref.h.
7700         * python/py-bpevent.c: Do not include py-ref.h.
7701         * python/py-cmd.c: Do not include py-ref.h.
7702         * python/py-continueevent.c: Do not include py-ref.h.
7703         * python/py-event.h: Do not include py-ref.h.
7704         * python/py-evtregistry.c: Do not include py-ref.h.
7705         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7706         * python/py-frame.c: Do not include py-ref.h.
7707         * python/py-framefilter.c: Do not include py-ref.h.
7708         * python/py-function.c: Do not include py-ref.h.
7709         * python/py-infevents.c: Do not include py-ref.h.
7710         * python/py-linetable.c: Do not include py-ref.h.
7711         * python/py-objfile.c: Do not include py-ref.h.
7712         * python/py-param.c: Do not include py-ref.h.
7713         * python/py-prettyprint.c: Do not include py-ref.h.
7714         * python/py-progspace.c: Do not include py-ref.h.
7715         * python/py-symbol.c: Do not include py-ref.h.
7716         * python/py-symtab.c: Do not include py-ref.h.
7717         * python/py-type.c: Do not include py-ref.h.
7718         * python/py-unwind.c: Do not include py-ref.h.
7719         * python/py-utils.c: Do not include py-ref.h.
7720         * python/py-value.c: Do not include py-ref.h.
7721         * python/py-varobj.c: Do not include py-ref.h.
7722         * python/py-xmethods.c: Do not include py-ref.h.
7723         * python/python.c: Do not include py-ref.h.
7724         * varobj.c: Do not include py-ref.h.
7725
7726 2019-01-22  Tom Tromey  <tom@tromey.com>
7727
7728         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7729         keyword for bcache.
7730
7731 2019-01-22  Tom Tromey  <tom@tromey.com>
7732
7733         * compile/compile-cplus-types.c: Remove a comment by #include.
7734
7735 2019-01-22  Tom Tromey  <tom@tromey.com>
7736
7737         * compile/gcc-c-plugin.h: Include compile-internal.h.
7738
7739 2019-01-22  Tom Tromey  <tom@tromey.com>
7740
7741         * stabsread.c (EXTERN): Do not define.
7742         (symnum, next_symbol_text_func, processing_gcc_compilation)
7743         (within_function, global_sym_chain, global_stabs)
7744         (previous_stab_code, this_object_header_files)
7745         (n_this_object_header_files)
7746         (n_allocated_this_object_header_files): Define.
7747         * stabsread.h (EXTERN): Never define.  Use "extern".
7748
7749 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7750
7751         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7752         history_value.
7753
7754 2019-01-21  Tom Tromey  <tom@tromey.com>
7755
7756         * ui-out.c: Fix includes.
7757         * tui/tui-source.c: Fix includes.
7758         * target.c: Fix includes.
7759         * remote.c: Fix includes.
7760         * regcache.c: Fix includes.
7761         * python/py-block.c: Fix includes.
7762         * printcmd.c: Fix includes.
7763         * or1k-tdep.c: Fix includes.
7764         * mi/mi-main.c: Fix includes.
7765         * m32r-tdep.c: Fix includes.
7766         * csky-tdep.c: Fix includes.
7767         * compile/compile-cplus-types.c: Fix includes.
7768         * cli/cli-interp.c: Fix includes.
7769
7770 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7771
7772         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7773         for padding.
7774
7775 2019-01-16  Tom Tromey  <tom@tromey.com>
7776
7777         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7778         earlier.
7779         (struct objfile) <msymbols_range>: Move from top level.
7780         <msymbols>: New method.
7781         (class objfile_msymbols): Remove.
7782         * symtab.c (default_collect_symbol_completion_matches_break_on):
7783         Update.
7784         * symmisc.c (dump_msymbols): Update.
7785         * stabsread.c (scan_file_globals): Update.
7786         * objc-lang.c (info_selectors_command, info_classes_command)
7787         (find_methods): Update.
7788         * minsyms.c (find_solib_trampoline_target): Update.
7789         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7790         * coffread.c (coff_symfile_read): Update.
7791         * ada-lang.c (ada_lookup_simple_minsym)
7792         (ada_collect_symbol_completion_matches): Update.
7793
7794 2019-01-16  Tom Tromey  <tom@tromey.com>
7795
7796         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7797         type.  Remove no-argument constructor.
7798         <iterator::operator++>: Simplify.
7799         <begin>: Update.
7800         <end>: Use minimal_symbol_count.
7801
7802 2019-01-16  Tom Tromey  <tom@tromey.com>
7803
7804         * objfiles.h (struct objfile) <psymtabs>: New method.
7805         (class objfile_psymtabs): Remove.
7806         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7807         typedef.
7808         <range>: New method.
7809         (require_partial_symbols): Change return type.
7810         * psymtab.c (require_partial_symbols)
7811         (psym_expand_symtabs_matching): Update.
7812         * mdebugread.c (parse_partial_symbols): Update.
7813         * dbxread.c (dbx_end_psymtab): Update.
7814
7815 2019-01-15  Tom Tromey  <tom@tromey.com>
7816
7817         * symtab.c (lookup_objfile_from_block)
7818         (lookup_symbol_in_objfile_symtabs)
7819         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7820         (find_line_symtab, info_sources_command)
7821         (default_collect_symbol_completion_matches_break_on)
7822         (make_source_files_completion_list): Update.
7823         * symmisc.c (print_objfile_statistics, dump_objfile)
7824         (maintenance_print_symbols, maintenance_info_symtabs)
7825         (maintenance_check_symtabs, maintenance_info_line_tables):
7826         Update.
7827         * source.c (select_source_symtab)
7828         (forget_cached_source_info_for_objfile): Update.
7829         * objfiles.h (class objfile_compunits): Remove.
7830         (struct objfile) <compunits_range>: New typedef.
7831         (compunits): New method.
7832         * objfiles.c (objfile_relocate1): Update.
7833         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7834         * maint.c (count_symtabs_and_blocks): Update.
7835         * linespec.c (iterate_over_all_matching_symtabs): Update.
7836         * cp-support.c (add_symbol_overload_list_qualified): Update.
7837         * coffread.c (coff_symtab_read): Update.
7838         * ada-lang.c (add_nonlocal_symbols)
7839         (ada_collect_symbol_completion_matches)
7840         (ada_add_global_exceptions): Update.
7841
7842 2019-01-15  Tom Tromey  <tom@tromey.com>
7843
7844         * progspace.h (program_space) <objfiles_safe_range>: New
7845         typedef.
7846         <objfiles_safe>: New method.
7847         * objfiles.h (class all_objfiles_safe): Remove.
7848         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7849         * jit.c (jit_inferior_exit_hook): Update.
7850
7851 2019-01-17  Tom Tromey  <tom@tromey.com>
7852
7853         * progspace.h (program_space) <objfiles_range>: New typedef.
7854         <objfiles>: New method.
7855         <objfiles_head>: Rename from objfiles.
7856         (object_files): Update.
7857         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7858         * guile/scm-pretty-print.c
7859         (ppscm_find_pretty_printer_from_objfiles): Update.
7860         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7861         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7862         Update.
7863         * python/py-progspace.c (pspy_get_objfiles): Update.
7864         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7865         Update.
7866         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7867         (objfpy_lookup_objfile_by_build_id): Update.
7868         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7869         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7870         Update.
7871         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7872         (expand_symtab_containing_pc, lookup_objfile_from_block)
7873         (lookup_static_symbol, basic_lookup_transparent_type)
7874         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7875         (find_line_symtab, info_sources_command)
7876         (default_collect_symbol_completion_matches_break_on)
7877         (make_source_files_completion_list, find_main_name): Update.
7878         * symmisc.c (print_symbol_bcache_statistics)
7879         (print_objfile_statistics, maintenance_print_symbols)
7880         (maintenance_print_msymbols, maintenance_print_objfiles)
7881         (maintenance_info_symtabs, maintenance_check_symtabs)
7882         (maintenance_expand_symtabs, maintenance_info_line_tables):
7883         Update.
7884         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7885         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7886         (map_overlay_command, unmap_overlay_command)
7887         (simple_overlay_update, expand_symtabs_matching)
7888         (map_symbol_filenames): Update.
7889         * symfile-debug.c (set_debug_symfile): Update.
7890         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7891         Update.
7892         * source.c (select_source_symtab, forget_cached_source_info):
7893         Update.
7894         * solib.c (solib_read_symbols): Update.
7895         * solib-spu.c (append_ocl_sos): Update.
7896         * psymtab.c (maintenance_print_psymbols)
7897         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7898         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7899         * printcmd.c (info_symbol_command): Update.
7900         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7901         Update.
7902         * objfiles.h (class all_objfiles): Remove.
7903         * objfiles.c (have_partial_symbols, have_full_symbols)
7904         (have_minimal_symbols, qsort_cmp, update_section_map)
7905         (shared_objfile_contains_address_p)
7906         (default_iterate_over_objfiles_in_search_order): Update.
7907         * objc-lang.c (info_selectors_command, info_classes_command)
7908         (find_methods): Update.
7909         * minsyms.c (find_solib_trampoline_target): Update.
7910         * maint.c (maintenance_info_sections)
7911         (maintenance_translate_address, count_symtabs_and_blocks):
7912         Update.
7913         * main.c (captured_main_1): Update.
7914         * linux-thread-db.c (try_thread_db_load_from_pdir)
7915         (has_libpthread): Update.
7916         * linespec.c (iterate_over_all_matching_symtabs)
7917         (search_minsyms_for_name): Update.
7918         * jit.c (jit_find_objf_with_entry_addr): Update.
7919         * hppa-tdep.c (find_unwind_entry)
7920         (hppa_lookup_stub_minimal_symbol): Update.
7921         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7922         Update.
7923         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7924         (elf_gnu_ifunc_resolve_by_got): Update.
7925         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7926         * dwarf-index-write.c (save_gdb_index_command): Update.
7927         * cp-support.c (add_symbol_overload_list_qualified): Update.
7928         * breakpoint.c (create_overlay_event_breakpoint)
7929         (create_longjmp_master_breakpoint)
7930         (create_std_terminate_master_breakpoint)
7931         (create_exception_master_breakpoint): Update.
7932         * blockframe.c (find_pc_partial_function): Update.
7933         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7934         (ada_collect_symbol_completion_matches)
7935         (ada_add_global_exceptions): Update.
7936
7937 2019-01-17  Tom Tromey  <tom@tromey.com>
7938
7939         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7940         declare VEC.
7941         (solib_target_parse_libraries): Change return type.
7942         (library_list_start_segment, library_list_start_section)
7943         (library_list_end_library, library_list_start_library); Update.
7944         (solib_target_free_library_list): Remove.
7945         (solib_target_parse_libraries): Remove cleanup.  Change return
7946         type.
7947         (solib_target_current_sos): Update.
7948
7949 2019-01-17  Tom Tromey  <tromey@bapiya>
7950
7951         * valprint.c: Replace "the the" with "the".
7952         * symtab.c: Replace "the the" with "the".
7953         * solib.c: Replace "the the" with "the".
7954         * solib-dsbt.c: Replace "the the" with "the".
7955         * linespec.c: Replace "the the" with "the".
7956         * dwarf2loc.h: Replace "the the" with "the".
7957         * amd64-windows-tdep.c: Replace "the the" with "the".
7958         * aarch64-tdep.c: Replace "the the" with "the".
7959
7960 2019-01-16  Keith Seitz  <keiths@redhat.com>
7961
7962         PR gdb/23773
7963         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7964         <builder>: Rename to ..
7965         <m_builder>: ... this and make private.
7966         (dwarf2_cu::get_builder): New method.  Change all users of
7967         `builder' to use this method.
7968         (dwarf2_start_symtab): Move to ...
7969         (dwarf2_cu::start_symtab): ... here.  Update all callers
7970         (setup_type_unit_groups): Move to ...
7971         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7972         callers.
7973         (dwarf2_cu::reset_builder): New method.
7974         (process_full_compunit, process_full_type_unit): Use
7975         dwarf2_cu::reset_builder.
7976         (follow_die_offset): Record the ancestor CU if it is different
7977         from the followed DIE's CU.
7978         (follow_die_sig_1): Likewise.
7979
7980 2019-01-15  Tom Tromey  <tom@tromey.com>
7981
7982         * remote.c (class remote_state) <buf>: Now a char_vector.
7983         <buf_size>: Remove.
7984         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7985         parameter.
7986         (remote_target::getpkt_or_notif_sane_1)
7987         (remote_target::getpkt_sane)
7988         (remote_target::getpkt_or_notif_sane): Likewise.
7989         (class remote_target) <putpkt>: New overload.
7990         (remote_target::read_frame): Change type of "buf_p".  Remove
7991         sizeof_p parameter.
7992         (packet_ok): New overload.
7993         (packet_check_result): New overload.
7994         Update all uses.
7995
7996 2019-01-14  Tom Tromey  <tom@tromey.com>
7997
7998         * remote-notif.c (handle_notification, remote_notif_ack)
7999         (remote_notif_parse): Make "buf" const.
8000         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8001         const.
8002         (remote_notif_parse, remote_notif_ack, handle_notification):
8003         Likewise.
8004         * remote.c (remote_notif_stop_parse): Make "buf" const.
8005         (remote_target::remote_parse_stop_reply): Make "buf" const.
8006         (remote_notif_stop_ack): Make "buf" const.
8007
8008 2019-01-14  Tom Tromey  <tom@tromey.com>
8009
8010         * remote.c (remote_console_output): Make parameter const.
8011
8012 2019-01-14  Tom Tromey  <tom@tromey.com>
8013
8014         * target-debug.h (target_debug_print_signals): Constify.
8015         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8016         * procfs.c (procfs_target::pass_signals): Update.
8017         * linux-nat.c (linux_nat_target::pass_signals): Update.
8018         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8019         * target-delegates.c: Rebuild.
8020         * remote.c (remote_target::program_signals): Update.
8021         (remote_target::pass_signals): Update.
8022         * target.c (target_pass_signals): Constify argument.
8023         (target_program_signals): Likewise.
8024         * target.h (struct target_ops) <pass_signals, program_signals>:
8025         Constify argument.
8026         (target_pass_signals, target_program_signals): Constify argument.
8027
8028 2019-01-14  Tom Tromey  <tom@tromey.com>
8029
8030         PR tui/28819:
8031         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8032
8033 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8034
8035         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8036         field.
8037         * rs6000-tdep.c: Include reggroups.h.
8038         (IS_V_ALIAS_PSEUDOREG): Define.
8039         (rs6000_register_name): Return names for the "vX" aliases.
8040         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8041         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8042         aliases.  Call default_register_reggroup_p for all other
8043         pseudo-registers.
8044         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8045         New functions.
8046         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8047         Handle "vX" aliases.
8048         (v_alias_pseudo_register_collect): New function.
8049         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8050         (rs6000_gdbarch_init): Initialize "vX" aliases as
8051         pseudo-registers.  Restore registration of
8052         rs6000_pseudo_register_reggroup_p with
8053         set_tdesc_pseudo_register_reggroup_p.
8054
8055 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8056
8057         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8058         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8059         set_gdbarch_num_pseudo_regs.
8060
8061 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8062
8063         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8064         Remove arg prefixname, add do_set and do_show.
8065         Add member functions set_list and show_list.
8066         * cli/cli-style.c (class cli_style_option): Update accordingly.
8067         (style_set_list): Move to file scope.
8068         (style_show_list): Likewise.
8069         (set_style): Call help_list.
8070         (show_style): Call cmd_show_list.
8071         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8072         Update to use the new macro.
8073
8074 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8075
8076         * ada-lang.c (_initialize_ada_language): Expand the help text
8077         for the "catch exception" command.
8078
8079 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8080
8081         * symtab.c (matching_obj_sections): Initialize obj,
8082         declare it closer to its usage.
8083
8084 2019-01-10  Tom Tromey  <tom@tromey.com>
8085
8086         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8087         (basic_inf_threads_range): Remove.
8088         (inf_threads_range, inf_non_exited_threads_range)
8089         (safe_inf_threads_range): Use next_adapter.
8090
8091 2019-01-10  Keith Seitz  <keiths@redhat.com>
8092
8093         PR gdb/23712
8094         PR symtab/23010
8095         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8096         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8097
8098 2019-01-10  Keith Seitz  <keiths@redhat.com>
8099
8100         PR gdb/23712
8101         PR symtab/23010
8102         * dictionary.c (pending_to_vector): Remove.
8103         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8104         Remove _1 suffix, replacing functions of the same name.  Update
8105         all callers.
8106         (dict_create_hashed, dict_create_hashed_expandable)
8107         (dict_create_linear, dict_create_linear_expandable, dict_free)
8108         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8109         Make functions static.
8110
8111 2019-01-10  Keith Seitz  <keiths@redhat.com>
8112
8113         PR gdb/23712
8114         PR symtab/23010
8115         * dictionary.h (struct dictionary): Replace declaration with
8116         multidictionary.
8117         (dict_create_hashed, dict_create_hashed_expandable)
8118         (dict_create_linear, dict_create_linear_expandable)
8119         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8120         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8121         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8122         taking multidictionary argument.
8123         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8124         * block.h (struct block) <dict>: Change to multidictionary
8125         and rename `multidict'.
8126         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8127         symmisc.c: Update all dictionary references to multidictionary.
8128
8129 2019-01-10  Keith Seitz  <keiths@redhat.com>
8130
8131         PR gdb/23712
8132         PR symtab/23010
8133         * dictionary.c: Include unordered_map.
8134         (pending_to_vector): New function.
8135         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8136         Rewrite the non-"_1" functions to take vector instead
8137         of linked list.
8138         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8139         "new" _1 versions of the same name.
8140         (multidictionary): Define.
8141         (std::hash<enum language): New definition.
8142         (collate_pending_symbols_by_language, mdict_create_hashed)
8143         (mdict_create_hashed_expandable, mdict_create_linear)
8144         (mdict_create_linear_expandable, mdict_free)
8145         (find_language_dictionary, create_new_language_dictionary)
8146         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8147         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8148         (mdict_size, mdict_empty): New functions.
8149         * dictionary.h (mdict_iterator): Define.
8150
8151 2019-01-10  Pedro Alves  <palves@redhat.com>
8152
8153         * breakpoint.c (read_uploaded_action)
8154         (create_tracepoint_from_upload): Adjust to use
8155         gdb::unique_xmalloc_ptr.
8156         * ctf.c (ctf_write_uploaded_tp):
8157         (SET_ARRAY_FIELD): Use emplace_back.
8158         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8159         * tracefile-tfile.c (tfile_write_uploaded_tp):
8160         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8161         gdb::unique_xmalloc_ptr.
8162         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8163         at_string, cond_string, cmd_strings>: Replace char pointers
8164         with gdb::unique_xmalloc_ptr.
8165
8166 2019-01-10  Pedro Alves  <palves@redhat.com>
8167
8168         * solib-target.c (library_list_start_library): Don't xstrdup name.
8169
8170 2019-01-10  Pedro Alves  <palves@redhat.com>
8171
8172         * mdebugread.c (parse_partial_symbols): Use
8173         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8174
8175 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8176
8177         * linux-fork.c (scoped_switch_fork_info)
8178         <~scoped_switch_fork_info>: Fix incorrect variable name.
8179
8180 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8181
8182         * linux-fork.c (scoped_switch_fork_info)
8183         <scoped_switch_fork_info>: Make explicit.
8184         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8185
8186 2019-01-10  Tom Tromey  <tom@tromey.com>
8187
8188         * objfiles.h (objfile::reset_psymtabs): Update.
8189         * objfiles.c (objfile::objfile): Update.
8190         * psymtab.h (psymtab_storage::obstack): Update.
8191         (psymtab_storage::m_obstack): Use gdb::optional.
8192         (class psymtab_storage): Update comment.  Remove objfile
8193         parameter.
8194         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8195
8196 2019-01-10  Tom Tromey  <tom@tromey.com>
8197
8198         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8199         <free_psymtabs>: Now private.
8200         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8201         (allocate_psymtab): Use new method.
8202
8203 2019-01-10  Tom Tromey  <tom@tromey.com>
8204
8205         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8206         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8207         * mdebugread.c (parse_partial_symbols): Use
8208         allocate_dependencies.
8209         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8210         allocate_dependencies.
8211         (process_psymtab_comp_unit_reader)
8212         (build_type_psymtab_dependencies): Likewise.
8213         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8214
8215 2019-01-10  Tom Tromey  <tom@tromey.com>
8216
8217         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8218         PSYMBOL_SET_LANGUAGE.
8219         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8220
8221 2019-01-10  Tom Tromey  <tom@tromey.com>
8222
8223         * psymtab.h (psymtab_storage::obstack): New method.
8224         <m_obstack>: Rename from obstack; now private.
8225         * psymtab.c (psymtab_storage): Update.
8226         * dwarf2read.c (create_addrmap_from_index)
8227         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8228         Update.
8229
8230 2019-01-10  Tom Tromey  <tom@tromey.com>
8231
8232         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8233         * objfiles.h (objfile::reset_psymtabs): New method.
8234
8235 2019-01-10  Tom Tromey  <tom@tromey.com>
8236
8237         * symmisc.c (print_symbol_bcache_statistics): Update.
8238         (print_objfile_statistics): Update.
8239         * symfile.c (reread_symbols): Update.
8240         * psymtab.h (class psymtab_storage): New.
8241         * psymtab.c (psymtab_storage): New constructor.
8242         (~psymtab_storage): New destructor.
8243         (require_partial_symbols): Update.
8244         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8245         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8246         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8247         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8248         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8249         (start_psymtab_common, end_psymtab_common)
8250         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8251         (allocate_psymtab): Update.
8252         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8253         Update.
8254         (dump_psymtab_addrmap, maintenance_print_psymbols)
8255         (maintenance_check_psymtabs): Update.
8256         (class objfile_psymtabs): Move to objfiles.h.
8257         * psympriv.h (discard_psymtab): Now inline.
8258         (psymtab_discarder::psymtab_discarder): Update.
8259         (psymtab_discarder::~psymtab_discarder): Update.
8260         (ALL_OBJFILE_PSYMTABS): Rewrite.
8261         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8262         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8263         Remove fields.
8264         <partial_symtabs>: New field.
8265         (class objfile_psymtabs): Move from psymtab.h.  Update.
8266         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8267         psymbol_cache.
8268         (objfile::~objfile): Don't destroy psymbol_cache.
8269         * mdebugread.c (parse_partial_symbols): Update.
8270         * dwarf2read.c (create_addrmap_from_index)
8271         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8272         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8273         (add_partial_subprogram, dwarf2_ranges_read): Update.
8274         * dwarf-index-write.c (write_address_map)
8275         (write_one_signatured_type, recursively_write_psymbols)
8276         (class debug_names, class debug_names, write_psymtabs_to_index):
8277         Update.
8278
8279 2019-01-10  Tom Tromey  <tom@tromey.com>
8280
8281         * symtab.h (SYMBOL_SET_NAMES): Update.
8282         (symbol_set_names): Update.
8283         (MSYMBOL_SET_NAMES): Update.
8284         * symtab.c (symbol_set_names): Change argument to be an
8285         objfile_per_bfd_storage.
8286         * psymtab.c (add_psymbol_to_bcache): Update.
8287         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8288
8289 2019-01-10  Tom Tromey  <tom@tromey.com>
8290
8291         * symtab.c (create_demangled_names_hash): Change argument to be an
8292         objfile_per_bfd_storage.
8293         (symbol_set_names): Update.
8294
8295 2019-01-10  Tom Tromey  <tom@tromey.com>
8296
8297         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8298         init_psymbol_list.
8299         * psymtab.c (init_psymbol_list): Do nothing if already called.
8300         * psympriv.h (init_psymbol_list): Add comment.
8301         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8302         init_psymbol_list.
8303         * dbxread.c (dbx_symfile_read): Unconditionally call
8304         init_psymbol_list.
8305
8306 2019-01-10  Tom Tromey  <tom@tromey.com>
8307
8308         * xcoffread.c (scan_xcoff_symtab): Update.
8309         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8310         "where".
8311         * mdebugread.c (parse_partial_symbols)
8312         (handle_psymbol_enumerators): Update.
8313         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8314         * dbxread.c (read_dbx_symtab): Update.
8315         * psympriv.h (psymbol_placement): New enum.
8316         (add_psymbol_to_list): Update.
8317
8318 2019-01-10  Tom Tromey  <tom@tromey.com>
8319
8320         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8321         static_psymbols parameters.
8322         (scan_xcoff_symtab): Update.
8323         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8324         static_psymbols parameters.
8325         * psympriv.h (start_psymtab_common): Update.
8326         * mdebugread.c (parse_partial_symbols): Update.
8327         * dwarf2read.c (create_partial_symtab): Update.
8328         * dbxread.c (read_dbx_symtab): Update.
8329         (start_psymtab): Remove global_psymbols and static_psymbols
8330         parameters.
8331
8332 2019-01-10  Tom Tromey  <tom@tromey.com>
8333
8334         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8335         * psymtab.c (allocate_psymtab): Add comment.
8336         * psympriv.h (allocate_psymtab): Add comment.
8337         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8338         initializations.
8339         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8340
8341 2019-01-10  Tom Tromey  <tom@tromey.com>
8342
8343         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8344         Don't declare.
8345         * mipsread.c: Include mdebugread.h.
8346         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8347         Declare.
8348         * elfread.c: Include mdebugread.h.
8349
8350 2019-01-09  Tom Tromey  <tom@tromey.com>
8351
8352         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8353         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8354         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8355         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8356         (psym_lookup_symbol, psym_find_last_source_symtab)
8357         (psym_forget_cached_source_info, psym_print_stats)
8358         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8359         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8360         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8361         (psym_find_compunit_symtab_by_address)
8362         (maintenance_print_psymbols, maintenance_info_psymtabs)
8363         (maintenance_check_psymtabs): Use ranged for.
8364         * psymtab.h (class objfile_psymtabs): New.
8365         (require_partial_symbols): Return objfile_psymtabs.
8366         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8367
8368 2019-01-09  Tom Tromey  <tom@tromey.com>
8369
8370         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8371         (find_pc_mapped_section, list_overlays_command)
8372         (map_overlay_command, unmap_overlay_command)
8373         (simple_overlay_update): Use all_objfiles.
8374         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8375         * printcmd.c (info_symbol_command): Use all_objfiles.
8376         * objfiles.h (ALL_OBJSECTIONS): Remove.
8377         * maint.c (maintenance_translate_address): Use all_objfiles.
8378         * gcore.c (gcore_create_callback): Use all_objfiles.
8379         (objfile_find_memory_regions): Likewise.
8380
8381 2019-01-09  Tom Tromey  <tom@tromey.com>
8382
8383         * symtab.c (find_line_symtab, info_sources_command)
8384         (make_source_files_completion_list): Use objfile_compunits.
8385         * source.c (select_source_symtab): Use objfile_compunits.
8386         * objfiles.h (struct objfile): Update comment.
8387         (ALL_OBJFILES): Remove.
8388         (ALL_FILETABS): Remove.
8389         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8390         objfile_compunits.
8391
8392 2019-01-09  Tom Tromey  <tom@tromey.com>
8393
8394         * symmisc.c (print_objfile_statistics, dump_objfile)
8395         (maintenance_print_symbols): Use compunit_filetabs.
8396         * source.c (forget_cached_source_info_for_objfile): Use
8397         compunit_filetabs.
8398         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8399         (ALL_FILETABS): Use compunit_filetabs.
8400         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8401         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8402
8403 2019-01-09  Tom Tromey  <tom@tromey.com>
8404
8405         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8406         (compunit_filetabs): New.
8407         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8408         compunit_filetabs.
8409         (info_sources_command, make_source_files_completion_list): Remove
8410         declaration.
8411         * symmisc.c (print_objfile_statistics, dump_objfile)
8412         (maintenance_print_symbols): Remove declaration.
8413         (maintenance_info_symtabs): Use compunit_filetabs.
8414         (maintenance_info_line_tables): Likewise.
8415         * source.c (select_source_symtab): Change local variable name.
8416         (forget_cached_source_info_for_objfile): Remove declaration.
8417         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8418         * objfiles.c (objfile_relocate1): Remove declaration.
8419         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8420         declaration.
8421         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8422         * coffread.c (coff_symtab_read): Remove declaration.
8423         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8424         compunit_filetabs.
8425
8426 2019-01-09  Tom Tromey  <tom@tromey.com>
8427
8428         * symtab.c (lookup_objfile_from_block)
8429         (find_pc_sect_compunit_symtab, search_symbols)
8430         (default_collect_symbol_completion_matches_break_on): Use
8431         objfile_compunits.
8432         * objfiles.h (ALL_COMPUNITS): Remove.
8433         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8434         * cp-support.c (add_symbol_overload_list_qualified): Use
8435         objfile_compunits.
8436         * ada-lang.c (ada_collect_symbol_completion_matches)
8437         (ada_add_global_exceptions): Use objfile_compunits.
8438
8439 2019-01-09  Tom Tromey  <tom@tromey.com>
8440
8441         * source.c (select_source_symtab)
8442         (forget_cached_source_info_for_objfile): Remove declaration.
8443         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8444         declaration.
8445         * maint.c (count_symtabs_and_blocks): Remove declaration.
8446         * cp-support.c (add_symbol_overload_list_qualified): Remove
8447         declaration.
8448         * coffread.c (coff_symtab_read): Remove declaration.
8449         * symtab.c (lookup_symbol_in_objfile_symtabs)
8450         (basic_lookup_transparent_type_1): Use objfile_compunits.
8451         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8452         (info_sources_command, search_symbols)
8453         (default_collect_symbol_completion_matches_break_on)
8454         (make_source_files_completion_list): Remove declaration.
8455         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8456         (ada_collect_symbol_completion_matches)
8457         (ada_add_global_exceptions): Remove declaration.
8458         * linespec.c (iterate_over_all_matching_symtabs): Use
8459         objfile_compunits.
8460         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8461         (class objfile_compunits): New.
8462         (ALL_COMPUNITS): Use objfile_compunits.
8463         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8464         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8465         objfile_compunits.
8466         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8467
8468 2019-01-09  Tom Tromey  <tom@tromey.com>
8469
8470         * symtab.c (search_symbols)
8471         (default_collect_symbol_completion_matches_break_on): Use
8472         objfile_msymbols.
8473         * ada-lang.c (ada_lookup_simple_minsym)
8474         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8475         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8476         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8477         objfile_msymbols.
8478         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8479         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8480         * objc-lang.c (find_methods): Use objfile_msymbols.
8481         (info_selectors_command, info_classes_command): Likewise.
8482         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8483         * objfiles.h (class objfile_msymbols): New.
8484         (ALL_OBJFILE_MSYMBOLS): Remove.
8485         (ALL_MSYMBOLS): Remove.
8486
8487 2019-01-09  Tom Tromey  <tom@tromey.com>
8488
8489         * common/next-iterator.h (next_adapter): Add Iterator template
8490         parameter.
8491         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8492         (class all_objfiles_safe): New.
8493         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8494         * objfiles.c (put_objfile_before): Update comment.
8495         (add_separate_debug_objfile): Likewise.
8496         (free_all_objfiles): Use all_objfiles_safe.
8497         (objfile_purge_solibs): Likewise.
8498
8499 2019-01-09  Tom Tromey  <tom@tromey.com>
8500
8501         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8502         (expand_symtab_containing_pc, lookup_static_symbol)
8503         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8504         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8505         all_objfiles.
8506         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8507         * breakpoint.c (create_overlay_event_breakpoint)
8508         (create_longjmp_master_breakpoint)
8509         (create_std_terminate_master_breakpoint)
8510         (create_exception_master_breakpoint): Use all_objfiles.
8511         * linux-thread-db.c (try_thread_db_load_from_pdir)
8512         (has_libpthread): Use all_objfiles.
8513         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8514         * linespec.c (iterate_over_all_matching_symtabs)
8515         (search_minsyms_for_name): Use all_objfiles.
8516         * maint.c (maintenance_info_sections): Use all_objfiles.
8517         * main.c (captured_main_1): Use all_objfiles.
8518         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8519         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8520         * guile/scm-pretty-print.c
8521         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8522         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8523         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8524         (maintenance_print_msymbols): Use all_objfiles.
8525         * source.c (select_source_symtab): Use all_objfiles.
8526         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8527         * symfile.c (remove_symbol_file_command)
8528         (expand_symtabs_matching, map_symbol_filenames): Use
8529         all_objfiles.
8530         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8531         all_objfiles.
8532         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8533         * objc-lang.c (find_methods): Use all_objfiles.
8534         * objfiles.c (have_partial_symbols, have_full_symbols)
8535         (have_minimal_symbols, qsort_cmp)
8536         (default_iterate_over_objfiles_in_search_order): Use
8537         all_objfiles.
8538         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8539         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8540         (maintenance_check_psymtabs): Use all_objfiles.
8541         (ALL_PSYMTABS): Remove.
8542         * compile/compile-object-run.c (do_module_cleanup): Use
8543         all_objfiles.
8544         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8545         * cp-support.c (add_symbol_overload_list_qualified): Use
8546         all_objfiles.
8547         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8548         Use all_objfiles.
8549         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8550         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8551         all_objfiles.
8552         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8553         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8554         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8555         Uses all_objfiles.
8556         * solib.c (solib_read_symbols): Use all_objfiles
8557
8558 2019-01-09  Tom Tromey  <tom@tromey.com>
8559
8560         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8561         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8562         all_objfiles.
8563         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8564         * symmisc.c (print_symbol_bcache_statistics)
8565         (print_objfile_statistics, maintenance_print_objfiles)
8566         (maintenance_info_symtabs, maintenance_check_symtabs)
8567         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8568         all_objfiles.
8569         * source.c (forget_cached_source_info): Use all_objfiles.
8570         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8571         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8572         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8573         * objfiles.c (update_section_map): Use all_objfiles.
8574         (shared_objfile_contains_address_p): Likewise.
8575         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8576         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8577
8578 2019-01-09  Tom Tromey  <tom@tromey.com>
8579
8580         * common/next-iterator.h: New file.
8581         * objfiles.h (class all_objfiles): New.
8582         (struct objfile_iterator): New.
8583
8584 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8585
8586         * NEWS: Move the description of the changed "frame", "select-frame",
8587          and "info frame" commands to the Changed commands section.
8588
8589 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8590
8591         * gdbtypes.c (check_stub_method_group): Remove handling of old
8592         mangling schemes.
8593         * linespec.c (find_methods): Likewise.
8594         * stabsread.c (read_member_functions): Likewise.
8595         * valops.c (search_struct_method): Likewise.
8596         (value_struct_elt_for_reference): Likewise.
8597         * NEWS: Mention this change.
8598
8599 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8600
8601         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8602         print_source_lines.
8603         * source.c (print_source_lines_base): Update line number check.
8604         (print_source_lines): New function.
8605         (source_lines_range::source_lines_range): New function.
8606         * source.h (class source_lines_range): New class.
8607         (print_source_lines): New declaration.
8608
8609 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8610
8611         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8612
8613 2019-01-08  Tom Tromey  <tom@tromey.com>
8614             Simon Marchi  <simon.marchi@ericsson.com>
8615
8616         PR gdb/24060
8617         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8618         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8619         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8620         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8621         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8622         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8623
8624 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8625
8626         * source.c (select_source_symtab): Move header comment to
8627         declaration in source.h.
8628         (forget_cached_source_info_for_objfile): Likewise.
8629         (forget_cached_source_info): Likewise.
8630         (identify_source_line): Likewise.
8631         * source.h (identify_source_line): Move declaration from symtab.h
8632         and add comment from source.c
8633         (print_source_lines): Likewise.
8634         (forget_cached_source_info_for_objfile): Likewise.
8635         (forget_cached_source_info): Likewise.
8636         (select_source_symtab): Likewise.
8637         (enum print_source_lines_flag): Move definition from symtab.h.
8638         * symtab.h (identify_source_line): Move declaration to source.h.
8639         (print_source_lines): Likewise.
8640         (forget_cached_source_info_for_objfile): Likewise.
8641         (forget_cached_source_info): Likewise.
8642         (select_source_symtab): Likewise.
8643         (enum print_source_lines_flag): Move definition to source.h.
8644         * tui/tui-hooks.c: Add 'source.h' include.
8645
8646 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8647
8648         * source.c (print_source_lines_base): Handle requests to print
8649         reverse line number sequences, and guard against empty lines
8650         string.
8651
8652 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8653
8654         * source.c (print_source_lines_base): Fix skip of '\r' if next
8655         character is '\n'.
8656
8657 2019-01-06  Tom Tromey  <tom@tromey.com>
8658
8659         * c-exp.y (struct c_parse_state) <macro_original_text,
8660         expansion_obstack>: New member.
8661         (macro_original_text, expansion_obstack): Remove globals.
8662         (scan_macro_expansion, scanning_macro_expansion)
8663         (finished_macro_expansion): Update.
8664         (scan_macro_cleanup): Remove.
8665         (yylex, c_parse): Update.
8666
8667 2019-01-06  Tom Tromey  <tom@tromey.com>
8668
8669         * c-exp.y (struct c_parse_state) <strings>: New member.
8670         (operator_stoken): Update.
8671
8672 2019-01-06  Tom Tromey  <tom@tromey.com>
8673
8674         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8675         (union type_stack_elt) <typelist_val>: Now a pointer to
8676         std::vector.
8677         (type_stack_cleanup): Don't declare.
8678         (push_typelist): Update.
8679         * parse.c (pop_typelist): Return a std::vector.
8680         (push_typelist): Take a std::vector.
8681         (follow_types): Update.  Do not free args.
8682         (type_stack_cleanup): Remove.
8683         * c-exp.y (struct c_parse_state): New.
8684         (cpstate): New global.
8685         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8686         (nonempty_typelist): Update.
8687         (func_mod): Create a new vector.
8688         (c_parse): Create a c_parse_state.
8689         (check_parameter_typelist): Do not delete params.
8690         (function_method): Update.  Do not delete type_list.
8691
8692 2019-01-06  Tom Tromey  <tom@tromey.com>
8693
8694         PR gdb/28155:
8695         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8696         check_typedef.
8697         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8698         (print_return_value): Likewise.
8699
8700 2019-01-05  Tom Tromey  <tom@tromey.com>
8701
8702         * contrib/cleanup_check.py: Remove.
8703         * contrib/gcc-with-excheck: Remove.
8704         * contrib/exsummary.py: Remove.
8705         * contrib/excheck.py: Remove.
8706
8707 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8708
8709         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8710         NULL. Initialize tpprev to NULL instead of assigning it
8711         to NULL on the next statement.
8712         * windows-nat.c (windows_delete_thread): Remove check for
8713         main_thread_id before printing thread exit notifications.
8714         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8715         Remove thread ID check against main_thread_id.
8716         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8717         windows_delete_thread.
8718         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8719
8720 2019-01-04  Tom Tromey  <tom@tromey.com>
8721
8722         * compile/compile.c (_initialize_compile): Use upper case for
8723         metasyntactic variables.
8724         * symmisc.c (_initialize_symmisc): Use upper case for
8725         metasyntactic variables.
8726         * psymtab.c (_initialize_psymtab): Use upper case for
8727         metasyntactic variables.
8728         * demangle.c (demangle_command): Use upper case for metasyntactic
8729         variables.
8730         (_initialize_demangler): Likewise.
8731         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8732         variables.
8733
8734 2019-01-03  Tom Tromey  <tom@tromey.com>
8735
8736         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8737
8738 2019-01-03  Tom Tromey  <tom@tromey.com>
8739
8740         * python/py-symtab.c (salpy_str): Update.
8741         (struct salpy_sal_object) <symtab>: Now a PyObject.
8742         (salpy_dealloc): Update.
8743         (del_objfile_sal): Use gdbpy_ref.
8744
8745 2019-01-03  Tom Tromey  <tom@tromey.com>
8746
8747         * python/py-type.c (convert_field): Use new_reference.  Return
8748         gdbpy_ref.
8749         (make_fielditem): Return gdbpy_ref.
8750         (typy_fields): Update.
8751         (typy_getitem): Update.
8752         (field_name): Return gdbpy_ref.  Use new_reference.
8753         (typy_iterator_iternext): Update.
8754
8755 2019-01-03  Tom Tromey  <tom@tromey.com>
8756
8757         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8758
8759 2019-01-03  Tom Tromey  <tom@tromey.com>
8760
8761         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8762         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8763         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8764         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8765         (pspy_set_type_printers): Likewise.
8766         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8767         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8768         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8769         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8770         (objfpy_set_type_printers): Likewise.
8771
8772 2019-01-03  Tom Tromey  <tom@tromey.com>
8773
8774         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8775         (gdbpy_print_stack): Use gdbpy_err_fetch.
8776         * python/python-internal.h (class gdbpy_err_fetch): New class.
8777         (class gdbpy_enter) <m_error_type, m_error_value,
8778         m_error_traceback>: Remove.
8779         <m_error>: New member.
8780         (gdbpy_exception_to_string): Don't declare.
8781         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8782         * python/py-value.c (convert_value_from_python): Use
8783         gdbpy_err_fetch.
8784         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8785         gdbpy_exception_to_string.
8786         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8787         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8788         gdbpy_err_fetch.
8789
8790 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8791
8792         * linux-nat.c (delete_lwp_cleanup): Delete.
8793         (struct lwp_deleter): New struct.
8794         (lwp_info_up): New typedef.
8795         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8796         lwp_info_up.
8797
8798 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8799
8800         * linux-fork.c (class scoped_switch_fork_info): New class.
8801         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8802
8803 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8804
8805         * valops.c (find_overload_match): Remove use of null_cleanup, and
8806         calls to do_cleanups.
8807
8808 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8809
8810         * compile/compile-cplus-types.c
8811         (compile_cplus_instance::decl_name): Handle changes to
8812         cp_func_name.
8813         * cp-support.c (cp_func_name): Update header comment, update
8814         return type.
8815         * cp-support.h (cp_func_name): Update return type in declaration.
8816         * valops.c (find_overload_match): Move temp_func local to top
8817         level of function and change its type.  Use temp_func to hold and
8818         delete temporary string obtained from cp_func_name.
8819
8820 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8821
8822         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8823         gdb::char_vector, remove cleanup, and update uses of `msg`.
8824
8825 2019-01-03  Jim Wilson  <jimw@sifive.com>
8826
8827         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8828
8829 2019-01-02  Tom Tromey  <tom@tromey.com>
8830
8831         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8832         (tdesc_parse_xml): Remove cleanups.
8833         * target-descriptions.h (make_cleanup_free_target_description):
8834         Don't declare.
8835         (target_desc_deleter): New struct.
8836         (target_desc_up): New typedef.
8837         * target-descriptions.c (target_desc_deleter::operator()): Rename
8838         from free_target_description.
8839         (make_cleanup_free_target_description): Remove.
8840
8841 2019-01-02  Tom Tromey  <tom@tromey.com>
8842
8843         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8844         constructor, destructor.
8845         (linespec_parser): Remove typedef.
8846         (~linespec_parser): Rename from linespec_parser_delete.
8847         (linespec_lex_to_end, linespec_complete_label)
8848         (linespec_complete): Update.
8849         (decode_line_full): Remove cleanups.
8850         (decode_line_1): Update.
8851
8852 2019-01-02  Tom Tromey  <tom@tromey.com>
8853
8854         * python/python-internal.h (inferior_to_inferior_object): Change
8855         return type.
8856         * python/py-exitedevent.c (create_exited_event_object): Update.
8857         * python/py-inferior.c (inferior_to_inferior_object): Return
8858         gdbpy_ref.
8859         (python_new_inferior, python_inferior_deleted)
8860         (thread_to_thread_object, delete_thread_object)
8861         (build_inferior_list, gdbpy_selected_inferior): Update.
8862         * python/py-infthread.c (create_thread_object): Update.  Also fail
8863         if inferior_to_inferior_object fails.
8864
8865 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8866
8867         * inferior.h (class inferior) <displaced_step_state>: New field.
8868         * infrun.h (struct displaced_step_state): Move here from
8869         infrun.c.  Initialize fields, add constructor.
8870         <inf>: Remove field.
8871         <reset>: New method.
8872         * infrun.c (struct displaced_step_inferior_state): Move to
8873         infrun.h.
8874         (displaced_step_inferior_states): Remove.
8875         (get_displaced_stepping_state): Adust.
8876         (displaced_step_in_progress_any_inferior): Adjust.
8877         (displaced_step_in_progress_thread): Adjust.
8878         (displaced_step_in_progress): Adjust.
8879         (add_displaced_stepping_state): Remove.
8880         (get_displaced_step_closure_by_addr): Adjust.
8881         (remove_displaced_stepping_state): Remove.
8882         (infrun_inferior_exit): Call displaced_step_state.reset.
8883         (use_displaced_stepping): Don't check for NULL.
8884         (displaced_step_prepare_throw): Call
8885         get_displaced_stepping_state.
8886         (displaced_step_fixup): Don't check for NULL.
8887         (prepare_for_detach): Don't check for NULL.
8888
8889 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8890
8891         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8892          in case of call that did not complete.
8893
8894 2019-01-02  Andrey Utkin  <autkin@undo.io>
8895
8896         * symfile.c (find_separate_debug_file): Fix search of debug files for
8897         remote debuggee.
8898
8899 2019-01-02  Tom Tromey  <tom@tromey.com>
8900
8901         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8902         indentation.
8903         * python/py-frame.c (frapy_older): Remove cast.
8904         (frapy_newer): Likewise.
8905         * python/py-breakpoint.c (local_setattro): Remove cast.
8906         * python/py-arch.c (archpy_name): Remove local variable.
8907         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8908
8909 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8910
8911         * unittests/basic_string_view/element_access/char/empty.cc:
8912         Fix year range in copyright header.
8913
8914 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8915
8916         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8917         Delete.
8918         <operator==>: Update with for removed field.
8919         <hash>: Likewise.
8920         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8921         <isa_features>: ...this.
8922         <abi_features>: New field.
8923         (riscv_isa_flen): Update comment.
8924         (riscv_abi_xlen): New declaration.
8925         (riscv_abi_flen): New declaration.
8926         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8927         isa_features.
8928         (riscv_abi_xlen): New function.
8929         (riscv_isa_flen): Update to get answer from isa_features.
8930         (riscv_abi_flen): New function.
8931         (riscv_has_fp_abi): Update to get answer from abi_features.
8932         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8933         xlen and flen.
8934         (riscv_call_info) <xlen, flen>: Update comment.
8935         (riscv_call_arg_struct): Remove invalid assertions
8936         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8937         is removed.
8938         (riscv_gdbarch_init): Gather isa features and abi features
8939         separately, ensure both match on the gdbarch when reusing an old
8940         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8941         a target with 64-bit float hardware.
8942
8943 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8944
8945         * source.c (search_command_helper): Stop reverse search
8946         when line 1 has been searched.
8947
8948 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8949
8950         * record-full.c (record_full_base_target::close): Rewrite
8951         record_full_core_buf_list free logic.
8952
8953 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8954
8955         * break-catch-syscall.c (print_one_catch_syscall): xfree
8956         the last text.
8957
8958 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8959
8960         * top.c (print_gdb_version): Update Copyright year in version
8961         message.
8962
8963 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8964
8965         Update copyright year range in all GDB files.
8966
8967 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8968
8969         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8970
8971 For older changes see ChangeLog-2018.
8972 \f
8973 Local Variables:
8974 mode: change-log
8975 left-margin: 8
8976 fill-column: 74
8977 version-control: never
8978 coding: utf-8
8979 End:
8980