gdb/rs6000: Use default gdbarch methods where possible
[external/binutils.git] / gdb / ChangeLog
1 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2
3         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4         (rs6000_dummy_id): Delete.
5         (rs6000_gdbarch_init): Don't register deleted functions with
6         gdbarch.
7
8 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9
10         * or1k-tdep.c (or1k_dummy_id): Delete.
11         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
12
13 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
14
15         * nios2-tdep.c (nios2_dummy_id): Delete.
16         (nios2_unwind_sp): Delete.
17         (nios2_gdbarch_init): Don't register deleted functions with
18         gdbarch.
19
20 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
21
22         * nds32-tdep.c (nds32_dummy_id): Delete.
23         (nds32_unwind_pc): Delete.
24         (nds32_unwind_sp): Delete.
25         (nds32_gdbarch_init): Don't register deleted functions with
26         gdbarch.
27
28 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
29
30         * msp430-tdep.c (msp430_unwind_pc): Delete.
31         (msp430_unwind_sp): Delete.
32         (msp430_dummy_id): Delete.
33         (msp430_gdbarch_init): Don't register deleted functions with
34         gdbarch.
35
36 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
37
38         * moxie-tdep.c (moxie_unwind_sp): Delete.
39         (moxie_unwind_pc): Delete.
40         (moxie_dummy_id): Delete.
41         (moxie_gdbarch_init): Don't register deleted functions with
42         gdbarch.
43
44 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
45
46         * mn10300-tdep.c (mn10300_dummy_id): Delete.
47         (mn10300_unwind_pc): Delete.
48         (mn10300_unwind_sp): Delete.
49         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
50         mn10300_unwind_sp.
51         (mn10300_frame_unwind_init): Don't register deleted functions with
52         gdbarch.
53
54 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
55
56         * mep-tdep.c (mep_unwind_pc): Delete.
57         (mep_unwind_sp): Delete.
58         (mep_dummy_id): Delete.
59         (mep_gdbarch_init): Don't register deleted functions with
60         gdbarch.
61
62 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
63
64         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
65         (m68hc11_unwind_sp): Delete.
66         (m68hc11_gdbarch_init): Don't register deleted functions with
67         gdbarch.
68
69 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
70
71         * m32r-tdep.c (m32r_unwind_sp): Delete.
72         (m32r_unwind_pc): Delete.
73         (m32r_dummy_id): Delete.
74         (m32r_gdbarch_init): Don't register deleted functions with
75         gdbarch.
76
77 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
78
79         * m32c-tdep.c (m32c_unwind_pc): Delete.
80         (m32c_unwind_sp): Delete.
81         (m32c_dummy_id): Delete.
82         (m32c_gdbarch_init): Don't register deleted functions with
83         gdbarch.
84
85 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
86
87         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
88         (lm32_unwind_pc): Delete.
89         (lm32_dummy_id): Delete.
90         (lm32_gdbarch_init): Don't register deleted functions with
91         gdbarch.
92
93 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
94
95         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
96         (iq2000_unwind_pc): Delete.
97         (iq2000_dummy_id): Delete.
98         (iq2000_gdbarch_init): Don't register deleted functions with
99         gdbarch.
100
101 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
102
103         * nds32-tdep.c (nds32_type_align): Delete.
104         (nds32_push_dummy_call): Use type_align instead.
105
106 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
107
108         * arm-tdep.c (arm_type_align): Only handle vector override case.
109         (arm_push_dummy_call): Use type_align.
110         (arm_gdbarch_init): Register arm_type_align gdbarch function.
111
112 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
113
114         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
115         case.
116         (pass_on_stack): Use type_align.
117         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
118         function.
119
120 2019-04-23  Tom Tromey  <tromey@adacore.com>
121
122         * dwarf2read.c (line_header::file_name_at): Remove unused
123         overload.
124
125 2019-04-23  Tom de Vries  <tdevries@suse.de>
126
127         PR gdb/24438
128         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
129         invocation.
130
131
132 2019-03-27  Ali Tamur  <tamur@google.com>
133
134         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
135         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
136         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
137         (dwarf_expr_context::get_addr_index): Likewise
138         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
139         (symbol_needs_eval_context::get_addr_index): Likewise
140         (disassemble_dwarf_expression): Add DW_OP_addrx
141         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
142         (read_cutu_die_from_dwo): Update comment
143         (skip_one_die): Add DW_FORM_addrx
144         (read_attribute_value): Likewise
145         (var_decode_location): Add DW_OP_addrx
146         (dwarf2_const_value_attr): Add DW_FORM_addrx
147         (dump_die_shallow): Likewise
148         (dwarf2_fetch_constant_bytes): Likewise
149         (decode_locdesc): Add DW_OP_addrx
150         (skip_form_bytes): Add DW_FORM_addrx
151
152 2019-04-22  Ali Tamur  <tamur@google.com>
153
154         * MAINTAINERS (Write After Approval): Add self.
155
156 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
157
158         * solib-svr4.c (get_svr4_info): Add pspace parameter.
159         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
160         (open_symbol_file_object): Likewise.
161         (svr4_default_sos): Add info parameter.
162         (svr4_read_so_list): Likewise.
163         (svr4_current_sos_direct): Adjust functions calls to pass down
164         info.
165         (svr4_current_sos_1): Add info parameter.
166         (svr4_current_sos): Call get_svr4_info, pass info down to
167         svr4_current_sos_1.
168         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
169         get_svr4_info.
170         (svr4_in_dynsym_resolve_code): Pass current_program_space to
171         get_svr4_info.
172         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
173         to get_svr4_info.
174         (probes_table_remove_objfile_probes): Likewise.
175         (register_solib_event_probe): Add info parameter.
176         (solist_update_incremental): Pass info parameter down to
177         svr4_read_so_list.
178         (disable_probes_interface): Add info parameter.
179         (svr4_handle_solib_event): Pass current_program_space to
180         get_svr4_info.  Adjust disable_probes_interface cleanup.
181         (svr4_create_probe_breakpoints): Add info parameter, pass it
182         down to register_solib_event_probe.
183         (svr4_create_solib_event_breakpoints): Add info parameter,
184         pass it down to svr4_create_probe_breakpoints.
185         (enable_break): Pass info down to
186         svr4_create_solib_event_breakpoints.
187         (svr4_solib_create_inferior_hook): Pass current_program_space to
188         get_svr4_info.
189         (svr4_clear_solib): Likewise.
190
191 2019-04-22  Pedro Alves  <palves@redhat.com>
192
193         * solib-svr4.c (svr4_free_objfile_observer): New.
194         (probe_and_action::objfile): New field.
195         (probes_table_htab_remove_objfile_probes)
196         (probes_table_remove_objfile_probes): New functions.
197         (register_solib_event_probe): Add 'objfile' parameter.  Store it
198         in the new probe_and_action.  Don't store the probe in 'lookup'.
199         (svr4_create_probe_breakpoints): Pass objfile to
200         register_solib_event_probe.
201         (_initialize_svr4_solib): Register a free_objfile observer.
202
203 2019-04-19  Tom Tromey  <tom@tromey.com>
204
205         * common/queue.h: Remove.
206
207 2019-04-19  Tom Tromey  <tom@tromey.com>
208
209         * event-loop.c: Don't include "common/queue.h".
210
211 2019-04-19  Tom Tromey  <tom@tromey.com>
212
213         * remote.c (remote_target): Use delete.
214         * remote-notif.h: Include <list>, not "common/queue.h".
215         (notif_client_p): Remove typedef.
216         (remote_notif_state): Add constructor, destructor, initializer.
217         <notif_queue>: Now a std::list.
218         (remote_notif_state_xfree): Don't declare.
219         * remote-notif.c (remote_notif_process, handle_notification)
220         (remote_notif_state_allocate): Update.
221         (~remote_notif_state): Rename from remote_notif_state_xfree.
222
223 2019-04-19  Tom Tromey  <tom@tromey.com>
224
225         * symfile.c (reread_symbols): Update.
226         * objfiles.c (objfile_register_static_link)
227         (objfile_lookup_static_link): Update
228         (~objfile) Don't delete static_links.
229         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
230
231 2019-04-19  Tom Tromey  <tom@tromey.com>
232
233         * type-stack.h (struct type_stack) <insert>: Constify string.
234         * type-stack.c (type_stack::insert): Constify string.
235         * gdbtypes.h (lookup_template_type): Update.
236         (address_space_name_to_int): Update.
237         * gdbtypes.c (address_space_name_to_int): Make space_identifier
238         const.
239         (lookup_template_type): Make name const.
240         * c-exp.y: Update rules.
241         (lex_one_token, classify_name, classify_inner_name)
242         (c_print_token): Update.
243         * p-exp.y: Update rules.
244         (yylex): Update.
245         * f-exp.y: Update rules.
246         (yylex): Update.
247         * d-exp.y: Update rules.
248         (lex_one_token, classify_name, classify_inner_name): Update.
249         * parse.c (write_dollar_variable, copy_name): Return std::string.
250         * parser-defs.h (copy_name): Change return type.
251         * m2-exp.y: Update rules.
252         (yylex): Update.
253         * go-exp.y (lex_one_token): Update.
254         Update rules.
255         (classify_unsafe_function, classify_packaged_name)
256         (classify_name, yylex): Update.
257
258 2019-04-19  Sergei Trofimovich <siarheit@google.com>
259
260         * configure.ac: add --enable-source-highlight switch.
261         * configure: Regenerate.
262         * top.c (print_gdb_version): plumb --enable-source-highlight
263         status to "show configuration".
264
265 2019-04-19  Tom Tromey  <tromey@adacore.com>
266
267         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
268         Check ADA_TYPE_P.
269         (empty_record, ada_template_to_fixed_record_type_1)
270         (template_to_static_fixed_type)
271         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
272         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
273         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
274         macros.
275
276 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
277
278         PR symtab/24423:
279         * source.c (print_source_lines_base): Advance "iter" when a
280         control character is seen.
281
282 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
283
284         * inferior.h (struct infcall_suspend_state_deleter):
285         Catch exception in destructor to avoid crash.
286
287 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
288
289         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
290         close to the add_com "shell".
291
292 2019-04-18  Tom Tromey  <tromey@adacore.com>
293
294         * process-stratum-target.h (class process_stratum_target)
295         <stratum>: Add "final".
296
297 2019-04-17  Tom Tromey  <tromey@adacore.com>
298
299         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
300         against nullptr before use.
301
302 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
303
304         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
305
306 2019-04-17  Jim Wilson  <jimw@sifive.com>
307             Andrew Burgess  <andrew.burgess@embecosm.com>
308
309         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
310         code read might fail, assume 4-byte breakpoint in that case.
311
312 2019-04-15  Leszek Swirski  <leszeks@google.com>
313
314         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
315         rather than a hand-rolled POD check when checking for forced MEMORY
316         classification.
317
318 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
319
320         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
321         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
322         function.
323         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
324         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
325         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
326         declaration.
327
328 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
329
330         * aarch64-linux-nat.c
331         (aarch64_linux_nat_target::thread_architecture): Add override.
332         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
333         each VQ.
334
335 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
336
337         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
338
339 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
340
341         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
342         target types of size 96-bits, add some additional comments, and
343         check that the builtin type we found was the correct size.
344
345 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
346
347         * utils.c (prompt_for_continue): Don't restore the styling at the
348         end, as applied_style has the wrong value.  This fixes styling in
349         long lists of file names that are interrupted by the "Continue?"
350         prompt.
351
352 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
353
354         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
355         * c-lang.c (c_language_defn): Likewise.
356         (cplus_language_defn): Likewise.
357         (asm_language_defn): Likewise.
358         (minimal_language_defn): Likewise.
359         * d-lang.c (d_language_defn): Likewise.
360         * f-lang.c (f_language_defn): Likewise.
361         * go-lang.c (go_language_defn): Likewise.
362         * language.c (unknown_language_defn): Likewise.
363         (auto_language_defn): Likewise.
364         * language.h (struct language_defn): Remove la_magic field.
365         (LANG_MAGIC): Delete.
366         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
367         * objc-lang.c (objc_language_defn): Likewise.
368         * opencl-lang.c (opencl_language_defn): Likewise.
369         * p-lang.c (pascal_language_defn): Likewise.
370         * rust-lang.c (rust_language_defn): Likewise.
371
372 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
373
374         * riscv-tdep.c (riscv_type_align): New function.
375         (riscv_type_alignment): Delete.
376         (riscv_arg_location): Use 'type_align'.
377         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
378
379 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
380
381         * gdbtypes.c (type_align): A struct with no non-static fields also
382         has alignment of 1.
383
384 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
385
386         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
387         component to 0.
388         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
389         member.
390         (riscv_struct_info::analyse): New implementation using new
391         analyse_inner member function.
392         (riscv_struct_info::field_offset): New member function.
393         (riscv_struct_info::m_offsets): New member variable.
394         (riscv_struct_info::analyse_inner): New private member function,
395         takes the old implementation of riscv_struct_info::analyse but
396         extended to track field offsets.
397         (riscv_call_arg_struct): Update the struct folding special cases
398         to handle cases where empty C++ structs, which are non-zero
399         length, are found.
400         (riscv_arg_location): Initialise the length of each location, a
401         non-zero length now indicates the location is in use.
402         (riscv_push_dummy_call): Allow for the first location having a
403         non-zero offset when setting up arguments.
404         (riscv_return_value): Likewise, but for return values.
405
406 2019-04-11  Tom Tromey  <tromey@adacore.com>
407
408         * utils.c (internal_vproblem): Make "msg" const.
409
410 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
411
412         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
413         * trad-frame.c (trad_frame_reset_saved_regs): New function.
414         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
415         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
416
417 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
418
419         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
420         function.
421         (fill_gregset): Call amd64_linux_collect_native_gregset instead
422         of amd64_collect_native_gregset.
423         (amd64_linux_nat_target::store_registers): Likewise.
424
425 2019-04-10  Tom Tromey  <tom@tromey.com>
426
427         * symtab.c (lookup_global_symbol_from_objfile)
428         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
429         * objfiles.h (class separate_debug_iterator): New.
430         (class separate_debug_range): New.
431         (struct objfile) <separate_debug_objfiles>: New method.
432         (objfile_separate_debug_iterate): Don't declare.
433         * objfiles.c (separate_debug_iterator::operator++): Rename from
434         objfile_separate_debug_iterate.
435         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
436         iterator.
437         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
438         iterator.
439
440 2019-04-10  Tom Tromey  <tom@tromey.com>
441
442         * symfile.c (reread_symbols): Remove old comment.
443         * objfiles.c (free_all_objfiles): Fix a typo.
444
445 2019-04-10  Tom Tromey  <tom@tromey.com>
446
447         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
448         * minsyms.c (lookup_minimal_symbol): Use foreach.
449         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
450         (lookup_minimal_symbol_solib_trampoline): Likewise.
451         * symfile.c (reread_symbols): Use foreach.
452
453 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
454             Tom Tromey  <tromey@adacore.com>
455
456         PR rust/24414:
457         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
458         (rust_lex_int_test): Change "value" to be LONGEST.
459         (rust_lex_tests): Add test for long integer literal.
460
461 2019-04-09  Tom Tromey  <tromey@adacore.com>
462
463         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
464         to bool.
465         (extended_remote_target::attach): Update.
466         (remote_target::remote_notice_new_inferior): Update.
467         (remote_target::add_current_inferior_and_thread): Update.
468         * inferior.c (exit_inferior_1): Use "false".
469         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
470
471 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
472
473         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
474         the "start" command.
475
476 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
477
478         * python/py-inferior.c (infpy_thread_from_thread_handle):
479         Adjust comments to reflect renaming of thread_from_thread_handle
480         to thread_from_handle.  Adjust keywords.  Fix type error message.
481         (inferior_object_methods): Add thread_from_handle.  Retain
482         thread_from_thread_handle, but mark it as deprecated.
483
484 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
485
486         * gdbthread.h (find_thread_by_handle): Revise declaration.
487         * thread.c (find_thread_by_handle): Likewise.  Adjust
488         implementation too.
489         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
490         support for buffer objects as handles.
491
492 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
493
494         * python/py-infthread.c (thpy_thread_handle): New function.
495         (thread_object_methods): Register thpy_thread_handle.
496
497 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
498
499         * gdbthread.h (thread_to_thread_handle): Declare.
500         * thread.c (gdbtypes.h): Include.
501         (thread_to_thread_handle): New function.
502
503         * target.h (struct target_ops): Add thread_info_to_thread_handle.
504         (target_thread_info_to_thread_handle): Declare.
505         * target.c (target_thread_info_to_thread_handle): New function.
506         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
507         * target-delegates.c: Regenerate.
508
509         * linux-thread-db.c (class thread_db_target): Add method
510         thread_info_to_thread_handle.
511         (thread_db_target::thread_info_to_thread_handle): Define.
512         * remote.c (class remote_target): Add new method
513         thread_info_to_thread_handle.
514         (remote_target::thread_info_to_thread_handle): Define.
515
516 2019-04-08  Pedro Alves  <palves@redhat.com>
517
518         * common/common-exceptions.c (throw_exception): Don't create
519         named object to throw; throw directly.
520         (throw_it): Likewise.  Don't initialize gdb_exception::message
521         here, with new; pass FMT and AP to the ctor instead.
522         * common/common-exceptions.h: Include <string>.
523         (gdb_exception::gdb_exception(enum return_reason, enum errors,
524         const char *, va_list)): New ctor.  Use std::make_shared.
525         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
526         errors)): Delete.
527         (gdb_exception_error::gdb_exception_error(enum errors, const char
528         *, va_list)): New.
529         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
530         Add assertion.
531         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
532         errors)): Delete.
533         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
534         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
535         Add assertion.
536
537 2019-04-08  Tom Tromey  <tom@tromey.com>
538
539         * valops.c (value_rtti_indirect_type): Replace throw_exception
540         with throw.
541         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
542         with throw.
543         * thread.c (thr_try_catch_cmd): Replace throw_exception with
544         throw.
545         * target.c (target_translate_tls_address): Replace throw_exception
546         with throw.
547         * stack.c (frame_apply_command_count): Replace throw_exception
548         with throw.
549         * solib-spu.c (append_ocl_sos): Replace throw_exception with
550         throw.
551         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
552         with throw.
553         * rs6000-tdep.c (rs6000_frame_cache)
554         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
555         * remote.c: Replace throw_exception with throw.
556         * record-full.c (record_full_message, record_full_wait_1)
557         (record_full_restore): Replace throw_exception with throw.
558         * record-btrace.c:
559         (get_thread_current_frame_id, record_btrace_start_replaying)
560         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
561         (cmd_record_btrace_start): Replace throw_exception with throw.
562         * parse.c (parse_exp_in_context_1): Replace throw_exception with
563         throw.
564         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
565         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
566         * linespec.c:
567         (find_linespec_symbols): Replace throw_exception with throw.
568         * infrun.c (displaced_step_prepare, resume): Replace
569         throw_exception with throw.
570         * infcmd.c (post_create_inferior): Replace throw_exception with
571         throw.
572         * inf-loop.c (inferior_event_handler): Replace throw_exception
573         with throw.
574         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
575         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
576         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
577         (get_prev_frame_always, get_frame_pc_if_available)
578         (get_frame_address_in_block_if_available, get_frame_language):
579         Replace throw_exception with throw.
580         * frame-unwind.c (frame_unwind_try_unwinder): Replace
581         throw_exception with throw.
582         * eval.c (fetch_subexp_value, evaluate_var_value)
583         (evaluate_funcall, evaluate_subexp_standard): Replace
584         throw_exception with throw.
585         * dwarf2loc.c (call_site_find_chain)
586         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
587         Replace throw_exception with throw.
588         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
589         with throw.
590         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
591         throw.
592         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
593         * completer.c (complete_line_internal): Replace throw_exception
594         with throw.
595         * compile/compile-object-run.c (compile_object_run): Replace
596         throw_exception with throw.
597         * cli/cli-script.c (process_next_line): Replace throw_exception
598         with throw.
599         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
600         (btrace_enable, btrace_maint_update_pt_packets): Replace
601         throw_exception with throw.
602         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
603         throw_exception with throw.
604         * break-catch-throw.c (re_set_exception_catchpoint): Replace
605         throw_exception with throw.
606         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
607         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
608         * aarch64-tdep.c (aarch64_make_prologue_cache)
609         (aarch64_make_stub_cache): Replace throw_exception with throw.
610
611 2019-04-08  Tom Tromey  <tom@tromey.com>
612
613         * common/common-exceptions.c (throw_exception): Rename from
614         throw_exception_cxx.  Remove old copy.  Make argument const.
615         (throw_it): Create and throw exception objects directly.
616         * common/common-exceptions.h (throw_exception): Make argument
617         const.
618         (struct gdb_exception_error): Add constructor.
619         (struct gdb_exception_quit): Add constructor.
620
621 2019-04-08  Tom Tromey  <tom@tromey.com>
622
623         * common/common-exceptions.h (exception_rethrow): Don't declare.
624         (TRY_SJLJ): Update comment.
625         (TRY, CATCH, END_CATCH): Remove.
626         * common/common-exceptions.c (exception_rethrow): Remove.
627
628 2019-04-08  Tom Tromey  <tom@tromey.com>
629
630         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
631         Remove.
632         (gdb_exception_error): Rename from
633         gdb_exception_RETURN_MASK_ERROR.
634         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
635         (gdb_quit_bad_alloc): Update.
636         * aarch64-tdep.c: Update.
637         * ada-lang.c: Update.
638         * ada-typeprint.c: Update.
639         * ada-valprint.c: Update.
640         * amd64-tdep.c: Update.
641         * arch-utils.c: Update.
642         * break-catch-throw.c: Update.
643         * breakpoint.c: Update.
644         * btrace.c: Update.
645         * c-varobj.c: Update.
646         * cli/cli-cmds.c: Update.
647         * cli/cli-interp.c: Update.
648         * cli/cli-script.c: Update.
649         * common/common-exceptions.c: Update.
650         * common/new-op.c: Update.
651         * common/selftest.c: Update.
652         * compile/compile-c-symbols.c: Update.
653         * compile/compile-cplus-symbols.c: Update.
654         * compile/compile-object-load.c: Update.
655         * compile/compile-object-run.c: Update.
656         * completer.c: Update.
657         * corelow.c: Update.
658         * cp-abi.c: Update.
659         * cp-support.c: Update.
660         * cp-valprint.c: Update.
661         * darwin-nat.c: Update.
662         * disasm-selftests.c: Update.
663         * dtrace-probe.c: Update.
664         * dwarf-index-cache.c: Update.
665         * dwarf-index-write.c: Update.
666         * dwarf2-frame-tailcall.c: Update.
667         * dwarf2-frame.c: Update.
668         * dwarf2loc.c: Update.
669         * dwarf2read.c: Update.
670         * eval.c: Update.
671         * event-loop.c: Update.
672         * event-top.c: Update.
673         * exec.c: Update.
674         * f-valprint.c: Update.
675         * fbsd-tdep.c: Update.
676         * frame-unwind.c: Update.
677         * frame.c: Update.
678         * gdbtypes.c: Update.
679         * gnu-v3-abi.c: Update.
680         * guile/guile-internal.h: Update.
681         * guile/scm-block.c: Update.
682         * guile/scm-breakpoint.c: Update.
683         * guile/scm-cmd.c: Update.
684         * guile/scm-disasm.c: Update.
685         * guile/scm-frame.c: Update.
686         * guile/scm-lazy-string.c: Update.
687         * guile/scm-math.c: Update.
688         * guile/scm-param.c: Update.
689         * guile/scm-ports.c: Update.
690         * guile/scm-pretty-print.c: Update.
691         * guile/scm-symbol.c: Update.
692         * guile/scm-symtab.c: Update.
693         * guile/scm-type.c: Update.
694         * guile/scm-value.c: Update.
695         * i386-linux-tdep.c: Update.
696         * i386-tdep.c: Update.
697         * inf-loop.c: Update.
698         * infcall.c: Update.
699         * infcmd.c: Update.
700         * infrun.c: Update.
701         * jit.c: Update.
702         * language.c: Update.
703         * linespec.c: Update.
704         * linux-fork.c: Update.
705         * linux-nat.c: Update.
706         * linux-tdep.c: Update.
707         * linux-thread-db.c: Update.
708         * main.c: Update.
709         * mi/mi-cmd-break.c: Update.
710         * mi/mi-cmd-stack.c: Update.
711         * mi/mi-interp.c: Update.
712         * mi/mi-main.c: Update.
713         * objc-lang.c: Update.
714         * p-valprint.c: Update.
715         * parse.c: Update.
716         * ppc-linux-tdep.c: Update.
717         * printcmd.c: Update.
718         * python/py-arch.c: Update.
719         * python/py-breakpoint.c: Update.
720         * python/py-cmd.c: Update.
721         * python/py-finishbreakpoint.c: Update.
722         * python/py-frame.c: Update.
723         * python/py-framefilter.c: Update.
724         * python/py-gdb-readline.c: Update.
725         * python/py-inferior.c: Update.
726         * python/py-infthread.c: Update.
727         * python/py-lazy-string.c: Update.
728         * python/py-linetable.c: Update.
729         * python/py-objfile.c: Update.
730         * python/py-param.c: Update.
731         * python/py-prettyprint.c: Update.
732         * python/py-progspace.c: Update.
733         * python/py-record-btrace.c: Update.
734         * python/py-record.c: Update.
735         * python/py-symbol.c: Update.
736         * python/py-type.c: Update.
737         * python/py-unwind.c: Update.
738         * python/py-utils.c: Update.
739         * python/py-value.c: Update.
740         * python/python.c: Update.
741         * record-btrace.c: Update.
742         * record-full.c: Update.
743         * remote-fileio.c: Update.
744         * remote.c: Update.
745         * riscv-tdep.c: Update.
746         * rs6000-aix-tdep.c: Update.
747         * rs6000-tdep.c: Update.
748         * rust-exp.y: Update.
749         * rust-lang.c: Update.
750         * s390-tdep.c: Update.
751         * selftest-arch.c: Update.
752         * solib-dsbt.c: Update.
753         * solib-frv.c: Update.
754         * solib-spu.c: Update.
755         * solib-svr4.c: Update.
756         * solib.c: Update.
757         * sparc64-linux-tdep.c: Update.
758         * stack.c: Update.
759         * symfile-mem.c: Update.
760         * symmisc.c: Update.
761         * target.c: Update.
762         * thread.c: Update.
763         * top.c: Update.
764         * tracefile-tfile.c: Update.
765         * tui/tui.c: Update.
766         * typeprint.c: Update.
767         * unittests/cli-utils-selftests.c: Update.
768         * unittests/parse-connection-spec-selftests.c: Update.
769         * valops.c: Update.
770         * valprint.c: Update.
771         * value.c: Update.
772         * varobj.c: Update.
773         * windows-nat.c: Update.
774         * x86-linux-nat.c: Update.
775         * xml-support.c: Update.
776
777 2019-04-08  Tom Tromey  <tom@tromey.com>
778
779         * xml-support.c: Use C++ exception handling.
780         * x86-linux-nat.c: Use C++ exception handling.
781         * windows-nat.c: Use C++ exception handling.
782         * varobj.c: Use C++ exception handling.
783         * value.c: Use C++ exception handling.
784         * valprint.c: Use C++ exception handling.
785         * valops.c: Use C++ exception handling.
786         * unittests/parse-connection-spec-selftests.c: Use C++ exception
787         handling.
788         * unittests/cli-utils-selftests.c: Use C++ exception handling.
789         * typeprint.c: Use C++ exception handling.
790         * tui/tui.c: Use C++ exception handling.
791         * tracefile-tfile.c: Use C++ exception handling.
792         * top.c: Use C++ exception handling.
793         * thread.c: Use C++ exception handling.
794         * target.c: Use C++ exception handling.
795         * symmisc.c: Use C++ exception handling.
796         * symfile-mem.c: Use C++ exception handling.
797         * stack.c: Use C++ exception handling.
798         * sparc64-linux-tdep.c: Use C++ exception handling.
799         * solib.c: Use C++ exception handling.
800         * solib-svr4.c: Use C++ exception handling.
801         * solib-spu.c: Use C++ exception handling.
802         * solib-frv.c: Use C++ exception handling.
803         * solib-dsbt.c: Use C++ exception handling.
804         * selftest-arch.c: Use C++ exception handling.
805         * s390-tdep.c: Use C++ exception handling.
806         * rust-lang.c: Use C++ exception handling.
807         * rust-exp.y: Use C++ exception handling.
808         * rs6000-tdep.c: Use C++ exception handling.
809         * rs6000-aix-tdep.c: Use C++ exception handling.
810         * riscv-tdep.c: Use C++ exception handling.
811         * remote.c: Use C++ exception handling.
812         * remote-fileio.c: Use C++ exception handling.
813         * record-full.c: Use C++ exception handling.
814         * record-btrace.c: Use C++ exception handling.
815         * python/python.c: Use C++ exception handling.
816         * python/py-value.c: Use C++ exception handling.
817         * python/py-utils.c: Use C++ exception handling.
818         * python/py-unwind.c: Use C++ exception handling.
819         * python/py-type.c: Use C++ exception handling.
820         * python/py-symbol.c: Use C++ exception handling.
821         * python/py-record.c: Use C++ exception handling.
822         * python/py-record-btrace.c: Use C++ exception handling.
823         * python/py-progspace.c: Use C++ exception handling.
824         * python/py-prettyprint.c: Use C++ exception handling.
825         * python/py-param.c: Use C++ exception handling.
826         * python/py-objfile.c: Use C++ exception handling.
827         * python/py-linetable.c: Use C++ exception handling.
828         * python/py-lazy-string.c: Use C++ exception handling.
829         * python/py-infthread.c: Use C++ exception handling.
830         * python/py-inferior.c: Use C++ exception handling.
831         * python/py-gdb-readline.c: Use C++ exception handling.
832         * python/py-framefilter.c: Use C++ exception handling.
833         * python/py-frame.c: Use C++ exception handling.
834         * python/py-finishbreakpoint.c: Use C++ exception handling.
835         * python/py-cmd.c: Use C++ exception handling.
836         * python/py-breakpoint.c: Use C++ exception handling.
837         * python/py-arch.c: Use C++ exception handling.
838         * printcmd.c: Use C++ exception handling.
839         * ppc-linux-tdep.c: Use C++ exception handling.
840         * parse.c: Use C++ exception handling.
841         * p-valprint.c: Use C++ exception handling.
842         * objc-lang.c: Use C++ exception handling.
843         * mi/mi-main.c: Use C++ exception handling.
844         * mi/mi-interp.c: Use C++ exception handling.
845         * mi/mi-cmd-stack.c: Use C++ exception handling.
846         * mi/mi-cmd-break.c: Use C++ exception handling.
847         * main.c: Use C++ exception handling.
848         * linux-thread-db.c: Use C++ exception handling.
849         * linux-tdep.c: Use C++ exception handling.
850         * linux-nat.c: Use C++ exception handling.
851         * linux-fork.c: Use C++ exception handling.
852         * linespec.c: Use C++ exception handling.
853         * language.c: Use C++ exception handling.
854         * jit.c: Use C++ exception handling.
855         * infrun.c: Use C++ exception handling.
856         * infcmd.c: Use C++ exception handling.
857         * infcall.c: Use C++ exception handling.
858         * inf-loop.c: Use C++ exception handling.
859         * i386-tdep.c: Use C++ exception handling.
860         * i386-linux-tdep.c: Use C++ exception handling.
861         * guile/scm-value.c: Use C++ exception handling.
862         * guile/scm-type.c: Use C++ exception handling.
863         * guile/scm-symtab.c: Use C++ exception handling.
864         * guile/scm-symbol.c: Use C++ exception handling.
865         * guile/scm-pretty-print.c: Use C++ exception handling.
866         * guile/scm-ports.c: Use C++ exception handling.
867         * guile/scm-param.c: Use C++ exception handling.
868         * guile/scm-math.c: Use C++ exception handling.
869         * guile/scm-lazy-string.c: Use C++ exception handling.
870         * guile/scm-frame.c: Use C++ exception handling.
871         * guile/scm-disasm.c: Use C++ exception handling.
872         * guile/scm-cmd.c: Use C++ exception handling.
873         * guile/scm-breakpoint.c: Use C++ exception handling.
874         * guile/scm-block.c: Use C++ exception handling.
875         * guile/guile-internal.h: Use C++ exception handling.
876         * gnu-v3-abi.c: Use C++ exception handling.
877         * gdbtypes.c: Use C++ exception handling.
878         * frame.c: Use C++ exception handling.
879         * frame-unwind.c: Use C++ exception handling.
880         * fbsd-tdep.c: Use C++ exception handling.
881         * f-valprint.c: Use C++ exception handling.
882         * exec.c: Use C++ exception handling.
883         * event-top.c: Use C++ exception handling.
884         * event-loop.c: Use C++ exception handling.
885         * eval.c: Use C++ exception handling.
886         * dwarf2read.c: Use C++ exception handling.
887         * dwarf2loc.c: Use C++ exception handling.
888         * dwarf2-frame.c: Use C++ exception handling.
889         * dwarf2-frame-tailcall.c: Use C++ exception handling.
890         * dwarf-index-write.c: Use C++ exception handling.
891         * dwarf-index-cache.c: Use C++ exception handling.
892         * dtrace-probe.c: Use C++ exception handling.
893         * disasm-selftests.c: Use C++ exception handling.
894         * darwin-nat.c: Use C++ exception handling.
895         * cp-valprint.c: Use C++ exception handling.
896         * cp-support.c: Use C++ exception handling.
897         * cp-abi.c: Use C++ exception handling.
898         * corelow.c: Use C++ exception handling.
899         * completer.c: Use C++ exception handling.
900         * compile/compile-object-run.c: Use C++ exception handling.
901         * compile/compile-object-load.c: Use C++ exception handling.
902         * compile/compile-cplus-symbols.c: Use C++ exception handling.
903         * compile/compile-c-symbols.c: Use C++ exception handling.
904         * common/selftest.c: Use C++ exception handling.
905         * common/new-op.c: Use C++ exception handling.
906         * cli/cli-script.c: Use C++ exception handling.
907         * cli/cli-interp.c: Use C++ exception handling.
908         * cli/cli-cmds.c: Use C++ exception handling.
909         * c-varobj.c: Use C++ exception handling.
910         * btrace.c: Use C++ exception handling.
911         * breakpoint.c: Use C++ exception handling.
912         * break-catch-throw.c: Use C++ exception handling.
913         * arch-utils.c: Use C++ exception handling.
914         * amd64-tdep.c: Use C++ exception handling.
915         * ada-valprint.c: Use C++ exception handling.
916         * ada-typeprint.c: Use C++ exception handling.
917         * ada-lang.c: Use C++ exception handling.
918         * aarch64-tdep.c: Use C++ exception handling.
919
920 2019-04-08  Tom Tromey  <tom@tromey.com>
921
922         * xml-support.c (gdb_xml_parser::parse): Update.
923         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
924         * value.c (show_convenience): Update.
925         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
926         (test_parse_flags_qcs): Update.
927         * thread.c (thr_try_catch_cmd): Update.
928         * target.c (target_translate_tls_address): Update.
929         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
930         (info_frame_command_core, frame_apply_command_count): Update.
931         * rust-exp.y (rust_lex_exception_test): Update.
932         * riscv-tdep.c (riscv_print_one_register_info): Update.
933         * remote.c (remote_target::enable_btrace): Update.
934         * record-btrace.c (record_btrace_enable_warn): Update.
935         * python/py-utils.c (gdbpy_convert_exception): Update.
936         * printcmd.c (do_one_display, print_variable_and_value): Update.
937         * mi/mi-main.c (mi_print_exception): Update.
938         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
939         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
940         * linux-nat.c (linux_nat_target::attach): Update.
941         * linux-fork.c (class scoped_switch_fork_info): Update.
942         * infrun.c (displaced_step_prepare): Update.
943         * infcall.c (call_function_by_hand_dummy): Update.
944         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
945         * gnu-v3-abi.c (print_one_vtable): Update.
946         * frame.c (get_prev_frame_always): Update.
947         * f-valprint.c (info_common_command_for_block): Update.
948         * exec.c (try_open_exec_file): Update.
949         * exceptions.c (print_exception, exception_print)
950         (exception_fprintf, exception_print_same): Update.
951         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
952         * dwarf-index-cache.c (index_cache::store)
953         (index_cache::lookup_gdb_index): Update.
954         * darwin-nat.c (maybe_cache_shell): Update.
955         * cp-valprint.c (cp_print_value_fields): Update.
956         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
957         (gcc_cplus_symbol_address): Update.
958         * compile/compile-c-symbols.c (gcc_convert_symbol)
959         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
960         * common/selftest.c: Update.
961         * common/common-exceptions.h (struct gdb_exception) <message>: Now
962         a std::string.
963         (exception_try_scope_entry, exception_try_scope_exit): Don't
964         declare.
965         (struct exception_try_scope): Remove.
966         (TRY): Don't use exception_try_scope.
967         (struct gdb_exception): Add constructor, operator=.
968         <what>: New method.
969         (struct gdb_exception_RETURN_MASK_ALL)
970         (struct gdb_exception_RETURN_MASK_ERROR)
971         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
972         (struct gdb_quit_bad_alloc): Update.
973         * common/common-exceptions.c (exception_none): Change
974         initializer.
975         (struct catcher) <state, exception>: Initialize inline.
976         <prev>: Remove member.
977         (current_catcher): Remove.
978         (catchers): New global.
979         (exceptions_state_mc_init): Simplify.
980         (catcher_pop): Remove.
981         (exceptions_state_mc, exceptions_state_mc_catch): Update.
982         (try_scope_depth, exception_try_scope_entry)
983         (exception_try_scope_exit): Remove.
984         (throw_exception_sjlj): Update.
985         (exception_messages, exception_messages_size): Remove.
986         (throw_it): Simplify.
987         (gdb_exception_sliced_copy): Remove.
988         (throw_exception_cxx): Update.
989         * cli/cli-script.c (script_from_file): Update.
990         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
991         Update.
992         * ada-valprint.c (ada_val_print): Update.
993         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
994         (create_excep_cond_exprs): Update.
995
996 2019-04-08  Tom Tromey  <tom@tromey.com>
997
998         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
999         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1000         (TRY, CATCH, END_CATCH): Remove some definitions.
1001         * common/common-exceptions.c: Don't use GDB_XCPT.
1002         (catcher_list_size): Remove.
1003         (throw_exception, throw_it): Simplify.
1004
1005 2019-04-05  Tom Tromey  <tom@tromey.com>
1006
1007         Revert the header-sorting patch.
1008         * ft32-tdep.c: Revert.
1009         * frv-tdep.c: Revert.
1010         * frv-linux-tdep.c: Revert.
1011         * frame.c: Revert.
1012         * frame-unwind.c: Revert.
1013         * frame-base.c: Revert.
1014         * fork-child.c: Revert.
1015         * findvar.c: Revert.
1016         * findcmd.c: Revert.
1017         * filesystem.c: Revert.
1018         * filename-seen-cache.h: Revert.
1019         * filename-seen-cache.c: Revert.
1020         * fbsd-tdep.c: Revert.
1021         * fbsd-nat.h: Revert.
1022         * fbsd-nat.c: Revert.
1023         * f-valprint.c: Revert.
1024         * f-typeprint.c: Revert.
1025         * f-lang.c: Revert.
1026         * extension.h: Revert.
1027         * extension.c: Revert.
1028         * extension-priv.h: Revert.
1029         * expprint.c: Revert.
1030         * exec.h: Revert.
1031         * exec.c: Revert.
1032         * exceptions.c: Revert.
1033         * event-top.c: Revert.
1034         * event-loop.c: Revert.
1035         * eval.c: Revert.
1036         * elfread.c: Revert.
1037         * dwarf2read.h: Revert.
1038         * dwarf2read.c: Revert.
1039         * dwarf2loc.c: Revert.
1040         * dwarf2expr.h: Revert.
1041         * dwarf2expr.c: Revert.
1042         * dwarf2-frame.c: Revert.
1043         * dwarf2-frame-tailcall.c: Revert.
1044         * dwarf-index-write.h: Revert.
1045         * dwarf-index-write.c: Revert.
1046         * dwarf-index-common.c: Revert.
1047         * dwarf-index-cache.h: Revert.
1048         * dwarf-index-cache.c: Revert.
1049         * dummy-frame.c: Revert.
1050         * dtrace-probe.c: Revert.
1051         * disasm.h: Revert.
1052         * disasm.c: Revert.
1053         * disasm-selftests.c: Revert.
1054         * dictionary.c: Revert.
1055         * dicos-tdep.c: Revert.
1056         * demangle.c: Revert.
1057         * dcache.h: Revert.
1058         * dcache.c: Revert.
1059         * darwin-nat.h: Revert.
1060         * darwin-nat.c: Revert.
1061         * darwin-nat-info.c: Revert.
1062         * d-valprint.c: Revert.
1063         * d-namespace.c: Revert.
1064         * d-lang.c: Revert.
1065         * ctf.c: Revert.
1066         * csky-tdep.c: Revert.
1067         * csky-linux-tdep.c: Revert.
1068         * cris-tdep.c: Revert.
1069         * cris-linux-tdep.c: Revert.
1070         * cp-valprint.c: Revert.
1071         * cp-support.c: Revert.
1072         * cp-namespace.c: Revert.
1073         * cp-abi.c: Revert.
1074         * corelow.c: Revert.
1075         * corefile.c: Revert.
1076         * continuations.c: Revert.
1077         * completer.h: Revert.
1078         * completer.c: Revert.
1079         * complaints.c: Revert.
1080         * coffread.c: Revert.
1081         * coff-pe-read.c: Revert.
1082         * cli-out.h: Revert.
1083         * cli-out.c: Revert.
1084         * charset.c: Revert.
1085         * c-varobj.c: Revert.
1086         * c-valprint.c: Revert.
1087         * c-typeprint.c: Revert.
1088         * c-lang.c: Revert.
1089         * buildsym.c: Revert.
1090         * buildsym-legacy.c: Revert.
1091         * build-id.h: Revert.
1092         * build-id.c: Revert.
1093         * btrace.c: Revert.
1094         * bsd-uthread.c: Revert.
1095         * breakpoint.h: Revert.
1096         * breakpoint.c: Revert.
1097         * break-catch-throw.c: Revert.
1098         * break-catch-syscall.c: Revert.
1099         * break-catch-sig.c: Revert.
1100         * blockframe.c: Revert.
1101         * block.c: Revert.
1102         * bfin-tdep.c: Revert.
1103         * bfin-linux-tdep.c: Revert.
1104         * bfd-target.c: Revert.
1105         * bcache.c: Revert.
1106         * ax-general.c: Revert.
1107         * ax-gdb.h: Revert.
1108         * ax-gdb.c: Revert.
1109         * avr-tdep.c: Revert.
1110         * auxv.c: Revert.
1111         * auto-load.c: Revert.
1112         * arm-wince-tdep.c: Revert.
1113         * arm-tdep.c: Revert.
1114         * arm-symbian-tdep.c: Revert.
1115         * arm-pikeos-tdep.c: Revert.
1116         * arm-obsd-tdep.c: Revert.
1117         * arm-nbsd-tdep.c: Revert.
1118         * arm-nbsd-nat.c: Revert.
1119         * arm-linux-tdep.c: Revert.
1120         * arm-linux-nat.c: Revert.
1121         * arm-fbsd-tdep.c: Revert.
1122         * arm-fbsd-nat.c: Revert.
1123         * arm-bsd-tdep.c: Revert.
1124         * arch-utils.c: Revert.
1125         * arc-tdep.c: Revert.
1126         * arc-newlib-tdep.c: Revert.
1127         * annotate.h: Revert.
1128         * annotate.c: Revert.
1129         * amd64-windows-tdep.c: Revert.
1130         * amd64-windows-nat.c: Revert.
1131         * amd64-tdep.c: Revert.
1132         * amd64-sol2-tdep.c: Revert.
1133         * amd64-obsd-tdep.c: Revert.
1134         * amd64-obsd-nat.c: Revert.
1135         * amd64-nbsd-tdep.c: Revert.
1136         * amd64-nbsd-nat.c: Revert.
1137         * amd64-nat.c: Revert.
1138         * amd64-linux-tdep.c: Revert.
1139         * amd64-linux-nat.c: Revert.
1140         * amd64-fbsd-tdep.c: Revert.
1141         * amd64-fbsd-nat.c: Revert.
1142         * amd64-dicos-tdep.c: Revert.
1143         * amd64-darwin-tdep.c: Revert.
1144         * amd64-bsd-nat.c: Revert.
1145         * alpha-tdep.c: Revert.
1146         * alpha-obsd-tdep.c: Revert.
1147         * alpha-nbsd-tdep.c: Revert.
1148         * alpha-mdebug-tdep.c: Revert.
1149         * alpha-linux-tdep.c: Revert.
1150         * alpha-linux-nat.c: Revert.
1151         * alpha-bsd-tdep.c: Revert.
1152         * alpha-bsd-nat.c: Revert.
1153         * aix-thread.c: Revert.
1154         * agent.c: Revert.
1155         * addrmap.c: Revert.
1156         * ada-varobj.c: Revert.
1157         * ada-valprint.c: Revert.
1158         * ada-typeprint.c: Revert.
1159         * ada-tasks.c: Revert.
1160         * ada-lang.c: Revert.
1161         * aarch64-tdep.c: Revert.
1162         * aarch64-ravenscar-thread.c: Revert.
1163         * aarch64-newlib-tdep.c: Revert.
1164         * aarch64-linux-tdep.c: Revert.
1165         * aarch64-linux-nat.c: Revert.
1166         * aarch64-fbsd-tdep.c: Revert.
1167         * aarch64-fbsd-nat.c: Revert.
1168         * aarch32-linux-nat.c: Revert.
1169
1170 2019-04-05  Tom Tromey  <tom@tromey.com>
1171
1172         * ft32-tdep.c: Sort headers.
1173         * frv-tdep.c: Sort headers.
1174         * frv-linux-tdep.c: Sort headers.
1175         * frame.c: Sort headers.
1176         * frame-unwind.c: Sort headers.
1177         * frame-base.c: Sort headers.
1178         * fork-child.c: Sort headers.
1179         * findvar.c: Sort headers.
1180         * findcmd.c: Sort headers.
1181         * filesystem.c: Sort headers.
1182         * filename-seen-cache.h: Sort headers.
1183         * filename-seen-cache.c: Sort headers.
1184         * fbsd-tdep.c: Sort headers.
1185         * fbsd-nat.h: Sort headers.
1186         * fbsd-nat.c: Sort headers.
1187         * f-valprint.c: Sort headers.
1188         * f-typeprint.c: Sort headers.
1189         * f-lang.c: Sort headers.
1190         * extension.h: Sort headers.
1191         * extension.c: Sort headers.
1192         * extension-priv.h: Sort headers.
1193         * expprint.c: Sort headers.
1194         * exec.h: Sort headers.
1195         * exec.c: Sort headers.
1196         * exceptions.c: Sort headers.
1197         * event-top.c: Sort headers.
1198         * event-loop.c: Sort headers.
1199         * eval.c: Sort headers.
1200         * elfread.c: Sort headers.
1201         * dwarf2read.h: Sort headers.
1202         * dwarf2read.c: Sort headers.
1203         * dwarf2loc.c: Sort headers.
1204         * dwarf2expr.h: Sort headers.
1205         * dwarf2expr.c: Sort headers.
1206         * dwarf2-frame.c: Sort headers.
1207         * dwarf2-frame-tailcall.c: Sort headers.
1208         * dwarf-index-write.h: Sort headers.
1209         * dwarf-index-write.c: Sort headers.
1210         * dwarf-index-common.c: Sort headers.
1211         * dwarf-index-cache.h: Sort headers.
1212         * dwarf-index-cache.c: Sort headers.
1213         * dummy-frame.c: Sort headers.
1214         * dtrace-probe.c: Sort headers.
1215         * disasm.h: Sort headers.
1216         * disasm.c: Sort headers.
1217         * disasm-selftests.c: Sort headers.
1218         * dictionary.c: Sort headers.
1219         * dicos-tdep.c: Sort headers.
1220         * demangle.c: Sort headers.
1221         * dcache.h: Sort headers.
1222         * dcache.c: Sort headers.
1223         * darwin-nat.h: Sort headers.
1224         * darwin-nat.c: Sort headers.
1225         * darwin-nat-info.c: Sort headers.
1226         * d-valprint.c: Sort headers.
1227         * d-namespace.c: Sort headers.
1228         * d-lang.c: Sort headers.
1229         * ctf.c: Sort headers.
1230         * csky-tdep.c: Sort headers.
1231         * csky-linux-tdep.c: Sort headers.
1232         * cris-tdep.c: Sort headers.
1233         * cris-linux-tdep.c: Sort headers.
1234         * cp-valprint.c: Sort headers.
1235         * cp-support.c: Sort headers.
1236         * cp-namespace.c: Sort headers.
1237         * cp-abi.c: Sort headers.
1238         * corelow.c: Sort headers.
1239         * corefile.c: Sort headers.
1240         * continuations.c: Sort headers.
1241         * completer.h: Sort headers.
1242         * completer.c: Sort headers.
1243         * complaints.c: Sort headers.
1244         * coffread.c: Sort headers.
1245         * coff-pe-read.c: Sort headers.
1246         * cli-out.h: Sort headers.
1247         * cli-out.c: Sort headers.
1248         * charset.c: Sort headers.
1249         * c-varobj.c: Sort headers.
1250         * c-valprint.c: Sort headers.
1251         * c-typeprint.c: Sort headers.
1252         * c-lang.c: Sort headers.
1253         * buildsym.c: Sort headers.
1254         * buildsym-legacy.c: Sort headers.
1255         * build-id.h: Sort headers.
1256         * build-id.c: Sort headers.
1257         * btrace.c: Sort headers.
1258         * bsd-uthread.c: Sort headers.
1259         * breakpoint.h: Sort headers.
1260         * breakpoint.c: Sort headers.
1261         * break-catch-throw.c: Sort headers.
1262         * break-catch-syscall.c: Sort headers.
1263         * break-catch-sig.c: Sort headers.
1264         * blockframe.c: Sort headers.
1265         * block.c: Sort headers.
1266         * bfin-tdep.c: Sort headers.
1267         * bfin-linux-tdep.c: Sort headers.
1268         * bfd-target.c: Sort headers.
1269         * bcache.c: Sort headers.
1270         * ax-general.c: Sort headers.
1271         * ax-gdb.h: Sort headers.
1272         * ax-gdb.c: Sort headers.
1273         * avr-tdep.c: Sort headers.
1274         * auxv.c: Sort headers.
1275         * auto-load.c: Sort headers.
1276         * arm-wince-tdep.c: Sort headers.
1277         * arm-tdep.c: Sort headers.
1278         * arm-symbian-tdep.c: Sort headers.
1279         * arm-pikeos-tdep.c: Sort headers.
1280         * arm-obsd-tdep.c: Sort headers.
1281         * arm-nbsd-tdep.c: Sort headers.
1282         * arm-nbsd-nat.c: Sort headers.
1283         * arm-linux-tdep.c: Sort headers.
1284         * arm-linux-nat.c: Sort headers.
1285         * arm-fbsd-tdep.c: Sort headers.
1286         * arm-fbsd-nat.c: Sort headers.
1287         * arm-bsd-tdep.c: Sort headers.
1288         * arch-utils.c: Sort headers.
1289         * arc-tdep.c: Sort headers.
1290         * arc-newlib-tdep.c: Sort headers.
1291         * annotate.h: Sort headers.
1292         * annotate.c: Sort headers.
1293         * amd64-windows-tdep.c: Sort headers.
1294         * amd64-windows-nat.c: Sort headers.
1295         * amd64-tdep.c: Sort headers.
1296         * amd64-sol2-tdep.c: Sort headers.
1297         * amd64-obsd-tdep.c: Sort headers.
1298         * amd64-obsd-nat.c: Sort headers.
1299         * amd64-nbsd-tdep.c: Sort headers.
1300         * amd64-nbsd-nat.c: Sort headers.
1301         * amd64-nat.c: Sort headers.
1302         * amd64-linux-tdep.c: Sort headers.
1303         * amd64-linux-nat.c: Sort headers.
1304         * amd64-fbsd-tdep.c: Sort headers.
1305         * amd64-fbsd-nat.c: Sort headers.
1306         * amd64-dicos-tdep.c: Sort headers.
1307         * amd64-darwin-tdep.c: Sort headers.
1308         * amd64-bsd-nat.c: Sort headers.
1309         * alpha-tdep.c: Sort headers.
1310         * alpha-obsd-tdep.c: Sort headers.
1311         * alpha-nbsd-tdep.c: Sort headers.
1312         * alpha-mdebug-tdep.c: Sort headers.
1313         * alpha-linux-tdep.c: Sort headers.
1314         * alpha-linux-nat.c: Sort headers.
1315         * alpha-bsd-tdep.c: Sort headers.
1316         * alpha-bsd-nat.c: Sort headers.
1317         * aix-thread.c: Sort headers.
1318         * agent.c: Sort headers.
1319         * addrmap.c: Sort headers.
1320         * ada-varobj.c: Sort headers.
1321         * ada-valprint.c: Sort headers.
1322         * ada-typeprint.c: Sort headers.
1323         * ada-tasks.c: Sort headers.
1324         * ada-lang.c: Sort headers.
1325         * aarch64-tdep.c: Sort headers.
1326         * aarch64-ravenscar-thread.c: Sort headers.
1327         * aarch64-newlib-tdep.c: Sort headers.
1328         * aarch64-linux-tdep.c: Sort headers.
1329         * aarch64-linux-nat.c: Sort headers.
1330         * aarch64-fbsd-tdep.c: Sort headers.
1331         * aarch64-fbsd-nat.c: Sort headers.
1332         * aarch32-linux-nat.c: Sort headers.
1333
1334 2019-04-04  Tom Tromey  <tom@tromey.com>
1335
1336         * varobj.c (varobj_create): Update.
1337         * rust-exp.y (struct rust_parser) <update_innermost_block,
1338         lookup_symbol>: New methods.
1339         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1340         Rename.
1341         (rust_parser::rust_lookup_type)
1342         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1343         * printcmd.c (display_command, do_one_display): Update.
1344         * parser-defs.h (struct parser_state) <parser_state>: Add
1345         "tracker" parameter.
1346         (block_tracker): New member.
1347         (class innermost_block_tracker) <innermost_block_tracker>: Add
1348         "types" parameter.
1349         <reset>: Remove method.
1350         (innermost_block): Don't declare.
1351         (null_post_parser): Update.
1352         * parse.c (innermost_block): Remove global.
1353         (write_dollar_variable): Update.
1354         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1355         Remove "tracker_types" parameter.
1356         (parse_expression): Add "tracker" parameter.
1357         (parse_expression_for_completion): Update.
1358         (null_post_parser): Add "tracker" parameter.
1359         * p-exp.y: Update rules.
1360         * m2-exp.y: Update rules.
1361         * language.h (struct language_defn) <la_post_parser>: Add
1362         "tracker" parameter.
1363         * go-exp.y: Update rules.
1364         * f-exp.y: Update rules.
1365         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1366         parameter.
1367         * d-exp.y: Update rules.
1368         * c-exp.y: Update rules.
1369         * breakpoint.c (set_breakpoint_condition): Create an
1370         innermost_block_tracker.
1371         (watch_command_1): Likewise.
1372         * ada-lang.c (resolve): Add "tracker" parameter.
1373         (resolve_subexp): Likewise.
1374         * ada-exp.y (write_var_from_sym): Update.
1375
1376 2019-04-04  Tom Tromey  <tom@tromey.com>
1377
1378         * type-stack.h: New file.
1379         * type-stack.c: New file.
1380         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1381         type-stack.h.
1382         (insert_into_type_stack, insert_type, push_type, push_type_int)
1383         (insert_type_address_space, pop_type, pop_type_int)
1384         (pop_typelist, pop_type_stack, append_type_stack)
1385         (push_type_stack, get_type_stack, push_typelist)
1386         (follow_type_instance_flags, follow_types): Don't declare.
1387         * parse.c (type_stack): Remove global.
1388         (parse_exp_in_context): Update.
1389         (insert_into_type_stack, insert_type, push_type, push_type_int)
1390         (insert_type_address_space, pop_type, pop_type_int)
1391         (pop_typelist, pop_type_stack, append_type_stack)
1392         (push_type_stack, get_type_stack, push_typelist)
1393         (follow_type_instance_flags, follow_types): Remove (moved to
1394         type-stack.c).
1395         * f-exp.y (type_stack): New global.
1396         Update rules.
1397         (push_kind_type, f_parse): Update.
1398         * d-exp.y (type_stack): New global.
1399         Update rules.
1400         (d_parse): Update.
1401         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1402         Update rules.
1403         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1404         (HFILES_NO_SRCDIR): Add type-stack.h.
1405
1406 2019-04-04  Tom Tromey  <tom@tromey.com>
1407
1408         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1409         (rust_parser::convert_ast_to_expression, rust_parse)
1410         (rust_lex_test_completion, rust_lex_tests): Update.
1411         * parser-defs.h (struct expr_completion_state): New.
1412         (struct parser_state) <parser_state>: Add completion parameter.
1413         <mark_struct_expression, mark_completion_tag>: New methods.
1414         <parse_completion, m_completion_state>: New members.
1415         (prefixify_expression, null_post_parser): Update.
1416         (mark_struct_expression, mark_completion_tag): Don't declare.
1417         * parse.c (parse_completion, expout_last_struct)
1418         (expout_tag_completion_type, expout_completion_name): Remove
1419         globals.
1420         (parser_state::mark_struct_expression)
1421         (parser_state::mark_completion_tag): Now methods.
1422         (prefixify_expression): Add last_struct parameter.
1423         (prefixify_subexp): Likewise.
1424         (parse_exp_1): Update.
1425         (parse_exp_in_context): Add cstate parameter.  Update.
1426         (parse_expression_for_completion): Create an
1427         expr_completion_state.
1428         (null_post_parser): Add "completion" parameter.
1429         * p-exp.y: Update rules.
1430         (yylex): Update.
1431         * language.h (struct language_defn) <la_post_parser>: Add
1432         "completing" parameter.
1433         * go-exp.y: Update rules.
1434         (lex_one_token): Update.
1435         * expression.h (parse_completion): Don't declare.
1436         * d-exp.y: Update rules.
1437         (lex_one_token): Update rules.
1438         * c-exp.y: Update rules.
1439         (lex_one_token): Update.
1440         * ada-lang.c (resolve): Add "parse_completion" parameter.
1441         (resolve_subexp): Likewise.
1442         (ada_resolve_function): Likewise.
1443
1444 2019-04-04  Tom Tromey  <tom@tromey.com>
1445
1446         * parser-defs.h (struct parser_state) <start_arglist,
1447         end_arglist>: New methods.
1448         <arglist_len, m_funcall_chain>: New members.
1449         (arglist_len, start_arglist, end_arglist): Don't declare.
1450         * parse.c (arglist_len, funcall_chain): Remove global.
1451         (start_arglist, end_arglist): Remove functions.
1452         (parse_exp_in_context): Update.
1453         * p-exp.y: Update rules.
1454         * m2-exp.y: Update rules.
1455         * go-exp.y: Update rules.
1456         * f-exp.y: Update rules.
1457         * d-exp.y: Update rules.
1458         * c-exp.y: Update rules.
1459
1460 2019-04-04  Tom Tromey  <tom@tromey.com>
1461
1462         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1463         lex_operator, push_back>: New methods.
1464         Update all rules.
1465         (rust_parser::lex_hex, lex_escape): Rename and update.
1466         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1467         (rust_parser::lex_operator): Rename and update.
1468         (rust_parser::lex_number, rustyylex, rustyyerror)
1469         (rust_lex_test_init, rust_lex_test_sequence)
1470         (rust_lex_test_push_back, rust_lex_tests): Update.
1471         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1472         parameter.
1473         <lexptr, prev_lexptr>: New members.
1474         (lexptr, prev_lexptr): Don't declare.
1475         * parse.c (lexptr, prev_lexptr): Remove globals.
1476         (parse_exp_in_context): Update.
1477         * p-exp.y (yylex, yyerror): Update.
1478         * m2-exp.y (parse_number, yylex, yyerror): Update.
1479         * go-exp.y (lex_one_token, yyerror): Update.
1480         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1481         * d-exp.y (lex_one_token, yyerror): Update.
1482         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1483         (lex_one_token, yyerror): Update.
1484         * ada-lex.l (YY_INPUT): Update.
1485         (rewind_to_char): Update.
1486         * ada-exp.y (yyerror): Update.
1487
1488 2019-04-04  Tom Tromey  <tom@tromey.com>
1489
1490         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1491         * parser-defs.h (struct parser_state) <parser_state>: Add new
1492         parameter.
1493         <comma_terminates>: New member.
1494         (comma_terminates): Don't declare global.
1495         * parse.c (comma_terminates): Remove global.
1496         (parse_exp_in_context): Update.
1497         * p-exp.y (yylex): Update.
1498         * m2-exp.y (yylex): Update.
1499         * go-exp.y (lex_one_token): Update.
1500         * f-exp.y (yylex): Update.
1501         * d-exp.y (lex_one_token): Update.
1502         * c-exp.y (lex_one_token): Update.
1503         * ada-lex.l: Update.
1504
1505 2019-04-04  Tom Tromey  <tom@tromey.com>
1506
1507         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1508         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1509         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1510         * parser-defs.h (paren_depth): Don't declare.
1511         * parse.c (paren_depth): Remove global.
1512         (parse_exp_in_context): Update.
1513         * p-exp.y (paren_depth): New global.
1514         (pascal_parse): Initialize it.
1515         * m2-exp.y (paren_depth): New global.
1516         (m2_parse): Initialize it.
1517         * go-exp.y (paren_depth): New global.
1518         (go_parse): Initialize it.
1519         * f-exp.y (paren_depth): New global.
1520         (f_parse): Initialize it.
1521         * d-exp.y (paren_depth): New global.
1522         (d_parse): Initialize it.
1523         * c-exp.y (paren_depth): New global.
1524         (c_parse): Initialize it.
1525         * ada-lex.l (paren_depth): New global.
1526         (lexer_init): Initialize it.
1527
1528 2019-04-04  Tom Tromey  <tom@tromey.com>
1529
1530         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1531         (rust_parser::convert_ast_to_type)
1532         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1533         * parser-defs.h (struct parser_state) <parser_state>: Add
1534         parameters.  Initialize new members.
1535         <expression_context_block, expression_context_pc>: New members.
1536         * parse.c (expression_context_block, expression_context_pc):
1537         Remove globals.
1538         (parse_exp_in_context): Update.
1539         * p-exp.y: Update all rules.
1540         (yylex): Update.
1541         * m2-exp.y: Update all rules.
1542         (yylex): Update.
1543         * go-exp.y (yylex): Update.
1544         * f-exp.y (yylex): Update.
1545         * d-exp.y: Update all rules.
1546         (yylex): Update.
1547         * c-exp.y: Update all rules.
1548         (lex_one_token, classify_name, yylex, c_parse): Update.
1549         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1550
1551 2019-04-04  Tom Tromey  <tom@tromey.com>
1552
1553         * gdbarch.h, gdbarch.c: Rebuild.
1554         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1555         * stap-probe.h: 
1556         (struct stap_parse_info): Replace "parser_state" with
1557         "expr_builder".
1558         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1559         (parser_state): New class.
1560         * parse.c (expr_builder): Rename.
1561         (expr_builder::release): Rename.
1562         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1563         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1564         (write_exp_elt_longcst, write_exp_elt_floatcst)
1565         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1566         (write_exp_string_vector, write_exp_bitstring)
1567         (write_exp_msymbol, mark_struct_expression)
1568         (write_dollar_variable)
1569         (insert_type_address_space, increase_expout_size): Replace
1570         "parser_state" with "expr_builder".
1571         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1572         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1573         "parser_state" with "expr_builder".
1574
1575 2019-04-04  Tom Tromey  <tom@tromey.com>
1576
1577         * rust-exp.y: Replace "parse_language" with method call.
1578         * p-exp.y: 
1579         (yylex): Replace "parse_language" with method call.
1580         * m2-exp.y: 
1581         (yylex): Replace "parse_language" with method call.
1582         * go-exp.y (classify_name): Replace "parse_language" with method
1583         call.
1584         * f-exp.y (yylex): Replace "parse_language" with method call.
1585         * d-exp.y (lex_one_token): Replace "parse_language" with method
1586         call.
1587         * c-exp.y: 
1588         (lex_one_token, classify_name, yylex): Replace "parse_language"
1589         with method call.
1590         * ada-exp.y (find_primitive_type, type_char)
1591         (type_system_address): Replace "parse_language" with method call.
1592
1593 2019-04-04  Tom Tromey  <tom@tromey.com>
1594
1595         * rust-exp.y: Replace "parse_gdbarch" with method call.
1596         * parse.c (write_dollar_variable, insert_type_address_space):
1597         Replace "parse_gdbarch" with method call.
1598         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
1599         call.
1600         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
1601         call.
1602         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
1603         "parse_gdbarch" with method call.
1604         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
1605         with method call.
1606         * f-exp.y (parse_type, parse_f_type, yylex): Replace
1607         "parse_gdbarch" with method call.
1608         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
1609         "parse_gdbarch" with method call.
1610         * c-exp.y (parse_type, parse_number, classify_name): Replace
1611         "parse_gdbarch" with method call.
1612         * ada-lex.l: Replace "parse_gdbarch" with method call.
1613         * ada-exp.y (parse_type, find_primitive_type, type_char)
1614         (type_system_address): Replace "parse_gdbarch" with method call.
1615
1616 2019-04-04  Tom Tromey  <tom@tromey.com>
1617
1618         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
1619         * stap-probe.c (stap_parse_argument): Update.
1620         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
1621         initial_size parameter.
1622         * rust-exp.y (rust_lex_tests): Update.
1623         * parse.c (parser_state): Update.
1624         (parse_exp_in_context): Update.
1625         * parser-defs.h (struct parser_state) <parser_state>: Remove
1626         "initial_size" parameter.
1627
1628 2019-04-04  Tom Tromey  <tom@tromey.com>
1629
1630         * parser-defs.h (increase_expout_size): Don't declare.
1631         * parse.c (increase_expout_size): Now static.
1632
1633 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1634
1635         * gnu-nat.c (gnu_nat_target::wait): Fix
1636         target_waitstatus_to_string call.
1637
1638 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1639
1640         * eval.c (evaluate_subexp_standard): Handle internal functions
1641         during Fortran function call handling.
1642
1643 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1644
1645         * NEWS: Mention new internal functions.
1646         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1647         (read_base_type): Use dwarf2_init_complex_target_type.
1648         * value.c (creal_internal_fn): New function.
1649         (cimag_internal_fn): New function.
1650         (_initialize_values): Register new internal functions.
1651
1652 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1653
1654         * infrun.c (stop_all_threads): If debug_infrun, always
1655         trace the wait status after wait_one, using
1656         target_waitstatus_to_string and target_pid_to_str.
1657         (handle_inferior_event): Replace various trace of
1658         wait status kind by a single trace.
1659         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
1660         wait status kind image by target_waitstatus_to_string.
1661         * target/waitstatus.c (target_waitstatus_to_string): Fix
1662         obsolete comment.
1663
1664 2019-04-01  Tom Tromey  <tromey@adacore.com>
1665
1666         PR symtab/23331:
1667         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
1668
1669 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1670             Pedro Alves  <palves@redhat.com>
1671
1672         * top.c (quit_force): Call 'finalize_values'.
1673         * value.c (finalize_values): New function.
1674         * value.h (finalize_values): Declare.
1675
1676 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
1677
1678         * NEWS: Announce $_gdb_major and $_gdb_minor.
1679
1680         * top.c (init_gdb_version_vars): New function.
1681         (gdb_init): Call init_gdb_version_vars.
1682
1683 2019-03-29  Tom Tromey  <tromey@adacore.com>
1684
1685         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
1686         help text.  Remove dead code.
1687
1688 2019-03-29  Keith Seitz  <keiths@redhat.com>
1689
1690         From Siddhesh Poyarekar:
1691         * f-lang.h (f77_get_upperbound): Return LONGEST.
1692         (f77_get_lowerbound): Likewise.
1693         * f-typeprint.c (f_type_print_varspec_suffix): Expand
1694         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
1695         print them.
1696         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
1697         plongest to format print it.
1698         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
1699         (f77_get_upperbound): Likewise.
1700         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
1701         LOWER_BOUND to LONGEST.
1702         (f77_create_arrayprint_offset_tbl): Likewise.
1703
1704 2019-03-29  Keith Seitz  <keiths@redhat.com>
1705
1706         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
1707         %s/pulongest for TYPE_LENGTH instead of %d in format
1708         strings.
1709         * ada-typerint.c (ada_print_type): Likewise.
1710         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
1711         * compile/compile-c-support.c (generate_register_struct): Likewise.
1712         * gdbtypes.c (recursive_dump_type): Likewise.
1713         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
1714         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
1715         instead of %d in format strings.
1716         * riscv-tdep.c (riscv_type_alignment): Cast second argument
1717         to std::min to ULONGEST.
1718         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
1719         instead of %d in format strings.
1720         * tracepoint.c (info_scope_command): Likewise.
1721         * typeprint.c (print_offset_data::update)
1722         (print_offset_data::finish): Likewise.
1723         * xtensa-tdep.c (xtensa_store_return_value)
1724         (xtensa_push_dummy_call): Likewise.
1725
1726 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
1727
1728         * windows-nat.c (display_selector): Fixed format specifications
1729         for 64-bit Cygwin.
1730
1731 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1732
1733         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
1734
1735 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
1736
1737         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
1738         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
1739         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
1740         (nios2_linux_init_abi): Install it.
1741
1742 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1743
1744         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
1745
1746 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1747
1748         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
1749
1750 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1751             Tom Tromey  <tromey@adacore.com>
1752
1753         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
1754
1755 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
1756
1757         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
1758         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
1759         method to compute the bounds of range types. Also print "[evaluated]"
1760         if the bounds' values come from a dynamic evaluation.
1761
1762 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1763
1764         * cp-valprint.c (cp_print_value_fields): Don't print trailing
1765         whitespace when pretty printing is on.
1766
1767 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1768
1769         * ppc-linux-nat.c: Add include.
1770
1771 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1772
1773         * NEWS: Mention AArch64 Pointer Authentication.
1774
1775 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1776
1777         * arm-linux-nat.c: Add include.
1778
1779 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
1780
1781         * source-cache.c (source_cache::get_source_lines): Re-read
1782         fullname after calling open_source_file.
1783
1784 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
1785
1786         * NEWS: Mention TLS support for FreeBSD.
1787
1788 2019-03-25  Tom Tromey  <tromey@adacore.com>
1789
1790         * minsyms.c (BUNCH_SIZE): Update comment.
1791         (~minimal_symbol_reader): Remove old comment.
1792         (compact_minimal_symbols): Update comment.
1793         (minimal_symbol_reader::install): Remove old comment.  Update
1794         other comments.
1795
1796 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1797
1798         * s390-linux-nat.c: Add include.
1799
1800 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1801
1802         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1803         Call linux_get_hwcap.
1804         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
1805         Likewise.
1806         (aarch64_linux_get_hwcap): Remove function.
1807         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
1808         declaration.
1809         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
1810         linux_get_hwcap.
1811         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1812         * linux-tdep.c (linux_get_hwcap): Add function.
1813         (linux_get_hwcap2): Likewise.
1814         * linux-tdep.h (linux_get_hwcap): Add declaration.
1815         (linux_get_hwcap2): Likewise.
1816         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
1817         (ppc_linux_get_hwcap2): Likewise.
1818         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
1819         linux_get_hwcap.
1820         (ppc_linux_nat_target::insert_watchpoint): Likewise.
1821         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
1822         (ppc_linux_nat_target::read_description): Likewise.
1823         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
1824         * s390-linux-nat.c: Likewise.
1825         * s390-linux-tdep.c (s390_core_read_description): Likewise.
1826
1827 2019-03-24  Tom Tromey  <tom@tromey.com>
1828
1829         * ada-lang.c (standard_lookup): Simplify initialization.
1830         (ada_lookup_symbol_nonlocal): Simplify return.
1831         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
1832         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
1833         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
1834         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
1835         initialization.
1836         * solib.c (solib_global_lookup): Simplify.
1837         * symtab.c (null_block_symbol): Remove.
1838         (symbol_cache_lookup): Simplify returns.
1839         (lookup_language_this): Simplify returns.
1840         (lookup_symbol_aux): Simplify return.
1841         (lookup_local_symbol): Simplify returns.
1842         (lookup_global_symbol_from_objfile): Simplify return.
1843         (lookup_symbol_in_objfile_symtabs)
1844         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
1845         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
1846         (lookup_static_symbol, lookup_global_symbol): Simplify return.
1847         * cp-namespace.c (cp_lookup_bare_symbol)
1848         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
1849         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
1850         (cp_lookup_nested_symbol): Don't use null_block_symbol.
1851         (cp_lookup_symbol_via_imports): Simplify initialization.
1852         (find_symbol_in_baseclass): Likewise.
1853         * symtab.h (null_block_symbol): Remove.
1854         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
1855         (d_lookup_nested_symbol, d_lookup_symbol_imports)
1856         (d_lookup_symbol_module): Likewise.
1857         (find_symbol_in_baseclass): Simplify initialization.
1858
1859 2019-03-24  Tom Tromey  <tom@tromey.com>
1860
1861         * expression.h: Don't include symtab.h.
1862         (struct block): Forward declare.
1863
1864 2019-03-24  Tom Tromey  <tom@tromey.com>
1865
1866         * c-exp.y (typebase): Remove casts.
1867         * gdbtypes.c (lookup_unsigned_typename, )
1868         (lookup_signed_typename): Remove cast.
1869         * eval.c (parse_to_comma_and_eval): Remove cast.
1870         * parse.c (write_dollar_variable): Remove cast.
1871         * block.h (struct block) <superblock>: Now const.
1872         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
1873         * psymtab.c (psym_map_matching_symbols): Make "block" const.
1874         (map_block): Make "block" const.
1875         * symfile.h (struct quick_symbol_functions)
1876         <map_matching_symbols>: Constify block argument to "callback".
1877         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
1878         const.
1879         (find_pc_sect_compunit_symtab): Make "b" const.
1880         (find_symbol_at_address): Likewise.
1881         (search_symbols): Likewise.
1882         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
1883         (dw2_debug_names_lookup_symbol): Likewise.
1884         (dw2_map_matching_symbols): Update.
1885         * p-valprint.c (pascal_val_print): Remove "block".
1886         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
1887         (aux_add_nonlocal_symbols): Make "block" const.
1888         (resolve_subexp): Remove cast.
1889         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
1890         const.
1891         (iterate_over_file_blocks): Likewise.
1892         * f-exp.y (%union) <bval>: Remove.
1893         * coffread.c (patch_opaque_types): Make "b" const.
1894         * spu-tdep.c (spu_catch_start): Make "block" const.
1895         * c-valprint.c (print_unpacked_pointer): Remove "block".
1896         * symmisc.c (dump_symtab_1): Make "b" const.
1897         (block_depth): Make "block" const.
1898         * d-exp.y (%union) <bval>: Remove.
1899         * cp-support.h (cp_lookup_rtti_type): Update.
1900         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
1901         * psymtab.c (psym_lookup_symbol): Make "block" const.
1902         (maintenance_check_psymtabs): Make "b" const.
1903         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
1904         (enumerate_locals, enumerate_args): Update.
1905         * python/py-symtab.c (stpy_global_block): Make "block" const.
1906         (stpy_static_block): Likewise.
1907         * inline-frame.c (block_starting_point_at): Make "new_block"
1908         const.
1909         * block.c (find_block_in_blockvector): Make return type const.
1910         (blockvector_for_pc_sect): Make "b" const.
1911         (find_block_in_blockvector): Make "b" const.
1912
1913 2019-03-23  Tom Tromey  <tom@tromey.com>
1914
1915         * varobj.c (varobj_create): Update.
1916         * symfile.c (clear_symtab_users): Don't reset innermost_block.
1917         * printcmd.c (display_command, do_one_display): Don't reset
1918         innermost_block.
1919         * parser-defs.h (enum innermost_block_tracker_type): Move to
1920         expression.h.
1921         (innermost_block): Update comment.
1922         * parse.c (parse_exp_1): Add tracker_types parameter.
1923         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
1924         tracker_types parameter.  Reset innermost_block.
1925         (parse_exp_in_context): Remove.
1926         (parse_expression_for_completion): Update.
1927         * objfiles.c (~objfile): Don't reset expression_context_block or
1928         innermost_block.
1929         * expression.h (enum innermost_block_tracker_type): Move from
1930         parser-defs.h.
1931         (parse_exp_1): Add tracker_types parameter.
1932         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
1933         reset innermost_block.
1934
1935 2019-03-23  Tom Tromey  <tom@tromey.com>
1936
1937         * objfiles.h: Include bcache.h.
1938
1939 2019-03-23  Tom Tromey  <tom@tromey.com>
1940
1941         * linespec.c (get_current_search_block): Use
1942         scoped_restore_current_language.
1943         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
1944
1945 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1946             Jiong Wang  <jiong.wang@arm.com>
1947
1948         * aarch64-linux-tdep.c
1949         (aarch64_linux_iterate_over_regset_sections): Check for pauth
1950         section.
1951         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
1952
1953 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1954             Jiong Wang  <jiong.wang@arm.com>
1955
1956         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
1957         instructions.
1958         (aarch64_analyze_prologue_test): Add PACIASP test.
1959         (aarch64_prologue_prev_register): Unmask PC value.
1960
1961 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1962             Jiong Wang  <jiong.wang@arm.com>
1963
1964         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
1965         (aarch64_dwarf2_prev_register): Unmask PC value.
1966         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
1967         (aarch64_execute_dwarf_cfa_vendor_op): Check for
1968         DW_CFA_AARCH64_negate_ra_state.
1969         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
1970
1971 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1972             Jiong Wang  <jiong.wang@arm.com>
1973
1974         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
1975         registers.
1976         (aarch64_pseudo_register_name): Likewise.
1977         (aarch64_pseudo_register_type): Likewise.
1978         (aarch64_pseudo_register_reggroup_p): Likewise.
1979         (aarch64_gdbarch_init): Add pauth registers.
1980         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
1981         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
1982         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
1983         (struct gdbarch_tdep): Add regnum for ra_state.
1984
1985 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1986             Jiong Wang  <jiong.wang@arm.com>
1987
1988         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
1989
1990 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1991             Jiong Wang  <jiong.wang@arm.com>
1992
1993         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
1994         function.
1995         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
1996         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
1997         (aarch64_gdbarch_init): Add puth registers.
1998         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
1999         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2000         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2001
2002 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2003             Jiong Wang  <jiong.wang@arm.com>
2004
2005         * aarch64-linux-nat.c
2006         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2007         * aarch64-linux-tdep.c
2008         (aarch64_linux_core_read_description): Likewise.
2009         (aarch64_linux_get_hwcap): New function.
2010         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2011         (aarch64_linux_get_hwcap): New declaration.
2012
2013 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2014             Jiong Wang  <jiong.wang@arm.com>
2015
2016         * aarch64-linux-nat.c
2017         (aarch64_linux_nat_target::read_description): Add pauth param.
2018         * aarch64-linux-tdep.c
2019         (aarch64_linux_core_read_description): Likewise.
2020         * aarch64-tdep.c (struct target_desc): Add in pauth.
2021         (aarch64_read_description): Add pauth param.
2022         (aarch64_gdbarch_init): Likewise.
2023         * aarch64-tdep.h (aarch64_read_description): Likewise.
2024         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2025         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2026         * features/Makefile: Add new files.
2027         * features/aarch64-pauth.c: New file.
2028         * features/aarch64-pauth.xml: New file.
2029
2030 2019-03-20  Tom Tromey  <tromey@adacore.com>
2031
2032         * infrun.c (handle_inferior_event): Rename from
2033         handle_inferior_event_1.  Create a scoped_value_mark.
2034         (handle_inferior_event): Remove.
2035
2036 2019-03-19  Tom Tromey  <tromey@adacore.com>
2037
2038         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2039         * infrun.h (print_stop_event): Add "displays" parameter.
2040         * infrun.c (print_stop_event): Add "displays" parameter.
2041
2042 2019-03-19  Pedro Alves  <palves@redhat.com>
2043
2044         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2045         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2046         to -1.  Fix TABs vs spaces.
2047         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2048         * tui/tui-out.h (tui_ui_out) Add intro comments.
2049         <m_line, m_start_of_line>: In-class initialize, and add describing
2050         comment.
2051
2052 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2053
2054         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2055         variable names.
2056         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2057
2058 2019-03-18  Pedro Alves  <palves@redhat.com>
2059             Eli Zaretskii <eliz@gnu.org>
2060
2061         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2062         m_line and m_start_of_line.
2063
2064 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2065
2066         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2067         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2068         it returns a newline.  This fixes a regression in TU mode, whereby
2069         the next line is output on the same screen line as the user input.
2070
2071 2019-03-18  Tom Tromey  <tromey@adacore.com>
2072
2073         * minsyms.c (minimal_symbol_reader::install): Remove call to
2074         obstack_blank.
2075
2076 2019-03-18  Pedro Alves  <palves@redhat.com>
2077
2078         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2079         New globals.
2080         (apply_style): New, factored out from ...
2081         (apply_ansi_escape): ... this.  Handle reverse video mode.
2082         (tui_set_reverse_mode): New function.
2083         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2084         * tui/tui-winsource.c (tui_show_source_line): Use
2085         tui_set_reverse_mode instead of setting A_STANDOUT.
2086         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2087         New setter methods.
2088
2089 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2090
2091         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2092         Handle tabs.
2093
2094 2019-03-18  Tom Tromey  <tromey@adacore.com>
2095
2096         * ada-lang.c (empty_array): Add "high" parameter.
2097         (ada_evaluate_subexp): Update.
2098
2099 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2100
2101         * unittests/string_view-selftests.c: Define
2102         _initialize_string_view_selftests unconditionally.
2103
2104 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2105
2106         PR gdb/24350
2107         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2108
2109 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2110
2111         PR gdb/24351
2112         * windows-nat.c (display_selector): Fix format specifiers.
2113
2114 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2115
2116         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2117         tui_refill_source_window instead of tui_refresh_win, to update the
2118         current execution line.  This fixes redisplay of the current line
2119         when stepping through the code with "next" or "step".
2120
2121 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2122
2123         * source-cache.c (source_cache::get_source_lines): Call
2124         find_source_lines to initialize s->nlines.  This fixes vertical
2125         scrolling of TUI source window when the DOWN arrow is pressed.
2126
2127 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2128
2129         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2130         linux-thread-db.c (_initialize_thread_db): Likewise.
2131
2132 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2133
2134         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2135         wclrtoeol in tui_show_source_line".  This reverts changes made in
2136         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2137
2138 2019-03-15  Tom Tromey  <tom@tromey.com>
2139
2140         * symtab.h (struct minimal_symbol): Derive from
2141         general_symbol_info.
2142         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2143         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2144         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2145         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2146         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2147         (MSYMBOL_SEARCH_NAME): Update.
2148         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2149         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2150         * minsyms.c (minimal_symbol_reader::record_full): Update.
2151
2152 2019-03-15  Tom Tromey  <tom@tromey.com>
2153
2154         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2155
2156 2019-03-15  Tom Tromey  <tom@tromey.com>
2157
2158         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2159         unique_xmalloc_ptr.
2160         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2161         Update.
2162         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2163         (build_minimal_symbol_hash_tables)
2164         (minimal_symbol_reader::install): Update.
2165
2166 2019-03-15  Tom Tromey  <tom@tromey.com>
2167
2168         * symtab.c (create_demangled_names_hash): Update.
2169         (symbol_set_names): Update.
2170         * objfiles.h (struct objfile_per_bfd_storage)
2171         <demangled_names_hash>: Now an htab_up.
2172         * objfiles.c (objfile_per_bfd_storage): Simplify.
2173
2174 2019-03-15  Tom Tromey  <tom@tromey.com>
2175
2176         * objfiles.h (struct objfile_per_bfd_storage): Declare
2177         destructor.
2178         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2179         New.
2180         (get_objfile_bfd_data): Use new.  Don't initialize
2181         language_of_main.
2182         (free_objfile_per_bfd_storage): Remove.
2183         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2184
2185 2019-03-15  Tom Tromey  <tom@tromey.com>
2186
2187         * symfile.c (reread_symbols): Update.
2188         * objfiles.c (objfile::objfile): Update.
2189         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2190         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2191         comment.
2192         (minimal_symbol_reader::install): Update.
2193         (terminate_minimal_symbol_table): Remove.
2194         * jit.c (jit_object_close_impl): Update.
2195
2196 2019-03-15  Tom Tromey  <tom@tromey.com>
2197
2198         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2199         initializations.
2200
2201 2019-03-15  Tom Tromey  <tom@tromey.com>
2202
2203         * objfiles.h (struct objfile_per_bfd_storage)
2204         <demangled_hash_languages>: Now a bitset.
2205         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2206         (lookup_minimal_symbol): Update.
2207
2208 2019-03-15  Tom Tromey  <tom@tromey.com>
2209
2210         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2211         Don't return the symbol.
2212         * coffread.c (record_minimal_symbol): Use record_full.
2213
2214 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2215
2216         The MS-Windows port of ncurses fails to switch to a color pair if
2217         one or both of the colors are the implicit default colors.  This
2218         change records the default colors when TUI is initialized, and
2219         then specifies them explicitly when a color pair uses the default
2220         colors.  This allows color styling in TUI mode on MS-Windows.
2221
2222         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2223         ncurses_norm_attr.
2224         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2225         colors in ncurses_norm_attr.
2226         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2227         "none", replace it with the default color recorded in
2228         ncurses_norm_attr.
2229
2230 2019-03-14  Tom Tromey  <tromey@adacore.com>
2231
2232         * source-cache.h (class source_cache) <get_source_lines>: Return
2233         std::string.
2234         * source-cache.c (source_cache::extract_lines): Handle case where
2235         first_pos==npos.  Return std::string.
2236         (source_cache::get_source_lines): Update.
2237
2238 2019-03-14  Tom Tromey  <tromey@adacore.com>
2239
2240         * NEWS: Add item for "style sources" commands.
2241         * source-cache.c (source_cache::get_source_lines): Check
2242         source_styling.
2243         * cli/cli-style.c (source_styling): New global.
2244         (_initialize_cli_style): Add "style sources" commands.
2245         (show_style_sources): New function.
2246         * cli/cli-style.h (source_styling): Declare.
2247
2248 2019-03-14  Pedro Alves  <palves@redhat.com>
2249             Tom Tromey  <tromey@adacore.com>
2250
2251         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2252         * tui/tui-winsource.c (tui_refill_source_window): New function,
2253         from...
2254         (tui_horizontal_source_scroll): ... here.  Move some logic.
2255         * cli/cli-style.c (set_style_enabled): Notify new observable.
2256         * tui/tui-hooks.c (tui_redisplay_source): New function.
2257         (tui_attach_detach_observers): Attach or detach
2258         tui_redisplay_source.
2259         * observable.h (source_styling_changed): New observable.
2260         * observable.c: Define source_styling_changed observable.
2261
2262 2019-03-13  Tom Tromey  <tromey@adacore.com>
2263
2264         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2265         (i386_gnu_nat_target::store_registers): Update.
2266         * target-debug.h (target_debug_print_std_string): New macro.
2267         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2268         * windows-tdep.c (display_one_tib): Update.
2269         * tui/tui-stack.c (tui_make_status_line): Update.
2270         * top.c (print_inferior_quit_action): Update.
2271         * thread.c (thr_try_catch_cmd): Update.
2272         (add_thread_with_info): Update.
2273         (thread_target_id_str): Update.
2274         (thr_try_catch_cmd): Update.
2275         (thread_command): Update.
2276         (thread_find_command): Update.
2277         * record-btrace.c (record_btrace_target::info_record)
2278         (record_btrace_resume_thread, record_btrace_target::resume)
2279         (record_btrace_cancel_resume, record_btrace_step_thread)
2280         (record_btrace_target::wait, record_btrace_target::wait)
2281         (record_btrace_target::wait, record_btrace_target::stop): Update.
2282         * progspace.c (print_program_space): Update.
2283         * process-stratum-target.c
2284         (process_stratum_target::thread_address_space): Update.
2285         * linux-fork.c (linux_fork_mourn_inferior)
2286         (detach_checkpoint_command, info_checkpoints_command)
2287         (linux_fork_context): Update.
2288         (linux_fork_detach): Update.
2289         (class scoped_switch_fork_info): Update.
2290         (delete_checkpoint_command): Update.
2291         * infrun.c (follow_fork_inferior): Update.
2292         (follow_fork_inferior): Update.
2293         (proceed_after_vfork_done): Update.
2294         (handle_vfork_child_exec_or_exit): Update.
2295         (follow_exec): Update.
2296         (displaced_step_prepare_throw): Update.
2297         (displaced_step_restore): Update.
2298         (start_step_over): Update.
2299         (resume_1): Update.
2300         (clear_proceed_status_thread): Update.
2301         (proceed): Update.
2302         (print_target_wait_results): Update.
2303         (do_target_wait): Update.
2304         (context_switch): Update.
2305         (stop_all_threads): Update.
2306         (restart_threads): Update.
2307         (finish_step_over): Update.
2308         (handle_signal_stop): Update.
2309         (switch_back_to_stepped_thread): Update.
2310         (keep_going_pass_signal): Update.
2311         (print_exited_reason): Update.
2312         (normal_stop): Update.
2313         * inferior.c (inferior_pid_to_str): Change return type.
2314         (print_selected_inferior): Update.
2315         (add_inferior): Update.
2316         (detach_inferior): Update.
2317         * dummy-frame.c (fprint_dummy_frames): Update.
2318         * dcache.c (dcache_info_1): Update.
2319         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2320         (btrace_fetch, btrace_clear): Update.
2321         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2322         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2323         type.
2324         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2325         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2326         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2327         * gdbarch.c, gdbarch.h: Rebuild.
2328         * gdbarch.sh (core_pid_to_str): Change return type.
2329         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2330         return type.
2331         (windows_nat_target::pid_to_str): Change return type.
2332         (windows_delete_thread): Update.
2333         (windows_nat_target::attach): Update.
2334         (windows_nat_target::files_info): Update.
2335         * target-delegates.c: Rebuild.
2336         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2337         return type.
2338         (sol_thread_target::pid_to_str): Change return type.
2339         * remote.c (class remote_target) <pid_to_str>: Change return
2340         type.
2341         (remote_target::pid_to_str): Change return type.
2342         (extended_remote_target::attach, remote_target::remote_stop_ns)
2343         (remote_target::remote_notif_remove_queued_reply)
2344         (remote_target::push_stop_reply, remote_target::disable_btrace):
2345         Update.
2346         (extended_remote_target::attach): Update.
2347         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2348         type.
2349         (gdbsim_target::pid_to_str): Change return type.
2350         * ravenscar-thread.c (struct ravenscar_thread_target)
2351         <pid_to_str>: Change return type.
2352         (ravenscar_thread_target::pid_to_str): Change return type.
2353         * procfs.c (class procfs_target) <pid_to_str>: Change return
2354         type.
2355         (procfs_target::pid_to_str): Change return type.
2356         (procfs_target::attach): Update.
2357         (procfs_target::detach): Update.
2358         (procfs_target::fetch_registers): Update.
2359         (procfs_target::store_registers): Update.
2360         (procfs_target::wait): Update.
2361         (procfs_target::files_info): Update.
2362         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2363         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2364         return type.
2365         (nto_procfs_target::pid_to_str): Change return type.
2366         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2367         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2368         return type.
2369         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2370         (exit_lwp): Update.
2371         (attach_proc_task_lwp_callback, get_detach_signal)
2372         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2373         (linux_nat_target::resume, wait_lwp, stop_callback)
2374         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2375         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2376         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2377         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2378         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2379         type.
2380         (inf_ptrace_target::attach): Update.
2381         (inf_ptrace_target::files_info): Update.
2382         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2383         type.
2384         (go32_nat_target::pid_to_str): Change return type.
2385         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2386         (gnu_nat_target::wait): Update.
2387         (gnu_nat_target::wait): Update.
2388         (gnu_nat_target::resume): Update.
2389         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2390         (fbsd_nat_target::wait): Update.
2391         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2392         type.
2393         (darwin_nat_target::attach): Update.
2394         * corelow.c (class core_target) <pid_to_str>: Change return type.
2395         (core_target::pid_to_str): Change return type.
2396         * target.c (normal_pid_to_str): Change return type.
2397         (default_pid_to_str): Likewise.
2398         (target_pid_to_str): Change return type.
2399         (target_translate_tls_address): Update.
2400         (target_announce_detach): Update.
2401         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2402         return type.
2403         (bsd_uthread_target::pid_to_str): Change return type.
2404         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2405         type.
2406         (bsd_kvm_target::pid_to_str): Change return type.
2407         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2408         return type.
2409         (aix_thread_target::pid_to_str): Change return type.
2410         * target.h (struct target_ops) <pid_to_str>: Change return type.
2411         (target_pid_to_str, normal_pid_to_str): Likewise.
2412         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2413         type.
2414         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2415         type.
2416         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2417         return type.
2418         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2419         type.
2420         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2421         type.
2422         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2423         return type.
2424
2425 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2426
2427         * NEWS: Mention that the new default MI version is 3.  Mention
2428         changes to the output of commands and events that deal with
2429         multi-location breakpoints.
2430         * breakpoint.c: Include "mi/mi-out.h".
2431         (print_one_breakpoint): Change output syntax if using MI version
2432         >= 3.
2433         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2434         New.
2435         (mi_multi_location_breakpoint_output_fixed): New.
2436         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2437         (mi_cmd_fix_multi_location_breakpoint_output): New.
2438         (mi_multi_location_breakpoint_output_fixed): New.
2439         * mi/mi-cmds.c (mi_cmds): Register command
2440         -fix-multi-location-breakpoint-output.
2441         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2442         interpreter "mi".
2443
2444 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2445
2446         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2447         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2448         instantiate mi_ui_out based on interpreter name.
2449         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2450         * mi/mi-main.c (mi_load_progress): Likewise.
2451
2452 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2453
2454         * NEWS: Combine separate "New targets" sections for 8.3.
2455
2456 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2457
2458         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2459         (ppcfbsd_init_abi): Install gdbarch
2460         "fetch_tls_load_module_address" and "get_thread_local_address"
2461         methods.
2462
2463 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2464
2465         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2466         (riscv_fbsd_init_abi): Install gdbarch
2467         "fetch_tls_load_module_address" and "get_thread_local_address"
2468         methods.
2469
2470 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2471
2472         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2473         (i386fbsd_init_abi): Install gdbarch
2474         "fetch_tls_load_module_address" and "get_thread_local_address"
2475         methods.
2476
2477 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2478
2479         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2480         (amd64fbsd_init_abi): Install gdbarch
2481         "fetch_tls_load_module_address" and "get_thread_local_address"
2482         methods.
2483
2484 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2485
2486         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2487         (struct fbsd_pspace_data): New type.
2488         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2489         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2490         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2491         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2492         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2493
2494 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2495
2496         * gdbtypes.c (lookup_struct_elt): New function.
2497         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2498         * gdbtypes.h (struct struct_elt): New type.
2499         (lookup_struct_elt): New prototype.
2500
2501 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2502
2503         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2504         remove disabled code block.
2505
2506 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2507
2508         * gdbarch.sh (get_thread_local_address): New method.
2509         * gdbarch.h, gdbarch.c: Regenerate.
2510         * target.c (target_translate_tls_address): Use
2511         gdbarch_get_thread_local_address if present instead of
2512         target::get_thread_local_address.
2513
2514 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2515
2516         * target.h (target::get_thread_local_address): Update comment.
2517
2518 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2519
2520         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2521         objfile->separate_debug_objfile_backlink if not NULL.
2522
2523 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2524
2525         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2526         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2527         (amd64bsd_store_inferior_registers): Likewise.
2528         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2529         Enable segment base registers.
2530         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2531         PT_GETFSBASE and PT_GETGSBASE.
2532         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2533         PT_SETGSBASE.
2534         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2535         segment base registers.
2536         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2537
2538 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2539
2540         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2541         Update calls to i386_target_description to add 'segments'
2542         parameter.
2543         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2544         add segment base registers.
2545         * arch/i386.c (i386_create_target_description): Add 'segments'
2546         parameter to enable segment base registers.
2547         * arch/i386.h (i386_create_target_description): Likewise.
2548         * features/i386/32bit-segments.xml: New file.
2549         * features/i386/32bit-segments.c: Generate.
2550         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2551         call to i386_target_description to add 'segments' parameter.
2552         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2553         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2554         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2555         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2556         if feature is present.
2557         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2558         Add 'segments' parameter to call to i386_target_description.
2559         (i386_target_description): Add 'segments' parameter to enable
2560         segment base registers.
2561         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2562         to call to i386_target_description.
2563         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2564         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2565         Define I386_NUM_REGS.
2566         (i386_target_description): Add 'segments' parameter to enable
2567         segment base registers.
2568
2569 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2570
2571         PR/24325
2572         * source-cache.c: #undef open and close, to avoid unresolved
2573         externals during linking.
2574
2575 2019-03-12  Tom Tromey  <tromey@adacore.com>
2576
2577         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2578         const.  Add initializers.
2579         (_initialize_remote): Don't initialize ptid globals.
2580
2581 2019-03-12  Pedro Alves  <palves@redhat.com>
2582
2583         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
2584
2585 2019-03-12  Pedro Alves  <palves@redhat.com>
2586
2587         * cp-name-parser.y (main): Remove unused 'len' variable.
2588
2589 2019-03-12  Tom Tromey  <tromey@adacore.com>
2590
2591         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
2592         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
2593
2594 2019-03-12  Tom Tromey  <tromey@adacore.com>
2595
2596         * linux-nat.c (iterate_over_lwps): Update.
2597         (stop_callback): Remove parameter.
2598         (stop_wait_callback, detach_callback, resume_set_callback)
2599         (select_singlestep_lwp_callback, set_ignore_sigint)
2600         (status_callback, resumed_callback, resume_clear_callback)
2601         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
2602         data parameter.
2603         (linux_nat_target::detach, linux_nat_target::resume)
2604         (linux_stop_and_wait_all_lwps, select_event_lwp)
2605         (linux_nat_filter_event, linux_nat_wait_1)
2606         (linux_nat_target::kill, linux_nat_target::stop)
2607         (linux_nat_target::stop): Update.
2608         (linux_nat_resume_callback): Change type.
2609         (resume_stopped_resumed_lwps, count_events_callback)
2610         (select_event_lwp_callback): Likewise.
2611         (linux_stop_lwp, linux_nat_stop_lwp): Update.
2612         * arm-linux-nat.c (struct update_registers_data): Remove.
2613         (update_registers_callback): Change type.
2614         (arm_linux_insert_hw_breakpoint1): Update.
2615         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
2616         parameter.
2617         (x86_linux_dr_set_addr): Update.
2618         (x86_linux_dr_set_control): Update.
2619         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
2620         (iterate_over_lwps): Use gdb::function_view.
2621         * nat/aarch64-linux-hw-point.c (struct
2622         aarch64_dr_update_callback_param): Remove.
2623         (debug_reg_change_callback): Change type.
2624         (aarch64_notify_debug_reg_change): Update.
2625         * s390-linux-nat.c (s390_refresh_per_info): Update.
2626
2627 2019-03-11  Tom Tromey  <tromey@adacore.com>
2628
2629         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2630         redundant assignment to "this_cu".
2631
2632 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2633
2634         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2635
2636 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2637
2638         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2639         from...
2640         (rank_one_type): ... this.
2641
2642 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2643
2644         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2645         from...
2646         (rank_one_type): ... this.
2647
2648 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2649
2650         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
2651         from...
2652         (rank_one_type): ... this.
2653
2654 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2655
2656         * gdbtypes.c (rank_one_type_parm_float): New function extracted
2657         from...
2658         (rank_one_type): ... this.
2659
2660 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2661
2662         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
2663         from...
2664         (rank_one_type): ... this.
2665
2666 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2667
2668         * gdbtypes.c (rank_one_type_parm_range): New function extracted
2669         from...
2670         (rank_one_type): ... this.
2671
2672 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2673
2674         * gdbtypes.c (rank_one_type_parm_char): New function extracted
2675         from...
2676         (rank_one_type): ... this.
2677
2678 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2679
2680         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
2681         from...
2682         (rank_one_type): ... this.
2683
2684 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2685
2686         * gdbtypes.c (rank_one_type_parm_int): New function extracted
2687         from...
2688         (rank_one_type): ... this.
2689
2690 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2691
2692         * gdbtypes.c (rank_one_type_parm_func): New function extracted
2693         from...
2694         (rank_one_type): ... this.
2695
2696 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2697
2698         * gdbtypes.c (rank_one_type_parm_array): New function extracted
2699         from...
2700         (rank_one_type): ... this.
2701
2702 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2703
2704         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
2705         from...
2706         (rank_one_type): ... this.
2707
2708 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2709
2710         * inferior.c (initialize_inferiors): Ensure 'help set/show print
2711         inferior-events' shows the example events.
2712
2713 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
2714
2715         Support styling on native MS-Windows console
2716
2717         PR/24315
2718         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
2719         on MS-Windows if $TERM is not defined.
2720
2721         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
2722
2723         * posix-hdep.c (gdb_console_fputs):
2724         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
2725         functions.
2726         * ui-file.h (gdb_console_fputs): Add prototype.
2727
2728         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
2729         back to fputs only if the former returns zero.
2730
2731 2019-03-07  Tom Tromey  <tom@tromey.com>
2732
2733         * symmisc.c (print_symbol_bcache_statistics): Update.
2734         (print_objfile_statistics): Update.
2735         * symfile.c (allocate_symtab): Update.
2736         * stabsread.c: Don't include bcache.h.
2737         * psymtab.h (struct psymbol_bcache): Don't declare.
2738         (class psymtab_storage) <psymbol_cache>: Now a bcache.
2739         (psymbol_bcache_init, psymbol_bcache_free)
2740         (psymbol_bcache_get_bcache): Don't declare.
2741         * psymtab.c (struct psymbol_bcache): Remove.
2742         (psymtab_storage::psymtab_storage): Update.
2743         (psymtab_storage::~psymtab_storage): Update.
2744         (psymbol_bcache_init, psymbol_bcache_free)
2745         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
2746         (add_psymbol_to_bcache): Update.
2747         (allocate_psymtab): Update.
2748         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2749         macro_cache>: No longer pointers.
2750         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
2751         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
2752         * macrotab.c (macro_bcache): Update.
2753         * macroexp.c: Don't include bcache.h.
2754         * gdbtypes.c (check_types_worklist): Update.
2755         (types_deeply_equal): Remove TRY/CATCH.  Update.
2756         * elfread.c (elf_symtab_read): Update.
2757         * dwarf2read.c: Don't include bcache.h.
2758         * buildsym.c (buildsym_compunit::get_macro_table): Update.
2759         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
2760         (print_bcache_statistics, bcache_memory_used): Don't declare.
2761         (struct bcache): Move from bcache.c.  Add constructor, destructor,
2762         methods.  Rename all data members.
2763         * bcache.c (struct bcache): Move to bcache.h.
2764         (bcache::expand_hash_table): Rename from expand_hash_table.
2765         (bcache): Remove.
2766         (bcache::insert): Rename from bcache_full.
2767         (bcache::compare): Rename from bcache_compare.
2768         (bcache_xmalloc): Remove.
2769         (bcache::~bcache): Rename from bcache_xfree.
2770         (bcache::print_statistics): Rename from print_bcache_statistics.
2771         (bcache::memory_used): Rename from bcache_memory_used.
2772
2773 2019-03-07  Pedro Alves  <palves@redhat.com>
2774
2775         * infrun.c (normal_stop): Also check for
2776         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
2777
2778 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2779
2780         * f-lang.c (value_from_host_double): Moved to...
2781         * value.c (value_from_host_double): ...here.
2782         * value.h (value_from_host_double): Declare.
2783         * guile/scm-math.c (vlscm_convert_typed_number): Use
2784         value_from_host_double.
2785         (vlscm_convert_number): Likewise.
2786         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
2787         * python/py-value.c (convert_value_from_python): Likewise.
2788
2789 2019-03-06  Tom Tromey  <tom@tromey.com>
2790
2791         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
2792
2793 2019-03-06  Tom Tromey  <tom@tromey.com>
2794
2795         * utils.h (free_current_contents): Don't declare.
2796         * utils.c (free_current_contents): Remove.
2797
2798 2019-03-06  Tom Tromey  <tom@tromey.com>
2799
2800         * top.c (quit_force): Update.
2801         * main.c (captured_command_loop): Update.
2802         * common/new-op.c (operator new): Update.
2803         * common/common-exceptions.c (struct catcher)
2804         <save_cleanup_chain>: Remove member.
2805         (exceptions_state_mc_init): Update.
2806         (exception_try_scope_entry): Return nullptr.
2807         (exception_try_scope_exit, exception_rethrow)
2808         (throw_exception_sjlj, throw_exception_cxx): Update.
2809         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
2810         (all_cleanups, do_cleanups, discard_cleanups)
2811         (discard_final_cleanups, save_cleanups, save_final_cleanups)
2812         (restore_cleanups, restore_final_cleanups): Don't declare.
2813         (do_final_cleanups): Remove parameter.
2814         * common/cleanups.c (cleanup_chain, make_cleanup)
2815         (make_cleanup_dtor, all_cleanups, do_cleanups)
2816         (discard_my_cleanups, discard_cleanups)
2817         (discard_final_cleanups, save_my_cleanups, save_cleanups)
2818         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
2819         (null_cleanup): Remove.
2820         (do_final_cleanups): Remove parameter.
2821
2822 2019-03-06  Tom Tromey  <tom@tromey.com>
2823
2824         * remote.c (remote_target::remote_parse_stop_reply): Use
2825         unique_xmalloc_ptr.
2826
2827 2019-03-06  Tom Tromey  <tom@tromey.com>
2828
2829         * stabsread.c (struct stabs_field_info): Rename from field_info.
2830         <list, fnlist>: Add initializers.
2831         <obstack>: New member.
2832         (read_member_functions, read_struct_fields, read_baseclasses):
2833         Allocate on obstack.  Don't use cleanups.
2834         (read_one_struct_field, read_member_functions, read_struct_fields)
2835         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
2836         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
2837         (read_struct_type): Update.
2838
2839 2019-03-06  Tom Tromey  <tom@tromey.com>
2840
2841         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
2842         * common/filestuff.h (make_cleanup_close): Don't declare.
2843         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
2844         Remove.
2845
2846 2019-03-06  Tom Tromey  <tom@tromey.com>
2847
2848         * solib-aix.c: Use make_scope_exit.
2849
2850 2019-03-06  Tom Tromey  <tom@tromey.com>
2851
2852         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
2853         Use make_scope_exit.
2854
2855 2019-03-06  Tom Tromey  <tom@tromey.com>
2856
2857         * solib-svr4.c (disable_probes_interface): Remove parameter.
2858         (svr4_handle_solib_event): Use make_scope_exit.
2859
2860 2019-03-06  Tom Tromey  <tom@tromey.com>
2861
2862         * remote.c (struct stop_reply_deleter): Remove.
2863         (stop_reply_up): Update.
2864         (struct stop_reply): Derive from notif_event.  Don't typedef.
2865         <regcache>: Now a std::vector.
2866         (stop_reply_xfree): Remove.
2867         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
2868         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
2869         (remote_target::discard_pending_stop_replies): Use delete.
2870         (remote_target::remote_parse_stop_reply): Update.
2871         (remote_target::process_stop_reply): Update.
2872         * remote-notif.h (struct notif_event): Add virtual destructor.
2873         Remove "dtr" member.
2874         (struct notif_client) <alloc_event>: Return a unique_ptr.
2875         (notif_event_xfree): Don't declare.
2876         (notif_event_up): New typedef.
2877         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
2878         (notif_event_xfree, do_notif_event_xfree): Remove.
2879         (remote_notif_state_xfree): Update.
2880
2881 2019-03-06  Tom Tromey  <tom@tromey.com>
2882
2883         * infrun.c (displaced_step_clear_cleanup): Now a
2884         forward_scope_exit type.
2885         (displaced_step_prepare_throw): Update.
2886         (displaced_step_fixup): Update.
2887
2888 2019-03-06  Tom Tromey  <tom@tromey.com>
2889
2890         * inferior.h (class inferior): Update comment.
2891         * gdbthread.h (class thread_info): Update comment.
2892
2893 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
2894             Tom Tromey  <tom@tromey.com>
2895
2896         * stabsread.h (struct stab_section_list): Remove.
2897         (coffstab_build_psymtabs): Update.
2898         * dbxread.c (symbuf_sections): Now a std::vector.
2899         (sect_idx): New global.
2900         (fill_symbuf): Update.
2901         (coffstab_build_psymtabs): Change type of stabsects parameter.
2902         Update.
2903         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
2904         std::vector.
2905         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
2906         (coff_locate_sections): Update.
2907         (coff_symfile_read): Remove cleanups.  Update.
2908         (init_stringtab): Add storage parameter.
2909         (free_stringtab, free_stringtab_cleanup): Remove.
2910         (init_lineno): Add storage parameter.
2911         (free_linetab, free_linetab_cleanup): Remove.
2912
2913 2019-03-06  Pedro Alves  <palves@redhat.com>
2914
2915         * linux-fork.c (fork_info::clobber_regs): Delete.
2916         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
2917         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
2918         comment.  Adjust.
2919         (scoped_switch_fork_info::scoped_switch_fork_info)
2920         (checkpoint_command, linux_fork_context): Adjust
2921         fork_save_infrun_state calls.
2922
2923 2019-03-06  Pedro Alves  <palves@redhat.com>
2924
2925         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
2926         (inf_has_multiple_threads): Return 'bool' and rewrite using
2927         inferior_info::threads().
2928
2929 2019-03-06  Pedro Alves  <palves@redhat.com>
2930
2931         * linux-fork.c: Include <list>.
2932         (fork_list): Now a std::list instance.
2933         (fork_info): Add ctor, dtor, and in-class initialize all fields.
2934         (forks_exist_p, find_last_fork): Adjust.
2935         (new_fork): Delete.
2936         (one_fork_p): New.
2937         (add_fork): Adjust.
2938         (free_fork): Delete, folded into fork_info::~fork_info().
2939         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
2940         Adjust.
2941         (init_fork_list): Delete.
2942         (linux_fork_killall, linux_fork_mourn_inferior)
2943         (linux_fork_detach, info_checkpoints_command): Adjust.
2944         (_initialize_linux_fork): No longer call init_fork_list.
2945
2946 2019-03-06  Pedro Alves  <palves@redhat.com>
2947
2948         * linux-fork.c (new_fork): New, split out of ...
2949         (add_fork): ... this.  Return void.  Move "first fork" special
2950         case from here, to ...
2951         (checkpoint_command): ... here.
2952         * linux-linux.h (add_fork): Return void.
2953
2954 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2955
2956         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
2957
2958 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2959             Chris January  <chris.january@arm.com>
2960             David Lecomber  <david.lecomber@arm.com>
2961
2962         * f-exp.y: New token, UNOP_INTRINSIC.
2963         (exp): New pattern using UNOP_INTRINSIC token.
2964         (f77_keywords): Add 'abs' keyword.
2965         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
2966         (value_from_host_double): New function.
2967         (evaluate_subexp_f): Support UNOP_ABS.
2968
2969 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2970
2971         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
2972         types.
2973
2974 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2975
2976         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
2977         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
2978         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
2979
2980 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2981
2982         * f-exp.y (convert_to_kind_type): Handle more type kinds.
2983
2984 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2985             Chris January  <chris.january@arm.com>
2986
2987         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
2988         * f-exp.y: Define 'KIND' token.
2989         (exp): New pattern for KIND expressions.
2990         (ptype): Handle types with a kind extension.
2991         (direct_abs_decl): Extend to spot kind extensions.
2992         (f77_keywords): Add 'kind' to the list.
2993         (push_kind_type): New function.
2994         (convert_to_kind_type): New function.
2995         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
2996         * parse.c (operator_length_standard): Likewise.
2997         * parser-defs.h (enum type_pieces): Add tp_kind.
2998         * std-operator.def: Add UNOP_KIND.
2999
3000 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3001
3002         * f-exp.y (f_parse): Set yydebug.
3003
3004 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3005
3006         * f-lang.c (evaluate_subexp_f): New function.
3007         (exp_descriptor_f): New global.
3008         (f_language_defn): Use exp_descriptor_f instead of
3009         exp_descriptor_standard.
3010
3011 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3012
3013         * f-exp.y (struct token): Add comments.
3014         (dot_ops): Remove uppercase versions and the end marker.
3015         (f77_keywords): Likewise.
3016         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3017         entries in the dot_ops array are case insensitive, and use
3018         strncasecmp to compare strings.  Also some whitespace cleanup in
3019         this area.  Similar for the f77_keywords array, except entries in
3020         this list might be case sensitive.
3021
3022 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3023
3024         * f-exp.y (struct f77_boolean_val): Add comments.
3025         (boolean_values): Remove uppercase versions, and end marker.
3026         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3027         and use strncasecmp to achieve case insensitivity.  Additionally,
3028         perform whitespace cleanup around this code.
3029
3030 2019-03-06  Tom Tromey  <tromey@adacore.com>
3031
3032         * remote-sim.c (gdbsim_target_open): Use result of
3033         gdb_argv::release.
3034
3035 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3036         Dirk Schubert  <dirk.schubert@arm.com>
3037         Chris January  <chris.january@arm.com>
3038
3039         * eval.c (evaluate_subexp_standard): Call Fortran argument
3040         wrapping logic.
3041         * f-lang.c (struct value): A value which can be passed into a
3042         Fortran function call.
3043         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3044         where appropriate.
3045         (struct type): Value ready for a Fortran function call.
3046         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3047         is needed.
3048         * f-lang.h (fortran_argument_convert): Declaration.
3049         (fortran_preserve_arg_pointer): Declaration.
3050         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3051
3052 2019-03-05  Tom Tromey  <tromey@adacore.com>
3053
3054         * python/py-prettyprint.c (print_string_repr): Remove #if.
3055         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3056
3057 2019-03-05  Tom Tromey  <tromey@adacore.com>
3058
3059         * target.c (the_dummy_target): Move later.  Change type to
3060         "dummy_target".
3061         (initialize_targets): Don't initialize the_dummy_target.
3062
3063 2019-03-05  Tom Tromey  <tromey@adacore.com>
3064
3065         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3066         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3067
3068 2019-03-05  Tom Tromey  <tromey@adacore.com>
3069
3070         * windows-nat.c (windows_nat_target::attach)
3071         (windows_nat_target::detach): Don't call gdb_flush.
3072         * valprint.c (generic_val_print, val_print, val_print_string):
3073         Don't call gdb_flush.
3074         * utils.c (defaulted_query): Don't call gdb_flush.
3075         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3076         * target.c (target_announce_detach): Don't call gdb_flush.
3077         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3078         * remote.c (extended_remote_target::attach): Don't call
3079         gdb_flush.
3080         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3081         * printcmd.c (do_examine): Don't call gdb_flush.
3082         (info_display_command): Don't call gdb_flush.
3083         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3084         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3085         * memattr.c (info_mem_command): Don't call gdb_flush.
3086         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3087         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3088         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3089         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3090         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3091         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3092         (gnu_nat_target::detach): Don't call gdb_flush.
3093         * f-valprint.c (f_val_print): Don't call gdb_flush.
3094         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3095         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3096         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3097         gdb_flush.
3098         * c-valprint.c (c_val_print): Don't call gdb_flush.
3099         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3100
3101 2019-03-05  Tom Tromey  <tromey@adacore.com>
3102
3103         * varobj.c (update_dynamic_varobj_children): Update.
3104         (install_default_visualizer): Use reset, not release.
3105         * value.c (set_internalvar): Update.
3106         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3107         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3108         ATTRIBUTE_UNUSED_RESULT.
3109
3110 2019-03-05  Tom Tromey  <tromey@adacore.com>
3111
3112         * remote.c (class scoped_remote_fd) <release>: Add
3113         ATTRIBUTE_UNUSED_RESULT.
3114
3115 2019-03-05  Tom Tromey  <tromey@adacore.com>
3116
3117         * macroexp.c (struct macro_buffer) <release>: Add
3118         ATTRIBUTE_UNUSED_RESULT.
3119
3120 2019-03-05  Tom Tromey  <tromey@adacore.com>
3121
3122         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3123         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3124         ATTRIBUTE_UNUSED_RESULT.
3125
3126 2019-03-05  Tom Tromey  <tromey@adacore.com>
3127
3128         * common/scoped_fd.h (class scoped_fd) <release>: Add
3129         ATTRIBUTE_UNUSED_RESULT.
3130
3131 2019-03-05  Tom Tromey  <tromey@adacore.com>
3132
3133         * parser-defs.h (struct parser_state) <release>: Add
3134         ATTRIBUTE_UNUSED_RESULT.
3135
3136 2019-03-05  Tom Tromey  <tromey@adacore.com>
3137
3138         * utils.h (class gdb_argv) <release>: Add
3139         ATTRIBUTE_UNUSED_RESULT.
3140         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3141
3142 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3143
3144         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3145         for-loop range, to avoid compiler warnings.
3146
3147         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3148         avoid compiler warnings about unused variables.
3149
3150         * NEWS: Mention end of support for native debugging on MS-Windows
3151         before XP.
3152
3153         PR gdb/24292
3154         * common/netstuff.c:
3155         * gdbserver/gdbreplay.c
3156         * gdbserver/remote-utils.c:
3157         * ser-tcp.c:
3158         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3159         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3160         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3161         'getaddrinfo' and 'freeaddrinfo' were not available before
3162         Windows XP, and mingw.org's MinGW headers by default define
3163         _WIN32_WINNT to 0x500.
3164
3165 2019-03-01  Gary Benson <gbenson@redhat.com>
3166
3167         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3168
3169 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3170             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3171
3172         PR gdb/8527
3173         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3174         set_sigint_trap, clear_sigint_trap.
3175
3176 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3177
3178         * target.c (target_detach): Clear the regcache and the
3179         frame cache.
3180
3181 2019-02-27  Pedro Alves  <palves@redhat.com>
3182
3183         * utils.c (set_screen_size): When we cap the height/width sizes,
3184         tweak the corresponding command variable to show "unlimited":
3185
3186 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3187             Pedro Alves  <palves@redhat.com>
3188
3189         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3190         before calling rl_set_screen_size.
3191
3192 2019-02-27  Tom Tromey  <tromey@adacore.com>
3193
3194         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3195         define.
3196         * python/py-value.c: Remove Python 2.4 workaround.
3197         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3198         workaround.
3199         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3200         Python 2.4 workaround.
3201         * python/python-internal.h: Remove Python 2.4 comment.
3202         (Py_ssize_t): Don't define.
3203         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3204         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3205         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3206         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3207         * python/python.c (do_start_initialization): Remove Python 2.4
3208         workaround.
3209         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3210         (print_children): Remove Python 2.4 workaround.
3211         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3212         workaround.
3213         (CHARBUFFERPROC_NAME): Remove.
3214         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3215         Python 2.4 workaround.
3216
3217 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3218
3219         * NEWS: Note minimum Python version.
3220
3221 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3222
3223         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3224         code from these functions.  Remove corresponding ifdefs.  Use
3225         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3226         Remove gotos and target of gotos.
3227         (infpy_search_memory): Likewise.
3228
3229 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3230
3231         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3232         (hppa_gdbarch_init): Don't register deleted functions with
3233         gdbarch.
3234
3235 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3236
3237         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3238         (h8300_unwind_sp): Delete.
3239         (h8300_dummy_id): Delete.
3240         (h8300_gdbarch_init): Don't register deleted functions with
3241         gdbarch.
3242
3243 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3244
3245         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3246         (ft32_unwind_pc): Delete.
3247         (ft32_unwind_sp): Delete.
3248         (ft32_gdbarch_init): Don't register deleted functions with
3249         gdbarch.
3250
3251 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3252
3253         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3254         (frv_unwind_pc): Delete.
3255         (frv_unwind_sp): Delete.
3256         (frv_gdbarch_init): Don't register deleted functions with
3257         gdbarch.
3258
3259 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3260
3261         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3262         (riscv_unwind_pc): Delete.
3263         (riscv_unwind_sp): Delete.
3264         (riscv_gdbarch_init): Don't register deleted functions with
3265         gdbarch.
3266
3267 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3268
3269         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3270         (csky_unwind_pc): Delete.
3271         (csky_unwind_sp): Delete.
3272         (csky_gdbarch_init): Don't register deleted functions with
3273         gdbarch.
3274
3275 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3276
3277         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3278         (cris_unwind_pc): Delete.
3279         (cris_unwind_sp): Delete.
3280         (cris_gdbarch_init): Don't register deleted functions with
3281         gdbarch.
3282
3283 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3284
3285         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3286         (bfin_unwind_pc): Delete.
3287         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3288
3289 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3290
3291         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3292         (arm_unwind_pc): Delete.
3293         (arm_unwind_sp): Delete.
3294         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3295
3296 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3297
3298         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3299         (arc_unwind_pc): Delete.
3300         (arc_unwind_sp): Delete.
3301         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3302
3303 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3304
3305         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3306         (alpha_unwind_pc): Delete.
3307         (alpha_gdbarch_init): Don't register deleted functions with
3308         gdbarch.
3309
3310 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3311
3312         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3313         (aarch64_unwind_pc): Delete.
3314         (aarch64_unwind_sp): Delete.
3315         (aarch64_gdbarch_init): Don't register deleted functions with
3316         gdbarch.
3317
3318 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3319
3320         * gdbtypes.c (type_align): Don't consider static members when
3321         computing structure alignment.
3322
3323 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3324
3325         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3326         return 0 for other types.
3327         * arch-utils.c (default_type_align): Always return 0.
3328         * gdbarch.h: Regenerate.
3329         * gdbarch.sh (type_align): Extend comment.
3330         * gdbtypes.c (type_align): Add additional comments, always call
3331         gdbarch_type_align before applying the default rules.
3332         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3333         generic code will then apply a suitable default.
3334         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3335         types, return 0 for other types.
3336
3337 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3338
3339         * NEWS: Create a new section for the next release branch.
3340         Rename the section of the current branch, now that it has
3341         been cut.
3342
3343 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3344
3345         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3346         * version.in: Bump version to 8.3.50.DATE-git.
3347
3348 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3349
3350         * aix-thread.c (ptid_cmp): Remove unused variable.
3351         (get_signaled_thread): Likewise.
3352         (store_regs_user_thread): Likewise.
3353         (store_regs_kernel_thread): Likewise.
3354         (fetch_regs_kernel_thread): Remove shadowed variable.
3355
3356 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3357
3358         * features/riscv/32bit-cpu.xml: Add register numbers.
3359         * features/riscv/32bit-fpu.c: Regenerate.
3360         * features/riscv/32bit-fpu.xml: Add register numbers.
3361         * features/riscv/64bit-cpu.xml: Add register numbers.
3362         * features/riscv/64bit-fpu.c: Regenerate.
3363         * features/riscv/64bit-fpu.xml: Add register numbers.
3364
3365 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3366
3367         * NEWS: Mention two argument form of gdb.Value constructor.
3368         * python/py-value.c (convert_buffer_and_type_to_value): New
3369         function.
3370         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3371         Add support for handling an optional second argument.  Call
3372         convert_buffer_and_type_to_value as appropriate.
3373         * python/python-internal.h (Py_buffer_deleter): New struct.
3374         (Py_buffer_up): New typedef.
3375
3376 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3377
3378         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3379         instead of releasing ownership.
3380
3381 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3382
3383         * dwarf2read.c (open_and_init_dwp_file): Call
3384         elf_numsections instead of bfd_count_sections to initialize
3385         dwp_file->num_sections.
3386
3387 2019-02-25  Tom Tromey  <tromey@adacore.com>
3388
3389         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3390
3391 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3392
3393         * gcore.in: Add '--readnever' option when invoking GDB.
3394
3395 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3396
3397         * MAINTAINERS: Update my email address.
3398
3399 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3400
3401         * build-id.c (build_id_to_debug_bfd_1): New function.
3402         (build_id_to_debug_bfd): Look for separate debug file in
3403         sysroot.
3404
3405 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3406
3407         * gdbarch.sh: Update the copyright year range that is placed into
3408         generated files.
3409
3410 2019-02-22  Keith Seitz  <keiths@redhat.com>
3411
3412         PR symtab/23853
3413         * linespec.c (create_sals_line_offset): Search for the default
3414         symtab's filename instead of its fullname.
3415
3416 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3417
3418         * NEWS: Update style defaults.
3419
3420 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3421
3422         * main.c (captured_main_1): Disable styling in batch mode.
3423
3424 2019-02-20  Tom Tromey  <tom@tromey.com>
3425
3426         * symtab.c (symtab_symbol_info): Fix typos.
3427
3428 2019-02-20  Tom Tromey  <tromey@adacore.com>
3429
3430         * findcmd.c (_initialize_mem_search): Use upper case for
3431         metasyntactic variables.
3432
3433 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3434
3435         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3436         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3437
3438 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3439
3440         * top.h (source_file_name): Change to std::string.
3441         * top.c (source_file_name): Likewise.
3442         (command_line_input): Adjust.
3443         * cli/cli-script.c (script_from_file): Adjust.
3444
3445 2019-02-19  Tom Tromey  <tromey@adacore.com>
3446
3447         * ravenscar-thread.c
3448         (ravenscar_thread_target::update_thread_list): Don't call
3449         ada_build_task_list.
3450         * ada-lang.h (ada_build_task_list): Don't declare.
3451         * ada-tasks.c (struct ada_tasks_inferior_data)
3452         <task_list_valid_p>: Now bool.
3453         (read_known_tasks, ada_task_list_changed)
3454         (ada_tasks_invalidate_inferior_data): Update.
3455         (read_known_tasks_array): Return bool.
3456         (read_known_tasks_list): Likewise.
3457         (read_known_tasks): Return void.
3458         (ada_build_task_list): Now static.
3459
3460 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3461
3462         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3463         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3464
3465 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3466
3467         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3468         variant for ada_tasks_pspace_data_handle and
3469         ada_tasks_inferior_data_handle.
3470         (ada_tasks_pspace_data_cleanup): New function.
3471         (ada_tasks_inferior_data_cleanup): New function.
3472
3473 2019-02-17  Tom Tromey  <tom@tromey.com>
3474
3475         * macrotab.h (macro_source_fullname): Return a std::string.
3476         * macrotab.c (macro_include, check_for_redefinition)
3477         (macro_undef, macro_lookup_definition, foreach_macro)
3478         (foreach_macro_in_scope): Update.
3479         (macro_source_fullname): Return a std::string.
3480         * macrocmd.c (show_pp_source_pos): Update.
3481
3482 2019-02-17  Tom Tromey  <tom@tromey.com>
3483
3484         * macrocmd.c (show_pp_source_pos): Style the file names.
3485
3486 2019-02-17  Tom Tromey  <tom@tromey.com>
3487
3488         PR tui/24197:
3489         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3490
3491 2019-02-17  Tom Tromey  <tom@tromey.com>
3492
3493         * ada-lang.c (user_select_syms): Use filtered printing.
3494         * utils.c (wrap_style): New global.
3495         (desired_style): Remove.
3496         (emit_style_escape): Add stream parameter.
3497         (set_output_style, reset_terminal_style, prompt_for_continue):
3498         Update.
3499         (flush_wrap_buffer): Only flush gdb_stdout.
3500         (wrap_here): Set wrap_style.
3501         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3502         treat escape sequences as a character.  Change when wrap buffer is
3503         flushed.
3504         (fputs_styled): Do not set the output style when the default is
3505         requested.
3506         * ui-style.h (struct ui_file_style) <is_default>: New method.
3507         * source.c (print_source_lines_base): Emit escape sequences in one
3508         piece.
3509
3510 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3511
3512         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3513         integers and enumeration types.
3514
3515 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3516
3517         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3518         instead of lookup_symbol_in_language
3519         (do_exact_match): New function.
3520         (ada_get_symbol_name_matcher): Return do_exact_match when
3521         doing a verbatim match.
3522
3523 2019-02-15  Tom Tromey  <tromey@adacore.com>
3524
3525         * ravenscar-thread.c (ravenscar_thread_target::resume)
3526         (ravenscar_thread_target::wait): Special case wildcard requests.
3527
3528 2019-02-15  Tom Tromey  <tromey@adacore.com>
3529
3530         * ravenscar-thread.c (base_ptid): Remove.
3531         (struct ravenscar_thread_target) <close>: New method.
3532         <m_base_ptid>: New member.
3533         <update_inferior_ptid, active_task, task_is_currently_active,
3534         runtime_initialized>: Declare methods.
3535         <ravenscar_thread_target>: Add constructor.
3536         (ravenscar_thread_target::task_is_currently_active)
3537         (ravenscar_thread_target::update_inferior_ptid)
3538         (ravenscar_runtime_initialized): Rename.  Now methods.
3539         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3540         (ravenscar_thread_target::update_thread_list): Update.
3541         (ravenscar_thread_target::active_task): Now method.
3542         (ravenscar_thread_target::store_registers)
3543         (ravenscar_thread_target::prepare_to_store)
3544         (ravenscar_thread_target::prepare_to_store)
3545         (ravenscar_thread_target::mourn_inferior): Update.
3546         (ravenscar_inferior_created): Use "new" to create target.
3547         (ravenscar_thread_target::get_ada_task_ptid): Update.
3548         (_initialize_ravenscar): Don't initialize base_ptid.
3549         (ravenscar_ops): Remove global.
3550
3551 2019-02-15  Tom Tromey  <tromey@adacore.com>
3552
3553         * target.h (push_target): Declare new overload.
3554         * target.c (push_target): New overload, taking an rvalue reference.
3555         * remote.c (remote_target::open_1): Use push_target overload.
3556         * corelow.c (core_target_open): Use push_target overload.
3557
3558 2019-02-15  Tom Tromey  <tromey@adacore.com>
3559
3560         * ravenscar-thread.c (is_ravenscar_task)
3561         (ravenscar_task_is_currently_active): Return bool.
3562         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3563         (_initialize_ravenscar): Remove "(void)".
3564         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3565         Return bool.
3566
3567 2019-02-15  Tom Tromey  <tromey@adacore.com>
3568
3569         * ravenscar-thread.c (ravenscar_runtime_initializer)
3570         (has_ravenscar_runtime, get_running_thread_id)
3571         (ravenscar_thread_target::resume): Fix indentation.
3572
3573 2019-02-15  Tom Tromey  <tromey@adacore.com>
3574
3575         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3576         from ravenscar_arch_ops.
3577         (sparc_ravenscar_ops::fetch_registers)
3578         (sparc_ravenscar_ops::store_registers): Now methods.
3579         (sparc_ravenscar_prepare_to_store): Remove.
3580         (sparc_ravenscar_ops): Redefine.
3581         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
3582         methods and destructor.  Remove members.
3583         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
3584         (ravenscar_thread_target::store_registers)
3585         (ravenscar_thread_target::prepare_to_store): Update.
3586         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
3587         Remove.
3588         (struct ppc_ravenscar_powerpc_ops): Derive from
3589         ravenscar_arch_ops.
3590         (ppc_ravenscar_powerpc_ops::fetch_registers)
3591         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
3592         (ppc_ravenscar_powerpc_ops): Redefine.
3593         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
3594         (ppc_ravenscar_e500_ops::fetch_registers)
3595         (ppc_ravenscar_e500_ops::store_registers): Now methods.
3596         (ppc_ravenscar_e500_ops): Redefine.
3597         * aarch64-ravenscar-thread.c
3598         (aarch64_ravenscar_generic_prepare_to_store): Remove.
3599         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
3600         (aarch64_ravenscar_fetch_registers)
3601         (aarch64_ravenscar_store_registers): Now methods.
3602         (aarch64_ravenscar_ops): Redefine.
3603
3604 2019-02-15  Tom Tromey  <tromey@adacore.com>
3605
3606         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
3607         (ravenscar_thread_target::stopped_by_hw_breakpoint)
3608         (ravenscar_thread_target::stopped_by_watchpoint)
3609         (ravenscar_thread_target::stopped_data_address)
3610         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
3611
3612 2019-02-15  Tom Tromey  <tromey@adacore.com>
3613
3614         * ravenscar-thread.c: Fix some typos.
3615
3616 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3617             Tom Tromey  <tromey@adacore.com>
3618
3619         * ada-lang.c (ada_exception_sal): Change addr_string to a
3620         std::string.
3621         (create_ada_exception_catchpoint): Update.
3622
3623 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3624             Tom Tromey  <tromey@adacore.com>
3625
3626         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3627         (bp_location_ops): Remove.
3628         (base_breakpoint_allocate_location): Update.
3629         (free_bp_location): Update.
3630         * ada-lang.c (class ada_catchpoint_location)
3631         <ada_catchpoint_location>: Remove ops parameter.
3632         (ada_catchpoint_location_dtor): Remove.
3633         (ada_catchpoint_location_ops): Remove.
3634         (allocate_location_exception): Update.
3635         * breakpoint.h (struct bp_location_ops): Remove.
3636         (class bp_location) <bp_location>: Remove bp_location_ops
3637         parameter.
3638         <~bp_location>: Add destructor.
3639         <ops>: Remove.
3640
3641 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3642             Pedro Alves  <palves@redhat.com>
3643
3644         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3645         'PATH_MAX'.
3646
3647 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3648             Samuel Thibault  <samuel.thibault@gnu.org>
3649             Thomas Schwinge  <thomas@codesourcery.com>
3650
3651         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
3652         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
3653
3654 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3655
3656         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
3657         (check_empty): Use "const char *".
3658
3659         * gnu-nat.c (gnu_nat_target::detach): Instead of
3660         'detach_inferior (pid)' call
3661         'detach_inferior (find_inferior_pid (pid))'.
3662
3663         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
3664         'nat/fork-inferior.o'.
3665         * gnu-nat.c: #include "nat/fork-inferior.h".
3666
3667         * gnu-nat.c (gnu_nat_target::detach): Instead of
3668         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
3669         * gnu-nat.h: #include "inf-child.h".
3670         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
3671         'i386_gnu_nat_target::fetch_registers'.
3672         (gnu_store_registers): Rename/move to
3673         'i386_gnu_nat_target::store_registers'.
3674
3675         * config/i386/nm-i386gnu.h: Don't "#include" any files.
3676         * gnu-nat.h (mach_thread_info): New function.
3677         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
3678
3679         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
3680
3681 2019-02-14  Frederic Konrad  <konrad@adacore.com>
3682
3683         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
3684
3685 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
3686
3687         * windows-nat.c (windows_add_thread): Add new parameter
3688         "main_thread_p" with default value set to false.  Update
3689         function documentation as well as all callers.
3690         (windows_delete_thread): Likewise.
3691         (fake_create_process): Update call to windows_add_thread.
3692         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
3693         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
3694         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
3695         call to windows_delete_thread.
3696
3697 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
3698
3699         * MAINTAINERS: Add Andrew Burgess as global maintainer.
3700
3701 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3702
3703         * symfile.c (find_separate_debug_file): Use canonical path of
3704         sysroot with child_path instead of gdb_sysroot if it is valid.
3705
3706 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3707
3708         * symfile.c (find_separate_debug_file): Use child_path to
3709         determine if an object file is under a sysroot.
3710
3711 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3712
3713         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3714         unittests/child-path-selftests.c.
3715         * common/pathstuff.c (child_path): New function.
3716         * common/pathstuff.h (child_path): New prototype.
3717         * unittests/child-path-selftests.c: New file.
3718
3719 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3720
3721         * symfile.c (find_separate_debug_file): Look for separate debug
3722         files in debug directories under the sysroot.
3723
3724 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3725
3726         * symtab.h (struct minimal_symbol data_p): New const method.
3727         (struct minimal_symbol text_p): Likewise.
3728         * symtab.c (output_source_filename): Use file name style
3729         to print file name.
3730         (print_symbol_info): Likewise.
3731         (print_msymbol_info): Use address style to print addresses.
3732         Use function name style to print executable text symbols.
3733         (expand_symtab_containing_pc): Use data_p.
3734         (find_pc_sect_compunit_symtab): Likewise.
3735
3736 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3737
3738         * breakpoint.c (describe_other_breakpoints): Use address style
3739         to print addresses.
3740         (say_where): Likewise.
3741
3742 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3743
3744         * ada-typeprint.c (print_func_type): Print function name
3745         style to print function name.
3746         * c-typeprint.c (c_print_type_1): Likewise.
3747
3748 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
3749
3750         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
3751         for execve.
3752
3753 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3754
3755         * c-exp.y (direct_abs_decl): Use emplace_back to record the
3756         type_stack.
3757
3758 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
3759
3760         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
3761         TYPE_CODE_REF types.
3762
3763 2019-02-08  Jim Wilson  <jimw@sifive.com>
3764
3765         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
3766         (riscv_linux_fregset): New.
3767         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
3768
3769 2019-02-07  Tom Tromey  <tom@tromey.com>
3770
3771         * thread.c (thread_cancel_execution_command): Update.
3772         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
3773         methods.
3774         (struct thread_fsm_ops): Remove.
3775         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
3776         (thread_fsm_should_stop, thread_fsm_return_value)
3777         (thread_fsm_set_finished, thread_fsm_finished_p)
3778         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
3779         Don't declare.
3780         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
3781         * infrun.c (clear_proceed_status_thread)
3782         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
3783         (print_stop_event): Update.
3784         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
3785         Add constructor.
3786         (step_command_fsm_ops): Remove.
3787         (new_step_command_fsm): Remove.
3788         (step_1): Update.
3789         (step_command_fsm::should_stop): Rename from
3790         step_command_fsm_should_stop.
3791         (step_command_fsm::clean_up): Rename from
3792         step_command_fsm_clean_up.
3793         (step_command_fsm::do_async_reply_reason): Rename from
3794         step_command_fsm_async_reply_reason.
3795         (struct until_next_fsm): Inherit from thread_fsm.  Add
3796         constructor.
3797         (until_next_fsm_ops): Remove.
3798         (new_until_next_fsm): Remove.
3799         (until_next_fsm::should_stop): Rename from
3800         until_next_fsm_should_stop.
3801         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
3802         (until_next_fsm::do_async_reply_reason): Rename from
3803         until_next_fsm_async_reply_reason.
3804         (struct finish_command_fsm): Inherit from thread_fsm.  Add
3805         constructor.  Change type of breakpoint.
3806         (finish_command_fsm_ops): Remove.
3807         (new_finish_command_fsm): Remove.
3808         (finish_command_fsm::should_stop): Rename from
3809         finish_command_fsm_should_stop.
3810         (finish_command_fsm::clean_up): Rename from
3811         finish_command_fsm_clean_up.
3812         (finish_command_fsm::return_value): Rename from
3813         finish_command_fsm_return_value.
3814         (finish_command_fsm::do_async_reply_reason): Rename from
3815         finish_command_fsm_async_reply_reason.
3816         (finish_command): Update.
3817         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
3818         Add constructor.
3819         (call_thread_fsm_ops): Remove.
3820         (call_thread_fsm::call_thread_fsm): Rename from
3821         new_call_thread_fsm.
3822         (call_thread_fsm::should_stop): Rename from
3823         call_thread_fsm_should_stop.
3824         (call_thread_fsm::should_notify_stop): Rename from
3825         call_thread_fsm_should_notify_stop.
3826         (run_inferior_call, call_function_by_hand_dummy): Update.
3827         * cli/cli-interp.c (should_print_stop_to_console): Update.
3828         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
3829         Add constructor.  Change type of location_breakpoint,
3830         caller_breakpoint.
3831         (until_break_fsm_ops): Remove.
3832         (new_until_break_fsm): Remove.
3833         (until_break_fsm::should_stop): Rename from
3834         until_break_fsm_should_stop.
3835         (until_break_fsm::clean_up): Rename from
3836         until_break_fsm_clean_up.
3837         (until_break_fsm::do_async_reply_reason): Rename from
3838         until_break_fsm_async_reply_reason.
3839         (until_break_command): Update.
3840         * thread-fsm.c: Remove.
3841         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
3842
3843 2019-02-07  Tom Tromey  <tom@tromey.com>
3844
3845         * yy-remap.h: Add include guard.
3846         * xtensa-tdep.h: Add include guard.
3847         * xcoffread.h: Rename include guard.
3848         * varobj-iter.h: Add include guard.
3849         * tui/tui.h: Rename include guard.
3850         * tui/tui-winsource.h: Rename include guard.
3851         * tui/tui-wingeneral.h: Rename include guard.
3852         * tui/tui-windata.h: Rename include guard.
3853         * tui/tui-win.h: Rename include guard.
3854         * tui/tui-stack.h: Rename include guard.
3855         * tui/tui-source.h: Rename include guard.
3856         * tui/tui-regs.h: Rename include guard.
3857         * tui/tui-out.h: Rename include guard.
3858         * tui/tui-layout.h: Rename include guard.
3859         * tui/tui-io.h: Rename include guard.
3860         * tui/tui-hooks.h: Rename include guard.
3861         * tui/tui-file.h: Rename include guard.
3862         * tui/tui-disasm.h: Rename include guard.
3863         * tui/tui-data.h: Rename include guard.
3864         * tui/tui-command.h: Rename include guard.
3865         * tic6x-tdep.h: Add include guard.
3866         * target/waitstatus.h: Rename include guard.
3867         * target/wait.h: Rename include guard.
3868         * target/target.h: Rename include guard.
3869         * target/resume.h: Rename include guard.
3870         * target-float.h: Rename include guard.
3871         * stabsread.h: Add include guard.
3872         * rs6000-tdep.h: Add include guard.
3873         * riscv-fbsd-tdep.h: Add include guard.
3874         * regformats/regdef.h: Rename include guard.
3875         * record.h: Rename include guard.
3876         * python/python.h: Rename include guard.
3877         * python/python-internal.h: Rename include guard.
3878         * python/py-stopevent.h: Rename include guard.
3879         * python/py-ref.h: Rename include guard.
3880         * python/py-record.h: Rename include guard.
3881         * python/py-record-full.h: Rename include guard.
3882         * python/py-record-btrace.h: Rename include guard.
3883         * python/py-instruction.h: Rename include guard.
3884         * python/py-events.h: Rename include guard.
3885         * python/py-event.h: Rename include guard.
3886         * procfs.h: Add include guard.
3887         * proc-utils.h: Add include guard.
3888         * p-lang.h: Add include guard.
3889         * or1k-tdep.h: Rename include guard.
3890         * observable.h: Rename include guard.
3891         * nto-tdep.h: Rename include guard.
3892         * nat/x86-linux.h: Rename include guard.
3893         * nat/x86-linux-dregs.h: Rename include guard.
3894         * nat/x86-gcc-cpuid.h: Add include guard.
3895         * nat/x86-dregs.h: Rename include guard.
3896         * nat/x86-cpuid.h: Rename include guard.
3897         * nat/ppc-linux.h: Rename include guard.
3898         * nat/mips-linux-watch.h: Rename include guard.
3899         * nat/linux-waitpid.h: Rename include guard.
3900         * nat/linux-ptrace.h: Rename include guard.
3901         * nat/linux-procfs.h: Rename include guard.
3902         * nat/linux-osdata.h: Rename include guard.
3903         * nat/linux-nat.h: Rename include guard.
3904         * nat/linux-namespaces.h: Rename include guard.
3905         * nat/linux-btrace.h: Rename include guard.
3906         * nat/glibc_thread_db.h: Rename include guard.
3907         * nat/gdb_thread_db.h: Rename include guard.
3908         * nat/gdb_ptrace.h: Rename include guard.
3909         * nat/fork-inferior.h: Rename include guard.
3910         * nat/amd64-linux-siginfo.h: Rename include guard.
3911         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
3912         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
3913         * nat/aarch64-linux.h: Rename include guard.
3914         * nat/aarch64-linux-hw-point.h: Rename include guard.
3915         * mn10300-tdep.h: Add include guard.
3916         * mips-linux-tdep.h: Add include guard.
3917         * mi/mi-parse.h: Rename include guard.
3918         * mi/mi-out.h: Rename include guard.
3919         * mi/mi-main.h: Rename include guard.
3920         * mi/mi-interp.h: Rename include guard.
3921         * mi/mi-getopt.h: Rename include guard.
3922         * mi/mi-console.h: Rename include guard.
3923         * mi/mi-common.h: Rename include guard.
3924         * mi/mi-cmds.h: Rename include guard.
3925         * mi/mi-cmd-break.h: Rename include guard.
3926         * m2-lang.h: Add include guard.
3927         * location.h: Rename include guard.
3928         * linux-record.h: Rename include guard.
3929         * linux-nat.h: Add include guard.
3930         * linux-fork.h: Add include guard.
3931         * i386-darwin-tdep.h: Rename include guard.
3932         * hppa-linux-offsets.h: Add include guard.
3933         * guile/guile.h: Rename include guard.
3934         * guile/guile-internal.h: Rename include guard.
3935         * gnu-nat.h: Rename include guard.
3936         * gdb-stabs.h: Rename include guard.
3937         * frv-tdep.h: Add include guard.
3938         * f-lang.h: Add include guard.
3939         * event-loop.h: Add include guard.
3940         * darwin-nat.h: Rename include guard.
3941         * cp-abi.h: Rename include guard.
3942         * config/sparc/nm-sol2.h: Rename include guard.
3943         * config/nm-nto.h: Rename include guard.
3944         * config/nm-linux.h: Add include guard.
3945         * config/i386/nm-i386gnu.h: Rename include guard.
3946         * config/djgpp/nl_types.h: Rename include guard.
3947         * config/djgpp/langinfo.h: Rename include guard.
3948         * compile/gcc-cp-plugin.h: Add include guard.
3949         * compile/gcc-c-plugin.h: Add include guard.
3950         * compile/compile.h: Rename include guard.
3951         * compile/compile-object-run.h: Rename include guard.
3952         * compile/compile-object-load.h: Rename include guard.
3953         * compile/compile-internal.h: Rename include guard.
3954         * compile/compile-cplus.h: Rename include guard.
3955         * compile/compile-c.h: Rename include guard.
3956         * common/xml-utils.h: Rename include guard.
3957         * common/x86-xstate.h: Rename include guard.
3958         * common/version.h: Rename include guard.
3959         * common/vec.h: Rename include guard.
3960         * common/tdesc.h: Rename include guard.
3961         * common/selftest.h: Rename include guard.
3962         * common/scoped_restore.h: Rename include guard.
3963         * common/scoped_mmap.h: Rename include guard.
3964         * common/scoped_fd.h: Rename include guard.
3965         * common/safe-iterator.h: Rename include guard.
3966         * common/run-time-clock.h: Rename include guard.
3967         * common/refcounted-object.h: Rename include guard.
3968         * common/queue.h: Rename include guard.
3969         * common/ptid.h: Rename include guard.
3970         * common/print-utils.h: Rename include guard.
3971         * common/preprocessor.h: Rename include guard.
3972         * common/pathstuff.h: Rename include guard.
3973         * common/observable.h: Rename include guard.
3974         * common/netstuff.h: Rename include guard.
3975         * common/job-control.h: Rename include guard.
3976         * common/host-defs.h: Rename include guard.
3977         * common/gdb_wait.h: Rename include guard.
3978         * common/gdb_vecs.h: Rename include guard.
3979         * common/gdb_unlinker.h: Rename include guard.
3980         * common/gdb_unique_ptr.h: Rename include guard.
3981         * common/gdb_tilde_expand.h: Rename include guard.
3982         * common/gdb_sys_time.h: Rename include guard.
3983         * common/gdb_string_view.h: Rename include guard.
3984         * common/gdb_splay_tree.h: Rename include guard.
3985         * common/gdb_setjmp.h: Rename include guard.
3986         * common/gdb_ref_ptr.h: Rename include guard.
3987         * common/gdb_optional.h: Rename include guard.
3988         * common/gdb_locale.h: Rename include guard.
3989         * common/gdb_assert.h: Rename include guard.
3990         * common/filtered-iterator.h: Rename include guard.
3991         * common/filestuff.h: Rename include guard.
3992         * common/fileio.h: Rename include guard.
3993         * common/environ.h: Rename include guard.
3994         * common/common-utils.h: Rename include guard.
3995         * common/common-types.h: Rename include guard.
3996         * common/common-regcache.h: Rename include guard.
3997         * common/common-inferior.h: Rename include guard.
3998         * common/common-gdbthread.h: Rename include guard.
3999         * common/common-exceptions.h: Rename include guard.
4000         * common/common-defs.h: Rename include guard.
4001         * common/common-debug.h: Rename include guard.
4002         * common/cleanups.h: Rename include guard.
4003         * common/buffer.h: Rename include guard.
4004         * common/btrace-common.h: Rename include guard.
4005         * common/break-common.h: Rename include guard.
4006         * cli/cli-utils.h: Rename include guard.
4007         * cli/cli-style.h: Rename include guard.
4008         * cli/cli-setshow.h: Rename include guard.
4009         * cli/cli-script.h: Rename include guard.
4010         * cli/cli-interp.h: Rename include guard.
4011         * cli/cli-decode.h: Rename include guard.
4012         * cli/cli-cmds.h: Rename include guard.
4013         * charset-list.h: Add include guard.
4014         * buildsym-legacy.h: Rename include guard.
4015         * bfin-tdep.h: Add include guard.
4016         * ax.h: Rename include guard.
4017         * arm-linux-tdep.h: Add include guard.
4018         * arm-fbsd-tdep.h: Add include guard.
4019         * arch/xtensa.h: Rename include guard.
4020         * arch/tic6x.h: Add include guard.
4021         * arch/i386.h: Add include guard.
4022         * arch/arm.h: Rename include guard.
4023         * arch/arm-linux.h: Rename include guard.
4024         * arch/arm-get-next-pcs.h: Rename include guard.
4025         * arch/amd64.h: Add include guard.
4026         * arch/aarch64-insn.h: Rename include guard.
4027         * arch-utils.h: Rename include guard.
4028         * annotate.h: Add include guard.
4029         * amd64-darwin-tdep.h: Rename include guard.
4030         * aarch64-linux-tdep.h: Add include guard.
4031         * aarch64-fbsd-tdep.h: Add include guard.
4032         * aarch32-linux-nat.h: Add include guard.
4033
4034 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4035
4036         * macrotab.c (macro_define_internal): New function that
4037         factorizes macro_define_object_internal and macro_define_function
4038         code.
4039         (macro_define_object_internal): Use macro_define_internal.
4040         (macro_define_function): Likewise.
4041
4042 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4043
4044         * macrocmd.c (extract_identifier): Return
4045         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4046         callers.
4047
4048 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4049
4050         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4051
4052 2019-02-05  Tom Tromey  <tom@tromey.com>
4053
4054         * target.c (target_stack::unpush): Move assertion earlier.
4055
4056 2019-01-30  Tom Tromey  <tom@tromey.com>
4057
4058         PR python/23615:
4059         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4060         (gdbpy_parse_and_eval): Likewise.
4061         * python/python-internal.h (gdbpy_allow_threads): New class.
4062
4063 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4064
4065         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4066         (aarch64_fbsd_fpregmap): Move earlier.
4067         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4068         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4069         instead of individual calls to trad_frame_set_reg_addr.
4070         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4071         earlier.
4072         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4073         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4074         instead of individual calls to trad_frame_set_reg_addr.
4075
4076 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4077
4078         * CONTRIBUTE: Replace contribution list with wiki link.
4079
4080 2019-01-25  Tom Tromey  <tom@tromey.com>
4081
4082         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4083
4084 2019-01-25  Tom Tromey  <tom@tromey.com>
4085
4086         * xtensa-linux-nat.c: Fix common/ includes.
4087         * xml-support.h: Fix common/ includes.
4088         * xml-support.c: Fix common/ includes.
4089         * x86-linux-nat.c: Fix common/ includes.
4090         * windows-nat.c: Fix common/ includes.
4091         * varobj.h: Fix common/ includes.
4092         * varobj.c: Fix common/ includes.
4093         * value.c: Fix common/ includes.
4094         * valops.c: Fix common/ includes.
4095         * utils.c: Fix common/ includes.
4096         * unittests/xml-utils-selftests.c: Fix common/ includes.
4097         * unittests/utils-selftests.c: Fix common/ includes.
4098         * unittests/unpack-selftests.c: Fix common/ includes.
4099         * unittests/tracepoint-selftests.c: Fix common/ includes.
4100         * unittests/style-selftests.c: Fix common/ includes.
4101         * unittests/string_view-selftests.c: Fix common/ includes.
4102         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4103         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4104         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4105         * unittests/rsp-low-selftests.c: Fix common/ includes.
4106         * unittests/parse-connection-spec-selftests.c: Fix common/
4107         includes.
4108         * unittests/optional-selftests.c: Fix common/ includes.
4109         * unittests/offset-type-selftests.c: Fix common/ includes.
4110         * unittests/observable-selftests.c: Fix common/ includes.
4111         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4112         * unittests/memrange-selftests.c: Fix common/ includes.
4113         * unittests/memory-map-selftests.c: Fix common/ includes.
4114         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4115         * unittests/function-view-selftests.c: Fix common/ includes.
4116         * unittests/environ-selftests.c: Fix common/ includes.
4117         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4118         * unittests/common-utils-selftests.c: Fix common/ includes.
4119         * unittests/cli-utils-selftests.c: Fix common/ includes.
4120         * unittests/array-view-selftests.c: Fix common/ includes.
4121         * ui-file.c: Fix common/ includes.
4122         * tui/tui-io.c: Fix common/ includes.
4123         * tracepoint.h: Fix common/ includes.
4124         * tracepoint.c: Fix common/ includes.
4125         * tracefile-tfile.c: Fix common/ includes.
4126         * top.h: Fix common/ includes.
4127         * top.c: Fix common/ includes.
4128         * thread.c: Fix common/ includes.
4129         * target/waitstatus.h: Fix common/ includes.
4130         * target/waitstatus.c: Fix common/ includes.
4131         * target.h: Fix common/ includes.
4132         * target.c: Fix common/ includes.
4133         * target-memory.c: Fix common/ includes.
4134         * target-descriptions.c: Fix common/ includes.
4135         * symtab.h: Fix common/ includes.
4136         * symfile.c: Fix common/ includes.
4137         * stap-probe.c: Fix common/ includes.
4138         * spu-linux-nat.c: Fix common/ includes.
4139         * sparc-nat.c: Fix common/ includes.
4140         * source.c: Fix common/ includes.
4141         * solib.c: Fix common/ includes.
4142         * solib-target.c: Fix common/ includes.
4143         * ser-unix.c: Fix common/ includes.
4144         * ser-tcp.c: Fix common/ includes.
4145         * ser-pipe.c: Fix common/ includes.
4146         * ser-base.c: Fix common/ includes.
4147         * selftest-arch.c: Fix common/ includes.
4148         * s12z-tdep.c: Fix common/ includes.
4149         * rust-exp.y: Fix common/ includes.
4150         * rs6000-aix-tdep.c: Fix common/ includes.
4151         * riscv-tdep.c: Fix common/ includes.
4152         * remote.c: Fix common/ includes.
4153         * remote-notif.h: Fix common/ includes.
4154         * remote-fileio.h: Fix common/ includes.
4155         * remote-fileio.c: Fix common/ includes.
4156         * regcache.h: Fix common/ includes.
4157         * regcache.c: Fix common/ includes.
4158         * record-btrace.c: Fix common/ includes.
4159         * python/python.c: Fix common/ includes.
4160         * python/py-type.c: Fix common/ includes.
4161         * python/py-inferior.c: Fix common/ includes.
4162         * progspace.h: Fix common/ includes.
4163         * producer.c: Fix common/ includes.
4164         * procfs.c: Fix common/ includes.
4165         * proc-api.c: Fix common/ includes.
4166         * printcmd.c: Fix common/ includes.
4167         * ppc-linux-nat.c: Fix common/ includes.
4168         * parser-defs.h: Fix common/ includes.
4169         * osdata.c: Fix common/ includes.
4170         * obsd-nat.c: Fix common/ includes.
4171         * nat/x86-linux.c: Fix common/ includes.
4172         * nat/x86-linux-dregs.c: Fix common/ includes.
4173         * nat/x86-dregs.h: Fix common/ includes.
4174         * nat/x86-dregs.c: Fix common/ includes.
4175         * nat/ppc-linux.c: Fix common/ includes.
4176         * nat/mips-linux-watch.h: Fix common/ includes.
4177         * nat/mips-linux-watch.c: Fix common/ includes.
4178         * nat/linux-waitpid.c: Fix common/ includes.
4179         * nat/linux-ptrace.h: Fix common/ includes.
4180         * nat/linux-ptrace.c: Fix common/ includes.
4181         * nat/linux-procfs.c: Fix common/ includes.
4182         * nat/linux-personality.c: Fix common/ includes.
4183         * nat/linux-osdata.c: Fix common/ includes.
4184         * nat/linux-namespaces.c: Fix common/ includes.
4185         * nat/linux-btrace.h: Fix common/ includes.
4186         * nat/linux-btrace.c: Fix common/ includes.
4187         * nat/fork-inferior.c: Fix common/ includes.
4188         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4189         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4190         * nat/aarch64-linux.c: Fix common/ includes.
4191         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4192         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4193         * namespace.h: Fix common/ includes.
4194         * mips-linux-tdep.c: Fix common/ includes.
4195         * minsyms.c: Fix common/ includes.
4196         * mi/mi-parse.h: Fix common/ includes.
4197         * mi/mi-main.c: Fix common/ includes.
4198         * mi/mi-cmd-env.c: Fix common/ includes.
4199         * memrange.h: Fix common/ includes.
4200         * memattr.c: Fix common/ includes.
4201         * maint.h: Fix common/ includes.
4202         * maint.c: Fix common/ includes.
4203         * main.c: Fix common/ includes.
4204         * machoread.c: Fix common/ includes.
4205         * location.c: Fix common/ includes.
4206         * linux-thread-db.c: Fix common/ includes.
4207         * linux-nat.c: Fix common/ includes.
4208         * linux-fork.c: Fix common/ includes.
4209         * inline-frame.c: Fix common/ includes.
4210         * infrun.c: Fix common/ includes.
4211         * inflow.c: Fix common/ includes.
4212         * inferior.h: Fix common/ includes.
4213         * inferior.c: Fix common/ includes.
4214         * infcmd.c: Fix common/ includes.
4215         * inf-ptrace.c: Fix common/ includes.
4216         * inf-child.c: Fix common/ includes.
4217         * ia64-linux-nat.c: Fix common/ includes.
4218         * i387-tdep.c: Fix common/ includes.
4219         * i386-tdep.c: Fix common/ includes.
4220         * i386-linux-tdep.c: Fix common/ includes.
4221         * i386-linux-nat.c: Fix common/ includes.
4222         * i386-go32-tdep.c: Fix common/ includes.
4223         * i386-fbsd-tdep.c: Fix common/ includes.
4224         * i386-fbsd-nat.c: Fix common/ includes.
4225         * guile/scm-type.c: Fix common/ includes.
4226         * guile/guile.c: Fix common/ includes.
4227         * go32-nat.c: Fix common/ includes.
4228         * gnu-nat.c: Fix common/ includes.
4229         * gdbthread.h: Fix common/ includes.
4230         * gdbarch-selftests.c: Fix common/ includes.
4231         * gdb_usleep.c: Fix common/ includes.
4232         * gdb_select.h: Fix common/ includes.
4233         * gdb_bfd.c: Fix common/ includes.
4234         * gcore.c: Fix common/ includes.
4235         * fork-child.c: Fix common/ includes.
4236         * findvar.c: Fix common/ includes.
4237         * fbsd-nat.c: Fix common/ includes.
4238         * event-top.c: Fix common/ includes.
4239         * event-loop.c: Fix common/ includes.
4240         * dwarf2read.c: Fix common/ includes.
4241         * dwarf2loc.c: Fix common/ includes.
4242         * dwarf2-frame.c: Fix common/ includes.
4243         * dwarf-index-cache.c: Fix common/ includes.
4244         * dtrace-probe.c: Fix common/ includes.
4245         * disasm-selftests.c: Fix common/ includes.
4246         * defs.h: Fix common/ includes.
4247         * csky-tdep.c: Fix common/ includes.
4248         * cp-valprint.c: Fix common/ includes.
4249         * cp-support.h: Fix common/ includes.
4250         * cp-support.c: Fix common/ includes.
4251         * corelow.c: Fix common/ includes.
4252         * completer.h: Fix common/ includes.
4253         * completer.c: Fix common/ includes.
4254         * compile/compile.c: Fix common/ includes.
4255         * compile/compile-loc2c.c: Fix common/ includes.
4256         * compile/compile-cplus-types.c: Fix common/ includes.
4257         * compile/compile-cplus-symbols.c: Fix common/ includes.
4258         * command.h: Fix common/ includes.
4259         * cli/cli-dump.c: Fix common/ includes.
4260         * cli/cli-cmds.c: Fix common/ includes.
4261         * charset.c: Fix common/ includes.
4262         * build-id.c: Fix common/ includes.
4263         * btrace.h: Fix common/ includes.
4264         * btrace.c: Fix common/ includes.
4265         * breakpoint.h: Fix common/ includes.
4266         * breakpoint.c: Fix common/ includes.
4267         * ax.h: 
4268         (enum agent_op): Fix common/ includes.
4269         * ax-general.c (struct aop_map): Fix common/ includes.
4270         * ax-gdb.c: Fix common/ includes.
4271         * auxv.c: Fix common/ includes.
4272         * auto-load.c: Fix common/ includes.
4273         * arm-tdep.c: Fix common/ includes.
4274         * arch/riscv.c: Fix common/ includes.
4275         * arch/ppc-linux-common.c: Fix common/ includes.
4276         * arch/i386.c: Fix common/ includes.
4277         * arch/arm.c: Fix common/ includes.
4278         * arch/arm-linux.c: Fix common/ includes.
4279         * arch/arm-get-next-pcs.c: Fix common/ includes.
4280         * arch/amd64.c: Fix common/ includes.
4281         * arch/aarch64.c: Fix common/ includes.
4282         * arch/aarch64-insn.c: Fix common/ includes.
4283         * arch-utils.c: Fix common/ includes.
4284         * amd64-windows-tdep.c: Fix common/ includes.
4285         * amd64-tdep.c: Fix common/ includes.
4286         * amd64-sol2-tdep.c: Fix common/ includes.
4287         * amd64-obsd-tdep.c: Fix common/ includes.
4288         * amd64-nbsd-tdep.c: Fix common/ includes.
4289         * amd64-linux-tdep.c: Fix common/ includes.
4290         * amd64-linux-nat.c: Fix common/ includes.
4291         * amd64-fbsd-tdep.c: Fix common/ includes.
4292         * amd64-fbsd-nat.c: Fix common/ includes.
4293         * amd64-dicos-tdep.c: Fix common/ includes.
4294         * amd64-darwin-tdep.c: Fix common/ includes.
4295         * agent.c: Fix common/ includes.
4296         * ada-lang.h: Fix common/ includes.
4297         * ada-lang.c: Fix common/ includes.
4298         * aarch64-tdep.c: Fix common/ includes.
4299
4300 2019-01-25  Tom Tromey  <tom@tromey.com>
4301
4302         * common/create-version.sh: Use common/version.h.
4303
4304 2019-01-24  Pedro Alves  <palves@redhat.com>
4305
4306         * infrun.c (signal_stop, signal_print, signal_program)
4307         (signal_catch, signal_pass): Now arrays instead of pointers.
4308         (update_signals_program_target, do_target_resume)
4309         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4310         * linux-nat.c (linux_nat_target::pass_signals)
4311         (linux_nat_target::create_inferior, linux_nat_target::attach):
4312         Adjust.
4313         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4314         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4315         * procfs.c (procfs_target::pass_signals): Adjust.
4316         * record-full.c (record_full_target::resume): Adjust.
4317         * remote.c (remote_target::pass_signals)
4318         (remote_target::program_signals): Adjust.
4319         * target-debug.h (target_debug_print_signals): Now takes a
4320         gdb::array_view as parameter.  Adjust.
4321         * target.h (target_ops) <pass_signals, program_signals>: Replace
4322         pointer and length parameters with gdb::array_view.
4323         (target_pass_signals, target_program_signals): Likewise.
4324         * target-delegates.c: Regenerate.
4325
4326 2019-01-24  Pedro Alves  <palves@redhat.com>
4327
4328         * common/forward-scope-exit.h
4329         (forward_scope_exit::forward_scope_exit): Pass arguments to
4330         m_bind_function directly, instead of creating a std::bind and
4331         copying that.
4332
4333 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4334
4335         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4336         for static members.
4337         (pass_in_v_vfp_candidate): Likewise.
4338
4339 2019-01-23  Tom Tromey  <tom@tromey.com>
4340             Pedro Alves  <palves@redhat.com>
4341
4342         * regcache.c (class regcache_invalidator): Remove.
4343         (regcache::raw_write): Use make_scope_exit.
4344
4345 2019-01-23  Tom Tromey  <tom@tromey.com>
4346
4347         * ui-out.h (class ui_out_emit_type): Update comment.
4348
4349 2019-01-23  Tom Tromey  <tom@tromey.com>
4350
4351         * infrun.c (fetch_inferior_event): Update comment.
4352
4353 2019-01-23  Tom Tromey  <tom@tromey.com>
4354             Pedro Alves  <palves@redhat.com>
4355
4356         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4357         parameter.
4358         (fetch_inferior_event): Use SCOPE_EXIT.
4359
4360
4361 2019-01-23  Tom Tromey  <tom@tromey.com>
4362             Pedro Alves  <palves@redhat.com>
4363
4364         * infrun.c (disable_thread_events): Delete.
4365         (stop_all_threads): Use SCOPE_EXIT.
4366
4367 2019-01-23  Tom Tromey  <tom@tromey.com>
4368             Pedro Alves  <palves@redhat.com>
4369
4370         * symfile.c: Include forward-scope-exit.h.
4371         (clear_symtab_users_cleanup): Replace forward declaration with
4372         a FORWARD_SCOPE_EXIT.
4373         (syms_from_objfile_1): Use the forward_scope_exit and
4374         gdb::optional instead of cleanup_function.
4375         (reread_symbols): Use the forward_scope_exit instead of
4376         cleanup_function.
4377         (clear_symtab_users_cleanup): Remove function.
4378
4379 2019-01-23  Tom Tromey  <tom@tromey.com>
4380             Pedro Alves  <palves@redhat.com>
4381
4382         * linux-nat.c: Include scope-exit.h.
4383         (cleanup_target_stop): Remove.
4384         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4385         SCOPE_EXIT.
4386
4387 2019-01-23  Tom Tromey  <tom@tromey.com>
4388             Pedro Alves  <palves@redhat.com>
4389
4390         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4391         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4392
4393 2019-01-23  Tom Tromey  <tom@tromey.com>
4394             Andrew Burgess  <andrew.burgess@embecosm.com>
4395             Pedro Alves  <palves@redhat.com>
4396
4397         * infrun.c (fetch_inferior_event): Use scope_exit.
4398         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4399         * top.c (execute_command): Use scope_exit.
4400         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4401         * utils.c (do_bpstat_clear_actions_cleanup)
4402         (make_bpstat_clear_actions_cleanup): Remove.
4403
4404 2019-01-23  Tom Tromey  <tom@tromey.com>
4405             Pedro Alves  <palves@redhat.com>
4406
4407         * infrun.c: Include "common/scope-exit.h"
4408         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4409         (wait_for_inferior): Use SCOPE_EXIT.
4410         (fetch_inferior_event): Use scope_exit.
4411
4412 2019-01-23  Tom Tromey  <tom@tromey.com>
4413             Pedro Alves  <palves@redhat.com>
4414
4415         * breakpoint.c (create_breakpoint): Remove cleanup.
4416
4417 2019-01-23  Tom Tromey  <tom@tromey.com>
4418             Andrew Burgess  <andrew.burgess@embecosm.com>
4419             Pedro Alves  <palves@redhat.com>
4420
4421 2019-01-23  Pedro Alves  <palves@redhat.com>
4422
4423         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4424
4425 2019-01-23  Pedro Alves  <palves@redhat.com>
4426             Andrew Burgess  <andrew.burgess@embecosm.com>
4427
4428         * gdbthread.h: Include "common/forward-scope-exit.h".
4429         (scoped_finish_thread_state): Redefine custom class in terms of
4430         forward_scope_exit.
4431
4432 2019-01-23  Pedro Alves  <palves@redhat.com>
4433             Andrew Burgess  <andrew.burgess@embecosm.com>
4434
4435         * common/forward-scope-exit.h: New file.
4436
4437 2019-01-23  Pedro Alves  <palves@redhat.com>
4438             Andrew Burgess  <andrew.burgess@embecosm.com>
4439             Tom Tromey  <tom@tromey.com>
4440
4441         * common/scope-exit.h: New file.
4442
4443 2019-01-23  Pedro Alves  <palves@redhat.com>
4444
4445         * common/preprocessor.h (ESC): Rename to ...
4446         (ESC_PARENS): ... this.
4447         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4448         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4449
4450 2019-01-23  Tom Tromey  <tom@tromey.com>
4451
4452         * language.h (class scoped_switch_to_sym_language_if_auto):
4453         Initialize m_lang in both cases.
4454
4455 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4456
4457         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4458         with XCNEW.
4459
4460 2019-01-22  Tom Tromey  <tom@tromey.com>
4461
4462         * corelow.c: Do not include sys/file.h.
4463
4464 2019-01-22  Tom Tromey  <tom@tromey.com>
4465
4466         * tui/tui-wingeneral.h: Include gdb_curses.h.
4467
4468 2019-01-22  Tom Tromey  <tom@tromey.com>
4469
4470         * source-cache.h (class source_cache) <get_source_lines,
4471         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4472
4473 2019-01-22  Tom Tromey  <tom@tromey.com>
4474
4475         * remote-fileio.h (struct remote_target): Declare.
4476
4477 2019-01-22  Tom Tromey  <tom@tromey.com>
4478
4479         * python/py-arch.c: Do not include py-ref.h.
4480         * python/py-bpevent.c: Do not include py-ref.h.
4481         * python/py-cmd.c: Do not include py-ref.h.
4482         * python/py-continueevent.c: Do not include py-ref.h.
4483         * python/py-event.h: Do not include py-ref.h.
4484         * python/py-evtregistry.c: Do not include py-ref.h.
4485         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4486         * python/py-frame.c: Do not include py-ref.h.
4487         * python/py-framefilter.c: Do not include py-ref.h.
4488         * python/py-function.c: Do not include py-ref.h.
4489         * python/py-infevents.c: Do not include py-ref.h.
4490         * python/py-linetable.c: Do not include py-ref.h.
4491         * python/py-objfile.c: Do not include py-ref.h.
4492         * python/py-param.c: Do not include py-ref.h.
4493         * python/py-prettyprint.c: Do not include py-ref.h.
4494         * python/py-progspace.c: Do not include py-ref.h.
4495         * python/py-symbol.c: Do not include py-ref.h.
4496         * python/py-symtab.c: Do not include py-ref.h.
4497         * python/py-type.c: Do not include py-ref.h.
4498         * python/py-unwind.c: Do not include py-ref.h.
4499         * python/py-utils.c: Do not include py-ref.h.
4500         * python/py-value.c: Do not include py-ref.h.
4501         * python/py-varobj.c: Do not include py-ref.h.
4502         * python/py-xmethods.c: Do not include py-ref.h.
4503         * python/python.c: Do not include py-ref.h.
4504         * varobj.c: Do not include py-ref.h.
4505
4506 2019-01-22  Tom Tromey  <tom@tromey.com>
4507
4508         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4509         keyword for bcache.
4510
4511 2019-01-22  Tom Tromey  <tom@tromey.com>
4512
4513         * compile/compile-cplus-types.c: Remove a comment by #include.
4514
4515 2019-01-22  Tom Tromey  <tom@tromey.com>
4516
4517         * compile/gcc-c-plugin.h: Include compile-internal.h.
4518
4519 2019-01-22  Tom Tromey  <tom@tromey.com>
4520
4521         * stabsread.c (EXTERN): Do not define.
4522         (symnum, next_symbol_text_func, processing_gcc_compilation)
4523         (within_function, global_sym_chain, global_stabs)
4524         (previous_stab_code, this_object_header_files)
4525         (n_this_object_header_files)
4526         (n_allocated_this_object_header_files): Define.
4527         * stabsread.h (EXTERN): Never define.  Use "extern".
4528
4529 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4530
4531         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4532         history_value.
4533
4534 2019-01-21  Tom Tromey  <tom@tromey.com>
4535
4536         * ui-out.c: Fix includes.
4537         * tui/tui-source.c: Fix includes.
4538         * target.c: Fix includes.
4539         * remote.c: Fix includes.
4540         * regcache.c: Fix includes.
4541         * python/py-block.c: Fix includes.
4542         * printcmd.c: Fix includes.
4543         * or1k-tdep.c: Fix includes.
4544         * mi/mi-main.c: Fix includes.
4545         * m32r-tdep.c: Fix includes.
4546         * csky-tdep.c: Fix includes.
4547         * compile/compile-cplus-types.c: Fix includes.
4548         * cli/cli-interp.c: Fix includes.
4549
4550 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4551
4552         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4553         for padding.
4554
4555 2019-01-16  Tom Tromey  <tom@tromey.com>
4556
4557         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4558         earlier.
4559         (struct objfile) <msymbols_range>: Move from top level.
4560         <msymbols>: New method.
4561         (class objfile_msymbols): Remove.
4562         * symtab.c (default_collect_symbol_completion_matches_break_on):
4563         Update.
4564         * symmisc.c (dump_msymbols): Update.
4565         * stabsread.c (scan_file_globals): Update.
4566         * objc-lang.c (info_selectors_command, info_classes_command)
4567         (find_methods): Update.
4568         * minsyms.c (find_solib_trampoline_target): Update.
4569         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4570         * coffread.c (coff_symfile_read): Update.
4571         * ada-lang.c (ada_lookup_simple_minsym)
4572         (ada_collect_symbol_completion_matches): Update.
4573
4574 2019-01-16  Tom Tromey  <tom@tromey.com>
4575
4576         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4577         type.  Remove no-argument constructor.
4578         <iterator::operator++>: Simplify.
4579         <begin>: Update.
4580         <end>: Use minimal_symbol_count.
4581
4582 2019-01-16  Tom Tromey  <tom@tromey.com>
4583
4584         * objfiles.h (struct objfile) <psymtabs>: New method.
4585         (class objfile_psymtabs): Remove.
4586         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
4587         typedef.
4588         <range>: New method.
4589         (require_partial_symbols): Change return type.
4590         * psymtab.c (require_partial_symbols)
4591         (psym_expand_symtabs_matching): Update.
4592         * mdebugread.c (parse_partial_symbols): Update.
4593         * dbxread.c (dbx_end_psymtab): Update.
4594
4595 2019-01-15  Tom Tromey  <tom@tromey.com>
4596
4597         * symtab.c (lookup_objfile_from_block)
4598         (lookup_symbol_in_objfile_symtabs)
4599         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
4600         (find_line_symtab, info_sources_command)
4601         (default_collect_symbol_completion_matches_break_on)
4602         (make_source_files_completion_list): Update.
4603         * symmisc.c (print_objfile_statistics, dump_objfile)
4604         (maintenance_print_symbols, maintenance_info_symtabs)
4605         (maintenance_check_symtabs, maintenance_info_line_tables):
4606         Update.
4607         * source.c (select_source_symtab)
4608         (forget_cached_source_info_for_objfile): Update.
4609         * objfiles.h (class objfile_compunits): Remove.
4610         (struct objfile) <compunits_range>: New typedef.
4611         (compunits): New method.
4612         * objfiles.c (objfile_relocate1): Update.
4613         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4614         * maint.c (count_symtabs_and_blocks): Update.
4615         * linespec.c (iterate_over_all_matching_symtabs): Update.
4616         * cp-support.c (add_symbol_overload_list_qualified): Update.
4617         * coffread.c (coff_symtab_read): Update.
4618         * ada-lang.c (add_nonlocal_symbols)
4619         (ada_collect_symbol_completion_matches)
4620         (ada_add_global_exceptions): Update.
4621
4622 2019-01-15  Tom Tromey  <tom@tromey.com>
4623
4624         * progspace.h (program_space) <objfiles_safe_range>: New
4625         typedef.
4626         <objfiles_safe>: New method.
4627         * objfiles.h (class all_objfiles_safe): Remove.
4628         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4629         * jit.c (jit_inferior_exit_hook): Update.
4630
4631 2019-01-17  Tom Tromey  <tom@tromey.com>
4632
4633         * progspace.h (program_space) <objfiles_range>: New typedef.
4634         <objfiles>: New method.
4635         <objfiles_head>: Rename from objfiles.
4636         (object_files): Update.
4637         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4638         * guile/scm-pretty-print.c
4639         (ppscm_find_pretty_printer_from_objfiles): Update.
4640         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4641         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4642         Update.
4643         * python/py-progspace.c (pspy_get_objfiles): Update.
4644         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4645         Update.
4646         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4647         (objfpy_lookup_objfile_by_build_id): Update.
4648         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4649         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4650         Update.
4651         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4652         (expand_symtab_containing_pc, lookup_objfile_from_block)
4653         (lookup_static_symbol, basic_lookup_transparent_type)
4654         (find_pc_sect_compunit_symtab, find_symbol_at_address)
4655         (find_line_symtab, info_sources_command)
4656         (default_collect_symbol_completion_matches_break_on)
4657         (make_source_files_completion_list, find_main_name): Update.
4658         * symmisc.c (print_symbol_bcache_statistics)
4659         (print_objfile_statistics, maintenance_print_symbols)
4660         (maintenance_print_msymbols, maintenance_print_objfiles)
4661         (maintenance_info_symtabs, maintenance_check_symtabs)
4662         (maintenance_expand_symtabs, maintenance_info_line_tables):
4663         Update.
4664         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
4665         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
4666         (map_overlay_command, unmap_overlay_command)
4667         (simple_overlay_update, expand_symtabs_matching)
4668         (map_symbol_filenames): Update.
4669         * symfile-debug.c (set_debug_symfile): Update.
4670         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
4671         Update.
4672         * source.c (select_source_symtab, forget_cached_source_info):
4673         Update.
4674         * solib.c (solib_read_symbols): Update.
4675         * solib-spu.c (append_ocl_sos): Update.
4676         * psymtab.c (maintenance_print_psymbols)
4677         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
4678         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
4679         * printcmd.c (info_symbol_command): Update.
4680         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
4681         Update.
4682         * objfiles.h (class all_objfiles): Remove.
4683         * objfiles.c (have_partial_symbols, have_full_symbols)
4684         (have_minimal_symbols, qsort_cmp, update_section_map)
4685         (shared_objfile_contains_address_p)
4686         (default_iterate_over_objfiles_in_search_order): Update.
4687         * objc-lang.c (info_selectors_command, info_classes_command)
4688         (find_methods): Update.
4689         * minsyms.c (find_solib_trampoline_target): Update.
4690         * maint.c (maintenance_info_sections)
4691         (maintenance_translate_address, count_symtabs_and_blocks):
4692         Update.
4693         * main.c (captured_main_1): Update.
4694         * linux-thread-db.c (try_thread_db_load_from_pdir)
4695         (has_libpthread): Update.
4696         * linespec.c (iterate_over_all_matching_symtabs)
4697         (search_minsyms_for_name): Update.
4698         * jit.c (jit_find_objf_with_entry_addr): Update.
4699         * hppa-tdep.c (find_unwind_entry)
4700         (hppa_lookup_stub_minimal_symbol): Update.
4701         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
4702         Update.
4703         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4704         (elf_gnu_ifunc_resolve_by_got): Update.
4705         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
4706         * dwarf-index-write.c (save_gdb_index_command): Update.
4707         * cp-support.c (add_symbol_overload_list_qualified): Update.
4708         * breakpoint.c (create_overlay_event_breakpoint)
4709         (create_longjmp_master_breakpoint)
4710         (create_std_terminate_master_breakpoint)
4711         (create_exception_master_breakpoint): Update.
4712         * blockframe.c (find_pc_partial_function): Update.
4713         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
4714         (ada_collect_symbol_completion_matches)
4715         (ada_add_global_exceptions): Update.
4716
4717 2019-01-17  Tom Tromey  <tom@tromey.com>
4718
4719         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
4720         declare VEC.
4721         (solib_target_parse_libraries): Change return type.
4722         (library_list_start_segment, library_list_start_section)
4723         (library_list_end_library, library_list_start_library); Update.
4724         (solib_target_free_library_list): Remove.
4725         (solib_target_parse_libraries): Remove cleanup.  Change return
4726         type.
4727         (solib_target_current_sos): Update.
4728
4729 2019-01-17  Tom Tromey  <tromey@bapiya>
4730
4731         * valprint.c: Replace "the the" with "the".
4732         * symtab.c: Replace "the the" with "the".
4733         * solib.c: Replace "the the" with "the".
4734         * solib-dsbt.c: Replace "the the" with "the".
4735         * linespec.c: Replace "the the" with "the".
4736         * dwarf2loc.h: Replace "the the" with "the".
4737         * amd64-windows-tdep.c: Replace "the the" with "the".
4738         * aarch64-tdep.c: Replace "the the" with "the".
4739
4740 2019-01-16  Keith Seitz  <keiths@redhat.com>
4741
4742         PR gdb/23773
4743         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
4744         <builder>: Rename to ..
4745         <m_builder>: ... this and make private.
4746         (dwarf2_cu::get_builder): New method.  Change all users of
4747         `builder' to use this method.
4748         (dwarf2_start_symtab): Move to ...
4749         (dwarf2_cu::start_symtab): ... here.  Update all callers
4750         (setup_type_unit_groups): Move to ...
4751         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
4752         callers.
4753         (dwarf2_cu::reset_builder): New method.
4754         (process_full_compunit, process_full_type_unit): Use
4755         dwarf2_cu::reset_builder.
4756         (follow_die_offset): Record the ancestor CU if it is different
4757         from the followed DIE's CU.
4758         (follow_die_sig_1): Likewise.
4759
4760 2019-01-15  Tom Tromey  <tom@tromey.com>
4761
4762         * remote.c (class remote_state) <buf>: Now a char_vector.
4763         <buf_size>: Remove.
4764         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
4765         parameter.
4766         (remote_target::getpkt_or_notif_sane_1)
4767         (remote_target::getpkt_sane)
4768         (remote_target::getpkt_or_notif_sane): Likewise.
4769         (class remote_target) <putpkt>: New overload.
4770         (remote_target::read_frame): Change type of "buf_p".  Remove
4771         sizeof_p parameter.
4772         (packet_ok): New overload.
4773         (packet_check_result): New overload.
4774         Update all uses.
4775
4776 2019-01-14  Tom Tromey  <tom@tromey.com>
4777
4778         * remote-notif.c (handle_notification, remote_notif_ack)
4779         (remote_notif_parse): Make "buf" const.
4780         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
4781         const.
4782         (remote_notif_parse, remote_notif_ack, handle_notification):
4783         Likewise.
4784         * remote.c (remote_notif_stop_parse): Make "buf" const.
4785         (remote_target::remote_parse_stop_reply): Make "buf" const.
4786         (remote_notif_stop_ack): Make "buf" const.
4787
4788 2019-01-14  Tom Tromey  <tom@tromey.com>
4789
4790         * remote.c (remote_console_output): Make parameter const.
4791
4792 2019-01-14  Tom Tromey  <tom@tromey.com>
4793
4794         * target-debug.h (target_debug_print_signals): Constify.
4795         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
4796         * procfs.c (procfs_target::pass_signals): Update.
4797         * linux-nat.c (linux_nat_target::pass_signals): Update.
4798         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
4799         * target-delegates.c: Rebuild.
4800         * remote.c (remote_target::program_signals): Update.
4801         (remote_target::pass_signals): Update.
4802         * target.c (target_pass_signals): Constify argument.
4803         (target_program_signals): Likewise.
4804         * target.h (struct target_ops) <pass_signals, program_signals>:
4805         Constify argument.
4806         (target_pass_signals, target_program_signals): Constify argument.
4807
4808 2019-01-14  Tom Tromey  <tom@tromey.com>
4809
4810         PR tui/28819:
4811         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
4812
4813 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4814
4815         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
4816         field.
4817         * rs6000-tdep.c: Include reggroups.h.
4818         (IS_V_ALIAS_PSEUDOREG): Define.
4819         (rs6000_register_name): Return names for the "vX" aliases.
4820         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
4821         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
4822         aliases.  Call default_register_reggroup_p for all other
4823         pseudo-registers.
4824         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
4825         New functions.
4826         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
4827         Handle "vX" aliases.
4828         (v_alias_pseudo_register_collect): New function.
4829         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
4830         (rs6000_gdbarch_init): Initialize "vX" aliases as
4831         pseudo-registers.  Restore registration of
4832         rs6000_pseudo_register_reggroup_p with
4833         set_tdesc_pseudo_register_reggroup_p.
4834
4835 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
4836
4837         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
4838         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
4839         set_gdbarch_num_pseudo_regs.
4840
4841 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4842
4843         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
4844         Remove arg prefixname, add do_set and do_show.
4845         Add member functions set_list and show_list.
4846         * cli/cli-style.c (class cli_style_option): Update accordingly.
4847         (style_set_list): Move to file scope.
4848         (style_show_list): Likewise.
4849         (set_style): Call help_list.
4850         (show_style): Call cmd_show_list.
4851         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
4852         Update to use the new macro.
4853
4854 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
4855
4856         * ada-lang.c (_initialize_ada_language): Expand the help text
4857         for the "catch exception" command.
4858
4859 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4860
4861         * symtab.c (matching_obj_sections): Initialize obj,
4862         declare it closer to its usage.
4863
4864 2019-01-10  Tom Tromey  <tom@tromey.com>
4865
4866         * thread-iter.h (inf_threads_iterator): Use next_iterator.
4867         (basic_inf_threads_range): Remove.
4868         (inf_threads_range, inf_non_exited_threads_range)
4869         (safe_inf_threads_range): Use next_adapter.
4870
4871 2019-01-10  Keith Seitz  <keiths@redhat.com>
4872
4873         PR gdb/23712
4874         PR symtab/23010
4875         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
4876         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
4877
4878 2019-01-10  Keith Seitz  <keiths@redhat.com>
4879
4880         PR gdb/23712
4881         PR symtab/23010
4882         * dictionary.c (pending_to_vector): Remove.
4883         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4884         Remove _1 suffix, replacing functions of the same name.  Update
4885         all callers.
4886         (dict_create_hashed, dict_create_hashed_expandable)
4887         (dict_create_linear, dict_create_linear_expandable, dict_free)
4888         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
4889         Make functions static.
4890
4891 2019-01-10  Keith Seitz  <keiths@redhat.com>
4892
4893         PR gdb/23712
4894         PR symtab/23010
4895         * dictionary.h (struct dictionary): Replace declaration with
4896         multidictionary.
4897         (dict_create_hashed, dict_create_hashed_expandable)
4898         (dict_create_linear, dict_create_linear_expandable)
4899         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
4900         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
4901         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
4902         taking multidictionary argument.
4903         [ALL_DICT_SYMBOLS]: Update for multidictionary.
4904         * block.h (struct block) <dict>: Change to multidictionary
4905         and rename `multidict'.
4906         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
4907         symmisc.c: Update all dictionary references to multidictionary.
4908
4909 2019-01-10  Keith Seitz  <keiths@redhat.com>
4910
4911         PR gdb/23712
4912         PR symtab/23010
4913         * dictionary.c: Include unordered_map.
4914         (pending_to_vector): New function.
4915         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4916         Rewrite the non-"_1" functions to take vector instead
4917         of linked list.
4918         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
4919         "new" _1 versions of the same name.
4920         (multidictionary): Define.
4921         (std::hash<enum language): New definition.
4922         (collate_pending_symbols_by_language, mdict_create_hashed)
4923         (mdict_create_hashed_expandable, mdict_create_linear)
4924         (mdict_create_linear_expandable, mdict_free)
4925         (find_language_dictionary, create_new_language_dictionary)
4926         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
4927         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
4928         (mdict_size, mdict_empty): New functions.
4929         * dictionary.h (mdict_iterator): Define.
4930
4931 2019-01-10  Pedro Alves  <palves@redhat.com>
4932
4933         * breakpoint.c (read_uploaded_action)
4934         (create_tracepoint_from_upload): Adjust to use
4935         gdb::unique_xmalloc_ptr.
4936         * ctf.c (ctf_write_uploaded_tp):
4937         (SET_ARRAY_FIELD): Use emplace_back.
4938         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
4939         * tracefile-tfile.c (tfile_write_uploaded_tp):
4940         * tracepoint.c (parse_tracepoint_definition): Adjust to use
4941         gdb::unique_xmalloc_ptr.
4942         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
4943         at_string, cond_string, cmd_strings>: Replace char pointers
4944         with gdb::unique_xmalloc_ptr.
4945
4946 2019-01-10  Pedro Alves  <palves@redhat.com>
4947
4948         * solib-target.c (library_list_start_library): Don't xstrdup name.
4949
4950 2019-01-10  Pedro Alves  <palves@redhat.com>
4951
4952         * mdebugread.c (parse_partial_symbols): Use
4953         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
4954
4955 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4956
4957         * linux-fork.c (scoped_switch_fork_info)
4958         <~scoped_switch_fork_info>: Fix incorrect variable name.
4959
4960 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4961
4962         * linux-fork.c (scoped_switch_fork_info)
4963         <scoped_switch_fork_info>: Make explicit.
4964         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
4965
4966 2019-01-10  Tom Tromey  <tom@tromey.com>
4967
4968         * objfiles.h (objfile::reset_psymtabs): Update.
4969         * objfiles.c (objfile::objfile): Update.
4970         * psymtab.h (psymtab_storage::obstack): Update.
4971         (psymtab_storage::m_obstack): Use gdb::optional.
4972         (class psymtab_storage): Update comment.  Remove objfile
4973         parameter.
4974         * psymtab.c (psymtab_storage::psymtab_storage): Update.
4975
4976 2019-01-10  Tom Tromey  <tom@tromey.com>
4977
4978         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
4979         <free_psymtabs>: Now private.
4980         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
4981         (allocate_psymtab): Use new method.
4982
4983 2019-01-10  Tom Tromey  <tom@tromey.com>
4984
4985         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
4986         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
4987         * mdebugread.c (parse_partial_symbols): Use
4988         allocate_dependencies.
4989         * dwarf2read.c (dwarf2_create_include_psymtab): Use
4990         allocate_dependencies.
4991         (process_psymtab_comp_unit_reader)
4992         (build_type_psymtab_dependencies): Likewise.
4993         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
4994
4995 2019-01-10  Tom Tromey  <tom@tromey.com>
4996
4997         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
4998         PSYMBOL_SET_LANGUAGE.
4999         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5000
5001 2019-01-10  Tom Tromey  <tom@tromey.com>
5002
5003         * psymtab.h (psymtab_storage::obstack): New method.
5004         <m_obstack>: Rename from obstack; now private.
5005         * psymtab.c (psymtab_storage): Update.
5006         * dwarf2read.c (create_addrmap_from_index)
5007         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5008         Update.
5009
5010 2019-01-10  Tom Tromey  <tom@tromey.com>
5011
5012         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5013         * objfiles.h (objfile::reset_psymtabs): New method.
5014
5015 2019-01-10  Tom Tromey  <tom@tromey.com>
5016
5017         * symmisc.c (print_symbol_bcache_statistics): Update.
5018         (print_objfile_statistics): Update.
5019         * symfile.c (reread_symbols): Update.
5020         * psymtab.h (class psymtab_storage): New.
5021         * psymtab.c (psymtab_storage): New constructor.
5022         (~psymtab_storage): New destructor.
5023         (require_partial_symbols): Update.
5024         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5025         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5026         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5027         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5028         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5029         (start_psymtab_common, end_psymtab_common)
5030         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5031         (allocate_psymtab): Update.
5032         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5033         Update.
5034         (dump_psymtab_addrmap, maintenance_print_psymbols)
5035         (maintenance_check_psymtabs): Update.
5036         (class objfile_psymtabs): Move to objfiles.h.
5037         * psympriv.h (discard_psymtab): Now inline.
5038         (psymtab_discarder::psymtab_discarder): Update.
5039         (psymtab_discarder::~psymtab_discarder): Update.
5040         (ALL_OBJFILE_PSYMTABS): Rewrite.
5041         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5042         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5043         Remove fields.
5044         <partial_symtabs>: New field.
5045         (class objfile_psymtabs): Move from psymtab.h.  Update.
5046         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5047         psymbol_cache.
5048         (objfile::~objfile): Don't destroy psymbol_cache.
5049         * mdebugread.c (parse_partial_symbols): Update.
5050         * dwarf2read.c (create_addrmap_from_index)
5051         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5052         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5053         (add_partial_subprogram, dwarf2_ranges_read): Update.
5054         * dwarf-index-write.c (write_address_map)
5055         (write_one_signatured_type, recursively_write_psymbols)
5056         (class debug_names, class debug_names, write_psymtabs_to_index):
5057         Update.
5058
5059 2019-01-10  Tom Tromey  <tom@tromey.com>
5060
5061         * symtab.h (SYMBOL_SET_NAMES): Update.
5062         (symbol_set_names): Update.
5063         (MSYMBOL_SET_NAMES): Update.
5064         * symtab.c (symbol_set_names): Change argument to be an
5065         objfile_per_bfd_storage.
5066         * psymtab.c (add_psymbol_to_bcache): Update.
5067         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5068
5069 2019-01-10  Tom Tromey  <tom@tromey.com>
5070
5071         * symtab.c (create_demangled_names_hash): Change argument to be an
5072         objfile_per_bfd_storage.
5073         (symbol_set_names): Update.
5074
5075 2019-01-10  Tom Tromey  <tom@tromey.com>
5076
5077         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5078         init_psymbol_list.
5079         * psymtab.c (init_psymbol_list): Do nothing if already called.
5080         * psympriv.h (init_psymbol_list): Add comment.
5081         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5082         init_psymbol_list.
5083         * dbxread.c (dbx_symfile_read): Unconditionally call
5084         init_psymbol_list.
5085
5086 2019-01-10  Tom Tromey  <tom@tromey.com>
5087
5088         * xcoffread.c (scan_xcoff_symtab): Update.
5089         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5090         "where".
5091         * mdebugread.c (parse_partial_symbols)
5092         (handle_psymbol_enumerators): Update.
5093         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5094         * dbxread.c (read_dbx_symtab): Update.
5095         * psympriv.h (psymbol_placement): New enum.
5096         (add_psymbol_to_list): Update.
5097
5098 2019-01-10  Tom Tromey  <tom@tromey.com>
5099
5100         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5101         static_psymbols parameters.
5102         (scan_xcoff_symtab): Update.
5103         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5104         static_psymbols parameters.
5105         * psympriv.h (start_psymtab_common): Update.
5106         * mdebugread.c (parse_partial_symbols): Update.
5107         * dwarf2read.c (create_partial_symtab): Update.
5108         * dbxread.c (read_dbx_symtab): Update.
5109         (start_psymtab): Remove global_psymbols and static_psymbols
5110         parameters.
5111
5112 2019-01-10  Tom Tromey  <tom@tromey.com>
5113
5114         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5115         * psymtab.c (allocate_psymtab): Add comment.
5116         * psympriv.h (allocate_psymtab): Add comment.
5117         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5118         initializations.
5119         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5120
5121 2019-01-10  Tom Tromey  <tom@tromey.com>
5122
5123         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5124         Don't declare.
5125         * mipsread.c: Include mdebugread.h.
5126         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5127         Declare.
5128         * elfread.c: Include mdebugread.h.
5129
5130 2019-01-09  Tom Tromey  <tom@tromey.com>
5131
5132         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5133         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5134         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5135         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5136         (psym_lookup_symbol, psym_find_last_source_symtab)
5137         (psym_forget_cached_source_info, psym_print_stats)
5138         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5139         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5140         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5141         (psym_find_compunit_symtab_by_address)
5142         (maintenance_print_psymbols, maintenance_info_psymtabs)
5143         (maintenance_check_psymtabs): Use ranged for.
5144         * psymtab.h (class objfile_psymtabs): New.
5145         (require_partial_symbols): Return objfile_psymtabs.
5146         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5147
5148 2019-01-09  Tom Tromey  <tom@tromey.com>
5149
5150         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5151         (find_pc_mapped_section, list_overlays_command)
5152         (map_overlay_command, unmap_overlay_command)
5153         (simple_overlay_update): Use all_objfiles.
5154         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5155         * printcmd.c (info_symbol_command): Use all_objfiles.
5156         * objfiles.h (ALL_OBJSECTIONS): Remove.
5157         * maint.c (maintenance_translate_address): Use all_objfiles.
5158         * gcore.c (gcore_create_callback): Use all_objfiles.
5159         (objfile_find_memory_regions): Likewise.
5160
5161 2019-01-09  Tom Tromey  <tom@tromey.com>
5162
5163         * symtab.c (find_line_symtab, info_sources_command)
5164         (make_source_files_completion_list): Use objfile_compunits.
5165         * source.c (select_source_symtab): Use objfile_compunits.
5166         * objfiles.h (struct objfile): Update comment.
5167         (ALL_OBJFILES): Remove.
5168         (ALL_FILETABS): Remove.
5169         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5170         objfile_compunits.
5171
5172 2019-01-09  Tom Tromey  <tom@tromey.com>
5173
5174         * symmisc.c (print_objfile_statistics, dump_objfile)
5175         (maintenance_print_symbols): Use compunit_filetabs.
5176         * source.c (forget_cached_source_info_for_objfile): Use
5177         compunit_filetabs.
5178         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5179         (ALL_FILETABS): Use compunit_filetabs.
5180         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5181         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5182
5183 2019-01-09  Tom Tromey  <tom@tromey.com>
5184
5185         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5186         (compunit_filetabs): New.
5187         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5188         compunit_filetabs.
5189         (info_sources_command, make_source_files_completion_list): Remove
5190         declaration.
5191         * symmisc.c (print_objfile_statistics, dump_objfile)
5192         (maintenance_print_symbols): Remove declaration.
5193         (maintenance_info_symtabs): Use compunit_filetabs.
5194         (maintenance_info_line_tables): Likewise.
5195         * source.c (select_source_symtab): Change local variable name.
5196         (forget_cached_source_info_for_objfile): Remove declaration.
5197         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5198         * objfiles.c (objfile_relocate1): Remove declaration.
5199         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5200         declaration.
5201         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5202         * coffread.c (coff_symtab_read): Remove declaration.
5203         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5204         compunit_filetabs.
5205
5206 2019-01-09  Tom Tromey  <tom@tromey.com>
5207
5208         * symtab.c (lookup_objfile_from_block)
5209         (find_pc_sect_compunit_symtab, search_symbols)
5210         (default_collect_symbol_completion_matches_break_on): Use
5211         objfile_compunits.
5212         * objfiles.h (ALL_COMPUNITS): Remove.
5213         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5214         * cp-support.c (add_symbol_overload_list_qualified): Use
5215         objfile_compunits.
5216         * ada-lang.c (ada_collect_symbol_completion_matches)
5217         (ada_add_global_exceptions): Use objfile_compunits.
5218
5219 2019-01-09  Tom Tromey  <tom@tromey.com>
5220
5221         * source.c (select_source_symtab)
5222         (forget_cached_source_info_for_objfile): Remove declaration.
5223         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5224         declaration.
5225         * maint.c (count_symtabs_and_blocks): Remove declaration.
5226         * cp-support.c (add_symbol_overload_list_qualified): Remove
5227         declaration.
5228         * coffread.c (coff_symtab_read): Remove declaration.
5229         * symtab.c (lookup_symbol_in_objfile_symtabs)
5230         (basic_lookup_transparent_type_1): Use objfile_compunits.
5231         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5232         (info_sources_command, search_symbols)
5233         (default_collect_symbol_completion_matches_break_on)
5234         (make_source_files_completion_list): Remove declaration.
5235         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5236         (ada_collect_symbol_completion_matches)
5237         (ada_add_global_exceptions): Remove declaration.
5238         * linespec.c (iterate_over_all_matching_symtabs): Use
5239         objfile_compunits.
5240         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5241         (class objfile_compunits): New.
5242         (ALL_COMPUNITS): Use objfile_compunits.
5243         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5244         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5245         objfile_compunits.
5246         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5247
5248 2019-01-09  Tom Tromey  <tom@tromey.com>
5249
5250         * symtab.c (search_symbols)
5251         (default_collect_symbol_completion_matches_break_on): Use
5252         objfile_msymbols.
5253         * ada-lang.c (ada_lookup_simple_minsym)
5254         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5255         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5256         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5257         objfile_msymbols.
5258         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5259         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5260         * objc-lang.c (find_methods): Use objfile_msymbols.
5261         (info_selectors_command, info_classes_command): Likewise.
5262         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5263         * objfiles.h (class objfile_msymbols): New.
5264         (ALL_OBJFILE_MSYMBOLS): Remove.
5265         (ALL_MSYMBOLS): Remove.
5266
5267 2019-01-09  Tom Tromey  <tom@tromey.com>
5268
5269         * common/next-iterator.h (next_adapter): Add Iterator template
5270         parameter.
5271         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5272         (class all_objfiles_safe): New.
5273         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5274         * objfiles.c (put_objfile_before): Update comment.
5275         (add_separate_debug_objfile): Likewise.
5276         (free_all_objfiles): Use all_objfiles_safe.
5277         (objfile_purge_solibs): Likewise.
5278
5279 2019-01-09  Tom Tromey  <tom@tromey.com>
5280
5281         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5282         (expand_symtab_containing_pc, lookup_static_symbol)
5283         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5284         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5285         all_objfiles.
5286         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5287         * breakpoint.c (create_overlay_event_breakpoint)
5288         (create_longjmp_master_breakpoint)
5289         (create_std_terminate_master_breakpoint)
5290         (create_exception_master_breakpoint): Use all_objfiles.
5291         * linux-thread-db.c (try_thread_db_load_from_pdir)
5292         (has_libpthread): Use all_objfiles.
5293         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5294         * linespec.c (iterate_over_all_matching_symtabs)
5295         (search_minsyms_for_name): Use all_objfiles.
5296         * maint.c (maintenance_info_sections): Use all_objfiles.
5297         * main.c (captured_main_1): Use all_objfiles.
5298         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5299         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5300         * guile/scm-pretty-print.c
5301         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5302         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5303         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5304         (maintenance_print_msymbols): Use all_objfiles.
5305         * source.c (select_source_symtab): Use all_objfiles.
5306         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5307         * symfile.c (remove_symbol_file_command)
5308         (expand_symtabs_matching, map_symbol_filenames): Use
5309         all_objfiles.
5310         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5311         all_objfiles.
5312         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5313         * objc-lang.c (find_methods): Use all_objfiles.
5314         * objfiles.c (have_partial_symbols, have_full_symbols)
5315         (have_minimal_symbols, qsort_cmp)
5316         (default_iterate_over_objfiles_in_search_order): Use
5317         all_objfiles.
5318         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5319         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5320         (maintenance_check_psymtabs): Use all_objfiles.
5321         (ALL_PSYMTABS): Remove.
5322         * compile/compile-object-run.c (do_module_cleanup): Use
5323         all_objfiles.
5324         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5325         * cp-support.c (add_symbol_overload_list_qualified): Use
5326         all_objfiles.
5327         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5328         Use all_objfiles.
5329         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5330         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5331         all_objfiles.
5332         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5333         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5334         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5335         Uses all_objfiles.
5336         * solib.c (solib_read_symbols): Use all_objfiles
5337
5338 2019-01-09  Tom Tromey  <tom@tromey.com>
5339
5340         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5341         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5342         all_objfiles.
5343         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5344         * symmisc.c (print_symbol_bcache_statistics)
5345         (print_objfile_statistics, maintenance_print_objfiles)
5346         (maintenance_info_symtabs, maintenance_check_symtabs)
5347         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5348         all_objfiles.
5349         * source.c (forget_cached_source_info): Use all_objfiles.
5350         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5351         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5352         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5353         * objfiles.c (update_section_map): Use all_objfiles.
5354         (shared_objfile_contains_address_p): Likewise.
5355         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5356         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5357
5358 2019-01-09  Tom Tromey  <tom@tromey.com>
5359
5360         * common/next-iterator.h: New file.
5361         * objfiles.h (class all_objfiles): New.
5362         (struct objfile_iterator): New.
5363
5364 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5365
5366         * NEWS: Move the description of the changed "frame", "select-frame",
5367          and "info frame" commands to the Changed commands section.
5368
5369 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5370
5371         * gdbtypes.c (check_stub_method_group): Remove handling of old
5372         mangling schemes.
5373         * linespec.c (find_methods): Likewise.
5374         * stabsread.c (read_member_functions): Likewise.
5375         * valops.c (search_struct_method): Likewise.
5376         (value_struct_elt_for_reference): Likewise.
5377         * NEWS: Mention this change.
5378
5379 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5380
5381         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5382         print_source_lines.
5383         * source.c (print_source_lines_base): Update line number check.
5384         (print_source_lines): New function.
5385         (source_lines_range::source_lines_range): New function.
5386         * source.h (class source_lines_range): New class.
5387         (print_source_lines): New declaration.
5388
5389 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5390
5391         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5392
5393 2019-01-08  Tom Tromey  <tom@tromey.com>
5394             Simon Marchi  <simon.marchi@ericsson.com>
5395
5396         PR gdb/24060
5397         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5398         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5399         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5400         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5401         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5402         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5403
5404 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5405
5406         * source.c (select_source_symtab): Move header comment to
5407         declaration in source.h.
5408         (forget_cached_source_info_for_objfile): Likewise.
5409         (forget_cached_source_info): Likewise.
5410         (identify_source_line): Likewise.
5411         * source.h (identify_source_line): Move declaration from symtab.h
5412         and add comment from source.c
5413         (print_source_lines): Likewise.
5414         (forget_cached_source_info_for_objfile): Likewise.
5415         (forget_cached_source_info): Likewise.
5416         (select_source_symtab): Likewise.
5417         (enum print_source_lines_flag): Move definition from symtab.h.
5418         * symtab.h (identify_source_line): Move declaration to source.h.
5419         (print_source_lines): Likewise.
5420         (forget_cached_source_info_for_objfile): Likewise.
5421         (forget_cached_source_info): Likewise.
5422         (select_source_symtab): Likewise.
5423         (enum print_source_lines_flag): Move definition to source.h.
5424         * tui/tui-hooks.c: Add 'source.h' include.
5425
5426 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5427
5428         * source.c (print_source_lines_base): Handle requests to print
5429         reverse line number sequences, and guard against empty lines
5430         string.
5431
5432 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5433
5434         * source.c (print_source_lines_base): Fix skip of '\r' if next
5435         character is '\n'.
5436
5437 2019-01-06  Tom Tromey  <tom@tromey.com>
5438
5439         * c-exp.y (struct c_parse_state) <macro_original_text,
5440         expansion_obstack>: New member.
5441         (macro_original_text, expansion_obstack): Remove globals.
5442         (scan_macro_expansion, scanning_macro_expansion)
5443         (finished_macro_expansion): Update.
5444         (scan_macro_cleanup): Remove.
5445         (yylex, c_parse): Update.
5446
5447 2019-01-06  Tom Tromey  <tom@tromey.com>
5448
5449         * c-exp.y (struct c_parse_state) <strings>: New member.
5450         (operator_stoken): Update.
5451
5452 2019-01-06  Tom Tromey  <tom@tromey.com>
5453
5454         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5455         (union type_stack_elt) <typelist_val>: Now a pointer to
5456         std::vector.
5457         (type_stack_cleanup): Don't declare.
5458         (push_typelist): Update.
5459         * parse.c (pop_typelist): Return a std::vector.
5460         (push_typelist): Take a std::vector.
5461         (follow_types): Update.  Do not free args.
5462         (type_stack_cleanup): Remove.
5463         * c-exp.y (struct c_parse_state): New.
5464         (cpstate): New global.
5465         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5466         (nonempty_typelist): Update.
5467         (func_mod): Create a new vector.
5468         (c_parse): Create a c_parse_state.
5469         (check_parameter_typelist): Do not delete params.
5470         (function_method): Update.  Do not delete type_list.
5471
5472 2019-01-06  Tom Tromey  <tom@tromey.com>
5473
5474         PR gdb/28155:
5475         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5476         check_typedef.
5477         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5478         (print_return_value): Likewise.
5479
5480 2019-01-05  Tom Tromey  <tom@tromey.com>
5481
5482         * contrib/cleanup_check.py: Remove.
5483         * contrib/gcc-with-excheck: Remove.
5484         * contrib/exsummary.py: Remove.
5485         * contrib/excheck.py: Remove.
5486
5487 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5488
5489         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5490         NULL. Initialize tpprev to NULL instead of assigning it
5491         to NULL on the next statement.
5492         * windows-nat.c (windows_delete_thread): Remove check for
5493         main_thread_id before printing thread exit notifications.
5494         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5495         Remove thread ID check against main_thread_id.
5496         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5497         windows_delete_thread.
5498         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5499
5500 2019-01-04  Tom Tromey  <tom@tromey.com>
5501
5502         * compile/compile.c (_initialize_compile): Use upper case for
5503         metasyntactic variables.
5504         * symmisc.c (_initialize_symmisc): Use upper case for
5505         metasyntactic variables.
5506         * psymtab.c (_initialize_psymtab): Use upper case for
5507         metasyntactic variables.
5508         * demangle.c (demangle_command): Use upper case for metasyntactic
5509         variables.
5510         (_initialize_demangler): Likewise.
5511         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5512         variables.
5513
5514 2019-01-03  Tom Tromey  <tom@tromey.com>
5515
5516         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5517
5518 2019-01-03  Tom Tromey  <tom@tromey.com>
5519
5520         * python/py-symtab.c (salpy_str): Update.
5521         (struct salpy_sal_object) <symtab>: Now a PyObject.
5522         (salpy_dealloc): Update.
5523         (del_objfile_sal): Use gdbpy_ref.
5524
5525 2019-01-03  Tom Tromey  <tom@tromey.com>
5526
5527         * python/py-type.c (convert_field): Use new_reference.  Return
5528         gdbpy_ref.
5529         (make_fielditem): Return gdbpy_ref.
5530         (typy_fields): Update.
5531         (typy_getitem): Update.
5532         (field_name): Return gdbpy_ref.  Use new_reference.
5533         (typy_iterator_iternext): Update.
5534
5535 2019-01-03  Tom Tromey  <tom@tromey.com>
5536
5537         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5538
5539 2019-01-03  Tom Tromey  <tom@tromey.com>
5540
5541         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5542         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5543         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5544         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5545         (pspy_set_type_printers): Likewise.
5546         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5547         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5548         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5549         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5550         (objfpy_set_type_printers): Likewise.
5551
5552 2019-01-03  Tom Tromey  <tom@tromey.com>
5553
5554         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5555         (gdbpy_print_stack): Use gdbpy_err_fetch.
5556         * python/python-internal.h (class gdbpy_err_fetch): New class.
5557         (class gdbpy_enter) <m_error_type, m_error_value,
5558         m_error_traceback>: Remove.
5559         <m_error>: New member.
5560         (gdbpy_exception_to_string): Don't declare.
5561         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5562         * python/py-value.c (convert_value_from_python): Use
5563         gdbpy_err_fetch.
5564         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5565         gdbpy_exception_to_string.
5566         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5567         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5568         gdbpy_err_fetch.
5569
5570 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5571
5572         * linux-nat.c (delete_lwp_cleanup): Delete.
5573         (struct lwp_deleter): New struct.
5574         (lwp_info_up): New typedef.
5575         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5576         lwp_info_up.
5577
5578 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5579
5580         * linux-fork.c (class scoped_switch_fork_info): New class.
5581         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
5582
5583 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5584
5585         * valops.c (find_overload_match): Remove use of null_cleanup, and
5586         calls to do_cleanups.
5587
5588 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5589
5590         * compile/compile-cplus-types.c
5591         (compile_cplus_instance::decl_name): Handle changes to
5592         cp_func_name.
5593         * cp-support.c (cp_func_name): Update header comment, update
5594         return type.
5595         * cp-support.h (cp_func_name): Update return type in declaration.
5596         * valops.c (find_overload_match): Move temp_func local to top
5597         level of function and change its type.  Use temp_func to hold and
5598         delete temporary string obtained from cp_func_name.
5599
5600 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5601
5602         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
5603         gdb::char_vector, remove cleanup, and update uses of `msg`.
5604
5605 2019-01-03  Jim Wilson  <jimw@sifive.com>
5606
5607         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
5608
5609 2019-01-02  Tom Tromey  <tom@tromey.com>
5610
5611         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
5612         (tdesc_parse_xml): Remove cleanups.
5613         * target-descriptions.h (make_cleanup_free_target_description):
5614         Don't declare.
5615         (target_desc_deleter): New struct.
5616         (target_desc_up): New typedef.
5617         * target-descriptions.c (target_desc_deleter::operator()): Rename
5618         from free_target_description.
5619         (make_cleanup_free_target_description): Remove.
5620
5621 2019-01-02  Tom Tromey  <tom@tromey.com>
5622
5623         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
5624         constructor, destructor.
5625         (linespec_parser): Remove typedef.
5626         (~linespec_parser): Rename from linespec_parser_delete.
5627         (linespec_lex_to_end, linespec_complete_label)
5628         (linespec_complete): Update.
5629         (decode_line_full): Remove cleanups.
5630         (decode_line_1): Update.
5631
5632 2019-01-02  Tom Tromey  <tom@tromey.com>
5633
5634         * python/python-internal.h (inferior_to_inferior_object): Change
5635         return type.
5636         * python/py-exitedevent.c (create_exited_event_object): Update.
5637         * python/py-inferior.c (inferior_to_inferior_object): Return
5638         gdbpy_ref.
5639         (python_new_inferior, python_inferior_deleted)
5640         (thread_to_thread_object, delete_thread_object)
5641         (build_inferior_list, gdbpy_selected_inferior): Update.
5642         * python/py-infthread.c (create_thread_object): Update.  Also fail
5643         if inferior_to_inferior_object fails.
5644
5645 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5646
5647         * inferior.h (class inferior) <displaced_step_state>: New field.
5648         * infrun.h (struct displaced_step_state): Move here from
5649         infrun.c.  Initialize fields, add constructor.
5650         <inf>: Remove field.
5651         <reset>: New method.
5652         * infrun.c (struct displaced_step_inferior_state): Move to
5653         infrun.h.
5654         (displaced_step_inferior_states): Remove.
5655         (get_displaced_stepping_state): Adust.
5656         (displaced_step_in_progress_any_inferior): Adjust.
5657         (displaced_step_in_progress_thread): Adjust.
5658         (displaced_step_in_progress): Adjust.
5659         (add_displaced_stepping_state): Remove.
5660         (get_displaced_step_closure_by_addr): Adjust.
5661         (remove_displaced_stepping_state): Remove.
5662         (infrun_inferior_exit): Call displaced_step_state.reset.
5663         (use_displaced_stepping): Don't check for NULL.
5664         (displaced_step_prepare_throw): Call
5665         get_displaced_stepping_state.
5666         (displaced_step_fixup): Don't check for NULL.
5667         (prepare_for_detach): Don't check for NULL.
5668
5669 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5670
5671         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
5672          in case of call that did not complete.
5673
5674 2019-01-02  Andrey Utkin  <autkin@undo.io>
5675
5676         * symfile.c (find_separate_debug_file): Fix search of debug files for
5677         remote debuggee.
5678
5679 2019-01-02  Tom Tromey  <tom@tromey.com>
5680
5681         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
5682         indentation.
5683         * python/py-frame.c (frapy_older): Remove cast.
5684         (frapy_newer): Likewise.
5685         * python/py-breakpoint.c (local_setattro): Remove cast.
5686         * python/py-arch.c (archpy_name): Remove local variable.
5687         * python/py-type.c (gdbpy_lookup_type): Remove cast.
5688
5689 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
5690
5691         * unittests/basic_string_view/element_access/char/empty.cc:
5692         Fix year range in copyright header.
5693
5694 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5695
5696         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
5697         Delete.
5698         <operator==>: Update with for removed field.
5699         <hash>: Likewise.
5700         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
5701         <isa_features>: ...this.
5702         <abi_features>: New field.
5703         (riscv_isa_flen): Update comment.
5704         (riscv_abi_xlen): New declaration.
5705         (riscv_abi_flen): New declaration.
5706         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
5707         isa_features.
5708         (riscv_abi_xlen): New function.
5709         (riscv_isa_flen): Update to get answer from isa_features.
5710         (riscv_abi_flen): New function.
5711         (riscv_has_fp_abi): Update to get answer from abi_features.
5712         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
5713         xlen and flen.
5714         (riscv_call_info) <xlen, flen>: Update comment.
5715         (riscv_call_arg_struct): Remove invalid assertions
5716         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
5717         is removed.
5718         (riscv_gdbarch_init): Gather isa features and abi features
5719         separately, ensure both match on the gdbarch when reusing an old
5720         gdbarch.  Relax an error check to allow 32-bit abi float to run on
5721         a target with 64-bit float hardware.
5722
5723 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5724
5725         * source.c (search_command_helper): Stop reverse search
5726         when line 1 has been searched.
5727
5728 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5729
5730         * record-full.c (record_full_base_target::close): Rewrite
5731         record_full_core_buf_list free logic.
5732
5733 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5734
5735         * break-catch-syscall.c (print_one_catch_syscall): xfree
5736         the last text.
5737
5738 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5739
5740         * top.c (print_gdb_version): Update Copyright year in version
5741         message.
5742
5743 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5744
5745         Update copyright year range in all GDB files.
5746
5747 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
5748
5749         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
5750
5751 For older changes see ChangeLog-2018.
5752 \f
5753 Local Variables:
5754 mode: change-log
5755 left-margin: 8
5756 fill-column: 74
5757 version-control: never
5758 coding: utf-8
5759 End:
5760