gdb/ChangeLog

   1 2019-05-08  Tom Tromey  <tom@tromey.com>
   2
   3         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
   4         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
   5         on obstack.
   6         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
   7
   8 2019-05-08  Tom Tromey  <tom@tromey.com>
   9
  10         * mdebugread.c (basic_type_data): Change type.
  11         (basic_type, _initialize_mdebugread): Update.
  12
  13 2019-05-08  Tom Tromey  <tom@tromey.com>
  14
  15         * common/gdb_unique_ptr.h (struct noop_deleter): New.
  16
  17 2019-05-08  Tom Tromey  <tom@tromey.com>
  18
  19         * nto-tdep.c (nto_inferior_data_reg): Change type.
  20         (nto_inferior_data): Update.
  21         (nto_inferior_data_cleanup, nto_new_inferior_data)
  22         (_initialize_nto_tdep): Remove.
  23         * nto-tdep.h (struct nto_inferior_data): Add initializers.
  24
  25 2019-05-08  Tom Tromey  <tom@tromey.com>
  26
  27         * ada-lang.c (struct ada_inferior_data): Add initializers.
  28         (ada_inferior_data): Change type.
  29         (ada_inferior_data_cleanup): Remove.
  30         (get_ada_inferior_data, ada_inferior_exit)
  31         (struct ada_pspace_data): Add initializers, destructor.
  32         (ada_pspace_data_handle): Change type.
  33         (get_ada_pspace_data): Update.
  34         (ada_pspace_data_cleanup): Remove.
  35
  36 2019-05-08  Tom Tromey  <tom@tromey.com>
  37
  38         * coffread.c (struct coff_symfile_info): Add initializers.
  39         (coff_objfile_data_key): Move lower.  Change type.
  40         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
  41         Update.
  42         (coff_free_info): Remove.
  43
  44 2019-05-08  Tom Tromey  <tom@tromey.com>
  45
  46         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
  47         (fbsd_pspace_data_handle): Move lower.  Change type.
  48         (get_fbsd_pspace_data): Update.
  49         (fbsd_pspace_data_cleanup): Remove.
  50         (_initialize_fbsd_tdep): Update.
  51
  52 2019-05-08  Tom Tromey  <tom@tromey.com>
  53
  54         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
  55         (get_ada_tasks_pspace_data): Update.
  56         (ada_tasks_pspace_data_cleanup): Remove.
  57         (_initialize_tasks): Update.
  58         (ada_tasks_inferior_data_handle): Change type.
  59         (get_ada_tasks_inferior_data): Update.
  60         (ada_tasks_inferior_data_cleanup): Remove.
  61         (struct ada_tasks_pspace_data): Add initializers.
  62
  63 2019-05-08  Tom Tromey  <tom@tromey.com>
  64
  65         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
  66         * symfile-debug.c (debug_sym_get_probes): Change type.
  67         * stap-probe.c (handle_stap_probe):
  68         (stap_static_probe_ops::get_probes): Change type.
  69         * probe.h (class static_probe_ops) <get_probes>: Change type.
  70         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
  71         (parse_probes_in_pspace): Update.
  72         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
  73         Update.
  74         (any_static_probe_ops::get_probes): Change type.
  75         * elfread.c (elfread_data): New typedef.
  76         (probe_key): Change type.
  77         (elf_get_probes): Likewise.  Update.
  78         (probe_key_free): Remove.
  79         (_initialize_elfread): Update.
  80         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
  81         Change type.
  82         (dtrace_process_dof_probe, dtrace_process_dof)
  83         (dtrace_static_probe_ops::get_probe): Change type.
  84
  85 2019-05-08  Tom Tromey  <tom@tromey.com>
  86
  87         * xcoffread.c (struct xcoff_symfile_info): Rename from
  88         coff_symfile_info.  Add initializers.
  89         (xcoff_objfile_data_key): Move lower.  Change type.
  90         (XCOFF_DATA): Rewrite.
  91         (xcoff_free_info): Remove.
  92         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
  93         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
  94         (xcoff_initial_scan): Update.
  95
  96 2019-05-08  Tom Tromey  <tom@tromey.com>
  97
  98         * solib-svr4.c (struct svr4_info): Add initializers and
  99         destructor.
 100         <probes_table>: Now an htab_up.
 101         (solib_svr4_pspace_data): Change type.
 102         (free_probes_table): Simplify.
 103         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 104         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 105         (probes_table_remove_objfile_probes, register_solib_event_probe)
 106         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 107         (_initialize_svr4_solib): Update.
 108
 109 2019-05-08  Tom Tromey  <tom@tromey.com>
 110
 111         * remote.c (remote_pspace_data): Change type.
 112         (remote_pspace_data_cleanup): Remove.
 113         (get_remote_exec_file, set_pspace_remote_exec_file)
 114         (_initialize_remote): Update.
 115
 116 2019-05-08  Tom Tromey  <tom@tromey.com>
 117
 118         * breakpoint.c (breakpoint_objfile_key): Change type.
 119         (get_breakpoint_objfile_data): Update.
 120         (free_breakpoint_objfile_data): Remove.
 121         (_initialize_breakpoint): Update.
 122
 123 2019-05-08  Tom Tromey  <tom@tromey.com>
 124
 125         * linux-tdep.c (struct linux_info): Add initializers.
 126         (linux_inferior_data): Move.  Change type.
 127         (invalidate_linux_cache_inf): Update.
 128         (linux_inferior_data_cleanup): Remove.
 129         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 130
 131 2019-05-08  Tom Tromey  <tom@tromey.com>
 132
 133         * auxv.c (auxv_inferior_data): Move.  Change type.
 134         (auxv_inferior_data_cleanup): Remove.
 135         (invalidate_auxv_cache_inf): Rewrite.
 136         (get_auxv_inferior_data, _initialize_auxv): Update.
 137
 138 2019-05-08  Tom Tromey  <tom@tromey.com>
 139
 140         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 141         (symfile_debug_objfile_data_key): Change type.
 142         (symfile_debug_installed, debug_qf_has_symbols)
 143         (debug_qf_find_last_source_symtab)
 144         (debug_qf_forget_cached_source_info)
 145         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 146         (debug_qf_print_stats, debug_qf_dump)
 147         (debug_qf_expand_symtabs_for_function)
 148         (debug_qf_expand_all_symtabs)
 149         (debug_qf_expand_symtabs_with_fullname)
 150         (debug_qf_map_matching_symbols)
 151         (debug_qf_expand_symtabs_matching)
 152         (debug_qf_find_pc_sect_compunit_symtab)
 153         (debug_qf_map_symbol_filenames)
 154         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 155         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 156         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 157         (debug_sym_read_linetable, debug_sym_relocate): Update.
 158         (symfile_debug_free_objfile): Remove.
 159         (install_symfile_debug_logging, _initialize_symfile_debug):
 160         Update.
 161
 162 2019-05-08  Tom Tromey  <tom@tromey.com>
 163
 164         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 165         allocate_on_obstack.
 166         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 167         (get_dwarf2_per_objfile): Update.
 168         (set_dwarf2_per_objfile): Remove.
 169         (dwarf2_has_info, dwarf2_get_section_info): Update.
 170         (dwarf2_free_objfile): Remove.
 171         (_initialize_dwarf2_read): Update.
 172
 173 2019-05-08  Tom Tromey  <tom@tromey.com>
 174
 175         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 176         initializers.
 177         <unsupported_script_warning_printed,
 178         script_not_found_warning_printed>: Now bool.
 179         (auto_load_pspace_data): Change type.
 180         (~auto_load_pspace_info): Rename from
 181         auto_load_pspace_data_cleanup.
 182         (get_auto_load_pspace_data, init_loaded_scripts_info)
 183         (clear_section_scripts, maybe_print_unsupported_script_warning)
 184         (maybe_print_script_not_found_warning, _initialize_auto_load):
 185         Update.
 186
 187 2019-05-08  Tom Tromey  <tom@tromey.com>
 188
 189         * objfiles.c (objfile_pspace_info): Add destructor and
 190         initializers.
 191         (objfiles_pspace_data): Change type.
 192         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 193         (get_objfile_pspace_data): Update.
 194         (objfiles_bfd_data): Change type.
 195         (get_objfile_bfd_data): Update.
 196         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 197
 198 2019-05-08  Tom Tromey  <tom@tromey.com>
 199
 200         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 201         Change type.
 202         (get_catch_syscall_inferior_data): Update.
 203         (catch_syscall_inferior_data_cleanup): Remove.
 204         (_initialize_break_catch_syscall): Update.
 205
 206 2019-05-08  Tom Tromey  <tom@tromey.com>
 207
 208         * inflow.c (struct terminal_info): Add destructor and
 209         initializers.
 210         (inflow_inferior_data): Change type.
 211         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 212         (get_inflow_inferior_data, inflow_inferior_exit)
 213         (swap_terminal_info, _initialize_inflow): Update.
 214
 215 2019-05-08  Tom Tromey  <tom@tromey.com>
 216
 217         * target-dcache.c (target_dcache_cleanup): Remove.
 218         (target_dcache_aspace_key): Change type.
 219         (target_dcache_init_p, target_dcache_invalidate)
 220         (target_dcache_get, target_dcache_get_or_init)
 221         (_initialize_target_dcache): Update.
 222         * dcache.h (struct dcache_deleter): New.
 223
 224 2019-05-08  Tom Tromey  <tom@tromey.com>
 225
 226         * symtab.c (struct symbol_cache): Add destructor and
 227         initializers.
 228         (symbol_cache_key): Move.  Change type.
 229         (make_symbol_cache, free_symbol_cache): Remove.
 230         (get_symbol_cache): Update.
 231         (symbol_cache_cleanup): Remove.
 232         (ALL_PSPACES, symbol_cache_flush)
 233         (maintenance_print_symbol_cache)
 234         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 235         Update.
 236
 237 2019-05-08  Tom Tromey  <tom@tromey.com>
 238
 239         * symtab.c (struct main_info): Add destructor and initializers.
 240         (main_progspace_key): Move.  Change type.
 241         (get_main_info): Update.
 242         (main_info_cleanup): Remove.
 243         (_initialize_symtab): Update.
 244
 245 2019-05-08  Tom Tromey  <tom@tromey.com>
 246
 247         * registry.h (DECLARE_REGISTRY): Define the _key class.
 248
 249 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 250
 251         * NEWS: Merge two 'New commands' sections.
 252
 253 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 254
 255         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 256         parameter and use Ada language definition instead.
 257         (ada_val_print_ptr): Remove unused language parameter.
 258         (ada_val_print_num): Remove language parameter and use Ada language
 259         definition instead.
 260         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 261         parameter.
 262         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 263         parameter and use Ada language definition instead.
 264         (ada_val_print_1): Update all ada_val_print_xxx calls.
 265         Remove language parameter.
 266         (ada_val_print): Update ada_val_print_1 call.
 267
 268 2019-05-08  Tom Tromey  <tromey@adacore.com>
 269
 270         * remote.c (remote_hw_watchpoint_limit)
 271         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 272         Now static.
 273
 274 2019-05-08  Tom Tromey  <tromey@adacore.com>
 275
 276         * maint.c (_initialize_maint_cmds): Move initialization code to
 277         remote.c.
 278         (watchdog, show_watchdog): Move to remote.c.
 279         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 280         "watchdog" static.
 281         (_initialize_remote): Move initialization code from maint.c.
 282         * defs.h (watchdog): Don't declare.
 283
 284 2019-05-08  Tom Tromey  <tromey@adacore.com>
 285
 286         * tui/tui-interp.c: Include main.h.
 287         * interps.c: Include main.h.
 288         * main.h (interpreter_p): Declare.
 289         * defs.h (interpreter_p): Don't declare.
 290
 291 2019-05-08  Tom Tromey  <tromey@adacore.com>
 292
 293         * dwarf2loc.c: Include dwarf2read.h.
 294         * defs.h (read_unsigned_leb128): Don't declare.
 295         * dwarf2read.h (read_unsigned_leb128): Declare.
 296
 297 2019-05-08  Tom Tromey  <tromey@adacore.com>
 298
 299         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 300         method.
 301
 302 2019-05-08  Tom Tromey  <tromey@adacore.com>
 303
 304         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 305         when no wrap column is set.
 306
 307 2019-05-08  Tom Tromey  <tromey@adacore.com>
 308
 309         * c-lang.c (c_get_string): Handle non-C-style arrays.
 310
 311 2019-05-08  Tom Tromey  <tromey@adacore.com>
 312
 313         * typeprint.c (print_offset_data::update): Print the bit offset,
 314         not the number of bits remaining.
 315
 316 2019-05-08  Tom Tromey  <tromey@adacore.com>
 317
 318         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 319         padding at end of comment.
 320
 321 2019-05-08  Tom Tromey  <tromey@adacore.com>
 322
 323         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 324         Compare main types.
 325
 326 2019-05-06  Tom Tromey  <tom@tromey.com>
 327
 328         * common/scoped_mmap.c: Include common-defs.h.
 329         * common/scoped_mmap.h: Don't include config.h.
 330
 331 2019-05-04  Tom Tromey  <tom@tromey.com>
 332
 333         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 334         (struct aarch64_call_info): Add initializers.
 335         <si>: Now a std::vector.
 336         (pass_on_stack, aarch64_push_dummy_call): Update.
 337
 338 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 339             Tom Tromey  <tom@tromey.com>
 340
 341         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 342         (ppc_threads): Now a std::vector.  Now static.
 343         (hwdebug_find_thread_points_by_tid)
 344         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 345         Update.
 346
 347 2019-05-04  Tom Tromey  <tom@tromey.com>
 348
 349         * arc-tdep.c (arc_tdesc_init): Return bool.
 350
 351 2019-05-04  Tom Tromey  <tom@tromey.com>
 352
 353         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 354         Use gdb_assert_not_reached.
 355
 356 2019-05-04  Tom Tromey  <tom@tromey.com>
 357
 358         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 359         "false".
 360
 361 2019-05-04  Tom Tromey  <tom@tromey.com>
 362
 363         * arc-tdep.c (arc_tdesc_init): Use bool.
 364
 365 2019-05-04  Tom Tromey  <tom@tromey.com>
 366
 367         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 368
 369 2019-05-04  Tom Tromey  <tom@tromey.com>
 370
 371         * cli/cli-cmds.c (valid_command_p): Return bool.
 372
 373 2019-05-04  Tom Tromey  <tom@tromey.com>
 374
 375         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 376         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 377
 378 2019-05-04  Raul Tambre  <raul@tambre.ee>
 379
 380         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 381         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 382         operator for comparison.
 383
 384 2019-05-04  Tom Tromey  <tom@tromey.com>
 385
 386         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 387         (lookup_partial_symbol, print_partial_symbols)
 388         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 389         (psymbol_compare): Update.
 390         (add_psymbol_to_bcache): Clear the entire psymbol.
 391         (maintenance_check_psymtabs): Update.
 392         * psympriv.h (struct partial_symbol): Don't derive from
 393         general_symbol_info.
 394         <obj_section, unrelocated_address, address,
 395         set_unrelocated_address>: Update.
 396         <ginfo>: New member.
 397         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 398         (debug_names::write_psymbols): Update.
 399
 400 2019-05-04  Tom de Vries  <tdevries@suse.de>
 401
 402         * contrib/cc-with-tweaks.sh: Support -n arg.
 403
 404 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 405
 406         * corelow.c (core_target::detach): Ensure frame cache and
 407         register caches are cleared.
 408         inferior.c (exit_inferior_1): Likewise.
 409
 410 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 411             Tom Tromey  <tom@tromey.com>
 412
 413         * dictionary.c (collate_pending_symbols_by_language): Remove
 414         "struct" from foreach.
 415         * symtab.c (lookup_global_symbol_from_objfile)
 416         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 417         foreach.
 418         * ser-tcp.c (net_open): Remove "struct" from foreach.
 419         * objfiles.c (objfile_relocate, objfile_rebase)
 420         (objfile_has_symbols): Remove "struct" from foreach.
 421         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 422         from foreach.
 423         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 424         foreach.
 425         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 426         "struct" from foreach.
 427         * ada-lang.c (create_excep_cond_exprs)
 428         (ada_exception_catchpoint_cond_string): Remove "struct" from
 429         foreach.
 430
 431 2019-05-03  Tom Tromey  <tromey@adacore.com>
 432
 433         * ada-exp.y (convert_char_literal): Check suffix of each
 434         enumerator.
 435
 436 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 437
 438         PR ada/21406:
 439         * ada-exp.y (yywrap): Don't define.
 440         * ada-lex.l (%option): Add noyywrap
 441         (yywrap): Remove.
 442
 443 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 444
 445         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 446         _WIN32_WINNT to the XP level, unless already defined to a higher
 447         level.
 448
 449         * unittests/parse-connection-spec-selftests.c:
 450         * ser-tcp.c:
 451         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 452         override.
 453
 454         * symfile.c (find_separate_debug_file): Remove colon from the
 455         drive spec of DOS/Windows file names of the target, so that the
 456         file name produced from DEBUGDIR and the target's directory will
 457         be valid on DOS/Windows systems.
 458
 459 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 460
 461         * rust-lang.c (val_print_struct): Handle printing structures
 462         containing strings.
 463
 464 2019-05-02  Tom Tromey  <tromey@adacore.com>
 465
 466         * valarith.c (_initialize_valarith): Remove.
 467
 468 2019-05-01  Tom Tromey  <tromey@adacore.com>
 469
 470         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 471         bitfields.
 472
 473 2019-05-01  Tom Tromey  <tromey@adacore.com>
 474
 475         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 476         for big-endian copies.
 477
 478 2019-04-30  Ali Tamur  <tamur@google.com>
 479         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 480         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 481         (read_3_bytes): New function.
 482
 483 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 484
 485         * windows-nat.c (main_thread_id): Delete.
 486         (handle_output_debug_string): Replace main_thread_id by
 487         current_event.dwThreadId.
 488         (fake_create_process): Likewise.
 489         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 490         Do not set main_thread_id.
 491         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 492         current_event.dwThreadId.
 493         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 494
 495 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 496
 497         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 498         Use current_event.dwThreadId instead of main_thread_id.
 499
 500 2019-04-30  Tom Tromey  <tromey@adacore.com>
 501
 502         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 503         (create_excep_cond_exprs): Iterate over program spaces.
 504         (ada_exception_catchpoint_cond_string): Examine all minimal
 505         symbols for exception types.
 506
 507 2019-04-30  Tom Tromey  <tromey@adacore.com>
 508
 509         PR c++/24470:
 510         * dwarf2read.c (process_structure_scope): Handle case where type
 511         has template parameters but no symbol was created.
 512
 513 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 514             Chris January  <chris.january@arm.com>
 515
 516         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 517         qualifier.
 518         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 519
 520 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 521
 522         * f-typeprint.c (f_print_type): Update rules for printing
 523         whitespace.
 524         (f_type_print_varspec_suffix): Likewise.
 525
 526 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 527             Chris January  <chris.january@arm.com>
 528
 529         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 530         function arguments.
 531
 532 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 533
 534         * f-lang.c (build_fortran_types): Change name of void type to
 535         lower case.
 536         * f-typeprint.c (f_type_print_base): Print the name of the void
 537         type, rather than a fixed string.
 538         * f-valprint.c (f_decorations): Use lower case void string.
 539
 540 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 541             Chris January  <chris.january@arm.com>
 542
 543         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 544         types for Fortran.
 545
 546 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 547             Chris January  <chris.january@arm.com>
 548             David Lecomber  <david.lecomber@arm.com>
 549
 550         * f-exp.y (BINOP_INTRINSIC): New token.
 551         (exp): New parser rule handling BINOP_INTRINSIC.
 552         (f77_keywords): Add new builtin procedures.
 553         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 554         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 555         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 556         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 557         (print_unop_subexp_f): New function.
 558         (print_binop_subexp_f): New function.
 559         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 560         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 561         (dump_subexp_body_f): Likewise.
 562         (operator_check_f): Likewise.
 563         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 564         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 565
 566 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 567
 568         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 569         UNOP_KIND.
 570         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 571         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 572         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 573         (operator_length_f): New fuction.
 574         (print_subexp_f): New function.
 575         (op_name_f): New function.
 576         (dump_subexp_body_f): New function.
 577         (operator_check_f): New function.
 578         (exp_descriptor_f): Replace standard expression handling functions
 579         with new functions.
 580         * gdb/fortran-operator.def: New file.
 581         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 582         * gdb/std-operator.def: Remove UNOP_KIND.
 583
 584 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 585
 586         * std-operator.def: Remove unbalanced, stray double quote
 587         character.
 588
 589 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 590             Chris January  <chris.january@arm.com>
 591             Daniel Everett  <daniel.everett@arm.com>
 592             Nick Forrington  <nick.forrington@arm.com>
 593             Richard Bunt  <richard.bunt@arm.com>
 594
 595         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 596         of depth when printing anonymous structs or unions.
 597         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 598         Don't print either the top-level value, or the children if the
 599         max-depth is exceeded.
 600         (ppscm_print_children): When printing the key of a map, allow one
 601         extra level of depth.
 602         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 603         print either the top-level value, or the children if the max-depth
 604         is exceeded.
 605         (print_children): When printing the key of a map, allow one extra
 606         level of depth.
 607         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 608         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 609         (user_print_options): Initialise max_depth field.
 610         (val_print_scalar_or_string_type_p): New function.
 611         (val_print): Check to see if the max depth has been reached.
 612         (val_print_check_max_depth): Define new function.
 613         (show_print_max_depth): New function.
 614         (_initialize_valprint): Add 'print max-depth' option.
 615         * valprint.h (struct value_print_options) <max_depth>: New field.
 616         (val_print_check_max_depth): Declare new function.
 617         * NEWS: Document new feature.
 618
 619 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 620
 621         * ada-lang.c (ada_language_defn): Initialise new field.
 622         * c-lang.c (c_is_string_type_p): New function.
 623         (c_language_defn): Initialise new field.
 624         (cplus_language_defn): Initialise new field.
 625         (asm_language_defn): Initialise new field.
 626         (minimal_language_defn): Initialise new field.
 627         * c-lang.h (c_is_string_type_p): Declare new function.
 628         * d-lang.c (d_language_defn): Initialise new field.
 629         * f-lang.c (f_is_string_type_p): New function.
 630         (f_language_defn): Initialise new field.
 631         * go-lang.c (go_is_string_type_p): New function.
 632         (go_language_defn): Initialise new field.
 633         * language.c (default_is_string_type_p): New function.
 634         (unknown_language_defn): Initialise new field.
 635         (auto_language_defn): Initialise new field.
 636         * language.h (struct language_defn) <la_is_string_type_p>: New
 637         member variable.
 638         (default_is_string_type_p): Declare new function.
 639         * m2-lang.c (m2_language_defn): Initialise new field.
 640         * objc-lang.c (objc_language_defn): Initialise new field.
 641         * opencl-lang.c (opencl_language_defn): Initialise new field.
 642         * p-lang.c (pascal_is_string_type_p): New function.
 643         (pascal_language_defn): Initialise new field.
 644         * rust-lang.c (rust_is_string_type_p): New function.
 645         (rust_language_defn): Initialise new field.
 646
 647 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 648
 649         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 650         New field.
 651         * ada-lang.c (ada_language_defn): Initialise new field.
 652         * c-lang.c (c_language_defn): Likewise.
 653         (cplus_language_defn): Likewise.
 654         (asm_language_defn): Likewise.
 655         (minimal_language_defn): Likewise.
 656         * d-lang.c (d_language_defn): Likewise.
 657         * f-lang.c (f_language_defn): Likewise.
 658         * go-lang.c (go_language_defn): Likewise.
 659         * language.c (unknown_language_defn): Likewise.
 660         (auto_language_defn): Likewise.
 661         * m2-lang.c (m2_language_defn): Likewise.
 662         * objc-lang.c (objc_language_defn): Likewise.
 663         * opencl-lang.c (opencl_language_defn): Likewise.
 664         * p-lang.c (pascal_language_defn): Likewise.
 665         * rust-lang.c (rust_language_defn): Likewise.
 666
 667 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 668
 669         * ada-lang.c (ada_is_character_type): Change return type to bool.
 670         (ada_is_string_type): Likewise.
 671         * ada-lang.h (ada_is_character_type): Update declaration
 672         (ada_is_string_type): Likewise.
 673
 674 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 675
 676         Support style in 'frame|thread apply'
 677
 678         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 679         * record.c (record_start, record_stop): Update callers of
 680         execute_command_to_string with false.
 681         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 682         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 683         methods.
 684         (class string_file): New constructor with term_out parameter.
 685         Override methods term_out and can_emit_style_escape.  New member
 686         term_out.
 687         (class stdio_file): Override can_emit_style_escape.
 688         (class tee_file): Override term_out and can_emit_style_escape.
 689         * utils.h (can_emit_style_escape): Remove.
 690         * utils.c (can_emit_style_escape): Likewise.
 691         Update all callers of can_emit_style_escape (SOMESTREAM) to
 692         SOMESTREAM->can_emit_style_escape.
 693         * source-cache.c (source_cache::get_source_lines): Likewise.
 694         * stack.c (frame_apply_command_count): Call execute_command_to_string
 695         passing the term_out characteristic of the current gdb_stdout.
 696         * thread.c (thr_try_catch_cmd): Likewise.
 697         * top.c (execute_command_to_string): pass term_out parameter
 698         to construct the string_file for the command output.
 699         * ui-file.c (term_cli_styling): New function (most code moved
 700         from utils.c can_emit_style_escape).
 701         (string_file::string_file, string_file::can_emit_style_escape,
 702         stdio_file::can_emit_style_escape, tee_file::term_out,
 703         tee_file::can_emit_style_escape): New functions.
 704
 705 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 706
 707         * NEWS: Mention the new set|show may-call-functions.
 708         * infcall.c (may_call_functions_p): New variable.
 709         (show_may_call_functions_p): New function.
 710         (call_function_by_hand_dummy): Throws an error if not
 711         may-call-functions.
 712         (_initialize_infcall): Call add_setshow_boolean_cmd for
 713         may-call-functions.
 714
 715 2019-04-25  Keith Seitz  <keiths@redhat.com>
 716
 717         PR c++/24367
 718         * cp-support.c (inspect_type): Don't attempt substitutions
 719         of symbol with the same name.
 720
 721 2019-04-25  Tom Tromey  <tromey@adacore.com>
 722
 723         PR gdb/24475:
 724         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 725         static.
 726
 727 2019-04-25  Tom Tromey  <tromey@adacore.com>
 728
 729         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 730         rvalue reference.
 731         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 732         (gdb_xml_parser::parse): Use std::move.
 733         * python/python-internal.h (gdbpy_convert_exception): Take a const
 734         reference.
 735         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 736         std::move.
 737         * python/py-utils.c (gdbpy_convert_exception): Take a const
 738         reference.
 739         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 740         Use std::move.
 741         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 742         Use std::move.
 743         * mi/mi-main.c (mi_print_exception): Take a const reference.
 744         * main.c (handle_command_errors): Take a const reference.
 745         * linespec.c (parse_linespec): Use std::move.
 746         * infcall.c (run_inferior_call): Use std::move.
 747         (call_function_by_hand_dummy): Use std::move.
 748         * exec.c (try_open_exec_file): Use std::move.
 749         * exceptions.h (exception_print, exception_fprintf)
 750         (exception_print_same): Update.
 751         * exceptions.c (print_exception, exception_print)
 752         (exception_fprintf, exception_print_same): Change parameters to
 753         const reference.
 754         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 755         * common/new-op.c: Use std::move.
 756         * common/common-exceptions.h (struct gdb_exception): Add move
 757         constructor.
 758         (struct gdb_exception_error, struct gdb_exception_quit, struct
 759         gdb_quit_bad_alloc): Change constructor to move constructor.
 760         (throw_exception): Change parameter to rvalue reference.
 761         * common/common-exceptions.c (throw_exception): Take rvalue
 762         reference.
 763         * cli/cli-interp.c (safe_execute_command): Use std::move.
 764         * breakpoint.c (insert_bp_location, location_to_sals): Use
 765         std::move.
 766
 767 2019-04-25  Tom Tromey  <tromey@adacore.com>
 768
 769         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 770         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 771         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 772         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 773         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 774         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 775         guile/scm-value.c: Use unpack.
 776         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 777         gdbscm_gdb_exception.
 778         (gdbscm_throw_gdb_exception): Likewise.
 779         (struct gdbscm_gdb_exception): New.
 780         (unpack): New function.
 781         (gdbscm_wrap): Use unpack.
 782
 783 2019-04-25  Tom Tromey  <tromey@adacore.com>
 784
 785         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 786         (gdb_rl_callback_handler): Use std::move.
 787         * common/common-exceptions.h (struct gdb_exception): Add move
 788         assignment operator.
 789         (throw_exception_sjlj): Change "exception" to const reference.
 790         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 791         (throw_exception_sjlj): Change "exception" to const reference.
 792
 793 2019-04-25  Tom Tromey  <tromey@adacore.com>
 794
 795         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 796         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 797         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 798         Update.
 799         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 800         Update.
 801         * mi/mi-interp.c (mi_interp::exec): Update.
 802         * linespec.c (parse_linespec): Update.
 803         * infcall.c (run_inferior_call): Update.
 804         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 805         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 806         (gdbscm_lookup_global_symbol): Update.
 807         * guile/scm-param.c (gdbscm_parameter_value): Update.
 808         * guile/scm-frame.c (gdbscm_frame_read_register)
 809         (gdbscm_frame_read_var): Update.
 810         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 811         * exec.c (try_open_exec_file): Update.
 812         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 813         (gdb_rl_callback_handler): Update.
 814         * common/common-exceptions.h (exception_none): Don't declare.
 815         * common/common-exceptions.c (exception_none): Don't define.
 816         (struct catcher) <exception>: Update.
 817         * cli/cli-interp.c (safe_execute_command): Update.
 818         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 819
 820 2019-04-25  Ali Tamur  <tamur@google.com>
 821
 822         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 823         (read_attribute_value): Likewise.
 824         (dwarf2_read_addr_index): Update comment.
 825         (read_str_index): Add DW_FORM_strx.
 826         (dwarf2_string_attr): Likewise.
 827         (dwarf2_const_value_attr): Likewise.
 828         (dump_die_shallow): Likewise.
 829         (dwarf2_fetch_constant_bytes): Likewise.
 830         (skip_form_bytes): Likewise.
 831         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 832
 833 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 834
 835         PR corefiles/11608
 836         PR corefiles/18187
 837         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 838         OFFSET.  Verify if current mapping contains an ELF header.
 839         (linux_find_memory_regions_full): Adjust call to
 840         dump_mapping_p.
 841
 842 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 843             Kang Li <kanglictf@gmail.com>
 844
 845         PR gdb/21600
 846
 847         * dwarf2-frame.c (read_initial_length): Be consistent about using
 848         unsigned representation of length.
 849         (decode_frame_entry_1): Likewise.  Check for wraparound of
 850         end pointer as well as buffer overflow.
 851
 852 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 853
 854         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 855         "vq".
 856
 857 2019-04-24  Tom Tromey  <tromey@adacore.com>
 858
 859         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 860
 861 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 862
 863         * s12z-tdep.c (s12z_unwind_pc): Delete.
 864         (s12z_unwind_sp): Delete.
 865         (s12z_gdbarch_init): Don't register deleted functions with
 866         gdbarch.
 867
 868 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 869
 870         * rl78-tdep.c (rl78_unwind_sp): Delete.
 871         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 872
 873 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 874
 875         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 876         (xstormy16_unwind_pc): Delete.
 877         (xstormy16_dummy_id): Delete.
 878         (xstormy16_gdbarch_init): Don't register deleted functions with
 879         gdbarch.
 880
 881 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 882
 883         * vax-tdep.c (vax_unwind_pc): Delete.
 884         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 885
 886 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 887
 888         * v850-tdep.c (v850_unwind_sp): Delete.
 889         (v850_unwind_pc): Delete.
 890         (v850_dummy_id): Delete.
 891         (v850_gdbarch_init): Don't register deleted functions with
 892         gdbarch.
 893
 894 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 895
 896         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 897         (tilegx_unwind_pc): Delete.
 898         (tilegx_unwind_dummy_id): Delete.
 899         (tilegx_gdbarch_init): Don't register deleted functions with
 900         gdbarch.
 901
 902 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 903
 904         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 905         (tic6x_dummy_id): Delete.
 906         (tic6x_gdbarch_init): Don't register deleted functions with
 907         gdbarch.
 908
 909 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 910
 911         * sparc-tdep.c (sparc_unwind_pc): Delete.
 912         (sparc32_gdbarch_init): Don't register deleted function with
 913         gdbarch.
 914
 915 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 916
 917         * sh-tdep.c (sh_unwind_sp): Delete.
 918         (sh_unwind_pc): Delete.
 919         (sh_dummy_id): Delete.
 920         (sh_gdbarch_init): Don't register deleted functions with
 921         gdbarch.
 922
 923 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 924
 925         * score-tdep.c (score_unwind_sp): Delete.
 926         (score_unwind_pc): Delete.
 927         (score_dummy_id): Delete.
 928         (score_gdbarch_init): Don't register deleted functions with
 929         gdbarch.
 930
 931 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 932
 933         * rx-tdep.c (rx_unwind_pc): Delete.
 934         (rx_unwind_sp): Delete.
 935         (rx_dummy_id): Delete.
 936         (rx_gdbarch_init): Don't register deleted functions with
 937         gdbarch.  Update comment.
 938
 939 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 940
 941         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 942         (rs6000_dummy_id): Delete.
 943         (rs6000_gdbarch_init): Don't register deleted functions with
 944         gdbarch.
 945
 946 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 947
 948         * or1k-tdep.c (or1k_dummy_id): Delete.
 949         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 950
 951 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 952
 953         * nios2-tdep.c (nios2_dummy_id): Delete.
 954         (nios2_unwind_sp): Delete.
 955         (nios2_gdbarch_init): Don't register deleted functions with
 956         gdbarch.
 957
 958 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 959
 960         * nds32-tdep.c (nds32_dummy_id): Delete.
 961         (nds32_unwind_pc): Delete.
 962         (nds32_unwind_sp): Delete.
 963         (nds32_gdbarch_init): Don't register deleted functions with
 964         gdbarch.
 965
 966 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 967
 968         * msp430-tdep.c (msp430_unwind_pc): Delete.
 969         (msp430_unwind_sp): Delete.
 970         (msp430_dummy_id): Delete.
 971         (msp430_gdbarch_init): Don't register deleted functions with
 972         gdbarch.
 973
 974 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 975
 976         * moxie-tdep.c (moxie_unwind_sp): Delete.
 977         (moxie_unwind_pc): Delete.
 978         (moxie_dummy_id): Delete.
 979         (moxie_gdbarch_init): Don't register deleted functions with
 980         gdbarch.
 981
 982 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 983
 984         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 985         (mn10300_unwind_pc): Delete.
 986         (mn10300_unwind_sp): Delete.
 987         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 988         mn10300_unwind_sp.
 989         (mn10300_frame_unwind_init): Don't register deleted functions with
 990         gdbarch.
 991
 992 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 993
 994         * mep-tdep.c (mep_unwind_pc): Delete.
 995         (mep_unwind_sp): Delete.
 996         (mep_dummy_id): Delete.
 997         (mep_gdbarch_init): Don't register deleted functions with
 998         gdbarch.
 999
1000 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1001
1002         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1003         (m68hc11_unwind_sp): Delete.
1004         (m68hc11_gdbarch_init): Don't register deleted functions with
1005         gdbarch.
1006
1007 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1008
1009         * m32r-tdep.c (m32r_unwind_sp): Delete.
1010         (m32r_unwind_pc): Delete.
1011         (m32r_dummy_id): Delete.
1012         (m32r_gdbarch_init): Don't register deleted functions with
1013         gdbarch.
1014
1015 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1016
1017         * m32c-tdep.c (m32c_unwind_pc): Delete.
1018         (m32c_unwind_sp): Delete.
1019         (m32c_dummy_id): Delete.
1020         (m32c_gdbarch_init): Don't register deleted functions with
1021         gdbarch.
1022
1023 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1024
1025         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1026         (lm32_unwind_pc): Delete.
1027         (lm32_dummy_id): Delete.
1028         (lm32_gdbarch_init): Don't register deleted functions with
1029         gdbarch.
1030
1031 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1032
1033         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1034         (iq2000_unwind_pc): Delete.
1035         (iq2000_dummy_id): Delete.
1036         (iq2000_gdbarch_init): Don't register deleted functions with
1037         gdbarch.
1038
1039 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1040
1041         * nds32-tdep.c (nds32_type_align): Delete.
1042         (nds32_push_dummy_call): Use type_align instead.
1043
1044 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1045
1046         * arm-tdep.c (arm_type_align): Only handle vector override case.
1047         (arm_push_dummy_call): Use type_align.
1048         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1049
1050 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1051
1052         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1053         case.
1054         (pass_on_stack): Use type_align.
1055         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1056         function.
1057
1058 2019-04-23  Tom Tromey  <tromey@adacore.com>
1059
1060         * dwarf2read.c (line_header::file_name_at): Remove unused
1061         overload.
1062
1063 2019-04-23  Tom de Vries  <tdevries@suse.de>
1064
1065         PR gdb/24438
1066         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1067         invocation.
1068
1069
1070 2019-03-27  Ali Tamur  <tamur@google.com>
1071
1072         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1073         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1074         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1075         (dwarf_expr_context::get_addr_index): Likewise
1076         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1077         (symbol_needs_eval_context::get_addr_index): Likewise
1078         (disassemble_dwarf_expression): Add DW_OP_addrx
1079         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1080         (read_cutu_die_from_dwo): Update comment
1081         (skip_one_die): Add DW_FORM_addrx
1082         (read_attribute_value): Likewise
1083         (var_decode_location): Add DW_OP_addrx
1084         (dwarf2_const_value_attr): Add DW_FORM_addrx
1085         (dump_die_shallow): Likewise
1086         (dwarf2_fetch_constant_bytes): Likewise
1087         (decode_locdesc): Add DW_OP_addrx
1088         (skip_form_bytes): Add DW_FORM_addrx
1089
1090 2019-04-22  Ali Tamur  <tamur@google.com>
1091
1092         * MAINTAINERS (Write After Approval): Add self.
1093
1094 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1095
1096         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1097         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1098         (open_symbol_file_object): Likewise.
1099         (svr4_default_sos): Add info parameter.
1100         (svr4_read_so_list): Likewise.
1101         (svr4_current_sos_direct): Adjust functions calls to pass down
1102         info.
1103         (svr4_current_sos_1): Add info parameter.
1104         (svr4_current_sos): Call get_svr4_info, pass info down to
1105         svr4_current_sos_1.
1106         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1107         get_svr4_info.
1108         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1109         get_svr4_info.
1110         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1111         to get_svr4_info.
1112         (probes_table_remove_objfile_probes): Likewise.
1113         (register_solib_event_probe): Add info parameter.
1114         (solist_update_incremental): Pass info parameter down to
1115         svr4_read_so_list.
1116         (disable_probes_interface): Add info parameter.
1117         (svr4_handle_solib_event): Pass current_program_space to
1118         get_svr4_info.  Adjust disable_probes_interface cleanup.
1119         (svr4_create_probe_breakpoints): Add info parameter, pass it
1120         down to register_solib_event_probe.
1121         (svr4_create_solib_event_breakpoints): Add info parameter,
1122         pass it down to svr4_create_probe_breakpoints.
1123         (enable_break): Pass info down to
1124         svr4_create_solib_event_breakpoints.
1125         (svr4_solib_create_inferior_hook): Pass current_program_space to
1126         get_svr4_info.
1127         (svr4_clear_solib): Likewise.
1128
1129 2019-04-22  Pedro Alves  <palves@redhat.com>
1130
1131         * solib-svr4.c (svr4_free_objfile_observer): New.
1132         (probe_and_action::objfile): New field.
1133         (probes_table_htab_remove_objfile_probes)
1134         (probes_table_remove_objfile_probes): New functions.
1135         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1136         in the new probe_and_action.  Don't store the probe in 'lookup'.
1137         (svr4_create_probe_breakpoints): Pass objfile to
1138         register_solib_event_probe.
1139         (_initialize_svr4_solib): Register a free_objfile observer.
1140
1141 2019-04-19  Tom Tromey  <tom@tromey.com>
1142
1143         * common/queue.h: Remove.
1144
1145 2019-04-19  Tom Tromey  <tom@tromey.com>
1146
1147         * event-loop.c: Don't include "common/queue.h".
1148
1149 2019-04-19  Tom Tromey  <tom@tromey.com>
1150
1151         * remote.c (remote_target): Use delete.
1152         * remote-notif.h: Include <list>, not "common/queue.h".
1153         (notif_client_p): Remove typedef.
1154         (remote_notif_state): Add constructor, destructor, initializer.
1155         <notif_queue>: Now a std::list.
1156         (remote_notif_state_xfree): Don't declare.
1157         * remote-notif.c (remote_notif_process, handle_notification)
1158         (remote_notif_state_allocate): Update.
1159         (~remote_notif_state): Rename from remote_notif_state_xfree.
1160
1161 2019-04-19  Tom Tromey  <tom@tromey.com>
1162
1163         * symfile.c (reread_symbols): Update.
1164         * objfiles.c (objfile_register_static_link)
1165         (objfile_lookup_static_link): Update
1166         (~objfile) Don't delete static_links.
1167         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1168
1169 2019-04-19  Tom Tromey  <tom@tromey.com>
1170
1171         * type-stack.h (struct type_stack) <insert>: Constify string.
1172         * type-stack.c (type_stack::insert): Constify string.
1173         * gdbtypes.h (lookup_template_type): Update.
1174         (address_space_name_to_int): Update.
1175         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1176         const.
1177         (lookup_template_type): Make name const.
1178         * c-exp.y: Update rules.
1179         (lex_one_token, classify_name, classify_inner_name)
1180         (c_print_token): Update.
1181         * p-exp.y: Update rules.
1182         (yylex): Update.
1183         * f-exp.y: Update rules.
1184         (yylex): Update.
1185         * d-exp.y: Update rules.
1186         (lex_one_token, classify_name, classify_inner_name): Update.
1187         * parse.c (write_dollar_variable, copy_name): Return std::string.
1188         * parser-defs.h (copy_name): Change return type.
1189         * m2-exp.y: Update rules.
1190         (yylex): Update.
1191         * go-exp.y (lex_one_token): Update.
1192         Update rules.
1193         (classify_unsafe_function, classify_packaged_name)
1194         (classify_name, yylex): Update.
1195
1196 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1197
1198         * configure.ac: add --enable-source-highlight switch.
1199         * configure: Regenerate.
1200         * top.c (print_gdb_version): plumb --enable-source-highlight
1201         status to "show configuration".
1202
1203 2019-04-19  Tom Tromey  <tromey@adacore.com>
1204
1205         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1206         Check ADA_TYPE_P.
1207         (empty_record, ada_template_to_fixed_record_type_1)
1208         (template_to_static_fixed_type)
1209         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1210         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1211         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1212         macros.
1213
1214 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1215
1216         PR symtab/24423:
1217         * source.c (print_source_lines_base): Advance "iter" when a
1218         control character is seen.
1219
1220 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1221
1222         * inferior.h (struct infcall_suspend_state_deleter):
1223         Catch exception in destructor to avoid crash.
1224
1225 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1226
1227         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1228         close to the add_com "shell".
1229
1230 2019-04-18  Tom Tromey  <tromey@adacore.com>
1231
1232         * process-stratum-target.h (class process_stratum_target)
1233         <stratum>: Add "final".
1234
1235 2019-04-17  Tom Tromey  <tromey@adacore.com>
1236
1237         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1238         against nullptr before use.
1239
1240 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1241
1242         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1243
1244 2019-04-17  Jim Wilson  <jimw@sifive.com>
1245             Andrew Burgess  <andrew.burgess@embecosm.com>
1246
1247         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1248         code read might fail, assume 4-byte breakpoint in that case.
1249
1250 2019-04-15  Leszek Swirski  <leszeks@google.com>
1251
1252         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1253         rather than a hand-rolled POD check when checking for forced MEMORY
1254         classification.
1255
1256 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1257
1258         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1259         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1260         function.
1261         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1262         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1263         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1264         declaration.
1265
1266 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1267
1268         * aarch64-linux-nat.c
1269         (aarch64_linux_nat_target::thread_architecture): Add override.
1270         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1271         each VQ.
1272
1273 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1274
1275         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1276
1277 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1278
1279         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1280         target types of size 96-bits, add some additional comments, and
1281         check that the builtin type we found was the correct size.
1282
1283 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1284
1285         * utils.c (prompt_for_continue): Don't restore the styling at the
1286         end, as applied_style has the wrong value.  This fixes styling in
1287         long lists of file names that are interrupted by the "Continue?"
1288         prompt.
1289
1290 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1291
1292         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1293         * c-lang.c (c_language_defn): Likewise.
1294         (cplus_language_defn): Likewise.
1295         (asm_language_defn): Likewise.
1296         (minimal_language_defn): Likewise.
1297         * d-lang.c (d_language_defn): Likewise.
1298         * f-lang.c (f_language_defn): Likewise.
1299         * go-lang.c (go_language_defn): Likewise.
1300         * language.c (unknown_language_defn): Likewise.
1301         (auto_language_defn): Likewise.
1302         * language.h (struct language_defn): Remove la_magic field.
1303         (LANG_MAGIC): Delete.
1304         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1305         * objc-lang.c (objc_language_defn): Likewise.
1306         * opencl-lang.c (opencl_language_defn): Likewise.
1307         * p-lang.c (pascal_language_defn): Likewise.
1308         * rust-lang.c (rust_language_defn): Likewise.
1309
1310 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1311
1312         * riscv-tdep.c (riscv_type_align): New function.
1313         (riscv_type_alignment): Delete.
1314         (riscv_arg_location): Use 'type_align'.
1315         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1316
1317 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1318
1319         * gdbtypes.c (type_align): A struct with no non-static fields also
1320         has alignment of 1.
1321
1322 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1323
1324         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1325         component to 0.
1326         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1327         member.
1328         (riscv_struct_info::analyse): New implementation using new
1329         analyse_inner member function.
1330         (riscv_struct_info::field_offset): New member function.
1331         (riscv_struct_info::m_offsets): New member variable.
1332         (riscv_struct_info::analyse_inner): New private member function,
1333         takes the old implementation of riscv_struct_info::analyse but
1334         extended to track field offsets.
1335         (riscv_call_arg_struct): Update the struct folding special cases
1336         to handle cases where empty C++ structs, which are non-zero
1337         length, are found.
1338         (riscv_arg_location): Initialise the length of each location, a
1339         non-zero length now indicates the location is in use.
1340         (riscv_push_dummy_call): Allow for the first location having a
1341         non-zero offset when setting up arguments.
1342         (riscv_return_value): Likewise, but for return values.
1343
1344 2019-04-11  Tom Tromey  <tromey@adacore.com>
1345
1346         * utils.c (internal_vproblem): Make "msg" const.
1347
1348 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1349
1350         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1351         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1352         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1353         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1354
1355 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1356
1357         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1358         function.
1359         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1360         of amd64_collect_native_gregset.
1361         (amd64_linux_nat_target::store_registers): Likewise.
1362
1363 2019-04-10  Tom Tromey  <tom@tromey.com>
1364
1365         * symtab.c (lookup_global_symbol_from_objfile)
1366         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1367         * objfiles.h (class separate_debug_iterator): New.
1368         (class separate_debug_range): New.
1369         (struct objfile) <separate_debug_objfiles>: New method.
1370         (objfile_separate_debug_iterate): Don't declare.
1371         * objfiles.c (separate_debug_iterator::operator++): Rename from
1372         objfile_separate_debug_iterate.
1373         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1374         iterator.
1375         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1376         iterator.
1377
1378 2019-04-10  Tom Tromey  <tom@tromey.com>
1379
1380         * symfile.c (reread_symbols): Remove old comment.
1381         * objfiles.c (free_all_objfiles): Fix a typo.
1382
1383 2019-04-10  Tom Tromey  <tom@tromey.com>
1384
1385         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1386         * minsyms.c (lookup_minimal_symbol): Use foreach.
1387         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1388         (lookup_minimal_symbol_solib_trampoline): Likewise.
1389         * symfile.c (reread_symbols): Use foreach.
1390
1391 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1392             Tom Tromey  <tromey@adacore.com>
1393
1394         PR rust/24414:
1395         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1396         (rust_lex_int_test): Change "value" to be LONGEST.
1397         (rust_lex_tests): Add test for long integer literal.
1398
1399 2019-04-09  Tom Tromey  <tromey@adacore.com>
1400
1401         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1402         to bool.
1403         (extended_remote_target::attach): Update.
1404         (remote_target::remote_notice_new_inferior): Update.
1405         (remote_target::add_current_inferior_and_thread): Update.
1406         * inferior.c (exit_inferior_1): Use "false".
1407         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1408
1409 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1410
1411         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1412         the "start" command.
1413
1414 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1415
1416         * python/py-inferior.c (infpy_thread_from_thread_handle):
1417         Adjust comments to reflect renaming of thread_from_thread_handle
1418         to thread_from_handle.  Adjust keywords.  Fix type error message.
1419         (inferior_object_methods): Add thread_from_handle.  Retain
1420         thread_from_thread_handle, but mark it as deprecated.
1421
1422 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1423
1424         * gdbthread.h (find_thread_by_handle): Revise declaration.
1425         * thread.c (find_thread_by_handle): Likewise.  Adjust
1426         implementation too.
1427         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1428         support for buffer objects as handles.
1429
1430 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1431
1432         * python/py-infthread.c (thpy_thread_handle): New function.
1433         (thread_object_methods): Register thpy_thread_handle.
1434
1435 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1436
1437         * gdbthread.h (thread_to_thread_handle): Declare.
1438         * thread.c (gdbtypes.h): Include.
1439         (thread_to_thread_handle): New function.
1440
1441         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1442         (target_thread_info_to_thread_handle): Declare.
1443         * target.c (target_thread_info_to_thread_handle): New function.
1444         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1445         * target-delegates.c: Regenerate.
1446
1447         * linux-thread-db.c (class thread_db_target): Add method
1448         thread_info_to_thread_handle.
1449         (thread_db_target::thread_info_to_thread_handle): Define.
1450         * remote.c (class remote_target): Add new method
1451         thread_info_to_thread_handle.
1452         (remote_target::thread_info_to_thread_handle): Define.
1453
1454 2019-04-08  Pedro Alves  <palves@redhat.com>
1455
1456         * common/common-exceptions.c (throw_exception): Don't create
1457         named object to throw; throw directly.
1458         (throw_it): Likewise.  Don't initialize gdb_exception::message
1459         here, with new; pass FMT and AP to the ctor instead.
1460         * common/common-exceptions.h: Include <string>.
1461         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1462         const char *, va_list)): New ctor.  Use std::make_shared.
1463         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1464         errors)): Delete.
1465         (gdb_exception_error::gdb_exception_error(enum errors, const char
1466         *, va_list)): New.
1467         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1468         Add assertion.
1469         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1470         errors)): Delete.
1471         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1472         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1473         Add assertion.
1474
1475 2019-04-08  Tom Tromey  <tom@tromey.com>
1476
1477         * valops.c (value_rtti_indirect_type): Replace throw_exception
1478         with throw.
1479         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1480         with throw.
1481         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1482         throw.
1483         * target.c (target_translate_tls_address): Replace throw_exception
1484         with throw.
1485         * stack.c (frame_apply_command_count): Replace throw_exception
1486         with throw.
1487         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1488         throw.
1489         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1490         with throw.
1491         * rs6000-tdep.c (rs6000_frame_cache)
1492         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1493         * remote.c: Replace throw_exception with throw.
1494         * record-full.c (record_full_message, record_full_wait_1)
1495         (record_full_restore): Replace throw_exception with throw.
1496         * record-btrace.c:
1497         (get_thread_current_frame_id, record_btrace_start_replaying)
1498         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1499         (cmd_record_btrace_start): Replace throw_exception with throw.
1500         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1501         throw.
1502         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1503         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1504         * linespec.c:
1505         (find_linespec_symbols): Replace throw_exception with throw.
1506         * infrun.c (displaced_step_prepare, resume): Replace
1507         throw_exception with throw.
1508         * infcmd.c (post_create_inferior): Replace throw_exception with
1509         throw.
1510         * inf-loop.c (inferior_event_handler): Replace throw_exception
1511         with throw.
1512         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1513         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1514         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1515         (get_prev_frame_always, get_frame_pc_if_available)
1516         (get_frame_address_in_block_if_available, get_frame_language):
1517         Replace throw_exception with throw.
1518         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1519         throw_exception with throw.
1520         * eval.c (fetch_subexp_value, evaluate_var_value)
1521         (evaluate_funcall, evaluate_subexp_standard): Replace
1522         throw_exception with throw.
1523         * dwarf2loc.c (call_site_find_chain)
1524         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1525         Replace throw_exception with throw.
1526         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1527         with throw.
1528         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1529         throw.
1530         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1531         * completer.c (complete_line_internal): Replace throw_exception
1532         with throw.
1533         * compile/compile-object-run.c (compile_object_run): Replace
1534         throw_exception with throw.
1535         * cli/cli-script.c (process_next_line): Replace throw_exception
1536         with throw.
1537         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1538         (btrace_enable, btrace_maint_update_pt_packets): Replace
1539         throw_exception with throw.
1540         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1541         throw_exception with throw.
1542         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1543         throw_exception with throw.
1544         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1545         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1546         * aarch64-tdep.c (aarch64_make_prologue_cache)
1547         (aarch64_make_stub_cache): Replace throw_exception with throw.
1548
1549 2019-04-08  Tom Tromey  <tom@tromey.com>
1550
1551         * common/common-exceptions.c (throw_exception): Rename from
1552         throw_exception_cxx.  Remove old copy.  Make argument const.
1553         (throw_it): Create and throw exception objects directly.
1554         * common/common-exceptions.h (throw_exception): Make argument
1555         const.
1556         (struct gdb_exception_error): Add constructor.
1557         (struct gdb_exception_quit): Add constructor.
1558
1559 2019-04-08  Tom Tromey  <tom@tromey.com>
1560
1561         * common/common-exceptions.h (exception_rethrow): Don't declare.
1562         (TRY_SJLJ): Update comment.
1563         (TRY, CATCH, END_CATCH): Remove.
1564         * common/common-exceptions.c (exception_rethrow): Remove.
1565
1566 2019-04-08  Tom Tromey  <tom@tromey.com>
1567
1568         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1569         Remove.
1570         (gdb_exception_error): Rename from
1571         gdb_exception_RETURN_MASK_ERROR.
1572         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1573         (gdb_quit_bad_alloc): Update.
1574         * aarch64-tdep.c: Update.
1575         * ada-lang.c: Update.
1576         * ada-typeprint.c: Update.
1577         * ada-valprint.c: Update.
1578         * amd64-tdep.c: Update.
1579         * arch-utils.c: Update.
1580         * break-catch-throw.c: Update.
1581         * breakpoint.c: Update.
1582         * btrace.c: Update.
1583         * c-varobj.c: Update.
1584         * cli/cli-cmds.c: Update.
1585         * cli/cli-interp.c: Update.
1586         * cli/cli-script.c: Update.
1587         * common/common-exceptions.c: Update.
1588         * common/new-op.c: Update.
1589         * common/selftest.c: Update.
1590         * compile/compile-c-symbols.c: Update.
1591         * compile/compile-cplus-symbols.c: Update.
1592         * compile/compile-object-load.c: Update.
1593         * compile/compile-object-run.c: Update.
1594         * completer.c: Update.
1595         * corelow.c: Update.
1596         * cp-abi.c: Update.
1597         * cp-support.c: Update.
1598         * cp-valprint.c: Update.
1599         * darwin-nat.c: Update.
1600         * disasm-selftests.c: Update.
1601         * dtrace-probe.c: Update.
1602         * dwarf-index-cache.c: Update.
1603         * dwarf-index-write.c: Update.
1604         * dwarf2-frame-tailcall.c: Update.
1605         * dwarf2-frame.c: Update.
1606         * dwarf2loc.c: Update.
1607         * dwarf2read.c: Update.
1608         * eval.c: Update.
1609         * event-loop.c: Update.
1610         * event-top.c: Update.
1611         * exec.c: Update.
1612         * f-valprint.c: Update.
1613         * fbsd-tdep.c: Update.
1614         * frame-unwind.c: Update.
1615         * frame.c: Update.
1616         * gdbtypes.c: Update.
1617         * gnu-v3-abi.c: Update.
1618         * guile/guile-internal.h: Update.
1619         * guile/scm-block.c: Update.
1620         * guile/scm-breakpoint.c: Update.
1621         * guile/scm-cmd.c: Update.
1622         * guile/scm-disasm.c: Update.
1623         * guile/scm-frame.c: Update.
1624         * guile/scm-lazy-string.c: Update.
1625         * guile/scm-math.c: Update.
1626         * guile/scm-param.c: Update.
1627         * guile/scm-ports.c: Update.
1628         * guile/scm-pretty-print.c: Update.
1629         * guile/scm-symbol.c: Update.
1630         * guile/scm-symtab.c: Update.
1631         * guile/scm-type.c: Update.
1632         * guile/scm-value.c: Update.
1633         * i386-linux-tdep.c: Update.
1634         * i386-tdep.c: Update.
1635         * inf-loop.c: Update.
1636         * infcall.c: Update.
1637         * infcmd.c: Update.
1638         * infrun.c: Update.
1639         * jit.c: Update.
1640         * language.c: Update.
1641         * linespec.c: Update.
1642         * linux-fork.c: Update.
1643         * linux-nat.c: Update.
1644         * linux-tdep.c: Update.
1645         * linux-thread-db.c: Update.
1646         * main.c: Update.
1647         * mi/mi-cmd-break.c: Update.
1648         * mi/mi-cmd-stack.c: Update.
1649         * mi/mi-interp.c: Update.
1650         * mi/mi-main.c: Update.
1651         * objc-lang.c: Update.
1652         * p-valprint.c: Update.
1653         * parse.c: Update.
1654         * ppc-linux-tdep.c: Update.
1655         * printcmd.c: Update.
1656         * python/py-arch.c: Update.
1657         * python/py-breakpoint.c: Update.
1658         * python/py-cmd.c: Update.
1659         * python/py-finishbreakpoint.c: Update.
1660         * python/py-frame.c: Update.
1661         * python/py-framefilter.c: Update.
1662         * python/py-gdb-readline.c: Update.
1663         * python/py-inferior.c: Update.
1664         * python/py-infthread.c: Update.
1665         * python/py-lazy-string.c: Update.
1666         * python/py-linetable.c: Update.
1667         * python/py-objfile.c: Update.
1668         * python/py-param.c: Update.
1669         * python/py-prettyprint.c: Update.
1670         * python/py-progspace.c: Update.
1671         * python/py-record-btrace.c: Update.
1672         * python/py-record.c: Update.
1673         * python/py-symbol.c: Update.
1674         * python/py-type.c: Update.
1675         * python/py-unwind.c: Update.
1676         * python/py-utils.c: Update.
1677         * python/py-value.c: Update.
1678         * python/python.c: Update.
1679         * record-btrace.c: Update.
1680         * record-full.c: Update.
1681         * remote-fileio.c: Update.
1682         * remote.c: Update.
1683         * riscv-tdep.c: Update.
1684         * rs6000-aix-tdep.c: Update.
1685         * rs6000-tdep.c: Update.
1686         * rust-exp.y: Update.
1687         * rust-lang.c: Update.
1688         * s390-tdep.c: Update.
1689         * selftest-arch.c: Update.
1690         * solib-dsbt.c: Update.
1691         * solib-frv.c: Update.
1692         * solib-spu.c: Update.
1693         * solib-svr4.c: Update.
1694         * solib.c: Update.
1695         * sparc64-linux-tdep.c: Update.
1696         * stack.c: Update.
1697         * symfile-mem.c: Update.
1698         * symmisc.c: Update.
1699         * target.c: Update.
1700         * thread.c: Update.
1701         * top.c: Update.
1702         * tracefile-tfile.c: Update.
1703         * tui/tui.c: Update.
1704         * typeprint.c: Update.
1705         * unittests/cli-utils-selftests.c: Update.
1706         * unittests/parse-connection-spec-selftests.c: Update.
1707         * valops.c: Update.
1708         * valprint.c: Update.
1709         * value.c: Update.
1710         * varobj.c: Update.
1711         * windows-nat.c: Update.
1712         * x86-linux-nat.c: Update.
1713         * xml-support.c: Update.
1714
1715 2019-04-08  Tom Tromey  <tom@tromey.com>
1716
1717         * xml-support.c: Use C++ exception handling.
1718         * x86-linux-nat.c: Use C++ exception handling.
1719         * windows-nat.c: Use C++ exception handling.
1720         * varobj.c: Use C++ exception handling.
1721         * value.c: Use C++ exception handling.
1722         * valprint.c: Use C++ exception handling.
1723         * valops.c: Use C++ exception handling.
1724         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1725         handling.
1726         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1727         * typeprint.c: Use C++ exception handling.
1728         * tui/tui.c: Use C++ exception handling.
1729         * tracefile-tfile.c: Use C++ exception handling.
1730         * top.c: Use C++ exception handling.
1731         * thread.c: Use C++ exception handling.
1732         * target.c: Use C++ exception handling.
1733         * symmisc.c: Use C++ exception handling.
1734         * symfile-mem.c: Use C++ exception handling.
1735         * stack.c: Use C++ exception handling.
1736         * sparc64-linux-tdep.c: Use C++ exception handling.
1737         * solib.c: Use C++ exception handling.
1738         * solib-svr4.c: Use C++ exception handling.
1739         * solib-spu.c: Use C++ exception handling.
1740         * solib-frv.c: Use C++ exception handling.
1741         * solib-dsbt.c: Use C++ exception handling.
1742         * selftest-arch.c: Use C++ exception handling.
1743         * s390-tdep.c: Use C++ exception handling.
1744         * rust-lang.c: Use C++ exception handling.
1745         * rust-exp.y: Use C++ exception handling.
1746         * rs6000-tdep.c: Use C++ exception handling.
1747         * rs6000-aix-tdep.c: Use C++ exception handling.
1748         * riscv-tdep.c: Use C++ exception handling.
1749         * remote.c: Use C++ exception handling.
1750         * remote-fileio.c: Use C++ exception handling.
1751         * record-full.c: Use C++ exception handling.
1752         * record-btrace.c: Use C++ exception handling.
1753         * python/python.c: Use C++ exception handling.
1754         * python/py-value.c: Use C++ exception handling.
1755         * python/py-utils.c: Use C++ exception handling.
1756         * python/py-unwind.c: Use C++ exception handling.
1757         * python/py-type.c: Use C++ exception handling.
1758         * python/py-symbol.c: Use C++ exception handling.
1759         * python/py-record.c: Use C++ exception handling.
1760         * python/py-record-btrace.c: Use C++ exception handling.
1761         * python/py-progspace.c: Use C++ exception handling.
1762         * python/py-prettyprint.c: Use C++ exception handling.
1763         * python/py-param.c: Use C++ exception handling.
1764         * python/py-objfile.c: Use C++ exception handling.
1765         * python/py-linetable.c: Use C++ exception handling.
1766         * python/py-lazy-string.c: Use C++ exception handling.
1767         * python/py-infthread.c: Use C++ exception handling.
1768         * python/py-inferior.c: Use C++ exception handling.
1769         * python/py-gdb-readline.c: Use C++ exception handling.
1770         * python/py-framefilter.c: Use C++ exception handling.
1771         * python/py-frame.c: Use C++ exception handling.
1772         * python/py-finishbreakpoint.c: Use C++ exception handling.
1773         * python/py-cmd.c: Use C++ exception handling.
1774         * python/py-breakpoint.c: Use C++ exception handling.
1775         * python/py-arch.c: Use C++ exception handling.
1776         * printcmd.c: Use C++ exception handling.
1777         * ppc-linux-tdep.c: Use C++ exception handling.
1778         * parse.c: Use C++ exception handling.
1779         * p-valprint.c: Use C++ exception handling.
1780         * objc-lang.c: Use C++ exception handling.
1781         * mi/mi-main.c: Use C++ exception handling.
1782         * mi/mi-interp.c: Use C++ exception handling.
1783         * mi/mi-cmd-stack.c: Use C++ exception handling.
1784         * mi/mi-cmd-break.c: Use C++ exception handling.
1785         * main.c: Use C++ exception handling.
1786         * linux-thread-db.c: Use C++ exception handling.
1787         * linux-tdep.c: Use C++ exception handling.
1788         * linux-nat.c: Use C++ exception handling.
1789         * linux-fork.c: Use C++ exception handling.
1790         * linespec.c: Use C++ exception handling.
1791         * language.c: Use C++ exception handling.
1792         * jit.c: Use C++ exception handling.
1793         * infrun.c: Use C++ exception handling.
1794         * infcmd.c: Use C++ exception handling.
1795         * infcall.c: Use C++ exception handling.
1796         * inf-loop.c: Use C++ exception handling.
1797         * i386-tdep.c: Use C++ exception handling.
1798         * i386-linux-tdep.c: Use C++ exception handling.
1799         * guile/scm-value.c: Use C++ exception handling.
1800         * guile/scm-type.c: Use C++ exception handling.
1801         * guile/scm-symtab.c: Use C++ exception handling.
1802         * guile/scm-symbol.c: Use C++ exception handling.
1803         * guile/scm-pretty-print.c: Use C++ exception handling.
1804         * guile/scm-ports.c: Use C++ exception handling.
1805         * guile/scm-param.c: Use C++ exception handling.
1806         * guile/scm-math.c: Use C++ exception handling.
1807         * guile/scm-lazy-string.c: Use C++ exception handling.
1808         * guile/scm-frame.c: Use C++ exception handling.
1809         * guile/scm-disasm.c: Use C++ exception handling.
1810         * guile/scm-cmd.c: Use C++ exception handling.
1811         * guile/scm-breakpoint.c: Use C++ exception handling.
1812         * guile/scm-block.c: Use C++ exception handling.
1813         * guile/guile-internal.h: Use C++ exception handling.
1814         * gnu-v3-abi.c: Use C++ exception handling.
1815         * gdbtypes.c: Use C++ exception handling.
1816         * frame.c: Use C++ exception handling.
1817         * frame-unwind.c: Use C++ exception handling.
1818         * fbsd-tdep.c: Use C++ exception handling.
1819         * f-valprint.c: Use C++ exception handling.
1820         * exec.c: Use C++ exception handling.
1821         * event-top.c: Use C++ exception handling.
1822         * event-loop.c: Use C++ exception handling.
1823         * eval.c: Use C++ exception handling.
1824         * dwarf2read.c: Use C++ exception handling.
1825         * dwarf2loc.c: Use C++ exception handling.
1826         * dwarf2-frame.c: Use C++ exception handling.
1827         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1828         * dwarf-index-write.c: Use C++ exception handling.
1829         * dwarf-index-cache.c: Use C++ exception handling.
1830         * dtrace-probe.c: Use C++ exception handling.
1831         * disasm-selftests.c: Use C++ exception handling.
1832         * darwin-nat.c: Use C++ exception handling.
1833         * cp-valprint.c: Use C++ exception handling.
1834         * cp-support.c: Use C++ exception handling.
1835         * cp-abi.c: Use C++ exception handling.
1836         * corelow.c: Use C++ exception handling.
1837         * completer.c: Use C++ exception handling.
1838         * compile/compile-object-run.c: Use C++ exception handling.
1839         * compile/compile-object-load.c: Use C++ exception handling.
1840         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1841         * compile/compile-c-symbols.c: Use C++ exception handling.
1842         * common/selftest.c: Use C++ exception handling.
1843         * common/new-op.c: Use C++ exception handling.
1844         * cli/cli-script.c: Use C++ exception handling.
1845         * cli/cli-interp.c: Use C++ exception handling.
1846         * cli/cli-cmds.c: Use C++ exception handling.
1847         * c-varobj.c: Use C++ exception handling.
1848         * btrace.c: Use C++ exception handling.
1849         * breakpoint.c: Use C++ exception handling.
1850         * break-catch-throw.c: Use C++ exception handling.
1851         * arch-utils.c: Use C++ exception handling.
1852         * amd64-tdep.c: Use C++ exception handling.
1853         * ada-valprint.c: Use C++ exception handling.
1854         * ada-typeprint.c: Use C++ exception handling.
1855         * ada-lang.c: Use C++ exception handling.
1856         * aarch64-tdep.c: Use C++ exception handling.
1857
1858 2019-04-08  Tom Tromey  <tom@tromey.com>
1859
1860         * xml-support.c (gdb_xml_parser::parse): Update.
1861         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1862         * value.c (show_convenience): Update.
1863         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1864         (test_parse_flags_qcs): Update.
1865         * thread.c (thr_try_catch_cmd): Update.
1866         * target.c (target_translate_tls_address): Update.
1867         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1868         (info_frame_command_core, frame_apply_command_count): Update.
1869         * rust-exp.y (rust_lex_exception_test): Update.
1870         * riscv-tdep.c (riscv_print_one_register_info): Update.
1871         * remote.c (remote_target::enable_btrace): Update.
1872         * record-btrace.c (record_btrace_enable_warn): Update.
1873         * python/py-utils.c (gdbpy_convert_exception): Update.
1874         * printcmd.c (do_one_display, print_variable_and_value): Update.
1875         * mi/mi-main.c (mi_print_exception): Update.
1876         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1877         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1878         * linux-nat.c (linux_nat_target::attach): Update.
1879         * linux-fork.c (class scoped_switch_fork_info): Update.
1880         * infrun.c (displaced_step_prepare): Update.
1881         * infcall.c (call_function_by_hand_dummy): Update.
1882         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1883         * gnu-v3-abi.c (print_one_vtable): Update.
1884         * frame.c (get_prev_frame_always): Update.
1885         * f-valprint.c (info_common_command_for_block): Update.
1886         * exec.c (try_open_exec_file): Update.
1887         * exceptions.c (print_exception, exception_print)
1888         (exception_fprintf, exception_print_same): Update.
1889         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1890         * dwarf-index-cache.c (index_cache::store)
1891         (index_cache::lookup_gdb_index): Update.
1892         * darwin-nat.c (maybe_cache_shell): Update.
1893         * cp-valprint.c (cp_print_value_fields): Update.
1894         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1895         (gcc_cplus_symbol_address): Update.
1896         * compile/compile-c-symbols.c (gcc_convert_symbol)
1897         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1898         * common/selftest.c: Update.
1899         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1900         a std::string.
1901         (exception_try_scope_entry, exception_try_scope_exit): Don't
1902         declare.
1903         (struct exception_try_scope): Remove.
1904         (TRY): Don't use exception_try_scope.
1905         (struct gdb_exception): Add constructor, operator=.
1906         <what>: New method.
1907         (struct gdb_exception_RETURN_MASK_ALL)
1908         (struct gdb_exception_RETURN_MASK_ERROR)
1909         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1910         (struct gdb_quit_bad_alloc): Update.
1911         * common/common-exceptions.c (exception_none): Change
1912         initializer.
1913         (struct catcher) <state, exception>: Initialize inline.
1914         <prev>: Remove member.
1915         (current_catcher): Remove.
1916         (catchers): New global.
1917         (exceptions_state_mc_init): Simplify.
1918         (catcher_pop): Remove.
1919         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1920         (try_scope_depth, exception_try_scope_entry)
1921         (exception_try_scope_exit): Remove.
1922         (throw_exception_sjlj): Update.
1923         (exception_messages, exception_messages_size): Remove.
1924         (throw_it): Simplify.
1925         (gdb_exception_sliced_copy): Remove.
1926         (throw_exception_cxx): Update.
1927         * cli/cli-script.c (script_from_file): Update.
1928         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1929         Update.
1930         * ada-valprint.c (ada_val_print): Update.
1931         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1932         (create_excep_cond_exprs): Update.
1933
1934 2019-04-08  Tom Tromey  <tom@tromey.com>
1935
1936         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1937         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1938         (TRY, CATCH, END_CATCH): Remove some definitions.
1939         * common/common-exceptions.c: Don't use GDB_XCPT.
1940         (catcher_list_size): Remove.
1941         (throw_exception, throw_it): Simplify.
1942
1943 2019-04-05  Tom Tromey  <tom@tromey.com>
1944
1945         Revert the header-sorting patch.
1946         * ft32-tdep.c: Revert.
1947         * frv-tdep.c: Revert.
1948         * frv-linux-tdep.c: Revert.
1949         * frame.c: Revert.
1950         * frame-unwind.c: Revert.
1951         * frame-base.c: Revert.
1952         * fork-child.c: Revert.
1953         * findvar.c: Revert.
1954         * findcmd.c: Revert.
1955         * filesystem.c: Revert.
1956         * filename-seen-cache.h: Revert.
1957         * filename-seen-cache.c: Revert.
1958         * fbsd-tdep.c: Revert.
1959         * fbsd-nat.h: Revert.
1960         * fbsd-nat.c: Revert.
1961         * f-valprint.c: Revert.
1962         * f-typeprint.c: Revert.
1963         * f-lang.c: Revert.
1964         * extension.h: Revert.
1965         * extension.c: Revert.
1966         * extension-priv.h: Revert.
1967         * expprint.c: Revert.
1968         * exec.h: Revert.
1969         * exec.c: Revert.
1970         * exceptions.c: Revert.
1971         * event-top.c: Revert.
1972         * event-loop.c: Revert.
1973         * eval.c: Revert.
1974         * elfread.c: Revert.
1975         * dwarf2read.h: Revert.
1976         * dwarf2read.c: Revert.
1977         * dwarf2loc.c: Revert.
1978         * dwarf2expr.h: Revert.
1979         * dwarf2expr.c: Revert.
1980         * dwarf2-frame.c: Revert.
1981         * dwarf2-frame-tailcall.c: Revert.
1982         * dwarf-index-write.h: Revert.
1983         * dwarf-index-write.c: Revert.
1984         * dwarf-index-common.c: Revert.
1985         * dwarf-index-cache.h: Revert.
1986         * dwarf-index-cache.c: Revert.
1987         * dummy-frame.c: Revert.
1988         * dtrace-probe.c: Revert.
1989         * disasm.h: Revert.
1990         * disasm.c: Revert.
1991         * disasm-selftests.c: Revert.
1992         * dictionary.c: Revert.
1993         * dicos-tdep.c: Revert.
1994         * demangle.c: Revert.
1995         * dcache.h: Revert.
1996         * dcache.c: Revert.
1997         * darwin-nat.h: Revert.
1998         * darwin-nat.c: Revert.
1999         * darwin-nat-info.c: Revert.
2000         * d-valprint.c: Revert.
2001         * d-namespace.c: Revert.
2002         * d-lang.c: Revert.
2003         * ctf.c: Revert.
2004         * csky-tdep.c: Revert.
2005         * csky-linux-tdep.c: Revert.
2006         * cris-tdep.c: Revert.
2007         * cris-linux-tdep.c: Revert.
2008         * cp-valprint.c: Revert.
2009         * cp-support.c: Revert.
2010         * cp-namespace.c: Revert.
2011         * cp-abi.c: Revert.
2012         * corelow.c: Revert.
2013         * corefile.c: Revert.
2014         * continuations.c: Revert.
2015         * completer.h: Revert.
2016         * completer.c: Revert.
2017         * complaints.c: Revert.
2018         * coffread.c: Revert.
2019         * coff-pe-read.c: Revert.
2020         * cli-out.h: Revert.
2021         * cli-out.c: Revert.
2022         * charset.c: Revert.
2023         * c-varobj.c: Revert.
2024         * c-valprint.c: Revert.
2025         * c-typeprint.c: Revert.
2026         * c-lang.c: Revert.
2027         * buildsym.c: Revert.
2028         * buildsym-legacy.c: Revert.
2029         * build-id.h: Revert.
2030         * build-id.c: Revert.
2031         * btrace.c: Revert.
2032         * bsd-uthread.c: Revert.
2033         * breakpoint.h: Revert.
2034         * breakpoint.c: Revert.
2035         * break-catch-throw.c: Revert.
2036         * break-catch-syscall.c: Revert.
2037         * break-catch-sig.c: Revert.
2038         * blockframe.c: Revert.
2039         * block.c: Revert.
2040         * bfin-tdep.c: Revert.
2041         * bfin-linux-tdep.c: Revert.
2042         * bfd-target.c: Revert.
2043         * bcache.c: Revert.
2044         * ax-general.c: Revert.
2045         * ax-gdb.h: Revert.
2046         * ax-gdb.c: Revert.
2047         * avr-tdep.c: Revert.
2048         * auxv.c: Revert.
2049         * auto-load.c: Revert.
2050         * arm-wince-tdep.c: Revert.
2051         * arm-tdep.c: Revert.
2052         * arm-symbian-tdep.c: Revert.
2053         * arm-pikeos-tdep.c: Revert.
2054         * arm-obsd-tdep.c: Revert.
2055         * arm-nbsd-tdep.c: Revert.
2056         * arm-nbsd-nat.c: Revert.
2057         * arm-linux-tdep.c: Revert.
2058         * arm-linux-nat.c: Revert.
2059         * arm-fbsd-tdep.c: Revert.
2060         * arm-fbsd-nat.c: Revert.
2061         * arm-bsd-tdep.c: Revert.
2062         * arch-utils.c: Revert.
2063         * arc-tdep.c: Revert.
2064         * arc-newlib-tdep.c: Revert.
2065         * annotate.h: Revert.
2066         * annotate.c: Revert.
2067         * amd64-windows-tdep.c: Revert.
2068         * amd64-windows-nat.c: Revert.
2069         * amd64-tdep.c: Revert.
2070         * amd64-sol2-tdep.c: Revert.
2071         * amd64-obsd-tdep.c: Revert.
2072         * amd64-obsd-nat.c: Revert.
2073         * amd64-nbsd-tdep.c: Revert.
2074         * amd64-nbsd-nat.c: Revert.
2075         * amd64-nat.c: Revert.
2076         * amd64-linux-tdep.c: Revert.
2077         * amd64-linux-nat.c: Revert.
2078         * amd64-fbsd-tdep.c: Revert.
2079         * amd64-fbsd-nat.c: Revert.
2080         * amd64-dicos-tdep.c: Revert.
2081         * amd64-darwin-tdep.c: Revert.
2082         * amd64-bsd-nat.c: Revert.
2083         * alpha-tdep.c: Revert.
2084         * alpha-obsd-tdep.c: Revert.
2085         * alpha-nbsd-tdep.c: Revert.
2086         * alpha-mdebug-tdep.c: Revert.
2087         * alpha-linux-tdep.c: Revert.
2088         * alpha-linux-nat.c: Revert.
2089         * alpha-bsd-tdep.c: Revert.
2090         * alpha-bsd-nat.c: Revert.
2091         * aix-thread.c: Revert.
2092         * agent.c: Revert.
2093         * addrmap.c: Revert.
2094         * ada-varobj.c: Revert.
2095         * ada-valprint.c: Revert.
2096         * ada-typeprint.c: Revert.
2097         * ada-tasks.c: Revert.
2098         * ada-lang.c: Revert.
2099         * aarch64-tdep.c: Revert.
2100         * aarch64-ravenscar-thread.c: Revert.
2101         * aarch64-newlib-tdep.c: Revert.
2102         * aarch64-linux-tdep.c: Revert.
2103         * aarch64-linux-nat.c: Revert.
2104         * aarch64-fbsd-tdep.c: Revert.
2105         * aarch64-fbsd-nat.c: Revert.
2106         * aarch32-linux-nat.c: Revert.
2107
2108 2019-04-05  Tom Tromey  <tom@tromey.com>
2109
2110         * ft32-tdep.c: Sort headers.
2111         * frv-tdep.c: Sort headers.
2112         * frv-linux-tdep.c: Sort headers.
2113         * frame.c: Sort headers.
2114         * frame-unwind.c: Sort headers.
2115         * frame-base.c: Sort headers.
2116         * fork-child.c: Sort headers.
2117         * findvar.c: Sort headers.
2118         * findcmd.c: Sort headers.
2119         * filesystem.c: Sort headers.
2120         * filename-seen-cache.h: Sort headers.
2121         * filename-seen-cache.c: Sort headers.
2122         * fbsd-tdep.c: Sort headers.
2123         * fbsd-nat.h: Sort headers.
2124         * fbsd-nat.c: Sort headers.
2125         * f-valprint.c: Sort headers.
2126         * f-typeprint.c: Sort headers.
2127         * f-lang.c: Sort headers.
2128         * extension.h: Sort headers.
2129         * extension.c: Sort headers.
2130         * extension-priv.h: Sort headers.
2131         * expprint.c: Sort headers.
2132         * exec.h: Sort headers.
2133         * exec.c: Sort headers.
2134         * exceptions.c: Sort headers.
2135         * event-top.c: Sort headers.
2136         * event-loop.c: Sort headers.
2137         * eval.c: Sort headers.
2138         * elfread.c: Sort headers.
2139         * dwarf2read.h: Sort headers.
2140         * dwarf2read.c: Sort headers.
2141         * dwarf2loc.c: Sort headers.
2142         * dwarf2expr.h: Sort headers.
2143         * dwarf2expr.c: Sort headers.
2144         * dwarf2-frame.c: Sort headers.
2145         * dwarf2-frame-tailcall.c: Sort headers.
2146         * dwarf-index-write.h: Sort headers.
2147         * dwarf-index-write.c: Sort headers.
2148         * dwarf-index-common.c: Sort headers.
2149         * dwarf-index-cache.h: Sort headers.
2150         * dwarf-index-cache.c: Sort headers.
2151         * dummy-frame.c: Sort headers.
2152         * dtrace-probe.c: Sort headers.
2153         * disasm.h: Sort headers.
2154         * disasm.c: Sort headers.
2155         * disasm-selftests.c: Sort headers.
2156         * dictionary.c: Sort headers.
2157         * dicos-tdep.c: Sort headers.
2158         * demangle.c: Sort headers.
2159         * dcache.h: Sort headers.
2160         * dcache.c: Sort headers.
2161         * darwin-nat.h: Sort headers.
2162         * darwin-nat.c: Sort headers.
2163         * darwin-nat-info.c: Sort headers.
2164         * d-valprint.c: Sort headers.
2165         * d-namespace.c: Sort headers.
2166         * d-lang.c: Sort headers.
2167         * ctf.c: Sort headers.
2168         * csky-tdep.c: Sort headers.
2169         * csky-linux-tdep.c: Sort headers.
2170         * cris-tdep.c: Sort headers.
2171         * cris-linux-tdep.c: Sort headers.
2172         * cp-valprint.c: Sort headers.
2173         * cp-support.c: Sort headers.
2174         * cp-namespace.c: Sort headers.
2175         * cp-abi.c: Sort headers.
2176         * corelow.c: Sort headers.
2177         * corefile.c: Sort headers.
2178         * continuations.c: Sort headers.
2179         * completer.h: Sort headers.
2180         * completer.c: Sort headers.
2181         * complaints.c: Sort headers.
2182         * coffread.c: Sort headers.
2183         * coff-pe-read.c: Sort headers.
2184         * cli-out.h: Sort headers.
2185         * cli-out.c: Sort headers.
2186         * charset.c: Sort headers.
2187         * c-varobj.c: Sort headers.
2188         * c-valprint.c: Sort headers.
2189         * c-typeprint.c: Sort headers.
2190         * c-lang.c: Sort headers.
2191         * buildsym.c: Sort headers.
2192         * buildsym-legacy.c: Sort headers.
2193         * build-id.h: Sort headers.
2194         * build-id.c: Sort headers.
2195         * btrace.c: Sort headers.
2196         * bsd-uthread.c: Sort headers.
2197         * breakpoint.h: Sort headers.
2198         * breakpoint.c: Sort headers.
2199         * break-catch-throw.c: Sort headers.
2200         * break-catch-syscall.c: Sort headers.
2201         * break-catch-sig.c: Sort headers.
2202         * blockframe.c: Sort headers.
2203         * block.c: Sort headers.
2204         * bfin-tdep.c: Sort headers.
2205         * bfin-linux-tdep.c: Sort headers.
2206         * bfd-target.c: Sort headers.
2207         * bcache.c: Sort headers.
2208         * ax-general.c: Sort headers.
2209         * ax-gdb.h: Sort headers.
2210         * ax-gdb.c: Sort headers.
2211         * avr-tdep.c: Sort headers.
2212         * auxv.c: Sort headers.
2213         * auto-load.c: Sort headers.
2214         * arm-wince-tdep.c: Sort headers.
2215         * arm-tdep.c: Sort headers.
2216         * arm-symbian-tdep.c: Sort headers.
2217         * arm-pikeos-tdep.c: Sort headers.
2218         * arm-obsd-tdep.c: Sort headers.
2219         * arm-nbsd-tdep.c: Sort headers.
2220         * arm-nbsd-nat.c: Sort headers.
2221         * arm-linux-tdep.c: Sort headers.
2222         * arm-linux-nat.c: Sort headers.
2223         * arm-fbsd-tdep.c: Sort headers.
2224         * arm-fbsd-nat.c: Sort headers.
2225         * arm-bsd-tdep.c: Sort headers.
2226         * arch-utils.c: Sort headers.
2227         * arc-tdep.c: Sort headers.
2228         * arc-newlib-tdep.c: Sort headers.
2229         * annotate.h: Sort headers.
2230         * annotate.c: Sort headers.
2231         * amd64-windows-tdep.c: Sort headers.
2232         * amd64-windows-nat.c: Sort headers.
2233         * amd64-tdep.c: Sort headers.
2234         * amd64-sol2-tdep.c: Sort headers.
2235         * amd64-obsd-tdep.c: Sort headers.
2236         * amd64-obsd-nat.c: Sort headers.
2237         * amd64-nbsd-tdep.c: Sort headers.
2238         * amd64-nbsd-nat.c: Sort headers.
2239         * amd64-nat.c: Sort headers.
2240         * amd64-linux-tdep.c: Sort headers.
2241         * amd64-linux-nat.c: Sort headers.
2242         * amd64-fbsd-tdep.c: Sort headers.
2243         * amd64-fbsd-nat.c: Sort headers.
2244         * amd64-dicos-tdep.c: Sort headers.
2245         * amd64-darwin-tdep.c: Sort headers.
2246         * amd64-bsd-nat.c: Sort headers.
2247         * alpha-tdep.c: Sort headers.
2248         * alpha-obsd-tdep.c: Sort headers.
2249         * alpha-nbsd-tdep.c: Sort headers.
2250         * alpha-mdebug-tdep.c: Sort headers.
2251         * alpha-linux-tdep.c: Sort headers.
2252         * alpha-linux-nat.c: Sort headers.
2253         * alpha-bsd-tdep.c: Sort headers.
2254         * alpha-bsd-nat.c: Sort headers.
2255         * aix-thread.c: Sort headers.
2256         * agent.c: Sort headers.
2257         * addrmap.c: Sort headers.
2258         * ada-varobj.c: Sort headers.
2259         * ada-valprint.c: Sort headers.
2260         * ada-typeprint.c: Sort headers.
2261         * ada-tasks.c: Sort headers.
2262         * ada-lang.c: Sort headers.
2263         * aarch64-tdep.c: Sort headers.
2264         * aarch64-ravenscar-thread.c: Sort headers.
2265         * aarch64-newlib-tdep.c: Sort headers.
2266         * aarch64-linux-tdep.c: Sort headers.
2267         * aarch64-linux-nat.c: Sort headers.
2268         * aarch64-fbsd-tdep.c: Sort headers.
2269         * aarch64-fbsd-nat.c: Sort headers.
2270         * aarch32-linux-nat.c: Sort headers.
2271
2272 2019-04-04  Tom Tromey  <tom@tromey.com>
2273
2274         * varobj.c (varobj_create): Update.
2275         * rust-exp.y (struct rust_parser) <update_innermost_block,
2276         lookup_symbol>: New methods.
2277         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2278         Rename.
2279         (rust_parser::rust_lookup_type)
2280         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2281         * printcmd.c (display_command, do_one_display): Update.
2282         * parser-defs.h (struct parser_state) <parser_state>: Add
2283         "tracker" parameter.
2284         (block_tracker): New member.
2285         (class innermost_block_tracker) <innermost_block_tracker>: Add
2286         "types" parameter.
2287         <reset>: Remove method.
2288         (innermost_block): Don't declare.
2289         (null_post_parser): Update.
2290         * parse.c (innermost_block): Remove global.
2291         (write_dollar_variable): Update.
2292         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2293         Remove "tracker_types" parameter.
2294         (parse_expression): Add "tracker" parameter.
2295         (parse_expression_for_completion): Update.
2296         (null_post_parser): Add "tracker" parameter.
2297         * p-exp.y: Update rules.
2298         * m2-exp.y: Update rules.
2299         * language.h (struct language_defn) <la_post_parser>: Add
2300         "tracker" parameter.
2301         * go-exp.y: Update rules.
2302         * f-exp.y: Update rules.
2303         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2304         parameter.
2305         * d-exp.y: Update rules.
2306         * c-exp.y: Update rules.
2307         * breakpoint.c (set_breakpoint_condition): Create an
2308         innermost_block_tracker.
2309         (watch_command_1): Likewise.
2310         * ada-lang.c (resolve): Add "tracker" parameter.
2311         (resolve_subexp): Likewise.
2312         * ada-exp.y (write_var_from_sym): Update.
2313
2314 2019-04-04  Tom Tromey  <tom@tromey.com>
2315
2316         * type-stack.h: New file.
2317         * type-stack.c: New file.
2318         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2319         type-stack.h.
2320         (insert_into_type_stack, insert_type, push_type, push_type_int)
2321         (insert_type_address_space, pop_type, pop_type_int)
2322         (pop_typelist, pop_type_stack, append_type_stack)
2323         (push_type_stack, get_type_stack, push_typelist)
2324         (follow_type_instance_flags, follow_types): Don't declare.
2325         * parse.c (type_stack): Remove global.
2326         (parse_exp_in_context): Update.
2327         (insert_into_type_stack, insert_type, push_type, push_type_int)
2328         (insert_type_address_space, pop_type, pop_type_int)
2329         (pop_typelist, pop_type_stack, append_type_stack)
2330         (push_type_stack, get_type_stack, push_typelist)
2331         (follow_type_instance_flags, follow_types): Remove (moved to
2332         type-stack.c).
2333         * f-exp.y (type_stack): New global.
2334         Update rules.
2335         (push_kind_type, f_parse): Update.
2336         * d-exp.y (type_stack): New global.
2337         Update rules.
2338         (d_parse): Update.
2339         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2340         Update rules.
2341         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2342         (HFILES_NO_SRCDIR): Add type-stack.h.
2343
2344 2019-04-04  Tom Tromey  <tom@tromey.com>
2345
2346         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2347         (rust_parser::convert_ast_to_expression, rust_parse)
2348         (rust_lex_test_completion, rust_lex_tests): Update.
2349         * parser-defs.h (struct expr_completion_state): New.
2350         (struct parser_state) <parser_state>: Add completion parameter.
2351         <mark_struct_expression, mark_completion_tag>: New methods.
2352         <parse_completion, m_completion_state>: New members.
2353         (prefixify_expression, null_post_parser): Update.
2354         (mark_struct_expression, mark_completion_tag): Don't declare.
2355         * parse.c (parse_completion, expout_last_struct)
2356         (expout_tag_completion_type, expout_completion_name): Remove
2357         globals.
2358         (parser_state::mark_struct_expression)
2359         (parser_state::mark_completion_tag): Now methods.
2360         (prefixify_expression): Add last_struct parameter.
2361         (prefixify_subexp): Likewise.
2362         (parse_exp_1): Update.
2363         (parse_exp_in_context): Add cstate parameter.  Update.
2364         (parse_expression_for_completion): Create an
2365         expr_completion_state.
2366         (null_post_parser): Add "completion" parameter.
2367         * p-exp.y: Update rules.
2368         (yylex): Update.
2369         * language.h (struct language_defn) <la_post_parser>: Add
2370         "completing" parameter.
2371         * go-exp.y: Update rules.
2372         (lex_one_token): Update.
2373         * expression.h (parse_completion): Don't declare.
2374         * d-exp.y: Update rules.
2375         (lex_one_token): Update rules.
2376         * c-exp.y: Update rules.
2377         (lex_one_token): Update.
2378         * ada-lang.c (resolve): Add "parse_completion" parameter.
2379         (resolve_subexp): Likewise.
2380         (ada_resolve_function): Likewise.
2381
2382 2019-04-04  Tom Tromey  <tom@tromey.com>
2383
2384         * parser-defs.h (struct parser_state) <start_arglist,
2385         end_arglist>: New methods.
2386         <arglist_len, m_funcall_chain>: New members.
2387         (arglist_len, start_arglist, end_arglist): Don't declare.
2388         * parse.c (arglist_len, funcall_chain): Remove global.
2389         (start_arglist, end_arglist): Remove functions.
2390         (parse_exp_in_context): Update.
2391         * p-exp.y: Update rules.
2392         * m2-exp.y: Update rules.
2393         * go-exp.y: Update rules.
2394         * f-exp.y: Update rules.
2395         * d-exp.y: Update rules.
2396         * c-exp.y: Update rules.
2397
2398 2019-04-04  Tom Tromey  <tom@tromey.com>
2399
2400         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2401         lex_operator, push_back>: New methods.
2402         Update all rules.
2403         (rust_parser::lex_hex, lex_escape): Rename and update.
2404         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2405         (rust_parser::lex_operator): Rename and update.
2406         (rust_parser::lex_number, rustyylex, rustyyerror)
2407         (rust_lex_test_init, rust_lex_test_sequence)
2408         (rust_lex_test_push_back, rust_lex_tests): Update.
2409         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2410         parameter.
2411         <lexptr, prev_lexptr>: New members.
2412         (lexptr, prev_lexptr): Don't declare.
2413         * parse.c (lexptr, prev_lexptr): Remove globals.
2414         (parse_exp_in_context): Update.
2415         * p-exp.y (yylex, yyerror): Update.
2416         * m2-exp.y (parse_number, yylex, yyerror): Update.
2417         * go-exp.y (lex_one_token, yyerror): Update.
2418         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2419         * d-exp.y (lex_one_token, yyerror): Update.
2420         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2421         (lex_one_token, yyerror): Update.
2422         * ada-lex.l (YY_INPUT): Update.
2423         (rewind_to_char): Update.
2424         * ada-exp.y (yyerror): Update.
2425
2426 2019-04-04  Tom Tromey  <tom@tromey.com>
2427
2428         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2429         * parser-defs.h (struct parser_state) <parser_state>: Add new
2430         parameter.
2431         <comma_terminates>: New member.
2432         (comma_terminates): Don't declare global.
2433         * parse.c (comma_terminates): Remove global.
2434         (parse_exp_in_context): Update.
2435         * p-exp.y (yylex): Update.
2436         * m2-exp.y (yylex): Update.
2437         * go-exp.y (lex_one_token): Update.
2438         * f-exp.y (yylex): Update.
2439         * d-exp.y (lex_one_token): Update.
2440         * c-exp.y (lex_one_token): Update.
2441         * ada-lex.l: Update.
2442
2443 2019-04-04  Tom Tromey  <tom@tromey.com>
2444
2445         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2446         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2447         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2448         * parser-defs.h (paren_depth): Don't declare.
2449         * parse.c (paren_depth): Remove global.
2450         (parse_exp_in_context): Update.
2451         * p-exp.y (paren_depth): New global.
2452         (pascal_parse): Initialize it.
2453         * m2-exp.y (paren_depth): New global.
2454         (m2_parse): Initialize it.
2455         * go-exp.y (paren_depth): New global.
2456         (go_parse): Initialize it.
2457         * f-exp.y (paren_depth): New global.
2458         (f_parse): Initialize it.
2459         * d-exp.y (paren_depth): New global.
2460         (d_parse): Initialize it.
2461         * c-exp.y (paren_depth): New global.
2462         (c_parse): Initialize it.
2463         * ada-lex.l (paren_depth): New global.
2464         (lexer_init): Initialize it.
2465
2466 2019-04-04  Tom Tromey  <tom@tromey.com>
2467
2468         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2469         (rust_parser::convert_ast_to_type)
2470         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2471         * parser-defs.h (struct parser_state) <parser_state>: Add
2472         parameters.  Initialize new members.
2473         <expression_context_block, expression_context_pc>: New members.
2474         * parse.c (expression_context_block, expression_context_pc):
2475         Remove globals.
2476         (parse_exp_in_context): Update.
2477         * p-exp.y: Update all rules.
2478         (yylex): Update.
2479         * m2-exp.y: Update all rules.
2480         (yylex): Update.
2481         * go-exp.y (yylex): Update.
2482         * f-exp.y (yylex): Update.
2483         * d-exp.y: Update all rules.
2484         (yylex): Update.
2485         * c-exp.y: Update all rules.
2486         (lex_one_token, classify_name, yylex, c_parse): Update.
2487         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2488
2489 2019-04-04  Tom Tromey  <tom@tromey.com>
2490
2491         * gdbarch.h, gdbarch.c: Rebuild.
2492         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2493         * stap-probe.h:
2494         (struct stap_parse_info): Replace "parser_state" with
2495         "expr_builder".
2496         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2497         (parser_state): New class.
2498         * parse.c (expr_builder): Rename.
2499         (expr_builder::release): Rename.
2500         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2501         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2502         (write_exp_elt_longcst, write_exp_elt_floatcst)
2503         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2504         (write_exp_string_vector, write_exp_bitstring)
2505         (write_exp_msymbol, mark_struct_expression)
2506         (write_dollar_variable)
2507         (insert_type_address_space, increase_expout_size): Replace
2508         "parser_state" with "expr_builder".
2509         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2510         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2511         "parser_state" with "expr_builder".
2512
2513 2019-04-04  Tom Tromey  <tom@tromey.com>
2514
2515         * rust-exp.y: Replace "parse_language" with method call.
2516         * p-exp.y:
2517         (yylex): Replace "parse_language" with method call.
2518         * m2-exp.y:
2519         (yylex): Replace "parse_language" with method call.
2520         * go-exp.y (classify_name): Replace "parse_language" with method
2521         call.
2522         * f-exp.y (yylex): Replace "parse_language" with method call.
2523         * d-exp.y (lex_one_token): Replace "parse_language" with method
2524         call.
2525         * c-exp.y:
2526         (lex_one_token, classify_name, yylex): Replace "parse_language"
2527         with method call.
2528         * ada-exp.y (find_primitive_type, type_char)
2529         (type_system_address): Replace "parse_language" with method call.
2530
2531 2019-04-04  Tom Tromey  <tom@tromey.com>
2532
2533         * rust-exp.y: Replace "parse_gdbarch" with method call.
2534         * parse.c (write_dollar_variable, insert_type_address_space):
2535         Replace "parse_gdbarch" with method call.
2536         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2537         call.
2538         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2539         call.
2540         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2541         "parse_gdbarch" with method call.
2542         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2543         with method call.
2544         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2545         "parse_gdbarch" with method call.
2546         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2547         "parse_gdbarch" with method call.
2548         * c-exp.y (parse_type, parse_number, classify_name): Replace
2549         "parse_gdbarch" with method call.
2550         * ada-lex.l: Replace "parse_gdbarch" with method call.
2551         * ada-exp.y (parse_type, find_primitive_type, type_char)
2552         (type_system_address): Replace "parse_gdbarch" with method call.
2553
2554 2019-04-04  Tom Tromey  <tom@tromey.com>
2555
2556         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2557         * stap-probe.c (stap_parse_argument): Update.
2558         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2559         initial_size parameter.
2560         * rust-exp.y (rust_lex_tests): Update.
2561         * parse.c (parser_state): Update.
2562         (parse_exp_in_context): Update.
2563         * parser-defs.h (struct parser_state) <parser_state>: Remove
2564         "initial_size" parameter.
2565
2566 2019-04-04  Tom Tromey  <tom@tromey.com>
2567
2568         * parser-defs.h (increase_expout_size): Don't declare.
2569         * parse.c (increase_expout_size): Now static.
2570
2571 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2572
2573         * gnu-nat.c (gnu_nat_target::wait): Fix
2574         target_waitstatus_to_string call.
2575
2576 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2577
2578         * eval.c (evaluate_subexp_standard): Handle internal functions
2579         during Fortran function call handling.
2580
2581 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2582
2583         * NEWS: Mention new internal functions.
2584         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2585         (read_base_type): Use dwarf2_init_complex_target_type.
2586         * value.c (creal_internal_fn): New function.
2587         (cimag_internal_fn): New function.
2588         (_initialize_values): Register new internal functions.
2589
2590 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2591
2592         * infrun.c (stop_all_threads): If debug_infrun, always
2593         trace the wait status after wait_one, using
2594         target_waitstatus_to_string and target_pid_to_str.
2595         (handle_inferior_event): Replace various trace of
2596         wait status kind by a single trace.
2597         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2598         wait status kind image by target_waitstatus_to_string.
2599         * target/waitstatus.c (target_waitstatus_to_string): Fix
2600         obsolete comment.
2601
2602 2019-04-01  Tom Tromey  <tromey@adacore.com>
2603
2604         PR symtab/23331:
2605         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2606
2607 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2608             Pedro Alves  <palves@redhat.com>
2609
2610         * top.c (quit_force): Call 'finalize_values'.
2611         * value.c (finalize_values): New function.
2612         * value.h (finalize_values): Declare.
2613
2614 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2615
2616         * NEWS: Announce $_gdb_major and $_gdb_minor.
2617
2618         * top.c (init_gdb_version_vars): New function.
2619         (gdb_init): Call init_gdb_version_vars.
2620
2621 2019-03-29  Tom Tromey  <tromey@adacore.com>
2622
2623         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2624         help text.  Remove dead code.
2625
2626 2019-03-29  Keith Seitz  <keiths@redhat.com>
2627
2628         From Siddhesh Poyarekar:
2629         * f-lang.h (f77_get_upperbound): Return LONGEST.
2630         (f77_get_lowerbound): Likewise.
2631         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2632         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2633         print them.
2634         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2635         plongest to format print it.
2636         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2637         (f77_get_upperbound): Likewise.
2638         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2639         LOWER_BOUND to LONGEST.
2640         (f77_create_arrayprint_offset_tbl): Likewise.
2641
2642 2019-03-29  Keith Seitz  <keiths@redhat.com>
2643
2644         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2645         %s/pulongest for TYPE_LENGTH instead of %d in format
2646         strings.
2647         * ada-typerint.c (ada_print_type): Likewise.
2648         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2649         * compile/compile-c-support.c (generate_register_struct): Likewise.
2650         * gdbtypes.c (recursive_dump_type): Likewise.
2651         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2652         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2653         instead of %d in format strings.
2654         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2655         to std::min to ULONGEST.
2656         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2657         instead of %d in format strings.
2658         * tracepoint.c (info_scope_command): Likewise.
2659         * typeprint.c (print_offset_data::update)
2660         (print_offset_data::finish): Likewise.
2661         * xtensa-tdep.c (xtensa_store_return_value)
2662         (xtensa_push_dummy_call): Likewise.
2663
2664 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2665
2666         * windows-nat.c (display_selector): Fixed format specifications
2667         for 64-bit Cygwin.
2668
2669 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2670
2671         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2672
2673 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2674
2675         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2676         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2677         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2678         (nios2_linux_init_abi): Install it.
2679
2680 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2681
2682         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2683
2684 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2685
2686         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2687
2688 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2689             Tom Tromey  <tromey@adacore.com>
2690
2691         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2692
2693 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2694
2695         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2696         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2697         method to compute the bounds of range types. Also print "[evaluated]"
2698         if the bounds' values come from a dynamic evaluation.
2699
2700 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2701
2702         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2703         whitespace when pretty printing is on.
2704
2705 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2706
2707         * ppc-linux-nat.c: Add include.
2708
2709 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2710
2711         * NEWS: Mention AArch64 Pointer Authentication.
2712
2713 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2714
2715         * arm-linux-nat.c: Add include.
2716
2717 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2718
2719         * source-cache.c (source_cache::get_source_lines): Re-read
2720         fullname after calling open_source_file.
2721
2722 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2723
2724         * NEWS: Mention TLS support for FreeBSD.
2725
2726 2019-03-25  Tom Tromey  <tromey@adacore.com>
2727
2728         * minsyms.c (BUNCH_SIZE): Update comment.
2729         (~minimal_symbol_reader): Remove old comment.
2730         (compact_minimal_symbols): Update comment.
2731         (minimal_symbol_reader::install): Remove old comment.  Update
2732         other comments.
2733
2734 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2735
2736         * s390-linux-nat.c: Add include.
2737
2738 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2739
2740         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2741         Call linux_get_hwcap.
2742         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2743         Likewise.
2744         (aarch64_linux_get_hwcap): Remove function.
2745         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2746         declaration.
2747         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2748         linux_get_hwcap.
2749         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2750         * linux-tdep.c (linux_get_hwcap): Add function.
2751         (linux_get_hwcap2): Likewise.
2752         * linux-tdep.h (linux_get_hwcap): Add declaration.
2753         (linux_get_hwcap2): Likewise.
2754         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2755         (ppc_linux_get_hwcap2): Likewise.
2756         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2757         linux_get_hwcap.
2758         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2759         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2760         (ppc_linux_nat_target::read_description): Likewise.
2761         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2762         * s390-linux-nat.c: Likewise.
2763         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2764
2765 2019-03-24  Tom Tromey  <tom@tromey.com>
2766
2767         * ada-lang.c (standard_lookup): Simplify initialization.
2768         (ada_lookup_symbol_nonlocal): Simplify return.
2769         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2770         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2771         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2772         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2773         initialization.
2774         * solib.c (solib_global_lookup): Simplify.
2775         * symtab.c (null_block_symbol): Remove.
2776         (symbol_cache_lookup): Simplify returns.
2777         (lookup_language_this): Simplify returns.
2778         (lookup_symbol_aux): Simplify return.
2779         (lookup_local_symbol): Simplify returns.
2780         (lookup_global_symbol_from_objfile): Simplify return.
2781         (lookup_symbol_in_objfile_symtabs)
2782         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2783         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2784         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2785         * cp-namespace.c (cp_lookup_bare_symbol)
2786         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2787         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2788         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2789         (cp_lookup_symbol_via_imports): Simplify initialization.
2790         (find_symbol_in_baseclass): Likewise.
2791         * symtab.h (null_block_symbol): Remove.
2792         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2793         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2794         (d_lookup_symbol_module): Likewise.
2795         (find_symbol_in_baseclass): Simplify initialization.
2796
2797 2019-03-24  Tom Tromey  <tom@tromey.com>
2798
2799         * expression.h: Don't include symtab.h.
2800         (struct block): Forward declare.
2801
2802 2019-03-24  Tom Tromey  <tom@tromey.com>
2803
2804         * c-exp.y (typebase): Remove casts.
2805         * gdbtypes.c (lookup_unsigned_typename, )
2806         (lookup_signed_typename): Remove cast.
2807         * eval.c (parse_to_comma_and_eval): Remove cast.
2808         * parse.c (write_dollar_variable): Remove cast.
2809         * block.h (struct block) <superblock>: Now const.
2810         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2811         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2812         (map_block): Make "block" const.
2813         * symfile.h (struct quick_symbol_functions)
2814         <map_matching_symbols>: Constify block argument to "callback".
2815         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2816         const.
2817         (find_pc_sect_compunit_symtab): Make "b" const.
2818         (find_symbol_at_address): Likewise.
2819         (search_symbols): Likewise.
2820         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2821         (dw2_debug_names_lookup_symbol): Likewise.
2822         (dw2_map_matching_symbols): Update.
2823         * p-valprint.c (pascal_val_print): Remove "block".
2824         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2825         (aux_add_nonlocal_symbols): Make "block" const.
2826         (resolve_subexp): Remove cast.
2827         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2828         const.
2829         (iterate_over_file_blocks): Likewise.
2830         * f-exp.y (%union) <bval>: Remove.
2831         * coffread.c (patch_opaque_types): Make "b" const.
2832         * spu-tdep.c (spu_catch_start): Make "block" const.
2833         * c-valprint.c (print_unpacked_pointer): Remove "block".
2834         * symmisc.c (dump_symtab_1): Make "b" const.
2835         (block_depth): Make "block" const.
2836         * d-exp.y (%union) <bval>: Remove.
2837         * cp-support.h (cp_lookup_rtti_type): Update.
2838         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2839         * psymtab.c (psym_lookup_symbol): Make "block" const.
2840         (maintenance_check_psymtabs): Make "b" const.
2841         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2842         (enumerate_locals, enumerate_args): Update.
2843         * python/py-symtab.c (stpy_global_block): Make "block" const.
2844         (stpy_static_block): Likewise.
2845         * inline-frame.c (block_starting_point_at): Make "new_block"
2846         const.
2847         * block.c (find_block_in_blockvector): Make return type const.
2848         (blockvector_for_pc_sect): Make "b" const.
2849         (find_block_in_blockvector): Make "b" const.
2850
2851 2019-03-23  Tom Tromey  <tom@tromey.com>
2852
2853         * varobj.c (varobj_create): Update.
2854         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2855         * printcmd.c (display_command, do_one_display): Don't reset
2856         innermost_block.
2857         * parser-defs.h (enum innermost_block_tracker_type): Move to
2858         expression.h.
2859         (innermost_block): Update comment.
2860         * parse.c (parse_exp_1): Add tracker_types parameter.
2861         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2862         tracker_types parameter.  Reset innermost_block.
2863         (parse_exp_in_context): Remove.
2864         (parse_expression_for_completion): Update.
2865         * objfiles.c (~objfile): Don't reset expression_context_block or
2866         innermost_block.
2867         * expression.h (enum innermost_block_tracker_type): Move from
2868         parser-defs.h.
2869         (parse_exp_1): Add tracker_types parameter.
2870         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2871         reset innermost_block.
2872
2873 2019-03-23  Tom Tromey  <tom@tromey.com>
2874
2875         * objfiles.h: Include bcache.h.
2876
2877 2019-03-23  Tom Tromey  <tom@tromey.com>
2878
2879         * linespec.c (get_current_search_block): Use
2880         scoped_restore_current_language.
2881         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2882
2883 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2884             Jiong Wang  <jiong.wang@arm.com>
2885
2886         * aarch64-linux-tdep.c
2887         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2888         section.
2889         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2890
2891 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2892             Jiong Wang  <jiong.wang@arm.com>
2893
2894         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2895         instructions.
2896         (aarch64_analyze_prologue_test): Add PACIASP test.
2897         (aarch64_prologue_prev_register): Unmask PC value.
2898
2899 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2900             Jiong Wang  <jiong.wang@arm.com>
2901
2902         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2903         (aarch64_dwarf2_prev_register): Unmask PC value.
2904         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2905         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2906         DW_CFA_AARCH64_negate_ra_state.
2907         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2908
2909 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2910             Jiong Wang  <jiong.wang@arm.com>
2911
2912         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2913         registers.
2914         (aarch64_pseudo_register_name): Likewise.
2915         (aarch64_pseudo_register_type): Likewise.
2916         (aarch64_pseudo_register_reggroup_p): Likewise.
2917         (aarch64_gdbarch_init): Add pauth registers.
2918         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2919         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2920         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2921         (struct gdbarch_tdep): Add regnum for ra_state.
2922
2923 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2924             Jiong Wang  <jiong.wang@arm.com>
2925
2926         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2927
2928 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2929             Jiong Wang  <jiong.wang@arm.com>
2930
2931         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2932         function.
2933         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2934         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2935         (aarch64_gdbarch_init): Add puth registers.
2936         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2937         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2938         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2939
2940 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2941             Jiong Wang  <jiong.wang@arm.com>
2942
2943         * aarch64-linux-nat.c
2944         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2945         * aarch64-linux-tdep.c
2946         (aarch64_linux_core_read_description): Likewise.
2947         (aarch64_linux_get_hwcap): New function.
2948         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2949         (aarch64_linux_get_hwcap): New declaration.
2950
2951 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2952             Jiong Wang  <jiong.wang@arm.com>
2953
2954         * aarch64-linux-nat.c
2955         (aarch64_linux_nat_target::read_description): Add pauth param.
2956         * aarch64-linux-tdep.c
2957         (aarch64_linux_core_read_description): Likewise.
2958         * aarch64-tdep.c (struct target_desc): Add in pauth.
2959         (aarch64_read_description): Add pauth param.
2960         (aarch64_gdbarch_init): Likewise.
2961         * aarch64-tdep.h (aarch64_read_description): Likewise.
2962         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2963         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2964         * features/Makefile: Add new files.
2965         * features/aarch64-pauth.c: New file.
2966         * features/aarch64-pauth.xml: New file.
2967
2968 2019-03-20  Tom Tromey  <tromey@adacore.com>
2969
2970         * infrun.c (handle_inferior_event): Rename from
2971         handle_inferior_event_1.  Create a scoped_value_mark.
2972         (handle_inferior_event): Remove.
2973
2974 2019-03-19  Tom Tromey  <tromey@adacore.com>
2975
2976         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2977         * infrun.h (print_stop_event): Add "displays" parameter.
2978         * infrun.c (print_stop_event): Add "displays" parameter.
2979
2980 2019-03-19  Pedro Alves  <palves@redhat.com>
2981
2982         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2983         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2984         to -1.  Fix TABs vs spaces.
2985         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2986         * tui/tui-out.h (tui_ui_out) Add intro comments.
2987         <m_line, m_start_of_line>: In-class initialize, and add describing
2988         comment.
2989
2990 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2991
2992         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2993         variable names.
2994         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2995
2996 2019-03-18  Pedro Alves  <palves@redhat.com>
2997             Eli Zaretskii <eliz@gnu.org>
2998
2999         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3000         m_line and m_start_of_line.
3001
3002 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3003
3004         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3005         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3006         it returns a newline.  This fixes a regression in TU mode, whereby
3007         the next line is output on the same screen line as the user input.
3008
3009 2019-03-18  Tom Tromey  <tromey@adacore.com>
3010
3011         * minsyms.c (minimal_symbol_reader::install): Remove call to
3012         obstack_blank.
3013
3014 2019-03-18  Pedro Alves  <palves@redhat.com>
3015
3016         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3017         New globals.
3018         (apply_style): New, factored out from ...
3019         (apply_ansi_escape): ... this.  Handle reverse video mode.
3020         (tui_set_reverse_mode): New function.
3021         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3022         * tui/tui-winsource.c (tui_show_source_line): Use
3023         tui_set_reverse_mode instead of setting A_STANDOUT.
3024         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3025         New setter methods.
3026
3027 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3028
3029         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3030         Handle tabs.
3031
3032 2019-03-18  Tom Tromey  <tromey@adacore.com>
3033
3034         * ada-lang.c (empty_array): Add "high" parameter.
3035         (ada_evaluate_subexp): Update.
3036
3037 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3038
3039         * unittests/string_view-selftests.c: Define
3040         _initialize_string_view_selftests unconditionally.
3041
3042 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3043
3044         PR gdb/24350
3045         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3046
3047 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3048
3049         PR gdb/24351
3050         * windows-nat.c (display_selector): Fix format specifiers.
3051
3052 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3053
3054         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3055         tui_refill_source_window instead of tui_refresh_win, to update the
3056         current execution line.  This fixes redisplay of the current line
3057         when stepping through the code with "next" or "step".
3058
3059 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3060
3061         * source-cache.c (source_cache::get_source_lines): Call
3062         find_source_lines to initialize s->nlines.  This fixes vertical
3063         scrolling of TUI source window when the DOWN arrow is pressed.
3064
3065 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3066
3067         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3068         linux-thread-db.c (_initialize_thread_db): Likewise.
3069
3070 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3071
3072         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3073         wclrtoeol in tui_show_source_line".  This reverts changes made in
3074         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3075
3076 2019-03-15  Tom Tromey  <tom@tromey.com>
3077
3078         * symtab.h (struct minimal_symbol): Derive from
3079         general_symbol_info.
3080         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3081         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3082         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3083         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3084         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3085         (MSYMBOL_SEARCH_NAME): Update.
3086         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3087         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3088         * minsyms.c (minimal_symbol_reader::record_full): Update.
3089
3090 2019-03-15  Tom Tromey  <tom@tromey.com>
3091
3092         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3093
3094 2019-03-15  Tom Tromey  <tom@tromey.com>
3095
3096         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3097         unique_xmalloc_ptr.
3098         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3099         Update.
3100         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3101         (build_minimal_symbol_hash_tables)
3102         (minimal_symbol_reader::install): Update.
3103
3104 2019-03-15  Tom Tromey  <tom@tromey.com>
3105
3106         * symtab.c (create_demangled_names_hash): Update.
3107         (symbol_set_names): Update.
3108         * objfiles.h (struct objfile_per_bfd_storage)
3109         <demangled_names_hash>: Now an htab_up.
3110         * objfiles.c (objfile_per_bfd_storage): Simplify.
3111
3112 2019-03-15  Tom Tromey  <tom@tromey.com>
3113
3114         * objfiles.h (struct objfile_per_bfd_storage): Declare
3115         destructor.
3116         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3117         New.
3118         (get_objfile_bfd_data): Use new.  Don't initialize
3119         language_of_main.
3120         (free_objfile_per_bfd_storage): Remove.
3121         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3122
3123 2019-03-15  Tom Tromey  <tom@tromey.com>
3124
3125         * symfile.c (reread_symbols): Update.
3126         * objfiles.c (objfile::objfile): Update.
3127         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3128         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3129         comment.
3130         (minimal_symbol_reader::install): Update.
3131         (terminate_minimal_symbol_table): Remove.
3132         * jit.c (jit_object_close_impl): Update.
3133
3134 2019-03-15  Tom Tromey  <tom@tromey.com>
3135
3136         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3137         initializations.
3138
3139 2019-03-15  Tom Tromey  <tom@tromey.com>
3140
3141         * objfiles.h (struct objfile_per_bfd_storage)
3142         <demangled_hash_languages>: Now a bitset.
3143         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3144         (lookup_minimal_symbol): Update.
3145
3146 2019-03-15  Tom Tromey  <tom@tromey.com>
3147
3148         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3149         Don't return the symbol.
3150         * coffread.c (record_minimal_symbol): Use record_full.
3151
3152 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3153
3154         The MS-Windows port of ncurses fails to switch to a color pair if
3155         one or both of the colors are the implicit default colors.  This
3156         change records the default colors when TUI is initialized, and
3157         then specifies them explicitly when a color pair uses the default
3158         colors.  This allows color styling in TUI mode on MS-Windows.
3159
3160         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3161         ncurses_norm_attr.
3162         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3163         colors in ncurses_norm_attr.
3164         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3165         "none", replace it with the default color recorded in
3166         ncurses_norm_attr.
3167
3168 2019-03-14  Tom Tromey  <tromey@adacore.com>
3169
3170         * source-cache.h (class source_cache) <get_source_lines>: Return
3171         std::string.
3172         * source-cache.c (source_cache::extract_lines): Handle case where
3173         first_pos==npos.  Return std::string.
3174         (source_cache::get_source_lines): Update.
3175
3176 2019-03-14  Tom Tromey  <tromey@adacore.com>
3177
3178         * NEWS: Add item for "style sources" commands.
3179         * source-cache.c (source_cache::get_source_lines): Check
3180         source_styling.
3181         * cli/cli-style.c (source_styling): New global.
3182         (_initialize_cli_style): Add "style sources" commands.
3183         (show_style_sources): New function.
3184         * cli/cli-style.h (source_styling): Declare.
3185
3186 2019-03-14  Pedro Alves  <palves@redhat.com>
3187             Tom Tromey  <tromey@adacore.com>
3188
3189         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3190         * tui/tui-winsource.c (tui_refill_source_window): New function,
3191         from...
3192         (tui_horizontal_source_scroll): ... here.  Move some logic.
3193         * cli/cli-style.c (set_style_enabled): Notify new observable.
3194         * tui/tui-hooks.c (tui_redisplay_source): New function.
3195         (tui_attach_detach_observers): Attach or detach
3196         tui_redisplay_source.
3197         * observable.h (source_styling_changed): New observable.
3198         * observable.c: Define source_styling_changed observable.
3199
3200 2019-03-13  Tom Tromey  <tromey@adacore.com>
3201
3202         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3203         (i386_gnu_nat_target::store_registers): Update.
3204         * target-debug.h (target_debug_print_std_string): New macro.
3205         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3206         * windows-tdep.c (display_one_tib): Update.
3207         * tui/tui-stack.c (tui_make_status_line): Update.
3208         * top.c (print_inferior_quit_action): Update.
3209         * thread.c (thr_try_catch_cmd): Update.
3210         (add_thread_with_info): Update.
3211         (thread_target_id_str): Update.
3212         (thr_try_catch_cmd): Update.
3213         (thread_command): Update.
3214         (thread_find_command): Update.
3215         * record-btrace.c (record_btrace_target::info_record)
3216         (record_btrace_resume_thread, record_btrace_target::resume)
3217         (record_btrace_cancel_resume, record_btrace_step_thread)
3218         (record_btrace_target::wait, record_btrace_target::wait)
3219         (record_btrace_target::wait, record_btrace_target::stop): Update.
3220         * progspace.c (print_program_space): Update.
3221         * process-stratum-target.c
3222         (process_stratum_target::thread_address_space): Update.
3223         * linux-fork.c (linux_fork_mourn_inferior)
3224         (detach_checkpoint_command, info_checkpoints_command)
3225         (linux_fork_context): Update.
3226         (linux_fork_detach): Update.
3227         (class scoped_switch_fork_info): Update.
3228         (delete_checkpoint_command): Update.
3229         * infrun.c (follow_fork_inferior): Update.
3230         (follow_fork_inferior): Update.
3231         (proceed_after_vfork_done): Update.
3232         (handle_vfork_child_exec_or_exit): Update.
3233         (follow_exec): Update.
3234         (displaced_step_prepare_throw): Update.
3235         (displaced_step_restore): Update.
3236         (start_step_over): Update.
3237         (resume_1): Update.
3238         (clear_proceed_status_thread): Update.
3239         (proceed): Update.
3240         (print_target_wait_results): Update.
3241         (do_target_wait): Update.
3242         (context_switch): Update.
3243         (stop_all_threads): Update.
3244         (restart_threads): Update.
3245         (finish_step_over): Update.
3246         (handle_signal_stop): Update.
3247         (switch_back_to_stepped_thread): Update.
3248         (keep_going_pass_signal): Update.
3249         (print_exited_reason): Update.
3250         (normal_stop): Update.
3251         * inferior.c (inferior_pid_to_str): Change return type.
3252         (print_selected_inferior): Update.
3253         (add_inferior): Update.
3254         (detach_inferior): Update.
3255         * dummy-frame.c (fprint_dummy_frames): Update.
3256         * dcache.c (dcache_info_1): Update.
3257         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3258         (btrace_fetch, btrace_clear): Update.
3259         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3260         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3261         type.
3262         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3263         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3264         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3265         * gdbarch.c, gdbarch.h: Rebuild.
3266         * gdbarch.sh (core_pid_to_str): Change return type.
3267         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3268         return type.
3269         (windows_nat_target::pid_to_str): Change return type.
3270         (windows_delete_thread): Update.
3271         (windows_nat_target::attach): Update.
3272         (windows_nat_target::files_info): Update.
3273         * target-delegates.c: Rebuild.
3274         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3275         return type.
3276         (sol_thread_target::pid_to_str): Change return type.
3277         * remote.c (class remote_target) <pid_to_str>: Change return
3278         type.
3279         (remote_target::pid_to_str): Change return type.
3280         (extended_remote_target::attach, remote_target::remote_stop_ns)
3281         (remote_target::remote_notif_remove_queued_reply)
3282         (remote_target::push_stop_reply, remote_target::disable_btrace):
3283         Update.
3284         (extended_remote_target::attach): Update.
3285         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3286         type.
3287         (gdbsim_target::pid_to_str): Change return type.
3288         * ravenscar-thread.c (struct ravenscar_thread_target)
3289         <pid_to_str>: Change return type.
3290         (ravenscar_thread_target::pid_to_str): Change return type.
3291         * procfs.c (class procfs_target) <pid_to_str>: Change return
3292         type.
3293         (procfs_target::pid_to_str): Change return type.
3294         (procfs_target::attach): Update.
3295         (procfs_target::detach): Update.
3296         (procfs_target::fetch_registers): Update.
3297         (procfs_target::store_registers): Update.
3298         (procfs_target::wait): Update.
3299         (procfs_target::files_info): Update.
3300         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3301         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3302         return type.
3303         (nto_procfs_target::pid_to_str): Change return type.
3304         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3305         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3306         return type.
3307         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3308         (exit_lwp): Update.
3309         (attach_proc_task_lwp_callback, get_detach_signal)
3310         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3311         (linux_nat_target::resume, wait_lwp, stop_callback)
3312         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3313         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3314         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3315         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3316         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3317         type.
3318         (inf_ptrace_target::attach): Update.
3319         (inf_ptrace_target::files_info): Update.
3320         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3321         type.
3322         (go32_nat_target::pid_to_str): Change return type.
3323         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3324         (gnu_nat_target::wait): Update.
3325         (gnu_nat_target::wait): Update.
3326         (gnu_nat_target::resume): Update.
3327         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3328         (fbsd_nat_target::wait): Update.
3329         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3330         type.
3331         (darwin_nat_target::attach): Update.
3332         * corelow.c (class core_target) <pid_to_str>: Change return type.
3333         (core_target::pid_to_str): Change return type.
3334         * target.c (normal_pid_to_str): Change return type.
3335         (default_pid_to_str): Likewise.
3336         (target_pid_to_str): Change return type.
3337         (target_translate_tls_address): Update.
3338         (target_announce_detach): Update.
3339         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3340         return type.
3341         (bsd_uthread_target::pid_to_str): Change return type.
3342         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3343         type.
3344         (bsd_kvm_target::pid_to_str): Change return type.
3345         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3346         return type.
3347         (aix_thread_target::pid_to_str): Change return type.
3348         * target.h (struct target_ops) <pid_to_str>: Change return type.
3349         (target_pid_to_str, normal_pid_to_str): Likewise.
3350         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3351         type.
3352         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3353         type.
3354         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3355         return type.
3356         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3357         type.
3358         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3359         type.
3360         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3361         return type.
3362
3363 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3364
3365         * NEWS: Mention that the new default MI version is 3.  Mention
3366         changes to the output of commands and events that deal with
3367         multi-location breakpoints.
3368         * breakpoint.c: Include "mi/mi-out.h".
3369         (print_one_breakpoint): Change output syntax if using MI version
3370         >= 3.
3371         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3372         New.
3373         (mi_multi_location_breakpoint_output_fixed): New.
3374         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3375         (mi_cmd_fix_multi_location_breakpoint_output): New.
3376         (mi_multi_location_breakpoint_output_fixed): New.
3377         * mi/mi-cmds.c (mi_cmds): Register command
3378         -fix-multi-location-breakpoint-output.
3379         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3380         interpreter "mi".
3381
3382 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3383
3384         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3385         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3386         instantiate mi_ui_out based on interpreter name.
3387         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3388         * mi/mi-main.c (mi_load_progress): Likewise.
3389
3390 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3391
3392         * NEWS: Combine separate "New targets" sections for 8.3.
3393
3394 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3395
3396         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3397         (ppcfbsd_init_abi): Install gdbarch
3398         "fetch_tls_load_module_address" and "get_thread_local_address"
3399         methods.
3400
3401 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3402
3403         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3404         (riscv_fbsd_init_abi): Install gdbarch
3405         "fetch_tls_load_module_address" and "get_thread_local_address"
3406         methods.
3407
3408 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3409
3410         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3411         (i386fbsd_init_abi): Install gdbarch
3412         "fetch_tls_load_module_address" and "get_thread_local_address"
3413         methods.
3414
3415 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3416
3417         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3418         (amd64fbsd_init_abi): Install gdbarch
3419         "fetch_tls_load_module_address" and "get_thread_local_address"
3420         methods.
3421
3422 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3423
3424         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3425         (struct fbsd_pspace_data): New type.
3426         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3427         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3428         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3429         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3430         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3431
3432 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3433
3434         * gdbtypes.c (lookup_struct_elt): New function.
3435         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3436         * gdbtypes.h (struct struct_elt): New type.
3437         (lookup_struct_elt): New prototype.
3438
3439 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3440
3441         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3442         remove disabled code block.
3443
3444 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3445
3446         * gdbarch.sh (get_thread_local_address): New method.
3447         * gdbarch.h, gdbarch.c: Regenerate.
3448         * target.c (target_translate_tls_address): Use
3449         gdbarch_get_thread_local_address if present instead of
3450         target::get_thread_local_address.
3451
3452 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3453
3454         * target.h (target::get_thread_local_address): Update comment.
3455
3456 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3457
3458         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3459         objfile->separate_debug_objfile_backlink if not NULL.
3460
3461 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3462
3463         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3464         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3465         (amd64bsd_store_inferior_registers): Likewise.
3466         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3467         Enable segment base registers.
3468         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3469         PT_GETFSBASE and PT_GETGSBASE.
3470         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3471         PT_SETGSBASE.
3472         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3473         segment base registers.
3474         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3475
3476 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3477
3478         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3479         Update calls to i386_target_description to add 'segments'
3480         parameter.
3481         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3482         add segment base registers.
3483         * arch/i386.c (i386_create_target_description): Add 'segments'
3484         parameter to enable segment base registers.
3485         * arch/i386.h (i386_create_target_description): Likewise.
3486         * features/i386/32bit-segments.xml: New file.
3487         * features/i386/32bit-segments.c: Generate.
3488         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3489         call to i386_target_description to add 'segments' parameter.
3490         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3491         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3492         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3493         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3494         if feature is present.
3495         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3496         Add 'segments' parameter to call to i386_target_description.
3497         (i386_target_description): Add 'segments' parameter to enable
3498         segment base registers.
3499         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3500         to call to i386_target_description.
3501         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3502         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3503         Define I386_NUM_REGS.
3504         (i386_target_description): Add 'segments' parameter to enable
3505         segment base registers.
3506
3507 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3508
3509         PR/24325
3510         * source-cache.c: #undef open and close, to avoid unresolved
3511         externals during linking.
3512
3513 2019-03-12  Tom Tromey  <tromey@adacore.com>
3514
3515         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3516         const.  Add initializers.
3517         (_initialize_remote): Don't initialize ptid globals.
3518
3519 2019-03-12  Pedro Alves  <palves@redhat.com>
3520
3521         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3522
3523 2019-03-12  Pedro Alves  <palves@redhat.com>
3524
3525         * cp-name-parser.y (main): Remove unused 'len' variable.
3526
3527 2019-03-12  Tom Tromey  <tromey@adacore.com>
3528
3529         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3530         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3531
3532 2019-03-12  Tom Tromey  <tromey@adacore.com>
3533
3534         * linux-nat.c (iterate_over_lwps): Update.
3535         (stop_callback): Remove parameter.
3536         (stop_wait_callback, detach_callback, resume_set_callback)
3537         (select_singlestep_lwp_callback, set_ignore_sigint)
3538         (status_callback, resumed_callback, resume_clear_callback)
3539         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3540         data parameter.
3541         (linux_nat_target::detach, linux_nat_target::resume)
3542         (linux_stop_and_wait_all_lwps, select_event_lwp)
3543         (linux_nat_filter_event, linux_nat_wait_1)
3544         (linux_nat_target::kill, linux_nat_target::stop)
3545         (linux_nat_target::stop): Update.
3546         (linux_nat_resume_callback): Change type.
3547         (resume_stopped_resumed_lwps, count_events_callback)
3548         (select_event_lwp_callback): Likewise.
3549         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3550         * arm-linux-nat.c (struct update_registers_data): Remove.
3551         (update_registers_callback): Change type.
3552         (arm_linux_insert_hw_breakpoint1): Update.
3553         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3554         parameter.
3555         (x86_linux_dr_set_addr): Update.
3556         (x86_linux_dr_set_control): Update.
3557         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3558         (iterate_over_lwps): Use gdb::function_view.
3559         * nat/aarch64-linux-hw-point.c (struct
3560         aarch64_dr_update_callback_param): Remove.
3561         (debug_reg_change_callback): Change type.
3562         (aarch64_notify_debug_reg_change): Update.
3563         * s390-linux-nat.c (s390_refresh_per_info): Update.
3564
3565 2019-03-11  Tom Tromey  <tromey@adacore.com>
3566
3567         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3568         redundant assignment to "this_cu".
3569
3570 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3571
3572         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3573
3574 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3575
3576         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3577         from...
3578         (rank_one_type): ... this.
3579
3580 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3581
3582         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3583         from...
3584         (rank_one_type): ... this.
3585
3586 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3587
3588         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3589         from...
3590         (rank_one_type): ... this.
3591
3592 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3593
3594         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3595         from...
3596         (rank_one_type): ... this.
3597
3598 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3599
3600         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3601         from...
3602         (rank_one_type): ... this.
3603
3604 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3605
3606         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3607         from...
3608         (rank_one_type): ... this.
3609
3610 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3611
3612         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3613         from...
3614         (rank_one_type): ... this.
3615
3616 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3617
3618         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3619         from...
3620         (rank_one_type): ... this.
3621
3622 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3623
3624         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3625         from...
3626         (rank_one_type): ... this.
3627
3628 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3629
3630         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3631         from...
3632         (rank_one_type): ... this.
3633
3634 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3635
3636         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3637         from...
3638         (rank_one_type): ... this.
3639
3640 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3641
3642         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3643         from...
3644         (rank_one_type): ... this.
3645
3646 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3647
3648         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3649         inferior-events' shows the example events.
3650
3651 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3652
3653         Support styling on native MS-Windows console
3654
3655         PR/24315
3656         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3657         on MS-Windows if $TERM is not defined.
3658
3659         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3660
3661         * posix-hdep.c (gdb_console_fputs):
3662         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3663         functions.
3664         * ui-file.h (gdb_console_fputs): Add prototype.
3665
3666         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3667         back to fputs only if the former returns zero.
3668
3669 2019-03-07  Tom Tromey  <tom@tromey.com>
3670
3671         * symmisc.c (print_symbol_bcache_statistics): Update.
3672         (print_objfile_statistics): Update.
3673         * symfile.c (allocate_symtab): Update.
3674         * stabsread.c: Don't include bcache.h.
3675         * psymtab.h (struct psymbol_bcache): Don't declare.
3676         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3677         (psymbol_bcache_init, psymbol_bcache_free)
3678         (psymbol_bcache_get_bcache): Don't declare.
3679         * psymtab.c (struct psymbol_bcache): Remove.
3680         (psymtab_storage::psymtab_storage): Update.
3681         (psymtab_storage::~psymtab_storage): Update.
3682         (psymbol_bcache_init, psymbol_bcache_free)
3683         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3684         (add_psymbol_to_bcache): Update.
3685         (allocate_psymtab): Update.
3686         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3687         macro_cache>: No longer pointers.
3688         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3689         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3690         * macrotab.c (macro_bcache): Update.
3691         * macroexp.c: Don't include bcache.h.
3692         * gdbtypes.c (check_types_worklist): Update.
3693         (types_deeply_equal): Remove TRY/CATCH.  Update.
3694         * elfread.c (elf_symtab_read): Update.
3695         * dwarf2read.c: Don't include bcache.h.
3696         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3697         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3698         (print_bcache_statistics, bcache_memory_used): Don't declare.
3699         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3700         methods.  Rename all data members.
3701         * bcache.c (struct bcache): Move to bcache.h.
3702         (bcache::expand_hash_table): Rename from expand_hash_table.
3703         (bcache): Remove.
3704         (bcache::insert): Rename from bcache_full.
3705         (bcache::compare): Rename from bcache_compare.
3706         (bcache_xmalloc): Remove.
3707         (bcache::~bcache): Rename from bcache_xfree.
3708         (bcache::print_statistics): Rename from print_bcache_statistics.
3709         (bcache::memory_used): Rename from bcache_memory_used.
3710
3711 2019-03-07  Pedro Alves  <palves@redhat.com>
3712
3713         * infrun.c (normal_stop): Also check for
3714         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3715
3716 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3717
3718         * f-lang.c (value_from_host_double): Moved to...
3719         * value.c (value_from_host_double): ...here.
3720         * value.h (value_from_host_double): Declare.
3721         * guile/scm-math.c (vlscm_convert_typed_number): Use
3722         value_from_host_double.
3723         (vlscm_convert_number): Likewise.
3724         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3725         * python/py-value.c (convert_value_from_python): Likewise.
3726
3727 2019-03-06  Tom Tromey  <tom@tromey.com>
3728
3729         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3730
3731 2019-03-06  Tom Tromey  <tom@tromey.com>
3732
3733         * utils.h (free_current_contents): Don't declare.
3734         * utils.c (free_current_contents): Remove.
3735
3736 2019-03-06  Tom Tromey  <tom@tromey.com>
3737
3738         * top.c (quit_force): Update.
3739         * main.c (captured_command_loop): Update.
3740         * common/new-op.c (operator new): Update.
3741         * common/common-exceptions.c (struct catcher)
3742         <save_cleanup_chain>: Remove member.
3743         (exceptions_state_mc_init): Update.
3744         (exception_try_scope_entry): Return nullptr.
3745         (exception_try_scope_exit, exception_rethrow)
3746         (throw_exception_sjlj, throw_exception_cxx): Update.
3747         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3748         (all_cleanups, do_cleanups, discard_cleanups)
3749         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3750         (restore_cleanups, restore_final_cleanups): Don't declare.
3751         (do_final_cleanups): Remove parameter.
3752         * common/cleanups.c (cleanup_chain, make_cleanup)
3753         (make_cleanup_dtor, all_cleanups, do_cleanups)
3754         (discard_my_cleanups, discard_cleanups)
3755         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3756         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3757         (null_cleanup): Remove.
3758         (do_final_cleanups): Remove parameter.
3759
3760 2019-03-06  Tom Tromey  <tom@tromey.com>
3761
3762         * remote.c (remote_target::remote_parse_stop_reply): Use
3763         unique_xmalloc_ptr.
3764
3765 2019-03-06  Tom Tromey  <tom@tromey.com>
3766
3767         * stabsread.c (struct stabs_field_info): Rename from field_info.
3768         <list, fnlist>: Add initializers.
3769         <obstack>: New member.
3770         (read_member_functions, read_struct_fields, read_baseclasses):
3771         Allocate on obstack.  Don't use cleanups.
3772         (read_one_struct_field, read_member_functions, read_struct_fields)
3773         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3774         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3775         (read_struct_type): Update.
3776
3777 2019-03-06  Tom Tromey  <tom@tromey.com>
3778
3779         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3780         * common/filestuff.h (make_cleanup_close): Don't declare.
3781         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3782         Remove.
3783
3784 2019-03-06  Tom Tromey  <tom@tromey.com>
3785
3786         * solib-aix.c: Use make_scope_exit.
3787
3788 2019-03-06  Tom Tromey  <tom@tromey.com>
3789
3790         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3791         Use make_scope_exit.
3792
3793 2019-03-06  Tom Tromey  <tom@tromey.com>
3794
3795         * solib-svr4.c (disable_probes_interface): Remove parameter.
3796         (svr4_handle_solib_event): Use make_scope_exit.
3797
3798 2019-03-06  Tom Tromey  <tom@tromey.com>
3799
3800         * remote.c (struct stop_reply_deleter): Remove.
3801         (stop_reply_up): Update.
3802         (struct stop_reply): Derive from notif_event.  Don't typedef.
3803         <regcache>: Now a std::vector.
3804         (stop_reply_xfree): Remove.
3805         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3806         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3807         (remote_target::discard_pending_stop_replies): Use delete.
3808         (remote_target::remote_parse_stop_reply): Update.
3809         (remote_target::process_stop_reply): Update.
3810         * remote-notif.h (struct notif_event): Add virtual destructor.
3811         Remove "dtr" member.
3812         (struct notif_client) <alloc_event>: Return a unique_ptr.
3813         (notif_event_xfree): Don't declare.
3814         (notif_event_up): New typedef.
3815         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3816         (notif_event_xfree, do_notif_event_xfree): Remove.
3817         (remote_notif_state_xfree): Update.
3818
3819 2019-03-06  Tom Tromey  <tom@tromey.com>
3820
3821         * infrun.c (displaced_step_clear_cleanup): Now a
3822         forward_scope_exit type.
3823         (displaced_step_prepare_throw): Update.
3824         (displaced_step_fixup): Update.
3825
3826 2019-03-06  Tom Tromey  <tom@tromey.com>
3827
3828         * inferior.h (class inferior): Update comment.
3829         * gdbthread.h (class thread_info): Update comment.
3830
3831 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3832             Tom Tromey  <tom@tromey.com>
3833
3834         * stabsread.h (struct stab_section_list): Remove.
3835         (coffstab_build_psymtabs): Update.
3836         * dbxread.c (symbuf_sections): Now a std::vector.
3837         (sect_idx): New global.
3838         (fill_symbuf): Update.
3839         (coffstab_build_psymtabs): Change type of stabsects parameter.
3840         Update.
3841         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3842         std::vector.
3843         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3844         (coff_locate_sections): Update.
3845         (coff_symfile_read): Remove cleanups.  Update.
3846         (init_stringtab): Add storage parameter.
3847         (free_stringtab, free_stringtab_cleanup): Remove.
3848         (init_lineno): Add storage parameter.
3849         (free_linetab, free_linetab_cleanup): Remove.
3850
3851 2019-03-06  Pedro Alves  <palves@redhat.com>
3852
3853         * linux-fork.c (fork_info::clobber_regs): Delete.
3854         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3855         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3856         comment.  Adjust.
3857         (scoped_switch_fork_info::scoped_switch_fork_info)
3858         (checkpoint_command, linux_fork_context): Adjust
3859         fork_save_infrun_state calls.
3860
3861 2019-03-06  Pedro Alves  <palves@redhat.com>
3862
3863         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3864         (inf_has_multiple_threads): Return 'bool' and rewrite using
3865         inferior_info::threads().
3866
3867 2019-03-06  Pedro Alves  <palves@redhat.com>
3868
3869         * linux-fork.c: Include <list>.
3870         (fork_list): Now a std::list instance.
3871         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3872         (forks_exist_p, find_last_fork): Adjust.
3873         (new_fork): Delete.
3874         (one_fork_p): New.
3875         (add_fork): Adjust.
3876         (free_fork): Delete, folded into fork_info::~fork_info().
3877         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3878         Adjust.
3879         (init_fork_list): Delete.
3880         (linux_fork_killall, linux_fork_mourn_inferior)
3881         (linux_fork_detach, info_checkpoints_command): Adjust.
3882         (_initialize_linux_fork): No longer call init_fork_list.
3883
3884 2019-03-06  Pedro Alves  <palves@redhat.com>
3885
3886         * linux-fork.c (new_fork): New, split out of ...
3887         (add_fork): ... this.  Return void.  Move "first fork" special
3888         case from here, to ...
3889         (checkpoint_command): ... here.
3890         * linux-linux.h (add_fork): Return void.
3891
3892 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3893
3894         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3895
3896 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3897             Chris January  <chris.january@arm.com>
3898             David Lecomber  <david.lecomber@arm.com>
3899
3900         * f-exp.y: New token, UNOP_INTRINSIC.
3901         (exp): New pattern using UNOP_INTRINSIC token.
3902         (f77_keywords): Add 'abs' keyword.
3903         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3904         (value_from_host_double): New function.
3905         (evaluate_subexp_f): Support UNOP_ABS.
3906
3907 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3908
3909         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3910         types.
3911
3912 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3913
3914         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3915         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3916         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3917
3918 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3919
3920         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3921
3922 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3923             Chris January  <chris.january@arm.com>
3924
3925         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3926         * f-exp.y: Define 'KIND' token.
3927         (exp): New pattern for KIND expressions.
3928         (ptype): Handle types with a kind extension.
3929         (direct_abs_decl): Extend to spot kind extensions.
3930         (f77_keywords): Add 'kind' to the list.
3931         (push_kind_type): New function.
3932         (convert_to_kind_type): New function.
3933         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3934         * parse.c (operator_length_standard): Likewise.
3935         * parser-defs.h (enum type_pieces): Add tp_kind.
3936         * std-operator.def: Add UNOP_KIND.
3937
3938 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3939
3940         * f-exp.y (f_parse): Set yydebug.
3941
3942 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3943
3944         * f-lang.c (evaluate_subexp_f): New function.
3945         (exp_descriptor_f): New global.
3946         (f_language_defn): Use exp_descriptor_f instead of
3947         exp_descriptor_standard.
3948
3949 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3950
3951         * f-exp.y (struct token): Add comments.
3952         (dot_ops): Remove uppercase versions and the end marker.
3953         (f77_keywords): Likewise.
3954         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3955         entries in the dot_ops array are case insensitive, and use
3956         strncasecmp to compare strings.  Also some whitespace cleanup in
3957         this area.  Similar for the f77_keywords array, except entries in
3958         this list might be case sensitive.
3959
3960 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3961
3962         * f-exp.y (struct f77_boolean_val): Add comments.
3963         (boolean_values): Remove uppercase versions, and end marker.
3964         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3965         and use strncasecmp to achieve case insensitivity.  Additionally,
3966         perform whitespace cleanup around this code.
3967
3968 2019-03-06  Tom Tromey  <tromey@adacore.com>
3969
3970         * remote-sim.c (gdbsim_target_open): Use result of
3971         gdb_argv::release.
3972
3973 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3974         Dirk Schubert  <dirk.schubert@arm.com>
3975         Chris January  <chris.january@arm.com>
3976
3977         * eval.c (evaluate_subexp_standard): Call Fortran argument
3978         wrapping logic.
3979         * f-lang.c (struct value): A value which can be passed into a
3980         Fortran function call.
3981         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3982         where appropriate.
3983         (struct type): Value ready for a Fortran function call.
3984         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3985         is needed.
3986         * f-lang.h (fortran_argument_convert): Declaration.
3987         (fortran_preserve_arg_pointer): Declaration.
3988         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3989
3990 2019-03-05  Tom Tromey  <tromey@adacore.com>
3991
3992         * python/py-prettyprint.c (print_string_repr): Remove #if.
3993         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3994
3995 2019-03-05  Tom Tromey  <tromey@adacore.com>
3996
3997         * target.c (the_dummy_target): Move later.  Change type to
3998         "dummy_target".
3999         (initialize_targets): Don't initialize the_dummy_target.
4000
4001 2019-03-05  Tom Tromey  <tromey@adacore.com>
4002
4003         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4004         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4005
4006 2019-03-05  Tom Tromey  <tromey@adacore.com>
4007
4008         * windows-nat.c (windows_nat_target::attach)
4009         (windows_nat_target::detach): Don't call gdb_flush.
4010         * valprint.c (generic_val_print, val_print, val_print_string):
4011         Don't call gdb_flush.
4012         * utils.c (defaulted_query): Don't call gdb_flush.
4013         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4014         * target.c (target_announce_detach): Don't call gdb_flush.
4015         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4016         * remote.c (extended_remote_target::attach): Don't call
4017         gdb_flush.
4018         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4019         * printcmd.c (do_examine): Don't call gdb_flush.
4020         (info_display_command): Don't call gdb_flush.
4021         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4022         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4023         * memattr.c (info_mem_command): Don't call gdb_flush.
4024         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4025         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4026         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4027         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4028         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4029         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4030         (gnu_nat_target::detach): Don't call gdb_flush.
4031         * f-valprint.c (f_val_print): Don't call gdb_flush.
4032         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4033         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4034         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4035         gdb_flush.
4036         * c-valprint.c (c_val_print): Don't call gdb_flush.
4037         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4038
4039 2019-03-05  Tom Tromey  <tromey@adacore.com>
4040
4041         * varobj.c (update_dynamic_varobj_children): Update.
4042         (install_default_visualizer): Use reset, not release.
4043         * value.c (set_internalvar): Update.
4044         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4045         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4046         ATTRIBUTE_UNUSED_RESULT.
4047
4048 2019-03-05  Tom Tromey  <tromey@adacore.com>
4049
4050         * remote.c (class scoped_remote_fd) <release>: Add
4051         ATTRIBUTE_UNUSED_RESULT.
4052
4053 2019-03-05  Tom Tromey  <tromey@adacore.com>
4054
4055         * macroexp.c (struct macro_buffer) <release>: Add
4056         ATTRIBUTE_UNUSED_RESULT.
4057
4058 2019-03-05  Tom Tromey  <tromey@adacore.com>
4059
4060         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4061         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4062         ATTRIBUTE_UNUSED_RESULT.
4063
4064 2019-03-05  Tom Tromey  <tromey@adacore.com>
4065
4066         * common/scoped_fd.h (class scoped_fd) <release>: Add
4067         ATTRIBUTE_UNUSED_RESULT.
4068
4069 2019-03-05  Tom Tromey  <tromey@adacore.com>
4070
4071         * parser-defs.h (struct parser_state) <release>: Add
4072         ATTRIBUTE_UNUSED_RESULT.
4073
4074 2019-03-05  Tom Tromey  <tromey@adacore.com>
4075
4076         * utils.h (class gdb_argv) <release>: Add
4077         ATTRIBUTE_UNUSED_RESULT.
4078         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4079
4080 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4081
4082         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4083         for-loop range, to avoid compiler warnings.
4084
4085         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4086         avoid compiler warnings about unused variables.
4087
4088         * NEWS: Mention end of support for native debugging on MS-Windows
4089         before XP.
4090
4091         PR gdb/24292
4092         * common/netstuff.c:
4093         * gdbserver/gdbreplay.c
4094         * gdbserver/remote-utils.c:
4095         * ser-tcp.c:
4096         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4097         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4098         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4099         'getaddrinfo' and 'freeaddrinfo' were not available before
4100         Windows XP, and mingw.org's MinGW headers by default define
4101         _WIN32_WINNT to 0x500.
4102
4103 2019-03-01  Gary Benson <gbenson@redhat.com>
4104
4105         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4106
4107 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4108             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4109
4110         PR gdb/8527
4111         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4112         set_sigint_trap, clear_sigint_trap.
4113
4114 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4115
4116         * target.c (target_detach): Clear the regcache and the
4117         frame cache.
4118
4119 2019-02-27  Pedro Alves  <palves@redhat.com>
4120
4121         * utils.c (set_screen_size): When we cap the height/width sizes,
4122         tweak the corresponding command variable to show "unlimited":
4123
4124 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4125             Pedro Alves  <palves@redhat.com>
4126
4127         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4128         before calling rl_set_screen_size.
4129
4130 2019-02-27  Tom Tromey  <tromey@adacore.com>
4131
4132         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4133         define.
4134         * python/py-value.c: Remove Python 2.4 workaround.
4135         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4136         workaround.
4137         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4138         Python 2.4 workaround.
4139         * python/python-internal.h: Remove Python 2.4 comment.
4140         (Py_ssize_t): Don't define.
4141         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4142         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4143         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4144         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4145         * python/python.c (do_start_initialization): Remove Python 2.4
4146         workaround.
4147         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4148         (print_children): Remove Python 2.4 workaround.
4149         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4150         workaround.
4151         (CHARBUFFERPROC_NAME): Remove.
4152         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4153         Python 2.4 workaround.
4154
4155 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4156
4157         * NEWS: Note minimum Python version.
4158
4159 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4160
4161         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4162         code from these functions.  Remove corresponding ifdefs.  Use
4163         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4164         Remove gotos and target of gotos.
4165         (infpy_search_memory): Likewise.
4166
4167 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4168
4169         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4170         (hppa_gdbarch_init): Don't register deleted functions with
4171         gdbarch.
4172
4173 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4174
4175         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4176         (h8300_unwind_sp): Delete.
4177         (h8300_dummy_id): Delete.
4178         (h8300_gdbarch_init): Don't register deleted functions with
4179         gdbarch.
4180
4181 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4182
4183         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4184         (ft32_unwind_pc): Delete.
4185         (ft32_unwind_sp): Delete.
4186         (ft32_gdbarch_init): Don't register deleted functions with
4187         gdbarch.
4188
4189 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4190
4191         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4192         (frv_unwind_pc): Delete.
4193         (frv_unwind_sp): Delete.
4194         (frv_gdbarch_init): Don't register deleted functions with
4195         gdbarch.
4196
4197 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4198
4199         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4200         (riscv_unwind_pc): Delete.
4201         (riscv_unwind_sp): Delete.
4202         (riscv_gdbarch_init): Don't register deleted functions with
4203         gdbarch.
4204
4205 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4206
4207         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4208         (csky_unwind_pc): Delete.
4209         (csky_unwind_sp): Delete.
4210         (csky_gdbarch_init): Don't register deleted functions with
4211         gdbarch.
4212
4213 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4214
4215         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4216         (cris_unwind_pc): Delete.
4217         (cris_unwind_sp): Delete.
4218         (cris_gdbarch_init): Don't register deleted functions with
4219         gdbarch.
4220
4221 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4222
4223         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4224         (bfin_unwind_pc): Delete.
4225         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4226
4227 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4228
4229         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4230         (arm_unwind_pc): Delete.
4231         (arm_unwind_sp): Delete.
4232         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4233
4234 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4235
4236         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4237         (arc_unwind_pc): Delete.
4238         (arc_unwind_sp): Delete.
4239         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4240
4241 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4242
4243         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4244         (alpha_unwind_pc): Delete.
4245         (alpha_gdbarch_init): Don't register deleted functions with
4246         gdbarch.
4247
4248 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4249
4250         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4251         (aarch64_unwind_pc): Delete.
4252         (aarch64_unwind_sp): Delete.
4253         (aarch64_gdbarch_init): Don't register deleted functions with
4254         gdbarch.
4255
4256 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4257
4258         * gdbtypes.c (type_align): Don't consider static members when
4259         computing structure alignment.
4260
4261 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4262
4263         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4264         return 0 for other types.
4265         * arch-utils.c (default_type_align): Always return 0.
4266         * gdbarch.h: Regenerate.
4267         * gdbarch.sh (type_align): Extend comment.
4268         * gdbtypes.c (type_align): Add additional comments, always call
4269         gdbarch_type_align before applying the default rules.
4270         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4271         generic code will then apply a suitable default.
4272         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4273         types, return 0 for other types.
4274
4275 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4276
4277         * NEWS: Create a new section for the next release branch.
4278         Rename the section of the current branch, now that it has
4279         been cut.
4280
4281 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4282
4283         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4284         * version.in: Bump version to 8.3.50.DATE-git.
4285
4286 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4287
4288         * aix-thread.c (ptid_cmp): Remove unused variable.
4289         (get_signaled_thread): Likewise.
4290         (store_regs_user_thread): Likewise.
4291         (store_regs_kernel_thread): Likewise.
4292         (fetch_regs_kernel_thread): Remove shadowed variable.
4293
4294 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4295
4296         * features/riscv/32bit-cpu.xml: Add register numbers.
4297         * features/riscv/32bit-fpu.c: Regenerate.
4298         * features/riscv/32bit-fpu.xml: Add register numbers.
4299         * features/riscv/64bit-cpu.xml: Add register numbers.
4300         * features/riscv/64bit-fpu.c: Regenerate.
4301         * features/riscv/64bit-fpu.xml: Add register numbers.
4302
4303 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4304
4305         * NEWS: Mention two argument form of gdb.Value constructor.
4306         * python/py-value.c (convert_buffer_and_type_to_value): New
4307         function.
4308         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4309         Add support for handling an optional second argument.  Call
4310         convert_buffer_and_type_to_value as appropriate.
4311         * python/python-internal.h (Py_buffer_deleter): New struct.
4312         (Py_buffer_up): New typedef.
4313
4314 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4315
4316         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4317         instead of releasing ownership.
4318
4319 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4320
4321         * dwarf2read.c (open_and_init_dwp_file): Call
4322         elf_numsections instead of bfd_count_sections to initialize
4323         dwp_file->num_sections.
4324
4325 2019-02-25  Tom Tromey  <tromey@adacore.com>
4326
4327         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4328
4329 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4330
4331         * gcore.in: Add '--readnever' option when invoking GDB.
4332
4333 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4334
4335         * MAINTAINERS: Update my email address.
4336
4337 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4338
4339         * build-id.c (build_id_to_debug_bfd_1): New function.
4340         (build_id_to_debug_bfd): Look for separate debug file in
4341         sysroot.
4342
4343 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4344
4345         * gdbarch.sh: Update the copyright year range that is placed into
4346         generated files.
4347
4348 2019-02-22  Keith Seitz  <keiths@redhat.com>
4349
4350         PR symtab/23853
4351         * linespec.c (create_sals_line_offset): Search for the default
4352         symtab's filename instead of its fullname.
4353
4354 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4355
4356         * NEWS: Update style defaults.
4357
4358 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4359
4360         * main.c (captured_main_1): Disable styling in batch mode.
4361
4362 2019-02-20  Tom Tromey  <tom@tromey.com>
4363
4364         * symtab.c (symtab_symbol_info): Fix typos.
4365
4366 2019-02-20  Tom Tromey  <tromey@adacore.com>
4367
4368         * findcmd.c (_initialize_mem_search): Use upper case for
4369         metasyntactic variables.
4370
4371 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4372
4373         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4374         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4375
4376 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4377
4378         * top.h (source_file_name): Change to std::string.
4379         * top.c (source_file_name): Likewise.
4380         (command_line_input): Adjust.
4381         * cli/cli-script.c (script_from_file): Adjust.
4382
4383 2019-02-19  Tom Tromey  <tromey@adacore.com>
4384
4385         * ravenscar-thread.c
4386         (ravenscar_thread_target::update_thread_list): Don't call
4387         ada_build_task_list.
4388         * ada-lang.h (ada_build_task_list): Don't declare.
4389         * ada-tasks.c (struct ada_tasks_inferior_data)
4390         <task_list_valid_p>: Now bool.
4391         (read_known_tasks, ada_task_list_changed)
4392         (ada_tasks_invalidate_inferior_data): Update.
4393         (read_known_tasks_array): Return bool.
4394         (read_known_tasks_list): Likewise.
4395         (read_known_tasks): Return void.
4396         (ada_build_task_list): Now static.
4397
4398 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4399
4400         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4401         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4402
4403 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4404
4405         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4406         variant for ada_tasks_pspace_data_handle and
4407         ada_tasks_inferior_data_handle.
4408         (ada_tasks_pspace_data_cleanup): New function.
4409         (ada_tasks_inferior_data_cleanup): New function.
4410
4411 2019-02-17  Tom Tromey  <tom@tromey.com>
4412
4413         * macrotab.h (macro_source_fullname): Return a std::string.
4414         * macrotab.c (macro_include, check_for_redefinition)
4415         (macro_undef, macro_lookup_definition, foreach_macro)
4416         (foreach_macro_in_scope): Update.
4417         (macro_source_fullname): Return a std::string.
4418         * macrocmd.c (show_pp_source_pos): Update.
4419
4420 2019-02-17  Tom Tromey  <tom@tromey.com>
4421
4422         * macrocmd.c (show_pp_source_pos): Style the file names.
4423
4424 2019-02-17  Tom Tromey  <tom@tromey.com>
4425
4426         PR tui/24197:
4427         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4428
4429 2019-02-17  Tom Tromey  <tom@tromey.com>
4430
4431         * ada-lang.c (user_select_syms): Use filtered printing.
4432         * utils.c (wrap_style): New global.
4433         (desired_style): Remove.
4434         (emit_style_escape): Add stream parameter.
4435         (set_output_style, reset_terminal_style, prompt_for_continue):
4436         Update.
4437         (flush_wrap_buffer): Only flush gdb_stdout.
4438         (wrap_here): Set wrap_style.
4439         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4440         treat escape sequences as a character.  Change when wrap buffer is
4441         flushed.
4442         (fputs_styled): Do not set the output style when the default is
4443         requested.
4444         * ui-style.h (struct ui_file_style) <is_default>: New method.
4445         * source.c (print_source_lines_base): Emit escape sequences in one
4446         piece.
4447
4448 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4449
4450         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4451         integers and enumeration types.
4452
4453 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4454
4455         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4456         instead of lookup_symbol_in_language
4457         (do_exact_match): New function.
4458         (ada_get_symbol_name_matcher): Return do_exact_match when
4459         doing a verbatim match.
4460
4461 2019-02-15  Tom Tromey  <tromey@adacore.com>
4462
4463         * ravenscar-thread.c (ravenscar_thread_target::resume)
4464         (ravenscar_thread_target::wait): Special case wildcard requests.
4465
4466 2019-02-15  Tom Tromey  <tromey@adacore.com>
4467
4468         * ravenscar-thread.c (base_ptid): Remove.
4469         (struct ravenscar_thread_target) <close>: New method.
4470         <m_base_ptid>: New member.
4471         <update_inferior_ptid, active_task, task_is_currently_active,
4472         runtime_initialized>: Declare methods.
4473         <ravenscar_thread_target>: Add constructor.
4474         (ravenscar_thread_target::task_is_currently_active)
4475         (ravenscar_thread_target::update_inferior_ptid)
4476         (ravenscar_runtime_initialized): Rename.  Now methods.
4477         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4478         (ravenscar_thread_target::update_thread_list): Update.
4479         (ravenscar_thread_target::active_task): Now method.
4480         (ravenscar_thread_target::store_registers)
4481         (ravenscar_thread_target::prepare_to_store)
4482         (ravenscar_thread_target::prepare_to_store)
4483         (ravenscar_thread_target::mourn_inferior): Update.
4484         (ravenscar_inferior_created): Use "new" to create target.
4485         (ravenscar_thread_target::get_ada_task_ptid): Update.
4486         (_initialize_ravenscar): Don't initialize base_ptid.
4487         (ravenscar_ops): Remove global.
4488
4489 2019-02-15  Tom Tromey  <tromey@adacore.com>
4490
4491         * target.h (push_target): Declare new overload.
4492         * target.c (push_target): New overload, taking an rvalue reference.
4493         * remote.c (remote_target::open_1): Use push_target overload.
4494         * corelow.c (core_target_open): Use push_target overload.
4495
4496 2019-02-15  Tom Tromey  <tromey@adacore.com>
4497
4498         * ravenscar-thread.c (is_ravenscar_task)
4499         (ravenscar_task_is_currently_active): Return bool.
4500         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4501         (_initialize_ravenscar): Remove "(void)".
4502         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4503         Return bool.
4504
4505 2019-02-15  Tom Tromey  <tromey@adacore.com>
4506
4507         * ravenscar-thread.c (ravenscar_runtime_initializer)
4508         (has_ravenscar_runtime, get_running_thread_id)
4509         (ravenscar_thread_target::resume): Fix indentation.
4510
4511 2019-02-15  Tom Tromey  <tromey@adacore.com>
4512
4513         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4514         from ravenscar_arch_ops.
4515         (sparc_ravenscar_ops::fetch_registers)
4516         (sparc_ravenscar_ops::store_registers): Now methods.
4517         (sparc_ravenscar_prepare_to_store): Remove.
4518         (sparc_ravenscar_ops): Redefine.
4519         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4520         methods and destructor.  Remove members.
4521         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4522         (ravenscar_thread_target::store_registers)
4523         (ravenscar_thread_target::prepare_to_store): Update.
4524         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4525         Remove.
4526         (struct ppc_ravenscar_powerpc_ops): Derive from
4527         ravenscar_arch_ops.
4528         (ppc_ravenscar_powerpc_ops::fetch_registers)
4529         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4530         (ppc_ravenscar_powerpc_ops): Redefine.
4531         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4532         (ppc_ravenscar_e500_ops::fetch_registers)
4533         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4534         (ppc_ravenscar_e500_ops): Redefine.
4535         * aarch64-ravenscar-thread.c
4536         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4537         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4538         (aarch64_ravenscar_fetch_registers)
4539         (aarch64_ravenscar_store_registers): Now methods.
4540         (aarch64_ravenscar_ops): Redefine.
4541
4542 2019-02-15  Tom Tromey  <tromey@adacore.com>
4543
4544         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4545         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4546         (ravenscar_thread_target::stopped_by_watchpoint)
4547         (ravenscar_thread_target::stopped_data_address)
4548         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4549
4550 2019-02-15  Tom Tromey  <tromey@adacore.com>
4551
4552         * ravenscar-thread.c: Fix some typos.
4553
4554 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4555             Tom Tromey  <tromey@adacore.com>
4556
4557         * ada-lang.c (ada_exception_sal): Change addr_string to a
4558         std::string.
4559         (create_ada_exception_catchpoint): Update.
4560
4561 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4562             Tom Tromey  <tromey@adacore.com>
4563
4564         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4565         (bp_location_ops): Remove.
4566         (base_breakpoint_allocate_location): Update.
4567         (free_bp_location): Update.
4568         * ada-lang.c (class ada_catchpoint_location)
4569         <ada_catchpoint_location>: Remove ops parameter.
4570         (ada_catchpoint_location_dtor): Remove.
4571         (ada_catchpoint_location_ops): Remove.
4572         (allocate_location_exception): Update.
4573         * breakpoint.h (struct bp_location_ops): Remove.
4574         (class bp_location) <bp_location>: Remove bp_location_ops
4575         parameter.
4576         <~bp_location>: Add destructor.
4577         <ops>: Remove.
4578
4579 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4580             Pedro Alves  <palves@redhat.com>
4581
4582         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4583         'PATH_MAX'.
4584
4585 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4586             Samuel Thibault  <samuel.thibault@gnu.org>
4587             Thomas Schwinge  <thomas@codesourcery.com>
4588
4589         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4590         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4591
4592 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4593
4594         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4595         (check_empty): Use "const char *".
4596
4597         * gnu-nat.c (gnu_nat_target::detach): Instead of
4598         'detach_inferior (pid)' call
4599         'detach_inferior (find_inferior_pid (pid))'.
4600
4601         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4602         'nat/fork-inferior.o'.
4603         * gnu-nat.c: #include "nat/fork-inferior.h".
4604
4605         * gnu-nat.c (gnu_nat_target::detach): Instead of
4606         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4607         * gnu-nat.h: #include "inf-child.h".
4608         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4609         'i386_gnu_nat_target::fetch_registers'.
4610         (gnu_store_registers): Rename/move to
4611         'i386_gnu_nat_target::store_registers'.
4612
4613         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4614         * gnu-nat.h (mach_thread_info): New function.
4615         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4616
4617         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4618
4619 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4620
4621         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4622
4623 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4624
4625         * windows-nat.c (windows_add_thread): Add new parameter
4626         "main_thread_p" with default value set to false.  Update
4627         function documentation as well as all callers.
4628         (windows_delete_thread): Likewise.
4629         (fake_create_process): Update call to windows_add_thread.
4630         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4631         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4632         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4633         call to windows_delete_thread.
4634
4635 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4636
4637         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4638
4639 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4640
4641         * symfile.c (find_separate_debug_file): Use canonical path of
4642         sysroot with child_path instead of gdb_sysroot if it is valid.
4643
4644 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4645
4646         * symfile.c (find_separate_debug_file): Use child_path to
4647         determine if an object file is under a sysroot.
4648
4649 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4650
4651         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4652         unittests/child-path-selftests.c.
4653         * common/pathstuff.c (child_path): New function.
4654         * common/pathstuff.h (child_path): New prototype.
4655         * unittests/child-path-selftests.c: New file.
4656
4657 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4658
4659         * symfile.c (find_separate_debug_file): Look for separate debug
4660         files in debug directories under the sysroot.
4661
4662 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4663
4664         * symtab.h (struct minimal_symbol data_p): New const method.
4665         (struct minimal_symbol text_p): Likewise.
4666         * symtab.c (output_source_filename): Use file name style
4667         to print file name.
4668         (print_symbol_info): Likewise.
4669         (print_msymbol_info): Use address style to print addresses.
4670         Use function name style to print executable text symbols.
4671         (expand_symtab_containing_pc): Use data_p.
4672         (find_pc_sect_compunit_symtab): Likewise.
4673
4674 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4675
4676         * breakpoint.c (describe_other_breakpoints): Use address style
4677         to print addresses.
4678         (say_where): Likewise.
4679
4680 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4681
4682         * ada-typeprint.c (print_func_type): Print function name
4683         style to print function name.
4684         * c-typeprint.c (c_print_type_1): Likewise.
4685
4686 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4687
4688         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4689         for execve.
4690
4691 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4692
4693         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4694         type_stack.
4695
4696 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4697
4698         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4699         TYPE_CODE_REF types.
4700
4701 2019-02-08  Jim Wilson  <jimw@sifive.com>
4702
4703         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4704         (riscv_linux_fregset): New.
4705         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4706
4707 2019-02-07  Tom Tromey  <tom@tromey.com>
4708
4709         * thread.c (thread_cancel_execution_command): Update.
4710         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4711         methods.
4712         (struct thread_fsm_ops): Remove.
4713         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4714         (thread_fsm_should_stop, thread_fsm_return_value)
4715         (thread_fsm_set_finished, thread_fsm_finished_p)
4716         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4717         Don't declare.
4718         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4719         * infrun.c (clear_proceed_status_thread)
4720         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4721         (print_stop_event): Update.
4722         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4723         Add constructor.
4724         (step_command_fsm_ops): Remove.
4725         (new_step_command_fsm): Remove.
4726         (step_1): Update.
4727         (step_command_fsm::should_stop): Rename from
4728         step_command_fsm_should_stop.
4729         (step_command_fsm::clean_up): Rename from
4730         step_command_fsm_clean_up.
4731         (step_command_fsm::do_async_reply_reason): Rename from
4732         step_command_fsm_async_reply_reason.
4733         (struct until_next_fsm): Inherit from thread_fsm.  Add
4734         constructor.
4735         (until_next_fsm_ops): Remove.
4736         (new_until_next_fsm): Remove.
4737         (until_next_fsm::should_stop): Rename from
4738         until_next_fsm_should_stop.
4739         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4740         (until_next_fsm::do_async_reply_reason): Rename from
4741         until_next_fsm_async_reply_reason.
4742         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4743         constructor.  Change type of breakpoint.
4744         (finish_command_fsm_ops): Remove.
4745         (new_finish_command_fsm): Remove.
4746         (finish_command_fsm::should_stop): Rename from
4747         finish_command_fsm_should_stop.
4748         (finish_command_fsm::clean_up): Rename from
4749         finish_command_fsm_clean_up.
4750         (finish_command_fsm::return_value): Rename from
4751         finish_command_fsm_return_value.
4752         (finish_command_fsm::do_async_reply_reason): Rename from
4753         finish_command_fsm_async_reply_reason.
4754         (finish_command): Update.
4755         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4756         Add constructor.
4757         (call_thread_fsm_ops): Remove.
4758         (call_thread_fsm::call_thread_fsm): Rename from
4759         new_call_thread_fsm.
4760         (call_thread_fsm::should_stop): Rename from
4761         call_thread_fsm_should_stop.
4762         (call_thread_fsm::should_notify_stop): Rename from
4763         call_thread_fsm_should_notify_stop.
4764         (run_inferior_call, call_function_by_hand_dummy): Update.
4765         * cli/cli-interp.c (should_print_stop_to_console): Update.
4766         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4767         Add constructor.  Change type of location_breakpoint,
4768         caller_breakpoint.
4769         (until_break_fsm_ops): Remove.
4770         (new_until_break_fsm): Remove.
4771         (until_break_fsm::should_stop): Rename from
4772         until_break_fsm_should_stop.
4773         (until_break_fsm::clean_up): Rename from
4774         until_break_fsm_clean_up.
4775         (until_break_fsm::do_async_reply_reason): Rename from
4776         until_break_fsm_async_reply_reason.
4777         (until_break_command): Update.
4778         * thread-fsm.c: Remove.
4779         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4780
4781 2019-02-07  Tom Tromey  <tom@tromey.com>
4782
4783         * yy-remap.h: Add include guard.
4784         * xtensa-tdep.h: Add include guard.
4785         * xcoffread.h: Rename include guard.
4786         * varobj-iter.h: Add include guard.
4787         * tui/tui.h: Rename include guard.
4788         * tui/tui-winsource.h: Rename include guard.
4789         * tui/tui-wingeneral.h: Rename include guard.
4790         * tui/tui-windata.h: Rename include guard.
4791         * tui/tui-win.h: Rename include guard.
4792         * tui/tui-stack.h: Rename include guard.
4793         * tui/tui-source.h: Rename include guard.
4794         * tui/tui-regs.h: Rename include guard.
4795         * tui/tui-out.h: Rename include guard.
4796         * tui/tui-layout.h: Rename include guard.
4797         * tui/tui-io.h: Rename include guard.
4798         * tui/tui-hooks.h: Rename include guard.
4799         * tui/tui-file.h: Rename include guard.
4800         * tui/tui-disasm.h: Rename include guard.
4801         * tui/tui-data.h: Rename include guard.
4802         * tui/tui-command.h: Rename include guard.
4803         * tic6x-tdep.h: Add include guard.
4804         * target/waitstatus.h: Rename include guard.
4805         * target/wait.h: Rename include guard.
4806         * target/target.h: Rename include guard.
4807         * target/resume.h: Rename include guard.
4808         * target-float.h: Rename include guard.
4809         * stabsread.h: Add include guard.
4810         * rs6000-tdep.h: Add include guard.
4811         * riscv-fbsd-tdep.h: Add include guard.
4812         * regformats/regdef.h: Rename include guard.
4813         * record.h: Rename include guard.
4814         * python/python.h: Rename include guard.
4815         * python/python-internal.h: Rename include guard.
4816         * python/py-stopevent.h: Rename include guard.
4817         * python/py-ref.h: Rename include guard.
4818         * python/py-record.h: Rename include guard.
4819         * python/py-record-full.h: Rename include guard.
4820         * python/py-record-btrace.h: Rename include guard.
4821         * python/py-instruction.h: Rename include guard.
4822         * python/py-events.h: Rename include guard.
4823         * python/py-event.h: Rename include guard.
4824         * procfs.h: Add include guard.
4825         * proc-utils.h: Add include guard.
4826         * p-lang.h: Add include guard.
4827         * or1k-tdep.h: Rename include guard.
4828         * observable.h: Rename include guard.
4829         * nto-tdep.h: Rename include guard.
4830         * nat/x86-linux.h: Rename include guard.
4831         * nat/x86-linux-dregs.h: Rename include guard.
4832         * nat/x86-gcc-cpuid.h: Add include guard.
4833         * nat/x86-dregs.h: Rename include guard.
4834         * nat/x86-cpuid.h: Rename include guard.
4835         * nat/ppc-linux.h: Rename include guard.
4836         * nat/mips-linux-watch.h: Rename include guard.
4837         * nat/linux-waitpid.h: Rename include guard.
4838         * nat/linux-ptrace.h: Rename include guard.
4839         * nat/linux-procfs.h: Rename include guard.
4840         * nat/linux-osdata.h: Rename include guard.
4841         * nat/linux-nat.h: Rename include guard.
4842         * nat/linux-namespaces.h: Rename include guard.
4843         * nat/linux-btrace.h: Rename include guard.
4844         * nat/glibc_thread_db.h: Rename include guard.
4845         * nat/gdb_thread_db.h: Rename include guard.
4846         * nat/gdb_ptrace.h: Rename include guard.
4847         * nat/fork-inferior.h: Rename include guard.
4848         * nat/amd64-linux-siginfo.h: Rename include guard.
4849         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4850         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4851         * nat/aarch64-linux.h: Rename include guard.
4852         * nat/aarch64-linux-hw-point.h: Rename include guard.
4853         * mn10300-tdep.h: Add include guard.
4854         * mips-linux-tdep.h: Add include guard.
4855         * mi/mi-parse.h: Rename include guard.
4856         * mi/mi-out.h: Rename include guard.
4857         * mi/mi-main.h: Rename include guard.
4858         * mi/mi-interp.h: Rename include guard.
4859         * mi/mi-getopt.h: Rename include guard.
4860         * mi/mi-console.h: Rename include guard.
4861         * mi/mi-common.h: Rename include guard.
4862         * mi/mi-cmds.h: Rename include guard.
4863         * mi/mi-cmd-break.h: Rename include guard.
4864         * m2-lang.h: Add include guard.
4865         * location.h: Rename include guard.
4866         * linux-record.h: Rename include guard.
4867         * linux-nat.h: Add include guard.
4868         * linux-fork.h: Add include guard.
4869         * i386-darwin-tdep.h: Rename include guard.
4870         * hppa-linux-offsets.h: Add include guard.
4871         * guile/guile.h: Rename include guard.
4872         * guile/guile-internal.h: Rename include guard.
4873         * gnu-nat.h: Rename include guard.
4874         * gdb-stabs.h: Rename include guard.
4875         * frv-tdep.h: Add include guard.
4876         * f-lang.h: Add include guard.
4877         * event-loop.h: Add include guard.
4878         * darwin-nat.h: Rename include guard.
4879         * cp-abi.h: Rename include guard.
4880         * config/sparc/nm-sol2.h: Rename include guard.
4881         * config/nm-nto.h: Rename include guard.
4882         * config/nm-linux.h: Add include guard.
4883         * config/i386/nm-i386gnu.h: Rename include guard.
4884         * config/djgpp/nl_types.h: Rename include guard.
4885         * config/djgpp/langinfo.h: Rename include guard.
4886         * compile/gcc-cp-plugin.h: Add include guard.
4887         * compile/gcc-c-plugin.h: Add include guard.
4888         * compile/compile.h: Rename include guard.
4889         * compile/compile-object-run.h: Rename include guard.
4890         * compile/compile-object-load.h: Rename include guard.
4891         * compile/compile-internal.h: Rename include guard.
4892         * compile/compile-cplus.h: Rename include guard.
4893         * compile/compile-c.h: Rename include guard.
4894         * common/xml-utils.h: Rename include guard.
4895         * common/x86-xstate.h: Rename include guard.
4896         * common/version.h: Rename include guard.
4897         * common/vec.h: Rename include guard.
4898         * common/tdesc.h: Rename include guard.
4899         * common/selftest.h: Rename include guard.
4900         * common/scoped_restore.h: Rename include guard.
4901         * common/scoped_mmap.h: Rename include guard.
4902         * common/scoped_fd.h: Rename include guard.
4903         * common/safe-iterator.h: Rename include guard.
4904         * common/run-time-clock.h: Rename include guard.
4905         * common/refcounted-object.h: Rename include guard.
4906         * common/queue.h: Rename include guard.
4907         * common/ptid.h: Rename include guard.
4908         * common/print-utils.h: Rename include guard.
4909         * common/preprocessor.h: Rename include guard.
4910         * common/pathstuff.h: Rename include guard.
4911         * common/observable.h: Rename include guard.
4912         * common/netstuff.h: Rename include guard.
4913         * common/job-control.h: Rename include guard.
4914         * common/host-defs.h: Rename include guard.
4915         * common/gdb_wait.h: Rename include guard.
4916         * common/gdb_vecs.h: Rename include guard.
4917         * common/gdb_unlinker.h: Rename include guard.
4918         * common/gdb_unique_ptr.h: Rename include guard.
4919         * common/gdb_tilde_expand.h: Rename include guard.
4920         * common/gdb_sys_time.h: Rename include guard.
4921         * common/gdb_string_view.h: Rename include guard.
4922         * common/gdb_splay_tree.h: Rename include guard.
4923         * common/gdb_setjmp.h: Rename include guard.
4924         * common/gdb_ref_ptr.h: Rename include guard.
4925         * common/gdb_optional.h: Rename include guard.
4926         * common/gdb_locale.h: Rename include guard.
4927         * common/gdb_assert.h: Rename include guard.
4928         * common/filtered-iterator.h: Rename include guard.
4929         * common/filestuff.h: Rename include guard.
4930         * common/fileio.h: Rename include guard.
4931         * common/environ.h: Rename include guard.
4932         * common/common-utils.h: Rename include guard.
4933         * common/common-types.h: Rename include guard.
4934         * common/common-regcache.h: Rename include guard.
4935         * common/common-inferior.h: Rename include guard.
4936         * common/common-gdbthread.h: Rename include guard.
4937         * common/common-exceptions.h: Rename include guard.
4938         * common/common-defs.h: Rename include guard.
4939         * common/common-debug.h: Rename include guard.
4940         * common/cleanups.h: Rename include guard.
4941         * common/buffer.h: Rename include guard.
4942         * common/btrace-common.h: Rename include guard.
4943         * common/break-common.h: Rename include guard.
4944         * cli/cli-utils.h: Rename include guard.
4945         * cli/cli-style.h: Rename include guard.
4946         * cli/cli-setshow.h: Rename include guard.
4947         * cli/cli-script.h: Rename include guard.
4948         * cli/cli-interp.h: Rename include guard.
4949         * cli/cli-decode.h: Rename include guard.
4950         * cli/cli-cmds.h: Rename include guard.
4951         * charset-list.h: Add include guard.
4952         * buildsym-legacy.h: Rename include guard.
4953         * bfin-tdep.h: Add include guard.
4954         * ax.h: Rename include guard.
4955         * arm-linux-tdep.h: Add include guard.
4956         * arm-fbsd-tdep.h: Add include guard.
4957         * arch/xtensa.h: Rename include guard.
4958         * arch/tic6x.h: Add include guard.
4959         * arch/i386.h: Add include guard.
4960         * arch/arm.h: Rename include guard.
4961         * arch/arm-linux.h: Rename include guard.
4962         * arch/arm-get-next-pcs.h: Rename include guard.
4963         * arch/amd64.h: Add include guard.
4964         * arch/aarch64-insn.h: Rename include guard.
4965         * arch-utils.h: Rename include guard.
4966         * annotate.h: Add include guard.
4967         * amd64-darwin-tdep.h: Rename include guard.
4968         * aarch64-linux-tdep.h: Add include guard.
4969         * aarch64-fbsd-tdep.h: Add include guard.
4970         * aarch32-linux-nat.h: Add include guard.
4971
4972 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4973
4974         * macrotab.c (macro_define_internal): New function that
4975         factorizes macro_define_object_internal and macro_define_function
4976         code.
4977         (macro_define_object_internal): Use macro_define_internal.
4978         (macro_define_function): Likewise.
4979
4980 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4981
4982         * macrocmd.c (extract_identifier): Return
4983         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4984         callers.
4985
4986 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4987
4988         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4989
4990 2019-02-05  Tom Tromey  <tom@tromey.com>
4991
4992         * target.c (target_stack::unpush): Move assertion earlier.
4993
4994 2019-01-30  Tom Tromey  <tom@tromey.com>
4995
4996         PR python/23615:
4997         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4998         (gdbpy_parse_and_eval): Likewise.
4999         * python/python-internal.h (gdbpy_allow_threads): New class.
5000
5001 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5002
5003         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5004         (aarch64_fbsd_fpregmap): Move earlier.
5005         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5006         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5007         instead of individual calls to trad_frame_set_reg_addr.
5008         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5009         earlier.
5010         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5011         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5012         instead of individual calls to trad_frame_set_reg_addr.
5013
5014 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5015
5016         * CONTRIBUTE: Replace contribution list with wiki link.
5017
5018 2019-01-25  Tom Tromey  <tom@tromey.com>
5019
5020         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5021
5022 2019-01-25  Tom Tromey  <tom@tromey.com>
5023
5024         * xtensa-linux-nat.c: Fix common/ includes.
5025         * xml-support.h: Fix common/ includes.
5026         * xml-support.c: Fix common/ includes.
5027         * x86-linux-nat.c: Fix common/ includes.
5028         * windows-nat.c: Fix common/ includes.
5029         * varobj.h: Fix common/ includes.
5030         * varobj.c: Fix common/ includes.
5031         * value.c: Fix common/ includes.
5032         * valops.c: Fix common/ includes.
5033         * utils.c: Fix common/ includes.
5034         * unittests/xml-utils-selftests.c: Fix common/ includes.
5035         * unittests/utils-selftests.c: Fix common/ includes.
5036         * unittests/unpack-selftests.c: Fix common/ includes.
5037         * unittests/tracepoint-selftests.c: Fix common/ includes.
5038         * unittests/style-selftests.c: Fix common/ includes.
5039         * unittests/string_view-selftests.c: Fix common/ includes.
5040         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5041         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5042         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5043         * unittests/rsp-low-selftests.c: Fix common/ includes.
5044         * unittests/parse-connection-spec-selftests.c: Fix common/
5045         includes.
5046         * unittests/optional-selftests.c: Fix common/ includes.
5047         * unittests/offset-type-selftests.c: Fix common/ includes.
5048         * unittests/observable-selftests.c: Fix common/ includes.
5049         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5050         * unittests/memrange-selftests.c: Fix common/ includes.
5051         * unittests/memory-map-selftests.c: Fix common/ includes.
5052         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5053         * unittests/function-view-selftests.c: Fix common/ includes.
5054         * unittests/environ-selftests.c: Fix common/ includes.
5055         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5056         * unittests/common-utils-selftests.c: Fix common/ includes.
5057         * unittests/cli-utils-selftests.c: Fix common/ includes.
5058         * unittests/array-view-selftests.c: Fix common/ includes.
5059         * ui-file.c: Fix common/ includes.
5060         * tui/tui-io.c: Fix common/ includes.
5061         * tracepoint.h: Fix common/ includes.
5062         * tracepoint.c: Fix common/ includes.
5063         * tracefile-tfile.c: Fix common/ includes.
5064         * top.h: Fix common/ includes.
5065         * top.c: Fix common/ includes.
5066         * thread.c: Fix common/ includes.
5067         * target/waitstatus.h: Fix common/ includes.
5068         * target/waitstatus.c: Fix common/ includes.
5069         * target.h: Fix common/ includes.
5070         * target.c: Fix common/ includes.
5071         * target-memory.c: Fix common/ includes.
5072         * target-descriptions.c: Fix common/ includes.
5073         * symtab.h: Fix common/ includes.
5074         * symfile.c: Fix common/ includes.
5075         * stap-probe.c: Fix common/ includes.
5076         * spu-linux-nat.c: Fix common/ includes.
5077         * sparc-nat.c: Fix common/ includes.
5078         * source.c: Fix common/ includes.
5079         * solib.c: Fix common/ includes.
5080         * solib-target.c: Fix common/ includes.
5081         * ser-unix.c: Fix common/ includes.
5082         * ser-tcp.c: Fix common/ includes.
5083         * ser-pipe.c: Fix common/ includes.
5084         * ser-base.c: Fix common/ includes.
5085         * selftest-arch.c: Fix common/ includes.
5086         * s12z-tdep.c: Fix common/ includes.
5087         * rust-exp.y: Fix common/ includes.
5088         * rs6000-aix-tdep.c: Fix common/ includes.
5089         * riscv-tdep.c: Fix common/ includes.
5090         * remote.c: Fix common/ includes.
5091         * remote-notif.h: Fix common/ includes.
5092         * remote-fileio.h: Fix common/ includes.
5093         * remote-fileio.c: Fix common/ includes.
5094         * regcache.h: Fix common/ includes.
5095         * regcache.c: Fix common/ includes.
5096         * record-btrace.c: Fix common/ includes.
5097         * python/python.c: Fix common/ includes.
5098         * python/py-type.c: Fix common/ includes.
5099         * python/py-inferior.c: Fix common/ includes.
5100         * progspace.h: Fix common/ includes.
5101         * producer.c: Fix common/ includes.
5102         * procfs.c: Fix common/ includes.
5103         * proc-api.c: Fix common/ includes.
5104         * printcmd.c: Fix common/ includes.
5105         * ppc-linux-nat.c: Fix common/ includes.
5106         * parser-defs.h: Fix common/ includes.
5107         * osdata.c: Fix common/ includes.
5108         * obsd-nat.c: Fix common/ includes.
5109         * nat/x86-linux.c: Fix common/ includes.
5110         * nat/x86-linux-dregs.c: Fix common/ includes.
5111         * nat/x86-dregs.h: Fix common/ includes.
5112         * nat/x86-dregs.c: Fix common/ includes.
5113         * nat/ppc-linux.c: Fix common/ includes.
5114         * nat/mips-linux-watch.h: Fix common/ includes.
5115         * nat/mips-linux-watch.c: Fix common/ includes.
5116         * nat/linux-waitpid.c: Fix common/ includes.
5117         * nat/linux-ptrace.h: Fix common/ includes.
5118         * nat/linux-ptrace.c: Fix common/ includes.
5119         * nat/linux-procfs.c: Fix common/ includes.
5120         * nat/linux-personality.c: Fix common/ includes.
5121         * nat/linux-osdata.c: Fix common/ includes.
5122         * nat/linux-namespaces.c: Fix common/ includes.
5123         * nat/linux-btrace.h: Fix common/ includes.
5124         * nat/linux-btrace.c: Fix common/ includes.
5125         * nat/fork-inferior.c: Fix common/ includes.
5126         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5127         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5128         * nat/aarch64-linux.c: Fix common/ includes.
5129         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5130         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5131         * namespace.h: Fix common/ includes.
5132         * mips-linux-tdep.c: Fix common/ includes.
5133         * minsyms.c: Fix common/ includes.
5134         * mi/mi-parse.h: Fix common/ includes.
5135         * mi/mi-main.c: Fix common/ includes.
5136         * mi/mi-cmd-env.c: Fix common/ includes.
5137         * memrange.h: Fix common/ includes.
5138         * memattr.c: Fix common/ includes.
5139         * maint.h: Fix common/ includes.
5140         * maint.c: Fix common/ includes.
5141         * main.c: Fix common/ includes.
5142         * machoread.c: Fix common/ includes.
5143         * location.c: Fix common/ includes.
5144         * linux-thread-db.c: Fix common/ includes.
5145         * linux-nat.c: Fix common/ includes.
5146         * linux-fork.c: Fix common/ includes.
5147         * inline-frame.c: Fix common/ includes.
5148         * infrun.c: Fix common/ includes.
5149         * inflow.c: Fix common/ includes.
5150         * inferior.h: Fix common/ includes.
5151         * inferior.c: Fix common/ includes.
5152         * infcmd.c: Fix common/ includes.
5153         * inf-ptrace.c: Fix common/ includes.
5154         * inf-child.c: Fix common/ includes.
5155         * ia64-linux-nat.c: Fix common/ includes.
5156         * i387-tdep.c: Fix common/ includes.
5157         * i386-tdep.c: Fix common/ includes.
5158         * i386-linux-tdep.c: Fix common/ includes.
5159         * i386-linux-nat.c: Fix common/ includes.
5160         * i386-go32-tdep.c: Fix common/ includes.
5161         * i386-fbsd-tdep.c: Fix common/ includes.
5162         * i386-fbsd-nat.c: Fix common/ includes.
5163         * guile/scm-type.c: Fix common/ includes.
5164         * guile/guile.c: Fix common/ includes.
5165         * go32-nat.c: Fix common/ includes.
5166         * gnu-nat.c: Fix common/ includes.
5167         * gdbthread.h: Fix common/ includes.
5168         * gdbarch-selftests.c: Fix common/ includes.
5169         * gdb_usleep.c: Fix common/ includes.
5170         * gdb_select.h: Fix common/ includes.
5171         * gdb_bfd.c: Fix common/ includes.
5172         * gcore.c: Fix common/ includes.
5173         * fork-child.c: Fix common/ includes.
5174         * findvar.c: Fix common/ includes.
5175         * fbsd-nat.c: Fix common/ includes.
5176         * event-top.c: Fix common/ includes.
5177         * event-loop.c: Fix common/ includes.
5178         * dwarf2read.c: Fix common/ includes.
5179         * dwarf2loc.c: Fix common/ includes.
5180         * dwarf2-frame.c: Fix common/ includes.
5181         * dwarf-index-cache.c: Fix common/ includes.
5182         * dtrace-probe.c: Fix common/ includes.
5183         * disasm-selftests.c: Fix common/ includes.
5184         * defs.h: Fix common/ includes.
5185         * csky-tdep.c: Fix common/ includes.
5186         * cp-valprint.c: Fix common/ includes.
5187         * cp-support.h: Fix common/ includes.
5188         * cp-support.c: Fix common/ includes.
5189         * corelow.c: Fix common/ includes.
5190         * completer.h: Fix common/ includes.
5191         * completer.c: Fix common/ includes.
5192         * compile/compile.c: Fix common/ includes.
5193         * compile/compile-loc2c.c: Fix common/ includes.
5194         * compile/compile-cplus-types.c: Fix common/ includes.
5195         * compile/compile-cplus-symbols.c: Fix common/ includes.
5196         * command.h: Fix common/ includes.
5197         * cli/cli-dump.c: Fix common/ includes.
5198         * cli/cli-cmds.c: Fix common/ includes.
5199         * charset.c: Fix common/ includes.
5200         * build-id.c: Fix common/ includes.
5201         * btrace.h: Fix common/ includes.
5202         * btrace.c: Fix common/ includes.
5203         * breakpoint.h: Fix common/ includes.
5204         * breakpoint.c: Fix common/ includes.
5205         * ax.h:
5206         (enum agent_op): Fix common/ includes.
5207         * ax-general.c (struct aop_map): Fix common/ includes.
5208         * ax-gdb.c: Fix common/ includes.
5209         * auxv.c: Fix common/ includes.
5210         * auto-load.c: Fix common/ includes.
5211         * arm-tdep.c: Fix common/ includes.
5212         * arch/riscv.c: Fix common/ includes.
5213         * arch/ppc-linux-common.c: Fix common/ includes.
5214         * arch/i386.c: Fix common/ includes.
5215         * arch/arm.c: Fix common/ includes.
5216         * arch/arm-linux.c: Fix common/ includes.
5217         * arch/arm-get-next-pcs.c: Fix common/ includes.
5218         * arch/amd64.c: Fix common/ includes.
5219         * arch/aarch64.c: Fix common/ includes.
5220         * arch/aarch64-insn.c: Fix common/ includes.
5221         * arch-utils.c: Fix common/ includes.
5222         * amd64-windows-tdep.c: Fix common/ includes.
5223         * amd64-tdep.c: Fix common/ includes.
5224         * amd64-sol2-tdep.c: Fix common/ includes.
5225         * amd64-obsd-tdep.c: Fix common/ includes.
5226         * amd64-nbsd-tdep.c: Fix common/ includes.
5227         * amd64-linux-tdep.c: Fix common/ includes.
5228         * amd64-linux-nat.c: Fix common/ includes.
5229         * amd64-fbsd-tdep.c: Fix common/ includes.
5230         * amd64-fbsd-nat.c: Fix common/ includes.
5231         * amd64-dicos-tdep.c: Fix common/ includes.
5232         * amd64-darwin-tdep.c: Fix common/ includes.
5233         * agent.c: Fix common/ includes.
5234         * ada-lang.h: Fix common/ includes.
5235         * ada-lang.c: Fix common/ includes.
5236         * aarch64-tdep.c: Fix common/ includes.
5237
5238 2019-01-25  Tom Tromey  <tom@tromey.com>
5239
5240         * common/create-version.sh: Use common/version.h.
5241
5242 2019-01-24  Pedro Alves  <palves@redhat.com>
5243
5244         * infrun.c (signal_stop, signal_print, signal_program)
5245         (signal_catch, signal_pass): Now arrays instead of pointers.
5246         (update_signals_program_target, do_target_resume)
5247         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5248         * linux-nat.c (linux_nat_target::pass_signals)
5249         (linux_nat_target::create_inferior, linux_nat_target::attach):
5250         Adjust.
5251         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5252         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5253         * procfs.c (procfs_target::pass_signals): Adjust.
5254         * record-full.c (record_full_target::resume): Adjust.
5255         * remote.c (remote_target::pass_signals)
5256         (remote_target::program_signals): Adjust.
5257         * target-debug.h (target_debug_print_signals): Now takes a
5258         gdb::array_view as parameter.  Adjust.
5259         * target.h (target_ops) <pass_signals, program_signals>: Replace
5260         pointer and length parameters with gdb::array_view.
5261         (target_pass_signals, target_program_signals): Likewise.
5262         * target-delegates.c: Regenerate.
5263
5264 2019-01-24  Pedro Alves  <palves@redhat.com>
5265
5266         * common/forward-scope-exit.h
5267         (forward_scope_exit::forward_scope_exit): Pass arguments to
5268         m_bind_function directly, instead of creating a std::bind and
5269         copying that.
5270
5271 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5272
5273         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5274         for static members.
5275         (pass_in_v_vfp_candidate): Likewise.
5276
5277 2019-01-23  Tom Tromey  <tom@tromey.com>
5278             Pedro Alves  <palves@redhat.com>
5279
5280         * regcache.c (class regcache_invalidator): Remove.
5281         (regcache::raw_write): Use make_scope_exit.
5282
5283 2019-01-23  Tom Tromey  <tom@tromey.com>
5284
5285         * ui-out.h (class ui_out_emit_type): Update comment.
5286
5287 2019-01-23  Tom Tromey  <tom@tromey.com>
5288
5289         * infrun.c (fetch_inferior_event): Update comment.
5290
5291 2019-01-23  Tom Tromey  <tom@tromey.com>
5292             Pedro Alves  <palves@redhat.com>
5293
5294         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5295         parameter.
5296         (fetch_inferior_event): Use SCOPE_EXIT.
5297
5298
5299 2019-01-23  Tom Tromey  <tom@tromey.com>
5300             Pedro Alves  <palves@redhat.com>
5301
5302         * infrun.c (disable_thread_events): Delete.
5303         (stop_all_threads): Use SCOPE_EXIT.
5304
5305 2019-01-23  Tom Tromey  <tom@tromey.com>
5306             Pedro Alves  <palves@redhat.com>
5307
5308         * symfile.c: Include forward-scope-exit.h.
5309         (clear_symtab_users_cleanup): Replace forward declaration with
5310         a FORWARD_SCOPE_EXIT.
5311         (syms_from_objfile_1): Use the forward_scope_exit and
5312         gdb::optional instead of cleanup_function.
5313         (reread_symbols): Use the forward_scope_exit instead of
5314         cleanup_function.
5315         (clear_symtab_users_cleanup): Remove function.
5316
5317 2019-01-23  Tom Tromey  <tom@tromey.com>
5318             Pedro Alves  <palves@redhat.com>
5319
5320         * linux-nat.c: Include scope-exit.h.
5321         (cleanup_target_stop): Remove.
5322         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5323         SCOPE_EXIT.
5324
5325 2019-01-23  Tom Tromey  <tom@tromey.com>
5326             Pedro Alves  <palves@redhat.com>
5327
5328         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5329         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5330
5331 2019-01-23  Tom Tromey  <tom@tromey.com>
5332             Andrew Burgess  <andrew.burgess@embecosm.com>
5333             Pedro Alves  <palves@redhat.com>
5334
5335         * infrun.c (fetch_inferior_event): Use scope_exit.
5336         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5337         * top.c (execute_command): Use scope_exit.
5338         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5339         * utils.c (do_bpstat_clear_actions_cleanup)
5340         (make_bpstat_clear_actions_cleanup): Remove.
5341
5342 2019-01-23  Tom Tromey  <tom@tromey.com>
5343             Pedro Alves  <palves@redhat.com>
5344
5345         * infrun.c: Include "common/scope-exit.h"
5346         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5347         (wait_for_inferior): Use SCOPE_EXIT.
5348         (fetch_inferior_event): Use scope_exit.
5349
5350 2019-01-23  Tom Tromey  <tom@tromey.com>
5351             Pedro Alves  <palves@redhat.com>
5352
5353         * breakpoint.c (create_breakpoint): Remove cleanup.
5354
5355 2019-01-23  Tom Tromey  <tom@tromey.com>
5356             Andrew Burgess  <andrew.burgess@embecosm.com>
5357             Pedro Alves  <palves@redhat.com>
5358
5359 2019-01-23  Pedro Alves  <palves@redhat.com>
5360
5361         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5362
5363 2019-01-23  Pedro Alves  <palves@redhat.com>
5364             Andrew Burgess  <andrew.burgess@embecosm.com>
5365
5366         * gdbthread.h: Include "common/forward-scope-exit.h".
5367         (scoped_finish_thread_state): Redefine custom class in terms of
5368         forward_scope_exit.
5369
5370 2019-01-23  Pedro Alves  <palves@redhat.com>
5371             Andrew Burgess  <andrew.burgess@embecosm.com>
5372
5373         * common/forward-scope-exit.h: New file.
5374
5375 2019-01-23  Pedro Alves  <palves@redhat.com>
5376             Andrew Burgess  <andrew.burgess@embecosm.com>
5377             Tom Tromey  <tom@tromey.com>
5378
5379         * common/scope-exit.h: New file.
5380
5381 2019-01-23  Pedro Alves  <palves@redhat.com>
5382
5383         * common/preprocessor.h (ESC): Rename to ...
5384         (ESC_PARENS): ... this.
5385         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5386         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5387
5388 2019-01-23  Tom Tromey  <tom@tromey.com>
5389
5390         * language.h (class scoped_switch_to_sym_language_if_auto):
5391         Initialize m_lang in both cases.
5392
5393 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5394
5395         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5396         with XCNEW.
5397
5398 2019-01-22  Tom Tromey  <tom@tromey.com>
5399
5400         * corelow.c: Do not include sys/file.h.
5401
5402 2019-01-22  Tom Tromey  <tom@tromey.com>
5403
5404         * tui/tui-wingeneral.h: Include gdb_curses.h.
5405
5406 2019-01-22  Tom Tromey  <tom@tromey.com>
5407
5408         * source-cache.h (class source_cache) <get_source_lines,
5409         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5410
5411 2019-01-22  Tom Tromey  <tom@tromey.com>
5412
5413         * remote-fileio.h (struct remote_target): Declare.
5414
5415 2019-01-22  Tom Tromey  <tom@tromey.com>
5416
5417         * python/py-arch.c: Do not include py-ref.h.
5418         * python/py-bpevent.c: Do not include py-ref.h.
5419         * python/py-cmd.c: Do not include py-ref.h.
5420         * python/py-continueevent.c: Do not include py-ref.h.
5421         * python/py-event.h: Do not include py-ref.h.
5422         * python/py-evtregistry.c: Do not include py-ref.h.
5423         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5424         * python/py-frame.c: Do not include py-ref.h.
5425         * python/py-framefilter.c: Do not include py-ref.h.
5426         * python/py-function.c: Do not include py-ref.h.
5427         * python/py-infevents.c: Do not include py-ref.h.
5428         * python/py-linetable.c: Do not include py-ref.h.
5429         * python/py-objfile.c: Do not include py-ref.h.
5430         * python/py-param.c: Do not include py-ref.h.
5431         * python/py-prettyprint.c: Do not include py-ref.h.
5432         * python/py-progspace.c: Do not include py-ref.h.
5433         * python/py-symbol.c: Do not include py-ref.h.
5434         * python/py-symtab.c: Do not include py-ref.h.
5435         * python/py-type.c: Do not include py-ref.h.
5436         * python/py-unwind.c: Do not include py-ref.h.
5437         * python/py-utils.c: Do not include py-ref.h.
5438         * python/py-value.c: Do not include py-ref.h.
5439         * python/py-varobj.c: Do not include py-ref.h.
5440         * python/py-xmethods.c: Do not include py-ref.h.
5441         * python/python.c: Do not include py-ref.h.
5442         * varobj.c: Do not include py-ref.h.
5443
5444 2019-01-22  Tom Tromey  <tom@tromey.com>
5445
5446         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5447         keyword for bcache.
5448
5449 2019-01-22  Tom Tromey  <tom@tromey.com>
5450
5451         * compile/compile-cplus-types.c: Remove a comment by #include.
5452
5453 2019-01-22  Tom Tromey  <tom@tromey.com>
5454
5455         * compile/gcc-c-plugin.h: Include compile-internal.h.
5456
5457 2019-01-22  Tom Tromey  <tom@tromey.com>
5458
5459         * stabsread.c (EXTERN): Do not define.
5460         (symnum, next_symbol_text_func, processing_gcc_compilation)
5461         (within_function, global_sym_chain, global_stabs)
5462         (previous_stab_code, this_object_header_files)
5463         (n_this_object_header_files)
5464         (n_allocated_this_object_header_files): Define.
5465         * stabsread.h (EXTERN): Never define.  Use "extern".
5466
5467 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5468
5469         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5470         history_value.
5471
5472 2019-01-21  Tom Tromey  <tom@tromey.com>
5473
5474         * ui-out.c: Fix includes.
5475         * tui/tui-source.c: Fix includes.
5476         * target.c: Fix includes.
5477         * remote.c: Fix includes.
5478         * regcache.c: Fix includes.
5479         * python/py-block.c: Fix includes.
5480         * printcmd.c: Fix includes.
5481         * or1k-tdep.c: Fix includes.
5482         * mi/mi-main.c: Fix includes.
5483         * m32r-tdep.c: Fix includes.
5484         * csky-tdep.c: Fix includes.
5485         * compile/compile-cplus-types.c: Fix includes.
5486         * cli/cli-interp.c: Fix includes.
5487
5488 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5489
5490         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5491         for padding.
5492
5493 2019-01-16  Tom Tromey  <tom@tromey.com>
5494
5495         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5496         earlier.
5497         (struct objfile) <msymbols_range>: Move from top level.
5498         <msymbols>: New method.
5499         (class objfile_msymbols): Remove.
5500         * symtab.c (default_collect_symbol_completion_matches_break_on):
5501         Update.
5502         * symmisc.c (dump_msymbols): Update.
5503         * stabsread.c (scan_file_globals): Update.
5504         * objc-lang.c (info_selectors_command, info_classes_command)
5505         (find_methods): Update.
5506         * minsyms.c (find_solib_trampoline_target): Update.
5507         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5508         * coffread.c (coff_symfile_read): Update.
5509         * ada-lang.c (ada_lookup_simple_minsym)
5510         (ada_collect_symbol_completion_matches): Update.
5511
5512 2019-01-16  Tom Tromey  <tom@tromey.com>
5513
5514         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5515         type.  Remove no-argument constructor.
5516         <iterator::operator++>: Simplify.
5517         <begin>: Update.
5518         <end>: Use minimal_symbol_count.
5519
5520 2019-01-16  Tom Tromey  <tom@tromey.com>
5521
5522         * objfiles.h (struct objfile) <psymtabs>: New method.
5523         (class objfile_psymtabs): Remove.
5524         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5525         typedef.
5526         <range>: New method.
5527         (require_partial_symbols): Change return type.
5528         * psymtab.c (require_partial_symbols)
5529         (psym_expand_symtabs_matching): Update.
5530         * mdebugread.c (parse_partial_symbols): Update.
5531         * dbxread.c (dbx_end_psymtab): Update.
5532
5533 2019-01-15  Tom Tromey  <tom@tromey.com>
5534
5535         * symtab.c (lookup_objfile_from_block)
5536         (lookup_symbol_in_objfile_symtabs)
5537         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5538         (find_line_symtab, info_sources_command)
5539         (default_collect_symbol_completion_matches_break_on)
5540         (make_source_files_completion_list): Update.
5541         * symmisc.c (print_objfile_statistics, dump_objfile)
5542         (maintenance_print_symbols, maintenance_info_symtabs)
5543         (maintenance_check_symtabs, maintenance_info_line_tables):
5544         Update.
5545         * source.c (select_source_symtab)
5546         (forget_cached_source_info_for_objfile): Update.
5547         * objfiles.h (class objfile_compunits): Remove.
5548         (struct objfile) <compunits_range>: New typedef.
5549         (compunits): New method.
5550         * objfiles.c (objfile_relocate1): Update.
5551         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5552         * maint.c (count_symtabs_and_blocks): Update.
5553         * linespec.c (iterate_over_all_matching_symtabs): Update.
5554         * cp-support.c (add_symbol_overload_list_qualified): Update.
5555         * coffread.c (coff_symtab_read): Update.
5556         * ada-lang.c (add_nonlocal_symbols)
5557         (ada_collect_symbol_completion_matches)
5558         (ada_add_global_exceptions): Update.
5559
5560 2019-01-15  Tom Tromey  <tom@tromey.com>
5561
5562         * progspace.h (program_space) <objfiles_safe_range>: New
5563         typedef.
5564         <objfiles_safe>: New method.
5565         * objfiles.h (class all_objfiles_safe): Remove.
5566         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5567         * jit.c (jit_inferior_exit_hook): Update.
5568
5569 2019-01-17  Tom Tromey  <tom@tromey.com>
5570
5571         * progspace.h (program_space) <objfiles_range>: New typedef.
5572         <objfiles>: New method.
5573         <objfiles_head>: Rename from objfiles.
5574         (object_files): Update.
5575         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5576         * guile/scm-pretty-print.c
5577         (ppscm_find_pretty_printer_from_objfiles): Update.
5578         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5579         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5580         Update.
5581         * python/py-progspace.c (pspy_get_objfiles): Update.
5582         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5583         Update.
5584         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5585         (objfpy_lookup_objfile_by_build_id): Update.
5586         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5587         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5588         Update.
5589         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5590         (expand_symtab_containing_pc, lookup_objfile_from_block)
5591         (lookup_static_symbol, basic_lookup_transparent_type)
5592         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5593         (find_line_symtab, info_sources_command)
5594         (default_collect_symbol_completion_matches_break_on)
5595         (make_source_files_completion_list, find_main_name): Update.
5596         * symmisc.c (print_symbol_bcache_statistics)
5597         (print_objfile_statistics, maintenance_print_symbols)
5598         (maintenance_print_msymbols, maintenance_print_objfiles)
5599         (maintenance_info_symtabs, maintenance_check_symtabs)
5600         (maintenance_expand_symtabs, maintenance_info_line_tables):
5601         Update.
5602         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5603         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5604         (map_overlay_command, unmap_overlay_command)
5605         (simple_overlay_update, expand_symtabs_matching)
5606         (map_symbol_filenames): Update.
5607         * symfile-debug.c (set_debug_symfile): Update.
5608         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5609         Update.
5610         * source.c (select_source_symtab, forget_cached_source_info):
5611         Update.
5612         * solib.c (solib_read_symbols): Update.
5613         * solib-spu.c (append_ocl_sos): Update.
5614         * psymtab.c (maintenance_print_psymbols)
5615         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5616         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5617         * printcmd.c (info_symbol_command): Update.
5618         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5619         Update.
5620         * objfiles.h (class all_objfiles): Remove.
5621         * objfiles.c (have_partial_symbols, have_full_symbols)
5622         (have_minimal_symbols, qsort_cmp, update_section_map)
5623         (shared_objfile_contains_address_p)
5624         (default_iterate_over_objfiles_in_search_order): Update.
5625         * objc-lang.c (info_selectors_command, info_classes_command)
5626         (find_methods): Update.
5627         * minsyms.c (find_solib_trampoline_target): Update.
5628         * maint.c (maintenance_info_sections)
5629         (maintenance_translate_address, count_symtabs_and_blocks):
5630         Update.
5631         * main.c (captured_main_1): Update.
5632         * linux-thread-db.c (try_thread_db_load_from_pdir)
5633         (has_libpthread): Update.
5634         * linespec.c (iterate_over_all_matching_symtabs)
5635         (search_minsyms_for_name): Update.
5636         * jit.c (jit_find_objf_with_entry_addr): Update.
5637         * hppa-tdep.c (find_unwind_entry)
5638         (hppa_lookup_stub_minimal_symbol): Update.
5639         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5640         Update.
5641         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5642         (elf_gnu_ifunc_resolve_by_got): Update.
5643         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5644         * dwarf-index-write.c (save_gdb_index_command): Update.
5645         * cp-support.c (add_symbol_overload_list_qualified): Update.
5646         * breakpoint.c (create_overlay_event_breakpoint)
5647         (create_longjmp_master_breakpoint)
5648         (create_std_terminate_master_breakpoint)
5649         (create_exception_master_breakpoint): Update.
5650         * blockframe.c (find_pc_partial_function): Update.
5651         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5652         (ada_collect_symbol_completion_matches)
5653         (ada_add_global_exceptions): Update.
5654
5655 2019-01-17  Tom Tromey  <tom@tromey.com>
5656
5657         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5658         declare VEC.
5659         (solib_target_parse_libraries): Change return type.
5660         (library_list_start_segment, library_list_start_section)
5661         (library_list_end_library, library_list_start_library); Update.
5662         (solib_target_free_library_list): Remove.
5663         (solib_target_parse_libraries): Remove cleanup.  Change return
5664         type.
5665         (solib_target_current_sos): Update.
5666
5667 2019-01-17  Tom Tromey  <tromey@bapiya>
5668
5669         * valprint.c: Replace "the the" with "the".
5670         * symtab.c: Replace "the the" with "the".
5671         * solib.c: Replace "the the" with "the".
5672         * solib-dsbt.c: Replace "the the" with "the".
5673         * linespec.c: Replace "the the" with "the".
5674         * dwarf2loc.h: Replace "the the" with "the".
5675         * amd64-windows-tdep.c: Replace "the the" with "the".
5676         * aarch64-tdep.c: Replace "the the" with "the".
5677
5678 2019-01-16  Keith Seitz  <keiths@redhat.com>
5679
5680         PR gdb/23773
5681         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5682         <builder>: Rename to ..
5683         <m_builder>: ... this and make private.
5684         (dwarf2_cu::get_builder): New method.  Change all users of
5685         `builder' to use this method.
5686         (dwarf2_start_symtab): Move to ...
5687         (dwarf2_cu::start_symtab): ... here.  Update all callers
5688         (setup_type_unit_groups): Move to ...
5689         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5690         callers.
5691         (dwarf2_cu::reset_builder): New method.
5692         (process_full_compunit, process_full_type_unit): Use
5693         dwarf2_cu::reset_builder.
5694         (follow_die_offset): Record the ancestor CU if it is different
5695         from the followed DIE's CU.
5696         (follow_die_sig_1): Likewise.
5697
5698 2019-01-15  Tom Tromey  <tom@tromey.com>
5699
5700         * remote.c (class remote_state) <buf>: Now a char_vector.
5701         <buf_size>: Remove.
5702         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5703         parameter.
5704         (remote_target::getpkt_or_notif_sane_1)
5705         (remote_target::getpkt_sane)
5706         (remote_target::getpkt_or_notif_sane): Likewise.
5707         (class remote_target) <putpkt>: New overload.
5708         (remote_target::read_frame): Change type of "buf_p".  Remove
5709         sizeof_p parameter.
5710         (packet_ok): New overload.
5711         (packet_check_result): New overload.
5712         Update all uses.
5713
5714 2019-01-14  Tom Tromey  <tom@tromey.com>
5715
5716         * remote-notif.c (handle_notification, remote_notif_ack)
5717         (remote_notif_parse): Make "buf" const.
5718         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5719         const.
5720         (remote_notif_parse, remote_notif_ack, handle_notification):
5721         Likewise.
5722         * remote.c (remote_notif_stop_parse): Make "buf" const.
5723         (remote_target::remote_parse_stop_reply): Make "buf" const.
5724         (remote_notif_stop_ack): Make "buf" const.
5725
5726 2019-01-14  Tom Tromey  <tom@tromey.com>
5727
5728         * remote.c (remote_console_output): Make parameter const.
5729
5730 2019-01-14  Tom Tromey  <tom@tromey.com>
5731
5732         * target-debug.h (target_debug_print_signals): Constify.
5733         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5734         * procfs.c (procfs_target::pass_signals): Update.
5735         * linux-nat.c (linux_nat_target::pass_signals): Update.
5736         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5737         * target-delegates.c: Rebuild.
5738         * remote.c (remote_target::program_signals): Update.
5739         (remote_target::pass_signals): Update.
5740         * target.c (target_pass_signals): Constify argument.
5741         (target_program_signals): Likewise.
5742         * target.h (struct target_ops) <pass_signals, program_signals>:
5743         Constify argument.
5744         (target_pass_signals, target_program_signals): Constify argument.
5745
5746 2019-01-14  Tom Tromey  <tom@tromey.com>
5747
5748         PR tui/28819:
5749         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5750
5751 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5752
5753         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5754         field.
5755         * rs6000-tdep.c: Include reggroups.h.
5756         (IS_V_ALIAS_PSEUDOREG): Define.
5757         (rs6000_register_name): Return names for the "vX" aliases.
5758         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5759         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5760         aliases.  Call default_register_reggroup_p for all other
5761         pseudo-registers.
5762         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5763         New functions.
5764         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5765         Handle "vX" aliases.
5766         (v_alias_pseudo_register_collect): New function.
5767         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5768         (rs6000_gdbarch_init): Initialize "vX" aliases as
5769         pseudo-registers.  Restore registration of
5770         rs6000_pseudo_register_reggroup_p with
5771         set_tdesc_pseudo_register_reggroup_p.
5772
5773 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5774
5775         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5776         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5777         set_gdbarch_num_pseudo_regs.
5778
5779 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5780
5781         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5782         Remove arg prefixname, add do_set and do_show.
5783         Add member functions set_list and show_list.
5784         * cli/cli-style.c (class cli_style_option): Update accordingly.
5785         (style_set_list): Move to file scope.
5786         (style_show_list): Likewise.
5787         (set_style): Call help_list.
5788         (show_style): Call cmd_show_list.
5789         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5790         Update to use the new macro.
5791
5792 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5793
5794         * ada-lang.c (_initialize_ada_language): Expand the help text
5795         for the "catch exception" command.
5796
5797 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5798
5799         * symtab.c (matching_obj_sections): Initialize obj,
5800         declare it closer to its usage.
5801
5802 2019-01-10  Tom Tromey  <tom@tromey.com>
5803
5804         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5805         (basic_inf_threads_range): Remove.
5806         (inf_threads_range, inf_non_exited_threads_range)
5807         (safe_inf_threads_range): Use next_adapter.
5808
5809 2019-01-10  Keith Seitz  <keiths@redhat.com>
5810
5811         PR gdb/23712
5812         PR symtab/23010
5813         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5814         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5815
5816 2019-01-10  Keith Seitz  <keiths@redhat.com>
5817
5818         PR gdb/23712
5819         PR symtab/23010
5820         * dictionary.c (pending_to_vector): Remove.
5821         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5822         Remove _1 suffix, replacing functions of the same name.  Update
5823         all callers.
5824         (dict_create_hashed, dict_create_hashed_expandable)
5825         (dict_create_linear, dict_create_linear_expandable, dict_free)
5826         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5827         Make functions static.
5828
5829 2019-01-10  Keith Seitz  <keiths@redhat.com>
5830
5831         PR gdb/23712
5832         PR symtab/23010
5833         * dictionary.h (struct dictionary): Replace declaration with
5834         multidictionary.
5835         (dict_create_hashed, dict_create_hashed_expandable)
5836         (dict_create_linear, dict_create_linear_expandable)
5837         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5838         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5839         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5840         taking multidictionary argument.
5841         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5842         * block.h (struct block) <dict>: Change to multidictionary
5843         and rename `multidict'.
5844         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5845         symmisc.c: Update all dictionary references to multidictionary.
5846
5847 2019-01-10  Keith Seitz  <keiths@redhat.com>
5848
5849         PR gdb/23712
5850         PR symtab/23010
5851         * dictionary.c: Include unordered_map.
5852         (pending_to_vector): New function.
5853         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5854         Rewrite the non-"_1" functions to take vector instead
5855         of linked list.
5856         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5857         "new" _1 versions of the same name.
5858         (multidictionary): Define.
5859         (std::hash<enum language): New definition.
5860         (collate_pending_symbols_by_language, mdict_create_hashed)
5861         (mdict_create_hashed_expandable, mdict_create_linear)
5862         (mdict_create_linear_expandable, mdict_free)
5863         (find_language_dictionary, create_new_language_dictionary)
5864         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5865         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5866         (mdict_size, mdict_empty): New functions.
5867         * dictionary.h (mdict_iterator): Define.
5868
5869 2019-01-10  Pedro Alves  <palves@redhat.com>
5870
5871         * breakpoint.c (read_uploaded_action)
5872         (create_tracepoint_from_upload): Adjust to use
5873         gdb::unique_xmalloc_ptr.
5874         * ctf.c (ctf_write_uploaded_tp):
5875         (SET_ARRAY_FIELD): Use emplace_back.
5876         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5877         * tracefile-tfile.c (tfile_write_uploaded_tp):
5878         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5879         gdb::unique_xmalloc_ptr.
5880         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5881         at_string, cond_string, cmd_strings>: Replace char pointers
5882         with gdb::unique_xmalloc_ptr.
5883
5884 2019-01-10  Pedro Alves  <palves@redhat.com>
5885
5886         * solib-target.c (library_list_start_library): Don't xstrdup name.
5887
5888 2019-01-10  Pedro Alves  <palves@redhat.com>
5889
5890         * mdebugread.c (parse_partial_symbols): Use
5891         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5892
5893 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5894
5895         * linux-fork.c (scoped_switch_fork_info)
5896         <~scoped_switch_fork_info>: Fix incorrect variable name.
5897
5898 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5899
5900         * linux-fork.c (scoped_switch_fork_info)
5901         <scoped_switch_fork_info>: Make explicit.
5902         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5903
5904 2019-01-10  Tom Tromey  <tom@tromey.com>
5905
5906         * objfiles.h (objfile::reset_psymtabs): Update.
5907         * objfiles.c (objfile::objfile): Update.
5908         * psymtab.h (psymtab_storage::obstack): Update.
5909         (psymtab_storage::m_obstack): Use gdb::optional.
5910         (class psymtab_storage): Update comment.  Remove objfile
5911         parameter.
5912         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5913
5914 2019-01-10  Tom Tromey  <tom@tromey.com>
5915
5916         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5917         <free_psymtabs>: Now private.
5918         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5919         (allocate_psymtab): Use new method.
5920
5921 2019-01-10  Tom Tromey  <tom@tromey.com>
5922
5923         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5924         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5925         * mdebugread.c (parse_partial_symbols): Use
5926         allocate_dependencies.
5927         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5928         allocate_dependencies.
5929         (process_psymtab_comp_unit_reader)
5930         (build_type_psymtab_dependencies): Likewise.
5931         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5932
5933 2019-01-10  Tom Tromey  <tom@tromey.com>
5934
5935         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5936         PSYMBOL_SET_LANGUAGE.
5937         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5938
5939 2019-01-10  Tom Tromey  <tom@tromey.com>
5940
5941         * psymtab.h (psymtab_storage::obstack): New method.
5942         <m_obstack>: Rename from obstack; now private.
5943         * psymtab.c (psymtab_storage): Update.
5944         * dwarf2read.c (create_addrmap_from_index)
5945         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5946         Update.
5947
5948 2019-01-10  Tom Tromey  <tom@tromey.com>
5949
5950         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5951         * objfiles.h (objfile::reset_psymtabs): New method.
5952
5953 2019-01-10  Tom Tromey  <tom@tromey.com>
5954
5955         * symmisc.c (print_symbol_bcache_statistics): Update.
5956         (print_objfile_statistics): Update.
5957         * symfile.c (reread_symbols): Update.
5958         * psymtab.h (class psymtab_storage): New.
5959         * psymtab.c (psymtab_storage): New constructor.
5960         (~psymtab_storage): New destructor.
5961         (require_partial_symbols): Update.
5962         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5963         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5964         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5965         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5966         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5967         (start_psymtab_common, end_psymtab_common)
5968         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5969         (allocate_psymtab): Update.
5970         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5971         Update.
5972         (dump_psymtab_addrmap, maintenance_print_psymbols)
5973         (maintenance_check_psymtabs): Update.
5974         (class objfile_psymtabs): Move to objfiles.h.
5975         * psympriv.h (discard_psymtab): Now inline.
5976         (psymtab_discarder::psymtab_discarder): Update.
5977         (psymtab_discarder::~psymtab_discarder): Update.
5978         (ALL_OBJFILE_PSYMTABS): Rewrite.
5979         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5980         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5981         Remove fields.
5982         <partial_symtabs>: New field.
5983         (class objfile_psymtabs): Move from psymtab.h.  Update.
5984         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5985         psymbol_cache.
5986         (objfile::~objfile): Don't destroy psymbol_cache.
5987         * mdebugread.c (parse_partial_symbols): Update.
5988         * dwarf2read.c (create_addrmap_from_index)
5989         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5990         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5991         (add_partial_subprogram, dwarf2_ranges_read): Update.
5992         * dwarf-index-write.c (write_address_map)
5993         (write_one_signatured_type, recursively_write_psymbols)
5994         (class debug_names, class debug_names, write_psymtabs_to_index):
5995         Update.
5996
5997 2019-01-10  Tom Tromey  <tom@tromey.com>
5998
5999         * symtab.h (SYMBOL_SET_NAMES): Update.
6000         (symbol_set_names): Update.
6001         (MSYMBOL_SET_NAMES): Update.
6002         * symtab.c (symbol_set_names): Change argument to be an
6003         objfile_per_bfd_storage.
6004         * psymtab.c (add_psymbol_to_bcache): Update.
6005         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6006
6007 2019-01-10  Tom Tromey  <tom@tromey.com>
6008
6009         * symtab.c (create_demangled_names_hash): Change argument to be an
6010         objfile_per_bfd_storage.
6011         (symbol_set_names): Update.
6012
6013 2019-01-10  Tom Tromey  <tom@tromey.com>
6014
6015         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6016         init_psymbol_list.
6017         * psymtab.c (init_psymbol_list): Do nothing if already called.
6018         * psympriv.h (init_psymbol_list): Add comment.
6019         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6020         init_psymbol_list.
6021         * dbxread.c (dbx_symfile_read): Unconditionally call
6022         init_psymbol_list.
6023
6024 2019-01-10  Tom Tromey  <tom@tromey.com>
6025
6026         * xcoffread.c (scan_xcoff_symtab): Update.
6027         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6028         "where".
6029         * mdebugread.c (parse_partial_symbols)
6030         (handle_psymbol_enumerators): Update.
6031         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6032         * dbxread.c (read_dbx_symtab): Update.
6033         * psympriv.h (psymbol_placement): New enum.
6034         (add_psymbol_to_list): Update.
6035
6036 2019-01-10  Tom Tromey  <tom@tromey.com>
6037
6038         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6039         static_psymbols parameters.
6040         (scan_xcoff_symtab): Update.
6041         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6042         static_psymbols parameters.
6043         * psympriv.h (start_psymtab_common): Update.
6044         * mdebugread.c (parse_partial_symbols): Update.
6045         * dwarf2read.c (create_partial_symtab): Update.
6046         * dbxread.c (read_dbx_symtab): Update.
6047         (start_psymtab): Remove global_psymbols and static_psymbols
6048         parameters.
6049
6050 2019-01-10  Tom Tromey  <tom@tromey.com>
6051
6052         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6053         * psymtab.c (allocate_psymtab): Add comment.
6054         * psympriv.h (allocate_psymtab): Add comment.
6055         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6056         initializations.
6057         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6058
6059 2019-01-10  Tom Tromey  <tom@tromey.com>
6060
6061         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6062         Don't declare.
6063         * mipsread.c: Include mdebugread.h.
6064         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6065         Declare.
6066         * elfread.c: Include mdebugread.h.
6067
6068 2019-01-09  Tom Tromey  <tom@tromey.com>
6069
6070         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6071         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6072         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6073         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6074         (psym_lookup_symbol, psym_find_last_source_symtab)
6075         (psym_forget_cached_source_info, psym_print_stats)
6076         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6077         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6078         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6079         (psym_find_compunit_symtab_by_address)
6080         (maintenance_print_psymbols, maintenance_info_psymtabs)
6081         (maintenance_check_psymtabs): Use ranged for.
6082         * psymtab.h (class objfile_psymtabs): New.
6083         (require_partial_symbols): Return objfile_psymtabs.
6084         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6085
6086 2019-01-09  Tom Tromey  <tom@tromey.com>
6087
6088         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6089         (find_pc_mapped_section, list_overlays_command)
6090         (map_overlay_command, unmap_overlay_command)
6091         (simple_overlay_update): Use all_objfiles.
6092         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6093         * printcmd.c (info_symbol_command): Use all_objfiles.
6094         * objfiles.h (ALL_OBJSECTIONS): Remove.
6095         * maint.c (maintenance_translate_address): Use all_objfiles.
6096         * gcore.c (gcore_create_callback): Use all_objfiles.
6097         (objfile_find_memory_regions): Likewise.
6098
6099 2019-01-09  Tom Tromey  <tom@tromey.com>
6100
6101         * symtab.c (find_line_symtab, info_sources_command)
6102         (make_source_files_completion_list): Use objfile_compunits.
6103         * source.c (select_source_symtab): Use objfile_compunits.
6104         * objfiles.h (struct objfile): Update comment.
6105         (ALL_OBJFILES): Remove.
6106         (ALL_FILETABS): Remove.
6107         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6108         objfile_compunits.
6109
6110 2019-01-09  Tom Tromey  <tom@tromey.com>
6111
6112         * symmisc.c (print_objfile_statistics, dump_objfile)
6113         (maintenance_print_symbols): Use compunit_filetabs.
6114         * source.c (forget_cached_source_info_for_objfile): Use
6115         compunit_filetabs.
6116         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6117         (ALL_FILETABS): Use compunit_filetabs.
6118         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6119         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6120
6121 2019-01-09  Tom Tromey  <tom@tromey.com>
6122
6123         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6124         (compunit_filetabs): New.
6125         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6126         compunit_filetabs.
6127         (info_sources_command, make_source_files_completion_list): Remove
6128         declaration.
6129         * symmisc.c (print_objfile_statistics, dump_objfile)
6130         (maintenance_print_symbols): Remove declaration.
6131         (maintenance_info_symtabs): Use compunit_filetabs.
6132         (maintenance_info_line_tables): Likewise.
6133         * source.c (select_source_symtab): Change local variable name.
6134         (forget_cached_source_info_for_objfile): Remove declaration.
6135         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6136         * objfiles.c (objfile_relocate1): Remove declaration.
6137         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6138         declaration.
6139         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6140         * coffread.c (coff_symtab_read): Remove declaration.
6141         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6142         compunit_filetabs.
6143
6144 2019-01-09  Tom Tromey  <tom@tromey.com>
6145
6146         * symtab.c (lookup_objfile_from_block)
6147         (find_pc_sect_compunit_symtab, search_symbols)
6148         (default_collect_symbol_completion_matches_break_on): Use
6149         objfile_compunits.
6150         * objfiles.h (ALL_COMPUNITS): Remove.
6151         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6152         * cp-support.c (add_symbol_overload_list_qualified): Use
6153         objfile_compunits.
6154         * ada-lang.c (ada_collect_symbol_completion_matches)
6155         (ada_add_global_exceptions): Use objfile_compunits.
6156
6157 2019-01-09  Tom Tromey  <tom@tromey.com>
6158
6159         * source.c (select_source_symtab)
6160         (forget_cached_source_info_for_objfile): Remove declaration.
6161         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6162         declaration.
6163         * maint.c (count_symtabs_and_blocks): Remove declaration.
6164         * cp-support.c (add_symbol_overload_list_qualified): Remove
6165         declaration.
6166         * coffread.c (coff_symtab_read): Remove declaration.
6167         * symtab.c (lookup_symbol_in_objfile_symtabs)
6168         (basic_lookup_transparent_type_1): Use objfile_compunits.
6169         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6170         (info_sources_command, search_symbols)
6171         (default_collect_symbol_completion_matches_break_on)
6172         (make_source_files_completion_list): Remove declaration.
6173         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6174         (ada_collect_symbol_completion_matches)
6175         (ada_add_global_exceptions): Remove declaration.
6176         * linespec.c (iterate_over_all_matching_symtabs): Use
6177         objfile_compunits.
6178         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6179         (class objfile_compunits): New.
6180         (ALL_COMPUNITS): Use objfile_compunits.
6181         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6182         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6183         objfile_compunits.
6184         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6185
6186 2019-01-09  Tom Tromey  <tom@tromey.com>
6187
6188         * symtab.c (search_symbols)
6189         (default_collect_symbol_completion_matches_break_on): Use
6190         objfile_msymbols.
6191         * ada-lang.c (ada_lookup_simple_minsym)
6192         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6193         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6194         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6195         objfile_msymbols.
6196         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6197         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6198         * objc-lang.c (find_methods): Use objfile_msymbols.
6199         (info_selectors_command, info_classes_command): Likewise.
6200         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6201         * objfiles.h (class objfile_msymbols): New.
6202         (ALL_OBJFILE_MSYMBOLS): Remove.
6203         (ALL_MSYMBOLS): Remove.
6204
6205 2019-01-09  Tom Tromey  <tom@tromey.com>
6206
6207         * common/next-iterator.h (next_adapter): Add Iterator template
6208         parameter.
6209         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6210         (class all_objfiles_safe): New.
6211         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6212         * objfiles.c (put_objfile_before): Update comment.
6213         (add_separate_debug_objfile): Likewise.
6214         (free_all_objfiles): Use all_objfiles_safe.
6215         (objfile_purge_solibs): Likewise.
6216
6217 2019-01-09  Tom Tromey  <tom@tromey.com>
6218
6219         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6220         (expand_symtab_containing_pc, lookup_static_symbol)
6221         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6222         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6223         all_objfiles.
6224         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6225         * breakpoint.c (create_overlay_event_breakpoint)
6226         (create_longjmp_master_breakpoint)
6227         (create_std_terminate_master_breakpoint)
6228         (create_exception_master_breakpoint): Use all_objfiles.
6229         * linux-thread-db.c (try_thread_db_load_from_pdir)
6230         (has_libpthread): Use all_objfiles.
6231         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6232         * linespec.c (iterate_over_all_matching_symtabs)
6233         (search_minsyms_for_name): Use all_objfiles.
6234         * maint.c (maintenance_info_sections): Use all_objfiles.
6235         * main.c (captured_main_1): Use all_objfiles.
6236         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6237         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6238         * guile/scm-pretty-print.c
6239         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6240         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6241         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6242         (maintenance_print_msymbols): Use all_objfiles.
6243         * source.c (select_source_symtab): Use all_objfiles.
6244         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6245         * symfile.c (remove_symbol_file_command)
6246         (expand_symtabs_matching, map_symbol_filenames): Use
6247         all_objfiles.
6248         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6249         all_objfiles.
6250         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6251         * objc-lang.c (find_methods): Use all_objfiles.
6252         * objfiles.c (have_partial_symbols, have_full_symbols)
6253         (have_minimal_symbols, qsort_cmp)
6254         (default_iterate_over_objfiles_in_search_order): Use
6255         all_objfiles.
6256         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6257         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6258         (maintenance_check_psymtabs): Use all_objfiles.
6259         (ALL_PSYMTABS): Remove.
6260         * compile/compile-object-run.c (do_module_cleanup): Use
6261         all_objfiles.
6262         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6263         * cp-support.c (add_symbol_overload_list_qualified): Use
6264         all_objfiles.
6265         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6266         Use all_objfiles.
6267         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6268         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6269         all_objfiles.
6270         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6271         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6272         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6273         Uses all_objfiles.
6274         * solib.c (solib_read_symbols): Use all_objfiles
6275
6276 2019-01-09  Tom Tromey  <tom@tromey.com>
6277
6278         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6279         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6280         all_objfiles.
6281         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6282         * symmisc.c (print_symbol_bcache_statistics)
6283         (print_objfile_statistics, maintenance_print_objfiles)
6284         (maintenance_info_symtabs, maintenance_check_symtabs)
6285         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6286         all_objfiles.
6287         * source.c (forget_cached_source_info): Use all_objfiles.
6288         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6289         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6290         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6291         * objfiles.c (update_section_map): Use all_objfiles.
6292         (shared_objfile_contains_address_p): Likewise.
6293         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6294         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6295
6296 2019-01-09  Tom Tromey  <tom@tromey.com>
6297
6298         * common/next-iterator.h: New file.
6299         * objfiles.h (class all_objfiles): New.
6300         (struct objfile_iterator): New.
6301
6302 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6303
6304         * NEWS: Move the description of the changed "frame", "select-frame",
6305          and "info frame" commands to the Changed commands section.
6306
6307 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6308
6309         * gdbtypes.c (check_stub_method_group): Remove handling of old
6310         mangling schemes.
6311         * linespec.c (find_methods): Likewise.
6312         * stabsread.c (read_member_functions): Likewise.
6313         * valops.c (search_struct_method): Likewise.
6314         (value_struct_elt_for_reference): Likewise.
6315         * NEWS: Mention this change.
6316
6317 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6318
6319         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6320         print_source_lines.
6321         * source.c (print_source_lines_base): Update line number check.
6322         (print_source_lines): New function.
6323         (source_lines_range::source_lines_range): New function.
6324         * source.h (class source_lines_range): New class.
6325         (print_source_lines): New declaration.
6326
6327 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6328
6329         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6330
6331 2019-01-08  Tom Tromey  <tom@tromey.com>
6332             Simon Marchi  <simon.marchi@ericsson.com>
6333
6334         PR gdb/24060
6335         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6336         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6337         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6338         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6339         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6340         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6341
6342 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6343
6344         * source.c (select_source_symtab): Move header comment to
6345         declaration in source.h.
6346         (forget_cached_source_info_for_objfile): Likewise.
6347         (forget_cached_source_info): Likewise.
6348         (identify_source_line): Likewise.
6349         * source.h (identify_source_line): Move declaration from symtab.h
6350         and add comment from source.c
6351         (print_source_lines): Likewise.
6352         (forget_cached_source_info_for_objfile): Likewise.
6353         (forget_cached_source_info): Likewise.
6354         (select_source_symtab): Likewise.
6355         (enum print_source_lines_flag): Move definition from symtab.h.
6356         * symtab.h (identify_source_line): Move declaration to source.h.
6357         (print_source_lines): Likewise.
6358         (forget_cached_source_info_for_objfile): Likewise.
6359         (forget_cached_source_info): Likewise.
6360         (select_source_symtab): Likewise.
6361         (enum print_source_lines_flag): Move definition to source.h.
6362         * tui/tui-hooks.c: Add 'source.h' include.
6363
6364 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6365
6366         * source.c (print_source_lines_base): Handle requests to print
6367         reverse line number sequences, and guard against empty lines
6368         string.
6369
6370 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6371
6372         * source.c (print_source_lines_base): Fix skip of '\r' if next
6373         character is '\n'.
6374
6375 2019-01-06  Tom Tromey  <tom@tromey.com>
6376
6377         * c-exp.y (struct c_parse_state) <macro_original_text,
6378         expansion_obstack>: New member.
6379         (macro_original_text, expansion_obstack): Remove globals.
6380         (scan_macro_expansion, scanning_macro_expansion)
6381         (finished_macro_expansion): Update.
6382         (scan_macro_cleanup): Remove.
6383         (yylex, c_parse): Update.
6384
6385 2019-01-06  Tom Tromey  <tom@tromey.com>
6386
6387         * c-exp.y (struct c_parse_state) <strings>: New member.
6388         (operator_stoken): Update.
6389
6390 2019-01-06  Tom Tromey  <tom@tromey.com>
6391
6392         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6393         (union type_stack_elt) <typelist_val>: Now a pointer to
6394         std::vector.
6395         (type_stack_cleanup): Don't declare.
6396         (push_typelist): Update.
6397         * parse.c (pop_typelist): Return a std::vector.
6398         (push_typelist): Take a std::vector.
6399         (follow_types): Update.  Do not free args.
6400         (type_stack_cleanup): Remove.
6401         * c-exp.y (struct c_parse_state): New.
6402         (cpstate): New global.
6403         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6404         (nonempty_typelist): Update.
6405         (func_mod): Create a new vector.
6406         (c_parse): Create a c_parse_state.
6407         (check_parameter_typelist): Do not delete params.
6408         (function_method): Update.  Do not delete type_list.
6409
6410 2019-01-06  Tom Tromey  <tom@tromey.com>
6411
6412         PR gdb/28155:
6413         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6414         check_typedef.
6415         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6416         (print_return_value): Likewise.
6417
6418 2019-01-05  Tom Tromey  <tom@tromey.com>
6419
6420         * contrib/cleanup_check.py: Remove.
6421         * contrib/gcc-with-excheck: Remove.
6422         * contrib/exsummary.py: Remove.
6423         * contrib/excheck.py: Remove.
6424
6425 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6426
6427         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6428         NULL. Initialize tpprev to NULL instead of assigning it
6429         to NULL on the next statement.
6430         * windows-nat.c (windows_delete_thread): Remove check for
6431         main_thread_id before printing thread exit notifications.
6432         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6433         Remove thread ID check against main_thread_id.
6434         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6435         windows_delete_thread.
6436         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6437
6438 2019-01-04  Tom Tromey  <tom@tromey.com>
6439
6440         * compile/compile.c (_initialize_compile): Use upper case for
6441         metasyntactic variables.
6442         * symmisc.c (_initialize_symmisc): Use upper case for
6443         metasyntactic variables.
6444         * psymtab.c (_initialize_psymtab): Use upper case for
6445         metasyntactic variables.
6446         * demangle.c (demangle_command): Use upper case for metasyntactic
6447         variables.
6448         (_initialize_demangler): Likewise.
6449         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6450         variables.
6451
6452 2019-01-03  Tom Tromey  <tom@tromey.com>
6453
6454         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6455
6456 2019-01-03  Tom Tromey  <tom@tromey.com>
6457
6458         * python/py-symtab.c (salpy_str): Update.
6459         (struct salpy_sal_object) <symtab>: Now a PyObject.
6460         (salpy_dealloc): Update.
6461         (del_objfile_sal): Use gdbpy_ref.
6462
6463 2019-01-03  Tom Tromey  <tom@tromey.com>
6464
6465         * python/py-type.c (convert_field): Use new_reference.  Return
6466         gdbpy_ref.
6467         (make_fielditem): Return gdbpy_ref.
6468         (typy_fields): Update.
6469         (typy_getitem): Update.
6470         (field_name): Return gdbpy_ref.  Use new_reference.
6471         (typy_iterator_iternext): Update.
6472
6473 2019-01-03  Tom Tromey  <tom@tromey.com>
6474
6475         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6476
6477 2019-01-03  Tom Tromey  <tom@tromey.com>
6478
6479         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6480         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6481         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6482         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6483         (pspy_set_type_printers): Likewise.
6484         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6485         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6486         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6487         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6488         (objfpy_set_type_printers): Likewise.
6489
6490 2019-01-03  Tom Tromey  <tom@tromey.com>
6491
6492         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6493         (gdbpy_print_stack): Use gdbpy_err_fetch.
6494         * python/python-internal.h (class gdbpy_err_fetch): New class.
6495         (class gdbpy_enter) <m_error_type, m_error_value,
6496         m_error_traceback>: Remove.
6497         <m_error>: New member.
6498         (gdbpy_exception_to_string): Don't declare.
6499         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6500         * python/py-value.c (convert_value_from_python): Use
6501         gdbpy_err_fetch.
6502         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6503         gdbpy_exception_to_string.
6504         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6505         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6506         gdbpy_err_fetch.
6507
6508 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6509
6510         * linux-nat.c (delete_lwp_cleanup): Delete.
6511         (struct lwp_deleter): New struct.
6512         (lwp_info_up): New typedef.
6513         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6514         lwp_info_up.
6515
6516 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6517
6518         * linux-fork.c (class scoped_switch_fork_info): New class.
6519         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6520
6521 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6522
6523         * valops.c (find_overload_match): Remove use of null_cleanup, and
6524         calls to do_cleanups.
6525
6526 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6527
6528         * compile/compile-cplus-types.c
6529         (compile_cplus_instance::decl_name): Handle changes to
6530         cp_func_name.
6531         * cp-support.c (cp_func_name): Update header comment, update
6532         return type.
6533         * cp-support.h (cp_func_name): Update return type in declaration.
6534         * valops.c (find_overload_match): Move temp_func local to top
6535         level of function and change its type.  Use temp_func to hold and
6536         delete temporary string obtained from cp_func_name.
6537
6538 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6539
6540         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6541         gdb::char_vector, remove cleanup, and update uses of `msg`.
6542
6543 2019-01-03  Jim Wilson  <jimw@sifive.com>
6544
6545         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6546
6547 2019-01-02  Tom Tromey  <tom@tromey.com>
6548
6549         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6550         (tdesc_parse_xml): Remove cleanups.
6551         * target-descriptions.h (make_cleanup_free_target_description):
6552         Don't declare.
6553         (target_desc_deleter): New struct.
6554         (target_desc_up): New typedef.
6555         * target-descriptions.c (target_desc_deleter::operator()): Rename
6556         from free_target_description.
6557         (make_cleanup_free_target_description): Remove.
6558
6559 2019-01-02  Tom Tromey  <tom@tromey.com>
6560
6561         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6562         constructor, destructor.
6563         (linespec_parser): Remove typedef.
6564         (~linespec_parser): Rename from linespec_parser_delete.
6565         (linespec_lex_to_end, linespec_complete_label)
6566         (linespec_complete): Update.
6567         (decode_line_full): Remove cleanups.
6568         (decode_line_1): Update.
6569
6570 2019-01-02  Tom Tromey  <tom@tromey.com>
6571
6572         * python/python-internal.h (inferior_to_inferior_object): Change
6573         return type.
6574         * python/py-exitedevent.c (create_exited_event_object): Update.
6575         * python/py-inferior.c (inferior_to_inferior_object): Return
6576         gdbpy_ref.
6577         (python_new_inferior, python_inferior_deleted)
6578         (thread_to_thread_object, delete_thread_object)
6579         (build_inferior_list, gdbpy_selected_inferior): Update.
6580         * python/py-infthread.c (create_thread_object): Update.  Also fail
6581         if inferior_to_inferior_object fails.
6582
6583 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6584
6585         * inferior.h (class inferior) <displaced_step_state>: New field.
6586         * infrun.h (struct displaced_step_state): Move here from
6587         infrun.c.  Initialize fields, add constructor.
6588         <inf>: Remove field.
6589         <reset>: New method.
6590         * infrun.c (struct displaced_step_inferior_state): Move to
6591         infrun.h.
6592         (displaced_step_inferior_states): Remove.
6593         (get_displaced_stepping_state): Adust.
6594         (displaced_step_in_progress_any_inferior): Adjust.
6595         (displaced_step_in_progress_thread): Adjust.
6596         (displaced_step_in_progress): Adjust.
6597         (add_displaced_stepping_state): Remove.
6598         (get_displaced_step_closure_by_addr): Adjust.
6599         (remove_displaced_stepping_state): Remove.
6600         (infrun_inferior_exit): Call displaced_step_state.reset.
6601         (use_displaced_stepping): Don't check for NULL.
6602         (displaced_step_prepare_throw): Call
6603         get_displaced_stepping_state.
6604         (displaced_step_fixup): Don't check for NULL.
6605         (prepare_for_detach): Don't check for NULL.
6606
6607 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6608
6609         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6610          in case of call that did not complete.
6611
6612 2019-01-02  Andrey Utkin  <autkin@undo.io>
6613
6614         * symfile.c (find_separate_debug_file): Fix search of debug files for
6615         remote debuggee.
6616
6617 2019-01-02  Tom Tromey  <tom@tromey.com>
6618
6619         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6620         indentation.
6621         * python/py-frame.c (frapy_older): Remove cast.
6622         (frapy_newer): Likewise.
6623         * python/py-breakpoint.c (local_setattro): Remove cast.
6624         * python/py-arch.c (archpy_name): Remove local variable.
6625         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6626
6627 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6628
6629         * unittests/basic_string_view/element_access/char/empty.cc:
6630         Fix year range in copyright header.
6631
6632 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6633
6634         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6635         Delete.
6636         <operator==>: Update with for removed field.
6637         <hash>: Likewise.
6638         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6639         <isa_features>: ...this.
6640         <abi_features>: New field.
6641         (riscv_isa_flen): Update comment.
6642         (riscv_abi_xlen): New declaration.
6643         (riscv_abi_flen): New declaration.
6644         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6645         isa_features.
6646         (riscv_abi_xlen): New function.
6647         (riscv_isa_flen): Update to get answer from isa_features.
6648         (riscv_abi_flen): New function.
6649         (riscv_has_fp_abi): Update to get answer from abi_features.
6650         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6651         xlen and flen.
6652         (riscv_call_info) <xlen, flen>: Update comment.
6653         (riscv_call_arg_struct): Remove invalid assertions
6654         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6655         is removed.
6656         (riscv_gdbarch_init): Gather isa features and abi features
6657         separately, ensure both match on the gdbarch when reusing an old
6658         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6659         a target with 64-bit float hardware.
6660
6661 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6662
6663         * source.c (search_command_helper): Stop reverse search
6664         when line 1 has been searched.
6665
6666 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6667
6668         * record-full.c (record_full_base_target::close): Rewrite
6669         record_full_core_buf_list free logic.
6670
6671 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6672
6673         * break-catch-syscall.c (print_one_catch_syscall): xfree
6674         the last text.
6675
6676 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6677
6678         * top.c (print_gdb_version): Update Copyright year in version
6679         message.
6680
6681 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6682
6683         Update copyright year range in all GDB files.
6684
6685 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6686
6687         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6688
6689 For older changes see ChangeLog-2018.
6690 \f
6691 Local Variables:
6692 mode: change-log
6693 left-margin: 8
6694 fill-column: 74
6695 version-control: never
6696 coding: utf-8
6697 End:
6698