gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
   4         * tui/tui-windata.c (tui_display_data_from_line): Remove.
   5         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
   6         tui_display_registers_from_line.
   7         * tui/tui-regs.h (tui_display_registers_from_line): Update.
   8         * tui/tui-regs.c (tui_display_registers_from_line): Remove
   9         "force_display" parameter.
  10
  11 2019-07-17  Tom Tromey  <tom@tromey.com>
  12
  13         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
  14         declare.
  15         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
  16         Rename from tui_first_reg_element_no_inline.
  17         (tui_display_reg_element_at_line)
  18         (tui_display_registers_from_line): Update.
  19         * tui/tui-data.h (struct tui_data_window)
  20         <first_reg_element_no_inline>: New method.
  21
  22 2019-07-17  Tom Tromey  <tom@tromey.com>
  23
  24         * tui/tui-windata.c (tui_display_data_from)
  25         (tui_data_window::do_scroll_vertical): Update.
  26         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
  27         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
  28         Rename from tui_line_from_reg_element_no.
  29         (tui_display_registers_from_line): Update.
  30         * tui/tui-data.h (struct tui_data_window)
  31         <line_from_reg_element_no>: New method.
  32
  33 2019-07-17  Tom Tromey  <tom@tromey.com>
  34
  35         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
  36         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
  37         tui_last_regs_line_no.
  38         (tui_display_reg_element_at_line)
  39         (tui_display_registers_from_line): Update.
  40         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
  41         method.
  42
  43 2019-07-17  Tom Tromey  <tom@tromey.com>
  44
  45         PR tui/24722:
  46         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
  47         (tui_update_breakpoint_info): Add "being_deleted" parameter.
  48         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
  49         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
  50         (tui_update_breakpoint_info): Likewise.
  51         * tui/tui-hooks.c (tui_event_create_breakpoint)
  52         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
  53         Update.
  54
  55 2019-07-17  Tom Tromey  <tom@tromey.com>
  56
  57         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
  58
  59 2019-07-17  Tom Tromey  <tom@tromey.com>
  60
  61         * tui/tui-winsource.c (tui_update_source_window_as_is)
  62         (tui_update_source_windows_with_addr): Update.
  63         * tui/tui-source.h (tui_set_source_content)
  64         (tui_show_symtab_source): Add "win_info" parameter.
  65         * tui/tui-source.c (tui_set_source_content): Add "win_info"
  66         parameter.
  67         (tui_show_symtab_source): Likewise.
  68
  69 2019-07-17  Tom Tromey  <tom@tromey.com>
  70
  71         * tui/tui-wingeneral.c
  72         (tui_check_and_display_highlight_if_needed): Check can_highlight.
  73
  74 2019-07-17  Tom Tromey  <tom@tromey.com>
  75
  76         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
  77         (struct tui_cmd_window) <can_scroll>: New method.
  78         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
  79         method.
  80
  81 2019-07-17  Tom Tromey  <tromey@adacore.com>
  82
  83         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
  84         do_field_signed>: Rename.  Change type of "value".
  85         * ui-out.c (ui_out::field_signed): Rename from field_int.
  86         Change type of "value".
  87         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
  88         type of "value".
  89         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
  90         do_field_int.  Change type of "value".
  91         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
  92         do_field_int.  Change type of "value".
  93         * tracepoint.c (trace_status_mi, tfind_1)
  94         (print_one_static_tracepoint_marker): Update.
  95         * thread.c (print_thread_info_1, print_selected_thread_frame):
  96         Update.
  97         * stack.c (print_frame, print_frame_info): Update.
  98         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
  99         Update.
 100         * source.c (print_source_lines_base): Update.
 101         * skip.c (info_skip_command): Update.
 102         * record-btrace.c (btrace_ui_out_decode_error)
 103         (btrace_call_history_src_line): Update.
 104         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 105         Update.
 106         * progspace.c (print_program_space): Update.
 107         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 108         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 109         do_field_int.  Change type of "value".
 110         * mi/mi-out.c (mi_ui_out::do_table_begin)
 111         (mi_ui_out::do_table_header): Update.
 112         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 113         type of "value".
 114         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 115         (mi_cmd_data_list_changed_registers, output_register)
 116         (mi_cmd_data_read_memory, mi_load_progress)
 117         (mi_cmd_trace_frame_collected): Update.
 118         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 119         Update.
 120         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 121         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 122         (mi_cmd_var_list_children, varobj_update_one): Update.
 123         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 124         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 125         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 126         * inferior.c (print_inferior): Update.
 127         * gdb_bfd.c (print_one_bfd): Update.
 128         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 129         Update.
 130         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 131         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 132         do_field_int.  Change type of "value".
 133         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 134         do_field_int.  Change type of "value".
 135         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 136         (print_one_breakpoint_location, print_it_catch_fork)
 137         (print_one_catch_fork, print_it_catch_vfork)
 138         (print_one_catch_vfork, print_it_catch_solib)
 139         (print_it_catch_exec, print_it_ranged_breakpoint)
 140         (print_mention_watchpoint, print_mention_masked_watchpoint)
 141         (bkpt_print_it, update_static_tracepoint): Update.
 142         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 143         * break-catch-syscall.c (print_it_catch_syscall): Update.
 144         * ada-tasks.c (print_ada_task_info): Update.
 145         * ada-lang.c (print_it_exception, print_mention_exception):
 146         Update.
 147
 148 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 149
 150         PR breakpoints/24541
 151         * gdbarch.c: Regenerate.
 152         * gdbarch.h: Regenerate.
 153         * gdbarch.sh: Adjust return type and parameter types for
 154         'stap_adjust_register'.
 155         (i386_stap_adjust_register): Adjust signature and return new
 156         register name.
 157         * stap-probe.c (stap_parse_register_operand): Adjust use of
 158         'gdbarch_stap_adjust_register'.
 159
 160 2019-07-17  Tom Tromey  <tromey@adacore.com>
 161
 162         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 163         declare VEC.
 164         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 165         std::vector.
 166         (struct s390_process_info): Add initializers.
 167         (s390_add_process): Use new.
 168         (s390_linux_nat_target::low_forget_process): Use delete.
 169         (s390_linux_nat_target::low_new_fork)
 170         (s390_linux_nat_target::stopped_by_watchpoint)
 171         (s390_linux_nat_target::low_prepare_to_resume)
 172         (s390_linux_nat_target::insert_watchpoint)
 173         (s390_linux_nat_target::insert_hw_breakpoint)
 174         (s390_linux_nat_target::remove_watchpoint)
 175         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 176
 177 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 178
 179         * aarch64-fbsd-nat.c: Include regcache.h.
 180         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 181         argument.
 182         (aarch64_fbsd_nat_target::fetch_registers)
 183         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 184         variable.
 185         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 186
 187 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 188
 189         * fbsd-nat.c: Include gdbarch.h.
 190
 191 2019-07-15  Tom Tromey  <tromey@adacore.com>
 192
 193         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 194
 195 2019-07-15  Tom Tromey  <tromey@adacore.com>
 196
 197         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 198         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 199         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 200         * cli-out.c (cli_ui_out::do_field_int): New method.
 201         * ui-out.c (ui_out::field_unsigned): New method.
 202         * symfile.c (generic_load): Use field_unsigned.
 203         (print_transfer_performance): Likewise.
 204         * record-btrace.c (ui_out_field_uint): Remove.
 205         (btrace_call_history_insn_range, btrace_call_history): Use
 206         field_unsigned.
 207         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 208         field_unsigned.
 209         * ui-out.h (class ui_out) <field_unsigned>: New method.
 210         <do_field_unsigned>: Likewise.
 211
 212 2019-07-15  Tom Tromey  <tromey@adacore.com>
 213
 214         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 215         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 216         * target.c (flash_erase_command): Use field_string.
 217         * infrun.c (print_signal_received_reason): Use field_string.
 218         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 219         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 220         field_string.
 221         * ada-tasks.c (print_ada_task_info): Use field_string.
 222
 223 2019-07-15  Tom Tromey  <tromey@adacore.com>
 224
 225         * target.c (flash_erase_command): Use field_core_addr.
 226         * symfile.c (generic_load): Use field_core_addr.
 227         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 228         Use field_core_addr.
 229         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 230         field_core_addr.
 231
 232 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 233
 234         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 235         value if its desired type is smaller than a CORE_ADDR and signed.
 236
 237 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 238
 239         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 240         of changes to field names, and use new is_reference field to
 241         decide if a property is a reference or not.
 242         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 243         field.
 244         (struct dwarf2_property_baton): Update header comment, rename
 245         'referenced_type' to 'property_type' and update comments.
 246         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 247         default property type, store in property baton, update to take
 248         accound of renamed field.
 249         (read_func_scope): Update call to attr_to_dynamic_prop.
 250         (read_array_type): Likewise.
 251         (dwarf2_per_cu_addr_sized_int_type): New function.
 252         (read_subrange_index_type): Move type finding code to
 253         dwarf2_per_cu_addr_sized_int_type.
 254         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 255         (dwarf2_per_cu_addr_type): New function.
 256         (set_die_type): Update calls to attr_to_dynamic_prop.
 257
 258 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 259
 260         * dwarf2read.c (read_subrange_index_type): New function.
 261         (read_subrange_type): Move code into new function and call it.
 262         * gdbtypes.c (create_range_type): Add some asserts.
 263
 264 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 265
 266         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 267         update return statements.
 268         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 269         declaration, and update comment to match.
 270         * gdbtypes.c (resolve_dynamic_array): Update call to
 271         dwarf2_evaluate_property to match new return type.
 272
 273 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 274
 275         * valarith.c (value_subscripted_rvalue): Change lowerbound
 276         parameter type from int to LONGEST.
 277         * value.h (value_subscripted_rvalue): Likewise in declaration.
 278
 279 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 280
 281         * cli/cli-utils.c (info_print_command_completer): New function.
 282         * cli/cli-utils.h: Add 'completer.h' include, and forward
 283         declaration for 'struct cmd_list_element'.
 284         (info_print_command_completer): Declare.
 285         * stack.c (_initialize_stack): Add completer for 'info locals' and
 286         'info args'.
 287         * symtab.c (_initialize_symtab): Add completer for 'info
 288         variables' and 'info functions'.
 289         * NEWS: Mention completion for additional info commands.
 290
 291 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 292
 293         * cli/cli-utils.c (extract_info_print_args): Delete.
 294         (extract_arg_maybe_quoted): Delete.
 295         (info_print_options_defs): New variable.
 296         (make_info_print_options_def_group): New function.
 297         (extract_info_print_options): Define new function.
 298         * cli/cli-utils.h (extract_info_print_args): Delete.
 299         (struct info_print_options): New structure.
 300         (extract_info_print_options): Declare new function.
 301         * stack.c (info_locals_command): Update to use new
 302         extract_info_print_options, also add a header comment.
 303         (info_args_command): Likewise.
 304         * symtab.c (info_variables_command): Likewise.
 305         (info_functions_command): Likewise.
 306
 307 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 308
 309         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 310         to extract string arguments.
 311         * common/common-utils.c (extract_string_maybe_quoted): New function.
 312         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 313
 314 2019-07-11  Tom Tromey  <tromey@adacore.com>
 315
 316         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 317         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 318         * top.h (gdbinit): Don't declare.
 319         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 320         into...
 321         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 322         * top.c (gdb_init): Don't call init_cli_cmds.
 323         (gdbinit): Remove.
 324         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 325
 326 2019-07-11  Tom Tromey  <tromey@adacore.com>
 327
 328         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 329         after it has been moved.
 330
 331 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 332
 333         * valops.c (value_must_coerce_to_target): Change return type to
 334         bool.
 335         * value.h (value_must_coerce_to_target): Likewise.
 336
 337 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 338
 339         * breakpoint.c (is_hardware_watchpoint): Remove
 340         forward-declaration.
 341         (is_masked_watchpoint): Change return type to bool.
 342         (is_tracepoint): Likewise.
 343         (is_breakpoint): Likewise.
 344         (is_hardware_watchpoint): Likewise.
 345         (is_watchpoint): Likewise.
 346         (is_no_memory_software_watchpoint): Likewise.
 347         (is_catchpoint): Likewise.
 348         (breakpoint_1): Make FILTER parameter's return type bool.
 349         is_masked_watchpoint): Change return type to bool.
 350         (save_breakpoints): Make FILTER parameter's return type bool.
 351         * breakpoint.h (is_breakpoint): Change return type to bool.
 352         (is_watchpoint): Likewise.
 353         (is_catchpoint): Likewise.
 354         (is_tracepoint): Likewise.
 355
 356 2019-07-10  Tom Tromey  <tom@tromey.com>
 357
 358         * defs.h: Don't include gdbarch.h.
 359         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 360         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 361         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 362         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 363         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 364         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 365         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 366         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 367         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 368         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 369         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 370         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 371         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 372         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 373         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 374         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 375         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 376         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 377         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 378         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 379         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 380         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 381         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 382         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 383         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 384         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 385         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 386
 387 2019-07-10  Tom Tromey  <tromey@adacore.com>
 388
 389         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 390         * breakpoint.c (init_ada_exception_breakpoint): Register as
 391         bp_catchpoint.
 392         (print_one_breakpoint_location, print_one_breakpoint): Use
 393         is_ada_exception_catchpoint.
 394         * ada-lang.c (class ada_catchpoint_location): Pass
 395         bp_loc_software_breakpoint to bp_location constructor.
 396         (is_ada_exception_catchpoint): New function.
 397
 398 2019-07-10  Tom Tromey  <tromey@adacore.com>
 399
 400         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 401         VEC.
 402         (struct arm_exidx_entry): New method operator<.
 403         (struct arm_exidx_data) <section_maps>: Change type.
 404         (arm_exidx_data_free): Remove.
 405         (arm_exidx_data_key): Change type.  Move lower.
 406         (arm_exidx_new_objfile): Update.
 407         (arm_compare_exidx_entries): Remove.
 408         (arm_find_exidx_entry, _initialize_arm_tdep)
 409
 410 2019-07-10  Tom Tromey  <tromey@adacore.com>
 411
 412         * solib-spu.c (ocl_program_data_key): Change type.
 413         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 414         Update.
 415
 416 2019-07-10  Tom Tromey  <tromey@adacore.com>
 417
 418         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 419         (struct solib_aix_inferior_data) <library_list>: Change type.
 420         (solib_aix_inferior_data_handle): Change type.
 421         (get_solib_aix_inferior_data): Update.
 422         (solib_aix_free_library_list): Remove.
 423         (library_list_start_library): Update.
 424         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 425         return type.
 426         (solib_aix_get_library_list)
 427         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 428         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 429
 430 2019-07-10  Tom Tromey  <tromey@adacore.com>
 431
 432         * solib-dsbt.c (struct dsbt_info): Add initializers.
 433         (solib_dsbt_pspace_data): Change type.
 434         (dsbt_pspace_data_cleanup): Remove.
 435         (get_dsbt_info, _initialize_dsbt_solib): Update.
 436
 437 2019-07-10  Tom Tromey  <tromey@adacore.com>
 438
 439         * spu-tdep.c (spu_overlay_data): Change type.
 440         (spu_get_overlay_table, spu_overlay_new_objfile)
 441         (_initialize_spu_tdep): Update.
 442
 443 2019-07-10  Tom Tromey  <tromey@adacore.com>
 444
 445         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 446         destructor.
 447         (dbx_objfile_data_key): Change type and declare later.
 448         (DBX_SYMFILE_INFO): Rewrite.
 449         * dbxread.c (dbx_objfile_data_key): Change type.
 450         (dbx_symfile_init): Update.
 451         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 452         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 453         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 454
 455 2019-07-10  Tom Tromey  <tromey@adacore.com>
 456
 457         * jit.c (jit_program_space_key): Change type.  Move lower.
 458         (get_jit_program_space_data): Update.
 459         (jit_program_space_data_cleanup): Remove.
 460         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 461         Update.
 462         (struct jit_program_space_data): Add initializers.
 463
 464 2019-07-10  Tom Tromey  <tromey@adacore.com>
 465
 466         * solib-darwin.c (struct darwin_info): Add initializers.
 467         (solib_darwin_pspace_data): Change type.
 468         (darwin_pspace_data_cleanup): Remove.
 469         (get_darwin_info, _initialize_darwin_solib): Update.
 470
 471 2019-07-10  Tom Tromey  <tromey@adacore.com>
 472
 473         * remote-sim.c (struct sim_inferior_data): Add initializers,
 474         constructor, and destructor.
 475         (sim_inferior_data_key): Change type.  Move lower.
 476         (check_for_duplicate_sim_descriptor): Update.
 477         (get_sim_inferior_data): Use new.  Update.
 478         (~sim_inferior_data_cleanup): Rename from
 479         sim_inferior_data_cleanup.  Simplify.
 480         (gdbsim_close_inferior, simulator_command)
 481         (sim_command_completer, _initialize_remote_sim): Update.
 482         (next_pid, INITIAL_PID): Move earlier.
 483
 484 2019-07-10  Tom Tromey  <tromey@adacore.com>
 485
 486         * python/python-internal.h (create_thread_object): Return
 487         gdbpy_ref.
 488         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 489         * python/py-inferior.c (struct threadlist_entry): Add
 490         constructor.
 491         <thread_obj>: Now a gdbpy_ref.
 492         (thread_to_thread_object): Update.
 493         (add_thread_object): Use new.
 494         (delete_thread_object): Use delete.
 495         (infpy_threads): Update.
 496         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 497         GIL.
 498
 499 2019-07-10  Tom Tromey  <tromey@adacore.com>
 500
 501         * valops.c (value_cast): Specialize error message for Ada.
 502
 503 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 504
 505         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 506
 507 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 508
 509         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 510         bpstat_should_step): Return bool, adjust comments.
 511         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 512         bpstat_should_step): Likewise.
 513
 514 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 515
 516         * features/Makefile: Use feature target descriptions for Arm.
 517         * features/arm/arm-core.c: Generate new file.
 518         * features/arm/arm-fpa.c: Likewise.
 519         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 520         * features/arm/arm-m-profile.c: Likewise.
 521         * features/arm/arm-vfpv2.c: Likewise.
 522         * features/arm/arm-vfpv3.c: Likewise.
 523         * features/arm/xscale-iwmmxt.c: Likewise.
 524         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 525
 526 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 527
 528         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 529         ptrace earlier.
 530
 531 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 532
 533         * features/aarch64-pauth.c: Regenerate.
 534
 535 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 536
 537         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 538         bool.
 539         (bpstat_what): Use false instead of 0.
 540
 541 2019-07-09  Pedro Alves  <palves@redhat.com>
 542
 543         * break-catch-throw.c (is_exception_catchpoint): New.
 544         * breakpoint.c (print_one_breakpoint_location): New parameter
 545         'raw_loc'.  Handle it.  Use
 546         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 547         looking at the breakpoint's type.
 548         (print_one_breakpoint): If handling "maint info breakpoints", also
 549         print locations of exception catchpoints.
 550         * breakpoint.h (is_exception_catchpoint): Declare.
 551
 552 2019-07-09  Pedro Alves  <palves@redhat.com>
 553
 554         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 555         "addr" field.
 556         (allocate_location_exception_catchpoint): New.
 557         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 558         (initialize_throw_catchpoint_ops): Install
 559         allocate_location_exception_catchpoint as allocate_location
 560         method.
 561         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 562         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 563         bp_loc_other.
 564         (breakpoint_address_is_meaningful): Delete.
 565         (bl_address_is_meaningful): New.
 566         (breakpoint_locations_match): Adjust comment.
 567         (bp_location_from_bp_type): New, factored out of...
 568         (bp_location::bp_location(breakpoint *)): ... this.
 569         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 570         factored out of...
 571         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 572         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 573         breakpoint_address_is_meaningful.
 574         (bp_locations_compare): Adjust comment.
 575         (update_global_location_list): Use bl_address_is_meaningful
 576         instead of breakpoint_address_is_meaningful.
 577         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 578         explicit.
 579         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 580         * python/py-breakpoint.c (bppy_get_location): No longer check
 581         whether location is null.
 582
 583 2019-07-09  Pedro Alves  <palves@redhat.com>
 584
 585         PR c++/15468
 586         * breakpoint.c (print_one_breakpoint_location): Remove
 587         single-location assert.
 588
 589 2019-07-09  Tom Tromey  <tom@tromey.com>
 590
 591         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 592         * configure: Rebuild.
 593         * configure.ac: Change common to gdbsupport.
 594         * gdbsupport: Rename from common.
 595         * acinclude.m4: Change common to gdbsupport.
 596         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 597         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 598         gdbsupport.
 599         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 600         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 601         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 602         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 603         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 604         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 605         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 606         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 607         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 608         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 609         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 610         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 611         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 612         coff-pe-read.c, command.h, compile/compile-c-support.c,
 613         compile/compile-c.h, compile/compile-cplus-symbols.c,
 614         compile/compile-cplus-types.c, compile/compile-cplus.h,
 615         compile/compile-loc2c.c, compile/compile.c, completer.c,
 616         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 617         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 618         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 619         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 620         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 621         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 622         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 623         features/aarch64-core.c, features/aarch64-fpu.c,
 624         features/aarch64-pauth.c, features/aarch64-sve.c,
 625         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 626         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 627         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 628         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 629         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 630         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 631         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 632         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 633         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 634         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 635         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 636         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 637         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 638         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 639         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 640         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 641         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 642         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 643         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 644         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 645         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 646         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 647         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 648         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 649         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 650         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 651         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 652         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 653         minsyms.c, mips-linux-tdep.c, namespace.h,
 654         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 655         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 656         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 657         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 658         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 659         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 660         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 661         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 662         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 663         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 664         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 665         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 666         procfs.c, producer.c, progspace.h, psymtab.h,
 667         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 668         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 669         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 670         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 671         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 672         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 673         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 674         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 675         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 676         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 677         target-memory.c, target.c, target.h, target/waitstatus.c,
 678         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 679         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 680         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 681         unittests/array-view-selftests.c,
 682         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 683         unittests/common-utils-selftests.c,
 684         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 685         unittests/format_pieces-selftests.c,
 686         unittests/function-view-selftests.c,
 687         unittests/lookup_name_info-selftests.c,
 688         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 689         unittests/mkdir-recursive-selftests.c,
 690         unittests/observable-selftests.c,
 691         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 692         unittests/parse-connection-spec-selftests.c,
 693         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 694         unittests/scoped_fd-selftests.c,
 695         unittests/scoped_mmap-selftests.c,
 696         unittests/scoped_restore-selftests.c,
 697         unittests/string_view-selftests.c, unittests/style-selftests.c,
 698         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 699         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 700         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 701         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 702         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 703         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 704
 705 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 706
 707         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 708         bool value.
 709         (decode_digits_ordinary): Set explicit_line field in sal.
 710         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 711         symtab_and_line that was set on an explicit line number in
 712         assembler code.  Do always update the recorded symtab and line if
 713         we do skip the prologue.
 714
 715 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 716
 717         * breakpoint.c (set_breakpoint_location_function): Remove
 718         explicit_loc parameter.
 719         (momentary_breakpoint_from_master): Update call to
 720         set_breakpoint_location_function.
 721         (add_location_to_breakpoint): Likewise.
 722
 723 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 724
 725         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 726         required features based on default bfd type when no specific bfd
 727         is present.
 728
 729 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 730
 731         * NEWS: Mention that GDB printf and eval commands can now print
 732         C-style and Ada-style convenience var strings without
 733         calling the inferior.
 734         * printcmd.c (printf_c_string): Locally print GDB internal var
 735         instead of transiting via the inferior.
 736         (printf_wide_c_string): Likewise.
 737
 738 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 739
 740         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 741
 742 2019-07-04  Tom Tromey  <tom@tromey.com>
 743
 744         PR tui/24724:
 745         * tui/tui-winsource.c (tui_clear_source_content): Update.
 746         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 747         (tui_update_breakpoint_info): Update.
 748         (tui_set_exec_info_content): Update.
 749         * tui/tui-source.c (tui_set_source_content_nil): Update.
 750         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 751         has_break.
 752         * tui/tui-data.h (enum tui_bp_flag): New.
 753         (tui_bp_flags): New enum flags type.
 754         (struct tui_source_element) <break_mode>: Change type.  Rename
 755         from has_break.
 756         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 757         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 758         constants.
 759         * tui/tui-winsource.h: Fix comment.
 760
 761 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 762
 763         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 764         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 765         (store_fpregs_to_thread)
 766         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 767         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 768         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 769         (IWMMXT_REGS_SIZE): Add define.
 770         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 771         (fetch_vfp_regs, store_vfp_regs)
 772         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 773         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 774
 775 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 776
 777         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 778         defines.
 779         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 780         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 781         (ARM_INT_REGISTER_SIZE): ...to this.
 782         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 783         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 784         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 785         (arm_linux_collect_gregset, supply_nwfpe_register)
 786         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 787         defines.
 788         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 789         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 790         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 791         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 792         (arm_return_in_memory, arm_store_return_value)
 793         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 794         (arm_record_ld_st_multiple): Likewise.
 795         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 796         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 797
 798 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 799
 800         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 801         AARCH64_DISPLACED_MODIFIED_INSNS.
 802         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 803         (aarch64_displaced_step_copy_insn): Likewise.
 804         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 805         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 806         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 807         ARM_DISPLACED_MODIFIED_INSNS.
 808         * arm-tdep.c (arm_gdbarch_init): Likewise.
 809         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 810         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 811         (struct arm_displaced_step_closure): Use
 812         ARM_DISPLACED_MODIFIED_INSNS.
 813
 814 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 815
 816         * features/Makefile: Remove unused xml files.
 817         * features/aarch64.xml: Remove.
 818         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 819         * features/i386/amd64-avx-avx512.xml: Remove.
 820         * features/i386/amd64-avx-linux.xml: Remove.
 821         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 822         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 823         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 824         * features/i386/amd64-avx-mpx.xml: Remove.
 825         * features/i386/amd64-avx.xml: Remove.
 826         * features/i386/amd64-linux.xml: Remove.
 827         * features/i386/amd64-mpx-linux.xml: Remove.
 828         * features/i386/amd64-mpx.xml: Remove.
 829         * features/i386/amd64.xml: Remove.
 830         * features/i386/i386-avx-avx512-linux.xml: Remove.
 831         * features/i386/i386-avx-avx512.xml: Remove.
 832         * features/i386/i386-avx-linux.xml: Remove.
 833         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 834         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 835         * features/i386/i386-avx-mpx-linux.xml: Remove.
 836         * features/i386/i386-avx-mpx.xml: Remove.
 837         * features/i386/i386-avx.xml: Remove.
 838         * features/i386/i386-linux.xml: Remove.
 839         * features/i386/i386-mmx-linux.xml: Remove.
 840         * features/i386/i386-mmx.xml: Remove.
 841         * features/i386/i386-mpx-linux.xml: Remove.
 842         * features/i386/i386-mpx.xml: Remove.
 843         * features/i386/i386.xml: Remove.
 844         * features/i386/x32-avx-avx512-linux.xml: Remove.
 845         * features/i386/x32-avx-linux.xml: Remove.
 846         * features/i386/x32-linux.xml: Remove.
 847
 848 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 849
 850         * regformats/aarch64.dat: Remove.
 851         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 852         * regformats/i386/amd64-avx-linux.dat: Remove.
 853         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 854         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 855         * regformats/i386/amd64-linux.dat: Remove.
 856         * regformats/i386/amd64-mpx-linux.dat: Remove.
 857         * regformats/i386/amd64.dat: Remove.
 858         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 859         * regformats/i386/i386-avx-linux.dat: Remove.
 860         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 861         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 862         * regformats/i386/i386-linux.dat: Remove.
 863         * regformats/i386/i386-mmx-linux.dat: Remove.
 864         * regformats/i386/i386-mpx-linux.dat: Remove.
 865         * regformats/i386/i386.dat: Remove.
 866         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 867         * regformats/i386/x32-avx-linux.dat: Remove.
 868         * regformats/i386/x32-linux.dat: Remove.
 869
 870 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 871
 872         * aarch64-tdep.c: Remove xml self tests.
 873         * amd64-linux-tdep.c: Likewise.
 874         * amd64-tdep.c: Likewise.
 875         * i386-linux-tdep.c: Likewise.
 876         * i386-tdep.c: Likewise.
 877
 878 2019-07-03  Pedro Alves  <palves@redhat.com>
 879
 880         PR cli/24732
 881         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 882         (pipe_cmd_option_defs): New.
 883         (make_pipe_cmd_options_def_group): New.
 884         (pipe_command): Use gdb::option::process_options.
 885         (pipe_command_completer): New function.
 886         (_initialize_cli_cmds): Install completer for "pipe" command.
 887
 888 2019-07-03  Pedro Alves  <palves@redhat.com>
 889
 890         * cli/cli-option.c (union option_value) <string>: New field.
 891         (struct option_def_and_value): Add ctor, move ctor, dtor and
 892         use DISABLE_COPY_AND_ASSIGN.
 893         (option_def_and_value::clear_value): New.
 894         (parse_option, save_option_value_in_ctx, get_val_type_str)
 895         (add_setshow_cmds_for_options): Handle var_string.
 896         * cli-option.h (union option_def::var_address) <string>: New
 897         field.
 898         (struct string_option_def): New.
 899         * maint-test-options.c (struct test_options_opts): Add default
 900         ctor and use DISABLE_COPY_AND_ASSIGN.
 901         <string_opt>: New field.
 902         (test_options_opts::~test_options_opts): New.
 903         (test_options_opts::dump): Also dump "-string".
 904         (test_options_option_defs): Install "string.
 905
 906 2019-07-03  Pedro Alves  <palves@redhat.com>
 907
 908         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 909         option_value with a null enumeration.
 910         (complete_options): Save the option values in the context.
 911         (save_option_value_in_ctx): New, factored out from ...
 912         (process_options): ... here.
 913         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 914         of the function.
 915         * maint-test-options.c (test_options_opts::dump): New, factored
 916         out from ...
 917         (maintenance_test_options_command_mode): ... here.
 918         (maintenance_test_options_command_completion_result): Delete.
 919         (maintenance_test_options_command_completion_text): Update
 920         comment.
 921         (maintenance_show_test_options_completion_result): Change
 922         prototype.  Just print
 923         maintenance_test_options_command_completion_text.
 924         (save_completion_result): New.
 925         (maintenance_test_options_completer_mode): Pass options context to
 926         complete_options, and then save a dump.
 927         (_initialize_maint_test_options): Use add_cmd to install "maint
 928         show test-options-completion-result".
 929
 930 2019-07-03  Pedro Alves  <palves@redhat.com>
 931
 932         * NEWS (New commands): Mention "with" and "maint with".
 933         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 934         (with_command, with_command_completer): New.
 935         (pipe_command): Adjust to new repeat_previous
 936         interface.
 937         (_initialize_cli_cmds): Install the "with" command and its "w"
 938         alias.
 939         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 940         declarations.
 941         * cli/cli-setshow.c (parse_cli_var_uinteger)
 942         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 943         argument strings for all var_types.
 944         (get_setshow_command_value_string): New, factored out from ...
 945         (do_show_command): ... this.
 946         * cli/cli-setshow.h: Include <string>.
 947         (get_setshow_command_value_string): Declare.
 948         * command.h (repeat_previous): Now returns const char *.  Adjust
 949         comment.
 950         * maint.c: Include "cli/cli-cmds.h".
 951         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 952         (_initialize_maint_cmds): Register the "maintenance with" command.
 953         * top.c (repeat_previous): Move bits from pipe_command here:
 954         Return the saved command line, if any; error out if there's no
 955         command to relaunch.
 956
 957 2019-07-03  Pedro Alves  <palves@redhat.com>
 958
 959         * NEWS (New commands): Mention "maint set/show test-settings"
 960         instead of "maint test-settings".
 961         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 962         (maintenance_test_settings_set_list): Rename to ...
 963         (maintenance_set_test_settings_list): ... this.
 964         (maintenance_test_settings_show_list): Rename to  ...
 965         (maintenance_show_test_settings_list): ... this.
 966         (maintenance_test_settings_cmd): Delete.
 967         (maintenance_test_settings_set_cmd): ...
 968         (maintenance_set_test_settings_cmd): ... this.
 969         (maintenance_test_settings_show_cmd): ...
 970         (maintenance_show_test_settings_cmd): ... this.
 971         (maintenance_test_settings_show_value_cmd):
 972         (maintenance_show_test_settings_value_cmd): ... this.
 973         (_initialize_maint_test_settings): No longer install the "maint
 974         test-settings" prefix command.  Rename "maint test-settings set"
 975         to "maint set test-settings", and "maint test-settings show" to
 976         "maint show test-settings".  Adjust all subcommands.
 977
 978 2019-07-03  Pedro Alves  <palves@redhat.com>
 979
 980         * maint-test-settings.c: Fix file's intro comment.  Replace all
 981         references to "test-options" with references to "test-settings",
 982         in comments.
 983
 984 2019-07-03  Pedro Alves  <palves@redhat.com>
 985
 986         * maint-test-settings.c (maintenance_test_settings_xxx)
 987         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 988         New.
 989         (maintenance_test_settings_enums): Use them.
 990         (maintenance_test_settings_enum): Default to
 991         maintenance_test_settings_xxx.
 992         (_initialize_maint_test_settings): Initialize
 993         MAINTENANCE_TEST_SETTINGS_FILENAME.
 994
 995 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 996
 997         * breakpoint.h (remove_breakpoints_inf): Change return type to
 998         void, move function documentation here.
 999         * breakpoint.c (remove_breakpoints_inf): Change return type to
1000         void, move function documentation to header.
1001
1002 2019-07-02  Pedro Alves  <palves@redhat.com>
1003
1004         * NEWS (Completion improvements): Mention "info threads".
1005         * thread.c (struct info_threads_opts, info_threads_option_defs)
1006         (make_info_threads_options_def_group): New.
1007         (info_threads_command): Use gdb::option::process_options.
1008         (info_threads_command_completer): New.
1009         (_initialize_thread): Use gdb::option::build_help to build the
1010         help text for "info threads".
1011
1012 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1013
1014         * defs.h (generic_load): Move from here...
1015         * symfile.h (generic_load): ... to here.  Rename name parameter
1016         to args.
1017         * symfile.c (generic_load): Add comment.
1018
1019 2019-07-01  Tom Tromey  <tromey@adacore.com>
1020
1021         * dwarf2read.c
1022         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1023         declaration of without_params.  Fix formatting.
1024
1025 2019-07-01  Tom Tromey  <tromey@adacore.com>
1026
1027         * ada-exp.y (find_primitive_type): Update.
1028         * ada-lang.h (ada_lookup_symbol): Update.
1029         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1030         parameter.
1031         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1032
1033 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1034
1035         PR breakpoints/24541
1036         * gdbarch.c: Regenerate.
1037         * gdbarch.h: Regenerate.
1038         * gdbarch.sh: Add 'stap_adjust_register'.
1039         * i386-tdep.c: Include '<unordered_set>'.
1040         (i386_stap_adjust_register): New function.
1041         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1042         * stap-probe.c (stap_parse_register_operand): Call
1043         'gdbarch_stap_adjust_register'.
1044
1045 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1046
1047         PR python/24742
1048         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1049         * python/python.c (do_start_initialization): Use 'xmalloc'
1050         instead of 'PyMem_Malloc'.
1051
1052 2019-06-28  Tom Tromey  <tromey@adacore.com>
1053
1054         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1055         for Ada.
1056
1057 2019-06-27  Tom Tromey  <tromey@adacore.com>
1058
1059         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1060         objfile_key.
1061         (arm_find_mapping_symbol, arm_record_special_symbol)
1062         (_initialize_arm_tdep): Update.
1063         (arm_objfile_data_free): Remove.
1064
1065 2019-06-27  Tom Tromey  <tromey@adacore.com>
1066
1067         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1068         to cp_print_static_field.
1069
1070 2019-06-26  Tom Tromey  <tromey@adacore.com>
1071
1072         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1073         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1074         declare.
1075
1076 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1077
1078         * features/aarch64-core.c (create_feature_aarch64_core):
1079         Regenerate.
1080         * features/aarch64-core.xml: Add cpsr flags.
1081
1082 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1083
1084         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1085         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1086
1087 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1088
1089         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1090         field.
1091         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1092         use.
1093         (arm_record_special_symbol): Don't insert new symbol in sorted
1094         position, push it at the end.
1095
1096 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1097
1098         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1099         (arm_mapping_symbol_s): Remove.
1100         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1101         (arm_mapping_symbol_vec): New typedef.
1102         (struct arm_per_objfile): Add constructor.
1103         <section_maps>: Change type to
1104         std::unique_ptr<arm_mapping_symbol_vec[]>.
1105         (arm_compare_mapping_symbols): Remove.
1106         (arm_find_mapping_symbol): Adjust to section_maps type change.
1107         (arm_objfile_data_free): Call delete on arm_per_objfile.
1108         (arm_record_special_symbol): Adjust to section_maps type change.
1109         Allocate arm_per_objfile with new.
1110
1111 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1112
1113         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1114         with the command prefix.
1115
1116 2019-06-25  Tom Tromey  <tom@tromey.com>
1117
1118         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1119         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1120
1121 2019-06-25  Tom Tromey  <tom@tromey.com>
1122
1123         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1124         type.
1125         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1126         protected.
1127
1128 2019-06-25  Tom Tromey  <tom@tromey.com>
1129
1130         * tui/tui-winsource.c
1131         (tui_source_window_base::set_is_exec_point_at): Add check against
1132         LOA_ADDRESS.
1133
1134 2019-06-25  Tom Tromey  <tom@tromey.com>
1135
1136         * tui/tui-source.c (tui_set_source_content): Don't check before
1137         xfree.
1138         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1139
1140 2019-06-25  Tom Tromey  <tom@tromey.com>
1141
1142         * tui/tui-winsource.h (tui_update_source_window_as_is)
1143         (tui_alloc_source_buffer, tui_line_is_displayed)
1144         (tui_addr_is_displayed): Change type of win_info.
1145         * tui/tui-winsource.c (tui_update_source_window_as_is)
1146         (tui_clear_source_content, tui_show_source_line)
1147         (tui_show_source_content, tui_source_window_base::refill)
1148         (tui_source_window_base::set_is_exec_point_at)
1149         (tui_source_window_base::set_is_exec_point_at)
1150         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1151         (tui_alloc_source_buffer, tui_line_is_displayed)
1152         (tui_addr_is_displayed): Change type of win_info.  Update.
1153         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1154         (tui_source_window_base::do_make_visible_with_new_height):
1155         Update.
1156         * tui/tui-source.c (tui_set_source_content)
1157         (tui_set_source_content_nil)
1158         (tui_source_window::do_scroll_vertical): Update.
1159         * tui/tui-layout.c (show_layout): Update.
1160         * tui/tui-disasm.c (tui_set_disassem_content)
1161         (tui_disasm_window::do_scroll_vertical): Update.
1162         * tui/tui-data.h (tui_win_content): Remove.
1163         (struct tui_gen_win_info) <content, content_size>: Remove.
1164         (struct tui_source_element): Add initializers and destructor.
1165         (union tui_which_element, struct tui_win_element): Remove.
1166         (struct tui_source_window_base) <content>: New field.
1167         (struct tui_data_window): Remove destructor.
1168         (tui_alloc_content, tui_free_win_content)
1169         (tui_free_all_source_wins_content): Don't declare.
1170         * tui/tui-data.c (tui_initialize_static_data): Update.
1171         (init_content_element, tui_alloc_content): Remove.
1172         (~tui_gen_win_info): Update.
1173         (~tui_data_window, tui_free_all_source_wins_content)
1174         (tui_free_win_content, free_content, free_content_elements):
1175         Remove.
1176
1177 2019-06-25  Tom Tromey  <tom@tromey.com>
1178
1179         * tui/tui-winsource.h (tui_clear_source_content)
1180         (tui_erase_source_content, tui_show_source_content): Change type
1181         of win_info.
1182         * tui/tui-winsource.c (tui_clear_source_content)
1183         (tui_erase_source_content, tui_show_source_content): Change type
1184         of win_info.
1185         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1186         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1187         win_info.
1188         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1189         win_info.
1190         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1191
1192 2019-06-25  Tom Tromey  <tom@tromey.com>
1193
1194         * tui/tui-winsource.c (tui_clear_source_content)
1195         (tui_source_window_base::set_is_exec_point_at): Update.
1196         * tui/tui-source.c (tui_set_source_content_nil): Update.
1197         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1198         a bool.
1199         * tui/tui-data.c (init_content_element): Update.
1200
1201 2019-06-25  Tom Tromey  <tom@tromey.com>
1202
1203         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1204         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1205         * tui/tui-layout.c (init_and_make_win): Update.
1206         * tui/tui.h (enum tui_win_type): Update.
1207         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1208         tui_win_is_auxillary.
1209         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1210         tui_win_is_auxillary.
1211
1212 2019-06-25  Tom Tromey  <tom@tromey.com>
1213
1214         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1215         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1216         (tui_delete_data_content_windows, tui_display_all_data)
1217         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1218         Update.
1219         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1220         * tui/tui-regs.c (tui_last_regs_line_no)
1221         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1222         (tui_show_registers): Update.
1223         (tui_show_register_group): Return void.  Update.
1224         (tui_display_registers_from, tui_display_reg_element_at_line)
1225         (tui_display_registers_from_line, tui_check_register_values):
1226         Update.
1227         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1228         member.
1229         (struct tui_data_window) <regs_content>: Now a std::vector.
1230         <regs_content_count>: Remove.
1231         (tui_add_content_elements, tui_free_data_content): Don't declare.
1232         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1233         (init_content_element): Remove DATA_WIN case.  Add assert.
1234         (tui_add_content_elements): Remove.
1235         (tui_data_window): Update.
1236         (tui_free_data_content): Remove.
1237         (free_content_elements): Remove DATA_WIN case.
1238
1239 2019-06-25  Tom Tromey  <tom@tromey.com>
1240
1241         * tui/tui-data.c (tui_data_item_window): Update.
1242         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1243         * tui/tui-windata.c (tui_display_all_data)
1244         (tui_display_data_from_line): Update.
1245         (tui_check_data_values): Remove.
1246         * tui/tui-regs.c (tui_show_register_group)
1247         (tui_display_reg_element_at_line): Update.
1248         * tui/tui-hooks.c (tui_register_changed)
1249         (tui_refresh_frame_and_register_information): Call
1250         tui_check_register_values.
1251         * tui/tui-data.h (struct tui_data_window) <data_content,
1252         data_content_count, data_type>: Remove.
1253         (enum tui_data_type): Remove.
1254
1255         * tui/tui-data.c (tui_data_window::clear_detail)
1256         (~tui_data_window): Update.
1257
1258 2019-06-25  Tom Tromey  <tom@tromey.com>
1259
1260         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1261         declare.
1262         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1263         Rename from tui_first_data_item_displayed.  Update.
1264         (tui_data_window::refresh_all)
1265         (tui_data_window::do_scroll_vertical): Update.
1266         * tui/tui-data.h (struct tui_data_window)
1267         <first_data_item_displayed>: Declare new method.
1268
1269 2019-06-25  Tom Tromey  <tom@tromey.com>
1270
1271         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1272         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1273         contents...
1274         (tui_initialize_static_data): ...here.
1275
1276 2019-06-25  Tom Tromey  <tom@tromey.com>
1277
1278         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1279         (tui_display_registers_from, tui_check_register_values): Update.
1280         (tui_display_register): Remove win_info parameter; update.
1281         (tui_get_register): Change type of parameters.
1282         * tui/tui-data.h (struct tui_data_element): Remove.
1283         (union tui_which_element) <data>: Remove.
1284         <data_window>: Change type.
1285         (struct tui_data_item_window): New.
1286         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1287         case.  Add assert.
1288         (~tui_data_item_window): New destructor.
1289         (free_content_elements): Remove DATA_ITEM_WIN case.
1290
1291 2019-06-25  Tom Tromey  <tom@tromey.com>
1292
1293         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1294         Remove.
1295
1296 2019-06-25  Tom Tromey  <tom@tromey.com>
1297
1298         * tui/tui-data.h (struct tui_command_element): Remove.
1299         (union tui_which_element) <command>: Remove.
1300         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1301         assert.
1302         (free_content_elements): Remove CMD_WIN case.
1303
1304 2019-06-25  Tom Tromey  <tom@tromey.com>
1305
1306         * tui/tui-layout.c (tui_set_layout): Update.
1307         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1308         * tui/tui-data.c (layout_def): Update.
1309
1310 2019-06-25  Tom Tromey  <tom@tromey.com>
1311
1312         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1313         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1314         (tui_source_window_base::set_new_height): Update.
1315         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1316         Update.
1317         (tui_set_locator_fullname, tui_set_locator_info)
1318         (tui_show_frame_info): Update.
1319         * tui/tui-source.c (tui_set_source_content)
1320         (tui_source_is_displayed): Update.
1321         * tui/tui-layout.c (show_source_disasm_command, show_data)
1322         (show_source_or_disasm_and_command): Update.
1323         * tui/tui-disasm.c (tui_set_disassem_content)
1324         (tui_get_begin_asm_address): Update.
1325         * tui/tui-data.h (struct tui_locator_element): Remove.
1326         (union tui_which_element) <locator>: Remove.
1327         (struct tui_locator_window): New.
1328         (tui_locator_win_info_ptr): Change return type.
1329         * tui/tui-data.c (_locator): Change type.
1330         (tui_locator_win_info_ptr): Change return type.
1331         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1332         (tui_alloc_content): Add assert.
1333
1334 2019-06-25  Tom Tromey  <tom@tromey.com>
1335
1336         * tui/tui-winsource.c
1337         (tui_exec_info_window::maybe_allocate_content): New method.
1338         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1339         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1340         (make_source_or_disasm_window): Add cast.
1341         * tui/tui-data.h (union tui_which_element) <simple_string>:
1342         Remove.
1343         (struct tui_source_info): New.
1344         (struct tui_source_window_base) <execution_info>: Change type.
1345         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1346         case, and add assert.
1347         (tui_alloc_content): Add assert.
1348
1349 2019-06-25  Tom Tromey  <tom@tromey.com>
1350
1351         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1352         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1353         * tui/tui-data.c (tui_alloc_win_info): Remove.
1354
1355 2019-06-25  Tom Tromey  <tom@tromey.com>
1356
1357         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1358         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1359         can_highlight.
1360
1361 2019-06-25  Tom Tromey  <tom@tromey.com>
1362
1363         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1364         make_visible_with_new_height method.
1365         (tui_win_info::make_visible_with_new_height): New method.
1366         (tui_source_window_base::do_make_visible_with_new_height)
1367         (tui_data_window::do_make_visible_with_new_height)
1368         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1369         (make_visible_with_new_height): Remove.
1370         (tui_resize_all, tui_adjust_win_heights): Use
1371         make_visible_with_new_height method.
1372         * tui/tui-data.h (struct tui_win_info)
1373         <do_make_visible_with_new_height, make_visible_with_new_height>:
1374         New methods.
1375         (struct tui_source_window_base, struct tui_data_window)
1376         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1377         methods.
1378
1379 2019-06-25  Tom Tromey  <tom@tromey.com>
1380
1381         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1382         method.
1383         (update_tab_width): Call update_tab_width method.
1384         * tui/tui-data.h (struct tui_win_info)
1385         (struct tui_source_window_base) <update_tab_width>: New methods.
1386
1387 2019-06-25  Tom Tromey  <tom@tromey.com>
1388
1389         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1390         parameter.
1391         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1392         parameter.
1393         (tui_gen_win_info::make_visible): Update.
1394         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1395         parameter.
1396         * tui/tui-data.h (enum tui_box): New enum.
1397         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1398
1399 2019-06-25  Tom Tromey  <tom@tromey.com>
1400
1401         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1402         init_and_make_win for EXEC_INFO_WIN.
1403         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1404         longer inline.
1405         (struct tui_win_info) <~tui_win_info>: Inline.
1406         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1407         Don't declare.
1408         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1409         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1410         Remove.
1411         (tui_initialize_static_data): Update.
1412         (~tui_gen_win_info): Handle more cleanup here.
1413         (~tui_source_window_base): Delete "execution_info".
1414         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1415
1416 2019-06-25  Tom Tromey  <tom@tromey.com>
1417
1418         * tui/tui-layout.c (make_command_window): Don't set
1419         can_highlight.
1420         (show_source_disasm_command): Call the reset method.
1421         (show_data): Don't set can_highlight.  Call the reset method.
1422         (tui_gen_win_info::reset): Rename from init_gen_win_info
1423         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1424         (show_source_or_disasm_and_command): Call the reset method.
1425         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1426         (struct tui_cmd_window): Set can_highlight.
1427
1428 2019-06-25  Tom Tromey  <tom@tromey.com>
1429
1430         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1431         from make_visible.
1432         (tui_make_visible, tui_make_invisible): Rewrite.
1433         (tui_win_info::make_visible): Remove.
1434         (tui_source_window_base::make_visible): Update.
1435         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1436         method.  Moved from...
1437         (struct tui_win_info) <make_visible>: ...here.
1438
1439 2019-06-25  Tom Tromey  <tom@tromey.com>
1440
1441         * tui/tui-winsource.c
1442         (tui_source_window_base::do_scroll_horizontal): Remove direction
1443         parameter.
1444         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1445         direction parameter.
1446         * tui/tui-win.c (tui_win_info::forward_scroll)
1447         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1448         (tui_win_info::right_scroll): Update.
1449         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1450         direction parameter.
1451         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1452         direction parameter.
1453         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1454         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1455         Remove direction parameter.
1456         (struct tui_source_window_base, struct tui_source_window)
1457         (struct tui_disasm_window, struct tui_data_window)
1458         (struct tui_cmd_window): Update.
1459
1460 2019-06-25  Tom Tromey  <tom@tromey.com>
1461
1462         * tui/tui-winsource.h (tui_set_exec_info_content)
1463         (tui_show_exec_info_content, tui_erase_exec_info_content)
1464         (tui_clear_exec_info_content, tui_update_exec_info): Change
1465         argument to tui_source_window_base.
1466         * tui/tui-winsource.c (tui_set_exec_info_content)
1467         (tui_show_exec_info_content, tui_erase_exec_info_content)
1468         (tui_clear_exec_info_content, tui_update_exec_info): Change
1469         argument to tui_source_window_base.
1470
1471 2019-06-25  Tom Tromey  <tom@tromey.com>
1472
1473         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1474         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1475
1476 2019-06-25  Tom Tromey  <tom@tromey.com>
1477
1478         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1479         check.
1480
1481 2019-06-25  Tom Tromey  <tom@tromey.com>
1482
1483         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1484         type to void.
1485         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1486         type to void.
1487         * tui/tui-source.c (tui_set_source_content): Update.
1488         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1489
1490 2019-06-25  Tom Tromey  <tom@tromey.com>
1491
1492         * tui/tui-win.c (window_name_completer, tui_set_focus)
1493         (tui_all_windows_info): Use name method.
1494         * tui/tui-data.h (struct tui_gen_win_info)
1495         (struct tui_source_window, struct tui_disasm_window)
1496         (struct tui_data_window, struct tui_cmd_window) <name>: New
1497         method.
1498         (tui_win_name): Don't declare.
1499         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1500         (tui_win_name): Remove.
1501
1502 2019-06-25  Tom Tromey  <tom@tromey.com>
1503
1504         * tui/tui-winsource.h (tui_update_source_window)
1505         (tui_update_source_window_as_is): Change parameter type.
1506         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1507         to be a tui_source_window_base.
1508         (tui_update_source_window_as_is): Likewise.
1509         * tui/tui-win.c (make_visible_with_new_height): Update.
1510
1511 2019-06-25  Tom Tromey  <tom@tromey.com>
1512
1513         * tui/tui-winsource.c (tui_erase_source_content)
1514         (tui_show_source_content, tui_show_exec_info_content)
1515         (tui_erase_exec_info_content): Use refresh_window method.
1516         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1517         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1518         from tui_refresh_win.
1519         (tui_data_window::refresh_window): New method.
1520         (tui_win_info::refresh, tui_source_window_base::refresh)
1521         (tui_refresh_all): Use refresh_window method.
1522         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1523         method.
1524         * tui/tui-regs.c (tui_display_register): Call refresh_window
1525         method.
1526         * tui/tui-layout.c (show_source_disasm_command)
1527         (show_source_or_disasm_and_command): Call refresh_window method.
1528         * tui/tui-data.h (struct tui_gen_win_info)
1529         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1530         New method.
1531
1532 2019-06-25  Tom Tromey  <tom@tromey.com>
1533
1534         * tui/tui.c (tui_rl_other_window, tui_enable)
1535         (tui_is_window_visible, tui_get_command_dimension): Update.
1536         * tui/tui-winsource.c (tui_update_source_window_as_is)
1537         (tui_clear_source_content, tui_erase_source_content)
1538         (tui_show_source_line, tui_source_window_base::refill)
1539         (tui_source_window_base::do_scroll_horizontal)
1540         (tui_source_window_base::set_is_exec_point_at)
1541         (tui_update_breakpoint_info, tui_set_exec_info_content)
1542         (tui_alloc_source_buffer, tui_line_is_displayed)
1543         (tui_addr_is_displayed): Update.
1544         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1545         (tui_check_and_display_highlight_if_needed)
1546         (tui_win_info::make_visible, tui_win_info::refresh)
1547         (tui_refresh_all): Update.
1548         * tui/tui-windata.c (tui_first_data_item_displayed)
1549         (tui_delete_data_content_windows, tui_erase_data_content)
1550         (tui_display_all_data, tui_data_window::refresh_all)
1551         (tui_check_data_values): Update.
1552         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1553         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1554         (tui_win_info::backward_scroll, tui_refresh_all_win)
1555         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1556         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1557         (tui_source_window_base::set_new_height)
1558         (tui_data_window::set_new_height)
1559         (make_invisible_and_set_new_height)
1560         (make_visible_with_new_height, new_height_ok)
1561         (parse_scrolling_args): Update.
1562         * tui/tui-stack.c (tui_show_frame_info): Update.
1563         * tui/tui-source.c (tui_set_source_content)
1564         (tui_set_source_content_nil, tui_source_is_displayed)
1565         (tui_source_window::do_scroll_vertical): Update.
1566         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1567         (tui_display_registers_from, tui_display_reg_element_at_line)
1568         (tui_check_register_values, tui_reg_command): Update.
1569         * tui/tui-layout.c (tui_default_win_height)
1570         (show_source_disasm_command, show_data, init_and_make_win)
1571         (show_source_or_disasm_and_command): Update.
1572         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1573         (tui_redisplay_readline, tui_mld_flush)
1574         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1575         (tui_getc): Update.
1576         * tui/tui-disasm.c (tui_set_disassem_content)
1577         (tui_disasm_window::do_scroll_vertical): Update.
1578         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1579         Now virtual.
1580         (struct tui_win_info): Derive from tui_gen_win_info.
1581         <~tui_win_info>: Mark as override.
1582         <generic>: Remove member.
1583         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1584         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1585         (~tui_data_window, ~tui_win_info)
1586         (tui_free_all_source_wins_content): Update.
1587         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1588
1589 2019-06-25  Tom Tromey  <tom@tromey.com>
1590
1591         * tui/tui-layout.c (init_and_make_win): Use new.
1592         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1593         destructor, initializers.
1594         (tui_alloc_generic_win_info): Don't declare.
1595         * tui/tui-data.c (_locator): Add argument to constructor.
1596         (source_win, disasm_win): New globals.
1597         (exec_info): Remove.
1598         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1599         Update.
1600         (tui_alloc_generic_win_info): Remove.
1601         (init_content_element): Use new.
1602         (tui_win_info::tui_win_info): Update.
1603         (free_content_elements) <case DATA_WIN>: Use delete.
1604
1605 2019-06-25  Tom Tromey  <tom@tromey.com>
1606
1607         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1608         * tui/tui-windata.c (tui_first_data_item_displayed)
1609         (tui_delete_data_content_windows): Update.
1610         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1611         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1612         (tui_display_registers_from, tui_check_register_values): Update.
1613         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1614         pointer.
1615         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1616         window.
1617         (tui_free_data_content): Update.
1618         (free_content_elements) <case DATA_WIN>: Free the window.
1619
1620 2019-06-25  Tom Tromey  <tom@tromey.com>
1621
1622         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1623         Update.
1624         * tui/tui-layout.c (make_command_window)
1625         (show_source_disasm_command, show_data, init_and_make_win)
1626         (show_source_or_disasm_and_command): Update.
1627         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1628         method.
1629         <can_highight, is_highlighted>: Now bool.
1630         (tui_set_win_highlight): Don't declare.
1631         * tui/tui-data.c (tui_set_win_highlight): Remove.
1632
1633 2019-06-25  Tom Tromey  <tom@tromey.com>
1634
1635         * tui/tui-wingeneral.c (make_visible): Remove check of window
1636         type.
1637
1638 2019-06-25  Tom Tromey  <tom@tromey.com>
1639
1640         * tui/tui-win.c (tui_win_info::max_height)
1641         (tui_cmd_window::max_height): New methods.
1642         (new_height_ok): Call max_height.
1643         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1644         <max_height>: New method.
1645
1646 2019-06-25  Tom Tromey  <tom@tromey.com>
1647
1648         * tui/tui-win.c (tui_source_window_base::set_new_height)
1649         (tui_data_window::set_new_height): New methods.
1650         (make_invisible_and_set_new_height): Call set_new_height method.
1651         * tui/tui-data.h (struct tui_win_info)
1652         (struct tui_source_window_base, struct tui_data_window)
1653         <set_new_height>: New method.
1654
1655 2019-06-25  Tom Tromey  <tom@tromey.com>
1656
1657         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1658         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1659         tui_refresh_data_win.
1660         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1661         method.
1662         (tui_refresh_all_win): Call the refresh_all method.
1663         (tui_set_focus): Likewise.
1664         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1665         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1666         Likewise.
1667
1668 2019-06-25  Tom Tromey  <tom@tromey.com>
1669
1670         * tui/tui-winsource.h (tui_refill_source_window)
1671         (tui_set_is_exec_point_at): Don't declare.
1672         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1673         (tui_source_window_base::refill): Rename from
1674         tui_refill_source_window.
1675         (tui_source_window_base::do_scroll_horizontal): Update.
1676         (tui_source_window_base::set_is_exec_point_at): Rename from
1677         tui_set_is_exec_point_at.
1678         (tui_update_all_breakpoint_info): Update.
1679         * tui/tui-stack.c (tui_show_frame_info): Update.
1680         * tui/tui-layout.c (show_data): Add cast.
1681         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1682         * tui/tui-data.h (struct tui_source_window_base) <refill,
1683         set_is_exec_point_at>: New methods.
1684         (tui_source_windows, tui_add_to_source_windows): Update types.
1685         (tui_add_to_source_windows): Remove redundant declaration.
1686         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1687         (tui_source_windows): Change return type.
1688         (tui_clear_source_windows_detail): Update.
1689         (tui_add_to_source_windows): Change type of parameter.
1690         (tui_free_all_source_wins_content): Update.
1691
1692 2019-06-25  Tom Tromey  <tom@tromey.com>
1693
1694         * tui/tui-wingeneral.c (tui_win_info::refresh)
1695         (tui_source_window_base::refresh): New methods.
1696         (tui_refresh_all): Call the refresh method.
1697         * tui/tui-data.h (struct tui_win_info)
1698         (struct tui_source_window_base) <refresh>: New method.
1699
1700 2019-06-25  Tom Tromey  <tom@tromey.com>
1701
1702         * tui/tui.h (tui_is_window_visible): Return bool.
1703         * tui/tui.c (tui_is_window_visible): Return bool.
1704         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1705         (tui_make_visible, tui_make_invisible)
1706         (tui_win_info::make_visible)
1707         (tui_source_window_base::make_visible, make_all_visible)
1708         (tui_make_all_visible, tui_make_all_invisible): Update.
1709         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1710         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1711         bool.
1712         (struct tui_win_info, struct tui_source_window_base)
1713         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1714         * tui/tui-data.c (tui_init_generic_part): Update.
1715
1716 2019-06-25  Tom Tromey  <tom@tromey.com>
1717
1718         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1719         (tui_source_window_base::make_visible): New methods.
1720         (make_all_visible): Make method call.
1721         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1722         (struct tui_source_window_base, struct tui_cmd_window): Override
1723         make_visible.
1724         (tui_win_is_source_type): Don't declare.
1725         * tui/tui-data.c (tui_win_is_source_type): Remove.
1726
1727 2019-06-25  Tom Tromey  <tom@tromey.com>
1728
1729         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1730         NULL check.
1731
1732 2019-06-25  Tom Tromey  <tom@tromey.com>
1733
1734         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1735         Inline constructor.  Add initializers for members.
1736         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1737         constructors; now inline in class.
1738
1739 2019-06-25  Tom Tromey  <tom@tromey.com>
1740
1741         * tui/tui-regs.c (tui_show_registers): Update.
1742         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1743         bool.
1744         * tui/tui-data.c (tui_data_window::clear_detail)
1745         (tui_data_window): Update.
1746
1747 2019-06-25  Tom Tromey  <tom@tromey.com>
1748
1749         * tui/tui-windata.c (tui_display_all_data)
1750         (tui_display_data_from_line, tui_display_data_from)
1751         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1752         Update.
1753         * tui/tui-regs.c (tui_last_regs_line_no)
1754         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1755         (tui_show_registers, tui_show_register_group)
1756         (tui_display_registers_from, tui_display_reg_element_at_line)
1757         (tui_display_registers_from_line, tui_check_register_values)
1758         (tui_reg_next, tui_reg_prev): Update.
1759         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1760         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1761         tui_data_window.
1762         (struct tui_win_info) <detail>: Remove.  Add new fields from
1763         tui_data_info.
1764         (TUI_DATA_WIN): Add cast.
1765         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1766         (~tui_data_window): Simplify.
1767
1768 2019-06-25  Tom Tromey  <tom@tromey.com>
1769
1770         * tui/tui-layout.c (show_source_disasm_command)
1771         (show_source_or_disasm_and_command): Update.
1772         * tui/tui-io.c (update_cmdwin_start_line)
1773         (tui_redisplay_readline): Update.
1774         * tui/tui-data.h (struct tui_command_info): Remove.
1775         (struct tui_win_info) <detail>: Remove command_info member.
1776         (struct tui_data_window) <start_line>: New member, from
1777         tui_command_info.
1778         (TUI_CMD_WIN): Add casts.
1779
1780 2019-06-25  Tom Tromey  <tom@tromey.com>
1781
1782         * tui/tui-winsource.c (tui_update_source_window)
1783         (tui_refill_source_window)
1784         (tui_source_window_base::do_scroll_horizontal)
1785         (tui_update_breakpoint_info, tui_set_exec_info_content)
1786         (tui_show_exec_info_content, tui_erase_exec_info_content)
1787         (tui_clear_exec_info_content): Update.
1788         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1789         Update.
1790         * tui/tui-win.c (make_invisible_and_set_new_height)
1791         (make_visible_with_new_height): Update.
1792         * tui/tui-source.c (tui_set_source_content)
1793         (tui_show_symtab_source): Update.
1794         * tui/tui-layout.c (extract_display_start_addr)
1795         (show_source_disasm_command, show_data)
1796         (make_source_or_disasm_window)
1797         (show_source_or_disasm_and_command): Update.
1798         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1799         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1800         "gdbarch".
1801         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1802         to tui_source_window_base.
1803         (struct tui_win_info) <detail>: Remove source_info member.
1804         (struct tui_source_window_base) <has_locator>: Inline.
1805         Move contents from tui_source_info; rename has_locator member to
1806         m_has_locator.
1807         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1808         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1809         header file.
1810         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1811         Simplify.
1812         (tui_free_all_source_wins_content): Cast to
1813         tui_source_window_base.
1814
1815 2019-06-25  Tom Tromey  <tom@tromey.com>
1816
1817         * tui/tui-win.c (make_invisible_and_set_new_height)
1818         (make_visible_with_new_height): Call has_locator method.
1819         * tui/tui-layout.c (show_source_disasm_command, show_data)
1820         (show_source_or_disasm_and_command): Update for bool change.
1821         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1822         (tui_win_info) <has_locator>: New method.
1823         (struct tui_source_window_base) <has_locator>: New method.
1824         (tui_win_has_locator): Don't declare.
1825         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1826         from tui_win_has_locator.
1827         (tui_source_window_base): Use false, not FALSE.
1828
1829 2019-06-25  Tom Tromey  <tom@tromey.com>
1830
1831         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1832         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1833         clear_detail method directly.
1834         (tui_clear_win_detail): Remove.
1835
1836 2019-06-25  Tom Tromey  <tom@tromey.com>
1837
1838         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1839         "this", not TUI_DISASM_WIN.
1840
1841 2019-06-25  Tom Tromey  <tom@tromey.com>
1842
1843         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1844         declare.
1845         * tui/tui-winsource.c
1846         (tui_source_window_base::do_scroll_horizontal): Rename from
1847         tui_horizontal_source_scroll.
1848         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1849         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1850         from tui_vertical_data_scroll.
1851         * tui/tui-win.h (tui_scroll): Don't declare.
1852         * tui/tui-win.c (tui_win_info::forward_scroll)
1853         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1854         (tui_win_info::right_scroll): Rename and update.
1855         (tui_scroll_forward_command, tui_scroll_backward_command)
1856         (tui_scroll_left_command, tui_scroll_right_command): Update.
1857         (tui_scroll): Remove.
1858         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1859         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1860         from tui_vertical_source_scroll.
1861         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1862         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1863         from tui_vertical_disassem_scroll.
1864         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1865         do_scroll_horizontal>: New methods.
1866         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1867         Likewise.
1868         (struct tui_source_window_base): Add do_scroll_horizontal.
1869         (struct tui_source_window, struct tui_disasm_window): Add
1870         do_scroll_vertical.
1871         (struct tui_data_window, struct tui_cmd_window): Add
1872         do_scroll_horizontal and do_scroll_vertical.
1873         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1874
1875 2019-06-25  Tom Tromey  <tom@tromey.com>
1876
1877         * tui/tui-data.h (struct tui_source_window_base): New struct.
1878         (struct tui_source_window): Derive from tui_source_window_base.
1879         (struct tui_disasm_window): New struct.
1880         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1881         from tui_source_window::clear_detail.
1882         (tui_source_window_base): Rename from tui_source_window.
1883         (~tui_source_window_base): Rename from ~tui_source_window.
1884         (tui_alloc_win_info): Create a tui_disasm_window.
1885
1886 2019-06-25  Tom Tromey  <tom@tromey.com>
1887
1888         * tui/tui-data.h (struct tui_source_window)
1889         (struct tui_data_window): Declare destructors.
1890         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1891         destructors.
1892         (tui_win_info): Simplify.
1893
1894 2019-06-25  Tom Tromey  <tom@tromey.com>
1895
1896         * tui/tui-winsource.c (tui_display_main)
1897         (tui_update_source_windows_with_addr)
1898         (tui_update_all_breakpoint_info): Update.
1899         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1900         (new_height_ok, parse_scrolling_args): Update.
1901         * tui/tui-stack.c (tui_show_frame_info): Update.
1902         * tui/tui-data.h (struct tui_list): Remove.
1903         (tui_source_windows): Return a reference to a std::vector.
1904         * tui/tui-data.c (source_windows): Now a std::vector.
1905         (tui_source_windows): Change return type.
1906         (tui_clear_source_windows): Rewrite.
1907         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1908         (tui_free_all_source_wins_content): Rewrite.
1909
1910 2019-06-25  Tom Tromey  <tom@tromey.com>
1911
1912         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1913         (struct tui_data_window, struct tui_cmd_window): Declare
1914         clear_detail method.
1915         * tui/tui-data.c (tui_source_window::clear_detail)
1916         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1917         methods.
1918         (tui_clear_win_detail): Simplify.
1919
1920 2019-06-25  Tom Tromey  <tom@tromey.com>
1921
1922         * tui/tui-layout.c (make_source_window, make_disasm_window)
1923         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1924         Return the new window.
1925         (show_source_disasm_command, show_data)
1926         (show_source_or_disasm_and_command): Update.
1927
1928 2019-06-25  Tom Tromey  <tom@tromey.com>
1929
1930         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1931         parameter.  Return the new window.
1932         (show_source_disasm_command): Update and remove NULL check.
1933         (show_source_or_disasm_and_command): Update.
1934
1935 2019-06-25  Tom Tromey  <tom@tromey.com>
1936
1937         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1938
1939 2019-06-25  Tom Tromey  <tom@tromey.com>
1940
1941         * tui/tui-data.h (struct tui_win_info): Make constructor
1942         protected.  Make destructor virtual.  Add initializers.
1943         (tui_source_window, tui_data_window, tui_cmd_window): New
1944         classes.
1945         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1946         constructor.  Add "type" parameter.
1947         (tui_source_window, tui_data_window, tui_cmd_window): New
1948         constructors.
1949         (tui_alloc_win_info): Instantiate the appropriate subclass.
1950
1951 2019-06-25  Tom Tromey  <tom@tromey.com>
1952
1953         * tui/tui-win.c (tui_resize_all): Use delete.
1954         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1955         destructor.
1956         (tui_free_window): Don't declare.
1957         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1958         Update.
1959
1960 2019-06-25  Tom Tromey  <tom@tromey.com>
1961
1962         * tui/tui-data.h (struct tui_win_info): Add constructor.
1963         * tui/tui-data.c (tui_alloc_win_info): Use new.
1964         (tui_free_window): Use delete.
1965
1966 2019-06-22  Tom Tromey  <tom@tromey.com>
1967
1968         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1969         declare.
1970         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1971
1972 2019-06-22  Tom Tromey  <tom@tromey.com>
1973
1974         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1975         declare.
1976         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1977
1978 2019-06-22  Tom de Vries  <tdevries@suse.de>
1979
1980         * dwarf2read.c (create_addrmap_from_aranges)
1981         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1982         instead of '%zu'.
1983
1984 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1985
1986         * dwarf2read.h (dwarf2_section_info_def): Remove.
1987         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1988         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1989         std::vector<dwarf2_section_info>.
1990         (struct dwo_file) <~dwo_file>: Remove.
1991         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1992         types field.
1993         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1994         (dwarf2_read_debug_names): Likewise.
1995         (create_debug_types_hash_table): Change parameter type to
1996         array_view, adjust code accordingly.
1997         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1998         (partial_die_info::fixup): Likewise.
1999         (determine_prefix): Likewise.
2000         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2001
2002 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2003
2004         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2005         gdb_bfd_ref_ptr.
2006         <~dwo_file>: Remove call to gdb_bfd_unref.
2007         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2008         gdb_bfd_ref_ptr::get.
2009
2010 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2011
2012         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2013         type to htab_up.
2014         * dwarf2read.c (struct dwo_file): Initialize fields.
2015         <~dwo_file>: New.
2016         (free_dwo_file): Remove, move content to ~dwo_file.
2017         (struct dwo_file_deleter): Remove.
2018         (dwo_file_up>: Remove custom deleter.
2019         (free_dwo_files): Remove.
2020         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2021         dwo_files.
2022         (process_skeletonless_type_units): Call unique_ptr::get.
2023         (allocate_dwo_file_hash_table): Add deleter to created hash
2024         table.  Change return type to htab_up.
2025         (lookup_dwo_file_slot): Don't memset dwo_file, call
2026         unique_ptr::get.
2027         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2028         (create_dwo_unit_in_dwp_v2): Likewise.
2029         (open_and_init_dwo_file): Likewise.
2030         (free_dwo_file_from_slot): Remove.
2031
2032 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2033
2034         * dwarf2read.h (struct dwarf2_section_info) <readin,
2035         is_virtual>: Change type to bool.
2036         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2037         true instead of 1.
2038
2039 2019-06-19  Tom Tromey  <tom@tromey.com>
2040
2041         * tui/tui-data.h (tui_init_content_element): Don't declare.
2042
2043 2019-06-19  Tom Tromey  <tom@tromey.com>
2044
2045         * tui/tui-data.h (tui_init_win_info): Don't declare.
2046
2047 2019-06-19  Tom de Vries  <tdevries@suse.de>
2048
2049         * dwarf2read.h (abstract_to_concrete): Change type to
2050         std::unordered_map<sect_offset, std::vector<sect_offset>,
2051         gdb::hash_enum<sect_offset>>.
2052
2053 2019-06-19  Tom Tromey  <tromey@adacore.com>
2054
2055         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2056         EVAL_AVOID_SIDE_EFFECTS specially.
2057
2058 2019-06-19  Tom Tromey  <tromey@adacore.com>
2059
2060         * source-cache.c (highlighter): New global.
2061         (source_cache::get_source_lines): Create a highlighter on demand.
2062
2063 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2064
2065         * defs.h (deprecated_interactive_hook): Delete declaration.
2066         * interps.c (clear_interpreter_hooks): Remove use of
2067         deprecated_interactive_hook.
2068         * top.c (deprecated_interactive_hook): Delete definition.
2069         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2070
2071 2019-06-18  Tom de Vries  <tdevries@suse.de>
2072
2073         PR gdb/24515
2074         * dwarf2read.h (abstract_to_concrete): Change type from
2075         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2076         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2077         * dwarf2read.c (read_variable): Update.
2078         (dwarf2_fetch_die_loc_sect_off): Update.
2079
2080 2019-06-17  Tom de Vries  <tdevries@suse.de>
2081
2082         PR gdb/24617
2083         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2084         accessing parent[parent_len - 1].
2085
2086 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2087
2088         PR gdb/24364
2089         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2090         call dtrace_process_dof with NULL dof.
2091
2092 2019-06-16  Tom de Vries  <tdevries@suse.de>
2093
2094         PR gdb/24445
2095         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2096
2097 2019-06-16  Tom Tromey  <tom@tromey.com>
2098
2099         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2100         (make_all_visible): Use address of member.
2101
2102 2019-06-16  Tom Tromey  <tom@tromey.com>
2103
2104         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2105         (tui_free_window, free_content, free_content_elements): Remove
2106         unnecessary cast.
2107         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2108         cast.
2109         * tui/tui-regs.c (tui_show_register_group)
2110         (tui_display_registers_from, tui_display_reg_element_at_line):
2111         Remove unnecessary cast.
2112
2113 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2114
2115         * linux-nat.c (normal_mask): Delete.
2116         (_initialize_linux_nat): Don't initialise normal_mask.
2117
2118 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2119
2120         PR gdb/24445
2121         * dwarf-index-write.h (write_psymtabs_to_index): Add
2122         dwz_basename parameter.
2123         * dwarf-index-write.c (write_gdbindex): Move file writing to
2124         write_gdbindex_1.  Change return type void.
2125         (assert_file_size): Move up, remove filename parameter.
2126         (write_gdbindex_1): New function.
2127         (write_debug_names): Change return type to void, call
2128         assert_file_size.
2129         (struct index_wip_file): New struct.
2130         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2131         file logic to index_wip_file.  Write index for dwz file if
2132         needed.
2133         (save_gdb_index_command): Pass basename of dwz file, if present.
2134         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2135         build-id of dwz file, if present.
2136         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2137         (dwarf2_get_dwz_file): Likewise.
2138         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2139         (dwarf2_get_dwz_file): Likewise.
2140
2141 2019-06-16  Tom Tromey  <tom@tromey.com>
2142
2143         * coffread.c (process_coff_symbol): Use xstrdup.
2144         * value.c (create_internalvar): Use xstrdup.
2145
2146 2019-06-16  Tom Tromey  <tom@tromey.com>
2147
2148         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2149         * breakpoint.c (stopin_command, stopat_command)
2150         (until_break_command, decode_location_default): Remove unnecessary
2151         cast.
2152         * utils.c (subset_compare): Remove unnecessary cast.
2153         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2154         cast.
2155         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2156         cast.
2157         * infcmd.c (path_command): Remove unnecessary cast.
2158         * coffread.c (decode_type): Remove unnecessary cast.
2159         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2160         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2161         * tui/tui-stack.c (tui_show_locator_content)
2162         (tui_show_frame_info): Remove unnecessary cast.
2163         * tui/tui-win.c (tui_scroll_forward_command)
2164         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2165         (parse_scrolling_args): Remove unnecessary cast.
2166         * tui/tui-data.c (init_win_info, tui_del_window)
2167         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2168         (free_content_elements): Remove unnecessary cast.
2169         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2170         unnecessary cast.
2171         * tui/tui-source.c (tui_set_source_content)
2172         (tui_vertical_source_scroll): Remove unnecessary cast.
2173         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2174         cast.
2175         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2176         * tui/tui-regs.c (tui_display_registers_from)
2177         (tui_display_register): Remove unnecessary cast.
2178         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2179         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2180         (make_visible): Remove unnecessary cast.
2181         * tui/tui-winsource.c (tui_erase_source_content)
2182         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2183         unnecessary cast.
2184         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2185         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2186         * stabsread.c (read_type, read_array_type, read_range_type):
2187         Remove unnecessary cast.
2188         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2189         (parse_symbol, parse_type, upgrade_type, parse_external)
2190         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2191         unnecessary cast.
2192         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2193
2194 2019-06-16  Tom Tromey  <tom@tromey.com>
2195
2196         * tui/tui-data.c (tui_alloc_generic_win_info)
2197         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2198         checks.
2199
2200 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2201             Andrew Burgess  <andrew.burgess@embecosm.com>
2202
2203         * f-typeprint.c (f_print_type): Don't return early for not
2204         associated or not allocated types.
2205         (f_type_print_varspec_suffix): Add print_rank parameter and print
2206         ranks of array types in case they dangling.
2207         (f_type_print_base): Add print_rank parameter.
2208
2209 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2210
2211         * NEWS: Mention new MI commands.
2212         * break-catch-throw.c (enum exception_event_kind): Move to
2213         breakpoint.h.
2214         (print_mention_exception_catchpoint): Output text as a single
2215         message.
2216         (catch_exception_command_1): Rename to...
2217         (catch_exception_event): ...this, make non-static, update header
2218         command, and change some parameter types.
2219         (catch_catch_command): Update for changes to
2220         catch_exception_command_1.
2221         (catch_throw_command): Likewise.
2222         (catch_rethrow_command): Likewise.
2223         * breakpoint.c (enum exception_event_kind): Delete.
2224         * breakpoint.h (enum exception_event_kind): Moved here from
2225         break-catch-throw.c.
2226         (catch_exception_event): Declare.
2227         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2228         (mi_cmd_catch_throw): New function.
2229         (mi_cmd_catch_rethrow): New function.
2230         (mi_cmd_catch_catch): New function.
2231         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2232         'catch-catch' entries.
2233         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2234         (mi_cmd_catch_rethrow): Declare.
2235         (mi_cmd_catch_catch): Declare.
2236
2237 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2238
2239         * annotate.c (annotate_source_line): Change return type to void,
2240         update implementation to match.
2241         * annotate.h (annotate_source_line): Change return type to void,
2242         update header comment.
2243         * stack.c (print_frame_info): Don't change what frame information
2244         is printed based on whether annotations are on or not.
2245
2246 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2247
2248         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2249         (annotate_source): Make static.
2250         (annotate_source_line): Moved from source.c and renamed from
2251         identify_source_line.  Update the return type.
2252         * annotate.h (annotate_source): Delete declaration.
2253         (annotate_source_line): Declaration moved from source.h, and
2254         renamed from identify_source_line.  Return type updated.
2255         * source.c (identify_source_line): Moved to annotate.c and renamed
2256         to annotate_source_line.
2257         (info_line_command): Remove check of annotation_level.
2258         * source.h (identify_source_line): Move declaration to annotate.h
2259         and rename to annotate_source_line.
2260         * stack.c: Add 'annotate.h' include.
2261         (print_frame_info): Remove check of annotation_level before
2262         calling annotate_source_line.
2263
2264 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2265
2266         * source-cache.c (source_cache::get_plain_source_lines): Use
2267         open_source_file_with_line_charpos instead of just
2268         open_source_file, remove call to find_source_lines.
2269         (source_cache::get_source_lines): Likewise.
2270         * source.c (find_source_lines): Make static.
2271         (get_filename_and_charpos): Renamed into...
2272         (open_source_file_with_line_charpos): ..this along with changes to
2273         return a scoped_fd, and some other minor clean ups.
2274         (identify_source_line): Use open_source_file_with_line_charpos.
2275         (search_command_helper): Use open_source_file_with_line_charpos
2276         instead of just open_source_file, remove call to
2277         find_source_lines.
2278         * source.h (open_source_file_with_line_charpos): Declare new
2279         function.
2280         (find_source_lines): Delete declaration.
2281
2282 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2283
2284         * source.c (get_filename_and_charpos): Remove fullname
2285         parameter.
2286         (identify_source_line): Update call to get_filename_and_charpos.
2287
2288 2019-06-14  Tom Tromey  <tromey@adacore.com>
2289
2290         PR gdb/24502:
2291         * ui-style.h (skip_ansi_escape): Update comment.
2292         * ui-file.h (class no_terminal_escape_file): New class.
2293         * ui-file.c (no_terminal_escape_file::write)
2294         (no_terminal_escape_file::puts): New methods.
2295         * cli/cli-logging.c (handle_redirections): Use
2296         no_terminal_escape_file.
2297
2298 2019-06-14  Tom Tromey  <tromey@adacore.com>
2299
2300         * NEWS: Move convenience variable news above Python news.
2301
2302 2019-06-14  Tom Tromey  <tom@tromey.com>
2303
2304         * gnulib: Move directory to top-level.
2305         * configure.ac: Don't configure gnulib.
2306         * configure: Rebuild.
2307         * common/common-defs.h: Use new path to gnulib.
2308         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2309         (GNULIB_H): Remove.
2310         (INCGNU): Look in new gnulib location.
2311         (HFILES_NO_SRCDIR): Remove gnulib files.
2312         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2313         (generated_files): Remove GNULIB_H.
2314         ($(LIBGNU), all-lib): Remove targets.
2315         (distclean): Don't mention GNULIB_BUILDDIR.
2316         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2317
2318 2019-06-14  Tom Tromey  <tromey@adacore.com>
2319
2320         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2321         Warn if symbol file does not provide any symbols.
2322
2323 2019-06-14  Tom Tromey  <tromey@adacore.com>
2324
2325         * source.c (find_and_open_source): Respect basenames_may_differ.
2326
2327 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2328
2329         * annotate.c (annotate_breakpoints_invalid): Make use of
2330         scoped_restore_terminal_state.
2331         (annotate_frames_invalid): Likewise.
2332
2333 2019-06-14  Tom Tromey  <tromey@adacore.com>
2334
2335         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2336         allow assignment to an internalvar.
2337
2338 2019-06-14  Tom Tromey  <tromey@adacore.com>
2339
2340         * ada-lex.l: Allow "_" in attribute names.
2341
2342 2019-06-14  Tom Tromey  <tromey@adacore.com>
2343
2344         PR gdb/24653:
2345         * regcache.c (registers_changed): Don't call alloca.
2346         * top.c (execute_command): Don't call alloca.
2347
2348 2019-06-13  Pedro Alves  <palves@redhat.com>
2349
2350         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2351         'expression'.  When parsing an expression, error out if there's
2352         junk after "unlimited".
2353         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2354         (do_set_command): Adjust calls to is_unlimited_literal.
2355
2356 2019-06-13  Pedro Alves  <palves@redhat.com>
2357
2358         * compile/compile.c (make_compile_options_def_group): Add braces
2359         around array_view initializer.
2360         * thread.c (make_thread_apply_all_options_def_group)
2361         (make_thread_apply_all_options_def_group): Likewise.
2362
2363 2019-06-13  Pedro Alves  <palves@redhat.com>
2364
2365         * NEWS (New commands): Mention "maint test-options
2366         require-delimiter", "maint test-options unknown-is-error", "maint
2367         test-options unknown-is-operand" and "maint show
2368         test-options-completion-result".
2369         (New command options, command completion): New section.
2370         (Completion improvements): New section.
2371         Mention that you can abbreviate "unlimited".
2372
2373 2019-06-13  Pedro Alves  <palves@redhat.com>
2374
2375         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2376         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2377         * unittests/cli-utils-selftests.c (test_parse_flags)
2378         (test_parse_flags_qcs): Delete.
2379         (test_cli_utils): Don't call deleted functions.
2380
2381 2019-06-13  Pedro Alves  <palves@redhat.com>
2382
2383         * thread.c: Include "cli/cli-option.h".
2384         (tp_array_compar_ascending): Global.
2385         (tp_array_compar): Delete function.
2386         (tp_array_compar_ascending, tp_array_compar_descending): New
2387         functions.
2388         (ascending_option_def, qcs_flag_option_def)
2389         (thr_qcs_flags_option_defs)
2390         (make_thread_apply_all_options_def_group)
2391         (make_thread_apply_options_def_group): New.
2392         (thread_apply_all_command): Use gdb::option::process_options.
2393         (thread_apply_command_completer)
2394         (thread_apply_all_command_completer): New.
2395         (thread_apply_command): Use gdb::option::process_options.
2396         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2397         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2398         to generate help text of "thread apply".  Adjust "taas"'s help.
2399         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2400         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2401
2402 2019-06-13  Pedro Alves  <palves@redhat.com>
2403
2404         * thread.c (thread_apply_command): Check for invalid TID with
2405         isdigit instead of !isalpha.
2406
2407 2019-06-13  Pedro Alves  <palves@redhat.com>
2408
2409         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2410         (validate_flags_qcs): New.
2411         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2412         (validate_flags_qcs): Declare.
2413         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2414         (make_frame_apply_options_def_group): New.
2415         (frame_apply_command_count): Process options with
2416         gdb::option::process_options.
2417         (frame_apply_completer): New.
2418         (frame_apply_level_completer, frame_apply_all_completer)
2419         (frame_apply_completer): New.
2420         (_initialize_stack): Update help of "frame apply", "frame apply
2421         level", "frame apply all" and "faas" to mention supported options
2422         and install command completers.
2423         * stack.h (frame_apply_all_completer): Declare.
2424         * thread.c: Include "stack.h".
2425         (tfaas_command): Add "--".
2426         (_initialize_thread): Update help "tfaas" to mention supported
2427         options and install command completer.
2428
2429 2019-06-13  Pedro Alves  <palves@redhat.com>
2430
2431         * completer.c (complete_nested_command_line): New.
2432         (gdb_completion_word_break_characters_throw): Add assertion.
2433         * completer.h (complete_nested_command_line): Declare.
2434
2435 2019-06-13  Pedro Alves  <palves@redhat.com>
2436
2437         * stack.c (parse_backtrace_qualifiers): New.
2438         (backtrace_command): Use it.
2439         (backtrace_command_completer): Complete on qualifiers.
2440
2441 2019-06-13  Pedro Alves  <palves@redhat.com>
2442
2443         * frame.c: Include "cli/cli-option.h.
2444         (user_set_backtrace_options): New.
2445         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2446         Delete.
2447         (get_prev_frame): Adjust.
2448         (boolean_option_def, uinteger_option_def)
2449         (set_backtrace_option_defs): New.
2450         (_initialize_frame): Adjust and use
2451         gdb::option::add_setshow_cmds_for_options to install "set
2452         backtrace past-main" and "set backtrace past-entry".
2453         * frame.h: Include "cli/cli-option.h".
2454         (struct frame_print_options): Forward declare.
2455         (print_frame_arguments_all, print_frame_arguments_scalars)
2456         (print_frame_arguments_none): Declare.
2457         (print_entry_values): Delete declaration.
2458         (struct frame_print_options, user_frame_print_options): New.
2459         (struct set_backtrace_options): New.
2460         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2461         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2462         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2463         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2464         (list_args_or_locals): Add frame_print_options parameter.
2465         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2466         * python/py-framefilter.c (enumerate_args): Pass down
2467         USER_FRAME_PRINT_OPTIONS.
2468         * stack.c: Include "cli/cli-option.h".
2469         (print_frame_arguments_all, print_frame_arguments_scalars)
2470         (print_frame_arguments_none): Declare.
2471         (print_raw_frame_arguments, print_entry_values): Delete.
2472         (user_frame_print_options): New.
2473         (boolean_option_def, enum_option_def, frame_print_option_defs):
2474         New.
2475         (struct backtrace_cmd_options): New.
2476         (bt_flag_option_def): New.
2477         (backtrace_command_option_defs): New.
2478         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2479         (print_frame_arg, read_frame_arg, print_frame_args)
2480         (print_frame_info, print_frame): Add frame_print_options parameter
2481         and use it.
2482         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2483         (backtrace_command_1): Add frame_print_options and
2484         backtrace_cmd_options parameters and use them.
2485         (make_backtrace_options_def_group): New.
2486         (backtrace_command): Process command options with
2487         gdb::option::process_options.
2488         (backtrace_command_completer): New.
2489         (_initialize_stack): Extend "backtrace"'s help to mention
2490         supported options.  Install completer for "backtrace".
2491         Install some settings commands with add_setshow_cmds_for_options.
2492
2493 2019-06-13  Pedro Alves  <palves@redhat.com>
2494
2495         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2496         and that "set/show print raw frame-arguments" are now deprecated.
2497
2498         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2499         command.
2500         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2501         * stack.c (_initialize_stack): Install "set/show print
2502         raw-frame-arguments", and deprecate "set/show print raw
2503         frame-arguments".
2504         * valprint.c (_initialize_valprint): Deprecate "set/show print
2505         raw".
2506
2507 2019-06-13  Pedro Alves  <palves@redhat.com>
2508
2509         * compile/compile.c (struct compile_options): New.
2510         (compile_flag_option_def, compile_command_option_defs)
2511         (make_compile_options_def_group): New.
2512         (compile_file_command): Handle options with
2513         gdb::option::process_options.
2514         (compile_file_command_completer): New function.
2515         (compile_code_command): Handle options with
2516         gdb::option::process_options.
2517         (compile_code_command_completer): New function.
2518         (_initialize_compiler): Install completers for "compile code" and
2519         "compile file".  Mention available options in "compile code" and
2520         "compile code"'s help.
2521         * completer.c (advance_to_completion_word): New, factored out from
2522         ...
2523         (advance_to_expression_complete_word_point): ... this.
2524         (advance_to_filename_complete_word_point): New.
2525         * completer.h (advance_to_filename_complete_word_point): New
2526         declaration.
2527
2528 2019-06-13  Pedro Alves  <palves@redhat.com>
2529
2530         * compile/compile.c: Include "cli/cli-option.h".
2531         (compile_print_value): Scope data pointer is now a
2532         value_print_options pointer; adjust.
2533         (compile_print_command): Process options.  Scope data pointer is
2534         now a value_print_options pointer; adjust.
2535         (_initialize_compile): Update "compile print"'s help to include
2536         supported options.  Install a completer for "compile print".
2537         * cp-valprint.c (show_vtblprint, show_objectprint)
2538         (show_static_field_print): Delete.
2539         (_initialize_cp_valprint): Don't install "set print
2540         static-members", "set print vtbl", "set print object" here.
2541         * printcmd.c: Include "cli/cli-option.h" and
2542         "common/gdb_optional.h".
2543         (print_command_parse_format): Rework to fill in a
2544         value_print_options instead of a format_data.
2545         (print_value): Change parameter type from format_data pointer to
2546         value_print_options reference.  Adjust.
2547         (print_command_1): Process options.  Adjust to pass down a
2548         value_print_options.
2549         (print_command_completer): New.
2550         (_initialize_printcmd): Install print_command_completer as
2551         handle_brkchars completer for the "print" command.  Update
2552         "print"'s help to include supported options.
2553         * valprint.c: Include "cli/cli-option.h".
2554         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2555         here from cp-valprint.c.
2556         (boolean_option_def, uinteger_option_def)
2557         (value_print_option_defs, make_value_print_options_def_group):
2558         New.  Use gdb::option::add_setshow_cmds_for_options to install
2559         "set print elements", "set print null-stop", "set print repeats",
2560         "set print pretty", "set print union", "set print array", "set
2561         print address", "set print symbol", "set print array-indexes".
2562         * valprint.h: Include <string> and "cli/cli-option.h".
2563         (make_value_print_options_def_group): Declare.
2564         (print_value): Change parameter type from format_data pointer to
2565         value_print_options reference.
2566         (print_command_completer): Declare.
2567
2568 2019-06-13  Pedro Alves  <palves@redhat.com>
2569
2570         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2571         (COMMON_SFILES): Add maint-test-settings.c.
2572         * cli/cli-decode.c (boolean_enums): New global, factored out from
2573         ...
2574         (add_setshow_boolean_cmd): ... here.
2575         * cli/cli-decode.h (boolean_enums): Declare.
2576         * cli/cli-option.c: New file.
2577         * cli/cli-option.h: New file.
2578         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2579         factored out from ...
2580         (parse_cli_boolean_value(const char *)): ... this.
2581         (is_unlimited_literal): Change parameter type to pointer to
2582         pointer.  Adjust and advance ARG pointer.
2583         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2584         (parse_cli_var_enum): New, factored out from ...
2585         (do_set_command): ... this.  Adjust.
2586         * cli/cli-setshow.h (parse_cli_boolean_value)
2587         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2588         (parse_cli_var_enum): Declare.
2589         * cli/cli-utils.c: Include "cli/cli-option.h".
2590         (get_ulongest): New.
2591         * cli/cli-utils.h (get_ulongest): Declare.
2592         (check_for_argument): New overloads.
2593         * maint-test-options.c: New file.
2594
2595 2019-06-13  Pedro Alves  <palves@redhat.com>
2596
2597         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2598         parse a range if "-" is at the end of the string.
2599
2600 2019-06-13  Pedro Alves  <palves@redhat.com>
2601
2602         * cli/cli-setshow.c (parse_auto_binary_operation)
2603         (parse_cli_boolean_value): Don't allow "o".
2604
2605 2019-06-13  Pedro Alves  <palves@redhat.com>
2606
2607         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2608         * NEWS: Mention maint test-settings KIND.
2609         * maint-test-settings.c: New file.
2610
2611 2019-06-13  Pedro Alves  <palves@redhat.com>
2612
2613         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2614         completer.
2615         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2616         "set" completers.
2617
2618 2019-06-13  Pedro Alves  <palves@redhat.com>
2619
2620         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2621         after item.
2622
2623 2019-06-13  Pedro Alves  <palves@redhat.com>
2624
2625         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2626
2627 2019-06-13  Pedro Alves <palves@redhat.com>
2628
2629         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2630         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2631         call.
2632         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2633         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2634         calls.
2635         (check_for_argument): Skip spaces after argument.
2636
2637 2019-06-13  Pedro Alves  <palves@redhat.com>
2638
2639         * thread.c (thread_apply_command): Adjust TID parsing.
2640         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2641         detected before end of string.
2642         (tid_is_in_list): Error out if LIST is invalid.
2643
2644 2019-06-13  Pedro Alves  <palves@redhat.com>
2645
2646         * completer.c (complete_line_internal_1): Rewind completion word
2647         point.
2648         (completion_tracker::advance_custom_word_point_by): Change
2649         parameter type to int.
2650         * completer.h (completion_tracker::advance_custom_word_point_by):
2651         Likewise.
2652
2653 2019-06-13  Pedro Alves  <palves@redhat.com>
2654
2655         * completer.c (advance_to_completion_word): Handle delimiters.
2656
2657 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2658
2659         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2660
2661 2019-06-11  Tom Tromey  <tom@tromey.com>
2662
2663         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2664         (xmalloc_failed): Move to alloc.c.
2665         * alloc.c: New file.
2666         * Makefile.in (COMMON_SFILES): Add alloc.c.
2667
2668 2019-06-11  Tom Tromey  <tom@tromey.com>
2669
2670         * nat/linux-waitpid.c: Don't include server.h.
2671         (linux_debug): Remove.
2672         (my_waitpid): Update.
2673
2674 2019-06-11  Tom Tromey  <tromey@adacore.com>
2675
2676         * infcall.c (_initialize_infcall): Remove trailing newline from
2677         help.
2678         * user-regs.c (_initialize_user_regs): Remove trailing newline
2679         from help.
2680         * typeprint.c (_initialize_typeprint): Remove trailing newline
2681         from help.
2682         * reverse.c (_initialize_reverse): Remove trailing newlines from
2683         help.
2684         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2685         from help.
2686         * language.c (add_set_language_command): Remove trailing newline
2687         from help.
2688         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2689         help.
2690         * disasm.c (_initialize_disasm): Remove trailing newline from
2691         help.
2692         * top.c (init_main): Remove trailing newline from help.
2693         * interps.c (_initialize_interpreter): Remove trailing newline
2694         from help.
2695         * btrace.c (_initialize_btrace): Remove trailing newlines from
2696         help.
2697         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2698         from help.
2699         * python/python.c (_initialize_python): Remove trailing newline
2700         from help.
2701         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2702         help.
2703         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2704         from help.  Reformat some text.
2705         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2706         from help.
2707         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2708         newline from help.
2709
2710 2019-06-11  Tom Tromey  <tromey@adacore.com>
2711
2712         * darwin-nat.c (darwin_decode_exception_message)
2713         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2714
2715 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2716
2717         * valops.c (value_slice): Check for not allocated or not
2718         associated values.
2719
2720 2019-06-10  Tom de Vries  <tdevries@suse.de>
2721
2722         PR gdb/24618
2723         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2724         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2725         invalid.
2726
2727 2019-06-10  Tom de Vries  <tdevries@suse.de>
2728
2729         PR gdb/24611
2730         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2731         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2732
2733 2019-06-10  Tom de Vries  <tdevries@suse.de>
2734
2735         PR symtab/24545
2736         * symtab.c (struct demangled_name_entry): Add language field.
2737         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2738         static minimal symbol".  Set and use language field.
2739
2740 2019-06-10  Tom Tromey  <tromey@adacore.com>
2741
2742         * ada-lang.c (_initialize_ada_language): Update help text.
2743
2744 2019-06-10  Tom Tromey  <tromey@adacore.com>
2745
2746         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2747         with a newline.
2748         * guile/guile.c (handle_boot_error): Don't end warning with a
2749         newline.
2750         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2751         warning with a newline.
2752         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2753         newline.
2754         (s12z_frame_cache): Likewise.
2755         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2756         a newline.
2757         * solib-svr4.c (disable_probes_interface): Don't end warning with
2758         a newline.
2759         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2760         newline.
2761         * python/python.c (do_finish_initialization): Don't end warning
2762         with a newline.
2763
2764 2019-06-10  Tom Tromey  <tom@tromey.com>
2765
2766         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2767         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2768         gdbpy_enter.
2769
2770 2019-06-10  Tom Tromey  <tromey@adacore.com>
2771
2772         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2773         data.
2774         (elf_new_init): Don't call stabsread_new_init.
2775         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2776         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2777         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2778
2779 2019-06-10  Tom de Vries  <tdevries@suse.de>
2780
2781         PR symtab/16264
2782         PR symtab/24517
2783         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2784
2785 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2786
2787         * source.c (find_and_open_source): Also rewrite relative file
2788         names.
2789
2790 2019-04-26  Amos Bird  <amosbird@gmail.com>
2791
2792         * annotate.c (annotate_thread_exited): Add "thread-exited"
2793         annotation.
2794
2795 2019-06-06  Tom Tromey  <tromey@adacore.com>
2796
2797         * maint.h (class scoped_command_stats): Use
2798         DISABLE_COPY_AND_ASSIGN.
2799         <print_time>: New method.
2800         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2801         print_time.
2802         (scoped_command_stats::print_time): New method.
2803
2804 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2805
2806         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2807         instructions of lengths 6 or 8 bytes.
2808
2809 2019-06-04  Pedro Alves  <palves@redhat.com>
2810
2811         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2812
2813         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2814         * breakpoint.c (condition_completer): Likewise.
2815         * cli/cli-dump.c (scan_expression): Likewise.
2816         * common/filestuff.c (mkdir_recursive): Likewise.
2817         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2818         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2819         (gdb_abspath): Likewise.
2820         * compile/compile-cplus-types.c
2821         (compile_cplus_instance::decl_name): Likewise.
2822         * completer.c (complete_explicit_location):
2823         (signal_completer, reg_or_group_completer_1): Likewise.
2824         * cp-support.c (cp_remove_params_if_any): Likewise.
2825         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2826         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2827         * infcmd.c (strip_bg_char): Likewise.
2828         * linespec.c (copy_token_string): Likewise.
2829         * mi/mi-main.c (output_cores): Likewise.
2830         * psymtab.c (psymtab_search_name):
2831         * symfile.c (test_set_ext_lang_command): Likewise.
2832         * target.c (target_fileio_read_stralloc): Likewise.
2833         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2834         * value.c (complete_internalvar): Likewise.
2835
2836 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2837
2838         Add objfile property to gdb.Type.
2839         * NEWS: Mention Python API addition.
2840         * python/py-type.c (typy_get_objfile): New method.
2841
2842 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2843
2844         * NEWS: Mention the new set|show style [title|highlight].
2845         Mention changes to "show style", "help" and "apropos".
2846
2847 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2848
2849         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2850         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2851         instead of print_help_for_command.
2852         (print_doc_of_command): New function.
2853         (help_list): Add 'apropos -v word' suggestion.
2854         (print_help_for_command): Style the command name using title style.
2855         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2856         (_initialize_cli_cmds): Describe -v in apropos_command help.
2857
2858 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2859
2860         * cli/cli-style.h (cli_style_option): Add name in constructor,
2861         add m_name class member, add constructor with intensity,
2862         add name class function.
2863         (cli_style_option::add_setshow_commands): Remove name argument.
2864         (highlight_style, title_style): New styles.
2865         * cli/cli-style.c (do_show): New function that shows a style
2866         characteristic styling the style name with itself.
2867         (set_style_name): New function.
2868         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2869         Update all callers according to the changes in cli/cli-style.h.
2870         * utils.h (fputs_highlighted): New function.
2871         * utils.c (fputs_highlighted): Likewise.
2872
2873 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2874
2875         * NEWS: Mention new pipe command and new convenience variables.
2876
2877 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2878
2879         * cli/cli-cmds.c (pipe_command): New function.
2880         (_initialize_cli_cmds): Call add_com for pipe_command.
2881         Define | as an alias for pipe.
2882         (exit_status_set_internal_vars): New function.
2883         (shell_escape): Call exit_status_set_internal_vars.
2884         cli/cli-decode.c (find_command_name_length): Recognize | as
2885         a single character command.
2886
2887 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2888
2889         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2890         top.c (execute_command_to_ui_file): New function, mostly a copy
2891         of execute_command_to_string.
2892         (execute_command_to_string): Implement by calling
2893         execute_command_to_ui_file.
2894
2895 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2896
2897         * top.h (saved_command_line): Remove declaration.
2898         * top.c (previous_saved_command_line, previous_repeat_arguments):
2899         New variables.
2900         (saved_command_line): Make static, define together with other
2901         'repeat variables'.
2902         (dont_repeat): Clear repeat_arguments.
2903         (repeat_previous, get_saved_command_line, save_command_line):
2904         New functions.
2905         (gdb_init): Initialize saved_command_line
2906         and previous_saved_command_line.
2907         * main.c (captured_main_1): Remove saved_command_line initialization.
2908         * event-top.c (handle_line_of_input): Update to use
2909         the new 'repeat' related functions instead of direct access to
2910         saved_command_line.
2911         * command.h (repeat_previous, get_saved_command_line,
2912         save_command_line): New declarations.
2913         (dont_repeat): Add comment.
2914
2915 2019-05-30  Tom Tromey  <tromey@adacore.com>
2916
2917         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2918         Fix comment.
2919         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2920
2921 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2922
2923         PR cli/24587
2924         * completer.c (complete): Initialize variable word.
2925
2926 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2927
2928         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2929         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2930         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2931         'body' is NULL to the outter 'if', protecting the '!is_define'
2932         situation as well.
2933
2934 2019-05-29  Tom Tromey  <tromey@adacore.com>
2935
2936         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2937         (dwarf_unknown): New function.
2938         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2939         (dwarf_type_encoding_name): Use dwarf_unknown.
2940
2941 2019-05-29  Tom Tromey  <tromey@adacore.com>
2942
2943         PR c++/20020:
2944         * cp-valprint.c (cp_print_value_fields): Call
2945         cp_print_static_field inside "try".
2946
2947 2019-05-29  Tom Tromey  <tromey@adacore.com>
2948
2949         * inflow.c (struct terminal_info): Add default operator=.
2950         * configure: Rebuild.
2951         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2952         -Wdeprecated-copy-dtor, -Wredundant-move.
2953
2954 2019-05-29  Tom Tromey  <tromey@adacore.com>
2955
2956         * NEWS: Add entry.
2957         * infcmd.c (print_return_value_1): Handle finish_print
2958         option.
2959         (show_print_finish): New function.
2960         (_initialize_infcmd): Add "set/show print finish" commands.
2961         * valprint.c (user_print_options): Initialize new member.
2962         * valprint.h (struct value_print_options) <finish_print>: New
2963         member.
2964
2965 2019-05-28  Tom Tromey  <tromey@adacore.com>
2966
2967         * ada-lang.c (ada_remove_Xbn_suffix)
2968         (find_old_style_renaming_symbol)
2969         (parse_old_style_renaming): Remove.
2970         (ada_find_renaming_symbol): Don't call
2971         find_old_style_renaming_symbol.
2972         (ada_is_renaming_symbol): Rename from
2973         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2974         bool.  Now static.
2975         (ada_read_var_value): Update and simplify.
2976         * ada-exp.y (write_var_or_type): Remove old code.
2977
2978 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2979
2980         * event-top.c: Remove include comment.
2981         * inflow.c (class scoped_ignore_sigttou): Move from here...
2982         * inflow.h (class scoped_ignore_sigttou): ...to here.
2983         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2984         * top.c:  Remove include comment.
2985
2986 2019-05-27  Tom Tromey  <tom@tromey.com>
2987
2988         * NEWS: Fix typo.
2989
2990 2019-05-22  Tom Tromey  <tromey@adacore.com>
2991
2992         * target.c (target_follow_exec): Constify parameter.
2993         * target-delegates.c: Rebuild.
2994         * remote.c (remote_target::follow_exec): Constify parameter.
2995         * infrun.c (follow_exec): Constify parameter.
2996         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2997         (target_follow_exec): Likewise.
2998
2999 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3000
3001         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3002         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3003
3004 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3005
3006         * NEWS: Add debugredirect and testsuite sections.
3007
3008 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3009
3010         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3011         target descriptions using exclusively floating point register name
3012         aliases.
3013
3014 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3015
3016         PR gdb/18644:
3017         * f-lang.c (build_fortran_types): Handle the case where
3018         gdbarch_floatformat_for_type returns a nullptr.
3019
3020 2019-05-21  Tom de Vries  <tdevries@suse.de>
3021
3022         PR cli/24587
3023         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3024
3025 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3026
3027         PR gdb/18644:
3028         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3029         16-byte floats.
3030         * i386-tdep.c (i386_floatformat_for_type): Use
3031         floatformats_ia64_quad for the 16-byte floating point component
3032         within a fortran 32-byte complex number.
3033
3034 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3035
3036         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3037         delete default constructor.
3038         (find_partial_die): Update to return const struct.
3039         (partial_die_parent_scope): Move variable declaration into scope
3040         of its use and change its type to auto.
3041         (guess_partial_die_structure_name): Likewise.
3042         (partial_die_info::fixup): Likewise.
3043
3044 2019-05-17  Tom Tromey  <tromey@adacore.com>
3045
3046         * source.c (find_and_open_source): Remove cast.
3047
3048 2019-05-17  Tom Tromey  <tromey@adacore.com>
3049
3050         * annotate.c (annotate_source): Make "filename" const.
3051         * annotate.h (annotate_source): Use const.
3052
3053 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3054
3055         * disasm.c (set_disassembler_options): Send errors to stderr.
3056
3057 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3058
3059         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3060         (cli_interp_base::set_logging): Check debug_redirect.
3061         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3062         * cli/cli-logging.c (debug_redirect): Add static variable.
3063         (pop_output_files): Add default param.
3064         (handle_redirections): Print debug setting.
3065         (show_logging_command): Likewise.
3066         (_initialize_cli_logging): Add debugredirect command.
3067         * interps.c (current_interp_set_logging): Add debug_redirect
3068         parameter.
3069         * interps.h (set_logging): Add debug_redirect parameter.
3070         (current_interp_set_logging): Likewise.
3071         * mi/mi-common.h: Likewise.
3072         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3073
3074 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3075             Tom Tromey  <tromey@adacore.com>
3076
3077         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3078         directly.
3079         * cli/cli-interp.h (make_logging_output): Remove declaration.
3080         * cli/cli-logging.c (make_logging_output): Remove function.
3081         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3082         directly.
3083         * ui-file.c (tee_file::tee_file): Remove bools.
3084         (tee_file::~tee_file): Remove deletes.
3085         * ui-file.h (tee_file): Remove bools.
3086
3087 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3088
3089         * mi/mi-cmds.h (mi_cmd_complete): New function.
3090         * mi/mi-main.c (mi_cmd_complete): Likewise.
3091         * mi/mi-cmds.c: Define new MI command -complete.
3092         * NEWS: Mention new -complete command.
3093
3094 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3095
3096         * completer.h (complete): New function.
3097         * completer.c (complete): Likewise.
3098         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3099         function defined in completer.h.
3100
3101 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3102
3103         * MAINTAINERS (Write After Approval): Add myself.
3104
3105 2019-05-17  Tom de Vries  <tdevries@suse.de>
3106
3107         PR gdb/24094
3108         * dwarf2read.c (struct cu_partial_die_info): New struct.
3109         (find_partial_die): Return cu_partial_die_info.
3110         (partial_die_parent_scope, guess_partial_die_structure_name)
3111         (partial_die_info::fixup): Handle new return type of find_partial_die.
3112
3113 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3114
3115         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3116         "std::string", simplifying the algorithm.
3117
3118 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3119
3120         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3121         (stap_static_probe_ops::get_probes): Likewise.
3122
3123 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3124
3125         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3126         '-')" and "else if".
3127         (stap_parse_single_operand): Join checks for
3128         "gdbarch_stap_parse_special_token_p" and
3129         "gdbarch_stap_parse_special_token" in the same "if" statement.
3130         Invert check when verifying for operation on register
3131         displacement.
3132
3133 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3134
3135         * stap-probe.c (stap_get_opcode): Update comment.
3136         (stap_get_expected_argument_type): Likewise.
3137         (handle_stap_probe): Likewise.
3138
3139 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3140
3141         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3142         return type to 'bool'.  Adjust comment.  Use 'bool' when
3143         appropriate.
3144         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3145         * stap-probe.c (stap_parse_argument_1): Likewise.
3146         (stap_is_operator): Likewise.
3147         (stap_is_generic_prefix): Likewise.
3148         (stap_is_register_prefix): Likewise.
3149         (stap_is_register_indirection_prefix): Likewise.
3150         (stap_is_integer_prefix): Likewise.
3151         (stap_generic_check_suffix): Likewise.
3152         (stap_check_integer_suffix): Likewise.
3153         (stap_check_register_suffix): Likewise.
3154         (stap_check_register_indirection_suffix): Likewise.
3155         (stap_parse_register_operand): Likewise.
3156         (stap_parse_single_operand): Likewise.
3157         (stap_parse_argument_1): Likewise.
3158         (stap_probe::get_argument_count): Likewise.
3159         (stap_is_operator): Likewise.
3160
3161 2019-05-16  Tom Tromey  <tromey@adacore.com>
3162
3163         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3164         keyword to foreach.
3165
3166 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3167
3168         * linux-thread-db.c (try_thread_db_load_1): Change return type
3169         to bool.
3170         (try_thread_db_load): Likewise.
3171         (try_thread_db_load_from_pdir_1): Likewise.
3172         (try_thread_db_load_from_pdir): Likewise.
3173         (try_thread_db_load_from_sdir): Likewise.
3174         (try_thread_db_load_from_dir): Likewise.
3175         (thread_db_load_search): Likewise.
3176         (has_libpthread): Likewise.
3177         (thread_db_load): Likewise.
3178
3179 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3180
3181         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3182         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3183         NULL, and complain/return if that's the case.
3184
3185 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3186
3187         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3188         (advance, posn, abstract_read_memory): New functions.
3189         [struct mem_read_abstraction]: New struct.
3190         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3191
3192 2019-05-14  Tom Tromey  <tromey@adacore.com>
3193
3194         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3195         value is not lval_memory.
3196
3197 2019-05-14  Tom Tromey  <tromey@adacore.com>
3198
3199         * solib.c (info_sharedlibrary_command): Style the file name.
3200
3201 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3202
3203         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3204         (aarch64_vnv_type): Likewise.
3205         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3206         * common/tdesc.c: Likewise.
3207         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3208         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3209         * features/aarch64-fpu.xml: Add ieee half view.
3210         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3211         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3212         * gdbtypes.h (struct builtin_type): Likewise.
3213         (struct objfile_type): Likewise.
3214
3215 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3216
3217         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3218         typo.
3219         * location.h (string_to_event_location): Likewise.
3220
3221 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3222
3223         GDB 8.3 released.
3224
3225 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3226
3227         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3228         New variable declaration.
3229         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3230         New variable.
3231         (print_one_breakpoint): Use ui_out::test_flags and new global
3232         variable to compute use_fixed_output.
3233         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3234         Remove.
3235         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3236         (mi_multi_location_breakpoint_output_fixed): Remove.
3237         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3238         new variable.
3239         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3240         fix_multi_location_breakpoint_output flag if version >= 3.
3241         * ui-out.h (enum ui_out_flag)
3242         <fix_multi_location_breakpoint_output>: New enumerator.
3243
3244 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3245
3246         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3247
3248 2019-05-10  Tom Tromey  <tromey@adacore.com>
3249
3250         * ada-lang.c (catch_ada_completer): New function.
3251         (_initialize_ada_language): Use it.
3252
3253 2019-05-10  Tom Tromey  <tromey@adacore.com>
3254
3255         * thread.c (print_thread_info): Make "requested_threads" const.
3256         * gdbthread.h (print_thread_info): Make "requested_threads"
3257         const.
3258         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3259         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3260
3261 2019-05-08  Tom Tromey  <tom@tromey.com>
3262
3263         * gdbtypes.c (objfile_type_data): Change type.
3264         (objfile_type, _initialize_gdbtypes): Update.
3265
3266 2019-05-08  Tom Tromey  <tom@tromey.com>
3267
3268         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3269         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3270         (_initialize_dwarf2_frame): Update.
3271
3272 2019-05-08  Tom Tromey  <tom@tromey.com>
3273
3274         * objc-lang.c (objc_objfile_data): Change type.
3275         (find_methods): Update.
3276         (_initialize_objc_lang): Remove.
3277
3278 2019-05-08  Tom Tromey  <tom@tromey.com>
3279
3280         * stabsread.c (rs6000_builtin_type_data): Change type.
3281         (rs6000_builtin_type, _initialize_stabsread): Update.
3282
3283 2019-05-08  Tom Tromey  <tom@tromey.com>
3284
3285         * mips-tdep.c (mips_pdr_data): Remove.
3286         (_initialize_mips_tdep): Update.
3287
3288 2019-05-08  Tom Tromey  <tom@tromey.com>
3289
3290         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3291         (hppa_init_objfile_priv_data, read_unwind_info)
3292         (find_unwind_entry, _initialize_hppa_tdep): Update.
3293
3294 2019-05-08  Tom Tromey  <tom@tromey.com>
3295
3296         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3297         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3298         on obstack.
3299         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3300
3301 2019-05-08  Tom Tromey  <tom@tromey.com>
3302
3303         * mdebugread.c (basic_type_data): Change type.
3304         (basic_type, _initialize_mdebugread): Update.
3305
3306 2019-05-08  Tom Tromey  <tom@tromey.com>
3307
3308         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3309
3310 2019-05-08  Tom Tromey  <tom@tromey.com>
3311
3312         * nto-tdep.c (nto_inferior_data_reg): Change type.
3313         (nto_inferior_data): Update.
3314         (nto_inferior_data_cleanup, nto_new_inferior_data)
3315         (_initialize_nto_tdep): Remove.
3316         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3317
3318 2019-05-08  Tom Tromey  <tom@tromey.com>
3319
3320         * ada-lang.c (struct ada_inferior_data): Add initializers.
3321         (ada_inferior_data): Change type.
3322         (ada_inferior_data_cleanup): Remove.
3323         (get_ada_inferior_data, ada_inferior_exit)
3324         (struct ada_pspace_data): Add initializers, destructor.
3325         (ada_pspace_data_handle): Change type.
3326         (get_ada_pspace_data): Update.
3327         (ada_pspace_data_cleanup): Remove.
3328
3329 2019-05-08  Tom Tromey  <tom@tromey.com>
3330
3331         * coffread.c (struct coff_symfile_info): Add initializers.
3332         (coff_objfile_data_key): Move lower.  Change type.
3333         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3334         Update.
3335         (coff_free_info): Remove.
3336
3337 2019-05-08  Tom Tromey  <tom@tromey.com>
3338
3339         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3340         (fbsd_pspace_data_handle): Move lower.  Change type.
3341         (get_fbsd_pspace_data): Update.
3342         (fbsd_pspace_data_cleanup): Remove.
3343         (_initialize_fbsd_tdep): Update.
3344
3345 2019-05-08  Tom Tromey  <tom@tromey.com>
3346
3347         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3348         (get_ada_tasks_pspace_data): Update.
3349         (ada_tasks_pspace_data_cleanup): Remove.
3350         (_initialize_tasks): Update.
3351         (ada_tasks_inferior_data_handle): Change type.
3352         (get_ada_tasks_inferior_data): Update.
3353         (ada_tasks_inferior_data_cleanup): Remove.
3354         (struct ada_tasks_pspace_data): Add initializers.
3355
3356 2019-05-08  Tom Tromey  <tom@tromey.com>
3357
3358         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3359         * symfile-debug.c (debug_sym_get_probes): Change type.
3360         * stap-probe.c (handle_stap_probe):
3361         (stap_static_probe_ops::get_probes): Change type.
3362         * probe.h (class static_probe_ops) <get_probes>: Change type.
3363         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3364         (parse_probes_in_pspace): Update.
3365         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3366         Update.
3367         (any_static_probe_ops::get_probes): Change type.
3368         * elfread.c (elfread_data): New typedef.
3369         (probe_key): Change type.
3370         (elf_get_probes): Likewise.  Update.
3371         (probe_key_free): Remove.
3372         (_initialize_elfread): Update.
3373         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3374         Change type.
3375         (dtrace_process_dof_probe, dtrace_process_dof)
3376         (dtrace_static_probe_ops::get_probe): Change type.
3377
3378 2019-05-08  Tom Tromey  <tom@tromey.com>
3379
3380         * xcoffread.c (struct xcoff_symfile_info): Rename from
3381         coff_symfile_info.  Add initializers.
3382         (xcoff_objfile_data_key): Move lower.  Change type.
3383         (XCOFF_DATA): Rewrite.
3384         (xcoff_free_info): Remove.
3385         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3386         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3387         (xcoff_initial_scan): Update.
3388
3389 2019-05-08  Tom Tromey  <tom@tromey.com>
3390
3391         * solib-svr4.c (struct svr4_info): Add initializers and
3392         destructor.
3393         <probes_table>: Now an htab_up.
3394         (solib_svr4_pspace_data): Change type.
3395         (free_probes_table): Simplify.
3396         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3397         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3398         (probes_table_remove_objfile_probes, register_solib_event_probe)
3399         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3400         (_initialize_svr4_solib): Update.
3401
3402 2019-05-08  Tom Tromey  <tom@tromey.com>
3403
3404         * remote.c (remote_pspace_data): Change type.
3405         (remote_pspace_data_cleanup): Remove.
3406         (get_remote_exec_file, set_pspace_remote_exec_file)
3407         (_initialize_remote): Update.
3408
3409 2019-05-08  Tom Tromey  <tom@tromey.com>
3410
3411         * breakpoint.c (breakpoint_objfile_key): Change type.
3412         (get_breakpoint_objfile_data): Update.
3413         (free_breakpoint_objfile_data): Remove.
3414         (_initialize_breakpoint): Update.
3415
3416 2019-05-08  Tom Tromey  <tom@tromey.com>
3417
3418         * linux-tdep.c (struct linux_info): Add initializers.
3419         (linux_inferior_data): Move.  Change type.
3420         (invalidate_linux_cache_inf): Update.
3421         (linux_inferior_data_cleanup): Remove.
3422         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3423
3424 2019-05-08  Tom Tromey  <tom@tromey.com>
3425
3426         * auxv.c (auxv_inferior_data): Move.  Change type.
3427         (auxv_inferior_data_cleanup): Remove.
3428         (invalidate_auxv_cache_inf): Rewrite.
3429         (get_auxv_inferior_data, _initialize_auxv): Update.
3430
3431 2019-05-08  Tom Tromey  <tom@tromey.com>
3432
3433         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3434         (symfile_debug_objfile_data_key): Change type.
3435         (symfile_debug_installed, debug_qf_has_symbols)
3436         (debug_qf_find_last_source_symtab)
3437         (debug_qf_forget_cached_source_info)
3438         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3439         (debug_qf_print_stats, debug_qf_dump)
3440         (debug_qf_expand_symtabs_for_function)
3441         (debug_qf_expand_all_symtabs)
3442         (debug_qf_expand_symtabs_with_fullname)
3443         (debug_qf_map_matching_symbols)
3444         (debug_qf_expand_symtabs_matching)
3445         (debug_qf_find_pc_sect_compunit_symtab)
3446         (debug_qf_map_symbol_filenames)
3447         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3448         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3449         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3450         (debug_sym_read_linetable, debug_sym_relocate): Update.
3451         (symfile_debug_free_objfile): Remove.
3452         (install_symfile_debug_logging, _initialize_symfile_debug):
3453         Update.
3454
3455 2019-05-08  Tom Tromey  <tom@tromey.com>
3456
3457         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3458         allocate_on_obstack.
3459         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3460         (get_dwarf2_per_objfile): Update.
3461         (set_dwarf2_per_objfile): Remove.
3462         (dwarf2_has_info, dwarf2_get_section_info): Update.
3463         (dwarf2_free_objfile): Remove.
3464         (_initialize_dwarf2_read): Update.
3465
3466 2019-05-08  Tom Tromey  <tom@tromey.com>
3467
3468         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3469         initializers.
3470         <unsupported_script_warning_printed,
3471         script_not_found_warning_printed>: Now bool.
3472         (auto_load_pspace_data): Change type.
3473         (~auto_load_pspace_info): Rename from
3474         auto_load_pspace_data_cleanup.
3475         (get_auto_load_pspace_data, init_loaded_scripts_info)
3476         (clear_section_scripts, maybe_print_unsupported_script_warning)
3477         (maybe_print_script_not_found_warning, _initialize_auto_load):
3478         Update.
3479
3480 2019-05-08  Tom Tromey  <tom@tromey.com>
3481
3482         * objfiles.c (objfile_pspace_info): Add destructor and
3483         initializers.
3484         (objfiles_pspace_data): Change type.
3485         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3486         (get_objfile_pspace_data): Update.
3487         (objfiles_bfd_data): Change type.
3488         (get_objfile_bfd_data): Update.
3489         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3490
3491 2019-05-08  Tom Tromey  <tom@tromey.com>
3492
3493         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3494         Change type.
3495         (get_catch_syscall_inferior_data): Update.
3496         (catch_syscall_inferior_data_cleanup): Remove.
3497         (_initialize_break_catch_syscall): Update.
3498
3499 2019-05-08  Tom Tromey  <tom@tromey.com>
3500
3501         * inflow.c (struct terminal_info): Add destructor and
3502         initializers.
3503         (inflow_inferior_data): Change type.
3504         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3505         (get_inflow_inferior_data, inflow_inferior_exit)
3506         (swap_terminal_info, _initialize_inflow): Update.
3507
3508 2019-05-08  Tom Tromey  <tom@tromey.com>
3509
3510         * target-dcache.c (target_dcache_cleanup): Remove.
3511         (target_dcache_aspace_key): Change type.
3512         (target_dcache_init_p, target_dcache_invalidate)
3513         (target_dcache_get, target_dcache_get_or_init)
3514         (_initialize_target_dcache): Update.
3515         * dcache.h (struct dcache_deleter): New.
3516
3517 2019-05-08  Tom Tromey  <tom@tromey.com>
3518
3519         * symtab.c (struct symbol_cache): Add destructor and
3520         initializers.
3521         (symbol_cache_key): Move.  Change type.
3522         (make_symbol_cache, free_symbol_cache): Remove.
3523         (get_symbol_cache): Update.
3524         (symbol_cache_cleanup): Remove.
3525         (ALL_PSPACES, symbol_cache_flush)
3526         (maintenance_print_symbol_cache)
3527         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3528         Update.
3529
3530 2019-05-08  Tom Tromey  <tom@tromey.com>
3531
3532         * symtab.c (struct main_info): Add destructor and initializers.
3533         (main_progspace_key): Move.  Change type.
3534         (get_main_info): Update.
3535         (main_info_cleanup): Remove.
3536         (_initialize_symtab): Update.
3537
3538 2019-05-08  Tom Tromey  <tom@tromey.com>
3539
3540         * registry.h (DECLARE_REGISTRY): Define the _key class.
3541
3542 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3543
3544         * NEWS: Merge two 'New commands' sections.
3545
3546 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3547
3548         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3549         parameter and use Ada language definition instead.
3550         (ada_val_print_ptr): Remove unused language parameter.
3551         (ada_val_print_num): Remove language parameter and use Ada language
3552         definition instead.
3553         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3554         parameter.
3555         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3556         parameter and use Ada language definition instead.
3557         (ada_val_print_1): Update all ada_val_print_xxx calls.
3558         Remove language parameter.
3559         (ada_val_print): Update ada_val_print_1 call.
3560
3561 2019-05-08  Tom Tromey  <tromey@adacore.com>
3562
3563         * remote.c (remote_hw_watchpoint_limit)
3564         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3565         Now static.
3566
3567 2019-05-08  Tom Tromey  <tromey@adacore.com>
3568
3569         * maint.c (_initialize_maint_cmds): Move initialization code to
3570         remote.c.
3571         (watchdog, show_watchdog): Move to remote.c.
3572         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3573         "watchdog" static.
3574         (_initialize_remote): Move initialization code from maint.c.
3575         * defs.h (watchdog): Don't declare.
3576
3577 2019-05-08  Tom Tromey  <tromey@adacore.com>
3578
3579         * tui/tui-interp.c: Include main.h.
3580         * interps.c: Include main.h.
3581         * main.h (interpreter_p): Declare.
3582         * defs.h (interpreter_p): Don't declare.
3583
3584 2019-05-08  Tom Tromey  <tromey@adacore.com>
3585
3586         * dwarf2loc.c: Include dwarf2read.h.
3587         * defs.h (read_unsigned_leb128): Don't declare.
3588         * dwarf2read.h (read_unsigned_leb128): Declare.
3589
3590 2019-05-08  Tom Tromey  <tromey@adacore.com>
3591
3592         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3593         method.
3594
3595 2019-05-08  Tom Tromey  <tromey@adacore.com>
3596
3597         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3598         when no wrap column is set.
3599
3600 2019-05-08  Tom Tromey  <tromey@adacore.com>
3601
3602         * c-lang.c (c_get_string): Handle non-C-style arrays.
3603
3604 2019-05-08  Tom Tromey  <tromey@adacore.com>
3605
3606         * typeprint.c (print_offset_data::update): Print the bit offset,
3607         not the number of bits remaining.
3608
3609 2019-05-08  Tom Tromey  <tromey@adacore.com>
3610
3611         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3612         padding at end of comment.
3613
3614 2019-05-08  Tom Tromey  <tromey@adacore.com>
3615
3616         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3617         Compare main types.
3618
3619 2019-05-06  Tom Tromey  <tom@tromey.com>
3620
3621         * common/scoped_mmap.c: Include common-defs.h.
3622         * common/scoped_mmap.h: Don't include config.h.
3623
3624 2019-05-04  Tom Tromey  <tom@tromey.com>
3625
3626         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3627         (struct aarch64_call_info): Add initializers.
3628         <si>: Now a std::vector.
3629         (pass_on_stack, aarch64_push_dummy_call): Update.
3630
3631 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3632             Tom Tromey  <tom@tromey.com>
3633
3634         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3635         (ppc_threads): Now a std::vector.  Now static.
3636         (hwdebug_find_thread_points_by_tid)
3637         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3638         Update.
3639
3640 2019-05-04  Tom Tromey  <tom@tromey.com>
3641
3642         * arc-tdep.c (arc_tdesc_init): Return bool.
3643
3644 2019-05-04  Tom Tromey  <tom@tromey.com>
3645
3646         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3647         Use gdb_assert_not_reached.
3648
3649 2019-05-04  Tom Tromey  <tom@tromey.com>
3650
3651         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3652         "false".
3653
3654 2019-05-04  Tom Tromey  <tom@tromey.com>
3655
3656         * arc-tdep.c (arc_tdesc_init): Use bool.
3657
3658 2019-05-04  Tom Tromey  <tom@tromey.com>
3659
3660         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3661
3662 2019-05-04  Tom Tromey  <tom@tromey.com>
3663
3664         * cli/cli-cmds.c (valid_command_p): Return bool.
3665
3666 2019-05-04  Tom Tromey  <tom@tromey.com>
3667
3668         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3669         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3670
3671 2019-05-04  Raul Tambre  <raul@tambre.ee>
3672
3673         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3674         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3675         operator for comparison.
3676
3677 2019-05-04  Tom Tromey  <tom@tromey.com>
3678
3679         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3680         (lookup_partial_symbol, print_partial_symbols)
3681         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3682         (psymbol_compare): Update.
3683         (add_psymbol_to_bcache): Clear the entire psymbol.
3684         (maintenance_check_psymtabs): Update.
3685         * psympriv.h (struct partial_symbol): Don't derive from
3686         general_symbol_info.
3687         <obj_section, unrelocated_address, address,
3688         set_unrelocated_address>: Update.
3689         <ginfo>: New member.
3690         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3691         (debug_names::write_psymbols): Update.
3692
3693 2019-05-04  Tom de Vries  <tdevries@suse.de>
3694
3695         * contrib/cc-with-tweaks.sh: Support -n arg.
3696
3697 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3698
3699         * corelow.c (core_target::detach): Ensure frame cache and
3700         register caches are cleared.
3701         inferior.c (exit_inferior_1): Likewise.
3702
3703 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3704             Tom Tromey  <tom@tromey.com>
3705
3706         * dictionary.c (collate_pending_symbols_by_language): Remove
3707         "struct" from foreach.
3708         * symtab.c (lookup_global_symbol_from_objfile)
3709         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3710         foreach.
3711         * ser-tcp.c (net_open): Remove "struct" from foreach.
3712         * objfiles.c (objfile_relocate, objfile_rebase)
3713         (objfile_has_symbols): Remove "struct" from foreach.
3714         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3715         from foreach.
3716         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3717         foreach.
3718         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3719         "struct" from foreach.
3720         * ada-lang.c (create_excep_cond_exprs)
3721         (ada_exception_catchpoint_cond_string): Remove "struct" from
3722         foreach.
3723
3724 2019-05-03  Tom Tromey  <tromey@adacore.com>
3725
3726         * ada-exp.y (convert_char_literal): Check suffix of each
3727         enumerator.
3728
3729 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3730
3731         PR ada/21406:
3732         * ada-exp.y (yywrap): Don't define.
3733         * ada-lex.l (%option): Add noyywrap
3734         (yywrap): Remove.
3735
3736 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3737
3738         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3739         _WIN32_WINNT to the XP level, unless already defined to a higher
3740         level.
3741
3742         * unittests/parse-connection-spec-selftests.c:
3743         * ser-tcp.c:
3744         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3745         override.
3746
3747         * symfile.c (find_separate_debug_file): Remove colon from the
3748         drive spec of DOS/Windows file names of the target, so that the
3749         file name produced from DEBUGDIR and the target's directory will
3750         be valid on DOS/Windows systems.
3751
3752 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3753
3754         * rust-lang.c (val_print_struct): Handle printing structures
3755         containing strings.
3756
3757 2019-05-02  Tom Tromey  <tromey@adacore.com>
3758
3759         * valarith.c (_initialize_valarith): Remove.
3760
3761 2019-05-01  Tom Tromey  <tromey@adacore.com>
3762
3763         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3764         bitfields.
3765
3766 2019-05-01  Tom Tromey  <tromey@adacore.com>
3767
3768         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3769         for big-endian copies.
3770
3771 2019-04-30  Ali Tamur  <tamur@google.com>
3772         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3773         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3774         (read_3_bytes): New function.
3775
3776 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3777
3778         * windows-nat.c (main_thread_id): Delete.
3779         (handle_output_debug_string): Replace main_thread_id by
3780         current_event.dwThreadId.
3781         (fake_create_process): Likewise.
3782         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3783         Do not set main_thread_id.
3784         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3785         current_event.dwThreadId.
3786         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3787
3788 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3789
3790         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3791         Use current_event.dwThreadId instead of main_thread_id.
3792
3793 2019-04-30  Tom Tromey  <tromey@adacore.com>
3794
3795         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3796         (create_excep_cond_exprs): Iterate over program spaces.
3797         (ada_exception_catchpoint_cond_string): Examine all minimal
3798         symbols for exception types.
3799
3800 2019-04-30  Tom Tromey  <tromey@adacore.com>
3801
3802         PR c++/24470:
3803         * dwarf2read.c (process_structure_scope): Handle case where type
3804         has template parameters but no symbol was created.
3805
3806 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3807             Chris January  <chris.january@arm.com>
3808
3809         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3810         qualifier.
3811         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3812
3813 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3814
3815         * f-typeprint.c (f_print_type): Update rules for printing
3816         whitespace.
3817         (f_type_print_varspec_suffix): Likewise.
3818
3819 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3820             Chris January  <chris.january@arm.com>
3821
3822         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3823         function arguments.
3824
3825 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3826
3827         * f-lang.c (build_fortran_types): Change name of void type to
3828         lower case.
3829         * f-typeprint.c (f_type_print_base): Print the name of the void
3830         type, rather than a fixed string.
3831         * f-valprint.c (f_decorations): Use lower case void string.
3832
3833 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3834             Chris January  <chris.january@arm.com>
3835
3836         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3837         types for Fortran.
3838
3839 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3840             Chris January  <chris.january@arm.com>
3841             David Lecomber  <david.lecomber@arm.com>
3842
3843         * f-exp.y (BINOP_INTRINSIC): New token.
3844         (exp): New parser rule handling BINOP_INTRINSIC.
3845         (f77_keywords): Add new builtin procedures.
3846         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3847         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3848         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3849         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3850         (print_unop_subexp_f): New function.
3851         (print_binop_subexp_f): New function.
3852         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3853         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3854         (dump_subexp_body_f): Likewise.
3855         (operator_check_f): Likewise.
3856         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3857         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3858
3859 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3860
3861         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3862         UNOP_KIND.
3863         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3864         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3865         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3866         (operator_length_f): New fuction.
3867         (print_subexp_f): New function.
3868         (op_name_f): New function.
3869         (dump_subexp_body_f): New function.
3870         (operator_check_f): New function.
3871         (exp_descriptor_f): Replace standard expression handling functions
3872         with new functions.
3873         * gdb/fortran-operator.def: New file.
3874         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3875         * gdb/std-operator.def: Remove UNOP_KIND.
3876
3877 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3878
3879         * std-operator.def: Remove unbalanced, stray double quote
3880         character.
3881
3882 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3883             Chris January  <chris.january@arm.com>
3884             Daniel Everett  <daniel.everett@arm.com>
3885             Nick Forrington  <nick.forrington@arm.com>
3886             Richard Bunt  <richard.bunt@arm.com>
3887
3888         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3889         of depth when printing anonymous structs or unions.
3890         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3891         Don't print either the top-level value, or the children if the
3892         max-depth is exceeded.
3893         (ppscm_print_children): When printing the key of a map, allow one
3894         extra level of depth.
3895         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3896         print either the top-level value, or the children if the max-depth
3897         is exceeded.
3898         (print_children): When printing the key of a map, allow one extra
3899         level of depth.
3900         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3901         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3902         (user_print_options): Initialise max_depth field.
3903         (val_print_scalar_or_string_type_p): New function.
3904         (val_print): Check to see if the max depth has been reached.
3905         (val_print_check_max_depth): Define new function.
3906         (show_print_max_depth): New function.
3907         (_initialize_valprint): Add 'print max-depth' option.
3908         * valprint.h (struct value_print_options) <max_depth>: New field.
3909         (val_print_check_max_depth): Declare new function.
3910         * NEWS: Document new feature.
3911
3912 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3913
3914         * ada-lang.c (ada_language_defn): Initialise new field.
3915         * c-lang.c (c_is_string_type_p): New function.
3916         (c_language_defn): Initialise new field.
3917         (cplus_language_defn): Initialise new field.
3918         (asm_language_defn): Initialise new field.
3919         (minimal_language_defn): Initialise new field.
3920         * c-lang.h (c_is_string_type_p): Declare new function.
3921         * d-lang.c (d_language_defn): Initialise new field.
3922         * f-lang.c (f_is_string_type_p): New function.
3923         (f_language_defn): Initialise new field.
3924         * go-lang.c (go_is_string_type_p): New function.
3925         (go_language_defn): Initialise new field.
3926         * language.c (default_is_string_type_p): New function.
3927         (unknown_language_defn): Initialise new field.
3928         (auto_language_defn): Initialise new field.
3929         * language.h (struct language_defn) <la_is_string_type_p>: New
3930         member variable.
3931         (default_is_string_type_p): Declare new function.
3932         * m2-lang.c (m2_language_defn): Initialise new field.
3933         * objc-lang.c (objc_language_defn): Initialise new field.
3934         * opencl-lang.c (opencl_language_defn): Initialise new field.
3935         * p-lang.c (pascal_is_string_type_p): New function.
3936         (pascal_language_defn): Initialise new field.
3937         * rust-lang.c (rust_is_string_type_p): New function.
3938         (rust_language_defn): Initialise new field.
3939
3940 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3941
3942         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3943         New field.
3944         * ada-lang.c (ada_language_defn): Initialise new field.
3945         * c-lang.c (c_language_defn): Likewise.
3946         (cplus_language_defn): Likewise.
3947         (asm_language_defn): Likewise.
3948         (minimal_language_defn): Likewise.
3949         * d-lang.c (d_language_defn): Likewise.
3950         * f-lang.c (f_language_defn): Likewise.
3951         * go-lang.c (go_language_defn): Likewise.
3952         * language.c (unknown_language_defn): Likewise.
3953         (auto_language_defn): Likewise.
3954         * m2-lang.c (m2_language_defn): Likewise.
3955         * objc-lang.c (objc_language_defn): Likewise.
3956         * opencl-lang.c (opencl_language_defn): Likewise.
3957         * p-lang.c (pascal_language_defn): Likewise.
3958         * rust-lang.c (rust_language_defn): Likewise.
3959
3960 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3961
3962         * ada-lang.c (ada_is_character_type): Change return type to bool.
3963         (ada_is_string_type): Likewise.
3964         * ada-lang.h (ada_is_character_type): Update declaration
3965         (ada_is_string_type): Likewise.
3966
3967 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3968
3969         Support style in 'frame|thread apply'
3970
3971         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3972         * record.c (record_start, record_stop): Update callers of
3973         execute_command_to_string with false.
3974         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3975         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3976         methods.
3977         (class string_file): New constructor with term_out parameter.
3978         Override methods term_out and can_emit_style_escape.  New member
3979         term_out.
3980         (class stdio_file): Override can_emit_style_escape.
3981         (class tee_file): Override term_out and can_emit_style_escape.
3982         * utils.h (can_emit_style_escape): Remove.
3983         * utils.c (can_emit_style_escape): Likewise.
3984         Update all callers of can_emit_style_escape (SOMESTREAM) to
3985         SOMESTREAM->can_emit_style_escape.
3986         * source-cache.c (source_cache::get_source_lines): Likewise.
3987         * stack.c (frame_apply_command_count): Call execute_command_to_string
3988         passing the term_out characteristic of the current gdb_stdout.
3989         * thread.c (thr_try_catch_cmd): Likewise.
3990         * top.c (execute_command_to_string): pass term_out parameter
3991         to construct the string_file for the command output.
3992         * ui-file.c (term_cli_styling): New function (most code moved
3993         from utils.c can_emit_style_escape).
3994         (string_file::string_file, string_file::can_emit_style_escape,
3995         stdio_file::can_emit_style_escape, tee_file::term_out,
3996         tee_file::can_emit_style_escape): New functions.
3997
3998 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3999
4000         * NEWS: Mention the new set|show may-call-functions.
4001         * infcall.c (may_call_functions_p): New variable.
4002         (show_may_call_functions_p): New function.
4003         (call_function_by_hand_dummy): Throws an error if not
4004         may-call-functions.
4005         (_initialize_infcall): Call add_setshow_boolean_cmd for
4006         may-call-functions.
4007
4008 2019-04-25  Keith Seitz  <keiths@redhat.com>
4009
4010         PR c++/24367
4011         * cp-support.c (inspect_type): Don't attempt substitutions
4012         of symbol with the same name.
4013
4014 2019-04-25  Tom Tromey  <tromey@adacore.com>
4015
4016         PR gdb/24475:
4017         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4018         static.
4019
4020 2019-04-25  Tom Tromey  <tromey@adacore.com>
4021
4022         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4023         rvalue reference.
4024         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4025         (gdb_xml_parser::parse): Use std::move.
4026         * python/python-internal.h (gdbpy_convert_exception): Take a const
4027         reference.
4028         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4029         std::move.
4030         * python/py-utils.c (gdbpy_convert_exception): Take a const
4031         reference.
4032         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4033         Use std::move.
4034         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4035         Use std::move.
4036         * mi/mi-main.c (mi_print_exception): Take a const reference.
4037         * main.c (handle_command_errors): Take a const reference.
4038         * linespec.c (parse_linespec): Use std::move.
4039         * infcall.c (run_inferior_call): Use std::move.
4040         (call_function_by_hand_dummy): Use std::move.
4041         * exec.c (try_open_exec_file): Use std::move.
4042         * exceptions.h (exception_print, exception_fprintf)
4043         (exception_print_same): Update.
4044         * exceptions.c (print_exception, exception_print)
4045         (exception_fprintf, exception_print_same): Change parameters to
4046         const reference.
4047         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4048         * common/new-op.c: Use std::move.
4049         * common/common-exceptions.h (struct gdb_exception): Add move
4050         constructor.
4051         (struct gdb_exception_error, struct gdb_exception_quit, struct
4052         gdb_quit_bad_alloc): Change constructor to move constructor.
4053         (throw_exception): Change parameter to rvalue reference.
4054         * common/common-exceptions.c (throw_exception): Take rvalue
4055         reference.
4056         * cli/cli-interp.c (safe_execute_command): Use std::move.
4057         * breakpoint.c (insert_bp_location, location_to_sals): Use
4058         std::move.
4059
4060 2019-04-25  Tom Tromey  <tromey@adacore.com>
4061
4062         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4063         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4064         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4065         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4066         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4067         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4068         guile/scm-value.c: Use unpack.
4069         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4070         gdbscm_gdb_exception.
4071         (gdbscm_throw_gdb_exception): Likewise.
4072         (struct gdbscm_gdb_exception): New.
4073         (unpack): New function.
4074         (gdbscm_wrap): Use unpack.
4075
4076 2019-04-25  Tom Tromey  <tromey@adacore.com>
4077
4078         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4079         (gdb_rl_callback_handler): Use std::move.
4080         * common/common-exceptions.h (struct gdb_exception): Add move
4081         assignment operator.
4082         (throw_exception_sjlj): Change "exception" to const reference.
4083         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4084         (throw_exception_sjlj): Change "exception" to const reference.
4085
4086 2019-04-25  Tom Tromey  <tromey@adacore.com>
4087
4088         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4089         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4090         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4091         Update.
4092         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4093         Update.
4094         * mi/mi-interp.c (mi_interp::exec): Update.
4095         * linespec.c (parse_linespec): Update.
4096         * infcall.c (run_inferior_call): Update.
4097         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4098         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4099         (gdbscm_lookup_global_symbol): Update.
4100         * guile/scm-param.c (gdbscm_parameter_value): Update.
4101         * guile/scm-frame.c (gdbscm_frame_read_register)
4102         (gdbscm_frame_read_var): Update.
4103         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4104         * exec.c (try_open_exec_file): Update.
4105         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4106         (gdb_rl_callback_handler): Update.
4107         * common/common-exceptions.h (exception_none): Don't declare.
4108         * common/common-exceptions.c (exception_none): Don't define.
4109         (struct catcher) <exception>: Update.
4110         * cli/cli-interp.c (safe_execute_command): Update.
4111         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4112
4113 2019-04-25  Ali Tamur  <tamur@google.com>
4114
4115         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4116         (read_attribute_value): Likewise.
4117         (dwarf2_read_addr_index): Update comment.
4118         (read_str_index): Add DW_FORM_strx.
4119         (dwarf2_string_attr): Likewise.
4120         (dwarf2_const_value_attr): Likewise.
4121         (dump_die_shallow): Likewise.
4122         (dwarf2_fetch_constant_bytes): Likewise.
4123         (skip_form_bytes): Likewise.
4124         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4125
4126 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4127
4128         PR corefiles/11608
4129         PR corefiles/18187
4130         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4131         OFFSET.  Verify if current mapping contains an ELF header.
4132         (linux_find_memory_regions_full): Adjust call to
4133         dump_mapping_p.
4134
4135 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4136             Kang Li <kanglictf@gmail.com>
4137
4138         PR gdb/21600
4139
4140         * dwarf2-frame.c (read_initial_length): Be consistent about using
4141         unsigned representation of length.
4142         (decode_frame_entry_1): Likewise.  Check for wraparound of
4143         end pointer as well as buffer overflow.
4144
4145 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4146
4147         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4148         "vq".
4149
4150 2019-04-24  Tom Tromey  <tromey@adacore.com>
4151
4152         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4153
4154 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4155
4156         * s12z-tdep.c (s12z_unwind_pc): Delete.
4157         (s12z_unwind_sp): Delete.
4158         (s12z_gdbarch_init): Don't register deleted functions with
4159         gdbarch.
4160
4161 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4162
4163         * rl78-tdep.c (rl78_unwind_sp): Delete.
4164         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4165
4166 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4167
4168         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4169         (xstormy16_unwind_pc): Delete.
4170         (xstormy16_dummy_id): Delete.
4171         (xstormy16_gdbarch_init): Don't register deleted functions with
4172         gdbarch.
4173
4174 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4175
4176         * vax-tdep.c (vax_unwind_pc): Delete.
4177         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4178
4179 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4180
4181         * v850-tdep.c (v850_unwind_sp): Delete.
4182         (v850_unwind_pc): Delete.
4183         (v850_dummy_id): Delete.
4184         (v850_gdbarch_init): Don't register deleted functions with
4185         gdbarch.
4186
4187 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4188
4189         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4190         (tilegx_unwind_pc): Delete.
4191         (tilegx_unwind_dummy_id): Delete.
4192         (tilegx_gdbarch_init): Don't register deleted functions with
4193         gdbarch.
4194
4195 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4196
4197         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4198         (tic6x_dummy_id): Delete.
4199         (tic6x_gdbarch_init): Don't register deleted functions with
4200         gdbarch.
4201
4202 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4203
4204         * sparc-tdep.c (sparc_unwind_pc): Delete.
4205         (sparc32_gdbarch_init): Don't register deleted function with
4206         gdbarch.
4207
4208 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4209
4210         * sh-tdep.c (sh_unwind_sp): Delete.
4211         (sh_unwind_pc): Delete.
4212         (sh_dummy_id): Delete.
4213         (sh_gdbarch_init): Don't register deleted functions with
4214         gdbarch.
4215
4216 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4217
4218         * score-tdep.c (score_unwind_sp): Delete.
4219         (score_unwind_pc): Delete.
4220         (score_dummy_id): Delete.
4221         (score_gdbarch_init): Don't register deleted functions with
4222         gdbarch.
4223
4224 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4225
4226         * rx-tdep.c (rx_unwind_pc): Delete.
4227         (rx_unwind_sp): Delete.
4228         (rx_dummy_id): Delete.
4229         (rx_gdbarch_init): Don't register deleted functions with
4230         gdbarch.  Update comment.
4231
4232 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4233
4234         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4235         (rs6000_dummy_id): Delete.
4236         (rs6000_gdbarch_init): Don't register deleted functions with
4237         gdbarch.
4238
4239 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4240
4241         * or1k-tdep.c (or1k_dummy_id): Delete.
4242         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4243
4244 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4245
4246         * nios2-tdep.c (nios2_dummy_id): Delete.
4247         (nios2_unwind_sp): Delete.
4248         (nios2_gdbarch_init): Don't register deleted functions with
4249         gdbarch.
4250
4251 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4252
4253         * nds32-tdep.c (nds32_dummy_id): Delete.
4254         (nds32_unwind_pc): Delete.
4255         (nds32_unwind_sp): Delete.
4256         (nds32_gdbarch_init): Don't register deleted functions with
4257         gdbarch.
4258
4259 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4260
4261         * msp430-tdep.c (msp430_unwind_pc): Delete.
4262         (msp430_unwind_sp): Delete.
4263         (msp430_dummy_id): Delete.
4264         (msp430_gdbarch_init): Don't register deleted functions with
4265         gdbarch.
4266
4267 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4268
4269         * moxie-tdep.c (moxie_unwind_sp): Delete.
4270         (moxie_unwind_pc): Delete.
4271         (moxie_dummy_id): Delete.
4272         (moxie_gdbarch_init): Don't register deleted functions with
4273         gdbarch.
4274
4275 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4276
4277         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4278         (mn10300_unwind_pc): Delete.
4279         (mn10300_unwind_sp): Delete.
4280         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4281         mn10300_unwind_sp.
4282         (mn10300_frame_unwind_init): Don't register deleted functions with
4283         gdbarch.
4284
4285 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4286
4287         * mep-tdep.c (mep_unwind_pc): Delete.
4288         (mep_unwind_sp): Delete.
4289         (mep_dummy_id): Delete.
4290         (mep_gdbarch_init): Don't register deleted functions with
4291         gdbarch.
4292
4293 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4294
4295         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4296         (m68hc11_unwind_sp): Delete.
4297         (m68hc11_gdbarch_init): Don't register deleted functions with
4298         gdbarch.
4299
4300 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4301
4302         * m32r-tdep.c (m32r_unwind_sp): Delete.
4303         (m32r_unwind_pc): Delete.
4304         (m32r_dummy_id): Delete.
4305         (m32r_gdbarch_init): Don't register deleted functions with
4306         gdbarch.
4307
4308 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4309
4310         * m32c-tdep.c (m32c_unwind_pc): Delete.
4311         (m32c_unwind_sp): Delete.
4312         (m32c_dummy_id): Delete.
4313         (m32c_gdbarch_init): Don't register deleted functions with
4314         gdbarch.
4315
4316 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4317
4318         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4319         (lm32_unwind_pc): Delete.
4320         (lm32_dummy_id): Delete.
4321         (lm32_gdbarch_init): Don't register deleted functions with
4322         gdbarch.
4323
4324 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4325
4326         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4327         (iq2000_unwind_pc): Delete.
4328         (iq2000_dummy_id): Delete.
4329         (iq2000_gdbarch_init): Don't register deleted functions with
4330         gdbarch.
4331
4332 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4333
4334         * nds32-tdep.c (nds32_type_align): Delete.
4335         (nds32_push_dummy_call): Use type_align instead.
4336
4337 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4338
4339         * arm-tdep.c (arm_type_align): Only handle vector override case.
4340         (arm_push_dummy_call): Use type_align.
4341         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4342
4343 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4344
4345         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4346         case.
4347         (pass_on_stack): Use type_align.
4348         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4349         function.
4350
4351 2019-04-23  Tom Tromey  <tromey@adacore.com>
4352
4353         * dwarf2read.c (line_header::file_name_at): Remove unused
4354         overload.
4355
4356 2019-04-23  Tom de Vries  <tdevries@suse.de>
4357
4358         PR gdb/24438
4359         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4360         invocation.
4361
4362
4363 2019-03-27  Ali Tamur  <tamur@google.com>
4364
4365         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4366         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4367         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4368         (dwarf_expr_context::get_addr_index): Likewise
4369         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4370         (symbol_needs_eval_context::get_addr_index): Likewise
4371         (disassemble_dwarf_expression): Add DW_OP_addrx
4372         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4373         (read_cutu_die_from_dwo): Update comment
4374         (skip_one_die): Add DW_FORM_addrx
4375         (read_attribute_value): Likewise
4376         (var_decode_location): Add DW_OP_addrx
4377         (dwarf2_const_value_attr): Add DW_FORM_addrx
4378         (dump_die_shallow): Likewise
4379         (dwarf2_fetch_constant_bytes): Likewise
4380         (decode_locdesc): Add DW_OP_addrx
4381         (skip_form_bytes): Add DW_FORM_addrx
4382
4383 2019-04-22  Ali Tamur  <tamur@google.com>
4384
4385         * MAINTAINERS (Write After Approval): Add self.
4386
4387 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4388
4389         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4390         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4391         (open_symbol_file_object): Likewise.
4392         (svr4_default_sos): Add info parameter.
4393         (svr4_read_so_list): Likewise.
4394         (svr4_current_sos_direct): Adjust functions calls to pass down
4395         info.
4396         (svr4_current_sos_1): Add info parameter.
4397         (svr4_current_sos): Call get_svr4_info, pass info down to
4398         svr4_current_sos_1.
4399         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4400         get_svr4_info.
4401         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4402         get_svr4_info.
4403         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4404         to get_svr4_info.
4405         (probes_table_remove_objfile_probes): Likewise.
4406         (register_solib_event_probe): Add info parameter.
4407         (solist_update_incremental): Pass info parameter down to
4408         svr4_read_so_list.
4409         (disable_probes_interface): Add info parameter.
4410         (svr4_handle_solib_event): Pass current_program_space to
4411         get_svr4_info.  Adjust disable_probes_interface cleanup.
4412         (svr4_create_probe_breakpoints): Add info parameter, pass it
4413         down to register_solib_event_probe.
4414         (svr4_create_solib_event_breakpoints): Add info parameter,
4415         pass it down to svr4_create_probe_breakpoints.
4416         (enable_break): Pass info down to
4417         svr4_create_solib_event_breakpoints.
4418         (svr4_solib_create_inferior_hook): Pass current_program_space to
4419         get_svr4_info.
4420         (svr4_clear_solib): Likewise.
4421
4422 2019-04-22  Pedro Alves  <palves@redhat.com>
4423
4424         * solib-svr4.c (svr4_free_objfile_observer): New.
4425         (probe_and_action::objfile): New field.
4426         (probes_table_htab_remove_objfile_probes)
4427         (probes_table_remove_objfile_probes): New functions.
4428         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4429         in the new probe_and_action.  Don't store the probe in 'lookup'.
4430         (svr4_create_probe_breakpoints): Pass objfile to
4431         register_solib_event_probe.
4432         (_initialize_svr4_solib): Register a free_objfile observer.
4433
4434 2019-04-19  Tom Tromey  <tom@tromey.com>
4435
4436         * common/queue.h: Remove.
4437
4438 2019-04-19  Tom Tromey  <tom@tromey.com>
4439
4440         * event-loop.c: Don't include "common/queue.h".
4441
4442 2019-04-19  Tom Tromey  <tom@tromey.com>
4443
4444         * remote.c (remote_target): Use delete.
4445         * remote-notif.h: Include <list>, not "common/queue.h".
4446         (notif_client_p): Remove typedef.
4447         (remote_notif_state): Add constructor, destructor, initializer.
4448         <notif_queue>: Now a std::list.
4449         (remote_notif_state_xfree): Don't declare.
4450         * remote-notif.c (remote_notif_process, handle_notification)
4451         (remote_notif_state_allocate): Update.
4452         (~remote_notif_state): Rename from remote_notif_state_xfree.
4453
4454 2019-04-19  Tom Tromey  <tom@tromey.com>
4455
4456         * symfile.c (reread_symbols): Update.
4457         * objfiles.c (objfile_register_static_link)
4458         (objfile_lookup_static_link): Update
4459         (~objfile) Don't delete static_links.
4460         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4461
4462 2019-04-19  Tom Tromey  <tom@tromey.com>
4463
4464         * type-stack.h (struct type_stack) <insert>: Constify string.
4465         * type-stack.c (type_stack::insert): Constify string.
4466         * gdbtypes.h (lookup_template_type): Update.
4467         (address_space_name_to_int): Update.
4468         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4469         const.
4470         (lookup_template_type): Make name const.
4471         * c-exp.y: Update rules.
4472         (lex_one_token, classify_name, classify_inner_name)
4473         (c_print_token): Update.
4474         * p-exp.y: Update rules.
4475         (yylex): Update.
4476         * f-exp.y: Update rules.
4477         (yylex): Update.
4478         * d-exp.y: Update rules.
4479         (lex_one_token, classify_name, classify_inner_name): Update.
4480         * parse.c (write_dollar_variable, copy_name): Return std::string.
4481         * parser-defs.h (copy_name): Change return type.
4482         * m2-exp.y: Update rules.
4483         (yylex): Update.
4484         * go-exp.y (lex_one_token): Update.
4485         Update rules.
4486         (classify_unsafe_function, classify_packaged_name)
4487         (classify_name, yylex): Update.
4488
4489 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4490
4491         * configure.ac: add --enable-source-highlight switch.
4492         * configure: Regenerate.
4493         * top.c (print_gdb_version): plumb --enable-source-highlight
4494         status to "show configuration".
4495
4496 2019-04-19  Tom Tromey  <tromey@adacore.com>
4497
4498         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4499         Check ADA_TYPE_P.
4500         (empty_record, ada_template_to_fixed_record_type_1)
4501         (template_to_static_fixed_type)
4502         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4503         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4504         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4505         macros.
4506
4507 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4508
4509         PR symtab/24423:
4510         * source.c (print_source_lines_base): Advance "iter" when a
4511         control character is seen.
4512
4513 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4514
4515         * inferior.h (struct infcall_suspend_state_deleter):
4516         Catch exception in destructor to avoid crash.
4517
4518 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4519
4520         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4521         close to the add_com "shell".
4522
4523 2019-04-18  Tom Tromey  <tromey@adacore.com>
4524
4525         * process-stratum-target.h (class process_stratum_target)
4526         <stratum>: Add "final".
4527
4528 2019-04-17  Tom Tromey  <tromey@adacore.com>
4529
4530         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4531         against nullptr before use.
4532
4533 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4534
4535         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4536
4537 2019-04-17  Jim Wilson  <jimw@sifive.com>
4538             Andrew Burgess  <andrew.burgess@embecosm.com>
4539
4540         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4541         code read might fail, assume 4-byte breakpoint in that case.
4542
4543 2019-04-15  Leszek Swirski  <leszeks@google.com>
4544
4545         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4546         rather than a hand-rolled POD check when checking for forced MEMORY
4547         classification.
4548
4549 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4550
4551         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4552         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4553         function.
4554         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4555         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4556         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4557         declaration.
4558
4559 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4560
4561         * aarch64-linux-nat.c
4562         (aarch64_linux_nat_target::thread_architecture): Add override.
4563         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4564         each VQ.
4565
4566 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4567
4568         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4569
4570 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4571
4572         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4573         target types of size 96-bits, add some additional comments, and
4574         check that the builtin type we found was the correct size.
4575
4576 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4577
4578         * utils.c (prompt_for_continue): Don't restore the styling at the
4579         end, as applied_style has the wrong value.  This fixes styling in
4580         long lists of file names that are interrupted by the "Continue?"
4581         prompt.
4582
4583 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4584
4585         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4586         * c-lang.c (c_language_defn): Likewise.
4587         (cplus_language_defn): Likewise.
4588         (asm_language_defn): Likewise.
4589         (minimal_language_defn): Likewise.
4590         * d-lang.c (d_language_defn): Likewise.
4591         * f-lang.c (f_language_defn): Likewise.
4592         * go-lang.c (go_language_defn): Likewise.
4593         * language.c (unknown_language_defn): Likewise.
4594         (auto_language_defn): Likewise.
4595         * language.h (struct language_defn): Remove la_magic field.
4596         (LANG_MAGIC): Delete.
4597         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4598         * objc-lang.c (objc_language_defn): Likewise.
4599         * opencl-lang.c (opencl_language_defn): Likewise.
4600         * p-lang.c (pascal_language_defn): Likewise.
4601         * rust-lang.c (rust_language_defn): Likewise.
4602
4603 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4604
4605         * riscv-tdep.c (riscv_type_align): New function.
4606         (riscv_type_alignment): Delete.
4607         (riscv_arg_location): Use 'type_align'.
4608         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4609
4610 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4611
4612         * gdbtypes.c (type_align): A struct with no non-static fields also
4613         has alignment of 1.
4614
4615 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4616
4617         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4618         component to 0.
4619         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4620         member.
4621         (riscv_struct_info::analyse): New implementation using new
4622         analyse_inner member function.
4623         (riscv_struct_info::field_offset): New member function.
4624         (riscv_struct_info::m_offsets): New member variable.
4625         (riscv_struct_info::analyse_inner): New private member function,
4626         takes the old implementation of riscv_struct_info::analyse but
4627         extended to track field offsets.
4628         (riscv_call_arg_struct): Update the struct folding special cases
4629         to handle cases where empty C++ structs, which are non-zero
4630         length, are found.
4631         (riscv_arg_location): Initialise the length of each location, a
4632         non-zero length now indicates the location is in use.
4633         (riscv_push_dummy_call): Allow for the first location having a
4634         non-zero offset when setting up arguments.
4635         (riscv_return_value): Likewise, but for return values.
4636
4637 2019-04-11  Tom Tromey  <tromey@adacore.com>
4638
4639         * utils.c (internal_vproblem): Make "msg" const.
4640
4641 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4642
4643         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4644         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4645         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4646         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4647
4648 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4649
4650         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4651         function.
4652         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4653         of amd64_collect_native_gregset.
4654         (amd64_linux_nat_target::store_registers): Likewise.
4655
4656 2019-04-10  Tom Tromey  <tom@tromey.com>
4657
4658         * symtab.c (lookup_global_symbol_from_objfile)
4659         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4660         * objfiles.h (class separate_debug_iterator): New.
4661         (class separate_debug_range): New.
4662         (struct objfile) <separate_debug_objfiles>: New method.
4663         (objfile_separate_debug_iterate): Don't declare.
4664         * objfiles.c (separate_debug_iterator::operator++): Rename from
4665         objfile_separate_debug_iterate.
4666         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4667         iterator.
4668         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4669         iterator.
4670
4671 2019-04-10  Tom Tromey  <tom@tromey.com>
4672
4673         * symfile.c (reread_symbols): Remove old comment.
4674         * objfiles.c (free_all_objfiles): Fix a typo.
4675
4676 2019-04-10  Tom Tromey  <tom@tromey.com>
4677
4678         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4679         * minsyms.c (lookup_minimal_symbol): Use foreach.
4680         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4681         (lookup_minimal_symbol_solib_trampoline): Likewise.
4682         * symfile.c (reread_symbols): Use foreach.
4683
4684 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4685             Tom Tromey  <tromey@adacore.com>
4686
4687         PR rust/24414:
4688         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4689         (rust_lex_int_test): Change "value" to be LONGEST.
4690         (rust_lex_tests): Add test for long integer literal.
4691
4692 2019-04-09  Tom Tromey  <tromey@adacore.com>
4693
4694         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4695         to bool.
4696         (extended_remote_target::attach): Update.
4697         (remote_target::remote_notice_new_inferior): Update.
4698         (remote_target::add_current_inferior_and_thread): Update.
4699         * inferior.c (exit_inferior_1): Use "false".
4700         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4701
4702 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4703
4704         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4705         the "start" command.
4706
4707 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4708
4709         * python/py-inferior.c (infpy_thread_from_thread_handle):
4710         Adjust comments to reflect renaming of thread_from_thread_handle
4711         to thread_from_handle.  Adjust keywords.  Fix type error message.
4712         (inferior_object_methods): Add thread_from_handle.  Retain
4713         thread_from_thread_handle, but mark it as deprecated.
4714
4715 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4716
4717         * gdbthread.h (find_thread_by_handle): Revise declaration.
4718         * thread.c (find_thread_by_handle): Likewise.  Adjust
4719         implementation too.
4720         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4721         support for buffer objects as handles.
4722
4723 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4724
4725         * python/py-infthread.c (thpy_thread_handle): New function.
4726         (thread_object_methods): Register thpy_thread_handle.
4727
4728 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4729
4730         * gdbthread.h (thread_to_thread_handle): Declare.
4731         * thread.c (gdbtypes.h): Include.
4732         (thread_to_thread_handle): New function.
4733
4734         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4735         (target_thread_info_to_thread_handle): Declare.
4736         * target.c (target_thread_info_to_thread_handle): New function.
4737         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4738         * target-delegates.c: Regenerate.
4739
4740         * linux-thread-db.c (class thread_db_target): Add method
4741         thread_info_to_thread_handle.
4742         (thread_db_target::thread_info_to_thread_handle): Define.
4743         * remote.c (class remote_target): Add new method
4744         thread_info_to_thread_handle.
4745         (remote_target::thread_info_to_thread_handle): Define.
4746
4747 2019-04-08  Pedro Alves  <palves@redhat.com>
4748
4749         * common/common-exceptions.c (throw_exception): Don't create
4750         named object to throw; throw directly.
4751         (throw_it): Likewise.  Don't initialize gdb_exception::message
4752         here, with new; pass FMT and AP to the ctor instead.
4753         * common/common-exceptions.h: Include <string>.
4754         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4755         const char *, va_list)): New ctor.  Use std::make_shared.
4756         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4757         errors)): Delete.
4758         (gdb_exception_error::gdb_exception_error(enum errors, const char
4759         *, va_list)): New.
4760         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4761         Add assertion.
4762         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4763         errors)): Delete.
4764         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4765         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4766         Add assertion.
4767
4768 2019-04-08  Tom Tromey  <tom@tromey.com>
4769
4770         * valops.c (value_rtti_indirect_type): Replace throw_exception
4771         with throw.
4772         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4773         with throw.
4774         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4775         throw.
4776         * target.c (target_translate_tls_address): Replace throw_exception
4777         with throw.
4778         * stack.c (frame_apply_command_count): Replace throw_exception
4779         with throw.
4780         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4781         throw.
4782         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4783         with throw.
4784         * rs6000-tdep.c (rs6000_frame_cache)
4785         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4786         * remote.c: Replace throw_exception with throw.
4787         * record-full.c (record_full_message, record_full_wait_1)
4788         (record_full_restore): Replace throw_exception with throw.
4789         * record-btrace.c:
4790         (get_thread_current_frame_id, record_btrace_start_replaying)
4791         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4792         (cmd_record_btrace_start): Replace throw_exception with throw.
4793         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4794         throw.
4795         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4796         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4797         * linespec.c:
4798         (find_linespec_symbols): Replace throw_exception with throw.
4799         * infrun.c (displaced_step_prepare, resume): Replace
4800         throw_exception with throw.
4801         * infcmd.c (post_create_inferior): Replace throw_exception with
4802         throw.
4803         * inf-loop.c (inferior_event_handler): Replace throw_exception
4804         with throw.
4805         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4806         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4807         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4808         (get_prev_frame_always, get_frame_pc_if_available)
4809         (get_frame_address_in_block_if_available, get_frame_language):
4810         Replace throw_exception with throw.
4811         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4812         throw_exception with throw.
4813         * eval.c (fetch_subexp_value, evaluate_var_value)
4814         (evaluate_funcall, evaluate_subexp_standard): Replace
4815         throw_exception with throw.
4816         * dwarf2loc.c (call_site_find_chain)
4817         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4818         Replace throw_exception with throw.
4819         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4820         with throw.
4821         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4822         throw.
4823         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4824         * completer.c (complete_line_internal): Replace throw_exception
4825         with throw.
4826         * compile/compile-object-run.c (compile_object_run): Replace
4827         throw_exception with throw.
4828         * cli/cli-script.c (process_next_line): Replace throw_exception
4829         with throw.
4830         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4831         (btrace_enable, btrace_maint_update_pt_packets): Replace
4832         throw_exception with throw.
4833         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4834         throw_exception with throw.
4835         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4836         throw_exception with throw.
4837         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4838         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4839         * aarch64-tdep.c (aarch64_make_prologue_cache)
4840         (aarch64_make_stub_cache): Replace throw_exception with throw.
4841
4842 2019-04-08  Tom Tromey  <tom@tromey.com>
4843
4844         * common/common-exceptions.c (throw_exception): Rename from
4845         throw_exception_cxx.  Remove old copy.  Make argument const.
4846         (throw_it): Create and throw exception objects directly.
4847         * common/common-exceptions.h (throw_exception): Make argument
4848         const.
4849         (struct gdb_exception_error): Add constructor.
4850         (struct gdb_exception_quit): Add constructor.
4851
4852 2019-04-08  Tom Tromey  <tom@tromey.com>
4853
4854         * common/common-exceptions.h (exception_rethrow): Don't declare.
4855         (TRY_SJLJ): Update comment.
4856         (TRY, CATCH, END_CATCH): Remove.
4857         * common/common-exceptions.c (exception_rethrow): Remove.
4858
4859 2019-04-08  Tom Tromey  <tom@tromey.com>
4860
4861         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4862         Remove.
4863         (gdb_exception_error): Rename from
4864         gdb_exception_RETURN_MASK_ERROR.
4865         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4866         (gdb_quit_bad_alloc): Update.
4867         * aarch64-tdep.c: Update.
4868         * ada-lang.c: Update.
4869         * ada-typeprint.c: Update.
4870         * ada-valprint.c: Update.
4871         * amd64-tdep.c: Update.
4872         * arch-utils.c: Update.
4873         * break-catch-throw.c: Update.
4874         * breakpoint.c: Update.
4875         * btrace.c: Update.
4876         * c-varobj.c: Update.
4877         * cli/cli-cmds.c: Update.
4878         * cli/cli-interp.c: Update.
4879         * cli/cli-script.c: Update.
4880         * common/common-exceptions.c: Update.
4881         * common/new-op.c: Update.
4882         * common/selftest.c: Update.
4883         * compile/compile-c-symbols.c: Update.
4884         * compile/compile-cplus-symbols.c: Update.
4885         * compile/compile-object-load.c: Update.
4886         * compile/compile-object-run.c: Update.
4887         * completer.c: Update.
4888         * corelow.c: Update.
4889         * cp-abi.c: Update.
4890         * cp-support.c: Update.
4891         * cp-valprint.c: Update.
4892         * darwin-nat.c: Update.
4893         * disasm-selftests.c: Update.
4894         * dtrace-probe.c: Update.
4895         * dwarf-index-cache.c: Update.
4896         * dwarf-index-write.c: Update.
4897         * dwarf2-frame-tailcall.c: Update.
4898         * dwarf2-frame.c: Update.
4899         * dwarf2loc.c: Update.
4900         * dwarf2read.c: Update.
4901         * eval.c: Update.
4902         * event-loop.c: Update.
4903         * event-top.c: Update.
4904         * exec.c: Update.
4905         * f-valprint.c: Update.
4906         * fbsd-tdep.c: Update.
4907         * frame-unwind.c: Update.
4908         * frame.c: Update.
4909         * gdbtypes.c: Update.
4910         * gnu-v3-abi.c: Update.
4911         * guile/guile-internal.h: Update.
4912         * guile/scm-block.c: Update.
4913         * guile/scm-breakpoint.c: Update.
4914         * guile/scm-cmd.c: Update.
4915         * guile/scm-disasm.c: Update.
4916         * guile/scm-frame.c: Update.
4917         * guile/scm-lazy-string.c: Update.
4918         * guile/scm-math.c: Update.
4919         * guile/scm-param.c: Update.
4920         * guile/scm-ports.c: Update.
4921         * guile/scm-pretty-print.c: Update.
4922         * guile/scm-symbol.c: Update.
4923         * guile/scm-symtab.c: Update.
4924         * guile/scm-type.c: Update.
4925         * guile/scm-value.c: Update.
4926         * i386-linux-tdep.c: Update.
4927         * i386-tdep.c: Update.
4928         * inf-loop.c: Update.
4929         * infcall.c: Update.
4930         * infcmd.c: Update.
4931         * infrun.c: Update.
4932         * jit.c: Update.
4933         * language.c: Update.
4934         * linespec.c: Update.
4935         * linux-fork.c: Update.
4936         * linux-nat.c: Update.
4937         * linux-tdep.c: Update.
4938         * linux-thread-db.c: Update.
4939         * main.c: Update.
4940         * mi/mi-cmd-break.c: Update.
4941         * mi/mi-cmd-stack.c: Update.
4942         * mi/mi-interp.c: Update.
4943         * mi/mi-main.c: Update.
4944         * objc-lang.c: Update.
4945         * p-valprint.c: Update.
4946         * parse.c: Update.
4947         * ppc-linux-tdep.c: Update.
4948         * printcmd.c: Update.
4949         * python/py-arch.c: Update.
4950         * python/py-breakpoint.c: Update.
4951         * python/py-cmd.c: Update.
4952         * python/py-finishbreakpoint.c: Update.
4953         * python/py-frame.c: Update.
4954         * python/py-framefilter.c: Update.
4955         * python/py-gdb-readline.c: Update.
4956         * python/py-inferior.c: Update.
4957         * python/py-infthread.c: Update.
4958         * python/py-lazy-string.c: Update.
4959         * python/py-linetable.c: Update.
4960         * python/py-objfile.c: Update.
4961         * python/py-param.c: Update.
4962         * python/py-prettyprint.c: Update.
4963         * python/py-progspace.c: Update.
4964         * python/py-record-btrace.c: Update.
4965         * python/py-record.c: Update.
4966         * python/py-symbol.c: Update.
4967         * python/py-type.c: Update.
4968         * python/py-unwind.c: Update.
4969         * python/py-utils.c: Update.
4970         * python/py-value.c: Update.
4971         * python/python.c: Update.
4972         * record-btrace.c: Update.
4973         * record-full.c: Update.
4974         * remote-fileio.c: Update.
4975         * remote.c: Update.
4976         * riscv-tdep.c: Update.
4977         * rs6000-aix-tdep.c: Update.
4978         * rs6000-tdep.c: Update.
4979         * rust-exp.y: Update.
4980         * rust-lang.c: Update.
4981         * s390-tdep.c: Update.
4982         * selftest-arch.c: Update.
4983         * solib-dsbt.c: Update.
4984         * solib-frv.c: Update.
4985         * solib-spu.c: Update.
4986         * solib-svr4.c: Update.
4987         * solib.c: Update.
4988         * sparc64-linux-tdep.c: Update.
4989         * stack.c: Update.
4990         * symfile-mem.c: Update.
4991         * symmisc.c: Update.
4992         * target.c: Update.
4993         * thread.c: Update.
4994         * top.c: Update.
4995         * tracefile-tfile.c: Update.
4996         * tui/tui.c: Update.
4997         * typeprint.c: Update.
4998         * unittests/cli-utils-selftests.c: Update.
4999         * unittests/parse-connection-spec-selftests.c: Update.
5000         * valops.c: Update.
5001         * valprint.c: Update.
5002         * value.c: Update.
5003         * varobj.c: Update.
5004         * windows-nat.c: Update.
5005         * x86-linux-nat.c: Update.
5006         * xml-support.c: Update.
5007
5008 2019-04-08  Tom Tromey  <tom@tromey.com>
5009
5010         * xml-support.c: Use C++ exception handling.
5011         * x86-linux-nat.c: Use C++ exception handling.
5012         * windows-nat.c: Use C++ exception handling.
5013         * varobj.c: Use C++ exception handling.
5014         * value.c: Use C++ exception handling.
5015         * valprint.c: Use C++ exception handling.
5016         * valops.c: Use C++ exception handling.
5017         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5018         handling.
5019         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5020         * typeprint.c: Use C++ exception handling.
5021         * tui/tui.c: Use C++ exception handling.
5022         * tracefile-tfile.c: Use C++ exception handling.
5023         * top.c: Use C++ exception handling.
5024         * thread.c: Use C++ exception handling.
5025         * target.c: Use C++ exception handling.
5026         * symmisc.c: Use C++ exception handling.
5027         * symfile-mem.c: Use C++ exception handling.
5028         * stack.c: Use C++ exception handling.
5029         * sparc64-linux-tdep.c: Use C++ exception handling.
5030         * solib.c: Use C++ exception handling.
5031         * solib-svr4.c: Use C++ exception handling.
5032         * solib-spu.c: Use C++ exception handling.
5033         * solib-frv.c: Use C++ exception handling.
5034         * solib-dsbt.c: Use C++ exception handling.
5035         * selftest-arch.c: Use C++ exception handling.
5036         * s390-tdep.c: Use C++ exception handling.
5037         * rust-lang.c: Use C++ exception handling.
5038         * rust-exp.y: Use C++ exception handling.
5039         * rs6000-tdep.c: Use C++ exception handling.
5040         * rs6000-aix-tdep.c: Use C++ exception handling.
5041         * riscv-tdep.c: Use C++ exception handling.
5042         * remote.c: Use C++ exception handling.
5043         * remote-fileio.c: Use C++ exception handling.
5044         * record-full.c: Use C++ exception handling.
5045         * record-btrace.c: Use C++ exception handling.
5046         * python/python.c: Use C++ exception handling.
5047         * python/py-value.c: Use C++ exception handling.
5048         * python/py-utils.c: Use C++ exception handling.
5049         * python/py-unwind.c: Use C++ exception handling.
5050         * python/py-type.c: Use C++ exception handling.
5051         * python/py-symbol.c: Use C++ exception handling.
5052         * python/py-record.c: Use C++ exception handling.
5053         * python/py-record-btrace.c: Use C++ exception handling.
5054         * python/py-progspace.c: Use C++ exception handling.
5055         * python/py-prettyprint.c: Use C++ exception handling.
5056         * python/py-param.c: Use C++ exception handling.
5057         * python/py-objfile.c: Use C++ exception handling.
5058         * python/py-linetable.c: Use C++ exception handling.
5059         * python/py-lazy-string.c: Use C++ exception handling.
5060         * python/py-infthread.c: Use C++ exception handling.
5061         * python/py-inferior.c: Use C++ exception handling.
5062         * python/py-gdb-readline.c: Use C++ exception handling.
5063         * python/py-framefilter.c: Use C++ exception handling.
5064         * python/py-frame.c: Use C++ exception handling.
5065         * python/py-finishbreakpoint.c: Use C++ exception handling.
5066         * python/py-cmd.c: Use C++ exception handling.
5067         * python/py-breakpoint.c: Use C++ exception handling.
5068         * python/py-arch.c: Use C++ exception handling.
5069         * printcmd.c: Use C++ exception handling.
5070         * ppc-linux-tdep.c: Use C++ exception handling.
5071         * parse.c: Use C++ exception handling.
5072         * p-valprint.c: Use C++ exception handling.
5073         * objc-lang.c: Use C++ exception handling.
5074         * mi/mi-main.c: Use C++ exception handling.
5075         * mi/mi-interp.c: Use C++ exception handling.
5076         * mi/mi-cmd-stack.c: Use C++ exception handling.
5077         * mi/mi-cmd-break.c: Use C++ exception handling.
5078         * main.c: Use C++ exception handling.
5079         * linux-thread-db.c: Use C++ exception handling.
5080         * linux-tdep.c: Use C++ exception handling.
5081         * linux-nat.c: Use C++ exception handling.
5082         * linux-fork.c: Use C++ exception handling.
5083         * linespec.c: Use C++ exception handling.
5084         * language.c: Use C++ exception handling.
5085         * jit.c: Use C++ exception handling.
5086         * infrun.c: Use C++ exception handling.
5087         * infcmd.c: Use C++ exception handling.
5088         * infcall.c: Use C++ exception handling.
5089         * inf-loop.c: Use C++ exception handling.
5090         * i386-tdep.c: Use C++ exception handling.
5091         * i386-linux-tdep.c: Use C++ exception handling.
5092         * guile/scm-value.c: Use C++ exception handling.
5093         * guile/scm-type.c: Use C++ exception handling.
5094         * guile/scm-symtab.c: Use C++ exception handling.
5095         * guile/scm-symbol.c: Use C++ exception handling.
5096         * guile/scm-pretty-print.c: Use C++ exception handling.
5097         * guile/scm-ports.c: Use C++ exception handling.
5098         * guile/scm-param.c: Use C++ exception handling.
5099         * guile/scm-math.c: Use C++ exception handling.
5100         * guile/scm-lazy-string.c: Use C++ exception handling.
5101         * guile/scm-frame.c: Use C++ exception handling.
5102         * guile/scm-disasm.c: Use C++ exception handling.
5103         * guile/scm-cmd.c: Use C++ exception handling.
5104         * guile/scm-breakpoint.c: Use C++ exception handling.
5105         * guile/scm-block.c: Use C++ exception handling.
5106         * guile/guile-internal.h: Use C++ exception handling.
5107         * gnu-v3-abi.c: Use C++ exception handling.
5108         * gdbtypes.c: Use C++ exception handling.
5109         * frame.c: Use C++ exception handling.
5110         * frame-unwind.c: Use C++ exception handling.
5111         * fbsd-tdep.c: Use C++ exception handling.
5112         * f-valprint.c: Use C++ exception handling.
5113         * exec.c: Use C++ exception handling.
5114         * event-top.c: Use C++ exception handling.
5115         * event-loop.c: Use C++ exception handling.
5116         * eval.c: Use C++ exception handling.
5117         * dwarf2read.c: Use C++ exception handling.
5118         * dwarf2loc.c: Use C++ exception handling.
5119         * dwarf2-frame.c: Use C++ exception handling.
5120         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5121         * dwarf-index-write.c: Use C++ exception handling.
5122         * dwarf-index-cache.c: Use C++ exception handling.
5123         * dtrace-probe.c: Use C++ exception handling.
5124         * disasm-selftests.c: Use C++ exception handling.
5125         * darwin-nat.c: Use C++ exception handling.
5126         * cp-valprint.c: Use C++ exception handling.
5127         * cp-support.c: Use C++ exception handling.
5128         * cp-abi.c: Use C++ exception handling.
5129         * corelow.c: Use C++ exception handling.
5130         * completer.c: Use C++ exception handling.
5131         * compile/compile-object-run.c: Use C++ exception handling.
5132         * compile/compile-object-load.c: Use C++ exception handling.
5133         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5134         * compile/compile-c-symbols.c: Use C++ exception handling.
5135         * common/selftest.c: Use C++ exception handling.
5136         * common/new-op.c: Use C++ exception handling.
5137         * cli/cli-script.c: Use C++ exception handling.
5138         * cli/cli-interp.c: Use C++ exception handling.
5139         * cli/cli-cmds.c: Use C++ exception handling.
5140         * c-varobj.c: Use C++ exception handling.
5141         * btrace.c: Use C++ exception handling.
5142         * breakpoint.c: Use C++ exception handling.
5143         * break-catch-throw.c: Use C++ exception handling.
5144         * arch-utils.c: Use C++ exception handling.
5145         * amd64-tdep.c: Use C++ exception handling.
5146         * ada-valprint.c: Use C++ exception handling.
5147         * ada-typeprint.c: Use C++ exception handling.
5148         * ada-lang.c: Use C++ exception handling.
5149         * aarch64-tdep.c: Use C++ exception handling.
5150
5151 2019-04-08  Tom Tromey  <tom@tromey.com>
5152
5153         * xml-support.c (gdb_xml_parser::parse): Update.
5154         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5155         * value.c (show_convenience): Update.
5156         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5157         (test_parse_flags_qcs): Update.
5158         * thread.c (thr_try_catch_cmd): Update.
5159         * target.c (target_translate_tls_address): Update.
5160         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5161         (info_frame_command_core, frame_apply_command_count): Update.
5162         * rust-exp.y (rust_lex_exception_test): Update.
5163         * riscv-tdep.c (riscv_print_one_register_info): Update.
5164         * remote.c (remote_target::enable_btrace): Update.
5165         * record-btrace.c (record_btrace_enable_warn): Update.
5166         * python/py-utils.c (gdbpy_convert_exception): Update.
5167         * printcmd.c (do_one_display, print_variable_and_value): Update.
5168         * mi/mi-main.c (mi_print_exception): Update.
5169         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5170         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5171         * linux-nat.c (linux_nat_target::attach): Update.
5172         * linux-fork.c (class scoped_switch_fork_info): Update.
5173         * infrun.c (displaced_step_prepare): Update.
5174         * infcall.c (call_function_by_hand_dummy): Update.
5175         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5176         * gnu-v3-abi.c (print_one_vtable): Update.
5177         * frame.c (get_prev_frame_always): Update.
5178         * f-valprint.c (info_common_command_for_block): Update.
5179         * exec.c (try_open_exec_file): Update.
5180         * exceptions.c (print_exception, exception_print)
5181         (exception_fprintf, exception_print_same): Update.
5182         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5183         * dwarf-index-cache.c (index_cache::store)
5184         (index_cache::lookup_gdb_index): Update.
5185         * darwin-nat.c (maybe_cache_shell): Update.
5186         * cp-valprint.c (cp_print_value_fields): Update.
5187         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5188         (gcc_cplus_symbol_address): Update.
5189         * compile/compile-c-symbols.c (gcc_convert_symbol)
5190         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5191         * common/selftest.c: Update.
5192         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5193         a std::string.
5194         (exception_try_scope_entry, exception_try_scope_exit): Don't
5195         declare.
5196         (struct exception_try_scope): Remove.
5197         (TRY): Don't use exception_try_scope.
5198         (struct gdb_exception): Add constructor, operator=.
5199         <what>: New method.
5200         (struct gdb_exception_RETURN_MASK_ALL)
5201         (struct gdb_exception_RETURN_MASK_ERROR)
5202         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5203         (struct gdb_quit_bad_alloc): Update.
5204         * common/common-exceptions.c (exception_none): Change
5205         initializer.
5206         (struct catcher) <state, exception>: Initialize inline.
5207         <prev>: Remove member.
5208         (current_catcher): Remove.
5209         (catchers): New global.
5210         (exceptions_state_mc_init): Simplify.
5211         (catcher_pop): Remove.
5212         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5213         (try_scope_depth, exception_try_scope_entry)
5214         (exception_try_scope_exit): Remove.
5215         (throw_exception_sjlj): Update.
5216         (exception_messages, exception_messages_size): Remove.
5217         (throw_it): Simplify.
5218         (gdb_exception_sliced_copy): Remove.
5219         (throw_exception_cxx): Update.
5220         * cli/cli-script.c (script_from_file): Update.
5221         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5222         Update.
5223         * ada-valprint.c (ada_val_print): Update.
5224         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5225         (create_excep_cond_exprs): Update.
5226
5227 2019-04-08  Tom Tromey  <tom@tromey.com>
5228
5229         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5230         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5231         (TRY, CATCH, END_CATCH): Remove some definitions.
5232         * common/common-exceptions.c: Don't use GDB_XCPT.
5233         (catcher_list_size): Remove.
5234         (throw_exception, throw_it): Simplify.
5235
5236 2019-04-05  Tom Tromey  <tom@tromey.com>
5237
5238         Revert the header-sorting patch.
5239         * ft32-tdep.c: Revert.
5240         * frv-tdep.c: Revert.
5241         * frv-linux-tdep.c: Revert.
5242         * frame.c: Revert.
5243         * frame-unwind.c: Revert.
5244         * frame-base.c: Revert.
5245         * fork-child.c: Revert.
5246         * findvar.c: Revert.
5247         * findcmd.c: Revert.
5248         * filesystem.c: Revert.
5249         * filename-seen-cache.h: Revert.
5250         * filename-seen-cache.c: Revert.
5251         * fbsd-tdep.c: Revert.
5252         * fbsd-nat.h: Revert.
5253         * fbsd-nat.c: Revert.
5254         * f-valprint.c: Revert.
5255         * f-typeprint.c: Revert.
5256         * f-lang.c: Revert.
5257         * extension.h: Revert.
5258         * extension.c: Revert.
5259         * extension-priv.h: Revert.
5260         * expprint.c: Revert.
5261         * exec.h: Revert.
5262         * exec.c: Revert.
5263         * exceptions.c: Revert.
5264         * event-top.c: Revert.
5265         * event-loop.c: Revert.
5266         * eval.c: Revert.
5267         * elfread.c: Revert.
5268         * dwarf2read.h: Revert.
5269         * dwarf2read.c: Revert.
5270         * dwarf2loc.c: Revert.
5271         * dwarf2expr.h: Revert.
5272         * dwarf2expr.c: Revert.
5273         * dwarf2-frame.c: Revert.
5274         * dwarf2-frame-tailcall.c: Revert.
5275         * dwarf-index-write.h: Revert.
5276         * dwarf-index-write.c: Revert.
5277         * dwarf-index-common.c: Revert.
5278         * dwarf-index-cache.h: Revert.
5279         * dwarf-index-cache.c: Revert.
5280         * dummy-frame.c: Revert.
5281         * dtrace-probe.c: Revert.
5282         * disasm.h: Revert.
5283         * disasm.c: Revert.
5284         * disasm-selftests.c: Revert.
5285         * dictionary.c: Revert.
5286         * dicos-tdep.c: Revert.
5287         * demangle.c: Revert.
5288         * dcache.h: Revert.
5289         * dcache.c: Revert.
5290         * darwin-nat.h: Revert.
5291         * darwin-nat.c: Revert.
5292         * darwin-nat-info.c: Revert.
5293         * d-valprint.c: Revert.
5294         * d-namespace.c: Revert.
5295         * d-lang.c: Revert.
5296         * ctf.c: Revert.
5297         * csky-tdep.c: Revert.
5298         * csky-linux-tdep.c: Revert.
5299         * cris-tdep.c: Revert.
5300         * cris-linux-tdep.c: Revert.
5301         * cp-valprint.c: Revert.
5302         * cp-support.c: Revert.
5303         * cp-namespace.c: Revert.
5304         * cp-abi.c: Revert.
5305         * corelow.c: Revert.
5306         * corefile.c: Revert.
5307         * continuations.c: Revert.
5308         * completer.h: Revert.
5309         * completer.c: Revert.
5310         * complaints.c: Revert.
5311         * coffread.c: Revert.
5312         * coff-pe-read.c: Revert.
5313         * cli-out.h: Revert.
5314         * cli-out.c: Revert.
5315         * charset.c: Revert.
5316         * c-varobj.c: Revert.
5317         * c-valprint.c: Revert.
5318         * c-typeprint.c: Revert.
5319         * c-lang.c: Revert.
5320         * buildsym.c: Revert.
5321         * buildsym-legacy.c: Revert.
5322         * build-id.h: Revert.
5323         * build-id.c: Revert.
5324         * btrace.c: Revert.
5325         * bsd-uthread.c: Revert.
5326         * breakpoint.h: Revert.
5327         * breakpoint.c: Revert.
5328         * break-catch-throw.c: Revert.
5329         * break-catch-syscall.c: Revert.
5330         * break-catch-sig.c: Revert.
5331         * blockframe.c: Revert.
5332         * block.c: Revert.
5333         * bfin-tdep.c: Revert.
5334         * bfin-linux-tdep.c: Revert.
5335         * bfd-target.c: Revert.
5336         * bcache.c: Revert.
5337         * ax-general.c: Revert.
5338         * ax-gdb.h: Revert.
5339         * ax-gdb.c: Revert.
5340         * avr-tdep.c: Revert.
5341         * auxv.c: Revert.
5342         * auto-load.c: Revert.
5343         * arm-wince-tdep.c: Revert.
5344         * arm-tdep.c: Revert.
5345         * arm-symbian-tdep.c: Revert.
5346         * arm-pikeos-tdep.c: Revert.
5347         * arm-obsd-tdep.c: Revert.
5348         * arm-nbsd-tdep.c: Revert.
5349         * arm-nbsd-nat.c: Revert.
5350         * arm-linux-tdep.c: Revert.
5351         * arm-linux-nat.c: Revert.
5352         * arm-fbsd-tdep.c: Revert.
5353         * arm-fbsd-nat.c: Revert.
5354         * arm-bsd-tdep.c: Revert.
5355         * arch-utils.c: Revert.
5356         * arc-tdep.c: Revert.
5357         * arc-newlib-tdep.c: Revert.
5358         * annotate.h: Revert.
5359         * annotate.c: Revert.
5360         * amd64-windows-tdep.c: Revert.
5361         * amd64-windows-nat.c: Revert.
5362         * amd64-tdep.c: Revert.
5363         * amd64-sol2-tdep.c: Revert.
5364         * amd64-obsd-tdep.c: Revert.
5365         * amd64-obsd-nat.c: Revert.
5366         * amd64-nbsd-tdep.c: Revert.
5367         * amd64-nbsd-nat.c: Revert.
5368         * amd64-nat.c: Revert.
5369         * amd64-linux-tdep.c: Revert.
5370         * amd64-linux-nat.c: Revert.
5371         * amd64-fbsd-tdep.c: Revert.
5372         * amd64-fbsd-nat.c: Revert.
5373         * amd64-dicos-tdep.c: Revert.
5374         * amd64-darwin-tdep.c: Revert.
5375         * amd64-bsd-nat.c: Revert.
5376         * alpha-tdep.c: Revert.
5377         * alpha-obsd-tdep.c: Revert.
5378         * alpha-nbsd-tdep.c: Revert.
5379         * alpha-mdebug-tdep.c: Revert.
5380         * alpha-linux-tdep.c: Revert.
5381         * alpha-linux-nat.c: Revert.
5382         * alpha-bsd-tdep.c: Revert.
5383         * alpha-bsd-nat.c: Revert.
5384         * aix-thread.c: Revert.
5385         * agent.c: Revert.
5386         * addrmap.c: Revert.
5387         * ada-varobj.c: Revert.
5388         * ada-valprint.c: Revert.
5389         * ada-typeprint.c: Revert.
5390         * ada-tasks.c: Revert.
5391         * ada-lang.c: Revert.
5392         * aarch64-tdep.c: Revert.
5393         * aarch64-ravenscar-thread.c: Revert.
5394         * aarch64-newlib-tdep.c: Revert.
5395         * aarch64-linux-tdep.c: Revert.
5396         * aarch64-linux-nat.c: Revert.
5397         * aarch64-fbsd-tdep.c: Revert.
5398         * aarch64-fbsd-nat.c: Revert.
5399         * aarch32-linux-nat.c: Revert.
5400
5401 2019-04-05  Tom Tromey  <tom@tromey.com>
5402
5403         * ft32-tdep.c: Sort headers.
5404         * frv-tdep.c: Sort headers.
5405         * frv-linux-tdep.c: Sort headers.
5406         * frame.c: Sort headers.
5407         * frame-unwind.c: Sort headers.
5408         * frame-base.c: Sort headers.
5409         * fork-child.c: Sort headers.
5410         * findvar.c: Sort headers.
5411         * findcmd.c: Sort headers.
5412         * filesystem.c: Sort headers.
5413         * filename-seen-cache.h: Sort headers.
5414         * filename-seen-cache.c: Sort headers.
5415         * fbsd-tdep.c: Sort headers.
5416         * fbsd-nat.h: Sort headers.
5417         * fbsd-nat.c: Sort headers.
5418         * f-valprint.c: Sort headers.
5419         * f-typeprint.c: Sort headers.
5420         * f-lang.c: Sort headers.
5421         * extension.h: Sort headers.
5422         * extension.c: Sort headers.
5423         * extension-priv.h: Sort headers.
5424         * expprint.c: Sort headers.
5425         * exec.h: Sort headers.
5426         * exec.c: Sort headers.
5427         * exceptions.c: Sort headers.
5428         * event-top.c: Sort headers.
5429         * event-loop.c: Sort headers.
5430         * eval.c: Sort headers.
5431         * elfread.c: Sort headers.
5432         * dwarf2read.h: Sort headers.
5433         * dwarf2read.c: Sort headers.
5434         * dwarf2loc.c: Sort headers.
5435         * dwarf2expr.h: Sort headers.
5436         * dwarf2expr.c: Sort headers.
5437         * dwarf2-frame.c: Sort headers.
5438         * dwarf2-frame-tailcall.c: Sort headers.
5439         * dwarf-index-write.h: Sort headers.
5440         * dwarf-index-write.c: Sort headers.
5441         * dwarf-index-common.c: Sort headers.
5442         * dwarf-index-cache.h: Sort headers.
5443         * dwarf-index-cache.c: Sort headers.
5444         * dummy-frame.c: Sort headers.
5445         * dtrace-probe.c: Sort headers.
5446         * disasm.h: Sort headers.
5447         * disasm.c: Sort headers.
5448         * disasm-selftests.c: Sort headers.
5449         * dictionary.c: Sort headers.
5450         * dicos-tdep.c: Sort headers.
5451         * demangle.c: Sort headers.
5452         * dcache.h: Sort headers.
5453         * dcache.c: Sort headers.
5454         * darwin-nat.h: Sort headers.
5455         * darwin-nat.c: Sort headers.
5456         * darwin-nat-info.c: Sort headers.
5457         * d-valprint.c: Sort headers.
5458         * d-namespace.c: Sort headers.
5459         * d-lang.c: Sort headers.
5460         * ctf.c: Sort headers.
5461         * csky-tdep.c: Sort headers.
5462         * csky-linux-tdep.c: Sort headers.
5463         * cris-tdep.c: Sort headers.
5464         * cris-linux-tdep.c: Sort headers.
5465         * cp-valprint.c: Sort headers.
5466         * cp-support.c: Sort headers.
5467         * cp-namespace.c: Sort headers.
5468         * cp-abi.c: Sort headers.
5469         * corelow.c: Sort headers.
5470         * corefile.c: Sort headers.
5471         * continuations.c: Sort headers.
5472         * completer.h: Sort headers.
5473         * completer.c: Sort headers.
5474         * complaints.c: Sort headers.
5475         * coffread.c: Sort headers.
5476         * coff-pe-read.c: Sort headers.
5477         * cli-out.h: Sort headers.
5478         * cli-out.c: Sort headers.
5479         * charset.c: Sort headers.
5480         * c-varobj.c: Sort headers.
5481         * c-valprint.c: Sort headers.
5482         * c-typeprint.c: Sort headers.
5483         * c-lang.c: Sort headers.
5484         * buildsym.c: Sort headers.
5485         * buildsym-legacy.c: Sort headers.
5486         * build-id.h: Sort headers.
5487         * build-id.c: Sort headers.
5488         * btrace.c: Sort headers.
5489         * bsd-uthread.c: Sort headers.
5490         * breakpoint.h: Sort headers.
5491         * breakpoint.c: Sort headers.
5492         * break-catch-throw.c: Sort headers.
5493         * break-catch-syscall.c: Sort headers.
5494         * break-catch-sig.c: Sort headers.
5495         * blockframe.c: Sort headers.
5496         * block.c: Sort headers.
5497         * bfin-tdep.c: Sort headers.
5498         * bfin-linux-tdep.c: Sort headers.
5499         * bfd-target.c: Sort headers.
5500         * bcache.c: Sort headers.
5501         * ax-general.c: Sort headers.
5502         * ax-gdb.h: Sort headers.
5503         * ax-gdb.c: Sort headers.
5504         * avr-tdep.c: Sort headers.
5505         * auxv.c: Sort headers.
5506         * auto-load.c: Sort headers.
5507         * arm-wince-tdep.c: Sort headers.
5508         * arm-tdep.c: Sort headers.
5509         * arm-symbian-tdep.c: Sort headers.
5510         * arm-pikeos-tdep.c: Sort headers.
5511         * arm-obsd-tdep.c: Sort headers.
5512         * arm-nbsd-tdep.c: Sort headers.
5513         * arm-nbsd-nat.c: Sort headers.
5514         * arm-linux-tdep.c: Sort headers.
5515         * arm-linux-nat.c: Sort headers.
5516         * arm-fbsd-tdep.c: Sort headers.
5517         * arm-fbsd-nat.c: Sort headers.
5518         * arm-bsd-tdep.c: Sort headers.
5519         * arch-utils.c: Sort headers.
5520         * arc-tdep.c: Sort headers.
5521         * arc-newlib-tdep.c: Sort headers.
5522         * annotate.h: Sort headers.
5523         * annotate.c: Sort headers.
5524         * amd64-windows-tdep.c: Sort headers.
5525         * amd64-windows-nat.c: Sort headers.
5526         * amd64-tdep.c: Sort headers.
5527         * amd64-sol2-tdep.c: Sort headers.
5528         * amd64-obsd-tdep.c: Sort headers.
5529         * amd64-obsd-nat.c: Sort headers.
5530         * amd64-nbsd-tdep.c: Sort headers.
5531         * amd64-nbsd-nat.c: Sort headers.
5532         * amd64-nat.c: Sort headers.
5533         * amd64-linux-tdep.c: Sort headers.
5534         * amd64-linux-nat.c: Sort headers.
5535         * amd64-fbsd-tdep.c: Sort headers.
5536         * amd64-fbsd-nat.c: Sort headers.
5537         * amd64-dicos-tdep.c: Sort headers.
5538         * amd64-darwin-tdep.c: Sort headers.
5539         * amd64-bsd-nat.c: Sort headers.
5540         * alpha-tdep.c: Sort headers.
5541         * alpha-obsd-tdep.c: Sort headers.
5542         * alpha-nbsd-tdep.c: Sort headers.
5543         * alpha-mdebug-tdep.c: Sort headers.
5544         * alpha-linux-tdep.c: Sort headers.
5545         * alpha-linux-nat.c: Sort headers.
5546         * alpha-bsd-tdep.c: Sort headers.
5547         * alpha-bsd-nat.c: Sort headers.
5548         * aix-thread.c: Sort headers.
5549         * agent.c: Sort headers.
5550         * addrmap.c: Sort headers.
5551         * ada-varobj.c: Sort headers.
5552         * ada-valprint.c: Sort headers.
5553         * ada-typeprint.c: Sort headers.
5554         * ada-tasks.c: Sort headers.
5555         * ada-lang.c: Sort headers.
5556         * aarch64-tdep.c: Sort headers.
5557         * aarch64-ravenscar-thread.c: Sort headers.
5558         * aarch64-newlib-tdep.c: Sort headers.
5559         * aarch64-linux-tdep.c: Sort headers.
5560         * aarch64-linux-nat.c: Sort headers.
5561         * aarch64-fbsd-tdep.c: Sort headers.
5562         * aarch64-fbsd-nat.c: Sort headers.
5563         * aarch32-linux-nat.c: Sort headers.
5564
5565 2019-04-04  Tom Tromey  <tom@tromey.com>
5566
5567         * varobj.c (varobj_create): Update.
5568         * rust-exp.y (struct rust_parser) <update_innermost_block,
5569         lookup_symbol>: New methods.
5570         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5571         Rename.
5572         (rust_parser::rust_lookup_type)
5573         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5574         * printcmd.c (display_command, do_one_display): Update.
5575         * parser-defs.h (struct parser_state) <parser_state>: Add
5576         "tracker" parameter.
5577         (block_tracker): New member.
5578         (class innermost_block_tracker) <innermost_block_tracker>: Add
5579         "types" parameter.
5580         <reset>: Remove method.
5581         (innermost_block): Don't declare.
5582         (null_post_parser): Update.
5583         * parse.c (innermost_block): Remove global.
5584         (write_dollar_variable): Update.
5585         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5586         Remove "tracker_types" parameter.
5587         (parse_expression): Add "tracker" parameter.
5588         (parse_expression_for_completion): Update.
5589         (null_post_parser): Add "tracker" parameter.
5590         * p-exp.y: Update rules.
5591         * m2-exp.y: Update rules.
5592         * language.h (struct language_defn) <la_post_parser>: Add
5593         "tracker" parameter.
5594         * go-exp.y: Update rules.
5595         * f-exp.y: Update rules.
5596         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5597         parameter.
5598         * d-exp.y: Update rules.
5599         * c-exp.y: Update rules.
5600         * breakpoint.c (set_breakpoint_condition): Create an
5601         innermost_block_tracker.
5602         (watch_command_1): Likewise.
5603         * ada-lang.c (resolve): Add "tracker" parameter.
5604         (resolve_subexp): Likewise.
5605         * ada-exp.y (write_var_from_sym): Update.
5606
5607 2019-04-04  Tom Tromey  <tom@tromey.com>
5608
5609         * type-stack.h: New file.
5610         * type-stack.c: New file.
5611         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5612         type-stack.h.
5613         (insert_into_type_stack, insert_type, push_type, push_type_int)
5614         (insert_type_address_space, pop_type, pop_type_int)
5615         (pop_typelist, pop_type_stack, append_type_stack)
5616         (push_type_stack, get_type_stack, push_typelist)
5617         (follow_type_instance_flags, follow_types): Don't declare.
5618         * parse.c (type_stack): Remove global.
5619         (parse_exp_in_context): Update.
5620         (insert_into_type_stack, insert_type, push_type, push_type_int)
5621         (insert_type_address_space, pop_type, pop_type_int)
5622         (pop_typelist, pop_type_stack, append_type_stack)
5623         (push_type_stack, get_type_stack, push_typelist)
5624         (follow_type_instance_flags, follow_types): Remove (moved to
5625         type-stack.c).
5626         * f-exp.y (type_stack): New global.
5627         Update rules.
5628         (push_kind_type, f_parse): Update.
5629         * d-exp.y (type_stack): New global.
5630         Update rules.
5631         (d_parse): Update.
5632         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5633         Update rules.
5634         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5635         (HFILES_NO_SRCDIR): Add type-stack.h.
5636
5637 2019-04-04  Tom Tromey  <tom@tromey.com>
5638
5639         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5640         (rust_parser::convert_ast_to_expression, rust_parse)
5641         (rust_lex_test_completion, rust_lex_tests): Update.
5642         * parser-defs.h (struct expr_completion_state): New.
5643         (struct parser_state) <parser_state>: Add completion parameter.
5644         <mark_struct_expression, mark_completion_tag>: New methods.
5645         <parse_completion, m_completion_state>: New members.
5646         (prefixify_expression, null_post_parser): Update.
5647         (mark_struct_expression, mark_completion_tag): Don't declare.
5648         * parse.c (parse_completion, expout_last_struct)
5649         (expout_tag_completion_type, expout_completion_name): Remove
5650         globals.
5651         (parser_state::mark_struct_expression)
5652         (parser_state::mark_completion_tag): Now methods.
5653         (prefixify_expression): Add last_struct parameter.
5654         (prefixify_subexp): Likewise.
5655         (parse_exp_1): Update.
5656         (parse_exp_in_context): Add cstate parameter.  Update.
5657         (parse_expression_for_completion): Create an
5658         expr_completion_state.
5659         (null_post_parser): Add "completion" parameter.
5660         * p-exp.y: Update rules.
5661         (yylex): Update.
5662         * language.h (struct language_defn) <la_post_parser>: Add
5663         "completing" parameter.
5664         * go-exp.y: Update rules.
5665         (lex_one_token): Update.
5666         * expression.h (parse_completion): Don't declare.
5667         * d-exp.y: Update rules.
5668         (lex_one_token): Update rules.
5669         * c-exp.y: Update rules.
5670         (lex_one_token): Update.
5671         * ada-lang.c (resolve): Add "parse_completion" parameter.
5672         (resolve_subexp): Likewise.
5673         (ada_resolve_function): Likewise.
5674
5675 2019-04-04  Tom Tromey  <tom@tromey.com>
5676
5677         * parser-defs.h (struct parser_state) <start_arglist,
5678         end_arglist>: New methods.
5679         <arglist_len, m_funcall_chain>: New members.
5680         (arglist_len, start_arglist, end_arglist): Don't declare.
5681         * parse.c (arglist_len, funcall_chain): Remove global.
5682         (start_arglist, end_arglist): Remove functions.
5683         (parse_exp_in_context): Update.
5684         * p-exp.y: Update rules.
5685         * m2-exp.y: Update rules.
5686         * go-exp.y: Update rules.
5687         * f-exp.y: Update rules.
5688         * d-exp.y: Update rules.
5689         * c-exp.y: Update rules.
5690
5691 2019-04-04  Tom Tromey  <tom@tromey.com>
5692
5693         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5694         lex_operator, push_back>: New methods.
5695         Update all rules.
5696         (rust_parser::lex_hex, lex_escape): Rename and update.
5697         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5698         (rust_parser::lex_operator): Rename and update.
5699         (rust_parser::lex_number, rustyylex, rustyyerror)
5700         (rust_lex_test_init, rust_lex_test_sequence)
5701         (rust_lex_test_push_back, rust_lex_tests): Update.
5702         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5703         parameter.
5704         <lexptr, prev_lexptr>: New members.
5705         (lexptr, prev_lexptr): Don't declare.
5706         * parse.c (lexptr, prev_lexptr): Remove globals.
5707         (parse_exp_in_context): Update.
5708         * p-exp.y (yylex, yyerror): Update.
5709         * m2-exp.y (parse_number, yylex, yyerror): Update.
5710         * go-exp.y (lex_one_token, yyerror): Update.
5711         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5712         * d-exp.y (lex_one_token, yyerror): Update.
5713         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5714         (lex_one_token, yyerror): Update.
5715         * ada-lex.l (YY_INPUT): Update.
5716         (rewind_to_char): Update.
5717         * ada-exp.y (yyerror): Update.
5718
5719 2019-04-04  Tom Tromey  <tom@tromey.com>
5720
5721         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5722         * parser-defs.h (struct parser_state) <parser_state>: Add new
5723         parameter.
5724         <comma_terminates>: New member.
5725         (comma_terminates): Don't declare global.
5726         * parse.c (comma_terminates): Remove global.
5727         (parse_exp_in_context): Update.
5728         * p-exp.y (yylex): Update.
5729         * m2-exp.y (yylex): Update.
5730         * go-exp.y (lex_one_token): Update.
5731         * f-exp.y (yylex): Update.
5732         * d-exp.y (lex_one_token): Update.
5733         * c-exp.y (lex_one_token): Update.
5734         * ada-lex.l: Update.
5735
5736 2019-04-04  Tom Tromey  <tom@tromey.com>
5737
5738         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5739         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5740         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5741         * parser-defs.h (paren_depth): Don't declare.
5742         * parse.c (paren_depth): Remove global.
5743         (parse_exp_in_context): Update.
5744         * p-exp.y (paren_depth): New global.
5745         (pascal_parse): Initialize it.
5746         * m2-exp.y (paren_depth): New global.
5747         (m2_parse): Initialize it.
5748         * go-exp.y (paren_depth): New global.
5749         (go_parse): Initialize it.
5750         * f-exp.y (paren_depth): New global.
5751         (f_parse): Initialize it.
5752         * d-exp.y (paren_depth): New global.
5753         (d_parse): Initialize it.
5754         * c-exp.y (paren_depth): New global.
5755         (c_parse): Initialize it.
5756         * ada-lex.l (paren_depth): New global.
5757         (lexer_init): Initialize it.
5758
5759 2019-04-04  Tom Tromey  <tom@tromey.com>
5760
5761         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5762         (rust_parser::convert_ast_to_type)
5763         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5764         * parser-defs.h (struct parser_state) <parser_state>: Add
5765         parameters.  Initialize new members.
5766         <expression_context_block, expression_context_pc>: New members.
5767         * parse.c (expression_context_block, expression_context_pc):
5768         Remove globals.
5769         (parse_exp_in_context): Update.
5770         * p-exp.y: Update all rules.
5771         (yylex): Update.
5772         * m2-exp.y: Update all rules.
5773         (yylex): Update.
5774         * go-exp.y (yylex): Update.
5775         * f-exp.y (yylex): Update.
5776         * d-exp.y: Update all rules.
5777         (yylex): Update.
5778         * c-exp.y: Update all rules.
5779         (lex_one_token, classify_name, yylex, c_parse): Update.
5780         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5781
5782 2019-04-04  Tom Tromey  <tom@tromey.com>
5783
5784         * gdbarch.h, gdbarch.c: Rebuild.
5785         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5786         * stap-probe.h:
5787         (struct stap_parse_info): Replace "parser_state" with
5788         "expr_builder".
5789         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5790         (parser_state): New class.
5791         * parse.c (expr_builder): Rename.
5792         (expr_builder::release): Rename.
5793         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5794         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5795         (write_exp_elt_longcst, write_exp_elt_floatcst)
5796         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5797         (write_exp_string_vector, write_exp_bitstring)
5798         (write_exp_msymbol, mark_struct_expression)
5799         (write_dollar_variable)
5800         (insert_type_address_space, increase_expout_size): Replace
5801         "parser_state" with "expr_builder".
5802         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5803         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5804         "parser_state" with "expr_builder".
5805
5806 2019-04-04  Tom Tromey  <tom@tromey.com>
5807
5808         * rust-exp.y: Replace "parse_language" with method call.
5809         * p-exp.y:
5810         (yylex): Replace "parse_language" with method call.
5811         * m2-exp.y:
5812         (yylex): Replace "parse_language" with method call.
5813         * go-exp.y (classify_name): Replace "parse_language" with method
5814         call.
5815         * f-exp.y (yylex): Replace "parse_language" with method call.
5816         * d-exp.y (lex_one_token): Replace "parse_language" with method
5817         call.
5818         * c-exp.y:
5819         (lex_one_token, classify_name, yylex): Replace "parse_language"
5820         with method call.
5821         * ada-exp.y (find_primitive_type, type_char)
5822         (type_system_address): Replace "parse_language" with method call.
5823
5824 2019-04-04  Tom Tromey  <tom@tromey.com>
5825
5826         * rust-exp.y: Replace "parse_gdbarch" with method call.
5827         * parse.c (write_dollar_variable, insert_type_address_space):
5828         Replace "parse_gdbarch" with method call.
5829         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5830         call.
5831         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5832         call.
5833         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5834         "parse_gdbarch" with method call.
5835         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5836         with method call.
5837         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5838         "parse_gdbarch" with method call.
5839         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5840         "parse_gdbarch" with method call.
5841         * c-exp.y (parse_type, parse_number, classify_name): Replace
5842         "parse_gdbarch" with method call.
5843         * ada-lex.l: Replace "parse_gdbarch" with method call.
5844         * ada-exp.y (parse_type, find_primitive_type, type_char)
5845         (type_system_address): Replace "parse_gdbarch" with method call.
5846
5847 2019-04-04  Tom Tromey  <tom@tromey.com>
5848
5849         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5850         * stap-probe.c (stap_parse_argument): Update.
5851         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5852         initial_size parameter.
5853         * rust-exp.y (rust_lex_tests): Update.
5854         * parse.c (parser_state): Update.
5855         (parse_exp_in_context): Update.
5856         * parser-defs.h (struct parser_state) <parser_state>: Remove
5857         "initial_size" parameter.
5858
5859 2019-04-04  Tom Tromey  <tom@tromey.com>
5860
5861         * parser-defs.h (increase_expout_size): Don't declare.
5862         * parse.c (increase_expout_size): Now static.
5863
5864 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5865
5866         * gnu-nat.c (gnu_nat_target::wait): Fix
5867         target_waitstatus_to_string call.
5868
5869 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5870
5871         * eval.c (evaluate_subexp_standard): Handle internal functions
5872         during Fortran function call handling.
5873
5874 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5875
5876         * NEWS: Mention new internal functions.
5877         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5878         (read_base_type): Use dwarf2_init_complex_target_type.
5879         * value.c (creal_internal_fn): New function.
5880         (cimag_internal_fn): New function.
5881         (_initialize_values): Register new internal functions.
5882
5883 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5884
5885         * infrun.c (stop_all_threads): If debug_infrun, always
5886         trace the wait status after wait_one, using
5887         target_waitstatus_to_string and target_pid_to_str.
5888         (handle_inferior_event): Replace various trace of
5889         wait status kind by a single trace.
5890         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5891         wait status kind image by target_waitstatus_to_string.
5892         * target/waitstatus.c (target_waitstatus_to_string): Fix
5893         obsolete comment.
5894
5895 2019-04-01  Tom Tromey  <tromey@adacore.com>
5896
5897         PR symtab/23331:
5898         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5899
5900 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5901             Pedro Alves  <palves@redhat.com>
5902
5903         * top.c (quit_force): Call 'finalize_values'.
5904         * value.c (finalize_values): New function.
5905         * value.h (finalize_values): Declare.
5906
5907 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5908
5909         * NEWS: Announce $_gdb_major and $_gdb_minor.
5910
5911         * top.c (init_gdb_version_vars): New function.
5912         (gdb_init): Call init_gdb_version_vars.
5913
5914 2019-03-29  Tom Tromey  <tromey@adacore.com>
5915
5916         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5917         help text.  Remove dead code.
5918
5919 2019-03-29  Keith Seitz  <keiths@redhat.com>
5920
5921         From Siddhesh Poyarekar:
5922         * f-lang.h (f77_get_upperbound): Return LONGEST.
5923         (f77_get_lowerbound): Likewise.
5924         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5925         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5926         print them.
5927         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5928         plongest to format print it.
5929         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5930         (f77_get_upperbound): Likewise.
5931         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5932         LOWER_BOUND to LONGEST.
5933         (f77_create_arrayprint_offset_tbl): Likewise.
5934
5935 2019-03-29  Keith Seitz  <keiths@redhat.com>
5936
5937         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5938         %s/pulongest for TYPE_LENGTH instead of %d in format
5939         strings.
5940         * ada-typerint.c (ada_print_type): Likewise.
5941         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5942         * compile/compile-c-support.c (generate_register_struct): Likewise.
5943         * gdbtypes.c (recursive_dump_type): Likewise.
5944         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5945         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5946         instead of %d in format strings.
5947         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5948         to std::min to ULONGEST.
5949         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5950         instead of %d in format strings.
5951         * tracepoint.c (info_scope_command): Likewise.
5952         * typeprint.c (print_offset_data::update)
5953         (print_offset_data::finish): Likewise.
5954         * xtensa-tdep.c (xtensa_store_return_value)
5955         (xtensa_push_dummy_call): Likewise.
5956
5957 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5958
5959         * windows-nat.c (display_selector): Fixed format specifications
5960         for 64-bit Cygwin.
5961
5962 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5963
5964         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5965
5966 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5967
5968         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5969         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5970         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5971         (nios2_linux_init_abi): Install it.
5972
5973 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5974
5975         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5976
5977 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5978
5979         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5980
5981 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5982             Tom Tromey  <tromey@adacore.com>
5983
5984         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5985
5986 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5987
5988         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5989         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5990         method to compute the bounds of range types. Also print "[evaluated]"
5991         if the bounds' values come from a dynamic evaluation.
5992
5993 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5994
5995         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5996         whitespace when pretty printing is on.
5997
5998 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5999
6000         * ppc-linux-nat.c: Add include.
6001
6002 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6003
6004         * NEWS: Mention AArch64 Pointer Authentication.
6005
6006 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6007
6008         * arm-linux-nat.c: Add include.
6009
6010 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6011
6012         * source-cache.c (source_cache::get_source_lines): Re-read
6013         fullname after calling open_source_file.
6014
6015 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6016
6017         * NEWS: Mention TLS support for FreeBSD.
6018
6019 2019-03-25  Tom Tromey  <tromey@adacore.com>
6020
6021         * minsyms.c (BUNCH_SIZE): Update comment.
6022         (~minimal_symbol_reader): Remove old comment.
6023         (compact_minimal_symbols): Update comment.
6024         (minimal_symbol_reader::install): Remove old comment.  Update
6025         other comments.
6026
6027 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6028
6029         * s390-linux-nat.c: Add include.
6030
6031 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6032
6033         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6034         Call linux_get_hwcap.
6035         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6036         Likewise.
6037         (aarch64_linux_get_hwcap): Remove function.
6038         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6039         declaration.
6040         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6041         linux_get_hwcap.
6042         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6043         * linux-tdep.c (linux_get_hwcap): Add function.
6044         (linux_get_hwcap2): Likewise.
6045         * linux-tdep.h (linux_get_hwcap): Add declaration.
6046         (linux_get_hwcap2): Likewise.
6047         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6048         (ppc_linux_get_hwcap2): Likewise.
6049         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6050         linux_get_hwcap.
6051         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6052         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6053         (ppc_linux_nat_target::read_description): Likewise.
6054         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6055         * s390-linux-nat.c: Likewise.
6056         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6057
6058 2019-03-24  Tom Tromey  <tom@tromey.com>
6059
6060         * ada-lang.c (standard_lookup): Simplify initialization.
6061         (ada_lookup_symbol_nonlocal): Simplify return.
6062         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6063         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6064         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6065         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6066         initialization.
6067         * solib.c (solib_global_lookup): Simplify.
6068         * symtab.c (null_block_symbol): Remove.
6069         (symbol_cache_lookup): Simplify returns.
6070         (lookup_language_this): Simplify returns.
6071         (lookup_symbol_aux): Simplify return.
6072         (lookup_local_symbol): Simplify returns.
6073         (lookup_global_symbol_from_objfile): Simplify return.
6074         (lookup_symbol_in_objfile_symtabs)
6075         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6076         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6077         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6078         * cp-namespace.c (cp_lookup_bare_symbol)
6079         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6080         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6081         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6082         (cp_lookup_symbol_via_imports): Simplify initialization.
6083         (find_symbol_in_baseclass): Likewise.
6084         * symtab.h (null_block_symbol): Remove.
6085         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6086         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6087         (d_lookup_symbol_module): Likewise.
6088         (find_symbol_in_baseclass): Simplify initialization.
6089
6090 2019-03-24  Tom Tromey  <tom@tromey.com>
6091
6092         * expression.h: Don't include symtab.h.
6093         (struct block): Forward declare.
6094
6095 2019-03-24  Tom Tromey  <tom@tromey.com>
6096
6097         * c-exp.y (typebase): Remove casts.
6098         * gdbtypes.c (lookup_unsigned_typename, )
6099         (lookup_signed_typename): Remove cast.
6100         * eval.c (parse_to_comma_and_eval): Remove cast.
6101         * parse.c (write_dollar_variable): Remove cast.
6102         * block.h (struct block) <superblock>: Now const.
6103         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6104         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6105         (map_block): Make "block" const.
6106         * symfile.h (struct quick_symbol_functions)
6107         <map_matching_symbols>: Constify block argument to "callback".
6108         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6109         const.
6110         (find_pc_sect_compunit_symtab): Make "b" const.
6111         (find_symbol_at_address): Likewise.
6112         (search_symbols): Likewise.
6113         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6114         (dw2_debug_names_lookup_symbol): Likewise.
6115         (dw2_map_matching_symbols): Update.
6116         * p-valprint.c (pascal_val_print): Remove "block".
6117         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6118         (aux_add_nonlocal_symbols): Make "block" const.
6119         (resolve_subexp): Remove cast.
6120         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6121         const.
6122         (iterate_over_file_blocks): Likewise.
6123         * f-exp.y (%union) <bval>: Remove.
6124         * coffread.c (patch_opaque_types): Make "b" const.
6125         * spu-tdep.c (spu_catch_start): Make "block" const.
6126         * c-valprint.c (print_unpacked_pointer): Remove "block".
6127         * symmisc.c (dump_symtab_1): Make "b" const.
6128         (block_depth): Make "block" const.
6129         * d-exp.y (%union) <bval>: Remove.
6130         * cp-support.h (cp_lookup_rtti_type): Update.
6131         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6132         * psymtab.c (psym_lookup_symbol): Make "block" const.
6133         (maintenance_check_psymtabs): Make "b" const.
6134         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6135         (enumerate_locals, enumerate_args): Update.
6136         * python/py-symtab.c (stpy_global_block): Make "block" const.
6137         (stpy_static_block): Likewise.
6138         * inline-frame.c (block_starting_point_at): Make "new_block"
6139         const.
6140         * block.c (find_block_in_blockvector): Make return type const.
6141         (blockvector_for_pc_sect): Make "b" const.
6142         (find_block_in_blockvector): Make "b" const.
6143
6144 2019-03-23  Tom Tromey  <tom@tromey.com>
6145
6146         * varobj.c (varobj_create): Update.
6147         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6148         * printcmd.c (display_command, do_one_display): Don't reset
6149         innermost_block.
6150         * parser-defs.h (enum innermost_block_tracker_type): Move to
6151         expression.h.
6152         (innermost_block): Update comment.
6153         * parse.c (parse_exp_1): Add tracker_types parameter.
6154         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6155         tracker_types parameter.  Reset innermost_block.
6156         (parse_exp_in_context): Remove.
6157         (parse_expression_for_completion): Update.
6158         * objfiles.c (~objfile): Don't reset expression_context_block or
6159         innermost_block.
6160         * expression.h (enum innermost_block_tracker_type): Move from
6161         parser-defs.h.
6162         (parse_exp_1): Add tracker_types parameter.
6163         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6164         reset innermost_block.
6165
6166 2019-03-23  Tom Tromey  <tom@tromey.com>
6167
6168         * objfiles.h: Include bcache.h.
6169
6170 2019-03-23  Tom Tromey  <tom@tromey.com>
6171
6172         * linespec.c (get_current_search_block): Use
6173         scoped_restore_current_language.
6174         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6175
6176 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6177             Jiong Wang  <jiong.wang@arm.com>
6178
6179         * aarch64-linux-tdep.c
6180         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6181         section.
6182         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6183
6184 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6185             Jiong Wang  <jiong.wang@arm.com>
6186
6187         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6188         instructions.
6189         (aarch64_analyze_prologue_test): Add PACIASP test.
6190         (aarch64_prologue_prev_register): Unmask PC value.
6191
6192 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6193             Jiong Wang  <jiong.wang@arm.com>
6194
6195         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6196         (aarch64_dwarf2_prev_register): Unmask PC value.
6197         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6198         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6199         DW_CFA_AARCH64_negate_ra_state.
6200         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6201
6202 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6203             Jiong Wang  <jiong.wang@arm.com>
6204
6205         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6206         registers.
6207         (aarch64_pseudo_register_name): Likewise.
6208         (aarch64_pseudo_register_type): Likewise.
6209         (aarch64_pseudo_register_reggroup_p): Likewise.
6210         (aarch64_gdbarch_init): Add pauth registers.
6211         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6212         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6213         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6214         (struct gdbarch_tdep): Add regnum for ra_state.
6215
6216 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6217             Jiong Wang  <jiong.wang@arm.com>
6218
6219         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6220
6221 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6222             Jiong Wang  <jiong.wang@arm.com>
6223
6224         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6225         function.
6226         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6227         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6228         (aarch64_gdbarch_init): Add puth registers.
6229         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6230         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6231         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6232
6233 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6234             Jiong Wang  <jiong.wang@arm.com>
6235
6236         * aarch64-linux-nat.c
6237         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6238         * aarch64-linux-tdep.c
6239         (aarch64_linux_core_read_description): Likewise.
6240         (aarch64_linux_get_hwcap): New function.
6241         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6242         (aarch64_linux_get_hwcap): New declaration.
6243
6244 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6245             Jiong Wang  <jiong.wang@arm.com>
6246
6247         * aarch64-linux-nat.c
6248         (aarch64_linux_nat_target::read_description): Add pauth param.
6249         * aarch64-linux-tdep.c
6250         (aarch64_linux_core_read_description): Likewise.
6251         * aarch64-tdep.c (struct target_desc): Add in pauth.
6252         (aarch64_read_description): Add pauth param.
6253         (aarch64_gdbarch_init): Likewise.
6254         * aarch64-tdep.h (aarch64_read_description): Likewise.
6255         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6256         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6257         * features/Makefile: Add new files.
6258         * features/aarch64-pauth.c: New file.
6259         * features/aarch64-pauth.xml: New file.
6260
6261 2019-03-20  Tom Tromey  <tromey@adacore.com>
6262
6263         * infrun.c (handle_inferior_event): Rename from
6264         handle_inferior_event_1.  Create a scoped_value_mark.
6265         (handle_inferior_event): Remove.
6266
6267 2019-03-19  Tom Tromey  <tromey@adacore.com>
6268
6269         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6270         * infrun.h (print_stop_event): Add "displays" parameter.
6271         * infrun.c (print_stop_event): Add "displays" parameter.
6272
6273 2019-03-19  Pedro Alves  <palves@redhat.com>
6274
6275         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6276         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6277         to -1.  Fix TABs vs spaces.
6278         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6279         * tui/tui-out.h (tui_ui_out) Add intro comments.
6280         <m_line, m_start_of_line>: In-class initialize, and add describing
6281         comment.
6282
6283 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6284
6285         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6286         variable names.
6287         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6288
6289 2019-03-18  Pedro Alves  <palves@redhat.com>
6290             Eli Zaretskii <eliz@gnu.org>
6291
6292         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6293         m_line and m_start_of_line.
6294
6295 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6296
6297         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6298         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6299         it returns a newline.  This fixes a regression in TU mode, whereby
6300         the next line is output on the same screen line as the user input.
6301
6302 2019-03-18  Tom Tromey  <tromey@adacore.com>
6303
6304         * minsyms.c (minimal_symbol_reader::install): Remove call to
6305         obstack_blank.
6306
6307 2019-03-18  Pedro Alves  <palves@redhat.com>
6308
6309         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6310         New globals.
6311         (apply_style): New, factored out from ...
6312         (apply_ansi_escape): ... this.  Handle reverse video mode.
6313         (tui_set_reverse_mode): New function.
6314         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6315         * tui/tui-winsource.c (tui_show_source_line): Use
6316         tui_set_reverse_mode instead of setting A_STANDOUT.
6317         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6318         New setter methods.
6319
6320 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6321
6322         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6323         Handle tabs.
6324
6325 2019-03-18  Tom Tromey  <tromey@adacore.com>
6326
6327         * ada-lang.c (empty_array): Add "high" parameter.
6328         (ada_evaluate_subexp): Update.
6329
6330 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6331
6332         * unittests/string_view-selftests.c: Define
6333         _initialize_string_view_selftests unconditionally.
6334
6335 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6336
6337         PR gdb/24350
6338         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6339
6340 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6341
6342         PR gdb/24351
6343         * windows-nat.c (display_selector): Fix format specifiers.
6344
6345 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6346
6347         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6348         tui_refill_source_window instead of tui_refresh_win, to update the
6349         current execution line.  This fixes redisplay of the current line
6350         when stepping through the code with "next" or "step".
6351
6352 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6353
6354         * source-cache.c (source_cache::get_source_lines): Call
6355         find_source_lines to initialize s->nlines.  This fixes vertical
6356         scrolling of TUI source window when the DOWN arrow is pressed.
6357
6358 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6359
6360         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6361         linux-thread-db.c (_initialize_thread_db): Likewise.
6362
6363 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6364
6365         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6366         wclrtoeol in tui_show_source_line".  This reverts changes made in
6367         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6368
6369 2019-03-15  Tom Tromey  <tom@tromey.com>
6370
6371         * symtab.h (struct minimal_symbol): Derive from
6372         general_symbol_info.
6373         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6374         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6375         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6376         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6377         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6378         (MSYMBOL_SEARCH_NAME): Update.
6379         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6380         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6381         * minsyms.c (minimal_symbol_reader::record_full): Update.
6382
6383 2019-03-15  Tom Tromey  <tom@tromey.com>
6384
6385         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6386
6387 2019-03-15  Tom Tromey  <tom@tromey.com>
6388
6389         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6390         unique_xmalloc_ptr.
6391         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6392         Update.
6393         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6394         (build_minimal_symbol_hash_tables)
6395         (minimal_symbol_reader::install): Update.
6396
6397 2019-03-15  Tom Tromey  <tom@tromey.com>
6398
6399         * symtab.c (create_demangled_names_hash): Update.
6400         (symbol_set_names): Update.
6401         * objfiles.h (struct objfile_per_bfd_storage)
6402         <demangled_names_hash>: Now an htab_up.
6403         * objfiles.c (objfile_per_bfd_storage): Simplify.
6404
6405 2019-03-15  Tom Tromey  <tom@tromey.com>
6406
6407         * objfiles.h (struct objfile_per_bfd_storage): Declare
6408         destructor.
6409         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6410         New.
6411         (get_objfile_bfd_data): Use new.  Don't initialize
6412         language_of_main.
6413         (free_objfile_per_bfd_storage): Remove.
6414         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6415
6416 2019-03-15  Tom Tromey  <tom@tromey.com>
6417
6418         * symfile.c (reread_symbols): Update.
6419         * objfiles.c (objfile::objfile): Update.
6420         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6421         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6422         comment.
6423         (minimal_symbol_reader::install): Update.
6424         (terminate_minimal_symbol_table): Remove.
6425         * jit.c (jit_object_close_impl): Update.
6426
6427 2019-03-15  Tom Tromey  <tom@tromey.com>
6428
6429         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6430         initializations.
6431
6432 2019-03-15  Tom Tromey  <tom@tromey.com>
6433
6434         * objfiles.h (struct objfile_per_bfd_storage)
6435         <demangled_hash_languages>: Now a bitset.
6436         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6437         (lookup_minimal_symbol): Update.
6438
6439 2019-03-15  Tom Tromey  <tom@tromey.com>
6440
6441         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6442         Don't return the symbol.
6443         * coffread.c (record_minimal_symbol): Use record_full.
6444
6445 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6446
6447         The MS-Windows port of ncurses fails to switch to a color pair if
6448         one or both of the colors are the implicit default colors.  This
6449         change records the default colors when TUI is initialized, and
6450         then specifies them explicitly when a color pair uses the default
6451         colors.  This allows color styling in TUI mode on MS-Windows.
6452
6453         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6454         ncurses_norm_attr.
6455         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6456         colors in ncurses_norm_attr.
6457         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6458         "none", replace it with the default color recorded in
6459         ncurses_norm_attr.
6460
6461 2019-03-14  Tom Tromey  <tromey@adacore.com>
6462
6463         * source-cache.h (class source_cache) <get_source_lines>: Return
6464         std::string.
6465         * source-cache.c (source_cache::extract_lines): Handle case where
6466         first_pos==npos.  Return std::string.
6467         (source_cache::get_source_lines): Update.
6468
6469 2019-03-14  Tom Tromey  <tromey@adacore.com>
6470
6471         * NEWS: Add item for "style sources" commands.
6472         * source-cache.c (source_cache::get_source_lines): Check
6473         source_styling.
6474         * cli/cli-style.c (source_styling): New global.
6475         (_initialize_cli_style): Add "style sources" commands.
6476         (show_style_sources): New function.
6477         * cli/cli-style.h (source_styling): Declare.
6478
6479 2019-03-14  Pedro Alves  <palves@redhat.com>
6480             Tom Tromey  <tromey@adacore.com>
6481
6482         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6483         * tui/tui-winsource.c (tui_refill_source_window): New function,
6484         from...
6485         (tui_horizontal_source_scroll): ... here.  Move some logic.
6486         * cli/cli-style.c (set_style_enabled): Notify new observable.
6487         * tui/tui-hooks.c (tui_redisplay_source): New function.
6488         (tui_attach_detach_observers): Attach or detach
6489         tui_redisplay_source.
6490         * observable.h (source_styling_changed): New observable.
6491         * observable.c: Define source_styling_changed observable.
6492
6493 2019-03-13  Tom Tromey  <tromey@adacore.com>
6494
6495         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6496         (i386_gnu_nat_target::store_registers): Update.
6497         * target-debug.h (target_debug_print_std_string): New macro.
6498         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6499         * windows-tdep.c (display_one_tib): Update.
6500         * tui/tui-stack.c (tui_make_status_line): Update.
6501         * top.c (print_inferior_quit_action): Update.
6502         * thread.c (thr_try_catch_cmd): Update.
6503         (add_thread_with_info): Update.
6504         (thread_target_id_str): Update.
6505         (thr_try_catch_cmd): Update.
6506         (thread_command): Update.
6507         (thread_find_command): Update.
6508         * record-btrace.c (record_btrace_target::info_record)
6509         (record_btrace_resume_thread, record_btrace_target::resume)
6510         (record_btrace_cancel_resume, record_btrace_step_thread)
6511         (record_btrace_target::wait, record_btrace_target::wait)
6512         (record_btrace_target::wait, record_btrace_target::stop): Update.
6513         * progspace.c (print_program_space): Update.
6514         * process-stratum-target.c
6515         (process_stratum_target::thread_address_space): Update.
6516         * linux-fork.c (linux_fork_mourn_inferior)
6517         (detach_checkpoint_command, info_checkpoints_command)
6518         (linux_fork_context): Update.
6519         (linux_fork_detach): Update.
6520         (class scoped_switch_fork_info): Update.
6521         (delete_checkpoint_command): Update.
6522         * infrun.c (follow_fork_inferior): Update.
6523         (follow_fork_inferior): Update.
6524         (proceed_after_vfork_done): Update.
6525         (handle_vfork_child_exec_or_exit): Update.
6526         (follow_exec): Update.
6527         (displaced_step_prepare_throw): Update.
6528         (displaced_step_restore): Update.
6529         (start_step_over): Update.
6530         (resume_1): Update.
6531         (clear_proceed_status_thread): Update.
6532         (proceed): Update.
6533         (print_target_wait_results): Update.
6534         (do_target_wait): Update.
6535         (context_switch): Update.
6536         (stop_all_threads): Update.
6537         (restart_threads): Update.
6538         (finish_step_over): Update.
6539         (handle_signal_stop): Update.
6540         (switch_back_to_stepped_thread): Update.
6541         (keep_going_pass_signal): Update.
6542         (print_exited_reason): Update.
6543         (normal_stop): Update.
6544         * inferior.c (inferior_pid_to_str): Change return type.
6545         (print_selected_inferior): Update.
6546         (add_inferior): Update.
6547         (detach_inferior): Update.
6548         * dummy-frame.c (fprint_dummy_frames): Update.
6549         * dcache.c (dcache_info_1): Update.
6550         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6551         (btrace_fetch, btrace_clear): Update.
6552         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6553         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6554         type.
6555         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6556         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6557         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6558         * gdbarch.c, gdbarch.h: Rebuild.
6559         * gdbarch.sh (core_pid_to_str): Change return type.
6560         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6561         return type.
6562         (windows_nat_target::pid_to_str): Change return type.
6563         (windows_delete_thread): Update.
6564         (windows_nat_target::attach): Update.
6565         (windows_nat_target::files_info): Update.
6566         * target-delegates.c: Rebuild.
6567         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6568         return type.
6569         (sol_thread_target::pid_to_str): Change return type.
6570         * remote.c (class remote_target) <pid_to_str>: Change return
6571         type.
6572         (remote_target::pid_to_str): Change return type.
6573         (extended_remote_target::attach, remote_target::remote_stop_ns)
6574         (remote_target::remote_notif_remove_queued_reply)
6575         (remote_target::push_stop_reply, remote_target::disable_btrace):
6576         Update.
6577         (extended_remote_target::attach): Update.
6578         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6579         type.
6580         (gdbsim_target::pid_to_str): Change return type.
6581         * ravenscar-thread.c (struct ravenscar_thread_target)
6582         <pid_to_str>: Change return type.
6583         (ravenscar_thread_target::pid_to_str): Change return type.
6584         * procfs.c (class procfs_target) <pid_to_str>: Change return
6585         type.
6586         (procfs_target::pid_to_str): Change return type.
6587         (procfs_target::attach): Update.
6588         (procfs_target::detach): Update.
6589         (procfs_target::fetch_registers): Update.
6590         (procfs_target::store_registers): Update.
6591         (procfs_target::wait): Update.
6592         (procfs_target::files_info): Update.
6593         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6594         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6595         return type.
6596         (nto_procfs_target::pid_to_str): Change return type.
6597         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6598         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6599         return type.
6600         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6601         (exit_lwp): Update.
6602         (attach_proc_task_lwp_callback, get_detach_signal)
6603         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6604         (linux_nat_target::resume, wait_lwp, stop_callback)
6605         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6606         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6607         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6608         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6609         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6610         type.
6611         (inf_ptrace_target::attach): Update.
6612         (inf_ptrace_target::files_info): Update.
6613         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6614         type.
6615         (go32_nat_target::pid_to_str): Change return type.
6616         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6617         (gnu_nat_target::wait): Update.
6618         (gnu_nat_target::wait): Update.
6619         (gnu_nat_target::resume): Update.
6620         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6621         (fbsd_nat_target::wait): Update.
6622         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6623         type.
6624         (darwin_nat_target::attach): Update.
6625         * corelow.c (class core_target) <pid_to_str>: Change return type.
6626         (core_target::pid_to_str): Change return type.
6627         * target.c (normal_pid_to_str): Change return type.
6628         (default_pid_to_str): Likewise.
6629         (target_pid_to_str): Change return type.
6630         (target_translate_tls_address): Update.
6631         (target_announce_detach): Update.
6632         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6633         return type.
6634         (bsd_uthread_target::pid_to_str): Change return type.
6635         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6636         type.
6637         (bsd_kvm_target::pid_to_str): Change return type.
6638         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6639         return type.
6640         (aix_thread_target::pid_to_str): Change return type.
6641         * target.h (struct target_ops) <pid_to_str>: Change return type.
6642         (target_pid_to_str, normal_pid_to_str): Likewise.
6643         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6644         type.
6645         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6646         type.
6647         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6648         return type.
6649         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6650         type.
6651         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6652         type.
6653         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6654         return type.
6655
6656 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6657
6658         * NEWS: Mention that the new default MI version is 3.  Mention
6659         changes to the output of commands and events that deal with
6660         multi-location breakpoints.
6661         * breakpoint.c: Include "mi/mi-out.h".
6662         (print_one_breakpoint): Change output syntax if using MI version
6663         >= 3.
6664         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6665         New.
6666         (mi_multi_location_breakpoint_output_fixed): New.
6667         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6668         (mi_cmd_fix_multi_location_breakpoint_output): New.
6669         (mi_multi_location_breakpoint_output_fixed): New.
6670         * mi/mi-cmds.c (mi_cmds): Register command
6671         -fix-multi-location-breakpoint-output.
6672         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6673         interpreter "mi".
6674
6675 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6676
6677         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6678         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6679         instantiate mi_ui_out based on interpreter name.
6680         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6681         * mi/mi-main.c (mi_load_progress): Likewise.
6682
6683 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6684
6685         * NEWS: Combine separate "New targets" sections for 8.3.
6686
6687 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6688
6689         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6690         (ppcfbsd_init_abi): Install gdbarch
6691         "fetch_tls_load_module_address" and "get_thread_local_address"
6692         methods.
6693
6694 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6695
6696         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6697         (riscv_fbsd_init_abi): Install gdbarch
6698         "fetch_tls_load_module_address" and "get_thread_local_address"
6699         methods.
6700
6701 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6702
6703         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6704         (i386fbsd_init_abi): Install gdbarch
6705         "fetch_tls_load_module_address" and "get_thread_local_address"
6706         methods.
6707
6708 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6709
6710         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6711         (amd64fbsd_init_abi): Install gdbarch
6712         "fetch_tls_load_module_address" and "get_thread_local_address"
6713         methods.
6714
6715 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6716
6717         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6718         (struct fbsd_pspace_data): New type.
6719         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6720         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6721         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6722         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6723         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6724
6725 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6726
6727         * gdbtypes.c (lookup_struct_elt): New function.
6728         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6729         * gdbtypes.h (struct struct_elt): New type.
6730         (lookup_struct_elt): New prototype.
6731
6732 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6733
6734         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6735         remove disabled code block.
6736
6737 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6738
6739         * gdbarch.sh (get_thread_local_address): New method.
6740         * gdbarch.h, gdbarch.c: Regenerate.
6741         * target.c (target_translate_tls_address): Use
6742         gdbarch_get_thread_local_address if present instead of
6743         target::get_thread_local_address.
6744
6745 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6746
6747         * target.h (target::get_thread_local_address): Update comment.
6748
6749 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6750
6751         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6752         objfile->separate_debug_objfile_backlink if not NULL.
6753
6754 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6755
6756         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6757         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6758         (amd64bsd_store_inferior_registers): Likewise.
6759         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6760         Enable segment base registers.
6761         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6762         PT_GETFSBASE and PT_GETGSBASE.
6763         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6764         PT_SETGSBASE.
6765         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6766         segment base registers.
6767         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6768
6769 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6770
6771         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6772         Update calls to i386_target_description to add 'segments'
6773         parameter.
6774         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6775         add segment base registers.
6776         * arch/i386.c (i386_create_target_description): Add 'segments'
6777         parameter to enable segment base registers.
6778         * arch/i386.h (i386_create_target_description): Likewise.
6779         * features/i386/32bit-segments.xml: New file.
6780         * features/i386/32bit-segments.c: Generate.
6781         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6782         call to i386_target_description to add 'segments' parameter.
6783         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6784         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6785         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6786         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6787         if feature is present.
6788         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6789         Add 'segments' parameter to call to i386_target_description.
6790         (i386_target_description): Add 'segments' parameter to enable
6791         segment base registers.
6792         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6793         to call to i386_target_description.
6794         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6795         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6796         Define I386_NUM_REGS.
6797         (i386_target_description): Add 'segments' parameter to enable
6798         segment base registers.
6799
6800 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6801
6802         PR/24325
6803         * source-cache.c: #undef open and close, to avoid unresolved
6804         externals during linking.
6805
6806 2019-03-12  Tom Tromey  <tromey@adacore.com>
6807
6808         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6809         const.  Add initializers.
6810         (_initialize_remote): Don't initialize ptid globals.
6811
6812 2019-03-12  Pedro Alves  <palves@redhat.com>
6813
6814         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6815
6816 2019-03-12  Pedro Alves  <palves@redhat.com>
6817
6818         * cp-name-parser.y (main): Remove unused 'len' variable.
6819
6820 2019-03-12  Tom Tromey  <tromey@adacore.com>
6821
6822         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6823         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6824
6825 2019-03-12  Tom Tromey  <tromey@adacore.com>
6826
6827         * linux-nat.c (iterate_over_lwps): Update.
6828         (stop_callback): Remove parameter.
6829         (stop_wait_callback, detach_callback, resume_set_callback)
6830         (select_singlestep_lwp_callback, set_ignore_sigint)
6831         (status_callback, resumed_callback, resume_clear_callback)
6832         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6833         data parameter.
6834         (linux_nat_target::detach, linux_nat_target::resume)
6835         (linux_stop_and_wait_all_lwps, select_event_lwp)
6836         (linux_nat_filter_event, linux_nat_wait_1)
6837         (linux_nat_target::kill, linux_nat_target::stop)
6838         (linux_nat_target::stop): Update.
6839         (linux_nat_resume_callback): Change type.
6840         (resume_stopped_resumed_lwps, count_events_callback)
6841         (select_event_lwp_callback): Likewise.
6842         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6843         * arm-linux-nat.c (struct update_registers_data): Remove.
6844         (update_registers_callback): Change type.
6845         (arm_linux_insert_hw_breakpoint1): Update.
6846         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6847         parameter.
6848         (x86_linux_dr_set_addr): Update.
6849         (x86_linux_dr_set_control): Update.
6850         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6851         (iterate_over_lwps): Use gdb::function_view.
6852         * nat/aarch64-linux-hw-point.c (struct
6853         aarch64_dr_update_callback_param): Remove.
6854         (debug_reg_change_callback): Change type.
6855         (aarch64_notify_debug_reg_change): Update.
6856         * s390-linux-nat.c (s390_refresh_per_info): Update.
6857
6858 2019-03-11  Tom Tromey  <tromey@adacore.com>
6859
6860         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6861         redundant assignment to "this_cu".
6862
6863 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6864
6865         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6866
6867 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6868
6869         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6870         from...
6871         (rank_one_type): ... this.
6872
6873 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6874
6875         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6876         from...
6877         (rank_one_type): ... this.
6878
6879 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6880
6881         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6882         from...
6883         (rank_one_type): ... this.
6884
6885 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6886
6887         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6888         from...
6889         (rank_one_type): ... this.
6890
6891 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6892
6893         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6894         from...
6895         (rank_one_type): ... this.
6896
6897 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6898
6899         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6900         from...
6901         (rank_one_type): ... this.
6902
6903 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6904
6905         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6906         from...
6907         (rank_one_type): ... this.
6908
6909 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6910
6911         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6912         from...
6913         (rank_one_type): ... this.
6914
6915 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6916
6917         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6918         from...
6919         (rank_one_type): ... this.
6920
6921 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6922
6923         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6924         from...
6925         (rank_one_type): ... this.
6926
6927 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6928
6929         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6930         from...
6931         (rank_one_type): ... this.
6932
6933 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6934
6935         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6936         from...
6937         (rank_one_type): ... this.
6938
6939 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6940
6941         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6942         inferior-events' shows the example events.
6943
6944 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6945
6946         Support styling on native MS-Windows console
6947
6948         PR/24315
6949         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6950         on MS-Windows if $TERM is not defined.
6951
6952         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6953
6954         * posix-hdep.c (gdb_console_fputs):
6955         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6956         functions.
6957         * ui-file.h (gdb_console_fputs): Add prototype.
6958
6959         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6960         back to fputs only if the former returns zero.
6961
6962 2019-03-07  Tom Tromey  <tom@tromey.com>
6963
6964         * symmisc.c (print_symbol_bcache_statistics): Update.
6965         (print_objfile_statistics): Update.
6966         * symfile.c (allocate_symtab): Update.
6967         * stabsread.c: Don't include bcache.h.
6968         * psymtab.h (struct psymbol_bcache): Don't declare.
6969         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6970         (psymbol_bcache_init, psymbol_bcache_free)
6971         (psymbol_bcache_get_bcache): Don't declare.
6972         * psymtab.c (struct psymbol_bcache): Remove.
6973         (psymtab_storage::psymtab_storage): Update.
6974         (psymtab_storage::~psymtab_storage): Update.
6975         (psymbol_bcache_init, psymbol_bcache_free)
6976         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6977         (add_psymbol_to_bcache): Update.
6978         (allocate_psymtab): Update.
6979         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6980         macro_cache>: No longer pointers.
6981         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6982         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6983         * macrotab.c (macro_bcache): Update.
6984         * macroexp.c: Don't include bcache.h.
6985         * gdbtypes.c (check_types_worklist): Update.
6986         (types_deeply_equal): Remove TRY/CATCH.  Update.
6987         * elfread.c (elf_symtab_read): Update.
6988         * dwarf2read.c: Don't include bcache.h.
6989         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6990         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6991         (print_bcache_statistics, bcache_memory_used): Don't declare.
6992         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6993         methods.  Rename all data members.
6994         * bcache.c (struct bcache): Move to bcache.h.
6995         (bcache::expand_hash_table): Rename from expand_hash_table.
6996         (bcache): Remove.
6997         (bcache::insert): Rename from bcache_full.
6998         (bcache::compare): Rename from bcache_compare.
6999         (bcache_xmalloc): Remove.
7000         (bcache::~bcache): Rename from bcache_xfree.
7001         (bcache::print_statistics): Rename from print_bcache_statistics.
7002         (bcache::memory_used): Rename from bcache_memory_used.
7003
7004 2019-03-07  Pedro Alves  <palves@redhat.com>
7005
7006         * infrun.c (normal_stop): Also check for
7007         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7008
7009 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7010
7011         * f-lang.c (value_from_host_double): Moved to...
7012         * value.c (value_from_host_double): ...here.
7013         * value.h (value_from_host_double): Declare.
7014         * guile/scm-math.c (vlscm_convert_typed_number): Use
7015         value_from_host_double.
7016         (vlscm_convert_number): Likewise.
7017         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7018         * python/py-value.c (convert_value_from_python): Likewise.
7019
7020 2019-03-06  Tom Tromey  <tom@tromey.com>
7021
7022         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7023
7024 2019-03-06  Tom Tromey  <tom@tromey.com>
7025
7026         * utils.h (free_current_contents): Don't declare.
7027         * utils.c (free_current_contents): Remove.
7028
7029 2019-03-06  Tom Tromey  <tom@tromey.com>
7030
7031         * top.c (quit_force): Update.
7032         * main.c (captured_command_loop): Update.
7033         * common/new-op.c (operator new): Update.
7034         * common/common-exceptions.c (struct catcher)
7035         <save_cleanup_chain>: Remove member.
7036         (exceptions_state_mc_init): Update.
7037         (exception_try_scope_entry): Return nullptr.
7038         (exception_try_scope_exit, exception_rethrow)
7039         (throw_exception_sjlj, throw_exception_cxx): Update.
7040         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7041         (all_cleanups, do_cleanups, discard_cleanups)
7042         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7043         (restore_cleanups, restore_final_cleanups): Don't declare.
7044         (do_final_cleanups): Remove parameter.
7045         * common/cleanups.c (cleanup_chain, make_cleanup)
7046         (make_cleanup_dtor, all_cleanups, do_cleanups)
7047         (discard_my_cleanups, discard_cleanups)
7048         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7049         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7050         (null_cleanup): Remove.
7051         (do_final_cleanups): Remove parameter.
7052
7053 2019-03-06  Tom Tromey  <tom@tromey.com>
7054
7055         * remote.c (remote_target::remote_parse_stop_reply): Use
7056         unique_xmalloc_ptr.
7057
7058 2019-03-06  Tom Tromey  <tom@tromey.com>
7059
7060         * stabsread.c (struct stabs_field_info): Rename from field_info.
7061         <list, fnlist>: Add initializers.
7062         <obstack>: New member.
7063         (read_member_functions, read_struct_fields, read_baseclasses):
7064         Allocate on obstack.  Don't use cleanups.
7065         (read_one_struct_field, read_member_functions, read_struct_fields)
7066         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7067         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7068         (read_struct_type): Update.
7069
7070 2019-03-06  Tom Tromey  <tom@tromey.com>
7071
7072         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7073         * common/filestuff.h (make_cleanup_close): Don't declare.
7074         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7075         Remove.
7076
7077 2019-03-06  Tom Tromey  <tom@tromey.com>
7078
7079         * solib-aix.c: Use make_scope_exit.
7080
7081 2019-03-06  Tom Tromey  <tom@tromey.com>
7082
7083         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7084         Use make_scope_exit.
7085
7086 2019-03-06  Tom Tromey  <tom@tromey.com>
7087
7088         * solib-svr4.c (disable_probes_interface): Remove parameter.
7089         (svr4_handle_solib_event): Use make_scope_exit.
7090
7091 2019-03-06  Tom Tromey  <tom@tromey.com>
7092
7093         * remote.c (struct stop_reply_deleter): Remove.
7094         (stop_reply_up): Update.
7095         (struct stop_reply): Derive from notif_event.  Don't typedef.
7096         <regcache>: Now a std::vector.
7097         (stop_reply_xfree): Remove.
7098         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7099         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7100         (remote_target::discard_pending_stop_replies): Use delete.
7101         (remote_target::remote_parse_stop_reply): Update.
7102         (remote_target::process_stop_reply): Update.
7103         * remote-notif.h (struct notif_event): Add virtual destructor.
7104         Remove "dtr" member.
7105         (struct notif_client) <alloc_event>: Return a unique_ptr.
7106         (notif_event_xfree): Don't declare.
7107         (notif_event_up): New typedef.
7108         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7109         (notif_event_xfree, do_notif_event_xfree): Remove.
7110         (remote_notif_state_xfree): Update.
7111
7112 2019-03-06  Tom Tromey  <tom@tromey.com>
7113
7114         * infrun.c (displaced_step_clear_cleanup): Now a
7115         forward_scope_exit type.
7116         (displaced_step_prepare_throw): Update.
7117         (displaced_step_fixup): Update.
7118
7119 2019-03-06  Tom Tromey  <tom@tromey.com>
7120
7121         * inferior.h (class inferior): Update comment.
7122         * gdbthread.h (class thread_info): Update comment.
7123
7124 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7125             Tom Tromey  <tom@tromey.com>
7126
7127         * stabsread.h (struct stab_section_list): Remove.
7128         (coffstab_build_psymtabs): Update.
7129         * dbxread.c (symbuf_sections): Now a std::vector.
7130         (sect_idx): New global.
7131         (fill_symbuf): Update.
7132         (coffstab_build_psymtabs): Change type of stabsects parameter.
7133         Update.
7134         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7135         std::vector.
7136         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7137         (coff_locate_sections): Update.
7138         (coff_symfile_read): Remove cleanups.  Update.
7139         (init_stringtab): Add storage parameter.
7140         (free_stringtab, free_stringtab_cleanup): Remove.
7141         (init_lineno): Add storage parameter.
7142         (free_linetab, free_linetab_cleanup): Remove.
7143
7144 2019-03-06  Pedro Alves  <palves@redhat.com>
7145
7146         * linux-fork.c (fork_info::clobber_regs): Delete.
7147         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7148         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7149         comment.  Adjust.
7150         (scoped_switch_fork_info::scoped_switch_fork_info)
7151         (checkpoint_command, linux_fork_context): Adjust
7152         fork_save_infrun_state calls.
7153
7154 2019-03-06  Pedro Alves  <palves@redhat.com>
7155
7156         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7157         (inf_has_multiple_threads): Return 'bool' and rewrite using
7158         inferior_info::threads().
7159
7160 2019-03-06  Pedro Alves  <palves@redhat.com>
7161
7162         * linux-fork.c: Include <list>.
7163         (fork_list): Now a std::list instance.
7164         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7165         (forks_exist_p, find_last_fork): Adjust.
7166         (new_fork): Delete.
7167         (one_fork_p): New.
7168         (add_fork): Adjust.
7169         (free_fork): Delete, folded into fork_info::~fork_info().
7170         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7171         Adjust.
7172         (init_fork_list): Delete.
7173         (linux_fork_killall, linux_fork_mourn_inferior)
7174         (linux_fork_detach, info_checkpoints_command): Adjust.
7175         (_initialize_linux_fork): No longer call init_fork_list.
7176
7177 2019-03-06  Pedro Alves  <palves@redhat.com>
7178
7179         * linux-fork.c (new_fork): New, split out of ...
7180         (add_fork): ... this.  Return void.  Move "first fork" special
7181         case from here, to ...
7182         (checkpoint_command): ... here.
7183         * linux-linux.h (add_fork): Return void.
7184
7185 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7186
7187         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7188
7189 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7190             Chris January  <chris.january@arm.com>
7191             David Lecomber  <david.lecomber@arm.com>
7192
7193         * f-exp.y: New token, UNOP_INTRINSIC.
7194         (exp): New pattern using UNOP_INTRINSIC token.
7195         (f77_keywords): Add 'abs' keyword.
7196         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7197         (value_from_host_double): New function.
7198         (evaluate_subexp_f): Support UNOP_ABS.
7199
7200 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7201
7202         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7203         types.
7204
7205 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7206
7207         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7208         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7209         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7210
7211 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7212
7213         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7214
7215 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7216             Chris January  <chris.january@arm.com>
7217
7218         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7219         * f-exp.y: Define 'KIND' token.
7220         (exp): New pattern for KIND expressions.
7221         (ptype): Handle types with a kind extension.
7222         (direct_abs_decl): Extend to spot kind extensions.
7223         (f77_keywords): Add 'kind' to the list.
7224         (push_kind_type): New function.
7225         (convert_to_kind_type): New function.
7226         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7227         * parse.c (operator_length_standard): Likewise.
7228         * parser-defs.h (enum type_pieces): Add tp_kind.
7229         * std-operator.def: Add UNOP_KIND.
7230
7231 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7232
7233         * f-exp.y (f_parse): Set yydebug.
7234
7235 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7236
7237         * f-lang.c (evaluate_subexp_f): New function.
7238         (exp_descriptor_f): New global.
7239         (f_language_defn): Use exp_descriptor_f instead of
7240         exp_descriptor_standard.
7241
7242 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7243
7244         * f-exp.y (struct token): Add comments.
7245         (dot_ops): Remove uppercase versions and the end marker.
7246         (f77_keywords): Likewise.
7247         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7248         entries in the dot_ops array are case insensitive, and use
7249         strncasecmp to compare strings.  Also some whitespace cleanup in
7250         this area.  Similar for the f77_keywords array, except entries in
7251         this list might be case sensitive.
7252
7253 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7254
7255         * f-exp.y (struct f77_boolean_val): Add comments.
7256         (boolean_values): Remove uppercase versions, and end marker.
7257         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7258         and use strncasecmp to achieve case insensitivity.  Additionally,
7259         perform whitespace cleanup around this code.
7260
7261 2019-03-06  Tom Tromey  <tromey@adacore.com>
7262
7263         * remote-sim.c (gdbsim_target_open): Use result of
7264         gdb_argv::release.
7265
7266 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7267         Dirk Schubert  <dirk.schubert@arm.com>
7268         Chris January  <chris.january@arm.com>
7269
7270         * eval.c (evaluate_subexp_standard): Call Fortran argument
7271         wrapping logic.
7272         * f-lang.c (struct value): A value which can be passed into a
7273         Fortran function call.
7274         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7275         where appropriate.
7276         (struct type): Value ready for a Fortran function call.
7277         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7278         is needed.
7279         * f-lang.h (fortran_argument_convert): Declaration.
7280         (fortran_preserve_arg_pointer): Declaration.
7281         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7282
7283 2019-03-05  Tom Tromey  <tromey@adacore.com>
7284
7285         * python/py-prettyprint.c (print_string_repr): Remove #if.
7286         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7287
7288 2019-03-05  Tom Tromey  <tromey@adacore.com>
7289
7290         * target.c (the_dummy_target): Move later.  Change type to
7291         "dummy_target".
7292         (initialize_targets): Don't initialize the_dummy_target.
7293
7294 2019-03-05  Tom Tromey  <tromey@adacore.com>
7295
7296         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7297         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7298
7299 2019-03-05  Tom Tromey  <tromey@adacore.com>
7300
7301         * windows-nat.c (windows_nat_target::attach)
7302         (windows_nat_target::detach): Don't call gdb_flush.
7303         * valprint.c (generic_val_print, val_print, val_print_string):
7304         Don't call gdb_flush.
7305         * utils.c (defaulted_query): Don't call gdb_flush.
7306         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7307         * target.c (target_announce_detach): Don't call gdb_flush.
7308         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7309         * remote.c (extended_remote_target::attach): Don't call
7310         gdb_flush.
7311         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7312         * printcmd.c (do_examine): Don't call gdb_flush.
7313         (info_display_command): Don't call gdb_flush.
7314         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7315         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7316         * memattr.c (info_mem_command): Don't call gdb_flush.
7317         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7318         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7319         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7320         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7321         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7322         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7323         (gnu_nat_target::detach): Don't call gdb_flush.
7324         * f-valprint.c (f_val_print): Don't call gdb_flush.
7325         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7326         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7327         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7328         gdb_flush.
7329         * c-valprint.c (c_val_print): Don't call gdb_flush.
7330         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7331
7332 2019-03-05  Tom Tromey  <tromey@adacore.com>
7333
7334         * varobj.c (update_dynamic_varobj_children): Update.
7335         (install_default_visualizer): Use reset, not release.
7336         * value.c (set_internalvar): Update.
7337         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7338         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7339         ATTRIBUTE_UNUSED_RESULT.
7340
7341 2019-03-05  Tom Tromey  <tromey@adacore.com>
7342
7343         * remote.c (class scoped_remote_fd) <release>: Add
7344         ATTRIBUTE_UNUSED_RESULT.
7345
7346 2019-03-05  Tom Tromey  <tromey@adacore.com>
7347
7348         * macroexp.c (struct macro_buffer) <release>: Add
7349         ATTRIBUTE_UNUSED_RESULT.
7350
7351 2019-03-05  Tom Tromey  <tromey@adacore.com>
7352
7353         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7354         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7355         ATTRIBUTE_UNUSED_RESULT.
7356
7357 2019-03-05  Tom Tromey  <tromey@adacore.com>
7358
7359         * common/scoped_fd.h (class scoped_fd) <release>: Add
7360         ATTRIBUTE_UNUSED_RESULT.
7361
7362 2019-03-05  Tom Tromey  <tromey@adacore.com>
7363
7364         * parser-defs.h (struct parser_state) <release>: Add
7365         ATTRIBUTE_UNUSED_RESULT.
7366
7367 2019-03-05  Tom Tromey  <tromey@adacore.com>
7368
7369         * utils.h (class gdb_argv) <release>: Add
7370         ATTRIBUTE_UNUSED_RESULT.
7371         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7372
7373 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7374
7375         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7376         for-loop range, to avoid compiler warnings.
7377
7378         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7379         avoid compiler warnings about unused variables.
7380
7381         * NEWS: Mention end of support for native debugging on MS-Windows
7382         before XP.
7383
7384         PR gdb/24292
7385         * common/netstuff.c:
7386         * gdbserver/gdbreplay.c
7387         * gdbserver/remote-utils.c:
7388         * ser-tcp.c:
7389         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7390         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7391         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7392         'getaddrinfo' and 'freeaddrinfo' were not available before
7393         Windows XP, and mingw.org's MinGW headers by default define
7394         _WIN32_WINNT to 0x500.
7395
7396 2019-03-01  Gary Benson <gbenson@redhat.com>
7397
7398         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7399
7400 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7401             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7402
7403         PR gdb/8527
7404         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7405         set_sigint_trap, clear_sigint_trap.
7406
7407 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7408
7409         * target.c (target_detach): Clear the regcache and the
7410         frame cache.
7411
7412 2019-02-27  Pedro Alves  <palves@redhat.com>
7413
7414         * utils.c (set_screen_size): When we cap the height/width sizes,
7415         tweak the corresponding command variable to show "unlimited":
7416
7417 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7418             Pedro Alves  <palves@redhat.com>
7419
7420         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7421         before calling rl_set_screen_size.
7422
7423 2019-02-27  Tom Tromey  <tromey@adacore.com>
7424
7425         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7426         define.
7427         * python/py-value.c: Remove Python 2.4 workaround.
7428         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7429         workaround.
7430         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7431         Python 2.4 workaround.
7432         * python/python-internal.h: Remove Python 2.4 comment.
7433         (Py_ssize_t): Don't define.
7434         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7435         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7436         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7437         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7438         * python/python.c (do_start_initialization): Remove Python 2.4
7439         workaround.
7440         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7441         (print_children): Remove Python 2.4 workaround.
7442         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7443         workaround.
7444         (CHARBUFFERPROC_NAME): Remove.
7445         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7446         Python 2.4 workaround.
7447
7448 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7449
7450         * NEWS: Note minimum Python version.
7451
7452 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7453
7454         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7455         code from these functions.  Remove corresponding ifdefs.  Use
7456         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7457         Remove gotos and target of gotos.
7458         (infpy_search_memory): Likewise.
7459
7460 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7461
7462         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7463         (hppa_gdbarch_init): Don't register deleted functions with
7464         gdbarch.
7465
7466 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7467
7468         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7469         (h8300_unwind_sp): Delete.
7470         (h8300_dummy_id): Delete.
7471         (h8300_gdbarch_init): Don't register deleted functions with
7472         gdbarch.
7473
7474 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7475
7476         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7477         (ft32_unwind_pc): Delete.
7478         (ft32_unwind_sp): Delete.
7479         (ft32_gdbarch_init): Don't register deleted functions with
7480         gdbarch.
7481
7482 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7483
7484         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7485         (frv_unwind_pc): Delete.
7486         (frv_unwind_sp): Delete.
7487         (frv_gdbarch_init): Don't register deleted functions with
7488         gdbarch.
7489
7490 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7491
7492         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7493         (riscv_unwind_pc): Delete.
7494         (riscv_unwind_sp): Delete.
7495         (riscv_gdbarch_init): Don't register deleted functions with
7496         gdbarch.
7497
7498 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7499
7500         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7501         (csky_unwind_pc): Delete.
7502         (csky_unwind_sp): Delete.
7503         (csky_gdbarch_init): Don't register deleted functions with
7504         gdbarch.
7505
7506 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7507
7508         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7509         (cris_unwind_pc): Delete.
7510         (cris_unwind_sp): Delete.
7511         (cris_gdbarch_init): Don't register deleted functions with
7512         gdbarch.
7513
7514 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7515
7516         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7517         (bfin_unwind_pc): Delete.
7518         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7519
7520 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7521
7522         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7523         (arm_unwind_pc): Delete.
7524         (arm_unwind_sp): Delete.
7525         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7526
7527 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7528
7529         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7530         (arc_unwind_pc): Delete.
7531         (arc_unwind_sp): Delete.
7532         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7533
7534 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7535
7536         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7537         (alpha_unwind_pc): Delete.
7538         (alpha_gdbarch_init): Don't register deleted functions with
7539         gdbarch.
7540
7541 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7542
7543         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7544         (aarch64_unwind_pc): Delete.
7545         (aarch64_unwind_sp): Delete.
7546         (aarch64_gdbarch_init): Don't register deleted functions with
7547         gdbarch.
7548
7549 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7550
7551         * gdbtypes.c (type_align): Don't consider static members when
7552         computing structure alignment.
7553
7554 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7555
7556         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7557         return 0 for other types.
7558         * arch-utils.c (default_type_align): Always return 0.
7559         * gdbarch.h: Regenerate.
7560         * gdbarch.sh (type_align): Extend comment.
7561         * gdbtypes.c (type_align): Add additional comments, always call
7562         gdbarch_type_align before applying the default rules.
7563         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7564         generic code will then apply a suitable default.
7565         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7566         types, return 0 for other types.
7567
7568 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7569
7570         * NEWS: Create a new section for the next release branch.
7571         Rename the section of the current branch, now that it has
7572         been cut.
7573
7574 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7575
7576         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7577         * version.in: Bump version to 8.3.50.DATE-git.
7578
7579 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7580
7581         * aix-thread.c (ptid_cmp): Remove unused variable.
7582         (get_signaled_thread): Likewise.
7583         (store_regs_user_thread): Likewise.
7584         (store_regs_kernel_thread): Likewise.
7585         (fetch_regs_kernel_thread): Remove shadowed variable.
7586
7587 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7588
7589         * features/riscv/32bit-cpu.xml: Add register numbers.
7590         * features/riscv/32bit-fpu.c: Regenerate.
7591         * features/riscv/32bit-fpu.xml: Add register numbers.
7592         * features/riscv/64bit-cpu.xml: Add register numbers.
7593         * features/riscv/64bit-fpu.c: Regenerate.
7594         * features/riscv/64bit-fpu.xml: Add register numbers.
7595
7596 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7597
7598         * NEWS: Mention two argument form of gdb.Value constructor.
7599         * python/py-value.c (convert_buffer_and_type_to_value): New
7600         function.
7601         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7602         Add support for handling an optional second argument.  Call
7603         convert_buffer_and_type_to_value as appropriate.
7604         * python/python-internal.h (Py_buffer_deleter): New struct.
7605         (Py_buffer_up): New typedef.
7606
7607 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7608
7609         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7610         instead of releasing ownership.
7611
7612 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7613
7614         * dwarf2read.c (open_and_init_dwp_file): Call
7615         elf_numsections instead of bfd_count_sections to initialize
7616         dwp_file->num_sections.
7617
7618 2019-02-25  Tom Tromey  <tromey@adacore.com>
7619
7620         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7621
7622 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7623
7624         * gcore.in: Add '--readnever' option when invoking GDB.
7625
7626 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7627
7628         * MAINTAINERS: Update my email address.
7629
7630 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7631
7632         * build-id.c (build_id_to_debug_bfd_1): New function.
7633         (build_id_to_debug_bfd): Look for separate debug file in
7634         sysroot.
7635
7636 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7637
7638         * gdbarch.sh: Update the copyright year range that is placed into
7639         generated files.
7640
7641 2019-02-22  Keith Seitz  <keiths@redhat.com>
7642
7643         PR symtab/23853
7644         * linespec.c (create_sals_line_offset): Search for the default
7645         symtab's filename instead of its fullname.
7646
7647 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7648
7649         * NEWS: Update style defaults.
7650
7651 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7652
7653         * main.c (captured_main_1): Disable styling in batch mode.
7654
7655 2019-02-20  Tom Tromey  <tom@tromey.com>
7656
7657         * symtab.c (symtab_symbol_info): Fix typos.
7658
7659 2019-02-20  Tom Tromey  <tromey@adacore.com>
7660
7661         * findcmd.c (_initialize_mem_search): Use upper case for
7662         metasyntactic variables.
7663
7664 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7665
7666         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7667         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7668
7669 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7670
7671         * top.h (source_file_name): Change to std::string.
7672         * top.c (source_file_name): Likewise.
7673         (command_line_input): Adjust.
7674         * cli/cli-script.c (script_from_file): Adjust.
7675
7676 2019-02-19  Tom Tromey  <tromey@adacore.com>
7677
7678         * ravenscar-thread.c
7679         (ravenscar_thread_target::update_thread_list): Don't call
7680         ada_build_task_list.
7681         * ada-lang.h (ada_build_task_list): Don't declare.
7682         * ada-tasks.c (struct ada_tasks_inferior_data)
7683         <task_list_valid_p>: Now bool.
7684         (read_known_tasks, ada_task_list_changed)
7685         (ada_tasks_invalidate_inferior_data): Update.
7686         (read_known_tasks_array): Return bool.
7687         (read_known_tasks_list): Likewise.
7688         (read_known_tasks): Return void.
7689         (ada_build_task_list): Now static.
7690
7691 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7692
7693         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7694         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7695
7696 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7697
7698         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7699         variant for ada_tasks_pspace_data_handle and
7700         ada_tasks_inferior_data_handle.
7701         (ada_tasks_pspace_data_cleanup): New function.
7702         (ada_tasks_inferior_data_cleanup): New function.
7703
7704 2019-02-17  Tom Tromey  <tom@tromey.com>
7705
7706         * macrotab.h (macro_source_fullname): Return a std::string.
7707         * macrotab.c (macro_include, check_for_redefinition)
7708         (macro_undef, macro_lookup_definition, foreach_macro)
7709         (foreach_macro_in_scope): Update.
7710         (macro_source_fullname): Return a std::string.
7711         * macrocmd.c (show_pp_source_pos): Update.
7712
7713 2019-02-17  Tom Tromey  <tom@tromey.com>
7714
7715         * macrocmd.c (show_pp_source_pos): Style the file names.
7716
7717 2019-02-17  Tom Tromey  <tom@tromey.com>
7718
7719         PR tui/24197:
7720         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7721
7722 2019-02-17  Tom Tromey  <tom@tromey.com>
7723
7724         * ada-lang.c (user_select_syms): Use filtered printing.
7725         * utils.c (wrap_style): New global.
7726         (desired_style): Remove.
7727         (emit_style_escape): Add stream parameter.
7728         (set_output_style, reset_terminal_style, prompt_for_continue):
7729         Update.
7730         (flush_wrap_buffer): Only flush gdb_stdout.
7731         (wrap_here): Set wrap_style.
7732         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7733         treat escape sequences as a character.  Change when wrap buffer is
7734         flushed.
7735         (fputs_styled): Do not set the output style when the default is
7736         requested.
7737         * ui-style.h (struct ui_file_style) <is_default>: New method.
7738         * source.c (print_source_lines_base): Emit escape sequences in one
7739         piece.
7740
7741 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7742
7743         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7744         integers and enumeration types.
7745
7746 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7747
7748         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7749         instead of lookup_symbol_in_language
7750         (do_exact_match): New function.
7751         (ada_get_symbol_name_matcher): Return do_exact_match when
7752         doing a verbatim match.
7753
7754 2019-02-15  Tom Tromey  <tromey@adacore.com>
7755
7756         * ravenscar-thread.c (ravenscar_thread_target::resume)
7757         (ravenscar_thread_target::wait): Special case wildcard requests.
7758
7759 2019-02-15  Tom Tromey  <tromey@adacore.com>
7760
7761         * ravenscar-thread.c (base_ptid): Remove.
7762         (struct ravenscar_thread_target) <close>: New method.
7763         <m_base_ptid>: New member.
7764         <update_inferior_ptid, active_task, task_is_currently_active,
7765         runtime_initialized>: Declare methods.
7766         <ravenscar_thread_target>: Add constructor.
7767         (ravenscar_thread_target::task_is_currently_active)
7768         (ravenscar_thread_target::update_inferior_ptid)
7769         (ravenscar_runtime_initialized): Rename.  Now methods.
7770         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7771         (ravenscar_thread_target::update_thread_list): Update.
7772         (ravenscar_thread_target::active_task): Now method.
7773         (ravenscar_thread_target::store_registers)
7774         (ravenscar_thread_target::prepare_to_store)
7775         (ravenscar_thread_target::prepare_to_store)
7776         (ravenscar_thread_target::mourn_inferior): Update.
7777         (ravenscar_inferior_created): Use "new" to create target.
7778         (ravenscar_thread_target::get_ada_task_ptid): Update.
7779         (_initialize_ravenscar): Don't initialize base_ptid.
7780         (ravenscar_ops): Remove global.
7781
7782 2019-02-15  Tom Tromey  <tromey@adacore.com>
7783
7784         * target.h (push_target): Declare new overload.
7785         * target.c (push_target): New overload, taking an rvalue reference.
7786         * remote.c (remote_target::open_1): Use push_target overload.
7787         * corelow.c (core_target_open): Use push_target overload.
7788
7789 2019-02-15  Tom Tromey  <tromey@adacore.com>
7790
7791         * ravenscar-thread.c (is_ravenscar_task)
7792         (ravenscar_task_is_currently_active): Return bool.
7793         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7794         (_initialize_ravenscar): Remove "(void)".
7795         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7796         Return bool.
7797
7798 2019-02-15  Tom Tromey  <tromey@adacore.com>
7799
7800         * ravenscar-thread.c (ravenscar_runtime_initializer)
7801         (has_ravenscar_runtime, get_running_thread_id)
7802         (ravenscar_thread_target::resume): Fix indentation.
7803
7804 2019-02-15  Tom Tromey  <tromey@adacore.com>
7805
7806         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7807         from ravenscar_arch_ops.
7808         (sparc_ravenscar_ops::fetch_registers)
7809         (sparc_ravenscar_ops::store_registers): Now methods.
7810         (sparc_ravenscar_prepare_to_store): Remove.
7811         (sparc_ravenscar_ops): Redefine.
7812         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7813         methods and destructor.  Remove members.
7814         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7815         (ravenscar_thread_target::store_registers)
7816         (ravenscar_thread_target::prepare_to_store): Update.
7817         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7818         Remove.
7819         (struct ppc_ravenscar_powerpc_ops): Derive from
7820         ravenscar_arch_ops.
7821         (ppc_ravenscar_powerpc_ops::fetch_registers)
7822         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7823         (ppc_ravenscar_powerpc_ops): Redefine.
7824         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7825         (ppc_ravenscar_e500_ops::fetch_registers)
7826         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7827         (ppc_ravenscar_e500_ops): Redefine.
7828         * aarch64-ravenscar-thread.c
7829         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7830         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7831         (aarch64_ravenscar_fetch_registers)
7832         (aarch64_ravenscar_store_registers): Now methods.
7833         (aarch64_ravenscar_ops): Redefine.
7834
7835 2019-02-15  Tom Tromey  <tromey@adacore.com>
7836
7837         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7838         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7839         (ravenscar_thread_target::stopped_by_watchpoint)
7840         (ravenscar_thread_target::stopped_data_address)
7841         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7842
7843 2019-02-15  Tom Tromey  <tromey@adacore.com>
7844
7845         * ravenscar-thread.c: Fix some typos.
7846
7847 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7848             Tom Tromey  <tromey@adacore.com>
7849
7850         * ada-lang.c (ada_exception_sal): Change addr_string to a
7851         std::string.
7852         (create_ada_exception_catchpoint): Update.
7853
7854 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7855             Tom Tromey  <tromey@adacore.com>
7856
7857         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7858         (bp_location_ops): Remove.
7859         (base_breakpoint_allocate_location): Update.
7860         (free_bp_location): Update.
7861         * ada-lang.c (class ada_catchpoint_location)
7862         <ada_catchpoint_location>: Remove ops parameter.
7863         (ada_catchpoint_location_dtor): Remove.
7864         (ada_catchpoint_location_ops): Remove.
7865         (allocate_location_exception): Update.
7866         * breakpoint.h (struct bp_location_ops): Remove.
7867         (class bp_location) <bp_location>: Remove bp_location_ops
7868         parameter.
7869         <~bp_location>: Add destructor.
7870         <ops>: Remove.
7871
7872 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7873             Pedro Alves  <palves@redhat.com>
7874
7875         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7876         'PATH_MAX'.
7877
7878 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7879             Samuel Thibault  <samuel.thibault@gnu.org>
7880             Thomas Schwinge  <thomas@codesourcery.com>
7881
7882         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7883         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7884
7885 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7886
7887         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7888         (check_empty): Use "const char *".
7889
7890         * gnu-nat.c (gnu_nat_target::detach): Instead of
7891         'detach_inferior (pid)' call
7892         'detach_inferior (find_inferior_pid (pid))'.
7893
7894         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7895         'nat/fork-inferior.o'.
7896         * gnu-nat.c: #include "nat/fork-inferior.h".
7897
7898         * gnu-nat.c (gnu_nat_target::detach): Instead of
7899         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7900         * gnu-nat.h: #include "inf-child.h".
7901         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7902         'i386_gnu_nat_target::fetch_registers'.
7903         (gnu_store_registers): Rename/move to
7904         'i386_gnu_nat_target::store_registers'.
7905
7906         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7907         * gnu-nat.h (mach_thread_info): New function.
7908         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7909
7910         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7911
7912 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7913
7914         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7915
7916 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7917
7918         * windows-nat.c (windows_add_thread): Add new parameter
7919         "main_thread_p" with default value set to false.  Update
7920         function documentation as well as all callers.
7921         (windows_delete_thread): Likewise.
7922         (fake_create_process): Update call to windows_add_thread.
7923         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7924         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7925         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7926         call to windows_delete_thread.
7927
7928 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7929
7930         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7931
7932 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7933
7934         * symfile.c (find_separate_debug_file): Use canonical path of
7935         sysroot with child_path instead of gdb_sysroot if it is valid.
7936
7937 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7938
7939         * symfile.c (find_separate_debug_file): Use child_path to
7940         determine if an object file is under a sysroot.
7941
7942 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7943
7944         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7945         unittests/child-path-selftests.c.
7946         * common/pathstuff.c (child_path): New function.
7947         * common/pathstuff.h (child_path): New prototype.
7948         * unittests/child-path-selftests.c: New file.
7949
7950 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7951
7952         * symfile.c (find_separate_debug_file): Look for separate debug
7953         files in debug directories under the sysroot.
7954
7955 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7956
7957         * symtab.h (struct minimal_symbol data_p): New const method.
7958         (struct minimal_symbol text_p): Likewise.
7959         * symtab.c (output_source_filename): Use file name style
7960         to print file name.
7961         (print_symbol_info): Likewise.
7962         (print_msymbol_info): Use address style to print addresses.
7963         Use function name style to print executable text symbols.
7964         (expand_symtab_containing_pc): Use data_p.
7965         (find_pc_sect_compunit_symtab): Likewise.
7966
7967 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7968
7969         * breakpoint.c (describe_other_breakpoints): Use address style
7970         to print addresses.
7971         (say_where): Likewise.
7972
7973 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7974
7975         * ada-typeprint.c (print_func_type): Print function name
7976         style to print function name.
7977         * c-typeprint.c (c_print_type_1): Likewise.
7978
7979 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7980
7981         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7982         for execve.
7983
7984 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7985
7986         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7987         type_stack.
7988
7989 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7990
7991         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7992         TYPE_CODE_REF types.
7993
7994 2019-02-08  Jim Wilson  <jimw@sifive.com>
7995
7996         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7997         (riscv_linux_fregset): New.
7998         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7999
8000 2019-02-07  Tom Tromey  <tom@tromey.com>
8001
8002         * thread.c (thread_cancel_execution_command): Update.
8003         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8004         methods.
8005         (struct thread_fsm_ops): Remove.
8006         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8007         (thread_fsm_should_stop, thread_fsm_return_value)
8008         (thread_fsm_set_finished, thread_fsm_finished_p)
8009         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8010         Don't declare.
8011         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8012         * infrun.c (clear_proceed_status_thread)
8013         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8014         (print_stop_event): Update.
8015         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8016         Add constructor.
8017         (step_command_fsm_ops): Remove.
8018         (new_step_command_fsm): Remove.
8019         (step_1): Update.
8020         (step_command_fsm::should_stop): Rename from
8021         step_command_fsm_should_stop.
8022         (step_command_fsm::clean_up): Rename from
8023         step_command_fsm_clean_up.
8024         (step_command_fsm::do_async_reply_reason): Rename from
8025         step_command_fsm_async_reply_reason.
8026         (struct until_next_fsm): Inherit from thread_fsm.  Add
8027         constructor.
8028         (until_next_fsm_ops): Remove.
8029         (new_until_next_fsm): Remove.
8030         (until_next_fsm::should_stop): Rename from
8031         until_next_fsm_should_stop.
8032         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8033         (until_next_fsm::do_async_reply_reason): Rename from
8034         until_next_fsm_async_reply_reason.
8035         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8036         constructor.  Change type of breakpoint.
8037         (finish_command_fsm_ops): Remove.
8038         (new_finish_command_fsm): Remove.
8039         (finish_command_fsm::should_stop): Rename from
8040         finish_command_fsm_should_stop.
8041         (finish_command_fsm::clean_up): Rename from
8042         finish_command_fsm_clean_up.
8043         (finish_command_fsm::return_value): Rename from
8044         finish_command_fsm_return_value.
8045         (finish_command_fsm::do_async_reply_reason): Rename from
8046         finish_command_fsm_async_reply_reason.
8047         (finish_command): Update.
8048         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8049         Add constructor.
8050         (call_thread_fsm_ops): Remove.
8051         (call_thread_fsm::call_thread_fsm): Rename from
8052         new_call_thread_fsm.
8053         (call_thread_fsm::should_stop): Rename from
8054         call_thread_fsm_should_stop.
8055         (call_thread_fsm::should_notify_stop): Rename from
8056         call_thread_fsm_should_notify_stop.
8057         (run_inferior_call, call_function_by_hand_dummy): Update.
8058         * cli/cli-interp.c (should_print_stop_to_console): Update.
8059         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8060         Add constructor.  Change type of location_breakpoint,
8061         caller_breakpoint.
8062         (until_break_fsm_ops): Remove.
8063         (new_until_break_fsm): Remove.
8064         (until_break_fsm::should_stop): Rename from
8065         until_break_fsm_should_stop.
8066         (until_break_fsm::clean_up): Rename from
8067         until_break_fsm_clean_up.
8068         (until_break_fsm::do_async_reply_reason): Rename from
8069         until_break_fsm_async_reply_reason.
8070         (until_break_command): Update.
8071         * thread-fsm.c: Remove.
8072         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8073
8074 2019-02-07  Tom Tromey  <tom@tromey.com>
8075
8076         * yy-remap.h: Add include guard.
8077         * xtensa-tdep.h: Add include guard.
8078         * xcoffread.h: Rename include guard.
8079         * varobj-iter.h: Add include guard.
8080         * tui/tui.h: Rename include guard.
8081         * tui/tui-winsource.h: Rename include guard.
8082         * tui/tui-wingeneral.h: Rename include guard.
8083         * tui/tui-windata.h: Rename include guard.
8084         * tui/tui-win.h: Rename include guard.
8085         * tui/tui-stack.h: Rename include guard.
8086         * tui/tui-source.h: Rename include guard.
8087         * tui/tui-regs.h: Rename include guard.
8088         * tui/tui-out.h: Rename include guard.
8089         * tui/tui-layout.h: Rename include guard.
8090         * tui/tui-io.h: Rename include guard.
8091         * tui/tui-hooks.h: Rename include guard.
8092         * tui/tui-file.h: Rename include guard.
8093         * tui/tui-disasm.h: Rename include guard.
8094         * tui/tui-data.h: Rename include guard.
8095         * tui/tui-command.h: Rename include guard.
8096         * tic6x-tdep.h: Add include guard.
8097         * target/waitstatus.h: Rename include guard.
8098         * target/wait.h: Rename include guard.
8099         * target/target.h: Rename include guard.
8100         * target/resume.h: Rename include guard.
8101         * target-float.h: Rename include guard.
8102         * stabsread.h: Add include guard.
8103         * rs6000-tdep.h: Add include guard.
8104         * riscv-fbsd-tdep.h: Add include guard.
8105         * regformats/regdef.h: Rename include guard.
8106         * record.h: Rename include guard.
8107         * python/python.h: Rename include guard.
8108         * python/python-internal.h: Rename include guard.
8109         * python/py-stopevent.h: Rename include guard.
8110         * python/py-ref.h: Rename include guard.
8111         * python/py-record.h: Rename include guard.
8112         * python/py-record-full.h: Rename include guard.
8113         * python/py-record-btrace.h: Rename include guard.
8114         * python/py-instruction.h: Rename include guard.
8115         * python/py-events.h: Rename include guard.
8116         * python/py-event.h: Rename include guard.
8117         * procfs.h: Add include guard.
8118         * proc-utils.h: Add include guard.
8119         * p-lang.h: Add include guard.
8120         * or1k-tdep.h: Rename include guard.
8121         * observable.h: Rename include guard.
8122         * nto-tdep.h: Rename include guard.
8123         * nat/x86-linux.h: Rename include guard.
8124         * nat/x86-linux-dregs.h: Rename include guard.
8125         * nat/x86-gcc-cpuid.h: Add include guard.
8126         * nat/x86-dregs.h: Rename include guard.
8127         * nat/x86-cpuid.h: Rename include guard.
8128         * nat/ppc-linux.h: Rename include guard.
8129         * nat/mips-linux-watch.h: Rename include guard.
8130         * nat/linux-waitpid.h: Rename include guard.
8131         * nat/linux-ptrace.h: Rename include guard.
8132         * nat/linux-procfs.h: Rename include guard.
8133         * nat/linux-osdata.h: Rename include guard.
8134         * nat/linux-nat.h: Rename include guard.
8135         * nat/linux-namespaces.h: Rename include guard.
8136         * nat/linux-btrace.h: Rename include guard.
8137         * nat/glibc_thread_db.h: Rename include guard.
8138         * nat/gdb_thread_db.h: Rename include guard.
8139         * nat/gdb_ptrace.h: Rename include guard.
8140         * nat/fork-inferior.h: Rename include guard.
8141         * nat/amd64-linux-siginfo.h: Rename include guard.
8142         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8143         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8144         * nat/aarch64-linux.h: Rename include guard.
8145         * nat/aarch64-linux-hw-point.h: Rename include guard.
8146         * mn10300-tdep.h: Add include guard.
8147         * mips-linux-tdep.h: Add include guard.
8148         * mi/mi-parse.h: Rename include guard.
8149         * mi/mi-out.h: Rename include guard.
8150         * mi/mi-main.h: Rename include guard.
8151         * mi/mi-interp.h: Rename include guard.
8152         * mi/mi-getopt.h: Rename include guard.
8153         * mi/mi-console.h: Rename include guard.
8154         * mi/mi-common.h: Rename include guard.
8155         * mi/mi-cmds.h: Rename include guard.
8156         * mi/mi-cmd-break.h: Rename include guard.
8157         * m2-lang.h: Add include guard.
8158         * location.h: Rename include guard.
8159         * linux-record.h: Rename include guard.
8160         * linux-nat.h: Add include guard.
8161         * linux-fork.h: Add include guard.
8162         * i386-darwin-tdep.h: Rename include guard.
8163         * hppa-linux-offsets.h: Add include guard.
8164         * guile/guile.h: Rename include guard.
8165         * guile/guile-internal.h: Rename include guard.
8166         * gnu-nat.h: Rename include guard.
8167         * gdb-stabs.h: Rename include guard.
8168         * frv-tdep.h: Add include guard.
8169         * f-lang.h: Add include guard.
8170         * event-loop.h: Add include guard.
8171         * darwin-nat.h: Rename include guard.
8172         * cp-abi.h: Rename include guard.
8173         * config/sparc/nm-sol2.h: Rename include guard.
8174         * config/nm-nto.h: Rename include guard.
8175         * config/nm-linux.h: Add include guard.
8176         * config/i386/nm-i386gnu.h: Rename include guard.
8177         * config/djgpp/nl_types.h: Rename include guard.
8178         * config/djgpp/langinfo.h: Rename include guard.
8179         * compile/gcc-cp-plugin.h: Add include guard.
8180         * compile/gcc-c-plugin.h: Add include guard.
8181         * compile/compile.h: Rename include guard.
8182         * compile/compile-object-run.h: Rename include guard.
8183         * compile/compile-object-load.h: Rename include guard.
8184         * compile/compile-internal.h: Rename include guard.
8185         * compile/compile-cplus.h: Rename include guard.
8186         * compile/compile-c.h: Rename include guard.
8187         * common/xml-utils.h: Rename include guard.
8188         * common/x86-xstate.h: Rename include guard.
8189         * common/version.h: Rename include guard.
8190         * common/vec.h: Rename include guard.
8191         * common/tdesc.h: Rename include guard.
8192         * common/selftest.h: Rename include guard.
8193         * common/scoped_restore.h: Rename include guard.
8194         * common/scoped_mmap.h: Rename include guard.
8195         * common/scoped_fd.h: Rename include guard.
8196         * common/safe-iterator.h: Rename include guard.
8197         * common/run-time-clock.h: Rename include guard.
8198         * common/refcounted-object.h: Rename include guard.
8199         * common/queue.h: Rename include guard.
8200         * common/ptid.h: Rename include guard.
8201         * common/print-utils.h: Rename include guard.
8202         * common/preprocessor.h: Rename include guard.
8203         * common/pathstuff.h: Rename include guard.
8204         * common/observable.h: Rename include guard.
8205         * common/netstuff.h: Rename include guard.
8206         * common/job-control.h: Rename include guard.
8207         * common/host-defs.h: Rename include guard.
8208         * common/gdb_wait.h: Rename include guard.
8209         * common/gdb_vecs.h: Rename include guard.
8210         * common/gdb_unlinker.h: Rename include guard.
8211         * common/gdb_unique_ptr.h: Rename include guard.
8212         * common/gdb_tilde_expand.h: Rename include guard.
8213         * common/gdb_sys_time.h: Rename include guard.
8214         * common/gdb_string_view.h: Rename include guard.
8215         * common/gdb_splay_tree.h: Rename include guard.
8216         * common/gdb_setjmp.h: Rename include guard.
8217         * common/gdb_ref_ptr.h: Rename include guard.
8218         * common/gdb_optional.h: Rename include guard.
8219         * common/gdb_locale.h: Rename include guard.
8220         * common/gdb_assert.h: Rename include guard.
8221         * common/filtered-iterator.h: Rename include guard.
8222         * common/filestuff.h: Rename include guard.
8223         * common/fileio.h: Rename include guard.
8224         * common/environ.h: Rename include guard.
8225         * common/common-utils.h: Rename include guard.
8226         * common/common-types.h: Rename include guard.
8227         * common/common-regcache.h: Rename include guard.
8228         * common/common-inferior.h: Rename include guard.
8229         * common/common-gdbthread.h: Rename include guard.
8230         * common/common-exceptions.h: Rename include guard.
8231         * common/common-defs.h: Rename include guard.
8232         * common/common-debug.h: Rename include guard.
8233         * common/cleanups.h: Rename include guard.
8234         * common/buffer.h: Rename include guard.
8235         * common/btrace-common.h: Rename include guard.
8236         * common/break-common.h: Rename include guard.
8237         * cli/cli-utils.h: Rename include guard.
8238         * cli/cli-style.h: Rename include guard.
8239         * cli/cli-setshow.h: Rename include guard.
8240         * cli/cli-script.h: Rename include guard.
8241         * cli/cli-interp.h: Rename include guard.
8242         * cli/cli-decode.h: Rename include guard.
8243         * cli/cli-cmds.h: Rename include guard.
8244         * charset-list.h: Add include guard.
8245         * buildsym-legacy.h: Rename include guard.
8246         * bfin-tdep.h: Add include guard.
8247         * ax.h: Rename include guard.
8248         * arm-linux-tdep.h: Add include guard.
8249         * arm-fbsd-tdep.h: Add include guard.
8250         * arch/xtensa.h: Rename include guard.
8251         * arch/tic6x.h: Add include guard.
8252         * arch/i386.h: Add include guard.
8253         * arch/arm.h: Rename include guard.
8254         * arch/arm-linux.h: Rename include guard.
8255         * arch/arm-get-next-pcs.h: Rename include guard.
8256         * arch/amd64.h: Add include guard.
8257         * arch/aarch64-insn.h: Rename include guard.
8258         * arch-utils.h: Rename include guard.
8259         * annotate.h: Add include guard.
8260         * amd64-darwin-tdep.h: Rename include guard.
8261         * aarch64-linux-tdep.h: Add include guard.
8262         * aarch64-fbsd-tdep.h: Add include guard.
8263         * aarch32-linux-nat.h: Add include guard.
8264
8265 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8266
8267         * macrotab.c (macro_define_internal): New function that
8268         factorizes macro_define_object_internal and macro_define_function
8269         code.
8270         (macro_define_object_internal): Use macro_define_internal.
8271         (macro_define_function): Likewise.
8272
8273 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8274
8275         * macrocmd.c (extract_identifier): Return
8276         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8277         callers.
8278
8279 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8280
8281         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8282
8283 2019-02-05  Tom Tromey  <tom@tromey.com>
8284
8285         * target.c (target_stack::unpush): Move assertion earlier.
8286
8287 2019-01-30  Tom Tromey  <tom@tromey.com>
8288
8289         PR python/23615:
8290         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8291         (gdbpy_parse_and_eval): Likewise.
8292         * python/python-internal.h (gdbpy_allow_threads): New class.
8293
8294 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8295
8296         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8297         (aarch64_fbsd_fpregmap): Move earlier.
8298         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8299         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8300         instead of individual calls to trad_frame_set_reg_addr.
8301         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8302         earlier.
8303         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8304         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8305         instead of individual calls to trad_frame_set_reg_addr.
8306
8307 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8308
8309         * CONTRIBUTE: Replace contribution list with wiki link.
8310
8311 2019-01-25  Tom Tromey  <tom@tromey.com>
8312
8313         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8314
8315 2019-01-25  Tom Tromey  <tom@tromey.com>
8316
8317         * xtensa-linux-nat.c: Fix common/ includes.
8318         * xml-support.h: Fix common/ includes.
8319         * xml-support.c: Fix common/ includes.
8320         * x86-linux-nat.c: Fix common/ includes.
8321         * windows-nat.c: Fix common/ includes.
8322         * varobj.h: Fix common/ includes.
8323         * varobj.c: Fix common/ includes.
8324         * value.c: Fix common/ includes.
8325         * valops.c: Fix common/ includes.
8326         * utils.c: Fix common/ includes.
8327         * unittests/xml-utils-selftests.c: Fix common/ includes.
8328         * unittests/utils-selftests.c: Fix common/ includes.
8329         * unittests/unpack-selftests.c: Fix common/ includes.
8330         * unittests/tracepoint-selftests.c: Fix common/ includes.
8331         * unittests/style-selftests.c: Fix common/ includes.
8332         * unittests/string_view-selftests.c: Fix common/ includes.
8333         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8334         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8335         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8336         * unittests/rsp-low-selftests.c: Fix common/ includes.
8337         * unittests/parse-connection-spec-selftests.c: Fix common/
8338         includes.
8339         * unittests/optional-selftests.c: Fix common/ includes.
8340         * unittests/offset-type-selftests.c: Fix common/ includes.
8341         * unittests/observable-selftests.c: Fix common/ includes.
8342         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8343         * unittests/memrange-selftests.c: Fix common/ includes.
8344         * unittests/memory-map-selftests.c: Fix common/ includes.
8345         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8346         * unittests/function-view-selftests.c: Fix common/ includes.
8347         * unittests/environ-selftests.c: Fix common/ includes.
8348         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8349         * unittests/common-utils-selftests.c: Fix common/ includes.
8350         * unittests/cli-utils-selftests.c: Fix common/ includes.
8351         * unittests/array-view-selftests.c: Fix common/ includes.
8352         * ui-file.c: Fix common/ includes.
8353         * tui/tui-io.c: Fix common/ includes.
8354         * tracepoint.h: Fix common/ includes.
8355         * tracepoint.c: Fix common/ includes.
8356         * tracefile-tfile.c: Fix common/ includes.
8357         * top.h: Fix common/ includes.
8358         * top.c: Fix common/ includes.
8359         * thread.c: Fix common/ includes.
8360         * target/waitstatus.h: Fix common/ includes.
8361         * target/waitstatus.c: Fix common/ includes.
8362         * target.h: Fix common/ includes.
8363         * target.c: Fix common/ includes.
8364         * target-memory.c: Fix common/ includes.
8365         * target-descriptions.c: Fix common/ includes.
8366         * symtab.h: Fix common/ includes.
8367         * symfile.c: Fix common/ includes.
8368         * stap-probe.c: Fix common/ includes.
8369         * spu-linux-nat.c: Fix common/ includes.
8370         * sparc-nat.c: Fix common/ includes.
8371         * source.c: Fix common/ includes.
8372         * solib.c: Fix common/ includes.
8373         * solib-target.c: Fix common/ includes.
8374         * ser-unix.c: Fix common/ includes.
8375         * ser-tcp.c: Fix common/ includes.
8376         * ser-pipe.c: Fix common/ includes.
8377         * ser-base.c: Fix common/ includes.
8378         * selftest-arch.c: Fix common/ includes.
8379         * s12z-tdep.c: Fix common/ includes.
8380         * rust-exp.y: Fix common/ includes.
8381         * rs6000-aix-tdep.c: Fix common/ includes.
8382         * riscv-tdep.c: Fix common/ includes.
8383         * remote.c: Fix common/ includes.
8384         * remote-notif.h: Fix common/ includes.
8385         * remote-fileio.h: Fix common/ includes.
8386         * remote-fileio.c: Fix common/ includes.
8387         * regcache.h: Fix common/ includes.
8388         * regcache.c: Fix common/ includes.
8389         * record-btrace.c: Fix common/ includes.
8390         * python/python.c: Fix common/ includes.
8391         * python/py-type.c: Fix common/ includes.
8392         * python/py-inferior.c: Fix common/ includes.
8393         * progspace.h: Fix common/ includes.
8394         * producer.c: Fix common/ includes.
8395         * procfs.c: Fix common/ includes.
8396         * proc-api.c: Fix common/ includes.
8397         * printcmd.c: Fix common/ includes.
8398         * ppc-linux-nat.c: Fix common/ includes.
8399         * parser-defs.h: Fix common/ includes.
8400         * osdata.c: Fix common/ includes.
8401         * obsd-nat.c: Fix common/ includes.
8402         * nat/x86-linux.c: Fix common/ includes.
8403         * nat/x86-linux-dregs.c: Fix common/ includes.
8404         * nat/x86-dregs.h: Fix common/ includes.
8405         * nat/x86-dregs.c: Fix common/ includes.
8406         * nat/ppc-linux.c: Fix common/ includes.
8407         * nat/mips-linux-watch.h: Fix common/ includes.
8408         * nat/mips-linux-watch.c: Fix common/ includes.
8409         * nat/linux-waitpid.c: Fix common/ includes.
8410         * nat/linux-ptrace.h: Fix common/ includes.
8411         * nat/linux-ptrace.c: Fix common/ includes.
8412         * nat/linux-procfs.c: Fix common/ includes.
8413         * nat/linux-personality.c: Fix common/ includes.
8414         * nat/linux-osdata.c: Fix common/ includes.
8415         * nat/linux-namespaces.c: Fix common/ includes.
8416         * nat/linux-btrace.h: Fix common/ includes.
8417         * nat/linux-btrace.c: Fix common/ includes.
8418         * nat/fork-inferior.c: Fix common/ includes.
8419         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8420         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8421         * nat/aarch64-linux.c: Fix common/ includes.
8422         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8423         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8424         * namespace.h: Fix common/ includes.
8425         * mips-linux-tdep.c: Fix common/ includes.
8426         * minsyms.c: Fix common/ includes.
8427         * mi/mi-parse.h: Fix common/ includes.
8428         * mi/mi-main.c: Fix common/ includes.
8429         * mi/mi-cmd-env.c: Fix common/ includes.
8430         * memrange.h: Fix common/ includes.
8431         * memattr.c: Fix common/ includes.
8432         * maint.h: Fix common/ includes.
8433         * maint.c: Fix common/ includes.
8434         * main.c: Fix common/ includes.
8435         * machoread.c: Fix common/ includes.
8436         * location.c: Fix common/ includes.
8437         * linux-thread-db.c: Fix common/ includes.
8438         * linux-nat.c: Fix common/ includes.
8439         * linux-fork.c: Fix common/ includes.
8440         * inline-frame.c: Fix common/ includes.
8441         * infrun.c: Fix common/ includes.
8442         * inflow.c: Fix common/ includes.
8443         * inferior.h: Fix common/ includes.
8444         * inferior.c: Fix common/ includes.
8445         * infcmd.c: Fix common/ includes.
8446         * inf-ptrace.c: Fix common/ includes.
8447         * inf-child.c: Fix common/ includes.
8448         * ia64-linux-nat.c: Fix common/ includes.
8449         * i387-tdep.c: Fix common/ includes.
8450         * i386-tdep.c: Fix common/ includes.
8451         * i386-linux-tdep.c: Fix common/ includes.
8452         * i386-linux-nat.c: Fix common/ includes.
8453         * i386-go32-tdep.c: Fix common/ includes.
8454         * i386-fbsd-tdep.c: Fix common/ includes.
8455         * i386-fbsd-nat.c: Fix common/ includes.
8456         * guile/scm-type.c: Fix common/ includes.
8457         * guile/guile.c: Fix common/ includes.
8458         * go32-nat.c: Fix common/ includes.
8459         * gnu-nat.c: Fix common/ includes.
8460         * gdbthread.h: Fix common/ includes.
8461         * gdbarch-selftests.c: Fix common/ includes.
8462         * gdb_usleep.c: Fix common/ includes.
8463         * gdb_select.h: Fix common/ includes.
8464         * gdb_bfd.c: Fix common/ includes.
8465         * gcore.c: Fix common/ includes.
8466         * fork-child.c: Fix common/ includes.
8467         * findvar.c: Fix common/ includes.
8468         * fbsd-nat.c: Fix common/ includes.
8469         * event-top.c: Fix common/ includes.
8470         * event-loop.c: Fix common/ includes.
8471         * dwarf2read.c: Fix common/ includes.
8472         * dwarf2loc.c: Fix common/ includes.
8473         * dwarf2-frame.c: Fix common/ includes.
8474         * dwarf-index-cache.c: Fix common/ includes.
8475         * dtrace-probe.c: Fix common/ includes.
8476         * disasm-selftests.c: Fix common/ includes.
8477         * defs.h: Fix common/ includes.
8478         * csky-tdep.c: Fix common/ includes.
8479         * cp-valprint.c: Fix common/ includes.
8480         * cp-support.h: Fix common/ includes.
8481         * cp-support.c: Fix common/ includes.
8482         * corelow.c: Fix common/ includes.
8483         * completer.h: Fix common/ includes.
8484         * completer.c: Fix common/ includes.
8485         * compile/compile.c: Fix common/ includes.
8486         * compile/compile-loc2c.c: Fix common/ includes.
8487         * compile/compile-cplus-types.c: Fix common/ includes.
8488         * compile/compile-cplus-symbols.c: Fix common/ includes.
8489         * command.h: Fix common/ includes.
8490         * cli/cli-dump.c: Fix common/ includes.
8491         * cli/cli-cmds.c: Fix common/ includes.
8492         * charset.c: Fix common/ includes.
8493         * build-id.c: Fix common/ includes.
8494         * btrace.h: Fix common/ includes.
8495         * btrace.c: Fix common/ includes.
8496         * breakpoint.h: Fix common/ includes.
8497         * breakpoint.c: Fix common/ includes.
8498         * ax.h:
8499         (enum agent_op): Fix common/ includes.
8500         * ax-general.c (struct aop_map): Fix common/ includes.
8501         * ax-gdb.c: Fix common/ includes.
8502         * auxv.c: Fix common/ includes.
8503         * auto-load.c: Fix common/ includes.
8504         * arm-tdep.c: Fix common/ includes.
8505         * arch/riscv.c: Fix common/ includes.
8506         * arch/ppc-linux-common.c: Fix common/ includes.
8507         * arch/i386.c: Fix common/ includes.
8508         * arch/arm.c: Fix common/ includes.
8509         * arch/arm-linux.c: Fix common/ includes.
8510         * arch/arm-get-next-pcs.c: Fix common/ includes.
8511         * arch/amd64.c: Fix common/ includes.
8512         * arch/aarch64.c: Fix common/ includes.
8513         * arch/aarch64-insn.c: Fix common/ includes.
8514         * arch-utils.c: Fix common/ includes.
8515         * amd64-windows-tdep.c: Fix common/ includes.
8516         * amd64-tdep.c: Fix common/ includes.
8517         * amd64-sol2-tdep.c: Fix common/ includes.
8518         * amd64-obsd-tdep.c: Fix common/ includes.
8519         * amd64-nbsd-tdep.c: Fix common/ includes.
8520         * amd64-linux-tdep.c: Fix common/ includes.
8521         * amd64-linux-nat.c: Fix common/ includes.
8522         * amd64-fbsd-tdep.c: Fix common/ includes.
8523         * amd64-fbsd-nat.c: Fix common/ includes.
8524         * amd64-dicos-tdep.c: Fix common/ includes.
8525         * amd64-darwin-tdep.c: Fix common/ includes.
8526         * agent.c: Fix common/ includes.
8527         * ada-lang.h: Fix common/ includes.
8528         * ada-lang.c: Fix common/ includes.
8529         * aarch64-tdep.c: Fix common/ includes.
8530
8531 2019-01-25  Tom Tromey  <tom@tromey.com>
8532
8533         * common/create-version.sh: Use common/version.h.
8534
8535 2019-01-24  Pedro Alves  <palves@redhat.com>
8536
8537         * infrun.c (signal_stop, signal_print, signal_program)
8538         (signal_catch, signal_pass): Now arrays instead of pointers.
8539         (update_signals_program_target, do_target_resume)
8540         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8541         * linux-nat.c (linux_nat_target::pass_signals)
8542         (linux_nat_target::create_inferior, linux_nat_target::attach):
8543         Adjust.
8544         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8545         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8546         * procfs.c (procfs_target::pass_signals): Adjust.
8547         * record-full.c (record_full_target::resume): Adjust.
8548         * remote.c (remote_target::pass_signals)
8549         (remote_target::program_signals): Adjust.
8550         * target-debug.h (target_debug_print_signals): Now takes a
8551         gdb::array_view as parameter.  Adjust.
8552         * target.h (target_ops) <pass_signals, program_signals>: Replace
8553         pointer and length parameters with gdb::array_view.
8554         (target_pass_signals, target_program_signals): Likewise.
8555         * target-delegates.c: Regenerate.
8556
8557 2019-01-24  Pedro Alves  <palves@redhat.com>
8558
8559         * common/forward-scope-exit.h
8560         (forward_scope_exit::forward_scope_exit): Pass arguments to
8561         m_bind_function directly, instead of creating a std::bind and
8562         copying that.
8563
8564 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8565
8566         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8567         for static members.
8568         (pass_in_v_vfp_candidate): Likewise.
8569
8570 2019-01-23  Tom Tromey  <tom@tromey.com>
8571             Pedro Alves  <palves@redhat.com>
8572
8573         * regcache.c (class regcache_invalidator): Remove.
8574         (regcache::raw_write): Use make_scope_exit.
8575
8576 2019-01-23  Tom Tromey  <tom@tromey.com>
8577
8578         * ui-out.h (class ui_out_emit_type): Update comment.
8579
8580 2019-01-23  Tom Tromey  <tom@tromey.com>
8581
8582         * infrun.c (fetch_inferior_event): Update comment.
8583
8584 2019-01-23  Tom Tromey  <tom@tromey.com>
8585             Pedro Alves  <palves@redhat.com>
8586
8587         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8588         parameter.
8589         (fetch_inferior_event): Use SCOPE_EXIT.
8590
8591
8592 2019-01-23  Tom Tromey  <tom@tromey.com>
8593             Pedro Alves  <palves@redhat.com>
8594
8595         * infrun.c (disable_thread_events): Delete.
8596         (stop_all_threads): Use SCOPE_EXIT.
8597
8598 2019-01-23  Tom Tromey  <tom@tromey.com>
8599             Pedro Alves  <palves@redhat.com>
8600
8601         * symfile.c: Include forward-scope-exit.h.
8602         (clear_symtab_users_cleanup): Replace forward declaration with
8603         a FORWARD_SCOPE_EXIT.
8604         (syms_from_objfile_1): Use the forward_scope_exit and
8605         gdb::optional instead of cleanup_function.
8606         (reread_symbols): Use the forward_scope_exit instead of
8607         cleanup_function.
8608         (clear_symtab_users_cleanup): Remove function.
8609
8610 2019-01-23  Tom Tromey  <tom@tromey.com>
8611             Pedro Alves  <palves@redhat.com>
8612
8613         * linux-nat.c: Include scope-exit.h.
8614         (cleanup_target_stop): Remove.
8615         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8616         SCOPE_EXIT.
8617
8618 2019-01-23  Tom Tromey  <tom@tromey.com>
8619             Pedro Alves  <palves@redhat.com>
8620
8621         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8622         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8623
8624 2019-01-23  Tom Tromey  <tom@tromey.com>
8625             Andrew Burgess  <andrew.burgess@embecosm.com>
8626             Pedro Alves  <palves@redhat.com>
8627
8628         * infrun.c (fetch_inferior_event): Use scope_exit.
8629         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8630         * top.c (execute_command): Use scope_exit.
8631         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8632         * utils.c (do_bpstat_clear_actions_cleanup)
8633         (make_bpstat_clear_actions_cleanup): Remove.
8634
8635 2019-01-23  Tom Tromey  <tom@tromey.com>
8636             Pedro Alves  <palves@redhat.com>
8637
8638         * infrun.c: Include "common/scope-exit.h"
8639         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8640         (wait_for_inferior): Use SCOPE_EXIT.
8641         (fetch_inferior_event): Use scope_exit.
8642
8643 2019-01-23  Tom Tromey  <tom@tromey.com>
8644             Pedro Alves  <palves@redhat.com>
8645
8646         * breakpoint.c (create_breakpoint): Remove cleanup.
8647
8648 2019-01-23  Tom Tromey  <tom@tromey.com>
8649             Andrew Burgess  <andrew.burgess@embecosm.com>
8650             Pedro Alves  <palves@redhat.com>
8651
8652 2019-01-23  Pedro Alves  <palves@redhat.com>
8653
8654         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8655
8656 2019-01-23  Pedro Alves  <palves@redhat.com>
8657             Andrew Burgess  <andrew.burgess@embecosm.com>
8658
8659         * gdbthread.h: Include "common/forward-scope-exit.h".
8660         (scoped_finish_thread_state): Redefine custom class in terms of
8661         forward_scope_exit.
8662
8663 2019-01-23  Pedro Alves  <palves@redhat.com>
8664             Andrew Burgess  <andrew.burgess@embecosm.com>
8665
8666         * common/forward-scope-exit.h: New file.
8667
8668 2019-01-23  Pedro Alves  <palves@redhat.com>
8669             Andrew Burgess  <andrew.burgess@embecosm.com>
8670             Tom Tromey  <tom@tromey.com>
8671
8672         * common/scope-exit.h: New file.
8673
8674 2019-01-23  Pedro Alves  <palves@redhat.com>
8675
8676         * common/preprocessor.h (ESC): Rename to ...
8677         (ESC_PARENS): ... this.
8678         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8679         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8680
8681 2019-01-23  Tom Tromey  <tom@tromey.com>
8682
8683         * language.h (class scoped_switch_to_sym_language_if_auto):
8684         Initialize m_lang in both cases.
8685
8686 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8687
8688         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8689         with XCNEW.
8690
8691 2019-01-22  Tom Tromey  <tom@tromey.com>
8692
8693         * corelow.c: Do not include sys/file.h.
8694
8695 2019-01-22  Tom Tromey  <tom@tromey.com>
8696
8697         * tui/tui-wingeneral.h: Include gdb_curses.h.
8698
8699 2019-01-22  Tom Tromey  <tom@tromey.com>
8700
8701         * source-cache.h (class source_cache) <get_source_lines,
8702         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8703
8704 2019-01-22  Tom Tromey  <tom@tromey.com>
8705
8706         * remote-fileio.h (struct remote_target): Declare.
8707
8708 2019-01-22  Tom Tromey  <tom@tromey.com>
8709
8710         * python/py-arch.c: Do not include py-ref.h.
8711         * python/py-bpevent.c: Do not include py-ref.h.
8712         * python/py-cmd.c: Do not include py-ref.h.
8713         * python/py-continueevent.c: Do not include py-ref.h.
8714         * python/py-event.h: Do not include py-ref.h.
8715         * python/py-evtregistry.c: Do not include py-ref.h.
8716         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8717         * python/py-frame.c: Do not include py-ref.h.
8718         * python/py-framefilter.c: Do not include py-ref.h.
8719         * python/py-function.c: Do not include py-ref.h.
8720         * python/py-infevents.c: Do not include py-ref.h.
8721         * python/py-linetable.c: Do not include py-ref.h.
8722         * python/py-objfile.c: Do not include py-ref.h.
8723         * python/py-param.c: Do not include py-ref.h.
8724         * python/py-prettyprint.c: Do not include py-ref.h.
8725         * python/py-progspace.c: Do not include py-ref.h.
8726         * python/py-symbol.c: Do not include py-ref.h.
8727         * python/py-symtab.c: Do not include py-ref.h.
8728         * python/py-type.c: Do not include py-ref.h.
8729         * python/py-unwind.c: Do not include py-ref.h.
8730         * python/py-utils.c: Do not include py-ref.h.
8731         * python/py-value.c: Do not include py-ref.h.
8732         * python/py-varobj.c: Do not include py-ref.h.
8733         * python/py-xmethods.c: Do not include py-ref.h.
8734         * python/python.c: Do not include py-ref.h.
8735         * varobj.c: Do not include py-ref.h.
8736
8737 2019-01-22  Tom Tromey  <tom@tromey.com>
8738
8739         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8740         keyword for bcache.
8741
8742 2019-01-22  Tom Tromey  <tom@tromey.com>
8743
8744         * compile/compile-cplus-types.c: Remove a comment by #include.
8745
8746 2019-01-22  Tom Tromey  <tom@tromey.com>
8747
8748         * compile/gcc-c-plugin.h: Include compile-internal.h.
8749
8750 2019-01-22  Tom Tromey  <tom@tromey.com>
8751
8752         * stabsread.c (EXTERN): Do not define.
8753         (symnum, next_symbol_text_func, processing_gcc_compilation)
8754         (within_function, global_sym_chain, global_stabs)
8755         (previous_stab_code, this_object_header_files)
8756         (n_this_object_header_files)
8757         (n_allocated_this_object_header_files): Define.
8758         * stabsread.h (EXTERN): Never define.  Use "extern".
8759
8760 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8761
8762         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8763         history_value.
8764
8765 2019-01-21  Tom Tromey  <tom@tromey.com>
8766
8767         * ui-out.c: Fix includes.
8768         * tui/tui-source.c: Fix includes.
8769         * target.c: Fix includes.
8770         * remote.c: Fix includes.
8771         * regcache.c: Fix includes.
8772         * python/py-block.c: Fix includes.
8773         * printcmd.c: Fix includes.
8774         * or1k-tdep.c: Fix includes.
8775         * mi/mi-main.c: Fix includes.
8776         * m32r-tdep.c: Fix includes.
8777         * csky-tdep.c: Fix includes.
8778         * compile/compile-cplus-types.c: Fix includes.
8779         * cli/cli-interp.c: Fix includes.
8780
8781 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8782
8783         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8784         for padding.
8785
8786 2019-01-16  Tom Tromey  <tom@tromey.com>
8787
8788         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8789         earlier.
8790         (struct objfile) <msymbols_range>: Move from top level.
8791         <msymbols>: New method.
8792         (class objfile_msymbols): Remove.
8793         * symtab.c (default_collect_symbol_completion_matches_break_on):
8794         Update.
8795         * symmisc.c (dump_msymbols): Update.
8796         * stabsread.c (scan_file_globals): Update.
8797         * objc-lang.c (info_selectors_command, info_classes_command)
8798         (find_methods): Update.
8799         * minsyms.c (find_solib_trampoline_target): Update.
8800         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8801         * coffread.c (coff_symfile_read): Update.
8802         * ada-lang.c (ada_lookup_simple_minsym)
8803         (ada_collect_symbol_completion_matches): Update.
8804
8805 2019-01-16  Tom Tromey  <tom@tromey.com>
8806
8807         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8808         type.  Remove no-argument constructor.
8809         <iterator::operator++>: Simplify.
8810         <begin>: Update.
8811         <end>: Use minimal_symbol_count.
8812
8813 2019-01-16  Tom Tromey  <tom@tromey.com>
8814
8815         * objfiles.h (struct objfile) <psymtabs>: New method.
8816         (class objfile_psymtabs): Remove.
8817         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8818         typedef.
8819         <range>: New method.
8820         (require_partial_symbols): Change return type.
8821         * psymtab.c (require_partial_symbols)
8822         (psym_expand_symtabs_matching): Update.
8823         * mdebugread.c (parse_partial_symbols): Update.
8824         * dbxread.c (dbx_end_psymtab): Update.
8825
8826 2019-01-15  Tom Tromey  <tom@tromey.com>
8827
8828         * symtab.c (lookup_objfile_from_block)
8829         (lookup_symbol_in_objfile_symtabs)
8830         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8831         (find_line_symtab, info_sources_command)
8832         (default_collect_symbol_completion_matches_break_on)
8833         (make_source_files_completion_list): Update.
8834         * symmisc.c (print_objfile_statistics, dump_objfile)
8835         (maintenance_print_symbols, maintenance_info_symtabs)
8836         (maintenance_check_symtabs, maintenance_info_line_tables):
8837         Update.
8838         * source.c (select_source_symtab)
8839         (forget_cached_source_info_for_objfile): Update.
8840         * objfiles.h (class objfile_compunits): Remove.
8841         (struct objfile) <compunits_range>: New typedef.
8842         (compunits): New method.
8843         * objfiles.c (objfile_relocate1): Update.
8844         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8845         * maint.c (count_symtabs_and_blocks): Update.
8846         * linespec.c (iterate_over_all_matching_symtabs): Update.
8847         * cp-support.c (add_symbol_overload_list_qualified): Update.
8848         * coffread.c (coff_symtab_read): Update.
8849         * ada-lang.c (add_nonlocal_symbols)
8850         (ada_collect_symbol_completion_matches)
8851         (ada_add_global_exceptions): Update.
8852
8853 2019-01-15  Tom Tromey  <tom@tromey.com>
8854
8855         * progspace.h (program_space) <objfiles_safe_range>: New
8856         typedef.
8857         <objfiles_safe>: New method.
8858         * objfiles.h (class all_objfiles_safe): Remove.
8859         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8860         * jit.c (jit_inferior_exit_hook): Update.
8861
8862 2019-01-17  Tom Tromey  <tom@tromey.com>
8863
8864         * progspace.h (program_space) <objfiles_range>: New typedef.
8865         <objfiles>: New method.
8866         <objfiles_head>: Rename from objfiles.
8867         (object_files): Update.
8868         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8869         * guile/scm-pretty-print.c
8870         (ppscm_find_pretty_printer_from_objfiles): Update.
8871         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8872         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8873         Update.
8874         * python/py-progspace.c (pspy_get_objfiles): Update.
8875         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8876         Update.
8877         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8878         (objfpy_lookup_objfile_by_build_id): Update.
8879         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8880         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8881         Update.
8882         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8883         (expand_symtab_containing_pc, lookup_objfile_from_block)
8884         (lookup_static_symbol, basic_lookup_transparent_type)
8885         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8886         (find_line_symtab, info_sources_command)
8887         (default_collect_symbol_completion_matches_break_on)
8888         (make_source_files_completion_list, find_main_name): Update.
8889         * symmisc.c (print_symbol_bcache_statistics)
8890         (print_objfile_statistics, maintenance_print_symbols)
8891         (maintenance_print_msymbols, maintenance_print_objfiles)
8892         (maintenance_info_symtabs, maintenance_check_symtabs)
8893         (maintenance_expand_symtabs, maintenance_info_line_tables):
8894         Update.
8895         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8896         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8897         (map_overlay_command, unmap_overlay_command)
8898         (simple_overlay_update, expand_symtabs_matching)
8899         (map_symbol_filenames): Update.
8900         * symfile-debug.c (set_debug_symfile): Update.
8901         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8902         Update.
8903         * source.c (select_source_symtab, forget_cached_source_info):
8904         Update.
8905         * solib.c (solib_read_symbols): Update.
8906         * solib-spu.c (append_ocl_sos): Update.
8907         * psymtab.c (maintenance_print_psymbols)
8908         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8909         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8910         * printcmd.c (info_symbol_command): Update.
8911         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8912         Update.
8913         * objfiles.h (class all_objfiles): Remove.
8914         * objfiles.c (have_partial_symbols, have_full_symbols)
8915         (have_minimal_symbols, qsort_cmp, update_section_map)
8916         (shared_objfile_contains_address_p)
8917         (default_iterate_over_objfiles_in_search_order): Update.
8918         * objc-lang.c (info_selectors_command, info_classes_command)
8919         (find_methods): Update.
8920         * minsyms.c (find_solib_trampoline_target): Update.
8921         * maint.c (maintenance_info_sections)
8922         (maintenance_translate_address, count_symtabs_and_blocks):
8923         Update.
8924         * main.c (captured_main_1): Update.
8925         * linux-thread-db.c (try_thread_db_load_from_pdir)
8926         (has_libpthread): Update.
8927         * linespec.c (iterate_over_all_matching_symtabs)
8928         (search_minsyms_for_name): Update.
8929         * jit.c (jit_find_objf_with_entry_addr): Update.
8930         * hppa-tdep.c (find_unwind_entry)
8931         (hppa_lookup_stub_minimal_symbol): Update.
8932         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8933         Update.
8934         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8935         (elf_gnu_ifunc_resolve_by_got): Update.
8936         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8937         * dwarf-index-write.c (save_gdb_index_command): Update.
8938         * cp-support.c (add_symbol_overload_list_qualified): Update.
8939         * breakpoint.c (create_overlay_event_breakpoint)
8940         (create_longjmp_master_breakpoint)
8941         (create_std_terminate_master_breakpoint)
8942         (create_exception_master_breakpoint): Update.
8943         * blockframe.c (find_pc_partial_function): Update.
8944         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8945         (ada_collect_symbol_completion_matches)
8946         (ada_add_global_exceptions): Update.
8947
8948 2019-01-17  Tom Tromey  <tom@tromey.com>
8949
8950         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8951         declare VEC.
8952         (solib_target_parse_libraries): Change return type.
8953         (library_list_start_segment, library_list_start_section)
8954         (library_list_end_library, library_list_start_library); Update.
8955         (solib_target_free_library_list): Remove.
8956         (solib_target_parse_libraries): Remove cleanup.  Change return
8957         type.
8958         (solib_target_current_sos): Update.
8959
8960 2019-01-17  Tom Tromey  <tromey@bapiya>
8961
8962         * valprint.c: Replace "the the" with "the".
8963         * symtab.c: Replace "the the" with "the".
8964         * solib.c: Replace "the the" with "the".
8965         * solib-dsbt.c: Replace "the the" with "the".
8966         * linespec.c: Replace "the the" with "the".
8967         * dwarf2loc.h: Replace "the the" with "the".
8968         * amd64-windows-tdep.c: Replace "the the" with "the".
8969         * aarch64-tdep.c: Replace "the the" with "the".
8970
8971 2019-01-16  Keith Seitz  <keiths@redhat.com>
8972
8973         PR gdb/23773
8974         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8975         <builder>: Rename to ..
8976         <m_builder>: ... this and make private.
8977         (dwarf2_cu::get_builder): New method.  Change all users of
8978         `builder' to use this method.
8979         (dwarf2_start_symtab): Move to ...
8980         (dwarf2_cu::start_symtab): ... here.  Update all callers
8981         (setup_type_unit_groups): Move to ...
8982         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8983         callers.
8984         (dwarf2_cu::reset_builder): New method.
8985         (process_full_compunit, process_full_type_unit): Use
8986         dwarf2_cu::reset_builder.
8987         (follow_die_offset): Record the ancestor CU if it is different
8988         from the followed DIE's CU.
8989         (follow_die_sig_1): Likewise.
8990
8991 2019-01-15  Tom Tromey  <tom@tromey.com>
8992
8993         * remote.c (class remote_state) <buf>: Now a char_vector.
8994         <buf_size>: Remove.
8995         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8996         parameter.
8997         (remote_target::getpkt_or_notif_sane_1)
8998         (remote_target::getpkt_sane)
8999         (remote_target::getpkt_or_notif_sane): Likewise.
9000         (class remote_target) <putpkt>: New overload.
9001         (remote_target::read_frame): Change type of "buf_p".  Remove
9002         sizeof_p parameter.
9003         (packet_ok): New overload.
9004         (packet_check_result): New overload.
9005         Update all uses.
9006
9007 2019-01-14  Tom Tromey  <tom@tromey.com>
9008
9009         * remote-notif.c (handle_notification, remote_notif_ack)
9010         (remote_notif_parse): Make "buf" const.
9011         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9012         const.
9013         (remote_notif_parse, remote_notif_ack, handle_notification):
9014         Likewise.
9015         * remote.c (remote_notif_stop_parse): Make "buf" const.
9016         (remote_target::remote_parse_stop_reply): Make "buf" const.
9017         (remote_notif_stop_ack): Make "buf" const.
9018
9019 2019-01-14  Tom Tromey  <tom@tromey.com>
9020
9021         * remote.c (remote_console_output): Make parameter const.
9022
9023 2019-01-14  Tom Tromey  <tom@tromey.com>
9024
9025         * target-debug.h (target_debug_print_signals): Constify.
9026         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9027         * procfs.c (procfs_target::pass_signals): Update.
9028         * linux-nat.c (linux_nat_target::pass_signals): Update.
9029         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9030         * target-delegates.c: Rebuild.
9031         * remote.c (remote_target::program_signals): Update.
9032         (remote_target::pass_signals): Update.
9033         * target.c (target_pass_signals): Constify argument.
9034         (target_program_signals): Likewise.
9035         * target.h (struct target_ops) <pass_signals, program_signals>:
9036         Constify argument.
9037         (target_pass_signals, target_program_signals): Constify argument.
9038
9039 2019-01-14  Tom Tromey  <tom@tromey.com>
9040
9041         PR tui/28819:
9042         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9043
9044 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9045
9046         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9047         field.
9048         * rs6000-tdep.c: Include reggroups.h.
9049         (IS_V_ALIAS_PSEUDOREG): Define.
9050         (rs6000_register_name): Return names for the "vX" aliases.
9051         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9052         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9053         aliases.  Call default_register_reggroup_p for all other
9054         pseudo-registers.
9055         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9056         New functions.
9057         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9058         Handle "vX" aliases.
9059         (v_alias_pseudo_register_collect): New function.
9060         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9061         (rs6000_gdbarch_init): Initialize "vX" aliases as
9062         pseudo-registers.  Restore registration of
9063         rs6000_pseudo_register_reggroup_p with
9064         set_tdesc_pseudo_register_reggroup_p.
9065
9066 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9067
9068         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9069         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9070         set_gdbarch_num_pseudo_regs.
9071
9072 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9073
9074         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9075         Remove arg prefixname, add do_set and do_show.
9076         Add member functions set_list and show_list.
9077         * cli/cli-style.c (class cli_style_option): Update accordingly.
9078         (style_set_list): Move to file scope.
9079         (style_show_list): Likewise.
9080         (set_style): Call help_list.
9081         (show_style): Call cmd_show_list.
9082         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9083         Update to use the new macro.
9084
9085 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9086
9087         * ada-lang.c (_initialize_ada_language): Expand the help text
9088         for the "catch exception" command.
9089
9090 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9091
9092         * symtab.c (matching_obj_sections): Initialize obj,
9093         declare it closer to its usage.
9094
9095 2019-01-10  Tom Tromey  <tom@tromey.com>
9096
9097         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9098         (basic_inf_threads_range): Remove.
9099         (inf_threads_range, inf_non_exited_threads_range)
9100         (safe_inf_threads_range): Use next_adapter.
9101
9102 2019-01-10  Keith Seitz  <keiths@redhat.com>
9103
9104         PR gdb/23712
9105         PR symtab/23010
9106         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9107         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9108
9109 2019-01-10  Keith Seitz  <keiths@redhat.com>
9110
9111         PR gdb/23712
9112         PR symtab/23010
9113         * dictionary.c (pending_to_vector): Remove.
9114         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9115         Remove _1 suffix, replacing functions of the same name.  Update
9116         all callers.
9117         (dict_create_hashed, dict_create_hashed_expandable)
9118         (dict_create_linear, dict_create_linear_expandable, dict_free)
9119         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9120         Make functions static.
9121
9122 2019-01-10  Keith Seitz  <keiths@redhat.com>
9123
9124         PR gdb/23712
9125         PR symtab/23010
9126         * dictionary.h (struct dictionary): Replace declaration with
9127         multidictionary.
9128         (dict_create_hashed, dict_create_hashed_expandable)
9129         (dict_create_linear, dict_create_linear_expandable)
9130         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9131         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9132         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9133         taking multidictionary argument.
9134         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9135         * block.h (struct block) <dict>: Change to multidictionary
9136         and rename `multidict'.
9137         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9138         symmisc.c: Update all dictionary references to multidictionary.
9139
9140 2019-01-10  Keith Seitz  <keiths@redhat.com>
9141
9142         PR gdb/23712
9143         PR symtab/23010
9144         * dictionary.c: Include unordered_map.
9145         (pending_to_vector): New function.
9146         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9147         Rewrite the non-"_1" functions to take vector instead
9148         of linked list.
9149         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9150         "new" _1 versions of the same name.
9151         (multidictionary): Define.
9152         (std::hash<enum language): New definition.
9153         (collate_pending_symbols_by_language, mdict_create_hashed)
9154         (mdict_create_hashed_expandable, mdict_create_linear)
9155         (mdict_create_linear_expandable, mdict_free)
9156         (find_language_dictionary, create_new_language_dictionary)
9157         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9158         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9159         (mdict_size, mdict_empty): New functions.
9160         * dictionary.h (mdict_iterator): Define.
9161
9162 2019-01-10  Pedro Alves  <palves@redhat.com>
9163
9164         * breakpoint.c (read_uploaded_action)
9165         (create_tracepoint_from_upload): Adjust to use
9166         gdb::unique_xmalloc_ptr.
9167         * ctf.c (ctf_write_uploaded_tp):
9168         (SET_ARRAY_FIELD): Use emplace_back.
9169         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9170         * tracefile-tfile.c (tfile_write_uploaded_tp):
9171         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9172         gdb::unique_xmalloc_ptr.
9173         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9174         at_string, cond_string, cmd_strings>: Replace char pointers
9175         with gdb::unique_xmalloc_ptr.
9176
9177 2019-01-10  Pedro Alves  <palves@redhat.com>
9178
9179         * solib-target.c (library_list_start_library): Don't xstrdup name.
9180
9181 2019-01-10  Pedro Alves  <palves@redhat.com>
9182
9183         * mdebugread.c (parse_partial_symbols): Use
9184         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9185
9186 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9187
9188         * linux-fork.c (scoped_switch_fork_info)
9189         <~scoped_switch_fork_info>: Fix incorrect variable name.
9190
9191 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9192
9193         * linux-fork.c (scoped_switch_fork_info)
9194         <scoped_switch_fork_info>: Make explicit.
9195         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9196
9197 2019-01-10  Tom Tromey  <tom@tromey.com>
9198
9199         * objfiles.h (objfile::reset_psymtabs): Update.
9200         * objfiles.c (objfile::objfile): Update.
9201         * psymtab.h (psymtab_storage::obstack): Update.
9202         (psymtab_storage::m_obstack): Use gdb::optional.
9203         (class psymtab_storage): Update comment.  Remove objfile
9204         parameter.
9205         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9206
9207 2019-01-10  Tom Tromey  <tom@tromey.com>
9208
9209         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9210         <free_psymtabs>: Now private.
9211         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9212         (allocate_psymtab): Use new method.
9213
9214 2019-01-10  Tom Tromey  <tom@tromey.com>
9215
9216         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9217         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9218         * mdebugread.c (parse_partial_symbols): Use
9219         allocate_dependencies.
9220         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9221         allocate_dependencies.
9222         (process_psymtab_comp_unit_reader)
9223         (build_type_psymtab_dependencies): Likewise.
9224         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9225
9226 2019-01-10  Tom Tromey  <tom@tromey.com>
9227
9228         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9229         PSYMBOL_SET_LANGUAGE.
9230         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9231
9232 2019-01-10  Tom Tromey  <tom@tromey.com>
9233
9234         * psymtab.h (psymtab_storage::obstack): New method.
9235         <m_obstack>: Rename from obstack; now private.
9236         * psymtab.c (psymtab_storage): Update.
9237         * dwarf2read.c (create_addrmap_from_index)
9238         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9239         Update.
9240
9241 2019-01-10  Tom Tromey  <tom@tromey.com>
9242
9243         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9244         * objfiles.h (objfile::reset_psymtabs): New method.
9245
9246 2019-01-10  Tom Tromey  <tom@tromey.com>
9247
9248         * symmisc.c (print_symbol_bcache_statistics): Update.
9249         (print_objfile_statistics): Update.
9250         * symfile.c (reread_symbols): Update.
9251         * psymtab.h (class psymtab_storage): New.
9252         * psymtab.c (psymtab_storage): New constructor.
9253         (~psymtab_storage): New destructor.
9254         (require_partial_symbols): Update.
9255         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9256         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9257         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9258         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9259         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9260         (start_psymtab_common, end_psymtab_common)
9261         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9262         (allocate_psymtab): Update.
9263         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9264         Update.
9265         (dump_psymtab_addrmap, maintenance_print_psymbols)
9266         (maintenance_check_psymtabs): Update.
9267         (class objfile_psymtabs): Move to objfiles.h.
9268         * psympriv.h (discard_psymtab): Now inline.
9269         (psymtab_discarder::psymtab_discarder): Update.
9270         (psymtab_discarder::~psymtab_discarder): Update.
9271         (ALL_OBJFILE_PSYMTABS): Rewrite.
9272         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9273         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9274         Remove fields.
9275         <partial_symtabs>: New field.
9276         (class objfile_psymtabs): Move from psymtab.h.  Update.
9277         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9278         psymbol_cache.
9279         (objfile::~objfile): Don't destroy psymbol_cache.
9280         * mdebugread.c (parse_partial_symbols): Update.
9281         * dwarf2read.c (create_addrmap_from_index)
9282         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9283         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9284         (add_partial_subprogram, dwarf2_ranges_read): Update.
9285         * dwarf-index-write.c (write_address_map)
9286         (write_one_signatured_type, recursively_write_psymbols)
9287         (class debug_names, class debug_names, write_psymtabs_to_index):
9288         Update.
9289
9290 2019-01-10  Tom Tromey  <tom@tromey.com>
9291
9292         * symtab.h (SYMBOL_SET_NAMES): Update.
9293         (symbol_set_names): Update.
9294         (MSYMBOL_SET_NAMES): Update.
9295         * symtab.c (symbol_set_names): Change argument to be an
9296         objfile_per_bfd_storage.
9297         * psymtab.c (add_psymbol_to_bcache): Update.
9298         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9299
9300 2019-01-10  Tom Tromey  <tom@tromey.com>
9301
9302         * symtab.c (create_demangled_names_hash): Change argument to be an
9303         objfile_per_bfd_storage.
9304         (symbol_set_names): Update.
9305
9306 2019-01-10  Tom Tromey  <tom@tromey.com>
9307
9308         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9309         init_psymbol_list.
9310         * psymtab.c (init_psymbol_list): Do nothing if already called.
9311         * psympriv.h (init_psymbol_list): Add comment.
9312         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9313         init_psymbol_list.
9314         * dbxread.c (dbx_symfile_read): Unconditionally call
9315         init_psymbol_list.
9316
9317 2019-01-10  Tom Tromey  <tom@tromey.com>
9318
9319         * xcoffread.c (scan_xcoff_symtab): Update.
9320         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9321         "where".
9322         * mdebugread.c (parse_partial_symbols)
9323         (handle_psymbol_enumerators): Update.
9324         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9325         * dbxread.c (read_dbx_symtab): Update.
9326         * psympriv.h (psymbol_placement): New enum.
9327         (add_psymbol_to_list): Update.
9328
9329 2019-01-10  Tom Tromey  <tom@tromey.com>
9330
9331         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9332         static_psymbols parameters.
9333         (scan_xcoff_symtab): Update.
9334         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9335         static_psymbols parameters.
9336         * psympriv.h (start_psymtab_common): Update.
9337         * mdebugread.c (parse_partial_symbols): Update.
9338         * dwarf2read.c (create_partial_symtab): Update.
9339         * dbxread.c (read_dbx_symtab): Update.
9340         (start_psymtab): Remove global_psymbols and static_psymbols
9341         parameters.
9342
9343 2019-01-10  Tom Tromey  <tom@tromey.com>
9344
9345         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9346         * psymtab.c (allocate_psymtab): Add comment.
9347         * psympriv.h (allocate_psymtab): Add comment.
9348         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9349         initializations.
9350         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9351
9352 2019-01-10  Tom Tromey  <tom@tromey.com>
9353
9354         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9355         Don't declare.
9356         * mipsread.c: Include mdebugread.h.
9357         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9358         Declare.
9359         * elfread.c: Include mdebugread.h.
9360
9361 2019-01-09  Tom Tromey  <tom@tromey.com>
9362
9363         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9364         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9365         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9366         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9367         (psym_lookup_symbol, psym_find_last_source_symtab)
9368         (psym_forget_cached_source_info, psym_print_stats)
9369         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9370         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9371         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9372         (psym_find_compunit_symtab_by_address)
9373         (maintenance_print_psymbols, maintenance_info_psymtabs)
9374         (maintenance_check_psymtabs): Use ranged for.
9375         * psymtab.h (class objfile_psymtabs): New.
9376         (require_partial_symbols): Return objfile_psymtabs.
9377         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9378
9379 2019-01-09  Tom Tromey  <tom@tromey.com>
9380
9381         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9382         (find_pc_mapped_section, list_overlays_command)
9383         (map_overlay_command, unmap_overlay_command)
9384         (simple_overlay_update): Use all_objfiles.
9385         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9386         * printcmd.c (info_symbol_command): Use all_objfiles.
9387         * objfiles.h (ALL_OBJSECTIONS): Remove.
9388         * maint.c (maintenance_translate_address): Use all_objfiles.
9389         * gcore.c (gcore_create_callback): Use all_objfiles.
9390         (objfile_find_memory_regions): Likewise.
9391
9392 2019-01-09  Tom Tromey  <tom@tromey.com>
9393
9394         * symtab.c (find_line_symtab, info_sources_command)
9395         (make_source_files_completion_list): Use objfile_compunits.
9396         * source.c (select_source_symtab): Use objfile_compunits.
9397         * objfiles.h (struct objfile): Update comment.
9398         (ALL_OBJFILES): Remove.
9399         (ALL_FILETABS): Remove.
9400         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9401         objfile_compunits.
9402
9403 2019-01-09  Tom Tromey  <tom@tromey.com>
9404
9405         * symmisc.c (print_objfile_statistics, dump_objfile)
9406         (maintenance_print_symbols): Use compunit_filetabs.
9407         * source.c (forget_cached_source_info_for_objfile): Use
9408         compunit_filetabs.
9409         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9410         (ALL_FILETABS): Use compunit_filetabs.
9411         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9412         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9413
9414 2019-01-09  Tom Tromey  <tom@tromey.com>
9415
9416         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9417         (compunit_filetabs): New.
9418         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9419         compunit_filetabs.
9420         (info_sources_command, make_source_files_completion_list): Remove
9421         declaration.
9422         * symmisc.c (print_objfile_statistics, dump_objfile)
9423         (maintenance_print_symbols): Remove declaration.
9424         (maintenance_info_symtabs): Use compunit_filetabs.
9425         (maintenance_info_line_tables): Likewise.
9426         * source.c (select_source_symtab): Change local variable name.
9427         (forget_cached_source_info_for_objfile): Remove declaration.
9428         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9429         * objfiles.c (objfile_relocate1): Remove declaration.
9430         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9431         declaration.
9432         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9433         * coffread.c (coff_symtab_read): Remove declaration.
9434         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9435         compunit_filetabs.
9436
9437 2019-01-09  Tom Tromey  <tom@tromey.com>
9438
9439         * symtab.c (lookup_objfile_from_block)
9440         (find_pc_sect_compunit_symtab, search_symbols)
9441         (default_collect_symbol_completion_matches_break_on): Use
9442         objfile_compunits.
9443         * objfiles.h (ALL_COMPUNITS): Remove.
9444         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9445         * cp-support.c (add_symbol_overload_list_qualified): Use
9446         objfile_compunits.
9447         * ada-lang.c (ada_collect_symbol_completion_matches)
9448         (ada_add_global_exceptions): Use objfile_compunits.
9449
9450 2019-01-09  Tom Tromey  <tom@tromey.com>
9451
9452         * source.c (select_source_symtab)
9453         (forget_cached_source_info_for_objfile): Remove declaration.
9454         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9455         declaration.
9456         * maint.c (count_symtabs_and_blocks): Remove declaration.
9457         * cp-support.c (add_symbol_overload_list_qualified): Remove
9458         declaration.
9459         * coffread.c (coff_symtab_read): Remove declaration.
9460         * symtab.c (lookup_symbol_in_objfile_symtabs)
9461         (basic_lookup_transparent_type_1): Use objfile_compunits.
9462         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9463         (info_sources_command, search_symbols)
9464         (default_collect_symbol_completion_matches_break_on)
9465         (make_source_files_completion_list): Remove declaration.
9466         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9467         (ada_collect_symbol_completion_matches)
9468         (ada_add_global_exceptions): Remove declaration.
9469         * linespec.c (iterate_over_all_matching_symtabs): Use
9470         objfile_compunits.
9471         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9472         (class objfile_compunits): New.
9473         (ALL_COMPUNITS): Use objfile_compunits.
9474         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9475         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9476         objfile_compunits.
9477         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9478
9479 2019-01-09  Tom Tromey  <tom@tromey.com>
9480
9481         * symtab.c (search_symbols)
9482         (default_collect_symbol_completion_matches_break_on): Use
9483         objfile_msymbols.
9484         * ada-lang.c (ada_lookup_simple_minsym)
9485         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9486         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9487         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9488         objfile_msymbols.
9489         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9490         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9491         * objc-lang.c (find_methods): Use objfile_msymbols.
9492         (info_selectors_command, info_classes_command): Likewise.
9493         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9494         * objfiles.h (class objfile_msymbols): New.
9495         (ALL_OBJFILE_MSYMBOLS): Remove.
9496         (ALL_MSYMBOLS): Remove.
9497
9498 2019-01-09  Tom Tromey  <tom@tromey.com>
9499
9500         * common/next-iterator.h (next_adapter): Add Iterator template
9501         parameter.
9502         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9503         (class all_objfiles_safe): New.
9504         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9505         * objfiles.c (put_objfile_before): Update comment.
9506         (add_separate_debug_objfile): Likewise.
9507         (free_all_objfiles): Use all_objfiles_safe.
9508         (objfile_purge_solibs): Likewise.
9509
9510 2019-01-09  Tom Tromey  <tom@tromey.com>
9511
9512         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9513         (expand_symtab_containing_pc, lookup_static_symbol)
9514         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9515         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9516         all_objfiles.
9517         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9518         * breakpoint.c (create_overlay_event_breakpoint)
9519         (create_longjmp_master_breakpoint)
9520         (create_std_terminate_master_breakpoint)
9521         (create_exception_master_breakpoint): Use all_objfiles.
9522         * linux-thread-db.c (try_thread_db_load_from_pdir)
9523         (has_libpthread): Use all_objfiles.
9524         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9525         * linespec.c (iterate_over_all_matching_symtabs)
9526         (search_minsyms_for_name): Use all_objfiles.
9527         * maint.c (maintenance_info_sections): Use all_objfiles.
9528         * main.c (captured_main_1): Use all_objfiles.
9529         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9530         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9531         * guile/scm-pretty-print.c
9532         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9533         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9534         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9535         (maintenance_print_msymbols): Use all_objfiles.
9536         * source.c (select_source_symtab): Use all_objfiles.
9537         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9538         * symfile.c (remove_symbol_file_command)
9539         (expand_symtabs_matching, map_symbol_filenames): Use
9540         all_objfiles.
9541         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9542         all_objfiles.
9543         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9544         * objc-lang.c (find_methods): Use all_objfiles.
9545         * objfiles.c (have_partial_symbols, have_full_symbols)
9546         (have_minimal_symbols, qsort_cmp)
9547         (default_iterate_over_objfiles_in_search_order): Use
9548         all_objfiles.
9549         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9550         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9551         (maintenance_check_psymtabs): Use all_objfiles.
9552         (ALL_PSYMTABS): Remove.
9553         * compile/compile-object-run.c (do_module_cleanup): Use
9554         all_objfiles.
9555         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9556         * cp-support.c (add_symbol_overload_list_qualified): Use
9557         all_objfiles.
9558         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9559         Use all_objfiles.
9560         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9561         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9562         all_objfiles.
9563         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9564         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9565         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9566         Uses all_objfiles.
9567         * solib.c (solib_read_symbols): Use all_objfiles
9568
9569 2019-01-09  Tom Tromey  <tom@tromey.com>
9570
9571         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9572         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9573         all_objfiles.
9574         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9575         * symmisc.c (print_symbol_bcache_statistics)
9576         (print_objfile_statistics, maintenance_print_objfiles)
9577         (maintenance_info_symtabs, maintenance_check_symtabs)
9578         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9579         all_objfiles.
9580         * source.c (forget_cached_source_info): Use all_objfiles.
9581         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9582         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9583         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9584         * objfiles.c (update_section_map): Use all_objfiles.
9585         (shared_objfile_contains_address_p): Likewise.
9586         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9587         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9588
9589 2019-01-09  Tom Tromey  <tom@tromey.com>
9590
9591         * common/next-iterator.h: New file.
9592         * objfiles.h (class all_objfiles): New.
9593         (struct objfile_iterator): New.
9594
9595 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9596
9597         * NEWS: Move the description of the changed "frame", "select-frame",
9598          and "info frame" commands to the Changed commands section.
9599
9600 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9601
9602         * gdbtypes.c (check_stub_method_group): Remove handling of old
9603         mangling schemes.
9604         * linespec.c (find_methods): Likewise.
9605         * stabsread.c (read_member_functions): Likewise.
9606         * valops.c (search_struct_method): Likewise.
9607         (value_struct_elt_for_reference): Likewise.
9608         * NEWS: Mention this change.
9609
9610 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9611
9612         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9613         print_source_lines.
9614         * source.c (print_source_lines_base): Update line number check.
9615         (print_source_lines): New function.
9616         (source_lines_range::source_lines_range): New function.
9617         * source.h (class source_lines_range): New class.
9618         (print_source_lines): New declaration.
9619
9620 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9621
9622         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9623
9624 2019-01-08  Tom Tromey  <tom@tromey.com>
9625             Simon Marchi  <simon.marchi@ericsson.com>
9626
9627         PR gdb/24060
9628         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9629         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9630         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9631         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9632         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9633         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9634
9635 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9636
9637         * source.c (select_source_symtab): Move header comment to
9638         declaration in source.h.
9639         (forget_cached_source_info_for_objfile): Likewise.
9640         (forget_cached_source_info): Likewise.
9641         (identify_source_line): Likewise.
9642         * source.h (identify_source_line): Move declaration from symtab.h
9643         and add comment from source.c
9644         (print_source_lines): Likewise.
9645         (forget_cached_source_info_for_objfile): Likewise.
9646         (forget_cached_source_info): Likewise.
9647         (select_source_symtab): Likewise.
9648         (enum print_source_lines_flag): Move definition from symtab.h.
9649         * symtab.h (identify_source_line): Move declaration to source.h.
9650         (print_source_lines): Likewise.
9651         (forget_cached_source_info_for_objfile): Likewise.
9652         (forget_cached_source_info): Likewise.
9653         (select_source_symtab): Likewise.
9654         (enum print_source_lines_flag): Move definition to source.h.
9655         * tui/tui-hooks.c: Add 'source.h' include.
9656
9657 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9658
9659         * source.c (print_source_lines_base): Handle requests to print
9660         reverse line number sequences, and guard against empty lines
9661         string.
9662
9663 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9664
9665         * source.c (print_source_lines_base): Fix skip of '\r' if next
9666         character is '\n'.
9667
9668 2019-01-06  Tom Tromey  <tom@tromey.com>
9669
9670         * c-exp.y (struct c_parse_state) <macro_original_text,
9671         expansion_obstack>: New member.
9672         (macro_original_text, expansion_obstack): Remove globals.
9673         (scan_macro_expansion, scanning_macro_expansion)
9674         (finished_macro_expansion): Update.
9675         (scan_macro_cleanup): Remove.
9676         (yylex, c_parse): Update.
9677
9678 2019-01-06  Tom Tromey  <tom@tromey.com>
9679
9680         * c-exp.y (struct c_parse_state) <strings>: New member.
9681         (operator_stoken): Update.
9682
9683 2019-01-06  Tom Tromey  <tom@tromey.com>
9684
9685         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9686         (union type_stack_elt) <typelist_val>: Now a pointer to
9687         std::vector.
9688         (type_stack_cleanup): Don't declare.
9689         (push_typelist): Update.
9690         * parse.c (pop_typelist): Return a std::vector.
9691         (push_typelist): Take a std::vector.
9692         (follow_types): Update.  Do not free args.
9693         (type_stack_cleanup): Remove.
9694         * c-exp.y (struct c_parse_state): New.
9695         (cpstate): New global.
9696         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9697         (nonempty_typelist): Update.
9698         (func_mod): Create a new vector.
9699         (c_parse): Create a c_parse_state.
9700         (check_parameter_typelist): Do not delete params.
9701         (function_method): Update.  Do not delete type_list.
9702
9703 2019-01-06  Tom Tromey  <tom@tromey.com>
9704
9705         PR gdb/28155:
9706         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9707         check_typedef.
9708         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9709         (print_return_value): Likewise.
9710
9711 2019-01-05  Tom Tromey  <tom@tromey.com>
9712
9713         * contrib/cleanup_check.py: Remove.
9714         * contrib/gcc-with-excheck: Remove.
9715         * contrib/exsummary.py: Remove.
9716         * contrib/excheck.py: Remove.
9717
9718 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9719
9720         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9721         NULL. Initialize tpprev to NULL instead of assigning it
9722         to NULL on the next statement.
9723         * windows-nat.c (windows_delete_thread): Remove check for
9724         main_thread_id before printing thread exit notifications.
9725         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9726         Remove thread ID check against main_thread_id.
9727         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9728         windows_delete_thread.
9729         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9730
9731 2019-01-04  Tom Tromey  <tom@tromey.com>
9732
9733         * compile/compile.c (_initialize_compile): Use upper case for
9734         metasyntactic variables.
9735         * symmisc.c (_initialize_symmisc): Use upper case for
9736         metasyntactic variables.
9737         * psymtab.c (_initialize_psymtab): Use upper case for
9738         metasyntactic variables.
9739         * demangle.c (demangle_command): Use upper case for metasyntactic
9740         variables.
9741         (_initialize_demangler): Likewise.
9742         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9743         variables.
9744
9745 2019-01-03  Tom Tromey  <tom@tromey.com>
9746
9747         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9748
9749 2019-01-03  Tom Tromey  <tom@tromey.com>
9750
9751         * python/py-symtab.c (salpy_str): Update.
9752         (struct salpy_sal_object) <symtab>: Now a PyObject.
9753         (salpy_dealloc): Update.
9754         (del_objfile_sal): Use gdbpy_ref.
9755
9756 2019-01-03  Tom Tromey  <tom@tromey.com>
9757
9758         * python/py-type.c (convert_field): Use new_reference.  Return
9759         gdbpy_ref.
9760         (make_fielditem): Return gdbpy_ref.
9761         (typy_fields): Update.
9762         (typy_getitem): Update.
9763         (field_name): Return gdbpy_ref.  Use new_reference.
9764         (typy_iterator_iternext): Update.
9765
9766 2019-01-03  Tom Tromey  <tom@tromey.com>
9767
9768         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9769
9770 2019-01-03  Tom Tromey  <tom@tromey.com>
9771
9772         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9773         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9774         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9775         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9776         (pspy_set_type_printers): Likewise.
9777         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9778         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9779         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9780         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9781         (objfpy_set_type_printers): Likewise.
9782
9783 2019-01-03  Tom Tromey  <tom@tromey.com>
9784
9785         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9786         (gdbpy_print_stack): Use gdbpy_err_fetch.
9787         * python/python-internal.h (class gdbpy_err_fetch): New class.
9788         (class gdbpy_enter) <m_error_type, m_error_value,
9789         m_error_traceback>: Remove.
9790         <m_error>: New member.
9791         (gdbpy_exception_to_string): Don't declare.
9792         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9793         * python/py-value.c (convert_value_from_python): Use
9794         gdbpy_err_fetch.
9795         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9796         gdbpy_exception_to_string.
9797         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9798         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9799         gdbpy_err_fetch.
9800
9801 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9802
9803         * linux-nat.c (delete_lwp_cleanup): Delete.
9804         (struct lwp_deleter): New struct.
9805         (lwp_info_up): New typedef.
9806         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9807         lwp_info_up.
9808
9809 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9810
9811         * linux-fork.c (class scoped_switch_fork_info): New class.
9812         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9813
9814 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9815
9816         * valops.c (find_overload_match): Remove use of null_cleanup, and
9817         calls to do_cleanups.
9818
9819 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9820
9821         * compile/compile-cplus-types.c
9822         (compile_cplus_instance::decl_name): Handle changes to
9823         cp_func_name.
9824         * cp-support.c (cp_func_name): Update header comment, update
9825         return type.
9826         * cp-support.h (cp_func_name): Update return type in declaration.
9827         * valops.c (find_overload_match): Move temp_func local to top
9828         level of function and change its type.  Use temp_func to hold and
9829         delete temporary string obtained from cp_func_name.
9830
9831 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9832
9833         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9834         gdb::char_vector, remove cleanup, and update uses of `msg`.
9835
9836 2019-01-03  Jim Wilson  <jimw@sifive.com>
9837
9838         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9839
9840 2019-01-02  Tom Tromey  <tom@tromey.com>
9841
9842         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9843         (tdesc_parse_xml): Remove cleanups.
9844         * target-descriptions.h (make_cleanup_free_target_description):
9845         Don't declare.
9846         (target_desc_deleter): New struct.
9847         (target_desc_up): New typedef.
9848         * target-descriptions.c (target_desc_deleter::operator()): Rename
9849         from free_target_description.
9850         (make_cleanup_free_target_description): Remove.
9851
9852 2019-01-02  Tom Tromey  <tom@tromey.com>
9853
9854         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9855         constructor, destructor.
9856         (linespec_parser): Remove typedef.
9857         (~linespec_parser): Rename from linespec_parser_delete.
9858         (linespec_lex_to_end, linespec_complete_label)
9859         (linespec_complete): Update.
9860         (decode_line_full): Remove cleanups.
9861         (decode_line_1): Update.
9862
9863 2019-01-02  Tom Tromey  <tom@tromey.com>
9864
9865         * python/python-internal.h (inferior_to_inferior_object): Change
9866         return type.
9867         * python/py-exitedevent.c (create_exited_event_object): Update.
9868         * python/py-inferior.c (inferior_to_inferior_object): Return
9869         gdbpy_ref.
9870         (python_new_inferior, python_inferior_deleted)
9871         (thread_to_thread_object, delete_thread_object)
9872         (build_inferior_list, gdbpy_selected_inferior): Update.
9873         * python/py-infthread.c (create_thread_object): Update.  Also fail
9874         if inferior_to_inferior_object fails.
9875
9876 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9877
9878         * inferior.h (class inferior) <displaced_step_state>: New field.
9879         * infrun.h (struct displaced_step_state): Move here from
9880         infrun.c.  Initialize fields, add constructor.
9881         <inf>: Remove field.
9882         <reset>: New method.
9883         * infrun.c (struct displaced_step_inferior_state): Move to
9884         infrun.h.
9885         (displaced_step_inferior_states): Remove.
9886         (get_displaced_stepping_state): Adust.
9887         (displaced_step_in_progress_any_inferior): Adjust.
9888         (displaced_step_in_progress_thread): Adjust.
9889         (displaced_step_in_progress): Adjust.
9890         (add_displaced_stepping_state): Remove.
9891         (get_displaced_step_closure_by_addr): Adjust.
9892         (remove_displaced_stepping_state): Remove.
9893         (infrun_inferior_exit): Call displaced_step_state.reset.
9894         (use_displaced_stepping): Don't check for NULL.
9895         (displaced_step_prepare_throw): Call
9896         get_displaced_stepping_state.
9897         (displaced_step_fixup): Don't check for NULL.
9898         (prepare_for_detach): Don't check for NULL.
9899
9900 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9901
9902         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9903          in case of call that did not complete.
9904
9905 2019-01-02  Andrey Utkin  <autkin@undo.io>
9906
9907         * symfile.c (find_separate_debug_file): Fix search of debug files for
9908         remote debuggee.
9909
9910 2019-01-02  Tom Tromey  <tom@tromey.com>
9911
9912         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9913         indentation.
9914         * python/py-frame.c (frapy_older): Remove cast.
9915         (frapy_newer): Likewise.
9916         * python/py-breakpoint.c (local_setattro): Remove cast.
9917         * python/py-arch.c (archpy_name): Remove local variable.
9918         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9919
9920 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9921
9922         * unittests/basic_string_view/element_access/char/empty.cc:
9923         Fix year range in copyright header.
9924
9925 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9926
9927         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9928         Delete.
9929         <operator==>: Update with for removed field.
9930         <hash>: Likewise.
9931         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9932         <isa_features>: ...this.
9933         <abi_features>: New field.
9934         (riscv_isa_flen): Update comment.
9935         (riscv_abi_xlen): New declaration.
9936         (riscv_abi_flen): New declaration.
9937         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9938         isa_features.
9939         (riscv_abi_xlen): New function.
9940         (riscv_isa_flen): Update to get answer from isa_features.
9941         (riscv_abi_flen): New function.
9942         (riscv_has_fp_abi): Update to get answer from abi_features.
9943         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9944         xlen and flen.
9945         (riscv_call_info) <xlen, flen>: Update comment.
9946         (riscv_call_arg_struct): Remove invalid assertions
9947         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9948         is removed.
9949         (riscv_gdbarch_init): Gather isa features and abi features
9950         separately, ensure both match on the gdbarch when reusing an old
9951         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9952         a target with 64-bit float hardware.
9953
9954 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9955
9956         * source.c (search_command_helper): Stop reverse search
9957         when line 1 has been searched.
9958
9959 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9960
9961         * record-full.c (record_full_base_target::close): Rewrite
9962         record_full_core_buf_list free logic.
9963
9964 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9965
9966         * break-catch-syscall.c (print_one_catch_syscall): xfree
9967         the last text.
9968
9969 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9970
9971         * top.c (print_gdb_version): Update Copyright year in version
9972         message.
9973
9974 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9975
9976         Update copyright year range in all GDB files.
9977
9978 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9979
9980         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9981
9982 For older changes see ChangeLog-2018.
9983 \f
9984 Local Variables:
9985 mode: change-log
9986 left-margin: 8
9987 fill-column: 74
9988 version-control: never
9989 coding: utf-8
9990 End:
9991