gdb/ChangeLog

   1 2019-03-18  Pedro Alves  <palves@redhat.com>
   2             Eli Zaretskii <eliz@gnu.org>
   3
   4         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
   5         m_line and m_start_of_line.
   6
   7 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
   8
   9         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
  10         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
  11         it returns a newline.  This fixes a regression in TU mode, whereby
  12         the next line is output on the same screen line as the user input.
  13
  14 2019-03-18  Pedro Alves  <palves@redhat.com>
  15
  16         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
  17         New globals.
  18         (apply_style): New, factored out from ...
  19         (apply_ansi_escape): ... this.  Handle reverse video mode.
  20         (tui_set_reverse_mode): New function.
  21         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
  22         * tui/tui-winsource.c (tui_show_source_line): Use
  23         tui_set_reverse_mode instead of setting A_STANDOUT.
  24         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
  25         New setter methods.
  26
  27 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
  28
  29         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
  30         Handle tabs.
  31
  32 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
  33
  34         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
  35         tui_refill_source_window instead of tui_refresh_win, to update the
  36         current execution line.  This fixes redisplay of the current line
  37         when stepping through the code with "next" or "step".
  38
  39 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
  40
  41         * source-cache.c (source_cache::get_source_lines): Call
  42         find_source_lines to initialize s->nlines.  This fixes vertical
  43         scrolling of TUI source window when the DOWN arrow is pressed.
  44
  45 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
  46
  47         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
  48         wclrtoeol in tui_show_source_line".  This reverts changes made in
  49         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
  50
  51 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  52
  53         * NEWS: Combine separate "New targets" sections for 8.3.
  54
  55 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
  56
  57         The MS-Windows port of ncurses fails to switch to a color pair if
  58         one or both of the colors are the implicit default colors.  This
  59         change records the default colors when TUI is initialized, and
  60         then specifies them explicitly when a color pair uses the default
  61         colors.  This allows color styling in TUI mode on MS-Windows.
  62
  63         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
  64         ncurses_norm_attr.
  65         (tui_initialize_io) [__MINGW32__]: Record the default terminal
  66         colors in ncurses_norm_attr.
  67         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
  68         "none", replace it with the default color recorded in
  69         ncurses_norm_attr.
  70
  71 2019-03-14  Tom Tromey  <tromey@adacore.com>
  72
  73         * source-cache.h (class source_cache) <get_source_lines>: Return
  74         std::string.
  75         * source-cache.c (source_cache::extract_lines): Handle case where
  76         first_pos==npos.  Return std::string.
  77         (source_cache::get_source_lines): Update.
  78
  79 2019-03-14  Tom Tromey  <tromey@adacore.com>
  80
  81         * NEWS: Add item for "style sources" commands.
  82         * source-cache.c (source_cache::get_source_lines): Check
  83         source_styling.
  84         * cli/cli-style.c (source_styling): New global.
  85         (_initialize_cli_style): Add "style sources" commands.
  86         (show_style_sources): New function.
  87         * cli/cli-style.h (source_styling): Declare.
  88
  89 2019-03-14  Pedro Alves  <palves@redhat.com>
  90             Tom Tromey  <tromey@adacore.com>
  91
  92         * tui/tui-winsource.h (tui_refill_source_window): Declare.
  93         * tui/tui-winsource.c (tui_refill_source_window): New function,
  94         from...
  95         (tui_horizontal_source_scroll): ... here.  Move some logic.
  96         * cli/cli-style.c (set_style_enabled): Notify new observable.
  97         * tui/tui-hooks.c (tui_redisplay_source): New function.
  98         (tui_attach_detach_observers): Attach or detach
  99         tui_redisplay_source.
 100         * observable.h (source_styling_changed): New observable.
 101         * observable.c: Define source_styling_changed observable.
 102
 103 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 104
 105         PR/24325
 106         * source-cache.c: #undef open and close, to avoid unresolved
 107         externals during linking.
 108
 109 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 110
 111         Support styling on native MS-Windows console
 112
 113         PR/24315
 114         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 115         on MS-Windows if $TERM is not defined.
 116
 117         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 118
 119         * posix-hdep.c (gdb_console_fputs):
 120         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 121         functions.
 122         * ui-file.h (gdb_console_fputs): Add prototype.
 123
 124         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 125         back to fputs only if the former returns zero.
 126
 127 2019-03-07  Brian Vandenberg  <phantall@gmail.com>
 128             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 129
 130         PR gdb/8527
 131         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
 132         set_sigint_trap, clear_sigint_trap.
 133
 134 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 135
 136         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
 137         for-loop range, to avoid compiler warnings.
 138
 139         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
 140         avoid compiler warnings about unused variables.
 141
 142 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 143
 144         * NEWS: Mention end of support for native debugging on MS-Windows
 145         before XP.
 146
 147 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 148
 149         PR gdb/24292
 150         * common/netstuff.c:
 151         * gdbserver/gdbreplay.c
 152         * gdbserver/remote-utils.c:
 153         * ser-tcp.c:
 154         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
 155         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
 156         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
 157         'getaddrinfo' and 'freeaddrinfo' were not available before
 158         Windows XP, and mingw.org's MinGW headers by default define
 159         _WIN32_WINNT to 0x500.
 160
 161 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 162
 163         * NEWS: Note minimum Python version.
 164
 165 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 166
 167         * version.in: Set GDB version number to 8.2.90.DATE-git.
 168
 169 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 170
 171         GDB 8.2.90 released.
 172
 173 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 174
 175         * version.in: Set GDB version number to 8.2.90.
 176
 177 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 178
 179         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
 180
 181 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 182
 183         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
 184         * version.in: Bump version to 8.2.90.DATE-git.
 185
 186 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
 187
 188         * aix-thread.c (ptid_cmp): Remove unused variable.
 189         (get_signaled_thread): Likewise.
 190         (store_regs_user_thread): Likewise.
 191         (store_regs_kernel_thread): Likewise.
 192         (fetch_regs_kernel_thread): Remove shadowed variable.
 193
 194 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 195
 196         * features/riscv/32bit-cpu.xml: Add register numbers.
 197         * features/riscv/32bit-fpu.c: Regenerate.
 198         * features/riscv/32bit-fpu.xml: Add register numbers.
 199         * features/riscv/64bit-cpu.xml: Add register numbers.
 200         * features/riscv/64bit-fpu.c: Regenerate.
 201         * features/riscv/64bit-fpu.xml: Add register numbers.
 202
 203 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
 204
 205         * NEWS: Mention two argument form of gdb.Value constructor.
 206         * python/py-value.c (convert_buffer_and_type_to_value): New
 207         function.
 208         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
 209         Add support for handling an optional second argument.  Call
 210         convert_buffer_and_type_to_value as appropriate.
 211         * python/python-internal.h (Py_buffer_deleter): New struct.
 212         (Py_buffer_up): New typedef.
 213
 214 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
 215
 216         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
 217         instead of releasing ownership.
 218
 219 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
 220
 221         * dwarf2read.c (open_and_init_dwp_file): Call
 222         elf_numsections instead of bfd_count_sections to initialize
 223         dwp_file->num_sections.
 224
 225 2019-02-25  Tom Tromey  <tromey@adacore.com>
 226
 227         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
 228
 229 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 230
 231         * gcore.in: Add '--readnever' option when invoking GDB.
 232
 233 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 234
 235         * MAINTAINERS: Update my email address.
 236
 237 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 238
 239         * build-id.c (build_id_to_debug_bfd_1): New function.
 240         (build_id_to_debug_bfd): Look for separate debug file in
 241         sysroot.
 242
 243 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 244
 245         * gdbarch.sh: Update the copyright year range that is placed into
 246         generated files.
 247
 248 2019-02-22  Keith Seitz  <keiths@redhat.com>
 249
 250         PR symtab/23853
 251         * linespec.c (create_sals_line_offset): Search for the default
 252         symtab's filename instead of its fullname.
 253
 254 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 255
 256         * NEWS: Update style defaults.
 257
 258 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 259
 260         * main.c (captured_main_1): Disable styling in batch mode.
 261
 262 2019-02-20  Tom Tromey  <tom@tromey.com>
 263
 264         * symtab.c (symtab_symbol_info): Fix typos.
 265
 266 2019-02-20  Tom Tromey  <tromey@adacore.com>
 267
 268         * findcmd.c (_initialize_mem_search): Use upper case for
 269         metasyntactic variables.
 270
 271 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
 272
 273         * aarch64-tdep.c (aarch64_add_reggroups): New function.
 274         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
 275
 276 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
 277
 278         * top.h (source_file_name): Change to std::string.
 279         * top.c (source_file_name): Likewise.
 280         (command_line_input): Adjust.
 281         * cli/cli-script.c (script_from_file): Adjust.
 282
 283 2019-02-19  Tom Tromey  <tromey@adacore.com>
 284
 285         * ravenscar-thread.c
 286         (ravenscar_thread_target::update_thread_list): Don't call
 287         ada_build_task_list.
 288         * ada-lang.h (ada_build_task_list): Don't declare.
 289         * ada-tasks.c (struct ada_tasks_inferior_data)
 290         <task_list_valid_p>: Now bool.
 291         (read_known_tasks, ada_task_list_changed)
 292         (ada_tasks_invalidate_inferior_data): Update.
 293         (read_known_tasks_array): Return bool.
 294         (read_known_tasks_list): Likewise.
 295         (read_known_tasks): Return void.
 296         (ada_build_task_list): Now static.
 297
 298 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 299
 300         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
 301         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
 302
 303 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 304
 305         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
 306         variant for ada_tasks_pspace_data_handle and
 307         ada_tasks_inferior_data_handle.
 308         (ada_tasks_pspace_data_cleanup): New function.
 309         (ada_tasks_inferior_data_cleanup): New function.
 310
 311 2019-02-17  Tom Tromey  <tom@tromey.com>
 312
 313         * macrotab.h (macro_source_fullname): Return a std::string.
 314         * macrotab.c (macro_include, check_for_redefinition)
 315         (macro_undef, macro_lookup_definition, foreach_macro)
 316         (foreach_macro_in_scope): Update.
 317         (macro_source_fullname): Return a std::string.
 318         * macrocmd.c (show_pp_source_pos): Update.
 319
 320 2019-02-17  Tom Tromey  <tom@tromey.com>
 321
 322         * macrocmd.c (show_pp_source_pos): Style the file names.
 323
 324 2019-02-17  Tom Tromey  <tom@tromey.com>
 325
 326         PR tui/24197:
 327         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 328
 329 2019-02-17  Tom Tromey  <tom@tromey.com>
 330
 331         * ada-lang.c (user_select_syms): Use filtered printing.
 332         * utils.c (wrap_style): New global.
 333         (desired_style): Remove.
 334         (emit_style_escape): Add stream parameter.
 335         (set_output_style, reset_terminal_style, prompt_for_continue):
 336         Update.
 337         (flush_wrap_buffer): Only flush gdb_stdout.
 338         (wrap_here): Set wrap_style.
 339         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 340         treat escape sequences as a character.  Change when wrap buffer is
 341         flushed.
 342         (fputs_styled): Do not set the output style when the default is
 343         requested.
 344         * ui-style.h (struct ui_file_style) <is_default>: New method.
 345         * source.c (print_source_lines_base): Emit escape sequences in one
 346         piece.
 347
 348 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 349
 350         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 351         integers and enumeration types.
 352
 353 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 354
 355         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 356         instead of lookup_symbol_in_language
 357         (do_exact_match): New function.
 358         (ada_get_symbol_name_matcher): Return do_exact_match when
 359         doing a verbatim match.
 360
 361 2019-02-15  Tom Tromey  <tromey@adacore.com>
 362
 363         * ravenscar-thread.c (ravenscar_thread_target::resume)
 364         (ravenscar_thread_target::wait): Special case wildcard requests.
 365
 366 2019-02-15  Tom Tromey  <tromey@adacore.com>
 367
 368         * ravenscar-thread.c (base_ptid): Remove.
 369         (struct ravenscar_thread_target) <close>: New method.
 370         <m_base_ptid>: New member.
 371         <update_inferior_ptid, active_task, task_is_currently_active,
 372         runtime_initialized>: Declare methods.
 373         <ravenscar_thread_target>: Add constructor.
 374         (ravenscar_thread_target::task_is_currently_active)
 375         (ravenscar_thread_target::update_inferior_ptid)
 376         (ravenscar_runtime_initialized): Rename.  Now methods.
 377         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 378         (ravenscar_thread_target::update_thread_list): Update.
 379         (ravenscar_thread_target::active_task): Now method.
 380         (ravenscar_thread_target::store_registers)
 381         (ravenscar_thread_target::prepare_to_store)
 382         (ravenscar_thread_target::prepare_to_store)
 383         (ravenscar_thread_target::mourn_inferior): Update.
 384         (ravenscar_inferior_created): Use "new" to create target.
 385         (ravenscar_thread_target::get_ada_task_ptid): Update.
 386         (_initialize_ravenscar): Don't initialize base_ptid.
 387         (ravenscar_ops): Remove global.
 388
 389 2019-02-15  Tom Tromey  <tromey@adacore.com>
 390
 391         * target.h (push_target): Declare new overload.
 392         * target.c (push_target): New overload, taking an rvalue reference.
 393         * remote.c (remote_target::open_1): Use push_target overload.
 394         * corelow.c (core_target_open): Use push_target overload.
 395
 396 2019-02-15  Tom Tromey  <tromey@adacore.com>
 397
 398         * ravenscar-thread.c (is_ravenscar_task)
 399         (ravenscar_task_is_currently_active): Return bool.
 400         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 401         (_initialize_ravenscar): Remove "(void)".
 402         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 403         Return bool.
 404
 405 2019-02-15  Tom Tromey  <tromey@adacore.com>
 406
 407         * ravenscar-thread.c (ravenscar_runtime_initializer)
 408         (has_ravenscar_runtime, get_running_thread_id)
 409         (ravenscar_thread_target::resume): Fix indentation.
 410
 411 2019-02-15  Tom Tromey  <tromey@adacore.com>
 412
 413         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 414         from ravenscar_arch_ops.
 415         (sparc_ravenscar_ops::fetch_registers)
 416         (sparc_ravenscar_ops::store_registers): Now methods.
 417         (sparc_ravenscar_prepare_to_store): Remove.
 418         (sparc_ravenscar_ops): Redefine.
 419         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 420         methods and destructor.  Remove members.
 421         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 422         (ravenscar_thread_target::store_registers)
 423         (ravenscar_thread_target::prepare_to_store): Update.
 424         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 425         Remove.
 426         (struct ppc_ravenscar_powerpc_ops): Derive from
 427         ravenscar_arch_ops.
 428         (ppc_ravenscar_powerpc_ops::fetch_registers)
 429         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 430         (ppc_ravenscar_powerpc_ops): Redefine.
 431         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 432         (ppc_ravenscar_e500_ops::fetch_registers)
 433         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 434         (ppc_ravenscar_e500_ops): Redefine.
 435         * aarch64-ravenscar-thread.c
 436         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 437         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 438         (aarch64_ravenscar_fetch_registers)
 439         (aarch64_ravenscar_store_registers): Now methods.
 440         (aarch64_ravenscar_ops): Redefine.
 441
 442 2019-02-15  Tom Tromey  <tromey@adacore.com>
 443
 444         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 445         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 446         (ravenscar_thread_target::stopped_by_watchpoint)
 447         (ravenscar_thread_target::stopped_data_address)
 448         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 449
 450 2019-02-15  Tom Tromey  <tromey@adacore.com>
 451
 452         * ravenscar-thread.c: Fix some typos.
 453
 454 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 455             Tom Tromey  <tromey@adacore.com>
 456
 457         * ada-lang.c (ada_exception_sal): Change addr_string to a
 458         std::string.
 459         (create_ada_exception_catchpoint): Update.
 460
 461 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 462             Tom Tromey  <tromey@adacore.com>
 463
 464         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 465         (bp_location_ops): Remove.
 466         (base_breakpoint_allocate_location): Update.
 467         (free_bp_location): Update.
 468         * ada-lang.c (class ada_catchpoint_location)
 469         <ada_catchpoint_location>: Remove ops parameter.
 470         (ada_catchpoint_location_dtor): Remove.
 471         (ada_catchpoint_location_ops): Remove.
 472         (allocate_location_exception): Update.
 473         * breakpoint.h (struct bp_location_ops): Remove.
 474         (class bp_location) <bp_location>: Remove bp_location_ops
 475         parameter.
 476         <~bp_location>: Add destructor.
 477         <ops>: Remove.
 478
 479 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 480             Pedro Alves  <palves@redhat.com>
 481
 482         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 483         'PATH_MAX'.
 484
 485 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 486             Samuel Thibault  <samuel.thibault@gnu.org>
 487             Thomas Schwinge  <thomas@codesourcery.com>
 488
 489         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 490         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 491
 492 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 493
 494         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 495         (check_empty): Use "const char *".
 496
 497         * gnu-nat.c (gnu_nat_target::detach): Instead of
 498         'detach_inferior (pid)' call
 499         'detach_inferior (find_inferior_pid (pid))'.
 500
 501         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 502         'nat/fork-inferior.o'.
 503         * gnu-nat.c: #include "nat/fork-inferior.h".
 504
 505         * gnu-nat.c (gnu_nat_target::detach): Instead of
 506         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 507         * gnu-nat.h: #include "inf-child.h".
 508         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 509         'i386_gnu_nat_target::fetch_registers'.
 510         (gnu_store_registers): Rename/move to
 511         'i386_gnu_nat_target::store_registers'.
 512
 513         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 514         * gnu-nat.h (mach_thread_info): New function.
 515         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 516
 517         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 518
 519 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 520
 521         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 522
 523 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 524
 525         * windows-nat.c (windows_add_thread): Add new parameter
 526         "main_thread_p" with default value set to false.  Update
 527         function documentation as well as all callers.
 528         (windows_delete_thread): Likewise.
 529         (fake_create_process): Update call to windows_add_thread.
 530         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 531         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 532         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 533         call to windows_delete_thread.
 534
 535 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 536
 537         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 538
 539 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 540
 541         * symfile.c (find_separate_debug_file): Use canonical path of
 542         sysroot with child_path instead of gdb_sysroot if it is valid.
 543
 544 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 545
 546         * symfile.c (find_separate_debug_file): Use child_path to
 547         determine if an object file is under a sysroot.
 548
 549 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 550
 551         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 552         unittests/child-path-selftests.c.
 553         * common/pathstuff.c (child_path): New function.
 554         * common/pathstuff.h (child_path): New prototype.
 555         * unittests/child-path-selftests.c: New file.
 556
 557 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 558
 559         * symfile.c (find_separate_debug_file): Look for separate debug
 560         files in debug directories under the sysroot.
 561
 562 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 563
 564         * symtab.h (struct minimal_symbol data_p): New const method.
 565         (struct minimal_symbol text_p): Likewise.
 566         * symtab.c (output_source_filename): Use file name style
 567         to print file name.
 568         (print_symbol_info): Likewise.
 569         (print_msymbol_info): Use address style to print addresses.
 570         Use function name style to print executable text symbols.
 571         (expand_symtab_containing_pc): Use data_p.
 572         (find_pc_sect_compunit_symtab): Likewise.
 573
 574 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 575
 576         * breakpoint.c (describe_other_breakpoints): Use address style
 577         to print addresses.
 578         (say_where): Likewise.
 579
 580 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 581
 582         * ada-typeprint.c (print_func_type): Print function name
 583         style to print function name.
 584         * c-typeprint.c (c_print_type_1): Likewise.
 585
 586 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 587
 588         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 589         for execve.
 590
 591 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 592
 593         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 594         type_stack.
 595
 596 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 597
 598         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 599         TYPE_CODE_REF types.
 600
 601 2019-02-08  Jim Wilson  <jimw@sifive.com>
 602
 603         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 604         (riscv_linux_fregset): New.
 605         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 606
 607 2019-02-07  Tom Tromey  <tom@tromey.com>
 608
 609         * thread.c (thread_cancel_execution_command): Update.
 610         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 611         methods.
 612         (struct thread_fsm_ops): Remove.
 613         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 614         (thread_fsm_should_stop, thread_fsm_return_value)
 615         (thread_fsm_set_finished, thread_fsm_finished_p)
 616         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 617         Don't declare.
 618         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 619         * infrun.c (clear_proceed_status_thread)
 620         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 621         (print_stop_event): Update.
 622         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 623         Add constructor.
 624         (step_command_fsm_ops): Remove.
 625         (new_step_command_fsm): Remove.
 626         (step_1): Update.
 627         (step_command_fsm::should_stop): Rename from
 628         step_command_fsm_should_stop.
 629         (step_command_fsm::clean_up): Rename from
 630         step_command_fsm_clean_up.
 631         (step_command_fsm::do_async_reply_reason): Rename from
 632         step_command_fsm_async_reply_reason.
 633         (struct until_next_fsm): Inherit from thread_fsm.  Add
 634         constructor.
 635         (until_next_fsm_ops): Remove.
 636         (new_until_next_fsm): Remove.
 637         (until_next_fsm::should_stop): Rename from
 638         until_next_fsm_should_stop.
 639         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 640         (until_next_fsm::do_async_reply_reason): Rename from
 641         until_next_fsm_async_reply_reason.
 642         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 643         constructor.  Change type of breakpoint.
 644         (finish_command_fsm_ops): Remove.
 645         (new_finish_command_fsm): Remove.
 646         (finish_command_fsm::should_stop): Rename from
 647         finish_command_fsm_should_stop.
 648         (finish_command_fsm::clean_up): Rename from
 649         finish_command_fsm_clean_up.
 650         (finish_command_fsm::return_value): Rename from
 651         finish_command_fsm_return_value.
 652         (finish_command_fsm::do_async_reply_reason): Rename from
 653         finish_command_fsm_async_reply_reason.
 654         (finish_command): Update.
 655         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 656         Add constructor.
 657         (call_thread_fsm_ops): Remove.
 658         (call_thread_fsm::call_thread_fsm): Rename from
 659         new_call_thread_fsm.
 660         (call_thread_fsm::should_stop): Rename from
 661         call_thread_fsm_should_stop.
 662         (call_thread_fsm::should_notify_stop): Rename from
 663         call_thread_fsm_should_notify_stop.
 664         (run_inferior_call, call_function_by_hand_dummy): Update.
 665         * cli/cli-interp.c (should_print_stop_to_console): Update.
 666         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 667         Add constructor.  Change type of location_breakpoint,
 668         caller_breakpoint.
 669         (until_break_fsm_ops): Remove.
 670         (new_until_break_fsm): Remove.
 671         (until_break_fsm::should_stop): Rename from
 672         until_break_fsm_should_stop.
 673         (until_break_fsm::clean_up): Rename from
 674         until_break_fsm_clean_up.
 675         (until_break_fsm::do_async_reply_reason): Rename from
 676         until_break_fsm_async_reply_reason.
 677         (until_break_command): Update.
 678         * thread-fsm.c: Remove.
 679         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 680
 681 2019-02-07  Tom Tromey  <tom@tromey.com>
 682
 683         * yy-remap.h: Add include guard.
 684         * xtensa-tdep.h: Add include guard.
 685         * xcoffread.h: Rename include guard.
 686         * varobj-iter.h: Add include guard.
 687         * tui/tui.h: Rename include guard.
 688         * tui/tui-winsource.h: Rename include guard.
 689         * tui/tui-wingeneral.h: Rename include guard.
 690         * tui/tui-windata.h: Rename include guard.
 691         * tui/tui-win.h: Rename include guard.
 692         * tui/tui-stack.h: Rename include guard.
 693         * tui/tui-source.h: Rename include guard.
 694         * tui/tui-regs.h: Rename include guard.
 695         * tui/tui-out.h: Rename include guard.
 696         * tui/tui-layout.h: Rename include guard.
 697         * tui/tui-io.h: Rename include guard.
 698         * tui/tui-hooks.h: Rename include guard.
 699         * tui/tui-file.h: Rename include guard.
 700         * tui/tui-disasm.h: Rename include guard.
 701         * tui/tui-data.h: Rename include guard.
 702         * tui/tui-command.h: Rename include guard.
 703         * tic6x-tdep.h: Add include guard.
 704         * target/waitstatus.h: Rename include guard.
 705         * target/wait.h: Rename include guard.
 706         * target/target.h: Rename include guard.
 707         * target/resume.h: Rename include guard.
 708         * target-float.h: Rename include guard.
 709         * stabsread.h: Add include guard.
 710         * rs6000-tdep.h: Add include guard.
 711         * riscv-fbsd-tdep.h: Add include guard.
 712         * regformats/regdef.h: Rename include guard.
 713         * record.h: Rename include guard.
 714         * python/python.h: Rename include guard.
 715         * python/python-internal.h: Rename include guard.
 716         * python/py-stopevent.h: Rename include guard.
 717         * python/py-ref.h: Rename include guard.
 718         * python/py-record.h: Rename include guard.
 719         * python/py-record-full.h: Rename include guard.
 720         * python/py-record-btrace.h: Rename include guard.
 721         * python/py-instruction.h: Rename include guard.
 722         * python/py-events.h: Rename include guard.
 723         * python/py-event.h: Rename include guard.
 724         * procfs.h: Add include guard.
 725         * proc-utils.h: Add include guard.
 726         * p-lang.h: Add include guard.
 727         * or1k-tdep.h: Rename include guard.
 728         * observable.h: Rename include guard.
 729         * nto-tdep.h: Rename include guard.
 730         * nat/x86-linux.h: Rename include guard.
 731         * nat/x86-linux-dregs.h: Rename include guard.
 732         * nat/x86-gcc-cpuid.h: Add include guard.
 733         * nat/x86-dregs.h: Rename include guard.
 734         * nat/x86-cpuid.h: Rename include guard.
 735         * nat/ppc-linux.h: Rename include guard.
 736         * nat/mips-linux-watch.h: Rename include guard.
 737         * nat/linux-waitpid.h: Rename include guard.
 738         * nat/linux-ptrace.h: Rename include guard.
 739         * nat/linux-procfs.h: Rename include guard.
 740         * nat/linux-osdata.h: Rename include guard.
 741         * nat/linux-nat.h: Rename include guard.
 742         * nat/linux-namespaces.h: Rename include guard.
 743         * nat/linux-btrace.h: Rename include guard.
 744         * nat/glibc_thread_db.h: Rename include guard.
 745         * nat/gdb_thread_db.h: Rename include guard.
 746         * nat/gdb_ptrace.h: Rename include guard.
 747         * nat/fork-inferior.h: Rename include guard.
 748         * nat/amd64-linux-siginfo.h: Rename include guard.
 749         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 750         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 751         * nat/aarch64-linux.h: Rename include guard.
 752         * nat/aarch64-linux-hw-point.h: Rename include guard.
 753         * mn10300-tdep.h: Add include guard.
 754         * mips-linux-tdep.h: Add include guard.
 755         * mi/mi-parse.h: Rename include guard.
 756         * mi/mi-out.h: Rename include guard.
 757         * mi/mi-main.h: Rename include guard.
 758         * mi/mi-interp.h: Rename include guard.
 759         * mi/mi-getopt.h: Rename include guard.
 760         * mi/mi-console.h: Rename include guard.
 761         * mi/mi-common.h: Rename include guard.
 762         * mi/mi-cmds.h: Rename include guard.
 763         * mi/mi-cmd-break.h: Rename include guard.
 764         * m2-lang.h: Add include guard.
 765         * location.h: Rename include guard.
 766         * linux-record.h: Rename include guard.
 767         * linux-nat.h: Add include guard.
 768         * linux-fork.h: Add include guard.
 769         * i386-darwin-tdep.h: Rename include guard.
 770         * hppa-linux-offsets.h: Add include guard.
 771         * guile/guile.h: Rename include guard.
 772         * guile/guile-internal.h: Rename include guard.
 773         * gnu-nat.h: Rename include guard.
 774         * gdb-stabs.h: Rename include guard.
 775         * frv-tdep.h: Add include guard.
 776         * f-lang.h: Add include guard.
 777         * event-loop.h: Add include guard.
 778         * darwin-nat.h: Rename include guard.
 779         * cp-abi.h: Rename include guard.
 780         * config/sparc/nm-sol2.h: Rename include guard.
 781         * config/nm-nto.h: Rename include guard.
 782         * config/nm-linux.h: Add include guard.
 783         * config/i386/nm-i386gnu.h: Rename include guard.
 784         * config/djgpp/nl_types.h: Rename include guard.
 785         * config/djgpp/langinfo.h: Rename include guard.
 786         * compile/gcc-cp-plugin.h: Add include guard.
 787         * compile/gcc-c-plugin.h: Add include guard.
 788         * compile/compile.h: Rename include guard.
 789         * compile/compile-object-run.h: Rename include guard.
 790         * compile/compile-object-load.h: Rename include guard.
 791         * compile/compile-internal.h: Rename include guard.
 792         * compile/compile-cplus.h: Rename include guard.
 793         * compile/compile-c.h: Rename include guard.
 794         * common/xml-utils.h: Rename include guard.
 795         * common/x86-xstate.h: Rename include guard.
 796         * common/version.h: Rename include guard.
 797         * common/vec.h: Rename include guard.
 798         * common/tdesc.h: Rename include guard.
 799         * common/selftest.h: Rename include guard.
 800         * common/scoped_restore.h: Rename include guard.
 801         * common/scoped_mmap.h: Rename include guard.
 802         * common/scoped_fd.h: Rename include guard.
 803         * common/safe-iterator.h: Rename include guard.
 804         * common/run-time-clock.h: Rename include guard.
 805         * common/refcounted-object.h: Rename include guard.
 806         * common/queue.h: Rename include guard.
 807         * common/ptid.h: Rename include guard.
 808         * common/print-utils.h: Rename include guard.
 809         * common/preprocessor.h: Rename include guard.
 810         * common/pathstuff.h: Rename include guard.
 811         * common/observable.h: Rename include guard.
 812         * common/netstuff.h: Rename include guard.
 813         * common/job-control.h: Rename include guard.
 814         * common/host-defs.h: Rename include guard.
 815         * common/gdb_wait.h: Rename include guard.
 816         * common/gdb_vecs.h: Rename include guard.
 817         * common/gdb_unlinker.h: Rename include guard.
 818         * common/gdb_unique_ptr.h: Rename include guard.
 819         * common/gdb_tilde_expand.h: Rename include guard.
 820         * common/gdb_sys_time.h: Rename include guard.
 821         * common/gdb_string_view.h: Rename include guard.
 822         * common/gdb_splay_tree.h: Rename include guard.
 823         * common/gdb_setjmp.h: Rename include guard.
 824         * common/gdb_ref_ptr.h: Rename include guard.
 825         * common/gdb_optional.h: Rename include guard.
 826         * common/gdb_locale.h: Rename include guard.
 827         * common/gdb_assert.h: Rename include guard.
 828         * common/filtered-iterator.h: Rename include guard.
 829         * common/filestuff.h: Rename include guard.
 830         * common/fileio.h: Rename include guard.
 831         * common/environ.h: Rename include guard.
 832         * common/common-utils.h: Rename include guard.
 833         * common/common-types.h: Rename include guard.
 834         * common/common-regcache.h: Rename include guard.
 835         * common/common-inferior.h: Rename include guard.
 836         * common/common-gdbthread.h: Rename include guard.
 837         * common/common-exceptions.h: Rename include guard.
 838         * common/common-defs.h: Rename include guard.
 839         * common/common-debug.h: Rename include guard.
 840         * common/cleanups.h: Rename include guard.
 841         * common/buffer.h: Rename include guard.
 842         * common/btrace-common.h: Rename include guard.
 843         * common/break-common.h: Rename include guard.
 844         * cli/cli-utils.h: Rename include guard.
 845         * cli/cli-style.h: Rename include guard.
 846         * cli/cli-setshow.h: Rename include guard.
 847         * cli/cli-script.h: Rename include guard.
 848         * cli/cli-interp.h: Rename include guard.
 849         * cli/cli-decode.h: Rename include guard.
 850         * cli/cli-cmds.h: Rename include guard.
 851         * charset-list.h: Add include guard.
 852         * buildsym-legacy.h: Rename include guard.
 853         * bfin-tdep.h: Add include guard.
 854         * ax.h: Rename include guard.
 855         * arm-linux-tdep.h: Add include guard.
 856         * arm-fbsd-tdep.h: Add include guard.
 857         * arch/xtensa.h: Rename include guard.
 858         * arch/tic6x.h: Add include guard.
 859         * arch/i386.h: Add include guard.
 860         * arch/arm.h: Rename include guard.
 861         * arch/arm-linux.h: Rename include guard.
 862         * arch/arm-get-next-pcs.h: Rename include guard.
 863         * arch/amd64.h: Add include guard.
 864         * arch/aarch64-insn.h: Rename include guard.
 865         * arch-utils.h: Rename include guard.
 866         * annotate.h: Add include guard.
 867         * amd64-darwin-tdep.h: Rename include guard.
 868         * aarch64-linux-tdep.h: Add include guard.
 869         * aarch64-fbsd-tdep.h: Add include guard.
 870         * aarch32-linux-nat.h: Add include guard.
 871
 872 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 873
 874         * macrotab.c (macro_define_internal): New function that
 875         factorizes macro_define_object_internal and macro_define_function
 876         code.
 877         (macro_define_object_internal): Use macro_define_internal.
 878         (macro_define_function): Likewise.
 879
 880 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 881
 882         * macrocmd.c (extract_identifier): Return
 883         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 884         callers.
 885
 886 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 887
 888         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 889
 890 2019-02-05  Tom Tromey  <tom@tromey.com>
 891
 892         * target.c (target_stack::unpush): Move assertion earlier.
 893
 894 2019-01-30  Tom Tromey  <tom@tromey.com>
 895
 896         PR python/23615:
 897         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 898         (gdbpy_parse_and_eval): Likewise.
 899         * python/python-internal.h (gdbpy_allow_threads): New class.
 900
 901 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 902
 903         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 904         (aarch64_fbsd_fpregmap): Move earlier.
 905         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 906         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 907         instead of individual calls to trad_frame_set_reg_addr.
 908         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 909         earlier.
 910         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 911         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 912         instead of individual calls to trad_frame_set_reg_addr.
 913
 914 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 915
 916         * CONTRIBUTE: Replace contribution list with wiki link.
 917
 918 2019-01-25  Tom Tromey  <tom@tromey.com>
 919
 920         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 921
 922 2019-01-25  Tom Tromey  <tom@tromey.com>
 923
 924         * xtensa-linux-nat.c: Fix common/ includes.
 925         * xml-support.h: Fix common/ includes.
 926         * xml-support.c: Fix common/ includes.
 927         * x86-linux-nat.c: Fix common/ includes.
 928         * windows-nat.c: Fix common/ includes.
 929         * varobj.h: Fix common/ includes.
 930         * varobj.c: Fix common/ includes.
 931         * value.c: Fix common/ includes.
 932         * valops.c: Fix common/ includes.
 933         * utils.c: Fix common/ includes.
 934         * unittests/xml-utils-selftests.c: Fix common/ includes.
 935         * unittests/utils-selftests.c: Fix common/ includes.
 936         * unittests/unpack-selftests.c: Fix common/ includes.
 937         * unittests/tracepoint-selftests.c: Fix common/ includes.
 938         * unittests/style-selftests.c: Fix common/ includes.
 939         * unittests/string_view-selftests.c: Fix common/ includes.
 940         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 941         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 942         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 943         * unittests/rsp-low-selftests.c: Fix common/ includes.
 944         * unittests/parse-connection-spec-selftests.c: Fix common/
 945         includes.
 946         * unittests/optional-selftests.c: Fix common/ includes.
 947         * unittests/offset-type-selftests.c: Fix common/ includes.
 948         * unittests/observable-selftests.c: Fix common/ includes.
 949         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 950         * unittests/memrange-selftests.c: Fix common/ includes.
 951         * unittests/memory-map-selftests.c: Fix common/ includes.
 952         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 953         * unittests/function-view-selftests.c: Fix common/ includes.
 954         * unittests/environ-selftests.c: Fix common/ includes.
 955         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 956         * unittests/common-utils-selftests.c: Fix common/ includes.
 957         * unittests/cli-utils-selftests.c: Fix common/ includes.
 958         * unittests/array-view-selftests.c: Fix common/ includes.
 959         * ui-file.c: Fix common/ includes.
 960         * tui/tui-io.c: Fix common/ includes.
 961         * tracepoint.h: Fix common/ includes.
 962         * tracepoint.c: Fix common/ includes.
 963         * tracefile-tfile.c: Fix common/ includes.
 964         * top.h: Fix common/ includes.
 965         * top.c: Fix common/ includes.
 966         * thread.c: Fix common/ includes.
 967         * target/waitstatus.h: Fix common/ includes.
 968         * target/waitstatus.c: Fix common/ includes.
 969         * target.h: Fix common/ includes.
 970         * target.c: Fix common/ includes.
 971         * target-memory.c: Fix common/ includes.
 972         * target-descriptions.c: Fix common/ includes.
 973         * symtab.h: Fix common/ includes.
 974         * symfile.c: Fix common/ includes.
 975         * stap-probe.c: Fix common/ includes.
 976         * spu-linux-nat.c: Fix common/ includes.
 977         * sparc-nat.c: Fix common/ includes.
 978         * source.c: Fix common/ includes.
 979         * solib.c: Fix common/ includes.
 980         * solib-target.c: Fix common/ includes.
 981         * ser-unix.c: Fix common/ includes.
 982         * ser-tcp.c: Fix common/ includes.
 983         * ser-pipe.c: Fix common/ includes.
 984         * ser-base.c: Fix common/ includes.
 985         * selftest-arch.c: Fix common/ includes.
 986         * s12z-tdep.c: Fix common/ includes.
 987         * rust-exp.y: Fix common/ includes.
 988         * rs6000-aix-tdep.c: Fix common/ includes.
 989         * riscv-tdep.c: Fix common/ includes.
 990         * remote.c: Fix common/ includes.
 991         * remote-notif.h: Fix common/ includes.
 992         * remote-fileio.h: Fix common/ includes.
 993         * remote-fileio.c: Fix common/ includes.
 994         * regcache.h: Fix common/ includes.
 995         * regcache.c: Fix common/ includes.
 996         * record-btrace.c: Fix common/ includes.
 997         * python/python.c: Fix common/ includes.
 998         * python/py-type.c: Fix common/ includes.
 999         * python/py-inferior.c: Fix common/ includes.
1000         * progspace.h: Fix common/ includes.
1001         * producer.c: Fix common/ includes.
1002         * procfs.c: Fix common/ includes.
1003         * proc-api.c: Fix common/ includes.
1004         * printcmd.c: Fix common/ includes.
1005         * ppc-linux-nat.c: Fix common/ includes.
1006         * parser-defs.h: Fix common/ includes.
1007         * osdata.c: Fix common/ includes.
1008         * obsd-nat.c: Fix common/ includes.
1009         * nat/x86-linux.c: Fix common/ includes.
1010         * nat/x86-linux-dregs.c: Fix common/ includes.
1011         * nat/x86-dregs.h: Fix common/ includes.
1012         * nat/x86-dregs.c: Fix common/ includes.
1013         * nat/ppc-linux.c: Fix common/ includes.
1014         * nat/mips-linux-watch.h: Fix common/ includes.
1015         * nat/mips-linux-watch.c: Fix common/ includes.
1016         * nat/linux-waitpid.c: Fix common/ includes.
1017         * nat/linux-ptrace.h: Fix common/ includes.
1018         * nat/linux-ptrace.c: Fix common/ includes.
1019         * nat/linux-procfs.c: Fix common/ includes.
1020         * nat/linux-personality.c: Fix common/ includes.
1021         * nat/linux-osdata.c: Fix common/ includes.
1022         * nat/linux-namespaces.c: Fix common/ includes.
1023         * nat/linux-btrace.h: Fix common/ includes.
1024         * nat/linux-btrace.c: Fix common/ includes.
1025         * nat/fork-inferior.c: Fix common/ includes.
1026         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1027         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1028         * nat/aarch64-linux.c: Fix common/ includes.
1029         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1030         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1031         * namespace.h: Fix common/ includes.
1032         * mips-linux-tdep.c: Fix common/ includes.
1033         * minsyms.c: Fix common/ includes.
1034         * mi/mi-parse.h: Fix common/ includes.
1035         * mi/mi-main.c: Fix common/ includes.
1036         * mi/mi-cmd-env.c: Fix common/ includes.
1037         * memrange.h: Fix common/ includes.
1038         * memattr.c: Fix common/ includes.
1039         * maint.h: Fix common/ includes.
1040         * maint.c: Fix common/ includes.
1041         * main.c: Fix common/ includes.
1042         * machoread.c: Fix common/ includes.
1043         * location.c: Fix common/ includes.
1044         * linux-thread-db.c: Fix common/ includes.
1045         * linux-nat.c: Fix common/ includes.
1046         * linux-fork.c: Fix common/ includes.
1047         * inline-frame.c: Fix common/ includes.
1048         * infrun.c: Fix common/ includes.
1049         * inflow.c: Fix common/ includes.
1050         * inferior.h: Fix common/ includes.
1051         * inferior.c: Fix common/ includes.
1052         * infcmd.c: Fix common/ includes.
1053         * inf-ptrace.c: Fix common/ includes.
1054         * inf-child.c: Fix common/ includes.
1055         * ia64-linux-nat.c: Fix common/ includes.
1056         * i387-tdep.c: Fix common/ includes.
1057         * i386-tdep.c: Fix common/ includes.
1058         * i386-linux-tdep.c: Fix common/ includes.
1059         * i386-linux-nat.c: Fix common/ includes.
1060         * i386-go32-tdep.c: Fix common/ includes.
1061         * i386-fbsd-tdep.c: Fix common/ includes.
1062         * i386-fbsd-nat.c: Fix common/ includes.
1063         * guile/scm-type.c: Fix common/ includes.
1064         * guile/guile.c: Fix common/ includes.
1065         * go32-nat.c: Fix common/ includes.
1066         * gnu-nat.c: Fix common/ includes.
1067         * gdbthread.h: Fix common/ includes.
1068         * gdbarch-selftests.c: Fix common/ includes.
1069         * gdb_usleep.c: Fix common/ includes.
1070         * gdb_select.h: Fix common/ includes.
1071         * gdb_bfd.c: Fix common/ includes.
1072         * gcore.c: Fix common/ includes.
1073         * fork-child.c: Fix common/ includes.
1074         * findvar.c: Fix common/ includes.
1075         * fbsd-nat.c: Fix common/ includes.
1076         * event-top.c: Fix common/ includes.
1077         * event-loop.c: Fix common/ includes.
1078         * dwarf2read.c: Fix common/ includes.
1079         * dwarf2loc.c: Fix common/ includes.
1080         * dwarf2-frame.c: Fix common/ includes.
1081         * dwarf-index-cache.c: Fix common/ includes.
1082         * dtrace-probe.c: Fix common/ includes.
1083         * disasm-selftests.c: Fix common/ includes.
1084         * defs.h: Fix common/ includes.
1085         * csky-tdep.c: Fix common/ includes.
1086         * cp-valprint.c: Fix common/ includes.
1087         * cp-support.h: Fix common/ includes.
1088         * cp-support.c: Fix common/ includes.
1089         * corelow.c: Fix common/ includes.
1090         * completer.h: Fix common/ includes.
1091         * completer.c: Fix common/ includes.
1092         * compile/compile.c: Fix common/ includes.
1093         * compile/compile-loc2c.c: Fix common/ includes.
1094         * compile/compile-cplus-types.c: Fix common/ includes.
1095         * compile/compile-cplus-symbols.c: Fix common/ includes.
1096         * command.h: Fix common/ includes.
1097         * cli/cli-dump.c: Fix common/ includes.
1098         * cli/cli-cmds.c: Fix common/ includes.
1099         * charset.c: Fix common/ includes.
1100         * build-id.c: Fix common/ includes.
1101         * btrace.h: Fix common/ includes.
1102         * btrace.c: Fix common/ includes.
1103         * breakpoint.h: Fix common/ includes.
1104         * breakpoint.c: Fix common/ includes.
1105         * ax.h:
1106         (enum agent_op): Fix common/ includes.
1107         * ax-general.c (struct aop_map): Fix common/ includes.
1108         * ax-gdb.c: Fix common/ includes.
1109         * auxv.c: Fix common/ includes.
1110         * auto-load.c: Fix common/ includes.
1111         * arm-tdep.c: Fix common/ includes.
1112         * arch/riscv.c: Fix common/ includes.
1113         * arch/ppc-linux-common.c: Fix common/ includes.
1114         * arch/i386.c: Fix common/ includes.
1115         * arch/arm.c: Fix common/ includes.
1116         * arch/arm-linux.c: Fix common/ includes.
1117         * arch/arm-get-next-pcs.c: Fix common/ includes.
1118         * arch/amd64.c: Fix common/ includes.
1119         * arch/aarch64.c: Fix common/ includes.
1120         * arch/aarch64-insn.c: Fix common/ includes.
1121         * arch-utils.c: Fix common/ includes.
1122         * amd64-windows-tdep.c: Fix common/ includes.
1123         * amd64-tdep.c: Fix common/ includes.
1124         * amd64-sol2-tdep.c: Fix common/ includes.
1125         * amd64-obsd-tdep.c: Fix common/ includes.
1126         * amd64-nbsd-tdep.c: Fix common/ includes.
1127         * amd64-linux-tdep.c: Fix common/ includes.
1128         * amd64-linux-nat.c: Fix common/ includes.
1129         * amd64-fbsd-tdep.c: Fix common/ includes.
1130         * amd64-fbsd-nat.c: Fix common/ includes.
1131         * amd64-dicos-tdep.c: Fix common/ includes.
1132         * amd64-darwin-tdep.c: Fix common/ includes.
1133         * agent.c: Fix common/ includes.
1134         * ada-lang.h: Fix common/ includes.
1135         * ada-lang.c: Fix common/ includes.
1136         * aarch64-tdep.c: Fix common/ includes.
1137
1138 2019-01-25  Tom Tromey  <tom@tromey.com>
1139
1140         * common/create-version.sh: Use common/version.h.
1141
1142 2019-01-24  Pedro Alves  <palves@redhat.com>
1143
1144         * infrun.c (signal_stop, signal_print, signal_program)
1145         (signal_catch, signal_pass): Now arrays instead of pointers.
1146         (update_signals_program_target, do_target_resume)
1147         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1148         * linux-nat.c (linux_nat_target::pass_signals)
1149         (linux_nat_target::create_inferior, linux_nat_target::attach):
1150         Adjust.
1151         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1152         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1153         * procfs.c (procfs_target::pass_signals): Adjust.
1154         * record-full.c (record_full_target::resume): Adjust.
1155         * remote.c (remote_target::pass_signals)
1156         (remote_target::program_signals): Adjust.
1157         * target-debug.h (target_debug_print_signals): Now takes a
1158         gdb::array_view as parameter.  Adjust.
1159         * target.h (target_ops) <pass_signals, program_signals>: Replace
1160         pointer and length parameters with gdb::array_view.
1161         (target_pass_signals, target_program_signals): Likewise.
1162         * target-delegates.c: Regenerate.
1163
1164 2019-01-24  Pedro Alves  <palves@redhat.com>
1165
1166         * common/forward-scope-exit.h
1167         (forward_scope_exit::forward_scope_exit): Pass arguments to
1168         m_bind_function directly, instead of creating a std::bind and
1169         copying that.
1170
1171 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1172
1173         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1174         for static members.
1175         (pass_in_v_vfp_candidate): Likewise.
1176
1177 2019-01-23  Tom Tromey  <tom@tromey.com>
1178             Pedro Alves  <palves@redhat.com>
1179
1180         * regcache.c (class regcache_invalidator): Remove.
1181         (regcache::raw_write): Use make_scope_exit.
1182
1183 2019-01-23  Tom Tromey  <tom@tromey.com>
1184
1185         * ui-out.h (class ui_out_emit_type): Update comment.
1186
1187 2019-01-23  Tom Tromey  <tom@tromey.com>
1188
1189         * infrun.c (fetch_inferior_event): Update comment.
1190
1191 2019-01-23  Tom Tromey  <tom@tromey.com>
1192             Pedro Alves  <palves@redhat.com>
1193
1194         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1195         parameter.
1196         (fetch_inferior_event): Use SCOPE_EXIT.
1197
1198
1199 2019-01-23  Tom Tromey  <tom@tromey.com>
1200             Pedro Alves  <palves@redhat.com>
1201
1202         * infrun.c (disable_thread_events): Delete.
1203         (stop_all_threads): Use SCOPE_EXIT.
1204
1205 2019-01-23  Tom Tromey  <tom@tromey.com>
1206             Pedro Alves  <palves@redhat.com>
1207
1208         * symfile.c: Include forward-scope-exit.h.
1209         (clear_symtab_users_cleanup): Replace forward declaration with
1210         a FORWARD_SCOPE_EXIT.
1211         (syms_from_objfile_1): Use the forward_scope_exit and
1212         gdb::optional instead of cleanup_function.
1213         (reread_symbols): Use the forward_scope_exit instead of
1214         cleanup_function.
1215         (clear_symtab_users_cleanup): Remove function.
1216
1217 2019-01-23  Tom Tromey  <tom@tromey.com>
1218             Pedro Alves  <palves@redhat.com>
1219
1220         * linux-nat.c: Include scope-exit.h.
1221         (cleanup_target_stop): Remove.
1222         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1223         SCOPE_EXIT.
1224
1225 2019-01-23  Tom Tromey  <tom@tromey.com>
1226             Pedro Alves  <palves@redhat.com>
1227
1228         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1229         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1230
1231 2019-01-23  Tom Tromey  <tom@tromey.com>
1232             Andrew Burgess  <andrew.burgess@embecosm.com>
1233             Pedro Alves  <palves@redhat.com>
1234
1235         * infrun.c (fetch_inferior_event): Use scope_exit.
1236         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1237         * top.c (execute_command): Use scope_exit.
1238         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1239         * utils.c (do_bpstat_clear_actions_cleanup)
1240         (make_bpstat_clear_actions_cleanup): Remove.
1241
1242 2019-01-23  Tom Tromey  <tom@tromey.com>
1243             Pedro Alves  <palves@redhat.com>
1244
1245         * infrun.c: Include "common/scope-exit.h"
1246         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1247         (wait_for_inferior): Use SCOPE_EXIT.
1248         (fetch_inferior_event): Use scope_exit.
1249
1250 2019-01-23  Tom Tromey  <tom@tromey.com>
1251             Pedro Alves  <palves@redhat.com>
1252
1253         * breakpoint.c (create_breakpoint): Remove cleanup.
1254
1255 2019-01-23  Tom Tromey  <tom@tromey.com>
1256             Andrew Burgess  <andrew.burgess@embecosm.com>
1257             Pedro Alves  <palves@redhat.com>
1258
1259 2019-01-23  Pedro Alves  <palves@redhat.com>
1260
1261         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1262
1263 2019-01-23  Pedro Alves  <palves@redhat.com>
1264             Andrew Burgess  <andrew.burgess@embecosm.com>
1265
1266         * gdbthread.h: Include "common/forward-scope-exit.h".
1267         (scoped_finish_thread_state): Redefine custom class in terms of
1268         forward_scope_exit.
1269
1270 2019-01-23  Pedro Alves  <palves@redhat.com>
1271             Andrew Burgess  <andrew.burgess@embecosm.com>
1272
1273         * common/forward-scope-exit.h: New file.
1274
1275 2019-01-23  Pedro Alves  <palves@redhat.com>
1276             Andrew Burgess  <andrew.burgess@embecosm.com>
1277             Tom Tromey  <tom@tromey.com>
1278
1279         * common/scope-exit.h: New file.
1280
1281 2019-01-23  Pedro Alves  <palves@redhat.com>
1282
1283         * common/preprocessor.h (ESC): Rename to ...
1284         (ESC_PARENS): ... this.
1285         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1286         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1287
1288 2019-01-23  Tom Tromey  <tom@tromey.com>
1289
1290         * language.h (class scoped_switch_to_sym_language_if_auto):
1291         Initialize m_lang in both cases.
1292
1293 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1294
1295         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1296         with XCNEW.
1297
1298 2019-01-22  Tom Tromey  <tom@tromey.com>
1299
1300         * corelow.c: Do not include sys/file.h.
1301
1302 2019-01-22  Tom Tromey  <tom@tromey.com>
1303
1304         * tui/tui-wingeneral.h: Include gdb_curses.h.
1305
1306 2019-01-22  Tom Tromey  <tom@tromey.com>
1307
1308         * source-cache.h (class source_cache) <get_source_lines,
1309         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1310
1311 2019-01-22  Tom Tromey  <tom@tromey.com>
1312
1313         * remote-fileio.h (struct remote_target): Declare.
1314
1315 2019-01-22  Tom Tromey  <tom@tromey.com>
1316
1317         * python/py-arch.c: Do not include py-ref.h.
1318         * python/py-bpevent.c: Do not include py-ref.h.
1319         * python/py-cmd.c: Do not include py-ref.h.
1320         * python/py-continueevent.c: Do not include py-ref.h.
1321         * python/py-event.h: Do not include py-ref.h.
1322         * python/py-evtregistry.c: Do not include py-ref.h.
1323         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1324         * python/py-frame.c: Do not include py-ref.h.
1325         * python/py-framefilter.c: Do not include py-ref.h.
1326         * python/py-function.c: Do not include py-ref.h.
1327         * python/py-infevents.c: Do not include py-ref.h.
1328         * python/py-linetable.c: Do not include py-ref.h.
1329         * python/py-objfile.c: Do not include py-ref.h.
1330         * python/py-param.c: Do not include py-ref.h.
1331         * python/py-prettyprint.c: Do not include py-ref.h.
1332         * python/py-progspace.c: Do not include py-ref.h.
1333         * python/py-symbol.c: Do not include py-ref.h.
1334         * python/py-symtab.c: Do not include py-ref.h.
1335         * python/py-type.c: Do not include py-ref.h.
1336         * python/py-unwind.c: Do not include py-ref.h.
1337         * python/py-utils.c: Do not include py-ref.h.
1338         * python/py-value.c: Do not include py-ref.h.
1339         * python/py-varobj.c: Do not include py-ref.h.
1340         * python/py-xmethods.c: Do not include py-ref.h.
1341         * python/python.c: Do not include py-ref.h.
1342         * varobj.c: Do not include py-ref.h.
1343
1344 2019-01-22  Tom Tromey  <tom@tromey.com>
1345
1346         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1347         keyword for bcache.
1348
1349 2019-01-22  Tom Tromey  <tom@tromey.com>
1350
1351         * compile/compile-cplus-types.c: Remove a comment by #include.
1352
1353 2019-01-22  Tom Tromey  <tom@tromey.com>
1354
1355         * compile/gcc-c-plugin.h: Include compile-internal.h.
1356
1357 2019-01-22  Tom Tromey  <tom@tromey.com>
1358
1359         * stabsread.c (EXTERN): Do not define.
1360         (symnum, next_symbol_text_func, processing_gcc_compilation)
1361         (within_function, global_sym_chain, global_stabs)
1362         (previous_stab_code, this_object_header_files)
1363         (n_this_object_header_files)
1364         (n_allocated_this_object_header_files): Define.
1365         * stabsread.h (EXTERN): Never define.  Use "extern".
1366
1367 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1368
1369         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1370         history_value.
1371
1372 2019-01-21  Tom Tromey  <tom@tromey.com>
1373
1374         * ui-out.c: Fix includes.
1375         * tui/tui-source.c: Fix includes.
1376         * target.c: Fix includes.
1377         * remote.c: Fix includes.
1378         * regcache.c: Fix includes.
1379         * python/py-block.c: Fix includes.
1380         * printcmd.c: Fix includes.
1381         * or1k-tdep.c: Fix includes.
1382         * mi/mi-main.c: Fix includes.
1383         * m32r-tdep.c: Fix includes.
1384         * csky-tdep.c: Fix includes.
1385         * compile/compile-cplus-types.c: Fix includes.
1386         * cli/cli-interp.c: Fix includes.
1387
1388 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1389
1390         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1391         for padding.
1392
1393 2019-01-16  Tom Tromey  <tom@tromey.com>
1394
1395         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1396         earlier.
1397         (struct objfile) <msymbols_range>: Move from top level.
1398         <msymbols>: New method.
1399         (class objfile_msymbols): Remove.
1400         * symtab.c (default_collect_symbol_completion_matches_break_on):
1401         Update.
1402         * symmisc.c (dump_msymbols): Update.
1403         * stabsread.c (scan_file_globals): Update.
1404         * objc-lang.c (info_selectors_command, info_classes_command)
1405         (find_methods): Update.
1406         * minsyms.c (find_solib_trampoline_target): Update.
1407         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1408         * coffread.c (coff_symfile_read): Update.
1409         * ada-lang.c (ada_lookup_simple_minsym)
1410         (ada_collect_symbol_completion_matches): Update.
1411
1412 2019-01-16  Tom Tromey  <tom@tromey.com>
1413
1414         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1415         type.  Remove no-argument constructor.
1416         <iterator::operator++>: Simplify.
1417         <begin>: Update.
1418         <end>: Use minimal_symbol_count.
1419
1420 2019-01-16  Tom Tromey  <tom@tromey.com>
1421
1422         * objfiles.h (struct objfile) <psymtabs>: New method.
1423         (class objfile_psymtabs): Remove.
1424         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1425         typedef.
1426         <range>: New method.
1427         (require_partial_symbols): Change return type.
1428         * psymtab.c (require_partial_symbols)
1429         (psym_expand_symtabs_matching): Update.
1430         * mdebugread.c (parse_partial_symbols): Update.
1431         * dbxread.c (dbx_end_psymtab): Update.
1432
1433 2019-01-15  Tom Tromey  <tom@tromey.com>
1434
1435         * symtab.c (lookup_objfile_from_block)
1436         (lookup_symbol_in_objfile_symtabs)
1437         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1438         (find_line_symtab, info_sources_command)
1439         (default_collect_symbol_completion_matches_break_on)
1440         (make_source_files_completion_list): Update.
1441         * symmisc.c (print_objfile_statistics, dump_objfile)
1442         (maintenance_print_symbols, maintenance_info_symtabs)
1443         (maintenance_check_symtabs, maintenance_info_line_tables):
1444         Update.
1445         * source.c (select_source_symtab)
1446         (forget_cached_source_info_for_objfile): Update.
1447         * objfiles.h (class objfile_compunits): Remove.
1448         (struct objfile) <compunits_range>: New typedef.
1449         (compunits): New method.
1450         * objfiles.c (objfile_relocate1): Update.
1451         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1452         * maint.c (count_symtabs_and_blocks): Update.
1453         * linespec.c (iterate_over_all_matching_symtabs): Update.
1454         * cp-support.c (add_symbol_overload_list_qualified): Update.
1455         * coffread.c (coff_symtab_read): Update.
1456         * ada-lang.c (add_nonlocal_symbols)
1457         (ada_collect_symbol_completion_matches)
1458         (ada_add_global_exceptions): Update.
1459
1460 2019-01-15  Tom Tromey  <tom@tromey.com>
1461
1462         * progspace.h (program_space) <objfiles_safe_range>: New
1463         typedef.
1464         <objfiles_safe>: New method.
1465         * objfiles.h (class all_objfiles_safe): Remove.
1466         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1467         * jit.c (jit_inferior_exit_hook): Update.
1468
1469 2019-01-17  Tom Tromey  <tom@tromey.com>
1470
1471         * progspace.h (program_space) <objfiles_range>: New typedef.
1472         <objfiles>: New method.
1473         <objfiles_head>: Rename from objfiles.
1474         (object_files): Update.
1475         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1476         * guile/scm-pretty-print.c
1477         (ppscm_find_pretty_printer_from_objfiles): Update.
1478         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1479         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1480         Update.
1481         * python/py-progspace.c (pspy_get_objfiles): Update.
1482         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1483         Update.
1484         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1485         (objfpy_lookup_objfile_by_build_id): Update.
1486         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1487         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1488         Update.
1489         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1490         (expand_symtab_containing_pc, lookup_objfile_from_block)
1491         (lookup_static_symbol, basic_lookup_transparent_type)
1492         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1493         (find_line_symtab, info_sources_command)
1494         (default_collect_symbol_completion_matches_break_on)
1495         (make_source_files_completion_list, find_main_name): Update.
1496         * symmisc.c (print_symbol_bcache_statistics)
1497         (print_objfile_statistics, maintenance_print_symbols)
1498         (maintenance_print_msymbols, maintenance_print_objfiles)
1499         (maintenance_info_symtabs, maintenance_check_symtabs)
1500         (maintenance_expand_symtabs, maintenance_info_line_tables):
1501         Update.
1502         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1503         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1504         (map_overlay_command, unmap_overlay_command)
1505         (simple_overlay_update, expand_symtabs_matching)
1506         (map_symbol_filenames): Update.
1507         * symfile-debug.c (set_debug_symfile): Update.
1508         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1509         Update.
1510         * source.c (select_source_symtab, forget_cached_source_info):
1511         Update.
1512         * solib.c (solib_read_symbols): Update.
1513         * solib-spu.c (append_ocl_sos): Update.
1514         * psymtab.c (maintenance_print_psymbols)
1515         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1516         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1517         * printcmd.c (info_symbol_command): Update.
1518         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1519         Update.
1520         * objfiles.h (class all_objfiles): Remove.
1521         * objfiles.c (have_partial_symbols, have_full_symbols)
1522         (have_minimal_symbols, qsort_cmp, update_section_map)
1523         (shared_objfile_contains_address_p)
1524         (default_iterate_over_objfiles_in_search_order): Update.
1525         * objc-lang.c (info_selectors_command, info_classes_command)
1526         (find_methods): Update.
1527         * minsyms.c (find_solib_trampoline_target): Update.
1528         * maint.c (maintenance_info_sections)
1529         (maintenance_translate_address, count_symtabs_and_blocks):
1530         Update.
1531         * main.c (captured_main_1): Update.
1532         * linux-thread-db.c (try_thread_db_load_from_pdir)
1533         (has_libpthread): Update.
1534         * linespec.c (iterate_over_all_matching_symtabs)
1535         (search_minsyms_for_name): Update.
1536         * jit.c (jit_find_objf_with_entry_addr): Update.
1537         * hppa-tdep.c (find_unwind_entry)
1538         (hppa_lookup_stub_minimal_symbol): Update.
1539         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1540         Update.
1541         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1542         (elf_gnu_ifunc_resolve_by_got): Update.
1543         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1544         * dwarf-index-write.c (save_gdb_index_command): Update.
1545         * cp-support.c (add_symbol_overload_list_qualified): Update.
1546         * breakpoint.c (create_overlay_event_breakpoint)
1547         (create_longjmp_master_breakpoint)
1548         (create_std_terminate_master_breakpoint)
1549         (create_exception_master_breakpoint): Update.
1550         * blockframe.c (find_pc_partial_function): Update.
1551         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1552         (ada_collect_symbol_completion_matches)
1553         (ada_add_global_exceptions): Update.
1554
1555 2019-01-17  Tom Tromey  <tom@tromey.com>
1556
1557         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1558         declare VEC.
1559         (solib_target_parse_libraries): Change return type.
1560         (library_list_start_segment, library_list_start_section)
1561         (library_list_end_library, library_list_start_library); Update.
1562         (solib_target_free_library_list): Remove.
1563         (solib_target_parse_libraries): Remove cleanup.  Change return
1564         type.
1565         (solib_target_current_sos): Update.
1566
1567 2019-01-17  Tom Tromey  <tromey@bapiya>
1568
1569         * valprint.c: Replace "the the" with "the".
1570         * symtab.c: Replace "the the" with "the".
1571         * solib.c: Replace "the the" with "the".
1572         * solib-dsbt.c: Replace "the the" with "the".
1573         * linespec.c: Replace "the the" with "the".
1574         * dwarf2loc.h: Replace "the the" with "the".
1575         * amd64-windows-tdep.c: Replace "the the" with "the".
1576         * aarch64-tdep.c: Replace "the the" with "the".
1577
1578 2019-01-16  Keith Seitz  <keiths@redhat.com>
1579
1580         PR gdb/23773
1581         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1582         <builder>: Rename to ..
1583         <m_builder>: ... this and make private.
1584         (dwarf2_cu::get_builder): New method.  Change all users of
1585         `builder' to use this method.
1586         (dwarf2_start_symtab): Move to ...
1587         (dwarf2_cu::start_symtab): ... here.  Update all callers
1588         (setup_type_unit_groups): Move to ...
1589         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1590         callers.
1591         (dwarf2_cu::reset_builder): New method.
1592         (process_full_compunit, process_full_type_unit): Use
1593         dwarf2_cu::reset_builder.
1594         (follow_die_offset): Record the ancestor CU if it is different
1595         from the followed DIE's CU.
1596         (follow_die_sig_1): Likewise.
1597
1598 2019-01-15  Tom Tromey  <tom@tromey.com>
1599
1600         * remote.c (class remote_state) <buf>: Now a char_vector.
1601         <buf_size>: Remove.
1602         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1603         parameter.
1604         (remote_target::getpkt_or_notif_sane_1)
1605         (remote_target::getpkt_sane)
1606         (remote_target::getpkt_or_notif_sane): Likewise.
1607         (class remote_target) <putpkt>: New overload.
1608         (remote_target::read_frame): Change type of "buf_p".  Remove
1609         sizeof_p parameter.
1610         (packet_ok): New overload.
1611         (packet_check_result): New overload.
1612         Update all uses.
1613
1614 2019-01-14  Tom Tromey  <tom@tromey.com>
1615
1616         * remote-notif.c (handle_notification, remote_notif_ack)
1617         (remote_notif_parse): Make "buf" const.
1618         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1619         const.
1620         (remote_notif_parse, remote_notif_ack, handle_notification):
1621         Likewise.
1622         * remote.c (remote_notif_stop_parse): Make "buf" const.
1623         (remote_target::remote_parse_stop_reply): Make "buf" const.
1624         (remote_notif_stop_ack): Make "buf" const.
1625
1626 2019-01-14  Tom Tromey  <tom@tromey.com>
1627
1628         * remote.c (remote_console_output): Make parameter const.
1629
1630 2019-01-14  Tom Tromey  <tom@tromey.com>
1631
1632         * target-debug.h (target_debug_print_signals): Constify.
1633         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1634         * procfs.c (procfs_target::pass_signals): Update.
1635         * linux-nat.c (linux_nat_target::pass_signals): Update.
1636         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1637         * target-delegates.c: Rebuild.
1638         * remote.c (remote_target::program_signals): Update.
1639         (remote_target::pass_signals): Update.
1640         * target.c (target_pass_signals): Constify argument.
1641         (target_program_signals): Likewise.
1642         * target.h (struct target_ops) <pass_signals, program_signals>:
1643         Constify argument.
1644         (target_pass_signals, target_program_signals): Constify argument.
1645
1646 2019-01-14  Tom Tromey  <tom@tromey.com>
1647
1648         PR tui/28819:
1649         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1650
1651 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1652
1653         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1654         field.
1655         * rs6000-tdep.c: Include reggroups.h.
1656         (IS_V_ALIAS_PSEUDOREG): Define.
1657         (rs6000_register_name): Return names for the "vX" aliases.
1658         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1659         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1660         aliases.  Call default_register_reggroup_p for all other
1661         pseudo-registers.
1662         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1663         New functions.
1664         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1665         Handle "vX" aliases.
1666         (v_alias_pseudo_register_collect): New function.
1667         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1668         (rs6000_gdbarch_init): Initialize "vX" aliases as
1669         pseudo-registers.  Restore registration of
1670         rs6000_pseudo_register_reggroup_p with
1671         set_tdesc_pseudo_register_reggroup_p.
1672
1673 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1674
1675         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1676         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1677         set_gdbarch_num_pseudo_regs.
1678
1679 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1680
1681         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1682         Remove arg prefixname, add do_set and do_show.
1683         Add member functions set_list and show_list.
1684         * cli/cli-style.c (class cli_style_option): Update accordingly.
1685         (style_set_list): Move to file scope.
1686         (style_show_list): Likewise.
1687         (set_style): Call help_list.
1688         (show_style): Call cmd_show_list.
1689         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1690         Update to use the new macro.
1691
1692 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1693
1694         * ada-lang.c (_initialize_ada_language): Expand the help text
1695         for the "catch exception" command.
1696
1697 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1698
1699         * symtab.c (matching_obj_sections): Initialize obj,
1700         declare it closer to its usage.
1701
1702 2019-01-10  Tom Tromey  <tom@tromey.com>
1703
1704         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1705         (basic_inf_threads_range): Remove.
1706         (inf_threads_range, inf_non_exited_threads_range)
1707         (safe_inf_threads_range): Use next_adapter.
1708
1709 2019-01-10  Keith Seitz  <keiths@redhat.com>
1710
1711         PR gdb/23712
1712         PR symtab/23010
1713         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1714         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1715
1716 2019-01-10  Keith Seitz  <keiths@redhat.com>
1717
1718         PR gdb/23712
1719         PR symtab/23010
1720         * dictionary.c (pending_to_vector): Remove.
1721         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1722         Remove _1 suffix, replacing functions of the same name.  Update
1723         all callers.
1724         (dict_create_hashed, dict_create_hashed_expandable)
1725         (dict_create_linear, dict_create_linear_expandable, dict_free)
1726         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1727         Make functions static.
1728
1729 2019-01-10  Keith Seitz  <keiths@redhat.com>
1730
1731         PR gdb/23712
1732         PR symtab/23010
1733         * dictionary.h (struct dictionary): Replace declaration with
1734         multidictionary.
1735         (dict_create_hashed, dict_create_hashed_expandable)
1736         (dict_create_linear, dict_create_linear_expandable)
1737         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1738         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1739         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1740         taking multidictionary argument.
1741         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1742         * block.h (struct block) <dict>: Change to multidictionary
1743         and rename `multidict'.
1744         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1745         symmisc.c: Update all dictionary references to multidictionary.
1746
1747 2019-01-10  Keith Seitz  <keiths@redhat.com>
1748
1749         PR gdb/23712
1750         PR symtab/23010
1751         * dictionary.c: Include unordered_map.
1752         (pending_to_vector): New function.
1753         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1754         Rewrite the non-"_1" functions to take vector instead
1755         of linked list.
1756         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1757         "new" _1 versions of the same name.
1758         (multidictionary): Define.
1759         (std::hash<enum language): New definition.
1760         (collate_pending_symbols_by_language, mdict_create_hashed)
1761         (mdict_create_hashed_expandable, mdict_create_linear)
1762         (mdict_create_linear_expandable, mdict_free)
1763         (find_language_dictionary, create_new_language_dictionary)
1764         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1765         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1766         (mdict_size, mdict_empty): New functions.
1767         * dictionary.h (mdict_iterator): Define.
1768
1769 2019-01-10  Pedro Alves  <palves@redhat.com>
1770
1771         * breakpoint.c (read_uploaded_action)
1772         (create_tracepoint_from_upload): Adjust to use
1773         gdb::unique_xmalloc_ptr.
1774         * ctf.c (ctf_write_uploaded_tp):
1775         (SET_ARRAY_FIELD): Use emplace_back.
1776         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1777         * tracefile-tfile.c (tfile_write_uploaded_tp):
1778         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1779         gdb::unique_xmalloc_ptr.
1780         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1781         at_string, cond_string, cmd_strings>: Replace char pointers
1782         with gdb::unique_xmalloc_ptr.
1783
1784 2019-01-10  Pedro Alves  <palves@redhat.com>
1785
1786         * solib-target.c (library_list_start_library): Don't xstrdup name.
1787
1788 2019-01-10  Pedro Alves  <palves@redhat.com>
1789
1790         * mdebugread.c (parse_partial_symbols): Use
1791         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1792
1793 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1794
1795         * linux-fork.c (scoped_switch_fork_info)
1796         <~scoped_switch_fork_info>: Fix incorrect variable name.
1797
1798 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1799
1800         * linux-fork.c (scoped_switch_fork_info)
1801         <scoped_switch_fork_info>: Make explicit.
1802         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1803
1804 2019-01-10  Tom Tromey  <tom@tromey.com>
1805
1806         * objfiles.h (objfile::reset_psymtabs): Update.
1807         * objfiles.c (objfile::objfile): Update.
1808         * psymtab.h (psymtab_storage::obstack): Update.
1809         (psymtab_storage::m_obstack): Use gdb::optional.
1810         (class psymtab_storage): Update comment.  Remove objfile
1811         parameter.
1812         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1813
1814 2019-01-10  Tom Tromey  <tom@tromey.com>
1815
1816         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1817         <free_psymtabs>: Now private.
1818         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1819         (allocate_psymtab): Use new method.
1820
1821 2019-01-10  Tom Tromey  <tom@tromey.com>
1822
1823         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1824         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1825         * mdebugread.c (parse_partial_symbols): Use
1826         allocate_dependencies.
1827         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1828         allocate_dependencies.
1829         (process_psymtab_comp_unit_reader)
1830         (build_type_psymtab_dependencies): Likewise.
1831         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1832
1833 2019-01-10  Tom Tromey  <tom@tromey.com>
1834
1835         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1836         PSYMBOL_SET_LANGUAGE.
1837         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1838
1839 2019-01-10  Tom Tromey  <tom@tromey.com>
1840
1841         * psymtab.h (psymtab_storage::obstack): New method.
1842         <m_obstack>: Rename from obstack; now private.
1843         * psymtab.c (psymtab_storage): Update.
1844         * dwarf2read.c (create_addrmap_from_index)
1845         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1846         Update.
1847
1848 2019-01-10  Tom Tromey  <tom@tromey.com>
1849
1850         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1851         * objfiles.h (objfile::reset_psymtabs): New method.
1852
1853 2019-01-10  Tom Tromey  <tom@tromey.com>
1854
1855         * symmisc.c (print_symbol_bcache_statistics): Update.
1856         (print_objfile_statistics): Update.
1857         * symfile.c (reread_symbols): Update.
1858         * psymtab.h (class psymtab_storage): New.
1859         * psymtab.c (psymtab_storage): New constructor.
1860         (~psymtab_storage): New destructor.
1861         (require_partial_symbols): Update.
1862         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1863         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1864         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1865         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1866         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1867         (start_psymtab_common, end_psymtab_common)
1868         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1869         (allocate_psymtab): Update.
1870         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1871         Update.
1872         (dump_psymtab_addrmap, maintenance_print_psymbols)
1873         (maintenance_check_psymtabs): Update.
1874         (class objfile_psymtabs): Move to objfiles.h.
1875         * psympriv.h (discard_psymtab): Now inline.
1876         (psymtab_discarder::psymtab_discarder): Update.
1877         (psymtab_discarder::~psymtab_discarder): Update.
1878         (ALL_OBJFILE_PSYMTABS): Rewrite.
1879         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1880         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1881         Remove fields.
1882         <partial_symtabs>: New field.
1883         (class objfile_psymtabs): Move from psymtab.h.  Update.
1884         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1885         psymbol_cache.
1886         (objfile::~objfile): Don't destroy psymbol_cache.
1887         * mdebugread.c (parse_partial_symbols): Update.
1888         * dwarf2read.c (create_addrmap_from_index)
1889         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1890         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1891         (add_partial_subprogram, dwarf2_ranges_read): Update.
1892         * dwarf-index-write.c (write_address_map)
1893         (write_one_signatured_type, recursively_write_psymbols)
1894         (class debug_names, class debug_names, write_psymtabs_to_index):
1895         Update.
1896
1897 2019-01-10  Tom Tromey  <tom@tromey.com>
1898
1899         * symtab.h (SYMBOL_SET_NAMES): Update.
1900         (symbol_set_names): Update.
1901         (MSYMBOL_SET_NAMES): Update.
1902         * symtab.c (symbol_set_names): Change argument to be an
1903         objfile_per_bfd_storage.
1904         * psymtab.c (add_psymbol_to_bcache): Update.
1905         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1906
1907 2019-01-10  Tom Tromey  <tom@tromey.com>
1908
1909         * symtab.c (create_demangled_names_hash): Change argument to be an
1910         objfile_per_bfd_storage.
1911         (symbol_set_names): Update.
1912
1913 2019-01-10  Tom Tromey  <tom@tromey.com>
1914
1915         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1916         init_psymbol_list.
1917         * psymtab.c (init_psymbol_list): Do nothing if already called.
1918         * psympriv.h (init_psymbol_list): Add comment.
1919         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1920         init_psymbol_list.
1921         * dbxread.c (dbx_symfile_read): Unconditionally call
1922         init_psymbol_list.
1923
1924 2019-01-10  Tom Tromey  <tom@tromey.com>
1925
1926         * xcoffread.c (scan_xcoff_symtab): Update.
1927         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1928         "where".
1929         * mdebugread.c (parse_partial_symbols)
1930         (handle_psymbol_enumerators): Update.
1931         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1932         * dbxread.c (read_dbx_symtab): Update.
1933         * psympriv.h (psymbol_placement): New enum.
1934         (add_psymbol_to_list): Update.
1935
1936 2019-01-10  Tom Tromey  <tom@tromey.com>
1937
1938         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1939         static_psymbols parameters.
1940         (scan_xcoff_symtab): Update.
1941         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1942         static_psymbols parameters.
1943         * psympriv.h (start_psymtab_common): Update.
1944         * mdebugread.c (parse_partial_symbols): Update.
1945         * dwarf2read.c (create_partial_symtab): Update.
1946         * dbxread.c (read_dbx_symtab): Update.
1947         (start_psymtab): Remove global_psymbols and static_psymbols
1948         parameters.
1949
1950 2019-01-10  Tom Tromey  <tom@tromey.com>
1951
1952         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1953         * psymtab.c (allocate_psymtab): Add comment.
1954         * psympriv.h (allocate_psymtab): Add comment.
1955         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1956         initializations.
1957         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1958
1959 2019-01-10  Tom Tromey  <tom@tromey.com>
1960
1961         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1962         Don't declare.
1963         * mipsread.c: Include mdebugread.h.
1964         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1965         Declare.
1966         * elfread.c: Include mdebugread.h.
1967
1968 2019-01-09  Tom Tromey  <tom@tromey.com>
1969
1970         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1971         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1972         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1973         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1974         (psym_lookup_symbol, psym_find_last_source_symtab)
1975         (psym_forget_cached_source_info, psym_print_stats)
1976         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1977         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1978         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1979         (psym_find_compunit_symtab_by_address)
1980         (maintenance_print_psymbols, maintenance_info_psymtabs)
1981         (maintenance_check_psymtabs): Use ranged for.
1982         * psymtab.h (class objfile_psymtabs): New.
1983         (require_partial_symbols): Return objfile_psymtabs.
1984         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1985
1986 2019-01-09  Tom Tromey  <tom@tromey.com>
1987
1988         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1989         (find_pc_mapped_section, list_overlays_command)
1990         (map_overlay_command, unmap_overlay_command)
1991         (simple_overlay_update): Use all_objfiles.
1992         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1993         * printcmd.c (info_symbol_command): Use all_objfiles.
1994         * objfiles.h (ALL_OBJSECTIONS): Remove.
1995         * maint.c (maintenance_translate_address): Use all_objfiles.
1996         * gcore.c (gcore_create_callback): Use all_objfiles.
1997         (objfile_find_memory_regions): Likewise.
1998
1999 2019-01-09  Tom Tromey  <tom@tromey.com>
2000
2001         * symtab.c (find_line_symtab, info_sources_command)
2002         (make_source_files_completion_list): Use objfile_compunits.
2003         * source.c (select_source_symtab): Use objfile_compunits.
2004         * objfiles.h (struct objfile): Update comment.
2005         (ALL_OBJFILES): Remove.
2006         (ALL_FILETABS): Remove.
2007         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2008         objfile_compunits.
2009
2010 2019-01-09  Tom Tromey  <tom@tromey.com>
2011
2012         * symmisc.c (print_objfile_statistics, dump_objfile)
2013         (maintenance_print_symbols): Use compunit_filetabs.
2014         * source.c (forget_cached_source_info_for_objfile): Use
2015         compunit_filetabs.
2016         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2017         (ALL_FILETABS): Use compunit_filetabs.
2018         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2019         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2020
2021 2019-01-09  Tom Tromey  <tom@tromey.com>
2022
2023         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2024         (compunit_filetabs): New.
2025         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2026         compunit_filetabs.
2027         (info_sources_command, make_source_files_completion_list): Remove
2028         declaration.
2029         * symmisc.c (print_objfile_statistics, dump_objfile)
2030         (maintenance_print_symbols): Remove declaration.
2031         (maintenance_info_symtabs): Use compunit_filetabs.
2032         (maintenance_info_line_tables): Likewise.
2033         * source.c (select_source_symtab): Change local variable name.
2034         (forget_cached_source_info_for_objfile): Remove declaration.
2035         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2036         * objfiles.c (objfile_relocate1): Remove declaration.
2037         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2038         declaration.
2039         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2040         * coffread.c (coff_symtab_read): Remove declaration.
2041         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2042         compunit_filetabs.
2043
2044 2019-01-09  Tom Tromey  <tom@tromey.com>
2045
2046         * symtab.c (lookup_objfile_from_block)
2047         (find_pc_sect_compunit_symtab, search_symbols)
2048         (default_collect_symbol_completion_matches_break_on): Use
2049         objfile_compunits.
2050         * objfiles.h (ALL_COMPUNITS): Remove.
2051         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2052         * cp-support.c (add_symbol_overload_list_qualified): Use
2053         objfile_compunits.
2054         * ada-lang.c (ada_collect_symbol_completion_matches)
2055         (ada_add_global_exceptions): Use objfile_compunits.
2056
2057 2019-01-09  Tom Tromey  <tom@tromey.com>
2058
2059         * source.c (select_source_symtab)
2060         (forget_cached_source_info_for_objfile): Remove declaration.
2061         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2062         declaration.
2063         * maint.c (count_symtabs_and_blocks): Remove declaration.
2064         * cp-support.c (add_symbol_overload_list_qualified): Remove
2065         declaration.
2066         * coffread.c (coff_symtab_read): Remove declaration.
2067         * symtab.c (lookup_symbol_in_objfile_symtabs)
2068         (basic_lookup_transparent_type_1): Use objfile_compunits.
2069         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2070         (info_sources_command, search_symbols)
2071         (default_collect_symbol_completion_matches_break_on)
2072         (make_source_files_completion_list): Remove declaration.
2073         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2074         (ada_collect_symbol_completion_matches)
2075         (ada_add_global_exceptions): Remove declaration.
2076         * linespec.c (iterate_over_all_matching_symtabs): Use
2077         objfile_compunits.
2078         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2079         (class objfile_compunits): New.
2080         (ALL_COMPUNITS): Use objfile_compunits.
2081         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2082         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2083         objfile_compunits.
2084         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2085
2086 2019-01-09  Tom Tromey  <tom@tromey.com>
2087
2088         * symtab.c (search_symbols)
2089         (default_collect_symbol_completion_matches_break_on): Use
2090         objfile_msymbols.
2091         * ada-lang.c (ada_lookup_simple_minsym)
2092         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2093         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2094         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2095         objfile_msymbols.
2096         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2097         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2098         * objc-lang.c (find_methods): Use objfile_msymbols.
2099         (info_selectors_command, info_classes_command): Likewise.
2100         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2101         * objfiles.h (class objfile_msymbols): New.
2102         (ALL_OBJFILE_MSYMBOLS): Remove.
2103         (ALL_MSYMBOLS): Remove.
2104
2105 2019-01-09  Tom Tromey  <tom@tromey.com>
2106
2107         * common/next-iterator.h (next_adapter): Add Iterator template
2108         parameter.
2109         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2110         (class all_objfiles_safe): New.
2111         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2112         * objfiles.c (put_objfile_before): Update comment.
2113         (add_separate_debug_objfile): Likewise.
2114         (free_all_objfiles): Use all_objfiles_safe.
2115         (objfile_purge_solibs): Likewise.
2116
2117 2019-01-09  Tom Tromey  <tom@tromey.com>
2118
2119         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2120         (expand_symtab_containing_pc, lookup_static_symbol)
2121         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2122         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2123         all_objfiles.
2124         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2125         * breakpoint.c (create_overlay_event_breakpoint)
2126         (create_longjmp_master_breakpoint)
2127         (create_std_terminate_master_breakpoint)
2128         (create_exception_master_breakpoint): Use all_objfiles.
2129         * linux-thread-db.c (try_thread_db_load_from_pdir)
2130         (has_libpthread): Use all_objfiles.
2131         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2132         * linespec.c (iterate_over_all_matching_symtabs)
2133         (search_minsyms_for_name): Use all_objfiles.
2134         * maint.c (maintenance_info_sections): Use all_objfiles.
2135         * main.c (captured_main_1): Use all_objfiles.
2136         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2137         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2138         * guile/scm-pretty-print.c
2139         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2140         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2141         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2142         (maintenance_print_msymbols): Use all_objfiles.
2143         * source.c (select_source_symtab): Use all_objfiles.
2144         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2145         * symfile.c (remove_symbol_file_command)
2146         (expand_symtabs_matching, map_symbol_filenames): Use
2147         all_objfiles.
2148         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2149         all_objfiles.
2150         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2151         * objc-lang.c (find_methods): Use all_objfiles.
2152         * objfiles.c (have_partial_symbols, have_full_symbols)
2153         (have_minimal_symbols, qsort_cmp)
2154         (default_iterate_over_objfiles_in_search_order): Use
2155         all_objfiles.
2156         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2157         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2158         (maintenance_check_psymtabs): Use all_objfiles.
2159         (ALL_PSYMTABS): Remove.
2160         * compile/compile-object-run.c (do_module_cleanup): Use
2161         all_objfiles.
2162         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2163         * cp-support.c (add_symbol_overload_list_qualified): Use
2164         all_objfiles.
2165         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2166         Use all_objfiles.
2167         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2168         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2169         all_objfiles.
2170         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2171         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2172         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2173         Uses all_objfiles.
2174         * solib.c (solib_read_symbols): Use all_objfiles
2175
2176 2019-01-09  Tom Tromey  <tom@tromey.com>
2177
2178         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2179         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2180         all_objfiles.
2181         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2182         * symmisc.c (print_symbol_bcache_statistics)
2183         (print_objfile_statistics, maintenance_print_objfiles)
2184         (maintenance_info_symtabs, maintenance_check_symtabs)
2185         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2186         all_objfiles.
2187         * source.c (forget_cached_source_info): Use all_objfiles.
2188         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2189         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2190         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2191         * objfiles.c (update_section_map): Use all_objfiles.
2192         (shared_objfile_contains_address_p): Likewise.
2193         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2194         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2195
2196 2019-01-09  Tom Tromey  <tom@tromey.com>
2197
2198         * common/next-iterator.h: New file.
2199         * objfiles.h (class all_objfiles): New.
2200         (struct objfile_iterator): New.
2201
2202 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2203
2204         * NEWS: Move the description of the changed "frame", "select-frame",
2205          and "info frame" commands to the Changed commands section.
2206
2207 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2208
2209         * gdbtypes.c (check_stub_method_group): Remove handling of old
2210         mangling schemes.
2211         * linespec.c (find_methods): Likewise.
2212         * stabsread.c (read_member_functions): Likewise.
2213         * valops.c (search_struct_method): Likewise.
2214         (value_struct_elt_for_reference): Likewise.
2215         * NEWS: Mention this change.
2216
2217 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2218
2219         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2220         print_source_lines.
2221         * source.c (print_source_lines_base): Update line number check.
2222         (print_source_lines): New function.
2223         (source_lines_range::source_lines_range): New function.
2224         * source.h (class source_lines_range): New class.
2225         (print_source_lines): New declaration.
2226
2227 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2228
2229         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2230
2231 2019-01-08  Tom Tromey  <tom@tromey.com>
2232             Simon Marchi  <simon.marchi@ericsson.com>
2233
2234         PR gdb/24060
2235         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2236         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2237         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2238         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2239         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2240         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2241
2242 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2243
2244         * source.c (select_source_symtab): Move header comment to
2245         declaration in source.h.
2246         (forget_cached_source_info_for_objfile): Likewise.
2247         (forget_cached_source_info): Likewise.
2248         (identify_source_line): Likewise.
2249         * source.h (identify_source_line): Move declaration from symtab.h
2250         and add comment from source.c
2251         (print_source_lines): Likewise.
2252         (forget_cached_source_info_for_objfile): Likewise.
2253         (forget_cached_source_info): Likewise.
2254         (select_source_symtab): Likewise.
2255         (enum print_source_lines_flag): Move definition from symtab.h.
2256         * symtab.h (identify_source_line): Move declaration to source.h.
2257         (print_source_lines): Likewise.
2258         (forget_cached_source_info_for_objfile): Likewise.
2259         (forget_cached_source_info): Likewise.
2260         (select_source_symtab): Likewise.
2261         (enum print_source_lines_flag): Move definition to source.h.
2262         * tui/tui-hooks.c: Add 'source.h' include.
2263
2264 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2265
2266         * source.c (print_source_lines_base): Handle requests to print
2267         reverse line number sequences, and guard against empty lines
2268         string.
2269
2270 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2271
2272         * source.c (print_source_lines_base): Fix skip of '\r' if next
2273         character is '\n'.
2274
2275 2019-01-06  Tom Tromey  <tom@tromey.com>
2276
2277         * c-exp.y (struct c_parse_state) <macro_original_text,
2278         expansion_obstack>: New member.
2279         (macro_original_text, expansion_obstack): Remove globals.
2280         (scan_macro_expansion, scanning_macro_expansion)
2281         (finished_macro_expansion): Update.
2282         (scan_macro_cleanup): Remove.
2283         (yylex, c_parse): Update.
2284
2285 2019-01-06  Tom Tromey  <tom@tromey.com>
2286
2287         * c-exp.y (struct c_parse_state) <strings>: New member.
2288         (operator_stoken): Update.
2289
2290 2019-01-06  Tom Tromey  <tom@tromey.com>
2291
2292         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2293         (union type_stack_elt) <typelist_val>: Now a pointer to
2294         std::vector.
2295         (type_stack_cleanup): Don't declare.
2296         (push_typelist): Update.
2297         * parse.c (pop_typelist): Return a std::vector.
2298         (push_typelist): Take a std::vector.
2299         (follow_types): Update.  Do not free args.
2300         (type_stack_cleanup): Remove.
2301         * c-exp.y (struct c_parse_state): New.
2302         (cpstate): New global.
2303         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2304         (nonempty_typelist): Update.
2305         (func_mod): Create a new vector.
2306         (c_parse): Create a c_parse_state.
2307         (check_parameter_typelist): Do not delete params.
2308         (function_method): Update.  Do not delete type_list.
2309
2310 2019-01-06  Tom Tromey  <tom@tromey.com>
2311
2312         PR gdb/28155:
2313         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2314         check_typedef.
2315         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2316         (print_return_value): Likewise.
2317
2318 2019-01-05  Tom Tromey  <tom@tromey.com>
2319
2320         * contrib/cleanup_check.py: Remove.
2321         * contrib/gcc-with-excheck: Remove.
2322         * contrib/exsummary.py: Remove.
2323         * contrib/excheck.py: Remove.
2324
2325 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2326
2327         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2328         NULL. Initialize tpprev to NULL instead of assigning it
2329         to NULL on the next statement.
2330         * windows-nat.c (windows_delete_thread): Remove check for
2331         main_thread_id before printing thread exit notifications.
2332         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2333         Remove thread ID check against main_thread_id.
2334         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2335         windows_delete_thread.
2336         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2337
2338 2019-01-04  Tom Tromey  <tom@tromey.com>
2339
2340         * compile/compile.c (_initialize_compile): Use upper case for
2341         metasyntactic variables.
2342         * symmisc.c (_initialize_symmisc): Use upper case for
2343         metasyntactic variables.
2344         * psymtab.c (_initialize_psymtab): Use upper case for
2345         metasyntactic variables.
2346         * demangle.c (demangle_command): Use upper case for metasyntactic
2347         variables.
2348         (_initialize_demangler): Likewise.
2349         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2350         variables.
2351
2352 2019-01-03  Tom Tromey  <tom@tromey.com>
2353
2354         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2355
2356 2019-01-03  Tom Tromey  <tom@tromey.com>
2357
2358         * python/py-symtab.c (salpy_str): Update.
2359         (struct salpy_sal_object) <symtab>: Now a PyObject.
2360         (salpy_dealloc): Update.
2361         (del_objfile_sal): Use gdbpy_ref.
2362
2363 2019-01-03  Tom Tromey  <tom@tromey.com>
2364
2365         * python/py-type.c (convert_field): Use new_reference.  Return
2366         gdbpy_ref.
2367         (make_fielditem): Return gdbpy_ref.
2368         (typy_fields): Update.
2369         (typy_getitem): Update.
2370         (field_name): Return gdbpy_ref.  Use new_reference.
2371         (typy_iterator_iternext): Update.
2372
2373 2019-01-03  Tom Tromey  <tom@tromey.com>
2374
2375         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2376
2377 2019-01-03  Tom Tromey  <tom@tromey.com>
2378
2379         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2380         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2381         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2382         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2383         (pspy_set_type_printers): Likewise.
2384         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2385         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2386         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2387         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2388         (objfpy_set_type_printers): Likewise.
2389
2390 2019-01-03  Tom Tromey  <tom@tromey.com>
2391
2392         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2393         (gdbpy_print_stack): Use gdbpy_err_fetch.
2394         * python/python-internal.h (class gdbpy_err_fetch): New class.
2395         (class gdbpy_enter) <m_error_type, m_error_value,
2396         m_error_traceback>: Remove.
2397         <m_error>: New member.
2398         (gdbpy_exception_to_string): Don't declare.
2399         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2400         * python/py-value.c (convert_value_from_python): Use
2401         gdbpy_err_fetch.
2402         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2403         gdbpy_exception_to_string.
2404         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2405         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2406         gdbpy_err_fetch.
2407
2408 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2409
2410         * linux-nat.c (delete_lwp_cleanup): Delete.
2411         (struct lwp_deleter): New struct.
2412         (lwp_info_up): New typedef.
2413         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2414         lwp_info_up.
2415
2416 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2417
2418         * linux-fork.c (class scoped_switch_fork_info): New class.
2419         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2420
2421 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2422
2423         * valops.c (find_overload_match): Remove use of null_cleanup, and
2424         calls to do_cleanups.
2425
2426 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2427
2428         * compile/compile-cplus-types.c
2429         (compile_cplus_instance::decl_name): Handle changes to
2430         cp_func_name.
2431         * cp-support.c (cp_func_name): Update header comment, update
2432         return type.
2433         * cp-support.h (cp_func_name): Update return type in declaration.
2434         * valops.c (find_overload_match): Move temp_func local to top
2435         level of function and change its type.  Use temp_func to hold and
2436         delete temporary string obtained from cp_func_name.
2437
2438 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2439
2440         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2441         gdb::char_vector, remove cleanup, and update uses of `msg`.
2442
2443 2019-01-03  Jim Wilson  <jimw@sifive.com>
2444
2445         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2446
2447 2019-01-02  Tom Tromey  <tom@tromey.com>
2448
2449         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2450         (tdesc_parse_xml): Remove cleanups.
2451         * target-descriptions.h (make_cleanup_free_target_description):
2452         Don't declare.
2453         (target_desc_deleter): New struct.
2454         (target_desc_up): New typedef.
2455         * target-descriptions.c (target_desc_deleter::operator()): Rename
2456         from free_target_description.
2457         (make_cleanup_free_target_description): Remove.
2458
2459 2019-01-02  Tom Tromey  <tom@tromey.com>
2460
2461         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2462         constructor, destructor.
2463         (linespec_parser): Remove typedef.
2464         (~linespec_parser): Rename from linespec_parser_delete.
2465         (linespec_lex_to_end, linespec_complete_label)
2466         (linespec_complete): Update.
2467         (decode_line_full): Remove cleanups.
2468         (decode_line_1): Update.
2469
2470 2019-01-02  Tom Tromey  <tom@tromey.com>
2471
2472         * python/python-internal.h (inferior_to_inferior_object): Change
2473         return type.
2474         * python/py-exitedevent.c (create_exited_event_object): Update.
2475         * python/py-inferior.c (inferior_to_inferior_object): Return
2476         gdbpy_ref.
2477         (python_new_inferior, python_inferior_deleted)
2478         (thread_to_thread_object, delete_thread_object)
2479         (build_inferior_list, gdbpy_selected_inferior): Update.
2480         * python/py-infthread.c (create_thread_object): Update.  Also fail
2481         if inferior_to_inferior_object fails.
2482
2483 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2484
2485         * inferior.h (class inferior) <displaced_step_state>: New field.
2486         * infrun.h (struct displaced_step_state): Move here from
2487         infrun.c.  Initialize fields, add constructor.
2488         <inf>: Remove field.
2489         <reset>: New method.
2490         * infrun.c (struct displaced_step_inferior_state): Move to
2491         infrun.h.
2492         (displaced_step_inferior_states): Remove.
2493         (get_displaced_stepping_state): Adust.
2494         (displaced_step_in_progress_any_inferior): Adjust.
2495         (displaced_step_in_progress_thread): Adjust.
2496         (displaced_step_in_progress): Adjust.
2497         (add_displaced_stepping_state): Remove.
2498         (get_displaced_step_closure_by_addr): Adjust.
2499         (remove_displaced_stepping_state): Remove.
2500         (infrun_inferior_exit): Call displaced_step_state.reset.
2501         (use_displaced_stepping): Don't check for NULL.
2502         (displaced_step_prepare_throw): Call
2503         get_displaced_stepping_state.
2504         (displaced_step_fixup): Don't check for NULL.
2505         (prepare_for_detach): Don't check for NULL.
2506
2507 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2508
2509         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2510          in case of call that did not complete.
2511
2512 2019-01-02  Andrey Utkin  <autkin@undo.io>
2513
2514         * symfile.c (find_separate_debug_file): Fix search of debug files for
2515         remote debuggee.
2516
2517 2019-01-02  Tom Tromey  <tom@tromey.com>
2518
2519         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2520         indentation.
2521         * python/py-frame.c (frapy_older): Remove cast.
2522         (frapy_newer): Likewise.
2523         * python/py-breakpoint.c (local_setattro): Remove cast.
2524         * python/py-arch.c (archpy_name): Remove local variable.
2525         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2526
2527 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2528
2529         * unittests/basic_string_view/element_access/char/empty.cc:
2530         Fix year range in copyright header.
2531
2532 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2533
2534         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2535         Delete.
2536         <operator==>: Update with for removed field.
2537         <hash>: Likewise.
2538         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2539         <isa_features>: ...this.
2540         <abi_features>: New field.
2541         (riscv_isa_flen): Update comment.
2542         (riscv_abi_xlen): New declaration.
2543         (riscv_abi_flen): New declaration.
2544         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2545         isa_features.
2546         (riscv_abi_xlen): New function.
2547         (riscv_isa_flen): Update to get answer from isa_features.
2548         (riscv_abi_flen): New function.
2549         (riscv_has_fp_abi): Update to get answer from abi_features.
2550         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2551         xlen and flen.
2552         (riscv_call_info) <xlen, flen>: Update comment.
2553         (riscv_call_arg_struct): Remove invalid assertions
2554         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2555         is removed.
2556         (riscv_gdbarch_init): Gather isa features and abi features
2557         separately, ensure both match on the gdbarch when reusing an old
2558         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2559         a target with 64-bit float hardware.
2560
2561 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2562
2563         * source.c (search_command_helper): Stop reverse search
2564         when line 1 has been searched.
2565
2566 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2567
2568         * record-full.c (record_full_base_target::close): Rewrite
2569         record_full_core_buf_list free logic.
2570
2571 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2572
2573         * break-catch-syscall.c (print_one_catch_syscall): xfree
2574         the last text.
2575
2576 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2577
2578         * top.c (print_gdb_version): Update Copyright year in version
2579         message.
2580
2581 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2582
2583         Update copyright year range in all GDB files.
2584
2585 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2586
2587         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2588
2589 For older changes see ChangeLog-2018.
2590 \f
2591 Local Variables:
2592 mode: change-log
2593 left-margin: 8
2594 fill-column: 74
2595 version-control: never
2596 coding: utf-8
2597 End:
2598