gdb/ChangeLog

   1 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
   2
   3         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
   4         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
   5         method to compute the bounds of range types. Also print "[evaluated]"
   6         if the bounds' values come from a dynamic evaluation.
   7
   8 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
   9
  10         * cp-valprint.c (cp_print_value_fields): Don't print trailing
  11         whitespace when pretty printing is on.
  12
  13 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
  14
  15         * ppc-linux-nat.c: Add include.
  16
  17 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
  18
  19         * NEWS: Mention AArch64 Pointer Authentication.
  20
  21 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
  22
  23         * arm-linux-nat.c: Add include.
  24
  25 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
  26
  27         * source-cache.c (source_cache::get_source_lines): Re-read
  28         fullname after calling open_source_file.
  29
  30 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
  31
  32         * NEWS: Mention TLS support for FreeBSD.
  33
  34 2019-03-25  Tom Tromey  <tromey@adacore.com>
  35
  36         * minsyms.c (BUNCH_SIZE): Update comment.
  37         (~minimal_symbol_reader): Remove old comment.
  38         (compact_minimal_symbols): Update comment.
  39         (minimal_symbol_reader::install): Remove old comment.  Update
  40         other comments.
  41
  42 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
  43
  44         * s390-linux-nat.c: Add include.
  45
  46 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
  47
  48         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
  49         Call linux_get_hwcap.
  50         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
  51         Likewise.
  52         (aarch64_linux_get_hwcap): Remove function.
  53         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
  54         declaration.
  55         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
  56         linux_get_hwcap.
  57         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
  58         * linux-tdep.c (linux_get_hwcap): Add function.
  59         (linux_get_hwcap2): Likewise.
  60         * linux-tdep.h (linux_get_hwcap): Add declaration.
  61         (linux_get_hwcap2): Likewise.
  62         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
  63         (ppc_linux_get_hwcap2): Likewise.
  64         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
  65         linux_get_hwcap.
  66         (ppc_linux_nat_target::insert_watchpoint): Likewise.
  67         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
  68         (ppc_linux_nat_target::read_description): Likewise.
  69         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
  70         * s390-linux-nat.c: Likewise.
  71         * s390-linux-tdep.c (s390_core_read_description): Likewise.
  72
  73 2019-03-24  Tom Tromey  <tom@tromey.com>
  74
  75         * ada-lang.c (standard_lookup): Simplify initialization.
  76         (ada_lookup_symbol_nonlocal): Simplify return.
  77         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
  78         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
  79         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
  80         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
  81         initialization.
  82         * solib.c (solib_global_lookup): Simplify.
  83         * symtab.c (null_block_symbol): Remove.
  84         (symbol_cache_lookup): Simplify returns.
  85         (lookup_language_this): Simplify returns.
  86         (lookup_symbol_aux): Simplify return.
  87         (lookup_local_symbol): Simplify returns.
  88         (lookup_global_symbol_from_objfile): Simplify return.
  89         (lookup_symbol_in_objfile_symtabs)
  90         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
  91         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
  92         (lookup_static_symbol, lookup_global_symbol): Simplify return.
  93         * cp-namespace.c (cp_lookup_bare_symbol)
  94         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
  95         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
  96         (cp_lookup_nested_symbol): Don't use null_block_symbol.
  97         (cp_lookup_symbol_via_imports): Simplify initialization.
  98         (find_symbol_in_baseclass): Likewise.
  99         * symtab.h (null_block_symbol): Remove.
 100         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
 101         (d_lookup_nested_symbol, d_lookup_symbol_imports)
 102         (d_lookup_symbol_module): Likewise.
 103         (find_symbol_in_baseclass): Simplify initialization.
 104
 105 2019-03-24  Tom Tromey  <tom@tromey.com>
 106
 107         * expression.h: Don't include symtab.h.
 108         (struct block): Forward declare.
 109
 110 2019-03-24  Tom Tromey  <tom@tromey.com>
 111
 112         * c-exp.y (typebase): Remove casts.
 113         * gdbtypes.c (lookup_unsigned_typename, )
 114         (lookup_signed_typename): Remove cast.
 115         * eval.c (parse_to_comma_and_eval): Remove cast.
 116         * parse.c (write_dollar_variable): Remove cast.
 117         * block.h (struct block) <superblock>: Now const.
 118         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
 119         * psymtab.c (psym_map_matching_symbols): Make "block" const.
 120         (map_block): Make "block" const.
 121         * symfile.h (struct quick_symbol_functions)
 122         <map_matching_symbols>: Constify block argument to "callback".
 123         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
 124         const.
 125         (find_pc_sect_compunit_symtab): Make "b" const.
 126         (find_symbol_at_address): Likewise.
 127         (search_symbols): Likewise.
 128         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
 129         (dw2_debug_names_lookup_symbol): Likewise.
 130         (dw2_map_matching_symbols): Update.
 131         * p-valprint.c (pascal_val_print): Remove "block".
 132         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
 133         (aux_add_nonlocal_symbols): Make "block" const.
 134         (resolve_subexp): Remove cast.
 135         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
 136         const.
 137         (iterate_over_file_blocks): Likewise.
 138         * f-exp.y (%union) <bval>: Remove.
 139         * coffread.c (patch_opaque_types): Make "b" const.
 140         * spu-tdep.c (spu_catch_start): Make "block" const.
 141         * c-valprint.c (print_unpacked_pointer): Remove "block".
 142         * symmisc.c (dump_symtab_1): Make "b" const.
 143         (block_depth): Make "block" const.
 144         * d-exp.y (%union) <bval>: Remove.
 145         * cp-support.h (cp_lookup_rtti_type): Update.
 146         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
 147         * psymtab.c (psym_lookup_symbol): Make "block" const.
 148         (maintenance_check_psymtabs): Make "b" const.
 149         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
 150         (enumerate_locals, enumerate_args): Update.
 151         * python/py-symtab.c (stpy_global_block): Make "block" const.
 152         (stpy_static_block): Likewise.
 153         * inline-frame.c (block_starting_point_at): Make "new_block"
 154         const.
 155         * block.c (find_block_in_blockvector): Make return type const.
 156         (blockvector_for_pc_sect): Make "b" const.
 157         (find_block_in_blockvector): Make "b" const.
 158
 159 2019-03-23  Tom Tromey  <tom@tromey.com>
 160
 161         * varobj.c (varobj_create): Update.
 162         * symfile.c (clear_symtab_users): Don't reset innermost_block.
 163         * printcmd.c (display_command, do_one_display): Don't reset
 164         innermost_block.
 165         * parser-defs.h (enum innermost_block_tracker_type): Move to
 166         expression.h.
 167         (innermost_block): Update comment.
 168         * parse.c (parse_exp_1): Add tracker_types parameter.
 169         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
 170         tracker_types parameter.  Reset innermost_block.
 171         (parse_exp_in_context): Remove.
 172         (parse_expression_for_completion): Update.
 173         * objfiles.c (~objfile): Don't reset expression_context_block or
 174         innermost_block.
 175         * expression.h (enum innermost_block_tracker_type): Move from
 176         parser-defs.h.
 177         (parse_exp_1): Add tracker_types parameter.
 178         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
 179         reset innermost_block.
 180
 181 2019-03-23  Tom Tromey  <tom@tromey.com>
 182
 183         * objfiles.h: Include bcache.h.
 184
 185 2019-03-23  Tom Tromey  <tom@tromey.com>
 186
 187         * linespec.c (get_current_search_block): Use
 188         scoped_restore_current_language.
 189         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
 190
 191 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 192             Jiong Wang  <jiong.wang@arm.com>
 193
 194         * aarch64-linux-tdep.c
 195         (aarch64_linux_iterate_over_regset_sections): Check for pauth
 196         section.
 197         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
 198
 199 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 200             Jiong Wang  <jiong.wang@arm.com>
 201
 202         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
 203         instructions.
 204         (aarch64_analyze_prologue_test): Add PACIASP test.
 205         (aarch64_prologue_prev_register): Unmask PC value.
 206
 207 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 208             Jiong Wang  <jiong.wang@arm.com>
 209
 210         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
 211         (aarch64_dwarf2_prev_register): Unmask PC value.
 212         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
 213         (aarch64_execute_dwarf_cfa_vendor_op): Check for
 214         DW_CFA_AARCH64_negate_ra_state.
 215         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
 216
 217 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 218             Jiong Wang  <jiong.wang@arm.com>
 219
 220         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
 221         registers.
 222         (aarch64_pseudo_register_name): Likewise.
 223         (aarch64_pseudo_register_type): Likewise.
 224         (aarch64_pseudo_register_reggroup_p): Likewise.
 225         (aarch64_gdbarch_init): Add pauth registers.
 226         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
 227         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
 228         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
 229         (struct gdbarch_tdep): Add regnum for ra_state.
 230
 231 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 232             Jiong Wang  <jiong.wang@arm.com>
 233
 234         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
 235
 236 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 237             Jiong Wang  <jiong.wang@arm.com>
 238
 239         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
 240         function.
 241         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
 242         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
 243         (aarch64_gdbarch_init): Add puth registers.
 244         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
 245         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
 246         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
 247
 248 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 249             Jiong Wang  <jiong.wang@arm.com>
 250
 251         * aarch64-linux-nat.c
 252         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
 253         * aarch64-linux-tdep.c
 254         (aarch64_linux_core_read_description): Likewise.
 255         (aarch64_linux_get_hwcap): New function.
 256         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
 257         (aarch64_linux_get_hwcap): New declaration.
 258
 259 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 260             Jiong Wang  <jiong.wang@arm.com>
 261
 262         * aarch64-linux-nat.c
 263         (aarch64_linux_nat_target::read_description): Add pauth param.
 264         * aarch64-linux-tdep.c
 265         (aarch64_linux_core_read_description): Likewise.
 266         * aarch64-tdep.c (struct target_desc): Add in pauth.
 267         (aarch64_read_description): Add pauth param.
 268         (aarch64_gdbarch_init): Likewise.
 269         * aarch64-tdep.h (aarch64_read_description): Likewise.
 270         * arch/aarch64.c (aarch64_create_target_description): Likewise.
 271         * arch/aarch64.h (aarch64_create_target_description): Likewise.
 272         * features/Makefile: Add new files.
 273         * features/aarch64-pauth.c: New file.
 274         * features/aarch64-pauth.xml: New file.
 275
 276 2019-03-20  Tom Tromey  <tromey@adacore.com>
 277
 278         * infrun.c (handle_inferior_event): Rename from
 279         handle_inferior_event_1.  Create a scoped_value_mark.
 280         (handle_inferior_event): Remove.
 281
 282 2019-03-19  Tom Tromey  <tromey@adacore.com>
 283
 284         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
 285         * infrun.h (print_stop_event): Add "displays" parameter.
 286         * infrun.c (print_stop_event): Add "displays" parameter.
 287
 288 2019-03-19  Pedro Alves  <palves@redhat.com>
 289
 290         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
 291         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
 292         to -1.  Fix TABs vs spaces.
 293         (tui_ui_out::tui_ui_out): Don't initialize fields here.
 294         * tui/tui-out.h (tui_ui_out) Add intro comments.
 295         <m_line, m_start_of_line>: In-class initialize, and add describing
 296         comment.
 297
 298 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
 299
 300         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
 301         variable names.
 302         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
 303
 304 2019-03-18  Pedro Alves  <palves@redhat.com>
 305             Eli Zaretskii <eliz@gnu.org>
 306
 307         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 308         m_line and m_start_of_line.
 309
 310 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 311
 312         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 313         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 314         it returns a newline.  This fixes a regression in TU mode, whereby
 315         the next line is output on the same screen line as the user input.
 316
 317 2019-03-18  Tom Tromey  <tromey@adacore.com>
 318
 319         * minsyms.c (minimal_symbol_reader::install): Remove call to
 320         obstack_blank.
 321
 322 2019-03-18  Pedro Alves  <palves@redhat.com>
 323
 324         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 325         New globals.
 326         (apply_style): New, factored out from ...
 327         (apply_ansi_escape): ... this.  Handle reverse video mode.
 328         (tui_set_reverse_mode): New function.
 329         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 330         * tui/tui-winsource.c (tui_show_source_line): Use
 331         tui_set_reverse_mode instead of setting A_STANDOUT.
 332         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 333         New setter methods.
 334
 335 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 336
 337         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 338         Handle tabs.
 339
 340 2019-03-18  Tom Tromey  <tromey@adacore.com>
 341
 342         * ada-lang.c (empty_array): Add "high" parameter.
 343         (ada_evaluate_subexp): Update.
 344
 345 2019-03-17  Sergei Trofimovich <siarheit@google.com>
 346
 347         * unittests/string_view-selftests.c: Define
 348         _initialize_string_view_selftests unconditionally.
 349
 350 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 351
 352         PR gdb/24350
 353         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
 354
 355 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 356
 357         PR gdb/24351
 358         * windows-nat.c (display_selector): Fix format specifiers.
 359
 360 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 361
 362         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 363         tui_refill_source_window instead of tui_refresh_win, to update the
 364         current execution line.  This fixes redisplay of the current line
 365         when stepping through the code with "next" or "step".
 366
 367 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 368
 369         * source-cache.c (source_cache::get_source_lines): Call
 370         find_source_lines to initialize s->nlines.  This fixes vertical
 371         scrolling of TUI source window when the DOWN arrow is pressed.
 372
 373 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 374
 375         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
 376         linux-thread-db.c (_initialize_thread_db): Likewise.
 377
 378 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 379
 380         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 381         wclrtoeol in tui_show_source_line".  This reverts changes made in
 382         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 383
 384 2019-03-15  Tom Tromey  <tom@tromey.com>
 385
 386         * symtab.h (struct minimal_symbol): Derive from
 387         general_symbol_info.
 388         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
 389         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
 390         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
 391         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
 392         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
 393         (MSYMBOL_SEARCH_NAME): Update.
 394         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
 395         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
 396         * minsyms.c (minimal_symbol_reader::record_full): Update.
 397
 398 2019-03-15  Tom Tromey  <tom@tromey.com>
 399
 400         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
 401
 402 2019-03-15  Tom Tromey  <tom@tromey.com>
 403
 404         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 405         unique_xmalloc_ptr.
 406         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 407         Update.
 408         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 409         (build_minimal_symbol_hash_tables)
 410         (minimal_symbol_reader::install): Update.
 411
 412 2019-03-15  Tom Tromey  <tom@tromey.com>
 413
 414         * symtab.c (create_demangled_names_hash): Update.
 415         (symbol_set_names): Update.
 416         * objfiles.h (struct objfile_per_bfd_storage)
 417         <demangled_names_hash>: Now an htab_up.
 418         * objfiles.c (objfile_per_bfd_storage): Simplify.
 419
 420 2019-03-15  Tom Tromey  <tom@tromey.com>
 421
 422         * objfiles.h (struct objfile_per_bfd_storage): Declare
 423         destructor.
 424         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 425         New.
 426         (get_objfile_bfd_data): Use new.  Don't initialize
 427         language_of_main.
 428         (free_objfile_per_bfd_storage): Remove.
 429         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 430
 431 2019-03-15  Tom Tromey  <tom@tromey.com>
 432
 433         * symfile.c (reread_symbols): Update.
 434         * objfiles.c (objfile::objfile): Update.
 435         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 436         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 437         comment.
 438         (minimal_symbol_reader::install): Update.
 439         (terminate_minimal_symbol_table): Remove.
 440         * jit.c (jit_object_close_impl): Update.
 441
 442 2019-03-15  Tom Tromey  <tom@tromey.com>
 443
 444         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 445         initializations.
 446
 447 2019-03-15  Tom Tromey  <tom@tromey.com>
 448
 449         * objfiles.h (struct objfile_per_bfd_storage)
 450         <demangled_hash_languages>: Now a bitset.
 451         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 452         (lookup_minimal_symbol): Update.
 453
 454 2019-03-15  Tom Tromey  <tom@tromey.com>
 455
 456         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 457         Don't return the symbol.
 458         * coffread.c (record_minimal_symbol): Use record_full.
 459
 460 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 461
 462         The MS-Windows port of ncurses fails to switch to a color pair if
 463         one or both of the colors are the implicit default colors.  This
 464         change records the default colors when TUI is initialized, and
 465         then specifies them explicitly when a color pair uses the default
 466         colors.  This allows color styling in TUI mode on MS-Windows.
 467
 468         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 469         ncurses_norm_attr.
 470         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 471         colors in ncurses_norm_attr.
 472         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 473         "none", replace it with the default color recorded in
 474         ncurses_norm_attr.
 475
 476 2019-03-14  Tom Tromey  <tromey@adacore.com>
 477
 478         * source-cache.h (class source_cache) <get_source_lines>: Return
 479         std::string.
 480         * source-cache.c (source_cache::extract_lines): Handle case where
 481         first_pos==npos.  Return std::string.
 482         (source_cache::get_source_lines): Update.
 483
 484 2019-03-14  Tom Tromey  <tromey@adacore.com>
 485
 486         * NEWS: Add item for "style sources" commands.
 487         * source-cache.c (source_cache::get_source_lines): Check
 488         source_styling.
 489         * cli/cli-style.c (source_styling): New global.
 490         (_initialize_cli_style): Add "style sources" commands.
 491         (show_style_sources): New function.
 492         * cli/cli-style.h (source_styling): Declare.
 493
 494 2019-03-14  Pedro Alves  <palves@redhat.com>
 495             Tom Tromey  <tromey@adacore.com>
 496
 497         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 498         * tui/tui-winsource.c (tui_refill_source_window): New function,
 499         from...
 500         (tui_horizontal_source_scroll): ... here.  Move some logic.
 501         * cli/cli-style.c (set_style_enabled): Notify new observable.
 502         * tui/tui-hooks.c (tui_redisplay_source): New function.
 503         (tui_attach_detach_observers): Attach or detach
 504         tui_redisplay_source.
 505         * observable.h (source_styling_changed): New observable.
 506         * observable.c: Define source_styling_changed observable.
 507
 508 2019-03-13  Tom Tromey  <tromey@adacore.com>
 509
 510         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 511         (i386_gnu_nat_target::store_registers): Update.
 512         * target-debug.h (target_debug_print_std_string): New macro.
 513         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 514         * windows-tdep.c (display_one_tib): Update.
 515         * tui/tui-stack.c (tui_make_status_line): Update.
 516         * top.c (print_inferior_quit_action): Update.
 517         * thread.c (thr_try_catch_cmd): Update.
 518         (add_thread_with_info): Update.
 519         (thread_target_id_str): Update.
 520         (thr_try_catch_cmd): Update.
 521         (thread_command): Update.
 522         (thread_find_command): Update.
 523         * record-btrace.c (record_btrace_target::info_record)
 524         (record_btrace_resume_thread, record_btrace_target::resume)
 525         (record_btrace_cancel_resume, record_btrace_step_thread)
 526         (record_btrace_target::wait, record_btrace_target::wait)
 527         (record_btrace_target::wait, record_btrace_target::stop): Update.
 528         * progspace.c (print_program_space): Update.
 529         * process-stratum-target.c
 530         (process_stratum_target::thread_address_space): Update.
 531         * linux-fork.c (linux_fork_mourn_inferior)
 532         (detach_checkpoint_command, info_checkpoints_command)
 533         (linux_fork_context): Update.
 534         (linux_fork_detach): Update.
 535         (class scoped_switch_fork_info): Update.
 536         (delete_checkpoint_command): Update.
 537         * infrun.c (follow_fork_inferior): Update.
 538         (follow_fork_inferior): Update.
 539         (proceed_after_vfork_done): Update.
 540         (handle_vfork_child_exec_or_exit): Update.
 541         (follow_exec): Update.
 542         (displaced_step_prepare_throw): Update.
 543         (displaced_step_restore): Update.
 544         (start_step_over): Update.
 545         (resume_1): Update.
 546         (clear_proceed_status_thread): Update.
 547         (proceed): Update.
 548         (print_target_wait_results): Update.
 549         (do_target_wait): Update.
 550         (context_switch): Update.
 551         (stop_all_threads): Update.
 552         (restart_threads): Update.
 553         (finish_step_over): Update.
 554         (handle_signal_stop): Update.
 555         (switch_back_to_stepped_thread): Update.
 556         (keep_going_pass_signal): Update.
 557         (print_exited_reason): Update.
 558         (normal_stop): Update.
 559         * inferior.c (inferior_pid_to_str): Change return type.
 560         (print_selected_inferior): Update.
 561         (add_inferior): Update.
 562         (detach_inferior): Update.
 563         * dummy-frame.c (fprint_dummy_frames): Update.
 564         * dcache.c (dcache_info_1): Update.
 565         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 566         (btrace_fetch, btrace_clear): Update.
 567         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 568         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 569         type.
 570         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 571         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 572         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 573         * gdbarch.c, gdbarch.h: Rebuild.
 574         * gdbarch.sh (core_pid_to_str): Change return type.
 575         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 576         return type.
 577         (windows_nat_target::pid_to_str): Change return type.
 578         (windows_delete_thread): Update.
 579         (windows_nat_target::attach): Update.
 580         (windows_nat_target::files_info): Update.
 581         * target-delegates.c: Rebuild.
 582         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 583         return type.
 584         (sol_thread_target::pid_to_str): Change return type.
 585         * remote.c (class remote_target) <pid_to_str>: Change return
 586         type.
 587         (remote_target::pid_to_str): Change return type.
 588         (extended_remote_target::attach, remote_target::remote_stop_ns)
 589         (remote_target::remote_notif_remove_queued_reply)
 590         (remote_target::push_stop_reply, remote_target::disable_btrace):
 591         Update.
 592         (extended_remote_target::attach): Update.
 593         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 594         type.
 595         (gdbsim_target::pid_to_str): Change return type.
 596         * ravenscar-thread.c (struct ravenscar_thread_target)
 597         <pid_to_str>: Change return type.
 598         (ravenscar_thread_target::pid_to_str): Change return type.
 599         * procfs.c (class procfs_target) <pid_to_str>: Change return
 600         type.
 601         (procfs_target::pid_to_str): Change return type.
 602         (procfs_target::attach): Update.
 603         (procfs_target::detach): Update.
 604         (procfs_target::fetch_registers): Update.
 605         (procfs_target::store_registers): Update.
 606         (procfs_target::wait): Update.
 607         (procfs_target::files_info): Update.
 608         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 609         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 610         return type.
 611         (nto_procfs_target::pid_to_str): Change return type.
 612         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 613         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 614         return type.
 615         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 616         (exit_lwp): Update.
 617         (attach_proc_task_lwp_callback, get_detach_signal)
 618         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 619         (linux_nat_target::resume, wait_lwp, stop_callback)
 620         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 621         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 622         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 623         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 624         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 625         type.
 626         (inf_ptrace_target::attach): Update.
 627         (inf_ptrace_target::files_info): Update.
 628         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 629         type.
 630         (go32_nat_target::pid_to_str): Change return type.
 631         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 632         (gnu_nat_target::wait): Update.
 633         (gnu_nat_target::wait): Update.
 634         (gnu_nat_target::resume): Update.
 635         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 636         (fbsd_nat_target::wait): Update.
 637         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 638         type.
 639         (darwin_nat_target::attach): Update.
 640         * corelow.c (class core_target) <pid_to_str>: Change return type.
 641         (core_target::pid_to_str): Change return type.
 642         * target.c (normal_pid_to_str): Change return type.
 643         (default_pid_to_str): Likewise.
 644         (target_pid_to_str): Change return type.
 645         (target_translate_tls_address): Update.
 646         (target_announce_detach): Update.
 647         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 648         return type.
 649         (bsd_uthread_target::pid_to_str): Change return type.
 650         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 651         type.
 652         (bsd_kvm_target::pid_to_str): Change return type.
 653         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 654         return type.
 655         (aix_thread_target::pid_to_str): Change return type.
 656         * target.h (struct target_ops) <pid_to_str>: Change return type.
 657         (target_pid_to_str, normal_pid_to_str): Likewise.
 658         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 659         type.
 660         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 661         type.
 662         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 663         return type.
 664         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 665         type.
 666         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 667         type.
 668         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 669         return type.
 670
 671 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 672
 673         * NEWS: Mention that the new default MI version is 3.  Mention
 674         changes to the output of commands and events that deal with
 675         multi-location breakpoints.
 676         * breakpoint.c: Include "mi/mi-out.h".
 677         (print_one_breakpoint): Change output syntax if using MI version
 678         >= 3.
 679         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 680         New.
 681         (mi_multi_location_breakpoint_output_fixed): New.
 682         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 683         (mi_cmd_fix_multi_location_breakpoint_output): New.
 684         (mi_multi_location_breakpoint_output_fixed): New.
 685         * mi/mi-cmds.c (mi_cmds): Register command
 686         -fix-multi-location-breakpoint-output.
 687         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 688         interpreter "mi".
 689
 690 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 691
 692         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 693         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 694         instantiate mi_ui_out based on interpreter name.
 695         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 696         * mi/mi-main.c (mi_load_progress): Likewise.
 697
 698 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 699
 700         * NEWS: Combine separate "New targets" sections for 8.3.
 701
 702 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 703
 704         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 705         (ppcfbsd_init_abi): Install gdbarch
 706         "fetch_tls_load_module_address" and "get_thread_local_address"
 707         methods.
 708
 709 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 710
 711         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 712         (riscv_fbsd_init_abi): Install gdbarch
 713         "fetch_tls_load_module_address" and "get_thread_local_address"
 714         methods.
 715
 716 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 717
 718         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 719         (i386fbsd_init_abi): Install gdbarch
 720         "fetch_tls_load_module_address" and "get_thread_local_address"
 721         methods.
 722
 723 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 724
 725         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 726         (amd64fbsd_init_abi): Install gdbarch
 727         "fetch_tls_load_module_address" and "get_thread_local_address"
 728         methods.
 729
 730 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 731
 732         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 733         (struct fbsd_pspace_data): New type.
 734         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 735         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 736         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 737         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 738         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 739
 740 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 741
 742         * gdbtypes.c (lookup_struct_elt): New function.
 743         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 744         * gdbtypes.h (struct struct_elt): New type.
 745         (lookup_struct_elt): New prototype.
 746
 747 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 748
 749         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 750         remove disabled code block.
 751
 752 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 753
 754         * gdbarch.sh (get_thread_local_address): New method.
 755         * gdbarch.h, gdbarch.c: Regenerate.
 756         * target.c (target_translate_tls_address): Use
 757         gdbarch_get_thread_local_address if present instead of
 758         target::get_thread_local_address.
 759
 760 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 761
 762         * target.h (target::get_thread_local_address): Update comment.
 763
 764 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 765
 766         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 767         objfile->separate_debug_objfile_backlink if not NULL.
 768
 769 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 770
 771         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 772         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 773         (amd64bsd_store_inferior_registers): Likewise.
 774         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 775         Enable segment base registers.
 776         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 777         PT_GETFSBASE and PT_GETGSBASE.
 778         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 779         PT_SETGSBASE.
 780         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 781         segment base registers.
 782         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 783
 784 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 785
 786         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 787         Update calls to i386_target_description to add 'segments'
 788         parameter.
 789         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 790         add segment base registers.
 791         * arch/i386.c (i386_create_target_description): Add 'segments'
 792         parameter to enable segment base registers.
 793         * arch/i386.h (i386_create_target_description): Likewise.
 794         * features/i386/32bit-segments.xml: New file.
 795         * features/i386/32bit-segments.c: Generate.
 796         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 797         call to i386_target_description to add 'segments' parameter.
 798         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 799         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 800         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 801         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 802         if feature is present.
 803         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 804         Add 'segments' parameter to call to i386_target_description.
 805         (i386_target_description): Add 'segments' parameter to enable
 806         segment base registers.
 807         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 808         to call to i386_target_description.
 809         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 810         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 811         Define I386_NUM_REGS.
 812         (i386_target_description): Add 'segments' parameter to enable
 813         segment base registers.
 814
 815 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 816
 817         PR/24325
 818         * source-cache.c: #undef open and close, to avoid unresolved
 819         externals during linking.
 820
 821 2019-03-12  Tom Tromey  <tromey@adacore.com>
 822
 823         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 824         const.  Add initializers.
 825         (_initialize_remote): Don't initialize ptid globals.
 826
 827 2019-03-12  Pedro Alves  <palves@redhat.com>
 828
 829         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 830
 831 2019-03-12  Pedro Alves  <palves@redhat.com>
 832
 833         * cp-name-parser.y (main): Remove unused 'len' variable.
 834
 835 2019-03-12  Tom Tromey  <tromey@adacore.com>
 836
 837         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 838         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 839
 840 2019-03-12  Tom Tromey  <tromey@adacore.com>
 841
 842         * linux-nat.c (iterate_over_lwps): Update.
 843         (stop_callback): Remove parameter.
 844         (stop_wait_callback, detach_callback, resume_set_callback)
 845         (select_singlestep_lwp_callback, set_ignore_sigint)
 846         (status_callback, resumed_callback, resume_clear_callback)
 847         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 848         data parameter.
 849         (linux_nat_target::detach, linux_nat_target::resume)
 850         (linux_stop_and_wait_all_lwps, select_event_lwp)
 851         (linux_nat_filter_event, linux_nat_wait_1)
 852         (linux_nat_target::kill, linux_nat_target::stop)
 853         (linux_nat_target::stop): Update.
 854         (linux_nat_resume_callback): Change type.
 855         (resume_stopped_resumed_lwps, count_events_callback)
 856         (select_event_lwp_callback): Likewise.
 857         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 858         * arm-linux-nat.c (struct update_registers_data): Remove.
 859         (update_registers_callback): Change type.
 860         (arm_linux_insert_hw_breakpoint1): Update.
 861         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 862         parameter.
 863         (x86_linux_dr_set_addr): Update.
 864         (x86_linux_dr_set_control): Update.
 865         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 866         (iterate_over_lwps): Use gdb::function_view.
 867         * nat/aarch64-linux-hw-point.c (struct
 868         aarch64_dr_update_callback_param): Remove.
 869         (debug_reg_change_callback): Change type.
 870         (aarch64_notify_debug_reg_change): Update.
 871         * s390-linux-nat.c (s390_refresh_per_info): Update.
 872
 873 2019-03-11  Tom Tromey  <tromey@adacore.com>
 874
 875         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 876         redundant assignment to "this_cu".
 877
 878 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 879
 880         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 881
 882 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 883
 884         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 885         from...
 886         (rank_one_type): ... this.
 887
 888 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 889
 890         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 891         from...
 892         (rank_one_type): ... this.
 893
 894 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 895
 896         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 897         from...
 898         (rank_one_type): ... this.
 899
 900 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 901
 902         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 903         from...
 904         (rank_one_type): ... this.
 905
 906 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 907
 908         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 909         from...
 910         (rank_one_type): ... this.
 911
 912 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 913
 914         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 915         from...
 916         (rank_one_type): ... this.
 917
 918 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 919
 920         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 921         from...
 922         (rank_one_type): ... this.
 923
 924 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 925
 926         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 927         from...
 928         (rank_one_type): ... this.
 929
 930 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 931
 932         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 933         from...
 934         (rank_one_type): ... this.
 935
 936 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 937
 938         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 939         from...
 940         (rank_one_type): ... this.
 941
 942 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 943
 944         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 945         from...
 946         (rank_one_type): ... this.
 947
 948 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 949
 950         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 951         from...
 952         (rank_one_type): ... this.
 953
 954 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 955
 956         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 957         inferior-events' shows the example events.
 958
 959 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 960
 961         Support styling on native MS-Windows console
 962
 963         PR/24315
 964         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 965         on MS-Windows if $TERM is not defined.
 966
 967         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 968
 969         * posix-hdep.c (gdb_console_fputs):
 970         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 971         functions.
 972         * ui-file.h (gdb_console_fputs): Add prototype.
 973
 974         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 975         back to fputs only if the former returns zero.
 976
 977 2019-03-07  Tom Tromey  <tom@tromey.com>
 978
 979         * symmisc.c (print_symbol_bcache_statistics): Update.
 980         (print_objfile_statistics): Update.
 981         * symfile.c (allocate_symtab): Update.
 982         * stabsread.c: Don't include bcache.h.
 983         * psymtab.h (struct psymbol_bcache): Don't declare.
 984         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 985         (psymbol_bcache_init, psymbol_bcache_free)
 986         (psymbol_bcache_get_bcache): Don't declare.
 987         * psymtab.c (struct psymbol_bcache): Remove.
 988         (psymtab_storage::psymtab_storage): Update.
 989         (psymtab_storage::~psymtab_storage): Update.
 990         (psymbol_bcache_init, psymbol_bcache_free)
 991         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
 992         (add_psymbol_to_bcache): Update.
 993         (allocate_psymtab): Update.
 994         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 995         macro_cache>: No longer pointers.
 996         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
 997         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
 998         * macrotab.c (macro_bcache): Update.
 999         * macroexp.c: Don't include bcache.h.
1000         * gdbtypes.c (check_types_worklist): Update.
1001         (types_deeply_equal): Remove TRY/CATCH.  Update.
1002         * elfread.c (elf_symtab_read): Update.
1003         * dwarf2read.c: Don't include bcache.h.
1004         * buildsym.c (buildsym_compunit::get_macro_table): Update.
1005         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
1006         (print_bcache_statistics, bcache_memory_used): Don't declare.
1007         (struct bcache): Move from bcache.c.  Add constructor, destructor,
1008         methods.  Rename all data members.
1009         * bcache.c (struct bcache): Move to bcache.h.
1010         (bcache::expand_hash_table): Rename from expand_hash_table.
1011         (bcache): Remove.
1012         (bcache::insert): Rename from bcache_full.
1013         (bcache::compare): Rename from bcache_compare.
1014         (bcache_xmalloc): Remove.
1015         (bcache::~bcache): Rename from bcache_xfree.
1016         (bcache::print_statistics): Rename from print_bcache_statistics.
1017         (bcache::memory_used): Rename from bcache_memory_used.
1018
1019 2019-03-07  Pedro Alves  <palves@redhat.com>
1020
1021         * infrun.c (normal_stop): Also check for
1022         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
1023
1024 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1025
1026         * f-lang.c (value_from_host_double): Moved to...
1027         * value.c (value_from_host_double): ...here.
1028         * value.h (value_from_host_double): Declare.
1029         * guile/scm-math.c (vlscm_convert_typed_number): Use
1030         value_from_host_double.
1031         (vlscm_convert_number): Likewise.
1032         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
1033         * python/py-value.c (convert_value_from_python): Likewise.
1034
1035 2019-03-06  Tom Tromey  <tom@tromey.com>
1036
1037         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
1038
1039 2019-03-06  Tom Tromey  <tom@tromey.com>
1040
1041         * utils.h (free_current_contents): Don't declare.
1042         * utils.c (free_current_contents): Remove.
1043
1044 2019-03-06  Tom Tromey  <tom@tromey.com>
1045
1046         * top.c (quit_force): Update.
1047         * main.c (captured_command_loop): Update.
1048         * common/new-op.c (operator new): Update.
1049         * common/common-exceptions.c (struct catcher)
1050         <save_cleanup_chain>: Remove member.
1051         (exceptions_state_mc_init): Update.
1052         (exception_try_scope_entry): Return nullptr.
1053         (exception_try_scope_exit, exception_rethrow)
1054         (throw_exception_sjlj, throw_exception_cxx): Update.
1055         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
1056         (all_cleanups, do_cleanups, discard_cleanups)
1057         (discard_final_cleanups, save_cleanups, save_final_cleanups)
1058         (restore_cleanups, restore_final_cleanups): Don't declare.
1059         (do_final_cleanups): Remove parameter.
1060         * common/cleanups.c (cleanup_chain, make_cleanup)
1061         (make_cleanup_dtor, all_cleanups, do_cleanups)
1062         (discard_my_cleanups, discard_cleanups)
1063         (discard_final_cleanups, save_my_cleanups, save_cleanups)
1064         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
1065         (null_cleanup): Remove.
1066         (do_final_cleanups): Remove parameter.
1067
1068 2019-03-06  Tom Tromey  <tom@tromey.com>
1069
1070         * remote.c (remote_target::remote_parse_stop_reply): Use
1071         unique_xmalloc_ptr.
1072
1073 2019-03-06  Tom Tromey  <tom@tromey.com>
1074
1075         * stabsread.c (struct stabs_field_info): Rename from field_info.
1076         <list, fnlist>: Add initializers.
1077         <obstack>: New member.
1078         (read_member_functions, read_struct_fields, read_baseclasses):
1079         Allocate on obstack.  Don't use cleanups.
1080         (read_one_struct_field, read_member_functions, read_struct_fields)
1081         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
1082         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
1083         (read_struct_type): Update.
1084
1085 2019-03-06  Tom Tromey  <tom@tromey.com>
1086
1087         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
1088         * common/filestuff.h (make_cleanup_close): Don't declare.
1089         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
1090         Remove.
1091
1092 2019-03-06  Tom Tromey  <tom@tromey.com>
1093
1094         * solib-aix.c: Use make_scope_exit.
1095
1096 2019-03-06  Tom Tromey  <tom@tromey.com>
1097
1098         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
1099         Use make_scope_exit.
1100
1101 2019-03-06  Tom Tromey  <tom@tromey.com>
1102
1103         * solib-svr4.c (disable_probes_interface): Remove parameter.
1104         (svr4_handle_solib_event): Use make_scope_exit.
1105
1106 2019-03-06  Tom Tromey  <tom@tromey.com>
1107
1108         * remote.c (struct stop_reply_deleter): Remove.
1109         (stop_reply_up): Update.
1110         (struct stop_reply): Derive from notif_event.  Don't typedef.
1111         <regcache>: Now a std::vector.
1112         (stop_reply_xfree): Remove.
1113         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
1114         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
1115         (remote_target::discard_pending_stop_replies): Use delete.
1116         (remote_target::remote_parse_stop_reply): Update.
1117         (remote_target::process_stop_reply): Update.
1118         * remote-notif.h (struct notif_event): Add virtual destructor.
1119         Remove "dtr" member.
1120         (struct notif_client) <alloc_event>: Return a unique_ptr.
1121         (notif_event_xfree): Don't declare.
1122         (notif_event_up): New typedef.
1123         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
1124         (notif_event_xfree, do_notif_event_xfree): Remove.
1125         (remote_notif_state_xfree): Update.
1126
1127 2019-03-06  Tom Tromey  <tom@tromey.com>
1128
1129         * infrun.c (displaced_step_clear_cleanup): Now a
1130         forward_scope_exit type.
1131         (displaced_step_prepare_throw): Update.
1132         (displaced_step_fixup): Update.
1133
1134 2019-03-06  Tom Tromey  <tom@tromey.com>
1135
1136         * inferior.h (class inferior): Update comment.
1137         * gdbthread.h (class thread_info): Update comment.
1138
1139 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
1140             Tom Tromey  <tom@tromey.com>
1141
1142         * stabsread.h (struct stab_section_list): Remove.
1143         (coffstab_build_psymtabs): Update.
1144         * dbxread.c (symbuf_sections): Now a std::vector.
1145         (sect_idx): New global.
1146         (fill_symbuf): Update.
1147         (coffstab_build_psymtabs): Change type of stabsects parameter.
1148         Update.
1149         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
1150         std::vector.
1151         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
1152         (coff_locate_sections): Update.
1153         (coff_symfile_read): Remove cleanups.  Update.
1154         (init_stringtab): Add storage parameter.
1155         (free_stringtab, free_stringtab_cleanup): Remove.
1156         (init_lineno): Add storage parameter.
1157         (free_linetab, free_linetab_cleanup): Remove.
1158
1159 2019-03-06  Pedro Alves  <palves@redhat.com>
1160
1161         * linux-fork.c (fork_info::clobber_regs): Delete.
1162         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
1163         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
1164         comment.  Adjust.
1165         (scoped_switch_fork_info::scoped_switch_fork_info)
1166         (checkpoint_command, linux_fork_context): Adjust
1167         fork_save_infrun_state calls.
1168
1169 2019-03-06  Pedro Alves  <palves@redhat.com>
1170
1171         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
1172         (inf_has_multiple_threads): Return 'bool' and rewrite using
1173         inferior_info::threads().
1174
1175 2019-03-06  Pedro Alves  <palves@redhat.com>
1176
1177         * linux-fork.c: Include <list>.
1178         (fork_list): Now a std::list instance.
1179         (fork_info): Add ctor, dtor, and in-class initialize all fields.
1180         (forks_exist_p, find_last_fork): Adjust.
1181         (new_fork): Delete.
1182         (one_fork_p): New.
1183         (add_fork): Adjust.
1184         (free_fork): Delete, folded into fork_info::~fork_info().
1185         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
1186         Adjust.
1187         (init_fork_list): Delete.
1188         (linux_fork_killall, linux_fork_mourn_inferior)
1189         (linux_fork_detach, info_checkpoints_command): Adjust.
1190         (_initialize_linux_fork): No longer call init_fork_list.
1191
1192 2019-03-06  Pedro Alves  <palves@redhat.com>
1193
1194         * linux-fork.c (new_fork): New, split out of ...
1195         (add_fork): ... this.  Return void.  Move "first fork" special
1196         case from here, to ...
1197         (checkpoint_command): ... here.
1198         * linux-linux.h (add_fork): Return void.
1199
1200 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1201
1202         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1203
1204 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1205             Chris January  <chris.january@arm.com>
1206             David Lecomber  <david.lecomber@arm.com>
1207
1208         * f-exp.y: New token, UNOP_INTRINSIC.
1209         (exp): New pattern using UNOP_INTRINSIC token.
1210         (f77_keywords): Add 'abs' keyword.
1211         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1212         (value_from_host_double): New function.
1213         (evaluate_subexp_f): Support UNOP_ABS.
1214
1215 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1216
1217         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1218         types.
1219
1220 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1221
1222         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1223         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1224         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1225
1226 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1227
1228         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1229
1230 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1231             Chris January  <chris.january@arm.com>
1232
1233         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1234         * f-exp.y: Define 'KIND' token.
1235         (exp): New pattern for KIND expressions.
1236         (ptype): Handle types with a kind extension.
1237         (direct_abs_decl): Extend to spot kind extensions.
1238         (f77_keywords): Add 'kind' to the list.
1239         (push_kind_type): New function.
1240         (convert_to_kind_type): New function.
1241         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1242         * parse.c (operator_length_standard): Likewise.
1243         * parser-defs.h (enum type_pieces): Add tp_kind.
1244         * std-operator.def: Add UNOP_KIND.
1245
1246 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1247
1248         * f-exp.y (f_parse): Set yydebug.
1249
1250 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1251
1252         * f-lang.c (evaluate_subexp_f): New function.
1253         (exp_descriptor_f): New global.
1254         (f_language_defn): Use exp_descriptor_f instead of
1255         exp_descriptor_standard.
1256
1257 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1258
1259         * f-exp.y (struct token): Add comments.
1260         (dot_ops): Remove uppercase versions and the end marker.
1261         (f77_keywords): Likewise.
1262         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1263         entries in the dot_ops array are case insensitive, and use
1264         strncasecmp to compare strings.  Also some whitespace cleanup in
1265         this area.  Similar for the f77_keywords array, except entries in
1266         this list might be case sensitive.
1267
1268 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1269
1270         * f-exp.y (struct f77_boolean_val): Add comments.
1271         (boolean_values): Remove uppercase versions, and end marker.
1272         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1273         and use strncasecmp to achieve case insensitivity.  Additionally,
1274         perform whitespace cleanup around this code.
1275
1276 2019-03-06  Tom Tromey  <tromey@adacore.com>
1277
1278         * remote-sim.c (gdbsim_target_open): Use result of
1279         gdb_argv::release.
1280
1281 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1282         Dirk Schubert  <dirk.schubert@arm.com>
1283         Chris January  <chris.january@arm.com>
1284
1285         * eval.c (evaluate_subexp_standard): Call Fortran argument
1286         wrapping logic.
1287         * f-lang.c (struct value): A value which can be passed into a
1288         Fortran function call.
1289         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1290         where appropriate.
1291         (struct type): Value ready for a Fortran function call.
1292         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1293         is needed.
1294         * f-lang.h (fortran_argument_convert): Declaration.
1295         (fortran_preserve_arg_pointer): Declaration.
1296         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1297
1298 2019-03-05  Tom Tromey  <tromey@adacore.com>
1299
1300         * python/py-prettyprint.c (print_string_repr): Remove #if.
1301         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1302
1303 2019-03-05  Tom Tromey  <tromey@adacore.com>
1304
1305         * target.c (the_dummy_target): Move later.  Change type to
1306         "dummy_target".
1307         (initialize_targets): Don't initialize the_dummy_target.
1308
1309 2019-03-05  Tom Tromey  <tromey@adacore.com>
1310
1311         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1312         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1313
1314 2019-03-05  Tom Tromey  <tromey@adacore.com>
1315
1316         * windows-nat.c (windows_nat_target::attach)
1317         (windows_nat_target::detach): Don't call gdb_flush.
1318         * valprint.c (generic_val_print, val_print, val_print_string):
1319         Don't call gdb_flush.
1320         * utils.c (defaulted_query): Don't call gdb_flush.
1321         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1322         * target.c (target_announce_detach): Don't call gdb_flush.
1323         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1324         * remote.c (extended_remote_target::attach): Don't call
1325         gdb_flush.
1326         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1327         * printcmd.c (do_examine): Don't call gdb_flush.
1328         (info_display_command): Don't call gdb_flush.
1329         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1330         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1331         * memattr.c (info_mem_command): Don't call gdb_flush.
1332         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1333         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1334         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1335         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1336         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1337         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1338         (gnu_nat_target::detach): Don't call gdb_flush.
1339         * f-valprint.c (f_val_print): Don't call gdb_flush.
1340         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1341         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1342         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1343         gdb_flush.
1344         * c-valprint.c (c_val_print): Don't call gdb_flush.
1345         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1346
1347 2019-03-05  Tom Tromey  <tromey@adacore.com>
1348
1349         * varobj.c (update_dynamic_varobj_children): Update.
1350         (install_default_visualizer): Use reset, not release.
1351         * value.c (set_internalvar): Update.
1352         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1353         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1354         ATTRIBUTE_UNUSED_RESULT.
1355
1356 2019-03-05  Tom Tromey  <tromey@adacore.com>
1357
1358         * remote.c (class scoped_remote_fd) <release>: Add
1359         ATTRIBUTE_UNUSED_RESULT.
1360
1361 2019-03-05  Tom Tromey  <tromey@adacore.com>
1362
1363         * macroexp.c (struct macro_buffer) <release>: Add
1364         ATTRIBUTE_UNUSED_RESULT.
1365
1366 2019-03-05  Tom Tromey  <tromey@adacore.com>
1367
1368         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1369         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1370         ATTRIBUTE_UNUSED_RESULT.
1371
1372 2019-03-05  Tom Tromey  <tromey@adacore.com>
1373
1374         * common/scoped_fd.h (class scoped_fd) <release>: Add
1375         ATTRIBUTE_UNUSED_RESULT.
1376
1377 2019-03-05  Tom Tromey  <tromey@adacore.com>
1378
1379         * parser-defs.h (struct parser_state) <release>: Add
1380         ATTRIBUTE_UNUSED_RESULT.
1381
1382 2019-03-05  Tom Tromey  <tromey@adacore.com>
1383
1384         * utils.h (class gdb_argv) <release>: Add
1385         ATTRIBUTE_UNUSED_RESULT.
1386         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1387
1388 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1389
1390         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1391         for-loop range, to avoid compiler warnings.
1392
1393         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1394         avoid compiler warnings about unused variables.
1395
1396         * NEWS: Mention end of support for native debugging on MS-Windows
1397         before XP.
1398
1399         PR gdb/24292
1400         * common/netstuff.c:
1401         * gdbserver/gdbreplay.c
1402         * gdbserver/remote-utils.c:
1403         * ser-tcp.c:
1404         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1405         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1406         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1407         'getaddrinfo' and 'freeaddrinfo' were not available before
1408         Windows XP, and mingw.org's MinGW headers by default define
1409         _WIN32_WINNT to 0x500.
1410
1411 2019-03-01  Gary Benson <gbenson@redhat.com>
1412
1413         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1414
1415 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1416             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1417
1418         PR gdb/8527
1419         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1420         set_sigint_trap, clear_sigint_trap.
1421
1422 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1423
1424         * target.c (target_detach): Clear the regcache and the
1425         frame cache.
1426
1427 2019-02-27  Pedro Alves  <palves@redhat.com>
1428
1429         * utils.c (set_screen_size): When we cap the height/width sizes,
1430         tweak the corresponding command variable to show "unlimited":
1431
1432 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1433             Pedro Alves  <palves@redhat.com>
1434
1435         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1436         before calling rl_set_screen_size.
1437
1438 2019-02-27  Tom Tromey  <tromey@adacore.com>
1439
1440         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1441         define.
1442         * python/py-value.c: Remove Python 2.4 workaround.
1443         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1444         workaround.
1445         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1446         Python 2.4 workaround.
1447         * python/python-internal.h: Remove Python 2.4 comment.
1448         (Py_ssize_t): Don't define.
1449         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1450         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1451         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1452         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1453         * python/python.c (do_start_initialization): Remove Python 2.4
1454         workaround.
1455         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1456         (print_children): Remove Python 2.4 workaround.
1457         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1458         workaround.
1459         (CHARBUFFERPROC_NAME): Remove.
1460         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1461         Python 2.4 workaround.
1462
1463 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1464
1465         * NEWS: Note minimum Python version.
1466
1467 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1468
1469         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1470         code from these functions.  Remove corresponding ifdefs.  Use
1471         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1472         Remove gotos and target of gotos.
1473         (infpy_search_memory): Likewise.
1474
1475 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1476
1477         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1478         (hppa_gdbarch_init): Don't register deleted functions with
1479         gdbarch.
1480
1481 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1482
1483         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1484         (h8300_unwind_sp): Delete.
1485         (h8300_dummy_id): Delete.
1486         (h8300_gdbarch_init): Don't register deleted functions with
1487         gdbarch.
1488
1489 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1490
1491         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1492         (ft32_unwind_pc): Delete.
1493         (ft32_unwind_sp): Delete.
1494         (ft32_gdbarch_init): Don't register deleted functions with
1495         gdbarch.
1496
1497 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1498
1499         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1500         (frv_unwind_pc): Delete.
1501         (frv_unwind_sp): Delete.
1502         (frv_gdbarch_init): Don't register deleted functions with
1503         gdbarch.
1504
1505 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1506
1507         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1508         (riscv_unwind_pc): Delete.
1509         (riscv_unwind_sp): Delete.
1510         (riscv_gdbarch_init): Don't register deleted functions with
1511         gdbarch.
1512
1513 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1514
1515         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1516         (csky_unwind_pc): Delete.
1517         (csky_unwind_sp): Delete.
1518         (csky_gdbarch_init): Don't register deleted functions with
1519         gdbarch.
1520
1521 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1522
1523         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1524         (cris_unwind_pc): Delete.
1525         (cris_unwind_sp): Delete.
1526         (cris_gdbarch_init): Don't register deleted functions with
1527         gdbarch.
1528
1529 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1530
1531         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1532         (bfin_unwind_pc): Delete.
1533         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1534
1535 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1536
1537         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1538         (arm_unwind_pc): Delete.
1539         (arm_unwind_sp): Delete.
1540         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1541
1542 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1543
1544         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1545         (arc_unwind_pc): Delete.
1546         (arc_unwind_sp): Delete.
1547         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1548
1549 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1550
1551         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1552         (alpha_unwind_pc): Delete.
1553         (alpha_gdbarch_init): Don't register deleted functions with
1554         gdbarch.
1555
1556 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1557
1558         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1559         (aarch64_unwind_pc): Delete.
1560         (aarch64_unwind_sp): Delete.
1561         (aarch64_gdbarch_init): Don't register deleted functions with
1562         gdbarch.
1563
1564 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1565
1566         * gdbtypes.c (type_align): Don't consider static members when
1567         computing structure alignment.
1568
1569 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1570
1571         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1572         return 0 for other types.
1573         * arch-utils.c (default_type_align): Always return 0.
1574         * gdbarch.h: Regenerate.
1575         * gdbarch.sh (type_align): Extend comment.
1576         * gdbtypes.c (type_align): Add additional comments, always call
1577         gdbarch_type_align before applying the default rules.
1578         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1579         generic code will then apply a suitable default.
1580         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1581         types, return 0 for other types.
1582
1583 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1584
1585         * NEWS: Create a new section for the next release branch.
1586         Rename the section of the current branch, now that it has
1587         been cut.
1588
1589 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1590
1591         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1592         * version.in: Bump version to 8.3.50.DATE-git.
1593
1594 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1595
1596         * aix-thread.c (ptid_cmp): Remove unused variable.
1597         (get_signaled_thread): Likewise.
1598         (store_regs_user_thread): Likewise.
1599         (store_regs_kernel_thread): Likewise.
1600         (fetch_regs_kernel_thread): Remove shadowed variable.
1601
1602 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1603
1604         * features/riscv/32bit-cpu.xml: Add register numbers.
1605         * features/riscv/32bit-fpu.c: Regenerate.
1606         * features/riscv/32bit-fpu.xml: Add register numbers.
1607         * features/riscv/64bit-cpu.xml: Add register numbers.
1608         * features/riscv/64bit-fpu.c: Regenerate.
1609         * features/riscv/64bit-fpu.xml: Add register numbers.
1610
1611 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1612
1613         * NEWS: Mention two argument form of gdb.Value constructor.
1614         * python/py-value.c (convert_buffer_and_type_to_value): New
1615         function.
1616         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1617         Add support for handling an optional second argument.  Call
1618         convert_buffer_and_type_to_value as appropriate.
1619         * python/python-internal.h (Py_buffer_deleter): New struct.
1620         (Py_buffer_up): New typedef.
1621
1622 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1623
1624         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1625         instead of releasing ownership.
1626
1627 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1628
1629         * dwarf2read.c (open_and_init_dwp_file): Call
1630         elf_numsections instead of bfd_count_sections to initialize
1631         dwp_file->num_sections.
1632
1633 2019-02-25  Tom Tromey  <tromey@adacore.com>
1634
1635         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1636
1637 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1638
1639         * gcore.in: Add '--readnever' option when invoking GDB.
1640
1641 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1642
1643         * MAINTAINERS: Update my email address.
1644
1645 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1646
1647         * build-id.c (build_id_to_debug_bfd_1): New function.
1648         (build_id_to_debug_bfd): Look for separate debug file in
1649         sysroot.
1650
1651 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1652
1653         * gdbarch.sh: Update the copyright year range that is placed into
1654         generated files.
1655
1656 2019-02-22  Keith Seitz  <keiths@redhat.com>
1657
1658         PR symtab/23853
1659         * linespec.c (create_sals_line_offset): Search for the default
1660         symtab's filename instead of its fullname.
1661
1662 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1663
1664         * NEWS: Update style defaults.
1665
1666 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1667
1668         * main.c (captured_main_1): Disable styling in batch mode.
1669
1670 2019-02-20  Tom Tromey  <tom@tromey.com>
1671
1672         * symtab.c (symtab_symbol_info): Fix typos.
1673
1674 2019-02-20  Tom Tromey  <tromey@adacore.com>
1675
1676         * findcmd.c (_initialize_mem_search): Use upper case for
1677         metasyntactic variables.
1678
1679 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1680
1681         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1682         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1683
1684 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1685
1686         * top.h (source_file_name): Change to std::string.
1687         * top.c (source_file_name): Likewise.
1688         (command_line_input): Adjust.
1689         * cli/cli-script.c (script_from_file): Adjust.
1690
1691 2019-02-19  Tom Tromey  <tromey@adacore.com>
1692
1693         * ravenscar-thread.c
1694         (ravenscar_thread_target::update_thread_list): Don't call
1695         ada_build_task_list.
1696         * ada-lang.h (ada_build_task_list): Don't declare.
1697         * ada-tasks.c (struct ada_tasks_inferior_data)
1698         <task_list_valid_p>: Now bool.
1699         (read_known_tasks, ada_task_list_changed)
1700         (ada_tasks_invalidate_inferior_data): Update.
1701         (read_known_tasks_array): Return bool.
1702         (read_known_tasks_list): Likewise.
1703         (read_known_tasks): Return void.
1704         (ada_build_task_list): Now static.
1705
1706 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1707
1708         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1709         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1710
1711 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1712
1713         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1714         variant for ada_tasks_pspace_data_handle and
1715         ada_tasks_inferior_data_handle.
1716         (ada_tasks_pspace_data_cleanup): New function.
1717         (ada_tasks_inferior_data_cleanup): New function.
1718
1719 2019-02-17  Tom Tromey  <tom@tromey.com>
1720
1721         * macrotab.h (macro_source_fullname): Return a std::string.
1722         * macrotab.c (macro_include, check_for_redefinition)
1723         (macro_undef, macro_lookup_definition, foreach_macro)
1724         (foreach_macro_in_scope): Update.
1725         (macro_source_fullname): Return a std::string.
1726         * macrocmd.c (show_pp_source_pos): Update.
1727
1728 2019-02-17  Tom Tromey  <tom@tromey.com>
1729
1730         * macrocmd.c (show_pp_source_pos): Style the file names.
1731
1732 2019-02-17  Tom Tromey  <tom@tromey.com>
1733
1734         PR tui/24197:
1735         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1736
1737 2019-02-17  Tom Tromey  <tom@tromey.com>
1738
1739         * ada-lang.c (user_select_syms): Use filtered printing.
1740         * utils.c (wrap_style): New global.
1741         (desired_style): Remove.
1742         (emit_style_escape): Add stream parameter.
1743         (set_output_style, reset_terminal_style, prompt_for_continue):
1744         Update.
1745         (flush_wrap_buffer): Only flush gdb_stdout.
1746         (wrap_here): Set wrap_style.
1747         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1748         treat escape sequences as a character.  Change when wrap buffer is
1749         flushed.
1750         (fputs_styled): Do not set the output style when the default is
1751         requested.
1752         * ui-style.h (struct ui_file_style) <is_default>: New method.
1753         * source.c (print_source_lines_base): Emit escape sequences in one
1754         piece.
1755
1756 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1757
1758         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1759         integers and enumeration types.
1760
1761 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1762
1763         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1764         instead of lookup_symbol_in_language
1765         (do_exact_match): New function.
1766         (ada_get_symbol_name_matcher): Return do_exact_match when
1767         doing a verbatim match.
1768
1769 2019-02-15  Tom Tromey  <tromey@adacore.com>
1770
1771         * ravenscar-thread.c (ravenscar_thread_target::resume)
1772         (ravenscar_thread_target::wait): Special case wildcard requests.
1773
1774 2019-02-15  Tom Tromey  <tromey@adacore.com>
1775
1776         * ravenscar-thread.c (base_ptid): Remove.
1777         (struct ravenscar_thread_target) <close>: New method.
1778         <m_base_ptid>: New member.
1779         <update_inferior_ptid, active_task, task_is_currently_active,
1780         runtime_initialized>: Declare methods.
1781         <ravenscar_thread_target>: Add constructor.
1782         (ravenscar_thread_target::task_is_currently_active)
1783         (ravenscar_thread_target::update_inferior_ptid)
1784         (ravenscar_runtime_initialized): Rename.  Now methods.
1785         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1786         (ravenscar_thread_target::update_thread_list): Update.
1787         (ravenscar_thread_target::active_task): Now method.
1788         (ravenscar_thread_target::store_registers)
1789         (ravenscar_thread_target::prepare_to_store)
1790         (ravenscar_thread_target::prepare_to_store)
1791         (ravenscar_thread_target::mourn_inferior): Update.
1792         (ravenscar_inferior_created): Use "new" to create target.
1793         (ravenscar_thread_target::get_ada_task_ptid): Update.
1794         (_initialize_ravenscar): Don't initialize base_ptid.
1795         (ravenscar_ops): Remove global.
1796
1797 2019-02-15  Tom Tromey  <tromey@adacore.com>
1798
1799         * target.h (push_target): Declare new overload.
1800         * target.c (push_target): New overload, taking an rvalue reference.
1801         * remote.c (remote_target::open_1): Use push_target overload.
1802         * corelow.c (core_target_open): Use push_target overload.
1803
1804 2019-02-15  Tom Tromey  <tromey@adacore.com>
1805
1806         * ravenscar-thread.c (is_ravenscar_task)
1807         (ravenscar_task_is_currently_active): Return bool.
1808         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1809         (_initialize_ravenscar): Remove "(void)".
1810         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1811         Return bool.
1812
1813 2019-02-15  Tom Tromey  <tromey@adacore.com>
1814
1815         * ravenscar-thread.c (ravenscar_runtime_initializer)
1816         (has_ravenscar_runtime, get_running_thread_id)
1817         (ravenscar_thread_target::resume): Fix indentation.
1818
1819 2019-02-15  Tom Tromey  <tromey@adacore.com>
1820
1821         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1822         from ravenscar_arch_ops.
1823         (sparc_ravenscar_ops::fetch_registers)
1824         (sparc_ravenscar_ops::store_registers): Now methods.
1825         (sparc_ravenscar_prepare_to_store): Remove.
1826         (sparc_ravenscar_ops): Redefine.
1827         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1828         methods and destructor.  Remove members.
1829         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1830         (ravenscar_thread_target::store_registers)
1831         (ravenscar_thread_target::prepare_to_store): Update.
1832         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1833         Remove.
1834         (struct ppc_ravenscar_powerpc_ops): Derive from
1835         ravenscar_arch_ops.
1836         (ppc_ravenscar_powerpc_ops::fetch_registers)
1837         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1838         (ppc_ravenscar_powerpc_ops): Redefine.
1839         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1840         (ppc_ravenscar_e500_ops::fetch_registers)
1841         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1842         (ppc_ravenscar_e500_ops): Redefine.
1843         * aarch64-ravenscar-thread.c
1844         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1845         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1846         (aarch64_ravenscar_fetch_registers)
1847         (aarch64_ravenscar_store_registers): Now methods.
1848         (aarch64_ravenscar_ops): Redefine.
1849
1850 2019-02-15  Tom Tromey  <tromey@adacore.com>
1851
1852         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1853         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1854         (ravenscar_thread_target::stopped_by_watchpoint)
1855         (ravenscar_thread_target::stopped_data_address)
1856         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1857
1858 2019-02-15  Tom Tromey  <tromey@adacore.com>
1859
1860         * ravenscar-thread.c: Fix some typos.
1861
1862 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1863             Tom Tromey  <tromey@adacore.com>
1864
1865         * ada-lang.c (ada_exception_sal): Change addr_string to a
1866         std::string.
1867         (create_ada_exception_catchpoint): Update.
1868
1869 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1870             Tom Tromey  <tromey@adacore.com>
1871
1872         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1873         (bp_location_ops): Remove.
1874         (base_breakpoint_allocate_location): Update.
1875         (free_bp_location): Update.
1876         * ada-lang.c (class ada_catchpoint_location)
1877         <ada_catchpoint_location>: Remove ops parameter.
1878         (ada_catchpoint_location_dtor): Remove.
1879         (ada_catchpoint_location_ops): Remove.
1880         (allocate_location_exception): Update.
1881         * breakpoint.h (struct bp_location_ops): Remove.
1882         (class bp_location) <bp_location>: Remove bp_location_ops
1883         parameter.
1884         <~bp_location>: Add destructor.
1885         <ops>: Remove.
1886
1887 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1888             Pedro Alves  <palves@redhat.com>
1889
1890         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1891         'PATH_MAX'.
1892
1893 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1894             Samuel Thibault  <samuel.thibault@gnu.org>
1895             Thomas Schwinge  <thomas@codesourcery.com>
1896
1897         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1898         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1899
1900 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1901
1902         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1903         (check_empty): Use "const char *".
1904
1905         * gnu-nat.c (gnu_nat_target::detach): Instead of
1906         'detach_inferior (pid)' call
1907         'detach_inferior (find_inferior_pid (pid))'.
1908
1909         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1910         'nat/fork-inferior.o'.
1911         * gnu-nat.c: #include "nat/fork-inferior.h".
1912
1913         * gnu-nat.c (gnu_nat_target::detach): Instead of
1914         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1915         * gnu-nat.h: #include "inf-child.h".
1916         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1917         'i386_gnu_nat_target::fetch_registers'.
1918         (gnu_store_registers): Rename/move to
1919         'i386_gnu_nat_target::store_registers'.
1920
1921         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1922         * gnu-nat.h (mach_thread_info): New function.
1923         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1924
1925         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1926
1927 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1928
1929         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1930
1931 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1932
1933         * windows-nat.c (windows_add_thread): Add new parameter
1934         "main_thread_p" with default value set to false.  Update
1935         function documentation as well as all callers.
1936         (windows_delete_thread): Likewise.
1937         (fake_create_process): Update call to windows_add_thread.
1938         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1939         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1940         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1941         call to windows_delete_thread.
1942
1943 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1944
1945         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1946
1947 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1948
1949         * symfile.c (find_separate_debug_file): Use canonical path of
1950         sysroot with child_path instead of gdb_sysroot if it is valid.
1951
1952 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1953
1954         * symfile.c (find_separate_debug_file): Use child_path to
1955         determine if an object file is under a sysroot.
1956
1957 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1958
1959         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1960         unittests/child-path-selftests.c.
1961         * common/pathstuff.c (child_path): New function.
1962         * common/pathstuff.h (child_path): New prototype.
1963         * unittests/child-path-selftests.c: New file.
1964
1965 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1966
1967         * symfile.c (find_separate_debug_file): Look for separate debug
1968         files in debug directories under the sysroot.
1969
1970 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1971
1972         * symtab.h (struct minimal_symbol data_p): New const method.
1973         (struct minimal_symbol text_p): Likewise.
1974         * symtab.c (output_source_filename): Use file name style
1975         to print file name.
1976         (print_symbol_info): Likewise.
1977         (print_msymbol_info): Use address style to print addresses.
1978         Use function name style to print executable text symbols.
1979         (expand_symtab_containing_pc): Use data_p.
1980         (find_pc_sect_compunit_symtab): Likewise.
1981
1982 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1983
1984         * breakpoint.c (describe_other_breakpoints): Use address style
1985         to print addresses.
1986         (say_where): Likewise.
1987
1988 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1989
1990         * ada-typeprint.c (print_func_type): Print function name
1991         style to print function name.
1992         * c-typeprint.c (c_print_type_1): Likewise.
1993
1994 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1995
1996         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1997         for execve.
1998
1999 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2000
2001         * c-exp.y (direct_abs_decl): Use emplace_back to record the
2002         type_stack.
2003
2004 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
2005
2006         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
2007         TYPE_CODE_REF types.
2008
2009 2019-02-08  Jim Wilson  <jimw@sifive.com>
2010
2011         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
2012         (riscv_linux_fregset): New.
2013         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
2014
2015 2019-02-07  Tom Tromey  <tom@tromey.com>
2016
2017         * thread.c (thread_cancel_execution_command): Update.
2018         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
2019         methods.
2020         (struct thread_fsm_ops): Remove.
2021         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
2022         (thread_fsm_should_stop, thread_fsm_return_value)
2023         (thread_fsm_set_finished, thread_fsm_finished_p)
2024         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
2025         Don't declare.
2026         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
2027         * infrun.c (clear_proceed_status_thread)
2028         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
2029         (print_stop_event): Update.
2030         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
2031         Add constructor.
2032         (step_command_fsm_ops): Remove.
2033         (new_step_command_fsm): Remove.
2034         (step_1): Update.
2035         (step_command_fsm::should_stop): Rename from
2036         step_command_fsm_should_stop.
2037         (step_command_fsm::clean_up): Rename from
2038         step_command_fsm_clean_up.
2039         (step_command_fsm::do_async_reply_reason): Rename from
2040         step_command_fsm_async_reply_reason.
2041         (struct until_next_fsm): Inherit from thread_fsm.  Add
2042         constructor.
2043         (until_next_fsm_ops): Remove.
2044         (new_until_next_fsm): Remove.
2045         (until_next_fsm::should_stop): Rename from
2046         until_next_fsm_should_stop.
2047         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
2048         (until_next_fsm::do_async_reply_reason): Rename from
2049         until_next_fsm_async_reply_reason.
2050         (struct finish_command_fsm): Inherit from thread_fsm.  Add
2051         constructor.  Change type of breakpoint.
2052         (finish_command_fsm_ops): Remove.
2053         (new_finish_command_fsm): Remove.
2054         (finish_command_fsm::should_stop): Rename from
2055         finish_command_fsm_should_stop.
2056         (finish_command_fsm::clean_up): Rename from
2057         finish_command_fsm_clean_up.
2058         (finish_command_fsm::return_value): Rename from
2059         finish_command_fsm_return_value.
2060         (finish_command_fsm::do_async_reply_reason): Rename from
2061         finish_command_fsm_async_reply_reason.
2062         (finish_command): Update.
2063         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
2064         Add constructor.
2065         (call_thread_fsm_ops): Remove.
2066         (call_thread_fsm::call_thread_fsm): Rename from
2067         new_call_thread_fsm.
2068         (call_thread_fsm::should_stop): Rename from
2069         call_thread_fsm_should_stop.
2070         (call_thread_fsm::should_notify_stop): Rename from
2071         call_thread_fsm_should_notify_stop.
2072         (run_inferior_call, call_function_by_hand_dummy): Update.
2073         * cli/cli-interp.c (should_print_stop_to_console): Update.
2074         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
2075         Add constructor.  Change type of location_breakpoint,
2076         caller_breakpoint.
2077         (until_break_fsm_ops): Remove.
2078         (new_until_break_fsm): Remove.
2079         (until_break_fsm::should_stop): Rename from
2080         until_break_fsm_should_stop.
2081         (until_break_fsm::clean_up): Rename from
2082         until_break_fsm_clean_up.
2083         (until_break_fsm::do_async_reply_reason): Rename from
2084         until_break_fsm_async_reply_reason.
2085         (until_break_command): Update.
2086         * thread-fsm.c: Remove.
2087         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
2088
2089 2019-02-07  Tom Tromey  <tom@tromey.com>
2090
2091         * yy-remap.h: Add include guard.
2092         * xtensa-tdep.h: Add include guard.
2093         * xcoffread.h: Rename include guard.
2094         * varobj-iter.h: Add include guard.
2095         * tui/tui.h: Rename include guard.
2096         * tui/tui-winsource.h: Rename include guard.
2097         * tui/tui-wingeneral.h: Rename include guard.
2098         * tui/tui-windata.h: Rename include guard.
2099         * tui/tui-win.h: Rename include guard.
2100         * tui/tui-stack.h: Rename include guard.
2101         * tui/tui-source.h: Rename include guard.
2102         * tui/tui-regs.h: Rename include guard.
2103         * tui/tui-out.h: Rename include guard.
2104         * tui/tui-layout.h: Rename include guard.
2105         * tui/tui-io.h: Rename include guard.
2106         * tui/tui-hooks.h: Rename include guard.
2107         * tui/tui-file.h: Rename include guard.
2108         * tui/tui-disasm.h: Rename include guard.
2109         * tui/tui-data.h: Rename include guard.
2110         * tui/tui-command.h: Rename include guard.
2111         * tic6x-tdep.h: Add include guard.
2112         * target/waitstatus.h: Rename include guard.
2113         * target/wait.h: Rename include guard.
2114         * target/target.h: Rename include guard.
2115         * target/resume.h: Rename include guard.
2116         * target-float.h: Rename include guard.
2117         * stabsread.h: Add include guard.
2118         * rs6000-tdep.h: Add include guard.
2119         * riscv-fbsd-tdep.h: Add include guard.
2120         * regformats/regdef.h: Rename include guard.
2121         * record.h: Rename include guard.
2122         * python/python.h: Rename include guard.
2123         * python/python-internal.h: Rename include guard.
2124         * python/py-stopevent.h: Rename include guard.
2125         * python/py-ref.h: Rename include guard.
2126         * python/py-record.h: Rename include guard.
2127         * python/py-record-full.h: Rename include guard.
2128         * python/py-record-btrace.h: Rename include guard.
2129         * python/py-instruction.h: Rename include guard.
2130         * python/py-events.h: Rename include guard.
2131         * python/py-event.h: Rename include guard.
2132         * procfs.h: Add include guard.
2133         * proc-utils.h: Add include guard.
2134         * p-lang.h: Add include guard.
2135         * or1k-tdep.h: Rename include guard.
2136         * observable.h: Rename include guard.
2137         * nto-tdep.h: Rename include guard.
2138         * nat/x86-linux.h: Rename include guard.
2139         * nat/x86-linux-dregs.h: Rename include guard.
2140         * nat/x86-gcc-cpuid.h: Add include guard.
2141         * nat/x86-dregs.h: Rename include guard.
2142         * nat/x86-cpuid.h: Rename include guard.
2143         * nat/ppc-linux.h: Rename include guard.
2144         * nat/mips-linux-watch.h: Rename include guard.
2145         * nat/linux-waitpid.h: Rename include guard.
2146         * nat/linux-ptrace.h: Rename include guard.
2147         * nat/linux-procfs.h: Rename include guard.
2148         * nat/linux-osdata.h: Rename include guard.
2149         * nat/linux-nat.h: Rename include guard.
2150         * nat/linux-namespaces.h: Rename include guard.
2151         * nat/linux-btrace.h: Rename include guard.
2152         * nat/glibc_thread_db.h: Rename include guard.
2153         * nat/gdb_thread_db.h: Rename include guard.
2154         * nat/gdb_ptrace.h: Rename include guard.
2155         * nat/fork-inferior.h: Rename include guard.
2156         * nat/amd64-linux-siginfo.h: Rename include guard.
2157         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
2158         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
2159         * nat/aarch64-linux.h: Rename include guard.
2160         * nat/aarch64-linux-hw-point.h: Rename include guard.
2161         * mn10300-tdep.h: Add include guard.
2162         * mips-linux-tdep.h: Add include guard.
2163         * mi/mi-parse.h: Rename include guard.
2164         * mi/mi-out.h: Rename include guard.
2165         * mi/mi-main.h: Rename include guard.
2166         * mi/mi-interp.h: Rename include guard.
2167         * mi/mi-getopt.h: Rename include guard.
2168         * mi/mi-console.h: Rename include guard.
2169         * mi/mi-common.h: Rename include guard.
2170         * mi/mi-cmds.h: Rename include guard.
2171         * mi/mi-cmd-break.h: Rename include guard.
2172         * m2-lang.h: Add include guard.
2173         * location.h: Rename include guard.
2174         * linux-record.h: Rename include guard.
2175         * linux-nat.h: Add include guard.
2176         * linux-fork.h: Add include guard.
2177         * i386-darwin-tdep.h: Rename include guard.
2178         * hppa-linux-offsets.h: Add include guard.
2179         * guile/guile.h: Rename include guard.
2180         * guile/guile-internal.h: Rename include guard.
2181         * gnu-nat.h: Rename include guard.
2182         * gdb-stabs.h: Rename include guard.
2183         * frv-tdep.h: Add include guard.
2184         * f-lang.h: Add include guard.
2185         * event-loop.h: Add include guard.
2186         * darwin-nat.h: Rename include guard.
2187         * cp-abi.h: Rename include guard.
2188         * config/sparc/nm-sol2.h: Rename include guard.
2189         * config/nm-nto.h: Rename include guard.
2190         * config/nm-linux.h: Add include guard.
2191         * config/i386/nm-i386gnu.h: Rename include guard.
2192         * config/djgpp/nl_types.h: Rename include guard.
2193         * config/djgpp/langinfo.h: Rename include guard.
2194         * compile/gcc-cp-plugin.h: Add include guard.
2195         * compile/gcc-c-plugin.h: Add include guard.
2196         * compile/compile.h: Rename include guard.
2197         * compile/compile-object-run.h: Rename include guard.
2198         * compile/compile-object-load.h: Rename include guard.
2199         * compile/compile-internal.h: Rename include guard.
2200         * compile/compile-cplus.h: Rename include guard.
2201         * compile/compile-c.h: Rename include guard.
2202         * common/xml-utils.h: Rename include guard.
2203         * common/x86-xstate.h: Rename include guard.
2204         * common/version.h: Rename include guard.
2205         * common/vec.h: Rename include guard.
2206         * common/tdesc.h: Rename include guard.
2207         * common/selftest.h: Rename include guard.
2208         * common/scoped_restore.h: Rename include guard.
2209         * common/scoped_mmap.h: Rename include guard.
2210         * common/scoped_fd.h: Rename include guard.
2211         * common/safe-iterator.h: Rename include guard.
2212         * common/run-time-clock.h: Rename include guard.
2213         * common/refcounted-object.h: Rename include guard.
2214         * common/queue.h: Rename include guard.
2215         * common/ptid.h: Rename include guard.
2216         * common/print-utils.h: Rename include guard.
2217         * common/preprocessor.h: Rename include guard.
2218         * common/pathstuff.h: Rename include guard.
2219         * common/observable.h: Rename include guard.
2220         * common/netstuff.h: Rename include guard.
2221         * common/job-control.h: Rename include guard.
2222         * common/host-defs.h: Rename include guard.
2223         * common/gdb_wait.h: Rename include guard.
2224         * common/gdb_vecs.h: Rename include guard.
2225         * common/gdb_unlinker.h: Rename include guard.
2226         * common/gdb_unique_ptr.h: Rename include guard.
2227         * common/gdb_tilde_expand.h: Rename include guard.
2228         * common/gdb_sys_time.h: Rename include guard.
2229         * common/gdb_string_view.h: Rename include guard.
2230         * common/gdb_splay_tree.h: Rename include guard.
2231         * common/gdb_setjmp.h: Rename include guard.
2232         * common/gdb_ref_ptr.h: Rename include guard.
2233         * common/gdb_optional.h: Rename include guard.
2234         * common/gdb_locale.h: Rename include guard.
2235         * common/gdb_assert.h: Rename include guard.
2236         * common/filtered-iterator.h: Rename include guard.
2237         * common/filestuff.h: Rename include guard.
2238         * common/fileio.h: Rename include guard.
2239         * common/environ.h: Rename include guard.
2240         * common/common-utils.h: Rename include guard.
2241         * common/common-types.h: Rename include guard.
2242         * common/common-regcache.h: Rename include guard.
2243         * common/common-inferior.h: Rename include guard.
2244         * common/common-gdbthread.h: Rename include guard.
2245         * common/common-exceptions.h: Rename include guard.
2246         * common/common-defs.h: Rename include guard.
2247         * common/common-debug.h: Rename include guard.
2248         * common/cleanups.h: Rename include guard.
2249         * common/buffer.h: Rename include guard.
2250         * common/btrace-common.h: Rename include guard.
2251         * common/break-common.h: Rename include guard.
2252         * cli/cli-utils.h: Rename include guard.
2253         * cli/cli-style.h: Rename include guard.
2254         * cli/cli-setshow.h: Rename include guard.
2255         * cli/cli-script.h: Rename include guard.
2256         * cli/cli-interp.h: Rename include guard.
2257         * cli/cli-decode.h: Rename include guard.
2258         * cli/cli-cmds.h: Rename include guard.
2259         * charset-list.h: Add include guard.
2260         * buildsym-legacy.h: Rename include guard.
2261         * bfin-tdep.h: Add include guard.
2262         * ax.h: Rename include guard.
2263         * arm-linux-tdep.h: Add include guard.
2264         * arm-fbsd-tdep.h: Add include guard.
2265         * arch/xtensa.h: Rename include guard.
2266         * arch/tic6x.h: Add include guard.
2267         * arch/i386.h: Add include guard.
2268         * arch/arm.h: Rename include guard.
2269         * arch/arm-linux.h: Rename include guard.
2270         * arch/arm-get-next-pcs.h: Rename include guard.
2271         * arch/amd64.h: Add include guard.
2272         * arch/aarch64-insn.h: Rename include guard.
2273         * arch-utils.h: Rename include guard.
2274         * annotate.h: Add include guard.
2275         * amd64-darwin-tdep.h: Rename include guard.
2276         * aarch64-linux-tdep.h: Add include guard.
2277         * aarch64-fbsd-tdep.h: Add include guard.
2278         * aarch32-linux-nat.h: Add include guard.
2279
2280 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2281
2282         * macrotab.c (macro_define_internal): New function that
2283         factorizes macro_define_object_internal and macro_define_function
2284         code.
2285         (macro_define_object_internal): Use macro_define_internal.
2286         (macro_define_function): Likewise.
2287
2288 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2289
2290         * macrocmd.c (extract_identifier): Return
2291         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2292         callers.
2293
2294 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2295
2296         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2297
2298 2019-02-05  Tom Tromey  <tom@tromey.com>
2299
2300         * target.c (target_stack::unpush): Move assertion earlier.
2301
2302 2019-01-30  Tom Tromey  <tom@tromey.com>
2303
2304         PR python/23615:
2305         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2306         (gdbpy_parse_and_eval): Likewise.
2307         * python/python-internal.h (gdbpy_allow_threads): New class.
2308
2309 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2310
2311         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2312         (aarch64_fbsd_fpregmap): Move earlier.
2313         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2314         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2315         instead of individual calls to trad_frame_set_reg_addr.
2316         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2317         earlier.
2318         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2319         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2320         instead of individual calls to trad_frame_set_reg_addr.
2321
2322 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2323
2324         * CONTRIBUTE: Replace contribution list with wiki link.
2325
2326 2019-01-25  Tom Tromey  <tom@tromey.com>
2327
2328         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2329
2330 2019-01-25  Tom Tromey  <tom@tromey.com>
2331
2332         * xtensa-linux-nat.c: Fix common/ includes.
2333         * xml-support.h: Fix common/ includes.
2334         * xml-support.c: Fix common/ includes.
2335         * x86-linux-nat.c: Fix common/ includes.
2336         * windows-nat.c: Fix common/ includes.
2337         * varobj.h: Fix common/ includes.
2338         * varobj.c: Fix common/ includes.
2339         * value.c: Fix common/ includes.
2340         * valops.c: Fix common/ includes.
2341         * utils.c: Fix common/ includes.
2342         * unittests/xml-utils-selftests.c: Fix common/ includes.
2343         * unittests/utils-selftests.c: Fix common/ includes.
2344         * unittests/unpack-selftests.c: Fix common/ includes.
2345         * unittests/tracepoint-selftests.c: Fix common/ includes.
2346         * unittests/style-selftests.c: Fix common/ includes.
2347         * unittests/string_view-selftests.c: Fix common/ includes.
2348         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2349         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2350         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2351         * unittests/rsp-low-selftests.c: Fix common/ includes.
2352         * unittests/parse-connection-spec-selftests.c: Fix common/
2353         includes.
2354         * unittests/optional-selftests.c: Fix common/ includes.
2355         * unittests/offset-type-selftests.c: Fix common/ includes.
2356         * unittests/observable-selftests.c: Fix common/ includes.
2357         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2358         * unittests/memrange-selftests.c: Fix common/ includes.
2359         * unittests/memory-map-selftests.c: Fix common/ includes.
2360         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2361         * unittests/function-view-selftests.c: Fix common/ includes.
2362         * unittests/environ-selftests.c: Fix common/ includes.
2363         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2364         * unittests/common-utils-selftests.c: Fix common/ includes.
2365         * unittests/cli-utils-selftests.c: Fix common/ includes.
2366         * unittests/array-view-selftests.c: Fix common/ includes.
2367         * ui-file.c: Fix common/ includes.
2368         * tui/tui-io.c: Fix common/ includes.
2369         * tracepoint.h: Fix common/ includes.
2370         * tracepoint.c: Fix common/ includes.
2371         * tracefile-tfile.c: Fix common/ includes.
2372         * top.h: Fix common/ includes.
2373         * top.c: Fix common/ includes.
2374         * thread.c: Fix common/ includes.
2375         * target/waitstatus.h: Fix common/ includes.
2376         * target/waitstatus.c: Fix common/ includes.
2377         * target.h: Fix common/ includes.
2378         * target.c: Fix common/ includes.
2379         * target-memory.c: Fix common/ includes.
2380         * target-descriptions.c: Fix common/ includes.
2381         * symtab.h: Fix common/ includes.
2382         * symfile.c: Fix common/ includes.
2383         * stap-probe.c: Fix common/ includes.
2384         * spu-linux-nat.c: Fix common/ includes.
2385         * sparc-nat.c: Fix common/ includes.
2386         * source.c: Fix common/ includes.
2387         * solib.c: Fix common/ includes.
2388         * solib-target.c: Fix common/ includes.
2389         * ser-unix.c: Fix common/ includes.
2390         * ser-tcp.c: Fix common/ includes.
2391         * ser-pipe.c: Fix common/ includes.
2392         * ser-base.c: Fix common/ includes.
2393         * selftest-arch.c: Fix common/ includes.
2394         * s12z-tdep.c: Fix common/ includes.
2395         * rust-exp.y: Fix common/ includes.
2396         * rs6000-aix-tdep.c: Fix common/ includes.
2397         * riscv-tdep.c: Fix common/ includes.
2398         * remote.c: Fix common/ includes.
2399         * remote-notif.h: Fix common/ includes.
2400         * remote-fileio.h: Fix common/ includes.
2401         * remote-fileio.c: Fix common/ includes.
2402         * regcache.h: Fix common/ includes.
2403         * regcache.c: Fix common/ includes.
2404         * record-btrace.c: Fix common/ includes.
2405         * python/python.c: Fix common/ includes.
2406         * python/py-type.c: Fix common/ includes.
2407         * python/py-inferior.c: Fix common/ includes.
2408         * progspace.h: Fix common/ includes.
2409         * producer.c: Fix common/ includes.
2410         * procfs.c: Fix common/ includes.
2411         * proc-api.c: Fix common/ includes.
2412         * printcmd.c: Fix common/ includes.
2413         * ppc-linux-nat.c: Fix common/ includes.
2414         * parser-defs.h: Fix common/ includes.
2415         * osdata.c: Fix common/ includes.
2416         * obsd-nat.c: Fix common/ includes.
2417         * nat/x86-linux.c: Fix common/ includes.
2418         * nat/x86-linux-dregs.c: Fix common/ includes.
2419         * nat/x86-dregs.h: Fix common/ includes.
2420         * nat/x86-dregs.c: Fix common/ includes.
2421         * nat/ppc-linux.c: Fix common/ includes.
2422         * nat/mips-linux-watch.h: Fix common/ includes.
2423         * nat/mips-linux-watch.c: Fix common/ includes.
2424         * nat/linux-waitpid.c: Fix common/ includes.
2425         * nat/linux-ptrace.h: Fix common/ includes.
2426         * nat/linux-ptrace.c: Fix common/ includes.
2427         * nat/linux-procfs.c: Fix common/ includes.
2428         * nat/linux-personality.c: Fix common/ includes.
2429         * nat/linux-osdata.c: Fix common/ includes.
2430         * nat/linux-namespaces.c: Fix common/ includes.
2431         * nat/linux-btrace.h: Fix common/ includes.
2432         * nat/linux-btrace.c: Fix common/ includes.
2433         * nat/fork-inferior.c: Fix common/ includes.
2434         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2435         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2436         * nat/aarch64-linux.c: Fix common/ includes.
2437         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2438         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2439         * namespace.h: Fix common/ includes.
2440         * mips-linux-tdep.c: Fix common/ includes.
2441         * minsyms.c: Fix common/ includes.
2442         * mi/mi-parse.h: Fix common/ includes.
2443         * mi/mi-main.c: Fix common/ includes.
2444         * mi/mi-cmd-env.c: Fix common/ includes.
2445         * memrange.h: Fix common/ includes.
2446         * memattr.c: Fix common/ includes.
2447         * maint.h: Fix common/ includes.
2448         * maint.c: Fix common/ includes.
2449         * main.c: Fix common/ includes.
2450         * machoread.c: Fix common/ includes.
2451         * location.c: Fix common/ includes.
2452         * linux-thread-db.c: Fix common/ includes.
2453         * linux-nat.c: Fix common/ includes.
2454         * linux-fork.c: Fix common/ includes.
2455         * inline-frame.c: Fix common/ includes.
2456         * infrun.c: Fix common/ includes.
2457         * inflow.c: Fix common/ includes.
2458         * inferior.h: Fix common/ includes.
2459         * inferior.c: Fix common/ includes.
2460         * infcmd.c: Fix common/ includes.
2461         * inf-ptrace.c: Fix common/ includes.
2462         * inf-child.c: Fix common/ includes.
2463         * ia64-linux-nat.c: Fix common/ includes.
2464         * i387-tdep.c: Fix common/ includes.
2465         * i386-tdep.c: Fix common/ includes.
2466         * i386-linux-tdep.c: Fix common/ includes.
2467         * i386-linux-nat.c: Fix common/ includes.
2468         * i386-go32-tdep.c: Fix common/ includes.
2469         * i386-fbsd-tdep.c: Fix common/ includes.
2470         * i386-fbsd-nat.c: Fix common/ includes.
2471         * guile/scm-type.c: Fix common/ includes.
2472         * guile/guile.c: Fix common/ includes.
2473         * go32-nat.c: Fix common/ includes.
2474         * gnu-nat.c: Fix common/ includes.
2475         * gdbthread.h: Fix common/ includes.
2476         * gdbarch-selftests.c: Fix common/ includes.
2477         * gdb_usleep.c: Fix common/ includes.
2478         * gdb_select.h: Fix common/ includes.
2479         * gdb_bfd.c: Fix common/ includes.
2480         * gcore.c: Fix common/ includes.
2481         * fork-child.c: Fix common/ includes.
2482         * findvar.c: Fix common/ includes.
2483         * fbsd-nat.c: Fix common/ includes.
2484         * event-top.c: Fix common/ includes.
2485         * event-loop.c: Fix common/ includes.
2486         * dwarf2read.c: Fix common/ includes.
2487         * dwarf2loc.c: Fix common/ includes.
2488         * dwarf2-frame.c: Fix common/ includes.
2489         * dwarf-index-cache.c: Fix common/ includes.
2490         * dtrace-probe.c: Fix common/ includes.
2491         * disasm-selftests.c: Fix common/ includes.
2492         * defs.h: Fix common/ includes.
2493         * csky-tdep.c: Fix common/ includes.
2494         * cp-valprint.c: Fix common/ includes.
2495         * cp-support.h: Fix common/ includes.
2496         * cp-support.c: Fix common/ includes.
2497         * corelow.c: Fix common/ includes.
2498         * completer.h: Fix common/ includes.
2499         * completer.c: Fix common/ includes.
2500         * compile/compile.c: Fix common/ includes.
2501         * compile/compile-loc2c.c: Fix common/ includes.
2502         * compile/compile-cplus-types.c: Fix common/ includes.
2503         * compile/compile-cplus-symbols.c: Fix common/ includes.
2504         * command.h: Fix common/ includes.
2505         * cli/cli-dump.c: Fix common/ includes.
2506         * cli/cli-cmds.c: Fix common/ includes.
2507         * charset.c: Fix common/ includes.
2508         * build-id.c: Fix common/ includes.
2509         * btrace.h: Fix common/ includes.
2510         * btrace.c: Fix common/ includes.
2511         * breakpoint.h: Fix common/ includes.
2512         * breakpoint.c: Fix common/ includes.
2513         * ax.h:
2514         (enum agent_op): Fix common/ includes.
2515         * ax-general.c (struct aop_map): Fix common/ includes.
2516         * ax-gdb.c: Fix common/ includes.
2517         * auxv.c: Fix common/ includes.
2518         * auto-load.c: Fix common/ includes.
2519         * arm-tdep.c: Fix common/ includes.
2520         * arch/riscv.c: Fix common/ includes.
2521         * arch/ppc-linux-common.c: Fix common/ includes.
2522         * arch/i386.c: Fix common/ includes.
2523         * arch/arm.c: Fix common/ includes.
2524         * arch/arm-linux.c: Fix common/ includes.
2525         * arch/arm-get-next-pcs.c: Fix common/ includes.
2526         * arch/amd64.c: Fix common/ includes.
2527         * arch/aarch64.c: Fix common/ includes.
2528         * arch/aarch64-insn.c: Fix common/ includes.
2529         * arch-utils.c: Fix common/ includes.
2530         * amd64-windows-tdep.c: Fix common/ includes.
2531         * amd64-tdep.c: Fix common/ includes.
2532         * amd64-sol2-tdep.c: Fix common/ includes.
2533         * amd64-obsd-tdep.c: Fix common/ includes.
2534         * amd64-nbsd-tdep.c: Fix common/ includes.
2535         * amd64-linux-tdep.c: Fix common/ includes.
2536         * amd64-linux-nat.c: Fix common/ includes.
2537         * amd64-fbsd-tdep.c: Fix common/ includes.
2538         * amd64-fbsd-nat.c: Fix common/ includes.
2539         * amd64-dicos-tdep.c: Fix common/ includes.
2540         * amd64-darwin-tdep.c: Fix common/ includes.
2541         * agent.c: Fix common/ includes.
2542         * ada-lang.h: Fix common/ includes.
2543         * ada-lang.c: Fix common/ includes.
2544         * aarch64-tdep.c: Fix common/ includes.
2545
2546 2019-01-25  Tom Tromey  <tom@tromey.com>
2547
2548         * common/create-version.sh: Use common/version.h.
2549
2550 2019-01-24  Pedro Alves  <palves@redhat.com>
2551
2552         * infrun.c (signal_stop, signal_print, signal_program)
2553         (signal_catch, signal_pass): Now arrays instead of pointers.
2554         (update_signals_program_target, do_target_resume)
2555         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2556         * linux-nat.c (linux_nat_target::pass_signals)
2557         (linux_nat_target::create_inferior, linux_nat_target::attach):
2558         Adjust.
2559         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2560         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2561         * procfs.c (procfs_target::pass_signals): Adjust.
2562         * record-full.c (record_full_target::resume): Adjust.
2563         * remote.c (remote_target::pass_signals)
2564         (remote_target::program_signals): Adjust.
2565         * target-debug.h (target_debug_print_signals): Now takes a
2566         gdb::array_view as parameter.  Adjust.
2567         * target.h (target_ops) <pass_signals, program_signals>: Replace
2568         pointer and length parameters with gdb::array_view.
2569         (target_pass_signals, target_program_signals): Likewise.
2570         * target-delegates.c: Regenerate.
2571
2572 2019-01-24  Pedro Alves  <palves@redhat.com>
2573
2574         * common/forward-scope-exit.h
2575         (forward_scope_exit::forward_scope_exit): Pass arguments to
2576         m_bind_function directly, instead of creating a std::bind and
2577         copying that.
2578
2579 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2580
2581         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2582         for static members.
2583         (pass_in_v_vfp_candidate): Likewise.
2584
2585 2019-01-23  Tom Tromey  <tom@tromey.com>
2586             Pedro Alves  <palves@redhat.com>
2587
2588         * regcache.c (class regcache_invalidator): Remove.
2589         (regcache::raw_write): Use make_scope_exit.
2590
2591 2019-01-23  Tom Tromey  <tom@tromey.com>
2592
2593         * ui-out.h (class ui_out_emit_type): Update comment.
2594
2595 2019-01-23  Tom Tromey  <tom@tromey.com>
2596
2597         * infrun.c (fetch_inferior_event): Update comment.
2598
2599 2019-01-23  Tom Tromey  <tom@tromey.com>
2600             Pedro Alves  <palves@redhat.com>
2601
2602         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2603         parameter.
2604         (fetch_inferior_event): Use SCOPE_EXIT.
2605
2606
2607 2019-01-23  Tom Tromey  <tom@tromey.com>
2608             Pedro Alves  <palves@redhat.com>
2609
2610         * infrun.c (disable_thread_events): Delete.
2611         (stop_all_threads): Use SCOPE_EXIT.
2612
2613 2019-01-23  Tom Tromey  <tom@tromey.com>
2614             Pedro Alves  <palves@redhat.com>
2615
2616         * symfile.c: Include forward-scope-exit.h.
2617         (clear_symtab_users_cleanup): Replace forward declaration with
2618         a FORWARD_SCOPE_EXIT.
2619         (syms_from_objfile_1): Use the forward_scope_exit and
2620         gdb::optional instead of cleanup_function.
2621         (reread_symbols): Use the forward_scope_exit instead of
2622         cleanup_function.
2623         (clear_symtab_users_cleanup): Remove function.
2624
2625 2019-01-23  Tom Tromey  <tom@tromey.com>
2626             Pedro Alves  <palves@redhat.com>
2627
2628         * linux-nat.c: Include scope-exit.h.
2629         (cleanup_target_stop): Remove.
2630         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2631         SCOPE_EXIT.
2632
2633 2019-01-23  Tom Tromey  <tom@tromey.com>
2634             Pedro Alves  <palves@redhat.com>
2635
2636         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2637         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2638
2639 2019-01-23  Tom Tromey  <tom@tromey.com>
2640             Andrew Burgess  <andrew.burgess@embecosm.com>
2641             Pedro Alves  <palves@redhat.com>
2642
2643         * infrun.c (fetch_inferior_event): Use scope_exit.
2644         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2645         * top.c (execute_command): Use scope_exit.
2646         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2647         * utils.c (do_bpstat_clear_actions_cleanup)
2648         (make_bpstat_clear_actions_cleanup): Remove.
2649
2650 2019-01-23  Tom Tromey  <tom@tromey.com>
2651             Pedro Alves  <palves@redhat.com>
2652
2653         * infrun.c: Include "common/scope-exit.h"
2654         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2655         (wait_for_inferior): Use SCOPE_EXIT.
2656         (fetch_inferior_event): Use scope_exit.
2657
2658 2019-01-23  Tom Tromey  <tom@tromey.com>
2659             Pedro Alves  <palves@redhat.com>
2660
2661         * breakpoint.c (create_breakpoint): Remove cleanup.
2662
2663 2019-01-23  Tom Tromey  <tom@tromey.com>
2664             Andrew Burgess  <andrew.burgess@embecosm.com>
2665             Pedro Alves  <palves@redhat.com>
2666
2667 2019-01-23  Pedro Alves  <palves@redhat.com>
2668
2669         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2670
2671 2019-01-23  Pedro Alves  <palves@redhat.com>
2672             Andrew Burgess  <andrew.burgess@embecosm.com>
2673
2674         * gdbthread.h: Include "common/forward-scope-exit.h".
2675         (scoped_finish_thread_state): Redefine custom class in terms of
2676         forward_scope_exit.
2677
2678 2019-01-23  Pedro Alves  <palves@redhat.com>
2679             Andrew Burgess  <andrew.burgess@embecosm.com>
2680
2681         * common/forward-scope-exit.h: New file.
2682
2683 2019-01-23  Pedro Alves  <palves@redhat.com>
2684             Andrew Burgess  <andrew.burgess@embecosm.com>
2685             Tom Tromey  <tom@tromey.com>
2686
2687         * common/scope-exit.h: New file.
2688
2689 2019-01-23  Pedro Alves  <palves@redhat.com>
2690
2691         * common/preprocessor.h (ESC): Rename to ...
2692         (ESC_PARENS): ... this.
2693         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2694         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2695
2696 2019-01-23  Tom Tromey  <tom@tromey.com>
2697
2698         * language.h (class scoped_switch_to_sym_language_if_auto):
2699         Initialize m_lang in both cases.
2700
2701 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2702
2703         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2704         with XCNEW.
2705
2706 2019-01-22  Tom Tromey  <tom@tromey.com>
2707
2708         * corelow.c: Do not include sys/file.h.
2709
2710 2019-01-22  Tom Tromey  <tom@tromey.com>
2711
2712         * tui/tui-wingeneral.h: Include gdb_curses.h.
2713
2714 2019-01-22  Tom Tromey  <tom@tromey.com>
2715
2716         * source-cache.h (class source_cache) <get_source_lines,
2717         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2718
2719 2019-01-22  Tom Tromey  <tom@tromey.com>
2720
2721         * remote-fileio.h (struct remote_target): Declare.
2722
2723 2019-01-22  Tom Tromey  <tom@tromey.com>
2724
2725         * python/py-arch.c: Do not include py-ref.h.
2726         * python/py-bpevent.c: Do not include py-ref.h.
2727         * python/py-cmd.c: Do not include py-ref.h.
2728         * python/py-continueevent.c: Do not include py-ref.h.
2729         * python/py-event.h: Do not include py-ref.h.
2730         * python/py-evtregistry.c: Do not include py-ref.h.
2731         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2732         * python/py-frame.c: Do not include py-ref.h.
2733         * python/py-framefilter.c: Do not include py-ref.h.
2734         * python/py-function.c: Do not include py-ref.h.
2735         * python/py-infevents.c: Do not include py-ref.h.
2736         * python/py-linetable.c: Do not include py-ref.h.
2737         * python/py-objfile.c: Do not include py-ref.h.
2738         * python/py-param.c: Do not include py-ref.h.
2739         * python/py-prettyprint.c: Do not include py-ref.h.
2740         * python/py-progspace.c: Do not include py-ref.h.
2741         * python/py-symbol.c: Do not include py-ref.h.
2742         * python/py-symtab.c: Do not include py-ref.h.
2743         * python/py-type.c: Do not include py-ref.h.
2744         * python/py-unwind.c: Do not include py-ref.h.
2745         * python/py-utils.c: Do not include py-ref.h.
2746         * python/py-value.c: Do not include py-ref.h.
2747         * python/py-varobj.c: Do not include py-ref.h.
2748         * python/py-xmethods.c: Do not include py-ref.h.
2749         * python/python.c: Do not include py-ref.h.
2750         * varobj.c: Do not include py-ref.h.
2751
2752 2019-01-22  Tom Tromey  <tom@tromey.com>
2753
2754         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2755         keyword for bcache.
2756
2757 2019-01-22  Tom Tromey  <tom@tromey.com>
2758
2759         * compile/compile-cplus-types.c: Remove a comment by #include.
2760
2761 2019-01-22  Tom Tromey  <tom@tromey.com>
2762
2763         * compile/gcc-c-plugin.h: Include compile-internal.h.
2764
2765 2019-01-22  Tom Tromey  <tom@tromey.com>
2766
2767         * stabsread.c (EXTERN): Do not define.
2768         (symnum, next_symbol_text_func, processing_gcc_compilation)
2769         (within_function, global_sym_chain, global_stabs)
2770         (previous_stab_code, this_object_header_files)
2771         (n_this_object_header_files)
2772         (n_allocated_this_object_header_files): Define.
2773         * stabsread.h (EXTERN): Never define.  Use "extern".
2774
2775 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2776
2777         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2778         history_value.
2779
2780 2019-01-21  Tom Tromey  <tom@tromey.com>
2781
2782         * ui-out.c: Fix includes.
2783         * tui/tui-source.c: Fix includes.
2784         * target.c: Fix includes.
2785         * remote.c: Fix includes.
2786         * regcache.c: Fix includes.
2787         * python/py-block.c: Fix includes.
2788         * printcmd.c: Fix includes.
2789         * or1k-tdep.c: Fix includes.
2790         * mi/mi-main.c: Fix includes.
2791         * m32r-tdep.c: Fix includes.
2792         * csky-tdep.c: Fix includes.
2793         * compile/compile-cplus-types.c: Fix includes.
2794         * cli/cli-interp.c: Fix includes.
2795
2796 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2797
2798         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2799         for padding.
2800
2801 2019-01-16  Tom Tromey  <tom@tromey.com>
2802
2803         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2804         earlier.
2805         (struct objfile) <msymbols_range>: Move from top level.
2806         <msymbols>: New method.
2807         (class objfile_msymbols): Remove.
2808         * symtab.c (default_collect_symbol_completion_matches_break_on):
2809         Update.
2810         * symmisc.c (dump_msymbols): Update.
2811         * stabsread.c (scan_file_globals): Update.
2812         * objc-lang.c (info_selectors_command, info_classes_command)
2813         (find_methods): Update.
2814         * minsyms.c (find_solib_trampoline_target): Update.
2815         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2816         * coffread.c (coff_symfile_read): Update.
2817         * ada-lang.c (ada_lookup_simple_minsym)
2818         (ada_collect_symbol_completion_matches): Update.
2819
2820 2019-01-16  Tom Tromey  <tom@tromey.com>
2821
2822         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2823         type.  Remove no-argument constructor.
2824         <iterator::operator++>: Simplify.
2825         <begin>: Update.
2826         <end>: Use minimal_symbol_count.
2827
2828 2019-01-16  Tom Tromey  <tom@tromey.com>
2829
2830         * objfiles.h (struct objfile) <psymtabs>: New method.
2831         (class objfile_psymtabs): Remove.
2832         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2833         typedef.
2834         <range>: New method.
2835         (require_partial_symbols): Change return type.
2836         * psymtab.c (require_partial_symbols)
2837         (psym_expand_symtabs_matching): Update.
2838         * mdebugread.c (parse_partial_symbols): Update.
2839         * dbxread.c (dbx_end_psymtab): Update.
2840
2841 2019-01-15  Tom Tromey  <tom@tromey.com>
2842
2843         * symtab.c (lookup_objfile_from_block)
2844         (lookup_symbol_in_objfile_symtabs)
2845         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2846         (find_line_symtab, info_sources_command)
2847         (default_collect_symbol_completion_matches_break_on)
2848         (make_source_files_completion_list): Update.
2849         * symmisc.c (print_objfile_statistics, dump_objfile)
2850         (maintenance_print_symbols, maintenance_info_symtabs)
2851         (maintenance_check_symtabs, maintenance_info_line_tables):
2852         Update.
2853         * source.c (select_source_symtab)
2854         (forget_cached_source_info_for_objfile): Update.
2855         * objfiles.h (class objfile_compunits): Remove.
2856         (struct objfile) <compunits_range>: New typedef.
2857         (compunits): New method.
2858         * objfiles.c (objfile_relocate1): Update.
2859         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2860         * maint.c (count_symtabs_and_blocks): Update.
2861         * linespec.c (iterate_over_all_matching_symtabs): Update.
2862         * cp-support.c (add_symbol_overload_list_qualified): Update.
2863         * coffread.c (coff_symtab_read): Update.
2864         * ada-lang.c (add_nonlocal_symbols)
2865         (ada_collect_symbol_completion_matches)
2866         (ada_add_global_exceptions): Update.
2867
2868 2019-01-15  Tom Tromey  <tom@tromey.com>
2869
2870         * progspace.h (program_space) <objfiles_safe_range>: New
2871         typedef.
2872         <objfiles_safe>: New method.
2873         * objfiles.h (class all_objfiles_safe): Remove.
2874         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2875         * jit.c (jit_inferior_exit_hook): Update.
2876
2877 2019-01-17  Tom Tromey  <tom@tromey.com>
2878
2879         * progspace.h (program_space) <objfiles_range>: New typedef.
2880         <objfiles>: New method.
2881         <objfiles_head>: Rename from objfiles.
2882         (object_files): Update.
2883         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2884         * guile/scm-pretty-print.c
2885         (ppscm_find_pretty_printer_from_objfiles): Update.
2886         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2887         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2888         Update.
2889         * python/py-progspace.c (pspy_get_objfiles): Update.
2890         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2891         Update.
2892         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2893         (objfpy_lookup_objfile_by_build_id): Update.
2894         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2895         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2896         Update.
2897         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2898         (expand_symtab_containing_pc, lookup_objfile_from_block)
2899         (lookup_static_symbol, basic_lookup_transparent_type)
2900         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2901         (find_line_symtab, info_sources_command)
2902         (default_collect_symbol_completion_matches_break_on)
2903         (make_source_files_completion_list, find_main_name): Update.
2904         * symmisc.c (print_symbol_bcache_statistics)
2905         (print_objfile_statistics, maintenance_print_symbols)
2906         (maintenance_print_msymbols, maintenance_print_objfiles)
2907         (maintenance_info_symtabs, maintenance_check_symtabs)
2908         (maintenance_expand_symtabs, maintenance_info_line_tables):
2909         Update.
2910         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2911         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2912         (map_overlay_command, unmap_overlay_command)
2913         (simple_overlay_update, expand_symtabs_matching)
2914         (map_symbol_filenames): Update.
2915         * symfile-debug.c (set_debug_symfile): Update.
2916         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2917         Update.
2918         * source.c (select_source_symtab, forget_cached_source_info):
2919         Update.
2920         * solib.c (solib_read_symbols): Update.
2921         * solib-spu.c (append_ocl_sos): Update.
2922         * psymtab.c (maintenance_print_psymbols)
2923         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2924         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2925         * printcmd.c (info_symbol_command): Update.
2926         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2927         Update.
2928         * objfiles.h (class all_objfiles): Remove.
2929         * objfiles.c (have_partial_symbols, have_full_symbols)
2930         (have_minimal_symbols, qsort_cmp, update_section_map)
2931         (shared_objfile_contains_address_p)
2932         (default_iterate_over_objfiles_in_search_order): Update.
2933         * objc-lang.c (info_selectors_command, info_classes_command)
2934         (find_methods): Update.
2935         * minsyms.c (find_solib_trampoline_target): Update.
2936         * maint.c (maintenance_info_sections)
2937         (maintenance_translate_address, count_symtabs_and_blocks):
2938         Update.
2939         * main.c (captured_main_1): Update.
2940         * linux-thread-db.c (try_thread_db_load_from_pdir)
2941         (has_libpthread): Update.
2942         * linespec.c (iterate_over_all_matching_symtabs)
2943         (search_minsyms_for_name): Update.
2944         * jit.c (jit_find_objf_with_entry_addr): Update.
2945         * hppa-tdep.c (find_unwind_entry)
2946         (hppa_lookup_stub_minimal_symbol): Update.
2947         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2948         Update.
2949         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2950         (elf_gnu_ifunc_resolve_by_got): Update.
2951         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2952         * dwarf-index-write.c (save_gdb_index_command): Update.
2953         * cp-support.c (add_symbol_overload_list_qualified): Update.
2954         * breakpoint.c (create_overlay_event_breakpoint)
2955         (create_longjmp_master_breakpoint)
2956         (create_std_terminate_master_breakpoint)
2957         (create_exception_master_breakpoint): Update.
2958         * blockframe.c (find_pc_partial_function): Update.
2959         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2960         (ada_collect_symbol_completion_matches)
2961         (ada_add_global_exceptions): Update.
2962
2963 2019-01-17  Tom Tromey  <tom@tromey.com>
2964
2965         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2966         declare VEC.
2967         (solib_target_parse_libraries): Change return type.
2968         (library_list_start_segment, library_list_start_section)
2969         (library_list_end_library, library_list_start_library); Update.
2970         (solib_target_free_library_list): Remove.
2971         (solib_target_parse_libraries): Remove cleanup.  Change return
2972         type.
2973         (solib_target_current_sos): Update.
2974
2975 2019-01-17  Tom Tromey  <tromey@bapiya>
2976
2977         * valprint.c: Replace "the the" with "the".
2978         * symtab.c: Replace "the the" with "the".
2979         * solib.c: Replace "the the" with "the".
2980         * solib-dsbt.c: Replace "the the" with "the".
2981         * linespec.c: Replace "the the" with "the".
2982         * dwarf2loc.h: Replace "the the" with "the".
2983         * amd64-windows-tdep.c: Replace "the the" with "the".
2984         * aarch64-tdep.c: Replace "the the" with "the".
2985
2986 2019-01-16  Keith Seitz  <keiths@redhat.com>
2987
2988         PR gdb/23773
2989         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2990         <builder>: Rename to ..
2991         <m_builder>: ... this and make private.
2992         (dwarf2_cu::get_builder): New method.  Change all users of
2993         `builder' to use this method.
2994         (dwarf2_start_symtab): Move to ...
2995         (dwarf2_cu::start_symtab): ... here.  Update all callers
2996         (setup_type_unit_groups): Move to ...
2997         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2998         callers.
2999         (dwarf2_cu::reset_builder): New method.
3000         (process_full_compunit, process_full_type_unit): Use
3001         dwarf2_cu::reset_builder.
3002         (follow_die_offset): Record the ancestor CU if it is different
3003         from the followed DIE's CU.
3004         (follow_die_sig_1): Likewise.
3005
3006 2019-01-15  Tom Tromey  <tom@tromey.com>
3007
3008         * remote.c (class remote_state) <buf>: Now a char_vector.
3009         <buf_size>: Remove.
3010         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
3011         parameter.
3012         (remote_target::getpkt_or_notif_sane_1)
3013         (remote_target::getpkt_sane)
3014         (remote_target::getpkt_or_notif_sane): Likewise.
3015         (class remote_target) <putpkt>: New overload.
3016         (remote_target::read_frame): Change type of "buf_p".  Remove
3017         sizeof_p parameter.
3018         (packet_ok): New overload.
3019         (packet_check_result): New overload.
3020         Update all uses.
3021
3022 2019-01-14  Tom Tromey  <tom@tromey.com>
3023
3024         * remote-notif.c (handle_notification, remote_notif_ack)
3025         (remote_notif_parse): Make "buf" const.
3026         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
3027         const.
3028         (remote_notif_parse, remote_notif_ack, handle_notification):
3029         Likewise.
3030         * remote.c (remote_notif_stop_parse): Make "buf" const.
3031         (remote_target::remote_parse_stop_reply): Make "buf" const.
3032         (remote_notif_stop_ack): Make "buf" const.
3033
3034 2019-01-14  Tom Tromey  <tom@tromey.com>
3035
3036         * remote.c (remote_console_output): Make parameter const.
3037
3038 2019-01-14  Tom Tromey  <tom@tromey.com>
3039
3040         * target-debug.h (target_debug_print_signals): Constify.
3041         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
3042         * procfs.c (procfs_target::pass_signals): Update.
3043         * linux-nat.c (linux_nat_target::pass_signals): Update.
3044         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
3045         * target-delegates.c: Rebuild.
3046         * remote.c (remote_target::program_signals): Update.
3047         (remote_target::pass_signals): Update.
3048         * target.c (target_pass_signals): Constify argument.
3049         (target_program_signals): Likewise.
3050         * target.h (struct target_ops) <pass_signals, program_signals>:
3051         Constify argument.
3052         (target_pass_signals, target_program_signals): Constify argument.
3053
3054 2019-01-14  Tom Tromey  <tom@tromey.com>
3055
3056         PR tui/28819:
3057         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
3058
3059 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3060
3061         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
3062         field.
3063         * rs6000-tdep.c: Include reggroups.h.
3064         (IS_V_ALIAS_PSEUDOREG): Define.
3065         (rs6000_register_name): Return names for the "vX" aliases.
3066         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
3067         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
3068         aliases.  Call default_register_reggroup_p for all other
3069         pseudo-registers.
3070         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
3071         New functions.
3072         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
3073         Handle "vX" aliases.
3074         (v_alias_pseudo_register_collect): New function.
3075         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
3076         (rs6000_gdbarch_init): Initialize "vX" aliases as
3077         pseudo-registers.  Restore registration of
3078         rs6000_pseudo_register_reggroup_p with
3079         set_tdesc_pseudo_register_reggroup_p.
3080
3081 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
3082
3083         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
3084         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
3085         set_gdbarch_num_pseudo_regs.
3086
3087 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3088
3089         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
3090         Remove arg prefixname, add do_set and do_show.
3091         Add member functions set_list and show_list.
3092         * cli/cli-style.c (class cli_style_option): Update accordingly.
3093         (style_set_list): Move to file scope.
3094         (style_show_list): Likewise.
3095         (set_style): Call help_list.
3096         (show_style): Call cmd_show_list.
3097         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
3098         Update to use the new macro.
3099
3100 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
3101
3102         * ada-lang.c (_initialize_ada_language): Expand the help text
3103         for the "catch exception" command.
3104
3105 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3106
3107         * symtab.c (matching_obj_sections): Initialize obj,
3108         declare it closer to its usage.
3109
3110 2019-01-10  Tom Tromey  <tom@tromey.com>
3111
3112         * thread-iter.h (inf_threads_iterator): Use next_iterator.
3113         (basic_inf_threads_range): Remove.
3114         (inf_threads_range, inf_non_exited_threads_range)
3115         (safe_inf_threads_range): Use next_adapter.
3116
3117 2019-01-10  Keith Seitz  <keiths@redhat.com>
3118
3119         PR gdb/23712
3120         PR symtab/23010
3121         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
3122         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
3123
3124 2019-01-10  Keith Seitz  <keiths@redhat.com>
3125
3126         PR gdb/23712
3127         PR symtab/23010
3128         * dictionary.c (pending_to_vector): Remove.
3129         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3130         Remove _1 suffix, replacing functions of the same name.  Update
3131         all callers.
3132         (dict_create_hashed, dict_create_hashed_expandable)
3133         (dict_create_linear, dict_create_linear_expandable, dict_free)
3134         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
3135         Make functions static.
3136
3137 2019-01-10  Keith Seitz  <keiths@redhat.com>
3138
3139         PR gdb/23712
3140         PR symtab/23010
3141         * dictionary.h (struct dictionary): Replace declaration with
3142         multidictionary.
3143         (dict_create_hashed, dict_create_hashed_expandable)
3144         (dict_create_linear, dict_create_linear_expandable)
3145         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
3146         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
3147         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
3148         taking multidictionary argument.
3149         [ALL_DICT_SYMBOLS]: Update for multidictionary.
3150         * block.h (struct block) <dict>: Change to multidictionary
3151         and rename `multidict'.
3152         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
3153         symmisc.c: Update all dictionary references to multidictionary.
3154
3155 2019-01-10  Keith Seitz  <keiths@redhat.com>
3156
3157         PR gdb/23712
3158         PR symtab/23010
3159         * dictionary.c: Include unordered_map.
3160         (pending_to_vector): New function.
3161         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3162         Rewrite the non-"_1" functions to take vector instead
3163         of linked list.
3164         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
3165         "new" _1 versions of the same name.
3166         (multidictionary): Define.
3167         (std::hash<enum language): New definition.
3168         (collate_pending_symbols_by_language, mdict_create_hashed)
3169         (mdict_create_hashed_expandable, mdict_create_linear)
3170         (mdict_create_linear_expandable, mdict_free)
3171         (find_language_dictionary, create_new_language_dictionary)
3172         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
3173         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
3174         (mdict_size, mdict_empty): New functions.
3175         * dictionary.h (mdict_iterator): Define.
3176
3177 2019-01-10  Pedro Alves  <palves@redhat.com>
3178
3179         * breakpoint.c (read_uploaded_action)
3180         (create_tracepoint_from_upload): Adjust to use
3181         gdb::unique_xmalloc_ptr.
3182         * ctf.c (ctf_write_uploaded_tp):
3183         (SET_ARRAY_FIELD): Use emplace_back.
3184         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
3185         * tracefile-tfile.c (tfile_write_uploaded_tp):
3186         * tracepoint.c (parse_tracepoint_definition): Adjust to use
3187         gdb::unique_xmalloc_ptr.
3188         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
3189         at_string, cond_string, cmd_strings>: Replace char pointers
3190         with gdb::unique_xmalloc_ptr.
3191
3192 2019-01-10  Pedro Alves  <palves@redhat.com>
3193
3194         * solib-target.c (library_list_start_library): Don't xstrdup name.
3195
3196 2019-01-10  Pedro Alves  <palves@redhat.com>
3197
3198         * mdebugread.c (parse_partial_symbols): Use
3199         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3200
3201 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3202
3203         * linux-fork.c (scoped_switch_fork_info)
3204         <~scoped_switch_fork_info>: Fix incorrect variable name.
3205
3206 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3207
3208         * linux-fork.c (scoped_switch_fork_info)
3209         <scoped_switch_fork_info>: Make explicit.
3210         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3211
3212 2019-01-10  Tom Tromey  <tom@tromey.com>
3213
3214         * objfiles.h (objfile::reset_psymtabs): Update.
3215         * objfiles.c (objfile::objfile): Update.
3216         * psymtab.h (psymtab_storage::obstack): Update.
3217         (psymtab_storage::m_obstack): Use gdb::optional.
3218         (class psymtab_storage): Update comment.  Remove objfile
3219         parameter.
3220         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3221
3222 2019-01-10  Tom Tromey  <tom@tromey.com>
3223
3224         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3225         <free_psymtabs>: Now private.
3226         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3227         (allocate_psymtab): Use new method.
3228
3229 2019-01-10  Tom Tromey  <tom@tromey.com>
3230
3231         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3232         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3233         * mdebugread.c (parse_partial_symbols): Use
3234         allocate_dependencies.
3235         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3236         allocate_dependencies.
3237         (process_psymtab_comp_unit_reader)
3238         (build_type_psymtab_dependencies): Likewise.
3239         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3240
3241 2019-01-10  Tom Tromey  <tom@tromey.com>
3242
3243         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3244         PSYMBOL_SET_LANGUAGE.
3245         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3246
3247 2019-01-10  Tom Tromey  <tom@tromey.com>
3248
3249         * psymtab.h (psymtab_storage::obstack): New method.
3250         <m_obstack>: Rename from obstack; now private.
3251         * psymtab.c (psymtab_storage): Update.
3252         * dwarf2read.c (create_addrmap_from_index)
3253         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3254         Update.
3255
3256 2019-01-10  Tom Tromey  <tom@tromey.com>
3257
3258         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3259         * objfiles.h (objfile::reset_psymtabs): New method.
3260
3261 2019-01-10  Tom Tromey  <tom@tromey.com>
3262
3263         * symmisc.c (print_symbol_bcache_statistics): Update.
3264         (print_objfile_statistics): Update.
3265         * symfile.c (reread_symbols): Update.
3266         * psymtab.h (class psymtab_storage): New.
3267         * psymtab.c (psymtab_storage): New constructor.
3268         (~psymtab_storage): New destructor.
3269         (require_partial_symbols): Update.
3270         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3271         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3272         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3273         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3274         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3275         (start_psymtab_common, end_psymtab_common)
3276         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3277         (allocate_psymtab): Update.
3278         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3279         Update.
3280         (dump_psymtab_addrmap, maintenance_print_psymbols)
3281         (maintenance_check_psymtabs): Update.
3282         (class objfile_psymtabs): Move to objfiles.h.
3283         * psympriv.h (discard_psymtab): Now inline.
3284         (psymtab_discarder::psymtab_discarder): Update.
3285         (psymtab_discarder::~psymtab_discarder): Update.
3286         (ALL_OBJFILE_PSYMTABS): Rewrite.
3287         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3288         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3289         Remove fields.
3290         <partial_symtabs>: New field.
3291         (class objfile_psymtabs): Move from psymtab.h.  Update.
3292         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3293         psymbol_cache.
3294         (objfile::~objfile): Don't destroy psymbol_cache.
3295         * mdebugread.c (parse_partial_symbols): Update.
3296         * dwarf2read.c (create_addrmap_from_index)
3297         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3298         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3299         (add_partial_subprogram, dwarf2_ranges_read): Update.
3300         * dwarf-index-write.c (write_address_map)
3301         (write_one_signatured_type, recursively_write_psymbols)
3302         (class debug_names, class debug_names, write_psymtabs_to_index):
3303         Update.
3304
3305 2019-01-10  Tom Tromey  <tom@tromey.com>
3306
3307         * symtab.h (SYMBOL_SET_NAMES): Update.
3308         (symbol_set_names): Update.
3309         (MSYMBOL_SET_NAMES): Update.
3310         * symtab.c (symbol_set_names): Change argument to be an
3311         objfile_per_bfd_storage.
3312         * psymtab.c (add_psymbol_to_bcache): Update.
3313         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3314
3315 2019-01-10  Tom Tromey  <tom@tromey.com>
3316
3317         * symtab.c (create_demangled_names_hash): Change argument to be an
3318         objfile_per_bfd_storage.
3319         (symbol_set_names): Update.
3320
3321 2019-01-10  Tom Tromey  <tom@tromey.com>
3322
3323         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3324         init_psymbol_list.
3325         * psymtab.c (init_psymbol_list): Do nothing if already called.
3326         * psympriv.h (init_psymbol_list): Add comment.
3327         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3328         init_psymbol_list.
3329         * dbxread.c (dbx_symfile_read): Unconditionally call
3330         init_psymbol_list.
3331
3332 2019-01-10  Tom Tromey  <tom@tromey.com>
3333
3334         * xcoffread.c (scan_xcoff_symtab): Update.
3335         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3336         "where".
3337         * mdebugread.c (parse_partial_symbols)
3338         (handle_psymbol_enumerators): Update.
3339         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3340         * dbxread.c (read_dbx_symtab): Update.
3341         * psympriv.h (psymbol_placement): New enum.
3342         (add_psymbol_to_list): Update.
3343
3344 2019-01-10  Tom Tromey  <tom@tromey.com>
3345
3346         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3347         static_psymbols parameters.
3348         (scan_xcoff_symtab): Update.
3349         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3350         static_psymbols parameters.
3351         * psympriv.h (start_psymtab_common): Update.
3352         * mdebugread.c (parse_partial_symbols): Update.
3353         * dwarf2read.c (create_partial_symtab): Update.
3354         * dbxread.c (read_dbx_symtab): Update.
3355         (start_psymtab): Remove global_psymbols and static_psymbols
3356         parameters.
3357
3358 2019-01-10  Tom Tromey  <tom@tromey.com>
3359
3360         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3361         * psymtab.c (allocate_psymtab): Add comment.
3362         * psympriv.h (allocate_psymtab): Add comment.
3363         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3364         initializations.
3365         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3366
3367 2019-01-10  Tom Tromey  <tom@tromey.com>
3368
3369         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3370         Don't declare.
3371         * mipsread.c: Include mdebugread.h.
3372         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3373         Declare.
3374         * elfread.c: Include mdebugread.h.
3375
3376 2019-01-09  Tom Tromey  <tom@tromey.com>
3377
3378         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3379         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3380         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3381         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3382         (psym_lookup_symbol, psym_find_last_source_symtab)
3383         (psym_forget_cached_source_info, psym_print_stats)
3384         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3385         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3386         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3387         (psym_find_compunit_symtab_by_address)
3388         (maintenance_print_psymbols, maintenance_info_psymtabs)
3389         (maintenance_check_psymtabs): Use ranged for.
3390         * psymtab.h (class objfile_psymtabs): New.
3391         (require_partial_symbols): Return objfile_psymtabs.
3392         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3393
3394 2019-01-09  Tom Tromey  <tom@tromey.com>
3395
3396         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3397         (find_pc_mapped_section, list_overlays_command)
3398         (map_overlay_command, unmap_overlay_command)
3399         (simple_overlay_update): Use all_objfiles.
3400         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3401         * printcmd.c (info_symbol_command): Use all_objfiles.
3402         * objfiles.h (ALL_OBJSECTIONS): Remove.
3403         * maint.c (maintenance_translate_address): Use all_objfiles.
3404         * gcore.c (gcore_create_callback): Use all_objfiles.
3405         (objfile_find_memory_regions): Likewise.
3406
3407 2019-01-09  Tom Tromey  <tom@tromey.com>
3408
3409         * symtab.c (find_line_symtab, info_sources_command)
3410         (make_source_files_completion_list): Use objfile_compunits.
3411         * source.c (select_source_symtab): Use objfile_compunits.
3412         * objfiles.h (struct objfile): Update comment.
3413         (ALL_OBJFILES): Remove.
3414         (ALL_FILETABS): Remove.
3415         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3416         objfile_compunits.
3417
3418 2019-01-09  Tom Tromey  <tom@tromey.com>
3419
3420         * symmisc.c (print_objfile_statistics, dump_objfile)
3421         (maintenance_print_symbols): Use compunit_filetabs.
3422         * source.c (forget_cached_source_info_for_objfile): Use
3423         compunit_filetabs.
3424         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3425         (ALL_FILETABS): Use compunit_filetabs.
3426         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3427         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3428
3429 2019-01-09  Tom Tromey  <tom@tromey.com>
3430
3431         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3432         (compunit_filetabs): New.
3433         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3434         compunit_filetabs.
3435         (info_sources_command, make_source_files_completion_list): Remove
3436         declaration.
3437         * symmisc.c (print_objfile_statistics, dump_objfile)
3438         (maintenance_print_symbols): Remove declaration.
3439         (maintenance_info_symtabs): Use compunit_filetabs.
3440         (maintenance_info_line_tables): Likewise.
3441         * source.c (select_source_symtab): Change local variable name.
3442         (forget_cached_source_info_for_objfile): Remove declaration.
3443         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3444         * objfiles.c (objfile_relocate1): Remove declaration.
3445         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3446         declaration.
3447         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3448         * coffread.c (coff_symtab_read): Remove declaration.
3449         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3450         compunit_filetabs.
3451
3452 2019-01-09  Tom Tromey  <tom@tromey.com>
3453
3454         * symtab.c (lookup_objfile_from_block)
3455         (find_pc_sect_compunit_symtab, search_symbols)
3456         (default_collect_symbol_completion_matches_break_on): Use
3457         objfile_compunits.
3458         * objfiles.h (ALL_COMPUNITS): Remove.
3459         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3460         * cp-support.c (add_symbol_overload_list_qualified): Use
3461         objfile_compunits.
3462         * ada-lang.c (ada_collect_symbol_completion_matches)
3463         (ada_add_global_exceptions): Use objfile_compunits.
3464
3465 2019-01-09  Tom Tromey  <tom@tromey.com>
3466
3467         * source.c (select_source_symtab)
3468         (forget_cached_source_info_for_objfile): Remove declaration.
3469         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3470         declaration.
3471         * maint.c (count_symtabs_and_blocks): Remove declaration.
3472         * cp-support.c (add_symbol_overload_list_qualified): Remove
3473         declaration.
3474         * coffread.c (coff_symtab_read): Remove declaration.
3475         * symtab.c (lookup_symbol_in_objfile_symtabs)
3476         (basic_lookup_transparent_type_1): Use objfile_compunits.
3477         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3478         (info_sources_command, search_symbols)
3479         (default_collect_symbol_completion_matches_break_on)
3480         (make_source_files_completion_list): Remove declaration.
3481         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3482         (ada_collect_symbol_completion_matches)
3483         (ada_add_global_exceptions): Remove declaration.
3484         * linespec.c (iterate_over_all_matching_symtabs): Use
3485         objfile_compunits.
3486         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3487         (class objfile_compunits): New.
3488         (ALL_COMPUNITS): Use objfile_compunits.
3489         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3490         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3491         objfile_compunits.
3492         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3493
3494 2019-01-09  Tom Tromey  <tom@tromey.com>
3495
3496         * symtab.c (search_symbols)
3497         (default_collect_symbol_completion_matches_break_on): Use
3498         objfile_msymbols.
3499         * ada-lang.c (ada_lookup_simple_minsym)
3500         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3501         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3502         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3503         objfile_msymbols.
3504         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3505         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3506         * objc-lang.c (find_methods): Use objfile_msymbols.
3507         (info_selectors_command, info_classes_command): Likewise.
3508         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3509         * objfiles.h (class objfile_msymbols): New.
3510         (ALL_OBJFILE_MSYMBOLS): Remove.
3511         (ALL_MSYMBOLS): Remove.
3512
3513 2019-01-09  Tom Tromey  <tom@tromey.com>
3514
3515         * common/next-iterator.h (next_adapter): Add Iterator template
3516         parameter.
3517         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3518         (class all_objfiles_safe): New.
3519         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3520         * objfiles.c (put_objfile_before): Update comment.
3521         (add_separate_debug_objfile): Likewise.
3522         (free_all_objfiles): Use all_objfiles_safe.
3523         (objfile_purge_solibs): Likewise.
3524
3525 2019-01-09  Tom Tromey  <tom@tromey.com>
3526
3527         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3528         (expand_symtab_containing_pc, lookup_static_symbol)
3529         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3530         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3531         all_objfiles.
3532         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3533         * breakpoint.c (create_overlay_event_breakpoint)
3534         (create_longjmp_master_breakpoint)
3535         (create_std_terminate_master_breakpoint)
3536         (create_exception_master_breakpoint): Use all_objfiles.
3537         * linux-thread-db.c (try_thread_db_load_from_pdir)
3538         (has_libpthread): Use all_objfiles.
3539         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3540         * linespec.c (iterate_over_all_matching_symtabs)
3541         (search_minsyms_for_name): Use all_objfiles.
3542         * maint.c (maintenance_info_sections): Use all_objfiles.
3543         * main.c (captured_main_1): Use all_objfiles.
3544         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3545         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3546         * guile/scm-pretty-print.c
3547         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3548         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3549         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3550         (maintenance_print_msymbols): Use all_objfiles.
3551         * source.c (select_source_symtab): Use all_objfiles.
3552         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3553         * symfile.c (remove_symbol_file_command)
3554         (expand_symtabs_matching, map_symbol_filenames): Use
3555         all_objfiles.
3556         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3557         all_objfiles.
3558         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3559         * objc-lang.c (find_methods): Use all_objfiles.
3560         * objfiles.c (have_partial_symbols, have_full_symbols)
3561         (have_minimal_symbols, qsort_cmp)
3562         (default_iterate_over_objfiles_in_search_order): Use
3563         all_objfiles.
3564         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3565         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3566         (maintenance_check_psymtabs): Use all_objfiles.
3567         (ALL_PSYMTABS): Remove.
3568         * compile/compile-object-run.c (do_module_cleanup): Use
3569         all_objfiles.
3570         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3571         * cp-support.c (add_symbol_overload_list_qualified): Use
3572         all_objfiles.
3573         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3574         Use all_objfiles.
3575         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3576         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3577         all_objfiles.
3578         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3579         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3580         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3581         Uses all_objfiles.
3582         * solib.c (solib_read_symbols): Use all_objfiles
3583
3584 2019-01-09  Tom Tromey  <tom@tromey.com>
3585
3586         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3587         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3588         all_objfiles.
3589         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3590         * symmisc.c (print_symbol_bcache_statistics)
3591         (print_objfile_statistics, maintenance_print_objfiles)
3592         (maintenance_info_symtabs, maintenance_check_symtabs)
3593         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3594         all_objfiles.
3595         * source.c (forget_cached_source_info): Use all_objfiles.
3596         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3597         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3598         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3599         * objfiles.c (update_section_map): Use all_objfiles.
3600         (shared_objfile_contains_address_p): Likewise.
3601         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3602         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3603
3604 2019-01-09  Tom Tromey  <tom@tromey.com>
3605
3606         * common/next-iterator.h: New file.
3607         * objfiles.h (class all_objfiles): New.
3608         (struct objfile_iterator): New.
3609
3610 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3611
3612         * NEWS: Move the description of the changed "frame", "select-frame",
3613          and "info frame" commands to the Changed commands section.
3614
3615 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3616
3617         * gdbtypes.c (check_stub_method_group): Remove handling of old
3618         mangling schemes.
3619         * linespec.c (find_methods): Likewise.
3620         * stabsread.c (read_member_functions): Likewise.
3621         * valops.c (search_struct_method): Likewise.
3622         (value_struct_elt_for_reference): Likewise.
3623         * NEWS: Mention this change.
3624
3625 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3626
3627         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3628         print_source_lines.
3629         * source.c (print_source_lines_base): Update line number check.
3630         (print_source_lines): New function.
3631         (source_lines_range::source_lines_range): New function.
3632         * source.h (class source_lines_range): New class.
3633         (print_source_lines): New declaration.
3634
3635 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3636
3637         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3638
3639 2019-01-08  Tom Tromey  <tom@tromey.com>
3640             Simon Marchi  <simon.marchi@ericsson.com>
3641
3642         PR gdb/24060
3643         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3644         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3645         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3646         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3647         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3648         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3649
3650 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3651
3652         * source.c (select_source_symtab): Move header comment to
3653         declaration in source.h.
3654         (forget_cached_source_info_for_objfile): Likewise.
3655         (forget_cached_source_info): Likewise.
3656         (identify_source_line): Likewise.
3657         * source.h (identify_source_line): Move declaration from symtab.h
3658         and add comment from source.c
3659         (print_source_lines): Likewise.
3660         (forget_cached_source_info_for_objfile): Likewise.
3661         (forget_cached_source_info): Likewise.
3662         (select_source_symtab): Likewise.
3663         (enum print_source_lines_flag): Move definition from symtab.h.
3664         * symtab.h (identify_source_line): Move declaration to source.h.
3665         (print_source_lines): Likewise.
3666         (forget_cached_source_info_for_objfile): Likewise.
3667         (forget_cached_source_info): Likewise.
3668         (select_source_symtab): Likewise.
3669         (enum print_source_lines_flag): Move definition to source.h.
3670         * tui/tui-hooks.c: Add 'source.h' include.
3671
3672 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3673
3674         * source.c (print_source_lines_base): Handle requests to print
3675         reverse line number sequences, and guard against empty lines
3676         string.
3677
3678 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3679
3680         * source.c (print_source_lines_base): Fix skip of '\r' if next
3681         character is '\n'.
3682
3683 2019-01-06  Tom Tromey  <tom@tromey.com>
3684
3685         * c-exp.y (struct c_parse_state) <macro_original_text,
3686         expansion_obstack>: New member.
3687         (macro_original_text, expansion_obstack): Remove globals.
3688         (scan_macro_expansion, scanning_macro_expansion)
3689         (finished_macro_expansion): Update.
3690         (scan_macro_cleanup): Remove.
3691         (yylex, c_parse): Update.
3692
3693 2019-01-06  Tom Tromey  <tom@tromey.com>
3694
3695         * c-exp.y (struct c_parse_state) <strings>: New member.
3696         (operator_stoken): Update.
3697
3698 2019-01-06  Tom Tromey  <tom@tromey.com>
3699
3700         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3701         (union type_stack_elt) <typelist_val>: Now a pointer to
3702         std::vector.
3703         (type_stack_cleanup): Don't declare.
3704         (push_typelist): Update.
3705         * parse.c (pop_typelist): Return a std::vector.
3706         (push_typelist): Take a std::vector.
3707         (follow_types): Update.  Do not free args.
3708         (type_stack_cleanup): Remove.
3709         * c-exp.y (struct c_parse_state): New.
3710         (cpstate): New global.
3711         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3712         (nonempty_typelist): Update.
3713         (func_mod): Create a new vector.
3714         (c_parse): Create a c_parse_state.
3715         (check_parameter_typelist): Do not delete params.
3716         (function_method): Update.  Do not delete type_list.
3717
3718 2019-01-06  Tom Tromey  <tom@tromey.com>
3719
3720         PR gdb/28155:
3721         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3722         check_typedef.
3723         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3724         (print_return_value): Likewise.
3725
3726 2019-01-05  Tom Tromey  <tom@tromey.com>
3727
3728         * contrib/cleanup_check.py: Remove.
3729         * contrib/gcc-with-excheck: Remove.
3730         * contrib/exsummary.py: Remove.
3731         * contrib/excheck.py: Remove.
3732
3733 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3734
3735         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3736         NULL. Initialize tpprev to NULL instead of assigning it
3737         to NULL on the next statement.
3738         * windows-nat.c (windows_delete_thread): Remove check for
3739         main_thread_id before printing thread exit notifications.
3740         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3741         Remove thread ID check against main_thread_id.
3742         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3743         windows_delete_thread.
3744         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3745
3746 2019-01-04  Tom Tromey  <tom@tromey.com>
3747
3748         * compile/compile.c (_initialize_compile): Use upper case for
3749         metasyntactic variables.
3750         * symmisc.c (_initialize_symmisc): Use upper case for
3751         metasyntactic variables.
3752         * psymtab.c (_initialize_psymtab): Use upper case for
3753         metasyntactic variables.
3754         * demangle.c (demangle_command): Use upper case for metasyntactic
3755         variables.
3756         (_initialize_demangler): Likewise.
3757         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3758         variables.
3759
3760 2019-01-03  Tom Tromey  <tom@tromey.com>
3761
3762         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3763
3764 2019-01-03  Tom Tromey  <tom@tromey.com>
3765
3766         * python/py-symtab.c (salpy_str): Update.
3767         (struct salpy_sal_object) <symtab>: Now a PyObject.
3768         (salpy_dealloc): Update.
3769         (del_objfile_sal): Use gdbpy_ref.
3770
3771 2019-01-03  Tom Tromey  <tom@tromey.com>
3772
3773         * python/py-type.c (convert_field): Use new_reference.  Return
3774         gdbpy_ref.
3775         (make_fielditem): Return gdbpy_ref.
3776         (typy_fields): Update.
3777         (typy_getitem): Update.
3778         (field_name): Return gdbpy_ref.  Use new_reference.
3779         (typy_iterator_iternext): Update.
3780
3781 2019-01-03  Tom Tromey  <tom@tromey.com>
3782
3783         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3784
3785 2019-01-03  Tom Tromey  <tom@tromey.com>
3786
3787         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3788         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3789         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3790         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3791         (pspy_set_type_printers): Likewise.
3792         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3793         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3794         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3795         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3796         (objfpy_set_type_printers): Likewise.
3797
3798 2019-01-03  Tom Tromey  <tom@tromey.com>
3799
3800         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3801         (gdbpy_print_stack): Use gdbpy_err_fetch.
3802         * python/python-internal.h (class gdbpy_err_fetch): New class.
3803         (class gdbpy_enter) <m_error_type, m_error_value,
3804         m_error_traceback>: Remove.
3805         <m_error>: New member.
3806         (gdbpy_exception_to_string): Don't declare.
3807         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3808         * python/py-value.c (convert_value_from_python): Use
3809         gdbpy_err_fetch.
3810         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3811         gdbpy_exception_to_string.
3812         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3813         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3814         gdbpy_err_fetch.
3815
3816 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3817
3818         * linux-nat.c (delete_lwp_cleanup): Delete.
3819         (struct lwp_deleter): New struct.
3820         (lwp_info_up): New typedef.
3821         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3822         lwp_info_up.
3823
3824 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3825
3826         * linux-fork.c (class scoped_switch_fork_info): New class.
3827         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3828
3829 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3830
3831         * valops.c (find_overload_match): Remove use of null_cleanup, and
3832         calls to do_cleanups.
3833
3834 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3835
3836         * compile/compile-cplus-types.c
3837         (compile_cplus_instance::decl_name): Handle changes to
3838         cp_func_name.
3839         * cp-support.c (cp_func_name): Update header comment, update
3840         return type.
3841         * cp-support.h (cp_func_name): Update return type in declaration.
3842         * valops.c (find_overload_match): Move temp_func local to top
3843         level of function and change its type.  Use temp_func to hold and
3844         delete temporary string obtained from cp_func_name.
3845
3846 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3847
3848         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3849         gdb::char_vector, remove cleanup, and update uses of `msg`.
3850
3851 2019-01-03  Jim Wilson  <jimw@sifive.com>
3852
3853         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3854
3855 2019-01-02  Tom Tromey  <tom@tromey.com>
3856
3857         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3858         (tdesc_parse_xml): Remove cleanups.
3859         * target-descriptions.h (make_cleanup_free_target_description):
3860         Don't declare.
3861         (target_desc_deleter): New struct.
3862         (target_desc_up): New typedef.
3863         * target-descriptions.c (target_desc_deleter::operator()): Rename
3864         from free_target_description.
3865         (make_cleanup_free_target_description): Remove.
3866
3867 2019-01-02  Tom Tromey  <tom@tromey.com>
3868
3869         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3870         constructor, destructor.
3871         (linespec_parser): Remove typedef.
3872         (~linespec_parser): Rename from linespec_parser_delete.
3873         (linespec_lex_to_end, linespec_complete_label)
3874         (linespec_complete): Update.
3875         (decode_line_full): Remove cleanups.
3876         (decode_line_1): Update.
3877
3878 2019-01-02  Tom Tromey  <tom@tromey.com>
3879
3880         * python/python-internal.h (inferior_to_inferior_object): Change
3881         return type.
3882         * python/py-exitedevent.c (create_exited_event_object): Update.
3883         * python/py-inferior.c (inferior_to_inferior_object): Return
3884         gdbpy_ref.
3885         (python_new_inferior, python_inferior_deleted)
3886         (thread_to_thread_object, delete_thread_object)
3887         (build_inferior_list, gdbpy_selected_inferior): Update.
3888         * python/py-infthread.c (create_thread_object): Update.  Also fail
3889         if inferior_to_inferior_object fails.
3890
3891 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3892
3893         * inferior.h (class inferior) <displaced_step_state>: New field.
3894         * infrun.h (struct displaced_step_state): Move here from
3895         infrun.c.  Initialize fields, add constructor.
3896         <inf>: Remove field.
3897         <reset>: New method.
3898         * infrun.c (struct displaced_step_inferior_state): Move to
3899         infrun.h.
3900         (displaced_step_inferior_states): Remove.
3901         (get_displaced_stepping_state): Adust.
3902         (displaced_step_in_progress_any_inferior): Adjust.
3903         (displaced_step_in_progress_thread): Adjust.
3904         (displaced_step_in_progress): Adjust.
3905         (add_displaced_stepping_state): Remove.
3906         (get_displaced_step_closure_by_addr): Adjust.
3907         (remove_displaced_stepping_state): Remove.
3908         (infrun_inferior_exit): Call displaced_step_state.reset.
3909         (use_displaced_stepping): Don't check for NULL.
3910         (displaced_step_prepare_throw): Call
3911         get_displaced_stepping_state.
3912         (displaced_step_fixup): Don't check for NULL.
3913         (prepare_for_detach): Don't check for NULL.
3914
3915 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3916
3917         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3918          in case of call that did not complete.
3919
3920 2019-01-02  Andrey Utkin  <autkin@undo.io>
3921
3922         * symfile.c (find_separate_debug_file): Fix search of debug files for
3923         remote debuggee.
3924
3925 2019-01-02  Tom Tromey  <tom@tromey.com>
3926
3927         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3928         indentation.
3929         * python/py-frame.c (frapy_older): Remove cast.
3930         (frapy_newer): Likewise.
3931         * python/py-breakpoint.c (local_setattro): Remove cast.
3932         * python/py-arch.c (archpy_name): Remove local variable.
3933         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3934
3935 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3936
3937         * unittests/basic_string_view/element_access/char/empty.cc:
3938         Fix year range in copyright header.
3939
3940 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3941
3942         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3943         Delete.
3944         <operator==>: Update with for removed field.
3945         <hash>: Likewise.
3946         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3947         <isa_features>: ...this.
3948         <abi_features>: New field.
3949         (riscv_isa_flen): Update comment.
3950         (riscv_abi_xlen): New declaration.
3951         (riscv_abi_flen): New declaration.
3952         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3953         isa_features.
3954         (riscv_abi_xlen): New function.
3955         (riscv_isa_flen): Update to get answer from isa_features.
3956         (riscv_abi_flen): New function.
3957         (riscv_has_fp_abi): Update to get answer from abi_features.
3958         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3959         xlen and flen.
3960         (riscv_call_info) <xlen, flen>: Update comment.
3961         (riscv_call_arg_struct): Remove invalid assertions
3962         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3963         is removed.
3964         (riscv_gdbarch_init): Gather isa features and abi features
3965         separately, ensure both match on the gdbarch when reusing an old
3966         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3967         a target with 64-bit float hardware.
3968
3969 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3970
3971         * source.c (search_command_helper): Stop reverse search
3972         when line 1 has been searched.
3973
3974 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3975
3976         * record-full.c (record_full_base_target::close): Rewrite
3977         record_full_core_buf_list free logic.
3978
3979 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3980
3981         * break-catch-syscall.c (print_one_catch_syscall): xfree
3982         the last text.
3983
3984 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3985
3986         * top.c (print_gdb_version): Update Copyright year in version
3987         message.
3988
3989 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3990
3991         Update copyright year range in all GDB files.
3992
3993 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3994
3995         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3996
3997 For older changes see ChangeLog-2018.
3998 \f
3999 Local Variables:
4000 mode: change-log
4001 left-margin: 8
4002 fill-column: 74
4003 version-control: never
4004 coding: utf-8
4005 End:
4006