gdb/ChangeLog

   1 2019-01-15  Tom Tromey  <tom@tromey.com>
   2
   3         * progspace.h (program_space) <objfiles_safe_range>: New
   4         typedef.
   5         <objfiles_safe>: New method.
   6         * objfiles.h (class all_objfiles_safe): Remove.
   7         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
   8         * jit.c (jit_inferior_exit_hook): Update.
   9
  10 2019-01-17  Tom Tromey  <tom@tromey.com>
  11
  12         * progspace.h (program_space) <objfiles_range>: New typedef.
  13         <objfiles>: New method.
  14         <objfiles_head>: Rename from objfiles.
  15         (object_files): Update.
  16         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
  17         * guile/scm-pretty-print.c
  18         (ppscm_find_pretty_printer_from_objfiles): Update.
  19         * guile/scm-objfile.c (gdbscm_objfiles): Update.
  20         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
  21         Update.
  22         * python/py-progspace.c (pspy_get_objfiles): Update.
  23         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
  24         Update.
  25         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
  26         (objfpy_lookup_objfile_by_build_id): Update.
  27         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
  28         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
  29         Update.
  30         * symtab.c (iterate_over_symtabs, matching_obj_sections)
  31         (expand_symtab_containing_pc, lookup_objfile_from_block)
  32         (lookup_static_symbol, basic_lookup_transparent_type)
  33         (find_pc_sect_compunit_symtab, find_symbol_at_address)
  34         (find_line_symtab, info_sources_command)
  35         (default_collect_symbol_completion_matches_break_on)
  36         (make_source_files_completion_list, find_main_name): Update.
  37         * symmisc.c (print_symbol_bcache_statistics)
  38         (print_objfile_statistics, maintenance_print_symbols)
  39         (maintenance_print_msymbols, maintenance_print_objfiles)
  40         (maintenance_info_symtabs, maintenance_check_symtabs)
  41         (maintenance_expand_symtabs, maintenance_info_line_tables):
  42         Update.
  43         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
  44         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
  45         (map_overlay_command, unmap_overlay_command)
  46         (simple_overlay_update, expand_symtabs_matching)
  47         (map_symbol_filenames): Update.
  48         * symfile-debug.c (set_debug_symfile): Update.
  49         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
  50         Update.
  51         * source.c (select_source_symtab, forget_cached_source_info):
  52         Update.
  53         * solib.c (solib_read_symbols): Update.
  54         * solib-spu.c (append_ocl_sos): Update.
  55         * psymtab.c (maintenance_print_psymbols)
  56         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
  57         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
  58         * printcmd.c (info_symbol_command): Update.
  59         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
  60         Update.
  61         * objfiles.h (class all_objfiles): Remove.
  62         * objfiles.c (have_partial_symbols, have_full_symbols)
  63         (have_minimal_symbols, qsort_cmp, update_section_map)
  64         (shared_objfile_contains_address_p)
  65         (default_iterate_over_objfiles_in_search_order): Update.
  66         * objc-lang.c (info_selectors_command, info_classes_command)
  67         (find_methods): Update.
  68         * minsyms.c (find_solib_trampoline_target): Update.
  69         * maint.c (maintenance_info_sections)
  70         (maintenance_translate_address, count_symtabs_and_blocks):
  71         Update.
  72         * main.c (captured_main_1): Update.
  73         * linux-thread-db.c (try_thread_db_load_from_pdir)
  74         (has_libpthread): Update.
  75         * linespec.c (iterate_over_all_matching_symtabs)
  76         (search_minsyms_for_name): Update.
  77         * jit.c (jit_find_objf_with_entry_addr): Update.
  78         * hppa-tdep.c (find_unwind_entry)
  79         (hppa_lookup_stub_minimal_symbol): Update.
  80         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
  81         Update.
  82         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
  83         (elf_gnu_ifunc_resolve_by_got): Update.
  84         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
  85         * dwarf-index-write.c (save_gdb_index_command): Update.
  86         * cp-support.c (add_symbol_overload_list_qualified): Update.
  87         * breakpoint.c (create_overlay_event_breakpoint)
  88         (create_longjmp_master_breakpoint)
  89         (create_std_terminate_master_breakpoint)
  90         (create_exception_master_breakpoint): Update.
  91         * blockframe.c (find_pc_partial_function): Update.
  92         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
  93         (ada_collect_symbol_completion_matches)
  94         (ada_add_global_exceptions): Update.
  95
  96 2019-01-17  Tom Tromey  <tom@tromey.com>
  97
  98         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
  99         declare VEC.
 100         (solib_target_parse_libraries): Change return type.
 101         (library_list_start_segment, library_list_start_section)
 102         (library_list_end_library, library_list_start_library); Update.
 103         (solib_target_free_library_list): Remove.
 104         (solib_target_parse_libraries): Remove cleanup.  Change return
 105         type.
 106         (solib_target_current_sos): Update.
 107
 108 2019-01-17  Tom Tromey  <tromey@bapiya>
 109
 110         * valprint.c: Replace "the the" with "the".
 111         * symtab.c: Replace "the the" with "the".
 112         * solib.c: Replace "the the" with "the".
 113         * solib-dsbt.c: Replace "the the" with "the".
 114         * linespec.c: Replace "the the" with "the".
 115         * dwarf2loc.h: Replace "the the" with "the".
 116         * amd64-windows-tdep.c: Replace "the the" with "the".
 117         * aarch64-tdep.c: Replace "the the" with "the".
 118
 119 2019-01-16  Keith Seitz  <keiths@redhat.com>
 120
 121         PR gdb/23773
 122         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
 123         <builder>: Rename to ..
 124         <m_builder>: ... this and make private.
 125         (dwarf2_cu::get_builder): New method.  Change all users of
 126         `builder' to use this method.
 127         (dwarf2_start_symtab): Move to ...
 128         (dwarf2_cu::start_symtab): ... here.  Update all callers
 129         (setup_type_unit_groups): Move to ...
 130         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
 131         callers.
 132         (dwarf2_cu::reset_builder): New method.
 133         (process_full_compunit, process_full_type_unit): Use
 134         dwarf2_cu::reset_builder.
 135         (follow_die_offset): Record the ancestor CU if it is different
 136         from the followed DIE's CU.
 137         (follow_die_sig_1): Likewise.
 138
 139 2019-01-15  Tom Tromey  <tom@tromey.com>
 140
 141         * remote.c (class remote_state) <buf>: Now a char_vector.
 142         <buf_size>: Remove.
 143         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
 144         parameter.
 145         (remote_target::getpkt_or_notif_sane_1)
 146         (remote_target::getpkt_sane)
 147         (remote_target::getpkt_or_notif_sane): Likewise.
 148         (class remote_target) <putpkt>: New overload.
 149         (remote_target::read_frame): Change type of "buf_p".  Remove
 150         sizeof_p parameter.
 151         (packet_ok): New overload.
 152         (packet_check_result): New overload.
 153         Update all uses.
 154
 155 2019-01-14  Tom Tromey  <tom@tromey.com>
 156
 157         * remote-notif.c (handle_notification, remote_notif_ack)
 158         (remote_notif_parse): Make "buf" const.
 159         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
 160         const.
 161         (remote_notif_parse, remote_notif_ack, handle_notification):
 162         Likewise.
 163         * remote.c (remote_notif_stop_parse): Make "buf" const.
 164         (remote_target::remote_parse_stop_reply): Make "buf" const.
 165         (remote_notif_stop_ack): Make "buf" const.
 166
 167 2019-01-14  Tom Tromey  <tom@tromey.com>
 168
 169         * remote.c (remote_console_output): Make parameter const.
 170
 171 2019-01-14  Tom Tromey  <tom@tromey.com>
 172
 173         * target-debug.h (target_debug_print_signals): Constify.
 174         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
 175         * procfs.c (procfs_target::pass_signals): Update.
 176         * linux-nat.c (linux_nat_target::pass_signals): Update.
 177         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
 178         * target-delegates.c: Rebuild.
 179         * remote.c (remote_target::program_signals): Update.
 180         (remote_target::pass_signals): Update.
 181         * target.c (target_pass_signals): Constify argument.
 182         (target_program_signals): Likewise.
 183         * target.h (struct target_ops) <pass_signals, program_signals>:
 184         Constify argument.
 185         (target_pass_signals, target_program_signals): Constify argument.
 186
 187 2019-01-14  Tom Tromey  <tom@tromey.com>
 188
 189         PR tui/28819:
 190         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
 191
 192 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 193
 194         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
 195         field.
 196         * rs6000-tdep.c: Include reggroups.h.
 197         (IS_V_ALIAS_PSEUDOREG): Define.
 198         (rs6000_register_name): Return names for the "vX" aliases.
 199         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
 200         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
 201         aliases.  Call default_register_reggroup_p for all other
 202         pseudo-registers.
 203         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
 204         New functions.
 205         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
 206         Handle "vX" aliases.
 207         (v_alias_pseudo_register_collect): New function.
 208         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
 209         (rs6000_gdbarch_init): Initialize "vX" aliases as
 210         pseudo-registers.  Restore registration of
 211         rs6000_pseudo_register_reggroup_p with
 212         set_tdesc_pseudo_register_reggroup_p.
 213
 214 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
 215
 216         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
 217         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
 218         set_gdbarch_num_pseudo_regs.
 219
 220 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 221
 222         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
 223         Remove arg prefixname, add do_set and do_show.
 224         Add member functions set_list and show_list.
 225         * cli/cli-style.c (class cli_style_option): Update accordingly.
 226         (style_set_list): Move to file scope.
 227         (style_show_list): Likewise.
 228         (set_style): Call help_list.
 229         (show_style): Call cmd_show_list.
 230         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
 231         Update to use the new macro.
 232
 233 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
 234
 235         * ada-lang.c (_initialize_ada_language): Expand the help text
 236         for the "catch exception" command.
 237
 238 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 239
 240         * symtab.c (matching_obj_sections): Initialize obj,
 241         declare it closer to its usage.
 242
 243 2019-01-10  Tom Tromey  <tom@tromey.com>
 244
 245         * thread-iter.h (inf_threads_iterator): Use next_iterator.
 246         (basic_inf_threads_range): Remove.
 247         (inf_threads_range, inf_non_exited_threads_range)
 248         (safe_inf_threads_range): Use next_adapter.
 249
 250 2019-01-10  Keith Seitz  <keiths@redhat.com>
 251
 252         PR gdb/23712
 253         PR symtab/23010
 254         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
 255         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
 256
 257 2019-01-10  Keith Seitz  <keiths@redhat.com>
 258
 259         PR gdb/23712
 260         PR symtab/23010
 261         * dictionary.c (pending_to_vector): Remove.
 262         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 263         Remove _1 suffix, replacing functions of the same name.  Update
 264         all callers.
 265         (dict_create_hashed, dict_create_hashed_expandable)
 266         (dict_create_linear, dict_create_linear_expandable, dict_free)
 267         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
 268         Make functions static.
 269
 270 2019-01-10  Keith Seitz  <keiths@redhat.com>
 271
 272         PR gdb/23712
 273         PR symtab/23010
 274         * dictionary.h (struct dictionary): Replace declaration with
 275         multidictionary.
 276         (dict_create_hashed, dict_create_hashed_expandable)
 277         (dict_create_linear, dict_create_linear_expandable)
 278         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
 279         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
 280         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
 281         taking multidictionary argument.
 282         [ALL_DICT_SYMBOLS]: Update for multidictionary.
 283         * block.h (struct block) <dict>: Change to multidictionary
 284         and rename `multidict'.
 285         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
 286         symmisc.c: Update all dictionary references to multidictionary.
 287
 288 2019-01-10  Keith Seitz  <keiths@redhat.com>
 289
 290         PR gdb/23712
 291         PR symtab/23010
 292         * dictionary.c: Include unordered_map.
 293         (pending_to_vector): New function.
 294         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 295         Rewrite the non-"_1" functions to take vector instead
 296         of linked list.
 297         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
 298         "new" _1 versions of the same name.
 299         (multidictionary): Define.
 300         (std::hash<enum language): New definition.
 301         (collate_pending_symbols_by_language, mdict_create_hashed)
 302         (mdict_create_hashed_expandable, mdict_create_linear)
 303         (mdict_create_linear_expandable, mdict_free)
 304         (find_language_dictionary, create_new_language_dictionary)
 305         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
 306         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
 307         (mdict_size, mdict_empty): New functions.
 308         * dictionary.h (mdict_iterator): Define.
 309
 310 2019-01-10  Pedro Alves  <palves@redhat.com>
 311
 312         * breakpoint.c (read_uploaded_action)
 313         (create_tracepoint_from_upload): Adjust to use
 314         gdb::unique_xmalloc_ptr.
 315         * ctf.c (ctf_write_uploaded_tp):
 316         (SET_ARRAY_FIELD): Use emplace_back.
 317         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
 318         * tracefile-tfile.c (tfile_write_uploaded_tp):
 319         * tracepoint.c (parse_tracepoint_definition): Adjust to use
 320         gdb::unique_xmalloc_ptr.
 321         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
 322         at_string, cond_string, cmd_strings>: Replace char pointers
 323         with gdb::unique_xmalloc_ptr.
 324
 325 2019-01-10  Pedro Alves  <palves@redhat.com>
 326
 327         * solib-target.c (library_list_start_library): Don't xstrdup name.
 328
 329 2019-01-10  Pedro Alves  <palves@redhat.com>
 330
 331         * mdebugread.c (parse_partial_symbols): Use
 332         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
 333
 334 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 335
 336         * linux-fork.c (scoped_switch_fork_info)
 337         <~scoped_switch_fork_info>: Fix incorrect variable name.
 338
 339 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 340
 341         * linux-fork.c (scoped_switch_fork_info)
 342         <scoped_switch_fork_info>: Make explicit.
 343         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
 344
 345 2019-01-10  Tom Tromey  <tom@tromey.com>
 346
 347         * objfiles.h (objfile::reset_psymtabs): Update.
 348         * objfiles.c (objfile::objfile): Update.
 349         * psymtab.h (psymtab_storage::obstack): Update.
 350         (psymtab_storage::m_obstack): Use gdb::optional.
 351         (class psymtab_storage): Update comment.  Remove objfile
 352         parameter.
 353         * psymtab.c (psymtab_storage::psymtab_storage): Update.
 354
 355 2019-01-10  Tom Tromey  <tom@tromey.com>
 356
 357         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
 358         <free_psymtabs>: Now private.
 359         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
 360         (allocate_psymtab): Use new method.
 361
 362 2019-01-10  Tom Tromey  <tom@tromey.com>
 363
 364         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
 365         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
 366         * mdebugread.c (parse_partial_symbols): Use
 367         allocate_dependencies.
 368         * dwarf2read.c (dwarf2_create_include_psymtab): Use
 369         allocate_dependencies.
 370         (process_psymtab_comp_unit_reader)
 371         (build_type_psymtab_dependencies): Likewise.
 372         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
 373
 374 2019-01-10  Tom Tromey  <tom@tromey.com>
 375
 376         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
 377         PSYMBOL_SET_LANGUAGE.
 378         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
 379
 380 2019-01-10  Tom Tromey  <tom@tromey.com>
 381
 382         * psymtab.h (psymtab_storage::obstack): New method.
 383         <m_obstack>: Rename from obstack; now private.
 384         * psymtab.c (psymtab_storage): Update.
 385         * dwarf2read.c (create_addrmap_from_index)
 386         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
 387         Update.
 388
 389 2019-01-10  Tom Tromey  <tom@tromey.com>
 390
 391         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
 392         * objfiles.h (objfile::reset_psymtabs): New method.
 393
 394 2019-01-10  Tom Tromey  <tom@tromey.com>
 395
 396         * symmisc.c (print_symbol_bcache_statistics): Update.
 397         (print_objfile_statistics): Update.
 398         * symfile.c (reread_symbols): Update.
 399         * psymtab.h (class psymtab_storage): New.
 400         * psymtab.c (psymtab_storage): New constructor.
 401         (~psymtab_storage): New destructor.
 402         (require_partial_symbols): Update.
 403         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
 404         (find_pc_sect_psymtab, find_pc_sect_psymbol)
 405         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
 406         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
 407         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
 408         (start_psymtab_common, end_psymtab_common)
 409         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
 410         (allocate_psymtab): Update.
 411         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
 412         Update.
 413         (dump_psymtab_addrmap, maintenance_print_psymbols)
 414         (maintenance_check_psymtabs): Update.
 415         (class objfile_psymtabs): Move to objfiles.h.
 416         * psympriv.h (discard_psymtab): Now inline.
 417         (psymtab_discarder::psymtab_discarder): Update.
 418         (psymtab_discarder::~psymtab_discarder): Update.
 419         (ALL_OBJFILE_PSYMTABS): Rewrite.
 420         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
 421         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
 422         Remove fields.
 423         <partial_symtabs>: New field.
 424         (class objfile_psymtabs): Move from psymtab.h.  Update.
 425         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
 426         psymbol_cache.
 427         (objfile::~objfile): Don't destroy psymbol_cache.
 428         * mdebugread.c (parse_partial_symbols): Update.
 429         * dwarf2read.c (create_addrmap_from_index)
 430         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 431         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
 432         (add_partial_subprogram, dwarf2_ranges_read): Update.
 433         * dwarf-index-write.c (write_address_map)
 434         (write_one_signatured_type, recursively_write_psymbols)
 435         (class debug_names, class debug_names, write_psymtabs_to_index):
 436         Update.
 437
 438 2019-01-10  Tom Tromey  <tom@tromey.com>
 439
 440         * symtab.h (SYMBOL_SET_NAMES): Update.
 441         (symbol_set_names): Update.
 442         (MSYMBOL_SET_NAMES): Update.
 443         * symtab.c (symbol_set_names): Change argument to be an
 444         objfile_per_bfd_storage.
 445         * psymtab.c (add_psymbol_to_bcache): Update.
 446         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
 447
 448 2019-01-10  Tom Tromey  <tom@tromey.com>
 449
 450         * symtab.c (create_demangled_names_hash): Change argument to be an
 451         objfile_per_bfd_storage.
 452         (symbol_set_names): Update.
 453
 454 2019-01-10  Tom Tromey  <tom@tromey.com>
 455
 456         * xcoffread.c (xcoff_initial_scan): Unconditionally call
 457         init_psymbol_list.
 458         * psymtab.c (init_psymbol_list): Do nothing if already called.
 459         * psympriv.h (init_psymbol_list): Add comment.
 460         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
 461         init_psymbol_list.
 462         * dbxread.c (dbx_symfile_read): Unconditionally call
 463         init_psymbol_list.
 464
 465 2019-01-10  Tom Tromey  <tom@tromey.com>
 466
 467         * xcoffread.c (scan_xcoff_symtab): Update.
 468         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
 469         "where".
 470         * mdebugread.c (parse_partial_symbols)
 471         (handle_psymbol_enumerators): Update.
 472         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
 473         * dbxread.c (read_dbx_symtab): Update.
 474         * psympriv.h (psymbol_placement): New enum.
 475         (add_psymbol_to_list): Update.
 476
 477 2019-01-10  Tom Tromey  <tom@tromey.com>
 478
 479         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
 480         static_psymbols parameters.
 481         (scan_xcoff_symtab): Update.
 482         * psymtab.c (start_psymtab_common): Remove global_psymbols and
 483         static_psymbols parameters.
 484         * psympriv.h (start_psymtab_common): Update.
 485         * mdebugread.c (parse_partial_symbols): Update.
 486         * dwarf2read.c (create_partial_symtab): Update.
 487         * dbxread.c (read_dbx_symtab): Update.
 488         (start_psymtab): Remove global_psymbols and static_psymbols
 489         parameters.
 490
 491 2019-01-10  Tom Tromey  <tom@tromey.com>
 492
 493         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
 494         * psymtab.c (allocate_psymtab): Add comment.
 495         * psympriv.h (allocate_psymtab): Add comment.
 496         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
 497         initializations.
 498         * dbxread.c (dbx_end_psymtab): Remove some initializations.
 499
 500 2019-01-10  Tom Tromey  <tom@tromey.com>
 501
 502         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 503         Don't declare.
 504         * mipsread.c: Include mdebugread.h.
 505         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 506         Declare.
 507         * elfread.c: Include mdebugread.h.
 508
 509 2019-01-09  Tom Tromey  <tom@tromey.com>
 510
 511         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
 512         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
 513         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
 514         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 515         (psym_lookup_symbol, psym_find_last_source_symtab)
 516         (psym_forget_cached_source_info, psym_print_stats)
 517         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 518         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 519         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 520         (psym_find_compunit_symtab_by_address)
 521         (maintenance_print_psymbols, maintenance_info_psymtabs)
 522         (maintenance_check_psymtabs): Use ranged for.
 523         * psymtab.h (class objfile_psymtabs): New.
 524         (require_partial_symbols): Return objfile_psymtabs.
 525         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
 526
 527 2019-01-09  Tom Tromey  <tom@tromey.com>
 528
 529         * symfile.c (overlay_invalidate_all, find_pc_overlay)
 530         (find_pc_mapped_section, list_overlays_command)
 531         (map_overlay_command, unmap_overlay_command)
 532         (simple_overlay_update): Use all_objfiles.
 533         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
 534         * printcmd.c (info_symbol_command): Use all_objfiles.
 535         * objfiles.h (ALL_OBJSECTIONS): Remove.
 536         * maint.c (maintenance_translate_address): Use all_objfiles.
 537         * gcore.c (gcore_create_callback): Use all_objfiles.
 538         (objfile_find_memory_regions): Likewise.
 539
 540 2019-01-09  Tom Tromey  <tom@tromey.com>
 541
 542         * symtab.c (find_line_symtab, info_sources_command)
 543         (make_source_files_completion_list): Use objfile_compunits.
 544         * source.c (select_source_symtab): Use objfile_compunits.
 545         * objfiles.h (struct objfile): Update comment.
 546         (ALL_OBJFILES): Remove.
 547         (ALL_FILETABS): Remove.
 548         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
 549         objfile_compunits.
 550
 551 2019-01-09  Tom Tromey  <tom@tromey.com>
 552
 553         * symmisc.c (print_objfile_statistics, dump_objfile)
 554         (maintenance_print_symbols): Use compunit_filetabs.
 555         * source.c (forget_cached_source_info_for_objfile): Use
 556         compunit_filetabs.
 557         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
 558         (ALL_FILETABS): Use compunit_filetabs.
 559         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
 560         * coffread.c (coff_symtab_read): Use compunit_filetabs.
 561
 562 2019-01-09  Tom Tromey  <tom@tromey.com>
 563
 564         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
 565         (compunit_filetabs): New.
 566         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
 567         compunit_filetabs.
 568         (info_sources_command, make_source_files_completion_list): Remove
 569         declaration.
 570         * symmisc.c (print_objfile_statistics, dump_objfile)
 571         (maintenance_print_symbols): Remove declaration.
 572         (maintenance_info_symtabs): Use compunit_filetabs.
 573         (maintenance_info_line_tables): Likewise.
 574         * source.c (select_source_symtab): Change local variable name.
 575         (forget_cached_source_info_for_objfile): Remove declaration.
 576         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
 577         * objfiles.c (objfile_relocate1): Remove declaration.
 578         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 579         declaration.
 580         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
 581         * coffread.c (coff_symtab_read): Remove declaration.
 582         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 583         compunit_filetabs.
 584
 585 2019-01-09  Tom Tromey  <tom@tromey.com>
 586
 587         * symtab.c (lookup_objfile_from_block)
 588         (find_pc_sect_compunit_symtab, search_symbols)
 589         (default_collect_symbol_completion_matches_break_on): Use
 590         objfile_compunits.
 591         * objfiles.h (ALL_COMPUNITS): Remove.
 592         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
 593         * cp-support.c (add_symbol_overload_list_qualified): Use
 594         objfile_compunits.
 595         * ada-lang.c (ada_collect_symbol_completion_matches)
 596         (ada_add_global_exceptions): Use objfile_compunits.
 597
 598 2019-01-09  Tom Tromey  <tom@tromey.com>
 599
 600         * source.c (select_source_symtab)
 601         (forget_cached_source_info_for_objfile): Remove declaration.
 602         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 603         declaration.
 604         * maint.c (count_symtabs_and_blocks): Remove declaration.
 605         * cp-support.c (add_symbol_overload_list_qualified): Remove
 606         declaration.
 607         * coffread.c (coff_symtab_read): Remove declaration.
 608         * symtab.c (lookup_symbol_in_objfile_symtabs)
 609         (basic_lookup_transparent_type_1): Use objfile_compunits.
 610         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
 611         (info_sources_command, search_symbols)
 612         (default_collect_symbol_completion_matches_break_on)
 613         (make_source_files_completion_list): Remove declaration.
 614         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
 615         (ada_collect_symbol_completion_matches)
 616         (ada_add_global_exceptions): Remove declaration.
 617         * linespec.c (iterate_over_all_matching_symtabs): Use
 618         objfile_compunits.
 619         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
 620         (class objfile_compunits): New.
 621         (ALL_COMPUNITS): Use objfile_compunits.
 622         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
 623         (maintenance_check_symtabs, maintenance_info_line_tables): Use
 624         objfile_compunits.
 625         * objfiles.c (objfile_relocate1): Use objfile_compunits.
 626
 627 2019-01-09  Tom Tromey  <tom@tromey.com>
 628
 629         * symtab.c (search_symbols)
 630         (default_collect_symbol_completion_matches_break_on): Use
 631         objfile_msymbols.
 632         * ada-lang.c (ada_lookup_simple_minsym)
 633         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
 634         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
 635         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
 636         objfile_msymbols.
 637         * coffread.c (coff_symfile_read): Use objfile_msymbols.
 638         * symmisc.c (dump_msymbols): Use objfile_msymbols.
 639         * objc-lang.c (find_methods): Use objfile_msymbols.
 640         (info_selectors_command, info_classes_command): Likewise.
 641         * stabsread.c (scan_file_globals): Use objfile_msymbols.
 642         * objfiles.h (class objfile_msymbols): New.
 643         (ALL_OBJFILE_MSYMBOLS): Remove.
 644         (ALL_MSYMBOLS): Remove.
 645
 646 2019-01-09  Tom Tromey  <tom@tromey.com>
 647
 648         * common/next-iterator.h (next_adapter): Add Iterator template
 649         parameter.
 650         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
 651         (class all_objfiles_safe): New.
 652         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
 653         * objfiles.c (put_objfile_before): Update comment.
 654         (add_separate_debug_objfile): Likewise.
 655         (free_all_objfiles): Use all_objfiles_safe.
 656         (objfile_purge_solibs): Likewise.
 657
 658 2019-01-09  Tom Tromey  <tom@tromey.com>
 659
 660         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 661         (expand_symtab_containing_pc, lookup_static_symbol)
 662         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
 663         (find_symbol_at_address, find_line_symtab, find_main_name): Use
 664         all_objfiles.
 665         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
 666         * breakpoint.c (create_overlay_event_breakpoint)
 667         (create_longjmp_master_breakpoint)
 668         (create_std_terminate_master_breakpoint)
 669         (create_exception_master_breakpoint): Use all_objfiles.
 670         * linux-thread-db.c (try_thread_db_load_from_pdir)
 671         (has_libpthread): Use all_objfiles.
 672         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
 673         * linespec.c (iterate_over_all_matching_symtabs)
 674         (search_minsyms_for_name): Use all_objfiles.
 675         * maint.c (maintenance_info_sections): Use all_objfiles.
 676         * main.c (captured_main_1): Use all_objfiles.
 677         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
 678         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
 679         * guile/scm-pretty-print.c
 680         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
 681         * solib-spu.c (append_ocl_sos): Use all_objfiles.
 682         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
 683         (maintenance_print_msymbols): Use all_objfiles.
 684         * source.c (select_source_symtab): Use all_objfiles.
 685         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
 686         * symfile.c (remove_symbol_file_command)
 687         (expand_symtabs_matching, map_symbol_filenames): Use
 688         all_objfiles.
 689         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
 690         all_objfiles.
 691         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
 692         * objc-lang.c (find_methods): Use all_objfiles.
 693         * objfiles.c (have_partial_symbols, have_full_symbols)
 694         (have_minimal_symbols, qsort_cmp)
 695         (default_iterate_over_objfiles_in_search_order): Use
 696         all_objfiles.
 697         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
 698         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
 699         (maintenance_check_psymtabs): Use all_objfiles.
 700         (ALL_PSYMTABS): Remove.
 701         * compile/compile-object-run.c (do_module_cleanup): Use
 702         all_objfiles.
 703         * blockframe.c (find_pc_partial_function): Use all_objfiles.
 704         * cp-support.c (add_symbol_overload_list_qualified): Use
 705         all_objfiles.
 706         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 707         Use all_objfiles.
 708         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
 709         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
 710         all_objfiles.
 711         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 712         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
 713         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 714         Uses all_objfiles.
 715         * solib.c (solib_read_symbols): Use all_objfiles
 716
 717 2019-01-09  Tom Tromey  <tom@tromey.com>
 718
 719         * probe.c (parse_probes_in_pspace): Use all_objfiles.
 720         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
 721         all_objfiles.
 722         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
 723         * symmisc.c (print_symbol_bcache_statistics)
 724         (print_objfile_statistics, maintenance_print_objfiles)
 725         (maintenance_info_symtabs, maintenance_check_symtabs)
 726         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
 727         all_objfiles.
 728         * source.c (forget_cached_source_info): Use all_objfiles.
 729         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
 730         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 731         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
 732         * objfiles.c (update_section_map): Use all_objfiles.
 733         (shared_objfile_contains_address_p): Likewise.
 734         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
 735         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
 736
 737 2019-01-09  Tom Tromey  <tom@tromey.com>
 738
 739         * common/next-iterator.h: New file.
 740         * objfiles.h (class all_objfiles): New.
 741         (struct objfile_iterator): New.
 742
 743 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 744
 745         * NEWS: Move the description of the changed "frame", "select-frame",
 746          and "info frame" commands to the Changed commands section.
 747
 748 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
 749
 750         * gdbtypes.c (check_stub_method_group): Remove handling of old
 751         mangling schemes.
 752         * linespec.c (find_methods): Likewise.
 753         * stabsread.c (read_member_functions): Likewise.
 754         * valops.c (search_struct_method): Likewise.
 755         (value_struct_elt_for_reference): Likewise.
 756         * NEWS: Mention this change.
 757
 758 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 759
 760         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
 761         print_source_lines.
 762         * source.c (print_source_lines_base): Update line number check.
 763         (print_source_lines): New function.
 764         (source_lines_range::source_lines_range): New function.
 765         * source.h (class source_lines_range): New class.
 766         (print_source_lines): New declaration.
 767
 768 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 769
 770         * linespec.c (linespec_state_destructor): Free self->canonical_names.
 771
 772 2019-01-08  Tom Tromey  <tom@tromey.com>
 773             Simon Marchi  <simon.marchi@ericsson.com>
 774
 775         PR gdb/24060
 776         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
 777         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
 778         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 779         * f-exp.y (DOLLAR_VARIABLE): Likewise.
 780         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
 781         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 782
 783 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 784
 785         * source.c (select_source_symtab): Move header comment to
 786         declaration in source.h.
 787         (forget_cached_source_info_for_objfile): Likewise.
 788         (forget_cached_source_info): Likewise.
 789         (identify_source_line): Likewise.
 790         * source.h (identify_source_line): Move declaration from symtab.h
 791         and add comment from source.c
 792         (print_source_lines): Likewise.
 793         (forget_cached_source_info_for_objfile): Likewise.
 794         (forget_cached_source_info): Likewise.
 795         (select_source_symtab): Likewise.
 796         (enum print_source_lines_flag): Move definition from symtab.h.
 797         * symtab.h (identify_source_line): Move declaration to source.h.
 798         (print_source_lines): Likewise.
 799         (forget_cached_source_info_for_objfile): Likewise.
 800         (forget_cached_source_info): Likewise.
 801         (select_source_symtab): Likewise.
 802         (enum print_source_lines_flag): Move definition to source.h.
 803         * tui/tui-hooks.c: Add 'source.h' include.
 804
 805 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 806
 807         * source.c (print_source_lines_base): Handle requests to print
 808         reverse line number sequences, and guard against empty lines
 809         string.
 810
 811 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 812
 813         * source.c (print_source_lines_base): Fix skip of '\r' if next
 814         character is '\n'.
 815
 816 2019-01-06  Tom Tromey  <tom@tromey.com>
 817
 818         * c-exp.y (struct c_parse_state) <macro_original_text,
 819         expansion_obstack>: New member.
 820         (macro_original_text, expansion_obstack): Remove globals.
 821         (scan_macro_expansion, scanning_macro_expansion)
 822         (finished_macro_expansion): Update.
 823         (scan_macro_cleanup): Remove.
 824         (yylex, c_parse): Update.
 825
 826 2019-01-06  Tom Tromey  <tom@tromey.com>
 827
 828         * c-exp.y (struct c_parse_state) <strings>: New member.
 829         (operator_stoken): Update.
 830
 831 2019-01-06  Tom Tromey  <tom@tromey.com>
 832
 833         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
 834         (union type_stack_elt) <typelist_val>: Now a pointer to
 835         std::vector.
 836         (type_stack_cleanup): Don't declare.
 837         (push_typelist): Update.
 838         * parse.c (pop_typelist): Return a std::vector.
 839         (push_typelist): Take a std::vector.
 840         (follow_types): Update.  Do not free args.
 841         (type_stack_cleanup): Remove.
 842         * c-exp.y (struct c_parse_state): New.
 843         (cpstate): New global.
 844         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
 845         (nonempty_typelist): Update.
 846         (func_mod): Create a new vector.
 847         (c_parse): Create a c_parse_state.
 848         (check_parameter_typelist): Do not delete params.
 849         (function_method): Update.  Do not delete type_list.
 850
 851 2019-01-06  Tom Tromey  <tom@tromey.com>
 852
 853         PR gdb/28155:
 854         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
 855         check_typedef.
 856         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
 857         (print_return_value): Likewise.
 858
 859 2019-01-05  Tom Tromey  <tom@tromey.com>
 860
 861         * contrib/cleanup_check.py: Remove.
 862         * contrib/gcc-with-excheck: Remove.
 863         * contrib/exsummary.py: Remove.
 864         * contrib/excheck.py: Remove.
 865
 866 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
 867
 868         * thread.c (delete_thread_1): Add gdb_assert that THR is not
 869         NULL. Initialize tpprev to NULL instead of assigning it
 870         to NULL on the next statement.
 871         * windows-nat.c (windows_delete_thread): Remove check for
 872         main_thread_id before printing thread exit notifications.
 873         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
 874         Remove thread ID check against main_thread_id.
 875         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
 876         windows_delete_thread.
 877         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
 878
 879 2019-01-04  Tom Tromey  <tom@tromey.com>
 880
 881         * compile/compile.c (_initialize_compile): Use upper case for
 882         metasyntactic variables.
 883         * symmisc.c (_initialize_symmisc): Use upper case for
 884         metasyntactic variables.
 885         * psymtab.c (_initialize_psymtab): Use upper case for
 886         metasyntactic variables.
 887         * demangle.c (demangle_command): Use upper case for metasyntactic
 888         variables.
 889         (_initialize_demangler): Likewise.
 890         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
 891         variables.
 892
 893 2019-01-03  Tom Tromey  <tom@tromey.com>
 894
 895         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
 896
 897 2019-01-03  Tom Tromey  <tom@tromey.com>
 898
 899         * python/py-symtab.c (salpy_str): Update.
 900         (struct salpy_sal_object) <symtab>: Now a PyObject.
 901         (salpy_dealloc): Update.
 902         (del_objfile_sal): Use gdbpy_ref.
 903
 904 2019-01-03  Tom Tromey  <tom@tromey.com>
 905
 906         * python/py-type.c (convert_field): Use new_reference.  Return
 907         gdbpy_ref.
 908         (make_fielditem): Return gdbpy_ref.
 909         (typy_fields): Update.
 910         (typy_getitem): Update.
 911         (field_name): Return gdbpy_ref.  Use new_reference.
 912         (typy_iterator_iternext): Update.
 913
 914 2019-01-03  Tom Tromey  <tom@tromey.com>
 915
 916         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
 917
 918 2019-01-03  Tom Tromey  <tom@tromey.com>
 919
 920         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
 921         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
 922         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
 923         (pspy_set_frame_filters, pspy_set_frame_unwinders)
 924         (pspy_set_type_printers): Likewise.
 925         * python/py-function.c (fnpy_init): Use gdbpy_ref.
 926         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
 927         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
 928         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
 929         (objfpy_set_type_printers): Likewise.
 930
 931 2019-01-03  Tom Tromey  <tom@tromey.com>
 932
 933         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
 934         (gdbpy_print_stack): Use gdbpy_err_fetch.
 935         * python/python-internal.h (class gdbpy_err_fetch): New class.
 936         (class gdbpy_enter) <m_error_type, m_error_value,
 937         m_error_traceback>: Remove.
 938         <m_error>: New member.
 939         (gdbpy_exception_to_string): Don't declare.
 940         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
 941         * python/py-value.c (convert_value_from_python): Use
 942         gdbpy_err_fetch.
 943         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
 944         gdbpy_exception_to_string.
 945         (gdbpy_handle_exception): Use gdbpy_err_fetch.
 946         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 947         gdbpy_err_fetch.
 948
 949 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 950
 951         * linux-nat.c (delete_lwp_cleanup): Delete.
 952         (struct lwp_deleter): New struct.
 953         (lwp_info_up): New typedef.
 954         (linux_nat_target::follow_fork): Delete cleanup, and make use of
 955         lwp_info_up.
 956
 957 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 958
 959         * linux-fork.c (class scoped_switch_fork_info): New class.
 960         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
 961
 962 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 963
 964         * valops.c (find_overload_match): Remove use of null_cleanup, and
 965         calls to do_cleanups.
 966
 967 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 968
 969         * compile/compile-cplus-types.c
 970         (compile_cplus_instance::decl_name): Handle changes to
 971         cp_func_name.
 972         * cp-support.c (cp_func_name): Update header comment, update
 973         return type.
 974         * cp-support.h (cp_func_name): Update return type in declaration.
 975         * valops.c (find_overload_match): Move temp_func local to top
 976         level of function and change its type.  Use temp_func to hold and
 977         delete temporary string obtained from cp_func_name.
 978
 979 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 980
 981         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
 982         gdb::char_vector, remove cleanup, and update uses of `msg`.
 983
 984 2019-01-03  Jim Wilson  <jimw@sifive.com>
 985
 986         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
 987
 988 2019-01-02  Tom Tromey  <tom@tromey.com>
 989
 990         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
 991         (tdesc_parse_xml): Remove cleanups.
 992         * target-descriptions.h (make_cleanup_free_target_description):
 993         Don't declare.
 994         (target_desc_deleter): New struct.
 995         (target_desc_up): New typedef.
 996         * target-descriptions.c (target_desc_deleter::operator()): Rename
 997         from free_target_description.
 998         (make_cleanup_free_target_description): Remove.
 999
1000 2019-01-02  Tom Tromey  <tom@tromey.com>
1001
1002         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1003         constructor, destructor.
1004         (linespec_parser): Remove typedef.
1005         (~linespec_parser): Rename from linespec_parser_delete.
1006         (linespec_lex_to_end, linespec_complete_label)
1007         (linespec_complete): Update.
1008         (decode_line_full): Remove cleanups.
1009         (decode_line_1): Update.
1010
1011 2019-01-02  Tom Tromey  <tom@tromey.com>
1012
1013         * python/python-internal.h (inferior_to_inferior_object): Change
1014         return type.
1015         * python/py-exitedevent.c (create_exited_event_object): Update.
1016         * python/py-inferior.c (inferior_to_inferior_object): Return
1017         gdbpy_ref.
1018         (python_new_inferior, python_inferior_deleted)
1019         (thread_to_thread_object, delete_thread_object)
1020         (build_inferior_list, gdbpy_selected_inferior): Update.
1021         * python/py-infthread.c (create_thread_object): Update.  Also fail
1022         if inferior_to_inferior_object fails.
1023
1024 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1025
1026         * inferior.h (class inferior) <displaced_step_state>: New field.
1027         * infrun.h (struct displaced_step_state): Move here from
1028         infrun.c.  Initialize fields, add constructor.
1029         <inf>: Remove field.
1030         <reset>: New method.
1031         * infrun.c (struct displaced_step_inferior_state): Move to
1032         infrun.h.
1033         (displaced_step_inferior_states): Remove.
1034         (get_displaced_stepping_state): Adust.
1035         (displaced_step_in_progress_any_inferior): Adjust.
1036         (displaced_step_in_progress_thread): Adjust.
1037         (displaced_step_in_progress): Adjust.
1038         (add_displaced_stepping_state): Remove.
1039         (get_displaced_step_closure_by_addr): Adjust.
1040         (remove_displaced_stepping_state): Remove.
1041         (infrun_inferior_exit): Call displaced_step_state.reset.
1042         (use_displaced_stepping): Don't check for NULL.
1043         (displaced_step_prepare_throw): Call
1044         get_displaced_stepping_state.
1045         (displaced_step_fixup): Don't check for NULL.
1046         (prepare_for_detach): Don't check for NULL.
1047
1048 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1049
1050         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
1051          in case of call that did not complete.
1052
1053 2019-01-02  Andrey Utkin  <autkin@undo.io>
1054
1055         * symfile.c (find_separate_debug_file): Fix search of debug files for
1056         remote debuggee.
1057
1058 2019-01-02  Tom Tromey  <tom@tromey.com>
1059
1060         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
1061         indentation.
1062         * python/py-frame.c (frapy_older): Remove cast.
1063         (frapy_newer): Likewise.
1064         * python/py-breakpoint.c (local_setattro): Remove cast.
1065         * python/py-arch.c (archpy_name): Remove local variable.
1066         * python/py-type.c (gdbpy_lookup_type): Remove cast.
1067
1068 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
1069
1070         * unittests/basic_string_view/element_access/char/empty.cc:
1071         Fix year range in copyright header.
1072
1073 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1074
1075         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
1076         Delete.
1077         <operator==>: Update with for removed field.
1078         <hash>: Likewise.
1079         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
1080         <isa_features>: ...this.
1081         <abi_features>: New field.
1082         (riscv_isa_flen): Update comment.
1083         (riscv_abi_xlen): New declaration.
1084         (riscv_abi_flen): New declaration.
1085         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
1086         isa_features.
1087         (riscv_abi_xlen): New function.
1088         (riscv_isa_flen): Update to get answer from isa_features.
1089         (riscv_abi_flen): New function.
1090         (riscv_has_fp_abi): Update to get answer from abi_features.
1091         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
1092         xlen and flen.
1093         (riscv_call_info) <xlen, flen>: Update comment.
1094         (riscv_call_arg_struct): Remove invalid assertions
1095         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
1096         is removed.
1097         (riscv_gdbarch_init): Gather isa features and abi features
1098         separately, ensure both match on the gdbarch when reusing an old
1099         gdbarch.  Relax an error check to allow 32-bit abi float to run on
1100         a target with 64-bit float hardware.
1101
1102 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1103
1104         * source.c (search_command_helper): Stop reverse search
1105         when line 1 has been searched.
1106
1107 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1108
1109         * record-full.c (record_full_base_target::close): Rewrite
1110         record_full_core_buf_list free logic.
1111
1112 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1113
1114         * break-catch-syscall.c (print_one_catch_syscall): xfree
1115         the last text.
1116
1117 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1118
1119         * top.c (print_gdb_version): Update Copyright year in version
1120         message.
1121
1122 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1123
1124         Update copyright year range in all GDB files.
1125
1126 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
1127
1128         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
1129
1130 For older changes see ChangeLog-2018.
1131 \f
1132 Local Variables:
1133 mode: change-log
1134 left-margin: 8
1135 fill-column: 74
1136 version-control: never
1137 coding: utf-8
1138 End:
1139