gdb/ChangeLog

   1 2019-01-10  Tom Tromey  <tom@tromey.com>
   2
   3         * thread-iter.h (inf_threads_iterator): Use next_iterator.
   4         (basic_inf_threads_range): Remove.
   5         (inf_threads_range, inf_non_exited_threads_range)
   6         (safe_inf_threads_range): Use next_adapter.
   7
   8 2019-01-10  Keith Seitz  <keiths@redhat.com>
   9
  10         PR gdb/23712
  11         PR symtab/23010
  12         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
  13         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
  14
  15 2019-01-10  Keith Seitz  <keiths@redhat.com>
  16
  17         PR gdb/23712
  18         PR symtab/23010
  19         * dictionary.c (pending_to_vector): Remove.
  20         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
  21         Remove _1 suffix, replacing functions of the same name.  Update
  22         all callers.
  23         (dict_create_hashed, dict_create_hashed_expandable)
  24         (dict_create_linear, dict_create_linear_expandable, dict_free)
  25         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
  26         Make functions static.
  27
  28 2019-01-10  Keith Seitz  <keiths@redhat.com>
  29
  30         PR gdb/23712
  31         PR symtab/23010
  32         * dictionary.h (struct dictionary): Replace declaration with
  33         multidictionary.
  34         (dict_create_hashed, dict_create_hashed_expandable)
  35         (dict_create_linear, dict_create_linear_expandable)
  36         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
  37         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
  38         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
  39         taking multidictionary argument.
  40         [ALL_DICT_SYMBOLS]: Update for multidictionary.
  41         * block.h (struct block) <dict>: Change to multidictionary
  42         and rename `multidict'.
  43         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
  44         symmisc.c: Update all dictionary references to multidictionary.
  45
  46 2019-01-10  Keith Seitz  <keiths@redhat.com>
  47
  48         PR gdb/23712
  49         PR symtab/23010
  50         * dictionary.c: Include unordered_map.
  51         (pending_to_vector): New function.
  52         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
  53         Rewrite the non-"_1" functions to take vector instead
  54         of linked list.
  55         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
  56         "new" _1 versions of the same name.
  57         (multidictionary): Define.
  58         (std::hash<enum language): New definition.
  59         (collate_pending_symbols_by_language, mdict_create_hashed)
  60         (mdict_create_hashed_expandable, mdict_create_linear)
  61         (mdict_create_linear_expandable, mdict_free)
  62         (find_language_dictionary, create_new_language_dictionary)
  63         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
  64         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
  65         (mdict_size, mdict_empty): New functions.
  66         * dictionary.h (mdict_iterator): Define.
  67
  68 2019-01-10  Pedro Alves  <palves@redhat.com>
  69
  70         * breakpoint.c (read_uploaded_action)
  71         (create_tracepoint_from_upload): Adjust to use
  72         gdb::unique_xmalloc_ptr.
  73         * ctf.c (ctf_write_uploaded_tp):
  74         (SET_ARRAY_FIELD): Use emplace_back.
  75         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
  76         * tracefile-tfile.c (tfile_write_uploaded_tp):
  77         * tracepoint.c (parse_tracepoint_definition): Adjust to use
  78         gdb::unique_xmalloc_ptr.
  79         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
  80         at_string, cond_string, cmd_strings>: Replace char pointers
  81         with gdb::unique_xmalloc_ptr.
  82
  83 2019-01-10  Pedro Alves  <palves@redhat.com>
  84
  85         * solib-target.c (library_list_start_library): Don't xstrdup name.
  86
  87 2019-01-10  Pedro Alves  <palves@redhat.com>
  88
  89         * mdebugread.c (parse_partial_symbols): Use
  90         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
  91
  92 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
  93
  94         * linux-fork.c (scoped_switch_fork_info)
  95         <~scoped_switch_fork_info>: Fix incorrect variable name.
  96
  97 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
  98
  99         * linux-fork.c (scoped_switch_fork_info)
 100         <scoped_switch_fork_info>: Make explicit.
 101         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
 102
 103 2019-01-10  Tom Tromey  <tom@tromey.com>
 104
 105         * objfiles.h (objfile::reset_psymtabs): Update.
 106         * objfiles.c (objfile::objfile): Update.
 107         * psymtab.h (psymtab_storage::obstack): Update.
 108         (psymtab_storage::m_obstack): Use gdb::optional.
 109         (class psymtab_storage): Update comment.  Remove objfile
 110         parameter.
 111         * psymtab.c (psymtab_storage::psymtab_storage): Update.
 112
 113 2019-01-10  Tom Tromey  <tom@tromey.com>
 114
 115         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
 116         <free_psymtabs>: Now private.
 117         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
 118         (allocate_psymtab): Use new method.
 119
 120 2019-01-10  Tom Tromey  <tom@tromey.com>
 121
 122         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
 123         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
 124         * mdebugread.c (parse_partial_symbols): Use
 125         allocate_dependencies.
 126         * dwarf2read.c (dwarf2_create_include_psymtab): Use
 127         allocate_dependencies.
 128         (process_psymtab_comp_unit_reader)
 129         (build_type_psymtab_dependencies): Likewise.
 130         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
 131
 132 2019-01-10  Tom Tromey  <tom@tromey.com>
 133
 134         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
 135         PSYMBOL_SET_LANGUAGE.
 136         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
 137
 138 2019-01-10  Tom Tromey  <tom@tromey.com>
 139
 140         * psymtab.h (psymtab_storage::obstack): New method.
 141         <m_obstack>: Rename from obstack; now private.
 142         * psymtab.c (psymtab_storage): Update.
 143         * dwarf2read.c (create_addrmap_from_index)
 144         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
 145         Update.
 146
 147 2019-01-10  Tom Tromey  <tom@tromey.com>
 148
 149         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
 150         * objfiles.h (objfile::reset_psymtabs): New method.
 151
 152 2019-01-10  Tom Tromey  <tom@tromey.com>
 153
 154         * symmisc.c (print_symbol_bcache_statistics): Update.
 155         (print_objfile_statistics): Update.
 156         * symfile.c (reread_symbols): Update.
 157         * psymtab.h (class psymtab_storage): New.
 158         * psymtab.c (psymtab_storage): New constructor.
 159         (~psymtab_storage): New destructor.
 160         (require_partial_symbols): Update.
 161         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
 162         (find_pc_sect_psymtab, find_pc_sect_psymbol)
 163         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
 164         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
 165         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
 166         (start_psymtab_common, end_psymtab_common)
 167         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
 168         (allocate_psymtab): Update.
 169         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
 170         Update.
 171         (dump_psymtab_addrmap, maintenance_print_psymbols)
 172         (maintenance_check_psymtabs): Update.
 173         (class objfile_psymtabs): Move to objfiles.h.
 174         * psympriv.h (discard_psymtab): Now inline.
 175         (psymtab_discarder::psymtab_discarder): Update.
 176         (psymtab_discarder::~psymtab_discarder): Update.
 177         (ALL_OBJFILE_PSYMTABS): Rewrite.
 178         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
 179         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
 180         Remove fields.
 181         <partial_symtabs>: New field.
 182         (class objfile_psymtabs): Move from psymtab.h.  Update.
 183         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
 184         psymbol_cache.
 185         (objfile::~objfile): Don't destroy psymbol_cache.
 186         * mdebugread.c (parse_partial_symbols): Update.
 187         * dwarf2read.c (create_addrmap_from_index)
 188         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 189         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
 190         (add_partial_subprogram, dwarf2_ranges_read): Update.
 191         * dwarf-index-write.c (write_address_map)
 192         (write_one_signatured_type, recursively_write_psymbols)
 193         (class debug_names, class debug_names, write_psymtabs_to_index):
 194         Update.
 195
 196 2019-01-10  Tom Tromey  <tom@tromey.com>
 197
 198         * symtab.h (SYMBOL_SET_NAMES): Update.
 199         (symbol_set_names): Update.
 200         (MSYMBOL_SET_NAMES): Update.
 201         * symtab.c (symbol_set_names): Change argument to be an
 202         objfile_per_bfd_storage.
 203         * psymtab.c (add_psymbol_to_bcache): Update.
 204         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
 205
 206 2019-01-10  Tom Tromey  <tom@tromey.com>
 207
 208         * symtab.c (create_demangled_names_hash): Change argument to be an
 209         objfile_per_bfd_storage.
 210         (symbol_set_names): Update.
 211
 212 2019-01-10  Tom Tromey  <tom@tromey.com>
 213
 214         * xcoffread.c (xcoff_initial_scan): Unconditionally call
 215         init_psymbol_list.
 216         * psymtab.c (init_psymbol_list): Do nothing if already called.
 217         * psympriv.h (init_psymbol_list): Add comment.
 218         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
 219         init_psymbol_list.
 220         * dbxread.c (dbx_symfile_read): Unconditionally call
 221         init_psymbol_list.
 222
 223 2019-01-10  Tom Tromey  <tom@tromey.com>
 224
 225         * xcoffread.c (scan_xcoff_symtab): Update.
 226         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
 227         "where".
 228         * mdebugread.c (parse_partial_symbols)
 229         (handle_psymbol_enumerators): Update.
 230         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
 231         * dbxread.c (read_dbx_symtab): Update.
 232         * psympriv.h (psymbol_placement): New enum.
 233         (add_psymbol_to_list): Update.
 234
 235 2019-01-10  Tom Tromey  <tom@tromey.com>
 236
 237         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
 238         static_psymbols parameters.
 239         (scan_xcoff_symtab): Update.
 240         * psymtab.c (start_psymtab_common): Remove global_psymbols and
 241         static_psymbols parameters.
 242         * psympriv.h (start_psymtab_common): Update.
 243         * mdebugread.c (parse_partial_symbols): Update.
 244         * dwarf2read.c (create_partial_symtab): Update.
 245         * dbxread.c (read_dbx_symtab): Update.
 246         (start_psymtab): Remove global_psymbols and static_psymbols
 247         parameters.
 248
 249 2019-01-10  Tom Tromey  <tom@tromey.com>
 250
 251         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
 252         * psymtab.c (allocate_psymtab): Add comment.
 253         * psympriv.h (allocate_psymtab): Add comment.
 254         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
 255         initializations.
 256         * dbxread.c (dbx_end_psymtab): Remove some initializations.
 257
 258 2019-01-10  Tom Tromey  <tom@tromey.com>
 259
 260         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 261         Don't declare.
 262         * mipsread.c: Include mdebugread.h.
 263         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 264         Declare.
 265         * elfread.c: Include mdebugread.h.
 266
 267 2019-01-09  Tom Tromey  <tom@tromey.com>
 268
 269         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
 270         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
 271         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
 272         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 273         (psym_lookup_symbol, psym_find_last_source_symtab)
 274         (psym_forget_cached_source_info, psym_print_stats)
 275         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 276         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 277         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 278         (psym_find_compunit_symtab_by_address)
 279         (maintenance_print_psymbols, maintenance_info_psymtabs)
 280         (maintenance_check_psymtabs): Use ranged for.
 281         * psymtab.h (class objfile_psymtabs): New.
 282         (require_partial_symbols): Return objfile_psymtabs.
 283         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
 284
 285 2019-01-09  Tom Tromey  <tom@tromey.com>
 286
 287         * symfile.c (overlay_invalidate_all, find_pc_overlay)
 288         (find_pc_mapped_section, list_overlays_command)
 289         (map_overlay_command, unmap_overlay_command)
 290         (simple_overlay_update): Use all_objfiles.
 291         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
 292         * printcmd.c (info_symbol_command): Use all_objfiles.
 293         * objfiles.h (ALL_OBJSECTIONS): Remove.
 294         * maint.c (maintenance_translate_address): Use all_objfiles.
 295         * gcore.c (gcore_create_callback): Use all_objfiles.
 296         (objfile_find_memory_regions): Likewise.
 297
 298 2019-01-09  Tom Tromey  <tom@tromey.com>
 299
 300         * symtab.c (find_line_symtab, info_sources_command)
 301         (make_source_files_completion_list): Use objfile_compunits.
 302         * source.c (select_source_symtab): Use objfile_compunits.
 303         * objfiles.h (struct objfile): Update comment.
 304         (ALL_OBJFILES): Remove.
 305         (ALL_FILETABS): Remove.
 306         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
 307         objfile_compunits.
 308
 309 2019-01-09  Tom Tromey  <tom@tromey.com>
 310
 311         * symmisc.c (print_objfile_statistics, dump_objfile)
 312         (maintenance_print_symbols): Use compunit_filetabs.
 313         * source.c (forget_cached_source_info_for_objfile): Use
 314         compunit_filetabs.
 315         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
 316         (ALL_FILETABS): Use compunit_filetabs.
 317         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
 318         * coffread.c (coff_symtab_read): Use compunit_filetabs.
 319
 320 2019-01-09  Tom Tromey  <tom@tromey.com>
 321
 322         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
 323         (compunit_filetabs): New.
 324         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
 325         compunit_filetabs.
 326         (info_sources_command, make_source_files_completion_list): Remove
 327         declaration.
 328         * symmisc.c (print_objfile_statistics, dump_objfile)
 329         (maintenance_print_symbols): Remove declaration.
 330         (maintenance_info_symtabs): Use compunit_filetabs.
 331         (maintenance_info_line_tables): Likewise.
 332         * source.c (select_source_symtab): Change local variable name.
 333         (forget_cached_source_info_for_objfile): Remove declaration.
 334         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
 335         * objfiles.c (objfile_relocate1): Remove declaration.
 336         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 337         declaration.
 338         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
 339         * coffread.c (coff_symtab_read): Remove declaration.
 340         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 341         compunit_filetabs.
 342
 343 2019-01-09  Tom Tromey  <tom@tromey.com>
 344
 345         * symtab.c (lookup_objfile_from_block)
 346         (find_pc_sect_compunit_symtab, search_symbols)
 347         (default_collect_symbol_completion_matches_break_on): Use
 348         objfile_compunits.
 349         * objfiles.h (ALL_COMPUNITS): Remove.
 350         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
 351         * cp-support.c (add_symbol_overload_list_qualified): Use
 352         objfile_compunits.
 353         * ada-lang.c (ada_collect_symbol_completion_matches)
 354         (ada_add_global_exceptions): Use objfile_compunits.
 355
 356 2019-01-09  Tom Tromey  <tom@tromey.com>
 357
 358         * source.c (select_source_symtab)
 359         (forget_cached_source_info_for_objfile): Remove declaration.
 360         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 361         declaration.
 362         * maint.c (count_symtabs_and_blocks): Remove declaration.
 363         * cp-support.c (add_symbol_overload_list_qualified): Remove
 364         declaration.
 365         * coffread.c (coff_symtab_read): Remove declaration.
 366         * symtab.c (lookup_symbol_in_objfile_symtabs)
 367         (basic_lookup_transparent_type_1): Use objfile_compunits.
 368         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
 369         (info_sources_command, search_symbols)
 370         (default_collect_symbol_completion_matches_break_on)
 371         (make_source_files_completion_list): Remove declaration.
 372         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
 373         (ada_collect_symbol_completion_matches)
 374         (ada_add_global_exceptions): Remove declaration.
 375         * linespec.c (iterate_over_all_matching_symtabs): Use
 376         objfile_compunits.
 377         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
 378         (class objfile_compunits): New.
 379         (ALL_COMPUNITS): Use objfile_compunits.
 380         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
 381         (maintenance_check_symtabs, maintenance_info_line_tables): Use
 382         objfile_compunits.
 383         * objfiles.c (objfile_relocate1): Use objfile_compunits.
 384
 385 2019-01-09  Tom Tromey  <tom@tromey.com>
 386
 387         * symtab.c (search_symbols)
 388         (default_collect_symbol_completion_matches_break_on): Use
 389         objfile_msymbols.
 390         * ada-lang.c (ada_lookup_simple_minsym)
 391         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
 392         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
 393         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
 394         objfile_msymbols.
 395         * coffread.c (coff_symfile_read): Use objfile_msymbols.
 396         * symmisc.c (dump_msymbols): Use objfile_msymbols.
 397         * objc-lang.c (find_methods): Use objfile_msymbols.
 398         (info_selectors_command, info_classes_command): Likewise.
 399         * stabsread.c (scan_file_globals): Use objfile_msymbols.
 400         * objfiles.h (class objfile_msymbols): New.
 401         (ALL_OBJFILE_MSYMBOLS): Remove.
 402         (ALL_MSYMBOLS): Remove.
 403
 404 2019-01-09  Tom Tromey  <tom@tromey.com>
 405
 406         * common/next-iterator.h (next_adapter): Add Iterator template
 407         parameter.
 408         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
 409         (class all_objfiles_safe): New.
 410         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
 411         * objfiles.c (put_objfile_before): Update comment.
 412         (add_separate_debug_objfile): Likewise.
 413         (free_all_objfiles): Use all_objfiles_safe.
 414         (objfile_purge_solibs): Likewise.
 415
 416 2019-01-09  Tom Tromey  <tom@tromey.com>
 417
 418         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 419         (expand_symtab_containing_pc, lookup_static_symbol)
 420         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
 421         (find_symbol_at_address, find_line_symtab, find_main_name): Use
 422         all_objfiles.
 423         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
 424         * breakpoint.c (create_overlay_event_breakpoint)
 425         (create_longjmp_master_breakpoint)
 426         (create_std_terminate_master_breakpoint)
 427         (create_exception_master_breakpoint): Use all_objfiles.
 428         * linux-thread-db.c (try_thread_db_load_from_pdir)
 429         (has_libpthread): Use all_objfiles.
 430         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
 431         * linespec.c (iterate_over_all_matching_symtabs)
 432         (search_minsyms_for_name): Use all_objfiles.
 433         * maint.c (maintenance_info_sections): Use all_objfiles.
 434         * main.c (captured_main_1): Use all_objfiles.
 435         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
 436         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
 437         * guile/scm-pretty-print.c
 438         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
 439         * solib-spu.c (append_ocl_sos): Use all_objfiles.
 440         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
 441         (maintenance_print_msymbols): Use all_objfiles.
 442         * source.c (select_source_symtab): Use all_objfiles.
 443         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
 444         * symfile.c (remove_symbol_file_command)
 445         (expand_symtabs_matching, map_symbol_filenames): Use
 446         all_objfiles.
 447         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
 448         all_objfiles.
 449         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
 450         * objc-lang.c (find_methods): Use all_objfiles.
 451         * objfiles.c (have_partial_symbols, have_full_symbols)
 452         (have_minimal_symbols, qsort_cmp)
 453         (default_iterate_over_objfiles_in_search_order): Use
 454         all_objfiles.
 455         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
 456         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
 457         (maintenance_check_psymtabs): Use all_objfiles.
 458         (ALL_PSYMTABS): Remove.
 459         * compile/compile-object-run.c (do_module_cleanup): Use
 460         all_objfiles.
 461         * blockframe.c (find_pc_partial_function): Use all_objfiles.
 462         * cp-support.c (add_symbol_overload_list_qualified): Use
 463         all_objfiles.
 464         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 465         Use all_objfiles.
 466         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
 467         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
 468         all_objfiles.
 469         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 470         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
 471         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 472         Uses all_objfiles.
 473         * solib.c (solib_read_symbols): Use all_objfiles
 474
 475 2019-01-09  Tom Tromey  <tom@tromey.com>
 476
 477         * probe.c (parse_probes_in_pspace): Use all_objfiles.
 478         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
 479         all_objfiles.
 480         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
 481         * symmisc.c (print_symbol_bcache_statistics)
 482         (print_objfile_statistics, maintenance_print_objfiles)
 483         (maintenance_info_symtabs, maintenance_check_symtabs)
 484         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
 485         all_objfiles.
 486         * source.c (forget_cached_source_info): Use all_objfiles.
 487         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
 488         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 489         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
 490         * objfiles.c (update_section_map): Use all_objfiles.
 491         (shared_objfile_contains_address_p): Likewise.
 492         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
 493         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
 494
 495 2019-01-09  Tom Tromey  <tom@tromey.com>
 496
 497         * common/next-iterator.h: New file.
 498         * objfiles.h (class all_objfiles): New.
 499         (struct objfile_iterator): New.
 500
 501 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 502
 503         * NEWS: Move the description of the changed "frame", "select-frame",
 504          and "info frame" commands to the Changed commands section.
 505
 506 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
 507
 508         * gdbtypes.c (check_stub_method_group): Remove handling of old
 509         mangling schemes.
 510         * linespec.c (find_methods): Likewise.
 511         * stabsread.c (read_member_functions): Likewise.
 512         * valops.c (search_struct_method): Likewise.
 513         (value_struct_elt_for_reference): Likewise.
 514         * NEWS: Mention this change.
 515
 516 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 517
 518         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
 519         print_source_lines.
 520         * source.c (print_source_lines_base): Update line number check.
 521         (print_source_lines): New function.
 522         (source_lines_range::source_lines_range): New function.
 523         * source.h (class source_lines_range): New class.
 524         (print_source_lines): New declaration.
 525
 526 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 527
 528         * linespec.c (linespec_state_destructor): Free self->canonical_names.
 529
 530 2019-01-08  Tom Tromey  <tom@tromey.com>
 531             Simon Marchi  <simon.marchi@ericsson.com>
 532
 533         PR gdb/24060
 534         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
 535         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
 536         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 537         * f-exp.y (DOLLAR_VARIABLE): Likewise.
 538         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
 539         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 540
 541 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 542
 543         * source.c (select_source_symtab): Move header comment to
 544         declaration in source.h.
 545         (forget_cached_source_info_for_objfile): Likewise.
 546         (forget_cached_source_info): Likewise.
 547         (identify_source_line): Likewise.
 548         * source.h (identify_source_line): Move declaration from symtab.h
 549         and add comment from source.c
 550         (print_source_lines): Likewise.
 551         (forget_cached_source_info_for_objfile): Likewise.
 552         (forget_cached_source_info): Likewise.
 553         (select_source_symtab): Likewise.
 554         (enum print_source_lines_flag): Move definition from symtab.h.
 555         * symtab.h (identify_source_line): Move declaration to source.h.
 556         (print_source_lines): Likewise.
 557         (forget_cached_source_info_for_objfile): Likewise.
 558         (forget_cached_source_info): Likewise.
 559         (select_source_symtab): Likewise.
 560         (enum print_source_lines_flag): Move definition to source.h.
 561         * tui/tui-hooks.c: Add 'source.h' include.
 562
 563 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 564
 565         * source.c (print_source_lines_base): Handle requests to print
 566         reverse line number sequences, and guard against empty lines
 567         string.
 568
 569 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 570
 571         * source.c (print_source_lines_base): Fix skip of '\r' if next
 572         character is '\n'.
 573
 574 2019-01-06  Tom Tromey  <tom@tromey.com>
 575
 576         * c-exp.y (struct c_parse_state) <macro_original_text,
 577         expansion_obstack>: New member.
 578         (macro_original_text, expansion_obstack): Remove globals.
 579         (scan_macro_expansion, scanning_macro_expansion)
 580         (finished_macro_expansion): Update.
 581         (scan_macro_cleanup): Remove.
 582         (yylex, c_parse): Update.
 583
 584 2019-01-06  Tom Tromey  <tom@tromey.com>
 585
 586         * c-exp.y (struct c_parse_state) <strings>: New member.
 587         (operator_stoken): Update.
 588
 589 2019-01-06  Tom Tromey  <tom@tromey.com>
 590
 591         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
 592         (union type_stack_elt) <typelist_val>: Now a pointer to
 593         std::vector.
 594         (type_stack_cleanup): Don't declare.
 595         (push_typelist): Update.
 596         * parse.c (pop_typelist): Return a std::vector.
 597         (push_typelist): Take a std::vector.
 598         (follow_types): Update.  Do not free args.
 599         (type_stack_cleanup): Remove.
 600         * c-exp.y (struct c_parse_state): New.
 601         (cpstate): New global.
 602         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
 603         (nonempty_typelist): Update.
 604         (func_mod): Create a new vector.
 605         (c_parse): Create a c_parse_state.
 606         (check_parameter_typelist): Do not delete params.
 607         (function_method): Update.  Do not delete type_list.
 608
 609 2019-01-06  Tom Tromey  <tom@tromey.com>
 610
 611         PR gdb/28155:
 612         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
 613         check_typedef.
 614         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
 615         (print_return_value): Likewise.
 616
 617 2019-01-05  Tom Tromey  <tom@tromey.com>
 618
 619         * contrib/cleanup_check.py: Remove.
 620         * contrib/gcc-with-excheck: Remove.
 621         * contrib/exsummary.py: Remove.
 622         * contrib/excheck.py: Remove.
 623
 624 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
 625
 626         * thread.c (delete_thread_1): Add gdb_assert that THR is not
 627         NULL. Initialize tpprev to NULL instead of assigning it
 628         to NULL on the next statement.
 629         * windows-nat.c (windows_delete_thread): Remove check for
 630         main_thread_id before printing thread exit notifications.
 631         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
 632         Remove thread ID check against main_thread_id.
 633         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
 634         windows_delete_thread.
 635         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
 636
 637 2019-01-04  Tom Tromey  <tom@tromey.com>
 638
 639         * compile/compile.c (_initialize_compile): Use upper case for
 640         metasyntactic variables.
 641         * symmisc.c (_initialize_symmisc): Use upper case for
 642         metasyntactic variables.
 643         * psymtab.c (_initialize_psymtab): Use upper case for
 644         metasyntactic variables.
 645         * demangle.c (demangle_command): Use upper case for metasyntactic
 646         variables.
 647         (_initialize_demangler): Likewise.
 648         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
 649         variables.
 650
 651 2019-01-03  Tom Tromey  <tom@tromey.com>
 652
 653         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
 654
 655 2019-01-03  Tom Tromey  <tom@tromey.com>
 656
 657         * python/py-symtab.c (salpy_str): Update.
 658         (struct salpy_sal_object) <symtab>: Now a PyObject.
 659         (salpy_dealloc): Update.
 660         (del_objfile_sal): Use gdbpy_ref.
 661
 662 2019-01-03  Tom Tromey  <tom@tromey.com>
 663
 664         * python/py-type.c (convert_field): Use new_reference.  Return
 665         gdbpy_ref.
 666         (make_fielditem): Return gdbpy_ref.
 667         (typy_fields): Update.
 668         (typy_getitem): Update.
 669         (field_name): Return gdbpy_ref.  Use new_reference.
 670         (typy_iterator_iternext): Update.
 671
 672 2019-01-03  Tom Tromey  <tom@tromey.com>
 673
 674         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
 675
 676 2019-01-03  Tom Tromey  <tom@tromey.com>
 677
 678         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
 679         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
 680         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
 681         (pspy_set_frame_filters, pspy_set_frame_unwinders)
 682         (pspy_set_type_printers): Likewise.
 683         * python/py-function.c (fnpy_init): Use gdbpy_ref.
 684         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
 685         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
 686         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
 687         (objfpy_set_type_printers): Likewise.
 688
 689 2019-01-03  Tom Tromey  <tom@tromey.com>
 690
 691         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
 692         (gdbpy_print_stack): Use gdbpy_err_fetch.
 693         * python/python-internal.h (class gdbpy_err_fetch): New class.
 694         (class gdbpy_enter) <m_error_type, m_error_value,
 695         m_error_traceback>: Remove.
 696         <m_error>: New member.
 697         (gdbpy_exception_to_string): Don't declare.
 698         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
 699         * python/py-value.c (convert_value_from_python): Use
 700         gdbpy_err_fetch.
 701         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
 702         gdbpy_exception_to_string.
 703         (gdbpy_handle_exception): Use gdbpy_err_fetch.
 704         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 705         gdbpy_err_fetch.
 706
 707 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 708
 709         * linux-nat.c (delete_lwp_cleanup): Delete.
 710         (struct lwp_deleter): New struct.
 711         (lwp_info_up): New typedef.
 712         (linux_nat_target::follow_fork): Delete cleanup, and make use of
 713         lwp_info_up.
 714
 715 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 716
 717         * linux-fork.c (class scoped_switch_fork_info): New class.
 718         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
 719
 720 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 721
 722         * valops.c (find_overload_match): Remove use of null_cleanup, and
 723         calls to do_cleanups.
 724
 725 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 726
 727         * compile/compile-cplus-types.c
 728         (compile_cplus_instance::decl_name): Handle changes to
 729         cp_func_name.
 730         * cp-support.c (cp_func_name): Update header comment, update
 731         return type.
 732         * cp-support.h (cp_func_name): Update return type in declaration.
 733         * valops.c (find_overload_match): Move temp_func local to top
 734         level of function and change its type.  Use temp_func to hold and
 735         delete temporary string obtained from cp_func_name.
 736
 737 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 738
 739         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
 740         gdb::char_vector, remove cleanup, and update uses of `msg`.
 741
 742 2019-01-03  Jim Wilson  <jimw@sifive.com>
 743
 744         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
 745
 746 2019-01-02  Tom Tromey  <tom@tromey.com>
 747
 748         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
 749         (tdesc_parse_xml): Remove cleanups.
 750         * target-descriptions.h (make_cleanup_free_target_description):
 751         Don't declare.
 752         (target_desc_deleter): New struct.
 753         (target_desc_up): New typedef.
 754         * target-descriptions.c (target_desc_deleter::operator()): Rename
 755         from free_target_description.
 756         (make_cleanup_free_target_description): Remove.
 757
 758 2019-01-02  Tom Tromey  <tom@tromey.com>
 759
 760         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
 761         constructor, destructor.
 762         (linespec_parser): Remove typedef.
 763         (~linespec_parser): Rename from linespec_parser_delete.
 764         (linespec_lex_to_end, linespec_complete_label)
 765         (linespec_complete): Update.
 766         (decode_line_full): Remove cleanups.
 767         (decode_line_1): Update.
 768
 769 2019-01-02  Tom Tromey  <tom@tromey.com>
 770
 771         * python/python-internal.h (inferior_to_inferior_object): Change
 772         return type.
 773         * python/py-exitedevent.c (create_exited_event_object): Update.
 774         * python/py-inferior.c (inferior_to_inferior_object): Return
 775         gdbpy_ref.
 776         (python_new_inferior, python_inferior_deleted)
 777         (thread_to_thread_object, delete_thread_object)
 778         (build_inferior_list, gdbpy_selected_inferior): Update.
 779         * python/py-infthread.c (create_thread_object): Update.  Also fail
 780         if inferior_to_inferior_object fails.
 781
 782 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
 783
 784         * inferior.h (class inferior) <displaced_step_state>: New field.
 785         * infrun.h (struct displaced_step_state): Move here from
 786         infrun.c.  Initialize fields, add constructor.
 787         <inf>: Remove field.
 788         <reset>: New method.
 789         * infrun.c (struct displaced_step_inferior_state): Move to
 790         infrun.h.
 791         (displaced_step_inferior_states): Remove.
 792         (get_displaced_stepping_state): Adust.
 793         (displaced_step_in_progress_any_inferior): Adjust.
 794         (displaced_step_in_progress_thread): Adjust.
 795         (displaced_step_in_progress): Adjust.
 796         (add_displaced_stepping_state): Remove.
 797         (get_displaced_step_closure_by_addr): Adjust.
 798         (remove_displaced_stepping_state): Remove.
 799         (infrun_inferior_exit): Call displaced_step_state.reset.
 800         (use_displaced_stepping): Don't check for NULL.
 801         (displaced_step_prepare_throw): Call
 802         get_displaced_stepping_state.
 803         (displaced_step_fixup): Don't check for NULL.
 804         (prepare_for_detach): Don't check for NULL.
 805
 806 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 807
 808         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
 809          in case of call that did not complete.
 810
 811 2019-01-02  Andrey Utkin  <autkin@undo.io>
 812
 813         * symfile.c (find_separate_debug_file): Fix search of debug files for
 814         remote debuggee.
 815
 816 2019-01-02  Tom Tromey  <tom@tromey.com>
 817
 818         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
 819         indentation.
 820         * python/py-frame.c (frapy_older): Remove cast.
 821         (frapy_newer): Likewise.
 822         * python/py-breakpoint.c (local_setattro): Remove cast.
 823         * python/py-arch.c (archpy_name): Remove local variable.
 824         * python/py-type.c (gdbpy_lookup_type): Remove cast.
 825
 826 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
 827
 828         * unittests/basic_string_view/element_access/char/empty.cc:
 829         Fix year range in copyright header.
 830
 831 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 832
 833         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
 834         Delete.
 835         <operator==>: Update with for removed field.
 836         <hash>: Likewise.
 837         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
 838         <isa_features>: ...this.
 839         <abi_features>: New field.
 840         (riscv_isa_flen): Update comment.
 841         (riscv_abi_xlen): New declaration.
 842         (riscv_abi_flen): New declaration.
 843         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
 844         isa_features.
 845         (riscv_abi_xlen): New function.
 846         (riscv_isa_flen): Update to get answer from isa_features.
 847         (riscv_abi_flen): New function.
 848         (riscv_has_fp_abi): Update to get answer from abi_features.
 849         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
 850         xlen and flen.
 851         (riscv_call_info) <xlen, flen>: Update comment.
 852         (riscv_call_arg_struct): Remove invalid assertions
 853         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
 854         is removed.
 855         (riscv_gdbarch_init): Gather isa features and abi features
 856         separately, ensure both match on the gdbarch when reusing an old
 857         gdbarch.  Relax an error check to allow 32-bit abi float to run on
 858         a target with 64-bit float hardware.
 859
 860 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 861
 862         * source.c (search_command_helper): Stop reverse search
 863         when line 1 has been searched.
 864
 865 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 866
 867         * record-full.c (record_full_base_target::close): Rewrite
 868         record_full_core_buf_list free logic.
 869
 870 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 871
 872         * break-catch-syscall.c (print_one_catch_syscall): xfree
 873         the last text.
 874
 875 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
 876
 877         * top.c (print_gdb_version): Update Copyright year in version
 878         message.
 879
 880 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
 881
 882         Update copyright year range in all GDB files.
 883
 884 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
 885
 886         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
 887
 888 For older changes see ChangeLog-2018.
 889 \f
 890 Local Variables:
 891 mode: change-log
 892 left-margin: 8
 893 fill-column: 74
 894 version-control: never
 895 coding: utf-8
 896 End:
 897