Revert "Use wclrtoeol in tui_show_source_line"
[external/binutils.git] / gdb / ChangeLog
1 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2
3         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4         wclrtoeol in tui_show_source_line".  This reverts changes made in
5         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6
7 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8
9         * NEWS: Combine separate "New targets" sections for 8.3.
10
11 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
12
13         The MS-Windows port of ncurses fails to switch to a color pair if
14         one or both of the colors are the implicit default colors.  This
15         change records the default colors when TUI is initialized, and
16         then specifies them explicitly when a color pair uses the default
17         colors.  This allows color styling in TUI mode on MS-Windows.
18
19         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
20         ncurses_norm_attr.
21         (tui_initialize_io) [__MINGW32__]: Record the default terminal
22         colors in ncurses_norm_attr.
23         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
24         "none", replace it with the default color recorded in
25         ncurses_norm_attr.
26
27 2019-03-14  Tom Tromey  <tromey@adacore.com>
28
29         * source-cache.h (class source_cache) <get_source_lines>: Return
30         std::string.
31         * source-cache.c (source_cache::extract_lines): Handle case where
32         first_pos==npos.  Return std::string.
33         (source_cache::get_source_lines): Update.
34
35 2019-03-14  Tom Tromey  <tromey@adacore.com>
36
37         * NEWS: Add item for "style sources" commands.
38         * source-cache.c (source_cache::get_source_lines): Check
39         source_styling.
40         * cli/cli-style.c (source_styling): New global.
41         (_initialize_cli_style): Add "style sources" commands.
42         (show_style_sources): New function.
43         * cli/cli-style.h (source_styling): Declare.
44
45 2019-03-14  Pedro Alves  <palves@redhat.com>
46             Tom Tromey  <tromey@adacore.com>
47
48         * tui/tui-winsource.h (tui_refill_source_window): Declare.
49         * tui/tui-winsource.c (tui_refill_source_window): New function,
50         from...
51         (tui_horizontal_source_scroll): ... here.  Move some logic.
52         * cli/cli-style.c (set_style_enabled): Notify new observable.
53         * tui/tui-hooks.c (tui_redisplay_source): New function.
54         (tui_attach_detach_observers): Attach or detach
55         tui_redisplay_source.
56         * observable.h (source_styling_changed): New observable.
57         * observable.c: Define source_styling_changed observable.
58
59 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
60
61         PR/24325
62         * source-cache.c: #undef open and close, to avoid unresolved
63         externals during linking.
64
65 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
66
67         Support styling on native MS-Windows console
68
69         PR/24315
70         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
71         on MS-Windows if $TERM is not defined.
72
73         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
74
75         * posix-hdep.c (gdb_console_fputs):
76         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
77         functions.
78         * ui-file.h (gdb_console_fputs): Add prototype.
79
80         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
81         back to fputs only if the former returns zero.
82
83 2019-03-07  Brian Vandenberg  <phantall@gmail.com>
84             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
85
86         PR gdb/8527
87         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
88         set_sigint_trap, clear_sigint_trap.
89
90 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
91
92         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
93         for-loop range, to avoid compiler warnings.
94
95         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
96         avoid compiler warnings about unused variables.
97
98 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
99
100         * NEWS: Mention end of support for native debugging on MS-Windows
101         before XP.
102
103 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
104
105         PR gdb/24292
106         * common/netstuff.c:
107         * gdbserver/gdbreplay.c
108         * gdbserver/remote-utils.c:
109         * ser-tcp.c:
110         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
111         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
112         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
113         'getaddrinfo' and 'freeaddrinfo' were not available before
114         Windows XP, and mingw.org's MinGW headers by default define
115         _WIN32_WINNT to 0x500.
116
117 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
118     
119         * NEWS: Note minimum Python version.
120
121 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
122
123         * version.in: Set GDB version number to 8.2.90.DATE-git.
124
125 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
126
127         GDB 8.2.90 released.
128
129 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
130
131         * version.in: Set GDB version number to 8.2.90.
132
133 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
134
135         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
136
137 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
138
139         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
140         * version.in: Bump version to 8.2.90.DATE-git.
141
142 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
143
144         * aix-thread.c (ptid_cmp): Remove unused variable.
145         (get_signaled_thread): Likewise.
146         (store_regs_user_thread): Likewise.
147         (store_regs_kernel_thread): Likewise.
148         (fetch_regs_kernel_thread): Remove shadowed variable.
149
150 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
151
152         * features/riscv/32bit-cpu.xml: Add register numbers.
153         * features/riscv/32bit-fpu.c: Regenerate.
154         * features/riscv/32bit-fpu.xml: Add register numbers.
155         * features/riscv/64bit-cpu.xml: Add register numbers.
156         * features/riscv/64bit-fpu.c: Regenerate.
157         * features/riscv/64bit-fpu.xml: Add register numbers.
158
159 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
160
161         * NEWS: Mention two argument form of gdb.Value constructor.
162         * python/py-value.c (convert_buffer_and_type_to_value): New
163         function.
164         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
165         Add support for handling an optional second argument.  Call
166         convert_buffer_and_type_to_value as appropriate.
167         * python/python-internal.h (Py_buffer_deleter): New struct.
168         (Py_buffer_up): New typedef.
169
170 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
171
172         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
173         instead of releasing ownership.
174
175 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
176
177         * dwarf2read.c (open_and_init_dwp_file): Call
178         elf_numsections instead of bfd_count_sections to initialize
179         dwp_file->num_sections.
180
181 2019-02-25  Tom Tromey  <tromey@adacore.com>
182
183         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
184
185 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
186
187         * gcore.in: Add '--readnever' option when invoking GDB.
188
189 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
190
191         * MAINTAINERS: Update my email address.
192
193 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
194
195         * build-id.c (build_id_to_debug_bfd_1): New function.
196         (build_id_to_debug_bfd): Look for separate debug file in
197         sysroot.
198
199 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
200
201         * gdbarch.sh: Update the copyright year range that is placed into
202         generated files.
203
204 2019-02-22  Keith Seitz  <keiths@redhat.com>
205
206         PR symtab/23853
207         * linespec.c (create_sals_line_offset): Search for the default
208         symtab's filename instead of its fullname.
209
210 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
211
212         * NEWS: Update style defaults.
213
214 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
215
216         * main.c (captured_main_1): Disable styling in batch mode.
217
218 2019-02-20  Tom Tromey  <tom@tromey.com>
219
220         * symtab.c (symtab_symbol_info): Fix typos.
221
222 2019-02-20  Tom Tromey  <tromey@adacore.com>
223
224         * findcmd.c (_initialize_mem_search): Use upper case for
225         metasyntactic variables.
226
227 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
228
229         * aarch64-tdep.c (aarch64_add_reggroups): New function.
230         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
231
232 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
233
234         * top.h (source_file_name): Change to std::string.
235         * top.c (source_file_name): Likewise.
236         (command_line_input): Adjust.
237         * cli/cli-script.c (script_from_file): Adjust.
238
239 2019-02-19  Tom Tromey  <tromey@adacore.com>
240
241         * ravenscar-thread.c
242         (ravenscar_thread_target::update_thread_list): Don't call
243         ada_build_task_list.
244         * ada-lang.h (ada_build_task_list): Don't declare.
245         * ada-tasks.c (struct ada_tasks_inferior_data)
246         <task_list_valid_p>: Now bool.
247         (read_known_tasks, ada_task_list_changed)
248         (ada_tasks_invalidate_inferior_data): Update.
249         (read_known_tasks_array): Return bool.
250         (read_known_tasks_list): Likewise.
251         (read_known_tasks): Return void.
252         (ada_build_task_list): Now static.
253
254 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
255
256         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
257         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
258
259 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
260
261         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
262         variant for ada_tasks_pspace_data_handle and
263         ada_tasks_inferior_data_handle.
264         (ada_tasks_pspace_data_cleanup): New function.
265         (ada_tasks_inferior_data_cleanup): New function.
266
267 2019-02-17  Tom Tromey  <tom@tromey.com>
268
269         * macrotab.h (macro_source_fullname): Return a std::string.
270         * macrotab.c (macro_include, check_for_redefinition)
271         (macro_undef, macro_lookup_definition, foreach_macro)
272         (foreach_macro_in_scope): Update.
273         (macro_source_fullname): Return a std::string.
274         * macrocmd.c (show_pp_source_pos): Update.
275
276 2019-02-17  Tom Tromey  <tom@tromey.com>
277
278         * macrocmd.c (show_pp_source_pos): Style the file names.
279
280 2019-02-17  Tom Tromey  <tom@tromey.com>
281
282         PR tui/24197:
283         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
284
285 2019-02-17  Tom Tromey  <tom@tromey.com>
286
287         * ada-lang.c (user_select_syms): Use filtered printing.
288         * utils.c (wrap_style): New global.
289         (desired_style): Remove.
290         (emit_style_escape): Add stream parameter.
291         (set_output_style, reset_terminal_style, prompt_for_continue):
292         Update.
293         (flush_wrap_buffer): Only flush gdb_stdout.
294         (wrap_here): Set wrap_style.
295         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
296         treat escape sequences as a character.  Change when wrap buffer is
297         flushed.
298         (fputs_styled): Do not set the output style when the default is
299         requested.
300         * ui-style.h (struct ui_file_style) <is_default>: New method.
301         * source.c (print_source_lines_base): Emit escape sequences in one
302         piece.
303
304 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
305
306         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
307         integers and enumeration types.
308
309 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
310
311         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
312         instead of lookup_symbol_in_language
313         (do_exact_match): New function.
314         (ada_get_symbol_name_matcher): Return do_exact_match when
315         doing a verbatim match.
316
317 2019-02-15  Tom Tromey  <tromey@adacore.com>
318
319         * ravenscar-thread.c (ravenscar_thread_target::resume)
320         (ravenscar_thread_target::wait): Special case wildcard requests.
321
322 2019-02-15  Tom Tromey  <tromey@adacore.com>
323
324         * ravenscar-thread.c (base_ptid): Remove.
325         (struct ravenscar_thread_target) <close>: New method.
326         <m_base_ptid>: New member.
327         <update_inferior_ptid, active_task, task_is_currently_active,
328         runtime_initialized>: Declare methods.
329         <ravenscar_thread_target>: Add constructor.
330         (ravenscar_thread_target::task_is_currently_active)
331         (ravenscar_thread_target::update_inferior_ptid)
332         (ravenscar_runtime_initialized): Rename.  Now methods.
333         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
334         (ravenscar_thread_target::update_thread_list): Update.
335         (ravenscar_thread_target::active_task): Now method.
336         (ravenscar_thread_target::store_registers)
337         (ravenscar_thread_target::prepare_to_store)
338         (ravenscar_thread_target::prepare_to_store)
339         (ravenscar_thread_target::mourn_inferior): Update.
340         (ravenscar_inferior_created): Use "new" to create target.
341         (ravenscar_thread_target::get_ada_task_ptid): Update.
342         (_initialize_ravenscar): Don't initialize base_ptid.
343         (ravenscar_ops): Remove global.
344
345 2019-02-15  Tom Tromey  <tromey@adacore.com>
346
347         * target.h (push_target): Declare new overload.
348         * target.c (push_target): New overload, taking an rvalue reference.
349         * remote.c (remote_target::open_1): Use push_target overload.
350         * corelow.c (core_target_open): Use push_target overload.
351
352 2019-02-15  Tom Tromey  <tromey@adacore.com>
353
354         * ravenscar-thread.c (is_ravenscar_task)
355         (ravenscar_task_is_currently_active): Return bool.
356         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
357         (_initialize_ravenscar): Remove "(void)".
358         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
359         Return bool.
360
361 2019-02-15  Tom Tromey  <tromey@adacore.com>
362
363         * ravenscar-thread.c (ravenscar_runtime_initializer)
364         (has_ravenscar_runtime, get_running_thread_id)
365         (ravenscar_thread_target::resume): Fix indentation.
366
367 2019-02-15  Tom Tromey  <tromey@adacore.com>
368
369         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
370         from ravenscar_arch_ops.
371         (sparc_ravenscar_ops::fetch_registers)
372         (sparc_ravenscar_ops::store_registers): Now methods.
373         (sparc_ravenscar_prepare_to_store): Remove.
374         (sparc_ravenscar_ops): Redefine.
375         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
376         methods and destructor.  Remove members.
377         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
378         (ravenscar_thread_target::store_registers)
379         (ravenscar_thread_target::prepare_to_store): Update.
380         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
381         Remove.
382         (struct ppc_ravenscar_powerpc_ops): Derive from
383         ravenscar_arch_ops.
384         (ppc_ravenscar_powerpc_ops::fetch_registers)
385         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
386         (ppc_ravenscar_powerpc_ops): Redefine.
387         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
388         (ppc_ravenscar_e500_ops::fetch_registers)
389         (ppc_ravenscar_e500_ops::store_registers): Now methods.
390         (ppc_ravenscar_e500_ops): Redefine.
391         * aarch64-ravenscar-thread.c
392         (aarch64_ravenscar_generic_prepare_to_store): Remove.
393         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
394         (aarch64_ravenscar_fetch_registers)
395         (aarch64_ravenscar_store_registers): Now methods.
396         (aarch64_ravenscar_ops): Redefine.
397
398 2019-02-15  Tom Tromey  <tromey@adacore.com>
399
400         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
401         (ravenscar_thread_target::stopped_by_hw_breakpoint)
402         (ravenscar_thread_target::stopped_by_watchpoint)
403         (ravenscar_thread_target::stopped_data_address)
404         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
405
406 2019-02-15  Tom Tromey  <tromey@adacore.com>
407
408         * ravenscar-thread.c: Fix some typos.
409
410 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
411             Tom Tromey  <tromey@adacore.com>
412
413         * ada-lang.c (ada_exception_sal): Change addr_string to a
414         std::string.
415         (create_ada_exception_catchpoint): Update.
416
417 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
418             Tom Tromey  <tromey@adacore.com>
419
420         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
421         (bp_location_ops): Remove.
422         (base_breakpoint_allocate_location): Update.
423         (free_bp_location): Update.
424         * ada-lang.c (class ada_catchpoint_location)
425         <ada_catchpoint_location>: Remove ops parameter.
426         (ada_catchpoint_location_dtor): Remove.
427         (ada_catchpoint_location_ops): Remove.
428         (allocate_location_exception): Update.
429         * breakpoint.h (struct bp_location_ops): Remove.
430         (class bp_location) <bp_location>: Remove bp_location_ops
431         parameter.
432         <~bp_location>: Add destructor.
433         <ops>: Remove.
434
435 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
436             Pedro Alves  <palves@redhat.com>
437
438         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
439         'PATH_MAX'.
440
441 2019-02-14  David Michael  <fedora.dm0@gmail.com>
442             Samuel Thibault  <samuel.thibault@gnu.org>
443             Thomas Schwinge  <thomas@codesourcery.com>
444
445         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
446         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
447
448 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
449
450         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
451         (check_empty): Use "const char *".
452
453         * gnu-nat.c (gnu_nat_target::detach): Instead of
454         'detach_inferior (pid)' call
455         'detach_inferior (find_inferior_pid (pid))'.
456
457         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
458         'nat/fork-inferior.o'.
459         * gnu-nat.c: #include "nat/fork-inferior.h".
460
461         * gnu-nat.c (gnu_nat_target::detach): Instead of
462         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
463         * gnu-nat.h: #include "inf-child.h".
464         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
465         'i386_gnu_nat_target::fetch_registers'.
466         (gnu_store_registers): Rename/move to
467         'i386_gnu_nat_target::store_registers'.
468
469         * config/i386/nm-i386gnu.h: Don't "#include" any files.
470         * gnu-nat.h (mach_thread_info): New function.
471         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
472
473         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
474
475 2019-02-14  Frederic Konrad  <konrad@adacore.com>
476
477         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
478
479 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
480
481         * windows-nat.c (windows_add_thread): Add new parameter
482         "main_thread_p" with default value set to false.  Update
483         function documentation as well as all callers.
484         (windows_delete_thread): Likewise.
485         (fake_create_process): Update call to windows_add_thread.
486         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
487         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
488         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
489         call to windows_delete_thread.
490
491 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
492
493         * MAINTAINERS: Add Andrew Burgess as global maintainer.
494
495 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
496
497         * symfile.c (find_separate_debug_file): Use canonical path of
498         sysroot with child_path instead of gdb_sysroot if it is valid.
499
500 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
501
502         * symfile.c (find_separate_debug_file): Use child_path to
503         determine if an object file is under a sysroot.
504
505 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
506
507         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
508         unittests/child-path-selftests.c.
509         * common/pathstuff.c (child_path): New function.
510         * common/pathstuff.h (child_path): New prototype.
511         * unittests/child-path-selftests.c: New file.
512
513 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
514
515         * symfile.c (find_separate_debug_file): Look for separate debug
516         files in debug directories under the sysroot.
517
518 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
519
520         * symtab.h (struct minimal_symbol data_p): New const method.
521         (struct minimal_symbol text_p): Likewise.
522         * symtab.c (output_source_filename): Use file name style
523         to print file name.
524         (print_symbol_info): Likewise.
525         (print_msymbol_info): Use address style to print addresses.
526         Use function name style to print executable text symbols.
527         (expand_symtab_containing_pc): Use data_p.
528         (find_pc_sect_compunit_symtab): Likewise.
529
530 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
531
532         * breakpoint.c (describe_other_breakpoints): Use address style
533         to print addresses.
534         (say_where): Likewise.
535
536 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
537
538         * ada-typeprint.c (print_func_type): Print function name
539         style to print function name.
540         * c-typeprint.c (c_print_type_1): Likewise.
541
542 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
543
544         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
545         for execve.
546
547 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
548
549         * c-exp.y (direct_abs_decl): Use emplace_back to record the
550         type_stack.
551
552 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
553
554         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
555         TYPE_CODE_REF types.
556
557 2019-02-08  Jim Wilson  <jimw@sifive.com>
558
559         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
560         (riscv_linux_fregset): New.
561         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
562
563 2019-02-07  Tom Tromey  <tom@tromey.com>
564
565         * thread.c (thread_cancel_execution_command): Update.
566         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
567         methods.
568         (struct thread_fsm_ops): Remove.
569         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
570         (thread_fsm_should_stop, thread_fsm_return_value)
571         (thread_fsm_set_finished, thread_fsm_finished_p)
572         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
573         Don't declare.
574         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
575         * infrun.c (clear_proceed_status_thread)
576         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
577         (print_stop_event): Update.
578         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
579         Add constructor.
580         (step_command_fsm_ops): Remove.
581         (new_step_command_fsm): Remove.
582         (step_1): Update.
583         (step_command_fsm::should_stop): Rename from
584         step_command_fsm_should_stop.
585         (step_command_fsm::clean_up): Rename from
586         step_command_fsm_clean_up.
587         (step_command_fsm::do_async_reply_reason): Rename from
588         step_command_fsm_async_reply_reason.
589         (struct until_next_fsm): Inherit from thread_fsm.  Add
590         constructor.
591         (until_next_fsm_ops): Remove.
592         (new_until_next_fsm): Remove.
593         (until_next_fsm::should_stop): Rename from
594         until_next_fsm_should_stop.
595         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
596         (until_next_fsm::do_async_reply_reason): Rename from
597         until_next_fsm_async_reply_reason.
598         (struct finish_command_fsm): Inherit from thread_fsm.  Add
599         constructor.  Change type of breakpoint.
600         (finish_command_fsm_ops): Remove.
601         (new_finish_command_fsm): Remove.
602         (finish_command_fsm::should_stop): Rename from
603         finish_command_fsm_should_stop.
604         (finish_command_fsm::clean_up): Rename from
605         finish_command_fsm_clean_up.
606         (finish_command_fsm::return_value): Rename from
607         finish_command_fsm_return_value.
608         (finish_command_fsm::do_async_reply_reason): Rename from
609         finish_command_fsm_async_reply_reason.
610         (finish_command): Update.
611         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
612         Add constructor.
613         (call_thread_fsm_ops): Remove.
614         (call_thread_fsm::call_thread_fsm): Rename from
615         new_call_thread_fsm.
616         (call_thread_fsm::should_stop): Rename from
617         call_thread_fsm_should_stop.
618         (call_thread_fsm::should_notify_stop): Rename from
619         call_thread_fsm_should_notify_stop.
620         (run_inferior_call, call_function_by_hand_dummy): Update.
621         * cli/cli-interp.c (should_print_stop_to_console): Update.
622         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
623         Add constructor.  Change type of location_breakpoint,
624         caller_breakpoint.
625         (until_break_fsm_ops): Remove.
626         (new_until_break_fsm): Remove.
627         (until_break_fsm::should_stop): Rename from
628         until_break_fsm_should_stop.
629         (until_break_fsm::clean_up): Rename from
630         until_break_fsm_clean_up.
631         (until_break_fsm::do_async_reply_reason): Rename from
632         until_break_fsm_async_reply_reason.
633         (until_break_command): Update.
634         * thread-fsm.c: Remove.
635         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
636
637 2019-02-07  Tom Tromey  <tom@tromey.com>
638
639         * yy-remap.h: Add include guard.
640         * xtensa-tdep.h: Add include guard.
641         * xcoffread.h: Rename include guard.
642         * varobj-iter.h: Add include guard.
643         * tui/tui.h: Rename include guard.
644         * tui/tui-winsource.h: Rename include guard.
645         * tui/tui-wingeneral.h: Rename include guard.
646         * tui/tui-windata.h: Rename include guard.
647         * tui/tui-win.h: Rename include guard.
648         * tui/tui-stack.h: Rename include guard.
649         * tui/tui-source.h: Rename include guard.
650         * tui/tui-regs.h: Rename include guard.
651         * tui/tui-out.h: Rename include guard.
652         * tui/tui-layout.h: Rename include guard.
653         * tui/tui-io.h: Rename include guard.
654         * tui/tui-hooks.h: Rename include guard.
655         * tui/tui-file.h: Rename include guard.
656         * tui/tui-disasm.h: Rename include guard.
657         * tui/tui-data.h: Rename include guard.
658         * tui/tui-command.h: Rename include guard.
659         * tic6x-tdep.h: Add include guard.
660         * target/waitstatus.h: Rename include guard.
661         * target/wait.h: Rename include guard.
662         * target/target.h: Rename include guard.
663         * target/resume.h: Rename include guard.
664         * target-float.h: Rename include guard.
665         * stabsread.h: Add include guard.
666         * rs6000-tdep.h: Add include guard.
667         * riscv-fbsd-tdep.h: Add include guard.
668         * regformats/regdef.h: Rename include guard.
669         * record.h: Rename include guard.
670         * python/python.h: Rename include guard.
671         * python/python-internal.h: Rename include guard.
672         * python/py-stopevent.h: Rename include guard.
673         * python/py-ref.h: Rename include guard.
674         * python/py-record.h: Rename include guard.
675         * python/py-record-full.h: Rename include guard.
676         * python/py-record-btrace.h: Rename include guard.
677         * python/py-instruction.h: Rename include guard.
678         * python/py-events.h: Rename include guard.
679         * python/py-event.h: Rename include guard.
680         * procfs.h: Add include guard.
681         * proc-utils.h: Add include guard.
682         * p-lang.h: Add include guard.
683         * or1k-tdep.h: Rename include guard.
684         * observable.h: Rename include guard.
685         * nto-tdep.h: Rename include guard.
686         * nat/x86-linux.h: Rename include guard.
687         * nat/x86-linux-dregs.h: Rename include guard.
688         * nat/x86-gcc-cpuid.h: Add include guard.
689         * nat/x86-dregs.h: Rename include guard.
690         * nat/x86-cpuid.h: Rename include guard.
691         * nat/ppc-linux.h: Rename include guard.
692         * nat/mips-linux-watch.h: Rename include guard.
693         * nat/linux-waitpid.h: Rename include guard.
694         * nat/linux-ptrace.h: Rename include guard.
695         * nat/linux-procfs.h: Rename include guard.
696         * nat/linux-osdata.h: Rename include guard.
697         * nat/linux-nat.h: Rename include guard.
698         * nat/linux-namespaces.h: Rename include guard.
699         * nat/linux-btrace.h: Rename include guard.
700         * nat/glibc_thread_db.h: Rename include guard.
701         * nat/gdb_thread_db.h: Rename include guard.
702         * nat/gdb_ptrace.h: Rename include guard.
703         * nat/fork-inferior.h: Rename include guard.
704         * nat/amd64-linux-siginfo.h: Rename include guard.
705         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
706         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
707         * nat/aarch64-linux.h: Rename include guard.
708         * nat/aarch64-linux-hw-point.h: Rename include guard.
709         * mn10300-tdep.h: Add include guard.
710         * mips-linux-tdep.h: Add include guard.
711         * mi/mi-parse.h: Rename include guard.
712         * mi/mi-out.h: Rename include guard.
713         * mi/mi-main.h: Rename include guard.
714         * mi/mi-interp.h: Rename include guard.
715         * mi/mi-getopt.h: Rename include guard.
716         * mi/mi-console.h: Rename include guard.
717         * mi/mi-common.h: Rename include guard.
718         * mi/mi-cmds.h: Rename include guard.
719         * mi/mi-cmd-break.h: Rename include guard.
720         * m2-lang.h: Add include guard.
721         * location.h: Rename include guard.
722         * linux-record.h: Rename include guard.
723         * linux-nat.h: Add include guard.
724         * linux-fork.h: Add include guard.
725         * i386-darwin-tdep.h: Rename include guard.
726         * hppa-linux-offsets.h: Add include guard.
727         * guile/guile.h: Rename include guard.
728         * guile/guile-internal.h: Rename include guard.
729         * gnu-nat.h: Rename include guard.
730         * gdb-stabs.h: Rename include guard.
731         * frv-tdep.h: Add include guard.
732         * f-lang.h: Add include guard.
733         * event-loop.h: Add include guard.
734         * darwin-nat.h: Rename include guard.
735         * cp-abi.h: Rename include guard.
736         * config/sparc/nm-sol2.h: Rename include guard.
737         * config/nm-nto.h: Rename include guard.
738         * config/nm-linux.h: Add include guard.
739         * config/i386/nm-i386gnu.h: Rename include guard.
740         * config/djgpp/nl_types.h: Rename include guard.
741         * config/djgpp/langinfo.h: Rename include guard.
742         * compile/gcc-cp-plugin.h: Add include guard.
743         * compile/gcc-c-plugin.h: Add include guard.
744         * compile/compile.h: Rename include guard.
745         * compile/compile-object-run.h: Rename include guard.
746         * compile/compile-object-load.h: Rename include guard.
747         * compile/compile-internal.h: Rename include guard.
748         * compile/compile-cplus.h: Rename include guard.
749         * compile/compile-c.h: Rename include guard.
750         * common/xml-utils.h: Rename include guard.
751         * common/x86-xstate.h: Rename include guard.
752         * common/version.h: Rename include guard.
753         * common/vec.h: Rename include guard.
754         * common/tdesc.h: Rename include guard.
755         * common/selftest.h: Rename include guard.
756         * common/scoped_restore.h: Rename include guard.
757         * common/scoped_mmap.h: Rename include guard.
758         * common/scoped_fd.h: Rename include guard.
759         * common/safe-iterator.h: Rename include guard.
760         * common/run-time-clock.h: Rename include guard.
761         * common/refcounted-object.h: Rename include guard.
762         * common/queue.h: Rename include guard.
763         * common/ptid.h: Rename include guard.
764         * common/print-utils.h: Rename include guard.
765         * common/preprocessor.h: Rename include guard.
766         * common/pathstuff.h: Rename include guard.
767         * common/observable.h: Rename include guard.
768         * common/netstuff.h: Rename include guard.
769         * common/job-control.h: Rename include guard.
770         * common/host-defs.h: Rename include guard.
771         * common/gdb_wait.h: Rename include guard.
772         * common/gdb_vecs.h: Rename include guard.
773         * common/gdb_unlinker.h: Rename include guard.
774         * common/gdb_unique_ptr.h: Rename include guard.
775         * common/gdb_tilde_expand.h: Rename include guard.
776         * common/gdb_sys_time.h: Rename include guard.
777         * common/gdb_string_view.h: Rename include guard.
778         * common/gdb_splay_tree.h: Rename include guard.
779         * common/gdb_setjmp.h: Rename include guard.
780         * common/gdb_ref_ptr.h: Rename include guard.
781         * common/gdb_optional.h: Rename include guard.
782         * common/gdb_locale.h: Rename include guard.
783         * common/gdb_assert.h: Rename include guard.
784         * common/filtered-iterator.h: Rename include guard.
785         * common/filestuff.h: Rename include guard.
786         * common/fileio.h: Rename include guard.
787         * common/environ.h: Rename include guard.
788         * common/common-utils.h: Rename include guard.
789         * common/common-types.h: Rename include guard.
790         * common/common-regcache.h: Rename include guard.
791         * common/common-inferior.h: Rename include guard.
792         * common/common-gdbthread.h: Rename include guard.
793         * common/common-exceptions.h: Rename include guard.
794         * common/common-defs.h: Rename include guard.
795         * common/common-debug.h: Rename include guard.
796         * common/cleanups.h: Rename include guard.
797         * common/buffer.h: Rename include guard.
798         * common/btrace-common.h: Rename include guard.
799         * common/break-common.h: Rename include guard.
800         * cli/cli-utils.h: Rename include guard.
801         * cli/cli-style.h: Rename include guard.
802         * cli/cli-setshow.h: Rename include guard.
803         * cli/cli-script.h: Rename include guard.
804         * cli/cli-interp.h: Rename include guard.
805         * cli/cli-decode.h: Rename include guard.
806         * cli/cli-cmds.h: Rename include guard.
807         * charset-list.h: Add include guard.
808         * buildsym-legacy.h: Rename include guard.
809         * bfin-tdep.h: Add include guard.
810         * ax.h: Rename include guard.
811         * arm-linux-tdep.h: Add include guard.
812         * arm-fbsd-tdep.h: Add include guard.
813         * arch/xtensa.h: Rename include guard.
814         * arch/tic6x.h: Add include guard.
815         * arch/i386.h: Add include guard.
816         * arch/arm.h: Rename include guard.
817         * arch/arm-linux.h: Rename include guard.
818         * arch/arm-get-next-pcs.h: Rename include guard.
819         * arch/amd64.h: Add include guard.
820         * arch/aarch64-insn.h: Rename include guard.
821         * arch-utils.h: Rename include guard.
822         * annotate.h: Add include guard.
823         * amd64-darwin-tdep.h: Rename include guard.
824         * aarch64-linux-tdep.h: Add include guard.
825         * aarch64-fbsd-tdep.h: Add include guard.
826         * aarch32-linux-nat.h: Add include guard.
827
828 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
829
830         * macrotab.c (macro_define_internal): New function that
831         factorizes macro_define_object_internal and macro_define_function
832         code.
833         (macro_define_object_internal): Use macro_define_internal.
834         (macro_define_function): Likewise.
835
836 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
837
838         * macrocmd.c (extract_identifier): Return
839         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
840         callers.
841
842 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
843
844         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
845
846 2019-02-05  Tom Tromey  <tom@tromey.com>
847
848         * target.c (target_stack::unpush): Move assertion earlier.
849
850 2019-01-30  Tom Tromey  <tom@tromey.com>
851
852         PR python/23615:
853         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
854         (gdbpy_parse_and_eval): Likewise.
855         * python/python-internal.h (gdbpy_allow_threads): New class.
856
857 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
858
859         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
860         (aarch64_fbsd_fpregmap): Move earlier.
861         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
862         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
863         instead of individual calls to trad_frame_set_reg_addr.
864         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
865         earlier.
866         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
867         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
868         instead of individual calls to trad_frame_set_reg_addr.
869
870 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
871
872         * CONTRIBUTE: Replace contribution list with wiki link.
873
874 2019-01-25  Tom Tromey  <tom@tromey.com>
875
876         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
877
878 2019-01-25  Tom Tromey  <tom@tromey.com>
879
880         * xtensa-linux-nat.c: Fix common/ includes.
881         * xml-support.h: Fix common/ includes.
882         * xml-support.c: Fix common/ includes.
883         * x86-linux-nat.c: Fix common/ includes.
884         * windows-nat.c: Fix common/ includes.
885         * varobj.h: Fix common/ includes.
886         * varobj.c: Fix common/ includes.
887         * value.c: Fix common/ includes.
888         * valops.c: Fix common/ includes.
889         * utils.c: Fix common/ includes.
890         * unittests/xml-utils-selftests.c: Fix common/ includes.
891         * unittests/utils-selftests.c: Fix common/ includes.
892         * unittests/unpack-selftests.c: Fix common/ includes.
893         * unittests/tracepoint-selftests.c: Fix common/ includes.
894         * unittests/style-selftests.c: Fix common/ includes.
895         * unittests/string_view-selftests.c: Fix common/ includes.
896         * unittests/scoped_restore-selftests.c: Fix common/ includes.
897         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
898         * unittests/scoped_fd-selftests.c: Fix common/ includes.
899         * unittests/rsp-low-selftests.c: Fix common/ includes.
900         * unittests/parse-connection-spec-selftests.c: Fix common/
901         includes.
902         * unittests/optional-selftests.c: Fix common/ includes.
903         * unittests/offset-type-selftests.c: Fix common/ includes.
904         * unittests/observable-selftests.c: Fix common/ includes.
905         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
906         * unittests/memrange-selftests.c: Fix common/ includes.
907         * unittests/memory-map-selftests.c: Fix common/ includes.
908         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
909         * unittests/function-view-selftests.c: Fix common/ includes.
910         * unittests/environ-selftests.c: Fix common/ includes.
911         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
912         * unittests/common-utils-selftests.c: Fix common/ includes.
913         * unittests/cli-utils-selftests.c: Fix common/ includes.
914         * unittests/array-view-selftests.c: Fix common/ includes.
915         * ui-file.c: Fix common/ includes.
916         * tui/tui-io.c: Fix common/ includes.
917         * tracepoint.h: Fix common/ includes.
918         * tracepoint.c: Fix common/ includes.
919         * tracefile-tfile.c: Fix common/ includes.
920         * top.h: Fix common/ includes.
921         * top.c: Fix common/ includes.
922         * thread.c: Fix common/ includes.
923         * target/waitstatus.h: Fix common/ includes.
924         * target/waitstatus.c: Fix common/ includes.
925         * target.h: Fix common/ includes.
926         * target.c: Fix common/ includes.
927         * target-memory.c: Fix common/ includes.
928         * target-descriptions.c: Fix common/ includes.
929         * symtab.h: Fix common/ includes.
930         * symfile.c: Fix common/ includes.
931         * stap-probe.c: Fix common/ includes.
932         * spu-linux-nat.c: Fix common/ includes.
933         * sparc-nat.c: Fix common/ includes.
934         * source.c: Fix common/ includes.
935         * solib.c: Fix common/ includes.
936         * solib-target.c: Fix common/ includes.
937         * ser-unix.c: Fix common/ includes.
938         * ser-tcp.c: Fix common/ includes.
939         * ser-pipe.c: Fix common/ includes.
940         * ser-base.c: Fix common/ includes.
941         * selftest-arch.c: Fix common/ includes.
942         * s12z-tdep.c: Fix common/ includes.
943         * rust-exp.y: Fix common/ includes.
944         * rs6000-aix-tdep.c: Fix common/ includes.
945         * riscv-tdep.c: Fix common/ includes.
946         * remote.c: Fix common/ includes.
947         * remote-notif.h: Fix common/ includes.
948         * remote-fileio.h: Fix common/ includes.
949         * remote-fileio.c: Fix common/ includes.
950         * regcache.h: Fix common/ includes.
951         * regcache.c: Fix common/ includes.
952         * record-btrace.c: Fix common/ includes.
953         * python/python.c: Fix common/ includes.
954         * python/py-type.c: Fix common/ includes.
955         * python/py-inferior.c: Fix common/ includes.
956         * progspace.h: Fix common/ includes.
957         * producer.c: Fix common/ includes.
958         * procfs.c: Fix common/ includes.
959         * proc-api.c: Fix common/ includes.
960         * printcmd.c: Fix common/ includes.
961         * ppc-linux-nat.c: Fix common/ includes.
962         * parser-defs.h: Fix common/ includes.
963         * osdata.c: Fix common/ includes.
964         * obsd-nat.c: Fix common/ includes.
965         * nat/x86-linux.c: Fix common/ includes.
966         * nat/x86-linux-dregs.c: Fix common/ includes.
967         * nat/x86-dregs.h: Fix common/ includes.
968         * nat/x86-dregs.c: Fix common/ includes.
969         * nat/ppc-linux.c: Fix common/ includes.
970         * nat/mips-linux-watch.h: Fix common/ includes.
971         * nat/mips-linux-watch.c: Fix common/ includes.
972         * nat/linux-waitpid.c: Fix common/ includes.
973         * nat/linux-ptrace.h: Fix common/ includes.
974         * nat/linux-ptrace.c: Fix common/ includes.
975         * nat/linux-procfs.c: Fix common/ includes.
976         * nat/linux-personality.c: Fix common/ includes.
977         * nat/linux-osdata.c: Fix common/ includes.
978         * nat/linux-namespaces.c: Fix common/ includes.
979         * nat/linux-btrace.h: Fix common/ includes.
980         * nat/linux-btrace.c: Fix common/ includes.
981         * nat/fork-inferior.c: Fix common/ includes.
982         * nat/amd64-linux-siginfo.c: Fix common/ includes.
983         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
984         * nat/aarch64-linux.c: Fix common/ includes.
985         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
986         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
987         * namespace.h: Fix common/ includes.
988         * mips-linux-tdep.c: Fix common/ includes.
989         * minsyms.c: Fix common/ includes.
990         * mi/mi-parse.h: Fix common/ includes.
991         * mi/mi-main.c: Fix common/ includes.
992         * mi/mi-cmd-env.c: Fix common/ includes.
993         * memrange.h: Fix common/ includes.
994         * memattr.c: Fix common/ includes.
995         * maint.h: Fix common/ includes.
996         * maint.c: Fix common/ includes.
997         * main.c: Fix common/ includes.
998         * machoread.c: Fix common/ includes.
999         * location.c: Fix common/ includes.
1000         * linux-thread-db.c: Fix common/ includes.
1001         * linux-nat.c: Fix common/ includes.
1002         * linux-fork.c: Fix common/ includes.
1003         * inline-frame.c: Fix common/ includes.
1004         * infrun.c: Fix common/ includes.
1005         * inflow.c: Fix common/ includes.
1006         * inferior.h: Fix common/ includes.
1007         * inferior.c: Fix common/ includes.
1008         * infcmd.c: Fix common/ includes.
1009         * inf-ptrace.c: Fix common/ includes.
1010         * inf-child.c: Fix common/ includes.
1011         * ia64-linux-nat.c: Fix common/ includes.
1012         * i387-tdep.c: Fix common/ includes.
1013         * i386-tdep.c: Fix common/ includes.
1014         * i386-linux-tdep.c: Fix common/ includes.
1015         * i386-linux-nat.c: Fix common/ includes.
1016         * i386-go32-tdep.c: Fix common/ includes.
1017         * i386-fbsd-tdep.c: Fix common/ includes.
1018         * i386-fbsd-nat.c: Fix common/ includes.
1019         * guile/scm-type.c: Fix common/ includes.
1020         * guile/guile.c: Fix common/ includes.
1021         * go32-nat.c: Fix common/ includes.
1022         * gnu-nat.c: Fix common/ includes.
1023         * gdbthread.h: Fix common/ includes.
1024         * gdbarch-selftests.c: Fix common/ includes.
1025         * gdb_usleep.c: Fix common/ includes.
1026         * gdb_select.h: Fix common/ includes.
1027         * gdb_bfd.c: Fix common/ includes.
1028         * gcore.c: Fix common/ includes.
1029         * fork-child.c: Fix common/ includes.
1030         * findvar.c: Fix common/ includes.
1031         * fbsd-nat.c: Fix common/ includes.
1032         * event-top.c: Fix common/ includes.
1033         * event-loop.c: Fix common/ includes.
1034         * dwarf2read.c: Fix common/ includes.
1035         * dwarf2loc.c: Fix common/ includes.
1036         * dwarf2-frame.c: Fix common/ includes.
1037         * dwarf-index-cache.c: Fix common/ includes.
1038         * dtrace-probe.c: Fix common/ includes.
1039         * disasm-selftests.c: Fix common/ includes.
1040         * defs.h: Fix common/ includes.
1041         * csky-tdep.c: Fix common/ includes.
1042         * cp-valprint.c: Fix common/ includes.
1043         * cp-support.h: Fix common/ includes.
1044         * cp-support.c: Fix common/ includes.
1045         * corelow.c: Fix common/ includes.
1046         * completer.h: Fix common/ includes.
1047         * completer.c: Fix common/ includes.
1048         * compile/compile.c: Fix common/ includes.
1049         * compile/compile-loc2c.c: Fix common/ includes.
1050         * compile/compile-cplus-types.c: Fix common/ includes.
1051         * compile/compile-cplus-symbols.c: Fix common/ includes.
1052         * command.h: Fix common/ includes.
1053         * cli/cli-dump.c: Fix common/ includes.
1054         * cli/cli-cmds.c: Fix common/ includes.
1055         * charset.c: Fix common/ includes.
1056         * build-id.c: Fix common/ includes.
1057         * btrace.h: Fix common/ includes.
1058         * btrace.c: Fix common/ includes.
1059         * breakpoint.h: Fix common/ includes.
1060         * breakpoint.c: Fix common/ includes.
1061         * ax.h: 
1062         (enum agent_op): Fix common/ includes.
1063         * ax-general.c (struct aop_map): Fix common/ includes.
1064         * ax-gdb.c: Fix common/ includes.
1065         * auxv.c: Fix common/ includes.
1066         * auto-load.c: Fix common/ includes.
1067         * arm-tdep.c: Fix common/ includes.
1068         * arch/riscv.c: Fix common/ includes.
1069         * arch/ppc-linux-common.c: Fix common/ includes.
1070         * arch/i386.c: Fix common/ includes.
1071         * arch/arm.c: Fix common/ includes.
1072         * arch/arm-linux.c: Fix common/ includes.
1073         * arch/arm-get-next-pcs.c: Fix common/ includes.
1074         * arch/amd64.c: Fix common/ includes.
1075         * arch/aarch64.c: Fix common/ includes.
1076         * arch/aarch64-insn.c: Fix common/ includes.
1077         * arch-utils.c: Fix common/ includes.
1078         * amd64-windows-tdep.c: Fix common/ includes.
1079         * amd64-tdep.c: Fix common/ includes.
1080         * amd64-sol2-tdep.c: Fix common/ includes.
1081         * amd64-obsd-tdep.c: Fix common/ includes.
1082         * amd64-nbsd-tdep.c: Fix common/ includes.
1083         * amd64-linux-tdep.c: Fix common/ includes.
1084         * amd64-linux-nat.c: Fix common/ includes.
1085         * amd64-fbsd-tdep.c: Fix common/ includes.
1086         * amd64-fbsd-nat.c: Fix common/ includes.
1087         * amd64-dicos-tdep.c: Fix common/ includes.
1088         * amd64-darwin-tdep.c: Fix common/ includes.
1089         * agent.c: Fix common/ includes.
1090         * ada-lang.h: Fix common/ includes.
1091         * ada-lang.c: Fix common/ includes.
1092         * aarch64-tdep.c: Fix common/ includes.
1093
1094 2019-01-25  Tom Tromey  <tom@tromey.com>
1095
1096         * common/create-version.sh: Use common/version.h.
1097
1098 2019-01-24  Pedro Alves  <palves@redhat.com>
1099
1100         * infrun.c (signal_stop, signal_print, signal_program)
1101         (signal_catch, signal_pass): Now arrays instead of pointers.
1102         (update_signals_program_target, do_target_resume)
1103         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1104         * linux-nat.c (linux_nat_target::pass_signals)
1105         (linux_nat_target::create_inferior, linux_nat_target::attach):
1106         Adjust.
1107         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1108         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1109         * procfs.c (procfs_target::pass_signals): Adjust.
1110         * record-full.c (record_full_target::resume): Adjust.
1111         * remote.c (remote_target::pass_signals)
1112         (remote_target::program_signals): Adjust.
1113         * target-debug.h (target_debug_print_signals): Now takes a
1114         gdb::array_view as parameter.  Adjust.
1115         * target.h (target_ops) <pass_signals, program_signals>: Replace
1116         pointer and length parameters with gdb::array_view.
1117         (target_pass_signals, target_program_signals): Likewise.
1118         * target-delegates.c: Regenerate.
1119
1120 2019-01-24  Pedro Alves  <palves@redhat.com>
1121
1122         * common/forward-scope-exit.h
1123         (forward_scope_exit::forward_scope_exit): Pass arguments to
1124         m_bind_function directly, instead of creating a std::bind and
1125         copying that.
1126
1127 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1128
1129         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1130         for static members.
1131         (pass_in_v_vfp_candidate): Likewise.
1132
1133 2019-01-23  Tom Tromey  <tom@tromey.com>
1134             Pedro Alves  <palves@redhat.com>
1135
1136         * regcache.c (class regcache_invalidator): Remove.
1137         (regcache::raw_write): Use make_scope_exit.
1138
1139 2019-01-23  Tom Tromey  <tom@tromey.com>
1140
1141         * ui-out.h (class ui_out_emit_type): Update comment.
1142
1143 2019-01-23  Tom Tromey  <tom@tromey.com>
1144
1145         * infrun.c (fetch_inferior_event): Update comment.
1146
1147 2019-01-23  Tom Tromey  <tom@tromey.com>
1148             Pedro Alves  <palves@redhat.com>
1149
1150         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1151         parameter.
1152         (fetch_inferior_event): Use SCOPE_EXIT.
1153
1154
1155 2019-01-23  Tom Tromey  <tom@tromey.com>
1156             Pedro Alves  <palves@redhat.com>
1157
1158         * infrun.c (disable_thread_events): Delete.
1159         (stop_all_threads): Use SCOPE_EXIT.
1160
1161 2019-01-23  Tom Tromey  <tom@tromey.com>
1162             Pedro Alves  <palves@redhat.com>
1163
1164         * symfile.c: Include forward-scope-exit.h.
1165         (clear_symtab_users_cleanup): Replace forward declaration with
1166         a FORWARD_SCOPE_EXIT.
1167         (syms_from_objfile_1): Use the forward_scope_exit and
1168         gdb::optional instead of cleanup_function.
1169         (reread_symbols): Use the forward_scope_exit instead of
1170         cleanup_function.
1171         (clear_symtab_users_cleanup): Remove function.
1172
1173 2019-01-23  Tom Tromey  <tom@tromey.com>
1174             Pedro Alves  <palves@redhat.com>
1175
1176         * linux-nat.c: Include scope-exit.h.
1177         (cleanup_target_stop): Remove.
1178         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1179         SCOPE_EXIT.
1180
1181 2019-01-23  Tom Tromey  <tom@tromey.com>
1182             Pedro Alves  <palves@redhat.com>
1183
1184         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1185         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1186
1187 2019-01-23  Tom Tromey  <tom@tromey.com>
1188             Andrew Burgess  <andrew.burgess@embecosm.com>
1189             Pedro Alves  <palves@redhat.com>
1190
1191         * infrun.c (fetch_inferior_event): Use scope_exit.
1192         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1193         * top.c (execute_command): Use scope_exit.
1194         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1195         * utils.c (do_bpstat_clear_actions_cleanup)
1196         (make_bpstat_clear_actions_cleanup): Remove.
1197
1198 2019-01-23  Tom Tromey  <tom@tromey.com>
1199             Pedro Alves  <palves@redhat.com>
1200
1201         * infrun.c: Include "common/scope-exit.h"
1202         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1203         (wait_for_inferior): Use SCOPE_EXIT.
1204         (fetch_inferior_event): Use scope_exit.
1205
1206 2019-01-23  Tom Tromey  <tom@tromey.com>
1207             Pedro Alves  <palves@redhat.com>
1208
1209         * breakpoint.c (create_breakpoint): Remove cleanup.
1210
1211 2019-01-23  Tom Tromey  <tom@tromey.com>
1212             Andrew Burgess  <andrew.burgess@embecosm.com>
1213             Pedro Alves  <palves@redhat.com>
1214
1215 2019-01-23  Pedro Alves  <palves@redhat.com>
1216
1217         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1218
1219 2019-01-23  Pedro Alves  <palves@redhat.com>
1220             Andrew Burgess  <andrew.burgess@embecosm.com>
1221
1222         * gdbthread.h: Include "common/forward-scope-exit.h".
1223         (scoped_finish_thread_state): Redefine custom class in terms of
1224         forward_scope_exit.
1225
1226 2019-01-23  Pedro Alves  <palves@redhat.com>
1227             Andrew Burgess  <andrew.burgess@embecosm.com>
1228
1229         * common/forward-scope-exit.h: New file.
1230
1231 2019-01-23  Pedro Alves  <palves@redhat.com>
1232             Andrew Burgess  <andrew.burgess@embecosm.com>
1233             Tom Tromey  <tom@tromey.com>
1234
1235         * common/scope-exit.h: New file.
1236
1237 2019-01-23  Pedro Alves  <palves@redhat.com>
1238
1239         * common/preprocessor.h (ESC): Rename to ...
1240         (ESC_PARENS): ... this.
1241         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1242         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1243
1244 2019-01-23  Tom Tromey  <tom@tromey.com>
1245
1246         * language.h (class scoped_switch_to_sym_language_if_auto):
1247         Initialize m_lang in both cases.
1248
1249 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1250
1251         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1252         with XCNEW.
1253
1254 2019-01-22  Tom Tromey  <tom@tromey.com>
1255
1256         * corelow.c: Do not include sys/file.h.
1257
1258 2019-01-22  Tom Tromey  <tom@tromey.com>
1259
1260         * tui/tui-wingeneral.h: Include gdb_curses.h.
1261
1262 2019-01-22  Tom Tromey  <tom@tromey.com>
1263
1264         * source-cache.h (class source_cache) <get_source_lines,
1265         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1266
1267 2019-01-22  Tom Tromey  <tom@tromey.com>
1268
1269         * remote-fileio.h (struct remote_target): Declare.
1270
1271 2019-01-22  Tom Tromey  <tom@tromey.com>
1272
1273         * python/py-arch.c: Do not include py-ref.h.
1274         * python/py-bpevent.c: Do not include py-ref.h.
1275         * python/py-cmd.c: Do not include py-ref.h.
1276         * python/py-continueevent.c: Do not include py-ref.h.
1277         * python/py-event.h: Do not include py-ref.h.
1278         * python/py-evtregistry.c: Do not include py-ref.h.
1279         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1280         * python/py-frame.c: Do not include py-ref.h.
1281         * python/py-framefilter.c: Do not include py-ref.h.
1282         * python/py-function.c: Do not include py-ref.h.
1283         * python/py-infevents.c: Do not include py-ref.h.
1284         * python/py-linetable.c: Do not include py-ref.h.
1285         * python/py-objfile.c: Do not include py-ref.h.
1286         * python/py-param.c: Do not include py-ref.h.
1287         * python/py-prettyprint.c: Do not include py-ref.h.
1288         * python/py-progspace.c: Do not include py-ref.h.
1289         * python/py-symbol.c: Do not include py-ref.h.
1290         * python/py-symtab.c: Do not include py-ref.h.
1291         * python/py-type.c: Do not include py-ref.h.
1292         * python/py-unwind.c: Do not include py-ref.h.
1293         * python/py-utils.c: Do not include py-ref.h.
1294         * python/py-value.c: Do not include py-ref.h.
1295         * python/py-varobj.c: Do not include py-ref.h.
1296         * python/py-xmethods.c: Do not include py-ref.h.
1297         * python/python.c: Do not include py-ref.h.
1298         * varobj.c: Do not include py-ref.h.
1299
1300 2019-01-22  Tom Tromey  <tom@tromey.com>
1301
1302         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1303         keyword for bcache.
1304
1305 2019-01-22  Tom Tromey  <tom@tromey.com>
1306
1307         * compile/compile-cplus-types.c: Remove a comment by #include.
1308
1309 2019-01-22  Tom Tromey  <tom@tromey.com>
1310
1311         * compile/gcc-c-plugin.h: Include compile-internal.h.
1312
1313 2019-01-22  Tom Tromey  <tom@tromey.com>
1314
1315         * stabsread.c (EXTERN): Do not define.
1316         (symnum, next_symbol_text_func, processing_gcc_compilation)
1317         (within_function, global_sym_chain, global_stabs)
1318         (previous_stab_code, this_object_header_files)
1319         (n_this_object_header_files)
1320         (n_allocated_this_object_header_files): Define.
1321         * stabsread.h (EXTERN): Never define.  Use "extern".
1322
1323 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1324
1325         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1326         history_value.
1327
1328 2019-01-21  Tom Tromey  <tom@tromey.com>
1329
1330         * ui-out.c: Fix includes.
1331         * tui/tui-source.c: Fix includes.
1332         * target.c: Fix includes.
1333         * remote.c: Fix includes.
1334         * regcache.c: Fix includes.
1335         * python/py-block.c: Fix includes.
1336         * printcmd.c: Fix includes.
1337         * or1k-tdep.c: Fix includes.
1338         * mi/mi-main.c: Fix includes.
1339         * m32r-tdep.c: Fix includes.
1340         * csky-tdep.c: Fix includes.
1341         * compile/compile-cplus-types.c: Fix includes.
1342         * cli/cli-interp.c: Fix includes.
1343
1344 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1345
1346         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1347         for padding.
1348
1349 2019-01-16  Tom Tromey  <tom@tromey.com>
1350
1351         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1352         earlier.
1353         (struct objfile) <msymbols_range>: Move from top level.
1354         <msymbols>: New method.
1355         (class objfile_msymbols): Remove.
1356         * symtab.c (default_collect_symbol_completion_matches_break_on):
1357         Update.
1358         * symmisc.c (dump_msymbols): Update.
1359         * stabsread.c (scan_file_globals): Update.
1360         * objc-lang.c (info_selectors_command, info_classes_command)
1361         (find_methods): Update.
1362         * minsyms.c (find_solib_trampoline_target): Update.
1363         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1364         * coffread.c (coff_symfile_read): Update.
1365         * ada-lang.c (ada_lookup_simple_minsym)
1366         (ada_collect_symbol_completion_matches): Update.
1367
1368 2019-01-16  Tom Tromey  <tom@tromey.com>
1369
1370         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1371         type.  Remove no-argument constructor.
1372         <iterator::operator++>: Simplify.
1373         <begin>: Update.
1374         <end>: Use minimal_symbol_count.
1375
1376 2019-01-16  Tom Tromey  <tom@tromey.com>
1377
1378         * objfiles.h (struct objfile) <psymtabs>: New method.
1379         (class objfile_psymtabs): Remove.
1380         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1381         typedef.
1382         <range>: New method.
1383         (require_partial_symbols): Change return type.
1384         * psymtab.c (require_partial_symbols)
1385         (psym_expand_symtabs_matching): Update.
1386         * mdebugread.c (parse_partial_symbols): Update.
1387         * dbxread.c (dbx_end_psymtab): Update.
1388
1389 2019-01-15  Tom Tromey  <tom@tromey.com>
1390
1391         * symtab.c (lookup_objfile_from_block)
1392         (lookup_symbol_in_objfile_symtabs)
1393         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1394         (find_line_symtab, info_sources_command)
1395         (default_collect_symbol_completion_matches_break_on)
1396         (make_source_files_completion_list): Update.
1397         * symmisc.c (print_objfile_statistics, dump_objfile)
1398         (maintenance_print_symbols, maintenance_info_symtabs)
1399         (maintenance_check_symtabs, maintenance_info_line_tables):
1400         Update.
1401         * source.c (select_source_symtab)
1402         (forget_cached_source_info_for_objfile): Update.
1403         * objfiles.h (class objfile_compunits): Remove.
1404         (struct objfile) <compunits_range>: New typedef.
1405         (compunits): New method.
1406         * objfiles.c (objfile_relocate1): Update.
1407         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1408         * maint.c (count_symtabs_and_blocks): Update.
1409         * linespec.c (iterate_over_all_matching_symtabs): Update.
1410         * cp-support.c (add_symbol_overload_list_qualified): Update.
1411         * coffread.c (coff_symtab_read): Update.
1412         * ada-lang.c (add_nonlocal_symbols)
1413         (ada_collect_symbol_completion_matches)
1414         (ada_add_global_exceptions): Update.
1415
1416 2019-01-15  Tom Tromey  <tom@tromey.com>
1417
1418         * progspace.h (program_space) <objfiles_safe_range>: New
1419         typedef.
1420         <objfiles_safe>: New method.
1421         * objfiles.h (class all_objfiles_safe): Remove.
1422         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1423         * jit.c (jit_inferior_exit_hook): Update.
1424
1425 2019-01-17  Tom Tromey  <tom@tromey.com>
1426
1427         * progspace.h (program_space) <objfiles_range>: New typedef.
1428         <objfiles>: New method.
1429         <objfiles_head>: Rename from objfiles.
1430         (object_files): Update.
1431         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1432         * guile/scm-pretty-print.c
1433         (ppscm_find_pretty_printer_from_objfiles): Update.
1434         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1435         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1436         Update.
1437         * python/py-progspace.c (pspy_get_objfiles): Update.
1438         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1439         Update.
1440         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1441         (objfpy_lookup_objfile_by_build_id): Update.
1442         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1443         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1444         Update.
1445         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1446         (expand_symtab_containing_pc, lookup_objfile_from_block)
1447         (lookup_static_symbol, basic_lookup_transparent_type)
1448         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1449         (find_line_symtab, info_sources_command)
1450         (default_collect_symbol_completion_matches_break_on)
1451         (make_source_files_completion_list, find_main_name): Update.
1452         * symmisc.c (print_symbol_bcache_statistics)
1453         (print_objfile_statistics, maintenance_print_symbols)
1454         (maintenance_print_msymbols, maintenance_print_objfiles)
1455         (maintenance_info_symtabs, maintenance_check_symtabs)
1456         (maintenance_expand_symtabs, maintenance_info_line_tables):
1457         Update.
1458         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1459         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1460         (map_overlay_command, unmap_overlay_command)
1461         (simple_overlay_update, expand_symtabs_matching)
1462         (map_symbol_filenames): Update.
1463         * symfile-debug.c (set_debug_symfile): Update.
1464         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1465         Update.
1466         * source.c (select_source_symtab, forget_cached_source_info):
1467         Update.
1468         * solib.c (solib_read_symbols): Update.
1469         * solib-spu.c (append_ocl_sos): Update.
1470         * psymtab.c (maintenance_print_psymbols)
1471         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1472         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1473         * printcmd.c (info_symbol_command): Update.
1474         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1475         Update.
1476         * objfiles.h (class all_objfiles): Remove.
1477         * objfiles.c (have_partial_symbols, have_full_symbols)
1478         (have_minimal_symbols, qsort_cmp, update_section_map)
1479         (shared_objfile_contains_address_p)
1480         (default_iterate_over_objfiles_in_search_order): Update.
1481         * objc-lang.c (info_selectors_command, info_classes_command)
1482         (find_methods): Update.
1483         * minsyms.c (find_solib_trampoline_target): Update.
1484         * maint.c (maintenance_info_sections)
1485         (maintenance_translate_address, count_symtabs_and_blocks):
1486         Update.
1487         * main.c (captured_main_1): Update.
1488         * linux-thread-db.c (try_thread_db_load_from_pdir)
1489         (has_libpthread): Update.
1490         * linespec.c (iterate_over_all_matching_symtabs)
1491         (search_minsyms_for_name): Update.
1492         * jit.c (jit_find_objf_with_entry_addr): Update.
1493         * hppa-tdep.c (find_unwind_entry)
1494         (hppa_lookup_stub_minimal_symbol): Update.
1495         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1496         Update.
1497         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1498         (elf_gnu_ifunc_resolve_by_got): Update.
1499         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1500         * dwarf-index-write.c (save_gdb_index_command): Update.
1501         * cp-support.c (add_symbol_overload_list_qualified): Update.
1502         * breakpoint.c (create_overlay_event_breakpoint)
1503         (create_longjmp_master_breakpoint)
1504         (create_std_terminate_master_breakpoint)
1505         (create_exception_master_breakpoint): Update.
1506         * blockframe.c (find_pc_partial_function): Update.
1507         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1508         (ada_collect_symbol_completion_matches)
1509         (ada_add_global_exceptions): Update.
1510
1511 2019-01-17  Tom Tromey  <tom@tromey.com>
1512
1513         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1514         declare VEC.
1515         (solib_target_parse_libraries): Change return type.
1516         (library_list_start_segment, library_list_start_section)
1517         (library_list_end_library, library_list_start_library); Update.
1518         (solib_target_free_library_list): Remove.
1519         (solib_target_parse_libraries): Remove cleanup.  Change return
1520         type.
1521         (solib_target_current_sos): Update.
1522
1523 2019-01-17  Tom Tromey  <tromey@bapiya>
1524
1525         * valprint.c: Replace "the the" with "the".
1526         * symtab.c: Replace "the the" with "the".
1527         * solib.c: Replace "the the" with "the".
1528         * solib-dsbt.c: Replace "the the" with "the".
1529         * linespec.c: Replace "the the" with "the".
1530         * dwarf2loc.h: Replace "the the" with "the".
1531         * amd64-windows-tdep.c: Replace "the the" with "the".
1532         * aarch64-tdep.c: Replace "the the" with "the".
1533
1534 2019-01-16  Keith Seitz  <keiths@redhat.com>
1535
1536         PR gdb/23773
1537         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1538         <builder>: Rename to ..
1539         <m_builder>: ... this and make private.
1540         (dwarf2_cu::get_builder): New method.  Change all users of
1541         `builder' to use this method.
1542         (dwarf2_start_symtab): Move to ...
1543         (dwarf2_cu::start_symtab): ... here.  Update all callers
1544         (setup_type_unit_groups): Move to ...
1545         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1546         callers.
1547         (dwarf2_cu::reset_builder): New method.
1548         (process_full_compunit, process_full_type_unit): Use
1549         dwarf2_cu::reset_builder.
1550         (follow_die_offset): Record the ancestor CU if it is different
1551         from the followed DIE's CU.
1552         (follow_die_sig_1): Likewise.
1553
1554 2019-01-15  Tom Tromey  <tom@tromey.com>
1555
1556         * remote.c (class remote_state) <buf>: Now a char_vector.
1557         <buf_size>: Remove.
1558         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1559         parameter.
1560         (remote_target::getpkt_or_notif_sane_1)
1561         (remote_target::getpkt_sane)
1562         (remote_target::getpkt_or_notif_sane): Likewise.
1563         (class remote_target) <putpkt>: New overload.
1564         (remote_target::read_frame): Change type of "buf_p".  Remove
1565         sizeof_p parameter.
1566         (packet_ok): New overload.
1567         (packet_check_result): New overload.
1568         Update all uses.
1569
1570 2019-01-14  Tom Tromey  <tom@tromey.com>
1571
1572         * remote-notif.c (handle_notification, remote_notif_ack)
1573         (remote_notif_parse): Make "buf" const.
1574         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1575         const.
1576         (remote_notif_parse, remote_notif_ack, handle_notification):
1577         Likewise.
1578         * remote.c (remote_notif_stop_parse): Make "buf" const.
1579         (remote_target::remote_parse_stop_reply): Make "buf" const.
1580         (remote_notif_stop_ack): Make "buf" const.
1581
1582 2019-01-14  Tom Tromey  <tom@tromey.com>
1583
1584         * remote.c (remote_console_output): Make parameter const.
1585
1586 2019-01-14  Tom Tromey  <tom@tromey.com>
1587
1588         * target-debug.h (target_debug_print_signals): Constify.
1589         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1590         * procfs.c (procfs_target::pass_signals): Update.
1591         * linux-nat.c (linux_nat_target::pass_signals): Update.
1592         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1593         * target-delegates.c: Rebuild.
1594         * remote.c (remote_target::program_signals): Update.
1595         (remote_target::pass_signals): Update.
1596         * target.c (target_pass_signals): Constify argument.
1597         (target_program_signals): Likewise.
1598         * target.h (struct target_ops) <pass_signals, program_signals>:
1599         Constify argument.
1600         (target_pass_signals, target_program_signals): Constify argument.
1601
1602 2019-01-14  Tom Tromey  <tom@tromey.com>
1603
1604         PR tui/28819:
1605         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1606
1607 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1608
1609         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1610         field.
1611         * rs6000-tdep.c: Include reggroups.h.
1612         (IS_V_ALIAS_PSEUDOREG): Define.
1613         (rs6000_register_name): Return names for the "vX" aliases.
1614         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1615         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1616         aliases.  Call default_register_reggroup_p for all other
1617         pseudo-registers.
1618         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1619         New functions.
1620         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1621         Handle "vX" aliases.
1622         (v_alias_pseudo_register_collect): New function.
1623         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1624         (rs6000_gdbarch_init): Initialize "vX" aliases as
1625         pseudo-registers.  Restore registration of
1626         rs6000_pseudo_register_reggroup_p with
1627         set_tdesc_pseudo_register_reggroup_p.
1628
1629 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1630
1631         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1632         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1633         set_gdbarch_num_pseudo_regs.
1634
1635 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1636
1637         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1638         Remove arg prefixname, add do_set and do_show.
1639         Add member functions set_list and show_list.
1640         * cli/cli-style.c (class cli_style_option): Update accordingly.
1641         (style_set_list): Move to file scope.
1642         (style_show_list): Likewise.
1643         (set_style): Call help_list.
1644         (show_style): Call cmd_show_list.
1645         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1646         Update to use the new macro.
1647
1648 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1649
1650         * ada-lang.c (_initialize_ada_language): Expand the help text
1651         for the "catch exception" command.
1652
1653 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1654
1655         * symtab.c (matching_obj_sections): Initialize obj,
1656         declare it closer to its usage.
1657
1658 2019-01-10  Tom Tromey  <tom@tromey.com>
1659
1660         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1661         (basic_inf_threads_range): Remove.
1662         (inf_threads_range, inf_non_exited_threads_range)
1663         (safe_inf_threads_range): Use next_adapter.
1664
1665 2019-01-10  Keith Seitz  <keiths@redhat.com>
1666
1667         PR gdb/23712
1668         PR symtab/23010
1669         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1670         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1671
1672 2019-01-10  Keith Seitz  <keiths@redhat.com>
1673
1674         PR gdb/23712
1675         PR symtab/23010
1676         * dictionary.c (pending_to_vector): Remove.
1677         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1678         Remove _1 suffix, replacing functions of the same name.  Update
1679         all callers.
1680         (dict_create_hashed, dict_create_hashed_expandable)
1681         (dict_create_linear, dict_create_linear_expandable, dict_free)
1682         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1683         Make functions static.
1684
1685 2019-01-10  Keith Seitz  <keiths@redhat.com>
1686
1687         PR gdb/23712
1688         PR symtab/23010
1689         * dictionary.h (struct dictionary): Replace declaration with
1690         multidictionary.
1691         (dict_create_hashed, dict_create_hashed_expandable)
1692         (dict_create_linear, dict_create_linear_expandable)
1693         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1694         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1695         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1696         taking multidictionary argument.
1697         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1698         * block.h (struct block) <dict>: Change to multidictionary
1699         and rename `multidict'.
1700         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1701         symmisc.c: Update all dictionary references to multidictionary.
1702
1703 2019-01-10  Keith Seitz  <keiths@redhat.com>
1704
1705         PR gdb/23712
1706         PR symtab/23010
1707         * dictionary.c: Include unordered_map.
1708         (pending_to_vector): New function.
1709         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1710         Rewrite the non-"_1" functions to take vector instead
1711         of linked list.
1712         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1713         "new" _1 versions of the same name.
1714         (multidictionary): Define.
1715         (std::hash<enum language): New definition.
1716         (collate_pending_symbols_by_language, mdict_create_hashed)
1717         (mdict_create_hashed_expandable, mdict_create_linear)
1718         (mdict_create_linear_expandable, mdict_free)
1719         (find_language_dictionary, create_new_language_dictionary)
1720         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1721         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1722         (mdict_size, mdict_empty): New functions.
1723         * dictionary.h (mdict_iterator): Define.
1724
1725 2019-01-10  Pedro Alves  <palves@redhat.com>
1726
1727         * breakpoint.c (read_uploaded_action)
1728         (create_tracepoint_from_upload): Adjust to use
1729         gdb::unique_xmalloc_ptr.
1730         * ctf.c (ctf_write_uploaded_tp):
1731         (SET_ARRAY_FIELD): Use emplace_back.
1732         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1733         * tracefile-tfile.c (tfile_write_uploaded_tp):
1734         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1735         gdb::unique_xmalloc_ptr.
1736         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1737         at_string, cond_string, cmd_strings>: Replace char pointers
1738         with gdb::unique_xmalloc_ptr.
1739
1740 2019-01-10  Pedro Alves  <palves@redhat.com>
1741
1742         * solib-target.c (library_list_start_library): Don't xstrdup name.
1743
1744 2019-01-10  Pedro Alves  <palves@redhat.com>
1745
1746         * mdebugread.c (parse_partial_symbols): Use
1747         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1748
1749 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1750
1751         * linux-fork.c (scoped_switch_fork_info)
1752         <~scoped_switch_fork_info>: Fix incorrect variable name.
1753
1754 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1755
1756         * linux-fork.c (scoped_switch_fork_info)
1757         <scoped_switch_fork_info>: Make explicit.
1758         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1759
1760 2019-01-10  Tom Tromey  <tom@tromey.com>
1761
1762         * objfiles.h (objfile::reset_psymtabs): Update.
1763         * objfiles.c (objfile::objfile): Update.
1764         * psymtab.h (psymtab_storage::obstack): Update.
1765         (psymtab_storage::m_obstack): Use gdb::optional.
1766         (class psymtab_storage): Update comment.  Remove objfile
1767         parameter.
1768         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1769
1770 2019-01-10  Tom Tromey  <tom@tromey.com>
1771
1772         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1773         <free_psymtabs>: Now private.
1774         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1775         (allocate_psymtab): Use new method.
1776
1777 2019-01-10  Tom Tromey  <tom@tromey.com>
1778
1779         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1780         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1781         * mdebugread.c (parse_partial_symbols): Use
1782         allocate_dependencies.
1783         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1784         allocate_dependencies.
1785         (process_psymtab_comp_unit_reader)
1786         (build_type_psymtab_dependencies): Likewise.
1787         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1788
1789 2019-01-10  Tom Tromey  <tom@tromey.com>
1790
1791         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1792         PSYMBOL_SET_LANGUAGE.
1793         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1794
1795 2019-01-10  Tom Tromey  <tom@tromey.com>
1796
1797         * psymtab.h (psymtab_storage::obstack): New method.
1798         <m_obstack>: Rename from obstack; now private.
1799         * psymtab.c (psymtab_storage): Update.
1800         * dwarf2read.c (create_addrmap_from_index)
1801         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1802         Update.
1803
1804 2019-01-10  Tom Tromey  <tom@tromey.com>
1805
1806         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1807         * objfiles.h (objfile::reset_psymtabs): New method.
1808
1809 2019-01-10  Tom Tromey  <tom@tromey.com>
1810
1811         * symmisc.c (print_symbol_bcache_statistics): Update.
1812         (print_objfile_statistics): Update.
1813         * symfile.c (reread_symbols): Update.
1814         * psymtab.h (class psymtab_storage): New.
1815         * psymtab.c (psymtab_storage): New constructor.
1816         (~psymtab_storage): New destructor.
1817         (require_partial_symbols): Update.
1818         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1819         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1820         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1821         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1822         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1823         (start_psymtab_common, end_psymtab_common)
1824         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1825         (allocate_psymtab): Update.
1826         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1827         Update.
1828         (dump_psymtab_addrmap, maintenance_print_psymbols)
1829         (maintenance_check_psymtabs): Update.
1830         (class objfile_psymtabs): Move to objfiles.h.
1831         * psympriv.h (discard_psymtab): Now inline.
1832         (psymtab_discarder::psymtab_discarder): Update.
1833         (psymtab_discarder::~psymtab_discarder): Update.
1834         (ALL_OBJFILE_PSYMTABS): Rewrite.
1835         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1836         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1837         Remove fields.
1838         <partial_symtabs>: New field.
1839         (class objfile_psymtabs): Move from psymtab.h.  Update.
1840         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1841         psymbol_cache.
1842         (objfile::~objfile): Don't destroy psymbol_cache.
1843         * mdebugread.c (parse_partial_symbols): Update.
1844         * dwarf2read.c (create_addrmap_from_index)
1845         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1846         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1847         (add_partial_subprogram, dwarf2_ranges_read): Update.
1848         * dwarf-index-write.c (write_address_map)
1849         (write_one_signatured_type, recursively_write_psymbols)
1850         (class debug_names, class debug_names, write_psymtabs_to_index):
1851         Update.
1852
1853 2019-01-10  Tom Tromey  <tom@tromey.com>
1854
1855         * symtab.h (SYMBOL_SET_NAMES): Update.
1856         (symbol_set_names): Update.
1857         (MSYMBOL_SET_NAMES): Update.
1858         * symtab.c (symbol_set_names): Change argument to be an
1859         objfile_per_bfd_storage.
1860         * psymtab.c (add_psymbol_to_bcache): Update.
1861         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1862
1863 2019-01-10  Tom Tromey  <tom@tromey.com>
1864
1865         * symtab.c (create_demangled_names_hash): Change argument to be an
1866         objfile_per_bfd_storage.
1867         (symbol_set_names): Update.
1868
1869 2019-01-10  Tom Tromey  <tom@tromey.com>
1870
1871         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1872         init_psymbol_list.
1873         * psymtab.c (init_psymbol_list): Do nothing if already called.
1874         * psympriv.h (init_psymbol_list): Add comment.
1875         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1876         init_psymbol_list.
1877         * dbxread.c (dbx_symfile_read): Unconditionally call
1878         init_psymbol_list.
1879
1880 2019-01-10  Tom Tromey  <tom@tromey.com>
1881
1882         * xcoffread.c (scan_xcoff_symtab): Update.
1883         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1884         "where".
1885         * mdebugread.c (parse_partial_symbols)
1886         (handle_psymbol_enumerators): Update.
1887         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1888         * dbxread.c (read_dbx_symtab): Update.
1889         * psympriv.h (psymbol_placement): New enum.
1890         (add_psymbol_to_list): Update.
1891
1892 2019-01-10  Tom Tromey  <tom@tromey.com>
1893
1894         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1895         static_psymbols parameters.
1896         (scan_xcoff_symtab): Update.
1897         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1898         static_psymbols parameters.
1899         * psympriv.h (start_psymtab_common): Update.
1900         * mdebugread.c (parse_partial_symbols): Update.
1901         * dwarf2read.c (create_partial_symtab): Update.
1902         * dbxread.c (read_dbx_symtab): Update.
1903         (start_psymtab): Remove global_psymbols and static_psymbols
1904         parameters.
1905
1906 2019-01-10  Tom Tromey  <tom@tromey.com>
1907
1908         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1909         * psymtab.c (allocate_psymtab): Add comment.
1910         * psympriv.h (allocate_psymtab): Add comment.
1911         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1912         initializations.
1913         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1914
1915 2019-01-10  Tom Tromey  <tom@tromey.com>
1916
1917         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1918         Don't declare.
1919         * mipsread.c: Include mdebugread.h.
1920         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1921         Declare.
1922         * elfread.c: Include mdebugread.h.
1923
1924 2019-01-09  Tom Tromey  <tom@tromey.com>
1925
1926         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1927         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1928         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1929         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1930         (psym_lookup_symbol, psym_find_last_source_symtab)
1931         (psym_forget_cached_source_info, psym_print_stats)
1932         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1933         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1934         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1935         (psym_find_compunit_symtab_by_address)
1936         (maintenance_print_psymbols, maintenance_info_psymtabs)
1937         (maintenance_check_psymtabs): Use ranged for.
1938         * psymtab.h (class objfile_psymtabs): New.
1939         (require_partial_symbols): Return objfile_psymtabs.
1940         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1941
1942 2019-01-09  Tom Tromey  <tom@tromey.com>
1943
1944         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1945         (find_pc_mapped_section, list_overlays_command)
1946         (map_overlay_command, unmap_overlay_command)
1947         (simple_overlay_update): Use all_objfiles.
1948         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1949         * printcmd.c (info_symbol_command): Use all_objfiles.
1950         * objfiles.h (ALL_OBJSECTIONS): Remove.
1951         * maint.c (maintenance_translate_address): Use all_objfiles.
1952         * gcore.c (gcore_create_callback): Use all_objfiles.
1953         (objfile_find_memory_regions): Likewise.
1954
1955 2019-01-09  Tom Tromey  <tom@tromey.com>
1956
1957         * symtab.c (find_line_symtab, info_sources_command)
1958         (make_source_files_completion_list): Use objfile_compunits.
1959         * source.c (select_source_symtab): Use objfile_compunits.
1960         * objfiles.h (struct objfile): Update comment.
1961         (ALL_OBJFILES): Remove.
1962         (ALL_FILETABS): Remove.
1963         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1964         objfile_compunits.
1965
1966 2019-01-09  Tom Tromey  <tom@tromey.com>
1967
1968         * symmisc.c (print_objfile_statistics, dump_objfile)
1969         (maintenance_print_symbols): Use compunit_filetabs.
1970         * source.c (forget_cached_source_info_for_objfile): Use
1971         compunit_filetabs.
1972         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1973         (ALL_FILETABS): Use compunit_filetabs.
1974         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1975         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1976
1977 2019-01-09  Tom Tromey  <tom@tromey.com>
1978
1979         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1980         (compunit_filetabs): New.
1981         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1982         compunit_filetabs.
1983         (info_sources_command, make_source_files_completion_list): Remove
1984         declaration.
1985         * symmisc.c (print_objfile_statistics, dump_objfile)
1986         (maintenance_print_symbols): Remove declaration.
1987         (maintenance_info_symtabs): Use compunit_filetabs.
1988         (maintenance_info_line_tables): Likewise.
1989         * source.c (select_source_symtab): Change local variable name.
1990         (forget_cached_source_info_for_objfile): Remove declaration.
1991         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1992         * objfiles.c (objfile_relocate1): Remove declaration.
1993         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1994         declaration.
1995         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1996         * coffread.c (coff_symtab_read): Remove declaration.
1997         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1998         compunit_filetabs.
1999
2000 2019-01-09  Tom Tromey  <tom@tromey.com>
2001
2002         * symtab.c (lookup_objfile_from_block)
2003         (find_pc_sect_compunit_symtab, search_symbols)
2004         (default_collect_symbol_completion_matches_break_on): Use
2005         objfile_compunits.
2006         * objfiles.h (ALL_COMPUNITS): Remove.
2007         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2008         * cp-support.c (add_symbol_overload_list_qualified): Use
2009         objfile_compunits.
2010         * ada-lang.c (ada_collect_symbol_completion_matches)
2011         (ada_add_global_exceptions): Use objfile_compunits.
2012
2013 2019-01-09  Tom Tromey  <tom@tromey.com>
2014
2015         * source.c (select_source_symtab)
2016         (forget_cached_source_info_for_objfile): Remove declaration.
2017         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2018         declaration.
2019         * maint.c (count_symtabs_and_blocks): Remove declaration.
2020         * cp-support.c (add_symbol_overload_list_qualified): Remove
2021         declaration.
2022         * coffread.c (coff_symtab_read): Remove declaration.
2023         * symtab.c (lookup_symbol_in_objfile_symtabs)
2024         (basic_lookup_transparent_type_1): Use objfile_compunits.
2025         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2026         (info_sources_command, search_symbols)
2027         (default_collect_symbol_completion_matches_break_on)
2028         (make_source_files_completion_list): Remove declaration.
2029         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2030         (ada_collect_symbol_completion_matches)
2031         (ada_add_global_exceptions): Remove declaration.
2032         * linespec.c (iterate_over_all_matching_symtabs): Use
2033         objfile_compunits.
2034         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2035         (class objfile_compunits): New.
2036         (ALL_COMPUNITS): Use objfile_compunits.
2037         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2038         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2039         objfile_compunits.
2040         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2041
2042 2019-01-09  Tom Tromey  <tom@tromey.com>
2043
2044         * symtab.c (search_symbols)
2045         (default_collect_symbol_completion_matches_break_on): Use
2046         objfile_msymbols.
2047         * ada-lang.c (ada_lookup_simple_minsym)
2048         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2049         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2050         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2051         objfile_msymbols.
2052         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2053         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2054         * objc-lang.c (find_methods): Use objfile_msymbols.
2055         (info_selectors_command, info_classes_command): Likewise.
2056         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2057         * objfiles.h (class objfile_msymbols): New.
2058         (ALL_OBJFILE_MSYMBOLS): Remove.
2059         (ALL_MSYMBOLS): Remove.
2060
2061 2019-01-09  Tom Tromey  <tom@tromey.com>
2062
2063         * common/next-iterator.h (next_adapter): Add Iterator template
2064         parameter.
2065         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2066         (class all_objfiles_safe): New.
2067         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2068         * objfiles.c (put_objfile_before): Update comment.
2069         (add_separate_debug_objfile): Likewise.
2070         (free_all_objfiles): Use all_objfiles_safe.
2071         (objfile_purge_solibs): Likewise.
2072
2073 2019-01-09  Tom Tromey  <tom@tromey.com>
2074
2075         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2076         (expand_symtab_containing_pc, lookup_static_symbol)
2077         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2078         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2079         all_objfiles.
2080         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2081         * breakpoint.c (create_overlay_event_breakpoint)
2082         (create_longjmp_master_breakpoint)
2083         (create_std_terminate_master_breakpoint)
2084         (create_exception_master_breakpoint): Use all_objfiles.
2085         * linux-thread-db.c (try_thread_db_load_from_pdir)
2086         (has_libpthread): Use all_objfiles.
2087         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2088         * linespec.c (iterate_over_all_matching_symtabs)
2089         (search_minsyms_for_name): Use all_objfiles.
2090         * maint.c (maintenance_info_sections): Use all_objfiles.
2091         * main.c (captured_main_1): Use all_objfiles.
2092         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2093         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2094         * guile/scm-pretty-print.c
2095         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2096         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2097         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2098         (maintenance_print_msymbols): Use all_objfiles.
2099         * source.c (select_source_symtab): Use all_objfiles.
2100         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2101         * symfile.c (remove_symbol_file_command)
2102         (expand_symtabs_matching, map_symbol_filenames): Use
2103         all_objfiles.
2104         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2105         all_objfiles.
2106         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2107         * objc-lang.c (find_methods): Use all_objfiles.
2108         * objfiles.c (have_partial_symbols, have_full_symbols)
2109         (have_minimal_symbols, qsort_cmp)
2110         (default_iterate_over_objfiles_in_search_order): Use
2111         all_objfiles.
2112         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2113         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2114         (maintenance_check_psymtabs): Use all_objfiles.
2115         (ALL_PSYMTABS): Remove.
2116         * compile/compile-object-run.c (do_module_cleanup): Use
2117         all_objfiles.
2118         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2119         * cp-support.c (add_symbol_overload_list_qualified): Use
2120         all_objfiles.
2121         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2122         Use all_objfiles.
2123         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2124         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2125         all_objfiles.
2126         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2127         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2128         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2129         Uses all_objfiles.
2130         * solib.c (solib_read_symbols): Use all_objfiles
2131
2132 2019-01-09  Tom Tromey  <tom@tromey.com>
2133
2134         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2135         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2136         all_objfiles.
2137         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2138         * symmisc.c (print_symbol_bcache_statistics)
2139         (print_objfile_statistics, maintenance_print_objfiles)
2140         (maintenance_info_symtabs, maintenance_check_symtabs)
2141         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2142         all_objfiles.
2143         * source.c (forget_cached_source_info): Use all_objfiles.
2144         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2145         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2146         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2147         * objfiles.c (update_section_map): Use all_objfiles.
2148         (shared_objfile_contains_address_p): Likewise.
2149         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2150         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2151
2152 2019-01-09  Tom Tromey  <tom@tromey.com>
2153
2154         * common/next-iterator.h: New file.
2155         * objfiles.h (class all_objfiles): New.
2156         (struct objfile_iterator): New.
2157
2158 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2159
2160         * NEWS: Move the description of the changed "frame", "select-frame",
2161          and "info frame" commands to the Changed commands section.
2162
2163 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2164
2165         * gdbtypes.c (check_stub_method_group): Remove handling of old
2166         mangling schemes.
2167         * linespec.c (find_methods): Likewise.
2168         * stabsread.c (read_member_functions): Likewise.
2169         * valops.c (search_struct_method): Likewise.
2170         (value_struct_elt_for_reference): Likewise.
2171         * NEWS: Mention this change.
2172
2173 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2174
2175         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2176         print_source_lines.
2177         * source.c (print_source_lines_base): Update line number check.
2178         (print_source_lines): New function.
2179         (source_lines_range::source_lines_range): New function.
2180         * source.h (class source_lines_range): New class.
2181         (print_source_lines): New declaration.
2182
2183 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2184
2185         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2186
2187 2019-01-08  Tom Tromey  <tom@tromey.com>
2188             Simon Marchi  <simon.marchi@ericsson.com>
2189
2190         PR gdb/24060
2191         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2192         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2193         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2194         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2195         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2196         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2197
2198 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2199
2200         * source.c (select_source_symtab): Move header comment to
2201         declaration in source.h.
2202         (forget_cached_source_info_for_objfile): Likewise.
2203         (forget_cached_source_info): Likewise.
2204         (identify_source_line): Likewise.
2205         * source.h (identify_source_line): Move declaration from symtab.h
2206         and add comment from source.c
2207         (print_source_lines): Likewise.
2208         (forget_cached_source_info_for_objfile): Likewise.
2209         (forget_cached_source_info): Likewise.
2210         (select_source_symtab): Likewise.
2211         (enum print_source_lines_flag): Move definition from symtab.h.
2212         * symtab.h (identify_source_line): Move declaration to source.h.
2213         (print_source_lines): Likewise.
2214         (forget_cached_source_info_for_objfile): Likewise.
2215         (forget_cached_source_info): Likewise.
2216         (select_source_symtab): Likewise.
2217         (enum print_source_lines_flag): Move definition to source.h.
2218         * tui/tui-hooks.c: Add 'source.h' include.
2219
2220 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2221
2222         * source.c (print_source_lines_base): Handle requests to print
2223         reverse line number sequences, and guard against empty lines
2224         string.
2225
2226 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2227
2228         * source.c (print_source_lines_base): Fix skip of '\r' if next
2229         character is '\n'.
2230
2231 2019-01-06  Tom Tromey  <tom@tromey.com>
2232
2233         * c-exp.y (struct c_parse_state) <macro_original_text,
2234         expansion_obstack>: New member.
2235         (macro_original_text, expansion_obstack): Remove globals.
2236         (scan_macro_expansion, scanning_macro_expansion)
2237         (finished_macro_expansion): Update.
2238         (scan_macro_cleanup): Remove.
2239         (yylex, c_parse): Update.
2240
2241 2019-01-06  Tom Tromey  <tom@tromey.com>
2242
2243         * c-exp.y (struct c_parse_state) <strings>: New member.
2244         (operator_stoken): Update.
2245
2246 2019-01-06  Tom Tromey  <tom@tromey.com>
2247
2248         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2249         (union type_stack_elt) <typelist_val>: Now a pointer to
2250         std::vector.
2251         (type_stack_cleanup): Don't declare.
2252         (push_typelist): Update.
2253         * parse.c (pop_typelist): Return a std::vector.
2254         (push_typelist): Take a std::vector.
2255         (follow_types): Update.  Do not free args.
2256         (type_stack_cleanup): Remove.
2257         * c-exp.y (struct c_parse_state): New.
2258         (cpstate): New global.
2259         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2260         (nonempty_typelist): Update.
2261         (func_mod): Create a new vector.
2262         (c_parse): Create a c_parse_state.
2263         (check_parameter_typelist): Do not delete params.
2264         (function_method): Update.  Do not delete type_list.
2265
2266 2019-01-06  Tom Tromey  <tom@tromey.com>
2267
2268         PR gdb/28155:
2269         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2270         check_typedef.
2271         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2272         (print_return_value): Likewise.
2273
2274 2019-01-05  Tom Tromey  <tom@tromey.com>
2275
2276         * contrib/cleanup_check.py: Remove.
2277         * contrib/gcc-with-excheck: Remove.
2278         * contrib/exsummary.py: Remove.
2279         * contrib/excheck.py: Remove.
2280
2281 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2282
2283         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2284         NULL. Initialize tpprev to NULL instead of assigning it
2285         to NULL on the next statement.
2286         * windows-nat.c (windows_delete_thread): Remove check for
2287         main_thread_id before printing thread exit notifications.
2288         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2289         Remove thread ID check against main_thread_id.
2290         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2291         windows_delete_thread.
2292         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2293
2294 2019-01-04  Tom Tromey  <tom@tromey.com>
2295
2296         * compile/compile.c (_initialize_compile): Use upper case for
2297         metasyntactic variables.
2298         * symmisc.c (_initialize_symmisc): Use upper case for
2299         metasyntactic variables.
2300         * psymtab.c (_initialize_psymtab): Use upper case for
2301         metasyntactic variables.
2302         * demangle.c (demangle_command): Use upper case for metasyntactic
2303         variables.
2304         (_initialize_demangler): Likewise.
2305         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2306         variables.
2307
2308 2019-01-03  Tom Tromey  <tom@tromey.com>
2309
2310         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2311
2312 2019-01-03  Tom Tromey  <tom@tromey.com>
2313
2314         * python/py-symtab.c (salpy_str): Update.
2315         (struct salpy_sal_object) <symtab>: Now a PyObject.
2316         (salpy_dealloc): Update.
2317         (del_objfile_sal): Use gdbpy_ref.
2318
2319 2019-01-03  Tom Tromey  <tom@tromey.com>
2320
2321         * python/py-type.c (convert_field): Use new_reference.  Return
2322         gdbpy_ref.
2323         (make_fielditem): Return gdbpy_ref.
2324         (typy_fields): Update.
2325         (typy_getitem): Update.
2326         (field_name): Return gdbpy_ref.  Use new_reference.
2327         (typy_iterator_iternext): Update.
2328
2329 2019-01-03  Tom Tromey  <tom@tromey.com>
2330
2331         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2332
2333 2019-01-03  Tom Tromey  <tom@tromey.com>
2334
2335         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2336         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2337         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2338         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2339         (pspy_set_type_printers): Likewise.
2340         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2341         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2342         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2343         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2344         (objfpy_set_type_printers): Likewise.
2345
2346 2019-01-03  Tom Tromey  <tom@tromey.com>
2347
2348         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2349         (gdbpy_print_stack): Use gdbpy_err_fetch.
2350         * python/python-internal.h (class gdbpy_err_fetch): New class.
2351         (class gdbpy_enter) <m_error_type, m_error_value,
2352         m_error_traceback>: Remove.
2353         <m_error>: New member.
2354         (gdbpy_exception_to_string): Don't declare.
2355         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2356         * python/py-value.c (convert_value_from_python): Use
2357         gdbpy_err_fetch.
2358         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2359         gdbpy_exception_to_string.
2360         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2361         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2362         gdbpy_err_fetch.
2363
2364 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2365
2366         * linux-nat.c (delete_lwp_cleanup): Delete.
2367         (struct lwp_deleter): New struct.
2368         (lwp_info_up): New typedef.
2369         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2370         lwp_info_up.
2371
2372 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2373
2374         * linux-fork.c (class scoped_switch_fork_info): New class.
2375         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2376
2377 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2378
2379         * valops.c (find_overload_match): Remove use of null_cleanup, and
2380         calls to do_cleanups.
2381
2382 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2383
2384         * compile/compile-cplus-types.c
2385         (compile_cplus_instance::decl_name): Handle changes to
2386         cp_func_name.
2387         * cp-support.c (cp_func_name): Update header comment, update
2388         return type.
2389         * cp-support.h (cp_func_name): Update return type in declaration.
2390         * valops.c (find_overload_match): Move temp_func local to top
2391         level of function and change its type.  Use temp_func to hold and
2392         delete temporary string obtained from cp_func_name.
2393
2394 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2395
2396         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2397         gdb::char_vector, remove cleanup, and update uses of `msg`.
2398
2399 2019-01-03  Jim Wilson  <jimw@sifive.com>
2400
2401         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2402
2403 2019-01-02  Tom Tromey  <tom@tromey.com>
2404
2405         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2406         (tdesc_parse_xml): Remove cleanups.
2407         * target-descriptions.h (make_cleanup_free_target_description):
2408         Don't declare.
2409         (target_desc_deleter): New struct.
2410         (target_desc_up): New typedef.
2411         * target-descriptions.c (target_desc_deleter::operator()): Rename
2412         from free_target_description.
2413         (make_cleanup_free_target_description): Remove.
2414
2415 2019-01-02  Tom Tromey  <tom@tromey.com>
2416
2417         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2418         constructor, destructor.
2419         (linespec_parser): Remove typedef.
2420         (~linespec_parser): Rename from linespec_parser_delete.
2421         (linespec_lex_to_end, linespec_complete_label)
2422         (linespec_complete): Update.
2423         (decode_line_full): Remove cleanups.
2424         (decode_line_1): Update.
2425
2426 2019-01-02  Tom Tromey  <tom@tromey.com>
2427
2428         * python/python-internal.h (inferior_to_inferior_object): Change
2429         return type.
2430         * python/py-exitedevent.c (create_exited_event_object): Update.
2431         * python/py-inferior.c (inferior_to_inferior_object): Return
2432         gdbpy_ref.
2433         (python_new_inferior, python_inferior_deleted)
2434         (thread_to_thread_object, delete_thread_object)
2435         (build_inferior_list, gdbpy_selected_inferior): Update.
2436         * python/py-infthread.c (create_thread_object): Update.  Also fail
2437         if inferior_to_inferior_object fails.
2438
2439 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2440
2441         * inferior.h (class inferior) <displaced_step_state>: New field.
2442         * infrun.h (struct displaced_step_state): Move here from
2443         infrun.c.  Initialize fields, add constructor.
2444         <inf>: Remove field.
2445         <reset>: New method.
2446         * infrun.c (struct displaced_step_inferior_state): Move to
2447         infrun.h.
2448         (displaced_step_inferior_states): Remove.
2449         (get_displaced_stepping_state): Adust.
2450         (displaced_step_in_progress_any_inferior): Adjust.
2451         (displaced_step_in_progress_thread): Adjust.
2452         (displaced_step_in_progress): Adjust.
2453         (add_displaced_stepping_state): Remove.
2454         (get_displaced_step_closure_by_addr): Adjust.
2455         (remove_displaced_stepping_state): Remove.
2456         (infrun_inferior_exit): Call displaced_step_state.reset.
2457         (use_displaced_stepping): Don't check for NULL.
2458         (displaced_step_prepare_throw): Call
2459         get_displaced_stepping_state.
2460         (displaced_step_fixup): Don't check for NULL.
2461         (prepare_for_detach): Don't check for NULL.
2462
2463 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2464
2465         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2466          in case of call that did not complete.
2467
2468 2019-01-02  Andrey Utkin  <autkin@undo.io>
2469
2470         * symfile.c (find_separate_debug_file): Fix search of debug files for
2471         remote debuggee.
2472
2473 2019-01-02  Tom Tromey  <tom@tromey.com>
2474
2475         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2476         indentation.
2477         * python/py-frame.c (frapy_older): Remove cast.
2478         (frapy_newer): Likewise.
2479         * python/py-breakpoint.c (local_setattro): Remove cast.
2480         * python/py-arch.c (archpy_name): Remove local variable.
2481         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2482
2483 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2484
2485         * unittests/basic_string_view/element_access/char/empty.cc:
2486         Fix year range in copyright header.
2487
2488 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2489
2490         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2491         Delete.
2492         <operator==>: Update with for removed field.
2493         <hash>: Likewise.
2494         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2495         <isa_features>: ...this.
2496         <abi_features>: New field.
2497         (riscv_isa_flen): Update comment.
2498         (riscv_abi_xlen): New declaration.
2499         (riscv_abi_flen): New declaration.
2500         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2501         isa_features.
2502         (riscv_abi_xlen): New function.
2503         (riscv_isa_flen): Update to get answer from isa_features.
2504         (riscv_abi_flen): New function.
2505         (riscv_has_fp_abi): Update to get answer from abi_features.
2506         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2507         xlen and flen.
2508         (riscv_call_info) <xlen, flen>: Update comment.
2509         (riscv_call_arg_struct): Remove invalid assertions
2510         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2511         is removed.
2512         (riscv_gdbarch_init): Gather isa features and abi features
2513         separately, ensure both match on the gdbarch when reusing an old
2514         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2515         a target with 64-bit float hardware.
2516
2517 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2518
2519         * source.c (search_command_helper): Stop reverse search
2520         when line 1 has been searched.
2521
2522 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2523
2524         * record-full.c (record_full_base_target::close): Rewrite
2525         record_full_core_buf_list free logic.
2526
2527 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2528
2529         * break-catch-syscall.c (print_one_catch_syscall): xfree
2530         the last text.
2531
2532 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2533
2534         * top.c (print_gdb_version): Update Copyright year in version
2535         message.
2536
2537 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2538
2539         Update copyright year range in all GDB files.
2540
2541 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2542
2543         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2544
2545 For older changes see ChangeLog-2018.
2546 \f
2547 Local Variables:
2548 mode: change-log
2549 left-margin: 8
2550 fill-column: 74
2551 version-control: never
2552 coding: utf-8
2553 End:
2554