gdb/ChangeLog

   1 2019-01-22  Tom Tromey  <tom@tromey.com>
   2
   3         * compile/compile-cplus-types.c: Remove a comment by #include.
   4
   5 2019-01-22  Tom Tromey  <tom@tromey.com>
   6
   7         * compile/gcc-c-plugin.h: Include compile-internal.h.
   8
   9 2019-01-22  Tom Tromey  <tom@tromey.com>
  10
  11         * stabsread.c (EXTERN): Do not define.
  12         (symnum, next_symbol_text_func, processing_gcc_compilation)
  13         (within_function, global_sym_chain, global_stabs)
  14         (previous_stab_code, this_object_header_files)
  15         (n_this_object_header_files)
  16         (n_allocated_this_object_header_files): Define.
  17         * stabsread.h (EXTERN): Never define.  Use "extern".
  18
  19 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  20
  21         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
  22         history_value.
  23
  24 2019-01-21  Tom Tromey  <tom@tromey.com>
  25
  26         * ui-out.c: Fix includes.
  27         * tui/tui-source.c: Fix includes.
  28         * target.c: Fix includes.
  29         * remote.c: Fix includes.
  30         * regcache.c: Fix includes.
  31         * python/py-block.c: Fix includes.
  32         * printcmd.c: Fix includes.
  33         * or1k-tdep.c: Fix includes.
  34         * mi/mi-main.c: Fix includes.
  35         * m32r-tdep.c: Fix includes.
  36         * csky-tdep.c: Fix includes.
  37         * compile/compile-cplus-types.c: Fix includes.
  38         * cli/cli-interp.c: Fix includes.
  39
  40 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
  41
  42         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
  43         for padding.
  44
  45 2019-01-16  Tom Tromey  <tom@tromey.com>
  46
  47         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
  48         earlier.
  49         (struct objfile) <msymbols_range>: Move from top level.
  50         <msymbols>: New method.
  51         (class objfile_msymbols): Remove.
  52         * symtab.c (default_collect_symbol_completion_matches_break_on):
  53         Update.
  54         * symmisc.c (dump_msymbols): Update.
  55         * stabsread.c (scan_file_globals): Update.
  56         * objc-lang.c (info_selectors_command, info_classes_command)
  57         (find_methods): Update.
  58         * minsyms.c (find_solib_trampoline_target): Update.
  59         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
  60         * coffread.c (coff_symfile_read): Update.
  61         * ada-lang.c (ada_lookup_simple_minsym)
  62         (ada_collect_symbol_completion_matches): Update.
  63
  64 2019-01-16  Tom Tromey  <tom@tromey.com>
  65
  66         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
  67         type.  Remove no-argument constructor.
  68         <iterator::operator++>: Simplify.
  69         <begin>: Update.
  70         <end>: Use minimal_symbol_count.
  71
  72 2019-01-16  Tom Tromey  <tom@tromey.com>
  73
  74         * objfiles.h (struct objfile) <psymtabs>: New method.
  75         (class objfile_psymtabs): Remove.
  76         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
  77         typedef.
  78         <range>: New method.
  79         (require_partial_symbols): Change return type.
  80         * psymtab.c (require_partial_symbols)
  81         (psym_expand_symtabs_matching): Update.
  82         * mdebugread.c (parse_partial_symbols): Update.
  83         * dbxread.c (dbx_end_psymtab): Update.
  84
  85 2019-01-15  Tom Tromey  <tom@tromey.com>
  86
  87         * symtab.c (lookup_objfile_from_block)
  88         (lookup_symbol_in_objfile_symtabs)
  89         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
  90         (find_line_symtab, info_sources_command)
  91         (default_collect_symbol_completion_matches_break_on)
  92         (make_source_files_completion_list): Update.
  93         * symmisc.c (print_objfile_statistics, dump_objfile)
  94         (maintenance_print_symbols, maintenance_info_symtabs)
  95         (maintenance_check_symtabs, maintenance_info_line_tables):
  96         Update.
  97         * source.c (select_source_symtab)
  98         (forget_cached_source_info_for_objfile): Update.
  99         * objfiles.h (class objfile_compunits): Remove.
 100         (struct objfile) <compunits_range>: New typedef.
 101         (compunits): New method.
 102         * objfiles.c (objfile_relocate1): Update.
 103         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 104         * maint.c (count_symtabs_and_blocks): Update.
 105         * linespec.c (iterate_over_all_matching_symtabs): Update.
 106         * cp-support.c (add_symbol_overload_list_qualified): Update.
 107         * coffread.c (coff_symtab_read): Update.
 108         * ada-lang.c (add_nonlocal_symbols)
 109         (ada_collect_symbol_completion_matches)
 110         (ada_add_global_exceptions): Update.
 111
 112 2019-01-15  Tom Tromey  <tom@tromey.com>
 113
 114         * progspace.h (program_space) <objfiles_safe_range>: New
 115         typedef.
 116         <objfiles_safe>: New method.
 117         * objfiles.h (class all_objfiles_safe): Remove.
 118         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
 119         * jit.c (jit_inferior_exit_hook): Update.
 120
 121 2019-01-17  Tom Tromey  <tom@tromey.com>
 122
 123         * progspace.h (program_space) <objfiles_range>: New typedef.
 124         <objfiles>: New method.
 125         <objfiles_head>: Rename from objfiles.
 126         (object_files): Update.
 127         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
 128         * guile/scm-pretty-print.c
 129         (ppscm_find_pretty_printer_from_objfiles): Update.
 130         * guile/scm-objfile.c (gdbscm_objfiles): Update.
 131         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
 132         Update.
 133         * python/py-progspace.c (pspy_get_objfiles): Update.
 134         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 135         Update.
 136         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 137         (objfpy_lookup_objfile_by_build_id): Update.
 138         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 139         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 140         Update.
 141         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 142         (expand_symtab_containing_pc, lookup_objfile_from_block)
 143         (lookup_static_symbol, basic_lookup_transparent_type)
 144         (find_pc_sect_compunit_symtab, find_symbol_at_address)
 145         (find_line_symtab, info_sources_command)
 146         (default_collect_symbol_completion_matches_break_on)
 147         (make_source_files_completion_list, find_main_name): Update.
 148         * symmisc.c (print_symbol_bcache_statistics)
 149         (print_objfile_statistics, maintenance_print_symbols)
 150         (maintenance_print_msymbols, maintenance_print_objfiles)
 151         (maintenance_info_symtabs, maintenance_check_symtabs)
 152         (maintenance_expand_symtabs, maintenance_info_line_tables):
 153         Update.
 154         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
 155         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
 156         (map_overlay_command, unmap_overlay_command)
 157         (simple_overlay_update, expand_symtabs_matching)
 158         (map_symbol_filenames): Update.
 159         * symfile-debug.c (set_debug_symfile): Update.
 160         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
 161         Update.
 162         * source.c (select_source_symtab, forget_cached_source_info):
 163         Update.
 164         * solib.c (solib_read_symbols): Update.
 165         * solib-spu.c (append_ocl_sos): Update.
 166         * psymtab.c (maintenance_print_psymbols)
 167         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
 168         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
 169         * printcmd.c (info_symbol_command): Update.
 170         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
 171         Update.
 172         * objfiles.h (class all_objfiles): Remove.
 173         * objfiles.c (have_partial_symbols, have_full_symbols)
 174         (have_minimal_symbols, qsort_cmp, update_section_map)
 175         (shared_objfile_contains_address_p)
 176         (default_iterate_over_objfiles_in_search_order): Update.
 177         * objc-lang.c (info_selectors_command, info_classes_command)
 178         (find_methods): Update.
 179         * minsyms.c (find_solib_trampoline_target): Update.
 180         * maint.c (maintenance_info_sections)
 181         (maintenance_translate_address, count_symtabs_and_blocks):
 182         Update.
 183         * main.c (captured_main_1): Update.
 184         * linux-thread-db.c (try_thread_db_load_from_pdir)
 185         (has_libpthread): Update.
 186         * linespec.c (iterate_over_all_matching_symtabs)
 187         (search_minsyms_for_name): Update.
 188         * jit.c (jit_find_objf_with_entry_addr): Update.
 189         * hppa-tdep.c (find_unwind_entry)
 190         (hppa_lookup_stub_minimal_symbol): Update.
 191         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
 192         Update.
 193         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 194         (elf_gnu_ifunc_resolve_by_got): Update.
 195         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
 196         * dwarf-index-write.c (save_gdb_index_command): Update.
 197         * cp-support.c (add_symbol_overload_list_qualified): Update.
 198         * breakpoint.c (create_overlay_event_breakpoint)
 199         (create_longjmp_master_breakpoint)
 200         (create_std_terminate_master_breakpoint)
 201         (create_exception_master_breakpoint): Update.
 202         * blockframe.c (find_pc_partial_function): Update.
 203         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
 204         (ada_collect_symbol_completion_matches)
 205         (ada_add_global_exceptions): Update.
 206
 207 2019-01-17  Tom Tromey  <tom@tromey.com>
 208
 209         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
 210         declare VEC.
 211         (solib_target_parse_libraries): Change return type.
 212         (library_list_start_segment, library_list_start_section)
 213         (library_list_end_library, library_list_start_library); Update.
 214         (solib_target_free_library_list): Remove.
 215         (solib_target_parse_libraries): Remove cleanup.  Change return
 216         type.
 217         (solib_target_current_sos): Update.
 218
 219 2019-01-17  Tom Tromey  <tromey@bapiya>
 220
 221         * valprint.c: Replace "the the" with "the".
 222         * symtab.c: Replace "the the" with "the".
 223         * solib.c: Replace "the the" with "the".
 224         * solib-dsbt.c: Replace "the the" with "the".
 225         * linespec.c: Replace "the the" with "the".
 226         * dwarf2loc.h: Replace "the the" with "the".
 227         * amd64-windows-tdep.c: Replace "the the" with "the".
 228         * aarch64-tdep.c: Replace "the the" with "the".
 229
 230 2019-01-16  Keith Seitz  <keiths@redhat.com>
 231
 232         PR gdb/23773
 233         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
 234         <builder>: Rename to ..
 235         <m_builder>: ... this and make private.
 236         (dwarf2_cu::get_builder): New method.  Change all users of
 237         `builder' to use this method.
 238         (dwarf2_start_symtab): Move to ...
 239         (dwarf2_cu::start_symtab): ... here.  Update all callers
 240         (setup_type_unit_groups): Move to ...
 241         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
 242         callers.
 243         (dwarf2_cu::reset_builder): New method.
 244         (process_full_compunit, process_full_type_unit): Use
 245         dwarf2_cu::reset_builder.
 246         (follow_die_offset): Record the ancestor CU if it is different
 247         from the followed DIE's CU.
 248         (follow_die_sig_1): Likewise.
 249
 250 2019-01-15  Tom Tromey  <tom@tromey.com>
 251
 252         * remote.c (class remote_state) <buf>: Now a char_vector.
 253         <buf_size>: Remove.
 254         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
 255         parameter.
 256         (remote_target::getpkt_or_notif_sane_1)
 257         (remote_target::getpkt_sane)
 258         (remote_target::getpkt_or_notif_sane): Likewise.
 259         (class remote_target) <putpkt>: New overload.
 260         (remote_target::read_frame): Change type of "buf_p".  Remove
 261         sizeof_p parameter.
 262         (packet_ok): New overload.
 263         (packet_check_result): New overload.
 264         Update all uses.
 265
 266 2019-01-14  Tom Tromey  <tom@tromey.com>
 267
 268         * remote-notif.c (handle_notification, remote_notif_ack)
 269         (remote_notif_parse): Make "buf" const.
 270         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
 271         const.
 272         (remote_notif_parse, remote_notif_ack, handle_notification):
 273         Likewise.
 274         * remote.c (remote_notif_stop_parse): Make "buf" const.
 275         (remote_target::remote_parse_stop_reply): Make "buf" const.
 276         (remote_notif_stop_ack): Make "buf" const.
 277
 278 2019-01-14  Tom Tromey  <tom@tromey.com>
 279
 280         * remote.c (remote_console_output): Make parameter const.
 281
 282 2019-01-14  Tom Tromey  <tom@tromey.com>
 283
 284         * target-debug.h (target_debug_print_signals): Constify.
 285         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
 286         * procfs.c (procfs_target::pass_signals): Update.
 287         * linux-nat.c (linux_nat_target::pass_signals): Update.
 288         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
 289         * target-delegates.c: Rebuild.
 290         * remote.c (remote_target::program_signals): Update.
 291         (remote_target::pass_signals): Update.
 292         * target.c (target_pass_signals): Constify argument.
 293         (target_program_signals): Likewise.
 294         * target.h (struct target_ops) <pass_signals, program_signals>:
 295         Constify argument.
 296         (target_pass_signals, target_program_signals): Constify argument.
 297
 298 2019-01-14  Tom Tromey  <tom@tromey.com>
 299
 300         PR tui/28819:
 301         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
 302
 303 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 304
 305         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
 306         field.
 307         * rs6000-tdep.c: Include reggroups.h.
 308         (IS_V_ALIAS_PSEUDOREG): Define.
 309         (rs6000_register_name): Return names for the "vX" aliases.
 310         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
 311         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
 312         aliases.  Call default_register_reggroup_p for all other
 313         pseudo-registers.
 314         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
 315         New functions.
 316         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
 317         Handle "vX" aliases.
 318         (v_alias_pseudo_register_collect): New function.
 319         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
 320         (rs6000_gdbarch_init): Initialize "vX" aliases as
 321         pseudo-registers.  Restore registration of
 322         rs6000_pseudo_register_reggroup_p with
 323         set_tdesc_pseudo_register_reggroup_p.
 324
 325 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
 326
 327         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
 328         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
 329         set_gdbarch_num_pseudo_regs.
 330
 331 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 332
 333         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
 334         Remove arg prefixname, add do_set and do_show.
 335         Add member functions set_list and show_list.
 336         * cli/cli-style.c (class cli_style_option): Update accordingly.
 337         (style_set_list): Move to file scope.
 338         (style_show_list): Likewise.
 339         (set_style): Call help_list.
 340         (show_style): Call cmd_show_list.
 341         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
 342         Update to use the new macro.
 343
 344 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
 345
 346         * ada-lang.c (_initialize_ada_language): Expand the help text
 347         for the "catch exception" command.
 348
 349 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 350
 351         * symtab.c (matching_obj_sections): Initialize obj,
 352         declare it closer to its usage.
 353
 354 2019-01-10  Tom Tromey  <tom@tromey.com>
 355
 356         * thread-iter.h (inf_threads_iterator): Use next_iterator.
 357         (basic_inf_threads_range): Remove.
 358         (inf_threads_range, inf_non_exited_threads_range)
 359         (safe_inf_threads_range): Use next_adapter.
 360
 361 2019-01-10  Keith Seitz  <keiths@redhat.com>
 362
 363         PR gdb/23712
 364         PR symtab/23010
 365         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
 366         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
 367
 368 2019-01-10  Keith Seitz  <keiths@redhat.com>
 369
 370         PR gdb/23712
 371         PR symtab/23010
 372         * dictionary.c (pending_to_vector): Remove.
 373         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 374         Remove _1 suffix, replacing functions of the same name.  Update
 375         all callers.
 376         (dict_create_hashed, dict_create_hashed_expandable)
 377         (dict_create_linear, dict_create_linear_expandable, dict_free)
 378         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
 379         Make functions static.
 380
 381 2019-01-10  Keith Seitz  <keiths@redhat.com>
 382
 383         PR gdb/23712
 384         PR symtab/23010
 385         * dictionary.h (struct dictionary): Replace declaration with
 386         multidictionary.
 387         (dict_create_hashed, dict_create_hashed_expandable)
 388         (dict_create_linear, dict_create_linear_expandable)
 389         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
 390         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
 391         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
 392         taking multidictionary argument.
 393         [ALL_DICT_SYMBOLS]: Update for multidictionary.
 394         * block.h (struct block) <dict>: Change to multidictionary
 395         and rename `multidict'.
 396         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
 397         symmisc.c: Update all dictionary references to multidictionary.
 398
 399 2019-01-10  Keith Seitz  <keiths@redhat.com>
 400
 401         PR gdb/23712
 402         PR symtab/23010
 403         * dictionary.c: Include unordered_map.
 404         (pending_to_vector): New function.
 405         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 406         Rewrite the non-"_1" functions to take vector instead
 407         of linked list.
 408         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
 409         "new" _1 versions of the same name.
 410         (multidictionary): Define.
 411         (std::hash<enum language): New definition.
 412         (collate_pending_symbols_by_language, mdict_create_hashed)
 413         (mdict_create_hashed_expandable, mdict_create_linear)
 414         (mdict_create_linear_expandable, mdict_free)
 415         (find_language_dictionary, create_new_language_dictionary)
 416         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
 417         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
 418         (mdict_size, mdict_empty): New functions.
 419         * dictionary.h (mdict_iterator): Define.
 420
 421 2019-01-10  Pedro Alves  <palves@redhat.com>
 422
 423         * breakpoint.c (read_uploaded_action)
 424         (create_tracepoint_from_upload): Adjust to use
 425         gdb::unique_xmalloc_ptr.
 426         * ctf.c (ctf_write_uploaded_tp):
 427         (SET_ARRAY_FIELD): Use emplace_back.
 428         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
 429         * tracefile-tfile.c (tfile_write_uploaded_tp):
 430         * tracepoint.c (parse_tracepoint_definition): Adjust to use
 431         gdb::unique_xmalloc_ptr.
 432         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
 433         at_string, cond_string, cmd_strings>: Replace char pointers
 434         with gdb::unique_xmalloc_ptr.
 435
 436 2019-01-10  Pedro Alves  <palves@redhat.com>
 437
 438         * solib-target.c (library_list_start_library): Don't xstrdup name.
 439
 440 2019-01-10  Pedro Alves  <palves@redhat.com>
 441
 442         * mdebugread.c (parse_partial_symbols): Use
 443         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
 444
 445 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 446
 447         * linux-fork.c (scoped_switch_fork_info)
 448         <~scoped_switch_fork_info>: Fix incorrect variable name.
 449
 450 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 451
 452         * linux-fork.c (scoped_switch_fork_info)
 453         <scoped_switch_fork_info>: Make explicit.
 454         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
 455
 456 2019-01-10  Tom Tromey  <tom@tromey.com>
 457
 458         * objfiles.h (objfile::reset_psymtabs): Update.
 459         * objfiles.c (objfile::objfile): Update.
 460         * psymtab.h (psymtab_storage::obstack): Update.
 461         (psymtab_storage::m_obstack): Use gdb::optional.
 462         (class psymtab_storage): Update comment.  Remove objfile
 463         parameter.
 464         * psymtab.c (psymtab_storage::psymtab_storage): Update.
 465
 466 2019-01-10  Tom Tromey  <tom@tromey.com>
 467
 468         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
 469         <free_psymtabs>: Now private.
 470         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
 471         (allocate_psymtab): Use new method.
 472
 473 2019-01-10  Tom Tromey  <tom@tromey.com>
 474
 475         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
 476         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
 477         * mdebugread.c (parse_partial_symbols): Use
 478         allocate_dependencies.
 479         * dwarf2read.c (dwarf2_create_include_psymtab): Use
 480         allocate_dependencies.
 481         (process_psymtab_comp_unit_reader)
 482         (build_type_psymtab_dependencies): Likewise.
 483         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
 484
 485 2019-01-10  Tom Tromey  <tom@tromey.com>
 486
 487         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
 488         PSYMBOL_SET_LANGUAGE.
 489         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
 490
 491 2019-01-10  Tom Tromey  <tom@tromey.com>
 492
 493         * psymtab.h (psymtab_storage::obstack): New method.
 494         <m_obstack>: Rename from obstack; now private.
 495         * psymtab.c (psymtab_storage): Update.
 496         * dwarf2read.c (create_addrmap_from_index)
 497         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
 498         Update.
 499
 500 2019-01-10  Tom Tromey  <tom@tromey.com>
 501
 502         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
 503         * objfiles.h (objfile::reset_psymtabs): New method.
 504
 505 2019-01-10  Tom Tromey  <tom@tromey.com>
 506
 507         * symmisc.c (print_symbol_bcache_statistics): Update.
 508         (print_objfile_statistics): Update.
 509         * symfile.c (reread_symbols): Update.
 510         * psymtab.h (class psymtab_storage): New.
 511         * psymtab.c (psymtab_storage): New constructor.
 512         (~psymtab_storage): New destructor.
 513         (require_partial_symbols): Update.
 514         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
 515         (find_pc_sect_psymtab, find_pc_sect_psymbol)
 516         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
 517         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
 518         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
 519         (start_psymtab_common, end_psymtab_common)
 520         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
 521         (allocate_psymtab): Update.
 522         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
 523         Update.
 524         (dump_psymtab_addrmap, maintenance_print_psymbols)
 525         (maintenance_check_psymtabs): Update.
 526         (class objfile_psymtabs): Move to objfiles.h.
 527         * psympriv.h (discard_psymtab): Now inline.
 528         (psymtab_discarder::psymtab_discarder): Update.
 529         (psymtab_discarder::~psymtab_discarder): Update.
 530         (ALL_OBJFILE_PSYMTABS): Rewrite.
 531         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
 532         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
 533         Remove fields.
 534         <partial_symtabs>: New field.
 535         (class objfile_psymtabs): Move from psymtab.h.  Update.
 536         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
 537         psymbol_cache.
 538         (objfile::~objfile): Don't destroy psymbol_cache.
 539         * mdebugread.c (parse_partial_symbols): Update.
 540         * dwarf2read.c (create_addrmap_from_index)
 541         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 542         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
 543         (add_partial_subprogram, dwarf2_ranges_read): Update.
 544         * dwarf-index-write.c (write_address_map)
 545         (write_one_signatured_type, recursively_write_psymbols)
 546         (class debug_names, class debug_names, write_psymtabs_to_index):
 547         Update.
 548
 549 2019-01-10  Tom Tromey  <tom@tromey.com>
 550
 551         * symtab.h (SYMBOL_SET_NAMES): Update.
 552         (symbol_set_names): Update.
 553         (MSYMBOL_SET_NAMES): Update.
 554         * symtab.c (symbol_set_names): Change argument to be an
 555         objfile_per_bfd_storage.
 556         * psymtab.c (add_psymbol_to_bcache): Update.
 557         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
 558
 559 2019-01-10  Tom Tromey  <tom@tromey.com>
 560
 561         * symtab.c (create_demangled_names_hash): Change argument to be an
 562         objfile_per_bfd_storage.
 563         (symbol_set_names): Update.
 564
 565 2019-01-10  Tom Tromey  <tom@tromey.com>
 566
 567         * xcoffread.c (xcoff_initial_scan): Unconditionally call
 568         init_psymbol_list.
 569         * psymtab.c (init_psymbol_list): Do nothing if already called.
 570         * psympriv.h (init_psymbol_list): Add comment.
 571         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
 572         init_psymbol_list.
 573         * dbxread.c (dbx_symfile_read): Unconditionally call
 574         init_psymbol_list.
 575
 576 2019-01-10  Tom Tromey  <tom@tromey.com>
 577
 578         * xcoffread.c (scan_xcoff_symtab): Update.
 579         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
 580         "where".
 581         * mdebugread.c (parse_partial_symbols)
 582         (handle_psymbol_enumerators): Update.
 583         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
 584         * dbxread.c (read_dbx_symtab): Update.
 585         * psympriv.h (psymbol_placement): New enum.
 586         (add_psymbol_to_list): Update.
 587
 588 2019-01-10  Tom Tromey  <tom@tromey.com>
 589
 590         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
 591         static_psymbols parameters.
 592         (scan_xcoff_symtab): Update.
 593         * psymtab.c (start_psymtab_common): Remove global_psymbols and
 594         static_psymbols parameters.
 595         * psympriv.h (start_psymtab_common): Update.
 596         * mdebugread.c (parse_partial_symbols): Update.
 597         * dwarf2read.c (create_partial_symtab): Update.
 598         * dbxread.c (read_dbx_symtab): Update.
 599         (start_psymtab): Remove global_psymbols and static_psymbols
 600         parameters.
 601
 602 2019-01-10  Tom Tromey  <tom@tromey.com>
 603
 604         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
 605         * psymtab.c (allocate_psymtab): Add comment.
 606         * psympriv.h (allocate_psymtab): Add comment.
 607         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
 608         initializations.
 609         * dbxread.c (dbx_end_psymtab): Remove some initializations.
 610
 611 2019-01-10  Tom Tromey  <tom@tromey.com>
 612
 613         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 614         Don't declare.
 615         * mipsread.c: Include mdebugread.h.
 616         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 617         Declare.
 618         * elfread.c: Include mdebugread.h.
 619
 620 2019-01-09  Tom Tromey  <tom@tromey.com>
 621
 622         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
 623         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
 624         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
 625         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 626         (psym_lookup_symbol, psym_find_last_source_symtab)
 627         (psym_forget_cached_source_info, psym_print_stats)
 628         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 629         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 630         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 631         (psym_find_compunit_symtab_by_address)
 632         (maintenance_print_psymbols, maintenance_info_psymtabs)
 633         (maintenance_check_psymtabs): Use ranged for.
 634         * psymtab.h (class objfile_psymtabs): New.
 635         (require_partial_symbols): Return objfile_psymtabs.
 636         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
 637
 638 2019-01-09  Tom Tromey  <tom@tromey.com>
 639
 640         * symfile.c (overlay_invalidate_all, find_pc_overlay)
 641         (find_pc_mapped_section, list_overlays_command)
 642         (map_overlay_command, unmap_overlay_command)
 643         (simple_overlay_update): Use all_objfiles.
 644         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
 645         * printcmd.c (info_symbol_command): Use all_objfiles.
 646         * objfiles.h (ALL_OBJSECTIONS): Remove.
 647         * maint.c (maintenance_translate_address): Use all_objfiles.
 648         * gcore.c (gcore_create_callback): Use all_objfiles.
 649         (objfile_find_memory_regions): Likewise.
 650
 651 2019-01-09  Tom Tromey  <tom@tromey.com>
 652
 653         * symtab.c (find_line_symtab, info_sources_command)
 654         (make_source_files_completion_list): Use objfile_compunits.
 655         * source.c (select_source_symtab): Use objfile_compunits.
 656         * objfiles.h (struct objfile): Update comment.
 657         (ALL_OBJFILES): Remove.
 658         (ALL_FILETABS): Remove.
 659         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
 660         objfile_compunits.
 661
 662 2019-01-09  Tom Tromey  <tom@tromey.com>
 663
 664         * symmisc.c (print_objfile_statistics, dump_objfile)
 665         (maintenance_print_symbols): Use compunit_filetabs.
 666         * source.c (forget_cached_source_info_for_objfile): Use
 667         compunit_filetabs.
 668         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
 669         (ALL_FILETABS): Use compunit_filetabs.
 670         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
 671         * coffread.c (coff_symtab_read): Use compunit_filetabs.
 672
 673 2019-01-09  Tom Tromey  <tom@tromey.com>
 674
 675         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
 676         (compunit_filetabs): New.
 677         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
 678         compunit_filetabs.
 679         (info_sources_command, make_source_files_completion_list): Remove
 680         declaration.
 681         * symmisc.c (print_objfile_statistics, dump_objfile)
 682         (maintenance_print_symbols): Remove declaration.
 683         (maintenance_info_symtabs): Use compunit_filetabs.
 684         (maintenance_info_line_tables): Likewise.
 685         * source.c (select_source_symtab): Change local variable name.
 686         (forget_cached_source_info_for_objfile): Remove declaration.
 687         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
 688         * objfiles.c (objfile_relocate1): Remove declaration.
 689         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 690         declaration.
 691         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
 692         * coffread.c (coff_symtab_read): Remove declaration.
 693         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 694         compunit_filetabs.
 695
 696 2019-01-09  Tom Tromey  <tom@tromey.com>
 697
 698         * symtab.c (lookup_objfile_from_block)
 699         (find_pc_sect_compunit_symtab, search_symbols)
 700         (default_collect_symbol_completion_matches_break_on): Use
 701         objfile_compunits.
 702         * objfiles.h (ALL_COMPUNITS): Remove.
 703         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
 704         * cp-support.c (add_symbol_overload_list_qualified): Use
 705         objfile_compunits.
 706         * ada-lang.c (ada_collect_symbol_completion_matches)
 707         (ada_add_global_exceptions): Use objfile_compunits.
 708
 709 2019-01-09  Tom Tromey  <tom@tromey.com>
 710
 711         * source.c (select_source_symtab)
 712         (forget_cached_source_info_for_objfile): Remove declaration.
 713         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 714         declaration.
 715         * maint.c (count_symtabs_and_blocks): Remove declaration.
 716         * cp-support.c (add_symbol_overload_list_qualified): Remove
 717         declaration.
 718         * coffread.c (coff_symtab_read): Remove declaration.
 719         * symtab.c (lookup_symbol_in_objfile_symtabs)
 720         (basic_lookup_transparent_type_1): Use objfile_compunits.
 721         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
 722         (info_sources_command, search_symbols)
 723         (default_collect_symbol_completion_matches_break_on)
 724         (make_source_files_completion_list): Remove declaration.
 725         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
 726         (ada_collect_symbol_completion_matches)
 727         (ada_add_global_exceptions): Remove declaration.
 728         * linespec.c (iterate_over_all_matching_symtabs): Use
 729         objfile_compunits.
 730         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
 731         (class objfile_compunits): New.
 732         (ALL_COMPUNITS): Use objfile_compunits.
 733         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
 734         (maintenance_check_symtabs, maintenance_info_line_tables): Use
 735         objfile_compunits.
 736         * objfiles.c (objfile_relocate1): Use objfile_compunits.
 737
 738 2019-01-09  Tom Tromey  <tom@tromey.com>
 739
 740         * symtab.c (search_symbols)
 741         (default_collect_symbol_completion_matches_break_on): Use
 742         objfile_msymbols.
 743         * ada-lang.c (ada_lookup_simple_minsym)
 744         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
 745         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
 746         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
 747         objfile_msymbols.
 748         * coffread.c (coff_symfile_read): Use objfile_msymbols.
 749         * symmisc.c (dump_msymbols): Use objfile_msymbols.
 750         * objc-lang.c (find_methods): Use objfile_msymbols.
 751         (info_selectors_command, info_classes_command): Likewise.
 752         * stabsread.c (scan_file_globals): Use objfile_msymbols.
 753         * objfiles.h (class objfile_msymbols): New.
 754         (ALL_OBJFILE_MSYMBOLS): Remove.
 755         (ALL_MSYMBOLS): Remove.
 756
 757 2019-01-09  Tom Tromey  <tom@tromey.com>
 758
 759         * common/next-iterator.h (next_adapter): Add Iterator template
 760         parameter.
 761         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
 762         (class all_objfiles_safe): New.
 763         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
 764         * objfiles.c (put_objfile_before): Update comment.
 765         (add_separate_debug_objfile): Likewise.
 766         (free_all_objfiles): Use all_objfiles_safe.
 767         (objfile_purge_solibs): Likewise.
 768
 769 2019-01-09  Tom Tromey  <tom@tromey.com>
 770
 771         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 772         (expand_symtab_containing_pc, lookup_static_symbol)
 773         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
 774         (find_symbol_at_address, find_line_symtab, find_main_name): Use
 775         all_objfiles.
 776         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
 777         * breakpoint.c (create_overlay_event_breakpoint)
 778         (create_longjmp_master_breakpoint)
 779         (create_std_terminate_master_breakpoint)
 780         (create_exception_master_breakpoint): Use all_objfiles.
 781         * linux-thread-db.c (try_thread_db_load_from_pdir)
 782         (has_libpthread): Use all_objfiles.
 783         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
 784         * linespec.c (iterate_over_all_matching_symtabs)
 785         (search_minsyms_for_name): Use all_objfiles.
 786         * maint.c (maintenance_info_sections): Use all_objfiles.
 787         * main.c (captured_main_1): Use all_objfiles.
 788         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
 789         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
 790         * guile/scm-pretty-print.c
 791         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
 792         * solib-spu.c (append_ocl_sos): Use all_objfiles.
 793         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
 794         (maintenance_print_msymbols): Use all_objfiles.
 795         * source.c (select_source_symtab): Use all_objfiles.
 796         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
 797         * symfile.c (remove_symbol_file_command)
 798         (expand_symtabs_matching, map_symbol_filenames): Use
 799         all_objfiles.
 800         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
 801         all_objfiles.
 802         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
 803         * objc-lang.c (find_methods): Use all_objfiles.
 804         * objfiles.c (have_partial_symbols, have_full_symbols)
 805         (have_minimal_symbols, qsort_cmp)
 806         (default_iterate_over_objfiles_in_search_order): Use
 807         all_objfiles.
 808         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
 809         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
 810         (maintenance_check_psymtabs): Use all_objfiles.
 811         (ALL_PSYMTABS): Remove.
 812         * compile/compile-object-run.c (do_module_cleanup): Use
 813         all_objfiles.
 814         * blockframe.c (find_pc_partial_function): Use all_objfiles.
 815         * cp-support.c (add_symbol_overload_list_qualified): Use
 816         all_objfiles.
 817         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 818         Use all_objfiles.
 819         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
 820         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
 821         all_objfiles.
 822         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 823         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
 824         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 825         Uses all_objfiles.
 826         * solib.c (solib_read_symbols): Use all_objfiles
 827
 828 2019-01-09  Tom Tromey  <tom@tromey.com>
 829
 830         * probe.c (parse_probes_in_pspace): Use all_objfiles.
 831         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
 832         all_objfiles.
 833         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
 834         * symmisc.c (print_symbol_bcache_statistics)
 835         (print_objfile_statistics, maintenance_print_objfiles)
 836         (maintenance_info_symtabs, maintenance_check_symtabs)
 837         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
 838         all_objfiles.
 839         * source.c (forget_cached_source_info): Use all_objfiles.
 840         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
 841         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 842         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
 843         * objfiles.c (update_section_map): Use all_objfiles.
 844         (shared_objfile_contains_address_p): Likewise.
 845         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
 846         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
 847
 848 2019-01-09  Tom Tromey  <tom@tromey.com>
 849
 850         * common/next-iterator.h: New file.
 851         * objfiles.h (class all_objfiles): New.
 852         (struct objfile_iterator): New.
 853
 854 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 855
 856         * NEWS: Move the description of the changed "frame", "select-frame",
 857          and "info frame" commands to the Changed commands section.
 858
 859 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
 860
 861         * gdbtypes.c (check_stub_method_group): Remove handling of old
 862         mangling schemes.
 863         * linespec.c (find_methods): Likewise.
 864         * stabsread.c (read_member_functions): Likewise.
 865         * valops.c (search_struct_method): Likewise.
 866         (value_struct_elt_for_reference): Likewise.
 867         * NEWS: Mention this change.
 868
 869 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 870
 871         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
 872         print_source_lines.
 873         * source.c (print_source_lines_base): Update line number check.
 874         (print_source_lines): New function.
 875         (source_lines_range::source_lines_range): New function.
 876         * source.h (class source_lines_range): New class.
 877         (print_source_lines): New declaration.
 878
 879 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 880
 881         * linespec.c (linespec_state_destructor): Free self->canonical_names.
 882
 883 2019-01-08  Tom Tromey  <tom@tromey.com>
 884             Simon Marchi  <simon.marchi@ericsson.com>
 885
 886         PR gdb/24060
 887         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
 888         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
 889         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 890         * f-exp.y (DOLLAR_VARIABLE): Likewise.
 891         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
 892         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 893
 894 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 895
 896         * source.c (select_source_symtab): Move header comment to
 897         declaration in source.h.
 898         (forget_cached_source_info_for_objfile): Likewise.
 899         (forget_cached_source_info): Likewise.
 900         (identify_source_line): Likewise.
 901         * source.h (identify_source_line): Move declaration from symtab.h
 902         and add comment from source.c
 903         (print_source_lines): Likewise.
 904         (forget_cached_source_info_for_objfile): Likewise.
 905         (forget_cached_source_info): Likewise.
 906         (select_source_symtab): Likewise.
 907         (enum print_source_lines_flag): Move definition from symtab.h.
 908         * symtab.h (identify_source_line): Move declaration to source.h.
 909         (print_source_lines): Likewise.
 910         (forget_cached_source_info_for_objfile): Likewise.
 911         (forget_cached_source_info): Likewise.
 912         (select_source_symtab): Likewise.
 913         (enum print_source_lines_flag): Move definition to source.h.
 914         * tui/tui-hooks.c: Add 'source.h' include.
 915
 916 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 917
 918         * source.c (print_source_lines_base): Handle requests to print
 919         reverse line number sequences, and guard against empty lines
 920         string.
 921
 922 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 923
 924         * source.c (print_source_lines_base): Fix skip of '\r' if next
 925         character is '\n'.
 926
 927 2019-01-06  Tom Tromey  <tom@tromey.com>
 928
 929         * c-exp.y (struct c_parse_state) <macro_original_text,
 930         expansion_obstack>: New member.
 931         (macro_original_text, expansion_obstack): Remove globals.
 932         (scan_macro_expansion, scanning_macro_expansion)
 933         (finished_macro_expansion): Update.
 934         (scan_macro_cleanup): Remove.
 935         (yylex, c_parse): Update.
 936
 937 2019-01-06  Tom Tromey  <tom@tromey.com>
 938
 939         * c-exp.y (struct c_parse_state) <strings>: New member.
 940         (operator_stoken): Update.
 941
 942 2019-01-06  Tom Tromey  <tom@tromey.com>
 943
 944         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
 945         (union type_stack_elt) <typelist_val>: Now a pointer to
 946         std::vector.
 947         (type_stack_cleanup): Don't declare.
 948         (push_typelist): Update.
 949         * parse.c (pop_typelist): Return a std::vector.
 950         (push_typelist): Take a std::vector.
 951         (follow_types): Update.  Do not free args.
 952         (type_stack_cleanup): Remove.
 953         * c-exp.y (struct c_parse_state): New.
 954         (cpstate): New global.
 955         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
 956         (nonempty_typelist): Update.
 957         (func_mod): Create a new vector.
 958         (c_parse): Create a c_parse_state.
 959         (check_parameter_typelist): Do not delete params.
 960         (function_method): Update.  Do not delete type_list.
 961
 962 2019-01-06  Tom Tromey  <tom@tromey.com>
 963
 964         PR gdb/28155:
 965         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
 966         check_typedef.
 967         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
 968         (print_return_value): Likewise.
 969
 970 2019-01-05  Tom Tromey  <tom@tromey.com>
 971
 972         * contrib/cleanup_check.py: Remove.
 973         * contrib/gcc-with-excheck: Remove.
 974         * contrib/exsummary.py: Remove.
 975         * contrib/excheck.py: Remove.
 976
 977 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
 978
 979         * thread.c (delete_thread_1): Add gdb_assert that THR is not
 980         NULL. Initialize tpprev to NULL instead of assigning it
 981         to NULL on the next statement.
 982         * windows-nat.c (windows_delete_thread): Remove check for
 983         main_thread_id before printing thread exit notifications.
 984         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
 985         Remove thread ID check against main_thread_id.
 986         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
 987         windows_delete_thread.
 988         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
 989
 990 2019-01-04  Tom Tromey  <tom@tromey.com>
 991
 992         * compile/compile.c (_initialize_compile): Use upper case for
 993         metasyntactic variables.
 994         * symmisc.c (_initialize_symmisc): Use upper case for
 995         metasyntactic variables.
 996         * psymtab.c (_initialize_psymtab): Use upper case for
 997         metasyntactic variables.
 998         * demangle.c (demangle_command): Use upper case for metasyntactic
 999         variables.
1000         (_initialize_demangler): Likewise.
1001         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1002         variables.
1003
1004 2019-01-03  Tom Tromey  <tom@tromey.com>
1005
1006         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1007
1008 2019-01-03  Tom Tromey  <tom@tromey.com>
1009
1010         * python/py-symtab.c (salpy_str): Update.
1011         (struct salpy_sal_object) <symtab>: Now a PyObject.
1012         (salpy_dealloc): Update.
1013         (del_objfile_sal): Use gdbpy_ref.
1014
1015 2019-01-03  Tom Tromey  <tom@tromey.com>
1016
1017         * python/py-type.c (convert_field): Use new_reference.  Return
1018         gdbpy_ref.
1019         (make_fielditem): Return gdbpy_ref.
1020         (typy_fields): Update.
1021         (typy_getitem): Update.
1022         (field_name): Return gdbpy_ref.  Use new_reference.
1023         (typy_iterator_iternext): Update.
1024
1025 2019-01-03  Tom Tromey  <tom@tromey.com>
1026
1027         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1028
1029 2019-01-03  Tom Tromey  <tom@tromey.com>
1030
1031         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1032         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1033         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1034         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1035         (pspy_set_type_printers): Likewise.
1036         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1037         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1038         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1039         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1040         (objfpy_set_type_printers): Likewise.
1041
1042 2019-01-03  Tom Tromey  <tom@tromey.com>
1043
1044         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1045         (gdbpy_print_stack): Use gdbpy_err_fetch.
1046         * python/python-internal.h (class gdbpy_err_fetch): New class.
1047         (class gdbpy_enter) <m_error_type, m_error_value,
1048         m_error_traceback>: Remove.
1049         <m_error>: New member.
1050         (gdbpy_exception_to_string): Don't declare.
1051         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1052         * python/py-value.c (convert_value_from_python): Use
1053         gdbpy_err_fetch.
1054         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1055         gdbpy_exception_to_string.
1056         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1057         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1058         gdbpy_err_fetch.
1059
1060 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1061
1062         * linux-nat.c (delete_lwp_cleanup): Delete.
1063         (struct lwp_deleter): New struct.
1064         (lwp_info_up): New typedef.
1065         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1066         lwp_info_up.
1067
1068 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1069
1070         * linux-fork.c (class scoped_switch_fork_info): New class.
1071         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1072
1073 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1074
1075         * valops.c (find_overload_match): Remove use of null_cleanup, and
1076         calls to do_cleanups.
1077
1078 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1079
1080         * compile/compile-cplus-types.c
1081         (compile_cplus_instance::decl_name): Handle changes to
1082         cp_func_name.
1083         * cp-support.c (cp_func_name): Update header comment, update
1084         return type.
1085         * cp-support.h (cp_func_name): Update return type in declaration.
1086         * valops.c (find_overload_match): Move temp_func local to top
1087         level of function and change its type.  Use temp_func to hold and
1088         delete temporary string obtained from cp_func_name.
1089
1090 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1091
1092         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1093         gdb::char_vector, remove cleanup, and update uses of `msg`.
1094
1095 2019-01-03  Jim Wilson  <jimw@sifive.com>
1096
1097         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1098
1099 2019-01-02  Tom Tromey  <tom@tromey.com>
1100
1101         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1102         (tdesc_parse_xml): Remove cleanups.
1103         * target-descriptions.h (make_cleanup_free_target_description):
1104         Don't declare.
1105         (target_desc_deleter): New struct.
1106         (target_desc_up): New typedef.
1107         * target-descriptions.c (target_desc_deleter::operator()): Rename
1108         from free_target_description.
1109         (make_cleanup_free_target_description): Remove.
1110
1111 2019-01-02  Tom Tromey  <tom@tromey.com>
1112
1113         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1114         constructor, destructor.
1115         (linespec_parser): Remove typedef.
1116         (~linespec_parser): Rename from linespec_parser_delete.
1117         (linespec_lex_to_end, linespec_complete_label)
1118         (linespec_complete): Update.
1119         (decode_line_full): Remove cleanups.
1120         (decode_line_1): Update.
1121
1122 2019-01-02  Tom Tromey  <tom@tromey.com>
1123
1124         * python/python-internal.h (inferior_to_inferior_object): Change
1125         return type.
1126         * python/py-exitedevent.c (create_exited_event_object): Update.
1127         * python/py-inferior.c (inferior_to_inferior_object): Return
1128         gdbpy_ref.
1129         (python_new_inferior, python_inferior_deleted)
1130         (thread_to_thread_object, delete_thread_object)
1131         (build_inferior_list, gdbpy_selected_inferior): Update.
1132         * python/py-infthread.c (create_thread_object): Update.  Also fail
1133         if inferior_to_inferior_object fails.
1134
1135 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1136
1137         * inferior.h (class inferior) <displaced_step_state>: New field.
1138         * infrun.h (struct displaced_step_state): Move here from
1139         infrun.c.  Initialize fields, add constructor.
1140         <inf>: Remove field.
1141         <reset>: New method.
1142         * infrun.c (struct displaced_step_inferior_state): Move to
1143         infrun.h.
1144         (displaced_step_inferior_states): Remove.
1145         (get_displaced_stepping_state): Adust.
1146         (displaced_step_in_progress_any_inferior): Adjust.
1147         (displaced_step_in_progress_thread): Adjust.
1148         (displaced_step_in_progress): Adjust.
1149         (add_displaced_stepping_state): Remove.
1150         (get_displaced_step_closure_by_addr): Adjust.
1151         (remove_displaced_stepping_state): Remove.
1152         (infrun_inferior_exit): Call displaced_step_state.reset.
1153         (use_displaced_stepping): Don't check for NULL.
1154         (displaced_step_prepare_throw): Call
1155         get_displaced_stepping_state.
1156         (displaced_step_fixup): Don't check for NULL.
1157         (prepare_for_detach): Don't check for NULL.
1158
1159 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1160
1161         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
1162          in case of call that did not complete.
1163
1164 2019-01-02  Andrey Utkin  <autkin@undo.io>
1165
1166         * symfile.c (find_separate_debug_file): Fix search of debug files for
1167         remote debuggee.
1168
1169 2019-01-02  Tom Tromey  <tom@tromey.com>
1170
1171         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
1172         indentation.
1173         * python/py-frame.c (frapy_older): Remove cast.
1174         (frapy_newer): Likewise.
1175         * python/py-breakpoint.c (local_setattro): Remove cast.
1176         * python/py-arch.c (archpy_name): Remove local variable.
1177         * python/py-type.c (gdbpy_lookup_type): Remove cast.
1178
1179 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
1180
1181         * unittests/basic_string_view/element_access/char/empty.cc:
1182         Fix year range in copyright header.
1183
1184 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1185
1186         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
1187         Delete.
1188         <operator==>: Update with for removed field.
1189         <hash>: Likewise.
1190         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
1191         <isa_features>: ...this.
1192         <abi_features>: New field.
1193         (riscv_isa_flen): Update comment.
1194         (riscv_abi_xlen): New declaration.
1195         (riscv_abi_flen): New declaration.
1196         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
1197         isa_features.
1198         (riscv_abi_xlen): New function.
1199         (riscv_isa_flen): Update to get answer from isa_features.
1200         (riscv_abi_flen): New function.
1201         (riscv_has_fp_abi): Update to get answer from abi_features.
1202         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
1203         xlen and flen.
1204         (riscv_call_info) <xlen, flen>: Update comment.
1205         (riscv_call_arg_struct): Remove invalid assertions
1206         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
1207         is removed.
1208         (riscv_gdbarch_init): Gather isa features and abi features
1209         separately, ensure both match on the gdbarch when reusing an old
1210         gdbarch.  Relax an error check to allow 32-bit abi float to run on
1211         a target with 64-bit float hardware.
1212
1213 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1214
1215         * source.c (search_command_helper): Stop reverse search
1216         when line 1 has been searched.
1217
1218 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1219
1220         * record-full.c (record_full_base_target::close): Rewrite
1221         record_full_core_buf_list free logic.
1222
1223 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1224
1225         * break-catch-syscall.c (print_one_catch_syscall): xfree
1226         the last text.
1227
1228 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1229
1230         * top.c (print_gdb_version): Update Copyright year in version
1231         message.
1232
1233 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1234
1235         Update copyright year range in all GDB files.
1236
1237 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
1238
1239         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
1240
1241 For older changes see ChangeLog-2018.
1242 \f
1243 Local Variables:
1244 mode: change-log
1245 left-margin: 8
1246 fill-column: 74
1247 version-control: never
1248 coding: utf-8
1249 End:
1250