gdb/ChangeLog

   1 2019-03-23  Tom Tromey  <tom@tromey.com>
   2
   3         * varobj.c (varobj_create): Update.
   4         * symfile.c (clear_symtab_users): Don't reset innermost_block.
   5         * printcmd.c (display_command, do_one_display): Don't reset
   6         innermost_block.
   7         * parser-defs.h (enum innermost_block_tracker_type): Move to
   8         expression.h.
   9         (innermost_block): Update comment.
  10         * parse.c (parse_exp_1): Add tracker_types parameter.
  11         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
  12         tracker_types parameter.  Reset innermost_block.
  13         (parse_exp_in_context): Remove.
  14         (parse_expression_for_completion): Update.
  15         * objfiles.c (~objfile): Don't reset expression_context_block or
  16         innermost_block.
  17         * expression.h (enum innermost_block_tracker_type): Move from
  18         parser-defs.h.
  19         (parse_exp_1): Add tracker_types parameter.
  20         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
  21         reset innermost_block.
  22
  23 2019-03-23  Tom Tromey  <tom@tromey.com>
  24
  25         * objfiles.h: Include bcache.h.
  26
  27 2019-03-23  Tom Tromey  <tom@tromey.com>
  28
  29         * linespec.c (get_current_search_block): Use
  30         scoped_restore_current_language.
  31         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
  32
  33 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
  34             Jiong Wang  <jiong.wang@arm.com>
  35
  36         * aarch64-linux-tdep.c
  37         (aarch64_linux_iterate_over_regset_sections): Check for pauth
  38         section.
  39         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
  40
  41 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
  42             Jiong Wang  <jiong.wang@arm.com>
  43
  44         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
  45         instructions.
  46         (aarch64_analyze_prologue_test): Add PACIASP test.
  47         (aarch64_prologue_prev_register): Unmask PC value.
  48
  49 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
  50             Jiong Wang  <jiong.wang@arm.com>
  51
  52         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
  53         (aarch64_dwarf2_prev_register): Unmask PC value.
  54         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
  55         (aarch64_execute_dwarf_cfa_vendor_op): Check for
  56         DW_CFA_AARCH64_negate_ra_state.
  57         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
  58
  59 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
  60             Jiong Wang  <jiong.wang@arm.com>
  61
  62         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
  63         registers.
  64         (aarch64_pseudo_register_name): Likewise.
  65         (aarch64_pseudo_register_type): Likewise.
  66         (aarch64_pseudo_register_reggroup_p): Likewise.
  67         (aarch64_gdbarch_init): Add pauth registers.
  68         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
  69         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
  70         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
  71         (struct gdbarch_tdep): Add regnum for ra_state.
  72
  73 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
  74             Jiong Wang  <jiong.wang@arm.com>
  75
  76         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
  77
  78 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
  79             Jiong Wang  <jiong.wang@arm.com>
  80
  81         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
  82         function.
  83         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
  84         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
  85         (aarch64_gdbarch_init): Add puth registers.
  86         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
  87         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
  88         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
  89
  90 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
  91             Jiong Wang  <jiong.wang@arm.com>
  92
  93         * aarch64-linux-nat.c
  94         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
  95         * aarch64-linux-tdep.c
  96         (aarch64_linux_core_read_description): Likewise.
  97         (aarch64_linux_get_hwcap): New function.
  98         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
  99         (aarch64_linux_get_hwcap): New declaration.
 100
 101 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 102             Jiong Wang  <jiong.wang@arm.com>
 103
 104         * aarch64-linux-nat.c
 105         (aarch64_linux_nat_target::read_description): Add pauth param.
 106         * aarch64-linux-tdep.c
 107         (aarch64_linux_core_read_description): Likewise.
 108         * aarch64-tdep.c (struct target_desc): Add in pauth.
 109         (aarch64_read_description): Add pauth param.
 110         (aarch64_gdbarch_init): Likewise.
 111         * aarch64-tdep.h (aarch64_read_description): Likewise.
 112         * arch/aarch64.c (aarch64_create_target_description): Likewise.
 113         * arch/aarch64.h (aarch64_create_target_description): Likewise.
 114         * features/Makefile: Add new files.
 115         * features/aarch64-pauth.c: New file.
 116         * features/aarch64-pauth.xml: New file.
 117
 118 2019-03-20  Tom Tromey  <tromey@adacore.com>
 119
 120         * infrun.c (handle_inferior_event): Rename from
 121         handle_inferior_event_1.  Create a scoped_value_mark.
 122         (handle_inferior_event): Remove.
 123
 124 2019-03-19  Tom Tromey  <tromey@adacore.com>
 125
 126         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
 127         * infrun.h (print_stop_event): Add "displays" parameter.
 128         * infrun.c (print_stop_event): Add "displays" parameter.
 129
 130 2019-03-19  Pedro Alves  <palves@redhat.com>
 131
 132         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
 133         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
 134         to -1.  Fix TABs vs spaces.
 135         (tui_ui_out::tui_ui_out): Don't initialize fields here.
 136         * tui/tui-out.h (tui_ui_out) Add intro comments.
 137         <m_line, m_start_of_line>: In-class initialize, and add describing
 138         comment.
 139
 140 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
 141
 142         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
 143         variable names.
 144         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
 145
 146 2019-03-18  Pedro Alves  <palves@redhat.com>
 147             Eli Zaretskii <eliz@gnu.org>
 148
 149         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 150         m_line and m_start_of_line.
 151
 152 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 153
 154         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 155         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 156         it returns a newline.  This fixes a regression in TU mode, whereby
 157         the next line is output on the same screen line as the user input.
 158
 159 2019-03-18  Tom Tromey  <tromey@adacore.com>
 160
 161         * minsyms.c (minimal_symbol_reader::install): Remove call to
 162         obstack_blank.
 163
 164 2019-03-18  Pedro Alves  <palves@redhat.com>
 165
 166         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 167         New globals.
 168         (apply_style): New, factored out from ...
 169         (apply_ansi_escape): ... this.  Handle reverse video mode.
 170         (tui_set_reverse_mode): New function.
 171         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 172         * tui/tui-winsource.c (tui_show_source_line): Use
 173         tui_set_reverse_mode instead of setting A_STANDOUT.
 174         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 175         New setter methods.
 176
 177 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 178
 179         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 180         Handle tabs.
 181
 182 2019-03-18  Tom Tromey  <tromey@adacore.com>
 183
 184         * ada-lang.c (empty_array): Add "high" parameter.
 185         (ada_evaluate_subexp): Update.
 186
 187 2019-03-17  Sergei Trofimovich <siarheit@google.com>
 188
 189         * unittests/string_view-selftests.c: Define
 190         _initialize_string_view_selftests unconditionally.
 191
 192 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 193
 194         PR gdb/24350
 195         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
 196
 197 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 198
 199         PR gdb/24351
 200         * windows-nat.c (display_selector): Fix format specifiers.
 201
 202 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 203
 204         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 205         tui_refill_source_window instead of tui_refresh_win, to update the
 206         current execution line.  This fixes redisplay of the current line
 207         when stepping through the code with "next" or "step".
 208
 209 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 210
 211         * source-cache.c (source_cache::get_source_lines): Call
 212         find_source_lines to initialize s->nlines.  This fixes vertical
 213         scrolling of TUI source window when the DOWN arrow is pressed.
 214
 215 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 216
 217         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
 218         linux-thread-db.c (_initialize_thread_db): Likewise.
 219
 220 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 221
 222         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 223         wclrtoeol in tui_show_source_line".  This reverts changes made in
 224         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 225
 226 2019-03-15  Tom Tromey  <tom@tromey.com>
 227
 228         * symtab.h (struct minimal_symbol): Derive from
 229         general_symbol_info.
 230         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
 231         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
 232         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
 233         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
 234         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
 235         (MSYMBOL_SEARCH_NAME): Update.
 236         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
 237         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
 238         * minsyms.c (minimal_symbol_reader::record_full): Update.
 239
 240 2019-03-15  Tom Tromey  <tom@tromey.com>
 241
 242         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
 243
 244 2019-03-15  Tom Tromey  <tom@tromey.com>
 245
 246         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 247         unique_xmalloc_ptr.
 248         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 249         Update.
 250         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 251         (build_minimal_symbol_hash_tables)
 252         (minimal_symbol_reader::install): Update.
 253
 254 2019-03-15  Tom Tromey  <tom@tromey.com>
 255
 256         * symtab.c (create_demangled_names_hash): Update.
 257         (symbol_set_names): Update.
 258         * objfiles.h (struct objfile_per_bfd_storage)
 259         <demangled_names_hash>: Now an htab_up.
 260         * objfiles.c (objfile_per_bfd_storage): Simplify.
 261
 262 2019-03-15  Tom Tromey  <tom@tromey.com>
 263
 264         * objfiles.h (struct objfile_per_bfd_storage): Declare
 265         destructor.
 266         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 267         New.
 268         (get_objfile_bfd_data): Use new.  Don't initialize
 269         language_of_main.
 270         (free_objfile_per_bfd_storage): Remove.
 271         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 272
 273 2019-03-15  Tom Tromey  <tom@tromey.com>
 274
 275         * symfile.c (reread_symbols): Update.
 276         * objfiles.c (objfile::objfile): Update.
 277         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 278         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 279         comment.
 280         (minimal_symbol_reader::install): Update.
 281         (terminate_minimal_symbol_table): Remove.
 282         * jit.c (jit_object_close_impl): Update.
 283
 284 2019-03-15  Tom Tromey  <tom@tromey.com>
 285
 286         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 287         initializations.
 288
 289 2019-03-15  Tom Tromey  <tom@tromey.com>
 290
 291         * objfiles.h (struct objfile_per_bfd_storage)
 292         <demangled_hash_languages>: Now a bitset.
 293         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 294         (lookup_minimal_symbol): Update.
 295
 296 2019-03-15  Tom Tromey  <tom@tromey.com>
 297
 298         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 299         Don't return the symbol.
 300         * coffread.c (record_minimal_symbol): Use record_full.
 301
 302 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 303
 304         The MS-Windows port of ncurses fails to switch to a color pair if
 305         one or both of the colors are the implicit default colors.  This
 306         change records the default colors when TUI is initialized, and
 307         then specifies them explicitly when a color pair uses the default
 308         colors.  This allows color styling in TUI mode on MS-Windows.
 309
 310         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 311         ncurses_norm_attr.
 312         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 313         colors in ncurses_norm_attr.
 314         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 315         "none", replace it with the default color recorded in
 316         ncurses_norm_attr.
 317
 318 2019-03-14  Tom Tromey  <tromey@adacore.com>
 319
 320         * source-cache.h (class source_cache) <get_source_lines>: Return
 321         std::string.
 322         * source-cache.c (source_cache::extract_lines): Handle case where
 323         first_pos==npos.  Return std::string.
 324         (source_cache::get_source_lines): Update.
 325
 326 2019-03-14  Tom Tromey  <tromey@adacore.com>
 327
 328         * NEWS: Add item for "style sources" commands.
 329         * source-cache.c (source_cache::get_source_lines): Check
 330         source_styling.
 331         * cli/cli-style.c (source_styling): New global.
 332         (_initialize_cli_style): Add "style sources" commands.
 333         (show_style_sources): New function.
 334         * cli/cli-style.h (source_styling): Declare.
 335
 336 2019-03-14  Pedro Alves  <palves@redhat.com>
 337             Tom Tromey  <tromey@adacore.com>
 338
 339         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 340         * tui/tui-winsource.c (tui_refill_source_window): New function,
 341         from...
 342         (tui_horizontal_source_scroll): ... here.  Move some logic.
 343         * cli/cli-style.c (set_style_enabled): Notify new observable.
 344         * tui/tui-hooks.c (tui_redisplay_source): New function.
 345         (tui_attach_detach_observers): Attach or detach
 346         tui_redisplay_source.
 347         * observable.h (source_styling_changed): New observable.
 348         * observable.c: Define source_styling_changed observable.
 349
 350 2019-03-13  Tom Tromey  <tromey@adacore.com>
 351
 352         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 353         (i386_gnu_nat_target::store_registers): Update.
 354         * target-debug.h (target_debug_print_std_string): New macro.
 355         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 356         * windows-tdep.c (display_one_tib): Update.
 357         * tui/tui-stack.c (tui_make_status_line): Update.
 358         * top.c (print_inferior_quit_action): Update.
 359         * thread.c (thr_try_catch_cmd): Update.
 360         (add_thread_with_info): Update.
 361         (thread_target_id_str): Update.
 362         (thr_try_catch_cmd): Update.
 363         (thread_command): Update.
 364         (thread_find_command): Update.
 365         * record-btrace.c (record_btrace_target::info_record)
 366         (record_btrace_resume_thread, record_btrace_target::resume)
 367         (record_btrace_cancel_resume, record_btrace_step_thread)
 368         (record_btrace_target::wait, record_btrace_target::wait)
 369         (record_btrace_target::wait, record_btrace_target::stop): Update.
 370         * progspace.c (print_program_space): Update.
 371         * process-stratum-target.c
 372         (process_stratum_target::thread_address_space): Update.
 373         * linux-fork.c (linux_fork_mourn_inferior)
 374         (detach_checkpoint_command, info_checkpoints_command)
 375         (linux_fork_context): Update.
 376         (linux_fork_detach): Update.
 377         (class scoped_switch_fork_info): Update.
 378         (delete_checkpoint_command): Update.
 379         * infrun.c (follow_fork_inferior): Update.
 380         (follow_fork_inferior): Update.
 381         (proceed_after_vfork_done): Update.
 382         (handle_vfork_child_exec_or_exit): Update.
 383         (follow_exec): Update.
 384         (displaced_step_prepare_throw): Update.
 385         (displaced_step_restore): Update.
 386         (start_step_over): Update.
 387         (resume_1): Update.
 388         (clear_proceed_status_thread): Update.
 389         (proceed): Update.
 390         (print_target_wait_results): Update.
 391         (do_target_wait): Update.
 392         (context_switch): Update.
 393         (stop_all_threads): Update.
 394         (restart_threads): Update.
 395         (finish_step_over): Update.
 396         (handle_signal_stop): Update.
 397         (switch_back_to_stepped_thread): Update.
 398         (keep_going_pass_signal): Update.
 399         (print_exited_reason): Update.
 400         (normal_stop): Update.
 401         * inferior.c (inferior_pid_to_str): Change return type.
 402         (print_selected_inferior): Update.
 403         (add_inferior): Update.
 404         (detach_inferior): Update.
 405         * dummy-frame.c (fprint_dummy_frames): Update.
 406         * dcache.c (dcache_info_1): Update.
 407         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 408         (btrace_fetch, btrace_clear): Update.
 409         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 410         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 411         type.
 412         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 413         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 414         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 415         * gdbarch.c, gdbarch.h: Rebuild.
 416         * gdbarch.sh (core_pid_to_str): Change return type.
 417         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 418         return type.
 419         (windows_nat_target::pid_to_str): Change return type.
 420         (windows_delete_thread): Update.
 421         (windows_nat_target::attach): Update.
 422         (windows_nat_target::files_info): Update.
 423         * target-delegates.c: Rebuild.
 424         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 425         return type.
 426         (sol_thread_target::pid_to_str): Change return type.
 427         * remote.c (class remote_target) <pid_to_str>: Change return
 428         type.
 429         (remote_target::pid_to_str): Change return type.
 430         (extended_remote_target::attach, remote_target::remote_stop_ns)
 431         (remote_target::remote_notif_remove_queued_reply)
 432         (remote_target::push_stop_reply, remote_target::disable_btrace):
 433         Update.
 434         (extended_remote_target::attach): Update.
 435         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 436         type.
 437         (gdbsim_target::pid_to_str): Change return type.
 438         * ravenscar-thread.c (struct ravenscar_thread_target)
 439         <pid_to_str>: Change return type.
 440         (ravenscar_thread_target::pid_to_str): Change return type.
 441         * procfs.c (class procfs_target) <pid_to_str>: Change return
 442         type.
 443         (procfs_target::pid_to_str): Change return type.
 444         (procfs_target::attach): Update.
 445         (procfs_target::detach): Update.
 446         (procfs_target::fetch_registers): Update.
 447         (procfs_target::store_registers): Update.
 448         (procfs_target::wait): Update.
 449         (procfs_target::files_info): Update.
 450         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 451         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 452         return type.
 453         (nto_procfs_target::pid_to_str): Change return type.
 454         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 455         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 456         return type.
 457         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 458         (exit_lwp): Update.
 459         (attach_proc_task_lwp_callback, get_detach_signal)
 460         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 461         (linux_nat_target::resume, wait_lwp, stop_callback)
 462         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 463         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 464         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 465         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 466         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 467         type.
 468         (inf_ptrace_target::attach): Update.
 469         (inf_ptrace_target::files_info): Update.
 470         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 471         type.
 472         (go32_nat_target::pid_to_str): Change return type.
 473         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 474         (gnu_nat_target::wait): Update.
 475         (gnu_nat_target::wait): Update.
 476         (gnu_nat_target::resume): Update.
 477         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 478         (fbsd_nat_target::wait): Update.
 479         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 480         type.
 481         (darwin_nat_target::attach): Update.
 482         * corelow.c (class core_target) <pid_to_str>: Change return type.
 483         (core_target::pid_to_str): Change return type.
 484         * target.c (normal_pid_to_str): Change return type.
 485         (default_pid_to_str): Likewise.
 486         (target_pid_to_str): Change return type.
 487         (target_translate_tls_address): Update.
 488         (target_announce_detach): Update.
 489         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 490         return type.
 491         (bsd_uthread_target::pid_to_str): Change return type.
 492         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 493         type.
 494         (bsd_kvm_target::pid_to_str): Change return type.
 495         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 496         return type.
 497         (aix_thread_target::pid_to_str): Change return type.
 498         * target.h (struct target_ops) <pid_to_str>: Change return type.
 499         (target_pid_to_str, normal_pid_to_str): Likewise.
 500         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 501         type.
 502         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 503         type.
 504         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 505         return type.
 506         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 507         type.
 508         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 509         type.
 510         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 511         return type.
 512
 513 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 514
 515         * NEWS: Mention that the new default MI version is 3.  Mention
 516         changes to the output of commands and events that deal with
 517         multi-location breakpoints.
 518         * breakpoint.c: Include "mi/mi-out.h".
 519         (print_one_breakpoint): Change output syntax if using MI version
 520         >= 3.
 521         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 522         New.
 523         (mi_multi_location_breakpoint_output_fixed): New.
 524         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 525         (mi_cmd_fix_multi_location_breakpoint_output): New.
 526         (mi_multi_location_breakpoint_output_fixed): New.
 527         * mi/mi-cmds.c (mi_cmds): Register command
 528         -fix-multi-location-breakpoint-output.
 529         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 530         interpreter "mi".
 531
 532 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 533
 534         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 535         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 536         instantiate mi_ui_out based on interpreter name.
 537         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 538         * mi/mi-main.c (mi_load_progress): Likewise.
 539
 540 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 541
 542         * NEWS: Combine separate "New targets" sections for 8.3.
 543
 544 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 545
 546         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 547         (ppcfbsd_init_abi): Install gdbarch
 548         "fetch_tls_load_module_address" and "get_thread_local_address"
 549         methods.
 550
 551 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 552
 553         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 554         (riscv_fbsd_init_abi): Install gdbarch
 555         "fetch_tls_load_module_address" and "get_thread_local_address"
 556         methods.
 557
 558 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 559
 560         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 561         (i386fbsd_init_abi): Install gdbarch
 562         "fetch_tls_load_module_address" and "get_thread_local_address"
 563         methods.
 564
 565 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 566
 567         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 568         (amd64fbsd_init_abi): Install gdbarch
 569         "fetch_tls_load_module_address" and "get_thread_local_address"
 570         methods.
 571
 572 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 573
 574         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 575         (struct fbsd_pspace_data): New type.
 576         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 577         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 578         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 579         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 580         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 581
 582 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 583
 584         * gdbtypes.c (lookup_struct_elt): New function.
 585         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 586         * gdbtypes.h (struct struct_elt): New type.
 587         (lookup_struct_elt): New prototype.
 588
 589 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 590
 591         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 592         remove disabled code block.
 593
 594 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 595
 596         * gdbarch.sh (get_thread_local_address): New method.
 597         * gdbarch.h, gdbarch.c: Regenerate.
 598         * target.c (target_translate_tls_address): Use
 599         gdbarch_get_thread_local_address if present instead of
 600         target::get_thread_local_address.
 601
 602 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 603
 604         * target.h (target::get_thread_local_address): Update comment.
 605
 606 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 607
 608         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 609         objfile->separate_debug_objfile_backlink if not NULL.
 610
 611 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 612
 613         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 614         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 615         (amd64bsd_store_inferior_registers): Likewise.
 616         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 617         Enable segment base registers.
 618         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 619         PT_GETFSBASE and PT_GETGSBASE.
 620         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 621         PT_SETGSBASE.
 622         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 623         segment base registers.
 624         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 625
 626 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 627
 628         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 629         Update calls to i386_target_description to add 'segments'
 630         parameter.
 631         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 632         add segment base registers.
 633         * arch/i386.c (i386_create_target_description): Add 'segments'
 634         parameter to enable segment base registers.
 635         * arch/i386.h (i386_create_target_description): Likewise.
 636         * features/i386/32bit-segments.xml: New file.
 637         * features/i386/32bit-segments.c: Generate.
 638         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 639         call to i386_target_description to add 'segments' parameter.
 640         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 641         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 642         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 643         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 644         if feature is present.
 645         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 646         Add 'segments' parameter to call to i386_target_description.
 647         (i386_target_description): Add 'segments' parameter to enable
 648         segment base registers.
 649         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 650         to call to i386_target_description.
 651         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 652         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 653         Define I386_NUM_REGS.
 654         (i386_target_description): Add 'segments' parameter to enable
 655         segment base registers.
 656
 657 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 658
 659         PR/24325
 660         * source-cache.c: #undef open and close, to avoid unresolved
 661         externals during linking.
 662
 663 2019-03-12  Tom Tromey  <tromey@adacore.com>
 664
 665         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 666         const.  Add initializers.
 667         (_initialize_remote): Don't initialize ptid globals.
 668
 669 2019-03-12  Pedro Alves  <palves@redhat.com>
 670
 671         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 672
 673 2019-03-12  Pedro Alves  <palves@redhat.com>
 674
 675         * cp-name-parser.y (main): Remove unused 'len' variable.
 676
 677 2019-03-12  Tom Tromey  <tromey@adacore.com>
 678
 679         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 680         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 681
 682 2019-03-12  Tom Tromey  <tromey@adacore.com>
 683
 684         * linux-nat.c (iterate_over_lwps): Update.
 685         (stop_callback): Remove parameter.
 686         (stop_wait_callback, detach_callback, resume_set_callback)
 687         (select_singlestep_lwp_callback, set_ignore_sigint)
 688         (status_callback, resumed_callback, resume_clear_callback)
 689         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 690         data parameter.
 691         (linux_nat_target::detach, linux_nat_target::resume)
 692         (linux_stop_and_wait_all_lwps, select_event_lwp)
 693         (linux_nat_filter_event, linux_nat_wait_1)
 694         (linux_nat_target::kill, linux_nat_target::stop)
 695         (linux_nat_target::stop): Update.
 696         (linux_nat_resume_callback): Change type.
 697         (resume_stopped_resumed_lwps, count_events_callback)
 698         (select_event_lwp_callback): Likewise.
 699         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 700         * arm-linux-nat.c (struct update_registers_data): Remove.
 701         (update_registers_callback): Change type.
 702         (arm_linux_insert_hw_breakpoint1): Update.
 703         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 704         parameter.
 705         (x86_linux_dr_set_addr): Update.
 706         (x86_linux_dr_set_control): Update.
 707         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 708         (iterate_over_lwps): Use gdb::function_view.
 709         * nat/aarch64-linux-hw-point.c (struct
 710         aarch64_dr_update_callback_param): Remove.
 711         (debug_reg_change_callback): Change type.
 712         (aarch64_notify_debug_reg_change): Update.
 713         * s390-linux-nat.c (s390_refresh_per_info): Update.
 714
 715 2019-03-11  Tom Tromey  <tromey@adacore.com>
 716
 717         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 718         redundant assignment to "this_cu".
 719
 720 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 721
 722         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 723
 724 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 725
 726         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 727         from...
 728         (rank_one_type): ... this.
 729
 730 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 731
 732         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 733         from...
 734         (rank_one_type): ... this.
 735
 736 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 737
 738         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 739         from...
 740         (rank_one_type): ... this.
 741
 742 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 743
 744         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 745         from...
 746         (rank_one_type): ... this.
 747
 748 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 749
 750         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 751         from...
 752         (rank_one_type): ... this.
 753
 754 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 755
 756         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 757         from...
 758         (rank_one_type): ... this.
 759
 760 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 761
 762         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 763         from...
 764         (rank_one_type): ... this.
 765
 766 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 767
 768         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 769         from...
 770         (rank_one_type): ... this.
 771
 772 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 773
 774         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 775         from...
 776         (rank_one_type): ... this.
 777
 778 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 779
 780         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 781         from...
 782         (rank_one_type): ... this.
 783
 784 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 785
 786         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 787         from...
 788         (rank_one_type): ... this.
 789
 790 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 791
 792         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 793         from...
 794         (rank_one_type): ... this.
 795
 796 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 797
 798         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 799         inferior-events' shows the example events.
 800
 801 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 802
 803         Support styling on native MS-Windows console
 804
 805         PR/24315
 806         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 807         on MS-Windows if $TERM is not defined.
 808
 809         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 810
 811         * posix-hdep.c (gdb_console_fputs):
 812         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 813         functions.
 814         * ui-file.h (gdb_console_fputs): Add prototype.
 815
 816         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 817         back to fputs only if the former returns zero.
 818
 819 2019-03-07  Tom Tromey  <tom@tromey.com>
 820
 821         * symmisc.c (print_symbol_bcache_statistics): Update.
 822         (print_objfile_statistics): Update.
 823         * symfile.c (allocate_symtab): Update.
 824         * stabsread.c: Don't include bcache.h.
 825         * psymtab.h (struct psymbol_bcache): Don't declare.
 826         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 827         (psymbol_bcache_init, psymbol_bcache_free)
 828         (psymbol_bcache_get_bcache): Don't declare.
 829         * psymtab.c (struct psymbol_bcache): Remove.
 830         (psymtab_storage::psymtab_storage): Update.
 831         (psymtab_storage::~psymtab_storage): Update.
 832         (psymbol_bcache_init, psymbol_bcache_free)
 833         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
 834         (add_psymbol_to_bcache): Update.
 835         (allocate_psymtab): Update.
 836         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 837         macro_cache>: No longer pointers.
 838         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
 839         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
 840         * macrotab.c (macro_bcache): Update.
 841         * macroexp.c: Don't include bcache.h.
 842         * gdbtypes.c (check_types_worklist): Update.
 843         (types_deeply_equal): Remove TRY/CATCH.  Update.
 844         * elfread.c (elf_symtab_read): Update.
 845         * dwarf2read.c: Don't include bcache.h.
 846         * buildsym.c (buildsym_compunit::get_macro_table): Update.
 847         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
 848         (print_bcache_statistics, bcache_memory_used): Don't declare.
 849         (struct bcache): Move from bcache.c.  Add constructor, destructor,
 850         methods.  Rename all data members.
 851         * bcache.c (struct bcache): Move to bcache.h.
 852         (bcache::expand_hash_table): Rename from expand_hash_table.
 853         (bcache): Remove.
 854         (bcache::insert): Rename from bcache_full.
 855         (bcache::compare): Rename from bcache_compare.
 856         (bcache_xmalloc): Remove.
 857         (bcache::~bcache): Rename from bcache_xfree.
 858         (bcache::print_statistics): Rename from print_bcache_statistics.
 859         (bcache::memory_used): Rename from bcache_memory_used.
 860
 861 2019-03-07  Pedro Alves  <palves@redhat.com>
 862
 863         * infrun.c (normal_stop): Also check for
 864         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
 865
 866 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 867
 868         * f-lang.c (value_from_host_double): Moved to...
 869         * value.c (value_from_host_double): ...here.
 870         * value.h (value_from_host_double): Declare.
 871         * guile/scm-math.c (vlscm_convert_typed_number): Use
 872         value_from_host_double.
 873         (vlscm_convert_number): Likewise.
 874         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
 875         * python/py-value.c (convert_value_from_python): Likewise.
 876
 877 2019-03-06  Tom Tromey  <tom@tromey.com>
 878
 879         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
 880
 881 2019-03-06  Tom Tromey  <tom@tromey.com>
 882
 883         * utils.h (free_current_contents): Don't declare.
 884         * utils.c (free_current_contents): Remove.
 885
 886 2019-03-06  Tom Tromey  <tom@tromey.com>
 887
 888         * top.c (quit_force): Update.
 889         * main.c (captured_command_loop): Update.
 890         * common/new-op.c (operator new): Update.
 891         * common/common-exceptions.c (struct catcher)
 892         <save_cleanup_chain>: Remove member.
 893         (exceptions_state_mc_init): Update.
 894         (exception_try_scope_entry): Return nullptr.
 895         (exception_try_scope_exit, exception_rethrow)
 896         (throw_exception_sjlj, throw_exception_cxx): Update.
 897         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
 898         (all_cleanups, do_cleanups, discard_cleanups)
 899         (discard_final_cleanups, save_cleanups, save_final_cleanups)
 900         (restore_cleanups, restore_final_cleanups): Don't declare.
 901         (do_final_cleanups): Remove parameter.
 902         * common/cleanups.c (cleanup_chain, make_cleanup)
 903         (make_cleanup_dtor, all_cleanups, do_cleanups)
 904         (discard_my_cleanups, discard_cleanups)
 905         (discard_final_cleanups, save_my_cleanups, save_cleanups)
 906         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
 907         (null_cleanup): Remove.
 908         (do_final_cleanups): Remove parameter.
 909
 910 2019-03-06  Tom Tromey  <tom@tromey.com>
 911
 912         * remote.c (remote_target::remote_parse_stop_reply): Use
 913         unique_xmalloc_ptr.
 914
 915 2019-03-06  Tom Tromey  <tom@tromey.com>
 916
 917         * stabsread.c (struct stabs_field_info): Rename from field_info.
 918         <list, fnlist>: Add initializers.
 919         <obstack>: New member.
 920         (read_member_functions, read_struct_fields, read_baseclasses):
 921         Allocate on obstack.  Don't use cleanups.
 922         (read_one_struct_field, read_member_functions, read_struct_fields)
 923         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
 924         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
 925         (read_struct_type): Update.
 926
 927 2019-03-06  Tom Tromey  <tom@tromey.com>
 928
 929         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
 930         * common/filestuff.h (make_cleanup_close): Don't declare.
 931         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
 932         Remove.
 933
 934 2019-03-06  Tom Tromey  <tom@tromey.com>
 935
 936         * solib-aix.c: Use make_scope_exit.
 937
 938 2019-03-06  Tom Tromey  <tom@tromey.com>
 939
 940         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
 941         Use make_scope_exit.
 942
 943 2019-03-06  Tom Tromey  <tom@tromey.com>
 944
 945         * solib-svr4.c (disable_probes_interface): Remove parameter.
 946         (svr4_handle_solib_event): Use make_scope_exit.
 947
 948 2019-03-06  Tom Tromey  <tom@tromey.com>
 949
 950         * remote.c (struct stop_reply_deleter): Remove.
 951         (stop_reply_up): Update.
 952         (struct stop_reply): Derive from notif_event.  Don't typedef.
 953         <regcache>: Now a std::vector.
 954         (stop_reply_xfree): Remove.
 955         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
 956         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
 957         (remote_target::discard_pending_stop_replies): Use delete.
 958         (remote_target::remote_parse_stop_reply): Update.
 959         (remote_target::process_stop_reply): Update.
 960         * remote-notif.h (struct notif_event): Add virtual destructor.
 961         Remove "dtr" member.
 962         (struct notif_client) <alloc_event>: Return a unique_ptr.
 963         (notif_event_xfree): Don't declare.
 964         (notif_event_up): New typedef.
 965         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
 966         (notif_event_xfree, do_notif_event_xfree): Remove.
 967         (remote_notif_state_xfree): Update.
 968
 969 2019-03-06  Tom Tromey  <tom@tromey.com>
 970
 971         * infrun.c (displaced_step_clear_cleanup): Now a
 972         forward_scope_exit type.
 973         (displaced_step_prepare_throw): Update.
 974         (displaced_step_fixup): Update.
 975
 976 2019-03-06  Tom Tromey  <tom@tromey.com>
 977
 978         * inferior.h (class inferior): Update comment.
 979         * gdbthread.h (class thread_info): Update comment.
 980
 981 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
 982             Tom Tromey  <tom@tromey.com>
 983
 984         * stabsread.h (struct stab_section_list): Remove.
 985         (coffstab_build_psymtabs): Update.
 986         * dbxread.c (symbuf_sections): Now a std::vector.
 987         (sect_idx): New global.
 988         (fill_symbuf): Update.
 989         (coffstab_build_psymtabs): Change type of stabsects parameter.
 990         Update.
 991         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
 992         std::vector.
 993         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
 994         (coff_locate_sections): Update.
 995         (coff_symfile_read): Remove cleanups.  Update.
 996         (init_stringtab): Add storage parameter.
 997         (free_stringtab, free_stringtab_cleanup): Remove.
 998         (init_lineno): Add storage parameter.
 999         (free_linetab, free_linetab_cleanup): Remove.
1000
1001 2019-03-06  Pedro Alves  <palves@redhat.com>
1002
1003         * linux-fork.c (fork_info::clobber_regs): Delete.
1004         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
1005         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
1006         comment.  Adjust.
1007         (scoped_switch_fork_info::scoped_switch_fork_info)
1008         (checkpoint_command, linux_fork_context): Adjust
1009         fork_save_infrun_state calls.
1010
1011 2019-03-06  Pedro Alves  <palves@redhat.com>
1012
1013         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
1014         (inf_has_multiple_threads): Return 'bool' and rewrite using
1015         inferior_info::threads().
1016
1017 2019-03-06  Pedro Alves  <palves@redhat.com>
1018
1019         * linux-fork.c: Include <list>.
1020         (fork_list): Now a std::list instance.
1021         (fork_info): Add ctor, dtor, and in-class initialize all fields.
1022         (forks_exist_p, find_last_fork): Adjust.
1023         (new_fork): Delete.
1024         (one_fork_p): New.
1025         (add_fork): Adjust.
1026         (free_fork): Delete, folded into fork_info::~fork_info().
1027         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
1028         Adjust.
1029         (init_fork_list): Delete.
1030         (linux_fork_killall, linux_fork_mourn_inferior)
1031         (linux_fork_detach, info_checkpoints_command): Adjust.
1032         (_initialize_linux_fork): No longer call init_fork_list.
1033
1034 2019-03-06  Pedro Alves  <palves@redhat.com>
1035
1036         * linux-fork.c (new_fork): New, split out of ...
1037         (add_fork): ... this.  Return void.  Move "first fork" special
1038         case from here, to ...
1039         (checkpoint_command): ... here.
1040         * linux-linux.h (add_fork): Return void.
1041
1042 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1043
1044         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1045
1046 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1047             Chris January  <chris.january@arm.com>
1048             David Lecomber  <david.lecomber@arm.com>
1049
1050         * f-exp.y: New token, UNOP_INTRINSIC.
1051         (exp): New pattern using UNOP_INTRINSIC token.
1052         (f77_keywords): Add 'abs' keyword.
1053         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1054         (value_from_host_double): New function.
1055         (evaluate_subexp_f): Support UNOP_ABS.
1056
1057 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1058
1059         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1060         types.
1061
1062 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1063
1064         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1065         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1066         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1067
1068 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1069
1070         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1071
1072 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1073             Chris January  <chris.january@arm.com>
1074
1075         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1076         * f-exp.y: Define 'KIND' token.
1077         (exp): New pattern for KIND expressions.
1078         (ptype): Handle types with a kind extension.
1079         (direct_abs_decl): Extend to spot kind extensions.
1080         (f77_keywords): Add 'kind' to the list.
1081         (push_kind_type): New function.
1082         (convert_to_kind_type): New function.
1083         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1084         * parse.c (operator_length_standard): Likewise.
1085         * parser-defs.h (enum type_pieces): Add tp_kind.
1086         * std-operator.def: Add UNOP_KIND.
1087
1088 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1089
1090         * f-exp.y (f_parse): Set yydebug.
1091
1092 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1093
1094         * f-lang.c (evaluate_subexp_f): New function.
1095         (exp_descriptor_f): New global.
1096         (f_language_defn): Use exp_descriptor_f instead of
1097         exp_descriptor_standard.
1098
1099 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1100
1101         * f-exp.y (struct token): Add comments.
1102         (dot_ops): Remove uppercase versions and the end marker.
1103         (f77_keywords): Likewise.
1104         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1105         entries in the dot_ops array are case insensitive, and use
1106         strncasecmp to compare strings.  Also some whitespace cleanup in
1107         this area.  Similar for the f77_keywords array, except entries in
1108         this list might be case sensitive.
1109
1110 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1111
1112         * f-exp.y (struct f77_boolean_val): Add comments.
1113         (boolean_values): Remove uppercase versions, and end marker.
1114         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1115         and use strncasecmp to achieve case insensitivity.  Additionally,
1116         perform whitespace cleanup around this code.
1117
1118 2019-03-06  Tom Tromey  <tromey@adacore.com>
1119
1120         * remote-sim.c (gdbsim_target_open): Use result of
1121         gdb_argv::release.
1122
1123 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1124         Dirk Schubert  <dirk.schubert@arm.com>
1125         Chris January  <chris.january@arm.com>
1126
1127         * eval.c (evaluate_subexp_standard): Call Fortran argument
1128         wrapping logic.
1129         * f-lang.c (struct value): A value which can be passed into a
1130         Fortran function call.
1131         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1132         where appropriate.
1133         (struct type): Value ready for a Fortran function call.
1134         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1135         is needed.
1136         * f-lang.h (fortran_argument_convert): Declaration.
1137         (fortran_preserve_arg_pointer): Declaration.
1138         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1139
1140 2019-03-05  Tom Tromey  <tromey@adacore.com>
1141
1142         * python/py-prettyprint.c (print_string_repr): Remove #if.
1143         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1144
1145 2019-03-05  Tom Tromey  <tromey@adacore.com>
1146
1147         * target.c (the_dummy_target): Move later.  Change type to
1148         "dummy_target".
1149         (initialize_targets): Don't initialize the_dummy_target.
1150
1151 2019-03-05  Tom Tromey  <tromey@adacore.com>
1152
1153         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1154         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1155
1156 2019-03-05  Tom Tromey  <tromey@adacore.com>
1157
1158         * windows-nat.c (windows_nat_target::attach)
1159         (windows_nat_target::detach): Don't call gdb_flush.
1160         * valprint.c (generic_val_print, val_print, val_print_string):
1161         Don't call gdb_flush.
1162         * utils.c (defaulted_query): Don't call gdb_flush.
1163         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1164         * target.c (target_announce_detach): Don't call gdb_flush.
1165         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1166         * remote.c (extended_remote_target::attach): Don't call
1167         gdb_flush.
1168         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1169         * printcmd.c (do_examine): Don't call gdb_flush.
1170         (info_display_command): Don't call gdb_flush.
1171         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1172         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1173         * memattr.c (info_mem_command): Don't call gdb_flush.
1174         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1175         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1176         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1177         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1178         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1179         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1180         (gnu_nat_target::detach): Don't call gdb_flush.
1181         * f-valprint.c (f_val_print): Don't call gdb_flush.
1182         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1183         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1184         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1185         gdb_flush.
1186         * c-valprint.c (c_val_print): Don't call gdb_flush.
1187         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1188
1189 2019-03-05  Tom Tromey  <tromey@adacore.com>
1190
1191         * varobj.c (update_dynamic_varobj_children): Update.
1192         (install_default_visualizer): Use reset, not release.
1193         * value.c (set_internalvar): Update.
1194         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1195         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1196         ATTRIBUTE_UNUSED_RESULT.
1197
1198 2019-03-05  Tom Tromey  <tromey@adacore.com>
1199
1200         * remote.c (class scoped_remote_fd) <release>: Add
1201         ATTRIBUTE_UNUSED_RESULT.
1202
1203 2019-03-05  Tom Tromey  <tromey@adacore.com>
1204
1205         * macroexp.c (struct macro_buffer) <release>: Add
1206         ATTRIBUTE_UNUSED_RESULT.
1207
1208 2019-03-05  Tom Tromey  <tromey@adacore.com>
1209
1210         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1211         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1212         ATTRIBUTE_UNUSED_RESULT.
1213
1214 2019-03-05  Tom Tromey  <tromey@adacore.com>
1215
1216         * common/scoped_fd.h (class scoped_fd) <release>: Add
1217         ATTRIBUTE_UNUSED_RESULT.
1218
1219 2019-03-05  Tom Tromey  <tromey@adacore.com>
1220
1221         * parser-defs.h (struct parser_state) <release>: Add
1222         ATTRIBUTE_UNUSED_RESULT.
1223
1224 2019-03-05  Tom Tromey  <tromey@adacore.com>
1225
1226         * utils.h (class gdb_argv) <release>: Add
1227         ATTRIBUTE_UNUSED_RESULT.
1228         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1229
1230 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1231
1232         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1233         for-loop range, to avoid compiler warnings.
1234
1235         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1236         avoid compiler warnings about unused variables.
1237
1238         * NEWS: Mention end of support for native debugging on MS-Windows
1239         before XP.
1240
1241         PR gdb/24292
1242         * common/netstuff.c:
1243         * gdbserver/gdbreplay.c
1244         * gdbserver/remote-utils.c:
1245         * ser-tcp.c:
1246         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1247         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1248         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1249         'getaddrinfo' and 'freeaddrinfo' were not available before
1250         Windows XP, and mingw.org's MinGW headers by default define
1251         _WIN32_WINNT to 0x500.
1252
1253 2019-03-01  Gary Benson <gbenson@redhat.com>
1254
1255         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1256
1257 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1258             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1259
1260         PR gdb/8527
1261         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1262         set_sigint_trap, clear_sigint_trap.
1263
1264 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1265
1266         * target.c (target_detach): Clear the regcache and the
1267         frame cache.
1268
1269 2019-02-27  Pedro Alves  <palves@redhat.com>
1270
1271         * utils.c (set_screen_size): When we cap the height/width sizes,
1272         tweak the corresponding command variable to show "unlimited":
1273
1274 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1275             Pedro Alves  <palves@redhat.com>
1276
1277         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1278         before calling rl_set_screen_size.
1279
1280 2019-02-27  Tom Tromey  <tromey@adacore.com>
1281
1282         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1283         define.
1284         * python/py-value.c: Remove Python 2.4 workaround.
1285         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1286         workaround.
1287         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1288         Python 2.4 workaround.
1289         * python/python-internal.h: Remove Python 2.4 comment.
1290         (Py_ssize_t): Don't define.
1291         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1292         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1293         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1294         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1295         * python/python.c (do_start_initialization): Remove Python 2.4
1296         workaround.
1297         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1298         (print_children): Remove Python 2.4 workaround.
1299         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1300         workaround.
1301         (CHARBUFFERPROC_NAME): Remove.
1302         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1303         Python 2.4 workaround.
1304
1305 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1306
1307         * NEWS: Note minimum Python version.
1308
1309 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1310
1311         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1312         code from these functions.  Remove corresponding ifdefs.  Use
1313         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1314         Remove gotos and target of gotos.
1315         (infpy_search_memory): Likewise.
1316
1317 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1318
1319         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1320         (hppa_gdbarch_init): Don't register deleted functions with
1321         gdbarch.
1322
1323 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1324
1325         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1326         (h8300_unwind_sp): Delete.
1327         (h8300_dummy_id): Delete.
1328         (h8300_gdbarch_init): Don't register deleted functions with
1329         gdbarch.
1330
1331 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1332
1333         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1334         (ft32_unwind_pc): Delete.
1335         (ft32_unwind_sp): Delete.
1336         (ft32_gdbarch_init): Don't register deleted functions with
1337         gdbarch.
1338
1339 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1340
1341         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1342         (frv_unwind_pc): Delete.
1343         (frv_unwind_sp): Delete.
1344         (frv_gdbarch_init): Don't register deleted functions with
1345         gdbarch.
1346
1347 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1348
1349         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1350         (riscv_unwind_pc): Delete.
1351         (riscv_unwind_sp): Delete.
1352         (riscv_gdbarch_init): Don't register deleted functions with
1353         gdbarch.
1354
1355 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1356
1357         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1358         (csky_unwind_pc): Delete.
1359         (csky_unwind_sp): Delete.
1360         (csky_gdbarch_init): Don't register deleted functions with
1361         gdbarch.
1362
1363 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1364
1365         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1366         (cris_unwind_pc): Delete.
1367         (cris_unwind_sp): Delete.
1368         (cris_gdbarch_init): Don't register deleted functions with
1369         gdbarch.
1370
1371 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1372
1373         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1374         (bfin_unwind_pc): Delete.
1375         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1376
1377 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1378
1379         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1380         (arm_unwind_pc): Delete.
1381         (arm_unwind_sp): Delete.
1382         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1383
1384 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1385
1386         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1387         (arc_unwind_pc): Delete.
1388         (arc_unwind_sp): Delete.
1389         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1390
1391 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1392
1393         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1394         (alpha_unwind_pc): Delete.
1395         (alpha_gdbarch_init): Don't register deleted functions with
1396         gdbarch.
1397
1398 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1399
1400         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1401         (aarch64_unwind_pc): Delete.
1402         (aarch64_unwind_sp): Delete.
1403         (aarch64_gdbarch_init): Don't register deleted functions with
1404         gdbarch.
1405
1406 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1407
1408         * gdbtypes.c (type_align): Don't consider static members when
1409         computing structure alignment.
1410
1411 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1412
1413         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1414         return 0 for other types.
1415         * arch-utils.c (default_type_align): Always return 0.
1416         * gdbarch.h: Regenerate.
1417         * gdbarch.sh (type_align): Extend comment.
1418         * gdbtypes.c (type_align): Add additional comments, always call
1419         gdbarch_type_align before applying the default rules.
1420         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1421         generic code will then apply a suitable default.
1422         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1423         types, return 0 for other types.
1424
1425 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1426
1427         * NEWS: Create a new section for the next release branch.
1428         Rename the section of the current branch, now that it has
1429         been cut.
1430
1431 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1432
1433         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1434         * version.in: Bump version to 8.3.50.DATE-git.
1435
1436 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1437
1438         * aix-thread.c (ptid_cmp): Remove unused variable.
1439         (get_signaled_thread): Likewise.
1440         (store_regs_user_thread): Likewise.
1441         (store_regs_kernel_thread): Likewise.
1442         (fetch_regs_kernel_thread): Remove shadowed variable.
1443
1444 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1445
1446         * features/riscv/32bit-cpu.xml: Add register numbers.
1447         * features/riscv/32bit-fpu.c: Regenerate.
1448         * features/riscv/32bit-fpu.xml: Add register numbers.
1449         * features/riscv/64bit-cpu.xml: Add register numbers.
1450         * features/riscv/64bit-fpu.c: Regenerate.
1451         * features/riscv/64bit-fpu.xml: Add register numbers.
1452
1453 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1454
1455         * NEWS: Mention two argument form of gdb.Value constructor.
1456         * python/py-value.c (convert_buffer_and_type_to_value): New
1457         function.
1458         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1459         Add support for handling an optional second argument.  Call
1460         convert_buffer_and_type_to_value as appropriate.
1461         * python/python-internal.h (Py_buffer_deleter): New struct.
1462         (Py_buffer_up): New typedef.
1463
1464 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1465
1466         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1467         instead of releasing ownership.
1468
1469 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1470
1471         * dwarf2read.c (open_and_init_dwp_file): Call
1472         elf_numsections instead of bfd_count_sections to initialize
1473         dwp_file->num_sections.
1474
1475 2019-02-25  Tom Tromey  <tromey@adacore.com>
1476
1477         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1478
1479 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1480
1481         * gcore.in: Add '--readnever' option when invoking GDB.
1482
1483 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1484
1485         * MAINTAINERS: Update my email address.
1486
1487 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1488
1489         * build-id.c (build_id_to_debug_bfd_1): New function.
1490         (build_id_to_debug_bfd): Look for separate debug file in
1491         sysroot.
1492
1493 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1494
1495         * gdbarch.sh: Update the copyright year range that is placed into
1496         generated files.
1497
1498 2019-02-22  Keith Seitz  <keiths@redhat.com>
1499
1500         PR symtab/23853
1501         * linespec.c (create_sals_line_offset): Search for the default
1502         symtab's filename instead of its fullname.
1503
1504 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1505
1506         * NEWS: Update style defaults.
1507
1508 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1509
1510         * main.c (captured_main_1): Disable styling in batch mode.
1511
1512 2019-02-20  Tom Tromey  <tom@tromey.com>
1513
1514         * symtab.c (symtab_symbol_info): Fix typos.
1515
1516 2019-02-20  Tom Tromey  <tromey@adacore.com>
1517
1518         * findcmd.c (_initialize_mem_search): Use upper case for
1519         metasyntactic variables.
1520
1521 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1522
1523         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1524         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1525
1526 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1527
1528         * top.h (source_file_name): Change to std::string.
1529         * top.c (source_file_name): Likewise.
1530         (command_line_input): Adjust.
1531         * cli/cli-script.c (script_from_file): Adjust.
1532
1533 2019-02-19  Tom Tromey  <tromey@adacore.com>
1534
1535         * ravenscar-thread.c
1536         (ravenscar_thread_target::update_thread_list): Don't call
1537         ada_build_task_list.
1538         * ada-lang.h (ada_build_task_list): Don't declare.
1539         * ada-tasks.c (struct ada_tasks_inferior_data)
1540         <task_list_valid_p>: Now bool.
1541         (read_known_tasks, ada_task_list_changed)
1542         (ada_tasks_invalidate_inferior_data): Update.
1543         (read_known_tasks_array): Return bool.
1544         (read_known_tasks_list): Likewise.
1545         (read_known_tasks): Return void.
1546         (ada_build_task_list): Now static.
1547
1548 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1549
1550         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1551         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1552
1553 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1554
1555         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1556         variant for ada_tasks_pspace_data_handle and
1557         ada_tasks_inferior_data_handle.
1558         (ada_tasks_pspace_data_cleanup): New function.
1559         (ada_tasks_inferior_data_cleanup): New function.
1560
1561 2019-02-17  Tom Tromey  <tom@tromey.com>
1562
1563         * macrotab.h (macro_source_fullname): Return a std::string.
1564         * macrotab.c (macro_include, check_for_redefinition)
1565         (macro_undef, macro_lookup_definition, foreach_macro)
1566         (foreach_macro_in_scope): Update.
1567         (macro_source_fullname): Return a std::string.
1568         * macrocmd.c (show_pp_source_pos): Update.
1569
1570 2019-02-17  Tom Tromey  <tom@tromey.com>
1571
1572         * macrocmd.c (show_pp_source_pos): Style the file names.
1573
1574 2019-02-17  Tom Tromey  <tom@tromey.com>
1575
1576         PR tui/24197:
1577         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1578
1579 2019-02-17  Tom Tromey  <tom@tromey.com>
1580
1581         * ada-lang.c (user_select_syms): Use filtered printing.
1582         * utils.c (wrap_style): New global.
1583         (desired_style): Remove.
1584         (emit_style_escape): Add stream parameter.
1585         (set_output_style, reset_terminal_style, prompt_for_continue):
1586         Update.
1587         (flush_wrap_buffer): Only flush gdb_stdout.
1588         (wrap_here): Set wrap_style.
1589         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1590         treat escape sequences as a character.  Change when wrap buffer is
1591         flushed.
1592         (fputs_styled): Do not set the output style when the default is
1593         requested.
1594         * ui-style.h (struct ui_file_style) <is_default>: New method.
1595         * source.c (print_source_lines_base): Emit escape sequences in one
1596         piece.
1597
1598 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1599
1600         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1601         integers and enumeration types.
1602
1603 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1604
1605         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1606         instead of lookup_symbol_in_language
1607         (do_exact_match): New function.
1608         (ada_get_symbol_name_matcher): Return do_exact_match when
1609         doing a verbatim match.
1610
1611 2019-02-15  Tom Tromey  <tromey@adacore.com>
1612
1613         * ravenscar-thread.c (ravenscar_thread_target::resume)
1614         (ravenscar_thread_target::wait): Special case wildcard requests.
1615
1616 2019-02-15  Tom Tromey  <tromey@adacore.com>
1617
1618         * ravenscar-thread.c (base_ptid): Remove.
1619         (struct ravenscar_thread_target) <close>: New method.
1620         <m_base_ptid>: New member.
1621         <update_inferior_ptid, active_task, task_is_currently_active,
1622         runtime_initialized>: Declare methods.
1623         <ravenscar_thread_target>: Add constructor.
1624         (ravenscar_thread_target::task_is_currently_active)
1625         (ravenscar_thread_target::update_inferior_ptid)
1626         (ravenscar_runtime_initialized): Rename.  Now methods.
1627         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1628         (ravenscar_thread_target::update_thread_list): Update.
1629         (ravenscar_thread_target::active_task): Now method.
1630         (ravenscar_thread_target::store_registers)
1631         (ravenscar_thread_target::prepare_to_store)
1632         (ravenscar_thread_target::prepare_to_store)
1633         (ravenscar_thread_target::mourn_inferior): Update.
1634         (ravenscar_inferior_created): Use "new" to create target.
1635         (ravenscar_thread_target::get_ada_task_ptid): Update.
1636         (_initialize_ravenscar): Don't initialize base_ptid.
1637         (ravenscar_ops): Remove global.
1638
1639 2019-02-15  Tom Tromey  <tromey@adacore.com>
1640
1641         * target.h (push_target): Declare new overload.
1642         * target.c (push_target): New overload, taking an rvalue reference.
1643         * remote.c (remote_target::open_1): Use push_target overload.
1644         * corelow.c (core_target_open): Use push_target overload.
1645
1646 2019-02-15  Tom Tromey  <tromey@adacore.com>
1647
1648         * ravenscar-thread.c (is_ravenscar_task)
1649         (ravenscar_task_is_currently_active): Return bool.
1650         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1651         (_initialize_ravenscar): Remove "(void)".
1652         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1653         Return bool.
1654
1655 2019-02-15  Tom Tromey  <tromey@adacore.com>
1656
1657         * ravenscar-thread.c (ravenscar_runtime_initializer)
1658         (has_ravenscar_runtime, get_running_thread_id)
1659         (ravenscar_thread_target::resume): Fix indentation.
1660
1661 2019-02-15  Tom Tromey  <tromey@adacore.com>
1662
1663         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1664         from ravenscar_arch_ops.
1665         (sparc_ravenscar_ops::fetch_registers)
1666         (sparc_ravenscar_ops::store_registers): Now methods.
1667         (sparc_ravenscar_prepare_to_store): Remove.
1668         (sparc_ravenscar_ops): Redefine.
1669         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1670         methods and destructor.  Remove members.
1671         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1672         (ravenscar_thread_target::store_registers)
1673         (ravenscar_thread_target::prepare_to_store): Update.
1674         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1675         Remove.
1676         (struct ppc_ravenscar_powerpc_ops): Derive from
1677         ravenscar_arch_ops.
1678         (ppc_ravenscar_powerpc_ops::fetch_registers)
1679         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1680         (ppc_ravenscar_powerpc_ops): Redefine.
1681         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1682         (ppc_ravenscar_e500_ops::fetch_registers)
1683         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1684         (ppc_ravenscar_e500_ops): Redefine.
1685         * aarch64-ravenscar-thread.c
1686         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1687         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1688         (aarch64_ravenscar_fetch_registers)
1689         (aarch64_ravenscar_store_registers): Now methods.
1690         (aarch64_ravenscar_ops): Redefine.
1691
1692 2019-02-15  Tom Tromey  <tromey@adacore.com>
1693
1694         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1695         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1696         (ravenscar_thread_target::stopped_by_watchpoint)
1697         (ravenscar_thread_target::stopped_data_address)
1698         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1699
1700 2019-02-15  Tom Tromey  <tromey@adacore.com>
1701
1702         * ravenscar-thread.c: Fix some typos.
1703
1704 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1705             Tom Tromey  <tromey@adacore.com>
1706
1707         * ada-lang.c (ada_exception_sal): Change addr_string to a
1708         std::string.
1709         (create_ada_exception_catchpoint): Update.
1710
1711 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1712             Tom Tromey  <tromey@adacore.com>
1713
1714         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1715         (bp_location_ops): Remove.
1716         (base_breakpoint_allocate_location): Update.
1717         (free_bp_location): Update.
1718         * ada-lang.c (class ada_catchpoint_location)
1719         <ada_catchpoint_location>: Remove ops parameter.
1720         (ada_catchpoint_location_dtor): Remove.
1721         (ada_catchpoint_location_ops): Remove.
1722         (allocate_location_exception): Update.
1723         * breakpoint.h (struct bp_location_ops): Remove.
1724         (class bp_location) <bp_location>: Remove bp_location_ops
1725         parameter.
1726         <~bp_location>: Add destructor.
1727         <ops>: Remove.
1728
1729 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1730             Pedro Alves  <palves@redhat.com>
1731
1732         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1733         'PATH_MAX'.
1734
1735 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1736             Samuel Thibault  <samuel.thibault@gnu.org>
1737             Thomas Schwinge  <thomas@codesourcery.com>
1738
1739         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1740         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1741
1742 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1743
1744         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1745         (check_empty): Use "const char *".
1746
1747         * gnu-nat.c (gnu_nat_target::detach): Instead of
1748         'detach_inferior (pid)' call
1749         'detach_inferior (find_inferior_pid (pid))'.
1750
1751         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1752         'nat/fork-inferior.o'.
1753         * gnu-nat.c: #include "nat/fork-inferior.h".
1754
1755         * gnu-nat.c (gnu_nat_target::detach): Instead of
1756         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1757         * gnu-nat.h: #include "inf-child.h".
1758         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1759         'i386_gnu_nat_target::fetch_registers'.
1760         (gnu_store_registers): Rename/move to
1761         'i386_gnu_nat_target::store_registers'.
1762
1763         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1764         * gnu-nat.h (mach_thread_info): New function.
1765         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1766
1767         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1768
1769 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1770
1771         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1772
1773 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1774
1775         * windows-nat.c (windows_add_thread): Add new parameter
1776         "main_thread_p" with default value set to false.  Update
1777         function documentation as well as all callers.
1778         (windows_delete_thread): Likewise.
1779         (fake_create_process): Update call to windows_add_thread.
1780         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1781         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1782         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1783         call to windows_delete_thread.
1784
1785 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1786
1787         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1788
1789 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1790
1791         * symfile.c (find_separate_debug_file): Use canonical path of
1792         sysroot with child_path instead of gdb_sysroot if it is valid.
1793
1794 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1795
1796         * symfile.c (find_separate_debug_file): Use child_path to
1797         determine if an object file is under a sysroot.
1798
1799 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1800
1801         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1802         unittests/child-path-selftests.c.
1803         * common/pathstuff.c (child_path): New function.
1804         * common/pathstuff.h (child_path): New prototype.
1805         * unittests/child-path-selftests.c: New file.
1806
1807 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1808
1809         * symfile.c (find_separate_debug_file): Look for separate debug
1810         files in debug directories under the sysroot.
1811
1812 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1813
1814         * symtab.h (struct minimal_symbol data_p): New const method.
1815         (struct minimal_symbol text_p): Likewise.
1816         * symtab.c (output_source_filename): Use file name style
1817         to print file name.
1818         (print_symbol_info): Likewise.
1819         (print_msymbol_info): Use address style to print addresses.
1820         Use function name style to print executable text symbols.
1821         (expand_symtab_containing_pc): Use data_p.
1822         (find_pc_sect_compunit_symtab): Likewise.
1823
1824 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1825
1826         * breakpoint.c (describe_other_breakpoints): Use address style
1827         to print addresses.
1828         (say_where): Likewise.
1829
1830 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1831
1832         * ada-typeprint.c (print_func_type): Print function name
1833         style to print function name.
1834         * c-typeprint.c (c_print_type_1): Likewise.
1835
1836 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1837
1838         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1839         for execve.
1840
1841 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1842
1843         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1844         type_stack.
1845
1846 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1847
1848         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1849         TYPE_CODE_REF types.
1850
1851 2019-02-08  Jim Wilson  <jimw@sifive.com>
1852
1853         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1854         (riscv_linux_fregset): New.
1855         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1856
1857 2019-02-07  Tom Tromey  <tom@tromey.com>
1858
1859         * thread.c (thread_cancel_execution_command): Update.
1860         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1861         methods.
1862         (struct thread_fsm_ops): Remove.
1863         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1864         (thread_fsm_should_stop, thread_fsm_return_value)
1865         (thread_fsm_set_finished, thread_fsm_finished_p)
1866         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1867         Don't declare.
1868         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1869         * infrun.c (clear_proceed_status_thread)
1870         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1871         (print_stop_event): Update.
1872         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1873         Add constructor.
1874         (step_command_fsm_ops): Remove.
1875         (new_step_command_fsm): Remove.
1876         (step_1): Update.
1877         (step_command_fsm::should_stop): Rename from
1878         step_command_fsm_should_stop.
1879         (step_command_fsm::clean_up): Rename from
1880         step_command_fsm_clean_up.
1881         (step_command_fsm::do_async_reply_reason): Rename from
1882         step_command_fsm_async_reply_reason.
1883         (struct until_next_fsm): Inherit from thread_fsm.  Add
1884         constructor.
1885         (until_next_fsm_ops): Remove.
1886         (new_until_next_fsm): Remove.
1887         (until_next_fsm::should_stop): Rename from
1888         until_next_fsm_should_stop.
1889         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1890         (until_next_fsm::do_async_reply_reason): Rename from
1891         until_next_fsm_async_reply_reason.
1892         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1893         constructor.  Change type of breakpoint.
1894         (finish_command_fsm_ops): Remove.
1895         (new_finish_command_fsm): Remove.
1896         (finish_command_fsm::should_stop): Rename from
1897         finish_command_fsm_should_stop.
1898         (finish_command_fsm::clean_up): Rename from
1899         finish_command_fsm_clean_up.
1900         (finish_command_fsm::return_value): Rename from
1901         finish_command_fsm_return_value.
1902         (finish_command_fsm::do_async_reply_reason): Rename from
1903         finish_command_fsm_async_reply_reason.
1904         (finish_command): Update.
1905         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1906         Add constructor.
1907         (call_thread_fsm_ops): Remove.
1908         (call_thread_fsm::call_thread_fsm): Rename from
1909         new_call_thread_fsm.
1910         (call_thread_fsm::should_stop): Rename from
1911         call_thread_fsm_should_stop.
1912         (call_thread_fsm::should_notify_stop): Rename from
1913         call_thread_fsm_should_notify_stop.
1914         (run_inferior_call, call_function_by_hand_dummy): Update.
1915         * cli/cli-interp.c (should_print_stop_to_console): Update.
1916         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1917         Add constructor.  Change type of location_breakpoint,
1918         caller_breakpoint.
1919         (until_break_fsm_ops): Remove.
1920         (new_until_break_fsm): Remove.
1921         (until_break_fsm::should_stop): Rename from
1922         until_break_fsm_should_stop.
1923         (until_break_fsm::clean_up): Rename from
1924         until_break_fsm_clean_up.
1925         (until_break_fsm::do_async_reply_reason): Rename from
1926         until_break_fsm_async_reply_reason.
1927         (until_break_command): Update.
1928         * thread-fsm.c: Remove.
1929         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1930
1931 2019-02-07  Tom Tromey  <tom@tromey.com>
1932
1933         * yy-remap.h: Add include guard.
1934         * xtensa-tdep.h: Add include guard.
1935         * xcoffread.h: Rename include guard.
1936         * varobj-iter.h: Add include guard.
1937         * tui/tui.h: Rename include guard.
1938         * tui/tui-winsource.h: Rename include guard.
1939         * tui/tui-wingeneral.h: Rename include guard.
1940         * tui/tui-windata.h: Rename include guard.
1941         * tui/tui-win.h: Rename include guard.
1942         * tui/tui-stack.h: Rename include guard.
1943         * tui/tui-source.h: Rename include guard.
1944         * tui/tui-regs.h: Rename include guard.
1945         * tui/tui-out.h: Rename include guard.
1946         * tui/tui-layout.h: Rename include guard.
1947         * tui/tui-io.h: Rename include guard.
1948         * tui/tui-hooks.h: Rename include guard.
1949         * tui/tui-file.h: Rename include guard.
1950         * tui/tui-disasm.h: Rename include guard.
1951         * tui/tui-data.h: Rename include guard.
1952         * tui/tui-command.h: Rename include guard.
1953         * tic6x-tdep.h: Add include guard.
1954         * target/waitstatus.h: Rename include guard.
1955         * target/wait.h: Rename include guard.
1956         * target/target.h: Rename include guard.
1957         * target/resume.h: Rename include guard.
1958         * target-float.h: Rename include guard.
1959         * stabsread.h: Add include guard.
1960         * rs6000-tdep.h: Add include guard.
1961         * riscv-fbsd-tdep.h: Add include guard.
1962         * regformats/regdef.h: Rename include guard.
1963         * record.h: Rename include guard.
1964         * python/python.h: Rename include guard.
1965         * python/python-internal.h: Rename include guard.
1966         * python/py-stopevent.h: Rename include guard.
1967         * python/py-ref.h: Rename include guard.
1968         * python/py-record.h: Rename include guard.
1969         * python/py-record-full.h: Rename include guard.
1970         * python/py-record-btrace.h: Rename include guard.
1971         * python/py-instruction.h: Rename include guard.
1972         * python/py-events.h: Rename include guard.
1973         * python/py-event.h: Rename include guard.
1974         * procfs.h: Add include guard.
1975         * proc-utils.h: Add include guard.
1976         * p-lang.h: Add include guard.
1977         * or1k-tdep.h: Rename include guard.
1978         * observable.h: Rename include guard.
1979         * nto-tdep.h: Rename include guard.
1980         * nat/x86-linux.h: Rename include guard.
1981         * nat/x86-linux-dregs.h: Rename include guard.
1982         * nat/x86-gcc-cpuid.h: Add include guard.
1983         * nat/x86-dregs.h: Rename include guard.
1984         * nat/x86-cpuid.h: Rename include guard.
1985         * nat/ppc-linux.h: Rename include guard.
1986         * nat/mips-linux-watch.h: Rename include guard.
1987         * nat/linux-waitpid.h: Rename include guard.
1988         * nat/linux-ptrace.h: Rename include guard.
1989         * nat/linux-procfs.h: Rename include guard.
1990         * nat/linux-osdata.h: Rename include guard.
1991         * nat/linux-nat.h: Rename include guard.
1992         * nat/linux-namespaces.h: Rename include guard.
1993         * nat/linux-btrace.h: Rename include guard.
1994         * nat/glibc_thread_db.h: Rename include guard.
1995         * nat/gdb_thread_db.h: Rename include guard.
1996         * nat/gdb_ptrace.h: Rename include guard.
1997         * nat/fork-inferior.h: Rename include guard.
1998         * nat/amd64-linux-siginfo.h: Rename include guard.
1999         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
2000         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
2001         * nat/aarch64-linux.h: Rename include guard.
2002         * nat/aarch64-linux-hw-point.h: Rename include guard.
2003         * mn10300-tdep.h: Add include guard.
2004         * mips-linux-tdep.h: Add include guard.
2005         * mi/mi-parse.h: Rename include guard.
2006         * mi/mi-out.h: Rename include guard.
2007         * mi/mi-main.h: Rename include guard.
2008         * mi/mi-interp.h: Rename include guard.
2009         * mi/mi-getopt.h: Rename include guard.
2010         * mi/mi-console.h: Rename include guard.
2011         * mi/mi-common.h: Rename include guard.
2012         * mi/mi-cmds.h: Rename include guard.
2013         * mi/mi-cmd-break.h: Rename include guard.
2014         * m2-lang.h: Add include guard.
2015         * location.h: Rename include guard.
2016         * linux-record.h: Rename include guard.
2017         * linux-nat.h: Add include guard.
2018         * linux-fork.h: Add include guard.
2019         * i386-darwin-tdep.h: Rename include guard.
2020         * hppa-linux-offsets.h: Add include guard.
2021         * guile/guile.h: Rename include guard.
2022         * guile/guile-internal.h: Rename include guard.
2023         * gnu-nat.h: Rename include guard.
2024         * gdb-stabs.h: Rename include guard.
2025         * frv-tdep.h: Add include guard.
2026         * f-lang.h: Add include guard.
2027         * event-loop.h: Add include guard.
2028         * darwin-nat.h: Rename include guard.
2029         * cp-abi.h: Rename include guard.
2030         * config/sparc/nm-sol2.h: Rename include guard.
2031         * config/nm-nto.h: Rename include guard.
2032         * config/nm-linux.h: Add include guard.
2033         * config/i386/nm-i386gnu.h: Rename include guard.
2034         * config/djgpp/nl_types.h: Rename include guard.
2035         * config/djgpp/langinfo.h: Rename include guard.
2036         * compile/gcc-cp-plugin.h: Add include guard.
2037         * compile/gcc-c-plugin.h: Add include guard.
2038         * compile/compile.h: Rename include guard.
2039         * compile/compile-object-run.h: Rename include guard.
2040         * compile/compile-object-load.h: Rename include guard.
2041         * compile/compile-internal.h: Rename include guard.
2042         * compile/compile-cplus.h: Rename include guard.
2043         * compile/compile-c.h: Rename include guard.
2044         * common/xml-utils.h: Rename include guard.
2045         * common/x86-xstate.h: Rename include guard.
2046         * common/version.h: Rename include guard.
2047         * common/vec.h: Rename include guard.
2048         * common/tdesc.h: Rename include guard.
2049         * common/selftest.h: Rename include guard.
2050         * common/scoped_restore.h: Rename include guard.
2051         * common/scoped_mmap.h: Rename include guard.
2052         * common/scoped_fd.h: Rename include guard.
2053         * common/safe-iterator.h: Rename include guard.
2054         * common/run-time-clock.h: Rename include guard.
2055         * common/refcounted-object.h: Rename include guard.
2056         * common/queue.h: Rename include guard.
2057         * common/ptid.h: Rename include guard.
2058         * common/print-utils.h: Rename include guard.
2059         * common/preprocessor.h: Rename include guard.
2060         * common/pathstuff.h: Rename include guard.
2061         * common/observable.h: Rename include guard.
2062         * common/netstuff.h: Rename include guard.
2063         * common/job-control.h: Rename include guard.
2064         * common/host-defs.h: Rename include guard.
2065         * common/gdb_wait.h: Rename include guard.
2066         * common/gdb_vecs.h: Rename include guard.
2067         * common/gdb_unlinker.h: Rename include guard.
2068         * common/gdb_unique_ptr.h: Rename include guard.
2069         * common/gdb_tilde_expand.h: Rename include guard.
2070         * common/gdb_sys_time.h: Rename include guard.
2071         * common/gdb_string_view.h: Rename include guard.
2072         * common/gdb_splay_tree.h: Rename include guard.
2073         * common/gdb_setjmp.h: Rename include guard.
2074         * common/gdb_ref_ptr.h: Rename include guard.
2075         * common/gdb_optional.h: Rename include guard.
2076         * common/gdb_locale.h: Rename include guard.
2077         * common/gdb_assert.h: Rename include guard.
2078         * common/filtered-iterator.h: Rename include guard.
2079         * common/filestuff.h: Rename include guard.
2080         * common/fileio.h: Rename include guard.
2081         * common/environ.h: Rename include guard.
2082         * common/common-utils.h: Rename include guard.
2083         * common/common-types.h: Rename include guard.
2084         * common/common-regcache.h: Rename include guard.
2085         * common/common-inferior.h: Rename include guard.
2086         * common/common-gdbthread.h: Rename include guard.
2087         * common/common-exceptions.h: Rename include guard.
2088         * common/common-defs.h: Rename include guard.
2089         * common/common-debug.h: Rename include guard.
2090         * common/cleanups.h: Rename include guard.
2091         * common/buffer.h: Rename include guard.
2092         * common/btrace-common.h: Rename include guard.
2093         * common/break-common.h: Rename include guard.
2094         * cli/cli-utils.h: Rename include guard.
2095         * cli/cli-style.h: Rename include guard.
2096         * cli/cli-setshow.h: Rename include guard.
2097         * cli/cli-script.h: Rename include guard.
2098         * cli/cli-interp.h: Rename include guard.
2099         * cli/cli-decode.h: Rename include guard.
2100         * cli/cli-cmds.h: Rename include guard.
2101         * charset-list.h: Add include guard.
2102         * buildsym-legacy.h: Rename include guard.
2103         * bfin-tdep.h: Add include guard.
2104         * ax.h: Rename include guard.
2105         * arm-linux-tdep.h: Add include guard.
2106         * arm-fbsd-tdep.h: Add include guard.
2107         * arch/xtensa.h: Rename include guard.
2108         * arch/tic6x.h: Add include guard.
2109         * arch/i386.h: Add include guard.
2110         * arch/arm.h: Rename include guard.
2111         * arch/arm-linux.h: Rename include guard.
2112         * arch/arm-get-next-pcs.h: Rename include guard.
2113         * arch/amd64.h: Add include guard.
2114         * arch/aarch64-insn.h: Rename include guard.
2115         * arch-utils.h: Rename include guard.
2116         * annotate.h: Add include guard.
2117         * amd64-darwin-tdep.h: Rename include guard.
2118         * aarch64-linux-tdep.h: Add include guard.
2119         * aarch64-fbsd-tdep.h: Add include guard.
2120         * aarch32-linux-nat.h: Add include guard.
2121
2122 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2123
2124         * macrotab.c (macro_define_internal): New function that
2125         factorizes macro_define_object_internal and macro_define_function
2126         code.
2127         (macro_define_object_internal): Use macro_define_internal.
2128         (macro_define_function): Likewise.
2129
2130 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2131
2132         * macrocmd.c (extract_identifier): Return
2133         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2134         callers.
2135
2136 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2137
2138         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2139
2140 2019-02-05  Tom Tromey  <tom@tromey.com>
2141
2142         * target.c (target_stack::unpush): Move assertion earlier.
2143
2144 2019-01-30  Tom Tromey  <tom@tromey.com>
2145
2146         PR python/23615:
2147         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2148         (gdbpy_parse_and_eval): Likewise.
2149         * python/python-internal.h (gdbpy_allow_threads): New class.
2150
2151 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2152
2153         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2154         (aarch64_fbsd_fpregmap): Move earlier.
2155         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2156         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2157         instead of individual calls to trad_frame_set_reg_addr.
2158         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2159         earlier.
2160         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2161         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2162         instead of individual calls to trad_frame_set_reg_addr.
2163
2164 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2165
2166         * CONTRIBUTE: Replace contribution list with wiki link.
2167
2168 2019-01-25  Tom Tromey  <tom@tromey.com>
2169
2170         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2171
2172 2019-01-25  Tom Tromey  <tom@tromey.com>
2173
2174         * xtensa-linux-nat.c: Fix common/ includes.
2175         * xml-support.h: Fix common/ includes.
2176         * xml-support.c: Fix common/ includes.
2177         * x86-linux-nat.c: Fix common/ includes.
2178         * windows-nat.c: Fix common/ includes.
2179         * varobj.h: Fix common/ includes.
2180         * varobj.c: Fix common/ includes.
2181         * value.c: Fix common/ includes.
2182         * valops.c: Fix common/ includes.
2183         * utils.c: Fix common/ includes.
2184         * unittests/xml-utils-selftests.c: Fix common/ includes.
2185         * unittests/utils-selftests.c: Fix common/ includes.
2186         * unittests/unpack-selftests.c: Fix common/ includes.
2187         * unittests/tracepoint-selftests.c: Fix common/ includes.
2188         * unittests/style-selftests.c: Fix common/ includes.
2189         * unittests/string_view-selftests.c: Fix common/ includes.
2190         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2191         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2192         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2193         * unittests/rsp-low-selftests.c: Fix common/ includes.
2194         * unittests/parse-connection-spec-selftests.c: Fix common/
2195         includes.
2196         * unittests/optional-selftests.c: Fix common/ includes.
2197         * unittests/offset-type-selftests.c: Fix common/ includes.
2198         * unittests/observable-selftests.c: Fix common/ includes.
2199         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2200         * unittests/memrange-selftests.c: Fix common/ includes.
2201         * unittests/memory-map-selftests.c: Fix common/ includes.
2202         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2203         * unittests/function-view-selftests.c: Fix common/ includes.
2204         * unittests/environ-selftests.c: Fix common/ includes.
2205         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2206         * unittests/common-utils-selftests.c: Fix common/ includes.
2207         * unittests/cli-utils-selftests.c: Fix common/ includes.
2208         * unittests/array-view-selftests.c: Fix common/ includes.
2209         * ui-file.c: Fix common/ includes.
2210         * tui/tui-io.c: Fix common/ includes.
2211         * tracepoint.h: Fix common/ includes.
2212         * tracepoint.c: Fix common/ includes.
2213         * tracefile-tfile.c: Fix common/ includes.
2214         * top.h: Fix common/ includes.
2215         * top.c: Fix common/ includes.
2216         * thread.c: Fix common/ includes.
2217         * target/waitstatus.h: Fix common/ includes.
2218         * target/waitstatus.c: Fix common/ includes.
2219         * target.h: Fix common/ includes.
2220         * target.c: Fix common/ includes.
2221         * target-memory.c: Fix common/ includes.
2222         * target-descriptions.c: Fix common/ includes.
2223         * symtab.h: Fix common/ includes.
2224         * symfile.c: Fix common/ includes.
2225         * stap-probe.c: Fix common/ includes.
2226         * spu-linux-nat.c: Fix common/ includes.
2227         * sparc-nat.c: Fix common/ includes.
2228         * source.c: Fix common/ includes.
2229         * solib.c: Fix common/ includes.
2230         * solib-target.c: Fix common/ includes.
2231         * ser-unix.c: Fix common/ includes.
2232         * ser-tcp.c: Fix common/ includes.
2233         * ser-pipe.c: Fix common/ includes.
2234         * ser-base.c: Fix common/ includes.
2235         * selftest-arch.c: Fix common/ includes.
2236         * s12z-tdep.c: Fix common/ includes.
2237         * rust-exp.y: Fix common/ includes.
2238         * rs6000-aix-tdep.c: Fix common/ includes.
2239         * riscv-tdep.c: Fix common/ includes.
2240         * remote.c: Fix common/ includes.
2241         * remote-notif.h: Fix common/ includes.
2242         * remote-fileio.h: Fix common/ includes.
2243         * remote-fileio.c: Fix common/ includes.
2244         * regcache.h: Fix common/ includes.
2245         * regcache.c: Fix common/ includes.
2246         * record-btrace.c: Fix common/ includes.
2247         * python/python.c: Fix common/ includes.
2248         * python/py-type.c: Fix common/ includes.
2249         * python/py-inferior.c: Fix common/ includes.
2250         * progspace.h: Fix common/ includes.
2251         * producer.c: Fix common/ includes.
2252         * procfs.c: Fix common/ includes.
2253         * proc-api.c: Fix common/ includes.
2254         * printcmd.c: Fix common/ includes.
2255         * ppc-linux-nat.c: Fix common/ includes.
2256         * parser-defs.h: Fix common/ includes.
2257         * osdata.c: Fix common/ includes.
2258         * obsd-nat.c: Fix common/ includes.
2259         * nat/x86-linux.c: Fix common/ includes.
2260         * nat/x86-linux-dregs.c: Fix common/ includes.
2261         * nat/x86-dregs.h: Fix common/ includes.
2262         * nat/x86-dregs.c: Fix common/ includes.
2263         * nat/ppc-linux.c: Fix common/ includes.
2264         * nat/mips-linux-watch.h: Fix common/ includes.
2265         * nat/mips-linux-watch.c: Fix common/ includes.
2266         * nat/linux-waitpid.c: Fix common/ includes.
2267         * nat/linux-ptrace.h: Fix common/ includes.
2268         * nat/linux-ptrace.c: Fix common/ includes.
2269         * nat/linux-procfs.c: Fix common/ includes.
2270         * nat/linux-personality.c: Fix common/ includes.
2271         * nat/linux-osdata.c: Fix common/ includes.
2272         * nat/linux-namespaces.c: Fix common/ includes.
2273         * nat/linux-btrace.h: Fix common/ includes.
2274         * nat/linux-btrace.c: Fix common/ includes.
2275         * nat/fork-inferior.c: Fix common/ includes.
2276         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2277         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2278         * nat/aarch64-linux.c: Fix common/ includes.
2279         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2280         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2281         * namespace.h: Fix common/ includes.
2282         * mips-linux-tdep.c: Fix common/ includes.
2283         * minsyms.c: Fix common/ includes.
2284         * mi/mi-parse.h: Fix common/ includes.
2285         * mi/mi-main.c: Fix common/ includes.
2286         * mi/mi-cmd-env.c: Fix common/ includes.
2287         * memrange.h: Fix common/ includes.
2288         * memattr.c: Fix common/ includes.
2289         * maint.h: Fix common/ includes.
2290         * maint.c: Fix common/ includes.
2291         * main.c: Fix common/ includes.
2292         * machoread.c: Fix common/ includes.
2293         * location.c: Fix common/ includes.
2294         * linux-thread-db.c: Fix common/ includes.
2295         * linux-nat.c: Fix common/ includes.
2296         * linux-fork.c: Fix common/ includes.
2297         * inline-frame.c: Fix common/ includes.
2298         * infrun.c: Fix common/ includes.
2299         * inflow.c: Fix common/ includes.
2300         * inferior.h: Fix common/ includes.
2301         * inferior.c: Fix common/ includes.
2302         * infcmd.c: Fix common/ includes.
2303         * inf-ptrace.c: Fix common/ includes.
2304         * inf-child.c: Fix common/ includes.
2305         * ia64-linux-nat.c: Fix common/ includes.
2306         * i387-tdep.c: Fix common/ includes.
2307         * i386-tdep.c: Fix common/ includes.
2308         * i386-linux-tdep.c: Fix common/ includes.
2309         * i386-linux-nat.c: Fix common/ includes.
2310         * i386-go32-tdep.c: Fix common/ includes.
2311         * i386-fbsd-tdep.c: Fix common/ includes.
2312         * i386-fbsd-nat.c: Fix common/ includes.
2313         * guile/scm-type.c: Fix common/ includes.
2314         * guile/guile.c: Fix common/ includes.
2315         * go32-nat.c: Fix common/ includes.
2316         * gnu-nat.c: Fix common/ includes.
2317         * gdbthread.h: Fix common/ includes.
2318         * gdbarch-selftests.c: Fix common/ includes.
2319         * gdb_usleep.c: Fix common/ includes.
2320         * gdb_select.h: Fix common/ includes.
2321         * gdb_bfd.c: Fix common/ includes.
2322         * gcore.c: Fix common/ includes.
2323         * fork-child.c: Fix common/ includes.
2324         * findvar.c: Fix common/ includes.
2325         * fbsd-nat.c: Fix common/ includes.
2326         * event-top.c: Fix common/ includes.
2327         * event-loop.c: Fix common/ includes.
2328         * dwarf2read.c: Fix common/ includes.
2329         * dwarf2loc.c: Fix common/ includes.
2330         * dwarf2-frame.c: Fix common/ includes.
2331         * dwarf-index-cache.c: Fix common/ includes.
2332         * dtrace-probe.c: Fix common/ includes.
2333         * disasm-selftests.c: Fix common/ includes.
2334         * defs.h: Fix common/ includes.
2335         * csky-tdep.c: Fix common/ includes.
2336         * cp-valprint.c: Fix common/ includes.
2337         * cp-support.h: Fix common/ includes.
2338         * cp-support.c: Fix common/ includes.
2339         * corelow.c: Fix common/ includes.
2340         * completer.h: Fix common/ includes.
2341         * completer.c: Fix common/ includes.
2342         * compile/compile.c: Fix common/ includes.
2343         * compile/compile-loc2c.c: Fix common/ includes.
2344         * compile/compile-cplus-types.c: Fix common/ includes.
2345         * compile/compile-cplus-symbols.c: Fix common/ includes.
2346         * command.h: Fix common/ includes.
2347         * cli/cli-dump.c: Fix common/ includes.
2348         * cli/cli-cmds.c: Fix common/ includes.
2349         * charset.c: Fix common/ includes.
2350         * build-id.c: Fix common/ includes.
2351         * btrace.h: Fix common/ includes.
2352         * btrace.c: Fix common/ includes.
2353         * breakpoint.h: Fix common/ includes.
2354         * breakpoint.c: Fix common/ includes.
2355         * ax.h:
2356         (enum agent_op): Fix common/ includes.
2357         * ax-general.c (struct aop_map): Fix common/ includes.
2358         * ax-gdb.c: Fix common/ includes.
2359         * auxv.c: Fix common/ includes.
2360         * auto-load.c: Fix common/ includes.
2361         * arm-tdep.c: Fix common/ includes.
2362         * arch/riscv.c: Fix common/ includes.
2363         * arch/ppc-linux-common.c: Fix common/ includes.
2364         * arch/i386.c: Fix common/ includes.
2365         * arch/arm.c: Fix common/ includes.
2366         * arch/arm-linux.c: Fix common/ includes.
2367         * arch/arm-get-next-pcs.c: Fix common/ includes.
2368         * arch/amd64.c: Fix common/ includes.
2369         * arch/aarch64.c: Fix common/ includes.
2370         * arch/aarch64-insn.c: Fix common/ includes.
2371         * arch-utils.c: Fix common/ includes.
2372         * amd64-windows-tdep.c: Fix common/ includes.
2373         * amd64-tdep.c: Fix common/ includes.
2374         * amd64-sol2-tdep.c: Fix common/ includes.
2375         * amd64-obsd-tdep.c: Fix common/ includes.
2376         * amd64-nbsd-tdep.c: Fix common/ includes.
2377         * amd64-linux-tdep.c: Fix common/ includes.
2378         * amd64-linux-nat.c: Fix common/ includes.
2379         * amd64-fbsd-tdep.c: Fix common/ includes.
2380         * amd64-fbsd-nat.c: Fix common/ includes.
2381         * amd64-dicos-tdep.c: Fix common/ includes.
2382         * amd64-darwin-tdep.c: Fix common/ includes.
2383         * agent.c: Fix common/ includes.
2384         * ada-lang.h: Fix common/ includes.
2385         * ada-lang.c: Fix common/ includes.
2386         * aarch64-tdep.c: Fix common/ includes.
2387
2388 2019-01-25  Tom Tromey  <tom@tromey.com>
2389
2390         * common/create-version.sh: Use common/version.h.
2391
2392 2019-01-24  Pedro Alves  <palves@redhat.com>
2393
2394         * infrun.c (signal_stop, signal_print, signal_program)
2395         (signal_catch, signal_pass): Now arrays instead of pointers.
2396         (update_signals_program_target, do_target_resume)
2397         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2398         * linux-nat.c (linux_nat_target::pass_signals)
2399         (linux_nat_target::create_inferior, linux_nat_target::attach):
2400         Adjust.
2401         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2402         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2403         * procfs.c (procfs_target::pass_signals): Adjust.
2404         * record-full.c (record_full_target::resume): Adjust.
2405         * remote.c (remote_target::pass_signals)
2406         (remote_target::program_signals): Adjust.
2407         * target-debug.h (target_debug_print_signals): Now takes a
2408         gdb::array_view as parameter.  Adjust.
2409         * target.h (target_ops) <pass_signals, program_signals>: Replace
2410         pointer and length parameters with gdb::array_view.
2411         (target_pass_signals, target_program_signals): Likewise.
2412         * target-delegates.c: Regenerate.
2413
2414 2019-01-24  Pedro Alves  <palves@redhat.com>
2415
2416         * common/forward-scope-exit.h
2417         (forward_scope_exit::forward_scope_exit): Pass arguments to
2418         m_bind_function directly, instead of creating a std::bind and
2419         copying that.
2420
2421 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2422
2423         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2424         for static members.
2425         (pass_in_v_vfp_candidate): Likewise.
2426
2427 2019-01-23  Tom Tromey  <tom@tromey.com>
2428             Pedro Alves  <palves@redhat.com>
2429
2430         * regcache.c (class regcache_invalidator): Remove.
2431         (regcache::raw_write): Use make_scope_exit.
2432
2433 2019-01-23  Tom Tromey  <tom@tromey.com>
2434
2435         * ui-out.h (class ui_out_emit_type): Update comment.
2436
2437 2019-01-23  Tom Tromey  <tom@tromey.com>
2438
2439         * infrun.c (fetch_inferior_event): Update comment.
2440
2441 2019-01-23  Tom Tromey  <tom@tromey.com>
2442             Pedro Alves  <palves@redhat.com>
2443
2444         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2445         parameter.
2446         (fetch_inferior_event): Use SCOPE_EXIT.
2447
2448
2449 2019-01-23  Tom Tromey  <tom@tromey.com>
2450             Pedro Alves  <palves@redhat.com>
2451
2452         * infrun.c (disable_thread_events): Delete.
2453         (stop_all_threads): Use SCOPE_EXIT.
2454
2455 2019-01-23  Tom Tromey  <tom@tromey.com>
2456             Pedro Alves  <palves@redhat.com>
2457
2458         * symfile.c: Include forward-scope-exit.h.
2459         (clear_symtab_users_cleanup): Replace forward declaration with
2460         a FORWARD_SCOPE_EXIT.
2461         (syms_from_objfile_1): Use the forward_scope_exit and
2462         gdb::optional instead of cleanup_function.
2463         (reread_symbols): Use the forward_scope_exit instead of
2464         cleanup_function.
2465         (clear_symtab_users_cleanup): Remove function.
2466
2467 2019-01-23  Tom Tromey  <tom@tromey.com>
2468             Pedro Alves  <palves@redhat.com>
2469
2470         * linux-nat.c: Include scope-exit.h.
2471         (cleanup_target_stop): Remove.
2472         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2473         SCOPE_EXIT.
2474
2475 2019-01-23  Tom Tromey  <tom@tromey.com>
2476             Pedro Alves  <palves@redhat.com>
2477
2478         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2479         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2480
2481 2019-01-23  Tom Tromey  <tom@tromey.com>
2482             Andrew Burgess  <andrew.burgess@embecosm.com>
2483             Pedro Alves  <palves@redhat.com>
2484
2485         * infrun.c (fetch_inferior_event): Use scope_exit.
2486         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2487         * top.c (execute_command): Use scope_exit.
2488         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2489         * utils.c (do_bpstat_clear_actions_cleanup)
2490         (make_bpstat_clear_actions_cleanup): Remove.
2491
2492 2019-01-23  Tom Tromey  <tom@tromey.com>
2493             Pedro Alves  <palves@redhat.com>
2494
2495         * infrun.c: Include "common/scope-exit.h"
2496         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2497         (wait_for_inferior): Use SCOPE_EXIT.
2498         (fetch_inferior_event): Use scope_exit.
2499
2500 2019-01-23  Tom Tromey  <tom@tromey.com>
2501             Pedro Alves  <palves@redhat.com>
2502
2503         * breakpoint.c (create_breakpoint): Remove cleanup.
2504
2505 2019-01-23  Tom Tromey  <tom@tromey.com>
2506             Andrew Burgess  <andrew.burgess@embecosm.com>
2507             Pedro Alves  <palves@redhat.com>
2508
2509 2019-01-23  Pedro Alves  <palves@redhat.com>
2510
2511         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2512
2513 2019-01-23  Pedro Alves  <palves@redhat.com>
2514             Andrew Burgess  <andrew.burgess@embecosm.com>
2515
2516         * gdbthread.h: Include "common/forward-scope-exit.h".
2517         (scoped_finish_thread_state): Redefine custom class in terms of
2518         forward_scope_exit.
2519
2520 2019-01-23  Pedro Alves  <palves@redhat.com>
2521             Andrew Burgess  <andrew.burgess@embecosm.com>
2522
2523         * common/forward-scope-exit.h: New file.
2524
2525 2019-01-23  Pedro Alves  <palves@redhat.com>
2526             Andrew Burgess  <andrew.burgess@embecosm.com>
2527             Tom Tromey  <tom@tromey.com>
2528
2529         * common/scope-exit.h: New file.
2530
2531 2019-01-23  Pedro Alves  <palves@redhat.com>
2532
2533         * common/preprocessor.h (ESC): Rename to ...
2534         (ESC_PARENS): ... this.
2535         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2536         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2537
2538 2019-01-23  Tom Tromey  <tom@tromey.com>
2539
2540         * language.h (class scoped_switch_to_sym_language_if_auto):
2541         Initialize m_lang in both cases.
2542
2543 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2544
2545         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2546         with XCNEW.
2547
2548 2019-01-22  Tom Tromey  <tom@tromey.com>
2549
2550         * corelow.c: Do not include sys/file.h.
2551
2552 2019-01-22  Tom Tromey  <tom@tromey.com>
2553
2554         * tui/tui-wingeneral.h: Include gdb_curses.h.
2555
2556 2019-01-22  Tom Tromey  <tom@tromey.com>
2557
2558         * source-cache.h (class source_cache) <get_source_lines,
2559         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2560
2561 2019-01-22  Tom Tromey  <tom@tromey.com>
2562
2563         * remote-fileio.h (struct remote_target): Declare.
2564
2565 2019-01-22  Tom Tromey  <tom@tromey.com>
2566
2567         * python/py-arch.c: Do not include py-ref.h.
2568         * python/py-bpevent.c: Do not include py-ref.h.
2569         * python/py-cmd.c: Do not include py-ref.h.
2570         * python/py-continueevent.c: Do not include py-ref.h.
2571         * python/py-event.h: Do not include py-ref.h.
2572         * python/py-evtregistry.c: Do not include py-ref.h.
2573         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2574         * python/py-frame.c: Do not include py-ref.h.
2575         * python/py-framefilter.c: Do not include py-ref.h.
2576         * python/py-function.c: Do not include py-ref.h.
2577         * python/py-infevents.c: Do not include py-ref.h.
2578         * python/py-linetable.c: Do not include py-ref.h.
2579         * python/py-objfile.c: Do not include py-ref.h.
2580         * python/py-param.c: Do not include py-ref.h.
2581         * python/py-prettyprint.c: Do not include py-ref.h.
2582         * python/py-progspace.c: Do not include py-ref.h.
2583         * python/py-symbol.c: Do not include py-ref.h.
2584         * python/py-symtab.c: Do not include py-ref.h.
2585         * python/py-type.c: Do not include py-ref.h.
2586         * python/py-unwind.c: Do not include py-ref.h.
2587         * python/py-utils.c: Do not include py-ref.h.
2588         * python/py-value.c: Do not include py-ref.h.
2589         * python/py-varobj.c: Do not include py-ref.h.
2590         * python/py-xmethods.c: Do not include py-ref.h.
2591         * python/python.c: Do not include py-ref.h.
2592         * varobj.c: Do not include py-ref.h.
2593
2594 2019-01-22  Tom Tromey  <tom@tromey.com>
2595
2596         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2597         keyword for bcache.
2598
2599 2019-01-22  Tom Tromey  <tom@tromey.com>
2600
2601         * compile/compile-cplus-types.c: Remove a comment by #include.
2602
2603 2019-01-22  Tom Tromey  <tom@tromey.com>
2604
2605         * compile/gcc-c-plugin.h: Include compile-internal.h.
2606
2607 2019-01-22  Tom Tromey  <tom@tromey.com>
2608
2609         * stabsread.c (EXTERN): Do not define.
2610         (symnum, next_symbol_text_func, processing_gcc_compilation)
2611         (within_function, global_sym_chain, global_stabs)
2612         (previous_stab_code, this_object_header_files)
2613         (n_this_object_header_files)
2614         (n_allocated_this_object_header_files): Define.
2615         * stabsread.h (EXTERN): Never define.  Use "extern".
2616
2617 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2618
2619         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2620         history_value.
2621
2622 2019-01-21  Tom Tromey  <tom@tromey.com>
2623
2624         * ui-out.c: Fix includes.
2625         * tui/tui-source.c: Fix includes.
2626         * target.c: Fix includes.
2627         * remote.c: Fix includes.
2628         * regcache.c: Fix includes.
2629         * python/py-block.c: Fix includes.
2630         * printcmd.c: Fix includes.
2631         * or1k-tdep.c: Fix includes.
2632         * mi/mi-main.c: Fix includes.
2633         * m32r-tdep.c: Fix includes.
2634         * csky-tdep.c: Fix includes.
2635         * compile/compile-cplus-types.c: Fix includes.
2636         * cli/cli-interp.c: Fix includes.
2637
2638 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2639
2640         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2641         for padding.
2642
2643 2019-01-16  Tom Tromey  <tom@tromey.com>
2644
2645         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2646         earlier.
2647         (struct objfile) <msymbols_range>: Move from top level.
2648         <msymbols>: New method.
2649         (class objfile_msymbols): Remove.
2650         * symtab.c (default_collect_symbol_completion_matches_break_on):
2651         Update.
2652         * symmisc.c (dump_msymbols): Update.
2653         * stabsread.c (scan_file_globals): Update.
2654         * objc-lang.c (info_selectors_command, info_classes_command)
2655         (find_methods): Update.
2656         * minsyms.c (find_solib_trampoline_target): Update.
2657         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2658         * coffread.c (coff_symfile_read): Update.
2659         * ada-lang.c (ada_lookup_simple_minsym)
2660         (ada_collect_symbol_completion_matches): Update.
2661
2662 2019-01-16  Tom Tromey  <tom@tromey.com>
2663
2664         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2665         type.  Remove no-argument constructor.
2666         <iterator::operator++>: Simplify.
2667         <begin>: Update.
2668         <end>: Use minimal_symbol_count.
2669
2670 2019-01-16  Tom Tromey  <tom@tromey.com>
2671
2672         * objfiles.h (struct objfile) <psymtabs>: New method.
2673         (class objfile_psymtabs): Remove.
2674         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2675         typedef.
2676         <range>: New method.
2677         (require_partial_symbols): Change return type.
2678         * psymtab.c (require_partial_symbols)
2679         (psym_expand_symtabs_matching): Update.
2680         * mdebugread.c (parse_partial_symbols): Update.
2681         * dbxread.c (dbx_end_psymtab): Update.
2682
2683 2019-01-15  Tom Tromey  <tom@tromey.com>
2684
2685         * symtab.c (lookup_objfile_from_block)
2686         (lookup_symbol_in_objfile_symtabs)
2687         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2688         (find_line_symtab, info_sources_command)
2689         (default_collect_symbol_completion_matches_break_on)
2690         (make_source_files_completion_list): Update.
2691         * symmisc.c (print_objfile_statistics, dump_objfile)
2692         (maintenance_print_symbols, maintenance_info_symtabs)
2693         (maintenance_check_symtabs, maintenance_info_line_tables):
2694         Update.
2695         * source.c (select_source_symtab)
2696         (forget_cached_source_info_for_objfile): Update.
2697         * objfiles.h (class objfile_compunits): Remove.
2698         (struct objfile) <compunits_range>: New typedef.
2699         (compunits): New method.
2700         * objfiles.c (objfile_relocate1): Update.
2701         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2702         * maint.c (count_symtabs_and_blocks): Update.
2703         * linespec.c (iterate_over_all_matching_symtabs): Update.
2704         * cp-support.c (add_symbol_overload_list_qualified): Update.
2705         * coffread.c (coff_symtab_read): Update.
2706         * ada-lang.c (add_nonlocal_symbols)
2707         (ada_collect_symbol_completion_matches)
2708         (ada_add_global_exceptions): Update.
2709
2710 2019-01-15  Tom Tromey  <tom@tromey.com>
2711
2712         * progspace.h (program_space) <objfiles_safe_range>: New
2713         typedef.
2714         <objfiles_safe>: New method.
2715         * objfiles.h (class all_objfiles_safe): Remove.
2716         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2717         * jit.c (jit_inferior_exit_hook): Update.
2718
2719 2019-01-17  Tom Tromey  <tom@tromey.com>
2720
2721         * progspace.h (program_space) <objfiles_range>: New typedef.
2722         <objfiles>: New method.
2723         <objfiles_head>: Rename from objfiles.
2724         (object_files): Update.
2725         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2726         * guile/scm-pretty-print.c
2727         (ppscm_find_pretty_printer_from_objfiles): Update.
2728         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2729         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2730         Update.
2731         * python/py-progspace.c (pspy_get_objfiles): Update.
2732         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2733         Update.
2734         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2735         (objfpy_lookup_objfile_by_build_id): Update.
2736         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2737         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2738         Update.
2739         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2740         (expand_symtab_containing_pc, lookup_objfile_from_block)
2741         (lookup_static_symbol, basic_lookup_transparent_type)
2742         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2743         (find_line_symtab, info_sources_command)
2744         (default_collect_symbol_completion_matches_break_on)
2745         (make_source_files_completion_list, find_main_name): Update.
2746         * symmisc.c (print_symbol_bcache_statistics)
2747         (print_objfile_statistics, maintenance_print_symbols)
2748         (maintenance_print_msymbols, maintenance_print_objfiles)
2749         (maintenance_info_symtabs, maintenance_check_symtabs)
2750         (maintenance_expand_symtabs, maintenance_info_line_tables):
2751         Update.
2752         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2753         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2754         (map_overlay_command, unmap_overlay_command)
2755         (simple_overlay_update, expand_symtabs_matching)
2756         (map_symbol_filenames): Update.
2757         * symfile-debug.c (set_debug_symfile): Update.
2758         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2759         Update.
2760         * source.c (select_source_symtab, forget_cached_source_info):
2761         Update.
2762         * solib.c (solib_read_symbols): Update.
2763         * solib-spu.c (append_ocl_sos): Update.
2764         * psymtab.c (maintenance_print_psymbols)
2765         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2766         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2767         * printcmd.c (info_symbol_command): Update.
2768         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2769         Update.
2770         * objfiles.h (class all_objfiles): Remove.
2771         * objfiles.c (have_partial_symbols, have_full_symbols)
2772         (have_minimal_symbols, qsort_cmp, update_section_map)
2773         (shared_objfile_contains_address_p)
2774         (default_iterate_over_objfiles_in_search_order): Update.
2775         * objc-lang.c (info_selectors_command, info_classes_command)
2776         (find_methods): Update.
2777         * minsyms.c (find_solib_trampoline_target): Update.
2778         * maint.c (maintenance_info_sections)
2779         (maintenance_translate_address, count_symtabs_and_blocks):
2780         Update.
2781         * main.c (captured_main_1): Update.
2782         * linux-thread-db.c (try_thread_db_load_from_pdir)
2783         (has_libpthread): Update.
2784         * linespec.c (iterate_over_all_matching_symtabs)
2785         (search_minsyms_for_name): Update.
2786         * jit.c (jit_find_objf_with_entry_addr): Update.
2787         * hppa-tdep.c (find_unwind_entry)
2788         (hppa_lookup_stub_minimal_symbol): Update.
2789         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2790         Update.
2791         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2792         (elf_gnu_ifunc_resolve_by_got): Update.
2793         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2794         * dwarf-index-write.c (save_gdb_index_command): Update.
2795         * cp-support.c (add_symbol_overload_list_qualified): Update.
2796         * breakpoint.c (create_overlay_event_breakpoint)
2797         (create_longjmp_master_breakpoint)
2798         (create_std_terminate_master_breakpoint)
2799         (create_exception_master_breakpoint): Update.
2800         * blockframe.c (find_pc_partial_function): Update.
2801         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2802         (ada_collect_symbol_completion_matches)
2803         (ada_add_global_exceptions): Update.
2804
2805 2019-01-17  Tom Tromey  <tom@tromey.com>
2806
2807         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2808         declare VEC.
2809         (solib_target_parse_libraries): Change return type.
2810         (library_list_start_segment, library_list_start_section)
2811         (library_list_end_library, library_list_start_library); Update.
2812         (solib_target_free_library_list): Remove.
2813         (solib_target_parse_libraries): Remove cleanup.  Change return
2814         type.
2815         (solib_target_current_sos): Update.
2816
2817 2019-01-17  Tom Tromey  <tromey@bapiya>
2818
2819         * valprint.c: Replace "the the" with "the".
2820         * symtab.c: Replace "the the" with "the".
2821         * solib.c: Replace "the the" with "the".
2822         * solib-dsbt.c: Replace "the the" with "the".
2823         * linespec.c: Replace "the the" with "the".
2824         * dwarf2loc.h: Replace "the the" with "the".
2825         * amd64-windows-tdep.c: Replace "the the" with "the".
2826         * aarch64-tdep.c: Replace "the the" with "the".
2827
2828 2019-01-16  Keith Seitz  <keiths@redhat.com>
2829
2830         PR gdb/23773
2831         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2832         <builder>: Rename to ..
2833         <m_builder>: ... this and make private.
2834         (dwarf2_cu::get_builder): New method.  Change all users of
2835         `builder' to use this method.
2836         (dwarf2_start_symtab): Move to ...
2837         (dwarf2_cu::start_symtab): ... here.  Update all callers
2838         (setup_type_unit_groups): Move to ...
2839         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2840         callers.
2841         (dwarf2_cu::reset_builder): New method.
2842         (process_full_compunit, process_full_type_unit): Use
2843         dwarf2_cu::reset_builder.
2844         (follow_die_offset): Record the ancestor CU if it is different
2845         from the followed DIE's CU.
2846         (follow_die_sig_1): Likewise.
2847
2848 2019-01-15  Tom Tromey  <tom@tromey.com>
2849
2850         * remote.c (class remote_state) <buf>: Now a char_vector.
2851         <buf_size>: Remove.
2852         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2853         parameter.
2854         (remote_target::getpkt_or_notif_sane_1)
2855         (remote_target::getpkt_sane)
2856         (remote_target::getpkt_or_notif_sane): Likewise.
2857         (class remote_target) <putpkt>: New overload.
2858         (remote_target::read_frame): Change type of "buf_p".  Remove
2859         sizeof_p parameter.
2860         (packet_ok): New overload.
2861         (packet_check_result): New overload.
2862         Update all uses.
2863
2864 2019-01-14  Tom Tromey  <tom@tromey.com>
2865
2866         * remote-notif.c (handle_notification, remote_notif_ack)
2867         (remote_notif_parse): Make "buf" const.
2868         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2869         const.
2870         (remote_notif_parse, remote_notif_ack, handle_notification):
2871         Likewise.
2872         * remote.c (remote_notif_stop_parse): Make "buf" const.
2873         (remote_target::remote_parse_stop_reply): Make "buf" const.
2874         (remote_notif_stop_ack): Make "buf" const.
2875
2876 2019-01-14  Tom Tromey  <tom@tromey.com>
2877
2878         * remote.c (remote_console_output): Make parameter const.
2879
2880 2019-01-14  Tom Tromey  <tom@tromey.com>
2881
2882         * target-debug.h (target_debug_print_signals): Constify.
2883         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2884         * procfs.c (procfs_target::pass_signals): Update.
2885         * linux-nat.c (linux_nat_target::pass_signals): Update.
2886         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2887         * target-delegates.c: Rebuild.
2888         * remote.c (remote_target::program_signals): Update.
2889         (remote_target::pass_signals): Update.
2890         * target.c (target_pass_signals): Constify argument.
2891         (target_program_signals): Likewise.
2892         * target.h (struct target_ops) <pass_signals, program_signals>:
2893         Constify argument.
2894         (target_pass_signals, target_program_signals): Constify argument.
2895
2896 2019-01-14  Tom Tromey  <tom@tromey.com>
2897
2898         PR tui/28819:
2899         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2900
2901 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2902
2903         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2904         field.
2905         * rs6000-tdep.c: Include reggroups.h.
2906         (IS_V_ALIAS_PSEUDOREG): Define.
2907         (rs6000_register_name): Return names for the "vX" aliases.
2908         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2909         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2910         aliases.  Call default_register_reggroup_p for all other
2911         pseudo-registers.
2912         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2913         New functions.
2914         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2915         Handle "vX" aliases.
2916         (v_alias_pseudo_register_collect): New function.
2917         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2918         (rs6000_gdbarch_init): Initialize "vX" aliases as
2919         pseudo-registers.  Restore registration of
2920         rs6000_pseudo_register_reggroup_p with
2921         set_tdesc_pseudo_register_reggroup_p.
2922
2923 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2924
2925         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2926         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2927         set_gdbarch_num_pseudo_regs.
2928
2929 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2930
2931         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2932         Remove arg prefixname, add do_set and do_show.
2933         Add member functions set_list and show_list.
2934         * cli/cli-style.c (class cli_style_option): Update accordingly.
2935         (style_set_list): Move to file scope.
2936         (style_show_list): Likewise.
2937         (set_style): Call help_list.
2938         (show_style): Call cmd_show_list.
2939         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2940         Update to use the new macro.
2941
2942 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2943
2944         * ada-lang.c (_initialize_ada_language): Expand the help text
2945         for the "catch exception" command.
2946
2947 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2948
2949         * symtab.c (matching_obj_sections): Initialize obj,
2950         declare it closer to its usage.
2951
2952 2019-01-10  Tom Tromey  <tom@tromey.com>
2953
2954         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2955         (basic_inf_threads_range): Remove.
2956         (inf_threads_range, inf_non_exited_threads_range)
2957         (safe_inf_threads_range): Use next_adapter.
2958
2959 2019-01-10  Keith Seitz  <keiths@redhat.com>
2960
2961         PR gdb/23712
2962         PR symtab/23010
2963         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2964         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2965
2966 2019-01-10  Keith Seitz  <keiths@redhat.com>
2967
2968         PR gdb/23712
2969         PR symtab/23010
2970         * dictionary.c (pending_to_vector): Remove.
2971         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2972         Remove _1 suffix, replacing functions of the same name.  Update
2973         all callers.
2974         (dict_create_hashed, dict_create_hashed_expandable)
2975         (dict_create_linear, dict_create_linear_expandable, dict_free)
2976         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2977         Make functions static.
2978
2979 2019-01-10  Keith Seitz  <keiths@redhat.com>
2980
2981         PR gdb/23712
2982         PR symtab/23010
2983         * dictionary.h (struct dictionary): Replace declaration with
2984         multidictionary.
2985         (dict_create_hashed, dict_create_hashed_expandable)
2986         (dict_create_linear, dict_create_linear_expandable)
2987         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2988         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2989         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2990         taking multidictionary argument.
2991         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2992         * block.h (struct block) <dict>: Change to multidictionary
2993         and rename `multidict'.
2994         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2995         symmisc.c: Update all dictionary references to multidictionary.
2996
2997 2019-01-10  Keith Seitz  <keiths@redhat.com>
2998
2999         PR gdb/23712
3000         PR symtab/23010
3001         * dictionary.c: Include unordered_map.
3002         (pending_to_vector): New function.
3003         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3004         Rewrite the non-"_1" functions to take vector instead
3005         of linked list.
3006         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
3007         "new" _1 versions of the same name.
3008         (multidictionary): Define.
3009         (std::hash<enum language): New definition.
3010         (collate_pending_symbols_by_language, mdict_create_hashed)
3011         (mdict_create_hashed_expandable, mdict_create_linear)
3012         (mdict_create_linear_expandable, mdict_free)
3013         (find_language_dictionary, create_new_language_dictionary)
3014         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
3015         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
3016         (mdict_size, mdict_empty): New functions.
3017         * dictionary.h (mdict_iterator): Define.
3018
3019 2019-01-10  Pedro Alves  <palves@redhat.com>
3020
3021         * breakpoint.c (read_uploaded_action)
3022         (create_tracepoint_from_upload): Adjust to use
3023         gdb::unique_xmalloc_ptr.
3024         * ctf.c (ctf_write_uploaded_tp):
3025         (SET_ARRAY_FIELD): Use emplace_back.
3026         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
3027         * tracefile-tfile.c (tfile_write_uploaded_tp):
3028         * tracepoint.c (parse_tracepoint_definition): Adjust to use
3029         gdb::unique_xmalloc_ptr.
3030         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
3031         at_string, cond_string, cmd_strings>: Replace char pointers
3032         with gdb::unique_xmalloc_ptr.
3033
3034 2019-01-10  Pedro Alves  <palves@redhat.com>
3035
3036         * solib-target.c (library_list_start_library): Don't xstrdup name.
3037
3038 2019-01-10  Pedro Alves  <palves@redhat.com>
3039
3040         * mdebugread.c (parse_partial_symbols): Use
3041         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3042
3043 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3044
3045         * linux-fork.c (scoped_switch_fork_info)
3046         <~scoped_switch_fork_info>: Fix incorrect variable name.
3047
3048 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3049
3050         * linux-fork.c (scoped_switch_fork_info)
3051         <scoped_switch_fork_info>: Make explicit.
3052         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3053
3054 2019-01-10  Tom Tromey  <tom@tromey.com>
3055
3056         * objfiles.h (objfile::reset_psymtabs): Update.
3057         * objfiles.c (objfile::objfile): Update.
3058         * psymtab.h (psymtab_storage::obstack): Update.
3059         (psymtab_storage::m_obstack): Use gdb::optional.
3060         (class psymtab_storage): Update comment.  Remove objfile
3061         parameter.
3062         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3063
3064 2019-01-10  Tom Tromey  <tom@tromey.com>
3065
3066         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3067         <free_psymtabs>: Now private.
3068         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3069         (allocate_psymtab): Use new method.
3070
3071 2019-01-10  Tom Tromey  <tom@tromey.com>
3072
3073         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3074         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3075         * mdebugread.c (parse_partial_symbols): Use
3076         allocate_dependencies.
3077         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3078         allocate_dependencies.
3079         (process_psymtab_comp_unit_reader)
3080         (build_type_psymtab_dependencies): Likewise.
3081         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3082
3083 2019-01-10  Tom Tromey  <tom@tromey.com>
3084
3085         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3086         PSYMBOL_SET_LANGUAGE.
3087         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3088
3089 2019-01-10  Tom Tromey  <tom@tromey.com>
3090
3091         * psymtab.h (psymtab_storage::obstack): New method.
3092         <m_obstack>: Rename from obstack; now private.
3093         * psymtab.c (psymtab_storage): Update.
3094         * dwarf2read.c (create_addrmap_from_index)
3095         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3096         Update.
3097
3098 2019-01-10  Tom Tromey  <tom@tromey.com>
3099
3100         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3101         * objfiles.h (objfile::reset_psymtabs): New method.
3102
3103 2019-01-10  Tom Tromey  <tom@tromey.com>
3104
3105         * symmisc.c (print_symbol_bcache_statistics): Update.
3106         (print_objfile_statistics): Update.
3107         * symfile.c (reread_symbols): Update.
3108         * psymtab.h (class psymtab_storage): New.
3109         * psymtab.c (psymtab_storage): New constructor.
3110         (~psymtab_storage): New destructor.
3111         (require_partial_symbols): Update.
3112         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3113         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3114         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3115         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3116         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3117         (start_psymtab_common, end_psymtab_common)
3118         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3119         (allocate_psymtab): Update.
3120         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3121         Update.
3122         (dump_psymtab_addrmap, maintenance_print_psymbols)
3123         (maintenance_check_psymtabs): Update.
3124         (class objfile_psymtabs): Move to objfiles.h.
3125         * psympriv.h (discard_psymtab): Now inline.
3126         (psymtab_discarder::psymtab_discarder): Update.
3127         (psymtab_discarder::~psymtab_discarder): Update.
3128         (ALL_OBJFILE_PSYMTABS): Rewrite.
3129         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3130         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3131         Remove fields.
3132         <partial_symtabs>: New field.
3133         (class objfile_psymtabs): Move from psymtab.h.  Update.
3134         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3135         psymbol_cache.
3136         (objfile::~objfile): Don't destroy psymbol_cache.
3137         * mdebugread.c (parse_partial_symbols): Update.
3138         * dwarf2read.c (create_addrmap_from_index)
3139         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3140         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3141         (add_partial_subprogram, dwarf2_ranges_read): Update.
3142         * dwarf-index-write.c (write_address_map)
3143         (write_one_signatured_type, recursively_write_psymbols)
3144         (class debug_names, class debug_names, write_psymtabs_to_index):
3145         Update.
3146
3147 2019-01-10  Tom Tromey  <tom@tromey.com>
3148
3149         * symtab.h (SYMBOL_SET_NAMES): Update.
3150         (symbol_set_names): Update.
3151         (MSYMBOL_SET_NAMES): Update.
3152         * symtab.c (symbol_set_names): Change argument to be an
3153         objfile_per_bfd_storage.
3154         * psymtab.c (add_psymbol_to_bcache): Update.
3155         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3156
3157 2019-01-10  Tom Tromey  <tom@tromey.com>
3158
3159         * symtab.c (create_demangled_names_hash): Change argument to be an
3160         objfile_per_bfd_storage.
3161         (symbol_set_names): Update.
3162
3163 2019-01-10  Tom Tromey  <tom@tromey.com>
3164
3165         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3166         init_psymbol_list.
3167         * psymtab.c (init_psymbol_list): Do nothing if already called.
3168         * psympriv.h (init_psymbol_list): Add comment.
3169         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3170         init_psymbol_list.
3171         * dbxread.c (dbx_symfile_read): Unconditionally call
3172         init_psymbol_list.
3173
3174 2019-01-10  Tom Tromey  <tom@tromey.com>
3175
3176         * xcoffread.c (scan_xcoff_symtab): Update.
3177         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3178         "where".
3179         * mdebugread.c (parse_partial_symbols)
3180         (handle_psymbol_enumerators): Update.
3181         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3182         * dbxread.c (read_dbx_symtab): Update.
3183         * psympriv.h (psymbol_placement): New enum.
3184         (add_psymbol_to_list): Update.
3185
3186 2019-01-10  Tom Tromey  <tom@tromey.com>
3187
3188         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3189         static_psymbols parameters.
3190         (scan_xcoff_symtab): Update.
3191         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3192         static_psymbols parameters.
3193         * psympriv.h (start_psymtab_common): Update.
3194         * mdebugread.c (parse_partial_symbols): Update.
3195         * dwarf2read.c (create_partial_symtab): Update.
3196         * dbxread.c (read_dbx_symtab): Update.
3197         (start_psymtab): Remove global_psymbols and static_psymbols
3198         parameters.
3199
3200 2019-01-10  Tom Tromey  <tom@tromey.com>
3201
3202         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3203         * psymtab.c (allocate_psymtab): Add comment.
3204         * psympriv.h (allocate_psymtab): Add comment.
3205         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3206         initializations.
3207         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3208
3209 2019-01-10  Tom Tromey  <tom@tromey.com>
3210
3211         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3212         Don't declare.
3213         * mipsread.c: Include mdebugread.h.
3214         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3215         Declare.
3216         * elfread.c: Include mdebugread.h.
3217
3218 2019-01-09  Tom Tromey  <tom@tromey.com>
3219
3220         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3221         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3222         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3223         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3224         (psym_lookup_symbol, psym_find_last_source_symtab)
3225         (psym_forget_cached_source_info, psym_print_stats)
3226         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3227         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3228         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3229         (psym_find_compunit_symtab_by_address)
3230         (maintenance_print_psymbols, maintenance_info_psymtabs)
3231         (maintenance_check_psymtabs): Use ranged for.
3232         * psymtab.h (class objfile_psymtabs): New.
3233         (require_partial_symbols): Return objfile_psymtabs.
3234         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3235
3236 2019-01-09  Tom Tromey  <tom@tromey.com>
3237
3238         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3239         (find_pc_mapped_section, list_overlays_command)
3240         (map_overlay_command, unmap_overlay_command)
3241         (simple_overlay_update): Use all_objfiles.
3242         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3243         * printcmd.c (info_symbol_command): Use all_objfiles.
3244         * objfiles.h (ALL_OBJSECTIONS): Remove.
3245         * maint.c (maintenance_translate_address): Use all_objfiles.
3246         * gcore.c (gcore_create_callback): Use all_objfiles.
3247         (objfile_find_memory_regions): Likewise.
3248
3249 2019-01-09  Tom Tromey  <tom@tromey.com>
3250
3251         * symtab.c (find_line_symtab, info_sources_command)
3252         (make_source_files_completion_list): Use objfile_compunits.
3253         * source.c (select_source_symtab): Use objfile_compunits.
3254         * objfiles.h (struct objfile): Update comment.
3255         (ALL_OBJFILES): Remove.
3256         (ALL_FILETABS): Remove.
3257         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3258         objfile_compunits.
3259
3260 2019-01-09  Tom Tromey  <tom@tromey.com>
3261
3262         * symmisc.c (print_objfile_statistics, dump_objfile)
3263         (maintenance_print_symbols): Use compunit_filetabs.
3264         * source.c (forget_cached_source_info_for_objfile): Use
3265         compunit_filetabs.
3266         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3267         (ALL_FILETABS): Use compunit_filetabs.
3268         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3269         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3270
3271 2019-01-09  Tom Tromey  <tom@tromey.com>
3272
3273         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3274         (compunit_filetabs): New.
3275         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3276         compunit_filetabs.
3277         (info_sources_command, make_source_files_completion_list): Remove
3278         declaration.
3279         * symmisc.c (print_objfile_statistics, dump_objfile)
3280         (maintenance_print_symbols): Remove declaration.
3281         (maintenance_info_symtabs): Use compunit_filetabs.
3282         (maintenance_info_line_tables): Likewise.
3283         * source.c (select_source_symtab): Change local variable name.
3284         (forget_cached_source_info_for_objfile): Remove declaration.
3285         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3286         * objfiles.c (objfile_relocate1): Remove declaration.
3287         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3288         declaration.
3289         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3290         * coffread.c (coff_symtab_read): Remove declaration.
3291         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3292         compunit_filetabs.
3293
3294 2019-01-09  Tom Tromey  <tom@tromey.com>
3295
3296         * symtab.c (lookup_objfile_from_block)
3297         (find_pc_sect_compunit_symtab, search_symbols)
3298         (default_collect_symbol_completion_matches_break_on): Use
3299         objfile_compunits.
3300         * objfiles.h (ALL_COMPUNITS): Remove.
3301         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3302         * cp-support.c (add_symbol_overload_list_qualified): Use
3303         objfile_compunits.
3304         * ada-lang.c (ada_collect_symbol_completion_matches)
3305         (ada_add_global_exceptions): Use objfile_compunits.
3306
3307 2019-01-09  Tom Tromey  <tom@tromey.com>
3308
3309         * source.c (select_source_symtab)
3310         (forget_cached_source_info_for_objfile): Remove declaration.
3311         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3312         declaration.
3313         * maint.c (count_symtabs_and_blocks): Remove declaration.
3314         * cp-support.c (add_symbol_overload_list_qualified): Remove
3315         declaration.
3316         * coffread.c (coff_symtab_read): Remove declaration.
3317         * symtab.c (lookup_symbol_in_objfile_symtabs)
3318         (basic_lookup_transparent_type_1): Use objfile_compunits.
3319         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3320         (info_sources_command, search_symbols)
3321         (default_collect_symbol_completion_matches_break_on)
3322         (make_source_files_completion_list): Remove declaration.
3323         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3324         (ada_collect_symbol_completion_matches)
3325         (ada_add_global_exceptions): Remove declaration.
3326         * linespec.c (iterate_over_all_matching_symtabs): Use
3327         objfile_compunits.
3328         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3329         (class objfile_compunits): New.
3330         (ALL_COMPUNITS): Use objfile_compunits.
3331         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3332         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3333         objfile_compunits.
3334         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3335
3336 2019-01-09  Tom Tromey  <tom@tromey.com>
3337
3338         * symtab.c (search_symbols)
3339         (default_collect_symbol_completion_matches_break_on): Use
3340         objfile_msymbols.
3341         * ada-lang.c (ada_lookup_simple_minsym)
3342         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3343         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3344         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3345         objfile_msymbols.
3346         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3347         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3348         * objc-lang.c (find_methods): Use objfile_msymbols.
3349         (info_selectors_command, info_classes_command): Likewise.
3350         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3351         * objfiles.h (class objfile_msymbols): New.
3352         (ALL_OBJFILE_MSYMBOLS): Remove.
3353         (ALL_MSYMBOLS): Remove.
3354
3355 2019-01-09  Tom Tromey  <tom@tromey.com>
3356
3357         * common/next-iterator.h (next_adapter): Add Iterator template
3358         parameter.
3359         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3360         (class all_objfiles_safe): New.
3361         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3362         * objfiles.c (put_objfile_before): Update comment.
3363         (add_separate_debug_objfile): Likewise.
3364         (free_all_objfiles): Use all_objfiles_safe.
3365         (objfile_purge_solibs): Likewise.
3366
3367 2019-01-09  Tom Tromey  <tom@tromey.com>
3368
3369         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3370         (expand_symtab_containing_pc, lookup_static_symbol)
3371         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3372         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3373         all_objfiles.
3374         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3375         * breakpoint.c (create_overlay_event_breakpoint)
3376         (create_longjmp_master_breakpoint)
3377         (create_std_terminate_master_breakpoint)
3378         (create_exception_master_breakpoint): Use all_objfiles.
3379         * linux-thread-db.c (try_thread_db_load_from_pdir)
3380         (has_libpthread): Use all_objfiles.
3381         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3382         * linespec.c (iterate_over_all_matching_symtabs)
3383         (search_minsyms_for_name): Use all_objfiles.
3384         * maint.c (maintenance_info_sections): Use all_objfiles.
3385         * main.c (captured_main_1): Use all_objfiles.
3386         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3387         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3388         * guile/scm-pretty-print.c
3389         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3390         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3391         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3392         (maintenance_print_msymbols): Use all_objfiles.
3393         * source.c (select_source_symtab): Use all_objfiles.
3394         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3395         * symfile.c (remove_symbol_file_command)
3396         (expand_symtabs_matching, map_symbol_filenames): Use
3397         all_objfiles.
3398         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3399         all_objfiles.
3400         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3401         * objc-lang.c (find_methods): Use all_objfiles.
3402         * objfiles.c (have_partial_symbols, have_full_symbols)
3403         (have_minimal_symbols, qsort_cmp)
3404         (default_iterate_over_objfiles_in_search_order): Use
3405         all_objfiles.
3406         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3407         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3408         (maintenance_check_psymtabs): Use all_objfiles.
3409         (ALL_PSYMTABS): Remove.
3410         * compile/compile-object-run.c (do_module_cleanup): Use
3411         all_objfiles.
3412         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3413         * cp-support.c (add_symbol_overload_list_qualified): Use
3414         all_objfiles.
3415         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3416         Use all_objfiles.
3417         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3418         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3419         all_objfiles.
3420         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3421         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3422         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3423         Uses all_objfiles.
3424         * solib.c (solib_read_symbols): Use all_objfiles
3425
3426 2019-01-09  Tom Tromey  <tom@tromey.com>
3427
3428         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3429         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3430         all_objfiles.
3431         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3432         * symmisc.c (print_symbol_bcache_statistics)
3433         (print_objfile_statistics, maintenance_print_objfiles)
3434         (maintenance_info_symtabs, maintenance_check_symtabs)
3435         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3436         all_objfiles.
3437         * source.c (forget_cached_source_info): Use all_objfiles.
3438         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3439         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3440         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3441         * objfiles.c (update_section_map): Use all_objfiles.
3442         (shared_objfile_contains_address_p): Likewise.
3443         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3444         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3445
3446 2019-01-09  Tom Tromey  <tom@tromey.com>
3447
3448         * common/next-iterator.h: New file.
3449         * objfiles.h (class all_objfiles): New.
3450         (struct objfile_iterator): New.
3451
3452 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3453
3454         * NEWS: Move the description of the changed "frame", "select-frame",
3455          and "info frame" commands to the Changed commands section.
3456
3457 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3458
3459         * gdbtypes.c (check_stub_method_group): Remove handling of old
3460         mangling schemes.
3461         * linespec.c (find_methods): Likewise.
3462         * stabsread.c (read_member_functions): Likewise.
3463         * valops.c (search_struct_method): Likewise.
3464         (value_struct_elt_for_reference): Likewise.
3465         * NEWS: Mention this change.
3466
3467 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3468
3469         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3470         print_source_lines.
3471         * source.c (print_source_lines_base): Update line number check.
3472         (print_source_lines): New function.
3473         (source_lines_range::source_lines_range): New function.
3474         * source.h (class source_lines_range): New class.
3475         (print_source_lines): New declaration.
3476
3477 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3478
3479         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3480
3481 2019-01-08  Tom Tromey  <tom@tromey.com>
3482             Simon Marchi  <simon.marchi@ericsson.com>
3483
3484         PR gdb/24060
3485         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3486         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3487         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3488         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3489         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3490         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3491
3492 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3493
3494         * source.c (select_source_symtab): Move header comment to
3495         declaration in source.h.
3496         (forget_cached_source_info_for_objfile): Likewise.
3497         (forget_cached_source_info): Likewise.
3498         (identify_source_line): Likewise.
3499         * source.h (identify_source_line): Move declaration from symtab.h
3500         and add comment from source.c
3501         (print_source_lines): Likewise.
3502         (forget_cached_source_info_for_objfile): Likewise.
3503         (forget_cached_source_info): Likewise.
3504         (select_source_symtab): Likewise.
3505         (enum print_source_lines_flag): Move definition from symtab.h.
3506         * symtab.h (identify_source_line): Move declaration to source.h.
3507         (print_source_lines): Likewise.
3508         (forget_cached_source_info_for_objfile): Likewise.
3509         (forget_cached_source_info): Likewise.
3510         (select_source_symtab): Likewise.
3511         (enum print_source_lines_flag): Move definition to source.h.
3512         * tui/tui-hooks.c: Add 'source.h' include.
3513
3514 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3515
3516         * source.c (print_source_lines_base): Handle requests to print
3517         reverse line number sequences, and guard against empty lines
3518         string.
3519
3520 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3521
3522         * source.c (print_source_lines_base): Fix skip of '\r' if next
3523         character is '\n'.
3524
3525 2019-01-06  Tom Tromey  <tom@tromey.com>
3526
3527         * c-exp.y (struct c_parse_state) <macro_original_text,
3528         expansion_obstack>: New member.
3529         (macro_original_text, expansion_obstack): Remove globals.
3530         (scan_macro_expansion, scanning_macro_expansion)
3531         (finished_macro_expansion): Update.
3532         (scan_macro_cleanup): Remove.
3533         (yylex, c_parse): Update.
3534
3535 2019-01-06  Tom Tromey  <tom@tromey.com>
3536
3537         * c-exp.y (struct c_parse_state) <strings>: New member.
3538         (operator_stoken): Update.
3539
3540 2019-01-06  Tom Tromey  <tom@tromey.com>
3541
3542         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3543         (union type_stack_elt) <typelist_val>: Now a pointer to
3544         std::vector.
3545         (type_stack_cleanup): Don't declare.
3546         (push_typelist): Update.
3547         * parse.c (pop_typelist): Return a std::vector.
3548         (push_typelist): Take a std::vector.
3549         (follow_types): Update.  Do not free args.
3550         (type_stack_cleanup): Remove.
3551         * c-exp.y (struct c_parse_state): New.
3552         (cpstate): New global.
3553         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3554         (nonempty_typelist): Update.
3555         (func_mod): Create a new vector.
3556         (c_parse): Create a c_parse_state.
3557         (check_parameter_typelist): Do not delete params.
3558         (function_method): Update.  Do not delete type_list.
3559
3560 2019-01-06  Tom Tromey  <tom@tromey.com>
3561
3562         PR gdb/28155:
3563         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3564         check_typedef.
3565         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3566         (print_return_value): Likewise.
3567
3568 2019-01-05  Tom Tromey  <tom@tromey.com>
3569
3570         * contrib/cleanup_check.py: Remove.
3571         * contrib/gcc-with-excheck: Remove.
3572         * contrib/exsummary.py: Remove.
3573         * contrib/excheck.py: Remove.
3574
3575 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3576
3577         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3578         NULL. Initialize tpprev to NULL instead of assigning it
3579         to NULL on the next statement.
3580         * windows-nat.c (windows_delete_thread): Remove check for
3581         main_thread_id before printing thread exit notifications.
3582         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3583         Remove thread ID check against main_thread_id.
3584         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3585         windows_delete_thread.
3586         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3587
3588 2019-01-04  Tom Tromey  <tom@tromey.com>
3589
3590         * compile/compile.c (_initialize_compile): Use upper case for
3591         metasyntactic variables.
3592         * symmisc.c (_initialize_symmisc): Use upper case for
3593         metasyntactic variables.
3594         * psymtab.c (_initialize_psymtab): Use upper case for
3595         metasyntactic variables.
3596         * demangle.c (demangle_command): Use upper case for metasyntactic
3597         variables.
3598         (_initialize_demangler): Likewise.
3599         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3600         variables.
3601
3602 2019-01-03  Tom Tromey  <tom@tromey.com>
3603
3604         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3605
3606 2019-01-03  Tom Tromey  <tom@tromey.com>
3607
3608         * python/py-symtab.c (salpy_str): Update.
3609         (struct salpy_sal_object) <symtab>: Now a PyObject.
3610         (salpy_dealloc): Update.
3611         (del_objfile_sal): Use gdbpy_ref.
3612
3613 2019-01-03  Tom Tromey  <tom@tromey.com>
3614
3615         * python/py-type.c (convert_field): Use new_reference.  Return
3616         gdbpy_ref.
3617         (make_fielditem): Return gdbpy_ref.
3618         (typy_fields): Update.
3619         (typy_getitem): Update.
3620         (field_name): Return gdbpy_ref.  Use new_reference.
3621         (typy_iterator_iternext): Update.
3622
3623 2019-01-03  Tom Tromey  <tom@tromey.com>
3624
3625         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3626
3627 2019-01-03  Tom Tromey  <tom@tromey.com>
3628
3629         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3630         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3631         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3632         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3633         (pspy_set_type_printers): Likewise.
3634         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3635         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3636         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3637         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3638         (objfpy_set_type_printers): Likewise.
3639
3640 2019-01-03  Tom Tromey  <tom@tromey.com>
3641
3642         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3643         (gdbpy_print_stack): Use gdbpy_err_fetch.
3644         * python/python-internal.h (class gdbpy_err_fetch): New class.
3645         (class gdbpy_enter) <m_error_type, m_error_value,
3646         m_error_traceback>: Remove.
3647         <m_error>: New member.
3648         (gdbpy_exception_to_string): Don't declare.
3649         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3650         * python/py-value.c (convert_value_from_python): Use
3651         gdbpy_err_fetch.
3652         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3653         gdbpy_exception_to_string.
3654         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3655         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3656         gdbpy_err_fetch.
3657
3658 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3659
3660         * linux-nat.c (delete_lwp_cleanup): Delete.
3661         (struct lwp_deleter): New struct.
3662         (lwp_info_up): New typedef.
3663         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3664         lwp_info_up.
3665
3666 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3667
3668         * linux-fork.c (class scoped_switch_fork_info): New class.
3669         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3670
3671 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3672
3673         * valops.c (find_overload_match): Remove use of null_cleanup, and
3674         calls to do_cleanups.
3675
3676 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3677
3678         * compile/compile-cplus-types.c
3679         (compile_cplus_instance::decl_name): Handle changes to
3680         cp_func_name.
3681         * cp-support.c (cp_func_name): Update header comment, update
3682         return type.
3683         * cp-support.h (cp_func_name): Update return type in declaration.
3684         * valops.c (find_overload_match): Move temp_func local to top
3685         level of function and change its type.  Use temp_func to hold and
3686         delete temporary string obtained from cp_func_name.
3687
3688 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3689
3690         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3691         gdb::char_vector, remove cleanup, and update uses of `msg`.
3692
3693 2019-01-03  Jim Wilson  <jimw@sifive.com>
3694
3695         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3696
3697 2019-01-02  Tom Tromey  <tom@tromey.com>
3698
3699         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3700         (tdesc_parse_xml): Remove cleanups.
3701         * target-descriptions.h (make_cleanup_free_target_description):
3702         Don't declare.
3703         (target_desc_deleter): New struct.
3704         (target_desc_up): New typedef.
3705         * target-descriptions.c (target_desc_deleter::operator()): Rename
3706         from free_target_description.
3707         (make_cleanup_free_target_description): Remove.
3708
3709 2019-01-02  Tom Tromey  <tom@tromey.com>
3710
3711         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3712         constructor, destructor.
3713         (linespec_parser): Remove typedef.
3714         (~linespec_parser): Rename from linespec_parser_delete.
3715         (linespec_lex_to_end, linespec_complete_label)
3716         (linespec_complete): Update.
3717         (decode_line_full): Remove cleanups.
3718         (decode_line_1): Update.
3719
3720 2019-01-02  Tom Tromey  <tom@tromey.com>
3721
3722         * python/python-internal.h (inferior_to_inferior_object): Change
3723         return type.
3724         * python/py-exitedevent.c (create_exited_event_object): Update.
3725         * python/py-inferior.c (inferior_to_inferior_object): Return
3726         gdbpy_ref.
3727         (python_new_inferior, python_inferior_deleted)
3728         (thread_to_thread_object, delete_thread_object)
3729         (build_inferior_list, gdbpy_selected_inferior): Update.
3730         * python/py-infthread.c (create_thread_object): Update.  Also fail
3731         if inferior_to_inferior_object fails.
3732
3733 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3734
3735         * inferior.h (class inferior) <displaced_step_state>: New field.
3736         * infrun.h (struct displaced_step_state): Move here from
3737         infrun.c.  Initialize fields, add constructor.
3738         <inf>: Remove field.
3739         <reset>: New method.
3740         * infrun.c (struct displaced_step_inferior_state): Move to
3741         infrun.h.
3742         (displaced_step_inferior_states): Remove.
3743         (get_displaced_stepping_state): Adust.
3744         (displaced_step_in_progress_any_inferior): Adjust.
3745         (displaced_step_in_progress_thread): Adjust.
3746         (displaced_step_in_progress): Adjust.
3747         (add_displaced_stepping_state): Remove.
3748         (get_displaced_step_closure_by_addr): Adjust.
3749         (remove_displaced_stepping_state): Remove.
3750         (infrun_inferior_exit): Call displaced_step_state.reset.
3751         (use_displaced_stepping): Don't check for NULL.
3752         (displaced_step_prepare_throw): Call
3753         get_displaced_stepping_state.
3754         (displaced_step_fixup): Don't check for NULL.
3755         (prepare_for_detach): Don't check for NULL.
3756
3757 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3758
3759         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3760          in case of call that did not complete.
3761
3762 2019-01-02  Andrey Utkin  <autkin@undo.io>
3763
3764         * symfile.c (find_separate_debug_file): Fix search of debug files for
3765         remote debuggee.
3766
3767 2019-01-02  Tom Tromey  <tom@tromey.com>
3768
3769         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3770         indentation.
3771         * python/py-frame.c (frapy_older): Remove cast.
3772         (frapy_newer): Likewise.
3773         * python/py-breakpoint.c (local_setattro): Remove cast.
3774         * python/py-arch.c (archpy_name): Remove local variable.
3775         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3776
3777 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3778
3779         * unittests/basic_string_view/element_access/char/empty.cc:
3780         Fix year range in copyright header.
3781
3782 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3783
3784         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3785         Delete.
3786         <operator==>: Update with for removed field.
3787         <hash>: Likewise.
3788         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3789         <isa_features>: ...this.
3790         <abi_features>: New field.
3791         (riscv_isa_flen): Update comment.
3792         (riscv_abi_xlen): New declaration.
3793         (riscv_abi_flen): New declaration.
3794         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3795         isa_features.
3796         (riscv_abi_xlen): New function.
3797         (riscv_isa_flen): Update to get answer from isa_features.
3798         (riscv_abi_flen): New function.
3799         (riscv_has_fp_abi): Update to get answer from abi_features.
3800         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3801         xlen and flen.
3802         (riscv_call_info) <xlen, flen>: Update comment.
3803         (riscv_call_arg_struct): Remove invalid assertions
3804         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3805         is removed.
3806         (riscv_gdbarch_init): Gather isa features and abi features
3807         separately, ensure both match on the gdbarch when reusing an old
3808         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3809         a target with 64-bit float hardware.
3810
3811 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3812
3813         * source.c (search_command_helper): Stop reverse search
3814         when line 1 has been searched.
3815
3816 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3817
3818         * record-full.c (record_full_base_target::close): Rewrite
3819         record_full_core_buf_list free logic.
3820
3821 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3822
3823         * break-catch-syscall.c (print_one_catch_syscall): xfree
3824         the last text.
3825
3826 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3827
3828         * top.c (print_gdb_version): Update Copyright year in version
3829         message.
3830
3831 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3832
3833         Update copyright year range in all GDB files.
3834
3835 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3836
3837         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3838
3839 For older changes see ChangeLog-2018.
3840 \f
3841 Local Variables:
3842 mode: change-log
3843 left-margin: 8
3844 fill-column: 74
3845 version-control: never
3846 coding: utf-8
3847 End:
3848