gdb/ChangeLog

   1 2019-07-10  Tom Tromey  <tromey@adacore.com>
   2
   3         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
   4         VEC.
   5         (struct arm_exidx_entry): New method operator<.
   6         (struct arm_exidx_data) <section_maps>: Change type.
   7         (arm_exidx_data_free): Remove.
   8         (arm_exidx_data_key): Change type.  Move lower.
   9         (arm_exidx_new_objfile): Update.
  10         (arm_compare_exidx_entries): Remove.
  11         (arm_find_exidx_entry, _initialize_arm_tdep)
  12
  13 2019-07-10  Tom Tromey  <tromey@adacore.com>
  14
  15         * solib-spu.c (ocl_program_data_key): Change type.
  16         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
  17         Update.
  18
  19 2019-07-10  Tom Tromey  <tromey@adacore.com>
  20
  21         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
  22         (struct solib_aix_inferior_data) <library_list>: Change type.
  23         (solib_aix_inferior_data_handle): Change type.
  24         (get_solib_aix_inferior_data): Update.
  25         (solib_aix_free_library_list): Remove.
  26         (library_list_start_library): Update.
  27         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
  28         return type.
  29         (solib_aix_get_library_list)
  30         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
  31         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
  32
  33 2019-07-10  Tom Tromey  <tromey@adacore.com>
  34
  35         * solib-dsbt.c (struct dsbt_info): Add initializers.
  36         (solib_dsbt_pspace_data): Change type.
  37         (dsbt_pspace_data_cleanup): Remove.
  38         (get_dsbt_info, _initialize_dsbt_solib): Update.
  39
  40 2019-07-10  Tom Tromey  <tromey@adacore.com>
  41
  42         * spu-tdep.c (spu_overlay_data): Change type.
  43         (spu_get_overlay_table, spu_overlay_new_objfile)
  44         (_initialize_spu_tdep): Update.
  45
  46 2019-07-10  Tom Tromey  <tromey@adacore.com>
  47
  48         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
  49         destructor.
  50         (dbx_objfile_data_key): Change type and declare later.
  51         (DBX_SYMFILE_INFO): Rewrite.
  52         * dbxread.c (dbx_objfile_data_key): Change type.
  53         (dbx_symfile_init): Update.
  54         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
  55         (coffstab_build_psymtabs, elfstab_build_psymtabs)
  56         (stabsect_build_psymtabs, _initialize_dbxread): Update.
  57
  58 2019-07-10  Tom Tromey  <tromey@adacore.com>
  59
  60         * jit.c (jit_program_space_key): Change type.  Move lower.
  61         (get_jit_program_space_data): Update.
  62         (jit_program_space_data_cleanup): Remove.
  63         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
  64         Update.
  65         (struct jit_program_space_data): Add initializers.
  66
  67 2019-07-10  Tom Tromey  <tromey@adacore.com>
  68
  69         * solib-darwin.c (struct darwin_info): Add initializers.
  70         (solib_darwin_pspace_data): Change type.
  71         (darwin_pspace_data_cleanup): Remove.
  72         (get_darwin_info, _initialize_darwin_solib): Update.
  73
  74 2019-07-10  Tom Tromey  <tromey@adacore.com>
  75
  76         * remote-sim.c (struct sim_inferior_data): Add initializers,
  77         constructor, and destructor.
  78         (sim_inferior_data_key): Change type.  Move lower.
  79         (check_for_duplicate_sim_descriptor): Update.
  80         (get_sim_inferior_data): Use new.  Update.
  81         (~sim_inferior_data_cleanup): Rename from
  82         sim_inferior_data_cleanup.  Simplify.
  83         (gdbsim_close_inferior, simulator_command)
  84         (sim_command_completer, _initialize_remote_sim): Update.
  85         (next_pid, INITIAL_PID): Move earlier.
  86
  87 2019-07-10  Tom Tromey  <tromey@adacore.com>
  88
  89         * python/python-internal.h (create_thread_object): Return
  90         gdbpy_ref.
  91         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
  92         * python/py-inferior.c (struct threadlist_entry): Add
  93         constructor.
  94         <thread_obj>: Now a gdbpy_ref.
  95         (thread_to_thread_object): Update.
  96         (add_thread_object): Use new.
  97         (delete_thread_object): Use delete.
  98         (infpy_threads): Update.
  99         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 100         GIL.
 101
 102 2019-07-10  Tom Tromey  <tromey@adacore.com>
 103
 104         * valops.c (value_cast): Specialize error message for Ada.
 105
 106 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 107
 108         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 109
 110 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 111
 112         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 113         bpstat_should_step): Return bool, adjust comments.
 114         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 115         bpstat_should_step): Likewise.
 116
 117 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 118
 119         * features/Makefile: Use feature target descriptions for Arm.
 120         * features/arm/arm-core.c: Generate new file.
 121         * features/arm/arm-fpa.c: Likewise.
 122         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 123         * features/arm/arm-m-profile.c: Likewise.
 124         * features/arm/arm-vfpv2.c: Likewise.
 125         * features/arm/arm-vfpv3.c: Likewise.
 126         * features/arm/xscale-iwmmxt.c: Likewise.
 127         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 128
 129 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 130
 131         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 132         ptrace earlier.
 133
 134 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 135
 136         * features/aarch64-pauth.c: Regenerate.
 137
 138 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 139
 140         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 141         bool.
 142         (bpstat_what): Use false instead of 0.
 143
 144 2019-07-09  Pedro Alves  <palves@redhat.com>
 145
 146         * break-catch-throw.c (is_exception_catchpoint): New.
 147         * breakpoint.c (print_one_breakpoint_location): New parameter
 148         'raw_loc'.  Handle it.  Use
 149         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 150         looking at the breakpoint's type.
 151         (print_one_breakpoint): If handling "maint info breakpoints", also
 152         print locations of exception catchpoints.
 153         * breakpoint.h (is_exception_catchpoint): Declare.
 154
 155 2019-07-09  Pedro Alves  <palves@redhat.com>
 156
 157         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 158         "addr" field.
 159         (allocate_location_exception_catchpoint): New.
 160         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 161         (initialize_throw_catchpoint_ops): Install
 162         allocate_location_exception_catchpoint as allocate_location
 163         method.
 164         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 165         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 166         bp_loc_other.
 167         (breakpoint_address_is_meaningful): Delete.
 168         (bl_address_is_meaningful): New.
 169         (breakpoint_locations_match): Adjust comment.
 170         (bp_location_from_bp_type): New, factored out of...
 171         (bp_location::bp_location(breakpoint *)): ... this.
 172         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 173         factored out of...
 174         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 175         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 176         breakpoint_address_is_meaningful.
 177         (bp_locations_compare): Adjust comment.
 178         (update_global_location_list): Use bl_address_is_meaningful
 179         instead of breakpoint_address_is_meaningful.
 180         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 181         explicit.
 182         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 183         * python/py-breakpoint.c (bppy_get_location): No longer check
 184         whether location is null.
 185
 186 2019-07-09  Pedro Alves  <palves@redhat.com>
 187
 188         PR c++/15468
 189         * breakpoint.c (print_one_breakpoint_location): Remove
 190         single-location assert.
 191
 192 2019-07-09  Tom Tromey  <tom@tromey.com>
 193
 194         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 195         * configure: Rebuild.
 196         * configure.ac: Change common to gdbsupport.
 197         * gdbsupport: Rename from common.
 198         * acinclude.m4: Change common to gdbsupport.
 199         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 200         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 201         gdbsupport.
 202         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 203         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 204         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 205         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 206         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 207         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 208         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 209         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 210         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 211         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 212         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 213         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 214         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 215         coff-pe-read.c, command.h, compile/compile-c-support.c,
 216         compile/compile-c.h, compile/compile-cplus-symbols.c,
 217         compile/compile-cplus-types.c, compile/compile-cplus.h,
 218         compile/compile-loc2c.c, compile/compile.c, completer.c,
 219         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 220         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 221         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 222         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 223         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 224         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 225         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 226         features/aarch64-core.c, features/aarch64-fpu.c,
 227         features/aarch64-pauth.c, features/aarch64-sve.c,
 228         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 229         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 230         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 231         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 232         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 233         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 234         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 235         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 236         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 237         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 238         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 239         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 240         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 241         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 242         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 243         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 244         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 245         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 246         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 247         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 248         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 249         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 250         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 251         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 252         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 253         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 254         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 255         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 256         minsyms.c, mips-linux-tdep.c, namespace.h,
 257         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 258         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 259         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 260         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 261         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 262         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 263         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 264         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 265         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 266         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 267         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 268         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 269         procfs.c, producer.c, progspace.h, psymtab.h,
 270         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 271         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 272         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 273         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 274         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 275         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 276         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 277         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 278         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 279         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 280         target-memory.c, target.c, target.h, target/waitstatus.c,
 281         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 282         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 283         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 284         unittests/array-view-selftests.c,
 285         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 286         unittests/common-utils-selftests.c,
 287         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 288         unittests/format_pieces-selftests.c,
 289         unittests/function-view-selftests.c,
 290         unittests/lookup_name_info-selftests.c,
 291         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 292         unittests/mkdir-recursive-selftests.c,
 293         unittests/observable-selftests.c,
 294         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 295         unittests/parse-connection-spec-selftests.c,
 296         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 297         unittests/scoped_fd-selftests.c,
 298         unittests/scoped_mmap-selftests.c,
 299         unittests/scoped_restore-selftests.c,
 300         unittests/string_view-selftests.c, unittests/style-selftests.c,
 301         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 302         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 303         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 304         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 305         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 306         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 307
 308 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 309
 310         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 311         bool value.
 312         (decode_digits_ordinary): Set explicit_line field in sal.
 313         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 314         symtab_and_line that was set on an explicit line number in
 315         assembler code.  Do always update the recorded symtab and line if
 316         we do skip the prologue.
 317
 318 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 319
 320         * breakpoint.c (set_breakpoint_location_function): Remove
 321         explicit_loc parameter.
 322         (momentary_breakpoint_from_master): Update call to
 323         set_breakpoint_location_function.
 324         (add_location_to_breakpoint): Likewise.
 325
 326 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 327
 328         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 329         required features based on default bfd type when no specific bfd
 330         is present.
 331
 332 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 333
 334         * NEWS: Mention that GDB printf and eval commands can now print
 335         C-style and Ada-style convenience var strings without
 336         calling the inferior.
 337         * printcmd.c (printf_c_string): Locally print GDB internal var
 338         instead of transiting via the inferior.
 339         (printf_wide_c_string): Likewise.
 340
 341 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 342
 343         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 344
 345 2019-07-04  Tom Tromey  <tom@tromey.com>
 346
 347         PR tui/24724:
 348         * tui/tui-winsource.c (tui_clear_source_content): Update.
 349         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 350         (tui_update_breakpoint_info): Update.
 351         (tui_set_exec_info_content): Update.
 352         * tui/tui-source.c (tui_set_source_content_nil): Update.
 353         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 354         has_break.
 355         * tui/tui-data.h (enum tui_bp_flag): New.
 356         (tui_bp_flags): New enum flags type.
 357         (struct tui_source_element) <break_mode>: Change type.  Rename
 358         from has_break.
 359         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 360         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 361         constants.
 362         * tui/tui-winsource.h: Fix comment.
 363
 364 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 365
 366         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 367         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 368         (store_fpregs_to_thread)
 369         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 370         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 371         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 372         (IWMMXT_REGS_SIZE): Add define.
 373         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 374         (fetch_vfp_regs, store_vfp_regs)
 375         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 376         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 377
 378 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 379
 380         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 381         defines.
 382         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 383         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 384         (ARM_INT_REGISTER_SIZE): ...to this.
 385         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 386         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 387         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 388         (arm_linux_collect_gregset, supply_nwfpe_register)
 389         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 390         defines.
 391         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 392         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 393         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 394         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 395         (arm_return_in_memory, arm_store_return_value)
 396         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 397         (arm_record_ld_st_multiple): Likewise.
 398         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 399         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 400
 401 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 402
 403         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 404         AARCH64_DISPLACED_MODIFIED_INSNS.
 405         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 406         (aarch64_displaced_step_copy_insn): Likewise.
 407         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 408         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 409         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 410         ARM_DISPLACED_MODIFIED_INSNS.
 411         * arm-tdep.c (arm_gdbarch_init): Likewise.
 412         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 413         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 414         (struct arm_displaced_step_closure): Use
 415         ARM_DISPLACED_MODIFIED_INSNS.
 416
 417 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 418
 419         * features/Makefile: Remove unused xml files.
 420         * features/aarch64.xml: Remove.
 421         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 422         * features/i386/amd64-avx-avx512.xml: Remove.
 423         * features/i386/amd64-avx-linux.xml: Remove.
 424         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 425         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 426         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 427         * features/i386/amd64-avx-mpx.xml: Remove.
 428         * features/i386/amd64-avx.xml: Remove.
 429         * features/i386/amd64-linux.xml: Remove.
 430         * features/i386/amd64-mpx-linux.xml: Remove.
 431         * features/i386/amd64-mpx.xml: Remove.
 432         * features/i386/amd64.xml: Remove.
 433         * features/i386/i386-avx-avx512-linux.xml: Remove.
 434         * features/i386/i386-avx-avx512.xml: Remove.
 435         * features/i386/i386-avx-linux.xml: Remove.
 436         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 437         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 438         * features/i386/i386-avx-mpx-linux.xml: Remove.
 439         * features/i386/i386-avx-mpx.xml: Remove.
 440         * features/i386/i386-avx.xml: Remove.
 441         * features/i386/i386-linux.xml: Remove.
 442         * features/i386/i386-mmx-linux.xml: Remove.
 443         * features/i386/i386-mmx.xml: Remove.
 444         * features/i386/i386-mpx-linux.xml: Remove.
 445         * features/i386/i386-mpx.xml: Remove.
 446         * features/i386/i386.xml: Remove.
 447         * features/i386/x32-avx-avx512-linux.xml: Remove.
 448         * features/i386/x32-avx-linux.xml: Remove.
 449         * features/i386/x32-linux.xml: Remove.
 450
 451 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 452
 453         * regformats/aarch64.dat: Remove.
 454         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 455         * regformats/i386/amd64-avx-linux.dat: Remove.
 456         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 457         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 458         * regformats/i386/amd64-linux.dat: Remove.
 459         * regformats/i386/amd64-mpx-linux.dat: Remove.
 460         * regformats/i386/amd64.dat: Remove.
 461         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 462         * regformats/i386/i386-avx-linux.dat: Remove.
 463         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 464         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 465         * regformats/i386/i386-linux.dat: Remove.
 466         * regformats/i386/i386-mmx-linux.dat: Remove.
 467         * regformats/i386/i386-mpx-linux.dat: Remove.
 468         * regformats/i386/i386.dat: Remove.
 469         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 470         * regformats/i386/x32-avx-linux.dat: Remove.
 471         * regformats/i386/x32-linux.dat: Remove.
 472
 473 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 474
 475         * aarch64-tdep.c: Remove xml self tests.
 476         * amd64-linux-tdep.c: Likewise.
 477         * amd64-tdep.c: Likewise.
 478         * i386-linux-tdep.c: Likewise.
 479         * i386-tdep.c: Likewise.
 480
 481 2019-07-03  Pedro Alves  <palves@redhat.com>
 482
 483         PR cli/24732
 484         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 485         (pipe_cmd_option_defs): New.
 486         (make_pipe_cmd_options_def_group): New.
 487         (pipe_command): Use gdb::option::process_options.
 488         (pipe_command_completer): New function.
 489         (_initialize_cli_cmds): Install completer for "pipe" command.
 490
 491 2019-07-03  Pedro Alves  <palves@redhat.com>
 492
 493         * cli/cli-option.c (union option_value) <string>: New field.
 494         (struct option_def_and_value): Add ctor, move ctor, dtor and
 495         use DISABLE_COPY_AND_ASSIGN.
 496         (option_def_and_value::clear_value): New.
 497         (parse_option, save_option_value_in_ctx, get_val_type_str)
 498         (add_setshow_cmds_for_options): Handle var_string.
 499         * cli-option.h (union option_def::var_address) <string>: New
 500         field.
 501         (struct string_option_def): New.
 502         * maint-test-options.c (struct test_options_opts): Add default
 503         ctor and use DISABLE_COPY_AND_ASSIGN.
 504         <string_opt>: New field.
 505         (test_options_opts::~test_options_opts): New.
 506         (test_options_opts::dump): Also dump "-string".
 507         (test_options_option_defs): Install "string.
 508
 509 2019-07-03  Pedro Alves  <palves@redhat.com>
 510
 511         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 512         option_value with a null enumeration.
 513         (complete_options): Save the option values in the context.
 514         (save_option_value_in_ctx): New, factored out from ...
 515         (process_options): ... here.
 516         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 517         of the function.
 518         * maint-test-options.c (test_options_opts::dump): New, factored
 519         out from ...
 520         (maintenance_test_options_command_mode): ... here.
 521         (maintenance_test_options_command_completion_result): Delete.
 522         (maintenance_test_options_command_completion_text): Update
 523         comment.
 524         (maintenance_show_test_options_completion_result): Change
 525         prototype.  Just print
 526         maintenance_test_options_command_completion_text.
 527         (save_completion_result): New.
 528         (maintenance_test_options_completer_mode): Pass options context to
 529         complete_options, and then save a dump.
 530         (_initialize_maint_test_options): Use add_cmd to install "maint
 531         show test-options-completion-result".
 532
 533 2019-07-03  Pedro Alves  <palves@redhat.com>
 534
 535         * NEWS (New commands): Mention "with" and "maint with".
 536         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 537         (with_command, with_command_completer): New.
 538         (pipe_command): Adjust to new repeat_previous
 539         interface.
 540         (_initialize_cli_cmds): Install the "with" command and its "w"
 541         alias.
 542         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 543         declarations.
 544         * cli/cli-setshow.c (parse_cli_var_uinteger)
 545         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 546         argument strings for all var_types.
 547         (get_setshow_command_value_string): New, factored out from ...
 548         (do_show_command): ... this.
 549         * cli/cli-setshow.h: Include <string>.
 550         (get_setshow_command_value_string): Declare.
 551         * command.h (repeat_previous): Now returns const char *.  Adjust
 552         comment.
 553         * maint.c: Include "cli/cli-cmds.h".
 554         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 555         (_initialize_maint_cmds): Register the "maintenance with" command.
 556         * top.c (repeat_previous): Move bits from pipe_command here:
 557         Return the saved command line, if any; error out if there's no
 558         command to relaunch.
 559
 560 2019-07-03  Pedro Alves  <palves@redhat.com>
 561
 562         * NEWS (New commands): Mention "maint set/show test-settings"
 563         instead of "maint test-settings".
 564         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 565         (maintenance_test_settings_set_list): Rename to ...
 566         (maintenance_set_test_settings_list): ... this.
 567         (maintenance_test_settings_show_list): Rename to  ...
 568         (maintenance_show_test_settings_list): ... this.
 569         (maintenance_test_settings_cmd): Delete.
 570         (maintenance_test_settings_set_cmd): ...
 571         (maintenance_set_test_settings_cmd): ... this.
 572         (maintenance_test_settings_show_cmd): ...
 573         (maintenance_show_test_settings_cmd): ... this.
 574         (maintenance_test_settings_show_value_cmd):
 575         (maintenance_show_test_settings_value_cmd): ... this.
 576         (_initialize_maint_test_settings): No longer install the "maint
 577         test-settings" prefix command.  Rename "maint test-settings set"
 578         to "maint set test-settings", and "maint test-settings show" to
 579         "maint show test-settings".  Adjust all subcommands.
 580
 581 2019-07-03  Pedro Alves  <palves@redhat.com>
 582
 583         * maint-test-settings.c: Fix file's intro comment.  Replace all
 584         references to "test-options" with references to "test-settings",
 585         in comments.
 586
 587 2019-07-03  Pedro Alves  <palves@redhat.com>
 588
 589         * maint-test-settings.c (maintenance_test_settings_xxx)
 590         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 591         New.
 592         (maintenance_test_settings_enums): Use them.
 593         (maintenance_test_settings_enum): Default to
 594         maintenance_test_settings_xxx.
 595         (_initialize_maint_test_settings): Initialize
 596         MAINTENANCE_TEST_SETTINGS_FILENAME.
 597
 598 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 599
 600         * breakpoint.h (remove_breakpoints_inf): Change return type to
 601         void, move function documentation here.
 602         * breakpoint.c (remove_breakpoints_inf): Change return type to
 603         void, move function documentation to header.
 604
 605 2019-07-02  Pedro Alves  <palves@redhat.com>
 606
 607         * NEWS (Completion improvements): Mention "info threads".
 608         * thread.c (struct info_threads_opts, info_threads_option_defs)
 609         (make_info_threads_options_def_group): New.
 610         (info_threads_command): Use gdb::option::process_options.
 611         (info_threads_command_completer): New.
 612         (_initialize_thread): Use gdb::option::build_help to build the
 613         help text for "info threads".
 614
 615 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 616
 617         * defs.h (generic_load): Move from here...
 618         * symfile.h (generic_load): ... to here.  Rename name parameter
 619         to args.
 620         * symfile.c (generic_load): Add comment.
 621
 622 2019-07-01  Tom Tromey  <tromey@adacore.com>
 623
 624         * dwarf2read.c
 625         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
 626         declaration of without_params.  Fix formatting.
 627
 628 2019-07-01  Tom Tromey  <tromey@adacore.com>
 629
 630         * ada-exp.y (find_primitive_type): Update.
 631         * ada-lang.h (ada_lookup_symbol): Update.
 632         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
 633         parameter.
 634         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
 635
 636 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 637
 638         PR breakpoints/24541
 639         * gdbarch.c: Regenerate.
 640         * gdbarch.h: Regenerate.
 641         * gdbarch.sh: Add 'stap_adjust_register'.
 642         * i386-tdep.c: Include '<unordered_set>'.
 643         (i386_stap_adjust_register): New function.
 644         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
 645         * stap-probe.c (stap_parse_register_operand): Call
 646         'gdbarch_stap_adjust_register'.
 647
 648 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 649
 650         PR python/24742
 651         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
 652         * python/python.c (do_start_initialization): Use 'xmalloc'
 653         instead of 'PyMem_Malloc'.
 654
 655 2019-06-28  Tom Tromey  <tromey@adacore.com>
 656
 657         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
 658         for Ada.
 659
 660 2019-06-27  Tom Tromey  <tromey@adacore.com>
 661
 662         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
 663         objfile_key.
 664         (arm_find_mapping_symbol, arm_record_special_symbol)
 665         (_initialize_arm_tdep): Update.
 666         (arm_objfile_data_free): Remove.
 667
 668 2019-06-27  Tom Tromey  <tromey@adacore.com>
 669
 670         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
 671         to cp_print_static_field.
 672
 673 2019-06-26  Tom Tromey  <tromey@adacore.com>
 674
 675         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
 676         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
 677         declare.
 678
 679 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 680
 681         * features/aarch64-core.c (create_feature_aarch64_core):
 682         Regenerate.
 683         * features/aarch64-core.xml: Add cpsr flags.
 684
 685 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 686
 687         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
 688         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
 689
 690 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 691
 692         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
 693         field.
 694         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
 695         use.
 696         (arm_record_special_symbol): Don't insert new symbol in sorted
 697         position, push it at the end.
 698
 699 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 700
 701         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
 702         (arm_mapping_symbol_s): Remove.
 703         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
 704         (arm_mapping_symbol_vec): New typedef.
 705         (struct arm_per_objfile): Add constructor.
 706         <section_maps>: Change type to
 707         std::unique_ptr<arm_mapping_symbol_vec[]>.
 708         (arm_compare_mapping_symbols): Remove.
 709         (arm_find_mapping_symbol): Adjust to section_maps type change.
 710         (arm_objfile_data_free): Call delete on arm_per_objfile.
 711         (arm_record_special_symbol): Adjust to section_maps type change.
 712         Allocate arm_per_objfile with new.
 713
 714 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 715
 716         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 717         with the command prefix.
 718
 719 2019-06-25  Tom Tromey  <tom@tromey.com>
 720
 721         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 722         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 723
 724 2019-06-25  Tom Tromey  <tom@tromey.com>
 725
 726         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 727         type.
 728         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 729         protected.
 730
 731 2019-06-25  Tom Tromey  <tom@tromey.com>
 732
 733         * tui/tui-winsource.c
 734         (tui_source_window_base::set_is_exec_point_at): Add check against
 735         LOA_ADDRESS.
 736
 737 2019-06-25  Tom Tromey  <tom@tromey.com>
 738
 739         * tui/tui-source.c (tui_set_source_content): Don't check before
 740         xfree.
 741         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 742
 743 2019-06-25  Tom Tromey  <tom@tromey.com>
 744
 745         * tui/tui-winsource.h (tui_update_source_window_as_is)
 746         (tui_alloc_source_buffer, tui_line_is_displayed)
 747         (tui_addr_is_displayed): Change type of win_info.
 748         * tui/tui-winsource.c (tui_update_source_window_as_is)
 749         (tui_clear_source_content, tui_show_source_line)
 750         (tui_show_source_content, tui_source_window_base::refill)
 751         (tui_source_window_base::set_is_exec_point_at)
 752         (tui_source_window_base::set_is_exec_point_at)
 753         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 754         (tui_alloc_source_buffer, tui_line_is_displayed)
 755         (tui_addr_is_displayed): Change type of win_info.  Update.
 756         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 757         (tui_source_window_base::do_make_visible_with_new_height):
 758         Update.
 759         * tui/tui-source.c (tui_set_source_content)
 760         (tui_set_source_content_nil)
 761         (tui_source_window::do_scroll_vertical): Update.
 762         * tui/tui-layout.c (show_layout): Update.
 763         * tui/tui-disasm.c (tui_set_disassem_content)
 764         (tui_disasm_window::do_scroll_vertical): Update.
 765         * tui/tui-data.h (tui_win_content): Remove.
 766         (struct tui_gen_win_info) <content, content_size>: Remove.
 767         (struct tui_source_element): Add initializers and destructor.
 768         (union tui_which_element, struct tui_win_element): Remove.
 769         (struct tui_source_window_base) <content>: New field.
 770         (struct tui_data_window): Remove destructor.
 771         (tui_alloc_content, tui_free_win_content)
 772         (tui_free_all_source_wins_content): Don't declare.
 773         * tui/tui-data.c (tui_initialize_static_data): Update.
 774         (init_content_element, tui_alloc_content): Remove.
 775         (~tui_gen_win_info): Update.
 776         (~tui_data_window, tui_free_all_source_wins_content)
 777         (tui_free_win_content, free_content, free_content_elements):
 778         Remove.
 779
 780 2019-06-25  Tom Tromey  <tom@tromey.com>
 781
 782         * tui/tui-winsource.h (tui_clear_source_content)
 783         (tui_erase_source_content, tui_show_source_content): Change type
 784         of win_info.
 785         * tui/tui-winsource.c (tui_clear_source_content)
 786         (tui_erase_source_content, tui_show_source_content): Change type
 787         of win_info.
 788         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 789         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 790         win_info.
 791         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 792         win_info.
 793         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 794
 795 2019-06-25  Tom Tromey  <tom@tromey.com>
 796
 797         * tui/tui-winsource.c (tui_clear_source_content)
 798         (tui_source_window_base::set_is_exec_point_at): Update.
 799         * tui/tui-source.c (tui_set_source_content_nil): Update.
 800         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 801         a bool.
 802         * tui/tui-data.c (init_content_element): Update.
 803
 804 2019-06-25  Tom Tromey  <tom@tromey.com>
 805
 806         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 807         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 808         * tui/tui-layout.c (init_and_make_win): Update.
 809         * tui/tui.h (enum tui_win_type): Update.
 810         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 811         tui_win_is_auxillary.
 812         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 813         tui_win_is_auxillary.
 814
 815 2019-06-25  Tom Tromey  <tom@tromey.com>
 816
 817         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 818         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 819         (tui_delete_data_content_windows, tui_display_all_data)
 820         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 821         Update.
 822         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 823         * tui/tui-regs.c (tui_last_regs_line_no)
 824         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 825         (tui_show_registers): Update.
 826         (tui_show_register_group): Return void.  Update.
 827         (tui_display_registers_from, tui_display_reg_element_at_line)
 828         (tui_display_registers_from_line, tui_check_register_values):
 829         Update.
 830         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 831         member.
 832         (struct tui_data_window) <regs_content>: Now a std::vector.
 833         <regs_content_count>: Remove.
 834         (tui_add_content_elements, tui_free_data_content): Don't declare.
 835         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 836         (init_content_element): Remove DATA_WIN case.  Add assert.
 837         (tui_add_content_elements): Remove.
 838         (tui_data_window): Update.
 839         (tui_free_data_content): Remove.
 840         (free_content_elements): Remove DATA_WIN case.
 841
 842 2019-06-25  Tom Tromey  <tom@tromey.com>
 843
 844         * tui/tui-data.c (tui_data_item_window): Update.
 845         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 846         * tui/tui-windata.c (tui_display_all_data)
 847         (tui_display_data_from_line): Update.
 848         (tui_check_data_values): Remove.
 849         * tui/tui-regs.c (tui_show_register_group)
 850         (tui_display_reg_element_at_line): Update.
 851         * tui/tui-hooks.c (tui_register_changed)
 852         (tui_refresh_frame_and_register_information): Call
 853         tui_check_register_values.
 854         * tui/tui-data.h (struct tui_data_window) <data_content,
 855         data_content_count, data_type>: Remove.
 856         (enum tui_data_type): Remove.
 857
 858         * tui/tui-data.c (tui_data_window::clear_detail)
 859         (~tui_data_window): Update.
 860
 861 2019-06-25  Tom Tromey  <tom@tromey.com>
 862
 863         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 864         declare.
 865         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 866         Rename from tui_first_data_item_displayed.  Update.
 867         (tui_data_window::refresh_all)
 868         (tui_data_window::do_scroll_vertical): Update.
 869         * tui/tui-data.h (struct tui_data_window)
 870         <first_data_item_displayed>: Declare new method.
 871
 872 2019-06-25  Tom Tromey  <tom@tromey.com>
 873
 874         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 875         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 876         contents...
 877         (tui_initialize_static_data): ...here.
 878
 879 2019-06-25  Tom Tromey  <tom@tromey.com>
 880
 881         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 882         (tui_display_registers_from, tui_check_register_values): Update.
 883         (tui_display_register): Remove win_info parameter; update.
 884         (tui_get_register): Change type of parameters.
 885         * tui/tui-data.h (struct tui_data_element): Remove.
 886         (union tui_which_element) <data>: Remove.
 887         <data_window>: Change type.
 888         (struct tui_data_item_window): New.
 889         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 890         case.  Add assert.
 891         (~tui_data_item_window): New destructor.
 892         (free_content_elements): Remove DATA_ITEM_WIN case.
 893
 894 2019-06-25  Tom Tromey  <tom@tromey.com>
 895
 896         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 897         Remove.
 898
 899 2019-06-25  Tom Tromey  <tom@tromey.com>
 900
 901         * tui/tui-data.h (struct tui_command_element): Remove.
 902         (union tui_which_element) <command>: Remove.
 903         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 904         assert.
 905         (free_content_elements): Remove CMD_WIN case.
 906
 907 2019-06-25  Tom Tromey  <tom@tromey.com>
 908
 909         * tui/tui-layout.c (tui_set_layout): Update.
 910         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 911         * tui/tui-data.c (layout_def): Update.
 912
 913 2019-06-25  Tom Tromey  <tom@tromey.com>
 914
 915         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 916         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 917         (tui_source_window_base::set_new_height): Update.
 918         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 919         Update.
 920         (tui_set_locator_fullname, tui_set_locator_info)
 921         (tui_show_frame_info): Update.
 922         * tui/tui-source.c (tui_set_source_content)
 923         (tui_source_is_displayed): Update.
 924         * tui/tui-layout.c (show_source_disasm_command, show_data)
 925         (show_source_or_disasm_and_command): Update.
 926         * tui/tui-disasm.c (tui_set_disassem_content)
 927         (tui_get_begin_asm_address): Update.
 928         * tui/tui-data.h (struct tui_locator_element): Remove.
 929         (union tui_which_element) <locator>: Remove.
 930         (struct tui_locator_window): New.
 931         (tui_locator_win_info_ptr): Change return type.
 932         * tui/tui-data.c (_locator): Change type.
 933         (tui_locator_win_info_ptr): Change return type.
 934         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 935         (tui_alloc_content): Add assert.
 936
 937 2019-06-25  Tom Tromey  <tom@tromey.com>
 938
 939         * tui/tui-winsource.c
 940         (tui_exec_info_window::maybe_allocate_content): New method.
 941         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 942         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 943         (make_source_or_disasm_window): Add cast.
 944         * tui/tui-data.h (union tui_which_element) <simple_string>:
 945         Remove.
 946         (struct tui_source_info): New.
 947         (struct tui_source_window_base) <execution_info>: Change type.
 948         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 949         case, and add assert.
 950         (tui_alloc_content): Add assert.
 951
 952 2019-06-25  Tom Tromey  <tom@tromey.com>
 953
 954         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 955         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 956         * tui/tui-data.c (tui_alloc_win_info): Remove.
 957
 958 2019-06-25  Tom Tromey  <tom@tromey.com>
 959
 960         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 961         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 962         can_highlight.
 963
 964 2019-06-25  Tom Tromey  <tom@tromey.com>
 965
 966         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 967         make_visible_with_new_height method.
 968         (tui_win_info::make_visible_with_new_height): New method.
 969         (tui_source_window_base::do_make_visible_with_new_height)
 970         (tui_data_window::do_make_visible_with_new_height)
 971         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 972         (make_visible_with_new_height): Remove.
 973         (tui_resize_all, tui_adjust_win_heights): Use
 974         make_visible_with_new_height method.
 975         * tui/tui-data.h (struct tui_win_info)
 976         <do_make_visible_with_new_height, make_visible_with_new_height>:
 977         New methods.
 978         (struct tui_source_window_base, struct tui_data_window)
 979         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 980         methods.
 981
 982 2019-06-25  Tom Tromey  <tom@tromey.com>
 983
 984         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 985         method.
 986         (update_tab_width): Call update_tab_width method.
 987         * tui/tui-data.h (struct tui_win_info)
 988         (struct tui_source_window_base) <update_tab_width>: New methods.
 989
 990 2019-06-25  Tom Tromey  <tom@tromey.com>
 991
 992         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 993         parameter.
 994         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 995         parameter.
 996         (tui_gen_win_info::make_visible): Update.
 997         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 998         parameter.
 999         * tui/tui-data.h (enum tui_box): New enum.
1000         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1001
1002 2019-06-25  Tom Tromey  <tom@tromey.com>
1003
1004         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1005         init_and_make_win for EXEC_INFO_WIN.
1006         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1007         longer inline.
1008         (struct tui_win_info) <~tui_win_info>: Inline.
1009         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1010         Don't declare.
1011         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1012         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1013         Remove.
1014         (tui_initialize_static_data): Update.
1015         (~tui_gen_win_info): Handle more cleanup here.
1016         (~tui_source_window_base): Delete "execution_info".
1017         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1018
1019 2019-06-25  Tom Tromey  <tom@tromey.com>
1020
1021         * tui/tui-layout.c (make_command_window): Don't set
1022         can_highlight.
1023         (show_source_disasm_command): Call the reset method.
1024         (show_data): Don't set can_highlight.  Call the reset method.
1025         (tui_gen_win_info::reset): Rename from init_gen_win_info
1026         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1027         (show_source_or_disasm_and_command): Call the reset method.
1028         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1029         (struct tui_cmd_window): Set can_highlight.
1030
1031 2019-06-25  Tom Tromey  <tom@tromey.com>
1032
1033         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1034         from make_visible.
1035         (tui_make_visible, tui_make_invisible): Rewrite.
1036         (tui_win_info::make_visible): Remove.
1037         (tui_source_window_base::make_visible): Update.
1038         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1039         method.  Moved from...
1040         (struct tui_win_info) <make_visible>: ...here.
1041
1042 2019-06-25  Tom Tromey  <tom@tromey.com>
1043
1044         * tui/tui-winsource.c
1045         (tui_source_window_base::do_scroll_horizontal): Remove direction
1046         parameter.
1047         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1048         direction parameter.
1049         * tui/tui-win.c (tui_win_info::forward_scroll)
1050         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1051         (tui_win_info::right_scroll): Update.
1052         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1053         direction parameter.
1054         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1055         direction parameter.
1056         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1057         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1058         Remove direction parameter.
1059         (struct tui_source_window_base, struct tui_source_window)
1060         (struct tui_disasm_window, struct tui_data_window)
1061         (struct tui_cmd_window): Update.
1062
1063 2019-06-25  Tom Tromey  <tom@tromey.com>
1064
1065         * tui/tui-winsource.h (tui_set_exec_info_content)
1066         (tui_show_exec_info_content, tui_erase_exec_info_content)
1067         (tui_clear_exec_info_content, tui_update_exec_info): Change
1068         argument to tui_source_window_base.
1069         * tui/tui-winsource.c (tui_set_exec_info_content)
1070         (tui_show_exec_info_content, tui_erase_exec_info_content)
1071         (tui_clear_exec_info_content, tui_update_exec_info): Change
1072         argument to tui_source_window_base.
1073
1074 2019-06-25  Tom Tromey  <tom@tromey.com>
1075
1076         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1077         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1078
1079 2019-06-25  Tom Tromey  <tom@tromey.com>
1080
1081         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1082         check.
1083
1084 2019-06-25  Tom Tromey  <tom@tromey.com>
1085
1086         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1087         type to void.
1088         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1089         type to void.
1090         * tui/tui-source.c (tui_set_source_content): Update.
1091         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1092
1093 2019-06-25  Tom Tromey  <tom@tromey.com>
1094
1095         * tui/tui-win.c (window_name_completer, tui_set_focus)
1096         (tui_all_windows_info): Use name method.
1097         * tui/tui-data.h (struct tui_gen_win_info)
1098         (struct tui_source_window, struct tui_disasm_window)
1099         (struct tui_data_window, struct tui_cmd_window) <name>: New
1100         method.
1101         (tui_win_name): Don't declare.
1102         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1103         (tui_win_name): Remove.
1104
1105 2019-06-25  Tom Tromey  <tom@tromey.com>
1106
1107         * tui/tui-winsource.h (tui_update_source_window)
1108         (tui_update_source_window_as_is): Change parameter type.
1109         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1110         to be a tui_source_window_base.
1111         (tui_update_source_window_as_is): Likewise.
1112         * tui/tui-win.c (make_visible_with_new_height): Update.
1113
1114 2019-06-25  Tom Tromey  <tom@tromey.com>
1115
1116         * tui/tui-winsource.c (tui_erase_source_content)
1117         (tui_show_source_content, tui_show_exec_info_content)
1118         (tui_erase_exec_info_content): Use refresh_window method.
1119         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1120         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1121         from tui_refresh_win.
1122         (tui_data_window::refresh_window): New method.
1123         (tui_win_info::refresh, tui_source_window_base::refresh)
1124         (tui_refresh_all): Use refresh_window method.
1125         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1126         method.
1127         * tui/tui-regs.c (tui_display_register): Call refresh_window
1128         method.
1129         * tui/tui-layout.c (show_source_disasm_command)
1130         (show_source_or_disasm_and_command): Call refresh_window method.
1131         * tui/tui-data.h (struct tui_gen_win_info)
1132         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1133         New method.
1134
1135 2019-06-25  Tom Tromey  <tom@tromey.com>
1136
1137         * tui/tui.c (tui_rl_other_window, tui_enable)
1138         (tui_is_window_visible, tui_get_command_dimension): Update.
1139         * tui/tui-winsource.c (tui_update_source_window_as_is)
1140         (tui_clear_source_content, tui_erase_source_content)
1141         (tui_show_source_line, tui_source_window_base::refill)
1142         (tui_source_window_base::do_scroll_horizontal)
1143         (tui_source_window_base::set_is_exec_point_at)
1144         (tui_update_breakpoint_info, tui_set_exec_info_content)
1145         (tui_alloc_source_buffer, tui_line_is_displayed)
1146         (tui_addr_is_displayed): Update.
1147         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1148         (tui_check_and_display_highlight_if_needed)
1149         (tui_win_info::make_visible, tui_win_info::refresh)
1150         (tui_refresh_all): Update.
1151         * tui/tui-windata.c (tui_first_data_item_displayed)
1152         (tui_delete_data_content_windows, tui_erase_data_content)
1153         (tui_display_all_data, tui_data_window::refresh_all)
1154         (tui_check_data_values): Update.
1155         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1156         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1157         (tui_win_info::backward_scroll, tui_refresh_all_win)
1158         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1159         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1160         (tui_source_window_base::set_new_height)
1161         (tui_data_window::set_new_height)
1162         (make_invisible_and_set_new_height)
1163         (make_visible_with_new_height, new_height_ok)
1164         (parse_scrolling_args): Update.
1165         * tui/tui-stack.c (tui_show_frame_info): Update.
1166         * tui/tui-source.c (tui_set_source_content)
1167         (tui_set_source_content_nil, tui_source_is_displayed)
1168         (tui_source_window::do_scroll_vertical): Update.
1169         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1170         (tui_display_registers_from, tui_display_reg_element_at_line)
1171         (tui_check_register_values, tui_reg_command): Update.
1172         * tui/tui-layout.c (tui_default_win_height)
1173         (show_source_disasm_command, show_data, init_and_make_win)
1174         (show_source_or_disasm_and_command): Update.
1175         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1176         (tui_redisplay_readline, tui_mld_flush)
1177         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1178         (tui_getc): Update.
1179         * tui/tui-disasm.c (tui_set_disassem_content)
1180         (tui_disasm_window::do_scroll_vertical): Update.
1181         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1182         Now virtual.
1183         (struct tui_win_info): Derive from tui_gen_win_info.
1184         <~tui_win_info>: Mark as override.
1185         <generic>: Remove member.
1186         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1187         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1188         (~tui_data_window, ~tui_win_info)
1189         (tui_free_all_source_wins_content): Update.
1190         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1191
1192 2019-06-25  Tom Tromey  <tom@tromey.com>
1193
1194         * tui/tui-layout.c (init_and_make_win): Use new.
1195         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1196         destructor, initializers.
1197         (tui_alloc_generic_win_info): Don't declare.
1198         * tui/tui-data.c (_locator): Add argument to constructor.
1199         (source_win, disasm_win): New globals.
1200         (exec_info): Remove.
1201         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1202         Update.
1203         (tui_alloc_generic_win_info): Remove.
1204         (init_content_element): Use new.
1205         (tui_win_info::tui_win_info): Update.
1206         (free_content_elements) <case DATA_WIN>: Use delete.
1207
1208 2019-06-25  Tom Tromey  <tom@tromey.com>
1209
1210         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1211         * tui/tui-windata.c (tui_first_data_item_displayed)
1212         (tui_delete_data_content_windows): Update.
1213         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1214         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1215         (tui_display_registers_from, tui_check_register_values): Update.
1216         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1217         pointer.
1218         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1219         window.
1220         (tui_free_data_content): Update.
1221         (free_content_elements) <case DATA_WIN>: Free the window.
1222
1223 2019-06-25  Tom Tromey  <tom@tromey.com>
1224
1225         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1226         Update.
1227         * tui/tui-layout.c (make_command_window)
1228         (show_source_disasm_command, show_data, init_and_make_win)
1229         (show_source_or_disasm_and_command): Update.
1230         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1231         method.
1232         <can_highight, is_highlighted>: Now bool.
1233         (tui_set_win_highlight): Don't declare.
1234         * tui/tui-data.c (tui_set_win_highlight): Remove.
1235
1236 2019-06-25  Tom Tromey  <tom@tromey.com>
1237
1238         * tui/tui-wingeneral.c (make_visible): Remove check of window
1239         type.
1240
1241 2019-06-25  Tom Tromey  <tom@tromey.com>
1242
1243         * tui/tui-win.c (tui_win_info::max_height)
1244         (tui_cmd_window::max_height): New methods.
1245         (new_height_ok): Call max_height.
1246         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1247         <max_height>: New method.
1248
1249 2019-06-25  Tom Tromey  <tom@tromey.com>
1250
1251         * tui/tui-win.c (tui_source_window_base::set_new_height)
1252         (tui_data_window::set_new_height): New methods.
1253         (make_invisible_and_set_new_height): Call set_new_height method.
1254         * tui/tui-data.h (struct tui_win_info)
1255         (struct tui_source_window_base, struct tui_data_window)
1256         <set_new_height>: New method.
1257
1258 2019-06-25  Tom Tromey  <tom@tromey.com>
1259
1260         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1261         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1262         tui_refresh_data_win.
1263         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1264         method.
1265         (tui_refresh_all_win): Call the refresh_all method.
1266         (tui_set_focus): Likewise.
1267         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1268         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1269         Likewise.
1270
1271 2019-06-25  Tom Tromey  <tom@tromey.com>
1272
1273         * tui/tui-winsource.h (tui_refill_source_window)
1274         (tui_set_is_exec_point_at): Don't declare.
1275         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1276         (tui_source_window_base::refill): Rename from
1277         tui_refill_source_window.
1278         (tui_source_window_base::do_scroll_horizontal): Update.
1279         (tui_source_window_base::set_is_exec_point_at): Rename from
1280         tui_set_is_exec_point_at.
1281         (tui_update_all_breakpoint_info): Update.
1282         * tui/tui-stack.c (tui_show_frame_info): Update.
1283         * tui/tui-layout.c (show_data): Add cast.
1284         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1285         * tui/tui-data.h (struct tui_source_window_base) <refill,
1286         set_is_exec_point_at>: New methods.
1287         (tui_source_windows, tui_add_to_source_windows): Update types.
1288         (tui_add_to_source_windows): Remove redundant declaration.
1289         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1290         (tui_source_windows): Change return type.
1291         (tui_clear_source_windows_detail): Update.
1292         (tui_add_to_source_windows): Change type of parameter.
1293         (tui_free_all_source_wins_content): Update.
1294
1295 2019-06-25  Tom Tromey  <tom@tromey.com>
1296
1297         * tui/tui-wingeneral.c (tui_win_info::refresh)
1298         (tui_source_window_base::refresh): New methods.
1299         (tui_refresh_all): Call the refresh method.
1300         * tui/tui-data.h (struct tui_win_info)
1301         (struct tui_source_window_base) <refresh>: New method.
1302
1303 2019-06-25  Tom Tromey  <tom@tromey.com>
1304
1305         * tui/tui.h (tui_is_window_visible): Return bool.
1306         * tui/tui.c (tui_is_window_visible): Return bool.
1307         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1308         (tui_make_visible, tui_make_invisible)
1309         (tui_win_info::make_visible)
1310         (tui_source_window_base::make_visible, make_all_visible)
1311         (tui_make_all_visible, tui_make_all_invisible): Update.
1312         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1313         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1314         bool.
1315         (struct tui_win_info, struct tui_source_window_base)
1316         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1317         * tui/tui-data.c (tui_init_generic_part): Update.
1318
1319 2019-06-25  Tom Tromey  <tom@tromey.com>
1320
1321         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1322         (tui_source_window_base::make_visible): New methods.
1323         (make_all_visible): Make method call.
1324         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1325         (struct tui_source_window_base, struct tui_cmd_window): Override
1326         make_visible.
1327         (tui_win_is_source_type): Don't declare.
1328         * tui/tui-data.c (tui_win_is_source_type): Remove.
1329
1330 2019-06-25  Tom Tromey  <tom@tromey.com>
1331
1332         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1333         NULL check.
1334
1335 2019-06-25  Tom Tromey  <tom@tromey.com>
1336
1337         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1338         Inline constructor.  Add initializers for members.
1339         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1340         constructors; now inline in class.
1341
1342 2019-06-25  Tom Tromey  <tom@tromey.com>
1343
1344         * tui/tui-regs.c (tui_show_registers): Update.
1345         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1346         bool.
1347         * tui/tui-data.c (tui_data_window::clear_detail)
1348         (tui_data_window): Update.
1349
1350 2019-06-25  Tom Tromey  <tom@tromey.com>
1351
1352         * tui/tui-windata.c (tui_display_all_data)
1353         (tui_display_data_from_line, tui_display_data_from)
1354         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1355         Update.
1356         * tui/tui-regs.c (tui_last_regs_line_no)
1357         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1358         (tui_show_registers, tui_show_register_group)
1359         (tui_display_registers_from, tui_display_reg_element_at_line)
1360         (tui_display_registers_from_line, tui_check_register_values)
1361         (tui_reg_next, tui_reg_prev): Update.
1362         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1363         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1364         tui_data_window.
1365         (struct tui_win_info) <detail>: Remove.  Add new fields from
1366         tui_data_info.
1367         (TUI_DATA_WIN): Add cast.
1368         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1369         (~tui_data_window): Simplify.
1370
1371 2019-06-25  Tom Tromey  <tom@tromey.com>
1372
1373         * tui/tui-layout.c (show_source_disasm_command)
1374         (show_source_or_disasm_and_command): Update.
1375         * tui/tui-io.c (update_cmdwin_start_line)
1376         (tui_redisplay_readline): Update.
1377         * tui/tui-data.h (struct tui_command_info): Remove.
1378         (struct tui_win_info) <detail>: Remove command_info member.
1379         (struct tui_data_window) <start_line>: New member, from
1380         tui_command_info.
1381         (TUI_CMD_WIN): Add casts.
1382
1383 2019-06-25  Tom Tromey  <tom@tromey.com>
1384
1385         * tui/tui-winsource.c (tui_update_source_window)
1386         (tui_refill_source_window)
1387         (tui_source_window_base::do_scroll_horizontal)
1388         (tui_update_breakpoint_info, tui_set_exec_info_content)
1389         (tui_show_exec_info_content, tui_erase_exec_info_content)
1390         (tui_clear_exec_info_content): Update.
1391         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1392         Update.
1393         * tui/tui-win.c (make_invisible_and_set_new_height)
1394         (make_visible_with_new_height): Update.
1395         * tui/tui-source.c (tui_set_source_content)
1396         (tui_show_symtab_source): Update.
1397         * tui/tui-layout.c (extract_display_start_addr)
1398         (show_source_disasm_command, show_data)
1399         (make_source_or_disasm_window)
1400         (show_source_or_disasm_and_command): Update.
1401         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1402         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1403         "gdbarch".
1404         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1405         to tui_source_window_base.
1406         (struct tui_win_info) <detail>: Remove source_info member.
1407         (struct tui_source_window_base) <has_locator>: Inline.
1408         Move contents from tui_source_info; rename has_locator member to
1409         m_has_locator.
1410         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1411         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1412         header file.
1413         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1414         Simplify.
1415         (tui_free_all_source_wins_content): Cast to
1416         tui_source_window_base.
1417
1418 2019-06-25  Tom Tromey  <tom@tromey.com>
1419
1420         * tui/tui-win.c (make_invisible_and_set_new_height)
1421         (make_visible_with_new_height): Call has_locator method.
1422         * tui/tui-layout.c (show_source_disasm_command, show_data)
1423         (show_source_or_disasm_and_command): Update for bool change.
1424         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1425         (tui_win_info) <has_locator>: New method.
1426         (struct tui_source_window_base) <has_locator>: New method.
1427         (tui_win_has_locator): Don't declare.
1428         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1429         from tui_win_has_locator.
1430         (tui_source_window_base): Use false, not FALSE.
1431
1432 2019-06-25  Tom Tromey  <tom@tromey.com>
1433
1434         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1435         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1436         clear_detail method directly.
1437         (tui_clear_win_detail): Remove.
1438
1439 2019-06-25  Tom Tromey  <tom@tromey.com>
1440
1441         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1442         "this", not TUI_DISASM_WIN.
1443
1444 2019-06-25  Tom Tromey  <tom@tromey.com>
1445
1446         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1447         declare.
1448         * tui/tui-winsource.c
1449         (tui_source_window_base::do_scroll_horizontal): Rename from
1450         tui_horizontal_source_scroll.
1451         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1452         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1453         from tui_vertical_data_scroll.
1454         * tui/tui-win.h (tui_scroll): Don't declare.
1455         * tui/tui-win.c (tui_win_info::forward_scroll)
1456         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1457         (tui_win_info::right_scroll): Rename and update.
1458         (tui_scroll_forward_command, tui_scroll_backward_command)
1459         (tui_scroll_left_command, tui_scroll_right_command): Update.
1460         (tui_scroll): Remove.
1461         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1462         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1463         from tui_vertical_source_scroll.
1464         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1465         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1466         from tui_vertical_disassem_scroll.
1467         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1468         do_scroll_horizontal>: New methods.
1469         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1470         Likewise.
1471         (struct tui_source_window_base): Add do_scroll_horizontal.
1472         (struct tui_source_window, struct tui_disasm_window): Add
1473         do_scroll_vertical.
1474         (struct tui_data_window, struct tui_cmd_window): Add
1475         do_scroll_horizontal and do_scroll_vertical.
1476         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1477
1478 2019-06-25  Tom Tromey  <tom@tromey.com>
1479
1480         * tui/tui-data.h (struct tui_source_window_base): New struct.
1481         (struct tui_source_window): Derive from tui_source_window_base.
1482         (struct tui_disasm_window): New struct.
1483         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1484         from tui_source_window::clear_detail.
1485         (tui_source_window_base): Rename from tui_source_window.
1486         (~tui_source_window_base): Rename from ~tui_source_window.
1487         (tui_alloc_win_info): Create a tui_disasm_window.
1488
1489 2019-06-25  Tom Tromey  <tom@tromey.com>
1490
1491         * tui/tui-data.h (struct tui_source_window)
1492         (struct tui_data_window): Declare destructors.
1493         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1494         destructors.
1495         (tui_win_info): Simplify.
1496
1497 2019-06-25  Tom Tromey  <tom@tromey.com>
1498
1499         * tui/tui-winsource.c (tui_display_main)
1500         (tui_update_source_windows_with_addr)
1501         (tui_update_all_breakpoint_info): Update.
1502         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1503         (new_height_ok, parse_scrolling_args): Update.
1504         * tui/tui-stack.c (tui_show_frame_info): Update.
1505         * tui/tui-data.h (struct tui_list): Remove.
1506         (tui_source_windows): Return a reference to a std::vector.
1507         * tui/tui-data.c (source_windows): Now a std::vector.
1508         (tui_source_windows): Change return type.
1509         (tui_clear_source_windows): Rewrite.
1510         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1511         (tui_free_all_source_wins_content): Rewrite.
1512
1513 2019-06-25  Tom Tromey  <tom@tromey.com>
1514
1515         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1516         (struct tui_data_window, struct tui_cmd_window): Declare
1517         clear_detail method.
1518         * tui/tui-data.c (tui_source_window::clear_detail)
1519         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1520         methods.
1521         (tui_clear_win_detail): Simplify.
1522
1523 2019-06-25  Tom Tromey  <tom@tromey.com>
1524
1525         * tui/tui-layout.c (make_source_window, make_disasm_window)
1526         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1527         Return the new window.
1528         (show_source_disasm_command, show_data)
1529         (show_source_or_disasm_and_command): Update.
1530
1531 2019-06-25  Tom Tromey  <tom@tromey.com>
1532
1533         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1534         parameter.  Return the new window.
1535         (show_source_disasm_command): Update and remove NULL check.
1536         (show_source_or_disasm_and_command): Update.
1537
1538 2019-06-25  Tom Tromey  <tom@tromey.com>
1539
1540         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1541
1542 2019-06-25  Tom Tromey  <tom@tromey.com>
1543
1544         * tui/tui-data.h (struct tui_win_info): Make constructor
1545         protected.  Make destructor virtual.  Add initializers.
1546         (tui_source_window, tui_data_window, tui_cmd_window): New
1547         classes.
1548         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1549         constructor.  Add "type" parameter.
1550         (tui_source_window, tui_data_window, tui_cmd_window): New
1551         constructors.
1552         (tui_alloc_win_info): Instantiate the appropriate subclass.
1553
1554 2019-06-25  Tom Tromey  <tom@tromey.com>
1555
1556         * tui/tui-win.c (tui_resize_all): Use delete.
1557         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1558         destructor.
1559         (tui_free_window): Don't declare.
1560         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1561         Update.
1562
1563 2019-06-25  Tom Tromey  <tom@tromey.com>
1564
1565         * tui/tui-data.h (struct tui_win_info): Add constructor.
1566         * tui/tui-data.c (tui_alloc_win_info): Use new.
1567         (tui_free_window): Use delete.
1568
1569 2019-06-22  Tom Tromey  <tom@tromey.com>
1570
1571         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1572         declare.
1573         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1574
1575 2019-06-22  Tom Tromey  <tom@tromey.com>
1576
1577         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1578         declare.
1579         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1580
1581 2019-06-22  Tom de Vries  <tdevries@suse.de>
1582
1583         * dwarf2read.c (create_addrmap_from_aranges)
1584         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1585         instead of '%zu'.
1586
1587 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1588
1589         * dwarf2read.h (dwarf2_section_info_def): Remove.
1590         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1591         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1592         std::vector<dwarf2_section_info>.
1593         (struct dwo_file) <~dwo_file>: Remove.
1594         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1595         types field.
1596         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1597         (dwarf2_read_debug_names): Likewise.
1598         (create_debug_types_hash_table): Change parameter type to
1599         array_view, adjust code accordingly.
1600         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1601         (partial_die_info::fixup): Likewise.
1602         (determine_prefix): Likewise.
1603         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1604
1605 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1606
1607         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1608         gdb_bfd_ref_ptr.
1609         <~dwo_file>: Remove call to gdb_bfd_unref.
1610         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1611         gdb_bfd_ref_ptr::get.
1612
1613 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1614
1615         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1616         type to htab_up.
1617         * dwarf2read.c (struct dwo_file): Initialize fields.
1618         <~dwo_file>: New.
1619         (free_dwo_file): Remove, move content to ~dwo_file.
1620         (struct dwo_file_deleter): Remove.
1621         (dwo_file_up>: Remove custom deleter.
1622         (free_dwo_files): Remove.
1623         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1624         dwo_files.
1625         (process_skeletonless_type_units): Call unique_ptr::get.
1626         (allocate_dwo_file_hash_table): Add deleter to created hash
1627         table.  Change return type to htab_up.
1628         (lookup_dwo_file_slot): Don't memset dwo_file, call
1629         unique_ptr::get.
1630         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1631         (create_dwo_unit_in_dwp_v2): Likewise.
1632         (open_and_init_dwo_file): Likewise.
1633         (free_dwo_file_from_slot): Remove.
1634
1635 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1636
1637         * dwarf2read.h (struct dwarf2_section_info) <readin,
1638         is_virtual>: Change type to bool.
1639         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1640         true instead of 1.
1641
1642 2019-06-19  Tom Tromey  <tom@tromey.com>
1643
1644         * tui/tui-data.h (tui_init_content_element): Don't declare.
1645
1646 2019-06-19  Tom Tromey  <tom@tromey.com>
1647
1648         * tui/tui-data.h (tui_init_win_info): Don't declare.
1649
1650 2019-06-19  Tom de Vries  <tdevries@suse.de>
1651
1652         * dwarf2read.h (abstract_to_concrete): Change type to
1653         std::unordered_map<sect_offset, std::vector<sect_offset>,
1654         gdb::hash_enum<sect_offset>>.
1655
1656 2019-06-19  Tom Tromey  <tromey@adacore.com>
1657
1658         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1659         EVAL_AVOID_SIDE_EFFECTS specially.
1660
1661 2019-06-19  Tom Tromey  <tromey@adacore.com>
1662
1663         * source-cache.c (highlighter): New global.
1664         (source_cache::get_source_lines): Create a highlighter on demand.
1665
1666 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1667
1668         * defs.h (deprecated_interactive_hook): Delete declaration.
1669         * interps.c (clear_interpreter_hooks): Remove use of
1670         deprecated_interactive_hook.
1671         * top.c (deprecated_interactive_hook): Delete definition.
1672         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1673
1674 2019-06-18  Tom de Vries  <tdevries@suse.de>
1675
1676         PR gdb/24515
1677         * dwarf2read.h (abstract_to_concrete): Change type from
1678         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1679         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1680         * dwarf2read.c (read_variable): Update.
1681         (dwarf2_fetch_die_loc_sect_off): Update.
1682
1683 2019-06-17  Tom de Vries  <tdevries@suse.de>
1684
1685         PR gdb/24617
1686         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1687         accessing parent[parent_len - 1].
1688
1689 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1690
1691         PR gdb/24364
1692         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1693         call dtrace_process_dof with NULL dof.
1694
1695 2019-06-16  Tom de Vries  <tdevries@suse.de>
1696
1697         PR gdb/24445
1698         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1699
1700 2019-06-16  Tom Tromey  <tom@tromey.com>
1701
1702         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1703         (make_all_visible): Use address of member.
1704
1705 2019-06-16  Tom Tromey  <tom@tromey.com>
1706
1707         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1708         (tui_free_window, free_content, free_content_elements): Remove
1709         unnecessary cast.
1710         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1711         cast.
1712         * tui/tui-regs.c (tui_show_register_group)
1713         (tui_display_registers_from, tui_display_reg_element_at_line):
1714         Remove unnecessary cast.
1715
1716 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1717
1718         * linux-nat.c (normal_mask): Delete.
1719         (_initialize_linux_nat): Don't initialise normal_mask.
1720
1721 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1722
1723         PR gdb/24445
1724         * dwarf-index-write.h (write_psymtabs_to_index): Add
1725         dwz_basename parameter.
1726         * dwarf-index-write.c (write_gdbindex): Move file writing to
1727         write_gdbindex_1.  Change return type void.
1728         (assert_file_size): Move up, remove filename parameter.
1729         (write_gdbindex_1): New function.
1730         (write_debug_names): Change return type to void, call
1731         assert_file_size.
1732         (struct index_wip_file): New struct.
1733         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1734         file logic to index_wip_file.  Write index for dwz file if
1735         needed.
1736         (save_gdb_index_command): Pass basename of dwz file, if present.
1737         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1738         build-id of dwz file, if present.
1739         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1740         (dwarf2_get_dwz_file): Likewise.
1741         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1742         (dwarf2_get_dwz_file): Likewise.
1743
1744 2019-06-16  Tom Tromey  <tom@tromey.com>
1745
1746         * coffread.c (process_coff_symbol): Use xstrdup.
1747         * value.c (create_internalvar): Use xstrdup.
1748
1749 2019-06-16  Tom Tromey  <tom@tromey.com>
1750
1751         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1752         * breakpoint.c (stopin_command, stopat_command)
1753         (until_break_command, decode_location_default): Remove unnecessary
1754         cast.
1755         * utils.c (subset_compare): Remove unnecessary cast.
1756         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1757         cast.
1758         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1759         cast.
1760         * infcmd.c (path_command): Remove unnecessary cast.
1761         * coffread.c (decode_type): Remove unnecessary cast.
1762         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1763         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1764         * tui/tui-stack.c (tui_show_locator_content)
1765         (tui_show_frame_info): Remove unnecessary cast.
1766         * tui/tui-win.c (tui_scroll_forward_command)
1767         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1768         (parse_scrolling_args): Remove unnecessary cast.
1769         * tui/tui-data.c (init_win_info, tui_del_window)
1770         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1771         (free_content_elements): Remove unnecessary cast.
1772         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1773         unnecessary cast.
1774         * tui/tui-source.c (tui_set_source_content)
1775         (tui_vertical_source_scroll): Remove unnecessary cast.
1776         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1777         cast.
1778         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1779         * tui/tui-regs.c (tui_display_registers_from)
1780         (tui_display_register): Remove unnecessary cast.
1781         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1782         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1783         (make_visible): Remove unnecessary cast.
1784         * tui/tui-winsource.c (tui_erase_source_content)
1785         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1786         unnecessary cast.
1787         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1788         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1789         * stabsread.c (read_type, read_array_type, read_range_type):
1790         Remove unnecessary cast.
1791         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1792         (parse_symbol, parse_type, upgrade_type, parse_external)
1793         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1794         unnecessary cast.
1795         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1796
1797 2019-06-16  Tom Tromey  <tom@tromey.com>
1798
1799         * tui/tui-data.c (tui_alloc_generic_win_info)
1800         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1801         checks.
1802
1803 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1804             Andrew Burgess  <andrew.burgess@embecosm.com>
1805
1806         * f-typeprint.c (f_print_type): Don't return early for not
1807         associated or not allocated types.
1808         (f_type_print_varspec_suffix): Add print_rank parameter and print
1809         ranks of array types in case they dangling.
1810         (f_type_print_base): Add print_rank parameter.
1811
1812 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1813
1814         * NEWS: Mention new MI commands.
1815         * break-catch-throw.c (enum exception_event_kind): Move to
1816         breakpoint.h.
1817         (print_mention_exception_catchpoint): Output text as a single
1818         message.
1819         (catch_exception_command_1): Rename to...
1820         (catch_exception_event): ...this, make non-static, update header
1821         command, and change some parameter types.
1822         (catch_catch_command): Update for changes to
1823         catch_exception_command_1.
1824         (catch_throw_command): Likewise.
1825         (catch_rethrow_command): Likewise.
1826         * breakpoint.c (enum exception_event_kind): Delete.
1827         * breakpoint.h (enum exception_event_kind): Moved here from
1828         break-catch-throw.c.
1829         (catch_exception_event): Declare.
1830         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1831         (mi_cmd_catch_throw): New function.
1832         (mi_cmd_catch_rethrow): New function.
1833         (mi_cmd_catch_catch): New function.
1834         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1835         'catch-catch' entries.
1836         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1837         (mi_cmd_catch_rethrow): Declare.
1838         (mi_cmd_catch_catch): Declare.
1839
1840 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1841
1842         * annotate.c (annotate_source_line): Change return type to void,
1843         update implementation to match.
1844         * annotate.h (annotate_source_line): Change return type to void,
1845         update header comment.
1846         * stack.c (print_frame_info): Don't change what frame information
1847         is printed based on whether annotations are on or not.
1848
1849 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1850
1851         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1852         (annotate_source): Make static.
1853         (annotate_source_line): Moved from source.c and renamed from
1854         identify_source_line.  Update the return type.
1855         * annotate.h (annotate_source): Delete declaration.
1856         (annotate_source_line): Declaration moved from source.h, and
1857         renamed from identify_source_line.  Return type updated.
1858         * source.c (identify_source_line): Moved to annotate.c and renamed
1859         to annotate_source_line.
1860         (info_line_command): Remove check of annotation_level.
1861         * source.h (identify_source_line): Move declaration to annotate.h
1862         and rename to annotate_source_line.
1863         * stack.c: Add 'annotate.h' include.
1864         (print_frame_info): Remove check of annotation_level before
1865         calling annotate_source_line.
1866
1867 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1868
1869         * source-cache.c (source_cache::get_plain_source_lines): Use
1870         open_source_file_with_line_charpos instead of just
1871         open_source_file, remove call to find_source_lines.
1872         (source_cache::get_source_lines): Likewise.
1873         * source.c (find_source_lines): Make static.
1874         (get_filename_and_charpos): Renamed into...
1875         (open_source_file_with_line_charpos): ..this along with changes to
1876         return a scoped_fd, and some other minor clean ups.
1877         (identify_source_line): Use open_source_file_with_line_charpos.
1878         (search_command_helper): Use open_source_file_with_line_charpos
1879         instead of just open_source_file, remove call to
1880         find_source_lines.
1881         * source.h (open_source_file_with_line_charpos): Declare new
1882         function.
1883         (find_source_lines): Delete declaration.
1884
1885 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1886
1887         * source.c (get_filename_and_charpos): Remove fullname
1888         parameter.
1889         (identify_source_line): Update call to get_filename_and_charpos.
1890
1891 2019-06-14  Tom Tromey  <tromey@adacore.com>
1892
1893         PR gdb/24502:
1894         * ui-style.h (skip_ansi_escape): Update comment.
1895         * ui-file.h (class no_terminal_escape_file): New class.
1896         * ui-file.c (no_terminal_escape_file::write)
1897         (no_terminal_escape_file::puts): New methods.
1898         * cli/cli-logging.c (handle_redirections): Use
1899         no_terminal_escape_file.
1900
1901 2019-06-14  Tom Tromey  <tromey@adacore.com>
1902
1903         * NEWS: Move convenience variable news above Python news.
1904
1905 2019-06-14  Tom Tromey  <tom@tromey.com>
1906
1907         * gnulib: Move directory to top-level.
1908         * configure.ac: Don't configure gnulib.
1909         * configure: Rebuild.
1910         * common/common-defs.h: Use new path to gnulib.
1911         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1912         (GNULIB_H): Remove.
1913         (INCGNU): Look in new gnulib location.
1914         (HFILES_NO_SRCDIR): Remove gnulib files.
1915         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1916         (generated_files): Remove GNULIB_H.
1917         ($(LIBGNU), all-lib): Remove targets.
1918         (distclean): Don't mention GNULIB_BUILDDIR.
1919         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1920
1921 2019-06-14  Tom Tromey  <tromey@adacore.com>
1922
1923         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1924         Warn if symbol file does not provide any symbols.
1925
1926 2019-06-14  Tom Tromey  <tromey@adacore.com>
1927
1928         * source.c (find_and_open_source): Respect basenames_may_differ.
1929
1930 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1931
1932         * annotate.c (annotate_breakpoints_invalid): Make use of
1933         scoped_restore_terminal_state.
1934         (annotate_frames_invalid): Likewise.
1935
1936 2019-06-14  Tom Tromey  <tromey@adacore.com>
1937
1938         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1939         allow assignment to an internalvar.
1940
1941 2019-06-14  Tom Tromey  <tromey@adacore.com>
1942
1943         * ada-lex.l: Allow "_" in attribute names.
1944
1945 2019-06-14  Tom Tromey  <tromey@adacore.com>
1946
1947         PR gdb/24653:
1948         * regcache.c (registers_changed): Don't call alloca.
1949         * top.c (execute_command): Don't call alloca.
1950
1951 2019-06-13  Pedro Alves  <palves@redhat.com>
1952
1953         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1954         'expression'.  When parsing an expression, error out if there's
1955         junk after "unlimited".
1956         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1957         (do_set_command): Adjust calls to is_unlimited_literal.
1958
1959 2019-06-13  Pedro Alves  <palves@redhat.com>
1960
1961         * compile/compile.c (make_compile_options_def_group): Add braces
1962         around array_view initializer.
1963         * thread.c (make_thread_apply_all_options_def_group)
1964         (make_thread_apply_all_options_def_group): Likewise.
1965
1966 2019-06-13  Pedro Alves  <palves@redhat.com>
1967
1968         * NEWS (New commands): Mention "maint test-options
1969         require-delimiter", "maint test-options unknown-is-error", "maint
1970         test-options unknown-is-operand" and "maint show
1971         test-options-completion-result".
1972         (New command options, command completion): New section.
1973         (Completion improvements): New section.
1974         Mention that you can abbreviate "unlimited".
1975
1976 2019-06-13  Pedro Alves  <palves@redhat.com>
1977
1978         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1979         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1980         * unittests/cli-utils-selftests.c (test_parse_flags)
1981         (test_parse_flags_qcs): Delete.
1982         (test_cli_utils): Don't call deleted functions.
1983
1984 2019-06-13  Pedro Alves  <palves@redhat.com>
1985
1986         * thread.c: Include "cli/cli-option.h".
1987         (tp_array_compar_ascending): Global.
1988         (tp_array_compar): Delete function.
1989         (tp_array_compar_ascending, tp_array_compar_descending): New
1990         functions.
1991         (ascending_option_def, qcs_flag_option_def)
1992         (thr_qcs_flags_option_defs)
1993         (make_thread_apply_all_options_def_group)
1994         (make_thread_apply_options_def_group): New.
1995         (thread_apply_all_command): Use gdb::option::process_options.
1996         (thread_apply_command_completer)
1997         (thread_apply_all_command_completer): New.
1998         (thread_apply_command): Use gdb::option::process_options.
1999         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2000         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2001         to generate help text of "thread apply".  Adjust "taas"'s help.
2002         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2003         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2004
2005 2019-06-13  Pedro Alves  <palves@redhat.com>
2006
2007         * thread.c (thread_apply_command): Check for invalid TID with
2008         isdigit instead of !isalpha.
2009
2010 2019-06-13  Pedro Alves  <palves@redhat.com>
2011
2012         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2013         (validate_flags_qcs): New.
2014         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2015         (validate_flags_qcs): Declare.
2016         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2017         (make_frame_apply_options_def_group): New.
2018         (frame_apply_command_count): Process options with
2019         gdb::option::process_options.
2020         (frame_apply_completer): New.
2021         (frame_apply_level_completer, frame_apply_all_completer)
2022         (frame_apply_completer): New.
2023         (_initialize_stack): Update help of "frame apply", "frame apply
2024         level", "frame apply all" and "faas" to mention supported options
2025         and install command completers.
2026         * stack.h (frame_apply_all_completer): Declare.
2027         * thread.c: Include "stack.h".
2028         (tfaas_command): Add "--".
2029         (_initialize_thread): Update help "tfaas" to mention supported
2030         options and install command completer.
2031
2032 2019-06-13  Pedro Alves  <palves@redhat.com>
2033
2034         * completer.c (complete_nested_command_line): New.
2035         (gdb_completion_word_break_characters_throw): Add assertion.
2036         * completer.h (complete_nested_command_line): Declare.
2037
2038 2019-06-13  Pedro Alves  <palves@redhat.com>
2039
2040         * stack.c (parse_backtrace_qualifiers): New.
2041         (backtrace_command): Use it.
2042         (backtrace_command_completer): Complete on qualifiers.
2043
2044 2019-06-13  Pedro Alves  <palves@redhat.com>
2045
2046         * frame.c: Include "cli/cli-option.h.
2047         (user_set_backtrace_options): New.
2048         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2049         Delete.
2050         (get_prev_frame): Adjust.
2051         (boolean_option_def, uinteger_option_def)
2052         (set_backtrace_option_defs): New.
2053         (_initialize_frame): Adjust and use
2054         gdb::option::add_setshow_cmds_for_options to install "set
2055         backtrace past-main" and "set backtrace past-entry".
2056         * frame.h: Include "cli/cli-option.h".
2057         (struct frame_print_options): Forward declare.
2058         (print_frame_arguments_all, print_frame_arguments_scalars)
2059         (print_frame_arguments_none): Declare.
2060         (print_entry_values): Delete declaration.
2061         (struct frame_print_options, user_frame_print_options): New.
2062         (struct set_backtrace_options): New.
2063         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2064         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2065         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2066         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2067         (list_args_or_locals): Add frame_print_options parameter.
2068         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2069         * python/py-framefilter.c (enumerate_args): Pass down
2070         USER_FRAME_PRINT_OPTIONS.
2071         * stack.c: Include "cli/cli-option.h".
2072         (print_frame_arguments_all, print_frame_arguments_scalars)
2073         (print_frame_arguments_none): Declare.
2074         (print_raw_frame_arguments, print_entry_values): Delete.
2075         (user_frame_print_options): New.
2076         (boolean_option_def, enum_option_def, frame_print_option_defs):
2077         New.
2078         (struct backtrace_cmd_options): New.
2079         (bt_flag_option_def): New.
2080         (backtrace_command_option_defs): New.
2081         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2082         (print_frame_arg, read_frame_arg, print_frame_args)
2083         (print_frame_info, print_frame): Add frame_print_options parameter
2084         and use it.
2085         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2086         (backtrace_command_1): Add frame_print_options and
2087         backtrace_cmd_options parameters and use them.
2088         (make_backtrace_options_def_group): New.
2089         (backtrace_command): Process command options with
2090         gdb::option::process_options.
2091         (backtrace_command_completer): New.
2092         (_initialize_stack): Extend "backtrace"'s help to mention
2093         supported options.  Install completer for "backtrace".
2094         Install some settings commands with add_setshow_cmds_for_options.
2095
2096 2019-06-13  Pedro Alves  <palves@redhat.com>
2097
2098         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2099         and that "set/show print raw frame-arguments" are now deprecated.
2100
2101         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2102         command.
2103         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2104         * stack.c (_initialize_stack): Install "set/show print
2105         raw-frame-arguments", and deprecate "set/show print raw
2106         frame-arguments".
2107         * valprint.c (_initialize_valprint): Deprecate "set/show print
2108         raw".
2109
2110 2019-06-13  Pedro Alves  <palves@redhat.com>
2111
2112         * compile/compile.c (struct compile_options): New.
2113         (compile_flag_option_def, compile_command_option_defs)
2114         (make_compile_options_def_group): New.
2115         (compile_file_command): Handle options with
2116         gdb::option::process_options.
2117         (compile_file_command_completer): New function.
2118         (compile_code_command): Handle options with
2119         gdb::option::process_options.
2120         (compile_code_command_completer): New function.
2121         (_initialize_compiler): Install completers for "compile code" and
2122         "compile file".  Mention available options in "compile code" and
2123         "compile code"'s help.
2124         * completer.c (advance_to_completion_word): New, factored out from
2125         ...
2126         (advance_to_expression_complete_word_point): ... this.
2127         (advance_to_filename_complete_word_point): New.
2128         * completer.h (advance_to_filename_complete_word_point): New
2129         declaration.
2130
2131 2019-06-13  Pedro Alves  <palves@redhat.com>
2132
2133         * compile/compile.c: Include "cli/cli-option.h".
2134         (compile_print_value): Scope data pointer is now a
2135         value_print_options pointer; adjust.
2136         (compile_print_command): Process options.  Scope data pointer is
2137         now a value_print_options pointer; adjust.
2138         (_initialize_compile): Update "compile print"'s help to include
2139         supported options.  Install a completer for "compile print".
2140         * cp-valprint.c (show_vtblprint, show_objectprint)
2141         (show_static_field_print): Delete.
2142         (_initialize_cp_valprint): Don't install "set print
2143         static-members", "set print vtbl", "set print object" here.
2144         * printcmd.c: Include "cli/cli-option.h" and
2145         "common/gdb_optional.h".
2146         (print_command_parse_format): Rework to fill in a
2147         value_print_options instead of a format_data.
2148         (print_value): Change parameter type from format_data pointer to
2149         value_print_options reference.  Adjust.
2150         (print_command_1): Process options.  Adjust to pass down a
2151         value_print_options.
2152         (print_command_completer): New.
2153         (_initialize_printcmd): Install print_command_completer as
2154         handle_brkchars completer for the "print" command.  Update
2155         "print"'s help to include supported options.
2156         * valprint.c: Include "cli/cli-option.h".
2157         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2158         here from cp-valprint.c.
2159         (boolean_option_def, uinteger_option_def)
2160         (value_print_option_defs, make_value_print_options_def_group):
2161         New.  Use gdb::option::add_setshow_cmds_for_options to install
2162         "set print elements", "set print null-stop", "set print repeats",
2163         "set print pretty", "set print union", "set print array", "set
2164         print address", "set print symbol", "set print array-indexes".
2165         * valprint.h: Include <string> and "cli/cli-option.h".
2166         (make_value_print_options_def_group): Declare.
2167         (print_value): Change parameter type from format_data pointer to
2168         value_print_options reference.
2169         (print_command_completer): Declare.
2170
2171 2019-06-13  Pedro Alves  <palves@redhat.com>
2172
2173         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2174         (COMMON_SFILES): Add maint-test-settings.c.
2175         * cli/cli-decode.c (boolean_enums): New global, factored out from
2176         ...
2177         (add_setshow_boolean_cmd): ... here.
2178         * cli/cli-decode.h (boolean_enums): Declare.
2179         * cli/cli-option.c: New file.
2180         * cli/cli-option.h: New file.
2181         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2182         factored out from ...
2183         (parse_cli_boolean_value(const char *)): ... this.
2184         (is_unlimited_literal): Change parameter type to pointer to
2185         pointer.  Adjust and advance ARG pointer.
2186         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2187         (parse_cli_var_enum): New, factored out from ...
2188         (do_set_command): ... this.  Adjust.
2189         * cli/cli-setshow.h (parse_cli_boolean_value)
2190         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2191         (parse_cli_var_enum): Declare.
2192         * cli/cli-utils.c: Include "cli/cli-option.h".
2193         (get_ulongest): New.
2194         * cli/cli-utils.h (get_ulongest): Declare.
2195         (check_for_argument): New overloads.
2196         * maint-test-options.c: New file.
2197
2198 2019-06-13  Pedro Alves  <palves@redhat.com>
2199
2200         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2201         parse a range if "-" is at the end of the string.
2202
2203 2019-06-13  Pedro Alves  <palves@redhat.com>
2204
2205         * cli/cli-setshow.c (parse_auto_binary_operation)
2206         (parse_cli_boolean_value): Don't allow "o".
2207
2208 2019-06-13  Pedro Alves  <palves@redhat.com>
2209
2210         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2211         * NEWS: Mention maint test-settings KIND.
2212         * maint-test-settings.c: New file.
2213
2214 2019-06-13  Pedro Alves  <palves@redhat.com>
2215
2216         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2217         completer.
2218         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2219         "set" completers.
2220
2221 2019-06-13  Pedro Alves  <palves@redhat.com>
2222
2223         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2224         after item.
2225
2226 2019-06-13  Pedro Alves  <palves@redhat.com>
2227
2228         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2229
2230 2019-06-13  Pedro Alves <palves@redhat.com>
2231
2232         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2233         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2234         call.
2235         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2236         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2237         calls.
2238         (check_for_argument): Skip spaces after argument.
2239
2240 2019-06-13  Pedro Alves  <palves@redhat.com>
2241
2242         * thread.c (thread_apply_command): Adjust TID parsing.
2243         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2244         detected before end of string.
2245         (tid_is_in_list): Error out if LIST is invalid.
2246
2247 2019-06-13  Pedro Alves  <palves@redhat.com>
2248
2249         * completer.c (complete_line_internal_1): Rewind completion word
2250         point.
2251         (completion_tracker::advance_custom_word_point_by): Change
2252         parameter type to int.
2253         * completer.h (completion_tracker::advance_custom_word_point_by):
2254         Likewise.
2255
2256 2019-06-13  Pedro Alves  <palves@redhat.com>
2257
2258         * completer.c (advance_to_completion_word): Handle delimiters.
2259
2260 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2261
2262         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2263
2264 2019-06-11  Tom Tromey  <tom@tromey.com>
2265
2266         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2267         (xmalloc_failed): Move to alloc.c.
2268         * alloc.c: New file.
2269         * Makefile.in (COMMON_SFILES): Add alloc.c.
2270
2271 2019-06-11  Tom Tromey  <tom@tromey.com>
2272
2273         * nat/linux-waitpid.c: Don't include server.h.
2274         (linux_debug): Remove.
2275         (my_waitpid): Update.
2276
2277 2019-06-11  Tom Tromey  <tromey@adacore.com>
2278
2279         * infcall.c (_initialize_infcall): Remove trailing newline from
2280         help.
2281         * user-regs.c (_initialize_user_regs): Remove trailing newline
2282         from help.
2283         * typeprint.c (_initialize_typeprint): Remove trailing newline
2284         from help.
2285         * reverse.c (_initialize_reverse): Remove trailing newlines from
2286         help.
2287         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2288         from help.
2289         * language.c (add_set_language_command): Remove trailing newline
2290         from help.
2291         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2292         help.
2293         * disasm.c (_initialize_disasm): Remove trailing newline from
2294         help.
2295         * top.c (init_main): Remove trailing newline from help.
2296         * interps.c (_initialize_interpreter): Remove trailing newline
2297         from help.
2298         * btrace.c (_initialize_btrace): Remove trailing newlines from
2299         help.
2300         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2301         from help.
2302         * python/python.c (_initialize_python): Remove trailing newline
2303         from help.
2304         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2305         help.
2306         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2307         from help.  Reformat some text.
2308         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2309         from help.
2310         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2311         newline from help.
2312
2313 2019-06-11  Tom Tromey  <tromey@adacore.com>
2314
2315         * darwin-nat.c (darwin_decode_exception_message)
2316         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2317
2318 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2319
2320         * valops.c (value_slice): Check for not allocated or not
2321         associated values.
2322
2323 2019-06-10  Tom de Vries  <tdevries@suse.de>
2324
2325         PR gdb/24618
2326         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2327         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2328         invalid.
2329
2330 2019-06-10  Tom de Vries  <tdevries@suse.de>
2331
2332         PR gdb/24611
2333         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2334         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2335
2336 2019-06-10  Tom de Vries  <tdevries@suse.de>
2337
2338         PR symtab/24545
2339         * symtab.c (struct demangled_name_entry): Add language field.
2340         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2341         static minimal symbol".  Set and use language field.
2342
2343 2019-06-10  Tom Tromey  <tromey@adacore.com>
2344
2345         * ada-lang.c (_initialize_ada_language): Update help text.
2346
2347 2019-06-10  Tom Tromey  <tromey@adacore.com>
2348
2349         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2350         with a newline.
2351         * guile/guile.c (handle_boot_error): Don't end warning with a
2352         newline.
2353         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2354         warning with a newline.
2355         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2356         newline.
2357         (s12z_frame_cache): Likewise.
2358         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2359         a newline.
2360         * solib-svr4.c (disable_probes_interface): Don't end warning with
2361         a newline.
2362         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2363         newline.
2364         * python/python.c (do_finish_initialization): Don't end warning
2365         with a newline.
2366
2367 2019-06-10  Tom Tromey  <tom@tromey.com>
2368
2369         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2370         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2371         gdbpy_enter.
2372
2373 2019-06-10  Tom Tromey  <tromey@adacore.com>
2374
2375         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2376         data.
2377         (elf_new_init): Don't call stabsread_new_init.
2378         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2379         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2380         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2381
2382 2019-06-10  Tom de Vries  <tdevries@suse.de>
2383
2384         PR symtab/16264
2385         PR symtab/24517
2386         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2387
2388 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2389
2390         * source.c (find_and_open_source): Also rewrite relative file
2391         names.
2392
2393 2019-04-26  Amos Bird  <amosbird@gmail.com>
2394
2395         * annotate.c (annotate_thread_exited): Add "thread-exited"
2396         annotation.
2397
2398 2019-06-06  Tom Tromey  <tromey@adacore.com>
2399
2400         * maint.h (class scoped_command_stats): Use
2401         DISABLE_COPY_AND_ASSIGN.
2402         <print_time>: New method.
2403         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2404         print_time.
2405         (scoped_command_stats::print_time): New method.
2406
2407 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2408
2409         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2410         instructions of lengths 6 or 8 bytes.
2411
2412 2019-06-04  Pedro Alves  <palves@redhat.com>
2413
2414         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2415
2416         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2417         * breakpoint.c (condition_completer): Likewise.
2418         * cli/cli-dump.c (scan_expression): Likewise.
2419         * common/filestuff.c (mkdir_recursive): Likewise.
2420         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2421         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2422         (gdb_abspath): Likewise.
2423         * compile/compile-cplus-types.c
2424         (compile_cplus_instance::decl_name): Likewise.
2425         * completer.c (complete_explicit_location):
2426         (signal_completer, reg_or_group_completer_1): Likewise.
2427         * cp-support.c (cp_remove_params_if_any): Likewise.
2428         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2429         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2430         * infcmd.c (strip_bg_char): Likewise.
2431         * linespec.c (copy_token_string): Likewise.
2432         * mi/mi-main.c (output_cores): Likewise.
2433         * psymtab.c (psymtab_search_name):
2434         * symfile.c (test_set_ext_lang_command): Likewise.
2435         * target.c (target_fileio_read_stralloc): Likewise.
2436         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2437         * value.c (complete_internalvar): Likewise.
2438
2439 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2440
2441         Add objfile property to gdb.Type.
2442         * NEWS: Mention Python API addition.
2443         * python/py-type.c (typy_get_objfile): New method.
2444
2445 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2446
2447         * NEWS: Mention the new set|show style [title|highlight].
2448         Mention changes to "show style", "help" and "apropos".
2449
2450 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2451
2452         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2453         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2454         instead of print_help_for_command.
2455         (print_doc_of_command): New function.
2456         (help_list): Add 'apropos -v word' suggestion.
2457         (print_help_for_command): Style the command name using title style.
2458         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2459         (_initialize_cli_cmds): Describe -v in apropos_command help.
2460
2461 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2462
2463         * cli/cli-style.h (cli_style_option): Add name in constructor,
2464         add m_name class member, add constructor with intensity,
2465         add name class function.
2466         (cli_style_option::add_setshow_commands): Remove name argument.
2467         (highlight_style, title_style): New styles.
2468         * cli/cli-style.c (do_show): New function that shows a style
2469         characteristic styling the style name with itself.
2470         (set_style_name): New function.
2471         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2472         Update all callers according to the changes in cli/cli-style.h.
2473         * utils.h (fputs_highlighted): New function.
2474         * utils.c (fputs_highlighted): Likewise.
2475
2476 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2477
2478         * NEWS: Mention new pipe command and new convenience variables.
2479
2480 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2481
2482         * cli/cli-cmds.c (pipe_command): New function.
2483         (_initialize_cli_cmds): Call add_com for pipe_command.
2484         Define | as an alias for pipe.
2485         (exit_status_set_internal_vars): New function.
2486         (shell_escape): Call exit_status_set_internal_vars.
2487         cli/cli-decode.c (find_command_name_length): Recognize | as
2488         a single character command.
2489
2490 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2491
2492         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2493         top.c (execute_command_to_ui_file): New function, mostly a copy
2494         of execute_command_to_string.
2495         (execute_command_to_string): Implement by calling
2496         execute_command_to_ui_file.
2497
2498 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2499
2500         * top.h (saved_command_line): Remove declaration.
2501         * top.c (previous_saved_command_line, previous_repeat_arguments):
2502         New variables.
2503         (saved_command_line): Make static, define together with other
2504         'repeat variables'.
2505         (dont_repeat): Clear repeat_arguments.
2506         (repeat_previous, get_saved_command_line, save_command_line):
2507         New functions.
2508         (gdb_init): Initialize saved_command_line
2509         and previous_saved_command_line.
2510         * main.c (captured_main_1): Remove saved_command_line initialization.
2511         * event-top.c (handle_line_of_input): Update to use
2512         the new 'repeat' related functions instead of direct access to
2513         saved_command_line.
2514         * command.h (repeat_previous, get_saved_command_line,
2515         save_command_line): New declarations.
2516         (dont_repeat): Add comment.
2517
2518 2019-05-30  Tom Tromey  <tromey@adacore.com>
2519
2520         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2521         Fix comment.
2522         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2523
2524 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2525
2526         PR cli/24587
2527         * completer.c (complete): Initialize variable word.
2528
2529 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2530
2531         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2532         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2533         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2534         'body' is NULL to the outter 'if', protecting the '!is_define'
2535         situation as well.
2536
2537 2019-05-29  Tom Tromey  <tromey@adacore.com>
2538
2539         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2540         (dwarf_unknown): New function.
2541         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2542         (dwarf_type_encoding_name): Use dwarf_unknown.
2543
2544 2019-05-29  Tom Tromey  <tromey@adacore.com>
2545
2546         PR c++/20020:
2547         * cp-valprint.c (cp_print_value_fields): Call
2548         cp_print_static_field inside "try".
2549
2550 2019-05-29  Tom Tromey  <tromey@adacore.com>
2551
2552         * inflow.c (struct terminal_info): Add default operator=.
2553         * configure: Rebuild.
2554         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2555         -Wdeprecated-copy-dtor, -Wredundant-move.
2556
2557 2019-05-29  Tom Tromey  <tromey@adacore.com>
2558
2559         * NEWS: Add entry.
2560         * infcmd.c (print_return_value_1): Handle finish_print
2561         option.
2562         (show_print_finish): New function.
2563         (_initialize_infcmd): Add "set/show print finish" commands.
2564         * valprint.c (user_print_options): Initialize new member.
2565         * valprint.h (struct value_print_options) <finish_print>: New
2566         member.
2567
2568 2019-05-28  Tom Tromey  <tromey@adacore.com>
2569
2570         * ada-lang.c (ada_remove_Xbn_suffix)
2571         (find_old_style_renaming_symbol)
2572         (parse_old_style_renaming): Remove.
2573         (ada_find_renaming_symbol): Don't call
2574         find_old_style_renaming_symbol.
2575         (ada_is_renaming_symbol): Rename from
2576         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2577         bool.  Now static.
2578         (ada_read_var_value): Update and simplify.
2579         * ada-exp.y (write_var_or_type): Remove old code.
2580
2581 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2582
2583         * event-top.c: Remove include comment.
2584         * inflow.c (class scoped_ignore_sigttou): Move from here...
2585         * inflow.h (class scoped_ignore_sigttou): ...to here.
2586         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2587         * top.c:  Remove include comment.
2588
2589 2019-05-27  Tom Tromey  <tom@tromey.com>
2590
2591         * NEWS: Fix typo.
2592
2593 2019-05-22  Tom Tromey  <tromey@adacore.com>
2594
2595         * target.c (target_follow_exec): Constify parameter.
2596         * target-delegates.c: Rebuild.
2597         * remote.c (remote_target::follow_exec): Constify parameter.
2598         * infrun.c (follow_exec): Constify parameter.
2599         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2600         (target_follow_exec): Likewise.
2601
2602 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2603
2604         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2605         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2606
2607 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2608
2609         * NEWS: Add debugredirect and testsuite sections.
2610
2611 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2612
2613         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2614         target descriptions using exclusively floating point register name
2615         aliases.
2616
2617 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2618
2619         PR gdb/18644:
2620         * f-lang.c (build_fortran_types): Handle the case where
2621         gdbarch_floatformat_for_type returns a nullptr.
2622
2623 2019-05-21  Tom de Vries  <tdevries@suse.de>
2624
2625         PR cli/24587
2626         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2627
2628 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2629
2630         PR gdb/18644:
2631         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2632         16-byte floats.
2633         * i386-tdep.c (i386_floatformat_for_type): Use
2634         floatformats_ia64_quad for the 16-byte floating point component
2635         within a fortran 32-byte complex number.
2636
2637 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2638
2639         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2640         delete default constructor.
2641         (find_partial_die): Update to return const struct.
2642         (partial_die_parent_scope): Move variable declaration into scope
2643         of its use and change its type to auto.
2644         (guess_partial_die_structure_name): Likewise.
2645         (partial_die_info::fixup): Likewise.
2646
2647 2019-05-17  Tom Tromey  <tromey@adacore.com>
2648
2649         * source.c (find_and_open_source): Remove cast.
2650
2651 2019-05-17  Tom Tromey  <tromey@adacore.com>
2652
2653         * annotate.c (annotate_source): Make "filename" const.
2654         * annotate.h (annotate_source): Use const.
2655
2656 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2657
2658         * disasm.c (set_disassembler_options): Send errors to stderr.
2659
2660 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2661
2662         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2663         (cli_interp_base::set_logging): Check debug_redirect.
2664         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2665         * cli/cli-logging.c (debug_redirect): Add static variable.
2666         (pop_output_files): Add default param.
2667         (handle_redirections): Print debug setting.
2668         (show_logging_command): Likewise.
2669         (_initialize_cli_logging): Add debugredirect command.
2670         * interps.c (current_interp_set_logging): Add debug_redirect
2671         parameter.
2672         * interps.h (set_logging): Add debug_redirect parameter.
2673         (current_interp_set_logging): Likewise.
2674         * mi/mi-common.h: Likewise.
2675         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2676
2677 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2678             Tom Tromey  <tromey@adacore.com>
2679
2680         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2681         directly.
2682         * cli/cli-interp.h (make_logging_output): Remove declaration.
2683         * cli/cli-logging.c (make_logging_output): Remove function.
2684         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2685         directly.
2686         * ui-file.c (tee_file::tee_file): Remove bools.
2687         (tee_file::~tee_file): Remove deletes.
2688         * ui-file.h (tee_file): Remove bools.
2689
2690 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2691
2692         * mi/mi-cmds.h (mi_cmd_complete): New function.
2693         * mi/mi-main.c (mi_cmd_complete): Likewise.
2694         * mi/mi-cmds.c: Define new MI command -complete.
2695         * NEWS: Mention new -complete command.
2696
2697 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2698
2699         * completer.h (complete): New function.
2700         * completer.c (complete): Likewise.
2701         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2702         function defined in completer.h.
2703
2704 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2705
2706         * MAINTAINERS (Write After Approval): Add myself.
2707
2708 2019-05-17  Tom de Vries  <tdevries@suse.de>
2709
2710         PR gdb/24094
2711         * dwarf2read.c (struct cu_partial_die_info): New struct.
2712         (find_partial_die): Return cu_partial_die_info.
2713         (partial_die_parent_scope, guess_partial_die_structure_name)
2714         (partial_die_info::fixup): Handle new return type of find_partial_die.
2715
2716 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2717
2718         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2719         "std::string", simplifying the algorithm.
2720
2721 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2722
2723         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2724         (stap_static_probe_ops::get_probes): Likewise.
2725
2726 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2727
2728         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2729         '-')" and "else if".
2730         (stap_parse_single_operand): Join checks for
2731         "gdbarch_stap_parse_special_token_p" and
2732         "gdbarch_stap_parse_special_token" in the same "if" statement.
2733         Invert check when verifying for operation on register
2734         displacement.
2735
2736 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2737
2738         * stap-probe.c (stap_get_opcode): Update comment.
2739         (stap_get_expected_argument_type): Likewise.
2740         (handle_stap_probe): Likewise.
2741
2742 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2743
2744         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2745         return type to 'bool'.  Adjust comment.  Use 'bool' when
2746         appropriate.
2747         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2748         * stap-probe.c (stap_parse_argument_1): Likewise.
2749         (stap_is_operator): Likewise.
2750         (stap_is_generic_prefix): Likewise.
2751         (stap_is_register_prefix): Likewise.
2752         (stap_is_register_indirection_prefix): Likewise.
2753         (stap_is_integer_prefix): Likewise.
2754         (stap_generic_check_suffix): Likewise.
2755         (stap_check_integer_suffix): Likewise.
2756         (stap_check_register_suffix): Likewise.
2757         (stap_check_register_indirection_suffix): Likewise.
2758         (stap_parse_register_operand): Likewise.
2759         (stap_parse_single_operand): Likewise.
2760         (stap_parse_argument_1): Likewise.
2761         (stap_probe::get_argument_count): Likewise.
2762         (stap_is_operator): Likewise.
2763
2764 2019-05-16  Tom Tromey  <tromey@adacore.com>
2765
2766         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2767         keyword to foreach.
2768
2769 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2770
2771         * linux-thread-db.c (try_thread_db_load_1): Change return type
2772         to bool.
2773         (try_thread_db_load): Likewise.
2774         (try_thread_db_load_from_pdir_1): Likewise.
2775         (try_thread_db_load_from_pdir): Likewise.
2776         (try_thread_db_load_from_sdir): Likewise.
2777         (try_thread_db_load_from_dir): Likewise.
2778         (thread_db_load_search): Likewise.
2779         (has_libpthread): Likewise.
2780         (thread_db_load): Likewise.
2781
2782 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2783
2784         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2785         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2786         NULL, and complain/return if that's the case.
2787
2788 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2789
2790         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2791         (advance, posn, abstract_read_memory): New functions.
2792         [struct mem_read_abstraction]: New struct.
2793         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2794
2795 2019-05-14  Tom Tromey  <tromey@adacore.com>
2796
2797         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2798         value is not lval_memory.
2799
2800 2019-05-14  Tom Tromey  <tromey@adacore.com>
2801
2802         * solib.c (info_sharedlibrary_command): Style the file name.
2803
2804 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2805
2806         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2807         (aarch64_vnv_type): Likewise.
2808         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2809         * common/tdesc.c: Likewise.
2810         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2811         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2812         * features/aarch64-fpu.xml: Add ieee half view.
2813         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2814         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2815         * gdbtypes.h (struct builtin_type): Likewise.
2816         (struct objfile_type): Likewise.
2817
2818 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2819
2820         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2821         typo.
2822         * location.h (string_to_event_location): Likewise.
2823
2824 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2825
2826         GDB 8.3 released.
2827
2828 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2829
2830         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2831         New variable declaration.
2832         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2833         New variable.
2834         (print_one_breakpoint): Use ui_out::test_flags and new global
2835         variable to compute use_fixed_output.
2836         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2837         Remove.
2838         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2839         (mi_multi_location_breakpoint_output_fixed): Remove.
2840         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2841         new variable.
2842         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2843         fix_multi_location_breakpoint_output flag if version >= 3.
2844         * ui-out.h (enum ui_out_flag)
2845         <fix_multi_location_breakpoint_output>: New enumerator.
2846
2847 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2848
2849         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2850
2851 2019-05-10  Tom Tromey  <tromey@adacore.com>
2852
2853         * ada-lang.c (catch_ada_completer): New function.
2854         (_initialize_ada_language): Use it.
2855
2856 2019-05-10  Tom Tromey  <tromey@adacore.com>
2857
2858         * thread.c (print_thread_info): Make "requested_threads" const.
2859         * gdbthread.h (print_thread_info): Make "requested_threads"
2860         const.
2861         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2862         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2863
2864 2019-05-08  Tom Tromey  <tom@tromey.com>
2865
2866         * gdbtypes.c (objfile_type_data): Change type.
2867         (objfile_type, _initialize_gdbtypes): Update.
2868
2869 2019-05-08  Tom Tromey  <tom@tromey.com>
2870
2871         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2872         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2873         (_initialize_dwarf2_frame): Update.
2874
2875 2019-05-08  Tom Tromey  <tom@tromey.com>
2876
2877         * objc-lang.c (objc_objfile_data): Change type.
2878         (find_methods): Update.
2879         (_initialize_objc_lang): Remove.
2880
2881 2019-05-08  Tom Tromey  <tom@tromey.com>
2882
2883         * stabsread.c (rs6000_builtin_type_data): Change type.
2884         (rs6000_builtin_type, _initialize_stabsread): Update.
2885
2886 2019-05-08  Tom Tromey  <tom@tromey.com>
2887
2888         * mips-tdep.c (mips_pdr_data): Remove.
2889         (_initialize_mips_tdep): Update.
2890
2891 2019-05-08  Tom Tromey  <tom@tromey.com>
2892
2893         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2894         (hppa_init_objfile_priv_data, read_unwind_info)
2895         (find_unwind_entry, _initialize_hppa_tdep): Update.
2896
2897 2019-05-08  Tom Tromey  <tom@tromey.com>
2898
2899         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2900         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2901         on obstack.
2902         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2903
2904 2019-05-08  Tom Tromey  <tom@tromey.com>
2905
2906         * mdebugread.c (basic_type_data): Change type.
2907         (basic_type, _initialize_mdebugread): Update.
2908
2909 2019-05-08  Tom Tromey  <tom@tromey.com>
2910
2911         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2912
2913 2019-05-08  Tom Tromey  <tom@tromey.com>
2914
2915         * nto-tdep.c (nto_inferior_data_reg): Change type.
2916         (nto_inferior_data): Update.
2917         (nto_inferior_data_cleanup, nto_new_inferior_data)
2918         (_initialize_nto_tdep): Remove.
2919         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2920
2921 2019-05-08  Tom Tromey  <tom@tromey.com>
2922
2923         * ada-lang.c (struct ada_inferior_data): Add initializers.
2924         (ada_inferior_data): Change type.
2925         (ada_inferior_data_cleanup): Remove.
2926         (get_ada_inferior_data, ada_inferior_exit)
2927         (struct ada_pspace_data): Add initializers, destructor.
2928         (ada_pspace_data_handle): Change type.
2929         (get_ada_pspace_data): Update.
2930         (ada_pspace_data_cleanup): Remove.
2931
2932 2019-05-08  Tom Tromey  <tom@tromey.com>
2933
2934         * coffread.c (struct coff_symfile_info): Add initializers.
2935         (coff_objfile_data_key): Move lower.  Change type.
2936         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2937         Update.
2938         (coff_free_info): Remove.
2939
2940 2019-05-08  Tom Tromey  <tom@tromey.com>
2941
2942         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2943         (fbsd_pspace_data_handle): Move lower.  Change type.
2944         (get_fbsd_pspace_data): Update.
2945         (fbsd_pspace_data_cleanup): Remove.
2946         (_initialize_fbsd_tdep): Update.
2947
2948 2019-05-08  Tom Tromey  <tom@tromey.com>
2949
2950         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2951         (get_ada_tasks_pspace_data): Update.
2952         (ada_tasks_pspace_data_cleanup): Remove.
2953         (_initialize_tasks): Update.
2954         (ada_tasks_inferior_data_handle): Change type.
2955         (get_ada_tasks_inferior_data): Update.
2956         (ada_tasks_inferior_data_cleanup): Remove.
2957         (struct ada_tasks_pspace_data): Add initializers.
2958
2959 2019-05-08  Tom Tromey  <tom@tromey.com>
2960
2961         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2962         * symfile-debug.c (debug_sym_get_probes): Change type.
2963         * stap-probe.c (handle_stap_probe):
2964         (stap_static_probe_ops::get_probes): Change type.
2965         * probe.h (class static_probe_ops) <get_probes>: Change type.
2966         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2967         (parse_probes_in_pspace): Update.
2968         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2969         Update.
2970         (any_static_probe_ops::get_probes): Change type.
2971         * elfread.c (elfread_data): New typedef.
2972         (probe_key): Change type.
2973         (elf_get_probes): Likewise.  Update.
2974         (probe_key_free): Remove.
2975         (_initialize_elfread): Update.
2976         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2977         Change type.
2978         (dtrace_process_dof_probe, dtrace_process_dof)
2979         (dtrace_static_probe_ops::get_probe): Change type.
2980
2981 2019-05-08  Tom Tromey  <tom@tromey.com>
2982
2983         * xcoffread.c (struct xcoff_symfile_info): Rename from
2984         coff_symfile_info.  Add initializers.
2985         (xcoff_objfile_data_key): Move lower.  Change type.
2986         (XCOFF_DATA): Rewrite.
2987         (xcoff_free_info): Remove.
2988         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2989         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2990         (xcoff_initial_scan): Update.
2991
2992 2019-05-08  Tom Tromey  <tom@tromey.com>
2993
2994         * solib-svr4.c (struct svr4_info): Add initializers and
2995         destructor.
2996         <probes_table>: Now an htab_up.
2997         (solib_svr4_pspace_data): Change type.
2998         (free_probes_table): Simplify.
2999         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3000         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3001         (probes_table_remove_objfile_probes, register_solib_event_probe)
3002         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3003         (_initialize_svr4_solib): Update.
3004
3005 2019-05-08  Tom Tromey  <tom@tromey.com>
3006
3007         * remote.c (remote_pspace_data): Change type.
3008         (remote_pspace_data_cleanup): Remove.
3009         (get_remote_exec_file, set_pspace_remote_exec_file)
3010         (_initialize_remote): Update.
3011
3012 2019-05-08  Tom Tromey  <tom@tromey.com>
3013
3014         * breakpoint.c (breakpoint_objfile_key): Change type.
3015         (get_breakpoint_objfile_data): Update.
3016         (free_breakpoint_objfile_data): Remove.
3017         (_initialize_breakpoint): Update.
3018
3019 2019-05-08  Tom Tromey  <tom@tromey.com>
3020
3021         * linux-tdep.c (struct linux_info): Add initializers.
3022         (linux_inferior_data): Move.  Change type.
3023         (invalidate_linux_cache_inf): Update.
3024         (linux_inferior_data_cleanup): Remove.
3025         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3026
3027 2019-05-08  Tom Tromey  <tom@tromey.com>
3028
3029         * auxv.c (auxv_inferior_data): Move.  Change type.
3030         (auxv_inferior_data_cleanup): Remove.
3031         (invalidate_auxv_cache_inf): Rewrite.
3032         (get_auxv_inferior_data, _initialize_auxv): Update.
3033
3034 2019-05-08  Tom Tromey  <tom@tromey.com>
3035
3036         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3037         (symfile_debug_objfile_data_key): Change type.
3038         (symfile_debug_installed, debug_qf_has_symbols)
3039         (debug_qf_find_last_source_symtab)
3040         (debug_qf_forget_cached_source_info)
3041         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3042         (debug_qf_print_stats, debug_qf_dump)
3043         (debug_qf_expand_symtabs_for_function)
3044         (debug_qf_expand_all_symtabs)
3045         (debug_qf_expand_symtabs_with_fullname)
3046         (debug_qf_map_matching_symbols)
3047         (debug_qf_expand_symtabs_matching)
3048         (debug_qf_find_pc_sect_compunit_symtab)
3049         (debug_qf_map_symbol_filenames)
3050         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3051         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3052         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3053         (debug_sym_read_linetable, debug_sym_relocate): Update.
3054         (symfile_debug_free_objfile): Remove.
3055         (install_symfile_debug_logging, _initialize_symfile_debug):
3056         Update.
3057
3058 2019-05-08  Tom Tromey  <tom@tromey.com>
3059
3060         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3061         allocate_on_obstack.
3062         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3063         (get_dwarf2_per_objfile): Update.
3064         (set_dwarf2_per_objfile): Remove.
3065         (dwarf2_has_info, dwarf2_get_section_info): Update.
3066         (dwarf2_free_objfile): Remove.
3067         (_initialize_dwarf2_read): Update.
3068
3069 2019-05-08  Tom Tromey  <tom@tromey.com>
3070
3071         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3072         initializers.
3073         <unsupported_script_warning_printed,
3074         script_not_found_warning_printed>: Now bool.
3075         (auto_load_pspace_data): Change type.
3076         (~auto_load_pspace_info): Rename from
3077         auto_load_pspace_data_cleanup.
3078         (get_auto_load_pspace_data, init_loaded_scripts_info)
3079         (clear_section_scripts, maybe_print_unsupported_script_warning)
3080         (maybe_print_script_not_found_warning, _initialize_auto_load):
3081         Update.
3082
3083 2019-05-08  Tom Tromey  <tom@tromey.com>
3084
3085         * objfiles.c (objfile_pspace_info): Add destructor and
3086         initializers.
3087         (objfiles_pspace_data): Change type.
3088         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3089         (get_objfile_pspace_data): Update.
3090         (objfiles_bfd_data): Change type.
3091         (get_objfile_bfd_data): Update.
3092         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3093
3094 2019-05-08  Tom Tromey  <tom@tromey.com>
3095
3096         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3097         Change type.
3098         (get_catch_syscall_inferior_data): Update.
3099         (catch_syscall_inferior_data_cleanup): Remove.
3100         (_initialize_break_catch_syscall): Update.
3101
3102 2019-05-08  Tom Tromey  <tom@tromey.com>
3103
3104         * inflow.c (struct terminal_info): Add destructor and
3105         initializers.
3106         (inflow_inferior_data): Change type.
3107         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3108         (get_inflow_inferior_data, inflow_inferior_exit)
3109         (swap_terminal_info, _initialize_inflow): Update.
3110
3111 2019-05-08  Tom Tromey  <tom@tromey.com>
3112
3113         * target-dcache.c (target_dcache_cleanup): Remove.
3114         (target_dcache_aspace_key): Change type.
3115         (target_dcache_init_p, target_dcache_invalidate)
3116         (target_dcache_get, target_dcache_get_or_init)
3117         (_initialize_target_dcache): Update.
3118         * dcache.h (struct dcache_deleter): New.
3119
3120 2019-05-08  Tom Tromey  <tom@tromey.com>
3121
3122         * symtab.c (struct symbol_cache): Add destructor and
3123         initializers.
3124         (symbol_cache_key): Move.  Change type.
3125         (make_symbol_cache, free_symbol_cache): Remove.
3126         (get_symbol_cache): Update.
3127         (symbol_cache_cleanup): Remove.
3128         (ALL_PSPACES, symbol_cache_flush)
3129         (maintenance_print_symbol_cache)
3130         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3131         Update.
3132
3133 2019-05-08  Tom Tromey  <tom@tromey.com>
3134
3135         * symtab.c (struct main_info): Add destructor and initializers.
3136         (main_progspace_key): Move.  Change type.
3137         (get_main_info): Update.
3138         (main_info_cleanup): Remove.
3139         (_initialize_symtab): Update.
3140
3141 2019-05-08  Tom Tromey  <tom@tromey.com>
3142
3143         * registry.h (DECLARE_REGISTRY): Define the _key class.
3144
3145 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3146
3147         * NEWS: Merge two 'New commands' sections.
3148
3149 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3150
3151         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3152         parameter and use Ada language definition instead.
3153         (ada_val_print_ptr): Remove unused language parameter.
3154         (ada_val_print_num): Remove language parameter and use Ada language
3155         definition instead.
3156         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3157         parameter.
3158         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3159         parameter and use Ada language definition instead.
3160         (ada_val_print_1): Update all ada_val_print_xxx calls.
3161         Remove language parameter.
3162         (ada_val_print): Update ada_val_print_1 call.
3163
3164 2019-05-08  Tom Tromey  <tromey@adacore.com>
3165
3166         * remote.c (remote_hw_watchpoint_limit)
3167         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3168         Now static.
3169
3170 2019-05-08  Tom Tromey  <tromey@adacore.com>
3171
3172         * maint.c (_initialize_maint_cmds): Move initialization code to
3173         remote.c.
3174         (watchdog, show_watchdog): Move to remote.c.
3175         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3176         "watchdog" static.
3177         (_initialize_remote): Move initialization code from maint.c.
3178         * defs.h (watchdog): Don't declare.
3179
3180 2019-05-08  Tom Tromey  <tromey@adacore.com>
3181
3182         * tui/tui-interp.c: Include main.h.
3183         * interps.c: Include main.h.
3184         * main.h (interpreter_p): Declare.
3185         * defs.h (interpreter_p): Don't declare.
3186
3187 2019-05-08  Tom Tromey  <tromey@adacore.com>
3188
3189         * dwarf2loc.c: Include dwarf2read.h.
3190         * defs.h (read_unsigned_leb128): Don't declare.
3191         * dwarf2read.h (read_unsigned_leb128): Declare.
3192
3193 2019-05-08  Tom Tromey  <tromey@adacore.com>
3194
3195         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3196         method.
3197
3198 2019-05-08  Tom Tromey  <tromey@adacore.com>
3199
3200         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3201         when no wrap column is set.
3202
3203 2019-05-08  Tom Tromey  <tromey@adacore.com>
3204
3205         * c-lang.c (c_get_string): Handle non-C-style arrays.
3206
3207 2019-05-08  Tom Tromey  <tromey@adacore.com>
3208
3209         * typeprint.c (print_offset_data::update): Print the bit offset,
3210         not the number of bits remaining.
3211
3212 2019-05-08  Tom Tromey  <tromey@adacore.com>
3213
3214         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3215         padding at end of comment.
3216
3217 2019-05-08  Tom Tromey  <tromey@adacore.com>
3218
3219         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3220         Compare main types.
3221
3222 2019-05-06  Tom Tromey  <tom@tromey.com>
3223
3224         * common/scoped_mmap.c: Include common-defs.h.
3225         * common/scoped_mmap.h: Don't include config.h.
3226
3227 2019-05-04  Tom Tromey  <tom@tromey.com>
3228
3229         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3230         (struct aarch64_call_info): Add initializers.
3231         <si>: Now a std::vector.
3232         (pass_on_stack, aarch64_push_dummy_call): Update.
3233
3234 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3235             Tom Tromey  <tom@tromey.com>
3236
3237         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3238         (ppc_threads): Now a std::vector.  Now static.
3239         (hwdebug_find_thread_points_by_tid)
3240         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3241         Update.
3242
3243 2019-05-04  Tom Tromey  <tom@tromey.com>
3244
3245         * arc-tdep.c (arc_tdesc_init): Return bool.
3246
3247 2019-05-04  Tom Tromey  <tom@tromey.com>
3248
3249         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3250         Use gdb_assert_not_reached.
3251
3252 2019-05-04  Tom Tromey  <tom@tromey.com>
3253
3254         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3255         "false".
3256
3257 2019-05-04  Tom Tromey  <tom@tromey.com>
3258
3259         * arc-tdep.c (arc_tdesc_init): Use bool.
3260
3261 2019-05-04  Tom Tromey  <tom@tromey.com>
3262
3263         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3264
3265 2019-05-04  Tom Tromey  <tom@tromey.com>
3266
3267         * cli/cli-cmds.c (valid_command_p): Return bool.
3268
3269 2019-05-04  Tom Tromey  <tom@tromey.com>
3270
3271         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3272         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3273
3274 2019-05-04  Raul Tambre  <raul@tambre.ee>
3275
3276         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3277         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3278         operator for comparison.
3279
3280 2019-05-04  Tom Tromey  <tom@tromey.com>
3281
3282         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3283         (lookup_partial_symbol, print_partial_symbols)
3284         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3285         (psymbol_compare): Update.
3286         (add_psymbol_to_bcache): Clear the entire psymbol.
3287         (maintenance_check_psymtabs): Update.
3288         * psympriv.h (struct partial_symbol): Don't derive from
3289         general_symbol_info.
3290         <obj_section, unrelocated_address, address,
3291         set_unrelocated_address>: Update.
3292         <ginfo>: New member.
3293         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3294         (debug_names::write_psymbols): Update.
3295
3296 2019-05-04  Tom de Vries  <tdevries@suse.de>
3297
3298         * contrib/cc-with-tweaks.sh: Support -n arg.
3299
3300 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3301
3302         * corelow.c (core_target::detach): Ensure frame cache and
3303         register caches are cleared.
3304         inferior.c (exit_inferior_1): Likewise.
3305
3306 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3307             Tom Tromey  <tom@tromey.com>
3308
3309         * dictionary.c (collate_pending_symbols_by_language): Remove
3310         "struct" from foreach.
3311         * symtab.c (lookup_global_symbol_from_objfile)
3312         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3313         foreach.
3314         * ser-tcp.c (net_open): Remove "struct" from foreach.
3315         * objfiles.c (objfile_relocate, objfile_rebase)
3316         (objfile_has_symbols): Remove "struct" from foreach.
3317         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3318         from foreach.
3319         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3320         foreach.
3321         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3322         "struct" from foreach.
3323         * ada-lang.c (create_excep_cond_exprs)
3324         (ada_exception_catchpoint_cond_string): Remove "struct" from
3325         foreach.
3326
3327 2019-05-03  Tom Tromey  <tromey@adacore.com>
3328
3329         * ada-exp.y (convert_char_literal): Check suffix of each
3330         enumerator.
3331
3332 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3333
3334         PR ada/21406:
3335         * ada-exp.y (yywrap): Don't define.
3336         * ada-lex.l (%option): Add noyywrap
3337         (yywrap): Remove.
3338
3339 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3340
3341         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3342         _WIN32_WINNT to the XP level, unless already defined to a higher
3343         level.
3344
3345         * unittests/parse-connection-spec-selftests.c:
3346         * ser-tcp.c:
3347         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3348         override.
3349
3350         * symfile.c (find_separate_debug_file): Remove colon from the
3351         drive spec of DOS/Windows file names of the target, so that the
3352         file name produced from DEBUGDIR and the target's directory will
3353         be valid on DOS/Windows systems.
3354
3355 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3356
3357         * rust-lang.c (val_print_struct): Handle printing structures
3358         containing strings.
3359
3360 2019-05-02  Tom Tromey  <tromey@adacore.com>
3361
3362         * valarith.c (_initialize_valarith): Remove.
3363
3364 2019-05-01  Tom Tromey  <tromey@adacore.com>
3365
3366         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3367         bitfields.
3368
3369 2019-05-01  Tom Tromey  <tromey@adacore.com>
3370
3371         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3372         for big-endian copies.
3373
3374 2019-04-30  Ali Tamur  <tamur@google.com>
3375         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3376         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3377         (read_3_bytes): New function.
3378
3379 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3380
3381         * windows-nat.c (main_thread_id): Delete.
3382         (handle_output_debug_string): Replace main_thread_id by
3383         current_event.dwThreadId.
3384         (fake_create_process): Likewise.
3385         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3386         Do not set main_thread_id.
3387         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3388         current_event.dwThreadId.
3389         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3390
3391 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3392
3393         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3394         Use current_event.dwThreadId instead of main_thread_id.
3395
3396 2019-04-30  Tom Tromey  <tromey@adacore.com>
3397
3398         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3399         (create_excep_cond_exprs): Iterate over program spaces.
3400         (ada_exception_catchpoint_cond_string): Examine all minimal
3401         symbols for exception types.
3402
3403 2019-04-30  Tom Tromey  <tromey@adacore.com>
3404
3405         PR c++/24470:
3406         * dwarf2read.c (process_structure_scope): Handle case where type
3407         has template parameters but no symbol was created.
3408
3409 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3410             Chris January  <chris.january@arm.com>
3411
3412         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3413         qualifier.
3414         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3415
3416 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3417
3418         * f-typeprint.c (f_print_type): Update rules for printing
3419         whitespace.
3420         (f_type_print_varspec_suffix): Likewise.
3421
3422 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3423             Chris January  <chris.january@arm.com>
3424
3425         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3426         function arguments.
3427
3428 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3429
3430         * f-lang.c (build_fortran_types): Change name of void type to
3431         lower case.
3432         * f-typeprint.c (f_type_print_base): Print the name of the void
3433         type, rather than a fixed string.
3434         * f-valprint.c (f_decorations): Use lower case void string.
3435
3436 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3437             Chris January  <chris.january@arm.com>
3438
3439         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3440         types for Fortran.
3441
3442 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3443             Chris January  <chris.january@arm.com>
3444             David Lecomber  <david.lecomber@arm.com>
3445
3446         * f-exp.y (BINOP_INTRINSIC): New token.
3447         (exp): New parser rule handling BINOP_INTRINSIC.
3448         (f77_keywords): Add new builtin procedures.
3449         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3450         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3451         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3452         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3453         (print_unop_subexp_f): New function.
3454         (print_binop_subexp_f): New function.
3455         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3456         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3457         (dump_subexp_body_f): Likewise.
3458         (operator_check_f): Likewise.
3459         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3460         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3461
3462 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3463
3464         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3465         UNOP_KIND.
3466         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3467         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3468         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3469         (operator_length_f): New fuction.
3470         (print_subexp_f): New function.
3471         (op_name_f): New function.
3472         (dump_subexp_body_f): New function.
3473         (operator_check_f): New function.
3474         (exp_descriptor_f): Replace standard expression handling functions
3475         with new functions.
3476         * gdb/fortran-operator.def: New file.
3477         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3478         * gdb/std-operator.def: Remove UNOP_KIND.
3479
3480 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3481
3482         * std-operator.def: Remove unbalanced, stray double quote
3483         character.
3484
3485 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3486             Chris January  <chris.january@arm.com>
3487             Daniel Everett  <daniel.everett@arm.com>
3488             Nick Forrington  <nick.forrington@arm.com>
3489             Richard Bunt  <richard.bunt@arm.com>
3490
3491         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3492         of depth when printing anonymous structs or unions.
3493         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3494         Don't print either the top-level value, or the children if the
3495         max-depth is exceeded.
3496         (ppscm_print_children): When printing the key of a map, allow one
3497         extra level of depth.
3498         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3499         print either the top-level value, or the children if the max-depth
3500         is exceeded.
3501         (print_children): When printing the key of a map, allow one extra
3502         level of depth.
3503         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3504         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3505         (user_print_options): Initialise max_depth field.
3506         (val_print_scalar_or_string_type_p): New function.
3507         (val_print): Check to see if the max depth has been reached.
3508         (val_print_check_max_depth): Define new function.
3509         (show_print_max_depth): New function.
3510         (_initialize_valprint): Add 'print max-depth' option.
3511         * valprint.h (struct value_print_options) <max_depth>: New field.
3512         (val_print_check_max_depth): Declare new function.
3513         * NEWS: Document new feature.
3514
3515 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3516
3517         * ada-lang.c (ada_language_defn): Initialise new field.
3518         * c-lang.c (c_is_string_type_p): New function.
3519         (c_language_defn): Initialise new field.
3520         (cplus_language_defn): Initialise new field.
3521         (asm_language_defn): Initialise new field.
3522         (minimal_language_defn): Initialise new field.
3523         * c-lang.h (c_is_string_type_p): Declare new function.
3524         * d-lang.c (d_language_defn): Initialise new field.
3525         * f-lang.c (f_is_string_type_p): New function.
3526         (f_language_defn): Initialise new field.
3527         * go-lang.c (go_is_string_type_p): New function.
3528         (go_language_defn): Initialise new field.
3529         * language.c (default_is_string_type_p): New function.
3530         (unknown_language_defn): Initialise new field.
3531         (auto_language_defn): Initialise new field.
3532         * language.h (struct language_defn) <la_is_string_type_p>: New
3533         member variable.
3534         (default_is_string_type_p): Declare new function.
3535         * m2-lang.c (m2_language_defn): Initialise new field.
3536         * objc-lang.c (objc_language_defn): Initialise new field.
3537         * opencl-lang.c (opencl_language_defn): Initialise new field.
3538         * p-lang.c (pascal_is_string_type_p): New function.
3539         (pascal_language_defn): Initialise new field.
3540         * rust-lang.c (rust_is_string_type_p): New function.
3541         (rust_language_defn): Initialise new field.
3542
3543 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3544
3545         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3546         New field.
3547         * ada-lang.c (ada_language_defn): Initialise new field.
3548         * c-lang.c (c_language_defn): Likewise.
3549         (cplus_language_defn): Likewise.
3550         (asm_language_defn): Likewise.
3551         (minimal_language_defn): Likewise.
3552         * d-lang.c (d_language_defn): Likewise.
3553         * f-lang.c (f_language_defn): Likewise.
3554         * go-lang.c (go_language_defn): Likewise.
3555         * language.c (unknown_language_defn): Likewise.
3556         (auto_language_defn): Likewise.
3557         * m2-lang.c (m2_language_defn): Likewise.
3558         * objc-lang.c (objc_language_defn): Likewise.
3559         * opencl-lang.c (opencl_language_defn): Likewise.
3560         * p-lang.c (pascal_language_defn): Likewise.
3561         * rust-lang.c (rust_language_defn): Likewise.
3562
3563 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3564
3565         * ada-lang.c (ada_is_character_type): Change return type to bool.
3566         (ada_is_string_type): Likewise.
3567         * ada-lang.h (ada_is_character_type): Update declaration
3568         (ada_is_string_type): Likewise.
3569
3570 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3571
3572         Support style in 'frame|thread apply'
3573
3574         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3575         * record.c (record_start, record_stop): Update callers of
3576         execute_command_to_string with false.
3577         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3578         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3579         methods.
3580         (class string_file): New constructor with term_out parameter.
3581         Override methods term_out and can_emit_style_escape.  New member
3582         term_out.
3583         (class stdio_file): Override can_emit_style_escape.
3584         (class tee_file): Override term_out and can_emit_style_escape.
3585         * utils.h (can_emit_style_escape): Remove.
3586         * utils.c (can_emit_style_escape): Likewise.
3587         Update all callers of can_emit_style_escape (SOMESTREAM) to
3588         SOMESTREAM->can_emit_style_escape.
3589         * source-cache.c (source_cache::get_source_lines): Likewise.
3590         * stack.c (frame_apply_command_count): Call execute_command_to_string
3591         passing the term_out characteristic of the current gdb_stdout.
3592         * thread.c (thr_try_catch_cmd): Likewise.
3593         * top.c (execute_command_to_string): pass term_out parameter
3594         to construct the string_file for the command output.
3595         * ui-file.c (term_cli_styling): New function (most code moved
3596         from utils.c can_emit_style_escape).
3597         (string_file::string_file, string_file::can_emit_style_escape,
3598         stdio_file::can_emit_style_escape, tee_file::term_out,
3599         tee_file::can_emit_style_escape): New functions.
3600
3601 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3602
3603         * NEWS: Mention the new set|show may-call-functions.
3604         * infcall.c (may_call_functions_p): New variable.
3605         (show_may_call_functions_p): New function.
3606         (call_function_by_hand_dummy): Throws an error if not
3607         may-call-functions.
3608         (_initialize_infcall): Call add_setshow_boolean_cmd for
3609         may-call-functions.
3610
3611 2019-04-25  Keith Seitz  <keiths@redhat.com>
3612
3613         PR c++/24367
3614         * cp-support.c (inspect_type): Don't attempt substitutions
3615         of symbol with the same name.
3616
3617 2019-04-25  Tom Tromey  <tromey@adacore.com>
3618
3619         PR gdb/24475:
3620         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3621         static.
3622
3623 2019-04-25  Tom Tromey  <tromey@adacore.com>
3624
3625         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3626         rvalue reference.
3627         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3628         (gdb_xml_parser::parse): Use std::move.
3629         * python/python-internal.h (gdbpy_convert_exception): Take a const
3630         reference.
3631         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3632         std::move.
3633         * python/py-utils.c (gdbpy_convert_exception): Take a const
3634         reference.
3635         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3636         Use std::move.
3637         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3638         Use std::move.
3639         * mi/mi-main.c (mi_print_exception): Take a const reference.
3640         * main.c (handle_command_errors): Take a const reference.
3641         * linespec.c (parse_linespec): Use std::move.
3642         * infcall.c (run_inferior_call): Use std::move.
3643         (call_function_by_hand_dummy): Use std::move.
3644         * exec.c (try_open_exec_file): Use std::move.
3645         * exceptions.h (exception_print, exception_fprintf)
3646         (exception_print_same): Update.
3647         * exceptions.c (print_exception, exception_print)
3648         (exception_fprintf, exception_print_same): Change parameters to
3649         const reference.
3650         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3651         * common/new-op.c: Use std::move.
3652         * common/common-exceptions.h (struct gdb_exception): Add move
3653         constructor.
3654         (struct gdb_exception_error, struct gdb_exception_quit, struct
3655         gdb_quit_bad_alloc): Change constructor to move constructor.
3656         (throw_exception): Change parameter to rvalue reference.
3657         * common/common-exceptions.c (throw_exception): Take rvalue
3658         reference.
3659         * cli/cli-interp.c (safe_execute_command): Use std::move.
3660         * breakpoint.c (insert_bp_location, location_to_sals): Use
3661         std::move.
3662
3663 2019-04-25  Tom Tromey  <tromey@adacore.com>
3664
3665         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3666         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3667         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3668         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3669         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3670         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3671         guile/scm-value.c: Use unpack.
3672         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3673         gdbscm_gdb_exception.
3674         (gdbscm_throw_gdb_exception): Likewise.
3675         (struct gdbscm_gdb_exception): New.
3676         (unpack): New function.
3677         (gdbscm_wrap): Use unpack.
3678
3679 2019-04-25  Tom Tromey  <tromey@adacore.com>
3680
3681         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3682         (gdb_rl_callback_handler): Use std::move.
3683         * common/common-exceptions.h (struct gdb_exception): Add move
3684         assignment operator.
3685         (throw_exception_sjlj): Change "exception" to const reference.
3686         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3687         (throw_exception_sjlj): Change "exception" to const reference.
3688
3689 2019-04-25  Tom Tromey  <tromey@adacore.com>
3690
3691         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3692         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3693         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3694         Update.
3695         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3696         Update.
3697         * mi/mi-interp.c (mi_interp::exec): Update.
3698         * linespec.c (parse_linespec): Update.
3699         * infcall.c (run_inferior_call): Update.
3700         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3701         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3702         (gdbscm_lookup_global_symbol): Update.
3703         * guile/scm-param.c (gdbscm_parameter_value): Update.
3704         * guile/scm-frame.c (gdbscm_frame_read_register)
3705         (gdbscm_frame_read_var): Update.
3706         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3707         * exec.c (try_open_exec_file): Update.
3708         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3709         (gdb_rl_callback_handler): Update.
3710         * common/common-exceptions.h (exception_none): Don't declare.
3711         * common/common-exceptions.c (exception_none): Don't define.
3712         (struct catcher) <exception>: Update.
3713         * cli/cli-interp.c (safe_execute_command): Update.
3714         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3715
3716 2019-04-25  Ali Tamur  <tamur@google.com>
3717
3718         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3719         (read_attribute_value): Likewise.
3720         (dwarf2_read_addr_index): Update comment.
3721         (read_str_index): Add DW_FORM_strx.
3722         (dwarf2_string_attr): Likewise.
3723         (dwarf2_const_value_attr): Likewise.
3724         (dump_die_shallow): Likewise.
3725         (dwarf2_fetch_constant_bytes): Likewise.
3726         (skip_form_bytes): Likewise.
3727         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3728
3729 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3730
3731         PR corefiles/11608
3732         PR corefiles/18187
3733         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3734         OFFSET.  Verify if current mapping contains an ELF header.
3735         (linux_find_memory_regions_full): Adjust call to
3736         dump_mapping_p.
3737
3738 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3739             Kang Li <kanglictf@gmail.com>
3740
3741         PR gdb/21600
3742
3743         * dwarf2-frame.c (read_initial_length): Be consistent about using
3744         unsigned representation of length.
3745         (decode_frame_entry_1): Likewise.  Check for wraparound of
3746         end pointer as well as buffer overflow.
3747
3748 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3749
3750         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3751         "vq".
3752
3753 2019-04-24  Tom Tromey  <tromey@adacore.com>
3754
3755         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3756
3757 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3758
3759         * s12z-tdep.c (s12z_unwind_pc): Delete.
3760         (s12z_unwind_sp): Delete.
3761         (s12z_gdbarch_init): Don't register deleted functions with
3762         gdbarch.
3763
3764 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3765
3766         * rl78-tdep.c (rl78_unwind_sp): Delete.
3767         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3768
3769 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3770
3771         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3772         (xstormy16_unwind_pc): Delete.
3773         (xstormy16_dummy_id): Delete.
3774         (xstormy16_gdbarch_init): Don't register deleted functions with
3775         gdbarch.
3776
3777 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3778
3779         * vax-tdep.c (vax_unwind_pc): Delete.
3780         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3781
3782 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3783
3784         * v850-tdep.c (v850_unwind_sp): Delete.
3785         (v850_unwind_pc): Delete.
3786         (v850_dummy_id): Delete.
3787         (v850_gdbarch_init): Don't register deleted functions with
3788         gdbarch.
3789
3790 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3791
3792         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3793         (tilegx_unwind_pc): Delete.
3794         (tilegx_unwind_dummy_id): Delete.
3795         (tilegx_gdbarch_init): Don't register deleted functions with
3796         gdbarch.
3797
3798 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3799
3800         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3801         (tic6x_dummy_id): Delete.
3802         (tic6x_gdbarch_init): Don't register deleted functions with
3803         gdbarch.
3804
3805 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3806
3807         * sparc-tdep.c (sparc_unwind_pc): Delete.
3808         (sparc32_gdbarch_init): Don't register deleted function with
3809         gdbarch.
3810
3811 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3812
3813         * sh-tdep.c (sh_unwind_sp): Delete.
3814         (sh_unwind_pc): Delete.
3815         (sh_dummy_id): Delete.
3816         (sh_gdbarch_init): Don't register deleted functions with
3817         gdbarch.
3818
3819 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3820
3821         * score-tdep.c (score_unwind_sp): Delete.
3822         (score_unwind_pc): Delete.
3823         (score_dummy_id): Delete.
3824         (score_gdbarch_init): Don't register deleted functions with
3825         gdbarch.
3826
3827 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3828
3829         * rx-tdep.c (rx_unwind_pc): Delete.
3830         (rx_unwind_sp): Delete.
3831         (rx_dummy_id): Delete.
3832         (rx_gdbarch_init): Don't register deleted functions with
3833         gdbarch.  Update comment.
3834
3835 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3836
3837         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3838         (rs6000_dummy_id): Delete.
3839         (rs6000_gdbarch_init): Don't register deleted functions with
3840         gdbarch.
3841
3842 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3843
3844         * or1k-tdep.c (or1k_dummy_id): Delete.
3845         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3846
3847 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3848
3849         * nios2-tdep.c (nios2_dummy_id): Delete.
3850         (nios2_unwind_sp): Delete.
3851         (nios2_gdbarch_init): Don't register deleted functions with
3852         gdbarch.
3853
3854 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3855
3856         * nds32-tdep.c (nds32_dummy_id): Delete.
3857         (nds32_unwind_pc): Delete.
3858         (nds32_unwind_sp): Delete.
3859         (nds32_gdbarch_init): Don't register deleted functions with
3860         gdbarch.
3861
3862 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3863
3864         * msp430-tdep.c (msp430_unwind_pc): Delete.
3865         (msp430_unwind_sp): Delete.
3866         (msp430_dummy_id): Delete.
3867         (msp430_gdbarch_init): Don't register deleted functions with
3868         gdbarch.
3869
3870 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3871
3872         * moxie-tdep.c (moxie_unwind_sp): Delete.
3873         (moxie_unwind_pc): Delete.
3874         (moxie_dummy_id): Delete.
3875         (moxie_gdbarch_init): Don't register deleted functions with
3876         gdbarch.
3877
3878 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3879
3880         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3881         (mn10300_unwind_pc): Delete.
3882         (mn10300_unwind_sp): Delete.
3883         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3884         mn10300_unwind_sp.
3885         (mn10300_frame_unwind_init): Don't register deleted functions with
3886         gdbarch.
3887
3888 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3889
3890         * mep-tdep.c (mep_unwind_pc): Delete.
3891         (mep_unwind_sp): Delete.
3892         (mep_dummy_id): Delete.
3893         (mep_gdbarch_init): Don't register deleted functions with
3894         gdbarch.
3895
3896 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3897
3898         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3899         (m68hc11_unwind_sp): Delete.
3900         (m68hc11_gdbarch_init): Don't register deleted functions with
3901         gdbarch.
3902
3903 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3904
3905         * m32r-tdep.c (m32r_unwind_sp): Delete.
3906         (m32r_unwind_pc): Delete.
3907         (m32r_dummy_id): Delete.
3908         (m32r_gdbarch_init): Don't register deleted functions with
3909         gdbarch.
3910
3911 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3912
3913         * m32c-tdep.c (m32c_unwind_pc): Delete.
3914         (m32c_unwind_sp): Delete.
3915         (m32c_dummy_id): Delete.
3916         (m32c_gdbarch_init): Don't register deleted functions with
3917         gdbarch.
3918
3919 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3920
3921         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3922         (lm32_unwind_pc): Delete.
3923         (lm32_dummy_id): Delete.
3924         (lm32_gdbarch_init): Don't register deleted functions with
3925         gdbarch.
3926
3927 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3928
3929         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3930         (iq2000_unwind_pc): Delete.
3931         (iq2000_dummy_id): Delete.
3932         (iq2000_gdbarch_init): Don't register deleted functions with
3933         gdbarch.
3934
3935 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3936
3937         * nds32-tdep.c (nds32_type_align): Delete.
3938         (nds32_push_dummy_call): Use type_align instead.
3939
3940 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3941
3942         * arm-tdep.c (arm_type_align): Only handle vector override case.
3943         (arm_push_dummy_call): Use type_align.
3944         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3945
3946 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3947
3948         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3949         case.
3950         (pass_on_stack): Use type_align.
3951         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3952         function.
3953
3954 2019-04-23  Tom Tromey  <tromey@adacore.com>
3955
3956         * dwarf2read.c (line_header::file_name_at): Remove unused
3957         overload.
3958
3959 2019-04-23  Tom de Vries  <tdevries@suse.de>
3960
3961         PR gdb/24438
3962         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3963         invocation.
3964
3965
3966 2019-03-27  Ali Tamur  <tamur@google.com>
3967
3968         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3969         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3970         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3971         (dwarf_expr_context::get_addr_index): Likewise
3972         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3973         (symbol_needs_eval_context::get_addr_index): Likewise
3974         (disassemble_dwarf_expression): Add DW_OP_addrx
3975         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3976         (read_cutu_die_from_dwo): Update comment
3977         (skip_one_die): Add DW_FORM_addrx
3978         (read_attribute_value): Likewise
3979         (var_decode_location): Add DW_OP_addrx
3980         (dwarf2_const_value_attr): Add DW_FORM_addrx
3981         (dump_die_shallow): Likewise
3982         (dwarf2_fetch_constant_bytes): Likewise
3983         (decode_locdesc): Add DW_OP_addrx
3984         (skip_form_bytes): Add DW_FORM_addrx
3985
3986 2019-04-22  Ali Tamur  <tamur@google.com>
3987
3988         * MAINTAINERS (Write After Approval): Add self.
3989
3990 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3991
3992         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3993         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3994         (open_symbol_file_object): Likewise.
3995         (svr4_default_sos): Add info parameter.
3996         (svr4_read_so_list): Likewise.
3997         (svr4_current_sos_direct): Adjust functions calls to pass down
3998         info.
3999         (svr4_current_sos_1): Add info parameter.
4000         (svr4_current_sos): Call get_svr4_info, pass info down to
4001         svr4_current_sos_1.
4002         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4003         get_svr4_info.
4004         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4005         get_svr4_info.
4006         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4007         to get_svr4_info.
4008         (probes_table_remove_objfile_probes): Likewise.
4009         (register_solib_event_probe): Add info parameter.
4010         (solist_update_incremental): Pass info parameter down to
4011         svr4_read_so_list.
4012         (disable_probes_interface): Add info parameter.
4013         (svr4_handle_solib_event): Pass current_program_space to
4014         get_svr4_info.  Adjust disable_probes_interface cleanup.
4015         (svr4_create_probe_breakpoints): Add info parameter, pass it
4016         down to register_solib_event_probe.
4017         (svr4_create_solib_event_breakpoints): Add info parameter,
4018         pass it down to svr4_create_probe_breakpoints.
4019         (enable_break): Pass info down to
4020         svr4_create_solib_event_breakpoints.
4021         (svr4_solib_create_inferior_hook): Pass current_program_space to
4022         get_svr4_info.
4023         (svr4_clear_solib): Likewise.
4024
4025 2019-04-22  Pedro Alves  <palves@redhat.com>
4026
4027         * solib-svr4.c (svr4_free_objfile_observer): New.
4028         (probe_and_action::objfile): New field.
4029         (probes_table_htab_remove_objfile_probes)
4030         (probes_table_remove_objfile_probes): New functions.
4031         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4032         in the new probe_and_action.  Don't store the probe in 'lookup'.
4033         (svr4_create_probe_breakpoints): Pass objfile to
4034         register_solib_event_probe.
4035         (_initialize_svr4_solib): Register a free_objfile observer.
4036
4037 2019-04-19  Tom Tromey  <tom@tromey.com>
4038
4039         * common/queue.h: Remove.
4040
4041 2019-04-19  Tom Tromey  <tom@tromey.com>
4042
4043         * event-loop.c: Don't include "common/queue.h".
4044
4045 2019-04-19  Tom Tromey  <tom@tromey.com>
4046
4047         * remote.c (remote_target): Use delete.
4048         * remote-notif.h: Include <list>, not "common/queue.h".
4049         (notif_client_p): Remove typedef.
4050         (remote_notif_state): Add constructor, destructor, initializer.
4051         <notif_queue>: Now a std::list.
4052         (remote_notif_state_xfree): Don't declare.
4053         * remote-notif.c (remote_notif_process, handle_notification)
4054         (remote_notif_state_allocate): Update.
4055         (~remote_notif_state): Rename from remote_notif_state_xfree.
4056
4057 2019-04-19  Tom Tromey  <tom@tromey.com>
4058
4059         * symfile.c (reread_symbols): Update.
4060         * objfiles.c (objfile_register_static_link)
4061         (objfile_lookup_static_link): Update
4062         (~objfile) Don't delete static_links.
4063         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4064
4065 2019-04-19  Tom Tromey  <tom@tromey.com>
4066
4067         * type-stack.h (struct type_stack) <insert>: Constify string.
4068         * type-stack.c (type_stack::insert): Constify string.
4069         * gdbtypes.h (lookup_template_type): Update.
4070         (address_space_name_to_int): Update.
4071         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4072         const.
4073         (lookup_template_type): Make name const.
4074         * c-exp.y: Update rules.
4075         (lex_one_token, classify_name, classify_inner_name)
4076         (c_print_token): Update.
4077         * p-exp.y: Update rules.
4078         (yylex): Update.
4079         * f-exp.y: Update rules.
4080         (yylex): Update.
4081         * d-exp.y: Update rules.
4082         (lex_one_token, classify_name, classify_inner_name): Update.
4083         * parse.c (write_dollar_variable, copy_name): Return std::string.
4084         * parser-defs.h (copy_name): Change return type.
4085         * m2-exp.y: Update rules.
4086         (yylex): Update.
4087         * go-exp.y (lex_one_token): Update.
4088         Update rules.
4089         (classify_unsafe_function, classify_packaged_name)
4090         (classify_name, yylex): Update.
4091
4092 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4093
4094         * configure.ac: add --enable-source-highlight switch.
4095         * configure: Regenerate.
4096         * top.c (print_gdb_version): plumb --enable-source-highlight
4097         status to "show configuration".
4098
4099 2019-04-19  Tom Tromey  <tromey@adacore.com>
4100
4101         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4102         Check ADA_TYPE_P.
4103         (empty_record, ada_template_to_fixed_record_type_1)
4104         (template_to_static_fixed_type)
4105         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4106         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4107         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4108         macros.
4109
4110 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4111
4112         PR symtab/24423:
4113         * source.c (print_source_lines_base): Advance "iter" when a
4114         control character is seen.
4115
4116 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4117
4118         * inferior.h (struct infcall_suspend_state_deleter):
4119         Catch exception in destructor to avoid crash.
4120
4121 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4122
4123         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4124         close to the add_com "shell".
4125
4126 2019-04-18  Tom Tromey  <tromey@adacore.com>
4127
4128         * process-stratum-target.h (class process_stratum_target)
4129         <stratum>: Add "final".
4130
4131 2019-04-17  Tom Tromey  <tromey@adacore.com>
4132
4133         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4134         against nullptr before use.
4135
4136 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4137
4138         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4139
4140 2019-04-17  Jim Wilson  <jimw@sifive.com>
4141             Andrew Burgess  <andrew.burgess@embecosm.com>
4142
4143         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4144         code read might fail, assume 4-byte breakpoint in that case.
4145
4146 2019-04-15  Leszek Swirski  <leszeks@google.com>
4147
4148         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4149         rather than a hand-rolled POD check when checking for forced MEMORY
4150         classification.
4151
4152 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4153
4154         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4155         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4156         function.
4157         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4158         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4159         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4160         declaration.
4161
4162 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4163
4164         * aarch64-linux-nat.c
4165         (aarch64_linux_nat_target::thread_architecture): Add override.
4166         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4167         each VQ.
4168
4169 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4170
4171         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4172
4173 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4174
4175         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4176         target types of size 96-bits, add some additional comments, and
4177         check that the builtin type we found was the correct size.
4178
4179 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4180
4181         * utils.c (prompt_for_continue): Don't restore the styling at the
4182         end, as applied_style has the wrong value.  This fixes styling in
4183         long lists of file names that are interrupted by the "Continue?"
4184         prompt.
4185
4186 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4187
4188         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4189         * c-lang.c (c_language_defn): Likewise.
4190         (cplus_language_defn): Likewise.
4191         (asm_language_defn): Likewise.
4192         (minimal_language_defn): Likewise.
4193         * d-lang.c (d_language_defn): Likewise.
4194         * f-lang.c (f_language_defn): Likewise.
4195         * go-lang.c (go_language_defn): Likewise.
4196         * language.c (unknown_language_defn): Likewise.
4197         (auto_language_defn): Likewise.
4198         * language.h (struct language_defn): Remove la_magic field.
4199         (LANG_MAGIC): Delete.
4200         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4201         * objc-lang.c (objc_language_defn): Likewise.
4202         * opencl-lang.c (opencl_language_defn): Likewise.
4203         * p-lang.c (pascal_language_defn): Likewise.
4204         * rust-lang.c (rust_language_defn): Likewise.
4205
4206 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4207
4208         * riscv-tdep.c (riscv_type_align): New function.
4209         (riscv_type_alignment): Delete.
4210         (riscv_arg_location): Use 'type_align'.
4211         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4212
4213 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4214
4215         * gdbtypes.c (type_align): A struct with no non-static fields also
4216         has alignment of 1.
4217
4218 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4219
4220         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4221         component to 0.
4222         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4223         member.
4224         (riscv_struct_info::analyse): New implementation using new
4225         analyse_inner member function.
4226         (riscv_struct_info::field_offset): New member function.
4227         (riscv_struct_info::m_offsets): New member variable.
4228         (riscv_struct_info::analyse_inner): New private member function,
4229         takes the old implementation of riscv_struct_info::analyse but
4230         extended to track field offsets.
4231         (riscv_call_arg_struct): Update the struct folding special cases
4232         to handle cases where empty C++ structs, which are non-zero
4233         length, are found.
4234         (riscv_arg_location): Initialise the length of each location, a
4235         non-zero length now indicates the location is in use.
4236         (riscv_push_dummy_call): Allow for the first location having a
4237         non-zero offset when setting up arguments.
4238         (riscv_return_value): Likewise, but for return values.
4239
4240 2019-04-11  Tom Tromey  <tromey@adacore.com>
4241
4242         * utils.c (internal_vproblem): Make "msg" const.
4243
4244 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4245
4246         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4247         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4248         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4249         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4250
4251 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4252
4253         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4254         function.
4255         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4256         of amd64_collect_native_gregset.
4257         (amd64_linux_nat_target::store_registers): Likewise.
4258
4259 2019-04-10  Tom Tromey  <tom@tromey.com>
4260
4261         * symtab.c (lookup_global_symbol_from_objfile)
4262         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4263         * objfiles.h (class separate_debug_iterator): New.
4264         (class separate_debug_range): New.
4265         (struct objfile) <separate_debug_objfiles>: New method.
4266         (objfile_separate_debug_iterate): Don't declare.
4267         * objfiles.c (separate_debug_iterator::operator++): Rename from
4268         objfile_separate_debug_iterate.
4269         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4270         iterator.
4271         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4272         iterator.
4273
4274 2019-04-10  Tom Tromey  <tom@tromey.com>
4275
4276         * symfile.c (reread_symbols): Remove old comment.
4277         * objfiles.c (free_all_objfiles): Fix a typo.
4278
4279 2019-04-10  Tom Tromey  <tom@tromey.com>
4280
4281         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4282         * minsyms.c (lookup_minimal_symbol): Use foreach.
4283         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4284         (lookup_minimal_symbol_solib_trampoline): Likewise.
4285         * symfile.c (reread_symbols): Use foreach.
4286
4287 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4288             Tom Tromey  <tromey@adacore.com>
4289
4290         PR rust/24414:
4291         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4292         (rust_lex_int_test): Change "value" to be LONGEST.
4293         (rust_lex_tests): Add test for long integer literal.
4294
4295 2019-04-09  Tom Tromey  <tromey@adacore.com>
4296
4297         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4298         to bool.
4299         (extended_remote_target::attach): Update.
4300         (remote_target::remote_notice_new_inferior): Update.
4301         (remote_target::add_current_inferior_and_thread): Update.
4302         * inferior.c (exit_inferior_1): Use "false".
4303         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4304
4305 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4306
4307         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4308         the "start" command.
4309
4310 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4311
4312         * python/py-inferior.c (infpy_thread_from_thread_handle):
4313         Adjust comments to reflect renaming of thread_from_thread_handle
4314         to thread_from_handle.  Adjust keywords.  Fix type error message.
4315         (inferior_object_methods): Add thread_from_handle.  Retain
4316         thread_from_thread_handle, but mark it as deprecated.
4317
4318 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4319
4320         * gdbthread.h (find_thread_by_handle): Revise declaration.
4321         * thread.c (find_thread_by_handle): Likewise.  Adjust
4322         implementation too.
4323         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4324         support for buffer objects as handles.
4325
4326 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4327
4328         * python/py-infthread.c (thpy_thread_handle): New function.
4329         (thread_object_methods): Register thpy_thread_handle.
4330
4331 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4332
4333         * gdbthread.h (thread_to_thread_handle): Declare.
4334         * thread.c (gdbtypes.h): Include.
4335         (thread_to_thread_handle): New function.
4336
4337         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4338         (target_thread_info_to_thread_handle): Declare.
4339         * target.c (target_thread_info_to_thread_handle): New function.
4340         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4341         * target-delegates.c: Regenerate.
4342
4343         * linux-thread-db.c (class thread_db_target): Add method
4344         thread_info_to_thread_handle.
4345         (thread_db_target::thread_info_to_thread_handle): Define.
4346         * remote.c (class remote_target): Add new method
4347         thread_info_to_thread_handle.
4348         (remote_target::thread_info_to_thread_handle): Define.
4349
4350 2019-04-08  Pedro Alves  <palves@redhat.com>
4351
4352         * common/common-exceptions.c (throw_exception): Don't create
4353         named object to throw; throw directly.
4354         (throw_it): Likewise.  Don't initialize gdb_exception::message
4355         here, with new; pass FMT and AP to the ctor instead.
4356         * common/common-exceptions.h: Include <string>.
4357         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4358         const char *, va_list)): New ctor.  Use std::make_shared.
4359         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4360         errors)): Delete.
4361         (gdb_exception_error::gdb_exception_error(enum errors, const char
4362         *, va_list)): New.
4363         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4364         Add assertion.
4365         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4366         errors)): Delete.
4367         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4368         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4369         Add assertion.
4370
4371 2019-04-08  Tom Tromey  <tom@tromey.com>
4372
4373         * valops.c (value_rtti_indirect_type): Replace throw_exception
4374         with throw.
4375         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4376         with throw.
4377         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4378         throw.
4379         * target.c (target_translate_tls_address): Replace throw_exception
4380         with throw.
4381         * stack.c (frame_apply_command_count): Replace throw_exception
4382         with throw.
4383         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4384         throw.
4385         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4386         with throw.
4387         * rs6000-tdep.c (rs6000_frame_cache)
4388         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4389         * remote.c: Replace throw_exception with throw.
4390         * record-full.c (record_full_message, record_full_wait_1)
4391         (record_full_restore): Replace throw_exception with throw.
4392         * record-btrace.c:
4393         (get_thread_current_frame_id, record_btrace_start_replaying)
4394         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4395         (cmd_record_btrace_start): Replace throw_exception with throw.
4396         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4397         throw.
4398         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4399         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4400         * linespec.c:
4401         (find_linespec_symbols): Replace throw_exception with throw.
4402         * infrun.c (displaced_step_prepare, resume): Replace
4403         throw_exception with throw.
4404         * infcmd.c (post_create_inferior): Replace throw_exception with
4405         throw.
4406         * inf-loop.c (inferior_event_handler): Replace throw_exception
4407         with throw.
4408         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4409         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4410         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4411         (get_prev_frame_always, get_frame_pc_if_available)
4412         (get_frame_address_in_block_if_available, get_frame_language):
4413         Replace throw_exception with throw.
4414         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4415         throw_exception with throw.
4416         * eval.c (fetch_subexp_value, evaluate_var_value)
4417         (evaluate_funcall, evaluate_subexp_standard): Replace
4418         throw_exception with throw.
4419         * dwarf2loc.c (call_site_find_chain)
4420         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4421         Replace throw_exception with throw.
4422         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4423         with throw.
4424         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4425         throw.
4426         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4427         * completer.c (complete_line_internal): Replace throw_exception
4428         with throw.
4429         * compile/compile-object-run.c (compile_object_run): Replace
4430         throw_exception with throw.
4431         * cli/cli-script.c (process_next_line): Replace throw_exception
4432         with throw.
4433         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4434         (btrace_enable, btrace_maint_update_pt_packets): Replace
4435         throw_exception with throw.
4436         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4437         throw_exception with throw.
4438         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4439         throw_exception with throw.
4440         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4441         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4442         * aarch64-tdep.c (aarch64_make_prologue_cache)
4443         (aarch64_make_stub_cache): Replace throw_exception with throw.
4444
4445 2019-04-08  Tom Tromey  <tom@tromey.com>
4446
4447         * common/common-exceptions.c (throw_exception): Rename from
4448         throw_exception_cxx.  Remove old copy.  Make argument const.
4449         (throw_it): Create and throw exception objects directly.
4450         * common/common-exceptions.h (throw_exception): Make argument
4451         const.
4452         (struct gdb_exception_error): Add constructor.
4453         (struct gdb_exception_quit): Add constructor.
4454
4455 2019-04-08  Tom Tromey  <tom@tromey.com>
4456
4457         * common/common-exceptions.h (exception_rethrow): Don't declare.
4458         (TRY_SJLJ): Update comment.
4459         (TRY, CATCH, END_CATCH): Remove.
4460         * common/common-exceptions.c (exception_rethrow): Remove.
4461
4462 2019-04-08  Tom Tromey  <tom@tromey.com>
4463
4464         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4465         Remove.
4466         (gdb_exception_error): Rename from
4467         gdb_exception_RETURN_MASK_ERROR.
4468         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4469         (gdb_quit_bad_alloc): Update.
4470         * aarch64-tdep.c: Update.
4471         * ada-lang.c: Update.
4472         * ada-typeprint.c: Update.
4473         * ada-valprint.c: Update.
4474         * amd64-tdep.c: Update.
4475         * arch-utils.c: Update.
4476         * break-catch-throw.c: Update.
4477         * breakpoint.c: Update.
4478         * btrace.c: Update.
4479         * c-varobj.c: Update.
4480         * cli/cli-cmds.c: Update.
4481         * cli/cli-interp.c: Update.
4482         * cli/cli-script.c: Update.
4483         * common/common-exceptions.c: Update.
4484         * common/new-op.c: Update.
4485         * common/selftest.c: Update.
4486         * compile/compile-c-symbols.c: Update.
4487         * compile/compile-cplus-symbols.c: Update.
4488         * compile/compile-object-load.c: Update.
4489         * compile/compile-object-run.c: Update.
4490         * completer.c: Update.
4491         * corelow.c: Update.
4492         * cp-abi.c: Update.
4493         * cp-support.c: Update.
4494         * cp-valprint.c: Update.
4495         * darwin-nat.c: Update.
4496         * disasm-selftests.c: Update.
4497         * dtrace-probe.c: Update.
4498         * dwarf-index-cache.c: Update.
4499         * dwarf-index-write.c: Update.
4500         * dwarf2-frame-tailcall.c: Update.
4501         * dwarf2-frame.c: Update.
4502         * dwarf2loc.c: Update.
4503         * dwarf2read.c: Update.
4504         * eval.c: Update.
4505         * event-loop.c: Update.
4506         * event-top.c: Update.
4507         * exec.c: Update.
4508         * f-valprint.c: Update.
4509         * fbsd-tdep.c: Update.
4510         * frame-unwind.c: Update.
4511         * frame.c: Update.
4512         * gdbtypes.c: Update.
4513         * gnu-v3-abi.c: Update.
4514         * guile/guile-internal.h: Update.
4515         * guile/scm-block.c: Update.
4516         * guile/scm-breakpoint.c: Update.
4517         * guile/scm-cmd.c: Update.
4518         * guile/scm-disasm.c: Update.
4519         * guile/scm-frame.c: Update.
4520         * guile/scm-lazy-string.c: Update.
4521         * guile/scm-math.c: Update.
4522         * guile/scm-param.c: Update.
4523         * guile/scm-ports.c: Update.
4524         * guile/scm-pretty-print.c: Update.
4525         * guile/scm-symbol.c: Update.
4526         * guile/scm-symtab.c: Update.
4527         * guile/scm-type.c: Update.
4528         * guile/scm-value.c: Update.
4529         * i386-linux-tdep.c: Update.
4530         * i386-tdep.c: Update.
4531         * inf-loop.c: Update.
4532         * infcall.c: Update.
4533         * infcmd.c: Update.
4534         * infrun.c: Update.
4535         * jit.c: Update.
4536         * language.c: Update.
4537         * linespec.c: Update.
4538         * linux-fork.c: Update.
4539         * linux-nat.c: Update.
4540         * linux-tdep.c: Update.
4541         * linux-thread-db.c: Update.
4542         * main.c: Update.
4543         * mi/mi-cmd-break.c: Update.
4544         * mi/mi-cmd-stack.c: Update.
4545         * mi/mi-interp.c: Update.
4546         * mi/mi-main.c: Update.
4547         * objc-lang.c: Update.
4548         * p-valprint.c: Update.
4549         * parse.c: Update.
4550         * ppc-linux-tdep.c: Update.
4551         * printcmd.c: Update.
4552         * python/py-arch.c: Update.
4553         * python/py-breakpoint.c: Update.
4554         * python/py-cmd.c: Update.
4555         * python/py-finishbreakpoint.c: Update.
4556         * python/py-frame.c: Update.
4557         * python/py-framefilter.c: Update.
4558         * python/py-gdb-readline.c: Update.
4559         * python/py-inferior.c: Update.
4560         * python/py-infthread.c: Update.
4561         * python/py-lazy-string.c: Update.
4562         * python/py-linetable.c: Update.
4563         * python/py-objfile.c: Update.
4564         * python/py-param.c: Update.
4565         * python/py-prettyprint.c: Update.
4566         * python/py-progspace.c: Update.
4567         * python/py-record-btrace.c: Update.
4568         * python/py-record.c: Update.
4569         * python/py-symbol.c: Update.
4570         * python/py-type.c: Update.
4571         * python/py-unwind.c: Update.
4572         * python/py-utils.c: Update.
4573         * python/py-value.c: Update.
4574         * python/python.c: Update.
4575         * record-btrace.c: Update.
4576         * record-full.c: Update.
4577         * remote-fileio.c: Update.
4578         * remote.c: Update.
4579         * riscv-tdep.c: Update.
4580         * rs6000-aix-tdep.c: Update.
4581         * rs6000-tdep.c: Update.
4582         * rust-exp.y: Update.
4583         * rust-lang.c: Update.
4584         * s390-tdep.c: Update.
4585         * selftest-arch.c: Update.
4586         * solib-dsbt.c: Update.
4587         * solib-frv.c: Update.
4588         * solib-spu.c: Update.
4589         * solib-svr4.c: Update.
4590         * solib.c: Update.
4591         * sparc64-linux-tdep.c: Update.
4592         * stack.c: Update.
4593         * symfile-mem.c: Update.
4594         * symmisc.c: Update.
4595         * target.c: Update.
4596         * thread.c: Update.
4597         * top.c: Update.
4598         * tracefile-tfile.c: Update.
4599         * tui/tui.c: Update.
4600         * typeprint.c: Update.
4601         * unittests/cli-utils-selftests.c: Update.
4602         * unittests/parse-connection-spec-selftests.c: Update.
4603         * valops.c: Update.
4604         * valprint.c: Update.
4605         * value.c: Update.
4606         * varobj.c: Update.
4607         * windows-nat.c: Update.
4608         * x86-linux-nat.c: Update.
4609         * xml-support.c: Update.
4610
4611 2019-04-08  Tom Tromey  <tom@tromey.com>
4612
4613         * xml-support.c: Use C++ exception handling.
4614         * x86-linux-nat.c: Use C++ exception handling.
4615         * windows-nat.c: Use C++ exception handling.
4616         * varobj.c: Use C++ exception handling.
4617         * value.c: Use C++ exception handling.
4618         * valprint.c: Use C++ exception handling.
4619         * valops.c: Use C++ exception handling.
4620         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4621         handling.
4622         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4623         * typeprint.c: Use C++ exception handling.
4624         * tui/tui.c: Use C++ exception handling.
4625         * tracefile-tfile.c: Use C++ exception handling.
4626         * top.c: Use C++ exception handling.
4627         * thread.c: Use C++ exception handling.
4628         * target.c: Use C++ exception handling.
4629         * symmisc.c: Use C++ exception handling.
4630         * symfile-mem.c: Use C++ exception handling.
4631         * stack.c: Use C++ exception handling.
4632         * sparc64-linux-tdep.c: Use C++ exception handling.
4633         * solib.c: Use C++ exception handling.
4634         * solib-svr4.c: Use C++ exception handling.
4635         * solib-spu.c: Use C++ exception handling.
4636         * solib-frv.c: Use C++ exception handling.
4637         * solib-dsbt.c: Use C++ exception handling.
4638         * selftest-arch.c: Use C++ exception handling.
4639         * s390-tdep.c: Use C++ exception handling.
4640         * rust-lang.c: Use C++ exception handling.
4641         * rust-exp.y: Use C++ exception handling.
4642         * rs6000-tdep.c: Use C++ exception handling.
4643         * rs6000-aix-tdep.c: Use C++ exception handling.
4644         * riscv-tdep.c: Use C++ exception handling.
4645         * remote.c: Use C++ exception handling.
4646         * remote-fileio.c: Use C++ exception handling.
4647         * record-full.c: Use C++ exception handling.
4648         * record-btrace.c: Use C++ exception handling.
4649         * python/python.c: Use C++ exception handling.
4650         * python/py-value.c: Use C++ exception handling.
4651         * python/py-utils.c: Use C++ exception handling.
4652         * python/py-unwind.c: Use C++ exception handling.
4653         * python/py-type.c: Use C++ exception handling.
4654         * python/py-symbol.c: Use C++ exception handling.
4655         * python/py-record.c: Use C++ exception handling.
4656         * python/py-record-btrace.c: Use C++ exception handling.
4657         * python/py-progspace.c: Use C++ exception handling.
4658         * python/py-prettyprint.c: Use C++ exception handling.
4659         * python/py-param.c: Use C++ exception handling.
4660         * python/py-objfile.c: Use C++ exception handling.
4661         * python/py-linetable.c: Use C++ exception handling.
4662         * python/py-lazy-string.c: Use C++ exception handling.
4663         * python/py-infthread.c: Use C++ exception handling.
4664         * python/py-inferior.c: Use C++ exception handling.
4665         * python/py-gdb-readline.c: Use C++ exception handling.
4666         * python/py-framefilter.c: Use C++ exception handling.
4667         * python/py-frame.c: Use C++ exception handling.
4668         * python/py-finishbreakpoint.c: Use C++ exception handling.
4669         * python/py-cmd.c: Use C++ exception handling.
4670         * python/py-breakpoint.c: Use C++ exception handling.
4671         * python/py-arch.c: Use C++ exception handling.
4672         * printcmd.c: Use C++ exception handling.
4673         * ppc-linux-tdep.c: Use C++ exception handling.
4674         * parse.c: Use C++ exception handling.
4675         * p-valprint.c: Use C++ exception handling.
4676         * objc-lang.c: Use C++ exception handling.
4677         * mi/mi-main.c: Use C++ exception handling.
4678         * mi/mi-interp.c: Use C++ exception handling.
4679         * mi/mi-cmd-stack.c: Use C++ exception handling.
4680         * mi/mi-cmd-break.c: Use C++ exception handling.
4681         * main.c: Use C++ exception handling.
4682         * linux-thread-db.c: Use C++ exception handling.
4683         * linux-tdep.c: Use C++ exception handling.
4684         * linux-nat.c: Use C++ exception handling.
4685         * linux-fork.c: Use C++ exception handling.
4686         * linespec.c: Use C++ exception handling.
4687         * language.c: Use C++ exception handling.
4688         * jit.c: Use C++ exception handling.
4689         * infrun.c: Use C++ exception handling.
4690         * infcmd.c: Use C++ exception handling.
4691         * infcall.c: Use C++ exception handling.
4692         * inf-loop.c: Use C++ exception handling.
4693         * i386-tdep.c: Use C++ exception handling.
4694         * i386-linux-tdep.c: Use C++ exception handling.
4695         * guile/scm-value.c: Use C++ exception handling.
4696         * guile/scm-type.c: Use C++ exception handling.
4697         * guile/scm-symtab.c: Use C++ exception handling.
4698         * guile/scm-symbol.c: Use C++ exception handling.
4699         * guile/scm-pretty-print.c: Use C++ exception handling.
4700         * guile/scm-ports.c: Use C++ exception handling.
4701         * guile/scm-param.c: Use C++ exception handling.
4702         * guile/scm-math.c: Use C++ exception handling.
4703         * guile/scm-lazy-string.c: Use C++ exception handling.
4704         * guile/scm-frame.c: Use C++ exception handling.
4705         * guile/scm-disasm.c: Use C++ exception handling.
4706         * guile/scm-cmd.c: Use C++ exception handling.
4707         * guile/scm-breakpoint.c: Use C++ exception handling.
4708         * guile/scm-block.c: Use C++ exception handling.
4709         * guile/guile-internal.h: Use C++ exception handling.
4710         * gnu-v3-abi.c: Use C++ exception handling.
4711         * gdbtypes.c: Use C++ exception handling.
4712         * frame.c: Use C++ exception handling.
4713         * frame-unwind.c: Use C++ exception handling.
4714         * fbsd-tdep.c: Use C++ exception handling.
4715         * f-valprint.c: Use C++ exception handling.
4716         * exec.c: Use C++ exception handling.
4717         * event-top.c: Use C++ exception handling.
4718         * event-loop.c: Use C++ exception handling.
4719         * eval.c: Use C++ exception handling.
4720         * dwarf2read.c: Use C++ exception handling.
4721         * dwarf2loc.c: Use C++ exception handling.
4722         * dwarf2-frame.c: Use C++ exception handling.
4723         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4724         * dwarf-index-write.c: Use C++ exception handling.
4725         * dwarf-index-cache.c: Use C++ exception handling.
4726         * dtrace-probe.c: Use C++ exception handling.
4727         * disasm-selftests.c: Use C++ exception handling.
4728         * darwin-nat.c: Use C++ exception handling.
4729         * cp-valprint.c: Use C++ exception handling.
4730         * cp-support.c: Use C++ exception handling.
4731         * cp-abi.c: Use C++ exception handling.
4732         * corelow.c: Use C++ exception handling.
4733         * completer.c: Use C++ exception handling.
4734         * compile/compile-object-run.c: Use C++ exception handling.
4735         * compile/compile-object-load.c: Use C++ exception handling.
4736         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4737         * compile/compile-c-symbols.c: Use C++ exception handling.
4738         * common/selftest.c: Use C++ exception handling.
4739         * common/new-op.c: Use C++ exception handling.
4740         * cli/cli-script.c: Use C++ exception handling.
4741         * cli/cli-interp.c: Use C++ exception handling.
4742         * cli/cli-cmds.c: Use C++ exception handling.
4743         * c-varobj.c: Use C++ exception handling.
4744         * btrace.c: Use C++ exception handling.
4745         * breakpoint.c: Use C++ exception handling.
4746         * break-catch-throw.c: Use C++ exception handling.
4747         * arch-utils.c: Use C++ exception handling.
4748         * amd64-tdep.c: Use C++ exception handling.
4749         * ada-valprint.c: Use C++ exception handling.
4750         * ada-typeprint.c: Use C++ exception handling.
4751         * ada-lang.c: Use C++ exception handling.
4752         * aarch64-tdep.c: Use C++ exception handling.
4753
4754 2019-04-08  Tom Tromey  <tom@tromey.com>
4755
4756         * xml-support.c (gdb_xml_parser::parse): Update.
4757         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4758         * value.c (show_convenience): Update.
4759         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4760         (test_parse_flags_qcs): Update.
4761         * thread.c (thr_try_catch_cmd): Update.
4762         * target.c (target_translate_tls_address): Update.
4763         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4764         (info_frame_command_core, frame_apply_command_count): Update.
4765         * rust-exp.y (rust_lex_exception_test): Update.
4766         * riscv-tdep.c (riscv_print_one_register_info): Update.
4767         * remote.c (remote_target::enable_btrace): Update.
4768         * record-btrace.c (record_btrace_enable_warn): Update.
4769         * python/py-utils.c (gdbpy_convert_exception): Update.
4770         * printcmd.c (do_one_display, print_variable_and_value): Update.
4771         * mi/mi-main.c (mi_print_exception): Update.
4772         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4773         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4774         * linux-nat.c (linux_nat_target::attach): Update.
4775         * linux-fork.c (class scoped_switch_fork_info): Update.
4776         * infrun.c (displaced_step_prepare): Update.
4777         * infcall.c (call_function_by_hand_dummy): Update.
4778         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4779         * gnu-v3-abi.c (print_one_vtable): Update.
4780         * frame.c (get_prev_frame_always): Update.
4781         * f-valprint.c (info_common_command_for_block): Update.
4782         * exec.c (try_open_exec_file): Update.
4783         * exceptions.c (print_exception, exception_print)
4784         (exception_fprintf, exception_print_same): Update.
4785         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4786         * dwarf-index-cache.c (index_cache::store)
4787         (index_cache::lookup_gdb_index): Update.
4788         * darwin-nat.c (maybe_cache_shell): Update.
4789         * cp-valprint.c (cp_print_value_fields): Update.
4790         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4791         (gcc_cplus_symbol_address): Update.
4792         * compile/compile-c-symbols.c (gcc_convert_symbol)
4793         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4794         * common/selftest.c: Update.
4795         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4796         a std::string.
4797         (exception_try_scope_entry, exception_try_scope_exit): Don't
4798         declare.
4799         (struct exception_try_scope): Remove.
4800         (TRY): Don't use exception_try_scope.
4801         (struct gdb_exception): Add constructor, operator=.
4802         <what>: New method.
4803         (struct gdb_exception_RETURN_MASK_ALL)
4804         (struct gdb_exception_RETURN_MASK_ERROR)
4805         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4806         (struct gdb_quit_bad_alloc): Update.
4807         * common/common-exceptions.c (exception_none): Change
4808         initializer.
4809         (struct catcher) <state, exception>: Initialize inline.
4810         <prev>: Remove member.
4811         (current_catcher): Remove.
4812         (catchers): New global.
4813         (exceptions_state_mc_init): Simplify.
4814         (catcher_pop): Remove.
4815         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4816         (try_scope_depth, exception_try_scope_entry)
4817         (exception_try_scope_exit): Remove.
4818         (throw_exception_sjlj): Update.
4819         (exception_messages, exception_messages_size): Remove.
4820         (throw_it): Simplify.
4821         (gdb_exception_sliced_copy): Remove.
4822         (throw_exception_cxx): Update.
4823         * cli/cli-script.c (script_from_file): Update.
4824         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4825         Update.
4826         * ada-valprint.c (ada_val_print): Update.
4827         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4828         (create_excep_cond_exprs): Update.
4829
4830 2019-04-08  Tom Tromey  <tom@tromey.com>
4831
4832         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4833         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4834         (TRY, CATCH, END_CATCH): Remove some definitions.
4835         * common/common-exceptions.c: Don't use GDB_XCPT.
4836         (catcher_list_size): Remove.
4837         (throw_exception, throw_it): Simplify.
4838
4839 2019-04-05  Tom Tromey  <tom@tromey.com>
4840
4841         Revert the header-sorting patch.
4842         * ft32-tdep.c: Revert.
4843         * frv-tdep.c: Revert.
4844         * frv-linux-tdep.c: Revert.
4845         * frame.c: Revert.
4846         * frame-unwind.c: Revert.
4847         * frame-base.c: Revert.
4848         * fork-child.c: Revert.
4849         * findvar.c: Revert.
4850         * findcmd.c: Revert.
4851         * filesystem.c: Revert.
4852         * filename-seen-cache.h: Revert.
4853         * filename-seen-cache.c: Revert.
4854         * fbsd-tdep.c: Revert.
4855         * fbsd-nat.h: Revert.
4856         * fbsd-nat.c: Revert.
4857         * f-valprint.c: Revert.
4858         * f-typeprint.c: Revert.
4859         * f-lang.c: Revert.
4860         * extension.h: Revert.
4861         * extension.c: Revert.
4862         * extension-priv.h: Revert.
4863         * expprint.c: Revert.
4864         * exec.h: Revert.
4865         * exec.c: Revert.
4866         * exceptions.c: Revert.
4867         * event-top.c: Revert.
4868         * event-loop.c: Revert.
4869         * eval.c: Revert.
4870         * elfread.c: Revert.
4871         * dwarf2read.h: Revert.
4872         * dwarf2read.c: Revert.
4873         * dwarf2loc.c: Revert.
4874         * dwarf2expr.h: Revert.
4875         * dwarf2expr.c: Revert.
4876         * dwarf2-frame.c: Revert.
4877         * dwarf2-frame-tailcall.c: Revert.
4878         * dwarf-index-write.h: Revert.
4879         * dwarf-index-write.c: Revert.
4880         * dwarf-index-common.c: Revert.
4881         * dwarf-index-cache.h: Revert.
4882         * dwarf-index-cache.c: Revert.
4883         * dummy-frame.c: Revert.
4884         * dtrace-probe.c: Revert.
4885         * disasm.h: Revert.
4886         * disasm.c: Revert.
4887         * disasm-selftests.c: Revert.
4888         * dictionary.c: Revert.
4889         * dicos-tdep.c: Revert.
4890         * demangle.c: Revert.
4891         * dcache.h: Revert.
4892         * dcache.c: Revert.
4893         * darwin-nat.h: Revert.
4894         * darwin-nat.c: Revert.
4895         * darwin-nat-info.c: Revert.
4896         * d-valprint.c: Revert.
4897         * d-namespace.c: Revert.
4898         * d-lang.c: Revert.
4899         * ctf.c: Revert.
4900         * csky-tdep.c: Revert.
4901         * csky-linux-tdep.c: Revert.
4902         * cris-tdep.c: Revert.
4903         * cris-linux-tdep.c: Revert.
4904         * cp-valprint.c: Revert.
4905         * cp-support.c: Revert.
4906         * cp-namespace.c: Revert.
4907         * cp-abi.c: Revert.
4908         * corelow.c: Revert.
4909         * corefile.c: Revert.
4910         * continuations.c: Revert.
4911         * completer.h: Revert.
4912         * completer.c: Revert.
4913         * complaints.c: Revert.
4914         * coffread.c: Revert.
4915         * coff-pe-read.c: Revert.
4916         * cli-out.h: Revert.
4917         * cli-out.c: Revert.
4918         * charset.c: Revert.
4919         * c-varobj.c: Revert.
4920         * c-valprint.c: Revert.
4921         * c-typeprint.c: Revert.
4922         * c-lang.c: Revert.
4923         * buildsym.c: Revert.
4924         * buildsym-legacy.c: Revert.
4925         * build-id.h: Revert.
4926         * build-id.c: Revert.
4927         * btrace.c: Revert.
4928         * bsd-uthread.c: Revert.
4929         * breakpoint.h: Revert.
4930         * breakpoint.c: Revert.
4931         * break-catch-throw.c: Revert.
4932         * break-catch-syscall.c: Revert.
4933         * break-catch-sig.c: Revert.
4934         * blockframe.c: Revert.
4935         * block.c: Revert.
4936         * bfin-tdep.c: Revert.
4937         * bfin-linux-tdep.c: Revert.
4938         * bfd-target.c: Revert.
4939         * bcache.c: Revert.
4940         * ax-general.c: Revert.
4941         * ax-gdb.h: Revert.
4942         * ax-gdb.c: Revert.
4943         * avr-tdep.c: Revert.
4944         * auxv.c: Revert.
4945         * auto-load.c: Revert.
4946         * arm-wince-tdep.c: Revert.
4947         * arm-tdep.c: Revert.
4948         * arm-symbian-tdep.c: Revert.
4949         * arm-pikeos-tdep.c: Revert.
4950         * arm-obsd-tdep.c: Revert.
4951         * arm-nbsd-tdep.c: Revert.
4952         * arm-nbsd-nat.c: Revert.
4953         * arm-linux-tdep.c: Revert.
4954         * arm-linux-nat.c: Revert.
4955         * arm-fbsd-tdep.c: Revert.
4956         * arm-fbsd-nat.c: Revert.
4957         * arm-bsd-tdep.c: Revert.
4958         * arch-utils.c: Revert.
4959         * arc-tdep.c: Revert.
4960         * arc-newlib-tdep.c: Revert.
4961         * annotate.h: Revert.
4962         * annotate.c: Revert.
4963         * amd64-windows-tdep.c: Revert.
4964         * amd64-windows-nat.c: Revert.
4965         * amd64-tdep.c: Revert.
4966         * amd64-sol2-tdep.c: Revert.
4967         * amd64-obsd-tdep.c: Revert.
4968         * amd64-obsd-nat.c: Revert.
4969         * amd64-nbsd-tdep.c: Revert.
4970         * amd64-nbsd-nat.c: Revert.
4971         * amd64-nat.c: Revert.
4972         * amd64-linux-tdep.c: Revert.
4973         * amd64-linux-nat.c: Revert.
4974         * amd64-fbsd-tdep.c: Revert.
4975         * amd64-fbsd-nat.c: Revert.
4976         * amd64-dicos-tdep.c: Revert.
4977         * amd64-darwin-tdep.c: Revert.
4978         * amd64-bsd-nat.c: Revert.
4979         * alpha-tdep.c: Revert.
4980         * alpha-obsd-tdep.c: Revert.
4981         * alpha-nbsd-tdep.c: Revert.
4982         * alpha-mdebug-tdep.c: Revert.
4983         * alpha-linux-tdep.c: Revert.
4984         * alpha-linux-nat.c: Revert.
4985         * alpha-bsd-tdep.c: Revert.
4986         * alpha-bsd-nat.c: Revert.
4987         * aix-thread.c: Revert.
4988         * agent.c: Revert.
4989         * addrmap.c: Revert.
4990         * ada-varobj.c: Revert.
4991         * ada-valprint.c: Revert.
4992         * ada-typeprint.c: Revert.
4993         * ada-tasks.c: Revert.
4994         * ada-lang.c: Revert.
4995         * aarch64-tdep.c: Revert.
4996         * aarch64-ravenscar-thread.c: Revert.
4997         * aarch64-newlib-tdep.c: Revert.
4998         * aarch64-linux-tdep.c: Revert.
4999         * aarch64-linux-nat.c: Revert.
5000         * aarch64-fbsd-tdep.c: Revert.
5001         * aarch64-fbsd-nat.c: Revert.
5002         * aarch32-linux-nat.c: Revert.
5003
5004 2019-04-05  Tom Tromey  <tom@tromey.com>
5005
5006         * ft32-tdep.c: Sort headers.
5007         * frv-tdep.c: Sort headers.
5008         * frv-linux-tdep.c: Sort headers.
5009         * frame.c: Sort headers.
5010         * frame-unwind.c: Sort headers.
5011         * frame-base.c: Sort headers.
5012         * fork-child.c: Sort headers.
5013         * findvar.c: Sort headers.
5014         * findcmd.c: Sort headers.
5015         * filesystem.c: Sort headers.
5016         * filename-seen-cache.h: Sort headers.
5017         * filename-seen-cache.c: Sort headers.
5018         * fbsd-tdep.c: Sort headers.
5019         * fbsd-nat.h: Sort headers.
5020         * fbsd-nat.c: Sort headers.
5021         * f-valprint.c: Sort headers.
5022         * f-typeprint.c: Sort headers.
5023         * f-lang.c: Sort headers.
5024         * extension.h: Sort headers.
5025         * extension.c: Sort headers.
5026         * extension-priv.h: Sort headers.
5027         * expprint.c: Sort headers.
5028         * exec.h: Sort headers.
5029         * exec.c: Sort headers.
5030         * exceptions.c: Sort headers.
5031         * event-top.c: Sort headers.
5032         * event-loop.c: Sort headers.
5033         * eval.c: Sort headers.
5034         * elfread.c: Sort headers.
5035         * dwarf2read.h: Sort headers.
5036         * dwarf2read.c: Sort headers.
5037         * dwarf2loc.c: Sort headers.
5038         * dwarf2expr.h: Sort headers.
5039         * dwarf2expr.c: Sort headers.
5040         * dwarf2-frame.c: Sort headers.
5041         * dwarf2-frame-tailcall.c: Sort headers.
5042         * dwarf-index-write.h: Sort headers.
5043         * dwarf-index-write.c: Sort headers.
5044         * dwarf-index-common.c: Sort headers.
5045         * dwarf-index-cache.h: Sort headers.
5046         * dwarf-index-cache.c: Sort headers.
5047         * dummy-frame.c: Sort headers.
5048         * dtrace-probe.c: Sort headers.
5049         * disasm.h: Sort headers.
5050         * disasm.c: Sort headers.
5051         * disasm-selftests.c: Sort headers.
5052         * dictionary.c: Sort headers.
5053         * dicos-tdep.c: Sort headers.
5054         * demangle.c: Sort headers.
5055         * dcache.h: Sort headers.
5056         * dcache.c: Sort headers.
5057         * darwin-nat.h: Sort headers.
5058         * darwin-nat.c: Sort headers.
5059         * darwin-nat-info.c: Sort headers.
5060         * d-valprint.c: Sort headers.
5061         * d-namespace.c: Sort headers.
5062         * d-lang.c: Sort headers.
5063         * ctf.c: Sort headers.
5064         * csky-tdep.c: Sort headers.
5065         * csky-linux-tdep.c: Sort headers.
5066         * cris-tdep.c: Sort headers.
5067         * cris-linux-tdep.c: Sort headers.
5068         * cp-valprint.c: Sort headers.
5069         * cp-support.c: Sort headers.
5070         * cp-namespace.c: Sort headers.
5071         * cp-abi.c: Sort headers.
5072         * corelow.c: Sort headers.
5073         * corefile.c: Sort headers.
5074         * continuations.c: Sort headers.
5075         * completer.h: Sort headers.
5076         * completer.c: Sort headers.
5077         * complaints.c: Sort headers.
5078         * coffread.c: Sort headers.
5079         * coff-pe-read.c: Sort headers.
5080         * cli-out.h: Sort headers.
5081         * cli-out.c: Sort headers.
5082         * charset.c: Sort headers.
5083         * c-varobj.c: Sort headers.
5084         * c-valprint.c: Sort headers.
5085         * c-typeprint.c: Sort headers.
5086         * c-lang.c: Sort headers.
5087         * buildsym.c: Sort headers.
5088         * buildsym-legacy.c: Sort headers.
5089         * build-id.h: Sort headers.
5090         * build-id.c: Sort headers.
5091         * btrace.c: Sort headers.
5092         * bsd-uthread.c: Sort headers.
5093         * breakpoint.h: Sort headers.
5094         * breakpoint.c: Sort headers.
5095         * break-catch-throw.c: Sort headers.
5096         * break-catch-syscall.c: Sort headers.
5097         * break-catch-sig.c: Sort headers.
5098         * blockframe.c: Sort headers.
5099         * block.c: Sort headers.
5100         * bfin-tdep.c: Sort headers.
5101         * bfin-linux-tdep.c: Sort headers.
5102         * bfd-target.c: Sort headers.
5103         * bcache.c: Sort headers.
5104         * ax-general.c: Sort headers.
5105         * ax-gdb.h: Sort headers.
5106         * ax-gdb.c: Sort headers.
5107         * avr-tdep.c: Sort headers.
5108         * auxv.c: Sort headers.
5109         * auto-load.c: Sort headers.
5110         * arm-wince-tdep.c: Sort headers.
5111         * arm-tdep.c: Sort headers.
5112         * arm-symbian-tdep.c: Sort headers.
5113         * arm-pikeos-tdep.c: Sort headers.
5114         * arm-obsd-tdep.c: Sort headers.
5115         * arm-nbsd-tdep.c: Sort headers.
5116         * arm-nbsd-nat.c: Sort headers.
5117         * arm-linux-tdep.c: Sort headers.
5118         * arm-linux-nat.c: Sort headers.
5119         * arm-fbsd-tdep.c: Sort headers.
5120         * arm-fbsd-nat.c: Sort headers.
5121         * arm-bsd-tdep.c: Sort headers.
5122         * arch-utils.c: Sort headers.
5123         * arc-tdep.c: Sort headers.
5124         * arc-newlib-tdep.c: Sort headers.
5125         * annotate.h: Sort headers.
5126         * annotate.c: Sort headers.
5127         * amd64-windows-tdep.c: Sort headers.
5128         * amd64-windows-nat.c: Sort headers.
5129         * amd64-tdep.c: Sort headers.
5130         * amd64-sol2-tdep.c: Sort headers.
5131         * amd64-obsd-tdep.c: Sort headers.
5132         * amd64-obsd-nat.c: Sort headers.
5133         * amd64-nbsd-tdep.c: Sort headers.
5134         * amd64-nbsd-nat.c: Sort headers.
5135         * amd64-nat.c: Sort headers.
5136         * amd64-linux-tdep.c: Sort headers.
5137         * amd64-linux-nat.c: Sort headers.
5138         * amd64-fbsd-tdep.c: Sort headers.
5139         * amd64-fbsd-nat.c: Sort headers.
5140         * amd64-dicos-tdep.c: Sort headers.
5141         * amd64-darwin-tdep.c: Sort headers.
5142         * amd64-bsd-nat.c: Sort headers.
5143         * alpha-tdep.c: Sort headers.
5144         * alpha-obsd-tdep.c: Sort headers.
5145         * alpha-nbsd-tdep.c: Sort headers.
5146         * alpha-mdebug-tdep.c: Sort headers.
5147         * alpha-linux-tdep.c: Sort headers.
5148         * alpha-linux-nat.c: Sort headers.
5149         * alpha-bsd-tdep.c: Sort headers.
5150         * alpha-bsd-nat.c: Sort headers.
5151         * aix-thread.c: Sort headers.
5152         * agent.c: Sort headers.
5153         * addrmap.c: Sort headers.
5154         * ada-varobj.c: Sort headers.
5155         * ada-valprint.c: Sort headers.
5156         * ada-typeprint.c: Sort headers.
5157         * ada-tasks.c: Sort headers.
5158         * ada-lang.c: Sort headers.
5159         * aarch64-tdep.c: Sort headers.
5160         * aarch64-ravenscar-thread.c: Sort headers.
5161         * aarch64-newlib-tdep.c: Sort headers.
5162         * aarch64-linux-tdep.c: Sort headers.
5163         * aarch64-linux-nat.c: Sort headers.
5164         * aarch64-fbsd-tdep.c: Sort headers.
5165         * aarch64-fbsd-nat.c: Sort headers.
5166         * aarch32-linux-nat.c: Sort headers.
5167
5168 2019-04-04  Tom Tromey  <tom@tromey.com>
5169
5170         * varobj.c (varobj_create): Update.
5171         * rust-exp.y (struct rust_parser) <update_innermost_block,
5172         lookup_symbol>: New methods.
5173         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5174         Rename.
5175         (rust_parser::rust_lookup_type)
5176         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5177         * printcmd.c (display_command, do_one_display): Update.
5178         * parser-defs.h (struct parser_state) <parser_state>: Add
5179         "tracker" parameter.
5180         (block_tracker): New member.
5181         (class innermost_block_tracker) <innermost_block_tracker>: Add
5182         "types" parameter.
5183         <reset>: Remove method.
5184         (innermost_block): Don't declare.
5185         (null_post_parser): Update.
5186         * parse.c (innermost_block): Remove global.
5187         (write_dollar_variable): Update.
5188         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5189         Remove "tracker_types" parameter.
5190         (parse_expression): Add "tracker" parameter.
5191         (parse_expression_for_completion): Update.
5192         (null_post_parser): Add "tracker" parameter.
5193         * p-exp.y: Update rules.
5194         * m2-exp.y: Update rules.
5195         * language.h (struct language_defn) <la_post_parser>: Add
5196         "tracker" parameter.
5197         * go-exp.y: Update rules.
5198         * f-exp.y: Update rules.
5199         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5200         parameter.
5201         * d-exp.y: Update rules.
5202         * c-exp.y: Update rules.
5203         * breakpoint.c (set_breakpoint_condition): Create an
5204         innermost_block_tracker.
5205         (watch_command_1): Likewise.
5206         * ada-lang.c (resolve): Add "tracker" parameter.
5207         (resolve_subexp): Likewise.
5208         * ada-exp.y (write_var_from_sym): Update.
5209
5210 2019-04-04  Tom Tromey  <tom@tromey.com>
5211
5212         * type-stack.h: New file.
5213         * type-stack.c: New file.
5214         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5215         type-stack.h.
5216         (insert_into_type_stack, insert_type, push_type, push_type_int)
5217         (insert_type_address_space, pop_type, pop_type_int)
5218         (pop_typelist, pop_type_stack, append_type_stack)
5219         (push_type_stack, get_type_stack, push_typelist)
5220         (follow_type_instance_flags, follow_types): Don't declare.
5221         * parse.c (type_stack): Remove global.
5222         (parse_exp_in_context): Update.
5223         (insert_into_type_stack, insert_type, push_type, push_type_int)
5224         (insert_type_address_space, pop_type, pop_type_int)
5225         (pop_typelist, pop_type_stack, append_type_stack)
5226         (push_type_stack, get_type_stack, push_typelist)
5227         (follow_type_instance_flags, follow_types): Remove (moved to
5228         type-stack.c).
5229         * f-exp.y (type_stack): New global.
5230         Update rules.
5231         (push_kind_type, f_parse): Update.
5232         * d-exp.y (type_stack): New global.
5233         Update rules.
5234         (d_parse): Update.
5235         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5236         Update rules.
5237         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5238         (HFILES_NO_SRCDIR): Add type-stack.h.
5239
5240 2019-04-04  Tom Tromey  <tom@tromey.com>
5241
5242         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5243         (rust_parser::convert_ast_to_expression, rust_parse)
5244         (rust_lex_test_completion, rust_lex_tests): Update.
5245         * parser-defs.h (struct expr_completion_state): New.
5246         (struct parser_state) <parser_state>: Add completion parameter.
5247         <mark_struct_expression, mark_completion_tag>: New methods.
5248         <parse_completion, m_completion_state>: New members.
5249         (prefixify_expression, null_post_parser): Update.
5250         (mark_struct_expression, mark_completion_tag): Don't declare.
5251         * parse.c (parse_completion, expout_last_struct)
5252         (expout_tag_completion_type, expout_completion_name): Remove
5253         globals.
5254         (parser_state::mark_struct_expression)
5255         (parser_state::mark_completion_tag): Now methods.
5256         (prefixify_expression): Add last_struct parameter.
5257         (prefixify_subexp): Likewise.
5258         (parse_exp_1): Update.
5259         (parse_exp_in_context): Add cstate parameter.  Update.
5260         (parse_expression_for_completion): Create an
5261         expr_completion_state.
5262         (null_post_parser): Add "completion" parameter.
5263         * p-exp.y: Update rules.
5264         (yylex): Update.
5265         * language.h (struct language_defn) <la_post_parser>: Add
5266         "completing" parameter.
5267         * go-exp.y: Update rules.
5268         (lex_one_token): Update.
5269         * expression.h (parse_completion): Don't declare.
5270         * d-exp.y: Update rules.
5271         (lex_one_token): Update rules.
5272         * c-exp.y: Update rules.
5273         (lex_one_token): Update.
5274         * ada-lang.c (resolve): Add "parse_completion" parameter.
5275         (resolve_subexp): Likewise.
5276         (ada_resolve_function): Likewise.
5277
5278 2019-04-04  Tom Tromey  <tom@tromey.com>
5279
5280         * parser-defs.h (struct parser_state) <start_arglist,
5281         end_arglist>: New methods.
5282         <arglist_len, m_funcall_chain>: New members.
5283         (arglist_len, start_arglist, end_arglist): Don't declare.
5284         * parse.c (arglist_len, funcall_chain): Remove global.
5285         (start_arglist, end_arglist): Remove functions.
5286         (parse_exp_in_context): Update.
5287         * p-exp.y: Update rules.
5288         * m2-exp.y: Update rules.
5289         * go-exp.y: Update rules.
5290         * f-exp.y: Update rules.
5291         * d-exp.y: Update rules.
5292         * c-exp.y: Update rules.
5293
5294 2019-04-04  Tom Tromey  <tom@tromey.com>
5295
5296         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5297         lex_operator, push_back>: New methods.
5298         Update all rules.
5299         (rust_parser::lex_hex, lex_escape): Rename and update.
5300         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5301         (rust_parser::lex_operator): Rename and update.
5302         (rust_parser::lex_number, rustyylex, rustyyerror)
5303         (rust_lex_test_init, rust_lex_test_sequence)
5304         (rust_lex_test_push_back, rust_lex_tests): Update.
5305         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5306         parameter.
5307         <lexptr, prev_lexptr>: New members.
5308         (lexptr, prev_lexptr): Don't declare.
5309         * parse.c (lexptr, prev_lexptr): Remove globals.
5310         (parse_exp_in_context): Update.
5311         * p-exp.y (yylex, yyerror): Update.
5312         * m2-exp.y (parse_number, yylex, yyerror): Update.
5313         * go-exp.y (lex_one_token, yyerror): Update.
5314         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5315         * d-exp.y (lex_one_token, yyerror): Update.
5316         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5317         (lex_one_token, yyerror): Update.
5318         * ada-lex.l (YY_INPUT): Update.
5319         (rewind_to_char): Update.
5320         * ada-exp.y (yyerror): Update.
5321
5322 2019-04-04  Tom Tromey  <tom@tromey.com>
5323
5324         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5325         * parser-defs.h (struct parser_state) <parser_state>: Add new
5326         parameter.
5327         <comma_terminates>: New member.
5328         (comma_terminates): Don't declare global.
5329         * parse.c (comma_terminates): Remove global.
5330         (parse_exp_in_context): Update.
5331         * p-exp.y (yylex): Update.
5332         * m2-exp.y (yylex): Update.
5333         * go-exp.y (lex_one_token): Update.
5334         * f-exp.y (yylex): Update.
5335         * d-exp.y (lex_one_token): Update.
5336         * c-exp.y (lex_one_token): Update.
5337         * ada-lex.l: Update.
5338
5339 2019-04-04  Tom Tromey  <tom@tromey.com>
5340
5341         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5342         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5343         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5344         * parser-defs.h (paren_depth): Don't declare.
5345         * parse.c (paren_depth): Remove global.
5346         (parse_exp_in_context): Update.
5347         * p-exp.y (paren_depth): New global.
5348         (pascal_parse): Initialize it.
5349         * m2-exp.y (paren_depth): New global.
5350         (m2_parse): Initialize it.
5351         * go-exp.y (paren_depth): New global.
5352         (go_parse): Initialize it.
5353         * f-exp.y (paren_depth): New global.
5354         (f_parse): Initialize it.
5355         * d-exp.y (paren_depth): New global.
5356         (d_parse): Initialize it.
5357         * c-exp.y (paren_depth): New global.
5358         (c_parse): Initialize it.
5359         * ada-lex.l (paren_depth): New global.
5360         (lexer_init): Initialize it.
5361
5362 2019-04-04  Tom Tromey  <tom@tromey.com>
5363
5364         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5365         (rust_parser::convert_ast_to_type)
5366         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5367         * parser-defs.h (struct parser_state) <parser_state>: Add
5368         parameters.  Initialize new members.
5369         <expression_context_block, expression_context_pc>: New members.
5370         * parse.c (expression_context_block, expression_context_pc):
5371         Remove globals.
5372         (parse_exp_in_context): Update.
5373         * p-exp.y: Update all rules.
5374         (yylex): Update.
5375         * m2-exp.y: Update all rules.
5376         (yylex): Update.
5377         * go-exp.y (yylex): Update.
5378         * f-exp.y (yylex): Update.
5379         * d-exp.y: Update all rules.
5380         (yylex): Update.
5381         * c-exp.y: Update all rules.
5382         (lex_one_token, classify_name, yylex, c_parse): Update.
5383         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5384
5385 2019-04-04  Tom Tromey  <tom@tromey.com>
5386
5387         * gdbarch.h, gdbarch.c: Rebuild.
5388         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5389         * stap-probe.h:
5390         (struct stap_parse_info): Replace "parser_state" with
5391         "expr_builder".
5392         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5393         (parser_state): New class.
5394         * parse.c (expr_builder): Rename.
5395         (expr_builder::release): Rename.
5396         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5397         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5398         (write_exp_elt_longcst, write_exp_elt_floatcst)
5399         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5400         (write_exp_string_vector, write_exp_bitstring)
5401         (write_exp_msymbol, mark_struct_expression)
5402         (write_dollar_variable)
5403         (insert_type_address_space, increase_expout_size): Replace
5404         "parser_state" with "expr_builder".
5405         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5406         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5407         "parser_state" with "expr_builder".
5408
5409 2019-04-04  Tom Tromey  <tom@tromey.com>
5410
5411         * rust-exp.y: Replace "parse_language" with method call.
5412         * p-exp.y:
5413         (yylex): Replace "parse_language" with method call.
5414         * m2-exp.y:
5415         (yylex): Replace "parse_language" with method call.
5416         * go-exp.y (classify_name): Replace "parse_language" with method
5417         call.
5418         * f-exp.y (yylex): Replace "parse_language" with method call.
5419         * d-exp.y (lex_one_token): Replace "parse_language" with method
5420         call.
5421         * c-exp.y:
5422         (lex_one_token, classify_name, yylex): Replace "parse_language"
5423         with method call.
5424         * ada-exp.y (find_primitive_type, type_char)
5425         (type_system_address): Replace "parse_language" with method call.
5426
5427 2019-04-04  Tom Tromey  <tom@tromey.com>
5428
5429         * rust-exp.y: Replace "parse_gdbarch" with method call.
5430         * parse.c (write_dollar_variable, insert_type_address_space):
5431         Replace "parse_gdbarch" with method call.
5432         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5433         call.
5434         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5435         call.
5436         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5437         "parse_gdbarch" with method call.
5438         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5439         with method call.
5440         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5441         "parse_gdbarch" with method call.
5442         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5443         "parse_gdbarch" with method call.
5444         * c-exp.y (parse_type, parse_number, classify_name): Replace
5445         "parse_gdbarch" with method call.
5446         * ada-lex.l: Replace "parse_gdbarch" with method call.
5447         * ada-exp.y (parse_type, find_primitive_type, type_char)
5448         (type_system_address): Replace "parse_gdbarch" with method call.
5449
5450 2019-04-04  Tom Tromey  <tom@tromey.com>
5451
5452         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5453         * stap-probe.c (stap_parse_argument): Update.
5454         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5455         initial_size parameter.
5456         * rust-exp.y (rust_lex_tests): Update.
5457         * parse.c (parser_state): Update.
5458         (parse_exp_in_context): Update.
5459         * parser-defs.h (struct parser_state) <parser_state>: Remove
5460         "initial_size" parameter.
5461
5462 2019-04-04  Tom Tromey  <tom@tromey.com>
5463
5464         * parser-defs.h (increase_expout_size): Don't declare.
5465         * parse.c (increase_expout_size): Now static.
5466
5467 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5468
5469         * gnu-nat.c (gnu_nat_target::wait): Fix
5470         target_waitstatus_to_string call.
5471
5472 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5473
5474         * eval.c (evaluate_subexp_standard): Handle internal functions
5475         during Fortran function call handling.
5476
5477 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5478
5479         * NEWS: Mention new internal functions.
5480         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5481         (read_base_type): Use dwarf2_init_complex_target_type.
5482         * value.c (creal_internal_fn): New function.
5483         (cimag_internal_fn): New function.
5484         (_initialize_values): Register new internal functions.
5485
5486 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5487
5488         * infrun.c (stop_all_threads): If debug_infrun, always
5489         trace the wait status after wait_one, using
5490         target_waitstatus_to_string and target_pid_to_str.
5491         (handle_inferior_event): Replace various trace of
5492         wait status kind by a single trace.
5493         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5494         wait status kind image by target_waitstatus_to_string.
5495         * target/waitstatus.c (target_waitstatus_to_string): Fix
5496         obsolete comment.
5497
5498 2019-04-01  Tom Tromey  <tromey@adacore.com>
5499
5500         PR symtab/23331:
5501         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5502
5503 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5504             Pedro Alves  <palves@redhat.com>
5505
5506         * top.c (quit_force): Call 'finalize_values'.
5507         * value.c (finalize_values): New function.
5508         * value.h (finalize_values): Declare.
5509
5510 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5511
5512         * NEWS: Announce $_gdb_major and $_gdb_minor.
5513
5514         * top.c (init_gdb_version_vars): New function.
5515         (gdb_init): Call init_gdb_version_vars.
5516
5517 2019-03-29  Tom Tromey  <tromey@adacore.com>
5518
5519         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5520         help text.  Remove dead code.
5521
5522 2019-03-29  Keith Seitz  <keiths@redhat.com>
5523
5524         From Siddhesh Poyarekar:
5525         * f-lang.h (f77_get_upperbound): Return LONGEST.
5526         (f77_get_lowerbound): Likewise.
5527         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5528         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5529         print them.
5530         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5531         plongest to format print it.
5532         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5533         (f77_get_upperbound): Likewise.
5534         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5535         LOWER_BOUND to LONGEST.
5536         (f77_create_arrayprint_offset_tbl): Likewise.
5537
5538 2019-03-29  Keith Seitz  <keiths@redhat.com>
5539
5540         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5541         %s/pulongest for TYPE_LENGTH instead of %d in format
5542         strings.
5543         * ada-typerint.c (ada_print_type): Likewise.
5544         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5545         * compile/compile-c-support.c (generate_register_struct): Likewise.
5546         * gdbtypes.c (recursive_dump_type): Likewise.
5547         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5548         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5549         instead of %d in format strings.
5550         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5551         to std::min to ULONGEST.
5552         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5553         instead of %d in format strings.
5554         * tracepoint.c (info_scope_command): Likewise.
5555         * typeprint.c (print_offset_data::update)
5556         (print_offset_data::finish): Likewise.
5557         * xtensa-tdep.c (xtensa_store_return_value)
5558         (xtensa_push_dummy_call): Likewise.
5559
5560 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5561
5562         * windows-nat.c (display_selector): Fixed format specifications
5563         for 64-bit Cygwin.
5564
5565 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5566
5567         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5568
5569 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5570
5571         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5572         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5573         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5574         (nios2_linux_init_abi): Install it.
5575
5576 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5577
5578         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5579
5580 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5581
5582         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5583
5584 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5585             Tom Tromey  <tromey@adacore.com>
5586
5587         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5588
5589 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5590
5591         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5592         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5593         method to compute the bounds of range types. Also print "[evaluated]"
5594         if the bounds' values come from a dynamic evaluation.
5595
5596 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5597
5598         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5599         whitespace when pretty printing is on.
5600
5601 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5602
5603         * ppc-linux-nat.c: Add include.
5604
5605 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5606
5607         * NEWS: Mention AArch64 Pointer Authentication.
5608
5609 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5610
5611         * arm-linux-nat.c: Add include.
5612
5613 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5614
5615         * source-cache.c (source_cache::get_source_lines): Re-read
5616         fullname after calling open_source_file.
5617
5618 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5619
5620         * NEWS: Mention TLS support for FreeBSD.
5621
5622 2019-03-25  Tom Tromey  <tromey@adacore.com>
5623
5624         * minsyms.c (BUNCH_SIZE): Update comment.
5625         (~minimal_symbol_reader): Remove old comment.
5626         (compact_minimal_symbols): Update comment.
5627         (minimal_symbol_reader::install): Remove old comment.  Update
5628         other comments.
5629
5630 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5631
5632         * s390-linux-nat.c: Add include.
5633
5634 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5635
5636         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5637         Call linux_get_hwcap.
5638         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5639         Likewise.
5640         (aarch64_linux_get_hwcap): Remove function.
5641         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5642         declaration.
5643         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5644         linux_get_hwcap.
5645         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5646         * linux-tdep.c (linux_get_hwcap): Add function.
5647         (linux_get_hwcap2): Likewise.
5648         * linux-tdep.h (linux_get_hwcap): Add declaration.
5649         (linux_get_hwcap2): Likewise.
5650         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5651         (ppc_linux_get_hwcap2): Likewise.
5652         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5653         linux_get_hwcap.
5654         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5655         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5656         (ppc_linux_nat_target::read_description): Likewise.
5657         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5658         * s390-linux-nat.c: Likewise.
5659         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5660
5661 2019-03-24  Tom Tromey  <tom@tromey.com>
5662
5663         * ada-lang.c (standard_lookup): Simplify initialization.
5664         (ada_lookup_symbol_nonlocal): Simplify return.
5665         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5666         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5667         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5668         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5669         initialization.
5670         * solib.c (solib_global_lookup): Simplify.
5671         * symtab.c (null_block_symbol): Remove.
5672         (symbol_cache_lookup): Simplify returns.
5673         (lookup_language_this): Simplify returns.
5674         (lookup_symbol_aux): Simplify return.
5675         (lookup_local_symbol): Simplify returns.
5676         (lookup_global_symbol_from_objfile): Simplify return.
5677         (lookup_symbol_in_objfile_symtabs)
5678         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5679         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5680         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5681         * cp-namespace.c (cp_lookup_bare_symbol)
5682         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5683         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5684         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5685         (cp_lookup_symbol_via_imports): Simplify initialization.
5686         (find_symbol_in_baseclass): Likewise.
5687         * symtab.h (null_block_symbol): Remove.
5688         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5689         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5690         (d_lookup_symbol_module): Likewise.
5691         (find_symbol_in_baseclass): Simplify initialization.
5692
5693 2019-03-24  Tom Tromey  <tom@tromey.com>
5694
5695         * expression.h: Don't include symtab.h.
5696         (struct block): Forward declare.
5697
5698 2019-03-24  Tom Tromey  <tom@tromey.com>
5699
5700         * c-exp.y (typebase): Remove casts.
5701         * gdbtypes.c (lookup_unsigned_typename, )
5702         (lookup_signed_typename): Remove cast.
5703         * eval.c (parse_to_comma_and_eval): Remove cast.
5704         * parse.c (write_dollar_variable): Remove cast.
5705         * block.h (struct block) <superblock>: Now const.
5706         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5707         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5708         (map_block): Make "block" const.
5709         * symfile.h (struct quick_symbol_functions)
5710         <map_matching_symbols>: Constify block argument to "callback".
5711         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5712         const.
5713         (find_pc_sect_compunit_symtab): Make "b" const.
5714         (find_symbol_at_address): Likewise.
5715         (search_symbols): Likewise.
5716         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5717         (dw2_debug_names_lookup_symbol): Likewise.
5718         (dw2_map_matching_symbols): Update.
5719         * p-valprint.c (pascal_val_print): Remove "block".
5720         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5721         (aux_add_nonlocal_symbols): Make "block" const.
5722         (resolve_subexp): Remove cast.
5723         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5724         const.
5725         (iterate_over_file_blocks): Likewise.
5726         * f-exp.y (%union) <bval>: Remove.
5727         * coffread.c (patch_opaque_types): Make "b" const.
5728         * spu-tdep.c (spu_catch_start): Make "block" const.
5729         * c-valprint.c (print_unpacked_pointer): Remove "block".
5730         * symmisc.c (dump_symtab_1): Make "b" const.
5731         (block_depth): Make "block" const.
5732         * d-exp.y (%union) <bval>: Remove.
5733         * cp-support.h (cp_lookup_rtti_type): Update.
5734         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5735         * psymtab.c (psym_lookup_symbol): Make "block" const.
5736         (maintenance_check_psymtabs): Make "b" const.
5737         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5738         (enumerate_locals, enumerate_args): Update.
5739         * python/py-symtab.c (stpy_global_block): Make "block" const.
5740         (stpy_static_block): Likewise.
5741         * inline-frame.c (block_starting_point_at): Make "new_block"
5742         const.
5743         * block.c (find_block_in_blockvector): Make return type const.
5744         (blockvector_for_pc_sect): Make "b" const.
5745         (find_block_in_blockvector): Make "b" const.
5746
5747 2019-03-23  Tom Tromey  <tom@tromey.com>
5748
5749         * varobj.c (varobj_create): Update.
5750         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5751         * printcmd.c (display_command, do_one_display): Don't reset
5752         innermost_block.
5753         * parser-defs.h (enum innermost_block_tracker_type): Move to
5754         expression.h.
5755         (innermost_block): Update comment.
5756         * parse.c (parse_exp_1): Add tracker_types parameter.
5757         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5758         tracker_types parameter.  Reset innermost_block.
5759         (parse_exp_in_context): Remove.
5760         (parse_expression_for_completion): Update.
5761         * objfiles.c (~objfile): Don't reset expression_context_block or
5762         innermost_block.
5763         * expression.h (enum innermost_block_tracker_type): Move from
5764         parser-defs.h.
5765         (parse_exp_1): Add tracker_types parameter.
5766         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5767         reset innermost_block.
5768
5769 2019-03-23  Tom Tromey  <tom@tromey.com>
5770
5771         * objfiles.h: Include bcache.h.
5772
5773 2019-03-23  Tom Tromey  <tom@tromey.com>
5774
5775         * linespec.c (get_current_search_block): Use
5776         scoped_restore_current_language.
5777         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5778
5779 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5780             Jiong Wang  <jiong.wang@arm.com>
5781
5782         * aarch64-linux-tdep.c
5783         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5784         section.
5785         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5786
5787 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5788             Jiong Wang  <jiong.wang@arm.com>
5789
5790         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5791         instructions.
5792         (aarch64_analyze_prologue_test): Add PACIASP test.
5793         (aarch64_prologue_prev_register): Unmask PC value.
5794
5795 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5796             Jiong Wang  <jiong.wang@arm.com>
5797
5798         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5799         (aarch64_dwarf2_prev_register): Unmask PC value.
5800         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5801         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5802         DW_CFA_AARCH64_negate_ra_state.
5803         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5804
5805 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5806             Jiong Wang  <jiong.wang@arm.com>
5807
5808         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5809         registers.
5810         (aarch64_pseudo_register_name): Likewise.
5811         (aarch64_pseudo_register_type): Likewise.
5812         (aarch64_pseudo_register_reggroup_p): Likewise.
5813         (aarch64_gdbarch_init): Add pauth registers.
5814         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5815         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5816         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5817         (struct gdbarch_tdep): Add regnum for ra_state.
5818
5819 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5820             Jiong Wang  <jiong.wang@arm.com>
5821
5822         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5823
5824 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5825             Jiong Wang  <jiong.wang@arm.com>
5826
5827         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5828         function.
5829         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5830         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5831         (aarch64_gdbarch_init): Add puth registers.
5832         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5833         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5834         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5835
5836 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5837             Jiong Wang  <jiong.wang@arm.com>
5838
5839         * aarch64-linux-nat.c
5840         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5841         * aarch64-linux-tdep.c
5842         (aarch64_linux_core_read_description): Likewise.
5843         (aarch64_linux_get_hwcap): New function.
5844         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5845         (aarch64_linux_get_hwcap): New declaration.
5846
5847 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5848             Jiong Wang  <jiong.wang@arm.com>
5849
5850         * aarch64-linux-nat.c
5851         (aarch64_linux_nat_target::read_description): Add pauth param.
5852         * aarch64-linux-tdep.c
5853         (aarch64_linux_core_read_description): Likewise.
5854         * aarch64-tdep.c (struct target_desc): Add in pauth.
5855         (aarch64_read_description): Add pauth param.
5856         (aarch64_gdbarch_init): Likewise.
5857         * aarch64-tdep.h (aarch64_read_description): Likewise.
5858         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5859         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5860         * features/Makefile: Add new files.
5861         * features/aarch64-pauth.c: New file.
5862         * features/aarch64-pauth.xml: New file.
5863
5864 2019-03-20  Tom Tromey  <tromey@adacore.com>
5865
5866         * infrun.c (handle_inferior_event): Rename from
5867         handle_inferior_event_1.  Create a scoped_value_mark.
5868         (handle_inferior_event): Remove.
5869
5870 2019-03-19  Tom Tromey  <tromey@adacore.com>
5871
5872         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5873         * infrun.h (print_stop_event): Add "displays" parameter.
5874         * infrun.c (print_stop_event): Add "displays" parameter.
5875
5876 2019-03-19  Pedro Alves  <palves@redhat.com>
5877
5878         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5879         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5880         to -1.  Fix TABs vs spaces.
5881         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5882         * tui/tui-out.h (tui_ui_out) Add intro comments.
5883         <m_line, m_start_of_line>: In-class initialize, and add describing
5884         comment.
5885
5886 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5887
5888         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5889         variable names.
5890         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5891
5892 2019-03-18  Pedro Alves  <palves@redhat.com>
5893             Eli Zaretskii <eliz@gnu.org>
5894
5895         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5896         m_line and m_start_of_line.
5897
5898 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5899
5900         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5901         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5902         it returns a newline.  This fixes a regression in TU mode, whereby
5903         the next line is output on the same screen line as the user input.
5904
5905 2019-03-18  Tom Tromey  <tromey@adacore.com>
5906
5907         * minsyms.c (minimal_symbol_reader::install): Remove call to
5908         obstack_blank.
5909
5910 2019-03-18  Pedro Alves  <palves@redhat.com>
5911
5912         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5913         New globals.
5914         (apply_style): New, factored out from ...
5915         (apply_ansi_escape): ... this.  Handle reverse video mode.
5916         (tui_set_reverse_mode): New function.
5917         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5918         * tui/tui-winsource.c (tui_show_source_line): Use
5919         tui_set_reverse_mode instead of setting A_STANDOUT.
5920         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5921         New setter methods.
5922
5923 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5924
5925         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5926         Handle tabs.
5927
5928 2019-03-18  Tom Tromey  <tromey@adacore.com>
5929
5930         * ada-lang.c (empty_array): Add "high" parameter.
5931         (ada_evaluate_subexp): Update.
5932
5933 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5934
5935         * unittests/string_view-selftests.c: Define
5936         _initialize_string_view_selftests unconditionally.
5937
5938 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5939
5940         PR gdb/24350
5941         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5942
5943 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5944
5945         PR gdb/24351
5946         * windows-nat.c (display_selector): Fix format specifiers.
5947
5948 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5949
5950         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5951         tui_refill_source_window instead of tui_refresh_win, to update the
5952         current execution line.  This fixes redisplay of the current line
5953         when stepping through the code with "next" or "step".
5954
5955 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5956
5957         * source-cache.c (source_cache::get_source_lines): Call
5958         find_source_lines to initialize s->nlines.  This fixes vertical
5959         scrolling of TUI source window when the DOWN arrow is pressed.
5960
5961 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5962
5963         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5964         linux-thread-db.c (_initialize_thread_db): Likewise.
5965
5966 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5967
5968         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5969         wclrtoeol in tui_show_source_line".  This reverts changes made in
5970         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5971
5972 2019-03-15  Tom Tromey  <tom@tromey.com>
5973
5974         * symtab.h (struct minimal_symbol): Derive from
5975         general_symbol_info.
5976         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5977         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5978         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5979         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5980         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5981         (MSYMBOL_SEARCH_NAME): Update.
5982         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5983         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5984         * minsyms.c (minimal_symbol_reader::record_full): Update.
5985
5986 2019-03-15  Tom Tromey  <tom@tromey.com>
5987
5988         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5989
5990 2019-03-15  Tom Tromey  <tom@tromey.com>
5991
5992         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5993         unique_xmalloc_ptr.
5994         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5995         Update.
5996         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5997         (build_minimal_symbol_hash_tables)
5998         (minimal_symbol_reader::install): Update.
5999
6000 2019-03-15  Tom Tromey  <tom@tromey.com>
6001
6002         * symtab.c (create_demangled_names_hash): Update.
6003         (symbol_set_names): Update.
6004         * objfiles.h (struct objfile_per_bfd_storage)
6005         <demangled_names_hash>: Now an htab_up.
6006         * objfiles.c (objfile_per_bfd_storage): Simplify.
6007
6008 2019-03-15  Tom Tromey  <tom@tromey.com>
6009
6010         * objfiles.h (struct objfile_per_bfd_storage): Declare
6011         destructor.
6012         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6013         New.
6014         (get_objfile_bfd_data): Use new.  Don't initialize
6015         language_of_main.
6016         (free_objfile_per_bfd_storage): Remove.
6017         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6018
6019 2019-03-15  Tom Tromey  <tom@tromey.com>
6020
6021         * symfile.c (reread_symbols): Update.
6022         * objfiles.c (objfile::objfile): Update.
6023         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6024         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6025         comment.
6026         (minimal_symbol_reader::install): Update.
6027         (terminate_minimal_symbol_table): Remove.
6028         * jit.c (jit_object_close_impl): Update.
6029
6030 2019-03-15  Tom Tromey  <tom@tromey.com>
6031
6032         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6033         initializations.
6034
6035 2019-03-15  Tom Tromey  <tom@tromey.com>
6036
6037         * objfiles.h (struct objfile_per_bfd_storage)
6038         <demangled_hash_languages>: Now a bitset.
6039         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6040         (lookup_minimal_symbol): Update.
6041
6042 2019-03-15  Tom Tromey  <tom@tromey.com>
6043
6044         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6045         Don't return the symbol.
6046         * coffread.c (record_minimal_symbol): Use record_full.
6047
6048 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6049
6050         The MS-Windows port of ncurses fails to switch to a color pair if
6051         one or both of the colors are the implicit default colors.  This
6052         change records the default colors when TUI is initialized, and
6053         then specifies them explicitly when a color pair uses the default
6054         colors.  This allows color styling in TUI mode on MS-Windows.
6055
6056         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6057         ncurses_norm_attr.
6058         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6059         colors in ncurses_norm_attr.
6060         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6061         "none", replace it with the default color recorded in
6062         ncurses_norm_attr.
6063
6064 2019-03-14  Tom Tromey  <tromey@adacore.com>
6065
6066         * source-cache.h (class source_cache) <get_source_lines>: Return
6067         std::string.
6068         * source-cache.c (source_cache::extract_lines): Handle case where
6069         first_pos==npos.  Return std::string.
6070         (source_cache::get_source_lines): Update.
6071
6072 2019-03-14  Tom Tromey  <tromey@adacore.com>
6073
6074         * NEWS: Add item for "style sources" commands.
6075         * source-cache.c (source_cache::get_source_lines): Check
6076         source_styling.
6077         * cli/cli-style.c (source_styling): New global.
6078         (_initialize_cli_style): Add "style sources" commands.
6079         (show_style_sources): New function.
6080         * cli/cli-style.h (source_styling): Declare.
6081
6082 2019-03-14  Pedro Alves  <palves@redhat.com>
6083             Tom Tromey  <tromey@adacore.com>
6084
6085         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6086         * tui/tui-winsource.c (tui_refill_source_window): New function,
6087         from...
6088         (tui_horizontal_source_scroll): ... here.  Move some logic.
6089         * cli/cli-style.c (set_style_enabled): Notify new observable.
6090         * tui/tui-hooks.c (tui_redisplay_source): New function.
6091         (tui_attach_detach_observers): Attach or detach
6092         tui_redisplay_source.
6093         * observable.h (source_styling_changed): New observable.
6094         * observable.c: Define source_styling_changed observable.
6095
6096 2019-03-13  Tom Tromey  <tromey@adacore.com>
6097
6098         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6099         (i386_gnu_nat_target::store_registers): Update.
6100         * target-debug.h (target_debug_print_std_string): New macro.
6101         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6102         * windows-tdep.c (display_one_tib): Update.
6103         * tui/tui-stack.c (tui_make_status_line): Update.
6104         * top.c (print_inferior_quit_action): Update.
6105         * thread.c (thr_try_catch_cmd): Update.
6106         (add_thread_with_info): Update.
6107         (thread_target_id_str): Update.
6108         (thr_try_catch_cmd): Update.
6109         (thread_command): Update.
6110         (thread_find_command): Update.
6111         * record-btrace.c (record_btrace_target::info_record)
6112         (record_btrace_resume_thread, record_btrace_target::resume)
6113         (record_btrace_cancel_resume, record_btrace_step_thread)
6114         (record_btrace_target::wait, record_btrace_target::wait)
6115         (record_btrace_target::wait, record_btrace_target::stop): Update.
6116         * progspace.c (print_program_space): Update.
6117         * process-stratum-target.c
6118         (process_stratum_target::thread_address_space): Update.
6119         * linux-fork.c (linux_fork_mourn_inferior)
6120         (detach_checkpoint_command, info_checkpoints_command)
6121         (linux_fork_context): Update.
6122         (linux_fork_detach): Update.
6123         (class scoped_switch_fork_info): Update.
6124         (delete_checkpoint_command): Update.
6125         * infrun.c (follow_fork_inferior): Update.
6126         (follow_fork_inferior): Update.
6127         (proceed_after_vfork_done): Update.
6128         (handle_vfork_child_exec_or_exit): Update.
6129         (follow_exec): Update.
6130         (displaced_step_prepare_throw): Update.
6131         (displaced_step_restore): Update.
6132         (start_step_over): Update.
6133         (resume_1): Update.
6134         (clear_proceed_status_thread): Update.
6135         (proceed): Update.
6136         (print_target_wait_results): Update.
6137         (do_target_wait): Update.
6138         (context_switch): Update.
6139         (stop_all_threads): Update.
6140         (restart_threads): Update.
6141         (finish_step_over): Update.
6142         (handle_signal_stop): Update.
6143         (switch_back_to_stepped_thread): Update.
6144         (keep_going_pass_signal): Update.
6145         (print_exited_reason): Update.
6146         (normal_stop): Update.
6147         * inferior.c (inferior_pid_to_str): Change return type.
6148         (print_selected_inferior): Update.
6149         (add_inferior): Update.
6150         (detach_inferior): Update.
6151         * dummy-frame.c (fprint_dummy_frames): Update.
6152         * dcache.c (dcache_info_1): Update.
6153         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6154         (btrace_fetch, btrace_clear): Update.
6155         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6156         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6157         type.
6158         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6159         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6160         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6161         * gdbarch.c, gdbarch.h: Rebuild.
6162         * gdbarch.sh (core_pid_to_str): Change return type.
6163         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6164         return type.
6165         (windows_nat_target::pid_to_str): Change return type.
6166         (windows_delete_thread): Update.
6167         (windows_nat_target::attach): Update.
6168         (windows_nat_target::files_info): Update.
6169         * target-delegates.c: Rebuild.
6170         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6171         return type.
6172         (sol_thread_target::pid_to_str): Change return type.
6173         * remote.c (class remote_target) <pid_to_str>: Change return
6174         type.
6175         (remote_target::pid_to_str): Change return type.
6176         (extended_remote_target::attach, remote_target::remote_stop_ns)
6177         (remote_target::remote_notif_remove_queued_reply)
6178         (remote_target::push_stop_reply, remote_target::disable_btrace):
6179         Update.
6180         (extended_remote_target::attach): Update.
6181         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6182         type.
6183         (gdbsim_target::pid_to_str): Change return type.
6184         * ravenscar-thread.c (struct ravenscar_thread_target)
6185         <pid_to_str>: Change return type.
6186         (ravenscar_thread_target::pid_to_str): Change return type.
6187         * procfs.c (class procfs_target) <pid_to_str>: Change return
6188         type.
6189         (procfs_target::pid_to_str): Change return type.
6190         (procfs_target::attach): Update.
6191         (procfs_target::detach): Update.
6192         (procfs_target::fetch_registers): Update.
6193         (procfs_target::store_registers): Update.
6194         (procfs_target::wait): Update.
6195         (procfs_target::files_info): Update.
6196         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6197         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6198         return type.
6199         (nto_procfs_target::pid_to_str): Change return type.
6200         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6201         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6202         return type.
6203         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6204         (exit_lwp): Update.
6205         (attach_proc_task_lwp_callback, get_detach_signal)
6206         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6207         (linux_nat_target::resume, wait_lwp, stop_callback)
6208         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6209         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6210         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6211         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6212         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6213         type.
6214         (inf_ptrace_target::attach): Update.
6215         (inf_ptrace_target::files_info): Update.
6216         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6217         type.
6218         (go32_nat_target::pid_to_str): Change return type.
6219         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6220         (gnu_nat_target::wait): Update.
6221         (gnu_nat_target::wait): Update.
6222         (gnu_nat_target::resume): Update.
6223         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6224         (fbsd_nat_target::wait): Update.
6225         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6226         type.
6227         (darwin_nat_target::attach): Update.
6228         * corelow.c (class core_target) <pid_to_str>: Change return type.
6229         (core_target::pid_to_str): Change return type.
6230         * target.c (normal_pid_to_str): Change return type.
6231         (default_pid_to_str): Likewise.
6232         (target_pid_to_str): Change return type.
6233         (target_translate_tls_address): Update.
6234         (target_announce_detach): Update.
6235         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6236         return type.
6237         (bsd_uthread_target::pid_to_str): Change return type.
6238         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6239         type.
6240         (bsd_kvm_target::pid_to_str): Change return type.
6241         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6242         return type.
6243         (aix_thread_target::pid_to_str): Change return type.
6244         * target.h (struct target_ops) <pid_to_str>: Change return type.
6245         (target_pid_to_str, normal_pid_to_str): Likewise.
6246         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6247         type.
6248         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6249         type.
6250         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6251         return type.
6252         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6253         type.
6254         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6255         type.
6256         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6257         return type.
6258
6259 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6260
6261         * NEWS: Mention that the new default MI version is 3.  Mention
6262         changes to the output of commands and events that deal with
6263         multi-location breakpoints.
6264         * breakpoint.c: Include "mi/mi-out.h".
6265         (print_one_breakpoint): Change output syntax if using MI version
6266         >= 3.
6267         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6268         New.
6269         (mi_multi_location_breakpoint_output_fixed): New.
6270         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6271         (mi_cmd_fix_multi_location_breakpoint_output): New.
6272         (mi_multi_location_breakpoint_output_fixed): New.
6273         * mi/mi-cmds.c (mi_cmds): Register command
6274         -fix-multi-location-breakpoint-output.
6275         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6276         interpreter "mi".
6277
6278 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6279
6280         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6281         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6282         instantiate mi_ui_out based on interpreter name.
6283         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6284         * mi/mi-main.c (mi_load_progress): Likewise.
6285
6286 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6287
6288         * NEWS: Combine separate "New targets" sections for 8.3.
6289
6290 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6291
6292         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6293         (ppcfbsd_init_abi): Install gdbarch
6294         "fetch_tls_load_module_address" and "get_thread_local_address"
6295         methods.
6296
6297 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6298
6299         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6300         (riscv_fbsd_init_abi): Install gdbarch
6301         "fetch_tls_load_module_address" and "get_thread_local_address"
6302         methods.
6303
6304 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6305
6306         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6307         (i386fbsd_init_abi): Install gdbarch
6308         "fetch_tls_load_module_address" and "get_thread_local_address"
6309         methods.
6310
6311 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6312
6313         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6314         (amd64fbsd_init_abi): Install gdbarch
6315         "fetch_tls_load_module_address" and "get_thread_local_address"
6316         methods.
6317
6318 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6319
6320         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6321         (struct fbsd_pspace_data): New type.
6322         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6323         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6324         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6325         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6326         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6327
6328 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6329
6330         * gdbtypes.c (lookup_struct_elt): New function.
6331         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6332         * gdbtypes.h (struct struct_elt): New type.
6333         (lookup_struct_elt): New prototype.
6334
6335 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6336
6337         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6338         remove disabled code block.
6339
6340 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6341
6342         * gdbarch.sh (get_thread_local_address): New method.
6343         * gdbarch.h, gdbarch.c: Regenerate.
6344         * target.c (target_translate_tls_address): Use
6345         gdbarch_get_thread_local_address if present instead of
6346         target::get_thread_local_address.
6347
6348 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6349
6350         * target.h (target::get_thread_local_address): Update comment.
6351
6352 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6353
6354         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6355         objfile->separate_debug_objfile_backlink if not NULL.
6356
6357 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6358
6359         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6360         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6361         (amd64bsd_store_inferior_registers): Likewise.
6362         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6363         Enable segment base registers.
6364         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6365         PT_GETFSBASE and PT_GETGSBASE.
6366         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6367         PT_SETGSBASE.
6368         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6369         segment base registers.
6370         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6371
6372 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6373
6374         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6375         Update calls to i386_target_description to add 'segments'
6376         parameter.
6377         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6378         add segment base registers.
6379         * arch/i386.c (i386_create_target_description): Add 'segments'
6380         parameter to enable segment base registers.
6381         * arch/i386.h (i386_create_target_description): Likewise.
6382         * features/i386/32bit-segments.xml: New file.
6383         * features/i386/32bit-segments.c: Generate.
6384         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6385         call to i386_target_description to add 'segments' parameter.
6386         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6387         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6388         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6389         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6390         if feature is present.
6391         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6392         Add 'segments' parameter to call to i386_target_description.
6393         (i386_target_description): Add 'segments' parameter to enable
6394         segment base registers.
6395         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6396         to call to i386_target_description.
6397         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6398         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6399         Define I386_NUM_REGS.
6400         (i386_target_description): Add 'segments' parameter to enable
6401         segment base registers.
6402
6403 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6404
6405         PR/24325
6406         * source-cache.c: #undef open and close, to avoid unresolved
6407         externals during linking.
6408
6409 2019-03-12  Tom Tromey  <tromey@adacore.com>
6410
6411         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6412         const.  Add initializers.
6413         (_initialize_remote): Don't initialize ptid globals.
6414
6415 2019-03-12  Pedro Alves  <palves@redhat.com>
6416
6417         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6418
6419 2019-03-12  Pedro Alves  <palves@redhat.com>
6420
6421         * cp-name-parser.y (main): Remove unused 'len' variable.
6422
6423 2019-03-12  Tom Tromey  <tromey@adacore.com>
6424
6425         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6426         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6427
6428 2019-03-12  Tom Tromey  <tromey@adacore.com>
6429
6430         * linux-nat.c (iterate_over_lwps): Update.
6431         (stop_callback): Remove parameter.
6432         (stop_wait_callback, detach_callback, resume_set_callback)
6433         (select_singlestep_lwp_callback, set_ignore_sigint)
6434         (status_callback, resumed_callback, resume_clear_callback)
6435         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6436         data parameter.
6437         (linux_nat_target::detach, linux_nat_target::resume)
6438         (linux_stop_and_wait_all_lwps, select_event_lwp)
6439         (linux_nat_filter_event, linux_nat_wait_1)
6440         (linux_nat_target::kill, linux_nat_target::stop)
6441         (linux_nat_target::stop): Update.
6442         (linux_nat_resume_callback): Change type.
6443         (resume_stopped_resumed_lwps, count_events_callback)
6444         (select_event_lwp_callback): Likewise.
6445         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6446         * arm-linux-nat.c (struct update_registers_data): Remove.
6447         (update_registers_callback): Change type.
6448         (arm_linux_insert_hw_breakpoint1): Update.
6449         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6450         parameter.
6451         (x86_linux_dr_set_addr): Update.
6452         (x86_linux_dr_set_control): Update.
6453         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6454         (iterate_over_lwps): Use gdb::function_view.
6455         * nat/aarch64-linux-hw-point.c (struct
6456         aarch64_dr_update_callback_param): Remove.
6457         (debug_reg_change_callback): Change type.
6458         (aarch64_notify_debug_reg_change): Update.
6459         * s390-linux-nat.c (s390_refresh_per_info): Update.
6460
6461 2019-03-11  Tom Tromey  <tromey@adacore.com>
6462
6463         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6464         redundant assignment to "this_cu".
6465
6466 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6467
6468         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6469
6470 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6471
6472         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6473         from...
6474         (rank_one_type): ... this.
6475
6476 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6477
6478         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6479         from...
6480         (rank_one_type): ... this.
6481
6482 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6483
6484         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6485         from...
6486         (rank_one_type): ... this.
6487
6488 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6489
6490         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6491         from...
6492         (rank_one_type): ... this.
6493
6494 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6495
6496         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6497         from...
6498         (rank_one_type): ... this.
6499
6500 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6501
6502         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6503         from...
6504         (rank_one_type): ... this.
6505
6506 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6507
6508         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6509         from...
6510         (rank_one_type): ... this.
6511
6512 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6513
6514         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6515         from...
6516         (rank_one_type): ... this.
6517
6518 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6519
6520         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6521         from...
6522         (rank_one_type): ... this.
6523
6524 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6525
6526         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6527         from...
6528         (rank_one_type): ... this.
6529
6530 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6531
6532         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6533         from...
6534         (rank_one_type): ... this.
6535
6536 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6537
6538         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6539         from...
6540         (rank_one_type): ... this.
6541
6542 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6543
6544         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6545         inferior-events' shows the example events.
6546
6547 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6548
6549         Support styling on native MS-Windows console
6550
6551         PR/24315
6552         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6553         on MS-Windows if $TERM is not defined.
6554
6555         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6556
6557         * posix-hdep.c (gdb_console_fputs):
6558         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6559         functions.
6560         * ui-file.h (gdb_console_fputs): Add prototype.
6561
6562         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6563         back to fputs only if the former returns zero.
6564
6565 2019-03-07  Tom Tromey  <tom@tromey.com>
6566
6567         * symmisc.c (print_symbol_bcache_statistics): Update.
6568         (print_objfile_statistics): Update.
6569         * symfile.c (allocate_symtab): Update.
6570         * stabsread.c: Don't include bcache.h.
6571         * psymtab.h (struct psymbol_bcache): Don't declare.
6572         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6573         (psymbol_bcache_init, psymbol_bcache_free)
6574         (psymbol_bcache_get_bcache): Don't declare.
6575         * psymtab.c (struct psymbol_bcache): Remove.
6576         (psymtab_storage::psymtab_storage): Update.
6577         (psymtab_storage::~psymtab_storage): Update.
6578         (psymbol_bcache_init, psymbol_bcache_free)
6579         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6580         (add_psymbol_to_bcache): Update.
6581         (allocate_psymtab): Update.
6582         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6583         macro_cache>: No longer pointers.
6584         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6585         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6586         * macrotab.c (macro_bcache): Update.
6587         * macroexp.c: Don't include bcache.h.
6588         * gdbtypes.c (check_types_worklist): Update.
6589         (types_deeply_equal): Remove TRY/CATCH.  Update.
6590         * elfread.c (elf_symtab_read): Update.
6591         * dwarf2read.c: Don't include bcache.h.
6592         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6593         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6594         (print_bcache_statistics, bcache_memory_used): Don't declare.
6595         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6596         methods.  Rename all data members.
6597         * bcache.c (struct bcache): Move to bcache.h.
6598         (bcache::expand_hash_table): Rename from expand_hash_table.
6599         (bcache): Remove.
6600         (bcache::insert): Rename from bcache_full.
6601         (bcache::compare): Rename from bcache_compare.
6602         (bcache_xmalloc): Remove.
6603         (bcache::~bcache): Rename from bcache_xfree.
6604         (bcache::print_statistics): Rename from print_bcache_statistics.
6605         (bcache::memory_used): Rename from bcache_memory_used.
6606
6607 2019-03-07  Pedro Alves  <palves@redhat.com>
6608
6609         * infrun.c (normal_stop): Also check for
6610         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6611
6612 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6613
6614         * f-lang.c (value_from_host_double): Moved to...
6615         * value.c (value_from_host_double): ...here.
6616         * value.h (value_from_host_double): Declare.
6617         * guile/scm-math.c (vlscm_convert_typed_number): Use
6618         value_from_host_double.
6619         (vlscm_convert_number): Likewise.
6620         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6621         * python/py-value.c (convert_value_from_python): Likewise.
6622
6623 2019-03-06  Tom Tromey  <tom@tromey.com>
6624
6625         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6626
6627 2019-03-06  Tom Tromey  <tom@tromey.com>
6628
6629         * utils.h (free_current_contents): Don't declare.
6630         * utils.c (free_current_contents): Remove.
6631
6632 2019-03-06  Tom Tromey  <tom@tromey.com>
6633
6634         * top.c (quit_force): Update.
6635         * main.c (captured_command_loop): Update.
6636         * common/new-op.c (operator new): Update.
6637         * common/common-exceptions.c (struct catcher)
6638         <save_cleanup_chain>: Remove member.
6639         (exceptions_state_mc_init): Update.
6640         (exception_try_scope_entry): Return nullptr.
6641         (exception_try_scope_exit, exception_rethrow)
6642         (throw_exception_sjlj, throw_exception_cxx): Update.
6643         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6644         (all_cleanups, do_cleanups, discard_cleanups)
6645         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6646         (restore_cleanups, restore_final_cleanups): Don't declare.
6647         (do_final_cleanups): Remove parameter.
6648         * common/cleanups.c (cleanup_chain, make_cleanup)
6649         (make_cleanup_dtor, all_cleanups, do_cleanups)
6650         (discard_my_cleanups, discard_cleanups)
6651         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6652         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6653         (null_cleanup): Remove.
6654         (do_final_cleanups): Remove parameter.
6655
6656 2019-03-06  Tom Tromey  <tom@tromey.com>
6657
6658         * remote.c (remote_target::remote_parse_stop_reply): Use
6659         unique_xmalloc_ptr.
6660
6661 2019-03-06  Tom Tromey  <tom@tromey.com>
6662
6663         * stabsread.c (struct stabs_field_info): Rename from field_info.
6664         <list, fnlist>: Add initializers.
6665         <obstack>: New member.
6666         (read_member_functions, read_struct_fields, read_baseclasses):
6667         Allocate on obstack.  Don't use cleanups.
6668         (read_one_struct_field, read_member_functions, read_struct_fields)
6669         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6670         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6671         (read_struct_type): Update.
6672
6673 2019-03-06  Tom Tromey  <tom@tromey.com>
6674
6675         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6676         * common/filestuff.h (make_cleanup_close): Don't declare.
6677         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6678         Remove.
6679
6680 2019-03-06  Tom Tromey  <tom@tromey.com>
6681
6682         * solib-aix.c: Use make_scope_exit.
6683
6684 2019-03-06  Tom Tromey  <tom@tromey.com>
6685
6686         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6687         Use make_scope_exit.
6688
6689 2019-03-06  Tom Tromey  <tom@tromey.com>
6690
6691         * solib-svr4.c (disable_probes_interface): Remove parameter.
6692         (svr4_handle_solib_event): Use make_scope_exit.
6693
6694 2019-03-06  Tom Tromey  <tom@tromey.com>
6695
6696         * remote.c (struct stop_reply_deleter): Remove.
6697         (stop_reply_up): Update.
6698         (struct stop_reply): Derive from notif_event.  Don't typedef.
6699         <regcache>: Now a std::vector.
6700         (stop_reply_xfree): Remove.
6701         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6702         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6703         (remote_target::discard_pending_stop_replies): Use delete.
6704         (remote_target::remote_parse_stop_reply): Update.
6705         (remote_target::process_stop_reply): Update.
6706         * remote-notif.h (struct notif_event): Add virtual destructor.
6707         Remove "dtr" member.
6708         (struct notif_client) <alloc_event>: Return a unique_ptr.
6709         (notif_event_xfree): Don't declare.
6710         (notif_event_up): New typedef.
6711         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6712         (notif_event_xfree, do_notif_event_xfree): Remove.
6713         (remote_notif_state_xfree): Update.
6714
6715 2019-03-06  Tom Tromey  <tom@tromey.com>
6716
6717         * infrun.c (displaced_step_clear_cleanup): Now a
6718         forward_scope_exit type.
6719         (displaced_step_prepare_throw): Update.
6720         (displaced_step_fixup): Update.
6721
6722 2019-03-06  Tom Tromey  <tom@tromey.com>
6723
6724         * inferior.h (class inferior): Update comment.
6725         * gdbthread.h (class thread_info): Update comment.
6726
6727 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6728             Tom Tromey  <tom@tromey.com>
6729
6730         * stabsread.h (struct stab_section_list): Remove.
6731         (coffstab_build_psymtabs): Update.
6732         * dbxread.c (symbuf_sections): Now a std::vector.
6733         (sect_idx): New global.
6734         (fill_symbuf): Update.
6735         (coffstab_build_psymtabs): Change type of stabsects parameter.
6736         Update.
6737         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6738         std::vector.
6739         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6740         (coff_locate_sections): Update.
6741         (coff_symfile_read): Remove cleanups.  Update.
6742         (init_stringtab): Add storage parameter.
6743         (free_stringtab, free_stringtab_cleanup): Remove.
6744         (init_lineno): Add storage parameter.
6745         (free_linetab, free_linetab_cleanup): Remove.
6746
6747 2019-03-06  Pedro Alves  <palves@redhat.com>
6748
6749         * linux-fork.c (fork_info::clobber_regs): Delete.
6750         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6751         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6752         comment.  Adjust.
6753         (scoped_switch_fork_info::scoped_switch_fork_info)
6754         (checkpoint_command, linux_fork_context): Adjust
6755         fork_save_infrun_state calls.
6756
6757 2019-03-06  Pedro Alves  <palves@redhat.com>
6758
6759         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6760         (inf_has_multiple_threads): Return 'bool' and rewrite using
6761         inferior_info::threads().
6762
6763 2019-03-06  Pedro Alves  <palves@redhat.com>
6764
6765         * linux-fork.c: Include <list>.
6766         (fork_list): Now a std::list instance.
6767         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6768         (forks_exist_p, find_last_fork): Adjust.
6769         (new_fork): Delete.
6770         (one_fork_p): New.
6771         (add_fork): Adjust.
6772         (free_fork): Delete, folded into fork_info::~fork_info().
6773         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6774         Adjust.
6775         (init_fork_list): Delete.
6776         (linux_fork_killall, linux_fork_mourn_inferior)
6777         (linux_fork_detach, info_checkpoints_command): Adjust.
6778         (_initialize_linux_fork): No longer call init_fork_list.
6779
6780 2019-03-06  Pedro Alves  <palves@redhat.com>
6781
6782         * linux-fork.c (new_fork): New, split out of ...
6783         (add_fork): ... this.  Return void.  Move "first fork" special
6784         case from here, to ...
6785         (checkpoint_command): ... here.
6786         * linux-linux.h (add_fork): Return void.
6787
6788 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6789
6790         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6791
6792 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6793             Chris January  <chris.january@arm.com>
6794             David Lecomber  <david.lecomber@arm.com>
6795
6796         * f-exp.y: New token, UNOP_INTRINSIC.
6797         (exp): New pattern using UNOP_INTRINSIC token.
6798         (f77_keywords): Add 'abs' keyword.
6799         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6800         (value_from_host_double): New function.
6801         (evaluate_subexp_f): Support UNOP_ABS.
6802
6803 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6804
6805         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6806         types.
6807
6808 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6809
6810         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6811         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6812         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6813
6814 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6815
6816         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6817
6818 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6819             Chris January  <chris.january@arm.com>
6820
6821         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6822         * f-exp.y: Define 'KIND' token.
6823         (exp): New pattern for KIND expressions.
6824         (ptype): Handle types with a kind extension.
6825         (direct_abs_decl): Extend to spot kind extensions.
6826         (f77_keywords): Add 'kind' to the list.
6827         (push_kind_type): New function.
6828         (convert_to_kind_type): New function.
6829         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6830         * parse.c (operator_length_standard): Likewise.
6831         * parser-defs.h (enum type_pieces): Add tp_kind.
6832         * std-operator.def: Add UNOP_KIND.
6833
6834 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6835
6836         * f-exp.y (f_parse): Set yydebug.
6837
6838 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6839
6840         * f-lang.c (evaluate_subexp_f): New function.
6841         (exp_descriptor_f): New global.
6842         (f_language_defn): Use exp_descriptor_f instead of
6843         exp_descriptor_standard.
6844
6845 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6846
6847         * f-exp.y (struct token): Add comments.
6848         (dot_ops): Remove uppercase versions and the end marker.
6849         (f77_keywords): Likewise.
6850         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6851         entries in the dot_ops array are case insensitive, and use
6852         strncasecmp to compare strings.  Also some whitespace cleanup in
6853         this area.  Similar for the f77_keywords array, except entries in
6854         this list might be case sensitive.
6855
6856 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6857
6858         * f-exp.y (struct f77_boolean_val): Add comments.
6859         (boolean_values): Remove uppercase versions, and end marker.
6860         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6861         and use strncasecmp to achieve case insensitivity.  Additionally,
6862         perform whitespace cleanup around this code.
6863
6864 2019-03-06  Tom Tromey  <tromey@adacore.com>
6865
6866         * remote-sim.c (gdbsim_target_open): Use result of
6867         gdb_argv::release.
6868
6869 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6870         Dirk Schubert  <dirk.schubert@arm.com>
6871         Chris January  <chris.january@arm.com>
6872
6873         * eval.c (evaluate_subexp_standard): Call Fortran argument
6874         wrapping logic.
6875         * f-lang.c (struct value): A value which can be passed into a
6876         Fortran function call.
6877         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6878         where appropriate.
6879         (struct type): Value ready for a Fortran function call.
6880         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6881         is needed.
6882         * f-lang.h (fortran_argument_convert): Declaration.
6883         (fortran_preserve_arg_pointer): Declaration.
6884         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6885
6886 2019-03-05  Tom Tromey  <tromey@adacore.com>
6887
6888         * python/py-prettyprint.c (print_string_repr): Remove #if.
6889         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6890
6891 2019-03-05  Tom Tromey  <tromey@adacore.com>
6892
6893         * target.c (the_dummy_target): Move later.  Change type to
6894         "dummy_target".
6895         (initialize_targets): Don't initialize the_dummy_target.
6896
6897 2019-03-05  Tom Tromey  <tromey@adacore.com>
6898
6899         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6900         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6901
6902 2019-03-05  Tom Tromey  <tromey@adacore.com>
6903
6904         * windows-nat.c (windows_nat_target::attach)
6905         (windows_nat_target::detach): Don't call gdb_flush.
6906         * valprint.c (generic_val_print, val_print, val_print_string):
6907         Don't call gdb_flush.
6908         * utils.c (defaulted_query): Don't call gdb_flush.
6909         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6910         * target.c (target_announce_detach): Don't call gdb_flush.
6911         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6912         * remote.c (extended_remote_target::attach): Don't call
6913         gdb_flush.
6914         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6915         * printcmd.c (do_examine): Don't call gdb_flush.
6916         (info_display_command): Don't call gdb_flush.
6917         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6918         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6919         * memattr.c (info_mem_command): Don't call gdb_flush.
6920         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6921         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6922         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6923         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6924         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6925         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6926         (gnu_nat_target::detach): Don't call gdb_flush.
6927         * f-valprint.c (f_val_print): Don't call gdb_flush.
6928         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6929         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6930         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6931         gdb_flush.
6932         * c-valprint.c (c_val_print): Don't call gdb_flush.
6933         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6934
6935 2019-03-05  Tom Tromey  <tromey@adacore.com>
6936
6937         * varobj.c (update_dynamic_varobj_children): Update.
6938         (install_default_visualizer): Use reset, not release.
6939         * value.c (set_internalvar): Update.
6940         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6941         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6942         ATTRIBUTE_UNUSED_RESULT.
6943
6944 2019-03-05  Tom Tromey  <tromey@adacore.com>
6945
6946         * remote.c (class scoped_remote_fd) <release>: Add
6947         ATTRIBUTE_UNUSED_RESULT.
6948
6949 2019-03-05  Tom Tromey  <tromey@adacore.com>
6950
6951         * macroexp.c (struct macro_buffer) <release>: Add
6952         ATTRIBUTE_UNUSED_RESULT.
6953
6954 2019-03-05  Tom Tromey  <tromey@adacore.com>
6955
6956         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6957         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6958         ATTRIBUTE_UNUSED_RESULT.
6959
6960 2019-03-05  Tom Tromey  <tromey@adacore.com>
6961
6962         * common/scoped_fd.h (class scoped_fd) <release>: Add
6963         ATTRIBUTE_UNUSED_RESULT.
6964
6965 2019-03-05  Tom Tromey  <tromey@adacore.com>
6966
6967         * parser-defs.h (struct parser_state) <release>: Add
6968         ATTRIBUTE_UNUSED_RESULT.
6969
6970 2019-03-05  Tom Tromey  <tromey@adacore.com>
6971
6972         * utils.h (class gdb_argv) <release>: Add
6973         ATTRIBUTE_UNUSED_RESULT.
6974         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6975
6976 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6977
6978         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6979         for-loop range, to avoid compiler warnings.
6980
6981         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6982         avoid compiler warnings about unused variables.
6983
6984         * NEWS: Mention end of support for native debugging on MS-Windows
6985         before XP.
6986
6987         PR gdb/24292
6988         * common/netstuff.c:
6989         * gdbserver/gdbreplay.c
6990         * gdbserver/remote-utils.c:
6991         * ser-tcp.c:
6992         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6993         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6994         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6995         'getaddrinfo' and 'freeaddrinfo' were not available before
6996         Windows XP, and mingw.org's MinGW headers by default define
6997         _WIN32_WINNT to 0x500.
6998
6999 2019-03-01  Gary Benson <gbenson@redhat.com>
7000
7001         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7002
7003 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7004             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7005
7006         PR gdb/8527
7007         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7008         set_sigint_trap, clear_sigint_trap.
7009
7010 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7011
7012         * target.c (target_detach): Clear the regcache and the
7013         frame cache.
7014
7015 2019-02-27  Pedro Alves  <palves@redhat.com>
7016
7017         * utils.c (set_screen_size): When we cap the height/width sizes,
7018         tweak the corresponding command variable to show "unlimited":
7019
7020 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7021             Pedro Alves  <palves@redhat.com>
7022
7023         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7024         before calling rl_set_screen_size.
7025
7026 2019-02-27  Tom Tromey  <tromey@adacore.com>
7027
7028         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7029         define.
7030         * python/py-value.c: Remove Python 2.4 workaround.
7031         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7032         workaround.
7033         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7034         Python 2.4 workaround.
7035         * python/python-internal.h: Remove Python 2.4 comment.
7036         (Py_ssize_t): Don't define.
7037         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7038         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7039         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7040         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7041         * python/python.c (do_start_initialization): Remove Python 2.4
7042         workaround.
7043         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7044         (print_children): Remove Python 2.4 workaround.
7045         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7046         workaround.
7047         (CHARBUFFERPROC_NAME): Remove.
7048         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7049         Python 2.4 workaround.
7050
7051 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7052
7053         * NEWS: Note minimum Python version.
7054
7055 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7056
7057         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7058         code from these functions.  Remove corresponding ifdefs.  Use
7059         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7060         Remove gotos and target of gotos.
7061         (infpy_search_memory): Likewise.
7062
7063 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7064
7065         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7066         (hppa_gdbarch_init): Don't register deleted functions with
7067         gdbarch.
7068
7069 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7070
7071         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7072         (h8300_unwind_sp): Delete.
7073         (h8300_dummy_id): Delete.
7074         (h8300_gdbarch_init): Don't register deleted functions with
7075         gdbarch.
7076
7077 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7078
7079         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7080         (ft32_unwind_pc): Delete.
7081         (ft32_unwind_sp): Delete.
7082         (ft32_gdbarch_init): Don't register deleted functions with
7083         gdbarch.
7084
7085 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7086
7087         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7088         (frv_unwind_pc): Delete.
7089         (frv_unwind_sp): Delete.
7090         (frv_gdbarch_init): Don't register deleted functions with
7091         gdbarch.
7092
7093 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7094
7095         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7096         (riscv_unwind_pc): Delete.
7097         (riscv_unwind_sp): Delete.
7098         (riscv_gdbarch_init): Don't register deleted functions with
7099         gdbarch.
7100
7101 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7102
7103         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7104         (csky_unwind_pc): Delete.
7105         (csky_unwind_sp): Delete.
7106         (csky_gdbarch_init): Don't register deleted functions with
7107         gdbarch.
7108
7109 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7110
7111         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7112         (cris_unwind_pc): Delete.
7113         (cris_unwind_sp): Delete.
7114         (cris_gdbarch_init): Don't register deleted functions with
7115         gdbarch.
7116
7117 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7118
7119         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7120         (bfin_unwind_pc): Delete.
7121         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7122
7123 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7124
7125         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7126         (arm_unwind_pc): Delete.
7127         (arm_unwind_sp): Delete.
7128         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7129
7130 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7131
7132         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7133         (arc_unwind_pc): Delete.
7134         (arc_unwind_sp): Delete.
7135         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7136
7137 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7138
7139         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7140         (alpha_unwind_pc): Delete.
7141         (alpha_gdbarch_init): Don't register deleted functions with
7142         gdbarch.
7143
7144 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7145
7146         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7147         (aarch64_unwind_pc): Delete.
7148         (aarch64_unwind_sp): Delete.
7149         (aarch64_gdbarch_init): Don't register deleted functions with
7150         gdbarch.
7151
7152 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7153
7154         * gdbtypes.c (type_align): Don't consider static members when
7155         computing structure alignment.
7156
7157 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7158
7159         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7160         return 0 for other types.
7161         * arch-utils.c (default_type_align): Always return 0.
7162         * gdbarch.h: Regenerate.
7163         * gdbarch.sh (type_align): Extend comment.
7164         * gdbtypes.c (type_align): Add additional comments, always call
7165         gdbarch_type_align before applying the default rules.
7166         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7167         generic code will then apply a suitable default.
7168         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7169         types, return 0 for other types.
7170
7171 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7172
7173         * NEWS: Create a new section for the next release branch.
7174         Rename the section of the current branch, now that it has
7175         been cut.
7176
7177 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7178
7179         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7180         * version.in: Bump version to 8.3.50.DATE-git.
7181
7182 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7183
7184         * aix-thread.c (ptid_cmp): Remove unused variable.
7185         (get_signaled_thread): Likewise.
7186         (store_regs_user_thread): Likewise.
7187         (store_regs_kernel_thread): Likewise.
7188         (fetch_regs_kernel_thread): Remove shadowed variable.
7189
7190 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7191
7192         * features/riscv/32bit-cpu.xml: Add register numbers.
7193         * features/riscv/32bit-fpu.c: Regenerate.
7194         * features/riscv/32bit-fpu.xml: Add register numbers.
7195         * features/riscv/64bit-cpu.xml: Add register numbers.
7196         * features/riscv/64bit-fpu.c: Regenerate.
7197         * features/riscv/64bit-fpu.xml: Add register numbers.
7198
7199 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7200
7201         * NEWS: Mention two argument form of gdb.Value constructor.
7202         * python/py-value.c (convert_buffer_and_type_to_value): New
7203         function.
7204         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7205         Add support for handling an optional second argument.  Call
7206         convert_buffer_and_type_to_value as appropriate.
7207         * python/python-internal.h (Py_buffer_deleter): New struct.
7208         (Py_buffer_up): New typedef.
7209
7210 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7211
7212         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7213         instead of releasing ownership.
7214
7215 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7216
7217         * dwarf2read.c (open_and_init_dwp_file): Call
7218         elf_numsections instead of bfd_count_sections to initialize
7219         dwp_file->num_sections.
7220
7221 2019-02-25  Tom Tromey  <tromey@adacore.com>
7222
7223         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7224
7225 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7226
7227         * gcore.in: Add '--readnever' option when invoking GDB.
7228
7229 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7230
7231         * MAINTAINERS: Update my email address.
7232
7233 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7234
7235         * build-id.c (build_id_to_debug_bfd_1): New function.
7236         (build_id_to_debug_bfd): Look for separate debug file in
7237         sysroot.
7238
7239 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7240
7241         * gdbarch.sh: Update the copyright year range that is placed into
7242         generated files.
7243
7244 2019-02-22  Keith Seitz  <keiths@redhat.com>
7245
7246         PR symtab/23853
7247         * linespec.c (create_sals_line_offset): Search for the default
7248         symtab's filename instead of its fullname.
7249
7250 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7251
7252         * NEWS: Update style defaults.
7253
7254 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7255
7256         * main.c (captured_main_1): Disable styling in batch mode.
7257
7258 2019-02-20  Tom Tromey  <tom@tromey.com>
7259
7260         * symtab.c (symtab_symbol_info): Fix typos.
7261
7262 2019-02-20  Tom Tromey  <tromey@adacore.com>
7263
7264         * findcmd.c (_initialize_mem_search): Use upper case for
7265         metasyntactic variables.
7266
7267 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7268
7269         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7270         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7271
7272 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7273
7274         * top.h (source_file_name): Change to std::string.
7275         * top.c (source_file_name): Likewise.
7276         (command_line_input): Adjust.
7277         * cli/cli-script.c (script_from_file): Adjust.
7278
7279 2019-02-19  Tom Tromey  <tromey@adacore.com>
7280
7281         * ravenscar-thread.c
7282         (ravenscar_thread_target::update_thread_list): Don't call
7283         ada_build_task_list.
7284         * ada-lang.h (ada_build_task_list): Don't declare.
7285         * ada-tasks.c (struct ada_tasks_inferior_data)
7286         <task_list_valid_p>: Now bool.
7287         (read_known_tasks, ada_task_list_changed)
7288         (ada_tasks_invalidate_inferior_data): Update.
7289         (read_known_tasks_array): Return bool.
7290         (read_known_tasks_list): Likewise.
7291         (read_known_tasks): Return void.
7292         (ada_build_task_list): Now static.
7293
7294 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7295
7296         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7297         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7298
7299 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7300
7301         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7302         variant for ada_tasks_pspace_data_handle and
7303         ada_tasks_inferior_data_handle.
7304         (ada_tasks_pspace_data_cleanup): New function.
7305         (ada_tasks_inferior_data_cleanup): New function.
7306
7307 2019-02-17  Tom Tromey  <tom@tromey.com>
7308
7309         * macrotab.h (macro_source_fullname): Return a std::string.
7310         * macrotab.c (macro_include, check_for_redefinition)
7311         (macro_undef, macro_lookup_definition, foreach_macro)
7312         (foreach_macro_in_scope): Update.
7313         (macro_source_fullname): Return a std::string.
7314         * macrocmd.c (show_pp_source_pos): Update.
7315
7316 2019-02-17  Tom Tromey  <tom@tromey.com>
7317
7318         * macrocmd.c (show_pp_source_pos): Style the file names.
7319
7320 2019-02-17  Tom Tromey  <tom@tromey.com>
7321
7322         PR tui/24197:
7323         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7324
7325 2019-02-17  Tom Tromey  <tom@tromey.com>
7326
7327         * ada-lang.c (user_select_syms): Use filtered printing.
7328         * utils.c (wrap_style): New global.
7329         (desired_style): Remove.
7330         (emit_style_escape): Add stream parameter.
7331         (set_output_style, reset_terminal_style, prompt_for_continue):
7332         Update.
7333         (flush_wrap_buffer): Only flush gdb_stdout.
7334         (wrap_here): Set wrap_style.
7335         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7336         treat escape sequences as a character.  Change when wrap buffer is
7337         flushed.
7338         (fputs_styled): Do not set the output style when the default is
7339         requested.
7340         * ui-style.h (struct ui_file_style) <is_default>: New method.
7341         * source.c (print_source_lines_base): Emit escape sequences in one
7342         piece.
7343
7344 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7345
7346         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7347         integers and enumeration types.
7348
7349 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7350
7351         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7352         instead of lookup_symbol_in_language
7353         (do_exact_match): New function.
7354         (ada_get_symbol_name_matcher): Return do_exact_match when
7355         doing a verbatim match.
7356
7357 2019-02-15  Tom Tromey  <tromey@adacore.com>
7358
7359         * ravenscar-thread.c (ravenscar_thread_target::resume)
7360         (ravenscar_thread_target::wait): Special case wildcard requests.
7361
7362 2019-02-15  Tom Tromey  <tromey@adacore.com>
7363
7364         * ravenscar-thread.c (base_ptid): Remove.
7365         (struct ravenscar_thread_target) <close>: New method.
7366         <m_base_ptid>: New member.
7367         <update_inferior_ptid, active_task, task_is_currently_active,
7368         runtime_initialized>: Declare methods.
7369         <ravenscar_thread_target>: Add constructor.
7370         (ravenscar_thread_target::task_is_currently_active)
7371         (ravenscar_thread_target::update_inferior_ptid)
7372         (ravenscar_runtime_initialized): Rename.  Now methods.
7373         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7374         (ravenscar_thread_target::update_thread_list): Update.
7375         (ravenscar_thread_target::active_task): Now method.
7376         (ravenscar_thread_target::store_registers)
7377         (ravenscar_thread_target::prepare_to_store)
7378         (ravenscar_thread_target::prepare_to_store)
7379         (ravenscar_thread_target::mourn_inferior): Update.
7380         (ravenscar_inferior_created): Use "new" to create target.
7381         (ravenscar_thread_target::get_ada_task_ptid): Update.
7382         (_initialize_ravenscar): Don't initialize base_ptid.
7383         (ravenscar_ops): Remove global.
7384
7385 2019-02-15  Tom Tromey  <tromey@adacore.com>
7386
7387         * target.h (push_target): Declare new overload.
7388         * target.c (push_target): New overload, taking an rvalue reference.
7389         * remote.c (remote_target::open_1): Use push_target overload.
7390         * corelow.c (core_target_open): Use push_target overload.
7391
7392 2019-02-15  Tom Tromey  <tromey@adacore.com>
7393
7394         * ravenscar-thread.c (is_ravenscar_task)
7395         (ravenscar_task_is_currently_active): Return bool.
7396         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7397         (_initialize_ravenscar): Remove "(void)".
7398         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7399         Return bool.
7400
7401 2019-02-15  Tom Tromey  <tromey@adacore.com>
7402
7403         * ravenscar-thread.c (ravenscar_runtime_initializer)
7404         (has_ravenscar_runtime, get_running_thread_id)
7405         (ravenscar_thread_target::resume): Fix indentation.
7406
7407 2019-02-15  Tom Tromey  <tromey@adacore.com>
7408
7409         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7410         from ravenscar_arch_ops.
7411         (sparc_ravenscar_ops::fetch_registers)
7412         (sparc_ravenscar_ops::store_registers): Now methods.
7413         (sparc_ravenscar_prepare_to_store): Remove.
7414         (sparc_ravenscar_ops): Redefine.
7415         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7416         methods and destructor.  Remove members.
7417         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7418         (ravenscar_thread_target::store_registers)
7419         (ravenscar_thread_target::prepare_to_store): Update.
7420         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7421         Remove.
7422         (struct ppc_ravenscar_powerpc_ops): Derive from
7423         ravenscar_arch_ops.
7424         (ppc_ravenscar_powerpc_ops::fetch_registers)
7425         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7426         (ppc_ravenscar_powerpc_ops): Redefine.
7427         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7428         (ppc_ravenscar_e500_ops::fetch_registers)
7429         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7430         (ppc_ravenscar_e500_ops): Redefine.
7431         * aarch64-ravenscar-thread.c
7432         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7433         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7434         (aarch64_ravenscar_fetch_registers)
7435         (aarch64_ravenscar_store_registers): Now methods.
7436         (aarch64_ravenscar_ops): Redefine.
7437
7438 2019-02-15  Tom Tromey  <tromey@adacore.com>
7439
7440         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7441         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7442         (ravenscar_thread_target::stopped_by_watchpoint)
7443         (ravenscar_thread_target::stopped_data_address)
7444         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7445
7446 2019-02-15  Tom Tromey  <tromey@adacore.com>
7447
7448         * ravenscar-thread.c: Fix some typos.
7449
7450 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7451             Tom Tromey  <tromey@adacore.com>
7452
7453         * ada-lang.c (ada_exception_sal): Change addr_string to a
7454         std::string.
7455         (create_ada_exception_catchpoint): Update.
7456
7457 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7458             Tom Tromey  <tromey@adacore.com>
7459
7460         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7461         (bp_location_ops): Remove.
7462         (base_breakpoint_allocate_location): Update.
7463         (free_bp_location): Update.
7464         * ada-lang.c (class ada_catchpoint_location)
7465         <ada_catchpoint_location>: Remove ops parameter.
7466         (ada_catchpoint_location_dtor): Remove.
7467         (ada_catchpoint_location_ops): Remove.
7468         (allocate_location_exception): Update.
7469         * breakpoint.h (struct bp_location_ops): Remove.
7470         (class bp_location) <bp_location>: Remove bp_location_ops
7471         parameter.
7472         <~bp_location>: Add destructor.
7473         <ops>: Remove.
7474
7475 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7476             Pedro Alves  <palves@redhat.com>
7477
7478         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7479         'PATH_MAX'.
7480
7481 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7482             Samuel Thibault  <samuel.thibault@gnu.org>
7483             Thomas Schwinge  <thomas@codesourcery.com>
7484
7485         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7486         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7487
7488 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7489
7490         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7491         (check_empty): Use "const char *".
7492
7493         * gnu-nat.c (gnu_nat_target::detach): Instead of
7494         'detach_inferior (pid)' call
7495         'detach_inferior (find_inferior_pid (pid))'.
7496
7497         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7498         'nat/fork-inferior.o'.
7499         * gnu-nat.c: #include "nat/fork-inferior.h".
7500
7501         * gnu-nat.c (gnu_nat_target::detach): Instead of
7502         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7503         * gnu-nat.h: #include "inf-child.h".
7504         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7505         'i386_gnu_nat_target::fetch_registers'.
7506         (gnu_store_registers): Rename/move to
7507         'i386_gnu_nat_target::store_registers'.
7508
7509         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7510         * gnu-nat.h (mach_thread_info): New function.
7511         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7512
7513         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7514
7515 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7516
7517         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7518
7519 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7520
7521         * windows-nat.c (windows_add_thread): Add new parameter
7522         "main_thread_p" with default value set to false.  Update
7523         function documentation as well as all callers.
7524         (windows_delete_thread): Likewise.
7525         (fake_create_process): Update call to windows_add_thread.
7526         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7527         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7528         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7529         call to windows_delete_thread.
7530
7531 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7532
7533         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7534
7535 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7536
7537         * symfile.c (find_separate_debug_file): Use canonical path of
7538         sysroot with child_path instead of gdb_sysroot if it is valid.
7539
7540 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7541
7542         * symfile.c (find_separate_debug_file): Use child_path to
7543         determine if an object file is under a sysroot.
7544
7545 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7546
7547         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7548         unittests/child-path-selftests.c.
7549         * common/pathstuff.c (child_path): New function.
7550         * common/pathstuff.h (child_path): New prototype.
7551         * unittests/child-path-selftests.c: New file.
7552
7553 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7554
7555         * symfile.c (find_separate_debug_file): Look for separate debug
7556         files in debug directories under the sysroot.
7557
7558 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7559
7560         * symtab.h (struct minimal_symbol data_p): New const method.
7561         (struct minimal_symbol text_p): Likewise.
7562         * symtab.c (output_source_filename): Use file name style
7563         to print file name.
7564         (print_symbol_info): Likewise.
7565         (print_msymbol_info): Use address style to print addresses.
7566         Use function name style to print executable text symbols.
7567         (expand_symtab_containing_pc): Use data_p.
7568         (find_pc_sect_compunit_symtab): Likewise.
7569
7570 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7571
7572         * breakpoint.c (describe_other_breakpoints): Use address style
7573         to print addresses.
7574         (say_where): Likewise.
7575
7576 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7577
7578         * ada-typeprint.c (print_func_type): Print function name
7579         style to print function name.
7580         * c-typeprint.c (c_print_type_1): Likewise.
7581
7582 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7583
7584         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7585         for execve.
7586
7587 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7588
7589         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7590         type_stack.
7591
7592 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7593
7594         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7595         TYPE_CODE_REF types.
7596
7597 2019-02-08  Jim Wilson  <jimw@sifive.com>
7598
7599         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7600         (riscv_linux_fregset): New.
7601         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7602
7603 2019-02-07  Tom Tromey  <tom@tromey.com>
7604
7605         * thread.c (thread_cancel_execution_command): Update.
7606         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7607         methods.
7608         (struct thread_fsm_ops): Remove.
7609         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7610         (thread_fsm_should_stop, thread_fsm_return_value)
7611         (thread_fsm_set_finished, thread_fsm_finished_p)
7612         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7613         Don't declare.
7614         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7615         * infrun.c (clear_proceed_status_thread)
7616         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7617         (print_stop_event): Update.
7618         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7619         Add constructor.
7620         (step_command_fsm_ops): Remove.
7621         (new_step_command_fsm): Remove.
7622         (step_1): Update.
7623         (step_command_fsm::should_stop): Rename from
7624         step_command_fsm_should_stop.
7625         (step_command_fsm::clean_up): Rename from
7626         step_command_fsm_clean_up.
7627         (step_command_fsm::do_async_reply_reason): Rename from
7628         step_command_fsm_async_reply_reason.
7629         (struct until_next_fsm): Inherit from thread_fsm.  Add
7630         constructor.
7631         (until_next_fsm_ops): Remove.
7632         (new_until_next_fsm): Remove.
7633         (until_next_fsm::should_stop): Rename from
7634         until_next_fsm_should_stop.
7635         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7636         (until_next_fsm::do_async_reply_reason): Rename from
7637         until_next_fsm_async_reply_reason.
7638         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7639         constructor.  Change type of breakpoint.
7640         (finish_command_fsm_ops): Remove.
7641         (new_finish_command_fsm): Remove.
7642         (finish_command_fsm::should_stop): Rename from
7643         finish_command_fsm_should_stop.
7644         (finish_command_fsm::clean_up): Rename from
7645         finish_command_fsm_clean_up.
7646         (finish_command_fsm::return_value): Rename from
7647         finish_command_fsm_return_value.
7648         (finish_command_fsm::do_async_reply_reason): Rename from
7649         finish_command_fsm_async_reply_reason.
7650         (finish_command): Update.
7651         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7652         Add constructor.
7653         (call_thread_fsm_ops): Remove.
7654         (call_thread_fsm::call_thread_fsm): Rename from
7655         new_call_thread_fsm.
7656         (call_thread_fsm::should_stop): Rename from
7657         call_thread_fsm_should_stop.
7658         (call_thread_fsm::should_notify_stop): Rename from
7659         call_thread_fsm_should_notify_stop.
7660         (run_inferior_call, call_function_by_hand_dummy): Update.
7661         * cli/cli-interp.c (should_print_stop_to_console): Update.
7662         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7663         Add constructor.  Change type of location_breakpoint,
7664         caller_breakpoint.
7665         (until_break_fsm_ops): Remove.
7666         (new_until_break_fsm): Remove.
7667         (until_break_fsm::should_stop): Rename from
7668         until_break_fsm_should_stop.
7669         (until_break_fsm::clean_up): Rename from
7670         until_break_fsm_clean_up.
7671         (until_break_fsm::do_async_reply_reason): Rename from
7672         until_break_fsm_async_reply_reason.
7673         (until_break_command): Update.
7674         * thread-fsm.c: Remove.
7675         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7676
7677 2019-02-07  Tom Tromey  <tom@tromey.com>
7678
7679         * yy-remap.h: Add include guard.
7680         * xtensa-tdep.h: Add include guard.
7681         * xcoffread.h: Rename include guard.
7682         * varobj-iter.h: Add include guard.
7683         * tui/tui.h: Rename include guard.
7684         * tui/tui-winsource.h: Rename include guard.
7685         * tui/tui-wingeneral.h: Rename include guard.
7686         * tui/tui-windata.h: Rename include guard.
7687         * tui/tui-win.h: Rename include guard.
7688         * tui/tui-stack.h: Rename include guard.
7689         * tui/tui-source.h: Rename include guard.
7690         * tui/tui-regs.h: Rename include guard.
7691         * tui/tui-out.h: Rename include guard.
7692         * tui/tui-layout.h: Rename include guard.
7693         * tui/tui-io.h: Rename include guard.
7694         * tui/tui-hooks.h: Rename include guard.
7695         * tui/tui-file.h: Rename include guard.
7696         * tui/tui-disasm.h: Rename include guard.
7697         * tui/tui-data.h: Rename include guard.
7698         * tui/tui-command.h: Rename include guard.
7699         * tic6x-tdep.h: Add include guard.
7700         * target/waitstatus.h: Rename include guard.
7701         * target/wait.h: Rename include guard.
7702         * target/target.h: Rename include guard.
7703         * target/resume.h: Rename include guard.
7704         * target-float.h: Rename include guard.
7705         * stabsread.h: Add include guard.
7706         * rs6000-tdep.h: Add include guard.
7707         * riscv-fbsd-tdep.h: Add include guard.
7708         * regformats/regdef.h: Rename include guard.
7709         * record.h: Rename include guard.
7710         * python/python.h: Rename include guard.
7711         * python/python-internal.h: Rename include guard.
7712         * python/py-stopevent.h: Rename include guard.
7713         * python/py-ref.h: Rename include guard.
7714         * python/py-record.h: Rename include guard.
7715         * python/py-record-full.h: Rename include guard.
7716         * python/py-record-btrace.h: Rename include guard.
7717         * python/py-instruction.h: Rename include guard.
7718         * python/py-events.h: Rename include guard.
7719         * python/py-event.h: Rename include guard.
7720         * procfs.h: Add include guard.
7721         * proc-utils.h: Add include guard.
7722         * p-lang.h: Add include guard.
7723         * or1k-tdep.h: Rename include guard.
7724         * observable.h: Rename include guard.
7725         * nto-tdep.h: Rename include guard.
7726         * nat/x86-linux.h: Rename include guard.
7727         * nat/x86-linux-dregs.h: Rename include guard.
7728         * nat/x86-gcc-cpuid.h: Add include guard.
7729         * nat/x86-dregs.h: Rename include guard.
7730         * nat/x86-cpuid.h: Rename include guard.
7731         * nat/ppc-linux.h: Rename include guard.
7732         * nat/mips-linux-watch.h: Rename include guard.
7733         * nat/linux-waitpid.h: Rename include guard.
7734         * nat/linux-ptrace.h: Rename include guard.
7735         * nat/linux-procfs.h: Rename include guard.
7736         * nat/linux-osdata.h: Rename include guard.
7737         * nat/linux-nat.h: Rename include guard.
7738         * nat/linux-namespaces.h: Rename include guard.
7739         * nat/linux-btrace.h: Rename include guard.
7740         * nat/glibc_thread_db.h: Rename include guard.
7741         * nat/gdb_thread_db.h: Rename include guard.
7742         * nat/gdb_ptrace.h: Rename include guard.
7743         * nat/fork-inferior.h: Rename include guard.
7744         * nat/amd64-linux-siginfo.h: Rename include guard.
7745         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7746         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7747         * nat/aarch64-linux.h: Rename include guard.
7748         * nat/aarch64-linux-hw-point.h: Rename include guard.
7749         * mn10300-tdep.h: Add include guard.
7750         * mips-linux-tdep.h: Add include guard.
7751         * mi/mi-parse.h: Rename include guard.
7752         * mi/mi-out.h: Rename include guard.
7753         * mi/mi-main.h: Rename include guard.
7754         * mi/mi-interp.h: Rename include guard.
7755         * mi/mi-getopt.h: Rename include guard.
7756         * mi/mi-console.h: Rename include guard.
7757         * mi/mi-common.h: Rename include guard.
7758         * mi/mi-cmds.h: Rename include guard.
7759         * mi/mi-cmd-break.h: Rename include guard.
7760         * m2-lang.h: Add include guard.
7761         * location.h: Rename include guard.
7762         * linux-record.h: Rename include guard.
7763         * linux-nat.h: Add include guard.
7764         * linux-fork.h: Add include guard.
7765         * i386-darwin-tdep.h: Rename include guard.
7766         * hppa-linux-offsets.h: Add include guard.
7767         * guile/guile.h: Rename include guard.
7768         * guile/guile-internal.h: Rename include guard.
7769         * gnu-nat.h: Rename include guard.
7770         * gdb-stabs.h: Rename include guard.
7771         * frv-tdep.h: Add include guard.
7772         * f-lang.h: Add include guard.
7773         * event-loop.h: Add include guard.
7774         * darwin-nat.h: Rename include guard.
7775         * cp-abi.h: Rename include guard.
7776         * config/sparc/nm-sol2.h: Rename include guard.
7777         * config/nm-nto.h: Rename include guard.
7778         * config/nm-linux.h: Add include guard.
7779         * config/i386/nm-i386gnu.h: Rename include guard.
7780         * config/djgpp/nl_types.h: Rename include guard.
7781         * config/djgpp/langinfo.h: Rename include guard.
7782         * compile/gcc-cp-plugin.h: Add include guard.
7783         * compile/gcc-c-plugin.h: Add include guard.
7784         * compile/compile.h: Rename include guard.
7785         * compile/compile-object-run.h: Rename include guard.
7786         * compile/compile-object-load.h: Rename include guard.
7787         * compile/compile-internal.h: Rename include guard.
7788         * compile/compile-cplus.h: Rename include guard.
7789         * compile/compile-c.h: Rename include guard.
7790         * common/xml-utils.h: Rename include guard.
7791         * common/x86-xstate.h: Rename include guard.
7792         * common/version.h: Rename include guard.
7793         * common/vec.h: Rename include guard.
7794         * common/tdesc.h: Rename include guard.
7795         * common/selftest.h: Rename include guard.
7796         * common/scoped_restore.h: Rename include guard.
7797         * common/scoped_mmap.h: Rename include guard.
7798         * common/scoped_fd.h: Rename include guard.
7799         * common/safe-iterator.h: Rename include guard.
7800         * common/run-time-clock.h: Rename include guard.
7801         * common/refcounted-object.h: Rename include guard.
7802         * common/queue.h: Rename include guard.
7803         * common/ptid.h: Rename include guard.
7804         * common/print-utils.h: Rename include guard.
7805         * common/preprocessor.h: Rename include guard.
7806         * common/pathstuff.h: Rename include guard.
7807         * common/observable.h: Rename include guard.
7808         * common/netstuff.h: Rename include guard.
7809         * common/job-control.h: Rename include guard.
7810         * common/host-defs.h: Rename include guard.
7811         * common/gdb_wait.h: Rename include guard.
7812         * common/gdb_vecs.h: Rename include guard.
7813         * common/gdb_unlinker.h: Rename include guard.
7814         * common/gdb_unique_ptr.h: Rename include guard.
7815         * common/gdb_tilde_expand.h: Rename include guard.
7816         * common/gdb_sys_time.h: Rename include guard.
7817         * common/gdb_string_view.h: Rename include guard.
7818         * common/gdb_splay_tree.h: Rename include guard.
7819         * common/gdb_setjmp.h: Rename include guard.
7820         * common/gdb_ref_ptr.h: Rename include guard.
7821         * common/gdb_optional.h: Rename include guard.
7822         * common/gdb_locale.h: Rename include guard.
7823         * common/gdb_assert.h: Rename include guard.
7824         * common/filtered-iterator.h: Rename include guard.
7825         * common/filestuff.h: Rename include guard.
7826         * common/fileio.h: Rename include guard.
7827         * common/environ.h: Rename include guard.
7828         * common/common-utils.h: Rename include guard.
7829         * common/common-types.h: Rename include guard.
7830         * common/common-regcache.h: Rename include guard.
7831         * common/common-inferior.h: Rename include guard.
7832         * common/common-gdbthread.h: Rename include guard.
7833         * common/common-exceptions.h: Rename include guard.
7834         * common/common-defs.h: Rename include guard.
7835         * common/common-debug.h: Rename include guard.
7836         * common/cleanups.h: Rename include guard.
7837         * common/buffer.h: Rename include guard.
7838         * common/btrace-common.h: Rename include guard.
7839         * common/break-common.h: Rename include guard.
7840         * cli/cli-utils.h: Rename include guard.
7841         * cli/cli-style.h: Rename include guard.
7842         * cli/cli-setshow.h: Rename include guard.
7843         * cli/cli-script.h: Rename include guard.
7844         * cli/cli-interp.h: Rename include guard.
7845         * cli/cli-decode.h: Rename include guard.
7846         * cli/cli-cmds.h: Rename include guard.
7847         * charset-list.h: Add include guard.
7848         * buildsym-legacy.h: Rename include guard.
7849         * bfin-tdep.h: Add include guard.
7850         * ax.h: Rename include guard.
7851         * arm-linux-tdep.h: Add include guard.
7852         * arm-fbsd-tdep.h: Add include guard.
7853         * arch/xtensa.h: Rename include guard.
7854         * arch/tic6x.h: Add include guard.
7855         * arch/i386.h: Add include guard.
7856         * arch/arm.h: Rename include guard.
7857         * arch/arm-linux.h: Rename include guard.
7858         * arch/arm-get-next-pcs.h: Rename include guard.
7859         * arch/amd64.h: Add include guard.
7860         * arch/aarch64-insn.h: Rename include guard.
7861         * arch-utils.h: Rename include guard.
7862         * annotate.h: Add include guard.
7863         * amd64-darwin-tdep.h: Rename include guard.
7864         * aarch64-linux-tdep.h: Add include guard.
7865         * aarch64-fbsd-tdep.h: Add include guard.
7866         * aarch32-linux-nat.h: Add include guard.
7867
7868 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7869
7870         * macrotab.c (macro_define_internal): New function that
7871         factorizes macro_define_object_internal and macro_define_function
7872         code.
7873         (macro_define_object_internal): Use macro_define_internal.
7874         (macro_define_function): Likewise.
7875
7876 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7877
7878         * macrocmd.c (extract_identifier): Return
7879         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7880         callers.
7881
7882 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7883
7884         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7885
7886 2019-02-05  Tom Tromey  <tom@tromey.com>
7887
7888         * target.c (target_stack::unpush): Move assertion earlier.
7889
7890 2019-01-30  Tom Tromey  <tom@tromey.com>
7891
7892         PR python/23615:
7893         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7894         (gdbpy_parse_and_eval): Likewise.
7895         * python/python-internal.h (gdbpy_allow_threads): New class.
7896
7897 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7898
7899         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7900         (aarch64_fbsd_fpregmap): Move earlier.
7901         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7902         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7903         instead of individual calls to trad_frame_set_reg_addr.
7904         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7905         earlier.
7906         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7907         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7908         instead of individual calls to trad_frame_set_reg_addr.
7909
7910 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7911
7912         * CONTRIBUTE: Replace contribution list with wiki link.
7913
7914 2019-01-25  Tom Tromey  <tom@tromey.com>
7915
7916         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7917
7918 2019-01-25  Tom Tromey  <tom@tromey.com>
7919
7920         * xtensa-linux-nat.c: Fix common/ includes.
7921         * xml-support.h: Fix common/ includes.
7922         * xml-support.c: Fix common/ includes.
7923         * x86-linux-nat.c: Fix common/ includes.
7924         * windows-nat.c: Fix common/ includes.
7925         * varobj.h: Fix common/ includes.
7926         * varobj.c: Fix common/ includes.
7927         * value.c: Fix common/ includes.
7928         * valops.c: Fix common/ includes.
7929         * utils.c: Fix common/ includes.
7930         * unittests/xml-utils-selftests.c: Fix common/ includes.
7931         * unittests/utils-selftests.c: Fix common/ includes.
7932         * unittests/unpack-selftests.c: Fix common/ includes.
7933         * unittests/tracepoint-selftests.c: Fix common/ includes.
7934         * unittests/style-selftests.c: Fix common/ includes.
7935         * unittests/string_view-selftests.c: Fix common/ includes.
7936         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7937         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7938         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7939         * unittests/rsp-low-selftests.c: Fix common/ includes.
7940         * unittests/parse-connection-spec-selftests.c: Fix common/
7941         includes.
7942         * unittests/optional-selftests.c: Fix common/ includes.
7943         * unittests/offset-type-selftests.c: Fix common/ includes.
7944         * unittests/observable-selftests.c: Fix common/ includes.
7945         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7946         * unittests/memrange-selftests.c: Fix common/ includes.
7947         * unittests/memory-map-selftests.c: Fix common/ includes.
7948         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7949         * unittests/function-view-selftests.c: Fix common/ includes.
7950         * unittests/environ-selftests.c: Fix common/ includes.
7951         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7952         * unittests/common-utils-selftests.c: Fix common/ includes.
7953         * unittests/cli-utils-selftests.c: Fix common/ includes.
7954         * unittests/array-view-selftests.c: Fix common/ includes.
7955         * ui-file.c: Fix common/ includes.
7956         * tui/tui-io.c: Fix common/ includes.
7957         * tracepoint.h: Fix common/ includes.
7958         * tracepoint.c: Fix common/ includes.
7959         * tracefile-tfile.c: Fix common/ includes.
7960         * top.h: Fix common/ includes.
7961         * top.c: Fix common/ includes.
7962         * thread.c: Fix common/ includes.
7963         * target/waitstatus.h: Fix common/ includes.
7964         * target/waitstatus.c: Fix common/ includes.
7965         * target.h: Fix common/ includes.
7966         * target.c: Fix common/ includes.
7967         * target-memory.c: Fix common/ includes.
7968         * target-descriptions.c: Fix common/ includes.
7969         * symtab.h: Fix common/ includes.
7970         * symfile.c: Fix common/ includes.
7971         * stap-probe.c: Fix common/ includes.
7972         * spu-linux-nat.c: Fix common/ includes.
7973         * sparc-nat.c: Fix common/ includes.
7974         * source.c: Fix common/ includes.
7975         * solib.c: Fix common/ includes.
7976         * solib-target.c: Fix common/ includes.
7977         * ser-unix.c: Fix common/ includes.
7978         * ser-tcp.c: Fix common/ includes.
7979         * ser-pipe.c: Fix common/ includes.
7980         * ser-base.c: Fix common/ includes.
7981         * selftest-arch.c: Fix common/ includes.
7982         * s12z-tdep.c: Fix common/ includes.
7983         * rust-exp.y: Fix common/ includes.
7984         * rs6000-aix-tdep.c: Fix common/ includes.
7985         * riscv-tdep.c: Fix common/ includes.
7986         * remote.c: Fix common/ includes.
7987         * remote-notif.h: Fix common/ includes.
7988         * remote-fileio.h: Fix common/ includes.
7989         * remote-fileio.c: Fix common/ includes.
7990         * regcache.h: Fix common/ includes.
7991         * regcache.c: Fix common/ includes.
7992         * record-btrace.c: Fix common/ includes.
7993         * python/python.c: Fix common/ includes.
7994         * python/py-type.c: Fix common/ includes.
7995         * python/py-inferior.c: Fix common/ includes.
7996         * progspace.h: Fix common/ includes.
7997         * producer.c: Fix common/ includes.
7998         * procfs.c: Fix common/ includes.
7999         * proc-api.c: Fix common/ includes.
8000         * printcmd.c: Fix common/ includes.
8001         * ppc-linux-nat.c: Fix common/ includes.
8002         * parser-defs.h: Fix common/ includes.
8003         * osdata.c: Fix common/ includes.
8004         * obsd-nat.c: Fix common/ includes.
8005         * nat/x86-linux.c: Fix common/ includes.
8006         * nat/x86-linux-dregs.c: Fix common/ includes.
8007         * nat/x86-dregs.h: Fix common/ includes.
8008         * nat/x86-dregs.c: Fix common/ includes.
8009         * nat/ppc-linux.c: Fix common/ includes.
8010         * nat/mips-linux-watch.h: Fix common/ includes.
8011         * nat/mips-linux-watch.c: Fix common/ includes.
8012         * nat/linux-waitpid.c: Fix common/ includes.
8013         * nat/linux-ptrace.h: Fix common/ includes.
8014         * nat/linux-ptrace.c: Fix common/ includes.
8015         * nat/linux-procfs.c: Fix common/ includes.
8016         * nat/linux-personality.c: Fix common/ includes.
8017         * nat/linux-osdata.c: Fix common/ includes.
8018         * nat/linux-namespaces.c: Fix common/ includes.
8019         * nat/linux-btrace.h: Fix common/ includes.
8020         * nat/linux-btrace.c: Fix common/ includes.
8021         * nat/fork-inferior.c: Fix common/ includes.
8022         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8023         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8024         * nat/aarch64-linux.c: Fix common/ includes.
8025         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8026         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8027         * namespace.h: Fix common/ includes.
8028         * mips-linux-tdep.c: Fix common/ includes.
8029         * minsyms.c: Fix common/ includes.
8030         * mi/mi-parse.h: Fix common/ includes.
8031         * mi/mi-main.c: Fix common/ includes.
8032         * mi/mi-cmd-env.c: Fix common/ includes.
8033         * memrange.h: Fix common/ includes.
8034         * memattr.c: Fix common/ includes.
8035         * maint.h: Fix common/ includes.
8036         * maint.c: Fix common/ includes.
8037         * main.c: Fix common/ includes.
8038         * machoread.c: Fix common/ includes.
8039         * location.c: Fix common/ includes.
8040         * linux-thread-db.c: Fix common/ includes.
8041         * linux-nat.c: Fix common/ includes.
8042         * linux-fork.c: Fix common/ includes.
8043         * inline-frame.c: Fix common/ includes.
8044         * infrun.c: Fix common/ includes.
8045         * inflow.c: Fix common/ includes.
8046         * inferior.h: Fix common/ includes.
8047         * inferior.c: Fix common/ includes.
8048         * infcmd.c: Fix common/ includes.
8049         * inf-ptrace.c: Fix common/ includes.
8050         * inf-child.c: Fix common/ includes.
8051         * ia64-linux-nat.c: Fix common/ includes.
8052         * i387-tdep.c: Fix common/ includes.
8053         * i386-tdep.c: Fix common/ includes.
8054         * i386-linux-tdep.c: Fix common/ includes.
8055         * i386-linux-nat.c: Fix common/ includes.
8056         * i386-go32-tdep.c: Fix common/ includes.
8057         * i386-fbsd-tdep.c: Fix common/ includes.
8058         * i386-fbsd-nat.c: Fix common/ includes.
8059         * guile/scm-type.c: Fix common/ includes.
8060         * guile/guile.c: Fix common/ includes.
8061         * go32-nat.c: Fix common/ includes.
8062         * gnu-nat.c: Fix common/ includes.
8063         * gdbthread.h: Fix common/ includes.
8064         * gdbarch-selftests.c: Fix common/ includes.
8065         * gdb_usleep.c: Fix common/ includes.
8066         * gdb_select.h: Fix common/ includes.
8067         * gdb_bfd.c: Fix common/ includes.
8068         * gcore.c: Fix common/ includes.
8069         * fork-child.c: Fix common/ includes.
8070         * findvar.c: Fix common/ includes.
8071         * fbsd-nat.c: Fix common/ includes.
8072         * event-top.c: Fix common/ includes.
8073         * event-loop.c: Fix common/ includes.
8074         * dwarf2read.c: Fix common/ includes.
8075         * dwarf2loc.c: Fix common/ includes.
8076         * dwarf2-frame.c: Fix common/ includes.
8077         * dwarf-index-cache.c: Fix common/ includes.
8078         * dtrace-probe.c: Fix common/ includes.
8079         * disasm-selftests.c: Fix common/ includes.
8080         * defs.h: Fix common/ includes.
8081         * csky-tdep.c: Fix common/ includes.
8082         * cp-valprint.c: Fix common/ includes.
8083         * cp-support.h: Fix common/ includes.
8084         * cp-support.c: Fix common/ includes.
8085         * corelow.c: Fix common/ includes.
8086         * completer.h: Fix common/ includes.
8087         * completer.c: Fix common/ includes.
8088         * compile/compile.c: Fix common/ includes.
8089         * compile/compile-loc2c.c: Fix common/ includes.
8090         * compile/compile-cplus-types.c: Fix common/ includes.
8091         * compile/compile-cplus-symbols.c: Fix common/ includes.
8092         * command.h: Fix common/ includes.
8093         * cli/cli-dump.c: Fix common/ includes.
8094         * cli/cli-cmds.c: Fix common/ includes.
8095         * charset.c: Fix common/ includes.
8096         * build-id.c: Fix common/ includes.
8097         * btrace.h: Fix common/ includes.
8098         * btrace.c: Fix common/ includes.
8099         * breakpoint.h: Fix common/ includes.
8100         * breakpoint.c: Fix common/ includes.
8101         * ax.h:
8102         (enum agent_op): Fix common/ includes.
8103         * ax-general.c (struct aop_map): Fix common/ includes.
8104         * ax-gdb.c: Fix common/ includes.
8105         * auxv.c: Fix common/ includes.
8106         * auto-load.c: Fix common/ includes.
8107         * arm-tdep.c: Fix common/ includes.
8108         * arch/riscv.c: Fix common/ includes.
8109         * arch/ppc-linux-common.c: Fix common/ includes.
8110         * arch/i386.c: Fix common/ includes.
8111         * arch/arm.c: Fix common/ includes.
8112         * arch/arm-linux.c: Fix common/ includes.
8113         * arch/arm-get-next-pcs.c: Fix common/ includes.
8114         * arch/amd64.c: Fix common/ includes.
8115         * arch/aarch64.c: Fix common/ includes.
8116         * arch/aarch64-insn.c: Fix common/ includes.
8117         * arch-utils.c: Fix common/ includes.
8118         * amd64-windows-tdep.c: Fix common/ includes.
8119         * amd64-tdep.c: Fix common/ includes.
8120         * amd64-sol2-tdep.c: Fix common/ includes.
8121         * amd64-obsd-tdep.c: Fix common/ includes.
8122         * amd64-nbsd-tdep.c: Fix common/ includes.
8123         * amd64-linux-tdep.c: Fix common/ includes.
8124         * amd64-linux-nat.c: Fix common/ includes.
8125         * amd64-fbsd-tdep.c: Fix common/ includes.
8126         * amd64-fbsd-nat.c: Fix common/ includes.
8127         * amd64-dicos-tdep.c: Fix common/ includes.
8128         * amd64-darwin-tdep.c: Fix common/ includes.
8129         * agent.c: Fix common/ includes.
8130         * ada-lang.h: Fix common/ includes.
8131         * ada-lang.c: Fix common/ includes.
8132         * aarch64-tdep.c: Fix common/ includes.
8133
8134 2019-01-25  Tom Tromey  <tom@tromey.com>
8135
8136         * common/create-version.sh: Use common/version.h.
8137
8138 2019-01-24  Pedro Alves  <palves@redhat.com>
8139
8140         * infrun.c (signal_stop, signal_print, signal_program)
8141         (signal_catch, signal_pass): Now arrays instead of pointers.
8142         (update_signals_program_target, do_target_resume)
8143         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8144         * linux-nat.c (linux_nat_target::pass_signals)
8145         (linux_nat_target::create_inferior, linux_nat_target::attach):
8146         Adjust.
8147         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8148         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8149         * procfs.c (procfs_target::pass_signals): Adjust.
8150         * record-full.c (record_full_target::resume): Adjust.
8151         * remote.c (remote_target::pass_signals)
8152         (remote_target::program_signals): Adjust.
8153         * target-debug.h (target_debug_print_signals): Now takes a
8154         gdb::array_view as parameter.  Adjust.
8155         * target.h (target_ops) <pass_signals, program_signals>: Replace
8156         pointer and length parameters with gdb::array_view.
8157         (target_pass_signals, target_program_signals): Likewise.
8158         * target-delegates.c: Regenerate.
8159
8160 2019-01-24  Pedro Alves  <palves@redhat.com>
8161
8162         * common/forward-scope-exit.h
8163         (forward_scope_exit::forward_scope_exit): Pass arguments to
8164         m_bind_function directly, instead of creating a std::bind and
8165         copying that.
8166
8167 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8168
8169         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8170         for static members.
8171         (pass_in_v_vfp_candidate): Likewise.
8172
8173 2019-01-23  Tom Tromey  <tom@tromey.com>
8174             Pedro Alves  <palves@redhat.com>
8175
8176         * regcache.c (class regcache_invalidator): Remove.
8177         (regcache::raw_write): Use make_scope_exit.
8178
8179 2019-01-23  Tom Tromey  <tom@tromey.com>
8180
8181         * ui-out.h (class ui_out_emit_type): Update comment.
8182
8183 2019-01-23  Tom Tromey  <tom@tromey.com>
8184
8185         * infrun.c (fetch_inferior_event): Update comment.
8186
8187 2019-01-23  Tom Tromey  <tom@tromey.com>
8188             Pedro Alves  <palves@redhat.com>
8189
8190         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8191         parameter.
8192         (fetch_inferior_event): Use SCOPE_EXIT.
8193
8194
8195 2019-01-23  Tom Tromey  <tom@tromey.com>
8196             Pedro Alves  <palves@redhat.com>
8197
8198         * infrun.c (disable_thread_events): Delete.
8199         (stop_all_threads): Use SCOPE_EXIT.
8200
8201 2019-01-23  Tom Tromey  <tom@tromey.com>
8202             Pedro Alves  <palves@redhat.com>
8203
8204         * symfile.c: Include forward-scope-exit.h.
8205         (clear_symtab_users_cleanup): Replace forward declaration with
8206         a FORWARD_SCOPE_EXIT.
8207         (syms_from_objfile_1): Use the forward_scope_exit and
8208         gdb::optional instead of cleanup_function.
8209         (reread_symbols): Use the forward_scope_exit instead of
8210         cleanup_function.
8211         (clear_symtab_users_cleanup): Remove function.
8212
8213 2019-01-23  Tom Tromey  <tom@tromey.com>
8214             Pedro Alves  <palves@redhat.com>
8215
8216         * linux-nat.c: Include scope-exit.h.
8217         (cleanup_target_stop): Remove.
8218         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8219         SCOPE_EXIT.
8220
8221 2019-01-23  Tom Tromey  <tom@tromey.com>
8222             Pedro Alves  <palves@redhat.com>
8223
8224         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8225         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8226
8227 2019-01-23  Tom Tromey  <tom@tromey.com>
8228             Andrew Burgess  <andrew.burgess@embecosm.com>
8229             Pedro Alves  <palves@redhat.com>
8230
8231         * infrun.c (fetch_inferior_event): Use scope_exit.
8232         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8233         * top.c (execute_command): Use scope_exit.
8234         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8235         * utils.c (do_bpstat_clear_actions_cleanup)
8236         (make_bpstat_clear_actions_cleanup): Remove.
8237
8238 2019-01-23  Tom Tromey  <tom@tromey.com>
8239             Pedro Alves  <palves@redhat.com>
8240
8241         * infrun.c: Include "common/scope-exit.h"
8242         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8243         (wait_for_inferior): Use SCOPE_EXIT.
8244         (fetch_inferior_event): Use scope_exit.
8245
8246 2019-01-23  Tom Tromey  <tom@tromey.com>
8247             Pedro Alves  <palves@redhat.com>
8248
8249         * breakpoint.c (create_breakpoint): Remove cleanup.
8250
8251 2019-01-23  Tom Tromey  <tom@tromey.com>
8252             Andrew Burgess  <andrew.burgess@embecosm.com>
8253             Pedro Alves  <palves@redhat.com>
8254
8255 2019-01-23  Pedro Alves  <palves@redhat.com>
8256
8257         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8258
8259 2019-01-23  Pedro Alves  <palves@redhat.com>
8260             Andrew Burgess  <andrew.burgess@embecosm.com>
8261
8262         * gdbthread.h: Include "common/forward-scope-exit.h".
8263         (scoped_finish_thread_state): Redefine custom class in terms of
8264         forward_scope_exit.
8265
8266 2019-01-23  Pedro Alves  <palves@redhat.com>
8267             Andrew Burgess  <andrew.burgess@embecosm.com>
8268
8269         * common/forward-scope-exit.h: New file.
8270
8271 2019-01-23  Pedro Alves  <palves@redhat.com>
8272             Andrew Burgess  <andrew.burgess@embecosm.com>
8273             Tom Tromey  <tom@tromey.com>
8274
8275         * common/scope-exit.h: New file.
8276
8277 2019-01-23  Pedro Alves  <palves@redhat.com>
8278
8279         * common/preprocessor.h (ESC): Rename to ...
8280         (ESC_PARENS): ... this.
8281         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8282         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8283
8284 2019-01-23  Tom Tromey  <tom@tromey.com>
8285
8286         * language.h (class scoped_switch_to_sym_language_if_auto):
8287         Initialize m_lang in both cases.
8288
8289 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8290
8291         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8292         with XCNEW.
8293
8294 2019-01-22  Tom Tromey  <tom@tromey.com>
8295
8296         * corelow.c: Do not include sys/file.h.
8297
8298 2019-01-22  Tom Tromey  <tom@tromey.com>
8299
8300         * tui/tui-wingeneral.h: Include gdb_curses.h.
8301
8302 2019-01-22  Tom Tromey  <tom@tromey.com>
8303
8304         * source-cache.h (class source_cache) <get_source_lines,
8305         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8306
8307 2019-01-22  Tom Tromey  <tom@tromey.com>
8308
8309         * remote-fileio.h (struct remote_target): Declare.
8310
8311 2019-01-22  Tom Tromey  <tom@tromey.com>
8312
8313         * python/py-arch.c: Do not include py-ref.h.
8314         * python/py-bpevent.c: Do not include py-ref.h.
8315         * python/py-cmd.c: Do not include py-ref.h.
8316         * python/py-continueevent.c: Do not include py-ref.h.
8317         * python/py-event.h: Do not include py-ref.h.
8318         * python/py-evtregistry.c: Do not include py-ref.h.
8319         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8320         * python/py-frame.c: Do not include py-ref.h.
8321         * python/py-framefilter.c: Do not include py-ref.h.
8322         * python/py-function.c: Do not include py-ref.h.
8323         * python/py-infevents.c: Do not include py-ref.h.
8324         * python/py-linetable.c: Do not include py-ref.h.
8325         * python/py-objfile.c: Do not include py-ref.h.
8326         * python/py-param.c: Do not include py-ref.h.
8327         * python/py-prettyprint.c: Do not include py-ref.h.
8328         * python/py-progspace.c: Do not include py-ref.h.
8329         * python/py-symbol.c: Do not include py-ref.h.
8330         * python/py-symtab.c: Do not include py-ref.h.
8331         * python/py-type.c: Do not include py-ref.h.
8332         * python/py-unwind.c: Do not include py-ref.h.
8333         * python/py-utils.c: Do not include py-ref.h.
8334         * python/py-value.c: Do not include py-ref.h.
8335         * python/py-varobj.c: Do not include py-ref.h.
8336         * python/py-xmethods.c: Do not include py-ref.h.
8337         * python/python.c: Do not include py-ref.h.
8338         * varobj.c: Do not include py-ref.h.
8339
8340 2019-01-22  Tom Tromey  <tom@tromey.com>
8341
8342         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8343         keyword for bcache.
8344
8345 2019-01-22  Tom Tromey  <tom@tromey.com>
8346
8347         * compile/compile-cplus-types.c: Remove a comment by #include.
8348
8349 2019-01-22  Tom Tromey  <tom@tromey.com>
8350
8351         * compile/gcc-c-plugin.h: Include compile-internal.h.
8352
8353 2019-01-22  Tom Tromey  <tom@tromey.com>
8354
8355         * stabsread.c (EXTERN): Do not define.
8356         (symnum, next_symbol_text_func, processing_gcc_compilation)
8357         (within_function, global_sym_chain, global_stabs)
8358         (previous_stab_code, this_object_header_files)
8359         (n_this_object_header_files)
8360         (n_allocated_this_object_header_files): Define.
8361         * stabsread.h (EXTERN): Never define.  Use "extern".
8362
8363 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8364
8365         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8366         history_value.
8367
8368 2019-01-21  Tom Tromey  <tom@tromey.com>
8369
8370         * ui-out.c: Fix includes.
8371         * tui/tui-source.c: Fix includes.
8372         * target.c: Fix includes.
8373         * remote.c: Fix includes.
8374         * regcache.c: Fix includes.
8375         * python/py-block.c: Fix includes.
8376         * printcmd.c: Fix includes.
8377         * or1k-tdep.c: Fix includes.
8378         * mi/mi-main.c: Fix includes.
8379         * m32r-tdep.c: Fix includes.
8380         * csky-tdep.c: Fix includes.
8381         * compile/compile-cplus-types.c: Fix includes.
8382         * cli/cli-interp.c: Fix includes.
8383
8384 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8385
8386         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8387         for padding.
8388
8389 2019-01-16  Tom Tromey  <tom@tromey.com>
8390
8391         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8392         earlier.
8393         (struct objfile) <msymbols_range>: Move from top level.
8394         <msymbols>: New method.
8395         (class objfile_msymbols): Remove.
8396         * symtab.c (default_collect_symbol_completion_matches_break_on):
8397         Update.
8398         * symmisc.c (dump_msymbols): Update.
8399         * stabsread.c (scan_file_globals): Update.
8400         * objc-lang.c (info_selectors_command, info_classes_command)
8401         (find_methods): Update.
8402         * minsyms.c (find_solib_trampoline_target): Update.
8403         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8404         * coffread.c (coff_symfile_read): Update.
8405         * ada-lang.c (ada_lookup_simple_minsym)
8406         (ada_collect_symbol_completion_matches): Update.
8407
8408 2019-01-16  Tom Tromey  <tom@tromey.com>
8409
8410         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8411         type.  Remove no-argument constructor.
8412         <iterator::operator++>: Simplify.
8413         <begin>: Update.
8414         <end>: Use minimal_symbol_count.
8415
8416 2019-01-16  Tom Tromey  <tom@tromey.com>
8417
8418         * objfiles.h (struct objfile) <psymtabs>: New method.
8419         (class objfile_psymtabs): Remove.
8420         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8421         typedef.
8422         <range>: New method.
8423         (require_partial_symbols): Change return type.
8424         * psymtab.c (require_partial_symbols)
8425         (psym_expand_symtabs_matching): Update.
8426         * mdebugread.c (parse_partial_symbols): Update.
8427         * dbxread.c (dbx_end_psymtab): Update.
8428
8429 2019-01-15  Tom Tromey  <tom@tromey.com>
8430
8431         * symtab.c (lookup_objfile_from_block)
8432         (lookup_symbol_in_objfile_symtabs)
8433         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8434         (find_line_symtab, info_sources_command)
8435         (default_collect_symbol_completion_matches_break_on)
8436         (make_source_files_completion_list): Update.
8437         * symmisc.c (print_objfile_statistics, dump_objfile)
8438         (maintenance_print_symbols, maintenance_info_symtabs)
8439         (maintenance_check_symtabs, maintenance_info_line_tables):
8440         Update.
8441         * source.c (select_source_symtab)
8442         (forget_cached_source_info_for_objfile): Update.
8443         * objfiles.h (class objfile_compunits): Remove.
8444         (struct objfile) <compunits_range>: New typedef.
8445         (compunits): New method.
8446         * objfiles.c (objfile_relocate1): Update.
8447         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8448         * maint.c (count_symtabs_and_blocks): Update.
8449         * linespec.c (iterate_over_all_matching_symtabs): Update.
8450         * cp-support.c (add_symbol_overload_list_qualified): Update.
8451         * coffread.c (coff_symtab_read): Update.
8452         * ada-lang.c (add_nonlocal_symbols)
8453         (ada_collect_symbol_completion_matches)
8454         (ada_add_global_exceptions): Update.
8455
8456 2019-01-15  Tom Tromey  <tom@tromey.com>
8457
8458         * progspace.h (program_space) <objfiles_safe_range>: New
8459         typedef.
8460         <objfiles_safe>: New method.
8461         * objfiles.h (class all_objfiles_safe): Remove.
8462         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8463         * jit.c (jit_inferior_exit_hook): Update.
8464
8465 2019-01-17  Tom Tromey  <tom@tromey.com>
8466
8467         * progspace.h (program_space) <objfiles_range>: New typedef.
8468         <objfiles>: New method.
8469         <objfiles_head>: Rename from objfiles.
8470         (object_files): Update.
8471         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8472         * guile/scm-pretty-print.c
8473         (ppscm_find_pretty_printer_from_objfiles): Update.
8474         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8475         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8476         Update.
8477         * python/py-progspace.c (pspy_get_objfiles): Update.
8478         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8479         Update.
8480         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8481         (objfpy_lookup_objfile_by_build_id): Update.
8482         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8483         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8484         Update.
8485         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8486         (expand_symtab_containing_pc, lookup_objfile_from_block)
8487         (lookup_static_symbol, basic_lookup_transparent_type)
8488         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8489         (find_line_symtab, info_sources_command)
8490         (default_collect_symbol_completion_matches_break_on)
8491         (make_source_files_completion_list, find_main_name): Update.
8492         * symmisc.c (print_symbol_bcache_statistics)
8493         (print_objfile_statistics, maintenance_print_symbols)
8494         (maintenance_print_msymbols, maintenance_print_objfiles)
8495         (maintenance_info_symtabs, maintenance_check_symtabs)
8496         (maintenance_expand_symtabs, maintenance_info_line_tables):
8497         Update.
8498         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8499         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8500         (map_overlay_command, unmap_overlay_command)
8501         (simple_overlay_update, expand_symtabs_matching)
8502         (map_symbol_filenames): Update.
8503         * symfile-debug.c (set_debug_symfile): Update.
8504         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8505         Update.
8506         * source.c (select_source_symtab, forget_cached_source_info):
8507         Update.
8508         * solib.c (solib_read_symbols): Update.
8509         * solib-spu.c (append_ocl_sos): Update.
8510         * psymtab.c (maintenance_print_psymbols)
8511         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8512         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8513         * printcmd.c (info_symbol_command): Update.
8514         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8515         Update.
8516         * objfiles.h (class all_objfiles): Remove.
8517         * objfiles.c (have_partial_symbols, have_full_symbols)
8518         (have_minimal_symbols, qsort_cmp, update_section_map)
8519         (shared_objfile_contains_address_p)
8520         (default_iterate_over_objfiles_in_search_order): Update.
8521         * objc-lang.c (info_selectors_command, info_classes_command)
8522         (find_methods): Update.
8523         * minsyms.c (find_solib_trampoline_target): Update.
8524         * maint.c (maintenance_info_sections)
8525         (maintenance_translate_address, count_symtabs_and_blocks):
8526         Update.
8527         * main.c (captured_main_1): Update.
8528         * linux-thread-db.c (try_thread_db_load_from_pdir)
8529         (has_libpthread): Update.
8530         * linespec.c (iterate_over_all_matching_symtabs)
8531         (search_minsyms_for_name): Update.
8532         * jit.c (jit_find_objf_with_entry_addr): Update.
8533         * hppa-tdep.c (find_unwind_entry)
8534         (hppa_lookup_stub_minimal_symbol): Update.
8535         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8536         Update.
8537         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8538         (elf_gnu_ifunc_resolve_by_got): Update.
8539         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8540         * dwarf-index-write.c (save_gdb_index_command): Update.
8541         * cp-support.c (add_symbol_overload_list_qualified): Update.
8542         * breakpoint.c (create_overlay_event_breakpoint)
8543         (create_longjmp_master_breakpoint)
8544         (create_std_terminate_master_breakpoint)
8545         (create_exception_master_breakpoint): Update.
8546         * blockframe.c (find_pc_partial_function): Update.
8547         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8548         (ada_collect_symbol_completion_matches)
8549         (ada_add_global_exceptions): Update.
8550
8551 2019-01-17  Tom Tromey  <tom@tromey.com>
8552
8553         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8554         declare VEC.
8555         (solib_target_parse_libraries): Change return type.
8556         (library_list_start_segment, library_list_start_section)
8557         (library_list_end_library, library_list_start_library); Update.
8558         (solib_target_free_library_list): Remove.
8559         (solib_target_parse_libraries): Remove cleanup.  Change return
8560         type.
8561         (solib_target_current_sos): Update.
8562
8563 2019-01-17  Tom Tromey  <tromey@bapiya>
8564
8565         * valprint.c: Replace "the the" with "the".
8566         * symtab.c: Replace "the the" with "the".
8567         * solib.c: Replace "the the" with "the".
8568         * solib-dsbt.c: Replace "the the" with "the".
8569         * linespec.c: Replace "the the" with "the".
8570         * dwarf2loc.h: Replace "the the" with "the".
8571         * amd64-windows-tdep.c: Replace "the the" with "the".
8572         * aarch64-tdep.c: Replace "the the" with "the".
8573
8574 2019-01-16  Keith Seitz  <keiths@redhat.com>
8575
8576         PR gdb/23773
8577         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8578         <builder>: Rename to ..
8579         <m_builder>: ... this and make private.
8580         (dwarf2_cu::get_builder): New method.  Change all users of
8581         `builder' to use this method.
8582         (dwarf2_start_symtab): Move to ...
8583         (dwarf2_cu::start_symtab): ... here.  Update all callers
8584         (setup_type_unit_groups): Move to ...
8585         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8586         callers.
8587         (dwarf2_cu::reset_builder): New method.
8588         (process_full_compunit, process_full_type_unit): Use
8589         dwarf2_cu::reset_builder.
8590         (follow_die_offset): Record the ancestor CU if it is different
8591         from the followed DIE's CU.
8592         (follow_die_sig_1): Likewise.
8593
8594 2019-01-15  Tom Tromey  <tom@tromey.com>
8595
8596         * remote.c (class remote_state) <buf>: Now a char_vector.
8597         <buf_size>: Remove.
8598         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8599         parameter.
8600         (remote_target::getpkt_or_notif_sane_1)
8601         (remote_target::getpkt_sane)
8602         (remote_target::getpkt_or_notif_sane): Likewise.
8603         (class remote_target) <putpkt>: New overload.
8604         (remote_target::read_frame): Change type of "buf_p".  Remove
8605         sizeof_p parameter.
8606         (packet_ok): New overload.
8607         (packet_check_result): New overload.
8608         Update all uses.
8609
8610 2019-01-14  Tom Tromey  <tom@tromey.com>
8611
8612         * remote-notif.c (handle_notification, remote_notif_ack)
8613         (remote_notif_parse): Make "buf" const.
8614         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8615         const.
8616         (remote_notif_parse, remote_notif_ack, handle_notification):
8617         Likewise.
8618         * remote.c (remote_notif_stop_parse): Make "buf" const.
8619         (remote_target::remote_parse_stop_reply): Make "buf" const.
8620         (remote_notif_stop_ack): Make "buf" const.
8621
8622 2019-01-14  Tom Tromey  <tom@tromey.com>
8623
8624         * remote.c (remote_console_output): Make parameter const.
8625
8626 2019-01-14  Tom Tromey  <tom@tromey.com>
8627
8628         * target-debug.h (target_debug_print_signals): Constify.
8629         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8630         * procfs.c (procfs_target::pass_signals): Update.
8631         * linux-nat.c (linux_nat_target::pass_signals): Update.
8632         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8633         * target-delegates.c: Rebuild.
8634         * remote.c (remote_target::program_signals): Update.
8635         (remote_target::pass_signals): Update.
8636         * target.c (target_pass_signals): Constify argument.
8637         (target_program_signals): Likewise.
8638         * target.h (struct target_ops) <pass_signals, program_signals>:
8639         Constify argument.
8640         (target_pass_signals, target_program_signals): Constify argument.
8641
8642 2019-01-14  Tom Tromey  <tom@tromey.com>
8643
8644         PR tui/28819:
8645         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8646
8647 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8648
8649         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8650         field.
8651         * rs6000-tdep.c: Include reggroups.h.
8652         (IS_V_ALIAS_PSEUDOREG): Define.
8653         (rs6000_register_name): Return names for the "vX" aliases.
8654         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8655         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8656         aliases.  Call default_register_reggroup_p for all other
8657         pseudo-registers.
8658         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8659         New functions.
8660         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8661         Handle "vX" aliases.
8662         (v_alias_pseudo_register_collect): New function.
8663         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8664         (rs6000_gdbarch_init): Initialize "vX" aliases as
8665         pseudo-registers.  Restore registration of
8666         rs6000_pseudo_register_reggroup_p with
8667         set_tdesc_pseudo_register_reggroup_p.
8668
8669 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8670
8671         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8672         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8673         set_gdbarch_num_pseudo_regs.
8674
8675 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8676
8677         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8678         Remove arg prefixname, add do_set and do_show.
8679         Add member functions set_list and show_list.
8680         * cli/cli-style.c (class cli_style_option): Update accordingly.
8681         (style_set_list): Move to file scope.
8682         (style_show_list): Likewise.
8683         (set_style): Call help_list.
8684         (show_style): Call cmd_show_list.
8685         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8686         Update to use the new macro.
8687
8688 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8689
8690         * ada-lang.c (_initialize_ada_language): Expand the help text
8691         for the "catch exception" command.
8692
8693 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8694
8695         * symtab.c (matching_obj_sections): Initialize obj,
8696         declare it closer to its usage.
8697
8698 2019-01-10  Tom Tromey  <tom@tromey.com>
8699
8700         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8701         (basic_inf_threads_range): Remove.
8702         (inf_threads_range, inf_non_exited_threads_range)
8703         (safe_inf_threads_range): Use next_adapter.
8704
8705 2019-01-10  Keith Seitz  <keiths@redhat.com>
8706
8707         PR gdb/23712
8708         PR symtab/23010
8709         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8710         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8711
8712 2019-01-10  Keith Seitz  <keiths@redhat.com>
8713
8714         PR gdb/23712
8715         PR symtab/23010
8716         * dictionary.c (pending_to_vector): Remove.
8717         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8718         Remove _1 suffix, replacing functions of the same name.  Update
8719         all callers.
8720         (dict_create_hashed, dict_create_hashed_expandable)
8721         (dict_create_linear, dict_create_linear_expandable, dict_free)
8722         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8723         Make functions static.
8724
8725 2019-01-10  Keith Seitz  <keiths@redhat.com>
8726
8727         PR gdb/23712
8728         PR symtab/23010
8729         * dictionary.h (struct dictionary): Replace declaration with
8730         multidictionary.
8731         (dict_create_hashed, dict_create_hashed_expandable)
8732         (dict_create_linear, dict_create_linear_expandable)
8733         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8734         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8735         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8736         taking multidictionary argument.
8737         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8738         * block.h (struct block) <dict>: Change to multidictionary
8739         and rename `multidict'.
8740         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8741         symmisc.c: Update all dictionary references to multidictionary.
8742
8743 2019-01-10  Keith Seitz  <keiths@redhat.com>
8744
8745         PR gdb/23712
8746         PR symtab/23010
8747         * dictionary.c: Include unordered_map.
8748         (pending_to_vector): New function.
8749         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8750         Rewrite the non-"_1" functions to take vector instead
8751         of linked list.
8752         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8753         "new" _1 versions of the same name.
8754         (multidictionary): Define.
8755         (std::hash<enum language): New definition.
8756         (collate_pending_symbols_by_language, mdict_create_hashed)
8757         (mdict_create_hashed_expandable, mdict_create_linear)
8758         (mdict_create_linear_expandable, mdict_free)
8759         (find_language_dictionary, create_new_language_dictionary)
8760         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8761         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8762         (mdict_size, mdict_empty): New functions.
8763         * dictionary.h (mdict_iterator): Define.
8764
8765 2019-01-10  Pedro Alves  <palves@redhat.com>
8766
8767         * breakpoint.c (read_uploaded_action)
8768         (create_tracepoint_from_upload): Adjust to use
8769         gdb::unique_xmalloc_ptr.
8770         * ctf.c (ctf_write_uploaded_tp):
8771         (SET_ARRAY_FIELD): Use emplace_back.
8772         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8773         * tracefile-tfile.c (tfile_write_uploaded_tp):
8774         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8775         gdb::unique_xmalloc_ptr.
8776         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8777         at_string, cond_string, cmd_strings>: Replace char pointers
8778         with gdb::unique_xmalloc_ptr.
8779
8780 2019-01-10  Pedro Alves  <palves@redhat.com>
8781
8782         * solib-target.c (library_list_start_library): Don't xstrdup name.
8783
8784 2019-01-10  Pedro Alves  <palves@redhat.com>
8785
8786         * mdebugread.c (parse_partial_symbols): Use
8787         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8788
8789 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8790
8791         * linux-fork.c (scoped_switch_fork_info)
8792         <~scoped_switch_fork_info>: Fix incorrect variable name.
8793
8794 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8795
8796         * linux-fork.c (scoped_switch_fork_info)
8797         <scoped_switch_fork_info>: Make explicit.
8798         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8799
8800 2019-01-10  Tom Tromey  <tom@tromey.com>
8801
8802         * objfiles.h (objfile::reset_psymtabs): Update.
8803         * objfiles.c (objfile::objfile): Update.
8804         * psymtab.h (psymtab_storage::obstack): Update.
8805         (psymtab_storage::m_obstack): Use gdb::optional.
8806         (class psymtab_storage): Update comment.  Remove objfile
8807         parameter.
8808         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8809
8810 2019-01-10  Tom Tromey  <tom@tromey.com>
8811
8812         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8813         <free_psymtabs>: Now private.
8814         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8815         (allocate_psymtab): Use new method.
8816
8817 2019-01-10  Tom Tromey  <tom@tromey.com>
8818
8819         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8820         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8821         * mdebugread.c (parse_partial_symbols): Use
8822         allocate_dependencies.
8823         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8824         allocate_dependencies.
8825         (process_psymtab_comp_unit_reader)
8826         (build_type_psymtab_dependencies): Likewise.
8827         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8828
8829 2019-01-10  Tom Tromey  <tom@tromey.com>
8830
8831         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8832         PSYMBOL_SET_LANGUAGE.
8833         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8834
8835 2019-01-10  Tom Tromey  <tom@tromey.com>
8836
8837         * psymtab.h (psymtab_storage::obstack): New method.
8838         <m_obstack>: Rename from obstack; now private.
8839         * psymtab.c (psymtab_storage): Update.
8840         * dwarf2read.c (create_addrmap_from_index)
8841         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8842         Update.
8843
8844 2019-01-10  Tom Tromey  <tom@tromey.com>
8845
8846         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8847         * objfiles.h (objfile::reset_psymtabs): New method.
8848
8849 2019-01-10  Tom Tromey  <tom@tromey.com>
8850
8851         * symmisc.c (print_symbol_bcache_statistics): Update.
8852         (print_objfile_statistics): Update.
8853         * symfile.c (reread_symbols): Update.
8854         * psymtab.h (class psymtab_storage): New.
8855         * psymtab.c (psymtab_storage): New constructor.
8856         (~psymtab_storage): New destructor.
8857         (require_partial_symbols): Update.
8858         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8859         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8860         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8861         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8862         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8863         (start_psymtab_common, end_psymtab_common)
8864         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8865         (allocate_psymtab): Update.
8866         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8867         Update.
8868         (dump_psymtab_addrmap, maintenance_print_psymbols)
8869         (maintenance_check_psymtabs): Update.
8870         (class objfile_psymtabs): Move to objfiles.h.
8871         * psympriv.h (discard_psymtab): Now inline.
8872         (psymtab_discarder::psymtab_discarder): Update.
8873         (psymtab_discarder::~psymtab_discarder): Update.
8874         (ALL_OBJFILE_PSYMTABS): Rewrite.
8875         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8876         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8877         Remove fields.
8878         <partial_symtabs>: New field.
8879         (class objfile_psymtabs): Move from psymtab.h.  Update.
8880         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8881         psymbol_cache.
8882         (objfile::~objfile): Don't destroy psymbol_cache.
8883         * mdebugread.c (parse_partial_symbols): Update.
8884         * dwarf2read.c (create_addrmap_from_index)
8885         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8886         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8887         (add_partial_subprogram, dwarf2_ranges_read): Update.
8888         * dwarf-index-write.c (write_address_map)
8889         (write_one_signatured_type, recursively_write_psymbols)
8890         (class debug_names, class debug_names, write_psymtabs_to_index):
8891         Update.
8892
8893 2019-01-10  Tom Tromey  <tom@tromey.com>
8894
8895         * symtab.h (SYMBOL_SET_NAMES): Update.
8896         (symbol_set_names): Update.
8897         (MSYMBOL_SET_NAMES): Update.
8898         * symtab.c (symbol_set_names): Change argument to be an
8899         objfile_per_bfd_storage.
8900         * psymtab.c (add_psymbol_to_bcache): Update.
8901         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8902
8903 2019-01-10  Tom Tromey  <tom@tromey.com>
8904
8905         * symtab.c (create_demangled_names_hash): Change argument to be an
8906         objfile_per_bfd_storage.
8907         (symbol_set_names): Update.
8908
8909 2019-01-10  Tom Tromey  <tom@tromey.com>
8910
8911         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8912         init_psymbol_list.
8913         * psymtab.c (init_psymbol_list): Do nothing if already called.
8914         * psympriv.h (init_psymbol_list): Add comment.
8915         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8916         init_psymbol_list.
8917         * dbxread.c (dbx_symfile_read): Unconditionally call
8918         init_psymbol_list.
8919
8920 2019-01-10  Tom Tromey  <tom@tromey.com>
8921
8922         * xcoffread.c (scan_xcoff_symtab): Update.
8923         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8924         "where".
8925         * mdebugread.c (parse_partial_symbols)
8926         (handle_psymbol_enumerators): Update.
8927         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8928         * dbxread.c (read_dbx_symtab): Update.
8929         * psympriv.h (psymbol_placement): New enum.
8930         (add_psymbol_to_list): Update.
8931
8932 2019-01-10  Tom Tromey  <tom@tromey.com>
8933
8934         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8935         static_psymbols parameters.
8936         (scan_xcoff_symtab): Update.
8937         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8938         static_psymbols parameters.
8939         * psympriv.h (start_psymtab_common): Update.
8940         * mdebugread.c (parse_partial_symbols): Update.
8941         * dwarf2read.c (create_partial_symtab): Update.
8942         * dbxread.c (read_dbx_symtab): Update.
8943         (start_psymtab): Remove global_psymbols and static_psymbols
8944         parameters.
8945
8946 2019-01-10  Tom Tromey  <tom@tromey.com>
8947
8948         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8949         * psymtab.c (allocate_psymtab): Add comment.
8950         * psympriv.h (allocate_psymtab): Add comment.
8951         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8952         initializations.
8953         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8954
8955 2019-01-10  Tom Tromey  <tom@tromey.com>
8956
8957         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8958         Don't declare.
8959         * mipsread.c: Include mdebugread.h.
8960         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8961         Declare.
8962         * elfread.c: Include mdebugread.h.
8963
8964 2019-01-09  Tom Tromey  <tom@tromey.com>
8965
8966         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8967         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8968         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8969         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8970         (psym_lookup_symbol, psym_find_last_source_symtab)
8971         (psym_forget_cached_source_info, psym_print_stats)
8972         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8973         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8974         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8975         (psym_find_compunit_symtab_by_address)
8976         (maintenance_print_psymbols, maintenance_info_psymtabs)
8977         (maintenance_check_psymtabs): Use ranged for.
8978         * psymtab.h (class objfile_psymtabs): New.
8979         (require_partial_symbols): Return objfile_psymtabs.
8980         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8981
8982 2019-01-09  Tom Tromey  <tom@tromey.com>
8983
8984         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8985         (find_pc_mapped_section, list_overlays_command)
8986         (map_overlay_command, unmap_overlay_command)
8987         (simple_overlay_update): Use all_objfiles.
8988         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8989         * printcmd.c (info_symbol_command): Use all_objfiles.
8990         * objfiles.h (ALL_OBJSECTIONS): Remove.
8991         * maint.c (maintenance_translate_address): Use all_objfiles.
8992         * gcore.c (gcore_create_callback): Use all_objfiles.
8993         (objfile_find_memory_regions): Likewise.
8994
8995 2019-01-09  Tom Tromey  <tom@tromey.com>
8996
8997         * symtab.c (find_line_symtab, info_sources_command)
8998         (make_source_files_completion_list): Use objfile_compunits.
8999         * source.c (select_source_symtab): Use objfile_compunits.
9000         * objfiles.h (struct objfile): Update comment.
9001         (ALL_OBJFILES): Remove.
9002         (ALL_FILETABS): Remove.
9003         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9004         objfile_compunits.
9005
9006 2019-01-09  Tom Tromey  <tom@tromey.com>
9007
9008         * symmisc.c (print_objfile_statistics, dump_objfile)
9009         (maintenance_print_symbols): Use compunit_filetabs.
9010         * source.c (forget_cached_source_info_for_objfile): Use
9011         compunit_filetabs.
9012         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9013         (ALL_FILETABS): Use compunit_filetabs.
9014         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9015         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9016
9017 2019-01-09  Tom Tromey  <tom@tromey.com>
9018
9019         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9020         (compunit_filetabs): New.
9021         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9022         compunit_filetabs.
9023         (info_sources_command, make_source_files_completion_list): Remove
9024         declaration.
9025         * symmisc.c (print_objfile_statistics, dump_objfile)
9026         (maintenance_print_symbols): Remove declaration.
9027         (maintenance_info_symtabs): Use compunit_filetabs.
9028         (maintenance_info_line_tables): Likewise.
9029         * source.c (select_source_symtab): Change local variable name.
9030         (forget_cached_source_info_for_objfile): Remove declaration.
9031         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9032         * objfiles.c (objfile_relocate1): Remove declaration.
9033         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9034         declaration.
9035         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9036         * coffread.c (coff_symtab_read): Remove declaration.
9037         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9038         compunit_filetabs.
9039
9040 2019-01-09  Tom Tromey  <tom@tromey.com>
9041
9042         * symtab.c (lookup_objfile_from_block)
9043         (find_pc_sect_compunit_symtab, search_symbols)
9044         (default_collect_symbol_completion_matches_break_on): Use
9045         objfile_compunits.
9046         * objfiles.h (ALL_COMPUNITS): Remove.
9047         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9048         * cp-support.c (add_symbol_overload_list_qualified): Use
9049         objfile_compunits.
9050         * ada-lang.c (ada_collect_symbol_completion_matches)
9051         (ada_add_global_exceptions): Use objfile_compunits.
9052
9053 2019-01-09  Tom Tromey  <tom@tromey.com>
9054
9055         * source.c (select_source_symtab)
9056         (forget_cached_source_info_for_objfile): Remove declaration.
9057         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9058         declaration.
9059         * maint.c (count_symtabs_and_blocks): Remove declaration.
9060         * cp-support.c (add_symbol_overload_list_qualified): Remove
9061         declaration.
9062         * coffread.c (coff_symtab_read): Remove declaration.
9063         * symtab.c (lookup_symbol_in_objfile_symtabs)
9064         (basic_lookup_transparent_type_1): Use objfile_compunits.
9065         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9066         (info_sources_command, search_symbols)
9067         (default_collect_symbol_completion_matches_break_on)
9068         (make_source_files_completion_list): Remove declaration.
9069         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9070         (ada_collect_symbol_completion_matches)
9071         (ada_add_global_exceptions): Remove declaration.
9072         * linespec.c (iterate_over_all_matching_symtabs): Use
9073         objfile_compunits.
9074         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9075         (class objfile_compunits): New.
9076         (ALL_COMPUNITS): Use objfile_compunits.
9077         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9078         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9079         objfile_compunits.
9080         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9081
9082 2019-01-09  Tom Tromey  <tom@tromey.com>
9083
9084         * symtab.c (search_symbols)
9085         (default_collect_symbol_completion_matches_break_on): Use
9086         objfile_msymbols.
9087         * ada-lang.c (ada_lookup_simple_minsym)
9088         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9089         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9090         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9091         objfile_msymbols.
9092         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9093         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9094         * objc-lang.c (find_methods): Use objfile_msymbols.
9095         (info_selectors_command, info_classes_command): Likewise.
9096         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9097         * objfiles.h (class objfile_msymbols): New.
9098         (ALL_OBJFILE_MSYMBOLS): Remove.
9099         (ALL_MSYMBOLS): Remove.
9100
9101 2019-01-09  Tom Tromey  <tom@tromey.com>
9102
9103         * common/next-iterator.h (next_adapter): Add Iterator template
9104         parameter.
9105         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9106         (class all_objfiles_safe): New.
9107         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9108         * objfiles.c (put_objfile_before): Update comment.
9109         (add_separate_debug_objfile): Likewise.
9110         (free_all_objfiles): Use all_objfiles_safe.
9111         (objfile_purge_solibs): Likewise.
9112
9113 2019-01-09  Tom Tromey  <tom@tromey.com>
9114
9115         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9116         (expand_symtab_containing_pc, lookup_static_symbol)
9117         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9118         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9119         all_objfiles.
9120         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9121         * breakpoint.c (create_overlay_event_breakpoint)
9122         (create_longjmp_master_breakpoint)
9123         (create_std_terminate_master_breakpoint)
9124         (create_exception_master_breakpoint): Use all_objfiles.
9125         * linux-thread-db.c (try_thread_db_load_from_pdir)
9126         (has_libpthread): Use all_objfiles.
9127         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9128         * linespec.c (iterate_over_all_matching_symtabs)
9129         (search_minsyms_for_name): Use all_objfiles.
9130         * maint.c (maintenance_info_sections): Use all_objfiles.
9131         * main.c (captured_main_1): Use all_objfiles.
9132         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9133         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9134         * guile/scm-pretty-print.c
9135         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9136         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9137         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9138         (maintenance_print_msymbols): Use all_objfiles.
9139         * source.c (select_source_symtab): Use all_objfiles.
9140         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9141         * symfile.c (remove_symbol_file_command)
9142         (expand_symtabs_matching, map_symbol_filenames): Use
9143         all_objfiles.
9144         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9145         all_objfiles.
9146         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9147         * objc-lang.c (find_methods): Use all_objfiles.
9148         * objfiles.c (have_partial_symbols, have_full_symbols)
9149         (have_minimal_symbols, qsort_cmp)
9150         (default_iterate_over_objfiles_in_search_order): Use
9151         all_objfiles.
9152         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9153         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9154         (maintenance_check_psymtabs): Use all_objfiles.
9155         (ALL_PSYMTABS): Remove.
9156         * compile/compile-object-run.c (do_module_cleanup): Use
9157         all_objfiles.
9158         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9159         * cp-support.c (add_symbol_overload_list_qualified): Use
9160         all_objfiles.
9161         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9162         Use all_objfiles.
9163         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9164         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9165         all_objfiles.
9166         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9167         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9168         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9169         Uses all_objfiles.
9170         * solib.c (solib_read_symbols): Use all_objfiles
9171
9172 2019-01-09  Tom Tromey  <tom@tromey.com>
9173
9174         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9175         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9176         all_objfiles.
9177         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9178         * symmisc.c (print_symbol_bcache_statistics)
9179         (print_objfile_statistics, maintenance_print_objfiles)
9180         (maintenance_info_symtabs, maintenance_check_symtabs)
9181         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9182         all_objfiles.
9183         * source.c (forget_cached_source_info): Use all_objfiles.
9184         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9185         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9186         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9187         * objfiles.c (update_section_map): Use all_objfiles.
9188         (shared_objfile_contains_address_p): Likewise.
9189         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9190         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9191
9192 2019-01-09  Tom Tromey  <tom@tromey.com>
9193
9194         * common/next-iterator.h: New file.
9195         * objfiles.h (class all_objfiles): New.
9196         (struct objfile_iterator): New.
9197
9198 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9199
9200         * NEWS: Move the description of the changed "frame", "select-frame",
9201          and "info frame" commands to the Changed commands section.
9202
9203 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9204
9205         * gdbtypes.c (check_stub_method_group): Remove handling of old
9206         mangling schemes.
9207         * linespec.c (find_methods): Likewise.
9208         * stabsread.c (read_member_functions): Likewise.
9209         * valops.c (search_struct_method): Likewise.
9210         (value_struct_elt_for_reference): Likewise.
9211         * NEWS: Mention this change.
9212
9213 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9214
9215         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9216         print_source_lines.
9217         * source.c (print_source_lines_base): Update line number check.
9218         (print_source_lines): New function.
9219         (source_lines_range::source_lines_range): New function.
9220         * source.h (class source_lines_range): New class.
9221         (print_source_lines): New declaration.
9222
9223 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9224
9225         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9226
9227 2019-01-08  Tom Tromey  <tom@tromey.com>
9228             Simon Marchi  <simon.marchi@ericsson.com>
9229
9230         PR gdb/24060
9231         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9232         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9233         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9234         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9235         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9236         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9237
9238 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9239
9240         * source.c (select_source_symtab): Move header comment to
9241         declaration in source.h.
9242         (forget_cached_source_info_for_objfile): Likewise.
9243         (forget_cached_source_info): Likewise.
9244         (identify_source_line): Likewise.
9245         * source.h (identify_source_line): Move declaration from symtab.h
9246         and add comment from source.c
9247         (print_source_lines): Likewise.
9248         (forget_cached_source_info_for_objfile): Likewise.
9249         (forget_cached_source_info): Likewise.
9250         (select_source_symtab): Likewise.
9251         (enum print_source_lines_flag): Move definition from symtab.h.
9252         * symtab.h (identify_source_line): Move declaration to source.h.
9253         (print_source_lines): Likewise.
9254         (forget_cached_source_info_for_objfile): Likewise.
9255         (forget_cached_source_info): Likewise.
9256         (select_source_symtab): Likewise.
9257         (enum print_source_lines_flag): Move definition to source.h.
9258         * tui/tui-hooks.c: Add 'source.h' include.
9259
9260 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9261
9262         * source.c (print_source_lines_base): Handle requests to print
9263         reverse line number sequences, and guard against empty lines
9264         string.
9265
9266 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9267
9268         * source.c (print_source_lines_base): Fix skip of '\r' if next
9269         character is '\n'.
9270
9271 2019-01-06  Tom Tromey  <tom@tromey.com>
9272
9273         * c-exp.y (struct c_parse_state) <macro_original_text,
9274         expansion_obstack>: New member.
9275         (macro_original_text, expansion_obstack): Remove globals.
9276         (scan_macro_expansion, scanning_macro_expansion)
9277         (finished_macro_expansion): Update.
9278         (scan_macro_cleanup): Remove.
9279         (yylex, c_parse): Update.
9280
9281 2019-01-06  Tom Tromey  <tom@tromey.com>
9282
9283         * c-exp.y (struct c_parse_state) <strings>: New member.
9284         (operator_stoken): Update.
9285
9286 2019-01-06  Tom Tromey  <tom@tromey.com>
9287
9288         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9289         (union type_stack_elt) <typelist_val>: Now a pointer to
9290         std::vector.
9291         (type_stack_cleanup): Don't declare.
9292         (push_typelist): Update.
9293         * parse.c (pop_typelist): Return a std::vector.
9294         (push_typelist): Take a std::vector.
9295         (follow_types): Update.  Do not free args.
9296         (type_stack_cleanup): Remove.
9297         * c-exp.y (struct c_parse_state): New.
9298         (cpstate): New global.
9299         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9300         (nonempty_typelist): Update.
9301         (func_mod): Create a new vector.
9302         (c_parse): Create a c_parse_state.
9303         (check_parameter_typelist): Do not delete params.
9304         (function_method): Update.  Do not delete type_list.
9305
9306 2019-01-06  Tom Tromey  <tom@tromey.com>
9307
9308         PR gdb/28155:
9309         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9310         check_typedef.
9311         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9312         (print_return_value): Likewise.
9313
9314 2019-01-05  Tom Tromey  <tom@tromey.com>
9315
9316         * contrib/cleanup_check.py: Remove.
9317         * contrib/gcc-with-excheck: Remove.
9318         * contrib/exsummary.py: Remove.
9319         * contrib/excheck.py: Remove.
9320
9321 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9322
9323         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9324         NULL. Initialize tpprev to NULL instead of assigning it
9325         to NULL on the next statement.
9326         * windows-nat.c (windows_delete_thread): Remove check for
9327         main_thread_id before printing thread exit notifications.
9328         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9329         Remove thread ID check against main_thread_id.
9330         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9331         windows_delete_thread.
9332         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9333
9334 2019-01-04  Tom Tromey  <tom@tromey.com>
9335
9336         * compile/compile.c (_initialize_compile): Use upper case for
9337         metasyntactic variables.
9338         * symmisc.c (_initialize_symmisc): Use upper case for
9339         metasyntactic variables.
9340         * psymtab.c (_initialize_psymtab): Use upper case for
9341         metasyntactic variables.
9342         * demangle.c (demangle_command): Use upper case for metasyntactic
9343         variables.
9344         (_initialize_demangler): Likewise.
9345         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9346         variables.
9347
9348 2019-01-03  Tom Tromey  <tom@tromey.com>
9349
9350         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9351
9352 2019-01-03  Tom Tromey  <tom@tromey.com>
9353
9354         * python/py-symtab.c (salpy_str): Update.
9355         (struct salpy_sal_object) <symtab>: Now a PyObject.
9356         (salpy_dealloc): Update.
9357         (del_objfile_sal): Use gdbpy_ref.
9358
9359 2019-01-03  Tom Tromey  <tom@tromey.com>
9360
9361         * python/py-type.c (convert_field): Use new_reference.  Return
9362         gdbpy_ref.
9363         (make_fielditem): Return gdbpy_ref.
9364         (typy_fields): Update.
9365         (typy_getitem): Update.
9366         (field_name): Return gdbpy_ref.  Use new_reference.
9367         (typy_iterator_iternext): Update.
9368
9369 2019-01-03  Tom Tromey  <tom@tromey.com>
9370
9371         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9372
9373 2019-01-03  Tom Tromey  <tom@tromey.com>
9374
9375         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9376         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9377         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9378         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9379         (pspy_set_type_printers): Likewise.
9380         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9381         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9382         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9383         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9384         (objfpy_set_type_printers): Likewise.
9385
9386 2019-01-03  Tom Tromey  <tom@tromey.com>
9387
9388         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9389         (gdbpy_print_stack): Use gdbpy_err_fetch.
9390         * python/python-internal.h (class gdbpy_err_fetch): New class.
9391         (class gdbpy_enter) <m_error_type, m_error_value,
9392         m_error_traceback>: Remove.
9393         <m_error>: New member.
9394         (gdbpy_exception_to_string): Don't declare.
9395         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9396         * python/py-value.c (convert_value_from_python): Use
9397         gdbpy_err_fetch.
9398         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9399         gdbpy_exception_to_string.
9400         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9401         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9402         gdbpy_err_fetch.
9403
9404 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9405
9406         * linux-nat.c (delete_lwp_cleanup): Delete.
9407         (struct lwp_deleter): New struct.
9408         (lwp_info_up): New typedef.
9409         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9410         lwp_info_up.
9411
9412 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9413
9414         * linux-fork.c (class scoped_switch_fork_info): New class.
9415         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9416
9417 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9418
9419         * valops.c (find_overload_match): Remove use of null_cleanup, and
9420         calls to do_cleanups.
9421
9422 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9423
9424         * compile/compile-cplus-types.c
9425         (compile_cplus_instance::decl_name): Handle changes to
9426         cp_func_name.
9427         * cp-support.c (cp_func_name): Update header comment, update
9428         return type.
9429         * cp-support.h (cp_func_name): Update return type in declaration.
9430         * valops.c (find_overload_match): Move temp_func local to top
9431         level of function and change its type.  Use temp_func to hold and
9432         delete temporary string obtained from cp_func_name.
9433
9434 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9435
9436         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9437         gdb::char_vector, remove cleanup, and update uses of `msg`.
9438
9439 2019-01-03  Jim Wilson  <jimw@sifive.com>
9440
9441         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9442
9443 2019-01-02  Tom Tromey  <tom@tromey.com>
9444
9445         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9446         (tdesc_parse_xml): Remove cleanups.
9447         * target-descriptions.h (make_cleanup_free_target_description):
9448         Don't declare.
9449         (target_desc_deleter): New struct.
9450         (target_desc_up): New typedef.
9451         * target-descriptions.c (target_desc_deleter::operator()): Rename
9452         from free_target_description.
9453         (make_cleanup_free_target_description): Remove.
9454
9455 2019-01-02  Tom Tromey  <tom@tromey.com>
9456
9457         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9458         constructor, destructor.
9459         (linespec_parser): Remove typedef.
9460         (~linespec_parser): Rename from linespec_parser_delete.
9461         (linespec_lex_to_end, linespec_complete_label)
9462         (linespec_complete): Update.
9463         (decode_line_full): Remove cleanups.
9464         (decode_line_1): Update.
9465
9466 2019-01-02  Tom Tromey  <tom@tromey.com>
9467
9468         * python/python-internal.h (inferior_to_inferior_object): Change
9469         return type.
9470         * python/py-exitedevent.c (create_exited_event_object): Update.
9471         * python/py-inferior.c (inferior_to_inferior_object): Return
9472         gdbpy_ref.
9473         (python_new_inferior, python_inferior_deleted)
9474         (thread_to_thread_object, delete_thread_object)
9475         (build_inferior_list, gdbpy_selected_inferior): Update.
9476         * python/py-infthread.c (create_thread_object): Update.  Also fail
9477         if inferior_to_inferior_object fails.
9478
9479 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9480
9481         * inferior.h (class inferior) <displaced_step_state>: New field.
9482         * infrun.h (struct displaced_step_state): Move here from
9483         infrun.c.  Initialize fields, add constructor.
9484         <inf>: Remove field.
9485         <reset>: New method.
9486         * infrun.c (struct displaced_step_inferior_state): Move to
9487         infrun.h.
9488         (displaced_step_inferior_states): Remove.
9489         (get_displaced_stepping_state): Adust.
9490         (displaced_step_in_progress_any_inferior): Adjust.
9491         (displaced_step_in_progress_thread): Adjust.
9492         (displaced_step_in_progress): Adjust.
9493         (add_displaced_stepping_state): Remove.
9494         (get_displaced_step_closure_by_addr): Adjust.
9495         (remove_displaced_stepping_state): Remove.
9496         (infrun_inferior_exit): Call displaced_step_state.reset.
9497         (use_displaced_stepping): Don't check for NULL.
9498         (displaced_step_prepare_throw): Call
9499         get_displaced_stepping_state.
9500         (displaced_step_fixup): Don't check for NULL.
9501         (prepare_for_detach): Don't check for NULL.
9502
9503 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9504
9505         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9506          in case of call that did not complete.
9507
9508 2019-01-02  Andrey Utkin  <autkin@undo.io>
9509
9510         * symfile.c (find_separate_debug_file): Fix search of debug files for
9511         remote debuggee.
9512
9513 2019-01-02  Tom Tromey  <tom@tromey.com>
9514
9515         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9516         indentation.
9517         * python/py-frame.c (frapy_older): Remove cast.
9518         (frapy_newer): Likewise.
9519         * python/py-breakpoint.c (local_setattro): Remove cast.
9520         * python/py-arch.c (archpy_name): Remove local variable.
9521         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9522
9523 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9524
9525         * unittests/basic_string_view/element_access/char/empty.cc:
9526         Fix year range in copyright header.
9527
9528 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9529
9530         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9531         Delete.
9532         <operator==>: Update with for removed field.
9533         <hash>: Likewise.
9534         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9535         <isa_features>: ...this.
9536         <abi_features>: New field.
9537         (riscv_isa_flen): Update comment.
9538         (riscv_abi_xlen): New declaration.
9539         (riscv_abi_flen): New declaration.
9540         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9541         isa_features.
9542         (riscv_abi_xlen): New function.
9543         (riscv_isa_flen): Update to get answer from isa_features.
9544         (riscv_abi_flen): New function.
9545         (riscv_has_fp_abi): Update to get answer from abi_features.
9546         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9547         xlen and flen.
9548         (riscv_call_info) <xlen, flen>: Update comment.
9549         (riscv_call_arg_struct): Remove invalid assertions
9550         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9551         is removed.
9552         (riscv_gdbarch_init): Gather isa features and abi features
9553         separately, ensure both match on the gdbarch when reusing an old
9554         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9555         a target with 64-bit float hardware.
9556
9557 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9558
9559         * source.c (search_command_helper): Stop reverse search
9560         when line 1 has been searched.
9561
9562 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9563
9564         * record-full.c (record_full_base_target::close): Rewrite
9565         record_full_core_buf_list free logic.
9566
9567 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9568
9569         * break-catch-syscall.c (print_one_catch_syscall): xfree
9570         the last text.
9571
9572 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9573
9574         * top.c (print_gdb_version): Update Copyright year in version
9575         message.
9576
9577 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9578
9579         Update copyright year range in all GDB files.
9580
9581 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9582
9583         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9584
9585 For older changes see ChangeLog-2018.
9586 \f
9587 Local Variables:
9588 mode: change-log
9589 left-margin: 8
9590 fill-column: 74
9591 version-control: never
9592 coding: utf-8
9593 End:
9594