Fix "nosharedlibrary + continue + shared lib event" crash
[external/binutils.git] / gdb / ChangeLog
1 2019-04-22  Pedro Alves  <palves@redhat.com>
2
3         * solib-svr4.c (svr4_free_objfile_observer): New.
4         (probe_and_action::objfile): New field.
5         (probes_table_htab_remove_objfile_probes)
6         (probes_table_remove_objfile_probes): New functions.
7         (register_solib_event_probe): Add 'objfile' parameter.  Store it
8         in the new probe_and_action.  Don't store the probe in 'lookup'.
9         (svr4_create_probe_breakpoints): Pass objfile to
10         register_solib_event_probe.
11         (_initialize_svr4_solib): Register a free_objfile observer.
12
13 2019-04-19  Tom Tromey  <tom@tromey.com>
14
15         * common/queue.h: Remove.
16
17 2019-04-19  Tom Tromey  <tom@tromey.com>
18
19         * event-loop.c: Don't include "common/queue.h".
20
21 2019-04-19  Tom Tromey  <tom@tromey.com>
22
23         * remote.c (remote_target): Use delete.
24         * remote-notif.h: Include <list>, not "common/queue.h".
25         (notif_client_p): Remove typedef.
26         (remote_notif_state): Add constructor, destructor, initializer.
27         <notif_queue>: Now a std::list.
28         (remote_notif_state_xfree): Don't declare.
29         * remote-notif.c (remote_notif_process, handle_notification)
30         (remote_notif_state_allocate): Update.
31         (~remote_notif_state): Rename from remote_notif_state_xfree.
32
33 2019-04-19  Tom Tromey  <tom@tromey.com>
34
35         * symfile.c (reread_symbols): Update.
36         * objfiles.c (objfile_register_static_link)
37         (objfile_lookup_static_link): Update
38         (~objfile) Don't delete static_links.
39         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
40
41 2019-04-19  Tom Tromey  <tom@tromey.com>
42
43         * type-stack.h (struct type_stack) <insert>: Constify string.
44         * type-stack.c (type_stack::insert): Constify string.
45         * gdbtypes.h (lookup_template_type): Update.
46         (address_space_name_to_int): Update.
47         * gdbtypes.c (address_space_name_to_int): Make space_identifier
48         const.
49         (lookup_template_type): Make name const.
50         * c-exp.y: Update rules.
51         (lex_one_token, classify_name, classify_inner_name)
52         (c_print_token): Update.
53         * p-exp.y: Update rules.
54         (yylex): Update.
55         * f-exp.y: Update rules.
56         (yylex): Update.
57         * d-exp.y: Update rules.
58         (lex_one_token, classify_name, classify_inner_name): Update.
59         * parse.c (write_dollar_variable, copy_name): Return std::string.
60         * parser-defs.h (copy_name): Change return type.
61         * m2-exp.y: Update rules.
62         (yylex): Update.
63         * go-exp.y (lex_one_token): Update.
64         Update rules.
65         (classify_unsafe_function, classify_packaged_name)
66         (classify_name, yylex): Update.
67
68 2019-04-19  Sergei Trofimovich <siarheit@google.com>
69
70         * configure.ac: add --enable-source-highlight switch.
71         * configure: Regenerate.
72         * top.c (print_gdb_version): plumb --enable-source-highlight
73         status to "show configuration".
74
75 2019-04-19  Tom Tromey  <tromey@adacore.com>
76
77         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
78         Check ADA_TYPE_P.
79         (empty_record, ada_template_to_fixed_record_type_1)
80         (template_to_static_fixed_type)
81         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
82         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
83         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
84         macros.
85
86 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
87
88         PR symtab/24423:
89         * source.c (print_source_lines_base): Advance "iter" when a
90         control character is seen.
91
92 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
93
94         * inferior.h (struct infcall_suspend_state_deleter):
95         Catch exception in destructor to avoid crash.
96
97 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
98
99         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
100         close to the add_com "shell".
101
102 2019-04-18  Tom Tromey  <tromey@adacore.com>
103
104         * process-stratum-target.h (class process_stratum_target)
105         <stratum>: Add "final".
106
107 2019-04-17  Tom Tromey  <tromey@adacore.com>
108
109         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
110         against nullptr before use.
111
112 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
113
114         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
115
116 2019-04-17  Jim Wilson  <jimw@sifive.com>
117             Andrew Burgess  <andrew.burgess@embecosm.com>
118
119         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
120         code read might fail, assume 4-byte breakpoint in that case.
121
122 2019-04-15  Leszek Swirski  <leszeks@google.com>
123
124         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
125         rather than a hand-rolled POD check when checking for forced MEMORY
126         classification.
127
128 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
129
130         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
131         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
132         function.
133         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
134         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
135         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
136         declaration.
137
138 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
139
140         * aarch64-linux-nat.c
141         (aarch64_linux_nat_target::thread_architecture): Add override.
142         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
143         each VQ.
144
145 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
146
147         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
148
149 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
150
151         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
152         target types of size 96-bits, add some additional comments, and
153         check that the builtin type we found was the correct size.
154
155 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
156
157         * utils.c (prompt_for_continue): Don't restore the styling at the
158         end, as applied_style has the wrong value.  This fixes styling in
159         long lists of file names that are interrupted by the "Continue?"
160         prompt.
161
162 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
163
164         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
165         * c-lang.c (c_language_defn): Likewise.
166         (cplus_language_defn): Likewise.
167         (asm_language_defn): Likewise.
168         (minimal_language_defn): Likewise.
169         * d-lang.c (d_language_defn): Likewise.
170         * f-lang.c (f_language_defn): Likewise.
171         * go-lang.c (go_language_defn): Likewise.
172         * language.c (unknown_language_defn): Likewise.
173         (auto_language_defn): Likewise.
174         * language.h (struct language_defn): Remove la_magic field.
175         (LANG_MAGIC): Delete.
176         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
177         * objc-lang.c (objc_language_defn): Likewise.
178         * opencl-lang.c (opencl_language_defn): Likewise.
179         * p-lang.c (pascal_language_defn): Likewise.
180         * rust-lang.c (rust_language_defn): Likewise.
181
182 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
183
184         * riscv-tdep.c (riscv_type_align): New function.
185         (riscv_type_alignment): Delete.
186         (riscv_arg_location): Use 'type_align'.
187         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
188
189 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
190
191         * gdbtypes.c (type_align): A struct with no non-static fields also
192         has alignment of 1.
193
194 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
195
196         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
197         component to 0.
198         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
199         member.
200         (riscv_struct_info::analyse): New implementation using new
201         analyse_inner member function.
202         (riscv_struct_info::field_offset): New member function.
203         (riscv_struct_info::m_offsets): New member variable.
204         (riscv_struct_info::analyse_inner): New private member function,
205         takes the old implementation of riscv_struct_info::analyse but
206         extended to track field offsets.
207         (riscv_call_arg_struct): Update the struct folding special cases
208         to handle cases where empty C++ structs, which are non-zero
209         length, are found.
210         (riscv_arg_location): Initialise the length of each location, a
211         non-zero length now indicates the location is in use.
212         (riscv_push_dummy_call): Allow for the first location having a
213         non-zero offset when setting up arguments.
214         (riscv_return_value): Likewise, but for return values.
215
216 2019-04-11  Tom Tromey  <tromey@adacore.com>
217
218         * utils.c (internal_vproblem): Make "msg" const.
219
220 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
221
222         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
223         * trad-frame.c (trad_frame_reset_saved_regs): New function.
224         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
225         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
226
227 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
228
229         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
230         function.
231         (fill_gregset): Call amd64_linux_collect_native_gregset instead
232         of amd64_collect_native_gregset.
233         (amd64_linux_nat_target::store_registers): Likewise.
234
235 2019-04-10  Tom Tromey  <tom@tromey.com>
236
237         * symtab.c (lookup_global_symbol_from_objfile)
238         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
239         * objfiles.h (class separate_debug_iterator): New.
240         (class separate_debug_range): New.
241         (struct objfile) <separate_debug_objfiles>: New method.
242         (objfile_separate_debug_iterate): Don't declare.
243         * objfiles.c (separate_debug_iterator::operator++): Rename from
244         objfile_separate_debug_iterate.
245         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
246         iterator.
247         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
248         iterator.
249
250 2019-04-10  Tom Tromey  <tom@tromey.com>
251
252         * symfile.c (reread_symbols): Remove old comment.
253         * objfiles.c (free_all_objfiles): Fix a typo.
254
255 2019-04-10  Tom Tromey  <tom@tromey.com>
256
257         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
258         * minsyms.c (lookup_minimal_symbol): Use foreach.
259         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
260         (lookup_minimal_symbol_solib_trampoline): Likewise.
261         * symfile.c (reread_symbols): Use foreach.
262
263 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
264             Tom Tromey  <tromey@adacore.com>
265
266         PR rust/24414:
267         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
268         (rust_lex_int_test): Change "value" to be LONGEST.
269         (rust_lex_tests): Add test for long integer literal.
270
271 2019-04-09  Tom Tromey  <tromey@adacore.com>
272
273         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
274         to bool.
275         (extended_remote_target::attach): Update.
276         (remote_target::remote_notice_new_inferior): Update.
277         (remote_target::add_current_inferior_and_thread): Update.
278         * inferior.c (exit_inferior_1): Use "false".
279         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
280
281 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
282
283         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
284         the "start" command.
285
286 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
287
288         * python/py-inferior.c (infpy_thread_from_thread_handle):
289         Adjust comments to reflect renaming of thread_from_thread_handle
290         to thread_from_handle.  Adjust keywords.  Fix type error message.
291         (inferior_object_methods): Add thread_from_handle.  Retain
292         thread_from_thread_handle, but mark it as deprecated.
293
294 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
295
296         * gdbthread.h (find_thread_by_handle): Revise declaration.
297         * thread.c (find_thread_by_handle): Likewise.  Adjust
298         implementation too.
299         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
300         support for buffer objects as handles.
301
302 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
303
304         * python/py-infthread.c (thpy_thread_handle): New function.
305         (thread_object_methods): Register thpy_thread_handle.
306
307 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
308
309         * gdbthread.h (thread_to_thread_handle): Declare.
310         * thread.c (gdbtypes.h): Include.
311         (thread_to_thread_handle): New function.
312
313         * target.h (struct target_ops): Add thread_info_to_thread_handle.
314         (target_thread_info_to_thread_handle): Declare.
315         * target.c (target_thread_info_to_thread_handle): New function.
316         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
317         * target-delegates.c: Regenerate.
318
319         * linux-thread-db.c (class thread_db_target): Add method
320         thread_info_to_thread_handle.
321         (thread_db_target::thread_info_to_thread_handle): Define.
322         * remote.c (class remote_target): Add new method
323         thread_info_to_thread_handle.
324         (remote_target::thread_info_to_thread_handle): Define.
325
326 2019-04-08  Pedro Alves  <palves@redhat.com>
327
328         * common/common-exceptions.c (throw_exception): Don't create
329         named object to throw; throw directly.
330         (throw_it): Likewise.  Don't initialize gdb_exception::message
331         here, with new; pass FMT and AP to the ctor instead.
332         * common/common-exceptions.h: Include <string>.
333         (gdb_exception::gdb_exception(enum return_reason, enum errors,
334         const char *, va_list)): New ctor.  Use std::make_shared.
335         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
336         errors)): Delete.
337         (gdb_exception_error::gdb_exception_error(enum errors, const char
338         *, va_list)): New.
339         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
340         Add assertion.
341         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
342         errors)): Delete.
343         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
344         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
345         Add assertion.
346
347 2019-04-08  Tom Tromey  <tom@tromey.com>
348
349         * valops.c (value_rtti_indirect_type): Replace throw_exception
350         with throw.
351         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
352         with throw.
353         * thread.c (thr_try_catch_cmd): Replace throw_exception with
354         throw.
355         * target.c (target_translate_tls_address): Replace throw_exception
356         with throw.
357         * stack.c (frame_apply_command_count): Replace throw_exception
358         with throw.
359         * solib-spu.c (append_ocl_sos): Replace throw_exception with
360         throw.
361         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
362         with throw.
363         * rs6000-tdep.c (rs6000_frame_cache)
364         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
365         * remote.c: Replace throw_exception with throw.
366         * record-full.c (record_full_message, record_full_wait_1)
367         (record_full_restore): Replace throw_exception with throw.
368         * record-btrace.c:
369         (get_thread_current_frame_id, record_btrace_start_replaying)
370         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
371         (cmd_record_btrace_start): Replace throw_exception with throw.
372         * parse.c (parse_exp_in_context_1): Replace throw_exception with
373         throw.
374         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
375         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
376         * linespec.c:
377         (find_linespec_symbols): Replace throw_exception with throw.
378         * infrun.c (displaced_step_prepare, resume): Replace
379         throw_exception with throw.
380         * infcmd.c (post_create_inferior): Replace throw_exception with
381         throw.
382         * inf-loop.c (inferior_event_handler): Replace throw_exception
383         with throw.
384         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
385         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
386         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
387         (get_prev_frame_always, get_frame_pc_if_available)
388         (get_frame_address_in_block_if_available, get_frame_language):
389         Replace throw_exception with throw.
390         * frame-unwind.c (frame_unwind_try_unwinder): Replace
391         throw_exception with throw.
392         * eval.c (fetch_subexp_value, evaluate_var_value)
393         (evaluate_funcall, evaluate_subexp_standard): Replace
394         throw_exception with throw.
395         * dwarf2loc.c (call_site_find_chain)
396         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
397         Replace throw_exception with throw.
398         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
399         with throw.
400         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
401         throw.
402         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
403         * completer.c (complete_line_internal): Replace throw_exception
404         with throw.
405         * compile/compile-object-run.c (compile_object_run): Replace
406         throw_exception with throw.
407         * cli/cli-script.c (process_next_line): Replace throw_exception
408         with throw.
409         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
410         (btrace_enable, btrace_maint_update_pt_packets): Replace
411         throw_exception with throw.
412         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
413         throw_exception with throw.
414         * break-catch-throw.c (re_set_exception_catchpoint): Replace
415         throw_exception with throw.
416         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
417         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
418         * aarch64-tdep.c (aarch64_make_prologue_cache)
419         (aarch64_make_stub_cache): Replace throw_exception with throw.
420
421 2019-04-08  Tom Tromey  <tom@tromey.com>
422
423         * common/common-exceptions.c (throw_exception): Rename from
424         throw_exception_cxx.  Remove old copy.  Make argument const.
425         (throw_it): Create and throw exception objects directly.
426         * common/common-exceptions.h (throw_exception): Make argument
427         const.
428         (struct gdb_exception_error): Add constructor.
429         (struct gdb_exception_quit): Add constructor.
430
431 2019-04-08  Tom Tromey  <tom@tromey.com>
432
433         * common/common-exceptions.h (exception_rethrow): Don't declare.
434         (TRY_SJLJ): Update comment.
435         (TRY, CATCH, END_CATCH): Remove.
436         * common/common-exceptions.c (exception_rethrow): Remove.
437
438 2019-04-08  Tom Tromey  <tom@tromey.com>
439
440         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
441         Remove.
442         (gdb_exception_error): Rename from
443         gdb_exception_RETURN_MASK_ERROR.
444         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
445         (gdb_quit_bad_alloc): Update.
446         * aarch64-tdep.c: Update.
447         * ada-lang.c: Update.
448         * ada-typeprint.c: Update.
449         * ada-valprint.c: Update.
450         * amd64-tdep.c: Update.
451         * arch-utils.c: Update.
452         * break-catch-throw.c: Update.
453         * breakpoint.c: Update.
454         * btrace.c: Update.
455         * c-varobj.c: Update.
456         * cli/cli-cmds.c: Update.
457         * cli/cli-interp.c: Update.
458         * cli/cli-script.c: Update.
459         * common/common-exceptions.c: Update.
460         * common/new-op.c: Update.
461         * common/selftest.c: Update.
462         * compile/compile-c-symbols.c: Update.
463         * compile/compile-cplus-symbols.c: Update.
464         * compile/compile-object-load.c: Update.
465         * compile/compile-object-run.c: Update.
466         * completer.c: Update.
467         * corelow.c: Update.
468         * cp-abi.c: Update.
469         * cp-support.c: Update.
470         * cp-valprint.c: Update.
471         * darwin-nat.c: Update.
472         * disasm-selftests.c: Update.
473         * dtrace-probe.c: Update.
474         * dwarf-index-cache.c: Update.
475         * dwarf-index-write.c: Update.
476         * dwarf2-frame-tailcall.c: Update.
477         * dwarf2-frame.c: Update.
478         * dwarf2loc.c: Update.
479         * dwarf2read.c: Update.
480         * eval.c: Update.
481         * event-loop.c: Update.
482         * event-top.c: Update.
483         * exec.c: Update.
484         * f-valprint.c: Update.
485         * fbsd-tdep.c: Update.
486         * frame-unwind.c: Update.
487         * frame.c: Update.
488         * gdbtypes.c: Update.
489         * gnu-v3-abi.c: Update.
490         * guile/guile-internal.h: Update.
491         * guile/scm-block.c: Update.
492         * guile/scm-breakpoint.c: Update.
493         * guile/scm-cmd.c: Update.
494         * guile/scm-disasm.c: Update.
495         * guile/scm-frame.c: Update.
496         * guile/scm-lazy-string.c: Update.
497         * guile/scm-math.c: Update.
498         * guile/scm-param.c: Update.
499         * guile/scm-ports.c: Update.
500         * guile/scm-pretty-print.c: Update.
501         * guile/scm-symbol.c: Update.
502         * guile/scm-symtab.c: Update.
503         * guile/scm-type.c: Update.
504         * guile/scm-value.c: Update.
505         * i386-linux-tdep.c: Update.
506         * i386-tdep.c: Update.
507         * inf-loop.c: Update.
508         * infcall.c: Update.
509         * infcmd.c: Update.
510         * infrun.c: Update.
511         * jit.c: Update.
512         * language.c: Update.
513         * linespec.c: Update.
514         * linux-fork.c: Update.
515         * linux-nat.c: Update.
516         * linux-tdep.c: Update.
517         * linux-thread-db.c: Update.
518         * main.c: Update.
519         * mi/mi-cmd-break.c: Update.
520         * mi/mi-cmd-stack.c: Update.
521         * mi/mi-interp.c: Update.
522         * mi/mi-main.c: Update.
523         * objc-lang.c: Update.
524         * p-valprint.c: Update.
525         * parse.c: Update.
526         * ppc-linux-tdep.c: Update.
527         * printcmd.c: Update.
528         * python/py-arch.c: Update.
529         * python/py-breakpoint.c: Update.
530         * python/py-cmd.c: Update.
531         * python/py-finishbreakpoint.c: Update.
532         * python/py-frame.c: Update.
533         * python/py-framefilter.c: Update.
534         * python/py-gdb-readline.c: Update.
535         * python/py-inferior.c: Update.
536         * python/py-infthread.c: Update.
537         * python/py-lazy-string.c: Update.
538         * python/py-linetable.c: Update.
539         * python/py-objfile.c: Update.
540         * python/py-param.c: Update.
541         * python/py-prettyprint.c: Update.
542         * python/py-progspace.c: Update.
543         * python/py-record-btrace.c: Update.
544         * python/py-record.c: Update.
545         * python/py-symbol.c: Update.
546         * python/py-type.c: Update.
547         * python/py-unwind.c: Update.
548         * python/py-utils.c: Update.
549         * python/py-value.c: Update.
550         * python/python.c: Update.
551         * record-btrace.c: Update.
552         * record-full.c: Update.
553         * remote-fileio.c: Update.
554         * remote.c: Update.
555         * riscv-tdep.c: Update.
556         * rs6000-aix-tdep.c: Update.
557         * rs6000-tdep.c: Update.
558         * rust-exp.y: Update.
559         * rust-lang.c: Update.
560         * s390-tdep.c: Update.
561         * selftest-arch.c: Update.
562         * solib-dsbt.c: Update.
563         * solib-frv.c: Update.
564         * solib-spu.c: Update.
565         * solib-svr4.c: Update.
566         * solib.c: Update.
567         * sparc64-linux-tdep.c: Update.
568         * stack.c: Update.
569         * symfile-mem.c: Update.
570         * symmisc.c: Update.
571         * target.c: Update.
572         * thread.c: Update.
573         * top.c: Update.
574         * tracefile-tfile.c: Update.
575         * tui/tui.c: Update.
576         * typeprint.c: Update.
577         * unittests/cli-utils-selftests.c: Update.
578         * unittests/parse-connection-spec-selftests.c: Update.
579         * valops.c: Update.
580         * valprint.c: Update.
581         * value.c: Update.
582         * varobj.c: Update.
583         * windows-nat.c: Update.
584         * x86-linux-nat.c: Update.
585         * xml-support.c: Update.
586
587 2019-04-08  Tom Tromey  <tom@tromey.com>
588
589         * xml-support.c: Use C++ exception handling.
590         * x86-linux-nat.c: Use C++ exception handling.
591         * windows-nat.c: Use C++ exception handling.
592         * varobj.c: Use C++ exception handling.
593         * value.c: Use C++ exception handling.
594         * valprint.c: Use C++ exception handling.
595         * valops.c: Use C++ exception handling.
596         * unittests/parse-connection-spec-selftests.c: Use C++ exception
597         handling.
598         * unittests/cli-utils-selftests.c: Use C++ exception handling.
599         * typeprint.c: Use C++ exception handling.
600         * tui/tui.c: Use C++ exception handling.
601         * tracefile-tfile.c: Use C++ exception handling.
602         * top.c: Use C++ exception handling.
603         * thread.c: Use C++ exception handling.
604         * target.c: Use C++ exception handling.
605         * symmisc.c: Use C++ exception handling.
606         * symfile-mem.c: Use C++ exception handling.
607         * stack.c: Use C++ exception handling.
608         * sparc64-linux-tdep.c: Use C++ exception handling.
609         * solib.c: Use C++ exception handling.
610         * solib-svr4.c: Use C++ exception handling.
611         * solib-spu.c: Use C++ exception handling.
612         * solib-frv.c: Use C++ exception handling.
613         * solib-dsbt.c: Use C++ exception handling.
614         * selftest-arch.c: Use C++ exception handling.
615         * s390-tdep.c: Use C++ exception handling.
616         * rust-lang.c: Use C++ exception handling.
617         * rust-exp.y: Use C++ exception handling.
618         * rs6000-tdep.c: Use C++ exception handling.
619         * rs6000-aix-tdep.c: Use C++ exception handling.
620         * riscv-tdep.c: Use C++ exception handling.
621         * remote.c: Use C++ exception handling.
622         * remote-fileio.c: Use C++ exception handling.
623         * record-full.c: Use C++ exception handling.
624         * record-btrace.c: Use C++ exception handling.
625         * python/python.c: Use C++ exception handling.
626         * python/py-value.c: Use C++ exception handling.
627         * python/py-utils.c: Use C++ exception handling.
628         * python/py-unwind.c: Use C++ exception handling.
629         * python/py-type.c: Use C++ exception handling.
630         * python/py-symbol.c: Use C++ exception handling.
631         * python/py-record.c: Use C++ exception handling.
632         * python/py-record-btrace.c: Use C++ exception handling.
633         * python/py-progspace.c: Use C++ exception handling.
634         * python/py-prettyprint.c: Use C++ exception handling.
635         * python/py-param.c: Use C++ exception handling.
636         * python/py-objfile.c: Use C++ exception handling.
637         * python/py-linetable.c: Use C++ exception handling.
638         * python/py-lazy-string.c: Use C++ exception handling.
639         * python/py-infthread.c: Use C++ exception handling.
640         * python/py-inferior.c: Use C++ exception handling.
641         * python/py-gdb-readline.c: Use C++ exception handling.
642         * python/py-framefilter.c: Use C++ exception handling.
643         * python/py-frame.c: Use C++ exception handling.
644         * python/py-finishbreakpoint.c: Use C++ exception handling.
645         * python/py-cmd.c: Use C++ exception handling.
646         * python/py-breakpoint.c: Use C++ exception handling.
647         * python/py-arch.c: Use C++ exception handling.
648         * printcmd.c: Use C++ exception handling.
649         * ppc-linux-tdep.c: Use C++ exception handling.
650         * parse.c: Use C++ exception handling.
651         * p-valprint.c: Use C++ exception handling.
652         * objc-lang.c: Use C++ exception handling.
653         * mi/mi-main.c: Use C++ exception handling.
654         * mi/mi-interp.c: Use C++ exception handling.
655         * mi/mi-cmd-stack.c: Use C++ exception handling.
656         * mi/mi-cmd-break.c: Use C++ exception handling.
657         * main.c: Use C++ exception handling.
658         * linux-thread-db.c: Use C++ exception handling.
659         * linux-tdep.c: Use C++ exception handling.
660         * linux-nat.c: Use C++ exception handling.
661         * linux-fork.c: Use C++ exception handling.
662         * linespec.c: Use C++ exception handling.
663         * language.c: Use C++ exception handling.
664         * jit.c: Use C++ exception handling.
665         * infrun.c: Use C++ exception handling.
666         * infcmd.c: Use C++ exception handling.
667         * infcall.c: Use C++ exception handling.
668         * inf-loop.c: Use C++ exception handling.
669         * i386-tdep.c: Use C++ exception handling.
670         * i386-linux-tdep.c: Use C++ exception handling.
671         * guile/scm-value.c: Use C++ exception handling.
672         * guile/scm-type.c: Use C++ exception handling.
673         * guile/scm-symtab.c: Use C++ exception handling.
674         * guile/scm-symbol.c: Use C++ exception handling.
675         * guile/scm-pretty-print.c: Use C++ exception handling.
676         * guile/scm-ports.c: Use C++ exception handling.
677         * guile/scm-param.c: Use C++ exception handling.
678         * guile/scm-math.c: Use C++ exception handling.
679         * guile/scm-lazy-string.c: Use C++ exception handling.
680         * guile/scm-frame.c: Use C++ exception handling.
681         * guile/scm-disasm.c: Use C++ exception handling.
682         * guile/scm-cmd.c: Use C++ exception handling.
683         * guile/scm-breakpoint.c: Use C++ exception handling.
684         * guile/scm-block.c: Use C++ exception handling.
685         * guile/guile-internal.h: Use C++ exception handling.
686         * gnu-v3-abi.c: Use C++ exception handling.
687         * gdbtypes.c: Use C++ exception handling.
688         * frame.c: Use C++ exception handling.
689         * frame-unwind.c: Use C++ exception handling.
690         * fbsd-tdep.c: Use C++ exception handling.
691         * f-valprint.c: Use C++ exception handling.
692         * exec.c: Use C++ exception handling.
693         * event-top.c: Use C++ exception handling.
694         * event-loop.c: Use C++ exception handling.
695         * eval.c: Use C++ exception handling.
696         * dwarf2read.c: Use C++ exception handling.
697         * dwarf2loc.c: Use C++ exception handling.
698         * dwarf2-frame.c: Use C++ exception handling.
699         * dwarf2-frame-tailcall.c: Use C++ exception handling.
700         * dwarf-index-write.c: Use C++ exception handling.
701         * dwarf-index-cache.c: Use C++ exception handling.
702         * dtrace-probe.c: Use C++ exception handling.
703         * disasm-selftests.c: Use C++ exception handling.
704         * darwin-nat.c: Use C++ exception handling.
705         * cp-valprint.c: Use C++ exception handling.
706         * cp-support.c: Use C++ exception handling.
707         * cp-abi.c: Use C++ exception handling.
708         * corelow.c: Use C++ exception handling.
709         * completer.c: Use C++ exception handling.
710         * compile/compile-object-run.c: Use C++ exception handling.
711         * compile/compile-object-load.c: Use C++ exception handling.
712         * compile/compile-cplus-symbols.c: Use C++ exception handling.
713         * compile/compile-c-symbols.c: Use C++ exception handling.
714         * common/selftest.c: Use C++ exception handling.
715         * common/new-op.c: Use C++ exception handling.
716         * cli/cli-script.c: Use C++ exception handling.
717         * cli/cli-interp.c: Use C++ exception handling.
718         * cli/cli-cmds.c: Use C++ exception handling.
719         * c-varobj.c: Use C++ exception handling.
720         * btrace.c: Use C++ exception handling.
721         * breakpoint.c: Use C++ exception handling.
722         * break-catch-throw.c: Use C++ exception handling.
723         * arch-utils.c: Use C++ exception handling.
724         * amd64-tdep.c: Use C++ exception handling.
725         * ada-valprint.c: Use C++ exception handling.
726         * ada-typeprint.c: Use C++ exception handling.
727         * ada-lang.c: Use C++ exception handling.
728         * aarch64-tdep.c: Use C++ exception handling.
729
730 2019-04-08  Tom Tromey  <tom@tromey.com>
731
732         * xml-support.c (gdb_xml_parser::parse): Update.
733         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
734         * value.c (show_convenience): Update.
735         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
736         (test_parse_flags_qcs): Update.
737         * thread.c (thr_try_catch_cmd): Update.
738         * target.c (target_translate_tls_address): Update.
739         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
740         (info_frame_command_core, frame_apply_command_count): Update.
741         * rust-exp.y (rust_lex_exception_test): Update.
742         * riscv-tdep.c (riscv_print_one_register_info): Update.
743         * remote.c (remote_target::enable_btrace): Update.
744         * record-btrace.c (record_btrace_enable_warn): Update.
745         * python/py-utils.c (gdbpy_convert_exception): Update.
746         * printcmd.c (do_one_display, print_variable_and_value): Update.
747         * mi/mi-main.c (mi_print_exception): Update.
748         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
749         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
750         * linux-nat.c (linux_nat_target::attach): Update.
751         * linux-fork.c (class scoped_switch_fork_info): Update.
752         * infrun.c (displaced_step_prepare): Update.
753         * infcall.c (call_function_by_hand_dummy): Update.
754         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
755         * gnu-v3-abi.c (print_one_vtable): Update.
756         * frame.c (get_prev_frame_always): Update.
757         * f-valprint.c (info_common_command_for_block): Update.
758         * exec.c (try_open_exec_file): Update.
759         * exceptions.c (print_exception, exception_print)
760         (exception_fprintf, exception_print_same): Update.
761         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
762         * dwarf-index-cache.c (index_cache::store)
763         (index_cache::lookup_gdb_index): Update.
764         * darwin-nat.c (maybe_cache_shell): Update.
765         * cp-valprint.c (cp_print_value_fields): Update.
766         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
767         (gcc_cplus_symbol_address): Update.
768         * compile/compile-c-symbols.c (gcc_convert_symbol)
769         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
770         * common/selftest.c: Update.
771         * common/common-exceptions.h (struct gdb_exception) <message>: Now
772         a std::string.
773         (exception_try_scope_entry, exception_try_scope_exit): Don't
774         declare.
775         (struct exception_try_scope): Remove.
776         (TRY): Don't use exception_try_scope.
777         (struct gdb_exception): Add constructor, operator=.
778         <what>: New method.
779         (struct gdb_exception_RETURN_MASK_ALL)
780         (struct gdb_exception_RETURN_MASK_ERROR)
781         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
782         (struct gdb_quit_bad_alloc): Update.
783         * common/common-exceptions.c (exception_none): Change
784         initializer.
785         (struct catcher) <state, exception>: Initialize inline.
786         <prev>: Remove member.
787         (current_catcher): Remove.
788         (catchers): New global.
789         (exceptions_state_mc_init): Simplify.
790         (catcher_pop): Remove.
791         (exceptions_state_mc, exceptions_state_mc_catch): Update.
792         (try_scope_depth, exception_try_scope_entry)
793         (exception_try_scope_exit): Remove.
794         (throw_exception_sjlj): Update.
795         (exception_messages, exception_messages_size): Remove.
796         (throw_it): Simplify.
797         (gdb_exception_sliced_copy): Remove.
798         (throw_exception_cxx): Update.
799         * cli/cli-script.c (script_from_file): Update.
800         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
801         Update.
802         * ada-valprint.c (ada_val_print): Update.
803         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
804         (create_excep_cond_exprs): Update.
805
806 2019-04-08  Tom Tromey  <tom@tromey.com>
807
808         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
809         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
810         (TRY, CATCH, END_CATCH): Remove some definitions.
811         * common/common-exceptions.c: Don't use GDB_XCPT.
812         (catcher_list_size): Remove.
813         (throw_exception, throw_it): Simplify.
814
815 2019-04-05  Tom Tromey  <tom@tromey.com>
816
817         Revert the header-sorting patch.
818         * ft32-tdep.c: Revert.
819         * frv-tdep.c: Revert.
820         * frv-linux-tdep.c: Revert.
821         * frame.c: Revert.
822         * frame-unwind.c: Revert.
823         * frame-base.c: Revert.
824         * fork-child.c: Revert.
825         * findvar.c: Revert.
826         * findcmd.c: Revert.
827         * filesystem.c: Revert.
828         * filename-seen-cache.h: Revert.
829         * filename-seen-cache.c: Revert.
830         * fbsd-tdep.c: Revert.
831         * fbsd-nat.h: Revert.
832         * fbsd-nat.c: Revert.
833         * f-valprint.c: Revert.
834         * f-typeprint.c: Revert.
835         * f-lang.c: Revert.
836         * extension.h: Revert.
837         * extension.c: Revert.
838         * extension-priv.h: Revert.
839         * expprint.c: Revert.
840         * exec.h: Revert.
841         * exec.c: Revert.
842         * exceptions.c: Revert.
843         * event-top.c: Revert.
844         * event-loop.c: Revert.
845         * eval.c: Revert.
846         * elfread.c: Revert.
847         * dwarf2read.h: Revert.
848         * dwarf2read.c: Revert.
849         * dwarf2loc.c: Revert.
850         * dwarf2expr.h: Revert.
851         * dwarf2expr.c: Revert.
852         * dwarf2-frame.c: Revert.
853         * dwarf2-frame-tailcall.c: Revert.
854         * dwarf-index-write.h: Revert.
855         * dwarf-index-write.c: Revert.
856         * dwarf-index-common.c: Revert.
857         * dwarf-index-cache.h: Revert.
858         * dwarf-index-cache.c: Revert.
859         * dummy-frame.c: Revert.
860         * dtrace-probe.c: Revert.
861         * disasm.h: Revert.
862         * disasm.c: Revert.
863         * disasm-selftests.c: Revert.
864         * dictionary.c: Revert.
865         * dicos-tdep.c: Revert.
866         * demangle.c: Revert.
867         * dcache.h: Revert.
868         * dcache.c: Revert.
869         * darwin-nat.h: Revert.
870         * darwin-nat.c: Revert.
871         * darwin-nat-info.c: Revert.
872         * d-valprint.c: Revert.
873         * d-namespace.c: Revert.
874         * d-lang.c: Revert.
875         * ctf.c: Revert.
876         * csky-tdep.c: Revert.
877         * csky-linux-tdep.c: Revert.
878         * cris-tdep.c: Revert.
879         * cris-linux-tdep.c: Revert.
880         * cp-valprint.c: Revert.
881         * cp-support.c: Revert.
882         * cp-namespace.c: Revert.
883         * cp-abi.c: Revert.
884         * corelow.c: Revert.
885         * corefile.c: Revert.
886         * continuations.c: Revert.
887         * completer.h: Revert.
888         * completer.c: Revert.
889         * complaints.c: Revert.
890         * coffread.c: Revert.
891         * coff-pe-read.c: Revert.
892         * cli-out.h: Revert.
893         * cli-out.c: Revert.
894         * charset.c: Revert.
895         * c-varobj.c: Revert.
896         * c-valprint.c: Revert.
897         * c-typeprint.c: Revert.
898         * c-lang.c: Revert.
899         * buildsym.c: Revert.
900         * buildsym-legacy.c: Revert.
901         * build-id.h: Revert.
902         * build-id.c: Revert.
903         * btrace.c: Revert.
904         * bsd-uthread.c: Revert.
905         * breakpoint.h: Revert.
906         * breakpoint.c: Revert.
907         * break-catch-throw.c: Revert.
908         * break-catch-syscall.c: Revert.
909         * break-catch-sig.c: Revert.
910         * blockframe.c: Revert.
911         * block.c: Revert.
912         * bfin-tdep.c: Revert.
913         * bfin-linux-tdep.c: Revert.
914         * bfd-target.c: Revert.
915         * bcache.c: Revert.
916         * ax-general.c: Revert.
917         * ax-gdb.h: Revert.
918         * ax-gdb.c: Revert.
919         * avr-tdep.c: Revert.
920         * auxv.c: Revert.
921         * auto-load.c: Revert.
922         * arm-wince-tdep.c: Revert.
923         * arm-tdep.c: Revert.
924         * arm-symbian-tdep.c: Revert.
925         * arm-pikeos-tdep.c: Revert.
926         * arm-obsd-tdep.c: Revert.
927         * arm-nbsd-tdep.c: Revert.
928         * arm-nbsd-nat.c: Revert.
929         * arm-linux-tdep.c: Revert.
930         * arm-linux-nat.c: Revert.
931         * arm-fbsd-tdep.c: Revert.
932         * arm-fbsd-nat.c: Revert.
933         * arm-bsd-tdep.c: Revert.
934         * arch-utils.c: Revert.
935         * arc-tdep.c: Revert.
936         * arc-newlib-tdep.c: Revert.
937         * annotate.h: Revert.
938         * annotate.c: Revert.
939         * amd64-windows-tdep.c: Revert.
940         * amd64-windows-nat.c: Revert.
941         * amd64-tdep.c: Revert.
942         * amd64-sol2-tdep.c: Revert.
943         * amd64-obsd-tdep.c: Revert.
944         * amd64-obsd-nat.c: Revert.
945         * amd64-nbsd-tdep.c: Revert.
946         * amd64-nbsd-nat.c: Revert.
947         * amd64-nat.c: Revert.
948         * amd64-linux-tdep.c: Revert.
949         * amd64-linux-nat.c: Revert.
950         * amd64-fbsd-tdep.c: Revert.
951         * amd64-fbsd-nat.c: Revert.
952         * amd64-dicos-tdep.c: Revert.
953         * amd64-darwin-tdep.c: Revert.
954         * amd64-bsd-nat.c: Revert.
955         * alpha-tdep.c: Revert.
956         * alpha-obsd-tdep.c: Revert.
957         * alpha-nbsd-tdep.c: Revert.
958         * alpha-mdebug-tdep.c: Revert.
959         * alpha-linux-tdep.c: Revert.
960         * alpha-linux-nat.c: Revert.
961         * alpha-bsd-tdep.c: Revert.
962         * alpha-bsd-nat.c: Revert.
963         * aix-thread.c: Revert.
964         * agent.c: Revert.
965         * addrmap.c: Revert.
966         * ada-varobj.c: Revert.
967         * ada-valprint.c: Revert.
968         * ada-typeprint.c: Revert.
969         * ada-tasks.c: Revert.
970         * ada-lang.c: Revert.
971         * aarch64-tdep.c: Revert.
972         * aarch64-ravenscar-thread.c: Revert.
973         * aarch64-newlib-tdep.c: Revert.
974         * aarch64-linux-tdep.c: Revert.
975         * aarch64-linux-nat.c: Revert.
976         * aarch64-fbsd-tdep.c: Revert.
977         * aarch64-fbsd-nat.c: Revert.
978         * aarch32-linux-nat.c: Revert.
979
980 2019-04-05  Tom Tromey  <tom@tromey.com>
981
982         * ft32-tdep.c: Sort headers.
983         * frv-tdep.c: Sort headers.
984         * frv-linux-tdep.c: Sort headers.
985         * frame.c: Sort headers.
986         * frame-unwind.c: Sort headers.
987         * frame-base.c: Sort headers.
988         * fork-child.c: Sort headers.
989         * findvar.c: Sort headers.
990         * findcmd.c: Sort headers.
991         * filesystem.c: Sort headers.
992         * filename-seen-cache.h: Sort headers.
993         * filename-seen-cache.c: Sort headers.
994         * fbsd-tdep.c: Sort headers.
995         * fbsd-nat.h: Sort headers.
996         * fbsd-nat.c: Sort headers.
997         * f-valprint.c: Sort headers.
998         * f-typeprint.c: Sort headers.
999         * f-lang.c: Sort headers.
1000         * extension.h: Sort headers.
1001         * extension.c: Sort headers.
1002         * extension-priv.h: Sort headers.
1003         * expprint.c: Sort headers.
1004         * exec.h: Sort headers.
1005         * exec.c: Sort headers.
1006         * exceptions.c: Sort headers.
1007         * event-top.c: Sort headers.
1008         * event-loop.c: Sort headers.
1009         * eval.c: Sort headers.
1010         * elfread.c: Sort headers.
1011         * dwarf2read.h: Sort headers.
1012         * dwarf2read.c: Sort headers.
1013         * dwarf2loc.c: Sort headers.
1014         * dwarf2expr.h: Sort headers.
1015         * dwarf2expr.c: Sort headers.
1016         * dwarf2-frame.c: Sort headers.
1017         * dwarf2-frame-tailcall.c: Sort headers.
1018         * dwarf-index-write.h: Sort headers.
1019         * dwarf-index-write.c: Sort headers.
1020         * dwarf-index-common.c: Sort headers.
1021         * dwarf-index-cache.h: Sort headers.
1022         * dwarf-index-cache.c: Sort headers.
1023         * dummy-frame.c: Sort headers.
1024         * dtrace-probe.c: Sort headers.
1025         * disasm.h: Sort headers.
1026         * disasm.c: Sort headers.
1027         * disasm-selftests.c: Sort headers.
1028         * dictionary.c: Sort headers.
1029         * dicos-tdep.c: Sort headers.
1030         * demangle.c: Sort headers.
1031         * dcache.h: Sort headers.
1032         * dcache.c: Sort headers.
1033         * darwin-nat.h: Sort headers.
1034         * darwin-nat.c: Sort headers.
1035         * darwin-nat-info.c: Sort headers.
1036         * d-valprint.c: Sort headers.
1037         * d-namespace.c: Sort headers.
1038         * d-lang.c: Sort headers.
1039         * ctf.c: Sort headers.
1040         * csky-tdep.c: Sort headers.
1041         * csky-linux-tdep.c: Sort headers.
1042         * cris-tdep.c: Sort headers.
1043         * cris-linux-tdep.c: Sort headers.
1044         * cp-valprint.c: Sort headers.
1045         * cp-support.c: Sort headers.
1046         * cp-namespace.c: Sort headers.
1047         * cp-abi.c: Sort headers.
1048         * corelow.c: Sort headers.
1049         * corefile.c: Sort headers.
1050         * continuations.c: Sort headers.
1051         * completer.h: Sort headers.
1052         * completer.c: Sort headers.
1053         * complaints.c: Sort headers.
1054         * coffread.c: Sort headers.
1055         * coff-pe-read.c: Sort headers.
1056         * cli-out.h: Sort headers.
1057         * cli-out.c: Sort headers.
1058         * charset.c: Sort headers.
1059         * c-varobj.c: Sort headers.
1060         * c-valprint.c: Sort headers.
1061         * c-typeprint.c: Sort headers.
1062         * c-lang.c: Sort headers.
1063         * buildsym.c: Sort headers.
1064         * buildsym-legacy.c: Sort headers.
1065         * build-id.h: Sort headers.
1066         * build-id.c: Sort headers.
1067         * btrace.c: Sort headers.
1068         * bsd-uthread.c: Sort headers.
1069         * breakpoint.h: Sort headers.
1070         * breakpoint.c: Sort headers.
1071         * break-catch-throw.c: Sort headers.
1072         * break-catch-syscall.c: Sort headers.
1073         * break-catch-sig.c: Sort headers.
1074         * blockframe.c: Sort headers.
1075         * block.c: Sort headers.
1076         * bfin-tdep.c: Sort headers.
1077         * bfin-linux-tdep.c: Sort headers.
1078         * bfd-target.c: Sort headers.
1079         * bcache.c: Sort headers.
1080         * ax-general.c: Sort headers.
1081         * ax-gdb.h: Sort headers.
1082         * ax-gdb.c: Sort headers.
1083         * avr-tdep.c: Sort headers.
1084         * auxv.c: Sort headers.
1085         * auto-load.c: Sort headers.
1086         * arm-wince-tdep.c: Sort headers.
1087         * arm-tdep.c: Sort headers.
1088         * arm-symbian-tdep.c: Sort headers.
1089         * arm-pikeos-tdep.c: Sort headers.
1090         * arm-obsd-tdep.c: Sort headers.
1091         * arm-nbsd-tdep.c: Sort headers.
1092         * arm-nbsd-nat.c: Sort headers.
1093         * arm-linux-tdep.c: Sort headers.
1094         * arm-linux-nat.c: Sort headers.
1095         * arm-fbsd-tdep.c: Sort headers.
1096         * arm-fbsd-nat.c: Sort headers.
1097         * arm-bsd-tdep.c: Sort headers.
1098         * arch-utils.c: Sort headers.
1099         * arc-tdep.c: Sort headers.
1100         * arc-newlib-tdep.c: Sort headers.
1101         * annotate.h: Sort headers.
1102         * annotate.c: Sort headers.
1103         * amd64-windows-tdep.c: Sort headers.
1104         * amd64-windows-nat.c: Sort headers.
1105         * amd64-tdep.c: Sort headers.
1106         * amd64-sol2-tdep.c: Sort headers.
1107         * amd64-obsd-tdep.c: Sort headers.
1108         * amd64-obsd-nat.c: Sort headers.
1109         * amd64-nbsd-tdep.c: Sort headers.
1110         * amd64-nbsd-nat.c: Sort headers.
1111         * amd64-nat.c: Sort headers.
1112         * amd64-linux-tdep.c: Sort headers.
1113         * amd64-linux-nat.c: Sort headers.
1114         * amd64-fbsd-tdep.c: Sort headers.
1115         * amd64-fbsd-nat.c: Sort headers.
1116         * amd64-dicos-tdep.c: Sort headers.
1117         * amd64-darwin-tdep.c: Sort headers.
1118         * amd64-bsd-nat.c: Sort headers.
1119         * alpha-tdep.c: Sort headers.
1120         * alpha-obsd-tdep.c: Sort headers.
1121         * alpha-nbsd-tdep.c: Sort headers.
1122         * alpha-mdebug-tdep.c: Sort headers.
1123         * alpha-linux-tdep.c: Sort headers.
1124         * alpha-linux-nat.c: Sort headers.
1125         * alpha-bsd-tdep.c: Sort headers.
1126         * alpha-bsd-nat.c: Sort headers.
1127         * aix-thread.c: Sort headers.
1128         * agent.c: Sort headers.
1129         * addrmap.c: Sort headers.
1130         * ada-varobj.c: Sort headers.
1131         * ada-valprint.c: Sort headers.
1132         * ada-typeprint.c: Sort headers.
1133         * ada-tasks.c: Sort headers.
1134         * ada-lang.c: Sort headers.
1135         * aarch64-tdep.c: Sort headers.
1136         * aarch64-ravenscar-thread.c: Sort headers.
1137         * aarch64-newlib-tdep.c: Sort headers.
1138         * aarch64-linux-tdep.c: Sort headers.
1139         * aarch64-linux-nat.c: Sort headers.
1140         * aarch64-fbsd-tdep.c: Sort headers.
1141         * aarch64-fbsd-nat.c: Sort headers.
1142         * aarch32-linux-nat.c: Sort headers.
1143
1144 2019-04-04  Tom Tromey  <tom@tromey.com>
1145
1146         * varobj.c (varobj_create): Update.
1147         * rust-exp.y (struct rust_parser) <update_innermost_block,
1148         lookup_symbol>: New methods.
1149         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1150         Rename.
1151         (rust_parser::rust_lookup_type)
1152         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1153         * printcmd.c (display_command, do_one_display): Update.
1154         * parser-defs.h (struct parser_state) <parser_state>: Add
1155         "tracker" parameter.
1156         (block_tracker): New member.
1157         (class innermost_block_tracker) <innermost_block_tracker>: Add
1158         "types" parameter.
1159         <reset>: Remove method.
1160         (innermost_block): Don't declare.
1161         (null_post_parser): Update.
1162         * parse.c (innermost_block): Remove global.
1163         (write_dollar_variable): Update.
1164         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1165         Remove "tracker_types" parameter.
1166         (parse_expression): Add "tracker" parameter.
1167         (parse_expression_for_completion): Update.
1168         (null_post_parser): Add "tracker" parameter.
1169         * p-exp.y: Update rules.
1170         * m2-exp.y: Update rules.
1171         * language.h (struct language_defn) <la_post_parser>: Add
1172         "tracker" parameter.
1173         * go-exp.y: Update rules.
1174         * f-exp.y: Update rules.
1175         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1176         parameter.
1177         * d-exp.y: Update rules.
1178         * c-exp.y: Update rules.
1179         * breakpoint.c (set_breakpoint_condition): Create an
1180         innermost_block_tracker.
1181         (watch_command_1): Likewise.
1182         * ada-lang.c (resolve): Add "tracker" parameter.
1183         (resolve_subexp): Likewise.
1184         * ada-exp.y (write_var_from_sym): Update.
1185
1186 2019-04-04  Tom Tromey  <tom@tromey.com>
1187
1188         * type-stack.h: New file.
1189         * type-stack.c: New file.
1190         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1191         type-stack.h.
1192         (insert_into_type_stack, insert_type, push_type, push_type_int)
1193         (insert_type_address_space, pop_type, pop_type_int)
1194         (pop_typelist, pop_type_stack, append_type_stack)
1195         (push_type_stack, get_type_stack, push_typelist)
1196         (follow_type_instance_flags, follow_types): Don't declare.
1197         * parse.c (type_stack): Remove global.
1198         (parse_exp_in_context): Update.
1199         (insert_into_type_stack, insert_type, push_type, push_type_int)
1200         (insert_type_address_space, pop_type, pop_type_int)
1201         (pop_typelist, pop_type_stack, append_type_stack)
1202         (push_type_stack, get_type_stack, push_typelist)
1203         (follow_type_instance_flags, follow_types): Remove (moved to
1204         type-stack.c).
1205         * f-exp.y (type_stack): New global.
1206         Update rules.
1207         (push_kind_type, f_parse): Update.
1208         * d-exp.y (type_stack): New global.
1209         Update rules.
1210         (d_parse): Update.
1211         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1212         Update rules.
1213         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1214         (HFILES_NO_SRCDIR): Add type-stack.h.
1215
1216 2019-04-04  Tom Tromey  <tom@tromey.com>
1217
1218         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1219         (rust_parser::convert_ast_to_expression, rust_parse)
1220         (rust_lex_test_completion, rust_lex_tests): Update.
1221         * parser-defs.h (struct expr_completion_state): New.
1222         (struct parser_state) <parser_state>: Add completion parameter.
1223         <mark_struct_expression, mark_completion_tag>: New methods.
1224         <parse_completion, m_completion_state>: New members.
1225         (prefixify_expression, null_post_parser): Update.
1226         (mark_struct_expression, mark_completion_tag): Don't declare.
1227         * parse.c (parse_completion, expout_last_struct)
1228         (expout_tag_completion_type, expout_completion_name): Remove
1229         globals.
1230         (parser_state::mark_struct_expression)
1231         (parser_state::mark_completion_tag): Now methods.
1232         (prefixify_expression): Add last_struct parameter.
1233         (prefixify_subexp): Likewise.
1234         (parse_exp_1): Update.
1235         (parse_exp_in_context): Add cstate parameter.  Update.
1236         (parse_expression_for_completion): Create an
1237         expr_completion_state.
1238         (null_post_parser): Add "completion" parameter.
1239         * p-exp.y: Update rules.
1240         (yylex): Update.
1241         * language.h (struct language_defn) <la_post_parser>: Add
1242         "completing" parameter.
1243         * go-exp.y: Update rules.
1244         (lex_one_token): Update.
1245         * expression.h (parse_completion): Don't declare.
1246         * d-exp.y: Update rules.
1247         (lex_one_token): Update rules.
1248         * c-exp.y: Update rules.
1249         (lex_one_token): Update.
1250         * ada-lang.c (resolve): Add "parse_completion" parameter.
1251         (resolve_subexp): Likewise.
1252         (ada_resolve_function): Likewise.
1253
1254 2019-04-04  Tom Tromey  <tom@tromey.com>
1255
1256         * parser-defs.h (struct parser_state) <start_arglist,
1257         end_arglist>: New methods.
1258         <arglist_len, m_funcall_chain>: New members.
1259         (arglist_len, start_arglist, end_arglist): Don't declare.
1260         * parse.c (arglist_len, funcall_chain): Remove global.
1261         (start_arglist, end_arglist): Remove functions.
1262         (parse_exp_in_context): Update.
1263         * p-exp.y: Update rules.
1264         * m2-exp.y: Update rules.
1265         * go-exp.y: Update rules.
1266         * f-exp.y: Update rules.
1267         * d-exp.y: Update rules.
1268         * c-exp.y: Update rules.
1269
1270 2019-04-04  Tom Tromey  <tom@tromey.com>
1271
1272         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1273         lex_operator, push_back>: New methods.
1274         Update all rules.
1275         (rust_parser::lex_hex, lex_escape): Rename and update.
1276         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1277         (rust_parser::lex_operator): Rename and update.
1278         (rust_parser::lex_number, rustyylex, rustyyerror)
1279         (rust_lex_test_init, rust_lex_test_sequence)
1280         (rust_lex_test_push_back, rust_lex_tests): Update.
1281         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1282         parameter.
1283         <lexptr, prev_lexptr>: New members.
1284         (lexptr, prev_lexptr): Don't declare.
1285         * parse.c (lexptr, prev_lexptr): Remove globals.
1286         (parse_exp_in_context): Update.
1287         * p-exp.y (yylex, yyerror): Update.
1288         * m2-exp.y (parse_number, yylex, yyerror): Update.
1289         * go-exp.y (lex_one_token, yyerror): Update.
1290         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1291         * d-exp.y (lex_one_token, yyerror): Update.
1292         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1293         (lex_one_token, yyerror): Update.
1294         * ada-lex.l (YY_INPUT): Update.
1295         (rewind_to_char): Update.
1296         * ada-exp.y (yyerror): Update.
1297
1298 2019-04-04  Tom Tromey  <tom@tromey.com>
1299
1300         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1301         * parser-defs.h (struct parser_state) <parser_state>: Add new
1302         parameter.
1303         <comma_terminates>: New member.
1304         (comma_terminates): Don't declare global.
1305         * parse.c (comma_terminates): Remove global.
1306         (parse_exp_in_context): Update.
1307         * p-exp.y (yylex): Update.
1308         * m2-exp.y (yylex): Update.
1309         * go-exp.y (lex_one_token): Update.
1310         * f-exp.y (yylex): Update.
1311         * d-exp.y (lex_one_token): Update.
1312         * c-exp.y (lex_one_token): Update.
1313         * ada-lex.l: Update.
1314
1315 2019-04-04  Tom Tromey  <tom@tromey.com>
1316
1317         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1318         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1319         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1320         * parser-defs.h (paren_depth): Don't declare.
1321         * parse.c (paren_depth): Remove global.
1322         (parse_exp_in_context): Update.
1323         * p-exp.y (paren_depth): New global.
1324         (pascal_parse): Initialize it.
1325         * m2-exp.y (paren_depth): New global.
1326         (m2_parse): Initialize it.
1327         * go-exp.y (paren_depth): New global.
1328         (go_parse): Initialize it.
1329         * f-exp.y (paren_depth): New global.
1330         (f_parse): Initialize it.
1331         * d-exp.y (paren_depth): New global.
1332         (d_parse): Initialize it.
1333         * c-exp.y (paren_depth): New global.
1334         (c_parse): Initialize it.
1335         * ada-lex.l (paren_depth): New global.
1336         (lexer_init): Initialize it.
1337
1338 2019-04-04  Tom Tromey  <tom@tromey.com>
1339
1340         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1341         (rust_parser::convert_ast_to_type)
1342         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1343         * parser-defs.h (struct parser_state) <parser_state>: Add
1344         parameters.  Initialize new members.
1345         <expression_context_block, expression_context_pc>: New members.
1346         * parse.c (expression_context_block, expression_context_pc):
1347         Remove globals.
1348         (parse_exp_in_context): Update.
1349         * p-exp.y: Update all rules.
1350         (yylex): Update.
1351         * m2-exp.y: Update all rules.
1352         (yylex): Update.
1353         * go-exp.y (yylex): Update.
1354         * f-exp.y (yylex): Update.
1355         * d-exp.y: Update all rules.
1356         (yylex): Update.
1357         * c-exp.y: Update all rules.
1358         (lex_one_token, classify_name, yylex, c_parse): Update.
1359         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1360
1361 2019-04-04  Tom Tromey  <tom@tromey.com>
1362
1363         * gdbarch.h, gdbarch.c: Rebuild.
1364         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1365         * stap-probe.h: 
1366         (struct stap_parse_info): Replace "parser_state" with
1367         "expr_builder".
1368         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1369         (parser_state): New class.
1370         * parse.c (expr_builder): Rename.
1371         (expr_builder::release): Rename.
1372         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1373         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1374         (write_exp_elt_longcst, write_exp_elt_floatcst)
1375         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1376         (write_exp_string_vector, write_exp_bitstring)
1377         (write_exp_msymbol, mark_struct_expression)
1378         (write_dollar_variable)
1379         (insert_type_address_space, increase_expout_size): Replace
1380         "parser_state" with "expr_builder".
1381         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1382         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1383         "parser_state" with "expr_builder".
1384
1385 2019-04-04  Tom Tromey  <tom@tromey.com>
1386
1387         * rust-exp.y: Replace "parse_language" with method call.
1388         * p-exp.y: 
1389         (yylex): Replace "parse_language" with method call.
1390         * m2-exp.y: 
1391         (yylex): Replace "parse_language" with method call.
1392         * go-exp.y (classify_name): Replace "parse_language" with method
1393         call.
1394         * f-exp.y (yylex): Replace "parse_language" with method call.
1395         * d-exp.y (lex_one_token): Replace "parse_language" with method
1396         call.
1397         * c-exp.y: 
1398         (lex_one_token, classify_name, yylex): Replace "parse_language"
1399         with method call.
1400         * ada-exp.y (find_primitive_type, type_char)
1401         (type_system_address): Replace "parse_language" with method call.
1402
1403 2019-04-04  Tom Tromey  <tom@tromey.com>
1404
1405         * rust-exp.y: Replace "parse_gdbarch" with method call.
1406         * parse.c (write_dollar_variable, insert_type_address_space):
1407         Replace "parse_gdbarch" with method call.
1408         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
1409         call.
1410         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
1411         call.
1412         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
1413         "parse_gdbarch" with method call.
1414         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
1415         with method call.
1416         * f-exp.y (parse_type, parse_f_type, yylex): Replace
1417         "parse_gdbarch" with method call.
1418         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
1419         "parse_gdbarch" with method call.
1420         * c-exp.y (parse_type, parse_number, classify_name): Replace
1421         "parse_gdbarch" with method call.
1422         * ada-lex.l: Replace "parse_gdbarch" with method call.
1423         * ada-exp.y (parse_type, find_primitive_type, type_char)
1424         (type_system_address): Replace "parse_gdbarch" with method call.
1425
1426 2019-04-04  Tom Tromey  <tom@tromey.com>
1427
1428         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
1429         * stap-probe.c (stap_parse_argument): Update.
1430         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
1431         initial_size parameter.
1432         * rust-exp.y (rust_lex_tests): Update.
1433         * parse.c (parser_state): Update.
1434         (parse_exp_in_context): Update.
1435         * parser-defs.h (struct parser_state) <parser_state>: Remove
1436         "initial_size" parameter.
1437
1438 2019-04-04  Tom Tromey  <tom@tromey.com>
1439
1440         * parser-defs.h (increase_expout_size): Don't declare.
1441         * parse.c (increase_expout_size): Now static.
1442
1443 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1444
1445         * gnu-nat.c (gnu_nat_target::wait): Fix
1446         target_waitstatus_to_string call.
1447
1448 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1449
1450         * eval.c (evaluate_subexp_standard): Handle internal functions
1451         during Fortran function call handling.
1452
1453 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1454
1455         * NEWS: Mention new internal functions.
1456         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1457         (read_base_type): Use dwarf2_init_complex_target_type.
1458         * value.c (creal_internal_fn): New function.
1459         (cimag_internal_fn): New function.
1460         (_initialize_values): Register new internal functions.
1461
1462 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1463
1464         * infrun.c (stop_all_threads): If debug_infrun, always
1465         trace the wait status after wait_one, using
1466         target_waitstatus_to_string and target_pid_to_str.
1467         (handle_inferior_event): Replace various trace of
1468         wait status kind by a single trace.
1469         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
1470         wait status kind image by target_waitstatus_to_string.
1471         * target/waitstatus.c (target_waitstatus_to_string): Fix
1472         obsolete comment.
1473
1474 2019-04-01  Tom Tromey  <tromey@adacore.com>
1475
1476         PR symtab/23331:
1477         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
1478
1479 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1480             Pedro Alves  <palves@redhat.com>
1481
1482         * top.c (quit_force): Call 'finalize_values'.
1483         * value.c (finalize_values): New function.
1484         * value.h (finalize_values): Declare.
1485
1486 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
1487
1488         * NEWS: Announce $_gdb_major and $_gdb_minor.
1489
1490         * top.c (init_gdb_version_vars): New function.
1491         (gdb_init): Call init_gdb_version_vars.
1492
1493 2019-03-29  Tom Tromey  <tromey@adacore.com>
1494
1495         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
1496         help text.  Remove dead code.
1497
1498 2019-03-29  Keith Seitz  <keiths@redhat.com>
1499
1500         From Siddhesh Poyarekar:
1501         * f-lang.h (f77_get_upperbound): Return LONGEST.
1502         (f77_get_lowerbound): Likewise.
1503         * f-typeprint.c (f_type_print_varspec_suffix): Expand
1504         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
1505         print them.
1506         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
1507         plongest to format print it.
1508         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
1509         (f77_get_upperbound): Likewise.
1510         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
1511         LOWER_BOUND to LONGEST.
1512         (f77_create_arrayprint_offset_tbl): Likewise.
1513
1514 2019-03-29  Keith Seitz  <keiths@redhat.com>
1515
1516         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
1517         %s/pulongest for TYPE_LENGTH instead of %d in format
1518         strings.
1519         * ada-typerint.c (ada_print_type): Likewise.
1520         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
1521         * compile/compile-c-support.c (generate_register_struct): Likewise.
1522         * gdbtypes.c (recursive_dump_type): Likewise.
1523         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
1524         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
1525         instead of %d in format strings.
1526         * riscv-tdep.c (riscv_type_alignment): Cast second argument
1527         to std::min to ULONGEST.
1528         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
1529         instead of %d in format strings.
1530         * tracepoint.c (info_scope_command): Likewise.
1531         * typeprint.c (print_offset_data::update)
1532         (print_offset_data::finish): Likewise.
1533         * xtensa-tdep.c (xtensa_store_return_value)
1534         (xtensa_push_dummy_call): Likewise.
1535
1536 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
1537
1538         * windows-nat.c (display_selector): Fixed format specifications
1539         for 64-bit Cygwin.
1540
1541 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1542
1543         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
1544
1545 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
1546
1547         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
1548         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
1549         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
1550         (nios2_linux_init_abi): Install it.
1551
1552 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1553
1554         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
1555
1556 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1557
1558         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
1559
1560 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1561             Tom Tromey  <tromey@adacore.com>
1562
1563         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
1564
1565 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
1566
1567         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
1568         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
1569         method to compute the bounds of range types. Also print "[evaluated]"
1570         if the bounds' values come from a dynamic evaluation.
1571
1572 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1573
1574         * cp-valprint.c (cp_print_value_fields): Don't print trailing
1575         whitespace when pretty printing is on.
1576
1577 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1578
1579         * ppc-linux-nat.c: Add include.
1580
1581 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1582
1583         * NEWS: Mention AArch64 Pointer Authentication.
1584
1585 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1586
1587         * arm-linux-nat.c: Add include.
1588
1589 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
1590
1591         * source-cache.c (source_cache::get_source_lines): Re-read
1592         fullname after calling open_source_file.
1593
1594 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
1595
1596         * NEWS: Mention TLS support for FreeBSD.
1597
1598 2019-03-25  Tom Tromey  <tromey@adacore.com>
1599
1600         * minsyms.c (BUNCH_SIZE): Update comment.
1601         (~minimal_symbol_reader): Remove old comment.
1602         (compact_minimal_symbols): Update comment.
1603         (minimal_symbol_reader::install): Remove old comment.  Update
1604         other comments.
1605
1606 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1607
1608         * s390-linux-nat.c: Add include.
1609
1610 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1611
1612         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1613         Call linux_get_hwcap.
1614         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
1615         Likewise.
1616         (aarch64_linux_get_hwcap): Remove function.
1617         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
1618         declaration.
1619         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
1620         linux_get_hwcap.
1621         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1622         * linux-tdep.c (linux_get_hwcap): Add function.
1623         (linux_get_hwcap2): Likewise.
1624         * linux-tdep.h (linux_get_hwcap): Add declaration.
1625         (linux_get_hwcap2): Likewise.
1626         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
1627         (ppc_linux_get_hwcap2): Likewise.
1628         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
1629         linux_get_hwcap.
1630         (ppc_linux_nat_target::insert_watchpoint): Likewise.
1631         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
1632         (ppc_linux_nat_target::read_description): Likewise.
1633         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
1634         * s390-linux-nat.c: Likewise.
1635         * s390-linux-tdep.c (s390_core_read_description): Likewise.
1636
1637 2019-03-24  Tom Tromey  <tom@tromey.com>
1638
1639         * ada-lang.c (standard_lookup): Simplify initialization.
1640         (ada_lookup_symbol_nonlocal): Simplify return.
1641         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
1642         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
1643         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
1644         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
1645         initialization.
1646         * solib.c (solib_global_lookup): Simplify.
1647         * symtab.c (null_block_symbol): Remove.
1648         (symbol_cache_lookup): Simplify returns.
1649         (lookup_language_this): Simplify returns.
1650         (lookup_symbol_aux): Simplify return.
1651         (lookup_local_symbol): Simplify returns.
1652         (lookup_global_symbol_from_objfile): Simplify return.
1653         (lookup_symbol_in_objfile_symtabs)
1654         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
1655         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
1656         (lookup_static_symbol, lookup_global_symbol): Simplify return.
1657         * cp-namespace.c (cp_lookup_bare_symbol)
1658         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
1659         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
1660         (cp_lookup_nested_symbol): Don't use null_block_symbol.
1661         (cp_lookup_symbol_via_imports): Simplify initialization.
1662         (find_symbol_in_baseclass): Likewise.
1663         * symtab.h (null_block_symbol): Remove.
1664         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
1665         (d_lookup_nested_symbol, d_lookup_symbol_imports)
1666         (d_lookup_symbol_module): Likewise.
1667         (find_symbol_in_baseclass): Simplify initialization.
1668
1669 2019-03-24  Tom Tromey  <tom@tromey.com>
1670
1671         * expression.h: Don't include symtab.h.
1672         (struct block): Forward declare.
1673
1674 2019-03-24  Tom Tromey  <tom@tromey.com>
1675
1676         * c-exp.y (typebase): Remove casts.
1677         * gdbtypes.c (lookup_unsigned_typename, )
1678         (lookup_signed_typename): Remove cast.
1679         * eval.c (parse_to_comma_and_eval): Remove cast.
1680         * parse.c (write_dollar_variable): Remove cast.
1681         * block.h (struct block) <superblock>: Now const.
1682         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
1683         * psymtab.c (psym_map_matching_symbols): Make "block" const.
1684         (map_block): Make "block" const.
1685         * symfile.h (struct quick_symbol_functions)
1686         <map_matching_symbols>: Constify block argument to "callback".
1687         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
1688         const.
1689         (find_pc_sect_compunit_symtab): Make "b" const.
1690         (find_symbol_at_address): Likewise.
1691         (search_symbols): Likewise.
1692         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
1693         (dw2_debug_names_lookup_symbol): Likewise.
1694         (dw2_map_matching_symbols): Update.
1695         * p-valprint.c (pascal_val_print): Remove "block".
1696         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
1697         (aux_add_nonlocal_symbols): Make "block" const.
1698         (resolve_subexp): Remove cast.
1699         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
1700         const.
1701         (iterate_over_file_blocks): Likewise.
1702         * f-exp.y (%union) <bval>: Remove.
1703         * coffread.c (patch_opaque_types): Make "b" const.
1704         * spu-tdep.c (spu_catch_start): Make "block" const.
1705         * c-valprint.c (print_unpacked_pointer): Remove "block".
1706         * symmisc.c (dump_symtab_1): Make "b" const.
1707         (block_depth): Make "block" const.
1708         * d-exp.y (%union) <bval>: Remove.
1709         * cp-support.h (cp_lookup_rtti_type): Update.
1710         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
1711         * psymtab.c (psym_lookup_symbol): Make "block" const.
1712         (maintenance_check_psymtabs): Make "b" const.
1713         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
1714         (enumerate_locals, enumerate_args): Update.
1715         * python/py-symtab.c (stpy_global_block): Make "block" const.
1716         (stpy_static_block): Likewise.
1717         * inline-frame.c (block_starting_point_at): Make "new_block"
1718         const.
1719         * block.c (find_block_in_blockvector): Make return type const.
1720         (blockvector_for_pc_sect): Make "b" const.
1721         (find_block_in_blockvector): Make "b" const.
1722
1723 2019-03-23  Tom Tromey  <tom@tromey.com>
1724
1725         * varobj.c (varobj_create): Update.
1726         * symfile.c (clear_symtab_users): Don't reset innermost_block.
1727         * printcmd.c (display_command, do_one_display): Don't reset
1728         innermost_block.
1729         * parser-defs.h (enum innermost_block_tracker_type): Move to
1730         expression.h.
1731         (innermost_block): Update comment.
1732         * parse.c (parse_exp_1): Add tracker_types parameter.
1733         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
1734         tracker_types parameter.  Reset innermost_block.
1735         (parse_exp_in_context): Remove.
1736         (parse_expression_for_completion): Update.
1737         * objfiles.c (~objfile): Don't reset expression_context_block or
1738         innermost_block.
1739         * expression.h (enum innermost_block_tracker_type): Move from
1740         parser-defs.h.
1741         (parse_exp_1): Add tracker_types parameter.
1742         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
1743         reset innermost_block.
1744
1745 2019-03-23  Tom Tromey  <tom@tromey.com>
1746
1747         * objfiles.h: Include bcache.h.
1748
1749 2019-03-23  Tom Tromey  <tom@tromey.com>
1750
1751         * linespec.c (get_current_search_block): Use
1752         scoped_restore_current_language.
1753         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
1754
1755 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1756             Jiong Wang  <jiong.wang@arm.com>
1757
1758         * aarch64-linux-tdep.c
1759         (aarch64_linux_iterate_over_regset_sections): Check for pauth
1760         section.
1761         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
1762
1763 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1764             Jiong Wang  <jiong.wang@arm.com>
1765
1766         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
1767         instructions.
1768         (aarch64_analyze_prologue_test): Add PACIASP test.
1769         (aarch64_prologue_prev_register): Unmask PC value.
1770
1771 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1772             Jiong Wang  <jiong.wang@arm.com>
1773
1774         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
1775         (aarch64_dwarf2_prev_register): Unmask PC value.
1776         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
1777         (aarch64_execute_dwarf_cfa_vendor_op): Check for
1778         DW_CFA_AARCH64_negate_ra_state.
1779         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
1780
1781 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1782             Jiong Wang  <jiong.wang@arm.com>
1783
1784         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
1785         registers.
1786         (aarch64_pseudo_register_name): Likewise.
1787         (aarch64_pseudo_register_type): Likewise.
1788         (aarch64_pseudo_register_reggroup_p): Likewise.
1789         (aarch64_gdbarch_init): Add pauth registers.
1790         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
1791         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
1792         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
1793         (struct gdbarch_tdep): Add regnum for ra_state.
1794
1795 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1796             Jiong Wang  <jiong.wang@arm.com>
1797
1798         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
1799
1800 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1801             Jiong Wang  <jiong.wang@arm.com>
1802
1803         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
1804         function.
1805         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
1806         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
1807         (aarch64_gdbarch_init): Add puth registers.
1808         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
1809         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
1810         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
1811
1812 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1813             Jiong Wang  <jiong.wang@arm.com>
1814
1815         * aarch64-linux-nat.c
1816         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
1817         * aarch64-linux-tdep.c
1818         (aarch64_linux_core_read_description): Likewise.
1819         (aarch64_linux_get_hwcap): New function.
1820         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
1821         (aarch64_linux_get_hwcap): New declaration.
1822
1823 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1824             Jiong Wang  <jiong.wang@arm.com>
1825
1826         * aarch64-linux-nat.c
1827         (aarch64_linux_nat_target::read_description): Add pauth param.
1828         * aarch64-linux-tdep.c
1829         (aarch64_linux_core_read_description): Likewise.
1830         * aarch64-tdep.c (struct target_desc): Add in pauth.
1831         (aarch64_read_description): Add pauth param.
1832         (aarch64_gdbarch_init): Likewise.
1833         * aarch64-tdep.h (aarch64_read_description): Likewise.
1834         * arch/aarch64.c (aarch64_create_target_description): Likewise.
1835         * arch/aarch64.h (aarch64_create_target_description): Likewise.
1836         * features/Makefile: Add new files.
1837         * features/aarch64-pauth.c: New file.
1838         * features/aarch64-pauth.xml: New file.
1839
1840 2019-03-20  Tom Tromey  <tromey@adacore.com>
1841
1842         * infrun.c (handle_inferior_event): Rename from
1843         handle_inferior_event_1.  Create a scoped_value_mark.
1844         (handle_inferior_event): Remove.
1845
1846 2019-03-19  Tom Tromey  <tromey@adacore.com>
1847
1848         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
1849         * infrun.h (print_stop_event): Add "displays" parameter.
1850         * infrun.c (print_stop_event): Add "displays" parameter.
1851
1852 2019-03-19  Pedro Alves  <palves@redhat.com>
1853
1854         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
1855         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
1856         to -1.  Fix TABs vs spaces.
1857         (tui_ui_out::tui_ui_out): Don't initialize fields here.
1858         * tui/tui-out.h (tui_ui_out) Add intro comments.
1859         <m_line, m_start_of_line>: In-class initialize, and add describing
1860         comment.
1861
1862 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
1863
1864         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
1865         variable names.
1866         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
1867
1868 2019-03-18  Pedro Alves  <palves@redhat.com>
1869             Eli Zaretskii <eliz@gnu.org>
1870
1871         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
1872         m_line and m_start_of_line.
1873
1874 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
1875
1876         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
1877         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
1878         it returns a newline.  This fixes a regression in TU mode, whereby
1879         the next line is output on the same screen line as the user input.
1880
1881 2019-03-18  Tom Tromey  <tromey@adacore.com>
1882
1883         * minsyms.c (minimal_symbol_reader::install): Remove call to
1884         obstack_blank.
1885
1886 2019-03-18  Pedro Alves  <palves@redhat.com>
1887
1888         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
1889         New globals.
1890         (apply_style): New, factored out from ...
1891         (apply_ansi_escape): ... this.  Handle reverse video mode.
1892         (tui_set_reverse_mode): New function.
1893         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
1894         * tui/tui-winsource.c (tui_show_source_line): Use
1895         tui_set_reverse_mode instead of setting A_STANDOUT.
1896         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
1897         New setter methods.
1898
1899 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
1900
1901         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
1902         Handle tabs.
1903
1904 2019-03-18  Tom Tromey  <tromey@adacore.com>
1905
1906         * ada-lang.c (empty_array): Add "high" parameter.
1907         (ada_evaluate_subexp): Update.
1908
1909 2019-03-17  Sergei Trofimovich <siarheit@google.com>
1910
1911         * unittests/string_view-selftests.c: Define
1912         _initialize_string_view_selftests unconditionally.
1913
1914 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1915
1916         PR gdb/24350
1917         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
1918
1919 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1920
1921         PR gdb/24351
1922         * windows-nat.c (display_selector): Fix format specifiers.
1923
1924 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
1925
1926         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
1927         tui_refill_source_window instead of tui_refresh_win, to update the
1928         current execution line.  This fixes redisplay of the current line
1929         when stepping through the code with "next" or "step".
1930
1931 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1932
1933         * source-cache.c (source_cache::get_source_lines): Call
1934         find_source_lines to initialize s->nlines.  This fixes vertical
1935         scrolling of TUI source window when the DOWN arrow is pressed.
1936
1937 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1938
1939         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
1940         linux-thread-db.c (_initialize_thread_db): Likewise.
1941
1942 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1943
1944         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
1945         wclrtoeol in tui_show_source_line".  This reverts changes made in
1946         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
1947
1948 2019-03-15  Tom Tromey  <tom@tromey.com>
1949
1950         * symtab.h (struct minimal_symbol): Derive from
1951         general_symbol_info.
1952         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
1953         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
1954         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
1955         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
1956         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
1957         (MSYMBOL_SEARCH_NAME): Update.
1958         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
1959         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
1960         * minsyms.c (minimal_symbol_reader::record_full): Update.
1961
1962 2019-03-15  Tom Tromey  <tom@tromey.com>
1963
1964         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
1965
1966 2019-03-15  Tom Tromey  <tom@tromey.com>
1967
1968         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
1969         unique_xmalloc_ptr.
1970         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
1971         Update.
1972         * minsyms.c (lookup_minimal_symbol_by_pc_section)
1973         (build_minimal_symbol_hash_tables)
1974         (minimal_symbol_reader::install): Update.
1975
1976 2019-03-15  Tom Tromey  <tom@tromey.com>
1977
1978         * symtab.c (create_demangled_names_hash): Update.
1979         (symbol_set_names): Update.
1980         * objfiles.h (struct objfile_per_bfd_storage)
1981         <demangled_names_hash>: Now an htab_up.
1982         * objfiles.c (objfile_per_bfd_storage): Simplify.
1983
1984 2019-03-15  Tom Tromey  <tom@tromey.com>
1985
1986         * objfiles.h (struct objfile_per_bfd_storage): Declare
1987         destructor.
1988         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
1989         New.
1990         (get_objfile_bfd_data): Use new.  Don't initialize
1991         language_of_main.
1992         (free_objfile_per_bfd_storage): Remove.
1993         (objfile_bfd_data_free, objfile::~objfile): Use delete.
1994
1995 2019-03-15  Tom Tromey  <tom@tromey.com>
1996
1997         * symfile.c (reread_symbols): Update.
1998         * objfiles.c (objfile::objfile): Update.
1999         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2000         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2001         comment.
2002         (minimal_symbol_reader::install): Update.
2003         (terminate_minimal_symbol_table): Remove.
2004         * jit.c (jit_object_close_impl): Update.
2005
2006 2019-03-15  Tom Tromey  <tom@tromey.com>
2007
2008         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2009         initializations.
2010
2011 2019-03-15  Tom Tromey  <tom@tromey.com>
2012
2013         * objfiles.h (struct objfile_per_bfd_storage)
2014         <demangled_hash_languages>: Now a bitset.
2015         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2016         (lookup_minimal_symbol): Update.
2017
2018 2019-03-15  Tom Tromey  <tom@tromey.com>
2019
2020         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2021         Don't return the symbol.
2022         * coffread.c (record_minimal_symbol): Use record_full.
2023
2024 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2025
2026         The MS-Windows port of ncurses fails to switch to a color pair if
2027         one or both of the colors are the implicit default colors.  This
2028         change records the default colors when TUI is initialized, and
2029         then specifies them explicitly when a color pair uses the default
2030         colors.  This allows color styling in TUI mode on MS-Windows.
2031
2032         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2033         ncurses_norm_attr.
2034         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2035         colors in ncurses_norm_attr.
2036         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2037         "none", replace it with the default color recorded in
2038         ncurses_norm_attr.
2039
2040 2019-03-14  Tom Tromey  <tromey@adacore.com>
2041
2042         * source-cache.h (class source_cache) <get_source_lines>: Return
2043         std::string.
2044         * source-cache.c (source_cache::extract_lines): Handle case where
2045         first_pos==npos.  Return std::string.
2046         (source_cache::get_source_lines): Update.
2047
2048 2019-03-14  Tom Tromey  <tromey@adacore.com>
2049
2050         * NEWS: Add item for "style sources" commands.
2051         * source-cache.c (source_cache::get_source_lines): Check
2052         source_styling.
2053         * cli/cli-style.c (source_styling): New global.
2054         (_initialize_cli_style): Add "style sources" commands.
2055         (show_style_sources): New function.
2056         * cli/cli-style.h (source_styling): Declare.
2057
2058 2019-03-14  Pedro Alves  <palves@redhat.com>
2059             Tom Tromey  <tromey@adacore.com>
2060
2061         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2062         * tui/tui-winsource.c (tui_refill_source_window): New function,
2063         from...
2064         (tui_horizontal_source_scroll): ... here.  Move some logic.
2065         * cli/cli-style.c (set_style_enabled): Notify new observable.
2066         * tui/tui-hooks.c (tui_redisplay_source): New function.
2067         (tui_attach_detach_observers): Attach or detach
2068         tui_redisplay_source.
2069         * observable.h (source_styling_changed): New observable.
2070         * observable.c: Define source_styling_changed observable.
2071
2072 2019-03-13  Tom Tromey  <tromey@adacore.com>
2073
2074         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2075         (i386_gnu_nat_target::store_registers): Update.
2076         * target-debug.h (target_debug_print_std_string): New macro.
2077         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2078         * windows-tdep.c (display_one_tib): Update.
2079         * tui/tui-stack.c (tui_make_status_line): Update.
2080         * top.c (print_inferior_quit_action): Update.
2081         * thread.c (thr_try_catch_cmd): Update.
2082         (add_thread_with_info): Update.
2083         (thread_target_id_str): Update.
2084         (thr_try_catch_cmd): Update.
2085         (thread_command): Update.
2086         (thread_find_command): Update.
2087         * record-btrace.c (record_btrace_target::info_record)
2088         (record_btrace_resume_thread, record_btrace_target::resume)
2089         (record_btrace_cancel_resume, record_btrace_step_thread)
2090         (record_btrace_target::wait, record_btrace_target::wait)
2091         (record_btrace_target::wait, record_btrace_target::stop): Update.
2092         * progspace.c (print_program_space): Update.
2093         * process-stratum-target.c
2094         (process_stratum_target::thread_address_space): Update.
2095         * linux-fork.c (linux_fork_mourn_inferior)
2096         (detach_checkpoint_command, info_checkpoints_command)
2097         (linux_fork_context): Update.
2098         (linux_fork_detach): Update.
2099         (class scoped_switch_fork_info): Update.
2100         (delete_checkpoint_command): Update.
2101         * infrun.c (follow_fork_inferior): Update.
2102         (follow_fork_inferior): Update.
2103         (proceed_after_vfork_done): Update.
2104         (handle_vfork_child_exec_or_exit): Update.
2105         (follow_exec): Update.
2106         (displaced_step_prepare_throw): Update.
2107         (displaced_step_restore): Update.
2108         (start_step_over): Update.
2109         (resume_1): Update.
2110         (clear_proceed_status_thread): Update.
2111         (proceed): Update.
2112         (print_target_wait_results): Update.
2113         (do_target_wait): Update.
2114         (context_switch): Update.
2115         (stop_all_threads): Update.
2116         (restart_threads): Update.
2117         (finish_step_over): Update.
2118         (handle_signal_stop): Update.
2119         (switch_back_to_stepped_thread): Update.
2120         (keep_going_pass_signal): Update.
2121         (print_exited_reason): Update.
2122         (normal_stop): Update.
2123         * inferior.c (inferior_pid_to_str): Change return type.
2124         (print_selected_inferior): Update.
2125         (add_inferior): Update.
2126         (detach_inferior): Update.
2127         * dummy-frame.c (fprint_dummy_frames): Update.
2128         * dcache.c (dcache_info_1): Update.
2129         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2130         (btrace_fetch, btrace_clear): Update.
2131         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2132         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2133         type.
2134         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2135         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2136         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2137         * gdbarch.c, gdbarch.h: Rebuild.
2138         * gdbarch.sh (core_pid_to_str): Change return type.
2139         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2140         return type.
2141         (windows_nat_target::pid_to_str): Change return type.
2142         (windows_delete_thread): Update.
2143         (windows_nat_target::attach): Update.
2144         (windows_nat_target::files_info): Update.
2145         * target-delegates.c: Rebuild.
2146         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2147         return type.
2148         (sol_thread_target::pid_to_str): Change return type.
2149         * remote.c (class remote_target) <pid_to_str>: Change return
2150         type.
2151         (remote_target::pid_to_str): Change return type.
2152         (extended_remote_target::attach, remote_target::remote_stop_ns)
2153         (remote_target::remote_notif_remove_queued_reply)
2154         (remote_target::push_stop_reply, remote_target::disable_btrace):
2155         Update.
2156         (extended_remote_target::attach): Update.
2157         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2158         type.
2159         (gdbsim_target::pid_to_str): Change return type.
2160         * ravenscar-thread.c (struct ravenscar_thread_target)
2161         <pid_to_str>: Change return type.
2162         (ravenscar_thread_target::pid_to_str): Change return type.
2163         * procfs.c (class procfs_target) <pid_to_str>: Change return
2164         type.
2165         (procfs_target::pid_to_str): Change return type.
2166         (procfs_target::attach): Update.
2167         (procfs_target::detach): Update.
2168         (procfs_target::fetch_registers): Update.
2169         (procfs_target::store_registers): Update.
2170         (procfs_target::wait): Update.
2171         (procfs_target::files_info): Update.
2172         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2173         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2174         return type.
2175         (nto_procfs_target::pid_to_str): Change return type.
2176         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2177         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2178         return type.
2179         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2180         (exit_lwp): Update.
2181         (attach_proc_task_lwp_callback, get_detach_signal)
2182         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2183         (linux_nat_target::resume, wait_lwp, stop_callback)
2184         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2185         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2186         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2187         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2188         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2189         type.
2190         (inf_ptrace_target::attach): Update.
2191         (inf_ptrace_target::files_info): Update.
2192         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2193         type.
2194         (go32_nat_target::pid_to_str): Change return type.
2195         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2196         (gnu_nat_target::wait): Update.
2197         (gnu_nat_target::wait): Update.
2198         (gnu_nat_target::resume): Update.
2199         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2200         (fbsd_nat_target::wait): Update.
2201         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2202         type.
2203         (darwin_nat_target::attach): Update.
2204         * corelow.c (class core_target) <pid_to_str>: Change return type.
2205         (core_target::pid_to_str): Change return type.
2206         * target.c (normal_pid_to_str): Change return type.
2207         (default_pid_to_str): Likewise.
2208         (target_pid_to_str): Change return type.
2209         (target_translate_tls_address): Update.
2210         (target_announce_detach): Update.
2211         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2212         return type.
2213         (bsd_uthread_target::pid_to_str): Change return type.
2214         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2215         type.
2216         (bsd_kvm_target::pid_to_str): Change return type.
2217         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2218         return type.
2219         (aix_thread_target::pid_to_str): Change return type.
2220         * target.h (struct target_ops) <pid_to_str>: Change return type.
2221         (target_pid_to_str, normal_pid_to_str): Likewise.
2222         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2223         type.
2224         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2225         type.
2226         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2227         return type.
2228         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2229         type.
2230         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2231         type.
2232         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2233         return type.
2234
2235 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2236
2237         * NEWS: Mention that the new default MI version is 3.  Mention
2238         changes to the output of commands and events that deal with
2239         multi-location breakpoints.
2240         * breakpoint.c: Include "mi/mi-out.h".
2241         (print_one_breakpoint): Change output syntax if using MI version
2242         >= 3.
2243         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2244         New.
2245         (mi_multi_location_breakpoint_output_fixed): New.
2246         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2247         (mi_cmd_fix_multi_location_breakpoint_output): New.
2248         (mi_multi_location_breakpoint_output_fixed): New.
2249         * mi/mi-cmds.c (mi_cmds): Register command
2250         -fix-multi-location-breakpoint-output.
2251         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2252         interpreter "mi".
2253
2254 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2255
2256         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2257         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2258         instantiate mi_ui_out based on interpreter name.
2259         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2260         * mi/mi-main.c (mi_load_progress): Likewise.
2261
2262 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2263
2264         * NEWS: Combine separate "New targets" sections for 8.3.
2265
2266 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2267
2268         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2269         (ppcfbsd_init_abi): Install gdbarch
2270         "fetch_tls_load_module_address" and "get_thread_local_address"
2271         methods.
2272
2273 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2274
2275         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2276         (riscv_fbsd_init_abi): Install gdbarch
2277         "fetch_tls_load_module_address" and "get_thread_local_address"
2278         methods.
2279
2280 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2281
2282         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2283         (i386fbsd_init_abi): Install gdbarch
2284         "fetch_tls_load_module_address" and "get_thread_local_address"
2285         methods.
2286
2287 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2288
2289         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2290         (amd64fbsd_init_abi): Install gdbarch
2291         "fetch_tls_load_module_address" and "get_thread_local_address"
2292         methods.
2293
2294 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2295
2296         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2297         (struct fbsd_pspace_data): New type.
2298         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2299         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2300         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2301         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2302         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2303
2304 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2305
2306         * gdbtypes.c (lookup_struct_elt): New function.
2307         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2308         * gdbtypes.h (struct struct_elt): New type.
2309         (lookup_struct_elt): New prototype.
2310
2311 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2312
2313         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2314         remove disabled code block.
2315
2316 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2317
2318         * gdbarch.sh (get_thread_local_address): New method.
2319         * gdbarch.h, gdbarch.c: Regenerate.
2320         * target.c (target_translate_tls_address): Use
2321         gdbarch_get_thread_local_address if present instead of
2322         target::get_thread_local_address.
2323
2324 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2325
2326         * target.h (target::get_thread_local_address): Update comment.
2327
2328 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2329
2330         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2331         objfile->separate_debug_objfile_backlink if not NULL.
2332
2333 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2334
2335         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2336         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2337         (amd64bsd_store_inferior_registers): Likewise.
2338         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2339         Enable segment base registers.
2340         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2341         PT_GETFSBASE and PT_GETGSBASE.
2342         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2343         PT_SETGSBASE.
2344         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2345         segment base registers.
2346         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2347
2348 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2349
2350         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2351         Update calls to i386_target_description to add 'segments'
2352         parameter.
2353         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2354         add segment base registers.
2355         * arch/i386.c (i386_create_target_description): Add 'segments'
2356         parameter to enable segment base registers.
2357         * arch/i386.h (i386_create_target_description): Likewise.
2358         * features/i386/32bit-segments.xml: New file.
2359         * features/i386/32bit-segments.c: Generate.
2360         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2361         call to i386_target_description to add 'segments' parameter.
2362         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2363         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2364         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2365         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2366         if feature is present.
2367         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2368         Add 'segments' parameter to call to i386_target_description.
2369         (i386_target_description): Add 'segments' parameter to enable
2370         segment base registers.
2371         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2372         to call to i386_target_description.
2373         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2374         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2375         Define I386_NUM_REGS.
2376         (i386_target_description): Add 'segments' parameter to enable
2377         segment base registers.
2378
2379 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2380
2381         PR/24325
2382         * source-cache.c: #undef open and close, to avoid unresolved
2383         externals during linking.
2384
2385 2019-03-12  Tom Tromey  <tromey@adacore.com>
2386
2387         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2388         const.  Add initializers.
2389         (_initialize_remote): Don't initialize ptid globals.
2390
2391 2019-03-12  Pedro Alves  <palves@redhat.com>
2392
2393         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
2394
2395 2019-03-12  Pedro Alves  <palves@redhat.com>
2396
2397         * cp-name-parser.y (main): Remove unused 'len' variable.
2398
2399 2019-03-12  Tom Tromey  <tromey@adacore.com>
2400
2401         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
2402         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
2403
2404 2019-03-12  Tom Tromey  <tromey@adacore.com>
2405
2406         * linux-nat.c (iterate_over_lwps): Update.
2407         (stop_callback): Remove parameter.
2408         (stop_wait_callback, detach_callback, resume_set_callback)
2409         (select_singlestep_lwp_callback, set_ignore_sigint)
2410         (status_callback, resumed_callback, resume_clear_callback)
2411         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
2412         data parameter.
2413         (linux_nat_target::detach, linux_nat_target::resume)
2414         (linux_stop_and_wait_all_lwps, select_event_lwp)
2415         (linux_nat_filter_event, linux_nat_wait_1)
2416         (linux_nat_target::kill, linux_nat_target::stop)
2417         (linux_nat_target::stop): Update.
2418         (linux_nat_resume_callback): Change type.
2419         (resume_stopped_resumed_lwps, count_events_callback)
2420         (select_event_lwp_callback): Likewise.
2421         (linux_stop_lwp, linux_nat_stop_lwp): Update.
2422         * arm-linux-nat.c (struct update_registers_data): Remove.
2423         (update_registers_callback): Change type.
2424         (arm_linux_insert_hw_breakpoint1): Update.
2425         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
2426         parameter.
2427         (x86_linux_dr_set_addr): Update.
2428         (x86_linux_dr_set_control): Update.
2429         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
2430         (iterate_over_lwps): Use gdb::function_view.
2431         * nat/aarch64-linux-hw-point.c (struct
2432         aarch64_dr_update_callback_param): Remove.
2433         (debug_reg_change_callback): Change type.
2434         (aarch64_notify_debug_reg_change): Update.
2435         * s390-linux-nat.c (s390_refresh_per_info): Update.
2436
2437 2019-03-11  Tom Tromey  <tromey@adacore.com>
2438
2439         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2440         redundant assignment to "this_cu".
2441
2442 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2443
2444         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2445
2446 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2447
2448         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2449         from...
2450         (rank_one_type): ... this.
2451
2452 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2453
2454         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2455         from...
2456         (rank_one_type): ... this.
2457
2458 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2459
2460         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
2461         from...
2462         (rank_one_type): ... this.
2463
2464 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2465
2466         * gdbtypes.c (rank_one_type_parm_float): New function extracted
2467         from...
2468         (rank_one_type): ... this.
2469
2470 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2471
2472         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
2473         from...
2474         (rank_one_type): ... this.
2475
2476 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2477
2478         * gdbtypes.c (rank_one_type_parm_range): New function extracted
2479         from...
2480         (rank_one_type): ... this.
2481
2482 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2483
2484         * gdbtypes.c (rank_one_type_parm_char): New function extracted
2485         from...
2486         (rank_one_type): ... this.
2487
2488 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2489
2490         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
2491         from...
2492         (rank_one_type): ... this.
2493
2494 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2495
2496         * gdbtypes.c (rank_one_type_parm_int): New function extracted
2497         from...
2498         (rank_one_type): ... this.
2499
2500 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2501
2502         * gdbtypes.c (rank_one_type_parm_func): New function extracted
2503         from...
2504         (rank_one_type): ... this.
2505
2506 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2507
2508         * gdbtypes.c (rank_one_type_parm_array): New function extracted
2509         from...
2510         (rank_one_type): ... this.
2511
2512 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2513
2514         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
2515         from...
2516         (rank_one_type): ... this.
2517
2518 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2519
2520         * inferior.c (initialize_inferiors): Ensure 'help set/show print
2521         inferior-events' shows the example events.
2522
2523 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
2524
2525         Support styling on native MS-Windows console
2526
2527         PR/24315
2528         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
2529         on MS-Windows if $TERM is not defined.
2530
2531         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
2532
2533         * posix-hdep.c (gdb_console_fputs):
2534         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
2535         functions.
2536         * ui-file.h (gdb_console_fputs): Add prototype.
2537
2538         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
2539         back to fputs only if the former returns zero.
2540
2541 2019-03-07  Tom Tromey  <tom@tromey.com>
2542
2543         * symmisc.c (print_symbol_bcache_statistics): Update.
2544         (print_objfile_statistics): Update.
2545         * symfile.c (allocate_symtab): Update.
2546         * stabsread.c: Don't include bcache.h.
2547         * psymtab.h (struct psymbol_bcache): Don't declare.
2548         (class psymtab_storage) <psymbol_cache>: Now a bcache.
2549         (psymbol_bcache_init, psymbol_bcache_free)
2550         (psymbol_bcache_get_bcache): Don't declare.
2551         * psymtab.c (struct psymbol_bcache): Remove.
2552         (psymtab_storage::psymtab_storage): Update.
2553         (psymtab_storage::~psymtab_storage): Update.
2554         (psymbol_bcache_init, psymbol_bcache_free)
2555         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
2556         (add_psymbol_to_bcache): Update.
2557         (allocate_psymtab): Update.
2558         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2559         macro_cache>: No longer pointers.
2560         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
2561         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
2562         * macrotab.c (macro_bcache): Update.
2563         * macroexp.c: Don't include bcache.h.
2564         * gdbtypes.c (check_types_worklist): Update.
2565         (types_deeply_equal): Remove TRY/CATCH.  Update.
2566         * elfread.c (elf_symtab_read): Update.
2567         * dwarf2read.c: Don't include bcache.h.
2568         * buildsym.c (buildsym_compunit::get_macro_table): Update.
2569         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
2570         (print_bcache_statistics, bcache_memory_used): Don't declare.
2571         (struct bcache): Move from bcache.c.  Add constructor, destructor,
2572         methods.  Rename all data members.
2573         * bcache.c (struct bcache): Move to bcache.h.
2574         (bcache::expand_hash_table): Rename from expand_hash_table.
2575         (bcache): Remove.
2576         (bcache::insert): Rename from bcache_full.
2577         (bcache::compare): Rename from bcache_compare.
2578         (bcache_xmalloc): Remove.
2579         (bcache::~bcache): Rename from bcache_xfree.
2580         (bcache::print_statistics): Rename from print_bcache_statistics.
2581         (bcache::memory_used): Rename from bcache_memory_used.
2582
2583 2019-03-07  Pedro Alves  <palves@redhat.com>
2584
2585         * infrun.c (normal_stop): Also check for
2586         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
2587
2588 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2589
2590         * f-lang.c (value_from_host_double): Moved to...
2591         * value.c (value_from_host_double): ...here.
2592         * value.h (value_from_host_double): Declare.
2593         * guile/scm-math.c (vlscm_convert_typed_number): Use
2594         value_from_host_double.
2595         (vlscm_convert_number): Likewise.
2596         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
2597         * python/py-value.c (convert_value_from_python): Likewise.
2598
2599 2019-03-06  Tom Tromey  <tom@tromey.com>
2600
2601         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
2602
2603 2019-03-06  Tom Tromey  <tom@tromey.com>
2604
2605         * utils.h (free_current_contents): Don't declare.
2606         * utils.c (free_current_contents): Remove.
2607
2608 2019-03-06  Tom Tromey  <tom@tromey.com>
2609
2610         * top.c (quit_force): Update.
2611         * main.c (captured_command_loop): Update.
2612         * common/new-op.c (operator new): Update.
2613         * common/common-exceptions.c (struct catcher)
2614         <save_cleanup_chain>: Remove member.
2615         (exceptions_state_mc_init): Update.
2616         (exception_try_scope_entry): Return nullptr.
2617         (exception_try_scope_exit, exception_rethrow)
2618         (throw_exception_sjlj, throw_exception_cxx): Update.
2619         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
2620         (all_cleanups, do_cleanups, discard_cleanups)
2621         (discard_final_cleanups, save_cleanups, save_final_cleanups)
2622         (restore_cleanups, restore_final_cleanups): Don't declare.
2623         (do_final_cleanups): Remove parameter.
2624         * common/cleanups.c (cleanup_chain, make_cleanup)
2625         (make_cleanup_dtor, all_cleanups, do_cleanups)
2626         (discard_my_cleanups, discard_cleanups)
2627         (discard_final_cleanups, save_my_cleanups, save_cleanups)
2628         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
2629         (null_cleanup): Remove.
2630         (do_final_cleanups): Remove parameter.
2631
2632 2019-03-06  Tom Tromey  <tom@tromey.com>
2633
2634         * remote.c (remote_target::remote_parse_stop_reply): Use
2635         unique_xmalloc_ptr.
2636
2637 2019-03-06  Tom Tromey  <tom@tromey.com>
2638
2639         * stabsread.c (struct stabs_field_info): Rename from field_info.
2640         <list, fnlist>: Add initializers.
2641         <obstack>: New member.
2642         (read_member_functions, read_struct_fields, read_baseclasses):
2643         Allocate on obstack.  Don't use cleanups.
2644         (read_one_struct_field, read_member_functions, read_struct_fields)
2645         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
2646         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
2647         (read_struct_type): Update.
2648
2649 2019-03-06  Tom Tromey  <tom@tromey.com>
2650
2651         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
2652         * common/filestuff.h (make_cleanup_close): Don't declare.
2653         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
2654         Remove.
2655
2656 2019-03-06  Tom Tromey  <tom@tromey.com>
2657
2658         * solib-aix.c: Use make_scope_exit.
2659
2660 2019-03-06  Tom Tromey  <tom@tromey.com>
2661
2662         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
2663         Use make_scope_exit.
2664
2665 2019-03-06  Tom Tromey  <tom@tromey.com>
2666
2667         * solib-svr4.c (disable_probes_interface): Remove parameter.
2668         (svr4_handle_solib_event): Use make_scope_exit.
2669
2670 2019-03-06  Tom Tromey  <tom@tromey.com>
2671
2672         * remote.c (struct stop_reply_deleter): Remove.
2673         (stop_reply_up): Update.
2674         (struct stop_reply): Derive from notif_event.  Don't typedef.
2675         <regcache>: Now a std::vector.
2676         (stop_reply_xfree): Remove.
2677         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
2678         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
2679         (remote_target::discard_pending_stop_replies): Use delete.
2680         (remote_target::remote_parse_stop_reply): Update.
2681         (remote_target::process_stop_reply): Update.
2682         * remote-notif.h (struct notif_event): Add virtual destructor.
2683         Remove "dtr" member.
2684         (struct notif_client) <alloc_event>: Return a unique_ptr.
2685         (notif_event_xfree): Don't declare.
2686         (notif_event_up): New typedef.
2687         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
2688         (notif_event_xfree, do_notif_event_xfree): Remove.
2689         (remote_notif_state_xfree): Update.
2690
2691 2019-03-06  Tom Tromey  <tom@tromey.com>
2692
2693         * infrun.c (displaced_step_clear_cleanup): Now a
2694         forward_scope_exit type.
2695         (displaced_step_prepare_throw): Update.
2696         (displaced_step_fixup): Update.
2697
2698 2019-03-06  Tom Tromey  <tom@tromey.com>
2699
2700         * inferior.h (class inferior): Update comment.
2701         * gdbthread.h (class thread_info): Update comment.
2702
2703 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
2704             Tom Tromey  <tom@tromey.com>
2705
2706         * stabsread.h (struct stab_section_list): Remove.
2707         (coffstab_build_psymtabs): Update.
2708         * dbxread.c (symbuf_sections): Now a std::vector.
2709         (sect_idx): New global.
2710         (fill_symbuf): Update.
2711         (coffstab_build_psymtabs): Change type of stabsects parameter.
2712         Update.
2713         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
2714         std::vector.
2715         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
2716         (coff_locate_sections): Update.
2717         (coff_symfile_read): Remove cleanups.  Update.
2718         (init_stringtab): Add storage parameter.
2719         (free_stringtab, free_stringtab_cleanup): Remove.
2720         (init_lineno): Add storage parameter.
2721         (free_linetab, free_linetab_cleanup): Remove.
2722
2723 2019-03-06  Pedro Alves  <palves@redhat.com>
2724
2725         * linux-fork.c (fork_info::clobber_regs): Delete.
2726         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
2727         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
2728         comment.  Adjust.
2729         (scoped_switch_fork_info::scoped_switch_fork_info)
2730         (checkpoint_command, linux_fork_context): Adjust
2731         fork_save_infrun_state calls.
2732
2733 2019-03-06  Pedro Alves  <palves@redhat.com>
2734
2735         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
2736         (inf_has_multiple_threads): Return 'bool' and rewrite using
2737         inferior_info::threads().
2738
2739 2019-03-06  Pedro Alves  <palves@redhat.com>
2740
2741         * linux-fork.c: Include <list>.
2742         (fork_list): Now a std::list instance.
2743         (fork_info): Add ctor, dtor, and in-class initialize all fields.
2744         (forks_exist_p, find_last_fork): Adjust.
2745         (new_fork): Delete.
2746         (one_fork_p): New.
2747         (add_fork): Adjust.
2748         (free_fork): Delete, folded into fork_info::~fork_info().
2749         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
2750         Adjust.
2751         (init_fork_list): Delete.
2752         (linux_fork_killall, linux_fork_mourn_inferior)
2753         (linux_fork_detach, info_checkpoints_command): Adjust.
2754         (_initialize_linux_fork): No longer call init_fork_list.
2755
2756 2019-03-06  Pedro Alves  <palves@redhat.com>
2757
2758         * linux-fork.c (new_fork): New, split out of ...
2759         (add_fork): ... this.  Return void.  Move "first fork" special
2760         case from here, to ...
2761         (checkpoint_command): ... here.
2762         * linux-linux.h (add_fork): Return void.
2763
2764 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2765
2766         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
2767
2768 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2769             Chris January  <chris.january@arm.com>
2770             David Lecomber  <david.lecomber@arm.com>
2771
2772         * f-exp.y: New token, UNOP_INTRINSIC.
2773         (exp): New pattern using UNOP_INTRINSIC token.
2774         (f77_keywords): Add 'abs' keyword.
2775         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
2776         (value_from_host_double): New function.
2777         (evaluate_subexp_f): Support UNOP_ABS.
2778
2779 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2780
2781         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
2782         types.
2783
2784 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2785
2786         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
2787         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
2788         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
2789
2790 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2791
2792         * f-exp.y (convert_to_kind_type): Handle more type kinds.
2793
2794 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2795             Chris January  <chris.january@arm.com>
2796
2797         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
2798         * f-exp.y: Define 'KIND' token.
2799         (exp): New pattern for KIND expressions.
2800         (ptype): Handle types with a kind extension.
2801         (direct_abs_decl): Extend to spot kind extensions.
2802         (f77_keywords): Add 'kind' to the list.
2803         (push_kind_type): New function.
2804         (convert_to_kind_type): New function.
2805         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
2806         * parse.c (operator_length_standard): Likewise.
2807         * parser-defs.h (enum type_pieces): Add tp_kind.
2808         * std-operator.def: Add UNOP_KIND.
2809
2810 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2811
2812         * f-exp.y (f_parse): Set yydebug.
2813
2814 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2815
2816         * f-lang.c (evaluate_subexp_f): New function.
2817         (exp_descriptor_f): New global.
2818         (f_language_defn): Use exp_descriptor_f instead of
2819         exp_descriptor_standard.
2820
2821 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2822
2823         * f-exp.y (struct token): Add comments.
2824         (dot_ops): Remove uppercase versions and the end marker.
2825         (f77_keywords): Likewise.
2826         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
2827         entries in the dot_ops array are case insensitive, and use
2828         strncasecmp to compare strings.  Also some whitespace cleanup in
2829         this area.  Similar for the f77_keywords array, except entries in
2830         this list might be case sensitive.
2831
2832 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2833
2834         * f-exp.y (struct f77_boolean_val): Add comments.
2835         (boolean_values): Remove uppercase versions, and end marker.
2836         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
2837         and use strncasecmp to achieve case insensitivity.  Additionally,
2838         perform whitespace cleanup around this code.
2839
2840 2019-03-06  Tom Tromey  <tromey@adacore.com>
2841
2842         * remote-sim.c (gdbsim_target_open): Use result of
2843         gdb_argv::release.
2844
2845 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
2846         Dirk Schubert  <dirk.schubert@arm.com>
2847         Chris January  <chris.january@arm.com>
2848
2849         * eval.c (evaluate_subexp_standard): Call Fortran argument
2850         wrapping logic.
2851         * f-lang.c (struct value): A value which can be passed into a
2852         Fortran function call.
2853         (fortran_argument_convert): Wrap Fortran arguments in a pointer
2854         where appropriate.
2855         (struct type): Value ready for a Fortran function call.
2856         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
2857         is needed.
2858         * f-lang.h (fortran_argument_convert): Declaration.
2859         (fortran_preserve_arg_pointer): Declaration.
2860         * infcall.c (value_arg_coerce): Call Fortran argument logic.
2861
2862 2019-03-05  Tom Tromey  <tromey@adacore.com>
2863
2864         * python/py-prettyprint.c (print_string_repr): Remove #if.
2865         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
2866
2867 2019-03-05  Tom Tromey  <tromey@adacore.com>
2868
2869         * target.c (the_dummy_target): Move later.  Change type to
2870         "dummy_target".
2871         (initialize_targets): Don't initialize the_dummy_target.
2872
2873 2019-03-05  Tom Tromey  <tromey@adacore.com>
2874
2875         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
2876         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
2877
2878 2019-03-05  Tom Tromey  <tromey@adacore.com>
2879
2880         * windows-nat.c (windows_nat_target::attach)
2881         (windows_nat_target::detach): Don't call gdb_flush.
2882         * valprint.c (generic_val_print, val_print, val_print_string):
2883         Don't call gdb_flush.
2884         * utils.c (defaulted_query): Don't call gdb_flush.
2885         * typeprint.c (print_type_scalar): Don't call gdb_flush.
2886         * target.c (target_announce_detach): Don't call gdb_flush.
2887         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
2888         * remote.c (extended_remote_target::attach): Don't call
2889         gdb_flush.
2890         * procfs.c (procfs_target::detach): Don't call gdb_flush.
2891         * printcmd.c (do_examine): Don't call gdb_flush.
2892         (info_display_command): Don't call gdb_flush.
2893         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
2894         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
2895         * memattr.c (info_mem_command): Don't call gdb_flush.
2896         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
2897         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
2898         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
2899         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
2900         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
2901         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
2902         (gnu_nat_target::detach): Don't call gdb_flush.
2903         * f-valprint.c (f_val_print): Don't call gdb_flush.
2904         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
2905         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
2906         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
2907         gdb_flush.
2908         * c-valprint.c (c_val_print): Don't call gdb_flush.
2909         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
2910
2911 2019-03-05  Tom Tromey  <tromey@adacore.com>
2912
2913         * varobj.c (update_dynamic_varobj_children): Update.
2914         (install_default_visualizer): Use reset, not release.
2915         * value.c (set_internalvar): Update.
2916         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
2917         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
2918         ATTRIBUTE_UNUSED_RESULT.
2919
2920 2019-03-05  Tom Tromey  <tromey@adacore.com>
2921
2922         * remote.c (class scoped_remote_fd) <release>: Add
2923         ATTRIBUTE_UNUSED_RESULT.
2924
2925 2019-03-05  Tom Tromey  <tromey@adacore.com>
2926
2927         * macroexp.c (struct macro_buffer) <release>: Add
2928         ATTRIBUTE_UNUSED_RESULT.
2929
2930 2019-03-05  Tom Tromey  <tromey@adacore.com>
2931
2932         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
2933         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
2934         ATTRIBUTE_UNUSED_RESULT.
2935
2936 2019-03-05  Tom Tromey  <tromey@adacore.com>
2937
2938         * common/scoped_fd.h (class scoped_fd) <release>: Add
2939         ATTRIBUTE_UNUSED_RESULT.
2940
2941 2019-03-05  Tom Tromey  <tromey@adacore.com>
2942
2943         * parser-defs.h (struct parser_state) <release>: Add
2944         ATTRIBUTE_UNUSED_RESULT.
2945
2946 2019-03-05  Tom Tromey  <tromey@adacore.com>
2947
2948         * utils.h (class gdb_argv) <release>: Add
2949         ATTRIBUTE_UNUSED_RESULT.
2950         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
2951
2952 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
2953
2954         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
2955         for-loop range, to avoid compiler warnings.
2956
2957         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
2958         avoid compiler warnings about unused variables.
2959
2960         * NEWS: Mention end of support for native debugging on MS-Windows
2961         before XP.
2962
2963         PR gdb/24292
2964         * common/netstuff.c:
2965         * gdbserver/gdbreplay.c
2966         * gdbserver/remote-utils.c:
2967         * ser-tcp.c:
2968         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
2969         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
2970         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
2971         'getaddrinfo' and 'freeaddrinfo' were not available before
2972         Windows XP, and mingw.org's MinGW headers by default define
2973         _WIN32_WINNT to 0x500.
2974
2975 2019-03-01  Gary Benson <gbenson@redhat.com>
2976
2977         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
2978
2979 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
2980             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2981
2982         PR gdb/8527
2983         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
2984         set_sigint_trap, clear_sigint_trap.
2985
2986 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2987
2988         * target.c (target_detach): Clear the regcache and the
2989         frame cache.
2990
2991 2019-02-27  Pedro Alves  <palves@redhat.com>
2992
2993         * utils.c (set_screen_size): When we cap the height/width sizes,
2994         tweak the corresponding command variable to show "unlimited":
2995
2996 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
2997             Pedro Alves  <palves@redhat.com>
2998
2999         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3000         before calling rl_set_screen_size.
3001
3002 2019-02-27  Tom Tromey  <tromey@adacore.com>
3003
3004         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3005         define.
3006         * python/py-value.c: Remove Python 2.4 workaround.
3007         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3008         workaround.
3009         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3010         Python 2.4 workaround.
3011         * python/python-internal.h: Remove Python 2.4 comment.
3012         (Py_ssize_t): Don't define.
3013         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3014         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3015         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3016         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3017         * python/python.c (do_start_initialization): Remove Python 2.4
3018         workaround.
3019         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3020         (print_children): Remove Python 2.4 workaround.
3021         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3022         workaround.
3023         (CHARBUFFERPROC_NAME): Remove.
3024         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3025         Python 2.4 workaround.
3026
3027 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3028
3029         * NEWS: Note minimum Python version.
3030
3031 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3032
3033         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3034         code from these functions.  Remove corresponding ifdefs.  Use
3035         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3036         Remove gotos and target of gotos.
3037         (infpy_search_memory): Likewise.
3038
3039 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3040
3041         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3042         (hppa_gdbarch_init): Don't register deleted functions with
3043         gdbarch.
3044
3045 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3046
3047         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3048         (h8300_unwind_sp): Delete.
3049         (h8300_dummy_id): Delete.
3050         (h8300_gdbarch_init): Don't register deleted functions with
3051         gdbarch.
3052
3053 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3054
3055         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3056         (ft32_unwind_pc): Delete.
3057         (ft32_unwind_sp): Delete.
3058         (ft32_gdbarch_init): Don't register deleted functions with
3059         gdbarch.
3060
3061 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3062
3063         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3064         (frv_unwind_pc): Delete.
3065         (frv_unwind_sp): Delete.
3066         (frv_gdbarch_init): Don't register deleted functions with
3067         gdbarch.
3068
3069 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3070
3071         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3072         (riscv_unwind_pc): Delete.
3073         (riscv_unwind_sp): Delete.
3074         (riscv_gdbarch_init): Don't register deleted functions with
3075         gdbarch.
3076
3077 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3078
3079         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3080         (csky_unwind_pc): Delete.
3081         (csky_unwind_sp): Delete.
3082         (csky_gdbarch_init): Don't register deleted functions with
3083         gdbarch.
3084
3085 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3086
3087         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3088         (cris_unwind_pc): Delete.
3089         (cris_unwind_sp): Delete.
3090         (cris_gdbarch_init): Don't register deleted functions with
3091         gdbarch.
3092
3093 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3094
3095         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3096         (bfin_unwind_pc): Delete.
3097         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3098
3099 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3100
3101         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3102         (arm_unwind_pc): Delete.
3103         (arm_unwind_sp): Delete.
3104         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3105
3106 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3107
3108         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3109         (arc_unwind_pc): Delete.
3110         (arc_unwind_sp): Delete.
3111         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3112
3113 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3114
3115         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3116         (alpha_unwind_pc): Delete.
3117         (alpha_gdbarch_init): Don't register deleted functions with
3118         gdbarch.
3119
3120 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3121
3122         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3123         (aarch64_unwind_pc): Delete.
3124         (aarch64_unwind_sp): Delete.
3125         (aarch64_gdbarch_init): Don't register deleted functions with
3126         gdbarch.
3127
3128 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3129
3130         * gdbtypes.c (type_align): Don't consider static members when
3131         computing structure alignment.
3132
3133 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3134
3135         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3136         return 0 for other types.
3137         * arch-utils.c (default_type_align): Always return 0.
3138         * gdbarch.h: Regenerate.
3139         * gdbarch.sh (type_align): Extend comment.
3140         * gdbtypes.c (type_align): Add additional comments, always call
3141         gdbarch_type_align before applying the default rules.
3142         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3143         generic code will then apply a suitable default.
3144         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3145         types, return 0 for other types.
3146
3147 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3148
3149         * NEWS: Create a new section for the next release branch.
3150         Rename the section of the current branch, now that it has
3151         been cut.
3152
3153 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3154
3155         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3156         * version.in: Bump version to 8.3.50.DATE-git.
3157
3158 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3159
3160         * aix-thread.c (ptid_cmp): Remove unused variable.
3161         (get_signaled_thread): Likewise.
3162         (store_regs_user_thread): Likewise.
3163         (store_regs_kernel_thread): Likewise.
3164         (fetch_regs_kernel_thread): Remove shadowed variable.
3165
3166 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3167
3168         * features/riscv/32bit-cpu.xml: Add register numbers.
3169         * features/riscv/32bit-fpu.c: Regenerate.
3170         * features/riscv/32bit-fpu.xml: Add register numbers.
3171         * features/riscv/64bit-cpu.xml: Add register numbers.
3172         * features/riscv/64bit-fpu.c: Regenerate.
3173         * features/riscv/64bit-fpu.xml: Add register numbers.
3174
3175 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3176
3177         * NEWS: Mention two argument form of gdb.Value constructor.
3178         * python/py-value.c (convert_buffer_and_type_to_value): New
3179         function.
3180         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3181         Add support for handling an optional second argument.  Call
3182         convert_buffer_and_type_to_value as appropriate.
3183         * python/python-internal.h (Py_buffer_deleter): New struct.
3184         (Py_buffer_up): New typedef.
3185
3186 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3187
3188         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3189         instead of releasing ownership.
3190
3191 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3192
3193         * dwarf2read.c (open_and_init_dwp_file): Call
3194         elf_numsections instead of bfd_count_sections to initialize
3195         dwp_file->num_sections.
3196
3197 2019-02-25  Tom Tromey  <tromey@adacore.com>
3198
3199         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3200
3201 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3202
3203         * gcore.in: Add '--readnever' option when invoking GDB.
3204
3205 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3206
3207         * MAINTAINERS: Update my email address.
3208
3209 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3210
3211         * build-id.c (build_id_to_debug_bfd_1): New function.
3212         (build_id_to_debug_bfd): Look for separate debug file in
3213         sysroot.
3214
3215 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3216
3217         * gdbarch.sh: Update the copyright year range that is placed into
3218         generated files.
3219
3220 2019-02-22  Keith Seitz  <keiths@redhat.com>
3221
3222         PR symtab/23853
3223         * linespec.c (create_sals_line_offset): Search for the default
3224         symtab's filename instead of its fullname.
3225
3226 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3227
3228         * NEWS: Update style defaults.
3229
3230 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3231
3232         * main.c (captured_main_1): Disable styling in batch mode.
3233
3234 2019-02-20  Tom Tromey  <tom@tromey.com>
3235
3236         * symtab.c (symtab_symbol_info): Fix typos.
3237
3238 2019-02-20  Tom Tromey  <tromey@adacore.com>
3239
3240         * findcmd.c (_initialize_mem_search): Use upper case for
3241         metasyntactic variables.
3242
3243 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3244
3245         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3246         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3247
3248 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3249
3250         * top.h (source_file_name): Change to std::string.
3251         * top.c (source_file_name): Likewise.
3252         (command_line_input): Adjust.
3253         * cli/cli-script.c (script_from_file): Adjust.
3254
3255 2019-02-19  Tom Tromey  <tromey@adacore.com>
3256
3257         * ravenscar-thread.c
3258         (ravenscar_thread_target::update_thread_list): Don't call
3259         ada_build_task_list.
3260         * ada-lang.h (ada_build_task_list): Don't declare.
3261         * ada-tasks.c (struct ada_tasks_inferior_data)
3262         <task_list_valid_p>: Now bool.
3263         (read_known_tasks, ada_task_list_changed)
3264         (ada_tasks_invalidate_inferior_data): Update.
3265         (read_known_tasks_array): Return bool.
3266         (read_known_tasks_list): Likewise.
3267         (read_known_tasks): Return void.
3268         (ada_build_task_list): Now static.
3269
3270 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3271
3272         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3273         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3274
3275 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3276
3277         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3278         variant for ada_tasks_pspace_data_handle and
3279         ada_tasks_inferior_data_handle.
3280         (ada_tasks_pspace_data_cleanup): New function.
3281         (ada_tasks_inferior_data_cleanup): New function.
3282
3283 2019-02-17  Tom Tromey  <tom@tromey.com>
3284
3285         * macrotab.h (macro_source_fullname): Return a std::string.
3286         * macrotab.c (macro_include, check_for_redefinition)
3287         (macro_undef, macro_lookup_definition, foreach_macro)
3288         (foreach_macro_in_scope): Update.
3289         (macro_source_fullname): Return a std::string.
3290         * macrocmd.c (show_pp_source_pos): Update.
3291
3292 2019-02-17  Tom Tromey  <tom@tromey.com>
3293
3294         * macrocmd.c (show_pp_source_pos): Style the file names.
3295
3296 2019-02-17  Tom Tromey  <tom@tromey.com>
3297
3298         PR tui/24197:
3299         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3300
3301 2019-02-17  Tom Tromey  <tom@tromey.com>
3302
3303         * ada-lang.c (user_select_syms): Use filtered printing.
3304         * utils.c (wrap_style): New global.
3305         (desired_style): Remove.
3306         (emit_style_escape): Add stream parameter.
3307         (set_output_style, reset_terminal_style, prompt_for_continue):
3308         Update.
3309         (flush_wrap_buffer): Only flush gdb_stdout.
3310         (wrap_here): Set wrap_style.
3311         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3312         treat escape sequences as a character.  Change when wrap buffer is
3313         flushed.
3314         (fputs_styled): Do not set the output style when the default is
3315         requested.
3316         * ui-style.h (struct ui_file_style) <is_default>: New method.
3317         * source.c (print_source_lines_base): Emit escape sequences in one
3318         piece.
3319
3320 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3321
3322         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3323         integers and enumeration types.
3324
3325 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3326
3327         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3328         instead of lookup_symbol_in_language
3329         (do_exact_match): New function.
3330         (ada_get_symbol_name_matcher): Return do_exact_match when
3331         doing a verbatim match.
3332
3333 2019-02-15  Tom Tromey  <tromey@adacore.com>
3334
3335         * ravenscar-thread.c (ravenscar_thread_target::resume)
3336         (ravenscar_thread_target::wait): Special case wildcard requests.
3337
3338 2019-02-15  Tom Tromey  <tromey@adacore.com>
3339
3340         * ravenscar-thread.c (base_ptid): Remove.
3341         (struct ravenscar_thread_target) <close>: New method.
3342         <m_base_ptid>: New member.
3343         <update_inferior_ptid, active_task, task_is_currently_active,
3344         runtime_initialized>: Declare methods.
3345         <ravenscar_thread_target>: Add constructor.
3346         (ravenscar_thread_target::task_is_currently_active)
3347         (ravenscar_thread_target::update_inferior_ptid)
3348         (ravenscar_runtime_initialized): Rename.  Now methods.
3349         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3350         (ravenscar_thread_target::update_thread_list): Update.
3351         (ravenscar_thread_target::active_task): Now method.
3352         (ravenscar_thread_target::store_registers)
3353         (ravenscar_thread_target::prepare_to_store)
3354         (ravenscar_thread_target::prepare_to_store)
3355         (ravenscar_thread_target::mourn_inferior): Update.
3356         (ravenscar_inferior_created): Use "new" to create target.
3357         (ravenscar_thread_target::get_ada_task_ptid): Update.
3358         (_initialize_ravenscar): Don't initialize base_ptid.
3359         (ravenscar_ops): Remove global.
3360
3361 2019-02-15  Tom Tromey  <tromey@adacore.com>
3362
3363         * target.h (push_target): Declare new overload.
3364         * target.c (push_target): New overload, taking an rvalue reference.
3365         * remote.c (remote_target::open_1): Use push_target overload.
3366         * corelow.c (core_target_open): Use push_target overload.
3367
3368 2019-02-15  Tom Tromey  <tromey@adacore.com>
3369
3370         * ravenscar-thread.c (is_ravenscar_task)
3371         (ravenscar_task_is_currently_active): Return bool.
3372         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3373         (_initialize_ravenscar): Remove "(void)".
3374         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3375         Return bool.
3376
3377 2019-02-15  Tom Tromey  <tromey@adacore.com>
3378
3379         * ravenscar-thread.c (ravenscar_runtime_initializer)
3380         (has_ravenscar_runtime, get_running_thread_id)
3381         (ravenscar_thread_target::resume): Fix indentation.
3382
3383 2019-02-15  Tom Tromey  <tromey@adacore.com>
3384
3385         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3386         from ravenscar_arch_ops.
3387         (sparc_ravenscar_ops::fetch_registers)
3388         (sparc_ravenscar_ops::store_registers): Now methods.
3389         (sparc_ravenscar_prepare_to_store): Remove.
3390         (sparc_ravenscar_ops): Redefine.
3391         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
3392         methods and destructor.  Remove members.
3393         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
3394         (ravenscar_thread_target::store_registers)
3395         (ravenscar_thread_target::prepare_to_store): Update.
3396         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
3397         Remove.
3398         (struct ppc_ravenscar_powerpc_ops): Derive from
3399         ravenscar_arch_ops.
3400         (ppc_ravenscar_powerpc_ops::fetch_registers)
3401         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
3402         (ppc_ravenscar_powerpc_ops): Redefine.
3403         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
3404         (ppc_ravenscar_e500_ops::fetch_registers)
3405         (ppc_ravenscar_e500_ops::store_registers): Now methods.
3406         (ppc_ravenscar_e500_ops): Redefine.
3407         * aarch64-ravenscar-thread.c
3408         (aarch64_ravenscar_generic_prepare_to_store): Remove.
3409         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
3410         (aarch64_ravenscar_fetch_registers)
3411         (aarch64_ravenscar_store_registers): Now methods.
3412         (aarch64_ravenscar_ops): Redefine.
3413
3414 2019-02-15  Tom Tromey  <tromey@adacore.com>
3415
3416         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
3417         (ravenscar_thread_target::stopped_by_hw_breakpoint)
3418         (ravenscar_thread_target::stopped_by_watchpoint)
3419         (ravenscar_thread_target::stopped_data_address)
3420         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
3421
3422 2019-02-15  Tom Tromey  <tromey@adacore.com>
3423
3424         * ravenscar-thread.c: Fix some typos.
3425
3426 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3427             Tom Tromey  <tromey@adacore.com>
3428
3429         * ada-lang.c (ada_exception_sal): Change addr_string to a
3430         std::string.
3431         (create_ada_exception_catchpoint): Update.
3432
3433 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3434             Tom Tromey  <tromey@adacore.com>
3435
3436         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3437         (bp_location_ops): Remove.
3438         (base_breakpoint_allocate_location): Update.
3439         (free_bp_location): Update.
3440         * ada-lang.c (class ada_catchpoint_location)
3441         <ada_catchpoint_location>: Remove ops parameter.
3442         (ada_catchpoint_location_dtor): Remove.
3443         (ada_catchpoint_location_ops): Remove.
3444         (allocate_location_exception): Update.
3445         * breakpoint.h (struct bp_location_ops): Remove.
3446         (class bp_location) <bp_location>: Remove bp_location_ops
3447         parameter.
3448         <~bp_location>: Add destructor.
3449         <ops>: Remove.
3450
3451 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3452             Pedro Alves  <palves@redhat.com>
3453
3454         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3455         'PATH_MAX'.
3456
3457 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3458             Samuel Thibault  <samuel.thibault@gnu.org>
3459             Thomas Schwinge  <thomas@codesourcery.com>
3460
3461         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
3462         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
3463
3464 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3465
3466         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
3467         (check_empty): Use "const char *".
3468
3469         * gnu-nat.c (gnu_nat_target::detach): Instead of
3470         'detach_inferior (pid)' call
3471         'detach_inferior (find_inferior_pid (pid))'.
3472
3473         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
3474         'nat/fork-inferior.o'.
3475         * gnu-nat.c: #include "nat/fork-inferior.h".
3476
3477         * gnu-nat.c (gnu_nat_target::detach): Instead of
3478         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
3479         * gnu-nat.h: #include "inf-child.h".
3480         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
3481         'i386_gnu_nat_target::fetch_registers'.
3482         (gnu_store_registers): Rename/move to
3483         'i386_gnu_nat_target::store_registers'.
3484
3485         * config/i386/nm-i386gnu.h: Don't "#include" any files.
3486         * gnu-nat.h (mach_thread_info): New function.
3487         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
3488
3489         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
3490
3491 2019-02-14  Frederic Konrad  <konrad@adacore.com>
3492
3493         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
3494
3495 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
3496
3497         * windows-nat.c (windows_add_thread): Add new parameter
3498         "main_thread_p" with default value set to false.  Update
3499         function documentation as well as all callers.
3500         (windows_delete_thread): Likewise.
3501         (fake_create_process): Update call to windows_add_thread.
3502         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
3503         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
3504         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
3505         call to windows_delete_thread.
3506
3507 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
3508
3509         * MAINTAINERS: Add Andrew Burgess as global maintainer.
3510
3511 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3512
3513         * symfile.c (find_separate_debug_file): Use canonical path of
3514         sysroot with child_path instead of gdb_sysroot if it is valid.
3515
3516 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3517
3518         * symfile.c (find_separate_debug_file): Use child_path to
3519         determine if an object file is under a sysroot.
3520
3521 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3522
3523         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3524         unittests/child-path-selftests.c.
3525         * common/pathstuff.c (child_path): New function.
3526         * common/pathstuff.h (child_path): New prototype.
3527         * unittests/child-path-selftests.c: New file.
3528
3529 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3530
3531         * symfile.c (find_separate_debug_file): Look for separate debug
3532         files in debug directories under the sysroot.
3533
3534 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3535
3536         * symtab.h (struct minimal_symbol data_p): New const method.
3537         (struct minimal_symbol text_p): Likewise.
3538         * symtab.c (output_source_filename): Use file name style
3539         to print file name.
3540         (print_symbol_info): Likewise.
3541         (print_msymbol_info): Use address style to print addresses.
3542         Use function name style to print executable text symbols.
3543         (expand_symtab_containing_pc): Use data_p.
3544         (find_pc_sect_compunit_symtab): Likewise.
3545
3546 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3547
3548         * breakpoint.c (describe_other_breakpoints): Use address style
3549         to print addresses.
3550         (say_where): Likewise.
3551
3552 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3553
3554         * ada-typeprint.c (print_func_type): Print function name
3555         style to print function name.
3556         * c-typeprint.c (c_print_type_1): Likewise.
3557
3558 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
3559
3560         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
3561         for execve.
3562
3563 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3564
3565         * c-exp.y (direct_abs_decl): Use emplace_back to record the
3566         type_stack.
3567
3568 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
3569
3570         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
3571         TYPE_CODE_REF types.
3572
3573 2019-02-08  Jim Wilson  <jimw@sifive.com>
3574
3575         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
3576         (riscv_linux_fregset): New.
3577         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
3578
3579 2019-02-07  Tom Tromey  <tom@tromey.com>
3580
3581         * thread.c (thread_cancel_execution_command): Update.
3582         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
3583         methods.
3584         (struct thread_fsm_ops): Remove.
3585         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
3586         (thread_fsm_should_stop, thread_fsm_return_value)
3587         (thread_fsm_set_finished, thread_fsm_finished_p)
3588         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
3589         Don't declare.
3590         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
3591         * infrun.c (clear_proceed_status_thread)
3592         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
3593         (print_stop_event): Update.
3594         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
3595         Add constructor.
3596         (step_command_fsm_ops): Remove.
3597         (new_step_command_fsm): Remove.
3598         (step_1): Update.
3599         (step_command_fsm::should_stop): Rename from
3600         step_command_fsm_should_stop.
3601         (step_command_fsm::clean_up): Rename from
3602         step_command_fsm_clean_up.
3603         (step_command_fsm::do_async_reply_reason): Rename from
3604         step_command_fsm_async_reply_reason.
3605         (struct until_next_fsm): Inherit from thread_fsm.  Add
3606         constructor.
3607         (until_next_fsm_ops): Remove.
3608         (new_until_next_fsm): Remove.
3609         (until_next_fsm::should_stop): Rename from
3610         until_next_fsm_should_stop.
3611         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
3612         (until_next_fsm::do_async_reply_reason): Rename from
3613         until_next_fsm_async_reply_reason.
3614         (struct finish_command_fsm): Inherit from thread_fsm.  Add
3615         constructor.  Change type of breakpoint.
3616         (finish_command_fsm_ops): Remove.
3617         (new_finish_command_fsm): Remove.
3618         (finish_command_fsm::should_stop): Rename from
3619         finish_command_fsm_should_stop.
3620         (finish_command_fsm::clean_up): Rename from
3621         finish_command_fsm_clean_up.
3622         (finish_command_fsm::return_value): Rename from
3623         finish_command_fsm_return_value.
3624         (finish_command_fsm::do_async_reply_reason): Rename from
3625         finish_command_fsm_async_reply_reason.
3626         (finish_command): Update.
3627         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
3628         Add constructor.
3629         (call_thread_fsm_ops): Remove.
3630         (call_thread_fsm::call_thread_fsm): Rename from
3631         new_call_thread_fsm.
3632         (call_thread_fsm::should_stop): Rename from
3633         call_thread_fsm_should_stop.
3634         (call_thread_fsm::should_notify_stop): Rename from
3635         call_thread_fsm_should_notify_stop.
3636         (run_inferior_call, call_function_by_hand_dummy): Update.
3637         * cli/cli-interp.c (should_print_stop_to_console): Update.
3638         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
3639         Add constructor.  Change type of location_breakpoint,
3640         caller_breakpoint.
3641         (until_break_fsm_ops): Remove.
3642         (new_until_break_fsm): Remove.
3643         (until_break_fsm::should_stop): Rename from
3644         until_break_fsm_should_stop.
3645         (until_break_fsm::clean_up): Rename from
3646         until_break_fsm_clean_up.
3647         (until_break_fsm::do_async_reply_reason): Rename from
3648         until_break_fsm_async_reply_reason.
3649         (until_break_command): Update.
3650         * thread-fsm.c: Remove.
3651         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
3652
3653 2019-02-07  Tom Tromey  <tom@tromey.com>
3654
3655         * yy-remap.h: Add include guard.
3656         * xtensa-tdep.h: Add include guard.
3657         * xcoffread.h: Rename include guard.
3658         * varobj-iter.h: Add include guard.
3659         * tui/tui.h: Rename include guard.
3660         * tui/tui-winsource.h: Rename include guard.
3661         * tui/tui-wingeneral.h: Rename include guard.
3662         * tui/tui-windata.h: Rename include guard.
3663         * tui/tui-win.h: Rename include guard.
3664         * tui/tui-stack.h: Rename include guard.
3665         * tui/tui-source.h: Rename include guard.
3666         * tui/tui-regs.h: Rename include guard.
3667         * tui/tui-out.h: Rename include guard.
3668         * tui/tui-layout.h: Rename include guard.
3669         * tui/tui-io.h: Rename include guard.
3670         * tui/tui-hooks.h: Rename include guard.
3671         * tui/tui-file.h: Rename include guard.
3672         * tui/tui-disasm.h: Rename include guard.
3673         * tui/tui-data.h: Rename include guard.
3674         * tui/tui-command.h: Rename include guard.
3675         * tic6x-tdep.h: Add include guard.
3676         * target/waitstatus.h: Rename include guard.
3677         * target/wait.h: Rename include guard.
3678         * target/target.h: Rename include guard.
3679         * target/resume.h: Rename include guard.
3680         * target-float.h: Rename include guard.
3681         * stabsread.h: Add include guard.
3682         * rs6000-tdep.h: Add include guard.
3683         * riscv-fbsd-tdep.h: Add include guard.
3684         * regformats/regdef.h: Rename include guard.
3685         * record.h: Rename include guard.
3686         * python/python.h: Rename include guard.
3687         * python/python-internal.h: Rename include guard.
3688         * python/py-stopevent.h: Rename include guard.
3689         * python/py-ref.h: Rename include guard.
3690         * python/py-record.h: Rename include guard.
3691         * python/py-record-full.h: Rename include guard.
3692         * python/py-record-btrace.h: Rename include guard.
3693         * python/py-instruction.h: Rename include guard.
3694         * python/py-events.h: Rename include guard.
3695         * python/py-event.h: Rename include guard.
3696         * procfs.h: Add include guard.
3697         * proc-utils.h: Add include guard.
3698         * p-lang.h: Add include guard.
3699         * or1k-tdep.h: Rename include guard.
3700         * observable.h: Rename include guard.
3701         * nto-tdep.h: Rename include guard.
3702         * nat/x86-linux.h: Rename include guard.
3703         * nat/x86-linux-dregs.h: Rename include guard.
3704         * nat/x86-gcc-cpuid.h: Add include guard.
3705         * nat/x86-dregs.h: Rename include guard.
3706         * nat/x86-cpuid.h: Rename include guard.
3707         * nat/ppc-linux.h: Rename include guard.
3708         * nat/mips-linux-watch.h: Rename include guard.
3709         * nat/linux-waitpid.h: Rename include guard.
3710         * nat/linux-ptrace.h: Rename include guard.
3711         * nat/linux-procfs.h: Rename include guard.
3712         * nat/linux-osdata.h: Rename include guard.
3713         * nat/linux-nat.h: Rename include guard.
3714         * nat/linux-namespaces.h: Rename include guard.
3715         * nat/linux-btrace.h: Rename include guard.
3716         * nat/glibc_thread_db.h: Rename include guard.
3717         * nat/gdb_thread_db.h: Rename include guard.
3718         * nat/gdb_ptrace.h: Rename include guard.
3719         * nat/fork-inferior.h: Rename include guard.
3720         * nat/amd64-linux-siginfo.h: Rename include guard.
3721         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
3722         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
3723         * nat/aarch64-linux.h: Rename include guard.
3724         * nat/aarch64-linux-hw-point.h: Rename include guard.
3725         * mn10300-tdep.h: Add include guard.
3726         * mips-linux-tdep.h: Add include guard.
3727         * mi/mi-parse.h: Rename include guard.
3728         * mi/mi-out.h: Rename include guard.
3729         * mi/mi-main.h: Rename include guard.
3730         * mi/mi-interp.h: Rename include guard.
3731         * mi/mi-getopt.h: Rename include guard.
3732         * mi/mi-console.h: Rename include guard.
3733         * mi/mi-common.h: Rename include guard.
3734         * mi/mi-cmds.h: Rename include guard.
3735         * mi/mi-cmd-break.h: Rename include guard.
3736         * m2-lang.h: Add include guard.
3737         * location.h: Rename include guard.
3738         * linux-record.h: Rename include guard.
3739         * linux-nat.h: Add include guard.
3740         * linux-fork.h: Add include guard.
3741         * i386-darwin-tdep.h: Rename include guard.
3742         * hppa-linux-offsets.h: Add include guard.
3743         * guile/guile.h: Rename include guard.
3744         * guile/guile-internal.h: Rename include guard.
3745         * gnu-nat.h: Rename include guard.
3746         * gdb-stabs.h: Rename include guard.
3747         * frv-tdep.h: Add include guard.
3748         * f-lang.h: Add include guard.
3749         * event-loop.h: Add include guard.
3750         * darwin-nat.h: Rename include guard.
3751         * cp-abi.h: Rename include guard.
3752         * config/sparc/nm-sol2.h: Rename include guard.
3753         * config/nm-nto.h: Rename include guard.
3754         * config/nm-linux.h: Add include guard.
3755         * config/i386/nm-i386gnu.h: Rename include guard.
3756         * config/djgpp/nl_types.h: Rename include guard.
3757         * config/djgpp/langinfo.h: Rename include guard.
3758         * compile/gcc-cp-plugin.h: Add include guard.
3759         * compile/gcc-c-plugin.h: Add include guard.
3760         * compile/compile.h: Rename include guard.
3761         * compile/compile-object-run.h: Rename include guard.
3762         * compile/compile-object-load.h: Rename include guard.
3763         * compile/compile-internal.h: Rename include guard.
3764         * compile/compile-cplus.h: Rename include guard.
3765         * compile/compile-c.h: Rename include guard.
3766         * common/xml-utils.h: Rename include guard.
3767         * common/x86-xstate.h: Rename include guard.
3768         * common/version.h: Rename include guard.
3769         * common/vec.h: Rename include guard.
3770         * common/tdesc.h: Rename include guard.
3771         * common/selftest.h: Rename include guard.
3772         * common/scoped_restore.h: Rename include guard.
3773         * common/scoped_mmap.h: Rename include guard.
3774         * common/scoped_fd.h: Rename include guard.
3775         * common/safe-iterator.h: Rename include guard.
3776         * common/run-time-clock.h: Rename include guard.
3777         * common/refcounted-object.h: Rename include guard.
3778         * common/queue.h: Rename include guard.
3779         * common/ptid.h: Rename include guard.
3780         * common/print-utils.h: Rename include guard.
3781         * common/preprocessor.h: Rename include guard.
3782         * common/pathstuff.h: Rename include guard.
3783         * common/observable.h: Rename include guard.
3784         * common/netstuff.h: Rename include guard.
3785         * common/job-control.h: Rename include guard.
3786         * common/host-defs.h: Rename include guard.
3787         * common/gdb_wait.h: Rename include guard.
3788         * common/gdb_vecs.h: Rename include guard.
3789         * common/gdb_unlinker.h: Rename include guard.
3790         * common/gdb_unique_ptr.h: Rename include guard.
3791         * common/gdb_tilde_expand.h: Rename include guard.
3792         * common/gdb_sys_time.h: Rename include guard.
3793         * common/gdb_string_view.h: Rename include guard.
3794         * common/gdb_splay_tree.h: Rename include guard.
3795         * common/gdb_setjmp.h: Rename include guard.
3796         * common/gdb_ref_ptr.h: Rename include guard.
3797         * common/gdb_optional.h: Rename include guard.
3798         * common/gdb_locale.h: Rename include guard.
3799         * common/gdb_assert.h: Rename include guard.
3800         * common/filtered-iterator.h: Rename include guard.
3801         * common/filestuff.h: Rename include guard.
3802         * common/fileio.h: Rename include guard.
3803         * common/environ.h: Rename include guard.
3804         * common/common-utils.h: Rename include guard.
3805         * common/common-types.h: Rename include guard.
3806         * common/common-regcache.h: Rename include guard.
3807         * common/common-inferior.h: Rename include guard.
3808         * common/common-gdbthread.h: Rename include guard.
3809         * common/common-exceptions.h: Rename include guard.
3810         * common/common-defs.h: Rename include guard.
3811         * common/common-debug.h: Rename include guard.
3812         * common/cleanups.h: Rename include guard.
3813         * common/buffer.h: Rename include guard.
3814         * common/btrace-common.h: Rename include guard.
3815         * common/break-common.h: Rename include guard.
3816         * cli/cli-utils.h: Rename include guard.
3817         * cli/cli-style.h: Rename include guard.
3818         * cli/cli-setshow.h: Rename include guard.
3819         * cli/cli-script.h: Rename include guard.
3820         * cli/cli-interp.h: Rename include guard.
3821         * cli/cli-decode.h: Rename include guard.
3822         * cli/cli-cmds.h: Rename include guard.
3823         * charset-list.h: Add include guard.
3824         * buildsym-legacy.h: Rename include guard.
3825         * bfin-tdep.h: Add include guard.
3826         * ax.h: Rename include guard.
3827         * arm-linux-tdep.h: Add include guard.
3828         * arm-fbsd-tdep.h: Add include guard.
3829         * arch/xtensa.h: Rename include guard.
3830         * arch/tic6x.h: Add include guard.
3831         * arch/i386.h: Add include guard.
3832         * arch/arm.h: Rename include guard.
3833         * arch/arm-linux.h: Rename include guard.
3834         * arch/arm-get-next-pcs.h: Rename include guard.
3835         * arch/amd64.h: Add include guard.
3836         * arch/aarch64-insn.h: Rename include guard.
3837         * arch-utils.h: Rename include guard.
3838         * annotate.h: Add include guard.
3839         * amd64-darwin-tdep.h: Rename include guard.
3840         * aarch64-linux-tdep.h: Add include guard.
3841         * aarch64-fbsd-tdep.h: Add include guard.
3842         * aarch32-linux-nat.h: Add include guard.
3843
3844 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3845
3846         * macrotab.c (macro_define_internal): New function that
3847         factorizes macro_define_object_internal and macro_define_function
3848         code.
3849         (macro_define_object_internal): Use macro_define_internal.
3850         (macro_define_function): Likewise.
3851
3852 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3853
3854         * macrocmd.c (extract_identifier): Return
3855         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
3856         callers.
3857
3858 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
3859
3860         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
3861
3862 2019-02-05  Tom Tromey  <tom@tromey.com>
3863
3864         * target.c (target_stack::unpush): Move assertion earlier.
3865
3866 2019-01-30  Tom Tromey  <tom@tromey.com>
3867
3868         PR python/23615:
3869         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
3870         (gdbpy_parse_and_eval): Likewise.
3871         * python/python-internal.h (gdbpy_allow_threads): New class.
3872
3873 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
3874
3875         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
3876         (aarch64_fbsd_fpregmap): Move earlier.
3877         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
3878         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3879         instead of individual calls to trad_frame_set_reg_addr.
3880         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
3881         earlier.
3882         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
3883         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3884         instead of individual calls to trad_frame_set_reg_addr.
3885
3886 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
3887
3888         * CONTRIBUTE: Replace contribution list with wiki link.
3889
3890 2019-01-25  Tom Tromey  <tom@tromey.com>
3891
3892         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
3893
3894 2019-01-25  Tom Tromey  <tom@tromey.com>
3895
3896         * xtensa-linux-nat.c: Fix common/ includes.
3897         * xml-support.h: Fix common/ includes.
3898         * xml-support.c: Fix common/ includes.
3899         * x86-linux-nat.c: Fix common/ includes.
3900         * windows-nat.c: Fix common/ includes.
3901         * varobj.h: Fix common/ includes.
3902         * varobj.c: Fix common/ includes.
3903         * value.c: Fix common/ includes.
3904         * valops.c: Fix common/ includes.
3905         * utils.c: Fix common/ includes.
3906         * unittests/xml-utils-selftests.c: Fix common/ includes.
3907         * unittests/utils-selftests.c: Fix common/ includes.
3908         * unittests/unpack-selftests.c: Fix common/ includes.
3909         * unittests/tracepoint-selftests.c: Fix common/ includes.
3910         * unittests/style-selftests.c: Fix common/ includes.
3911         * unittests/string_view-selftests.c: Fix common/ includes.
3912         * unittests/scoped_restore-selftests.c: Fix common/ includes.
3913         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
3914         * unittests/scoped_fd-selftests.c: Fix common/ includes.
3915         * unittests/rsp-low-selftests.c: Fix common/ includes.
3916         * unittests/parse-connection-spec-selftests.c: Fix common/
3917         includes.
3918         * unittests/optional-selftests.c: Fix common/ includes.
3919         * unittests/offset-type-selftests.c: Fix common/ includes.
3920         * unittests/observable-selftests.c: Fix common/ includes.
3921         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
3922         * unittests/memrange-selftests.c: Fix common/ includes.
3923         * unittests/memory-map-selftests.c: Fix common/ includes.
3924         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
3925         * unittests/function-view-selftests.c: Fix common/ includes.
3926         * unittests/environ-selftests.c: Fix common/ includes.
3927         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
3928         * unittests/common-utils-selftests.c: Fix common/ includes.
3929         * unittests/cli-utils-selftests.c: Fix common/ includes.
3930         * unittests/array-view-selftests.c: Fix common/ includes.
3931         * ui-file.c: Fix common/ includes.
3932         * tui/tui-io.c: Fix common/ includes.
3933         * tracepoint.h: Fix common/ includes.
3934         * tracepoint.c: Fix common/ includes.
3935         * tracefile-tfile.c: Fix common/ includes.
3936         * top.h: Fix common/ includes.
3937         * top.c: Fix common/ includes.
3938         * thread.c: Fix common/ includes.
3939         * target/waitstatus.h: Fix common/ includes.
3940         * target/waitstatus.c: Fix common/ includes.
3941         * target.h: Fix common/ includes.
3942         * target.c: Fix common/ includes.
3943         * target-memory.c: Fix common/ includes.
3944         * target-descriptions.c: Fix common/ includes.
3945         * symtab.h: Fix common/ includes.
3946         * symfile.c: Fix common/ includes.
3947         * stap-probe.c: Fix common/ includes.
3948         * spu-linux-nat.c: Fix common/ includes.
3949         * sparc-nat.c: Fix common/ includes.
3950         * source.c: Fix common/ includes.
3951         * solib.c: Fix common/ includes.
3952         * solib-target.c: Fix common/ includes.
3953         * ser-unix.c: Fix common/ includes.
3954         * ser-tcp.c: Fix common/ includes.
3955         * ser-pipe.c: Fix common/ includes.
3956         * ser-base.c: Fix common/ includes.
3957         * selftest-arch.c: Fix common/ includes.
3958         * s12z-tdep.c: Fix common/ includes.
3959         * rust-exp.y: Fix common/ includes.
3960         * rs6000-aix-tdep.c: Fix common/ includes.
3961         * riscv-tdep.c: Fix common/ includes.
3962         * remote.c: Fix common/ includes.
3963         * remote-notif.h: Fix common/ includes.
3964         * remote-fileio.h: Fix common/ includes.
3965         * remote-fileio.c: Fix common/ includes.
3966         * regcache.h: Fix common/ includes.
3967         * regcache.c: Fix common/ includes.
3968         * record-btrace.c: Fix common/ includes.
3969         * python/python.c: Fix common/ includes.
3970         * python/py-type.c: Fix common/ includes.
3971         * python/py-inferior.c: Fix common/ includes.
3972         * progspace.h: Fix common/ includes.
3973         * producer.c: Fix common/ includes.
3974         * procfs.c: Fix common/ includes.
3975         * proc-api.c: Fix common/ includes.
3976         * printcmd.c: Fix common/ includes.
3977         * ppc-linux-nat.c: Fix common/ includes.
3978         * parser-defs.h: Fix common/ includes.
3979         * osdata.c: Fix common/ includes.
3980         * obsd-nat.c: Fix common/ includes.
3981         * nat/x86-linux.c: Fix common/ includes.
3982         * nat/x86-linux-dregs.c: Fix common/ includes.
3983         * nat/x86-dregs.h: Fix common/ includes.
3984         * nat/x86-dregs.c: Fix common/ includes.
3985         * nat/ppc-linux.c: Fix common/ includes.
3986         * nat/mips-linux-watch.h: Fix common/ includes.
3987         * nat/mips-linux-watch.c: Fix common/ includes.
3988         * nat/linux-waitpid.c: Fix common/ includes.
3989         * nat/linux-ptrace.h: Fix common/ includes.
3990         * nat/linux-ptrace.c: Fix common/ includes.
3991         * nat/linux-procfs.c: Fix common/ includes.
3992         * nat/linux-personality.c: Fix common/ includes.
3993         * nat/linux-osdata.c: Fix common/ includes.
3994         * nat/linux-namespaces.c: Fix common/ includes.
3995         * nat/linux-btrace.h: Fix common/ includes.
3996         * nat/linux-btrace.c: Fix common/ includes.
3997         * nat/fork-inferior.c: Fix common/ includes.
3998         * nat/amd64-linux-siginfo.c: Fix common/ includes.
3999         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4000         * nat/aarch64-linux.c: Fix common/ includes.
4001         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4002         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4003         * namespace.h: Fix common/ includes.
4004         * mips-linux-tdep.c: Fix common/ includes.
4005         * minsyms.c: Fix common/ includes.
4006         * mi/mi-parse.h: Fix common/ includes.
4007         * mi/mi-main.c: Fix common/ includes.
4008         * mi/mi-cmd-env.c: Fix common/ includes.
4009         * memrange.h: Fix common/ includes.
4010         * memattr.c: Fix common/ includes.
4011         * maint.h: Fix common/ includes.
4012         * maint.c: Fix common/ includes.
4013         * main.c: Fix common/ includes.
4014         * machoread.c: Fix common/ includes.
4015         * location.c: Fix common/ includes.
4016         * linux-thread-db.c: Fix common/ includes.
4017         * linux-nat.c: Fix common/ includes.
4018         * linux-fork.c: Fix common/ includes.
4019         * inline-frame.c: Fix common/ includes.
4020         * infrun.c: Fix common/ includes.
4021         * inflow.c: Fix common/ includes.
4022         * inferior.h: Fix common/ includes.
4023         * inferior.c: Fix common/ includes.
4024         * infcmd.c: Fix common/ includes.
4025         * inf-ptrace.c: Fix common/ includes.
4026         * inf-child.c: Fix common/ includes.
4027         * ia64-linux-nat.c: Fix common/ includes.
4028         * i387-tdep.c: Fix common/ includes.
4029         * i386-tdep.c: Fix common/ includes.
4030         * i386-linux-tdep.c: Fix common/ includes.
4031         * i386-linux-nat.c: Fix common/ includes.
4032         * i386-go32-tdep.c: Fix common/ includes.
4033         * i386-fbsd-tdep.c: Fix common/ includes.
4034         * i386-fbsd-nat.c: Fix common/ includes.
4035         * guile/scm-type.c: Fix common/ includes.
4036         * guile/guile.c: Fix common/ includes.
4037         * go32-nat.c: Fix common/ includes.
4038         * gnu-nat.c: Fix common/ includes.
4039         * gdbthread.h: Fix common/ includes.
4040         * gdbarch-selftests.c: Fix common/ includes.
4041         * gdb_usleep.c: Fix common/ includes.
4042         * gdb_select.h: Fix common/ includes.
4043         * gdb_bfd.c: Fix common/ includes.
4044         * gcore.c: Fix common/ includes.
4045         * fork-child.c: Fix common/ includes.
4046         * findvar.c: Fix common/ includes.
4047         * fbsd-nat.c: Fix common/ includes.
4048         * event-top.c: Fix common/ includes.
4049         * event-loop.c: Fix common/ includes.
4050         * dwarf2read.c: Fix common/ includes.
4051         * dwarf2loc.c: Fix common/ includes.
4052         * dwarf2-frame.c: Fix common/ includes.
4053         * dwarf-index-cache.c: Fix common/ includes.
4054         * dtrace-probe.c: Fix common/ includes.
4055         * disasm-selftests.c: Fix common/ includes.
4056         * defs.h: Fix common/ includes.
4057         * csky-tdep.c: Fix common/ includes.
4058         * cp-valprint.c: Fix common/ includes.
4059         * cp-support.h: Fix common/ includes.
4060         * cp-support.c: Fix common/ includes.
4061         * corelow.c: Fix common/ includes.
4062         * completer.h: Fix common/ includes.
4063         * completer.c: Fix common/ includes.
4064         * compile/compile.c: Fix common/ includes.
4065         * compile/compile-loc2c.c: Fix common/ includes.
4066         * compile/compile-cplus-types.c: Fix common/ includes.
4067         * compile/compile-cplus-symbols.c: Fix common/ includes.
4068         * command.h: Fix common/ includes.
4069         * cli/cli-dump.c: Fix common/ includes.
4070         * cli/cli-cmds.c: Fix common/ includes.
4071         * charset.c: Fix common/ includes.
4072         * build-id.c: Fix common/ includes.
4073         * btrace.h: Fix common/ includes.
4074         * btrace.c: Fix common/ includes.
4075         * breakpoint.h: Fix common/ includes.
4076         * breakpoint.c: Fix common/ includes.
4077         * ax.h: 
4078         (enum agent_op): Fix common/ includes.
4079         * ax-general.c (struct aop_map): Fix common/ includes.
4080         * ax-gdb.c: Fix common/ includes.
4081         * auxv.c: Fix common/ includes.
4082         * auto-load.c: Fix common/ includes.
4083         * arm-tdep.c: Fix common/ includes.
4084         * arch/riscv.c: Fix common/ includes.
4085         * arch/ppc-linux-common.c: Fix common/ includes.
4086         * arch/i386.c: Fix common/ includes.
4087         * arch/arm.c: Fix common/ includes.
4088         * arch/arm-linux.c: Fix common/ includes.
4089         * arch/arm-get-next-pcs.c: Fix common/ includes.
4090         * arch/amd64.c: Fix common/ includes.
4091         * arch/aarch64.c: Fix common/ includes.
4092         * arch/aarch64-insn.c: Fix common/ includes.
4093         * arch-utils.c: Fix common/ includes.
4094         * amd64-windows-tdep.c: Fix common/ includes.
4095         * amd64-tdep.c: Fix common/ includes.
4096         * amd64-sol2-tdep.c: Fix common/ includes.
4097         * amd64-obsd-tdep.c: Fix common/ includes.
4098         * amd64-nbsd-tdep.c: Fix common/ includes.
4099         * amd64-linux-tdep.c: Fix common/ includes.
4100         * amd64-linux-nat.c: Fix common/ includes.
4101         * amd64-fbsd-tdep.c: Fix common/ includes.
4102         * amd64-fbsd-nat.c: Fix common/ includes.
4103         * amd64-dicos-tdep.c: Fix common/ includes.
4104         * amd64-darwin-tdep.c: Fix common/ includes.
4105         * agent.c: Fix common/ includes.
4106         * ada-lang.h: Fix common/ includes.
4107         * ada-lang.c: Fix common/ includes.
4108         * aarch64-tdep.c: Fix common/ includes.
4109
4110 2019-01-25  Tom Tromey  <tom@tromey.com>
4111
4112         * common/create-version.sh: Use common/version.h.
4113
4114 2019-01-24  Pedro Alves  <palves@redhat.com>
4115
4116         * infrun.c (signal_stop, signal_print, signal_program)
4117         (signal_catch, signal_pass): Now arrays instead of pointers.
4118         (update_signals_program_target, do_target_resume)
4119         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4120         * linux-nat.c (linux_nat_target::pass_signals)
4121         (linux_nat_target::create_inferior, linux_nat_target::attach):
4122         Adjust.
4123         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4124         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4125         * procfs.c (procfs_target::pass_signals): Adjust.
4126         * record-full.c (record_full_target::resume): Adjust.
4127         * remote.c (remote_target::pass_signals)
4128         (remote_target::program_signals): Adjust.
4129         * target-debug.h (target_debug_print_signals): Now takes a
4130         gdb::array_view as parameter.  Adjust.
4131         * target.h (target_ops) <pass_signals, program_signals>: Replace
4132         pointer and length parameters with gdb::array_view.
4133         (target_pass_signals, target_program_signals): Likewise.
4134         * target-delegates.c: Regenerate.
4135
4136 2019-01-24  Pedro Alves  <palves@redhat.com>
4137
4138         * common/forward-scope-exit.h
4139         (forward_scope_exit::forward_scope_exit): Pass arguments to
4140         m_bind_function directly, instead of creating a std::bind and
4141         copying that.
4142
4143 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4144
4145         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4146         for static members.
4147         (pass_in_v_vfp_candidate): Likewise.
4148
4149 2019-01-23  Tom Tromey  <tom@tromey.com>
4150             Pedro Alves  <palves@redhat.com>
4151
4152         * regcache.c (class regcache_invalidator): Remove.
4153         (regcache::raw_write): Use make_scope_exit.
4154
4155 2019-01-23  Tom Tromey  <tom@tromey.com>
4156
4157         * ui-out.h (class ui_out_emit_type): Update comment.
4158
4159 2019-01-23  Tom Tromey  <tom@tromey.com>
4160
4161         * infrun.c (fetch_inferior_event): Update comment.
4162
4163 2019-01-23  Tom Tromey  <tom@tromey.com>
4164             Pedro Alves  <palves@redhat.com>
4165
4166         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4167         parameter.
4168         (fetch_inferior_event): Use SCOPE_EXIT.
4169
4170
4171 2019-01-23  Tom Tromey  <tom@tromey.com>
4172             Pedro Alves  <palves@redhat.com>
4173
4174         * infrun.c (disable_thread_events): Delete.
4175         (stop_all_threads): Use SCOPE_EXIT.
4176
4177 2019-01-23  Tom Tromey  <tom@tromey.com>
4178             Pedro Alves  <palves@redhat.com>
4179
4180         * symfile.c: Include forward-scope-exit.h.
4181         (clear_symtab_users_cleanup): Replace forward declaration with
4182         a FORWARD_SCOPE_EXIT.
4183         (syms_from_objfile_1): Use the forward_scope_exit and
4184         gdb::optional instead of cleanup_function.
4185         (reread_symbols): Use the forward_scope_exit instead of
4186         cleanup_function.
4187         (clear_symtab_users_cleanup): Remove function.
4188
4189 2019-01-23  Tom Tromey  <tom@tromey.com>
4190             Pedro Alves  <palves@redhat.com>
4191
4192         * linux-nat.c: Include scope-exit.h.
4193         (cleanup_target_stop): Remove.
4194         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4195         SCOPE_EXIT.
4196
4197 2019-01-23  Tom Tromey  <tom@tromey.com>
4198             Pedro Alves  <palves@redhat.com>
4199
4200         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4201         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4202
4203 2019-01-23  Tom Tromey  <tom@tromey.com>
4204             Andrew Burgess  <andrew.burgess@embecosm.com>
4205             Pedro Alves  <palves@redhat.com>
4206
4207         * infrun.c (fetch_inferior_event): Use scope_exit.
4208         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4209         * top.c (execute_command): Use scope_exit.
4210         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4211         * utils.c (do_bpstat_clear_actions_cleanup)
4212         (make_bpstat_clear_actions_cleanup): Remove.
4213
4214 2019-01-23  Tom Tromey  <tom@tromey.com>
4215             Pedro Alves  <palves@redhat.com>
4216
4217         * infrun.c: Include "common/scope-exit.h"
4218         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4219         (wait_for_inferior): Use SCOPE_EXIT.
4220         (fetch_inferior_event): Use scope_exit.
4221
4222 2019-01-23  Tom Tromey  <tom@tromey.com>
4223             Pedro Alves  <palves@redhat.com>
4224
4225         * breakpoint.c (create_breakpoint): Remove cleanup.
4226
4227 2019-01-23  Tom Tromey  <tom@tromey.com>
4228             Andrew Burgess  <andrew.burgess@embecosm.com>
4229             Pedro Alves  <palves@redhat.com>
4230
4231 2019-01-23  Pedro Alves  <palves@redhat.com>
4232
4233         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4234
4235 2019-01-23  Pedro Alves  <palves@redhat.com>
4236             Andrew Burgess  <andrew.burgess@embecosm.com>
4237
4238         * gdbthread.h: Include "common/forward-scope-exit.h".
4239         (scoped_finish_thread_state): Redefine custom class in terms of
4240         forward_scope_exit.
4241
4242 2019-01-23  Pedro Alves  <palves@redhat.com>
4243             Andrew Burgess  <andrew.burgess@embecosm.com>
4244
4245         * common/forward-scope-exit.h: New file.
4246
4247 2019-01-23  Pedro Alves  <palves@redhat.com>
4248             Andrew Burgess  <andrew.burgess@embecosm.com>
4249             Tom Tromey  <tom@tromey.com>
4250
4251         * common/scope-exit.h: New file.
4252
4253 2019-01-23  Pedro Alves  <palves@redhat.com>
4254
4255         * common/preprocessor.h (ESC): Rename to ...
4256         (ESC_PARENS): ... this.
4257         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4258         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4259
4260 2019-01-23  Tom Tromey  <tom@tromey.com>
4261
4262         * language.h (class scoped_switch_to_sym_language_if_auto):
4263         Initialize m_lang in both cases.
4264
4265 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4266
4267         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4268         with XCNEW.
4269
4270 2019-01-22  Tom Tromey  <tom@tromey.com>
4271
4272         * corelow.c: Do not include sys/file.h.
4273
4274 2019-01-22  Tom Tromey  <tom@tromey.com>
4275
4276         * tui/tui-wingeneral.h: Include gdb_curses.h.
4277
4278 2019-01-22  Tom Tromey  <tom@tromey.com>
4279
4280         * source-cache.h (class source_cache) <get_source_lines,
4281         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4282
4283 2019-01-22  Tom Tromey  <tom@tromey.com>
4284
4285         * remote-fileio.h (struct remote_target): Declare.
4286
4287 2019-01-22  Tom Tromey  <tom@tromey.com>
4288
4289         * python/py-arch.c: Do not include py-ref.h.
4290         * python/py-bpevent.c: Do not include py-ref.h.
4291         * python/py-cmd.c: Do not include py-ref.h.
4292         * python/py-continueevent.c: Do not include py-ref.h.
4293         * python/py-event.h: Do not include py-ref.h.
4294         * python/py-evtregistry.c: Do not include py-ref.h.
4295         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4296         * python/py-frame.c: Do not include py-ref.h.
4297         * python/py-framefilter.c: Do not include py-ref.h.
4298         * python/py-function.c: Do not include py-ref.h.
4299         * python/py-infevents.c: Do not include py-ref.h.
4300         * python/py-linetable.c: Do not include py-ref.h.
4301         * python/py-objfile.c: Do not include py-ref.h.
4302         * python/py-param.c: Do not include py-ref.h.
4303         * python/py-prettyprint.c: Do not include py-ref.h.
4304         * python/py-progspace.c: Do not include py-ref.h.
4305         * python/py-symbol.c: Do not include py-ref.h.
4306         * python/py-symtab.c: Do not include py-ref.h.
4307         * python/py-type.c: Do not include py-ref.h.
4308         * python/py-unwind.c: Do not include py-ref.h.
4309         * python/py-utils.c: Do not include py-ref.h.
4310         * python/py-value.c: Do not include py-ref.h.
4311         * python/py-varobj.c: Do not include py-ref.h.
4312         * python/py-xmethods.c: Do not include py-ref.h.
4313         * python/python.c: Do not include py-ref.h.
4314         * varobj.c: Do not include py-ref.h.
4315
4316 2019-01-22  Tom Tromey  <tom@tromey.com>
4317
4318         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4319         keyword for bcache.
4320
4321 2019-01-22  Tom Tromey  <tom@tromey.com>
4322
4323         * compile/compile-cplus-types.c: Remove a comment by #include.
4324
4325 2019-01-22  Tom Tromey  <tom@tromey.com>
4326
4327         * compile/gcc-c-plugin.h: Include compile-internal.h.
4328
4329 2019-01-22  Tom Tromey  <tom@tromey.com>
4330
4331         * stabsread.c (EXTERN): Do not define.
4332         (symnum, next_symbol_text_func, processing_gcc_compilation)
4333         (within_function, global_sym_chain, global_stabs)
4334         (previous_stab_code, this_object_header_files)
4335         (n_this_object_header_files)
4336         (n_allocated_this_object_header_files): Define.
4337         * stabsread.h (EXTERN): Never define.  Use "extern".
4338
4339 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4340
4341         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4342         history_value.
4343
4344 2019-01-21  Tom Tromey  <tom@tromey.com>
4345
4346         * ui-out.c: Fix includes.
4347         * tui/tui-source.c: Fix includes.
4348         * target.c: Fix includes.
4349         * remote.c: Fix includes.
4350         * regcache.c: Fix includes.
4351         * python/py-block.c: Fix includes.
4352         * printcmd.c: Fix includes.
4353         * or1k-tdep.c: Fix includes.
4354         * mi/mi-main.c: Fix includes.
4355         * m32r-tdep.c: Fix includes.
4356         * csky-tdep.c: Fix includes.
4357         * compile/compile-cplus-types.c: Fix includes.
4358         * cli/cli-interp.c: Fix includes.
4359
4360 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4361
4362         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4363         for padding.
4364
4365 2019-01-16  Tom Tromey  <tom@tromey.com>
4366
4367         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4368         earlier.
4369         (struct objfile) <msymbols_range>: Move from top level.
4370         <msymbols>: New method.
4371         (class objfile_msymbols): Remove.
4372         * symtab.c (default_collect_symbol_completion_matches_break_on):
4373         Update.
4374         * symmisc.c (dump_msymbols): Update.
4375         * stabsread.c (scan_file_globals): Update.
4376         * objc-lang.c (info_selectors_command, info_classes_command)
4377         (find_methods): Update.
4378         * minsyms.c (find_solib_trampoline_target): Update.
4379         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4380         * coffread.c (coff_symfile_read): Update.
4381         * ada-lang.c (ada_lookup_simple_minsym)
4382         (ada_collect_symbol_completion_matches): Update.
4383
4384 2019-01-16  Tom Tromey  <tom@tromey.com>
4385
4386         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4387         type.  Remove no-argument constructor.
4388         <iterator::operator++>: Simplify.
4389         <begin>: Update.
4390         <end>: Use minimal_symbol_count.
4391
4392 2019-01-16  Tom Tromey  <tom@tromey.com>
4393
4394         * objfiles.h (struct objfile) <psymtabs>: New method.
4395         (class objfile_psymtabs): Remove.
4396         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
4397         typedef.
4398         <range>: New method.
4399         (require_partial_symbols): Change return type.
4400         * psymtab.c (require_partial_symbols)
4401         (psym_expand_symtabs_matching): Update.
4402         * mdebugread.c (parse_partial_symbols): Update.
4403         * dbxread.c (dbx_end_psymtab): Update.
4404
4405 2019-01-15  Tom Tromey  <tom@tromey.com>
4406
4407         * symtab.c (lookup_objfile_from_block)
4408         (lookup_symbol_in_objfile_symtabs)
4409         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
4410         (find_line_symtab, info_sources_command)
4411         (default_collect_symbol_completion_matches_break_on)
4412         (make_source_files_completion_list): Update.
4413         * symmisc.c (print_objfile_statistics, dump_objfile)
4414         (maintenance_print_symbols, maintenance_info_symtabs)
4415         (maintenance_check_symtabs, maintenance_info_line_tables):
4416         Update.
4417         * source.c (select_source_symtab)
4418         (forget_cached_source_info_for_objfile): Update.
4419         * objfiles.h (class objfile_compunits): Remove.
4420         (struct objfile) <compunits_range>: New typedef.
4421         (compunits): New method.
4422         * objfiles.c (objfile_relocate1): Update.
4423         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4424         * maint.c (count_symtabs_and_blocks): Update.
4425         * linespec.c (iterate_over_all_matching_symtabs): Update.
4426         * cp-support.c (add_symbol_overload_list_qualified): Update.
4427         * coffread.c (coff_symtab_read): Update.
4428         * ada-lang.c (add_nonlocal_symbols)
4429         (ada_collect_symbol_completion_matches)
4430         (ada_add_global_exceptions): Update.
4431
4432 2019-01-15  Tom Tromey  <tom@tromey.com>
4433
4434         * progspace.h (program_space) <objfiles_safe_range>: New
4435         typedef.
4436         <objfiles_safe>: New method.
4437         * objfiles.h (class all_objfiles_safe): Remove.
4438         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4439         * jit.c (jit_inferior_exit_hook): Update.
4440
4441 2019-01-17  Tom Tromey  <tom@tromey.com>
4442
4443         * progspace.h (program_space) <objfiles_range>: New typedef.
4444         <objfiles>: New method.
4445         <objfiles_head>: Rename from objfiles.
4446         (object_files): Update.
4447         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4448         * guile/scm-pretty-print.c
4449         (ppscm_find_pretty_printer_from_objfiles): Update.
4450         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4451         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4452         Update.
4453         * python/py-progspace.c (pspy_get_objfiles): Update.
4454         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4455         Update.
4456         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4457         (objfpy_lookup_objfile_by_build_id): Update.
4458         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4459         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4460         Update.
4461         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4462         (expand_symtab_containing_pc, lookup_objfile_from_block)
4463         (lookup_static_symbol, basic_lookup_transparent_type)
4464         (find_pc_sect_compunit_symtab, find_symbol_at_address)
4465         (find_line_symtab, info_sources_command)
4466         (default_collect_symbol_completion_matches_break_on)
4467         (make_source_files_completion_list, find_main_name): Update.
4468         * symmisc.c (print_symbol_bcache_statistics)
4469         (print_objfile_statistics, maintenance_print_symbols)
4470         (maintenance_print_msymbols, maintenance_print_objfiles)
4471         (maintenance_info_symtabs, maintenance_check_symtabs)
4472         (maintenance_expand_symtabs, maintenance_info_line_tables):
4473         Update.
4474         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
4475         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
4476         (map_overlay_command, unmap_overlay_command)
4477         (simple_overlay_update, expand_symtabs_matching)
4478         (map_symbol_filenames): Update.
4479         * symfile-debug.c (set_debug_symfile): Update.
4480         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
4481         Update.
4482         * source.c (select_source_symtab, forget_cached_source_info):
4483         Update.
4484         * solib.c (solib_read_symbols): Update.
4485         * solib-spu.c (append_ocl_sos): Update.
4486         * psymtab.c (maintenance_print_psymbols)
4487         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
4488         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
4489         * printcmd.c (info_symbol_command): Update.
4490         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
4491         Update.
4492         * objfiles.h (class all_objfiles): Remove.
4493         * objfiles.c (have_partial_symbols, have_full_symbols)
4494         (have_minimal_symbols, qsort_cmp, update_section_map)
4495         (shared_objfile_contains_address_p)
4496         (default_iterate_over_objfiles_in_search_order): Update.
4497         * objc-lang.c (info_selectors_command, info_classes_command)
4498         (find_methods): Update.
4499         * minsyms.c (find_solib_trampoline_target): Update.
4500         * maint.c (maintenance_info_sections)
4501         (maintenance_translate_address, count_symtabs_and_blocks):
4502         Update.
4503         * main.c (captured_main_1): Update.
4504         * linux-thread-db.c (try_thread_db_load_from_pdir)
4505         (has_libpthread): Update.
4506         * linespec.c (iterate_over_all_matching_symtabs)
4507         (search_minsyms_for_name): Update.
4508         * jit.c (jit_find_objf_with_entry_addr): Update.
4509         * hppa-tdep.c (find_unwind_entry)
4510         (hppa_lookup_stub_minimal_symbol): Update.
4511         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
4512         Update.
4513         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4514         (elf_gnu_ifunc_resolve_by_got): Update.
4515         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
4516         * dwarf-index-write.c (save_gdb_index_command): Update.
4517         * cp-support.c (add_symbol_overload_list_qualified): Update.
4518         * breakpoint.c (create_overlay_event_breakpoint)
4519         (create_longjmp_master_breakpoint)
4520         (create_std_terminate_master_breakpoint)
4521         (create_exception_master_breakpoint): Update.
4522         * blockframe.c (find_pc_partial_function): Update.
4523         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
4524         (ada_collect_symbol_completion_matches)
4525         (ada_add_global_exceptions): Update.
4526
4527 2019-01-17  Tom Tromey  <tom@tromey.com>
4528
4529         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
4530         declare VEC.
4531         (solib_target_parse_libraries): Change return type.
4532         (library_list_start_segment, library_list_start_section)
4533         (library_list_end_library, library_list_start_library); Update.
4534         (solib_target_free_library_list): Remove.
4535         (solib_target_parse_libraries): Remove cleanup.  Change return
4536         type.
4537         (solib_target_current_sos): Update.
4538
4539 2019-01-17  Tom Tromey  <tromey@bapiya>
4540
4541         * valprint.c: Replace "the the" with "the".
4542         * symtab.c: Replace "the the" with "the".
4543         * solib.c: Replace "the the" with "the".
4544         * solib-dsbt.c: Replace "the the" with "the".
4545         * linespec.c: Replace "the the" with "the".
4546         * dwarf2loc.h: Replace "the the" with "the".
4547         * amd64-windows-tdep.c: Replace "the the" with "the".
4548         * aarch64-tdep.c: Replace "the the" with "the".
4549
4550 2019-01-16  Keith Seitz  <keiths@redhat.com>
4551
4552         PR gdb/23773
4553         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
4554         <builder>: Rename to ..
4555         <m_builder>: ... this and make private.
4556         (dwarf2_cu::get_builder): New method.  Change all users of
4557         `builder' to use this method.
4558         (dwarf2_start_symtab): Move to ...
4559         (dwarf2_cu::start_symtab): ... here.  Update all callers
4560         (setup_type_unit_groups): Move to ...
4561         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
4562         callers.
4563         (dwarf2_cu::reset_builder): New method.
4564         (process_full_compunit, process_full_type_unit): Use
4565         dwarf2_cu::reset_builder.
4566         (follow_die_offset): Record the ancestor CU if it is different
4567         from the followed DIE's CU.
4568         (follow_die_sig_1): Likewise.
4569
4570 2019-01-15  Tom Tromey  <tom@tromey.com>
4571
4572         * remote.c (class remote_state) <buf>: Now a char_vector.
4573         <buf_size>: Remove.
4574         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
4575         parameter.
4576         (remote_target::getpkt_or_notif_sane_1)
4577         (remote_target::getpkt_sane)
4578         (remote_target::getpkt_or_notif_sane): Likewise.
4579         (class remote_target) <putpkt>: New overload.
4580         (remote_target::read_frame): Change type of "buf_p".  Remove
4581         sizeof_p parameter.
4582         (packet_ok): New overload.
4583         (packet_check_result): New overload.
4584         Update all uses.
4585
4586 2019-01-14  Tom Tromey  <tom@tromey.com>
4587
4588         * remote-notif.c (handle_notification, remote_notif_ack)
4589         (remote_notif_parse): Make "buf" const.
4590         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
4591         const.
4592         (remote_notif_parse, remote_notif_ack, handle_notification):
4593         Likewise.
4594         * remote.c (remote_notif_stop_parse): Make "buf" const.
4595         (remote_target::remote_parse_stop_reply): Make "buf" const.
4596         (remote_notif_stop_ack): Make "buf" const.
4597
4598 2019-01-14  Tom Tromey  <tom@tromey.com>
4599
4600         * remote.c (remote_console_output): Make parameter const.
4601
4602 2019-01-14  Tom Tromey  <tom@tromey.com>
4603
4604         * target-debug.h (target_debug_print_signals): Constify.
4605         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
4606         * procfs.c (procfs_target::pass_signals): Update.
4607         * linux-nat.c (linux_nat_target::pass_signals): Update.
4608         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
4609         * target-delegates.c: Rebuild.
4610         * remote.c (remote_target::program_signals): Update.
4611         (remote_target::pass_signals): Update.
4612         * target.c (target_pass_signals): Constify argument.
4613         (target_program_signals): Likewise.
4614         * target.h (struct target_ops) <pass_signals, program_signals>:
4615         Constify argument.
4616         (target_pass_signals, target_program_signals): Constify argument.
4617
4618 2019-01-14  Tom Tromey  <tom@tromey.com>
4619
4620         PR tui/28819:
4621         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
4622
4623 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4624
4625         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
4626         field.
4627         * rs6000-tdep.c: Include reggroups.h.
4628         (IS_V_ALIAS_PSEUDOREG): Define.
4629         (rs6000_register_name): Return names for the "vX" aliases.
4630         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
4631         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
4632         aliases.  Call default_register_reggroup_p for all other
4633         pseudo-registers.
4634         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
4635         New functions.
4636         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
4637         Handle "vX" aliases.
4638         (v_alias_pseudo_register_collect): New function.
4639         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
4640         (rs6000_gdbarch_init): Initialize "vX" aliases as
4641         pseudo-registers.  Restore registration of
4642         rs6000_pseudo_register_reggroup_p with
4643         set_tdesc_pseudo_register_reggroup_p.
4644
4645 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
4646
4647         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
4648         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
4649         set_gdbarch_num_pseudo_regs.
4650
4651 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4652
4653         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
4654         Remove arg prefixname, add do_set and do_show.
4655         Add member functions set_list and show_list.
4656         * cli/cli-style.c (class cli_style_option): Update accordingly.
4657         (style_set_list): Move to file scope.
4658         (style_show_list): Likewise.
4659         (set_style): Call help_list.
4660         (show_style): Call cmd_show_list.
4661         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
4662         Update to use the new macro.
4663
4664 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
4665
4666         * ada-lang.c (_initialize_ada_language): Expand the help text
4667         for the "catch exception" command.
4668
4669 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4670
4671         * symtab.c (matching_obj_sections): Initialize obj,
4672         declare it closer to its usage.
4673
4674 2019-01-10  Tom Tromey  <tom@tromey.com>
4675
4676         * thread-iter.h (inf_threads_iterator): Use next_iterator.
4677         (basic_inf_threads_range): Remove.
4678         (inf_threads_range, inf_non_exited_threads_range)
4679         (safe_inf_threads_range): Use next_adapter.
4680
4681 2019-01-10  Keith Seitz  <keiths@redhat.com>
4682
4683         PR gdb/23712
4684         PR symtab/23010
4685         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
4686         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
4687
4688 2019-01-10  Keith Seitz  <keiths@redhat.com>
4689
4690         PR gdb/23712
4691         PR symtab/23010
4692         * dictionary.c (pending_to_vector): Remove.
4693         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4694         Remove _1 suffix, replacing functions of the same name.  Update
4695         all callers.
4696         (dict_create_hashed, dict_create_hashed_expandable)
4697         (dict_create_linear, dict_create_linear_expandable, dict_free)
4698         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
4699         Make functions static.
4700
4701 2019-01-10  Keith Seitz  <keiths@redhat.com>
4702
4703         PR gdb/23712
4704         PR symtab/23010
4705         * dictionary.h (struct dictionary): Replace declaration with
4706         multidictionary.
4707         (dict_create_hashed, dict_create_hashed_expandable)
4708         (dict_create_linear, dict_create_linear_expandable)
4709         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
4710         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
4711         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
4712         taking multidictionary argument.
4713         [ALL_DICT_SYMBOLS]: Update for multidictionary.
4714         * block.h (struct block) <dict>: Change to multidictionary
4715         and rename `multidict'.
4716         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
4717         symmisc.c: Update all dictionary references to multidictionary.
4718
4719 2019-01-10  Keith Seitz  <keiths@redhat.com>
4720
4721         PR gdb/23712
4722         PR symtab/23010
4723         * dictionary.c: Include unordered_map.
4724         (pending_to_vector): New function.
4725         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4726         Rewrite the non-"_1" functions to take vector instead
4727         of linked list.
4728         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
4729         "new" _1 versions of the same name.
4730         (multidictionary): Define.
4731         (std::hash<enum language): New definition.
4732         (collate_pending_symbols_by_language, mdict_create_hashed)
4733         (mdict_create_hashed_expandable, mdict_create_linear)
4734         (mdict_create_linear_expandable, mdict_free)
4735         (find_language_dictionary, create_new_language_dictionary)
4736         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
4737         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
4738         (mdict_size, mdict_empty): New functions.
4739         * dictionary.h (mdict_iterator): Define.
4740
4741 2019-01-10  Pedro Alves  <palves@redhat.com>
4742
4743         * breakpoint.c (read_uploaded_action)
4744         (create_tracepoint_from_upload): Adjust to use
4745         gdb::unique_xmalloc_ptr.
4746         * ctf.c (ctf_write_uploaded_tp):
4747         (SET_ARRAY_FIELD): Use emplace_back.
4748         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
4749         * tracefile-tfile.c (tfile_write_uploaded_tp):
4750         * tracepoint.c (parse_tracepoint_definition): Adjust to use
4751         gdb::unique_xmalloc_ptr.
4752         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
4753         at_string, cond_string, cmd_strings>: Replace char pointers
4754         with gdb::unique_xmalloc_ptr.
4755
4756 2019-01-10  Pedro Alves  <palves@redhat.com>
4757
4758         * solib-target.c (library_list_start_library): Don't xstrdup name.
4759
4760 2019-01-10  Pedro Alves  <palves@redhat.com>
4761
4762         * mdebugread.c (parse_partial_symbols): Use
4763         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
4764
4765 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4766
4767         * linux-fork.c (scoped_switch_fork_info)
4768         <~scoped_switch_fork_info>: Fix incorrect variable name.
4769
4770 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4771
4772         * linux-fork.c (scoped_switch_fork_info)
4773         <scoped_switch_fork_info>: Make explicit.
4774         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
4775
4776 2019-01-10  Tom Tromey  <tom@tromey.com>
4777
4778         * objfiles.h (objfile::reset_psymtabs): Update.
4779         * objfiles.c (objfile::objfile): Update.
4780         * psymtab.h (psymtab_storage::obstack): Update.
4781         (psymtab_storage::m_obstack): Use gdb::optional.
4782         (class psymtab_storage): Update comment.  Remove objfile
4783         parameter.
4784         * psymtab.c (psymtab_storage::psymtab_storage): Update.
4785
4786 2019-01-10  Tom Tromey  <tom@tromey.com>
4787
4788         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
4789         <free_psymtabs>: Now private.
4790         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
4791         (allocate_psymtab): Use new method.
4792
4793 2019-01-10  Tom Tromey  <tom@tromey.com>
4794
4795         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
4796         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
4797         * mdebugread.c (parse_partial_symbols): Use
4798         allocate_dependencies.
4799         * dwarf2read.c (dwarf2_create_include_psymtab): Use
4800         allocate_dependencies.
4801         (process_psymtab_comp_unit_reader)
4802         (build_type_psymtab_dependencies): Likewise.
4803         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
4804
4805 2019-01-10  Tom Tromey  <tom@tromey.com>
4806
4807         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
4808         PSYMBOL_SET_LANGUAGE.
4809         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
4810
4811 2019-01-10  Tom Tromey  <tom@tromey.com>
4812
4813         * psymtab.h (psymtab_storage::obstack): New method.
4814         <m_obstack>: Rename from obstack; now private.
4815         * psymtab.c (psymtab_storage): Update.
4816         * dwarf2read.c (create_addrmap_from_index)
4817         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
4818         Update.
4819
4820 2019-01-10  Tom Tromey  <tom@tromey.com>
4821
4822         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
4823         * objfiles.h (objfile::reset_psymtabs): New method.
4824
4825 2019-01-10  Tom Tromey  <tom@tromey.com>
4826
4827         * symmisc.c (print_symbol_bcache_statistics): Update.
4828         (print_objfile_statistics): Update.
4829         * symfile.c (reread_symbols): Update.
4830         * psymtab.h (class psymtab_storage): New.
4831         * psymtab.c (psymtab_storage): New constructor.
4832         (~psymtab_storage): New destructor.
4833         (require_partial_symbols): Update.
4834         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
4835         (find_pc_sect_psymtab, find_pc_sect_psymbol)
4836         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
4837         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
4838         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
4839         (start_psymtab_common, end_psymtab_common)
4840         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
4841         (allocate_psymtab): Update.
4842         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
4843         Update.
4844         (dump_psymtab_addrmap, maintenance_print_psymbols)
4845         (maintenance_check_psymtabs): Update.
4846         (class objfile_psymtabs): Move to objfiles.h.
4847         * psympriv.h (discard_psymtab): Now inline.
4848         (psymtab_discarder::psymtab_discarder): Update.
4849         (psymtab_discarder::~psymtab_discarder): Update.
4850         (ALL_OBJFILE_PSYMTABS): Rewrite.
4851         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
4852         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
4853         Remove fields.
4854         <partial_symtabs>: New field.
4855         (class objfile_psymtabs): Move from psymtab.h.  Update.
4856         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
4857         psymbol_cache.
4858         (objfile::~objfile): Don't destroy psymbol_cache.
4859         * mdebugread.c (parse_partial_symbols): Update.
4860         * dwarf2read.c (create_addrmap_from_index)
4861         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4862         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
4863         (add_partial_subprogram, dwarf2_ranges_read): Update.
4864         * dwarf-index-write.c (write_address_map)
4865         (write_one_signatured_type, recursively_write_psymbols)
4866         (class debug_names, class debug_names, write_psymtabs_to_index):
4867         Update.
4868
4869 2019-01-10  Tom Tromey  <tom@tromey.com>
4870
4871         * symtab.h (SYMBOL_SET_NAMES): Update.
4872         (symbol_set_names): Update.
4873         (MSYMBOL_SET_NAMES): Update.
4874         * symtab.c (symbol_set_names): Change argument to be an
4875         objfile_per_bfd_storage.
4876         * psymtab.c (add_psymbol_to_bcache): Update.
4877         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
4878
4879 2019-01-10  Tom Tromey  <tom@tromey.com>
4880
4881         * symtab.c (create_demangled_names_hash): Change argument to be an
4882         objfile_per_bfd_storage.
4883         (symbol_set_names): Update.
4884
4885 2019-01-10  Tom Tromey  <tom@tromey.com>
4886
4887         * xcoffread.c (xcoff_initial_scan): Unconditionally call
4888         init_psymbol_list.
4889         * psymtab.c (init_psymbol_list): Do nothing if already called.
4890         * psympriv.h (init_psymbol_list): Add comment.
4891         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
4892         init_psymbol_list.
4893         * dbxread.c (dbx_symfile_read): Unconditionally call
4894         init_psymbol_list.
4895
4896 2019-01-10  Tom Tromey  <tom@tromey.com>
4897
4898         * xcoffread.c (scan_xcoff_symtab): Update.
4899         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
4900         "where".
4901         * mdebugread.c (parse_partial_symbols)
4902         (handle_psymbol_enumerators): Update.
4903         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
4904         * dbxread.c (read_dbx_symtab): Update.
4905         * psympriv.h (psymbol_placement): New enum.
4906         (add_psymbol_to_list): Update.
4907
4908 2019-01-10  Tom Tromey  <tom@tromey.com>
4909
4910         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
4911         static_psymbols parameters.
4912         (scan_xcoff_symtab): Update.
4913         * psymtab.c (start_psymtab_common): Remove global_psymbols and
4914         static_psymbols parameters.
4915         * psympriv.h (start_psymtab_common): Update.
4916         * mdebugread.c (parse_partial_symbols): Update.
4917         * dwarf2read.c (create_partial_symtab): Update.
4918         * dbxread.c (read_dbx_symtab): Update.
4919         (start_psymtab): Remove global_psymbols and static_psymbols
4920         parameters.
4921
4922 2019-01-10  Tom Tromey  <tom@tromey.com>
4923
4924         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
4925         * psymtab.c (allocate_psymtab): Add comment.
4926         * psympriv.h (allocate_psymtab): Add comment.
4927         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
4928         initializations.
4929         * dbxread.c (dbx_end_psymtab): Remove some initializations.
4930
4931 2019-01-10  Tom Tromey  <tom@tromey.com>
4932
4933         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4934         Don't declare.
4935         * mipsread.c: Include mdebugread.h.
4936         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4937         Declare.
4938         * elfread.c: Include mdebugread.h.
4939
4940 2019-01-09  Tom Tromey  <tom@tromey.com>
4941
4942         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
4943         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
4944         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
4945         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
4946         (psym_lookup_symbol, psym_find_last_source_symtab)
4947         (psym_forget_cached_source_info, psym_print_stats)
4948         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
4949         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
4950         (psym_map_matching_symbols, psym_expand_symtabs_matching)
4951         (psym_find_compunit_symtab_by_address)
4952         (maintenance_print_psymbols, maintenance_info_psymtabs)
4953         (maintenance_check_psymtabs): Use ranged for.
4954         * psymtab.h (class objfile_psymtabs): New.
4955         (require_partial_symbols): Return objfile_psymtabs.
4956         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
4957
4958 2019-01-09  Tom Tromey  <tom@tromey.com>
4959
4960         * symfile.c (overlay_invalidate_all, find_pc_overlay)
4961         (find_pc_mapped_section, list_overlays_command)
4962         (map_overlay_command, unmap_overlay_command)
4963         (simple_overlay_update): Use all_objfiles.
4964         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
4965         * printcmd.c (info_symbol_command): Use all_objfiles.
4966         * objfiles.h (ALL_OBJSECTIONS): Remove.
4967         * maint.c (maintenance_translate_address): Use all_objfiles.
4968         * gcore.c (gcore_create_callback): Use all_objfiles.
4969         (objfile_find_memory_regions): Likewise.
4970
4971 2019-01-09  Tom Tromey  <tom@tromey.com>
4972
4973         * symtab.c (find_line_symtab, info_sources_command)
4974         (make_source_files_completion_list): Use objfile_compunits.
4975         * source.c (select_source_symtab): Use objfile_compunits.
4976         * objfiles.h (struct objfile): Update comment.
4977         (ALL_OBJFILES): Remove.
4978         (ALL_FILETABS): Remove.
4979         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
4980         objfile_compunits.
4981
4982 2019-01-09  Tom Tromey  <tom@tromey.com>
4983
4984         * symmisc.c (print_objfile_statistics, dump_objfile)
4985         (maintenance_print_symbols): Use compunit_filetabs.
4986         * source.c (forget_cached_source_info_for_objfile): Use
4987         compunit_filetabs.
4988         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
4989         (ALL_FILETABS): Use compunit_filetabs.
4990         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
4991         * coffread.c (coff_symtab_read): Use compunit_filetabs.
4992
4993 2019-01-09  Tom Tromey  <tom@tromey.com>
4994
4995         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
4996         (compunit_filetabs): New.
4997         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
4998         compunit_filetabs.
4999         (info_sources_command, make_source_files_completion_list): Remove
5000         declaration.
5001         * symmisc.c (print_objfile_statistics, dump_objfile)
5002         (maintenance_print_symbols): Remove declaration.
5003         (maintenance_info_symtabs): Use compunit_filetabs.
5004         (maintenance_info_line_tables): Likewise.
5005         * source.c (select_source_symtab): Change local variable name.
5006         (forget_cached_source_info_for_objfile): Remove declaration.
5007         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5008         * objfiles.c (objfile_relocate1): Remove declaration.
5009         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5010         declaration.
5011         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5012         * coffread.c (coff_symtab_read): Remove declaration.
5013         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5014         compunit_filetabs.
5015
5016 2019-01-09  Tom Tromey  <tom@tromey.com>
5017
5018         * symtab.c (lookup_objfile_from_block)
5019         (find_pc_sect_compunit_symtab, search_symbols)
5020         (default_collect_symbol_completion_matches_break_on): Use
5021         objfile_compunits.
5022         * objfiles.h (ALL_COMPUNITS): Remove.
5023         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5024         * cp-support.c (add_symbol_overload_list_qualified): Use
5025         objfile_compunits.
5026         * ada-lang.c (ada_collect_symbol_completion_matches)
5027         (ada_add_global_exceptions): Use objfile_compunits.
5028
5029 2019-01-09  Tom Tromey  <tom@tromey.com>
5030
5031         * source.c (select_source_symtab)
5032         (forget_cached_source_info_for_objfile): Remove declaration.
5033         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5034         declaration.
5035         * maint.c (count_symtabs_and_blocks): Remove declaration.
5036         * cp-support.c (add_symbol_overload_list_qualified): Remove
5037         declaration.
5038         * coffread.c (coff_symtab_read): Remove declaration.
5039         * symtab.c (lookup_symbol_in_objfile_symtabs)
5040         (basic_lookup_transparent_type_1): Use objfile_compunits.
5041         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5042         (info_sources_command, search_symbols)
5043         (default_collect_symbol_completion_matches_break_on)
5044         (make_source_files_completion_list): Remove declaration.
5045         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5046         (ada_collect_symbol_completion_matches)
5047         (ada_add_global_exceptions): Remove declaration.
5048         * linespec.c (iterate_over_all_matching_symtabs): Use
5049         objfile_compunits.
5050         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5051         (class objfile_compunits): New.
5052         (ALL_COMPUNITS): Use objfile_compunits.
5053         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5054         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5055         objfile_compunits.
5056         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5057
5058 2019-01-09  Tom Tromey  <tom@tromey.com>
5059
5060         * symtab.c (search_symbols)
5061         (default_collect_symbol_completion_matches_break_on): Use
5062         objfile_msymbols.
5063         * ada-lang.c (ada_lookup_simple_minsym)
5064         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5065         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5066         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5067         objfile_msymbols.
5068         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5069         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5070         * objc-lang.c (find_methods): Use objfile_msymbols.
5071         (info_selectors_command, info_classes_command): Likewise.
5072         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5073         * objfiles.h (class objfile_msymbols): New.
5074         (ALL_OBJFILE_MSYMBOLS): Remove.
5075         (ALL_MSYMBOLS): Remove.
5076
5077 2019-01-09  Tom Tromey  <tom@tromey.com>
5078
5079         * common/next-iterator.h (next_adapter): Add Iterator template
5080         parameter.
5081         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5082         (class all_objfiles_safe): New.
5083         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5084         * objfiles.c (put_objfile_before): Update comment.
5085         (add_separate_debug_objfile): Likewise.
5086         (free_all_objfiles): Use all_objfiles_safe.
5087         (objfile_purge_solibs): Likewise.
5088
5089 2019-01-09  Tom Tromey  <tom@tromey.com>
5090
5091         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5092         (expand_symtab_containing_pc, lookup_static_symbol)
5093         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5094         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5095         all_objfiles.
5096         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5097         * breakpoint.c (create_overlay_event_breakpoint)
5098         (create_longjmp_master_breakpoint)
5099         (create_std_terminate_master_breakpoint)
5100         (create_exception_master_breakpoint): Use all_objfiles.
5101         * linux-thread-db.c (try_thread_db_load_from_pdir)
5102         (has_libpthread): Use all_objfiles.
5103         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5104         * linespec.c (iterate_over_all_matching_symtabs)
5105         (search_minsyms_for_name): Use all_objfiles.
5106         * maint.c (maintenance_info_sections): Use all_objfiles.
5107         * main.c (captured_main_1): Use all_objfiles.
5108         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5109         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5110         * guile/scm-pretty-print.c
5111         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5112         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5113         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5114         (maintenance_print_msymbols): Use all_objfiles.
5115         * source.c (select_source_symtab): Use all_objfiles.
5116         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5117         * symfile.c (remove_symbol_file_command)
5118         (expand_symtabs_matching, map_symbol_filenames): Use
5119         all_objfiles.
5120         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5121         all_objfiles.
5122         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5123         * objc-lang.c (find_methods): Use all_objfiles.
5124         * objfiles.c (have_partial_symbols, have_full_symbols)
5125         (have_minimal_symbols, qsort_cmp)
5126         (default_iterate_over_objfiles_in_search_order): Use
5127         all_objfiles.
5128         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5129         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5130         (maintenance_check_psymtabs): Use all_objfiles.
5131         (ALL_PSYMTABS): Remove.
5132         * compile/compile-object-run.c (do_module_cleanup): Use
5133         all_objfiles.
5134         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5135         * cp-support.c (add_symbol_overload_list_qualified): Use
5136         all_objfiles.
5137         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5138         Use all_objfiles.
5139         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5140         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5141         all_objfiles.
5142         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5143         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5144         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5145         Uses all_objfiles.
5146         * solib.c (solib_read_symbols): Use all_objfiles
5147
5148 2019-01-09  Tom Tromey  <tom@tromey.com>
5149
5150         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5151         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5152         all_objfiles.
5153         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5154         * symmisc.c (print_symbol_bcache_statistics)
5155         (print_objfile_statistics, maintenance_print_objfiles)
5156         (maintenance_info_symtabs, maintenance_check_symtabs)
5157         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5158         all_objfiles.
5159         * source.c (forget_cached_source_info): Use all_objfiles.
5160         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5161         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5162         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5163         * objfiles.c (update_section_map): Use all_objfiles.
5164         (shared_objfile_contains_address_p): Likewise.
5165         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5166         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5167
5168 2019-01-09  Tom Tromey  <tom@tromey.com>
5169
5170         * common/next-iterator.h: New file.
5171         * objfiles.h (class all_objfiles): New.
5172         (struct objfile_iterator): New.
5173
5174 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5175
5176         * NEWS: Move the description of the changed "frame", "select-frame",
5177          and "info frame" commands to the Changed commands section.
5178
5179 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5180
5181         * gdbtypes.c (check_stub_method_group): Remove handling of old
5182         mangling schemes.
5183         * linespec.c (find_methods): Likewise.
5184         * stabsread.c (read_member_functions): Likewise.
5185         * valops.c (search_struct_method): Likewise.
5186         (value_struct_elt_for_reference): Likewise.
5187         * NEWS: Mention this change.
5188
5189 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5190
5191         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5192         print_source_lines.
5193         * source.c (print_source_lines_base): Update line number check.
5194         (print_source_lines): New function.
5195         (source_lines_range::source_lines_range): New function.
5196         * source.h (class source_lines_range): New class.
5197         (print_source_lines): New declaration.
5198
5199 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5200
5201         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5202
5203 2019-01-08  Tom Tromey  <tom@tromey.com>
5204             Simon Marchi  <simon.marchi@ericsson.com>
5205
5206         PR gdb/24060
5207         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5208         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5209         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5210         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5211         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5212         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5213
5214 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5215
5216         * source.c (select_source_symtab): Move header comment to
5217         declaration in source.h.
5218         (forget_cached_source_info_for_objfile): Likewise.
5219         (forget_cached_source_info): Likewise.
5220         (identify_source_line): Likewise.
5221         * source.h (identify_source_line): Move declaration from symtab.h
5222         and add comment from source.c
5223         (print_source_lines): Likewise.
5224         (forget_cached_source_info_for_objfile): Likewise.
5225         (forget_cached_source_info): Likewise.
5226         (select_source_symtab): Likewise.
5227         (enum print_source_lines_flag): Move definition from symtab.h.
5228         * symtab.h (identify_source_line): Move declaration to source.h.
5229         (print_source_lines): Likewise.
5230         (forget_cached_source_info_for_objfile): Likewise.
5231         (forget_cached_source_info): Likewise.
5232         (select_source_symtab): Likewise.
5233         (enum print_source_lines_flag): Move definition to source.h.
5234         * tui/tui-hooks.c: Add 'source.h' include.
5235
5236 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5237
5238         * source.c (print_source_lines_base): Handle requests to print
5239         reverse line number sequences, and guard against empty lines
5240         string.
5241
5242 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5243
5244         * source.c (print_source_lines_base): Fix skip of '\r' if next
5245         character is '\n'.
5246
5247 2019-01-06  Tom Tromey  <tom@tromey.com>
5248
5249         * c-exp.y (struct c_parse_state) <macro_original_text,
5250         expansion_obstack>: New member.
5251         (macro_original_text, expansion_obstack): Remove globals.
5252         (scan_macro_expansion, scanning_macro_expansion)
5253         (finished_macro_expansion): Update.
5254         (scan_macro_cleanup): Remove.
5255         (yylex, c_parse): Update.
5256
5257 2019-01-06  Tom Tromey  <tom@tromey.com>
5258
5259         * c-exp.y (struct c_parse_state) <strings>: New member.
5260         (operator_stoken): Update.
5261
5262 2019-01-06  Tom Tromey  <tom@tromey.com>
5263
5264         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5265         (union type_stack_elt) <typelist_val>: Now a pointer to
5266         std::vector.
5267         (type_stack_cleanup): Don't declare.
5268         (push_typelist): Update.
5269         * parse.c (pop_typelist): Return a std::vector.
5270         (push_typelist): Take a std::vector.
5271         (follow_types): Update.  Do not free args.
5272         (type_stack_cleanup): Remove.
5273         * c-exp.y (struct c_parse_state): New.
5274         (cpstate): New global.
5275         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5276         (nonempty_typelist): Update.
5277         (func_mod): Create a new vector.
5278         (c_parse): Create a c_parse_state.
5279         (check_parameter_typelist): Do not delete params.
5280         (function_method): Update.  Do not delete type_list.
5281
5282 2019-01-06  Tom Tromey  <tom@tromey.com>
5283
5284         PR gdb/28155:
5285         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5286         check_typedef.
5287         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5288         (print_return_value): Likewise.
5289
5290 2019-01-05  Tom Tromey  <tom@tromey.com>
5291
5292         * contrib/cleanup_check.py: Remove.
5293         * contrib/gcc-with-excheck: Remove.
5294         * contrib/exsummary.py: Remove.
5295         * contrib/excheck.py: Remove.
5296
5297 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5298
5299         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5300         NULL. Initialize tpprev to NULL instead of assigning it
5301         to NULL on the next statement.
5302         * windows-nat.c (windows_delete_thread): Remove check for
5303         main_thread_id before printing thread exit notifications.
5304         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5305         Remove thread ID check against main_thread_id.
5306         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5307         windows_delete_thread.
5308         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5309
5310 2019-01-04  Tom Tromey  <tom@tromey.com>
5311
5312         * compile/compile.c (_initialize_compile): Use upper case for
5313         metasyntactic variables.
5314         * symmisc.c (_initialize_symmisc): Use upper case for
5315         metasyntactic variables.
5316         * psymtab.c (_initialize_psymtab): Use upper case for
5317         metasyntactic variables.
5318         * demangle.c (demangle_command): Use upper case for metasyntactic
5319         variables.
5320         (_initialize_demangler): Likewise.
5321         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5322         variables.
5323
5324 2019-01-03  Tom Tromey  <tom@tromey.com>
5325
5326         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5327
5328 2019-01-03  Tom Tromey  <tom@tromey.com>
5329
5330         * python/py-symtab.c (salpy_str): Update.
5331         (struct salpy_sal_object) <symtab>: Now a PyObject.
5332         (salpy_dealloc): Update.
5333         (del_objfile_sal): Use gdbpy_ref.
5334
5335 2019-01-03  Tom Tromey  <tom@tromey.com>
5336
5337         * python/py-type.c (convert_field): Use new_reference.  Return
5338         gdbpy_ref.
5339         (make_fielditem): Return gdbpy_ref.
5340         (typy_fields): Update.
5341         (typy_getitem): Update.
5342         (field_name): Return gdbpy_ref.  Use new_reference.
5343         (typy_iterator_iternext): Update.
5344
5345 2019-01-03  Tom Tromey  <tom@tromey.com>
5346
5347         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5348
5349 2019-01-03  Tom Tromey  <tom@tromey.com>
5350
5351         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5352         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5353         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5354         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5355         (pspy_set_type_printers): Likewise.
5356         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5357         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5358         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5359         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5360         (objfpy_set_type_printers): Likewise.
5361
5362 2019-01-03  Tom Tromey  <tom@tromey.com>
5363
5364         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5365         (gdbpy_print_stack): Use gdbpy_err_fetch.
5366         * python/python-internal.h (class gdbpy_err_fetch): New class.
5367         (class gdbpy_enter) <m_error_type, m_error_value,
5368         m_error_traceback>: Remove.
5369         <m_error>: New member.
5370         (gdbpy_exception_to_string): Don't declare.
5371         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5372         * python/py-value.c (convert_value_from_python): Use
5373         gdbpy_err_fetch.
5374         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5375         gdbpy_exception_to_string.
5376         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5377         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5378         gdbpy_err_fetch.
5379
5380 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5381
5382         * linux-nat.c (delete_lwp_cleanup): Delete.
5383         (struct lwp_deleter): New struct.
5384         (lwp_info_up): New typedef.
5385         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5386         lwp_info_up.
5387
5388 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5389
5390         * linux-fork.c (class scoped_switch_fork_info): New class.
5391         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
5392
5393 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5394
5395         * valops.c (find_overload_match): Remove use of null_cleanup, and
5396         calls to do_cleanups.
5397
5398 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5399
5400         * compile/compile-cplus-types.c
5401         (compile_cplus_instance::decl_name): Handle changes to
5402         cp_func_name.
5403         * cp-support.c (cp_func_name): Update header comment, update
5404         return type.
5405         * cp-support.h (cp_func_name): Update return type in declaration.
5406         * valops.c (find_overload_match): Move temp_func local to top
5407         level of function and change its type.  Use temp_func to hold and
5408         delete temporary string obtained from cp_func_name.
5409
5410 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5411
5412         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
5413         gdb::char_vector, remove cleanup, and update uses of `msg`.
5414
5415 2019-01-03  Jim Wilson  <jimw@sifive.com>
5416
5417         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
5418
5419 2019-01-02  Tom Tromey  <tom@tromey.com>
5420
5421         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
5422         (tdesc_parse_xml): Remove cleanups.
5423         * target-descriptions.h (make_cleanup_free_target_description):
5424         Don't declare.
5425         (target_desc_deleter): New struct.
5426         (target_desc_up): New typedef.
5427         * target-descriptions.c (target_desc_deleter::operator()): Rename
5428         from free_target_description.
5429         (make_cleanup_free_target_description): Remove.
5430
5431 2019-01-02  Tom Tromey  <tom@tromey.com>
5432
5433         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
5434         constructor, destructor.
5435         (linespec_parser): Remove typedef.
5436         (~linespec_parser): Rename from linespec_parser_delete.
5437         (linespec_lex_to_end, linespec_complete_label)
5438         (linespec_complete): Update.
5439         (decode_line_full): Remove cleanups.
5440         (decode_line_1): Update.
5441
5442 2019-01-02  Tom Tromey  <tom@tromey.com>
5443
5444         * python/python-internal.h (inferior_to_inferior_object): Change
5445         return type.
5446         * python/py-exitedevent.c (create_exited_event_object): Update.
5447         * python/py-inferior.c (inferior_to_inferior_object): Return
5448         gdbpy_ref.
5449         (python_new_inferior, python_inferior_deleted)
5450         (thread_to_thread_object, delete_thread_object)
5451         (build_inferior_list, gdbpy_selected_inferior): Update.
5452         * python/py-infthread.c (create_thread_object): Update.  Also fail
5453         if inferior_to_inferior_object fails.
5454
5455 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5456
5457         * inferior.h (class inferior) <displaced_step_state>: New field.
5458         * infrun.h (struct displaced_step_state): Move here from
5459         infrun.c.  Initialize fields, add constructor.
5460         <inf>: Remove field.
5461         <reset>: New method.
5462         * infrun.c (struct displaced_step_inferior_state): Move to
5463         infrun.h.
5464         (displaced_step_inferior_states): Remove.
5465         (get_displaced_stepping_state): Adust.
5466         (displaced_step_in_progress_any_inferior): Adjust.
5467         (displaced_step_in_progress_thread): Adjust.
5468         (displaced_step_in_progress): Adjust.
5469         (add_displaced_stepping_state): Remove.
5470         (get_displaced_step_closure_by_addr): Adjust.
5471         (remove_displaced_stepping_state): Remove.
5472         (infrun_inferior_exit): Call displaced_step_state.reset.
5473         (use_displaced_stepping): Don't check for NULL.
5474         (displaced_step_prepare_throw): Call
5475         get_displaced_stepping_state.
5476         (displaced_step_fixup): Don't check for NULL.
5477         (prepare_for_detach): Don't check for NULL.
5478
5479 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5480
5481         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
5482          in case of call that did not complete.
5483
5484 2019-01-02  Andrey Utkin  <autkin@undo.io>
5485
5486         * symfile.c (find_separate_debug_file): Fix search of debug files for
5487         remote debuggee.
5488
5489 2019-01-02  Tom Tromey  <tom@tromey.com>
5490
5491         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
5492         indentation.
5493         * python/py-frame.c (frapy_older): Remove cast.
5494         (frapy_newer): Likewise.
5495         * python/py-breakpoint.c (local_setattro): Remove cast.
5496         * python/py-arch.c (archpy_name): Remove local variable.
5497         * python/py-type.c (gdbpy_lookup_type): Remove cast.
5498
5499 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
5500
5501         * unittests/basic_string_view/element_access/char/empty.cc:
5502         Fix year range in copyright header.
5503
5504 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5505
5506         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
5507         Delete.
5508         <operator==>: Update with for removed field.
5509         <hash>: Likewise.
5510         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
5511         <isa_features>: ...this.
5512         <abi_features>: New field.
5513         (riscv_isa_flen): Update comment.
5514         (riscv_abi_xlen): New declaration.
5515         (riscv_abi_flen): New declaration.
5516         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
5517         isa_features.
5518         (riscv_abi_xlen): New function.
5519         (riscv_isa_flen): Update to get answer from isa_features.
5520         (riscv_abi_flen): New function.
5521         (riscv_has_fp_abi): Update to get answer from abi_features.
5522         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
5523         xlen and flen.
5524         (riscv_call_info) <xlen, flen>: Update comment.
5525         (riscv_call_arg_struct): Remove invalid assertions
5526         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
5527         is removed.
5528         (riscv_gdbarch_init): Gather isa features and abi features
5529         separately, ensure both match on the gdbarch when reusing an old
5530         gdbarch.  Relax an error check to allow 32-bit abi float to run on
5531         a target with 64-bit float hardware.
5532
5533 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5534
5535         * source.c (search_command_helper): Stop reverse search
5536         when line 1 has been searched.
5537
5538 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5539
5540         * record-full.c (record_full_base_target::close): Rewrite
5541         record_full_core_buf_list free logic.
5542
5543 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5544
5545         * break-catch-syscall.c (print_one_catch_syscall): xfree
5546         the last text.
5547
5548 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5549
5550         * top.c (print_gdb_version): Update Copyright year in version
5551         message.
5552
5553 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5554
5555         Update copyright year range in all GDB files.
5556
5557 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
5558
5559         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
5560
5561 For older changes see ChangeLog-2018.
5562 \f
5563 Local Variables:
5564 mode: change-log
5565 left-margin: 8
5566 fill-column: 74
5567 version-control: never
5568 coding: utf-8
5569 End:
5570