gdb/ChangeLog

   1 2019-03-15  Tom Tromey  <tom@tromey.com>
   2
   3         * minsyms.c (minimal_symbol_reader::record_full): Remove some
   4         initializations.
   5
   6 2019-03-15  Tom Tromey  <tom@tromey.com>
   7
   8         * objfiles.h (struct objfile_per_bfd_storage)
   9         <demangled_hash_languages>: Now a bitset.
  10         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
  11         (lookup_minimal_symbol): Update.
  12
  13 2019-03-15  Tom Tromey  <tom@tromey.com>
  14
  15         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
  16         Don't return the symbol.
  17         * coffread.c (record_minimal_symbol): Use record_full.
  18
  19 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
  20
  21         The MS-Windows port of ncurses fails to switch to a color pair if
  22         one or both of the colors are the implicit default colors.  This
  23         change records the default colors when TUI is initialized, and
  24         then specifies them explicitly when a color pair uses the default
  25         colors.  This allows color styling in TUI mode on MS-Windows.
  26
  27         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
  28         ncurses_norm_attr.
  29         (tui_initialize_io) [__MINGW32__]: Record the default terminal
  30         colors in ncurses_norm_attr.
  31         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
  32         "none", replace it with the default color recorded in
  33         ncurses_norm_attr.
  34
  35 2019-03-14  Tom Tromey  <tromey@adacore.com>
  36
  37         * source-cache.h (class source_cache) <get_source_lines>: Return
  38         std::string.
  39         * source-cache.c (source_cache::extract_lines): Handle case where
  40         first_pos==npos.  Return std::string.
  41         (source_cache::get_source_lines): Update.
  42
  43 2019-03-14  Tom Tromey  <tromey@adacore.com>
  44
  45         * NEWS: Add item for "style sources" commands.
  46         * source-cache.c (source_cache::get_source_lines): Check
  47         source_styling.
  48         * cli/cli-style.c (source_styling): New global.
  49         (_initialize_cli_style): Add "style sources" commands.
  50         (show_style_sources): New function.
  51         * cli/cli-style.h (source_styling): Declare.
  52
  53 2019-03-14  Pedro Alves  <palves@redhat.com>
  54             Tom Tromey  <tromey@adacore.com>
  55
  56         * tui/tui-winsource.h (tui_refill_source_window): Declare.
  57         * tui/tui-winsource.c (tui_refill_source_window): New function,
  58         from...
  59         (tui_horizontal_source_scroll): ... here.  Move some logic.
  60         * cli/cli-style.c (set_style_enabled): Notify new observable.
  61         * tui/tui-hooks.c (tui_redisplay_source): New function.
  62         (tui_attach_detach_observers): Attach or detach
  63         tui_redisplay_source.
  64         * observable.h (source_styling_changed): New observable.
  65         * observable.c: Define source_styling_changed observable.
  66
  67 2019-03-13  Tom Tromey  <tromey@adacore.com>
  68
  69         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
  70         (i386_gnu_nat_target::store_registers): Update.
  71         * target-debug.h (target_debug_print_std_string): New macro.
  72         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
  73         * windows-tdep.c (display_one_tib): Update.
  74         * tui/tui-stack.c (tui_make_status_line): Update.
  75         * top.c (print_inferior_quit_action): Update.
  76         * thread.c (thr_try_catch_cmd): Update.
  77         (add_thread_with_info): Update.
  78         (thread_target_id_str): Update.
  79         (thr_try_catch_cmd): Update.
  80         (thread_command): Update.
  81         (thread_find_command): Update.
  82         * record-btrace.c (record_btrace_target::info_record)
  83         (record_btrace_resume_thread, record_btrace_target::resume)
  84         (record_btrace_cancel_resume, record_btrace_step_thread)
  85         (record_btrace_target::wait, record_btrace_target::wait)
  86         (record_btrace_target::wait, record_btrace_target::stop): Update.
  87         * progspace.c (print_program_space): Update.
  88         * process-stratum-target.c
  89         (process_stratum_target::thread_address_space): Update.
  90         * linux-fork.c (linux_fork_mourn_inferior)
  91         (detach_checkpoint_command, info_checkpoints_command)
  92         (linux_fork_context): Update.
  93         (linux_fork_detach): Update.
  94         (class scoped_switch_fork_info): Update.
  95         (delete_checkpoint_command): Update.
  96         * infrun.c (follow_fork_inferior): Update.
  97         (follow_fork_inferior): Update.
  98         (proceed_after_vfork_done): Update.
  99         (handle_vfork_child_exec_or_exit): Update.
 100         (follow_exec): Update.
 101         (displaced_step_prepare_throw): Update.
 102         (displaced_step_restore): Update.
 103         (start_step_over): Update.
 104         (resume_1): Update.
 105         (clear_proceed_status_thread): Update.
 106         (proceed): Update.
 107         (print_target_wait_results): Update.
 108         (do_target_wait): Update.
 109         (context_switch): Update.
 110         (stop_all_threads): Update.
 111         (restart_threads): Update.
 112         (finish_step_over): Update.
 113         (handle_signal_stop): Update.
 114         (switch_back_to_stepped_thread): Update.
 115         (keep_going_pass_signal): Update.
 116         (print_exited_reason): Update.
 117         (normal_stop): Update.
 118         * inferior.c (inferior_pid_to_str): Change return type.
 119         (print_selected_inferior): Update.
 120         (add_inferior): Update.
 121         (detach_inferior): Update.
 122         * dummy-frame.c (fprint_dummy_frames): Update.
 123         * dcache.c (dcache_info_1): Update.
 124         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 125         (btrace_fetch, btrace_clear): Update.
 126         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 127         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 128         type.
 129         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 130         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 131         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 132         * gdbarch.c, gdbarch.h: Rebuild.
 133         * gdbarch.sh (core_pid_to_str): Change return type.
 134         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 135         return type.
 136         (windows_nat_target::pid_to_str): Change return type.
 137         (windows_delete_thread): Update.
 138         (windows_nat_target::attach): Update.
 139         (windows_nat_target::files_info): Update.
 140         * target-delegates.c: Rebuild.
 141         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 142         return type.
 143         (sol_thread_target::pid_to_str): Change return type.
 144         * remote.c (class remote_target) <pid_to_str>: Change return
 145         type.
 146         (remote_target::pid_to_str): Change return type.
 147         (extended_remote_target::attach, remote_target::remote_stop_ns)
 148         (remote_target::remote_notif_remove_queued_reply)
 149         (remote_target::push_stop_reply, remote_target::disable_btrace):
 150         Update.
 151         (extended_remote_target::attach): Update.
 152         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 153         type.
 154         (gdbsim_target::pid_to_str): Change return type.
 155         * ravenscar-thread.c (struct ravenscar_thread_target)
 156         <pid_to_str>: Change return type.
 157         (ravenscar_thread_target::pid_to_str): Change return type.
 158         * procfs.c (class procfs_target) <pid_to_str>: Change return
 159         type.
 160         (procfs_target::pid_to_str): Change return type.
 161         (procfs_target::attach): Update.
 162         (procfs_target::detach): Update.
 163         (procfs_target::fetch_registers): Update.
 164         (procfs_target::store_registers): Update.
 165         (procfs_target::wait): Update.
 166         (procfs_target::files_info): Update.
 167         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 168         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 169         return type.
 170         (nto_procfs_target::pid_to_str): Change return type.
 171         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 172         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 173         return type.
 174         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 175         (exit_lwp): Update.
 176         (attach_proc_task_lwp_callback, get_detach_signal)
 177         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 178         (linux_nat_target::resume, wait_lwp, stop_callback)
 179         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 180         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 181         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 182         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 183         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 184         type.
 185         (inf_ptrace_target::attach): Update.
 186         (inf_ptrace_target::files_info): Update.
 187         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 188         type.
 189         (go32_nat_target::pid_to_str): Change return type.
 190         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 191         (gnu_nat_target::wait): Update.
 192         (gnu_nat_target::wait): Update.
 193         (gnu_nat_target::resume): Update.
 194         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 195         (fbsd_nat_target::wait): Update.
 196         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 197         type.
 198         (darwin_nat_target::attach): Update.
 199         * corelow.c (class core_target) <pid_to_str>: Change return type.
 200         (core_target::pid_to_str): Change return type.
 201         * target.c (normal_pid_to_str): Change return type.
 202         (default_pid_to_str): Likewise.
 203         (target_pid_to_str): Change return type.
 204         (target_translate_tls_address): Update.
 205         (target_announce_detach): Update.
 206         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 207         return type.
 208         (bsd_uthread_target::pid_to_str): Change return type.
 209         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 210         type.
 211         (bsd_kvm_target::pid_to_str): Change return type.
 212         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 213         return type.
 214         (aix_thread_target::pid_to_str): Change return type.
 215         * target.h (struct target_ops) <pid_to_str>: Change return type.
 216         (target_pid_to_str, normal_pid_to_str): Likewise.
 217         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 218         type.
 219         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 220         type.
 221         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 222         return type.
 223         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 224         type.
 225         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 226         type.
 227         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 228         return type.
 229
 230 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 231
 232         * NEWS: Mention that the new default MI version is 3.  Mention
 233         changes to the output of commands and events that deal with
 234         multi-location breakpoints.
 235         * breakpoint.c: Include "mi/mi-out.h".
 236         (print_one_breakpoint): Change output syntax if using MI version
 237         >= 3.
 238         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 239         New.
 240         (mi_multi_location_breakpoint_output_fixed): New.
 241         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 242         (mi_cmd_fix_multi_location_breakpoint_output): New.
 243         (mi_multi_location_breakpoint_output_fixed): New.
 244         * mi/mi-cmds.c (mi_cmds): Register command
 245         -fix-multi-location-breakpoint-output.
 246         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 247         interpreter "mi".
 248
 249 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 250
 251         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 252         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 253         instantiate mi_ui_out based on interpreter name.
 254         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 255         * mi/mi-main.c (mi_load_progress): Likewise.
 256
 257 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 258
 259         * NEWS: Combine separate "New targets" sections for 8.3.
 260
 261 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 262
 263         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 264         (ppcfbsd_init_abi): Install gdbarch
 265         "fetch_tls_load_module_address" and "get_thread_local_address"
 266         methods.
 267
 268 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 269
 270         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 271         (riscv_fbsd_init_abi): Install gdbarch
 272         "fetch_tls_load_module_address" and "get_thread_local_address"
 273         methods.
 274
 275 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 276
 277         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 278         (i386fbsd_init_abi): Install gdbarch
 279         "fetch_tls_load_module_address" and "get_thread_local_address"
 280         methods.
 281
 282 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 283
 284         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 285         (amd64fbsd_init_abi): Install gdbarch
 286         "fetch_tls_load_module_address" and "get_thread_local_address"
 287         methods.
 288
 289 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 290
 291         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 292         (struct fbsd_pspace_data): New type.
 293         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 294         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 295         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 296         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 297         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 298
 299 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 300
 301         * gdbtypes.c (lookup_struct_elt): New function.
 302         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 303         * gdbtypes.h (struct struct_elt): New type.
 304         (lookup_struct_elt): New prototype.
 305
 306 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 307
 308         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 309         remove disabled code block.
 310
 311 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 312
 313         * gdbarch.sh (get_thread_local_address): New method.
 314         * gdbarch.h, gdbarch.c: Regenerate.
 315         * target.c (target_translate_tls_address): Use
 316         gdbarch_get_thread_local_address if present instead of
 317         target::get_thread_local_address.
 318
 319 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 320
 321         * target.h (target::get_thread_local_address): Update comment.
 322
 323 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 324
 325         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 326         objfile->separate_debug_objfile_backlink if not NULL.
 327
 328 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 329
 330         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 331         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 332         (amd64bsd_store_inferior_registers): Likewise.
 333         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 334         Enable segment base registers.
 335         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 336         PT_GETFSBASE and PT_GETGSBASE.
 337         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 338         PT_SETGSBASE.
 339         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 340         segment base registers.
 341         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 342
 343 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 344
 345         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 346         Update calls to i386_target_description to add 'segments'
 347         parameter.
 348         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 349         add segment base registers.
 350         * arch/i386.c (i386_create_target_description): Add 'segments'
 351         parameter to enable segment base registers.
 352         * arch/i386.h (i386_create_target_description): Likewise.
 353         * features/i386/32bit-segments.xml: New file.
 354         * features/i386/32bit-segments.c: Generate.
 355         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 356         call to i386_target_description to add 'segments' parameter.
 357         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 358         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 359         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 360         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 361         if feature is present.
 362         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 363         Add 'segments' parameter to call to i386_target_description.
 364         (i386_target_description): Add 'segments' parameter to enable
 365         segment base registers.
 366         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 367         to call to i386_target_description.
 368         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 369         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 370         Define I386_NUM_REGS.
 371         (i386_target_description): Add 'segments' parameter to enable
 372         segment base registers.
 373
 374 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 375
 376         PR/24325
 377         * source-cache.c: #undef open and close, to avoid unresolved
 378         externals during linking.
 379
 380 2019-03-12  Tom Tromey  <tromey@adacore.com>
 381
 382         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 383         const.  Add initializers.
 384         (_initialize_remote): Don't initialize ptid globals.
 385
 386 2019-03-12  Pedro Alves  <palves@redhat.com>
 387
 388         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 389
 390 2019-03-12  Pedro Alves  <palves@redhat.com>
 391
 392         * cp-name-parser.y (main): Remove unused 'len' variable.
 393
 394 2019-03-12  Tom Tromey  <tromey@adacore.com>
 395
 396         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 397         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 398
 399 2019-03-12  Tom Tromey  <tromey@adacore.com>
 400
 401         * linux-nat.c (iterate_over_lwps): Update.
 402         (stop_callback): Remove parameter.
 403         (stop_wait_callback, detach_callback, resume_set_callback)
 404         (select_singlestep_lwp_callback, set_ignore_sigint)
 405         (status_callback, resumed_callback, resume_clear_callback)
 406         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 407         data parameter.
 408         (linux_nat_target::detach, linux_nat_target::resume)
 409         (linux_stop_and_wait_all_lwps, select_event_lwp)
 410         (linux_nat_filter_event, linux_nat_wait_1)
 411         (linux_nat_target::kill, linux_nat_target::stop)
 412         (linux_nat_target::stop): Update.
 413         (linux_nat_resume_callback): Change type.
 414         (resume_stopped_resumed_lwps, count_events_callback)
 415         (select_event_lwp_callback): Likewise.
 416         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 417         * arm-linux-nat.c (struct update_registers_data): Remove.
 418         (update_registers_callback): Change type.
 419         (arm_linux_insert_hw_breakpoint1): Update.
 420         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 421         parameter.
 422         (x86_linux_dr_set_addr): Update.
 423         (x86_linux_dr_set_control): Update.
 424         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 425         (iterate_over_lwps): Use gdb::function_view.
 426         * nat/aarch64-linux-hw-point.c (struct
 427         aarch64_dr_update_callback_param): Remove.
 428         (debug_reg_change_callback): Change type.
 429         (aarch64_notify_debug_reg_change): Update.
 430         * s390-linux-nat.c (s390_refresh_per_info): Update.
 431
 432 2019-03-11  Tom Tromey  <tromey@adacore.com>
 433
 434         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 435         redundant assignment to "this_cu".
 436
 437 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 438
 439         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 440
 441 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 442
 443         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 444         from...
 445         (rank_one_type): ... this.
 446
 447 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 448
 449         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 450         from...
 451         (rank_one_type): ... this.
 452
 453 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 454
 455         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 456         from...
 457         (rank_one_type): ... this.
 458
 459 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 460
 461         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 462         from...
 463         (rank_one_type): ... this.
 464
 465 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 466
 467         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 468         from...
 469         (rank_one_type): ... this.
 470
 471 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 472
 473         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 474         from...
 475         (rank_one_type): ... this.
 476
 477 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 478
 479         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 480         from...
 481         (rank_one_type): ... this.
 482
 483 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 484
 485         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 486         from...
 487         (rank_one_type): ... this.
 488
 489 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 490
 491         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 492         from...
 493         (rank_one_type): ... this.
 494
 495 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 496
 497         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 498         from...
 499         (rank_one_type): ... this.
 500
 501 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 502
 503         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 504         from...
 505         (rank_one_type): ... this.
 506
 507 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 508
 509         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 510         from...
 511         (rank_one_type): ... this.
 512
 513 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 514
 515         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 516         inferior-events' shows the example events.
 517
 518 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 519
 520         Support styling on native MS-Windows console
 521
 522         PR/24315
 523         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 524         on MS-Windows if $TERM is not defined.
 525
 526         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 527
 528         * posix-hdep.c (gdb_console_fputs):
 529         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 530         functions.
 531         * ui-file.h (gdb_console_fputs): Add prototype.
 532
 533         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 534         back to fputs only if the former returns zero.
 535
 536 2019-03-07  Tom Tromey  <tom@tromey.com>
 537
 538         * symmisc.c (print_symbol_bcache_statistics): Update.
 539         (print_objfile_statistics): Update.
 540         * symfile.c (allocate_symtab): Update.
 541         * stabsread.c: Don't include bcache.h.
 542         * psymtab.h (struct psymbol_bcache): Don't declare.
 543         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 544         (psymbol_bcache_init, psymbol_bcache_free)
 545         (psymbol_bcache_get_bcache): Don't declare.
 546         * psymtab.c (struct psymbol_bcache): Remove.
 547         (psymtab_storage::psymtab_storage): Update.
 548         (psymtab_storage::~psymtab_storage): Update.
 549         (psymbol_bcache_init, psymbol_bcache_free)
 550         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
 551         (add_psymbol_to_bcache): Update.
 552         (allocate_psymtab): Update.
 553         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 554         macro_cache>: No longer pointers.
 555         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
 556         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
 557         * macrotab.c (macro_bcache): Update.
 558         * macroexp.c: Don't include bcache.h.
 559         * gdbtypes.c (check_types_worklist): Update.
 560         (types_deeply_equal): Remove TRY/CATCH.  Update.
 561         * elfread.c (elf_symtab_read): Update.
 562         * dwarf2read.c: Don't include bcache.h.
 563         * buildsym.c (buildsym_compunit::get_macro_table): Update.
 564         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
 565         (print_bcache_statistics, bcache_memory_used): Don't declare.
 566         (struct bcache): Move from bcache.c.  Add constructor, destructor,
 567         methods.  Rename all data members.
 568         * bcache.c (struct bcache): Move to bcache.h.
 569         (bcache::expand_hash_table): Rename from expand_hash_table.
 570         (bcache): Remove.
 571         (bcache::insert): Rename from bcache_full.
 572         (bcache::compare): Rename from bcache_compare.
 573         (bcache_xmalloc): Remove.
 574         (bcache::~bcache): Rename from bcache_xfree.
 575         (bcache::print_statistics): Rename from print_bcache_statistics.
 576         (bcache::memory_used): Rename from bcache_memory_used.
 577
 578 2019-03-07  Pedro Alves  <palves@redhat.com>
 579
 580         * infrun.c (normal_stop): Also check for
 581         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
 582
 583 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 584
 585         * f-lang.c (value_from_host_double): Moved to...
 586         * value.c (value_from_host_double): ...here.
 587         * value.h (value_from_host_double): Declare.
 588         * guile/scm-math.c (vlscm_convert_typed_number): Use
 589         value_from_host_double.
 590         (vlscm_convert_number): Likewise.
 591         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
 592         * python/py-value.c (convert_value_from_python): Likewise.
 593
 594 2019-03-06  Tom Tromey  <tom@tromey.com>
 595
 596         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
 597
 598 2019-03-06  Tom Tromey  <tom@tromey.com>
 599
 600         * utils.h (free_current_contents): Don't declare.
 601         * utils.c (free_current_contents): Remove.
 602
 603 2019-03-06  Tom Tromey  <tom@tromey.com>
 604
 605         * top.c (quit_force): Update.
 606         * main.c (captured_command_loop): Update.
 607         * common/new-op.c (operator new): Update.
 608         * common/common-exceptions.c (struct catcher)
 609         <save_cleanup_chain>: Remove member.
 610         (exceptions_state_mc_init): Update.
 611         (exception_try_scope_entry): Return nullptr.
 612         (exception_try_scope_exit, exception_rethrow)
 613         (throw_exception_sjlj, throw_exception_cxx): Update.
 614         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
 615         (all_cleanups, do_cleanups, discard_cleanups)
 616         (discard_final_cleanups, save_cleanups, save_final_cleanups)
 617         (restore_cleanups, restore_final_cleanups): Don't declare.
 618         (do_final_cleanups): Remove parameter.
 619         * common/cleanups.c (cleanup_chain, make_cleanup)
 620         (make_cleanup_dtor, all_cleanups, do_cleanups)
 621         (discard_my_cleanups, discard_cleanups)
 622         (discard_final_cleanups, save_my_cleanups, save_cleanups)
 623         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
 624         (null_cleanup): Remove.
 625         (do_final_cleanups): Remove parameter.
 626
 627 2019-03-06  Tom Tromey  <tom@tromey.com>
 628
 629         * remote.c (remote_target::remote_parse_stop_reply): Use
 630         unique_xmalloc_ptr.
 631
 632 2019-03-06  Tom Tromey  <tom@tromey.com>
 633
 634         * stabsread.c (struct stabs_field_info): Rename from field_info.
 635         <list, fnlist>: Add initializers.
 636         <obstack>: New member.
 637         (read_member_functions, read_struct_fields, read_baseclasses):
 638         Allocate on obstack.  Don't use cleanups.
 639         (read_one_struct_field, read_member_functions, read_struct_fields)
 640         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
 641         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
 642         (read_struct_type): Update.
 643
 644 2019-03-06  Tom Tromey  <tom@tromey.com>
 645
 646         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
 647         * common/filestuff.h (make_cleanup_close): Don't declare.
 648         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
 649         Remove.
 650
 651 2019-03-06  Tom Tromey  <tom@tromey.com>
 652
 653         * solib-aix.c: Use make_scope_exit.
 654
 655 2019-03-06  Tom Tromey  <tom@tromey.com>
 656
 657         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
 658         Use make_scope_exit.
 659
 660 2019-03-06  Tom Tromey  <tom@tromey.com>
 661
 662         * solib-svr4.c (disable_probes_interface): Remove parameter.
 663         (svr4_handle_solib_event): Use make_scope_exit.
 664
 665 2019-03-06  Tom Tromey  <tom@tromey.com>
 666
 667         * remote.c (struct stop_reply_deleter): Remove.
 668         (stop_reply_up): Update.
 669         (struct stop_reply): Derive from notif_event.  Don't typedef.
 670         <regcache>: Now a std::vector.
 671         (stop_reply_xfree): Remove.
 672         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
 673         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
 674         (remote_target::discard_pending_stop_replies): Use delete.
 675         (remote_target::remote_parse_stop_reply): Update.
 676         (remote_target::process_stop_reply): Update.
 677         * remote-notif.h (struct notif_event): Add virtual destructor.
 678         Remove "dtr" member.
 679         (struct notif_client) <alloc_event>: Return a unique_ptr.
 680         (notif_event_xfree): Don't declare.
 681         (notif_event_up): New typedef.
 682         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
 683         (notif_event_xfree, do_notif_event_xfree): Remove.
 684         (remote_notif_state_xfree): Update.
 685
 686 2019-03-06  Tom Tromey  <tom@tromey.com>
 687
 688         * infrun.c (displaced_step_clear_cleanup): Now a
 689         forward_scope_exit type.
 690         (displaced_step_prepare_throw): Update.
 691         (displaced_step_fixup): Update.
 692
 693 2019-03-06  Tom Tromey  <tom@tromey.com>
 694
 695         * inferior.h (class inferior): Update comment.
 696         * gdbthread.h (class thread_info): Update comment.
 697
 698 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
 699             Tom Tromey  <tom@tromey.com>
 700
 701         * stabsread.h (struct stab_section_list): Remove.
 702         (coffstab_build_psymtabs): Update.
 703         * dbxread.c (symbuf_sections): Now a std::vector.
 704         (sect_idx): New global.
 705         (fill_symbuf): Update.
 706         (coffstab_build_psymtabs): Change type of stabsects parameter.
 707         Update.
 708         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
 709         std::vector.
 710         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
 711         (coff_locate_sections): Update.
 712         (coff_symfile_read): Remove cleanups.  Update.
 713         (init_stringtab): Add storage parameter.
 714         (free_stringtab, free_stringtab_cleanup): Remove.
 715         (init_lineno): Add storage parameter.
 716         (free_linetab, free_linetab_cleanup): Remove.
 717
 718 2019-03-06  Pedro Alves  <palves@redhat.com>
 719
 720         * linux-fork.c (fork_info::clobber_regs): Delete.
 721         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
 722         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
 723         comment.  Adjust.
 724         (scoped_switch_fork_info::scoped_switch_fork_info)
 725         (checkpoint_command, linux_fork_context): Adjust
 726         fork_save_infrun_state calls.
 727
 728 2019-03-06  Pedro Alves  <palves@redhat.com>
 729
 730         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
 731         (inf_has_multiple_threads): Return 'bool' and rewrite using
 732         inferior_info::threads().
 733
 734 2019-03-06  Pedro Alves  <palves@redhat.com>
 735
 736         * linux-fork.c: Include <list>.
 737         (fork_list): Now a std::list instance.
 738         (fork_info): Add ctor, dtor, and in-class initialize all fields.
 739         (forks_exist_p, find_last_fork): Adjust.
 740         (new_fork): Delete.
 741         (one_fork_p): New.
 742         (add_fork): Adjust.
 743         (free_fork): Delete, folded into fork_info::~fork_info().
 744         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
 745         Adjust.
 746         (init_fork_list): Delete.
 747         (linux_fork_killall, linux_fork_mourn_inferior)
 748         (linux_fork_detach, info_checkpoints_command): Adjust.
 749         (_initialize_linux_fork): No longer call init_fork_list.
 750
 751 2019-03-06  Pedro Alves  <palves@redhat.com>
 752
 753         * linux-fork.c (new_fork): New, split out of ...
 754         (add_fork): ... this.  Return void.  Move "first fork" special
 755         case from here, to ...
 756         (checkpoint_command): ... here.
 757         * linux-linux.h (add_fork): Return void.
 758
 759 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 760
 761         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
 762
 763 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 764             Chris January  <chris.january@arm.com>
 765             David Lecomber  <david.lecomber@arm.com>
 766
 767         * f-exp.y: New token, UNOP_INTRINSIC.
 768         (exp): New pattern using UNOP_INTRINSIC token.
 769         (f77_keywords): Add 'abs' keyword.
 770         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
 771         (value_from_host_double): New function.
 772         (evaluate_subexp_f): Support UNOP_ABS.
 773
 774 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 775
 776         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
 777         types.
 778
 779 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 780
 781         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
 782         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
 783         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
 784
 785 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 786
 787         * f-exp.y (convert_to_kind_type): Handle more type kinds.
 788
 789 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 790             Chris January  <chris.january@arm.com>
 791
 792         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
 793         * f-exp.y: Define 'KIND' token.
 794         (exp): New pattern for KIND expressions.
 795         (ptype): Handle types with a kind extension.
 796         (direct_abs_decl): Extend to spot kind extensions.
 797         (f77_keywords): Add 'kind' to the list.
 798         (push_kind_type): New function.
 799         (convert_to_kind_type): New function.
 800         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
 801         * parse.c (operator_length_standard): Likewise.
 802         * parser-defs.h (enum type_pieces): Add tp_kind.
 803         * std-operator.def: Add UNOP_KIND.
 804
 805 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 806
 807         * f-exp.y (f_parse): Set yydebug.
 808
 809 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 810
 811         * f-lang.c (evaluate_subexp_f): New function.
 812         (exp_descriptor_f): New global.
 813         (f_language_defn): Use exp_descriptor_f instead of
 814         exp_descriptor_standard.
 815
 816 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 817
 818         * f-exp.y (struct token): Add comments.
 819         (dot_ops): Remove uppercase versions and the end marker.
 820         (f77_keywords): Likewise.
 821         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
 822         entries in the dot_ops array are case insensitive, and use
 823         strncasecmp to compare strings.  Also some whitespace cleanup in
 824         this area.  Similar for the f77_keywords array, except entries in
 825         this list might be case sensitive.
 826
 827 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 828
 829         * f-exp.y (struct f77_boolean_val): Add comments.
 830         (boolean_values): Remove uppercase versions, and end marker.
 831         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
 832         and use strncasecmp to achieve case insensitivity.  Additionally,
 833         perform whitespace cleanup around this code.
 834
 835 2019-03-06  Tom Tromey  <tromey@adacore.com>
 836
 837         * remote-sim.c (gdbsim_target_open): Use result of
 838         gdb_argv::release.
 839
 840 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
 841         Dirk Schubert  <dirk.schubert@arm.com>
 842         Chris January  <chris.january@arm.com>
 843
 844         * eval.c (evaluate_subexp_standard): Call Fortran argument
 845         wrapping logic.
 846         * f-lang.c (struct value): A value which can be passed into a
 847         Fortran function call.
 848         (fortran_argument_convert): Wrap Fortran arguments in a pointer
 849         where appropriate.
 850         (struct type): Value ready for a Fortran function call.
 851         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
 852         is needed.
 853         * f-lang.h (fortran_argument_convert): Declaration.
 854         (fortran_preserve_arg_pointer): Declaration.
 855         * infcall.c (value_arg_coerce): Call Fortran argument logic.
 856
 857 2019-03-05  Tom Tromey  <tromey@adacore.com>
 858
 859         * python/py-prettyprint.c (print_string_repr): Remove #if.
 860         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
 861
 862 2019-03-05  Tom Tromey  <tromey@adacore.com>
 863
 864         * target.c (the_dummy_target): Move later.  Change type to
 865         "dummy_target".
 866         (initialize_targets): Don't initialize the_dummy_target.
 867
 868 2019-03-05  Tom Tromey  <tromey@adacore.com>
 869
 870         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
 871         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
 872
 873 2019-03-05  Tom Tromey  <tromey@adacore.com>
 874
 875         * windows-nat.c (windows_nat_target::attach)
 876         (windows_nat_target::detach): Don't call gdb_flush.
 877         * valprint.c (generic_val_print, val_print, val_print_string):
 878         Don't call gdb_flush.
 879         * utils.c (defaulted_query): Don't call gdb_flush.
 880         * typeprint.c (print_type_scalar): Don't call gdb_flush.
 881         * target.c (target_announce_detach): Don't call gdb_flush.
 882         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
 883         * remote.c (extended_remote_target::attach): Don't call
 884         gdb_flush.
 885         * procfs.c (procfs_target::detach): Don't call gdb_flush.
 886         * printcmd.c (do_examine): Don't call gdb_flush.
 887         (info_display_command): Don't call gdb_flush.
 888         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
 889         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
 890         * memattr.c (info_mem_command): Don't call gdb_flush.
 891         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
 892         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
 893         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
 894         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
 895         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
 896         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
 897         (gnu_nat_target::detach): Don't call gdb_flush.
 898         * f-valprint.c (f_val_print): Don't call gdb_flush.
 899         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
 900         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
 901         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
 902         gdb_flush.
 903         * c-valprint.c (c_val_print): Don't call gdb_flush.
 904         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
 905
 906 2019-03-05  Tom Tromey  <tromey@adacore.com>
 907
 908         * varobj.c (update_dynamic_varobj_children): Update.
 909         (install_default_visualizer): Use reset, not release.
 910         * value.c (set_internalvar): Update.
 911         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
 912         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
 913         ATTRIBUTE_UNUSED_RESULT.
 914
 915 2019-03-05  Tom Tromey  <tromey@adacore.com>
 916
 917         * remote.c (class scoped_remote_fd) <release>: Add
 918         ATTRIBUTE_UNUSED_RESULT.
 919
 920 2019-03-05  Tom Tromey  <tromey@adacore.com>
 921
 922         * macroexp.c (struct macro_buffer) <release>: Add
 923         ATTRIBUTE_UNUSED_RESULT.
 924
 925 2019-03-05  Tom Tromey  <tromey@adacore.com>
 926
 927         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
 928         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
 929         ATTRIBUTE_UNUSED_RESULT.
 930
 931 2019-03-05  Tom Tromey  <tromey@adacore.com>
 932
 933         * common/scoped_fd.h (class scoped_fd) <release>: Add
 934         ATTRIBUTE_UNUSED_RESULT.
 935
 936 2019-03-05  Tom Tromey  <tromey@adacore.com>
 937
 938         * parser-defs.h (struct parser_state) <release>: Add
 939         ATTRIBUTE_UNUSED_RESULT.
 940
 941 2019-03-05  Tom Tromey  <tromey@adacore.com>
 942
 943         * utils.h (class gdb_argv) <release>: Add
 944         ATTRIBUTE_UNUSED_RESULT.
 945         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
 946
 947 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 948
 949         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
 950         for-loop range, to avoid compiler warnings.
 951
 952         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
 953         avoid compiler warnings about unused variables.
 954
 955         * NEWS: Mention end of support for native debugging on MS-Windows
 956         before XP.
 957
 958         PR gdb/24292
 959         * common/netstuff.c:
 960         * gdbserver/gdbreplay.c
 961         * gdbserver/remote-utils.c:
 962         * ser-tcp.c:
 963         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
 964         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
 965         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
 966         'getaddrinfo' and 'freeaddrinfo' were not available before
 967         Windows XP, and mingw.org's MinGW headers by default define
 968         _WIN32_WINNT to 0x500.
 969
 970 2019-03-01  Gary Benson <gbenson@redhat.com>
 971
 972         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
 973
 974 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
 975             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 976
 977         PR gdb/8527
 978         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
 979         set_sigint_trap, clear_sigint_trap.
 980
 981 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 982
 983         * target.c (target_detach): Clear the regcache and the
 984         frame cache.
 985
 986 2019-02-27  Pedro Alves  <palves@redhat.com>
 987
 988         * utils.c (set_screen_size): When we cap the height/width sizes,
 989         tweak the corresponding command variable to show "unlimited":
 990
 991 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
 992             Pedro Alves  <palves@redhat.com>
 993
 994         * utils.c (set_screen_size): Reduce "infinite" rows and columns
 995         before calling rl_set_screen_size.
 996
 997 2019-02-27  Tom Tromey  <tromey@adacore.com>
 998
 999         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1000         define.
1001         * python/py-value.c: Remove Python 2.4 workaround.
1002         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1003         workaround.
1004         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1005         Python 2.4 workaround.
1006         * python/python-internal.h: Remove Python 2.4 comment.
1007         (Py_ssize_t): Don't define.
1008         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1009         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1010         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1011         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1012         * python/python.c (do_start_initialization): Remove Python 2.4
1013         workaround.
1014         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1015         (print_children): Remove Python 2.4 workaround.
1016         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1017         workaround.
1018         (CHARBUFFERPROC_NAME): Remove.
1019         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1020         Python 2.4 workaround.
1021
1022 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1023
1024         * NEWS: Note minimum Python version.
1025
1026 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1027
1028         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1029         code from these functions.  Remove corresponding ifdefs.  Use
1030         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1031         Remove gotos and target of gotos.
1032         (infpy_search_memory): Likewise.
1033
1034 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1035
1036         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1037         (hppa_gdbarch_init): Don't register deleted functions with
1038         gdbarch.
1039
1040 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1041
1042         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1043         (h8300_unwind_sp): Delete.
1044         (h8300_dummy_id): Delete.
1045         (h8300_gdbarch_init): Don't register deleted functions with
1046         gdbarch.
1047
1048 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1049
1050         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1051         (ft32_unwind_pc): Delete.
1052         (ft32_unwind_sp): Delete.
1053         (ft32_gdbarch_init): Don't register deleted functions with
1054         gdbarch.
1055
1056 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1057
1058         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1059         (frv_unwind_pc): Delete.
1060         (frv_unwind_sp): Delete.
1061         (frv_gdbarch_init): Don't register deleted functions with
1062         gdbarch.
1063
1064 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1065
1066         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1067         (riscv_unwind_pc): Delete.
1068         (riscv_unwind_sp): Delete.
1069         (riscv_gdbarch_init): Don't register deleted functions with
1070         gdbarch.
1071
1072 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1073
1074         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1075         (csky_unwind_pc): Delete.
1076         (csky_unwind_sp): Delete.
1077         (csky_gdbarch_init): Don't register deleted functions with
1078         gdbarch.
1079
1080 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1081
1082         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1083         (cris_unwind_pc): Delete.
1084         (cris_unwind_sp): Delete.
1085         (cris_gdbarch_init): Don't register deleted functions with
1086         gdbarch.
1087
1088 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1089
1090         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1091         (bfin_unwind_pc): Delete.
1092         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1093
1094 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1095
1096         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1097         (arm_unwind_pc): Delete.
1098         (arm_unwind_sp): Delete.
1099         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1100
1101 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1102
1103         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1104         (arc_unwind_pc): Delete.
1105         (arc_unwind_sp): Delete.
1106         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1107
1108 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1109
1110         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1111         (alpha_unwind_pc): Delete.
1112         (alpha_gdbarch_init): Don't register deleted functions with
1113         gdbarch.
1114
1115 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1116
1117         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1118         (aarch64_unwind_pc): Delete.
1119         (aarch64_unwind_sp): Delete.
1120         (aarch64_gdbarch_init): Don't register deleted functions with
1121         gdbarch.
1122
1123 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1124
1125         * gdbtypes.c (type_align): Don't consider static members when
1126         computing structure alignment.
1127
1128 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1129
1130         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1131         return 0 for other types.
1132         * arch-utils.c (default_type_align): Always return 0.
1133         * gdbarch.h: Regenerate.
1134         * gdbarch.sh (type_align): Extend comment.
1135         * gdbtypes.c (type_align): Add additional comments, always call
1136         gdbarch_type_align before applying the default rules.
1137         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1138         generic code will then apply a suitable default.
1139         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1140         types, return 0 for other types.
1141
1142 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1143
1144         * NEWS: Create a new section for the next release branch.
1145         Rename the section of the current branch, now that it has
1146         been cut.
1147
1148 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1149
1150         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1151         * version.in: Bump version to 8.3.50.DATE-git.
1152
1153 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1154
1155         * aix-thread.c (ptid_cmp): Remove unused variable.
1156         (get_signaled_thread): Likewise.
1157         (store_regs_user_thread): Likewise.
1158         (store_regs_kernel_thread): Likewise.
1159         (fetch_regs_kernel_thread): Remove shadowed variable.
1160
1161 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1162
1163         * features/riscv/32bit-cpu.xml: Add register numbers.
1164         * features/riscv/32bit-fpu.c: Regenerate.
1165         * features/riscv/32bit-fpu.xml: Add register numbers.
1166         * features/riscv/64bit-cpu.xml: Add register numbers.
1167         * features/riscv/64bit-fpu.c: Regenerate.
1168         * features/riscv/64bit-fpu.xml: Add register numbers.
1169
1170 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1171
1172         * NEWS: Mention two argument form of gdb.Value constructor.
1173         * python/py-value.c (convert_buffer_and_type_to_value): New
1174         function.
1175         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1176         Add support for handling an optional second argument.  Call
1177         convert_buffer_and_type_to_value as appropriate.
1178         * python/python-internal.h (Py_buffer_deleter): New struct.
1179         (Py_buffer_up): New typedef.
1180
1181 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1182
1183         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1184         instead of releasing ownership.
1185
1186 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1187
1188         * dwarf2read.c (open_and_init_dwp_file): Call
1189         elf_numsections instead of bfd_count_sections to initialize
1190         dwp_file->num_sections.
1191
1192 2019-02-25  Tom Tromey  <tromey@adacore.com>
1193
1194         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1195
1196 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1197
1198         * gcore.in: Add '--readnever' option when invoking GDB.
1199
1200 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1201
1202         * MAINTAINERS: Update my email address.
1203
1204 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1205
1206         * build-id.c (build_id_to_debug_bfd_1): New function.
1207         (build_id_to_debug_bfd): Look for separate debug file in
1208         sysroot.
1209
1210 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1211
1212         * gdbarch.sh: Update the copyright year range that is placed into
1213         generated files.
1214
1215 2019-02-22  Keith Seitz  <keiths@redhat.com>
1216
1217         PR symtab/23853
1218         * linespec.c (create_sals_line_offset): Search for the default
1219         symtab's filename instead of its fullname.
1220
1221 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1222
1223         * NEWS: Update style defaults.
1224
1225 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1226
1227         * main.c (captured_main_1): Disable styling in batch mode.
1228
1229 2019-02-20  Tom Tromey  <tom@tromey.com>
1230
1231         * symtab.c (symtab_symbol_info): Fix typos.
1232
1233 2019-02-20  Tom Tromey  <tromey@adacore.com>
1234
1235         * findcmd.c (_initialize_mem_search): Use upper case for
1236         metasyntactic variables.
1237
1238 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1239
1240         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1241         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1242
1243 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1244
1245         * top.h (source_file_name): Change to std::string.
1246         * top.c (source_file_name): Likewise.
1247         (command_line_input): Adjust.
1248         * cli/cli-script.c (script_from_file): Adjust.
1249
1250 2019-02-19  Tom Tromey  <tromey@adacore.com>
1251
1252         * ravenscar-thread.c
1253         (ravenscar_thread_target::update_thread_list): Don't call
1254         ada_build_task_list.
1255         * ada-lang.h (ada_build_task_list): Don't declare.
1256         * ada-tasks.c (struct ada_tasks_inferior_data)
1257         <task_list_valid_p>: Now bool.
1258         (read_known_tasks, ada_task_list_changed)
1259         (ada_tasks_invalidate_inferior_data): Update.
1260         (read_known_tasks_array): Return bool.
1261         (read_known_tasks_list): Likewise.
1262         (read_known_tasks): Return void.
1263         (ada_build_task_list): Now static.
1264
1265 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1266
1267         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1268         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1269
1270 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1271
1272         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1273         variant for ada_tasks_pspace_data_handle and
1274         ada_tasks_inferior_data_handle.
1275         (ada_tasks_pspace_data_cleanup): New function.
1276         (ada_tasks_inferior_data_cleanup): New function.
1277
1278 2019-02-17  Tom Tromey  <tom@tromey.com>
1279
1280         * macrotab.h (macro_source_fullname): Return a std::string.
1281         * macrotab.c (macro_include, check_for_redefinition)
1282         (macro_undef, macro_lookup_definition, foreach_macro)
1283         (foreach_macro_in_scope): Update.
1284         (macro_source_fullname): Return a std::string.
1285         * macrocmd.c (show_pp_source_pos): Update.
1286
1287 2019-02-17  Tom Tromey  <tom@tromey.com>
1288
1289         * macrocmd.c (show_pp_source_pos): Style the file names.
1290
1291 2019-02-17  Tom Tromey  <tom@tromey.com>
1292
1293         PR tui/24197:
1294         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1295
1296 2019-02-17  Tom Tromey  <tom@tromey.com>
1297
1298         * ada-lang.c (user_select_syms): Use filtered printing.
1299         * utils.c (wrap_style): New global.
1300         (desired_style): Remove.
1301         (emit_style_escape): Add stream parameter.
1302         (set_output_style, reset_terminal_style, prompt_for_continue):
1303         Update.
1304         (flush_wrap_buffer): Only flush gdb_stdout.
1305         (wrap_here): Set wrap_style.
1306         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1307         treat escape sequences as a character.  Change when wrap buffer is
1308         flushed.
1309         (fputs_styled): Do not set the output style when the default is
1310         requested.
1311         * ui-style.h (struct ui_file_style) <is_default>: New method.
1312         * source.c (print_source_lines_base): Emit escape sequences in one
1313         piece.
1314
1315 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1316
1317         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1318         integers and enumeration types.
1319
1320 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1321
1322         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1323         instead of lookup_symbol_in_language
1324         (do_exact_match): New function.
1325         (ada_get_symbol_name_matcher): Return do_exact_match when
1326         doing a verbatim match.
1327
1328 2019-02-15  Tom Tromey  <tromey@adacore.com>
1329
1330         * ravenscar-thread.c (ravenscar_thread_target::resume)
1331         (ravenscar_thread_target::wait): Special case wildcard requests.
1332
1333 2019-02-15  Tom Tromey  <tromey@adacore.com>
1334
1335         * ravenscar-thread.c (base_ptid): Remove.
1336         (struct ravenscar_thread_target) <close>: New method.
1337         <m_base_ptid>: New member.
1338         <update_inferior_ptid, active_task, task_is_currently_active,
1339         runtime_initialized>: Declare methods.
1340         <ravenscar_thread_target>: Add constructor.
1341         (ravenscar_thread_target::task_is_currently_active)
1342         (ravenscar_thread_target::update_inferior_ptid)
1343         (ravenscar_runtime_initialized): Rename.  Now methods.
1344         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1345         (ravenscar_thread_target::update_thread_list): Update.
1346         (ravenscar_thread_target::active_task): Now method.
1347         (ravenscar_thread_target::store_registers)
1348         (ravenscar_thread_target::prepare_to_store)
1349         (ravenscar_thread_target::prepare_to_store)
1350         (ravenscar_thread_target::mourn_inferior): Update.
1351         (ravenscar_inferior_created): Use "new" to create target.
1352         (ravenscar_thread_target::get_ada_task_ptid): Update.
1353         (_initialize_ravenscar): Don't initialize base_ptid.
1354         (ravenscar_ops): Remove global.
1355
1356 2019-02-15  Tom Tromey  <tromey@adacore.com>
1357
1358         * target.h (push_target): Declare new overload.
1359         * target.c (push_target): New overload, taking an rvalue reference.
1360         * remote.c (remote_target::open_1): Use push_target overload.
1361         * corelow.c (core_target_open): Use push_target overload.
1362
1363 2019-02-15  Tom Tromey  <tromey@adacore.com>
1364
1365         * ravenscar-thread.c (is_ravenscar_task)
1366         (ravenscar_task_is_currently_active): Return bool.
1367         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1368         (_initialize_ravenscar): Remove "(void)".
1369         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1370         Return bool.
1371
1372 2019-02-15  Tom Tromey  <tromey@adacore.com>
1373
1374         * ravenscar-thread.c (ravenscar_runtime_initializer)
1375         (has_ravenscar_runtime, get_running_thread_id)
1376         (ravenscar_thread_target::resume): Fix indentation.
1377
1378 2019-02-15  Tom Tromey  <tromey@adacore.com>
1379
1380         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1381         from ravenscar_arch_ops.
1382         (sparc_ravenscar_ops::fetch_registers)
1383         (sparc_ravenscar_ops::store_registers): Now methods.
1384         (sparc_ravenscar_prepare_to_store): Remove.
1385         (sparc_ravenscar_ops): Redefine.
1386         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1387         methods and destructor.  Remove members.
1388         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1389         (ravenscar_thread_target::store_registers)
1390         (ravenscar_thread_target::prepare_to_store): Update.
1391         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1392         Remove.
1393         (struct ppc_ravenscar_powerpc_ops): Derive from
1394         ravenscar_arch_ops.
1395         (ppc_ravenscar_powerpc_ops::fetch_registers)
1396         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1397         (ppc_ravenscar_powerpc_ops): Redefine.
1398         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1399         (ppc_ravenscar_e500_ops::fetch_registers)
1400         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1401         (ppc_ravenscar_e500_ops): Redefine.
1402         * aarch64-ravenscar-thread.c
1403         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1404         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1405         (aarch64_ravenscar_fetch_registers)
1406         (aarch64_ravenscar_store_registers): Now methods.
1407         (aarch64_ravenscar_ops): Redefine.
1408
1409 2019-02-15  Tom Tromey  <tromey@adacore.com>
1410
1411         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1412         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1413         (ravenscar_thread_target::stopped_by_watchpoint)
1414         (ravenscar_thread_target::stopped_data_address)
1415         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1416
1417 2019-02-15  Tom Tromey  <tromey@adacore.com>
1418
1419         * ravenscar-thread.c: Fix some typos.
1420
1421 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1422             Tom Tromey  <tromey@adacore.com>
1423
1424         * ada-lang.c (ada_exception_sal): Change addr_string to a
1425         std::string.
1426         (create_ada_exception_catchpoint): Update.
1427
1428 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1429             Tom Tromey  <tromey@adacore.com>
1430
1431         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1432         (bp_location_ops): Remove.
1433         (base_breakpoint_allocate_location): Update.
1434         (free_bp_location): Update.
1435         * ada-lang.c (class ada_catchpoint_location)
1436         <ada_catchpoint_location>: Remove ops parameter.
1437         (ada_catchpoint_location_dtor): Remove.
1438         (ada_catchpoint_location_ops): Remove.
1439         (allocate_location_exception): Update.
1440         * breakpoint.h (struct bp_location_ops): Remove.
1441         (class bp_location) <bp_location>: Remove bp_location_ops
1442         parameter.
1443         <~bp_location>: Add destructor.
1444         <ops>: Remove.
1445
1446 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1447             Pedro Alves  <palves@redhat.com>
1448
1449         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1450         'PATH_MAX'.
1451
1452 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1453             Samuel Thibault  <samuel.thibault@gnu.org>
1454             Thomas Schwinge  <thomas@codesourcery.com>
1455
1456         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1457         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1458
1459 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1460
1461         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1462         (check_empty): Use "const char *".
1463
1464         * gnu-nat.c (gnu_nat_target::detach): Instead of
1465         'detach_inferior (pid)' call
1466         'detach_inferior (find_inferior_pid (pid))'.
1467
1468         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1469         'nat/fork-inferior.o'.
1470         * gnu-nat.c: #include "nat/fork-inferior.h".
1471
1472         * gnu-nat.c (gnu_nat_target::detach): Instead of
1473         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1474         * gnu-nat.h: #include "inf-child.h".
1475         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1476         'i386_gnu_nat_target::fetch_registers'.
1477         (gnu_store_registers): Rename/move to
1478         'i386_gnu_nat_target::store_registers'.
1479
1480         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1481         * gnu-nat.h (mach_thread_info): New function.
1482         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1483
1484         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1485
1486 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1487
1488         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1489
1490 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1491
1492         * windows-nat.c (windows_add_thread): Add new parameter
1493         "main_thread_p" with default value set to false.  Update
1494         function documentation as well as all callers.
1495         (windows_delete_thread): Likewise.
1496         (fake_create_process): Update call to windows_add_thread.
1497         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1498         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1499         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1500         call to windows_delete_thread.
1501
1502 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1503
1504         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1505
1506 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1507
1508         * symfile.c (find_separate_debug_file): Use canonical path of
1509         sysroot with child_path instead of gdb_sysroot if it is valid.
1510
1511 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1512
1513         * symfile.c (find_separate_debug_file): Use child_path to
1514         determine if an object file is under a sysroot.
1515
1516 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1517
1518         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1519         unittests/child-path-selftests.c.
1520         * common/pathstuff.c (child_path): New function.
1521         * common/pathstuff.h (child_path): New prototype.
1522         * unittests/child-path-selftests.c: New file.
1523
1524 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1525
1526         * symfile.c (find_separate_debug_file): Look for separate debug
1527         files in debug directories under the sysroot.
1528
1529 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1530
1531         * symtab.h (struct minimal_symbol data_p): New const method.
1532         (struct minimal_symbol text_p): Likewise.
1533         * symtab.c (output_source_filename): Use file name style
1534         to print file name.
1535         (print_symbol_info): Likewise.
1536         (print_msymbol_info): Use address style to print addresses.
1537         Use function name style to print executable text symbols.
1538         (expand_symtab_containing_pc): Use data_p.
1539         (find_pc_sect_compunit_symtab): Likewise.
1540
1541 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1542
1543         * breakpoint.c (describe_other_breakpoints): Use address style
1544         to print addresses.
1545         (say_where): Likewise.
1546
1547 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1548
1549         * ada-typeprint.c (print_func_type): Print function name
1550         style to print function name.
1551         * c-typeprint.c (c_print_type_1): Likewise.
1552
1553 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1554
1555         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1556         for execve.
1557
1558 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1559
1560         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1561         type_stack.
1562
1563 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1564
1565         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1566         TYPE_CODE_REF types.
1567
1568 2019-02-08  Jim Wilson  <jimw@sifive.com>
1569
1570         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1571         (riscv_linux_fregset): New.
1572         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1573
1574 2019-02-07  Tom Tromey  <tom@tromey.com>
1575
1576         * thread.c (thread_cancel_execution_command): Update.
1577         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1578         methods.
1579         (struct thread_fsm_ops): Remove.
1580         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1581         (thread_fsm_should_stop, thread_fsm_return_value)
1582         (thread_fsm_set_finished, thread_fsm_finished_p)
1583         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1584         Don't declare.
1585         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1586         * infrun.c (clear_proceed_status_thread)
1587         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1588         (print_stop_event): Update.
1589         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1590         Add constructor.
1591         (step_command_fsm_ops): Remove.
1592         (new_step_command_fsm): Remove.
1593         (step_1): Update.
1594         (step_command_fsm::should_stop): Rename from
1595         step_command_fsm_should_stop.
1596         (step_command_fsm::clean_up): Rename from
1597         step_command_fsm_clean_up.
1598         (step_command_fsm::do_async_reply_reason): Rename from
1599         step_command_fsm_async_reply_reason.
1600         (struct until_next_fsm): Inherit from thread_fsm.  Add
1601         constructor.
1602         (until_next_fsm_ops): Remove.
1603         (new_until_next_fsm): Remove.
1604         (until_next_fsm::should_stop): Rename from
1605         until_next_fsm_should_stop.
1606         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1607         (until_next_fsm::do_async_reply_reason): Rename from
1608         until_next_fsm_async_reply_reason.
1609         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1610         constructor.  Change type of breakpoint.
1611         (finish_command_fsm_ops): Remove.
1612         (new_finish_command_fsm): Remove.
1613         (finish_command_fsm::should_stop): Rename from
1614         finish_command_fsm_should_stop.
1615         (finish_command_fsm::clean_up): Rename from
1616         finish_command_fsm_clean_up.
1617         (finish_command_fsm::return_value): Rename from
1618         finish_command_fsm_return_value.
1619         (finish_command_fsm::do_async_reply_reason): Rename from
1620         finish_command_fsm_async_reply_reason.
1621         (finish_command): Update.
1622         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1623         Add constructor.
1624         (call_thread_fsm_ops): Remove.
1625         (call_thread_fsm::call_thread_fsm): Rename from
1626         new_call_thread_fsm.
1627         (call_thread_fsm::should_stop): Rename from
1628         call_thread_fsm_should_stop.
1629         (call_thread_fsm::should_notify_stop): Rename from
1630         call_thread_fsm_should_notify_stop.
1631         (run_inferior_call, call_function_by_hand_dummy): Update.
1632         * cli/cli-interp.c (should_print_stop_to_console): Update.
1633         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1634         Add constructor.  Change type of location_breakpoint,
1635         caller_breakpoint.
1636         (until_break_fsm_ops): Remove.
1637         (new_until_break_fsm): Remove.
1638         (until_break_fsm::should_stop): Rename from
1639         until_break_fsm_should_stop.
1640         (until_break_fsm::clean_up): Rename from
1641         until_break_fsm_clean_up.
1642         (until_break_fsm::do_async_reply_reason): Rename from
1643         until_break_fsm_async_reply_reason.
1644         (until_break_command): Update.
1645         * thread-fsm.c: Remove.
1646         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1647
1648 2019-02-07  Tom Tromey  <tom@tromey.com>
1649
1650         * yy-remap.h: Add include guard.
1651         * xtensa-tdep.h: Add include guard.
1652         * xcoffread.h: Rename include guard.
1653         * varobj-iter.h: Add include guard.
1654         * tui/tui.h: Rename include guard.
1655         * tui/tui-winsource.h: Rename include guard.
1656         * tui/tui-wingeneral.h: Rename include guard.
1657         * tui/tui-windata.h: Rename include guard.
1658         * tui/tui-win.h: Rename include guard.
1659         * tui/tui-stack.h: Rename include guard.
1660         * tui/tui-source.h: Rename include guard.
1661         * tui/tui-regs.h: Rename include guard.
1662         * tui/tui-out.h: Rename include guard.
1663         * tui/tui-layout.h: Rename include guard.
1664         * tui/tui-io.h: Rename include guard.
1665         * tui/tui-hooks.h: Rename include guard.
1666         * tui/tui-file.h: Rename include guard.
1667         * tui/tui-disasm.h: Rename include guard.
1668         * tui/tui-data.h: Rename include guard.
1669         * tui/tui-command.h: Rename include guard.
1670         * tic6x-tdep.h: Add include guard.
1671         * target/waitstatus.h: Rename include guard.
1672         * target/wait.h: Rename include guard.
1673         * target/target.h: Rename include guard.
1674         * target/resume.h: Rename include guard.
1675         * target-float.h: Rename include guard.
1676         * stabsread.h: Add include guard.
1677         * rs6000-tdep.h: Add include guard.
1678         * riscv-fbsd-tdep.h: Add include guard.
1679         * regformats/regdef.h: Rename include guard.
1680         * record.h: Rename include guard.
1681         * python/python.h: Rename include guard.
1682         * python/python-internal.h: Rename include guard.
1683         * python/py-stopevent.h: Rename include guard.
1684         * python/py-ref.h: Rename include guard.
1685         * python/py-record.h: Rename include guard.
1686         * python/py-record-full.h: Rename include guard.
1687         * python/py-record-btrace.h: Rename include guard.
1688         * python/py-instruction.h: Rename include guard.
1689         * python/py-events.h: Rename include guard.
1690         * python/py-event.h: Rename include guard.
1691         * procfs.h: Add include guard.
1692         * proc-utils.h: Add include guard.
1693         * p-lang.h: Add include guard.
1694         * or1k-tdep.h: Rename include guard.
1695         * observable.h: Rename include guard.
1696         * nto-tdep.h: Rename include guard.
1697         * nat/x86-linux.h: Rename include guard.
1698         * nat/x86-linux-dregs.h: Rename include guard.
1699         * nat/x86-gcc-cpuid.h: Add include guard.
1700         * nat/x86-dregs.h: Rename include guard.
1701         * nat/x86-cpuid.h: Rename include guard.
1702         * nat/ppc-linux.h: Rename include guard.
1703         * nat/mips-linux-watch.h: Rename include guard.
1704         * nat/linux-waitpid.h: Rename include guard.
1705         * nat/linux-ptrace.h: Rename include guard.
1706         * nat/linux-procfs.h: Rename include guard.
1707         * nat/linux-osdata.h: Rename include guard.
1708         * nat/linux-nat.h: Rename include guard.
1709         * nat/linux-namespaces.h: Rename include guard.
1710         * nat/linux-btrace.h: Rename include guard.
1711         * nat/glibc_thread_db.h: Rename include guard.
1712         * nat/gdb_thread_db.h: Rename include guard.
1713         * nat/gdb_ptrace.h: Rename include guard.
1714         * nat/fork-inferior.h: Rename include guard.
1715         * nat/amd64-linux-siginfo.h: Rename include guard.
1716         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1717         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1718         * nat/aarch64-linux.h: Rename include guard.
1719         * nat/aarch64-linux-hw-point.h: Rename include guard.
1720         * mn10300-tdep.h: Add include guard.
1721         * mips-linux-tdep.h: Add include guard.
1722         * mi/mi-parse.h: Rename include guard.
1723         * mi/mi-out.h: Rename include guard.
1724         * mi/mi-main.h: Rename include guard.
1725         * mi/mi-interp.h: Rename include guard.
1726         * mi/mi-getopt.h: Rename include guard.
1727         * mi/mi-console.h: Rename include guard.
1728         * mi/mi-common.h: Rename include guard.
1729         * mi/mi-cmds.h: Rename include guard.
1730         * mi/mi-cmd-break.h: Rename include guard.
1731         * m2-lang.h: Add include guard.
1732         * location.h: Rename include guard.
1733         * linux-record.h: Rename include guard.
1734         * linux-nat.h: Add include guard.
1735         * linux-fork.h: Add include guard.
1736         * i386-darwin-tdep.h: Rename include guard.
1737         * hppa-linux-offsets.h: Add include guard.
1738         * guile/guile.h: Rename include guard.
1739         * guile/guile-internal.h: Rename include guard.
1740         * gnu-nat.h: Rename include guard.
1741         * gdb-stabs.h: Rename include guard.
1742         * frv-tdep.h: Add include guard.
1743         * f-lang.h: Add include guard.
1744         * event-loop.h: Add include guard.
1745         * darwin-nat.h: Rename include guard.
1746         * cp-abi.h: Rename include guard.
1747         * config/sparc/nm-sol2.h: Rename include guard.
1748         * config/nm-nto.h: Rename include guard.
1749         * config/nm-linux.h: Add include guard.
1750         * config/i386/nm-i386gnu.h: Rename include guard.
1751         * config/djgpp/nl_types.h: Rename include guard.
1752         * config/djgpp/langinfo.h: Rename include guard.
1753         * compile/gcc-cp-plugin.h: Add include guard.
1754         * compile/gcc-c-plugin.h: Add include guard.
1755         * compile/compile.h: Rename include guard.
1756         * compile/compile-object-run.h: Rename include guard.
1757         * compile/compile-object-load.h: Rename include guard.
1758         * compile/compile-internal.h: Rename include guard.
1759         * compile/compile-cplus.h: Rename include guard.
1760         * compile/compile-c.h: Rename include guard.
1761         * common/xml-utils.h: Rename include guard.
1762         * common/x86-xstate.h: Rename include guard.
1763         * common/version.h: Rename include guard.
1764         * common/vec.h: Rename include guard.
1765         * common/tdesc.h: Rename include guard.
1766         * common/selftest.h: Rename include guard.
1767         * common/scoped_restore.h: Rename include guard.
1768         * common/scoped_mmap.h: Rename include guard.
1769         * common/scoped_fd.h: Rename include guard.
1770         * common/safe-iterator.h: Rename include guard.
1771         * common/run-time-clock.h: Rename include guard.
1772         * common/refcounted-object.h: Rename include guard.
1773         * common/queue.h: Rename include guard.
1774         * common/ptid.h: Rename include guard.
1775         * common/print-utils.h: Rename include guard.
1776         * common/preprocessor.h: Rename include guard.
1777         * common/pathstuff.h: Rename include guard.
1778         * common/observable.h: Rename include guard.
1779         * common/netstuff.h: Rename include guard.
1780         * common/job-control.h: Rename include guard.
1781         * common/host-defs.h: Rename include guard.
1782         * common/gdb_wait.h: Rename include guard.
1783         * common/gdb_vecs.h: Rename include guard.
1784         * common/gdb_unlinker.h: Rename include guard.
1785         * common/gdb_unique_ptr.h: Rename include guard.
1786         * common/gdb_tilde_expand.h: Rename include guard.
1787         * common/gdb_sys_time.h: Rename include guard.
1788         * common/gdb_string_view.h: Rename include guard.
1789         * common/gdb_splay_tree.h: Rename include guard.
1790         * common/gdb_setjmp.h: Rename include guard.
1791         * common/gdb_ref_ptr.h: Rename include guard.
1792         * common/gdb_optional.h: Rename include guard.
1793         * common/gdb_locale.h: Rename include guard.
1794         * common/gdb_assert.h: Rename include guard.
1795         * common/filtered-iterator.h: Rename include guard.
1796         * common/filestuff.h: Rename include guard.
1797         * common/fileio.h: Rename include guard.
1798         * common/environ.h: Rename include guard.
1799         * common/common-utils.h: Rename include guard.
1800         * common/common-types.h: Rename include guard.
1801         * common/common-regcache.h: Rename include guard.
1802         * common/common-inferior.h: Rename include guard.
1803         * common/common-gdbthread.h: Rename include guard.
1804         * common/common-exceptions.h: Rename include guard.
1805         * common/common-defs.h: Rename include guard.
1806         * common/common-debug.h: Rename include guard.
1807         * common/cleanups.h: Rename include guard.
1808         * common/buffer.h: Rename include guard.
1809         * common/btrace-common.h: Rename include guard.
1810         * common/break-common.h: Rename include guard.
1811         * cli/cli-utils.h: Rename include guard.
1812         * cli/cli-style.h: Rename include guard.
1813         * cli/cli-setshow.h: Rename include guard.
1814         * cli/cli-script.h: Rename include guard.
1815         * cli/cli-interp.h: Rename include guard.
1816         * cli/cli-decode.h: Rename include guard.
1817         * cli/cli-cmds.h: Rename include guard.
1818         * charset-list.h: Add include guard.
1819         * buildsym-legacy.h: Rename include guard.
1820         * bfin-tdep.h: Add include guard.
1821         * ax.h: Rename include guard.
1822         * arm-linux-tdep.h: Add include guard.
1823         * arm-fbsd-tdep.h: Add include guard.
1824         * arch/xtensa.h: Rename include guard.
1825         * arch/tic6x.h: Add include guard.
1826         * arch/i386.h: Add include guard.
1827         * arch/arm.h: Rename include guard.
1828         * arch/arm-linux.h: Rename include guard.
1829         * arch/arm-get-next-pcs.h: Rename include guard.
1830         * arch/amd64.h: Add include guard.
1831         * arch/aarch64-insn.h: Rename include guard.
1832         * arch-utils.h: Rename include guard.
1833         * annotate.h: Add include guard.
1834         * amd64-darwin-tdep.h: Rename include guard.
1835         * aarch64-linux-tdep.h: Add include guard.
1836         * aarch64-fbsd-tdep.h: Add include guard.
1837         * aarch32-linux-nat.h: Add include guard.
1838
1839 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1840
1841         * macrotab.c (macro_define_internal): New function that
1842         factorizes macro_define_object_internal and macro_define_function
1843         code.
1844         (macro_define_object_internal): Use macro_define_internal.
1845         (macro_define_function): Likewise.
1846
1847 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1848
1849         * macrocmd.c (extract_identifier): Return
1850         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1851         callers.
1852
1853 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1854
1855         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1856
1857 2019-02-05  Tom Tromey  <tom@tromey.com>
1858
1859         * target.c (target_stack::unpush): Move assertion earlier.
1860
1861 2019-01-30  Tom Tromey  <tom@tromey.com>
1862
1863         PR python/23615:
1864         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1865         (gdbpy_parse_and_eval): Likewise.
1866         * python/python-internal.h (gdbpy_allow_threads): New class.
1867
1868 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1869
1870         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1871         (aarch64_fbsd_fpregmap): Move earlier.
1872         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1873         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1874         instead of individual calls to trad_frame_set_reg_addr.
1875         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1876         earlier.
1877         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1878         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1879         instead of individual calls to trad_frame_set_reg_addr.
1880
1881 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1882
1883         * CONTRIBUTE: Replace contribution list with wiki link.
1884
1885 2019-01-25  Tom Tromey  <tom@tromey.com>
1886
1887         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1888
1889 2019-01-25  Tom Tromey  <tom@tromey.com>
1890
1891         * xtensa-linux-nat.c: Fix common/ includes.
1892         * xml-support.h: Fix common/ includes.
1893         * xml-support.c: Fix common/ includes.
1894         * x86-linux-nat.c: Fix common/ includes.
1895         * windows-nat.c: Fix common/ includes.
1896         * varobj.h: Fix common/ includes.
1897         * varobj.c: Fix common/ includes.
1898         * value.c: Fix common/ includes.
1899         * valops.c: Fix common/ includes.
1900         * utils.c: Fix common/ includes.
1901         * unittests/xml-utils-selftests.c: Fix common/ includes.
1902         * unittests/utils-selftests.c: Fix common/ includes.
1903         * unittests/unpack-selftests.c: Fix common/ includes.
1904         * unittests/tracepoint-selftests.c: Fix common/ includes.
1905         * unittests/style-selftests.c: Fix common/ includes.
1906         * unittests/string_view-selftests.c: Fix common/ includes.
1907         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1908         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1909         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1910         * unittests/rsp-low-selftests.c: Fix common/ includes.
1911         * unittests/parse-connection-spec-selftests.c: Fix common/
1912         includes.
1913         * unittests/optional-selftests.c: Fix common/ includes.
1914         * unittests/offset-type-selftests.c: Fix common/ includes.
1915         * unittests/observable-selftests.c: Fix common/ includes.
1916         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1917         * unittests/memrange-selftests.c: Fix common/ includes.
1918         * unittests/memory-map-selftests.c: Fix common/ includes.
1919         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1920         * unittests/function-view-selftests.c: Fix common/ includes.
1921         * unittests/environ-selftests.c: Fix common/ includes.
1922         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1923         * unittests/common-utils-selftests.c: Fix common/ includes.
1924         * unittests/cli-utils-selftests.c: Fix common/ includes.
1925         * unittests/array-view-selftests.c: Fix common/ includes.
1926         * ui-file.c: Fix common/ includes.
1927         * tui/tui-io.c: Fix common/ includes.
1928         * tracepoint.h: Fix common/ includes.
1929         * tracepoint.c: Fix common/ includes.
1930         * tracefile-tfile.c: Fix common/ includes.
1931         * top.h: Fix common/ includes.
1932         * top.c: Fix common/ includes.
1933         * thread.c: Fix common/ includes.
1934         * target/waitstatus.h: Fix common/ includes.
1935         * target/waitstatus.c: Fix common/ includes.
1936         * target.h: Fix common/ includes.
1937         * target.c: Fix common/ includes.
1938         * target-memory.c: Fix common/ includes.
1939         * target-descriptions.c: Fix common/ includes.
1940         * symtab.h: Fix common/ includes.
1941         * symfile.c: Fix common/ includes.
1942         * stap-probe.c: Fix common/ includes.
1943         * spu-linux-nat.c: Fix common/ includes.
1944         * sparc-nat.c: Fix common/ includes.
1945         * source.c: Fix common/ includes.
1946         * solib.c: Fix common/ includes.
1947         * solib-target.c: Fix common/ includes.
1948         * ser-unix.c: Fix common/ includes.
1949         * ser-tcp.c: Fix common/ includes.
1950         * ser-pipe.c: Fix common/ includes.
1951         * ser-base.c: Fix common/ includes.
1952         * selftest-arch.c: Fix common/ includes.
1953         * s12z-tdep.c: Fix common/ includes.
1954         * rust-exp.y: Fix common/ includes.
1955         * rs6000-aix-tdep.c: Fix common/ includes.
1956         * riscv-tdep.c: Fix common/ includes.
1957         * remote.c: Fix common/ includes.
1958         * remote-notif.h: Fix common/ includes.
1959         * remote-fileio.h: Fix common/ includes.
1960         * remote-fileio.c: Fix common/ includes.
1961         * regcache.h: Fix common/ includes.
1962         * regcache.c: Fix common/ includes.
1963         * record-btrace.c: Fix common/ includes.
1964         * python/python.c: Fix common/ includes.
1965         * python/py-type.c: Fix common/ includes.
1966         * python/py-inferior.c: Fix common/ includes.
1967         * progspace.h: Fix common/ includes.
1968         * producer.c: Fix common/ includes.
1969         * procfs.c: Fix common/ includes.
1970         * proc-api.c: Fix common/ includes.
1971         * printcmd.c: Fix common/ includes.
1972         * ppc-linux-nat.c: Fix common/ includes.
1973         * parser-defs.h: Fix common/ includes.
1974         * osdata.c: Fix common/ includes.
1975         * obsd-nat.c: Fix common/ includes.
1976         * nat/x86-linux.c: Fix common/ includes.
1977         * nat/x86-linux-dregs.c: Fix common/ includes.
1978         * nat/x86-dregs.h: Fix common/ includes.
1979         * nat/x86-dregs.c: Fix common/ includes.
1980         * nat/ppc-linux.c: Fix common/ includes.
1981         * nat/mips-linux-watch.h: Fix common/ includes.
1982         * nat/mips-linux-watch.c: Fix common/ includes.
1983         * nat/linux-waitpid.c: Fix common/ includes.
1984         * nat/linux-ptrace.h: Fix common/ includes.
1985         * nat/linux-ptrace.c: Fix common/ includes.
1986         * nat/linux-procfs.c: Fix common/ includes.
1987         * nat/linux-personality.c: Fix common/ includes.
1988         * nat/linux-osdata.c: Fix common/ includes.
1989         * nat/linux-namespaces.c: Fix common/ includes.
1990         * nat/linux-btrace.h: Fix common/ includes.
1991         * nat/linux-btrace.c: Fix common/ includes.
1992         * nat/fork-inferior.c: Fix common/ includes.
1993         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1994         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1995         * nat/aarch64-linux.c: Fix common/ includes.
1996         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1997         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1998         * namespace.h: Fix common/ includes.
1999         * mips-linux-tdep.c: Fix common/ includes.
2000         * minsyms.c: Fix common/ includes.
2001         * mi/mi-parse.h: Fix common/ includes.
2002         * mi/mi-main.c: Fix common/ includes.
2003         * mi/mi-cmd-env.c: Fix common/ includes.
2004         * memrange.h: Fix common/ includes.
2005         * memattr.c: Fix common/ includes.
2006         * maint.h: Fix common/ includes.
2007         * maint.c: Fix common/ includes.
2008         * main.c: Fix common/ includes.
2009         * machoread.c: Fix common/ includes.
2010         * location.c: Fix common/ includes.
2011         * linux-thread-db.c: Fix common/ includes.
2012         * linux-nat.c: Fix common/ includes.
2013         * linux-fork.c: Fix common/ includes.
2014         * inline-frame.c: Fix common/ includes.
2015         * infrun.c: Fix common/ includes.
2016         * inflow.c: Fix common/ includes.
2017         * inferior.h: Fix common/ includes.
2018         * inferior.c: Fix common/ includes.
2019         * infcmd.c: Fix common/ includes.
2020         * inf-ptrace.c: Fix common/ includes.
2021         * inf-child.c: Fix common/ includes.
2022         * ia64-linux-nat.c: Fix common/ includes.
2023         * i387-tdep.c: Fix common/ includes.
2024         * i386-tdep.c: Fix common/ includes.
2025         * i386-linux-tdep.c: Fix common/ includes.
2026         * i386-linux-nat.c: Fix common/ includes.
2027         * i386-go32-tdep.c: Fix common/ includes.
2028         * i386-fbsd-tdep.c: Fix common/ includes.
2029         * i386-fbsd-nat.c: Fix common/ includes.
2030         * guile/scm-type.c: Fix common/ includes.
2031         * guile/guile.c: Fix common/ includes.
2032         * go32-nat.c: Fix common/ includes.
2033         * gnu-nat.c: Fix common/ includes.
2034         * gdbthread.h: Fix common/ includes.
2035         * gdbarch-selftests.c: Fix common/ includes.
2036         * gdb_usleep.c: Fix common/ includes.
2037         * gdb_select.h: Fix common/ includes.
2038         * gdb_bfd.c: Fix common/ includes.
2039         * gcore.c: Fix common/ includes.
2040         * fork-child.c: Fix common/ includes.
2041         * findvar.c: Fix common/ includes.
2042         * fbsd-nat.c: Fix common/ includes.
2043         * event-top.c: Fix common/ includes.
2044         * event-loop.c: Fix common/ includes.
2045         * dwarf2read.c: Fix common/ includes.
2046         * dwarf2loc.c: Fix common/ includes.
2047         * dwarf2-frame.c: Fix common/ includes.
2048         * dwarf-index-cache.c: Fix common/ includes.
2049         * dtrace-probe.c: Fix common/ includes.
2050         * disasm-selftests.c: Fix common/ includes.
2051         * defs.h: Fix common/ includes.
2052         * csky-tdep.c: Fix common/ includes.
2053         * cp-valprint.c: Fix common/ includes.
2054         * cp-support.h: Fix common/ includes.
2055         * cp-support.c: Fix common/ includes.
2056         * corelow.c: Fix common/ includes.
2057         * completer.h: Fix common/ includes.
2058         * completer.c: Fix common/ includes.
2059         * compile/compile.c: Fix common/ includes.
2060         * compile/compile-loc2c.c: Fix common/ includes.
2061         * compile/compile-cplus-types.c: Fix common/ includes.
2062         * compile/compile-cplus-symbols.c: Fix common/ includes.
2063         * command.h: Fix common/ includes.
2064         * cli/cli-dump.c: Fix common/ includes.
2065         * cli/cli-cmds.c: Fix common/ includes.
2066         * charset.c: Fix common/ includes.
2067         * build-id.c: Fix common/ includes.
2068         * btrace.h: Fix common/ includes.
2069         * btrace.c: Fix common/ includes.
2070         * breakpoint.h: Fix common/ includes.
2071         * breakpoint.c: Fix common/ includes.
2072         * ax.h:
2073         (enum agent_op): Fix common/ includes.
2074         * ax-general.c (struct aop_map): Fix common/ includes.
2075         * ax-gdb.c: Fix common/ includes.
2076         * auxv.c: Fix common/ includes.
2077         * auto-load.c: Fix common/ includes.
2078         * arm-tdep.c: Fix common/ includes.
2079         * arch/riscv.c: Fix common/ includes.
2080         * arch/ppc-linux-common.c: Fix common/ includes.
2081         * arch/i386.c: Fix common/ includes.
2082         * arch/arm.c: Fix common/ includes.
2083         * arch/arm-linux.c: Fix common/ includes.
2084         * arch/arm-get-next-pcs.c: Fix common/ includes.
2085         * arch/amd64.c: Fix common/ includes.
2086         * arch/aarch64.c: Fix common/ includes.
2087         * arch/aarch64-insn.c: Fix common/ includes.
2088         * arch-utils.c: Fix common/ includes.
2089         * amd64-windows-tdep.c: Fix common/ includes.
2090         * amd64-tdep.c: Fix common/ includes.
2091         * amd64-sol2-tdep.c: Fix common/ includes.
2092         * amd64-obsd-tdep.c: Fix common/ includes.
2093         * amd64-nbsd-tdep.c: Fix common/ includes.
2094         * amd64-linux-tdep.c: Fix common/ includes.
2095         * amd64-linux-nat.c: Fix common/ includes.
2096         * amd64-fbsd-tdep.c: Fix common/ includes.
2097         * amd64-fbsd-nat.c: Fix common/ includes.
2098         * amd64-dicos-tdep.c: Fix common/ includes.
2099         * amd64-darwin-tdep.c: Fix common/ includes.
2100         * agent.c: Fix common/ includes.
2101         * ada-lang.h: Fix common/ includes.
2102         * ada-lang.c: Fix common/ includes.
2103         * aarch64-tdep.c: Fix common/ includes.
2104
2105 2019-01-25  Tom Tromey  <tom@tromey.com>
2106
2107         * common/create-version.sh: Use common/version.h.
2108
2109 2019-01-24  Pedro Alves  <palves@redhat.com>
2110
2111         * infrun.c (signal_stop, signal_print, signal_program)
2112         (signal_catch, signal_pass): Now arrays instead of pointers.
2113         (update_signals_program_target, do_target_resume)
2114         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2115         * linux-nat.c (linux_nat_target::pass_signals)
2116         (linux_nat_target::create_inferior, linux_nat_target::attach):
2117         Adjust.
2118         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2119         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2120         * procfs.c (procfs_target::pass_signals): Adjust.
2121         * record-full.c (record_full_target::resume): Adjust.
2122         * remote.c (remote_target::pass_signals)
2123         (remote_target::program_signals): Adjust.
2124         * target-debug.h (target_debug_print_signals): Now takes a
2125         gdb::array_view as parameter.  Adjust.
2126         * target.h (target_ops) <pass_signals, program_signals>: Replace
2127         pointer and length parameters with gdb::array_view.
2128         (target_pass_signals, target_program_signals): Likewise.
2129         * target-delegates.c: Regenerate.
2130
2131 2019-01-24  Pedro Alves  <palves@redhat.com>
2132
2133         * common/forward-scope-exit.h
2134         (forward_scope_exit::forward_scope_exit): Pass arguments to
2135         m_bind_function directly, instead of creating a std::bind and
2136         copying that.
2137
2138 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2139
2140         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2141         for static members.
2142         (pass_in_v_vfp_candidate): Likewise.
2143
2144 2019-01-23  Tom Tromey  <tom@tromey.com>
2145             Pedro Alves  <palves@redhat.com>
2146
2147         * regcache.c (class regcache_invalidator): Remove.
2148         (regcache::raw_write): Use make_scope_exit.
2149
2150 2019-01-23  Tom Tromey  <tom@tromey.com>
2151
2152         * ui-out.h (class ui_out_emit_type): Update comment.
2153
2154 2019-01-23  Tom Tromey  <tom@tromey.com>
2155
2156         * infrun.c (fetch_inferior_event): Update comment.
2157
2158 2019-01-23  Tom Tromey  <tom@tromey.com>
2159             Pedro Alves  <palves@redhat.com>
2160
2161         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2162         parameter.
2163         (fetch_inferior_event): Use SCOPE_EXIT.
2164
2165
2166 2019-01-23  Tom Tromey  <tom@tromey.com>
2167             Pedro Alves  <palves@redhat.com>
2168
2169         * infrun.c (disable_thread_events): Delete.
2170         (stop_all_threads): Use SCOPE_EXIT.
2171
2172 2019-01-23  Tom Tromey  <tom@tromey.com>
2173             Pedro Alves  <palves@redhat.com>
2174
2175         * symfile.c: Include forward-scope-exit.h.
2176         (clear_symtab_users_cleanup): Replace forward declaration with
2177         a FORWARD_SCOPE_EXIT.
2178         (syms_from_objfile_1): Use the forward_scope_exit and
2179         gdb::optional instead of cleanup_function.
2180         (reread_symbols): Use the forward_scope_exit instead of
2181         cleanup_function.
2182         (clear_symtab_users_cleanup): Remove function.
2183
2184 2019-01-23  Tom Tromey  <tom@tromey.com>
2185             Pedro Alves  <palves@redhat.com>
2186
2187         * linux-nat.c: Include scope-exit.h.
2188         (cleanup_target_stop): Remove.
2189         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2190         SCOPE_EXIT.
2191
2192 2019-01-23  Tom Tromey  <tom@tromey.com>
2193             Pedro Alves  <palves@redhat.com>
2194
2195         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2196         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2197
2198 2019-01-23  Tom Tromey  <tom@tromey.com>
2199             Andrew Burgess  <andrew.burgess@embecosm.com>
2200             Pedro Alves  <palves@redhat.com>
2201
2202         * infrun.c (fetch_inferior_event): Use scope_exit.
2203         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2204         * top.c (execute_command): Use scope_exit.
2205         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2206         * utils.c (do_bpstat_clear_actions_cleanup)
2207         (make_bpstat_clear_actions_cleanup): Remove.
2208
2209 2019-01-23  Tom Tromey  <tom@tromey.com>
2210             Pedro Alves  <palves@redhat.com>
2211
2212         * infrun.c: Include "common/scope-exit.h"
2213         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2214         (wait_for_inferior): Use SCOPE_EXIT.
2215         (fetch_inferior_event): Use scope_exit.
2216
2217 2019-01-23  Tom Tromey  <tom@tromey.com>
2218             Pedro Alves  <palves@redhat.com>
2219
2220         * breakpoint.c (create_breakpoint): Remove cleanup.
2221
2222 2019-01-23  Tom Tromey  <tom@tromey.com>
2223             Andrew Burgess  <andrew.burgess@embecosm.com>
2224             Pedro Alves  <palves@redhat.com>
2225
2226 2019-01-23  Pedro Alves  <palves@redhat.com>
2227
2228         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2229
2230 2019-01-23  Pedro Alves  <palves@redhat.com>
2231             Andrew Burgess  <andrew.burgess@embecosm.com>
2232
2233         * gdbthread.h: Include "common/forward-scope-exit.h".
2234         (scoped_finish_thread_state): Redefine custom class in terms of
2235         forward_scope_exit.
2236
2237 2019-01-23  Pedro Alves  <palves@redhat.com>
2238             Andrew Burgess  <andrew.burgess@embecosm.com>
2239
2240         * common/forward-scope-exit.h: New file.
2241
2242 2019-01-23  Pedro Alves  <palves@redhat.com>
2243             Andrew Burgess  <andrew.burgess@embecosm.com>
2244             Tom Tromey  <tom@tromey.com>
2245
2246         * common/scope-exit.h: New file.
2247
2248 2019-01-23  Pedro Alves  <palves@redhat.com>
2249
2250         * common/preprocessor.h (ESC): Rename to ...
2251         (ESC_PARENS): ... this.
2252         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2253         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2254
2255 2019-01-23  Tom Tromey  <tom@tromey.com>
2256
2257         * language.h (class scoped_switch_to_sym_language_if_auto):
2258         Initialize m_lang in both cases.
2259
2260 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2261
2262         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2263         with XCNEW.
2264
2265 2019-01-22  Tom Tromey  <tom@tromey.com>
2266
2267         * corelow.c: Do not include sys/file.h.
2268
2269 2019-01-22  Tom Tromey  <tom@tromey.com>
2270
2271         * tui/tui-wingeneral.h: Include gdb_curses.h.
2272
2273 2019-01-22  Tom Tromey  <tom@tromey.com>
2274
2275         * source-cache.h (class source_cache) <get_source_lines,
2276         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2277
2278 2019-01-22  Tom Tromey  <tom@tromey.com>
2279
2280         * remote-fileio.h (struct remote_target): Declare.
2281
2282 2019-01-22  Tom Tromey  <tom@tromey.com>
2283
2284         * python/py-arch.c: Do not include py-ref.h.
2285         * python/py-bpevent.c: Do not include py-ref.h.
2286         * python/py-cmd.c: Do not include py-ref.h.
2287         * python/py-continueevent.c: Do not include py-ref.h.
2288         * python/py-event.h: Do not include py-ref.h.
2289         * python/py-evtregistry.c: Do not include py-ref.h.
2290         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2291         * python/py-frame.c: Do not include py-ref.h.
2292         * python/py-framefilter.c: Do not include py-ref.h.
2293         * python/py-function.c: Do not include py-ref.h.
2294         * python/py-infevents.c: Do not include py-ref.h.
2295         * python/py-linetable.c: Do not include py-ref.h.
2296         * python/py-objfile.c: Do not include py-ref.h.
2297         * python/py-param.c: Do not include py-ref.h.
2298         * python/py-prettyprint.c: Do not include py-ref.h.
2299         * python/py-progspace.c: Do not include py-ref.h.
2300         * python/py-symbol.c: Do not include py-ref.h.
2301         * python/py-symtab.c: Do not include py-ref.h.
2302         * python/py-type.c: Do not include py-ref.h.
2303         * python/py-unwind.c: Do not include py-ref.h.
2304         * python/py-utils.c: Do not include py-ref.h.
2305         * python/py-value.c: Do not include py-ref.h.
2306         * python/py-varobj.c: Do not include py-ref.h.
2307         * python/py-xmethods.c: Do not include py-ref.h.
2308         * python/python.c: Do not include py-ref.h.
2309         * varobj.c: Do not include py-ref.h.
2310
2311 2019-01-22  Tom Tromey  <tom@tromey.com>
2312
2313         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2314         keyword for bcache.
2315
2316 2019-01-22  Tom Tromey  <tom@tromey.com>
2317
2318         * compile/compile-cplus-types.c: Remove a comment by #include.
2319
2320 2019-01-22  Tom Tromey  <tom@tromey.com>
2321
2322         * compile/gcc-c-plugin.h: Include compile-internal.h.
2323
2324 2019-01-22  Tom Tromey  <tom@tromey.com>
2325
2326         * stabsread.c (EXTERN): Do not define.
2327         (symnum, next_symbol_text_func, processing_gcc_compilation)
2328         (within_function, global_sym_chain, global_stabs)
2329         (previous_stab_code, this_object_header_files)
2330         (n_this_object_header_files)
2331         (n_allocated_this_object_header_files): Define.
2332         * stabsread.h (EXTERN): Never define.  Use "extern".
2333
2334 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2335
2336         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2337         history_value.
2338
2339 2019-01-21  Tom Tromey  <tom@tromey.com>
2340
2341         * ui-out.c: Fix includes.
2342         * tui/tui-source.c: Fix includes.
2343         * target.c: Fix includes.
2344         * remote.c: Fix includes.
2345         * regcache.c: Fix includes.
2346         * python/py-block.c: Fix includes.
2347         * printcmd.c: Fix includes.
2348         * or1k-tdep.c: Fix includes.
2349         * mi/mi-main.c: Fix includes.
2350         * m32r-tdep.c: Fix includes.
2351         * csky-tdep.c: Fix includes.
2352         * compile/compile-cplus-types.c: Fix includes.
2353         * cli/cli-interp.c: Fix includes.
2354
2355 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2356
2357         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2358         for padding.
2359
2360 2019-01-16  Tom Tromey  <tom@tromey.com>
2361
2362         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2363         earlier.
2364         (struct objfile) <msymbols_range>: Move from top level.
2365         <msymbols>: New method.
2366         (class objfile_msymbols): Remove.
2367         * symtab.c (default_collect_symbol_completion_matches_break_on):
2368         Update.
2369         * symmisc.c (dump_msymbols): Update.
2370         * stabsread.c (scan_file_globals): Update.
2371         * objc-lang.c (info_selectors_command, info_classes_command)
2372         (find_methods): Update.
2373         * minsyms.c (find_solib_trampoline_target): Update.
2374         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2375         * coffread.c (coff_symfile_read): Update.
2376         * ada-lang.c (ada_lookup_simple_minsym)
2377         (ada_collect_symbol_completion_matches): Update.
2378
2379 2019-01-16  Tom Tromey  <tom@tromey.com>
2380
2381         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2382         type.  Remove no-argument constructor.
2383         <iterator::operator++>: Simplify.
2384         <begin>: Update.
2385         <end>: Use minimal_symbol_count.
2386
2387 2019-01-16  Tom Tromey  <tom@tromey.com>
2388
2389         * objfiles.h (struct objfile) <psymtabs>: New method.
2390         (class objfile_psymtabs): Remove.
2391         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2392         typedef.
2393         <range>: New method.
2394         (require_partial_symbols): Change return type.
2395         * psymtab.c (require_partial_symbols)
2396         (psym_expand_symtabs_matching): Update.
2397         * mdebugread.c (parse_partial_symbols): Update.
2398         * dbxread.c (dbx_end_psymtab): Update.
2399
2400 2019-01-15  Tom Tromey  <tom@tromey.com>
2401
2402         * symtab.c (lookup_objfile_from_block)
2403         (lookup_symbol_in_objfile_symtabs)
2404         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2405         (find_line_symtab, info_sources_command)
2406         (default_collect_symbol_completion_matches_break_on)
2407         (make_source_files_completion_list): Update.
2408         * symmisc.c (print_objfile_statistics, dump_objfile)
2409         (maintenance_print_symbols, maintenance_info_symtabs)
2410         (maintenance_check_symtabs, maintenance_info_line_tables):
2411         Update.
2412         * source.c (select_source_symtab)
2413         (forget_cached_source_info_for_objfile): Update.
2414         * objfiles.h (class objfile_compunits): Remove.
2415         (struct objfile) <compunits_range>: New typedef.
2416         (compunits): New method.
2417         * objfiles.c (objfile_relocate1): Update.
2418         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2419         * maint.c (count_symtabs_and_blocks): Update.
2420         * linespec.c (iterate_over_all_matching_symtabs): Update.
2421         * cp-support.c (add_symbol_overload_list_qualified): Update.
2422         * coffread.c (coff_symtab_read): Update.
2423         * ada-lang.c (add_nonlocal_symbols)
2424         (ada_collect_symbol_completion_matches)
2425         (ada_add_global_exceptions): Update.
2426
2427 2019-01-15  Tom Tromey  <tom@tromey.com>
2428
2429         * progspace.h (program_space) <objfiles_safe_range>: New
2430         typedef.
2431         <objfiles_safe>: New method.
2432         * objfiles.h (class all_objfiles_safe): Remove.
2433         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2434         * jit.c (jit_inferior_exit_hook): Update.
2435
2436 2019-01-17  Tom Tromey  <tom@tromey.com>
2437
2438         * progspace.h (program_space) <objfiles_range>: New typedef.
2439         <objfiles>: New method.
2440         <objfiles_head>: Rename from objfiles.
2441         (object_files): Update.
2442         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2443         * guile/scm-pretty-print.c
2444         (ppscm_find_pretty_printer_from_objfiles): Update.
2445         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2446         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2447         Update.
2448         * python/py-progspace.c (pspy_get_objfiles): Update.
2449         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2450         Update.
2451         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2452         (objfpy_lookup_objfile_by_build_id): Update.
2453         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2454         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2455         Update.
2456         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2457         (expand_symtab_containing_pc, lookup_objfile_from_block)
2458         (lookup_static_symbol, basic_lookup_transparent_type)
2459         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2460         (find_line_symtab, info_sources_command)
2461         (default_collect_symbol_completion_matches_break_on)
2462         (make_source_files_completion_list, find_main_name): Update.
2463         * symmisc.c (print_symbol_bcache_statistics)
2464         (print_objfile_statistics, maintenance_print_symbols)
2465         (maintenance_print_msymbols, maintenance_print_objfiles)
2466         (maintenance_info_symtabs, maintenance_check_symtabs)
2467         (maintenance_expand_symtabs, maintenance_info_line_tables):
2468         Update.
2469         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2470         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2471         (map_overlay_command, unmap_overlay_command)
2472         (simple_overlay_update, expand_symtabs_matching)
2473         (map_symbol_filenames): Update.
2474         * symfile-debug.c (set_debug_symfile): Update.
2475         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2476         Update.
2477         * source.c (select_source_symtab, forget_cached_source_info):
2478         Update.
2479         * solib.c (solib_read_symbols): Update.
2480         * solib-spu.c (append_ocl_sos): Update.
2481         * psymtab.c (maintenance_print_psymbols)
2482         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2483         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2484         * printcmd.c (info_symbol_command): Update.
2485         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2486         Update.
2487         * objfiles.h (class all_objfiles): Remove.
2488         * objfiles.c (have_partial_symbols, have_full_symbols)
2489         (have_minimal_symbols, qsort_cmp, update_section_map)
2490         (shared_objfile_contains_address_p)
2491         (default_iterate_over_objfiles_in_search_order): Update.
2492         * objc-lang.c (info_selectors_command, info_classes_command)
2493         (find_methods): Update.
2494         * minsyms.c (find_solib_trampoline_target): Update.
2495         * maint.c (maintenance_info_sections)
2496         (maintenance_translate_address, count_symtabs_and_blocks):
2497         Update.
2498         * main.c (captured_main_1): Update.
2499         * linux-thread-db.c (try_thread_db_load_from_pdir)
2500         (has_libpthread): Update.
2501         * linespec.c (iterate_over_all_matching_symtabs)
2502         (search_minsyms_for_name): Update.
2503         * jit.c (jit_find_objf_with_entry_addr): Update.
2504         * hppa-tdep.c (find_unwind_entry)
2505         (hppa_lookup_stub_minimal_symbol): Update.
2506         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2507         Update.
2508         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2509         (elf_gnu_ifunc_resolve_by_got): Update.
2510         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2511         * dwarf-index-write.c (save_gdb_index_command): Update.
2512         * cp-support.c (add_symbol_overload_list_qualified): Update.
2513         * breakpoint.c (create_overlay_event_breakpoint)
2514         (create_longjmp_master_breakpoint)
2515         (create_std_terminate_master_breakpoint)
2516         (create_exception_master_breakpoint): Update.
2517         * blockframe.c (find_pc_partial_function): Update.
2518         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2519         (ada_collect_symbol_completion_matches)
2520         (ada_add_global_exceptions): Update.
2521
2522 2019-01-17  Tom Tromey  <tom@tromey.com>
2523
2524         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2525         declare VEC.
2526         (solib_target_parse_libraries): Change return type.
2527         (library_list_start_segment, library_list_start_section)
2528         (library_list_end_library, library_list_start_library); Update.
2529         (solib_target_free_library_list): Remove.
2530         (solib_target_parse_libraries): Remove cleanup.  Change return
2531         type.
2532         (solib_target_current_sos): Update.
2533
2534 2019-01-17  Tom Tromey  <tromey@bapiya>
2535
2536         * valprint.c: Replace "the the" with "the".
2537         * symtab.c: Replace "the the" with "the".
2538         * solib.c: Replace "the the" with "the".
2539         * solib-dsbt.c: Replace "the the" with "the".
2540         * linespec.c: Replace "the the" with "the".
2541         * dwarf2loc.h: Replace "the the" with "the".
2542         * amd64-windows-tdep.c: Replace "the the" with "the".
2543         * aarch64-tdep.c: Replace "the the" with "the".
2544
2545 2019-01-16  Keith Seitz  <keiths@redhat.com>
2546
2547         PR gdb/23773
2548         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2549         <builder>: Rename to ..
2550         <m_builder>: ... this and make private.
2551         (dwarf2_cu::get_builder): New method.  Change all users of
2552         `builder' to use this method.
2553         (dwarf2_start_symtab): Move to ...
2554         (dwarf2_cu::start_symtab): ... here.  Update all callers
2555         (setup_type_unit_groups): Move to ...
2556         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2557         callers.
2558         (dwarf2_cu::reset_builder): New method.
2559         (process_full_compunit, process_full_type_unit): Use
2560         dwarf2_cu::reset_builder.
2561         (follow_die_offset): Record the ancestor CU if it is different
2562         from the followed DIE's CU.
2563         (follow_die_sig_1): Likewise.
2564
2565 2019-01-15  Tom Tromey  <tom@tromey.com>
2566
2567         * remote.c (class remote_state) <buf>: Now a char_vector.
2568         <buf_size>: Remove.
2569         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2570         parameter.
2571         (remote_target::getpkt_or_notif_sane_1)
2572         (remote_target::getpkt_sane)
2573         (remote_target::getpkt_or_notif_sane): Likewise.
2574         (class remote_target) <putpkt>: New overload.
2575         (remote_target::read_frame): Change type of "buf_p".  Remove
2576         sizeof_p parameter.
2577         (packet_ok): New overload.
2578         (packet_check_result): New overload.
2579         Update all uses.
2580
2581 2019-01-14  Tom Tromey  <tom@tromey.com>
2582
2583         * remote-notif.c (handle_notification, remote_notif_ack)
2584         (remote_notif_parse): Make "buf" const.
2585         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2586         const.
2587         (remote_notif_parse, remote_notif_ack, handle_notification):
2588         Likewise.
2589         * remote.c (remote_notif_stop_parse): Make "buf" const.
2590         (remote_target::remote_parse_stop_reply): Make "buf" const.
2591         (remote_notif_stop_ack): Make "buf" const.
2592
2593 2019-01-14  Tom Tromey  <tom@tromey.com>
2594
2595         * remote.c (remote_console_output): Make parameter const.
2596
2597 2019-01-14  Tom Tromey  <tom@tromey.com>
2598
2599         * target-debug.h (target_debug_print_signals): Constify.
2600         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2601         * procfs.c (procfs_target::pass_signals): Update.
2602         * linux-nat.c (linux_nat_target::pass_signals): Update.
2603         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2604         * target-delegates.c: Rebuild.
2605         * remote.c (remote_target::program_signals): Update.
2606         (remote_target::pass_signals): Update.
2607         * target.c (target_pass_signals): Constify argument.
2608         (target_program_signals): Likewise.
2609         * target.h (struct target_ops) <pass_signals, program_signals>:
2610         Constify argument.
2611         (target_pass_signals, target_program_signals): Constify argument.
2612
2613 2019-01-14  Tom Tromey  <tom@tromey.com>
2614
2615         PR tui/28819:
2616         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2617
2618 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2619
2620         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2621         field.
2622         * rs6000-tdep.c: Include reggroups.h.
2623         (IS_V_ALIAS_PSEUDOREG): Define.
2624         (rs6000_register_name): Return names for the "vX" aliases.
2625         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2626         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2627         aliases.  Call default_register_reggroup_p for all other
2628         pseudo-registers.
2629         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2630         New functions.
2631         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2632         Handle "vX" aliases.
2633         (v_alias_pseudo_register_collect): New function.
2634         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2635         (rs6000_gdbarch_init): Initialize "vX" aliases as
2636         pseudo-registers.  Restore registration of
2637         rs6000_pseudo_register_reggroup_p with
2638         set_tdesc_pseudo_register_reggroup_p.
2639
2640 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2641
2642         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2643         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2644         set_gdbarch_num_pseudo_regs.
2645
2646 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2647
2648         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2649         Remove arg prefixname, add do_set and do_show.
2650         Add member functions set_list and show_list.
2651         * cli/cli-style.c (class cli_style_option): Update accordingly.
2652         (style_set_list): Move to file scope.
2653         (style_show_list): Likewise.
2654         (set_style): Call help_list.
2655         (show_style): Call cmd_show_list.
2656         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2657         Update to use the new macro.
2658
2659 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2660
2661         * ada-lang.c (_initialize_ada_language): Expand the help text
2662         for the "catch exception" command.
2663
2664 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2665
2666         * symtab.c (matching_obj_sections): Initialize obj,
2667         declare it closer to its usage.
2668
2669 2019-01-10  Tom Tromey  <tom@tromey.com>
2670
2671         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2672         (basic_inf_threads_range): Remove.
2673         (inf_threads_range, inf_non_exited_threads_range)
2674         (safe_inf_threads_range): Use next_adapter.
2675
2676 2019-01-10  Keith Seitz  <keiths@redhat.com>
2677
2678         PR gdb/23712
2679         PR symtab/23010
2680         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2681         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2682
2683 2019-01-10  Keith Seitz  <keiths@redhat.com>
2684
2685         PR gdb/23712
2686         PR symtab/23010
2687         * dictionary.c (pending_to_vector): Remove.
2688         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2689         Remove _1 suffix, replacing functions of the same name.  Update
2690         all callers.
2691         (dict_create_hashed, dict_create_hashed_expandable)
2692         (dict_create_linear, dict_create_linear_expandable, dict_free)
2693         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2694         Make functions static.
2695
2696 2019-01-10  Keith Seitz  <keiths@redhat.com>
2697
2698         PR gdb/23712
2699         PR symtab/23010
2700         * dictionary.h (struct dictionary): Replace declaration with
2701         multidictionary.
2702         (dict_create_hashed, dict_create_hashed_expandable)
2703         (dict_create_linear, dict_create_linear_expandable)
2704         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2705         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2706         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2707         taking multidictionary argument.
2708         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2709         * block.h (struct block) <dict>: Change to multidictionary
2710         and rename `multidict'.
2711         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2712         symmisc.c: Update all dictionary references to multidictionary.
2713
2714 2019-01-10  Keith Seitz  <keiths@redhat.com>
2715
2716         PR gdb/23712
2717         PR symtab/23010
2718         * dictionary.c: Include unordered_map.
2719         (pending_to_vector): New function.
2720         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2721         Rewrite the non-"_1" functions to take vector instead
2722         of linked list.
2723         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2724         "new" _1 versions of the same name.
2725         (multidictionary): Define.
2726         (std::hash<enum language): New definition.
2727         (collate_pending_symbols_by_language, mdict_create_hashed)
2728         (mdict_create_hashed_expandable, mdict_create_linear)
2729         (mdict_create_linear_expandable, mdict_free)
2730         (find_language_dictionary, create_new_language_dictionary)
2731         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2732         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2733         (mdict_size, mdict_empty): New functions.
2734         * dictionary.h (mdict_iterator): Define.
2735
2736 2019-01-10  Pedro Alves  <palves@redhat.com>
2737
2738         * breakpoint.c (read_uploaded_action)
2739         (create_tracepoint_from_upload): Adjust to use
2740         gdb::unique_xmalloc_ptr.
2741         * ctf.c (ctf_write_uploaded_tp):
2742         (SET_ARRAY_FIELD): Use emplace_back.
2743         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2744         * tracefile-tfile.c (tfile_write_uploaded_tp):
2745         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2746         gdb::unique_xmalloc_ptr.
2747         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2748         at_string, cond_string, cmd_strings>: Replace char pointers
2749         with gdb::unique_xmalloc_ptr.
2750
2751 2019-01-10  Pedro Alves  <palves@redhat.com>
2752
2753         * solib-target.c (library_list_start_library): Don't xstrdup name.
2754
2755 2019-01-10  Pedro Alves  <palves@redhat.com>
2756
2757         * mdebugread.c (parse_partial_symbols): Use
2758         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2759
2760 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2761
2762         * linux-fork.c (scoped_switch_fork_info)
2763         <~scoped_switch_fork_info>: Fix incorrect variable name.
2764
2765 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2766
2767         * linux-fork.c (scoped_switch_fork_info)
2768         <scoped_switch_fork_info>: Make explicit.
2769         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2770
2771 2019-01-10  Tom Tromey  <tom@tromey.com>
2772
2773         * objfiles.h (objfile::reset_psymtabs): Update.
2774         * objfiles.c (objfile::objfile): Update.
2775         * psymtab.h (psymtab_storage::obstack): Update.
2776         (psymtab_storage::m_obstack): Use gdb::optional.
2777         (class psymtab_storage): Update comment.  Remove objfile
2778         parameter.
2779         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2780
2781 2019-01-10  Tom Tromey  <tom@tromey.com>
2782
2783         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2784         <free_psymtabs>: Now private.
2785         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2786         (allocate_psymtab): Use new method.
2787
2788 2019-01-10  Tom Tromey  <tom@tromey.com>
2789
2790         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2791         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2792         * mdebugread.c (parse_partial_symbols): Use
2793         allocate_dependencies.
2794         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2795         allocate_dependencies.
2796         (process_psymtab_comp_unit_reader)
2797         (build_type_psymtab_dependencies): Likewise.
2798         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2799
2800 2019-01-10  Tom Tromey  <tom@tromey.com>
2801
2802         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2803         PSYMBOL_SET_LANGUAGE.
2804         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2805
2806 2019-01-10  Tom Tromey  <tom@tromey.com>
2807
2808         * psymtab.h (psymtab_storage::obstack): New method.
2809         <m_obstack>: Rename from obstack; now private.
2810         * psymtab.c (psymtab_storage): Update.
2811         * dwarf2read.c (create_addrmap_from_index)
2812         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2813         Update.
2814
2815 2019-01-10  Tom Tromey  <tom@tromey.com>
2816
2817         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2818         * objfiles.h (objfile::reset_psymtabs): New method.
2819
2820 2019-01-10  Tom Tromey  <tom@tromey.com>
2821
2822         * symmisc.c (print_symbol_bcache_statistics): Update.
2823         (print_objfile_statistics): Update.
2824         * symfile.c (reread_symbols): Update.
2825         * psymtab.h (class psymtab_storage): New.
2826         * psymtab.c (psymtab_storage): New constructor.
2827         (~psymtab_storage): New destructor.
2828         (require_partial_symbols): Update.
2829         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2830         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2831         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2832         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2833         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2834         (start_psymtab_common, end_psymtab_common)
2835         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2836         (allocate_psymtab): Update.
2837         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2838         Update.
2839         (dump_psymtab_addrmap, maintenance_print_psymbols)
2840         (maintenance_check_psymtabs): Update.
2841         (class objfile_psymtabs): Move to objfiles.h.
2842         * psympriv.h (discard_psymtab): Now inline.
2843         (psymtab_discarder::psymtab_discarder): Update.
2844         (psymtab_discarder::~psymtab_discarder): Update.
2845         (ALL_OBJFILE_PSYMTABS): Rewrite.
2846         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2847         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2848         Remove fields.
2849         <partial_symtabs>: New field.
2850         (class objfile_psymtabs): Move from psymtab.h.  Update.
2851         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2852         psymbol_cache.
2853         (objfile::~objfile): Don't destroy psymbol_cache.
2854         * mdebugread.c (parse_partial_symbols): Update.
2855         * dwarf2read.c (create_addrmap_from_index)
2856         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2857         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2858         (add_partial_subprogram, dwarf2_ranges_read): Update.
2859         * dwarf-index-write.c (write_address_map)
2860         (write_one_signatured_type, recursively_write_psymbols)
2861         (class debug_names, class debug_names, write_psymtabs_to_index):
2862         Update.
2863
2864 2019-01-10  Tom Tromey  <tom@tromey.com>
2865
2866         * symtab.h (SYMBOL_SET_NAMES): Update.
2867         (symbol_set_names): Update.
2868         (MSYMBOL_SET_NAMES): Update.
2869         * symtab.c (symbol_set_names): Change argument to be an
2870         objfile_per_bfd_storage.
2871         * psymtab.c (add_psymbol_to_bcache): Update.
2872         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2873
2874 2019-01-10  Tom Tromey  <tom@tromey.com>
2875
2876         * symtab.c (create_demangled_names_hash): Change argument to be an
2877         objfile_per_bfd_storage.
2878         (symbol_set_names): Update.
2879
2880 2019-01-10  Tom Tromey  <tom@tromey.com>
2881
2882         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2883         init_psymbol_list.
2884         * psymtab.c (init_psymbol_list): Do nothing if already called.
2885         * psympriv.h (init_psymbol_list): Add comment.
2886         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2887         init_psymbol_list.
2888         * dbxread.c (dbx_symfile_read): Unconditionally call
2889         init_psymbol_list.
2890
2891 2019-01-10  Tom Tromey  <tom@tromey.com>
2892
2893         * xcoffread.c (scan_xcoff_symtab): Update.
2894         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2895         "where".
2896         * mdebugread.c (parse_partial_symbols)
2897         (handle_psymbol_enumerators): Update.
2898         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2899         * dbxread.c (read_dbx_symtab): Update.
2900         * psympriv.h (psymbol_placement): New enum.
2901         (add_psymbol_to_list): Update.
2902
2903 2019-01-10  Tom Tromey  <tom@tromey.com>
2904
2905         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2906         static_psymbols parameters.
2907         (scan_xcoff_symtab): Update.
2908         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2909         static_psymbols parameters.
2910         * psympriv.h (start_psymtab_common): Update.
2911         * mdebugread.c (parse_partial_symbols): Update.
2912         * dwarf2read.c (create_partial_symtab): Update.
2913         * dbxread.c (read_dbx_symtab): Update.
2914         (start_psymtab): Remove global_psymbols and static_psymbols
2915         parameters.
2916
2917 2019-01-10  Tom Tromey  <tom@tromey.com>
2918
2919         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2920         * psymtab.c (allocate_psymtab): Add comment.
2921         * psympriv.h (allocate_psymtab): Add comment.
2922         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2923         initializations.
2924         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2925
2926 2019-01-10  Tom Tromey  <tom@tromey.com>
2927
2928         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2929         Don't declare.
2930         * mipsread.c: Include mdebugread.h.
2931         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2932         Declare.
2933         * elfread.c: Include mdebugread.h.
2934
2935 2019-01-09  Tom Tromey  <tom@tromey.com>
2936
2937         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2938         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2939         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2940         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2941         (psym_lookup_symbol, psym_find_last_source_symtab)
2942         (psym_forget_cached_source_info, psym_print_stats)
2943         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2944         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2945         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2946         (psym_find_compunit_symtab_by_address)
2947         (maintenance_print_psymbols, maintenance_info_psymtabs)
2948         (maintenance_check_psymtabs): Use ranged for.
2949         * psymtab.h (class objfile_psymtabs): New.
2950         (require_partial_symbols): Return objfile_psymtabs.
2951         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2952
2953 2019-01-09  Tom Tromey  <tom@tromey.com>
2954
2955         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2956         (find_pc_mapped_section, list_overlays_command)
2957         (map_overlay_command, unmap_overlay_command)
2958         (simple_overlay_update): Use all_objfiles.
2959         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2960         * printcmd.c (info_symbol_command): Use all_objfiles.
2961         * objfiles.h (ALL_OBJSECTIONS): Remove.
2962         * maint.c (maintenance_translate_address): Use all_objfiles.
2963         * gcore.c (gcore_create_callback): Use all_objfiles.
2964         (objfile_find_memory_regions): Likewise.
2965
2966 2019-01-09  Tom Tromey  <tom@tromey.com>
2967
2968         * symtab.c (find_line_symtab, info_sources_command)
2969         (make_source_files_completion_list): Use objfile_compunits.
2970         * source.c (select_source_symtab): Use objfile_compunits.
2971         * objfiles.h (struct objfile): Update comment.
2972         (ALL_OBJFILES): Remove.
2973         (ALL_FILETABS): Remove.
2974         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2975         objfile_compunits.
2976
2977 2019-01-09  Tom Tromey  <tom@tromey.com>
2978
2979         * symmisc.c (print_objfile_statistics, dump_objfile)
2980         (maintenance_print_symbols): Use compunit_filetabs.
2981         * source.c (forget_cached_source_info_for_objfile): Use
2982         compunit_filetabs.
2983         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2984         (ALL_FILETABS): Use compunit_filetabs.
2985         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2986         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2987
2988 2019-01-09  Tom Tromey  <tom@tromey.com>
2989
2990         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2991         (compunit_filetabs): New.
2992         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2993         compunit_filetabs.
2994         (info_sources_command, make_source_files_completion_list): Remove
2995         declaration.
2996         * symmisc.c (print_objfile_statistics, dump_objfile)
2997         (maintenance_print_symbols): Remove declaration.
2998         (maintenance_info_symtabs): Use compunit_filetabs.
2999         (maintenance_info_line_tables): Likewise.
3000         * source.c (select_source_symtab): Change local variable name.
3001         (forget_cached_source_info_for_objfile): Remove declaration.
3002         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3003         * objfiles.c (objfile_relocate1): Remove declaration.
3004         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3005         declaration.
3006         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3007         * coffread.c (coff_symtab_read): Remove declaration.
3008         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3009         compunit_filetabs.
3010
3011 2019-01-09  Tom Tromey  <tom@tromey.com>
3012
3013         * symtab.c (lookup_objfile_from_block)
3014         (find_pc_sect_compunit_symtab, search_symbols)
3015         (default_collect_symbol_completion_matches_break_on): Use
3016         objfile_compunits.
3017         * objfiles.h (ALL_COMPUNITS): Remove.
3018         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3019         * cp-support.c (add_symbol_overload_list_qualified): Use
3020         objfile_compunits.
3021         * ada-lang.c (ada_collect_symbol_completion_matches)
3022         (ada_add_global_exceptions): Use objfile_compunits.
3023
3024 2019-01-09  Tom Tromey  <tom@tromey.com>
3025
3026         * source.c (select_source_symtab)
3027         (forget_cached_source_info_for_objfile): Remove declaration.
3028         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3029         declaration.
3030         * maint.c (count_symtabs_and_blocks): Remove declaration.
3031         * cp-support.c (add_symbol_overload_list_qualified): Remove
3032         declaration.
3033         * coffread.c (coff_symtab_read): Remove declaration.
3034         * symtab.c (lookup_symbol_in_objfile_symtabs)
3035         (basic_lookup_transparent_type_1): Use objfile_compunits.
3036         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3037         (info_sources_command, search_symbols)
3038         (default_collect_symbol_completion_matches_break_on)
3039         (make_source_files_completion_list): Remove declaration.
3040         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3041         (ada_collect_symbol_completion_matches)
3042         (ada_add_global_exceptions): Remove declaration.
3043         * linespec.c (iterate_over_all_matching_symtabs): Use
3044         objfile_compunits.
3045         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3046         (class objfile_compunits): New.
3047         (ALL_COMPUNITS): Use objfile_compunits.
3048         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3049         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3050         objfile_compunits.
3051         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3052
3053 2019-01-09  Tom Tromey  <tom@tromey.com>
3054
3055         * symtab.c (search_symbols)
3056         (default_collect_symbol_completion_matches_break_on): Use
3057         objfile_msymbols.
3058         * ada-lang.c (ada_lookup_simple_minsym)
3059         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3060         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3061         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3062         objfile_msymbols.
3063         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3064         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3065         * objc-lang.c (find_methods): Use objfile_msymbols.
3066         (info_selectors_command, info_classes_command): Likewise.
3067         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3068         * objfiles.h (class objfile_msymbols): New.
3069         (ALL_OBJFILE_MSYMBOLS): Remove.
3070         (ALL_MSYMBOLS): Remove.
3071
3072 2019-01-09  Tom Tromey  <tom@tromey.com>
3073
3074         * common/next-iterator.h (next_adapter): Add Iterator template
3075         parameter.
3076         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3077         (class all_objfiles_safe): New.
3078         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3079         * objfiles.c (put_objfile_before): Update comment.
3080         (add_separate_debug_objfile): Likewise.
3081         (free_all_objfiles): Use all_objfiles_safe.
3082         (objfile_purge_solibs): Likewise.
3083
3084 2019-01-09  Tom Tromey  <tom@tromey.com>
3085
3086         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3087         (expand_symtab_containing_pc, lookup_static_symbol)
3088         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3089         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3090         all_objfiles.
3091         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3092         * breakpoint.c (create_overlay_event_breakpoint)
3093         (create_longjmp_master_breakpoint)
3094         (create_std_terminate_master_breakpoint)
3095         (create_exception_master_breakpoint): Use all_objfiles.
3096         * linux-thread-db.c (try_thread_db_load_from_pdir)
3097         (has_libpthread): Use all_objfiles.
3098         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3099         * linespec.c (iterate_over_all_matching_symtabs)
3100         (search_minsyms_for_name): Use all_objfiles.
3101         * maint.c (maintenance_info_sections): Use all_objfiles.
3102         * main.c (captured_main_1): Use all_objfiles.
3103         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3104         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3105         * guile/scm-pretty-print.c
3106         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3107         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3108         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3109         (maintenance_print_msymbols): Use all_objfiles.
3110         * source.c (select_source_symtab): Use all_objfiles.
3111         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3112         * symfile.c (remove_symbol_file_command)
3113         (expand_symtabs_matching, map_symbol_filenames): Use
3114         all_objfiles.
3115         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3116         all_objfiles.
3117         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3118         * objc-lang.c (find_methods): Use all_objfiles.
3119         * objfiles.c (have_partial_symbols, have_full_symbols)
3120         (have_minimal_symbols, qsort_cmp)
3121         (default_iterate_over_objfiles_in_search_order): Use
3122         all_objfiles.
3123         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3124         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3125         (maintenance_check_psymtabs): Use all_objfiles.
3126         (ALL_PSYMTABS): Remove.
3127         * compile/compile-object-run.c (do_module_cleanup): Use
3128         all_objfiles.
3129         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3130         * cp-support.c (add_symbol_overload_list_qualified): Use
3131         all_objfiles.
3132         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3133         Use all_objfiles.
3134         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3135         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3136         all_objfiles.
3137         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3138         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3139         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3140         Uses all_objfiles.
3141         * solib.c (solib_read_symbols): Use all_objfiles
3142
3143 2019-01-09  Tom Tromey  <tom@tromey.com>
3144
3145         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3146         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3147         all_objfiles.
3148         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3149         * symmisc.c (print_symbol_bcache_statistics)
3150         (print_objfile_statistics, maintenance_print_objfiles)
3151         (maintenance_info_symtabs, maintenance_check_symtabs)
3152         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3153         all_objfiles.
3154         * source.c (forget_cached_source_info): Use all_objfiles.
3155         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3156         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3157         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3158         * objfiles.c (update_section_map): Use all_objfiles.
3159         (shared_objfile_contains_address_p): Likewise.
3160         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3161         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3162
3163 2019-01-09  Tom Tromey  <tom@tromey.com>
3164
3165         * common/next-iterator.h: New file.
3166         * objfiles.h (class all_objfiles): New.
3167         (struct objfile_iterator): New.
3168
3169 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3170
3171         * NEWS: Move the description of the changed "frame", "select-frame",
3172          and "info frame" commands to the Changed commands section.
3173
3174 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3175
3176         * gdbtypes.c (check_stub_method_group): Remove handling of old
3177         mangling schemes.
3178         * linespec.c (find_methods): Likewise.
3179         * stabsread.c (read_member_functions): Likewise.
3180         * valops.c (search_struct_method): Likewise.
3181         (value_struct_elt_for_reference): Likewise.
3182         * NEWS: Mention this change.
3183
3184 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3185
3186         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3187         print_source_lines.
3188         * source.c (print_source_lines_base): Update line number check.
3189         (print_source_lines): New function.
3190         (source_lines_range::source_lines_range): New function.
3191         * source.h (class source_lines_range): New class.
3192         (print_source_lines): New declaration.
3193
3194 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3195
3196         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3197
3198 2019-01-08  Tom Tromey  <tom@tromey.com>
3199             Simon Marchi  <simon.marchi@ericsson.com>
3200
3201         PR gdb/24060
3202         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3203         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3204         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3205         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3206         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3207         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3208
3209 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3210
3211         * source.c (select_source_symtab): Move header comment to
3212         declaration in source.h.
3213         (forget_cached_source_info_for_objfile): Likewise.
3214         (forget_cached_source_info): Likewise.
3215         (identify_source_line): Likewise.
3216         * source.h (identify_source_line): Move declaration from symtab.h
3217         and add comment from source.c
3218         (print_source_lines): Likewise.
3219         (forget_cached_source_info_for_objfile): Likewise.
3220         (forget_cached_source_info): Likewise.
3221         (select_source_symtab): Likewise.
3222         (enum print_source_lines_flag): Move definition from symtab.h.
3223         * symtab.h (identify_source_line): Move declaration to source.h.
3224         (print_source_lines): Likewise.
3225         (forget_cached_source_info_for_objfile): Likewise.
3226         (forget_cached_source_info): Likewise.
3227         (select_source_symtab): Likewise.
3228         (enum print_source_lines_flag): Move definition to source.h.
3229         * tui/tui-hooks.c: Add 'source.h' include.
3230
3231 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3232
3233         * source.c (print_source_lines_base): Handle requests to print
3234         reverse line number sequences, and guard against empty lines
3235         string.
3236
3237 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3238
3239         * source.c (print_source_lines_base): Fix skip of '\r' if next
3240         character is '\n'.
3241
3242 2019-01-06  Tom Tromey  <tom@tromey.com>
3243
3244         * c-exp.y (struct c_parse_state) <macro_original_text,
3245         expansion_obstack>: New member.
3246         (macro_original_text, expansion_obstack): Remove globals.
3247         (scan_macro_expansion, scanning_macro_expansion)
3248         (finished_macro_expansion): Update.
3249         (scan_macro_cleanup): Remove.
3250         (yylex, c_parse): Update.
3251
3252 2019-01-06  Tom Tromey  <tom@tromey.com>
3253
3254         * c-exp.y (struct c_parse_state) <strings>: New member.
3255         (operator_stoken): Update.
3256
3257 2019-01-06  Tom Tromey  <tom@tromey.com>
3258
3259         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3260         (union type_stack_elt) <typelist_val>: Now a pointer to
3261         std::vector.
3262         (type_stack_cleanup): Don't declare.
3263         (push_typelist): Update.
3264         * parse.c (pop_typelist): Return a std::vector.
3265         (push_typelist): Take a std::vector.
3266         (follow_types): Update.  Do not free args.
3267         (type_stack_cleanup): Remove.
3268         * c-exp.y (struct c_parse_state): New.
3269         (cpstate): New global.
3270         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3271         (nonempty_typelist): Update.
3272         (func_mod): Create a new vector.
3273         (c_parse): Create a c_parse_state.
3274         (check_parameter_typelist): Do not delete params.
3275         (function_method): Update.  Do not delete type_list.
3276
3277 2019-01-06  Tom Tromey  <tom@tromey.com>
3278
3279         PR gdb/28155:
3280         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3281         check_typedef.
3282         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3283         (print_return_value): Likewise.
3284
3285 2019-01-05  Tom Tromey  <tom@tromey.com>
3286
3287         * contrib/cleanup_check.py: Remove.
3288         * contrib/gcc-with-excheck: Remove.
3289         * contrib/exsummary.py: Remove.
3290         * contrib/excheck.py: Remove.
3291
3292 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3293
3294         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3295         NULL. Initialize tpprev to NULL instead of assigning it
3296         to NULL on the next statement.
3297         * windows-nat.c (windows_delete_thread): Remove check for
3298         main_thread_id before printing thread exit notifications.
3299         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3300         Remove thread ID check against main_thread_id.
3301         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3302         windows_delete_thread.
3303         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3304
3305 2019-01-04  Tom Tromey  <tom@tromey.com>
3306
3307         * compile/compile.c (_initialize_compile): Use upper case for
3308         metasyntactic variables.
3309         * symmisc.c (_initialize_symmisc): Use upper case for
3310         metasyntactic variables.
3311         * psymtab.c (_initialize_psymtab): Use upper case for
3312         metasyntactic variables.
3313         * demangle.c (demangle_command): Use upper case for metasyntactic
3314         variables.
3315         (_initialize_demangler): Likewise.
3316         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3317         variables.
3318
3319 2019-01-03  Tom Tromey  <tom@tromey.com>
3320
3321         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3322
3323 2019-01-03  Tom Tromey  <tom@tromey.com>
3324
3325         * python/py-symtab.c (salpy_str): Update.
3326         (struct salpy_sal_object) <symtab>: Now a PyObject.
3327         (salpy_dealloc): Update.
3328         (del_objfile_sal): Use gdbpy_ref.
3329
3330 2019-01-03  Tom Tromey  <tom@tromey.com>
3331
3332         * python/py-type.c (convert_field): Use new_reference.  Return
3333         gdbpy_ref.
3334         (make_fielditem): Return gdbpy_ref.
3335         (typy_fields): Update.
3336         (typy_getitem): Update.
3337         (field_name): Return gdbpy_ref.  Use new_reference.
3338         (typy_iterator_iternext): Update.
3339
3340 2019-01-03  Tom Tromey  <tom@tromey.com>
3341
3342         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3343
3344 2019-01-03  Tom Tromey  <tom@tromey.com>
3345
3346         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3347         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3348         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3349         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3350         (pspy_set_type_printers): Likewise.
3351         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3352         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3353         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3354         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3355         (objfpy_set_type_printers): Likewise.
3356
3357 2019-01-03  Tom Tromey  <tom@tromey.com>
3358
3359         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3360         (gdbpy_print_stack): Use gdbpy_err_fetch.
3361         * python/python-internal.h (class gdbpy_err_fetch): New class.
3362         (class gdbpy_enter) <m_error_type, m_error_value,
3363         m_error_traceback>: Remove.
3364         <m_error>: New member.
3365         (gdbpy_exception_to_string): Don't declare.
3366         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3367         * python/py-value.c (convert_value_from_python): Use
3368         gdbpy_err_fetch.
3369         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3370         gdbpy_exception_to_string.
3371         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3372         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3373         gdbpy_err_fetch.
3374
3375 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3376
3377         * linux-nat.c (delete_lwp_cleanup): Delete.
3378         (struct lwp_deleter): New struct.
3379         (lwp_info_up): New typedef.
3380         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3381         lwp_info_up.
3382
3383 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3384
3385         * linux-fork.c (class scoped_switch_fork_info): New class.
3386         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3387
3388 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3389
3390         * valops.c (find_overload_match): Remove use of null_cleanup, and
3391         calls to do_cleanups.
3392
3393 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3394
3395         * compile/compile-cplus-types.c
3396         (compile_cplus_instance::decl_name): Handle changes to
3397         cp_func_name.
3398         * cp-support.c (cp_func_name): Update header comment, update
3399         return type.
3400         * cp-support.h (cp_func_name): Update return type in declaration.
3401         * valops.c (find_overload_match): Move temp_func local to top
3402         level of function and change its type.  Use temp_func to hold and
3403         delete temporary string obtained from cp_func_name.
3404
3405 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3406
3407         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3408         gdb::char_vector, remove cleanup, and update uses of `msg`.
3409
3410 2019-01-03  Jim Wilson  <jimw@sifive.com>
3411
3412         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3413
3414 2019-01-02  Tom Tromey  <tom@tromey.com>
3415
3416         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3417         (tdesc_parse_xml): Remove cleanups.
3418         * target-descriptions.h (make_cleanup_free_target_description):
3419         Don't declare.
3420         (target_desc_deleter): New struct.
3421         (target_desc_up): New typedef.
3422         * target-descriptions.c (target_desc_deleter::operator()): Rename
3423         from free_target_description.
3424         (make_cleanup_free_target_description): Remove.
3425
3426 2019-01-02  Tom Tromey  <tom@tromey.com>
3427
3428         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3429         constructor, destructor.
3430         (linespec_parser): Remove typedef.
3431         (~linespec_parser): Rename from linespec_parser_delete.
3432         (linespec_lex_to_end, linespec_complete_label)
3433         (linespec_complete): Update.
3434         (decode_line_full): Remove cleanups.
3435         (decode_line_1): Update.
3436
3437 2019-01-02  Tom Tromey  <tom@tromey.com>
3438
3439         * python/python-internal.h (inferior_to_inferior_object): Change
3440         return type.
3441         * python/py-exitedevent.c (create_exited_event_object): Update.
3442         * python/py-inferior.c (inferior_to_inferior_object): Return
3443         gdbpy_ref.
3444         (python_new_inferior, python_inferior_deleted)
3445         (thread_to_thread_object, delete_thread_object)
3446         (build_inferior_list, gdbpy_selected_inferior): Update.
3447         * python/py-infthread.c (create_thread_object): Update.  Also fail
3448         if inferior_to_inferior_object fails.
3449
3450 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3451
3452         * inferior.h (class inferior) <displaced_step_state>: New field.
3453         * infrun.h (struct displaced_step_state): Move here from
3454         infrun.c.  Initialize fields, add constructor.
3455         <inf>: Remove field.
3456         <reset>: New method.
3457         * infrun.c (struct displaced_step_inferior_state): Move to
3458         infrun.h.
3459         (displaced_step_inferior_states): Remove.
3460         (get_displaced_stepping_state): Adust.
3461         (displaced_step_in_progress_any_inferior): Adjust.
3462         (displaced_step_in_progress_thread): Adjust.
3463         (displaced_step_in_progress): Adjust.
3464         (add_displaced_stepping_state): Remove.
3465         (get_displaced_step_closure_by_addr): Adjust.
3466         (remove_displaced_stepping_state): Remove.
3467         (infrun_inferior_exit): Call displaced_step_state.reset.
3468         (use_displaced_stepping): Don't check for NULL.
3469         (displaced_step_prepare_throw): Call
3470         get_displaced_stepping_state.
3471         (displaced_step_fixup): Don't check for NULL.
3472         (prepare_for_detach): Don't check for NULL.
3473
3474 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3475
3476         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3477          in case of call that did not complete.
3478
3479 2019-01-02  Andrey Utkin  <autkin@undo.io>
3480
3481         * symfile.c (find_separate_debug_file): Fix search of debug files for
3482         remote debuggee.
3483
3484 2019-01-02  Tom Tromey  <tom@tromey.com>
3485
3486         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3487         indentation.
3488         * python/py-frame.c (frapy_older): Remove cast.
3489         (frapy_newer): Likewise.
3490         * python/py-breakpoint.c (local_setattro): Remove cast.
3491         * python/py-arch.c (archpy_name): Remove local variable.
3492         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3493
3494 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3495
3496         * unittests/basic_string_view/element_access/char/empty.cc:
3497         Fix year range in copyright header.
3498
3499 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3500
3501         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3502         Delete.
3503         <operator==>: Update with for removed field.
3504         <hash>: Likewise.
3505         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3506         <isa_features>: ...this.
3507         <abi_features>: New field.
3508         (riscv_isa_flen): Update comment.
3509         (riscv_abi_xlen): New declaration.
3510         (riscv_abi_flen): New declaration.
3511         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3512         isa_features.
3513         (riscv_abi_xlen): New function.
3514         (riscv_isa_flen): Update to get answer from isa_features.
3515         (riscv_abi_flen): New function.
3516         (riscv_has_fp_abi): Update to get answer from abi_features.
3517         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3518         xlen and flen.
3519         (riscv_call_info) <xlen, flen>: Update comment.
3520         (riscv_call_arg_struct): Remove invalid assertions
3521         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3522         is removed.
3523         (riscv_gdbarch_init): Gather isa features and abi features
3524         separately, ensure both match on the gdbarch when reusing an old
3525         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3526         a target with 64-bit float hardware.
3527
3528 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3529
3530         * source.c (search_command_helper): Stop reverse search
3531         when line 1 has been searched.
3532
3533 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3534
3535         * record-full.c (record_full_base_target::close): Rewrite
3536         record_full_core_buf_list free logic.
3537
3538 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3539
3540         * break-catch-syscall.c (print_one_catch_syscall): xfree
3541         the last text.
3542
3543 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3544
3545         * top.c (print_gdb_version): Update Copyright year in version
3546         message.
3547
3548 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3549
3550         Update copyright year range in all GDB files.
3551
3552 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3553
3554         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3555
3556 For older changes see ChangeLog-2018.
3557 \f
3558 Local Variables:
3559 mode: change-log
3560 left-margin: 8
3561 fill-column: 74
3562 version-control: never
3563 coding: utf-8
3564 End:
3565