gdb/ChangeLog

   1 2019-03-18  Pedro Alves  <palves@redhat.com>
   2
   3         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
   4         New globals.
   5         (apply_style): New, factored out from ...
   6         (apply_ansi_escape): ... this.  Handle reverse video mode.
   7         (tui_set_reverse_mode): New function.
   8         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
   9         * tui/tui-winsource.c (tui_show_source_line): Use
  10         tui_set_reverse_mode instead of setting A_STANDOUT.
  11         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
  12         New setter methods.
  13
  14 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
  15
  16         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
  17         Handle tabs.
  18
  19 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
  20
  21         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
  22         tui_refill_source_window instead of tui_refresh_win, to update the
  23         current execution line.  This fixes redisplay of the current line
  24         when stepping through the code with "next" or "step".
  25
  26 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
  27
  28         * source-cache.c (source_cache::get_source_lines): Call
  29         find_source_lines to initialize s->nlines.  This fixes vertical
  30         scrolling of TUI source window when the DOWN arrow is pressed.
  31
  32 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
  33
  34         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
  35         wclrtoeol in tui_show_source_line".  This reverts changes made in
  36         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
  37
  38 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  39
  40         * NEWS: Combine separate "New targets" sections for 8.3.
  41
  42 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
  43
  44         The MS-Windows port of ncurses fails to switch to a color pair if
  45         one or both of the colors are the implicit default colors.  This
  46         change records the default colors when TUI is initialized, and
  47         then specifies them explicitly when a color pair uses the default
  48         colors.  This allows color styling in TUI mode on MS-Windows.
  49
  50         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
  51         ncurses_norm_attr.
  52         (tui_initialize_io) [__MINGW32__]: Record the default terminal
  53         colors in ncurses_norm_attr.
  54         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
  55         "none", replace it with the default color recorded in
  56         ncurses_norm_attr.
  57
  58 2019-03-14  Tom Tromey  <tromey@adacore.com>
  59
  60         * source-cache.h (class source_cache) <get_source_lines>: Return
  61         std::string.
  62         * source-cache.c (source_cache::extract_lines): Handle case where
  63         first_pos==npos.  Return std::string.
  64         (source_cache::get_source_lines): Update.
  65
  66 2019-03-14  Tom Tromey  <tromey@adacore.com>
  67
  68         * NEWS: Add item for "style sources" commands.
  69         * source-cache.c (source_cache::get_source_lines): Check
  70         source_styling.
  71         * cli/cli-style.c (source_styling): New global.
  72         (_initialize_cli_style): Add "style sources" commands.
  73         (show_style_sources): New function.
  74         * cli/cli-style.h (source_styling): Declare.
  75
  76 2019-03-14  Pedro Alves  <palves@redhat.com>
  77             Tom Tromey  <tromey@adacore.com>
  78
  79         * tui/tui-winsource.h (tui_refill_source_window): Declare.
  80         * tui/tui-winsource.c (tui_refill_source_window): New function,
  81         from...
  82         (tui_horizontal_source_scroll): ... here.  Move some logic.
  83         * cli/cli-style.c (set_style_enabled): Notify new observable.
  84         * tui/tui-hooks.c (tui_redisplay_source): New function.
  85         (tui_attach_detach_observers): Attach or detach
  86         tui_redisplay_source.
  87         * observable.h (source_styling_changed): New observable.
  88         * observable.c: Define source_styling_changed observable.
  89
  90 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
  91
  92         PR/24325
  93         * source-cache.c: #undef open and close, to avoid unresolved
  94         externals during linking.
  95
  96 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
  97
  98         Support styling on native MS-Windows console
  99
 100         PR/24315
 101         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 102         on MS-Windows if $TERM is not defined.
 103
 104         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 105
 106         * posix-hdep.c (gdb_console_fputs):
 107         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 108         functions.
 109         * ui-file.h (gdb_console_fputs): Add prototype.
 110
 111         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 112         back to fputs only if the former returns zero.
 113
 114 2019-03-07  Brian Vandenberg  <phantall@gmail.com>
 115             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 116
 117         PR gdb/8527
 118         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
 119         set_sigint_trap, clear_sigint_trap.
 120
 121 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 122
 123         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
 124         for-loop range, to avoid compiler warnings.
 125
 126         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
 127         avoid compiler warnings about unused variables.
 128
 129 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 130
 131         * NEWS: Mention end of support for native debugging on MS-Windows
 132         before XP.
 133
 134 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 135
 136         PR gdb/24292
 137         * common/netstuff.c:
 138         * gdbserver/gdbreplay.c
 139         * gdbserver/remote-utils.c:
 140         * ser-tcp.c:
 141         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
 142         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
 143         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
 144         'getaddrinfo' and 'freeaddrinfo' were not available before
 145         Windows XP, and mingw.org's MinGW headers by default define
 146         _WIN32_WINNT to 0x500.
 147
 148 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 149
 150         * NEWS: Note minimum Python version.
 151
 152 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 153
 154         * version.in: Set GDB version number to 8.2.90.DATE-git.
 155
 156 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 157
 158         GDB 8.2.90 released.
 159
 160 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 161
 162         * version.in: Set GDB version number to 8.2.90.
 163
 164 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 165
 166         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
 167
 168 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 169
 170         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
 171         * version.in: Bump version to 8.2.90.DATE-git.
 172
 173 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
 174
 175         * aix-thread.c (ptid_cmp): Remove unused variable.
 176         (get_signaled_thread): Likewise.
 177         (store_regs_user_thread): Likewise.
 178         (store_regs_kernel_thread): Likewise.
 179         (fetch_regs_kernel_thread): Remove shadowed variable.
 180
 181 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 182
 183         * features/riscv/32bit-cpu.xml: Add register numbers.
 184         * features/riscv/32bit-fpu.c: Regenerate.
 185         * features/riscv/32bit-fpu.xml: Add register numbers.
 186         * features/riscv/64bit-cpu.xml: Add register numbers.
 187         * features/riscv/64bit-fpu.c: Regenerate.
 188         * features/riscv/64bit-fpu.xml: Add register numbers.
 189
 190 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
 191
 192         * NEWS: Mention two argument form of gdb.Value constructor.
 193         * python/py-value.c (convert_buffer_and_type_to_value): New
 194         function.
 195         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
 196         Add support for handling an optional second argument.  Call
 197         convert_buffer_and_type_to_value as appropriate.
 198         * python/python-internal.h (Py_buffer_deleter): New struct.
 199         (Py_buffer_up): New typedef.
 200
 201 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
 202
 203         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
 204         instead of releasing ownership.
 205
 206 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
 207
 208         * dwarf2read.c (open_and_init_dwp_file): Call
 209         elf_numsections instead of bfd_count_sections to initialize
 210         dwp_file->num_sections.
 211
 212 2019-02-25  Tom Tromey  <tromey@adacore.com>
 213
 214         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
 215
 216 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 217
 218         * gcore.in: Add '--readnever' option when invoking GDB.
 219
 220 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 221
 222         * MAINTAINERS: Update my email address.
 223
 224 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 225
 226         * build-id.c (build_id_to_debug_bfd_1): New function.
 227         (build_id_to_debug_bfd): Look for separate debug file in
 228         sysroot.
 229
 230 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 231
 232         * gdbarch.sh: Update the copyright year range that is placed into
 233         generated files.
 234
 235 2019-02-22  Keith Seitz  <keiths@redhat.com>
 236
 237         PR symtab/23853
 238         * linespec.c (create_sals_line_offset): Search for the default
 239         symtab's filename instead of its fullname.
 240
 241 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 242
 243         * NEWS: Update style defaults.
 244
 245 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 246
 247         * main.c (captured_main_1): Disable styling in batch mode.
 248
 249 2019-02-20  Tom Tromey  <tom@tromey.com>
 250
 251         * symtab.c (symtab_symbol_info): Fix typos.
 252
 253 2019-02-20  Tom Tromey  <tromey@adacore.com>
 254
 255         * findcmd.c (_initialize_mem_search): Use upper case for
 256         metasyntactic variables.
 257
 258 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
 259
 260         * aarch64-tdep.c (aarch64_add_reggroups): New function.
 261         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
 262
 263 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
 264
 265         * top.h (source_file_name): Change to std::string.
 266         * top.c (source_file_name): Likewise.
 267         (command_line_input): Adjust.
 268         * cli/cli-script.c (script_from_file): Adjust.
 269
 270 2019-02-19  Tom Tromey  <tromey@adacore.com>
 271
 272         * ravenscar-thread.c
 273         (ravenscar_thread_target::update_thread_list): Don't call
 274         ada_build_task_list.
 275         * ada-lang.h (ada_build_task_list): Don't declare.
 276         * ada-tasks.c (struct ada_tasks_inferior_data)
 277         <task_list_valid_p>: Now bool.
 278         (read_known_tasks, ada_task_list_changed)
 279         (ada_tasks_invalidate_inferior_data): Update.
 280         (read_known_tasks_array): Return bool.
 281         (read_known_tasks_list): Likewise.
 282         (read_known_tasks): Return void.
 283         (ada_build_task_list): Now static.
 284
 285 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 286
 287         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
 288         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
 289
 290 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 291
 292         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
 293         variant for ada_tasks_pspace_data_handle and
 294         ada_tasks_inferior_data_handle.
 295         (ada_tasks_pspace_data_cleanup): New function.
 296         (ada_tasks_inferior_data_cleanup): New function.
 297
 298 2019-02-17  Tom Tromey  <tom@tromey.com>
 299
 300         * macrotab.h (macro_source_fullname): Return a std::string.
 301         * macrotab.c (macro_include, check_for_redefinition)
 302         (macro_undef, macro_lookup_definition, foreach_macro)
 303         (foreach_macro_in_scope): Update.
 304         (macro_source_fullname): Return a std::string.
 305         * macrocmd.c (show_pp_source_pos): Update.
 306
 307 2019-02-17  Tom Tromey  <tom@tromey.com>
 308
 309         * macrocmd.c (show_pp_source_pos): Style the file names.
 310
 311 2019-02-17  Tom Tromey  <tom@tromey.com>
 312
 313         PR tui/24197:
 314         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 315
 316 2019-02-17  Tom Tromey  <tom@tromey.com>
 317
 318         * ada-lang.c (user_select_syms): Use filtered printing.
 319         * utils.c (wrap_style): New global.
 320         (desired_style): Remove.
 321         (emit_style_escape): Add stream parameter.
 322         (set_output_style, reset_terminal_style, prompt_for_continue):
 323         Update.
 324         (flush_wrap_buffer): Only flush gdb_stdout.
 325         (wrap_here): Set wrap_style.
 326         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 327         treat escape sequences as a character.  Change when wrap buffer is
 328         flushed.
 329         (fputs_styled): Do not set the output style when the default is
 330         requested.
 331         * ui-style.h (struct ui_file_style) <is_default>: New method.
 332         * source.c (print_source_lines_base): Emit escape sequences in one
 333         piece.
 334
 335 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 336
 337         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 338         integers and enumeration types.
 339
 340 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 341
 342         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 343         instead of lookup_symbol_in_language
 344         (do_exact_match): New function.
 345         (ada_get_symbol_name_matcher): Return do_exact_match when
 346         doing a verbatim match.
 347
 348 2019-02-15  Tom Tromey  <tromey@adacore.com>
 349
 350         * ravenscar-thread.c (ravenscar_thread_target::resume)
 351         (ravenscar_thread_target::wait): Special case wildcard requests.
 352
 353 2019-02-15  Tom Tromey  <tromey@adacore.com>
 354
 355         * ravenscar-thread.c (base_ptid): Remove.
 356         (struct ravenscar_thread_target) <close>: New method.
 357         <m_base_ptid>: New member.
 358         <update_inferior_ptid, active_task, task_is_currently_active,
 359         runtime_initialized>: Declare methods.
 360         <ravenscar_thread_target>: Add constructor.
 361         (ravenscar_thread_target::task_is_currently_active)
 362         (ravenscar_thread_target::update_inferior_ptid)
 363         (ravenscar_runtime_initialized): Rename.  Now methods.
 364         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 365         (ravenscar_thread_target::update_thread_list): Update.
 366         (ravenscar_thread_target::active_task): Now method.
 367         (ravenscar_thread_target::store_registers)
 368         (ravenscar_thread_target::prepare_to_store)
 369         (ravenscar_thread_target::prepare_to_store)
 370         (ravenscar_thread_target::mourn_inferior): Update.
 371         (ravenscar_inferior_created): Use "new" to create target.
 372         (ravenscar_thread_target::get_ada_task_ptid): Update.
 373         (_initialize_ravenscar): Don't initialize base_ptid.
 374         (ravenscar_ops): Remove global.
 375
 376 2019-02-15  Tom Tromey  <tromey@adacore.com>
 377
 378         * target.h (push_target): Declare new overload.
 379         * target.c (push_target): New overload, taking an rvalue reference.
 380         * remote.c (remote_target::open_1): Use push_target overload.
 381         * corelow.c (core_target_open): Use push_target overload.
 382
 383 2019-02-15  Tom Tromey  <tromey@adacore.com>
 384
 385         * ravenscar-thread.c (is_ravenscar_task)
 386         (ravenscar_task_is_currently_active): Return bool.
 387         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 388         (_initialize_ravenscar): Remove "(void)".
 389         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 390         Return bool.
 391
 392 2019-02-15  Tom Tromey  <tromey@adacore.com>
 393
 394         * ravenscar-thread.c (ravenscar_runtime_initializer)
 395         (has_ravenscar_runtime, get_running_thread_id)
 396         (ravenscar_thread_target::resume): Fix indentation.
 397
 398 2019-02-15  Tom Tromey  <tromey@adacore.com>
 399
 400         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 401         from ravenscar_arch_ops.
 402         (sparc_ravenscar_ops::fetch_registers)
 403         (sparc_ravenscar_ops::store_registers): Now methods.
 404         (sparc_ravenscar_prepare_to_store): Remove.
 405         (sparc_ravenscar_ops): Redefine.
 406         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 407         methods and destructor.  Remove members.
 408         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 409         (ravenscar_thread_target::store_registers)
 410         (ravenscar_thread_target::prepare_to_store): Update.
 411         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 412         Remove.
 413         (struct ppc_ravenscar_powerpc_ops): Derive from
 414         ravenscar_arch_ops.
 415         (ppc_ravenscar_powerpc_ops::fetch_registers)
 416         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 417         (ppc_ravenscar_powerpc_ops): Redefine.
 418         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 419         (ppc_ravenscar_e500_ops::fetch_registers)
 420         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 421         (ppc_ravenscar_e500_ops): Redefine.
 422         * aarch64-ravenscar-thread.c
 423         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 424         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 425         (aarch64_ravenscar_fetch_registers)
 426         (aarch64_ravenscar_store_registers): Now methods.
 427         (aarch64_ravenscar_ops): Redefine.
 428
 429 2019-02-15  Tom Tromey  <tromey@adacore.com>
 430
 431         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 432         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 433         (ravenscar_thread_target::stopped_by_watchpoint)
 434         (ravenscar_thread_target::stopped_data_address)
 435         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 436
 437 2019-02-15  Tom Tromey  <tromey@adacore.com>
 438
 439         * ravenscar-thread.c: Fix some typos.
 440
 441 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 442             Tom Tromey  <tromey@adacore.com>
 443
 444         * ada-lang.c (ada_exception_sal): Change addr_string to a
 445         std::string.
 446         (create_ada_exception_catchpoint): Update.
 447
 448 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 449             Tom Tromey  <tromey@adacore.com>
 450
 451         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 452         (bp_location_ops): Remove.
 453         (base_breakpoint_allocate_location): Update.
 454         (free_bp_location): Update.
 455         * ada-lang.c (class ada_catchpoint_location)
 456         <ada_catchpoint_location>: Remove ops parameter.
 457         (ada_catchpoint_location_dtor): Remove.
 458         (ada_catchpoint_location_ops): Remove.
 459         (allocate_location_exception): Update.
 460         * breakpoint.h (struct bp_location_ops): Remove.
 461         (class bp_location) <bp_location>: Remove bp_location_ops
 462         parameter.
 463         <~bp_location>: Add destructor.
 464         <ops>: Remove.
 465
 466 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 467             Pedro Alves  <palves@redhat.com>
 468
 469         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 470         'PATH_MAX'.
 471
 472 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 473             Samuel Thibault  <samuel.thibault@gnu.org>
 474             Thomas Schwinge  <thomas@codesourcery.com>
 475
 476         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 477         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 478
 479 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 480
 481         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 482         (check_empty): Use "const char *".
 483
 484         * gnu-nat.c (gnu_nat_target::detach): Instead of
 485         'detach_inferior (pid)' call
 486         'detach_inferior (find_inferior_pid (pid))'.
 487
 488         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 489         'nat/fork-inferior.o'.
 490         * gnu-nat.c: #include "nat/fork-inferior.h".
 491
 492         * gnu-nat.c (gnu_nat_target::detach): Instead of
 493         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 494         * gnu-nat.h: #include "inf-child.h".
 495         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 496         'i386_gnu_nat_target::fetch_registers'.
 497         (gnu_store_registers): Rename/move to
 498         'i386_gnu_nat_target::store_registers'.
 499
 500         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 501         * gnu-nat.h (mach_thread_info): New function.
 502         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 503
 504         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 505
 506 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 507
 508         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 509
 510 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 511
 512         * windows-nat.c (windows_add_thread): Add new parameter
 513         "main_thread_p" with default value set to false.  Update
 514         function documentation as well as all callers.
 515         (windows_delete_thread): Likewise.
 516         (fake_create_process): Update call to windows_add_thread.
 517         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 518         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 519         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 520         call to windows_delete_thread.
 521
 522 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 523
 524         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 525
 526 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 527
 528         * symfile.c (find_separate_debug_file): Use canonical path of
 529         sysroot with child_path instead of gdb_sysroot if it is valid.
 530
 531 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 532
 533         * symfile.c (find_separate_debug_file): Use child_path to
 534         determine if an object file is under a sysroot.
 535
 536 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 537
 538         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 539         unittests/child-path-selftests.c.
 540         * common/pathstuff.c (child_path): New function.
 541         * common/pathstuff.h (child_path): New prototype.
 542         * unittests/child-path-selftests.c: New file.
 543
 544 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 545
 546         * symfile.c (find_separate_debug_file): Look for separate debug
 547         files in debug directories under the sysroot.
 548
 549 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 550
 551         * symtab.h (struct minimal_symbol data_p): New const method.
 552         (struct minimal_symbol text_p): Likewise.
 553         * symtab.c (output_source_filename): Use file name style
 554         to print file name.
 555         (print_symbol_info): Likewise.
 556         (print_msymbol_info): Use address style to print addresses.
 557         Use function name style to print executable text symbols.
 558         (expand_symtab_containing_pc): Use data_p.
 559         (find_pc_sect_compunit_symtab): Likewise.
 560
 561 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 562
 563         * breakpoint.c (describe_other_breakpoints): Use address style
 564         to print addresses.
 565         (say_where): Likewise.
 566
 567 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 568
 569         * ada-typeprint.c (print_func_type): Print function name
 570         style to print function name.
 571         * c-typeprint.c (c_print_type_1): Likewise.
 572
 573 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 574
 575         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 576         for execve.
 577
 578 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 579
 580         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 581         type_stack.
 582
 583 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 584
 585         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 586         TYPE_CODE_REF types.
 587
 588 2019-02-08  Jim Wilson  <jimw@sifive.com>
 589
 590         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 591         (riscv_linux_fregset): New.
 592         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 593
 594 2019-02-07  Tom Tromey  <tom@tromey.com>
 595
 596         * thread.c (thread_cancel_execution_command): Update.
 597         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 598         methods.
 599         (struct thread_fsm_ops): Remove.
 600         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 601         (thread_fsm_should_stop, thread_fsm_return_value)
 602         (thread_fsm_set_finished, thread_fsm_finished_p)
 603         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 604         Don't declare.
 605         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 606         * infrun.c (clear_proceed_status_thread)
 607         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 608         (print_stop_event): Update.
 609         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 610         Add constructor.
 611         (step_command_fsm_ops): Remove.
 612         (new_step_command_fsm): Remove.
 613         (step_1): Update.
 614         (step_command_fsm::should_stop): Rename from
 615         step_command_fsm_should_stop.
 616         (step_command_fsm::clean_up): Rename from
 617         step_command_fsm_clean_up.
 618         (step_command_fsm::do_async_reply_reason): Rename from
 619         step_command_fsm_async_reply_reason.
 620         (struct until_next_fsm): Inherit from thread_fsm.  Add
 621         constructor.
 622         (until_next_fsm_ops): Remove.
 623         (new_until_next_fsm): Remove.
 624         (until_next_fsm::should_stop): Rename from
 625         until_next_fsm_should_stop.
 626         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 627         (until_next_fsm::do_async_reply_reason): Rename from
 628         until_next_fsm_async_reply_reason.
 629         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 630         constructor.  Change type of breakpoint.
 631         (finish_command_fsm_ops): Remove.
 632         (new_finish_command_fsm): Remove.
 633         (finish_command_fsm::should_stop): Rename from
 634         finish_command_fsm_should_stop.
 635         (finish_command_fsm::clean_up): Rename from
 636         finish_command_fsm_clean_up.
 637         (finish_command_fsm::return_value): Rename from
 638         finish_command_fsm_return_value.
 639         (finish_command_fsm::do_async_reply_reason): Rename from
 640         finish_command_fsm_async_reply_reason.
 641         (finish_command): Update.
 642         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 643         Add constructor.
 644         (call_thread_fsm_ops): Remove.
 645         (call_thread_fsm::call_thread_fsm): Rename from
 646         new_call_thread_fsm.
 647         (call_thread_fsm::should_stop): Rename from
 648         call_thread_fsm_should_stop.
 649         (call_thread_fsm::should_notify_stop): Rename from
 650         call_thread_fsm_should_notify_stop.
 651         (run_inferior_call, call_function_by_hand_dummy): Update.
 652         * cli/cli-interp.c (should_print_stop_to_console): Update.
 653         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 654         Add constructor.  Change type of location_breakpoint,
 655         caller_breakpoint.
 656         (until_break_fsm_ops): Remove.
 657         (new_until_break_fsm): Remove.
 658         (until_break_fsm::should_stop): Rename from
 659         until_break_fsm_should_stop.
 660         (until_break_fsm::clean_up): Rename from
 661         until_break_fsm_clean_up.
 662         (until_break_fsm::do_async_reply_reason): Rename from
 663         until_break_fsm_async_reply_reason.
 664         (until_break_command): Update.
 665         * thread-fsm.c: Remove.
 666         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 667
 668 2019-02-07  Tom Tromey  <tom@tromey.com>
 669
 670         * yy-remap.h: Add include guard.
 671         * xtensa-tdep.h: Add include guard.
 672         * xcoffread.h: Rename include guard.
 673         * varobj-iter.h: Add include guard.
 674         * tui/tui.h: Rename include guard.
 675         * tui/tui-winsource.h: Rename include guard.
 676         * tui/tui-wingeneral.h: Rename include guard.
 677         * tui/tui-windata.h: Rename include guard.
 678         * tui/tui-win.h: Rename include guard.
 679         * tui/tui-stack.h: Rename include guard.
 680         * tui/tui-source.h: Rename include guard.
 681         * tui/tui-regs.h: Rename include guard.
 682         * tui/tui-out.h: Rename include guard.
 683         * tui/tui-layout.h: Rename include guard.
 684         * tui/tui-io.h: Rename include guard.
 685         * tui/tui-hooks.h: Rename include guard.
 686         * tui/tui-file.h: Rename include guard.
 687         * tui/tui-disasm.h: Rename include guard.
 688         * tui/tui-data.h: Rename include guard.
 689         * tui/tui-command.h: Rename include guard.
 690         * tic6x-tdep.h: Add include guard.
 691         * target/waitstatus.h: Rename include guard.
 692         * target/wait.h: Rename include guard.
 693         * target/target.h: Rename include guard.
 694         * target/resume.h: Rename include guard.
 695         * target-float.h: Rename include guard.
 696         * stabsread.h: Add include guard.
 697         * rs6000-tdep.h: Add include guard.
 698         * riscv-fbsd-tdep.h: Add include guard.
 699         * regformats/regdef.h: Rename include guard.
 700         * record.h: Rename include guard.
 701         * python/python.h: Rename include guard.
 702         * python/python-internal.h: Rename include guard.
 703         * python/py-stopevent.h: Rename include guard.
 704         * python/py-ref.h: Rename include guard.
 705         * python/py-record.h: Rename include guard.
 706         * python/py-record-full.h: Rename include guard.
 707         * python/py-record-btrace.h: Rename include guard.
 708         * python/py-instruction.h: Rename include guard.
 709         * python/py-events.h: Rename include guard.
 710         * python/py-event.h: Rename include guard.
 711         * procfs.h: Add include guard.
 712         * proc-utils.h: Add include guard.
 713         * p-lang.h: Add include guard.
 714         * or1k-tdep.h: Rename include guard.
 715         * observable.h: Rename include guard.
 716         * nto-tdep.h: Rename include guard.
 717         * nat/x86-linux.h: Rename include guard.
 718         * nat/x86-linux-dregs.h: Rename include guard.
 719         * nat/x86-gcc-cpuid.h: Add include guard.
 720         * nat/x86-dregs.h: Rename include guard.
 721         * nat/x86-cpuid.h: Rename include guard.
 722         * nat/ppc-linux.h: Rename include guard.
 723         * nat/mips-linux-watch.h: Rename include guard.
 724         * nat/linux-waitpid.h: Rename include guard.
 725         * nat/linux-ptrace.h: Rename include guard.
 726         * nat/linux-procfs.h: Rename include guard.
 727         * nat/linux-osdata.h: Rename include guard.
 728         * nat/linux-nat.h: Rename include guard.
 729         * nat/linux-namespaces.h: Rename include guard.
 730         * nat/linux-btrace.h: Rename include guard.
 731         * nat/glibc_thread_db.h: Rename include guard.
 732         * nat/gdb_thread_db.h: Rename include guard.
 733         * nat/gdb_ptrace.h: Rename include guard.
 734         * nat/fork-inferior.h: Rename include guard.
 735         * nat/amd64-linux-siginfo.h: Rename include guard.
 736         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 737         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 738         * nat/aarch64-linux.h: Rename include guard.
 739         * nat/aarch64-linux-hw-point.h: Rename include guard.
 740         * mn10300-tdep.h: Add include guard.
 741         * mips-linux-tdep.h: Add include guard.
 742         * mi/mi-parse.h: Rename include guard.
 743         * mi/mi-out.h: Rename include guard.
 744         * mi/mi-main.h: Rename include guard.
 745         * mi/mi-interp.h: Rename include guard.
 746         * mi/mi-getopt.h: Rename include guard.
 747         * mi/mi-console.h: Rename include guard.
 748         * mi/mi-common.h: Rename include guard.
 749         * mi/mi-cmds.h: Rename include guard.
 750         * mi/mi-cmd-break.h: Rename include guard.
 751         * m2-lang.h: Add include guard.
 752         * location.h: Rename include guard.
 753         * linux-record.h: Rename include guard.
 754         * linux-nat.h: Add include guard.
 755         * linux-fork.h: Add include guard.
 756         * i386-darwin-tdep.h: Rename include guard.
 757         * hppa-linux-offsets.h: Add include guard.
 758         * guile/guile.h: Rename include guard.
 759         * guile/guile-internal.h: Rename include guard.
 760         * gnu-nat.h: Rename include guard.
 761         * gdb-stabs.h: Rename include guard.
 762         * frv-tdep.h: Add include guard.
 763         * f-lang.h: Add include guard.
 764         * event-loop.h: Add include guard.
 765         * darwin-nat.h: Rename include guard.
 766         * cp-abi.h: Rename include guard.
 767         * config/sparc/nm-sol2.h: Rename include guard.
 768         * config/nm-nto.h: Rename include guard.
 769         * config/nm-linux.h: Add include guard.
 770         * config/i386/nm-i386gnu.h: Rename include guard.
 771         * config/djgpp/nl_types.h: Rename include guard.
 772         * config/djgpp/langinfo.h: Rename include guard.
 773         * compile/gcc-cp-plugin.h: Add include guard.
 774         * compile/gcc-c-plugin.h: Add include guard.
 775         * compile/compile.h: Rename include guard.
 776         * compile/compile-object-run.h: Rename include guard.
 777         * compile/compile-object-load.h: Rename include guard.
 778         * compile/compile-internal.h: Rename include guard.
 779         * compile/compile-cplus.h: Rename include guard.
 780         * compile/compile-c.h: Rename include guard.
 781         * common/xml-utils.h: Rename include guard.
 782         * common/x86-xstate.h: Rename include guard.
 783         * common/version.h: Rename include guard.
 784         * common/vec.h: Rename include guard.
 785         * common/tdesc.h: Rename include guard.
 786         * common/selftest.h: Rename include guard.
 787         * common/scoped_restore.h: Rename include guard.
 788         * common/scoped_mmap.h: Rename include guard.
 789         * common/scoped_fd.h: Rename include guard.
 790         * common/safe-iterator.h: Rename include guard.
 791         * common/run-time-clock.h: Rename include guard.
 792         * common/refcounted-object.h: Rename include guard.
 793         * common/queue.h: Rename include guard.
 794         * common/ptid.h: Rename include guard.
 795         * common/print-utils.h: Rename include guard.
 796         * common/preprocessor.h: Rename include guard.
 797         * common/pathstuff.h: Rename include guard.
 798         * common/observable.h: Rename include guard.
 799         * common/netstuff.h: Rename include guard.
 800         * common/job-control.h: Rename include guard.
 801         * common/host-defs.h: Rename include guard.
 802         * common/gdb_wait.h: Rename include guard.
 803         * common/gdb_vecs.h: Rename include guard.
 804         * common/gdb_unlinker.h: Rename include guard.
 805         * common/gdb_unique_ptr.h: Rename include guard.
 806         * common/gdb_tilde_expand.h: Rename include guard.
 807         * common/gdb_sys_time.h: Rename include guard.
 808         * common/gdb_string_view.h: Rename include guard.
 809         * common/gdb_splay_tree.h: Rename include guard.
 810         * common/gdb_setjmp.h: Rename include guard.
 811         * common/gdb_ref_ptr.h: Rename include guard.
 812         * common/gdb_optional.h: Rename include guard.
 813         * common/gdb_locale.h: Rename include guard.
 814         * common/gdb_assert.h: Rename include guard.
 815         * common/filtered-iterator.h: Rename include guard.
 816         * common/filestuff.h: Rename include guard.
 817         * common/fileio.h: Rename include guard.
 818         * common/environ.h: Rename include guard.
 819         * common/common-utils.h: Rename include guard.
 820         * common/common-types.h: Rename include guard.
 821         * common/common-regcache.h: Rename include guard.
 822         * common/common-inferior.h: Rename include guard.
 823         * common/common-gdbthread.h: Rename include guard.
 824         * common/common-exceptions.h: Rename include guard.
 825         * common/common-defs.h: Rename include guard.
 826         * common/common-debug.h: Rename include guard.
 827         * common/cleanups.h: Rename include guard.
 828         * common/buffer.h: Rename include guard.
 829         * common/btrace-common.h: Rename include guard.
 830         * common/break-common.h: Rename include guard.
 831         * cli/cli-utils.h: Rename include guard.
 832         * cli/cli-style.h: Rename include guard.
 833         * cli/cli-setshow.h: Rename include guard.
 834         * cli/cli-script.h: Rename include guard.
 835         * cli/cli-interp.h: Rename include guard.
 836         * cli/cli-decode.h: Rename include guard.
 837         * cli/cli-cmds.h: Rename include guard.
 838         * charset-list.h: Add include guard.
 839         * buildsym-legacy.h: Rename include guard.
 840         * bfin-tdep.h: Add include guard.
 841         * ax.h: Rename include guard.
 842         * arm-linux-tdep.h: Add include guard.
 843         * arm-fbsd-tdep.h: Add include guard.
 844         * arch/xtensa.h: Rename include guard.
 845         * arch/tic6x.h: Add include guard.
 846         * arch/i386.h: Add include guard.
 847         * arch/arm.h: Rename include guard.
 848         * arch/arm-linux.h: Rename include guard.
 849         * arch/arm-get-next-pcs.h: Rename include guard.
 850         * arch/amd64.h: Add include guard.
 851         * arch/aarch64-insn.h: Rename include guard.
 852         * arch-utils.h: Rename include guard.
 853         * annotate.h: Add include guard.
 854         * amd64-darwin-tdep.h: Rename include guard.
 855         * aarch64-linux-tdep.h: Add include guard.
 856         * aarch64-fbsd-tdep.h: Add include guard.
 857         * aarch32-linux-nat.h: Add include guard.
 858
 859 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 860
 861         * macrotab.c (macro_define_internal): New function that
 862         factorizes macro_define_object_internal and macro_define_function
 863         code.
 864         (macro_define_object_internal): Use macro_define_internal.
 865         (macro_define_function): Likewise.
 866
 867 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 868
 869         * macrocmd.c (extract_identifier): Return
 870         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 871         callers.
 872
 873 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 874
 875         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 876
 877 2019-02-05  Tom Tromey  <tom@tromey.com>
 878
 879         * target.c (target_stack::unpush): Move assertion earlier.
 880
 881 2019-01-30  Tom Tromey  <tom@tromey.com>
 882
 883         PR python/23615:
 884         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 885         (gdbpy_parse_and_eval): Likewise.
 886         * python/python-internal.h (gdbpy_allow_threads): New class.
 887
 888 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 889
 890         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 891         (aarch64_fbsd_fpregmap): Move earlier.
 892         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 893         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 894         instead of individual calls to trad_frame_set_reg_addr.
 895         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 896         earlier.
 897         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 898         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 899         instead of individual calls to trad_frame_set_reg_addr.
 900
 901 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 902
 903         * CONTRIBUTE: Replace contribution list with wiki link.
 904
 905 2019-01-25  Tom Tromey  <tom@tromey.com>
 906
 907         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 908
 909 2019-01-25  Tom Tromey  <tom@tromey.com>
 910
 911         * xtensa-linux-nat.c: Fix common/ includes.
 912         * xml-support.h: Fix common/ includes.
 913         * xml-support.c: Fix common/ includes.
 914         * x86-linux-nat.c: Fix common/ includes.
 915         * windows-nat.c: Fix common/ includes.
 916         * varobj.h: Fix common/ includes.
 917         * varobj.c: Fix common/ includes.
 918         * value.c: Fix common/ includes.
 919         * valops.c: Fix common/ includes.
 920         * utils.c: Fix common/ includes.
 921         * unittests/xml-utils-selftests.c: Fix common/ includes.
 922         * unittests/utils-selftests.c: Fix common/ includes.
 923         * unittests/unpack-selftests.c: Fix common/ includes.
 924         * unittests/tracepoint-selftests.c: Fix common/ includes.
 925         * unittests/style-selftests.c: Fix common/ includes.
 926         * unittests/string_view-selftests.c: Fix common/ includes.
 927         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 928         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 929         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 930         * unittests/rsp-low-selftests.c: Fix common/ includes.
 931         * unittests/parse-connection-spec-selftests.c: Fix common/
 932         includes.
 933         * unittests/optional-selftests.c: Fix common/ includes.
 934         * unittests/offset-type-selftests.c: Fix common/ includes.
 935         * unittests/observable-selftests.c: Fix common/ includes.
 936         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 937         * unittests/memrange-selftests.c: Fix common/ includes.
 938         * unittests/memory-map-selftests.c: Fix common/ includes.
 939         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 940         * unittests/function-view-selftests.c: Fix common/ includes.
 941         * unittests/environ-selftests.c: Fix common/ includes.
 942         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 943         * unittests/common-utils-selftests.c: Fix common/ includes.
 944         * unittests/cli-utils-selftests.c: Fix common/ includes.
 945         * unittests/array-view-selftests.c: Fix common/ includes.
 946         * ui-file.c: Fix common/ includes.
 947         * tui/tui-io.c: Fix common/ includes.
 948         * tracepoint.h: Fix common/ includes.
 949         * tracepoint.c: Fix common/ includes.
 950         * tracefile-tfile.c: Fix common/ includes.
 951         * top.h: Fix common/ includes.
 952         * top.c: Fix common/ includes.
 953         * thread.c: Fix common/ includes.
 954         * target/waitstatus.h: Fix common/ includes.
 955         * target/waitstatus.c: Fix common/ includes.
 956         * target.h: Fix common/ includes.
 957         * target.c: Fix common/ includes.
 958         * target-memory.c: Fix common/ includes.
 959         * target-descriptions.c: Fix common/ includes.
 960         * symtab.h: Fix common/ includes.
 961         * symfile.c: Fix common/ includes.
 962         * stap-probe.c: Fix common/ includes.
 963         * spu-linux-nat.c: Fix common/ includes.
 964         * sparc-nat.c: Fix common/ includes.
 965         * source.c: Fix common/ includes.
 966         * solib.c: Fix common/ includes.
 967         * solib-target.c: Fix common/ includes.
 968         * ser-unix.c: Fix common/ includes.
 969         * ser-tcp.c: Fix common/ includes.
 970         * ser-pipe.c: Fix common/ includes.
 971         * ser-base.c: Fix common/ includes.
 972         * selftest-arch.c: Fix common/ includes.
 973         * s12z-tdep.c: Fix common/ includes.
 974         * rust-exp.y: Fix common/ includes.
 975         * rs6000-aix-tdep.c: Fix common/ includes.
 976         * riscv-tdep.c: Fix common/ includes.
 977         * remote.c: Fix common/ includes.
 978         * remote-notif.h: Fix common/ includes.
 979         * remote-fileio.h: Fix common/ includes.
 980         * remote-fileio.c: Fix common/ includes.
 981         * regcache.h: Fix common/ includes.
 982         * regcache.c: Fix common/ includes.
 983         * record-btrace.c: Fix common/ includes.
 984         * python/python.c: Fix common/ includes.
 985         * python/py-type.c: Fix common/ includes.
 986         * python/py-inferior.c: Fix common/ includes.
 987         * progspace.h: Fix common/ includes.
 988         * producer.c: Fix common/ includes.
 989         * procfs.c: Fix common/ includes.
 990         * proc-api.c: Fix common/ includes.
 991         * printcmd.c: Fix common/ includes.
 992         * ppc-linux-nat.c: Fix common/ includes.
 993         * parser-defs.h: Fix common/ includes.
 994         * osdata.c: Fix common/ includes.
 995         * obsd-nat.c: Fix common/ includes.
 996         * nat/x86-linux.c: Fix common/ includes.
 997         * nat/x86-linux-dregs.c: Fix common/ includes.
 998         * nat/x86-dregs.h: Fix common/ includes.
 999         * nat/x86-dregs.c: Fix common/ includes.
1000         * nat/ppc-linux.c: Fix common/ includes.
1001         * nat/mips-linux-watch.h: Fix common/ includes.
1002         * nat/mips-linux-watch.c: Fix common/ includes.
1003         * nat/linux-waitpid.c: Fix common/ includes.
1004         * nat/linux-ptrace.h: Fix common/ includes.
1005         * nat/linux-ptrace.c: Fix common/ includes.
1006         * nat/linux-procfs.c: Fix common/ includes.
1007         * nat/linux-personality.c: Fix common/ includes.
1008         * nat/linux-osdata.c: Fix common/ includes.
1009         * nat/linux-namespaces.c: Fix common/ includes.
1010         * nat/linux-btrace.h: Fix common/ includes.
1011         * nat/linux-btrace.c: Fix common/ includes.
1012         * nat/fork-inferior.c: Fix common/ includes.
1013         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1014         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1015         * nat/aarch64-linux.c: Fix common/ includes.
1016         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1017         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1018         * namespace.h: Fix common/ includes.
1019         * mips-linux-tdep.c: Fix common/ includes.
1020         * minsyms.c: Fix common/ includes.
1021         * mi/mi-parse.h: Fix common/ includes.
1022         * mi/mi-main.c: Fix common/ includes.
1023         * mi/mi-cmd-env.c: Fix common/ includes.
1024         * memrange.h: Fix common/ includes.
1025         * memattr.c: Fix common/ includes.
1026         * maint.h: Fix common/ includes.
1027         * maint.c: Fix common/ includes.
1028         * main.c: Fix common/ includes.
1029         * machoread.c: Fix common/ includes.
1030         * location.c: Fix common/ includes.
1031         * linux-thread-db.c: Fix common/ includes.
1032         * linux-nat.c: Fix common/ includes.
1033         * linux-fork.c: Fix common/ includes.
1034         * inline-frame.c: Fix common/ includes.
1035         * infrun.c: Fix common/ includes.
1036         * inflow.c: Fix common/ includes.
1037         * inferior.h: Fix common/ includes.
1038         * inferior.c: Fix common/ includes.
1039         * infcmd.c: Fix common/ includes.
1040         * inf-ptrace.c: Fix common/ includes.
1041         * inf-child.c: Fix common/ includes.
1042         * ia64-linux-nat.c: Fix common/ includes.
1043         * i387-tdep.c: Fix common/ includes.
1044         * i386-tdep.c: Fix common/ includes.
1045         * i386-linux-tdep.c: Fix common/ includes.
1046         * i386-linux-nat.c: Fix common/ includes.
1047         * i386-go32-tdep.c: Fix common/ includes.
1048         * i386-fbsd-tdep.c: Fix common/ includes.
1049         * i386-fbsd-nat.c: Fix common/ includes.
1050         * guile/scm-type.c: Fix common/ includes.
1051         * guile/guile.c: Fix common/ includes.
1052         * go32-nat.c: Fix common/ includes.
1053         * gnu-nat.c: Fix common/ includes.
1054         * gdbthread.h: Fix common/ includes.
1055         * gdbarch-selftests.c: Fix common/ includes.
1056         * gdb_usleep.c: Fix common/ includes.
1057         * gdb_select.h: Fix common/ includes.
1058         * gdb_bfd.c: Fix common/ includes.
1059         * gcore.c: Fix common/ includes.
1060         * fork-child.c: Fix common/ includes.
1061         * findvar.c: Fix common/ includes.
1062         * fbsd-nat.c: Fix common/ includes.
1063         * event-top.c: Fix common/ includes.
1064         * event-loop.c: Fix common/ includes.
1065         * dwarf2read.c: Fix common/ includes.
1066         * dwarf2loc.c: Fix common/ includes.
1067         * dwarf2-frame.c: Fix common/ includes.
1068         * dwarf-index-cache.c: Fix common/ includes.
1069         * dtrace-probe.c: Fix common/ includes.
1070         * disasm-selftests.c: Fix common/ includes.
1071         * defs.h: Fix common/ includes.
1072         * csky-tdep.c: Fix common/ includes.
1073         * cp-valprint.c: Fix common/ includes.
1074         * cp-support.h: Fix common/ includes.
1075         * cp-support.c: Fix common/ includes.
1076         * corelow.c: Fix common/ includes.
1077         * completer.h: Fix common/ includes.
1078         * completer.c: Fix common/ includes.
1079         * compile/compile.c: Fix common/ includes.
1080         * compile/compile-loc2c.c: Fix common/ includes.
1081         * compile/compile-cplus-types.c: Fix common/ includes.
1082         * compile/compile-cplus-symbols.c: Fix common/ includes.
1083         * command.h: Fix common/ includes.
1084         * cli/cli-dump.c: Fix common/ includes.
1085         * cli/cli-cmds.c: Fix common/ includes.
1086         * charset.c: Fix common/ includes.
1087         * build-id.c: Fix common/ includes.
1088         * btrace.h: Fix common/ includes.
1089         * btrace.c: Fix common/ includes.
1090         * breakpoint.h: Fix common/ includes.
1091         * breakpoint.c: Fix common/ includes.
1092         * ax.h:
1093         (enum agent_op): Fix common/ includes.
1094         * ax-general.c (struct aop_map): Fix common/ includes.
1095         * ax-gdb.c: Fix common/ includes.
1096         * auxv.c: Fix common/ includes.
1097         * auto-load.c: Fix common/ includes.
1098         * arm-tdep.c: Fix common/ includes.
1099         * arch/riscv.c: Fix common/ includes.
1100         * arch/ppc-linux-common.c: Fix common/ includes.
1101         * arch/i386.c: Fix common/ includes.
1102         * arch/arm.c: Fix common/ includes.
1103         * arch/arm-linux.c: Fix common/ includes.
1104         * arch/arm-get-next-pcs.c: Fix common/ includes.
1105         * arch/amd64.c: Fix common/ includes.
1106         * arch/aarch64.c: Fix common/ includes.
1107         * arch/aarch64-insn.c: Fix common/ includes.
1108         * arch-utils.c: Fix common/ includes.
1109         * amd64-windows-tdep.c: Fix common/ includes.
1110         * amd64-tdep.c: Fix common/ includes.
1111         * amd64-sol2-tdep.c: Fix common/ includes.
1112         * amd64-obsd-tdep.c: Fix common/ includes.
1113         * amd64-nbsd-tdep.c: Fix common/ includes.
1114         * amd64-linux-tdep.c: Fix common/ includes.
1115         * amd64-linux-nat.c: Fix common/ includes.
1116         * amd64-fbsd-tdep.c: Fix common/ includes.
1117         * amd64-fbsd-nat.c: Fix common/ includes.
1118         * amd64-dicos-tdep.c: Fix common/ includes.
1119         * amd64-darwin-tdep.c: Fix common/ includes.
1120         * agent.c: Fix common/ includes.
1121         * ada-lang.h: Fix common/ includes.
1122         * ada-lang.c: Fix common/ includes.
1123         * aarch64-tdep.c: Fix common/ includes.
1124
1125 2019-01-25  Tom Tromey  <tom@tromey.com>
1126
1127         * common/create-version.sh: Use common/version.h.
1128
1129 2019-01-24  Pedro Alves  <palves@redhat.com>
1130
1131         * infrun.c (signal_stop, signal_print, signal_program)
1132         (signal_catch, signal_pass): Now arrays instead of pointers.
1133         (update_signals_program_target, do_target_resume)
1134         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1135         * linux-nat.c (linux_nat_target::pass_signals)
1136         (linux_nat_target::create_inferior, linux_nat_target::attach):
1137         Adjust.
1138         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1139         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1140         * procfs.c (procfs_target::pass_signals): Adjust.
1141         * record-full.c (record_full_target::resume): Adjust.
1142         * remote.c (remote_target::pass_signals)
1143         (remote_target::program_signals): Adjust.
1144         * target-debug.h (target_debug_print_signals): Now takes a
1145         gdb::array_view as parameter.  Adjust.
1146         * target.h (target_ops) <pass_signals, program_signals>: Replace
1147         pointer and length parameters with gdb::array_view.
1148         (target_pass_signals, target_program_signals): Likewise.
1149         * target-delegates.c: Regenerate.
1150
1151 2019-01-24  Pedro Alves  <palves@redhat.com>
1152
1153         * common/forward-scope-exit.h
1154         (forward_scope_exit::forward_scope_exit): Pass arguments to
1155         m_bind_function directly, instead of creating a std::bind and
1156         copying that.
1157
1158 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1159
1160         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1161         for static members.
1162         (pass_in_v_vfp_candidate): Likewise.
1163
1164 2019-01-23  Tom Tromey  <tom@tromey.com>
1165             Pedro Alves  <palves@redhat.com>
1166
1167         * regcache.c (class regcache_invalidator): Remove.
1168         (regcache::raw_write): Use make_scope_exit.
1169
1170 2019-01-23  Tom Tromey  <tom@tromey.com>
1171
1172         * ui-out.h (class ui_out_emit_type): Update comment.
1173
1174 2019-01-23  Tom Tromey  <tom@tromey.com>
1175
1176         * infrun.c (fetch_inferior_event): Update comment.
1177
1178 2019-01-23  Tom Tromey  <tom@tromey.com>
1179             Pedro Alves  <palves@redhat.com>
1180
1181         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1182         parameter.
1183         (fetch_inferior_event): Use SCOPE_EXIT.
1184
1185
1186 2019-01-23  Tom Tromey  <tom@tromey.com>
1187             Pedro Alves  <palves@redhat.com>
1188
1189         * infrun.c (disable_thread_events): Delete.
1190         (stop_all_threads): Use SCOPE_EXIT.
1191
1192 2019-01-23  Tom Tromey  <tom@tromey.com>
1193             Pedro Alves  <palves@redhat.com>
1194
1195         * symfile.c: Include forward-scope-exit.h.
1196         (clear_symtab_users_cleanup): Replace forward declaration with
1197         a FORWARD_SCOPE_EXIT.
1198         (syms_from_objfile_1): Use the forward_scope_exit and
1199         gdb::optional instead of cleanup_function.
1200         (reread_symbols): Use the forward_scope_exit instead of
1201         cleanup_function.
1202         (clear_symtab_users_cleanup): Remove function.
1203
1204 2019-01-23  Tom Tromey  <tom@tromey.com>
1205             Pedro Alves  <palves@redhat.com>
1206
1207         * linux-nat.c: Include scope-exit.h.
1208         (cleanup_target_stop): Remove.
1209         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1210         SCOPE_EXIT.
1211
1212 2019-01-23  Tom Tromey  <tom@tromey.com>
1213             Pedro Alves  <palves@redhat.com>
1214
1215         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1216         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1217
1218 2019-01-23  Tom Tromey  <tom@tromey.com>
1219             Andrew Burgess  <andrew.burgess@embecosm.com>
1220             Pedro Alves  <palves@redhat.com>
1221
1222         * infrun.c (fetch_inferior_event): Use scope_exit.
1223         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1224         * top.c (execute_command): Use scope_exit.
1225         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1226         * utils.c (do_bpstat_clear_actions_cleanup)
1227         (make_bpstat_clear_actions_cleanup): Remove.
1228
1229 2019-01-23  Tom Tromey  <tom@tromey.com>
1230             Pedro Alves  <palves@redhat.com>
1231
1232         * infrun.c: Include "common/scope-exit.h"
1233         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1234         (wait_for_inferior): Use SCOPE_EXIT.
1235         (fetch_inferior_event): Use scope_exit.
1236
1237 2019-01-23  Tom Tromey  <tom@tromey.com>
1238             Pedro Alves  <palves@redhat.com>
1239
1240         * breakpoint.c (create_breakpoint): Remove cleanup.
1241
1242 2019-01-23  Tom Tromey  <tom@tromey.com>
1243             Andrew Burgess  <andrew.burgess@embecosm.com>
1244             Pedro Alves  <palves@redhat.com>
1245
1246 2019-01-23  Pedro Alves  <palves@redhat.com>
1247
1248         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1249
1250 2019-01-23  Pedro Alves  <palves@redhat.com>
1251             Andrew Burgess  <andrew.burgess@embecosm.com>
1252
1253         * gdbthread.h: Include "common/forward-scope-exit.h".
1254         (scoped_finish_thread_state): Redefine custom class in terms of
1255         forward_scope_exit.
1256
1257 2019-01-23  Pedro Alves  <palves@redhat.com>
1258             Andrew Burgess  <andrew.burgess@embecosm.com>
1259
1260         * common/forward-scope-exit.h: New file.
1261
1262 2019-01-23  Pedro Alves  <palves@redhat.com>
1263             Andrew Burgess  <andrew.burgess@embecosm.com>
1264             Tom Tromey  <tom@tromey.com>
1265
1266         * common/scope-exit.h: New file.
1267
1268 2019-01-23  Pedro Alves  <palves@redhat.com>
1269
1270         * common/preprocessor.h (ESC): Rename to ...
1271         (ESC_PARENS): ... this.
1272         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1273         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1274
1275 2019-01-23  Tom Tromey  <tom@tromey.com>
1276
1277         * language.h (class scoped_switch_to_sym_language_if_auto):
1278         Initialize m_lang in both cases.
1279
1280 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1281
1282         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1283         with XCNEW.
1284
1285 2019-01-22  Tom Tromey  <tom@tromey.com>
1286
1287         * corelow.c: Do not include sys/file.h.
1288
1289 2019-01-22  Tom Tromey  <tom@tromey.com>
1290
1291         * tui/tui-wingeneral.h: Include gdb_curses.h.
1292
1293 2019-01-22  Tom Tromey  <tom@tromey.com>
1294
1295         * source-cache.h (class source_cache) <get_source_lines,
1296         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1297
1298 2019-01-22  Tom Tromey  <tom@tromey.com>
1299
1300         * remote-fileio.h (struct remote_target): Declare.
1301
1302 2019-01-22  Tom Tromey  <tom@tromey.com>
1303
1304         * python/py-arch.c: Do not include py-ref.h.
1305         * python/py-bpevent.c: Do not include py-ref.h.
1306         * python/py-cmd.c: Do not include py-ref.h.
1307         * python/py-continueevent.c: Do not include py-ref.h.
1308         * python/py-event.h: Do not include py-ref.h.
1309         * python/py-evtregistry.c: Do not include py-ref.h.
1310         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1311         * python/py-frame.c: Do not include py-ref.h.
1312         * python/py-framefilter.c: Do not include py-ref.h.
1313         * python/py-function.c: Do not include py-ref.h.
1314         * python/py-infevents.c: Do not include py-ref.h.
1315         * python/py-linetable.c: Do not include py-ref.h.
1316         * python/py-objfile.c: Do not include py-ref.h.
1317         * python/py-param.c: Do not include py-ref.h.
1318         * python/py-prettyprint.c: Do not include py-ref.h.
1319         * python/py-progspace.c: Do not include py-ref.h.
1320         * python/py-symbol.c: Do not include py-ref.h.
1321         * python/py-symtab.c: Do not include py-ref.h.
1322         * python/py-type.c: Do not include py-ref.h.
1323         * python/py-unwind.c: Do not include py-ref.h.
1324         * python/py-utils.c: Do not include py-ref.h.
1325         * python/py-value.c: Do not include py-ref.h.
1326         * python/py-varobj.c: Do not include py-ref.h.
1327         * python/py-xmethods.c: Do not include py-ref.h.
1328         * python/python.c: Do not include py-ref.h.
1329         * varobj.c: Do not include py-ref.h.
1330
1331 2019-01-22  Tom Tromey  <tom@tromey.com>
1332
1333         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1334         keyword for bcache.
1335
1336 2019-01-22  Tom Tromey  <tom@tromey.com>
1337
1338         * compile/compile-cplus-types.c: Remove a comment by #include.
1339
1340 2019-01-22  Tom Tromey  <tom@tromey.com>
1341
1342         * compile/gcc-c-plugin.h: Include compile-internal.h.
1343
1344 2019-01-22  Tom Tromey  <tom@tromey.com>
1345
1346         * stabsread.c (EXTERN): Do not define.
1347         (symnum, next_symbol_text_func, processing_gcc_compilation)
1348         (within_function, global_sym_chain, global_stabs)
1349         (previous_stab_code, this_object_header_files)
1350         (n_this_object_header_files)
1351         (n_allocated_this_object_header_files): Define.
1352         * stabsread.h (EXTERN): Never define.  Use "extern".
1353
1354 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1355
1356         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1357         history_value.
1358
1359 2019-01-21  Tom Tromey  <tom@tromey.com>
1360
1361         * ui-out.c: Fix includes.
1362         * tui/tui-source.c: Fix includes.
1363         * target.c: Fix includes.
1364         * remote.c: Fix includes.
1365         * regcache.c: Fix includes.
1366         * python/py-block.c: Fix includes.
1367         * printcmd.c: Fix includes.
1368         * or1k-tdep.c: Fix includes.
1369         * mi/mi-main.c: Fix includes.
1370         * m32r-tdep.c: Fix includes.
1371         * csky-tdep.c: Fix includes.
1372         * compile/compile-cplus-types.c: Fix includes.
1373         * cli/cli-interp.c: Fix includes.
1374
1375 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1376
1377         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1378         for padding.
1379
1380 2019-01-16  Tom Tromey  <tom@tromey.com>
1381
1382         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1383         earlier.
1384         (struct objfile) <msymbols_range>: Move from top level.
1385         <msymbols>: New method.
1386         (class objfile_msymbols): Remove.
1387         * symtab.c (default_collect_symbol_completion_matches_break_on):
1388         Update.
1389         * symmisc.c (dump_msymbols): Update.
1390         * stabsread.c (scan_file_globals): Update.
1391         * objc-lang.c (info_selectors_command, info_classes_command)
1392         (find_methods): Update.
1393         * minsyms.c (find_solib_trampoline_target): Update.
1394         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1395         * coffread.c (coff_symfile_read): Update.
1396         * ada-lang.c (ada_lookup_simple_minsym)
1397         (ada_collect_symbol_completion_matches): Update.
1398
1399 2019-01-16  Tom Tromey  <tom@tromey.com>
1400
1401         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1402         type.  Remove no-argument constructor.
1403         <iterator::operator++>: Simplify.
1404         <begin>: Update.
1405         <end>: Use minimal_symbol_count.
1406
1407 2019-01-16  Tom Tromey  <tom@tromey.com>
1408
1409         * objfiles.h (struct objfile) <psymtabs>: New method.
1410         (class objfile_psymtabs): Remove.
1411         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1412         typedef.
1413         <range>: New method.
1414         (require_partial_symbols): Change return type.
1415         * psymtab.c (require_partial_symbols)
1416         (psym_expand_symtabs_matching): Update.
1417         * mdebugread.c (parse_partial_symbols): Update.
1418         * dbxread.c (dbx_end_psymtab): Update.
1419
1420 2019-01-15  Tom Tromey  <tom@tromey.com>
1421
1422         * symtab.c (lookup_objfile_from_block)
1423         (lookup_symbol_in_objfile_symtabs)
1424         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1425         (find_line_symtab, info_sources_command)
1426         (default_collect_symbol_completion_matches_break_on)
1427         (make_source_files_completion_list): Update.
1428         * symmisc.c (print_objfile_statistics, dump_objfile)
1429         (maintenance_print_symbols, maintenance_info_symtabs)
1430         (maintenance_check_symtabs, maintenance_info_line_tables):
1431         Update.
1432         * source.c (select_source_symtab)
1433         (forget_cached_source_info_for_objfile): Update.
1434         * objfiles.h (class objfile_compunits): Remove.
1435         (struct objfile) <compunits_range>: New typedef.
1436         (compunits): New method.
1437         * objfiles.c (objfile_relocate1): Update.
1438         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1439         * maint.c (count_symtabs_and_blocks): Update.
1440         * linespec.c (iterate_over_all_matching_symtabs): Update.
1441         * cp-support.c (add_symbol_overload_list_qualified): Update.
1442         * coffread.c (coff_symtab_read): Update.
1443         * ada-lang.c (add_nonlocal_symbols)
1444         (ada_collect_symbol_completion_matches)
1445         (ada_add_global_exceptions): Update.
1446
1447 2019-01-15  Tom Tromey  <tom@tromey.com>
1448
1449         * progspace.h (program_space) <objfiles_safe_range>: New
1450         typedef.
1451         <objfiles_safe>: New method.
1452         * objfiles.h (class all_objfiles_safe): Remove.
1453         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1454         * jit.c (jit_inferior_exit_hook): Update.
1455
1456 2019-01-17  Tom Tromey  <tom@tromey.com>
1457
1458         * progspace.h (program_space) <objfiles_range>: New typedef.
1459         <objfiles>: New method.
1460         <objfiles_head>: Rename from objfiles.
1461         (object_files): Update.
1462         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1463         * guile/scm-pretty-print.c
1464         (ppscm_find_pretty_printer_from_objfiles): Update.
1465         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1466         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1467         Update.
1468         * python/py-progspace.c (pspy_get_objfiles): Update.
1469         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1470         Update.
1471         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1472         (objfpy_lookup_objfile_by_build_id): Update.
1473         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1474         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1475         Update.
1476         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1477         (expand_symtab_containing_pc, lookup_objfile_from_block)
1478         (lookup_static_symbol, basic_lookup_transparent_type)
1479         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1480         (find_line_symtab, info_sources_command)
1481         (default_collect_symbol_completion_matches_break_on)
1482         (make_source_files_completion_list, find_main_name): Update.
1483         * symmisc.c (print_symbol_bcache_statistics)
1484         (print_objfile_statistics, maintenance_print_symbols)
1485         (maintenance_print_msymbols, maintenance_print_objfiles)
1486         (maintenance_info_symtabs, maintenance_check_symtabs)
1487         (maintenance_expand_symtabs, maintenance_info_line_tables):
1488         Update.
1489         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1490         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1491         (map_overlay_command, unmap_overlay_command)
1492         (simple_overlay_update, expand_symtabs_matching)
1493         (map_symbol_filenames): Update.
1494         * symfile-debug.c (set_debug_symfile): Update.
1495         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1496         Update.
1497         * source.c (select_source_symtab, forget_cached_source_info):
1498         Update.
1499         * solib.c (solib_read_symbols): Update.
1500         * solib-spu.c (append_ocl_sos): Update.
1501         * psymtab.c (maintenance_print_psymbols)
1502         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1503         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1504         * printcmd.c (info_symbol_command): Update.
1505         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1506         Update.
1507         * objfiles.h (class all_objfiles): Remove.
1508         * objfiles.c (have_partial_symbols, have_full_symbols)
1509         (have_minimal_symbols, qsort_cmp, update_section_map)
1510         (shared_objfile_contains_address_p)
1511         (default_iterate_over_objfiles_in_search_order): Update.
1512         * objc-lang.c (info_selectors_command, info_classes_command)
1513         (find_methods): Update.
1514         * minsyms.c (find_solib_trampoline_target): Update.
1515         * maint.c (maintenance_info_sections)
1516         (maintenance_translate_address, count_symtabs_and_blocks):
1517         Update.
1518         * main.c (captured_main_1): Update.
1519         * linux-thread-db.c (try_thread_db_load_from_pdir)
1520         (has_libpthread): Update.
1521         * linespec.c (iterate_over_all_matching_symtabs)
1522         (search_minsyms_for_name): Update.
1523         * jit.c (jit_find_objf_with_entry_addr): Update.
1524         * hppa-tdep.c (find_unwind_entry)
1525         (hppa_lookup_stub_minimal_symbol): Update.
1526         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1527         Update.
1528         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1529         (elf_gnu_ifunc_resolve_by_got): Update.
1530         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1531         * dwarf-index-write.c (save_gdb_index_command): Update.
1532         * cp-support.c (add_symbol_overload_list_qualified): Update.
1533         * breakpoint.c (create_overlay_event_breakpoint)
1534         (create_longjmp_master_breakpoint)
1535         (create_std_terminate_master_breakpoint)
1536         (create_exception_master_breakpoint): Update.
1537         * blockframe.c (find_pc_partial_function): Update.
1538         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1539         (ada_collect_symbol_completion_matches)
1540         (ada_add_global_exceptions): Update.
1541
1542 2019-01-17  Tom Tromey  <tom@tromey.com>
1543
1544         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1545         declare VEC.
1546         (solib_target_parse_libraries): Change return type.
1547         (library_list_start_segment, library_list_start_section)
1548         (library_list_end_library, library_list_start_library); Update.
1549         (solib_target_free_library_list): Remove.
1550         (solib_target_parse_libraries): Remove cleanup.  Change return
1551         type.
1552         (solib_target_current_sos): Update.
1553
1554 2019-01-17  Tom Tromey  <tromey@bapiya>
1555
1556         * valprint.c: Replace "the the" with "the".
1557         * symtab.c: Replace "the the" with "the".
1558         * solib.c: Replace "the the" with "the".
1559         * solib-dsbt.c: Replace "the the" with "the".
1560         * linespec.c: Replace "the the" with "the".
1561         * dwarf2loc.h: Replace "the the" with "the".
1562         * amd64-windows-tdep.c: Replace "the the" with "the".
1563         * aarch64-tdep.c: Replace "the the" with "the".
1564
1565 2019-01-16  Keith Seitz  <keiths@redhat.com>
1566
1567         PR gdb/23773
1568         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1569         <builder>: Rename to ..
1570         <m_builder>: ... this and make private.
1571         (dwarf2_cu::get_builder): New method.  Change all users of
1572         `builder' to use this method.
1573         (dwarf2_start_symtab): Move to ...
1574         (dwarf2_cu::start_symtab): ... here.  Update all callers
1575         (setup_type_unit_groups): Move to ...
1576         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1577         callers.
1578         (dwarf2_cu::reset_builder): New method.
1579         (process_full_compunit, process_full_type_unit): Use
1580         dwarf2_cu::reset_builder.
1581         (follow_die_offset): Record the ancestor CU if it is different
1582         from the followed DIE's CU.
1583         (follow_die_sig_1): Likewise.
1584
1585 2019-01-15  Tom Tromey  <tom@tromey.com>
1586
1587         * remote.c (class remote_state) <buf>: Now a char_vector.
1588         <buf_size>: Remove.
1589         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1590         parameter.
1591         (remote_target::getpkt_or_notif_sane_1)
1592         (remote_target::getpkt_sane)
1593         (remote_target::getpkt_or_notif_sane): Likewise.
1594         (class remote_target) <putpkt>: New overload.
1595         (remote_target::read_frame): Change type of "buf_p".  Remove
1596         sizeof_p parameter.
1597         (packet_ok): New overload.
1598         (packet_check_result): New overload.
1599         Update all uses.
1600
1601 2019-01-14  Tom Tromey  <tom@tromey.com>
1602
1603         * remote-notif.c (handle_notification, remote_notif_ack)
1604         (remote_notif_parse): Make "buf" const.
1605         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1606         const.
1607         (remote_notif_parse, remote_notif_ack, handle_notification):
1608         Likewise.
1609         * remote.c (remote_notif_stop_parse): Make "buf" const.
1610         (remote_target::remote_parse_stop_reply): Make "buf" const.
1611         (remote_notif_stop_ack): Make "buf" const.
1612
1613 2019-01-14  Tom Tromey  <tom@tromey.com>
1614
1615         * remote.c (remote_console_output): Make parameter const.
1616
1617 2019-01-14  Tom Tromey  <tom@tromey.com>
1618
1619         * target-debug.h (target_debug_print_signals): Constify.
1620         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1621         * procfs.c (procfs_target::pass_signals): Update.
1622         * linux-nat.c (linux_nat_target::pass_signals): Update.
1623         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1624         * target-delegates.c: Rebuild.
1625         * remote.c (remote_target::program_signals): Update.
1626         (remote_target::pass_signals): Update.
1627         * target.c (target_pass_signals): Constify argument.
1628         (target_program_signals): Likewise.
1629         * target.h (struct target_ops) <pass_signals, program_signals>:
1630         Constify argument.
1631         (target_pass_signals, target_program_signals): Constify argument.
1632
1633 2019-01-14  Tom Tromey  <tom@tromey.com>
1634
1635         PR tui/28819:
1636         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1637
1638 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1639
1640         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1641         field.
1642         * rs6000-tdep.c: Include reggroups.h.
1643         (IS_V_ALIAS_PSEUDOREG): Define.
1644         (rs6000_register_name): Return names for the "vX" aliases.
1645         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1646         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1647         aliases.  Call default_register_reggroup_p for all other
1648         pseudo-registers.
1649         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1650         New functions.
1651         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1652         Handle "vX" aliases.
1653         (v_alias_pseudo_register_collect): New function.
1654         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1655         (rs6000_gdbarch_init): Initialize "vX" aliases as
1656         pseudo-registers.  Restore registration of
1657         rs6000_pseudo_register_reggroup_p with
1658         set_tdesc_pseudo_register_reggroup_p.
1659
1660 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1661
1662         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1663         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1664         set_gdbarch_num_pseudo_regs.
1665
1666 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1667
1668         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1669         Remove arg prefixname, add do_set and do_show.
1670         Add member functions set_list and show_list.
1671         * cli/cli-style.c (class cli_style_option): Update accordingly.
1672         (style_set_list): Move to file scope.
1673         (style_show_list): Likewise.
1674         (set_style): Call help_list.
1675         (show_style): Call cmd_show_list.
1676         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1677         Update to use the new macro.
1678
1679 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1680
1681         * ada-lang.c (_initialize_ada_language): Expand the help text
1682         for the "catch exception" command.
1683
1684 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1685
1686         * symtab.c (matching_obj_sections): Initialize obj,
1687         declare it closer to its usage.
1688
1689 2019-01-10  Tom Tromey  <tom@tromey.com>
1690
1691         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1692         (basic_inf_threads_range): Remove.
1693         (inf_threads_range, inf_non_exited_threads_range)
1694         (safe_inf_threads_range): Use next_adapter.
1695
1696 2019-01-10  Keith Seitz  <keiths@redhat.com>
1697
1698         PR gdb/23712
1699         PR symtab/23010
1700         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1701         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1702
1703 2019-01-10  Keith Seitz  <keiths@redhat.com>
1704
1705         PR gdb/23712
1706         PR symtab/23010
1707         * dictionary.c (pending_to_vector): Remove.
1708         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1709         Remove _1 suffix, replacing functions of the same name.  Update
1710         all callers.
1711         (dict_create_hashed, dict_create_hashed_expandable)
1712         (dict_create_linear, dict_create_linear_expandable, dict_free)
1713         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1714         Make functions static.
1715
1716 2019-01-10  Keith Seitz  <keiths@redhat.com>
1717
1718         PR gdb/23712
1719         PR symtab/23010
1720         * dictionary.h (struct dictionary): Replace declaration with
1721         multidictionary.
1722         (dict_create_hashed, dict_create_hashed_expandable)
1723         (dict_create_linear, dict_create_linear_expandable)
1724         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1725         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1726         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1727         taking multidictionary argument.
1728         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1729         * block.h (struct block) <dict>: Change to multidictionary
1730         and rename `multidict'.
1731         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1732         symmisc.c: Update all dictionary references to multidictionary.
1733
1734 2019-01-10  Keith Seitz  <keiths@redhat.com>
1735
1736         PR gdb/23712
1737         PR symtab/23010
1738         * dictionary.c: Include unordered_map.
1739         (pending_to_vector): New function.
1740         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1741         Rewrite the non-"_1" functions to take vector instead
1742         of linked list.
1743         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1744         "new" _1 versions of the same name.
1745         (multidictionary): Define.
1746         (std::hash<enum language): New definition.
1747         (collate_pending_symbols_by_language, mdict_create_hashed)
1748         (mdict_create_hashed_expandable, mdict_create_linear)
1749         (mdict_create_linear_expandable, mdict_free)
1750         (find_language_dictionary, create_new_language_dictionary)
1751         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1752         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1753         (mdict_size, mdict_empty): New functions.
1754         * dictionary.h (mdict_iterator): Define.
1755
1756 2019-01-10  Pedro Alves  <palves@redhat.com>
1757
1758         * breakpoint.c (read_uploaded_action)
1759         (create_tracepoint_from_upload): Adjust to use
1760         gdb::unique_xmalloc_ptr.
1761         * ctf.c (ctf_write_uploaded_tp):
1762         (SET_ARRAY_FIELD): Use emplace_back.
1763         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1764         * tracefile-tfile.c (tfile_write_uploaded_tp):
1765         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1766         gdb::unique_xmalloc_ptr.
1767         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1768         at_string, cond_string, cmd_strings>: Replace char pointers
1769         with gdb::unique_xmalloc_ptr.
1770
1771 2019-01-10  Pedro Alves  <palves@redhat.com>
1772
1773         * solib-target.c (library_list_start_library): Don't xstrdup name.
1774
1775 2019-01-10  Pedro Alves  <palves@redhat.com>
1776
1777         * mdebugread.c (parse_partial_symbols): Use
1778         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1779
1780 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1781
1782         * linux-fork.c (scoped_switch_fork_info)
1783         <~scoped_switch_fork_info>: Fix incorrect variable name.
1784
1785 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1786
1787         * linux-fork.c (scoped_switch_fork_info)
1788         <scoped_switch_fork_info>: Make explicit.
1789         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1790
1791 2019-01-10  Tom Tromey  <tom@tromey.com>
1792
1793         * objfiles.h (objfile::reset_psymtabs): Update.
1794         * objfiles.c (objfile::objfile): Update.
1795         * psymtab.h (psymtab_storage::obstack): Update.
1796         (psymtab_storage::m_obstack): Use gdb::optional.
1797         (class psymtab_storage): Update comment.  Remove objfile
1798         parameter.
1799         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1800
1801 2019-01-10  Tom Tromey  <tom@tromey.com>
1802
1803         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1804         <free_psymtabs>: Now private.
1805         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1806         (allocate_psymtab): Use new method.
1807
1808 2019-01-10  Tom Tromey  <tom@tromey.com>
1809
1810         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1811         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1812         * mdebugread.c (parse_partial_symbols): Use
1813         allocate_dependencies.
1814         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1815         allocate_dependencies.
1816         (process_psymtab_comp_unit_reader)
1817         (build_type_psymtab_dependencies): Likewise.
1818         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1819
1820 2019-01-10  Tom Tromey  <tom@tromey.com>
1821
1822         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1823         PSYMBOL_SET_LANGUAGE.
1824         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1825
1826 2019-01-10  Tom Tromey  <tom@tromey.com>
1827
1828         * psymtab.h (psymtab_storage::obstack): New method.
1829         <m_obstack>: Rename from obstack; now private.
1830         * psymtab.c (psymtab_storage): Update.
1831         * dwarf2read.c (create_addrmap_from_index)
1832         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1833         Update.
1834
1835 2019-01-10  Tom Tromey  <tom@tromey.com>
1836
1837         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1838         * objfiles.h (objfile::reset_psymtabs): New method.
1839
1840 2019-01-10  Tom Tromey  <tom@tromey.com>
1841
1842         * symmisc.c (print_symbol_bcache_statistics): Update.
1843         (print_objfile_statistics): Update.
1844         * symfile.c (reread_symbols): Update.
1845         * psymtab.h (class psymtab_storage): New.
1846         * psymtab.c (psymtab_storage): New constructor.
1847         (~psymtab_storage): New destructor.
1848         (require_partial_symbols): Update.
1849         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1850         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1851         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1852         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1853         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1854         (start_psymtab_common, end_psymtab_common)
1855         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1856         (allocate_psymtab): Update.
1857         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1858         Update.
1859         (dump_psymtab_addrmap, maintenance_print_psymbols)
1860         (maintenance_check_psymtabs): Update.
1861         (class objfile_psymtabs): Move to objfiles.h.
1862         * psympriv.h (discard_psymtab): Now inline.
1863         (psymtab_discarder::psymtab_discarder): Update.
1864         (psymtab_discarder::~psymtab_discarder): Update.
1865         (ALL_OBJFILE_PSYMTABS): Rewrite.
1866         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1867         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1868         Remove fields.
1869         <partial_symtabs>: New field.
1870         (class objfile_psymtabs): Move from psymtab.h.  Update.
1871         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1872         psymbol_cache.
1873         (objfile::~objfile): Don't destroy psymbol_cache.
1874         * mdebugread.c (parse_partial_symbols): Update.
1875         * dwarf2read.c (create_addrmap_from_index)
1876         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1877         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1878         (add_partial_subprogram, dwarf2_ranges_read): Update.
1879         * dwarf-index-write.c (write_address_map)
1880         (write_one_signatured_type, recursively_write_psymbols)
1881         (class debug_names, class debug_names, write_psymtabs_to_index):
1882         Update.
1883
1884 2019-01-10  Tom Tromey  <tom@tromey.com>
1885
1886         * symtab.h (SYMBOL_SET_NAMES): Update.
1887         (symbol_set_names): Update.
1888         (MSYMBOL_SET_NAMES): Update.
1889         * symtab.c (symbol_set_names): Change argument to be an
1890         objfile_per_bfd_storage.
1891         * psymtab.c (add_psymbol_to_bcache): Update.
1892         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1893
1894 2019-01-10  Tom Tromey  <tom@tromey.com>
1895
1896         * symtab.c (create_demangled_names_hash): Change argument to be an
1897         objfile_per_bfd_storage.
1898         (symbol_set_names): Update.
1899
1900 2019-01-10  Tom Tromey  <tom@tromey.com>
1901
1902         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1903         init_psymbol_list.
1904         * psymtab.c (init_psymbol_list): Do nothing if already called.
1905         * psympriv.h (init_psymbol_list): Add comment.
1906         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1907         init_psymbol_list.
1908         * dbxread.c (dbx_symfile_read): Unconditionally call
1909         init_psymbol_list.
1910
1911 2019-01-10  Tom Tromey  <tom@tromey.com>
1912
1913         * xcoffread.c (scan_xcoff_symtab): Update.
1914         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1915         "where".
1916         * mdebugread.c (parse_partial_symbols)
1917         (handle_psymbol_enumerators): Update.
1918         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1919         * dbxread.c (read_dbx_symtab): Update.
1920         * psympriv.h (psymbol_placement): New enum.
1921         (add_psymbol_to_list): Update.
1922
1923 2019-01-10  Tom Tromey  <tom@tromey.com>
1924
1925         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1926         static_psymbols parameters.
1927         (scan_xcoff_symtab): Update.
1928         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1929         static_psymbols parameters.
1930         * psympriv.h (start_psymtab_common): Update.
1931         * mdebugread.c (parse_partial_symbols): Update.
1932         * dwarf2read.c (create_partial_symtab): Update.
1933         * dbxread.c (read_dbx_symtab): Update.
1934         (start_psymtab): Remove global_psymbols and static_psymbols
1935         parameters.
1936
1937 2019-01-10  Tom Tromey  <tom@tromey.com>
1938
1939         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1940         * psymtab.c (allocate_psymtab): Add comment.
1941         * psympriv.h (allocate_psymtab): Add comment.
1942         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1943         initializations.
1944         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1945
1946 2019-01-10  Tom Tromey  <tom@tromey.com>
1947
1948         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1949         Don't declare.
1950         * mipsread.c: Include mdebugread.h.
1951         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1952         Declare.
1953         * elfread.c: Include mdebugread.h.
1954
1955 2019-01-09  Tom Tromey  <tom@tromey.com>
1956
1957         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1958         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1959         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1960         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1961         (psym_lookup_symbol, psym_find_last_source_symtab)
1962         (psym_forget_cached_source_info, psym_print_stats)
1963         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1964         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1965         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1966         (psym_find_compunit_symtab_by_address)
1967         (maintenance_print_psymbols, maintenance_info_psymtabs)
1968         (maintenance_check_psymtabs): Use ranged for.
1969         * psymtab.h (class objfile_psymtabs): New.
1970         (require_partial_symbols): Return objfile_psymtabs.
1971         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1972
1973 2019-01-09  Tom Tromey  <tom@tromey.com>
1974
1975         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1976         (find_pc_mapped_section, list_overlays_command)
1977         (map_overlay_command, unmap_overlay_command)
1978         (simple_overlay_update): Use all_objfiles.
1979         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1980         * printcmd.c (info_symbol_command): Use all_objfiles.
1981         * objfiles.h (ALL_OBJSECTIONS): Remove.
1982         * maint.c (maintenance_translate_address): Use all_objfiles.
1983         * gcore.c (gcore_create_callback): Use all_objfiles.
1984         (objfile_find_memory_regions): Likewise.
1985
1986 2019-01-09  Tom Tromey  <tom@tromey.com>
1987
1988         * symtab.c (find_line_symtab, info_sources_command)
1989         (make_source_files_completion_list): Use objfile_compunits.
1990         * source.c (select_source_symtab): Use objfile_compunits.
1991         * objfiles.h (struct objfile): Update comment.
1992         (ALL_OBJFILES): Remove.
1993         (ALL_FILETABS): Remove.
1994         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1995         objfile_compunits.
1996
1997 2019-01-09  Tom Tromey  <tom@tromey.com>
1998
1999         * symmisc.c (print_objfile_statistics, dump_objfile)
2000         (maintenance_print_symbols): Use compunit_filetabs.
2001         * source.c (forget_cached_source_info_for_objfile): Use
2002         compunit_filetabs.
2003         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2004         (ALL_FILETABS): Use compunit_filetabs.
2005         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2006         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2007
2008 2019-01-09  Tom Tromey  <tom@tromey.com>
2009
2010         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2011         (compunit_filetabs): New.
2012         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2013         compunit_filetabs.
2014         (info_sources_command, make_source_files_completion_list): Remove
2015         declaration.
2016         * symmisc.c (print_objfile_statistics, dump_objfile)
2017         (maintenance_print_symbols): Remove declaration.
2018         (maintenance_info_symtabs): Use compunit_filetabs.
2019         (maintenance_info_line_tables): Likewise.
2020         * source.c (select_source_symtab): Change local variable name.
2021         (forget_cached_source_info_for_objfile): Remove declaration.
2022         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2023         * objfiles.c (objfile_relocate1): Remove declaration.
2024         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2025         declaration.
2026         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2027         * coffread.c (coff_symtab_read): Remove declaration.
2028         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2029         compunit_filetabs.
2030
2031 2019-01-09  Tom Tromey  <tom@tromey.com>
2032
2033         * symtab.c (lookup_objfile_from_block)
2034         (find_pc_sect_compunit_symtab, search_symbols)
2035         (default_collect_symbol_completion_matches_break_on): Use
2036         objfile_compunits.
2037         * objfiles.h (ALL_COMPUNITS): Remove.
2038         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2039         * cp-support.c (add_symbol_overload_list_qualified): Use
2040         objfile_compunits.
2041         * ada-lang.c (ada_collect_symbol_completion_matches)
2042         (ada_add_global_exceptions): Use objfile_compunits.
2043
2044 2019-01-09  Tom Tromey  <tom@tromey.com>
2045
2046         * source.c (select_source_symtab)
2047         (forget_cached_source_info_for_objfile): Remove declaration.
2048         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2049         declaration.
2050         * maint.c (count_symtabs_and_blocks): Remove declaration.
2051         * cp-support.c (add_symbol_overload_list_qualified): Remove
2052         declaration.
2053         * coffread.c (coff_symtab_read): Remove declaration.
2054         * symtab.c (lookup_symbol_in_objfile_symtabs)
2055         (basic_lookup_transparent_type_1): Use objfile_compunits.
2056         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2057         (info_sources_command, search_symbols)
2058         (default_collect_symbol_completion_matches_break_on)
2059         (make_source_files_completion_list): Remove declaration.
2060         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2061         (ada_collect_symbol_completion_matches)
2062         (ada_add_global_exceptions): Remove declaration.
2063         * linespec.c (iterate_over_all_matching_symtabs): Use
2064         objfile_compunits.
2065         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2066         (class objfile_compunits): New.
2067         (ALL_COMPUNITS): Use objfile_compunits.
2068         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2069         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2070         objfile_compunits.
2071         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2072
2073 2019-01-09  Tom Tromey  <tom@tromey.com>
2074
2075         * symtab.c (search_symbols)
2076         (default_collect_symbol_completion_matches_break_on): Use
2077         objfile_msymbols.
2078         * ada-lang.c (ada_lookup_simple_minsym)
2079         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2080         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2081         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2082         objfile_msymbols.
2083         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2084         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2085         * objc-lang.c (find_methods): Use objfile_msymbols.
2086         (info_selectors_command, info_classes_command): Likewise.
2087         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2088         * objfiles.h (class objfile_msymbols): New.
2089         (ALL_OBJFILE_MSYMBOLS): Remove.
2090         (ALL_MSYMBOLS): Remove.
2091
2092 2019-01-09  Tom Tromey  <tom@tromey.com>
2093
2094         * common/next-iterator.h (next_adapter): Add Iterator template
2095         parameter.
2096         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2097         (class all_objfiles_safe): New.
2098         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2099         * objfiles.c (put_objfile_before): Update comment.
2100         (add_separate_debug_objfile): Likewise.
2101         (free_all_objfiles): Use all_objfiles_safe.
2102         (objfile_purge_solibs): Likewise.
2103
2104 2019-01-09  Tom Tromey  <tom@tromey.com>
2105
2106         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2107         (expand_symtab_containing_pc, lookup_static_symbol)
2108         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2109         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2110         all_objfiles.
2111         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2112         * breakpoint.c (create_overlay_event_breakpoint)
2113         (create_longjmp_master_breakpoint)
2114         (create_std_terminate_master_breakpoint)
2115         (create_exception_master_breakpoint): Use all_objfiles.
2116         * linux-thread-db.c (try_thread_db_load_from_pdir)
2117         (has_libpthread): Use all_objfiles.
2118         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2119         * linespec.c (iterate_over_all_matching_symtabs)
2120         (search_minsyms_for_name): Use all_objfiles.
2121         * maint.c (maintenance_info_sections): Use all_objfiles.
2122         * main.c (captured_main_1): Use all_objfiles.
2123         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2124         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2125         * guile/scm-pretty-print.c
2126         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2127         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2128         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2129         (maintenance_print_msymbols): Use all_objfiles.
2130         * source.c (select_source_symtab): Use all_objfiles.
2131         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2132         * symfile.c (remove_symbol_file_command)
2133         (expand_symtabs_matching, map_symbol_filenames): Use
2134         all_objfiles.
2135         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2136         all_objfiles.
2137         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2138         * objc-lang.c (find_methods): Use all_objfiles.
2139         * objfiles.c (have_partial_symbols, have_full_symbols)
2140         (have_minimal_symbols, qsort_cmp)
2141         (default_iterate_over_objfiles_in_search_order): Use
2142         all_objfiles.
2143         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2144         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2145         (maintenance_check_psymtabs): Use all_objfiles.
2146         (ALL_PSYMTABS): Remove.
2147         * compile/compile-object-run.c (do_module_cleanup): Use
2148         all_objfiles.
2149         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2150         * cp-support.c (add_symbol_overload_list_qualified): Use
2151         all_objfiles.
2152         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2153         Use all_objfiles.
2154         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2155         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2156         all_objfiles.
2157         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2158         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2159         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2160         Uses all_objfiles.
2161         * solib.c (solib_read_symbols): Use all_objfiles
2162
2163 2019-01-09  Tom Tromey  <tom@tromey.com>
2164
2165         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2166         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2167         all_objfiles.
2168         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2169         * symmisc.c (print_symbol_bcache_statistics)
2170         (print_objfile_statistics, maintenance_print_objfiles)
2171         (maintenance_info_symtabs, maintenance_check_symtabs)
2172         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2173         all_objfiles.
2174         * source.c (forget_cached_source_info): Use all_objfiles.
2175         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2176         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2177         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2178         * objfiles.c (update_section_map): Use all_objfiles.
2179         (shared_objfile_contains_address_p): Likewise.
2180         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2181         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2182
2183 2019-01-09  Tom Tromey  <tom@tromey.com>
2184
2185         * common/next-iterator.h: New file.
2186         * objfiles.h (class all_objfiles): New.
2187         (struct objfile_iterator): New.
2188
2189 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2190
2191         * NEWS: Move the description of the changed "frame", "select-frame",
2192          and "info frame" commands to the Changed commands section.
2193
2194 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2195
2196         * gdbtypes.c (check_stub_method_group): Remove handling of old
2197         mangling schemes.
2198         * linespec.c (find_methods): Likewise.
2199         * stabsread.c (read_member_functions): Likewise.
2200         * valops.c (search_struct_method): Likewise.
2201         (value_struct_elt_for_reference): Likewise.
2202         * NEWS: Mention this change.
2203
2204 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2205
2206         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2207         print_source_lines.
2208         * source.c (print_source_lines_base): Update line number check.
2209         (print_source_lines): New function.
2210         (source_lines_range::source_lines_range): New function.
2211         * source.h (class source_lines_range): New class.
2212         (print_source_lines): New declaration.
2213
2214 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2215
2216         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2217
2218 2019-01-08  Tom Tromey  <tom@tromey.com>
2219             Simon Marchi  <simon.marchi@ericsson.com>
2220
2221         PR gdb/24060
2222         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2223         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2224         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2225         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2226         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2227         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2228
2229 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2230
2231         * source.c (select_source_symtab): Move header comment to
2232         declaration in source.h.
2233         (forget_cached_source_info_for_objfile): Likewise.
2234         (forget_cached_source_info): Likewise.
2235         (identify_source_line): Likewise.
2236         * source.h (identify_source_line): Move declaration from symtab.h
2237         and add comment from source.c
2238         (print_source_lines): Likewise.
2239         (forget_cached_source_info_for_objfile): Likewise.
2240         (forget_cached_source_info): Likewise.
2241         (select_source_symtab): Likewise.
2242         (enum print_source_lines_flag): Move definition from symtab.h.
2243         * symtab.h (identify_source_line): Move declaration to source.h.
2244         (print_source_lines): Likewise.
2245         (forget_cached_source_info_for_objfile): Likewise.
2246         (forget_cached_source_info): Likewise.
2247         (select_source_symtab): Likewise.
2248         (enum print_source_lines_flag): Move definition to source.h.
2249         * tui/tui-hooks.c: Add 'source.h' include.
2250
2251 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2252
2253         * source.c (print_source_lines_base): Handle requests to print
2254         reverse line number sequences, and guard against empty lines
2255         string.
2256
2257 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2258
2259         * source.c (print_source_lines_base): Fix skip of '\r' if next
2260         character is '\n'.
2261
2262 2019-01-06  Tom Tromey  <tom@tromey.com>
2263
2264         * c-exp.y (struct c_parse_state) <macro_original_text,
2265         expansion_obstack>: New member.
2266         (macro_original_text, expansion_obstack): Remove globals.
2267         (scan_macro_expansion, scanning_macro_expansion)
2268         (finished_macro_expansion): Update.
2269         (scan_macro_cleanup): Remove.
2270         (yylex, c_parse): Update.
2271
2272 2019-01-06  Tom Tromey  <tom@tromey.com>
2273
2274         * c-exp.y (struct c_parse_state) <strings>: New member.
2275         (operator_stoken): Update.
2276
2277 2019-01-06  Tom Tromey  <tom@tromey.com>
2278
2279         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2280         (union type_stack_elt) <typelist_val>: Now a pointer to
2281         std::vector.
2282         (type_stack_cleanup): Don't declare.
2283         (push_typelist): Update.
2284         * parse.c (pop_typelist): Return a std::vector.
2285         (push_typelist): Take a std::vector.
2286         (follow_types): Update.  Do not free args.
2287         (type_stack_cleanup): Remove.
2288         * c-exp.y (struct c_parse_state): New.
2289         (cpstate): New global.
2290         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2291         (nonempty_typelist): Update.
2292         (func_mod): Create a new vector.
2293         (c_parse): Create a c_parse_state.
2294         (check_parameter_typelist): Do not delete params.
2295         (function_method): Update.  Do not delete type_list.
2296
2297 2019-01-06  Tom Tromey  <tom@tromey.com>
2298
2299         PR gdb/28155:
2300         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2301         check_typedef.
2302         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2303         (print_return_value): Likewise.
2304
2305 2019-01-05  Tom Tromey  <tom@tromey.com>
2306
2307         * contrib/cleanup_check.py: Remove.
2308         * contrib/gcc-with-excheck: Remove.
2309         * contrib/exsummary.py: Remove.
2310         * contrib/excheck.py: Remove.
2311
2312 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2313
2314         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2315         NULL. Initialize tpprev to NULL instead of assigning it
2316         to NULL on the next statement.
2317         * windows-nat.c (windows_delete_thread): Remove check for
2318         main_thread_id before printing thread exit notifications.
2319         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2320         Remove thread ID check against main_thread_id.
2321         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2322         windows_delete_thread.
2323         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2324
2325 2019-01-04  Tom Tromey  <tom@tromey.com>
2326
2327         * compile/compile.c (_initialize_compile): Use upper case for
2328         metasyntactic variables.
2329         * symmisc.c (_initialize_symmisc): Use upper case for
2330         metasyntactic variables.
2331         * psymtab.c (_initialize_psymtab): Use upper case for
2332         metasyntactic variables.
2333         * demangle.c (demangle_command): Use upper case for metasyntactic
2334         variables.
2335         (_initialize_demangler): Likewise.
2336         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2337         variables.
2338
2339 2019-01-03  Tom Tromey  <tom@tromey.com>
2340
2341         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2342
2343 2019-01-03  Tom Tromey  <tom@tromey.com>
2344
2345         * python/py-symtab.c (salpy_str): Update.
2346         (struct salpy_sal_object) <symtab>: Now a PyObject.
2347         (salpy_dealloc): Update.
2348         (del_objfile_sal): Use gdbpy_ref.
2349
2350 2019-01-03  Tom Tromey  <tom@tromey.com>
2351
2352         * python/py-type.c (convert_field): Use new_reference.  Return
2353         gdbpy_ref.
2354         (make_fielditem): Return gdbpy_ref.
2355         (typy_fields): Update.
2356         (typy_getitem): Update.
2357         (field_name): Return gdbpy_ref.  Use new_reference.
2358         (typy_iterator_iternext): Update.
2359
2360 2019-01-03  Tom Tromey  <tom@tromey.com>
2361
2362         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2363
2364 2019-01-03  Tom Tromey  <tom@tromey.com>
2365
2366         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2367         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2368         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2369         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2370         (pspy_set_type_printers): Likewise.
2371         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2372         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2373         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2374         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2375         (objfpy_set_type_printers): Likewise.
2376
2377 2019-01-03  Tom Tromey  <tom@tromey.com>
2378
2379         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2380         (gdbpy_print_stack): Use gdbpy_err_fetch.
2381         * python/python-internal.h (class gdbpy_err_fetch): New class.
2382         (class gdbpy_enter) <m_error_type, m_error_value,
2383         m_error_traceback>: Remove.
2384         <m_error>: New member.
2385         (gdbpy_exception_to_string): Don't declare.
2386         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2387         * python/py-value.c (convert_value_from_python): Use
2388         gdbpy_err_fetch.
2389         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2390         gdbpy_exception_to_string.
2391         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2392         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2393         gdbpy_err_fetch.
2394
2395 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2396
2397         * linux-nat.c (delete_lwp_cleanup): Delete.
2398         (struct lwp_deleter): New struct.
2399         (lwp_info_up): New typedef.
2400         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2401         lwp_info_up.
2402
2403 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2404
2405         * linux-fork.c (class scoped_switch_fork_info): New class.
2406         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2407
2408 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2409
2410         * valops.c (find_overload_match): Remove use of null_cleanup, and
2411         calls to do_cleanups.
2412
2413 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2414
2415         * compile/compile-cplus-types.c
2416         (compile_cplus_instance::decl_name): Handle changes to
2417         cp_func_name.
2418         * cp-support.c (cp_func_name): Update header comment, update
2419         return type.
2420         * cp-support.h (cp_func_name): Update return type in declaration.
2421         * valops.c (find_overload_match): Move temp_func local to top
2422         level of function and change its type.  Use temp_func to hold and
2423         delete temporary string obtained from cp_func_name.
2424
2425 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2426
2427         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2428         gdb::char_vector, remove cleanup, and update uses of `msg`.
2429
2430 2019-01-03  Jim Wilson  <jimw@sifive.com>
2431
2432         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2433
2434 2019-01-02  Tom Tromey  <tom@tromey.com>
2435
2436         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2437         (tdesc_parse_xml): Remove cleanups.
2438         * target-descriptions.h (make_cleanup_free_target_description):
2439         Don't declare.
2440         (target_desc_deleter): New struct.
2441         (target_desc_up): New typedef.
2442         * target-descriptions.c (target_desc_deleter::operator()): Rename
2443         from free_target_description.
2444         (make_cleanup_free_target_description): Remove.
2445
2446 2019-01-02  Tom Tromey  <tom@tromey.com>
2447
2448         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2449         constructor, destructor.
2450         (linespec_parser): Remove typedef.
2451         (~linespec_parser): Rename from linespec_parser_delete.
2452         (linespec_lex_to_end, linespec_complete_label)
2453         (linespec_complete): Update.
2454         (decode_line_full): Remove cleanups.
2455         (decode_line_1): Update.
2456
2457 2019-01-02  Tom Tromey  <tom@tromey.com>
2458
2459         * python/python-internal.h (inferior_to_inferior_object): Change
2460         return type.
2461         * python/py-exitedevent.c (create_exited_event_object): Update.
2462         * python/py-inferior.c (inferior_to_inferior_object): Return
2463         gdbpy_ref.
2464         (python_new_inferior, python_inferior_deleted)
2465         (thread_to_thread_object, delete_thread_object)
2466         (build_inferior_list, gdbpy_selected_inferior): Update.
2467         * python/py-infthread.c (create_thread_object): Update.  Also fail
2468         if inferior_to_inferior_object fails.
2469
2470 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2471
2472         * inferior.h (class inferior) <displaced_step_state>: New field.
2473         * infrun.h (struct displaced_step_state): Move here from
2474         infrun.c.  Initialize fields, add constructor.
2475         <inf>: Remove field.
2476         <reset>: New method.
2477         * infrun.c (struct displaced_step_inferior_state): Move to
2478         infrun.h.
2479         (displaced_step_inferior_states): Remove.
2480         (get_displaced_stepping_state): Adust.
2481         (displaced_step_in_progress_any_inferior): Adjust.
2482         (displaced_step_in_progress_thread): Adjust.
2483         (displaced_step_in_progress): Adjust.
2484         (add_displaced_stepping_state): Remove.
2485         (get_displaced_step_closure_by_addr): Adjust.
2486         (remove_displaced_stepping_state): Remove.
2487         (infrun_inferior_exit): Call displaced_step_state.reset.
2488         (use_displaced_stepping): Don't check for NULL.
2489         (displaced_step_prepare_throw): Call
2490         get_displaced_stepping_state.
2491         (displaced_step_fixup): Don't check for NULL.
2492         (prepare_for_detach): Don't check for NULL.
2493
2494 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2495
2496         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2497          in case of call that did not complete.
2498
2499 2019-01-02  Andrey Utkin  <autkin@undo.io>
2500
2501         * symfile.c (find_separate_debug_file): Fix search of debug files for
2502         remote debuggee.
2503
2504 2019-01-02  Tom Tromey  <tom@tromey.com>
2505
2506         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2507         indentation.
2508         * python/py-frame.c (frapy_older): Remove cast.
2509         (frapy_newer): Likewise.
2510         * python/py-breakpoint.c (local_setattro): Remove cast.
2511         * python/py-arch.c (archpy_name): Remove local variable.
2512         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2513
2514 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2515
2516         * unittests/basic_string_view/element_access/char/empty.cc:
2517         Fix year range in copyright header.
2518
2519 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2520
2521         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2522         Delete.
2523         <operator==>: Update with for removed field.
2524         <hash>: Likewise.
2525         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2526         <isa_features>: ...this.
2527         <abi_features>: New field.
2528         (riscv_isa_flen): Update comment.
2529         (riscv_abi_xlen): New declaration.
2530         (riscv_abi_flen): New declaration.
2531         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2532         isa_features.
2533         (riscv_abi_xlen): New function.
2534         (riscv_isa_flen): Update to get answer from isa_features.
2535         (riscv_abi_flen): New function.
2536         (riscv_has_fp_abi): Update to get answer from abi_features.
2537         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2538         xlen and flen.
2539         (riscv_call_info) <xlen, flen>: Update comment.
2540         (riscv_call_arg_struct): Remove invalid assertions
2541         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2542         is removed.
2543         (riscv_gdbarch_init): Gather isa features and abi features
2544         separately, ensure both match on the gdbarch when reusing an old
2545         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2546         a target with 64-bit float hardware.
2547
2548 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2549
2550         * source.c (search_command_helper): Stop reverse search
2551         when line 1 has been searched.
2552
2553 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2554
2555         * record-full.c (record_full_base_target::close): Rewrite
2556         record_full_core_buf_list free logic.
2557
2558 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2559
2560         * break-catch-syscall.c (print_one_catch_syscall): xfree
2561         the last text.
2562
2563 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2564
2565         * top.c (print_gdb_version): Update Copyright year in version
2566         message.
2567
2568 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2569
2570         Update copyright year range in all GDB files.
2571
2572 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2573
2574         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2575
2576 For older changes see ChangeLog-2018.
2577 \f
2578 Local Variables:
2579 mode: change-log
2580 left-margin: 8
2581 fill-column: 74
2582 version-control: never
2583 coding: utf-8
2584 End:
2585