C++-ify ravenscar_arch_ops
[external/binutils.git] / gdb / ChangeLog
1 2019-02-15  Tom Tromey  <tromey@adacore.com>
2
3         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4         from ravenscar_arch_ops.
5         (sparc_ravenscar_ops::fetch_registers)
6         (sparc_ravenscar_ops::store_registers): Now methods.
7         (sparc_ravenscar_prepare_to_store): Remove.
8         (sparc_ravenscar_ops): Redefine.
9         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10         methods and destructor.  Remove members.
11         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12         (ravenscar_thread_target::store_registers)
13         (ravenscar_thread_target::prepare_to_store): Update.
14         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
15         Remove.
16         (struct ppc_ravenscar_powerpc_ops): Derive from
17         ravenscar_arch_ops.
18         (ppc_ravenscar_powerpc_ops::fetch_registers)
19         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
20         (ppc_ravenscar_powerpc_ops): Redefine.
21         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
22         (ppc_ravenscar_e500_ops::fetch_registers)
23         (ppc_ravenscar_e500_ops::store_registers): Now methods.
24         (ppc_ravenscar_e500_ops): Redefine.
25         * aarch64-ravenscar-thread.c
26         (aarch64_ravenscar_generic_prepare_to_store): Remove.
27         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
28         (aarch64_ravenscar_fetch_registers)
29         (aarch64_ravenscar_store_registers): Now methods.
30         (aarch64_ravenscar_ops): Redefine.
31
32 2019-02-15  Tom Tromey  <tromey@adacore.com>
33
34         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
35         (ravenscar_thread_target::stopped_by_hw_breakpoint)
36         (ravenscar_thread_target::stopped_by_watchpoint)
37         (ravenscar_thread_target::stopped_data_address)
38         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
39
40 2019-02-15  Tom Tromey  <tromey@adacore.com>
41
42         * ravenscar-thread.c: Fix some typos.
43
44 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
45             Tom Tromey  <tromey@adacore.com>
46
47         * ada-lang.c (ada_exception_sal): Change addr_string to a
48         std::string.
49         (create_ada_exception_catchpoint): Update.
50
51 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
52             Tom Tromey  <tromey@adacore.com>
53
54         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
55         (bp_location_ops): Remove.
56         (base_breakpoint_allocate_location): Update.
57         (free_bp_location): Update.
58         * ada-lang.c (class ada_catchpoint_location)
59         <ada_catchpoint_location>: Remove ops parameter.
60         (ada_catchpoint_location_dtor): Remove.
61         (ada_catchpoint_location_ops): Remove.
62         (allocate_location_exception): Update.
63         * breakpoint.h (struct bp_location_ops): Remove.
64         (class bp_location) <bp_location>: Remove bp_location_ops
65         parameter.
66         <~bp_location>: Add destructor.
67         <ops>: Remove.
68
69 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
70             Pedro Alves  <palves@redhat.com>
71
72         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
73         'PATH_MAX'.
74
75 2019-02-14  David Michael  <fedora.dm0@gmail.com>
76             Samuel Thibault  <samuel.thibault@gnu.org>
77             Thomas Schwinge  <thomas@codesourcery.com>
78
79         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
80         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
81
82 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
83
84         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
85         (check_empty): Use "const char *".
86
87         * gnu-nat.c (gnu_nat_target::detach): Instead of
88         'detach_inferior (pid)' call
89         'detach_inferior (find_inferior_pid (pid))'.
90
91         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
92         'nat/fork-inferior.o'.
93         * gnu-nat.c: #include "nat/fork-inferior.h".
94
95         * gnu-nat.c (gnu_nat_target::detach): Instead of
96         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
97         * gnu-nat.h: #include "inf-child.h".
98         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
99         'i386_gnu_nat_target::fetch_registers'.
100         (gnu_store_registers): Rename/move to
101         'i386_gnu_nat_target::store_registers'.
102
103         * config/i386/nm-i386gnu.h: Don't "#include" any files.
104         * gnu-nat.h (mach_thread_info): New function.
105         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
106
107         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
108
109 2019-02-14  Frederic Konrad  <konrad@adacore.com>
110
111         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
112
113 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
114
115         * windows-nat.c (windows_add_thread): Add new parameter
116         "main_thread_p" with default value set to false.  Update
117         function documentation as well as all callers.
118         (windows_delete_thread): Likewise.
119         (fake_create_process): Update call to windows_add_thread.
120         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
121         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
122         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
123         call to windows_delete_thread.
124
125 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
126
127         * MAINTAINERS: Add Andrew Burgess as global maintainer.
128
129 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
130
131         * symfile.c (find_separate_debug_file): Use canonical path of
132         sysroot with child_path instead of gdb_sysroot if it is valid.
133
134 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
135
136         * symfile.c (find_separate_debug_file): Use child_path to
137         determine if an object file is under a sysroot.
138
139 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
140
141         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
142         unittests/child-path-selftests.c.
143         * common/pathstuff.c (child_path): New function.
144         * common/pathstuff.h (child_path): New prototype.
145         * unittests/child-path-selftests.c: New file.
146
147 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
148
149         * symfile.c (find_separate_debug_file): Look for separate debug
150         files in debug directories under the sysroot.
151
152 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
153
154         * symtab.h (struct minimal_symbol data_p): New const method.
155         (struct minimal_symbol text_p): Likewise.
156         * symtab.c (output_source_filename): Use file name style
157         to print file name.
158         (print_symbol_info): Likewise.
159         (print_msymbol_info): Use address style to print addresses.
160         Use function name style to print executable text symbols.
161         (expand_symtab_containing_pc): Use data_p.
162         (find_pc_sect_compunit_symtab): Likewise.
163
164 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
165
166         * breakpoint.c (describe_other_breakpoints): Use address style
167         to print addresses.
168         (say_where): Likewise.
169
170 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
171
172         * ada-typeprint.c (print_func_type): Print function name
173         style to print function name.
174         * c-typeprint.c (c_print_type_1): Likewise.
175
176 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
177
178         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
179         for execve.
180
181 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
182
183         * c-exp.y (direct_abs_decl): Use emplace_back to record the
184         type_stack.
185
186 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
187
188         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
189         TYPE_CODE_REF types.
190
191 2019-02-08  Jim Wilson  <jimw@sifive.com>
192
193         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
194         (riscv_linux_fregset): New.
195         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
196
197 2019-02-07  Tom Tromey  <tom@tromey.com>
198
199         * thread.c (thread_cancel_execution_command): Update.
200         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
201         methods.
202         (struct thread_fsm_ops): Remove.
203         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
204         (thread_fsm_should_stop, thread_fsm_return_value)
205         (thread_fsm_set_finished, thread_fsm_finished_p)
206         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
207         Don't declare.
208         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
209         * infrun.c (clear_proceed_status_thread)
210         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
211         (print_stop_event): Update.
212         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
213         Add constructor.
214         (step_command_fsm_ops): Remove.
215         (new_step_command_fsm): Remove.
216         (step_1): Update.
217         (step_command_fsm::should_stop): Rename from
218         step_command_fsm_should_stop.
219         (step_command_fsm::clean_up): Rename from
220         step_command_fsm_clean_up.
221         (step_command_fsm::do_async_reply_reason): Rename from
222         step_command_fsm_async_reply_reason.
223         (struct until_next_fsm): Inherit from thread_fsm.  Add
224         constructor.
225         (until_next_fsm_ops): Remove.
226         (new_until_next_fsm): Remove.
227         (until_next_fsm::should_stop): Rename from
228         until_next_fsm_should_stop.
229         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
230         (until_next_fsm::do_async_reply_reason): Rename from
231         until_next_fsm_async_reply_reason.
232         (struct finish_command_fsm): Inherit from thread_fsm.  Add
233         constructor.  Change type of breakpoint.
234         (finish_command_fsm_ops): Remove.
235         (new_finish_command_fsm): Remove.
236         (finish_command_fsm::should_stop): Rename from
237         finish_command_fsm_should_stop.
238         (finish_command_fsm::clean_up): Rename from
239         finish_command_fsm_clean_up.
240         (finish_command_fsm::return_value): Rename from
241         finish_command_fsm_return_value.
242         (finish_command_fsm::do_async_reply_reason): Rename from
243         finish_command_fsm_async_reply_reason.
244         (finish_command): Update.
245         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
246         Add constructor.
247         (call_thread_fsm_ops): Remove.
248         (call_thread_fsm::call_thread_fsm): Rename from
249         new_call_thread_fsm.
250         (call_thread_fsm::should_stop): Rename from
251         call_thread_fsm_should_stop.
252         (call_thread_fsm::should_notify_stop): Rename from
253         call_thread_fsm_should_notify_stop.
254         (run_inferior_call, call_function_by_hand_dummy): Update.
255         * cli/cli-interp.c (should_print_stop_to_console): Update.
256         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
257         Add constructor.  Change type of location_breakpoint,
258         caller_breakpoint.
259         (until_break_fsm_ops): Remove.
260         (new_until_break_fsm): Remove.
261         (until_break_fsm::should_stop): Rename from
262         until_break_fsm_should_stop.
263         (until_break_fsm::clean_up): Rename from
264         until_break_fsm_clean_up.
265         (until_break_fsm::do_async_reply_reason): Rename from
266         until_break_fsm_async_reply_reason.
267         (until_break_command): Update.
268         * thread-fsm.c: Remove.
269         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
270
271 2019-02-07  Tom Tromey  <tom@tromey.com>
272
273         * yy-remap.h: Add include guard.
274         * xtensa-tdep.h: Add include guard.
275         * xcoffread.h: Rename include guard.
276         * varobj-iter.h: Add include guard.
277         * tui/tui.h: Rename include guard.
278         * tui/tui-winsource.h: Rename include guard.
279         * tui/tui-wingeneral.h: Rename include guard.
280         * tui/tui-windata.h: Rename include guard.
281         * tui/tui-win.h: Rename include guard.
282         * tui/tui-stack.h: Rename include guard.
283         * tui/tui-source.h: Rename include guard.
284         * tui/tui-regs.h: Rename include guard.
285         * tui/tui-out.h: Rename include guard.
286         * tui/tui-layout.h: Rename include guard.
287         * tui/tui-io.h: Rename include guard.
288         * tui/tui-hooks.h: Rename include guard.
289         * tui/tui-file.h: Rename include guard.
290         * tui/tui-disasm.h: Rename include guard.
291         * tui/tui-data.h: Rename include guard.
292         * tui/tui-command.h: Rename include guard.
293         * tic6x-tdep.h: Add include guard.
294         * target/waitstatus.h: Rename include guard.
295         * target/wait.h: Rename include guard.
296         * target/target.h: Rename include guard.
297         * target/resume.h: Rename include guard.
298         * target-float.h: Rename include guard.
299         * stabsread.h: Add include guard.
300         * rs6000-tdep.h: Add include guard.
301         * riscv-fbsd-tdep.h: Add include guard.
302         * regformats/regdef.h: Rename include guard.
303         * record.h: Rename include guard.
304         * python/python.h: Rename include guard.
305         * python/python-internal.h: Rename include guard.
306         * python/py-stopevent.h: Rename include guard.
307         * python/py-ref.h: Rename include guard.
308         * python/py-record.h: Rename include guard.
309         * python/py-record-full.h: Rename include guard.
310         * python/py-record-btrace.h: Rename include guard.
311         * python/py-instruction.h: Rename include guard.
312         * python/py-events.h: Rename include guard.
313         * python/py-event.h: Rename include guard.
314         * procfs.h: Add include guard.
315         * proc-utils.h: Add include guard.
316         * p-lang.h: Add include guard.
317         * or1k-tdep.h: Rename include guard.
318         * observable.h: Rename include guard.
319         * nto-tdep.h: Rename include guard.
320         * nat/x86-linux.h: Rename include guard.
321         * nat/x86-linux-dregs.h: Rename include guard.
322         * nat/x86-gcc-cpuid.h: Add include guard.
323         * nat/x86-dregs.h: Rename include guard.
324         * nat/x86-cpuid.h: Rename include guard.
325         * nat/ppc-linux.h: Rename include guard.
326         * nat/mips-linux-watch.h: Rename include guard.
327         * nat/linux-waitpid.h: Rename include guard.
328         * nat/linux-ptrace.h: Rename include guard.
329         * nat/linux-procfs.h: Rename include guard.
330         * nat/linux-osdata.h: Rename include guard.
331         * nat/linux-nat.h: Rename include guard.
332         * nat/linux-namespaces.h: Rename include guard.
333         * nat/linux-btrace.h: Rename include guard.
334         * nat/glibc_thread_db.h: Rename include guard.
335         * nat/gdb_thread_db.h: Rename include guard.
336         * nat/gdb_ptrace.h: Rename include guard.
337         * nat/fork-inferior.h: Rename include guard.
338         * nat/amd64-linux-siginfo.h: Rename include guard.
339         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
340         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
341         * nat/aarch64-linux.h: Rename include guard.
342         * nat/aarch64-linux-hw-point.h: Rename include guard.
343         * mn10300-tdep.h: Add include guard.
344         * mips-linux-tdep.h: Add include guard.
345         * mi/mi-parse.h: Rename include guard.
346         * mi/mi-out.h: Rename include guard.
347         * mi/mi-main.h: Rename include guard.
348         * mi/mi-interp.h: Rename include guard.
349         * mi/mi-getopt.h: Rename include guard.
350         * mi/mi-console.h: Rename include guard.
351         * mi/mi-common.h: Rename include guard.
352         * mi/mi-cmds.h: Rename include guard.
353         * mi/mi-cmd-break.h: Rename include guard.
354         * m2-lang.h: Add include guard.
355         * location.h: Rename include guard.
356         * linux-record.h: Rename include guard.
357         * linux-nat.h: Add include guard.
358         * linux-fork.h: Add include guard.
359         * i386-darwin-tdep.h: Rename include guard.
360         * hppa-linux-offsets.h: Add include guard.
361         * guile/guile.h: Rename include guard.
362         * guile/guile-internal.h: Rename include guard.
363         * gnu-nat.h: Rename include guard.
364         * gdb-stabs.h: Rename include guard.
365         * frv-tdep.h: Add include guard.
366         * f-lang.h: Add include guard.
367         * event-loop.h: Add include guard.
368         * darwin-nat.h: Rename include guard.
369         * cp-abi.h: Rename include guard.
370         * config/sparc/nm-sol2.h: Rename include guard.
371         * config/nm-nto.h: Rename include guard.
372         * config/nm-linux.h: Add include guard.
373         * config/i386/nm-i386gnu.h: Rename include guard.
374         * config/djgpp/nl_types.h: Rename include guard.
375         * config/djgpp/langinfo.h: Rename include guard.
376         * compile/gcc-cp-plugin.h: Add include guard.
377         * compile/gcc-c-plugin.h: Add include guard.
378         * compile/compile.h: Rename include guard.
379         * compile/compile-object-run.h: Rename include guard.
380         * compile/compile-object-load.h: Rename include guard.
381         * compile/compile-internal.h: Rename include guard.
382         * compile/compile-cplus.h: Rename include guard.
383         * compile/compile-c.h: Rename include guard.
384         * common/xml-utils.h: Rename include guard.
385         * common/x86-xstate.h: Rename include guard.
386         * common/version.h: Rename include guard.
387         * common/vec.h: Rename include guard.
388         * common/tdesc.h: Rename include guard.
389         * common/selftest.h: Rename include guard.
390         * common/scoped_restore.h: Rename include guard.
391         * common/scoped_mmap.h: Rename include guard.
392         * common/scoped_fd.h: Rename include guard.
393         * common/safe-iterator.h: Rename include guard.
394         * common/run-time-clock.h: Rename include guard.
395         * common/refcounted-object.h: Rename include guard.
396         * common/queue.h: Rename include guard.
397         * common/ptid.h: Rename include guard.
398         * common/print-utils.h: Rename include guard.
399         * common/preprocessor.h: Rename include guard.
400         * common/pathstuff.h: Rename include guard.
401         * common/observable.h: Rename include guard.
402         * common/netstuff.h: Rename include guard.
403         * common/job-control.h: Rename include guard.
404         * common/host-defs.h: Rename include guard.
405         * common/gdb_wait.h: Rename include guard.
406         * common/gdb_vecs.h: Rename include guard.
407         * common/gdb_unlinker.h: Rename include guard.
408         * common/gdb_unique_ptr.h: Rename include guard.
409         * common/gdb_tilde_expand.h: Rename include guard.
410         * common/gdb_sys_time.h: Rename include guard.
411         * common/gdb_string_view.h: Rename include guard.
412         * common/gdb_splay_tree.h: Rename include guard.
413         * common/gdb_setjmp.h: Rename include guard.
414         * common/gdb_ref_ptr.h: Rename include guard.
415         * common/gdb_optional.h: Rename include guard.
416         * common/gdb_locale.h: Rename include guard.
417         * common/gdb_assert.h: Rename include guard.
418         * common/filtered-iterator.h: Rename include guard.
419         * common/filestuff.h: Rename include guard.
420         * common/fileio.h: Rename include guard.
421         * common/environ.h: Rename include guard.
422         * common/common-utils.h: Rename include guard.
423         * common/common-types.h: Rename include guard.
424         * common/common-regcache.h: Rename include guard.
425         * common/common-inferior.h: Rename include guard.
426         * common/common-gdbthread.h: Rename include guard.
427         * common/common-exceptions.h: Rename include guard.
428         * common/common-defs.h: Rename include guard.
429         * common/common-debug.h: Rename include guard.
430         * common/cleanups.h: Rename include guard.
431         * common/buffer.h: Rename include guard.
432         * common/btrace-common.h: Rename include guard.
433         * common/break-common.h: Rename include guard.
434         * cli/cli-utils.h: Rename include guard.
435         * cli/cli-style.h: Rename include guard.
436         * cli/cli-setshow.h: Rename include guard.
437         * cli/cli-script.h: Rename include guard.
438         * cli/cli-interp.h: Rename include guard.
439         * cli/cli-decode.h: Rename include guard.
440         * cli/cli-cmds.h: Rename include guard.
441         * charset-list.h: Add include guard.
442         * buildsym-legacy.h: Rename include guard.
443         * bfin-tdep.h: Add include guard.
444         * ax.h: Rename include guard.
445         * arm-linux-tdep.h: Add include guard.
446         * arm-fbsd-tdep.h: Add include guard.
447         * arch/xtensa.h: Rename include guard.
448         * arch/tic6x.h: Add include guard.
449         * arch/i386.h: Add include guard.
450         * arch/arm.h: Rename include guard.
451         * arch/arm-linux.h: Rename include guard.
452         * arch/arm-get-next-pcs.h: Rename include guard.
453         * arch/amd64.h: Add include guard.
454         * arch/aarch64-insn.h: Rename include guard.
455         * arch-utils.h: Rename include guard.
456         * annotate.h: Add include guard.
457         * amd64-darwin-tdep.h: Rename include guard.
458         * aarch64-linux-tdep.h: Add include guard.
459         * aarch64-fbsd-tdep.h: Add include guard.
460         * aarch32-linux-nat.h: Add include guard.
461
462 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
463
464         * macrotab.c (macro_define_internal): New function that
465         factorizes macro_define_object_internal and macro_define_function
466         code.
467         (macro_define_object_internal): Use macro_define_internal.
468         (macro_define_function): Likewise.
469
470 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
471
472         * macrocmd.c (extract_identifier): Return
473         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
474         callers.
475
476 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
477
478         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
479
480 2019-02-05  Tom Tromey  <tom@tromey.com>
481
482         * target.c (target_stack::unpush): Move assertion earlier.
483
484 2019-01-30  Tom Tromey  <tom@tromey.com>
485
486         PR python/23615:
487         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
488         (gdbpy_parse_and_eval): Likewise.
489         * python/python-internal.h (gdbpy_allow_threads): New class.
490
491 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
492
493         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
494         (aarch64_fbsd_fpregmap): Move earlier.
495         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
496         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
497         instead of individual calls to trad_frame_set_reg_addr.
498         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
499         earlier.
500         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
501         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
502         instead of individual calls to trad_frame_set_reg_addr.
503
504 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
505
506         * CONTRIBUTE: Replace contribution list with wiki link.
507
508 2019-01-25  Tom Tromey  <tom@tromey.com>
509
510         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
511
512 2019-01-25  Tom Tromey  <tom@tromey.com>
513
514         * xtensa-linux-nat.c: Fix common/ includes.
515         * xml-support.h: Fix common/ includes.
516         * xml-support.c: Fix common/ includes.
517         * x86-linux-nat.c: Fix common/ includes.
518         * windows-nat.c: Fix common/ includes.
519         * varobj.h: Fix common/ includes.
520         * varobj.c: Fix common/ includes.
521         * value.c: Fix common/ includes.
522         * valops.c: Fix common/ includes.
523         * utils.c: Fix common/ includes.
524         * unittests/xml-utils-selftests.c: Fix common/ includes.
525         * unittests/utils-selftests.c: Fix common/ includes.
526         * unittests/unpack-selftests.c: Fix common/ includes.
527         * unittests/tracepoint-selftests.c: Fix common/ includes.
528         * unittests/style-selftests.c: Fix common/ includes.
529         * unittests/string_view-selftests.c: Fix common/ includes.
530         * unittests/scoped_restore-selftests.c: Fix common/ includes.
531         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
532         * unittests/scoped_fd-selftests.c: Fix common/ includes.
533         * unittests/rsp-low-selftests.c: Fix common/ includes.
534         * unittests/parse-connection-spec-selftests.c: Fix common/
535         includes.
536         * unittests/optional-selftests.c: Fix common/ includes.
537         * unittests/offset-type-selftests.c: Fix common/ includes.
538         * unittests/observable-selftests.c: Fix common/ includes.
539         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
540         * unittests/memrange-selftests.c: Fix common/ includes.
541         * unittests/memory-map-selftests.c: Fix common/ includes.
542         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
543         * unittests/function-view-selftests.c: Fix common/ includes.
544         * unittests/environ-selftests.c: Fix common/ includes.
545         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
546         * unittests/common-utils-selftests.c: Fix common/ includes.
547         * unittests/cli-utils-selftests.c: Fix common/ includes.
548         * unittests/array-view-selftests.c: Fix common/ includes.
549         * ui-file.c: Fix common/ includes.
550         * tui/tui-io.c: Fix common/ includes.
551         * tracepoint.h: Fix common/ includes.
552         * tracepoint.c: Fix common/ includes.
553         * tracefile-tfile.c: Fix common/ includes.
554         * top.h: Fix common/ includes.
555         * top.c: Fix common/ includes.
556         * thread.c: Fix common/ includes.
557         * target/waitstatus.h: Fix common/ includes.
558         * target/waitstatus.c: Fix common/ includes.
559         * target.h: Fix common/ includes.
560         * target.c: Fix common/ includes.
561         * target-memory.c: Fix common/ includes.
562         * target-descriptions.c: Fix common/ includes.
563         * symtab.h: Fix common/ includes.
564         * symfile.c: Fix common/ includes.
565         * stap-probe.c: Fix common/ includes.
566         * spu-linux-nat.c: Fix common/ includes.
567         * sparc-nat.c: Fix common/ includes.
568         * source.c: Fix common/ includes.
569         * solib.c: Fix common/ includes.
570         * solib-target.c: Fix common/ includes.
571         * ser-unix.c: Fix common/ includes.
572         * ser-tcp.c: Fix common/ includes.
573         * ser-pipe.c: Fix common/ includes.
574         * ser-base.c: Fix common/ includes.
575         * selftest-arch.c: Fix common/ includes.
576         * s12z-tdep.c: Fix common/ includes.
577         * rust-exp.y: Fix common/ includes.
578         * rs6000-aix-tdep.c: Fix common/ includes.
579         * riscv-tdep.c: Fix common/ includes.
580         * remote.c: Fix common/ includes.
581         * remote-notif.h: Fix common/ includes.
582         * remote-fileio.h: Fix common/ includes.
583         * remote-fileio.c: Fix common/ includes.
584         * regcache.h: Fix common/ includes.
585         * regcache.c: Fix common/ includes.
586         * record-btrace.c: Fix common/ includes.
587         * python/python.c: Fix common/ includes.
588         * python/py-type.c: Fix common/ includes.
589         * python/py-inferior.c: Fix common/ includes.
590         * progspace.h: Fix common/ includes.
591         * producer.c: Fix common/ includes.
592         * procfs.c: Fix common/ includes.
593         * proc-api.c: Fix common/ includes.
594         * printcmd.c: Fix common/ includes.
595         * ppc-linux-nat.c: Fix common/ includes.
596         * parser-defs.h: Fix common/ includes.
597         * osdata.c: Fix common/ includes.
598         * obsd-nat.c: Fix common/ includes.
599         * nat/x86-linux.c: Fix common/ includes.
600         * nat/x86-linux-dregs.c: Fix common/ includes.
601         * nat/x86-dregs.h: Fix common/ includes.
602         * nat/x86-dregs.c: Fix common/ includes.
603         * nat/ppc-linux.c: Fix common/ includes.
604         * nat/mips-linux-watch.h: Fix common/ includes.
605         * nat/mips-linux-watch.c: Fix common/ includes.
606         * nat/linux-waitpid.c: Fix common/ includes.
607         * nat/linux-ptrace.h: Fix common/ includes.
608         * nat/linux-ptrace.c: Fix common/ includes.
609         * nat/linux-procfs.c: Fix common/ includes.
610         * nat/linux-personality.c: Fix common/ includes.
611         * nat/linux-osdata.c: Fix common/ includes.
612         * nat/linux-namespaces.c: Fix common/ includes.
613         * nat/linux-btrace.h: Fix common/ includes.
614         * nat/linux-btrace.c: Fix common/ includes.
615         * nat/fork-inferior.c: Fix common/ includes.
616         * nat/amd64-linux-siginfo.c: Fix common/ includes.
617         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
618         * nat/aarch64-linux.c: Fix common/ includes.
619         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
620         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
621         * namespace.h: Fix common/ includes.
622         * mips-linux-tdep.c: Fix common/ includes.
623         * minsyms.c: Fix common/ includes.
624         * mi/mi-parse.h: Fix common/ includes.
625         * mi/mi-main.c: Fix common/ includes.
626         * mi/mi-cmd-env.c: Fix common/ includes.
627         * memrange.h: Fix common/ includes.
628         * memattr.c: Fix common/ includes.
629         * maint.h: Fix common/ includes.
630         * maint.c: Fix common/ includes.
631         * main.c: Fix common/ includes.
632         * machoread.c: Fix common/ includes.
633         * location.c: Fix common/ includes.
634         * linux-thread-db.c: Fix common/ includes.
635         * linux-nat.c: Fix common/ includes.
636         * linux-fork.c: Fix common/ includes.
637         * inline-frame.c: Fix common/ includes.
638         * infrun.c: Fix common/ includes.
639         * inflow.c: Fix common/ includes.
640         * inferior.h: Fix common/ includes.
641         * inferior.c: Fix common/ includes.
642         * infcmd.c: Fix common/ includes.
643         * inf-ptrace.c: Fix common/ includes.
644         * inf-child.c: Fix common/ includes.
645         * ia64-linux-nat.c: Fix common/ includes.
646         * i387-tdep.c: Fix common/ includes.
647         * i386-tdep.c: Fix common/ includes.
648         * i386-linux-tdep.c: Fix common/ includes.
649         * i386-linux-nat.c: Fix common/ includes.
650         * i386-go32-tdep.c: Fix common/ includes.
651         * i386-fbsd-tdep.c: Fix common/ includes.
652         * i386-fbsd-nat.c: Fix common/ includes.
653         * guile/scm-type.c: Fix common/ includes.
654         * guile/guile.c: Fix common/ includes.
655         * go32-nat.c: Fix common/ includes.
656         * gnu-nat.c: Fix common/ includes.
657         * gdbthread.h: Fix common/ includes.
658         * gdbarch-selftests.c: Fix common/ includes.
659         * gdb_usleep.c: Fix common/ includes.
660         * gdb_select.h: Fix common/ includes.
661         * gdb_bfd.c: Fix common/ includes.
662         * gcore.c: Fix common/ includes.
663         * fork-child.c: Fix common/ includes.
664         * findvar.c: Fix common/ includes.
665         * fbsd-nat.c: Fix common/ includes.
666         * event-top.c: Fix common/ includes.
667         * event-loop.c: Fix common/ includes.
668         * dwarf2read.c: Fix common/ includes.
669         * dwarf2loc.c: Fix common/ includes.
670         * dwarf2-frame.c: Fix common/ includes.
671         * dwarf-index-cache.c: Fix common/ includes.
672         * dtrace-probe.c: Fix common/ includes.
673         * disasm-selftests.c: Fix common/ includes.
674         * defs.h: Fix common/ includes.
675         * csky-tdep.c: Fix common/ includes.
676         * cp-valprint.c: Fix common/ includes.
677         * cp-support.h: Fix common/ includes.
678         * cp-support.c: Fix common/ includes.
679         * corelow.c: Fix common/ includes.
680         * completer.h: Fix common/ includes.
681         * completer.c: Fix common/ includes.
682         * compile/compile.c: Fix common/ includes.
683         * compile/compile-loc2c.c: Fix common/ includes.
684         * compile/compile-cplus-types.c: Fix common/ includes.
685         * compile/compile-cplus-symbols.c: Fix common/ includes.
686         * command.h: Fix common/ includes.
687         * cli/cli-dump.c: Fix common/ includes.
688         * cli/cli-cmds.c: Fix common/ includes.
689         * charset.c: Fix common/ includes.
690         * build-id.c: Fix common/ includes.
691         * btrace.h: Fix common/ includes.
692         * btrace.c: Fix common/ includes.
693         * breakpoint.h: Fix common/ includes.
694         * breakpoint.c: Fix common/ includes.
695         * ax.h: 
696         (enum agent_op): Fix common/ includes.
697         * ax-general.c (struct aop_map): Fix common/ includes.
698         * ax-gdb.c: Fix common/ includes.
699         * auxv.c: Fix common/ includes.
700         * auto-load.c: Fix common/ includes.
701         * arm-tdep.c: Fix common/ includes.
702         * arch/riscv.c: Fix common/ includes.
703         * arch/ppc-linux-common.c: Fix common/ includes.
704         * arch/i386.c: Fix common/ includes.
705         * arch/arm.c: Fix common/ includes.
706         * arch/arm-linux.c: Fix common/ includes.
707         * arch/arm-get-next-pcs.c: Fix common/ includes.
708         * arch/amd64.c: Fix common/ includes.
709         * arch/aarch64.c: Fix common/ includes.
710         * arch/aarch64-insn.c: Fix common/ includes.
711         * arch-utils.c: Fix common/ includes.
712         * amd64-windows-tdep.c: Fix common/ includes.
713         * amd64-tdep.c: Fix common/ includes.
714         * amd64-sol2-tdep.c: Fix common/ includes.
715         * amd64-obsd-tdep.c: Fix common/ includes.
716         * amd64-nbsd-tdep.c: Fix common/ includes.
717         * amd64-linux-tdep.c: Fix common/ includes.
718         * amd64-linux-nat.c: Fix common/ includes.
719         * amd64-fbsd-tdep.c: Fix common/ includes.
720         * amd64-fbsd-nat.c: Fix common/ includes.
721         * amd64-dicos-tdep.c: Fix common/ includes.
722         * amd64-darwin-tdep.c: Fix common/ includes.
723         * agent.c: Fix common/ includes.
724         * ada-lang.h: Fix common/ includes.
725         * ada-lang.c: Fix common/ includes.
726         * aarch64-tdep.c: Fix common/ includes.
727
728 2019-01-25  Tom Tromey  <tom@tromey.com>
729
730         * common/create-version.sh: Use common/version.h.
731
732 2019-01-24  Pedro Alves  <palves@redhat.com>
733
734         * infrun.c (signal_stop, signal_print, signal_program)
735         (signal_catch, signal_pass): Now arrays instead of pointers.
736         (update_signals_program_target, do_target_resume)
737         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
738         * linux-nat.c (linux_nat_target::pass_signals)
739         (linux_nat_target::create_inferior, linux_nat_target::attach):
740         Adjust.
741         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
742         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
743         * procfs.c (procfs_target::pass_signals): Adjust.
744         * record-full.c (record_full_target::resume): Adjust.
745         * remote.c (remote_target::pass_signals)
746         (remote_target::program_signals): Adjust.
747         * target-debug.h (target_debug_print_signals): Now takes a
748         gdb::array_view as parameter.  Adjust.
749         * target.h (target_ops) <pass_signals, program_signals>: Replace
750         pointer and length parameters with gdb::array_view.
751         (target_pass_signals, target_program_signals): Likewise.
752         * target-delegates.c: Regenerate.
753
754 2019-01-24  Pedro Alves  <palves@redhat.com>
755
756         * common/forward-scope-exit.h
757         (forward_scope_exit::forward_scope_exit): Pass arguments to
758         m_bind_function directly, instead of creating a std::bind and
759         copying that.
760
761 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
762
763         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
764         for static members.
765         (pass_in_v_vfp_candidate): Likewise.
766
767 2019-01-23  Tom Tromey  <tom@tromey.com>
768             Pedro Alves  <palves@redhat.com>
769
770         * regcache.c (class regcache_invalidator): Remove.
771         (regcache::raw_write): Use make_scope_exit.
772
773 2019-01-23  Tom Tromey  <tom@tromey.com>
774
775         * ui-out.h (class ui_out_emit_type): Update comment.
776
777 2019-01-23  Tom Tromey  <tom@tromey.com>
778
779         * infrun.c (fetch_inferior_event): Update comment.
780
781 2019-01-23  Tom Tromey  <tom@tromey.com>
782             Pedro Alves  <palves@redhat.com>
783
784         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
785         parameter.
786         (fetch_inferior_event): Use SCOPE_EXIT.
787
788
789 2019-01-23  Tom Tromey  <tom@tromey.com>
790             Pedro Alves  <palves@redhat.com>
791
792         * infrun.c (disable_thread_events): Delete.
793         (stop_all_threads): Use SCOPE_EXIT.
794
795 2019-01-23  Tom Tromey  <tom@tromey.com>
796             Pedro Alves  <palves@redhat.com>
797
798         * symfile.c: Include forward-scope-exit.h.
799         (clear_symtab_users_cleanup): Replace forward declaration with
800         a FORWARD_SCOPE_EXIT.
801         (syms_from_objfile_1): Use the forward_scope_exit and
802         gdb::optional instead of cleanup_function.
803         (reread_symbols): Use the forward_scope_exit instead of
804         cleanup_function.
805         (clear_symtab_users_cleanup): Remove function.
806
807 2019-01-23  Tom Tromey  <tom@tromey.com>
808             Pedro Alves  <palves@redhat.com>
809
810         * linux-nat.c: Include scope-exit.h.
811         (cleanup_target_stop): Remove.
812         (linux_nat_target::static_tracepoint_markers_by_strid): Use
813         SCOPE_EXIT.
814
815 2019-01-23  Tom Tromey  <tom@tromey.com>
816             Pedro Alves  <palves@redhat.com>
817
818         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
819         (call_function_by_hand_dummy): Use SCOPE_EXIT.
820
821 2019-01-23  Tom Tromey  <tom@tromey.com>
822             Andrew Burgess  <andrew.burgess@embecosm.com>
823             Pedro Alves  <palves@redhat.com>
824
825         * infrun.c (fetch_inferior_event): Use scope_exit.
826         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
827         * top.c (execute_command): Use scope_exit.
828         * breakpoint.c (bpstat_do_actions): Use scope_exit.
829         * utils.c (do_bpstat_clear_actions_cleanup)
830         (make_bpstat_clear_actions_cleanup): Remove.
831
832 2019-01-23  Tom Tromey  <tom@tromey.com>
833             Pedro Alves  <palves@redhat.com>
834
835         * infrun.c: Include "common/scope-exit.h"
836         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
837         (wait_for_inferior): Use SCOPE_EXIT.
838         (fetch_inferior_event): Use scope_exit.
839
840 2019-01-23  Tom Tromey  <tom@tromey.com>
841             Pedro Alves  <palves@redhat.com>
842
843         * breakpoint.c (create_breakpoint): Remove cleanup.
844
845 2019-01-23  Tom Tromey  <tom@tromey.com>
846             Andrew Burgess  <andrew.burgess@embecosm.com>
847             Pedro Alves  <palves@redhat.com>
848
849 2019-01-23  Pedro Alves  <palves@redhat.com>
850
851         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
852
853 2019-01-23  Pedro Alves  <palves@redhat.com>
854             Andrew Burgess  <andrew.burgess@embecosm.com>
855
856         * gdbthread.h: Include "common/forward-scope-exit.h".
857         (scoped_finish_thread_state): Redefine custom class in terms of
858         forward_scope_exit.
859
860 2019-01-23  Pedro Alves  <palves@redhat.com>
861             Andrew Burgess  <andrew.burgess@embecosm.com>
862
863         * common/forward-scope-exit.h: New file.
864
865 2019-01-23  Pedro Alves  <palves@redhat.com>
866             Andrew Burgess  <andrew.burgess@embecosm.com>
867             Tom Tromey  <tom@tromey.com>
868
869         * common/scope-exit.h: New file.
870
871 2019-01-23  Pedro Alves  <palves@redhat.com>
872
873         * common/preprocessor.h (ESC): Rename to ...
874         (ESC_PARENS): ... this.
875         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
876         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
877
878 2019-01-23  Tom Tromey  <tom@tromey.com>
879
880         * language.h (class scoped_switch_to_sym_language_if_auto):
881         Initialize m_lang in both cases.
882
883 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
884
885         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
886         with XCNEW.
887
888 2019-01-22  Tom Tromey  <tom@tromey.com>
889
890         * corelow.c: Do not include sys/file.h.
891
892 2019-01-22  Tom Tromey  <tom@tromey.com>
893
894         * tui/tui-wingeneral.h: Include gdb_curses.h.
895
896 2019-01-22  Tom Tromey  <tom@tromey.com>
897
898         * source-cache.h (class source_cache) <get_source_lines,
899         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
900
901 2019-01-22  Tom Tromey  <tom@tromey.com>
902
903         * remote-fileio.h (struct remote_target): Declare.
904
905 2019-01-22  Tom Tromey  <tom@tromey.com>
906
907         * python/py-arch.c: Do not include py-ref.h.
908         * python/py-bpevent.c: Do not include py-ref.h.
909         * python/py-cmd.c: Do not include py-ref.h.
910         * python/py-continueevent.c: Do not include py-ref.h.
911         * python/py-event.h: Do not include py-ref.h.
912         * python/py-evtregistry.c: Do not include py-ref.h.
913         * python/py-finishbreakpoint.c: Do not include py-ref.h.
914         * python/py-frame.c: Do not include py-ref.h.
915         * python/py-framefilter.c: Do not include py-ref.h.
916         * python/py-function.c: Do not include py-ref.h.
917         * python/py-infevents.c: Do not include py-ref.h.
918         * python/py-linetable.c: Do not include py-ref.h.
919         * python/py-objfile.c: Do not include py-ref.h.
920         * python/py-param.c: Do not include py-ref.h.
921         * python/py-prettyprint.c: Do not include py-ref.h.
922         * python/py-progspace.c: Do not include py-ref.h.
923         * python/py-symbol.c: Do not include py-ref.h.
924         * python/py-symtab.c: Do not include py-ref.h.
925         * python/py-type.c: Do not include py-ref.h.
926         * python/py-unwind.c: Do not include py-ref.h.
927         * python/py-utils.c: Do not include py-ref.h.
928         * python/py-value.c: Do not include py-ref.h.
929         * python/py-varobj.c: Do not include py-ref.h.
930         * python/py-xmethods.c: Do not include py-ref.h.
931         * python/python.c: Do not include py-ref.h.
932         * varobj.c: Do not include py-ref.h.
933
934 2019-01-22  Tom Tromey  <tom@tromey.com>
935
936         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
937         keyword for bcache.
938
939 2019-01-22  Tom Tromey  <tom@tromey.com>
940
941         * compile/compile-cplus-types.c: Remove a comment by #include.
942
943 2019-01-22  Tom Tromey  <tom@tromey.com>
944
945         * compile/gcc-c-plugin.h: Include compile-internal.h.
946
947 2019-01-22  Tom Tromey  <tom@tromey.com>
948
949         * stabsread.c (EXTERN): Do not define.
950         (symnum, next_symbol_text_func, processing_gcc_compilation)
951         (within_function, global_sym_chain, global_stabs)
952         (previous_stab_code, this_object_header_files)
953         (n_this_object_header_files)
954         (n_allocated_this_object_header_files): Define.
955         * stabsread.h (EXTERN): Never define.  Use "extern".
956
957 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
958
959         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
960         history_value.
961
962 2019-01-21  Tom Tromey  <tom@tromey.com>
963
964         * ui-out.c: Fix includes.
965         * tui/tui-source.c: Fix includes.
966         * target.c: Fix includes.
967         * remote.c: Fix includes.
968         * regcache.c: Fix includes.
969         * python/py-block.c: Fix includes.
970         * printcmd.c: Fix includes.
971         * or1k-tdep.c: Fix includes.
972         * mi/mi-main.c: Fix includes.
973         * m32r-tdep.c: Fix includes.
974         * csky-tdep.c: Fix includes.
975         * compile/compile-cplus-types.c: Fix includes.
976         * cli/cli-interp.c: Fix includes.
977
978 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
979
980         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
981         for padding.
982
983 2019-01-16  Tom Tromey  <tom@tromey.com>
984
985         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
986         earlier.
987         (struct objfile) <msymbols_range>: Move from top level.
988         <msymbols>: New method.
989         (class objfile_msymbols): Remove.
990         * symtab.c (default_collect_symbol_completion_matches_break_on):
991         Update.
992         * symmisc.c (dump_msymbols): Update.
993         * stabsread.c (scan_file_globals): Update.
994         * objc-lang.c (info_selectors_command, info_classes_command)
995         (find_methods): Update.
996         * minsyms.c (find_solib_trampoline_target): Update.
997         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
998         * coffread.c (coff_symfile_read): Update.
999         * ada-lang.c (ada_lookup_simple_minsym)
1000         (ada_collect_symbol_completion_matches): Update.
1001
1002 2019-01-16  Tom Tromey  <tom@tromey.com>
1003
1004         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1005         type.  Remove no-argument constructor.
1006         <iterator::operator++>: Simplify.
1007         <begin>: Update.
1008         <end>: Use minimal_symbol_count.
1009
1010 2019-01-16  Tom Tromey  <tom@tromey.com>
1011
1012         * objfiles.h (struct objfile) <psymtabs>: New method.
1013         (class objfile_psymtabs): Remove.
1014         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1015         typedef.
1016         <range>: New method.
1017         (require_partial_symbols): Change return type.
1018         * psymtab.c (require_partial_symbols)
1019         (psym_expand_symtabs_matching): Update.
1020         * mdebugread.c (parse_partial_symbols): Update.
1021         * dbxread.c (dbx_end_psymtab): Update.
1022
1023 2019-01-15  Tom Tromey  <tom@tromey.com>
1024
1025         * symtab.c (lookup_objfile_from_block)
1026         (lookup_symbol_in_objfile_symtabs)
1027         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1028         (find_line_symtab, info_sources_command)
1029         (default_collect_symbol_completion_matches_break_on)
1030         (make_source_files_completion_list): Update.
1031         * symmisc.c (print_objfile_statistics, dump_objfile)
1032         (maintenance_print_symbols, maintenance_info_symtabs)
1033         (maintenance_check_symtabs, maintenance_info_line_tables):
1034         Update.
1035         * source.c (select_source_symtab)
1036         (forget_cached_source_info_for_objfile): Update.
1037         * objfiles.h (class objfile_compunits): Remove.
1038         (struct objfile) <compunits_range>: New typedef.
1039         (compunits): New method.
1040         * objfiles.c (objfile_relocate1): Update.
1041         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1042         * maint.c (count_symtabs_and_blocks): Update.
1043         * linespec.c (iterate_over_all_matching_symtabs): Update.
1044         * cp-support.c (add_symbol_overload_list_qualified): Update.
1045         * coffread.c (coff_symtab_read): Update.
1046         * ada-lang.c (add_nonlocal_symbols)
1047         (ada_collect_symbol_completion_matches)
1048         (ada_add_global_exceptions): Update.
1049
1050 2019-01-15  Tom Tromey  <tom@tromey.com>
1051
1052         * progspace.h (program_space) <objfiles_safe_range>: New
1053         typedef.
1054         <objfiles_safe>: New method.
1055         * objfiles.h (class all_objfiles_safe): Remove.
1056         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1057         * jit.c (jit_inferior_exit_hook): Update.
1058
1059 2019-01-17  Tom Tromey  <tom@tromey.com>
1060
1061         * progspace.h (program_space) <objfiles_range>: New typedef.
1062         <objfiles>: New method.
1063         <objfiles_head>: Rename from objfiles.
1064         (object_files): Update.
1065         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1066         * guile/scm-pretty-print.c
1067         (ppscm_find_pretty_printer_from_objfiles): Update.
1068         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1069         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1070         Update.
1071         * python/py-progspace.c (pspy_get_objfiles): Update.
1072         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1073         Update.
1074         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1075         (objfpy_lookup_objfile_by_build_id): Update.
1076         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1077         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1078         Update.
1079         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1080         (expand_symtab_containing_pc, lookup_objfile_from_block)
1081         (lookup_static_symbol, basic_lookup_transparent_type)
1082         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1083         (find_line_symtab, info_sources_command)
1084         (default_collect_symbol_completion_matches_break_on)
1085         (make_source_files_completion_list, find_main_name): Update.
1086         * symmisc.c (print_symbol_bcache_statistics)
1087         (print_objfile_statistics, maintenance_print_symbols)
1088         (maintenance_print_msymbols, maintenance_print_objfiles)
1089         (maintenance_info_symtabs, maintenance_check_symtabs)
1090         (maintenance_expand_symtabs, maintenance_info_line_tables):
1091         Update.
1092         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1093         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1094         (map_overlay_command, unmap_overlay_command)
1095         (simple_overlay_update, expand_symtabs_matching)
1096         (map_symbol_filenames): Update.
1097         * symfile-debug.c (set_debug_symfile): Update.
1098         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1099         Update.
1100         * source.c (select_source_symtab, forget_cached_source_info):
1101         Update.
1102         * solib.c (solib_read_symbols): Update.
1103         * solib-spu.c (append_ocl_sos): Update.
1104         * psymtab.c (maintenance_print_psymbols)
1105         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1106         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1107         * printcmd.c (info_symbol_command): Update.
1108         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1109         Update.
1110         * objfiles.h (class all_objfiles): Remove.
1111         * objfiles.c (have_partial_symbols, have_full_symbols)
1112         (have_minimal_symbols, qsort_cmp, update_section_map)
1113         (shared_objfile_contains_address_p)
1114         (default_iterate_over_objfiles_in_search_order): Update.
1115         * objc-lang.c (info_selectors_command, info_classes_command)
1116         (find_methods): Update.
1117         * minsyms.c (find_solib_trampoline_target): Update.
1118         * maint.c (maintenance_info_sections)
1119         (maintenance_translate_address, count_symtabs_and_blocks):
1120         Update.
1121         * main.c (captured_main_1): Update.
1122         * linux-thread-db.c (try_thread_db_load_from_pdir)
1123         (has_libpthread): Update.
1124         * linespec.c (iterate_over_all_matching_symtabs)
1125         (search_minsyms_for_name): Update.
1126         * jit.c (jit_find_objf_with_entry_addr): Update.
1127         * hppa-tdep.c (find_unwind_entry)
1128         (hppa_lookup_stub_minimal_symbol): Update.
1129         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1130         Update.
1131         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1132         (elf_gnu_ifunc_resolve_by_got): Update.
1133         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1134         * dwarf-index-write.c (save_gdb_index_command): Update.
1135         * cp-support.c (add_symbol_overload_list_qualified): Update.
1136         * breakpoint.c (create_overlay_event_breakpoint)
1137         (create_longjmp_master_breakpoint)
1138         (create_std_terminate_master_breakpoint)
1139         (create_exception_master_breakpoint): Update.
1140         * blockframe.c (find_pc_partial_function): Update.
1141         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1142         (ada_collect_symbol_completion_matches)
1143         (ada_add_global_exceptions): Update.
1144
1145 2019-01-17  Tom Tromey  <tom@tromey.com>
1146
1147         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1148         declare VEC.
1149         (solib_target_parse_libraries): Change return type.
1150         (library_list_start_segment, library_list_start_section)
1151         (library_list_end_library, library_list_start_library); Update.
1152         (solib_target_free_library_list): Remove.
1153         (solib_target_parse_libraries): Remove cleanup.  Change return
1154         type.
1155         (solib_target_current_sos): Update.
1156
1157 2019-01-17  Tom Tromey  <tromey@bapiya>
1158
1159         * valprint.c: Replace "the the" with "the".
1160         * symtab.c: Replace "the the" with "the".
1161         * solib.c: Replace "the the" with "the".
1162         * solib-dsbt.c: Replace "the the" with "the".
1163         * linespec.c: Replace "the the" with "the".
1164         * dwarf2loc.h: Replace "the the" with "the".
1165         * amd64-windows-tdep.c: Replace "the the" with "the".
1166         * aarch64-tdep.c: Replace "the the" with "the".
1167
1168 2019-01-16  Keith Seitz  <keiths@redhat.com>
1169
1170         PR gdb/23773
1171         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1172         <builder>: Rename to ..
1173         <m_builder>: ... this and make private.
1174         (dwarf2_cu::get_builder): New method.  Change all users of
1175         `builder' to use this method.
1176         (dwarf2_start_symtab): Move to ...
1177         (dwarf2_cu::start_symtab): ... here.  Update all callers
1178         (setup_type_unit_groups): Move to ...
1179         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1180         callers.
1181         (dwarf2_cu::reset_builder): New method.
1182         (process_full_compunit, process_full_type_unit): Use
1183         dwarf2_cu::reset_builder.
1184         (follow_die_offset): Record the ancestor CU if it is different
1185         from the followed DIE's CU.
1186         (follow_die_sig_1): Likewise.
1187
1188 2019-01-15  Tom Tromey  <tom@tromey.com>
1189
1190         * remote.c (class remote_state) <buf>: Now a char_vector.
1191         <buf_size>: Remove.
1192         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1193         parameter.
1194         (remote_target::getpkt_or_notif_sane_1)
1195         (remote_target::getpkt_sane)
1196         (remote_target::getpkt_or_notif_sane): Likewise.
1197         (class remote_target) <putpkt>: New overload.
1198         (remote_target::read_frame): Change type of "buf_p".  Remove
1199         sizeof_p parameter.
1200         (packet_ok): New overload.
1201         (packet_check_result): New overload.
1202         Update all uses.
1203
1204 2019-01-14  Tom Tromey  <tom@tromey.com>
1205
1206         * remote-notif.c (handle_notification, remote_notif_ack)
1207         (remote_notif_parse): Make "buf" const.
1208         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1209         const.
1210         (remote_notif_parse, remote_notif_ack, handle_notification):
1211         Likewise.
1212         * remote.c (remote_notif_stop_parse): Make "buf" const.
1213         (remote_target::remote_parse_stop_reply): Make "buf" const.
1214         (remote_notif_stop_ack): Make "buf" const.
1215
1216 2019-01-14  Tom Tromey  <tom@tromey.com>
1217
1218         * remote.c (remote_console_output): Make parameter const.
1219
1220 2019-01-14  Tom Tromey  <tom@tromey.com>
1221
1222         * target-debug.h (target_debug_print_signals): Constify.
1223         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1224         * procfs.c (procfs_target::pass_signals): Update.
1225         * linux-nat.c (linux_nat_target::pass_signals): Update.
1226         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1227         * target-delegates.c: Rebuild.
1228         * remote.c (remote_target::program_signals): Update.
1229         (remote_target::pass_signals): Update.
1230         * target.c (target_pass_signals): Constify argument.
1231         (target_program_signals): Likewise.
1232         * target.h (struct target_ops) <pass_signals, program_signals>:
1233         Constify argument.
1234         (target_pass_signals, target_program_signals): Constify argument.
1235
1236 2019-01-14  Tom Tromey  <tom@tromey.com>
1237
1238         PR tui/28819:
1239         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1240
1241 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1242
1243         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1244         field.
1245         * rs6000-tdep.c: Include reggroups.h.
1246         (IS_V_ALIAS_PSEUDOREG): Define.
1247         (rs6000_register_name): Return names for the "vX" aliases.
1248         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1249         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1250         aliases.  Call default_register_reggroup_p for all other
1251         pseudo-registers.
1252         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1253         New functions.
1254         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1255         Handle "vX" aliases.
1256         (v_alias_pseudo_register_collect): New function.
1257         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1258         (rs6000_gdbarch_init): Initialize "vX" aliases as
1259         pseudo-registers.  Restore registration of
1260         rs6000_pseudo_register_reggroup_p with
1261         set_tdesc_pseudo_register_reggroup_p.
1262
1263 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1264
1265         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1266         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1267         set_gdbarch_num_pseudo_regs.
1268
1269 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1270
1271         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1272         Remove arg prefixname, add do_set and do_show.
1273         Add member functions set_list and show_list.
1274         * cli/cli-style.c (class cli_style_option): Update accordingly.
1275         (style_set_list): Move to file scope.
1276         (style_show_list): Likewise.
1277         (set_style): Call help_list.
1278         (show_style): Call cmd_show_list.
1279         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1280         Update to use the new macro.
1281
1282 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1283
1284         * ada-lang.c (_initialize_ada_language): Expand the help text
1285         for the "catch exception" command.
1286
1287 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1288
1289         * symtab.c (matching_obj_sections): Initialize obj,
1290         declare it closer to its usage.
1291
1292 2019-01-10  Tom Tromey  <tom@tromey.com>
1293
1294         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1295         (basic_inf_threads_range): Remove.
1296         (inf_threads_range, inf_non_exited_threads_range)
1297         (safe_inf_threads_range): Use next_adapter.
1298
1299 2019-01-10  Keith Seitz  <keiths@redhat.com>
1300
1301         PR gdb/23712
1302         PR symtab/23010
1303         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1304         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1305
1306 2019-01-10  Keith Seitz  <keiths@redhat.com>
1307
1308         PR gdb/23712
1309         PR symtab/23010
1310         * dictionary.c (pending_to_vector): Remove.
1311         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1312         Remove _1 suffix, replacing functions of the same name.  Update
1313         all callers.
1314         (dict_create_hashed, dict_create_hashed_expandable)
1315         (dict_create_linear, dict_create_linear_expandable, dict_free)
1316         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1317         Make functions static.
1318
1319 2019-01-10  Keith Seitz  <keiths@redhat.com>
1320
1321         PR gdb/23712
1322         PR symtab/23010
1323         * dictionary.h (struct dictionary): Replace declaration with
1324         multidictionary.
1325         (dict_create_hashed, dict_create_hashed_expandable)
1326         (dict_create_linear, dict_create_linear_expandable)
1327         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1328         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1329         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1330         taking multidictionary argument.
1331         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1332         * block.h (struct block) <dict>: Change to multidictionary
1333         and rename `multidict'.
1334         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1335         symmisc.c: Update all dictionary references to multidictionary.
1336
1337 2019-01-10  Keith Seitz  <keiths@redhat.com>
1338
1339         PR gdb/23712
1340         PR symtab/23010
1341         * dictionary.c: Include unordered_map.
1342         (pending_to_vector): New function.
1343         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1344         Rewrite the non-"_1" functions to take vector instead
1345         of linked list.
1346         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1347         "new" _1 versions of the same name.
1348         (multidictionary): Define.
1349         (std::hash<enum language): New definition.
1350         (collate_pending_symbols_by_language, mdict_create_hashed)
1351         (mdict_create_hashed_expandable, mdict_create_linear)
1352         (mdict_create_linear_expandable, mdict_free)
1353         (find_language_dictionary, create_new_language_dictionary)
1354         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1355         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1356         (mdict_size, mdict_empty): New functions.
1357         * dictionary.h (mdict_iterator): Define.
1358
1359 2019-01-10  Pedro Alves  <palves@redhat.com>
1360
1361         * breakpoint.c (read_uploaded_action)
1362         (create_tracepoint_from_upload): Adjust to use
1363         gdb::unique_xmalloc_ptr.
1364         * ctf.c (ctf_write_uploaded_tp):
1365         (SET_ARRAY_FIELD): Use emplace_back.
1366         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1367         * tracefile-tfile.c (tfile_write_uploaded_tp):
1368         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1369         gdb::unique_xmalloc_ptr.
1370         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1371         at_string, cond_string, cmd_strings>: Replace char pointers
1372         with gdb::unique_xmalloc_ptr.
1373
1374 2019-01-10  Pedro Alves  <palves@redhat.com>
1375
1376         * solib-target.c (library_list_start_library): Don't xstrdup name.
1377
1378 2019-01-10  Pedro Alves  <palves@redhat.com>
1379
1380         * mdebugread.c (parse_partial_symbols): Use
1381         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1382
1383 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1384
1385         * linux-fork.c (scoped_switch_fork_info)
1386         <~scoped_switch_fork_info>: Fix incorrect variable name.
1387
1388 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1389
1390         * linux-fork.c (scoped_switch_fork_info)
1391         <scoped_switch_fork_info>: Make explicit.
1392         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1393
1394 2019-01-10  Tom Tromey  <tom@tromey.com>
1395
1396         * objfiles.h (objfile::reset_psymtabs): Update.
1397         * objfiles.c (objfile::objfile): Update.
1398         * psymtab.h (psymtab_storage::obstack): Update.
1399         (psymtab_storage::m_obstack): Use gdb::optional.
1400         (class psymtab_storage): Update comment.  Remove objfile
1401         parameter.
1402         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1403
1404 2019-01-10  Tom Tromey  <tom@tromey.com>
1405
1406         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1407         <free_psymtabs>: Now private.
1408         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1409         (allocate_psymtab): Use new method.
1410
1411 2019-01-10  Tom Tromey  <tom@tromey.com>
1412
1413         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1414         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1415         * mdebugread.c (parse_partial_symbols): Use
1416         allocate_dependencies.
1417         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1418         allocate_dependencies.
1419         (process_psymtab_comp_unit_reader)
1420         (build_type_psymtab_dependencies): Likewise.
1421         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1422
1423 2019-01-10  Tom Tromey  <tom@tromey.com>
1424
1425         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1426         PSYMBOL_SET_LANGUAGE.
1427         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1428
1429 2019-01-10  Tom Tromey  <tom@tromey.com>
1430
1431         * psymtab.h (psymtab_storage::obstack): New method.
1432         <m_obstack>: Rename from obstack; now private.
1433         * psymtab.c (psymtab_storage): Update.
1434         * dwarf2read.c (create_addrmap_from_index)
1435         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1436         Update.
1437
1438 2019-01-10  Tom Tromey  <tom@tromey.com>
1439
1440         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1441         * objfiles.h (objfile::reset_psymtabs): New method.
1442
1443 2019-01-10  Tom Tromey  <tom@tromey.com>
1444
1445         * symmisc.c (print_symbol_bcache_statistics): Update.
1446         (print_objfile_statistics): Update.
1447         * symfile.c (reread_symbols): Update.
1448         * psymtab.h (class psymtab_storage): New.
1449         * psymtab.c (psymtab_storage): New constructor.
1450         (~psymtab_storage): New destructor.
1451         (require_partial_symbols): Update.
1452         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1453         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1454         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1455         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1456         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1457         (start_psymtab_common, end_psymtab_common)
1458         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1459         (allocate_psymtab): Update.
1460         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1461         Update.
1462         (dump_psymtab_addrmap, maintenance_print_psymbols)
1463         (maintenance_check_psymtabs): Update.
1464         (class objfile_psymtabs): Move to objfiles.h.
1465         * psympriv.h (discard_psymtab): Now inline.
1466         (psymtab_discarder::psymtab_discarder): Update.
1467         (psymtab_discarder::~psymtab_discarder): Update.
1468         (ALL_OBJFILE_PSYMTABS): Rewrite.
1469         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1470         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1471         Remove fields.
1472         <partial_symtabs>: New field.
1473         (class objfile_psymtabs): Move from psymtab.h.  Update.
1474         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1475         psymbol_cache.
1476         (objfile::~objfile): Don't destroy psymbol_cache.
1477         * mdebugread.c (parse_partial_symbols): Update.
1478         * dwarf2read.c (create_addrmap_from_index)
1479         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1480         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1481         (add_partial_subprogram, dwarf2_ranges_read): Update.
1482         * dwarf-index-write.c (write_address_map)
1483         (write_one_signatured_type, recursively_write_psymbols)
1484         (class debug_names, class debug_names, write_psymtabs_to_index):
1485         Update.
1486
1487 2019-01-10  Tom Tromey  <tom@tromey.com>
1488
1489         * symtab.h (SYMBOL_SET_NAMES): Update.
1490         (symbol_set_names): Update.
1491         (MSYMBOL_SET_NAMES): Update.
1492         * symtab.c (symbol_set_names): Change argument to be an
1493         objfile_per_bfd_storage.
1494         * psymtab.c (add_psymbol_to_bcache): Update.
1495         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1496
1497 2019-01-10  Tom Tromey  <tom@tromey.com>
1498
1499         * symtab.c (create_demangled_names_hash): Change argument to be an
1500         objfile_per_bfd_storage.
1501         (symbol_set_names): Update.
1502
1503 2019-01-10  Tom Tromey  <tom@tromey.com>
1504
1505         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1506         init_psymbol_list.
1507         * psymtab.c (init_psymbol_list): Do nothing if already called.
1508         * psympriv.h (init_psymbol_list): Add comment.
1509         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1510         init_psymbol_list.
1511         * dbxread.c (dbx_symfile_read): Unconditionally call
1512         init_psymbol_list.
1513
1514 2019-01-10  Tom Tromey  <tom@tromey.com>
1515
1516         * xcoffread.c (scan_xcoff_symtab): Update.
1517         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1518         "where".
1519         * mdebugread.c (parse_partial_symbols)
1520         (handle_psymbol_enumerators): Update.
1521         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1522         * dbxread.c (read_dbx_symtab): Update.
1523         * psympriv.h (psymbol_placement): New enum.
1524         (add_psymbol_to_list): Update.
1525
1526 2019-01-10  Tom Tromey  <tom@tromey.com>
1527
1528         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1529         static_psymbols parameters.
1530         (scan_xcoff_symtab): Update.
1531         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1532         static_psymbols parameters.
1533         * psympriv.h (start_psymtab_common): Update.
1534         * mdebugread.c (parse_partial_symbols): Update.
1535         * dwarf2read.c (create_partial_symtab): Update.
1536         * dbxread.c (read_dbx_symtab): Update.
1537         (start_psymtab): Remove global_psymbols and static_psymbols
1538         parameters.
1539
1540 2019-01-10  Tom Tromey  <tom@tromey.com>
1541
1542         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1543         * psymtab.c (allocate_psymtab): Add comment.
1544         * psympriv.h (allocate_psymtab): Add comment.
1545         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1546         initializations.
1547         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1548
1549 2019-01-10  Tom Tromey  <tom@tromey.com>
1550
1551         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1552         Don't declare.
1553         * mipsread.c: Include mdebugread.h.
1554         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1555         Declare.
1556         * elfread.c: Include mdebugread.h.
1557
1558 2019-01-09  Tom Tromey  <tom@tromey.com>
1559
1560         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1561         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1562         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1563         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1564         (psym_lookup_symbol, psym_find_last_source_symtab)
1565         (psym_forget_cached_source_info, psym_print_stats)
1566         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1567         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1568         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1569         (psym_find_compunit_symtab_by_address)
1570         (maintenance_print_psymbols, maintenance_info_psymtabs)
1571         (maintenance_check_psymtabs): Use ranged for.
1572         * psymtab.h (class objfile_psymtabs): New.
1573         (require_partial_symbols): Return objfile_psymtabs.
1574         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1575
1576 2019-01-09  Tom Tromey  <tom@tromey.com>
1577
1578         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1579         (find_pc_mapped_section, list_overlays_command)
1580         (map_overlay_command, unmap_overlay_command)
1581         (simple_overlay_update): Use all_objfiles.
1582         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1583         * printcmd.c (info_symbol_command): Use all_objfiles.
1584         * objfiles.h (ALL_OBJSECTIONS): Remove.
1585         * maint.c (maintenance_translate_address): Use all_objfiles.
1586         * gcore.c (gcore_create_callback): Use all_objfiles.
1587         (objfile_find_memory_regions): Likewise.
1588
1589 2019-01-09  Tom Tromey  <tom@tromey.com>
1590
1591         * symtab.c (find_line_symtab, info_sources_command)
1592         (make_source_files_completion_list): Use objfile_compunits.
1593         * source.c (select_source_symtab): Use objfile_compunits.
1594         * objfiles.h (struct objfile): Update comment.
1595         (ALL_OBJFILES): Remove.
1596         (ALL_FILETABS): Remove.
1597         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1598         objfile_compunits.
1599
1600 2019-01-09  Tom Tromey  <tom@tromey.com>
1601
1602         * symmisc.c (print_objfile_statistics, dump_objfile)
1603         (maintenance_print_symbols): Use compunit_filetabs.
1604         * source.c (forget_cached_source_info_for_objfile): Use
1605         compunit_filetabs.
1606         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1607         (ALL_FILETABS): Use compunit_filetabs.
1608         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1609         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1610
1611 2019-01-09  Tom Tromey  <tom@tromey.com>
1612
1613         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1614         (compunit_filetabs): New.
1615         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1616         compunit_filetabs.
1617         (info_sources_command, make_source_files_completion_list): Remove
1618         declaration.
1619         * symmisc.c (print_objfile_statistics, dump_objfile)
1620         (maintenance_print_symbols): Remove declaration.
1621         (maintenance_info_symtabs): Use compunit_filetabs.
1622         (maintenance_info_line_tables): Likewise.
1623         * source.c (select_source_symtab): Change local variable name.
1624         (forget_cached_source_info_for_objfile): Remove declaration.
1625         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1626         * objfiles.c (objfile_relocate1): Remove declaration.
1627         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1628         declaration.
1629         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1630         * coffread.c (coff_symtab_read): Remove declaration.
1631         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1632         compunit_filetabs.
1633
1634 2019-01-09  Tom Tromey  <tom@tromey.com>
1635
1636         * symtab.c (lookup_objfile_from_block)
1637         (find_pc_sect_compunit_symtab, search_symbols)
1638         (default_collect_symbol_completion_matches_break_on): Use
1639         objfile_compunits.
1640         * objfiles.h (ALL_COMPUNITS): Remove.
1641         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1642         * cp-support.c (add_symbol_overload_list_qualified): Use
1643         objfile_compunits.
1644         * ada-lang.c (ada_collect_symbol_completion_matches)
1645         (ada_add_global_exceptions): Use objfile_compunits.
1646
1647 2019-01-09  Tom Tromey  <tom@tromey.com>
1648
1649         * source.c (select_source_symtab)
1650         (forget_cached_source_info_for_objfile): Remove declaration.
1651         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1652         declaration.
1653         * maint.c (count_symtabs_and_blocks): Remove declaration.
1654         * cp-support.c (add_symbol_overload_list_qualified): Remove
1655         declaration.
1656         * coffread.c (coff_symtab_read): Remove declaration.
1657         * symtab.c (lookup_symbol_in_objfile_symtabs)
1658         (basic_lookup_transparent_type_1): Use objfile_compunits.
1659         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1660         (info_sources_command, search_symbols)
1661         (default_collect_symbol_completion_matches_break_on)
1662         (make_source_files_completion_list): Remove declaration.
1663         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1664         (ada_collect_symbol_completion_matches)
1665         (ada_add_global_exceptions): Remove declaration.
1666         * linespec.c (iterate_over_all_matching_symtabs): Use
1667         objfile_compunits.
1668         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1669         (class objfile_compunits): New.
1670         (ALL_COMPUNITS): Use objfile_compunits.
1671         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1672         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1673         objfile_compunits.
1674         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1675
1676 2019-01-09  Tom Tromey  <tom@tromey.com>
1677
1678         * symtab.c (search_symbols)
1679         (default_collect_symbol_completion_matches_break_on): Use
1680         objfile_msymbols.
1681         * ada-lang.c (ada_lookup_simple_minsym)
1682         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1683         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1684         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1685         objfile_msymbols.
1686         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1687         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1688         * objc-lang.c (find_methods): Use objfile_msymbols.
1689         (info_selectors_command, info_classes_command): Likewise.
1690         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1691         * objfiles.h (class objfile_msymbols): New.
1692         (ALL_OBJFILE_MSYMBOLS): Remove.
1693         (ALL_MSYMBOLS): Remove.
1694
1695 2019-01-09  Tom Tromey  <tom@tromey.com>
1696
1697         * common/next-iterator.h (next_adapter): Add Iterator template
1698         parameter.
1699         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1700         (class all_objfiles_safe): New.
1701         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1702         * objfiles.c (put_objfile_before): Update comment.
1703         (add_separate_debug_objfile): Likewise.
1704         (free_all_objfiles): Use all_objfiles_safe.
1705         (objfile_purge_solibs): Likewise.
1706
1707 2019-01-09  Tom Tromey  <tom@tromey.com>
1708
1709         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1710         (expand_symtab_containing_pc, lookup_static_symbol)
1711         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1712         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1713         all_objfiles.
1714         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1715         * breakpoint.c (create_overlay_event_breakpoint)
1716         (create_longjmp_master_breakpoint)
1717         (create_std_terminate_master_breakpoint)
1718         (create_exception_master_breakpoint): Use all_objfiles.
1719         * linux-thread-db.c (try_thread_db_load_from_pdir)
1720         (has_libpthread): Use all_objfiles.
1721         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1722         * linespec.c (iterate_over_all_matching_symtabs)
1723         (search_minsyms_for_name): Use all_objfiles.
1724         * maint.c (maintenance_info_sections): Use all_objfiles.
1725         * main.c (captured_main_1): Use all_objfiles.
1726         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1727         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1728         * guile/scm-pretty-print.c
1729         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1730         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1731         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1732         (maintenance_print_msymbols): Use all_objfiles.
1733         * source.c (select_source_symtab): Use all_objfiles.
1734         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1735         * symfile.c (remove_symbol_file_command)
1736         (expand_symtabs_matching, map_symbol_filenames): Use
1737         all_objfiles.
1738         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1739         all_objfiles.
1740         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1741         * objc-lang.c (find_methods): Use all_objfiles.
1742         * objfiles.c (have_partial_symbols, have_full_symbols)
1743         (have_minimal_symbols, qsort_cmp)
1744         (default_iterate_over_objfiles_in_search_order): Use
1745         all_objfiles.
1746         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1747         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1748         (maintenance_check_psymtabs): Use all_objfiles.
1749         (ALL_PSYMTABS): Remove.
1750         * compile/compile-object-run.c (do_module_cleanup): Use
1751         all_objfiles.
1752         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1753         * cp-support.c (add_symbol_overload_list_qualified): Use
1754         all_objfiles.
1755         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1756         Use all_objfiles.
1757         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1758         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1759         all_objfiles.
1760         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1761         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1762         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1763         Uses all_objfiles.
1764         * solib.c (solib_read_symbols): Use all_objfiles
1765
1766 2019-01-09  Tom Tromey  <tom@tromey.com>
1767
1768         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1769         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1770         all_objfiles.
1771         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1772         * symmisc.c (print_symbol_bcache_statistics)
1773         (print_objfile_statistics, maintenance_print_objfiles)
1774         (maintenance_info_symtabs, maintenance_check_symtabs)
1775         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1776         all_objfiles.
1777         * source.c (forget_cached_source_info): Use all_objfiles.
1778         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1779         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1780         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1781         * objfiles.c (update_section_map): Use all_objfiles.
1782         (shared_objfile_contains_address_p): Likewise.
1783         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1784         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1785
1786 2019-01-09  Tom Tromey  <tom@tromey.com>
1787
1788         * common/next-iterator.h: New file.
1789         * objfiles.h (class all_objfiles): New.
1790         (struct objfile_iterator): New.
1791
1792 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1793
1794         * NEWS: Move the description of the changed "frame", "select-frame",
1795          and "info frame" commands to the Changed commands section.
1796
1797 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1798
1799         * gdbtypes.c (check_stub_method_group): Remove handling of old
1800         mangling schemes.
1801         * linespec.c (find_methods): Likewise.
1802         * stabsread.c (read_member_functions): Likewise.
1803         * valops.c (search_struct_method): Likewise.
1804         (value_struct_elt_for_reference): Likewise.
1805         * NEWS: Mention this change.
1806
1807 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1808
1809         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1810         print_source_lines.
1811         * source.c (print_source_lines_base): Update line number check.
1812         (print_source_lines): New function.
1813         (source_lines_range::source_lines_range): New function.
1814         * source.h (class source_lines_range): New class.
1815         (print_source_lines): New declaration.
1816
1817 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1818
1819         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1820
1821 2019-01-08  Tom Tromey  <tom@tromey.com>
1822             Simon Marchi  <simon.marchi@ericsson.com>
1823
1824         PR gdb/24060
1825         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1826         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1827         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1828         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1829         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1830         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1831
1832 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1833
1834         * source.c (select_source_symtab): Move header comment to
1835         declaration in source.h.
1836         (forget_cached_source_info_for_objfile): Likewise.
1837         (forget_cached_source_info): Likewise.
1838         (identify_source_line): Likewise.
1839         * source.h (identify_source_line): Move declaration from symtab.h
1840         and add comment from source.c
1841         (print_source_lines): Likewise.
1842         (forget_cached_source_info_for_objfile): Likewise.
1843         (forget_cached_source_info): Likewise.
1844         (select_source_symtab): Likewise.
1845         (enum print_source_lines_flag): Move definition from symtab.h.
1846         * symtab.h (identify_source_line): Move declaration to source.h.
1847         (print_source_lines): Likewise.
1848         (forget_cached_source_info_for_objfile): Likewise.
1849         (forget_cached_source_info): Likewise.
1850         (select_source_symtab): Likewise.
1851         (enum print_source_lines_flag): Move definition to source.h.
1852         * tui/tui-hooks.c: Add 'source.h' include.
1853
1854 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1855
1856         * source.c (print_source_lines_base): Handle requests to print
1857         reverse line number sequences, and guard against empty lines
1858         string.
1859
1860 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1861
1862         * source.c (print_source_lines_base): Fix skip of '\r' if next
1863         character is '\n'.
1864
1865 2019-01-06  Tom Tromey  <tom@tromey.com>
1866
1867         * c-exp.y (struct c_parse_state) <macro_original_text,
1868         expansion_obstack>: New member.
1869         (macro_original_text, expansion_obstack): Remove globals.
1870         (scan_macro_expansion, scanning_macro_expansion)
1871         (finished_macro_expansion): Update.
1872         (scan_macro_cleanup): Remove.
1873         (yylex, c_parse): Update.
1874
1875 2019-01-06  Tom Tromey  <tom@tromey.com>
1876
1877         * c-exp.y (struct c_parse_state) <strings>: New member.
1878         (operator_stoken): Update.
1879
1880 2019-01-06  Tom Tromey  <tom@tromey.com>
1881
1882         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1883         (union type_stack_elt) <typelist_val>: Now a pointer to
1884         std::vector.
1885         (type_stack_cleanup): Don't declare.
1886         (push_typelist): Update.
1887         * parse.c (pop_typelist): Return a std::vector.
1888         (push_typelist): Take a std::vector.
1889         (follow_types): Update.  Do not free args.
1890         (type_stack_cleanup): Remove.
1891         * c-exp.y (struct c_parse_state): New.
1892         (cpstate): New global.
1893         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1894         (nonempty_typelist): Update.
1895         (func_mod): Create a new vector.
1896         (c_parse): Create a c_parse_state.
1897         (check_parameter_typelist): Do not delete params.
1898         (function_method): Update.  Do not delete type_list.
1899
1900 2019-01-06  Tom Tromey  <tom@tromey.com>
1901
1902         PR gdb/28155:
1903         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1904         check_typedef.
1905         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1906         (print_return_value): Likewise.
1907
1908 2019-01-05  Tom Tromey  <tom@tromey.com>
1909
1910         * contrib/cleanup_check.py: Remove.
1911         * contrib/gcc-with-excheck: Remove.
1912         * contrib/exsummary.py: Remove.
1913         * contrib/excheck.py: Remove.
1914
1915 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1916
1917         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1918         NULL. Initialize tpprev to NULL instead of assigning it
1919         to NULL on the next statement.
1920         * windows-nat.c (windows_delete_thread): Remove check for
1921         main_thread_id before printing thread exit notifications.
1922         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1923         Remove thread ID check against main_thread_id.
1924         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1925         windows_delete_thread.
1926         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1927
1928 2019-01-04  Tom Tromey  <tom@tromey.com>
1929
1930         * compile/compile.c (_initialize_compile): Use upper case for
1931         metasyntactic variables.
1932         * symmisc.c (_initialize_symmisc): Use upper case for
1933         metasyntactic variables.
1934         * psymtab.c (_initialize_psymtab): Use upper case for
1935         metasyntactic variables.
1936         * demangle.c (demangle_command): Use upper case for metasyntactic
1937         variables.
1938         (_initialize_demangler): Likewise.
1939         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1940         variables.
1941
1942 2019-01-03  Tom Tromey  <tom@tromey.com>
1943
1944         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1945
1946 2019-01-03  Tom Tromey  <tom@tromey.com>
1947
1948         * python/py-symtab.c (salpy_str): Update.
1949         (struct salpy_sal_object) <symtab>: Now a PyObject.
1950         (salpy_dealloc): Update.
1951         (del_objfile_sal): Use gdbpy_ref.
1952
1953 2019-01-03  Tom Tromey  <tom@tromey.com>
1954
1955         * python/py-type.c (convert_field): Use new_reference.  Return
1956         gdbpy_ref.
1957         (make_fielditem): Return gdbpy_ref.
1958         (typy_fields): Update.
1959         (typy_getitem): Update.
1960         (field_name): Return gdbpy_ref.  Use new_reference.
1961         (typy_iterator_iternext): Update.
1962
1963 2019-01-03  Tom Tromey  <tom@tromey.com>
1964
1965         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1966
1967 2019-01-03  Tom Tromey  <tom@tromey.com>
1968
1969         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1970         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1971         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1972         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1973         (pspy_set_type_printers): Likewise.
1974         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1975         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1976         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1977         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1978         (objfpy_set_type_printers): Likewise.
1979
1980 2019-01-03  Tom Tromey  <tom@tromey.com>
1981
1982         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1983         (gdbpy_print_stack): Use gdbpy_err_fetch.
1984         * python/python-internal.h (class gdbpy_err_fetch): New class.
1985         (class gdbpy_enter) <m_error_type, m_error_value,
1986         m_error_traceback>: Remove.
1987         <m_error>: New member.
1988         (gdbpy_exception_to_string): Don't declare.
1989         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1990         * python/py-value.c (convert_value_from_python): Use
1991         gdbpy_err_fetch.
1992         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1993         gdbpy_exception_to_string.
1994         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1995         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1996         gdbpy_err_fetch.
1997
1998 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1999
2000         * linux-nat.c (delete_lwp_cleanup): Delete.
2001         (struct lwp_deleter): New struct.
2002         (lwp_info_up): New typedef.
2003         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2004         lwp_info_up.
2005
2006 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2007
2008         * linux-fork.c (class scoped_switch_fork_info): New class.
2009         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2010
2011 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2012
2013         * valops.c (find_overload_match): Remove use of null_cleanup, and
2014         calls to do_cleanups.
2015
2016 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2017
2018         * compile/compile-cplus-types.c
2019         (compile_cplus_instance::decl_name): Handle changes to
2020         cp_func_name.
2021         * cp-support.c (cp_func_name): Update header comment, update
2022         return type.
2023         * cp-support.h (cp_func_name): Update return type in declaration.
2024         * valops.c (find_overload_match): Move temp_func local to top
2025         level of function and change its type.  Use temp_func to hold and
2026         delete temporary string obtained from cp_func_name.
2027
2028 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2029
2030         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2031         gdb::char_vector, remove cleanup, and update uses of `msg`.
2032
2033 2019-01-03  Jim Wilson  <jimw@sifive.com>
2034
2035         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2036
2037 2019-01-02  Tom Tromey  <tom@tromey.com>
2038
2039         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2040         (tdesc_parse_xml): Remove cleanups.
2041         * target-descriptions.h (make_cleanup_free_target_description):
2042         Don't declare.
2043         (target_desc_deleter): New struct.
2044         (target_desc_up): New typedef.
2045         * target-descriptions.c (target_desc_deleter::operator()): Rename
2046         from free_target_description.
2047         (make_cleanup_free_target_description): Remove.
2048
2049 2019-01-02  Tom Tromey  <tom@tromey.com>
2050
2051         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2052         constructor, destructor.
2053         (linespec_parser): Remove typedef.
2054         (~linespec_parser): Rename from linespec_parser_delete.
2055         (linespec_lex_to_end, linespec_complete_label)
2056         (linespec_complete): Update.
2057         (decode_line_full): Remove cleanups.
2058         (decode_line_1): Update.
2059
2060 2019-01-02  Tom Tromey  <tom@tromey.com>
2061
2062         * python/python-internal.h (inferior_to_inferior_object): Change
2063         return type.
2064         * python/py-exitedevent.c (create_exited_event_object): Update.
2065         * python/py-inferior.c (inferior_to_inferior_object): Return
2066         gdbpy_ref.
2067         (python_new_inferior, python_inferior_deleted)
2068         (thread_to_thread_object, delete_thread_object)
2069         (build_inferior_list, gdbpy_selected_inferior): Update.
2070         * python/py-infthread.c (create_thread_object): Update.  Also fail
2071         if inferior_to_inferior_object fails.
2072
2073 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2074
2075         * inferior.h (class inferior) <displaced_step_state>: New field.
2076         * infrun.h (struct displaced_step_state): Move here from
2077         infrun.c.  Initialize fields, add constructor.
2078         <inf>: Remove field.
2079         <reset>: New method.
2080         * infrun.c (struct displaced_step_inferior_state): Move to
2081         infrun.h.
2082         (displaced_step_inferior_states): Remove.
2083         (get_displaced_stepping_state): Adust.
2084         (displaced_step_in_progress_any_inferior): Adjust.
2085         (displaced_step_in_progress_thread): Adjust.
2086         (displaced_step_in_progress): Adjust.
2087         (add_displaced_stepping_state): Remove.
2088         (get_displaced_step_closure_by_addr): Adjust.
2089         (remove_displaced_stepping_state): Remove.
2090         (infrun_inferior_exit): Call displaced_step_state.reset.
2091         (use_displaced_stepping): Don't check for NULL.
2092         (displaced_step_prepare_throw): Call
2093         get_displaced_stepping_state.
2094         (displaced_step_fixup): Don't check for NULL.
2095         (prepare_for_detach): Don't check for NULL.
2096
2097 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2098
2099         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2100          in case of call that did not complete.
2101
2102 2019-01-02  Andrey Utkin  <autkin@undo.io>
2103
2104         * symfile.c (find_separate_debug_file): Fix search of debug files for
2105         remote debuggee.
2106
2107 2019-01-02  Tom Tromey  <tom@tromey.com>
2108
2109         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2110         indentation.
2111         * python/py-frame.c (frapy_older): Remove cast.
2112         (frapy_newer): Likewise.
2113         * python/py-breakpoint.c (local_setattro): Remove cast.
2114         * python/py-arch.c (archpy_name): Remove local variable.
2115         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2116
2117 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2118
2119         * unittests/basic_string_view/element_access/char/empty.cc:
2120         Fix year range in copyright header.
2121
2122 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2123
2124         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2125         Delete.
2126         <operator==>: Update with for removed field.
2127         <hash>: Likewise.
2128         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2129         <isa_features>: ...this.
2130         <abi_features>: New field.
2131         (riscv_isa_flen): Update comment.
2132         (riscv_abi_xlen): New declaration.
2133         (riscv_abi_flen): New declaration.
2134         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2135         isa_features.
2136         (riscv_abi_xlen): New function.
2137         (riscv_isa_flen): Update to get answer from isa_features.
2138         (riscv_abi_flen): New function.
2139         (riscv_has_fp_abi): Update to get answer from abi_features.
2140         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2141         xlen and flen.
2142         (riscv_call_info) <xlen, flen>: Update comment.
2143         (riscv_call_arg_struct): Remove invalid assertions
2144         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2145         is removed.
2146         (riscv_gdbarch_init): Gather isa features and abi features
2147         separately, ensure both match on the gdbarch when reusing an old
2148         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2149         a target with 64-bit float hardware.
2150
2151 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2152
2153         * source.c (search_command_helper): Stop reverse search
2154         when line 1 has been searched.
2155
2156 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2157
2158         * record-full.c (record_full_base_target::close): Rewrite
2159         record_full_core_buf_list free logic.
2160
2161 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2162
2163         * break-catch-syscall.c (print_one_catch_syscall): xfree
2164         the last text.
2165
2166 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2167
2168         * top.c (print_gdb_version): Update Copyright year in version
2169         message.
2170
2171 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2172
2173         Update copyright year range in all GDB files.
2174
2175 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2176
2177         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2178
2179 For older changes see ChangeLog-2018.
2180 \f
2181 Local Variables:
2182 mode: change-log
2183 left-margin: 8
2184 fill-column: 74
2185 version-control: never
2186 coding: utf-8
2187 End:
2188