gdb/ChangeLog

   1 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
   2
   3         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
   4         integers and enumeration types.
   5
   6 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
   7
   8         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
   9         instead of lookup_symbol_in_language
  10         (do_exact_match): New function.
  11         (ada_get_symbol_name_matcher): Return do_exact_match when
  12         doing a verbatim match.
  13
  14 2019-02-15  Tom Tromey  <tromey@adacore.com>
  15
  16         * ravenscar-thread.c (ravenscar_thread_target::resume)
  17         (ravenscar_thread_target::wait): Special case wildcard requests.
  18
  19 2019-02-15  Tom Tromey  <tromey@adacore.com>
  20
  21         * ravenscar-thread.c (base_ptid): Remove.
  22         (struct ravenscar_thread_target) <close>: New method.
  23         <m_base_ptid>: New member.
  24         <update_inferior_ptid, active_task, task_is_currently_active,
  25         runtime_initialized>: Declare methods.
  26         <ravenscar_thread_target>: Add constructor.
  27         (ravenscar_thread_target::task_is_currently_active)
  28         (ravenscar_thread_target::update_inferior_ptid)
  29         (ravenscar_runtime_initialized): Rename.  Now methods.
  30         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
  31         (ravenscar_thread_target::update_thread_list): Update.
  32         (ravenscar_thread_target::active_task): Now method.
  33         (ravenscar_thread_target::store_registers)
  34         (ravenscar_thread_target::prepare_to_store)
  35         (ravenscar_thread_target::prepare_to_store)
  36         (ravenscar_thread_target::mourn_inferior): Update.
  37         (ravenscar_inferior_created): Use "new" to create target.
  38         (ravenscar_thread_target::get_ada_task_ptid): Update.
  39         (_initialize_ravenscar): Don't initialize base_ptid.
  40         (ravenscar_ops): Remove global.
  41
  42 2019-02-15  Tom Tromey  <tromey@adacore.com>
  43
  44         * target.h (push_target): Declare new overload.
  45         * target.c (push_target): New overload, taking an rvalue reference.
  46         * remote.c (remote_target::open_1): Use push_target overload.
  47         * corelow.c (core_target_open): Use push_target overload.
  48
  49 2019-02-15  Tom Tromey  <tromey@adacore.com>
  50
  51         * ravenscar-thread.c (is_ravenscar_task)
  52         (ravenscar_task_is_currently_active): Return bool.
  53         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
  54         (_initialize_ravenscar): Remove "(void)".
  55         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
  56         Return bool.
  57
  58 2019-02-15  Tom Tromey  <tromey@adacore.com>
  59
  60         * ravenscar-thread.c (ravenscar_runtime_initializer)
  61         (has_ravenscar_runtime, get_running_thread_id)
  62         (ravenscar_thread_target::resume): Fix indentation.
  63
  64 2019-02-15  Tom Tromey  <tromey@adacore.com>
  65
  66         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
  67         from ravenscar_arch_ops.
  68         (sparc_ravenscar_ops::fetch_registers)
  69         (sparc_ravenscar_ops::store_registers): Now methods.
  70         (sparc_ravenscar_prepare_to_store): Remove.
  71         (sparc_ravenscar_ops): Redefine.
  72         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
  73         methods and destructor.  Remove members.
  74         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
  75         (ravenscar_thread_target::store_registers)
  76         (ravenscar_thread_target::prepare_to_store): Update.
  77         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
  78         Remove.
  79         (struct ppc_ravenscar_powerpc_ops): Derive from
  80         ravenscar_arch_ops.
  81         (ppc_ravenscar_powerpc_ops::fetch_registers)
  82         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
  83         (ppc_ravenscar_powerpc_ops): Redefine.
  84         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
  85         (ppc_ravenscar_e500_ops::fetch_registers)
  86         (ppc_ravenscar_e500_ops::store_registers): Now methods.
  87         (ppc_ravenscar_e500_ops): Redefine.
  88         * aarch64-ravenscar-thread.c
  89         (aarch64_ravenscar_generic_prepare_to_store): Remove.
  90         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
  91         (aarch64_ravenscar_fetch_registers)
  92         (aarch64_ravenscar_store_registers): Now methods.
  93         (aarch64_ravenscar_ops): Redefine.
  94
  95 2019-02-15  Tom Tromey  <tromey@adacore.com>
  96
  97         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
  98         (ravenscar_thread_target::stopped_by_hw_breakpoint)
  99         (ravenscar_thread_target::stopped_by_watchpoint)
 100         (ravenscar_thread_target::stopped_data_address)
 101         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 102
 103 2019-02-15  Tom Tromey  <tromey@adacore.com>
 104
 105         * ravenscar-thread.c: Fix some typos.
 106
 107 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 108             Tom Tromey  <tromey@adacore.com>
 109
 110         * ada-lang.c (ada_exception_sal): Change addr_string to a
 111         std::string.
 112         (create_ada_exception_catchpoint): Update.
 113
 114 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 115             Tom Tromey  <tromey@adacore.com>
 116
 117         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 118         (bp_location_ops): Remove.
 119         (base_breakpoint_allocate_location): Update.
 120         (free_bp_location): Update.
 121         * ada-lang.c (class ada_catchpoint_location)
 122         <ada_catchpoint_location>: Remove ops parameter.
 123         (ada_catchpoint_location_dtor): Remove.
 124         (ada_catchpoint_location_ops): Remove.
 125         (allocate_location_exception): Update.
 126         * breakpoint.h (struct bp_location_ops): Remove.
 127         (class bp_location) <bp_location>: Remove bp_location_ops
 128         parameter.
 129         <~bp_location>: Add destructor.
 130         <ops>: Remove.
 131
 132 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 133             Pedro Alves  <palves@redhat.com>
 134
 135         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 136         'PATH_MAX'.
 137
 138 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 139             Samuel Thibault  <samuel.thibault@gnu.org>
 140             Thomas Schwinge  <thomas@codesourcery.com>
 141
 142         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 143         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 144
 145 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 146
 147         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 148         (check_empty): Use "const char *".
 149
 150         * gnu-nat.c (gnu_nat_target::detach): Instead of
 151         'detach_inferior (pid)' call
 152         'detach_inferior (find_inferior_pid (pid))'.
 153
 154         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 155         'nat/fork-inferior.o'.
 156         * gnu-nat.c: #include "nat/fork-inferior.h".
 157
 158         * gnu-nat.c (gnu_nat_target::detach): Instead of
 159         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 160         * gnu-nat.h: #include "inf-child.h".
 161         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 162         'i386_gnu_nat_target::fetch_registers'.
 163         (gnu_store_registers): Rename/move to
 164         'i386_gnu_nat_target::store_registers'.
 165
 166         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 167         * gnu-nat.h (mach_thread_info): New function.
 168         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 169
 170         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 171
 172 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 173
 174         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 175
 176 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 177
 178         * windows-nat.c (windows_add_thread): Add new parameter
 179         "main_thread_p" with default value set to false.  Update
 180         function documentation as well as all callers.
 181         (windows_delete_thread): Likewise.
 182         (fake_create_process): Update call to windows_add_thread.
 183         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 184         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 185         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 186         call to windows_delete_thread.
 187
 188 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 189
 190         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 191
 192 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 193
 194         * symfile.c (find_separate_debug_file): Use canonical path of
 195         sysroot with child_path instead of gdb_sysroot if it is valid.
 196
 197 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 198
 199         * symfile.c (find_separate_debug_file): Use child_path to
 200         determine if an object file is under a sysroot.
 201
 202 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 203
 204         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 205         unittests/child-path-selftests.c.
 206         * common/pathstuff.c (child_path): New function.
 207         * common/pathstuff.h (child_path): New prototype.
 208         * unittests/child-path-selftests.c: New file.
 209
 210 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 211
 212         * symfile.c (find_separate_debug_file): Look for separate debug
 213         files in debug directories under the sysroot.
 214
 215 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 216
 217         * symtab.h (struct minimal_symbol data_p): New const method.
 218         (struct minimal_symbol text_p): Likewise.
 219         * symtab.c (output_source_filename): Use file name style
 220         to print file name.
 221         (print_symbol_info): Likewise.
 222         (print_msymbol_info): Use address style to print addresses.
 223         Use function name style to print executable text symbols.
 224         (expand_symtab_containing_pc): Use data_p.
 225         (find_pc_sect_compunit_symtab): Likewise.
 226
 227 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 228
 229         * breakpoint.c (describe_other_breakpoints): Use address style
 230         to print addresses.
 231         (say_where): Likewise.
 232
 233 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 234
 235         * ada-typeprint.c (print_func_type): Print function name
 236         style to print function name.
 237         * c-typeprint.c (c_print_type_1): Likewise.
 238
 239 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 240
 241         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 242         for execve.
 243
 244 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 245
 246         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 247         type_stack.
 248
 249 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 250
 251         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 252         TYPE_CODE_REF types.
 253
 254 2019-02-08  Jim Wilson  <jimw@sifive.com>
 255
 256         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 257         (riscv_linux_fregset): New.
 258         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 259
 260 2019-02-07  Tom Tromey  <tom@tromey.com>
 261
 262         * thread.c (thread_cancel_execution_command): Update.
 263         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 264         methods.
 265         (struct thread_fsm_ops): Remove.
 266         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 267         (thread_fsm_should_stop, thread_fsm_return_value)
 268         (thread_fsm_set_finished, thread_fsm_finished_p)
 269         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 270         Don't declare.
 271         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 272         * infrun.c (clear_proceed_status_thread)
 273         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 274         (print_stop_event): Update.
 275         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 276         Add constructor.
 277         (step_command_fsm_ops): Remove.
 278         (new_step_command_fsm): Remove.
 279         (step_1): Update.
 280         (step_command_fsm::should_stop): Rename from
 281         step_command_fsm_should_stop.
 282         (step_command_fsm::clean_up): Rename from
 283         step_command_fsm_clean_up.
 284         (step_command_fsm::do_async_reply_reason): Rename from
 285         step_command_fsm_async_reply_reason.
 286         (struct until_next_fsm): Inherit from thread_fsm.  Add
 287         constructor.
 288         (until_next_fsm_ops): Remove.
 289         (new_until_next_fsm): Remove.
 290         (until_next_fsm::should_stop): Rename from
 291         until_next_fsm_should_stop.
 292         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 293         (until_next_fsm::do_async_reply_reason): Rename from
 294         until_next_fsm_async_reply_reason.
 295         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 296         constructor.  Change type of breakpoint.
 297         (finish_command_fsm_ops): Remove.
 298         (new_finish_command_fsm): Remove.
 299         (finish_command_fsm::should_stop): Rename from
 300         finish_command_fsm_should_stop.
 301         (finish_command_fsm::clean_up): Rename from
 302         finish_command_fsm_clean_up.
 303         (finish_command_fsm::return_value): Rename from
 304         finish_command_fsm_return_value.
 305         (finish_command_fsm::do_async_reply_reason): Rename from
 306         finish_command_fsm_async_reply_reason.
 307         (finish_command): Update.
 308         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 309         Add constructor.
 310         (call_thread_fsm_ops): Remove.
 311         (call_thread_fsm::call_thread_fsm): Rename from
 312         new_call_thread_fsm.
 313         (call_thread_fsm::should_stop): Rename from
 314         call_thread_fsm_should_stop.
 315         (call_thread_fsm::should_notify_stop): Rename from
 316         call_thread_fsm_should_notify_stop.
 317         (run_inferior_call, call_function_by_hand_dummy): Update.
 318         * cli/cli-interp.c (should_print_stop_to_console): Update.
 319         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 320         Add constructor.  Change type of location_breakpoint,
 321         caller_breakpoint.
 322         (until_break_fsm_ops): Remove.
 323         (new_until_break_fsm): Remove.
 324         (until_break_fsm::should_stop): Rename from
 325         until_break_fsm_should_stop.
 326         (until_break_fsm::clean_up): Rename from
 327         until_break_fsm_clean_up.
 328         (until_break_fsm::do_async_reply_reason): Rename from
 329         until_break_fsm_async_reply_reason.
 330         (until_break_command): Update.
 331         * thread-fsm.c: Remove.
 332         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 333
 334 2019-02-07  Tom Tromey  <tom@tromey.com>
 335
 336         * yy-remap.h: Add include guard.
 337         * xtensa-tdep.h: Add include guard.
 338         * xcoffread.h: Rename include guard.
 339         * varobj-iter.h: Add include guard.
 340         * tui/tui.h: Rename include guard.
 341         * tui/tui-winsource.h: Rename include guard.
 342         * tui/tui-wingeneral.h: Rename include guard.
 343         * tui/tui-windata.h: Rename include guard.
 344         * tui/tui-win.h: Rename include guard.
 345         * tui/tui-stack.h: Rename include guard.
 346         * tui/tui-source.h: Rename include guard.
 347         * tui/tui-regs.h: Rename include guard.
 348         * tui/tui-out.h: Rename include guard.
 349         * tui/tui-layout.h: Rename include guard.
 350         * tui/tui-io.h: Rename include guard.
 351         * tui/tui-hooks.h: Rename include guard.
 352         * tui/tui-file.h: Rename include guard.
 353         * tui/tui-disasm.h: Rename include guard.
 354         * tui/tui-data.h: Rename include guard.
 355         * tui/tui-command.h: Rename include guard.
 356         * tic6x-tdep.h: Add include guard.
 357         * target/waitstatus.h: Rename include guard.
 358         * target/wait.h: Rename include guard.
 359         * target/target.h: Rename include guard.
 360         * target/resume.h: Rename include guard.
 361         * target-float.h: Rename include guard.
 362         * stabsread.h: Add include guard.
 363         * rs6000-tdep.h: Add include guard.
 364         * riscv-fbsd-tdep.h: Add include guard.
 365         * regformats/regdef.h: Rename include guard.
 366         * record.h: Rename include guard.
 367         * python/python.h: Rename include guard.
 368         * python/python-internal.h: Rename include guard.
 369         * python/py-stopevent.h: Rename include guard.
 370         * python/py-ref.h: Rename include guard.
 371         * python/py-record.h: Rename include guard.
 372         * python/py-record-full.h: Rename include guard.
 373         * python/py-record-btrace.h: Rename include guard.
 374         * python/py-instruction.h: Rename include guard.
 375         * python/py-events.h: Rename include guard.
 376         * python/py-event.h: Rename include guard.
 377         * procfs.h: Add include guard.
 378         * proc-utils.h: Add include guard.
 379         * p-lang.h: Add include guard.
 380         * or1k-tdep.h: Rename include guard.
 381         * observable.h: Rename include guard.
 382         * nto-tdep.h: Rename include guard.
 383         * nat/x86-linux.h: Rename include guard.
 384         * nat/x86-linux-dregs.h: Rename include guard.
 385         * nat/x86-gcc-cpuid.h: Add include guard.
 386         * nat/x86-dregs.h: Rename include guard.
 387         * nat/x86-cpuid.h: Rename include guard.
 388         * nat/ppc-linux.h: Rename include guard.
 389         * nat/mips-linux-watch.h: Rename include guard.
 390         * nat/linux-waitpid.h: Rename include guard.
 391         * nat/linux-ptrace.h: Rename include guard.
 392         * nat/linux-procfs.h: Rename include guard.
 393         * nat/linux-osdata.h: Rename include guard.
 394         * nat/linux-nat.h: Rename include guard.
 395         * nat/linux-namespaces.h: Rename include guard.
 396         * nat/linux-btrace.h: Rename include guard.
 397         * nat/glibc_thread_db.h: Rename include guard.
 398         * nat/gdb_thread_db.h: Rename include guard.
 399         * nat/gdb_ptrace.h: Rename include guard.
 400         * nat/fork-inferior.h: Rename include guard.
 401         * nat/amd64-linux-siginfo.h: Rename include guard.
 402         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 403         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 404         * nat/aarch64-linux.h: Rename include guard.
 405         * nat/aarch64-linux-hw-point.h: Rename include guard.
 406         * mn10300-tdep.h: Add include guard.
 407         * mips-linux-tdep.h: Add include guard.
 408         * mi/mi-parse.h: Rename include guard.
 409         * mi/mi-out.h: Rename include guard.
 410         * mi/mi-main.h: Rename include guard.
 411         * mi/mi-interp.h: Rename include guard.
 412         * mi/mi-getopt.h: Rename include guard.
 413         * mi/mi-console.h: Rename include guard.
 414         * mi/mi-common.h: Rename include guard.
 415         * mi/mi-cmds.h: Rename include guard.
 416         * mi/mi-cmd-break.h: Rename include guard.
 417         * m2-lang.h: Add include guard.
 418         * location.h: Rename include guard.
 419         * linux-record.h: Rename include guard.
 420         * linux-nat.h: Add include guard.
 421         * linux-fork.h: Add include guard.
 422         * i386-darwin-tdep.h: Rename include guard.
 423         * hppa-linux-offsets.h: Add include guard.
 424         * guile/guile.h: Rename include guard.
 425         * guile/guile-internal.h: Rename include guard.
 426         * gnu-nat.h: Rename include guard.
 427         * gdb-stabs.h: Rename include guard.
 428         * frv-tdep.h: Add include guard.
 429         * f-lang.h: Add include guard.
 430         * event-loop.h: Add include guard.
 431         * darwin-nat.h: Rename include guard.
 432         * cp-abi.h: Rename include guard.
 433         * config/sparc/nm-sol2.h: Rename include guard.
 434         * config/nm-nto.h: Rename include guard.
 435         * config/nm-linux.h: Add include guard.
 436         * config/i386/nm-i386gnu.h: Rename include guard.
 437         * config/djgpp/nl_types.h: Rename include guard.
 438         * config/djgpp/langinfo.h: Rename include guard.
 439         * compile/gcc-cp-plugin.h: Add include guard.
 440         * compile/gcc-c-plugin.h: Add include guard.
 441         * compile/compile.h: Rename include guard.
 442         * compile/compile-object-run.h: Rename include guard.
 443         * compile/compile-object-load.h: Rename include guard.
 444         * compile/compile-internal.h: Rename include guard.
 445         * compile/compile-cplus.h: Rename include guard.
 446         * compile/compile-c.h: Rename include guard.
 447         * common/xml-utils.h: Rename include guard.
 448         * common/x86-xstate.h: Rename include guard.
 449         * common/version.h: Rename include guard.
 450         * common/vec.h: Rename include guard.
 451         * common/tdesc.h: Rename include guard.
 452         * common/selftest.h: Rename include guard.
 453         * common/scoped_restore.h: Rename include guard.
 454         * common/scoped_mmap.h: Rename include guard.
 455         * common/scoped_fd.h: Rename include guard.
 456         * common/safe-iterator.h: Rename include guard.
 457         * common/run-time-clock.h: Rename include guard.
 458         * common/refcounted-object.h: Rename include guard.
 459         * common/queue.h: Rename include guard.
 460         * common/ptid.h: Rename include guard.
 461         * common/print-utils.h: Rename include guard.
 462         * common/preprocessor.h: Rename include guard.
 463         * common/pathstuff.h: Rename include guard.
 464         * common/observable.h: Rename include guard.
 465         * common/netstuff.h: Rename include guard.
 466         * common/job-control.h: Rename include guard.
 467         * common/host-defs.h: Rename include guard.
 468         * common/gdb_wait.h: Rename include guard.
 469         * common/gdb_vecs.h: Rename include guard.
 470         * common/gdb_unlinker.h: Rename include guard.
 471         * common/gdb_unique_ptr.h: Rename include guard.
 472         * common/gdb_tilde_expand.h: Rename include guard.
 473         * common/gdb_sys_time.h: Rename include guard.
 474         * common/gdb_string_view.h: Rename include guard.
 475         * common/gdb_splay_tree.h: Rename include guard.
 476         * common/gdb_setjmp.h: Rename include guard.
 477         * common/gdb_ref_ptr.h: Rename include guard.
 478         * common/gdb_optional.h: Rename include guard.
 479         * common/gdb_locale.h: Rename include guard.
 480         * common/gdb_assert.h: Rename include guard.
 481         * common/filtered-iterator.h: Rename include guard.
 482         * common/filestuff.h: Rename include guard.
 483         * common/fileio.h: Rename include guard.
 484         * common/environ.h: Rename include guard.
 485         * common/common-utils.h: Rename include guard.
 486         * common/common-types.h: Rename include guard.
 487         * common/common-regcache.h: Rename include guard.
 488         * common/common-inferior.h: Rename include guard.
 489         * common/common-gdbthread.h: Rename include guard.
 490         * common/common-exceptions.h: Rename include guard.
 491         * common/common-defs.h: Rename include guard.
 492         * common/common-debug.h: Rename include guard.
 493         * common/cleanups.h: Rename include guard.
 494         * common/buffer.h: Rename include guard.
 495         * common/btrace-common.h: Rename include guard.
 496         * common/break-common.h: Rename include guard.
 497         * cli/cli-utils.h: Rename include guard.
 498         * cli/cli-style.h: Rename include guard.
 499         * cli/cli-setshow.h: Rename include guard.
 500         * cli/cli-script.h: Rename include guard.
 501         * cli/cli-interp.h: Rename include guard.
 502         * cli/cli-decode.h: Rename include guard.
 503         * cli/cli-cmds.h: Rename include guard.
 504         * charset-list.h: Add include guard.
 505         * buildsym-legacy.h: Rename include guard.
 506         * bfin-tdep.h: Add include guard.
 507         * ax.h: Rename include guard.
 508         * arm-linux-tdep.h: Add include guard.
 509         * arm-fbsd-tdep.h: Add include guard.
 510         * arch/xtensa.h: Rename include guard.
 511         * arch/tic6x.h: Add include guard.
 512         * arch/i386.h: Add include guard.
 513         * arch/arm.h: Rename include guard.
 514         * arch/arm-linux.h: Rename include guard.
 515         * arch/arm-get-next-pcs.h: Rename include guard.
 516         * arch/amd64.h: Add include guard.
 517         * arch/aarch64-insn.h: Rename include guard.
 518         * arch-utils.h: Rename include guard.
 519         * annotate.h: Add include guard.
 520         * amd64-darwin-tdep.h: Rename include guard.
 521         * aarch64-linux-tdep.h: Add include guard.
 522         * aarch64-fbsd-tdep.h: Add include guard.
 523         * aarch32-linux-nat.h: Add include guard.
 524
 525 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 526
 527         * macrotab.c (macro_define_internal): New function that
 528         factorizes macro_define_object_internal and macro_define_function
 529         code.
 530         (macro_define_object_internal): Use macro_define_internal.
 531         (macro_define_function): Likewise.
 532
 533 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 534
 535         * macrocmd.c (extract_identifier): Return
 536         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 537         callers.
 538
 539 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 540
 541         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 542
 543 2019-02-05  Tom Tromey  <tom@tromey.com>
 544
 545         * target.c (target_stack::unpush): Move assertion earlier.
 546
 547 2019-01-30  Tom Tromey  <tom@tromey.com>
 548
 549         PR python/23615:
 550         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 551         (gdbpy_parse_and_eval): Likewise.
 552         * python/python-internal.h (gdbpy_allow_threads): New class.
 553
 554 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 555
 556         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 557         (aarch64_fbsd_fpregmap): Move earlier.
 558         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 559         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 560         instead of individual calls to trad_frame_set_reg_addr.
 561         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 562         earlier.
 563         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 564         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 565         instead of individual calls to trad_frame_set_reg_addr.
 566
 567 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 568
 569         * CONTRIBUTE: Replace contribution list with wiki link.
 570
 571 2019-01-25  Tom Tromey  <tom@tromey.com>
 572
 573         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 574
 575 2019-01-25  Tom Tromey  <tom@tromey.com>
 576
 577         * xtensa-linux-nat.c: Fix common/ includes.
 578         * xml-support.h: Fix common/ includes.
 579         * xml-support.c: Fix common/ includes.
 580         * x86-linux-nat.c: Fix common/ includes.
 581         * windows-nat.c: Fix common/ includes.
 582         * varobj.h: Fix common/ includes.
 583         * varobj.c: Fix common/ includes.
 584         * value.c: Fix common/ includes.
 585         * valops.c: Fix common/ includes.
 586         * utils.c: Fix common/ includes.
 587         * unittests/xml-utils-selftests.c: Fix common/ includes.
 588         * unittests/utils-selftests.c: Fix common/ includes.
 589         * unittests/unpack-selftests.c: Fix common/ includes.
 590         * unittests/tracepoint-selftests.c: Fix common/ includes.
 591         * unittests/style-selftests.c: Fix common/ includes.
 592         * unittests/string_view-selftests.c: Fix common/ includes.
 593         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 594         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 595         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 596         * unittests/rsp-low-selftests.c: Fix common/ includes.
 597         * unittests/parse-connection-spec-selftests.c: Fix common/
 598         includes.
 599         * unittests/optional-selftests.c: Fix common/ includes.
 600         * unittests/offset-type-selftests.c: Fix common/ includes.
 601         * unittests/observable-selftests.c: Fix common/ includes.
 602         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 603         * unittests/memrange-selftests.c: Fix common/ includes.
 604         * unittests/memory-map-selftests.c: Fix common/ includes.
 605         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 606         * unittests/function-view-selftests.c: Fix common/ includes.
 607         * unittests/environ-selftests.c: Fix common/ includes.
 608         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 609         * unittests/common-utils-selftests.c: Fix common/ includes.
 610         * unittests/cli-utils-selftests.c: Fix common/ includes.
 611         * unittests/array-view-selftests.c: Fix common/ includes.
 612         * ui-file.c: Fix common/ includes.
 613         * tui/tui-io.c: Fix common/ includes.
 614         * tracepoint.h: Fix common/ includes.
 615         * tracepoint.c: Fix common/ includes.
 616         * tracefile-tfile.c: Fix common/ includes.
 617         * top.h: Fix common/ includes.
 618         * top.c: Fix common/ includes.
 619         * thread.c: Fix common/ includes.
 620         * target/waitstatus.h: Fix common/ includes.
 621         * target/waitstatus.c: Fix common/ includes.
 622         * target.h: Fix common/ includes.
 623         * target.c: Fix common/ includes.
 624         * target-memory.c: Fix common/ includes.
 625         * target-descriptions.c: Fix common/ includes.
 626         * symtab.h: Fix common/ includes.
 627         * symfile.c: Fix common/ includes.
 628         * stap-probe.c: Fix common/ includes.
 629         * spu-linux-nat.c: Fix common/ includes.
 630         * sparc-nat.c: Fix common/ includes.
 631         * source.c: Fix common/ includes.
 632         * solib.c: Fix common/ includes.
 633         * solib-target.c: Fix common/ includes.
 634         * ser-unix.c: Fix common/ includes.
 635         * ser-tcp.c: Fix common/ includes.
 636         * ser-pipe.c: Fix common/ includes.
 637         * ser-base.c: Fix common/ includes.
 638         * selftest-arch.c: Fix common/ includes.
 639         * s12z-tdep.c: Fix common/ includes.
 640         * rust-exp.y: Fix common/ includes.
 641         * rs6000-aix-tdep.c: Fix common/ includes.
 642         * riscv-tdep.c: Fix common/ includes.
 643         * remote.c: Fix common/ includes.
 644         * remote-notif.h: Fix common/ includes.
 645         * remote-fileio.h: Fix common/ includes.
 646         * remote-fileio.c: Fix common/ includes.
 647         * regcache.h: Fix common/ includes.
 648         * regcache.c: Fix common/ includes.
 649         * record-btrace.c: Fix common/ includes.
 650         * python/python.c: Fix common/ includes.
 651         * python/py-type.c: Fix common/ includes.
 652         * python/py-inferior.c: Fix common/ includes.
 653         * progspace.h: Fix common/ includes.
 654         * producer.c: Fix common/ includes.
 655         * procfs.c: Fix common/ includes.
 656         * proc-api.c: Fix common/ includes.
 657         * printcmd.c: Fix common/ includes.
 658         * ppc-linux-nat.c: Fix common/ includes.
 659         * parser-defs.h: Fix common/ includes.
 660         * osdata.c: Fix common/ includes.
 661         * obsd-nat.c: Fix common/ includes.
 662         * nat/x86-linux.c: Fix common/ includes.
 663         * nat/x86-linux-dregs.c: Fix common/ includes.
 664         * nat/x86-dregs.h: Fix common/ includes.
 665         * nat/x86-dregs.c: Fix common/ includes.
 666         * nat/ppc-linux.c: Fix common/ includes.
 667         * nat/mips-linux-watch.h: Fix common/ includes.
 668         * nat/mips-linux-watch.c: Fix common/ includes.
 669         * nat/linux-waitpid.c: Fix common/ includes.
 670         * nat/linux-ptrace.h: Fix common/ includes.
 671         * nat/linux-ptrace.c: Fix common/ includes.
 672         * nat/linux-procfs.c: Fix common/ includes.
 673         * nat/linux-personality.c: Fix common/ includes.
 674         * nat/linux-osdata.c: Fix common/ includes.
 675         * nat/linux-namespaces.c: Fix common/ includes.
 676         * nat/linux-btrace.h: Fix common/ includes.
 677         * nat/linux-btrace.c: Fix common/ includes.
 678         * nat/fork-inferior.c: Fix common/ includes.
 679         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 680         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 681         * nat/aarch64-linux.c: Fix common/ includes.
 682         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 683         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 684         * namespace.h: Fix common/ includes.
 685         * mips-linux-tdep.c: Fix common/ includes.
 686         * minsyms.c: Fix common/ includes.
 687         * mi/mi-parse.h: Fix common/ includes.
 688         * mi/mi-main.c: Fix common/ includes.
 689         * mi/mi-cmd-env.c: Fix common/ includes.
 690         * memrange.h: Fix common/ includes.
 691         * memattr.c: Fix common/ includes.
 692         * maint.h: Fix common/ includes.
 693         * maint.c: Fix common/ includes.
 694         * main.c: Fix common/ includes.
 695         * machoread.c: Fix common/ includes.
 696         * location.c: Fix common/ includes.
 697         * linux-thread-db.c: Fix common/ includes.
 698         * linux-nat.c: Fix common/ includes.
 699         * linux-fork.c: Fix common/ includes.
 700         * inline-frame.c: Fix common/ includes.
 701         * infrun.c: Fix common/ includes.
 702         * inflow.c: Fix common/ includes.
 703         * inferior.h: Fix common/ includes.
 704         * inferior.c: Fix common/ includes.
 705         * infcmd.c: Fix common/ includes.
 706         * inf-ptrace.c: Fix common/ includes.
 707         * inf-child.c: Fix common/ includes.
 708         * ia64-linux-nat.c: Fix common/ includes.
 709         * i387-tdep.c: Fix common/ includes.
 710         * i386-tdep.c: Fix common/ includes.
 711         * i386-linux-tdep.c: Fix common/ includes.
 712         * i386-linux-nat.c: Fix common/ includes.
 713         * i386-go32-tdep.c: Fix common/ includes.
 714         * i386-fbsd-tdep.c: Fix common/ includes.
 715         * i386-fbsd-nat.c: Fix common/ includes.
 716         * guile/scm-type.c: Fix common/ includes.
 717         * guile/guile.c: Fix common/ includes.
 718         * go32-nat.c: Fix common/ includes.
 719         * gnu-nat.c: Fix common/ includes.
 720         * gdbthread.h: Fix common/ includes.
 721         * gdbarch-selftests.c: Fix common/ includes.
 722         * gdb_usleep.c: Fix common/ includes.
 723         * gdb_select.h: Fix common/ includes.
 724         * gdb_bfd.c: Fix common/ includes.
 725         * gcore.c: Fix common/ includes.
 726         * fork-child.c: Fix common/ includes.
 727         * findvar.c: Fix common/ includes.
 728         * fbsd-nat.c: Fix common/ includes.
 729         * event-top.c: Fix common/ includes.
 730         * event-loop.c: Fix common/ includes.
 731         * dwarf2read.c: Fix common/ includes.
 732         * dwarf2loc.c: Fix common/ includes.
 733         * dwarf2-frame.c: Fix common/ includes.
 734         * dwarf-index-cache.c: Fix common/ includes.
 735         * dtrace-probe.c: Fix common/ includes.
 736         * disasm-selftests.c: Fix common/ includes.
 737         * defs.h: Fix common/ includes.
 738         * csky-tdep.c: Fix common/ includes.
 739         * cp-valprint.c: Fix common/ includes.
 740         * cp-support.h: Fix common/ includes.
 741         * cp-support.c: Fix common/ includes.
 742         * corelow.c: Fix common/ includes.
 743         * completer.h: Fix common/ includes.
 744         * completer.c: Fix common/ includes.
 745         * compile/compile.c: Fix common/ includes.
 746         * compile/compile-loc2c.c: Fix common/ includes.
 747         * compile/compile-cplus-types.c: Fix common/ includes.
 748         * compile/compile-cplus-symbols.c: Fix common/ includes.
 749         * command.h: Fix common/ includes.
 750         * cli/cli-dump.c: Fix common/ includes.
 751         * cli/cli-cmds.c: Fix common/ includes.
 752         * charset.c: Fix common/ includes.
 753         * build-id.c: Fix common/ includes.
 754         * btrace.h: Fix common/ includes.
 755         * btrace.c: Fix common/ includes.
 756         * breakpoint.h: Fix common/ includes.
 757         * breakpoint.c: Fix common/ includes.
 758         * ax.h:
 759         (enum agent_op): Fix common/ includes.
 760         * ax-general.c (struct aop_map): Fix common/ includes.
 761         * ax-gdb.c: Fix common/ includes.
 762         * auxv.c: Fix common/ includes.
 763         * auto-load.c: Fix common/ includes.
 764         * arm-tdep.c: Fix common/ includes.
 765         * arch/riscv.c: Fix common/ includes.
 766         * arch/ppc-linux-common.c: Fix common/ includes.
 767         * arch/i386.c: Fix common/ includes.
 768         * arch/arm.c: Fix common/ includes.
 769         * arch/arm-linux.c: Fix common/ includes.
 770         * arch/arm-get-next-pcs.c: Fix common/ includes.
 771         * arch/amd64.c: Fix common/ includes.
 772         * arch/aarch64.c: Fix common/ includes.
 773         * arch/aarch64-insn.c: Fix common/ includes.
 774         * arch-utils.c: Fix common/ includes.
 775         * amd64-windows-tdep.c: Fix common/ includes.
 776         * amd64-tdep.c: Fix common/ includes.
 777         * amd64-sol2-tdep.c: Fix common/ includes.
 778         * amd64-obsd-tdep.c: Fix common/ includes.
 779         * amd64-nbsd-tdep.c: Fix common/ includes.
 780         * amd64-linux-tdep.c: Fix common/ includes.
 781         * amd64-linux-nat.c: Fix common/ includes.
 782         * amd64-fbsd-tdep.c: Fix common/ includes.
 783         * amd64-fbsd-nat.c: Fix common/ includes.
 784         * amd64-dicos-tdep.c: Fix common/ includes.
 785         * amd64-darwin-tdep.c: Fix common/ includes.
 786         * agent.c: Fix common/ includes.
 787         * ada-lang.h: Fix common/ includes.
 788         * ada-lang.c: Fix common/ includes.
 789         * aarch64-tdep.c: Fix common/ includes.
 790
 791 2019-01-25  Tom Tromey  <tom@tromey.com>
 792
 793         * common/create-version.sh: Use common/version.h.
 794
 795 2019-01-24  Pedro Alves  <palves@redhat.com>
 796
 797         * infrun.c (signal_stop, signal_print, signal_program)
 798         (signal_catch, signal_pass): Now arrays instead of pointers.
 799         (update_signals_program_target, do_target_resume)
 800         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 801         * linux-nat.c (linux_nat_target::pass_signals)
 802         (linux_nat_target::create_inferior, linux_nat_target::attach):
 803         Adjust.
 804         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 805         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 806         * procfs.c (procfs_target::pass_signals): Adjust.
 807         * record-full.c (record_full_target::resume): Adjust.
 808         * remote.c (remote_target::pass_signals)
 809         (remote_target::program_signals): Adjust.
 810         * target-debug.h (target_debug_print_signals): Now takes a
 811         gdb::array_view as parameter.  Adjust.
 812         * target.h (target_ops) <pass_signals, program_signals>: Replace
 813         pointer and length parameters with gdb::array_view.
 814         (target_pass_signals, target_program_signals): Likewise.
 815         * target-delegates.c: Regenerate.
 816
 817 2019-01-24  Pedro Alves  <palves@redhat.com>
 818
 819         * common/forward-scope-exit.h
 820         (forward_scope_exit::forward_scope_exit): Pass arguments to
 821         m_bind_function directly, instead of creating a std::bind and
 822         copying that.
 823
 824 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 825
 826         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 827         for static members.
 828         (pass_in_v_vfp_candidate): Likewise.
 829
 830 2019-01-23  Tom Tromey  <tom@tromey.com>
 831             Pedro Alves  <palves@redhat.com>
 832
 833         * regcache.c (class regcache_invalidator): Remove.
 834         (regcache::raw_write): Use make_scope_exit.
 835
 836 2019-01-23  Tom Tromey  <tom@tromey.com>
 837
 838         * ui-out.h (class ui_out_emit_type): Update comment.
 839
 840 2019-01-23  Tom Tromey  <tom@tromey.com>
 841
 842         * infrun.c (fetch_inferior_event): Update comment.
 843
 844 2019-01-23  Tom Tromey  <tom@tromey.com>
 845             Pedro Alves  <palves@redhat.com>
 846
 847         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 848         parameter.
 849         (fetch_inferior_event): Use SCOPE_EXIT.
 850
 851
 852 2019-01-23  Tom Tromey  <tom@tromey.com>
 853             Pedro Alves  <palves@redhat.com>
 854
 855         * infrun.c (disable_thread_events): Delete.
 856         (stop_all_threads): Use SCOPE_EXIT.
 857
 858 2019-01-23  Tom Tromey  <tom@tromey.com>
 859             Pedro Alves  <palves@redhat.com>
 860
 861         * symfile.c: Include forward-scope-exit.h.
 862         (clear_symtab_users_cleanup): Replace forward declaration with
 863         a FORWARD_SCOPE_EXIT.
 864         (syms_from_objfile_1): Use the forward_scope_exit and
 865         gdb::optional instead of cleanup_function.
 866         (reread_symbols): Use the forward_scope_exit instead of
 867         cleanup_function.
 868         (clear_symtab_users_cleanup): Remove function.
 869
 870 2019-01-23  Tom Tromey  <tom@tromey.com>
 871             Pedro Alves  <palves@redhat.com>
 872
 873         * linux-nat.c: Include scope-exit.h.
 874         (cleanup_target_stop): Remove.
 875         (linux_nat_target::static_tracepoint_markers_by_strid): Use
 876         SCOPE_EXIT.
 877
 878 2019-01-23  Tom Tromey  <tom@tromey.com>
 879             Pedro Alves  <palves@redhat.com>
 880
 881         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
 882         (call_function_by_hand_dummy): Use SCOPE_EXIT.
 883
 884 2019-01-23  Tom Tromey  <tom@tromey.com>
 885             Andrew Burgess  <andrew.burgess@embecosm.com>
 886             Pedro Alves  <palves@redhat.com>
 887
 888         * infrun.c (fetch_inferior_event): Use scope_exit.
 889         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
 890         * top.c (execute_command): Use scope_exit.
 891         * breakpoint.c (bpstat_do_actions): Use scope_exit.
 892         * utils.c (do_bpstat_clear_actions_cleanup)
 893         (make_bpstat_clear_actions_cleanup): Remove.
 894
 895 2019-01-23  Tom Tromey  <tom@tromey.com>
 896             Pedro Alves  <palves@redhat.com>
 897
 898         * infrun.c: Include "common/scope-exit.h"
 899         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
 900         (wait_for_inferior): Use SCOPE_EXIT.
 901         (fetch_inferior_event): Use scope_exit.
 902
 903 2019-01-23  Tom Tromey  <tom@tromey.com>
 904             Pedro Alves  <palves@redhat.com>
 905
 906         * breakpoint.c (create_breakpoint): Remove cleanup.
 907
 908 2019-01-23  Tom Tromey  <tom@tromey.com>
 909             Andrew Burgess  <andrew.burgess@embecosm.com>
 910             Pedro Alves  <palves@redhat.com>
 911
 912 2019-01-23  Pedro Alves  <palves@redhat.com>
 913
 914         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
 915
 916 2019-01-23  Pedro Alves  <palves@redhat.com>
 917             Andrew Burgess  <andrew.burgess@embecosm.com>
 918
 919         * gdbthread.h: Include "common/forward-scope-exit.h".
 920         (scoped_finish_thread_state): Redefine custom class in terms of
 921         forward_scope_exit.
 922
 923 2019-01-23  Pedro Alves  <palves@redhat.com>
 924             Andrew Burgess  <andrew.burgess@embecosm.com>
 925
 926         * common/forward-scope-exit.h: New file.
 927
 928 2019-01-23  Pedro Alves  <palves@redhat.com>
 929             Andrew Burgess  <andrew.burgess@embecosm.com>
 930             Tom Tromey  <tom@tromey.com>
 931
 932         * common/scope-exit.h: New file.
 933
 934 2019-01-23  Pedro Alves  <palves@redhat.com>
 935
 936         * common/preprocessor.h (ESC): Rename to ...
 937         (ESC_PARENS): ... this.
 938         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
 939         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
 940
 941 2019-01-23  Tom Tromey  <tom@tromey.com>
 942
 943         * language.h (class scoped_switch_to_sym_language_if_auto):
 944         Initialize m_lang in both cases.
 945
 946 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
 947
 948         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
 949         with XCNEW.
 950
 951 2019-01-22  Tom Tromey  <tom@tromey.com>
 952
 953         * corelow.c: Do not include sys/file.h.
 954
 955 2019-01-22  Tom Tromey  <tom@tromey.com>
 956
 957         * tui/tui-wingeneral.h: Include gdb_curses.h.
 958
 959 2019-01-22  Tom Tromey  <tom@tromey.com>
 960
 961         * source-cache.h (class source_cache) <get_source_lines,
 962         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
 963
 964 2019-01-22  Tom Tromey  <tom@tromey.com>
 965
 966         * remote-fileio.h (struct remote_target): Declare.
 967
 968 2019-01-22  Tom Tromey  <tom@tromey.com>
 969
 970         * python/py-arch.c: Do not include py-ref.h.
 971         * python/py-bpevent.c: Do not include py-ref.h.
 972         * python/py-cmd.c: Do not include py-ref.h.
 973         * python/py-continueevent.c: Do not include py-ref.h.
 974         * python/py-event.h: Do not include py-ref.h.
 975         * python/py-evtregistry.c: Do not include py-ref.h.
 976         * python/py-finishbreakpoint.c: Do not include py-ref.h.
 977         * python/py-frame.c: Do not include py-ref.h.
 978         * python/py-framefilter.c: Do not include py-ref.h.
 979         * python/py-function.c: Do not include py-ref.h.
 980         * python/py-infevents.c: Do not include py-ref.h.
 981         * python/py-linetable.c: Do not include py-ref.h.
 982         * python/py-objfile.c: Do not include py-ref.h.
 983         * python/py-param.c: Do not include py-ref.h.
 984         * python/py-prettyprint.c: Do not include py-ref.h.
 985         * python/py-progspace.c: Do not include py-ref.h.
 986         * python/py-symbol.c: Do not include py-ref.h.
 987         * python/py-symtab.c: Do not include py-ref.h.
 988         * python/py-type.c: Do not include py-ref.h.
 989         * python/py-unwind.c: Do not include py-ref.h.
 990         * python/py-utils.c: Do not include py-ref.h.
 991         * python/py-value.c: Do not include py-ref.h.
 992         * python/py-varobj.c: Do not include py-ref.h.
 993         * python/py-xmethods.c: Do not include py-ref.h.
 994         * python/python.c: Do not include py-ref.h.
 995         * varobj.c: Do not include py-ref.h.
 996
 997 2019-01-22  Tom Tromey  <tom@tromey.com>
 998
 999         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1000         keyword for bcache.
1001
1002 2019-01-22  Tom Tromey  <tom@tromey.com>
1003
1004         * compile/compile-cplus-types.c: Remove a comment by #include.
1005
1006 2019-01-22  Tom Tromey  <tom@tromey.com>
1007
1008         * compile/gcc-c-plugin.h: Include compile-internal.h.
1009
1010 2019-01-22  Tom Tromey  <tom@tromey.com>
1011
1012         * stabsread.c (EXTERN): Do not define.
1013         (symnum, next_symbol_text_func, processing_gcc_compilation)
1014         (within_function, global_sym_chain, global_stabs)
1015         (previous_stab_code, this_object_header_files)
1016         (n_this_object_header_files)
1017         (n_allocated_this_object_header_files): Define.
1018         * stabsread.h (EXTERN): Never define.  Use "extern".
1019
1020 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1021
1022         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1023         history_value.
1024
1025 2019-01-21  Tom Tromey  <tom@tromey.com>
1026
1027         * ui-out.c: Fix includes.
1028         * tui/tui-source.c: Fix includes.
1029         * target.c: Fix includes.
1030         * remote.c: Fix includes.
1031         * regcache.c: Fix includes.
1032         * python/py-block.c: Fix includes.
1033         * printcmd.c: Fix includes.
1034         * or1k-tdep.c: Fix includes.
1035         * mi/mi-main.c: Fix includes.
1036         * m32r-tdep.c: Fix includes.
1037         * csky-tdep.c: Fix includes.
1038         * compile/compile-cplus-types.c: Fix includes.
1039         * cli/cli-interp.c: Fix includes.
1040
1041 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1042
1043         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1044         for padding.
1045
1046 2019-01-16  Tom Tromey  <tom@tromey.com>
1047
1048         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1049         earlier.
1050         (struct objfile) <msymbols_range>: Move from top level.
1051         <msymbols>: New method.
1052         (class objfile_msymbols): Remove.
1053         * symtab.c (default_collect_symbol_completion_matches_break_on):
1054         Update.
1055         * symmisc.c (dump_msymbols): Update.
1056         * stabsread.c (scan_file_globals): Update.
1057         * objc-lang.c (info_selectors_command, info_classes_command)
1058         (find_methods): Update.
1059         * minsyms.c (find_solib_trampoline_target): Update.
1060         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1061         * coffread.c (coff_symfile_read): Update.
1062         * ada-lang.c (ada_lookup_simple_minsym)
1063         (ada_collect_symbol_completion_matches): Update.
1064
1065 2019-01-16  Tom Tromey  <tom@tromey.com>
1066
1067         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1068         type.  Remove no-argument constructor.
1069         <iterator::operator++>: Simplify.
1070         <begin>: Update.
1071         <end>: Use minimal_symbol_count.
1072
1073 2019-01-16  Tom Tromey  <tom@tromey.com>
1074
1075         * objfiles.h (struct objfile) <psymtabs>: New method.
1076         (class objfile_psymtabs): Remove.
1077         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1078         typedef.
1079         <range>: New method.
1080         (require_partial_symbols): Change return type.
1081         * psymtab.c (require_partial_symbols)
1082         (psym_expand_symtabs_matching): Update.
1083         * mdebugread.c (parse_partial_symbols): Update.
1084         * dbxread.c (dbx_end_psymtab): Update.
1085
1086 2019-01-15  Tom Tromey  <tom@tromey.com>
1087
1088         * symtab.c (lookup_objfile_from_block)
1089         (lookup_symbol_in_objfile_symtabs)
1090         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1091         (find_line_symtab, info_sources_command)
1092         (default_collect_symbol_completion_matches_break_on)
1093         (make_source_files_completion_list): Update.
1094         * symmisc.c (print_objfile_statistics, dump_objfile)
1095         (maintenance_print_symbols, maintenance_info_symtabs)
1096         (maintenance_check_symtabs, maintenance_info_line_tables):
1097         Update.
1098         * source.c (select_source_symtab)
1099         (forget_cached_source_info_for_objfile): Update.
1100         * objfiles.h (class objfile_compunits): Remove.
1101         (struct objfile) <compunits_range>: New typedef.
1102         (compunits): New method.
1103         * objfiles.c (objfile_relocate1): Update.
1104         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1105         * maint.c (count_symtabs_and_blocks): Update.
1106         * linespec.c (iterate_over_all_matching_symtabs): Update.
1107         * cp-support.c (add_symbol_overload_list_qualified): Update.
1108         * coffread.c (coff_symtab_read): Update.
1109         * ada-lang.c (add_nonlocal_symbols)
1110         (ada_collect_symbol_completion_matches)
1111         (ada_add_global_exceptions): Update.
1112
1113 2019-01-15  Tom Tromey  <tom@tromey.com>
1114
1115         * progspace.h (program_space) <objfiles_safe_range>: New
1116         typedef.
1117         <objfiles_safe>: New method.
1118         * objfiles.h (class all_objfiles_safe): Remove.
1119         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1120         * jit.c (jit_inferior_exit_hook): Update.
1121
1122 2019-01-17  Tom Tromey  <tom@tromey.com>
1123
1124         * progspace.h (program_space) <objfiles_range>: New typedef.
1125         <objfiles>: New method.
1126         <objfiles_head>: Rename from objfiles.
1127         (object_files): Update.
1128         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1129         * guile/scm-pretty-print.c
1130         (ppscm_find_pretty_printer_from_objfiles): Update.
1131         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1132         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1133         Update.
1134         * python/py-progspace.c (pspy_get_objfiles): Update.
1135         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1136         Update.
1137         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1138         (objfpy_lookup_objfile_by_build_id): Update.
1139         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1140         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1141         Update.
1142         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1143         (expand_symtab_containing_pc, lookup_objfile_from_block)
1144         (lookup_static_symbol, basic_lookup_transparent_type)
1145         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1146         (find_line_symtab, info_sources_command)
1147         (default_collect_symbol_completion_matches_break_on)
1148         (make_source_files_completion_list, find_main_name): Update.
1149         * symmisc.c (print_symbol_bcache_statistics)
1150         (print_objfile_statistics, maintenance_print_symbols)
1151         (maintenance_print_msymbols, maintenance_print_objfiles)
1152         (maintenance_info_symtabs, maintenance_check_symtabs)
1153         (maintenance_expand_symtabs, maintenance_info_line_tables):
1154         Update.
1155         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1156         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1157         (map_overlay_command, unmap_overlay_command)
1158         (simple_overlay_update, expand_symtabs_matching)
1159         (map_symbol_filenames): Update.
1160         * symfile-debug.c (set_debug_symfile): Update.
1161         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1162         Update.
1163         * source.c (select_source_symtab, forget_cached_source_info):
1164         Update.
1165         * solib.c (solib_read_symbols): Update.
1166         * solib-spu.c (append_ocl_sos): Update.
1167         * psymtab.c (maintenance_print_psymbols)
1168         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1169         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1170         * printcmd.c (info_symbol_command): Update.
1171         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1172         Update.
1173         * objfiles.h (class all_objfiles): Remove.
1174         * objfiles.c (have_partial_symbols, have_full_symbols)
1175         (have_minimal_symbols, qsort_cmp, update_section_map)
1176         (shared_objfile_contains_address_p)
1177         (default_iterate_over_objfiles_in_search_order): Update.
1178         * objc-lang.c (info_selectors_command, info_classes_command)
1179         (find_methods): Update.
1180         * minsyms.c (find_solib_trampoline_target): Update.
1181         * maint.c (maintenance_info_sections)
1182         (maintenance_translate_address, count_symtabs_and_blocks):
1183         Update.
1184         * main.c (captured_main_1): Update.
1185         * linux-thread-db.c (try_thread_db_load_from_pdir)
1186         (has_libpthread): Update.
1187         * linespec.c (iterate_over_all_matching_symtabs)
1188         (search_minsyms_for_name): Update.
1189         * jit.c (jit_find_objf_with_entry_addr): Update.
1190         * hppa-tdep.c (find_unwind_entry)
1191         (hppa_lookup_stub_minimal_symbol): Update.
1192         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1193         Update.
1194         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1195         (elf_gnu_ifunc_resolve_by_got): Update.
1196         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1197         * dwarf-index-write.c (save_gdb_index_command): Update.
1198         * cp-support.c (add_symbol_overload_list_qualified): Update.
1199         * breakpoint.c (create_overlay_event_breakpoint)
1200         (create_longjmp_master_breakpoint)
1201         (create_std_terminate_master_breakpoint)
1202         (create_exception_master_breakpoint): Update.
1203         * blockframe.c (find_pc_partial_function): Update.
1204         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1205         (ada_collect_symbol_completion_matches)
1206         (ada_add_global_exceptions): Update.
1207
1208 2019-01-17  Tom Tromey  <tom@tromey.com>
1209
1210         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1211         declare VEC.
1212         (solib_target_parse_libraries): Change return type.
1213         (library_list_start_segment, library_list_start_section)
1214         (library_list_end_library, library_list_start_library); Update.
1215         (solib_target_free_library_list): Remove.
1216         (solib_target_parse_libraries): Remove cleanup.  Change return
1217         type.
1218         (solib_target_current_sos): Update.
1219
1220 2019-01-17  Tom Tromey  <tromey@bapiya>
1221
1222         * valprint.c: Replace "the the" with "the".
1223         * symtab.c: Replace "the the" with "the".
1224         * solib.c: Replace "the the" with "the".
1225         * solib-dsbt.c: Replace "the the" with "the".
1226         * linespec.c: Replace "the the" with "the".
1227         * dwarf2loc.h: Replace "the the" with "the".
1228         * amd64-windows-tdep.c: Replace "the the" with "the".
1229         * aarch64-tdep.c: Replace "the the" with "the".
1230
1231 2019-01-16  Keith Seitz  <keiths@redhat.com>
1232
1233         PR gdb/23773
1234         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1235         <builder>: Rename to ..
1236         <m_builder>: ... this and make private.
1237         (dwarf2_cu::get_builder): New method.  Change all users of
1238         `builder' to use this method.
1239         (dwarf2_start_symtab): Move to ...
1240         (dwarf2_cu::start_symtab): ... here.  Update all callers
1241         (setup_type_unit_groups): Move to ...
1242         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1243         callers.
1244         (dwarf2_cu::reset_builder): New method.
1245         (process_full_compunit, process_full_type_unit): Use
1246         dwarf2_cu::reset_builder.
1247         (follow_die_offset): Record the ancestor CU if it is different
1248         from the followed DIE's CU.
1249         (follow_die_sig_1): Likewise.
1250
1251 2019-01-15  Tom Tromey  <tom@tromey.com>
1252
1253         * remote.c (class remote_state) <buf>: Now a char_vector.
1254         <buf_size>: Remove.
1255         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1256         parameter.
1257         (remote_target::getpkt_or_notif_sane_1)
1258         (remote_target::getpkt_sane)
1259         (remote_target::getpkt_or_notif_sane): Likewise.
1260         (class remote_target) <putpkt>: New overload.
1261         (remote_target::read_frame): Change type of "buf_p".  Remove
1262         sizeof_p parameter.
1263         (packet_ok): New overload.
1264         (packet_check_result): New overload.
1265         Update all uses.
1266
1267 2019-01-14  Tom Tromey  <tom@tromey.com>
1268
1269         * remote-notif.c (handle_notification, remote_notif_ack)
1270         (remote_notif_parse): Make "buf" const.
1271         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1272         const.
1273         (remote_notif_parse, remote_notif_ack, handle_notification):
1274         Likewise.
1275         * remote.c (remote_notif_stop_parse): Make "buf" const.
1276         (remote_target::remote_parse_stop_reply): Make "buf" const.
1277         (remote_notif_stop_ack): Make "buf" const.
1278
1279 2019-01-14  Tom Tromey  <tom@tromey.com>
1280
1281         * remote.c (remote_console_output): Make parameter const.
1282
1283 2019-01-14  Tom Tromey  <tom@tromey.com>
1284
1285         * target-debug.h (target_debug_print_signals): Constify.
1286         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1287         * procfs.c (procfs_target::pass_signals): Update.
1288         * linux-nat.c (linux_nat_target::pass_signals): Update.
1289         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1290         * target-delegates.c: Rebuild.
1291         * remote.c (remote_target::program_signals): Update.
1292         (remote_target::pass_signals): Update.
1293         * target.c (target_pass_signals): Constify argument.
1294         (target_program_signals): Likewise.
1295         * target.h (struct target_ops) <pass_signals, program_signals>:
1296         Constify argument.
1297         (target_pass_signals, target_program_signals): Constify argument.
1298
1299 2019-01-14  Tom Tromey  <tom@tromey.com>
1300
1301         PR tui/28819:
1302         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1303
1304 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1305
1306         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1307         field.
1308         * rs6000-tdep.c: Include reggroups.h.
1309         (IS_V_ALIAS_PSEUDOREG): Define.
1310         (rs6000_register_name): Return names for the "vX" aliases.
1311         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1312         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1313         aliases.  Call default_register_reggroup_p for all other
1314         pseudo-registers.
1315         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1316         New functions.
1317         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1318         Handle "vX" aliases.
1319         (v_alias_pseudo_register_collect): New function.
1320         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1321         (rs6000_gdbarch_init): Initialize "vX" aliases as
1322         pseudo-registers.  Restore registration of
1323         rs6000_pseudo_register_reggroup_p with
1324         set_tdesc_pseudo_register_reggroup_p.
1325
1326 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1327
1328         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1329         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1330         set_gdbarch_num_pseudo_regs.
1331
1332 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1333
1334         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1335         Remove arg prefixname, add do_set and do_show.
1336         Add member functions set_list and show_list.
1337         * cli/cli-style.c (class cli_style_option): Update accordingly.
1338         (style_set_list): Move to file scope.
1339         (style_show_list): Likewise.
1340         (set_style): Call help_list.
1341         (show_style): Call cmd_show_list.
1342         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1343         Update to use the new macro.
1344
1345 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1346
1347         * ada-lang.c (_initialize_ada_language): Expand the help text
1348         for the "catch exception" command.
1349
1350 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1351
1352         * symtab.c (matching_obj_sections): Initialize obj,
1353         declare it closer to its usage.
1354
1355 2019-01-10  Tom Tromey  <tom@tromey.com>
1356
1357         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1358         (basic_inf_threads_range): Remove.
1359         (inf_threads_range, inf_non_exited_threads_range)
1360         (safe_inf_threads_range): Use next_adapter.
1361
1362 2019-01-10  Keith Seitz  <keiths@redhat.com>
1363
1364         PR gdb/23712
1365         PR symtab/23010
1366         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1367         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1368
1369 2019-01-10  Keith Seitz  <keiths@redhat.com>
1370
1371         PR gdb/23712
1372         PR symtab/23010
1373         * dictionary.c (pending_to_vector): Remove.
1374         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1375         Remove _1 suffix, replacing functions of the same name.  Update
1376         all callers.
1377         (dict_create_hashed, dict_create_hashed_expandable)
1378         (dict_create_linear, dict_create_linear_expandable, dict_free)
1379         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1380         Make functions static.
1381
1382 2019-01-10  Keith Seitz  <keiths@redhat.com>
1383
1384         PR gdb/23712
1385         PR symtab/23010
1386         * dictionary.h (struct dictionary): Replace declaration with
1387         multidictionary.
1388         (dict_create_hashed, dict_create_hashed_expandable)
1389         (dict_create_linear, dict_create_linear_expandable)
1390         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1391         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1392         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1393         taking multidictionary argument.
1394         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1395         * block.h (struct block) <dict>: Change to multidictionary
1396         and rename `multidict'.
1397         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1398         symmisc.c: Update all dictionary references to multidictionary.
1399
1400 2019-01-10  Keith Seitz  <keiths@redhat.com>
1401
1402         PR gdb/23712
1403         PR symtab/23010
1404         * dictionary.c: Include unordered_map.
1405         (pending_to_vector): New function.
1406         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1407         Rewrite the non-"_1" functions to take vector instead
1408         of linked list.
1409         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1410         "new" _1 versions of the same name.
1411         (multidictionary): Define.
1412         (std::hash<enum language): New definition.
1413         (collate_pending_symbols_by_language, mdict_create_hashed)
1414         (mdict_create_hashed_expandable, mdict_create_linear)
1415         (mdict_create_linear_expandable, mdict_free)
1416         (find_language_dictionary, create_new_language_dictionary)
1417         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1418         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1419         (mdict_size, mdict_empty): New functions.
1420         * dictionary.h (mdict_iterator): Define.
1421
1422 2019-01-10  Pedro Alves  <palves@redhat.com>
1423
1424         * breakpoint.c (read_uploaded_action)
1425         (create_tracepoint_from_upload): Adjust to use
1426         gdb::unique_xmalloc_ptr.
1427         * ctf.c (ctf_write_uploaded_tp):
1428         (SET_ARRAY_FIELD): Use emplace_back.
1429         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1430         * tracefile-tfile.c (tfile_write_uploaded_tp):
1431         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1432         gdb::unique_xmalloc_ptr.
1433         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1434         at_string, cond_string, cmd_strings>: Replace char pointers
1435         with gdb::unique_xmalloc_ptr.
1436
1437 2019-01-10  Pedro Alves  <palves@redhat.com>
1438
1439         * solib-target.c (library_list_start_library): Don't xstrdup name.
1440
1441 2019-01-10  Pedro Alves  <palves@redhat.com>
1442
1443         * mdebugread.c (parse_partial_symbols): Use
1444         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1445
1446 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1447
1448         * linux-fork.c (scoped_switch_fork_info)
1449         <~scoped_switch_fork_info>: Fix incorrect variable name.
1450
1451 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1452
1453         * linux-fork.c (scoped_switch_fork_info)
1454         <scoped_switch_fork_info>: Make explicit.
1455         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1456
1457 2019-01-10  Tom Tromey  <tom@tromey.com>
1458
1459         * objfiles.h (objfile::reset_psymtabs): Update.
1460         * objfiles.c (objfile::objfile): Update.
1461         * psymtab.h (psymtab_storage::obstack): Update.
1462         (psymtab_storage::m_obstack): Use gdb::optional.
1463         (class psymtab_storage): Update comment.  Remove objfile
1464         parameter.
1465         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1466
1467 2019-01-10  Tom Tromey  <tom@tromey.com>
1468
1469         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1470         <free_psymtabs>: Now private.
1471         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1472         (allocate_psymtab): Use new method.
1473
1474 2019-01-10  Tom Tromey  <tom@tromey.com>
1475
1476         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1477         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1478         * mdebugread.c (parse_partial_symbols): Use
1479         allocate_dependencies.
1480         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1481         allocate_dependencies.
1482         (process_psymtab_comp_unit_reader)
1483         (build_type_psymtab_dependencies): Likewise.
1484         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1485
1486 2019-01-10  Tom Tromey  <tom@tromey.com>
1487
1488         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1489         PSYMBOL_SET_LANGUAGE.
1490         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1491
1492 2019-01-10  Tom Tromey  <tom@tromey.com>
1493
1494         * psymtab.h (psymtab_storage::obstack): New method.
1495         <m_obstack>: Rename from obstack; now private.
1496         * psymtab.c (psymtab_storage): Update.
1497         * dwarf2read.c (create_addrmap_from_index)
1498         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1499         Update.
1500
1501 2019-01-10  Tom Tromey  <tom@tromey.com>
1502
1503         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1504         * objfiles.h (objfile::reset_psymtabs): New method.
1505
1506 2019-01-10  Tom Tromey  <tom@tromey.com>
1507
1508         * symmisc.c (print_symbol_bcache_statistics): Update.
1509         (print_objfile_statistics): Update.
1510         * symfile.c (reread_symbols): Update.
1511         * psymtab.h (class psymtab_storage): New.
1512         * psymtab.c (psymtab_storage): New constructor.
1513         (~psymtab_storage): New destructor.
1514         (require_partial_symbols): Update.
1515         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1516         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1517         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1518         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1519         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1520         (start_psymtab_common, end_psymtab_common)
1521         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1522         (allocate_psymtab): Update.
1523         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1524         Update.
1525         (dump_psymtab_addrmap, maintenance_print_psymbols)
1526         (maintenance_check_psymtabs): Update.
1527         (class objfile_psymtabs): Move to objfiles.h.
1528         * psympriv.h (discard_psymtab): Now inline.
1529         (psymtab_discarder::psymtab_discarder): Update.
1530         (psymtab_discarder::~psymtab_discarder): Update.
1531         (ALL_OBJFILE_PSYMTABS): Rewrite.
1532         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1533         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1534         Remove fields.
1535         <partial_symtabs>: New field.
1536         (class objfile_psymtabs): Move from psymtab.h.  Update.
1537         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1538         psymbol_cache.
1539         (objfile::~objfile): Don't destroy psymbol_cache.
1540         * mdebugread.c (parse_partial_symbols): Update.
1541         * dwarf2read.c (create_addrmap_from_index)
1542         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1543         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1544         (add_partial_subprogram, dwarf2_ranges_read): Update.
1545         * dwarf-index-write.c (write_address_map)
1546         (write_one_signatured_type, recursively_write_psymbols)
1547         (class debug_names, class debug_names, write_psymtabs_to_index):
1548         Update.
1549
1550 2019-01-10  Tom Tromey  <tom@tromey.com>
1551
1552         * symtab.h (SYMBOL_SET_NAMES): Update.
1553         (symbol_set_names): Update.
1554         (MSYMBOL_SET_NAMES): Update.
1555         * symtab.c (symbol_set_names): Change argument to be an
1556         objfile_per_bfd_storage.
1557         * psymtab.c (add_psymbol_to_bcache): Update.
1558         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1559
1560 2019-01-10  Tom Tromey  <tom@tromey.com>
1561
1562         * symtab.c (create_demangled_names_hash): Change argument to be an
1563         objfile_per_bfd_storage.
1564         (symbol_set_names): Update.
1565
1566 2019-01-10  Tom Tromey  <tom@tromey.com>
1567
1568         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1569         init_psymbol_list.
1570         * psymtab.c (init_psymbol_list): Do nothing if already called.
1571         * psympriv.h (init_psymbol_list): Add comment.
1572         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1573         init_psymbol_list.
1574         * dbxread.c (dbx_symfile_read): Unconditionally call
1575         init_psymbol_list.
1576
1577 2019-01-10  Tom Tromey  <tom@tromey.com>
1578
1579         * xcoffread.c (scan_xcoff_symtab): Update.
1580         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1581         "where".
1582         * mdebugread.c (parse_partial_symbols)
1583         (handle_psymbol_enumerators): Update.
1584         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1585         * dbxread.c (read_dbx_symtab): Update.
1586         * psympriv.h (psymbol_placement): New enum.
1587         (add_psymbol_to_list): Update.
1588
1589 2019-01-10  Tom Tromey  <tom@tromey.com>
1590
1591         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1592         static_psymbols parameters.
1593         (scan_xcoff_symtab): Update.
1594         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1595         static_psymbols parameters.
1596         * psympriv.h (start_psymtab_common): Update.
1597         * mdebugread.c (parse_partial_symbols): Update.
1598         * dwarf2read.c (create_partial_symtab): Update.
1599         * dbxread.c (read_dbx_symtab): Update.
1600         (start_psymtab): Remove global_psymbols and static_psymbols
1601         parameters.
1602
1603 2019-01-10  Tom Tromey  <tom@tromey.com>
1604
1605         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1606         * psymtab.c (allocate_psymtab): Add comment.
1607         * psympriv.h (allocate_psymtab): Add comment.
1608         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1609         initializations.
1610         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1611
1612 2019-01-10  Tom Tromey  <tom@tromey.com>
1613
1614         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1615         Don't declare.
1616         * mipsread.c: Include mdebugread.h.
1617         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1618         Declare.
1619         * elfread.c: Include mdebugread.h.
1620
1621 2019-01-09  Tom Tromey  <tom@tromey.com>
1622
1623         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1624         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1625         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1626         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1627         (psym_lookup_symbol, psym_find_last_source_symtab)
1628         (psym_forget_cached_source_info, psym_print_stats)
1629         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1630         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1631         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1632         (psym_find_compunit_symtab_by_address)
1633         (maintenance_print_psymbols, maintenance_info_psymtabs)
1634         (maintenance_check_psymtabs): Use ranged for.
1635         * psymtab.h (class objfile_psymtabs): New.
1636         (require_partial_symbols): Return objfile_psymtabs.
1637         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1638
1639 2019-01-09  Tom Tromey  <tom@tromey.com>
1640
1641         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1642         (find_pc_mapped_section, list_overlays_command)
1643         (map_overlay_command, unmap_overlay_command)
1644         (simple_overlay_update): Use all_objfiles.
1645         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1646         * printcmd.c (info_symbol_command): Use all_objfiles.
1647         * objfiles.h (ALL_OBJSECTIONS): Remove.
1648         * maint.c (maintenance_translate_address): Use all_objfiles.
1649         * gcore.c (gcore_create_callback): Use all_objfiles.
1650         (objfile_find_memory_regions): Likewise.
1651
1652 2019-01-09  Tom Tromey  <tom@tromey.com>
1653
1654         * symtab.c (find_line_symtab, info_sources_command)
1655         (make_source_files_completion_list): Use objfile_compunits.
1656         * source.c (select_source_symtab): Use objfile_compunits.
1657         * objfiles.h (struct objfile): Update comment.
1658         (ALL_OBJFILES): Remove.
1659         (ALL_FILETABS): Remove.
1660         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1661         objfile_compunits.
1662
1663 2019-01-09  Tom Tromey  <tom@tromey.com>
1664
1665         * symmisc.c (print_objfile_statistics, dump_objfile)
1666         (maintenance_print_symbols): Use compunit_filetabs.
1667         * source.c (forget_cached_source_info_for_objfile): Use
1668         compunit_filetabs.
1669         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1670         (ALL_FILETABS): Use compunit_filetabs.
1671         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1672         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1673
1674 2019-01-09  Tom Tromey  <tom@tromey.com>
1675
1676         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1677         (compunit_filetabs): New.
1678         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1679         compunit_filetabs.
1680         (info_sources_command, make_source_files_completion_list): Remove
1681         declaration.
1682         * symmisc.c (print_objfile_statistics, dump_objfile)
1683         (maintenance_print_symbols): Remove declaration.
1684         (maintenance_info_symtabs): Use compunit_filetabs.
1685         (maintenance_info_line_tables): Likewise.
1686         * source.c (select_source_symtab): Change local variable name.
1687         (forget_cached_source_info_for_objfile): Remove declaration.
1688         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1689         * objfiles.c (objfile_relocate1): Remove declaration.
1690         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1691         declaration.
1692         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1693         * coffread.c (coff_symtab_read): Remove declaration.
1694         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1695         compunit_filetabs.
1696
1697 2019-01-09  Tom Tromey  <tom@tromey.com>
1698
1699         * symtab.c (lookup_objfile_from_block)
1700         (find_pc_sect_compunit_symtab, search_symbols)
1701         (default_collect_symbol_completion_matches_break_on): Use
1702         objfile_compunits.
1703         * objfiles.h (ALL_COMPUNITS): Remove.
1704         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1705         * cp-support.c (add_symbol_overload_list_qualified): Use
1706         objfile_compunits.
1707         * ada-lang.c (ada_collect_symbol_completion_matches)
1708         (ada_add_global_exceptions): Use objfile_compunits.
1709
1710 2019-01-09  Tom Tromey  <tom@tromey.com>
1711
1712         * source.c (select_source_symtab)
1713         (forget_cached_source_info_for_objfile): Remove declaration.
1714         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1715         declaration.
1716         * maint.c (count_symtabs_and_blocks): Remove declaration.
1717         * cp-support.c (add_symbol_overload_list_qualified): Remove
1718         declaration.
1719         * coffread.c (coff_symtab_read): Remove declaration.
1720         * symtab.c (lookup_symbol_in_objfile_symtabs)
1721         (basic_lookup_transparent_type_1): Use objfile_compunits.
1722         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1723         (info_sources_command, search_symbols)
1724         (default_collect_symbol_completion_matches_break_on)
1725         (make_source_files_completion_list): Remove declaration.
1726         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1727         (ada_collect_symbol_completion_matches)
1728         (ada_add_global_exceptions): Remove declaration.
1729         * linespec.c (iterate_over_all_matching_symtabs): Use
1730         objfile_compunits.
1731         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1732         (class objfile_compunits): New.
1733         (ALL_COMPUNITS): Use objfile_compunits.
1734         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1735         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1736         objfile_compunits.
1737         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1738
1739 2019-01-09  Tom Tromey  <tom@tromey.com>
1740
1741         * symtab.c (search_symbols)
1742         (default_collect_symbol_completion_matches_break_on): Use
1743         objfile_msymbols.
1744         * ada-lang.c (ada_lookup_simple_minsym)
1745         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1746         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1747         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1748         objfile_msymbols.
1749         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1750         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1751         * objc-lang.c (find_methods): Use objfile_msymbols.
1752         (info_selectors_command, info_classes_command): Likewise.
1753         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1754         * objfiles.h (class objfile_msymbols): New.
1755         (ALL_OBJFILE_MSYMBOLS): Remove.
1756         (ALL_MSYMBOLS): Remove.
1757
1758 2019-01-09  Tom Tromey  <tom@tromey.com>
1759
1760         * common/next-iterator.h (next_adapter): Add Iterator template
1761         parameter.
1762         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1763         (class all_objfiles_safe): New.
1764         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1765         * objfiles.c (put_objfile_before): Update comment.
1766         (add_separate_debug_objfile): Likewise.
1767         (free_all_objfiles): Use all_objfiles_safe.
1768         (objfile_purge_solibs): Likewise.
1769
1770 2019-01-09  Tom Tromey  <tom@tromey.com>
1771
1772         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1773         (expand_symtab_containing_pc, lookup_static_symbol)
1774         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1775         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1776         all_objfiles.
1777         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1778         * breakpoint.c (create_overlay_event_breakpoint)
1779         (create_longjmp_master_breakpoint)
1780         (create_std_terminate_master_breakpoint)
1781         (create_exception_master_breakpoint): Use all_objfiles.
1782         * linux-thread-db.c (try_thread_db_load_from_pdir)
1783         (has_libpthread): Use all_objfiles.
1784         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1785         * linespec.c (iterate_over_all_matching_symtabs)
1786         (search_minsyms_for_name): Use all_objfiles.
1787         * maint.c (maintenance_info_sections): Use all_objfiles.
1788         * main.c (captured_main_1): Use all_objfiles.
1789         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1790         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1791         * guile/scm-pretty-print.c
1792         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1793         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1794         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1795         (maintenance_print_msymbols): Use all_objfiles.
1796         * source.c (select_source_symtab): Use all_objfiles.
1797         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1798         * symfile.c (remove_symbol_file_command)
1799         (expand_symtabs_matching, map_symbol_filenames): Use
1800         all_objfiles.
1801         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1802         all_objfiles.
1803         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1804         * objc-lang.c (find_methods): Use all_objfiles.
1805         * objfiles.c (have_partial_symbols, have_full_symbols)
1806         (have_minimal_symbols, qsort_cmp)
1807         (default_iterate_over_objfiles_in_search_order): Use
1808         all_objfiles.
1809         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1810         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1811         (maintenance_check_psymtabs): Use all_objfiles.
1812         (ALL_PSYMTABS): Remove.
1813         * compile/compile-object-run.c (do_module_cleanup): Use
1814         all_objfiles.
1815         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1816         * cp-support.c (add_symbol_overload_list_qualified): Use
1817         all_objfiles.
1818         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1819         Use all_objfiles.
1820         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1821         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1822         all_objfiles.
1823         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1824         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1825         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1826         Uses all_objfiles.
1827         * solib.c (solib_read_symbols): Use all_objfiles
1828
1829 2019-01-09  Tom Tromey  <tom@tromey.com>
1830
1831         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1832         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1833         all_objfiles.
1834         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1835         * symmisc.c (print_symbol_bcache_statistics)
1836         (print_objfile_statistics, maintenance_print_objfiles)
1837         (maintenance_info_symtabs, maintenance_check_symtabs)
1838         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1839         all_objfiles.
1840         * source.c (forget_cached_source_info): Use all_objfiles.
1841         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1842         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1843         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1844         * objfiles.c (update_section_map): Use all_objfiles.
1845         (shared_objfile_contains_address_p): Likewise.
1846         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1847         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1848
1849 2019-01-09  Tom Tromey  <tom@tromey.com>
1850
1851         * common/next-iterator.h: New file.
1852         * objfiles.h (class all_objfiles): New.
1853         (struct objfile_iterator): New.
1854
1855 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1856
1857         * NEWS: Move the description of the changed "frame", "select-frame",
1858          and "info frame" commands to the Changed commands section.
1859
1860 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1861
1862         * gdbtypes.c (check_stub_method_group): Remove handling of old
1863         mangling schemes.
1864         * linespec.c (find_methods): Likewise.
1865         * stabsread.c (read_member_functions): Likewise.
1866         * valops.c (search_struct_method): Likewise.
1867         (value_struct_elt_for_reference): Likewise.
1868         * NEWS: Mention this change.
1869
1870 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1871
1872         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1873         print_source_lines.
1874         * source.c (print_source_lines_base): Update line number check.
1875         (print_source_lines): New function.
1876         (source_lines_range::source_lines_range): New function.
1877         * source.h (class source_lines_range): New class.
1878         (print_source_lines): New declaration.
1879
1880 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1881
1882         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1883
1884 2019-01-08  Tom Tromey  <tom@tromey.com>
1885             Simon Marchi  <simon.marchi@ericsson.com>
1886
1887         PR gdb/24060
1888         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1889         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1890         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1891         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1892         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1893         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1894
1895 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1896
1897         * source.c (select_source_symtab): Move header comment to
1898         declaration in source.h.
1899         (forget_cached_source_info_for_objfile): Likewise.
1900         (forget_cached_source_info): Likewise.
1901         (identify_source_line): Likewise.
1902         * source.h (identify_source_line): Move declaration from symtab.h
1903         and add comment from source.c
1904         (print_source_lines): Likewise.
1905         (forget_cached_source_info_for_objfile): Likewise.
1906         (forget_cached_source_info): Likewise.
1907         (select_source_symtab): Likewise.
1908         (enum print_source_lines_flag): Move definition from symtab.h.
1909         * symtab.h (identify_source_line): Move declaration to source.h.
1910         (print_source_lines): Likewise.
1911         (forget_cached_source_info_for_objfile): Likewise.
1912         (forget_cached_source_info): Likewise.
1913         (select_source_symtab): Likewise.
1914         (enum print_source_lines_flag): Move definition to source.h.
1915         * tui/tui-hooks.c: Add 'source.h' include.
1916
1917 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1918
1919         * source.c (print_source_lines_base): Handle requests to print
1920         reverse line number sequences, and guard against empty lines
1921         string.
1922
1923 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1924
1925         * source.c (print_source_lines_base): Fix skip of '\r' if next
1926         character is '\n'.
1927
1928 2019-01-06  Tom Tromey  <tom@tromey.com>
1929
1930         * c-exp.y (struct c_parse_state) <macro_original_text,
1931         expansion_obstack>: New member.
1932         (macro_original_text, expansion_obstack): Remove globals.
1933         (scan_macro_expansion, scanning_macro_expansion)
1934         (finished_macro_expansion): Update.
1935         (scan_macro_cleanup): Remove.
1936         (yylex, c_parse): Update.
1937
1938 2019-01-06  Tom Tromey  <tom@tromey.com>
1939
1940         * c-exp.y (struct c_parse_state) <strings>: New member.
1941         (operator_stoken): Update.
1942
1943 2019-01-06  Tom Tromey  <tom@tromey.com>
1944
1945         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1946         (union type_stack_elt) <typelist_val>: Now a pointer to
1947         std::vector.
1948         (type_stack_cleanup): Don't declare.
1949         (push_typelist): Update.
1950         * parse.c (pop_typelist): Return a std::vector.
1951         (push_typelist): Take a std::vector.
1952         (follow_types): Update.  Do not free args.
1953         (type_stack_cleanup): Remove.
1954         * c-exp.y (struct c_parse_state): New.
1955         (cpstate): New global.
1956         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1957         (nonempty_typelist): Update.
1958         (func_mod): Create a new vector.
1959         (c_parse): Create a c_parse_state.
1960         (check_parameter_typelist): Do not delete params.
1961         (function_method): Update.  Do not delete type_list.
1962
1963 2019-01-06  Tom Tromey  <tom@tromey.com>
1964
1965         PR gdb/28155:
1966         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1967         check_typedef.
1968         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1969         (print_return_value): Likewise.
1970
1971 2019-01-05  Tom Tromey  <tom@tromey.com>
1972
1973         * contrib/cleanup_check.py: Remove.
1974         * contrib/gcc-with-excheck: Remove.
1975         * contrib/exsummary.py: Remove.
1976         * contrib/excheck.py: Remove.
1977
1978 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1979
1980         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1981         NULL. Initialize tpprev to NULL instead of assigning it
1982         to NULL on the next statement.
1983         * windows-nat.c (windows_delete_thread): Remove check for
1984         main_thread_id before printing thread exit notifications.
1985         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1986         Remove thread ID check against main_thread_id.
1987         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1988         windows_delete_thread.
1989         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1990
1991 2019-01-04  Tom Tromey  <tom@tromey.com>
1992
1993         * compile/compile.c (_initialize_compile): Use upper case for
1994         metasyntactic variables.
1995         * symmisc.c (_initialize_symmisc): Use upper case for
1996         metasyntactic variables.
1997         * psymtab.c (_initialize_psymtab): Use upper case for
1998         metasyntactic variables.
1999         * demangle.c (demangle_command): Use upper case for metasyntactic
2000         variables.
2001         (_initialize_demangler): Likewise.
2002         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2003         variables.
2004
2005 2019-01-03  Tom Tromey  <tom@tromey.com>
2006
2007         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2008
2009 2019-01-03  Tom Tromey  <tom@tromey.com>
2010
2011         * python/py-symtab.c (salpy_str): Update.
2012         (struct salpy_sal_object) <symtab>: Now a PyObject.
2013         (salpy_dealloc): Update.
2014         (del_objfile_sal): Use gdbpy_ref.
2015
2016 2019-01-03  Tom Tromey  <tom@tromey.com>
2017
2018         * python/py-type.c (convert_field): Use new_reference.  Return
2019         gdbpy_ref.
2020         (make_fielditem): Return gdbpy_ref.
2021         (typy_fields): Update.
2022         (typy_getitem): Update.
2023         (field_name): Return gdbpy_ref.  Use new_reference.
2024         (typy_iterator_iternext): Update.
2025
2026 2019-01-03  Tom Tromey  <tom@tromey.com>
2027
2028         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2029
2030 2019-01-03  Tom Tromey  <tom@tromey.com>
2031
2032         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2033         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2034         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2035         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2036         (pspy_set_type_printers): Likewise.
2037         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2038         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2039         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2040         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2041         (objfpy_set_type_printers): Likewise.
2042
2043 2019-01-03  Tom Tromey  <tom@tromey.com>
2044
2045         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2046         (gdbpy_print_stack): Use gdbpy_err_fetch.
2047         * python/python-internal.h (class gdbpy_err_fetch): New class.
2048         (class gdbpy_enter) <m_error_type, m_error_value,
2049         m_error_traceback>: Remove.
2050         <m_error>: New member.
2051         (gdbpy_exception_to_string): Don't declare.
2052         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2053         * python/py-value.c (convert_value_from_python): Use
2054         gdbpy_err_fetch.
2055         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2056         gdbpy_exception_to_string.
2057         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2058         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2059         gdbpy_err_fetch.
2060
2061 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2062
2063         * linux-nat.c (delete_lwp_cleanup): Delete.
2064         (struct lwp_deleter): New struct.
2065         (lwp_info_up): New typedef.
2066         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2067         lwp_info_up.
2068
2069 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2070
2071         * linux-fork.c (class scoped_switch_fork_info): New class.
2072         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2073
2074 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2075
2076         * valops.c (find_overload_match): Remove use of null_cleanup, and
2077         calls to do_cleanups.
2078
2079 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2080
2081         * compile/compile-cplus-types.c
2082         (compile_cplus_instance::decl_name): Handle changes to
2083         cp_func_name.
2084         * cp-support.c (cp_func_name): Update header comment, update
2085         return type.
2086         * cp-support.h (cp_func_name): Update return type in declaration.
2087         * valops.c (find_overload_match): Move temp_func local to top
2088         level of function and change its type.  Use temp_func to hold and
2089         delete temporary string obtained from cp_func_name.
2090
2091 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2092
2093         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2094         gdb::char_vector, remove cleanup, and update uses of `msg`.
2095
2096 2019-01-03  Jim Wilson  <jimw@sifive.com>
2097
2098         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2099
2100 2019-01-02  Tom Tromey  <tom@tromey.com>
2101
2102         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2103         (tdesc_parse_xml): Remove cleanups.
2104         * target-descriptions.h (make_cleanup_free_target_description):
2105         Don't declare.
2106         (target_desc_deleter): New struct.
2107         (target_desc_up): New typedef.
2108         * target-descriptions.c (target_desc_deleter::operator()): Rename
2109         from free_target_description.
2110         (make_cleanup_free_target_description): Remove.
2111
2112 2019-01-02  Tom Tromey  <tom@tromey.com>
2113
2114         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2115         constructor, destructor.
2116         (linespec_parser): Remove typedef.
2117         (~linespec_parser): Rename from linespec_parser_delete.
2118         (linespec_lex_to_end, linespec_complete_label)
2119         (linespec_complete): Update.
2120         (decode_line_full): Remove cleanups.
2121         (decode_line_1): Update.
2122
2123 2019-01-02  Tom Tromey  <tom@tromey.com>
2124
2125         * python/python-internal.h (inferior_to_inferior_object): Change
2126         return type.
2127         * python/py-exitedevent.c (create_exited_event_object): Update.
2128         * python/py-inferior.c (inferior_to_inferior_object): Return
2129         gdbpy_ref.
2130         (python_new_inferior, python_inferior_deleted)
2131         (thread_to_thread_object, delete_thread_object)
2132         (build_inferior_list, gdbpy_selected_inferior): Update.
2133         * python/py-infthread.c (create_thread_object): Update.  Also fail
2134         if inferior_to_inferior_object fails.
2135
2136 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2137
2138         * inferior.h (class inferior) <displaced_step_state>: New field.
2139         * infrun.h (struct displaced_step_state): Move here from
2140         infrun.c.  Initialize fields, add constructor.
2141         <inf>: Remove field.
2142         <reset>: New method.
2143         * infrun.c (struct displaced_step_inferior_state): Move to
2144         infrun.h.
2145         (displaced_step_inferior_states): Remove.
2146         (get_displaced_stepping_state): Adust.
2147         (displaced_step_in_progress_any_inferior): Adjust.
2148         (displaced_step_in_progress_thread): Adjust.
2149         (displaced_step_in_progress): Adjust.
2150         (add_displaced_stepping_state): Remove.
2151         (get_displaced_step_closure_by_addr): Adjust.
2152         (remove_displaced_stepping_state): Remove.
2153         (infrun_inferior_exit): Call displaced_step_state.reset.
2154         (use_displaced_stepping): Don't check for NULL.
2155         (displaced_step_prepare_throw): Call
2156         get_displaced_stepping_state.
2157         (displaced_step_fixup): Don't check for NULL.
2158         (prepare_for_detach): Don't check for NULL.
2159
2160 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2161
2162         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2163          in case of call that did not complete.
2164
2165 2019-01-02  Andrey Utkin  <autkin@undo.io>
2166
2167         * symfile.c (find_separate_debug_file): Fix search of debug files for
2168         remote debuggee.
2169
2170 2019-01-02  Tom Tromey  <tom@tromey.com>
2171
2172         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2173         indentation.
2174         * python/py-frame.c (frapy_older): Remove cast.
2175         (frapy_newer): Likewise.
2176         * python/py-breakpoint.c (local_setattro): Remove cast.
2177         * python/py-arch.c (archpy_name): Remove local variable.
2178         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2179
2180 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2181
2182         * unittests/basic_string_view/element_access/char/empty.cc:
2183         Fix year range in copyright header.
2184
2185 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2186
2187         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2188         Delete.
2189         <operator==>: Update with for removed field.
2190         <hash>: Likewise.
2191         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2192         <isa_features>: ...this.
2193         <abi_features>: New field.
2194         (riscv_isa_flen): Update comment.
2195         (riscv_abi_xlen): New declaration.
2196         (riscv_abi_flen): New declaration.
2197         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2198         isa_features.
2199         (riscv_abi_xlen): New function.
2200         (riscv_isa_flen): Update to get answer from isa_features.
2201         (riscv_abi_flen): New function.
2202         (riscv_has_fp_abi): Update to get answer from abi_features.
2203         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2204         xlen and flen.
2205         (riscv_call_info) <xlen, flen>: Update comment.
2206         (riscv_call_arg_struct): Remove invalid assertions
2207         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2208         is removed.
2209         (riscv_gdbarch_init): Gather isa features and abi features
2210         separately, ensure both match on the gdbarch when reusing an old
2211         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2212         a target with 64-bit float hardware.
2213
2214 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2215
2216         * source.c (search_command_helper): Stop reverse search
2217         when line 1 has been searched.
2218
2219 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2220
2221         * record-full.c (record_full_base_target::close): Rewrite
2222         record_full_core_buf_list free logic.
2223
2224 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2225
2226         * break-catch-syscall.c (print_one_catch_syscall): xfree
2227         the last text.
2228
2229 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2230
2231         * top.c (print_gdb_version): Update Copyright year in version
2232         message.
2233
2234 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2235
2236         Update copyright year range in all GDB files.
2237
2238 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2239
2240         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2241
2242 For older changes see ChangeLog-2018.
2243 \f
2244 Local Variables:
2245 mode: change-log
2246 left-margin: 8
2247 fill-column: 74
2248 version-control: never
2249 coding: utf-8
2250 End:
2251