gdb/ChangeLog

   1 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         * f-lang.c (value_from_host_double): Moved to...
   4         * value.c (value_from_host_double): ...here.
   5         * value.h (value_from_host_double): Declare.
   6         * guile/scm-math.c (vlscm_convert_typed_number): Use
   7         value_from_host_double.
   8         (vlscm_convert_number): Likewise.
   9         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
  10         * python/py-value.c (convert_value_from_python): Likewise.
  11
  12 2019-03-06  Tom Tromey  <tom@tromey.com>
  13
  14         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
  15
  16 2019-03-06  Tom Tromey  <tom@tromey.com>
  17
  18         * utils.h (free_current_contents): Don't declare.
  19         * utils.c (free_current_contents): Remove.
  20
  21 2019-03-06  Tom Tromey  <tom@tromey.com>
  22
  23         * top.c (quit_force): Update.
  24         * main.c (captured_command_loop): Update.
  25         * common/new-op.c (operator new): Update.
  26         * common/common-exceptions.c (struct catcher)
  27         <save_cleanup_chain>: Remove member.
  28         (exceptions_state_mc_init): Update.
  29         (exception_try_scope_entry): Return nullptr.
  30         (exception_try_scope_exit, exception_rethrow)
  31         (throw_exception_sjlj, throw_exception_cxx): Update.
  32         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
  33         (all_cleanups, do_cleanups, discard_cleanups)
  34         (discard_final_cleanups, save_cleanups, save_final_cleanups)
  35         (restore_cleanups, restore_final_cleanups): Don't declare.
  36         (do_final_cleanups): Remove parameter.
  37         * common/cleanups.c (cleanup_chain, make_cleanup)
  38         (make_cleanup_dtor, all_cleanups, do_cleanups)
  39         (discard_my_cleanups, discard_cleanups)
  40         (discard_final_cleanups, save_my_cleanups, save_cleanups)
  41         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
  42         (null_cleanup): Remove.
  43         (do_final_cleanups): Remove parameter.
  44
  45 2019-03-06  Tom Tromey  <tom@tromey.com>
  46
  47         * remote.c (remote_target::remote_parse_stop_reply): Use
  48         unique_xmalloc_ptr.
  49
  50 2019-03-06  Tom Tromey  <tom@tromey.com>
  51
  52         * stabsread.c (struct stabs_field_info): Rename from field_info.
  53         <list, fnlist>: Add initializers.
  54         <obstack>: New member.
  55         (read_member_functions, read_struct_fields, read_baseclasses):
  56         Allocate on obstack.  Don't use cleanups.
  57         (read_one_struct_field, read_member_functions, read_struct_fields)
  58         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
  59         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
  60         (read_struct_type): Update.
  61
  62 2019-03-06  Tom Tromey  <tom@tromey.com>
  63
  64         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
  65         * common/filestuff.h (make_cleanup_close): Don't declare.
  66         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
  67         Remove.
  68
  69 2019-03-06  Tom Tromey  <tom@tromey.com>
  70
  71         * solib-aix.c: Use make_scope_exit.
  72
  73 2019-03-06  Tom Tromey  <tom@tromey.com>
  74
  75         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
  76         Use make_scope_exit.
  77
  78 2019-03-06  Tom Tromey  <tom@tromey.com>
  79
  80         * solib-svr4.c (disable_probes_interface): Remove parameter.
  81         (svr4_handle_solib_event): Use make_scope_exit.
  82
  83 2019-03-06  Tom Tromey  <tom@tromey.com>
  84
  85         * remote.c (struct stop_reply_deleter): Remove.
  86         (stop_reply_up): Update.
  87         (struct stop_reply): Derive from notif_event.  Don't typedef.
  88         <regcache>: Now a std::vector.
  89         (stop_reply_xfree): Remove.
  90         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
  91         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
  92         (remote_target::discard_pending_stop_replies): Use delete.
  93         (remote_target::remote_parse_stop_reply): Update.
  94         (remote_target::process_stop_reply): Update.
  95         * remote-notif.h (struct notif_event): Add virtual destructor.
  96         Remove "dtr" member.
  97         (struct notif_client) <alloc_event>: Return a unique_ptr.
  98         (notif_event_xfree): Don't declare.
  99         (notif_event_up): New typedef.
 100         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
 101         (notif_event_xfree, do_notif_event_xfree): Remove.
 102         (remote_notif_state_xfree): Update.
 103
 104 2019-03-06  Tom Tromey  <tom@tromey.com>
 105
 106         * infrun.c (displaced_step_clear_cleanup): Now a
 107         forward_scope_exit type.
 108         (displaced_step_prepare_throw): Update.
 109         (displaced_step_fixup): Update.
 110
 111 2019-03-06  Tom Tromey  <tom@tromey.com>
 112
 113         * inferior.h (class inferior): Update comment.
 114         * gdbthread.h (class thread_info): Update comment.
 115
 116 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
 117             Tom Tromey  <tom@tromey.com>
 118
 119         * stabsread.h (struct stab_section_list): Remove.
 120         (coffstab_build_psymtabs): Update.
 121         * dbxread.c (symbuf_sections): Now a std::vector.
 122         (sect_idx): New global.
 123         (fill_symbuf): Update.
 124         (coffstab_build_psymtabs): Change type of stabsects parameter.
 125         Update.
 126         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
 127         std::vector.
 128         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
 129         (coff_locate_sections): Update.
 130         (coff_symfile_read): Remove cleanups.  Update.
 131         (init_stringtab): Add storage parameter.
 132         (free_stringtab, free_stringtab_cleanup): Remove.
 133         (init_lineno): Add storage parameter.
 134         (free_linetab, free_linetab_cleanup): Remove.
 135
 136 2019-03-06  Pedro Alves  <palves@redhat.com>
 137
 138         * linux-fork.c (fork_info::clobber_regs): Delete.
 139         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
 140         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
 141         comment.  Adjust.
 142         (scoped_switch_fork_info::scoped_switch_fork_info)
 143         (checkpoint_command, linux_fork_context): Adjust
 144         fork_save_infrun_state calls.
 145
 146 2019-03-06  Pedro Alves  <palves@redhat.com>
 147
 148         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
 149         (inf_has_multiple_threads): Return 'bool' and rewrite using
 150         inferior_info::threads().
 151
 152 2019-03-06  Pedro Alves  <palves@redhat.com>
 153
 154         * linux-fork.c: Include <list>.
 155         (fork_list): Now a std::list instance.
 156         (fork_info): Add ctor, dtor, and in-class initialize all fields.
 157         (forks_exist_p, find_last_fork): Adjust.
 158         (new_fork): Delete.
 159         (one_fork_p): New.
 160         (add_fork): Adjust.
 161         (free_fork): Delete, folded into fork_info::~fork_info().
 162         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
 163         Adjust.
 164         (init_fork_list): Delete.
 165         (linux_fork_killall, linux_fork_mourn_inferior)
 166         (linux_fork_detach, info_checkpoints_command): Adjust.
 167         (_initialize_linux_fork): No longer call init_fork_list.
 168
 169 2019-03-06  Pedro Alves  <palves@redhat.com>
 170
 171         * linux-fork.c (new_fork): New, split out of ...
 172         (add_fork): ... this.  Return void.  Move "first fork" special
 173         case from here, to ...
 174         (checkpoint_command): ... here.
 175         * linux-linux.h (add_fork): Return void.
 176
 177 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 178
 179         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
 180
 181 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 182             Chris January  <chris.january@arm.com>
 183             David Lecomber  <david.lecomber@arm.com>
 184
 185         * f-exp.y: New token, UNOP_INTRINSIC.
 186         (exp): New pattern using UNOP_INTRINSIC token.
 187         (f77_keywords): Add 'abs' keyword.
 188         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
 189         (value_from_host_double): New function.
 190         (evaluate_subexp_f): Support UNOP_ABS.
 191
 192 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 193
 194         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
 195         types.
 196
 197 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 198
 199         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
 200         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
 201         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
 202
 203 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 204
 205         * f-exp.y (convert_to_kind_type): Handle more type kinds.
 206
 207 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 208             Chris January  <chris.january@arm.com>
 209
 210         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
 211         * f-exp.y: Define 'KIND' token.
 212         (exp): New pattern for KIND expressions.
 213         (ptype): Handle types with a kind extension.
 214         (direct_abs_decl): Extend to spot kind extensions.
 215         (f77_keywords): Add 'kind' to the list.
 216         (push_kind_type): New function.
 217         (convert_to_kind_type): New function.
 218         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
 219         * parse.c (operator_length_standard): Likewise.
 220         * parser-defs.h (enum type_pieces): Add tp_kind.
 221         * std-operator.def: Add UNOP_KIND.
 222
 223 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 224
 225         * f-exp.y (f_parse): Set yydebug.
 226
 227 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 228
 229         * f-lang.c (evaluate_subexp_f): New function.
 230         (exp_descriptor_f): New global.
 231         (f_language_defn): Use exp_descriptor_f instead of
 232         exp_descriptor_standard.
 233
 234 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 235
 236         * f-exp.y (struct token): Add comments.
 237         (dot_ops): Remove uppercase versions and the end marker.
 238         (f77_keywords): Likewise.
 239         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
 240         entries in the dot_ops array are case insensitive, and use
 241         strncasecmp to compare strings.  Also some whitespace cleanup in
 242         this area.  Similar for the f77_keywords array, except entries in
 243         this list might be case sensitive.
 244
 245 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 246
 247         * f-exp.y (struct f77_boolean_val): Add comments.
 248         (boolean_values): Remove uppercase versions, and end marker.
 249         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
 250         and use strncasecmp to achieve case insensitivity.  Additionally,
 251         perform whitespace cleanup around this code.
 252
 253 2019-03-06  Tom Tromey  <tromey@adacore.com>
 254
 255         * remote-sim.c (gdbsim_target_open): Use result of
 256         gdb_argv::release.
 257
 258 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
 259         Dirk Schubert  <dirk.schubert@arm.com>
 260         Chris January  <chris.january@arm.com>
 261
 262         * eval.c (evaluate_subexp_standard): Call Fortran argument
 263         wrapping logic.
 264         * f-lang.c (struct value): A value which can be passed into a
 265         Fortran function call.
 266         (fortran_argument_convert): Wrap Fortran arguments in a pointer
 267         where appropriate.
 268         (struct type): Value ready for a Fortran function call.
 269         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
 270         is needed.
 271         * f-lang.h (fortran_argument_convert): Declaration.
 272         (fortran_preserve_arg_pointer): Declaration.
 273         * infcall.c (value_arg_coerce): Call Fortran argument logic.
 274
 275 2019-03-05  Tom Tromey  <tromey@adacore.com>
 276
 277         * python/py-prettyprint.c (print_string_repr): Remove #if.
 278         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
 279
 280 2019-03-05  Tom Tromey  <tromey@adacore.com>
 281
 282         * target.c (the_dummy_target): Move later.  Change type to
 283         "dummy_target".
 284         (initialize_targets): Don't initialize the_dummy_target.
 285
 286 2019-03-05  Tom Tromey  <tromey@adacore.com>
 287
 288         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
 289         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
 290
 291 2019-03-05  Tom Tromey  <tromey@adacore.com>
 292
 293         * windows-nat.c (windows_nat_target::attach)
 294         (windows_nat_target::detach): Don't call gdb_flush.
 295         * valprint.c (generic_val_print, val_print, val_print_string):
 296         Don't call gdb_flush.
 297         * utils.c (defaulted_query): Don't call gdb_flush.
 298         * typeprint.c (print_type_scalar): Don't call gdb_flush.
 299         * target.c (target_announce_detach): Don't call gdb_flush.
 300         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
 301         * remote.c (extended_remote_target::attach): Don't call
 302         gdb_flush.
 303         * procfs.c (procfs_target::detach): Don't call gdb_flush.
 304         * printcmd.c (do_examine): Don't call gdb_flush.
 305         (info_display_command): Don't call gdb_flush.
 306         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
 307         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
 308         * memattr.c (info_mem_command): Don't call gdb_flush.
 309         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
 310         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
 311         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
 312         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
 313         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
 314         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
 315         (gnu_nat_target::detach): Don't call gdb_flush.
 316         * f-valprint.c (f_val_print): Don't call gdb_flush.
 317         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
 318         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
 319         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
 320         gdb_flush.
 321         * c-valprint.c (c_val_print): Don't call gdb_flush.
 322         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
 323
 324 2019-03-05  Tom Tromey  <tromey@adacore.com>
 325
 326         * varobj.c (update_dynamic_varobj_children): Update.
 327         (install_default_visualizer): Use reset, not release.
 328         * value.c (set_internalvar): Update.
 329         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
 330         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
 331         ATTRIBUTE_UNUSED_RESULT.
 332
 333 2019-03-05  Tom Tromey  <tromey@adacore.com>
 334
 335         * remote.c (class scoped_remote_fd) <release>: Add
 336         ATTRIBUTE_UNUSED_RESULT.
 337
 338 2019-03-05  Tom Tromey  <tromey@adacore.com>
 339
 340         * macroexp.c (struct macro_buffer) <release>: Add
 341         ATTRIBUTE_UNUSED_RESULT.
 342
 343 2019-03-05  Tom Tromey  <tromey@adacore.com>
 344
 345         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
 346         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
 347         ATTRIBUTE_UNUSED_RESULT.
 348
 349 2019-03-05  Tom Tromey  <tromey@adacore.com>
 350
 351         * common/scoped_fd.h (class scoped_fd) <release>: Add
 352         ATTRIBUTE_UNUSED_RESULT.
 353
 354 2019-03-05  Tom Tromey  <tromey@adacore.com>
 355
 356         * parser-defs.h (struct parser_state) <release>: Add
 357         ATTRIBUTE_UNUSED_RESULT.
 358
 359 2019-03-05  Tom Tromey  <tromey@adacore.com>
 360
 361         * utils.h (class gdb_argv) <release>: Add
 362         ATTRIBUTE_UNUSED_RESULT.
 363         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
 364
 365 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 366
 367         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
 368         for-loop range, to avoid compiler warnings.
 369
 370         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
 371         avoid compiler warnings about unused variables.
 372
 373         * NEWS: Mention end of support for native debugging on MS-Windows
 374         before XP.
 375
 376         PR gdb/24292
 377         * common/netstuff.c:
 378         * gdbserver/gdbreplay.c
 379         * gdbserver/remote-utils.c:
 380         * ser-tcp.c:
 381         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
 382         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
 383         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
 384         'getaddrinfo' and 'freeaddrinfo' were not available before
 385         Windows XP, and mingw.org's MinGW headers by default define
 386         _WIN32_WINNT to 0x500.
 387
 388 2019-03-01  Gary Benson <gbenson@redhat.com>
 389
 390         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
 391
 392 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
 393             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 394
 395         PR gdb/8527
 396         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
 397         set_sigint_trap, clear_sigint_trap.
 398
 399 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 400
 401         * target.c (target_detach): Clear the regcache and the
 402         frame cache.
 403
 404 2019-02-27  Pedro Alves  <palves@redhat.com>
 405
 406         * utils.c (set_screen_size): When we cap the height/width sizes,
 407         tweak the corresponding command variable to show "unlimited":
 408
 409 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
 410             Pedro Alves  <palves@redhat.com>
 411
 412         * utils.c (set_screen_size): Reduce "infinite" rows and columns
 413         before calling rl_set_screen_size.
 414
 415 2019-02-27  Tom Tromey  <tromey@adacore.com>
 416
 417         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
 418         define.
 419         * python/py-value.c: Remove Python 2.4 workaround.
 420         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
 421         workaround.
 422         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
 423         Python 2.4 workaround.
 424         * python/python-internal.h: Remove Python 2.4 comment.
 425         (Py_ssize_t): Don't define.
 426         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
 427         (gdb_Py_DECREF): Remove Python 2.4 workaround.
 428         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
 429         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
 430         * python/python.c (do_start_initialization): Remove Python 2.4
 431         workaround.
 432         * python/py-prettyprint.c (class dummy_python_frame): Remove.
 433         (print_children): Remove Python 2.4 workaround.
 434         * python/py-inferior.c (buffer_procs): Remove Python 2.4
 435         workaround.
 436         (CHARBUFFERPROC_NAME): Remove.
 437         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
 438         Python 2.4 workaround.
 439
 440 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 441
 442         * NEWS: Note minimum Python version.
 443
 444 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 445
 446         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
 447         code from these functions.  Remove corresponding ifdefs.  Use
 448         Py_buffer_up instead of explicit calls to PyBuffer_Release.
 449         Remove gotos and target of gotos.
 450         (infpy_search_memory): Likewise.
 451
 452 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 453
 454         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
 455         (hppa_gdbarch_init): Don't register deleted functions with
 456         gdbarch.
 457
 458 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 459
 460         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
 461         (h8300_unwind_sp): Delete.
 462         (h8300_dummy_id): Delete.
 463         (h8300_gdbarch_init): Don't register deleted functions with
 464         gdbarch.
 465
 466 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 467
 468         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
 469         (ft32_unwind_pc): Delete.
 470         (ft32_unwind_sp): Delete.
 471         (ft32_gdbarch_init): Don't register deleted functions with
 472         gdbarch.
 473
 474 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 475
 476         * gdb/frv-tdep.c (frv_dummy_id): Delete.
 477         (frv_unwind_pc): Delete.
 478         (frv_unwind_sp): Delete.
 479         (frv_gdbarch_init): Don't register deleted functions with
 480         gdbarch.
 481
 482 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 483
 484         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
 485         (riscv_unwind_pc): Delete.
 486         (riscv_unwind_sp): Delete.
 487         (riscv_gdbarch_init): Don't register deleted functions with
 488         gdbarch.
 489
 490 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 491
 492         * gdb/csky-tdep.c (csky_dummy_id): Delete.
 493         (csky_unwind_pc): Delete.
 494         (csky_unwind_sp): Delete.
 495         (csky_gdbarch_init): Don't register deleted functions with
 496         gdbarch.
 497
 498 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 499
 500         * gdb/cris-tdep.c (cris_dummy_id): Delete.
 501         (cris_unwind_pc): Delete.
 502         (cris_unwind_sp): Delete.
 503         (cris_gdbarch_init): Don't register deleted functions with
 504         gdbarch.
 505
 506 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 507
 508         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
 509         (bfin_unwind_pc): Delete.
 510         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
 511
 512 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 513
 514         * gdb/arm-tdep.c (arm_dummy_id): Delete.
 515         (arm_unwind_pc): Delete.
 516         (arm_unwind_sp): Delete.
 517         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
 518
 519 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 520
 521         * gdb/arc-tdep.c (arc_dummy_id): Delete.
 522         (arc_unwind_pc): Delete.
 523         (arc_unwind_sp): Delete.
 524         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
 525
 526 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 527
 528         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
 529         (alpha_unwind_pc): Delete.
 530         (alpha_gdbarch_init): Don't register deleted functions with
 531         gdbarch.
 532
 533 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 534
 535         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
 536         (aarch64_unwind_pc): Delete.
 537         (aarch64_unwind_sp): Delete.
 538         (aarch64_gdbarch_init): Don't register deleted functions with
 539         gdbarch.
 540
 541 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 542
 543         * gdbtypes.c (type_align): Don't consider static members when
 544         computing structure alignment.
 545
 546 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 547
 548         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
 549         return 0 for other types.
 550         * arch-utils.c (default_type_align): Always return 0.
 551         * gdbarch.h: Regenerate.
 552         * gdbarch.sh (type_align): Extend comment.
 553         * gdbtypes.c (type_align): Add additional comments, always call
 554         gdbarch_type_align before applying the default rules.
 555         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
 556         generic code will then apply a suitable default.
 557         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
 558         types, return 0 for other types.
 559
 560 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 561
 562         * NEWS: Create a new section for the next release branch.
 563         Rename the section of the current branch, now that it has
 564         been cut.
 565
 566 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 567
 568         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
 569         * version.in: Bump version to 8.3.50.DATE-git.
 570
 571 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
 572
 573         * aix-thread.c (ptid_cmp): Remove unused variable.
 574         (get_signaled_thread): Likewise.
 575         (store_regs_user_thread): Likewise.
 576         (store_regs_kernel_thread): Likewise.
 577         (fetch_regs_kernel_thread): Remove shadowed variable.
 578
 579 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 580
 581         * features/riscv/32bit-cpu.xml: Add register numbers.
 582         * features/riscv/32bit-fpu.c: Regenerate.
 583         * features/riscv/32bit-fpu.xml: Add register numbers.
 584         * features/riscv/64bit-cpu.xml: Add register numbers.
 585         * features/riscv/64bit-fpu.c: Regenerate.
 586         * features/riscv/64bit-fpu.xml: Add register numbers.
 587
 588 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
 589
 590         * NEWS: Mention two argument form of gdb.Value constructor.
 591         * python/py-value.c (convert_buffer_and_type_to_value): New
 592         function.
 593         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
 594         Add support for handling an optional second argument.  Call
 595         convert_buffer_and_type_to_value as appropriate.
 596         * python/python-internal.h (Py_buffer_deleter): New struct.
 597         (Py_buffer_up): New typedef.
 598
 599 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
 600
 601         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
 602         instead of releasing ownership.
 603
 604 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
 605
 606         * dwarf2read.c (open_and_init_dwp_file): Call
 607         elf_numsections instead of bfd_count_sections to initialize
 608         dwp_file->num_sections.
 609
 610 2019-02-25  Tom Tromey  <tromey@adacore.com>
 611
 612         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
 613
 614 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 615
 616         * gcore.in: Add '--readnever' option when invoking GDB.
 617
 618 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 619
 620         * MAINTAINERS: Update my email address.
 621
 622 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 623
 624         * build-id.c (build_id_to_debug_bfd_1): New function.
 625         (build_id_to_debug_bfd): Look for separate debug file in
 626         sysroot.
 627
 628 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 629
 630         * gdbarch.sh: Update the copyright year range that is placed into
 631         generated files.
 632
 633 2019-02-22  Keith Seitz  <keiths@redhat.com>
 634
 635         PR symtab/23853
 636         * linespec.c (create_sals_line_offset): Search for the default
 637         symtab's filename instead of its fullname.
 638
 639 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 640
 641         * NEWS: Update style defaults.
 642
 643 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 644
 645         * main.c (captured_main_1): Disable styling in batch mode.
 646
 647 2019-02-20  Tom Tromey  <tom@tromey.com>
 648
 649         * symtab.c (symtab_symbol_info): Fix typos.
 650
 651 2019-02-20  Tom Tromey  <tromey@adacore.com>
 652
 653         * findcmd.c (_initialize_mem_search): Use upper case for
 654         metasyntactic variables.
 655
 656 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
 657
 658         * aarch64-tdep.c (aarch64_add_reggroups): New function.
 659         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
 660
 661 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
 662
 663         * top.h (source_file_name): Change to std::string.
 664         * top.c (source_file_name): Likewise.
 665         (command_line_input): Adjust.
 666         * cli/cli-script.c (script_from_file): Adjust.
 667
 668 2019-02-19  Tom Tromey  <tromey@adacore.com>
 669
 670         * ravenscar-thread.c
 671         (ravenscar_thread_target::update_thread_list): Don't call
 672         ada_build_task_list.
 673         * ada-lang.h (ada_build_task_list): Don't declare.
 674         * ada-tasks.c (struct ada_tasks_inferior_data)
 675         <task_list_valid_p>: Now bool.
 676         (read_known_tasks, ada_task_list_changed)
 677         (ada_tasks_invalidate_inferior_data): Update.
 678         (read_known_tasks_array): Return bool.
 679         (read_known_tasks_list): Likewise.
 680         (read_known_tasks): Return void.
 681         (ada_build_task_list): Now static.
 682
 683 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 684
 685         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
 686         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
 687
 688 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 689
 690         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
 691         variant for ada_tasks_pspace_data_handle and
 692         ada_tasks_inferior_data_handle.
 693         (ada_tasks_pspace_data_cleanup): New function.
 694         (ada_tasks_inferior_data_cleanup): New function.
 695
 696 2019-02-17  Tom Tromey  <tom@tromey.com>
 697
 698         * macrotab.h (macro_source_fullname): Return a std::string.
 699         * macrotab.c (macro_include, check_for_redefinition)
 700         (macro_undef, macro_lookup_definition, foreach_macro)
 701         (foreach_macro_in_scope): Update.
 702         (macro_source_fullname): Return a std::string.
 703         * macrocmd.c (show_pp_source_pos): Update.
 704
 705 2019-02-17  Tom Tromey  <tom@tromey.com>
 706
 707         * macrocmd.c (show_pp_source_pos): Style the file names.
 708
 709 2019-02-17  Tom Tromey  <tom@tromey.com>
 710
 711         PR tui/24197:
 712         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 713
 714 2019-02-17  Tom Tromey  <tom@tromey.com>
 715
 716         * ada-lang.c (user_select_syms): Use filtered printing.
 717         * utils.c (wrap_style): New global.
 718         (desired_style): Remove.
 719         (emit_style_escape): Add stream parameter.
 720         (set_output_style, reset_terminal_style, prompt_for_continue):
 721         Update.
 722         (flush_wrap_buffer): Only flush gdb_stdout.
 723         (wrap_here): Set wrap_style.
 724         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 725         treat escape sequences as a character.  Change when wrap buffer is
 726         flushed.
 727         (fputs_styled): Do not set the output style when the default is
 728         requested.
 729         * ui-style.h (struct ui_file_style) <is_default>: New method.
 730         * source.c (print_source_lines_base): Emit escape sequences in one
 731         piece.
 732
 733 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 734
 735         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 736         integers and enumeration types.
 737
 738 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 739
 740         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 741         instead of lookup_symbol_in_language
 742         (do_exact_match): New function.
 743         (ada_get_symbol_name_matcher): Return do_exact_match when
 744         doing a verbatim match.
 745
 746 2019-02-15  Tom Tromey  <tromey@adacore.com>
 747
 748         * ravenscar-thread.c (ravenscar_thread_target::resume)
 749         (ravenscar_thread_target::wait): Special case wildcard requests.
 750
 751 2019-02-15  Tom Tromey  <tromey@adacore.com>
 752
 753         * ravenscar-thread.c (base_ptid): Remove.
 754         (struct ravenscar_thread_target) <close>: New method.
 755         <m_base_ptid>: New member.
 756         <update_inferior_ptid, active_task, task_is_currently_active,
 757         runtime_initialized>: Declare methods.
 758         <ravenscar_thread_target>: Add constructor.
 759         (ravenscar_thread_target::task_is_currently_active)
 760         (ravenscar_thread_target::update_inferior_ptid)
 761         (ravenscar_runtime_initialized): Rename.  Now methods.
 762         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 763         (ravenscar_thread_target::update_thread_list): Update.
 764         (ravenscar_thread_target::active_task): Now method.
 765         (ravenscar_thread_target::store_registers)
 766         (ravenscar_thread_target::prepare_to_store)
 767         (ravenscar_thread_target::prepare_to_store)
 768         (ravenscar_thread_target::mourn_inferior): Update.
 769         (ravenscar_inferior_created): Use "new" to create target.
 770         (ravenscar_thread_target::get_ada_task_ptid): Update.
 771         (_initialize_ravenscar): Don't initialize base_ptid.
 772         (ravenscar_ops): Remove global.
 773
 774 2019-02-15  Tom Tromey  <tromey@adacore.com>
 775
 776         * target.h (push_target): Declare new overload.
 777         * target.c (push_target): New overload, taking an rvalue reference.
 778         * remote.c (remote_target::open_1): Use push_target overload.
 779         * corelow.c (core_target_open): Use push_target overload.
 780
 781 2019-02-15  Tom Tromey  <tromey@adacore.com>
 782
 783         * ravenscar-thread.c (is_ravenscar_task)
 784         (ravenscar_task_is_currently_active): Return bool.
 785         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 786         (_initialize_ravenscar): Remove "(void)".
 787         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 788         Return bool.
 789
 790 2019-02-15  Tom Tromey  <tromey@adacore.com>
 791
 792         * ravenscar-thread.c (ravenscar_runtime_initializer)
 793         (has_ravenscar_runtime, get_running_thread_id)
 794         (ravenscar_thread_target::resume): Fix indentation.
 795
 796 2019-02-15  Tom Tromey  <tromey@adacore.com>
 797
 798         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 799         from ravenscar_arch_ops.
 800         (sparc_ravenscar_ops::fetch_registers)
 801         (sparc_ravenscar_ops::store_registers): Now methods.
 802         (sparc_ravenscar_prepare_to_store): Remove.
 803         (sparc_ravenscar_ops): Redefine.
 804         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 805         methods and destructor.  Remove members.
 806         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 807         (ravenscar_thread_target::store_registers)
 808         (ravenscar_thread_target::prepare_to_store): Update.
 809         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 810         Remove.
 811         (struct ppc_ravenscar_powerpc_ops): Derive from
 812         ravenscar_arch_ops.
 813         (ppc_ravenscar_powerpc_ops::fetch_registers)
 814         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 815         (ppc_ravenscar_powerpc_ops): Redefine.
 816         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 817         (ppc_ravenscar_e500_ops::fetch_registers)
 818         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 819         (ppc_ravenscar_e500_ops): Redefine.
 820         * aarch64-ravenscar-thread.c
 821         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 822         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 823         (aarch64_ravenscar_fetch_registers)
 824         (aarch64_ravenscar_store_registers): Now methods.
 825         (aarch64_ravenscar_ops): Redefine.
 826
 827 2019-02-15  Tom Tromey  <tromey@adacore.com>
 828
 829         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 830         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 831         (ravenscar_thread_target::stopped_by_watchpoint)
 832         (ravenscar_thread_target::stopped_data_address)
 833         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 834
 835 2019-02-15  Tom Tromey  <tromey@adacore.com>
 836
 837         * ravenscar-thread.c: Fix some typos.
 838
 839 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 840             Tom Tromey  <tromey@adacore.com>
 841
 842         * ada-lang.c (ada_exception_sal): Change addr_string to a
 843         std::string.
 844         (create_ada_exception_catchpoint): Update.
 845
 846 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 847             Tom Tromey  <tromey@adacore.com>
 848
 849         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 850         (bp_location_ops): Remove.
 851         (base_breakpoint_allocate_location): Update.
 852         (free_bp_location): Update.
 853         * ada-lang.c (class ada_catchpoint_location)
 854         <ada_catchpoint_location>: Remove ops parameter.
 855         (ada_catchpoint_location_dtor): Remove.
 856         (ada_catchpoint_location_ops): Remove.
 857         (allocate_location_exception): Update.
 858         * breakpoint.h (struct bp_location_ops): Remove.
 859         (class bp_location) <bp_location>: Remove bp_location_ops
 860         parameter.
 861         <~bp_location>: Add destructor.
 862         <ops>: Remove.
 863
 864 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 865             Pedro Alves  <palves@redhat.com>
 866
 867         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 868         'PATH_MAX'.
 869
 870 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 871             Samuel Thibault  <samuel.thibault@gnu.org>
 872             Thomas Schwinge  <thomas@codesourcery.com>
 873
 874         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 875         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 876
 877 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 878
 879         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 880         (check_empty): Use "const char *".
 881
 882         * gnu-nat.c (gnu_nat_target::detach): Instead of
 883         'detach_inferior (pid)' call
 884         'detach_inferior (find_inferior_pid (pid))'.
 885
 886         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 887         'nat/fork-inferior.o'.
 888         * gnu-nat.c: #include "nat/fork-inferior.h".
 889
 890         * gnu-nat.c (gnu_nat_target::detach): Instead of
 891         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 892         * gnu-nat.h: #include "inf-child.h".
 893         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 894         'i386_gnu_nat_target::fetch_registers'.
 895         (gnu_store_registers): Rename/move to
 896         'i386_gnu_nat_target::store_registers'.
 897
 898         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 899         * gnu-nat.h (mach_thread_info): New function.
 900         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 901
 902         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 903
 904 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 905
 906         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 907
 908 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 909
 910         * windows-nat.c (windows_add_thread): Add new parameter
 911         "main_thread_p" with default value set to false.  Update
 912         function documentation as well as all callers.
 913         (windows_delete_thread): Likewise.
 914         (fake_create_process): Update call to windows_add_thread.
 915         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 916         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 917         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 918         call to windows_delete_thread.
 919
 920 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 921
 922         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 923
 924 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 925
 926         * symfile.c (find_separate_debug_file): Use canonical path of
 927         sysroot with child_path instead of gdb_sysroot if it is valid.
 928
 929 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 930
 931         * symfile.c (find_separate_debug_file): Use child_path to
 932         determine if an object file is under a sysroot.
 933
 934 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 935
 936         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 937         unittests/child-path-selftests.c.
 938         * common/pathstuff.c (child_path): New function.
 939         * common/pathstuff.h (child_path): New prototype.
 940         * unittests/child-path-selftests.c: New file.
 941
 942 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 943
 944         * symfile.c (find_separate_debug_file): Look for separate debug
 945         files in debug directories under the sysroot.
 946
 947 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 948
 949         * symtab.h (struct minimal_symbol data_p): New const method.
 950         (struct minimal_symbol text_p): Likewise.
 951         * symtab.c (output_source_filename): Use file name style
 952         to print file name.
 953         (print_symbol_info): Likewise.
 954         (print_msymbol_info): Use address style to print addresses.
 955         Use function name style to print executable text symbols.
 956         (expand_symtab_containing_pc): Use data_p.
 957         (find_pc_sect_compunit_symtab): Likewise.
 958
 959 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 960
 961         * breakpoint.c (describe_other_breakpoints): Use address style
 962         to print addresses.
 963         (say_where): Likewise.
 964
 965 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 966
 967         * ada-typeprint.c (print_func_type): Print function name
 968         style to print function name.
 969         * c-typeprint.c (c_print_type_1): Likewise.
 970
 971 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 972
 973         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 974         for execve.
 975
 976 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 977
 978         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 979         type_stack.
 980
 981 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 982
 983         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 984         TYPE_CODE_REF types.
 985
 986 2019-02-08  Jim Wilson  <jimw@sifive.com>
 987
 988         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 989         (riscv_linux_fregset): New.
 990         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 991
 992 2019-02-07  Tom Tromey  <tom@tromey.com>
 993
 994         * thread.c (thread_cancel_execution_command): Update.
 995         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 996         methods.
 997         (struct thread_fsm_ops): Remove.
 998         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 999         (thread_fsm_should_stop, thread_fsm_return_value)
1000         (thread_fsm_set_finished, thread_fsm_finished_p)
1001         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1002         Don't declare.
1003         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1004         * infrun.c (clear_proceed_status_thread)
1005         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1006         (print_stop_event): Update.
1007         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1008         Add constructor.
1009         (step_command_fsm_ops): Remove.
1010         (new_step_command_fsm): Remove.
1011         (step_1): Update.
1012         (step_command_fsm::should_stop): Rename from
1013         step_command_fsm_should_stop.
1014         (step_command_fsm::clean_up): Rename from
1015         step_command_fsm_clean_up.
1016         (step_command_fsm::do_async_reply_reason): Rename from
1017         step_command_fsm_async_reply_reason.
1018         (struct until_next_fsm): Inherit from thread_fsm.  Add
1019         constructor.
1020         (until_next_fsm_ops): Remove.
1021         (new_until_next_fsm): Remove.
1022         (until_next_fsm::should_stop): Rename from
1023         until_next_fsm_should_stop.
1024         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1025         (until_next_fsm::do_async_reply_reason): Rename from
1026         until_next_fsm_async_reply_reason.
1027         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1028         constructor.  Change type of breakpoint.
1029         (finish_command_fsm_ops): Remove.
1030         (new_finish_command_fsm): Remove.
1031         (finish_command_fsm::should_stop): Rename from
1032         finish_command_fsm_should_stop.
1033         (finish_command_fsm::clean_up): Rename from
1034         finish_command_fsm_clean_up.
1035         (finish_command_fsm::return_value): Rename from
1036         finish_command_fsm_return_value.
1037         (finish_command_fsm::do_async_reply_reason): Rename from
1038         finish_command_fsm_async_reply_reason.
1039         (finish_command): Update.
1040         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1041         Add constructor.
1042         (call_thread_fsm_ops): Remove.
1043         (call_thread_fsm::call_thread_fsm): Rename from
1044         new_call_thread_fsm.
1045         (call_thread_fsm::should_stop): Rename from
1046         call_thread_fsm_should_stop.
1047         (call_thread_fsm::should_notify_stop): Rename from
1048         call_thread_fsm_should_notify_stop.
1049         (run_inferior_call, call_function_by_hand_dummy): Update.
1050         * cli/cli-interp.c (should_print_stop_to_console): Update.
1051         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1052         Add constructor.  Change type of location_breakpoint,
1053         caller_breakpoint.
1054         (until_break_fsm_ops): Remove.
1055         (new_until_break_fsm): Remove.
1056         (until_break_fsm::should_stop): Rename from
1057         until_break_fsm_should_stop.
1058         (until_break_fsm::clean_up): Rename from
1059         until_break_fsm_clean_up.
1060         (until_break_fsm::do_async_reply_reason): Rename from
1061         until_break_fsm_async_reply_reason.
1062         (until_break_command): Update.
1063         * thread-fsm.c: Remove.
1064         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1065
1066 2019-02-07  Tom Tromey  <tom@tromey.com>
1067
1068         * yy-remap.h: Add include guard.
1069         * xtensa-tdep.h: Add include guard.
1070         * xcoffread.h: Rename include guard.
1071         * varobj-iter.h: Add include guard.
1072         * tui/tui.h: Rename include guard.
1073         * tui/tui-winsource.h: Rename include guard.
1074         * tui/tui-wingeneral.h: Rename include guard.
1075         * tui/tui-windata.h: Rename include guard.
1076         * tui/tui-win.h: Rename include guard.
1077         * tui/tui-stack.h: Rename include guard.
1078         * tui/tui-source.h: Rename include guard.
1079         * tui/tui-regs.h: Rename include guard.
1080         * tui/tui-out.h: Rename include guard.
1081         * tui/tui-layout.h: Rename include guard.
1082         * tui/tui-io.h: Rename include guard.
1083         * tui/tui-hooks.h: Rename include guard.
1084         * tui/tui-file.h: Rename include guard.
1085         * tui/tui-disasm.h: Rename include guard.
1086         * tui/tui-data.h: Rename include guard.
1087         * tui/tui-command.h: Rename include guard.
1088         * tic6x-tdep.h: Add include guard.
1089         * target/waitstatus.h: Rename include guard.
1090         * target/wait.h: Rename include guard.
1091         * target/target.h: Rename include guard.
1092         * target/resume.h: Rename include guard.
1093         * target-float.h: Rename include guard.
1094         * stabsread.h: Add include guard.
1095         * rs6000-tdep.h: Add include guard.
1096         * riscv-fbsd-tdep.h: Add include guard.
1097         * regformats/regdef.h: Rename include guard.
1098         * record.h: Rename include guard.
1099         * python/python.h: Rename include guard.
1100         * python/python-internal.h: Rename include guard.
1101         * python/py-stopevent.h: Rename include guard.
1102         * python/py-ref.h: Rename include guard.
1103         * python/py-record.h: Rename include guard.
1104         * python/py-record-full.h: Rename include guard.
1105         * python/py-record-btrace.h: Rename include guard.
1106         * python/py-instruction.h: Rename include guard.
1107         * python/py-events.h: Rename include guard.
1108         * python/py-event.h: Rename include guard.
1109         * procfs.h: Add include guard.
1110         * proc-utils.h: Add include guard.
1111         * p-lang.h: Add include guard.
1112         * or1k-tdep.h: Rename include guard.
1113         * observable.h: Rename include guard.
1114         * nto-tdep.h: Rename include guard.
1115         * nat/x86-linux.h: Rename include guard.
1116         * nat/x86-linux-dregs.h: Rename include guard.
1117         * nat/x86-gcc-cpuid.h: Add include guard.
1118         * nat/x86-dregs.h: Rename include guard.
1119         * nat/x86-cpuid.h: Rename include guard.
1120         * nat/ppc-linux.h: Rename include guard.
1121         * nat/mips-linux-watch.h: Rename include guard.
1122         * nat/linux-waitpid.h: Rename include guard.
1123         * nat/linux-ptrace.h: Rename include guard.
1124         * nat/linux-procfs.h: Rename include guard.
1125         * nat/linux-osdata.h: Rename include guard.
1126         * nat/linux-nat.h: Rename include guard.
1127         * nat/linux-namespaces.h: Rename include guard.
1128         * nat/linux-btrace.h: Rename include guard.
1129         * nat/glibc_thread_db.h: Rename include guard.
1130         * nat/gdb_thread_db.h: Rename include guard.
1131         * nat/gdb_ptrace.h: Rename include guard.
1132         * nat/fork-inferior.h: Rename include guard.
1133         * nat/amd64-linux-siginfo.h: Rename include guard.
1134         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1135         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1136         * nat/aarch64-linux.h: Rename include guard.
1137         * nat/aarch64-linux-hw-point.h: Rename include guard.
1138         * mn10300-tdep.h: Add include guard.
1139         * mips-linux-tdep.h: Add include guard.
1140         * mi/mi-parse.h: Rename include guard.
1141         * mi/mi-out.h: Rename include guard.
1142         * mi/mi-main.h: Rename include guard.
1143         * mi/mi-interp.h: Rename include guard.
1144         * mi/mi-getopt.h: Rename include guard.
1145         * mi/mi-console.h: Rename include guard.
1146         * mi/mi-common.h: Rename include guard.
1147         * mi/mi-cmds.h: Rename include guard.
1148         * mi/mi-cmd-break.h: Rename include guard.
1149         * m2-lang.h: Add include guard.
1150         * location.h: Rename include guard.
1151         * linux-record.h: Rename include guard.
1152         * linux-nat.h: Add include guard.
1153         * linux-fork.h: Add include guard.
1154         * i386-darwin-tdep.h: Rename include guard.
1155         * hppa-linux-offsets.h: Add include guard.
1156         * guile/guile.h: Rename include guard.
1157         * guile/guile-internal.h: Rename include guard.
1158         * gnu-nat.h: Rename include guard.
1159         * gdb-stabs.h: Rename include guard.
1160         * frv-tdep.h: Add include guard.
1161         * f-lang.h: Add include guard.
1162         * event-loop.h: Add include guard.
1163         * darwin-nat.h: Rename include guard.
1164         * cp-abi.h: Rename include guard.
1165         * config/sparc/nm-sol2.h: Rename include guard.
1166         * config/nm-nto.h: Rename include guard.
1167         * config/nm-linux.h: Add include guard.
1168         * config/i386/nm-i386gnu.h: Rename include guard.
1169         * config/djgpp/nl_types.h: Rename include guard.
1170         * config/djgpp/langinfo.h: Rename include guard.
1171         * compile/gcc-cp-plugin.h: Add include guard.
1172         * compile/gcc-c-plugin.h: Add include guard.
1173         * compile/compile.h: Rename include guard.
1174         * compile/compile-object-run.h: Rename include guard.
1175         * compile/compile-object-load.h: Rename include guard.
1176         * compile/compile-internal.h: Rename include guard.
1177         * compile/compile-cplus.h: Rename include guard.
1178         * compile/compile-c.h: Rename include guard.
1179         * common/xml-utils.h: Rename include guard.
1180         * common/x86-xstate.h: Rename include guard.
1181         * common/version.h: Rename include guard.
1182         * common/vec.h: Rename include guard.
1183         * common/tdesc.h: Rename include guard.
1184         * common/selftest.h: Rename include guard.
1185         * common/scoped_restore.h: Rename include guard.
1186         * common/scoped_mmap.h: Rename include guard.
1187         * common/scoped_fd.h: Rename include guard.
1188         * common/safe-iterator.h: Rename include guard.
1189         * common/run-time-clock.h: Rename include guard.
1190         * common/refcounted-object.h: Rename include guard.
1191         * common/queue.h: Rename include guard.
1192         * common/ptid.h: Rename include guard.
1193         * common/print-utils.h: Rename include guard.
1194         * common/preprocessor.h: Rename include guard.
1195         * common/pathstuff.h: Rename include guard.
1196         * common/observable.h: Rename include guard.
1197         * common/netstuff.h: Rename include guard.
1198         * common/job-control.h: Rename include guard.
1199         * common/host-defs.h: Rename include guard.
1200         * common/gdb_wait.h: Rename include guard.
1201         * common/gdb_vecs.h: Rename include guard.
1202         * common/gdb_unlinker.h: Rename include guard.
1203         * common/gdb_unique_ptr.h: Rename include guard.
1204         * common/gdb_tilde_expand.h: Rename include guard.
1205         * common/gdb_sys_time.h: Rename include guard.
1206         * common/gdb_string_view.h: Rename include guard.
1207         * common/gdb_splay_tree.h: Rename include guard.
1208         * common/gdb_setjmp.h: Rename include guard.
1209         * common/gdb_ref_ptr.h: Rename include guard.
1210         * common/gdb_optional.h: Rename include guard.
1211         * common/gdb_locale.h: Rename include guard.
1212         * common/gdb_assert.h: Rename include guard.
1213         * common/filtered-iterator.h: Rename include guard.
1214         * common/filestuff.h: Rename include guard.
1215         * common/fileio.h: Rename include guard.
1216         * common/environ.h: Rename include guard.
1217         * common/common-utils.h: Rename include guard.
1218         * common/common-types.h: Rename include guard.
1219         * common/common-regcache.h: Rename include guard.
1220         * common/common-inferior.h: Rename include guard.
1221         * common/common-gdbthread.h: Rename include guard.
1222         * common/common-exceptions.h: Rename include guard.
1223         * common/common-defs.h: Rename include guard.
1224         * common/common-debug.h: Rename include guard.
1225         * common/cleanups.h: Rename include guard.
1226         * common/buffer.h: Rename include guard.
1227         * common/btrace-common.h: Rename include guard.
1228         * common/break-common.h: Rename include guard.
1229         * cli/cli-utils.h: Rename include guard.
1230         * cli/cli-style.h: Rename include guard.
1231         * cli/cli-setshow.h: Rename include guard.
1232         * cli/cli-script.h: Rename include guard.
1233         * cli/cli-interp.h: Rename include guard.
1234         * cli/cli-decode.h: Rename include guard.
1235         * cli/cli-cmds.h: Rename include guard.
1236         * charset-list.h: Add include guard.
1237         * buildsym-legacy.h: Rename include guard.
1238         * bfin-tdep.h: Add include guard.
1239         * ax.h: Rename include guard.
1240         * arm-linux-tdep.h: Add include guard.
1241         * arm-fbsd-tdep.h: Add include guard.
1242         * arch/xtensa.h: Rename include guard.
1243         * arch/tic6x.h: Add include guard.
1244         * arch/i386.h: Add include guard.
1245         * arch/arm.h: Rename include guard.
1246         * arch/arm-linux.h: Rename include guard.
1247         * arch/arm-get-next-pcs.h: Rename include guard.
1248         * arch/amd64.h: Add include guard.
1249         * arch/aarch64-insn.h: Rename include guard.
1250         * arch-utils.h: Rename include guard.
1251         * annotate.h: Add include guard.
1252         * amd64-darwin-tdep.h: Rename include guard.
1253         * aarch64-linux-tdep.h: Add include guard.
1254         * aarch64-fbsd-tdep.h: Add include guard.
1255         * aarch32-linux-nat.h: Add include guard.
1256
1257 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1258
1259         * macrotab.c (macro_define_internal): New function that
1260         factorizes macro_define_object_internal and macro_define_function
1261         code.
1262         (macro_define_object_internal): Use macro_define_internal.
1263         (macro_define_function): Likewise.
1264
1265 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1266
1267         * macrocmd.c (extract_identifier): Return
1268         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1269         callers.
1270
1271 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1272
1273         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1274
1275 2019-02-05  Tom Tromey  <tom@tromey.com>
1276
1277         * target.c (target_stack::unpush): Move assertion earlier.
1278
1279 2019-01-30  Tom Tromey  <tom@tromey.com>
1280
1281         PR python/23615:
1282         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1283         (gdbpy_parse_and_eval): Likewise.
1284         * python/python-internal.h (gdbpy_allow_threads): New class.
1285
1286 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1287
1288         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1289         (aarch64_fbsd_fpregmap): Move earlier.
1290         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1291         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1292         instead of individual calls to trad_frame_set_reg_addr.
1293         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1294         earlier.
1295         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1296         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1297         instead of individual calls to trad_frame_set_reg_addr.
1298
1299 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1300
1301         * CONTRIBUTE: Replace contribution list with wiki link.
1302
1303 2019-01-25  Tom Tromey  <tom@tromey.com>
1304
1305         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1306
1307 2019-01-25  Tom Tromey  <tom@tromey.com>
1308
1309         * xtensa-linux-nat.c: Fix common/ includes.
1310         * xml-support.h: Fix common/ includes.
1311         * xml-support.c: Fix common/ includes.
1312         * x86-linux-nat.c: Fix common/ includes.
1313         * windows-nat.c: Fix common/ includes.
1314         * varobj.h: Fix common/ includes.
1315         * varobj.c: Fix common/ includes.
1316         * value.c: Fix common/ includes.
1317         * valops.c: Fix common/ includes.
1318         * utils.c: Fix common/ includes.
1319         * unittests/xml-utils-selftests.c: Fix common/ includes.
1320         * unittests/utils-selftests.c: Fix common/ includes.
1321         * unittests/unpack-selftests.c: Fix common/ includes.
1322         * unittests/tracepoint-selftests.c: Fix common/ includes.
1323         * unittests/style-selftests.c: Fix common/ includes.
1324         * unittests/string_view-selftests.c: Fix common/ includes.
1325         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1326         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1327         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1328         * unittests/rsp-low-selftests.c: Fix common/ includes.
1329         * unittests/parse-connection-spec-selftests.c: Fix common/
1330         includes.
1331         * unittests/optional-selftests.c: Fix common/ includes.
1332         * unittests/offset-type-selftests.c: Fix common/ includes.
1333         * unittests/observable-selftests.c: Fix common/ includes.
1334         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1335         * unittests/memrange-selftests.c: Fix common/ includes.
1336         * unittests/memory-map-selftests.c: Fix common/ includes.
1337         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1338         * unittests/function-view-selftests.c: Fix common/ includes.
1339         * unittests/environ-selftests.c: Fix common/ includes.
1340         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1341         * unittests/common-utils-selftests.c: Fix common/ includes.
1342         * unittests/cli-utils-selftests.c: Fix common/ includes.
1343         * unittests/array-view-selftests.c: Fix common/ includes.
1344         * ui-file.c: Fix common/ includes.
1345         * tui/tui-io.c: Fix common/ includes.
1346         * tracepoint.h: Fix common/ includes.
1347         * tracepoint.c: Fix common/ includes.
1348         * tracefile-tfile.c: Fix common/ includes.
1349         * top.h: Fix common/ includes.
1350         * top.c: Fix common/ includes.
1351         * thread.c: Fix common/ includes.
1352         * target/waitstatus.h: Fix common/ includes.
1353         * target/waitstatus.c: Fix common/ includes.
1354         * target.h: Fix common/ includes.
1355         * target.c: Fix common/ includes.
1356         * target-memory.c: Fix common/ includes.
1357         * target-descriptions.c: Fix common/ includes.
1358         * symtab.h: Fix common/ includes.
1359         * symfile.c: Fix common/ includes.
1360         * stap-probe.c: Fix common/ includes.
1361         * spu-linux-nat.c: Fix common/ includes.
1362         * sparc-nat.c: Fix common/ includes.
1363         * source.c: Fix common/ includes.
1364         * solib.c: Fix common/ includes.
1365         * solib-target.c: Fix common/ includes.
1366         * ser-unix.c: Fix common/ includes.
1367         * ser-tcp.c: Fix common/ includes.
1368         * ser-pipe.c: Fix common/ includes.
1369         * ser-base.c: Fix common/ includes.
1370         * selftest-arch.c: Fix common/ includes.
1371         * s12z-tdep.c: Fix common/ includes.
1372         * rust-exp.y: Fix common/ includes.
1373         * rs6000-aix-tdep.c: Fix common/ includes.
1374         * riscv-tdep.c: Fix common/ includes.
1375         * remote.c: Fix common/ includes.
1376         * remote-notif.h: Fix common/ includes.
1377         * remote-fileio.h: Fix common/ includes.
1378         * remote-fileio.c: Fix common/ includes.
1379         * regcache.h: Fix common/ includes.
1380         * regcache.c: Fix common/ includes.
1381         * record-btrace.c: Fix common/ includes.
1382         * python/python.c: Fix common/ includes.
1383         * python/py-type.c: Fix common/ includes.
1384         * python/py-inferior.c: Fix common/ includes.
1385         * progspace.h: Fix common/ includes.
1386         * producer.c: Fix common/ includes.
1387         * procfs.c: Fix common/ includes.
1388         * proc-api.c: Fix common/ includes.
1389         * printcmd.c: Fix common/ includes.
1390         * ppc-linux-nat.c: Fix common/ includes.
1391         * parser-defs.h: Fix common/ includes.
1392         * osdata.c: Fix common/ includes.
1393         * obsd-nat.c: Fix common/ includes.
1394         * nat/x86-linux.c: Fix common/ includes.
1395         * nat/x86-linux-dregs.c: Fix common/ includes.
1396         * nat/x86-dregs.h: Fix common/ includes.
1397         * nat/x86-dregs.c: Fix common/ includes.
1398         * nat/ppc-linux.c: Fix common/ includes.
1399         * nat/mips-linux-watch.h: Fix common/ includes.
1400         * nat/mips-linux-watch.c: Fix common/ includes.
1401         * nat/linux-waitpid.c: Fix common/ includes.
1402         * nat/linux-ptrace.h: Fix common/ includes.
1403         * nat/linux-ptrace.c: Fix common/ includes.
1404         * nat/linux-procfs.c: Fix common/ includes.
1405         * nat/linux-personality.c: Fix common/ includes.
1406         * nat/linux-osdata.c: Fix common/ includes.
1407         * nat/linux-namespaces.c: Fix common/ includes.
1408         * nat/linux-btrace.h: Fix common/ includes.
1409         * nat/linux-btrace.c: Fix common/ includes.
1410         * nat/fork-inferior.c: Fix common/ includes.
1411         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1412         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1413         * nat/aarch64-linux.c: Fix common/ includes.
1414         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1415         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1416         * namespace.h: Fix common/ includes.
1417         * mips-linux-tdep.c: Fix common/ includes.
1418         * minsyms.c: Fix common/ includes.
1419         * mi/mi-parse.h: Fix common/ includes.
1420         * mi/mi-main.c: Fix common/ includes.
1421         * mi/mi-cmd-env.c: Fix common/ includes.
1422         * memrange.h: Fix common/ includes.
1423         * memattr.c: Fix common/ includes.
1424         * maint.h: Fix common/ includes.
1425         * maint.c: Fix common/ includes.
1426         * main.c: Fix common/ includes.
1427         * machoread.c: Fix common/ includes.
1428         * location.c: Fix common/ includes.
1429         * linux-thread-db.c: Fix common/ includes.
1430         * linux-nat.c: Fix common/ includes.
1431         * linux-fork.c: Fix common/ includes.
1432         * inline-frame.c: Fix common/ includes.
1433         * infrun.c: Fix common/ includes.
1434         * inflow.c: Fix common/ includes.
1435         * inferior.h: Fix common/ includes.
1436         * inferior.c: Fix common/ includes.
1437         * infcmd.c: Fix common/ includes.
1438         * inf-ptrace.c: Fix common/ includes.
1439         * inf-child.c: Fix common/ includes.
1440         * ia64-linux-nat.c: Fix common/ includes.
1441         * i387-tdep.c: Fix common/ includes.
1442         * i386-tdep.c: Fix common/ includes.
1443         * i386-linux-tdep.c: Fix common/ includes.
1444         * i386-linux-nat.c: Fix common/ includes.
1445         * i386-go32-tdep.c: Fix common/ includes.
1446         * i386-fbsd-tdep.c: Fix common/ includes.
1447         * i386-fbsd-nat.c: Fix common/ includes.
1448         * guile/scm-type.c: Fix common/ includes.
1449         * guile/guile.c: Fix common/ includes.
1450         * go32-nat.c: Fix common/ includes.
1451         * gnu-nat.c: Fix common/ includes.
1452         * gdbthread.h: Fix common/ includes.
1453         * gdbarch-selftests.c: Fix common/ includes.
1454         * gdb_usleep.c: Fix common/ includes.
1455         * gdb_select.h: Fix common/ includes.
1456         * gdb_bfd.c: Fix common/ includes.
1457         * gcore.c: Fix common/ includes.
1458         * fork-child.c: Fix common/ includes.
1459         * findvar.c: Fix common/ includes.
1460         * fbsd-nat.c: Fix common/ includes.
1461         * event-top.c: Fix common/ includes.
1462         * event-loop.c: Fix common/ includes.
1463         * dwarf2read.c: Fix common/ includes.
1464         * dwarf2loc.c: Fix common/ includes.
1465         * dwarf2-frame.c: Fix common/ includes.
1466         * dwarf-index-cache.c: Fix common/ includes.
1467         * dtrace-probe.c: Fix common/ includes.
1468         * disasm-selftests.c: Fix common/ includes.
1469         * defs.h: Fix common/ includes.
1470         * csky-tdep.c: Fix common/ includes.
1471         * cp-valprint.c: Fix common/ includes.
1472         * cp-support.h: Fix common/ includes.
1473         * cp-support.c: Fix common/ includes.
1474         * corelow.c: Fix common/ includes.
1475         * completer.h: Fix common/ includes.
1476         * completer.c: Fix common/ includes.
1477         * compile/compile.c: Fix common/ includes.
1478         * compile/compile-loc2c.c: Fix common/ includes.
1479         * compile/compile-cplus-types.c: Fix common/ includes.
1480         * compile/compile-cplus-symbols.c: Fix common/ includes.
1481         * command.h: Fix common/ includes.
1482         * cli/cli-dump.c: Fix common/ includes.
1483         * cli/cli-cmds.c: Fix common/ includes.
1484         * charset.c: Fix common/ includes.
1485         * build-id.c: Fix common/ includes.
1486         * btrace.h: Fix common/ includes.
1487         * btrace.c: Fix common/ includes.
1488         * breakpoint.h: Fix common/ includes.
1489         * breakpoint.c: Fix common/ includes.
1490         * ax.h:
1491         (enum agent_op): Fix common/ includes.
1492         * ax-general.c (struct aop_map): Fix common/ includes.
1493         * ax-gdb.c: Fix common/ includes.
1494         * auxv.c: Fix common/ includes.
1495         * auto-load.c: Fix common/ includes.
1496         * arm-tdep.c: Fix common/ includes.
1497         * arch/riscv.c: Fix common/ includes.
1498         * arch/ppc-linux-common.c: Fix common/ includes.
1499         * arch/i386.c: Fix common/ includes.
1500         * arch/arm.c: Fix common/ includes.
1501         * arch/arm-linux.c: Fix common/ includes.
1502         * arch/arm-get-next-pcs.c: Fix common/ includes.
1503         * arch/amd64.c: Fix common/ includes.
1504         * arch/aarch64.c: Fix common/ includes.
1505         * arch/aarch64-insn.c: Fix common/ includes.
1506         * arch-utils.c: Fix common/ includes.
1507         * amd64-windows-tdep.c: Fix common/ includes.
1508         * amd64-tdep.c: Fix common/ includes.
1509         * amd64-sol2-tdep.c: Fix common/ includes.
1510         * amd64-obsd-tdep.c: Fix common/ includes.
1511         * amd64-nbsd-tdep.c: Fix common/ includes.
1512         * amd64-linux-tdep.c: Fix common/ includes.
1513         * amd64-linux-nat.c: Fix common/ includes.
1514         * amd64-fbsd-tdep.c: Fix common/ includes.
1515         * amd64-fbsd-nat.c: Fix common/ includes.
1516         * amd64-dicos-tdep.c: Fix common/ includes.
1517         * amd64-darwin-tdep.c: Fix common/ includes.
1518         * agent.c: Fix common/ includes.
1519         * ada-lang.h: Fix common/ includes.
1520         * ada-lang.c: Fix common/ includes.
1521         * aarch64-tdep.c: Fix common/ includes.
1522
1523 2019-01-25  Tom Tromey  <tom@tromey.com>
1524
1525         * common/create-version.sh: Use common/version.h.
1526
1527 2019-01-24  Pedro Alves  <palves@redhat.com>
1528
1529         * infrun.c (signal_stop, signal_print, signal_program)
1530         (signal_catch, signal_pass): Now arrays instead of pointers.
1531         (update_signals_program_target, do_target_resume)
1532         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1533         * linux-nat.c (linux_nat_target::pass_signals)
1534         (linux_nat_target::create_inferior, linux_nat_target::attach):
1535         Adjust.
1536         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1537         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1538         * procfs.c (procfs_target::pass_signals): Adjust.
1539         * record-full.c (record_full_target::resume): Adjust.
1540         * remote.c (remote_target::pass_signals)
1541         (remote_target::program_signals): Adjust.
1542         * target-debug.h (target_debug_print_signals): Now takes a
1543         gdb::array_view as parameter.  Adjust.
1544         * target.h (target_ops) <pass_signals, program_signals>: Replace
1545         pointer and length parameters with gdb::array_view.
1546         (target_pass_signals, target_program_signals): Likewise.
1547         * target-delegates.c: Regenerate.
1548
1549 2019-01-24  Pedro Alves  <palves@redhat.com>
1550
1551         * common/forward-scope-exit.h
1552         (forward_scope_exit::forward_scope_exit): Pass arguments to
1553         m_bind_function directly, instead of creating a std::bind and
1554         copying that.
1555
1556 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1557
1558         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1559         for static members.
1560         (pass_in_v_vfp_candidate): Likewise.
1561
1562 2019-01-23  Tom Tromey  <tom@tromey.com>
1563             Pedro Alves  <palves@redhat.com>
1564
1565         * regcache.c (class regcache_invalidator): Remove.
1566         (regcache::raw_write): Use make_scope_exit.
1567
1568 2019-01-23  Tom Tromey  <tom@tromey.com>
1569
1570         * ui-out.h (class ui_out_emit_type): Update comment.
1571
1572 2019-01-23  Tom Tromey  <tom@tromey.com>
1573
1574         * infrun.c (fetch_inferior_event): Update comment.
1575
1576 2019-01-23  Tom Tromey  <tom@tromey.com>
1577             Pedro Alves  <palves@redhat.com>
1578
1579         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1580         parameter.
1581         (fetch_inferior_event): Use SCOPE_EXIT.
1582
1583
1584 2019-01-23  Tom Tromey  <tom@tromey.com>
1585             Pedro Alves  <palves@redhat.com>
1586
1587         * infrun.c (disable_thread_events): Delete.
1588         (stop_all_threads): Use SCOPE_EXIT.
1589
1590 2019-01-23  Tom Tromey  <tom@tromey.com>
1591             Pedro Alves  <palves@redhat.com>
1592
1593         * symfile.c: Include forward-scope-exit.h.
1594         (clear_symtab_users_cleanup): Replace forward declaration with
1595         a FORWARD_SCOPE_EXIT.
1596         (syms_from_objfile_1): Use the forward_scope_exit and
1597         gdb::optional instead of cleanup_function.
1598         (reread_symbols): Use the forward_scope_exit instead of
1599         cleanup_function.
1600         (clear_symtab_users_cleanup): Remove function.
1601
1602 2019-01-23  Tom Tromey  <tom@tromey.com>
1603             Pedro Alves  <palves@redhat.com>
1604
1605         * linux-nat.c: Include scope-exit.h.
1606         (cleanup_target_stop): Remove.
1607         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1608         SCOPE_EXIT.
1609
1610 2019-01-23  Tom Tromey  <tom@tromey.com>
1611             Pedro Alves  <palves@redhat.com>
1612
1613         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1614         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1615
1616 2019-01-23  Tom Tromey  <tom@tromey.com>
1617             Andrew Burgess  <andrew.burgess@embecosm.com>
1618             Pedro Alves  <palves@redhat.com>
1619
1620         * infrun.c (fetch_inferior_event): Use scope_exit.
1621         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1622         * top.c (execute_command): Use scope_exit.
1623         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1624         * utils.c (do_bpstat_clear_actions_cleanup)
1625         (make_bpstat_clear_actions_cleanup): Remove.
1626
1627 2019-01-23  Tom Tromey  <tom@tromey.com>
1628             Pedro Alves  <palves@redhat.com>
1629
1630         * infrun.c: Include "common/scope-exit.h"
1631         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1632         (wait_for_inferior): Use SCOPE_EXIT.
1633         (fetch_inferior_event): Use scope_exit.
1634
1635 2019-01-23  Tom Tromey  <tom@tromey.com>
1636             Pedro Alves  <palves@redhat.com>
1637
1638         * breakpoint.c (create_breakpoint): Remove cleanup.
1639
1640 2019-01-23  Tom Tromey  <tom@tromey.com>
1641             Andrew Burgess  <andrew.burgess@embecosm.com>
1642             Pedro Alves  <palves@redhat.com>
1643
1644 2019-01-23  Pedro Alves  <palves@redhat.com>
1645
1646         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1647
1648 2019-01-23  Pedro Alves  <palves@redhat.com>
1649             Andrew Burgess  <andrew.burgess@embecosm.com>
1650
1651         * gdbthread.h: Include "common/forward-scope-exit.h".
1652         (scoped_finish_thread_state): Redefine custom class in terms of
1653         forward_scope_exit.
1654
1655 2019-01-23  Pedro Alves  <palves@redhat.com>
1656             Andrew Burgess  <andrew.burgess@embecosm.com>
1657
1658         * common/forward-scope-exit.h: New file.
1659
1660 2019-01-23  Pedro Alves  <palves@redhat.com>
1661             Andrew Burgess  <andrew.burgess@embecosm.com>
1662             Tom Tromey  <tom@tromey.com>
1663
1664         * common/scope-exit.h: New file.
1665
1666 2019-01-23  Pedro Alves  <palves@redhat.com>
1667
1668         * common/preprocessor.h (ESC): Rename to ...
1669         (ESC_PARENS): ... this.
1670         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1671         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1672
1673 2019-01-23  Tom Tromey  <tom@tromey.com>
1674
1675         * language.h (class scoped_switch_to_sym_language_if_auto):
1676         Initialize m_lang in both cases.
1677
1678 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1679
1680         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1681         with XCNEW.
1682
1683 2019-01-22  Tom Tromey  <tom@tromey.com>
1684
1685         * corelow.c: Do not include sys/file.h.
1686
1687 2019-01-22  Tom Tromey  <tom@tromey.com>
1688
1689         * tui/tui-wingeneral.h: Include gdb_curses.h.
1690
1691 2019-01-22  Tom Tromey  <tom@tromey.com>
1692
1693         * source-cache.h (class source_cache) <get_source_lines,
1694         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1695
1696 2019-01-22  Tom Tromey  <tom@tromey.com>
1697
1698         * remote-fileio.h (struct remote_target): Declare.
1699
1700 2019-01-22  Tom Tromey  <tom@tromey.com>
1701
1702         * python/py-arch.c: Do not include py-ref.h.
1703         * python/py-bpevent.c: Do not include py-ref.h.
1704         * python/py-cmd.c: Do not include py-ref.h.
1705         * python/py-continueevent.c: Do not include py-ref.h.
1706         * python/py-event.h: Do not include py-ref.h.
1707         * python/py-evtregistry.c: Do not include py-ref.h.
1708         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1709         * python/py-frame.c: Do not include py-ref.h.
1710         * python/py-framefilter.c: Do not include py-ref.h.
1711         * python/py-function.c: Do not include py-ref.h.
1712         * python/py-infevents.c: Do not include py-ref.h.
1713         * python/py-linetable.c: Do not include py-ref.h.
1714         * python/py-objfile.c: Do not include py-ref.h.
1715         * python/py-param.c: Do not include py-ref.h.
1716         * python/py-prettyprint.c: Do not include py-ref.h.
1717         * python/py-progspace.c: Do not include py-ref.h.
1718         * python/py-symbol.c: Do not include py-ref.h.
1719         * python/py-symtab.c: Do not include py-ref.h.
1720         * python/py-type.c: Do not include py-ref.h.
1721         * python/py-unwind.c: Do not include py-ref.h.
1722         * python/py-utils.c: Do not include py-ref.h.
1723         * python/py-value.c: Do not include py-ref.h.
1724         * python/py-varobj.c: Do not include py-ref.h.
1725         * python/py-xmethods.c: Do not include py-ref.h.
1726         * python/python.c: Do not include py-ref.h.
1727         * varobj.c: Do not include py-ref.h.
1728
1729 2019-01-22  Tom Tromey  <tom@tromey.com>
1730
1731         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1732         keyword for bcache.
1733
1734 2019-01-22  Tom Tromey  <tom@tromey.com>
1735
1736         * compile/compile-cplus-types.c: Remove a comment by #include.
1737
1738 2019-01-22  Tom Tromey  <tom@tromey.com>
1739
1740         * compile/gcc-c-plugin.h: Include compile-internal.h.
1741
1742 2019-01-22  Tom Tromey  <tom@tromey.com>
1743
1744         * stabsread.c (EXTERN): Do not define.
1745         (symnum, next_symbol_text_func, processing_gcc_compilation)
1746         (within_function, global_sym_chain, global_stabs)
1747         (previous_stab_code, this_object_header_files)
1748         (n_this_object_header_files)
1749         (n_allocated_this_object_header_files): Define.
1750         * stabsread.h (EXTERN): Never define.  Use "extern".
1751
1752 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1753
1754         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1755         history_value.
1756
1757 2019-01-21  Tom Tromey  <tom@tromey.com>
1758
1759         * ui-out.c: Fix includes.
1760         * tui/tui-source.c: Fix includes.
1761         * target.c: Fix includes.
1762         * remote.c: Fix includes.
1763         * regcache.c: Fix includes.
1764         * python/py-block.c: Fix includes.
1765         * printcmd.c: Fix includes.
1766         * or1k-tdep.c: Fix includes.
1767         * mi/mi-main.c: Fix includes.
1768         * m32r-tdep.c: Fix includes.
1769         * csky-tdep.c: Fix includes.
1770         * compile/compile-cplus-types.c: Fix includes.
1771         * cli/cli-interp.c: Fix includes.
1772
1773 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1774
1775         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1776         for padding.
1777
1778 2019-01-16  Tom Tromey  <tom@tromey.com>
1779
1780         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1781         earlier.
1782         (struct objfile) <msymbols_range>: Move from top level.
1783         <msymbols>: New method.
1784         (class objfile_msymbols): Remove.
1785         * symtab.c (default_collect_symbol_completion_matches_break_on):
1786         Update.
1787         * symmisc.c (dump_msymbols): Update.
1788         * stabsread.c (scan_file_globals): Update.
1789         * objc-lang.c (info_selectors_command, info_classes_command)
1790         (find_methods): Update.
1791         * minsyms.c (find_solib_trampoline_target): Update.
1792         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1793         * coffread.c (coff_symfile_read): Update.
1794         * ada-lang.c (ada_lookup_simple_minsym)
1795         (ada_collect_symbol_completion_matches): Update.
1796
1797 2019-01-16  Tom Tromey  <tom@tromey.com>
1798
1799         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1800         type.  Remove no-argument constructor.
1801         <iterator::operator++>: Simplify.
1802         <begin>: Update.
1803         <end>: Use minimal_symbol_count.
1804
1805 2019-01-16  Tom Tromey  <tom@tromey.com>
1806
1807         * objfiles.h (struct objfile) <psymtabs>: New method.
1808         (class objfile_psymtabs): Remove.
1809         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1810         typedef.
1811         <range>: New method.
1812         (require_partial_symbols): Change return type.
1813         * psymtab.c (require_partial_symbols)
1814         (psym_expand_symtabs_matching): Update.
1815         * mdebugread.c (parse_partial_symbols): Update.
1816         * dbxread.c (dbx_end_psymtab): Update.
1817
1818 2019-01-15  Tom Tromey  <tom@tromey.com>
1819
1820         * symtab.c (lookup_objfile_from_block)
1821         (lookup_symbol_in_objfile_symtabs)
1822         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1823         (find_line_symtab, info_sources_command)
1824         (default_collect_symbol_completion_matches_break_on)
1825         (make_source_files_completion_list): Update.
1826         * symmisc.c (print_objfile_statistics, dump_objfile)
1827         (maintenance_print_symbols, maintenance_info_symtabs)
1828         (maintenance_check_symtabs, maintenance_info_line_tables):
1829         Update.
1830         * source.c (select_source_symtab)
1831         (forget_cached_source_info_for_objfile): Update.
1832         * objfiles.h (class objfile_compunits): Remove.
1833         (struct objfile) <compunits_range>: New typedef.
1834         (compunits): New method.
1835         * objfiles.c (objfile_relocate1): Update.
1836         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1837         * maint.c (count_symtabs_and_blocks): Update.
1838         * linespec.c (iterate_over_all_matching_symtabs): Update.
1839         * cp-support.c (add_symbol_overload_list_qualified): Update.
1840         * coffread.c (coff_symtab_read): Update.
1841         * ada-lang.c (add_nonlocal_symbols)
1842         (ada_collect_symbol_completion_matches)
1843         (ada_add_global_exceptions): Update.
1844
1845 2019-01-15  Tom Tromey  <tom@tromey.com>
1846
1847         * progspace.h (program_space) <objfiles_safe_range>: New
1848         typedef.
1849         <objfiles_safe>: New method.
1850         * objfiles.h (class all_objfiles_safe): Remove.
1851         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1852         * jit.c (jit_inferior_exit_hook): Update.
1853
1854 2019-01-17  Tom Tromey  <tom@tromey.com>
1855
1856         * progspace.h (program_space) <objfiles_range>: New typedef.
1857         <objfiles>: New method.
1858         <objfiles_head>: Rename from objfiles.
1859         (object_files): Update.
1860         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1861         * guile/scm-pretty-print.c
1862         (ppscm_find_pretty_printer_from_objfiles): Update.
1863         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1864         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1865         Update.
1866         * python/py-progspace.c (pspy_get_objfiles): Update.
1867         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1868         Update.
1869         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1870         (objfpy_lookup_objfile_by_build_id): Update.
1871         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1872         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1873         Update.
1874         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1875         (expand_symtab_containing_pc, lookup_objfile_from_block)
1876         (lookup_static_symbol, basic_lookup_transparent_type)
1877         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1878         (find_line_symtab, info_sources_command)
1879         (default_collect_symbol_completion_matches_break_on)
1880         (make_source_files_completion_list, find_main_name): Update.
1881         * symmisc.c (print_symbol_bcache_statistics)
1882         (print_objfile_statistics, maintenance_print_symbols)
1883         (maintenance_print_msymbols, maintenance_print_objfiles)
1884         (maintenance_info_symtabs, maintenance_check_symtabs)
1885         (maintenance_expand_symtabs, maintenance_info_line_tables):
1886         Update.
1887         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1888         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1889         (map_overlay_command, unmap_overlay_command)
1890         (simple_overlay_update, expand_symtabs_matching)
1891         (map_symbol_filenames): Update.
1892         * symfile-debug.c (set_debug_symfile): Update.
1893         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1894         Update.
1895         * source.c (select_source_symtab, forget_cached_source_info):
1896         Update.
1897         * solib.c (solib_read_symbols): Update.
1898         * solib-spu.c (append_ocl_sos): Update.
1899         * psymtab.c (maintenance_print_psymbols)
1900         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1901         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1902         * printcmd.c (info_symbol_command): Update.
1903         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1904         Update.
1905         * objfiles.h (class all_objfiles): Remove.
1906         * objfiles.c (have_partial_symbols, have_full_symbols)
1907         (have_minimal_symbols, qsort_cmp, update_section_map)
1908         (shared_objfile_contains_address_p)
1909         (default_iterate_over_objfiles_in_search_order): Update.
1910         * objc-lang.c (info_selectors_command, info_classes_command)
1911         (find_methods): Update.
1912         * minsyms.c (find_solib_trampoline_target): Update.
1913         * maint.c (maintenance_info_sections)
1914         (maintenance_translate_address, count_symtabs_and_blocks):
1915         Update.
1916         * main.c (captured_main_1): Update.
1917         * linux-thread-db.c (try_thread_db_load_from_pdir)
1918         (has_libpthread): Update.
1919         * linespec.c (iterate_over_all_matching_symtabs)
1920         (search_minsyms_for_name): Update.
1921         * jit.c (jit_find_objf_with_entry_addr): Update.
1922         * hppa-tdep.c (find_unwind_entry)
1923         (hppa_lookup_stub_minimal_symbol): Update.
1924         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1925         Update.
1926         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1927         (elf_gnu_ifunc_resolve_by_got): Update.
1928         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1929         * dwarf-index-write.c (save_gdb_index_command): Update.
1930         * cp-support.c (add_symbol_overload_list_qualified): Update.
1931         * breakpoint.c (create_overlay_event_breakpoint)
1932         (create_longjmp_master_breakpoint)
1933         (create_std_terminate_master_breakpoint)
1934         (create_exception_master_breakpoint): Update.
1935         * blockframe.c (find_pc_partial_function): Update.
1936         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1937         (ada_collect_symbol_completion_matches)
1938         (ada_add_global_exceptions): Update.
1939
1940 2019-01-17  Tom Tromey  <tom@tromey.com>
1941
1942         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1943         declare VEC.
1944         (solib_target_parse_libraries): Change return type.
1945         (library_list_start_segment, library_list_start_section)
1946         (library_list_end_library, library_list_start_library); Update.
1947         (solib_target_free_library_list): Remove.
1948         (solib_target_parse_libraries): Remove cleanup.  Change return
1949         type.
1950         (solib_target_current_sos): Update.
1951
1952 2019-01-17  Tom Tromey  <tromey@bapiya>
1953
1954         * valprint.c: Replace "the the" with "the".
1955         * symtab.c: Replace "the the" with "the".
1956         * solib.c: Replace "the the" with "the".
1957         * solib-dsbt.c: Replace "the the" with "the".
1958         * linespec.c: Replace "the the" with "the".
1959         * dwarf2loc.h: Replace "the the" with "the".
1960         * amd64-windows-tdep.c: Replace "the the" with "the".
1961         * aarch64-tdep.c: Replace "the the" with "the".
1962
1963 2019-01-16  Keith Seitz  <keiths@redhat.com>
1964
1965         PR gdb/23773
1966         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1967         <builder>: Rename to ..
1968         <m_builder>: ... this and make private.
1969         (dwarf2_cu::get_builder): New method.  Change all users of
1970         `builder' to use this method.
1971         (dwarf2_start_symtab): Move to ...
1972         (dwarf2_cu::start_symtab): ... here.  Update all callers
1973         (setup_type_unit_groups): Move to ...
1974         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1975         callers.
1976         (dwarf2_cu::reset_builder): New method.
1977         (process_full_compunit, process_full_type_unit): Use
1978         dwarf2_cu::reset_builder.
1979         (follow_die_offset): Record the ancestor CU if it is different
1980         from the followed DIE's CU.
1981         (follow_die_sig_1): Likewise.
1982
1983 2019-01-15  Tom Tromey  <tom@tromey.com>
1984
1985         * remote.c (class remote_state) <buf>: Now a char_vector.
1986         <buf_size>: Remove.
1987         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1988         parameter.
1989         (remote_target::getpkt_or_notif_sane_1)
1990         (remote_target::getpkt_sane)
1991         (remote_target::getpkt_or_notif_sane): Likewise.
1992         (class remote_target) <putpkt>: New overload.
1993         (remote_target::read_frame): Change type of "buf_p".  Remove
1994         sizeof_p parameter.
1995         (packet_ok): New overload.
1996         (packet_check_result): New overload.
1997         Update all uses.
1998
1999 2019-01-14  Tom Tromey  <tom@tromey.com>
2000
2001         * remote-notif.c (handle_notification, remote_notif_ack)
2002         (remote_notif_parse): Make "buf" const.
2003         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2004         const.
2005         (remote_notif_parse, remote_notif_ack, handle_notification):
2006         Likewise.
2007         * remote.c (remote_notif_stop_parse): Make "buf" const.
2008         (remote_target::remote_parse_stop_reply): Make "buf" const.
2009         (remote_notif_stop_ack): Make "buf" const.
2010
2011 2019-01-14  Tom Tromey  <tom@tromey.com>
2012
2013         * remote.c (remote_console_output): Make parameter const.
2014
2015 2019-01-14  Tom Tromey  <tom@tromey.com>
2016
2017         * target-debug.h (target_debug_print_signals): Constify.
2018         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2019         * procfs.c (procfs_target::pass_signals): Update.
2020         * linux-nat.c (linux_nat_target::pass_signals): Update.
2021         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2022         * target-delegates.c: Rebuild.
2023         * remote.c (remote_target::program_signals): Update.
2024         (remote_target::pass_signals): Update.
2025         * target.c (target_pass_signals): Constify argument.
2026         (target_program_signals): Likewise.
2027         * target.h (struct target_ops) <pass_signals, program_signals>:
2028         Constify argument.
2029         (target_pass_signals, target_program_signals): Constify argument.
2030
2031 2019-01-14  Tom Tromey  <tom@tromey.com>
2032
2033         PR tui/28819:
2034         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2035
2036 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2037
2038         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2039         field.
2040         * rs6000-tdep.c: Include reggroups.h.
2041         (IS_V_ALIAS_PSEUDOREG): Define.
2042         (rs6000_register_name): Return names for the "vX" aliases.
2043         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2044         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2045         aliases.  Call default_register_reggroup_p for all other
2046         pseudo-registers.
2047         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2048         New functions.
2049         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2050         Handle "vX" aliases.
2051         (v_alias_pseudo_register_collect): New function.
2052         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2053         (rs6000_gdbarch_init): Initialize "vX" aliases as
2054         pseudo-registers.  Restore registration of
2055         rs6000_pseudo_register_reggroup_p with
2056         set_tdesc_pseudo_register_reggroup_p.
2057
2058 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2059
2060         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2061         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2062         set_gdbarch_num_pseudo_regs.
2063
2064 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2065
2066         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2067         Remove arg prefixname, add do_set and do_show.
2068         Add member functions set_list and show_list.
2069         * cli/cli-style.c (class cli_style_option): Update accordingly.
2070         (style_set_list): Move to file scope.
2071         (style_show_list): Likewise.
2072         (set_style): Call help_list.
2073         (show_style): Call cmd_show_list.
2074         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2075         Update to use the new macro.
2076
2077 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2078
2079         * ada-lang.c (_initialize_ada_language): Expand the help text
2080         for the "catch exception" command.
2081
2082 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2083
2084         * symtab.c (matching_obj_sections): Initialize obj,
2085         declare it closer to its usage.
2086
2087 2019-01-10  Tom Tromey  <tom@tromey.com>
2088
2089         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2090         (basic_inf_threads_range): Remove.
2091         (inf_threads_range, inf_non_exited_threads_range)
2092         (safe_inf_threads_range): Use next_adapter.
2093
2094 2019-01-10  Keith Seitz  <keiths@redhat.com>
2095
2096         PR gdb/23712
2097         PR symtab/23010
2098         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2099         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2100
2101 2019-01-10  Keith Seitz  <keiths@redhat.com>
2102
2103         PR gdb/23712
2104         PR symtab/23010
2105         * dictionary.c (pending_to_vector): Remove.
2106         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2107         Remove _1 suffix, replacing functions of the same name.  Update
2108         all callers.
2109         (dict_create_hashed, dict_create_hashed_expandable)
2110         (dict_create_linear, dict_create_linear_expandable, dict_free)
2111         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2112         Make functions static.
2113
2114 2019-01-10  Keith Seitz  <keiths@redhat.com>
2115
2116         PR gdb/23712
2117         PR symtab/23010
2118         * dictionary.h (struct dictionary): Replace declaration with
2119         multidictionary.
2120         (dict_create_hashed, dict_create_hashed_expandable)
2121         (dict_create_linear, dict_create_linear_expandable)
2122         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2123         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2124         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2125         taking multidictionary argument.
2126         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2127         * block.h (struct block) <dict>: Change to multidictionary
2128         and rename `multidict'.
2129         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2130         symmisc.c: Update all dictionary references to multidictionary.
2131
2132 2019-01-10  Keith Seitz  <keiths@redhat.com>
2133
2134         PR gdb/23712
2135         PR symtab/23010
2136         * dictionary.c: Include unordered_map.
2137         (pending_to_vector): New function.
2138         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2139         Rewrite the non-"_1" functions to take vector instead
2140         of linked list.
2141         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2142         "new" _1 versions of the same name.
2143         (multidictionary): Define.
2144         (std::hash<enum language): New definition.
2145         (collate_pending_symbols_by_language, mdict_create_hashed)
2146         (mdict_create_hashed_expandable, mdict_create_linear)
2147         (mdict_create_linear_expandable, mdict_free)
2148         (find_language_dictionary, create_new_language_dictionary)
2149         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2150         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2151         (mdict_size, mdict_empty): New functions.
2152         * dictionary.h (mdict_iterator): Define.
2153
2154 2019-01-10  Pedro Alves  <palves@redhat.com>
2155
2156         * breakpoint.c (read_uploaded_action)
2157         (create_tracepoint_from_upload): Adjust to use
2158         gdb::unique_xmalloc_ptr.
2159         * ctf.c (ctf_write_uploaded_tp):
2160         (SET_ARRAY_FIELD): Use emplace_back.
2161         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2162         * tracefile-tfile.c (tfile_write_uploaded_tp):
2163         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2164         gdb::unique_xmalloc_ptr.
2165         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2166         at_string, cond_string, cmd_strings>: Replace char pointers
2167         with gdb::unique_xmalloc_ptr.
2168
2169 2019-01-10  Pedro Alves  <palves@redhat.com>
2170
2171         * solib-target.c (library_list_start_library): Don't xstrdup name.
2172
2173 2019-01-10  Pedro Alves  <palves@redhat.com>
2174
2175         * mdebugread.c (parse_partial_symbols): Use
2176         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2177
2178 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2179
2180         * linux-fork.c (scoped_switch_fork_info)
2181         <~scoped_switch_fork_info>: Fix incorrect variable name.
2182
2183 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2184
2185         * linux-fork.c (scoped_switch_fork_info)
2186         <scoped_switch_fork_info>: Make explicit.
2187         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2188
2189 2019-01-10  Tom Tromey  <tom@tromey.com>
2190
2191         * objfiles.h (objfile::reset_psymtabs): Update.
2192         * objfiles.c (objfile::objfile): Update.
2193         * psymtab.h (psymtab_storage::obstack): Update.
2194         (psymtab_storage::m_obstack): Use gdb::optional.
2195         (class psymtab_storage): Update comment.  Remove objfile
2196         parameter.
2197         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2198
2199 2019-01-10  Tom Tromey  <tom@tromey.com>
2200
2201         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2202         <free_psymtabs>: Now private.
2203         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2204         (allocate_psymtab): Use new method.
2205
2206 2019-01-10  Tom Tromey  <tom@tromey.com>
2207
2208         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2209         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2210         * mdebugread.c (parse_partial_symbols): Use
2211         allocate_dependencies.
2212         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2213         allocate_dependencies.
2214         (process_psymtab_comp_unit_reader)
2215         (build_type_psymtab_dependencies): Likewise.
2216         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2217
2218 2019-01-10  Tom Tromey  <tom@tromey.com>
2219
2220         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2221         PSYMBOL_SET_LANGUAGE.
2222         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2223
2224 2019-01-10  Tom Tromey  <tom@tromey.com>
2225
2226         * psymtab.h (psymtab_storage::obstack): New method.
2227         <m_obstack>: Rename from obstack; now private.
2228         * psymtab.c (psymtab_storage): Update.
2229         * dwarf2read.c (create_addrmap_from_index)
2230         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2231         Update.
2232
2233 2019-01-10  Tom Tromey  <tom@tromey.com>
2234
2235         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2236         * objfiles.h (objfile::reset_psymtabs): New method.
2237
2238 2019-01-10  Tom Tromey  <tom@tromey.com>
2239
2240         * symmisc.c (print_symbol_bcache_statistics): Update.
2241         (print_objfile_statistics): Update.
2242         * symfile.c (reread_symbols): Update.
2243         * psymtab.h (class psymtab_storage): New.
2244         * psymtab.c (psymtab_storage): New constructor.
2245         (~psymtab_storage): New destructor.
2246         (require_partial_symbols): Update.
2247         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2248         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2249         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2250         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2251         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2252         (start_psymtab_common, end_psymtab_common)
2253         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2254         (allocate_psymtab): Update.
2255         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2256         Update.
2257         (dump_psymtab_addrmap, maintenance_print_psymbols)
2258         (maintenance_check_psymtabs): Update.
2259         (class objfile_psymtabs): Move to objfiles.h.
2260         * psympriv.h (discard_psymtab): Now inline.
2261         (psymtab_discarder::psymtab_discarder): Update.
2262         (psymtab_discarder::~psymtab_discarder): Update.
2263         (ALL_OBJFILE_PSYMTABS): Rewrite.
2264         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2265         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2266         Remove fields.
2267         <partial_symtabs>: New field.
2268         (class objfile_psymtabs): Move from psymtab.h.  Update.
2269         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2270         psymbol_cache.
2271         (objfile::~objfile): Don't destroy psymbol_cache.
2272         * mdebugread.c (parse_partial_symbols): Update.
2273         * dwarf2read.c (create_addrmap_from_index)
2274         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2275         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2276         (add_partial_subprogram, dwarf2_ranges_read): Update.
2277         * dwarf-index-write.c (write_address_map)
2278         (write_one_signatured_type, recursively_write_psymbols)
2279         (class debug_names, class debug_names, write_psymtabs_to_index):
2280         Update.
2281
2282 2019-01-10  Tom Tromey  <tom@tromey.com>
2283
2284         * symtab.h (SYMBOL_SET_NAMES): Update.
2285         (symbol_set_names): Update.
2286         (MSYMBOL_SET_NAMES): Update.
2287         * symtab.c (symbol_set_names): Change argument to be an
2288         objfile_per_bfd_storage.
2289         * psymtab.c (add_psymbol_to_bcache): Update.
2290         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2291
2292 2019-01-10  Tom Tromey  <tom@tromey.com>
2293
2294         * symtab.c (create_demangled_names_hash): Change argument to be an
2295         objfile_per_bfd_storage.
2296         (symbol_set_names): Update.
2297
2298 2019-01-10  Tom Tromey  <tom@tromey.com>
2299
2300         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2301         init_psymbol_list.
2302         * psymtab.c (init_psymbol_list): Do nothing if already called.
2303         * psympriv.h (init_psymbol_list): Add comment.
2304         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2305         init_psymbol_list.
2306         * dbxread.c (dbx_symfile_read): Unconditionally call
2307         init_psymbol_list.
2308
2309 2019-01-10  Tom Tromey  <tom@tromey.com>
2310
2311         * xcoffread.c (scan_xcoff_symtab): Update.
2312         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2313         "where".
2314         * mdebugread.c (parse_partial_symbols)
2315         (handle_psymbol_enumerators): Update.
2316         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2317         * dbxread.c (read_dbx_symtab): Update.
2318         * psympriv.h (psymbol_placement): New enum.
2319         (add_psymbol_to_list): Update.
2320
2321 2019-01-10  Tom Tromey  <tom@tromey.com>
2322
2323         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2324         static_psymbols parameters.
2325         (scan_xcoff_symtab): Update.
2326         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2327         static_psymbols parameters.
2328         * psympriv.h (start_psymtab_common): Update.
2329         * mdebugread.c (parse_partial_symbols): Update.
2330         * dwarf2read.c (create_partial_symtab): Update.
2331         * dbxread.c (read_dbx_symtab): Update.
2332         (start_psymtab): Remove global_psymbols and static_psymbols
2333         parameters.
2334
2335 2019-01-10  Tom Tromey  <tom@tromey.com>
2336
2337         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2338         * psymtab.c (allocate_psymtab): Add comment.
2339         * psympriv.h (allocate_psymtab): Add comment.
2340         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2341         initializations.
2342         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2343
2344 2019-01-10  Tom Tromey  <tom@tromey.com>
2345
2346         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2347         Don't declare.
2348         * mipsread.c: Include mdebugread.h.
2349         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2350         Declare.
2351         * elfread.c: Include mdebugread.h.
2352
2353 2019-01-09  Tom Tromey  <tom@tromey.com>
2354
2355         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2356         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2357         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2358         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2359         (psym_lookup_symbol, psym_find_last_source_symtab)
2360         (psym_forget_cached_source_info, psym_print_stats)
2361         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2362         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2363         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2364         (psym_find_compunit_symtab_by_address)
2365         (maintenance_print_psymbols, maintenance_info_psymtabs)
2366         (maintenance_check_psymtabs): Use ranged for.
2367         * psymtab.h (class objfile_psymtabs): New.
2368         (require_partial_symbols): Return objfile_psymtabs.
2369         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2370
2371 2019-01-09  Tom Tromey  <tom@tromey.com>
2372
2373         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2374         (find_pc_mapped_section, list_overlays_command)
2375         (map_overlay_command, unmap_overlay_command)
2376         (simple_overlay_update): Use all_objfiles.
2377         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2378         * printcmd.c (info_symbol_command): Use all_objfiles.
2379         * objfiles.h (ALL_OBJSECTIONS): Remove.
2380         * maint.c (maintenance_translate_address): Use all_objfiles.
2381         * gcore.c (gcore_create_callback): Use all_objfiles.
2382         (objfile_find_memory_regions): Likewise.
2383
2384 2019-01-09  Tom Tromey  <tom@tromey.com>
2385
2386         * symtab.c (find_line_symtab, info_sources_command)
2387         (make_source_files_completion_list): Use objfile_compunits.
2388         * source.c (select_source_symtab): Use objfile_compunits.
2389         * objfiles.h (struct objfile): Update comment.
2390         (ALL_OBJFILES): Remove.
2391         (ALL_FILETABS): Remove.
2392         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2393         objfile_compunits.
2394
2395 2019-01-09  Tom Tromey  <tom@tromey.com>
2396
2397         * symmisc.c (print_objfile_statistics, dump_objfile)
2398         (maintenance_print_symbols): Use compunit_filetabs.
2399         * source.c (forget_cached_source_info_for_objfile): Use
2400         compunit_filetabs.
2401         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2402         (ALL_FILETABS): Use compunit_filetabs.
2403         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2404         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2405
2406 2019-01-09  Tom Tromey  <tom@tromey.com>
2407
2408         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2409         (compunit_filetabs): New.
2410         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2411         compunit_filetabs.
2412         (info_sources_command, make_source_files_completion_list): Remove
2413         declaration.
2414         * symmisc.c (print_objfile_statistics, dump_objfile)
2415         (maintenance_print_symbols): Remove declaration.
2416         (maintenance_info_symtabs): Use compunit_filetabs.
2417         (maintenance_info_line_tables): Likewise.
2418         * source.c (select_source_symtab): Change local variable name.
2419         (forget_cached_source_info_for_objfile): Remove declaration.
2420         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2421         * objfiles.c (objfile_relocate1): Remove declaration.
2422         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2423         declaration.
2424         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2425         * coffread.c (coff_symtab_read): Remove declaration.
2426         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2427         compunit_filetabs.
2428
2429 2019-01-09  Tom Tromey  <tom@tromey.com>
2430
2431         * symtab.c (lookup_objfile_from_block)
2432         (find_pc_sect_compunit_symtab, search_symbols)
2433         (default_collect_symbol_completion_matches_break_on): Use
2434         objfile_compunits.
2435         * objfiles.h (ALL_COMPUNITS): Remove.
2436         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2437         * cp-support.c (add_symbol_overload_list_qualified): Use
2438         objfile_compunits.
2439         * ada-lang.c (ada_collect_symbol_completion_matches)
2440         (ada_add_global_exceptions): Use objfile_compunits.
2441
2442 2019-01-09  Tom Tromey  <tom@tromey.com>
2443
2444         * source.c (select_source_symtab)
2445         (forget_cached_source_info_for_objfile): Remove declaration.
2446         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2447         declaration.
2448         * maint.c (count_symtabs_and_blocks): Remove declaration.
2449         * cp-support.c (add_symbol_overload_list_qualified): Remove
2450         declaration.
2451         * coffread.c (coff_symtab_read): Remove declaration.
2452         * symtab.c (lookup_symbol_in_objfile_symtabs)
2453         (basic_lookup_transparent_type_1): Use objfile_compunits.
2454         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2455         (info_sources_command, search_symbols)
2456         (default_collect_symbol_completion_matches_break_on)
2457         (make_source_files_completion_list): Remove declaration.
2458         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2459         (ada_collect_symbol_completion_matches)
2460         (ada_add_global_exceptions): Remove declaration.
2461         * linespec.c (iterate_over_all_matching_symtabs): Use
2462         objfile_compunits.
2463         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2464         (class objfile_compunits): New.
2465         (ALL_COMPUNITS): Use objfile_compunits.
2466         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2467         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2468         objfile_compunits.
2469         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2470
2471 2019-01-09  Tom Tromey  <tom@tromey.com>
2472
2473         * symtab.c (search_symbols)
2474         (default_collect_symbol_completion_matches_break_on): Use
2475         objfile_msymbols.
2476         * ada-lang.c (ada_lookup_simple_minsym)
2477         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2478         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2479         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2480         objfile_msymbols.
2481         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2482         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2483         * objc-lang.c (find_methods): Use objfile_msymbols.
2484         (info_selectors_command, info_classes_command): Likewise.
2485         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2486         * objfiles.h (class objfile_msymbols): New.
2487         (ALL_OBJFILE_MSYMBOLS): Remove.
2488         (ALL_MSYMBOLS): Remove.
2489
2490 2019-01-09  Tom Tromey  <tom@tromey.com>
2491
2492         * common/next-iterator.h (next_adapter): Add Iterator template
2493         parameter.
2494         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2495         (class all_objfiles_safe): New.
2496         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2497         * objfiles.c (put_objfile_before): Update comment.
2498         (add_separate_debug_objfile): Likewise.
2499         (free_all_objfiles): Use all_objfiles_safe.
2500         (objfile_purge_solibs): Likewise.
2501
2502 2019-01-09  Tom Tromey  <tom@tromey.com>
2503
2504         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2505         (expand_symtab_containing_pc, lookup_static_symbol)
2506         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2507         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2508         all_objfiles.
2509         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2510         * breakpoint.c (create_overlay_event_breakpoint)
2511         (create_longjmp_master_breakpoint)
2512         (create_std_terminate_master_breakpoint)
2513         (create_exception_master_breakpoint): Use all_objfiles.
2514         * linux-thread-db.c (try_thread_db_load_from_pdir)
2515         (has_libpthread): Use all_objfiles.
2516         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2517         * linespec.c (iterate_over_all_matching_symtabs)
2518         (search_minsyms_for_name): Use all_objfiles.
2519         * maint.c (maintenance_info_sections): Use all_objfiles.
2520         * main.c (captured_main_1): Use all_objfiles.
2521         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2522         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2523         * guile/scm-pretty-print.c
2524         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2525         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2526         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2527         (maintenance_print_msymbols): Use all_objfiles.
2528         * source.c (select_source_symtab): Use all_objfiles.
2529         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2530         * symfile.c (remove_symbol_file_command)
2531         (expand_symtabs_matching, map_symbol_filenames): Use
2532         all_objfiles.
2533         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2534         all_objfiles.
2535         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2536         * objc-lang.c (find_methods): Use all_objfiles.
2537         * objfiles.c (have_partial_symbols, have_full_symbols)
2538         (have_minimal_symbols, qsort_cmp)
2539         (default_iterate_over_objfiles_in_search_order): Use
2540         all_objfiles.
2541         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2542         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2543         (maintenance_check_psymtabs): Use all_objfiles.
2544         (ALL_PSYMTABS): Remove.
2545         * compile/compile-object-run.c (do_module_cleanup): Use
2546         all_objfiles.
2547         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2548         * cp-support.c (add_symbol_overload_list_qualified): Use
2549         all_objfiles.
2550         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2551         Use all_objfiles.
2552         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2553         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2554         all_objfiles.
2555         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2556         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2557         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2558         Uses all_objfiles.
2559         * solib.c (solib_read_symbols): Use all_objfiles
2560
2561 2019-01-09  Tom Tromey  <tom@tromey.com>
2562
2563         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2564         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2565         all_objfiles.
2566         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2567         * symmisc.c (print_symbol_bcache_statistics)
2568         (print_objfile_statistics, maintenance_print_objfiles)
2569         (maintenance_info_symtabs, maintenance_check_symtabs)
2570         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2571         all_objfiles.
2572         * source.c (forget_cached_source_info): Use all_objfiles.
2573         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2574         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2575         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2576         * objfiles.c (update_section_map): Use all_objfiles.
2577         (shared_objfile_contains_address_p): Likewise.
2578         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2579         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2580
2581 2019-01-09  Tom Tromey  <tom@tromey.com>
2582
2583         * common/next-iterator.h: New file.
2584         * objfiles.h (class all_objfiles): New.
2585         (struct objfile_iterator): New.
2586
2587 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2588
2589         * NEWS: Move the description of the changed "frame", "select-frame",
2590          and "info frame" commands to the Changed commands section.
2591
2592 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2593
2594         * gdbtypes.c (check_stub_method_group): Remove handling of old
2595         mangling schemes.
2596         * linespec.c (find_methods): Likewise.
2597         * stabsread.c (read_member_functions): Likewise.
2598         * valops.c (search_struct_method): Likewise.
2599         (value_struct_elt_for_reference): Likewise.
2600         * NEWS: Mention this change.
2601
2602 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2603
2604         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2605         print_source_lines.
2606         * source.c (print_source_lines_base): Update line number check.
2607         (print_source_lines): New function.
2608         (source_lines_range::source_lines_range): New function.
2609         * source.h (class source_lines_range): New class.
2610         (print_source_lines): New declaration.
2611
2612 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2613
2614         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2615
2616 2019-01-08  Tom Tromey  <tom@tromey.com>
2617             Simon Marchi  <simon.marchi@ericsson.com>
2618
2619         PR gdb/24060
2620         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2621         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2622         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2623         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2624         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2625         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2626
2627 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2628
2629         * source.c (select_source_symtab): Move header comment to
2630         declaration in source.h.
2631         (forget_cached_source_info_for_objfile): Likewise.
2632         (forget_cached_source_info): Likewise.
2633         (identify_source_line): Likewise.
2634         * source.h (identify_source_line): Move declaration from symtab.h
2635         and add comment from source.c
2636         (print_source_lines): Likewise.
2637         (forget_cached_source_info_for_objfile): Likewise.
2638         (forget_cached_source_info): Likewise.
2639         (select_source_symtab): Likewise.
2640         (enum print_source_lines_flag): Move definition from symtab.h.
2641         * symtab.h (identify_source_line): Move declaration to source.h.
2642         (print_source_lines): Likewise.
2643         (forget_cached_source_info_for_objfile): Likewise.
2644         (forget_cached_source_info): Likewise.
2645         (select_source_symtab): Likewise.
2646         (enum print_source_lines_flag): Move definition to source.h.
2647         * tui/tui-hooks.c: Add 'source.h' include.
2648
2649 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2650
2651         * source.c (print_source_lines_base): Handle requests to print
2652         reverse line number sequences, and guard against empty lines
2653         string.
2654
2655 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2656
2657         * source.c (print_source_lines_base): Fix skip of '\r' if next
2658         character is '\n'.
2659
2660 2019-01-06  Tom Tromey  <tom@tromey.com>
2661
2662         * c-exp.y (struct c_parse_state) <macro_original_text,
2663         expansion_obstack>: New member.
2664         (macro_original_text, expansion_obstack): Remove globals.
2665         (scan_macro_expansion, scanning_macro_expansion)
2666         (finished_macro_expansion): Update.
2667         (scan_macro_cleanup): Remove.
2668         (yylex, c_parse): Update.
2669
2670 2019-01-06  Tom Tromey  <tom@tromey.com>
2671
2672         * c-exp.y (struct c_parse_state) <strings>: New member.
2673         (operator_stoken): Update.
2674
2675 2019-01-06  Tom Tromey  <tom@tromey.com>
2676
2677         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2678         (union type_stack_elt) <typelist_val>: Now a pointer to
2679         std::vector.
2680         (type_stack_cleanup): Don't declare.
2681         (push_typelist): Update.
2682         * parse.c (pop_typelist): Return a std::vector.
2683         (push_typelist): Take a std::vector.
2684         (follow_types): Update.  Do not free args.
2685         (type_stack_cleanup): Remove.
2686         * c-exp.y (struct c_parse_state): New.
2687         (cpstate): New global.
2688         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2689         (nonempty_typelist): Update.
2690         (func_mod): Create a new vector.
2691         (c_parse): Create a c_parse_state.
2692         (check_parameter_typelist): Do not delete params.
2693         (function_method): Update.  Do not delete type_list.
2694
2695 2019-01-06  Tom Tromey  <tom@tromey.com>
2696
2697         PR gdb/28155:
2698         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2699         check_typedef.
2700         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2701         (print_return_value): Likewise.
2702
2703 2019-01-05  Tom Tromey  <tom@tromey.com>
2704
2705         * contrib/cleanup_check.py: Remove.
2706         * contrib/gcc-with-excheck: Remove.
2707         * contrib/exsummary.py: Remove.
2708         * contrib/excheck.py: Remove.
2709
2710 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2711
2712         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2713         NULL. Initialize tpprev to NULL instead of assigning it
2714         to NULL on the next statement.
2715         * windows-nat.c (windows_delete_thread): Remove check for
2716         main_thread_id before printing thread exit notifications.
2717         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2718         Remove thread ID check against main_thread_id.
2719         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2720         windows_delete_thread.
2721         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2722
2723 2019-01-04  Tom Tromey  <tom@tromey.com>
2724
2725         * compile/compile.c (_initialize_compile): Use upper case for
2726         metasyntactic variables.
2727         * symmisc.c (_initialize_symmisc): Use upper case for
2728         metasyntactic variables.
2729         * psymtab.c (_initialize_psymtab): Use upper case for
2730         metasyntactic variables.
2731         * demangle.c (demangle_command): Use upper case for metasyntactic
2732         variables.
2733         (_initialize_demangler): Likewise.
2734         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2735         variables.
2736
2737 2019-01-03  Tom Tromey  <tom@tromey.com>
2738
2739         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2740
2741 2019-01-03  Tom Tromey  <tom@tromey.com>
2742
2743         * python/py-symtab.c (salpy_str): Update.
2744         (struct salpy_sal_object) <symtab>: Now a PyObject.
2745         (salpy_dealloc): Update.
2746         (del_objfile_sal): Use gdbpy_ref.
2747
2748 2019-01-03  Tom Tromey  <tom@tromey.com>
2749
2750         * python/py-type.c (convert_field): Use new_reference.  Return
2751         gdbpy_ref.
2752         (make_fielditem): Return gdbpy_ref.
2753         (typy_fields): Update.
2754         (typy_getitem): Update.
2755         (field_name): Return gdbpy_ref.  Use new_reference.
2756         (typy_iterator_iternext): Update.
2757
2758 2019-01-03  Tom Tromey  <tom@tromey.com>
2759
2760         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2761
2762 2019-01-03  Tom Tromey  <tom@tromey.com>
2763
2764         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2765         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2766         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2767         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2768         (pspy_set_type_printers): Likewise.
2769         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2770         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2771         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2772         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2773         (objfpy_set_type_printers): Likewise.
2774
2775 2019-01-03  Tom Tromey  <tom@tromey.com>
2776
2777         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2778         (gdbpy_print_stack): Use gdbpy_err_fetch.
2779         * python/python-internal.h (class gdbpy_err_fetch): New class.
2780         (class gdbpy_enter) <m_error_type, m_error_value,
2781         m_error_traceback>: Remove.
2782         <m_error>: New member.
2783         (gdbpy_exception_to_string): Don't declare.
2784         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2785         * python/py-value.c (convert_value_from_python): Use
2786         gdbpy_err_fetch.
2787         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2788         gdbpy_exception_to_string.
2789         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2790         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2791         gdbpy_err_fetch.
2792
2793 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2794
2795         * linux-nat.c (delete_lwp_cleanup): Delete.
2796         (struct lwp_deleter): New struct.
2797         (lwp_info_up): New typedef.
2798         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2799         lwp_info_up.
2800
2801 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2802
2803         * linux-fork.c (class scoped_switch_fork_info): New class.
2804         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2805
2806 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2807
2808         * valops.c (find_overload_match): Remove use of null_cleanup, and
2809         calls to do_cleanups.
2810
2811 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2812
2813         * compile/compile-cplus-types.c
2814         (compile_cplus_instance::decl_name): Handle changes to
2815         cp_func_name.
2816         * cp-support.c (cp_func_name): Update header comment, update
2817         return type.
2818         * cp-support.h (cp_func_name): Update return type in declaration.
2819         * valops.c (find_overload_match): Move temp_func local to top
2820         level of function and change its type.  Use temp_func to hold and
2821         delete temporary string obtained from cp_func_name.
2822
2823 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2824
2825         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2826         gdb::char_vector, remove cleanup, and update uses of `msg`.
2827
2828 2019-01-03  Jim Wilson  <jimw@sifive.com>
2829
2830         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2831
2832 2019-01-02  Tom Tromey  <tom@tromey.com>
2833
2834         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2835         (tdesc_parse_xml): Remove cleanups.
2836         * target-descriptions.h (make_cleanup_free_target_description):
2837         Don't declare.
2838         (target_desc_deleter): New struct.
2839         (target_desc_up): New typedef.
2840         * target-descriptions.c (target_desc_deleter::operator()): Rename
2841         from free_target_description.
2842         (make_cleanup_free_target_description): Remove.
2843
2844 2019-01-02  Tom Tromey  <tom@tromey.com>
2845
2846         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2847         constructor, destructor.
2848         (linespec_parser): Remove typedef.
2849         (~linespec_parser): Rename from linespec_parser_delete.
2850         (linespec_lex_to_end, linespec_complete_label)
2851         (linespec_complete): Update.
2852         (decode_line_full): Remove cleanups.
2853         (decode_line_1): Update.
2854
2855 2019-01-02  Tom Tromey  <tom@tromey.com>
2856
2857         * python/python-internal.h (inferior_to_inferior_object): Change
2858         return type.
2859         * python/py-exitedevent.c (create_exited_event_object): Update.
2860         * python/py-inferior.c (inferior_to_inferior_object): Return
2861         gdbpy_ref.
2862         (python_new_inferior, python_inferior_deleted)
2863         (thread_to_thread_object, delete_thread_object)
2864         (build_inferior_list, gdbpy_selected_inferior): Update.
2865         * python/py-infthread.c (create_thread_object): Update.  Also fail
2866         if inferior_to_inferior_object fails.
2867
2868 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2869
2870         * inferior.h (class inferior) <displaced_step_state>: New field.
2871         * infrun.h (struct displaced_step_state): Move here from
2872         infrun.c.  Initialize fields, add constructor.
2873         <inf>: Remove field.
2874         <reset>: New method.
2875         * infrun.c (struct displaced_step_inferior_state): Move to
2876         infrun.h.
2877         (displaced_step_inferior_states): Remove.
2878         (get_displaced_stepping_state): Adust.
2879         (displaced_step_in_progress_any_inferior): Adjust.
2880         (displaced_step_in_progress_thread): Adjust.
2881         (displaced_step_in_progress): Adjust.
2882         (add_displaced_stepping_state): Remove.
2883         (get_displaced_step_closure_by_addr): Adjust.
2884         (remove_displaced_stepping_state): Remove.
2885         (infrun_inferior_exit): Call displaced_step_state.reset.
2886         (use_displaced_stepping): Don't check for NULL.
2887         (displaced_step_prepare_throw): Call
2888         get_displaced_stepping_state.
2889         (displaced_step_fixup): Don't check for NULL.
2890         (prepare_for_detach): Don't check for NULL.
2891
2892 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2893
2894         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2895          in case of call that did not complete.
2896
2897 2019-01-02  Andrey Utkin  <autkin@undo.io>
2898
2899         * symfile.c (find_separate_debug_file): Fix search of debug files for
2900         remote debuggee.
2901
2902 2019-01-02  Tom Tromey  <tom@tromey.com>
2903
2904         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2905         indentation.
2906         * python/py-frame.c (frapy_older): Remove cast.
2907         (frapy_newer): Likewise.
2908         * python/py-breakpoint.c (local_setattro): Remove cast.
2909         * python/py-arch.c (archpy_name): Remove local variable.
2910         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2911
2912 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2913
2914         * unittests/basic_string_view/element_access/char/empty.cc:
2915         Fix year range in copyright header.
2916
2917 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2918
2919         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2920         Delete.
2921         <operator==>: Update with for removed field.
2922         <hash>: Likewise.
2923         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2924         <isa_features>: ...this.
2925         <abi_features>: New field.
2926         (riscv_isa_flen): Update comment.
2927         (riscv_abi_xlen): New declaration.
2928         (riscv_abi_flen): New declaration.
2929         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2930         isa_features.
2931         (riscv_abi_xlen): New function.
2932         (riscv_isa_flen): Update to get answer from isa_features.
2933         (riscv_abi_flen): New function.
2934         (riscv_has_fp_abi): Update to get answer from abi_features.
2935         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2936         xlen and flen.
2937         (riscv_call_info) <xlen, flen>: Update comment.
2938         (riscv_call_arg_struct): Remove invalid assertions
2939         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2940         is removed.
2941         (riscv_gdbarch_init): Gather isa features and abi features
2942         separately, ensure both match on the gdbarch when reusing an old
2943         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2944         a target with 64-bit float hardware.
2945
2946 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2947
2948         * source.c (search_command_helper): Stop reverse search
2949         when line 1 has been searched.
2950
2951 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2952
2953         * record-full.c (record_full_base_target::close): Rewrite
2954         record_full_core_buf_list free logic.
2955
2956 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2957
2958         * break-catch-syscall.c (print_one_catch_syscall): xfree
2959         the last text.
2960
2961 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2962
2963         * top.c (print_gdb_version): Update Copyright year in version
2964         message.
2965
2966 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2967
2968         Update copyright year range in all GDB files.
2969
2970 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2971
2972         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2973
2974 For older changes see ChangeLog-2018.
2975 \f
2976 Local Variables:
2977 mode: change-log
2978 left-margin: 8
2979 fill-column: 74
2980 version-control: never
2981 coding: utf-8
2982 End:
2983