gdb/ChangeLog

   1 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
   2
   3         * NEWS: Update style defaults.
   4
   5 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
   6
   7         * main.c (captured_main_1): Disable styling in batch mode.
   8
   9 2019-02-20  Tom Tromey  <tom@tromey.com>
  10
  11         * symtab.c (symtab_symbol_info): Fix typos.
  12
  13 2019-02-20  Tom Tromey  <tromey@adacore.com>
  14
  15         * findcmd.c (_initialize_mem_search): Use upper case for
  16         metasyntactic variables.
  17
  18 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
  19
  20         * aarch64-tdep.c (aarch64_add_reggroups): New function.
  21         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
  22
  23 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
  24
  25         * top.h (source_file_name): Change to std::string.
  26         * top.c (source_file_name): Likewise.
  27         (command_line_input): Adjust.
  28         * cli/cli-script.c (script_from_file): Adjust.
  29
  30 2019-02-19  Tom Tromey  <tromey@adacore.com>
  31
  32         * ravenscar-thread.c
  33         (ravenscar_thread_target::update_thread_list): Don't call
  34         ada_build_task_list.
  35         * ada-lang.h (ada_build_task_list): Don't declare.
  36         * ada-tasks.c (struct ada_tasks_inferior_data)
  37         <task_list_valid_p>: Now bool.
  38         (read_known_tasks, ada_task_list_changed)
  39         (ada_tasks_invalidate_inferior_data): Update.
  40         (read_known_tasks_array): Return bool.
  41         (read_known_tasks_list): Likewise.
  42         (read_known_tasks): Return void.
  43         (ada_build_task_list): Now static.
  44
  45 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  46
  47         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
  48         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
  49
  50 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  51
  52         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
  53         variant for ada_tasks_pspace_data_handle and
  54         ada_tasks_inferior_data_handle.
  55         (ada_tasks_pspace_data_cleanup): New function.
  56         (ada_tasks_inferior_data_cleanup): New function.
  57
  58 2019-02-17  Tom Tromey  <tom@tromey.com>
  59
  60         * macrotab.h (macro_source_fullname): Return a std::string.
  61         * macrotab.c (macro_include, check_for_redefinition)
  62         (macro_undef, macro_lookup_definition, foreach_macro)
  63         (foreach_macro_in_scope): Update.
  64         (macro_source_fullname): Return a std::string.
  65         * macrocmd.c (show_pp_source_pos): Update.
  66
  67 2019-02-17  Tom Tromey  <tom@tromey.com>
  68
  69         * macrocmd.c (show_pp_source_pos): Style the file names.
  70
  71 2019-02-17  Tom Tromey  <tom@tromey.com>
  72
  73         PR tui/24197:
  74         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
  75
  76 2019-02-17  Tom Tromey  <tom@tromey.com>
  77
  78         * ada-lang.c (user_select_syms): Use filtered printing.
  79         * utils.c (wrap_style): New global.
  80         (desired_style): Remove.
  81         (emit_style_escape): Add stream parameter.
  82         (set_output_style, reset_terminal_style, prompt_for_continue):
  83         Update.
  84         (flush_wrap_buffer): Only flush gdb_stdout.
  85         (wrap_here): Set wrap_style.
  86         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
  87         treat escape sequences as a character.  Change when wrap buffer is
  88         flushed.
  89         (fputs_styled): Do not set the output style when the default is
  90         requested.
  91         * ui-style.h (struct ui_file_style) <is_default>: New method.
  92         * source.c (print_source_lines_base): Emit escape sequences in one
  93         piece.
  94
  95 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
  96
  97         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
  98         integers and enumeration types.
  99
 100 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 101
 102         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 103         instead of lookup_symbol_in_language
 104         (do_exact_match): New function.
 105         (ada_get_symbol_name_matcher): Return do_exact_match when
 106         doing a verbatim match.
 107
 108 2019-02-15  Tom Tromey  <tromey@adacore.com>
 109
 110         * ravenscar-thread.c (ravenscar_thread_target::resume)
 111         (ravenscar_thread_target::wait): Special case wildcard requests.
 112
 113 2019-02-15  Tom Tromey  <tromey@adacore.com>
 114
 115         * ravenscar-thread.c (base_ptid): Remove.
 116         (struct ravenscar_thread_target) <close>: New method.
 117         <m_base_ptid>: New member.
 118         <update_inferior_ptid, active_task, task_is_currently_active,
 119         runtime_initialized>: Declare methods.
 120         <ravenscar_thread_target>: Add constructor.
 121         (ravenscar_thread_target::task_is_currently_active)
 122         (ravenscar_thread_target::update_inferior_ptid)
 123         (ravenscar_runtime_initialized): Rename.  Now methods.
 124         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 125         (ravenscar_thread_target::update_thread_list): Update.
 126         (ravenscar_thread_target::active_task): Now method.
 127         (ravenscar_thread_target::store_registers)
 128         (ravenscar_thread_target::prepare_to_store)
 129         (ravenscar_thread_target::prepare_to_store)
 130         (ravenscar_thread_target::mourn_inferior): Update.
 131         (ravenscar_inferior_created): Use "new" to create target.
 132         (ravenscar_thread_target::get_ada_task_ptid): Update.
 133         (_initialize_ravenscar): Don't initialize base_ptid.
 134         (ravenscar_ops): Remove global.
 135
 136 2019-02-15  Tom Tromey  <tromey@adacore.com>
 137
 138         * target.h (push_target): Declare new overload.
 139         * target.c (push_target): New overload, taking an rvalue reference.
 140         * remote.c (remote_target::open_1): Use push_target overload.
 141         * corelow.c (core_target_open): Use push_target overload.
 142
 143 2019-02-15  Tom Tromey  <tromey@adacore.com>
 144
 145         * ravenscar-thread.c (is_ravenscar_task)
 146         (ravenscar_task_is_currently_active): Return bool.
 147         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 148         (_initialize_ravenscar): Remove "(void)".
 149         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 150         Return bool.
 151
 152 2019-02-15  Tom Tromey  <tromey@adacore.com>
 153
 154         * ravenscar-thread.c (ravenscar_runtime_initializer)
 155         (has_ravenscar_runtime, get_running_thread_id)
 156         (ravenscar_thread_target::resume): Fix indentation.
 157
 158 2019-02-15  Tom Tromey  <tromey@adacore.com>
 159
 160         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 161         from ravenscar_arch_ops.
 162         (sparc_ravenscar_ops::fetch_registers)
 163         (sparc_ravenscar_ops::store_registers): Now methods.
 164         (sparc_ravenscar_prepare_to_store): Remove.
 165         (sparc_ravenscar_ops): Redefine.
 166         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 167         methods and destructor.  Remove members.
 168         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 169         (ravenscar_thread_target::store_registers)
 170         (ravenscar_thread_target::prepare_to_store): Update.
 171         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 172         Remove.
 173         (struct ppc_ravenscar_powerpc_ops): Derive from
 174         ravenscar_arch_ops.
 175         (ppc_ravenscar_powerpc_ops::fetch_registers)
 176         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 177         (ppc_ravenscar_powerpc_ops): Redefine.
 178         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 179         (ppc_ravenscar_e500_ops::fetch_registers)
 180         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 181         (ppc_ravenscar_e500_ops): Redefine.
 182         * aarch64-ravenscar-thread.c
 183         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 184         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 185         (aarch64_ravenscar_fetch_registers)
 186         (aarch64_ravenscar_store_registers): Now methods.
 187         (aarch64_ravenscar_ops): Redefine.
 188
 189 2019-02-15  Tom Tromey  <tromey@adacore.com>
 190
 191         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 192         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 193         (ravenscar_thread_target::stopped_by_watchpoint)
 194         (ravenscar_thread_target::stopped_data_address)
 195         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 196
 197 2019-02-15  Tom Tromey  <tromey@adacore.com>
 198
 199         * ravenscar-thread.c: Fix some typos.
 200
 201 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 202             Tom Tromey  <tromey@adacore.com>
 203
 204         * ada-lang.c (ada_exception_sal): Change addr_string to a
 205         std::string.
 206         (create_ada_exception_catchpoint): Update.
 207
 208 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 209             Tom Tromey  <tromey@adacore.com>
 210
 211         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 212         (bp_location_ops): Remove.
 213         (base_breakpoint_allocate_location): Update.
 214         (free_bp_location): Update.
 215         * ada-lang.c (class ada_catchpoint_location)
 216         <ada_catchpoint_location>: Remove ops parameter.
 217         (ada_catchpoint_location_dtor): Remove.
 218         (ada_catchpoint_location_ops): Remove.
 219         (allocate_location_exception): Update.
 220         * breakpoint.h (struct bp_location_ops): Remove.
 221         (class bp_location) <bp_location>: Remove bp_location_ops
 222         parameter.
 223         <~bp_location>: Add destructor.
 224         <ops>: Remove.
 225
 226 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 227             Pedro Alves  <palves@redhat.com>
 228
 229         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 230         'PATH_MAX'.
 231
 232 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 233             Samuel Thibault  <samuel.thibault@gnu.org>
 234             Thomas Schwinge  <thomas@codesourcery.com>
 235
 236         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 237         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 238
 239 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 240
 241         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 242         (check_empty): Use "const char *".
 243
 244         * gnu-nat.c (gnu_nat_target::detach): Instead of
 245         'detach_inferior (pid)' call
 246         'detach_inferior (find_inferior_pid (pid))'.
 247
 248         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 249         'nat/fork-inferior.o'.
 250         * gnu-nat.c: #include "nat/fork-inferior.h".
 251
 252         * gnu-nat.c (gnu_nat_target::detach): Instead of
 253         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 254         * gnu-nat.h: #include "inf-child.h".
 255         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 256         'i386_gnu_nat_target::fetch_registers'.
 257         (gnu_store_registers): Rename/move to
 258         'i386_gnu_nat_target::store_registers'.
 259
 260         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 261         * gnu-nat.h (mach_thread_info): New function.
 262         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 263
 264         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 265
 266 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 267
 268         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 269
 270 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 271
 272         * windows-nat.c (windows_add_thread): Add new parameter
 273         "main_thread_p" with default value set to false.  Update
 274         function documentation as well as all callers.
 275         (windows_delete_thread): Likewise.
 276         (fake_create_process): Update call to windows_add_thread.
 277         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 278         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 279         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 280         call to windows_delete_thread.
 281
 282 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 283
 284         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 285
 286 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 287
 288         * symfile.c (find_separate_debug_file): Use canonical path of
 289         sysroot with child_path instead of gdb_sysroot if it is valid.
 290
 291 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 292
 293         * symfile.c (find_separate_debug_file): Use child_path to
 294         determine if an object file is under a sysroot.
 295
 296 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 297
 298         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 299         unittests/child-path-selftests.c.
 300         * common/pathstuff.c (child_path): New function.
 301         * common/pathstuff.h (child_path): New prototype.
 302         * unittests/child-path-selftests.c: New file.
 303
 304 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 305
 306         * symfile.c (find_separate_debug_file): Look for separate debug
 307         files in debug directories under the sysroot.
 308
 309 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 310
 311         * symtab.h (struct minimal_symbol data_p): New const method.
 312         (struct minimal_symbol text_p): Likewise.
 313         * symtab.c (output_source_filename): Use file name style
 314         to print file name.
 315         (print_symbol_info): Likewise.
 316         (print_msymbol_info): Use address style to print addresses.
 317         Use function name style to print executable text symbols.
 318         (expand_symtab_containing_pc): Use data_p.
 319         (find_pc_sect_compunit_symtab): Likewise.
 320
 321 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 322
 323         * breakpoint.c (describe_other_breakpoints): Use address style
 324         to print addresses.
 325         (say_where): Likewise.
 326
 327 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 328
 329         * ada-typeprint.c (print_func_type): Print function name
 330         style to print function name.
 331         * c-typeprint.c (c_print_type_1): Likewise.
 332
 333 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 334
 335         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 336         for execve.
 337
 338 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 339
 340         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 341         type_stack.
 342
 343 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 344
 345         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 346         TYPE_CODE_REF types.
 347
 348 2019-02-08  Jim Wilson  <jimw@sifive.com>
 349
 350         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 351         (riscv_linux_fregset): New.
 352         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 353
 354 2019-02-07  Tom Tromey  <tom@tromey.com>
 355
 356         * thread.c (thread_cancel_execution_command): Update.
 357         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 358         methods.
 359         (struct thread_fsm_ops): Remove.
 360         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 361         (thread_fsm_should_stop, thread_fsm_return_value)
 362         (thread_fsm_set_finished, thread_fsm_finished_p)
 363         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 364         Don't declare.
 365         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 366         * infrun.c (clear_proceed_status_thread)
 367         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 368         (print_stop_event): Update.
 369         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 370         Add constructor.
 371         (step_command_fsm_ops): Remove.
 372         (new_step_command_fsm): Remove.
 373         (step_1): Update.
 374         (step_command_fsm::should_stop): Rename from
 375         step_command_fsm_should_stop.
 376         (step_command_fsm::clean_up): Rename from
 377         step_command_fsm_clean_up.
 378         (step_command_fsm::do_async_reply_reason): Rename from
 379         step_command_fsm_async_reply_reason.
 380         (struct until_next_fsm): Inherit from thread_fsm.  Add
 381         constructor.
 382         (until_next_fsm_ops): Remove.
 383         (new_until_next_fsm): Remove.
 384         (until_next_fsm::should_stop): Rename from
 385         until_next_fsm_should_stop.
 386         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 387         (until_next_fsm::do_async_reply_reason): Rename from
 388         until_next_fsm_async_reply_reason.
 389         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 390         constructor.  Change type of breakpoint.
 391         (finish_command_fsm_ops): Remove.
 392         (new_finish_command_fsm): Remove.
 393         (finish_command_fsm::should_stop): Rename from
 394         finish_command_fsm_should_stop.
 395         (finish_command_fsm::clean_up): Rename from
 396         finish_command_fsm_clean_up.
 397         (finish_command_fsm::return_value): Rename from
 398         finish_command_fsm_return_value.
 399         (finish_command_fsm::do_async_reply_reason): Rename from
 400         finish_command_fsm_async_reply_reason.
 401         (finish_command): Update.
 402         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 403         Add constructor.
 404         (call_thread_fsm_ops): Remove.
 405         (call_thread_fsm::call_thread_fsm): Rename from
 406         new_call_thread_fsm.
 407         (call_thread_fsm::should_stop): Rename from
 408         call_thread_fsm_should_stop.
 409         (call_thread_fsm::should_notify_stop): Rename from
 410         call_thread_fsm_should_notify_stop.
 411         (run_inferior_call, call_function_by_hand_dummy): Update.
 412         * cli/cli-interp.c (should_print_stop_to_console): Update.
 413         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 414         Add constructor.  Change type of location_breakpoint,
 415         caller_breakpoint.
 416         (until_break_fsm_ops): Remove.
 417         (new_until_break_fsm): Remove.
 418         (until_break_fsm::should_stop): Rename from
 419         until_break_fsm_should_stop.
 420         (until_break_fsm::clean_up): Rename from
 421         until_break_fsm_clean_up.
 422         (until_break_fsm::do_async_reply_reason): Rename from
 423         until_break_fsm_async_reply_reason.
 424         (until_break_command): Update.
 425         * thread-fsm.c: Remove.
 426         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 427
 428 2019-02-07  Tom Tromey  <tom@tromey.com>
 429
 430         * yy-remap.h: Add include guard.
 431         * xtensa-tdep.h: Add include guard.
 432         * xcoffread.h: Rename include guard.
 433         * varobj-iter.h: Add include guard.
 434         * tui/tui.h: Rename include guard.
 435         * tui/tui-winsource.h: Rename include guard.
 436         * tui/tui-wingeneral.h: Rename include guard.
 437         * tui/tui-windata.h: Rename include guard.
 438         * tui/tui-win.h: Rename include guard.
 439         * tui/tui-stack.h: Rename include guard.
 440         * tui/tui-source.h: Rename include guard.
 441         * tui/tui-regs.h: Rename include guard.
 442         * tui/tui-out.h: Rename include guard.
 443         * tui/tui-layout.h: Rename include guard.
 444         * tui/tui-io.h: Rename include guard.
 445         * tui/tui-hooks.h: Rename include guard.
 446         * tui/tui-file.h: Rename include guard.
 447         * tui/tui-disasm.h: Rename include guard.
 448         * tui/tui-data.h: Rename include guard.
 449         * tui/tui-command.h: Rename include guard.
 450         * tic6x-tdep.h: Add include guard.
 451         * target/waitstatus.h: Rename include guard.
 452         * target/wait.h: Rename include guard.
 453         * target/target.h: Rename include guard.
 454         * target/resume.h: Rename include guard.
 455         * target-float.h: Rename include guard.
 456         * stabsread.h: Add include guard.
 457         * rs6000-tdep.h: Add include guard.
 458         * riscv-fbsd-tdep.h: Add include guard.
 459         * regformats/regdef.h: Rename include guard.
 460         * record.h: Rename include guard.
 461         * python/python.h: Rename include guard.
 462         * python/python-internal.h: Rename include guard.
 463         * python/py-stopevent.h: Rename include guard.
 464         * python/py-ref.h: Rename include guard.
 465         * python/py-record.h: Rename include guard.
 466         * python/py-record-full.h: Rename include guard.
 467         * python/py-record-btrace.h: Rename include guard.
 468         * python/py-instruction.h: Rename include guard.
 469         * python/py-events.h: Rename include guard.
 470         * python/py-event.h: Rename include guard.
 471         * procfs.h: Add include guard.
 472         * proc-utils.h: Add include guard.
 473         * p-lang.h: Add include guard.
 474         * or1k-tdep.h: Rename include guard.
 475         * observable.h: Rename include guard.
 476         * nto-tdep.h: Rename include guard.
 477         * nat/x86-linux.h: Rename include guard.
 478         * nat/x86-linux-dregs.h: Rename include guard.
 479         * nat/x86-gcc-cpuid.h: Add include guard.
 480         * nat/x86-dregs.h: Rename include guard.
 481         * nat/x86-cpuid.h: Rename include guard.
 482         * nat/ppc-linux.h: Rename include guard.
 483         * nat/mips-linux-watch.h: Rename include guard.
 484         * nat/linux-waitpid.h: Rename include guard.
 485         * nat/linux-ptrace.h: Rename include guard.
 486         * nat/linux-procfs.h: Rename include guard.
 487         * nat/linux-osdata.h: Rename include guard.
 488         * nat/linux-nat.h: Rename include guard.
 489         * nat/linux-namespaces.h: Rename include guard.
 490         * nat/linux-btrace.h: Rename include guard.
 491         * nat/glibc_thread_db.h: Rename include guard.
 492         * nat/gdb_thread_db.h: Rename include guard.
 493         * nat/gdb_ptrace.h: Rename include guard.
 494         * nat/fork-inferior.h: Rename include guard.
 495         * nat/amd64-linux-siginfo.h: Rename include guard.
 496         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 497         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 498         * nat/aarch64-linux.h: Rename include guard.
 499         * nat/aarch64-linux-hw-point.h: Rename include guard.
 500         * mn10300-tdep.h: Add include guard.
 501         * mips-linux-tdep.h: Add include guard.
 502         * mi/mi-parse.h: Rename include guard.
 503         * mi/mi-out.h: Rename include guard.
 504         * mi/mi-main.h: Rename include guard.
 505         * mi/mi-interp.h: Rename include guard.
 506         * mi/mi-getopt.h: Rename include guard.
 507         * mi/mi-console.h: Rename include guard.
 508         * mi/mi-common.h: Rename include guard.
 509         * mi/mi-cmds.h: Rename include guard.
 510         * mi/mi-cmd-break.h: Rename include guard.
 511         * m2-lang.h: Add include guard.
 512         * location.h: Rename include guard.
 513         * linux-record.h: Rename include guard.
 514         * linux-nat.h: Add include guard.
 515         * linux-fork.h: Add include guard.
 516         * i386-darwin-tdep.h: Rename include guard.
 517         * hppa-linux-offsets.h: Add include guard.
 518         * guile/guile.h: Rename include guard.
 519         * guile/guile-internal.h: Rename include guard.
 520         * gnu-nat.h: Rename include guard.
 521         * gdb-stabs.h: Rename include guard.
 522         * frv-tdep.h: Add include guard.
 523         * f-lang.h: Add include guard.
 524         * event-loop.h: Add include guard.
 525         * darwin-nat.h: Rename include guard.
 526         * cp-abi.h: Rename include guard.
 527         * config/sparc/nm-sol2.h: Rename include guard.
 528         * config/nm-nto.h: Rename include guard.
 529         * config/nm-linux.h: Add include guard.
 530         * config/i386/nm-i386gnu.h: Rename include guard.
 531         * config/djgpp/nl_types.h: Rename include guard.
 532         * config/djgpp/langinfo.h: Rename include guard.
 533         * compile/gcc-cp-plugin.h: Add include guard.
 534         * compile/gcc-c-plugin.h: Add include guard.
 535         * compile/compile.h: Rename include guard.
 536         * compile/compile-object-run.h: Rename include guard.
 537         * compile/compile-object-load.h: Rename include guard.
 538         * compile/compile-internal.h: Rename include guard.
 539         * compile/compile-cplus.h: Rename include guard.
 540         * compile/compile-c.h: Rename include guard.
 541         * common/xml-utils.h: Rename include guard.
 542         * common/x86-xstate.h: Rename include guard.
 543         * common/version.h: Rename include guard.
 544         * common/vec.h: Rename include guard.
 545         * common/tdesc.h: Rename include guard.
 546         * common/selftest.h: Rename include guard.
 547         * common/scoped_restore.h: Rename include guard.
 548         * common/scoped_mmap.h: Rename include guard.
 549         * common/scoped_fd.h: Rename include guard.
 550         * common/safe-iterator.h: Rename include guard.
 551         * common/run-time-clock.h: Rename include guard.
 552         * common/refcounted-object.h: Rename include guard.
 553         * common/queue.h: Rename include guard.
 554         * common/ptid.h: Rename include guard.
 555         * common/print-utils.h: Rename include guard.
 556         * common/preprocessor.h: Rename include guard.
 557         * common/pathstuff.h: Rename include guard.
 558         * common/observable.h: Rename include guard.
 559         * common/netstuff.h: Rename include guard.
 560         * common/job-control.h: Rename include guard.
 561         * common/host-defs.h: Rename include guard.
 562         * common/gdb_wait.h: Rename include guard.
 563         * common/gdb_vecs.h: Rename include guard.
 564         * common/gdb_unlinker.h: Rename include guard.
 565         * common/gdb_unique_ptr.h: Rename include guard.
 566         * common/gdb_tilde_expand.h: Rename include guard.
 567         * common/gdb_sys_time.h: Rename include guard.
 568         * common/gdb_string_view.h: Rename include guard.
 569         * common/gdb_splay_tree.h: Rename include guard.
 570         * common/gdb_setjmp.h: Rename include guard.
 571         * common/gdb_ref_ptr.h: Rename include guard.
 572         * common/gdb_optional.h: Rename include guard.
 573         * common/gdb_locale.h: Rename include guard.
 574         * common/gdb_assert.h: Rename include guard.
 575         * common/filtered-iterator.h: Rename include guard.
 576         * common/filestuff.h: Rename include guard.
 577         * common/fileio.h: Rename include guard.
 578         * common/environ.h: Rename include guard.
 579         * common/common-utils.h: Rename include guard.
 580         * common/common-types.h: Rename include guard.
 581         * common/common-regcache.h: Rename include guard.
 582         * common/common-inferior.h: Rename include guard.
 583         * common/common-gdbthread.h: Rename include guard.
 584         * common/common-exceptions.h: Rename include guard.
 585         * common/common-defs.h: Rename include guard.
 586         * common/common-debug.h: Rename include guard.
 587         * common/cleanups.h: Rename include guard.
 588         * common/buffer.h: Rename include guard.
 589         * common/btrace-common.h: Rename include guard.
 590         * common/break-common.h: Rename include guard.
 591         * cli/cli-utils.h: Rename include guard.
 592         * cli/cli-style.h: Rename include guard.
 593         * cli/cli-setshow.h: Rename include guard.
 594         * cli/cli-script.h: Rename include guard.
 595         * cli/cli-interp.h: Rename include guard.
 596         * cli/cli-decode.h: Rename include guard.
 597         * cli/cli-cmds.h: Rename include guard.
 598         * charset-list.h: Add include guard.
 599         * buildsym-legacy.h: Rename include guard.
 600         * bfin-tdep.h: Add include guard.
 601         * ax.h: Rename include guard.
 602         * arm-linux-tdep.h: Add include guard.
 603         * arm-fbsd-tdep.h: Add include guard.
 604         * arch/xtensa.h: Rename include guard.
 605         * arch/tic6x.h: Add include guard.
 606         * arch/i386.h: Add include guard.
 607         * arch/arm.h: Rename include guard.
 608         * arch/arm-linux.h: Rename include guard.
 609         * arch/arm-get-next-pcs.h: Rename include guard.
 610         * arch/amd64.h: Add include guard.
 611         * arch/aarch64-insn.h: Rename include guard.
 612         * arch-utils.h: Rename include guard.
 613         * annotate.h: Add include guard.
 614         * amd64-darwin-tdep.h: Rename include guard.
 615         * aarch64-linux-tdep.h: Add include guard.
 616         * aarch64-fbsd-tdep.h: Add include guard.
 617         * aarch32-linux-nat.h: Add include guard.
 618
 619 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 620
 621         * macrotab.c (macro_define_internal): New function that
 622         factorizes macro_define_object_internal and macro_define_function
 623         code.
 624         (macro_define_object_internal): Use macro_define_internal.
 625         (macro_define_function): Likewise.
 626
 627 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 628
 629         * macrocmd.c (extract_identifier): Return
 630         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 631         callers.
 632
 633 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 634
 635         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 636
 637 2019-02-05  Tom Tromey  <tom@tromey.com>
 638
 639         * target.c (target_stack::unpush): Move assertion earlier.
 640
 641 2019-01-30  Tom Tromey  <tom@tromey.com>
 642
 643         PR python/23615:
 644         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 645         (gdbpy_parse_and_eval): Likewise.
 646         * python/python-internal.h (gdbpy_allow_threads): New class.
 647
 648 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 649
 650         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 651         (aarch64_fbsd_fpregmap): Move earlier.
 652         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 653         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 654         instead of individual calls to trad_frame_set_reg_addr.
 655         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 656         earlier.
 657         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 658         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 659         instead of individual calls to trad_frame_set_reg_addr.
 660
 661 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 662
 663         * CONTRIBUTE: Replace contribution list with wiki link.
 664
 665 2019-01-25  Tom Tromey  <tom@tromey.com>
 666
 667         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 668
 669 2019-01-25  Tom Tromey  <tom@tromey.com>
 670
 671         * xtensa-linux-nat.c: Fix common/ includes.
 672         * xml-support.h: Fix common/ includes.
 673         * xml-support.c: Fix common/ includes.
 674         * x86-linux-nat.c: Fix common/ includes.
 675         * windows-nat.c: Fix common/ includes.
 676         * varobj.h: Fix common/ includes.
 677         * varobj.c: Fix common/ includes.
 678         * value.c: Fix common/ includes.
 679         * valops.c: Fix common/ includes.
 680         * utils.c: Fix common/ includes.
 681         * unittests/xml-utils-selftests.c: Fix common/ includes.
 682         * unittests/utils-selftests.c: Fix common/ includes.
 683         * unittests/unpack-selftests.c: Fix common/ includes.
 684         * unittests/tracepoint-selftests.c: Fix common/ includes.
 685         * unittests/style-selftests.c: Fix common/ includes.
 686         * unittests/string_view-selftests.c: Fix common/ includes.
 687         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 688         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 689         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 690         * unittests/rsp-low-selftests.c: Fix common/ includes.
 691         * unittests/parse-connection-spec-selftests.c: Fix common/
 692         includes.
 693         * unittests/optional-selftests.c: Fix common/ includes.
 694         * unittests/offset-type-selftests.c: Fix common/ includes.
 695         * unittests/observable-selftests.c: Fix common/ includes.
 696         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 697         * unittests/memrange-selftests.c: Fix common/ includes.
 698         * unittests/memory-map-selftests.c: Fix common/ includes.
 699         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 700         * unittests/function-view-selftests.c: Fix common/ includes.
 701         * unittests/environ-selftests.c: Fix common/ includes.
 702         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 703         * unittests/common-utils-selftests.c: Fix common/ includes.
 704         * unittests/cli-utils-selftests.c: Fix common/ includes.
 705         * unittests/array-view-selftests.c: Fix common/ includes.
 706         * ui-file.c: Fix common/ includes.
 707         * tui/tui-io.c: Fix common/ includes.
 708         * tracepoint.h: Fix common/ includes.
 709         * tracepoint.c: Fix common/ includes.
 710         * tracefile-tfile.c: Fix common/ includes.
 711         * top.h: Fix common/ includes.
 712         * top.c: Fix common/ includes.
 713         * thread.c: Fix common/ includes.
 714         * target/waitstatus.h: Fix common/ includes.
 715         * target/waitstatus.c: Fix common/ includes.
 716         * target.h: Fix common/ includes.
 717         * target.c: Fix common/ includes.
 718         * target-memory.c: Fix common/ includes.
 719         * target-descriptions.c: Fix common/ includes.
 720         * symtab.h: Fix common/ includes.
 721         * symfile.c: Fix common/ includes.
 722         * stap-probe.c: Fix common/ includes.
 723         * spu-linux-nat.c: Fix common/ includes.
 724         * sparc-nat.c: Fix common/ includes.
 725         * source.c: Fix common/ includes.
 726         * solib.c: Fix common/ includes.
 727         * solib-target.c: Fix common/ includes.
 728         * ser-unix.c: Fix common/ includes.
 729         * ser-tcp.c: Fix common/ includes.
 730         * ser-pipe.c: Fix common/ includes.
 731         * ser-base.c: Fix common/ includes.
 732         * selftest-arch.c: Fix common/ includes.
 733         * s12z-tdep.c: Fix common/ includes.
 734         * rust-exp.y: Fix common/ includes.
 735         * rs6000-aix-tdep.c: Fix common/ includes.
 736         * riscv-tdep.c: Fix common/ includes.
 737         * remote.c: Fix common/ includes.
 738         * remote-notif.h: Fix common/ includes.
 739         * remote-fileio.h: Fix common/ includes.
 740         * remote-fileio.c: Fix common/ includes.
 741         * regcache.h: Fix common/ includes.
 742         * regcache.c: Fix common/ includes.
 743         * record-btrace.c: Fix common/ includes.
 744         * python/python.c: Fix common/ includes.
 745         * python/py-type.c: Fix common/ includes.
 746         * python/py-inferior.c: Fix common/ includes.
 747         * progspace.h: Fix common/ includes.
 748         * producer.c: Fix common/ includes.
 749         * procfs.c: Fix common/ includes.
 750         * proc-api.c: Fix common/ includes.
 751         * printcmd.c: Fix common/ includes.
 752         * ppc-linux-nat.c: Fix common/ includes.
 753         * parser-defs.h: Fix common/ includes.
 754         * osdata.c: Fix common/ includes.
 755         * obsd-nat.c: Fix common/ includes.
 756         * nat/x86-linux.c: Fix common/ includes.
 757         * nat/x86-linux-dregs.c: Fix common/ includes.
 758         * nat/x86-dregs.h: Fix common/ includes.
 759         * nat/x86-dregs.c: Fix common/ includes.
 760         * nat/ppc-linux.c: Fix common/ includes.
 761         * nat/mips-linux-watch.h: Fix common/ includes.
 762         * nat/mips-linux-watch.c: Fix common/ includes.
 763         * nat/linux-waitpid.c: Fix common/ includes.
 764         * nat/linux-ptrace.h: Fix common/ includes.
 765         * nat/linux-ptrace.c: Fix common/ includes.
 766         * nat/linux-procfs.c: Fix common/ includes.
 767         * nat/linux-personality.c: Fix common/ includes.
 768         * nat/linux-osdata.c: Fix common/ includes.
 769         * nat/linux-namespaces.c: Fix common/ includes.
 770         * nat/linux-btrace.h: Fix common/ includes.
 771         * nat/linux-btrace.c: Fix common/ includes.
 772         * nat/fork-inferior.c: Fix common/ includes.
 773         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 774         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 775         * nat/aarch64-linux.c: Fix common/ includes.
 776         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 777         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 778         * namespace.h: Fix common/ includes.
 779         * mips-linux-tdep.c: Fix common/ includes.
 780         * minsyms.c: Fix common/ includes.
 781         * mi/mi-parse.h: Fix common/ includes.
 782         * mi/mi-main.c: Fix common/ includes.
 783         * mi/mi-cmd-env.c: Fix common/ includes.
 784         * memrange.h: Fix common/ includes.
 785         * memattr.c: Fix common/ includes.
 786         * maint.h: Fix common/ includes.
 787         * maint.c: Fix common/ includes.
 788         * main.c: Fix common/ includes.
 789         * machoread.c: Fix common/ includes.
 790         * location.c: Fix common/ includes.
 791         * linux-thread-db.c: Fix common/ includes.
 792         * linux-nat.c: Fix common/ includes.
 793         * linux-fork.c: Fix common/ includes.
 794         * inline-frame.c: Fix common/ includes.
 795         * infrun.c: Fix common/ includes.
 796         * inflow.c: Fix common/ includes.
 797         * inferior.h: Fix common/ includes.
 798         * inferior.c: Fix common/ includes.
 799         * infcmd.c: Fix common/ includes.
 800         * inf-ptrace.c: Fix common/ includes.
 801         * inf-child.c: Fix common/ includes.
 802         * ia64-linux-nat.c: Fix common/ includes.
 803         * i387-tdep.c: Fix common/ includes.
 804         * i386-tdep.c: Fix common/ includes.
 805         * i386-linux-tdep.c: Fix common/ includes.
 806         * i386-linux-nat.c: Fix common/ includes.
 807         * i386-go32-tdep.c: Fix common/ includes.
 808         * i386-fbsd-tdep.c: Fix common/ includes.
 809         * i386-fbsd-nat.c: Fix common/ includes.
 810         * guile/scm-type.c: Fix common/ includes.
 811         * guile/guile.c: Fix common/ includes.
 812         * go32-nat.c: Fix common/ includes.
 813         * gnu-nat.c: Fix common/ includes.
 814         * gdbthread.h: Fix common/ includes.
 815         * gdbarch-selftests.c: Fix common/ includes.
 816         * gdb_usleep.c: Fix common/ includes.
 817         * gdb_select.h: Fix common/ includes.
 818         * gdb_bfd.c: Fix common/ includes.
 819         * gcore.c: Fix common/ includes.
 820         * fork-child.c: Fix common/ includes.
 821         * findvar.c: Fix common/ includes.
 822         * fbsd-nat.c: Fix common/ includes.
 823         * event-top.c: Fix common/ includes.
 824         * event-loop.c: Fix common/ includes.
 825         * dwarf2read.c: Fix common/ includes.
 826         * dwarf2loc.c: Fix common/ includes.
 827         * dwarf2-frame.c: Fix common/ includes.
 828         * dwarf-index-cache.c: Fix common/ includes.
 829         * dtrace-probe.c: Fix common/ includes.
 830         * disasm-selftests.c: Fix common/ includes.
 831         * defs.h: Fix common/ includes.
 832         * csky-tdep.c: Fix common/ includes.
 833         * cp-valprint.c: Fix common/ includes.
 834         * cp-support.h: Fix common/ includes.
 835         * cp-support.c: Fix common/ includes.
 836         * corelow.c: Fix common/ includes.
 837         * completer.h: Fix common/ includes.
 838         * completer.c: Fix common/ includes.
 839         * compile/compile.c: Fix common/ includes.
 840         * compile/compile-loc2c.c: Fix common/ includes.
 841         * compile/compile-cplus-types.c: Fix common/ includes.
 842         * compile/compile-cplus-symbols.c: Fix common/ includes.
 843         * command.h: Fix common/ includes.
 844         * cli/cli-dump.c: Fix common/ includes.
 845         * cli/cli-cmds.c: Fix common/ includes.
 846         * charset.c: Fix common/ includes.
 847         * build-id.c: Fix common/ includes.
 848         * btrace.h: Fix common/ includes.
 849         * btrace.c: Fix common/ includes.
 850         * breakpoint.h: Fix common/ includes.
 851         * breakpoint.c: Fix common/ includes.
 852         * ax.h:
 853         (enum agent_op): Fix common/ includes.
 854         * ax-general.c (struct aop_map): Fix common/ includes.
 855         * ax-gdb.c: Fix common/ includes.
 856         * auxv.c: Fix common/ includes.
 857         * auto-load.c: Fix common/ includes.
 858         * arm-tdep.c: Fix common/ includes.
 859         * arch/riscv.c: Fix common/ includes.
 860         * arch/ppc-linux-common.c: Fix common/ includes.
 861         * arch/i386.c: Fix common/ includes.
 862         * arch/arm.c: Fix common/ includes.
 863         * arch/arm-linux.c: Fix common/ includes.
 864         * arch/arm-get-next-pcs.c: Fix common/ includes.
 865         * arch/amd64.c: Fix common/ includes.
 866         * arch/aarch64.c: Fix common/ includes.
 867         * arch/aarch64-insn.c: Fix common/ includes.
 868         * arch-utils.c: Fix common/ includes.
 869         * amd64-windows-tdep.c: Fix common/ includes.
 870         * amd64-tdep.c: Fix common/ includes.
 871         * amd64-sol2-tdep.c: Fix common/ includes.
 872         * amd64-obsd-tdep.c: Fix common/ includes.
 873         * amd64-nbsd-tdep.c: Fix common/ includes.
 874         * amd64-linux-tdep.c: Fix common/ includes.
 875         * amd64-linux-nat.c: Fix common/ includes.
 876         * amd64-fbsd-tdep.c: Fix common/ includes.
 877         * amd64-fbsd-nat.c: Fix common/ includes.
 878         * amd64-dicos-tdep.c: Fix common/ includes.
 879         * amd64-darwin-tdep.c: Fix common/ includes.
 880         * agent.c: Fix common/ includes.
 881         * ada-lang.h: Fix common/ includes.
 882         * ada-lang.c: Fix common/ includes.
 883         * aarch64-tdep.c: Fix common/ includes.
 884
 885 2019-01-25  Tom Tromey  <tom@tromey.com>
 886
 887         * common/create-version.sh: Use common/version.h.
 888
 889 2019-01-24  Pedro Alves  <palves@redhat.com>
 890
 891         * infrun.c (signal_stop, signal_print, signal_program)
 892         (signal_catch, signal_pass): Now arrays instead of pointers.
 893         (update_signals_program_target, do_target_resume)
 894         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 895         * linux-nat.c (linux_nat_target::pass_signals)
 896         (linux_nat_target::create_inferior, linux_nat_target::attach):
 897         Adjust.
 898         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 899         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 900         * procfs.c (procfs_target::pass_signals): Adjust.
 901         * record-full.c (record_full_target::resume): Adjust.
 902         * remote.c (remote_target::pass_signals)
 903         (remote_target::program_signals): Adjust.
 904         * target-debug.h (target_debug_print_signals): Now takes a
 905         gdb::array_view as parameter.  Adjust.
 906         * target.h (target_ops) <pass_signals, program_signals>: Replace
 907         pointer and length parameters with gdb::array_view.
 908         (target_pass_signals, target_program_signals): Likewise.
 909         * target-delegates.c: Regenerate.
 910
 911 2019-01-24  Pedro Alves  <palves@redhat.com>
 912
 913         * common/forward-scope-exit.h
 914         (forward_scope_exit::forward_scope_exit): Pass arguments to
 915         m_bind_function directly, instead of creating a std::bind and
 916         copying that.
 917
 918 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 919
 920         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 921         for static members.
 922         (pass_in_v_vfp_candidate): Likewise.
 923
 924 2019-01-23  Tom Tromey  <tom@tromey.com>
 925             Pedro Alves  <palves@redhat.com>
 926
 927         * regcache.c (class regcache_invalidator): Remove.
 928         (regcache::raw_write): Use make_scope_exit.
 929
 930 2019-01-23  Tom Tromey  <tom@tromey.com>
 931
 932         * ui-out.h (class ui_out_emit_type): Update comment.
 933
 934 2019-01-23  Tom Tromey  <tom@tromey.com>
 935
 936         * infrun.c (fetch_inferior_event): Update comment.
 937
 938 2019-01-23  Tom Tromey  <tom@tromey.com>
 939             Pedro Alves  <palves@redhat.com>
 940
 941         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 942         parameter.
 943         (fetch_inferior_event): Use SCOPE_EXIT.
 944
 945
 946 2019-01-23  Tom Tromey  <tom@tromey.com>
 947             Pedro Alves  <palves@redhat.com>
 948
 949         * infrun.c (disable_thread_events): Delete.
 950         (stop_all_threads): Use SCOPE_EXIT.
 951
 952 2019-01-23  Tom Tromey  <tom@tromey.com>
 953             Pedro Alves  <palves@redhat.com>
 954
 955         * symfile.c: Include forward-scope-exit.h.
 956         (clear_symtab_users_cleanup): Replace forward declaration with
 957         a FORWARD_SCOPE_EXIT.
 958         (syms_from_objfile_1): Use the forward_scope_exit and
 959         gdb::optional instead of cleanup_function.
 960         (reread_symbols): Use the forward_scope_exit instead of
 961         cleanup_function.
 962         (clear_symtab_users_cleanup): Remove function.
 963
 964 2019-01-23  Tom Tromey  <tom@tromey.com>
 965             Pedro Alves  <palves@redhat.com>
 966
 967         * linux-nat.c: Include scope-exit.h.
 968         (cleanup_target_stop): Remove.
 969         (linux_nat_target::static_tracepoint_markers_by_strid): Use
 970         SCOPE_EXIT.
 971
 972 2019-01-23  Tom Tromey  <tom@tromey.com>
 973             Pedro Alves  <palves@redhat.com>
 974
 975         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
 976         (call_function_by_hand_dummy): Use SCOPE_EXIT.
 977
 978 2019-01-23  Tom Tromey  <tom@tromey.com>
 979             Andrew Burgess  <andrew.burgess@embecosm.com>
 980             Pedro Alves  <palves@redhat.com>
 981
 982         * infrun.c (fetch_inferior_event): Use scope_exit.
 983         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
 984         * top.c (execute_command): Use scope_exit.
 985         * breakpoint.c (bpstat_do_actions): Use scope_exit.
 986         * utils.c (do_bpstat_clear_actions_cleanup)
 987         (make_bpstat_clear_actions_cleanup): Remove.
 988
 989 2019-01-23  Tom Tromey  <tom@tromey.com>
 990             Pedro Alves  <palves@redhat.com>
 991
 992         * infrun.c: Include "common/scope-exit.h"
 993         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
 994         (wait_for_inferior): Use SCOPE_EXIT.
 995         (fetch_inferior_event): Use scope_exit.
 996
 997 2019-01-23  Tom Tromey  <tom@tromey.com>
 998             Pedro Alves  <palves@redhat.com>
 999
1000         * breakpoint.c (create_breakpoint): Remove cleanup.
1001
1002 2019-01-23  Tom Tromey  <tom@tromey.com>
1003             Andrew Burgess  <andrew.burgess@embecosm.com>
1004             Pedro Alves  <palves@redhat.com>
1005
1006 2019-01-23  Pedro Alves  <palves@redhat.com>
1007
1008         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1009
1010 2019-01-23  Pedro Alves  <palves@redhat.com>
1011             Andrew Burgess  <andrew.burgess@embecosm.com>
1012
1013         * gdbthread.h: Include "common/forward-scope-exit.h".
1014         (scoped_finish_thread_state): Redefine custom class in terms of
1015         forward_scope_exit.
1016
1017 2019-01-23  Pedro Alves  <palves@redhat.com>
1018             Andrew Burgess  <andrew.burgess@embecosm.com>
1019
1020         * common/forward-scope-exit.h: New file.
1021
1022 2019-01-23  Pedro Alves  <palves@redhat.com>
1023             Andrew Burgess  <andrew.burgess@embecosm.com>
1024             Tom Tromey  <tom@tromey.com>
1025
1026         * common/scope-exit.h: New file.
1027
1028 2019-01-23  Pedro Alves  <palves@redhat.com>
1029
1030         * common/preprocessor.h (ESC): Rename to ...
1031         (ESC_PARENS): ... this.
1032         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1033         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1034
1035 2019-01-23  Tom Tromey  <tom@tromey.com>
1036
1037         * language.h (class scoped_switch_to_sym_language_if_auto):
1038         Initialize m_lang in both cases.
1039
1040 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1041
1042         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1043         with XCNEW.
1044
1045 2019-01-22  Tom Tromey  <tom@tromey.com>
1046
1047         * corelow.c: Do not include sys/file.h.
1048
1049 2019-01-22  Tom Tromey  <tom@tromey.com>
1050
1051         * tui/tui-wingeneral.h: Include gdb_curses.h.
1052
1053 2019-01-22  Tom Tromey  <tom@tromey.com>
1054
1055         * source-cache.h (class source_cache) <get_source_lines,
1056         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1057
1058 2019-01-22  Tom Tromey  <tom@tromey.com>
1059
1060         * remote-fileio.h (struct remote_target): Declare.
1061
1062 2019-01-22  Tom Tromey  <tom@tromey.com>
1063
1064         * python/py-arch.c: Do not include py-ref.h.
1065         * python/py-bpevent.c: Do not include py-ref.h.
1066         * python/py-cmd.c: Do not include py-ref.h.
1067         * python/py-continueevent.c: Do not include py-ref.h.
1068         * python/py-event.h: Do not include py-ref.h.
1069         * python/py-evtregistry.c: Do not include py-ref.h.
1070         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1071         * python/py-frame.c: Do not include py-ref.h.
1072         * python/py-framefilter.c: Do not include py-ref.h.
1073         * python/py-function.c: Do not include py-ref.h.
1074         * python/py-infevents.c: Do not include py-ref.h.
1075         * python/py-linetable.c: Do not include py-ref.h.
1076         * python/py-objfile.c: Do not include py-ref.h.
1077         * python/py-param.c: Do not include py-ref.h.
1078         * python/py-prettyprint.c: Do not include py-ref.h.
1079         * python/py-progspace.c: Do not include py-ref.h.
1080         * python/py-symbol.c: Do not include py-ref.h.
1081         * python/py-symtab.c: Do not include py-ref.h.
1082         * python/py-type.c: Do not include py-ref.h.
1083         * python/py-unwind.c: Do not include py-ref.h.
1084         * python/py-utils.c: Do not include py-ref.h.
1085         * python/py-value.c: Do not include py-ref.h.
1086         * python/py-varobj.c: Do not include py-ref.h.
1087         * python/py-xmethods.c: Do not include py-ref.h.
1088         * python/python.c: Do not include py-ref.h.
1089         * varobj.c: Do not include py-ref.h.
1090
1091 2019-01-22  Tom Tromey  <tom@tromey.com>
1092
1093         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1094         keyword for bcache.
1095
1096 2019-01-22  Tom Tromey  <tom@tromey.com>
1097
1098         * compile/compile-cplus-types.c: Remove a comment by #include.
1099
1100 2019-01-22  Tom Tromey  <tom@tromey.com>
1101
1102         * compile/gcc-c-plugin.h: Include compile-internal.h.
1103
1104 2019-01-22  Tom Tromey  <tom@tromey.com>
1105
1106         * stabsread.c (EXTERN): Do not define.
1107         (symnum, next_symbol_text_func, processing_gcc_compilation)
1108         (within_function, global_sym_chain, global_stabs)
1109         (previous_stab_code, this_object_header_files)
1110         (n_this_object_header_files)
1111         (n_allocated_this_object_header_files): Define.
1112         * stabsread.h (EXTERN): Never define.  Use "extern".
1113
1114 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1115
1116         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1117         history_value.
1118
1119 2019-01-21  Tom Tromey  <tom@tromey.com>
1120
1121         * ui-out.c: Fix includes.
1122         * tui/tui-source.c: Fix includes.
1123         * target.c: Fix includes.
1124         * remote.c: Fix includes.
1125         * regcache.c: Fix includes.
1126         * python/py-block.c: Fix includes.
1127         * printcmd.c: Fix includes.
1128         * or1k-tdep.c: Fix includes.
1129         * mi/mi-main.c: Fix includes.
1130         * m32r-tdep.c: Fix includes.
1131         * csky-tdep.c: Fix includes.
1132         * compile/compile-cplus-types.c: Fix includes.
1133         * cli/cli-interp.c: Fix includes.
1134
1135 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1136
1137         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1138         for padding.
1139
1140 2019-01-16  Tom Tromey  <tom@tromey.com>
1141
1142         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1143         earlier.
1144         (struct objfile) <msymbols_range>: Move from top level.
1145         <msymbols>: New method.
1146         (class objfile_msymbols): Remove.
1147         * symtab.c (default_collect_symbol_completion_matches_break_on):
1148         Update.
1149         * symmisc.c (dump_msymbols): Update.
1150         * stabsread.c (scan_file_globals): Update.
1151         * objc-lang.c (info_selectors_command, info_classes_command)
1152         (find_methods): Update.
1153         * minsyms.c (find_solib_trampoline_target): Update.
1154         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1155         * coffread.c (coff_symfile_read): Update.
1156         * ada-lang.c (ada_lookup_simple_minsym)
1157         (ada_collect_symbol_completion_matches): Update.
1158
1159 2019-01-16  Tom Tromey  <tom@tromey.com>
1160
1161         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1162         type.  Remove no-argument constructor.
1163         <iterator::operator++>: Simplify.
1164         <begin>: Update.
1165         <end>: Use minimal_symbol_count.
1166
1167 2019-01-16  Tom Tromey  <tom@tromey.com>
1168
1169         * objfiles.h (struct objfile) <psymtabs>: New method.
1170         (class objfile_psymtabs): Remove.
1171         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1172         typedef.
1173         <range>: New method.
1174         (require_partial_symbols): Change return type.
1175         * psymtab.c (require_partial_symbols)
1176         (psym_expand_symtabs_matching): Update.
1177         * mdebugread.c (parse_partial_symbols): Update.
1178         * dbxread.c (dbx_end_psymtab): Update.
1179
1180 2019-01-15  Tom Tromey  <tom@tromey.com>
1181
1182         * symtab.c (lookup_objfile_from_block)
1183         (lookup_symbol_in_objfile_symtabs)
1184         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1185         (find_line_symtab, info_sources_command)
1186         (default_collect_symbol_completion_matches_break_on)
1187         (make_source_files_completion_list): Update.
1188         * symmisc.c (print_objfile_statistics, dump_objfile)
1189         (maintenance_print_symbols, maintenance_info_symtabs)
1190         (maintenance_check_symtabs, maintenance_info_line_tables):
1191         Update.
1192         * source.c (select_source_symtab)
1193         (forget_cached_source_info_for_objfile): Update.
1194         * objfiles.h (class objfile_compunits): Remove.
1195         (struct objfile) <compunits_range>: New typedef.
1196         (compunits): New method.
1197         * objfiles.c (objfile_relocate1): Update.
1198         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1199         * maint.c (count_symtabs_and_blocks): Update.
1200         * linespec.c (iterate_over_all_matching_symtabs): Update.
1201         * cp-support.c (add_symbol_overload_list_qualified): Update.
1202         * coffread.c (coff_symtab_read): Update.
1203         * ada-lang.c (add_nonlocal_symbols)
1204         (ada_collect_symbol_completion_matches)
1205         (ada_add_global_exceptions): Update.
1206
1207 2019-01-15  Tom Tromey  <tom@tromey.com>
1208
1209         * progspace.h (program_space) <objfiles_safe_range>: New
1210         typedef.
1211         <objfiles_safe>: New method.
1212         * objfiles.h (class all_objfiles_safe): Remove.
1213         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1214         * jit.c (jit_inferior_exit_hook): Update.
1215
1216 2019-01-17  Tom Tromey  <tom@tromey.com>
1217
1218         * progspace.h (program_space) <objfiles_range>: New typedef.
1219         <objfiles>: New method.
1220         <objfiles_head>: Rename from objfiles.
1221         (object_files): Update.
1222         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1223         * guile/scm-pretty-print.c
1224         (ppscm_find_pretty_printer_from_objfiles): Update.
1225         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1226         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1227         Update.
1228         * python/py-progspace.c (pspy_get_objfiles): Update.
1229         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1230         Update.
1231         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1232         (objfpy_lookup_objfile_by_build_id): Update.
1233         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1234         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1235         Update.
1236         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1237         (expand_symtab_containing_pc, lookup_objfile_from_block)
1238         (lookup_static_symbol, basic_lookup_transparent_type)
1239         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1240         (find_line_symtab, info_sources_command)
1241         (default_collect_symbol_completion_matches_break_on)
1242         (make_source_files_completion_list, find_main_name): Update.
1243         * symmisc.c (print_symbol_bcache_statistics)
1244         (print_objfile_statistics, maintenance_print_symbols)
1245         (maintenance_print_msymbols, maintenance_print_objfiles)
1246         (maintenance_info_symtabs, maintenance_check_symtabs)
1247         (maintenance_expand_symtabs, maintenance_info_line_tables):
1248         Update.
1249         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1250         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1251         (map_overlay_command, unmap_overlay_command)
1252         (simple_overlay_update, expand_symtabs_matching)
1253         (map_symbol_filenames): Update.
1254         * symfile-debug.c (set_debug_symfile): Update.
1255         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1256         Update.
1257         * source.c (select_source_symtab, forget_cached_source_info):
1258         Update.
1259         * solib.c (solib_read_symbols): Update.
1260         * solib-spu.c (append_ocl_sos): Update.
1261         * psymtab.c (maintenance_print_psymbols)
1262         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1263         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1264         * printcmd.c (info_symbol_command): Update.
1265         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1266         Update.
1267         * objfiles.h (class all_objfiles): Remove.
1268         * objfiles.c (have_partial_symbols, have_full_symbols)
1269         (have_minimal_symbols, qsort_cmp, update_section_map)
1270         (shared_objfile_contains_address_p)
1271         (default_iterate_over_objfiles_in_search_order): Update.
1272         * objc-lang.c (info_selectors_command, info_classes_command)
1273         (find_methods): Update.
1274         * minsyms.c (find_solib_trampoline_target): Update.
1275         * maint.c (maintenance_info_sections)
1276         (maintenance_translate_address, count_symtabs_and_blocks):
1277         Update.
1278         * main.c (captured_main_1): Update.
1279         * linux-thread-db.c (try_thread_db_load_from_pdir)
1280         (has_libpthread): Update.
1281         * linespec.c (iterate_over_all_matching_symtabs)
1282         (search_minsyms_for_name): Update.
1283         * jit.c (jit_find_objf_with_entry_addr): Update.
1284         * hppa-tdep.c (find_unwind_entry)
1285         (hppa_lookup_stub_minimal_symbol): Update.
1286         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1287         Update.
1288         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1289         (elf_gnu_ifunc_resolve_by_got): Update.
1290         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1291         * dwarf-index-write.c (save_gdb_index_command): Update.
1292         * cp-support.c (add_symbol_overload_list_qualified): Update.
1293         * breakpoint.c (create_overlay_event_breakpoint)
1294         (create_longjmp_master_breakpoint)
1295         (create_std_terminate_master_breakpoint)
1296         (create_exception_master_breakpoint): Update.
1297         * blockframe.c (find_pc_partial_function): Update.
1298         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1299         (ada_collect_symbol_completion_matches)
1300         (ada_add_global_exceptions): Update.
1301
1302 2019-01-17  Tom Tromey  <tom@tromey.com>
1303
1304         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1305         declare VEC.
1306         (solib_target_parse_libraries): Change return type.
1307         (library_list_start_segment, library_list_start_section)
1308         (library_list_end_library, library_list_start_library); Update.
1309         (solib_target_free_library_list): Remove.
1310         (solib_target_parse_libraries): Remove cleanup.  Change return
1311         type.
1312         (solib_target_current_sos): Update.
1313
1314 2019-01-17  Tom Tromey  <tromey@bapiya>
1315
1316         * valprint.c: Replace "the the" with "the".
1317         * symtab.c: Replace "the the" with "the".
1318         * solib.c: Replace "the the" with "the".
1319         * solib-dsbt.c: Replace "the the" with "the".
1320         * linespec.c: Replace "the the" with "the".
1321         * dwarf2loc.h: Replace "the the" with "the".
1322         * amd64-windows-tdep.c: Replace "the the" with "the".
1323         * aarch64-tdep.c: Replace "the the" with "the".
1324
1325 2019-01-16  Keith Seitz  <keiths@redhat.com>
1326
1327         PR gdb/23773
1328         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1329         <builder>: Rename to ..
1330         <m_builder>: ... this and make private.
1331         (dwarf2_cu::get_builder): New method.  Change all users of
1332         `builder' to use this method.
1333         (dwarf2_start_symtab): Move to ...
1334         (dwarf2_cu::start_symtab): ... here.  Update all callers
1335         (setup_type_unit_groups): Move to ...
1336         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1337         callers.
1338         (dwarf2_cu::reset_builder): New method.
1339         (process_full_compunit, process_full_type_unit): Use
1340         dwarf2_cu::reset_builder.
1341         (follow_die_offset): Record the ancestor CU if it is different
1342         from the followed DIE's CU.
1343         (follow_die_sig_1): Likewise.
1344
1345 2019-01-15  Tom Tromey  <tom@tromey.com>
1346
1347         * remote.c (class remote_state) <buf>: Now a char_vector.
1348         <buf_size>: Remove.
1349         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1350         parameter.
1351         (remote_target::getpkt_or_notif_sane_1)
1352         (remote_target::getpkt_sane)
1353         (remote_target::getpkt_or_notif_sane): Likewise.
1354         (class remote_target) <putpkt>: New overload.
1355         (remote_target::read_frame): Change type of "buf_p".  Remove
1356         sizeof_p parameter.
1357         (packet_ok): New overload.
1358         (packet_check_result): New overload.
1359         Update all uses.
1360
1361 2019-01-14  Tom Tromey  <tom@tromey.com>
1362
1363         * remote-notif.c (handle_notification, remote_notif_ack)
1364         (remote_notif_parse): Make "buf" const.
1365         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1366         const.
1367         (remote_notif_parse, remote_notif_ack, handle_notification):
1368         Likewise.
1369         * remote.c (remote_notif_stop_parse): Make "buf" const.
1370         (remote_target::remote_parse_stop_reply): Make "buf" const.
1371         (remote_notif_stop_ack): Make "buf" const.
1372
1373 2019-01-14  Tom Tromey  <tom@tromey.com>
1374
1375         * remote.c (remote_console_output): Make parameter const.
1376
1377 2019-01-14  Tom Tromey  <tom@tromey.com>
1378
1379         * target-debug.h (target_debug_print_signals): Constify.
1380         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1381         * procfs.c (procfs_target::pass_signals): Update.
1382         * linux-nat.c (linux_nat_target::pass_signals): Update.
1383         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1384         * target-delegates.c: Rebuild.
1385         * remote.c (remote_target::program_signals): Update.
1386         (remote_target::pass_signals): Update.
1387         * target.c (target_pass_signals): Constify argument.
1388         (target_program_signals): Likewise.
1389         * target.h (struct target_ops) <pass_signals, program_signals>:
1390         Constify argument.
1391         (target_pass_signals, target_program_signals): Constify argument.
1392
1393 2019-01-14  Tom Tromey  <tom@tromey.com>
1394
1395         PR tui/28819:
1396         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1397
1398 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1399
1400         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1401         field.
1402         * rs6000-tdep.c: Include reggroups.h.
1403         (IS_V_ALIAS_PSEUDOREG): Define.
1404         (rs6000_register_name): Return names for the "vX" aliases.
1405         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1406         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1407         aliases.  Call default_register_reggroup_p for all other
1408         pseudo-registers.
1409         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1410         New functions.
1411         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1412         Handle "vX" aliases.
1413         (v_alias_pseudo_register_collect): New function.
1414         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1415         (rs6000_gdbarch_init): Initialize "vX" aliases as
1416         pseudo-registers.  Restore registration of
1417         rs6000_pseudo_register_reggroup_p with
1418         set_tdesc_pseudo_register_reggroup_p.
1419
1420 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1421
1422         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1423         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1424         set_gdbarch_num_pseudo_regs.
1425
1426 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1427
1428         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1429         Remove arg prefixname, add do_set and do_show.
1430         Add member functions set_list and show_list.
1431         * cli/cli-style.c (class cli_style_option): Update accordingly.
1432         (style_set_list): Move to file scope.
1433         (style_show_list): Likewise.
1434         (set_style): Call help_list.
1435         (show_style): Call cmd_show_list.
1436         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1437         Update to use the new macro.
1438
1439 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1440
1441         * ada-lang.c (_initialize_ada_language): Expand the help text
1442         for the "catch exception" command.
1443
1444 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1445
1446         * symtab.c (matching_obj_sections): Initialize obj,
1447         declare it closer to its usage.
1448
1449 2019-01-10  Tom Tromey  <tom@tromey.com>
1450
1451         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1452         (basic_inf_threads_range): Remove.
1453         (inf_threads_range, inf_non_exited_threads_range)
1454         (safe_inf_threads_range): Use next_adapter.
1455
1456 2019-01-10  Keith Seitz  <keiths@redhat.com>
1457
1458         PR gdb/23712
1459         PR symtab/23010
1460         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1461         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1462
1463 2019-01-10  Keith Seitz  <keiths@redhat.com>
1464
1465         PR gdb/23712
1466         PR symtab/23010
1467         * dictionary.c (pending_to_vector): Remove.
1468         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1469         Remove _1 suffix, replacing functions of the same name.  Update
1470         all callers.
1471         (dict_create_hashed, dict_create_hashed_expandable)
1472         (dict_create_linear, dict_create_linear_expandable, dict_free)
1473         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1474         Make functions static.
1475
1476 2019-01-10  Keith Seitz  <keiths@redhat.com>
1477
1478         PR gdb/23712
1479         PR symtab/23010
1480         * dictionary.h (struct dictionary): Replace declaration with
1481         multidictionary.
1482         (dict_create_hashed, dict_create_hashed_expandable)
1483         (dict_create_linear, dict_create_linear_expandable)
1484         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1485         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1486         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1487         taking multidictionary argument.
1488         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1489         * block.h (struct block) <dict>: Change to multidictionary
1490         and rename `multidict'.
1491         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1492         symmisc.c: Update all dictionary references to multidictionary.
1493
1494 2019-01-10  Keith Seitz  <keiths@redhat.com>
1495
1496         PR gdb/23712
1497         PR symtab/23010
1498         * dictionary.c: Include unordered_map.
1499         (pending_to_vector): New function.
1500         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1501         Rewrite the non-"_1" functions to take vector instead
1502         of linked list.
1503         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1504         "new" _1 versions of the same name.
1505         (multidictionary): Define.
1506         (std::hash<enum language): New definition.
1507         (collate_pending_symbols_by_language, mdict_create_hashed)
1508         (mdict_create_hashed_expandable, mdict_create_linear)
1509         (mdict_create_linear_expandable, mdict_free)
1510         (find_language_dictionary, create_new_language_dictionary)
1511         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1512         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1513         (mdict_size, mdict_empty): New functions.
1514         * dictionary.h (mdict_iterator): Define.
1515
1516 2019-01-10  Pedro Alves  <palves@redhat.com>
1517
1518         * breakpoint.c (read_uploaded_action)
1519         (create_tracepoint_from_upload): Adjust to use
1520         gdb::unique_xmalloc_ptr.
1521         * ctf.c (ctf_write_uploaded_tp):
1522         (SET_ARRAY_FIELD): Use emplace_back.
1523         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1524         * tracefile-tfile.c (tfile_write_uploaded_tp):
1525         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1526         gdb::unique_xmalloc_ptr.
1527         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1528         at_string, cond_string, cmd_strings>: Replace char pointers
1529         with gdb::unique_xmalloc_ptr.
1530
1531 2019-01-10  Pedro Alves  <palves@redhat.com>
1532
1533         * solib-target.c (library_list_start_library): Don't xstrdup name.
1534
1535 2019-01-10  Pedro Alves  <palves@redhat.com>
1536
1537         * mdebugread.c (parse_partial_symbols): Use
1538         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1539
1540 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1541
1542         * linux-fork.c (scoped_switch_fork_info)
1543         <~scoped_switch_fork_info>: Fix incorrect variable name.
1544
1545 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1546
1547         * linux-fork.c (scoped_switch_fork_info)
1548         <scoped_switch_fork_info>: Make explicit.
1549         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1550
1551 2019-01-10  Tom Tromey  <tom@tromey.com>
1552
1553         * objfiles.h (objfile::reset_psymtabs): Update.
1554         * objfiles.c (objfile::objfile): Update.
1555         * psymtab.h (psymtab_storage::obstack): Update.
1556         (psymtab_storage::m_obstack): Use gdb::optional.
1557         (class psymtab_storage): Update comment.  Remove objfile
1558         parameter.
1559         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1560
1561 2019-01-10  Tom Tromey  <tom@tromey.com>
1562
1563         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1564         <free_psymtabs>: Now private.
1565         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1566         (allocate_psymtab): Use new method.
1567
1568 2019-01-10  Tom Tromey  <tom@tromey.com>
1569
1570         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1571         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1572         * mdebugread.c (parse_partial_symbols): Use
1573         allocate_dependencies.
1574         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1575         allocate_dependencies.
1576         (process_psymtab_comp_unit_reader)
1577         (build_type_psymtab_dependencies): Likewise.
1578         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1579
1580 2019-01-10  Tom Tromey  <tom@tromey.com>
1581
1582         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1583         PSYMBOL_SET_LANGUAGE.
1584         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1585
1586 2019-01-10  Tom Tromey  <tom@tromey.com>
1587
1588         * psymtab.h (psymtab_storage::obstack): New method.
1589         <m_obstack>: Rename from obstack; now private.
1590         * psymtab.c (psymtab_storage): Update.
1591         * dwarf2read.c (create_addrmap_from_index)
1592         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1593         Update.
1594
1595 2019-01-10  Tom Tromey  <tom@tromey.com>
1596
1597         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1598         * objfiles.h (objfile::reset_psymtabs): New method.
1599
1600 2019-01-10  Tom Tromey  <tom@tromey.com>
1601
1602         * symmisc.c (print_symbol_bcache_statistics): Update.
1603         (print_objfile_statistics): Update.
1604         * symfile.c (reread_symbols): Update.
1605         * psymtab.h (class psymtab_storage): New.
1606         * psymtab.c (psymtab_storage): New constructor.
1607         (~psymtab_storage): New destructor.
1608         (require_partial_symbols): Update.
1609         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1610         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1611         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1612         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1613         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1614         (start_psymtab_common, end_psymtab_common)
1615         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1616         (allocate_psymtab): Update.
1617         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1618         Update.
1619         (dump_psymtab_addrmap, maintenance_print_psymbols)
1620         (maintenance_check_psymtabs): Update.
1621         (class objfile_psymtabs): Move to objfiles.h.
1622         * psympriv.h (discard_psymtab): Now inline.
1623         (psymtab_discarder::psymtab_discarder): Update.
1624         (psymtab_discarder::~psymtab_discarder): Update.
1625         (ALL_OBJFILE_PSYMTABS): Rewrite.
1626         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1627         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1628         Remove fields.
1629         <partial_symtabs>: New field.
1630         (class objfile_psymtabs): Move from psymtab.h.  Update.
1631         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1632         psymbol_cache.
1633         (objfile::~objfile): Don't destroy psymbol_cache.
1634         * mdebugread.c (parse_partial_symbols): Update.
1635         * dwarf2read.c (create_addrmap_from_index)
1636         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1637         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1638         (add_partial_subprogram, dwarf2_ranges_read): Update.
1639         * dwarf-index-write.c (write_address_map)
1640         (write_one_signatured_type, recursively_write_psymbols)
1641         (class debug_names, class debug_names, write_psymtabs_to_index):
1642         Update.
1643
1644 2019-01-10  Tom Tromey  <tom@tromey.com>
1645
1646         * symtab.h (SYMBOL_SET_NAMES): Update.
1647         (symbol_set_names): Update.
1648         (MSYMBOL_SET_NAMES): Update.
1649         * symtab.c (symbol_set_names): Change argument to be an
1650         objfile_per_bfd_storage.
1651         * psymtab.c (add_psymbol_to_bcache): Update.
1652         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1653
1654 2019-01-10  Tom Tromey  <tom@tromey.com>
1655
1656         * symtab.c (create_demangled_names_hash): Change argument to be an
1657         objfile_per_bfd_storage.
1658         (symbol_set_names): Update.
1659
1660 2019-01-10  Tom Tromey  <tom@tromey.com>
1661
1662         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1663         init_psymbol_list.
1664         * psymtab.c (init_psymbol_list): Do nothing if already called.
1665         * psympriv.h (init_psymbol_list): Add comment.
1666         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1667         init_psymbol_list.
1668         * dbxread.c (dbx_symfile_read): Unconditionally call
1669         init_psymbol_list.
1670
1671 2019-01-10  Tom Tromey  <tom@tromey.com>
1672
1673         * xcoffread.c (scan_xcoff_symtab): Update.
1674         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1675         "where".
1676         * mdebugread.c (parse_partial_symbols)
1677         (handle_psymbol_enumerators): Update.
1678         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1679         * dbxread.c (read_dbx_symtab): Update.
1680         * psympriv.h (psymbol_placement): New enum.
1681         (add_psymbol_to_list): Update.
1682
1683 2019-01-10  Tom Tromey  <tom@tromey.com>
1684
1685         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1686         static_psymbols parameters.
1687         (scan_xcoff_symtab): Update.
1688         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1689         static_psymbols parameters.
1690         * psympriv.h (start_psymtab_common): Update.
1691         * mdebugread.c (parse_partial_symbols): Update.
1692         * dwarf2read.c (create_partial_symtab): Update.
1693         * dbxread.c (read_dbx_symtab): Update.
1694         (start_psymtab): Remove global_psymbols and static_psymbols
1695         parameters.
1696
1697 2019-01-10  Tom Tromey  <tom@tromey.com>
1698
1699         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1700         * psymtab.c (allocate_psymtab): Add comment.
1701         * psympriv.h (allocate_psymtab): Add comment.
1702         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1703         initializations.
1704         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1705
1706 2019-01-10  Tom Tromey  <tom@tromey.com>
1707
1708         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1709         Don't declare.
1710         * mipsread.c: Include mdebugread.h.
1711         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1712         Declare.
1713         * elfread.c: Include mdebugread.h.
1714
1715 2019-01-09  Tom Tromey  <tom@tromey.com>
1716
1717         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1718         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1719         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1720         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1721         (psym_lookup_symbol, psym_find_last_source_symtab)
1722         (psym_forget_cached_source_info, psym_print_stats)
1723         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1724         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1725         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1726         (psym_find_compunit_symtab_by_address)
1727         (maintenance_print_psymbols, maintenance_info_psymtabs)
1728         (maintenance_check_psymtabs): Use ranged for.
1729         * psymtab.h (class objfile_psymtabs): New.
1730         (require_partial_symbols): Return objfile_psymtabs.
1731         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1732
1733 2019-01-09  Tom Tromey  <tom@tromey.com>
1734
1735         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1736         (find_pc_mapped_section, list_overlays_command)
1737         (map_overlay_command, unmap_overlay_command)
1738         (simple_overlay_update): Use all_objfiles.
1739         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1740         * printcmd.c (info_symbol_command): Use all_objfiles.
1741         * objfiles.h (ALL_OBJSECTIONS): Remove.
1742         * maint.c (maintenance_translate_address): Use all_objfiles.
1743         * gcore.c (gcore_create_callback): Use all_objfiles.
1744         (objfile_find_memory_regions): Likewise.
1745
1746 2019-01-09  Tom Tromey  <tom@tromey.com>
1747
1748         * symtab.c (find_line_symtab, info_sources_command)
1749         (make_source_files_completion_list): Use objfile_compunits.
1750         * source.c (select_source_symtab): Use objfile_compunits.
1751         * objfiles.h (struct objfile): Update comment.
1752         (ALL_OBJFILES): Remove.
1753         (ALL_FILETABS): Remove.
1754         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1755         objfile_compunits.
1756
1757 2019-01-09  Tom Tromey  <tom@tromey.com>
1758
1759         * symmisc.c (print_objfile_statistics, dump_objfile)
1760         (maintenance_print_symbols): Use compunit_filetabs.
1761         * source.c (forget_cached_source_info_for_objfile): Use
1762         compunit_filetabs.
1763         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1764         (ALL_FILETABS): Use compunit_filetabs.
1765         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1766         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1767
1768 2019-01-09  Tom Tromey  <tom@tromey.com>
1769
1770         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1771         (compunit_filetabs): New.
1772         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1773         compunit_filetabs.
1774         (info_sources_command, make_source_files_completion_list): Remove
1775         declaration.
1776         * symmisc.c (print_objfile_statistics, dump_objfile)
1777         (maintenance_print_symbols): Remove declaration.
1778         (maintenance_info_symtabs): Use compunit_filetabs.
1779         (maintenance_info_line_tables): Likewise.
1780         * source.c (select_source_symtab): Change local variable name.
1781         (forget_cached_source_info_for_objfile): Remove declaration.
1782         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1783         * objfiles.c (objfile_relocate1): Remove declaration.
1784         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1785         declaration.
1786         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1787         * coffread.c (coff_symtab_read): Remove declaration.
1788         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1789         compunit_filetabs.
1790
1791 2019-01-09  Tom Tromey  <tom@tromey.com>
1792
1793         * symtab.c (lookup_objfile_from_block)
1794         (find_pc_sect_compunit_symtab, search_symbols)
1795         (default_collect_symbol_completion_matches_break_on): Use
1796         objfile_compunits.
1797         * objfiles.h (ALL_COMPUNITS): Remove.
1798         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1799         * cp-support.c (add_symbol_overload_list_qualified): Use
1800         objfile_compunits.
1801         * ada-lang.c (ada_collect_symbol_completion_matches)
1802         (ada_add_global_exceptions): Use objfile_compunits.
1803
1804 2019-01-09  Tom Tromey  <tom@tromey.com>
1805
1806         * source.c (select_source_symtab)
1807         (forget_cached_source_info_for_objfile): Remove declaration.
1808         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1809         declaration.
1810         * maint.c (count_symtabs_and_blocks): Remove declaration.
1811         * cp-support.c (add_symbol_overload_list_qualified): Remove
1812         declaration.
1813         * coffread.c (coff_symtab_read): Remove declaration.
1814         * symtab.c (lookup_symbol_in_objfile_symtabs)
1815         (basic_lookup_transparent_type_1): Use objfile_compunits.
1816         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1817         (info_sources_command, search_symbols)
1818         (default_collect_symbol_completion_matches_break_on)
1819         (make_source_files_completion_list): Remove declaration.
1820         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1821         (ada_collect_symbol_completion_matches)
1822         (ada_add_global_exceptions): Remove declaration.
1823         * linespec.c (iterate_over_all_matching_symtabs): Use
1824         objfile_compunits.
1825         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1826         (class objfile_compunits): New.
1827         (ALL_COMPUNITS): Use objfile_compunits.
1828         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1829         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1830         objfile_compunits.
1831         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1832
1833 2019-01-09  Tom Tromey  <tom@tromey.com>
1834
1835         * symtab.c (search_symbols)
1836         (default_collect_symbol_completion_matches_break_on): Use
1837         objfile_msymbols.
1838         * ada-lang.c (ada_lookup_simple_minsym)
1839         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1840         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1841         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1842         objfile_msymbols.
1843         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1844         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1845         * objc-lang.c (find_methods): Use objfile_msymbols.
1846         (info_selectors_command, info_classes_command): Likewise.
1847         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1848         * objfiles.h (class objfile_msymbols): New.
1849         (ALL_OBJFILE_MSYMBOLS): Remove.
1850         (ALL_MSYMBOLS): Remove.
1851
1852 2019-01-09  Tom Tromey  <tom@tromey.com>
1853
1854         * common/next-iterator.h (next_adapter): Add Iterator template
1855         parameter.
1856         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1857         (class all_objfiles_safe): New.
1858         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1859         * objfiles.c (put_objfile_before): Update comment.
1860         (add_separate_debug_objfile): Likewise.
1861         (free_all_objfiles): Use all_objfiles_safe.
1862         (objfile_purge_solibs): Likewise.
1863
1864 2019-01-09  Tom Tromey  <tom@tromey.com>
1865
1866         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1867         (expand_symtab_containing_pc, lookup_static_symbol)
1868         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1869         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1870         all_objfiles.
1871         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1872         * breakpoint.c (create_overlay_event_breakpoint)
1873         (create_longjmp_master_breakpoint)
1874         (create_std_terminate_master_breakpoint)
1875         (create_exception_master_breakpoint): Use all_objfiles.
1876         * linux-thread-db.c (try_thread_db_load_from_pdir)
1877         (has_libpthread): Use all_objfiles.
1878         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1879         * linespec.c (iterate_over_all_matching_symtabs)
1880         (search_minsyms_for_name): Use all_objfiles.
1881         * maint.c (maintenance_info_sections): Use all_objfiles.
1882         * main.c (captured_main_1): Use all_objfiles.
1883         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1884         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1885         * guile/scm-pretty-print.c
1886         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1887         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1888         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1889         (maintenance_print_msymbols): Use all_objfiles.
1890         * source.c (select_source_symtab): Use all_objfiles.
1891         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1892         * symfile.c (remove_symbol_file_command)
1893         (expand_symtabs_matching, map_symbol_filenames): Use
1894         all_objfiles.
1895         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1896         all_objfiles.
1897         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1898         * objc-lang.c (find_methods): Use all_objfiles.
1899         * objfiles.c (have_partial_symbols, have_full_symbols)
1900         (have_minimal_symbols, qsort_cmp)
1901         (default_iterate_over_objfiles_in_search_order): Use
1902         all_objfiles.
1903         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1904         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1905         (maintenance_check_psymtabs): Use all_objfiles.
1906         (ALL_PSYMTABS): Remove.
1907         * compile/compile-object-run.c (do_module_cleanup): Use
1908         all_objfiles.
1909         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1910         * cp-support.c (add_symbol_overload_list_qualified): Use
1911         all_objfiles.
1912         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1913         Use all_objfiles.
1914         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1915         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1916         all_objfiles.
1917         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1918         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1919         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1920         Uses all_objfiles.
1921         * solib.c (solib_read_symbols): Use all_objfiles
1922
1923 2019-01-09  Tom Tromey  <tom@tromey.com>
1924
1925         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1926         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1927         all_objfiles.
1928         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1929         * symmisc.c (print_symbol_bcache_statistics)
1930         (print_objfile_statistics, maintenance_print_objfiles)
1931         (maintenance_info_symtabs, maintenance_check_symtabs)
1932         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1933         all_objfiles.
1934         * source.c (forget_cached_source_info): Use all_objfiles.
1935         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1936         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1937         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1938         * objfiles.c (update_section_map): Use all_objfiles.
1939         (shared_objfile_contains_address_p): Likewise.
1940         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1941         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1942
1943 2019-01-09  Tom Tromey  <tom@tromey.com>
1944
1945         * common/next-iterator.h: New file.
1946         * objfiles.h (class all_objfiles): New.
1947         (struct objfile_iterator): New.
1948
1949 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1950
1951         * NEWS: Move the description of the changed "frame", "select-frame",
1952          and "info frame" commands to the Changed commands section.
1953
1954 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1955
1956         * gdbtypes.c (check_stub_method_group): Remove handling of old
1957         mangling schemes.
1958         * linespec.c (find_methods): Likewise.
1959         * stabsread.c (read_member_functions): Likewise.
1960         * valops.c (search_struct_method): Likewise.
1961         (value_struct_elt_for_reference): Likewise.
1962         * NEWS: Mention this change.
1963
1964 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1965
1966         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1967         print_source_lines.
1968         * source.c (print_source_lines_base): Update line number check.
1969         (print_source_lines): New function.
1970         (source_lines_range::source_lines_range): New function.
1971         * source.h (class source_lines_range): New class.
1972         (print_source_lines): New declaration.
1973
1974 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1975
1976         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1977
1978 2019-01-08  Tom Tromey  <tom@tromey.com>
1979             Simon Marchi  <simon.marchi@ericsson.com>
1980
1981         PR gdb/24060
1982         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1983         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1984         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1985         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1986         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1987         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1988
1989 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1990
1991         * source.c (select_source_symtab): Move header comment to
1992         declaration in source.h.
1993         (forget_cached_source_info_for_objfile): Likewise.
1994         (forget_cached_source_info): Likewise.
1995         (identify_source_line): Likewise.
1996         * source.h (identify_source_line): Move declaration from symtab.h
1997         and add comment from source.c
1998         (print_source_lines): Likewise.
1999         (forget_cached_source_info_for_objfile): Likewise.
2000         (forget_cached_source_info): Likewise.
2001         (select_source_symtab): Likewise.
2002         (enum print_source_lines_flag): Move definition from symtab.h.
2003         * symtab.h (identify_source_line): Move declaration to source.h.
2004         (print_source_lines): Likewise.
2005         (forget_cached_source_info_for_objfile): Likewise.
2006         (forget_cached_source_info): Likewise.
2007         (select_source_symtab): Likewise.
2008         (enum print_source_lines_flag): Move definition to source.h.
2009         * tui/tui-hooks.c: Add 'source.h' include.
2010
2011 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2012
2013         * source.c (print_source_lines_base): Handle requests to print
2014         reverse line number sequences, and guard against empty lines
2015         string.
2016
2017 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2018
2019         * source.c (print_source_lines_base): Fix skip of '\r' if next
2020         character is '\n'.
2021
2022 2019-01-06  Tom Tromey  <tom@tromey.com>
2023
2024         * c-exp.y (struct c_parse_state) <macro_original_text,
2025         expansion_obstack>: New member.
2026         (macro_original_text, expansion_obstack): Remove globals.
2027         (scan_macro_expansion, scanning_macro_expansion)
2028         (finished_macro_expansion): Update.
2029         (scan_macro_cleanup): Remove.
2030         (yylex, c_parse): Update.
2031
2032 2019-01-06  Tom Tromey  <tom@tromey.com>
2033
2034         * c-exp.y (struct c_parse_state) <strings>: New member.
2035         (operator_stoken): Update.
2036
2037 2019-01-06  Tom Tromey  <tom@tromey.com>
2038
2039         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2040         (union type_stack_elt) <typelist_val>: Now a pointer to
2041         std::vector.
2042         (type_stack_cleanup): Don't declare.
2043         (push_typelist): Update.
2044         * parse.c (pop_typelist): Return a std::vector.
2045         (push_typelist): Take a std::vector.
2046         (follow_types): Update.  Do not free args.
2047         (type_stack_cleanup): Remove.
2048         * c-exp.y (struct c_parse_state): New.
2049         (cpstate): New global.
2050         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2051         (nonempty_typelist): Update.
2052         (func_mod): Create a new vector.
2053         (c_parse): Create a c_parse_state.
2054         (check_parameter_typelist): Do not delete params.
2055         (function_method): Update.  Do not delete type_list.
2056
2057 2019-01-06  Tom Tromey  <tom@tromey.com>
2058
2059         PR gdb/28155:
2060         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2061         check_typedef.
2062         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2063         (print_return_value): Likewise.
2064
2065 2019-01-05  Tom Tromey  <tom@tromey.com>
2066
2067         * contrib/cleanup_check.py: Remove.
2068         * contrib/gcc-with-excheck: Remove.
2069         * contrib/exsummary.py: Remove.
2070         * contrib/excheck.py: Remove.
2071
2072 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2073
2074         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2075         NULL. Initialize tpprev to NULL instead of assigning it
2076         to NULL on the next statement.
2077         * windows-nat.c (windows_delete_thread): Remove check for
2078         main_thread_id before printing thread exit notifications.
2079         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2080         Remove thread ID check against main_thread_id.
2081         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2082         windows_delete_thread.
2083         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2084
2085 2019-01-04  Tom Tromey  <tom@tromey.com>
2086
2087         * compile/compile.c (_initialize_compile): Use upper case for
2088         metasyntactic variables.
2089         * symmisc.c (_initialize_symmisc): Use upper case for
2090         metasyntactic variables.
2091         * psymtab.c (_initialize_psymtab): Use upper case for
2092         metasyntactic variables.
2093         * demangle.c (demangle_command): Use upper case for metasyntactic
2094         variables.
2095         (_initialize_demangler): Likewise.
2096         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2097         variables.
2098
2099 2019-01-03  Tom Tromey  <tom@tromey.com>
2100
2101         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2102
2103 2019-01-03  Tom Tromey  <tom@tromey.com>
2104
2105         * python/py-symtab.c (salpy_str): Update.
2106         (struct salpy_sal_object) <symtab>: Now a PyObject.
2107         (salpy_dealloc): Update.
2108         (del_objfile_sal): Use gdbpy_ref.
2109
2110 2019-01-03  Tom Tromey  <tom@tromey.com>
2111
2112         * python/py-type.c (convert_field): Use new_reference.  Return
2113         gdbpy_ref.
2114         (make_fielditem): Return gdbpy_ref.
2115         (typy_fields): Update.
2116         (typy_getitem): Update.
2117         (field_name): Return gdbpy_ref.  Use new_reference.
2118         (typy_iterator_iternext): Update.
2119
2120 2019-01-03  Tom Tromey  <tom@tromey.com>
2121
2122         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2123
2124 2019-01-03  Tom Tromey  <tom@tromey.com>
2125
2126         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2127         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2128         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2129         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2130         (pspy_set_type_printers): Likewise.
2131         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2132         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2133         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2134         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2135         (objfpy_set_type_printers): Likewise.
2136
2137 2019-01-03  Tom Tromey  <tom@tromey.com>
2138
2139         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2140         (gdbpy_print_stack): Use gdbpy_err_fetch.
2141         * python/python-internal.h (class gdbpy_err_fetch): New class.
2142         (class gdbpy_enter) <m_error_type, m_error_value,
2143         m_error_traceback>: Remove.
2144         <m_error>: New member.
2145         (gdbpy_exception_to_string): Don't declare.
2146         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2147         * python/py-value.c (convert_value_from_python): Use
2148         gdbpy_err_fetch.
2149         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2150         gdbpy_exception_to_string.
2151         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2152         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2153         gdbpy_err_fetch.
2154
2155 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2156
2157         * linux-nat.c (delete_lwp_cleanup): Delete.
2158         (struct lwp_deleter): New struct.
2159         (lwp_info_up): New typedef.
2160         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2161         lwp_info_up.
2162
2163 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2164
2165         * linux-fork.c (class scoped_switch_fork_info): New class.
2166         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2167
2168 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2169
2170         * valops.c (find_overload_match): Remove use of null_cleanup, and
2171         calls to do_cleanups.
2172
2173 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2174
2175         * compile/compile-cplus-types.c
2176         (compile_cplus_instance::decl_name): Handle changes to
2177         cp_func_name.
2178         * cp-support.c (cp_func_name): Update header comment, update
2179         return type.
2180         * cp-support.h (cp_func_name): Update return type in declaration.
2181         * valops.c (find_overload_match): Move temp_func local to top
2182         level of function and change its type.  Use temp_func to hold and
2183         delete temporary string obtained from cp_func_name.
2184
2185 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2186
2187         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2188         gdb::char_vector, remove cleanup, and update uses of `msg`.
2189
2190 2019-01-03  Jim Wilson  <jimw@sifive.com>
2191
2192         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2193
2194 2019-01-02  Tom Tromey  <tom@tromey.com>
2195
2196         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2197         (tdesc_parse_xml): Remove cleanups.
2198         * target-descriptions.h (make_cleanup_free_target_description):
2199         Don't declare.
2200         (target_desc_deleter): New struct.
2201         (target_desc_up): New typedef.
2202         * target-descriptions.c (target_desc_deleter::operator()): Rename
2203         from free_target_description.
2204         (make_cleanup_free_target_description): Remove.
2205
2206 2019-01-02  Tom Tromey  <tom@tromey.com>
2207
2208         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2209         constructor, destructor.
2210         (linespec_parser): Remove typedef.
2211         (~linespec_parser): Rename from linespec_parser_delete.
2212         (linespec_lex_to_end, linespec_complete_label)
2213         (linespec_complete): Update.
2214         (decode_line_full): Remove cleanups.
2215         (decode_line_1): Update.
2216
2217 2019-01-02  Tom Tromey  <tom@tromey.com>
2218
2219         * python/python-internal.h (inferior_to_inferior_object): Change
2220         return type.
2221         * python/py-exitedevent.c (create_exited_event_object): Update.
2222         * python/py-inferior.c (inferior_to_inferior_object): Return
2223         gdbpy_ref.
2224         (python_new_inferior, python_inferior_deleted)
2225         (thread_to_thread_object, delete_thread_object)
2226         (build_inferior_list, gdbpy_selected_inferior): Update.
2227         * python/py-infthread.c (create_thread_object): Update.  Also fail
2228         if inferior_to_inferior_object fails.
2229
2230 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2231
2232         * inferior.h (class inferior) <displaced_step_state>: New field.
2233         * infrun.h (struct displaced_step_state): Move here from
2234         infrun.c.  Initialize fields, add constructor.
2235         <inf>: Remove field.
2236         <reset>: New method.
2237         * infrun.c (struct displaced_step_inferior_state): Move to
2238         infrun.h.
2239         (displaced_step_inferior_states): Remove.
2240         (get_displaced_stepping_state): Adust.
2241         (displaced_step_in_progress_any_inferior): Adjust.
2242         (displaced_step_in_progress_thread): Adjust.
2243         (displaced_step_in_progress): Adjust.
2244         (add_displaced_stepping_state): Remove.
2245         (get_displaced_step_closure_by_addr): Adjust.
2246         (remove_displaced_stepping_state): Remove.
2247         (infrun_inferior_exit): Call displaced_step_state.reset.
2248         (use_displaced_stepping): Don't check for NULL.
2249         (displaced_step_prepare_throw): Call
2250         get_displaced_stepping_state.
2251         (displaced_step_fixup): Don't check for NULL.
2252         (prepare_for_detach): Don't check for NULL.
2253
2254 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2255
2256         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2257          in case of call that did not complete.
2258
2259 2019-01-02  Andrey Utkin  <autkin@undo.io>
2260
2261         * symfile.c (find_separate_debug_file): Fix search of debug files for
2262         remote debuggee.
2263
2264 2019-01-02  Tom Tromey  <tom@tromey.com>
2265
2266         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2267         indentation.
2268         * python/py-frame.c (frapy_older): Remove cast.
2269         (frapy_newer): Likewise.
2270         * python/py-breakpoint.c (local_setattro): Remove cast.
2271         * python/py-arch.c (archpy_name): Remove local variable.
2272         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2273
2274 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2275
2276         * unittests/basic_string_view/element_access/char/empty.cc:
2277         Fix year range in copyright header.
2278
2279 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2280
2281         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2282         Delete.
2283         <operator==>: Update with for removed field.
2284         <hash>: Likewise.
2285         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2286         <isa_features>: ...this.
2287         <abi_features>: New field.
2288         (riscv_isa_flen): Update comment.
2289         (riscv_abi_xlen): New declaration.
2290         (riscv_abi_flen): New declaration.
2291         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2292         isa_features.
2293         (riscv_abi_xlen): New function.
2294         (riscv_isa_flen): Update to get answer from isa_features.
2295         (riscv_abi_flen): New function.
2296         (riscv_has_fp_abi): Update to get answer from abi_features.
2297         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2298         xlen and flen.
2299         (riscv_call_info) <xlen, flen>: Update comment.
2300         (riscv_call_arg_struct): Remove invalid assertions
2301         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2302         is removed.
2303         (riscv_gdbarch_init): Gather isa features and abi features
2304         separately, ensure both match on the gdbarch when reusing an old
2305         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2306         a target with 64-bit float hardware.
2307
2308 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2309
2310         * source.c (search_command_helper): Stop reverse search
2311         when line 1 has been searched.
2312
2313 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2314
2315         * record-full.c (record_full_base_target::close): Rewrite
2316         record_full_core_buf_list free logic.
2317
2318 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2319
2320         * break-catch-syscall.c (print_one_catch_syscall): xfree
2321         the last text.
2322
2323 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2324
2325         * top.c (print_gdb_version): Update Copyright year in version
2326         message.
2327
2328 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2329
2330         Update copyright year range in all GDB files.
2331
2332 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2333
2334         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2335
2336 For older changes see ChangeLog-2018.
2337 \f
2338 Local Variables:
2339 mode: change-log
2340 left-margin: 8
2341 fill-column: 74
2342 version-control: never
2343 coding: utf-8
2344 End:
2345