gdb/ChangeLog

   1 2018-05-25  Tom Tromey  <tom@tromey.com>
   2
   3         * cli/cli-interp.c (safe_execute_command): Use scoped_restore.
   4         * interps.c (interp_exec): Use scoped_restore.
   5
   6 2018-05-25  Tom Tromey  <tom@tromey.com>
   7
   8         * remote.c (remote_target::remote_file_get): Use
   9         gdb::byte_vector.
  10         (remote_target::remote_file_put): Likewise.
  11
  12 2018-05-25  Tom Tromey  <tom@tromey.com>
  13
  14         * coff-pe-read.c (struct read_pe_section_data) <section_name>: Now
  15         a std::string.
  16         (get_pe_section_index, add_pe_exported_sym): Update.
  17         (read_pe_exported_syms): Use gdb::def_vector.
  18
  19 2018-05-25  Tom Tromey  <tom@tromey.com>
  20
  21         * frame.c (remove_prev_frame): Remove.
  22         (get_prev_frame_if_no_cycle): Use TRY/CATCH.
  23
  24 2018-05-25  Maciej W. Rozycki  <macro@mips.com>
  25
  26         * mips-linux-tdep.h (mips_supply_fpregset, mips_fill_fpregset):
  27         Remove prototypes.
  28         * mips-linux-nat.c (supply_fpregset): Always call
  29         `mips64_supply_fpregset' rather than `mips_supply_fpregset'.
  30         (fill_fpregset): Always call `mips64_fill_fpregset' rather than
  31         `mips_fill_fpregset'.
  32         * mips-linux-tdep.c (mips_supply_fpregset)
  33         (mips_supply_fpregset_wrapper, mips_fill_fpregset)
  34         (mips_fill_fpregset_wrapper): Remove functions.
  35         (mips64_supply_fpregset, mips64_fill_fpregset): Update comments.
  36         (mips_linux_fpregset): Remove variable.
  37         (mips_linux_iterate_over_regset_sections): Use
  38         `mips64_linux_fpregset' in place of `mips_linux_fpregset'.
  39         (mips_linux_o32_sigframe_init): Remove comment.
  40
  41 2018-05-25  Pedro Alves  <palves@redhat.com>
  42
  43         * remote.c (struct vCont_action_support, MAXTHREADLISTRESULTS)
  44         (struct readahead_cache, struct packet_reg, struct
  45         remote_arch_state, class remote_state): Move higher up in the
  46         file.
  47         (remote_target::m_remote_state): Now an object instead of a pointer.
  48         (remote_target::get_remote_state): Adjust.
  49
  50 2018-05-24  Andrew Burgess  <andrew.burgess@embecosm.com>
  51
  52         * stack.c (select_and_print_frame): Delete.
  53         (struct function_bounds): Move struct within function.
  54         (func_command): Most content moved into new function
  55         find_frame_for_function, use new function, print result, add
  56         function comment.
  57         (find_frame_for_function): New function, now returns a result.
  58
  59 2018-05-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  60
  61         * stack.c (iterate_over_block_arg_vars): Fix comment.
  62         (print_frame_arg_vars): Pass stream in cb_data, not gdb_stdout.
  63
  64 2018-05-24  Andrew Burgess  <andrew.burgess@embecosm.com>
  65
  66         PR gdb/23203
  67         * frame.c
  68         (scoped_restore_selected_frame::scoped_restore_selected_frame):
  69         Define.
  70         (scoped_restore_selected_frame::~scoped_restore_selected_frame):
  71         Define.
  72         * frame.h (class scoped_restore_selected_frame): New class.
  73         * stack.c (print_frame_local_vars): Remove catching and rethrowing
  74         of any exception, use scoped_restore_selected_frame to restore the
  75         frame instead.
  76
  77 2018-05-24  Pedro Alves  <palves@redhat.com>
  78
  79         * darwin-nat.h (darwin_nat_target::create_inferior): Mark with
  80         override.
  81
  82 2018-05-23  Tom Tromey  <tom@tromey.com>
  83
  84         * complaints.c (struct complaints): Remove.
  85         (symfile_complaint_book): Remove.
  86         (series): New global.
  87         (complaint_internal): Update.
  88         (clear_complaints): Update.
  89
  90 2018-05-23  Tom Tromey  <tom@tromey.com>
  91
  92         * complaints.c (counters): New global.
  93         (struct complain): Remove.
  94         (struct complaints) <root>: Remove.
  95         (complaint_sentinel): Remove.
  96         (symfile_complaint_book): Update.
  97         (find_complaint) Remove.
  98         (complaint_internal, clear_complaints): Update.
  99
 100 2018-05-23  Tom Tromey  <tom@tromey.com>
 101
 102         * complaints.c (struct complain) <file, line>: Remove.
 103         (find_complaint): Remove file, line parameters.
 104         (complaint_internal): Update.
 105
 106 2018-05-23  Tom Tromey  <tom@tromey.com>
 107
 108         * complaints.c (vcomplaint): Remove.
 109         (complaint_internal) Merge in contents of vcomplaint.
 110
 111 2018-05-23  Tom Tromey  <tom@tromey.com>
 112
 113         * complaints.c (struct complaints) <explanation>: Remove.
 114         (symfile_explanations): Remove.
 115         (symfile_complaint_book): Update.
 116         (vcomplaint): Update.
 117         (struct explanation): Remove.
 118
 119 2018-05-23  Tom Tromey  <tom@tromey.com>
 120
 121         * complaints.c (symfile_complaints): Remove.
 122         (complaint_internal): Remove "complaints" parameter.
 123         (clear_complaints, vcomplaint): Remove "c" parameter.
 124         (get_complaints): Remove.
 125         * dwarf2read.c (dwarf2_statement_list_fits_in_line_number_section_complaint)
 126         (dwarf2_debug_line_missing_file_complaint)
 127         (dwarf2_debug_line_missing_end_sequence_complaint)
 128         (dwarf2_complex_location_expr_complaint)
 129         (dwarf2_const_value_length_mismatch_complaint)
 130         (dwarf2_section_buffer_overflow_complaint)
 131         (dwarf2_macro_malformed_definition_complaint)
 132         (dwarf2_invalid_attrib_class_complaint)
 133         (create_addrmap_from_index, dw2_symtab_iter_next)
 134         (dw2_expand_marked_cus)
 135         (dw2_debug_names_iterator::find_vec_in_debug_names)
 136         (dw2_debug_names_iterator::next, dw2_debug_names_iterator::next)
 137         (create_debug_type_hash_table, init_cutu_and_read_dies)
 138         (partial_die_parent_scope, add_partial_enumeration)
 139         (skip_one_die, fixup_go_packaging, quirk_rust_enum, process_die)
 140         (dwarf2_compute_name, dwarf2_physname, read_namespace_alias)
 141         (read_import_statement, read_file_scope, create_dwo_cu_reader)
 142         (create_cus_hash_table, create_dwp_hash_table)
 143         (inherit_abstract_dies, read_func_scope, read_call_site_scope)
 144         (dwarf2_rnglists_process, dwarf2_ranges_process)
 145         (dwarf2_add_type_defn, dwarf2_attach_fields_to_type)
 146         (dwarf2_add_member_fn, get_alignment, maybe_set_alignment)
 147         (handle_struct_member_die, process_structure_scope)
 148         (read_array_type, read_common_block, read_module_type)
 149         (read_tag_pointer_type, read_typedef, read_base_type)
 150         (read_subrange_type, load_partial_dies, partial_die_info::read)
 151         (partial_die_info::read, partial_die_info::read)
 152         (partial_die_info::read, read_checked_initial_length_and_offset)
 153         (dwarf2_string_attr, read_formatted_entries)
 154         (dwarf_decode_line_header)
 155         (lnp_state_machine::check_line_address, dwarf_decode_lines_1)
 156         (new_symbol, dwarf2_const_value_attr, lookup_die_type)
 157         (read_type_die_1, determine_prefix, dwarf2_get_ref_die_offset)
 158         (dwarf2_get_attr_constant_value, dwarf2_fetch_constant_bytes)
 159         (get_signatured_type, get_DW_AT_signature_type)
 160         (decode_locdesc, file_file_name, consume_improper_spaces)
 161         (skip_form_bytes, skip_unknown_opcode, dwarf_parse_macro_header)
 162         (dwarf_decode_macro_bytes, dwarf_decode_macros)
 163         (dwarf2_symbol_mark_computed, set_die_type)
 164         (read_attribute_value): Update.
 165         * stap-probe.c (handle_stap_probe, get_stap_base_address):
 166         Update.
 167         * dbxread.c (unknown_symtype_complaint)
 168         (lbrac_mismatch_complaint, repeated_header_complaint)
 169         (set_namestring, function_outside_compilation_unit_complaint)
 170         (read_dbx_symtab, process_one_symbol): Update.
 171         * gdbtypes.c (stub_noname_complaint): Update.
 172         * windows-nat.c (handle_unload_dll): Update.
 173         * coffread.c (coff_symtab_read, enter_linenos, decode_type)
 174         (decode_base_type): Update.
 175         * xcoffread.c (bf_notfound_complaint, ef_complaint)
 176         (eb_complaint, record_include_begin, record_include_end)
 177         (enter_line_range, xcoff_next_symbol_text, read_xcoff_symtab)
 178         (process_xcoff_symbol, read_symbol)
 179         (function_outside_compilation_unit_complaint)
 180         (scan_xcoff_symtab): Update.
 181         * machoread.c (macho_symtab_read, macho_add_oso_symfile): Update.
 182         * buildsym.c (finish_block_internal, make_blockvector)
 183         (end_symtab_get_static_block, augment_type_symtab): Update.
 184         * dtrace-probe.c (dtrace_process_dof)
 185         (dtrace_static_probe_ops::get_probes): Update.
 186         * complaints.h (struct complaint): Don't declare.
 187         (symfile_complaints): Remove.
 188         (complaint_internal): Remove "complaints" parameter.
 189         (complaint): Likewise.
 190         (clear_complaints): Likewise.
 191         * symfile.c (syms_from_objfile_1, finish_new_objfile)
 192         (reread_symbols): Update.
 193         * dwarf2-frame.c (dwarf2_restore_rule, execute_cfa_program)
 194         (dwarf2_frame_cache, decode_frame_entry): Update.
 195         * dwarf2loc.c (dwarf_reg_to_regnum): Update.
 196         * objc-lang.c (lookup_objc_class, lookup_child_selector)
 197         (info_selectors_command): Update.
 198         * macrotab.c (macro_include, check_for_redefinition)
 199         (macro_undef): Update.
 200         * objfiles.c (filter_overlapping_sections): Update.
 201         * stabsread.c (invalid_cpp_abbrev_complaint)
 202         (reg_value_complaint, stabs_general_complaint, dbx_lookup_type)
 203         (define_symbol, error_type, read_type, rs6000_builtin_type)
 204         (stabs_method_name_from_physname, read_member_functions)
 205         (read_cpp_abbrev, read_baseclasses, read_tilde_fields)
 206         (attach_fields_to_type, complain_about_struct_wipeout)
 207         (read_range_type, read_args, common_block_start)
 208         (common_block_end, cleanup_undefined_types_1, scan_file_globals):
 209         Update.
 210         * mdebugread.c (index_complaint, unknown_ext_complaint)
 211         (basic_type_complaint, bad_tag_guess_complaint)
 212         (bad_rfd_entry_complaint, unexpected_type_code_complaint)
 213         (reg_value_complaint, parse_symbol, parse_type, upgrade_type)
 214         (parse_procedure, parse_lines)
 215         (function_outside_compilation_unit_complaint)
 216         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref)
 217         (bad_tag_guess_complaint, reg_value_complaint): Update.
 218         * cp-support.c (demangled_name_complaint): Update.
 219         * macroscope.c (sal_macro_scope): Update.
 220         * dwarf-index-write.c (class debug_names): Update.
 221
 222 2018-05-23  Tom Tromey  <tom@tromey.com>
 223
 224         * complaints.c (clear_complaints): Remove "noisy" parameter.
 225         * complaints.h (clear_complaints): Update.
 226         * symfile.c (syms_from_objfile_1, finish_new_objfile)
 227         (reread_symbols): Update.
 228
 229 2018-05-23  Tom Tromey  <tom@tromey.com>
 230
 231         * complaints.c (enum complaint_series): Remove FIRST_MESSAGE,
 232         SUBSEQUENT_MESSAGE.
 233         (vcomplaint, clear_complaints): Update.
 234         (symfile_explanations): Remove some messages.
 235
 236 2018-05-23  Tom Tromey  <tom@tromey.com>
 237
 238         * complaints.c (internal_complaint): Remove.
 239         * complaints.h (internal_complaint): Remove.
 240
 241 2018-05-22  Maciej W. Rozycki  <macro@mips.com>
 242
 243         * i387-tdep.c (i387_collect_xsave): Make `i' unsigned.
 244
 245 2018-05-22  Pedro Alves  <palves@redhat.com>
 246
 247         * remote-fileio.c (remote_fileio_reply, remote_fileio_ioerror)
 248         (remote_fileio_badfd, remote_fileio_return_errno)
 249         (remote_fileio_return_success, remote_fileio_func_open)
 250         (remote_fileio_func_open, remote_fileio_func_close)
 251         (remote_fileio_func_read, remote_fileio_func_write)
 252         (remote_fileio_func_lseek, remote_fileio_func_rename)
 253         (remote_fileio_func_unlink, remote_fileio_func_stat)
 254         (remote_fileio_func_fstat, remote_fileio_func_gettimeofday)
 255         (remote_fileio_func_isatty, remote_fileio_func_system): Add
 256         remote_target parameter.
 257         (remote_fio_func_map) <func>: Add remote_target parameter.
 258         (do_remote_fileio_request, remote_fileio_request):
 259         * remote-fileio.h (remote_fileio_request):
 260         * remote-notif.c (remote_notif_ack, remote_notif_parse, ): Add
 261         remote_target parameter.
 262         (remote_notif_process, handle_notification): Adjust to pass down
 263         the remote.
 264         (remote_notif_state_allocate): Add remote_target parameter.  Save
 265         it.
 266         * remote-notif.h (struct remote_target): Forward declare.
 267         (struct notif_client) <parse, ack, can_get_pending_events>: Add
 268         remote_target parameter.
 269         (struct remote_notif_state) <remote>: New field.
 270         (remote_notif_ack, remote_notif_parse): Add remote_target
 271         parameter.
 272         (remote_notif_state_allocate, remote_notif_state_allocate): Add
 273         remote_target parameter.
 274         * remote.c (OPAQUETHREADBYTES, threadref, gdb_ext_thread_info)
 275         (threads_listing_context, rmt_thread_action, protocol_feature)
 276         (packet_reg, stop_reply, stop_reply_p, enum packet_support)
 277         (packet_result, struct threads_listing_context, remote_state):
 278         Move definitions and declarations higher up.
 279         (remote_target) <~remote_target>: Declare.
 280         (remote_download_command_source, remote_file_put, remote_file_get)
 281         (remote_file_delete, remote_hostio_pread, remote_hostio_pwrite)
 282         (remote_hostio_pread_vFile, remote_hostio_send_command)
 283         (remote_hostio_set_filesystem, remote_hostio_open)
 284         (remote_hostio_close, remote_hostio_unlink, remote_state)
 285         (get_remote_state, get_remote_packet_size, get_memory_packet_size)
 286         (get_memory_write_packet_size, get_memory_read_packet_size)
 287         (append_pending_thread_resumptions, remote_detach_1)
 288         (append_resumption, remote_resume_with_vcont)
 289         (add_current_inferior_and_thread, wait_ns, wait_as)
 290         (process_stop_reply, remote_notice_new_inferior)
 291         (process_initial_stop_replies, remote_add_thread)
 292         (btrace_sync_conf, remote_btrace_maybe_reopen)
 293         (remove_new_fork_children, kill_new_fork_children)
 294         (discard_pending_stop_replies, stop_reply_queue_length)
 295         (check_pending_events_prevent_wildcard_vcont)
 296         (discard_pending_stop_replies_in_queue, stop_reply)
 297         (remote_notif_remove_queued_reply, stop_reply *queued_stop_reply)
 298         (peek_stop_reply, remote_parse_stop_reply, remote_stop_ns)
 299         (remote_interrupt_as, remote_interrupt_ns)
 300         (remote_get_noisy_reply, remote_query_attached)
 301         (remote_add_inferior, remote_current_thread, get_current_thread)
 302         (set_thread, set_general_thread, set_continue_thread)
 303         (set_general_process, write_ptid)
 304         (remote_unpack_thread_info_response, remote_get_threadinfo)
 305         (parse_threadlist_response, remote_get_threadlist)
 306         (remote_threadlist_iterator, remote_get_threads_with_ql)
 307         (remote_get_threads_with_qxfer)
 308         (remote_get_threads_with_qthreadinfo, extended_remote_restart)
 309         (get_offsets, remote_check_symbols, remote_supported_packet)
 310         (remote_query_supported, remote_packet_size)
 311         (remote_serial_quit_handler, remote_detach_pid)
 312         (remote_vcont_probe, remote_resume_with_hc)
 313         (send_interrupt_sequence, interrupt_query)
 314         (remote_notif_get_pending_events, fetch_register_using_p)
 315         (send_g_packet, process_g_packet, fetch_registers_using_g)
 316         (store_register_using_P, store_registers_using_G)
 317         (set_remote_traceframe, check_binary_download)
 318         (remote_write_bytes_aux, remote_write_bytes, remote_read_bytes_1)
 319         (remote_xfer_live_readonly_partial, remote_read_bytes)
 320         (remote_send_printf, remote_flash_write, readchar)
 321         (remote_serial_write, putpkt, putpkt_binary, skip_frame)
 322         (read_frame, getpkt, getpkt_or_notif_sane_1, getpkt_sane)
 323         (getpkt_or_notif_sane, remote_vkill, remote_kill_k)
 324         (extended_remote_disable_randomization, extended_remote_run)
 325         (send_environment_packet, extended_remote_environment_support)
 326         (extended_remote_set_inferior_cwd, remote_write_qxfer)
 327         (remote_read_qxfer, push_stop_reply, vcont_r_supported)
 328         (packet_command): Now methods of ...
 329         (remote_target): ... this class.
 330         (m_remote_state) <remote_target>: New field.
 331         (struct remote_state) <stop_reply_queue,
 332         remote_async_inferior_event_token, wait_forever_enabled_p>: New
 333         fields.
 334         (remote_state::remote_state): Allocate stop_reply_queue.
 335         (remote_state): Delete global.
 336         (get_remote_state_raw): Delete.
 337         (remote_target::get_remote_state): Allocate m_remote_state on
 338         demand.
 339         (get_current_remote_target): New.
 340         (remote_ops, extended_remote_ops): Delete.
 341         (wait_forever_enabled_p, remote_async_inferior_event_token):
 342         Delete, moved to struct remote_state.
 343         (remote_target::close): Delete self.  Destruction bits split to
 344         ...
 345         (remote_target::~remote_target): ... this.
 346         (show_memory_packet_size): Adjust to use
 347         get_current_remote_target.
 348         (struct protocol_feature) <func>: Add remote_target parameter.
 349         All callers adjusted.
 350         (curr_quit_handler_target): New.
 351         (remote_serial_quit_handler): Reimplement.
 352         (remote_target::open_1): Adjust to use get_current_remote_target.
 353         Heap-allocate remote_target/extended_remote_target instances.
 354         (vcont_builder::vcont_builder): Add remote_target parameter, and
 355         save it in m_remote.  All callers adjusted.
 356         (vcont_builder::m_remote): New field.
 357         (vcont_builder::restart, vcont_builder::flush)
 358         (vcont_builder::push_action): Use it.
 359         (remote_target::commit_resume): Use it.
 360         (struct queue_iter_param) <remote>: New field.
 361         (remote_target::remove_new_fork_children): Fill in 'remote' field.
 362         (check_pending_event_prevents_wildcard_vcont_callback_data): New.
 363         (check_pending_event_prevents_wildcard_vcont_callback)
 364         (remote_target::check_pending_events_prevent_wildcard_vcont)
 365         (remote_target::discard_pending_stop_replies)
 366         (remote_target::discard_pending_stop_replies_in_queue)
 367         (remote_target::remote_notif_remove_queued_reply): Fill in
 368         'remote' field.
 369         (remote_notif_get_pending_events): New.
 370         (remote_target::readchar, remote_target::remote_serial_write):
 371         Save/restore curr_quit_handler_target.
 372         (putpkt): New.
 373         (kill_new_fork_children): Fill in 'remote' field.
 374         (packet_command): Use get_current_remote_target, defer to
 375         remote_target method of same name.
 376         (scoped_remote_fd::scoped_remote_fd): Add 'remote_target'
 377         parameter, and save it in m_remote.  All callers adjusted.
 378         (scoped_remote_fd::release): Use m_remote.
 379         (scoped_remote_fd::m_remote): New field.
 380         (remote_file_put, remote_file_get, remote_file_delete): Use
 381         get_current_remote_target, defer to remote_target method of same
 382         name.
 383         (remote_btrace_reset): Add remote_state paremeter.  Update all
 384         callers.
 385         (remote_async_inferior_event_handler). Pass down 'data'.
 386         (remote_new_objfile): Use get_current_remote_target.
 387         (remote_target::vcont_r_supported): New.
 388         (set_range_stepping): Use get_current_remote_target and
 389         remote_target::vcont_r_supported.
 390         (_initialize_remote): Don't allocate 'remote_state' and
 391         'stop_reply_queue' globals.
 392         * remote.h (struct remote_target): Forward declare.
 393         (getpkt, putpkt, remote_notif_get_pending_events): Add
 394         'remote_target' parameter.
 395
 396 2018-05-22  Pedro Alves  <palves@redhat.com>
 397
 398         * remote.c (vcont_builder): Now a class.  Make all data members
 399         private.
 400         (vcont_builder) <vcont_builder, restart, flush, push_action>:
 401         Declare methods.
 402         (vcont_builder_restart): Rename to ...
 403         (vcont_builder::restart): ... this.
 404         (vcont_builder_flush): Rename to ...
 405         (vcont_builder::flush): ... this.
 406         (vcont_builder_push_action): Rename to ...
 407         (vcont_builder::push_action): ... this.
 408         (remote_target::commit_resume): Adjust.
 409
 410 2018-05-22  Pedro Alves  <palves@redhat.com>
 411
 412         * remote.c (DEFAULT_MAX_MEMORY_PACKET_SIZE): Rename to ...
 413         (DEFAULT_MAX_MEMORY_PACKET_SIZE_FIXED): ... this.
 414         (get_fixed_memory_packet_size): New.
 415         (get_memory_packet_size): Use it.
 416         (set_memory_packet_size): Don't override the config size with
 417         DEFAULT_MAX_MEMORY_PACKET_SIZE.
 418         (show_memory_packet_size): Use get_fixed_memory_packet_size.
 419         Don't refer to get_memory_packet_size if not connected to a remote
 420         target.  Show "(default)" if configured size is 0.
 421
 422 2018-05-22  Pedro Alves  <palves@redhat.com>
 423
 424         * remote.c (remote_target::mourn_inferior): Move
 425         discard_pending_stop_replies call here from ...
 426         (_initialize_remote): ... here.
 427
 428 2018-05-22  Pedro Alves  <palves@redhat.com>
 429
 430         * remote.c (compare_section_command): Remove set_general_process
 431         call.
 432
 433 2018-05-22  Pedro Alves  <palves@redhat.com>
 434
 435         * remote.c (struct packet_reg, struct remote_arch_state):
 436         Move higher up in the file.
 437         (remote_state) <m_arch_states>: Store remote_arch_state values
 438         instead of remote_arch_state pointers.
 439         (remote_state::get_remote_arch_state): Adjust.
 440
 441 2018-05-22  Pedro Alves  <palves@redhat.com>
 442
 443         * remote.c: Include <unordered_map>.
 444         (remote_state): Now a class.
 445         (remote_state) <get_remote_arch_state>: Declare method.
 446         <get_remote_arch_state>: New field.
 447         (remote_arch_state) <remote_arch_state>: Declare ctor.
 448         <regs>: Now a unique_ptr.
 449         (remote_gdbarch_data_handle): Delete.
 450         (get_remote_arch_state): Delete.
 451         (remote_state::get_remote_arch_state): New.
 452         (get_remote_state): Adjust to call remote_state's
 453         get_remote_arch_state method.
 454         (init_remote_state): Delete, bits factored out to ...
 455         (remote_arch_state::remote_arch_state): ... this new method.
 456         (get_remote_packet_size, get_memory_packet_size)
 457         (process_g_packet, remote_target::fetch_registers)
 458         (remote_target::prepare_to_store, store_registers_using_G)
 459         (remote_target::store_registers, remote_target::get_trace_status):
 460         Adjust to call remote_state's method.
 461         (_initialize_remote): Remove reference to
 462         remote_gdbarch_data_handle.
 463
 464 2018-05-22  Pedro Alves  <palves@redhat.com>
 465
 466         * remote.c (struct readahead_cache) <invalidate, invalidate_fd,
 467         pread>: New method declarations.
 468         (remote_target::open_1): Adjust.
 469         (readahead_cache_invalidate): Rename to ...
 470         (readahead_cache::invalidate): ... this, and adjust to be a class
 471         method.
 472         (readahead_cache_invalidate_fd): Rename to ...
 473         (readahead_cache::invalidate_fd): ... this, and adjust to be a
 474         class method.
 475         (remote_hostio_pwrite): Adjust.
 476         (remote_hostio_pread_from_cache): Rename to ...
 477         (readahead_cache::pread): ... this, and adjust to be a class
 478         method.
 479         (remote_hostio_close): Adjust.
 480
 481 2018-05-22  Pedro Alves  <palves@redhat.com>
 482
 483         * remote.c (remote_hostio_close_cleanup): Delete.
 484         (class scoped_remote_fd): New.
 485         (remote_file_put, remote_file_get): Use it.
 486
 487 2018-05-22  Pedro Alves  <palves@redhat.com>
 488
 489         (struct vCont_action_support): Use bool and initialize all fields.
 490         (struct readahead_cache): Initialize all fields.
 491         (remote_state): Use bool and initialize all fields.
 492         (remote_state::remote_state, remote_state::~remote_state): New.
 493         (new_remote_state): Delete.
 494         (_initialize_remote): Use new to allocate remote_state.
 495
 496 2018-05-22  Pedro Alves  <palves@redhat.com>
 497             張俊芝  <zjz@zjz.name>
 498
 499         PR gdb/22973
 500         * c-exp.y: Include "c-support.h".
 501         (parse_number, c_parse_escape, lex_one_token): Use TOLOWER instead
 502         of tolower.  Use c_ident_is_alpha to scan names.
 503         * c-lang.c: Include "c-support.h".
 504         (convert_ucn, convert_octal, convert_hex, convert_escape): Use
 505         ISXDIGIT instead of isxdigit and ISDIGIT instead of isdigit.
 506         * c-support.h: New file, with bits factored out from ...
 507         * cp-name-parser.y: ... this file.
 508         Include "c-support.h".
 509         (cp_ident_is_alpha, cp_ident_is_alnum): Deleted, moved to
 510         c-support.h and renamed.
 511         (symbol_end, yylex): Adjust.
 512
 513 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
 514
 515         * arch/ppc-linux-common.c (ppc_linux_has_isa205): Change the
 516         parameter type to CORE_ADDR.
 517         * arch/ppc-linux-common.h (ppc_linux_has_isa205): Change the
 518         parameter type in declaration to CORE_ADDR.
 519         * ppc-linux-tdep.c (ppc_linux_core_read_description): Call
 520         target_auxv_search to get AT_HWCAP and use the result to get the
 521         target description.
 522         * ppc-linux-nat.c (ppc_linux_get_hwcap): Change the return type
 523         to CORE_ADDR. Remove the cast of the return value to unsigned
 524         long. Fix error predicate of target_auxv_search.
 525         (ppc_linux_nat_target::read_description): Change the type of the
 526         hwcap variable to CORE_ADDR.
 527
 528 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
 529
 530         * rs6000-tdep.c (rs6000_gdbarch_init): Assign 1 to have_dfp only
 531         if the size of fpscr is larger than 32 bits.
 532
 533 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
 534
 535         * ppc-linux-tdep.c (ppc_linux_vsxregset): New function.
 536         (ppc32_linux_vsxregmap): New global.
 537         (ppc32_linux_vsxregset): Initialize with ppc32_linux_vsxregmap,
 538         regcache_supply_regset, and regcache_collect_regset.
 539         * ppc-linux-tdep.h (ppc_linux_vsxregset): Declare.
 540         * ppc-linux-nat.c (supply_vsxregset, fill_vsxregset): Remove.
 541         (fetch_vsx_register, store_vsx_register): Remove.
 542         (fetch_vsx_registers): Add regno parameter. Get regset using
 543         ppc_linux_vsxregset. Use regset to supply registers.
 544         (store_vsx_registers): Add regno parameter. Get regset using
 545         ppc_linux_vsxregset. Use regset to collect registers.
 546         (fetch_register): Call fetch_vsx_registers instead of
 547         fetch_vsx_register.
 548         (store_register): Call store_vsx_registers instead of
 549         store_vsx_register.
 550         (fetch_ppc_registers): Call fetch_vsx_registers with -1 for the
 551         new regno parameter.
 552         (store_ppc_registers): Call store_vsx_registers with -1 for the
 553         new regno parameter.
 554         * rs6000-tdep.c (ppc_vsx_support_p, ppc_supply_vsxreget)
 555         (ppc_collect_vsxregset): Remove.
 556
 557 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
 558
 559         * ppc-tdep.h (struct ppc_reg_offsets): Remove vector register
 560         offset fields.
 561         * ppc-fbsd-tdep.c (ppc32_fbsd_reg_offsets): Remove initializers
 562         for vector register offset fields.
 563         (ppc64_fbsd_reg_offsets): Likewise.
 564         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment
 565         to vector register offset fields.
 566         * ppc-obsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment
 567         to vector register offset fields.
 568         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Remove assignment to
 569         vector register offset fields.
 570         * rs6000-aix-tdep.c (rs6000_aix32_reg_offsets): Remove
 571         initializers for vector register offset fields.
 572         (rs6000_aix64_reg_offsets): Likewise.
 573         * rs6000-tdep.c (ppc_vrreg_offset): Remove.
 574         (ppc_supply_vrregset): Remove.
 575         (ppc_collect_vrregset): Remove.
 576         * ppc-linux-tdep.c (ppc_linux_collect_vrregset): New function.
 577         (ppc_linux_vrregset) : New function.
 578         (ppc32_le_linux_vrregmap, ppc32_be_linux_vrregmap)
 579         (ppc32_le_linux_vrregset, ppc32_be_linux_vrregset): New globals.
 580         (ppc32_linux_vrregset): Remove.
 581         (ppc_linux_iterate_over_regset_sections): Call ppc_linux_vrregset
 582         and use result instead of ppc32_linux_vrregset.
 583         (ppc32_linux_reg_offsets): Remove initializers for vector register
 584         offset fields.
 585         (ppc64_linux_reg_offsets): Likewise.
 586         * ppc-linux-tdep.h (ppc_linux_vrregset): New declaration.
 587         * ppc-linux-nat.c: Include regset.h.
 588         (gdb_vrregset_t): Adjust comment to account for little-endian
 589         mode.
 590         (supply_vrregset, fill_vrregset): Remove.
 591         (fetch_altivec_register, store_altivec_register): Remove.
 592         (fetch_altivec_registers): Add regno parameter. Get regset using
 593         ppc_linux_vrregset. Use regset to supply registers.
 594         (store_altivec_registers): Add regno parameter. Get regset using
 595         ppc_linux_vrregset. Use regset to collect registers.
 596         (fetch_register): Call fetch_altivec_registers instead of
 597         fetch_altivec_register.
 598         (store_register): Call store_altivec_registers instead of
 599         store_altivec_register.
 600         (fetch_ppc_registers): Call fetch_altivec_registers with -1 for
 601         the new regno parameter.
 602         (store_ppc_registers): Call store_altivec_registers with -1 for
 603         the new regno parameter.
 604
 605 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
 606
 607         * arch/ppc-linux-common.h (PPC_LINUX_SIZEOF_VRREGSET)
 608         (PPC_LINUX_SIZEOF_VSXREGSET): Define.
 609         * ppc-linux-nat.c (SIZEOF_VSXREGS, SIZEOF_VRREGS): Remove.
 610         (gdb_vrregset_t): Change array type size to
 611         PPC_LINUX_SIZEOF_VRREGSET.
 612         (gdb_vsxregset_t): Change array type size to
 613         PPC_LINUX_SIZEOF_VSXREGSET.
 614         * ppc-linux-tdep.c (ppc_linux_iterate_over_regset_sections):
 615         Change integer literals to PPC_LINUX_SIZEOF_VRREGSET and
 616         PPC_LINUX_SIZEOF_VSXREGSET.
 617
 618 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
 619
 620         * configure.nat <linux powerpc>: Add ppc-linux.o to NATDEPFILES.
 621         * ppc-linux-nat.c (ppc_linux_target_wordsize): Move to
 622         nat/ppc-linux.c.
 623         (ppc_linux_nat_target::auxv_parse): Get thread id tid. Call
 624         ppc_linux_target_wordsize with tid.
 625         (ppc_linux_nat_target::read_description): Call ppc_linux_target
 626         wordsize with tid.
 627         * nat/ppc-linux.c: Include nat/gdb_ptrace.h.
 628         (ppc64_64bit_inferior_p): Add static and inline specifiers.
 629         (ppc_linux_target_wordsize): Move here from ppc-linux-nat.c. Add
 630         tid parameter. Remove static specifier.
 631         * nat/ppc-linux.h (ppc64_64bit_inferior_p): Remove declaration.
 632         (ppc_linux_target_wordsize): New declaration.
 633
 634 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
 635
 636         * arch/ppc-linux-common.c: New file.
 637         * arch/ppc-linux-common.h: New file.
 638         * arch/ppc-linux-tdesc.h: New file.
 639         * configure.tgt (powerpc*-*-linux*): Add arch/ppc-linux-common.o.
 640         * Makefile.in (ALL_TARGET_OBS): Add arch/ppc-linux-common.o.
 641         (HFILES_NO_SRCDIR): Add arch/ppc-linux-common.h and
 642         arch/ppc-linux-tdesc.h.
 643         * ppc-linux-nat.c: Include arch/ppc-linux-common.h and
 644         arch/ppc-linux-tdesc.h.
 645         (ppc_linux_nat_target::read_description): Remove target
 646         description matching code. Fill a ppc_linux_features struct and
 647         call ppc_linux_match_description with it. Move comment about ISA
 648         2.05 to ppc-linux-common.c.
 649         * ppc-linux-tdep.c: Include arch/ppc-linux-common.h and
 650         arch/ppc-linux-tdesc.h.
 651         (ppc_linux_core_read_description): Remove target description
 652         matching code. Fill a ppc_linux_features struct and call
 653         ppc_linux_match_description with it.
 654         * ppc-linux-tdep.h (tdesc_powerpc_32l, tdesc_powerpc_64l)
 655         (tdesc_powerpc_altivec32l, tdesc_powerpc_altivec64l)
 656         (tdesc_powerpc_cell32l, tdesc_powerpc_cell64l)
 657         (tdesc_powerpc_vsx32l, tdesc_powerpc_vsx64l)
 658         (tdesc_powerpc_isa205_32l, tdesc_powerpc_isa205_64l)
 659         (tdesc_powerpc_isa205_altivec32l, tdesc_powerpc_isa205_altivec64l)
 660         (tdesc_powerpc_isa205_vsx32l, tdesc_powerpc_isa205_vsx64l)
 661         (tdesc_powerpc_e500l): Remove.
 662
 663 2018-05-22  Joel Brobecker  <brobecker@adacore.com>
 664
 665         * ada-lang.c (catch_assert_command): Pass empty string instead
 666         of NULL for excep_string argument.
 667
 668 2018-05-22  Maciej W. Rozycki  <macro@mips.com>
 669
 670         * mips-linux-nat.c (mips64_linux_register_addr): Return -1 if
 671         the width of the requested register exceeds the width of the
 672         `ptrace' data type.
 673
 674 2018-05-21  Tom Tromey  <tom@tromey.com>
 675
 676         * printcmd.c (output_command): Remove.
 677         (output_command_const): Rename to output_command.
 678         * valprint.h (output_command): Rename from output_command_const.
 679         * tracepoint.c (trace_dump_actions): Call output_command.
 680
 681 2018-05-21  Tom Tromey  <tom@tromey.com>
 682
 683         * mi/mi-cmd-catch.c (mi_cmd_catch_assert)
 684         (mi_cmd_catch_exception, mi_cmd_catch_handlers): Update.
 685         * ada-lang.h (create_ada_exception_catchpoint): Update.
 686         * ada-lang.c (struct ada_catchpoint) <excep_string>: Now a
 687         std::string.
 688         (create_excep_cond_exprs, ~ada_catchpoint)
 689         (should_stop_exception, print_one_exception)
 690         (print_mention_exception, print_recreate_exception): Update.
 691         (ada_get_next_arg): Remove.
 692         (catch_ada_exception_command_split): Use std::string.  Change type
 693         of "excep_string", "cond_string".
 694         (catch_ada_exception_command): Update.
 695         (create_ada_exception_catchpoint): Change type of excep_string.
 696         (ada_exception_sal): Remove excep_string parameter.
 697         (~ada_catchpoint): Remove.
 698
 699 2018-05-21  Tom Tromey  <tom@tromey.com>
 700
 701         * ada-lang.c (ada_collect_symbol_completion_matches): Remove
 702         cleanup.
 703
 704 2018-05-21  Tom Tromey  <tom@tromey.com>
 705
 706         * ada-lang.c (ada_exception_message_1, ada_exception_message):
 707         Return unique_xmalloc_ptr.
 708         (print_it_exception): Update.
 709
 710 2018-05-21  Tom Tromey  <tom@tromey.com>
 711
 712         * tracepoint.c (trace_dump_actions): Use std::string.
 713
 714 2018-05-21  Tom Tromey  <tom@tromey.com>
 715
 716         * symfile.c (reread_symbols): Use std::string for original_name.
 717
 718 2018-05-21  Tom Tromey  <tom@tromey.com>
 719
 720         * dwarf2read.c (dwarf2_read_debug_names): Use std::unique_ptr.
 721         (mapped_index_base): Use DISABLE_COPY_AND_ASSIGN.  Default
 722         constructor.
 723
 724 2018-05-20  Simon Marchi  <simon.marchi@polymtl.ca>
 725
 726         * common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Rename the wrong
 727         instance to...
 728         (HAVE_IS_TRIVIALLY_CONSTRUCTIBLE): ... this.
 729         * objfiles.c (get_objfile_bfd_data): Allocate
 730         objfile_per_bfd_storage with obstack_new when allocating on
 731         obstack.
 732
 733 2018-05-20  Simon Marchi  <simon.marchi@ericsson.com>
 734
 735         * ada-lang.c (cache_symbol): Use XOBNEW and/or XOBNEWVEC and/or
 736         OBSTACK_ZALLOC.
 737         * dwarf2-frame.c (dwarf2_build_frame_info): Likewise.
 738         * hppa-tdep.c (hppa_init_objfile_priv_data): Likewise.
 739         * mdebugread.c (mdebug_build_psymtabs): Likewise.
 740         (add_pending): Likewise.
 741         (parse_symbol): Likewise.
 742         (parse_partial_symbols): Likewise.
 743         (psymtab_to_symtab_1): Likewise.
 744         (new_psymtab): Likewise.
 745         (elfmdebug_build_psymtabs): Likewise.
 746         * minsyms.c (terminate_minimal_symbol_table): Likewise.
 747         * objfiles.c (get_objfile_bfd_data): Likewise.
 748         (objfile_register_static_link): Likewise.
 749         * psymtab.c (allocate_psymtab): Likewise.
 750         * stabsread.c (read_member_functions): Likewise.
 751         * xcoffread.c (xcoff_end_psymtab): Likewise.
 752
 753 2018-05-20  Simon Marchi  <simon.marchi@ericsson.com>
 754
 755         * common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Define if
 756         compiler supports std::is_trivially_constructible.
 757         * common/poison.h: Include obstack.h.
 758         (IsMallocable): Define to is_trivially_constructible if the
 759         compiler supports it, define to true_type otherwise.
 760         (xobnew): New.
 761         (XOBNEW): Redefine.
 762         (xobnewvec): New.
 763         (XOBNEWVEC): Redefine.
 764         * gdb_obstack.h (obstack_zalloc): New.
 765         (OBSTACK_ZALLOC): Redefine.
 766         (obstack_calloc): New.
 767         (OBSTACK_CALLOC): Redefine.
 768         (obstack_new): New.
 769         * gdbarch.sh: Include gdb_obstack in gdbarch.h.
 770         (gdbarch_obstack): New declaration in gdbarch.h, definition in
 771         gdbarch.c.
 772         (GDBARCH_OBSTACK_CALLOC, GDBARCH_OBSTACK_ZALLOC): Use
 773         obstack_calloc/obstack_zalloc.
 774         (gdbarch_obstack_zalloc): Remove.
 775         * target-descriptions.c (tdesc_data_init): Use obstack_new.
 776
 777 2018-05-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 778
 779         * stack.c (backtrace_command_1): Remove useless variable int i.
 780
 781 2018-05-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 782
 783         * stack.c (print_frame_info): Fix comment.
 784
 785 2018-05-18  Tom Tromey  <tom@tromey.com>
 786
 787         * dwarf2read.c (struct dwz_file): Add constructor, initializers.
 788         <dwz_bfd>: Now a gdb_bfd_ref_ptr.
 789         (~dwarf2_per_objfile): Update
 790         (dwarf2_get_dwz_file): Use new.
 791         * dwarf2read.h (struct dwarf2_per_objfile) <dwz_file>: Now a
 792         unique_ptr.
 793
 794 2018-05-18  Tom Tromey  <tom@tromey.com>
 795
 796         * dwarf2read.h (struct dwarf2_per_objfile) <dwp_file>: Now a
 797         unique_ptr.
 798         * dwarf2read.c (struct dwp_file): Add constructor and
 799         initializers.
 800         (open_and_init_dwp_file): Return a unique_ptr.
 801         (dwarf2_per_objfile, create_dwp_hash_table)
 802         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2)
 803         (lookup_dwo_unit_in_dwp): Update.
 804         (open_and_init_dwp_file, get_dwp_file): Update.
 805
 806 2018-05-18  Tom Tromey  <tom@tromey.com>
 807
 808         * dwarf2read.c (dwarf2_per_objfile): Update.
 809         (struct mapped_index): Add initializers.
 810         (dwarf2_read_index): Use new.
 811         (dw2_symtab_iter_init): Update.
 812         * dwarf2read.h (struct dwarf2_per_objfile) <index_table>: Now a
 813         unique_ptr.
 814
 815 2018-05-18  Simon Marchi  <simon.marchi@ericsson.com>
 816
 817         * dwarf2read.c (mapped_index) <total_size>: Remove.
 818
 819 2018-05-18  Simon Marchi  <simon.marchi@ericsson.com>
 820
 821         * unittests/format_pieces-selftests.c (test_format_specifier):
 822         Add ARI comments.
 823
 824 2018-05-18  Tom Tromey  <tom@tromey.com>
 825
 826         * c-typeprint.c (maybe_print_hole): New function.
 827         (c_print_type_struct_field_offset): Update.
 828         (c_type_print_base_struct_union): Call maybe_print_hole.
 829
 830 2018-05-17  Keith Seitz  <keiths@redhat.com>
 831
 832         * breakpoint.c (build_bpstat_chain): New function, moved from
 833         bpstat_stop_status.
 834         (bpstat_stop_status): Add optional parameter, `stop_chain'.
 835         If no stop chain is passed, call build_bpstat_chain to build it.
 836         * breakpoint.h (build_bpstat_chain): Declare.
 837         (bpstat_stop_status): Move documentation here from breakpoint.c.
 838         * infrun.c (handle_signal_stop): Before eliding inlined frames,
 839         build the stop chain and pass it to skip_inline_frames.
 840         Pass this stop chain to bpstat_stop_status.
 841         * inline-frame.c: Include breakpoint.h.
 842         (stopped_by_user_bp_inline_frame): New function.
 843         (skip_inline_frames): Add parameter `stop_chain'.
 844         Move documention to inline-frame.h.
 845         If non-NULL, use stopped_by_user_bp_inline_frame to determine
 846         whether the frame should be elided.
 847         * inline-frame.h (skip_inline_frames): Add parameter `stop_chain'.
 848         Add moved documentation and update for new parameter.
 849
 850 2018-05-17  Simon Marchi  <simon.marchi@ericsson.com>
 851
 852         PR cli/14975
 853         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 854         unittests/format_pieces-selftests.c.
 855         * common/format.h (format_piece) <operator==>: New.
 856         (format_pieces) <operator[]>: Remove.
 857         * common/format.c (format_pieces::format_pieces): Handle \e.
 858         * unittests/format_pieces-selftests.c: New.
 859
 860 2018-05-17  Tom Tromey  <tom@tromey.com>
 861
 862         PR symtab/23010:
 863         * dwarf2read.c (load_cu, dw2_do_instantiate_symtab)
 864         (dw2_instantiate_symtab): Add skip_partial parameter.
 865         (dw2_find_last_source_symtab, dw2_map_expand_apply)
 866         (dw2_lookup_symbol, dw2_expand_symtabs_for_function)
 867         (dw2_expand_all_symtabs, dw2_expand_symtabs_with_fullname)
 868         (dw2_expand_symtabs_matching_one)
 869         (dw2_find_pc_sect_compunit_symtab)
 870         (dw2_debug_names_lookup_symbol)
 871         (dw2_debug_names_expand_symtabs_for_function): Update.
 872         (init_cutu_and_read_dies): Add skip_partial parameter.
 873         (process_psymtab_comp_unit, build_type_psymtabs_1)
 874         (process_skeletonless_type_unit, load_partial_comp_unit)
 875         (psymtab_to_symtab_1): Update.
 876         (load_full_comp_unit): Add skip_partial parameter.
 877         (process_imported_unit_die, dwarf2_read_addr_index)
 878         (follow_die_offset, dwarf2_fetch_die_loc_sect_off)
 879         (dwarf2_fetch_constant_bytes, dwarf2_fetch_die_type_sect_off)
 880         (read_signatured_type): Update.
 881
 882 2018-05-17  Simon Marchi  <simon.marchi@ericsson.com>
 883
 884         * value.c (release_value): Remove unused variable.
 885         (record_latest_value): Likewise.
 886         (access_value_history): Likewise.
 887         (preserve_values): Likewise.
 888
 889 2018-05-17  Tom Tromey  <tom@tromey.com>
 890
 891         * extension.h (struct ext_lang_type_printers) <py_type_printers>:
 892         Initialize.
 893
 894 2018-05-16  Maciej W. Rozycki  <macro@mips.com>
 895
 896         PR gdb/22286
 897         * linux-nat-trad.c (linux_nat_trad_target::fetch_register):
 898         Also handle registers whose width is not a multiple of
 899         PTRACE_TYPE_RET.
 900         (linux_nat_trad_target::store_register): Likewise.
 901
 902 2018-05-16  Tom Tromey  <tom@tromey.com>
 903
 904         * gdbcore.h (core_bfd): Redefine.
 905         * corelow.c (core_target::close): Update.
 906         (core_target_open): Update.
 907         * progspace.h (struct program_space) <cbfd>: Now a
 908         gdb_bfd_ref_ptr.
 909
 910 2018-05-16  Tom Tromey  <tom@tromey.com>
 911
 912         PR cli/19551:
 913         * symfile-add-flags.h (enum symfile_add_flags)
 914         <SYMFILE_NOT_FILENAME>: New constant.
 915         * symfile.c (read_symbols): Use SYMFILE_NOT_FILENAME.  Get
 916         objfile name from BFD.
 917         (symbol_file_add_with_addrs): Check SYMFILE_NOT_FILENAME.
 918         * minidebug.c (find_separate_debug_file_in_section): Put
 919         ".gnu_debugdata" into BFD's file name.
 920
 921 2018-05-16  Simon Marchi  <simon.marchi@ericsson.com>
 922
 923         * regcache.c (regcache_read_ftype, regcache_write_ftype):
 924         Remove.
 925
 926 2018-05-15  Tamar Christina  <tamar.christina@arm.com>
 927
 928         PR binutils/21446
 929         * aarch64-tdep.c (aarch64_analyze_prologue,
 930         aarch64_software_single_step, aarch64_displaced_step_copy_insn):
 931         Indicate not interested in errors.
 932
 933 2018-05-15  Maciej W. Rozycki  <macro@mips.com>
 934
 935         * mips-linux-nat.c (mips_linux_nat_target::fetch_registers):
 936         Supply the MIPS_ZERO_REGNUM register.
 937
 938 2018-05-15  Maciej W. Rozycki  <macro@mips.com>
 939
 940         * mips-tdep.c (mask_address_var): Make variable static.
 941
 942 2018-05-14  Tom Tromey  <tom@tromey.com>
 943
 944         * dwarf2read.c (rust_union_quirks): Clear rust_unions.
 945
 946 2018-05-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 947
 948         * i387-tdep.c (i387_collect_xsave): Use FXSAVE_MXCSR_ADDR not
 949         FXSAVE_ADDR for the mxcsr register.
 950
 951 2018-05-11  Max Filippov  <jcmvbkbc@gmail.com>
 952
 953         * configure.tgt (xtensa*-*-linux*): Drop gdb_target definition.
 954
 955 2018-05-11  Pedro Alves  <palves@redhat.com>
 956
 957         * corelow.c (core_target) <core_target>: No longer inline.
 958         Initialize m_core_gdbarch, m_core_vec and build the section table
 959         here.
 960         <~core_target>: New.
 961         <core_gdbarch, get_core_register_section>: New methods.
 962         <m_core_section_table, m_core_vec, m_core_gdbarch>: New fields,
 963         factored out from ...
 964         <core_data, core_vec, core_gdbarch>: ... these deleted globals.
 965         (core_ops): Delete.
 966         (sniff_core_bfd): Add gdbarch parameter.
 967         (core_close): Delete, merged into ...
 968         (core_target::close): ... here.  Delete self.
 969         (core_close_cleanup): Delete.
 970         (core_target_open): Allocate a core_target on the heap.  Use a
 971         unique_ptr instead of a cleanup.  Bits moved into the core_target
 972         ctor.  Adjust to use core_target methods instead of globals.
 973         (get_core_register_section): Rename to ...
 974         (core_target::get_core_register_section): ... this and adjust.
 975         (struct get_core_registers_cb_data): New.
 976         (get_core_registers_cb): Use it.  Use bool.
 977         (core_target::fetch_registers, core_target::files_info)
 978         (core_target::xfer_partial, core_target::read_description)
 979         (core_target::pid_to, core_target::thread_name): Adjust to
 980         reference class fields instead of globals.
 981         * target.h (struct target_ops_deleter, target_ops_up): New.
 982
 983 2018-05-11  Pedro Alves  <palves@redhat.com>
 984
 985         * corefile.c (core_file_command): Move to corelow.c.
 986         * corelow.c (the_core_target): Delete.
 987         (core_file_command): Moved from corefile.c.  Check exec_bfd
 988         instead of the_core_target.  Use target_detach instead of calling
 989         into the_core_target directly.
 990         (maybe_say_no_core_file_now): New.
 991         (core_target::detach): Use it.
 992         (_initialize_corelow): Remove references to the_core_target.
 993         * gdbcore.h (the_core_target): Delete.
 994
 995 2018-05-11  Tom Tromey  <tromey@redhat.com>
 996             Pedro Alves  <palves@redhat.com>
 997
 998         * corefile.c (core_bfd): Remove.
 999         * gdbcore.h (core_bfd): Now a macro.
1000         * progspace.h (struct program_space) <cbfd>: New field.
1001
1002 2018-05-11  Tom Tromey  <tom@tromey.com>
1003
1004         * mdebugread.c (parse_partial_symbols, psymtab_to_symtab_1): Use
1005         gdb::def_vector.
1006
1007 2018-05-10  Tom Tromey  <tom@tromey.com>
1008
1009         * configure: Rebuild.
1010         * warning.m4 (AM_GDB_WARNINGS): Use -Wimplicit-fallthrough=3.
1011
1012 2018-05-10  Joel Brobecker  <brobecker@adacore.com>
1013
1014         PR server/23158:
1015         * regformats/regdat.sh: Adjust script, following the addition
1016         of the new expedite_regs parameter to init_target_desc.
1017
1018 2018-05-10  Omair Javaid  <omair.javaid@linaro.org>
1019
1020         PR gdb/23127
1021         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Add call to
1022         set_gdbarch_significant_addr_bit.
1023         * aarch64-tdep.c (aarch64_gdbarch_init): Remove call to
1024         set_gdbarch_significant_addr_bit.
1025         * utils.c (address_significant): Update to sign extend addr.
1026
1027 2018-05-09  Max Filippov  <jcmvbkbc@gmail.com>
1028
1029         * xtensa-linux-tdep.c (xtensa-tdep.h): New include.
1030         (xtensa_linux_init_abi): Limit tdep->num_regs by
1031         tdep->num_nopriv_regs.
1032         * xtensa-tdep.c (xtensa_derive_tdep): Calculate
1033         tdep->num_nopriv_regs and only copy it to tdep->num_regs if it's
1034         not initialized.
1035
1036 2018-05-08  Simon Marchi  <simon.marchi@ericsson.com>
1037
1038         * unittests/string_view-selftests.c: Define GNULIB_NAMESPACE.
1039
1040 2018-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1041
1042         * common/x86-xstate.h (I387_FCTRL_INIT_VAL): New constant.
1043         (I387_MXCSR_INIT_VAL): New constant.
1044         * amd64-tdep.c (amd64_supply_xsave): Only read state from xsave
1045         buffer if it was supplied by the inferior.
1046         * i387-tdep.c (i387_supply_fsave): Use I387_MXCSR_INIT_VAL.
1047         (i387_xsave_get_clear_bv): New function.
1048         (i387_supply_xsave): Only read x87 control registers from the
1049         xsave buffer if the feature is enabled, and the state will have
1050         been written, otherwise, provide a suitable default.
1051         (i387_collect_xsave): Pre-clear all registers in xsave buffer,
1052         including x87 control registers.  Update control registers if they
1053         have changed from the default value, and mark features as enabled
1054         as required.
1055         * i387-tdep.h (i387_xsave_get_clear_bv): Declare.
1056
1057 2018-05-08  Ulrich Weigand  <uweigand@de.ibm.com>
1058
1059         * spu-tdep.c (info_spu_event_command): Fix output formatting.
1060
1061 2018-05-07  Tom Tromey  <tom@tromey.com>
1062
1063         * configure: Rebuild.
1064         * warning.m4 (AM_GDB_WARNINGS): Add -Wduplicated-cond.
1065
1066 2018-05-07  Tom Tromey  <tom@tromey.com>
1067
1068         PR tdep/20362:
1069         * arm-tdep.c (arm_record_vfp_data_proc_insn): Properly mask off D
1070         bit.  Use correct value for VDIV.
1071
1072 2018-05-04  Tom Tromey  <tom@tromey.com>
1073
1074         * configure: Rebuild.
1075         * warning.m4 (AM_GDB_WARNINGS): Add -Wimplicit-fallthrough.
1076
1077 2018-05-04  Tom Tromey  <tom@tromey.com>
1078
1079         * linux-record.c (record_linux_system_call) <case
1080         RECORD_SYS_RECVFROM>: Add "break".
1081
1082 2018-05-04  Tom Tromey  <tom@tromey.com>
1083
1084         * mi/mi-main.c (mi_cmd_trace_frame_collected) <REGISTERS_FORMAT>:
1085         Add missing "break".
1086         * mi/mi-cmd-stack.c (mi_cmd_stack_list_locals) <NO_FRAME_FILTERS>:
1087         Add missing "break".
1088
1089 2018-05-04  Tom Tromey  <tom@tromey.com>
1090
1091         * rs6000-tdep.c (ppc_process_record_op4)
1092         (ppc_process_record_op63): Add fall-through comment.
1093
1094 2018-05-04  Tom Tromey  <tom@tromey.com>
1095
1096         * i386-tdep.c (i386_process_record): Add fall-through comment.
1097
1098 2018-05-04  Tom Tromey  <tom@tromey.com>
1099
1100         * stabsread.c (define_symbol) <case 'p'>: Add fall-through
1101         comment.
1102
1103 2018-05-04  Tom Tromey  <tom@tromey.com>
1104
1105         * riscv-tdep.c (riscv_isa_xlen): Add fall-through comment.
1106         * utils.c (can_dump_core) <LIMIT_CUR>: Add fall-through comment.
1107         * eval.c (fetch_subexp_value) <MEMORY_ERROR>: Add fall-through
1108         comment.
1109         * d-valprint.c (d_val_print) <TYPE_CODE_STRUCT>: Add fall-through
1110         comment.
1111         * coffread.c (coff_symtab_read) <C_LABEL>: Add fall-through
1112         comment.
1113
1114 2018-05-04  Tom Tromey  <tom@tromey.com>
1115
1116         * dwarf2loc.c (unimplemented): Add ATTRIBUTE_NORETURN.
1117
1118 2018-05-04  Tom Tromey  <tom@tromey.com>
1119
1120         * s390-tdep.c (s390_process_record): Fix fall-through comments.
1121         * xcoffread.c (scan_xcoff_symtab): Move comment later.
1122         * symfile.c (section_is_mapped): Fix fall-through comment.
1123         * stabsread.c (define_symbol, read_member_functions): Fix
1124         fall-through comment.
1125         * s390-linux-tdep.c (s390_process_record): Fix fall-through
1126         comment.
1127         * remote.c (remote_wait_as): Fix fall-through comment.
1128         * p-exp.y (yylex): Fix fall-through comment.
1129         * nat/x86-dregs.c (x86_length_and_rw_bits): Fix fall-through
1130         comment.
1131         * msp430-tdep.c (msp430_gdbarch_init): Fix fall-through comment.
1132         * mdebugread.c (parse_partial_symbols): Fix fall-through comment.
1133         * jv-exp.y (yylex): Fix fall-through comment.
1134         * go-exp.y (lex_one_token): Fix fall-through comment.
1135         * gdbtypes.c (get_discrete_bounds, rank_one_type): Fix
1136         fall-through comment.
1137         * f-exp.y (yylex): Fix fall-through comment.
1138         * dwarf2read.c (process_die): Fix fall-through comments.
1139         * dbxread.c (process_one_symbol): Fix fall-through comment.
1140         * d-exp.y (lex_one_token): Fix fall-through comment.
1141         * cp-name-parser.y (yylex): Fix fall-through comment.
1142         * coffread.c (coff_symtab_read): Fix fall-through comment.
1143         * c-exp.y (lex_one_token): Fix fall-through comment.
1144         * arm-tdep.c (arm_decode_miscellaneous): Fix fall-through
1145         comment.
1146         * arch/arm.c (arm_instruction_changes_pc): Fix fall-through
1147         comment.
1148
1149 2018-05-04  Tom Tromey  <tom@tromey.com>
1150
1151         PR python/22730:
1152         * NEWS: Mention gdb.execute change.
1153         * gdbcmd.h (execute_control_command): Don't declare.
1154         * python/python.c (execute_gdb_command): Use read_command_lines_1,
1155         execute_control_commands, execute_control_commands_to_string.
1156         * cli/cli-script.h (execute_control_commands)
1157         (execute_control_commands_to_string): Declare.
1158         (execute_control_command): Add from_tty parameter.
1159         * cli/cli-script.c (execute_control_commands)
1160         (execute_control_commands_to_string): New functions.
1161         (execute_user_command): Use execute_control_commands.
1162         (execute_control_command_1): Add "from_tty" parameter.  Update.
1163         (execute_control_command): Likewise.
1164
1165 2018-05-04  Tom Tromey  <tom@tromey.com>
1166
1167         PR python/22731:
1168         * NEWS: Mention that breakpoint commands are writable.
1169         * python/py-breakpoint.c (bppy_set_commands): New function.
1170         (breakpoint_object_getset) <"commands">: Use it.
1171
1172 2018-05-04  Tom Tromey  <tom@tromey.com>
1173
1174         * tracepoint.c (actions_command): Update.
1175         * mi/mi-cmd-break.c (mi_command_line_array)
1176         (mi_command_line_array_cnt, mi_command_line_array_ptr)
1177         (mi_read_next_line): Remove.
1178         (mi_cmd_break_commands): Update.
1179         * cli/cli-script.h (read_command_lines, read_command_lines_1): Use
1180         function_view.
1181         * cli/cli-script.c (get_command_line): Update.
1182         (process_next_line): Use function_view.  Constify.
1183         (recurse_read_control_structure, read_command_lines)
1184         (read_command_lines_1): Change argument types to function_view.
1185         (do_define_command, document_command): Update.
1186         * breakpoint.h (check_tracepoint_command): Don't declare.
1187         * breakpoint.c (check_tracepoint_command): Remove.
1188         (commands_command_1, create_tracepoint_from_upload): Update.
1189
1190 2018-05-04  Tom Tromey  <tom@tromey.com>
1191
1192         PR gdb/11750:
1193         * cli/cli-script.h (enum command_control_type) <define_control>:
1194         New constant.
1195         * cli/cli-script.c (multi_line_command_p): Handle define_control.
1196         (build_command_line, execute_control_command_1)
1197         (process_next_line): Likewise.
1198         (do_define_command): New function, extracted from define_command.
1199         (define_command): Use it.
1200
1201 2018-05-04  Tom Tromey  <tom@tromey.com>
1202
1203         * tracepoint.c (actions_command): Update.
1204         * cli/cli-script.h (read_command_lines): Update.
1205         * cli/cli-script.c (read_command_lines): Constify prompt_arg.
1206         (MAX_TMPBUF): Remove define.
1207         (define_command): Use string_printf.
1208         (document_command): Likewise.
1209         * breakpoint.c (commands_command_1): Update.
1210
1211 2018-05-04  Tom Tromey  <tom@tromey.com>
1212
1213         * top.c (execute_command): Update.
1214         * cli/cli-script.h (print_command_lines): Now varargs.
1215         * cli/cli-script.c (print_command_lines): Now varargs.
1216         (execute_control_command_1) <case while_control, case if_control>:
1217         Update.
1218
1219 2018-05-04  Tom Tromey  <tom@tromey.com>
1220
1221         * tracepoint.c (all_tracepoint_actions): Rename from
1222         all_tracepoint_actions_and_cleanup.  Change return type.
1223         (actions_command, encode_actions_1, encode_actions)
1224         (trace_dump_actions, tdump_command): Update.
1225         * remote.c (remote_download_command_source): Update.
1226         * python/python.c (gdbpy_eval_from_control_command)
1227         (python_command, python_interactive_command): Update.
1228         * mi/mi-cmd-break.c (mi_cmd_break_commands): Update.
1229         * guile/guile.c (guile_command)
1230         (gdbscm_eval_from_control_command, guile_command): Update.
1231         * compile/compile.c (compile_code_command)
1232         (compile_print_command, compile_to_object): Update.
1233         * cli/cli-script.h (struct command_lines_deleter): New.
1234         (counted_command_line): New typedef.
1235         (struct command_line): Add constructor, destructor.
1236         <body_list>: Remove.
1237         <body_list_0, body_list_1>: New members.
1238         (command_line_up): Remove typedef.
1239         (read_command_lines, read_command_lines_1, get_command_line):
1240         Update.
1241         (copy_command_lines): Don't declare.
1242         * cli/cli-script.c (build_command_line): Use "new".
1243         (get_command_line): Return counted_command_line.
1244         (print_command_lines, execute_user_command)
1245         (execute_control_command_1, while_command, if_command): Update.
1246         (realloc_body_list): Remove.
1247         (process_next_line, recurse_read_control_structure): Update.
1248         (read_command_lines, read_command_lines_1): Return counted_command_line.
1249         (free_command_lines): Use "delete".
1250         (copy_command_lines): Remove.
1251         (define_command, document_command, show_user_1): Update.
1252         * cli/cli-decode.h (struct cmd_list_element) <user_commands>: Now
1253         a counted_command_line.
1254         * breakpoint.h (counted_command_line): Remove typedef.
1255         (breakpoint_set_commands): Update.
1256         * breakpoint.c (check_no_tracepoint_commands)
1257         (validate_commands_for_breakpoint): Update.
1258         (breakpoint_set_commands): Change commands to be a
1259         counted_command_line.
1260         (commands_command_1, update_dprintf_command_list)
1261         (create_tracepoint_from_upload): Update.
1262
1263 2018-05-04  Tom Tromey  <tom@tromey.com>
1264
1265         * cli/cli-decode.h (cmd_list_element): New constructor.
1266         (~cmd_list_element): New destructor.
1267         (struct cmd_list_element): Add initializers.
1268         * cli/cli-decode.c (do_add_cmd): Use "new".
1269         (delete_cmd): Use "delete".
1270
1271 2018-05-04  Jan Kratochvil  <jan.kratochvil@redhat.com>
1272             Pedro Alves <palves@redhat.com>
1273
1274         PR breakpoints/19806 and support for PR external/20207.
1275         * NEWS: Mention Aarch64 watchpoint improvements.
1276         * aarch64-linux-nat.c (aarch64_linux_stopped_data_address): Fix missed
1277         watchpoints and PR external/20207 watchpoints.
1278         * nat/aarch64-linux-hw-point.c
1279         (kernel_supports_any_contiguous_range): New.
1280         (aarch64_watchpoint_offset): New.
1281         (aarch64_watchpoint_length): Support PR external/20207 watchpoints.
1282         (aarch64_point_encode_ctrl_reg): New parameter offset, new asserts.
1283         (aarch64_point_is_aligned): Support PR external/20207 watchpoints.
1284         (aarch64_align_watchpoint): New parameters aligned_offset_p and
1285         next_addr_orig_p.  Support PR external/20207 watchpoints.
1286         (aarch64_downgrade_regs): New.
1287         (aarch64_dr_state_insert_one_point): New parameters offset and
1288         addr_orig.
1289         (aarch64_dr_state_remove_one_point): Likewise.
1290         (aarch64_handle_breakpoint): Update caller.
1291         (aarch64_handle_aligned_watchpoint): Likewise.
1292         (aarch64_handle_unaligned_watchpoint): Support addr_orig and
1293         aligned_offset.
1294         (aarch64_linux_set_debug_regs): Remove const from state.  Call
1295         aarch64_downgrade_regs.
1296         (aarch64_show_debug_reg_state): Print also dr_addr_orig_wp.
1297         * nat/aarch64-linux-hw-point.h (DR_CONTROL_LENGTH): Rename to ...
1298         (DR_CONTROL_MASK): ... this.
1299         (struct aarch64_debug_reg_state): New field dr_addr_orig_wp.
1300         (unsigned int aarch64_watchpoint_offset): New prototype.
1301         (aarch64_linux_set_debug_regs): Remove const from state.
1302         * utils.c (align_up, align_down): Move to ...
1303         * common/common-utils.c (align_up, align_down): ... here.
1304         * utils.h (align_up, align_down): Move to ...
1305         * common/common-utils.h (align_up, align_down): ... here.
1306
1307 2018-05-04  Joel Brobecker  <brobecker@adacore.com>
1308
1309         * sparc-tdep.c (sparc_structure_return_p): Re-implement to
1310         match the ABI as summarized in GCC's gcc/config/sparc/sparc.c.
1311         (sparc_arg_by_memory_p): Renamed from sparc_arg_on_registers_p.
1312         Re-implement to match the ABI as summarized in GCC's
1313         gcc/config/sparc/sparc.c.  All callers updated.
1314         (sparc32_store_arguments): Remove assertion.
1315
1316 2018-05-04  Tom Tromey  <tom@tromey.com>
1317
1318         * printcmd.c: Don't include tui.h.
1319         (decode_format): Use skip_spaces.
1320
1321 2018-05-04  Tom Tromey  <tom@tromey.com>
1322
1323         PR gdb/22619:
1324         * printcmd.c (last_count): New global.
1325         (x_command): Use saved count when repeating.
1326
1327 2018-05-04  Tom Tromey  <tom@tromey.com>
1328
1329         * nto-procfs.c (do_closedir_cleanup): Remove.
1330         (procfs_pidlist): Use gdb_dir_up.
1331         * procfs.c (do_closedir_cleanup): Remove.
1332         (proc_update_threads): Use gdb_dir_up.
1333         * common/filestuff.h (struct gdb_dir_deleter): New.
1334         (gdb_dir_up): New typedef.
1335
1336 2018-05-04  Tom Tromey  <tom@tromey.com>
1337
1338         * ada-lang.c (print_mention_exception): Use std::string.
1339
1340 2018-05-04  Tom Tromey  <tom@tromey.com>
1341
1342         * ada-lang.c (create_excep_cond_exprs): Update.
1343         (ada_exception_catchpoint_cond_string): Use std::string.
1344
1345 2018-05-04  Tom Tromey  <tom@tromey.com>
1346
1347         * ada-lang.c (xget_renaming_scope): Return std::string.
1348         (old_renaming_is_invisible): Update.
1349
1350 2018-05-04  Tom Tromey  <tom@tromey.com>
1351
1352         * bfd-target.c (target_bfd::m_bfd): Now a gdb_bfd_ref_ptr.
1353         (target_bfd::target_bfd, target_bfd::~target_bfd): Update.
1354
1355 2018-05-04  Ulrich Weigand  <uweigand@de.ibm.com>
1356
1357         * spu-linux-nat.c (spu_linux_nat_target::wait): Fix syntax error.
1358
1359 2018-05-04  Tom Tromey  <tom@tromey.com>
1360
1361         * remote.c (remote_query_supported_append): Change type.
1362         (remote_check_symbols): Update.
1363
1364 2018-05-04  Paul Pluzhnikov  <ppluzhnikov@google.com>
1365
1366         PR gdb/11420
1367         * configure.ac: Prepend libpython.
1368         * python/python-config.py: Likewise.
1369         * configure: Regenerate.
1370
1371 2018-05-03  Simon Marchi  <simon.marchi@ericsson.com>
1372
1373         * Makefile.in (%.c: %.l): Use -t instead of --stdout.
1374
1375 2018-05-03  Pedro Alves  <palves@redhat.com>
1376
1377         * s390-linux-nat.c
1378         (s390_linux_nat_target::have_continuable_watchpoint): Mark with
1379         override.  Write 'true' instead of '1'.
1380         (s390_linux_nat_target::watchpoint_addr_within_range): Remove
1381         declaration.
1382
1383 2018-05-02  Pedro Alves  <palves@redhat.com>
1384
1385         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Use
1386         add_inf_child_target.
1387         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Use
1388         add_inf_child_target.
1389         * aix-thread.c (aix_thread_target_info): New.
1390         (aix_thread_target) <shortname, longname, doc>: Delete.
1391         <info>: New.
1392         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Use
1393         add_inf_child_target.
1394         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Use
1395         add_inf_child_target.
1396         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Use
1397         add_inf_child_target.
1398         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Use
1399         add_inf_child_target.
1400         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Use
1401         add_inf_child_target.
1402         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Use
1403         add_inf_child_target.
1404         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Use
1405         add_inf_child_target.
1406         * arm-linux-nat.c (_initialize_arm_linux_nat): Use
1407         add_inf_child_target.
1408         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Use
1409         add_inf_child_target.
1410         * bfd-target.c (target_bfd_target_info): New.
1411         (target_bfd) <shortname, longname, doc>: Delete.
1412         <info>: New.
1413         * bsd-kvm.c (bsd_kvm_target_info): New.
1414         (bsd_kvm_target) <shortname, longname, doc>: Delete.
1415         <info>: New.
1416         (bsd_kvm_target::open): Rename to ...
1417         (bsd_kvm_target_open): ... this.  Adjust.
1418         * bsd-uthread.c (bsd_uthread_target_info): New.
1419         (bsd_uthread_target) <shortname, longname, doc>: Delete.
1420         <info>: New.
1421         * corefile.c (core_file_command): Adjust.
1422         * corelow.c (core_target_info): New.
1423         (core_target) <shortname, longname, doc>: Delete.
1424         <info>: New.
1425         (core_target::open): Rename to ...
1426         (core_target_open): ... this.  Adjust.
1427         * ctf.c (ctf_target_info): New.
1428         (ctf_target) <shortname, longname, doc>: Delete.
1429         <info>: New.
1430         (ctf_target::open): Rename to ...
1431         (ctf_target_open): ... this.
1432         (_initialize_ctf): Adjust.
1433         * exec.c (exec_target_info): New.
1434         (exec_target) <shortname, longname, doc>: Delete.
1435         <info>: New.
1436         (exec_target::open): Rename to ...
1437         (exec_target_open): ... this.
1438         * gdbcore.h (core_target_open): Declare.
1439         * go32-nat.c (_initialize_go32_nat): Use add_inf_child_target.
1440         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Use
1441         add_inf_child_target.
1442         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Use
1443         add_inf_child_target.
1444         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Use
1445         add_inf_child_target.
1446         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Use
1447         add_inf_child_target.
1448         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Use
1449         add_inf_child_target.
1450         * i386-gnu-nat.c (_initialize_i386gnu_nat): Use
1451         add_inf_child_target.
1452         * i386-linux-nat.c (_initialize_i386_linux_nat): Use
1453         add_inf_child_target.
1454         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Use
1455         add_inf_child_target.
1456         * i386-obsd-nat.c (_initialize_i386obsd_nat): Use
1457         add_inf_child_target.
1458         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Use
1459         add_inf_child_target.
1460         * inf-child.c (inf_child_target_info): New.
1461         (inf_child_target::info): New.
1462         (inf_child_open_target): Remove 'target' parameter.  Use
1463         get_native_target instead.
1464         (inf_child_target::open): Delete.
1465         (add_inf_child_target): New.
1466         * inf-child.h (inf_child_target) <shortname, longname, doc, open>:
1467         Delete.
1468         <info>: New.
1469         (add_inf_child_target): Declare.
1470         (inf_child_open_target): Declare.
1471         * linux-thread-db.c (thread_db_target_info): New.
1472         (thread_db_target) <shortname, longname, doc>: Delete.
1473         <info>: New.
1474         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Use
1475         add_inf_child_target.
1476         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Use
1477         add_inf_child_target.
1478         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Use
1479         add_inf_child_target.
1480         * m88k-bsd-nat.c (_initialize_m88kbsd_nat): Use
1481         add_inf_child_target.
1482         * make-target-delegates (print_class): Adjust.
1483         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Use
1484         add_inf_child_target.
1485         * mips-linux-nat.c (_initialize_mips_linux_nat): Use
1486         add_inf_child_target.
1487         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Use
1488         add_inf_child_target.
1489         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Use
1490         add_inf_child_target.
1491         * nto-procfs.c (nto_native_target_info): New.
1492         (nto_procfs_target_native) <shortname, longname, doc>:
1493         Delete.
1494         <info>: New.
1495         (nto_procfs_target_info): New.
1496         (nto_procfs_target_procfs) <shortname, longname, doc>:
1497         Delete.
1498         <info>: New.
1499         (init_procfs_targets): Adjust.
1500         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Use
1501         add_inf_child_target.
1502         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Use
1503         add_inf_child_target.
1504         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Use
1505         add_inf_child_target.
1506         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Use
1507         add_inf_child_target.
1508         * ravenscar-thread.c (ravenscar_target_info): New.
1509         (ravenscar_thread_target) <shortname, longname, doc>:
1510         Delete.
1511         <info>: New.
1512         * record-btrace.c (record_btrace_target_info):
1513         (record_btrace_target) <shortname, longname, doc>: Delete.
1514         <info>: New.
1515         (record_btrace_target::open): Rename to ...
1516         (record_btrace_target_open): ... this.  Adjust.
1517         * record-full.c (record_longname, record_doc): New.
1518         (record_full_base_target) <shortname, longname, doc>: Delete.
1519         <info>: New.
1520         (record_full_target_info): New.
1521         (record_full_target): <shortname>: Delete.
1522         <info>: New.
1523         (record_full_core_open_1, record_full_open_1): Update comments.
1524         (record_full_base_target::open): Rename to ...
1525         (record_full_open): ... this.
1526         (cmd_record_full_restore): Update.
1527         (_initialize_record_full): Update.
1528         * remote-sim.c (remote_sim_target_info): New.
1529         (gdbsim_target) <shortname, longname, doc>: Delete.
1530         <info>: New.
1531         (gdbsim_target::open): Rename to ...
1532         (gdbsim_target_open): ... this.
1533         (_initialize_remote_sim): Adjust.
1534         * remote.c (remote_doc): New.
1535         (remote_target_info): New.
1536         (remote_target) <shortname, longname, doc>: Delete.
1537         <info>: New.
1538         (extended_remote_target_info): New.
1539         (extended_remote_target) <shortname, longname, doc>: Delete.
1540         <info>: New.
1541         (remote_target::open_1): Make static.  Adjust.
1542         * rs6000-nat.c (_initialize_rs6000_nat): Use add_inf_child_target.
1543         * s390-linux-nat.c (_initialize_s390_nat): Use
1544         add_inf_child_target.
1545         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Use
1546         add_inf_child_target.
1547         * sol-thread.c (thread_db_target_info): New.
1548         (sol_thread_target) <shortname, longname, doc>: Delete.
1549         <info>: New.
1550         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Use
1551         add_inf_child_target.
1552         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Use
1553         add_inf_child_target.
1554         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Use
1555         add_inf_child_target.
1556         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Use
1557         add_inf_child_target.
1558         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Use
1559         add_inf_child_target.
1560         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Use
1561         add_inf_child_target.
1562         * spu-linux-nat.c (_initialize_spu_nat): Use
1563         add_inf_child_target.
1564         * spu-multiarch.c (spu_multiarch_target_info): New.
1565         (spu_multiarch_target) <shortname, longname, doc>: Delete.
1566         <info>: New.
1567         * target-delegates.c: Regenerate.
1568         * target.c: Include <unordered_map>.
1569         (target_ops_p): Delete.
1570         (DEF_VEC_P(target_ops_p)): Delete.
1571         (target_factories): New.
1572         (test_target_info): New.
1573         (test_target_ops::info): New.
1574         (open_target): Adjust to use target_factories.
1575         (add_target_with_completer): Rename to ...
1576         (add_target): ... this.  Change prototype.  Register target_info
1577         and open callback in target_factories.  Register target_info in
1578         command context instead of target_ops.
1579         (add_target): Delete old implementation.
1580         (add_deprecated_target_alias): Change prototype.  Adjust.
1581         (the_native_target): New.
1582         (set_native_target, get_native_target): New.
1583         (find_default_run_target): Use the_native_target.
1584         (find_attach_target, find_run_target): Simplify.
1585         (target_ops::open): Delete.
1586         (dummy_target_info): New.
1587         (dummy_target::shortname, dummy_target::longname)
1588         (dummy_target::doc): Delete.
1589         (dummy_target::info): New.
1590         (debug_target::shortname, debug_target::longname)
1591         (debug_target::doc): Delete.
1592         (debug_target::info): New.
1593         * target.h (struct target_info): New.
1594         (target_ops::~target_ops): Add comment.
1595         (target_ops::info): New.
1596         (target_ops::shortname, target_ops::longname, target_ops::doc): No
1597         longer virtual.  Implement in terms of target_info.
1598         (set_native_target, get_native_target): Declare.
1599         (target_open_ftype): New.
1600         (add_target, add_target_with_completer)
1601         (add_deprecated_target_alias): Change prototype.
1602         (test_target) <shortname, longname, doc>: Delete.
1603         <info>: New.
1604         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Use
1605         add_inf_child_target.
1606         * tracefile-tfile.c (tfile_target_info): New.
1607         (tfile_target) <shortname, longname, doc>: Delete.
1608         <info>: New.
1609         (tfile_target::open): Rename to ...
1610         (tfile_target_open): ... this.
1611         (_initialize_tracefile_tfile): Adjust.
1612         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Use
1613         add_inf_child_target.
1614         * windows-nat.c (_initialize_windows_nat): Use
1615         add_inf_child_target.
1616         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Use
1617         add_inf_child_target.
1618
1619 2018-05-02  Pedro Alves  <palves@redhat.com>
1620
1621         * linux-nat.h (linux_nat_target) <low_new_thread,
1622         low_delete_thread, low_new_fork, low_forget_process,
1623         low_prepare_to_resume, low_siginfo_fixup, low_status_is_event>:
1624         New virtual methods.
1625         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
1626         (linux_nat_new_fork_ftype, linux_nat_set_new_fork)
1627         (linux_nat_forget_process_ftype, linux_nat_set_forget_process)
1628         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
1629         (linux_nat_set_prepare_to_resume, linux_nat_set_status_is_event):
1630         Delete.
1631         * linux-fork.c (delete_fork): Adjust to call low method.
1632         * linux-nat.c (linux_nat_new_thread, linux_nat_delete_thread)
1633         (linux_nat_new_fork, linux_nat_forget_process_hook)
1634         (linux_nat_prepare_to_resume, linux_nat_siginfo_fixup)
1635         (linux_nat_status_is_event):
1636         (linux_nat_target::follow_fork, lwp_free, add_lwp, detach_one_lwp)
1637         (linux_resume_one_lwp_throw, linux_handle_extended_wait): Adjust
1638         to call low method.
1639         (sigtrap_is_event): Rename to ...
1640         (linux_nat_target::low_status_is_event): ... this.
1641         (linux_nat_set_status_is_event): Delete.
1642         (save_stop_reason, linux_nat_wait_1)
1643         (linux_nat_target::mourn_inferior, siginfo_fixup): Adjust to call
1644         low methods.
1645         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
1646         (linux_nat_set_new_fork, linux_nat_set_forget_process)
1647         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
1648         (linux_nat_set_prepare_to_resume): Delete.
1649         * aarch64-linux-nat.c: All linux_nat_set_* callbacks converted to
1650         low virtual methods.
1651         * amd64-linux-nat.c: Likewise.
1652         * arm-linux-nat.c: Likewise.
1653         * i386-linux-nat.c: Likewise.
1654         * ia64-linux-nat.c: Likewise.
1655         * mips-linux-nat.c: Likewise.
1656         * ppc-linux-nat.c: Likewise.
1657         * s390-linux-nat.c: Likewise.
1658         * sparc64-linux-nat.c: Likewise.
1659         * x86-linux-nat.c: Likewise.
1660         * x86-linux-nat.h: Include "nat/x86-linux.h".
1661         (x86_linux_nat_target) <low_new_fork, low_forget_process,
1662         low_prepare_to_resume, low_new_thread, low_delete_thread>:
1663         Override methods.
1664
1665 2018-05-02  Pedro Alves  <palves@redhat.com>
1666
1667         * target.h (target_ops)
1668         <stopped_by_sw_breakpoint, supports_stopped_by_sw_breakpoint,
1669         stopped_by_hw_breakpoint, supports_stopped_by_hw_breakpoint,
1670         stopped_by_watchpoint, have_continuable_watchpoint,
1671         stopped_data_address, watchpoint_addr_within_range,
1672         can_accel_watchpoint_condition, can_run, thread_alive,
1673         has_all_memory, has_memory, has_stack, has_registers,
1674         has_execution, can_async_p, is_async_p, supports_non_stop,
1675         always_non_stop_p, can_execute_reverse, supports_multi_process,
1676         supports_enable_disable_tracepoint,
1677         supports_disable_randomization, supports_string_tracing,
1678         supports_evaluation_of_breakpoint_conditions,
1679         can_run_breakpoint_commands, filesystem_is_local,
1680         can_download_tracepoint, get_trace_state_variable_value,
1681         set_trace_notes, get_tib_address, use_agent, can_use_agent,
1682         record_is_replaying, record_will_replay,
1683         augmented_libraries_svr4_read>: Adjust to return bool.
1684         * aarch64-linux-nat.c: All implementations adjusted.
1685         * aix-thread.c: All implementations adjusted.
1686         * arm-linux-nat.c: All implementations adjusted.
1687         * breakpoint.c: All implementations adjusted.
1688         * bsd-kvm.c: All implementations adjusted.
1689         * bsd-uthread.c: All implementations adjusted.
1690         * corelow.c: All implementations adjusted.
1691         * ctf.c: All implementations adjusted.
1692         * darwin-nat.c: All implementations adjusted.
1693         * darwin-nat.h: All implementations adjusted.
1694         * exec.c: All implementations adjusted.
1695         * fbsd-nat.c: All implementations adjusted.
1696         * fbsd-nat.h: All implementations adjusted.
1697         * gnu-nat.c: All implementations adjusted.
1698         * gnu-nat.h: All implementations adjusted.
1699         * go32-nat.c: All implementations adjusted.
1700         * ia64-linux-nat.c: All implementations adjusted.
1701         * inf-child.c: All implementations adjusted.
1702         * inf-child.h: All implementations adjusted.
1703         * inf-ptrace.c: All implementations adjusted.
1704         * inf-ptrace.h: All implementations adjusted.
1705         * linux-nat.c: All implementations adjusted.
1706         * linux-nat.h: All implementations adjusted.
1707         * mips-linux-nat.c: All implementations adjusted.
1708         * nto-procfs.c: All implementations adjusted.
1709         * ppc-linux-nat.c: All implementations adjusted.
1710         * procfs.c: All implementations adjusted.
1711         * ravenscar-thread.c: All implementations adjusted.
1712         * record-btrace.c: All implementations adjusted.
1713         * record-full.c: All implementations adjusted.
1714         * remote-sim.c: All implementations adjusted.
1715         * remote.c: All implementations adjusted.
1716         * s390-linux-nat.c: All implementations adjusted.
1717         * sol-thread.c: All implementations adjusted.
1718         * spu-multiarch.c: All implementations adjusted.
1719         * target-delegates.c: All implementations adjusted.
1720         * target.c: All implementations adjusted.
1721         * target.h: All implementations adjusted.
1722         * tracefile-tfile.c: All implementations adjusted.
1723         * tracefile.c: All implementations adjusted.
1724         * tracefile.h: All implementations adjusted.
1725         * windows-nat.c: All implementations adjusted.
1726         * x86-linux-nat.h: All implementations adjusted.
1727         * x86-nat.h: All implementations adjusted.
1728
1729 2018-05-02  Pedro Alves  <palves@redhat.com>
1730
1731         * make-target-delegates (scan_target_h): Don't trim lines here.
1732         Replace sequences of tabs and/or whitespace with a single
1733         whitespace.
1734         (top level, parsing methods): Trim each line before processing it
1735         here.
1736
1737 2018-05-02  Pedro Alves  <palves@redhat.com>
1738             John Baldwin  <jhb@freebsd.org>
1739
1740         * target.h (enum strata) <debug_stratum>: New.
1741         (struct target_ops) <all delegation methods>: Replace by C++
1742         virtual methods, and drop "to_" prefix.  All references updated
1743         throughout.
1744         <to_shortname, to_longname, to_doc, to_data,
1745         to_have_steppable_watchpoint, to_have_continuable_watchpoint,
1746         to_has_thread_control, to_attach_no_wait>: Delete, replaced by
1747         virtual methods.  All references updated throughout.
1748         <can_attach, supports_terminal_ours, can_create_inferior,
1749         get_thread_control_capabilities, attach_no_wait>: New
1750         virtual methods.
1751         <insert_breakpoint, remove_breakpoint>: Now
1752         TARGET_DEFAULT_NORETURN methods.
1753         <info_proc>: Now returns bool.
1754         <to_magic>: Delete.
1755         (OPS_MAGIC): Delete.
1756         (current_target): Delete.  All references replaced by references
1757         to ...
1758         (target_stack): ... this.  New.
1759         (target_shortname, target_longname): Adjust.
1760         (target_can_run): Now a function declaration.
1761         (default_child_has_all_memory, default_child_has_memory)
1762         (default_child_has_stack, default_child_has_registers)
1763         (default_child_has_execution): Remove target_ops parameter.
1764         (complete_target_initialization): Delete.
1765         (memory_breakpoint_target): New template class.
1766         (test_target_ops): Refactor as a C++ class with virtual methods.
1767         * make-target-delegates (NAME_PART): Tighten.
1768         (POINTER_PART, CP_SYMBOL): New.
1769         (SIMPLE_RETURN_PART): Reimplement.
1770         (VEC_RETURN_PART): Expect less.
1771         (RETURN_PART, VIRTUAL_PART): New.
1772         (METHOD): Adjust to C++ virtual methods.
1773         (scan_target_h): Remove reference to C99.
1774         (dname): Output "target_ops::" prefix.
1775         (write_function_header): Adjust to output a C++ class method.
1776         (write_declaration): New.
1777         (write_delegator): Adjust to output a C++ class method.
1778         (tdname): Output "dummy_target::" prefix.
1779         (write_tdefault, write_debugmethod): Adjust to output a C++ class
1780         method.
1781         (tdefault_names, debug_names): Delete.
1782         (return_types, tdefaults, styles, argtypes_array): New.
1783         (top level): All methods are delegators.
1784         (print_class): New.
1785         (top level): Print dummy_target and debug_target classes.
1786         * target-delegates.c: Regenerate.
1787         * target-debug.h (target_debug_print_enum_info_proc_what)
1788         (target_debug_print_thread_control_capabilities)
1789         (target_debug_print_thread_info_p): New.
1790         * target.c (dummy_target): Delete.
1791         (the_dummy_target, the_debug_target): New.
1792         (target_stack): Now extern.
1793         (set_targetdebug): Push/unpush debug target.
1794         (default_child_has_all_memory, default_child_has_memory)
1795         (default_child_has_stack, default_child_has_registers)
1796         (default_child_has_execution): Remove target_ops parameter.
1797         (complete_target_initialization): Delete.
1798         (add_target_with_completer): No longer call
1799         complete_target_initialization.
1800         (target_supports_terminal_ours): Use regular delegation.
1801         (update_current_target): Delete.
1802         (push_target): No longer check magic number.  Don't call
1803         update_current_target.
1804         (unpush_target): Don't call update_current_target.
1805         (target_is_pushed): No longer check magic number.
1806         (target_require_runnable): Skip for all stratums over
1807         process_stratum.
1808         (target_ops::info_proc): New.
1809         (target_info_proc): Use find_target_at and
1810         find_default_run_target.
1811         (target_supports_disable_randomization): Use regular delegation.
1812         (target_get_osdata): Use find_target_at.
1813         (target_ops::open, target_ops::close, target_ops::can_attach)
1814         (target_ops::attach, target_ops::can_create_inferior)
1815         (target_ops::create_inferior, target_ops::can_run)
1816         (target_can_run): New.
1817         (default_fileio_target): Use regular delegation.
1818         (target_ops::fileio_open, target_ops::fileio_pwrite)
1819         (target_ops::fileio_pread, target_ops::fileio_fstat)
1820         (target_ops::fileio_close, target_ops::fileio_unlink)
1821         (target_ops::fileio_readlink): New.
1822         (target_fileio_open_1, target_fileio_unlink)
1823         (target_fileio_readlink): Always call the target method.  Handle
1824         FILEIO_ENOSYS.
1825         (return_zero, return_zero_has_execution): Delete.
1826         (init_dummy_target): Delete.
1827         (dummy_target::dummy_target, dummy_target::shortname)
1828         (dummy_target::longname, dummy_target::doc)
1829         (debug_target::debug_target, debug_target::shortname)
1830         (debug_target::longname, debug_target::doc): New.
1831         (target_supports_delete_record): Use regular delegation.
1832         (setup_target_debug): Delete.
1833         (maintenance_print_target_stack): Skip debug_stratum.
1834         (initialize_targets): Instantiate the_dummy_target and
1835         the_debug_target.
1836         * auxv.c (target_auxv_parse): Remove 'ops' parameter.  Adjust to
1837         use target_stack.
1838         (target_auxv_search, fprint_target_auxv): Adjust.
1839         (info_auxv_command): Adjust to use target_stack.
1840         * auxv.h (target_auxv_parse): Remove 'ops' parameter.
1841         * exceptions.c (print_flush): Handle a NULL target_stack.
1842         * regcache.c (target_ops_no_register): Refactor as class with
1843         virtual methods.
1844
1845         * exec.c (exec_target): New class.
1846         (exec_ops): Now an exec_target.
1847         (exec_open, exec_close_1, exec_get_section_table)
1848         (exec_xfer_partial, exec_files_info, exec_has_memory)
1849         (exec_make_note_section): Refactor as exec_target methods.
1850         (exec_file_clear, ignore, exec_remove_breakpoint, init_exec_ops):
1851         Delete.
1852         (exec_target::find_memory_regions): New.
1853         (_initialize_exec): Don't call init_exec_ops.
1854         * gdbcore.h (exec_file_clear): Delete.
1855
1856         * corefile.c (core_target): Delete.
1857         (core_file_command): Adjust.
1858         * corelow.c (core_target): New class.
1859         (the_core_target): New.
1860         (core_close): Remove target_ops parameter.
1861         (core_close_cleanup): Adjust.
1862         (core_target::close): New.
1863         (core_open, core_detach, get_core_registers, core_files_info)
1864         (core_xfer_partial, core_thread_alive, core_read_description)
1865         (core_pid_to_str, core_thread_name, core_has_memory)
1866         (core_has_stack, core_has_registers, core_info_proc): Rework as
1867         core_target methods.
1868         (ignore, core_remove_breakpoint, init_core_ops): Delete.
1869         (_initialize_corelow): Initialize the_core_target.
1870         * gdbcore.h (core_target): Delete.
1871         (the_core_target): New.
1872
1873         * ctf.c: (ctf_target): New class.
1874         (ctf_ops): Now a ctf_target.
1875         (ctf_open, ctf_close, ctf_files_info, ctf_fetch_registers)
1876         (ctf_xfer_partial, ctf_get_trace_state_variable_value)
1877         (ctf_trace_find, ctf_traceframe_info): Refactor as ctf_target
1878         methods.
1879         (init_ctf_ops): Delete.
1880         (_initialize_ctf): Don't call it.
1881         * tracefile-tfile.c (tfile_target): New class.
1882         (tfile_ops): Now a tfile_target.
1883         (tfile_open, tfile_close, tfile_files_info)
1884         (tfile_get_tracepoint_status, tfile_trace_find)
1885         (tfile_fetch_registers, tfile_xfer_partial)
1886         (tfile_get_trace_state_variable_value, tfile_traceframe_info):
1887         Refactor as tfile_target methods.
1888         (tfile_xfer_partial_features): Remove target_ops parameter.
1889         (init_tfile_ops): Delete.
1890         (_initialize_tracefile_tfile): Don't call it.
1891         * tracefile.c (tracefile_has_all_memory, tracefile_has_memory)
1892         (tracefile_has_stack, tracefile_has_registers)
1893         (tracefile_thread_alive, tracefile_get_trace_status): Refactor as
1894         tracefile_target methods.
1895         (init_tracefile_ops): Delete.
1896         (tracefile_target::tracefile_target): New.
1897         * tracefile.h: Include "target.h".
1898         (tracefile_target): New class.
1899         (init_tracefile_ops): Delete.
1900
1901         * spu-multiarch.c (spu_multiarch_target): New class.
1902         (spu_ops): Now a spu_multiarch_target.
1903         (spu_thread_architecture, spu_region_ok_for_hw_watchpoint)
1904         (spu_fetch_registers, spu_store_registers, spu_xfer_partial)
1905         (spu_search_memory, spu_mourn_inferior): Refactor as
1906         spu_multiarch_target methods.
1907         (init_spu_ops): Delete.
1908         (_initialize_spu_multiarch): Remove references to init_spu_ops,
1909         complete_target_initialization.
1910
1911         * ravenscar-thread.c (ravenscar_thread_target): New class.
1912         (ravenscar_ops): Now a ravenscar_thread_target.
1913         (ravenscar_resume, ravenscar_wait, ravenscar_update_thread_list)
1914         (ravenscar_thread_alive, ravenscar_pid_to_str)
1915         (ravenscar_fetch_registers, ravenscar_store_registers)
1916         (ravenscar_prepare_to_store, ravenscar_stopped_by_sw_breakpoint)
1917         (ravenscar_stopped_by_hw_breakpoint)
1918         (ravenscar_stopped_by_watchpoint, ravenscar_stopped_data_address)
1919         (ravenscar_mourn_inferior, ravenscar_core_of_thread)
1920         (ravenscar_get_ada_task_ptid): Refactor as ravenscar_thread_target
1921         methods.
1922         (init_ravenscar_thread_ops): Delete.
1923         (_initialize_ravenscar): Remove references to
1924         init_ravenscar_thread_ops and complete_target_initialization.
1925
1926         * bsd-uthread.c (bsd_uthread_ops_hack): Delete.
1927         (bsd_uthread_target): New class.
1928         (bsd_uthread_ops): Now a bsd_uthread_target.
1929         (bsd_uthread_activate): Adjust to refer to bsd_uthread_ops.
1930         (bsd_uthread_close, bsd_uthread_mourn_inferior)
1931         (bsd_uthread_fetch_registers, bsd_uthread_store_registers)
1932         (bsd_uthread_wait, bsd_uthread_resume, bsd_uthread_thread_alive)
1933         (bsd_uthread_update_thread_list, bsd_uthread_extra_thread_info)
1934         (bsd_uthread_pid_to_str): Refactor as bsd_uthread_target methods.
1935         (bsd_uthread_target): Delete function.
1936         (_initialize_bsd_uthread): Remove reference to
1937         complete_target_initialization.
1938
1939         * bfd-target.c (target_bfd_data): Delete.  Fields folded into ...
1940         (target_bfd): ... this new class.
1941         (target_bfd_xfer_partial, target_bfd_get_section_table)
1942         (target_bfd_close): Refactor as target_bfd methods.
1943         (target_bfd::~target_bfd): New.
1944         (target_bfd_reopen): Adjust.
1945         (target_bfd::close): New.
1946
1947         * record-btrace.c (record_btrace_target): New class.
1948         (record_btrace_ops): Now a record_btrace_target.
1949         (record_btrace_open, record_btrace_stop_recording)
1950         (record_btrace_disconnect, record_btrace_close)
1951         (record_btrace_async, record_btrace_info)
1952         (record_btrace_insn_history, record_btrace_insn_history_range)
1953         (record_btrace_insn_history_from, record_btrace_call_history)
1954         (record_btrace_call_history_range)
1955         (record_btrace_call_history_from, record_btrace_record_method)
1956         (record_btrace_is_replaying, record_btrace_will_replay)
1957         (record_btrace_xfer_partial, record_btrace_insert_breakpoint)
1958         (record_btrace_remove_breakpoint, record_btrace_fetch_registers)
1959         (record_btrace_store_registers, record_btrace_prepare_to_store)
1960         (record_btrace_to_get_unwinder)
1961         (record_btrace_to_get_tailcall_unwinder, record_btrace_resume)
1962         (record_btrace_commit_resume, record_btrace_wait)
1963         (record_btrace_stop, record_btrace_can_execute_reverse)
1964         (record_btrace_stopped_by_sw_breakpoint)
1965         (record_btrace_supports_stopped_by_sw_breakpoint)
1966         (record_btrace_stopped_by_hw_breakpoint)
1967         (record_btrace_supports_stopped_by_hw_breakpoint)
1968         (record_btrace_update_thread_list, record_btrace_thread_alive)
1969         (record_btrace_goto_begin, record_btrace_goto_end)
1970         (record_btrace_goto, record_btrace_stop_replaying_all)
1971         (record_btrace_execution_direction)
1972         (record_btrace_prepare_to_generate_core)
1973         (record_btrace_done_generating_core): Refactor as
1974         record_btrace_target methods.
1975         (init_record_btrace_ops): Delete.
1976         (_initialize_record_btrace): Remove reference to
1977         init_record_btrace_ops.
1978         * record-full.c (RECORD_FULL_IS_REPLAY): Adjust to always refer to
1979         the execution_direction global.
1980         (record_full_base_target, record_full_target)
1981         (record_full_core_target): New classes.
1982         (record_full_ops): Now a record_full_target.
1983         (record_full_core_ops): Now a record_full_core_target.
1984         (record_full_target::detach, record_full_target::disconnect)
1985         (record_full_core_target::disconnect)
1986         (record_full_target::mourn_inferior, record_full_target::kill):
1987         New.
1988         (record_full_open, record_full_close, record_full_async): Refactor
1989         as methods of the record_full_base_target class.
1990         (record_full_resume, record_full_commit_resume): Refactor
1991         as methods of the record_full_target class.
1992         (record_full_wait, record_full_stopped_by_watchpoint)
1993         (record_full_stopped_data_address)
1994         (record_full_stopped_by_sw_breakpoint)
1995         (record_full_supports_stopped_by_sw_breakpoint)
1996         (record_full_stopped_by_hw_breakpoint)
1997         (record_full_supports_stopped_by_hw_breakpoint): Refactor as
1998         methods of the record_full_base_target class.
1999         (record_full_store_registers, record_full_xfer_partial)
2000         (record_full_insert_breakpoint, record_full_remove_breakpoint):
2001         Refactor as methods of the record_full_target class.
2002         (record_full_can_execute_reverse, record_full_get_bookmark)
2003         (record_full_goto_bookmark, record_full_execution_direction)
2004         (record_full_record_method, record_full_info, record_full_delete)
2005         (record_full_is_replaying, record_full_will_replay)
2006         (record_full_goto_begin, record_full_goto_end, record_full_goto)
2007         (record_full_stop_replaying): Refactor as methods of the
2008         record_full_base_target class.
2009         (record_full_core_resume, record_full_core_kill)
2010         (record_full_core_fetch_registers)
2011         (record_full_core_prepare_to_store)
2012         (record_full_core_store_registers, record_full_core_xfer_partial)
2013         (record_full_core_insert_breakpoint)
2014         (record_full_core_remove_breakpoint)
2015         (record_full_core_has_execution): Refactor
2016         as methods of the record_full_core_target class.
2017         (record_full_base_target::supports_delete_record): New.
2018         (init_record_full_ops): Delete.
2019         (init_record_full_core_ops): Delete.
2020         (record_full_save): Refactor as method of the
2021         record_full_base_target class.
2022         (_initialize_record_full): Remove references to
2023         init_record_full_ops and init_record_full_core_ops.
2024
2025         * remote.c (remote_target, extended_remote_target): New classes.
2026         (remote_ops): Now a remote_target.
2027         (extended_remote_ops): Now an extended_remote_target.
2028         (remote_insert_fork_catchpoint, remote_remove_fork_catchpoint)
2029         (remote_insert_vfork_catchpoint, remote_remove_vfork_catchpoint)
2030         (remote_insert_exec_catchpoint, remote_remove_exec_catchpoint)
2031         (remote_pass_signals, remote_set_syscall_catchpoint)
2032         (remote_program_signals, )
2033         (remote_thread_always_alive): Remove target_ops parameter.
2034         (remote_thread_alive, remote_thread_name)
2035         (remote_update_thread_list, remote_threads_extra_info)
2036         (remote_static_tracepoint_marker_at)
2037         (remote_static_tracepoint_markers_by_strid)
2038         (remote_get_ada_task_ptid, remote_close, remote_start_remote)
2039         (remote_open): Refactor as methods of remote_target.
2040         (extended_remote_open, extended_remote_detach)
2041         (extended_remote_attach, extended_remote_post_attach):
2042         (extended_remote_supports_disable_randomization)
2043         (extended_remote_create_inferior): : Refactor as method of
2044         extended_remote_target.
2045         (remote_set_permissions, remote_open_1, remote_detach)
2046         (remote_follow_fork, remote_follow_exec, remote_disconnect)
2047         (remote_resume, remote_commit_resume, remote_stop)
2048         (remote_interrupt, remote_pass_ctrlc, remote_terminal_inferior)
2049         (remote_terminal_ours, remote_wait, remote_fetch_registers)
2050         (remote_prepare_to_store, remote_store_registers)
2051         (remote_flash_erase, remote_flash_done, remote_files_info)
2052         (remote_kill, remote_mourn, remote_insert_breakpoint)
2053         (remote_remove_breakpoint, remote_insert_watchpoint)
2054         (remote_watchpoint_addr_within_range)
2055         (remote_remove_watchpoint, remote_region_ok_for_hw_watchpoint)
2056         (remote_check_watch_resources, remote_stopped_by_sw_breakpoint)
2057         (remote_supports_stopped_by_sw_breakpoint)
2058         (remote_stopped_by_hw_breakpoint)
2059         (remote_supports_stopped_by_hw_breakpoint)
2060         (remote_stopped_by_watchpoint, remote_stopped_data_address)
2061         (remote_insert_hw_breakpoint, remote_remove_hw_breakpoint)
2062         (remote_verify_memory): Refactor as methods of remote_target.
2063         (remote_write_qxfer, remote_read_qxfer): Remove target_ops
2064         parameter.
2065         (remote_xfer_partial, remote_get_memory_xfer_limit)
2066         (remote_search_memory, remote_rcmd, remote_memory_map)
2067         (remote_pid_to_str, remote_get_thread_local_address)
2068         (remote_get_tib_address, remote_read_description): Refactor as
2069         methods of remote_target.
2070         (remote_target::fileio_open, remote_target::fileio_pwrite)
2071         (remote_target::fileio_pread, remote_target::fileio_close): New.
2072         (remote_hostio_readlink, remote_hostio_fstat)
2073         (remote_filesystem_is_local, remote_can_execute_reverse)
2074         (remote_supports_non_stop, remote_supports_disable_randomization)
2075         (remote_supports_multi_process, remote_supports_cond_breakpoints)
2076         (remote_supports_enable_disable_tracepoint)
2077         (remote_supports_string_tracing)
2078         (remote_can_run_breakpoint_commands, remote_trace_init)
2079         (remote_download_tracepoint, remote_can_download_tracepoint)
2080         (remote_download_trace_state_variable, remote_enable_tracepoint)
2081         (remote_disable_tracepoint, remote_trace_set_readonly_regions)
2082         (remote_trace_start, remote_get_trace_status)
2083         (remote_get_tracepoint_status, remote_trace_stop)
2084         (remote_trace_find, remote_get_trace_state_variable_value)
2085         (remote_save_trace_data, remote_get_raw_trace_data)
2086         (remote_set_disconnected_tracing, remote_core_of_thread)
2087         (remote_set_circular_trace_buffer, remote_traceframe_info)
2088         (remote_get_min_fast_tracepoint_insn_len)
2089         (remote_set_trace_buffer_size, remote_set_trace_notes)
2090         (remote_use_agent, remote_can_use_agent, remote_enable_btrace)
2091         (remote_disable_btrace, remote_teardown_btrace)
2092         (remote_read_btrace, remote_btrace_conf)
2093         (remote_augmented_libraries_svr4_read, remote_load)
2094         (remote_pid_to_exec_file, remote_can_do_single_step)
2095         (remote_execution_direction, remote_thread_handle_to_thread_info):
2096         Refactor as methods of remote_target.
2097         (init_remote_ops, init_extended_remote_ops): Delete.
2098         (remote_can_async_p, remote_is_async_p, remote_async)
2099         (remote_thread_events, remote_upload_tracepoints)
2100         (remote_upload_trace_state_variables): Refactor as methods of
2101         remote_target.
2102         (_initialize_remote): Remove references to init_remote_ops and
2103         init_extended_remote_ops.
2104
2105         * remote-sim.c (gdbsim_target): New class.
2106         (gdbsim_fetch_register, gdbsim_store_register, gdbsim_kill)
2107         (gdbsim_load, gdbsim_create_inferior, gdbsim_open, gdbsim_close)
2108         (gdbsim_detach, gdbsim_resume, gdbsim_interrupt)
2109         (gdbsim_wait, gdbsim_prepare_to_store, gdbsim_xfer_partial)
2110         (gdbsim_files_info, gdbsim_mourn_inferior, gdbsim_thread_alive)
2111         (gdbsim_pid_to_str, gdbsim_has_all_memory, gdbsim_has_memory):
2112         Refactor as methods of gdbsim_target.
2113         (gdbsim_ops): Now a gdbsim_target.
2114         (init_gdbsim_ops): Delete.
2115         (gdbsim_cntrl_c): Adjust.
2116         (_initialize_remote_sim): Remove reference to init_gdbsim_ops.
2117
2118         * amd64-linux-nat.c (amd64_linux_nat_target): New class.
2119         (the_amd64_linux_nat_target): New.
2120         (amd64_linux_fetch_inferior_registers)
2121         (amd64_linux_store_inferior_registers): Refactor as methods of
2122         amd64_linux_nat_target.
2123         (_initialize_amd64_linux_nat): Adjust.  Set linux_target.
2124         * i386-linux-nat.c: Don't include "linux-nat.h".
2125         (i386_linux_nat_target): New class.
2126         (the_i386_linux_nat_target): New.
2127         (i386_linux_fetch_inferior_registers)
2128         (i386_linux_store_inferior_registers, i386_linux_resume): Refactor
2129         as methods of i386_linux_nat_target.
2130         (_initialize_i386_linux_nat): Adjust.  Set linux_target.
2131         * inf-child.c (inf_child_ops): Delete.
2132         (inf_child_fetch_inferior_registers)
2133         (inf_child_store_inferior_registers): Delete.
2134         (inf_child_post_attach, inf_child_prepare_to_store): Refactor as
2135         methods of inf_child_target.
2136         (inf_child_target::supports_terminal_ours)
2137         (inf_child_target::terminal_init)
2138         (inf_child_target::terminal_inferior)
2139         (inf_child_target::terminal_ours_for_output)
2140         (inf_child_target::terminal_ours, inf_child_target::interrupt)
2141         (inf_child_target::pass_ctrlc, inf_child_target::terminal_info):
2142         New.
2143         (inf_child_open, inf_child_disconnect, inf_child_close)
2144         (inf_child_mourn_inferior, inf_child_maybe_unpush_target)
2145         (inf_child_post_startup_inferior, inf_child_can_run)
2146         (inf_child_pid_to_exec_file): Refactor as methods of
2147         inf_child_target.
2148         (inf_child_follow_fork): Delete.
2149         (inf_child_target::can_create_inferior)
2150         (inf_child_target::can_attach): New.
2151         (inf_child_target::has_all_memory, inf_child_target::has_memory)
2152         (inf_child_target::has_stack, inf_child_target::has_registers)
2153         (inf_child_target::has_execution): New.
2154         (inf_child_fileio_open, inf_child_fileio_pwrite)
2155         (inf_child_fileio_pread, inf_child_fileio_fstat)
2156         (inf_child_fileio_close, inf_child_fileio_unlink)
2157         (inf_child_fileio_readlink, inf_child_use_agent)
2158         (inf_child_can_use_agent): Refactor as methods of
2159         inf_child_target.
2160         (return_zero, inf_child_target): Delete.
2161         (inf_child_target::inf_child_target): New.
2162         * inf-child.h: Include "target.h".
2163         (inf_child_target): Delete function prototype.
2164         (inf_child_target): New class.
2165         (inf_child_open_target, inf_child_mourn_inferior)
2166         (inf_child_maybe_unpush_target): Delete.
2167         * inf-ptrace.c (inf_ptrace_target::~inf_ptrace_target): New.
2168         (inf_ptrace_follow_fork, inf_ptrace_insert_fork_catchpoint)
2169         (inf_ptrace_remove_fork_catchpoint, inf_ptrace_create_inferior)
2170         (inf_ptrace_post_startup_inferior, inf_ptrace_mourn_inferior)
2171         (inf_ptrace_attach, inf_ptrace_post_attach, inf_ptrace_detach)
2172         (inf_ptrace_detach_success, inf_ptrace_kill, inf_ptrace_resume)
2173         (inf_ptrace_wait, inf_ptrace_xfer_partial)
2174         (inf_ptrace_thread_alive, inf_ptrace_files_info)
2175         (inf_ptrace_pid_to_str, inf_ptrace_auxv_parse): Refactor as
2176         methods of inf_ptrace_target.
2177         (inf_ptrace_target): Delete function.
2178         * inf-ptrace.h: Include "inf-child.h".
2179         (inf_ptrace_target): Delete function declaration.
2180         (inf_ptrace_target): New class.
2181         (inf_ptrace_trad_target, inf_ptrace_detach_success): Delete.
2182         * linux-nat.c (linux_target): New.
2183         (linux_ops, linux_ops_saved, super_xfer_partial): Delete.
2184         (linux_nat_target::~linux_nat_target): New.
2185         (linux_child_post_attach, linux_child_post_startup_inferior)
2186         (linux_child_follow_fork, linux_child_insert_fork_catchpoint)
2187         (linux_child_remove_fork_catchpoint)
2188         (linux_child_insert_vfork_catchpoint)
2189         (linux_child_remove_vfork_catchpoint)
2190         (linux_child_insert_exec_catchpoint)
2191         (linux_child_remove_exec_catchpoint)
2192         (linux_child_set_syscall_catchpoint, linux_nat_pass_signals)
2193         (linux_nat_create_inferior, linux_nat_attach, linux_nat_detach)
2194         (linux_nat_resume, linux_nat_stopped_by_watchpoint)
2195         (linux_nat_stopped_data_address)
2196         (linux_nat_stopped_by_sw_breakpoint)
2197         (linux_nat_supports_stopped_by_sw_breakpoint)
2198         (linux_nat_stopped_by_hw_breakpoint)
2199         (linux_nat_supports_stopped_by_hw_breakpoint, linux_nat_wait)
2200         (linux_nat_kill, linux_nat_mourn_inferior)
2201         (linux_nat_xfer_partial, linux_nat_thread_alive)
2202         (linux_nat_update_thread_list, linux_nat_pid_to_str)
2203         (linux_nat_thread_name, linux_child_pid_to_exec_file)
2204         (linux_child_static_tracepoint_markers_by_strid)
2205         (linux_nat_is_async_p, linux_nat_can_async_p)
2206         (linux_nat_supports_non_stop, linux_nat_always_non_stop_p)
2207         (linux_nat_supports_multi_process)
2208         (linux_nat_supports_disable_randomization, linux_nat_async)
2209         (linux_nat_stop, linux_nat_close, linux_nat_thread_address_space)
2210         (linux_nat_core_of_thread, linux_nat_filesystem_is_local)
2211         (linux_nat_fileio_open, linux_nat_fileio_readlink)
2212         (linux_nat_fileio_unlink, linux_nat_thread_events): Refactor as
2213         methods of linux_nat_target.
2214         (linux_nat_wait_1, linux_xfer_siginfo, linux_proc_xfer_partial)
2215         (linux_proc_xfer_spu, linux_nat_xfer_osdata): Remove target_ops
2216         parameter.
2217         (check_stopped_by_watchpoint): Adjust.
2218         (linux_xfer_partial): Delete.
2219         (linux_target_install_ops, linux_target, linux_nat_add_target):
2220         Delete.
2221         (linux_nat_target::linux_nat_target): New.
2222         * linux-nat.h: Include "inf-ptrace.h".
2223         (linux_nat_target): New.
2224         (linux_target, linux_target_install_ops, linux_nat_add_target):
2225         Delete function declarations.
2226         (linux_target): Declare global.
2227         * linux-thread-db.c (thread_db_target): New.
2228         (thread_db_target::thread_db_target): New.
2229         (thread_db_ops): Delete.
2230         (the_thread_db_target): New.
2231         (thread_db_detach, thread_db_wait, thread_db_mourn_inferior)
2232         (thread_db_update_thread_list, thread_db_pid_to_str)
2233         (thread_db_extra_thread_info)
2234         (thread_db_thread_handle_to_thread_info)
2235         (thread_db_get_thread_local_address, thread_db_get_ada_task_ptid)
2236         (thread_db_resume): Refactor as methods of thread_db_target.
2237         (init_thread_db_ops): Delete.
2238         (_initialize_thread_db): Remove reference to init_thread_db_ops.
2239         * x86-linux-nat.c: Don't include "linux-nat.h".
2240         (super_post_startup_inferior): Delete.
2241         (x86_linux_nat_target::~x86_linux_nat_target): New.
2242         (x86_linux_child_post_startup_inferior)
2243         (x86_linux_read_description, x86_linux_enable_btrace)
2244         (x86_linux_disable_btrace, x86_linux_teardown_btrace)
2245         (x86_linux_read_btrace, x86_linux_btrace_conf): Refactor as
2246         methods of x86_linux_nat_target.
2247         (x86_linux_create_target): Delete.  Bits folded ...
2248         (x86_linux_add_target): ... here.  Now takes a linux_nat_target
2249         pointer.
2250         * x86-linux-nat.h: Include "linux-nat.h" and "x86-nat.h".
2251         (x86_linux_nat_target): New class.
2252         (x86_linux_create_target): Delete.
2253         (x86_linux_add_target): Now takes a linux_nat_target pointer.
2254         * x86-nat.c (x86_insert_watchpoint, x86_remove_watchpoint)
2255         (x86_region_ok_for_watchpoint, x86_stopped_data_address)
2256         (x86_stopped_by_watchpoint, x86_insert_hw_breakpoint)
2257         (x86_remove_hw_breakpoint, x86_can_use_hw_breakpoint)
2258         (x86_stopped_by_hw_breakpoint): Remove target_ops parameter and
2259         make extern.
2260         (x86_use_watchpoints): Delete.
2261         * x86-nat.h: Include "breakpoint.h" and "target.h".
2262         (x86_use_watchpoints): Delete.
2263         (x86_can_use_hw_breakpoint, x86_region_ok_for_hw_watchpoint)
2264         (x86_stopped_by_watchpoint, x86_stopped_data_address)
2265         (x86_insert_watchpoint, x86_remove_watchpoint)
2266         (x86_insert_hw_breakpoint, x86_remove_hw_breakpoint)
2267         (x86_stopped_by_hw_breakpoint): New declarations.
2268         (x86_nat_target): New template class.
2269
2270         * ppc-linux-nat.c (ppc_linux_nat_target): New class.
2271         (the_ppc_linux_nat_target): New.
2272         (ppc_linux_fetch_inferior_registers)
2273         (ppc_linux_can_use_hw_breakpoint)
2274         (ppc_linux_region_ok_for_hw_watchpoint)
2275         (ppc_linux_ranged_break_num_registers)
2276         (ppc_linux_insert_hw_breakpoint, ppc_linux_remove_hw_breakpoint)
2277         (ppc_linux_insert_mask_watchpoint)
2278         (ppc_linux_remove_mask_watchpoint)
2279         (ppc_linux_can_accel_watchpoint_condition)
2280         (ppc_linux_insert_watchpoint, ppc_linux_remove_watchpoint)
2281         (ppc_linux_stopped_data_address, ppc_linux_stopped_by_watchpoint)
2282         (ppc_linux_watchpoint_addr_within_range)
2283         (ppc_linux_masked_watch_num_registers)
2284         (ppc_linux_store_inferior_registers, ppc_linux_auxv_parse)
2285         (ppc_linux_read_description): Refactor as methods of
2286         ppc_linux_nat_target.
2287         (_initialize_ppc_linux_nat): Adjust.  Set linux_target.
2288
2289         * procfs.c (procfs_xfer_partial): Delete forward declaration.
2290         (procfs_target): New class.
2291         (the_procfs_target): New.
2292         (procfs_target): Delete function.
2293         (procfs_auxv_parse, procfs_attach, procfs_detach)
2294         (procfs_fetch_registers, procfs_store_registers, procfs_wait)
2295         (procfs_xfer_partial, procfs_resume, procfs_pass_signals)
2296         (procfs_files_info, procfs_kill_inferior, procfs_mourn_inferior)
2297         (procfs_create_inferior, procfs_update_thread_list)
2298         (procfs_thread_alive, procfs_pid_to_str)
2299         (procfs_can_use_hw_breakpoint, procfs_stopped_by_watchpoint)
2300         (procfs_stopped_data_address, procfs_insert_watchpoint)
2301         (procfs_remove_watchpoint, procfs_region_ok_for_hw_watchpoint)
2302         (proc_find_memory_regions, procfs_info_proc)
2303         (procfs_make_note_section): Refactor as methods of procfs_target.
2304         (_initialize_procfs): Adjust.
2305         * sol-thread.c (sol_thread_target): New class.
2306         (sol_thread_ops): Now a sol_thread_target.
2307         (sol_thread_detach, sol_thread_resume, sol_thread_wait)
2308         (sol_thread_fetch_registers, sol_thread_store_registers)
2309         (sol_thread_xfer_partial, sol_thread_mourn_inferior)
2310         (sol_thread_alive, solaris_pid_to_str, sol_update_thread_list)
2311         (sol_get_ada_task_ptid): Refactor as methods of sol_thread_target.
2312         (init_sol_thread_ops): Delete.
2313         (_initialize_sol_thread): Adjust.  Remove references to
2314         init_sol_thread_ops and complete_target_initialization.
2315
2316         * windows-nat.c (windows_nat_target): New class.
2317         (windows_fetch_inferior_registers)
2318         (windows_store_inferior_registers, windows_resume, windows_wait)
2319         (windows_attach, windows_detach, windows_pid_to_exec_file)
2320         (windows_files_info, windows_create_inferior)
2321         (windows_mourn_inferior, windows_interrupt, windows_kill_inferior)
2322         (windows_close, windows_pid_to_str, windows_xfer_partial)
2323         (windows_get_tib_address, windows_get_ada_task_ptid)
2324         (windows_thread_name, windows_thread_alive): Refactor as
2325         windows_nat_target methods.
2326         (do_initial_windows_stuff): Adjust.
2327         (windows_target): Delete function.
2328         (_initialize_windows_nat): Adjust.
2329
2330         * darwin-nat.c (darwin_resume, darwin_wait_to, darwin_interrupt)
2331         (darwin_mourn_inferior, darwin_kill_inferior)
2332         (darwin_create_inferior, darwin_attach, darwin_detach)
2333         (darwin_pid_to_str, darwin_thread_alive, darwin_xfer_partial)
2334         (darwin_pid_to_exec_file, darwin_get_ada_task_ptid)
2335         (darwin_supports_multi_process): Refactor as darwin_nat_target
2336         methods.
2337         (darwin_resume_to, darwin_files_info): Delete.
2338         (_initialize_darwin_inferior): Rename to ...
2339         (_initialize_darwin_nat): ... this.  Adjust to C++ification.
2340         * darwin-nat.h: Include "inf-child.h".
2341         (darwin_nat_target): New class.
2342         (darwin_complete_target): Delete.
2343         * i386-darwin-nat.c (i386_darwin_nat_target): New class.
2344         (darwin_target): New.
2345         (i386_darwin_fetch_inferior_registers)
2346         (i386_darwin_store_inferior_registers): Refactor as methods of
2347         darwin_nat_target.
2348         (darwin_complete_target): Delete, with ...
2349         (_initialize_i386_darwin_nat): ... bits factored out here.
2350
2351         * alpha-linux-nat.c (alpha_linux_nat_target): New class.
2352         (the_alpha_linux_nat_target): New.
2353         (alpha_linux_register_u_offset): Refactor as
2354         alpha_linux_nat_target method.
2355         (_initialize_alpha_linux_nat): Adjust.
2356         * linux-nat-trad.c (inf_ptrace_register_u_offset): Delete.
2357         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
2358         (inf_ptrace_store_register, inf_ptrace_store_registers): Refact as
2359         methods of linux_nat_trad_target.
2360         (linux_trad_target): Delete.
2361         * linux-nat-trad.h (linux_trad_target): Delete function.
2362         (linux_nat_trad_target): New class.
2363         * mips-linux-nat.c (mips_linux_nat_target): New class.
2364         (super_fetch_registers, super_store_registers, super_close):
2365         Delete.
2366         (the_mips_linux_nat_target): New.
2367         (mips64_linux_regsets_fetch_registers)
2368         (mips64_linux_regsets_store_registers)
2369         (mips64_linux_fetch_registers, mips64_linux_store_registers)
2370         (mips_linux_register_u_offset, mips_linux_read_description)
2371         (mips_linux_can_use_hw_breakpoint)
2372         (mips_linux_stopped_by_watchpoint)
2373         (mips_linux_stopped_data_address)
2374         (mips_linux_region_ok_for_hw_watchpoint)
2375         (mips_linux_insert_watchpoint, mips_linux_remove_watchpoint)
2376         (mips_linux_close): Refactor as methods of mips_linux_nat.
2377         (_initialize_mips_linux_nat): Adjust to C++ification.
2378
2379         * aix-thread.c (aix_thread_target): New class.
2380         (aix_thread_ops): Now an aix_thread_target.
2381         (aix_thread_detach, aix_thread_resume, aix_thread_wait)
2382         (aix_thread_fetch_registers, aix_thread_store_registers)
2383         (aix_thread_xfer_partial, aix_thread_mourn_inferior)
2384         (aix_thread_thread_alive, aix_thread_pid_to_str)
2385         (aix_thread_extra_thread_info, aix_thread_get_ada_task_ptid):
2386         Refactor as methods of aix_thread_target.
2387         (init_aix_thread_ops): Delete.
2388         (_initialize_aix_thread): Remove references to init_aix_thread_ops
2389         and complete_target_initialization.
2390         * rs6000-nat.c (rs6000_xfer_shared_libraries): Delete.
2391         (rs6000_nat_target): New class.
2392         (the_rs6000_nat_target): New.
2393         (rs6000_fetch_inferior_registers, rs6000_store_inferior_registers)
2394         (rs6000_xfer_partial, rs6000_wait, rs6000_create_inferior)
2395         (rs6000_xfer_shared_libraries): Refactor as rs6000_nat_target methods.
2396         (super_create_inferior): Delete.
2397         (_initialize_rs6000_nat): Adjust to C++ification.
2398
2399         * arm-linux-nat.c (arm_linux_nat_target): New class.
2400         (the_arm_linux_nat_target): New.
2401         (arm_linux_fetch_inferior_registers)
2402         (arm_linux_store_inferior_registers, arm_linux_read_description)
2403         (arm_linux_can_use_hw_breakpoint, arm_linux_insert_hw_breakpoint)
2404         (arm_linux_remove_hw_breakpoint)
2405         (arm_linux_region_ok_for_hw_watchpoint)
2406         (arm_linux_insert_watchpoint, arm_linux_remove_watchpoint)
2407         (arm_linux_stopped_data_address, arm_linux_stopped_by_watchpoint)
2408         (arm_linux_watchpoint_addr_within_range): Refactor as methods of
2409         arm_linux_nat_target.
2410         (_initialize_arm_linux_nat): Adjust to C++ification.
2411
2412         * aarch64-linux-nat.c (aarch64_linux_nat_target): New class.
2413         (the_aarch64_linux_nat_target): New.
2414         (aarch64_linux_fetch_inferior_registers)
2415         (aarch64_linux_store_inferior_registers)
2416         (aarch64_linux_child_post_startup_inferior)
2417         (aarch64_linux_read_description)
2418         (aarch64_linux_can_use_hw_breakpoint)
2419         (aarch64_linux_insert_hw_breakpoint)
2420         (aarch64_linux_remove_hw_breakpoint)
2421         (aarch64_linux_insert_watchpoint, aarch64_linux_remove_watchpoint)
2422         (aarch64_linux_region_ok_for_hw_watchpoint)
2423         (aarch64_linux_stopped_data_address)
2424         (aarch64_linux_stopped_by_watchpoint)
2425         (aarch64_linux_watchpoint_addr_within_range)
2426         (aarch64_linux_can_do_single_step): Refactor as methods of
2427         aarch64_linux_nat_target.
2428         (super_post_startup_inferior): Delete.
2429         (_initialize_aarch64_linux_nat): Adjust to C++ification.
2430
2431         * hppa-linux-nat.c (hppa_linux_nat_target): New class.
2432         (the_hppa_linux_nat_target): New.
2433         (hppa_linux_fetch_inferior_registers)
2434         (hppa_linux_store_inferior_registers): Refactor as methods of
2435         hppa_linux_nat_target.
2436         (_initialize_hppa_linux_nat): Adjust to C++ification.
2437
2438         * ia64-linux-nat.c (ia64_linux_nat_target): New class.
2439         (the_ia64_linux_nat_target): New.
2440         (ia64_linux_insert_watchpoint, ia64_linux_remove_watchpoint)
2441         (ia64_linux_stopped_data_address)
2442         (ia64_linux_stopped_by_watchpoint, ia64_linux_fetch_registers)
2443         (ia64_linux_store_registers, ia64_linux_xfer_partial): Refactor as
2444         ia64_linux_nat_target methods.
2445         (super_xfer_partial): Delete.
2446         (_initialize_ia64_linux_nat): Adjust to C++ification.
2447
2448         * m32r-linux-nat.c (m32r_linux_nat_target): New class.
2449         (the_m32r_linux_nat_target): New.
2450         (m32r_linux_fetch_inferior_registers)
2451         (m32r_linux_store_inferior_registers): Refactor as
2452         m32r_linux_nat_target methods.
2453         (_initialize_m32r_linux_nat): Adjust to C++ification.
2454
2455         * m68k-linux-nat.c (m68k_linux_nat_target): New class.
2456         (the_m68k_linux_nat_target): New.
2457         (m68k_linux_fetch_inferior_registers)
2458         (m68k_linux_store_inferior_registers): Refactor as
2459         m68k_linux_nat_target methods.
2460         (_initialize_m68k_linux_nat): Adjust to C++ification.
2461
2462         * s390-linux-nat.c (s390_linux_nat_target): New class.
2463         (the_s390_linux_nat_target): New.
2464         (s390_linux_fetch_inferior_registers)
2465         (s390_linux_store_inferior_registers, s390_stopped_by_watchpoint)
2466         (s390_insert_watchpoint, s390_remove_watchpoint)
2467         (s390_can_use_hw_breakpoint, s390_insert_hw_breakpoint)
2468         (s390_remove_hw_breakpoint, s390_region_ok_for_hw_watchpoint)
2469         (s390_auxv_parse, s390_read_description): Refactor as methods of
2470         s390_linux_nat_target.
2471         (_initialize_s390_nat): Adjust to C++ification.
2472
2473         * sparc-linux-nat.c (sparc_linux_nat_target): New class.
2474         (the_sparc_linux_nat_target): New.
2475         (_initialize_sparc_linux_nat): Adjust to C++ification.
2476         * sparc-nat.c (sparc_fetch_inferior_registers)
2477         (sparc_store_inferior_registers): Remove target_ops parameter.
2478         * sparc-nat.h (sparc_fetch_inferior_registers)
2479         (sparc_store_inferior_registers): Remove target_ops parameter.
2480         * sparc64-linux-nat.c (sparc64_linux_nat_target): New class.
2481         (the_sparc64_linux_nat_target): New.
2482         (_initialize_sparc64_linux_nat): Adjust to C++ification.
2483
2484         * spu-linux-nat.c (spu_linux_nat_target): New class.
2485         (the_spu_linux_nat_target): New.
2486         (spu_child_post_startup_inferior, spu_child_post_attach)
2487         (spu_child_wait, spu_fetch_inferior_registers)
2488         (spu_store_inferior_registers, spu_xfer_partial)
2489         (spu_can_use_hw_breakpoint): Refactor as spu_linux_nat_target
2490         methods.
2491         (_initialize_spu_nat): Adjust to C++ification.
2492
2493         * tilegx-linux-nat.c (tilegx_linux_nat_target): New class.
2494         (the_tilegx_linux_nat_target): New.
2495         (fetch_inferior_registers, store_inferior_registers):
2496         Refactor as methods.
2497         (_initialize_tile_linux_nat): Adjust to C++ification.
2498
2499         * xtensa-linux-nat.c (xtensa_linux_nat_target): New class.
2500         (the_xtensa_linux_nat_target): New.
2501         (xtensa_linux_fetch_inferior_registers)
2502         (xtensa_linux_store_inferior_registers): Refactor as
2503         xtensa_linux_nat_target methods.
2504         (_initialize_xtensa_linux_nat): Adjust to C++ification.
2505
2506         * fbsd-nat.c (USE_SIGTRAP_SIGINFO): Delete.
2507         (fbsd_pid_to_exec_file, fbsd_find_memory_regions)
2508         (fbsd_find_memory_regions, fbsd_info_proc, fbsd_xfer_partial)
2509         (fbsd_thread_alive, fbsd_pid_to_str, fbsd_thread_name)
2510         (fbsd_update_thread_list, fbsd_resume, fbsd_wait)
2511         (fbsd_stopped_by_sw_breakpoint)
2512         (fbsd_supports_stopped_by_sw_breakpoint, fbsd_follow_fork)
2513         (fbsd_insert_fork_catchpoint, fbsd_remove_fork_catchpoint)
2514         (fbsd_insert_vfork_catchpoint, fbsd_remove_vfork_catchpoint)
2515         (fbsd_post_startup_inferior, fbsd_post_attach)
2516         (fbsd_insert_exec_catchpoint, fbsd_remove_exec_catchpoint)
2517         (fbsd_set_syscall_catchpoint)
2518         (super_xfer_partial, super_resume, super_wait)
2519         (fbsd_supports_stopped_by_hw_breakpoint): Delete.
2520         (fbsd_handle_debug_trap): Remove target_ops parameter.
2521         (fbsd_nat_add_target): Delete.
2522         * fbsd-nat.h: Include "inf-ptrace.h".
2523         (fbsd_nat_add_target): Delete.
2524         (USE_SIGTRAP_SIGINFO): Define.
2525         (fbsd_nat_target): New class.
2526
2527         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers)
2528         (amd64bsd_store_inferior_registers): Remove target_ops parameter.
2529         (amd64bsd_target): Delete.
2530         * amd64-bsd-nat.h: New file.
2531         * amd64-fbsd-nat.c: Include "amd64-bsd-nat.h" instead of
2532         "x86-bsd-nat.h".
2533         (amd64_fbsd_nat_target): New class.
2534         (the_amd64_fbsd_nat_target): New.
2535         (amd64fbsd_read_description): Refactor as method of
2536         amd64_fbsd_nat_target.
2537         (amd64_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
2538         (_initialize_amd64fbsd_nat): Adjust to C++ification.
2539         * amd64-nat.h (amd64bsd_target): Delete function declaration.
2540         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers)
2541         (i386bsd_store_inferior_registers): Remove target_ops parameter.
2542         (i386bsd_target): Delete.
2543         * i386-bsd-nat.h (i386bsd_target): Delete function declaration.
2544         (i386bsd_fetch_inferior_registers)
2545         (i386bsd_store_inferior_registers): Declare.
2546         (i386_bsd_nat_target): New class.
2547         * i386-fbsd-nat.c (i386_fbsd_nat_target): New class.
2548         (the_i386_fbsd_nat_target): New.
2549         (i386fbsd_resume, i386fbsd_read_description): Refactor as
2550         i386_fbsd_nat_target methods.
2551         (i386_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
2552         (_initialize_i386fbsd_nat): Adjust to C++ification.
2553         * x86-bsd-nat.c (super_mourn_inferior): Delete.
2554         (x86bsd_mourn_inferior, x86bsd_target): Delete.
2555         (_initialize_x86_bsd_nat): Adjust to C++ification.
2556         * x86-bsd-nat.h: Include "x86-nat.h".
2557         (x86bsd_target): Delete declaration.
2558         (x86bsd_nat_target): New class.
2559
2560         * aarch64-fbsd-nat.c (aarch64_fbsd_nat_target): New class.
2561         (the_aarch64_fbsd_nat_target): New.
2562         (aarch64_fbsd_fetch_inferior_registers)
2563         (aarch64_fbsd_store_inferior_registers): Refactor as methods of
2564         aarch64_fbsd_nat_target.
2565         (_initialize_aarch64_fbsd_nat): Adjust to C++ification.
2566         * alpha-bsd-nat.c (alpha_bsd_nat_target): New class.
2567         (the_alpha_bsd_nat_target): New.
2568         (alphabsd_fetch_inferior_registers)
2569         (alphabsd_store_inferior_registers): Refactor as
2570         alpha_bsd_nat_target methods.
2571         (_initialize_alphabsd_nat): Refactor as methods of
2572         alpha_bsd_nat_target.
2573         * amd64-nbsd-nat.c: Include "amd64-bsd-nat.h".
2574         (the_amd64_nbsd_nat_target): New.
2575         (_initialize_amd64nbsd_nat): Adjust to C++ification.
2576         * amd64-obsd-nat.c: Include "amd64-bsd-nat.h".
2577         (the_amd64_obsd_nat_target): New.
2578         (_initialize_amd64obsd_nat): Adjust to C++ification.
2579         * arm-fbsd-nat.c (arm_fbsd_nat_target): New.
2580         (the_arm_fbsd_nat_target): New.
2581         (arm_fbsd_fetch_inferior_registers)
2582         (arm_fbsd_store_inferior_registers, arm_fbsd_read_description):
2583         (_initialize_arm_fbsd_nat): Refactor as methods of
2584         arm_fbsd_nat_target.
2585         (_initialize_arm_fbsd_nat): Adjust to C++ification.
2586         * arm-nbsd-nat.c (arm_netbsd_nat_target): New class.
2587         (the_arm_netbsd_nat_target): New.
2588         (armnbsd_fetch_registers, armnbsd_store_registers): Refactor as
2589         arm_netbsd_nat_target.
2590         (_initialize_arm_netbsd_nat): Adjust to C++ification.
2591         * hppa-nbsd-nat.c (hppa_nbsd_nat_target): New class.
2592         (the_hppa_nbsd_nat_target): New.
2593         (hppanbsd_fetch_registers, hppanbsd_store_registers): Refactor as
2594         hppa_nbsd_nat_target methods.
2595         (_initialize_hppanbsd_nat): Adjust to C++ification.
2596         * hppa-obsd-nat.c (hppa_obsd_nat_target): New class.
2597         (the_hppa_obsd_nat_target): New.
2598         (hppaobsd_fetch_registers, hppaobsd_store_registers): Refactor as
2599         methods of hppa_obsd_nat_target.
2600         (_initialize_hppaobsd_nat): Adjust to C++ification.  Use
2601         add_target.
2602         * i386-nbsd-nat.c (the_i386_nbsd_nat_target): New.
2603         (_initialize_i386nbsd_nat): Adjust to C++ification.  Use
2604         add_target.
2605         * i386-obsd-nat.c (the_i386_obsd_nat_target): New.
2606         (_initialize_i386obsd_nat): Use add_target.
2607         * m68k-bsd-nat.c (m68k_bsd_nat_target): New class.
2608         (the_m68k_bsd_nat_target): New.
2609         (m68kbsd_fetch_inferior_registers)
2610         (m68kbsd_store_inferior_registers): Refactor as methods of
2611         m68k_bsd_nat_target.
2612         (_initialize_m68kbsd_nat): Adjust to C++ification.
2613         * mips-fbsd-nat.c (mips_fbsd_nat_target): New class.
2614         (the_mips_fbsd_nat_target): New.
2615         (mips_fbsd_fetch_inferior_registers)
2616         (mips_fbsd_store_inferior_registers): Refactor as methods of
2617         mips_fbsd_nat_target.
2618         (_initialize_mips_fbsd_nat): Adjust to C++ification.  Use
2619         add_target.
2620         * mips-nbsd-nat.c (mips_nbsd_nat_target): New class.
2621         (the_mips_nbsd_nat_target): New.
2622         (mipsnbsd_fetch_inferior_registers)
2623         (mipsnbsd_store_inferior_registers): Refactor as methods of
2624         mips_nbsd_nat_target.
2625         (_initialize_mipsnbsd_nat): Adjust to C++ification.
2626         * mips64-obsd-nat.c (mips64_obsd_nat_target): New class.
2627         (the_mips64_obsd_nat_target): New.
2628         (mips64obsd_fetch_inferior_registers)
2629         (mips64obsd_store_inferior_registers): Refactor as methods of
2630         mips64_obsd_nat_target.
2631         (_initialize_mips64obsd_nat): Adjust to C++ification.  Use
2632         add_target.
2633         * nbsd-nat.c (nbsd_pid_to_exec_file): Refactor as method of
2634         nbsd_nat_target.
2635         * nbsd-nat.h: Include "inf-ptrace.h".
2636         (nbsd_nat_target): New class.
2637         * obsd-nat.c (obsd_pid_to_str, obsd_update_thread_list)
2638         (obsd_wait): Refactor as methods of obsd_nat_target.
2639         (obsd_add_target): Delete.
2640         * obsd-nat.h: Include "inf-ptrace.h".
2641         (obsd_nat_target): New class.
2642         * ppc-fbsd-nat.c (ppc_fbsd_nat_target): New class.
2643         (the_ppc_fbsd_nat_target): New.
2644         (ppcfbsd_fetch_inferior_registers)
2645         (ppcfbsd_store_inferior_registers): Refactor as methods of
2646         ppc_fbsd_nat_target.
2647         (_initialize_ppcfbsd_nat): Adjust to C++ification.  Use
2648         add_target.
2649         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): New class.
2650         (the_ppc_nbsd_nat_target): New.
2651         (ppcnbsd_fetch_inferior_registers)
2652         (ppcnbsd_store_inferior_registers): Refactor as methods of
2653         ppc_nbsd_nat_target.
2654         (_initialize_ppcnbsd_nat): Adjust to C++ification.
2655         * ppc-obsd-nat.c (ppc_obsd_nat_target): New class.
2656         (the_ppc_obsd_nat_target): New.
2657         (ppcobsd_fetch_registers, ppcobsd_store_registers): Refactor as
2658         methods of ppc_obsd_nat_target.
2659         (_initialize_ppcobsd_nat): Adjust to C++ification.  Use
2660         add_target.
2661         * sh-nbsd-nat.c (sh_nbsd_nat_target): New class.
2662         (the_sh_nbsd_nat_target): New.
2663         (shnbsd_fetch_inferior_registers)
2664         (shnbsd_store_inferior_registers): Refactor as methods of
2665         sh_nbsd_nat_target.
2666         (_initialize_shnbsd_nat): Adjust to C++ification.
2667         * sparc-nat.c (sparc_xfer_wcookie): Make extern.
2668         (inf_ptrace_xfer_partial): Delete.
2669         (sparc_xfer_partial, sparc_target): Delete.
2670         * sparc-nat.h (sparc_fetch_inferior_registers)
2671         (sparc_store_inferior_registers, sparc_xfer_wcookie): Declare.
2672         (sparc_target): Delete function declaration.
2673         (sparc_target): New template class.
2674         * sparc-nbsd-nat.c (the_sparc_nbsd_nat_target): New.
2675         (_initialize_sparcnbsd_nat): Adjust to C++ification.
2676         * sparc64-fbsd-nat.c (the_sparc64_fbsd_nat_target): New.
2677         (_initialize_sparc64fbsd_nat): Adjust to C++ification.  Use
2678         add_target.
2679         * sparc64-nbsd-nat.c (the_sparc64_nbsd_nat_target): New.
2680         (_initialize_sparc64nbsd_nat): Adjust to C++ification.
2681         * sparc64-obsd-nat.c (the_sparc64_obsd_nat_target): New.
2682         (_initialize_sparc64obsd_nat): Adjust to C++ification.  Use
2683         add_target.
2684         * vax-bsd-nat.c (vax_bsd_nat_target): New class.
2685         (the_vax_bsd_nat_target): New.
2686         (vaxbsd_fetch_inferior_registers)
2687         (vaxbsd_store_inferior_registers): Refactor as vax_bsd_nat_target
2688         methods.
2689         (_initialize_vaxbsd_nat): Adjust to C++ification.
2690
2691         * bsd-kvm.c (bsd_kvm_target): New class.
2692         (bsd_kvm_ops): Now a bsd_kvm_target.
2693         (bsd_kvm_open, bsd_kvm_close, bsd_kvm_xfer_partial)
2694         (bsd_kvm_files_info, bsd_kvm_fetch_registers)
2695         (bsd_kvm_thread_alive, bsd_kvm_pid_to_str): Refactor as methods of
2696         bsd_kvm_target.
2697         (bsd_kvm_return_one): Delete.
2698         (bsd_kvm_add_target): Adjust to C++ification.
2699
2700         * nto-procfs.c (nto_procfs_target, nto_procfs_target_native)
2701         (nto_procfs_target_procfs): New classes.
2702         (procfs_open_1, procfs_thread_alive, procfs_update_thread_list)
2703         (procfs_files_info, procfs_pid_to_exec_file, procfs_attach)
2704         (procfs_post_attach, procfs_wait, procfs_fetch_registers)
2705         (procfs_xfer_partial, procfs_detach, procfs_insert_breakpoint)
2706         (procfs_remove_breakpoint, procfs_insert_hw_breakpoint)
2707         (procfs_remove_hw_breakpoint, procfs_resume)
2708         (procfs_mourn_inferior, procfs_create_inferior, procfs_interrupt)
2709         (procfs_kill_inferior, procfs_store_registers)
2710         (procfs_pass_signals, procfs_pid_to_str, procfs_can_run): Refactor
2711         as methods of nto_procfs_target.
2712         (nto_procfs_ops): Now an nto_procfs_target_procfs.
2713         (nto_native_ops): Delete.
2714         (procfs_open, procfs_native_open): Delete.
2715         (nto_native_ops): Now an nto_procfs_target_native.
2716         (init_procfs_targets): Adjust to C++ification.
2717         (procfs_can_use_hw_breakpoint, procfs_remove_hw_watchpoint)
2718         (procfs_insert_hw_watchpoint, procfs_stopped_by_watchpoint):
2719         Refactor as methods of nto_procfs_target.
2720
2721         * go32-nat.c (go32_nat_target): New class.
2722         (the_go32_nat_target): New.
2723         (go32_attach, go32_resume, go32_wait, go32_fetch_registers)
2724         (go32_store_registers, go32_xfer_partial, go32_files_info)
2725         (go32_kill_inferior, go32_create_inferior, go32_mourn_inferior)
2726         (go32_terminal_init, go32_terminal_info, go32_terminal_inferior)
2727         (go32_terminal_ours, go32_pass_ctrlc, go32_thread_alive)
2728         (go32_pid_to_str): Refactor as methods of go32_nat_target.
2729         (go32_target): Delete.
2730         (_initialize_go32_nat): Adjust to C++ification.
2731
2732         * gnu-nat.c (gnu_wait, gnu_resume, gnu_kill_inferior)
2733         (gnu_mourn_inferior, gnu_create_inferior, gnu_attach, gnu_detach)
2734         (gnu_stop, gnu_thread_alive, gnu_xfer_partial)
2735         (gnu_find_memory_regions, gnu_pid_to_str): Refactor as methods of
2736         gnu_nat_target.
2737         (gnu_target): Delete.
2738         * gnu-nat.h (gnu_target): Delete.
2739         (gnu_nat_target): New class.
2740         * i386-gnu-nat.c (gnu_base_target): New.
2741         (i386_gnu_nat_target): New class.
2742         (the_i386_gnu_nat_target): New.
2743         (_initialize_i386gnu_nat): Adjust to C++ification.
2744
2745 2018-05-02  Pedro Alves  <palves@redhat.com>
2746
2747         * bfd-target.c (target_bfd_xclose): Rename to ...
2748         (target_bfd_close): ... this.
2749         (target_bfd_reopen): Adjust.
2750         * target.c (target_close): Remove references to to_xclose.
2751         * target.h (target_ops::to_xclose): Delete.
2752         (target_ops::to_close): Update comments.
2753
2754 2018-05-02  Pedro Alves  <palves@redhat.com>
2755
2756         * alpha-linux-nat.c: Include "linux-nat-trad.h" instead of
2757         "linux-nat.h".
2758         * configure.nat (alpha-linux, linux-mips): Add linux-nat-trad.o.
2759         * inf-ptrace.c (inf_ptrace_register_u_offset)
2760         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
2761         (inf_ptrace_store_register, inf_ptrace_store_registers)
2762         (inf_ptrace_trad_target): Move to ...
2763         * linux-nat-trad.c: ... this new file.
2764         * linux-nat-trad.h: New file.
2765         * linux-nat.c (linux_target_install_ops): Make extern.
2766         (linux_trad_target): Delete.
2767         * linux-nat.h (linux_trad_target): Delete declaration.
2768         (linux_target_install_ops): Declare.
2769         * mips-linux-nat.c: Include "linux-nat-trad.h" instead of
2770         "linux-nat.h".
2771
2772 2018-05-02  Pedro Alves  <palves@redhat.com>
2773
2774         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
2775         procfs_target/add_target here.
2776         * procfs.c (procfs_target): Make static.
2777         (_initialize_procfs): Call add_target here.
2778         * procfs.h (struct target_ops): Remove forward declaration.
2779         (procfs_target): Remove declaration.
2780         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Delete.
2781
2782 2018-05-02  Pedro Alves  <palves@redhat.com>
2783
2784         * procfs.c (procfs_stopped_by_watchpoint)
2785         (procfs_insert_watchpoint, procfs_remove_watchpoint)
2786         (procfs_region_ok_for_hw_watchpoint, procfs_stopped_data_address):
2787         Forward declare.
2788         (procfs_use_watchpoints): Delete, move contents...
2789         (procfs_target): ... here.
2790         * procfs.h (procfs_use_watchpoints): Delete declaration.
2791         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
2792         procfs_use_watchpoints.
2793         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Don't call
2794         procfs_use_watchpoints.
2795
2796 2018-05-02  Tom Tromey  <tom@tromey.com>
2797
2798         PR python/20084:
2799         * python/python.c (gdbpy_parameter_value): Handle var_zuinteger
2800         and var_zuinteger_unlimited.
2801         * python/py-param.c (struct parm_constant): Add PARAM_ZUINTEGER
2802         and PARAM_ZUINTEGER_UNLIMITED.
2803         (set_parameter_value): Handle var_zuinteger and
2804         var_zuinteger_unlimited.
2805         (add_setshow_generic): Likewise.
2806         (parmpy_init): Likewise.
2807
2808 2018-04-28  Dan Robertson  <danlrobertson89@gmail.com>
2809
2810         PR rust/23124
2811         * gdb/rust-exp.y (convert_params_to_types): Ensure that the params
2812         pointer is not null before dereferencing it.
2813
2814 2018-04-30  Tom Tromey  <tom@tromey.com>
2815
2816         * darwin-nat-info.c (darwin_debug_regions_recurse): Remove use of
2817         is_mi_like_p.
2818
2819 2018-04-30  Tom Tromey  <tom@tromey.com>
2820
2821         * breakpoint.c (mention): Remove use of is_mi_like_p.
2822         (print_mention_ranged_breakpoint): Likewise.
2823         * break-catch-throw.c (print_it_exception_catchpoint): Remove use
2824         of is_mi_like_p.
2825
2826 2018-04-30  Tom Tromey  <tom@tromey.com>
2827
2828         * tracepoint.c (tvariables_info_1): Remove use of is_mi_like_p.
2829
2830 2018-04-30  Tom Tromey  <tom@tromey.com>
2831
2832         * spu-tdep.c (info_spu_mailbox_list, info_spu_dma_cmdlist)
2833         (info_spu_event_command): Remove some uses of is_mi_like_p.
2834
2835 2018-04-30  Tom Tromey  <tom@tromey.com>
2836
2837         * python/py-framefilter.c (py_print_single_arg)
2838         (enumerate_locals, py_print_args, py_print_frame): Remove some
2839         uses of is_mi_like_p.
2840
2841 2018-04-30  Tom Tromey  <tom@tromey.com>
2842
2843         * ui-out.c: Update.
2844         * cli-out.h (cli_ui_out::do_is_mi_like_p): Update.
2845         * ui-out.h (ui_out::is_mi_like_p): Now const.
2846         (ui_out::do_is_mi_like_p): Now const.
2847         * mi/mi-out.h (mi_ui_out::do_is_mi_like_p): Update.
2848
2849 2018-04-30  Tom Tromey  <tom@tromey.com>
2850
2851         * varobj.c (varobj_set_visualizer): Use new_reference.
2852         * python/python.c (gdbpy_decode_line): Use new_reference.
2853         * python/py-cmd.c (cmdpy_function, cmdpy_completer_helper): Use
2854         new_reference.
2855
2856 2018-04-30  Tom Tromey  <tom@tromey.com>
2857
2858         * varobj.c (install_new_value): Use new_reference.
2859         * value.h (value_incref): Return void.  Swap intro comment with
2860         value_decref.
2861         * value.c (set_value_parent): Use new_reference.
2862         (value_incref): Return void.  Update intro comment.
2863         (release_value): Use new_reference.
2864         * dwarf2loc.c (dwarf2_evaluate_loc_desc_full): Use new_reference.
2865
2866 2018-04-30  Tom Tromey  <tom@tromey.com>
2867
2868         * symfile-mem.c (symbol_file_add_from_memory): Use new_reference.
2869         * gdb_bfd.h (new_bfd_ref): Remove.
2870         (gdb_bfd_open): Update comment.
2871         * gdb_bfd.c (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr)
2872         (gdb_bfd_openw, gdb_bfd_openr_iovec, gdb_bfd_record_inclusion)
2873         (gdb_bfd_fdopenr): Use new_reference.
2874         * exec.c (exec_file_attach): Use new_reference.
2875
2876 2018-04-30  Tom Tromey  <tom@tromey.com>
2877
2878         * common/gdb_ref_ptr.h (ref_ptr::new_reference): New static
2879         method.
2880
2881 2018-04-30  Tom Tromey  <tom@tromey.com>
2882
2883         * jit.c (jit_read_code_entry): Use type_align.
2884         * i386-tdep.c (i386_gdbarch_init): Don't call
2885         set_gdbarch_long_long_align_bit.
2886         * gdbarch.sh: Remove long_long_align_bit.
2887         * gdbarch.c, gdbarch.h: Rebuild.
2888         * arc-tdep.c (arc_type_align): New function.
2889         (arc_gdbarch_init): Use arc_type_align.  Don't call
2890         set_gdbarch_long_long_align_bit.
2891
2892 2018-04-30  Tom Tromey  <tom@tromey.com>
2893
2894         * rust-lang.c (rust_type_alignment): Remove.
2895         (rust_composite_type): Use type_align.
2896
2897 2018-04-30  Tom Tromey  <tom@tromey.com>
2898
2899         * NEWS: Mention Type.align.
2900         * python/py-type.c (typy_get_alignof): New function.
2901         (type_object_getset): Add "alignof".
2902
2903 2018-04-30  Tom Tromey  <tom@tromey.com>
2904
2905         PR exp/17095:
2906         * NEWS: Update.
2907         * std-operator.def (UNOP_ALIGNOF): New operator.
2908         * expprint.c (dump_subexp_body_standard) <case UNOP_ALIGNOF>:
2909         New.
2910         * eval.c (evaluate_subexp_standard) <case UNOP_ALIGNOF>: New.
2911         * c-lang.c (c_op_print_tab): Add alignof.
2912         * c-exp.y (ALIGNOF): New token.
2913         (exp): Add "ALIGNOF" production.
2914         (ident_tokens): Add _Alignof and alignof.
2915
2916 2018-04-30  Tom Tromey  <tom@tromey.com>
2917
2918         * i386-tdep.c (i386_type_align): New function.
2919         (i386_gdbarch_init): Update.
2920         * gdbarch.sh (type_align): New method.
2921         * gdbarch.c, gdbarch.h: Rebuild.
2922         * arch-utils.h (default_type_align): Declare.
2923         * arch-utils.c (default_type_align): New function.
2924         * gdbtypes.h (TYPE_ALIGN_BITS): New define.
2925         (struct type) <align_log2>: New field.
2926         <instance_flags>: Now a bitfield.
2927         (TYPE_RAW_ALIGN): New macro.
2928         (type_align, type_raw_align, set_type_align): Declare.
2929         * gdbtypes.c (type_align, type_raw_align, set_type_align): New
2930         functions.
2931         * dwarf2read.c (quirk_rust_enum): Set type alignment.
2932         (get_alignment, maybe_set_alignment): New functions.
2933         (read_structure_type, read_enumeration_type, read_array_type)
2934         (read_set_type, read_tag_pointer_type, read_tag_reference_type)
2935         (read_subrange_type, read_base_type): Set type alignment.
2936
2937 2018-04-30  Simon Marchi  <simon.marchi@ericsson.com>
2938
2939         * dwarf2read.c (read_index_from_section): Use bool.
2940
2941 2018-04-29  Fabian Groffen  <grobian@gentoo.org>
2942
2943         PR gdb/22950
2944         * proc-events.c (init_syscall_table): Guard usage os SYS_uuidsys
2945         with #ifdef.
2946
2947 2018-04-29  John Reiser  <jreiser@BitWagon.com>
2948
2949         PR build/22873
2950         * gdb/Makefile.in: (.c:.l, .c:.y): Write the target only in the
2951         last step, and do it atomically.
2952
2953 2018-04-27  Alexandre Oliva  <aoliva@redhat.com>
2954
2955         * compile/compile-c-types.c (convert_int, convert_float):
2956         Update for C FE v1.
2957
2958 2018-04-27  Tom Tromey  <tom@tromey.com>
2959
2960         PR rust/22545:
2961         * rust-lang.c (rust_inclusive_range_type_p): New function.
2962         (rust_range): Handle inclusive ranges.
2963         (rust_compute_range): Likewise.
2964         * rust-exp.y (struct rust_op) <inclusive>: New field.
2965         (DOTDOTEQ): New constant.
2966         (range_expr): Add "..=" productions.
2967         (operator_tokens): Add "..=" token.
2968         (ast_range): Add "inclusive" parameter.
2969         (convert_ast_to_expression) <case OP_RANGE>: Handle inclusive
2970         ranges.
2971         * parse.c (operator_length_standard) <case OP_RANGE>: Handle new
2972         bounds values.
2973         * expression.h (enum range_type) <NONE_BOUND_DEFAULT_EXCLUSIVE,
2974         LOW_BOUND_DEFAULT_EXCLUSIVE>: New constants.
2975         Update comments.
2976         * expprint.c (print_subexp_standard): Handle new bounds values.
2977         (dump_subexp_body_standard): Likewise.
2978
2979 2018-04-27  Tom Tromey  <tom@tromey.com>
2980
2981         * configure: Rebuild.
2982         * warning.m4 (AM_GDB_WARNINGS): Add -Wsuggest-override.
2983         * dwarf2loc.c (class dwarf_evaluate_loc_desc): Use "override", not
2984         "OVERRIDE".
2985         (class symbol_needs_eval_context): Likewise.
2986         * dwarf2read.c (mock_mapped_index::symbol_name_count)
2987         (mock_mapped_index::symbol_name_at): Use "override".  Remove
2988         "virtual".
2989         * dwarf2-frame.c (dwarf_expr_executor::get_addr_index): Use
2990         "override".
2991         (class dwarf_expr_executor): Use "override", not "OVERRIDE".
2992         * aarch64-tdep.c (instruction_reader::read): Use "override".
2993         (instruction_reader_test::read): Likewise.
2994         * arm-tdep.c (instruction_reader::read): Use "override".
2995         (instruction_reader_thumb::read): Likewise.
2996
2997 2018-04-26  Andrzej Kaczmarek  <andrzej.kaczmarek@codecoup.pl>
2998
2999         PR remote/9665
3000         * remote.c (send_g_packet): Use putpkt/getpkt/packet_check_result
3001         instead of remote_send.
3002         (remote_send): Remove.
3003
3004 2018-04-26  Pedro Alves  <palves@redhat.com>
3005
3006         * elfread.c (elf_gnu_ifunc_resolver_return_stop): Use
3007         find_function_start_sal instead of find_pc_line.
3008
3009 2018-04-26  Pedro Alves  <palves@redhat.com>
3010
3011         * breakpoint.c (set_breakpoint_location_function): Handle
3012         mst_data_gnu_ifunc.
3013         * c-exp.y (variable production): Handle mst_data_gnu_ifunc.
3014         * elfread.c (elf_symtab_read): Give data symbols with
3015         BSF_GNU_INDIRECT_FUNCTION set mst_data_gnu_ifunc type.
3016         (elf_rel_plt_read): Update comment.
3017         * linespec.c (convert_linespec_to_sals): Handle
3018         mst_data_gnu_ifunc.
3019         (minsym_found): Handle mst_data_gnu_ifunc.
3020         * minsyms.c (msymbol_is_function, minimal_symbol_reader::record)
3021         (find_solib_trampoline_target): Handle mst_data_gnu_ifunc.
3022         * parse.c (find_minsym_type_and_address): Handle
3023         mst_data_gnu_ifunc.
3024         * symmisc.c (dump_msymbols): Handle mst_data_gnu_ifunc.
3025         * symtab.c (find_gnu_ifunc): Handle mst_data_gnu_ifunc.
3026         * symtab.h (minimal_symbol_type) <mst_text_gnu_ifunc>: Update
3027         comment.
3028         <mst_data_gnu_ifunc>: New enumerator.
3029
3030 2018-04-26  Pedro Alves  <palves@redhat.com>
3031
3032         * minsyms.c (lookup_minimal_symbol_by_pc_section_1): Rename to ...
3033         (lookup_minimal_symbol_by_pc_section): ... this.  Replace
3034         'want_trampoline' parameter by a lookup_msym_prefer parameter.
3035         Handle it.
3036         (lookup_minimal_symbol_by_pc_section): Delete old implementation.
3037         (lookup_minimal_symbol_by_pc): Adjust.
3038         (in_gnu_ifunc_stub): Prefer GNU ifunc symbols.
3039         (lookup_solib_trampoline_symbol_by_pc): Adjust.
3040         * minsyms.h (lookup_msym_prefer): New enum.
3041         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
3042         parameter by a lookup_msym_prefer parameter.
3043
3044 2018-04-26  Pedro Alves  <palves@redhat.com>
3045
3046         * elfread.c (elf_gnu_ifunc_record_cache): Check if the symbol name
3047         ends in "@plt" instead of looking at the symbol's section.
3048
3049 2018-04-26  Pedro Alves  <palves@redhat.com>
3050
3051         * blockframe.c (cache_pc_function_is_gnu_ifunc): Delete.  Remove
3052         all references.
3053         (find_pc_partial_function_gnu_ifunc): Rename to ...
3054         (find_pc_partial_function): ... this, and remove references to
3055         'is_gnu_ifunc_p'.
3056         (find_pc_partial_function): Delete old implementation.
3057         * symtab.h (find_pc_partial_function_gnu_ifunc): Delete.
3058
3059 2018-04-26  Pedro Alves  <palves@redhat.com>
3060
3061         * linespec.c (struct bound_minimal_symbol_search_key): New.
3062         (convert_linespec_to_sals): Sort minimal symbols earlier.  Don't
3063         skip first line if we found a GNU ifunc minimal symbol by name.
3064         (compare_msymbols): Change parameters to work with a destructured
3065         lhs minsym.
3066         (compare_msymbols_for_qsort, compare_msymbols_for_bsearch): New
3067         functions.
3068
3069 2018-04-26  Pedro Alves  <palves@redhat.com>
3070
3071         * breakpoint.c (set_breakpoint_location_function): Don't resolve
3072         ifunc targets here.  Instead, if we have an ifunc minsym, use its
3073         address/name.
3074         (add_location_to_breakpoint): Store the minsym and the objfile in
3075         the breakpoint location.
3076         * breakpoint.h (bp_location) <msymbol, objfile>: New fields.
3077         * linespec.c (minsym_found): Resolve GNU ifunc targets here.
3078         Record the minsym in the sal.
3079         * symtab.h (symtab_and_line) <msymbol>: New field.
3080
3081 2018-04-26  Pedro Alves  <palves@redhat.com>
3082
3083         * elfread.c (elf_gnu_ifunc_resolve_by_got): Don't write to *ADDR_P
3084         unless we actually resolved the ifunc.
3085
3086 2018-04-26  Pedro Alves  <palves@redhat.com>
3087
3088         * c-exp.y (variable production): Prefer ifunc minsyms over
3089         regular function symbols.
3090         * symtab.c (find_gnu_ifunc): New function.
3091         * minsyms.h (lookup_msym_prefer): New enum.
3092         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
3093         parameter by a lookup_msym_prefer parameter.
3094         * symtab.h (find_gnu_ifunc): New declaration.
3095
3096 2018-04-26  Pedro Alves  <palves@redhat.com>
3097
3098         * blockframe.c (find_gnu_ifunc_target_type): New function.
3099         (find_function_type): New.
3100         * eval.c (evaluate_var_msym_value): For GNU ifunc types, always
3101         return a value with a memory address.
3102         (eval_call): For calls to GNU ifunc functions, try to find the
3103         type of the target function from the type that the resolver
3104         returns.
3105         * gdbtypes.c (objfile_type): Don't install a return type for ifunc
3106         symbols.
3107         * infcall.c (find_function_return_type): Delete.
3108         (find_function_addr): Add 'function_type' parameter.  For calls to
3109         GNU ifunc functions, try to find the type of the target function
3110         from the type that the resolver returns, and return it via
3111         FUNCTION_TYPE.
3112         (call_function_by_hand_dummy): Adjust to use the function type
3113         returned by find_function_addr.
3114         (find_function_addr): Add 'function_type' parameter and move
3115         description here.
3116         * symtab.h (find_function_type, find_gnu_ifunc_target_type): New
3117         declarations.
3118
3119 2018-04-26  Pedro Alves  <palves@redhat.com>
3120
3121         * c-exp.y (variable production): Skip finding an alias for ifunc
3122         symbols.
3123
3124 2018-04-26  Pedro Alves  <palves@redhat.com>
3125
3126         * elfread.c (elf_rel_plt_read): Look for relocations for .got.plt too.
3127
3128 2018-04-25  Pedro Alves  <palves@redhat.com>
3129
3130         * infcmd.c (kill_command): Print the pid as string, not the whole
3131         thread's ptid.  Add comment.  s/has been killed/killed/ in output
3132         message.
3133         * remote.c (remote_detach_1): Print the pid as string, not the
3134         whole thread's ptid.
3135
3136 2018-04-24  Jan Kratochvil  <jan.kratochvil@redhat.com>
3137             Sergio Durigan Junior  <sergiodj@redhat.com>
3138             Pedro Alves  <palves@redhat.com>
3139
3140         * infcmd.c (kill_command): Print message when inferior has
3141         been killed.
3142         * inferior.c (print_inferior_events): Remove 'static'.  Set as
3143         '1'.
3144         (add_inferior): Improve message printed when
3145         'print_inferior_events' is on.
3146         (exit_inferior): Remove message printed when
3147         'print_inferior_events' is on.
3148         (detach_inferior): Improve message printed when
3149         'print_inferior_events' is on.
3150         (initialize_inferiors): Use 'add_inferior_silent' to set
3151         'current_inferior_'.
3152         * inferior.h (print_inferior_events): Declare here as
3153         'extern'.
3154         * infrun.c (follow_fork_inferior): Print '[Attaching...]' or
3155         '[Detaching...]' messages when 'print_inferior_events' is on.
3156         Use 'add_thread_silent' instead of 'add_thread'.  Add '[' and ']'
3157         as prefix/suffix for messages.  Remove periods.  Fix erroneous
3158         'Detaching after fork from child...', replace it by '... from
3159         parent...'.
3160         (handle_vfork_child_exec_or_exit): Add '[' and ']' as
3161         prefix/suffix when printing 'Detaching...' messages.  Print
3162         them when 'print_inferior_events' is on.
3163         * remote.c (remote_detach_1): Print message when detaching
3164         from inferior and '!is_fork_parent'.
3165
3166 2018-04-24  Tom Tromey  <tom@tromey.com>
3167
3168         * cli-out.h: Reindent.
3169
3170 2018-04-24  Tom Tromey  <tom@tromey.com>
3171
3172         * cli-out.c (cli_ui_out::out_field_fmt): Remove.
3173         (cli_ui_out::do_field_string): Use fputs_filtered.
3174         * cli-out.h (class cli_ui_out) <out_field_fmt>: Remove.
3175
3176 2018-04-23  Tom Tromey  <tom@tromey.com>
3177
3178         * guile/scm-frame.c (gdbscm_frame_read_var): Use
3179         gdb::unique_xmalloc_ptr.
3180
3181 2018-04-23  Tom Tromey  <tom@tromey.com>
3182
3183         * configure: Rebuild.
3184
3185 2018-04-22  Rajendra SY  <rajendra.sy@gmail.com>
3186
3187         PR gdb/23095
3188         * gdb/testsuite/gdb.base/break-probes.exp: Pass shlib_load to
3189         prepare_for_testing.  Set normal_bp to r_debug_state if target
3190         is bsd.
3191
3192 2018-04-21  Pedro Alves  <palves@redhat.com>
3193             Rajendra SY  <rajendra.sy@gmail.com>
3194
3195         * inf-ptrace.c (inf_ptrace_attach): Mark the thread as executing.
3196         * remote.c (extended_remote_attach): In all-stop mode, mark the
3197         thread as executing.
3198
3199 2018-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3200
3201         * thread.c (thread_apply_all_command): Fix comment.
3202         (thread_command): Fix comment.
3203
3204 2018-04-10  Alan Hayward  <alan.hayward@arm.com>
3205
3206         * common/tdesc.h (tdesc_create_feature): Remove xml filename
3207         parameter.
3208         * features/aarch64-core.c (create_feature_aarch64_core):
3209         Regenerate.
3210         * features/aarch64-fpu.c (create_feature_aarch64_fpu):
3211         Likewise.
3212         * features/i386/32bit-avx.c (create_feature_i386_32bit_avx):
3213         Likewise.
3214         * features/i386/32bit-avx512.c
3215         (create_feature_i386_32bit_avx512): Likewise.
3216         * features/i386/32bit-core.c (create_feature_i386_32bit_core):
3217         Likewise.
3218         * features/i386/32bit-linux.c (create_feature_i386_32bit_linux):
3219         Likewise.
3220         * features/i386/32bit-mpx.c (create_feature_i386_32bit_mpx):
3221         Likewise.
3222         * features/i386/32bit-pkeys.c (create_feature_i386_32bit_pkeys):
3223         Likewise.
3224         * features/i386/32bit-sse.c (create_feature_i386_32bit_sse):
3225         Likewise.
3226         * features/i386/64bit-avx.c (create_feature_i386_64bit_avx):
3227         Likewise.
3228         * features/i386/64bit-avx512.c
3229         (create_feature_i386_64bit_avx512): Likewise.
3230         * features/i386/64bit-core.c (create_feature_i386_64bit_core):
3231         Likewise.
3232         * features/i386/64bit-linux.c (create_feature_i386_64bit_linux):
3233         Likewise.
3234         * features/i386/64bit-mpx.c (create_feature_i386_64bit_mpx):
3235         Likewise.
3236         * features/i386/64bit-pkeys.c (create_feature_i386_64bit_pkeys):
3237         Likewise.
3238         * features/i386/64bit-segments.c
3239         (create_feature_i386_64bit_segments): Likewise.
3240         * features/i386/64bit-sse.c (create_feature_i386_64bit_sse):
3241         Likewise.
3242         * features/i386/x32-core.c
3243         (create_feature_i386_x32_core): Likewise.
3244         * features/tic6x-c6xp.c (create_feature_tic6x_c6xp): Likewise.
3245         * features/tic6x-core.c (create_feature_tic6x_core): Likewise.
3246         * features/tic6x-gp.c (create_feature_tic6x_gp): Likewise.
3247         * target-descriptions.c: In generated code, don't pass xml
3248         filename.
3249
3250 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3251
3252         * common/tdesc.c (print_xml_feature::visit_pre): Add xml parsing.
3253         (print_xml_feature::visit_post): Likewise.
3254         (print_xml_feature::visit): Likewise.
3255         * common/tdesc.h (tdesc_get_features_xml): Use const tdesc.
3256         (print_xml_feature): Add new class.
3257         * regformats/regdat.sh: Null xmltarget on feature targets.
3258         * target-descriptions.c (struct target_desc): Add xmltarget.
3259         (maintenance_check_tdesc_xml_convert): Add unittest function.
3260         (tdesc_get_features_xml): Add function to get xml.
3261         (maintenance_check_xml_descriptions): Test xml generation.
3262         * xml-tdesc.c (string_read_description_xml): Add function.
3263         * xml-tdesc.h (string_read_description_xml): Add declaration.
3264
3265 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3266
3267         * features/Makefile: Add feature marker to targets with new style
3268         target descriptions.
3269         * regformats/aarch64.dat: Regenerate.
3270         * regformats/i386/amd64-avx-avx512-linux.dat: Likewise.
3271         * regformats/i386/amd64-avx-linux.dat: Likewise.
3272         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Likewise.
3273         * regformats/i386/amd64-avx-mpx-linux.dat: Likewise.
3274         * regformats/i386/amd64-linux.dat: Likewise.
3275         * regformats/i386/amd64-mpx-linux.dat: Likewise.
3276         * regformats/i386/amd64.dat: Likewise.
3277         * regformats/i386/i386-avx-avx512-linux.dat: Likewise.
3278         * regformats/i386/i386-avx-linux.dat: Likewise.
3279         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Likewise.
3280         * regformats/i386/i386-avx-mpx-linux.dat: Likewise.
3281         * regformats/i386/i386-linux.dat: Likewise.
3282         * regformats/i386/i386-mmx-linux.dat: Likewise.
3283         * regformats/i386/i386-mpx-linux.dat: Likewise.
3284         * regformats/i386/i386.dat: Likewise.
3285         * regformats/i386/x32-avx-avx512-linux.dat: Likewise.
3286         * regformats/i386/x32-avx-linux.dat: Likewise.
3287         * regformats/i386/x32-linux.dat: Likewise.
3288         * regformats/tic6x-c62x-linux.dat: Likewise.
3289         * regformats/tic6x-c64x-linux.dat: Likewise.
3290         * regformats/tic6x-c64xp-linux.dat: Likewise.
3291         * regformats/regdat.sh: Parse feature marker.
3292
3293 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3294
3295         * common/tdesc.h (tdesc_architecture_name): Add new declaration.
3296         (tdesc_osabi_name): Likewise.
3297         * target-descriptions.c (tdesc_architecture_name): Add new
3298         function.
3299         (tdesc_osabi_name): Likewise.
3300
3301 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3302
3303         * common/tdesc.c (tdesc_predefined_type): Move to here.
3304         (tdesc_named_type): Likewise.
3305         (tdesc_create_vector): Likewise.
3306         (tdesc_create_struct): Likewise.
3307         (tdesc_set_struct_size): Likewise.
3308         (tdesc_create_union): Likewise.
3309         (tdesc_create_flags): Likewise.
3310         (tdesc_create_enum): Likewise.
3311         (tdesc_add_field): Likewise.
3312         (tdesc_add_typed_bitfield): Likewise.
3313         (tdesc_add_bitfield): Likewise.
3314         (tdesc_add_flag): Likewise.
3315         (tdesc_add_enum_value): Likewise.
3316         * common/tdesc.h (struct tdesc_type_builtin): Likewise.
3317         (struct tdesc_type_vector): Likewise.
3318         (struct tdesc_type_field): Likewise.
3319         (struct tdesc_type_with_fields): Likewise.
3320         (tdesc_create_enum): Add declaration.
3321         (tdesc_add_typed_bitfield): Likewise.
3322         (tdesc_add_enum_value): Likewise.
3323         * target-descriptions.c (tdesc_type_field): Move from here.
3324         (tdesc_type_builtin): Likewise.
3325         (tdesc_type_vector): Likewise.
3326         (tdesc_type_with_fields): Likewise.
3327         (tdesc_predefined_types): Likewise.
3328         (tdesc_named_type): Likewise.
3329         (tdesc_create_vector): Likewise.
3330         (tdesc_create_struct): Likewise.
3331         (tdesc_set_struct_size): Likewise.
3332         (tdesc_create_union): Likewise.
3333         (tdesc_create_flags): Likewise.
3334         (tdesc_create_enum): Likewise.
3335         (tdesc_add_field): Likewise.
3336         (tdesc_add_typed_bitfield): Likewise.
3337         (tdesc_add_bitfield): Likewise.
3338         (tdesc_add_flag): Likewise.
3339         (tdesc_add_enum_value): Likewise.
3340         * gdb/target-descriptions.h (tdesc_create_enum): Likewise.
3341         (tdesc_add_typed_bitfield): Likewise.
3342         (tdesc_add_enum_value): Likewise.
3343
3344 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3345
3346         * common/tdesc.c (tdesc_feature::accept): Move to here.
3347         (tdesc_feature::operator==): Likewise.
3348         (tdesc_create_reg): Likewise.
3349         * common/tdesc.h (tdesc_type_kind): Likewise.
3350         (struct tdesc_type): Likewise.
3351         (struct tdesc_feature): Likewise.
3352         * regformats/regdat.sh: Create a feature.
3353         * target-descriptions.c (tdesc_type_kind): Move from here.
3354         (tdesc_type): Likewise.
3355         (tdesc_type_up): Likewise.
3356         (tdesc_feature): Likewise.
3357         (tdesc_create_reg): Likewise.
3358
3359 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3360
3361         * Makefile.in: Add arch/tdesc.c
3362         * common/tdesc.c: New file.
3363         * common/tdesc.h (tdesc_element_visitor): Move to here.
3364         (tdesc_element): Likewise.
3365         (tdesc_reg): Likewise.
3366         (tdesc_reg_up): Likewise.
3367         * regformats/regdef.h (reg): Add offset to constructors.
3368         * target-descriptions.c (tdesc_element_visitor): Move from here.
3369         (tdesc_element): Likewise.
3370         (tdesc_reg): Likewise.
3371         (tdesc_reg_up): Likewise.
3372
3373 2018-04-17  Tom Tromey  <tom@tromey.com>
3374
3375         * dwarf2read.c (quirk_rust_enum): Conditionally drop the
3376         discriminant field.
3377
3378 2018-04-17  Tom Tromey  <tom@tromey.com>
3379
3380         * dwarf2read.c (quirk_rust_enum): Handle unions correctly.
3381
3382 2018-04-17  Andreas Arnez  <arnez@linux.vnet.ibm.com>
3383
3384         * symtab.c (print_symbol_info): Skip printing filename and line
3385         number when `last' is NULL.
3386         (symtab_symbol_info): Use empty string instead of NULL for first
3387         invocation of print_symbol_info.
3388         (rbreak_command): Pass NULL to `last' parameter of
3389         print_symbol_info.
3390
3391 2018-04-16  Simon Marchi  <simon.marchi@ericsson.com>
3392
3393         * linux-tdep.c (linux_spu_make_corefile_notes): Return note_data
3394         instead of nullptr.
3395
3396 2018-04-16  Pedro Alves  <palves@redhat.com>
3397
3398         * MAINTAINERS (sh): Remove.
3399         * Makefile.in (ALL_TARGET_OBS): Remove sh64-tdep.o.
3400         (HFILES_NO_SRCDIR): Remove sh64-tdep.h.
3401         (ALLDEPFILES): Remove sh64-tdep.c.
3402         * NEWS: Mentions that support for SH-5/SH64 is removed.
3403         * configure.tgt (sh*-*-linux*): Remove reference to sh64-tdep.o.
3404         (sh*-*-openbsd*): Ditto.
3405         (sh64-*-elf*): Remove.
3406         (sh*): Remove.
3407         * regcache.c (cooked_write_test): Remove bfd_mach_sh5 case.
3408         * sh-linux-tdep.c: Remove reference to bfd_mach_sh5.
3409         * sh-tdep.c: No longer include "sh64-tdep.h".
3410         (sh_gdbarch_init): Remove reference to bfd_mach_sh5.
3411         * sh64-tdep.c, sh64-tdep.h: Remove files.
3412
3413 2018-04-16  Pedro Alves  <palves@redhat.com>
3414
3415         * MAINTAINERS: Remove m88k.
3416         * Makefile.in (ALL_TARGET_OBS): Remove m88k-tdep.o.
3417         (HFILES_NO_SRCDIR): Remove m88k-tdep.h.
3418         (ALLDEPFILES): Remove m88k-bsd-nat.c and m88k-tdep.c.
3419         * NEWS: Mention that support for m88k was removed.
3420         * configure.host (m88*-*-*): Remove support.
3421         * configure.nat (m88k-*-*): Remove support.
3422         * configure.tgt (m88*-*-openbsd*): Remove.
3423         * m88k-bsd-nat.c, m88k-tdep.c, m88k-tdep.h: Delete.
3424
3425 2018-04-15  Simon Marchi  <simon.marchi@polymtl.ca>
3426
3427         * configure.tgt (x86_tobjs): New variable.
3428         (amd64_tobjs, i386_tobjs): Use it.
3429
3430 2018-04-13  Andreas Arnez  <arnez@linux.vnet.ibm.com>
3431
3432         * symtab.c (print_symbol_info): Precede the symbol definition by
3433         the line number when available.
3434         * NEWS: Advertise this enhancement.
3435
3436 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3437
3438         * NEWS (New options): announce set/show record btrace cpu.
3439         * btrace.c: Include record-btrace.h.
3440         (btrace_compute_ftrace_pt): Skip enabling errata workarounds if
3441         the vendor is unknown.
3442         (btrace_compute_ftrace_1): Add cpu parameter.  Update callers.
3443         Maybe overwrite the btrace configuration's cpu.
3444         (btrace_compute_ftrace): Add cpu parameter.  Update callers.
3445         (btrace_fetch): Add cpu parameter.  Update callers.
3446         (btrace_maint_update_pt_packets): Call record_btrace_get_cpu.
3447         Maybe overwrite the btrace configuration's cpu.  Skip enabling
3448         errata workarounds if the vendor is unknown.
3449         * python/py-record-btrace.c: Include record-btrace.h.
3450         (recpy_bt_begin, recpy_bt_end, recpy_bt_instruction_history)
3451         (recpy_bt_function_call_history): Call record_btrace_get_cpu.
3452         * record-btrace.c (record_btrace_cpu_state_kind): New.
3453         (record_btrace_cpu): New.
3454         (set_record_btrace_cpu_cmdlist): New.
3455         (record_btrace_get_cpu): New.
3456         (require_btrace_thread, record_btrace_info)
3457         (record_btrace_resume_thread): Call record_btrace_get_cpu.
3458         (cmd_set_record_btrace_cpu_none): New.
3459         (cmd_set_record_btrace_cpu_auto): New.
3460         (cmd_set_record_btrace_cpu): New.
3461         (cmd_show_record_btrace_cpu): New.
3462         (_initialize_record_btrace): Initialize set/show record btrace cpu
3463         commands.
3464         * record-btrace.h (record_btrace_get_cpu): New.
3465
3466 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3467
3468         * record.c (set_record_command): Fix typo in message.
3469
3470 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3471
3472         * record-btrace.c (cmd_set_record_btrace): Print sub-commands.
3473
3474 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3475
3476         * infrun.c (process_event_stop_test): Call
3477         gdbarch_in_indirect_branch_thunk.
3478         * gdbarch.sh (in_indirect_branch_thunk): New.
3479         * gdbarch.c: Regenerated.
3480         * gdbarch.h: Regenerated.
3481         * x86-tdep.h: New.
3482         * x86-tdep.c: New.
3483         * Makefile.in (ALL_TARGET_OBS): Add x86-tdep.o.
3484         (HFILES_NO_SRCDIR): Add x86-tdep.h.
3485         (ALLDEPFILES): Add x86-tdep.c.
3486         * arch-utils.h (default_in_indirect_branch_thunk): New.
3487         * arch-utils.c (default_in_indirect_branch_thunk): New.
3488         * i386-tdep: Include x86-tdep.h.
3489         (i386_in_indirect_branch_thunk): New.
3490         (i386_elf_init_abi): Set in_indirect_branch_thunk gdbarch
3491         function.
3492         * amd64-tdep: Include x86-tdep.h.
3493         (amd64_in_indirect_branch_thunk): New.
3494         (amd64_init_abi): Set in_indirect_branch_thunk gdbarch function.
3495
3496 2018-04-12  Jan Kratochvil  <jan.kratochvil@redhat.com>
3497
3498         PR gdb/23053
3499         * dwarf-index-write.c (data_buf::grow) (write_one_signatured_type)
3500         (recursively_write_psymbols) (debug_names::recursively_write_psymbols)
3501         (debug_names::write_one_signatured_type): Fix -D_GLIBCXX_DEBUG
3502         regression.
3503
3504 2018-04-12  Tom Tromey  <tom@tromey.com>
3505
3506         * rust-lang.c (rust_print_struct_def): Remove univariant code.
3507         (rust_evaluate_subexp): Likewise.
3508
3509 2018-04-12  Pedro Alves  <palves@redhat.com>
3510
3511         * procfs.c (procfs_detach): Make forward declaration's prototype
3512         match definition's protototype.
3513         (proc_get_LDT_entry): Remove stale do_cleanups call.
3514
3515 2018-04-12  Pedro Alves  <palves@redhat.com>
3516
3517         * target.h (target_ops::to_has_exited): Delete.
3518         (target_has_exited): Delete.
3519         * target-delegates.c: Regenerate.
3520
3521 2018-04-11  Pedro Alves  <palves@redhat.com>
3522
3523         * target.c (fileio_fh_t::t): Add comment.
3524         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
3525         (target_fileio_close): Handle a NULL target.
3526         (invalidate_fileio_fh): New.
3527         (target_close): Call it.
3528         * remote.c (remote_hostio_send_command): No longer check whether
3529         remote_desc is open.
3530
3531 2018-04-11  Pedro Alves  <palves@redhat.com>
3532
3533         * target.c (fileio_fh_t): Make it a named struct instead of a
3534         typedef.
3535         (fileio_fh_t::is_closed): New method.
3536         (DEF_VEC_O (fileio_fh_t)): Remove.
3537         (fileio_fhandles): Now a std::vector.
3538         (is_closed_fileio_fh): Delete.
3539         (acquire_fileio_fd): Adjust.  Rename parameters.
3540         (release_fileio_fd): Adjust.
3541         (fileio_fd_to_fh): Reimplement as a function instead of a macro.
3542         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
3543         (target_fileio_close): Adjust.
3544
3545 2018-04-10  Simon Marchi  <simon.marchi@ericsson.com>
3546
3547         * auto-load.c (auto_load_safe_path_vec_update): Iterate by
3548         index.
3549
3550 2018-04-10  Pedro Alves  <palves@redhat.com>
3551
3552         * gdbthread.h (finish_thread_state_cleanup): Delete declaration.
3553         (scoped_finish_thread_state): New class.
3554         * infcmd.c (run_command_1): Use it instead of finish_thread_state
3555         cleanup.
3556         * infrun.c (proceed, prepare_for_detach, wait_for_inferior)
3557         (fetch_inferior_event, normal_stop): Likewise.
3558         * thread.c (finish_thread_state_cleanup): Delete.
3559
3560 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3561             Pedro Alves  <palves@redhat.com>
3562
3563         * value.c: Include "selftest.h" and "common/array-view.h".
3564         (struct range) <operator ==>: New.
3565         (test_ranges_contain): New.
3566         (check_ranges_vector): New.
3567         (test_insert_into_bit_range_vector): New.
3568         (_initialize_values): Register selftests.
3569         * common/array-view.h (operator==, operator!=): New.
3570
3571 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3572
3573         * common/gdb_vecs.h (unordered_remove): Add overload that takes
3574         an iterator.
3575         * inline-frame.c: Include <algorithm>.
3576         (struct inline_state): Add constructor.
3577         (inline_state_s): Remove.
3578         (DEF_VEC_O(inline_state_s)): Remove.
3579         (inline_states): Change type to std::vector.
3580         (find_inline_frame_state): Adjust to std::vector.
3581         (allocate_inline_frame_state): Remove.
3582         (clear_inline_frame_state): Adjust to std::vector.
3583         (skip_inline_frames): Adjust to std::vector.
3584
3585 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3586
3587         * tracepoint.h (struct trace_state_variable): Add constructor.
3588         <name>: Change type to std::string.
3589         * tracepoint.c (tsv_s): Remove.
3590         (DEF_VEC_O(tsv_s)): Remove.
3591         (tvariables): Change to std::vector.
3592         (create_trace_state_variable): Adjust to std::vector.
3593         (find_trace_state_variable): Likewise.
3594         (find_trace_state_variable_by_number): Likewise.
3595         (delete_trace_state_variable): Likewise.
3596         (trace_variable_command): Adjust to std::string.
3597         (delete_trace_variable_command): Likewise.
3598         (tvariables_info_1): Adjust to std::vector.
3599         (save_trace_state_variables): Likewise.
3600         (start_tracing): Likewise.
3601         (merge_uploaded_trace_state_variables): Adjust to std::vector
3602         and std::string.
3603         * target.h (struct target_ops)
3604         <to_download_trace_state_variable>: Pass reference to
3605         trace_state_variable.
3606         * target-debug.h (target_debug_print_const_trace_state_variable_r): New.
3607         * target-delegates.c: Re-generate.
3608         * mi/mi-interp.c (mi_tsv_created): Adjust to std::string.
3609         (mi_tsv_deleted): Likewise.
3610         * mi/mi-main.c (mi_cmd_trace_frame_collected): Likewise.
3611         * remote.c (remote_download_trace_state_variable): Change
3612         pointer to reference and adjust.
3613         * make-target-delegates (parse_argtypes): Handle references.
3614         (write_function_header): Likewise.
3615         (munge_type): Likewise.
3616
3617 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3618
3619         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3620         string_view-selftests.c.
3621         * unittests/basic_string_view/capacity/1.cc: Adapt to GDB
3622         testsuite.
3623         * unittests/basic_string_view/cons/char/1.cc: Likewise.
3624         * unittests/basic_string_view/cons/char/2.cc: Likewise.
3625         * unittests/basic_string_view/cons/char/3.cc: Likewise.
3626         * unittests/basic_string_view/element_access/char/1.cc:
3627         Likewise.
3628         * unittests/basic_string_view/element_access/char/empty.cc:
3629         Likewise.
3630         * unittests/basic_string_view/element_access/char/front_back.cc:
3631         Likewise.
3632         * unittests/basic_string_view/inserters/char/2.cc: Likewise.
3633         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc:
3634         Likewise.
3635         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc:
3636         Likewise.
3637         * unittests/basic_string_view/modifiers/swap/char/1.cc:
3638         Likewise.
3639         * unittests/basic_string_view/operations/compare/char/1.cc:
3640         Likewise.
3641         * unittests/basic_string_view/operations/compare/char/13650.cc:
3642         Likewise.
3643         * unittests/basic_string_view/operations/copy/char/1.cc:
3644         Likewise.
3645         * unittests/basic_string_view/operations/data/char/1.cc:
3646         Likewise.
3647         * unittests/basic_string_view/operations/find/char/1.cc:
3648         Likewise.
3649         * unittests/basic_string_view/operations/find/char/2.cc:
3650         Likewise.
3651         * unittests/basic_string_view/operations/find/char/3.cc:
3652         Likewise.
3653         * unittests/basic_string_view/operations/find/char/4.cc:
3654         Likewise.
3655         * unittests/basic_string_view/operations/rfind/char/1.cc:
3656         Likewise.
3657         * unittests/basic_string_view/operations/rfind/char/2.cc:
3658         Likewise.
3659         * unittests/basic_string_view/operations/rfind/char/3.cc:
3660         Likewise.
3661         * unittests/basic_string_view/operations/substr/char/1.cc:
3662         Likewise.
3663         * unittests/basic_string_view/operators/char/2.cc: Likewise.
3664         * unittests/string_view-selftests.c: New file.
3665
3666 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3667
3668         * unittests/basic_string_view/capacity/1.cc: New file.
3669         * unittests/basic_string_view/capacity/empty_neg.cc: New file.
3670         * unittests/basic_string_view/cons/char/1.cc: New file.
3671         * unittests/basic_string_view/cons/char/2.cc: New file.
3672         * unittests/basic_string_view/cons/char/3.cc: New file.
3673         * unittests/basic_string_view/cons/wchar_t/1.cc: New file.
3674         * unittests/basic_string_view/cons/wchar_t/2.cc: New file.
3675         * unittests/basic_string_view/cons/wchar_t/3.cc: New file.
3676         * unittests/basic_string_view/element_access/char/1.cc: New file.
3677         * unittests/basic_string_view/element_access/char/2.cc: New file.
3678         * unittests/basic_string_view/element_access/char/empty.cc: New file.
3679         * unittests/basic_string_view/element_access/char/front_back.cc: New file.
3680         * unittests/basic_string_view/element_access/wchar_t/1.cc: New file.
3681         * unittests/basic_string_view/element_access/wchar_t/2.cc: New file.
3682         * unittests/basic_string_view/element_access/wchar_t/empty.cc: New file.
3683         * unittests/basic_string_view/element_access/wchar_t/front_back.cc: New file.
3684         * unittests/basic_string_view/include.cc: New file.
3685         * unittests/basic_string_view/inserters/char/1.cc: New file.
3686         * unittests/basic_string_view/inserters/char/2.cc: New file.
3687         * unittests/basic_string_view/inserters/char/3.cc: New file.
3688         * unittests/basic_string_view/inserters/pod/10081-out.cc: New file.
3689         * unittests/basic_string_view/inserters/wchar_t/1.cc: New file.
3690         * unittests/basic_string_view/inserters/wchar_t/2.cc: New file.
3691         * unittests/basic_string_view/inserters/wchar_t/3.cc: New file.
3692         * unittests/basic_string_view/literals/types.cc: New file.
3693         * unittests/basic_string_view/literals/values.cc: New file.
3694         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc: New file.
3695         * unittests/basic_string_view/modifiers/remove_prefix/wchar_t/1.cc: New file.
3696         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc: New file.
3697         * unittests/basic_string_view/modifiers/remove_suffix/wchar_t/1.cc: New file.
3698         * unittests/basic_string_view/modifiers/swap/char/1.cc: New file.
3699         * unittests/basic_string_view/modifiers/swap/wchar_t/1.cc: New file.
3700         * unittests/basic_string_view/operations/compare/char/1.cc: New file.
3701         * unittests/basic_string_view/operations/compare/char/13650.cc: New file.
3702         * unittests/basic_string_view/operations/compare/char/2.cc: New file.
3703         * unittests/basic_string_view/operations/compare/char/70483.cc: New file.
3704         * unittests/basic_string_view/operations/compare/wchar_t/1.cc: New file.
3705         * unittests/basic_string_view/operations/compare/wchar_t/13650.cc: New file.
3706         * unittests/basic_string_view/operations/compare/wchar_t/2.cc: New file.
3707         * unittests/basic_string_view/operations/copy/char/1.cc: New file.
3708         * unittests/basic_string_view/operations/copy/wchar_t/1.cc: New file.
3709         * unittests/basic_string_view/operations/data/char/1.cc: New file.
3710         * unittests/basic_string_view/operations/data/wchar_t/1.cc: New file.
3711         * unittests/basic_string_view/operations/find/char/1.cc: New file.
3712         * unittests/basic_string_view/operations/find/char/2.cc: New file.
3713         * unittests/basic_string_view/operations/find/char/3.cc: New file.
3714         * unittests/basic_string_view/operations/find/char/4.cc: New file.
3715         * unittests/basic_string_view/operations/find/wchar_t/1.cc: New file.
3716         * unittests/basic_string_view/operations/find/wchar_t/2.cc: New file.
3717         * unittests/basic_string_view/operations/find/wchar_t/3.cc: New file.
3718         * unittests/basic_string_view/operations/find/wchar_t/4.cc: New file.
3719         * unittests/basic_string_view/operations/rfind/char/1.cc: New file.
3720         * unittests/basic_string_view/operations/rfind/char/2.cc: New file.
3721         * unittests/basic_string_view/operations/rfind/char/3.cc: New file.
3722         * unittests/basic_string_view/operations/rfind/wchar_t/1.cc: New file.
3723         * unittests/basic_string_view/operations/rfind/wchar_t/2.cc: New file.
3724         * unittests/basic_string_view/operations/rfind/wchar_t/3.cc: New file.
3725         * unittests/basic_string_view/operations/string_conversion/1.cc: New file.
3726         * unittests/basic_string_view/operations/substr/char/1.cc: New file.
3727         * unittests/basic_string_view/operations/substr/wchar_t/1.cc: New file.
3728         * unittests/basic_string_view/operators/char/2.cc: New file.
3729         * unittests/basic_string_view/operators/wchar_t/2.cc: New file.
3730         * unittests/basic_string_view/range_access/char/1.cc: New file.
3731         * unittests/basic_string_view/range_access/wchar_t/1.cc: New file.
3732         * unittests/basic_string_view/requirements/explicit_instantiation/1.cc: New file.
3733         * unittests/basic_string_view/requirements/explicit_instantiation/char/1.cc: New file.
3734         * unittests/basic_string_view/requirements/explicit_instantiation/char16_t/1.cc: New file.
3735         * unittests/basic_string_view/requirements/explicit_instantiation/char32_t/1.cc: New file.
3736         * unittests/basic_string_view/requirements/explicit_instantiation/wchar_t/1.cc: New file.
3737         * unittests/basic_string_view/requirements/typedefs.cc: New file.
3738         * unittests/basic_string_view/typedefs.cc: New file.
3739         * unittests/basic_string_view/types/1.cc: New file.
3740
3741 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3742
3743         * common/gdb_string_view.h: Remove libstdc++ implementation
3744         details, adjust to gdb reality.
3745         * common/gdb_string_view.tcc: Likewise.
3746         * cli/cli-script.c (struct string_view): Remove.
3747         (user_args) <m_args>: Change element type to gdb::string_view.
3748         (user_args::insert_args): Adjust.
3749
3750 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3751
3752         * common/gdb_string_view.h: New file.
3753         * common/gdb_string_view.tcc: New file.
3754
3755 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3756
3757         * ax_cxx_compile_stdcxx.m4: Sync with upstream.
3758         * configure: Re-generate.
3759
3760 2018-04-09  Pedro Alves  <palves@redhat.com>
3761
3762         * gdbarch.sh: Include "observable.h" instead of "observer.h".
3763         (set_target_gdbarch): Call
3764         gdb::observers::architecture_changed.notify instead of
3765         observer_notify_architecture_changed.
3766
3767 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3768
3769         * tracepoint.c (struct current_traceframe_cleanup): Remove.
3770         (do_restore_current_traceframe_cleanup): Remove.
3771         (restore_current_traceframe_cleanup_dtor): Remove.
3772         (make_cleanup_restore_current_traceframe): Remove.
3773         (scoped_restore_current_traceframe::scoped_restore_current_traceframe):
3774         New.
3775         * tracepoint.h (struct scoped_restore_current_traceframe): New.
3776         * infrun.c (fetch_inferior_event): Use
3777         scoped_restore_current_traceframe.
3778
3779 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3780
3781         * dwarf2read.h (struct dwarf2_per_objfile) <n_type_units>:
3782         Remove.
3783         <n_allocated_type_units>: Remove.
3784         <all_type_units>: Change to std::vector.
3785         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
3786         to std::vector change.
3787         (dwarf2_per_objfile::get_cutu): Likewise.
3788         (dwarf2_per_objfile::get_tu): Likewise.
3789         (create_signatured_type_table_from_index): Likewise.
3790         (create_signatured_type_table_from_debug_names): Likewise.
3791         (dw2_symtab_iter_next): Likewise.
3792         (dw2_print_stats): Likewise.
3793         (dw2_expand_all_symtabs): Likewise.
3794         (dw2_expand_marked_cus): Likewise.
3795         (dw2_debug_names_iterator::next): Likewise.
3796         (dwarf2_initialize_objfile): Likewise.
3797         (add_signatured_type_cu_to_table): Likewise.
3798         (create_all_type_units): Likewise.
3799         (add_type_unit): Likewise.
3800         (struct tu_abbrev_offset): Add constructor.
3801         (build_type_psymtabs_1): Adjust to std::vector change.
3802         (print_tu_stats): Likewise.
3803         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
3804         (write_debug_names): Likewise.
3805
3806 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3807
3808         * dwarf2read.h (struct dwarf2_per_objfile) <all_comp_units>: Likewise.
3809         Make an std::vector.
3810         <n_comp_units>: Remove.
3811         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
3812         to std::vector change.
3813         (dwarf2_per_objfile::get_cutu): Likewise.
3814         (dwarf2_per_objfile::get_cu): Likewise.
3815         (create_cus_from_index): Likewise.
3816         (create_addrmap_from_index): Likewise.
3817         (create_addrmap_from_aranges): Likewise.
3818         (dwarf2_read_index): Likewise.
3819         (dw2_find_last_source_symtab): Likewise.
3820         (dw2_map_symtabs_matching_filename): Likewise.
3821         (dw2_symtab_iter_next): Likewise.
3822         (dw2_print_stats): Likewise.
3823         (dw2_expand_all_symtabs): Likewise.
3824         (dw2_expand_symtabs_with_fullname): Likewise.
3825         (dw2_expand_marked_cus): Likewise.
3826         (dw2_map_symbol_filenames): Likewise.
3827         (create_cus_from_debug_names): Likewise.
3828         (dwarf2_read_debug_names): Likewise.
3829         (dw2_debug_names_iterator::next): Likewise.
3830         (dwarf2_initialize_objfile): Likewise.
3831         (set_partial_user): Likewise.
3832         (dwarf2_build_psymtabs_hard): Likewise.
3833         (read_comp_units_from_section): Remove arguments, adjust to
3834         std::vector change.
3835         (create_all_comp_units): Adjust to std::vector and
3836         read_comp_units_from_section changes.
3837         (dwarf2_find_containing_comp_unit): Adjust to std::vector
3838         change.
3839         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
3840         (psyms_seen_size): Likewise.
3841         (write_gdbindex): Likewise.
3842         (write_debug_names): Likewise.
3843
3844 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3845
3846         * dwarf2read.c (create_cus_from_index_list): Replace objfile arg
3847         with dwarf2_per_objfile.
3848         (create_cus_from_index): Likewise.
3849         (create_signatured_type_table_from_index): Likewise.
3850         (dwarf2_read_index): Likewise.
3851         (dwarf2_initialize_objfile): Likewise.
3852         (dwarf2_fetch_die_loc_sect_off):  Get dwarf2_per_objfile from
3853         per_cu rather than get_dwarf2_per_objfile.
3854
3855 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3856
3857         * dwarf2read.h (struct signatured_type): Forward declare.
3858         (struct dwarf2_per_objfile) <get_cutu, get_cu, get_tu>:
3859         New methods.
3860         * dwarf2read.c (dwarf2_per_objfile::get_cutu): Rename from...
3861         (dw2_get_cutu): ...this.
3862         (dwarf2_per_objfile::get_cu): Rename from...
3863         (dw2_get_cu): ...this.
3864         (dwarf2_per_objfile::get_tu): New.
3865         (create_addrmap_from_index): Adjust.
3866         (create_addrmap_from_aranges): Adjust.
3867         (dw2_find_last_source_symtab): Adjust.
3868         (dw2_map_symtabs_matching_filename): Adjust.
3869         (dw2_symtab_iter_next): Adjust.
3870         (dw2_print_stats): Adjust.
3871         (dw2_expand_all_symtabs): Adjust.
3872         (dw2_expand_symtabs_with_fullname): Adjust.
3873         (dw2_expand_marked_cus): Adjust.
3874         (dw_expand_symtabs_matching_file_matcher): Adjust.
3875         (dw2_map_symbol_filenames): Adjust.
3876         (dw2_debug_names_iterator::next): Adjust.
3877         (dwarf2_initialize_objfile): Adjust.
3878         (set_partial_user): Adjust.
3879         (dwarf2_build_psymtabs_hard): Adjust.
3880
3881 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3882
3883         * dwarf2read.c (create_signatured_type_table_from_debug_names):
3884         Remove unused variables.
3885         (dw2_map_symtabs_matching_filename): Likewise.
3886         (dwarf2_record_block_ranges): Likewise.
3887         (dwarf2_read_addr_index): Likewise.
3888         (follow_die_offset): Likewise.
3889
3890 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3891
3892         * progspace.c (clone_program_space): Pass SYMFILE_DEFER_BP_RESET
3893         to symbol_file_add_main.
3894
3895 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3896
3897         PR mi/22299
3898         * mi/mi-console.c (do_fputc_async_safe): New.
3899         (mi_console_file::write_async_safe): New.
3900         (mi_console_file::flush): Adjust calls to fputstrn_unfiltered.
3901         * mi/mi-console.h (class mi_console_file) <write_async_safe>:
3902         New.
3903         * ui-file.c (ui_file::putstrn): Adjust call to
3904         fputstrn_unfiltered.
3905         * utils.c (printchar): Replace do_fputs and do_fprintf
3906         parameters by do_fputc.
3907         (fputstr_filtered): Adjust call to printchar.
3908         (fputstr_unfiltered): Likewise.
3909         (fputstrn_filtered): Likewise.
3910         (fputstrn_unfiltered): Add do_fputc parameter, pass to
3911         printchar.
3912         * utils.h (do_fputc_ftype): New typedef.
3913         (fputstrn_unfiltered): Add do_fputc parameter.
3914
3915 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3916
3917         * regformats/i386/i386-avx.dat: Remove.
3918
3919 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
3920
3921         PR gdb/22979
3922         * amd64-tdep.c (amd64_none_init_abi): New function.
3923         (amd64_x32_none_init_abi): New function.
3924         (_initialize_amd64_tdep): Register handlers for x86-64 and
3925         x64_32 with GDB_OSABI_NONE.
3926         * osabi.c (gdbarch_init_osabi): Allow running handlers for the
3927         GDB_OSABI_NONE osabi.
3928
3929 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
3930
3931         PR gdb/22980
3932         * defs.h (enum gdb_osabi): Remove GDB_OSABI_UNINITIALIZED, add
3933         GDB_OSABI_NONE.
3934         * arch-utils.c (gdbarch_info_init): Don't set info->osabi.
3935         * osabi.c (gdb_osabi_names): Add "unknown" entry.
3936
3937 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
3938
3939         * common/byte-vector.h (char_vector): New type.
3940         * target.h (target_read_alloc): Return
3941         gdb::optional<byte_vector>.
3942         (target_read_stralloc): Return gdb::optional<char_vector>.
3943         (target_get_osdata): Return gdb::optional<char_vector>.
3944         * target.c (target_read_alloc_1): Templatize.  Replacement
3945         manual memory management with vector.
3946         (target_read_alloc): Change return type, adjust.
3947         (target_read_stralloc): Change return type, adjust.
3948         (target_get_osdata): Change return type, adjust.
3949         * auxv.c (struct auxv_info) <length>: Remove.
3950         <data>: Change type to gdb::optional<byte_vector>.
3951         (auxv_inferior_data_cleanup): Free auxv_info with delete.
3952         (get_auxv_inferior_data): Allocate auxv_info with new, adjust.
3953         (target_auxv_search): Adjust.
3954         (fprint_target_auxv): Adjust.
3955         * avr-tdep.c (avr_io_reg_read_command): Adjust.
3956         * linux-tdep.c (linux_spu_make_corefile_notes): Adjust.
3957         (linux_make_corefile_notes): Adjust.
3958         * osdata.c (get_osdata): Adjust.
3959         * remote.c (remote_get_threads_with_qxfer): Adjust.
3960         (remote_memory_map): Adjust.
3961         (remote_traceframe_info): Adjust.
3962         (btrace_read_config): Adjust.
3963         (remote_read_btrace): Adjust.
3964         (remote_pid_to_exec_file): Adjust.
3965         * solib-aix.c (solib_aix_get_library_list): Adjust.
3966         * solib-dsbt.c (decode_loadmap): Don't free buf.
3967         (dsbt_get_initial_loadmaps): Adjust.
3968         * solib-svr4.c (svr4_current_sos_via_xfer_libraries): Adjust.
3969         * solib-target.c (solib_target_current_sos): Adjust.
3970         * tracepoint.c (sdata_make_value): Adjust.
3971         * xml-support.c (xinclude_start_include): Adjust.
3972         (xml_fetch_content_from_file): Adjust.
3973         * xml-support.h (xml_fetch_another): Change return type.
3974         (xml_fetch_content_from_file): Change return type.
3975         * xml-syscall.c (xml_init_syscalls_info): Adjust.
3976         * xml-tdesc.c (file_read_description_xml): Adjust.
3977         (fetch_available_features_from_target): Change return type.
3978         (target_fetch_description_xml): Adjust.
3979         (target_read_description_xml): Adjust.
3980
3981 2018-04-06  Tom Tromey  <tom@tromey.com>
3982
3983         * value.c (~value): Update.
3984         (struct value) <contents>: Now unique_xmalloc_ptr.
3985         (value_contents_bits_eq, allocate_value_contents)
3986         (value_contents_raw, value_contents_all_raw)
3987         (value_contents_for_printing, value_contents_for_printing_const)
3988         (set_value_enclosing_type): Update.
3989
3990 2018-04-06  Tom Tromey  <tom@tromey.com>
3991
3992         * value.c (range_s): Remove typedef, VEC.
3993         (struct range): Add operator<.
3994         (range_lessthan): Remove.
3995         (ranges_contain): Change type.
3996         (~value): Update.
3997         (struct value) <unavailable, optimized_out>: Now std::vector.
3998         (value_entirely_available)
3999         (value_entirely_covered_by_range_vector)
4000         (value_entirely_unavailable, value_entirely_optimized_out):
4001         Update.
4002         (insert_into_bit_range_vector): Change argument type.
4003         (find_first_range_overlap): Likewise.
4004         (struct ranges_and_idx, value_contents_bits_eq)
4005         (require_not_optimized_out, require_available): Update.
4006         (ranges_copy_adjusted): Change argument types.
4007         (value_optimized_out, value_copy, value_fetch_lazy): Update.
4008
4009 2018-04-06  Tom Tromey  <tom@tromey.com>
4010
4011         * value.c (~value): Update.
4012         (struct value) <parent>: Now a value_ref_ptr.
4013         (value_parent, set_value_parent, value_address, value_copy):
4014         Update.
4015
4016 2018-04-06  Tom Tromey  <tom@tromey.com>
4017
4018         * value.c (struct value): Add constructor, destructor, and member
4019         initializers.
4020         (allocate_value_lazy, value_decref): Update.
4021
4022 2018-04-06  Tom Tromey  <tom@tromey.com>
4023
4024         * value.c (struct value) <released, next>: Remove.
4025         (all_values): Now a std::vector.
4026         (allocate_value_lazy): Update.
4027         (value_next): Remove.
4028         (value_mark, value_free_to_mark, release_value)
4029         (value_release_to_mark): Update.
4030
4031 2018-04-06  Tom Tromey  <tom@tromey.com>
4032
4033         * value.h (fetch_subexp_value, value_release_to_mark): Update.
4034         (free_value_chain): Remove.
4035         * value.c (free_value_chain): Remove.
4036         (value_release_to_mark): Return a std::vector.
4037         * ppc-linux-nat.c (num_memory_accesses): Change "chain" to a
4038         std::vector.
4039         (check_condition): Update.
4040         * eval.c (fetch_subexp_value): Change "val_chain" to a
4041         std::vector.
4042         * breakpoint.c (update_watchpoint): Update.
4043         (can_use_hardware_watchpoint): Change "vals" to a std::vector.
4044
4045 2018-04-06  Tom Tromey  <tom@tromey.com>
4046
4047         * value.h (free_all_values): Remove.
4048         * value.c (free_all_values): Remove.
4049
4050 2018-04-06  Tom Tromey  <tom@tromey.com>
4051
4052         * value.c (VALUE_HISTORY_CHUNK, struct value_history_chunk)
4053         (value_history_chain, value_history_count): Remove.
4054         (value_history): New global.
4055         (record_latest_value, access_value_history, show_values)
4056         (preserve_values): Update.
4057
4058 2018-04-06  Tom Tromey  <tom@tromey.com>
4059
4060         * varobj.h (struct varobj) <value>: Now a value_ref_ptr.
4061         * varobj.c (varobj_set_display_format, varobj_set_value)
4062         (install_default_visualizer, construct_visualizer)
4063         (install_new_value, ~varobj, varobj_get_value_type)
4064         (my_value_of_variable, varobj_editable_p): Update.
4065         * c-varobj.c (c_describe_child, c_value_of_variable)
4066         (cplus_number_of_children, cplus_describe_child): Update.
4067         * ada-varobj.c (ada_number_of_children, ada_name_of_child)
4068         (ada_path_expr_of_child, ada_value_of_child, ada_type_of_child)
4069         (ada_value_of_variable, ada_value_is_changeable_p): Update.
4070
4071 2018-04-06  Tom Tromey  <tom@tromey.com>
4072
4073         * printcmd.c (last_examine_address): Change type to
4074         value_ref_ptr.
4075         (do_examine, x_command): Update.
4076
4077 2018-04-06  Tom Tromey  <tom@tromey.com>
4078
4079         * value.c (release_value): Update.
4080         * breakpoint.h (struct watchpoint) <val>: Now a value_ref_ptr.
4081         (struct bpstats) <val>: Now a value_ref_ptr.
4082         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
4083         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
4084         (~watchpoint, print_it_watchpoint, watch_command_1)
4085         (invalidate_bp_value_on_memory_change): Update.
4086
4087 2018-04-06  Tom Tromey  <tom@tromey.com>
4088
4089         * varobj.c (varobj_clear_saved_item)
4090         (update_dynamic_varobj_children, install_new_value, ~varobj):
4091         Update.
4092         * value.h (value_incref): Move declaration earlier.
4093         (value_decref): Rename from value_free.
4094         (struct value_ref_policy): New.
4095         (value_ref_ptr): New typedef.
4096         (struct value_deleter): Remove.
4097         (gdb_value_up): Remove typedef.
4098         (release_value): Change return type.
4099         (release_value_or_incref): Remove.
4100         * value.c (set_value_parent): Update.
4101         (value_incref): Change return type.
4102         (value_decref): Rename from value_free.
4103         (value_free_to_mark, free_all_values, free_value_chain): Update.
4104         (release_value): Return value_ref_ptr.
4105         (release_value_or_incref): Remove.
4106         (record_latest_value, set_internalvar, clear_internalvar):
4107         Update.
4108         * stack.c (info_frame_command): Don't call value_free.
4109         * python/py-value.c (valpy_dealloc, valpy_new)
4110         (value_to_value_object): Update.
4111         * printcmd.c (do_examine): Update.
4112         * opencl-lang.c (lval_func_free_closure): Update.
4113         * mi/mi-main.c (register_changed_p): Don't call value_free.
4114         * mep-tdep.c (mep_frame_prev_register): Don't call value_free.
4115         * m88k-tdep.c (m88k_frame_prev_register): Don't call value_free.
4116         * m68hc11-tdep.c (m68hc11_frame_prev_register): Don't call
4117         value_free.
4118         * guile/scm-value.c (vlscm_free_value_smob)
4119         (vlscm_scm_from_value): Update.
4120         * frame.c (frame_register_unwind, frame_unwind_register_signed)
4121         (frame_unwind_register_unsigned, get_frame_register_bytes)
4122         (put_frame_register_bytes): Don't call value_free.
4123         * findvar.c (address_from_register): Don't call value_free.
4124         * dwarf2read.c (dwarf2_compute_name): Don't call value_free.
4125         * dwarf2loc.c (entry_data_value_free_closure)
4126         (value_of_dwarf_reg_entry, free_pieced_value_closure)
4127         (dwarf2_evaluate_loc_desc_full): Update.
4128         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
4129         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
4130         (~watchpoint, watch_command_1)
4131         (invalidate_bp_value_on_memory_change): Update.
4132         * alpha-tdep.c (alpha_register_to_value): Don't call value_free.
4133
4134 2018-04-06  Simon Marchi  <simon.marchi@polymtl.ca>
4135
4136         PR gdb/23022
4137         * warning.m4: Add -Wno-error=deprecated-register.
4138         * configure: Re-generate.
4139
4140 2018-04-05  Tom Tromey  <tom@tromey.com>
4141
4142         * linespec.h: Remove include of "vec.h".
4143
4144 2018-04-05  Tom Tromey  <tom@tromey.com>
4145
4146         * linespec.c (typep): Remove typedef.
4147         (find_methods, find_superclass_methods): Take a std::vector.
4148         (find_method): Use std::vector.
4149
4150 2018-04-05  Tom Tromey  <tom@tromey.com>
4151
4152         * utils.c (compare_strings): Remove.
4153         * utils.h (compare_strings): Remove.
4154         * objc-lang.h (find_imps): Update.
4155         * objc-lang.c (find_methods): Take a std::vector.
4156         (uniquify_strings, find_imps): Likewise.
4157         * linespec.c (find_methods): Take a std::vector.
4158         (decode_objc): Use std::vector.
4159         (add_all_symbol_names_from_pspace, find_superclass_methods): Take
4160         a std::vector.
4161         (find_method, find_function_symbols): Use std::vector.
4162
4163 2018-04-05  Tom Tromey  <tom@tromey.com>
4164
4165         * completer.c (completion_tracker::completion_tracker): Remove
4166         cast.
4167         (completion_tracker::discard_completions): Likewise.
4168         * breakpoint.c (ambiguous_names_p): Remove cast.
4169         * ada-lang.c (_initialize_ada_language): Remove cast.
4170         * utils.h (streq): Update.
4171         (streq_hash): Add new declaration.
4172         * utils.c (streq): Return bool.
4173         (streq_hash): New function.
4174
4175 2018-04-05  Tom Tromey  <tom@tromey.com>
4176
4177         * linespec.c (event_location_to_sals) <case ADDRESS_LOCATION>:
4178         Remove a string copy.
4179
4180 2018-04-05  Tom Tromey  <tom@tromey.com>
4181
4182         * linespec.c (filter_results): Use std::vector.
4183         (decode_line_2, decode_line_full): Update.
4184
4185 2018-04-05  Tom Tromey  <tom@tromey.com>
4186
4187         * linespec.c (canonical_to_fullform): Return std::string.
4188         (filter_results): Update.
4189         (struct decode_line_2_item): Add constructor.
4190         <fullform, displayform>: Now std::string.
4191         (decode_line_2_compare_items): Now a std::sort comparator.
4192         (decode_line_2): Update.
4193
4194 2018-04-05  Tom Tromey  <tom@tromey.com>
4195
4196         * linespec.c (copy_token_string): Return a unique_xmalloc_ptr.
4197         (unexpected_linespec_error): Update.
4198         (linespec_parse_basic, parse_linespec): Update.
4199
4200 2018-04-05  Tom Tromey  <tom@tromey.com>
4201
4202         * linespec.c (linespec_parse_basic): Reindent.
4203
4204 2018-04-05  Tom Tromey  <tom@tromey.com>
4205
4206         * minsyms.h (iterate_over_minimal_symbols): Update.
4207         * minsyms.c (iterate_over_minimal_symbols): Take a
4208         gdb::function_view.
4209         * linespec.c (struct collect_minsyms): Remove.
4210         (compare_msyms): Now a std::sort comparator.
4211         (add_minsym): Add parameters.
4212         (search_minsyms_for_name): Update.  Use std::vector.
4213
4214 2018-04-03  Tom Tromey  <tom@tromey.com>
4215
4216         * mipsread.c (read_alphacoff_dynamic_symtab): Use
4217         gdb::byte_vector.
4218
4219 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
4220
4221         * MAINTAINERS (Write After Approval): Add Weimin Pan.
4222
4223 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
4224
4225         PR gdb/16959
4226         * cp-valprint.c: (cp_print_static_field) Fix infinite recursion when
4227         printing static type.
4228
4229 2018-04-01  Tom Tromey  <tom@tromey.com>
4230
4231         * rs6000-nat.c (rs6000_ptrace_ldinfo): Return a byte_vector.
4232         (rs6000_xfer_shared_libraries): Update.
4233
4234 2018-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
4235
4236         * common/gdb_vecs.h (char_ptr): Remove.
4237         * tracepoint.c (encode_actions_1): Remove usage of char_ptr.
4238
4239 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
4240
4241         * guile/scm-utils.c (gdbscm_parse_function_args): Replace VEC
4242         with std::vector.
4243         * common/gdb_vecs.h (DEF_VEC_P (char_ptr)): Remove.
4244
4245 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
4246
4247         * tracepoint.h (struct uploaded_tp): Initialize fields.
4248         <actions, step_actions, cmd_strings>: Change type to
4249         std::vector<char *>.
4250         * tracepoint.c (get_uploaded_tp): Allocate with new.
4251         (free_uploaded_tps): Free with delete.
4252         (parse_tracepoint_definition): Adjust to std::vector change.
4253         * breakpoint.c (read_uploaded_action): Likewise.
4254         (create_tracepoint_from_upload): Likewise.
4255         * ctf.c (ctf_write_uploaded_tp): Likewise.
4256         (SET_ARRAY_FIELD): Likewise.
4257         * tracefile-tfile.c (tfile_write_uploaded_tp): Likewise.
4258
4259 2018-03-30  Tom Tromey  <tom@tromey.com>
4260
4261         * solib-svr4.c (lm_info_read): Use gdb::byte_vector.  Return
4262         std::unique_ptr.
4263         (svr4_keep_data_in_core): Update.
4264         (svr4_read_so_list): Update.
4265
4266 2018-03-30  Tom Tromey  <tom@tromey.com>
4267
4268         * windows-nat.c (handle_output_debug_string, handle_exception):
4269         Update.
4270         * target.h (target_read_string): Update.
4271         * target.c (target_read_string): Change "string" to
4272         unique_xmalloc_ptr.
4273         * solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
4274         Update.
4275         * solib-frv.c (frv_current_sos): Update.
4276         * solib-dsbt.c (dsbt_current_sos): Update.
4277         * solib-darwin.c (darwin_current_sos): Update.
4278         * linux-thread-db.c (inferior_has_bug): Update.
4279         * expprint.c (print_subexp_standard) <case OP_OBJC_MSGCALL>:
4280         Update.  Remove alloca.
4281         * ada-lang.c (ada_main_name): Update.
4282
4283 2018-03-30  Tom Tromey  <tom@tromey.com>
4284
4285         * dwarf2read.c (struct free_dwo_file_cleanup_data): Remove.
4286         (struct dwo_file_deleter): New.
4287         (dwo_file_up): New typedef.
4288         (open_and_init_dwo_file): Use dwo_file_up.
4289         (free_dwo_file_cleanup): Remove.
4290
4291 2018-03-30  Tom Tromey  <tom@tromey.com>
4292
4293         * dwarf2read.c (free_dwo_file): Remove "objfile" parameter.
4294         (free_dwo_file_cleanup, free_dwo_file_from_slot): Update.
4295
4296 2018-03-30  Tom Tromey  <tom@tromey.com>
4297
4298         * dwarf2read.c (class free_cached_comp_units): New class.
4299         (dw2_instantiate_symtab, dwarf2_build_psymtabs_hard): Use it.
4300         (free_cached_comp_units): Remove function.
4301
4302 2018-03-30  Tom Tromey  <tom@tromey.com>
4303
4304         * utils.h (make_cleanup_unpush_target): Remove.
4305         * inf-ptrace.c (struct target_unpusher): New.
4306         (target_unpush_up) New typedef.
4307         (inf_ptrace_create_inferior, inf_ptrace_attach): Use
4308         target_unpush_up.
4309         * utils.c (do_unpush_target, make_cleanup_unpush_target): Remove.
4310
4311 2018-03-27  Tom Tromey  <tom@tromey.com>
4312
4313         * utils.c (prompt_for_continue): Use unique_xmalloc_ptr.
4314
4315 2018-03-27  Pedro Alves  <palves@redhat.com>
4316             Tom Tromey  <tom@tromey.com>
4317
4318         * top.c (class gdb_readline_wrapper_cleanup): Add constructor,
4319         destructor.  Now a class.
4320         (gdb_readline_wrapper_cleanup): Remove function.
4321         (gdb_readline_wrapper): Remove cleanups.
4322
4323 2018-03-27  Tom Tromey  <tom@tromey.com>
4324
4325         * typeprint.h (struct type_print_options) <local_typedefs,
4326         global_typedefs>: Remove "struct" keyword.
4327         (class typedef_hash_table): New class.
4328         (recursively_update_typedef_hash, add_template_parameters)
4329         (create_typedef_hash, free_typedef_hash, copy_typedef_hash)
4330         (find_typedef_in_hash): Don't declare.
4331         * typeprint.c (struct typedef_hash_table): Move to typeprint.h.
4332         (typedef_hash_table::recursively_update): Rename from
4333         recursively_update_typedef_hash.  Now a member.
4334         (typedef_hash_table::add_template_parameters): Rename from
4335         add_template_parameters.  Now a member.
4336         (typedef_hash_table::typedef_hash_table): Now a constructor;
4337         rename from create_typedef_hash.
4338         (typedef_hash_table::~typedef_hash_table): Now a destructor;
4339         rename from free_typedef_hash.
4340         (do_free_typedef_hash, make_cleanup_free_typedef_hash)
4341         (do_free_global_table): Remove.
4342         (typedef_hash_table::typedef_hash_table): New constructor; renamed
4343         from copy_type_recursive.
4344         (create_global_typedef_table): Remove.
4345         (typedef_hash_table::find_global_typedef): Now a member of
4346         typedef_hash_table.
4347         (typedef_hash_table::find_typedef): Rename from
4348         find_typedef_in_hash; now a member.
4349         (whatis_exp): Update.
4350         * extension.h (struct ext_lang_type_printers): Add constructor and
4351         destructor.
4352         (start_ext_lang_type_printers, free_ext_lang_type_printers): Don't
4353         declare.
4354         * extension.c (ext_lang_type_printers::ext_lang_type_printers):
4355         Now a constructor; rename from start_ext_lang_type_printers.
4356         (ext_lang_type_printers): Now a destructor; rename from
4357         free_ext_lang_type_printers.
4358         * c-typeprint.c (find_typedef_for_canonicalize, c_print_type_1):
4359         Update.
4360         (c_type_print_base_struct_union): Update.  Remove cleanups.
4361
4362 2018-03-27  Tom Tromey  <tom@tromey.com>
4363
4364         * dwarf-index-write.c: Include <cmath>.
4365
4366 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
4367
4368         * NEWS: Add entry describing new "set|show varsize-limit" command.
4369         * ada-lang.c (_initialize_ada_language): Add "set/show varsize-limit"
4370         command.
4371         * printcmd.c (_initialize_printcmd): Add "set var" alias of
4372         "set variable".
4373
4374 2018-03-27  Simon Marchi  <simon.marchi@ericsson.com>
4375
4376         * Makefile.in (COMMON_SFILES): Add dwarf-index-common.c and
4377         dwarf-index-write.c
4378         (HFILES_NO_SRCDIR): Add dwarf-index-common.h and dwarf2read.h.
4379         * dwarf-index-common.c: New file.
4380         * dwarf-index-common.h: New file.
4381         * dwarf-index-write.c: New file.
4382         * dwarf2read.c: Include dwarf2read.h and dwarf-index-common.h.
4383         (struct dwarf2_section_info): Move from here.
4384         (dwarf2_section_info_def): Likewise.
4385         (DEF_VEC_O (dwarf2_section_info_def)): Likewise.
4386         (offset_type): Likewise.
4387         (DW2_GDB_INDEX_SYMBOL_STATIC_SET_VALUE): Likewise.
4388         (DW2_GDB_INDEX_SYMBOL_KIND_SET_VALUE): Likewise.
4389         (DW2_GDB_INDEX_CU_SET_VALUE): Likewise.
4390         (byte_swap): Likewise.
4391         (MAYBE_SWAP): Likewise.
4392         (dwarf2_per_cu_ptr): Likewise.
4393         (DEF_VEC_P (dwarf2_per_cu_ptr)): Likewise.
4394         (struct tu_stats): Likewise.
4395         (struct dwarf2_per_objfile): Likewise.
4396         (struct dwarf2_per_cu_data): Likewise.
4397         (struct signatured_type): Likewise.
4398         (sig_type_ptr): Likewise.
4399         (DEF_VEC_P (sig_type_ptr)): Likewise.
4400         (INDEX4_SUFFIX): Likewise.
4401         (INDEX5_SUFFIX): Likewise.
4402         (DEBUG_STR_SUFFIX): Likewise.
4403         (dwarf2_read_section): Make non-static.
4404         (mapped_index_string_hash): Move from here.
4405         (dwarf5_djb_hash): Likewise.
4406         (file_write): Likewise.
4407         (class data_buf): Likewise.
4408         (struct symtab_index_entry): Likewise.
4409         (struct mapped_symtab): Likewise.
4410         (find_slot): Likewise.
4411         (hash_expand): Likewise.
4412         (add_index_entry): Likewise.
4413         (uniquify_cu_indices): Likewise.
4414         (class c_str_view): Likewise.
4415         (class c_str_view_hasher): Likewise.
4416         (class vector_hasher): Likewise.
4417         (write_hash_table): Likewise.
4418         (psym_index_map): Likewise.
4419         (struct addrmap_index_data): Likewise.
4420         (add_address_entry): Likewise.
4421         (add_address_entry_worker): Likewise.
4422         (write_address_map): Likewise.
4423         (symbol_kind): Likewise.
4424         (write_psymbols): Likewise.
4425         (struct signatured_type_index_data): Likewise.
4426         (write_one_signatured_type): Likewise.
4427         (recursively_count_psymbols): Likewise.
4428         (recursively_write_psymbols): Likewise.
4429         (class debug_names): Likewise.
4430         (check_dwarf64_offsets): Likewise.
4431         (psyms_seen_size): Likewise.
4432         (write_gdbindex): Likewise.
4433         (write_debug_names): Likewise.
4434         (assert_file_size): Likewise.
4435         (write_psymtabs_to_index): Likewise.
4436         (save_gdb_index_command): Likewise.
4437         (_initialize_dwarf2_read): Don't register the "save gdb-index"
4438         command.
4439         * dwarf2read.h: New file.
4440
4441 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
4442
4443         PR gdb/22670
4444         * dwarf2read.c (dwarf2_physname): Do not return the demangled
4445         symbol name if the CU's language stores symbol names in linkage
4446         format.
4447         * language.h (struct language_defn)
4448         <la_store_sym_names_in_linkage_form_p>: New field.  Adjust
4449         all instances of this struct.
4450
4451 2018-03-26  Tom Tromey  <tom@tromey.com>
4452
4453         * stack.c (backtrace_command_1): Remove verbose code.
4454
4455 2018-03-26  Tom Tromey  <tom@tromey.com>
4456
4457         * python/py-framefilter.c (py_print_type): Don't catch
4458         exceptions.  Return void.
4459         (py_print_value): Likewise.
4460         (py_print_single_arg): Likewise.
4461         (enumerate_args): Don't catch exceptions.
4462         (py_print_args): Likewise.
4463         (py_print_frame): Likewise.
4464         (gdbpy_apply_frame_filter): Catch exceptions here.
4465
4466 2018-03-26  Tom Tromey  <tom@tromey.com>
4467
4468         * stack.c (_initialize_stack): Remove trailing newlines from help
4469         text.  Add "Usage" line to "backtrace" help.
4470
4471 2018-03-26  Tom Tromey  <tom@tromey.com>
4472
4473         PR python/16486:
4474         * python/py-framefilter.c (py_print_args): Call wrap_hint.
4475
4476 2018-03-26  Tom Tromey  <tom@tromey.com>
4477
4478         * python/py-framefilter.c (py_print_single_arg): Return
4479         EXT_LANG_BT_ERROR from catch.
4480
4481 2018-03-26  Tom Tromey  <tom@tromey.com>
4482
4483         PR backtrace/15584:
4484         * stack.c (backtrace_command_1): Move some code into no-filters
4485         "if".
4486
4487 2018-03-26  Tom Tromey  <tom@tromey.com>
4488
4489         * python/py-framefilter.c (throw_quit_or_print_exception): New
4490         function.
4491         (gdbpy_apply_frame_filter): Use it.
4492
4493 2018-03-26  Tom Tromey  <tom@tromey.com>
4494
4495         PR cli/17716:
4496         * python/py-framefilter.c (py_print_type, py_print_value)
4497         (enumerate_args, py_print_args, gdbpy_apply_frame_filter): Use
4498         RETURN_MASK_ERROR.
4499
4500 2018-03-26  Tom Tromey  <tom@tromey.com>
4501
4502         * python/py-framefilter.c (enumerate_args): Use
4503         gdb::unique_xmalloc_ptr.
4504
4505 2018-03-26  Tom Tromey  <tom@tromey.com>
4506
4507         * python/py-framefilter.c (py_print_frame): Return
4508         EXT_LANG_BT_OK.
4509         (gdbpy_apply_frame_filter): Update comment.
4510         * extension.h (enum ext_lang_bt_status) <EXT_LANG_BT_COMPLETED>:
4511         Remove.
4512         <EXT_LANG_BT_NO_FILTERS>: Change value.
4513
4514 2018-03-26  Tom Tromey  <tom@tromey.com>
4515
4516         PR backtrace/15582:
4517         * stack.c (backtrace_command): Parse "hide" argument.
4518         * python/py-framefilter.c (py_print_frame): Handle PRINT_HIDE.
4519         * extension.h (enum frame_filter_flags) <PRINT_HIDE>: New
4520         constant.
4521
4522 2018-03-26  Tom Tromey  <tom@tromey.com>
4523
4524         * stack.c (backtrace_command_1): Remove "show_locals" parameter,
4525         add "flags".
4526         (backtrace_command): Remove "fulltrace", add "flags".
4527
4528 2018-03-26  Tom Tromey  <tom@tromey.com>
4529
4530         * stack.c (backtrace_command): Rewrite command line parsing.
4531
4532 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
4533
4534         * dwarf2read.c (DEF_VEC_I(offset_type)): Remove.
4535
4536 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
4537
4538         * filename-seen-cache.h: Add include guard.
4539
4540 2018-03-26  Keith Seitz  <keiths@redhat.com>
4541
4542         * symfile.c (place_section): Remove "struct" from section_addr_info
4543         in comment.
4544         * windows-nat.c (struct safe_symbol_file_add_args) <addrs>: Remove
4545         "struct" keyword from section_addr_info.
4546
4547 2018-03-26  Alan Hayward  <alan.hayward@arm.com>
4548
4549         * regformats/regdef.h (reg): Add constructors.
4550
4551 2018-03-25  Pedro Alves  <palves@redhat.com>
4552
4553         * eval.c (evaluate_funcall): Swap OP_VAR_MSYM_VALUE/OP_VAR_VALUE
4554         if then/else bodies in var_func_name extraction.
4555
4556 2018-03-23  Weimin Pan  <weimin.pan@oracle.com>
4557
4558         * minsyms.c (lookup_minimal_symbol_and_objfile): Use
4559         lookup_minimal_symbol() to find symbol entry.
4560         * minsyms.h (lookup_minimal_symbol_and_objfile): Update comment.
4561
4562 2018-03-23  Keith Seitz  <keiths@redhat.com>
4563
4564         PR c++/22968
4565         * dwarf2read.c (scan_partial_symbols): Scan structs/classes for
4566         nested type definitions for C++, too.
4567
4568 2018-03-23  Tom Tromey  <tom@tromey.com>
4569
4570         * machoread.c (struct oso_el): Add a constructor.  Don't define as
4571         a typedef.
4572         (macho_register_oso): Remove.
4573         (macho_symtab_read): Take a std::vector.
4574         (oso_el_compare_name): Now a std::sort comparator.
4575         (macho_symfile_read_all_oso): Take a std::vector.
4576         (macho_symfile_read): Use std::vector.  Remove cleanups.
4577
4578 2018-03-22  Tom Tromey  <tom@tromey.com>
4579
4580         * record-full.c (record_full_exec_insn): Use gdb::byte_vector.
4581         (record_full_goto_bookmark): Use std::string.
4582
4583 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4584
4585         PR tdep/18295
4586         * rs6000-tdep.c (skip_prologue): Match both stwux and stdux
4587         a single mask.
4588
4589 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4590
4591         * rs6000-tdep.c (store_insn_p): New function.
4592         (skip_prologue): New variable alloca_reg_offset. Set lr_reg
4593         and cr_reg to their unshifted values. Use store_insn_p to
4594         match LR saves using either R1 or fdata->alloca_reg. Use
4595         store_insn_p to match CR saves. Set alloca_reg_offset
4596         when alloca_reg and framep are set. Remove lr_reg shift
4597         when assigning to fdata->lr_register.
4598
4599 2018-03-22  Andreas Arnez  <arnez@linux.vnet.ibm.com>
4600
4601         * linux-tdep.c (linux_info_proc): For "info proc cmdline", print
4602         command line args instead of emitting a warning.
4603
4604 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
4605
4606         * tracepoint.h (struct static_tracepoint_marker): Initialize
4607         fields, define default constructor, move constructor and move
4608         assignment, disable the rest.
4609         <str_id, extra>: Make std::string.
4610         (release_static_tracepoint_marker): Remove.
4611         (free_current_marker): Remove.
4612         * tracepoint.c (free_current_marker): Remove.
4613         (parse_static_tracepoint_marker_definition): Adjust to
4614         std::string, use new hex2str overload.
4615         (release_static_tracepoint_marker): Remove.
4616         (print_one_static_tracepoint_marker): Get marker by reference
4617         and adjust to std::string.
4618         (info_static_tracepoint_markers_command): Adjust to std::vector
4619         changes
4620         * target.h (static_tracepoint_marker_p): Remove typedef.
4621         (DEF_VEC_P(static_tracepoint_marker_p)): Remove.
4622         (struct target_ops) <to_static_tracepoint_marker_at>: Return
4623         bool.
4624         <to_static_tracepoint_markers_by_strid>: Return std::vector.
4625         * target-debug.h
4626         (target_debug_print_VEC_static_tracepoint_marker_p_p): Remove.
4627         (target_debug_print_std_vector_static_tracepoint_marker): New.
4628         (target_debug_print_struct_static_tracepoint_marker_p): Rename
4629         to...
4630         (target_debug_print_static_tracepoint_marker_p): ... this.
4631         * target-delegates.c: Re-generate.
4632         * breakpoint.h (struct tracepoint) <static_trace_marker_id>:
4633         Make std::string.
4634         * breakpoint.c (init_breakpoint_sal): Adjust to std::string.
4635         (decode_static_tracepoint_spec): Adjust to std::vector.
4636         (tracepoint_print_one_detail): Adjust to std::string.
4637         (strace_marker_decode_location): Adjust to std::string.
4638         (update_static_tracepoint): Adjust to std::string, remove call
4639         to release_static_tracepoint_marker.
4640         * linux-nat.c (linux_child_static_tracepoint_markers_by_strid):
4641         Adjust to std::vector.
4642         * remote.c (remote_static_tracepoint_marker_at): Return bool.
4643         (remote_static_tracepoint_markers_by_strid): Adjust to
4644         std::vector.
4645         * common/rsp-low.h (hex2str): New overload with explicit count
4646         of bytes.
4647         * common/rsp-low.c (hex2str): New overload with explicit count
4648         of bytes.
4649         * unittests/rsp-low-selftests.c (test_hex2str): New function.
4650         (_initialize_rsp_low_selftests): Add test_hex2str test.
4651         * unittests/tracepoint-selftests.c
4652         (test_parse_static_tracepoint_marker_definition): Adjust to
4653         std::string.
4654
4655 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
4656
4657         * tracepoint.c (parse_static_tracepoint_marker_definition):
4658         Consider case where the definition is followed by more
4659         definitions.
4660         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4661         tracepoint-selftests.c.
4662         * unittests/tracepoint-selftests.c: New.
4663
4664 2018-03-21  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4665
4666         * MAINTAINERS (Write After Approval): Add Pedro Franco de
4667         Carvalho.
4668
4669 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
4670
4671         * symtab.c (find_pc_sect_line): fixed indentation.
4672
4673 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
4674
4675         * symtab.c (find_pc_sect_line): now uses binary search.
4676
4677 2018-03-19  Tom Tromey  <tom@tromey.com>
4678
4679         * rust-exp.y (struct_expr_tail, struct_expr_list): Add plain
4680         "IDENT" production.
4681
4682 2018-03-19  Pedro Alves  <palves@redhat.com>
4683             Tom Tromey  <tom@tromey.com>
4684
4685         * unittests/observable-selftests.c: New file.
4686         * common/observable.h: New file.
4687         * observable.h: New file.
4688         * ada-lang.c, ada-tasks.c, agent.c, aix-thread.c, annotate.c,
4689         arm-tdep.c, auto-load.c, auxv.c, break-catch-syscall.c,
4690         breakpoint.c, bsd-uthread.c, cli/cli-interp.c, cli/cli-setshow.c,
4691         corefile.c, dummy-frame.c, event-loop.c, event-top.c, exec.c,
4692         extension.c, frame.c, gdbarch.c, guile/scm-breakpoint.c,
4693         infcall.c, infcmd.c, inferior.c, inflow.c, infrun.c, jit.c,
4694         linux-tdep.c, linux-thread-db.c, m68klinux-tdep.c,
4695         mi/mi-cmd-break.c, mi/mi-interp.c, mi/mi-main.c, objfiles.c,
4696         ppc-linux-nat.c, ppc-linux-tdep.c, printcmd.c, procfs.c,
4697         python/py-breakpoint.c, python/py-finishbreakpoint.c,
4698         python/py-inferior.c, python/py-unwind.c, ravenscar-thread.c,
4699         record-btrace.c, record-full.c, record.c, regcache.c, remote.c,
4700         riscv-tdep.c, sol-thread.c, solib-aix.c, solib-spu.c, solib.c,
4701         spu-multiarch.c, spu-tdep.c, stack.c, symfile-mem.c, symfile.c,
4702         symtab.c, thread.c, top.c, tracepoint.c, tui/tui-hooks.c,
4703         tui/tui-interp.c, valops.c: Update all users.
4704         * tui/tui-hooks.c (tui_bp_created_observer)
4705         (tui_bp_deleted_observer, tui_bp_modified_observer)
4706         (tui_inferior_exit_observer, tui_before_prompt_observer)
4707         (tui_normal_stop_observer, tui_register_changed_observer):
4708         Remove.
4709         (tui_observers_token): New global.
4710         (attach_or_detach, tui_attach_detach_observers): New functions.
4711         (tui_install_hooks, tui_remove_hooks): Use
4712         tui_attach_detach_observers.
4713         * record-btrace.c (record_btrace_thread_observer): Remove.
4714         (record_btrace_thread_observer_token): New global.
4715         * observer.sh: Remove.
4716         * observer.c: Rename to observable.c.
4717         * observable.c (namespace gdb_observers): Define new objects.
4718         (observer_debug): Move into gdb_observers namespace.
4719         (struct observer, struct observer_list, xalloc_observer_list_node)
4720         (xfree_observer_list_node, generic_observer_attach)
4721         (generic_observer_detach, generic_observer_notify): Remove.
4722         (_initialize_observer): Update.
4723         Don't include observer.inc.
4724         * Makefile.in (generated_files): Remove observer.h, observer.inc.
4725         (clean mostlyclean): Likewise.
4726         (observer.h, observer.inc): Remove targets.
4727         (SUBDIR_UNITTESTS_SRCS): Add observable-selftests.c.
4728         (COMMON_SFILES): Use observable.c, not observer.c.
4729         * .gitignore: Remove observer.h.
4730
4731 2018-03-18  Tom Tromey  <tom@tromey.com>
4732
4733         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Use
4734         gdb::def_vector.
4735         (bfd_lookup_symbol_from_dyn_symtab): Likewise.
4736
4737 2018-03-17  Tom Tromey  <tom@tromey.com>
4738
4739         * auto-load.c (auto_load_objfile_script_1): Use std::string.
4740
4741 2018-03-17  Tom Tromey  <tom@tromey.com>
4742
4743         * target.c (class scoped_target_fd): New.
4744         (target_fileio_close_cleanup): Remove.
4745         (target_fileio_read_alloc_1): Use scoped_target_fd.
4746
4747 2018-03-16  Simon Marchi  <simon.marchi@polymtl.ca>
4748
4749         * silent-rules.mk: New.
4750         * Makefile.in: Include silent-rules.mk
4751         (srcdir, VPATH, top_srcdir): Move up.
4752         (COMPILE): Add ECHO_CXX.
4753         (test-cp-name-parser$(EXEEXT)): Add ECHO_CXXLD.
4754         (init.c): Add ECHO_INIT_C.
4755         (gdb$(EXEEXT)): Add SILENCE and ECHO_CXXLD.
4756         (version.c): Add ECHO_GEN.
4757         (printcmd.o): Add ECHO_CXX.
4758         (target-float.o): Add ECHO_CXX.
4759         (ada-exp.o): Add ECHO_CXX.
4760         (stamp-xml): Add SILENCE and ECHO_GEN_XML_BUILTIN.
4761         (insight$(EXEEXT)): Add ECHO_CXXLD.
4762         * gnulib/configure.ac: Add AM_SILENT_RULES.
4763         * gnulib/aclocal.m4: Re-generate.
4764         * gnulib/configure: Re-generate.
4765         * gnulib/import/Makefile.in: Re-generate.
4766
4767 2018-03-16  Tom Tromey  <tom@tromey.com>
4768
4769         * xcoffread.c (xcoff_symfile_offsets): Change type of "addrs".
4770         * utils.h (make_cleanup_free_section_addr_info): Don't declare.
4771         * utils.c (do_free_section_addr_info)
4772         (make_cleanup_free_section_addr_info): Remove.
4773         * symfile.h (struct other_sections): Add constructor.
4774         (struct section_addr_info): Remove.
4775         (section_addr_info): New typedef.
4776         (struct sym_fns) <sym_offsets>: Change type of parameter.
4777         (build_section_addr_info_from_objfile)
4778         (relative_addr_info_to_section_offsets, addr_info_make_relative)
4779         (default_symfile_offsets, symbol_file_add)
4780         (symbol_file_add_from_bfd)
4781         (build_section_addr_info_from_section_table): Update.
4782         (alloc_section_addr_info, free_section_addr_info): Don't declare.
4783         * symfile.c (alloc_section_addr_info): Remove.
4784         (build_section_addr_info_from_section_table): Change return type.
4785         Update.
4786         (build_section_addr_info_from_bfd)
4787         (build_section_addr_info_from_objfile): Likewise.
4788         (free_section_addr_info): Remove.
4789         (relative_addr_info_to_section_offsets): Change type of "addrs".
4790         (addrs_section_compar): Now a std::sort comparator.
4791         (addrs_section_sort): Change return type.
4792         (addr_info_make_relative): Change type of "addrs".  Update.
4793         (default_symfile_offsets, syms_from_objfile_1)
4794         (syms_from_objfile, symbol_file_add_with_addrs): Likewise.
4795         (symbol_file_add_separate): Update.
4796         (symbol_file_add): Change type of "addrs".  Update.
4797         (add_symbol_file_command): Update.  Remove cleanups.
4798         * symfile-mem.c (symbol_file_add_from_memory): Update.  Remove
4799         cleanups.
4800         * symfile-debug.c (debug_sym_offsets): Change type of "info".
4801         * solib.c (solib_read_symbols): Update.
4802         * objfiles.c (objfile_relocate): Update.  Remove cleanups.
4803         * machoread.c (macho_symfile_offsets): Update.
4804         * jit.c (jit_bfd_try_read_symtab): Update.
4805
4806 2018-03-15  Simon Marchi  <simon.marchi@polymtl.ca>
4807
4808         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4809         unittests/utils-selftests.c.
4810         * unittests/utils-selftests.c: New file.
4811
4812 2018-03-14  Tom Tromey  <tom@tromey.com>
4813
4814         PR cli/14977:
4815         * printcmd.c (printf_c_string, printf_wide_c_string): Special case
4816         for NULL.
4817
4818 2018-03-14  Tom Tromey  <tom@tromey.com>
4819
4820         PR cli/19918:
4821         * printcmd.c (printf_pointer): Allow "-" in format.
4822
4823 2018-03-14  Tom Tromey  <tom@tromey.com>
4824
4825         * printcmd.c (_initialize_printcmd): Add usage to printf.
4826
4827 2018-03-14  Yao Qi  <qiyao@sourceware.org>
4828
4829         * MAINTAINERS: Update my email address.
4830
4831 2018-03-13  Tom Tromey  <tom@tromey.com>
4832
4833         * machoread.c (macho_check_dsym): Change filenamep to a
4834         std::string*.
4835         (macho_symfile_read): Update.
4836         * symfile.c (load_command): Use std::string.
4837
4838 2018-03-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4839
4840         * riscv-tdep.c (riscv_sw_breakpoint_from_kind): Add localization
4841         to error message string.
4842         (riscv_register_name): Use xsnprintf instead of sprintf.
4843         (riscv_insn::fetch_instruction): Use gdb_assert instead of
4844         internal_error.
4845         (riscv_print_arg_location): Use gdb_assert_not_reached instead of
4846         error.
4847         (riscv_push_dummy_call): Likewise.
4848
4849 2018-03-12  Tom Tromey  <tom@tromey.com>
4850
4851         * rs6000-aix-tdep.c (rs6000_aix_core_xfer_shared_libraries_aix):
4852         Use gdb::byte_vector.
4853         * arm-tdep.c (arm_exidx_new_objfile): Use gdb::byte_vector.
4854
4855 2018-03-12  Yao Qi  <yao.qi@linaro.org>
4856
4857         * ia64-libunwind-tdep.c (libunwind_get_reg_special): Change
4858         parameter type to readable_regcache.
4859         * ia64-libunwind-tdep.h (libunwind_get_reg_special): Update
4860         the declaration.
4861
4862 2018-03-11  Tom Tromey  <tom@tromey.com>
4863
4864         * dwarf2read.c (struct nextfield): Add initializers.
4865         (struct nextfnfield): Remove.
4866         (struct fnfieldlist): Add initializers.  Remove "length" and
4867         "head", use std::vector.
4868         (struct decl_field_list): Remove.
4869         (struct field_info): Add initializers.
4870         <fields, baseclasses>: Now std::vector.
4871         <nbaseclasses, nfnfields, typedef_field_list_count,
4872         nested_types_list_count>: Remove.
4873         (dwarf2_add_field, dwarf2_add_type_defn)
4874         (dwarf2_attach_fields_to_type, dwarf2_add_member_fn)
4875         (dwarf2_attach_fn_fields_to_type, handle_struct_member_die)
4876         (process_structure_scope): Update.
4877
4878 2018-03-11  Tom Tromey  <tom@tromey.com>
4879
4880         * dwarf2read.c (sort_tu_by_abbrev_offset): Change to be suitable
4881         for use by std::sort.
4882         (build_type_psymtabs_1): Use std::vector.
4883
4884 2018-03-09  Eli Zaretskii  <eliz@gnu.org>
4885
4886         * top.c (print_gdb_configuration): Reflect LIBIPT, LIBMEMCHECK,
4887         and LIBMPFR in the printed configuration.
4888
4889 2018-03-08  Tom Tromey  <tom@tromey.com>
4890
4891         * source.c (get_filename_and_charpos): Use scoped_fd.
4892         * nto-procfs.c (procfs_open_1): Use scoped_fd.
4893         (procfs_pidlist): Likewise.
4894         * procfs.c (proc_get_LDT_entry): Use scoped_fd.
4895         (iterate_over_mappings): Likewise.
4896
4897 2018-03-08  Tom Tromey  <tom@tromey.com>
4898
4899         * infcall.c (struct call_return_meta_info)
4900         <stack_temporaries_enabled>: Remove.
4901         (get_call_return_value, call_function_by_hand_dummy): Update.
4902         * thread.c (disable_thread_stack_temporaries): Remove.
4903         (enable_thread_stack_temporaries): Remove.
4904         (thread_stack_temporaries_enabled_p): Return bool.
4905         (push_thread_stack_temporary, value_in_thread_stack_temporaries)
4906         (get_last_thread_stack_temporary): Update.
4907         * eval.c (evaluate_subexp): Update.
4908         * gdbthread.h (class enable_thread_stack_temporaries): Now a
4909         class, not a function.
4910         (value_ptr, value_vec): Remove typedefs.
4911         (class thread_info) <stack_temporaries_enabled>: Now bool.
4912         <stack_temporaries>: Now a std::vector.
4913         (thread_stack_temporaries_enabled_p)
4914         (value_in_thread_stack_temporaries): Return bool.
4915
4916 2018-03-08  Simon Marchi  <simon.marchi@ericsson.com>
4917
4918         * remote.c (putpkt_binary): Fix omitted bytes reporting.
4919         (getpkt_or_notif_sane_1): Likewise.
4920
4921 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
4922
4923         * build-id.c (build_id_to_debug_bfd): Use std::string.
4924
4925 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
4926
4927         * build-id.c (find_separate_debug_file_by_buildid): Return
4928         std::string.
4929         * build-id.h (find_separate_debug_file_by_buildid): Return
4930         std::string.
4931         * coffread.c (coff_symfile_read): Adjust to std::string.
4932         * elfread.c (elf_symfile_read): Adjust to std::string.
4933         * symfile.c (separate_debug_file_exists): Change parameter to
4934         std::string.
4935         (find_separate_debug_file): Return std::string.
4936         (find_separate_debug_file_by_debuglink): Return std::string.
4937         * symfile.h (find_separate_debug_file_by_debuglink): Return
4938         std::string.
4939
4940 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
4941
4942         * common/xml-utils.c (xml_escape_text): Move code to...
4943         (xml_escape_text_append): ... this new function.
4944         * common/xml-utils.h (xml_escape_text_append): New declaration.
4945         * unittests/xml-utils-selftests.c (test_xml_escape_text_append):
4946         New function.
4947         (_initialize_xml_utils): register test_xml_escape_text_append as
4948         a selftest.
4949
4950 2018-03-07  Alan Hayward  <alan.hayward@arm.com>
4951
4952         * defs.h: Remove MAX_REGISTER_SIZE.
4953         * regcache.c (init_regcache_descr): Remove MAX_REGISTER_SIZE
4954         asserts.
4955         * python/py-unwind.c (pyuw_sniffer): Likewise.
4956
4957 2018-03-07  Tom Tromey  <tom@tromey.com>
4958
4959         * linux-tdep.c (linux_info_proc): Update.
4960         * target.h (struct target_ops) <to_fileio_readlink>: Return
4961         optional<string>.
4962         (target_fileio_readlink): Return optional<string>.
4963         * remote.c (remote_hostio_readlink): Return optional<string>.
4964         * inf-child.c (inf_child_fileio_readlink): Return
4965         optional<string>.
4966         * target.c (target_fileio_readlink): Return optional<string>.
4967
4968 2018-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4969
4970         * regcache.c (cooked_read_test): Add riscv to the list of
4971         architectures that have a save_reggroup.
4972
4973 2018-03-07  Andreas Arnez  <arnez@linux.vnet.ibm.com>
4974
4975         * gnu-v3-abi.c (gnuv3_rtti_type): Add early exit if the given
4976         value is not a dynamic class object.
4977
4978 2018-03-06  Tom Tromey  <tom@tromey.com>
4979
4980         * rust-exp.y: Formatting fixes.
4981
4982 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4983
4984         * riscv-tdep.c (riscv_register_name): Remove target description
4985         support.
4986         (riscv_gdbarch_init): Remove target description check.
4987
4988 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4989
4990         * riscv-tdep.c: Remove 'Contributed by ...' lines from header
4991         comment.
4992         * riscv-tdep.h: Likewise.
4993
4994 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4995
4996         * riscv-tdep.c (riscv_pseudo_register_read): Delete.
4997         (riscv_pseudo_register_write): Delete.
4998         (riscv_gdbarch_init): Remove all use of pseudo registers.
4999
5000 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
5001
5002         * record-btrace.c (btrace_print_lines): Replace cleanup
5003         parameter with RAII equivalents.
5004         (btrace_insn_history): Replace cleanup with RAII equivalents.
5005         * ui-out.h (make_cleanup_ui_out_list_begin_end,
5006         make_cleanup_ui_out_tuple_begin_end): Remove.
5007         * ui-out.c (struct ui_out_end_cleanup_data, do_cleanup_end,
5008         make_cleanup_ui_out_end, make_cleanup_ui_out_tuple_begin_end,
5009         make_cleanup_ui_out_list_begin_end): Remove.
5010
5011 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
5012
5013         * record-btrace.c (record_btrace_maybe_mark_async_event): Change
5014         parameter types to std::vector.  Use bool.
5015         (record_btrace_wait): Replace VEC(tp_t) with
5016         std::vector<thread_info *>.
5017         * common/gdb_vecs.h (unordered_remove, ordered_remove): New.
5018
5019 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
5020
5021         * record-btrace.c (record_btrace_disable_callback): Remove.
5022         (struct scoped_btrace_disable): New.
5023         (record_btrace_open): Use scoped_btrace_disable.
5024
5025 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5026
5027         * riscv-tdep.c (riscv_return_value): Change type to ULONGEST for
5028         reading values from registers.
5029
5030 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5031
5032         * riscv-tdep.c (riscv_push_dummy_call): Use core_addr_to_string_nz
5033         where appropriate.
5034
5035 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5036
5037         * riscv-tdep.c (riscv_print_arg_location): Add header comment,
5038         change parameter type.  Use GDB's print functions, and use
5039         core_addr_to_string where appropriate.
5040         (riscv_push_dummy_call): Use core_addr_to_string where
5041         appropriate, update call to riscv_print_arg_location, and reindent
5042         a few lines.
5043         (riscv_return_value): Update call to riscv_print_arg_location.
5044
5045 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5046             Tim Newsome <tim@sifive.com>
5047             Albert Ou <a0u@eecs.berkeley.edu>
5048             Darius Rad <darius@bluespec.com>
5049
5050         * Makefile.in (ALL_TARGET_OBS): Add riscv-tdep.o
5051         (HFILES_NO_SRCDIR): Add riscv-tdep.h.
5052         (ALLDEPFILES): Add riscv-tdep.c
5053         * configure.tgt: Add riscv support.
5054         * riscv-tdep.c: New file.
5055         * riscv-tdep.h: New file.
5056         * NEWS: Mention new target.
5057         * MAINTAINERS: Add entry for riscv.
5058
5059 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5060
5061         * amd64-tdep.c (amd64_classify_aggregate): Ignore zero sized
5062         fields within aggregates.
5063
5064 2018-03-04  Simon Marchi  <simon.marchi@polymtl.ca>
5065
5066         * record-btrace.c (btrace_print_lines): Change type of flags to
5067         gdb_disassembly_flags.
5068
5069 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
5070
5071         * fbsd-nat.c: Include "inf-ptrace.h".
5072         (USE_SIGTRAP_SIGINFO): Conditionally define.
5073         [USE_SIGTRAP_SIGINFO] (fbsd_handle_debug_trap): New function.
5074         (fbsd_wait) [USE_SIGTRAP_SIGINFO]: Call "fbsd_handle_debug_trap".
5075         [USE_SIGTRAP_SIGINFO] (fbsd_stopped_by_sw_breakpoint): New
5076         function.
5077         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_sw_breakpoint):
5078         Likewise.
5079         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_hw_breakpoint):
5080         Likewise.
5081         (fbsd_nat_add_target) [USE_SIGTRAP_SIGINFO]: Set
5082         "stopped_by_sw_breakpoint", "supports_stopped_by_sw_breakpoint",
5083         "supports_stopped_by_hw_breakpoint" target methods.
5084
5085 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
5086
5087         * NEWS (Changes since GDB 8.1): Add "set/show debug fbsd-nat".
5088         * fbsd-nat.c (debug_fbsd_nat): New variable.
5089         (show_fbsd_nat_debug): New function.
5090         (fbsd_wait): Log LWP info if "debug_fbsd_nat" is enabled.
5091         (_initialize_fbsd_nat): Add "fbsd-nat" debug boolean command.
5092
5093 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
5094
5095         * nat/x86-dregs.c (x86_dr_stopped_by_hw_breakpoint): New function.
5096         * nat/x86-dregs.h (x86_dr_stopped_by_hw_breakpoint): New
5097         prototype.
5098         * x86-nat.c (x86_stopped_by_hw_breakpoint): New function.
5099         (x86_use_watchpoints): Set "stopped_by_hw_breakpoint" target
5100         method.
5101
5102 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5103
5104         * common/gdb_vecs.c (free_char_ptr_vec): Remove.
5105         * common/gdb_vecs.h (free_char_ptr_vec): Remove.
5106
5107 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5108
5109         * charset.c (struct charset_vector): New.
5110         (charsets): Change type to charset_vector.
5111         (find_charset_names): Adjust.
5112         (add_one): Adjust.
5113         (_initialize_charset): Adjust.
5114
5115 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5116
5117         * progspace.h (struct program_space) <deleted_solibs>: Change
5118         type to std::vector<std::string>.
5119         * progspace.c (clear_program_space_solib_cache): Adjust.
5120         * breakpoint.c (print_solib_event): Adjust.
5121         (check_status_catch_solib): Adjust.
5122         * solib.c (update_solib_list): Adjust.
5123         * ui-out.h (class ui_out) <field_string>: New overload.
5124         * ui-out.c (ui_out::field_string): New overload.
5125
5126 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5127
5128         * progspace.h (struct program_space): Add constructor and
5129         destructor, initialize fields.
5130         (add_program_space): Remove.
5131         * progspace.c (add_program_space): Rename to...
5132         (program_space::program_space): ... this.
5133         (release_program_space): Rename to...
5134         (program_space::~program_space): ... this.
5135         (delete_program_space): Use delete to delete program_space.
5136         (initialize_progspace): Use new to allocate program_space.
5137         * inferior.c (add_inferior_with_spaces): Likewise.
5138         (clone_inferior_command): Likewise.
5139         * infrun.c (follow_fork_inferior): Likewise.
5140         (handle_vfork_child_exec_or_exit): Likewise.
5141
5142 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5143
5144         * common/gdb_vecs.h (make_cleanup_free_char_ptr_vec): Remove.
5145         (delim_string_to_char_ptr_vec): Return std::vector of
5146         gdb::unique_xmalloc_ptr.
5147         (dirnames_to_char_ptr_vec_append): Take std::vector of
5148         gdb::unique_xmalloc_ptr.
5149         (dirnames_to_char_ptr_vec): Return std::vector of
5150         gdb::unique_xmalloc_ptr.
5151         * common/gdb_vecs.c (delim_string_to_char_ptr_vec_append):
5152         Take std::vector of gdb::unique_xmalloc_ptr, adjust the code.
5153         (delim_string_to_char_ptr_vec): Return an std::vector of
5154         gdb::unique_xmalloc_ptr, adjust the code.
5155         (dirnames_to_char_ptr_vec_append): Take an std::vector of
5156         gdb::unique_xmalloc_ptr, adjust the code.
5157         (dirnames_to_char_ptr_vec): Return an std::vector of
5158         gdb::unique_xmalloc_ptr, adjust the code.
5159         * auto-load.c (auto_load_safe_path_vec): Change type to
5160         std::vector of gdb::unique_xmalloc_ptr.
5161         (auto_load_expand_dir_vars): Return an std::vector of
5162         gdb::unique_xmalloc_ptr, adjust the code.
5163         (auto_load_safe_path_vec_update): Adjust.
5164         (filename_is_in_auto_load_safe_path_vec): Adjust.
5165         (auto_load_objfile_script_1): Adjust.
5166         * build-id.c (build_id_to_debug_bfd): Adjust.
5167         * linux-thread-db.c (thread_db_load_search): Adjust.
5168         * source.c (add_path): Adjust.
5169         (openp): Adjust.
5170         * symfile.c (find_separate_debug_file): Adjust.
5171         * utils.c (do_free_char_ptr_vec): Remove.
5172         (make_cleanup_free_char_ptr_vec): Remove.
5173
5174 2018-03-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5175
5176         PR gdb/22907
5177         * common/pathstuff.c: Conditionally include "<windows.h>".
5178
5179 2018-03-01  Georg Sauthoff  <mail@georg.so>
5180
5181         PR gdb/22888
5182         * gcore.in: Quote variables and switch interpreter to bash.
5183
5184 2018-03-01  Tom Tromey  <tom@tromey.com>
5185
5186         * dwarf2read.c (alloc_discriminant_info): Fix default_index
5187         assertion.  Add assertion for discriminant_index.
5188         (quirk_rust_enum): Use correct base type name in univariant case.
5189
5190 2018-03-01  Simon Marchi  <simon.marchi@ericsson.com>
5191
5192         * record.c (get_call_history_modifiers): Return a
5193         record_print_flags.
5194         (cmd_record_call_history): Adjust.
5195         * record-btrace.c (record_btrace_call_history): Adjust.
5196         (record_btrace_call_history_range): Adjust.
5197         (record_btrace_call_history_from): Adjust.
5198         * target-debug.h (target_debug_print_record_print_flags): New.
5199         * target-delegates.c: Re-generate.
5200         * target.c (target_call_history): Change flags type.
5201         (target_call_history_from): Likewise.
5202         (target_call_history_range): Likewise.
5203         * target.h (struct target_ops) <target_call_history>: Likewise.
5204         (target_call_history_from): Likewise.
5205         (target_call_history_range): Likewise.
5206
5207 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5208             Simon Marchi  <simon.marchi@polymtl.ca>
5209
5210         * common/common-utils.c: Include "sys/stat.h".
5211         (is_regular_file): Move here from "source.c"; change return
5212         type to "bool".
5213         * common/common-utils.h (is_regular_file): New prototype.
5214         * common/pathstuff.c (contains_dir_separator): New function.
5215         * common/pathstuff.h (contains_dir_separator): New prototype.
5216         * source.c: Don't include "sys/stat.h".
5217         (is_regular_file): Move to "common/common-utils.c".
5218
5219 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5220
5221         * Makefile.in (COMMON_SFILES): Add "common/pathstuff.c".
5222         (HFILES_NO_SRCDIR): Add "common/pathstuff.h".
5223         * auto-load.c: Include "common/pathstuff.h".
5224         * common/common-def.h (current_directory): Move here.
5225         * common/gdb_tilde_expand.c (gdb_tilde_expand_up): New
5226         function.
5227         * common/gdb_tilde_expand.h (gdb_tilde_expand_up): New
5228         prototype.
5229         * common/pathstuff.c: New file.
5230         * common/pathstuff.h: New file.
5231         * compile/compile.c: Include "common/pathstuff.h".
5232         * defs.h (current_directory): Move to "common/common-defs.h".
5233         * dwarf2read.c: Include "common/pathstuff.h".
5234         * exec.c: Likewise.
5235         * guile/scm-safe-call.c: Likewise.
5236         * linux-thread-db.c: Likewise.
5237         * main.c: Likewise.
5238         * nto-tdep.c: Likewise.
5239         * objfiles.c: Likewise.
5240         * source.c: Likewise.
5241         * symtab.c: Likewise.
5242         * utils.c: Include "common/pathstuff.h".
5243         (gdb_realpath): Move to "common/pathstuff.c".
5244         (gdb_realpath_keepfile): Likewise.
5245         (gdb_abspath): Likewise.
5246         * utils.h (gdb_realpath): Move to "common/pathstuff.h".
5247         (gdb_realpath_keepfile): Likewise.
5248         (gdb_abspath): Likewise.
5249
5250 2018-02-28  John Baldwin  <jhb@FreeBSD.org>
5251
5252         * fbsd-nat.c (fbsd_resume): Use PT_SETSTEP for stepping and a
5253         wildcard process pid for super_resume for kernels with a
5254         specific bug.
5255
5256 2018-02-27  Phil Muldoon  <pmuldoon@redhat.com>
5257
5258         * compile/compile.c (get_args): Add additional comments
5259         explaining function.
5260
5261 2018-02-27  Simon Marchi  <simon.marchi@polymtl.ca>
5262             Tom Tromey  <tom@tromey.com>
5263
5264         * target.h (memory_write_request_s): Remove typedef.  Don't define
5265         VEC.
5266         (target_write_memory_blocks): Change argument to std::vector.
5267         (struct memory_write_request): Add constructor.
5268         * target-memory.c (compare_block_starting_address): Return bool.
5269         Change argument types.
5270         (claim_memory): Change arguments to use std::vector.
5271         (split_regular_and_flash_blocks, blocks_to_erase)
5272         (compute_garbled_blocks): Likewise.
5273         (cleanup_request_data, cleanup_write_requests_vector): Remove.
5274         (target_write_memory_blocks): Change argument to std::vector.
5275         * symfile.c (struct load_section_data): Add constructor and
5276         destructor.  Use std::vector for "requests".
5277         (struct load_progress_data): Add initializers.
5278         (load_section_callback): Update.  Use "new".
5279         (clear_memory_write_data): Remove.
5280         (generic_load): Update.
5281
5282 2018-02-27  Alan Hayward  <alan.hayward@arm.com>
5283
5284         * arch/aarch64.h: Use common/tdesc.h.
5285
5286 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
5287
5288         * mips-tdep.c (mips_gdbarch_init): Don't use a 32-bit BFD
5289         architecture with a 64-bit ABI.
5290
5291 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
5292
5293         * gdb/mips-tdep.c (mips_gdbarch_init): Reorder ABI determination
5294         ahead of target description loading.
5295
5296 2018-02-26  Tom Tromey  <tom@tromey.com>
5297
5298         * stack.c (backtrace_command_1): Update.
5299         * python/python-internal.h (gdbpy_apply_frame_filter): Change type
5300         of "flags".
5301         * python/py-framefilter.c (py_print_frame)
5302         (gdbpy_apply_frame_filter): Change type of "flags".
5303         * mi/mi-cmd-stack.c (mi_apply_ext_lang_frame_filter): Change type
5304         of "flags".
5305         (mi_cmd_stack_list_frames, mi_cmd_stack_list_locals)
5306         (mi_cmd_stack_list_args, mi_cmd_stack_list_variables): Update.
5307         * extension.h (enum frame_filter_flag): Rename from
5308         frame_filter_flags.
5309         (frame_filter_flags): Define using DEF_ENUM_FLAGS_TYPE.
5310         (apply_ext_lang_frame_filter): Change type of "flags".
5311         * extension.c (apply_ext_lang_frame_filter): Change type of
5312         "flags".
5313         * extension-priv.h (struct extension_language_ops)
5314         <apply_frame_filter>: Change type of "flags".
5315
5316 2018-02-26  Tom Tromey  <tom@tromey.com>
5317
5318         PR python/16497:
5319         * stack.c (backtrace_command_1): Set PRINT_MORE_FRAMES flag.  Fix
5320         off-by-one in py_end computation.
5321         * python/py-framefilter.c (gdbpy_apply_frame_filter): Handle
5322         PRINT_MORE_FRAMES.
5323         * extension.h (enum frame_filter_flags) <PRINT_MORE_FRAMES>: New
5324         constant.
5325
5326 2018-02-26  Tom Tromey  <tom@tromey.com>
5327
5328         * dwarf2read.c (struct variant_field): New.
5329         (struct nextfield) <variant>: New field.
5330         (dwarf2_add_field): Handle DW_TAG_variant_part.
5331         (dwarf2_attach_fields_to_type): Attach a discriminant_info to a
5332         discriminated union.
5333         (read_structure_type): Handle DW_TAG_variant_part.
5334         (handle_struct_member_die): New function, extracted from
5335         process_structure_scope.  Handle DW_TAG_variant.
5336         (process_structure_scope): Handle discriminated unions.  Call
5337         handle_struct_member_die.
5338
5339 2018-02-26  Tom Tromey  <tom@tromey.com>
5340
5341         * rust-lang.h (rust_last_path_segment): Declare.
5342         * rust-lang.c (rust_last_path_segment): Now public.  Change
5343         contract.
5344         (struct disr_info): Remove.
5345         (RUST_ENUM_PREFIX, RUST_ENCODED_ENUM_REAL)
5346         (RUST_ENCODED_ENUM_HIDDEN, rust_union_is_untagged)
5347         (rust_get_disr_info, rust_tuple_variant_type_p): Remove.
5348         (rust_enum_p, rust_enum_variant): New function.
5349         (rust_underscore_fields): Remove "offset" parameter.
5350         (rust_print_enum): New function.
5351         (rust_val_print) <TYPE_CODE_UNION>: Remove enum code.
5352         <TYPE_CODE_STRUCT>: Call rust_print_enum when appropriate.
5353         (rust_print_struct_def): Add "for_rust_enum" parameter.  Handle
5354         enums.
5355         (rust_internal_print_type): New function, from rust_print_type.
5356         Remove enum code.
5357         (rust_print_type): Call rust_internal_print_type.
5358         (rust_evaluate_subexp) <STRUCTOP_ANONYMOUS, STRUCTOP_STRUCT>:
5359         Update enum handling.
5360         * dwarf2read.c (struct dwarf2_cu) <rust_unions>: New field.
5361         (rust_fully_qualify, alloc_discriminant_info, quirk_rust_enum)
5362         (rust_union_quirks): New functions.
5363         (process_full_comp_unit, process_full_type_unit): Call
5364         rust_union_quirks.
5365         (process_structure_scope): Update rust_unions if necessary.
5366
5367 2018-02-26  Tom Tromey  <tom@tromey.com>
5368
5369         * value.h (value_union_variant): Declare.
5370         * valops.c (value_union_variant): New function.
5371         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): New macro.
5372         (struct discriminant_info): New.
5373         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: New
5374         enumerator.
5375         (struct main_type) <flag_discriminated_union>: New field.
5376
5377 2018-02-26  Tom Tromey  <tom@tromey.com>
5378
5379         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5380         unittests/unpack-selftests.c.
5381         * unittests/unpack-selftests.c: New file.
5382         * value.c (unpack_bits_as_long): Fix bugs in non-bitfield cases.
5383
5384 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5385
5386         * dwarf2read.c (struct partial_die_info) <read>: New method.
5387         (read_partial_die): Remove the declaration.
5388         (load_partial_dies): Update.
5389         (partial_die_info::partial_die_info):
5390         (read_partial_die): Change it to partial_die_info::read.
5391
5392 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5393
5394         * dwarf2read.c (struct partial_die_info) <fixup>: New method.
5395         (fixup_partial_die): Remove declaration.
5396         (scan_partial_symbols): Update.
5397         (partial_die_parent_scope): Likewise.
5398         (partial_die_full_name): Likewise.
5399         (fixup_partial_die): Change it to partial_die_info::fixup.
5400
5401 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5402
5403         * dwarf2read.c (read_partial_die): Update the declaration.
5404         (load_partial_dies): Caller update.
5405         (read_partial_die): Remove one argument abbrev_len.
5406
5407 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5408
5409         * dwarf2read.c (struct partial_die_info): Add ctor, delete
5410         assignment operator.
5411         (load_partial_dies): Use ctor and copy ctor.
5412         (read_partial_die): Update.
5413         (dwarf2_cu::find_partial_die): Use ctor.
5414
5415 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5416
5417         * dwarf2read.c (struct dwarf2_cu) <find_partial_die>: New method.
5418         (find_partial_die_in_comp_unit): Change it to
5419         dwarf2_cu::find_partial_die.
5420         (find_partial_die): Update.
5421
5422 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5423
5424         * dwarf2read.c (read_partial_die): Remove the code checking abbrev
5425         is NULL.
5426
5427 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5428
5429         * dwarf2read.c (load_partial_dies): Move the location of XOBNEW.
5430
5431 2018-02-26  Alan Hayward  <alan.hayward@arm.com>
5432
5433         * arch/amd64.h: Use common/tdesc.h.
5434         * arch/i386.c: Likewise.
5435         * arch/i386.h: Likewise.
5436         * arch/tic6x.c: Likewise.
5437         * arch/tdesc.h: Move file from here...
5438         * common/tdesc.h: ...to here.
5439         * features/aarch64-core.c: Regenerate.
5440         * features/aarch64-fpu.c: Regenerate.
5441         * features/i386/32bit-avx.c: Regenerate.
5442         * features/i386/32bit-avx512.c: Regenerate.
5443         * features/i386/32bit-core.c: Regenerate.
5444         * features/i386/32bit-linux.c: Regenerate.
5445         * features/i386/32bit-mpx.c: Regenerate.
5446         * features/i386/32bit-pkeys.c: Regenerate.
5447         * features/i386/32bit-sse.c: Regenerate.
5448         * features/i386/64bit-avx.c: Regenerate.
5449         * features/i386/64bit-avx512.c: Regenerate.
5450         * features/i386/64bit-core.c: Regenerate.
5451         * features/i386/64bit-linux.c: Regenerate.
5452         * features/i386/64bit-mpx.c: Regenerate.
5453         * features/i386/64bit-pkeys.c: Regenerate.
5454         * features/i386/64bit-segments.c: Regenerate.
5455         * features/i386/64bit-sse.c: Regenerate.
5456         * features/i386/x32-core.c: Regenerate.
5457         * features/tic6x-c6xp.c: Regenerate.
5458         * features/tic6x-core.c: Regenerate.
5459         * features/tic6x-gp.c: Regenerate.
5460         * target-descriptions.c: Use common/tdesc.h.
5461         * target-descriptions.h: Likewise.
5462
5463 2018-02-24  Tom Tromey  <tom@tromey.com>
5464
5465         * linux-thread-db.c (try_thread_db_load_from_pdir_1)
5466         (try_thread_db_load_from_dir, thread_db_load_search): Use
5467         std::string.
5468         (info_auto_load_libthread_db_compare): Return bool.  Change
5469         argument types.
5470         (info_auto_load_libthread_db): Use std::vector, std::string.
5471         Remove cleanups.
5472
5473 2018-02-24  Tom Tromey  <tom@tromey.com>
5474
5475         * i386-tdep.c (i386_fast_tracepoint_valid_at): "msg" now a
5476         std::string.
5477         * gdbarch.sh (fast_tracepoint_valid_at): Change "msg" to a
5478         std::string*.
5479         * gdbarch.c: Rebuild.
5480         * gdbarch.h: Rebuild.
5481         * breakpoint.c (check_fast_tracepoint_sals): Use std::string.
5482         * arch-utils.h (default_fast_tracepoint_valid_at): Update.
5483         * arch-utils.c (default_fast_tracepoint_valid_at): "msg" now a
5484         std::string*.
5485
5486 2018-02-23  Simon Marchi  <simon.marchi@polymtl.ca>
5487
5488         * gdbtypes.h (sect_offset): Change type to uint64_t.
5489         (sect_offset_str): New function.
5490         * dwarf2read.c (create_addrmap_from_aranges): Use
5491         sect_offset_str.
5492         (error_check_comp_unit_head): Likewise.
5493         (create_debug_type_hash_table): Likewise.
5494         (read_cutu_die_from_dwo): Likewise.
5495         (init_cutu_and_read_dies): Likewise.
5496         (init_cutu_and_read_dies_no_follow): Likewise.
5497         (process_psymtab_comp_unit_reader): Likewise.
5498         (partial_die_parent_scope): Likewise.
5499         (peek_die_abbrev): Likewise.
5500         (process_queue): Likewise.
5501         (dwarf2_physname): Likewise.
5502         (read_namespace_alias): Likewise.
5503         (read_import_statement): Likewise.
5504         (create_dwo_cu_reader): Likewise.
5505         (create_cus_hash_table): Likewise.
5506         (lookup_dwo_cutu): Likewise.
5507         (inherit_abstract_dies): Likewise.
5508         (read_func_scope): Likewise.
5509         (read_call_site_scope): Likewise.
5510         (dwarf2_add_member_fn): Likewise.
5511         (read_common_block): Likewise.
5512         (read_module_type): Likewise.
5513         (read_typedef): Likewise.
5514         (read_subrange_type): Likewise.
5515         (load_partial_dies): Likewise.
5516         (read_partial_die): Likewise.
5517         (find_partial_die): Likewise.
5518         (read_str_index): Likewise.
5519         (dwarf2_string_attr): Likewise.
5520         (build_error_marker_type): Likewise.
5521         (lookup_die_type): Likewise.
5522         (dump_die_shallow): Likewise.
5523         (follow_die_ref): Likewise.
5524         (dwarf2_fetch_die_loc_sect_off): Likewise.
5525         (dwarf2_fetch_constant_bytes): Likewise.
5526         (follow_die_sig): Likewise.
5527         (get_signatured_type): Likewise.
5528         (get_DW_AT_signature_type): Likewise.
5529         (dwarf2_find_containing_comp_unit): Likewise.
5530         (set_die_type): Likewise.
5531
5532 2018-02-21  John Baldwin  <jhb@FreeBSD.org>
5533
5534         * arch/aarch64.c: Include "common-defs.h".
5535         * arch/amd64.c: Likewise.
5536         * arch/i386.c: Likewise.
5537
5538 2018-02-21  Tom Tromey  <tom@tromey.com>
5539
5540         * value.h: (extract_field_op): Update.
5541         * eval.c (extract_field_op): Return a const char *.
5542         * expression.h (parse_expression_for_completion): Update.
5543         * completer.c (complete_expression): Update.
5544         (add_struct_fields): Make fieldname const.
5545         * parse.c (expout_completion_name): Now a unique_xmalloc_ptr.
5546         (mark_completion_tag, parse_exp_in_context_1): Update.
5547         (parse_expression_for_completion): Change "name" to
5548         unique_xmalloc_ptr*.
5549
5550 2018-02-21  Tom Tromey  <tom@tromey.com>
5551
5552         * infcall.c (call_function_by_hand_dummy): Use std::vector.
5553
5554 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5555
5556         * avr-tdep.c (avr_read_pc): Change parameter type to
5557         readable_regcache.
5558         * gdbarch.sh (read_pc): Likewise.
5559         * gdbarch.c: Re-generated.
5560         * gdbarch.h: Re-generated.
5561         * hppa-tdep.c (hppa_read_pc): Change parameter type to
5562         readable_regcache.
5563         * ia64-tdep.c (ia64_read_pc): Likewise.
5564         * mips-tdep.c (mips_read_pc): Likewise.
5565         * spu-tdep.c (spu_read_pc): Likewise.
5566
5567 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5568
5569         * Makefile.in (COMMON_SFILES): Add regcache-dump.c
5570         * regcache-dump.c: New file.
5571         * regcache.c: Move register_dump to regcache-dump.c.
5572         (maintenance_print_registers): Likewise.
5573         (maintenance_print_raw_registers): Likewise.
5574         (maintenance_print_cooked_registers): Likewise.
5575         (maintenance_print_register_groups): Likewise.
5576         (maintenance_print_remote_registers): Likewise.
5577         (_initialize_regcache): Likewise.
5578         * regcache.h (register_dump): Moved from regcache.c.
5579
5580 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5581
5582         * regcache.c (regcache::regcache): Update.
5583         (regcache::invalidate): Move it to detached_regcache::invalidate.
5584         (get_thread_arch_aspace_regcache): Update.
5585         (regcache::raw_update): Update.
5586         (regcache::cooked_read): Remove some code.
5587         (regcache::cooked_read_value): Likewise.
5588         (regcache::raw_write): Remove assert on m_readonly_p.
5589         (regcache::raw_supply_integer): Move it to
5590         detached_regcache::raw_supply_integer.
5591         (regcache::raw_supply_zeroed): Likewise.
5592         * regcache.h (detached_regcache) <raw_supply_integer>: New
5593         declaration.
5594         <raw_supply_zeroed, invalidate>: Likewise.
5595         (regcache) <raw_supply_integer, raw_supply_zeroed>: Removed.
5596         <invalidate>: Likewise.
5597         <m_readonly_p>: Removed.
5598
5599 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5600
5601         * infcmd.c (get_return_value): Let stop_regs point to
5602         get_current_regcache.
5603         * regcache.c (regcache::regcache): Remove.
5604         (register_dump_reg_buffer): New class.
5605         (regcache_print): Adjust.
5606         * regcache.h (regcache): Remove constructors.
5607
5608 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5609
5610         * regcache.c (class register_dump): New class.
5611         (register_dump_regcache, register_dump_none): New class.
5612         (register_dump_remote, register_dump_groups): New class.
5613         (regcache_print): Update.
5614         * regcache.h (regcache_dump_what): Move it to regcache.c.
5615         (regcache) <dump>: Remove.
5616
5617 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5618
5619         * jit.c (struct jit_unwind_private) <regcache>: Change its type to
5620          reg_buffer_rw *.
5621         (jit_unwind_reg_set_impl): Call raw_supply.
5622         (jit_frame_sniffer): Use reg_buffer_rw.
5623         * record-full.c (record_full_core_regbuf): Change its type.
5624         (record_full_core_open_1): Use reg_buffer_rw.
5625         (record_full_close): Likewise.
5626         (record_full_core_fetch_registers): Use regcache->raw_supply.
5627         (record_full_core_store_registers): Likewise.
5628         * regcache.c (regcache::get_register_status): Move it to
5629         reg_buffer.
5630         (regcache_raw_set_cached_value): Remove.
5631         (regcache::raw_set_cached_value): Remove.
5632         (regcache::raw_write): Call raw_supply.
5633         (regcache::raw_supply): Move it to reg_buffer_rw.
5634         * regcache.h (regcache_raw_set_cached_value): Remove.
5635         (reg_buffer_rw): New class.
5636
5637 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5638
5639         * dummy-frame.c (dummy_frame_cache) <prev_regcache>: Use
5640         readonly_detached_regcache.
5641         (dummy_frame_prev_register): Use regcache->cooked_read.
5642         * frame.c (frame_save_as_regcache): Change return type.
5643         (frame_pop): Update.
5644         * frame.h (frame_save_as_regcache): Update declaration.
5645         * inferior.h (get_infcall_suspend_state_regcache): Update
5646         declaration.
5647         * infrun.c (infcall_suspend_state) <registers>: use
5648         readonly_detached_regcache.
5649         (save_infcall_suspend_state): Don't use regcache_dup.
5650         (get_infcall_suspend_state_regcache): Change return type.
5651         * linux-fork.c (struct fork_info) <savedregs>: Change to
5652         readonly_detached_regcache.
5653         <pc>: New field.
5654         (fork_save_infrun_state): Don't use regcache_dup.
5655         (info_checkpoints_command): Adjust.
5656         * mi/mi-main.c (register_changed_p): Update declaration.
5657         (mi_cmd_data_list_changed_registers): Use
5658         readonly_detached_regcache.
5659         (register_changed_p): Change parameter type to
5660         readonly_detached_regcache.
5661         * ppc-linux-tdep.c (ppu2spu_cache) <regcache>: Use
5662         readonly_detached_regcache.
5663         (ppu2spu_sniffer): Construct a new readonly_detached_regcache.
5664         * regcache.c (readonly_detached_regcache::readonly_detached_regcache):
5665         New.
5666         (regcache::save): Move it to reg_buffer.
5667         (regcache::restore): Change parameter type.
5668         (regcache_dup): Remove.
5669         * regcache.h (reg_buffer) <save>: New method.
5670         (readonly_detached_regcache): New class.
5671         * spu-tdep.c (spu2ppu_cache) <regcache>: Use
5672         readonly_detached_regcache.
5673         (spu2ppu_sniffer): Construct a new readonly_detached_regcache.
5674
5675 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5676
5677         * frame.c (frame_save_as_regcache): Use regcache method save.
5678         (frame_pop): Use regcache method restore.
5679         * infrun.c (restore_infcall_suspend_state): Likewise.
5680         * linux-fork.c (fork_load_infrun_state): Likewise.
5681         * ppc-linux-tdep.c (ppu2spu_sniffer): User regcache method
5682         save.
5683         * regcache.c (regcache_save): Remove.
5684         (regcache::restore): More asserts.
5685         (regcache_cpy): Remove.
5686         * regcache.h (regcache_save): Remove the declaration.
5687         (regcache::restore): Move from private to public.
5688         Remove the friend declaration of regcache_cpy.
5689         (regcache_cpy): Remove declaration.
5690
5691 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5692
5693         * aarch64-tdep.c (aarch64_pseudo_register_read_value): Change
5694         parameter type to 'readable_regcache *'.
5695         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
5696         * arm-tdep.c (arm_neon_quad_read): Likewise.
5697         (arm_pseudo_read): Likewise.
5698         * avr-tdep.c (avr_pseudo_register_read): Likewise.
5699         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
5700         * frv-tdep.c (frv_pseudo_register_read): Likewise.
5701         * gdbarch.c: Re-generated.
5702         * gdbarch.h: Re-generated.
5703         * gdbarch.sh (pseudo_register_read): Change parameter type to
5704         'readable_regcache *'.
5705         (pseudo_register_read_value): Likewise.
5706         * h8300-tdep.c (pseudo_from_raw_register): Likewise.
5707         (h8300_pseudo_register_read): Likewise.
5708         * hppa-tdep.c (hppa_pseudo_register_read): Likewise.
5709         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
5710         (i386_pseudo_register_read_into_value): Likewise.
5711         (i386_pseudo_register_read_value): Likewise.
5712         * i386-tdep.h (i386_pseudo_register_read_into_value): Update
5713         declaration.
5714         * ia64-tdep.c (ia64_pseudo_register_read): Likewise.
5715         * m32c-tdep.c (m32c_raw_read): Likewise.
5716         (m32c_read_flg): Likewise.
5717         (m32c_banked_register): Likewise.
5718         (m32c_banked_read): Likewise.
5719         (m32c_sb_read): Likewise.
5720         (m32c_part_read): Likewise.
5721         (m32c_cat_read): Likewise.
5722         (m32c_r3r2r1r0_read): Likewise.
5723         (m32c_pseudo_register_read): Likewise.
5724         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
5725         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
5726         (mep_pseudo_cr64_read): Likewise.
5727         (mep_pseudo_register_read): Likewise.
5728         * mips-tdep.c (mips_pseudo_register_read): Likewise.
5729         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
5730         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
5731         * regcache.c (regcache::raw_read): Move it to readable_regcache.
5732         (regcache::cooked_read): Likewise.
5733         (regcache::cooked_read_value): Likewise.
5734         (regcache_cooked_read_signed):
5735         (regcache::cooked_read): Likewise.
5736         * regcache.h (readable_regcache): New class.
5737         (regcache): Inherit readable_regcache.  Move some methods to
5738         readable_regcache.
5739         * rl78-tdep.c (rl78_pseudo_register_read): Change
5740         parameter type to 'readable_regcache *'.
5741         * rs6000-tdep.c (do_regcache_raw_read): Remove.
5742         (e500_pseudo_register_read): Change parameter type to
5743         'readable_regcache *'.
5744         (dfp_pseudo_register_read): Likewise.
5745         (vsx_pseudo_register_read): Likewise.
5746         (efpr_pseudo_register_read): Likewise.
5747         * s390-tdep.c (s390_pseudo_register_read): Likewise.
5748         * sh-tdep.c (sh_pseudo_register_read): Likewise.
5749         * sh64-tdep.c (pseudo_register_read_portions): Likewise.
5750         (sh64_pseudo_register_read): Likewise.
5751         * sparc-tdep.c (sparc32_pseudo_register_read): Likewise.
5752         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
5753         * spu-tdep.c (spu_pseudo_register_read_spu): Likewise.
5754         (spu_pseudo_register_read): Likewise.
5755         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
5756         (xtensa_pseudo_register_read): Likewise.
5757
5758 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5759
5760         * regcache.c (regcache::regcache): Call reg_buffer ctor.
5761         (regcache::arch): Move it to reg_buffer::arch.
5762         (regcache::register_buffer): Likewise.
5763         (regcache::assert_regnum): Likewise.
5764         (regcache::num_raw_registers): Likewise.
5765         * regcache.h (reg_buffer): New class.
5766         (regcache): Inherit reg_buffer.
5767
5768 2018-02-20  Simon Marchi  <simon.marchi@ericsson.com>
5769
5770         * remote-sim.c (gdb_os_printf_filtered, gdb_os_vprintf_filtered,
5771         gdb_os_evprintf_filtered, gdb_os_error): Add ATTRIBUTE_PRINTF.
5772
5773 2018-02-20  Markus Metzger  <markus.t.metzger@intel.com>
5774
5775         * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add mkstemp.
5776
5777 2018-02-19  Alan Hayward  <alan.hayward@arm.com>
5778
5779         * Makefile.in: (COMMON_SFILES): Add common/*.c files.
5780         (SFILES): Remove common/*.c files.
5781         (COMMON_OBS): Remove some *.o files built from common/*.c files.
5782         * common/common.host: Add common reference.
5783         * configure.ac: Likewise.
5784         * configure: Regenerate.
5785
5786 2018-02-16  Yao Qi  <yao.qi@linaro.org>
5787
5788         * block.c (block_namespace_info): Inherit allocate_on_obstack.
5789         (block_initialize_namespace): Use new.
5790         * dwarf2read.c (dwarf2_per_objfile): Inherit allocate_on_obstack.
5791         (dwarf2_free_objfile): Use delete.
5792         * gdbtypes.c (type_pair): Inherit allocate_on_obstack.
5793         (copy_type_recursive): Use new.
5794         * gdb_obstack.h (allocate_on_obstack): New.
5795
5796 2018-02-15  Yao Qi  <yao.qi@linaro.org>
5797
5798         PR gdb/22849
5799         * inferior.c (exit_inferior_1): Reset inf->control.
5800
5801 2018-02-15  Joel Brobecker  <brobecker@adacore.com>
5802
5803         * ada-lang.c (ada_to_fixed_value_create): Delete advance
5804         declaration.
5805
5806 2018-02-14  Pedro Alves  <palves@redhat.com>
5807
5808         * frame-unwind.c (frame_unwind_try_unwinder): Always call
5809         frame_cleanup_after_sniffer on exception.
5810
5811 2018-02-14  Tom Tromey  <tom@tromey.com>
5812
5813         * solist.h (struct target_so_ops) <bfd_open>: Make pathname
5814         const.
5815         (solib_bfd_open): Make pathname const.
5816         * solib.c (solib_bfd_open): Make pathname const.
5817         * solib-spu.c (spu_bfd_fopen): Make name const.
5818         (spu_bfd_open): Make pathname const.
5819         * solib-darwin.c (darwin_bfd_open): Make pathname const.
5820         * solib-aix.c (solib_aix_bfd_open): Make pathname const.
5821
5822 2018-02-14  Tom Tromey  <tom@tromey.com>
5823
5824         * symfile.c (symfile_bfd_open): Update.
5825         * source.h (openp, source_full_path_of, find_and_open_source):
5826         Change argument type to unique_xmalloc_ptr.
5827         * source.c (openp): Take a unique_xmalloc_ptr.
5828         (source_full_path_of, find_and_open_source): Likewise.
5829         (open_source_file, symtab_to_fullname): Update.
5830         * solist.h (struct target_so_ops) <find_and_open_solib>: Take a
5831         unique_xmalloc_ptr.
5832         * solib.c (solib_find_1): Use unique_xmalloc_ptr.
5833         (exec_file_find): Update.
5834         * psymtab.c (psymtab_to_fullname): Update.
5835         * nto-tdep.h (nto_find_and_open_solib): Update.
5836         * nto-tdep.c (nto_find_and_open_solib): Change temp_path to a
5837         unique_xmalloc_ptr.
5838         * exec.c (exec_file_attach): Update.
5839         * dwarf2read.c (try_open_dwop_file): Use unique_xmalloc_ptr.
5840         * cli/cli-cmds.c (find_and_open_script): Use unique_xmalloc_ptr.
5841
5842 2018-02-14  Tom Tromey  <tom@tromey.com>
5843
5844         * solib.c: Include source.h.
5845         * nto-tdep.c: Include source.h.
5846         * mi/mi-cmd-env.c: Include source.h.
5847         * infcmd.c: Include source.h.
5848         * exec.c: Include source.h.
5849         * defs.h (enum openp_flag, openp, source_full_path_of, mod_path)
5850         (add_path, directory_switch, source_path, init_source_path): Move
5851         declarations...
5852         * source.h (enum openp_flag, openp, source_full_path_of, mod_path)
5853         (add_path, directory_switch, source_path, init_source_path):
5854         ...here.
5855
5856 2018-02-14  Tom Tromey  <tom@tromey.com>
5857
5858         * solist.h (exec_file_find, solib_find): Return
5859         unique_xmalloc_ptr.
5860         (solib_bfd_fopen): Take a const char *.
5861         * solib.c (solib_find_1): Return unique_xmalloc_ptr.
5862         (exec_file_find, solib_find): Likewise.
5863         (solib_bfd_fopen): Do not take ownership of "pathname".
5864         (solib_bfd_open): Use unique_xmalloc_ptr.
5865         * solib-darwin.c (darwin_bfd_open): Use unique_xmalloc_ptr.
5866         * solib-aix.c (solib_aix_bfd_open): Use unique_xmalloc_ptr.
5867         * infrun.c (follow_exec): Use unique_xmalloc_ptr.
5868         * exec.c (exec_file_locate_attach): Use unique_xmalloc_ptr.
5869
5870 2018-02-14  Joel Brobecker  <brobecker@adacore.com>
5871
5872         * ada-lang.c (name_match_type_from_name): Remove reference to
5873         ada_name_for_lookup in function's documentation.
5874         * ada-lang.h (ada_name_for_lookup): Delete declaration.
5875
5876 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
5877
5878         * defs.h (enum openp_flags): New enum.
5879         (OPF_TRY_CWD_FIRST, OPF_SEARCH_IN_PATH, OPF_RETURN_REALPATH):
5880         Move to enum openp_flags.
5881         (openp_flags): New enum flags.
5882         (openp): Change parameter type to openp_flags.
5883         * source.c (openp): Change parameter type to openp_flags.
5884         * cli/cli-cmds.c (find_and_open_script): Use openp_flags.
5885         * dwarf2read.c (try_open_dwop_file): Use openp_flags.
5886
5887 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
5888
5889         * maint.c (_initialize_maint_cmds): Fix prefix of maint set/show
5890         per-command.
5891
5892 2018-02-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5893
5894         * dwarf2read.c (dwarf2_release_queue): Delete function, move body
5895         into...
5896         (class dwarf2_queue_guard): ...the destructor of this new class.
5897         (dw2_do_instantiate_symtab): Create instance of the new class
5898         dwarf2_queue_guard, remove cleanup.
5899
5900 2018-02-09  Tom Tromey  <tom@tromey.com>
5901
5902         * source.c (find_source_lines): Don't reference past the end of
5903         the vector.
5904
5905 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5906
5907         * remote.c (remote_btrace_maybe_reopen): Change error message.
5908         * btrace.c (btrace_enable): Likewise.
5909         (parse_xml_btrace): Likewise.
5910         (parse_xml_btrace_conf): Likewise.
5911
5912 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5913
5914         * nat/linux-btrace.c (diagnose_perf_event_open_fail): New.
5915         (linux_enable_pt, linux_enable_bts): Call
5916         diagnose_perf_event_open_fail.
5917
5918 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5919
5920         * nat/linux-btrace.c (perf_event_pt_event_type): Improve error message.
5921         Remove parameter and change return type.  Update callers.  Move it.
5922         (linux_enable_bts, linux_enable_pt): Improve error message.
5923         (linux_enable_pt): Remove zero buffer size check.
5924         (linux_enable_btrace): Improve error messages.  Remove NULL return
5925         check.
5926
5927 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5928
5929         * btrace.c (btrace_enable): Remove target_supports_btrace call.
5930         * nat/linux-btrace.c (perf_event_pt_event_type): Move.
5931         (kernel_supports_bts, kernel_supports_pt, linux_supports_bts)
5932         (linux_supports_pt, linux_supports_btrace): Remove.
5933         (linux_enable_bts): Call cpu_supports_bts.
5934         * nat/linux-btrace.h (linux_supports_btrace): Remove.
5935         * remote.c (remote_supports_btrace): Remove.
5936         (init_remote_ops): Remove remote_supports_btrace.
5937         * target-delegates.c: Regenerated.
5938         * target.c (target_supports_btrace): Remove.
5939         * target.h (target_ops) <to_supports_btrace>: Remove
5940         (target_supports_btrace): Remove.
5941         * x86-linux-nat.c (x86_linux_create_target): Remove
5942         linux_supports_btrace.
5943
5944 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5945
5946         * nat/linux-btrace.c (linux_enable_btrace): Throw exception if enabling
5947         btrace failed.
5948         * x86-linux-nat.c (x86_linux_enable_btrace): Catch btrace enabling
5949         exception and use message in own exception.
5950
5951 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5952
5953         * nat/linux-btrace.c: Include scoped_fd.h and scoped_mmap.h.
5954         (perf_event_pt_event_type): Use gdb_file_up.
5955         (linux_enable_bts, linux_enable_pt): Use gdb::unique_xmalloc_ptr,
5956         scoped_fd, and scoped_mmap.
5957
5958 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5959
5960         * common/scoped_mmap.h: New.
5961         * unittests/scoped_mmap-selftest.c: New.
5962         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5963         unittests/scoped_mmap-selftest.c.
5964
5965 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
5966
5967         * common/scoped_fd.h: New.
5968         * unittests/scoped_fd-selftest.c: New.
5969         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5970         unittests/scoped_fd-selftest.c.
5971
5972 2018-02-09  Tom Tromey  <tom@tromey.com>
5973
5974         * auto-load.c (auto_load_section_scripts): Use
5975         gdb::unique_xmalloc_ptr.
5976
5977 2018-02-09  Tom Tromey  <tom@tromey.com>
5978
5979         * auto-load.c (execute_script_contents): Use std::string.
5980
5981 2018-02-09  Joel Brobecker  <brobecker@adacore.com>
5982
5983         * NEWS <Changes in GDB 8.1>: Clarify that "rbreak" is a new
5984         Python function, rather than a new command.
5985
5986 2018-02-08  Tom Tromey  <tom@tromey.com>
5987
5988         * solib.c (solib_find_1): Use std::string.
5989         (solib_bfd_fopen): Use unique_xmalloc_ptr.
5990
5991 2018-02-08  Tom Tromey  <tom@tromey.com>
5992
5993         * build-id.c (build_id_to_debug_bfd): Use unique_xmalloc_ptr.
5994
5995 2018-02-08  Tom Tromey  <tom@tromey.com>
5996
5997         * source.c (find_source_lines): Use gdb::def_vector.
5998
5999 2018-02-08  Tom Tromey  <tom@tromey.com>
6000
6001         * macrocmd.c (struct temporary_macro_definition): New.
6002         (macro_define_command): Use temporary_macro_definition.  Remove
6003         cleanups.
6004         (free_macro_definition_ptr): Remove.
6005
6006 2018-02-08  Tom Tromey  <tom@tromey.com>
6007
6008         * macroexp.c (maybe_expand): Use std::string.
6009
6010 2018-02-08  Tom Tromey  <tom@tromey.com>
6011
6012         * macroexp.c (struct macro_buffer): Add initializers for some
6013         members.
6014         (init_buffer, init_shared_buffer, free_buffer)
6015         (free_buffer_return_text): Remove.
6016         (macro_buffer): New constructors.
6017         (~macro_buffer): New destructor.
6018         (macro_buffer::set_shared): New method.
6019         (macro_buffer::resize_buffer, macro_buffer::appendc)
6020         (macro_buffer::appendmem): Now methods, not free functions.
6021         (set_token, append_tokens_without_splicing, stringify)
6022         (macro_stringify): Update.
6023         (gather_arguments): Change return type.  Remove argc_p argument,
6024         add args_ptr argument.  Use std::vector.
6025         (substitute_args): Remove argc argument.  Accept std::vector.
6026         (expand): Update.  Use std::vector.
6027         (scan, macro_expand, macro_expand_next): Update.
6028
6029 2018-02-08  Tom Tromey  <tom@tromey.com>
6030
6031         * symtab.c (default_collect_symbol_completion_matches_break_on):
6032         Use unique_xmalloc_ptr.
6033         * macroscope.h: (sal_macro_scope, user_macro_scope)
6034         (default_macro_scope): Return unique_xmalloc_ptr.
6035         * macroscope.c (sal_macro_scope, user_macro_scope)
6036         (default_macro_scope): Return unique_xmalloc_ptr.
6037         * macroexp.h (macro_expand, macro_expand_once): Return
6038         unique_xmalloc_ptr.
6039         * macroexp.c (macro_expand, macro_expand_once): Return
6040         unique_xmalloc_ptr.
6041         * macrocmd.c (macro_expand_command, macro_expand_once_command)
6042         (info_macro_command, info_macros_command): Use
6043         unique_xmalloc_ptr.
6044         * compile/compile-c-support.c (write_macro_definitions): Use
6045         unique_xmalloc_ptr.
6046         * c-exp.y (c_parse): Use unique_xmalloc_ptr.
6047
6048 2018-02-07  Simon Marchi  <simon.marchi@ericsson.com>
6049
6050         * value.c (value_static_field): Assign field type instead of
6051         containing type when returning an optimized out value.
6052
6053 2018-02-06  Yao Qi  <yao.qi@linaro.org>
6054
6055         * ft32-tdep.c (ft32_read_pc): Remove.
6056         (ft32_write_pc): Remove.
6057         (ft32_gdbarch_init): Update.
6058         * m32r-tdep.c (m32r_read_pc): Remove.
6059         (m32r_gdbarch_init): Update.
6060         * mep-tdep.c (mep_read_pc): Remove.
6061         (mep_gdbarch_init): Update.
6062         * microblaze-tdep.c (microblaze_write_pc): Remove.
6063         (microblaze_gdbarch_init): Update.
6064         * mn10300-tdep.c (mn10300_read_pc): Remove.
6065         (mn10300_write_pc): Remove.
6066         (mn10300_gdbarch_init): Update.
6067         * moxie-tdep.c (moxie_read_pc): Remove.
6068         (moxie_write_pc): Remove.
6069         (moxie_gdbarch_init): Update.
6070
6071 2018-02-06  Yao Qi  <yao.qi@linaro.org>
6072
6073         * expprint.c (print_subexp_standard): Handle
6074         OP_F77_UNDETERMINED_ARGLIST.
6075         (dump_subexp_body_standard): Likewise.
6076
6077 2018-02-05  Alan Hayward  <alan.hayward@arm.com>
6078
6079         * target-descriptions.c (tdesc_element_visitor) Add empty
6080         implementations.
6081         (tdesc_type): Move make_gdb_type from here.
6082         (tdesc_type_builtin): Likewise.
6083         (tdesc_type_vector): Likewise.
6084         (tdesc_type_with_fields): Move make_gdb_type_ functions from here.
6085         (make_gdb_type_struct): Move from tdesc_type_with_fields.
6086         (make_gdb_type_union): Likewise.
6087         (make_gdb_type_flags): Likewise.
6088         (make_gdb_type_enum): Likewise.
6089         (make_gdb_type): New function.
6090         (tdesc_register_type): Use static make_gdb_type.
6091
6092 2018-02-05  Ruslan Kabatsayev <b7.10110111@gmail.com>
6093
6094         * infcmd.c (default_print_one_register_info): Align natural-format
6095         column values consistently one under another.
6096         (pad_to_column): New function.
6097
6098 2018-02-05  Joel Brobecker  <brobecker@adacore.com>
6099
6100         * dwarf2read.c (dwarf2_physname): Move commment.
6101
6102 2018-02-01  Leszek Swirski  <leszeks@google.com>
6103
6104         * varobj.c (varobj_formatted_print_options): Allow recursive
6105         pretty printing if pretty printing is enabled.
6106
6107 2018-02-01  Leszek Swirski  <leszeks@google.com>
6108
6109         * c-exp.y (lex_one_token, classify_name, yylex): Don't classify
6110         names after a structop as a filename.
6111
6112 2018-02-01  Yao Qi  <yao.qi@linaro.org>
6113
6114         * arm-tdep.c (arm_record_data_proc_misc_ld_str): Rewrite it.
6115         (arm_record_coproc_data_proc): Likewise.
6116
6117 2018-02-01  Yao Qi  <yao.qi@linaro.org>
6118
6119         * arm-tdep.c (arm_record_extension_space): Change ret to signed.
6120
6121 2018-01-31  Nikola Prica  <nikola.prica@rt-rk.com>
6122
6123         * rs6000-tdep.c (skip_prologue): Remove shifting for lr_reg and
6124         assign shifted lr_reg to fdata->lr_register when lr_reg is set.
6125
6126 2018-01-31  Pedro Alves  <palves@redhat.com>
6127
6128         * darwin-nat.c (darwin_interrupt): Remove ptid_t parameter.
6129         * inflow.c (child_terminal_save_inferior): Wrap reference to
6130         tcgetpgrp in HAVE_TERMIOS_H.
6131         (child_interrupt, child_pass_ctrlc): Wrap references to signal in
6132         _WIN32.
6133         * remote-sim.c (gdbsim_interrupt): Remove ptid_t parameter and
6134         always iterate over all inferiors.
6135         (gdbsim_cntrl_c): Adjust.
6136         * windows-nat.c (windows_interrupt): Remove 'ptid_t' parameter.
6137
6138 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
6139
6140         * gdbtypes.c (lookup_array_range_type): Make sure the array's
6141         index type is objfile-owned if the element type is as well.
6142
6143 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
6144
6145         GDB 8.1 released.
6146
6147 2018-01-30  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6148
6149         * s390-linux-tdep.c: Remove includes "features/s390-linux32.c" and
6150         "features/s390x-linux64.c".
6151         (_initialize_s390_linux_tdep): Remove initialization of tdescs
6152         s390_linux32 and s390x_linux64.
6153         (s390_linux_init_abi_31, s390_linux_init_abi_64): Don't set
6154         default tdesc.
6155         * s390-tdep.c: Include "features/s390-linux32.c" and
6156         "features/s390x-linux64.c".
6157         (s390_tdesc_valid): Add check for tdesc_has_registers.
6158         (s390_gdbarch_init): Make sure there is always a valid tdesc.
6159         (_initialize_s390_tdep): Initialize tdesc_s390_linux32 and
6160         tdesc_s390x_linux64.
6161         * s390-linux-tdep.h: Move export of tdesc_s390_linux32 and
6162         tdesc_s390x_linux64 to...
6163         * s390-tdep.h: ...here.
6164
6165 2018-01-30  Pedro Alves  <palves@redhat.com>
6166
6167         PR gdb/13211
6168         * config.in, configure: Regenerate.
6169         * configure.ac: Check for getpgid.
6170         * go32-nat.c (go32_pass_ctrlc): New.
6171         (go32_target): Install it.
6172         * inf-child.c (inf_child_target): Install
6173         child_terminal_save_inferior, child_pass_ctrlc and
6174         child_interrupt.
6175         * inf-ptrace.c (inf_ptrace_interrupt): Delete.
6176         (inf_ptrace_target): No longer install it.
6177         * infcmd.c (interrupt_target_1): Adjust.
6178         * inferior.h (child_terminal_save_inferior, child_pass_ctrlc)
6179         (child_interrupt): Declare.
6180         (inferior::terminal_state): New.
6181         * inflow.c (struct terminal_info): Update comments.
6182         (inferior_process_group): Delete.
6183         (terminal_is_ours): Delete.
6184         (gdb_tty_state): New.
6185         (child_terminal_init): Adjust.
6186         (is_gdb_terminal, sharing_input_terminal_1)
6187         (sharing_input_terminal): New functions.
6188         (child_terminal_inferior): Adjust.  Use sharing_input_terminal.
6189         Set the process's actual process group in the foreground if
6190         possible.  Handle is_ours_for_output/is_ours distinction.  Don't
6191         mark terminal as the inferior's if not sharing GDB's terminal.
6192         Don't check attach_flag.
6193         (child_terminal_ours_for_output, child_terminal_ours): Adjust to
6194         pass down a target_terminal_state.
6195         (child_terminal_save_inferior): New, factored out from ...
6196         (child_terminal_ours_1): ... this.  Handle
6197         target_terminal_state::is_ours_for_output.
6198         (child_interrupt, child_pass_ctrlc): New.
6199         (inflow_inferior_exit): Clear the inferior's terminal_state.
6200         (copy_terminal_info): Copy the inferior's terminal state.
6201         (_initialize_inflow): Remove reference to terminal_is_ours.
6202         * inflow.h (inferior_process_group): Delete.
6203         * nto-procfs.c (nto_handle_sigint, procfs_interrupt): Adjust.
6204         * procfs.c (procfs_target): Don't install procfs_interrupt.
6205         (procfs_interrupt): Delete.
6206         * remote.c (remote_serial_quit_handler): Adjust.
6207         (remote_interrupt): Remove ptid parameter.  Adjust.
6208         * target-delegates.c: Regenerate.
6209         * target.c: Include "terminal.h".
6210         (target_terminal::terminal_state): Rename to ...
6211         (target_terminal::m_terminal_state): ... this.
6212         (target_terminal::init): Adjust.
6213         (target_terminal::inferior): Adjust to per-inferior
6214         terminal_state.
6215         (target_terminal::restore_inferior, target_terminal_is_ours_kind): New.
6216         (target_terminal::ours, target_terminal::ours_for_output): Use
6217         target_terminal_is_ours_kind.
6218         (target_interrupt): Remove ptid parameter.  Adjust.
6219         (default_target_pass_ctrlc): Adjust.
6220         * target.h (target_ops::to_terminal_save_inferior): New field.
6221         (target_ops::to_interrupt): Remove ptid_t parameter.
6222         (target_interrupt): Remove ptid_t parameter.  Update comment.
6223         (target_pass_ctrlc): Update comment.
6224         * target/target.h (target_terminal_state): New scoped enum,
6225         factored out of ...
6226         (target_terminal::terminal_state): ... here.
6227         (target_terminal::inferior): Update comments.
6228         (target_terminal::restore_inferior): New.
6229         (target_terminal::is_inferior, target_terminal::is_ours)
6230         (target_terminal::is_ours_for_output): Adjust.
6231         (target_terminal::scoped_restore_terminal_state): Adjust to
6232         rename, and call restore_inferior() instead of inferior().
6233         (target_terminal::scoped_restore_terminal_state::m_state): Change
6234         type.
6235         (target_terminal::terminal_state): Rename to ...
6236         (target_terminal::m_terminal_state): ... this and change type.
6237
6238 2018-01-30  Pedro Alves  <palves@redhat.com>
6239
6240         * linux-nat.c (wait_for_signal): New function.
6241         (wait_lwp, linux_nat_wait_1): Use it instead of calling sigsuspend
6242         directly.
6243         (async_terminal_is_ours)
6244         (linux_nat_terminal_inferior, linux_nat_terminal_ours): Delete.
6245         (linux_nat_add_target): Don't override
6246         to_terminal_inferior/to_terminal_ours.
6247
6248 2018-01-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6249
6250         * remote.c (remote_follow_fork): Don't call "detach_inferior".
6251
6252 2018-01-28  Simon Marchi  <simon.marchi@ericsson.com>
6253
6254         * dwarf2read.c (free_dwo_files): Add forward-declaration.
6255         (dwarf2_per_objfile::~dwarf2_per_objfile): Move content from
6256         dwarf2_per_objfile_free here.
6257         (dwarf2_per_objfile_free): Remove.
6258         (_initialize_dwarf2_read): Don't register
6259         dwarf2_per_objfile_free as a registry cleanup.
6260
6261 2018-01-27  Eli Zaretskii  <eliz@gnu.org>
6262
6263         Avoid compilation errors in MinGW native builds
6264
6265         The error is triggered by including python-internal.h, and the
6266         error message is:
6267
6268              In file included from d:\usr\lib\gcc\mingw32\6.3.0\include\c++\math.h:36:0,
6269                       from build-gnulib/import/math.h:27,
6270                       from d:/usr/Python26/include/pyport.h:235,
6271                       from d:/usr/Python26/include/Python.h:58,
6272                       from python/python-internal.h:94,
6273                       from python/py-arch.c:24:
6274              d:\usr\lib\gcc\mingw32\6.3.0\include\c++\cmath:1157:11: error: '::hypot' has not been declared
6275         using ::hypot;
6276                 ^~~~~
6277
6278         This happens because Python headers define 'hypot' to expand t
6279         '_hypot' in the Windows builds.
6280         * python/python-internal.h (_hypot) [__MINGW32__]: Define back to
6281         'hypoth'.  This avoids a compilation error.
6282
6283 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
6284
6285         * MAINTAINERS (Write After Approval): Fix ordering.
6286
6287 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
6288
6289         * MAINTAINERS (Write After Approval): Add Alan Hayward.
6290
6291 2018-01-26  Alan Modra  <amodra@gmail.com>
6292
6293         * ppc-linux-tdep.c (powerpc32_plt_stub): Make const.
6294         (powerpc32_plt_stub_so_1): Rename from powerpc32_plt_stub_so.
6295         Remove nop.  Make const.  Comment.
6296         (powerpc32_plt_stub_so_2): New.
6297         (POWERPC32_PLT_CHECK_LEN): Rename from POWERPC32_PLT_STUB_LEN.
6298         Correct count.  Update uses.
6299         (ppc_skip_trampoline_code): Match powerpc32_plt_stub_so_2 too.
6300         Move common code reading PLT entry word.  Correct
6301         powerpc32_plt_stub PLT address calculation.
6302         * ppc64-tdep.c (ppc64_standard_linkage1): Make const.
6303         (ppc64_standard_linkage2, ppc64_standard_linkage3): Likewise.
6304         (ppc64_standard_linkage4, ppc64_standard_linkage5): Likewise.
6305         (ppc64_standard_linkage6, ppc64_standard_linkage7): Likewise.
6306         (ppc64_standard_linkage8): Likewise.
6307         * rs6000-tdep.c (ppc_insns_match_pattern): Make pattern const.
6308         Correct insns description.
6309         * ppc-tdep.h (ppc_insns_match_pattern): Update prototype.
6310
6311 2018-01-24  Pedro Alves  <palves@redhat.com>
6312
6313         GCC PR libstdc++/83906
6314         * gdbtypes.c (operator==(const dynamic_prop &,
6315         const dynamic_prop &)): New.
6316         (operator==(const range_bounds &, const range_bounds &)): New.
6317         (check_types_equal): Use them instead of memcmp.
6318         * gdbtypes.h (operator==(const dynamic_prop &,
6319         const dynamic_prop &)): Declare.
6320         (operator!=(const dynamic_prop &, const dynamic_prop &)): Declare.
6321         (operator==(const range_bounds &, const range_bounds &)): Declare.
6322         (operator!=(const range_bounds &, const range_bounds &)): Declare.
6323
6324 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6325
6326         * s390-linux-tdep.c (s390_record_address_mask)
6327         (s390_record_calc_disp_common, s390_record_calc_disp)
6328         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
6329         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
6330         (s390_process_record): Move to s390-tdep.c.
6331         (s390_linux_init_abi_any): Adjust.
6332         * s390-tdep.c (s390_record_address_mask)
6333         (s390_record_calc_disp_common, s390_record_calc_disp)
6334         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
6335         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
6336         (s390_process_record): Moved from s390-linux-tdep.c
6337         (s390_gdbarch_init): Adjust.
6338
6339 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6340
6341         * s390-linux-nat.c (s390-tdep.h): New include.
6342         * Makefile.in (ALL_TARGET_OBS): Add s390-tdep.o.
6343         (HFILES_NO_SRCDIR): Add s390-tdep.h.
6344         (ALLDEPFILES): Add s390-tdep.c.
6345         * configure.tgt (s390*-*-linux*): Add s390-tdep.o.
6346         * s390-linux-tdep.h (HWCAP_S390_*, S390_*_REGNUM): Move to...
6347         * s390-tdep.h: ...this.  New file.
6348         * s390-linux-tdep.c (s390-tdep.h): New include.
6349         (_initialize_s390_tdep): Rename to...
6350         (_initialize_s390_linux_tdep): ...this and adjust.
6351         (s390_abi_kind, s390_vector_abi_kind, gdbarch_tdep)
6352         (enum named opcodes, S390_NUM_GPRS, S390_NUM_FPRS): Move to
6353         s390-tdep.h.
6354         (s390_break_insn, s390_breakpoint, s390_readinstruction, is_ri)
6355         (is_ril, is_rr, is_rre, is_rs, is_rsy, is_rx, is_rxy)
6356         (s390_is_partial_instruction, s390_software_single_step)
6357         (is_non_branch_ril, s390_displaced_step_copy_insn)
6358         (s390_displaced_step_fixup, s390_displaced_step_hw_singlestep)
6359         (s390_prologue_data, s390_addr, s390_store, s390_load)
6360         (s390_check_for_saved, s390_analyze_prologue, s390_skip_prologue)
6361         (s390_register_call_saved, s390_guess_tracepoint_registers)
6362         (s390_register_name, s390_dwarf_regmap, s390_dwarf_reg_to_regnum)
6363         (regnum_is_gpr_full, regnum_is_vxr_full, s390_value_from_register)
6364         (s390_pseudo_register_name, s390_pseudo_register_type)
6365         (s390_pseudo_register_read, s390_pseudo_register_write)
6366         (s390_pseudo_register_reggroup_p, s390_ax_pseudo_register_collect)
6367         (s390_ax_pseudo_register_push_stack, s390_gen_return_address)
6368         (s390_addr_bits_remove, s390_address_class_type_flags)
6369         (s390_address_class_type_flags_to_name)
6370         (s390_address_class_name_to_type_flags, s390_effective_inner_type)
6371         (s390_function_arg_float, s390_function_arg_vector)
6372         (is_power_of_two, s390_function_arg_integer, s390_arg_state)
6373         (s390_handle_arg, s390_push_dummy_call, s390_dummy_id)
6374         (s390_frame_align, s390_register_return_value, s390_return_value)
6375         (s390_stack_frame_destroyed_p, s390_unwind_pc, s390_unwind_sp)
6376         (s390_unwind_pseudo_register, s390_adjust_frame_regnum)
6377         (s390_dwarf2_prev_register, s390_dwarf2_frame_init_reg)
6378         (s390_trad_frame_prev_register, s390_unwind_cache)
6379         (s390_prologue_frame_unwind_cache)
6380         (s390_backchain_frame_unwind_cache, s390_frame_unwind_cache)
6381         (s390_frame_this_id, s390_frame_prev_register, s390_frame_unwind)
6382         (s390_stub_unwind_cache, s390_stub_frame_unwind_cache)
6383         (s390_stub_frame_this_id, s390_stub_frame_prev_register)
6384         (s390_stub_frame_sniffer, s390_stub_frame_unwind)
6385         (s390_frame_base_address, s390_local_base_address)
6386         (s390_frame_base, s390_gcc_target_options)
6387         (s390_gnu_triplet_regexp, s390_stap_is_single_operand)
6388         (s390_validate_reg_range, s390_tdesc_valid)
6389         (s390_gdbarch_tdep_alloc, s390_gdbarch_init): Move to...
6390         * s390-tdep.c: ...this.  New file.
6391
6392 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6393
6394         * s390-linux-tdep.c (gdbarch_tdep.s390_syscall_record): New hook.
6395         (s390_process_record, s390_gdbarch_tdep_alloc)
6396         (s390_linux_init_abi_any): Use/set new hook.
6397
6398 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6399
6400         * s390-linux-tdep.c (osabi.h): New include.
6401         (s390_linux_init_abi_31, s390_linux_init_abi_64)
6402         (s390_linux_init_abi_any): New functions.
6403         (s390_gdbarch_init, _initialize_s390_tdep): Adjust.
6404
6405 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6406
6407         * s390-linux-tdep.c (s390_gdbarch_init): Use gdb_assert for
6408         tdesc_has_registers check
6409
6410 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6411
6412         * s390-linux-tdep.c (s390_tdesc_valid): New function.
6413         (s390_validate_reg_range): New macro.
6414         (s390_gdbarch_init): Adjust.
6415
6416 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6417
6418         * s390-linux-tdep.c (gdbarch_tdep) <tdesc>: New field.
6419         (s390_gdbarch_tdep_alloc): Adjust.
6420         (s390_gdbarch_init): Adjust.
6421
6422 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6423
6424         * s390-linux-tdep.c (gdbarch_tdep) <have_linux_v1, have_linux_v2>
6425         <have_tdb>: Change type to bool.
6426         (s390_gdbarch_tdep_alloc): Adjust.
6427         (s390_gdbarch_init): Adjust.
6428
6429 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6430
6431         * s390-linux-tdep (s390_abi_kind) <ABI_NONE>: New default field.
6432         (gdbarch_tdep) <have_upper, have_vx>: New fields.
6433         (s390_gdbarch_tdep_alloc): New function.
6434         (s390_gdbarch_init): Allocate tdep at start and use its fields
6435         instead of separate variables.
6436
6437 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6438
6439         * s390-linux-tdep.c (s390_gdbarch_init): Remove duplicate checks
6440         when looking for cached gdbarch and add comment for remaining.
6441
6442 2018-01-22  Pedro Alves  <palves@redhat.com>
6443             Sergio Durigan Junior  <sergiodj@redhat.com>
6444
6445         * typeprint.c (whatis_exp): Initialize "val" in the "whatis type"
6446         case.
6447
6448 2018-01-22  Maciej W. Rozycki  <macro@mips.com>
6449
6450         * MAINTAINERS: Update my company e-mail address.
6451
6452 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6453
6454         * regcache.c (cooked_write_test): New function.
6455         (_initialize_regcache): Register the test.
6456
6457 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6458
6459         * ia64-tdep.c (ia64_pseudo_register_read): Call
6460         regcache->cooked_read instead of regcache_cooked_read_unsigned.
6461         * m32c-tdep.c (m32c_cat_read): Likewise.
6462         (m32c_r3r2r1r0_read): Likewise.
6463         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
6464         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
6465
6466 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6467
6468         * aarch64-tdep.c (aarch64_pseudo_read_value): Call regcache
6469         method raw_read instead of regcache_raw_read.
6470         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
6471         * arm-tdep.c (arm_neon_quad_read): Likewise.
6472         * avr-tdep.c (avr_pseudo_register_read): Likewise.
6473         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
6474         * frv-tdep.c (frv_pseudo_register_read): Likewise.
6475         * h8300-tdep.c (h8300_pseudo_register_read): Likewise.
6476         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
6477         (i386_pseudo_register_read_into_value): Likewise.
6478         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
6479         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
6480         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
6481         * rl78-tdep.c (rl78_pseudo_register_read): Likewise.
6482         * s390-linux-tdep.c (s390_pseudo_register_read): Likewise.
6483         * sparc-tdep.c (sparc32_pseudo_register_read):  Likewise.
6484         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
6485         * spu-tdep.c (spu_pseudo_register_read_spu):  Likewise.
6486         * xtensa-tdep.c (xtensa_pseudo_register_read): Likewise.
6487
6488 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6489
6490         * Makefile.in (ALL_TARGET_OBS): Remove mt-tdep.o.
6491         * configure.tgt: Remove target mt.
6492         * mt-tdep.c: Remove.
6493         * regcache.c (cooked_read_test): Remove the check for mt.
6494
6495 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6496
6497         * jit.c (jit_frame_prev_register): Call regcache::cooked_read
6498         instead of gdbarch_pseudo_register_read_value.
6499
6500 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
6501
6502         * dwarf2read.c (need_gnat_info): Return nonzero if the cu's
6503         language is Ada.
6504
6505 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
6506
6507         * linespec.c (create_sals_line_offset): Remove code that preserved
6508         the symtab_and_line's line number.
6509
6510 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6511
6512         * varobj.c (varobj_create): Don't set valid_block when creating a
6513         floating varobj.
6514
6515 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6516
6517         * varobj.c (varobj_create): Remove out of date comment.
6518
6519 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6520
6521         PR mi/20395
6522         * ada-exp.y (write_var_from_sym): Pass extra parameter when
6523         updating innermost block.
6524         * parse.c (innermost_block_tracker::update): Take extra type
6525         parameter, and check types match before updating innermost block.
6526         (write_dollar_variable): Update innermost block for registers.
6527         * parser-defs.h (enum innermost_block_tracker_type): New enum.
6528         (innermost_block_tracker::innermost_block_tracker): Initialise
6529         m_types member.
6530         (innermost_block_tracker::reset): Take type parameter.
6531         (innermost_block_tracker::update): Take type parameter, and pass
6532         type through as needed.
6533         (innermost_block_tracker::m_types): New member.
6534         * varobj.c (varobj_create): Pass type when reseting innermost
6535         block.
6536
6537 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6538
6539         * ada-exp.y (write_var_from_sym): Switch to innermost_block API.
6540         * ada-lang.c (resolve_subexp): Likewise.
6541         * breakpoint.c (set_breakpoint_condition) Likewise.
6542         (watch_command_1) Likewise.
6543         * c-exp.y (variable): Likewise.
6544         * d-exp.y (PrimaryExpression): Likewise.
6545         * f-exp.y (variable): Likewise.
6546         * go-exp.y (variable): Likewise.
6547         * m2-exp.y (variable): Likewise.
6548         * objfiles.c (objfile::~objfile): Likewise.
6549         * p-exp.y (variable): Likewise.
6550         * parse.c (innermost_block): Change type.
6551         * parser-defs.h (class innermost_block_tracker): New.
6552         (innermost_block): Change to innermost_block_tracker.
6553         * printcmd.c (display_command): Switch to innermost_block API.
6554         (do_one_display): Likewise.
6555         * rust-exp.y (do_one_display): Likewise.
6556         * symfile.c (clear_symtab_users): Likewise.
6557         * varobj.c (varobj_create): Switch to innermost_block API, replace
6558         use of innermost_block with block stored on varobj object.
6559
6560 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6561
6562         * expression.h (innermost_block): Remove declaration.
6563         * varobj.c: Add 'parser-defs.h' include.
6564
6565 2018-01-19  Tom Tromey  <tom@tromey.com>
6566
6567         * rust-lang.c (rust_lookup_symbol_nonlocal): Look up qualified
6568         symbols in the static and global blocks.
6569
6570 2018-01-19  James Clarke  <jrtc27@jrtc27.com>
6571
6572         * nat/linux-ptrace.c: Remove unnecessary reinclusion of
6573         gdb_ptrace.h, and move including gdb_wait.h ...
6574         * nat/linux-ptrace.h: ... to here.
6575
6576 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
6577
6578         * inf-ptrace.c (inf_ptrace_detach): Adjust call to
6579         inf_ptrace_detach_success.
6580         (inf_ptrace_detach_success): Add inferior parameter, use it
6581         instead of inferior_ptid, pass it to detach_inferior.
6582         * inf-ptrace.h (inf_ptrace_detach_success): Add inferior
6583         parameter.
6584         * inferior.c (detach_inferior): Add overload that takes an
6585         inferior object.
6586         * inferior.h (detach_inferior): Likewise.
6587         * linux-nat.c (linux_nat_detach): Use the inf parameter, don't
6588         use inferior_ptid, adjust call to inf_ptrace_detach_success.
6589         * linux-thread-db.c (thread_db_detach): Use inf parameter.
6590
6591 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
6592
6593         * target.h (struct target_ops) <to_detach>: Add inferior
6594         parameter.
6595         (target_detach): Likewise.
6596         * target.c (dispose_inferior): Pass inferior down.
6597         (target_detach): Pass inferior down.  Assert that it is equal to
6598         the current inferior.
6599         * aix-thread.c (aix_thread_detach): Pass inferior down.
6600         * corefile.c (core_file_command): Pass current_inferior() down.
6601         * corelow.c (core_detach): Add inferior parameter.
6602         * darwin-nat.c (darwin_detach): Likewise.
6603         * gnu-nat.c (gnu_detach): Likewise.
6604         * inf-ptrace.c (inf_ptrace_detach): Likewise.
6605         * infcmd.c (detach_command): Pass current_inferior() down to
6606         target_detach.
6607         * infrun.c (follow_fork_inferior): Pass parent_inf to
6608         target_detach.
6609         (handle_vfork_child_exec_or_exit): Pass inf->vfork_parent to
6610         target_detach.
6611         * linux-nat.c (linux_nat_detach): Add inferior parameter.
6612         * linux-thread-db.c (thread_db_detach): Likewise.
6613         * nto-procfs.c (procfs_detach): Likewise.
6614         * procfs.c (procfs_detach): Likewise.
6615         * record.c (record_detach): Likewise.
6616         * record.h (struct inferior): Forward-declare.
6617         (record_detach): Add inferior parameter.
6618         * remote-sim.c (gdbsim_detach): Likewise.
6619         * remote.c (remote_detach_1): Likewise.
6620         (remote_detach): Likewise.
6621         (extended_remote_detach): Likewise.
6622         * sol-thread.c (sol_thread_detach): Likewise.
6623         * target-debug.h (target_debug_print_inferior_p): New macro.
6624         * target-delegates.c: Re-generate.
6625         * top.c (kill_or_detach): Pass inferior down to target_detach.
6626         * windows-nat.c (windows_detach): Add inferior parameter.
6627
6628 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
6629
6630         * target.h (struct target_ops) <to_detach>: Remove args
6631         parameter.
6632         (target_detach): Likewise.
6633         * target.c (dispose_inferior): Adjust.
6634         (target_detach): Remove args parameter, adjust.
6635         * aix-thread.c (aix_thread_detach): Adjust.
6636         * corefile.c (core_file_command): Adjust.
6637         * corelow.c (core_detach): Adjust.
6638         * darwin-nat.c (darwin_detach): Adjust.
6639         * gnu-nat.c (gnu_detach): Adjust.
6640         * inf-ptrace.c (inf_ptrace_detach): Adjust.
6641         * infcmd.c (detach_command): Adjust
6642         * infrun.c (follow_fork_inferior): Adjust.
6643         (handle_vfork_child_exec_or_exit): Adjust.
6644         * linux-fork.c (linux_fork_detach): Remove args parameter.
6645         * linux-fork.h (linux_fork_detach): Likewise.
6646         * linux-nat.c (linux_nat_detach): Likewise, and adjust.
6647         * linux-thread-db.c (thread_db_detach): Likewise.
6648         * nto-procfs.c (procfs_detach): Likewise.
6649         * procfs.c (procfs_detach): Likewise.
6650         (do_detach): Remove signo parameter.
6651         * record.c (record_detach): Remove args parameter.
6652         * record.h (record_detach): Likewise.
6653         * remote-sim.c (gdbsim_detach): Likewise.
6654         * remote.c (remote_detach_1): Likewise.
6655         (remote_detach): Likewise.
6656         (extended_remote_detach): Likewise.
6657         * sol-thread.c (sol_thread_detach): Likewise.
6658         * target-delegates.c: Re-generate.
6659         * top.c (struct qt_args) <args>: Remove field.
6660         (kill_or_detach): Don't pass args.
6661         (quit_force): Don't set args.
6662         * windows-nat.c (windows_detach): Remove args parameter.
6663
6664 2018-01-19  Yao Qi  <yao.qi@linaro.org>
6665
6666         * arm-linux-tdep.c (arm_linux_gcc_target_options): New function.
6667         (arm_linux_init_abi): Install it.
6668
6669 2018-01-19  Yao Qi  <yao.qi@linaro.org>
6670
6671         * osabi.c (gdb_osabi_names): Extend the regexp for
6672         arm-linux-gnueabihf.
6673
6674 2018-01-18  Yao Qi  <yao.qi@linaro.org>
6675
6676         * dwarf2read.c (abbrev_table) <abbrevs>: Rename it to
6677         m_abbrevs.
6678         (abbrev_table::add_abbrev): Update.
6679         (abbrev_table::lookup_abbrev): Update.
6680
6681 2018-01-18  Yao Qi  <yao.qi@linaro.org>
6682
6683         * ppc-linux-tdep.c (ppu2spu_prev_register): Call cooked_read.
6684
6685 2018-01-17  Sergio Durigan Junior  <sergiodj@redhat.com>
6686
6687         * compile/compile.c (compile_to_object): Convert "triplet_rx"
6688         to "std::string".
6689
6690 2018-01-17  Tom Tromey  <tom@tromey.com>
6691
6692         * dwarf2read.c (symbolp): Remove typedef.  Don't instantiate VEC.
6693
6694 2018-01-17  Tom Tromey  <tom@tromey.com>
6695
6696         * gdbtypes.h (add_dyn_prop): Remove objfile parameter.
6697         * gdbtypes.c (add_dyn_prop): Remove objfile parameter.
6698         (create_array_type_with_stride): Update.
6699         * dwarf2read.c (set_die_type): Update.
6700
6701 2018-01-17  Tom Tromey  <tom@tromey.com>
6702
6703         * dwarf2read.c (delayed_method_info): Remove typedef.
6704         (dwarf2_cu::method_info): Now a std::vector.
6705         (add_to_method_list): Update.
6706         (free_delayed_list): Remove.
6707         (compute_delayed_physnames): Update.
6708         (process_full_comp_unit, process_full_type_unit): Clear the method
6709         list.  Remove cleanups.
6710         (psymtab_include_file_name): Add name_holder parameter.  Use
6711         unique_xmalloc_ptr.
6712         (dwarf_decode_lines): Update.
6713
6714 2018-01-17  Tom Tromey  <tom@tromey.com>
6715             Simon Marchi  <simon.marchi@ericsson.com>
6716
6717         * dwarf2read.c (struct dwarf2_cu): Add constructor, destructor.
6718         (dwarf2_per_objfile::free_cached_comp_units)
6719         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
6720         (init_cutu_and_read_dies_no_follow): Update.
6721         (dwarf2_cu::dwarf2_cu): Rename from init_one_comp_unit.
6722         (dwarf2_cu::~dwarf2_cu): New.
6723         (free_heap_comp_unit, free_stack_comp_unit): Remove.
6724         (age_cached_comp_units, free_one_cached_comp_unit): Update.
6725
6726 2018-01-17  Tom Tromey  <tom@tromey.com>
6727             Simon Marchi  <simon.marchi@ericsson.com>
6728
6729         * dwarf2read.c (struct dwarf2_cu) <abbrev_table>: Remove.
6730         (struct die_reader_specs) <abbrev_table>: New member.
6731         (struct abbrev_table): Add constructor.
6732         <alloc_abbrev, add_abbrev, lookup_abbrev>: Declare.
6733         <abbrev_obstack>: Now an auto_obstack.
6734         (abbrev_table_up): New typedef.
6735         (init_cu_die_reader): Add abbrev_table parameter.
6736         (read_cutu_die_from_dwo): Remove abbrev_table_provided parameter.
6737         Add result_dwo_abbrev_table.
6738         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
6739         (init_cutu_and_read_dies_no_follow, build_type_psymtabs_1):
6740         Update.
6741         (peek_die_abbrev): Take die_reader_specs, not dwarf_cu as
6742         parameter.
6743         (skip_children): Update.
6744         (abbrev_table::alloc_abbrev): Rename from
6745         abbrev_table_alloc_abbrev.
6746         (abbrev_table::add_abbrev): Rename from abbrev_table_add_abbrev.
6747         (abbrev_table::lookup_abbrev): Rename from
6748         abbrev_table_lookup_abbrev.
6749         (abbrev_table_read_table): Return abbrev_table_up.
6750         (abbrev_table_free, abbrev_table_free_cleanup)
6751         (dwarf2_read_abbrevs, dwarf2_free_abbrev_table): Remove.
6752         (load_partial_dies): Update.
6753
6754 2018-01-17  Tom Tromey  <tom@tromey.com>
6755
6756         * dwarf2read.c (dwarf2_compute_name): Update comment.
6757         (read_func_scope, read_variable): Update.
6758         (new_symbol): Remove.
6759         (new_symbol_full): Rename to new_symbol.
6760
6761 2018-01-17  Mike Gulick  <mgulick@mathworks.com>
6762
6763         PR gdb/16577
6764         * gdb_bfd.c (gdb_bfd_map_section): If unable to read object file, issue
6765         a warning instead of throwing an error, set section size to 0 and return
6766         NULL.
6767         * gdb_bfd.h (gdb_bfd_map_section): Update description.
6768
6769 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
6770
6771         * nat/linux-ptrace.h (linux_ptrace_attach_fail_reason): Return
6772         std::string.
6773         (linux_ptrace_attach_fail_reason_string): Likewise.
6774         * nat/linux-ptrace.c (linux_ptrace_attach_fail_reason):
6775         Likewise.
6776         (linux_ptrace_attach_fail_reason_string): Likewise.
6777         * linux-nat.c (attach_proc_task_lwp_callback): Adjust.
6778
6779 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
6780
6781         * linux-nat.c (linux_nat_attach): Remove xstrdup.
6782
6783 2018-01-17  Eldar Abusalimov  <eldar.abusalimov@jetbrains.com>
6784
6785         PR gdb/21559
6786         * configure.ac: Include <sys/types.h> prior to <sys/user.h> when
6787         checking for fs_base/gs_base fields in struct user_regs_struct.
6788         * configure: Regenerate.
6789
6790 2018-01-17  Yao Qi  <yao.qi@linaro.org>
6791
6792         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): New
6793         function.
6794         (aarch64_linux_init_abi): Install it to gdbarch hook
6795         gcc_target_options.
6796
6797 2018-01-15  Pedro Alves  <palves@redhat.com>
6798
6799         * common/signals-state-save-restore.c
6800         (save_original_signals_state): Fix typos.
6801
6802 2017-01-12  Tom Tromey  <tom@tromey.com>
6803             Sergio Durigan Junior  <sergiodj@redhat.com>
6804
6805         * Makefile.in (install-only): Install gdb-add-index.
6806
6807 2018-01-12  John Baldwin  <jhb@FreeBSD.org>
6808
6809         * fbsd-tdep.c (KVE_PROTECTION): Correct value.
6810
6811 2018-01-12  Andreas Arnez  <arnez@linux.vnet.ibm.com>
6812
6813         * infrun.c (keep_going_pass_signal): Clear step-over info when
6814         insert_breakpoints fails.
6815
6816 2018-01-11  Pedro Alves  <palves@redhat.com>
6817
6818         PR gdb/22583
6819         * infrun.c (resume): Rename to ...
6820         (resume_1): ... this.
6821         (resume): Reimplement as wrapper around resume_1.
6822
6823 2018-01-11  Pedro Alves  <palves@redhat.com>
6824
6825         PR remote/22597
6826         * remote.c (remote_parse_stop_reply): Default to the last-set
6827         general thread instead of to 'magic_null_ptid'.
6828
6829 2018-01-10  Pedro Alves  <palves@redhat.com>
6830
6831         * language.h (language_get_symbol_name_matcher): Rename ...
6832         (get_symbol_name_matcher): ... this.
6833         * language.c (language_get_symbol_name_matcher): Ditto.
6834         * dictionary.c, linespec.c, minsyms.c, psymtab.c, symtab.c: All
6835         callers adjusted.
6836
6837 2018-01-10  Pedro Alves  <palves@redhat.com>
6838
6839         PR gdb/22670
6840         * dwarf2read.c
6841         (gdb_index_symbol_name_matcher::gdb_index_symbol_name_matcher):
6842         Adjust to use language_get_symbol_name_matcher instead of
6843         language_defn::la_get_symbol_name_matcher.
6844         * language.c (language_get_symbol_name_matcher): If in Ada mode
6845         and the lookup name is a verbatim match, return Ada's matcher.
6846         * language.h (language_get_symbol_name_matcher): Adjust comment.
6847         (ada_lookup_name_info::verbatim_p):: New method.
6848
6849 2018-01-10  Pedro Alves  <palves@redhat.com>
6850
6851         PR gdb/22670
6852         * ada-lang.c (ada_collect_symbol_completion_matches): If the
6853         minsym's language is language_auto or language_cplus, pass down
6854         language_ada instead.
6855         * symtab.c (compare_symbol_name): Don't frob symbol language here.
6856
6857 2018-01-10  Pedro Alves  <palves@redhat.com>
6858
6859         PR gdb/22670
6860         * minsyms.c (linkage_name_str): New function.
6861         (iterate_over_minimal_symbols): Use it.
6862
6863 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6864
6865         * NEWS: Document that 'info proc' now works on FreeBSD.
6866
6867 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6868
6869         * configure.ac: Check for kinfo_getfile in libutil.
6870         * configure: Regenerate.
6871         * config.in: Regenerate.
6872         * fbsd-nat.c: Include "fbsd-tdep.h".
6873         (fbsd_fetch_cmdline): New.
6874         (fbsd_fetch_kinfo_proc): Move earlier and change to return a bool
6875         rather than calling error.
6876         (fbsd_info_proc): New.
6877         (fbsd_thread_name): Report error if fbsd_fetch_kinfo_proc fails.
6878         (fbsd_wait): Report warning if fbsd_fetch_kinfo_proc fails.
6879         (fbsd_nat_add_target): Set "to_info_proc" to "fbsd_info_proc".
6880
6881 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6882
6883         * fbsd-nat.c (struct free_deleter): Remove.
6884         (fbsd_find_memory_regions): Use gdb::unique_xmalloc_ptr<>.
6885
6886 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6887
6888         * fbsd-nat.c (fbsd_pid_to_exec_file) [KERN_PROC_PATHNAME]: Return
6889         NULL for an empty pathname.
6890
6891 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6892
6893         * fbsd-tdep.c (KVE_STRUCTSIZE, KVE_START, KVE_END, KVE_OFFSET)
6894         (KVE_FLAGS, KVE_PROTECTION, KVE_PATH, KINFO_VME_PROT_READ)
6895         (KINFO_VME_PROT_WRITE, KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
6896         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
6897         (KINFO_VME_FLAG_SUPER, KINFO_VME_FLAG_GROWS_UP)
6898         (KINFO_VME_FLAG_GROWS_DOWN, KF_STRUCTSIZE, KF_TYPE, KF_FD)
6899         (KF_PATH, KINFO_FILE_TYPE_VNODE, KINFO_FILE_FD_TYPE_CWD)
6900         (KINFO_FILE_FD_TYPE_TEXT, SIG_WORDS, struct kinfo_proc_layout)
6901         (kinfo_proc_layout_32, kinfo_proc_layout_i386)
6902         (kinfo_proc_layout_64, fbsd_vm_map_entry_flags)
6903         (fbsd_core_info_proc_mappings, fbsd_core_vnode_path)
6904         (fbsd_core_fetch_timeval, fbsd_print_sigset)
6905         (fbsd_core_info_proc_status, fbsd_core_info_proc): New.
6906         (fbsd_init_abi):  Install gdbarch "core_info_proc" method.
6907         * fbsd-tdep.h (fbsd_vm_map_entry_flags): New.
6908
6909 2018-01-08  Samuel Thibault  <samuel.thibault@ens-lyon.org>
6910
6911         * gdb/gnu-nat.c: Include <elf.h> and <link.h>.
6912         (gnu_xfer_auxv): New function.
6913         (gnu_xfer_partial): Call gnu_xfer_auxv when `object' is
6914         TARGET_OBJECT_AUXV.
6915
6916 2018-01-08  Yao Qi  <yao.qi@linaro.org>
6917             Simon Marchi  <simon.marchi@ericsson.com>
6918
6919         * Makefile.in (COMMON_SFILES): Remove selftest-arch.c and
6920         common/selftest.c.
6921         (COMMON_OBS): Remove selftest.o.
6922         * configure.ac: Append selftest-arch.c and common/selftest.c to
6923         CONFIG_SRCS.  Append selftest-arch.o and selftest.o to COMMON_OBS.
6924         * configure: Re-generated.
6925         * maint.c (maintenance_selftest): Wrap selftests::run_tests with
6926         GDB_SELF_TEST.
6927         (maintenance_info_selftests): Likewise.
6928
6929 2018-01-08  Xavier Roirand  <roirand@adacore.com>
6930
6931         * ada-valprint.c (val_print_packed_array_elements): Use
6932         proper number of elements when printing an array indexed
6933         by an enumeration type.
6934
6935 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
6936
6937         * dwarf2read.c (struct dwarf2_cu) <dwarf2_per_objfile>: Remove.
6938         (dw2_get_file_names_reader): Adjust.
6939         (lookup_dwo_signatured_type): Adjust.
6940         (lookup_dwp_signatured_type): Adjust.
6941         (lookup_signatured_type): Adjust.
6942         (create_type_unit_group): Adjust.
6943         (get_type_unit_group): Adjust.
6944         (process_psymtab_comp_unit_reader): Adjust.
6945         (build_type_psymtabs_reader): Adjust.
6946         (scan_partial_symbols): Adjust.
6947         (add_partial_symbol): Adjust.
6948         (add_partial_subprogram): Adjust.
6949         (peek_die_abbrev): Adjust.
6950         (fixup_go_packaging): Adjust.
6951         (process_imported_unit_die): Adjust.
6952         (dwarf2_compute_name): Adjust.
6953         (dwarf2_physname): Adjust.
6954         (read_import_statement): Adjust.
6955         (handle_DW_AT_stmt_list): Adjust.
6956         (read_file_scope): Adjust.
6957         (read_func_scope): Adjust.
6958         (read_lexical_block_scope): Adjust.
6959         (read_call_site_scope): Adjust.
6960         (read_variable): Adjust.
6961         (dwarf2_rnglists_process): Adjust.
6962         (dwarf2_ranges_process): Adjust.
6963         (dwarf2_ranges_read): Adjust.
6964         (dwarf2_get_pc_bounds): Adjust.
6965         (dwarf2_record_block_ranges): Adjust.
6966         (dwarf2_add_field): Adjust.
6967         (dwarf2_add_member_fn): Adjust.
6968         (read_structure_type): Adjust.
6969         (process_structure_scope): Adjust.
6970         (read_enumeration_type): Adjust.
6971         (read_array_type): Adjust.
6972         (mark_common_block_symbol_computed): Adjust.
6973         (read_common_block): Adjust.
6974         (read_namespace_type): Adjust.
6975         (read_namespace): Adjust.
6976         (read_module_type): Adjust.
6977         (read_tag_pointer_type): Adjust.
6978         (read_tag_ptr_to_member_type): Adjust.
6979         (read_tag_string_type): Adjust.
6980         (read_subroutine_type): Adjust.
6981         (read_typedef): Adjust.
6982         (read_base_type): Adjust.
6983         (attr_to_dynamic_prop): Adjust.
6984         (read_subrange_type): Adjust.
6985         (read_unspecified_type): Adjust.
6986         (dwarf2_read_abbrevs): Adjust.
6987         (load_partial_dies): Adjust.
6988         (read_partial_die): Adjust.
6989         (find_partial_die): Adjust.
6990         (guess_partial_die_structure_name): Adjust.
6991         (fixup_partial_die): Adjust.
6992         (read_attribute_value): Adjust.
6993         (read_addr_index): Adjust.
6994         (read_addr_index_from_leb128): Adjust.
6995         (read_str_index): Adjust.
6996         (dwarf2_string_attr): Adjust.
6997         (get_debug_line_section): Adjust.
6998         (dwarf_decode_line_header): Adjust.
6999         (lnp_state_machine::check_line_address): Adjust.
7000         (dwarf_decode_lines_1): Adjust.
7001         (dwarf_decode_lines): Adjust.
7002         (dwarf2_start_symtab): Adjust.
7003         (var_decode_location): Adjust.
7004         (new_symbol_full): Adjust.
7005         (dwarf2_const_value_data): Adjust.
7006         (dwarf2_const_value_attr): Adjust.
7007         (dwarf2_const_value): Adjust.
7008         (die_type): Adjust.
7009         (die_containing_type): Adjust.
7010         (build_error_marker_type): Adjust.
7011         (lookup_die_type): Adjust.
7012         (guess_full_die_structure_name): Adjust.
7013         (anonymous_struct_prefix): Adjust.
7014         (determine_prefix): Adjust.
7015         (dwarf2_name): Adjust.
7016         (follow_die_ref_or_sig): Adjust.
7017         (follow_die_offset): Adjust.
7018         (follow_die_ref): Adjust.
7019         (follow_die_sig_1): Adjust.
7020         (follow_die_sig): Adjust.
7021         (get_signatured_type): Adjust.
7022         (get_DW_AT_signature_type): Adjust.
7023         (decode_locdesc): Adjust.
7024         (dwarf_decode_macros): Adjust.
7025         (cu_debug_loc_section): Adjust.
7026         (fill_in_loclist_baton): Adjust.
7027         (dwarf2_symbol_mark_computed): Adjust.
7028         (init_one_comp_unit): Don't assign
7029         dwarf2_cu::dwarf2_per_objfile.
7030         (set_die_type): Adjust.
7031
7032 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
7033
7034         * dwarf2read.c (struct mapped_debug_names): Add constructor.
7035         <dwarf2_per_objfile>: New field.
7036         (dwarf2_per_objfile): Remove global.
7037         (get_dwarf2_per_objfile): New function.
7038         (set_dwarf2_per_objfile): New function.
7039         (dwarf2_build_psymtabs_hard): Change objfile parameter to
7040         dwarf2_per_objfile.
7041         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
7042         (read_abbrev_offset): Likewise.
7043         (read_indirect_string): Likewise.
7044         (read_indirect_line_string): Likewise.
7045         (read_indirect_string_at_offset): Likewise.
7046         (read_indirect_string_from_dwz): Likewise.
7047         (dwarf2_find_containing_comp_unit): Change objfile parameter to
7048         dwarf2_per_objfile.
7049         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
7050         (create_all_comp_units): Change objfile parameter to
7051         dwarf2_per_objfile.
7052         (create_all_type_units): Likewise.
7053         (process_queue): Add dwarf2_per_objfile parameter.
7054         (read_and_check_comp_unit_head): Likewise.
7055         (lookup_dwo_unit_in_dwp): Likewise.
7056         (get_dwp_file): Likewise.
7057         (process_cu_includes): Likewise.
7058         (struct free_dwo_file_cleanup_data): New struct.
7059         (dwarf2_has_info): Use get_dwarf2_per_objfile and
7060         set_dwarf2_per_objfile.
7061         (dwarf2_get_dwz_file): Add dwarf2_per_objfile parameter.
7062         (dw2_do_instantiate_symtab): Get dwarf2_per_objfile from
7063         context, adjust calls.
7064         (dw2_instantiate_symtab): Likewise.
7065         (dw2_get_cutu): Add dwarf2_per_objfile parameter.
7066         (dw2_get_cu): Likewise.
7067         (create_cu_from_index_list): Change objfile parameter to
7068         dwarf2_per_objfile.
7069         (create_cus_from_index_list): Get dwarf2_per_objfile from
7070         context, adjust calls.
7071         (create_cus_from_index): Likewise.
7072         (create_signatured_type_table_from_index): Change objfile
7073         parameter to dwarf2_per_objfile.
7074         (create_signatured_type_table_from_debug_names): Change objfile
7075         parameter to dwarf2_per_objfile.
7076         (create_addrmap_from_index): Likewise.
7077         (create_addrmap_from_aranges): Likewise.
7078         (dwarf2_read_index): Use get_dwarf2_per_objfile, adjust calls.
7079         (dw2_setup): Remove.
7080         (dw2_get_file_names_reader): Get dwarf2_per_objfile from
7081         context.
7082         (dw2_find_last_source_symtab): Get dwarf2_per_objfile using
7083         get_dwarf2_per_objfile.
7084         (dw2_forget_cached_source_info): Likewise.
7085         (dw2_map_symtabs_matching_filename): Likewise.
7086         (struct dw2_symtab_iterator) <index>: Remove.
7087         <dwarf2_per_objfile>: New field.
7088         (dw2_symtab_iter_init): Replace index parameter with
7089         dwarf2_per_objfile.
7090         (dw2_symtab_iter_next): Use dwarf2_per_objfile from iter.
7091         (dw2_lookup_symbol): Use get_dwarf2_per_objfile and adjust.
7092         (dw2_print_stats): Likewise.
7093         (dw2_dump): Likewise.
7094         (dw2_expand_symtabs_for_function): Likewise.
7095         (dw2_expand_all_symtabs): Likewise.
7096         (dw2_expand_symtabs_with_fullname): Likewise.
7097         (dw2_expand_marked_cus): Replace index and objfile parameters
7098         with dwarf2_per_objfile.
7099         (dw_expand_symtabs_matching_file_matcher): Add
7100         dwarf2_per_objfile parameter and adjust calls.
7101         (dw2_expand_symtabs_matching): Use get_dwarf2_per_objfile and
7102         adjust calls.
7103         (dw2_find_pc_sect_compunit_symtab): Don't call dw2_setup.
7104         (dw2_map_symbol_filenames): Use get_dwarf2_per_objfile and
7105         adjust calls.
7106         (create_cus_from_debug_names_list): Replace objfile parameter
7107         with dwarf2_per_objfile and adjust calls.
7108         (create_cus_from_debug_names): Likewise.
7109         (dwarf2_read_debug_names): Likewise.
7110         (mapped_debug_names::namei_to_name): Adjust call.
7111         (dw2_debug_names_iterator::next): Likewise.
7112         (dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
7113         (dw2_debug_names_lookup_symbol): Use get_dwarf2_per_objfile.
7114         (dw2_debug_names_dump): Likewise.
7115         (dw2_debug_names_expand_symtabs_for_function): Likewise.
7116         (dw2_debug_names_expand_symtabs_matching): Likewise.
7117         (dwarf2_initialize_objfile): Likewise.
7118         (dwarf2_build_psymtabs): Likewise.
7119         (get_abbrev_section_for_cu): Get dwarf2_per_objfile from
7120         this_cu.
7121         (error_check_comp_unit_head): Add dwarf2_per_objfile parameter.
7122         (read_and_check_comp_unit_head): Likewise.
7123         (read_abbrev_offset): Likewise.
7124         (create_debug_type_hash_table): Likewise.
7125         (create_debug_types_hash_table): Likewise.
7126         (create_all_type_units): Replace objfile parameter with
7127         dwarf2_per_objfile.
7128         (add_type_unit): Add dwarf2_per_objfile parameter.
7129         (fill_in_sig_entry_from_dwo_entry): Replace objfile parameter
7130         with dwarf2_per_objfile.
7131         (lookup_dwo_signatured_type): Get dwarf2_per_objfile from cu.
7132         (lookup_dwp_signatured_type): Likewise.
7133         (lookup_signatured_type): Likewise.
7134         (read_cutu_die_from_dwo): Likewise.
7135         (init_tu_and_read_dwo_dies): Likewise.
7136         (init_cutu_and_read_dies): Likewise.
7137         (init_cutu_and_read_dies_no_follow): Likewise.
7138         (allocate_type_unit_groups_table): Add objfile parameter.
7139         (create_type_unit_group): Use dwarf2_per_objfile from cu.
7140         (get_type_unit_group): Likewise.
7141         (process_psymtab_comp_unit): Update call.
7142         (build_type_psymtabs_reader): Use dwarf2_per_objfile from cu.
7143         (build_type_psymtabs_1): Add dwarf2_per_objfile parameter.
7144         (print_tu_stats): Likewise.
7145         (build_type_psymtab_dependencies): Use dwarf2_per_objfile passed
7146         in void* parameter.
7147         (build_type_psymtabs): Change objfile parameter to
7148         dwarf2_per_objfile.
7149         (process_skeletonless_type_unit): Use dwarf2_per_objfile
7150         passed in void* parameter.
7151         (process_skeletonless_type_units): Change objfile parameter to
7152         dwarf2_per_objfile.
7153         (set_partial_user): Likewise.
7154         (dwarf2_build_psymtabs_hard): Likewise.
7155         (read_comp_units_from_section): Likewise.
7156         (create_all_comp_units): Likewise.
7157         (scan_partial_symbols): Update calls.
7158         (add_partial_symbol): Likewise.
7159         (dwarf2_read_symtab): Use get_dwarf2_per_objfile.
7160         (maybe_queue_comp_unit): Use dwarf2_read_symtab from cu.
7161         (process_queue): Add dwarf2_per_objfile parameter.
7162         (get_compunit_symtab): Use dwarf2_per_objfile from cu.
7163         (compute_compunit_symtab_includes): Likewise.
7164         (process_cu_includes): Add dwarf2_per_objfile parameter.
7165         (process_full_comp_unit): Use dwarf2_per_objfile from cu.
7166         (process_full_type_unit): Likewise.
7167         (process_imported_unit_die): Update call.
7168         (handle_DW_AT_stmt_list): Use dwarf2_per_objfile from cu.
7169         (read_file_scope): Likewise.
7170         (allocate_dwo_file_hash_table): Add objfile parameter.
7171         (lookup_dwo_file_slot): Add dwarf2_per_objfile parameter.
7172         (create_cus_hash_table): Likewise.
7173         (create_dwp_hash_table): Likewise.
7174         (create_dwo_unit_in_dwp_v1): Likewise.
7175         (create_dwp_v2_section): Likewise.
7176         (create_dwo_unit_in_dwp_v2): Likewise.
7177         (lookup_dwo_unit_in_dwp): Likewise.
7178         (try_open_dwop_file): Likewise.
7179         (open_dwo_file): Likewise. Use dwarf2_per_objfile from cu.
7180         (open_and_init_dwo_file): Use dwarf2_per_objfile from cu, update
7181         cleanup to include a reference to dwarf2_per_objfile.
7182         (open_dwp_file): Add dwarf2_per_objfile parameter.
7183         (open_and_init_dwp_file): Likewise.
7184         (get_dwp_file): Likewise.
7185         (lookup_dwo_cutu): Use dwarf2_per_objfile from cu.
7186         (queue_and_load_all_dwo_tus): Update call.
7187         (free_dwo_file_cleanup): Use dwarf2_per_objfile from cleanup
7188         data.
7189         (dwarf2_rnglists_process): Use dwarf2_per_objfile from cu.
7190         (dwarf2_ranges_process): Likewise.
7191         (dwarf2_get_pc_bounds): Likewise.
7192         (mark_common_block_symbol_computed): Likewise.
7193         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
7194         (dwarf2_read_abbrevs): Update call.
7195         (read_partial_die): Use dwarf2_per_objfile from cu.
7196         (find_partial_die): Likewise.
7197         (fixup_partial_die): Likewise.
7198         (read_attribute_value): Likewise.
7199         (read_indirect_string_at_offset_from): Add objfile parameter.
7200         (read_indirect_string_at_offset): Add dwarf2_per_objfile
7201         parameter.
7202         (read_indirect_string_from_dwz): Add objfile parameter.
7203         (read_indirect_string): Add objfile parameter.
7204         (read_addr_index_1): Add dwarf2_per_objfile parameter.
7205         (read_addr_index): Use dwarf2_per_objfile from cu.
7206         (dwarf2_read_addr_index): Use dwarf2_per_objfile from cu, don't
7207         call dw2_setup.
7208         (read_str_index): Use dwarf2_per_objfile from cu.
7209         (get_debug_line_section): Likewise.
7210         (read_formatted_entries): Add dwarf2_per_objfile parameter.
7211         (dwarf_decode_line_header): Use dwarf2_per_objfile from cu.
7212         (new_symbol_full): Use dwarf2_per_objfile from cu.
7213         (build_error_marker_type): Likewise.
7214         (lookup_die_type): Likewise.
7215         (determine_prefix): Likewise.
7216         (follow_die_offset): Likewise.
7217         (dwarf2_fetch_die_loc_sect_off): Use get_dwarf2_per_objfile.
7218         (dwarf2_fetch_constant_bytes): Don't call dw2_setup.
7219         (dwarf2_fetch_die_type_sect_off): Likewise.
7220         (dwarf2_get_die_type): Likewise.
7221         (follow_die_sig_1): Use dwarf2_per_objfile from cu.
7222         (get_signatured_type): Likewise.
7223         (get_DW_AT_signature_type): Likewise.
7224         (dwarf_decode_macro_bytes): Add dwarf2_per_objfile parameter.
7225         (dwarf_decode_macros): Use dwarf2_per_objfile from cu.
7226         (cu_debug_loc_section): Likewise.
7227         (fill_in_loclist_baton): Likewise.
7228         (dwarf2_symbol_mark_computed): Likewise.
7229         (dwarf2_find_containing_comp_unit): Change objfile parameter to
7230         dwarf2_per_objfile.
7231         (free_cached_comp_units): Use dwarf2_per_objfile passed in void*
7232         parameter.
7233         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
7234         (free_one_cached_comp_unit): Use dwarf2_per_objfile from cu.
7235         (dwarf2_free_objfile): Use get_dwarf2_per_objfile.
7236         (set_die_type): Use dwarf2_free_objfile from cu.
7237         (get_die_type_at_offset): Likewise.
7238         (dwarf2_per_objfile_free): Don't assign global variable.
7239         (debug_names) <constructor>: Add dwarf2_per_objfile
7240         parameter, update m_debugstrlookup construction.
7241         (debug_names::debug_str_lookup): Add dwarf2_per_objfile
7242         parameter.
7243         <m_dwarf2_per_objfile>: New field.
7244         <lookup>: Use m_dwarf2_per_objfile.
7245         (check_dwarf64_offsets): Add dwarf2_per_objfile parameter.
7246         (psyms_seen_size): Likewise.
7247         (write_gdbindex): Replace objfile parameter with
7248         dwarf2_per_objfile.
7249         (write_debug_names): Likewise.
7250         (write_psymtabs_to_index): Likewise.
7251         (save_gdb_index_command): Use get_dwarf2_per_objfile, update
7252         calls.
7253
7254 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
7255
7256         * dwarf2read.c (struct dwarf2_cu) <objfile>: Remove.
7257         <dwarf2_per_objfile>: New field.
7258         (struct dwarf2_per_cu_data) <objfile>: Remove.
7259         <dwarf2_per_objfile>: New field.
7260         (create_cu_from_index_list): Assign dwarf2_per_objfile instead
7261         of objfile.
7262         (create_signatured_type_table_from_index): Likewise.
7263         (create_debug_type_hash_table): Likewise.
7264         (fill_in_sig_entry_from_dwo_entry): Likewise.
7265         (lookup_dwo_unit): Access objfile through dwarf2_per_objfile.
7266         (create_type_unit_group): Assign dwarf2_per_objfile instead of
7267         objfile.
7268         (create_partial_symtab): Access objfile through
7269         dwarf2_per_objfile.
7270         (process_psymtab_comp_unit_reader): Likewise.
7271         (read_comp_units_from_section): Likewise.
7272         (scan_partial_symbols): Likewise.
7273         (add_partial_symbol): Likewise.
7274         (add_partial_subprogram): Likewise.
7275         (peek_die_abbrev): Likewise.
7276         (fixup_go_packaging): Likewise.
7277         (process_full_comp_unit): Likewise.
7278         (process_full_type_unit): Likewise.
7279         (process_imported_unit_die): Likewise.
7280         (dwarf2_compute_name): Likewise.
7281         (dwarf2_physname): Likewise.
7282         (read_import_statement): Likewise.
7283         (create_cus_hash_table): Assign dwarf2_physname instead of
7284         objfile.
7285         (read_func_scope): Access objfile through dwarf2_per_objfile.
7286         (read_lexical_block_scope): Likewise.
7287         (read_call_site_scope): Likewise.
7288         (read_variable): Likewise.
7289         (dwarf2_rnglists_process): Likewise.
7290         (dwarf2_ranges_process): Likewise.
7291         (dwarf2_ranges_read): Likewise.
7292         (dwarf2_record_block_ranges): Likewise.
7293         (dwarf2_add_field): Likewise.
7294         (dwarf2_add_member_fn): Likewise.
7295         (read_structure_type): Likewise.
7296         (process_structure_scope): Likewise.
7297         (read_enumeration_type): Likewise.
7298         (read_array_type): Likewise.
7299         (read_common_block): Likewise.
7300         (read_namespace_type): Likewise.
7301         (read_namespace): Likewise.
7302         (read_module_type): Likewise.
7303         (read_tag_pointer_type): Likewise.
7304         (read_tag_ptr_to_member_type): Likewise.
7305         (read_tag_string_type): Likewise.
7306         (read_subroutine_type): Likewise.
7307         (read_typedef): Likewise.
7308         (read_base_type): Likewise.
7309         (attr_to_dynamic_prop): Likewise.
7310         (read_subrange_type): Likewise.
7311         (read_unspecified_type): Likewise.
7312         (load_partial_dies): Likewise.
7313         (read_partial_die): Likewise.
7314         (find_partial_die): Likewise.
7315         (guess_partial_die_structure_name): Likewise.
7316         (fixup_partial_die): Likewise.
7317         (read_attribute_value): Likewise.
7318         (read_addr_index_from_leb128): Likewise.
7319         (dwarf2_read_addr_index): Likewise.
7320         (dwarf2_string_attr): Likewise.
7321         (lnp_state_machine::check_line_address): Likewise.
7322         (dwarf_decode_lines_1): Likewise.
7323         (dwarf_decode_lines): Likewise.
7324         (dwarf2_start_symtab): Likewise.
7325         (var_decode_location): Likewise.
7326         (new_symbol_full): Likewise.
7327         (dwarf2_const_value_data): Likewise.
7328         (dwarf2_const_value_attr): Likewise.
7329         (dwarf2_const_value): Likewise.
7330         (die_type): Likewise.
7331         (die_containing_type): Likewise.
7332         (lookup_die_type): Likewise.
7333         (guess_full_die_structure_name): Likewise.
7334         (anonymous_struct_prefix): Likewise.
7335         (dwarf2_name): Likewise.
7336         (follow_die_ref_or_sig): Likewise.
7337         (follow_die_offset): Likewise.
7338         (follow_die_ref): Likewise.
7339         (dwarf2_fetch_die_loc_sect_off): Likewise.
7340         (dwarf2_fetch_constant_bytes): Likewise.
7341         (dwarf2_fetch_die_type_sect_off): Likewise.
7342         (dwarf2_get_die_type): Likewise.
7343         (follow_die_sig): Likewise.
7344         (decode_locdesc): Likewise.
7345         (dwarf2_per_cu_objfile): Likewise.
7346         (dwarf2_per_cu_text_offset): Likewise.
7347         (init_one_comp_unit): Assign dwarf2_per_objfile instead of
7348         objfile.
7349         (set_die_type): Access objfile through
7350         dwarf2_per_objfile.
7351
7352 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
7353
7354         * valprint.c (converted_character_d): Remove typedef.
7355         (DEF_VEC_O (converted_character_d)): Remove.
7356         (count_next_character): Use std::vector.
7357         (print_converted_chars_to_obstack): Likewise.
7358         (generic_printstr): Likewise.
7359
7360 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
7361
7362         * xml-support.h (struct gdb_xml_value): Add constructor.
7363         <value>: Change type to unique_xmalloc_ptr.
7364         (gdb_xml_value_s): Remove typedef.
7365         (DEF_VEC_O (gdb_xml_value_s)): Remove.
7366         (gdb_xml_element_start_handler): Change parameter type to
7367         std::vector.
7368         (xml_find_attribute): Likewise.
7369         * xml-support.c (xml_find_attribute): Change parameter type to
7370         std::vector and adjust.
7371         (gdb_xml_values_cleanup): Remove.
7372         (gdb_xml_parser::start_element): Adjust to std::vector.
7373         (xinclude_start_include): Change paraeter type to std::vector
7374         and adjust.
7375         * btrace.c (check_xml_btrace_version): Likewise.
7376         (parse_xml_btrace_block): Likewise.
7377         (parse_xml_btrace_pt_config_cpu): Likewise.
7378         (parse_xml_btrace_pt): Likewise.
7379         (parse_xml_btrace_conf_bts): Likewise.
7380         (parse_xml_btrace_conf_pt): Likewise.
7381         * memory-map.c (memory_map_start_memory): Likewise.
7382         (memory_map_start_property): Likewise.
7383         * osdata.c (osdata_start_osdata): Likewise.
7384         (osdata_start_item): Likewise.
7385         (osdata_start_column): Likewise.
7386         * remote.c (start_thread): Likewise.
7387         * solib-aix.c (library_list_start_library): Likewise.
7388         (library_list_start_list): Likewise.
7389         * solib-svr4.c (library_list_start_library): Likewise.
7390         (svr4_library_list_start_list): Likewise.
7391         * solib-target.c (library_list_start_segment): Likewise.
7392         (library_list_start_section): Likewise.
7393         (library_list_start_library): Likewise.
7394         (library_list_start_list): Likewise.
7395         * tracepoint.c (traceframe_info_start_memory): Likewise.
7396         (traceframe_info_start_tvar): Likewise.
7397         * xml-syscall.c (syscall_start_syscall): Likewise.
7398         * xml-tdesc.c (tdesc_start_target): Likewise.
7399         (tdesc_start_feature): Likewise.
7400         (tdesc_start_reg): Likewise.
7401         (tdesc_start_union): Likewise.
7402         (tdesc_start_struct): Likewise.
7403         (tdesc_start_flags): Likewise.
7404         (tdesc_start_enum): Likewise.
7405         (tdesc_start_field): Likewise.
7406         (tdesc_start_enum_value): Likewise.
7407         (tdesc_start_vector): Likewise.
7408
7409 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
7410
7411         * extension.h (struct xmethod_worker) <clone>: Remove.
7412         * python/py-xmethods.c (struct python_xmethod_worker) <clone>:
7413         Remove.
7414         (python_xmethod_worker::clone): Remove.
7415         * valops.c (find_overload_match): Use std::move instead of
7416         clone.
7417
7418 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
7419
7420         * extension-priv.h (enum ext_lang_rc): Remove, move to extension.h.
7421         (struct extension_language_ops) <clone_xmethod_worker_data>: Remove.
7422         <free_xmethod_worker_data>: Remove.
7423         <get_matching_xmethod_workers>: Chance VEC to std::vector.
7424         <get_xmethod_arg_types>: Remove.
7425         <get_xmethod_result_type>: Remove.
7426         <invoke_xmethod>: Remove.
7427         * extension.c (new_xmethod_worker): Remove.
7428         (clone_xmethod_worker): Remove.
7429         (get_matching_xmethod_workers): Return void, pass std::vector by
7430         pointer.
7431         (get_xmethod_arg_types): Rename to...
7432         (xmethod_worker::get_arg_types): ... this, and adjust.
7433         (get_xmethod_result_type): Rename to...
7434         (xmethod_worker::get_result_type): ... this, and adjust.
7435         (invoke_xmethod): Remove.
7436         (free_xmethod_worker): Remove.
7437         (free_xmethod_worker_vec): Remove.
7438         * extension.h (enum ext_lang_rc): Move here from
7439         extension-priv.h.
7440         (struct xmethod_worker): Add constructor and destructor.
7441         <data>: Remove.
7442         <value>: Remove.
7443         <invoke, clone, do_get_result_type, do_get_arg_types>: New
7444         virtual pure methods.
7445         <get_arg_types, get_result_type>: New methods.
7446         (xmethod_worker_ptr): Remove typedef.
7447         (DEF_VEC_P (xmethod_worker_ptr)): Remove.
7448         (xmethod_worker_vec): Remove typedef.
7449         (xmethod_worker_up): New typedef.
7450         (invoke_xmethod): Remove.
7451         (clone_xmethod_worker): Remove.
7452         (free_xmethod_worker): Remove.
7453         (free_xmethod_worker_vec): Remove.
7454         (get_xmethod_arg_types): Remove.
7455         (get_xmethod_result_type): Remove.
7456         * valops.c (find_method_list): Use std::vector, don't use
7457         intermediate vector.
7458         (value_find_oload_method_list): Use std::vector.
7459         (find_overload_match): Use std::vector.
7460         (find_oload_champ): Use std::vector.
7461         * value.c (value_free): Use operator delete.
7462         (value_of_xmethod): Rename to...
7463         (value_from_xmethod): ... this.  Don't assign
7464         xmethod_worker::value, take rvalue-reference.
7465         (result_type_of_xmethod): Adjust.
7466         (call_xmethod): Adjust.
7467         * value.h: Include extension.h.
7468         (struct xmethod_worker): Don't forward-declare.
7469         (value_of_xmethod): Rename to...
7470         (value_from_xmethod): ... this, take rvalue-reference.
7471         * python/py-xmethods.c (struct gdbpy_worker_data): Rename to...
7472         (struct python_xmethod_worker): ... this, add constructor and
7473         destructor.
7474         <invoke, clone, do_get_arg_types, do_get_result_type>: Implement.
7475         (gdbpy_free_xmethod_worker_data): Rename to...
7476         (python_xmethod_worker::~python_xmethod_worker): ... this and
7477         adjust.
7478         (gdbpy_clone_xmethod_worker_data): Rename to...
7479         (python_xmethod_worker::clone): ... this and adjust.
7480         (gdbpy_get_matching_xmethod_workers): Use std::vector, don't use
7481         temporary vector.
7482         (gdbpy_get_xmethod_arg_types): Rename to...
7483         (python_xmethod_worker::do_get_arg_types): ... this and adjust.
7484         (gdbpy_get_xmethod_result_type): Rename to...
7485         (python_xmethod_worker::do_get_result_type): ... this and
7486         adjust.
7487         (gdbpy_invoke_xmethod): Rename to...
7488         (python_xmethod_worker::invoke): ... this and adjust.
7489         (new_python_xmethod_worker): Rename to...
7490         (python_xmethod_worker::python_xmethod_worker): ... this and
7491         adjust.
7492         * python/python-internal.h (gdbpy_clone_xmethod_worker_data):
7493         Remove.
7494         (gdbpy_free_xmethod_worker_data): Remove.
7495         (gdbpy_get_matching_xmethod_workers): Use std::vector.
7496         (gdbpy_get_xmethod_arg_types): Remove.
7497         (gdbpy_get_xmethod_result_type): Remove.
7498         (gdbpy_invoke_xmethod): Remove.
7499         * python/python.c (python_extension_ops): Remove obsolete
7500         callbacks.
7501
7502 2018-01-05  Pedro Alves  <palves@redhat.com>
7503
7504         PR gdb/18653
7505         * common/signals-state-save-restore.c
7506         (save_original_signals_state): New parameter 'quiet'.  Warn if we
7507         find a custom handler preinstalled, instead of internal erroring.
7508         But only warn if !quiet.
7509         * common/signals-state-save-restore.h
7510         (save_original_signals_state): New parameter 'quiet'.
7511         * main.c (captured_main_1): Move save_original_signals_state call
7512         after option handling, and pass QUIET.
7513
7514 2018-01-05  Pedro Alves  <palves@redhat.com>
7515
7516         * spu-tdep.c (spu_catch_start): Pass
7517         symbol_name_match_type::SEARCH_NAME to block_lookup_symbol.
7518
7519 2018-01-05  Pedro Alves  <palves@redhat.com>
7520
7521         PR gdb/22670
7522         * ada-lang.c (literal_symbol_name_matcher): New function.
7523         (ada_get_symbol_name_matcher): Use it for
7524         symbol_name_match_type::SEARCH_NAME.
7525         * block.c (block_lookup_symbol): New parameter 'match_type'.  Pass
7526         it down instead of assuming symbol_name_match_type::FULL.
7527         * block.h (block_lookup_symbol): New parameter 'match_type'.
7528         * c-valprint.c (print_unpacked_pointer): Use
7529         lookup_symbol_search_name instead of lookup_symbol.
7530         * compile/compile-object-load.c (get_out_value_type): Pass down
7531         symbol_name_match_type::SEARCH_NAME.
7532         * cp-namespace.c (cp_basic_lookup_symbol): Pass down
7533         symbol_name_match_type::FULL.
7534         * cp-support.c (cp_get_symbol_name_matcher): Handle
7535         symbol_name_match_type::SEARCH_NAME.
7536         * infrun.c (insert_exception_resume_breakpoint): Use
7537         lookup_symbol_search_name.
7538         * p-valprint.c (pascal_val_print): Use lookup_symbol_search_name.
7539         * psymtab.c (maintenance_check_psymtabs): Use
7540         symbol_name_match_type::SEARCH_NAME and SYMBOL_SEARCH_NAME.
7541         * stack.c (print_frame_args): Use lookup_symbol_search_name and
7542         SYMBOL_SEARCH_NAME.
7543         * symtab.c (lookup_local_symbol): Don't demangle the lookup name
7544         if symbol_name_match_type::SEARCH_NAME.
7545         (lookup_symbol_in_language): Pass down
7546         symbol_name_match_type::FULL.
7547         (lookup_symbol_search_name): New.
7548         (lookup_language_this): Pass down
7549         symbol_name_match_type::SEARCH_NAME.
7550         (lookup_symbol_aux, lookup_local_symbol): New parameter
7551         'match_type'.  Pass it down.
7552         * symtab.h (symbol_name_match_type::SEARCH_NAME): New enumerator.
7553         (lookup_symbol_search_name): New declaration.
7554         (lookup_symbol_in_block): New 'match_type' parameter.
7555
7556 2018-01-05  Pedro Alves  <palves@redhat.com>
7557
7558         PR gdb/22670
7559         * ada-lang.c (ada_lookup_encoded_symbol): Reimplement in terms of
7560         ada_lookup_symbol.
7561         (ada_lookup_symbol): Reimplement in terms of
7562         ada_lookup_symbol_list, bits factored out from
7563         ada_lookup_encoded_symbol.
7564
7565 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7566
7567         * ada-exp.y (write_object_renaming): When subscripting an array
7568         using a symbol as the index, pass the block in call to
7569         ada_lookup_encoded_symbol when looking that symbol up.
7570
7571 2018-01-05  Jerome Guitton  <guitton@adacore.com>
7572
7573         * ada-lang.c (ada_array_length): Use ada_index_type instead of
7574         TYPE_INDEX_TYPE.
7575
7576 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7577
7578         * ada-lang.c (ada_to_fixed_value_create): Add handling of
7579         the case where VALUE_LVAL (val0) is not lval_memory.
7580
7581 2018-01-05  Xavier Roirand  <roirand@adacore.com>
7582
7583         * ada-valprint.c (print_optional_low_bound): Handle
7584         character-indexed array printing like boolean-indexed array
7585         printing.
7586
7587 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7588
7589         * NEWS: Create a new section for the next release branch.
7590         Rename the section of the current branch, now that it has
7591         been cut.
7592
7593 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7594
7595         GDB 8.1 branch created (5219ac6237c272b938c28517bf371429260c71e7):
7596         * version.in: Bump version to 8.1.50.DATE-git.
7597
7598 2018-01-03  Xavier Roirand  <roirand@adacore.com>
7599
7600         * ada-lang.h (ada_exception_catchpoint_kind) <ada_catch_handlers>:
7601         Add field.
7602         * ada-lang.c (struct exception_support_info) <catch_handlers_sym>:
7603         Add field.
7604         (default_exception_support_info) <catch_handlers_sym>: Add field.
7605         (exception_support_info_fallback) <catch_handlers_sym>: Add field.
7606         (ada_exception_name_addr_1): Add "catch handlers" handling.
7607         (ada_exception_catchpoint_cond_string) <ex>: New parameter.
7608         Update all callers.
7609         (create_excep_cond_exprs) <ex>: Add parameter.
7610         (re_set_exception): Update create_excep_cond_exprs call.
7611         (print_it_exception, print_one_exception, print_mention_exception)
7612         (print_recreate_exception): Add "catch handler" handling.
7613         (allocate_location_catch_handlers, re_set_catch_handlers)
7614         (check_status_catch_handlers, print_it_catch_handlers)
7615         (print_one_catch_handlers, print_mention_catch_handlers)
7616         (print_recreate_catch_handlers): New function.
7617         (catch_handlers_breakpoint_ops): New variable.
7618         (catch_ada_exception_command_split) <is_catch_handlers_cmd>:
7619         Add parameter.  Add "catch handler" handling.
7620         (ada_exception_sym_name, ada_exception_breakpoint_ops):
7621         Add "catch handler" handling.
7622         (ada_exception_catchpoint_cond_string): Add "catch handler"
7623         handling.
7624         (create_ada_exception_catchpoint): Update create_excep_cond_exprs
7625         call.
7626         (catch_ada_handlers_command): New function.
7627         (initialize_ada_catchpoint_ops): Initialize "catch handlers"
7628         operations structure.
7629         (_initialize_ada_language): Add "catch handlers" command entry.
7630         * NEWS: Document "catch handlers" feature.
7631
7632 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
7633
7634         * ada-lang.c (ada_value_slice_from_ptr): Take array stride into
7635         account when creating the array type of the slice.
7636         (ada_value_slice): Likewise.
7637
7638 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
7639
7640         * gdbtypes.h (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_STRIDE>:
7641         New enum value.
7642         (create_array_type_with_stride): Add byte_stride_prop parameter.
7643         * gdbtypes.c (create_array_type_with_stride) <byte_stride_prop>:
7644         New parameter.  Update all callers in this file.
7645         (array_type_has_dynamic_stride): New function.
7646         (is_dynamic_type_internal, resolve_dynamic_array): Add handling
7647         of arrays with dynamic byte strides.
7648         * dwarf2read.c (read_array_type): Add support for dynamic
7649         DW_AT_byte_stride attributes.
7650
7651 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
7652
7653         * dwarf2read.c (read_unspecified_type): Treat
7654         DW_TAG_enumeration_type DIEs from Ada units as stubs.
7655
7656 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7657
7658         Update copyright year range in all GDB files.
7659
7660 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7661
7662         * copyright.py (BY_HAND): Remove gdb/testsuite/gdb.base/step-line.inp
7663         and gdb/testsuite/gdb.base/step-line.c.
7664
7665 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7666
7667         * copyright.py (main): Dump the contents of
7668         MULTIPLE_COPYRIGHT_HEADERS (separately) from BY_HAND,
7669         even if BY_HAND is empty.
7670
7671 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7672
7673         * top.c (print_gdb_version): Update Copyright year in version
7674         message.
7675
7676 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7677
7678         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2017.
7679
7680 For older changes see ChangeLog-2017.
7681 \f
7682 Local Variables:
7683 mode: change-log
7684 left-margin: 8
7685 fill-column: 74
7686 version-control: never
7687 coding: utf-8
7688 End: