GDB no longer supports Windows before XP.
[external/binutils.git] / gdb / ChangeLog
1 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
2
3         * NEWS: Mention end of support for native debugging on MS-Windows
4         before XP.
5
6         PR gdb/24292
7         * common/netstuff.c:
8         * gdbserver/gdbreplay.c
9         * gdbserver/remote-utils.c:
10         * ser-tcp.c:
11         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
12         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
13         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14         'getaddrinfo' and 'freeaddrinfo' were not available before
15         Windows XP, and mingw.org's MinGW headers by default define
16         _WIN32_WINNT to 0x500.
17
18 2019-03-01  Gary Benson <gbenson@redhat.com>
19
20         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
21
22 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
23             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
24
25         PR gdb/8527
26         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
27         set_sigint_trap, clear_sigint_trap.
28
29 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
30
31         * target.c (target_detach): Clear the regcache and the
32         frame cache.
33
34 2019-02-27  Pedro Alves  <palves@redhat.com>
35
36         * utils.c (set_screen_size): When we cap the height/width sizes,
37         tweak the corresponding command variable to show "unlimited":
38
39 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
40             Pedro Alves  <palves@redhat.com>
41
42         * utils.c (set_screen_size): Reduce "infinite" rows and columns
43         before calling rl_set_screen_size.
44
45 2019-02-27  Tom Tromey  <tromey@adacore.com>
46
47         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
48         define.
49         * python/py-value.c: Remove Python 2.4 workaround.
50         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
51         workaround.
52         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
53         Python 2.4 workaround.
54         * python/python-internal.h: Remove Python 2.4 comment.
55         (Py_ssize_t): Don't define.
56         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
57         (gdb_Py_DECREF): Remove Python 2.4 workaround.
58         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
59         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
60         * python/python.c (do_start_initialization): Remove Python 2.4
61         workaround.
62         * python/py-prettyprint.c (class dummy_python_frame): Remove.
63         (print_children): Remove Python 2.4 workaround.
64         * python/py-inferior.c (buffer_procs): Remove Python 2.4
65         workaround.
66         (CHARBUFFERPROC_NAME): Remove.
67         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
68         Python 2.4 workaround.
69
70 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
71
72         * NEWS: Note minimum Python version.
73
74 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
75
76         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
77         code from these functions.  Remove corresponding ifdefs.  Use
78         Py_buffer_up instead of explicit calls to PyBuffer_Release.
79         Remove gotos and target of gotos.
80         (infpy_search_memory): Likewise.
81
82 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
83
84         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
85         (hppa_gdbarch_init): Don't register deleted functions with
86         gdbarch.
87
88 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
89
90         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
91         (h8300_unwind_sp): Delete.
92         (h8300_dummy_id): Delete.
93         (h8300_gdbarch_init): Don't register deleted functions with
94         gdbarch.
95
96 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
97
98         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
99         (ft32_unwind_pc): Delete.
100         (ft32_unwind_sp): Delete.
101         (ft32_gdbarch_init): Don't register deleted functions with
102         gdbarch.
103
104 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
105
106         * gdb/frv-tdep.c (frv_dummy_id): Delete.
107         (frv_unwind_pc): Delete.
108         (frv_unwind_sp): Delete.
109         (frv_gdbarch_init): Don't register deleted functions with
110         gdbarch.
111
112 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
113
114         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
115         (riscv_unwind_pc): Delete.
116         (riscv_unwind_sp): Delete.
117         (riscv_gdbarch_init): Don't register deleted functions with
118         gdbarch.
119
120 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
121
122         * gdb/csky-tdep.c (csky_dummy_id): Delete.
123         (csky_unwind_pc): Delete.
124         (csky_unwind_sp): Delete.
125         (csky_gdbarch_init): Don't register deleted functions with
126         gdbarch.
127
128 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
129
130         * gdb/cris-tdep.c (cris_dummy_id): Delete.
131         (cris_unwind_pc): Delete.
132         (cris_unwind_sp): Delete.
133         (cris_gdbarch_init): Don't register deleted functions with
134         gdbarch.
135
136 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
137
138         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
139         (bfin_unwind_pc): Delete.
140         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
141
142 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
143
144         * gdb/arm-tdep.c (arm_dummy_id): Delete.
145         (arm_unwind_pc): Delete.
146         (arm_unwind_sp): Delete.
147         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
148
149 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
150
151         * gdb/arc-tdep.c (arc_dummy_id): Delete.
152         (arc_unwind_pc): Delete.
153         (arc_unwind_sp): Delete.
154         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
155
156 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
157
158         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
159         (alpha_unwind_pc): Delete.
160         (alpha_gdbarch_init): Don't register deleted functions with
161         gdbarch.
162
163 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
164
165         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
166         (aarch64_unwind_pc): Delete.
167         (aarch64_unwind_sp): Delete.
168         (aarch64_gdbarch_init): Don't register deleted functions with
169         gdbarch.
170
171 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
172
173         * gdbtypes.c (type_align): Don't consider static members when
174         computing structure alignment.
175
176 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
177
178         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
179         return 0 for other types.
180         * arch-utils.c (default_type_align): Always return 0.
181         * gdbarch.h: Regenerate.
182         * gdbarch.sh (type_align): Extend comment.
183         * gdbtypes.c (type_align): Add additional comments, always call
184         gdbarch_type_align before applying the default rules.
185         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
186         generic code will then apply a suitable default.
187         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
188         types, return 0 for other types.
189
190 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
191
192         * NEWS: Create a new section for the next release branch.
193         Rename the section of the current branch, now that it has
194         been cut.
195
196 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
197
198         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
199         * version.in: Bump version to 8.3.50.DATE-git.
200
201 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
202
203         * aix-thread.c (ptid_cmp): Remove unused variable.
204         (get_signaled_thread): Likewise.
205         (store_regs_user_thread): Likewise.
206         (store_regs_kernel_thread): Likewise.
207         (fetch_regs_kernel_thread): Remove shadowed variable.
208
209 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
210
211         * features/riscv/32bit-cpu.xml: Add register numbers.
212         * features/riscv/32bit-fpu.c: Regenerate.
213         * features/riscv/32bit-fpu.xml: Add register numbers.
214         * features/riscv/64bit-cpu.xml: Add register numbers.
215         * features/riscv/64bit-fpu.c: Regenerate.
216         * features/riscv/64bit-fpu.xml: Add register numbers.
217
218 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
219
220         * NEWS: Mention two argument form of gdb.Value constructor.
221         * python/py-value.c (convert_buffer_and_type_to_value): New
222         function.
223         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
224         Add support for handling an optional second argument.  Call
225         convert_buffer_and_type_to_value as appropriate.
226         * python/python-internal.h (Py_buffer_deleter): New struct.
227         (Py_buffer_up): New typedef.
228
229 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
230
231         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
232         instead of releasing ownership.
233
234 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
235
236         * dwarf2read.c (open_and_init_dwp_file): Call
237         elf_numsections instead of bfd_count_sections to initialize
238         dwp_file->num_sections.
239
240 2019-02-25  Tom Tromey  <tromey@adacore.com>
241
242         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
243
244 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
245
246         * gcore.in: Add '--readnever' option when invoking GDB.
247
248 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
249
250         * MAINTAINERS: Update my email address.
251
252 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
253
254         * build-id.c (build_id_to_debug_bfd_1): New function.
255         (build_id_to_debug_bfd): Look for separate debug file in
256         sysroot.
257
258 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
259
260         * gdbarch.sh: Update the copyright year range that is placed into
261         generated files.
262
263 2019-02-22  Keith Seitz  <keiths@redhat.com>
264
265         PR symtab/23853
266         * linespec.c (create_sals_line_offset): Search for the default
267         symtab's filename instead of its fullname.
268
269 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
270
271         * NEWS: Update style defaults.
272
273 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
274
275         * main.c (captured_main_1): Disable styling in batch mode.
276
277 2019-02-20  Tom Tromey  <tom@tromey.com>
278
279         * symtab.c (symtab_symbol_info): Fix typos.
280
281 2019-02-20  Tom Tromey  <tromey@adacore.com>
282
283         * findcmd.c (_initialize_mem_search): Use upper case for
284         metasyntactic variables.
285
286 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
287
288         * aarch64-tdep.c (aarch64_add_reggroups): New function.
289         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
290
291 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
292
293         * top.h (source_file_name): Change to std::string.
294         * top.c (source_file_name): Likewise.
295         (command_line_input): Adjust.
296         * cli/cli-script.c (script_from_file): Adjust.
297
298 2019-02-19  Tom Tromey  <tromey@adacore.com>
299
300         * ravenscar-thread.c
301         (ravenscar_thread_target::update_thread_list): Don't call
302         ada_build_task_list.
303         * ada-lang.h (ada_build_task_list): Don't declare.
304         * ada-tasks.c (struct ada_tasks_inferior_data)
305         <task_list_valid_p>: Now bool.
306         (read_known_tasks, ada_task_list_changed)
307         (ada_tasks_invalidate_inferior_data): Update.
308         (read_known_tasks_array): Return bool.
309         (read_known_tasks_list): Likewise.
310         (read_known_tasks): Return void.
311         (ada_build_task_list): Now static.
312
313 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
314
315         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
316         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
317
318 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
319
320         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
321         variant for ada_tasks_pspace_data_handle and
322         ada_tasks_inferior_data_handle.
323         (ada_tasks_pspace_data_cleanup): New function.
324         (ada_tasks_inferior_data_cleanup): New function.
325
326 2019-02-17  Tom Tromey  <tom@tromey.com>
327
328         * macrotab.h (macro_source_fullname): Return a std::string.
329         * macrotab.c (macro_include, check_for_redefinition)
330         (macro_undef, macro_lookup_definition, foreach_macro)
331         (foreach_macro_in_scope): Update.
332         (macro_source_fullname): Return a std::string.
333         * macrocmd.c (show_pp_source_pos): Update.
334
335 2019-02-17  Tom Tromey  <tom@tromey.com>
336
337         * macrocmd.c (show_pp_source_pos): Style the file names.
338
339 2019-02-17  Tom Tromey  <tom@tromey.com>
340
341         PR tui/24197:
342         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
343
344 2019-02-17  Tom Tromey  <tom@tromey.com>
345
346         * ada-lang.c (user_select_syms): Use filtered printing.
347         * utils.c (wrap_style): New global.
348         (desired_style): Remove.
349         (emit_style_escape): Add stream parameter.
350         (set_output_style, reset_terminal_style, prompt_for_continue):
351         Update.
352         (flush_wrap_buffer): Only flush gdb_stdout.
353         (wrap_here): Set wrap_style.
354         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
355         treat escape sequences as a character.  Change when wrap buffer is
356         flushed.
357         (fputs_styled): Do not set the output style when the default is
358         requested.
359         * ui-style.h (struct ui_file_style) <is_default>: New method.
360         * source.c (print_source_lines_base): Emit escape sequences in one
361         piece.
362
363 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
364
365         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
366         integers and enumeration types.
367
368 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
369
370         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
371         instead of lookup_symbol_in_language
372         (do_exact_match): New function.
373         (ada_get_symbol_name_matcher): Return do_exact_match when
374         doing a verbatim match.
375
376 2019-02-15  Tom Tromey  <tromey@adacore.com>
377
378         * ravenscar-thread.c (ravenscar_thread_target::resume)
379         (ravenscar_thread_target::wait): Special case wildcard requests.
380
381 2019-02-15  Tom Tromey  <tromey@adacore.com>
382
383         * ravenscar-thread.c (base_ptid): Remove.
384         (struct ravenscar_thread_target) <close>: New method.
385         <m_base_ptid>: New member.
386         <update_inferior_ptid, active_task, task_is_currently_active,
387         runtime_initialized>: Declare methods.
388         <ravenscar_thread_target>: Add constructor.
389         (ravenscar_thread_target::task_is_currently_active)
390         (ravenscar_thread_target::update_inferior_ptid)
391         (ravenscar_runtime_initialized): Rename.  Now methods.
392         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
393         (ravenscar_thread_target::update_thread_list): Update.
394         (ravenscar_thread_target::active_task): Now method.
395         (ravenscar_thread_target::store_registers)
396         (ravenscar_thread_target::prepare_to_store)
397         (ravenscar_thread_target::prepare_to_store)
398         (ravenscar_thread_target::mourn_inferior): Update.
399         (ravenscar_inferior_created): Use "new" to create target.
400         (ravenscar_thread_target::get_ada_task_ptid): Update.
401         (_initialize_ravenscar): Don't initialize base_ptid.
402         (ravenscar_ops): Remove global.
403
404 2019-02-15  Tom Tromey  <tromey@adacore.com>
405
406         * target.h (push_target): Declare new overload.
407         * target.c (push_target): New overload, taking an rvalue reference.
408         * remote.c (remote_target::open_1): Use push_target overload.
409         * corelow.c (core_target_open): Use push_target overload.
410
411 2019-02-15  Tom Tromey  <tromey@adacore.com>
412
413         * ravenscar-thread.c (is_ravenscar_task)
414         (ravenscar_task_is_currently_active): Return bool.
415         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
416         (_initialize_ravenscar): Remove "(void)".
417         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
418         Return bool.
419
420 2019-02-15  Tom Tromey  <tromey@adacore.com>
421
422         * ravenscar-thread.c (ravenscar_runtime_initializer)
423         (has_ravenscar_runtime, get_running_thread_id)
424         (ravenscar_thread_target::resume): Fix indentation.
425
426 2019-02-15  Tom Tromey  <tromey@adacore.com>
427
428         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
429         from ravenscar_arch_ops.
430         (sparc_ravenscar_ops::fetch_registers)
431         (sparc_ravenscar_ops::store_registers): Now methods.
432         (sparc_ravenscar_prepare_to_store): Remove.
433         (sparc_ravenscar_ops): Redefine.
434         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
435         methods and destructor.  Remove members.
436         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
437         (ravenscar_thread_target::store_registers)
438         (ravenscar_thread_target::prepare_to_store): Update.
439         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
440         Remove.
441         (struct ppc_ravenscar_powerpc_ops): Derive from
442         ravenscar_arch_ops.
443         (ppc_ravenscar_powerpc_ops::fetch_registers)
444         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
445         (ppc_ravenscar_powerpc_ops): Redefine.
446         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
447         (ppc_ravenscar_e500_ops::fetch_registers)
448         (ppc_ravenscar_e500_ops::store_registers): Now methods.
449         (ppc_ravenscar_e500_ops): Redefine.
450         * aarch64-ravenscar-thread.c
451         (aarch64_ravenscar_generic_prepare_to_store): Remove.
452         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
453         (aarch64_ravenscar_fetch_registers)
454         (aarch64_ravenscar_store_registers): Now methods.
455         (aarch64_ravenscar_ops): Redefine.
456
457 2019-02-15  Tom Tromey  <tromey@adacore.com>
458
459         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
460         (ravenscar_thread_target::stopped_by_hw_breakpoint)
461         (ravenscar_thread_target::stopped_by_watchpoint)
462         (ravenscar_thread_target::stopped_data_address)
463         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
464
465 2019-02-15  Tom Tromey  <tromey@adacore.com>
466
467         * ravenscar-thread.c: Fix some typos.
468
469 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
470             Tom Tromey  <tromey@adacore.com>
471
472         * ada-lang.c (ada_exception_sal): Change addr_string to a
473         std::string.
474         (create_ada_exception_catchpoint): Update.
475
476 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
477             Tom Tromey  <tromey@adacore.com>
478
479         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
480         (bp_location_ops): Remove.
481         (base_breakpoint_allocate_location): Update.
482         (free_bp_location): Update.
483         * ada-lang.c (class ada_catchpoint_location)
484         <ada_catchpoint_location>: Remove ops parameter.
485         (ada_catchpoint_location_dtor): Remove.
486         (ada_catchpoint_location_ops): Remove.
487         (allocate_location_exception): Update.
488         * breakpoint.h (struct bp_location_ops): Remove.
489         (class bp_location) <bp_location>: Remove bp_location_ops
490         parameter.
491         <~bp_location>: Add destructor.
492         <ops>: Remove.
493
494 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
495             Pedro Alves  <palves@redhat.com>
496
497         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
498         'PATH_MAX'.
499
500 2019-02-14  David Michael  <fedora.dm0@gmail.com>
501             Samuel Thibault  <samuel.thibault@gnu.org>
502             Thomas Schwinge  <thomas@codesourcery.com>
503
504         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
505         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
506
507 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
508
509         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
510         (check_empty): Use "const char *".
511
512         * gnu-nat.c (gnu_nat_target::detach): Instead of
513         'detach_inferior (pid)' call
514         'detach_inferior (find_inferior_pid (pid))'.
515
516         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
517         'nat/fork-inferior.o'.
518         * gnu-nat.c: #include "nat/fork-inferior.h".
519
520         * gnu-nat.c (gnu_nat_target::detach): Instead of
521         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
522         * gnu-nat.h: #include "inf-child.h".
523         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
524         'i386_gnu_nat_target::fetch_registers'.
525         (gnu_store_registers): Rename/move to
526         'i386_gnu_nat_target::store_registers'.
527
528         * config/i386/nm-i386gnu.h: Don't "#include" any files.
529         * gnu-nat.h (mach_thread_info): New function.
530         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
531
532         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
533
534 2019-02-14  Frederic Konrad  <konrad@adacore.com>
535
536         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
537
538 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
539
540         * windows-nat.c (windows_add_thread): Add new parameter
541         "main_thread_p" with default value set to false.  Update
542         function documentation as well as all callers.
543         (windows_delete_thread): Likewise.
544         (fake_create_process): Update call to windows_add_thread.
545         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
546         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
547         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
548         call to windows_delete_thread.
549
550 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
551
552         * MAINTAINERS: Add Andrew Burgess as global maintainer.
553
554 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
555
556         * symfile.c (find_separate_debug_file): Use canonical path of
557         sysroot with child_path instead of gdb_sysroot if it is valid.
558
559 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
560
561         * symfile.c (find_separate_debug_file): Use child_path to
562         determine if an object file is under a sysroot.
563
564 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
565
566         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
567         unittests/child-path-selftests.c.
568         * common/pathstuff.c (child_path): New function.
569         * common/pathstuff.h (child_path): New prototype.
570         * unittests/child-path-selftests.c: New file.
571
572 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
573
574         * symfile.c (find_separate_debug_file): Look for separate debug
575         files in debug directories under the sysroot.
576
577 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
578
579         * symtab.h (struct minimal_symbol data_p): New const method.
580         (struct minimal_symbol text_p): Likewise.
581         * symtab.c (output_source_filename): Use file name style
582         to print file name.
583         (print_symbol_info): Likewise.
584         (print_msymbol_info): Use address style to print addresses.
585         Use function name style to print executable text symbols.
586         (expand_symtab_containing_pc): Use data_p.
587         (find_pc_sect_compunit_symtab): Likewise.
588
589 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
590
591         * breakpoint.c (describe_other_breakpoints): Use address style
592         to print addresses.
593         (say_where): Likewise.
594
595 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
596
597         * ada-typeprint.c (print_func_type): Print function name
598         style to print function name.
599         * c-typeprint.c (c_print_type_1): Likewise.
600
601 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
602
603         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
604         for execve.
605
606 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
607
608         * c-exp.y (direct_abs_decl): Use emplace_back to record the
609         type_stack.
610
611 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
612
613         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
614         TYPE_CODE_REF types.
615
616 2019-02-08  Jim Wilson  <jimw@sifive.com>
617
618         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
619         (riscv_linux_fregset): New.
620         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
621
622 2019-02-07  Tom Tromey  <tom@tromey.com>
623
624         * thread.c (thread_cancel_execution_command): Update.
625         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
626         methods.
627         (struct thread_fsm_ops): Remove.
628         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
629         (thread_fsm_should_stop, thread_fsm_return_value)
630         (thread_fsm_set_finished, thread_fsm_finished_p)
631         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
632         Don't declare.
633         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
634         * infrun.c (clear_proceed_status_thread)
635         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
636         (print_stop_event): Update.
637         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
638         Add constructor.
639         (step_command_fsm_ops): Remove.
640         (new_step_command_fsm): Remove.
641         (step_1): Update.
642         (step_command_fsm::should_stop): Rename from
643         step_command_fsm_should_stop.
644         (step_command_fsm::clean_up): Rename from
645         step_command_fsm_clean_up.
646         (step_command_fsm::do_async_reply_reason): Rename from
647         step_command_fsm_async_reply_reason.
648         (struct until_next_fsm): Inherit from thread_fsm.  Add
649         constructor.
650         (until_next_fsm_ops): Remove.
651         (new_until_next_fsm): Remove.
652         (until_next_fsm::should_stop): Rename from
653         until_next_fsm_should_stop.
654         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
655         (until_next_fsm::do_async_reply_reason): Rename from
656         until_next_fsm_async_reply_reason.
657         (struct finish_command_fsm): Inherit from thread_fsm.  Add
658         constructor.  Change type of breakpoint.
659         (finish_command_fsm_ops): Remove.
660         (new_finish_command_fsm): Remove.
661         (finish_command_fsm::should_stop): Rename from
662         finish_command_fsm_should_stop.
663         (finish_command_fsm::clean_up): Rename from
664         finish_command_fsm_clean_up.
665         (finish_command_fsm::return_value): Rename from
666         finish_command_fsm_return_value.
667         (finish_command_fsm::do_async_reply_reason): Rename from
668         finish_command_fsm_async_reply_reason.
669         (finish_command): Update.
670         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
671         Add constructor.
672         (call_thread_fsm_ops): Remove.
673         (call_thread_fsm::call_thread_fsm): Rename from
674         new_call_thread_fsm.
675         (call_thread_fsm::should_stop): Rename from
676         call_thread_fsm_should_stop.
677         (call_thread_fsm::should_notify_stop): Rename from
678         call_thread_fsm_should_notify_stop.
679         (run_inferior_call, call_function_by_hand_dummy): Update.
680         * cli/cli-interp.c (should_print_stop_to_console): Update.
681         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
682         Add constructor.  Change type of location_breakpoint,
683         caller_breakpoint.
684         (until_break_fsm_ops): Remove.
685         (new_until_break_fsm): Remove.
686         (until_break_fsm::should_stop): Rename from
687         until_break_fsm_should_stop.
688         (until_break_fsm::clean_up): Rename from
689         until_break_fsm_clean_up.
690         (until_break_fsm::do_async_reply_reason): Rename from
691         until_break_fsm_async_reply_reason.
692         (until_break_command): Update.
693         * thread-fsm.c: Remove.
694         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
695
696 2019-02-07  Tom Tromey  <tom@tromey.com>
697
698         * yy-remap.h: Add include guard.
699         * xtensa-tdep.h: Add include guard.
700         * xcoffread.h: Rename include guard.
701         * varobj-iter.h: Add include guard.
702         * tui/tui.h: Rename include guard.
703         * tui/tui-winsource.h: Rename include guard.
704         * tui/tui-wingeneral.h: Rename include guard.
705         * tui/tui-windata.h: Rename include guard.
706         * tui/tui-win.h: Rename include guard.
707         * tui/tui-stack.h: Rename include guard.
708         * tui/tui-source.h: Rename include guard.
709         * tui/tui-regs.h: Rename include guard.
710         * tui/tui-out.h: Rename include guard.
711         * tui/tui-layout.h: Rename include guard.
712         * tui/tui-io.h: Rename include guard.
713         * tui/tui-hooks.h: Rename include guard.
714         * tui/tui-file.h: Rename include guard.
715         * tui/tui-disasm.h: Rename include guard.
716         * tui/tui-data.h: Rename include guard.
717         * tui/tui-command.h: Rename include guard.
718         * tic6x-tdep.h: Add include guard.
719         * target/waitstatus.h: Rename include guard.
720         * target/wait.h: Rename include guard.
721         * target/target.h: Rename include guard.
722         * target/resume.h: Rename include guard.
723         * target-float.h: Rename include guard.
724         * stabsread.h: Add include guard.
725         * rs6000-tdep.h: Add include guard.
726         * riscv-fbsd-tdep.h: Add include guard.
727         * regformats/regdef.h: Rename include guard.
728         * record.h: Rename include guard.
729         * python/python.h: Rename include guard.
730         * python/python-internal.h: Rename include guard.
731         * python/py-stopevent.h: Rename include guard.
732         * python/py-ref.h: Rename include guard.
733         * python/py-record.h: Rename include guard.
734         * python/py-record-full.h: Rename include guard.
735         * python/py-record-btrace.h: Rename include guard.
736         * python/py-instruction.h: Rename include guard.
737         * python/py-events.h: Rename include guard.
738         * python/py-event.h: Rename include guard.
739         * procfs.h: Add include guard.
740         * proc-utils.h: Add include guard.
741         * p-lang.h: Add include guard.
742         * or1k-tdep.h: Rename include guard.
743         * observable.h: Rename include guard.
744         * nto-tdep.h: Rename include guard.
745         * nat/x86-linux.h: Rename include guard.
746         * nat/x86-linux-dregs.h: Rename include guard.
747         * nat/x86-gcc-cpuid.h: Add include guard.
748         * nat/x86-dregs.h: Rename include guard.
749         * nat/x86-cpuid.h: Rename include guard.
750         * nat/ppc-linux.h: Rename include guard.
751         * nat/mips-linux-watch.h: Rename include guard.
752         * nat/linux-waitpid.h: Rename include guard.
753         * nat/linux-ptrace.h: Rename include guard.
754         * nat/linux-procfs.h: Rename include guard.
755         * nat/linux-osdata.h: Rename include guard.
756         * nat/linux-nat.h: Rename include guard.
757         * nat/linux-namespaces.h: Rename include guard.
758         * nat/linux-btrace.h: Rename include guard.
759         * nat/glibc_thread_db.h: Rename include guard.
760         * nat/gdb_thread_db.h: Rename include guard.
761         * nat/gdb_ptrace.h: Rename include guard.
762         * nat/fork-inferior.h: Rename include guard.
763         * nat/amd64-linux-siginfo.h: Rename include guard.
764         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
765         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
766         * nat/aarch64-linux.h: Rename include guard.
767         * nat/aarch64-linux-hw-point.h: Rename include guard.
768         * mn10300-tdep.h: Add include guard.
769         * mips-linux-tdep.h: Add include guard.
770         * mi/mi-parse.h: Rename include guard.
771         * mi/mi-out.h: Rename include guard.
772         * mi/mi-main.h: Rename include guard.
773         * mi/mi-interp.h: Rename include guard.
774         * mi/mi-getopt.h: Rename include guard.
775         * mi/mi-console.h: Rename include guard.
776         * mi/mi-common.h: Rename include guard.
777         * mi/mi-cmds.h: Rename include guard.
778         * mi/mi-cmd-break.h: Rename include guard.
779         * m2-lang.h: Add include guard.
780         * location.h: Rename include guard.
781         * linux-record.h: Rename include guard.
782         * linux-nat.h: Add include guard.
783         * linux-fork.h: Add include guard.
784         * i386-darwin-tdep.h: Rename include guard.
785         * hppa-linux-offsets.h: Add include guard.
786         * guile/guile.h: Rename include guard.
787         * guile/guile-internal.h: Rename include guard.
788         * gnu-nat.h: Rename include guard.
789         * gdb-stabs.h: Rename include guard.
790         * frv-tdep.h: Add include guard.
791         * f-lang.h: Add include guard.
792         * event-loop.h: Add include guard.
793         * darwin-nat.h: Rename include guard.
794         * cp-abi.h: Rename include guard.
795         * config/sparc/nm-sol2.h: Rename include guard.
796         * config/nm-nto.h: Rename include guard.
797         * config/nm-linux.h: Add include guard.
798         * config/i386/nm-i386gnu.h: Rename include guard.
799         * config/djgpp/nl_types.h: Rename include guard.
800         * config/djgpp/langinfo.h: Rename include guard.
801         * compile/gcc-cp-plugin.h: Add include guard.
802         * compile/gcc-c-plugin.h: Add include guard.
803         * compile/compile.h: Rename include guard.
804         * compile/compile-object-run.h: Rename include guard.
805         * compile/compile-object-load.h: Rename include guard.
806         * compile/compile-internal.h: Rename include guard.
807         * compile/compile-cplus.h: Rename include guard.
808         * compile/compile-c.h: Rename include guard.
809         * common/xml-utils.h: Rename include guard.
810         * common/x86-xstate.h: Rename include guard.
811         * common/version.h: Rename include guard.
812         * common/vec.h: Rename include guard.
813         * common/tdesc.h: Rename include guard.
814         * common/selftest.h: Rename include guard.
815         * common/scoped_restore.h: Rename include guard.
816         * common/scoped_mmap.h: Rename include guard.
817         * common/scoped_fd.h: Rename include guard.
818         * common/safe-iterator.h: Rename include guard.
819         * common/run-time-clock.h: Rename include guard.
820         * common/refcounted-object.h: Rename include guard.
821         * common/queue.h: Rename include guard.
822         * common/ptid.h: Rename include guard.
823         * common/print-utils.h: Rename include guard.
824         * common/preprocessor.h: Rename include guard.
825         * common/pathstuff.h: Rename include guard.
826         * common/observable.h: Rename include guard.
827         * common/netstuff.h: Rename include guard.
828         * common/job-control.h: Rename include guard.
829         * common/host-defs.h: Rename include guard.
830         * common/gdb_wait.h: Rename include guard.
831         * common/gdb_vecs.h: Rename include guard.
832         * common/gdb_unlinker.h: Rename include guard.
833         * common/gdb_unique_ptr.h: Rename include guard.
834         * common/gdb_tilde_expand.h: Rename include guard.
835         * common/gdb_sys_time.h: Rename include guard.
836         * common/gdb_string_view.h: Rename include guard.
837         * common/gdb_splay_tree.h: Rename include guard.
838         * common/gdb_setjmp.h: Rename include guard.
839         * common/gdb_ref_ptr.h: Rename include guard.
840         * common/gdb_optional.h: Rename include guard.
841         * common/gdb_locale.h: Rename include guard.
842         * common/gdb_assert.h: Rename include guard.
843         * common/filtered-iterator.h: Rename include guard.
844         * common/filestuff.h: Rename include guard.
845         * common/fileio.h: Rename include guard.
846         * common/environ.h: Rename include guard.
847         * common/common-utils.h: Rename include guard.
848         * common/common-types.h: Rename include guard.
849         * common/common-regcache.h: Rename include guard.
850         * common/common-inferior.h: Rename include guard.
851         * common/common-gdbthread.h: Rename include guard.
852         * common/common-exceptions.h: Rename include guard.
853         * common/common-defs.h: Rename include guard.
854         * common/common-debug.h: Rename include guard.
855         * common/cleanups.h: Rename include guard.
856         * common/buffer.h: Rename include guard.
857         * common/btrace-common.h: Rename include guard.
858         * common/break-common.h: Rename include guard.
859         * cli/cli-utils.h: Rename include guard.
860         * cli/cli-style.h: Rename include guard.
861         * cli/cli-setshow.h: Rename include guard.
862         * cli/cli-script.h: Rename include guard.
863         * cli/cli-interp.h: Rename include guard.
864         * cli/cli-decode.h: Rename include guard.
865         * cli/cli-cmds.h: Rename include guard.
866         * charset-list.h: Add include guard.
867         * buildsym-legacy.h: Rename include guard.
868         * bfin-tdep.h: Add include guard.
869         * ax.h: Rename include guard.
870         * arm-linux-tdep.h: Add include guard.
871         * arm-fbsd-tdep.h: Add include guard.
872         * arch/xtensa.h: Rename include guard.
873         * arch/tic6x.h: Add include guard.
874         * arch/i386.h: Add include guard.
875         * arch/arm.h: Rename include guard.
876         * arch/arm-linux.h: Rename include guard.
877         * arch/arm-get-next-pcs.h: Rename include guard.
878         * arch/amd64.h: Add include guard.
879         * arch/aarch64-insn.h: Rename include guard.
880         * arch-utils.h: Rename include guard.
881         * annotate.h: Add include guard.
882         * amd64-darwin-tdep.h: Rename include guard.
883         * aarch64-linux-tdep.h: Add include guard.
884         * aarch64-fbsd-tdep.h: Add include guard.
885         * aarch32-linux-nat.h: Add include guard.
886
887 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
888
889         * macrotab.c (macro_define_internal): New function that
890         factorizes macro_define_object_internal and macro_define_function
891         code.
892         (macro_define_object_internal): Use macro_define_internal.
893         (macro_define_function): Likewise.
894
895 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
896
897         * macrocmd.c (extract_identifier): Return
898         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
899         callers.
900
901 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
902
903         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
904
905 2019-02-05  Tom Tromey  <tom@tromey.com>
906
907         * target.c (target_stack::unpush): Move assertion earlier.
908
909 2019-01-30  Tom Tromey  <tom@tromey.com>
910
911         PR python/23615:
912         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
913         (gdbpy_parse_and_eval): Likewise.
914         * python/python-internal.h (gdbpy_allow_threads): New class.
915
916 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
917
918         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
919         (aarch64_fbsd_fpregmap): Move earlier.
920         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
921         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
922         instead of individual calls to trad_frame_set_reg_addr.
923         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
924         earlier.
925         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
926         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
927         instead of individual calls to trad_frame_set_reg_addr.
928
929 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
930
931         * CONTRIBUTE: Replace contribution list with wiki link.
932
933 2019-01-25  Tom Tromey  <tom@tromey.com>
934
935         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
936
937 2019-01-25  Tom Tromey  <tom@tromey.com>
938
939         * xtensa-linux-nat.c: Fix common/ includes.
940         * xml-support.h: Fix common/ includes.
941         * xml-support.c: Fix common/ includes.
942         * x86-linux-nat.c: Fix common/ includes.
943         * windows-nat.c: Fix common/ includes.
944         * varobj.h: Fix common/ includes.
945         * varobj.c: Fix common/ includes.
946         * value.c: Fix common/ includes.
947         * valops.c: Fix common/ includes.
948         * utils.c: Fix common/ includes.
949         * unittests/xml-utils-selftests.c: Fix common/ includes.
950         * unittests/utils-selftests.c: Fix common/ includes.
951         * unittests/unpack-selftests.c: Fix common/ includes.
952         * unittests/tracepoint-selftests.c: Fix common/ includes.
953         * unittests/style-selftests.c: Fix common/ includes.
954         * unittests/string_view-selftests.c: Fix common/ includes.
955         * unittests/scoped_restore-selftests.c: Fix common/ includes.
956         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
957         * unittests/scoped_fd-selftests.c: Fix common/ includes.
958         * unittests/rsp-low-selftests.c: Fix common/ includes.
959         * unittests/parse-connection-spec-selftests.c: Fix common/
960         includes.
961         * unittests/optional-selftests.c: Fix common/ includes.
962         * unittests/offset-type-selftests.c: Fix common/ includes.
963         * unittests/observable-selftests.c: Fix common/ includes.
964         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
965         * unittests/memrange-selftests.c: Fix common/ includes.
966         * unittests/memory-map-selftests.c: Fix common/ includes.
967         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
968         * unittests/function-view-selftests.c: Fix common/ includes.
969         * unittests/environ-selftests.c: Fix common/ includes.
970         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
971         * unittests/common-utils-selftests.c: Fix common/ includes.
972         * unittests/cli-utils-selftests.c: Fix common/ includes.
973         * unittests/array-view-selftests.c: Fix common/ includes.
974         * ui-file.c: Fix common/ includes.
975         * tui/tui-io.c: Fix common/ includes.
976         * tracepoint.h: Fix common/ includes.
977         * tracepoint.c: Fix common/ includes.
978         * tracefile-tfile.c: Fix common/ includes.
979         * top.h: Fix common/ includes.
980         * top.c: Fix common/ includes.
981         * thread.c: Fix common/ includes.
982         * target/waitstatus.h: Fix common/ includes.
983         * target/waitstatus.c: Fix common/ includes.
984         * target.h: Fix common/ includes.
985         * target.c: Fix common/ includes.
986         * target-memory.c: Fix common/ includes.
987         * target-descriptions.c: Fix common/ includes.
988         * symtab.h: Fix common/ includes.
989         * symfile.c: Fix common/ includes.
990         * stap-probe.c: Fix common/ includes.
991         * spu-linux-nat.c: Fix common/ includes.
992         * sparc-nat.c: Fix common/ includes.
993         * source.c: Fix common/ includes.
994         * solib.c: Fix common/ includes.
995         * solib-target.c: Fix common/ includes.
996         * ser-unix.c: Fix common/ includes.
997         * ser-tcp.c: Fix common/ includes.
998         * ser-pipe.c: Fix common/ includes.
999         * ser-base.c: Fix common/ includes.
1000         * selftest-arch.c: Fix common/ includes.
1001         * s12z-tdep.c: Fix common/ includes.
1002         * rust-exp.y: Fix common/ includes.
1003         * rs6000-aix-tdep.c: Fix common/ includes.
1004         * riscv-tdep.c: Fix common/ includes.
1005         * remote.c: Fix common/ includes.
1006         * remote-notif.h: Fix common/ includes.
1007         * remote-fileio.h: Fix common/ includes.
1008         * remote-fileio.c: Fix common/ includes.
1009         * regcache.h: Fix common/ includes.
1010         * regcache.c: Fix common/ includes.
1011         * record-btrace.c: Fix common/ includes.
1012         * python/python.c: Fix common/ includes.
1013         * python/py-type.c: Fix common/ includes.
1014         * python/py-inferior.c: Fix common/ includes.
1015         * progspace.h: Fix common/ includes.
1016         * producer.c: Fix common/ includes.
1017         * procfs.c: Fix common/ includes.
1018         * proc-api.c: Fix common/ includes.
1019         * printcmd.c: Fix common/ includes.
1020         * ppc-linux-nat.c: Fix common/ includes.
1021         * parser-defs.h: Fix common/ includes.
1022         * osdata.c: Fix common/ includes.
1023         * obsd-nat.c: Fix common/ includes.
1024         * nat/x86-linux.c: Fix common/ includes.
1025         * nat/x86-linux-dregs.c: Fix common/ includes.
1026         * nat/x86-dregs.h: Fix common/ includes.
1027         * nat/x86-dregs.c: Fix common/ includes.
1028         * nat/ppc-linux.c: Fix common/ includes.
1029         * nat/mips-linux-watch.h: Fix common/ includes.
1030         * nat/mips-linux-watch.c: Fix common/ includes.
1031         * nat/linux-waitpid.c: Fix common/ includes.
1032         * nat/linux-ptrace.h: Fix common/ includes.
1033         * nat/linux-ptrace.c: Fix common/ includes.
1034         * nat/linux-procfs.c: Fix common/ includes.
1035         * nat/linux-personality.c: Fix common/ includes.
1036         * nat/linux-osdata.c: Fix common/ includes.
1037         * nat/linux-namespaces.c: Fix common/ includes.
1038         * nat/linux-btrace.h: Fix common/ includes.
1039         * nat/linux-btrace.c: Fix common/ includes.
1040         * nat/fork-inferior.c: Fix common/ includes.
1041         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1042         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1043         * nat/aarch64-linux.c: Fix common/ includes.
1044         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1045         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1046         * namespace.h: Fix common/ includes.
1047         * mips-linux-tdep.c: Fix common/ includes.
1048         * minsyms.c: Fix common/ includes.
1049         * mi/mi-parse.h: Fix common/ includes.
1050         * mi/mi-main.c: Fix common/ includes.
1051         * mi/mi-cmd-env.c: Fix common/ includes.
1052         * memrange.h: Fix common/ includes.
1053         * memattr.c: Fix common/ includes.
1054         * maint.h: Fix common/ includes.
1055         * maint.c: Fix common/ includes.
1056         * main.c: Fix common/ includes.
1057         * machoread.c: Fix common/ includes.
1058         * location.c: Fix common/ includes.
1059         * linux-thread-db.c: Fix common/ includes.
1060         * linux-nat.c: Fix common/ includes.
1061         * linux-fork.c: Fix common/ includes.
1062         * inline-frame.c: Fix common/ includes.
1063         * infrun.c: Fix common/ includes.
1064         * inflow.c: Fix common/ includes.
1065         * inferior.h: Fix common/ includes.
1066         * inferior.c: Fix common/ includes.
1067         * infcmd.c: Fix common/ includes.
1068         * inf-ptrace.c: Fix common/ includes.
1069         * inf-child.c: Fix common/ includes.
1070         * ia64-linux-nat.c: Fix common/ includes.
1071         * i387-tdep.c: Fix common/ includes.
1072         * i386-tdep.c: Fix common/ includes.
1073         * i386-linux-tdep.c: Fix common/ includes.
1074         * i386-linux-nat.c: Fix common/ includes.
1075         * i386-go32-tdep.c: Fix common/ includes.
1076         * i386-fbsd-tdep.c: Fix common/ includes.
1077         * i386-fbsd-nat.c: Fix common/ includes.
1078         * guile/scm-type.c: Fix common/ includes.
1079         * guile/guile.c: Fix common/ includes.
1080         * go32-nat.c: Fix common/ includes.
1081         * gnu-nat.c: Fix common/ includes.
1082         * gdbthread.h: Fix common/ includes.
1083         * gdbarch-selftests.c: Fix common/ includes.
1084         * gdb_usleep.c: Fix common/ includes.
1085         * gdb_select.h: Fix common/ includes.
1086         * gdb_bfd.c: Fix common/ includes.
1087         * gcore.c: Fix common/ includes.
1088         * fork-child.c: Fix common/ includes.
1089         * findvar.c: Fix common/ includes.
1090         * fbsd-nat.c: Fix common/ includes.
1091         * event-top.c: Fix common/ includes.
1092         * event-loop.c: Fix common/ includes.
1093         * dwarf2read.c: Fix common/ includes.
1094         * dwarf2loc.c: Fix common/ includes.
1095         * dwarf2-frame.c: Fix common/ includes.
1096         * dwarf-index-cache.c: Fix common/ includes.
1097         * dtrace-probe.c: Fix common/ includes.
1098         * disasm-selftests.c: Fix common/ includes.
1099         * defs.h: Fix common/ includes.
1100         * csky-tdep.c: Fix common/ includes.
1101         * cp-valprint.c: Fix common/ includes.
1102         * cp-support.h: Fix common/ includes.
1103         * cp-support.c: Fix common/ includes.
1104         * corelow.c: Fix common/ includes.
1105         * completer.h: Fix common/ includes.
1106         * completer.c: Fix common/ includes.
1107         * compile/compile.c: Fix common/ includes.
1108         * compile/compile-loc2c.c: Fix common/ includes.
1109         * compile/compile-cplus-types.c: Fix common/ includes.
1110         * compile/compile-cplus-symbols.c: Fix common/ includes.
1111         * command.h: Fix common/ includes.
1112         * cli/cli-dump.c: Fix common/ includes.
1113         * cli/cli-cmds.c: Fix common/ includes.
1114         * charset.c: Fix common/ includes.
1115         * build-id.c: Fix common/ includes.
1116         * btrace.h: Fix common/ includes.
1117         * btrace.c: Fix common/ includes.
1118         * breakpoint.h: Fix common/ includes.
1119         * breakpoint.c: Fix common/ includes.
1120         * ax.h: 
1121         (enum agent_op): Fix common/ includes.
1122         * ax-general.c (struct aop_map): Fix common/ includes.
1123         * ax-gdb.c: Fix common/ includes.
1124         * auxv.c: Fix common/ includes.
1125         * auto-load.c: Fix common/ includes.
1126         * arm-tdep.c: Fix common/ includes.
1127         * arch/riscv.c: Fix common/ includes.
1128         * arch/ppc-linux-common.c: Fix common/ includes.
1129         * arch/i386.c: Fix common/ includes.
1130         * arch/arm.c: Fix common/ includes.
1131         * arch/arm-linux.c: Fix common/ includes.
1132         * arch/arm-get-next-pcs.c: Fix common/ includes.
1133         * arch/amd64.c: Fix common/ includes.
1134         * arch/aarch64.c: Fix common/ includes.
1135         * arch/aarch64-insn.c: Fix common/ includes.
1136         * arch-utils.c: Fix common/ includes.
1137         * amd64-windows-tdep.c: Fix common/ includes.
1138         * amd64-tdep.c: Fix common/ includes.
1139         * amd64-sol2-tdep.c: Fix common/ includes.
1140         * amd64-obsd-tdep.c: Fix common/ includes.
1141         * amd64-nbsd-tdep.c: Fix common/ includes.
1142         * amd64-linux-tdep.c: Fix common/ includes.
1143         * amd64-linux-nat.c: Fix common/ includes.
1144         * amd64-fbsd-tdep.c: Fix common/ includes.
1145         * amd64-fbsd-nat.c: Fix common/ includes.
1146         * amd64-dicos-tdep.c: Fix common/ includes.
1147         * amd64-darwin-tdep.c: Fix common/ includes.
1148         * agent.c: Fix common/ includes.
1149         * ada-lang.h: Fix common/ includes.
1150         * ada-lang.c: Fix common/ includes.
1151         * aarch64-tdep.c: Fix common/ includes.
1152
1153 2019-01-25  Tom Tromey  <tom@tromey.com>
1154
1155         * common/create-version.sh: Use common/version.h.
1156
1157 2019-01-24  Pedro Alves  <palves@redhat.com>
1158
1159         * infrun.c (signal_stop, signal_print, signal_program)
1160         (signal_catch, signal_pass): Now arrays instead of pointers.
1161         (update_signals_program_target, do_target_resume)
1162         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1163         * linux-nat.c (linux_nat_target::pass_signals)
1164         (linux_nat_target::create_inferior, linux_nat_target::attach):
1165         Adjust.
1166         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1167         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1168         * procfs.c (procfs_target::pass_signals): Adjust.
1169         * record-full.c (record_full_target::resume): Adjust.
1170         * remote.c (remote_target::pass_signals)
1171         (remote_target::program_signals): Adjust.
1172         * target-debug.h (target_debug_print_signals): Now takes a
1173         gdb::array_view as parameter.  Adjust.
1174         * target.h (target_ops) <pass_signals, program_signals>: Replace
1175         pointer and length parameters with gdb::array_view.
1176         (target_pass_signals, target_program_signals): Likewise.
1177         * target-delegates.c: Regenerate.
1178
1179 2019-01-24  Pedro Alves  <palves@redhat.com>
1180
1181         * common/forward-scope-exit.h
1182         (forward_scope_exit::forward_scope_exit): Pass arguments to
1183         m_bind_function directly, instead of creating a std::bind and
1184         copying that.
1185
1186 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1187
1188         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1189         for static members.
1190         (pass_in_v_vfp_candidate): Likewise.
1191
1192 2019-01-23  Tom Tromey  <tom@tromey.com>
1193             Pedro Alves  <palves@redhat.com>
1194
1195         * regcache.c (class regcache_invalidator): Remove.
1196         (regcache::raw_write): Use make_scope_exit.
1197
1198 2019-01-23  Tom Tromey  <tom@tromey.com>
1199
1200         * ui-out.h (class ui_out_emit_type): Update comment.
1201
1202 2019-01-23  Tom Tromey  <tom@tromey.com>
1203
1204         * infrun.c (fetch_inferior_event): Update comment.
1205
1206 2019-01-23  Tom Tromey  <tom@tromey.com>
1207             Pedro Alves  <palves@redhat.com>
1208
1209         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1210         parameter.
1211         (fetch_inferior_event): Use SCOPE_EXIT.
1212
1213
1214 2019-01-23  Tom Tromey  <tom@tromey.com>
1215             Pedro Alves  <palves@redhat.com>
1216
1217         * infrun.c (disable_thread_events): Delete.
1218         (stop_all_threads): Use SCOPE_EXIT.
1219
1220 2019-01-23  Tom Tromey  <tom@tromey.com>
1221             Pedro Alves  <palves@redhat.com>
1222
1223         * symfile.c: Include forward-scope-exit.h.
1224         (clear_symtab_users_cleanup): Replace forward declaration with
1225         a FORWARD_SCOPE_EXIT.
1226         (syms_from_objfile_1): Use the forward_scope_exit and
1227         gdb::optional instead of cleanup_function.
1228         (reread_symbols): Use the forward_scope_exit instead of
1229         cleanup_function.
1230         (clear_symtab_users_cleanup): Remove function.
1231
1232 2019-01-23  Tom Tromey  <tom@tromey.com>
1233             Pedro Alves  <palves@redhat.com>
1234
1235         * linux-nat.c: Include scope-exit.h.
1236         (cleanup_target_stop): Remove.
1237         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1238         SCOPE_EXIT.
1239
1240 2019-01-23  Tom Tromey  <tom@tromey.com>
1241             Pedro Alves  <palves@redhat.com>
1242
1243         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1244         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1245
1246 2019-01-23  Tom Tromey  <tom@tromey.com>
1247             Andrew Burgess  <andrew.burgess@embecosm.com>
1248             Pedro Alves  <palves@redhat.com>
1249
1250         * infrun.c (fetch_inferior_event): Use scope_exit.
1251         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1252         * top.c (execute_command): Use scope_exit.
1253         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1254         * utils.c (do_bpstat_clear_actions_cleanup)
1255         (make_bpstat_clear_actions_cleanup): Remove.
1256
1257 2019-01-23  Tom Tromey  <tom@tromey.com>
1258             Pedro Alves  <palves@redhat.com>
1259
1260         * infrun.c: Include "common/scope-exit.h"
1261         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1262         (wait_for_inferior): Use SCOPE_EXIT.
1263         (fetch_inferior_event): Use scope_exit.
1264
1265 2019-01-23  Tom Tromey  <tom@tromey.com>
1266             Pedro Alves  <palves@redhat.com>
1267
1268         * breakpoint.c (create_breakpoint): Remove cleanup.
1269
1270 2019-01-23  Tom Tromey  <tom@tromey.com>
1271             Andrew Burgess  <andrew.burgess@embecosm.com>
1272             Pedro Alves  <palves@redhat.com>
1273
1274 2019-01-23  Pedro Alves  <palves@redhat.com>
1275
1276         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1277
1278 2019-01-23  Pedro Alves  <palves@redhat.com>
1279             Andrew Burgess  <andrew.burgess@embecosm.com>
1280
1281         * gdbthread.h: Include "common/forward-scope-exit.h".
1282         (scoped_finish_thread_state): Redefine custom class in terms of
1283         forward_scope_exit.
1284
1285 2019-01-23  Pedro Alves  <palves@redhat.com>
1286             Andrew Burgess  <andrew.burgess@embecosm.com>
1287
1288         * common/forward-scope-exit.h: New file.
1289
1290 2019-01-23  Pedro Alves  <palves@redhat.com>
1291             Andrew Burgess  <andrew.burgess@embecosm.com>
1292             Tom Tromey  <tom@tromey.com>
1293
1294         * common/scope-exit.h: New file.
1295
1296 2019-01-23  Pedro Alves  <palves@redhat.com>
1297
1298         * common/preprocessor.h (ESC): Rename to ...
1299         (ESC_PARENS): ... this.
1300         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1301         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1302
1303 2019-01-23  Tom Tromey  <tom@tromey.com>
1304
1305         * language.h (class scoped_switch_to_sym_language_if_auto):
1306         Initialize m_lang in both cases.
1307
1308 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1309
1310         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1311         with XCNEW.
1312
1313 2019-01-22  Tom Tromey  <tom@tromey.com>
1314
1315         * corelow.c: Do not include sys/file.h.
1316
1317 2019-01-22  Tom Tromey  <tom@tromey.com>
1318
1319         * tui/tui-wingeneral.h: Include gdb_curses.h.
1320
1321 2019-01-22  Tom Tromey  <tom@tromey.com>
1322
1323         * source-cache.h (class source_cache) <get_source_lines,
1324         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1325
1326 2019-01-22  Tom Tromey  <tom@tromey.com>
1327
1328         * remote-fileio.h (struct remote_target): Declare.
1329
1330 2019-01-22  Tom Tromey  <tom@tromey.com>
1331
1332         * python/py-arch.c: Do not include py-ref.h.
1333         * python/py-bpevent.c: Do not include py-ref.h.
1334         * python/py-cmd.c: Do not include py-ref.h.
1335         * python/py-continueevent.c: Do not include py-ref.h.
1336         * python/py-event.h: Do not include py-ref.h.
1337         * python/py-evtregistry.c: Do not include py-ref.h.
1338         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1339         * python/py-frame.c: Do not include py-ref.h.
1340         * python/py-framefilter.c: Do not include py-ref.h.
1341         * python/py-function.c: Do not include py-ref.h.
1342         * python/py-infevents.c: Do not include py-ref.h.
1343         * python/py-linetable.c: Do not include py-ref.h.
1344         * python/py-objfile.c: Do not include py-ref.h.
1345         * python/py-param.c: Do not include py-ref.h.
1346         * python/py-prettyprint.c: Do not include py-ref.h.
1347         * python/py-progspace.c: Do not include py-ref.h.
1348         * python/py-symbol.c: Do not include py-ref.h.
1349         * python/py-symtab.c: Do not include py-ref.h.
1350         * python/py-type.c: Do not include py-ref.h.
1351         * python/py-unwind.c: Do not include py-ref.h.
1352         * python/py-utils.c: Do not include py-ref.h.
1353         * python/py-value.c: Do not include py-ref.h.
1354         * python/py-varobj.c: Do not include py-ref.h.
1355         * python/py-xmethods.c: Do not include py-ref.h.
1356         * python/python.c: Do not include py-ref.h.
1357         * varobj.c: Do not include py-ref.h.
1358
1359 2019-01-22  Tom Tromey  <tom@tromey.com>
1360
1361         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1362         keyword for bcache.
1363
1364 2019-01-22  Tom Tromey  <tom@tromey.com>
1365
1366         * compile/compile-cplus-types.c: Remove a comment by #include.
1367
1368 2019-01-22  Tom Tromey  <tom@tromey.com>
1369
1370         * compile/gcc-c-plugin.h: Include compile-internal.h.
1371
1372 2019-01-22  Tom Tromey  <tom@tromey.com>
1373
1374         * stabsread.c (EXTERN): Do not define.
1375         (symnum, next_symbol_text_func, processing_gcc_compilation)
1376         (within_function, global_sym_chain, global_stabs)
1377         (previous_stab_code, this_object_header_files)
1378         (n_this_object_header_files)
1379         (n_allocated_this_object_header_files): Define.
1380         * stabsread.h (EXTERN): Never define.  Use "extern".
1381
1382 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1383
1384         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1385         history_value.
1386
1387 2019-01-21  Tom Tromey  <tom@tromey.com>
1388
1389         * ui-out.c: Fix includes.
1390         * tui/tui-source.c: Fix includes.
1391         * target.c: Fix includes.
1392         * remote.c: Fix includes.
1393         * regcache.c: Fix includes.
1394         * python/py-block.c: Fix includes.
1395         * printcmd.c: Fix includes.
1396         * or1k-tdep.c: Fix includes.
1397         * mi/mi-main.c: Fix includes.
1398         * m32r-tdep.c: Fix includes.
1399         * csky-tdep.c: Fix includes.
1400         * compile/compile-cplus-types.c: Fix includes.
1401         * cli/cli-interp.c: Fix includes.
1402
1403 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1404
1405         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1406         for padding.
1407
1408 2019-01-16  Tom Tromey  <tom@tromey.com>
1409
1410         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1411         earlier.
1412         (struct objfile) <msymbols_range>: Move from top level.
1413         <msymbols>: New method.
1414         (class objfile_msymbols): Remove.
1415         * symtab.c (default_collect_symbol_completion_matches_break_on):
1416         Update.
1417         * symmisc.c (dump_msymbols): Update.
1418         * stabsread.c (scan_file_globals): Update.
1419         * objc-lang.c (info_selectors_command, info_classes_command)
1420         (find_methods): Update.
1421         * minsyms.c (find_solib_trampoline_target): Update.
1422         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1423         * coffread.c (coff_symfile_read): Update.
1424         * ada-lang.c (ada_lookup_simple_minsym)
1425         (ada_collect_symbol_completion_matches): Update.
1426
1427 2019-01-16  Tom Tromey  <tom@tromey.com>
1428
1429         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1430         type.  Remove no-argument constructor.
1431         <iterator::operator++>: Simplify.
1432         <begin>: Update.
1433         <end>: Use minimal_symbol_count.
1434
1435 2019-01-16  Tom Tromey  <tom@tromey.com>
1436
1437         * objfiles.h (struct objfile) <psymtabs>: New method.
1438         (class objfile_psymtabs): Remove.
1439         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1440         typedef.
1441         <range>: New method.
1442         (require_partial_symbols): Change return type.
1443         * psymtab.c (require_partial_symbols)
1444         (psym_expand_symtabs_matching): Update.
1445         * mdebugread.c (parse_partial_symbols): Update.
1446         * dbxread.c (dbx_end_psymtab): Update.
1447
1448 2019-01-15  Tom Tromey  <tom@tromey.com>
1449
1450         * symtab.c (lookup_objfile_from_block)
1451         (lookup_symbol_in_objfile_symtabs)
1452         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1453         (find_line_symtab, info_sources_command)
1454         (default_collect_symbol_completion_matches_break_on)
1455         (make_source_files_completion_list): Update.
1456         * symmisc.c (print_objfile_statistics, dump_objfile)
1457         (maintenance_print_symbols, maintenance_info_symtabs)
1458         (maintenance_check_symtabs, maintenance_info_line_tables):
1459         Update.
1460         * source.c (select_source_symtab)
1461         (forget_cached_source_info_for_objfile): Update.
1462         * objfiles.h (class objfile_compunits): Remove.
1463         (struct objfile) <compunits_range>: New typedef.
1464         (compunits): New method.
1465         * objfiles.c (objfile_relocate1): Update.
1466         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1467         * maint.c (count_symtabs_and_blocks): Update.
1468         * linespec.c (iterate_over_all_matching_symtabs): Update.
1469         * cp-support.c (add_symbol_overload_list_qualified): Update.
1470         * coffread.c (coff_symtab_read): Update.
1471         * ada-lang.c (add_nonlocal_symbols)
1472         (ada_collect_symbol_completion_matches)
1473         (ada_add_global_exceptions): Update.
1474
1475 2019-01-15  Tom Tromey  <tom@tromey.com>
1476
1477         * progspace.h (program_space) <objfiles_safe_range>: New
1478         typedef.
1479         <objfiles_safe>: New method.
1480         * objfiles.h (class all_objfiles_safe): Remove.
1481         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1482         * jit.c (jit_inferior_exit_hook): Update.
1483
1484 2019-01-17  Tom Tromey  <tom@tromey.com>
1485
1486         * progspace.h (program_space) <objfiles_range>: New typedef.
1487         <objfiles>: New method.
1488         <objfiles_head>: Rename from objfiles.
1489         (object_files): Update.
1490         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1491         * guile/scm-pretty-print.c
1492         (ppscm_find_pretty_printer_from_objfiles): Update.
1493         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1494         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1495         Update.
1496         * python/py-progspace.c (pspy_get_objfiles): Update.
1497         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1498         Update.
1499         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1500         (objfpy_lookup_objfile_by_build_id): Update.
1501         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1502         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1503         Update.
1504         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1505         (expand_symtab_containing_pc, lookup_objfile_from_block)
1506         (lookup_static_symbol, basic_lookup_transparent_type)
1507         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1508         (find_line_symtab, info_sources_command)
1509         (default_collect_symbol_completion_matches_break_on)
1510         (make_source_files_completion_list, find_main_name): Update.
1511         * symmisc.c (print_symbol_bcache_statistics)
1512         (print_objfile_statistics, maintenance_print_symbols)
1513         (maintenance_print_msymbols, maintenance_print_objfiles)
1514         (maintenance_info_symtabs, maintenance_check_symtabs)
1515         (maintenance_expand_symtabs, maintenance_info_line_tables):
1516         Update.
1517         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1518         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1519         (map_overlay_command, unmap_overlay_command)
1520         (simple_overlay_update, expand_symtabs_matching)
1521         (map_symbol_filenames): Update.
1522         * symfile-debug.c (set_debug_symfile): Update.
1523         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1524         Update.
1525         * source.c (select_source_symtab, forget_cached_source_info):
1526         Update.
1527         * solib.c (solib_read_symbols): Update.
1528         * solib-spu.c (append_ocl_sos): Update.
1529         * psymtab.c (maintenance_print_psymbols)
1530         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1531         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1532         * printcmd.c (info_symbol_command): Update.
1533         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1534         Update.
1535         * objfiles.h (class all_objfiles): Remove.
1536         * objfiles.c (have_partial_symbols, have_full_symbols)
1537         (have_minimal_symbols, qsort_cmp, update_section_map)
1538         (shared_objfile_contains_address_p)
1539         (default_iterate_over_objfiles_in_search_order): Update.
1540         * objc-lang.c (info_selectors_command, info_classes_command)
1541         (find_methods): Update.
1542         * minsyms.c (find_solib_trampoline_target): Update.
1543         * maint.c (maintenance_info_sections)
1544         (maintenance_translate_address, count_symtabs_and_blocks):
1545         Update.
1546         * main.c (captured_main_1): Update.
1547         * linux-thread-db.c (try_thread_db_load_from_pdir)
1548         (has_libpthread): Update.
1549         * linespec.c (iterate_over_all_matching_symtabs)
1550         (search_minsyms_for_name): Update.
1551         * jit.c (jit_find_objf_with_entry_addr): Update.
1552         * hppa-tdep.c (find_unwind_entry)
1553         (hppa_lookup_stub_minimal_symbol): Update.
1554         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1555         Update.
1556         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1557         (elf_gnu_ifunc_resolve_by_got): Update.
1558         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1559         * dwarf-index-write.c (save_gdb_index_command): Update.
1560         * cp-support.c (add_symbol_overload_list_qualified): Update.
1561         * breakpoint.c (create_overlay_event_breakpoint)
1562         (create_longjmp_master_breakpoint)
1563         (create_std_terminate_master_breakpoint)
1564         (create_exception_master_breakpoint): Update.
1565         * blockframe.c (find_pc_partial_function): Update.
1566         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1567         (ada_collect_symbol_completion_matches)
1568         (ada_add_global_exceptions): Update.
1569
1570 2019-01-17  Tom Tromey  <tom@tromey.com>
1571
1572         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1573         declare VEC.
1574         (solib_target_parse_libraries): Change return type.
1575         (library_list_start_segment, library_list_start_section)
1576         (library_list_end_library, library_list_start_library); Update.
1577         (solib_target_free_library_list): Remove.
1578         (solib_target_parse_libraries): Remove cleanup.  Change return
1579         type.
1580         (solib_target_current_sos): Update.
1581
1582 2019-01-17  Tom Tromey  <tromey@bapiya>
1583
1584         * valprint.c: Replace "the the" with "the".
1585         * symtab.c: Replace "the the" with "the".
1586         * solib.c: Replace "the the" with "the".
1587         * solib-dsbt.c: Replace "the the" with "the".
1588         * linespec.c: Replace "the the" with "the".
1589         * dwarf2loc.h: Replace "the the" with "the".
1590         * amd64-windows-tdep.c: Replace "the the" with "the".
1591         * aarch64-tdep.c: Replace "the the" with "the".
1592
1593 2019-01-16  Keith Seitz  <keiths@redhat.com>
1594
1595         PR gdb/23773
1596         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1597         <builder>: Rename to ..
1598         <m_builder>: ... this and make private.
1599         (dwarf2_cu::get_builder): New method.  Change all users of
1600         `builder' to use this method.
1601         (dwarf2_start_symtab): Move to ...
1602         (dwarf2_cu::start_symtab): ... here.  Update all callers
1603         (setup_type_unit_groups): Move to ...
1604         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1605         callers.
1606         (dwarf2_cu::reset_builder): New method.
1607         (process_full_compunit, process_full_type_unit): Use
1608         dwarf2_cu::reset_builder.
1609         (follow_die_offset): Record the ancestor CU if it is different
1610         from the followed DIE's CU.
1611         (follow_die_sig_1): Likewise.
1612
1613 2019-01-15  Tom Tromey  <tom@tromey.com>
1614
1615         * remote.c (class remote_state) <buf>: Now a char_vector.
1616         <buf_size>: Remove.
1617         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1618         parameter.
1619         (remote_target::getpkt_or_notif_sane_1)
1620         (remote_target::getpkt_sane)
1621         (remote_target::getpkt_or_notif_sane): Likewise.
1622         (class remote_target) <putpkt>: New overload.
1623         (remote_target::read_frame): Change type of "buf_p".  Remove
1624         sizeof_p parameter.
1625         (packet_ok): New overload.
1626         (packet_check_result): New overload.
1627         Update all uses.
1628
1629 2019-01-14  Tom Tromey  <tom@tromey.com>
1630
1631         * remote-notif.c (handle_notification, remote_notif_ack)
1632         (remote_notif_parse): Make "buf" const.
1633         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1634         const.
1635         (remote_notif_parse, remote_notif_ack, handle_notification):
1636         Likewise.
1637         * remote.c (remote_notif_stop_parse): Make "buf" const.
1638         (remote_target::remote_parse_stop_reply): Make "buf" const.
1639         (remote_notif_stop_ack): Make "buf" const.
1640
1641 2019-01-14  Tom Tromey  <tom@tromey.com>
1642
1643         * remote.c (remote_console_output): Make parameter const.
1644
1645 2019-01-14  Tom Tromey  <tom@tromey.com>
1646
1647         * target-debug.h (target_debug_print_signals): Constify.
1648         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1649         * procfs.c (procfs_target::pass_signals): Update.
1650         * linux-nat.c (linux_nat_target::pass_signals): Update.
1651         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1652         * target-delegates.c: Rebuild.
1653         * remote.c (remote_target::program_signals): Update.
1654         (remote_target::pass_signals): Update.
1655         * target.c (target_pass_signals): Constify argument.
1656         (target_program_signals): Likewise.
1657         * target.h (struct target_ops) <pass_signals, program_signals>:
1658         Constify argument.
1659         (target_pass_signals, target_program_signals): Constify argument.
1660
1661 2019-01-14  Tom Tromey  <tom@tromey.com>
1662
1663         PR tui/28819:
1664         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1665
1666 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1667
1668         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1669         field.
1670         * rs6000-tdep.c: Include reggroups.h.
1671         (IS_V_ALIAS_PSEUDOREG): Define.
1672         (rs6000_register_name): Return names for the "vX" aliases.
1673         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1674         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1675         aliases.  Call default_register_reggroup_p for all other
1676         pseudo-registers.
1677         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1678         New functions.
1679         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1680         Handle "vX" aliases.
1681         (v_alias_pseudo_register_collect): New function.
1682         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1683         (rs6000_gdbarch_init): Initialize "vX" aliases as
1684         pseudo-registers.  Restore registration of
1685         rs6000_pseudo_register_reggroup_p with
1686         set_tdesc_pseudo_register_reggroup_p.
1687
1688 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1689
1690         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1691         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1692         set_gdbarch_num_pseudo_regs.
1693
1694 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1695
1696         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1697         Remove arg prefixname, add do_set and do_show.
1698         Add member functions set_list and show_list.
1699         * cli/cli-style.c (class cli_style_option): Update accordingly.
1700         (style_set_list): Move to file scope.
1701         (style_show_list): Likewise.
1702         (set_style): Call help_list.
1703         (show_style): Call cmd_show_list.
1704         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1705         Update to use the new macro.
1706
1707 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1708
1709         * ada-lang.c (_initialize_ada_language): Expand the help text
1710         for the "catch exception" command.
1711
1712 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1713
1714         * symtab.c (matching_obj_sections): Initialize obj,
1715         declare it closer to its usage.
1716
1717 2019-01-10  Tom Tromey  <tom@tromey.com>
1718
1719         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1720         (basic_inf_threads_range): Remove.
1721         (inf_threads_range, inf_non_exited_threads_range)
1722         (safe_inf_threads_range): Use next_adapter.
1723
1724 2019-01-10  Keith Seitz  <keiths@redhat.com>
1725
1726         PR gdb/23712
1727         PR symtab/23010
1728         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1729         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1730
1731 2019-01-10  Keith Seitz  <keiths@redhat.com>
1732
1733         PR gdb/23712
1734         PR symtab/23010
1735         * dictionary.c (pending_to_vector): Remove.
1736         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1737         Remove _1 suffix, replacing functions of the same name.  Update
1738         all callers.
1739         (dict_create_hashed, dict_create_hashed_expandable)
1740         (dict_create_linear, dict_create_linear_expandable, dict_free)
1741         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1742         Make functions static.
1743
1744 2019-01-10  Keith Seitz  <keiths@redhat.com>
1745
1746         PR gdb/23712
1747         PR symtab/23010
1748         * dictionary.h (struct dictionary): Replace declaration with
1749         multidictionary.
1750         (dict_create_hashed, dict_create_hashed_expandable)
1751         (dict_create_linear, dict_create_linear_expandable)
1752         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1753         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1754         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1755         taking multidictionary argument.
1756         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1757         * block.h (struct block) <dict>: Change to multidictionary
1758         and rename `multidict'.
1759         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1760         symmisc.c: Update all dictionary references to multidictionary.
1761
1762 2019-01-10  Keith Seitz  <keiths@redhat.com>
1763
1764         PR gdb/23712
1765         PR symtab/23010
1766         * dictionary.c: Include unordered_map.
1767         (pending_to_vector): New function.
1768         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1769         Rewrite the non-"_1" functions to take vector instead
1770         of linked list.
1771         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1772         "new" _1 versions of the same name.
1773         (multidictionary): Define.
1774         (std::hash<enum language): New definition.
1775         (collate_pending_symbols_by_language, mdict_create_hashed)
1776         (mdict_create_hashed_expandable, mdict_create_linear)
1777         (mdict_create_linear_expandable, mdict_free)
1778         (find_language_dictionary, create_new_language_dictionary)
1779         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1780         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1781         (mdict_size, mdict_empty): New functions.
1782         * dictionary.h (mdict_iterator): Define.
1783
1784 2019-01-10  Pedro Alves  <palves@redhat.com>
1785
1786         * breakpoint.c (read_uploaded_action)
1787         (create_tracepoint_from_upload): Adjust to use
1788         gdb::unique_xmalloc_ptr.
1789         * ctf.c (ctf_write_uploaded_tp):
1790         (SET_ARRAY_FIELD): Use emplace_back.
1791         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1792         * tracefile-tfile.c (tfile_write_uploaded_tp):
1793         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1794         gdb::unique_xmalloc_ptr.
1795         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1796         at_string, cond_string, cmd_strings>: Replace char pointers
1797         with gdb::unique_xmalloc_ptr.
1798
1799 2019-01-10  Pedro Alves  <palves@redhat.com>
1800
1801         * solib-target.c (library_list_start_library): Don't xstrdup name.
1802
1803 2019-01-10  Pedro Alves  <palves@redhat.com>
1804
1805         * mdebugread.c (parse_partial_symbols): Use
1806         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1807
1808 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1809
1810         * linux-fork.c (scoped_switch_fork_info)
1811         <~scoped_switch_fork_info>: Fix incorrect variable name.
1812
1813 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1814
1815         * linux-fork.c (scoped_switch_fork_info)
1816         <scoped_switch_fork_info>: Make explicit.
1817         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1818
1819 2019-01-10  Tom Tromey  <tom@tromey.com>
1820
1821         * objfiles.h (objfile::reset_psymtabs): Update.
1822         * objfiles.c (objfile::objfile): Update.
1823         * psymtab.h (psymtab_storage::obstack): Update.
1824         (psymtab_storage::m_obstack): Use gdb::optional.
1825         (class psymtab_storage): Update comment.  Remove objfile
1826         parameter.
1827         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1828
1829 2019-01-10  Tom Tromey  <tom@tromey.com>
1830
1831         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1832         <free_psymtabs>: Now private.
1833         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1834         (allocate_psymtab): Use new method.
1835
1836 2019-01-10  Tom Tromey  <tom@tromey.com>
1837
1838         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1839         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1840         * mdebugread.c (parse_partial_symbols): Use
1841         allocate_dependencies.
1842         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1843         allocate_dependencies.
1844         (process_psymtab_comp_unit_reader)
1845         (build_type_psymtab_dependencies): Likewise.
1846         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1847
1848 2019-01-10  Tom Tromey  <tom@tromey.com>
1849
1850         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1851         PSYMBOL_SET_LANGUAGE.
1852         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1853
1854 2019-01-10  Tom Tromey  <tom@tromey.com>
1855
1856         * psymtab.h (psymtab_storage::obstack): New method.
1857         <m_obstack>: Rename from obstack; now private.
1858         * psymtab.c (psymtab_storage): Update.
1859         * dwarf2read.c (create_addrmap_from_index)
1860         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1861         Update.
1862
1863 2019-01-10  Tom Tromey  <tom@tromey.com>
1864
1865         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1866         * objfiles.h (objfile::reset_psymtabs): New method.
1867
1868 2019-01-10  Tom Tromey  <tom@tromey.com>
1869
1870         * symmisc.c (print_symbol_bcache_statistics): Update.
1871         (print_objfile_statistics): Update.
1872         * symfile.c (reread_symbols): Update.
1873         * psymtab.h (class psymtab_storage): New.
1874         * psymtab.c (psymtab_storage): New constructor.
1875         (~psymtab_storage): New destructor.
1876         (require_partial_symbols): Update.
1877         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1878         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1879         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1880         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1881         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1882         (start_psymtab_common, end_psymtab_common)
1883         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1884         (allocate_psymtab): Update.
1885         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1886         Update.
1887         (dump_psymtab_addrmap, maintenance_print_psymbols)
1888         (maintenance_check_psymtabs): Update.
1889         (class objfile_psymtabs): Move to objfiles.h.
1890         * psympriv.h (discard_psymtab): Now inline.
1891         (psymtab_discarder::psymtab_discarder): Update.
1892         (psymtab_discarder::~psymtab_discarder): Update.
1893         (ALL_OBJFILE_PSYMTABS): Rewrite.
1894         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1895         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1896         Remove fields.
1897         <partial_symtabs>: New field.
1898         (class objfile_psymtabs): Move from psymtab.h.  Update.
1899         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1900         psymbol_cache.
1901         (objfile::~objfile): Don't destroy psymbol_cache.
1902         * mdebugread.c (parse_partial_symbols): Update.
1903         * dwarf2read.c (create_addrmap_from_index)
1904         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1905         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1906         (add_partial_subprogram, dwarf2_ranges_read): Update.
1907         * dwarf-index-write.c (write_address_map)
1908         (write_one_signatured_type, recursively_write_psymbols)
1909         (class debug_names, class debug_names, write_psymtabs_to_index):
1910         Update.
1911
1912 2019-01-10  Tom Tromey  <tom@tromey.com>
1913
1914         * symtab.h (SYMBOL_SET_NAMES): Update.
1915         (symbol_set_names): Update.
1916         (MSYMBOL_SET_NAMES): Update.
1917         * symtab.c (symbol_set_names): Change argument to be an
1918         objfile_per_bfd_storage.
1919         * psymtab.c (add_psymbol_to_bcache): Update.
1920         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1921
1922 2019-01-10  Tom Tromey  <tom@tromey.com>
1923
1924         * symtab.c (create_demangled_names_hash): Change argument to be an
1925         objfile_per_bfd_storage.
1926         (symbol_set_names): Update.
1927
1928 2019-01-10  Tom Tromey  <tom@tromey.com>
1929
1930         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1931         init_psymbol_list.
1932         * psymtab.c (init_psymbol_list): Do nothing if already called.
1933         * psympriv.h (init_psymbol_list): Add comment.
1934         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1935         init_psymbol_list.
1936         * dbxread.c (dbx_symfile_read): Unconditionally call
1937         init_psymbol_list.
1938
1939 2019-01-10  Tom Tromey  <tom@tromey.com>
1940
1941         * xcoffread.c (scan_xcoff_symtab): Update.
1942         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1943         "where".
1944         * mdebugread.c (parse_partial_symbols)
1945         (handle_psymbol_enumerators): Update.
1946         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1947         * dbxread.c (read_dbx_symtab): Update.
1948         * psympriv.h (psymbol_placement): New enum.
1949         (add_psymbol_to_list): Update.
1950
1951 2019-01-10  Tom Tromey  <tom@tromey.com>
1952
1953         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1954         static_psymbols parameters.
1955         (scan_xcoff_symtab): Update.
1956         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1957         static_psymbols parameters.
1958         * psympriv.h (start_psymtab_common): Update.
1959         * mdebugread.c (parse_partial_symbols): Update.
1960         * dwarf2read.c (create_partial_symtab): Update.
1961         * dbxread.c (read_dbx_symtab): Update.
1962         (start_psymtab): Remove global_psymbols and static_psymbols
1963         parameters.
1964
1965 2019-01-10  Tom Tromey  <tom@tromey.com>
1966
1967         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1968         * psymtab.c (allocate_psymtab): Add comment.
1969         * psympriv.h (allocate_psymtab): Add comment.
1970         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1971         initializations.
1972         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1973
1974 2019-01-10  Tom Tromey  <tom@tromey.com>
1975
1976         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1977         Don't declare.
1978         * mipsread.c: Include mdebugread.h.
1979         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1980         Declare.
1981         * elfread.c: Include mdebugread.h.
1982
1983 2019-01-09  Tom Tromey  <tom@tromey.com>
1984
1985         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1986         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1987         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1988         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1989         (psym_lookup_symbol, psym_find_last_source_symtab)
1990         (psym_forget_cached_source_info, psym_print_stats)
1991         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1992         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1993         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1994         (psym_find_compunit_symtab_by_address)
1995         (maintenance_print_psymbols, maintenance_info_psymtabs)
1996         (maintenance_check_psymtabs): Use ranged for.
1997         * psymtab.h (class objfile_psymtabs): New.
1998         (require_partial_symbols): Return objfile_psymtabs.
1999         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2000
2001 2019-01-09  Tom Tromey  <tom@tromey.com>
2002
2003         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2004         (find_pc_mapped_section, list_overlays_command)
2005         (map_overlay_command, unmap_overlay_command)
2006         (simple_overlay_update): Use all_objfiles.
2007         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2008         * printcmd.c (info_symbol_command): Use all_objfiles.
2009         * objfiles.h (ALL_OBJSECTIONS): Remove.
2010         * maint.c (maintenance_translate_address): Use all_objfiles.
2011         * gcore.c (gcore_create_callback): Use all_objfiles.
2012         (objfile_find_memory_regions): Likewise.
2013
2014 2019-01-09  Tom Tromey  <tom@tromey.com>
2015
2016         * symtab.c (find_line_symtab, info_sources_command)
2017         (make_source_files_completion_list): Use objfile_compunits.
2018         * source.c (select_source_symtab): Use objfile_compunits.
2019         * objfiles.h (struct objfile): Update comment.
2020         (ALL_OBJFILES): Remove.
2021         (ALL_FILETABS): Remove.
2022         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2023         objfile_compunits.
2024
2025 2019-01-09  Tom Tromey  <tom@tromey.com>
2026
2027         * symmisc.c (print_objfile_statistics, dump_objfile)
2028         (maintenance_print_symbols): Use compunit_filetabs.
2029         * source.c (forget_cached_source_info_for_objfile): Use
2030         compunit_filetabs.
2031         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2032         (ALL_FILETABS): Use compunit_filetabs.
2033         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2034         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2035
2036 2019-01-09  Tom Tromey  <tom@tromey.com>
2037
2038         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2039         (compunit_filetabs): New.
2040         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2041         compunit_filetabs.
2042         (info_sources_command, make_source_files_completion_list): Remove
2043         declaration.
2044         * symmisc.c (print_objfile_statistics, dump_objfile)
2045         (maintenance_print_symbols): Remove declaration.
2046         (maintenance_info_symtabs): Use compunit_filetabs.
2047         (maintenance_info_line_tables): Likewise.
2048         * source.c (select_source_symtab): Change local variable name.
2049         (forget_cached_source_info_for_objfile): Remove declaration.
2050         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2051         * objfiles.c (objfile_relocate1): Remove declaration.
2052         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2053         declaration.
2054         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2055         * coffread.c (coff_symtab_read): Remove declaration.
2056         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2057         compunit_filetabs.
2058
2059 2019-01-09  Tom Tromey  <tom@tromey.com>
2060
2061         * symtab.c (lookup_objfile_from_block)
2062         (find_pc_sect_compunit_symtab, search_symbols)
2063         (default_collect_symbol_completion_matches_break_on): Use
2064         objfile_compunits.
2065         * objfiles.h (ALL_COMPUNITS): Remove.
2066         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2067         * cp-support.c (add_symbol_overload_list_qualified): Use
2068         objfile_compunits.
2069         * ada-lang.c (ada_collect_symbol_completion_matches)
2070         (ada_add_global_exceptions): Use objfile_compunits.
2071
2072 2019-01-09  Tom Tromey  <tom@tromey.com>
2073
2074         * source.c (select_source_symtab)
2075         (forget_cached_source_info_for_objfile): Remove declaration.
2076         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2077         declaration.
2078         * maint.c (count_symtabs_and_blocks): Remove declaration.
2079         * cp-support.c (add_symbol_overload_list_qualified): Remove
2080         declaration.
2081         * coffread.c (coff_symtab_read): Remove declaration.
2082         * symtab.c (lookup_symbol_in_objfile_symtabs)
2083         (basic_lookup_transparent_type_1): Use objfile_compunits.
2084         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2085         (info_sources_command, search_symbols)
2086         (default_collect_symbol_completion_matches_break_on)
2087         (make_source_files_completion_list): Remove declaration.
2088         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2089         (ada_collect_symbol_completion_matches)
2090         (ada_add_global_exceptions): Remove declaration.
2091         * linespec.c (iterate_over_all_matching_symtabs): Use
2092         objfile_compunits.
2093         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2094         (class objfile_compunits): New.
2095         (ALL_COMPUNITS): Use objfile_compunits.
2096         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2097         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2098         objfile_compunits.
2099         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2100
2101 2019-01-09  Tom Tromey  <tom@tromey.com>
2102
2103         * symtab.c (search_symbols)
2104         (default_collect_symbol_completion_matches_break_on): Use
2105         objfile_msymbols.
2106         * ada-lang.c (ada_lookup_simple_minsym)
2107         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2108         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2109         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2110         objfile_msymbols.
2111         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2112         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2113         * objc-lang.c (find_methods): Use objfile_msymbols.
2114         (info_selectors_command, info_classes_command): Likewise.
2115         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2116         * objfiles.h (class objfile_msymbols): New.
2117         (ALL_OBJFILE_MSYMBOLS): Remove.
2118         (ALL_MSYMBOLS): Remove.
2119
2120 2019-01-09  Tom Tromey  <tom@tromey.com>
2121
2122         * common/next-iterator.h (next_adapter): Add Iterator template
2123         parameter.
2124         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2125         (class all_objfiles_safe): New.
2126         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2127         * objfiles.c (put_objfile_before): Update comment.
2128         (add_separate_debug_objfile): Likewise.
2129         (free_all_objfiles): Use all_objfiles_safe.
2130         (objfile_purge_solibs): Likewise.
2131
2132 2019-01-09  Tom Tromey  <tom@tromey.com>
2133
2134         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2135         (expand_symtab_containing_pc, lookup_static_symbol)
2136         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2137         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2138         all_objfiles.
2139         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2140         * breakpoint.c (create_overlay_event_breakpoint)
2141         (create_longjmp_master_breakpoint)
2142         (create_std_terminate_master_breakpoint)
2143         (create_exception_master_breakpoint): Use all_objfiles.
2144         * linux-thread-db.c (try_thread_db_load_from_pdir)
2145         (has_libpthread): Use all_objfiles.
2146         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2147         * linespec.c (iterate_over_all_matching_symtabs)
2148         (search_minsyms_for_name): Use all_objfiles.
2149         * maint.c (maintenance_info_sections): Use all_objfiles.
2150         * main.c (captured_main_1): Use all_objfiles.
2151         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2152         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2153         * guile/scm-pretty-print.c
2154         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2155         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2156         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2157         (maintenance_print_msymbols): Use all_objfiles.
2158         * source.c (select_source_symtab): Use all_objfiles.
2159         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2160         * symfile.c (remove_symbol_file_command)
2161         (expand_symtabs_matching, map_symbol_filenames): Use
2162         all_objfiles.
2163         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2164         all_objfiles.
2165         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2166         * objc-lang.c (find_methods): Use all_objfiles.
2167         * objfiles.c (have_partial_symbols, have_full_symbols)
2168         (have_minimal_symbols, qsort_cmp)
2169         (default_iterate_over_objfiles_in_search_order): Use
2170         all_objfiles.
2171         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2172         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2173         (maintenance_check_psymtabs): Use all_objfiles.
2174         (ALL_PSYMTABS): Remove.
2175         * compile/compile-object-run.c (do_module_cleanup): Use
2176         all_objfiles.
2177         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2178         * cp-support.c (add_symbol_overload_list_qualified): Use
2179         all_objfiles.
2180         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2181         Use all_objfiles.
2182         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2183         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2184         all_objfiles.
2185         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2186         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2187         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2188         Uses all_objfiles.
2189         * solib.c (solib_read_symbols): Use all_objfiles
2190
2191 2019-01-09  Tom Tromey  <tom@tromey.com>
2192
2193         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2194         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2195         all_objfiles.
2196         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2197         * symmisc.c (print_symbol_bcache_statistics)
2198         (print_objfile_statistics, maintenance_print_objfiles)
2199         (maintenance_info_symtabs, maintenance_check_symtabs)
2200         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2201         all_objfiles.
2202         * source.c (forget_cached_source_info): Use all_objfiles.
2203         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2204         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2205         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2206         * objfiles.c (update_section_map): Use all_objfiles.
2207         (shared_objfile_contains_address_p): Likewise.
2208         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2209         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2210
2211 2019-01-09  Tom Tromey  <tom@tromey.com>
2212
2213         * common/next-iterator.h: New file.
2214         * objfiles.h (class all_objfiles): New.
2215         (struct objfile_iterator): New.
2216
2217 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2218
2219         * NEWS: Move the description of the changed "frame", "select-frame",
2220          and "info frame" commands to the Changed commands section.
2221
2222 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2223
2224         * gdbtypes.c (check_stub_method_group): Remove handling of old
2225         mangling schemes.
2226         * linespec.c (find_methods): Likewise.
2227         * stabsread.c (read_member_functions): Likewise.
2228         * valops.c (search_struct_method): Likewise.
2229         (value_struct_elt_for_reference): Likewise.
2230         * NEWS: Mention this change.
2231
2232 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2233
2234         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2235         print_source_lines.
2236         * source.c (print_source_lines_base): Update line number check.
2237         (print_source_lines): New function.
2238         (source_lines_range::source_lines_range): New function.
2239         * source.h (class source_lines_range): New class.
2240         (print_source_lines): New declaration.
2241
2242 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2243
2244         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2245
2246 2019-01-08  Tom Tromey  <tom@tromey.com>
2247             Simon Marchi  <simon.marchi@ericsson.com>
2248
2249         PR gdb/24060
2250         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2251         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2252         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2253         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2254         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2255         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2256
2257 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2258
2259         * source.c (select_source_symtab): Move header comment to
2260         declaration in source.h.
2261         (forget_cached_source_info_for_objfile): Likewise.
2262         (forget_cached_source_info): Likewise.
2263         (identify_source_line): Likewise.
2264         * source.h (identify_source_line): Move declaration from symtab.h
2265         and add comment from source.c
2266         (print_source_lines): Likewise.
2267         (forget_cached_source_info_for_objfile): Likewise.
2268         (forget_cached_source_info): Likewise.
2269         (select_source_symtab): Likewise.
2270         (enum print_source_lines_flag): Move definition from symtab.h.
2271         * symtab.h (identify_source_line): Move declaration to source.h.
2272         (print_source_lines): Likewise.
2273         (forget_cached_source_info_for_objfile): Likewise.
2274         (forget_cached_source_info): Likewise.
2275         (select_source_symtab): Likewise.
2276         (enum print_source_lines_flag): Move definition to source.h.
2277         * tui/tui-hooks.c: Add 'source.h' include.
2278
2279 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2280
2281         * source.c (print_source_lines_base): Handle requests to print
2282         reverse line number sequences, and guard against empty lines
2283         string.
2284
2285 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2286
2287         * source.c (print_source_lines_base): Fix skip of '\r' if next
2288         character is '\n'.
2289
2290 2019-01-06  Tom Tromey  <tom@tromey.com>
2291
2292         * c-exp.y (struct c_parse_state) <macro_original_text,
2293         expansion_obstack>: New member.
2294         (macro_original_text, expansion_obstack): Remove globals.
2295         (scan_macro_expansion, scanning_macro_expansion)
2296         (finished_macro_expansion): Update.
2297         (scan_macro_cleanup): Remove.
2298         (yylex, c_parse): Update.
2299
2300 2019-01-06  Tom Tromey  <tom@tromey.com>
2301
2302         * c-exp.y (struct c_parse_state) <strings>: New member.
2303         (operator_stoken): Update.
2304
2305 2019-01-06  Tom Tromey  <tom@tromey.com>
2306
2307         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2308         (union type_stack_elt) <typelist_val>: Now a pointer to
2309         std::vector.
2310         (type_stack_cleanup): Don't declare.
2311         (push_typelist): Update.
2312         * parse.c (pop_typelist): Return a std::vector.
2313         (push_typelist): Take a std::vector.
2314         (follow_types): Update.  Do not free args.
2315         (type_stack_cleanup): Remove.
2316         * c-exp.y (struct c_parse_state): New.
2317         (cpstate): New global.
2318         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2319         (nonempty_typelist): Update.
2320         (func_mod): Create a new vector.
2321         (c_parse): Create a c_parse_state.
2322         (check_parameter_typelist): Do not delete params.
2323         (function_method): Update.  Do not delete type_list.
2324
2325 2019-01-06  Tom Tromey  <tom@tromey.com>
2326
2327         PR gdb/28155:
2328         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2329         check_typedef.
2330         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2331         (print_return_value): Likewise.
2332
2333 2019-01-05  Tom Tromey  <tom@tromey.com>
2334
2335         * contrib/cleanup_check.py: Remove.
2336         * contrib/gcc-with-excheck: Remove.
2337         * contrib/exsummary.py: Remove.
2338         * contrib/excheck.py: Remove.
2339
2340 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2341
2342         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2343         NULL. Initialize tpprev to NULL instead of assigning it
2344         to NULL on the next statement.
2345         * windows-nat.c (windows_delete_thread): Remove check for
2346         main_thread_id before printing thread exit notifications.
2347         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2348         Remove thread ID check against main_thread_id.
2349         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2350         windows_delete_thread.
2351         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2352
2353 2019-01-04  Tom Tromey  <tom@tromey.com>
2354
2355         * compile/compile.c (_initialize_compile): Use upper case for
2356         metasyntactic variables.
2357         * symmisc.c (_initialize_symmisc): Use upper case for
2358         metasyntactic variables.
2359         * psymtab.c (_initialize_psymtab): Use upper case for
2360         metasyntactic variables.
2361         * demangle.c (demangle_command): Use upper case for metasyntactic
2362         variables.
2363         (_initialize_demangler): Likewise.
2364         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2365         variables.
2366
2367 2019-01-03  Tom Tromey  <tom@tromey.com>
2368
2369         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2370
2371 2019-01-03  Tom Tromey  <tom@tromey.com>
2372
2373         * python/py-symtab.c (salpy_str): Update.
2374         (struct salpy_sal_object) <symtab>: Now a PyObject.
2375         (salpy_dealloc): Update.
2376         (del_objfile_sal): Use gdbpy_ref.
2377
2378 2019-01-03  Tom Tromey  <tom@tromey.com>
2379
2380         * python/py-type.c (convert_field): Use new_reference.  Return
2381         gdbpy_ref.
2382         (make_fielditem): Return gdbpy_ref.
2383         (typy_fields): Update.
2384         (typy_getitem): Update.
2385         (field_name): Return gdbpy_ref.  Use new_reference.
2386         (typy_iterator_iternext): Update.
2387
2388 2019-01-03  Tom Tromey  <tom@tromey.com>
2389
2390         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2391
2392 2019-01-03  Tom Tromey  <tom@tromey.com>
2393
2394         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2395         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2396         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2397         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2398         (pspy_set_type_printers): Likewise.
2399         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2400         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2401         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2402         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2403         (objfpy_set_type_printers): Likewise.
2404
2405 2019-01-03  Tom Tromey  <tom@tromey.com>
2406
2407         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2408         (gdbpy_print_stack): Use gdbpy_err_fetch.
2409         * python/python-internal.h (class gdbpy_err_fetch): New class.
2410         (class gdbpy_enter) <m_error_type, m_error_value,
2411         m_error_traceback>: Remove.
2412         <m_error>: New member.
2413         (gdbpy_exception_to_string): Don't declare.
2414         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2415         * python/py-value.c (convert_value_from_python): Use
2416         gdbpy_err_fetch.
2417         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2418         gdbpy_exception_to_string.
2419         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2420         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2421         gdbpy_err_fetch.
2422
2423 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2424
2425         * linux-nat.c (delete_lwp_cleanup): Delete.
2426         (struct lwp_deleter): New struct.
2427         (lwp_info_up): New typedef.
2428         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2429         lwp_info_up.
2430
2431 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2432
2433         * linux-fork.c (class scoped_switch_fork_info): New class.
2434         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2435
2436 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2437
2438         * valops.c (find_overload_match): Remove use of null_cleanup, and
2439         calls to do_cleanups.
2440
2441 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2442
2443         * compile/compile-cplus-types.c
2444         (compile_cplus_instance::decl_name): Handle changes to
2445         cp_func_name.
2446         * cp-support.c (cp_func_name): Update header comment, update
2447         return type.
2448         * cp-support.h (cp_func_name): Update return type in declaration.
2449         * valops.c (find_overload_match): Move temp_func local to top
2450         level of function and change its type.  Use temp_func to hold and
2451         delete temporary string obtained from cp_func_name.
2452
2453 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2454
2455         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2456         gdb::char_vector, remove cleanup, and update uses of `msg`.
2457
2458 2019-01-03  Jim Wilson  <jimw@sifive.com>
2459
2460         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2461
2462 2019-01-02  Tom Tromey  <tom@tromey.com>
2463
2464         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2465         (tdesc_parse_xml): Remove cleanups.
2466         * target-descriptions.h (make_cleanup_free_target_description):
2467         Don't declare.
2468         (target_desc_deleter): New struct.
2469         (target_desc_up): New typedef.
2470         * target-descriptions.c (target_desc_deleter::operator()): Rename
2471         from free_target_description.
2472         (make_cleanup_free_target_description): Remove.
2473
2474 2019-01-02  Tom Tromey  <tom@tromey.com>
2475
2476         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2477         constructor, destructor.
2478         (linespec_parser): Remove typedef.
2479         (~linespec_parser): Rename from linespec_parser_delete.
2480         (linespec_lex_to_end, linespec_complete_label)
2481         (linespec_complete): Update.
2482         (decode_line_full): Remove cleanups.
2483         (decode_line_1): Update.
2484
2485 2019-01-02  Tom Tromey  <tom@tromey.com>
2486
2487         * python/python-internal.h (inferior_to_inferior_object): Change
2488         return type.
2489         * python/py-exitedevent.c (create_exited_event_object): Update.
2490         * python/py-inferior.c (inferior_to_inferior_object): Return
2491         gdbpy_ref.
2492         (python_new_inferior, python_inferior_deleted)
2493         (thread_to_thread_object, delete_thread_object)
2494         (build_inferior_list, gdbpy_selected_inferior): Update.
2495         * python/py-infthread.c (create_thread_object): Update.  Also fail
2496         if inferior_to_inferior_object fails.
2497
2498 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2499
2500         * inferior.h (class inferior) <displaced_step_state>: New field.
2501         * infrun.h (struct displaced_step_state): Move here from
2502         infrun.c.  Initialize fields, add constructor.
2503         <inf>: Remove field.
2504         <reset>: New method.
2505         * infrun.c (struct displaced_step_inferior_state): Move to
2506         infrun.h.
2507         (displaced_step_inferior_states): Remove.
2508         (get_displaced_stepping_state): Adust.
2509         (displaced_step_in_progress_any_inferior): Adjust.
2510         (displaced_step_in_progress_thread): Adjust.
2511         (displaced_step_in_progress): Adjust.
2512         (add_displaced_stepping_state): Remove.
2513         (get_displaced_step_closure_by_addr): Adjust.
2514         (remove_displaced_stepping_state): Remove.
2515         (infrun_inferior_exit): Call displaced_step_state.reset.
2516         (use_displaced_stepping): Don't check for NULL.
2517         (displaced_step_prepare_throw): Call
2518         get_displaced_stepping_state.
2519         (displaced_step_fixup): Don't check for NULL.
2520         (prepare_for_detach): Don't check for NULL.
2521
2522 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2523
2524         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2525          in case of call that did not complete.
2526
2527 2019-01-02  Andrey Utkin  <autkin@undo.io>
2528
2529         * symfile.c (find_separate_debug_file): Fix search of debug files for
2530         remote debuggee.
2531
2532 2019-01-02  Tom Tromey  <tom@tromey.com>
2533
2534         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2535         indentation.
2536         * python/py-frame.c (frapy_older): Remove cast.
2537         (frapy_newer): Likewise.
2538         * python/py-breakpoint.c (local_setattro): Remove cast.
2539         * python/py-arch.c (archpy_name): Remove local variable.
2540         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2541
2542 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2543
2544         * unittests/basic_string_view/element_access/char/empty.cc:
2545         Fix year range in copyright header.
2546
2547 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2548
2549         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2550         Delete.
2551         <operator==>: Update with for removed field.
2552         <hash>: Likewise.
2553         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2554         <isa_features>: ...this.
2555         <abi_features>: New field.
2556         (riscv_isa_flen): Update comment.
2557         (riscv_abi_xlen): New declaration.
2558         (riscv_abi_flen): New declaration.
2559         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2560         isa_features.
2561         (riscv_abi_xlen): New function.
2562         (riscv_isa_flen): Update to get answer from isa_features.
2563         (riscv_abi_flen): New function.
2564         (riscv_has_fp_abi): Update to get answer from abi_features.
2565         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2566         xlen and flen.
2567         (riscv_call_info) <xlen, flen>: Update comment.
2568         (riscv_call_arg_struct): Remove invalid assertions
2569         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2570         is removed.
2571         (riscv_gdbarch_init): Gather isa features and abi features
2572         separately, ensure both match on the gdbarch when reusing an old
2573         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2574         a target with 64-bit float hardware.
2575
2576 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2577
2578         * source.c (search_command_helper): Stop reverse search
2579         when line 1 has been searched.
2580
2581 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2582
2583         * record-full.c (record_full_base_target::close): Rewrite
2584         record_full_core_buf_list free logic.
2585
2586 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2587
2588         * break-catch-syscall.c (print_one_catch_syscall): xfree
2589         the last text.
2590
2591 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2592
2593         * top.c (print_gdb_version): Update Copyright year in version
2594         message.
2595
2596 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2597
2598         Update copyright year range in all GDB files.
2599
2600 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2601
2602         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2603
2604 For older changes see ChangeLog-2018.
2605 \f
2606 Local Variables:
2607 mode: change-log
2608 left-margin: 8
2609 fill-column: 74
2610 version-control: never
2611 coding: utf-8
2612 End:
2613