gdb/ChangeLog

   1 2019-04-04  Tom Tromey  <tom@tromey.com>
   2
   3         * rust-exp.y: Replace "parse_language" with method call.
   4         * p-exp.y:
   5         (yylex): Replace "parse_language" with method call.
   6         * m2-exp.y:
   7         (yylex): Replace "parse_language" with method call.
   8         * go-exp.y (classify_name): Replace "parse_language" with method
   9         call.
  10         * f-exp.y (yylex): Replace "parse_language" with method call.
  11         * d-exp.y (lex_one_token): Replace "parse_language" with method
  12         call.
  13         * c-exp.y:
  14         (lex_one_token, classify_name, yylex): Replace "parse_language"
  15         with method call.
  16         * ada-exp.y (find_primitive_type, type_char)
  17         (type_system_address): Replace "parse_language" with method call.
  18
  19 2019-04-04  Tom Tromey  <tom@tromey.com>
  20
  21         * rust-exp.y: Replace "parse_gdbarch" with method call.
  22         * parse.c (write_dollar_variable, insert_type_address_space):
  23         Replace "parse_gdbarch" with method call.
  24         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
  25         call.
  26         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
  27         call.
  28         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
  29         "parse_gdbarch" with method call.
  30         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
  31         with method call.
  32         * f-exp.y (parse_type, parse_f_type, yylex): Replace
  33         "parse_gdbarch" with method call.
  34         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
  35         "parse_gdbarch" with method call.
  36         * c-exp.y (parse_type, parse_number, classify_name): Replace
  37         "parse_gdbarch" with method call.
  38         * ada-lex.l: Replace "parse_gdbarch" with method call.
  39         * ada-exp.y (parse_type, find_primitive_type, type_char)
  40         (type_system_address): Replace "parse_gdbarch" with method call.
  41
  42 2019-04-04  Tom Tromey  <tom@tromey.com>
  43
  44         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
  45         * stap-probe.c (stap_parse_argument): Update.
  46         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
  47         initial_size parameter.
  48         * rust-exp.y (rust_lex_tests): Update.
  49         * parse.c (parser_state): Update.
  50         (parse_exp_in_context): Update.
  51         * parser-defs.h (struct parser_state) <parser_state>: Remove
  52         "initial_size" parameter.
  53
  54 2019-04-04  Tom Tromey  <tom@tromey.com>
  55
  56         * parser-defs.h (increase_expout_size): Don't declare.
  57         * parse.c (increase_expout_size): Now static.
  58
  59 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
  60
  61         * gnu-nat.c (gnu_nat_target::wait): Fix
  62         target_waitstatus_to_string call.
  63
  64 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
  65
  66         * eval.c (evaluate_subexp_standard): Handle internal functions
  67         during Fortran function call handling.
  68
  69 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
  70
  71         * NEWS: Mention new internal functions.
  72         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
  73         (read_base_type): Use dwarf2_init_complex_target_type.
  74         * value.c (creal_internal_fn): New function.
  75         (cimag_internal_fn): New function.
  76         (_initialize_values): Register new internal functions.
  77
  78 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  79
  80         * infrun.c (stop_all_threads): If debug_infrun, always
  81         trace the wait status after wait_one, using
  82         target_waitstatus_to_string and target_pid_to_str.
  83         (handle_inferior_event): Replace various trace of
  84         wait status kind by a single trace.
  85         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
  86         wait status kind image by target_waitstatus_to_string.
  87         * target/waitstatus.c (target_waitstatus_to_string): Fix
  88         obsolete comment.
  89
  90 2019-04-01  Tom Tromey  <tromey@adacore.com>
  91
  92         PR symtab/23331:
  93         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
  94
  95 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
  96             Pedro Alves  <palves@redhat.com>
  97
  98         * top.c (quit_force): Call 'finalize_values'.
  99         * value.c (finalize_values): New function.
 100         * value.h (finalize_values): Declare.
 101
 102 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
 103
 104         * NEWS: Announce $_gdb_major and $_gdb_minor.
 105
 106         * top.c (init_gdb_version_vars): New function.
 107         (gdb_init): Call init_gdb_version_vars.
 108
 109 2019-03-29  Tom Tromey  <tromey@adacore.com>
 110
 111         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
 112         help text.  Remove dead code.
 113
 114 2019-03-29  Keith Seitz  <keiths@redhat.com>
 115
 116         From Siddhesh Poyarekar:
 117         * f-lang.h (f77_get_upperbound): Return LONGEST.
 118         (f77_get_lowerbound): Likewise.
 119         * f-typeprint.c (f_type_print_varspec_suffix): Expand
 120         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
 121         print them.
 122         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
 123         plongest to format print it.
 124         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
 125         (f77_get_upperbound): Likewise.
 126         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
 127         LOWER_BOUND to LONGEST.
 128         (f77_create_arrayprint_offset_tbl): Likewise.
 129
 130 2019-03-29  Keith Seitz  <keiths@redhat.com>
 131
 132         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
 133         %s/pulongest for TYPE_LENGTH instead of %d in format
 134         strings.
 135         * ada-typerint.c (ada_print_type): Likewise.
 136         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
 137         * compile/compile-c-support.c (generate_register_struct): Likewise.
 138         * gdbtypes.c (recursive_dump_type): Likewise.
 139         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
 140         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
 141         instead of %d in format strings.
 142         * riscv-tdep.c (riscv_type_alignment): Cast second argument
 143         to std::min to ULONGEST.
 144         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
 145         instead of %d in format strings.
 146         * tracepoint.c (info_scope_command): Likewise.
 147         * typeprint.c (print_offset_data::update)
 148         (print_offset_data::finish): Likewise.
 149         * xtensa-tdep.c (xtensa_store_return_value)
 150         (xtensa_push_dummy_call): Likewise.
 151
 152 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
 153
 154         * windows-nat.c (display_selector): Fixed format specifications
 155         for 64-bit Cygwin.
 156
 157 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 158
 159         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
 160
 161 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
 162
 163         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
 164         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
 165         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
 166         (nios2_linux_init_abi): Install it.
 167
 168 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
 169
 170         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
 171
 172 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
 173
 174         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
 175
 176 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 177             Tom Tromey  <tromey@adacore.com>
 178
 179         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
 180
 181 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
 182
 183         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
 184         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
 185         method to compute the bounds of range types. Also print "[evaluated]"
 186         if the bounds' values come from a dynamic evaluation.
 187
 188 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 189
 190         * cp-valprint.c (cp_print_value_fields): Don't print trailing
 191         whitespace when pretty printing is on.
 192
 193 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 194
 195         * ppc-linux-nat.c: Add include.
 196
 197 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 198
 199         * NEWS: Mention AArch64 Pointer Authentication.
 200
 201 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 202
 203         * arm-linux-nat.c: Add include.
 204
 205 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
 206
 207         * source-cache.c (source_cache::get_source_lines): Re-read
 208         fullname after calling open_source_file.
 209
 210 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
 211
 212         * NEWS: Mention TLS support for FreeBSD.
 213
 214 2019-03-25  Tom Tromey  <tromey@adacore.com>
 215
 216         * minsyms.c (BUNCH_SIZE): Update comment.
 217         (~minimal_symbol_reader): Remove old comment.
 218         (compact_minimal_symbols): Update comment.
 219         (minimal_symbol_reader::install): Remove old comment.  Update
 220         other comments.
 221
 222 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 223
 224         * s390-linux-nat.c: Add include.
 225
 226 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 227
 228         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 229         Call linux_get_hwcap.
 230         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
 231         Likewise.
 232         (aarch64_linux_get_hwcap): Remove function.
 233         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
 234         declaration.
 235         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
 236         linux_get_hwcap.
 237         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 238         * linux-tdep.c (linux_get_hwcap): Add function.
 239         (linux_get_hwcap2): Likewise.
 240         * linux-tdep.h (linux_get_hwcap): Add declaration.
 241         (linux_get_hwcap2): Likewise.
 242         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
 243         (ppc_linux_get_hwcap2): Likewise.
 244         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
 245         linux_get_hwcap.
 246         (ppc_linux_nat_target::insert_watchpoint): Likewise.
 247         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
 248         (ppc_linux_nat_target::read_description): Likewise.
 249         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
 250         * s390-linux-nat.c: Likewise.
 251         * s390-linux-tdep.c (s390_core_read_description): Likewise.
 252
 253 2019-03-24  Tom Tromey  <tom@tromey.com>
 254
 255         * ada-lang.c (standard_lookup): Simplify initialization.
 256         (ada_lookup_symbol_nonlocal): Simplify return.
 257         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
 258         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
 259         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
 260         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
 261         initialization.
 262         * solib.c (solib_global_lookup): Simplify.
 263         * symtab.c (null_block_symbol): Remove.
 264         (symbol_cache_lookup): Simplify returns.
 265         (lookup_language_this): Simplify returns.
 266         (lookup_symbol_aux): Simplify return.
 267         (lookup_local_symbol): Simplify returns.
 268         (lookup_global_symbol_from_objfile): Simplify return.
 269         (lookup_symbol_in_objfile_symtabs)
 270         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
 271         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
 272         (lookup_static_symbol, lookup_global_symbol): Simplify return.
 273         * cp-namespace.c (cp_lookup_bare_symbol)
 274         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
 275         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
 276         (cp_lookup_nested_symbol): Don't use null_block_symbol.
 277         (cp_lookup_symbol_via_imports): Simplify initialization.
 278         (find_symbol_in_baseclass): Likewise.
 279         * symtab.h (null_block_symbol): Remove.
 280         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
 281         (d_lookup_nested_symbol, d_lookup_symbol_imports)
 282         (d_lookup_symbol_module): Likewise.
 283         (find_symbol_in_baseclass): Simplify initialization.
 284
 285 2019-03-24  Tom Tromey  <tom@tromey.com>
 286
 287         * expression.h: Don't include symtab.h.
 288         (struct block): Forward declare.
 289
 290 2019-03-24  Tom Tromey  <tom@tromey.com>
 291
 292         * c-exp.y (typebase): Remove casts.
 293         * gdbtypes.c (lookup_unsigned_typename, )
 294         (lookup_signed_typename): Remove cast.
 295         * eval.c (parse_to_comma_and_eval): Remove cast.
 296         * parse.c (write_dollar_variable): Remove cast.
 297         * block.h (struct block) <superblock>: Now const.
 298         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
 299         * psymtab.c (psym_map_matching_symbols): Make "block" const.
 300         (map_block): Make "block" const.
 301         * symfile.h (struct quick_symbol_functions)
 302         <map_matching_symbols>: Constify block argument to "callback".
 303         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
 304         const.
 305         (find_pc_sect_compunit_symtab): Make "b" const.
 306         (find_symbol_at_address): Likewise.
 307         (search_symbols): Likewise.
 308         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
 309         (dw2_debug_names_lookup_symbol): Likewise.
 310         (dw2_map_matching_symbols): Update.
 311         * p-valprint.c (pascal_val_print): Remove "block".
 312         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
 313         (aux_add_nonlocal_symbols): Make "block" const.
 314         (resolve_subexp): Remove cast.
 315         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
 316         const.
 317         (iterate_over_file_blocks): Likewise.
 318         * f-exp.y (%union) <bval>: Remove.
 319         * coffread.c (patch_opaque_types): Make "b" const.
 320         * spu-tdep.c (spu_catch_start): Make "block" const.
 321         * c-valprint.c (print_unpacked_pointer): Remove "block".
 322         * symmisc.c (dump_symtab_1): Make "b" const.
 323         (block_depth): Make "block" const.
 324         * d-exp.y (%union) <bval>: Remove.
 325         * cp-support.h (cp_lookup_rtti_type): Update.
 326         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
 327         * psymtab.c (psym_lookup_symbol): Make "block" const.
 328         (maintenance_check_psymtabs): Make "b" const.
 329         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
 330         (enumerate_locals, enumerate_args): Update.
 331         * python/py-symtab.c (stpy_global_block): Make "block" const.
 332         (stpy_static_block): Likewise.
 333         * inline-frame.c (block_starting_point_at): Make "new_block"
 334         const.
 335         * block.c (find_block_in_blockvector): Make return type const.
 336         (blockvector_for_pc_sect): Make "b" const.
 337         (find_block_in_blockvector): Make "b" const.
 338
 339 2019-03-23  Tom Tromey  <tom@tromey.com>
 340
 341         * varobj.c (varobj_create): Update.
 342         * symfile.c (clear_symtab_users): Don't reset innermost_block.
 343         * printcmd.c (display_command, do_one_display): Don't reset
 344         innermost_block.
 345         * parser-defs.h (enum innermost_block_tracker_type): Move to
 346         expression.h.
 347         (innermost_block): Update comment.
 348         * parse.c (parse_exp_1): Add tracker_types parameter.
 349         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
 350         tracker_types parameter.  Reset innermost_block.
 351         (parse_exp_in_context): Remove.
 352         (parse_expression_for_completion): Update.
 353         * objfiles.c (~objfile): Don't reset expression_context_block or
 354         innermost_block.
 355         * expression.h (enum innermost_block_tracker_type): Move from
 356         parser-defs.h.
 357         (parse_exp_1): Add tracker_types parameter.
 358         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
 359         reset innermost_block.
 360
 361 2019-03-23  Tom Tromey  <tom@tromey.com>
 362
 363         * objfiles.h: Include bcache.h.
 364
 365 2019-03-23  Tom Tromey  <tom@tromey.com>
 366
 367         * linespec.c (get_current_search_block): Use
 368         scoped_restore_current_language.
 369         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
 370
 371 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 372             Jiong Wang  <jiong.wang@arm.com>
 373
 374         * aarch64-linux-tdep.c
 375         (aarch64_linux_iterate_over_regset_sections): Check for pauth
 376         section.
 377         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
 378
 379 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 380             Jiong Wang  <jiong.wang@arm.com>
 381
 382         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
 383         instructions.
 384         (aarch64_analyze_prologue_test): Add PACIASP test.
 385         (aarch64_prologue_prev_register): Unmask PC value.
 386
 387 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 388             Jiong Wang  <jiong.wang@arm.com>
 389
 390         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
 391         (aarch64_dwarf2_prev_register): Unmask PC value.
 392         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
 393         (aarch64_execute_dwarf_cfa_vendor_op): Check for
 394         DW_CFA_AARCH64_negate_ra_state.
 395         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
 396
 397 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 398             Jiong Wang  <jiong.wang@arm.com>
 399
 400         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
 401         registers.
 402         (aarch64_pseudo_register_name): Likewise.
 403         (aarch64_pseudo_register_type): Likewise.
 404         (aarch64_pseudo_register_reggroup_p): Likewise.
 405         (aarch64_gdbarch_init): Add pauth registers.
 406         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
 407         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
 408         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
 409         (struct gdbarch_tdep): Add regnum for ra_state.
 410
 411 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 412             Jiong Wang  <jiong.wang@arm.com>
 413
 414         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
 415
 416 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 417             Jiong Wang  <jiong.wang@arm.com>
 418
 419         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
 420         function.
 421         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
 422         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
 423         (aarch64_gdbarch_init): Add puth registers.
 424         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
 425         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
 426         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
 427
 428 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 429             Jiong Wang  <jiong.wang@arm.com>
 430
 431         * aarch64-linux-nat.c
 432         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
 433         * aarch64-linux-tdep.c
 434         (aarch64_linux_core_read_description): Likewise.
 435         (aarch64_linux_get_hwcap): New function.
 436         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
 437         (aarch64_linux_get_hwcap): New declaration.
 438
 439 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 440             Jiong Wang  <jiong.wang@arm.com>
 441
 442         * aarch64-linux-nat.c
 443         (aarch64_linux_nat_target::read_description): Add pauth param.
 444         * aarch64-linux-tdep.c
 445         (aarch64_linux_core_read_description): Likewise.
 446         * aarch64-tdep.c (struct target_desc): Add in pauth.
 447         (aarch64_read_description): Add pauth param.
 448         (aarch64_gdbarch_init): Likewise.
 449         * aarch64-tdep.h (aarch64_read_description): Likewise.
 450         * arch/aarch64.c (aarch64_create_target_description): Likewise.
 451         * arch/aarch64.h (aarch64_create_target_description): Likewise.
 452         * features/Makefile: Add new files.
 453         * features/aarch64-pauth.c: New file.
 454         * features/aarch64-pauth.xml: New file.
 455
 456 2019-03-20  Tom Tromey  <tromey@adacore.com>
 457
 458         * infrun.c (handle_inferior_event): Rename from
 459         handle_inferior_event_1.  Create a scoped_value_mark.
 460         (handle_inferior_event): Remove.
 461
 462 2019-03-19  Tom Tromey  <tromey@adacore.com>
 463
 464         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
 465         * infrun.h (print_stop_event): Add "displays" parameter.
 466         * infrun.c (print_stop_event): Add "displays" parameter.
 467
 468 2019-03-19  Pedro Alves  <palves@redhat.com>
 469
 470         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
 471         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
 472         to -1.  Fix TABs vs spaces.
 473         (tui_ui_out::tui_ui_out): Don't initialize fields here.
 474         * tui/tui-out.h (tui_ui_out) Add intro comments.
 475         <m_line, m_start_of_line>: In-class initialize, and add describing
 476         comment.
 477
 478 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
 479
 480         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
 481         variable names.
 482         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
 483
 484 2019-03-18  Pedro Alves  <palves@redhat.com>
 485             Eli Zaretskii <eliz@gnu.org>
 486
 487         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 488         m_line and m_start_of_line.
 489
 490 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 491
 492         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 493         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 494         it returns a newline.  This fixes a regression in TU mode, whereby
 495         the next line is output on the same screen line as the user input.
 496
 497 2019-03-18  Tom Tromey  <tromey@adacore.com>
 498
 499         * minsyms.c (minimal_symbol_reader::install): Remove call to
 500         obstack_blank.
 501
 502 2019-03-18  Pedro Alves  <palves@redhat.com>
 503
 504         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 505         New globals.
 506         (apply_style): New, factored out from ...
 507         (apply_ansi_escape): ... this.  Handle reverse video mode.
 508         (tui_set_reverse_mode): New function.
 509         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 510         * tui/tui-winsource.c (tui_show_source_line): Use
 511         tui_set_reverse_mode instead of setting A_STANDOUT.
 512         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 513         New setter methods.
 514
 515 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 516
 517         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 518         Handle tabs.
 519
 520 2019-03-18  Tom Tromey  <tromey@adacore.com>
 521
 522         * ada-lang.c (empty_array): Add "high" parameter.
 523         (ada_evaluate_subexp): Update.
 524
 525 2019-03-17  Sergei Trofimovich <siarheit@google.com>
 526
 527         * unittests/string_view-selftests.c: Define
 528         _initialize_string_view_selftests unconditionally.
 529
 530 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 531
 532         PR gdb/24350
 533         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
 534
 535 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 536
 537         PR gdb/24351
 538         * windows-nat.c (display_selector): Fix format specifiers.
 539
 540 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 541
 542         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 543         tui_refill_source_window instead of tui_refresh_win, to update the
 544         current execution line.  This fixes redisplay of the current line
 545         when stepping through the code with "next" or "step".
 546
 547 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 548
 549         * source-cache.c (source_cache::get_source_lines): Call
 550         find_source_lines to initialize s->nlines.  This fixes vertical
 551         scrolling of TUI source window when the DOWN arrow is pressed.
 552
 553 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 554
 555         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
 556         linux-thread-db.c (_initialize_thread_db): Likewise.
 557
 558 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 559
 560         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 561         wclrtoeol in tui_show_source_line".  This reverts changes made in
 562         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 563
 564 2019-03-15  Tom Tromey  <tom@tromey.com>
 565
 566         * symtab.h (struct minimal_symbol): Derive from
 567         general_symbol_info.
 568         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
 569         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
 570         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
 571         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
 572         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
 573         (MSYMBOL_SEARCH_NAME): Update.
 574         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
 575         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
 576         * minsyms.c (minimal_symbol_reader::record_full): Update.
 577
 578 2019-03-15  Tom Tromey  <tom@tromey.com>
 579
 580         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
 581
 582 2019-03-15  Tom Tromey  <tom@tromey.com>
 583
 584         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 585         unique_xmalloc_ptr.
 586         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 587         Update.
 588         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 589         (build_minimal_symbol_hash_tables)
 590         (minimal_symbol_reader::install): Update.
 591
 592 2019-03-15  Tom Tromey  <tom@tromey.com>
 593
 594         * symtab.c (create_demangled_names_hash): Update.
 595         (symbol_set_names): Update.
 596         * objfiles.h (struct objfile_per_bfd_storage)
 597         <demangled_names_hash>: Now an htab_up.
 598         * objfiles.c (objfile_per_bfd_storage): Simplify.
 599
 600 2019-03-15  Tom Tromey  <tom@tromey.com>
 601
 602         * objfiles.h (struct objfile_per_bfd_storage): Declare
 603         destructor.
 604         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 605         New.
 606         (get_objfile_bfd_data): Use new.  Don't initialize
 607         language_of_main.
 608         (free_objfile_per_bfd_storage): Remove.
 609         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 610
 611 2019-03-15  Tom Tromey  <tom@tromey.com>
 612
 613         * symfile.c (reread_symbols): Update.
 614         * objfiles.c (objfile::objfile): Update.
 615         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 616         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 617         comment.
 618         (minimal_symbol_reader::install): Update.
 619         (terminate_minimal_symbol_table): Remove.
 620         * jit.c (jit_object_close_impl): Update.
 621
 622 2019-03-15  Tom Tromey  <tom@tromey.com>
 623
 624         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 625         initializations.
 626
 627 2019-03-15  Tom Tromey  <tom@tromey.com>
 628
 629         * objfiles.h (struct objfile_per_bfd_storage)
 630         <demangled_hash_languages>: Now a bitset.
 631         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 632         (lookup_minimal_symbol): Update.
 633
 634 2019-03-15  Tom Tromey  <tom@tromey.com>
 635
 636         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 637         Don't return the symbol.
 638         * coffread.c (record_minimal_symbol): Use record_full.
 639
 640 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 641
 642         The MS-Windows port of ncurses fails to switch to a color pair if
 643         one or both of the colors are the implicit default colors.  This
 644         change records the default colors when TUI is initialized, and
 645         then specifies them explicitly when a color pair uses the default
 646         colors.  This allows color styling in TUI mode on MS-Windows.
 647
 648         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 649         ncurses_norm_attr.
 650         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 651         colors in ncurses_norm_attr.
 652         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 653         "none", replace it with the default color recorded in
 654         ncurses_norm_attr.
 655
 656 2019-03-14  Tom Tromey  <tromey@adacore.com>
 657
 658         * source-cache.h (class source_cache) <get_source_lines>: Return
 659         std::string.
 660         * source-cache.c (source_cache::extract_lines): Handle case where
 661         first_pos==npos.  Return std::string.
 662         (source_cache::get_source_lines): Update.
 663
 664 2019-03-14  Tom Tromey  <tromey@adacore.com>
 665
 666         * NEWS: Add item for "style sources" commands.
 667         * source-cache.c (source_cache::get_source_lines): Check
 668         source_styling.
 669         * cli/cli-style.c (source_styling): New global.
 670         (_initialize_cli_style): Add "style sources" commands.
 671         (show_style_sources): New function.
 672         * cli/cli-style.h (source_styling): Declare.
 673
 674 2019-03-14  Pedro Alves  <palves@redhat.com>
 675             Tom Tromey  <tromey@adacore.com>
 676
 677         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 678         * tui/tui-winsource.c (tui_refill_source_window): New function,
 679         from...
 680         (tui_horizontal_source_scroll): ... here.  Move some logic.
 681         * cli/cli-style.c (set_style_enabled): Notify new observable.
 682         * tui/tui-hooks.c (tui_redisplay_source): New function.
 683         (tui_attach_detach_observers): Attach or detach
 684         tui_redisplay_source.
 685         * observable.h (source_styling_changed): New observable.
 686         * observable.c: Define source_styling_changed observable.
 687
 688 2019-03-13  Tom Tromey  <tromey@adacore.com>
 689
 690         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 691         (i386_gnu_nat_target::store_registers): Update.
 692         * target-debug.h (target_debug_print_std_string): New macro.
 693         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 694         * windows-tdep.c (display_one_tib): Update.
 695         * tui/tui-stack.c (tui_make_status_line): Update.
 696         * top.c (print_inferior_quit_action): Update.
 697         * thread.c (thr_try_catch_cmd): Update.
 698         (add_thread_with_info): Update.
 699         (thread_target_id_str): Update.
 700         (thr_try_catch_cmd): Update.
 701         (thread_command): Update.
 702         (thread_find_command): Update.
 703         * record-btrace.c (record_btrace_target::info_record)
 704         (record_btrace_resume_thread, record_btrace_target::resume)
 705         (record_btrace_cancel_resume, record_btrace_step_thread)
 706         (record_btrace_target::wait, record_btrace_target::wait)
 707         (record_btrace_target::wait, record_btrace_target::stop): Update.
 708         * progspace.c (print_program_space): Update.
 709         * process-stratum-target.c
 710         (process_stratum_target::thread_address_space): Update.
 711         * linux-fork.c (linux_fork_mourn_inferior)
 712         (detach_checkpoint_command, info_checkpoints_command)
 713         (linux_fork_context): Update.
 714         (linux_fork_detach): Update.
 715         (class scoped_switch_fork_info): Update.
 716         (delete_checkpoint_command): Update.
 717         * infrun.c (follow_fork_inferior): Update.
 718         (follow_fork_inferior): Update.
 719         (proceed_after_vfork_done): Update.
 720         (handle_vfork_child_exec_or_exit): Update.
 721         (follow_exec): Update.
 722         (displaced_step_prepare_throw): Update.
 723         (displaced_step_restore): Update.
 724         (start_step_over): Update.
 725         (resume_1): Update.
 726         (clear_proceed_status_thread): Update.
 727         (proceed): Update.
 728         (print_target_wait_results): Update.
 729         (do_target_wait): Update.
 730         (context_switch): Update.
 731         (stop_all_threads): Update.
 732         (restart_threads): Update.
 733         (finish_step_over): Update.
 734         (handle_signal_stop): Update.
 735         (switch_back_to_stepped_thread): Update.
 736         (keep_going_pass_signal): Update.
 737         (print_exited_reason): Update.
 738         (normal_stop): Update.
 739         * inferior.c (inferior_pid_to_str): Change return type.
 740         (print_selected_inferior): Update.
 741         (add_inferior): Update.
 742         (detach_inferior): Update.
 743         * dummy-frame.c (fprint_dummy_frames): Update.
 744         * dcache.c (dcache_info_1): Update.
 745         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 746         (btrace_fetch, btrace_clear): Update.
 747         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 748         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 749         type.
 750         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 751         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 752         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 753         * gdbarch.c, gdbarch.h: Rebuild.
 754         * gdbarch.sh (core_pid_to_str): Change return type.
 755         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 756         return type.
 757         (windows_nat_target::pid_to_str): Change return type.
 758         (windows_delete_thread): Update.
 759         (windows_nat_target::attach): Update.
 760         (windows_nat_target::files_info): Update.
 761         * target-delegates.c: Rebuild.
 762         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 763         return type.
 764         (sol_thread_target::pid_to_str): Change return type.
 765         * remote.c (class remote_target) <pid_to_str>: Change return
 766         type.
 767         (remote_target::pid_to_str): Change return type.
 768         (extended_remote_target::attach, remote_target::remote_stop_ns)
 769         (remote_target::remote_notif_remove_queued_reply)
 770         (remote_target::push_stop_reply, remote_target::disable_btrace):
 771         Update.
 772         (extended_remote_target::attach): Update.
 773         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 774         type.
 775         (gdbsim_target::pid_to_str): Change return type.
 776         * ravenscar-thread.c (struct ravenscar_thread_target)
 777         <pid_to_str>: Change return type.
 778         (ravenscar_thread_target::pid_to_str): Change return type.
 779         * procfs.c (class procfs_target) <pid_to_str>: Change return
 780         type.
 781         (procfs_target::pid_to_str): Change return type.
 782         (procfs_target::attach): Update.
 783         (procfs_target::detach): Update.
 784         (procfs_target::fetch_registers): Update.
 785         (procfs_target::store_registers): Update.
 786         (procfs_target::wait): Update.
 787         (procfs_target::files_info): Update.
 788         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 789         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 790         return type.
 791         (nto_procfs_target::pid_to_str): Change return type.
 792         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 793         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 794         return type.
 795         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 796         (exit_lwp): Update.
 797         (attach_proc_task_lwp_callback, get_detach_signal)
 798         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 799         (linux_nat_target::resume, wait_lwp, stop_callback)
 800         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 801         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 802         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 803         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 804         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 805         type.
 806         (inf_ptrace_target::attach): Update.
 807         (inf_ptrace_target::files_info): Update.
 808         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 809         type.
 810         (go32_nat_target::pid_to_str): Change return type.
 811         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 812         (gnu_nat_target::wait): Update.
 813         (gnu_nat_target::wait): Update.
 814         (gnu_nat_target::resume): Update.
 815         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 816         (fbsd_nat_target::wait): Update.
 817         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 818         type.
 819         (darwin_nat_target::attach): Update.
 820         * corelow.c (class core_target) <pid_to_str>: Change return type.
 821         (core_target::pid_to_str): Change return type.
 822         * target.c (normal_pid_to_str): Change return type.
 823         (default_pid_to_str): Likewise.
 824         (target_pid_to_str): Change return type.
 825         (target_translate_tls_address): Update.
 826         (target_announce_detach): Update.
 827         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 828         return type.
 829         (bsd_uthread_target::pid_to_str): Change return type.
 830         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 831         type.
 832         (bsd_kvm_target::pid_to_str): Change return type.
 833         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 834         return type.
 835         (aix_thread_target::pid_to_str): Change return type.
 836         * target.h (struct target_ops) <pid_to_str>: Change return type.
 837         (target_pid_to_str, normal_pid_to_str): Likewise.
 838         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 839         type.
 840         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 841         type.
 842         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 843         return type.
 844         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 845         type.
 846         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 847         type.
 848         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 849         return type.
 850
 851 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 852
 853         * NEWS: Mention that the new default MI version is 3.  Mention
 854         changes to the output of commands and events that deal with
 855         multi-location breakpoints.
 856         * breakpoint.c: Include "mi/mi-out.h".
 857         (print_one_breakpoint): Change output syntax if using MI version
 858         >= 3.
 859         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 860         New.
 861         (mi_multi_location_breakpoint_output_fixed): New.
 862         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 863         (mi_cmd_fix_multi_location_breakpoint_output): New.
 864         (mi_multi_location_breakpoint_output_fixed): New.
 865         * mi/mi-cmds.c (mi_cmds): Register command
 866         -fix-multi-location-breakpoint-output.
 867         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 868         interpreter "mi".
 869
 870 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 871
 872         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 873         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 874         instantiate mi_ui_out based on interpreter name.
 875         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 876         * mi/mi-main.c (mi_load_progress): Likewise.
 877
 878 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 879
 880         * NEWS: Combine separate "New targets" sections for 8.3.
 881
 882 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 883
 884         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 885         (ppcfbsd_init_abi): Install gdbarch
 886         "fetch_tls_load_module_address" and "get_thread_local_address"
 887         methods.
 888
 889 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 890
 891         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 892         (riscv_fbsd_init_abi): Install gdbarch
 893         "fetch_tls_load_module_address" and "get_thread_local_address"
 894         methods.
 895
 896 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 897
 898         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 899         (i386fbsd_init_abi): Install gdbarch
 900         "fetch_tls_load_module_address" and "get_thread_local_address"
 901         methods.
 902
 903 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 904
 905         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 906         (amd64fbsd_init_abi): Install gdbarch
 907         "fetch_tls_load_module_address" and "get_thread_local_address"
 908         methods.
 909
 910 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 911
 912         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 913         (struct fbsd_pspace_data): New type.
 914         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 915         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 916         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 917         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 918         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 919
 920 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 921
 922         * gdbtypes.c (lookup_struct_elt): New function.
 923         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 924         * gdbtypes.h (struct struct_elt): New type.
 925         (lookup_struct_elt): New prototype.
 926
 927 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 928
 929         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 930         remove disabled code block.
 931
 932 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 933
 934         * gdbarch.sh (get_thread_local_address): New method.
 935         * gdbarch.h, gdbarch.c: Regenerate.
 936         * target.c (target_translate_tls_address): Use
 937         gdbarch_get_thread_local_address if present instead of
 938         target::get_thread_local_address.
 939
 940 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 941
 942         * target.h (target::get_thread_local_address): Update comment.
 943
 944 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 945
 946         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 947         objfile->separate_debug_objfile_backlink if not NULL.
 948
 949 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 950
 951         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 952         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 953         (amd64bsd_store_inferior_registers): Likewise.
 954         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 955         Enable segment base registers.
 956         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 957         PT_GETFSBASE and PT_GETGSBASE.
 958         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 959         PT_SETGSBASE.
 960         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 961         segment base registers.
 962         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 963
 964 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 965
 966         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 967         Update calls to i386_target_description to add 'segments'
 968         parameter.
 969         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 970         add segment base registers.
 971         * arch/i386.c (i386_create_target_description): Add 'segments'
 972         parameter to enable segment base registers.
 973         * arch/i386.h (i386_create_target_description): Likewise.
 974         * features/i386/32bit-segments.xml: New file.
 975         * features/i386/32bit-segments.c: Generate.
 976         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 977         call to i386_target_description to add 'segments' parameter.
 978         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 979         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 980         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 981         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 982         if feature is present.
 983         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 984         Add 'segments' parameter to call to i386_target_description.
 985         (i386_target_description): Add 'segments' parameter to enable
 986         segment base registers.
 987         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 988         to call to i386_target_description.
 989         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 990         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 991         Define I386_NUM_REGS.
 992         (i386_target_description): Add 'segments' parameter to enable
 993         segment base registers.
 994
 995 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 996
 997         PR/24325
 998         * source-cache.c: #undef open and close, to avoid unresolved
 999         externals during linking.
1000
1001 2019-03-12  Tom Tromey  <tromey@adacore.com>
1002
1003         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
1004         const.  Add initializers.
1005         (_initialize_remote): Don't initialize ptid globals.
1006
1007 2019-03-12  Pedro Alves  <palves@redhat.com>
1008
1009         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
1010
1011 2019-03-12  Pedro Alves  <palves@redhat.com>
1012
1013         * cp-name-parser.y (main): Remove unused 'len' variable.
1014
1015 2019-03-12  Tom Tromey  <tromey@adacore.com>
1016
1017         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
1018         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
1019
1020 2019-03-12  Tom Tromey  <tromey@adacore.com>
1021
1022         * linux-nat.c (iterate_over_lwps): Update.
1023         (stop_callback): Remove parameter.
1024         (stop_wait_callback, detach_callback, resume_set_callback)
1025         (select_singlestep_lwp_callback, set_ignore_sigint)
1026         (status_callback, resumed_callback, resume_clear_callback)
1027         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
1028         data parameter.
1029         (linux_nat_target::detach, linux_nat_target::resume)
1030         (linux_stop_and_wait_all_lwps, select_event_lwp)
1031         (linux_nat_filter_event, linux_nat_wait_1)
1032         (linux_nat_target::kill, linux_nat_target::stop)
1033         (linux_nat_target::stop): Update.
1034         (linux_nat_resume_callback): Change type.
1035         (resume_stopped_resumed_lwps, count_events_callback)
1036         (select_event_lwp_callback): Likewise.
1037         (linux_stop_lwp, linux_nat_stop_lwp): Update.
1038         * arm-linux-nat.c (struct update_registers_data): Remove.
1039         (update_registers_callback): Change type.
1040         (arm_linux_insert_hw_breakpoint1): Update.
1041         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
1042         parameter.
1043         (x86_linux_dr_set_addr): Update.
1044         (x86_linux_dr_set_control): Update.
1045         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
1046         (iterate_over_lwps): Use gdb::function_view.
1047         * nat/aarch64-linux-hw-point.c (struct
1048         aarch64_dr_update_callback_param): Remove.
1049         (debug_reg_change_callback): Change type.
1050         (aarch64_notify_debug_reg_change): Update.
1051         * s390-linux-nat.c (s390_refresh_per_info): Update.
1052
1053 2019-03-11  Tom Tromey  <tromey@adacore.com>
1054
1055         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
1056         redundant assignment to "this_cu".
1057
1058 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1059
1060         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
1061
1062 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1063
1064         * gdbtypes.c (rank_one_type_parm_set): New function extracted
1065         from...
1066         (rank_one_type): ... this.
1067
1068 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1069
1070         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
1071         from...
1072         (rank_one_type): ... this.
1073
1074 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1075
1076         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
1077         from...
1078         (rank_one_type): ... this.
1079
1080 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1081
1082         * gdbtypes.c (rank_one_type_parm_float): New function extracted
1083         from...
1084         (rank_one_type): ... this.
1085
1086 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1087
1088         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
1089         from...
1090         (rank_one_type): ... this.
1091
1092 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1093
1094         * gdbtypes.c (rank_one_type_parm_range): New function extracted
1095         from...
1096         (rank_one_type): ... this.
1097
1098 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1099
1100         * gdbtypes.c (rank_one_type_parm_char): New function extracted
1101         from...
1102         (rank_one_type): ... this.
1103
1104 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1105
1106         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
1107         from...
1108         (rank_one_type): ... this.
1109
1110 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1111
1112         * gdbtypes.c (rank_one_type_parm_int): New function extracted
1113         from...
1114         (rank_one_type): ... this.
1115
1116 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1117
1118         * gdbtypes.c (rank_one_type_parm_func): New function extracted
1119         from...
1120         (rank_one_type): ... this.
1121
1122 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1123
1124         * gdbtypes.c (rank_one_type_parm_array): New function extracted
1125         from...
1126         (rank_one_type): ... this.
1127
1128 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1129
1130         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
1131         from...
1132         (rank_one_type): ... this.
1133
1134 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1135
1136         * inferior.c (initialize_inferiors): Ensure 'help set/show print
1137         inferior-events' shows the example events.
1138
1139 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
1140
1141         Support styling on native MS-Windows console
1142
1143         PR/24315
1144         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
1145         on MS-Windows if $TERM is not defined.
1146
1147         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
1148
1149         * posix-hdep.c (gdb_console_fputs):
1150         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
1151         functions.
1152         * ui-file.h (gdb_console_fputs): Add prototype.
1153
1154         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
1155         back to fputs only if the former returns zero.
1156
1157 2019-03-07  Tom Tromey  <tom@tromey.com>
1158
1159         * symmisc.c (print_symbol_bcache_statistics): Update.
1160         (print_objfile_statistics): Update.
1161         * symfile.c (allocate_symtab): Update.
1162         * stabsread.c: Don't include bcache.h.
1163         * psymtab.h (struct psymbol_bcache): Don't declare.
1164         (class psymtab_storage) <psymbol_cache>: Now a bcache.
1165         (psymbol_bcache_init, psymbol_bcache_free)
1166         (psymbol_bcache_get_bcache): Don't declare.
1167         * psymtab.c (struct psymbol_bcache): Remove.
1168         (psymtab_storage::psymtab_storage): Update.
1169         (psymtab_storage::~psymtab_storage): Update.
1170         (psymbol_bcache_init, psymbol_bcache_free)
1171         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
1172         (add_psymbol_to_bcache): Update.
1173         (allocate_psymtab): Update.
1174         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
1175         macro_cache>: No longer pointers.
1176         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
1177         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
1178         * macrotab.c (macro_bcache): Update.
1179         * macroexp.c: Don't include bcache.h.
1180         * gdbtypes.c (check_types_worklist): Update.
1181         (types_deeply_equal): Remove TRY/CATCH.  Update.
1182         * elfread.c (elf_symtab_read): Update.
1183         * dwarf2read.c: Don't include bcache.h.
1184         * buildsym.c (buildsym_compunit::get_macro_table): Update.
1185         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
1186         (print_bcache_statistics, bcache_memory_used): Don't declare.
1187         (struct bcache): Move from bcache.c.  Add constructor, destructor,
1188         methods.  Rename all data members.
1189         * bcache.c (struct bcache): Move to bcache.h.
1190         (bcache::expand_hash_table): Rename from expand_hash_table.
1191         (bcache): Remove.
1192         (bcache::insert): Rename from bcache_full.
1193         (bcache::compare): Rename from bcache_compare.
1194         (bcache_xmalloc): Remove.
1195         (bcache::~bcache): Rename from bcache_xfree.
1196         (bcache::print_statistics): Rename from print_bcache_statistics.
1197         (bcache::memory_used): Rename from bcache_memory_used.
1198
1199 2019-03-07  Pedro Alves  <palves@redhat.com>
1200
1201         * infrun.c (normal_stop): Also check for
1202         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
1203
1204 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1205
1206         * f-lang.c (value_from_host_double): Moved to...
1207         * value.c (value_from_host_double): ...here.
1208         * value.h (value_from_host_double): Declare.
1209         * guile/scm-math.c (vlscm_convert_typed_number): Use
1210         value_from_host_double.
1211         (vlscm_convert_number): Likewise.
1212         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
1213         * python/py-value.c (convert_value_from_python): Likewise.
1214
1215 2019-03-06  Tom Tromey  <tom@tromey.com>
1216
1217         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
1218
1219 2019-03-06  Tom Tromey  <tom@tromey.com>
1220
1221         * utils.h (free_current_contents): Don't declare.
1222         * utils.c (free_current_contents): Remove.
1223
1224 2019-03-06  Tom Tromey  <tom@tromey.com>
1225
1226         * top.c (quit_force): Update.
1227         * main.c (captured_command_loop): Update.
1228         * common/new-op.c (operator new): Update.
1229         * common/common-exceptions.c (struct catcher)
1230         <save_cleanup_chain>: Remove member.
1231         (exceptions_state_mc_init): Update.
1232         (exception_try_scope_entry): Return nullptr.
1233         (exception_try_scope_exit, exception_rethrow)
1234         (throw_exception_sjlj, throw_exception_cxx): Update.
1235         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
1236         (all_cleanups, do_cleanups, discard_cleanups)
1237         (discard_final_cleanups, save_cleanups, save_final_cleanups)
1238         (restore_cleanups, restore_final_cleanups): Don't declare.
1239         (do_final_cleanups): Remove parameter.
1240         * common/cleanups.c (cleanup_chain, make_cleanup)
1241         (make_cleanup_dtor, all_cleanups, do_cleanups)
1242         (discard_my_cleanups, discard_cleanups)
1243         (discard_final_cleanups, save_my_cleanups, save_cleanups)
1244         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
1245         (null_cleanup): Remove.
1246         (do_final_cleanups): Remove parameter.
1247
1248 2019-03-06  Tom Tromey  <tom@tromey.com>
1249
1250         * remote.c (remote_target::remote_parse_stop_reply): Use
1251         unique_xmalloc_ptr.
1252
1253 2019-03-06  Tom Tromey  <tom@tromey.com>
1254
1255         * stabsread.c (struct stabs_field_info): Rename from field_info.
1256         <list, fnlist>: Add initializers.
1257         <obstack>: New member.
1258         (read_member_functions, read_struct_fields, read_baseclasses):
1259         Allocate on obstack.  Don't use cleanups.
1260         (read_one_struct_field, read_member_functions, read_struct_fields)
1261         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
1262         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
1263         (read_struct_type): Update.
1264
1265 2019-03-06  Tom Tromey  <tom@tromey.com>
1266
1267         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
1268         * common/filestuff.h (make_cleanup_close): Don't declare.
1269         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
1270         Remove.
1271
1272 2019-03-06  Tom Tromey  <tom@tromey.com>
1273
1274         * solib-aix.c: Use make_scope_exit.
1275
1276 2019-03-06  Tom Tromey  <tom@tromey.com>
1277
1278         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
1279         Use make_scope_exit.
1280
1281 2019-03-06  Tom Tromey  <tom@tromey.com>
1282
1283         * solib-svr4.c (disable_probes_interface): Remove parameter.
1284         (svr4_handle_solib_event): Use make_scope_exit.
1285
1286 2019-03-06  Tom Tromey  <tom@tromey.com>
1287
1288         * remote.c (struct stop_reply_deleter): Remove.
1289         (stop_reply_up): Update.
1290         (struct stop_reply): Derive from notif_event.  Don't typedef.
1291         <regcache>: Now a std::vector.
1292         (stop_reply_xfree): Remove.
1293         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
1294         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
1295         (remote_target::discard_pending_stop_replies): Use delete.
1296         (remote_target::remote_parse_stop_reply): Update.
1297         (remote_target::process_stop_reply): Update.
1298         * remote-notif.h (struct notif_event): Add virtual destructor.
1299         Remove "dtr" member.
1300         (struct notif_client) <alloc_event>: Return a unique_ptr.
1301         (notif_event_xfree): Don't declare.
1302         (notif_event_up): New typedef.
1303         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
1304         (notif_event_xfree, do_notif_event_xfree): Remove.
1305         (remote_notif_state_xfree): Update.
1306
1307 2019-03-06  Tom Tromey  <tom@tromey.com>
1308
1309         * infrun.c (displaced_step_clear_cleanup): Now a
1310         forward_scope_exit type.
1311         (displaced_step_prepare_throw): Update.
1312         (displaced_step_fixup): Update.
1313
1314 2019-03-06  Tom Tromey  <tom@tromey.com>
1315
1316         * inferior.h (class inferior): Update comment.
1317         * gdbthread.h (class thread_info): Update comment.
1318
1319 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
1320             Tom Tromey  <tom@tromey.com>
1321
1322         * stabsread.h (struct stab_section_list): Remove.
1323         (coffstab_build_psymtabs): Update.
1324         * dbxread.c (symbuf_sections): Now a std::vector.
1325         (sect_idx): New global.
1326         (fill_symbuf): Update.
1327         (coffstab_build_psymtabs): Change type of stabsects parameter.
1328         Update.
1329         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
1330         std::vector.
1331         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
1332         (coff_locate_sections): Update.
1333         (coff_symfile_read): Remove cleanups.  Update.
1334         (init_stringtab): Add storage parameter.
1335         (free_stringtab, free_stringtab_cleanup): Remove.
1336         (init_lineno): Add storage parameter.
1337         (free_linetab, free_linetab_cleanup): Remove.
1338
1339 2019-03-06  Pedro Alves  <palves@redhat.com>
1340
1341         * linux-fork.c (fork_info::clobber_regs): Delete.
1342         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
1343         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
1344         comment.  Adjust.
1345         (scoped_switch_fork_info::scoped_switch_fork_info)
1346         (checkpoint_command, linux_fork_context): Adjust
1347         fork_save_infrun_state calls.
1348
1349 2019-03-06  Pedro Alves  <palves@redhat.com>
1350
1351         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
1352         (inf_has_multiple_threads): Return 'bool' and rewrite using
1353         inferior_info::threads().
1354
1355 2019-03-06  Pedro Alves  <palves@redhat.com>
1356
1357         * linux-fork.c: Include <list>.
1358         (fork_list): Now a std::list instance.
1359         (fork_info): Add ctor, dtor, and in-class initialize all fields.
1360         (forks_exist_p, find_last_fork): Adjust.
1361         (new_fork): Delete.
1362         (one_fork_p): New.
1363         (add_fork): Adjust.
1364         (free_fork): Delete, folded into fork_info::~fork_info().
1365         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
1366         Adjust.
1367         (init_fork_list): Delete.
1368         (linux_fork_killall, linux_fork_mourn_inferior)
1369         (linux_fork_detach, info_checkpoints_command): Adjust.
1370         (_initialize_linux_fork): No longer call init_fork_list.
1371
1372 2019-03-06  Pedro Alves  <palves@redhat.com>
1373
1374         * linux-fork.c (new_fork): New, split out of ...
1375         (add_fork): ... this.  Return void.  Move "first fork" special
1376         case from here, to ...
1377         (checkpoint_command): ... here.
1378         * linux-linux.h (add_fork): Return void.
1379
1380 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1381
1382         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1383
1384 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1385             Chris January  <chris.january@arm.com>
1386             David Lecomber  <david.lecomber@arm.com>
1387
1388         * f-exp.y: New token, UNOP_INTRINSIC.
1389         (exp): New pattern using UNOP_INTRINSIC token.
1390         (f77_keywords): Add 'abs' keyword.
1391         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1392         (value_from_host_double): New function.
1393         (evaluate_subexp_f): Support UNOP_ABS.
1394
1395 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1396
1397         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1398         types.
1399
1400 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1401
1402         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1403         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1404         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1405
1406 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1407
1408         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1409
1410 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1411             Chris January  <chris.january@arm.com>
1412
1413         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1414         * f-exp.y: Define 'KIND' token.
1415         (exp): New pattern for KIND expressions.
1416         (ptype): Handle types with a kind extension.
1417         (direct_abs_decl): Extend to spot kind extensions.
1418         (f77_keywords): Add 'kind' to the list.
1419         (push_kind_type): New function.
1420         (convert_to_kind_type): New function.
1421         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1422         * parse.c (operator_length_standard): Likewise.
1423         * parser-defs.h (enum type_pieces): Add tp_kind.
1424         * std-operator.def: Add UNOP_KIND.
1425
1426 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1427
1428         * f-exp.y (f_parse): Set yydebug.
1429
1430 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1431
1432         * f-lang.c (evaluate_subexp_f): New function.
1433         (exp_descriptor_f): New global.
1434         (f_language_defn): Use exp_descriptor_f instead of
1435         exp_descriptor_standard.
1436
1437 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1438
1439         * f-exp.y (struct token): Add comments.
1440         (dot_ops): Remove uppercase versions and the end marker.
1441         (f77_keywords): Likewise.
1442         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1443         entries in the dot_ops array are case insensitive, and use
1444         strncasecmp to compare strings.  Also some whitespace cleanup in
1445         this area.  Similar for the f77_keywords array, except entries in
1446         this list might be case sensitive.
1447
1448 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1449
1450         * f-exp.y (struct f77_boolean_val): Add comments.
1451         (boolean_values): Remove uppercase versions, and end marker.
1452         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1453         and use strncasecmp to achieve case insensitivity.  Additionally,
1454         perform whitespace cleanup around this code.
1455
1456 2019-03-06  Tom Tromey  <tromey@adacore.com>
1457
1458         * remote-sim.c (gdbsim_target_open): Use result of
1459         gdb_argv::release.
1460
1461 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1462         Dirk Schubert  <dirk.schubert@arm.com>
1463         Chris January  <chris.january@arm.com>
1464
1465         * eval.c (evaluate_subexp_standard): Call Fortran argument
1466         wrapping logic.
1467         * f-lang.c (struct value): A value which can be passed into a
1468         Fortran function call.
1469         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1470         where appropriate.
1471         (struct type): Value ready for a Fortran function call.
1472         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1473         is needed.
1474         * f-lang.h (fortran_argument_convert): Declaration.
1475         (fortran_preserve_arg_pointer): Declaration.
1476         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1477
1478 2019-03-05  Tom Tromey  <tromey@adacore.com>
1479
1480         * python/py-prettyprint.c (print_string_repr): Remove #if.
1481         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1482
1483 2019-03-05  Tom Tromey  <tromey@adacore.com>
1484
1485         * target.c (the_dummy_target): Move later.  Change type to
1486         "dummy_target".
1487         (initialize_targets): Don't initialize the_dummy_target.
1488
1489 2019-03-05  Tom Tromey  <tromey@adacore.com>
1490
1491         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1492         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1493
1494 2019-03-05  Tom Tromey  <tromey@adacore.com>
1495
1496         * windows-nat.c (windows_nat_target::attach)
1497         (windows_nat_target::detach): Don't call gdb_flush.
1498         * valprint.c (generic_val_print, val_print, val_print_string):
1499         Don't call gdb_flush.
1500         * utils.c (defaulted_query): Don't call gdb_flush.
1501         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1502         * target.c (target_announce_detach): Don't call gdb_flush.
1503         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1504         * remote.c (extended_remote_target::attach): Don't call
1505         gdb_flush.
1506         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1507         * printcmd.c (do_examine): Don't call gdb_flush.
1508         (info_display_command): Don't call gdb_flush.
1509         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1510         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1511         * memattr.c (info_mem_command): Don't call gdb_flush.
1512         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1513         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1514         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1515         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1516         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1517         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1518         (gnu_nat_target::detach): Don't call gdb_flush.
1519         * f-valprint.c (f_val_print): Don't call gdb_flush.
1520         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1521         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1522         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1523         gdb_flush.
1524         * c-valprint.c (c_val_print): Don't call gdb_flush.
1525         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1526
1527 2019-03-05  Tom Tromey  <tromey@adacore.com>
1528
1529         * varobj.c (update_dynamic_varobj_children): Update.
1530         (install_default_visualizer): Use reset, not release.
1531         * value.c (set_internalvar): Update.
1532         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1533         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1534         ATTRIBUTE_UNUSED_RESULT.
1535
1536 2019-03-05  Tom Tromey  <tromey@adacore.com>
1537
1538         * remote.c (class scoped_remote_fd) <release>: Add
1539         ATTRIBUTE_UNUSED_RESULT.
1540
1541 2019-03-05  Tom Tromey  <tromey@adacore.com>
1542
1543         * macroexp.c (struct macro_buffer) <release>: Add
1544         ATTRIBUTE_UNUSED_RESULT.
1545
1546 2019-03-05  Tom Tromey  <tromey@adacore.com>
1547
1548         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1549         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1550         ATTRIBUTE_UNUSED_RESULT.
1551
1552 2019-03-05  Tom Tromey  <tromey@adacore.com>
1553
1554         * common/scoped_fd.h (class scoped_fd) <release>: Add
1555         ATTRIBUTE_UNUSED_RESULT.
1556
1557 2019-03-05  Tom Tromey  <tromey@adacore.com>
1558
1559         * parser-defs.h (struct parser_state) <release>: Add
1560         ATTRIBUTE_UNUSED_RESULT.
1561
1562 2019-03-05  Tom Tromey  <tromey@adacore.com>
1563
1564         * utils.h (class gdb_argv) <release>: Add
1565         ATTRIBUTE_UNUSED_RESULT.
1566         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1567
1568 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1569
1570         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1571         for-loop range, to avoid compiler warnings.
1572
1573         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1574         avoid compiler warnings about unused variables.
1575
1576         * NEWS: Mention end of support for native debugging on MS-Windows
1577         before XP.
1578
1579         PR gdb/24292
1580         * common/netstuff.c:
1581         * gdbserver/gdbreplay.c
1582         * gdbserver/remote-utils.c:
1583         * ser-tcp.c:
1584         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1585         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1586         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1587         'getaddrinfo' and 'freeaddrinfo' were not available before
1588         Windows XP, and mingw.org's MinGW headers by default define
1589         _WIN32_WINNT to 0x500.
1590
1591 2019-03-01  Gary Benson <gbenson@redhat.com>
1592
1593         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1594
1595 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1596             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1597
1598         PR gdb/8527
1599         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1600         set_sigint_trap, clear_sigint_trap.
1601
1602 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1603
1604         * target.c (target_detach): Clear the regcache and the
1605         frame cache.
1606
1607 2019-02-27  Pedro Alves  <palves@redhat.com>
1608
1609         * utils.c (set_screen_size): When we cap the height/width sizes,
1610         tweak the corresponding command variable to show "unlimited":
1611
1612 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1613             Pedro Alves  <palves@redhat.com>
1614
1615         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1616         before calling rl_set_screen_size.
1617
1618 2019-02-27  Tom Tromey  <tromey@adacore.com>
1619
1620         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1621         define.
1622         * python/py-value.c: Remove Python 2.4 workaround.
1623         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1624         workaround.
1625         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1626         Python 2.4 workaround.
1627         * python/python-internal.h: Remove Python 2.4 comment.
1628         (Py_ssize_t): Don't define.
1629         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1630         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1631         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1632         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1633         * python/python.c (do_start_initialization): Remove Python 2.4
1634         workaround.
1635         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1636         (print_children): Remove Python 2.4 workaround.
1637         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1638         workaround.
1639         (CHARBUFFERPROC_NAME): Remove.
1640         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1641         Python 2.4 workaround.
1642
1643 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1644
1645         * NEWS: Note minimum Python version.
1646
1647 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1648
1649         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1650         code from these functions.  Remove corresponding ifdefs.  Use
1651         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1652         Remove gotos and target of gotos.
1653         (infpy_search_memory): Likewise.
1654
1655 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1656
1657         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1658         (hppa_gdbarch_init): Don't register deleted functions with
1659         gdbarch.
1660
1661 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1662
1663         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1664         (h8300_unwind_sp): Delete.
1665         (h8300_dummy_id): Delete.
1666         (h8300_gdbarch_init): Don't register deleted functions with
1667         gdbarch.
1668
1669 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1670
1671         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1672         (ft32_unwind_pc): Delete.
1673         (ft32_unwind_sp): Delete.
1674         (ft32_gdbarch_init): Don't register deleted functions with
1675         gdbarch.
1676
1677 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1678
1679         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1680         (frv_unwind_pc): Delete.
1681         (frv_unwind_sp): Delete.
1682         (frv_gdbarch_init): Don't register deleted functions with
1683         gdbarch.
1684
1685 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1686
1687         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1688         (riscv_unwind_pc): Delete.
1689         (riscv_unwind_sp): Delete.
1690         (riscv_gdbarch_init): Don't register deleted functions with
1691         gdbarch.
1692
1693 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1694
1695         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1696         (csky_unwind_pc): Delete.
1697         (csky_unwind_sp): Delete.
1698         (csky_gdbarch_init): Don't register deleted functions with
1699         gdbarch.
1700
1701 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1702
1703         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1704         (cris_unwind_pc): Delete.
1705         (cris_unwind_sp): Delete.
1706         (cris_gdbarch_init): Don't register deleted functions with
1707         gdbarch.
1708
1709 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1710
1711         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1712         (bfin_unwind_pc): Delete.
1713         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1714
1715 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1716
1717         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1718         (arm_unwind_pc): Delete.
1719         (arm_unwind_sp): Delete.
1720         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1721
1722 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1723
1724         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1725         (arc_unwind_pc): Delete.
1726         (arc_unwind_sp): Delete.
1727         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1728
1729 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1730
1731         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1732         (alpha_unwind_pc): Delete.
1733         (alpha_gdbarch_init): Don't register deleted functions with
1734         gdbarch.
1735
1736 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1737
1738         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1739         (aarch64_unwind_pc): Delete.
1740         (aarch64_unwind_sp): Delete.
1741         (aarch64_gdbarch_init): Don't register deleted functions with
1742         gdbarch.
1743
1744 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1745
1746         * gdbtypes.c (type_align): Don't consider static members when
1747         computing structure alignment.
1748
1749 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1750
1751         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1752         return 0 for other types.
1753         * arch-utils.c (default_type_align): Always return 0.
1754         * gdbarch.h: Regenerate.
1755         * gdbarch.sh (type_align): Extend comment.
1756         * gdbtypes.c (type_align): Add additional comments, always call
1757         gdbarch_type_align before applying the default rules.
1758         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1759         generic code will then apply a suitable default.
1760         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1761         types, return 0 for other types.
1762
1763 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1764
1765         * NEWS: Create a new section for the next release branch.
1766         Rename the section of the current branch, now that it has
1767         been cut.
1768
1769 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1770
1771         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1772         * version.in: Bump version to 8.3.50.DATE-git.
1773
1774 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1775
1776         * aix-thread.c (ptid_cmp): Remove unused variable.
1777         (get_signaled_thread): Likewise.
1778         (store_regs_user_thread): Likewise.
1779         (store_regs_kernel_thread): Likewise.
1780         (fetch_regs_kernel_thread): Remove shadowed variable.
1781
1782 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1783
1784         * features/riscv/32bit-cpu.xml: Add register numbers.
1785         * features/riscv/32bit-fpu.c: Regenerate.
1786         * features/riscv/32bit-fpu.xml: Add register numbers.
1787         * features/riscv/64bit-cpu.xml: Add register numbers.
1788         * features/riscv/64bit-fpu.c: Regenerate.
1789         * features/riscv/64bit-fpu.xml: Add register numbers.
1790
1791 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1792
1793         * NEWS: Mention two argument form of gdb.Value constructor.
1794         * python/py-value.c (convert_buffer_and_type_to_value): New
1795         function.
1796         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1797         Add support for handling an optional second argument.  Call
1798         convert_buffer_and_type_to_value as appropriate.
1799         * python/python-internal.h (Py_buffer_deleter): New struct.
1800         (Py_buffer_up): New typedef.
1801
1802 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1803
1804         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1805         instead of releasing ownership.
1806
1807 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1808
1809         * dwarf2read.c (open_and_init_dwp_file): Call
1810         elf_numsections instead of bfd_count_sections to initialize
1811         dwp_file->num_sections.
1812
1813 2019-02-25  Tom Tromey  <tromey@adacore.com>
1814
1815         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1816
1817 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1818
1819         * gcore.in: Add '--readnever' option when invoking GDB.
1820
1821 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1822
1823         * MAINTAINERS: Update my email address.
1824
1825 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1826
1827         * build-id.c (build_id_to_debug_bfd_1): New function.
1828         (build_id_to_debug_bfd): Look for separate debug file in
1829         sysroot.
1830
1831 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1832
1833         * gdbarch.sh: Update the copyright year range that is placed into
1834         generated files.
1835
1836 2019-02-22  Keith Seitz  <keiths@redhat.com>
1837
1838         PR symtab/23853
1839         * linespec.c (create_sals_line_offset): Search for the default
1840         symtab's filename instead of its fullname.
1841
1842 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1843
1844         * NEWS: Update style defaults.
1845
1846 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1847
1848         * main.c (captured_main_1): Disable styling in batch mode.
1849
1850 2019-02-20  Tom Tromey  <tom@tromey.com>
1851
1852         * symtab.c (symtab_symbol_info): Fix typos.
1853
1854 2019-02-20  Tom Tromey  <tromey@adacore.com>
1855
1856         * findcmd.c (_initialize_mem_search): Use upper case for
1857         metasyntactic variables.
1858
1859 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1860
1861         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1862         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1863
1864 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1865
1866         * top.h (source_file_name): Change to std::string.
1867         * top.c (source_file_name): Likewise.
1868         (command_line_input): Adjust.
1869         * cli/cli-script.c (script_from_file): Adjust.
1870
1871 2019-02-19  Tom Tromey  <tromey@adacore.com>
1872
1873         * ravenscar-thread.c
1874         (ravenscar_thread_target::update_thread_list): Don't call
1875         ada_build_task_list.
1876         * ada-lang.h (ada_build_task_list): Don't declare.
1877         * ada-tasks.c (struct ada_tasks_inferior_data)
1878         <task_list_valid_p>: Now bool.
1879         (read_known_tasks, ada_task_list_changed)
1880         (ada_tasks_invalidate_inferior_data): Update.
1881         (read_known_tasks_array): Return bool.
1882         (read_known_tasks_list): Likewise.
1883         (read_known_tasks): Return void.
1884         (ada_build_task_list): Now static.
1885
1886 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1887
1888         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1889         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1890
1891 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1892
1893         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1894         variant for ada_tasks_pspace_data_handle and
1895         ada_tasks_inferior_data_handle.
1896         (ada_tasks_pspace_data_cleanup): New function.
1897         (ada_tasks_inferior_data_cleanup): New function.
1898
1899 2019-02-17  Tom Tromey  <tom@tromey.com>
1900
1901         * macrotab.h (macro_source_fullname): Return a std::string.
1902         * macrotab.c (macro_include, check_for_redefinition)
1903         (macro_undef, macro_lookup_definition, foreach_macro)
1904         (foreach_macro_in_scope): Update.
1905         (macro_source_fullname): Return a std::string.
1906         * macrocmd.c (show_pp_source_pos): Update.
1907
1908 2019-02-17  Tom Tromey  <tom@tromey.com>
1909
1910         * macrocmd.c (show_pp_source_pos): Style the file names.
1911
1912 2019-02-17  Tom Tromey  <tom@tromey.com>
1913
1914         PR tui/24197:
1915         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1916
1917 2019-02-17  Tom Tromey  <tom@tromey.com>
1918
1919         * ada-lang.c (user_select_syms): Use filtered printing.
1920         * utils.c (wrap_style): New global.
1921         (desired_style): Remove.
1922         (emit_style_escape): Add stream parameter.
1923         (set_output_style, reset_terminal_style, prompt_for_continue):
1924         Update.
1925         (flush_wrap_buffer): Only flush gdb_stdout.
1926         (wrap_here): Set wrap_style.
1927         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1928         treat escape sequences as a character.  Change when wrap buffer is
1929         flushed.
1930         (fputs_styled): Do not set the output style when the default is
1931         requested.
1932         * ui-style.h (struct ui_file_style) <is_default>: New method.
1933         * source.c (print_source_lines_base): Emit escape sequences in one
1934         piece.
1935
1936 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1937
1938         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1939         integers and enumeration types.
1940
1941 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1942
1943         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1944         instead of lookup_symbol_in_language
1945         (do_exact_match): New function.
1946         (ada_get_symbol_name_matcher): Return do_exact_match when
1947         doing a verbatim match.
1948
1949 2019-02-15  Tom Tromey  <tromey@adacore.com>
1950
1951         * ravenscar-thread.c (ravenscar_thread_target::resume)
1952         (ravenscar_thread_target::wait): Special case wildcard requests.
1953
1954 2019-02-15  Tom Tromey  <tromey@adacore.com>
1955
1956         * ravenscar-thread.c (base_ptid): Remove.
1957         (struct ravenscar_thread_target) <close>: New method.
1958         <m_base_ptid>: New member.
1959         <update_inferior_ptid, active_task, task_is_currently_active,
1960         runtime_initialized>: Declare methods.
1961         <ravenscar_thread_target>: Add constructor.
1962         (ravenscar_thread_target::task_is_currently_active)
1963         (ravenscar_thread_target::update_inferior_ptid)
1964         (ravenscar_runtime_initialized): Rename.  Now methods.
1965         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1966         (ravenscar_thread_target::update_thread_list): Update.
1967         (ravenscar_thread_target::active_task): Now method.
1968         (ravenscar_thread_target::store_registers)
1969         (ravenscar_thread_target::prepare_to_store)
1970         (ravenscar_thread_target::prepare_to_store)
1971         (ravenscar_thread_target::mourn_inferior): Update.
1972         (ravenscar_inferior_created): Use "new" to create target.
1973         (ravenscar_thread_target::get_ada_task_ptid): Update.
1974         (_initialize_ravenscar): Don't initialize base_ptid.
1975         (ravenscar_ops): Remove global.
1976
1977 2019-02-15  Tom Tromey  <tromey@adacore.com>
1978
1979         * target.h (push_target): Declare new overload.
1980         * target.c (push_target): New overload, taking an rvalue reference.
1981         * remote.c (remote_target::open_1): Use push_target overload.
1982         * corelow.c (core_target_open): Use push_target overload.
1983
1984 2019-02-15  Tom Tromey  <tromey@adacore.com>
1985
1986         * ravenscar-thread.c (is_ravenscar_task)
1987         (ravenscar_task_is_currently_active): Return bool.
1988         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1989         (_initialize_ravenscar): Remove "(void)".
1990         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1991         Return bool.
1992
1993 2019-02-15  Tom Tromey  <tromey@adacore.com>
1994
1995         * ravenscar-thread.c (ravenscar_runtime_initializer)
1996         (has_ravenscar_runtime, get_running_thread_id)
1997         (ravenscar_thread_target::resume): Fix indentation.
1998
1999 2019-02-15  Tom Tromey  <tromey@adacore.com>
2000
2001         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
2002         from ravenscar_arch_ops.
2003         (sparc_ravenscar_ops::fetch_registers)
2004         (sparc_ravenscar_ops::store_registers): Now methods.
2005         (sparc_ravenscar_prepare_to_store): Remove.
2006         (sparc_ravenscar_ops): Redefine.
2007         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
2008         methods and destructor.  Remove members.
2009         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
2010         (ravenscar_thread_target::store_registers)
2011         (ravenscar_thread_target::prepare_to_store): Update.
2012         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
2013         Remove.
2014         (struct ppc_ravenscar_powerpc_ops): Derive from
2015         ravenscar_arch_ops.
2016         (ppc_ravenscar_powerpc_ops::fetch_registers)
2017         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
2018         (ppc_ravenscar_powerpc_ops): Redefine.
2019         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
2020         (ppc_ravenscar_e500_ops::fetch_registers)
2021         (ppc_ravenscar_e500_ops::store_registers): Now methods.
2022         (ppc_ravenscar_e500_ops): Redefine.
2023         * aarch64-ravenscar-thread.c
2024         (aarch64_ravenscar_generic_prepare_to_store): Remove.
2025         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
2026         (aarch64_ravenscar_fetch_registers)
2027         (aarch64_ravenscar_store_registers): Now methods.
2028         (aarch64_ravenscar_ops): Redefine.
2029
2030 2019-02-15  Tom Tromey  <tromey@adacore.com>
2031
2032         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
2033         (ravenscar_thread_target::stopped_by_hw_breakpoint)
2034         (ravenscar_thread_target::stopped_by_watchpoint)
2035         (ravenscar_thread_target::stopped_data_address)
2036         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
2037
2038 2019-02-15  Tom Tromey  <tromey@adacore.com>
2039
2040         * ravenscar-thread.c: Fix some typos.
2041
2042 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2043             Tom Tromey  <tromey@adacore.com>
2044
2045         * ada-lang.c (ada_exception_sal): Change addr_string to a
2046         std::string.
2047         (create_ada_exception_catchpoint): Update.
2048
2049 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2050             Tom Tromey  <tromey@adacore.com>
2051
2052         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
2053         (bp_location_ops): Remove.
2054         (base_breakpoint_allocate_location): Update.
2055         (free_bp_location): Update.
2056         * ada-lang.c (class ada_catchpoint_location)
2057         <ada_catchpoint_location>: Remove ops parameter.
2058         (ada_catchpoint_location_dtor): Remove.
2059         (ada_catchpoint_location_ops): Remove.
2060         (allocate_location_exception): Update.
2061         * breakpoint.h (struct bp_location_ops): Remove.
2062         (class bp_location) <bp_location>: Remove bp_location_ops
2063         parameter.
2064         <~bp_location>: Add destructor.
2065         <ops>: Remove.
2066
2067 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
2068             Pedro Alves  <palves@redhat.com>
2069
2070         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
2071         'PATH_MAX'.
2072
2073 2019-02-14  David Michael  <fedora.dm0@gmail.com>
2074             Samuel Thibault  <samuel.thibault@gnu.org>
2075             Thomas Schwinge  <thomas@codesourcery.com>
2076
2077         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
2078         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
2079
2080 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
2081
2082         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
2083         (check_empty): Use "const char *".
2084
2085         * gnu-nat.c (gnu_nat_target::detach): Instead of
2086         'detach_inferior (pid)' call
2087         'detach_inferior (find_inferior_pid (pid))'.
2088
2089         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
2090         'nat/fork-inferior.o'.
2091         * gnu-nat.c: #include "nat/fork-inferior.h".
2092
2093         * gnu-nat.c (gnu_nat_target::detach): Instead of
2094         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
2095         * gnu-nat.h: #include "inf-child.h".
2096         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
2097         'i386_gnu_nat_target::fetch_registers'.
2098         (gnu_store_registers): Rename/move to
2099         'i386_gnu_nat_target::store_registers'.
2100
2101         * config/i386/nm-i386gnu.h: Don't "#include" any files.
2102         * gnu-nat.h (mach_thread_info): New function.
2103         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
2104
2105         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
2106
2107 2019-02-14  Frederic Konrad  <konrad@adacore.com>
2108
2109         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
2110
2111 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
2112
2113         * windows-nat.c (windows_add_thread): Add new parameter
2114         "main_thread_p" with default value set to false.  Update
2115         function documentation as well as all callers.
2116         (windows_delete_thread): Likewise.
2117         (fake_create_process): Update call to windows_add_thread.
2118         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
2119         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
2120         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
2121         call to windows_delete_thread.
2122
2123 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
2124
2125         * MAINTAINERS: Add Andrew Burgess as global maintainer.
2126
2127 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2128
2129         * symfile.c (find_separate_debug_file): Use canonical path of
2130         sysroot with child_path instead of gdb_sysroot if it is valid.
2131
2132 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2133
2134         * symfile.c (find_separate_debug_file): Use child_path to
2135         determine if an object file is under a sysroot.
2136
2137 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2138
2139         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
2140         unittests/child-path-selftests.c.
2141         * common/pathstuff.c (child_path): New function.
2142         * common/pathstuff.h (child_path): New prototype.
2143         * unittests/child-path-selftests.c: New file.
2144
2145 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2146
2147         * symfile.c (find_separate_debug_file): Look for separate debug
2148         files in debug directories under the sysroot.
2149
2150 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2151
2152         * symtab.h (struct minimal_symbol data_p): New const method.
2153         (struct minimal_symbol text_p): Likewise.
2154         * symtab.c (output_source_filename): Use file name style
2155         to print file name.
2156         (print_symbol_info): Likewise.
2157         (print_msymbol_info): Use address style to print addresses.
2158         Use function name style to print executable text symbols.
2159         (expand_symtab_containing_pc): Use data_p.
2160         (find_pc_sect_compunit_symtab): Likewise.
2161
2162 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2163
2164         * breakpoint.c (describe_other_breakpoints): Use address style
2165         to print addresses.
2166         (say_where): Likewise.
2167
2168 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2169
2170         * ada-typeprint.c (print_func_type): Print function name
2171         style to print function name.
2172         * c-typeprint.c (c_print_type_1): Likewise.
2173
2174 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
2175
2176         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
2177         for execve.
2178
2179 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2180
2181         * c-exp.y (direct_abs_decl): Use emplace_back to record the
2182         type_stack.
2183
2184 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
2185
2186         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
2187         TYPE_CODE_REF types.
2188
2189 2019-02-08  Jim Wilson  <jimw@sifive.com>
2190
2191         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
2192         (riscv_linux_fregset): New.
2193         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
2194
2195 2019-02-07  Tom Tromey  <tom@tromey.com>
2196
2197         * thread.c (thread_cancel_execution_command): Update.
2198         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
2199         methods.
2200         (struct thread_fsm_ops): Remove.
2201         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
2202         (thread_fsm_should_stop, thread_fsm_return_value)
2203         (thread_fsm_set_finished, thread_fsm_finished_p)
2204         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
2205         Don't declare.
2206         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
2207         * infrun.c (clear_proceed_status_thread)
2208         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
2209         (print_stop_event): Update.
2210         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
2211         Add constructor.
2212         (step_command_fsm_ops): Remove.
2213         (new_step_command_fsm): Remove.
2214         (step_1): Update.
2215         (step_command_fsm::should_stop): Rename from
2216         step_command_fsm_should_stop.
2217         (step_command_fsm::clean_up): Rename from
2218         step_command_fsm_clean_up.
2219         (step_command_fsm::do_async_reply_reason): Rename from
2220         step_command_fsm_async_reply_reason.
2221         (struct until_next_fsm): Inherit from thread_fsm.  Add
2222         constructor.
2223         (until_next_fsm_ops): Remove.
2224         (new_until_next_fsm): Remove.
2225         (until_next_fsm::should_stop): Rename from
2226         until_next_fsm_should_stop.
2227         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
2228         (until_next_fsm::do_async_reply_reason): Rename from
2229         until_next_fsm_async_reply_reason.
2230         (struct finish_command_fsm): Inherit from thread_fsm.  Add
2231         constructor.  Change type of breakpoint.
2232         (finish_command_fsm_ops): Remove.
2233         (new_finish_command_fsm): Remove.
2234         (finish_command_fsm::should_stop): Rename from
2235         finish_command_fsm_should_stop.
2236         (finish_command_fsm::clean_up): Rename from
2237         finish_command_fsm_clean_up.
2238         (finish_command_fsm::return_value): Rename from
2239         finish_command_fsm_return_value.
2240         (finish_command_fsm::do_async_reply_reason): Rename from
2241         finish_command_fsm_async_reply_reason.
2242         (finish_command): Update.
2243         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
2244         Add constructor.
2245         (call_thread_fsm_ops): Remove.
2246         (call_thread_fsm::call_thread_fsm): Rename from
2247         new_call_thread_fsm.
2248         (call_thread_fsm::should_stop): Rename from
2249         call_thread_fsm_should_stop.
2250         (call_thread_fsm::should_notify_stop): Rename from
2251         call_thread_fsm_should_notify_stop.
2252         (run_inferior_call, call_function_by_hand_dummy): Update.
2253         * cli/cli-interp.c (should_print_stop_to_console): Update.
2254         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
2255         Add constructor.  Change type of location_breakpoint,
2256         caller_breakpoint.
2257         (until_break_fsm_ops): Remove.
2258         (new_until_break_fsm): Remove.
2259         (until_break_fsm::should_stop): Rename from
2260         until_break_fsm_should_stop.
2261         (until_break_fsm::clean_up): Rename from
2262         until_break_fsm_clean_up.
2263         (until_break_fsm::do_async_reply_reason): Rename from
2264         until_break_fsm_async_reply_reason.
2265         (until_break_command): Update.
2266         * thread-fsm.c: Remove.
2267         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
2268
2269 2019-02-07  Tom Tromey  <tom@tromey.com>
2270
2271         * yy-remap.h: Add include guard.
2272         * xtensa-tdep.h: Add include guard.
2273         * xcoffread.h: Rename include guard.
2274         * varobj-iter.h: Add include guard.
2275         * tui/tui.h: Rename include guard.
2276         * tui/tui-winsource.h: Rename include guard.
2277         * tui/tui-wingeneral.h: Rename include guard.
2278         * tui/tui-windata.h: Rename include guard.
2279         * tui/tui-win.h: Rename include guard.
2280         * tui/tui-stack.h: Rename include guard.
2281         * tui/tui-source.h: Rename include guard.
2282         * tui/tui-regs.h: Rename include guard.
2283         * tui/tui-out.h: Rename include guard.
2284         * tui/tui-layout.h: Rename include guard.
2285         * tui/tui-io.h: Rename include guard.
2286         * tui/tui-hooks.h: Rename include guard.
2287         * tui/tui-file.h: Rename include guard.
2288         * tui/tui-disasm.h: Rename include guard.
2289         * tui/tui-data.h: Rename include guard.
2290         * tui/tui-command.h: Rename include guard.
2291         * tic6x-tdep.h: Add include guard.
2292         * target/waitstatus.h: Rename include guard.
2293         * target/wait.h: Rename include guard.
2294         * target/target.h: Rename include guard.
2295         * target/resume.h: Rename include guard.
2296         * target-float.h: Rename include guard.
2297         * stabsread.h: Add include guard.
2298         * rs6000-tdep.h: Add include guard.
2299         * riscv-fbsd-tdep.h: Add include guard.
2300         * regformats/regdef.h: Rename include guard.
2301         * record.h: Rename include guard.
2302         * python/python.h: Rename include guard.
2303         * python/python-internal.h: Rename include guard.
2304         * python/py-stopevent.h: Rename include guard.
2305         * python/py-ref.h: Rename include guard.
2306         * python/py-record.h: Rename include guard.
2307         * python/py-record-full.h: Rename include guard.
2308         * python/py-record-btrace.h: Rename include guard.
2309         * python/py-instruction.h: Rename include guard.
2310         * python/py-events.h: Rename include guard.
2311         * python/py-event.h: Rename include guard.
2312         * procfs.h: Add include guard.
2313         * proc-utils.h: Add include guard.
2314         * p-lang.h: Add include guard.
2315         * or1k-tdep.h: Rename include guard.
2316         * observable.h: Rename include guard.
2317         * nto-tdep.h: Rename include guard.
2318         * nat/x86-linux.h: Rename include guard.
2319         * nat/x86-linux-dregs.h: Rename include guard.
2320         * nat/x86-gcc-cpuid.h: Add include guard.
2321         * nat/x86-dregs.h: Rename include guard.
2322         * nat/x86-cpuid.h: Rename include guard.
2323         * nat/ppc-linux.h: Rename include guard.
2324         * nat/mips-linux-watch.h: Rename include guard.
2325         * nat/linux-waitpid.h: Rename include guard.
2326         * nat/linux-ptrace.h: Rename include guard.
2327         * nat/linux-procfs.h: Rename include guard.
2328         * nat/linux-osdata.h: Rename include guard.
2329         * nat/linux-nat.h: Rename include guard.
2330         * nat/linux-namespaces.h: Rename include guard.
2331         * nat/linux-btrace.h: Rename include guard.
2332         * nat/glibc_thread_db.h: Rename include guard.
2333         * nat/gdb_thread_db.h: Rename include guard.
2334         * nat/gdb_ptrace.h: Rename include guard.
2335         * nat/fork-inferior.h: Rename include guard.
2336         * nat/amd64-linux-siginfo.h: Rename include guard.
2337         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
2338         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
2339         * nat/aarch64-linux.h: Rename include guard.
2340         * nat/aarch64-linux-hw-point.h: Rename include guard.
2341         * mn10300-tdep.h: Add include guard.
2342         * mips-linux-tdep.h: Add include guard.
2343         * mi/mi-parse.h: Rename include guard.
2344         * mi/mi-out.h: Rename include guard.
2345         * mi/mi-main.h: Rename include guard.
2346         * mi/mi-interp.h: Rename include guard.
2347         * mi/mi-getopt.h: Rename include guard.
2348         * mi/mi-console.h: Rename include guard.
2349         * mi/mi-common.h: Rename include guard.
2350         * mi/mi-cmds.h: Rename include guard.
2351         * mi/mi-cmd-break.h: Rename include guard.
2352         * m2-lang.h: Add include guard.
2353         * location.h: Rename include guard.
2354         * linux-record.h: Rename include guard.
2355         * linux-nat.h: Add include guard.
2356         * linux-fork.h: Add include guard.
2357         * i386-darwin-tdep.h: Rename include guard.
2358         * hppa-linux-offsets.h: Add include guard.
2359         * guile/guile.h: Rename include guard.
2360         * guile/guile-internal.h: Rename include guard.
2361         * gnu-nat.h: Rename include guard.
2362         * gdb-stabs.h: Rename include guard.
2363         * frv-tdep.h: Add include guard.
2364         * f-lang.h: Add include guard.
2365         * event-loop.h: Add include guard.
2366         * darwin-nat.h: Rename include guard.
2367         * cp-abi.h: Rename include guard.
2368         * config/sparc/nm-sol2.h: Rename include guard.
2369         * config/nm-nto.h: Rename include guard.
2370         * config/nm-linux.h: Add include guard.
2371         * config/i386/nm-i386gnu.h: Rename include guard.
2372         * config/djgpp/nl_types.h: Rename include guard.
2373         * config/djgpp/langinfo.h: Rename include guard.
2374         * compile/gcc-cp-plugin.h: Add include guard.
2375         * compile/gcc-c-plugin.h: Add include guard.
2376         * compile/compile.h: Rename include guard.
2377         * compile/compile-object-run.h: Rename include guard.
2378         * compile/compile-object-load.h: Rename include guard.
2379         * compile/compile-internal.h: Rename include guard.
2380         * compile/compile-cplus.h: Rename include guard.
2381         * compile/compile-c.h: Rename include guard.
2382         * common/xml-utils.h: Rename include guard.
2383         * common/x86-xstate.h: Rename include guard.
2384         * common/version.h: Rename include guard.
2385         * common/vec.h: Rename include guard.
2386         * common/tdesc.h: Rename include guard.
2387         * common/selftest.h: Rename include guard.
2388         * common/scoped_restore.h: Rename include guard.
2389         * common/scoped_mmap.h: Rename include guard.
2390         * common/scoped_fd.h: Rename include guard.
2391         * common/safe-iterator.h: Rename include guard.
2392         * common/run-time-clock.h: Rename include guard.
2393         * common/refcounted-object.h: Rename include guard.
2394         * common/queue.h: Rename include guard.
2395         * common/ptid.h: Rename include guard.
2396         * common/print-utils.h: Rename include guard.
2397         * common/preprocessor.h: Rename include guard.
2398         * common/pathstuff.h: Rename include guard.
2399         * common/observable.h: Rename include guard.
2400         * common/netstuff.h: Rename include guard.
2401         * common/job-control.h: Rename include guard.
2402         * common/host-defs.h: Rename include guard.
2403         * common/gdb_wait.h: Rename include guard.
2404         * common/gdb_vecs.h: Rename include guard.
2405         * common/gdb_unlinker.h: Rename include guard.
2406         * common/gdb_unique_ptr.h: Rename include guard.
2407         * common/gdb_tilde_expand.h: Rename include guard.
2408         * common/gdb_sys_time.h: Rename include guard.
2409         * common/gdb_string_view.h: Rename include guard.
2410         * common/gdb_splay_tree.h: Rename include guard.
2411         * common/gdb_setjmp.h: Rename include guard.
2412         * common/gdb_ref_ptr.h: Rename include guard.
2413         * common/gdb_optional.h: Rename include guard.
2414         * common/gdb_locale.h: Rename include guard.
2415         * common/gdb_assert.h: Rename include guard.
2416         * common/filtered-iterator.h: Rename include guard.
2417         * common/filestuff.h: Rename include guard.
2418         * common/fileio.h: Rename include guard.
2419         * common/environ.h: Rename include guard.
2420         * common/common-utils.h: Rename include guard.
2421         * common/common-types.h: Rename include guard.
2422         * common/common-regcache.h: Rename include guard.
2423         * common/common-inferior.h: Rename include guard.
2424         * common/common-gdbthread.h: Rename include guard.
2425         * common/common-exceptions.h: Rename include guard.
2426         * common/common-defs.h: Rename include guard.
2427         * common/common-debug.h: Rename include guard.
2428         * common/cleanups.h: Rename include guard.
2429         * common/buffer.h: Rename include guard.
2430         * common/btrace-common.h: Rename include guard.
2431         * common/break-common.h: Rename include guard.
2432         * cli/cli-utils.h: Rename include guard.
2433         * cli/cli-style.h: Rename include guard.
2434         * cli/cli-setshow.h: Rename include guard.
2435         * cli/cli-script.h: Rename include guard.
2436         * cli/cli-interp.h: Rename include guard.
2437         * cli/cli-decode.h: Rename include guard.
2438         * cli/cli-cmds.h: Rename include guard.
2439         * charset-list.h: Add include guard.
2440         * buildsym-legacy.h: Rename include guard.
2441         * bfin-tdep.h: Add include guard.
2442         * ax.h: Rename include guard.
2443         * arm-linux-tdep.h: Add include guard.
2444         * arm-fbsd-tdep.h: Add include guard.
2445         * arch/xtensa.h: Rename include guard.
2446         * arch/tic6x.h: Add include guard.
2447         * arch/i386.h: Add include guard.
2448         * arch/arm.h: Rename include guard.
2449         * arch/arm-linux.h: Rename include guard.
2450         * arch/arm-get-next-pcs.h: Rename include guard.
2451         * arch/amd64.h: Add include guard.
2452         * arch/aarch64-insn.h: Rename include guard.
2453         * arch-utils.h: Rename include guard.
2454         * annotate.h: Add include guard.
2455         * amd64-darwin-tdep.h: Rename include guard.
2456         * aarch64-linux-tdep.h: Add include guard.
2457         * aarch64-fbsd-tdep.h: Add include guard.
2458         * aarch32-linux-nat.h: Add include guard.
2459
2460 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2461
2462         * macrotab.c (macro_define_internal): New function that
2463         factorizes macro_define_object_internal and macro_define_function
2464         code.
2465         (macro_define_object_internal): Use macro_define_internal.
2466         (macro_define_function): Likewise.
2467
2468 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2469
2470         * macrocmd.c (extract_identifier): Return
2471         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2472         callers.
2473
2474 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2475
2476         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2477
2478 2019-02-05  Tom Tromey  <tom@tromey.com>
2479
2480         * target.c (target_stack::unpush): Move assertion earlier.
2481
2482 2019-01-30  Tom Tromey  <tom@tromey.com>
2483
2484         PR python/23615:
2485         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2486         (gdbpy_parse_and_eval): Likewise.
2487         * python/python-internal.h (gdbpy_allow_threads): New class.
2488
2489 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2490
2491         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2492         (aarch64_fbsd_fpregmap): Move earlier.
2493         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2494         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2495         instead of individual calls to trad_frame_set_reg_addr.
2496         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2497         earlier.
2498         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2499         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2500         instead of individual calls to trad_frame_set_reg_addr.
2501
2502 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2503
2504         * CONTRIBUTE: Replace contribution list with wiki link.
2505
2506 2019-01-25  Tom Tromey  <tom@tromey.com>
2507
2508         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2509
2510 2019-01-25  Tom Tromey  <tom@tromey.com>
2511
2512         * xtensa-linux-nat.c: Fix common/ includes.
2513         * xml-support.h: Fix common/ includes.
2514         * xml-support.c: Fix common/ includes.
2515         * x86-linux-nat.c: Fix common/ includes.
2516         * windows-nat.c: Fix common/ includes.
2517         * varobj.h: Fix common/ includes.
2518         * varobj.c: Fix common/ includes.
2519         * value.c: Fix common/ includes.
2520         * valops.c: Fix common/ includes.
2521         * utils.c: Fix common/ includes.
2522         * unittests/xml-utils-selftests.c: Fix common/ includes.
2523         * unittests/utils-selftests.c: Fix common/ includes.
2524         * unittests/unpack-selftests.c: Fix common/ includes.
2525         * unittests/tracepoint-selftests.c: Fix common/ includes.
2526         * unittests/style-selftests.c: Fix common/ includes.
2527         * unittests/string_view-selftests.c: Fix common/ includes.
2528         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2529         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2530         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2531         * unittests/rsp-low-selftests.c: Fix common/ includes.
2532         * unittests/parse-connection-spec-selftests.c: Fix common/
2533         includes.
2534         * unittests/optional-selftests.c: Fix common/ includes.
2535         * unittests/offset-type-selftests.c: Fix common/ includes.
2536         * unittests/observable-selftests.c: Fix common/ includes.
2537         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2538         * unittests/memrange-selftests.c: Fix common/ includes.
2539         * unittests/memory-map-selftests.c: Fix common/ includes.
2540         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2541         * unittests/function-view-selftests.c: Fix common/ includes.
2542         * unittests/environ-selftests.c: Fix common/ includes.
2543         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2544         * unittests/common-utils-selftests.c: Fix common/ includes.
2545         * unittests/cli-utils-selftests.c: Fix common/ includes.
2546         * unittests/array-view-selftests.c: Fix common/ includes.
2547         * ui-file.c: Fix common/ includes.
2548         * tui/tui-io.c: Fix common/ includes.
2549         * tracepoint.h: Fix common/ includes.
2550         * tracepoint.c: Fix common/ includes.
2551         * tracefile-tfile.c: Fix common/ includes.
2552         * top.h: Fix common/ includes.
2553         * top.c: Fix common/ includes.
2554         * thread.c: Fix common/ includes.
2555         * target/waitstatus.h: Fix common/ includes.
2556         * target/waitstatus.c: Fix common/ includes.
2557         * target.h: Fix common/ includes.
2558         * target.c: Fix common/ includes.
2559         * target-memory.c: Fix common/ includes.
2560         * target-descriptions.c: Fix common/ includes.
2561         * symtab.h: Fix common/ includes.
2562         * symfile.c: Fix common/ includes.
2563         * stap-probe.c: Fix common/ includes.
2564         * spu-linux-nat.c: Fix common/ includes.
2565         * sparc-nat.c: Fix common/ includes.
2566         * source.c: Fix common/ includes.
2567         * solib.c: Fix common/ includes.
2568         * solib-target.c: Fix common/ includes.
2569         * ser-unix.c: Fix common/ includes.
2570         * ser-tcp.c: Fix common/ includes.
2571         * ser-pipe.c: Fix common/ includes.
2572         * ser-base.c: Fix common/ includes.
2573         * selftest-arch.c: Fix common/ includes.
2574         * s12z-tdep.c: Fix common/ includes.
2575         * rust-exp.y: Fix common/ includes.
2576         * rs6000-aix-tdep.c: Fix common/ includes.
2577         * riscv-tdep.c: Fix common/ includes.
2578         * remote.c: Fix common/ includes.
2579         * remote-notif.h: Fix common/ includes.
2580         * remote-fileio.h: Fix common/ includes.
2581         * remote-fileio.c: Fix common/ includes.
2582         * regcache.h: Fix common/ includes.
2583         * regcache.c: Fix common/ includes.
2584         * record-btrace.c: Fix common/ includes.
2585         * python/python.c: Fix common/ includes.
2586         * python/py-type.c: Fix common/ includes.
2587         * python/py-inferior.c: Fix common/ includes.
2588         * progspace.h: Fix common/ includes.
2589         * producer.c: Fix common/ includes.
2590         * procfs.c: Fix common/ includes.
2591         * proc-api.c: Fix common/ includes.
2592         * printcmd.c: Fix common/ includes.
2593         * ppc-linux-nat.c: Fix common/ includes.
2594         * parser-defs.h: Fix common/ includes.
2595         * osdata.c: Fix common/ includes.
2596         * obsd-nat.c: Fix common/ includes.
2597         * nat/x86-linux.c: Fix common/ includes.
2598         * nat/x86-linux-dregs.c: Fix common/ includes.
2599         * nat/x86-dregs.h: Fix common/ includes.
2600         * nat/x86-dregs.c: Fix common/ includes.
2601         * nat/ppc-linux.c: Fix common/ includes.
2602         * nat/mips-linux-watch.h: Fix common/ includes.
2603         * nat/mips-linux-watch.c: Fix common/ includes.
2604         * nat/linux-waitpid.c: Fix common/ includes.
2605         * nat/linux-ptrace.h: Fix common/ includes.
2606         * nat/linux-ptrace.c: Fix common/ includes.
2607         * nat/linux-procfs.c: Fix common/ includes.
2608         * nat/linux-personality.c: Fix common/ includes.
2609         * nat/linux-osdata.c: Fix common/ includes.
2610         * nat/linux-namespaces.c: Fix common/ includes.
2611         * nat/linux-btrace.h: Fix common/ includes.
2612         * nat/linux-btrace.c: Fix common/ includes.
2613         * nat/fork-inferior.c: Fix common/ includes.
2614         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2615         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2616         * nat/aarch64-linux.c: Fix common/ includes.
2617         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2618         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2619         * namespace.h: Fix common/ includes.
2620         * mips-linux-tdep.c: Fix common/ includes.
2621         * minsyms.c: Fix common/ includes.
2622         * mi/mi-parse.h: Fix common/ includes.
2623         * mi/mi-main.c: Fix common/ includes.
2624         * mi/mi-cmd-env.c: Fix common/ includes.
2625         * memrange.h: Fix common/ includes.
2626         * memattr.c: Fix common/ includes.
2627         * maint.h: Fix common/ includes.
2628         * maint.c: Fix common/ includes.
2629         * main.c: Fix common/ includes.
2630         * machoread.c: Fix common/ includes.
2631         * location.c: Fix common/ includes.
2632         * linux-thread-db.c: Fix common/ includes.
2633         * linux-nat.c: Fix common/ includes.
2634         * linux-fork.c: Fix common/ includes.
2635         * inline-frame.c: Fix common/ includes.
2636         * infrun.c: Fix common/ includes.
2637         * inflow.c: Fix common/ includes.
2638         * inferior.h: Fix common/ includes.
2639         * inferior.c: Fix common/ includes.
2640         * infcmd.c: Fix common/ includes.
2641         * inf-ptrace.c: Fix common/ includes.
2642         * inf-child.c: Fix common/ includes.
2643         * ia64-linux-nat.c: Fix common/ includes.
2644         * i387-tdep.c: Fix common/ includes.
2645         * i386-tdep.c: Fix common/ includes.
2646         * i386-linux-tdep.c: Fix common/ includes.
2647         * i386-linux-nat.c: Fix common/ includes.
2648         * i386-go32-tdep.c: Fix common/ includes.
2649         * i386-fbsd-tdep.c: Fix common/ includes.
2650         * i386-fbsd-nat.c: Fix common/ includes.
2651         * guile/scm-type.c: Fix common/ includes.
2652         * guile/guile.c: Fix common/ includes.
2653         * go32-nat.c: Fix common/ includes.
2654         * gnu-nat.c: Fix common/ includes.
2655         * gdbthread.h: Fix common/ includes.
2656         * gdbarch-selftests.c: Fix common/ includes.
2657         * gdb_usleep.c: Fix common/ includes.
2658         * gdb_select.h: Fix common/ includes.
2659         * gdb_bfd.c: Fix common/ includes.
2660         * gcore.c: Fix common/ includes.
2661         * fork-child.c: Fix common/ includes.
2662         * findvar.c: Fix common/ includes.
2663         * fbsd-nat.c: Fix common/ includes.
2664         * event-top.c: Fix common/ includes.
2665         * event-loop.c: Fix common/ includes.
2666         * dwarf2read.c: Fix common/ includes.
2667         * dwarf2loc.c: Fix common/ includes.
2668         * dwarf2-frame.c: Fix common/ includes.
2669         * dwarf-index-cache.c: Fix common/ includes.
2670         * dtrace-probe.c: Fix common/ includes.
2671         * disasm-selftests.c: Fix common/ includes.
2672         * defs.h: Fix common/ includes.
2673         * csky-tdep.c: Fix common/ includes.
2674         * cp-valprint.c: Fix common/ includes.
2675         * cp-support.h: Fix common/ includes.
2676         * cp-support.c: Fix common/ includes.
2677         * corelow.c: Fix common/ includes.
2678         * completer.h: Fix common/ includes.
2679         * completer.c: Fix common/ includes.
2680         * compile/compile.c: Fix common/ includes.
2681         * compile/compile-loc2c.c: Fix common/ includes.
2682         * compile/compile-cplus-types.c: Fix common/ includes.
2683         * compile/compile-cplus-symbols.c: Fix common/ includes.
2684         * command.h: Fix common/ includes.
2685         * cli/cli-dump.c: Fix common/ includes.
2686         * cli/cli-cmds.c: Fix common/ includes.
2687         * charset.c: Fix common/ includes.
2688         * build-id.c: Fix common/ includes.
2689         * btrace.h: Fix common/ includes.
2690         * btrace.c: Fix common/ includes.
2691         * breakpoint.h: Fix common/ includes.
2692         * breakpoint.c: Fix common/ includes.
2693         * ax.h:
2694         (enum agent_op): Fix common/ includes.
2695         * ax-general.c (struct aop_map): Fix common/ includes.
2696         * ax-gdb.c: Fix common/ includes.
2697         * auxv.c: Fix common/ includes.
2698         * auto-load.c: Fix common/ includes.
2699         * arm-tdep.c: Fix common/ includes.
2700         * arch/riscv.c: Fix common/ includes.
2701         * arch/ppc-linux-common.c: Fix common/ includes.
2702         * arch/i386.c: Fix common/ includes.
2703         * arch/arm.c: Fix common/ includes.
2704         * arch/arm-linux.c: Fix common/ includes.
2705         * arch/arm-get-next-pcs.c: Fix common/ includes.
2706         * arch/amd64.c: Fix common/ includes.
2707         * arch/aarch64.c: Fix common/ includes.
2708         * arch/aarch64-insn.c: Fix common/ includes.
2709         * arch-utils.c: Fix common/ includes.
2710         * amd64-windows-tdep.c: Fix common/ includes.
2711         * amd64-tdep.c: Fix common/ includes.
2712         * amd64-sol2-tdep.c: Fix common/ includes.
2713         * amd64-obsd-tdep.c: Fix common/ includes.
2714         * amd64-nbsd-tdep.c: Fix common/ includes.
2715         * amd64-linux-tdep.c: Fix common/ includes.
2716         * amd64-linux-nat.c: Fix common/ includes.
2717         * amd64-fbsd-tdep.c: Fix common/ includes.
2718         * amd64-fbsd-nat.c: Fix common/ includes.
2719         * amd64-dicos-tdep.c: Fix common/ includes.
2720         * amd64-darwin-tdep.c: Fix common/ includes.
2721         * agent.c: Fix common/ includes.
2722         * ada-lang.h: Fix common/ includes.
2723         * ada-lang.c: Fix common/ includes.
2724         * aarch64-tdep.c: Fix common/ includes.
2725
2726 2019-01-25  Tom Tromey  <tom@tromey.com>
2727
2728         * common/create-version.sh: Use common/version.h.
2729
2730 2019-01-24  Pedro Alves  <palves@redhat.com>
2731
2732         * infrun.c (signal_stop, signal_print, signal_program)
2733         (signal_catch, signal_pass): Now arrays instead of pointers.
2734         (update_signals_program_target, do_target_resume)
2735         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2736         * linux-nat.c (linux_nat_target::pass_signals)
2737         (linux_nat_target::create_inferior, linux_nat_target::attach):
2738         Adjust.
2739         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2740         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2741         * procfs.c (procfs_target::pass_signals): Adjust.
2742         * record-full.c (record_full_target::resume): Adjust.
2743         * remote.c (remote_target::pass_signals)
2744         (remote_target::program_signals): Adjust.
2745         * target-debug.h (target_debug_print_signals): Now takes a
2746         gdb::array_view as parameter.  Adjust.
2747         * target.h (target_ops) <pass_signals, program_signals>: Replace
2748         pointer and length parameters with gdb::array_view.
2749         (target_pass_signals, target_program_signals): Likewise.
2750         * target-delegates.c: Regenerate.
2751
2752 2019-01-24  Pedro Alves  <palves@redhat.com>
2753
2754         * common/forward-scope-exit.h
2755         (forward_scope_exit::forward_scope_exit): Pass arguments to
2756         m_bind_function directly, instead of creating a std::bind and
2757         copying that.
2758
2759 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2760
2761         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2762         for static members.
2763         (pass_in_v_vfp_candidate): Likewise.
2764
2765 2019-01-23  Tom Tromey  <tom@tromey.com>
2766             Pedro Alves  <palves@redhat.com>
2767
2768         * regcache.c (class regcache_invalidator): Remove.
2769         (regcache::raw_write): Use make_scope_exit.
2770
2771 2019-01-23  Tom Tromey  <tom@tromey.com>
2772
2773         * ui-out.h (class ui_out_emit_type): Update comment.
2774
2775 2019-01-23  Tom Tromey  <tom@tromey.com>
2776
2777         * infrun.c (fetch_inferior_event): Update comment.
2778
2779 2019-01-23  Tom Tromey  <tom@tromey.com>
2780             Pedro Alves  <palves@redhat.com>
2781
2782         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2783         parameter.
2784         (fetch_inferior_event): Use SCOPE_EXIT.
2785
2786
2787 2019-01-23  Tom Tromey  <tom@tromey.com>
2788             Pedro Alves  <palves@redhat.com>
2789
2790         * infrun.c (disable_thread_events): Delete.
2791         (stop_all_threads): Use SCOPE_EXIT.
2792
2793 2019-01-23  Tom Tromey  <tom@tromey.com>
2794             Pedro Alves  <palves@redhat.com>
2795
2796         * symfile.c: Include forward-scope-exit.h.
2797         (clear_symtab_users_cleanup): Replace forward declaration with
2798         a FORWARD_SCOPE_EXIT.
2799         (syms_from_objfile_1): Use the forward_scope_exit and
2800         gdb::optional instead of cleanup_function.
2801         (reread_symbols): Use the forward_scope_exit instead of
2802         cleanup_function.
2803         (clear_symtab_users_cleanup): Remove function.
2804
2805 2019-01-23  Tom Tromey  <tom@tromey.com>
2806             Pedro Alves  <palves@redhat.com>
2807
2808         * linux-nat.c: Include scope-exit.h.
2809         (cleanup_target_stop): Remove.
2810         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2811         SCOPE_EXIT.
2812
2813 2019-01-23  Tom Tromey  <tom@tromey.com>
2814             Pedro Alves  <palves@redhat.com>
2815
2816         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2817         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2818
2819 2019-01-23  Tom Tromey  <tom@tromey.com>
2820             Andrew Burgess  <andrew.burgess@embecosm.com>
2821             Pedro Alves  <palves@redhat.com>
2822
2823         * infrun.c (fetch_inferior_event): Use scope_exit.
2824         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2825         * top.c (execute_command): Use scope_exit.
2826         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2827         * utils.c (do_bpstat_clear_actions_cleanup)
2828         (make_bpstat_clear_actions_cleanup): Remove.
2829
2830 2019-01-23  Tom Tromey  <tom@tromey.com>
2831             Pedro Alves  <palves@redhat.com>
2832
2833         * infrun.c: Include "common/scope-exit.h"
2834         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2835         (wait_for_inferior): Use SCOPE_EXIT.
2836         (fetch_inferior_event): Use scope_exit.
2837
2838 2019-01-23  Tom Tromey  <tom@tromey.com>
2839             Pedro Alves  <palves@redhat.com>
2840
2841         * breakpoint.c (create_breakpoint): Remove cleanup.
2842
2843 2019-01-23  Tom Tromey  <tom@tromey.com>
2844             Andrew Burgess  <andrew.burgess@embecosm.com>
2845             Pedro Alves  <palves@redhat.com>
2846
2847 2019-01-23  Pedro Alves  <palves@redhat.com>
2848
2849         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2850
2851 2019-01-23  Pedro Alves  <palves@redhat.com>
2852             Andrew Burgess  <andrew.burgess@embecosm.com>
2853
2854         * gdbthread.h: Include "common/forward-scope-exit.h".
2855         (scoped_finish_thread_state): Redefine custom class in terms of
2856         forward_scope_exit.
2857
2858 2019-01-23  Pedro Alves  <palves@redhat.com>
2859             Andrew Burgess  <andrew.burgess@embecosm.com>
2860
2861         * common/forward-scope-exit.h: New file.
2862
2863 2019-01-23  Pedro Alves  <palves@redhat.com>
2864             Andrew Burgess  <andrew.burgess@embecosm.com>
2865             Tom Tromey  <tom@tromey.com>
2866
2867         * common/scope-exit.h: New file.
2868
2869 2019-01-23  Pedro Alves  <palves@redhat.com>
2870
2871         * common/preprocessor.h (ESC): Rename to ...
2872         (ESC_PARENS): ... this.
2873         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2874         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2875
2876 2019-01-23  Tom Tromey  <tom@tromey.com>
2877
2878         * language.h (class scoped_switch_to_sym_language_if_auto):
2879         Initialize m_lang in both cases.
2880
2881 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2882
2883         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2884         with XCNEW.
2885
2886 2019-01-22  Tom Tromey  <tom@tromey.com>
2887
2888         * corelow.c: Do not include sys/file.h.
2889
2890 2019-01-22  Tom Tromey  <tom@tromey.com>
2891
2892         * tui/tui-wingeneral.h: Include gdb_curses.h.
2893
2894 2019-01-22  Tom Tromey  <tom@tromey.com>
2895
2896         * source-cache.h (class source_cache) <get_source_lines,
2897         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2898
2899 2019-01-22  Tom Tromey  <tom@tromey.com>
2900
2901         * remote-fileio.h (struct remote_target): Declare.
2902
2903 2019-01-22  Tom Tromey  <tom@tromey.com>
2904
2905         * python/py-arch.c: Do not include py-ref.h.
2906         * python/py-bpevent.c: Do not include py-ref.h.
2907         * python/py-cmd.c: Do not include py-ref.h.
2908         * python/py-continueevent.c: Do not include py-ref.h.
2909         * python/py-event.h: Do not include py-ref.h.
2910         * python/py-evtregistry.c: Do not include py-ref.h.
2911         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2912         * python/py-frame.c: Do not include py-ref.h.
2913         * python/py-framefilter.c: Do not include py-ref.h.
2914         * python/py-function.c: Do not include py-ref.h.
2915         * python/py-infevents.c: Do not include py-ref.h.
2916         * python/py-linetable.c: Do not include py-ref.h.
2917         * python/py-objfile.c: Do not include py-ref.h.
2918         * python/py-param.c: Do not include py-ref.h.
2919         * python/py-prettyprint.c: Do not include py-ref.h.
2920         * python/py-progspace.c: Do not include py-ref.h.
2921         * python/py-symbol.c: Do not include py-ref.h.
2922         * python/py-symtab.c: Do not include py-ref.h.
2923         * python/py-type.c: Do not include py-ref.h.
2924         * python/py-unwind.c: Do not include py-ref.h.
2925         * python/py-utils.c: Do not include py-ref.h.
2926         * python/py-value.c: Do not include py-ref.h.
2927         * python/py-varobj.c: Do not include py-ref.h.
2928         * python/py-xmethods.c: Do not include py-ref.h.
2929         * python/python.c: Do not include py-ref.h.
2930         * varobj.c: Do not include py-ref.h.
2931
2932 2019-01-22  Tom Tromey  <tom@tromey.com>
2933
2934         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2935         keyword for bcache.
2936
2937 2019-01-22  Tom Tromey  <tom@tromey.com>
2938
2939         * compile/compile-cplus-types.c: Remove a comment by #include.
2940
2941 2019-01-22  Tom Tromey  <tom@tromey.com>
2942
2943         * compile/gcc-c-plugin.h: Include compile-internal.h.
2944
2945 2019-01-22  Tom Tromey  <tom@tromey.com>
2946
2947         * stabsread.c (EXTERN): Do not define.
2948         (symnum, next_symbol_text_func, processing_gcc_compilation)
2949         (within_function, global_sym_chain, global_stabs)
2950         (previous_stab_code, this_object_header_files)
2951         (n_this_object_header_files)
2952         (n_allocated_this_object_header_files): Define.
2953         * stabsread.h (EXTERN): Never define.  Use "extern".
2954
2955 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2956
2957         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2958         history_value.
2959
2960 2019-01-21  Tom Tromey  <tom@tromey.com>
2961
2962         * ui-out.c: Fix includes.
2963         * tui/tui-source.c: Fix includes.
2964         * target.c: Fix includes.
2965         * remote.c: Fix includes.
2966         * regcache.c: Fix includes.
2967         * python/py-block.c: Fix includes.
2968         * printcmd.c: Fix includes.
2969         * or1k-tdep.c: Fix includes.
2970         * mi/mi-main.c: Fix includes.
2971         * m32r-tdep.c: Fix includes.
2972         * csky-tdep.c: Fix includes.
2973         * compile/compile-cplus-types.c: Fix includes.
2974         * cli/cli-interp.c: Fix includes.
2975
2976 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2977
2978         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2979         for padding.
2980
2981 2019-01-16  Tom Tromey  <tom@tromey.com>
2982
2983         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2984         earlier.
2985         (struct objfile) <msymbols_range>: Move from top level.
2986         <msymbols>: New method.
2987         (class objfile_msymbols): Remove.
2988         * symtab.c (default_collect_symbol_completion_matches_break_on):
2989         Update.
2990         * symmisc.c (dump_msymbols): Update.
2991         * stabsread.c (scan_file_globals): Update.
2992         * objc-lang.c (info_selectors_command, info_classes_command)
2993         (find_methods): Update.
2994         * minsyms.c (find_solib_trampoline_target): Update.
2995         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2996         * coffread.c (coff_symfile_read): Update.
2997         * ada-lang.c (ada_lookup_simple_minsym)
2998         (ada_collect_symbol_completion_matches): Update.
2999
3000 2019-01-16  Tom Tromey  <tom@tromey.com>
3001
3002         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
3003         type.  Remove no-argument constructor.
3004         <iterator::operator++>: Simplify.
3005         <begin>: Update.
3006         <end>: Use minimal_symbol_count.
3007
3008 2019-01-16  Tom Tromey  <tom@tromey.com>
3009
3010         * objfiles.h (struct objfile) <psymtabs>: New method.
3011         (class objfile_psymtabs): Remove.
3012         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
3013         typedef.
3014         <range>: New method.
3015         (require_partial_symbols): Change return type.
3016         * psymtab.c (require_partial_symbols)
3017         (psym_expand_symtabs_matching): Update.
3018         * mdebugread.c (parse_partial_symbols): Update.
3019         * dbxread.c (dbx_end_psymtab): Update.
3020
3021 2019-01-15  Tom Tromey  <tom@tromey.com>
3022
3023         * symtab.c (lookup_objfile_from_block)
3024         (lookup_symbol_in_objfile_symtabs)
3025         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
3026         (find_line_symtab, info_sources_command)
3027         (default_collect_symbol_completion_matches_break_on)
3028         (make_source_files_completion_list): Update.
3029         * symmisc.c (print_objfile_statistics, dump_objfile)
3030         (maintenance_print_symbols, maintenance_info_symtabs)
3031         (maintenance_check_symtabs, maintenance_info_line_tables):
3032         Update.
3033         * source.c (select_source_symtab)
3034         (forget_cached_source_info_for_objfile): Update.
3035         * objfiles.h (class objfile_compunits): Remove.
3036         (struct objfile) <compunits_range>: New typedef.
3037         (compunits): New method.
3038         * objfiles.c (objfile_relocate1): Update.
3039         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
3040         * maint.c (count_symtabs_and_blocks): Update.
3041         * linespec.c (iterate_over_all_matching_symtabs): Update.
3042         * cp-support.c (add_symbol_overload_list_qualified): Update.
3043         * coffread.c (coff_symtab_read): Update.
3044         * ada-lang.c (add_nonlocal_symbols)
3045         (ada_collect_symbol_completion_matches)
3046         (ada_add_global_exceptions): Update.
3047
3048 2019-01-15  Tom Tromey  <tom@tromey.com>
3049
3050         * progspace.h (program_space) <objfiles_safe_range>: New
3051         typedef.
3052         <objfiles_safe>: New method.
3053         * objfiles.h (class all_objfiles_safe): Remove.
3054         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
3055         * jit.c (jit_inferior_exit_hook): Update.
3056
3057 2019-01-17  Tom Tromey  <tom@tromey.com>
3058
3059         * progspace.h (program_space) <objfiles_range>: New typedef.
3060         <objfiles>: New method.
3061         <objfiles_head>: Rename from objfiles.
3062         (object_files): Update.
3063         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
3064         * guile/scm-pretty-print.c
3065         (ppscm_find_pretty_printer_from_objfiles): Update.
3066         * guile/scm-objfile.c (gdbscm_objfiles): Update.
3067         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
3068         Update.
3069         * python/py-progspace.c (pspy_get_objfiles): Update.
3070         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3071         Update.
3072         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3073         (objfpy_lookup_objfile_by_build_id): Update.
3074         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
3075         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3076         Update.
3077         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3078         (expand_symtab_containing_pc, lookup_objfile_from_block)
3079         (lookup_static_symbol, basic_lookup_transparent_type)
3080         (find_pc_sect_compunit_symtab, find_symbol_at_address)
3081         (find_line_symtab, info_sources_command)
3082         (default_collect_symbol_completion_matches_break_on)
3083         (make_source_files_completion_list, find_main_name): Update.
3084         * symmisc.c (print_symbol_bcache_statistics)
3085         (print_objfile_statistics, maintenance_print_symbols)
3086         (maintenance_print_msymbols, maintenance_print_objfiles)
3087         (maintenance_info_symtabs, maintenance_check_symtabs)
3088         (maintenance_expand_symtabs, maintenance_info_line_tables):
3089         Update.
3090         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
3091         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
3092         (map_overlay_command, unmap_overlay_command)
3093         (simple_overlay_update, expand_symtabs_matching)
3094         (map_symbol_filenames): Update.
3095         * symfile-debug.c (set_debug_symfile): Update.
3096         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
3097         Update.
3098         * source.c (select_source_symtab, forget_cached_source_info):
3099         Update.
3100         * solib.c (solib_read_symbols): Update.
3101         * solib-spu.c (append_ocl_sos): Update.
3102         * psymtab.c (maintenance_print_psymbols)
3103         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
3104         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
3105         * printcmd.c (info_symbol_command): Update.
3106         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
3107         Update.
3108         * objfiles.h (class all_objfiles): Remove.
3109         * objfiles.c (have_partial_symbols, have_full_symbols)
3110         (have_minimal_symbols, qsort_cmp, update_section_map)
3111         (shared_objfile_contains_address_p)
3112         (default_iterate_over_objfiles_in_search_order): Update.
3113         * objc-lang.c (info_selectors_command, info_classes_command)
3114         (find_methods): Update.
3115         * minsyms.c (find_solib_trampoline_target): Update.
3116         * maint.c (maintenance_info_sections)
3117         (maintenance_translate_address, count_symtabs_and_blocks):
3118         Update.
3119         * main.c (captured_main_1): Update.
3120         * linux-thread-db.c (try_thread_db_load_from_pdir)
3121         (has_libpthread): Update.
3122         * linespec.c (iterate_over_all_matching_symtabs)
3123         (search_minsyms_for_name): Update.
3124         * jit.c (jit_find_objf_with_entry_addr): Update.
3125         * hppa-tdep.c (find_unwind_entry)
3126         (hppa_lookup_stub_minimal_symbol): Update.
3127         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
3128         Update.
3129         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3130         (elf_gnu_ifunc_resolve_by_got): Update.
3131         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
3132         * dwarf-index-write.c (save_gdb_index_command): Update.
3133         * cp-support.c (add_symbol_overload_list_qualified): Update.
3134         * breakpoint.c (create_overlay_event_breakpoint)
3135         (create_longjmp_master_breakpoint)
3136         (create_std_terminate_master_breakpoint)
3137         (create_exception_master_breakpoint): Update.
3138         * blockframe.c (find_pc_partial_function): Update.
3139         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
3140         (ada_collect_symbol_completion_matches)
3141         (ada_add_global_exceptions): Update.
3142
3143 2019-01-17  Tom Tromey  <tom@tromey.com>
3144
3145         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
3146         declare VEC.
3147         (solib_target_parse_libraries): Change return type.
3148         (library_list_start_segment, library_list_start_section)
3149         (library_list_end_library, library_list_start_library); Update.
3150         (solib_target_free_library_list): Remove.
3151         (solib_target_parse_libraries): Remove cleanup.  Change return
3152         type.
3153         (solib_target_current_sos): Update.
3154
3155 2019-01-17  Tom Tromey  <tromey@bapiya>
3156
3157         * valprint.c: Replace "the the" with "the".
3158         * symtab.c: Replace "the the" with "the".
3159         * solib.c: Replace "the the" with "the".
3160         * solib-dsbt.c: Replace "the the" with "the".
3161         * linespec.c: Replace "the the" with "the".
3162         * dwarf2loc.h: Replace "the the" with "the".
3163         * amd64-windows-tdep.c: Replace "the the" with "the".
3164         * aarch64-tdep.c: Replace "the the" with "the".
3165
3166 2019-01-16  Keith Seitz  <keiths@redhat.com>
3167
3168         PR gdb/23773
3169         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
3170         <builder>: Rename to ..
3171         <m_builder>: ... this and make private.
3172         (dwarf2_cu::get_builder): New method.  Change all users of
3173         `builder' to use this method.
3174         (dwarf2_start_symtab): Move to ...
3175         (dwarf2_cu::start_symtab): ... here.  Update all callers
3176         (setup_type_unit_groups): Move to ...
3177         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
3178         callers.
3179         (dwarf2_cu::reset_builder): New method.
3180         (process_full_compunit, process_full_type_unit): Use
3181         dwarf2_cu::reset_builder.
3182         (follow_die_offset): Record the ancestor CU if it is different
3183         from the followed DIE's CU.
3184         (follow_die_sig_1): Likewise.
3185
3186 2019-01-15  Tom Tromey  <tom@tromey.com>
3187
3188         * remote.c (class remote_state) <buf>: Now a char_vector.
3189         <buf_size>: Remove.
3190         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
3191         parameter.
3192         (remote_target::getpkt_or_notif_sane_1)
3193         (remote_target::getpkt_sane)
3194         (remote_target::getpkt_or_notif_sane): Likewise.
3195         (class remote_target) <putpkt>: New overload.
3196         (remote_target::read_frame): Change type of "buf_p".  Remove
3197         sizeof_p parameter.
3198         (packet_ok): New overload.
3199         (packet_check_result): New overload.
3200         Update all uses.
3201
3202 2019-01-14  Tom Tromey  <tom@tromey.com>
3203
3204         * remote-notif.c (handle_notification, remote_notif_ack)
3205         (remote_notif_parse): Make "buf" const.
3206         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
3207         const.
3208         (remote_notif_parse, remote_notif_ack, handle_notification):
3209         Likewise.
3210         * remote.c (remote_notif_stop_parse): Make "buf" const.
3211         (remote_target::remote_parse_stop_reply): Make "buf" const.
3212         (remote_notif_stop_ack): Make "buf" const.
3213
3214 2019-01-14  Tom Tromey  <tom@tromey.com>
3215
3216         * remote.c (remote_console_output): Make parameter const.
3217
3218 2019-01-14  Tom Tromey  <tom@tromey.com>
3219
3220         * target-debug.h (target_debug_print_signals): Constify.
3221         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
3222         * procfs.c (procfs_target::pass_signals): Update.
3223         * linux-nat.c (linux_nat_target::pass_signals): Update.
3224         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
3225         * target-delegates.c: Rebuild.
3226         * remote.c (remote_target::program_signals): Update.
3227         (remote_target::pass_signals): Update.
3228         * target.c (target_pass_signals): Constify argument.
3229         (target_program_signals): Likewise.
3230         * target.h (struct target_ops) <pass_signals, program_signals>:
3231         Constify argument.
3232         (target_pass_signals, target_program_signals): Constify argument.
3233
3234 2019-01-14  Tom Tromey  <tom@tromey.com>
3235
3236         PR tui/28819:
3237         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
3238
3239 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3240
3241         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
3242         field.
3243         * rs6000-tdep.c: Include reggroups.h.
3244         (IS_V_ALIAS_PSEUDOREG): Define.
3245         (rs6000_register_name): Return names for the "vX" aliases.
3246         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
3247         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
3248         aliases.  Call default_register_reggroup_p for all other
3249         pseudo-registers.
3250         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
3251         New functions.
3252         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
3253         Handle "vX" aliases.
3254         (v_alias_pseudo_register_collect): New function.
3255         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
3256         (rs6000_gdbarch_init): Initialize "vX" aliases as
3257         pseudo-registers.  Restore registration of
3258         rs6000_pseudo_register_reggroup_p with
3259         set_tdesc_pseudo_register_reggroup_p.
3260
3261 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
3262
3263         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
3264         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
3265         set_gdbarch_num_pseudo_regs.
3266
3267 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3268
3269         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
3270         Remove arg prefixname, add do_set and do_show.
3271         Add member functions set_list and show_list.
3272         * cli/cli-style.c (class cli_style_option): Update accordingly.
3273         (style_set_list): Move to file scope.
3274         (style_show_list): Likewise.
3275         (set_style): Call help_list.
3276         (show_style): Call cmd_show_list.
3277         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
3278         Update to use the new macro.
3279
3280 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
3281
3282         * ada-lang.c (_initialize_ada_language): Expand the help text
3283         for the "catch exception" command.
3284
3285 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3286
3287         * symtab.c (matching_obj_sections): Initialize obj,
3288         declare it closer to its usage.
3289
3290 2019-01-10  Tom Tromey  <tom@tromey.com>
3291
3292         * thread-iter.h (inf_threads_iterator): Use next_iterator.
3293         (basic_inf_threads_range): Remove.
3294         (inf_threads_range, inf_non_exited_threads_range)
3295         (safe_inf_threads_range): Use next_adapter.
3296
3297 2019-01-10  Keith Seitz  <keiths@redhat.com>
3298
3299         PR gdb/23712
3300         PR symtab/23010
3301         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
3302         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
3303
3304 2019-01-10  Keith Seitz  <keiths@redhat.com>
3305
3306         PR gdb/23712
3307         PR symtab/23010
3308         * dictionary.c (pending_to_vector): Remove.
3309         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3310         Remove _1 suffix, replacing functions of the same name.  Update
3311         all callers.
3312         (dict_create_hashed, dict_create_hashed_expandable)
3313         (dict_create_linear, dict_create_linear_expandable, dict_free)
3314         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
3315         Make functions static.
3316
3317 2019-01-10  Keith Seitz  <keiths@redhat.com>
3318
3319         PR gdb/23712
3320         PR symtab/23010
3321         * dictionary.h (struct dictionary): Replace declaration with
3322         multidictionary.
3323         (dict_create_hashed, dict_create_hashed_expandable)
3324         (dict_create_linear, dict_create_linear_expandable)
3325         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
3326         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
3327         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
3328         taking multidictionary argument.
3329         [ALL_DICT_SYMBOLS]: Update for multidictionary.
3330         * block.h (struct block) <dict>: Change to multidictionary
3331         and rename `multidict'.
3332         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
3333         symmisc.c: Update all dictionary references to multidictionary.
3334
3335 2019-01-10  Keith Seitz  <keiths@redhat.com>
3336
3337         PR gdb/23712
3338         PR symtab/23010
3339         * dictionary.c: Include unordered_map.
3340         (pending_to_vector): New function.
3341         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3342         Rewrite the non-"_1" functions to take vector instead
3343         of linked list.
3344         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
3345         "new" _1 versions of the same name.
3346         (multidictionary): Define.
3347         (std::hash<enum language): New definition.
3348         (collate_pending_symbols_by_language, mdict_create_hashed)
3349         (mdict_create_hashed_expandable, mdict_create_linear)
3350         (mdict_create_linear_expandable, mdict_free)
3351         (find_language_dictionary, create_new_language_dictionary)
3352         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
3353         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
3354         (mdict_size, mdict_empty): New functions.
3355         * dictionary.h (mdict_iterator): Define.
3356
3357 2019-01-10  Pedro Alves  <palves@redhat.com>
3358
3359         * breakpoint.c (read_uploaded_action)
3360         (create_tracepoint_from_upload): Adjust to use
3361         gdb::unique_xmalloc_ptr.
3362         * ctf.c (ctf_write_uploaded_tp):
3363         (SET_ARRAY_FIELD): Use emplace_back.
3364         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
3365         * tracefile-tfile.c (tfile_write_uploaded_tp):
3366         * tracepoint.c (parse_tracepoint_definition): Adjust to use
3367         gdb::unique_xmalloc_ptr.
3368         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
3369         at_string, cond_string, cmd_strings>: Replace char pointers
3370         with gdb::unique_xmalloc_ptr.
3371
3372 2019-01-10  Pedro Alves  <palves@redhat.com>
3373
3374         * solib-target.c (library_list_start_library): Don't xstrdup name.
3375
3376 2019-01-10  Pedro Alves  <palves@redhat.com>
3377
3378         * mdebugread.c (parse_partial_symbols): Use
3379         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3380
3381 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3382
3383         * linux-fork.c (scoped_switch_fork_info)
3384         <~scoped_switch_fork_info>: Fix incorrect variable name.
3385
3386 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3387
3388         * linux-fork.c (scoped_switch_fork_info)
3389         <scoped_switch_fork_info>: Make explicit.
3390         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3391
3392 2019-01-10  Tom Tromey  <tom@tromey.com>
3393
3394         * objfiles.h (objfile::reset_psymtabs): Update.
3395         * objfiles.c (objfile::objfile): Update.
3396         * psymtab.h (psymtab_storage::obstack): Update.
3397         (psymtab_storage::m_obstack): Use gdb::optional.
3398         (class psymtab_storage): Update comment.  Remove objfile
3399         parameter.
3400         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3401
3402 2019-01-10  Tom Tromey  <tom@tromey.com>
3403
3404         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3405         <free_psymtabs>: Now private.
3406         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3407         (allocate_psymtab): Use new method.
3408
3409 2019-01-10  Tom Tromey  <tom@tromey.com>
3410
3411         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3412         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3413         * mdebugread.c (parse_partial_symbols): Use
3414         allocate_dependencies.
3415         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3416         allocate_dependencies.
3417         (process_psymtab_comp_unit_reader)
3418         (build_type_psymtab_dependencies): Likewise.
3419         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3420
3421 2019-01-10  Tom Tromey  <tom@tromey.com>
3422
3423         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3424         PSYMBOL_SET_LANGUAGE.
3425         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3426
3427 2019-01-10  Tom Tromey  <tom@tromey.com>
3428
3429         * psymtab.h (psymtab_storage::obstack): New method.
3430         <m_obstack>: Rename from obstack; now private.
3431         * psymtab.c (psymtab_storage): Update.
3432         * dwarf2read.c (create_addrmap_from_index)
3433         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3434         Update.
3435
3436 2019-01-10  Tom Tromey  <tom@tromey.com>
3437
3438         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3439         * objfiles.h (objfile::reset_psymtabs): New method.
3440
3441 2019-01-10  Tom Tromey  <tom@tromey.com>
3442
3443         * symmisc.c (print_symbol_bcache_statistics): Update.
3444         (print_objfile_statistics): Update.
3445         * symfile.c (reread_symbols): Update.
3446         * psymtab.h (class psymtab_storage): New.
3447         * psymtab.c (psymtab_storage): New constructor.
3448         (~psymtab_storage): New destructor.
3449         (require_partial_symbols): Update.
3450         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3451         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3452         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3453         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3454         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3455         (start_psymtab_common, end_psymtab_common)
3456         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3457         (allocate_psymtab): Update.
3458         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3459         Update.
3460         (dump_psymtab_addrmap, maintenance_print_psymbols)
3461         (maintenance_check_psymtabs): Update.
3462         (class objfile_psymtabs): Move to objfiles.h.
3463         * psympriv.h (discard_psymtab): Now inline.
3464         (psymtab_discarder::psymtab_discarder): Update.
3465         (psymtab_discarder::~psymtab_discarder): Update.
3466         (ALL_OBJFILE_PSYMTABS): Rewrite.
3467         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3468         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3469         Remove fields.
3470         <partial_symtabs>: New field.
3471         (class objfile_psymtabs): Move from psymtab.h.  Update.
3472         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3473         psymbol_cache.
3474         (objfile::~objfile): Don't destroy psymbol_cache.
3475         * mdebugread.c (parse_partial_symbols): Update.
3476         * dwarf2read.c (create_addrmap_from_index)
3477         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3478         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3479         (add_partial_subprogram, dwarf2_ranges_read): Update.
3480         * dwarf-index-write.c (write_address_map)
3481         (write_one_signatured_type, recursively_write_psymbols)
3482         (class debug_names, class debug_names, write_psymtabs_to_index):
3483         Update.
3484
3485 2019-01-10  Tom Tromey  <tom@tromey.com>
3486
3487         * symtab.h (SYMBOL_SET_NAMES): Update.
3488         (symbol_set_names): Update.
3489         (MSYMBOL_SET_NAMES): Update.
3490         * symtab.c (symbol_set_names): Change argument to be an
3491         objfile_per_bfd_storage.
3492         * psymtab.c (add_psymbol_to_bcache): Update.
3493         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3494
3495 2019-01-10  Tom Tromey  <tom@tromey.com>
3496
3497         * symtab.c (create_demangled_names_hash): Change argument to be an
3498         objfile_per_bfd_storage.
3499         (symbol_set_names): Update.
3500
3501 2019-01-10  Tom Tromey  <tom@tromey.com>
3502
3503         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3504         init_psymbol_list.
3505         * psymtab.c (init_psymbol_list): Do nothing if already called.
3506         * psympriv.h (init_psymbol_list): Add comment.
3507         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3508         init_psymbol_list.
3509         * dbxread.c (dbx_symfile_read): Unconditionally call
3510         init_psymbol_list.
3511
3512 2019-01-10  Tom Tromey  <tom@tromey.com>
3513
3514         * xcoffread.c (scan_xcoff_symtab): Update.
3515         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3516         "where".
3517         * mdebugread.c (parse_partial_symbols)
3518         (handle_psymbol_enumerators): Update.
3519         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3520         * dbxread.c (read_dbx_symtab): Update.
3521         * psympriv.h (psymbol_placement): New enum.
3522         (add_psymbol_to_list): Update.
3523
3524 2019-01-10  Tom Tromey  <tom@tromey.com>
3525
3526         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3527         static_psymbols parameters.
3528         (scan_xcoff_symtab): Update.
3529         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3530         static_psymbols parameters.
3531         * psympriv.h (start_psymtab_common): Update.
3532         * mdebugread.c (parse_partial_symbols): Update.
3533         * dwarf2read.c (create_partial_symtab): Update.
3534         * dbxread.c (read_dbx_symtab): Update.
3535         (start_psymtab): Remove global_psymbols and static_psymbols
3536         parameters.
3537
3538 2019-01-10  Tom Tromey  <tom@tromey.com>
3539
3540         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3541         * psymtab.c (allocate_psymtab): Add comment.
3542         * psympriv.h (allocate_psymtab): Add comment.
3543         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3544         initializations.
3545         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3546
3547 2019-01-10  Tom Tromey  <tom@tromey.com>
3548
3549         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3550         Don't declare.
3551         * mipsread.c: Include mdebugread.h.
3552         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3553         Declare.
3554         * elfread.c: Include mdebugread.h.
3555
3556 2019-01-09  Tom Tromey  <tom@tromey.com>
3557
3558         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3559         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3560         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3561         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3562         (psym_lookup_symbol, psym_find_last_source_symtab)
3563         (psym_forget_cached_source_info, psym_print_stats)
3564         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3565         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3566         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3567         (psym_find_compunit_symtab_by_address)
3568         (maintenance_print_psymbols, maintenance_info_psymtabs)
3569         (maintenance_check_psymtabs): Use ranged for.
3570         * psymtab.h (class objfile_psymtabs): New.
3571         (require_partial_symbols): Return objfile_psymtabs.
3572         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3573
3574 2019-01-09  Tom Tromey  <tom@tromey.com>
3575
3576         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3577         (find_pc_mapped_section, list_overlays_command)
3578         (map_overlay_command, unmap_overlay_command)
3579         (simple_overlay_update): Use all_objfiles.
3580         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3581         * printcmd.c (info_symbol_command): Use all_objfiles.
3582         * objfiles.h (ALL_OBJSECTIONS): Remove.
3583         * maint.c (maintenance_translate_address): Use all_objfiles.
3584         * gcore.c (gcore_create_callback): Use all_objfiles.
3585         (objfile_find_memory_regions): Likewise.
3586
3587 2019-01-09  Tom Tromey  <tom@tromey.com>
3588
3589         * symtab.c (find_line_symtab, info_sources_command)
3590         (make_source_files_completion_list): Use objfile_compunits.
3591         * source.c (select_source_symtab): Use objfile_compunits.
3592         * objfiles.h (struct objfile): Update comment.
3593         (ALL_OBJFILES): Remove.
3594         (ALL_FILETABS): Remove.
3595         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3596         objfile_compunits.
3597
3598 2019-01-09  Tom Tromey  <tom@tromey.com>
3599
3600         * symmisc.c (print_objfile_statistics, dump_objfile)
3601         (maintenance_print_symbols): Use compunit_filetabs.
3602         * source.c (forget_cached_source_info_for_objfile): Use
3603         compunit_filetabs.
3604         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3605         (ALL_FILETABS): Use compunit_filetabs.
3606         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3607         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3608
3609 2019-01-09  Tom Tromey  <tom@tromey.com>
3610
3611         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3612         (compunit_filetabs): New.
3613         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3614         compunit_filetabs.
3615         (info_sources_command, make_source_files_completion_list): Remove
3616         declaration.
3617         * symmisc.c (print_objfile_statistics, dump_objfile)
3618         (maintenance_print_symbols): Remove declaration.
3619         (maintenance_info_symtabs): Use compunit_filetabs.
3620         (maintenance_info_line_tables): Likewise.
3621         * source.c (select_source_symtab): Change local variable name.
3622         (forget_cached_source_info_for_objfile): Remove declaration.
3623         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3624         * objfiles.c (objfile_relocate1): Remove declaration.
3625         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3626         declaration.
3627         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3628         * coffread.c (coff_symtab_read): Remove declaration.
3629         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3630         compunit_filetabs.
3631
3632 2019-01-09  Tom Tromey  <tom@tromey.com>
3633
3634         * symtab.c (lookup_objfile_from_block)
3635         (find_pc_sect_compunit_symtab, search_symbols)
3636         (default_collect_symbol_completion_matches_break_on): Use
3637         objfile_compunits.
3638         * objfiles.h (ALL_COMPUNITS): Remove.
3639         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3640         * cp-support.c (add_symbol_overload_list_qualified): Use
3641         objfile_compunits.
3642         * ada-lang.c (ada_collect_symbol_completion_matches)
3643         (ada_add_global_exceptions): Use objfile_compunits.
3644
3645 2019-01-09  Tom Tromey  <tom@tromey.com>
3646
3647         * source.c (select_source_symtab)
3648         (forget_cached_source_info_for_objfile): Remove declaration.
3649         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3650         declaration.
3651         * maint.c (count_symtabs_and_blocks): Remove declaration.
3652         * cp-support.c (add_symbol_overload_list_qualified): Remove
3653         declaration.
3654         * coffread.c (coff_symtab_read): Remove declaration.
3655         * symtab.c (lookup_symbol_in_objfile_symtabs)
3656         (basic_lookup_transparent_type_1): Use objfile_compunits.
3657         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3658         (info_sources_command, search_symbols)
3659         (default_collect_symbol_completion_matches_break_on)
3660         (make_source_files_completion_list): Remove declaration.
3661         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3662         (ada_collect_symbol_completion_matches)
3663         (ada_add_global_exceptions): Remove declaration.
3664         * linespec.c (iterate_over_all_matching_symtabs): Use
3665         objfile_compunits.
3666         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3667         (class objfile_compunits): New.
3668         (ALL_COMPUNITS): Use objfile_compunits.
3669         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3670         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3671         objfile_compunits.
3672         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3673
3674 2019-01-09  Tom Tromey  <tom@tromey.com>
3675
3676         * symtab.c (search_symbols)
3677         (default_collect_symbol_completion_matches_break_on): Use
3678         objfile_msymbols.
3679         * ada-lang.c (ada_lookup_simple_minsym)
3680         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3681         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3682         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3683         objfile_msymbols.
3684         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3685         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3686         * objc-lang.c (find_methods): Use objfile_msymbols.
3687         (info_selectors_command, info_classes_command): Likewise.
3688         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3689         * objfiles.h (class objfile_msymbols): New.
3690         (ALL_OBJFILE_MSYMBOLS): Remove.
3691         (ALL_MSYMBOLS): Remove.
3692
3693 2019-01-09  Tom Tromey  <tom@tromey.com>
3694
3695         * common/next-iterator.h (next_adapter): Add Iterator template
3696         parameter.
3697         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3698         (class all_objfiles_safe): New.
3699         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3700         * objfiles.c (put_objfile_before): Update comment.
3701         (add_separate_debug_objfile): Likewise.
3702         (free_all_objfiles): Use all_objfiles_safe.
3703         (objfile_purge_solibs): Likewise.
3704
3705 2019-01-09  Tom Tromey  <tom@tromey.com>
3706
3707         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3708         (expand_symtab_containing_pc, lookup_static_symbol)
3709         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3710         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3711         all_objfiles.
3712         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3713         * breakpoint.c (create_overlay_event_breakpoint)
3714         (create_longjmp_master_breakpoint)
3715         (create_std_terminate_master_breakpoint)
3716         (create_exception_master_breakpoint): Use all_objfiles.
3717         * linux-thread-db.c (try_thread_db_load_from_pdir)
3718         (has_libpthread): Use all_objfiles.
3719         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3720         * linespec.c (iterate_over_all_matching_symtabs)
3721         (search_minsyms_for_name): Use all_objfiles.
3722         * maint.c (maintenance_info_sections): Use all_objfiles.
3723         * main.c (captured_main_1): Use all_objfiles.
3724         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3725         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3726         * guile/scm-pretty-print.c
3727         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3728         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3729         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3730         (maintenance_print_msymbols): Use all_objfiles.
3731         * source.c (select_source_symtab): Use all_objfiles.
3732         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3733         * symfile.c (remove_symbol_file_command)
3734         (expand_symtabs_matching, map_symbol_filenames): Use
3735         all_objfiles.
3736         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3737         all_objfiles.
3738         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3739         * objc-lang.c (find_methods): Use all_objfiles.
3740         * objfiles.c (have_partial_symbols, have_full_symbols)
3741         (have_minimal_symbols, qsort_cmp)
3742         (default_iterate_over_objfiles_in_search_order): Use
3743         all_objfiles.
3744         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3745         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3746         (maintenance_check_psymtabs): Use all_objfiles.
3747         (ALL_PSYMTABS): Remove.
3748         * compile/compile-object-run.c (do_module_cleanup): Use
3749         all_objfiles.
3750         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3751         * cp-support.c (add_symbol_overload_list_qualified): Use
3752         all_objfiles.
3753         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3754         Use all_objfiles.
3755         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3756         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3757         all_objfiles.
3758         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3759         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3760         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3761         Uses all_objfiles.
3762         * solib.c (solib_read_symbols): Use all_objfiles
3763
3764 2019-01-09  Tom Tromey  <tom@tromey.com>
3765
3766         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3767         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3768         all_objfiles.
3769         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3770         * symmisc.c (print_symbol_bcache_statistics)
3771         (print_objfile_statistics, maintenance_print_objfiles)
3772         (maintenance_info_symtabs, maintenance_check_symtabs)
3773         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3774         all_objfiles.
3775         * source.c (forget_cached_source_info): Use all_objfiles.
3776         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3777         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3778         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3779         * objfiles.c (update_section_map): Use all_objfiles.
3780         (shared_objfile_contains_address_p): Likewise.
3781         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3782         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3783
3784 2019-01-09  Tom Tromey  <tom@tromey.com>
3785
3786         * common/next-iterator.h: New file.
3787         * objfiles.h (class all_objfiles): New.
3788         (struct objfile_iterator): New.
3789
3790 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3791
3792         * NEWS: Move the description of the changed "frame", "select-frame",
3793          and "info frame" commands to the Changed commands section.
3794
3795 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3796
3797         * gdbtypes.c (check_stub_method_group): Remove handling of old
3798         mangling schemes.
3799         * linespec.c (find_methods): Likewise.
3800         * stabsread.c (read_member_functions): Likewise.
3801         * valops.c (search_struct_method): Likewise.
3802         (value_struct_elt_for_reference): Likewise.
3803         * NEWS: Mention this change.
3804
3805 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3806
3807         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3808         print_source_lines.
3809         * source.c (print_source_lines_base): Update line number check.
3810         (print_source_lines): New function.
3811         (source_lines_range::source_lines_range): New function.
3812         * source.h (class source_lines_range): New class.
3813         (print_source_lines): New declaration.
3814
3815 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3816
3817         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3818
3819 2019-01-08  Tom Tromey  <tom@tromey.com>
3820             Simon Marchi  <simon.marchi@ericsson.com>
3821
3822         PR gdb/24060
3823         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3824         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3825         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3826         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3827         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3828         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3829
3830 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3831
3832         * source.c (select_source_symtab): Move header comment to
3833         declaration in source.h.
3834         (forget_cached_source_info_for_objfile): Likewise.
3835         (forget_cached_source_info): Likewise.
3836         (identify_source_line): Likewise.
3837         * source.h (identify_source_line): Move declaration from symtab.h
3838         and add comment from source.c
3839         (print_source_lines): Likewise.
3840         (forget_cached_source_info_for_objfile): Likewise.
3841         (forget_cached_source_info): Likewise.
3842         (select_source_symtab): Likewise.
3843         (enum print_source_lines_flag): Move definition from symtab.h.
3844         * symtab.h (identify_source_line): Move declaration to source.h.
3845         (print_source_lines): Likewise.
3846         (forget_cached_source_info_for_objfile): Likewise.
3847         (forget_cached_source_info): Likewise.
3848         (select_source_symtab): Likewise.
3849         (enum print_source_lines_flag): Move definition to source.h.
3850         * tui/tui-hooks.c: Add 'source.h' include.
3851
3852 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3853
3854         * source.c (print_source_lines_base): Handle requests to print
3855         reverse line number sequences, and guard against empty lines
3856         string.
3857
3858 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3859
3860         * source.c (print_source_lines_base): Fix skip of '\r' if next
3861         character is '\n'.
3862
3863 2019-01-06  Tom Tromey  <tom@tromey.com>
3864
3865         * c-exp.y (struct c_parse_state) <macro_original_text,
3866         expansion_obstack>: New member.
3867         (macro_original_text, expansion_obstack): Remove globals.
3868         (scan_macro_expansion, scanning_macro_expansion)
3869         (finished_macro_expansion): Update.
3870         (scan_macro_cleanup): Remove.
3871         (yylex, c_parse): Update.
3872
3873 2019-01-06  Tom Tromey  <tom@tromey.com>
3874
3875         * c-exp.y (struct c_parse_state) <strings>: New member.
3876         (operator_stoken): Update.
3877
3878 2019-01-06  Tom Tromey  <tom@tromey.com>
3879
3880         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3881         (union type_stack_elt) <typelist_val>: Now a pointer to
3882         std::vector.
3883         (type_stack_cleanup): Don't declare.
3884         (push_typelist): Update.
3885         * parse.c (pop_typelist): Return a std::vector.
3886         (push_typelist): Take a std::vector.
3887         (follow_types): Update.  Do not free args.
3888         (type_stack_cleanup): Remove.
3889         * c-exp.y (struct c_parse_state): New.
3890         (cpstate): New global.
3891         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3892         (nonempty_typelist): Update.
3893         (func_mod): Create a new vector.
3894         (c_parse): Create a c_parse_state.
3895         (check_parameter_typelist): Do not delete params.
3896         (function_method): Update.  Do not delete type_list.
3897
3898 2019-01-06  Tom Tromey  <tom@tromey.com>
3899
3900         PR gdb/28155:
3901         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3902         check_typedef.
3903         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3904         (print_return_value): Likewise.
3905
3906 2019-01-05  Tom Tromey  <tom@tromey.com>
3907
3908         * contrib/cleanup_check.py: Remove.
3909         * contrib/gcc-with-excheck: Remove.
3910         * contrib/exsummary.py: Remove.
3911         * contrib/excheck.py: Remove.
3912
3913 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3914
3915         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3916         NULL. Initialize tpprev to NULL instead of assigning it
3917         to NULL on the next statement.
3918         * windows-nat.c (windows_delete_thread): Remove check for
3919         main_thread_id before printing thread exit notifications.
3920         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3921         Remove thread ID check against main_thread_id.
3922         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3923         windows_delete_thread.
3924         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3925
3926 2019-01-04  Tom Tromey  <tom@tromey.com>
3927
3928         * compile/compile.c (_initialize_compile): Use upper case for
3929         metasyntactic variables.
3930         * symmisc.c (_initialize_symmisc): Use upper case for
3931         metasyntactic variables.
3932         * psymtab.c (_initialize_psymtab): Use upper case for
3933         metasyntactic variables.
3934         * demangle.c (demangle_command): Use upper case for metasyntactic
3935         variables.
3936         (_initialize_demangler): Likewise.
3937         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3938         variables.
3939
3940 2019-01-03  Tom Tromey  <tom@tromey.com>
3941
3942         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3943
3944 2019-01-03  Tom Tromey  <tom@tromey.com>
3945
3946         * python/py-symtab.c (salpy_str): Update.
3947         (struct salpy_sal_object) <symtab>: Now a PyObject.
3948         (salpy_dealloc): Update.
3949         (del_objfile_sal): Use gdbpy_ref.
3950
3951 2019-01-03  Tom Tromey  <tom@tromey.com>
3952
3953         * python/py-type.c (convert_field): Use new_reference.  Return
3954         gdbpy_ref.
3955         (make_fielditem): Return gdbpy_ref.
3956         (typy_fields): Update.
3957         (typy_getitem): Update.
3958         (field_name): Return gdbpy_ref.  Use new_reference.
3959         (typy_iterator_iternext): Update.
3960
3961 2019-01-03  Tom Tromey  <tom@tromey.com>
3962
3963         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3964
3965 2019-01-03  Tom Tromey  <tom@tromey.com>
3966
3967         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3968         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3969         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3970         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3971         (pspy_set_type_printers): Likewise.
3972         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3973         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3974         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3975         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3976         (objfpy_set_type_printers): Likewise.
3977
3978 2019-01-03  Tom Tromey  <tom@tromey.com>
3979
3980         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3981         (gdbpy_print_stack): Use gdbpy_err_fetch.
3982         * python/python-internal.h (class gdbpy_err_fetch): New class.
3983         (class gdbpy_enter) <m_error_type, m_error_value,
3984         m_error_traceback>: Remove.
3985         <m_error>: New member.
3986         (gdbpy_exception_to_string): Don't declare.
3987         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3988         * python/py-value.c (convert_value_from_python): Use
3989         gdbpy_err_fetch.
3990         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3991         gdbpy_exception_to_string.
3992         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3993         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3994         gdbpy_err_fetch.
3995
3996 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3997
3998         * linux-nat.c (delete_lwp_cleanup): Delete.
3999         (struct lwp_deleter): New struct.
4000         (lwp_info_up): New typedef.
4001         (linux_nat_target::follow_fork): Delete cleanup, and make use of
4002         lwp_info_up.
4003
4004 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4005
4006         * linux-fork.c (class scoped_switch_fork_info): New class.
4007         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
4008
4009 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4010
4011         * valops.c (find_overload_match): Remove use of null_cleanup, and
4012         calls to do_cleanups.
4013
4014 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4015
4016         * compile/compile-cplus-types.c
4017         (compile_cplus_instance::decl_name): Handle changes to
4018         cp_func_name.
4019         * cp-support.c (cp_func_name): Update header comment, update
4020         return type.
4021         * cp-support.h (cp_func_name): Update return type in declaration.
4022         * valops.c (find_overload_match): Move temp_func local to top
4023         level of function and change its type.  Use temp_func to hold and
4024         delete temporary string obtained from cp_func_name.
4025
4026 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4027
4028         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
4029         gdb::char_vector, remove cleanup, and update uses of `msg`.
4030
4031 2019-01-03  Jim Wilson  <jimw@sifive.com>
4032
4033         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
4034
4035 2019-01-02  Tom Tromey  <tom@tromey.com>
4036
4037         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
4038         (tdesc_parse_xml): Remove cleanups.
4039         * target-descriptions.h (make_cleanup_free_target_description):
4040         Don't declare.
4041         (target_desc_deleter): New struct.
4042         (target_desc_up): New typedef.
4043         * target-descriptions.c (target_desc_deleter::operator()): Rename
4044         from free_target_description.
4045         (make_cleanup_free_target_description): Remove.
4046
4047 2019-01-02  Tom Tromey  <tom@tromey.com>
4048
4049         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
4050         constructor, destructor.
4051         (linespec_parser): Remove typedef.
4052         (~linespec_parser): Rename from linespec_parser_delete.
4053         (linespec_lex_to_end, linespec_complete_label)
4054         (linespec_complete): Update.
4055         (decode_line_full): Remove cleanups.
4056         (decode_line_1): Update.
4057
4058 2019-01-02  Tom Tromey  <tom@tromey.com>
4059
4060         * python/python-internal.h (inferior_to_inferior_object): Change
4061         return type.
4062         * python/py-exitedevent.c (create_exited_event_object): Update.
4063         * python/py-inferior.c (inferior_to_inferior_object): Return
4064         gdbpy_ref.
4065         (python_new_inferior, python_inferior_deleted)
4066         (thread_to_thread_object, delete_thread_object)
4067         (build_inferior_list, gdbpy_selected_inferior): Update.
4068         * python/py-infthread.c (create_thread_object): Update.  Also fail
4069         if inferior_to_inferior_object fails.
4070
4071 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
4072
4073         * inferior.h (class inferior) <displaced_step_state>: New field.
4074         * infrun.h (struct displaced_step_state): Move here from
4075         infrun.c.  Initialize fields, add constructor.
4076         <inf>: Remove field.
4077         <reset>: New method.
4078         * infrun.c (struct displaced_step_inferior_state): Move to
4079         infrun.h.
4080         (displaced_step_inferior_states): Remove.
4081         (get_displaced_stepping_state): Adust.
4082         (displaced_step_in_progress_any_inferior): Adjust.
4083         (displaced_step_in_progress_thread): Adjust.
4084         (displaced_step_in_progress): Adjust.
4085         (add_displaced_stepping_state): Remove.
4086         (get_displaced_step_closure_by_addr): Adjust.
4087         (remove_displaced_stepping_state): Remove.
4088         (infrun_inferior_exit): Call displaced_step_state.reset.
4089         (use_displaced_stepping): Don't check for NULL.
4090         (displaced_step_prepare_throw): Call
4091         get_displaced_stepping_state.
4092         (displaced_step_fixup): Don't check for NULL.
4093         (prepare_for_detach): Don't check for NULL.
4094
4095 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4096
4097         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
4098          in case of call that did not complete.
4099
4100 2019-01-02  Andrey Utkin  <autkin@undo.io>
4101
4102         * symfile.c (find_separate_debug_file): Fix search of debug files for
4103         remote debuggee.
4104
4105 2019-01-02  Tom Tromey  <tom@tromey.com>
4106
4107         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
4108         indentation.
4109         * python/py-frame.c (frapy_older): Remove cast.
4110         (frapy_newer): Likewise.
4111         * python/py-breakpoint.c (local_setattro): Remove cast.
4112         * python/py-arch.c (archpy_name): Remove local variable.
4113         * python/py-type.c (gdbpy_lookup_type): Remove cast.
4114
4115 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
4116
4117         * unittests/basic_string_view/element_access/char/empty.cc:
4118         Fix year range in copyright header.
4119
4120 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4121
4122         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
4123         Delete.
4124         <operator==>: Update with for removed field.
4125         <hash>: Likewise.
4126         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
4127         <isa_features>: ...this.
4128         <abi_features>: New field.
4129         (riscv_isa_flen): Update comment.
4130         (riscv_abi_xlen): New declaration.
4131         (riscv_abi_flen): New declaration.
4132         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
4133         isa_features.
4134         (riscv_abi_xlen): New function.
4135         (riscv_isa_flen): Update to get answer from isa_features.
4136         (riscv_abi_flen): New function.
4137         (riscv_has_fp_abi): Update to get answer from abi_features.
4138         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
4139         xlen and flen.
4140         (riscv_call_info) <xlen, flen>: Update comment.
4141         (riscv_call_arg_struct): Remove invalid assertions
4142         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
4143         is removed.
4144         (riscv_gdbarch_init): Gather isa features and abi features
4145         separately, ensure both match on the gdbarch when reusing an old
4146         gdbarch.  Relax an error check to allow 32-bit abi float to run on
4147         a target with 64-bit float hardware.
4148
4149 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4150
4151         * source.c (search_command_helper): Stop reverse search
4152         when line 1 has been searched.
4153
4154 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4155
4156         * record-full.c (record_full_base_target::close): Rewrite
4157         record_full_core_buf_list free logic.
4158
4159 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4160
4161         * break-catch-syscall.c (print_one_catch_syscall): xfree
4162         the last text.
4163
4164 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4165
4166         * top.c (print_gdb_version): Update Copyright year in version
4167         message.
4168
4169 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4170
4171         Update copyright year range in all GDB files.
4172
4173 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
4174
4175         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
4176
4177 For older changes see ChangeLog-2018.
4178 \f
4179 Local Variables:
4180 mode: change-log
4181 left-margin: 8
4182 fill-column: 74
4183 version-control: never
4184 coding: utf-8
4185 End:
4186