gdb/ChangeLog

   1 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
   2
   3         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
   4         for padding.
   5
   6 2019-01-16  Tom Tromey  <tom@tromey.com>
   7
   8         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
   9         earlier.
  10         (struct objfile) <msymbols_range>: Move from top level.
  11         <msymbols>: New method.
  12         (class objfile_msymbols): Remove.
  13         * symtab.c (default_collect_symbol_completion_matches_break_on):
  14         Update.
  15         * symmisc.c (dump_msymbols): Update.
  16         * stabsread.c (scan_file_globals): Update.
  17         * objc-lang.c (info_selectors_command, info_classes_command)
  18         (find_methods): Update.
  19         * minsyms.c (find_solib_trampoline_target): Update.
  20         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
  21         * coffread.c (coff_symfile_read): Update.
  22         * ada-lang.c (ada_lookup_simple_minsym)
  23         (ada_collect_symbol_completion_matches): Update.
  24
  25 2019-01-16  Tom Tromey  <tom@tromey.com>
  26
  27         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
  28         type.  Remove no-argument constructor.
  29         <iterator::operator++>: Simplify.
  30         <begin>: Update.
  31         <end>: Use minimal_symbol_count.
  32
  33 2019-01-16  Tom Tromey  <tom@tromey.com>
  34
  35         * objfiles.h (struct objfile) <psymtabs>: New method.
  36         (class objfile_psymtabs): Remove.
  37         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
  38         typedef.
  39         <range>: New method.
  40         (require_partial_symbols): Change return type.
  41         * psymtab.c (require_partial_symbols)
  42         (psym_expand_symtabs_matching): Update.
  43         * mdebugread.c (parse_partial_symbols): Update.
  44         * dbxread.c (dbx_end_psymtab): Update.
  45
  46 2019-01-15  Tom Tromey  <tom@tromey.com>
  47
  48         * symtab.c (lookup_objfile_from_block)
  49         (lookup_symbol_in_objfile_symtabs)
  50         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
  51         (find_line_symtab, info_sources_command)
  52         (default_collect_symbol_completion_matches_break_on)
  53         (make_source_files_completion_list): Update.
  54         * symmisc.c (print_objfile_statistics, dump_objfile)
  55         (maintenance_print_symbols, maintenance_info_symtabs)
  56         (maintenance_check_symtabs, maintenance_info_line_tables):
  57         Update.
  58         * source.c (select_source_symtab)
  59         (forget_cached_source_info_for_objfile): Update.
  60         * objfiles.h (class objfile_compunits): Remove.
  61         (struct objfile) <compunits_range>: New typedef.
  62         (compunits): New method.
  63         * objfiles.c (objfile_relocate1): Update.
  64         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
  65         * maint.c (count_symtabs_and_blocks): Update.
  66         * linespec.c (iterate_over_all_matching_symtabs): Update.
  67         * cp-support.c (add_symbol_overload_list_qualified): Update.
  68         * coffread.c (coff_symtab_read): Update.
  69         * ada-lang.c (add_nonlocal_symbols)
  70         (ada_collect_symbol_completion_matches)
  71         (ada_add_global_exceptions): Update.
  72
  73 2019-01-15  Tom Tromey  <tom@tromey.com>
  74
  75         * progspace.h (program_space) <objfiles_safe_range>: New
  76         typedef.
  77         <objfiles_safe>: New method.
  78         * objfiles.h (class all_objfiles_safe): Remove.
  79         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
  80         * jit.c (jit_inferior_exit_hook): Update.
  81
  82 2019-01-17  Tom Tromey  <tom@tromey.com>
  83
  84         * progspace.h (program_space) <objfiles_range>: New typedef.
  85         <objfiles>: New method.
  86         <objfiles_head>: Rename from objfiles.
  87         (object_files): Update.
  88         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
  89         * guile/scm-pretty-print.c
  90         (ppscm_find_pretty_printer_from_objfiles): Update.
  91         * guile/scm-objfile.c (gdbscm_objfiles): Update.
  92         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
  93         Update.
  94         * python/py-progspace.c (pspy_get_objfiles): Update.
  95         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
  96         Update.
  97         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
  98         (objfpy_lookup_objfile_by_build_id): Update.
  99         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 100         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 101         Update.
 102         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 103         (expand_symtab_containing_pc, lookup_objfile_from_block)
 104         (lookup_static_symbol, basic_lookup_transparent_type)
 105         (find_pc_sect_compunit_symtab, find_symbol_at_address)
 106         (find_line_symtab, info_sources_command)
 107         (default_collect_symbol_completion_matches_break_on)
 108         (make_source_files_completion_list, find_main_name): Update.
 109         * symmisc.c (print_symbol_bcache_statistics)
 110         (print_objfile_statistics, maintenance_print_symbols)
 111         (maintenance_print_msymbols, maintenance_print_objfiles)
 112         (maintenance_info_symtabs, maintenance_check_symtabs)
 113         (maintenance_expand_symtabs, maintenance_info_line_tables):
 114         Update.
 115         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
 116         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
 117         (map_overlay_command, unmap_overlay_command)
 118         (simple_overlay_update, expand_symtabs_matching)
 119         (map_symbol_filenames): Update.
 120         * symfile-debug.c (set_debug_symfile): Update.
 121         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
 122         Update.
 123         * source.c (select_source_symtab, forget_cached_source_info):
 124         Update.
 125         * solib.c (solib_read_symbols): Update.
 126         * solib-spu.c (append_ocl_sos): Update.
 127         * psymtab.c (maintenance_print_psymbols)
 128         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
 129         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
 130         * printcmd.c (info_symbol_command): Update.
 131         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
 132         Update.
 133         * objfiles.h (class all_objfiles): Remove.
 134         * objfiles.c (have_partial_symbols, have_full_symbols)
 135         (have_minimal_symbols, qsort_cmp, update_section_map)
 136         (shared_objfile_contains_address_p)
 137         (default_iterate_over_objfiles_in_search_order): Update.
 138         * objc-lang.c (info_selectors_command, info_classes_command)
 139         (find_methods): Update.
 140         * minsyms.c (find_solib_trampoline_target): Update.
 141         * maint.c (maintenance_info_sections)
 142         (maintenance_translate_address, count_symtabs_and_blocks):
 143         Update.
 144         * main.c (captured_main_1): Update.
 145         * linux-thread-db.c (try_thread_db_load_from_pdir)
 146         (has_libpthread): Update.
 147         * linespec.c (iterate_over_all_matching_symtabs)
 148         (search_minsyms_for_name): Update.
 149         * jit.c (jit_find_objf_with_entry_addr): Update.
 150         * hppa-tdep.c (find_unwind_entry)
 151         (hppa_lookup_stub_minimal_symbol): Update.
 152         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
 153         Update.
 154         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 155         (elf_gnu_ifunc_resolve_by_got): Update.
 156         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
 157         * dwarf-index-write.c (save_gdb_index_command): Update.
 158         * cp-support.c (add_symbol_overload_list_qualified): Update.
 159         * breakpoint.c (create_overlay_event_breakpoint)
 160         (create_longjmp_master_breakpoint)
 161         (create_std_terminate_master_breakpoint)
 162         (create_exception_master_breakpoint): Update.
 163         * blockframe.c (find_pc_partial_function): Update.
 164         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
 165         (ada_collect_symbol_completion_matches)
 166         (ada_add_global_exceptions): Update.
 167
 168 2019-01-17  Tom Tromey  <tom@tromey.com>
 169
 170         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
 171         declare VEC.
 172         (solib_target_parse_libraries): Change return type.
 173         (library_list_start_segment, library_list_start_section)
 174         (library_list_end_library, library_list_start_library); Update.
 175         (solib_target_free_library_list): Remove.
 176         (solib_target_parse_libraries): Remove cleanup.  Change return
 177         type.
 178         (solib_target_current_sos): Update.
 179
 180 2019-01-17  Tom Tromey  <tromey@bapiya>
 181
 182         * valprint.c: Replace "the the" with "the".
 183         * symtab.c: Replace "the the" with "the".
 184         * solib.c: Replace "the the" with "the".
 185         * solib-dsbt.c: Replace "the the" with "the".
 186         * linespec.c: Replace "the the" with "the".
 187         * dwarf2loc.h: Replace "the the" with "the".
 188         * amd64-windows-tdep.c: Replace "the the" with "the".
 189         * aarch64-tdep.c: Replace "the the" with "the".
 190
 191 2019-01-16  Keith Seitz  <keiths@redhat.com>
 192
 193         PR gdb/23773
 194         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
 195         <builder>: Rename to ..
 196         <m_builder>: ... this and make private.
 197         (dwarf2_cu::get_builder): New method.  Change all users of
 198         `builder' to use this method.
 199         (dwarf2_start_symtab): Move to ...
 200         (dwarf2_cu::start_symtab): ... here.  Update all callers
 201         (setup_type_unit_groups): Move to ...
 202         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
 203         callers.
 204         (dwarf2_cu::reset_builder): New method.
 205         (process_full_compunit, process_full_type_unit): Use
 206         dwarf2_cu::reset_builder.
 207         (follow_die_offset): Record the ancestor CU if it is different
 208         from the followed DIE's CU.
 209         (follow_die_sig_1): Likewise.
 210
 211 2019-01-15  Tom Tromey  <tom@tromey.com>
 212
 213         * remote.c (class remote_state) <buf>: Now a char_vector.
 214         <buf_size>: Remove.
 215         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
 216         parameter.
 217         (remote_target::getpkt_or_notif_sane_1)
 218         (remote_target::getpkt_sane)
 219         (remote_target::getpkt_or_notif_sane): Likewise.
 220         (class remote_target) <putpkt>: New overload.
 221         (remote_target::read_frame): Change type of "buf_p".  Remove
 222         sizeof_p parameter.
 223         (packet_ok): New overload.
 224         (packet_check_result): New overload.
 225         Update all uses.
 226
 227 2019-01-14  Tom Tromey  <tom@tromey.com>
 228
 229         * remote-notif.c (handle_notification, remote_notif_ack)
 230         (remote_notif_parse): Make "buf" const.
 231         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
 232         const.
 233         (remote_notif_parse, remote_notif_ack, handle_notification):
 234         Likewise.
 235         * remote.c (remote_notif_stop_parse): Make "buf" const.
 236         (remote_target::remote_parse_stop_reply): Make "buf" const.
 237         (remote_notif_stop_ack): Make "buf" const.
 238
 239 2019-01-14  Tom Tromey  <tom@tromey.com>
 240
 241         * remote.c (remote_console_output): Make parameter const.
 242
 243 2019-01-14  Tom Tromey  <tom@tromey.com>
 244
 245         * target-debug.h (target_debug_print_signals): Constify.
 246         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
 247         * procfs.c (procfs_target::pass_signals): Update.
 248         * linux-nat.c (linux_nat_target::pass_signals): Update.
 249         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
 250         * target-delegates.c: Rebuild.
 251         * remote.c (remote_target::program_signals): Update.
 252         (remote_target::pass_signals): Update.
 253         * target.c (target_pass_signals): Constify argument.
 254         (target_program_signals): Likewise.
 255         * target.h (struct target_ops) <pass_signals, program_signals>:
 256         Constify argument.
 257         (target_pass_signals, target_program_signals): Constify argument.
 258
 259 2019-01-14  Tom Tromey  <tom@tromey.com>
 260
 261         PR tui/28819:
 262         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
 263
 264 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 265
 266         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
 267         field.
 268         * rs6000-tdep.c: Include reggroups.h.
 269         (IS_V_ALIAS_PSEUDOREG): Define.
 270         (rs6000_register_name): Return names for the "vX" aliases.
 271         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
 272         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
 273         aliases.  Call default_register_reggroup_p for all other
 274         pseudo-registers.
 275         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
 276         New functions.
 277         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
 278         Handle "vX" aliases.
 279         (v_alias_pseudo_register_collect): New function.
 280         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
 281         (rs6000_gdbarch_init): Initialize "vX" aliases as
 282         pseudo-registers.  Restore registration of
 283         rs6000_pseudo_register_reggroup_p with
 284         set_tdesc_pseudo_register_reggroup_p.
 285
 286 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
 287
 288         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
 289         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
 290         set_gdbarch_num_pseudo_regs.
 291
 292 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 293
 294         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
 295         Remove arg prefixname, add do_set and do_show.
 296         Add member functions set_list and show_list.
 297         * cli/cli-style.c (class cli_style_option): Update accordingly.
 298         (style_set_list): Move to file scope.
 299         (style_show_list): Likewise.
 300         (set_style): Call help_list.
 301         (show_style): Call cmd_show_list.
 302         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
 303         Update to use the new macro.
 304
 305 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
 306
 307         * ada-lang.c (_initialize_ada_language): Expand the help text
 308         for the "catch exception" command.
 309
 310 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 311
 312         * symtab.c (matching_obj_sections): Initialize obj,
 313         declare it closer to its usage.
 314
 315 2019-01-10  Tom Tromey  <tom@tromey.com>
 316
 317         * thread-iter.h (inf_threads_iterator): Use next_iterator.
 318         (basic_inf_threads_range): Remove.
 319         (inf_threads_range, inf_non_exited_threads_range)
 320         (safe_inf_threads_range): Use next_adapter.
 321
 322 2019-01-10  Keith Seitz  <keiths@redhat.com>
 323
 324         PR gdb/23712
 325         PR symtab/23010
 326         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
 327         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
 328
 329 2019-01-10  Keith Seitz  <keiths@redhat.com>
 330
 331         PR gdb/23712
 332         PR symtab/23010
 333         * dictionary.c (pending_to_vector): Remove.
 334         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 335         Remove _1 suffix, replacing functions of the same name.  Update
 336         all callers.
 337         (dict_create_hashed, dict_create_hashed_expandable)
 338         (dict_create_linear, dict_create_linear_expandable, dict_free)
 339         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
 340         Make functions static.
 341
 342 2019-01-10  Keith Seitz  <keiths@redhat.com>
 343
 344         PR gdb/23712
 345         PR symtab/23010
 346         * dictionary.h (struct dictionary): Replace declaration with
 347         multidictionary.
 348         (dict_create_hashed, dict_create_hashed_expandable)
 349         (dict_create_linear, dict_create_linear_expandable)
 350         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
 351         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
 352         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
 353         taking multidictionary argument.
 354         [ALL_DICT_SYMBOLS]: Update for multidictionary.
 355         * block.h (struct block) <dict>: Change to multidictionary
 356         and rename `multidict'.
 357         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
 358         symmisc.c: Update all dictionary references to multidictionary.
 359
 360 2019-01-10  Keith Seitz  <keiths@redhat.com>
 361
 362         PR gdb/23712
 363         PR symtab/23010
 364         * dictionary.c: Include unordered_map.
 365         (pending_to_vector): New function.
 366         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 367         Rewrite the non-"_1" functions to take vector instead
 368         of linked list.
 369         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
 370         "new" _1 versions of the same name.
 371         (multidictionary): Define.
 372         (std::hash<enum language): New definition.
 373         (collate_pending_symbols_by_language, mdict_create_hashed)
 374         (mdict_create_hashed_expandable, mdict_create_linear)
 375         (mdict_create_linear_expandable, mdict_free)
 376         (find_language_dictionary, create_new_language_dictionary)
 377         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
 378         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
 379         (mdict_size, mdict_empty): New functions.
 380         * dictionary.h (mdict_iterator): Define.
 381
 382 2019-01-10  Pedro Alves  <palves@redhat.com>
 383
 384         * breakpoint.c (read_uploaded_action)
 385         (create_tracepoint_from_upload): Adjust to use
 386         gdb::unique_xmalloc_ptr.
 387         * ctf.c (ctf_write_uploaded_tp):
 388         (SET_ARRAY_FIELD): Use emplace_back.
 389         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
 390         * tracefile-tfile.c (tfile_write_uploaded_tp):
 391         * tracepoint.c (parse_tracepoint_definition): Adjust to use
 392         gdb::unique_xmalloc_ptr.
 393         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
 394         at_string, cond_string, cmd_strings>: Replace char pointers
 395         with gdb::unique_xmalloc_ptr.
 396
 397 2019-01-10  Pedro Alves  <palves@redhat.com>
 398
 399         * solib-target.c (library_list_start_library): Don't xstrdup name.
 400
 401 2019-01-10  Pedro Alves  <palves@redhat.com>
 402
 403         * mdebugread.c (parse_partial_symbols): Use
 404         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
 405
 406 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 407
 408         * linux-fork.c (scoped_switch_fork_info)
 409         <~scoped_switch_fork_info>: Fix incorrect variable name.
 410
 411 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 412
 413         * linux-fork.c (scoped_switch_fork_info)
 414         <scoped_switch_fork_info>: Make explicit.
 415         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
 416
 417 2019-01-10  Tom Tromey  <tom@tromey.com>
 418
 419         * objfiles.h (objfile::reset_psymtabs): Update.
 420         * objfiles.c (objfile::objfile): Update.
 421         * psymtab.h (psymtab_storage::obstack): Update.
 422         (psymtab_storage::m_obstack): Use gdb::optional.
 423         (class psymtab_storage): Update comment.  Remove objfile
 424         parameter.
 425         * psymtab.c (psymtab_storage::psymtab_storage): Update.
 426
 427 2019-01-10  Tom Tromey  <tom@tromey.com>
 428
 429         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
 430         <free_psymtabs>: Now private.
 431         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
 432         (allocate_psymtab): Use new method.
 433
 434 2019-01-10  Tom Tromey  <tom@tromey.com>
 435
 436         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
 437         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
 438         * mdebugread.c (parse_partial_symbols): Use
 439         allocate_dependencies.
 440         * dwarf2read.c (dwarf2_create_include_psymtab): Use
 441         allocate_dependencies.
 442         (process_psymtab_comp_unit_reader)
 443         (build_type_psymtab_dependencies): Likewise.
 444         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
 445
 446 2019-01-10  Tom Tromey  <tom@tromey.com>
 447
 448         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
 449         PSYMBOL_SET_LANGUAGE.
 450         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
 451
 452 2019-01-10  Tom Tromey  <tom@tromey.com>
 453
 454         * psymtab.h (psymtab_storage::obstack): New method.
 455         <m_obstack>: Rename from obstack; now private.
 456         * psymtab.c (psymtab_storage): Update.
 457         * dwarf2read.c (create_addrmap_from_index)
 458         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
 459         Update.
 460
 461 2019-01-10  Tom Tromey  <tom@tromey.com>
 462
 463         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
 464         * objfiles.h (objfile::reset_psymtabs): New method.
 465
 466 2019-01-10  Tom Tromey  <tom@tromey.com>
 467
 468         * symmisc.c (print_symbol_bcache_statistics): Update.
 469         (print_objfile_statistics): Update.
 470         * symfile.c (reread_symbols): Update.
 471         * psymtab.h (class psymtab_storage): New.
 472         * psymtab.c (psymtab_storage): New constructor.
 473         (~psymtab_storage): New destructor.
 474         (require_partial_symbols): Update.
 475         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
 476         (find_pc_sect_psymtab, find_pc_sect_psymbol)
 477         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
 478         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
 479         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
 480         (start_psymtab_common, end_psymtab_common)
 481         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
 482         (allocate_psymtab): Update.
 483         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
 484         Update.
 485         (dump_psymtab_addrmap, maintenance_print_psymbols)
 486         (maintenance_check_psymtabs): Update.
 487         (class objfile_psymtabs): Move to objfiles.h.
 488         * psympriv.h (discard_psymtab): Now inline.
 489         (psymtab_discarder::psymtab_discarder): Update.
 490         (psymtab_discarder::~psymtab_discarder): Update.
 491         (ALL_OBJFILE_PSYMTABS): Rewrite.
 492         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
 493         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
 494         Remove fields.
 495         <partial_symtabs>: New field.
 496         (class objfile_psymtabs): Move from psymtab.h.  Update.
 497         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
 498         psymbol_cache.
 499         (objfile::~objfile): Don't destroy psymbol_cache.
 500         * mdebugread.c (parse_partial_symbols): Update.
 501         * dwarf2read.c (create_addrmap_from_index)
 502         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 503         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
 504         (add_partial_subprogram, dwarf2_ranges_read): Update.
 505         * dwarf-index-write.c (write_address_map)
 506         (write_one_signatured_type, recursively_write_psymbols)
 507         (class debug_names, class debug_names, write_psymtabs_to_index):
 508         Update.
 509
 510 2019-01-10  Tom Tromey  <tom@tromey.com>
 511
 512         * symtab.h (SYMBOL_SET_NAMES): Update.
 513         (symbol_set_names): Update.
 514         (MSYMBOL_SET_NAMES): Update.
 515         * symtab.c (symbol_set_names): Change argument to be an
 516         objfile_per_bfd_storage.
 517         * psymtab.c (add_psymbol_to_bcache): Update.
 518         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
 519
 520 2019-01-10  Tom Tromey  <tom@tromey.com>
 521
 522         * symtab.c (create_demangled_names_hash): Change argument to be an
 523         objfile_per_bfd_storage.
 524         (symbol_set_names): Update.
 525
 526 2019-01-10  Tom Tromey  <tom@tromey.com>
 527
 528         * xcoffread.c (xcoff_initial_scan): Unconditionally call
 529         init_psymbol_list.
 530         * psymtab.c (init_psymbol_list): Do nothing if already called.
 531         * psympriv.h (init_psymbol_list): Add comment.
 532         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
 533         init_psymbol_list.
 534         * dbxread.c (dbx_symfile_read): Unconditionally call
 535         init_psymbol_list.
 536
 537 2019-01-10  Tom Tromey  <tom@tromey.com>
 538
 539         * xcoffread.c (scan_xcoff_symtab): Update.
 540         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
 541         "where".
 542         * mdebugread.c (parse_partial_symbols)
 543         (handle_psymbol_enumerators): Update.
 544         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
 545         * dbxread.c (read_dbx_symtab): Update.
 546         * psympriv.h (psymbol_placement): New enum.
 547         (add_psymbol_to_list): Update.
 548
 549 2019-01-10  Tom Tromey  <tom@tromey.com>
 550
 551         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
 552         static_psymbols parameters.
 553         (scan_xcoff_symtab): Update.
 554         * psymtab.c (start_psymtab_common): Remove global_psymbols and
 555         static_psymbols parameters.
 556         * psympriv.h (start_psymtab_common): Update.
 557         * mdebugread.c (parse_partial_symbols): Update.
 558         * dwarf2read.c (create_partial_symtab): Update.
 559         * dbxread.c (read_dbx_symtab): Update.
 560         (start_psymtab): Remove global_psymbols and static_psymbols
 561         parameters.
 562
 563 2019-01-10  Tom Tromey  <tom@tromey.com>
 564
 565         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
 566         * psymtab.c (allocate_psymtab): Add comment.
 567         * psympriv.h (allocate_psymtab): Add comment.
 568         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
 569         initializations.
 570         * dbxread.c (dbx_end_psymtab): Remove some initializations.
 571
 572 2019-01-10  Tom Tromey  <tom@tromey.com>
 573
 574         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 575         Don't declare.
 576         * mipsread.c: Include mdebugread.h.
 577         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 578         Declare.
 579         * elfread.c: Include mdebugread.h.
 580
 581 2019-01-09  Tom Tromey  <tom@tromey.com>
 582
 583         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
 584         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
 585         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
 586         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 587         (psym_lookup_symbol, psym_find_last_source_symtab)
 588         (psym_forget_cached_source_info, psym_print_stats)
 589         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 590         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 591         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 592         (psym_find_compunit_symtab_by_address)
 593         (maintenance_print_psymbols, maintenance_info_psymtabs)
 594         (maintenance_check_psymtabs): Use ranged for.
 595         * psymtab.h (class objfile_psymtabs): New.
 596         (require_partial_symbols): Return objfile_psymtabs.
 597         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
 598
 599 2019-01-09  Tom Tromey  <tom@tromey.com>
 600
 601         * symfile.c (overlay_invalidate_all, find_pc_overlay)
 602         (find_pc_mapped_section, list_overlays_command)
 603         (map_overlay_command, unmap_overlay_command)
 604         (simple_overlay_update): Use all_objfiles.
 605         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
 606         * printcmd.c (info_symbol_command): Use all_objfiles.
 607         * objfiles.h (ALL_OBJSECTIONS): Remove.
 608         * maint.c (maintenance_translate_address): Use all_objfiles.
 609         * gcore.c (gcore_create_callback): Use all_objfiles.
 610         (objfile_find_memory_regions): Likewise.
 611
 612 2019-01-09  Tom Tromey  <tom@tromey.com>
 613
 614         * symtab.c (find_line_symtab, info_sources_command)
 615         (make_source_files_completion_list): Use objfile_compunits.
 616         * source.c (select_source_symtab): Use objfile_compunits.
 617         * objfiles.h (struct objfile): Update comment.
 618         (ALL_OBJFILES): Remove.
 619         (ALL_FILETABS): Remove.
 620         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
 621         objfile_compunits.
 622
 623 2019-01-09  Tom Tromey  <tom@tromey.com>
 624
 625         * symmisc.c (print_objfile_statistics, dump_objfile)
 626         (maintenance_print_symbols): Use compunit_filetabs.
 627         * source.c (forget_cached_source_info_for_objfile): Use
 628         compunit_filetabs.
 629         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
 630         (ALL_FILETABS): Use compunit_filetabs.
 631         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
 632         * coffread.c (coff_symtab_read): Use compunit_filetabs.
 633
 634 2019-01-09  Tom Tromey  <tom@tromey.com>
 635
 636         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
 637         (compunit_filetabs): New.
 638         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
 639         compunit_filetabs.
 640         (info_sources_command, make_source_files_completion_list): Remove
 641         declaration.
 642         * symmisc.c (print_objfile_statistics, dump_objfile)
 643         (maintenance_print_symbols): Remove declaration.
 644         (maintenance_info_symtabs): Use compunit_filetabs.
 645         (maintenance_info_line_tables): Likewise.
 646         * source.c (select_source_symtab): Change local variable name.
 647         (forget_cached_source_info_for_objfile): Remove declaration.
 648         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
 649         * objfiles.c (objfile_relocate1): Remove declaration.
 650         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 651         declaration.
 652         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
 653         * coffread.c (coff_symtab_read): Remove declaration.
 654         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 655         compunit_filetabs.
 656
 657 2019-01-09  Tom Tromey  <tom@tromey.com>
 658
 659         * symtab.c (lookup_objfile_from_block)
 660         (find_pc_sect_compunit_symtab, search_symbols)
 661         (default_collect_symbol_completion_matches_break_on): Use
 662         objfile_compunits.
 663         * objfiles.h (ALL_COMPUNITS): Remove.
 664         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
 665         * cp-support.c (add_symbol_overload_list_qualified): Use
 666         objfile_compunits.
 667         * ada-lang.c (ada_collect_symbol_completion_matches)
 668         (ada_add_global_exceptions): Use objfile_compunits.
 669
 670 2019-01-09  Tom Tromey  <tom@tromey.com>
 671
 672         * source.c (select_source_symtab)
 673         (forget_cached_source_info_for_objfile): Remove declaration.
 674         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 675         declaration.
 676         * maint.c (count_symtabs_and_blocks): Remove declaration.
 677         * cp-support.c (add_symbol_overload_list_qualified): Remove
 678         declaration.
 679         * coffread.c (coff_symtab_read): Remove declaration.
 680         * symtab.c (lookup_symbol_in_objfile_symtabs)
 681         (basic_lookup_transparent_type_1): Use objfile_compunits.
 682         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
 683         (info_sources_command, search_symbols)
 684         (default_collect_symbol_completion_matches_break_on)
 685         (make_source_files_completion_list): Remove declaration.
 686         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
 687         (ada_collect_symbol_completion_matches)
 688         (ada_add_global_exceptions): Remove declaration.
 689         * linespec.c (iterate_over_all_matching_symtabs): Use
 690         objfile_compunits.
 691         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
 692         (class objfile_compunits): New.
 693         (ALL_COMPUNITS): Use objfile_compunits.
 694         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
 695         (maintenance_check_symtabs, maintenance_info_line_tables): Use
 696         objfile_compunits.
 697         * objfiles.c (objfile_relocate1): Use objfile_compunits.
 698
 699 2019-01-09  Tom Tromey  <tom@tromey.com>
 700
 701         * symtab.c (search_symbols)
 702         (default_collect_symbol_completion_matches_break_on): Use
 703         objfile_msymbols.
 704         * ada-lang.c (ada_lookup_simple_minsym)
 705         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
 706         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
 707         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
 708         objfile_msymbols.
 709         * coffread.c (coff_symfile_read): Use objfile_msymbols.
 710         * symmisc.c (dump_msymbols): Use objfile_msymbols.
 711         * objc-lang.c (find_methods): Use objfile_msymbols.
 712         (info_selectors_command, info_classes_command): Likewise.
 713         * stabsread.c (scan_file_globals): Use objfile_msymbols.
 714         * objfiles.h (class objfile_msymbols): New.
 715         (ALL_OBJFILE_MSYMBOLS): Remove.
 716         (ALL_MSYMBOLS): Remove.
 717
 718 2019-01-09  Tom Tromey  <tom@tromey.com>
 719
 720         * common/next-iterator.h (next_adapter): Add Iterator template
 721         parameter.
 722         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
 723         (class all_objfiles_safe): New.
 724         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
 725         * objfiles.c (put_objfile_before): Update comment.
 726         (add_separate_debug_objfile): Likewise.
 727         (free_all_objfiles): Use all_objfiles_safe.
 728         (objfile_purge_solibs): Likewise.
 729
 730 2019-01-09  Tom Tromey  <tom@tromey.com>
 731
 732         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 733         (expand_symtab_containing_pc, lookup_static_symbol)
 734         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
 735         (find_symbol_at_address, find_line_symtab, find_main_name): Use
 736         all_objfiles.
 737         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
 738         * breakpoint.c (create_overlay_event_breakpoint)
 739         (create_longjmp_master_breakpoint)
 740         (create_std_terminate_master_breakpoint)
 741         (create_exception_master_breakpoint): Use all_objfiles.
 742         * linux-thread-db.c (try_thread_db_load_from_pdir)
 743         (has_libpthread): Use all_objfiles.
 744         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
 745         * linespec.c (iterate_over_all_matching_symtabs)
 746         (search_minsyms_for_name): Use all_objfiles.
 747         * maint.c (maintenance_info_sections): Use all_objfiles.
 748         * main.c (captured_main_1): Use all_objfiles.
 749         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
 750         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
 751         * guile/scm-pretty-print.c
 752         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
 753         * solib-spu.c (append_ocl_sos): Use all_objfiles.
 754         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
 755         (maintenance_print_msymbols): Use all_objfiles.
 756         * source.c (select_source_symtab): Use all_objfiles.
 757         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
 758         * symfile.c (remove_symbol_file_command)
 759         (expand_symtabs_matching, map_symbol_filenames): Use
 760         all_objfiles.
 761         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
 762         all_objfiles.
 763         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
 764         * objc-lang.c (find_methods): Use all_objfiles.
 765         * objfiles.c (have_partial_symbols, have_full_symbols)
 766         (have_minimal_symbols, qsort_cmp)
 767         (default_iterate_over_objfiles_in_search_order): Use
 768         all_objfiles.
 769         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
 770         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
 771         (maintenance_check_psymtabs): Use all_objfiles.
 772         (ALL_PSYMTABS): Remove.
 773         * compile/compile-object-run.c (do_module_cleanup): Use
 774         all_objfiles.
 775         * blockframe.c (find_pc_partial_function): Use all_objfiles.
 776         * cp-support.c (add_symbol_overload_list_qualified): Use
 777         all_objfiles.
 778         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 779         Use all_objfiles.
 780         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
 781         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
 782         all_objfiles.
 783         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 784         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
 785         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 786         Uses all_objfiles.
 787         * solib.c (solib_read_symbols): Use all_objfiles
 788
 789 2019-01-09  Tom Tromey  <tom@tromey.com>
 790
 791         * probe.c (parse_probes_in_pspace): Use all_objfiles.
 792         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
 793         all_objfiles.
 794         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
 795         * symmisc.c (print_symbol_bcache_statistics)
 796         (print_objfile_statistics, maintenance_print_objfiles)
 797         (maintenance_info_symtabs, maintenance_check_symtabs)
 798         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
 799         all_objfiles.
 800         * source.c (forget_cached_source_info): Use all_objfiles.
 801         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
 802         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 803         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
 804         * objfiles.c (update_section_map): Use all_objfiles.
 805         (shared_objfile_contains_address_p): Likewise.
 806         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
 807         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
 808
 809 2019-01-09  Tom Tromey  <tom@tromey.com>
 810
 811         * common/next-iterator.h: New file.
 812         * objfiles.h (class all_objfiles): New.
 813         (struct objfile_iterator): New.
 814
 815 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 816
 817         * NEWS: Move the description of the changed "frame", "select-frame",
 818          and "info frame" commands to the Changed commands section.
 819
 820 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
 821
 822         * gdbtypes.c (check_stub_method_group): Remove handling of old
 823         mangling schemes.
 824         * linespec.c (find_methods): Likewise.
 825         * stabsread.c (read_member_functions): Likewise.
 826         * valops.c (search_struct_method): Likewise.
 827         (value_struct_elt_for_reference): Likewise.
 828         * NEWS: Mention this change.
 829
 830 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 831
 832         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
 833         print_source_lines.
 834         * source.c (print_source_lines_base): Update line number check.
 835         (print_source_lines): New function.
 836         (source_lines_range::source_lines_range): New function.
 837         * source.h (class source_lines_range): New class.
 838         (print_source_lines): New declaration.
 839
 840 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 841
 842         * linespec.c (linespec_state_destructor): Free self->canonical_names.
 843
 844 2019-01-08  Tom Tromey  <tom@tromey.com>
 845             Simon Marchi  <simon.marchi@ericsson.com>
 846
 847         PR gdb/24060
 848         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
 849         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
 850         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 851         * f-exp.y (DOLLAR_VARIABLE): Likewise.
 852         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
 853         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 854
 855 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 856
 857         * source.c (select_source_symtab): Move header comment to
 858         declaration in source.h.
 859         (forget_cached_source_info_for_objfile): Likewise.
 860         (forget_cached_source_info): Likewise.
 861         (identify_source_line): Likewise.
 862         * source.h (identify_source_line): Move declaration from symtab.h
 863         and add comment from source.c
 864         (print_source_lines): Likewise.
 865         (forget_cached_source_info_for_objfile): Likewise.
 866         (forget_cached_source_info): Likewise.
 867         (select_source_symtab): Likewise.
 868         (enum print_source_lines_flag): Move definition from symtab.h.
 869         * symtab.h (identify_source_line): Move declaration to source.h.
 870         (print_source_lines): Likewise.
 871         (forget_cached_source_info_for_objfile): Likewise.
 872         (forget_cached_source_info): Likewise.
 873         (select_source_symtab): Likewise.
 874         (enum print_source_lines_flag): Move definition to source.h.
 875         * tui/tui-hooks.c: Add 'source.h' include.
 876
 877 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 878
 879         * source.c (print_source_lines_base): Handle requests to print
 880         reverse line number sequences, and guard against empty lines
 881         string.
 882
 883 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 884
 885         * source.c (print_source_lines_base): Fix skip of '\r' if next
 886         character is '\n'.
 887
 888 2019-01-06  Tom Tromey  <tom@tromey.com>
 889
 890         * c-exp.y (struct c_parse_state) <macro_original_text,
 891         expansion_obstack>: New member.
 892         (macro_original_text, expansion_obstack): Remove globals.
 893         (scan_macro_expansion, scanning_macro_expansion)
 894         (finished_macro_expansion): Update.
 895         (scan_macro_cleanup): Remove.
 896         (yylex, c_parse): Update.
 897
 898 2019-01-06  Tom Tromey  <tom@tromey.com>
 899
 900         * c-exp.y (struct c_parse_state) <strings>: New member.
 901         (operator_stoken): Update.
 902
 903 2019-01-06  Tom Tromey  <tom@tromey.com>
 904
 905         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
 906         (union type_stack_elt) <typelist_val>: Now a pointer to
 907         std::vector.
 908         (type_stack_cleanup): Don't declare.
 909         (push_typelist): Update.
 910         * parse.c (pop_typelist): Return a std::vector.
 911         (push_typelist): Take a std::vector.
 912         (follow_types): Update.  Do not free args.
 913         (type_stack_cleanup): Remove.
 914         * c-exp.y (struct c_parse_state): New.
 915         (cpstate): New global.
 916         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
 917         (nonempty_typelist): Update.
 918         (func_mod): Create a new vector.
 919         (c_parse): Create a c_parse_state.
 920         (check_parameter_typelist): Do not delete params.
 921         (function_method): Update.  Do not delete type_list.
 922
 923 2019-01-06  Tom Tromey  <tom@tromey.com>
 924
 925         PR gdb/28155:
 926         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
 927         check_typedef.
 928         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
 929         (print_return_value): Likewise.
 930
 931 2019-01-05  Tom Tromey  <tom@tromey.com>
 932
 933         * contrib/cleanup_check.py: Remove.
 934         * contrib/gcc-with-excheck: Remove.
 935         * contrib/exsummary.py: Remove.
 936         * contrib/excheck.py: Remove.
 937
 938 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
 939
 940         * thread.c (delete_thread_1): Add gdb_assert that THR is not
 941         NULL. Initialize tpprev to NULL instead of assigning it
 942         to NULL on the next statement.
 943         * windows-nat.c (windows_delete_thread): Remove check for
 944         main_thread_id before printing thread exit notifications.
 945         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
 946         Remove thread ID check against main_thread_id.
 947         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
 948         windows_delete_thread.
 949         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
 950
 951 2019-01-04  Tom Tromey  <tom@tromey.com>
 952
 953         * compile/compile.c (_initialize_compile): Use upper case for
 954         metasyntactic variables.
 955         * symmisc.c (_initialize_symmisc): Use upper case for
 956         metasyntactic variables.
 957         * psymtab.c (_initialize_psymtab): Use upper case for
 958         metasyntactic variables.
 959         * demangle.c (demangle_command): Use upper case for metasyntactic
 960         variables.
 961         (_initialize_demangler): Likewise.
 962         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
 963         variables.
 964
 965 2019-01-03  Tom Tromey  <tom@tromey.com>
 966
 967         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
 968
 969 2019-01-03  Tom Tromey  <tom@tromey.com>
 970
 971         * python/py-symtab.c (salpy_str): Update.
 972         (struct salpy_sal_object) <symtab>: Now a PyObject.
 973         (salpy_dealloc): Update.
 974         (del_objfile_sal): Use gdbpy_ref.
 975
 976 2019-01-03  Tom Tromey  <tom@tromey.com>
 977
 978         * python/py-type.c (convert_field): Use new_reference.  Return
 979         gdbpy_ref.
 980         (make_fielditem): Return gdbpy_ref.
 981         (typy_fields): Update.
 982         (typy_getitem): Update.
 983         (field_name): Return gdbpy_ref.  Use new_reference.
 984         (typy_iterator_iternext): Update.
 985
 986 2019-01-03  Tom Tromey  <tom@tromey.com>
 987
 988         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
 989
 990 2019-01-03  Tom Tromey  <tom@tromey.com>
 991
 992         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
 993         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
 994         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
 995         (pspy_set_frame_filters, pspy_set_frame_unwinders)
 996         (pspy_set_type_printers): Likewise.
 997         * python/py-function.c (fnpy_init): Use gdbpy_ref.
 998         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
 999         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1000         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1001         (objfpy_set_type_printers): Likewise.
1002
1003 2019-01-03  Tom Tromey  <tom@tromey.com>
1004
1005         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1006         (gdbpy_print_stack): Use gdbpy_err_fetch.
1007         * python/python-internal.h (class gdbpy_err_fetch): New class.
1008         (class gdbpy_enter) <m_error_type, m_error_value,
1009         m_error_traceback>: Remove.
1010         <m_error>: New member.
1011         (gdbpy_exception_to_string): Don't declare.
1012         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1013         * python/py-value.c (convert_value_from_python): Use
1014         gdbpy_err_fetch.
1015         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1016         gdbpy_exception_to_string.
1017         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1018         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1019         gdbpy_err_fetch.
1020
1021 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1022
1023         * linux-nat.c (delete_lwp_cleanup): Delete.
1024         (struct lwp_deleter): New struct.
1025         (lwp_info_up): New typedef.
1026         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1027         lwp_info_up.
1028
1029 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1030
1031         * linux-fork.c (class scoped_switch_fork_info): New class.
1032         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1033
1034 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1035
1036         * valops.c (find_overload_match): Remove use of null_cleanup, and
1037         calls to do_cleanups.
1038
1039 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1040
1041         * compile/compile-cplus-types.c
1042         (compile_cplus_instance::decl_name): Handle changes to
1043         cp_func_name.
1044         * cp-support.c (cp_func_name): Update header comment, update
1045         return type.
1046         * cp-support.h (cp_func_name): Update return type in declaration.
1047         * valops.c (find_overload_match): Move temp_func local to top
1048         level of function and change its type.  Use temp_func to hold and
1049         delete temporary string obtained from cp_func_name.
1050
1051 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1052
1053         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1054         gdb::char_vector, remove cleanup, and update uses of `msg`.
1055
1056 2019-01-03  Jim Wilson  <jimw@sifive.com>
1057
1058         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1059
1060 2019-01-02  Tom Tromey  <tom@tromey.com>
1061
1062         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1063         (tdesc_parse_xml): Remove cleanups.
1064         * target-descriptions.h (make_cleanup_free_target_description):
1065         Don't declare.
1066         (target_desc_deleter): New struct.
1067         (target_desc_up): New typedef.
1068         * target-descriptions.c (target_desc_deleter::operator()): Rename
1069         from free_target_description.
1070         (make_cleanup_free_target_description): Remove.
1071
1072 2019-01-02  Tom Tromey  <tom@tromey.com>
1073
1074         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1075         constructor, destructor.
1076         (linespec_parser): Remove typedef.
1077         (~linespec_parser): Rename from linespec_parser_delete.
1078         (linespec_lex_to_end, linespec_complete_label)
1079         (linespec_complete): Update.
1080         (decode_line_full): Remove cleanups.
1081         (decode_line_1): Update.
1082
1083 2019-01-02  Tom Tromey  <tom@tromey.com>
1084
1085         * python/python-internal.h (inferior_to_inferior_object): Change
1086         return type.
1087         * python/py-exitedevent.c (create_exited_event_object): Update.
1088         * python/py-inferior.c (inferior_to_inferior_object): Return
1089         gdbpy_ref.
1090         (python_new_inferior, python_inferior_deleted)
1091         (thread_to_thread_object, delete_thread_object)
1092         (build_inferior_list, gdbpy_selected_inferior): Update.
1093         * python/py-infthread.c (create_thread_object): Update.  Also fail
1094         if inferior_to_inferior_object fails.
1095
1096 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1097
1098         * inferior.h (class inferior) <displaced_step_state>: New field.
1099         * infrun.h (struct displaced_step_state): Move here from
1100         infrun.c.  Initialize fields, add constructor.
1101         <inf>: Remove field.
1102         <reset>: New method.
1103         * infrun.c (struct displaced_step_inferior_state): Move to
1104         infrun.h.
1105         (displaced_step_inferior_states): Remove.
1106         (get_displaced_stepping_state): Adust.
1107         (displaced_step_in_progress_any_inferior): Adjust.
1108         (displaced_step_in_progress_thread): Adjust.
1109         (displaced_step_in_progress): Adjust.
1110         (add_displaced_stepping_state): Remove.
1111         (get_displaced_step_closure_by_addr): Adjust.
1112         (remove_displaced_stepping_state): Remove.
1113         (infrun_inferior_exit): Call displaced_step_state.reset.
1114         (use_displaced_stepping): Don't check for NULL.
1115         (displaced_step_prepare_throw): Call
1116         get_displaced_stepping_state.
1117         (displaced_step_fixup): Don't check for NULL.
1118         (prepare_for_detach): Don't check for NULL.
1119
1120 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1121
1122         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
1123          in case of call that did not complete.
1124
1125 2019-01-02  Andrey Utkin  <autkin@undo.io>
1126
1127         * symfile.c (find_separate_debug_file): Fix search of debug files for
1128         remote debuggee.
1129
1130 2019-01-02  Tom Tromey  <tom@tromey.com>
1131
1132         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
1133         indentation.
1134         * python/py-frame.c (frapy_older): Remove cast.
1135         (frapy_newer): Likewise.
1136         * python/py-breakpoint.c (local_setattro): Remove cast.
1137         * python/py-arch.c (archpy_name): Remove local variable.
1138         * python/py-type.c (gdbpy_lookup_type): Remove cast.
1139
1140 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
1141
1142         * unittests/basic_string_view/element_access/char/empty.cc:
1143         Fix year range in copyright header.
1144
1145 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1146
1147         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
1148         Delete.
1149         <operator==>: Update with for removed field.
1150         <hash>: Likewise.
1151         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
1152         <isa_features>: ...this.
1153         <abi_features>: New field.
1154         (riscv_isa_flen): Update comment.
1155         (riscv_abi_xlen): New declaration.
1156         (riscv_abi_flen): New declaration.
1157         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
1158         isa_features.
1159         (riscv_abi_xlen): New function.
1160         (riscv_isa_flen): Update to get answer from isa_features.
1161         (riscv_abi_flen): New function.
1162         (riscv_has_fp_abi): Update to get answer from abi_features.
1163         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
1164         xlen and flen.
1165         (riscv_call_info) <xlen, flen>: Update comment.
1166         (riscv_call_arg_struct): Remove invalid assertions
1167         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
1168         is removed.
1169         (riscv_gdbarch_init): Gather isa features and abi features
1170         separately, ensure both match on the gdbarch when reusing an old
1171         gdbarch.  Relax an error check to allow 32-bit abi float to run on
1172         a target with 64-bit float hardware.
1173
1174 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1175
1176         * source.c (search_command_helper): Stop reverse search
1177         when line 1 has been searched.
1178
1179 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1180
1181         * record-full.c (record_full_base_target::close): Rewrite
1182         record_full_core_buf_list free logic.
1183
1184 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1185
1186         * break-catch-syscall.c (print_one_catch_syscall): xfree
1187         the last text.
1188
1189 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1190
1191         * top.c (print_gdb_version): Update Copyright year in version
1192         message.
1193
1194 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1195
1196         Update copyright year range in all GDB files.
1197
1198 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
1199
1200         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
1201
1202 For older changes see ChangeLog-2018.
1203 \f
1204 Local Variables:
1205 mode: change-log
1206 left-margin: 8
1207 fill-column: 74
1208 version-control: never
1209 coding: utf-8
1210 End:
1211