gdb/ChangeLog

   1 2019-07-11  Tom Tromey  <tromey@adacore.com>
   2
   3         * python/py-inferior.c (add_thread_object): Don't use thread_obj
   4         after it has been moved.
   5
   6 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
   7
   8         * valops.c (value_must_coerce_to_target): Change return type to
   9         bool.
  10         * value.h (value_must_coerce_to_target): Likewise.
  11
  12 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
  13
  14         * breakpoint.c (is_hardware_watchpoint): Remove
  15         forward-declaration.
  16         (is_masked_watchpoint): Change return type to bool.
  17         (is_tracepoint): Likewise.
  18         (is_breakpoint): Likewise.
  19         (is_hardware_watchpoint): Likewise.
  20         (is_watchpoint): Likewise.
  21         (is_no_memory_software_watchpoint): Likewise.
  22         (is_catchpoint): Likewise.
  23         (breakpoint_1): Make FILTER parameter's return type bool.
  24         is_masked_watchpoint): Change return type to bool.
  25         (save_breakpoints): Make FILTER parameter's return type bool.
  26         * breakpoint.h (is_breakpoint): Change return type to bool.
  27         (is_watchpoint): Likewise.
  28         (is_catchpoint): Likewise.
  29         (is_tracepoint): Likewise.
  30
  31 2019-07-10  Tom Tromey  <tom@tromey.com>
  32
  33         * defs.h: Don't include gdbarch.h.
  34         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
  35         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
  36         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
  37         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
  38         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
  39         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
  40         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
  41         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
  42         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
  43         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
  44         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
  45         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
  46         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
  47         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
  48         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
  49         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
  50         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
  51         record-btrace.c, record.h, regcache-dump.c, regcache.h,
  52         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
  53         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
  54         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
  55         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
  56         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
  57         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
  58         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
  59         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
  60         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
  61
  62 2019-07-10  Tom Tromey  <tromey@adacore.com>
  63
  64         * ada-lang.h (is_ada_exception_catchpoint): Declare.
  65         * breakpoint.c (init_ada_exception_breakpoint): Register as
  66         bp_catchpoint.
  67         (print_one_breakpoint_location, print_one_breakpoint): Use
  68         is_ada_exception_catchpoint.
  69         * ada-lang.c (class ada_catchpoint_location): Pass
  70         bp_loc_software_breakpoint to bp_location constructor.
  71         (is_ada_exception_catchpoint): New function.
  72
  73 2019-07-10  Tom Tromey  <tromey@adacore.com>
  74
  75         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
  76         VEC.
  77         (struct arm_exidx_entry): New method operator<.
  78         (struct arm_exidx_data) <section_maps>: Change type.
  79         (arm_exidx_data_free): Remove.
  80         (arm_exidx_data_key): Change type.  Move lower.
  81         (arm_exidx_new_objfile): Update.
  82         (arm_compare_exidx_entries): Remove.
  83         (arm_find_exidx_entry, _initialize_arm_tdep)
  84
  85 2019-07-10  Tom Tromey  <tromey@adacore.com>
  86
  87         * solib-spu.c (ocl_program_data_key): Change type.
  88         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
  89         Update.
  90
  91 2019-07-10  Tom Tromey  <tromey@adacore.com>
  92
  93         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
  94         (struct solib_aix_inferior_data) <library_list>: Change type.
  95         (solib_aix_inferior_data_handle): Change type.
  96         (get_solib_aix_inferior_data): Update.
  97         (solib_aix_free_library_list): Remove.
  98         (library_list_start_library): Update.
  99         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 100         return type.
 101         (solib_aix_get_library_list)
 102         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 103         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 104
 105 2019-07-10  Tom Tromey  <tromey@adacore.com>
 106
 107         * solib-dsbt.c (struct dsbt_info): Add initializers.
 108         (solib_dsbt_pspace_data): Change type.
 109         (dsbt_pspace_data_cleanup): Remove.
 110         (get_dsbt_info, _initialize_dsbt_solib): Update.
 111
 112 2019-07-10  Tom Tromey  <tromey@adacore.com>
 113
 114         * spu-tdep.c (spu_overlay_data): Change type.
 115         (spu_get_overlay_table, spu_overlay_new_objfile)
 116         (_initialize_spu_tdep): Update.
 117
 118 2019-07-10  Tom Tromey  <tromey@adacore.com>
 119
 120         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 121         destructor.
 122         (dbx_objfile_data_key): Change type and declare later.
 123         (DBX_SYMFILE_INFO): Rewrite.
 124         * dbxread.c (dbx_objfile_data_key): Change type.
 125         (dbx_symfile_init): Update.
 126         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 127         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 128         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 129
 130 2019-07-10  Tom Tromey  <tromey@adacore.com>
 131
 132         * jit.c (jit_program_space_key): Change type.  Move lower.
 133         (get_jit_program_space_data): Update.
 134         (jit_program_space_data_cleanup): Remove.
 135         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 136         Update.
 137         (struct jit_program_space_data): Add initializers.
 138
 139 2019-07-10  Tom Tromey  <tromey@adacore.com>
 140
 141         * solib-darwin.c (struct darwin_info): Add initializers.
 142         (solib_darwin_pspace_data): Change type.
 143         (darwin_pspace_data_cleanup): Remove.
 144         (get_darwin_info, _initialize_darwin_solib): Update.
 145
 146 2019-07-10  Tom Tromey  <tromey@adacore.com>
 147
 148         * remote-sim.c (struct sim_inferior_data): Add initializers,
 149         constructor, and destructor.
 150         (sim_inferior_data_key): Change type.  Move lower.
 151         (check_for_duplicate_sim_descriptor): Update.
 152         (get_sim_inferior_data): Use new.  Update.
 153         (~sim_inferior_data_cleanup): Rename from
 154         sim_inferior_data_cleanup.  Simplify.
 155         (gdbsim_close_inferior, simulator_command)
 156         (sim_command_completer, _initialize_remote_sim): Update.
 157         (next_pid, INITIAL_PID): Move earlier.
 158
 159 2019-07-10  Tom Tromey  <tromey@adacore.com>
 160
 161         * python/python-internal.h (create_thread_object): Return
 162         gdbpy_ref.
 163         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 164         * python/py-inferior.c (struct threadlist_entry): Add
 165         constructor.
 166         <thread_obj>: Now a gdbpy_ref.
 167         (thread_to_thread_object): Update.
 168         (add_thread_object): Use new.
 169         (delete_thread_object): Use delete.
 170         (infpy_threads): Update.
 171         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 172         GIL.
 173
 174 2019-07-10  Tom Tromey  <tromey@adacore.com>
 175
 176         * valops.c (value_cast): Specialize error message for Ada.
 177
 178 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 179
 180         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 181
 182 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 183
 184         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 185         bpstat_should_step): Return bool, adjust comments.
 186         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 187         bpstat_should_step): Likewise.
 188
 189 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 190
 191         * features/Makefile: Use feature target descriptions for Arm.
 192         * features/arm/arm-core.c: Generate new file.
 193         * features/arm/arm-fpa.c: Likewise.
 194         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 195         * features/arm/arm-m-profile.c: Likewise.
 196         * features/arm/arm-vfpv2.c: Likewise.
 197         * features/arm/arm-vfpv3.c: Likewise.
 198         * features/arm/xscale-iwmmxt.c: Likewise.
 199         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 200
 201 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 202
 203         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 204         ptrace earlier.
 205
 206 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 207
 208         * features/aarch64-pauth.c: Regenerate.
 209
 210 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 211
 212         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 213         bool.
 214         (bpstat_what): Use false instead of 0.
 215
 216 2019-07-09  Pedro Alves  <palves@redhat.com>
 217
 218         * break-catch-throw.c (is_exception_catchpoint): New.
 219         * breakpoint.c (print_one_breakpoint_location): New parameter
 220         'raw_loc'.  Handle it.  Use
 221         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 222         looking at the breakpoint's type.
 223         (print_one_breakpoint): If handling "maint info breakpoints", also
 224         print locations of exception catchpoints.
 225         * breakpoint.h (is_exception_catchpoint): Declare.
 226
 227 2019-07-09  Pedro Alves  <palves@redhat.com>
 228
 229         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 230         "addr" field.
 231         (allocate_location_exception_catchpoint): New.
 232         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 233         (initialize_throw_catchpoint_ops): Install
 234         allocate_location_exception_catchpoint as allocate_location
 235         method.
 236         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 237         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 238         bp_loc_other.
 239         (breakpoint_address_is_meaningful): Delete.
 240         (bl_address_is_meaningful): New.
 241         (breakpoint_locations_match): Adjust comment.
 242         (bp_location_from_bp_type): New, factored out of...
 243         (bp_location::bp_location(breakpoint *)): ... this.
 244         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 245         factored out of...
 246         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 247         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 248         breakpoint_address_is_meaningful.
 249         (bp_locations_compare): Adjust comment.
 250         (update_global_location_list): Use bl_address_is_meaningful
 251         instead of breakpoint_address_is_meaningful.
 252         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 253         explicit.
 254         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 255         * python/py-breakpoint.c (bppy_get_location): No longer check
 256         whether location is null.
 257
 258 2019-07-09  Pedro Alves  <palves@redhat.com>
 259
 260         PR c++/15468
 261         * breakpoint.c (print_one_breakpoint_location): Remove
 262         single-location assert.
 263
 264 2019-07-09  Tom Tromey  <tom@tromey.com>
 265
 266         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 267         * configure: Rebuild.
 268         * configure.ac: Change common to gdbsupport.
 269         * gdbsupport: Rename from common.
 270         * acinclude.m4: Change common to gdbsupport.
 271         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 272         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 273         gdbsupport.
 274         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 275         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 276         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 277         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 278         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 279         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 280         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 281         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 282         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 283         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 284         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 285         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 286         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 287         coff-pe-read.c, command.h, compile/compile-c-support.c,
 288         compile/compile-c.h, compile/compile-cplus-symbols.c,
 289         compile/compile-cplus-types.c, compile/compile-cplus.h,
 290         compile/compile-loc2c.c, compile/compile.c, completer.c,
 291         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 292         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 293         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 294         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 295         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 296         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 297         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 298         features/aarch64-core.c, features/aarch64-fpu.c,
 299         features/aarch64-pauth.c, features/aarch64-sve.c,
 300         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 301         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 302         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 303         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 304         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 305         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 306         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 307         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 308         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 309         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 310         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 311         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 312         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 313         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 314         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 315         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 316         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 317         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 318         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 319         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 320         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 321         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 322         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 323         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 324         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 325         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 326         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 327         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 328         minsyms.c, mips-linux-tdep.c, namespace.h,
 329         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 330         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 331         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 332         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 333         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 334         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 335         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 336         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 337         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 338         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 339         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 340         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 341         procfs.c, producer.c, progspace.h, psymtab.h,
 342         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 343         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 344         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 345         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 346         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 347         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 348         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 349         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 350         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 351         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 352         target-memory.c, target.c, target.h, target/waitstatus.c,
 353         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 354         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 355         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 356         unittests/array-view-selftests.c,
 357         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 358         unittests/common-utils-selftests.c,
 359         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 360         unittests/format_pieces-selftests.c,
 361         unittests/function-view-selftests.c,
 362         unittests/lookup_name_info-selftests.c,
 363         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 364         unittests/mkdir-recursive-selftests.c,
 365         unittests/observable-selftests.c,
 366         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 367         unittests/parse-connection-spec-selftests.c,
 368         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 369         unittests/scoped_fd-selftests.c,
 370         unittests/scoped_mmap-selftests.c,
 371         unittests/scoped_restore-selftests.c,
 372         unittests/string_view-selftests.c, unittests/style-selftests.c,
 373         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 374         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 375         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 376         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 377         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 378         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 379
 380 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 381
 382         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 383         bool value.
 384         (decode_digits_ordinary): Set explicit_line field in sal.
 385         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 386         symtab_and_line that was set on an explicit line number in
 387         assembler code.  Do always update the recorded symtab and line if
 388         we do skip the prologue.
 389
 390 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 391
 392         * breakpoint.c (set_breakpoint_location_function): Remove
 393         explicit_loc parameter.
 394         (momentary_breakpoint_from_master): Update call to
 395         set_breakpoint_location_function.
 396         (add_location_to_breakpoint): Likewise.
 397
 398 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 399
 400         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 401         required features based on default bfd type when no specific bfd
 402         is present.
 403
 404 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 405
 406         * NEWS: Mention that GDB printf and eval commands can now print
 407         C-style and Ada-style convenience var strings without
 408         calling the inferior.
 409         * printcmd.c (printf_c_string): Locally print GDB internal var
 410         instead of transiting via the inferior.
 411         (printf_wide_c_string): Likewise.
 412
 413 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 414
 415         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 416
 417 2019-07-04  Tom Tromey  <tom@tromey.com>
 418
 419         PR tui/24724:
 420         * tui/tui-winsource.c (tui_clear_source_content): Update.
 421         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 422         (tui_update_breakpoint_info): Update.
 423         (tui_set_exec_info_content): Update.
 424         * tui/tui-source.c (tui_set_source_content_nil): Update.
 425         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 426         has_break.
 427         * tui/tui-data.h (enum tui_bp_flag): New.
 428         (tui_bp_flags): New enum flags type.
 429         (struct tui_source_element) <break_mode>: Change type.  Rename
 430         from has_break.
 431         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 432         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 433         constants.
 434         * tui/tui-winsource.h: Fix comment.
 435
 436 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 437
 438         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 439         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 440         (store_fpregs_to_thread)
 441         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 442         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 443         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 444         (IWMMXT_REGS_SIZE): Add define.
 445         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 446         (fetch_vfp_regs, store_vfp_regs)
 447         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 448         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 449
 450 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 451
 452         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 453         defines.
 454         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 455         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 456         (ARM_INT_REGISTER_SIZE): ...to this.
 457         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 458         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 459         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 460         (arm_linux_collect_gregset, supply_nwfpe_register)
 461         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 462         defines.
 463         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 464         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 465         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 466         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 467         (arm_return_in_memory, arm_store_return_value)
 468         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 469         (arm_record_ld_st_multiple): Likewise.
 470         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 471         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 472
 473 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 474
 475         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 476         AARCH64_DISPLACED_MODIFIED_INSNS.
 477         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 478         (aarch64_displaced_step_copy_insn): Likewise.
 479         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 480         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 481         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 482         ARM_DISPLACED_MODIFIED_INSNS.
 483         * arm-tdep.c (arm_gdbarch_init): Likewise.
 484         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 485         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 486         (struct arm_displaced_step_closure): Use
 487         ARM_DISPLACED_MODIFIED_INSNS.
 488
 489 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 490
 491         * features/Makefile: Remove unused xml files.
 492         * features/aarch64.xml: Remove.
 493         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 494         * features/i386/amd64-avx-avx512.xml: Remove.
 495         * features/i386/amd64-avx-linux.xml: Remove.
 496         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 497         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 498         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 499         * features/i386/amd64-avx-mpx.xml: Remove.
 500         * features/i386/amd64-avx.xml: Remove.
 501         * features/i386/amd64-linux.xml: Remove.
 502         * features/i386/amd64-mpx-linux.xml: Remove.
 503         * features/i386/amd64-mpx.xml: Remove.
 504         * features/i386/amd64.xml: Remove.
 505         * features/i386/i386-avx-avx512-linux.xml: Remove.
 506         * features/i386/i386-avx-avx512.xml: Remove.
 507         * features/i386/i386-avx-linux.xml: Remove.
 508         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 509         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 510         * features/i386/i386-avx-mpx-linux.xml: Remove.
 511         * features/i386/i386-avx-mpx.xml: Remove.
 512         * features/i386/i386-avx.xml: Remove.
 513         * features/i386/i386-linux.xml: Remove.
 514         * features/i386/i386-mmx-linux.xml: Remove.
 515         * features/i386/i386-mmx.xml: Remove.
 516         * features/i386/i386-mpx-linux.xml: Remove.
 517         * features/i386/i386-mpx.xml: Remove.
 518         * features/i386/i386.xml: Remove.
 519         * features/i386/x32-avx-avx512-linux.xml: Remove.
 520         * features/i386/x32-avx-linux.xml: Remove.
 521         * features/i386/x32-linux.xml: Remove.
 522
 523 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 524
 525         * regformats/aarch64.dat: Remove.
 526         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 527         * regformats/i386/amd64-avx-linux.dat: Remove.
 528         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 529         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 530         * regformats/i386/amd64-linux.dat: Remove.
 531         * regformats/i386/amd64-mpx-linux.dat: Remove.
 532         * regformats/i386/amd64.dat: Remove.
 533         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 534         * regformats/i386/i386-avx-linux.dat: Remove.
 535         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 536         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 537         * regformats/i386/i386-linux.dat: Remove.
 538         * regformats/i386/i386-mmx-linux.dat: Remove.
 539         * regformats/i386/i386-mpx-linux.dat: Remove.
 540         * regformats/i386/i386.dat: Remove.
 541         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 542         * regformats/i386/x32-avx-linux.dat: Remove.
 543         * regformats/i386/x32-linux.dat: Remove.
 544
 545 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 546
 547         * aarch64-tdep.c: Remove xml self tests.
 548         * amd64-linux-tdep.c: Likewise.
 549         * amd64-tdep.c: Likewise.
 550         * i386-linux-tdep.c: Likewise.
 551         * i386-tdep.c: Likewise.
 552
 553 2019-07-03  Pedro Alves  <palves@redhat.com>
 554
 555         PR cli/24732
 556         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 557         (pipe_cmd_option_defs): New.
 558         (make_pipe_cmd_options_def_group): New.
 559         (pipe_command): Use gdb::option::process_options.
 560         (pipe_command_completer): New function.
 561         (_initialize_cli_cmds): Install completer for "pipe" command.
 562
 563 2019-07-03  Pedro Alves  <palves@redhat.com>
 564
 565         * cli/cli-option.c (union option_value) <string>: New field.
 566         (struct option_def_and_value): Add ctor, move ctor, dtor and
 567         use DISABLE_COPY_AND_ASSIGN.
 568         (option_def_and_value::clear_value): New.
 569         (parse_option, save_option_value_in_ctx, get_val_type_str)
 570         (add_setshow_cmds_for_options): Handle var_string.
 571         * cli-option.h (union option_def::var_address) <string>: New
 572         field.
 573         (struct string_option_def): New.
 574         * maint-test-options.c (struct test_options_opts): Add default
 575         ctor and use DISABLE_COPY_AND_ASSIGN.
 576         <string_opt>: New field.
 577         (test_options_opts::~test_options_opts): New.
 578         (test_options_opts::dump): Also dump "-string".
 579         (test_options_option_defs): Install "string.
 580
 581 2019-07-03  Pedro Alves  <palves@redhat.com>
 582
 583         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 584         option_value with a null enumeration.
 585         (complete_options): Save the option values in the context.
 586         (save_option_value_in_ctx): New, factored out from ...
 587         (process_options): ... here.
 588         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 589         of the function.
 590         * maint-test-options.c (test_options_opts::dump): New, factored
 591         out from ...
 592         (maintenance_test_options_command_mode): ... here.
 593         (maintenance_test_options_command_completion_result): Delete.
 594         (maintenance_test_options_command_completion_text): Update
 595         comment.
 596         (maintenance_show_test_options_completion_result): Change
 597         prototype.  Just print
 598         maintenance_test_options_command_completion_text.
 599         (save_completion_result): New.
 600         (maintenance_test_options_completer_mode): Pass options context to
 601         complete_options, and then save a dump.
 602         (_initialize_maint_test_options): Use add_cmd to install "maint
 603         show test-options-completion-result".
 604
 605 2019-07-03  Pedro Alves  <palves@redhat.com>
 606
 607         * NEWS (New commands): Mention "with" and "maint with".
 608         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 609         (with_command, with_command_completer): New.
 610         (pipe_command): Adjust to new repeat_previous
 611         interface.
 612         (_initialize_cli_cmds): Install the "with" command and its "w"
 613         alias.
 614         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 615         declarations.
 616         * cli/cli-setshow.c (parse_cli_var_uinteger)
 617         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 618         argument strings for all var_types.
 619         (get_setshow_command_value_string): New, factored out from ...
 620         (do_show_command): ... this.
 621         * cli/cli-setshow.h: Include <string>.
 622         (get_setshow_command_value_string): Declare.
 623         * command.h (repeat_previous): Now returns const char *.  Adjust
 624         comment.
 625         * maint.c: Include "cli/cli-cmds.h".
 626         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 627         (_initialize_maint_cmds): Register the "maintenance with" command.
 628         * top.c (repeat_previous): Move bits from pipe_command here:
 629         Return the saved command line, if any; error out if there's no
 630         command to relaunch.
 631
 632 2019-07-03  Pedro Alves  <palves@redhat.com>
 633
 634         * NEWS (New commands): Mention "maint set/show test-settings"
 635         instead of "maint test-settings".
 636         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 637         (maintenance_test_settings_set_list): Rename to ...
 638         (maintenance_set_test_settings_list): ... this.
 639         (maintenance_test_settings_show_list): Rename to  ...
 640         (maintenance_show_test_settings_list): ... this.
 641         (maintenance_test_settings_cmd): Delete.
 642         (maintenance_test_settings_set_cmd): ...
 643         (maintenance_set_test_settings_cmd): ... this.
 644         (maintenance_test_settings_show_cmd): ...
 645         (maintenance_show_test_settings_cmd): ... this.
 646         (maintenance_test_settings_show_value_cmd):
 647         (maintenance_show_test_settings_value_cmd): ... this.
 648         (_initialize_maint_test_settings): No longer install the "maint
 649         test-settings" prefix command.  Rename "maint test-settings set"
 650         to "maint set test-settings", and "maint test-settings show" to
 651         "maint show test-settings".  Adjust all subcommands.
 652
 653 2019-07-03  Pedro Alves  <palves@redhat.com>
 654
 655         * maint-test-settings.c: Fix file's intro comment.  Replace all
 656         references to "test-options" with references to "test-settings",
 657         in comments.
 658
 659 2019-07-03  Pedro Alves  <palves@redhat.com>
 660
 661         * maint-test-settings.c (maintenance_test_settings_xxx)
 662         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 663         New.
 664         (maintenance_test_settings_enums): Use them.
 665         (maintenance_test_settings_enum): Default to
 666         maintenance_test_settings_xxx.
 667         (_initialize_maint_test_settings): Initialize
 668         MAINTENANCE_TEST_SETTINGS_FILENAME.
 669
 670 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 671
 672         * breakpoint.h (remove_breakpoints_inf): Change return type to
 673         void, move function documentation here.
 674         * breakpoint.c (remove_breakpoints_inf): Change return type to
 675         void, move function documentation to header.
 676
 677 2019-07-02  Pedro Alves  <palves@redhat.com>
 678
 679         * NEWS (Completion improvements): Mention "info threads".
 680         * thread.c (struct info_threads_opts, info_threads_option_defs)
 681         (make_info_threads_options_def_group): New.
 682         (info_threads_command): Use gdb::option::process_options.
 683         (info_threads_command_completer): New.
 684         (_initialize_thread): Use gdb::option::build_help to build the
 685         help text for "info threads".
 686
 687 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 688
 689         * defs.h (generic_load): Move from here...
 690         * symfile.h (generic_load): ... to here.  Rename name parameter
 691         to args.
 692         * symfile.c (generic_load): Add comment.
 693
 694 2019-07-01  Tom Tromey  <tromey@adacore.com>
 695
 696         * dwarf2read.c
 697         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
 698         declaration of without_params.  Fix formatting.
 699
 700 2019-07-01  Tom Tromey  <tromey@adacore.com>
 701
 702         * ada-exp.y (find_primitive_type): Update.
 703         * ada-lang.h (ada_lookup_symbol): Update.
 704         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
 705         parameter.
 706         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
 707
 708 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 709
 710         PR breakpoints/24541
 711         * gdbarch.c: Regenerate.
 712         * gdbarch.h: Regenerate.
 713         * gdbarch.sh: Add 'stap_adjust_register'.
 714         * i386-tdep.c: Include '<unordered_set>'.
 715         (i386_stap_adjust_register): New function.
 716         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
 717         * stap-probe.c (stap_parse_register_operand): Call
 718         'gdbarch_stap_adjust_register'.
 719
 720 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 721
 722         PR python/24742
 723         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
 724         * python/python.c (do_start_initialization): Use 'xmalloc'
 725         instead of 'PyMem_Malloc'.
 726
 727 2019-06-28  Tom Tromey  <tromey@adacore.com>
 728
 729         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
 730         for Ada.
 731
 732 2019-06-27  Tom Tromey  <tromey@adacore.com>
 733
 734         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
 735         objfile_key.
 736         (arm_find_mapping_symbol, arm_record_special_symbol)
 737         (_initialize_arm_tdep): Update.
 738         (arm_objfile_data_free): Remove.
 739
 740 2019-06-27  Tom Tromey  <tromey@adacore.com>
 741
 742         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
 743         to cp_print_static_field.
 744
 745 2019-06-26  Tom Tromey  <tromey@adacore.com>
 746
 747         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
 748         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
 749         declare.
 750
 751 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 752
 753         * features/aarch64-core.c (create_feature_aarch64_core):
 754         Regenerate.
 755         * features/aarch64-core.xml: Add cpsr flags.
 756
 757 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 758
 759         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
 760         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
 761
 762 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 763
 764         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
 765         field.
 766         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
 767         use.
 768         (arm_record_special_symbol): Don't insert new symbol in sorted
 769         position, push it at the end.
 770
 771 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 772
 773         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
 774         (arm_mapping_symbol_s): Remove.
 775         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
 776         (arm_mapping_symbol_vec): New typedef.
 777         (struct arm_per_objfile): Add constructor.
 778         <section_maps>: Change type to
 779         std::unique_ptr<arm_mapping_symbol_vec[]>.
 780         (arm_compare_mapping_symbols): Remove.
 781         (arm_find_mapping_symbol): Adjust to section_maps type change.
 782         (arm_objfile_data_free): Call delete on arm_per_objfile.
 783         (arm_record_special_symbol): Adjust to section_maps type change.
 784         Allocate arm_per_objfile with new.
 785
 786 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 787
 788         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 789         with the command prefix.
 790
 791 2019-06-25  Tom Tromey  <tom@tromey.com>
 792
 793         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 794         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 795
 796 2019-06-25  Tom Tromey  <tom@tromey.com>
 797
 798         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 799         type.
 800         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 801         protected.
 802
 803 2019-06-25  Tom Tromey  <tom@tromey.com>
 804
 805         * tui/tui-winsource.c
 806         (tui_source_window_base::set_is_exec_point_at): Add check against
 807         LOA_ADDRESS.
 808
 809 2019-06-25  Tom Tromey  <tom@tromey.com>
 810
 811         * tui/tui-source.c (tui_set_source_content): Don't check before
 812         xfree.
 813         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 814
 815 2019-06-25  Tom Tromey  <tom@tromey.com>
 816
 817         * tui/tui-winsource.h (tui_update_source_window_as_is)
 818         (tui_alloc_source_buffer, tui_line_is_displayed)
 819         (tui_addr_is_displayed): Change type of win_info.
 820         * tui/tui-winsource.c (tui_update_source_window_as_is)
 821         (tui_clear_source_content, tui_show_source_line)
 822         (tui_show_source_content, tui_source_window_base::refill)
 823         (tui_source_window_base::set_is_exec_point_at)
 824         (tui_source_window_base::set_is_exec_point_at)
 825         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 826         (tui_alloc_source_buffer, tui_line_is_displayed)
 827         (tui_addr_is_displayed): Change type of win_info.  Update.
 828         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 829         (tui_source_window_base::do_make_visible_with_new_height):
 830         Update.
 831         * tui/tui-source.c (tui_set_source_content)
 832         (tui_set_source_content_nil)
 833         (tui_source_window::do_scroll_vertical): Update.
 834         * tui/tui-layout.c (show_layout): Update.
 835         * tui/tui-disasm.c (tui_set_disassem_content)
 836         (tui_disasm_window::do_scroll_vertical): Update.
 837         * tui/tui-data.h (tui_win_content): Remove.
 838         (struct tui_gen_win_info) <content, content_size>: Remove.
 839         (struct tui_source_element): Add initializers and destructor.
 840         (union tui_which_element, struct tui_win_element): Remove.
 841         (struct tui_source_window_base) <content>: New field.
 842         (struct tui_data_window): Remove destructor.
 843         (tui_alloc_content, tui_free_win_content)
 844         (tui_free_all_source_wins_content): Don't declare.
 845         * tui/tui-data.c (tui_initialize_static_data): Update.
 846         (init_content_element, tui_alloc_content): Remove.
 847         (~tui_gen_win_info): Update.
 848         (~tui_data_window, tui_free_all_source_wins_content)
 849         (tui_free_win_content, free_content, free_content_elements):
 850         Remove.
 851
 852 2019-06-25  Tom Tromey  <tom@tromey.com>
 853
 854         * tui/tui-winsource.h (tui_clear_source_content)
 855         (tui_erase_source_content, tui_show_source_content): Change type
 856         of win_info.
 857         * tui/tui-winsource.c (tui_clear_source_content)
 858         (tui_erase_source_content, tui_show_source_content): Change type
 859         of win_info.
 860         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 861         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 862         win_info.
 863         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 864         win_info.
 865         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 866
 867 2019-06-25  Tom Tromey  <tom@tromey.com>
 868
 869         * tui/tui-winsource.c (tui_clear_source_content)
 870         (tui_source_window_base::set_is_exec_point_at): Update.
 871         * tui/tui-source.c (tui_set_source_content_nil): Update.
 872         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 873         a bool.
 874         * tui/tui-data.c (init_content_element): Update.
 875
 876 2019-06-25  Tom Tromey  <tom@tromey.com>
 877
 878         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 879         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 880         * tui/tui-layout.c (init_and_make_win): Update.
 881         * tui/tui.h (enum tui_win_type): Update.
 882         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 883         tui_win_is_auxillary.
 884         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 885         tui_win_is_auxillary.
 886
 887 2019-06-25  Tom Tromey  <tom@tromey.com>
 888
 889         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 890         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 891         (tui_delete_data_content_windows, tui_display_all_data)
 892         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 893         Update.
 894         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 895         * tui/tui-regs.c (tui_last_regs_line_no)
 896         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 897         (tui_show_registers): Update.
 898         (tui_show_register_group): Return void.  Update.
 899         (tui_display_registers_from, tui_display_reg_element_at_line)
 900         (tui_display_registers_from_line, tui_check_register_values):
 901         Update.
 902         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 903         member.
 904         (struct tui_data_window) <regs_content>: Now a std::vector.
 905         <regs_content_count>: Remove.
 906         (tui_add_content_elements, tui_free_data_content): Don't declare.
 907         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 908         (init_content_element): Remove DATA_WIN case.  Add assert.
 909         (tui_add_content_elements): Remove.
 910         (tui_data_window): Update.
 911         (tui_free_data_content): Remove.
 912         (free_content_elements): Remove DATA_WIN case.
 913
 914 2019-06-25  Tom Tromey  <tom@tromey.com>
 915
 916         * tui/tui-data.c (tui_data_item_window): Update.
 917         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 918         * tui/tui-windata.c (tui_display_all_data)
 919         (tui_display_data_from_line): Update.
 920         (tui_check_data_values): Remove.
 921         * tui/tui-regs.c (tui_show_register_group)
 922         (tui_display_reg_element_at_line): Update.
 923         * tui/tui-hooks.c (tui_register_changed)
 924         (tui_refresh_frame_and_register_information): Call
 925         tui_check_register_values.
 926         * tui/tui-data.h (struct tui_data_window) <data_content,
 927         data_content_count, data_type>: Remove.
 928         (enum tui_data_type): Remove.
 929
 930         * tui/tui-data.c (tui_data_window::clear_detail)
 931         (~tui_data_window): Update.
 932
 933 2019-06-25  Tom Tromey  <tom@tromey.com>
 934
 935         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 936         declare.
 937         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 938         Rename from tui_first_data_item_displayed.  Update.
 939         (tui_data_window::refresh_all)
 940         (tui_data_window::do_scroll_vertical): Update.
 941         * tui/tui-data.h (struct tui_data_window)
 942         <first_data_item_displayed>: Declare new method.
 943
 944 2019-06-25  Tom Tromey  <tom@tromey.com>
 945
 946         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 947         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 948         contents...
 949         (tui_initialize_static_data): ...here.
 950
 951 2019-06-25  Tom Tromey  <tom@tromey.com>
 952
 953         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 954         (tui_display_registers_from, tui_check_register_values): Update.
 955         (tui_display_register): Remove win_info parameter; update.
 956         (tui_get_register): Change type of parameters.
 957         * tui/tui-data.h (struct tui_data_element): Remove.
 958         (union tui_which_element) <data>: Remove.
 959         <data_window>: Change type.
 960         (struct tui_data_item_window): New.
 961         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 962         case.  Add assert.
 963         (~tui_data_item_window): New destructor.
 964         (free_content_elements): Remove DATA_ITEM_WIN case.
 965
 966 2019-06-25  Tom Tromey  <tom@tromey.com>
 967
 968         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 969         Remove.
 970
 971 2019-06-25  Tom Tromey  <tom@tromey.com>
 972
 973         * tui/tui-data.h (struct tui_command_element): Remove.
 974         (union tui_which_element) <command>: Remove.
 975         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 976         assert.
 977         (free_content_elements): Remove CMD_WIN case.
 978
 979 2019-06-25  Tom Tromey  <tom@tromey.com>
 980
 981         * tui/tui-layout.c (tui_set_layout): Update.
 982         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 983         * tui/tui-data.c (layout_def): Update.
 984
 985 2019-06-25  Tom Tromey  <tom@tromey.com>
 986
 987         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 988         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 989         (tui_source_window_base::set_new_height): Update.
 990         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 991         Update.
 992         (tui_set_locator_fullname, tui_set_locator_info)
 993         (tui_show_frame_info): Update.
 994         * tui/tui-source.c (tui_set_source_content)
 995         (tui_source_is_displayed): Update.
 996         * tui/tui-layout.c (show_source_disasm_command, show_data)
 997         (show_source_or_disasm_and_command): Update.
 998         * tui/tui-disasm.c (tui_set_disassem_content)
 999         (tui_get_begin_asm_address): Update.
1000         * tui/tui-data.h (struct tui_locator_element): Remove.
1001         (union tui_which_element) <locator>: Remove.
1002         (struct tui_locator_window): New.
1003         (tui_locator_win_info_ptr): Change return type.
1004         * tui/tui-data.c (_locator): Change type.
1005         (tui_locator_win_info_ptr): Change return type.
1006         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1007         (tui_alloc_content): Add assert.
1008
1009 2019-06-25  Tom Tromey  <tom@tromey.com>
1010
1011         * tui/tui-winsource.c
1012         (tui_exec_info_window::maybe_allocate_content): New method.
1013         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1014         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1015         (make_source_or_disasm_window): Add cast.
1016         * tui/tui-data.h (union tui_which_element) <simple_string>:
1017         Remove.
1018         (struct tui_source_info): New.
1019         (struct tui_source_window_base) <execution_info>: Change type.
1020         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1021         case, and add assert.
1022         (tui_alloc_content): Add assert.
1023
1024 2019-06-25  Tom Tromey  <tom@tromey.com>
1025
1026         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1027         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1028         * tui/tui-data.c (tui_alloc_win_info): Remove.
1029
1030 2019-06-25  Tom Tromey  <tom@tromey.com>
1031
1032         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1033         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1034         can_highlight.
1035
1036 2019-06-25  Tom Tromey  <tom@tromey.com>
1037
1038         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1039         make_visible_with_new_height method.
1040         (tui_win_info::make_visible_with_new_height): New method.
1041         (tui_source_window_base::do_make_visible_with_new_height)
1042         (tui_data_window::do_make_visible_with_new_height)
1043         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1044         (make_visible_with_new_height): Remove.
1045         (tui_resize_all, tui_adjust_win_heights): Use
1046         make_visible_with_new_height method.
1047         * tui/tui-data.h (struct tui_win_info)
1048         <do_make_visible_with_new_height, make_visible_with_new_height>:
1049         New methods.
1050         (struct tui_source_window_base, struct tui_data_window)
1051         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1052         methods.
1053
1054 2019-06-25  Tom Tromey  <tom@tromey.com>
1055
1056         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1057         method.
1058         (update_tab_width): Call update_tab_width method.
1059         * tui/tui-data.h (struct tui_win_info)
1060         (struct tui_source_window_base) <update_tab_width>: New methods.
1061
1062 2019-06-25  Tom Tromey  <tom@tromey.com>
1063
1064         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1065         parameter.
1066         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1067         parameter.
1068         (tui_gen_win_info::make_visible): Update.
1069         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1070         parameter.
1071         * tui/tui-data.h (enum tui_box): New enum.
1072         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1073
1074 2019-06-25  Tom Tromey  <tom@tromey.com>
1075
1076         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1077         init_and_make_win for EXEC_INFO_WIN.
1078         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1079         longer inline.
1080         (struct tui_win_info) <~tui_win_info>: Inline.
1081         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1082         Don't declare.
1083         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1084         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1085         Remove.
1086         (tui_initialize_static_data): Update.
1087         (~tui_gen_win_info): Handle more cleanup here.
1088         (~tui_source_window_base): Delete "execution_info".
1089         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1090
1091 2019-06-25  Tom Tromey  <tom@tromey.com>
1092
1093         * tui/tui-layout.c (make_command_window): Don't set
1094         can_highlight.
1095         (show_source_disasm_command): Call the reset method.
1096         (show_data): Don't set can_highlight.  Call the reset method.
1097         (tui_gen_win_info::reset): Rename from init_gen_win_info
1098         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1099         (show_source_or_disasm_and_command): Call the reset method.
1100         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1101         (struct tui_cmd_window): Set can_highlight.
1102
1103 2019-06-25  Tom Tromey  <tom@tromey.com>
1104
1105         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1106         from make_visible.
1107         (tui_make_visible, tui_make_invisible): Rewrite.
1108         (tui_win_info::make_visible): Remove.
1109         (tui_source_window_base::make_visible): Update.
1110         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1111         method.  Moved from...
1112         (struct tui_win_info) <make_visible>: ...here.
1113
1114 2019-06-25  Tom Tromey  <tom@tromey.com>
1115
1116         * tui/tui-winsource.c
1117         (tui_source_window_base::do_scroll_horizontal): Remove direction
1118         parameter.
1119         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1120         direction parameter.
1121         * tui/tui-win.c (tui_win_info::forward_scroll)
1122         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1123         (tui_win_info::right_scroll): Update.
1124         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1125         direction parameter.
1126         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1127         direction parameter.
1128         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1129         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1130         Remove direction parameter.
1131         (struct tui_source_window_base, struct tui_source_window)
1132         (struct tui_disasm_window, struct tui_data_window)
1133         (struct tui_cmd_window): Update.
1134
1135 2019-06-25  Tom Tromey  <tom@tromey.com>
1136
1137         * tui/tui-winsource.h (tui_set_exec_info_content)
1138         (tui_show_exec_info_content, tui_erase_exec_info_content)
1139         (tui_clear_exec_info_content, tui_update_exec_info): Change
1140         argument to tui_source_window_base.
1141         * tui/tui-winsource.c (tui_set_exec_info_content)
1142         (tui_show_exec_info_content, tui_erase_exec_info_content)
1143         (tui_clear_exec_info_content, tui_update_exec_info): Change
1144         argument to tui_source_window_base.
1145
1146 2019-06-25  Tom Tromey  <tom@tromey.com>
1147
1148         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1149         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1150
1151 2019-06-25  Tom Tromey  <tom@tromey.com>
1152
1153         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1154         check.
1155
1156 2019-06-25  Tom Tromey  <tom@tromey.com>
1157
1158         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1159         type to void.
1160         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1161         type to void.
1162         * tui/tui-source.c (tui_set_source_content): Update.
1163         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1164
1165 2019-06-25  Tom Tromey  <tom@tromey.com>
1166
1167         * tui/tui-win.c (window_name_completer, tui_set_focus)
1168         (tui_all_windows_info): Use name method.
1169         * tui/tui-data.h (struct tui_gen_win_info)
1170         (struct tui_source_window, struct tui_disasm_window)
1171         (struct tui_data_window, struct tui_cmd_window) <name>: New
1172         method.
1173         (tui_win_name): Don't declare.
1174         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1175         (tui_win_name): Remove.
1176
1177 2019-06-25  Tom Tromey  <tom@tromey.com>
1178
1179         * tui/tui-winsource.h (tui_update_source_window)
1180         (tui_update_source_window_as_is): Change parameter type.
1181         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1182         to be a tui_source_window_base.
1183         (tui_update_source_window_as_is): Likewise.
1184         * tui/tui-win.c (make_visible_with_new_height): Update.
1185
1186 2019-06-25  Tom Tromey  <tom@tromey.com>
1187
1188         * tui/tui-winsource.c (tui_erase_source_content)
1189         (tui_show_source_content, tui_show_exec_info_content)
1190         (tui_erase_exec_info_content): Use refresh_window method.
1191         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1192         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1193         from tui_refresh_win.
1194         (tui_data_window::refresh_window): New method.
1195         (tui_win_info::refresh, tui_source_window_base::refresh)
1196         (tui_refresh_all): Use refresh_window method.
1197         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1198         method.
1199         * tui/tui-regs.c (tui_display_register): Call refresh_window
1200         method.
1201         * tui/tui-layout.c (show_source_disasm_command)
1202         (show_source_or_disasm_and_command): Call refresh_window method.
1203         * tui/tui-data.h (struct tui_gen_win_info)
1204         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1205         New method.
1206
1207 2019-06-25  Tom Tromey  <tom@tromey.com>
1208
1209         * tui/tui.c (tui_rl_other_window, tui_enable)
1210         (tui_is_window_visible, tui_get_command_dimension): Update.
1211         * tui/tui-winsource.c (tui_update_source_window_as_is)
1212         (tui_clear_source_content, tui_erase_source_content)
1213         (tui_show_source_line, tui_source_window_base::refill)
1214         (tui_source_window_base::do_scroll_horizontal)
1215         (tui_source_window_base::set_is_exec_point_at)
1216         (tui_update_breakpoint_info, tui_set_exec_info_content)
1217         (tui_alloc_source_buffer, tui_line_is_displayed)
1218         (tui_addr_is_displayed): Update.
1219         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1220         (tui_check_and_display_highlight_if_needed)
1221         (tui_win_info::make_visible, tui_win_info::refresh)
1222         (tui_refresh_all): Update.
1223         * tui/tui-windata.c (tui_first_data_item_displayed)
1224         (tui_delete_data_content_windows, tui_erase_data_content)
1225         (tui_display_all_data, tui_data_window::refresh_all)
1226         (tui_check_data_values): Update.
1227         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1228         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1229         (tui_win_info::backward_scroll, tui_refresh_all_win)
1230         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1231         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1232         (tui_source_window_base::set_new_height)
1233         (tui_data_window::set_new_height)
1234         (make_invisible_and_set_new_height)
1235         (make_visible_with_new_height, new_height_ok)
1236         (parse_scrolling_args): Update.
1237         * tui/tui-stack.c (tui_show_frame_info): Update.
1238         * tui/tui-source.c (tui_set_source_content)
1239         (tui_set_source_content_nil, tui_source_is_displayed)
1240         (tui_source_window::do_scroll_vertical): Update.
1241         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1242         (tui_display_registers_from, tui_display_reg_element_at_line)
1243         (tui_check_register_values, tui_reg_command): Update.
1244         * tui/tui-layout.c (tui_default_win_height)
1245         (show_source_disasm_command, show_data, init_and_make_win)
1246         (show_source_or_disasm_and_command): Update.
1247         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1248         (tui_redisplay_readline, tui_mld_flush)
1249         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1250         (tui_getc): Update.
1251         * tui/tui-disasm.c (tui_set_disassem_content)
1252         (tui_disasm_window::do_scroll_vertical): Update.
1253         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1254         Now virtual.
1255         (struct tui_win_info): Derive from tui_gen_win_info.
1256         <~tui_win_info>: Mark as override.
1257         <generic>: Remove member.
1258         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1259         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1260         (~tui_data_window, ~tui_win_info)
1261         (tui_free_all_source_wins_content): Update.
1262         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1263
1264 2019-06-25  Tom Tromey  <tom@tromey.com>
1265
1266         * tui/tui-layout.c (init_and_make_win): Use new.
1267         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1268         destructor, initializers.
1269         (tui_alloc_generic_win_info): Don't declare.
1270         * tui/tui-data.c (_locator): Add argument to constructor.
1271         (source_win, disasm_win): New globals.
1272         (exec_info): Remove.
1273         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1274         Update.
1275         (tui_alloc_generic_win_info): Remove.
1276         (init_content_element): Use new.
1277         (tui_win_info::tui_win_info): Update.
1278         (free_content_elements) <case DATA_WIN>: Use delete.
1279
1280 2019-06-25  Tom Tromey  <tom@tromey.com>
1281
1282         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1283         * tui/tui-windata.c (tui_first_data_item_displayed)
1284         (tui_delete_data_content_windows): Update.
1285         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1286         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1287         (tui_display_registers_from, tui_check_register_values): Update.
1288         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1289         pointer.
1290         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1291         window.
1292         (tui_free_data_content): Update.
1293         (free_content_elements) <case DATA_WIN>: Free the window.
1294
1295 2019-06-25  Tom Tromey  <tom@tromey.com>
1296
1297         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1298         Update.
1299         * tui/tui-layout.c (make_command_window)
1300         (show_source_disasm_command, show_data, init_and_make_win)
1301         (show_source_or_disasm_and_command): Update.
1302         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1303         method.
1304         <can_highight, is_highlighted>: Now bool.
1305         (tui_set_win_highlight): Don't declare.
1306         * tui/tui-data.c (tui_set_win_highlight): Remove.
1307
1308 2019-06-25  Tom Tromey  <tom@tromey.com>
1309
1310         * tui/tui-wingeneral.c (make_visible): Remove check of window
1311         type.
1312
1313 2019-06-25  Tom Tromey  <tom@tromey.com>
1314
1315         * tui/tui-win.c (tui_win_info::max_height)
1316         (tui_cmd_window::max_height): New methods.
1317         (new_height_ok): Call max_height.
1318         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1319         <max_height>: New method.
1320
1321 2019-06-25  Tom Tromey  <tom@tromey.com>
1322
1323         * tui/tui-win.c (tui_source_window_base::set_new_height)
1324         (tui_data_window::set_new_height): New methods.
1325         (make_invisible_and_set_new_height): Call set_new_height method.
1326         * tui/tui-data.h (struct tui_win_info)
1327         (struct tui_source_window_base, struct tui_data_window)
1328         <set_new_height>: New method.
1329
1330 2019-06-25  Tom Tromey  <tom@tromey.com>
1331
1332         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1333         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1334         tui_refresh_data_win.
1335         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1336         method.
1337         (tui_refresh_all_win): Call the refresh_all method.
1338         (tui_set_focus): Likewise.
1339         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1340         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1341         Likewise.
1342
1343 2019-06-25  Tom Tromey  <tom@tromey.com>
1344
1345         * tui/tui-winsource.h (tui_refill_source_window)
1346         (tui_set_is_exec_point_at): Don't declare.
1347         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1348         (tui_source_window_base::refill): Rename from
1349         tui_refill_source_window.
1350         (tui_source_window_base::do_scroll_horizontal): Update.
1351         (tui_source_window_base::set_is_exec_point_at): Rename from
1352         tui_set_is_exec_point_at.
1353         (tui_update_all_breakpoint_info): Update.
1354         * tui/tui-stack.c (tui_show_frame_info): Update.
1355         * tui/tui-layout.c (show_data): Add cast.
1356         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1357         * tui/tui-data.h (struct tui_source_window_base) <refill,
1358         set_is_exec_point_at>: New methods.
1359         (tui_source_windows, tui_add_to_source_windows): Update types.
1360         (tui_add_to_source_windows): Remove redundant declaration.
1361         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1362         (tui_source_windows): Change return type.
1363         (tui_clear_source_windows_detail): Update.
1364         (tui_add_to_source_windows): Change type of parameter.
1365         (tui_free_all_source_wins_content): Update.
1366
1367 2019-06-25  Tom Tromey  <tom@tromey.com>
1368
1369         * tui/tui-wingeneral.c (tui_win_info::refresh)
1370         (tui_source_window_base::refresh): New methods.
1371         (tui_refresh_all): Call the refresh method.
1372         * tui/tui-data.h (struct tui_win_info)
1373         (struct tui_source_window_base) <refresh>: New method.
1374
1375 2019-06-25  Tom Tromey  <tom@tromey.com>
1376
1377         * tui/tui.h (tui_is_window_visible): Return bool.
1378         * tui/tui.c (tui_is_window_visible): Return bool.
1379         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1380         (tui_make_visible, tui_make_invisible)
1381         (tui_win_info::make_visible)
1382         (tui_source_window_base::make_visible, make_all_visible)
1383         (tui_make_all_visible, tui_make_all_invisible): Update.
1384         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1385         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1386         bool.
1387         (struct tui_win_info, struct tui_source_window_base)
1388         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1389         * tui/tui-data.c (tui_init_generic_part): Update.
1390
1391 2019-06-25  Tom Tromey  <tom@tromey.com>
1392
1393         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1394         (tui_source_window_base::make_visible): New methods.
1395         (make_all_visible): Make method call.
1396         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1397         (struct tui_source_window_base, struct tui_cmd_window): Override
1398         make_visible.
1399         (tui_win_is_source_type): Don't declare.
1400         * tui/tui-data.c (tui_win_is_source_type): Remove.
1401
1402 2019-06-25  Tom Tromey  <tom@tromey.com>
1403
1404         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1405         NULL check.
1406
1407 2019-06-25  Tom Tromey  <tom@tromey.com>
1408
1409         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1410         Inline constructor.  Add initializers for members.
1411         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1412         constructors; now inline in class.
1413
1414 2019-06-25  Tom Tromey  <tom@tromey.com>
1415
1416         * tui/tui-regs.c (tui_show_registers): Update.
1417         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1418         bool.
1419         * tui/tui-data.c (tui_data_window::clear_detail)
1420         (tui_data_window): Update.
1421
1422 2019-06-25  Tom Tromey  <tom@tromey.com>
1423
1424         * tui/tui-windata.c (tui_display_all_data)
1425         (tui_display_data_from_line, tui_display_data_from)
1426         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1427         Update.
1428         * tui/tui-regs.c (tui_last_regs_line_no)
1429         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1430         (tui_show_registers, tui_show_register_group)
1431         (tui_display_registers_from, tui_display_reg_element_at_line)
1432         (tui_display_registers_from_line, tui_check_register_values)
1433         (tui_reg_next, tui_reg_prev): Update.
1434         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1435         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1436         tui_data_window.
1437         (struct tui_win_info) <detail>: Remove.  Add new fields from
1438         tui_data_info.
1439         (TUI_DATA_WIN): Add cast.
1440         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1441         (~tui_data_window): Simplify.
1442
1443 2019-06-25  Tom Tromey  <tom@tromey.com>
1444
1445         * tui/tui-layout.c (show_source_disasm_command)
1446         (show_source_or_disasm_and_command): Update.
1447         * tui/tui-io.c (update_cmdwin_start_line)
1448         (tui_redisplay_readline): Update.
1449         * tui/tui-data.h (struct tui_command_info): Remove.
1450         (struct tui_win_info) <detail>: Remove command_info member.
1451         (struct tui_data_window) <start_line>: New member, from
1452         tui_command_info.
1453         (TUI_CMD_WIN): Add casts.
1454
1455 2019-06-25  Tom Tromey  <tom@tromey.com>
1456
1457         * tui/tui-winsource.c (tui_update_source_window)
1458         (tui_refill_source_window)
1459         (tui_source_window_base::do_scroll_horizontal)
1460         (tui_update_breakpoint_info, tui_set_exec_info_content)
1461         (tui_show_exec_info_content, tui_erase_exec_info_content)
1462         (tui_clear_exec_info_content): Update.
1463         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1464         Update.
1465         * tui/tui-win.c (make_invisible_and_set_new_height)
1466         (make_visible_with_new_height): Update.
1467         * tui/tui-source.c (tui_set_source_content)
1468         (tui_show_symtab_source): Update.
1469         * tui/tui-layout.c (extract_display_start_addr)
1470         (show_source_disasm_command, show_data)
1471         (make_source_or_disasm_window)
1472         (show_source_or_disasm_and_command): Update.
1473         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1474         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1475         "gdbarch".
1476         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1477         to tui_source_window_base.
1478         (struct tui_win_info) <detail>: Remove source_info member.
1479         (struct tui_source_window_base) <has_locator>: Inline.
1480         Move contents from tui_source_info; rename has_locator member to
1481         m_has_locator.
1482         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1483         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1484         header file.
1485         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1486         Simplify.
1487         (tui_free_all_source_wins_content): Cast to
1488         tui_source_window_base.
1489
1490 2019-06-25  Tom Tromey  <tom@tromey.com>
1491
1492         * tui/tui-win.c (make_invisible_and_set_new_height)
1493         (make_visible_with_new_height): Call has_locator method.
1494         * tui/tui-layout.c (show_source_disasm_command, show_data)
1495         (show_source_or_disasm_and_command): Update for bool change.
1496         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1497         (tui_win_info) <has_locator>: New method.
1498         (struct tui_source_window_base) <has_locator>: New method.
1499         (tui_win_has_locator): Don't declare.
1500         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1501         from tui_win_has_locator.
1502         (tui_source_window_base): Use false, not FALSE.
1503
1504 2019-06-25  Tom Tromey  <tom@tromey.com>
1505
1506         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1507         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1508         clear_detail method directly.
1509         (tui_clear_win_detail): Remove.
1510
1511 2019-06-25  Tom Tromey  <tom@tromey.com>
1512
1513         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1514         "this", not TUI_DISASM_WIN.
1515
1516 2019-06-25  Tom Tromey  <tom@tromey.com>
1517
1518         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1519         declare.
1520         * tui/tui-winsource.c
1521         (tui_source_window_base::do_scroll_horizontal): Rename from
1522         tui_horizontal_source_scroll.
1523         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1524         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1525         from tui_vertical_data_scroll.
1526         * tui/tui-win.h (tui_scroll): Don't declare.
1527         * tui/tui-win.c (tui_win_info::forward_scroll)
1528         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1529         (tui_win_info::right_scroll): Rename and update.
1530         (tui_scroll_forward_command, tui_scroll_backward_command)
1531         (tui_scroll_left_command, tui_scroll_right_command): Update.
1532         (tui_scroll): Remove.
1533         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1534         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1535         from tui_vertical_source_scroll.
1536         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1537         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1538         from tui_vertical_disassem_scroll.
1539         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1540         do_scroll_horizontal>: New methods.
1541         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1542         Likewise.
1543         (struct tui_source_window_base): Add do_scroll_horizontal.
1544         (struct tui_source_window, struct tui_disasm_window): Add
1545         do_scroll_vertical.
1546         (struct tui_data_window, struct tui_cmd_window): Add
1547         do_scroll_horizontal and do_scroll_vertical.
1548         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1549
1550 2019-06-25  Tom Tromey  <tom@tromey.com>
1551
1552         * tui/tui-data.h (struct tui_source_window_base): New struct.
1553         (struct tui_source_window): Derive from tui_source_window_base.
1554         (struct tui_disasm_window): New struct.
1555         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1556         from tui_source_window::clear_detail.
1557         (tui_source_window_base): Rename from tui_source_window.
1558         (~tui_source_window_base): Rename from ~tui_source_window.
1559         (tui_alloc_win_info): Create a tui_disasm_window.
1560
1561 2019-06-25  Tom Tromey  <tom@tromey.com>
1562
1563         * tui/tui-data.h (struct tui_source_window)
1564         (struct tui_data_window): Declare destructors.
1565         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1566         destructors.
1567         (tui_win_info): Simplify.
1568
1569 2019-06-25  Tom Tromey  <tom@tromey.com>
1570
1571         * tui/tui-winsource.c (tui_display_main)
1572         (tui_update_source_windows_with_addr)
1573         (tui_update_all_breakpoint_info): Update.
1574         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1575         (new_height_ok, parse_scrolling_args): Update.
1576         * tui/tui-stack.c (tui_show_frame_info): Update.
1577         * tui/tui-data.h (struct tui_list): Remove.
1578         (tui_source_windows): Return a reference to a std::vector.
1579         * tui/tui-data.c (source_windows): Now a std::vector.
1580         (tui_source_windows): Change return type.
1581         (tui_clear_source_windows): Rewrite.
1582         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1583         (tui_free_all_source_wins_content): Rewrite.
1584
1585 2019-06-25  Tom Tromey  <tom@tromey.com>
1586
1587         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1588         (struct tui_data_window, struct tui_cmd_window): Declare
1589         clear_detail method.
1590         * tui/tui-data.c (tui_source_window::clear_detail)
1591         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1592         methods.
1593         (tui_clear_win_detail): Simplify.
1594
1595 2019-06-25  Tom Tromey  <tom@tromey.com>
1596
1597         * tui/tui-layout.c (make_source_window, make_disasm_window)
1598         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1599         Return the new window.
1600         (show_source_disasm_command, show_data)
1601         (show_source_or_disasm_and_command): Update.
1602
1603 2019-06-25  Tom Tromey  <tom@tromey.com>
1604
1605         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1606         parameter.  Return the new window.
1607         (show_source_disasm_command): Update and remove NULL check.
1608         (show_source_or_disasm_and_command): Update.
1609
1610 2019-06-25  Tom Tromey  <tom@tromey.com>
1611
1612         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1613
1614 2019-06-25  Tom Tromey  <tom@tromey.com>
1615
1616         * tui/tui-data.h (struct tui_win_info): Make constructor
1617         protected.  Make destructor virtual.  Add initializers.
1618         (tui_source_window, tui_data_window, tui_cmd_window): New
1619         classes.
1620         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1621         constructor.  Add "type" parameter.
1622         (tui_source_window, tui_data_window, tui_cmd_window): New
1623         constructors.
1624         (tui_alloc_win_info): Instantiate the appropriate subclass.
1625
1626 2019-06-25  Tom Tromey  <tom@tromey.com>
1627
1628         * tui/tui-win.c (tui_resize_all): Use delete.
1629         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1630         destructor.
1631         (tui_free_window): Don't declare.
1632         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1633         Update.
1634
1635 2019-06-25  Tom Tromey  <tom@tromey.com>
1636
1637         * tui/tui-data.h (struct tui_win_info): Add constructor.
1638         * tui/tui-data.c (tui_alloc_win_info): Use new.
1639         (tui_free_window): Use delete.
1640
1641 2019-06-22  Tom Tromey  <tom@tromey.com>
1642
1643         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1644         declare.
1645         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1646
1647 2019-06-22  Tom Tromey  <tom@tromey.com>
1648
1649         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1650         declare.
1651         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1652
1653 2019-06-22  Tom de Vries  <tdevries@suse.de>
1654
1655         * dwarf2read.c (create_addrmap_from_aranges)
1656         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1657         instead of '%zu'.
1658
1659 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1660
1661         * dwarf2read.h (dwarf2_section_info_def): Remove.
1662         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1663         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1664         std::vector<dwarf2_section_info>.
1665         (struct dwo_file) <~dwo_file>: Remove.
1666         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1667         types field.
1668         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1669         (dwarf2_read_debug_names): Likewise.
1670         (create_debug_types_hash_table): Change parameter type to
1671         array_view, adjust code accordingly.
1672         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1673         (partial_die_info::fixup): Likewise.
1674         (determine_prefix): Likewise.
1675         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1676
1677 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1678
1679         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1680         gdb_bfd_ref_ptr.
1681         <~dwo_file>: Remove call to gdb_bfd_unref.
1682         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1683         gdb_bfd_ref_ptr::get.
1684
1685 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1686
1687         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1688         type to htab_up.
1689         * dwarf2read.c (struct dwo_file): Initialize fields.
1690         <~dwo_file>: New.
1691         (free_dwo_file): Remove, move content to ~dwo_file.
1692         (struct dwo_file_deleter): Remove.
1693         (dwo_file_up>: Remove custom deleter.
1694         (free_dwo_files): Remove.
1695         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1696         dwo_files.
1697         (process_skeletonless_type_units): Call unique_ptr::get.
1698         (allocate_dwo_file_hash_table): Add deleter to created hash
1699         table.  Change return type to htab_up.
1700         (lookup_dwo_file_slot): Don't memset dwo_file, call
1701         unique_ptr::get.
1702         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1703         (create_dwo_unit_in_dwp_v2): Likewise.
1704         (open_and_init_dwo_file): Likewise.
1705         (free_dwo_file_from_slot): Remove.
1706
1707 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1708
1709         * dwarf2read.h (struct dwarf2_section_info) <readin,
1710         is_virtual>: Change type to bool.
1711         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1712         true instead of 1.
1713
1714 2019-06-19  Tom Tromey  <tom@tromey.com>
1715
1716         * tui/tui-data.h (tui_init_content_element): Don't declare.
1717
1718 2019-06-19  Tom Tromey  <tom@tromey.com>
1719
1720         * tui/tui-data.h (tui_init_win_info): Don't declare.
1721
1722 2019-06-19  Tom de Vries  <tdevries@suse.de>
1723
1724         * dwarf2read.h (abstract_to_concrete): Change type to
1725         std::unordered_map<sect_offset, std::vector<sect_offset>,
1726         gdb::hash_enum<sect_offset>>.
1727
1728 2019-06-19  Tom Tromey  <tromey@adacore.com>
1729
1730         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1731         EVAL_AVOID_SIDE_EFFECTS specially.
1732
1733 2019-06-19  Tom Tromey  <tromey@adacore.com>
1734
1735         * source-cache.c (highlighter): New global.
1736         (source_cache::get_source_lines): Create a highlighter on demand.
1737
1738 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1739
1740         * defs.h (deprecated_interactive_hook): Delete declaration.
1741         * interps.c (clear_interpreter_hooks): Remove use of
1742         deprecated_interactive_hook.
1743         * top.c (deprecated_interactive_hook): Delete definition.
1744         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1745
1746 2019-06-18  Tom de Vries  <tdevries@suse.de>
1747
1748         PR gdb/24515
1749         * dwarf2read.h (abstract_to_concrete): Change type from
1750         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1751         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1752         * dwarf2read.c (read_variable): Update.
1753         (dwarf2_fetch_die_loc_sect_off): Update.
1754
1755 2019-06-17  Tom de Vries  <tdevries@suse.de>
1756
1757         PR gdb/24617
1758         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1759         accessing parent[parent_len - 1].
1760
1761 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1762
1763         PR gdb/24364
1764         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1765         call dtrace_process_dof with NULL dof.
1766
1767 2019-06-16  Tom de Vries  <tdevries@suse.de>
1768
1769         PR gdb/24445
1770         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1771
1772 2019-06-16  Tom Tromey  <tom@tromey.com>
1773
1774         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1775         (make_all_visible): Use address of member.
1776
1777 2019-06-16  Tom Tromey  <tom@tromey.com>
1778
1779         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1780         (tui_free_window, free_content, free_content_elements): Remove
1781         unnecessary cast.
1782         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1783         cast.
1784         * tui/tui-regs.c (tui_show_register_group)
1785         (tui_display_registers_from, tui_display_reg_element_at_line):
1786         Remove unnecessary cast.
1787
1788 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1789
1790         * linux-nat.c (normal_mask): Delete.
1791         (_initialize_linux_nat): Don't initialise normal_mask.
1792
1793 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1794
1795         PR gdb/24445
1796         * dwarf-index-write.h (write_psymtabs_to_index): Add
1797         dwz_basename parameter.
1798         * dwarf-index-write.c (write_gdbindex): Move file writing to
1799         write_gdbindex_1.  Change return type void.
1800         (assert_file_size): Move up, remove filename parameter.
1801         (write_gdbindex_1): New function.
1802         (write_debug_names): Change return type to void, call
1803         assert_file_size.
1804         (struct index_wip_file): New struct.
1805         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1806         file logic to index_wip_file.  Write index for dwz file if
1807         needed.
1808         (save_gdb_index_command): Pass basename of dwz file, if present.
1809         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1810         build-id of dwz file, if present.
1811         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1812         (dwarf2_get_dwz_file): Likewise.
1813         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1814         (dwarf2_get_dwz_file): Likewise.
1815
1816 2019-06-16  Tom Tromey  <tom@tromey.com>
1817
1818         * coffread.c (process_coff_symbol): Use xstrdup.
1819         * value.c (create_internalvar): Use xstrdup.
1820
1821 2019-06-16  Tom Tromey  <tom@tromey.com>
1822
1823         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1824         * breakpoint.c (stopin_command, stopat_command)
1825         (until_break_command, decode_location_default): Remove unnecessary
1826         cast.
1827         * utils.c (subset_compare): Remove unnecessary cast.
1828         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1829         cast.
1830         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1831         cast.
1832         * infcmd.c (path_command): Remove unnecessary cast.
1833         * coffread.c (decode_type): Remove unnecessary cast.
1834         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1835         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1836         * tui/tui-stack.c (tui_show_locator_content)
1837         (tui_show_frame_info): Remove unnecessary cast.
1838         * tui/tui-win.c (tui_scroll_forward_command)
1839         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1840         (parse_scrolling_args): Remove unnecessary cast.
1841         * tui/tui-data.c (init_win_info, tui_del_window)
1842         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1843         (free_content_elements): Remove unnecessary cast.
1844         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1845         unnecessary cast.
1846         * tui/tui-source.c (tui_set_source_content)
1847         (tui_vertical_source_scroll): Remove unnecessary cast.
1848         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1849         cast.
1850         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1851         * tui/tui-regs.c (tui_display_registers_from)
1852         (tui_display_register): Remove unnecessary cast.
1853         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1854         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1855         (make_visible): Remove unnecessary cast.
1856         * tui/tui-winsource.c (tui_erase_source_content)
1857         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1858         unnecessary cast.
1859         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1860         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1861         * stabsread.c (read_type, read_array_type, read_range_type):
1862         Remove unnecessary cast.
1863         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1864         (parse_symbol, parse_type, upgrade_type, parse_external)
1865         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1866         unnecessary cast.
1867         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1868
1869 2019-06-16  Tom Tromey  <tom@tromey.com>
1870
1871         * tui/tui-data.c (tui_alloc_generic_win_info)
1872         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1873         checks.
1874
1875 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1876             Andrew Burgess  <andrew.burgess@embecosm.com>
1877
1878         * f-typeprint.c (f_print_type): Don't return early for not
1879         associated or not allocated types.
1880         (f_type_print_varspec_suffix): Add print_rank parameter and print
1881         ranks of array types in case they dangling.
1882         (f_type_print_base): Add print_rank parameter.
1883
1884 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1885
1886         * NEWS: Mention new MI commands.
1887         * break-catch-throw.c (enum exception_event_kind): Move to
1888         breakpoint.h.
1889         (print_mention_exception_catchpoint): Output text as a single
1890         message.
1891         (catch_exception_command_1): Rename to...
1892         (catch_exception_event): ...this, make non-static, update header
1893         command, and change some parameter types.
1894         (catch_catch_command): Update for changes to
1895         catch_exception_command_1.
1896         (catch_throw_command): Likewise.
1897         (catch_rethrow_command): Likewise.
1898         * breakpoint.c (enum exception_event_kind): Delete.
1899         * breakpoint.h (enum exception_event_kind): Moved here from
1900         break-catch-throw.c.
1901         (catch_exception_event): Declare.
1902         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1903         (mi_cmd_catch_throw): New function.
1904         (mi_cmd_catch_rethrow): New function.
1905         (mi_cmd_catch_catch): New function.
1906         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1907         'catch-catch' entries.
1908         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1909         (mi_cmd_catch_rethrow): Declare.
1910         (mi_cmd_catch_catch): Declare.
1911
1912 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1913
1914         * annotate.c (annotate_source_line): Change return type to void,
1915         update implementation to match.
1916         * annotate.h (annotate_source_line): Change return type to void,
1917         update header comment.
1918         * stack.c (print_frame_info): Don't change what frame information
1919         is printed based on whether annotations are on or not.
1920
1921 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1922
1923         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1924         (annotate_source): Make static.
1925         (annotate_source_line): Moved from source.c and renamed from
1926         identify_source_line.  Update the return type.
1927         * annotate.h (annotate_source): Delete declaration.
1928         (annotate_source_line): Declaration moved from source.h, and
1929         renamed from identify_source_line.  Return type updated.
1930         * source.c (identify_source_line): Moved to annotate.c and renamed
1931         to annotate_source_line.
1932         (info_line_command): Remove check of annotation_level.
1933         * source.h (identify_source_line): Move declaration to annotate.h
1934         and rename to annotate_source_line.
1935         * stack.c: Add 'annotate.h' include.
1936         (print_frame_info): Remove check of annotation_level before
1937         calling annotate_source_line.
1938
1939 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1940
1941         * source-cache.c (source_cache::get_plain_source_lines): Use
1942         open_source_file_with_line_charpos instead of just
1943         open_source_file, remove call to find_source_lines.
1944         (source_cache::get_source_lines): Likewise.
1945         * source.c (find_source_lines): Make static.
1946         (get_filename_and_charpos): Renamed into...
1947         (open_source_file_with_line_charpos): ..this along with changes to
1948         return a scoped_fd, and some other minor clean ups.
1949         (identify_source_line): Use open_source_file_with_line_charpos.
1950         (search_command_helper): Use open_source_file_with_line_charpos
1951         instead of just open_source_file, remove call to
1952         find_source_lines.
1953         * source.h (open_source_file_with_line_charpos): Declare new
1954         function.
1955         (find_source_lines): Delete declaration.
1956
1957 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1958
1959         * source.c (get_filename_and_charpos): Remove fullname
1960         parameter.
1961         (identify_source_line): Update call to get_filename_and_charpos.
1962
1963 2019-06-14  Tom Tromey  <tromey@adacore.com>
1964
1965         PR gdb/24502:
1966         * ui-style.h (skip_ansi_escape): Update comment.
1967         * ui-file.h (class no_terminal_escape_file): New class.
1968         * ui-file.c (no_terminal_escape_file::write)
1969         (no_terminal_escape_file::puts): New methods.
1970         * cli/cli-logging.c (handle_redirections): Use
1971         no_terminal_escape_file.
1972
1973 2019-06-14  Tom Tromey  <tromey@adacore.com>
1974
1975         * NEWS: Move convenience variable news above Python news.
1976
1977 2019-06-14  Tom Tromey  <tom@tromey.com>
1978
1979         * gnulib: Move directory to top-level.
1980         * configure.ac: Don't configure gnulib.
1981         * configure: Rebuild.
1982         * common/common-defs.h: Use new path to gnulib.
1983         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1984         (GNULIB_H): Remove.
1985         (INCGNU): Look in new gnulib location.
1986         (HFILES_NO_SRCDIR): Remove gnulib files.
1987         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1988         (generated_files): Remove GNULIB_H.
1989         ($(LIBGNU), all-lib): Remove targets.
1990         (distclean): Don't mention GNULIB_BUILDDIR.
1991         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1992
1993 2019-06-14  Tom Tromey  <tromey@adacore.com>
1994
1995         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1996         Warn if symbol file does not provide any symbols.
1997
1998 2019-06-14  Tom Tromey  <tromey@adacore.com>
1999
2000         * source.c (find_and_open_source): Respect basenames_may_differ.
2001
2002 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2003
2004         * annotate.c (annotate_breakpoints_invalid): Make use of
2005         scoped_restore_terminal_state.
2006         (annotate_frames_invalid): Likewise.
2007
2008 2019-06-14  Tom Tromey  <tromey@adacore.com>
2009
2010         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2011         allow assignment to an internalvar.
2012
2013 2019-06-14  Tom Tromey  <tromey@adacore.com>
2014
2015         * ada-lex.l: Allow "_" in attribute names.
2016
2017 2019-06-14  Tom Tromey  <tromey@adacore.com>
2018
2019         PR gdb/24653:
2020         * regcache.c (registers_changed): Don't call alloca.
2021         * top.c (execute_command): Don't call alloca.
2022
2023 2019-06-13  Pedro Alves  <palves@redhat.com>
2024
2025         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2026         'expression'.  When parsing an expression, error out if there's
2027         junk after "unlimited".
2028         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2029         (do_set_command): Adjust calls to is_unlimited_literal.
2030
2031 2019-06-13  Pedro Alves  <palves@redhat.com>
2032
2033         * compile/compile.c (make_compile_options_def_group): Add braces
2034         around array_view initializer.
2035         * thread.c (make_thread_apply_all_options_def_group)
2036         (make_thread_apply_all_options_def_group): Likewise.
2037
2038 2019-06-13  Pedro Alves  <palves@redhat.com>
2039
2040         * NEWS (New commands): Mention "maint test-options
2041         require-delimiter", "maint test-options unknown-is-error", "maint
2042         test-options unknown-is-operand" and "maint show
2043         test-options-completion-result".
2044         (New command options, command completion): New section.
2045         (Completion improvements): New section.
2046         Mention that you can abbreviate "unlimited".
2047
2048 2019-06-13  Pedro Alves  <palves@redhat.com>
2049
2050         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2051         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2052         * unittests/cli-utils-selftests.c (test_parse_flags)
2053         (test_parse_flags_qcs): Delete.
2054         (test_cli_utils): Don't call deleted functions.
2055
2056 2019-06-13  Pedro Alves  <palves@redhat.com>
2057
2058         * thread.c: Include "cli/cli-option.h".
2059         (tp_array_compar_ascending): Global.
2060         (tp_array_compar): Delete function.
2061         (tp_array_compar_ascending, tp_array_compar_descending): New
2062         functions.
2063         (ascending_option_def, qcs_flag_option_def)
2064         (thr_qcs_flags_option_defs)
2065         (make_thread_apply_all_options_def_group)
2066         (make_thread_apply_options_def_group): New.
2067         (thread_apply_all_command): Use gdb::option::process_options.
2068         (thread_apply_command_completer)
2069         (thread_apply_all_command_completer): New.
2070         (thread_apply_command): Use gdb::option::process_options.
2071         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2072         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2073         to generate help text of "thread apply".  Adjust "taas"'s help.
2074         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2075         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2076
2077 2019-06-13  Pedro Alves  <palves@redhat.com>
2078
2079         * thread.c (thread_apply_command): Check for invalid TID with
2080         isdigit instead of !isalpha.
2081
2082 2019-06-13  Pedro Alves  <palves@redhat.com>
2083
2084         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2085         (validate_flags_qcs): New.
2086         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2087         (validate_flags_qcs): Declare.
2088         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2089         (make_frame_apply_options_def_group): New.
2090         (frame_apply_command_count): Process options with
2091         gdb::option::process_options.
2092         (frame_apply_completer): New.
2093         (frame_apply_level_completer, frame_apply_all_completer)
2094         (frame_apply_completer): New.
2095         (_initialize_stack): Update help of "frame apply", "frame apply
2096         level", "frame apply all" and "faas" to mention supported options
2097         and install command completers.
2098         * stack.h (frame_apply_all_completer): Declare.
2099         * thread.c: Include "stack.h".
2100         (tfaas_command): Add "--".
2101         (_initialize_thread): Update help "tfaas" to mention supported
2102         options and install command completer.
2103
2104 2019-06-13  Pedro Alves  <palves@redhat.com>
2105
2106         * completer.c (complete_nested_command_line): New.
2107         (gdb_completion_word_break_characters_throw): Add assertion.
2108         * completer.h (complete_nested_command_line): Declare.
2109
2110 2019-06-13  Pedro Alves  <palves@redhat.com>
2111
2112         * stack.c (parse_backtrace_qualifiers): New.
2113         (backtrace_command): Use it.
2114         (backtrace_command_completer): Complete on qualifiers.
2115
2116 2019-06-13  Pedro Alves  <palves@redhat.com>
2117
2118         * frame.c: Include "cli/cli-option.h.
2119         (user_set_backtrace_options): New.
2120         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2121         Delete.
2122         (get_prev_frame): Adjust.
2123         (boolean_option_def, uinteger_option_def)
2124         (set_backtrace_option_defs): New.
2125         (_initialize_frame): Adjust and use
2126         gdb::option::add_setshow_cmds_for_options to install "set
2127         backtrace past-main" and "set backtrace past-entry".
2128         * frame.h: Include "cli/cli-option.h".
2129         (struct frame_print_options): Forward declare.
2130         (print_frame_arguments_all, print_frame_arguments_scalars)
2131         (print_frame_arguments_none): Declare.
2132         (print_entry_values): Delete declaration.
2133         (struct frame_print_options, user_frame_print_options): New.
2134         (struct set_backtrace_options): New.
2135         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2136         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2137         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2138         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2139         (list_args_or_locals): Add frame_print_options parameter.
2140         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2141         * python/py-framefilter.c (enumerate_args): Pass down
2142         USER_FRAME_PRINT_OPTIONS.
2143         * stack.c: Include "cli/cli-option.h".
2144         (print_frame_arguments_all, print_frame_arguments_scalars)
2145         (print_frame_arguments_none): Declare.
2146         (print_raw_frame_arguments, print_entry_values): Delete.
2147         (user_frame_print_options): New.
2148         (boolean_option_def, enum_option_def, frame_print_option_defs):
2149         New.
2150         (struct backtrace_cmd_options): New.
2151         (bt_flag_option_def): New.
2152         (backtrace_command_option_defs): New.
2153         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2154         (print_frame_arg, read_frame_arg, print_frame_args)
2155         (print_frame_info, print_frame): Add frame_print_options parameter
2156         and use it.
2157         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2158         (backtrace_command_1): Add frame_print_options and
2159         backtrace_cmd_options parameters and use them.
2160         (make_backtrace_options_def_group): New.
2161         (backtrace_command): Process command options with
2162         gdb::option::process_options.
2163         (backtrace_command_completer): New.
2164         (_initialize_stack): Extend "backtrace"'s help to mention
2165         supported options.  Install completer for "backtrace".
2166         Install some settings commands with add_setshow_cmds_for_options.
2167
2168 2019-06-13  Pedro Alves  <palves@redhat.com>
2169
2170         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2171         and that "set/show print raw frame-arguments" are now deprecated.
2172
2173         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2174         command.
2175         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2176         * stack.c (_initialize_stack): Install "set/show print
2177         raw-frame-arguments", and deprecate "set/show print raw
2178         frame-arguments".
2179         * valprint.c (_initialize_valprint): Deprecate "set/show print
2180         raw".
2181
2182 2019-06-13  Pedro Alves  <palves@redhat.com>
2183
2184         * compile/compile.c (struct compile_options): New.
2185         (compile_flag_option_def, compile_command_option_defs)
2186         (make_compile_options_def_group): New.
2187         (compile_file_command): Handle options with
2188         gdb::option::process_options.
2189         (compile_file_command_completer): New function.
2190         (compile_code_command): Handle options with
2191         gdb::option::process_options.
2192         (compile_code_command_completer): New function.
2193         (_initialize_compiler): Install completers for "compile code" and
2194         "compile file".  Mention available options in "compile code" and
2195         "compile code"'s help.
2196         * completer.c (advance_to_completion_word): New, factored out from
2197         ...
2198         (advance_to_expression_complete_word_point): ... this.
2199         (advance_to_filename_complete_word_point): New.
2200         * completer.h (advance_to_filename_complete_word_point): New
2201         declaration.
2202
2203 2019-06-13  Pedro Alves  <palves@redhat.com>
2204
2205         * compile/compile.c: Include "cli/cli-option.h".
2206         (compile_print_value): Scope data pointer is now a
2207         value_print_options pointer; adjust.
2208         (compile_print_command): Process options.  Scope data pointer is
2209         now a value_print_options pointer; adjust.
2210         (_initialize_compile): Update "compile print"'s help to include
2211         supported options.  Install a completer for "compile print".
2212         * cp-valprint.c (show_vtblprint, show_objectprint)
2213         (show_static_field_print): Delete.
2214         (_initialize_cp_valprint): Don't install "set print
2215         static-members", "set print vtbl", "set print object" here.
2216         * printcmd.c: Include "cli/cli-option.h" and
2217         "common/gdb_optional.h".
2218         (print_command_parse_format): Rework to fill in a
2219         value_print_options instead of a format_data.
2220         (print_value): Change parameter type from format_data pointer to
2221         value_print_options reference.  Adjust.
2222         (print_command_1): Process options.  Adjust to pass down a
2223         value_print_options.
2224         (print_command_completer): New.
2225         (_initialize_printcmd): Install print_command_completer as
2226         handle_brkchars completer for the "print" command.  Update
2227         "print"'s help to include supported options.
2228         * valprint.c: Include "cli/cli-option.h".
2229         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2230         here from cp-valprint.c.
2231         (boolean_option_def, uinteger_option_def)
2232         (value_print_option_defs, make_value_print_options_def_group):
2233         New.  Use gdb::option::add_setshow_cmds_for_options to install
2234         "set print elements", "set print null-stop", "set print repeats",
2235         "set print pretty", "set print union", "set print array", "set
2236         print address", "set print symbol", "set print array-indexes".
2237         * valprint.h: Include <string> and "cli/cli-option.h".
2238         (make_value_print_options_def_group): Declare.
2239         (print_value): Change parameter type from format_data pointer to
2240         value_print_options reference.
2241         (print_command_completer): Declare.
2242
2243 2019-06-13  Pedro Alves  <palves@redhat.com>
2244
2245         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2246         (COMMON_SFILES): Add maint-test-settings.c.
2247         * cli/cli-decode.c (boolean_enums): New global, factored out from
2248         ...
2249         (add_setshow_boolean_cmd): ... here.
2250         * cli/cli-decode.h (boolean_enums): Declare.
2251         * cli/cli-option.c: New file.
2252         * cli/cli-option.h: New file.
2253         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2254         factored out from ...
2255         (parse_cli_boolean_value(const char *)): ... this.
2256         (is_unlimited_literal): Change parameter type to pointer to
2257         pointer.  Adjust and advance ARG pointer.
2258         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2259         (parse_cli_var_enum): New, factored out from ...
2260         (do_set_command): ... this.  Adjust.
2261         * cli/cli-setshow.h (parse_cli_boolean_value)
2262         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2263         (parse_cli_var_enum): Declare.
2264         * cli/cli-utils.c: Include "cli/cli-option.h".
2265         (get_ulongest): New.
2266         * cli/cli-utils.h (get_ulongest): Declare.
2267         (check_for_argument): New overloads.
2268         * maint-test-options.c: New file.
2269
2270 2019-06-13  Pedro Alves  <palves@redhat.com>
2271
2272         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2273         parse a range if "-" is at the end of the string.
2274
2275 2019-06-13  Pedro Alves  <palves@redhat.com>
2276
2277         * cli/cli-setshow.c (parse_auto_binary_operation)
2278         (parse_cli_boolean_value): Don't allow "o".
2279
2280 2019-06-13  Pedro Alves  <palves@redhat.com>
2281
2282         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2283         * NEWS: Mention maint test-settings KIND.
2284         * maint-test-settings.c: New file.
2285
2286 2019-06-13  Pedro Alves  <palves@redhat.com>
2287
2288         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2289         completer.
2290         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2291         "set" completers.
2292
2293 2019-06-13  Pedro Alves  <palves@redhat.com>
2294
2295         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2296         after item.
2297
2298 2019-06-13  Pedro Alves  <palves@redhat.com>
2299
2300         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2301
2302 2019-06-13  Pedro Alves <palves@redhat.com>
2303
2304         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2305         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2306         call.
2307         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2308         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2309         calls.
2310         (check_for_argument): Skip spaces after argument.
2311
2312 2019-06-13  Pedro Alves  <palves@redhat.com>
2313
2314         * thread.c (thread_apply_command): Adjust TID parsing.
2315         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2316         detected before end of string.
2317         (tid_is_in_list): Error out if LIST is invalid.
2318
2319 2019-06-13  Pedro Alves  <palves@redhat.com>
2320
2321         * completer.c (complete_line_internal_1): Rewind completion word
2322         point.
2323         (completion_tracker::advance_custom_word_point_by): Change
2324         parameter type to int.
2325         * completer.h (completion_tracker::advance_custom_word_point_by):
2326         Likewise.
2327
2328 2019-06-13  Pedro Alves  <palves@redhat.com>
2329
2330         * completer.c (advance_to_completion_word): Handle delimiters.
2331
2332 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2333
2334         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2335
2336 2019-06-11  Tom Tromey  <tom@tromey.com>
2337
2338         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2339         (xmalloc_failed): Move to alloc.c.
2340         * alloc.c: New file.
2341         * Makefile.in (COMMON_SFILES): Add alloc.c.
2342
2343 2019-06-11  Tom Tromey  <tom@tromey.com>
2344
2345         * nat/linux-waitpid.c: Don't include server.h.
2346         (linux_debug): Remove.
2347         (my_waitpid): Update.
2348
2349 2019-06-11  Tom Tromey  <tromey@adacore.com>
2350
2351         * infcall.c (_initialize_infcall): Remove trailing newline from
2352         help.
2353         * user-regs.c (_initialize_user_regs): Remove trailing newline
2354         from help.
2355         * typeprint.c (_initialize_typeprint): Remove trailing newline
2356         from help.
2357         * reverse.c (_initialize_reverse): Remove trailing newlines from
2358         help.
2359         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2360         from help.
2361         * language.c (add_set_language_command): Remove trailing newline
2362         from help.
2363         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2364         help.
2365         * disasm.c (_initialize_disasm): Remove trailing newline from
2366         help.
2367         * top.c (init_main): Remove trailing newline from help.
2368         * interps.c (_initialize_interpreter): Remove trailing newline
2369         from help.
2370         * btrace.c (_initialize_btrace): Remove trailing newlines from
2371         help.
2372         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2373         from help.
2374         * python/python.c (_initialize_python): Remove trailing newline
2375         from help.
2376         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2377         help.
2378         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2379         from help.  Reformat some text.
2380         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2381         from help.
2382         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2383         newline from help.
2384
2385 2019-06-11  Tom Tromey  <tromey@adacore.com>
2386
2387         * darwin-nat.c (darwin_decode_exception_message)
2388         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2389
2390 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2391
2392         * valops.c (value_slice): Check for not allocated or not
2393         associated values.
2394
2395 2019-06-10  Tom de Vries  <tdevries@suse.de>
2396
2397         PR gdb/24618
2398         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2399         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2400         invalid.
2401
2402 2019-06-10  Tom de Vries  <tdevries@suse.de>
2403
2404         PR gdb/24611
2405         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2406         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2407
2408 2019-06-10  Tom de Vries  <tdevries@suse.de>
2409
2410         PR symtab/24545
2411         * symtab.c (struct demangled_name_entry): Add language field.
2412         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2413         static minimal symbol".  Set and use language field.
2414
2415 2019-06-10  Tom Tromey  <tromey@adacore.com>
2416
2417         * ada-lang.c (_initialize_ada_language): Update help text.
2418
2419 2019-06-10  Tom Tromey  <tromey@adacore.com>
2420
2421         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2422         with a newline.
2423         * guile/guile.c (handle_boot_error): Don't end warning with a
2424         newline.
2425         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2426         warning with a newline.
2427         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2428         newline.
2429         (s12z_frame_cache): Likewise.
2430         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2431         a newline.
2432         * solib-svr4.c (disable_probes_interface): Don't end warning with
2433         a newline.
2434         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2435         newline.
2436         * python/python.c (do_finish_initialization): Don't end warning
2437         with a newline.
2438
2439 2019-06-10  Tom Tromey  <tom@tromey.com>
2440
2441         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2442         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2443         gdbpy_enter.
2444
2445 2019-06-10  Tom Tromey  <tromey@adacore.com>
2446
2447         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2448         data.
2449         (elf_new_init): Don't call stabsread_new_init.
2450         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2451         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2452         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2453
2454 2019-06-10  Tom de Vries  <tdevries@suse.de>
2455
2456         PR symtab/16264
2457         PR symtab/24517
2458         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2459
2460 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2461
2462         * source.c (find_and_open_source): Also rewrite relative file
2463         names.
2464
2465 2019-04-26  Amos Bird  <amosbird@gmail.com>
2466
2467         * annotate.c (annotate_thread_exited): Add "thread-exited"
2468         annotation.
2469
2470 2019-06-06  Tom Tromey  <tromey@adacore.com>
2471
2472         * maint.h (class scoped_command_stats): Use
2473         DISABLE_COPY_AND_ASSIGN.
2474         <print_time>: New method.
2475         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2476         print_time.
2477         (scoped_command_stats::print_time): New method.
2478
2479 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2480
2481         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2482         instructions of lengths 6 or 8 bytes.
2483
2484 2019-06-04  Pedro Alves  <palves@redhat.com>
2485
2486         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2487
2488         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2489         * breakpoint.c (condition_completer): Likewise.
2490         * cli/cli-dump.c (scan_expression): Likewise.
2491         * common/filestuff.c (mkdir_recursive): Likewise.
2492         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2493         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2494         (gdb_abspath): Likewise.
2495         * compile/compile-cplus-types.c
2496         (compile_cplus_instance::decl_name): Likewise.
2497         * completer.c (complete_explicit_location):
2498         (signal_completer, reg_or_group_completer_1): Likewise.
2499         * cp-support.c (cp_remove_params_if_any): Likewise.
2500         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2501         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2502         * infcmd.c (strip_bg_char): Likewise.
2503         * linespec.c (copy_token_string): Likewise.
2504         * mi/mi-main.c (output_cores): Likewise.
2505         * psymtab.c (psymtab_search_name):
2506         * symfile.c (test_set_ext_lang_command): Likewise.
2507         * target.c (target_fileio_read_stralloc): Likewise.
2508         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2509         * value.c (complete_internalvar): Likewise.
2510
2511 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2512
2513         Add objfile property to gdb.Type.
2514         * NEWS: Mention Python API addition.
2515         * python/py-type.c (typy_get_objfile): New method.
2516
2517 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2518
2519         * NEWS: Mention the new set|show style [title|highlight].
2520         Mention changes to "show style", "help" and "apropos".
2521
2522 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2523
2524         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2525         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2526         instead of print_help_for_command.
2527         (print_doc_of_command): New function.
2528         (help_list): Add 'apropos -v word' suggestion.
2529         (print_help_for_command): Style the command name using title style.
2530         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2531         (_initialize_cli_cmds): Describe -v in apropos_command help.
2532
2533 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2534
2535         * cli/cli-style.h (cli_style_option): Add name in constructor,
2536         add m_name class member, add constructor with intensity,
2537         add name class function.
2538         (cli_style_option::add_setshow_commands): Remove name argument.
2539         (highlight_style, title_style): New styles.
2540         * cli/cli-style.c (do_show): New function that shows a style
2541         characteristic styling the style name with itself.
2542         (set_style_name): New function.
2543         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2544         Update all callers according to the changes in cli/cli-style.h.
2545         * utils.h (fputs_highlighted): New function.
2546         * utils.c (fputs_highlighted): Likewise.
2547
2548 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2549
2550         * NEWS: Mention new pipe command and new convenience variables.
2551
2552 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2553
2554         * cli/cli-cmds.c (pipe_command): New function.
2555         (_initialize_cli_cmds): Call add_com for pipe_command.
2556         Define | as an alias for pipe.
2557         (exit_status_set_internal_vars): New function.
2558         (shell_escape): Call exit_status_set_internal_vars.
2559         cli/cli-decode.c (find_command_name_length): Recognize | as
2560         a single character command.
2561
2562 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2563
2564         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2565         top.c (execute_command_to_ui_file): New function, mostly a copy
2566         of execute_command_to_string.
2567         (execute_command_to_string): Implement by calling
2568         execute_command_to_ui_file.
2569
2570 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2571
2572         * top.h (saved_command_line): Remove declaration.
2573         * top.c (previous_saved_command_line, previous_repeat_arguments):
2574         New variables.
2575         (saved_command_line): Make static, define together with other
2576         'repeat variables'.
2577         (dont_repeat): Clear repeat_arguments.
2578         (repeat_previous, get_saved_command_line, save_command_line):
2579         New functions.
2580         (gdb_init): Initialize saved_command_line
2581         and previous_saved_command_line.
2582         * main.c (captured_main_1): Remove saved_command_line initialization.
2583         * event-top.c (handle_line_of_input): Update to use
2584         the new 'repeat' related functions instead of direct access to
2585         saved_command_line.
2586         * command.h (repeat_previous, get_saved_command_line,
2587         save_command_line): New declarations.
2588         (dont_repeat): Add comment.
2589
2590 2019-05-30  Tom Tromey  <tromey@adacore.com>
2591
2592         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2593         Fix comment.
2594         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2595
2596 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2597
2598         PR cli/24587
2599         * completer.c (complete): Initialize variable word.
2600
2601 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2602
2603         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2604         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2605         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2606         'body' is NULL to the outter 'if', protecting the '!is_define'
2607         situation as well.
2608
2609 2019-05-29  Tom Tromey  <tromey@adacore.com>
2610
2611         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2612         (dwarf_unknown): New function.
2613         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2614         (dwarf_type_encoding_name): Use dwarf_unknown.
2615
2616 2019-05-29  Tom Tromey  <tromey@adacore.com>
2617
2618         PR c++/20020:
2619         * cp-valprint.c (cp_print_value_fields): Call
2620         cp_print_static_field inside "try".
2621
2622 2019-05-29  Tom Tromey  <tromey@adacore.com>
2623
2624         * inflow.c (struct terminal_info): Add default operator=.
2625         * configure: Rebuild.
2626         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2627         -Wdeprecated-copy-dtor, -Wredundant-move.
2628
2629 2019-05-29  Tom Tromey  <tromey@adacore.com>
2630
2631         * NEWS: Add entry.
2632         * infcmd.c (print_return_value_1): Handle finish_print
2633         option.
2634         (show_print_finish): New function.
2635         (_initialize_infcmd): Add "set/show print finish" commands.
2636         * valprint.c (user_print_options): Initialize new member.
2637         * valprint.h (struct value_print_options) <finish_print>: New
2638         member.
2639
2640 2019-05-28  Tom Tromey  <tromey@adacore.com>
2641
2642         * ada-lang.c (ada_remove_Xbn_suffix)
2643         (find_old_style_renaming_symbol)
2644         (parse_old_style_renaming): Remove.
2645         (ada_find_renaming_symbol): Don't call
2646         find_old_style_renaming_symbol.
2647         (ada_is_renaming_symbol): Rename from
2648         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2649         bool.  Now static.
2650         (ada_read_var_value): Update and simplify.
2651         * ada-exp.y (write_var_or_type): Remove old code.
2652
2653 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2654
2655         * event-top.c: Remove include comment.
2656         * inflow.c (class scoped_ignore_sigttou): Move from here...
2657         * inflow.h (class scoped_ignore_sigttou): ...to here.
2658         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2659         * top.c:  Remove include comment.
2660
2661 2019-05-27  Tom Tromey  <tom@tromey.com>
2662
2663         * NEWS: Fix typo.
2664
2665 2019-05-22  Tom Tromey  <tromey@adacore.com>
2666
2667         * target.c (target_follow_exec): Constify parameter.
2668         * target-delegates.c: Rebuild.
2669         * remote.c (remote_target::follow_exec): Constify parameter.
2670         * infrun.c (follow_exec): Constify parameter.
2671         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2672         (target_follow_exec): Likewise.
2673
2674 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2675
2676         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2677         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2678
2679 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2680
2681         * NEWS: Add debugredirect and testsuite sections.
2682
2683 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2684
2685         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2686         target descriptions using exclusively floating point register name
2687         aliases.
2688
2689 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2690
2691         PR gdb/18644:
2692         * f-lang.c (build_fortran_types): Handle the case where
2693         gdbarch_floatformat_for_type returns a nullptr.
2694
2695 2019-05-21  Tom de Vries  <tdevries@suse.de>
2696
2697         PR cli/24587
2698         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2699
2700 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2701
2702         PR gdb/18644:
2703         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2704         16-byte floats.
2705         * i386-tdep.c (i386_floatformat_for_type): Use
2706         floatformats_ia64_quad for the 16-byte floating point component
2707         within a fortran 32-byte complex number.
2708
2709 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2710
2711         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2712         delete default constructor.
2713         (find_partial_die): Update to return const struct.
2714         (partial_die_parent_scope): Move variable declaration into scope
2715         of its use and change its type to auto.
2716         (guess_partial_die_structure_name): Likewise.
2717         (partial_die_info::fixup): Likewise.
2718
2719 2019-05-17  Tom Tromey  <tromey@adacore.com>
2720
2721         * source.c (find_and_open_source): Remove cast.
2722
2723 2019-05-17  Tom Tromey  <tromey@adacore.com>
2724
2725         * annotate.c (annotate_source): Make "filename" const.
2726         * annotate.h (annotate_source): Use const.
2727
2728 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2729
2730         * disasm.c (set_disassembler_options): Send errors to stderr.
2731
2732 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2733
2734         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2735         (cli_interp_base::set_logging): Check debug_redirect.
2736         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2737         * cli/cli-logging.c (debug_redirect): Add static variable.
2738         (pop_output_files): Add default param.
2739         (handle_redirections): Print debug setting.
2740         (show_logging_command): Likewise.
2741         (_initialize_cli_logging): Add debugredirect command.
2742         * interps.c (current_interp_set_logging): Add debug_redirect
2743         parameter.
2744         * interps.h (set_logging): Add debug_redirect parameter.
2745         (current_interp_set_logging): Likewise.
2746         * mi/mi-common.h: Likewise.
2747         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2748
2749 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2750             Tom Tromey  <tromey@adacore.com>
2751
2752         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2753         directly.
2754         * cli/cli-interp.h (make_logging_output): Remove declaration.
2755         * cli/cli-logging.c (make_logging_output): Remove function.
2756         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2757         directly.
2758         * ui-file.c (tee_file::tee_file): Remove bools.
2759         (tee_file::~tee_file): Remove deletes.
2760         * ui-file.h (tee_file): Remove bools.
2761
2762 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2763
2764         * mi/mi-cmds.h (mi_cmd_complete): New function.
2765         * mi/mi-main.c (mi_cmd_complete): Likewise.
2766         * mi/mi-cmds.c: Define new MI command -complete.
2767         * NEWS: Mention new -complete command.
2768
2769 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2770
2771         * completer.h (complete): New function.
2772         * completer.c (complete): Likewise.
2773         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2774         function defined in completer.h.
2775
2776 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2777
2778         * MAINTAINERS (Write After Approval): Add myself.
2779
2780 2019-05-17  Tom de Vries  <tdevries@suse.de>
2781
2782         PR gdb/24094
2783         * dwarf2read.c (struct cu_partial_die_info): New struct.
2784         (find_partial_die): Return cu_partial_die_info.
2785         (partial_die_parent_scope, guess_partial_die_structure_name)
2786         (partial_die_info::fixup): Handle new return type of find_partial_die.
2787
2788 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2789
2790         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2791         "std::string", simplifying the algorithm.
2792
2793 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2794
2795         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2796         (stap_static_probe_ops::get_probes): Likewise.
2797
2798 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2799
2800         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2801         '-')" and "else if".
2802         (stap_parse_single_operand): Join checks for
2803         "gdbarch_stap_parse_special_token_p" and
2804         "gdbarch_stap_parse_special_token" in the same "if" statement.
2805         Invert check when verifying for operation on register
2806         displacement.
2807
2808 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2809
2810         * stap-probe.c (stap_get_opcode): Update comment.
2811         (stap_get_expected_argument_type): Likewise.
2812         (handle_stap_probe): Likewise.
2813
2814 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2815
2816         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2817         return type to 'bool'.  Adjust comment.  Use 'bool' when
2818         appropriate.
2819         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2820         * stap-probe.c (stap_parse_argument_1): Likewise.
2821         (stap_is_operator): Likewise.
2822         (stap_is_generic_prefix): Likewise.
2823         (stap_is_register_prefix): Likewise.
2824         (stap_is_register_indirection_prefix): Likewise.
2825         (stap_is_integer_prefix): Likewise.
2826         (stap_generic_check_suffix): Likewise.
2827         (stap_check_integer_suffix): Likewise.
2828         (stap_check_register_suffix): Likewise.
2829         (stap_check_register_indirection_suffix): Likewise.
2830         (stap_parse_register_operand): Likewise.
2831         (stap_parse_single_operand): Likewise.
2832         (stap_parse_argument_1): Likewise.
2833         (stap_probe::get_argument_count): Likewise.
2834         (stap_is_operator): Likewise.
2835
2836 2019-05-16  Tom Tromey  <tromey@adacore.com>
2837
2838         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2839         keyword to foreach.
2840
2841 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2842
2843         * linux-thread-db.c (try_thread_db_load_1): Change return type
2844         to bool.
2845         (try_thread_db_load): Likewise.
2846         (try_thread_db_load_from_pdir_1): Likewise.
2847         (try_thread_db_load_from_pdir): Likewise.
2848         (try_thread_db_load_from_sdir): Likewise.
2849         (try_thread_db_load_from_dir): Likewise.
2850         (thread_db_load_search): Likewise.
2851         (has_libpthread): Likewise.
2852         (thread_db_load): Likewise.
2853
2854 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2855
2856         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2857         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2858         NULL, and complain/return if that's the case.
2859
2860 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2861
2862         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2863         (advance, posn, abstract_read_memory): New functions.
2864         [struct mem_read_abstraction]: New struct.
2865         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2866
2867 2019-05-14  Tom Tromey  <tromey@adacore.com>
2868
2869         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2870         value is not lval_memory.
2871
2872 2019-05-14  Tom Tromey  <tromey@adacore.com>
2873
2874         * solib.c (info_sharedlibrary_command): Style the file name.
2875
2876 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2877
2878         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2879         (aarch64_vnv_type): Likewise.
2880         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2881         * common/tdesc.c: Likewise.
2882         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2883         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2884         * features/aarch64-fpu.xml: Add ieee half view.
2885         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2886         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2887         * gdbtypes.h (struct builtin_type): Likewise.
2888         (struct objfile_type): Likewise.
2889
2890 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2891
2892         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2893         typo.
2894         * location.h (string_to_event_location): Likewise.
2895
2896 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2897
2898         GDB 8.3 released.
2899
2900 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2901
2902         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2903         New variable declaration.
2904         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2905         New variable.
2906         (print_one_breakpoint): Use ui_out::test_flags and new global
2907         variable to compute use_fixed_output.
2908         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2909         Remove.
2910         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2911         (mi_multi_location_breakpoint_output_fixed): Remove.
2912         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2913         new variable.
2914         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2915         fix_multi_location_breakpoint_output flag if version >= 3.
2916         * ui-out.h (enum ui_out_flag)
2917         <fix_multi_location_breakpoint_output>: New enumerator.
2918
2919 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2920
2921         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2922
2923 2019-05-10  Tom Tromey  <tromey@adacore.com>
2924
2925         * ada-lang.c (catch_ada_completer): New function.
2926         (_initialize_ada_language): Use it.
2927
2928 2019-05-10  Tom Tromey  <tromey@adacore.com>
2929
2930         * thread.c (print_thread_info): Make "requested_threads" const.
2931         * gdbthread.h (print_thread_info): Make "requested_threads"
2932         const.
2933         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2934         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2935
2936 2019-05-08  Tom Tromey  <tom@tromey.com>
2937
2938         * gdbtypes.c (objfile_type_data): Change type.
2939         (objfile_type, _initialize_gdbtypes): Update.
2940
2941 2019-05-08  Tom Tromey  <tom@tromey.com>
2942
2943         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2944         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2945         (_initialize_dwarf2_frame): Update.
2946
2947 2019-05-08  Tom Tromey  <tom@tromey.com>
2948
2949         * objc-lang.c (objc_objfile_data): Change type.
2950         (find_methods): Update.
2951         (_initialize_objc_lang): Remove.
2952
2953 2019-05-08  Tom Tromey  <tom@tromey.com>
2954
2955         * stabsread.c (rs6000_builtin_type_data): Change type.
2956         (rs6000_builtin_type, _initialize_stabsread): Update.
2957
2958 2019-05-08  Tom Tromey  <tom@tromey.com>
2959
2960         * mips-tdep.c (mips_pdr_data): Remove.
2961         (_initialize_mips_tdep): Update.
2962
2963 2019-05-08  Tom Tromey  <tom@tromey.com>
2964
2965         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2966         (hppa_init_objfile_priv_data, read_unwind_info)
2967         (find_unwind_entry, _initialize_hppa_tdep): Update.
2968
2969 2019-05-08  Tom Tromey  <tom@tromey.com>
2970
2971         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2972         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2973         on obstack.
2974         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2975
2976 2019-05-08  Tom Tromey  <tom@tromey.com>
2977
2978         * mdebugread.c (basic_type_data): Change type.
2979         (basic_type, _initialize_mdebugread): Update.
2980
2981 2019-05-08  Tom Tromey  <tom@tromey.com>
2982
2983         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2984
2985 2019-05-08  Tom Tromey  <tom@tromey.com>
2986
2987         * nto-tdep.c (nto_inferior_data_reg): Change type.
2988         (nto_inferior_data): Update.
2989         (nto_inferior_data_cleanup, nto_new_inferior_data)
2990         (_initialize_nto_tdep): Remove.
2991         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2992
2993 2019-05-08  Tom Tromey  <tom@tromey.com>
2994
2995         * ada-lang.c (struct ada_inferior_data): Add initializers.
2996         (ada_inferior_data): Change type.
2997         (ada_inferior_data_cleanup): Remove.
2998         (get_ada_inferior_data, ada_inferior_exit)
2999         (struct ada_pspace_data): Add initializers, destructor.
3000         (ada_pspace_data_handle): Change type.
3001         (get_ada_pspace_data): Update.
3002         (ada_pspace_data_cleanup): Remove.
3003
3004 2019-05-08  Tom Tromey  <tom@tromey.com>
3005
3006         * coffread.c (struct coff_symfile_info): Add initializers.
3007         (coff_objfile_data_key): Move lower.  Change type.
3008         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3009         Update.
3010         (coff_free_info): Remove.
3011
3012 2019-05-08  Tom Tromey  <tom@tromey.com>
3013
3014         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3015         (fbsd_pspace_data_handle): Move lower.  Change type.
3016         (get_fbsd_pspace_data): Update.
3017         (fbsd_pspace_data_cleanup): Remove.
3018         (_initialize_fbsd_tdep): Update.
3019
3020 2019-05-08  Tom Tromey  <tom@tromey.com>
3021
3022         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3023         (get_ada_tasks_pspace_data): Update.
3024         (ada_tasks_pspace_data_cleanup): Remove.
3025         (_initialize_tasks): Update.
3026         (ada_tasks_inferior_data_handle): Change type.
3027         (get_ada_tasks_inferior_data): Update.
3028         (ada_tasks_inferior_data_cleanup): Remove.
3029         (struct ada_tasks_pspace_data): Add initializers.
3030
3031 2019-05-08  Tom Tromey  <tom@tromey.com>
3032
3033         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3034         * symfile-debug.c (debug_sym_get_probes): Change type.
3035         * stap-probe.c (handle_stap_probe):
3036         (stap_static_probe_ops::get_probes): Change type.
3037         * probe.h (class static_probe_ops) <get_probes>: Change type.
3038         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3039         (parse_probes_in_pspace): Update.
3040         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3041         Update.
3042         (any_static_probe_ops::get_probes): Change type.
3043         * elfread.c (elfread_data): New typedef.
3044         (probe_key): Change type.
3045         (elf_get_probes): Likewise.  Update.
3046         (probe_key_free): Remove.
3047         (_initialize_elfread): Update.
3048         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3049         Change type.
3050         (dtrace_process_dof_probe, dtrace_process_dof)
3051         (dtrace_static_probe_ops::get_probe): Change type.
3052
3053 2019-05-08  Tom Tromey  <tom@tromey.com>
3054
3055         * xcoffread.c (struct xcoff_symfile_info): Rename from
3056         coff_symfile_info.  Add initializers.
3057         (xcoff_objfile_data_key): Move lower.  Change type.
3058         (XCOFF_DATA): Rewrite.
3059         (xcoff_free_info): Remove.
3060         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3061         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3062         (xcoff_initial_scan): Update.
3063
3064 2019-05-08  Tom Tromey  <tom@tromey.com>
3065
3066         * solib-svr4.c (struct svr4_info): Add initializers and
3067         destructor.
3068         <probes_table>: Now an htab_up.
3069         (solib_svr4_pspace_data): Change type.
3070         (free_probes_table): Simplify.
3071         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3072         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3073         (probes_table_remove_objfile_probes, register_solib_event_probe)
3074         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3075         (_initialize_svr4_solib): Update.
3076
3077 2019-05-08  Tom Tromey  <tom@tromey.com>
3078
3079         * remote.c (remote_pspace_data): Change type.
3080         (remote_pspace_data_cleanup): Remove.
3081         (get_remote_exec_file, set_pspace_remote_exec_file)
3082         (_initialize_remote): Update.
3083
3084 2019-05-08  Tom Tromey  <tom@tromey.com>
3085
3086         * breakpoint.c (breakpoint_objfile_key): Change type.
3087         (get_breakpoint_objfile_data): Update.
3088         (free_breakpoint_objfile_data): Remove.
3089         (_initialize_breakpoint): Update.
3090
3091 2019-05-08  Tom Tromey  <tom@tromey.com>
3092
3093         * linux-tdep.c (struct linux_info): Add initializers.
3094         (linux_inferior_data): Move.  Change type.
3095         (invalidate_linux_cache_inf): Update.
3096         (linux_inferior_data_cleanup): Remove.
3097         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3098
3099 2019-05-08  Tom Tromey  <tom@tromey.com>
3100
3101         * auxv.c (auxv_inferior_data): Move.  Change type.
3102         (auxv_inferior_data_cleanup): Remove.
3103         (invalidate_auxv_cache_inf): Rewrite.
3104         (get_auxv_inferior_data, _initialize_auxv): Update.
3105
3106 2019-05-08  Tom Tromey  <tom@tromey.com>
3107
3108         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3109         (symfile_debug_objfile_data_key): Change type.
3110         (symfile_debug_installed, debug_qf_has_symbols)
3111         (debug_qf_find_last_source_symtab)
3112         (debug_qf_forget_cached_source_info)
3113         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3114         (debug_qf_print_stats, debug_qf_dump)
3115         (debug_qf_expand_symtabs_for_function)
3116         (debug_qf_expand_all_symtabs)
3117         (debug_qf_expand_symtabs_with_fullname)
3118         (debug_qf_map_matching_symbols)
3119         (debug_qf_expand_symtabs_matching)
3120         (debug_qf_find_pc_sect_compunit_symtab)
3121         (debug_qf_map_symbol_filenames)
3122         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3123         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3124         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3125         (debug_sym_read_linetable, debug_sym_relocate): Update.
3126         (symfile_debug_free_objfile): Remove.
3127         (install_symfile_debug_logging, _initialize_symfile_debug):
3128         Update.
3129
3130 2019-05-08  Tom Tromey  <tom@tromey.com>
3131
3132         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3133         allocate_on_obstack.
3134         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3135         (get_dwarf2_per_objfile): Update.
3136         (set_dwarf2_per_objfile): Remove.
3137         (dwarf2_has_info, dwarf2_get_section_info): Update.
3138         (dwarf2_free_objfile): Remove.
3139         (_initialize_dwarf2_read): Update.
3140
3141 2019-05-08  Tom Tromey  <tom@tromey.com>
3142
3143         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3144         initializers.
3145         <unsupported_script_warning_printed,
3146         script_not_found_warning_printed>: Now bool.
3147         (auto_load_pspace_data): Change type.
3148         (~auto_load_pspace_info): Rename from
3149         auto_load_pspace_data_cleanup.
3150         (get_auto_load_pspace_data, init_loaded_scripts_info)
3151         (clear_section_scripts, maybe_print_unsupported_script_warning)
3152         (maybe_print_script_not_found_warning, _initialize_auto_load):
3153         Update.
3154
3155 2019-05-08  Tom Tromey  <tom@tromey.com>
3156
3157         * objfiles.c (objfile_pspace_info): Add destructor and
3158         initializers.
3159         (objfiles_pspace_data): Change type.
3160         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3161         (get_objfile_pspace_data): Update.
3162         (objfiles_bfd_data): Change type.
3163         (get_objfile_bfd_data): Update.
3164         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3165
3166 2019-05-08  Tom Tromey  <tom@tromey.com>
3167
3168         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3169         Change type.
3170         (get_catch_syscall_inferior_data): Update.
3171         (catch_syscall_inferior_data_cleanup): Remove.
3172         (_initialize_break_catch_syscall): Update.
3173
3174 2019-05-08  Tom Tromey  <tom@tromey.com>
3175
3176         * inflow.c (struct terminal_info): Add destructor and
3177         initializers.
3178         (inflow_inferior_data): Change type.
3179         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3180         (get_inflow_inferior_data, inflow_inferior_exit)
3181         (swap_terminal_info, _initialize_inflow): Update.
3182
3183 2019-05-08  Tom Tromey  <tom@tromey.com>
3184
3185         * target-dcache.c (target_dcache_cleanup): Remove.
3186         (target_dcache_aspace_key): Change type.
3187         (target_dcache_init_p, target_dcache_invalidate)
3188         (target_dcache_get, target_dcache_get_or_init)
3189         (_initialize_target_dcache): Update.
3190         * dcache.h (struct dcache_deleter): New.
3191
3192 2019-05-08  Tom Tromey  <tom@tromey.com>
3193
3194         * symtab.c (struct symbol_cache): Add destructor and
3195         initializers.
3196         (symbol_cache_key): Move.  Change type.
3197         (make_symbol_cache, free_symbol_cache): Remove.
3198         (get_symbol_cache): Update.
3199         (symbol_cache_cleanup): Remove.
3200         (ALL_PSPACES, symbol_cache_flush)
3201         (maintenance_print_symbol_cache)
3202         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3203         Update.
3204
3205 2019-05-08  Tom Tromey  <tom@tromey.com>
3206
3207         * symtab.c (struct main_info): Add destructor and initializers.
3208         (main_progspace_key): Move.  Change type.
3209         (get_main_info): Update.
3210         (main_info_cleanup): Remove.
3211         (_initialize_symtab): Update.
3212
3213 2019-05-08  Tom Tromey  <tom@tromey.com>
3214
3215         * registry.h (DECLARE_REGISTRY): Define the _key class.
3216
3217 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3218
3219         * NEWS: Merge two 'New commands' sections.
3220
3221 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3222
3223         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3224         parameter and use Ada language definition instead.
3225         (ada_val_print_ptr): Remove unused language parameter.
3226         (ada_val_print_num): Remove language parameter and use Ada language
3227         definition instead.
3228         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3229         parameter.
3230         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3231         parameter and use Ada language definition instead.
3232         (ada_val_print_1): Update all ada_val_print_xxx calls.
3233         Remove language parameter.
3234         (ada_val_print): Update ada_val_print_1 call.
3235
3236 2019-05-08  Tom Tromey  <tromey@adacore.com>
3237
3238         * remote.c (remote_hw_watchpoint_limit)
3239         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3240         Now static.
3241
3242 2019-05-08  Tom Tromey  <tromey@adacore.com>
3243
3244         * maint.c (_initialize_maint_cmds): Move initialization code to
3245         remote.c.
3246         (watchdog, show_watchdog): Move to remote.c.
3247         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3248         "watchdog" static.
3249         (_initialize_remote): Move initialization code from maint.c.
3250         * defs.h (watchdog): Don't declare.
3251
3252 2019-05-08  Tom Tromey  <tromey@adacore.com>
3253
3254         * tui/tui-interp.c: Include main.h.
3255         * interps.c: Include main.h.
3256         * main.h (interpreter_p): Declare.
3257         * defs.h (interpreter_p): Don't declare.
3258
3259 2019-05-08  Tom Tromey  <tromey@adacore.com>
3260
3261         * dwarf2loc.c: Include dwarf2read.h.
3262         * defs.h (read_unsigned_leb128): Don't declare.
3263         * dwarf2read.h (read_unsigned_leb128): Declare.
3264
3265 2019-05-08  Tom Tromey  <tromey@adacore.com>
3266
3267         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3268         method.
3269
3270 2019-05-08  Tom Tromey  <tromey@adacore.com>
3271
3272         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3273         when no wrap column is set.
3274
3275 2019-05-08  Tom Tromey  <tromey@adacore.com>
3276
3277         * c-lang.c (c_get_string): Handle non-C-style arrays.
3278
3279 2019-05-08  Tom Tromey  <tromey@adacore.com>
3280
3281         * typeprint.c (print_offset_data::update): Print the bit offset,
3282         not the number of bits remaining.
3283
3284 2019-05-08  Tom Tromey  <tromey@adacore.com>
3285
3286         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3287         padding at end of comment.
3288
3289 2019-05-08  Tom Tromey  <tromey@adacore.com>
3290
3291         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3292         Compare main types.
3293
3294 2019-05-06  Tom Tromey  <tom@tromey.com>
3295
3296         * common/scoped_mmap.c: Include common-defs.h.
3297         * common/scoped_mmap.h: Don't include config.h.
3298
3299 2019-05-04  Tom Tromey  <tom@tromey.com>
3300
3301         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3302         (struct aarch64_call_info): Add initializers.
3303         <si>: Now a std::vector.
3304         (pass_on_stack, aarch64_push_dummy_call): Update.
3305
3306 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3307             Tom Tromey  <tom@tromey.com>
3308
3309         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3310         (ppc_threads): Now a std::vector.  Now static.
3311         (hwdebug_find_thread_points_by_tid)
3312         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3313         Update.
3314
3315 2019-05-04  Tom Tromey  <tom@tromey.com>
3316
3317         * arc-tdep.c (arc_tdesc_init): Return bool.
3318
3319 2019-05-04  Tom Tromey  <tom@tromey.com>
3320
3321         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3322         Use gdb_assert_not_reached.
3323
3324 2019-05-04  Tom Tromey  <tom@tromey.com>
3325
3326         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3327         "false".
3328
3329 2019-05-04  Tom Tromey  <tom@tromey.com>
3330
3331         * arc-tdep.c (arc_tdesc_init): Use bool.
3332
3333 2019-05-04  Tom Tromey  <tom@tromey.com>
3334
3335         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3336
3337 2019-05-04  Tom Tromey  <tom@tromey.com>
3338
3339         * cli/cli-cmds.c (valid_command_p): Return bool.
3340
3341 2019-05-04  Tom Tromey  <tom@tromey.com>
3342
3343         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3344         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3345
3346 2019-05-04  Raul Tambre  <raul@tambre.ee>
3347
3348         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3349         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3350         operator for comparison.
3351
3352 2019-05-04  Tom Tromey  <tom@tromey.com>
3353
3354         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3355         (lookup_partial_symbol, print_partial_symbols)
3356         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3357         (psymbol_compare): Update.
3358         (add_psymbol_to_bcache): Clear the entire psymbol.
3359         (maintenance_check_psymtabs): Update.
3360         * psympriv.h (struct partial_symbol): Don't derive from
3361         general_symbol_info.
3362         <obj_section, unrelocated_address, address,
3363         set_unrelocated_address>: Update.
3364         <ginfo>: New member.
3365         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3366         (debug_names::write_psymbols): Update.
3367
3368 2019-05-04  Tom de Vries  <tdevries@suse.de>
3369
3370         * contrib/cc-with-tweaks.sh: Support -n arg.
3371
3372 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3373
3374         * corelow.c (core_target::detach): Ensure frame cache and
3375         register caches are cleared.
3376         inferior.c (exit_inferior_1): Likewise.
3377
3378 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3379             Tom Tromey  <tom@tromey.com>
3380
3381         * dictionary.c (collate_pending_symbols_by_language): Remove
3382         "struct" from foreach.
3383         * symtab.c (lookup_global_symbol_from_objfile)
3384         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3385         foreach.
3386         * ser-tcp.c (net_open): Remove "struct" from foreach.
3387         * objfiles.c (objfile_relocate, objfile_rebase)
3388         (objfile_has_symbols): Remove "struct" from foreach.
3389         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3390         from foreach.
3391         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3392         foreach.
3393         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3394         "struct" from foreach.
3395         * ada-lang.c (create_excep_cond_exprs)
3396         (ada_exception_catchpoint_cond_string): Remove "struct" from
3397         foreach.
3398
3399 2019-05-03  Tom Tromey  <tromey@adacore.com>
3400
3401         * ada-exp.y (convert_char_literal): Check suffix of each
3402         enumerator.
3403
3404 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3405
3406         PR ada/21406:
3407         * ada-exp.y (yywrap): Don't define.
3408         * ada-lex.l (%option): Add noyywrap
3409         (yywrap): Remove.
3410
3411 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3412
3413         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3414         _WIN32_WINNT to the XP level, unless already defined to a higher
3415         level.
3416
3417         * unittests/parse-connection-spec-selftests.c:
3418         * ser-tcp.c:
3419         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3420         override.
3421
3422         * symfile.c (find_separate_debug_file): Remove colon from the
3423         drive spec of DOS/Windows file names of the target, so that the
3424         file name produced from DEBUGDIR and the target's directory will
3425         be valid on DOS/Windows systems.
3426
3427 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3428
3429         * rust-lang.c (val_print_struct): Handle printing structures
3430         containing strings.
3431
3432 2019-05-02  Tom Tromey  <tromey@adacore.com>
3433
3434         * valarith.c (_initialize_valarith): Remove.
3435
3436 2019-05-01  Tom Tromey  <tromey@adacore.com>
3437
3438         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3439         bitfields.
3440
3441 2019-05-01  Tom Tromey  <tromey@adacore.com>
3442
3443         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3444         for big-endian copies.
3445
3446 2019-04-30  Ali Tamur  <tamur@google.com>
3447         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3448         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3449         (read_3_bytes): New function.
3450
3451 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3452
3453         * windows-nat.c (main_thread_id): Delete.
3454         (handle_output_debug_string): Replace main_thread_id by
3455         current_event.dwThreadId.
3456         (fake_create_process): Likewise.
3457         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3458         Do not set main_thread_id.
3459         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3460         current_event.dwThreadId.
3461         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3462
3463 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3464
3465         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3466         Use current_event.dwThreadId instead of main_thread_id.
3467
3468 2019-04-30  Tom Tromey  <tromey@adacore.com>
3469
3470         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3471         (create_excep_cond_exprs): Iterate over program spaces.
3472         (ada_exception_catchpoint_cond_string): Examine all minimal
3473         symbols for exception types.
3474
3475 2019-04-30  Tom Tromey  <tromey@adacore.com>
3476
3477         PR c++/24470:
3478         * dwarf2read.c (process_structure_scope): Handle case where type
3479         has template parameters but no symbol was created.
3480
3481 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3482             Chris January  <chris.january@arm.com>
3483
3484         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3485         qualifier.
3486         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3487
3488 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3489
3490         * f-typeprint.c (f_print_type): Update rules for printing
3491         whitespace.
3492         (f_type_print_varspec_suffix): Likewise.
3493
3494 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3495             Chris January  <chris.january@arm.com>
3496
3497         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3498         function arguments.
3499
3500 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3501
3502         * f-lang.c (build_fortran_types): Change name of void type to
3503         lower case.
3504         * f-typeprint.c (f_type_print_base): Print the name of the void
3505         type, rather than a fixed string.
3506         * f-valprint.c (f_decorations): Use lower case void string.
3507
3508 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3509             Chris January  <chris.january@arm.com>
3510
3511         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3512         types for Fortran.
3513
3514 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3515             Chris January  <chris.january@arm.com>
3516             David Lecomber  <david.lecomber@arm.com>
3517
3518         * f-exp.y (BINOP_INTRINSIC): New token.
3519         (exp): New parser rule handling BINOP_INTRINSIC.
3520         (f77_keywords): Add new builtin procedures.
3521         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3522         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3523         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3524         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3525         (print_unop_subexp_f): New function.
3526         (print_binop_subexp_f): New function.
3527         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3528         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3529         (dump_subexp_body_f): Likewise.
3530         (operator_check_f): Likewise.
3531         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3532         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3533
3534 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3535
3536         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3537         UNOP_KIND.
3538         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3539         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3540         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3541         (operator_length_f): New fuction.
3542         (print_subexp_f): New function.
3543         (op_name_f): New function.
3544         (dump_subexp_body_f): New function.
3545         (operator_check_f): New function.
3546         (exp_descriptor_f): Replace standard expression handling functions
3547         with new functions.
3548         * gdb/fortran-operator.def: New file.
3549         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3550         * gdb/std-operator.def: Remove UNOP_KIND.
3551
3552 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3553
3554         * std-operator.def: Remove unbalanced, stray double quote
3555         character.
3556
3557 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3558             Chris January  <chris.january@arm.com>
3559             Daniel Everett  <daniel.everett@arm.com>
3560             Nick Forrington  <nick.forrington@arm.com>
3561             Richard Bunt  <richard.bunt@arm.com>
3562
3563         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3564         of depth when printing anonymous structs or unions.
3565         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3566         Don't print either the top-level value, or the children if the
3567         max-depth is exceeded.
3568         (ppscm_print_children): When printing the key of a map, allow one
3569         extra level of depth.
3570         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3571         print either the top-level value, or the children if the max-depth
3572         is exceeded.
3573         (print_children): When printing the key of a map, allow one extra
3574         level of depth.
3575         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3576         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3577         (user_print_options): Initialise max_depth field.
3578         (val_print_scalar_or_string_type_p): New function.
3579         (val_print): Check to see if the max depth has been reached.
3580         (val_print_check_max_depth): Define new function.
3581         (show_print_max_depth): New function.
3582         (_initialize_valprint): Add 'print max-depth' option.
3583         * valprint.h (struct value_print_options) <max_depth>: New field.
3584         (val_print_check_max_depth): Declare new function.
3585         * NEWS: Document new feature.
3586
3587 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3588
3589         * ada-lang.c (ada_language_defn): Initialise new field.
3590         * c-lang.c (c_is_string_type_p): New function.
3591         (c_language_defn): Initialise new field.
3592         (cplus_language_defn): Initialise new field.
3593         (asm_language_defn): Initialise new field.
3594         (minimal_language_defn): Initialise new field.
3595         * c-lang.h (c_is_string_type_p): Declare new function.
3596         * d-lang.c (d_language_defn): Initialise new field.
3597         * f-lang.c (f_is_string_type_p): New function.
3598         (f_language_defn): Initialise new field.
3599         * go-lang.c (go_is_string_type_p): New function.
3600         (go_language_defn): Initialise new field.
3601         * language.c (default_is_string_type_p): New function.
3602         (unknown_language_defn): Initialise new field.
3603         (auto_language_defn): Initialise new field.
3604         * language.h (struct language_defn) <la_is_string_type_p>: New
3605         member variable.
3606         (default_is_string_type_p): Declare new function.
3607         * m2-lang.c (m2_language_defn): Initialise new field.
3608         * objc-lang.c (objc_language_defn): Initialise new field.
3609         * opencl-lang.c (opencl_language_defn): Initialise new field.
3610         * p-lang.c (pascal_is_string_type_p): New function.
3611         (pascal_language_defn): Initialise new field.
3612         * rust-lang.c (rust_is_string_type_p): New function.
3613         (rust_language_defn): Initialise new field.
3614
3615 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3616
3617         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3618         New field.
3619         * ada-lang.c (ada_language_defn): Initialise new field.
3620         * c-lang.c (c_language_defn): Likewise.
3621         (cplus_language_defn): Likewise.
3622         (asm_language_defn): Likewise.
3623         (minimal_language_defn): Likewise.
3624         * d-lang.c (d_language_defn): Likewise.
3625         * f-lang.c (f_language_defn): Likewise.
3626         * go-lang.c (go_language_defn): Likewise.
3627         * language.c (unknown_language_defn): Likewise.
3628         (auto_language_defn): Likewise.
3629         * m2-lang.c (m2_language_defn): Likewise.
3630         * objc-lang.c (objc_language_defn): Likewise.
3631         * opencl-lang.c (opencl_language_defn): Likewise.
3632         * p-lang.c (pascal_language_defn): Likewise.
3633         * rust-lang.c (rust_language_defn): Likewise.
3634
3635 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3636
3637         * ada-lang.c (ada_is_character_type): Change return type to bool.
3638         (ada_is_string_type): Likewise.
3639         * ada-lang.h (ada_is_character_type): Update declaration
3640         (ada_is_string_type): Likewise.
3641
3642 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3643
3644         Support style in 'frame|thread apply'
3645
3646         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3647         * record.c (record_start, record_stop): Update callers of
3648         execute_command_to_string with false.
3649         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3650         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3651         methods.
3652         (class string_file): New constructor with term_out parameter.
3653         Override methods term_out and can_emit_style_escape.  New member
3654         term_out.
3655         (class stdio_file): Override can_emit_style_escape.
3656         (class tee_file): Override term_out and can_emit_style_escape.
3657         * utils.h (can_emit_style_escape): Remove.
3658         * utils.c (can_emit_style_escape): Likewise.
3659         Update all callers of can_emit_style_escape (SOMESTREAM) to
3660         SOMESTREAM->can_emit_style_escape.
3661         * source-cache.c (source_cache::get_source_lines): Likewise.
3662         * stack.c (frame_apply_command_count): Call execute_command_to_string
3663         passing the term_out characteristic of the current gdb_stdout.
3664         * thread.c (thr_try_catch_cmd): Likewise.
3665         * top.c (execute_command_to_string): pass term_out parameter
3666         to construct the string_file for the command output.
3667         * ui-file.c (term_cli_styling): New function (most code moved
3668         from utils.c can_emit_style_escape).
3669         (string_file::string_file, string_file::can_emit_style_escape,
3670         stdio_file::can_emit_style_escape, tee_file::term_out,
3671         tee_file::can_emit_style_escape): New functions.
3672
3673 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3674
3675         * NEWS: Mention the new set|show may-call-functions.
3676         * infcall.c (may_call_functions_p): New variable.
3677         (show_may_call_functions_p): New function.
3678         (call_function_by_hand_dummy): Throws an error if not
3679         may-call-functions.
3680         (_initialize_infcall): Call add_setshow_boolean_cmd for
3681         may-call-functions.
3682
3683 2019-04-25  Keith Seitz  <keiths@redhat.com>
3684
3685         PR c++/24367
3686         * cp-support.c (inspect_type): Don't attempt substitutions
3687         of symbol with the same name.
3688
3689 2019-04-25  Tom Tromey  <tromey@adacore.com>
3690
3691         PR gdb/24475:
3692         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3693         static.
3694
3695 2019-04-25  Tom Tromey  <tromey@adacore.com>
3696
3697         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3698         rvalue reference.
3699         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3700         (gdb_xml_parser::parse): Use std::move.
3701         * python/python-internal.h (gdbpy_convert_exception): Take a const
3702         reference.
3703         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3704         std::move.
3705         * python/py-utils.c (gdbpy_convert_exception): Take a const
3706         reference.
3707         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3708         Use std::move.
3709         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3710         Use std::move.
3711         * mi/mi-main.c (mi_print_exception): Take a const reference.
3712         * main.c (handle_command_errors): Take a const reference.
3713         * linespec.c (parse_linespec): Use std::move.
3714         * infcall.c (run_inferior_call): Use std::move.
3715         (call_function_by_hand_dummy): Use std::move.
3716         * exec.c (try_open_exec_file): Use std::move.
3717         * exceptions.h (exception_print, exception_fprintf)
3718         (exception_print_same): Update.
3719         * exceptions.c (print_exception, exception_print)
3720         (exception_fprintf, exception_print_same): Change parameters to
3721         const reference.
3722         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3723         * common/new-op.c: Use std::move.
3724         * common/common-exceptions.h (struct gdb_exception): Add move
3725         constructor.
3726         (struct gdb_exception_error, struct gdb_exception_quit, struct
3727         gdb_quit_bad_alloc): Change constructor to move constructor.
3728         (throw_exception): Change parameter to rvalue reference.
3729         * common/common-exceptions.c (throw_exception): Take rvalue
3730         reference.
3731         * cli/cli-interp.c (safe_execute_command): Use std::move.
3732         * breakpoint.c (insert_bp_location, location_to_sals): Use
3733         std::move.
3734
3735 2019-04-25  Tom Tromey  <tromey@adacore.com>
3736
3737         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3738         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3739         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3740         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3741         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3742         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3743         guile/scm-value.c: Use unpack.
3744         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3745         gdbscm_gdb_exception.
3746         (gdbscm_throw_gdb_exception): Likewise.
3747         (struct gdbscm_gdb_exception): New.
3748         (unpack): New function.
3749         (gdbscm_wrap): Use unpack.
3750
3751 2019-04-25  Tom Tromey  <tromey@adacore.com>
3752
3753         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3754         (gdb_rl_callback_handler): Use std::move.
3755         * common/common-exceptions.h (struct gdb_exception): Add move
3756         assignment operator.
3757         (throw_exception_sjlj): Change "exception" to const reference.
3758         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3759         (throw_exception_sjlj): Change "exception" to const reference.
3760
3761 2019-04-25  Tom Tromey  <tromey@adacore.com>
3762
3763         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3764         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3765         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3766         Update.
3767         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3768         Update.
3769         * mi/mi-interp.c (mi_interp::exec): Update.
3770         * linespec.c (parse_linespec): Update.
3771         * infcall.c (run_inferior_call): Update.
3772         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3773         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3774         (gdbscm_lookup_global_symbol): Update.
3775         * guile/scm-param.c (gdbscm_parameter_value): Update.
3776         * guile/scm-frame.c (gdbscm_frame_read_register)
3777         (gdbscm_frame_read_var): Update.
3778         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3779         * exec.c (try_open_exec_file): Update.
3780         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3781         (gdb_rl_callback_handler): Update.
3782         * common/common-exceptions.h (exception_none): Don't declare.
3783         * common/common-exceptions.c (exception_none): Don't define.
3784         (struct catcher) <exception>: Update.
3785         * cli/cli-interp.c (safe_execute_command): Update.
3786         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3787
3788 2019-04-25  Ali Tamur  <tamur@google.com>
3789
3790         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3791         (read_attribute_value): Likewise.
3792         (dwarf2_read_addr_index): Update comment.
3793         (read_str_index): Add DW_FORM_strx.
3794         (dwarf2_string_attr): Likewise.
3795         (dwarf2_const_value_attr): Likewise.
3796         (dump_die_shallow): Likewise.
3797         (dwarf2_fetch_constant_bytes): Likewise.
3798         (skip_form_bytes): Likewise.
3799         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3800
3801 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3802
3803         PR corefiles/11608
3804         PR corefiles/18187
3805         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3806         OFFSET.  Verify if current mapping contains an ELF header.
3807         (linux_find_memory_regions_full): Adjust call to
3808         dump_mapping_p.
3809
3810 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3811             Kang Li <kanglictf@gmail.com>
3812
3813         PR gdb/21600
3814
3815         * dwarf2-frame.c (read_initial_length): Be consistent about using
3816         unsigned representation of length.
3817         (decode_frame_entry_1): Likewise.  Check for wraparound of
3818         end pointer as well as buffer overflow.
3819
3820 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3821
3822         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3823         "vq".
3824
3825 2019-04-24  Tom Tromey  <tromey@adacore.com>
3826
3827         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3828
3829 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3830
3831         * s12z-tdep.c (s12z_unwind_pc): Delete.
3832         (s12z_unwind_sp): Delete.
3833         (s12z_gdbarch_init): Don't register deleted functions with
3834         gdbarch.
3835
3836 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3837
3838         * rl78-tdep.c (rl78_unwind_sp): Delete.
3839         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3840
3841 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3842
3843         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3844         (xstormy16_unwind_pc): Delete.
3845         (xstormy16_dummy_id): Delete.
3846         (xstormy16_gdbarch_init): Don't register deleted functions with
3847         gdbarch.
3848
3849 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3850
3851         * vax-tdep.c (vax_unwind_pc): Delete.
3852         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3853
3854 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3855
3856         * v850-tdep.c (v850_unwind_sp): Delete.
3857         (v850_unwind_pc): Delete.
3858         (v850_dummy_id): Delete.
3859         (v850_gdbarch_init): Don't register deleted functions with
3860         gdbarch.
3861
3862 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3863
3864         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3865         (tilegx_unwind_pc): Delete.
3866         (tilegx_unwind_dummy_id): Delete.
3867         (tilegx_gdbarch_init): Don't register deleted functions with
3868         gdbarch.
3869
3870 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3871
3872         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3873         (tic6x_dummy_id): Delete.
3874         (tic6x_gdbarch_init): Don't register deleted functions with
3875         gdbarch.
3876
3877 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3878
3879         * sparc-tdep.c (sparc_unwind_pc): Delete.
3880         (sparc32_gdbarch_init): Don't register deleted function with
3881         gdbarch.
3882
3883 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3884
3885         * sh-tdep.c (sh_unwind_sp): Delete.
3886         (sh_unwind_pc): Delete.
3887         (sh_dummy_id): Delete.
3888         (sh_gdbarch_init): Don't register deleted functions with
3889         gdbarch.
3890
3891 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3892
3893         * score-tdep.c (score_unwind_sp): Delete.
3894         (score_unwind_pc): Delete.
3895         (score_dummy_id): Delete.
3896         (score_gdbarch_init): Don't register deleted functions with
3897         gdbarch.
3898
3899 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3900
3901         * rx-tdep.c (rx_unwind_pc): Delete.
3902         (rx_unwind_sp): Delete.
3903         (rx_dummy_id): Delete.
3904         (rx_gdbarch_init): Don't register deleted functions with
3905         gdbarch.  Update comment.
3906
3907 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3908
3909         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3910         (rs6000_dummy_id): Delete.
3911         (rs6000_gdbarch_init): Don't register deleted functions with
3912         gdbarch.
3913
3914 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3915
3916         * or1k-tdep.c (or1k_dummy_id): Delete.
3917         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3918
3919 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3920
3921         * nios2-tdep.c (nios2_dummy_id): Delete.
3922         (nios2_unwind_sp): Delete.
3923         (nios2_gdbarch_init): Don't register deleted functions with
3924         gdbarch.
3925
3926 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3927
3928         * nds32-tdep.c (nds32_dummy_id): Delete.
3929         (nds32_unwind_pc): Delete.
3930         (nds32_unwind_sp): Delete.
3931         (nds32_gdbarch_init): Don't register deleted functions with
3932         gdbarch.
3933
3934 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3935
3936         * msp430-tdep.c (msp430_unwind_pc): Delete.
3937         (msp430_unwind_sp): Delete.
3938         (msp430_dummy_id): Delete.
3939         (msp430_gdbarch_init): Don't register deleted functions with
3940         gdbarch.
3941
3942 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3943
3944         * moxie-tdep.c (moxie_unwind_sp): Delete.
3945         (moxie_unwind_pc): Delete.
3946         (moxie_dummy_id): Delete.
3947         (moxie_gdbarch_init): Don't register deleted functions with
3948         gdbarch.
3949
3950 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3951
3952         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3953         (mn10300_unwind_pc): Delete.
3954         (mn10300_unwind_sp): Delete.
3955         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3956         mn10300_unwind_sp.
3957         (mn10300_frame_unwind_init): Don't register deleted functions with
3958         gdbarch.
3959
3960 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3961
3962         * mep-tdep.c (mep_unwind_pc): Delete.
3963         (mep_unwind_sp): Delete.
3964         (mep_dummy_id): Delete.
3965         (mep_gdbarch_init): Don't register deleted functions with
3966         gdbarch.
3967
3968 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3969
3970         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3971         (m68hc11_unwind_sp): Delete.
3972         (m68hc11_gdbarch_init): Don't register deleted functions with
3973         gdbarch.
3974
3975 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3976
3977         * m32r-tdep.c (m32r_unwind_sp): Delete.
3978         (m32r_unwind_pc): Delete.
3979         (m32r_dummy_id): Delete.
3980         (m32r_gdbarch_init): Don't register deleted functions with
3981         gdbarch.
3982
3983 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3984
3985         * m32c-tdep.c (m32c_unwind_pc): Delete.
3986         (m32c_unwind_sp): Delete.
3987         (m32c_dummy_id): Delete.
3988         (m32c_gdbarch_init): Don't register deleted functions with
3989         gdbarch.
3990
3991 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3992
3993         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3994         (lm32_unwind_pc): Delete.
3995         (lm32_dummy_id): Delete.
3996         (lm32_gdbarch_init): Don't register deleted functions with
3997         gdbarch.
3998
3999 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4000
4001         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4002         (iq2000_unwind_pc): Delete.
4003         (iq2000_dummy_id): Delete.
4004         (iq2000_gdbarch_init): Don't register deleted functions with
4005         gdbarch.
4006
4007 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4008
4009         * nds32-tdep.c (nds32_type_align): Delete.
4010         (nds32_push_dummy_call): Use type_align instead.
4011
4012 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4013
4014         * arm-tdep.c (arm_type_align): Only handle vector override case.
4015         (arm_push_dummy_call): Use type_align.
4016         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4017
4018 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4019
4020         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4021         case.
4022         (pass_on_stack): Use type_align.
4023         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4024         function.
4025
4026 2019-04-23  Tom Tromey  <tromey@adacore.com>
4027
4028         * dwarf2read.c (line_header::file_name_at): Remove unused
4029         overload.
4030
4031 2019-04-23  Tom de Vries  <tdevries@suse.de>
4032
4033         PR gdb/24438
4034         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4035         invocation.
4036
4037
4038 2019-03-27  Ali Tamur  <tamur@google.com>
4039
4040         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4041         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4042         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4043         (dwarf_expr_context::get_addr_index): Likewise
4044         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4045         (symbol_needs_eval_context::get_addr_index): Likewise
4046         (disassemble_dwarf_expression): Add DW_OP_addrx
4047         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4048         (read_cutu_die_from_dwo): Update comment
4049         (skip_one_die): Add DW_FORM_addrx
4050         (read_attribute_value): Likewise
4051         (var_decode_location): Add DW_OP_addrx
4052         (dwarf2_const_value_attr): Add DW_FORM_addrx
4053         (dump_die_shallow): Likewise
4054         (dwarf2_fetch_constant_bytes): Likewise
4055         (decode_locdesc): Add DW_OP_addrx
4056         (skip_form_bytes): Add DW_FORM_addrx
4057
4058 2019-04-22  Ali Tamur  <tamur@google.com>
4059
4060         * MAINTAINERS (Write After Approval): Add self.
4061
4062 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4063
4064         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4065         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4066         (open_symbol_file_object): Likewise.
4067         (svr4_default_sos): Add info parameter.
4068         (svr4_read_so_list): Likewise.
4069         (svr4_current_sos_direct): Adjust functions calls to pass down
4070         info.
4071         (svr4_current_sos_1): Add info parameter.
4072         (svr4_current_sos): Call get_svr4_info, pass info down to
4073         svr4_current_sos_1.
4074         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4075         get_svr4_info.
4076         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4077         get_svr4_info.
4078         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4079         to get_svr4_info.
4080         (probes_table_remove_objfile_probes): Likewise.
4081         (register_solib_event_probe): Add info parameter.
4082         (solist_update_incremental): Pass info parameter down to
4083         svr4_read_so_list.
4084         (disable_probes_interface): Add info parameter.
4085         (svr4_handle_solib_event): Pass current_program_space to
4086         get_svr4_info.  Adjust disable_probes_interface cleanup.
4087         (svr4_create_probe_breakpoints): Add info parameter, pass it
4088         down to register_solib_event_probe.
4089         (svr4_create_solib_event_breakpoints): Add info parameter,
4090         pass it down to svr4_create_probe_breakpoints.
4091         (enable_break): Pass info down to
4092         svr4_create_solib_event_breakpoints.
4093         (svr4_solib_create_inferior_hook): Pass current_program_space to
4094         get_svr4_info.
4095         (svr4_clear_solib): Likewise.
4096
4097 2019-04-22  Pedro Alves  <palves@redhat.com>
4098
4099         * solib-svr4.c (svr4_free_objfile_observer): New.
4100         (probe_and_action::objfile): New field.
4101         (probes_table_htab_remove_objfile_probes)
4102         (probes_table_remove_objfile_probes): New functions.
4103         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4104         in the new probe_and_action.  Don't store the probe in 'lookup'.
4105         (svr4_create_probe_breakpoints): Pass objfile to
4106         register_solib_event_probe.
4107         (_initialize_svr4_solib): Register a free_objfile observer.
4108
4109 2019-04-19  Tom Tromey  <tom@tromey.com>
4110
4111         * common/queue.h: Remove.
4112
4113 2019-04-19  Tom Tromey  <tom@tromey.com>
4114
4115         * event-loop.c: Don't include "common/queue.h".
4116
4117 2019-04-19  Tom Tromey  <tom@tromey.com>
4118
4119         * remote.c (remote_target): Use delete.
4120         * remote-notif.h: Include <list>, not "common/queue.h".
4121         (notif_client_p): Remove typedef.
4122         (remote_notif_state): Add constructor, destructor, initializer.
4123         <notif_queue>: Now a std::list.
4124         (remote_notif_state_xfree): Don't declare.
4125         * remote-notif.c (remote_notif_process, handle_notification)
4126         (remote_notif_state_allocate): Update.
4127         (~remote_notif_state): Rename from remote_notif_state_xfree.
4128
4129 2019-04-19  Tom Tromey  <tom@tromey.com>
4130
4131         * symfile.c (reread_symbols): Update.
4132         * objfiles.c (objfile_register_static_link)
4133         (objfile_lookup_static_link): Update
4134         (~objfile) Don't delete static_links.
4135         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4136
4137 2019-04-19  Tom Tromey  <tom@tromey.com>
4138
4139         * type-stack.h (struct type_stack) <insert>: Constify string.
4140         * type-stack.c (type_stack::insert): Constify string.
4141         * gdbtypes.h (lookup_template_type): Update.
4142         (address_space_name_to_int): Update.
4143         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4144         const.
4145         (lookup_template_type): Make name const.
4146         * c-exp.y: Update rules.
4147         (lex_one_token, classify_name, classify_inner_name)
4148         (c_print_token): Update.
4149         * p-exp.y: Update rules.
4150         (yylex): Update.
4151         * f-exp.y: Update rules.
4152         (yylex): Update.
4153         * d-exp.y: Update rules.
4154         (lex_one_token, classify_name, classify_inner_name): Update.
4155         * parse.c (write_dollar_variable, copy_name): Return std::string.
4156         * parser-defs.h (copy_name): Change return type.
4157         * m2-exp.y: Update rules.
4158         (yylex): Update.
4159         * go-exp.y (lex_one_token): Update.
4160         Update rules.
4161         (classify_unsafe_function, classify_packaged_name)
4162         (classify_name, yylex): Update.
4163
4164 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4165
4166         * configure.ac: add --enable-source-highlight switch.
4167         * configure: Regenerate.
4168         * top.c (print_gdb_version): plumb --enable-source-highlight
4169         status to "show configuration".
4170
4171 2019-04-19  Tom Tromey  <tromey@adacore.com>
4172
4173         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4174         Check ADA_TYPE_P.
4175         (empty_record, ada_template_to_fixed_record_type_1)
4176         (template_to_static_fixed_type)
4177         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4178         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4179         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4180         macros.
4181
4182 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4183
4184         PR symtab/24423:
4185         * source.c (print_source_lines_base): Advance "iter" when a
4186         control character is seen.
4187
4188 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4189
4190         * inferior.h (struct infcall_suspend_state_deleter):
4191         Catch exception in destructor to avoid crash.
4192
4193 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4194
4195         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4196         close to the add_com "shell".
4197
4198 2019-04-18  Tom Tromey  <tromey@adacore.com>
4199
4200         * process-stratum-target.h (class process_stratum_target)
4201         <stratum>: Add "final".
4202
4203 2019-04-17  Tom Tromey  <tromey@adacore.com>
4204
4205         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4206         against nullptr before use.
4207
4208 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4209
4210         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4211
4212 2019-04-17  Jim Wilson  <jimw@sifive.com>
4213             Andrew Burgess  <andrew.burgess@embecosm.com>
4214
4215         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4216         code read might fail, assume 4-byte breakpoint in that case.
4217
4218 2019-04-15  Leszek Swirski  <leszeks@google.com>
4219
4220         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4221         rather than a hand-rolled POD check when checking for forced MEMORY
4222         classification.
4223
4224 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4225
4226         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4227         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4228         function.
4229         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4230         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4231         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4232         declaration.
4233
4234 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4235
4236         * aarch64-linux-nat.c
4237         (aarch64_linux_nat_target::thread_architecture): Add override.
4238         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4239         each VQ.
4240
4241 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4242
4243         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4244
4245 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4246
4247         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4248         target types of size 96-bits, add some additional comments, and
4249         check that the builtin type we found was the correct size.
4250
4251 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4252
4253         * utils.c (prompt_for_continue): Don't restore the styling at the
4254         end, as applied_style has the wrong value.  This fixes styling in
4255         long lists of file names that are interrupted by the "Continue?"
4256         prompt.
4257
4258 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4259
4260         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4261         * c-lang.c (c_language_defn): Likewise.
4262         (cplus_language_defn): Likewise.
4263         (asm_language_defn): Likewise.
4264         (minimal_language_defn): Likewise.
4265         * d-lang.c (d_language_defn): Likewise.
4266         * f-lang.c (f_language_defn): Likewise.
4267         * go-lang.c (go_language_defn): Likewise.
4268         * language.c (unknown_language_defn): Likewise.
4269         (auto_language_defn): Likewise.
4270         * language.h (struct language_defn): Remove la_magic field.
4271         (LANG_MAGIC): Delete.
4272         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4273         * objc-lang.c (objc_language_defn): Likewise.
4274         * opencl-lang.c (opencl_language_defn): Likewise.
4275         * p-lang.c (pascal_language_defn): Likewise.
4276         * rust-lang.c (rust_language_defn): Likewise.
4277
4278 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4279
4280         * riscv-tdep.c (riscv_type_align): New function.
4281         (riscv_type_alignment): Delete.
4282         (riscv_arg_location): Use 'type_align'.
4283         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4284
4285 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4286
4287         * gdbtypes.c (type_align): A struct with no non-static fields also
4288         has alignment of 1.
4289
4290 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4291
4292         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4293         component to 0.
4294         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4295         member.
4296         (riscv_struct_info::analyse): New implementation using new
4297         analyse_inner member function.
4298         (riscv_struct_info::field_offset): New member function.
4299         (riscv_struct_info::m_offsets): New member variable.
4300         (riscv_struct_info::analyse_inner): New private member function,
4301         takes the old implementation of riscv_struct_info::analyse but
4302         extended to track field offsets.
4303         (riscv_call_arg_struct): Update the struct folding special cases
4304         to handle cases where empty C++ structs, which are non-zero
4305         length, are found.
4306         (riscv_arg_location): Initialise the length of each location, a
4307         non-zero length now indicates the location is in use.
4308         (riscv_push_dummy_call): Allow for the first location having a
4309         non-zero offset when setting up arguments.
4310         (riscv_return_value): Likewise, but for return values.
4311
4312 2019-04-11  Tom Tromey  <tromey@adacore.com>
4313
4314         * utils.c (internal_vproblem): Make "msg" const.
4315
4316 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4317
4318         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4319         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4320         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4321         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4322
4323 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4324
4325         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4326         function.
4327         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4328         of amd64_collect_native_gregset.
4329         (amd64_linux_nat_target::store_registers): Likewise.
4330
4331 2019-04-10  Tom Tromey  <tom@tromey.com>
4332
4333         * symtab.c (lookup_global_symbol_from_objfile)
4334         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4335         * objfiles.h (class separate_debug_iterator): New.
4336         (class separate_debug_range): New.
4337         (struct objfile) <separate_debug_objfiles>: New method.
4338         (objfile_separate_debug_iterate): Don't declare.
4339         * objfiles.c (separate_debug_iterator::operator++): Rename from
4340         objfile_separate_debug_iterate.
4341         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4342         iterator.
4343         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4344         iterator.
4345
4346 2019-04-10  Tom Tromey  <tom@tromey.com>
4347
4348         * symfile.c (reread_symbols): Remove old comment.
4349         * objfiles.c (free_all_objfiles): Fix a typo.
4350
4351 2019-04-10  Tom Tromey  <tom@tromey.com>
4352
4353         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4354         * minsyms.c (lookup_minimal_symbol): Use foreach.
4355         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4356         (lookup_minimal_symbol_solib_trampoline): Likewise.
4357         * symfile.c (reread_symbols): Use foreach.
4358
4359 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4360             Tom Tromey  <tromey@adacore.com>
4361
4362         PR rust/24414:
4363         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4364         (rust_lex_int_test): Change "value" to be LONGEST.
4365         (rust_lex_tests): Add test for long integer literal.
4366
4367 2019-04-09  Tom Tromey  <tromey@adacore.com>
4368
4369         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4370         to bool.
4371         (extended_remote_target::attach): Update.
4372         (remote_target::remote_notice_new_inferior): Update.
4373         (remote_target::add_current_inferior_and_thread): Update.
4374         * inferior.c (exit_inferior_1): Use "false".
4375         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4376
4377 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4378
4379         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4380         the "start" command.
4381
4382 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4383
4384         * python/py-inferior.c (infpy_thread_from_thread_handle):
4385         Adjust comments to reflect renaming of thread_from_thread_handle
4386         to thread_from_handle.  Adjust keywords.  Fix type error message.
4387         (inferior_object_methods): Add thread_from_handle.  Retain
4388         thread_from_thread_handle, but mark it as deprecated.
4389
4390 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4391
4392         * gdbthread.h (find_thread_by_handle): Revise declaration.
4393         * thread.c (find_thread_by_handle): Likewise.  Adjust
4394         implementation too.
4395         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4396         support for buffer objects as handles.
4397
4398 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4399
4400         * python/py-infthread.c (thpy_thread_handle): New function.
4401         (thread_object_methods): Register thpy_thread_handle.
4402
4403 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4404
4405         * gdbthread.h (thread_to_thread_handle): Declare.
4406         * thread.c (gdbtypes.h): Include.
4407         (thread_to_thread_handle): New function.
4408
4409         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4410         (target_thread_info_to_thread_handle): Declare.
4411         * target.c (target_thread_info_to_thread_handle): New function.
4412         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4413         * target-delegates.c: Regenerate.
4414
4415         * linux-thread-db.c (class thread_db_target): Add method
4416         thread_info_to_thread_handle.
4417         (thread_db_target::thread_info_to_thread_handle): Define.
4418         * remote.c (class remote_target): Add new method
4419         thread_info_to_thread_handle.
4420         (remote_target::thread_info_to_thread_handle): Define.
4421
4422 2019-04-08  Pedro Alves  <palves@redhat.com>
4423
4424         * common/common-exceptions.c (throw_exception): Don't create
4425         named object to throw; throw directly.
4426         (throw_it): Likewise.  Don't initialize gdb_exception::message
4427         here, with new; pass FMT and AP to the ctor instead.
4428         * common/common-exceptions.h: Include <string>.
4429         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4430         const char *, va_list)): New ctor.  Use std::make_shared.
4431         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4432         errors)): Delete.
4433         (gdb_exception_error::gdb_exception_error(enum errors, const char
4434         *, va_list)): New.
4435         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4436         Add assertion.
4437         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4438         errors)): Delete.
4439         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4440         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4441         Add assertion.
4442
4443 2019-04-08  Tom Tromey  <tom@tromey.com>
4444
4445         * valops.c (value_rtti_indirect_type): Replace throw_exception
4446         with throw.
4447         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4448         with throw.
4449         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4450         throw.
4451         * target.c (target_translate_tls_address): Replace throw_exception
4452         with throw.
4453         * stack.c (frame_apply_command_count): Replace throw_exception
4454         with throw.
4455         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4456         throw.
4457         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4458         with throw.
4459         * rs6000-tdep.c (rs6000_frame_cache)
4460         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4461         * remote.c: Replace throw_exception with throw.
4462         * record-full.c (record_full_message, record_full_wait_1)
4463         (record_full_restore): Replace throw_exception with throw.
4464         * record-btrace.c:
4465         (get_thread_current_frame_id, record_btrace_start_replaying)
4466         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4467         (cmd_record_btrace_start): Replace throw_exception with throw.
4468         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4469         throw.
4470         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4471         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4472         * linespec.c:
4473         (find_linespec_symbols): Replace throw_exception with throw.
4474         * infrun.c (displaced_step_prepare, resume): Replace
4475         throw_exception with throw.
4476         * infcmd.c (post_create_inferior): Replace throw_exception with
4477         throw.
4478         * inf-loop.c (inferior_event_handler): Replace throw_exception
4479         with throw.
4480         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4481         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4482         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4483         (get_prev_frame_always, get_frame_pc_if_available)
4484         (get_frame_address_in_block_if_available, get_frame_language):
4485         Replace throw_exception with throw.
4486         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4487         throw_exception with throw.
4488         * eval.c (fetch_subexp_value, evaluate_var_value)
4489         (evaluate_funcall, evaluate_subexp_standard): Replace
4490         throw_exception with throw.
4491         * dwarf2loc.c (call_site_find_chain)
4492         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4493         Replace throw_exception with throw.
4494         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4495         with throw.
4496         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4497         throw.
4498         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4499         * completer.c (complete_line_internal): Replace throw_exception
4500         with throw.
4501         * compile/compile-object-run.c (compile_object_run): Replace
4502         throw_exception with throw.
4503         * cli/cli-script.c (process_next_line): Replace throw_exception
4504         with throw.
4505         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4506         (btrace_enable, btrace_maint_update_pt_packets): Replace
4507         throw_exception with throw.
4508         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4509         throw_exception with throw.
4510         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4511         throw_exception with throw.
4512         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4513         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4514         * aarch64-tdep.c (aarch64_make_prologue_cache)
4515         (aarch64_make_stub_cache): Replace throw_exception with throw.
4516
4517 2019-04-08  Tom Tromey  <tom@tromey.com>
4518
4519         * common/common-exceptions.c (throw_exception): Rename from
4520         throw_exception_cxx.  Remove old copy.  Make argument const.
4521         (throw_it): Create and throw exception objects directly.
4522         * common/common-exceptions.h (throw_exception): Make argument
4523         const.
4524         (struct gdb_exception_error): Add constructor.
4525         (struct gdb_exception_quit): Add constructor.
4526
4527 2019-04-08  Tom Tromey  <tom@tromey.com>
4528
4529         * common/common-exceptions.h (exception_rethrow): Don't declare.
4530         (TRY_SJLJ): Update comment.
4531         (TRY, CATCH, END_CATCH): Remove.
4532         * common/common-exceptions.c (exception_rethrow): Remove.
4533
4534 2019-04-08  Tom Tromey  <tom@tromey.com>
4535
4536         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4537         Remove.
4538         (gdb_exception_error): Rename from
4539         gdb_exception_RETURN_MASK_ERROR.
4540         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4541         (gdb_quit_bad_alloc): Update.
4542         * aarch64-tdep.c: Update.
4543         * ada-lang.c: Update.
4544         * ada-typeprint.c: Update.
4545         * ada-valprint.c: Update.
4546         * amd64-tdep.c: Update.
4547         * arch-utils.c: Update.
4548         * break-catch-throw.c: Update.
4549         * breakpoint.c: Update.
4550         * btrace.c: Update.
4551         * c-varobj.c: Update.
4552         * cli/cli-cmds.c: Update.
4553         * cli/cli-interp.c: Update.
4554         * cli/cli-script.c: Update.
4555         * common/common-exceptions.c: Update.
4556         * common/new-op.c: Update.
4557         * common/selftest.c: Update.
4558         * compile/compile-c-symbols.c: Update.
4559         * compile/compile-cplus-symbols.c: Update.
4560         * compile/compile-object-load.c: Update.
4561         * compile/compile-object-run.c: Update.
4562         * completer.c: Update.
4563         * corelow.c: Update.
4564         * cp-abi.c: Update.
4565         * cp-support.c: Update.
4566         * cp-valprint.c: Update.
4567         * darwin-nat.c: Update.
4568         * disasm-selftests.c: Update.
4569         * dtrace-probe.c: Update.
4570         * dwarf-index-cache.c: Update.
4571         * dwarf-index-write.c: Update.
4572         * dwarf2-frame-tailcall.c: Update.
4573         * dwarf2-frame.c: Update.
4574         * dwarf2loc.c: Update.
4575         * dwarf2read.c: Update.
4576         * eval.c: Update.
4577         * event-loop.c: Update.
4578         * event-top.c: Update.
4579         * exec.c: Update.
4580         * f-valprint.c: Update.
4581         * fbsd-tdep.c: Update.
4582         * frame-unwind.c: Update.
4583         * frame.c: Update.
4584         * gdbtypes.c: Update.
4585         * gnu-v3-abi.c: Update.
4586         * guile/guile-internal.h: Update.
4587         * guile/scm-block.c: Update.
4588         * guile/scm-breakpoint.c: Update.
4589         * guile/scm-cmd.c: Update.
4590         * guile/scm-disasm.c: Update.
4591         * guile/scm-frame.c: Update.
4592         * guile/scm-lazy-string.c: Update.
4593         * guile/scm-math.c: Update.
4594         * guile/scm-param.c: Update.
4595         * guile/scm-ports.c: Update.
4596         * guile/scm-pretty-print.c: Update.
4597         * guile/scm-symbol.c: Update.
4598         * guile/scm-symtab.c: Update.
4599         * guile/scm-type.c: Update.
4600         * guile/scm-value.c: Update.
4601         * i386-linux-tdep.c: Update.
4602         * i386-tdep.c: Update.
4603         * inf-loop.c: Update.
4604         * infcall.c: Update.
4605         * infcmd.c: Update.
4606         * infrun.c: Update.
4607         * jit.c: Update.
4608         * language.c: Update.
4609         * linespec.c: Update.
4610         * linux-fork.c: Update.
4611         * linux-nat.c: Update.
4612         * linux-tdep.c: Update.
4613         * linux-thread-db.c: Update.
4614         * main.c: Update.
4615         * mi/mi-cmd-break.c: Update.
4616         * mi/mi-cmd-stack.c: Update.
4617         * mi/mi-interp.c: Update.
4618         * mi/mi-main.c: Update.
4619         * objc-lang.c: Update.
4620         * p-valprint.c: Update.
4621         * parse.c: Update.
4622         * ppc-linux-tdep.c: Update.
4623         * printcmd.c: Update.
4624         * python/py-arch.c: Update.
4625         * python/py-breakpoint.c: Update.
4626         * python/py-cmd.c: Update.
4627         * python/py-finishbreakpoint.c: Update.
4628         * python/py-frame.c: Update.
4629         * python/py-framefilter.c: Update.
4630         * python/py-gdb-readline.c: Update.
4631         * python/py-inferior.c: Update.
4632         * python/py-infthread.c: Update.
4633         * python/py-lazy-string.c: Update.
4634         * python/py-linetable.c: Update.
4635         * python/py-objfile.c: Update.
4636         * python/py-param.c: Update.
4637         * python/py-prettyprint.c: Update.
4638         * python/py-progspace.c: Update.
4639         * python/py-record-btrace.c: Update.
4640         * python/py-record.c: Update.
4641         * python/py-symbol.c: Update.
4642         * python/py-type.c: Update.
4643         * python/py-unwind.c: Update.
4644         * python/py-utils.c: Update.
4645         * python/py-value.c: Update.
4646         * python/python.c: Update.
4647         * record-btrace.c: Update.
4648         * record-full.c: Update.
4649         * remote-fileio.c: Update.
4650         * remote.c: Update.
4651         * riscv-tdep.c: Update.
4652         * rs6000-aix-tdep.c: Update.
4653         * rs6000-tdep.c: Update.
4654         * rust-exp.y: Update.
4655         * rust-lang.c: Update.
4656         * s390-tdep.c: Update.
4657         * selftest-arch.c: Update.
4658         * solib-dsbt.c: Update.
4659         * solib-frv.c: Update.
4660         * solib-spu.c: Update.
4661         * solib-svr4.c: Update.
4662         * solib.c: Update.
4663         * sparc64-linux-tdep.c: Update.
4664         * stack.c: Update.
4665         * symfile-mem.c: Update.
4666         * symmisc.c: Update.
4667         * target.c: Update.
4668         * thread.c: Update.
4669         * top.c: Update.
4670         * tracefile-tfile.c: Update.
4671         * tui/tui.c: Update.
4672         * typeprint.c: Update.
4673         * unittests/cli-utils-selftests.c: Update.
4674         * unittests/parse-connection-spec-selftests.c: Update.
4675         * valops.c: Update.
4676         * valprint.c: Update.
4677         * value.c: Update.
4678         * varobj.c: Update.
4679         * windows-nat.c: Update.
4680         * x86-linux-nat.c: Update.
4681         * xml-support.c: Update.
4682
4683 2019-04-08  Tom Tromey  <tom@tromey.com>
4684
4685         * xml-support.c: Use C++ exception handling.
4686         * x86-linux-nat.c: Use C++ exception handling.
4687         * windows-nat.c: Use C++ exception handling.
4688         * varobj.c: Use C++ exception handling.
4689         * value.c: Use C++ exception handling.
4690         * valprint.c: Use C++ exception handling.
4691         * valops.c: Use C++ exception handling.
4692         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4693         handling.
4694         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4695         * typeprint.c: Use C++ exception handling.
4696         * tui/tui.c: Use C++ exception handling.
4697         * tracefile-tfile.c: Use C++ exception handling.
4698         * top.c: Use C++ exception handling.
4699         * thread.c: Use C++ exception handling.
4700         * target.c: Use C++ exception handling.
4701         * symmisc.c: Use C++ exception handling.
4702         * symfile-mem.c: Use C++ exception handling.
4703         * stack.c: Use C++ exception handling.
4704         * sparc64-linux-tdep.c: Use C++ exception handling.
4705         * solib.c: Use C++ exception handling.
4706         * solib-svr4.c: Use C++ exception handling.
4707         * solib-spu.c: Use C++ exception handling.
4708         * solib-frv.c: Use C++ exception handling.
4709         * solib-dsbt.c: Use C++ exception handling.
4710         * selftest-arch.c: Use C++ exception handling.
4711         * s390-tdep.c: Use C++ exception handling.
4712         * rust-lang.c: Use C++ exception handling.
4713         * rust-exp.y: Use C++ exception handling.
4714         * rs6000-tdep.c: Use C++ exception handling.
4715         * rs6000-aix-tdep.c: Use C++ exception handling.
4716         * riscv-tdep.c: Use C++ exception handling.
4717         * remote.c: Use C++ exception handling.
4718         * remote-fileio.c: Use C++ exception handling.
4719         * record-full.c: Use C++ exception handling.
4720         * record-btrace.c: Use C++ exception handling.
4721         * python/python.c: Use C++ exception handling.
4722         * python/py-value.c: Use C++ exception handling.
4723         * python/py-utils.c: Use C++ exception handling.
4724         * python/py-unwind.c: Use C++ exception handling.
4725         * python/py-type.c: Use C++ exception handling.
4726         * python/py-symbol.c: Use C++ exception handling.
4727         * python/py-record.c: Use C++ exception handling.
4728         * python/py-record-btrace.c: Use C++ exception handling.
4729         * python/py-progspace.c: Use C++ exception handling.
4730         * python/py-prettyprint.c: Use C++ exception handling.
4731         * python/py-param.c: Use C++ exception handling.
4732         * python/py-objfile.c: Use C++ exception handling.
4733         * python/py-linetable.c: Use C++ exception handling.
4734         * python/py-lazy-string.c: Use C++ exception handling.
4735         * python/py-infthread.c: Use C++ exception handling.
4736         * python/py-inferior.c: Use C++ exception handling.
4737         * python/py-gdb-readline.c: Use C++ exception handling.
4738         * python/py-framefilter.c: Use C++ exception handling.
4739         * python/py-frame.c: Use C++ exception handling.
4740         * python/py-finishbreakpoint.c: Use C++ exception handling.
4741         * python/py-cmd.c: Use C++ exception handling.
4742         * python/py-breakpoint.c: Use C++ exception handling.
4743         * python/py-arch.c: Use C++ exception handling.
4744         * printcmd.c: Use C++ exception handling.
4745         * ppc-linux-tdep.c: Use C++ exception handling.
4746         * parse.c: Use C++ exception handling.
4747         * p-valprint.c: Use C++ exception handling.
4748         * objc-lang.c: Use C++ exception handling.
4749         * mi/mi-main.c: Use C++ exception handling.
4750         * mi/mi-interp.c: Use C++ exception handling.
4751         * mi/mi-cmd-stack.c: Use C++ exception handling.
4752         * mi/mi-cmd-break.c: Use C++ exception handling.
4753         * main.c: Use C++ exception handling.
4754         * linux-thread-db.c: Use C++ exception handling.
4755         * linux-tdep.c: Use C++ exception handling.
4756         * linux-nat.c: Use C++ exception handling.
4757         * linux-fork.c: Use C++ exception handling.
4758         * linespec.c: Use C++ exception handling.
4759         * language.c: Use C++ exception handling.
4760         * jit.c: Use C++ exception handling.
4761         * infrun.c: Use C++ exception handling.
4762         * infcmd.c: Use C++ exception handling.
4763         * infcall.c: Use C++ exception handling.
4764         * inf-loop.c: Use C++ exception handling.
4765         * i386-tdep.c: Use C++ exception handling.
4766         * i386-linux-tdep.c: Use C++ exception handling.
4767         * guile/scm-value.c: Use C++ exception handling.
4768         * guile/scm-type.c: Use C++ exception handling.
4769         * guile/scm-symtab.c: Use C++ exception handling.
4770         * guile/scm-symbol.c: Use C++ exception handling.
4771         * guile/scm-pretty-print.c: Use C++ exception handling.
4772         * guile/scm-ports.c: Use C++ exception handling.
4773         * guile/scm-param.c: Use C++ exception handling.
4774         * guile/scm-math.c: Use C++ exception handling.
4775         * guile/scm-lazy-string.c: Use C++ exception handling.
4776         * guile/scm-frame.c: Use C++ exception handling.
4777         * guile/scm-disasm.c: Use C++ exception handling.
4778         * guile/scm-cmd.c: Use C++ exception handling.
4779         * guile/scm-breakpoint.c: Use C++ exception handling.
4780         * guile/scm-block.c: Use C++ exception handling.
4781         * guile/guile-internal.h: Use C++ exception handling.
4782         * gnu-v3-abi.c: Use C++ exception handling.
4783         * gdbtypes.c: Use C++ exception handling.
4784         * frame.c: Use C++ exception handling.
4785         * frame-unwind.c: Use C++ exception handling.
4786         * fbsd-tdep.c: Use C++ exception handling.
4787         * f-valprint.c: Use C++ exception handling.
4788         * exec.c: Use C++ exception handling.
4789         * event-top.c: Use C++ exception handling.
4790         * event-loop.c: Use C++ exception handling.
4791         * eval.c: Use C++ exception handling.
4792         * dwarf2read.c: Use C++ exception handling.
4793         * dwarf2loc.c: Use C++ exception handling.
4794         * dwarf2-frame.c: Use C++ exception handling.
4795         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4796         * dwarf-index-write.c: Use C++ exception handling.
4797         * dwarf-index-cache.c: Use C++ exception handling.
4798         * dtrace-probe.c: Use C++ exception handling.
4799         * disasm-selftests.c: Use C++ exception handling.
4800         * darwin-nat.c: Use C++ exception handling.
4801         * cp-valprint.c: Use C++ exception handling.
4802         * cp-support.c: Use C++ exception handling.
4803         * cp-abi.c: Use C++ exception handling.
4804         * corelow.c: Use C++ exception handling.
4805         * completer.c: Use C++ exception handling.
4806         * compile/compile-object-run.c: Use C++ exception handling.
4807         * compile/compile-object-load.c: Use C++ exception handling.
4808         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4809         * compile/compile-c-symbols.c: Use C++ exception handling.
4810         * common/selftest.c: Use C++ exception handling.
4811         * common/new-op.c: Use C++ exception handling.
4812         * cli/cli-script.c: Use C++ exception handling.
4813         * cli/cli-interp.c: Use C++ exception handling.
4814         * cli/cli-cmds.c: Use C++ exception handling.
4815         * c-varobj.c: Use C++ exception handling.
4816         * btrace.c: Use C++ exception handling.
4817         * breakpoint.c: Use C++ exception handling.
4818         * break-catch-throw.c: Use C++ exception handling.
4819         * arch-utils.c: Use C++ exception handling.
4820         * amd64-tdep.c: Use C++ exception handling.
4821         * ada-valprint.c: Use C++ exception handling.
4822         * ada-typeprint.c: Use C++ exception handling.
4823         * ada-lang.c: Use C++ exception handling.
4824         * aarch64-tdep.c: Use C++ exception handling.
4825
4826 2019-04-08  Tom Tromey  <tom@tromey.com>
4827
4828         * xml-support.c (gdb_xml_parser::parse): Update.
4829         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4830         * value.c (show_convenience): Update.
4831         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4832         (test_parse_flags_qcs): Update.
4833         * thread.c (thr_try_catch_cmd): Update.
4834         * target.c (target_translate_tls_address): Update.
4835         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4836         (info_frame_command_core, frame_apply_command_count): Update.
4837         * rust-exp.y (rust_lex_exception_test): Update.
4838         * riscv-tdep.c (riscv_print_one_register_info): Update.
4839         * remote.c (remote_target::enable_btrace): Update.
4840         * record-btrace.c (record_btrace_enable_warn): Update.
4841         * python/py-utils.c (gdbpy_convert_exception): Update.
4842         * printcmd.c (do_one_display, print_variable_and_value): Update.
4843         * mi/mi-main.c (mi_print_exception): Update.
4844         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4845         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4846         * linux-nat.c (linux_nat_target::attach): Update.
4847         * linux-fork.c (class scoped_switch_fork_info): Update.
4848         * infrun.c (displaced_step_prepare): Update.
4849         * infcall.c (call_function_by_hand_dummy): Update.
4850         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4851         * gnu-v3-abi.c (print_one_vtable): Update.
4852         * frame.c (get_prev_frame_always): Update.
4853         * f-valprint.c (info_common_command_for_block): Update.
4854         * exec.c (try_open_exec_file): Update.
4855         * exceptions.c (print_exception, exception_print)
4856         (exception_fprintf, exception_print_same): Update.
4857         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4858         * dwarf-index-cache.c (index_cache::store)
4859         (index_cache::lookup_gdb_index): Update.
4860         * darwin-nat.c (maybe_cache_shell): Update.
4861         * cp-valprint.c (cp_print_value_fields): Update.
4862         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4863         (gcc_cplus_symbol_address): Update.
4864         * compile/compile-c-symbols.c (gcc_convert_symbol)
4865         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4866         * common/selftest.c: Update.
4867         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4868         a std::string.
4869         (exception_try_scope_entry, exception_try_scope_exit): Don't
4870         declare.
4871         (struct exception_try_scope): Remove.
4872         (TRY): Don't use exception_try_scope.
4873         (struct gdb_exception): Add constructor, operator=.
4874         <what>: New method.
4875         (struct gdb_exception_RETURN_MASK_ALL)
4876         (struct gdb_exception_RETURN_MASK_ERROR)
4877         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4878         (struct gdb_quit_bad_alloc): Update.
4879         * common/common-exceptions.c (exception_none): Change
4880         initializer.
4881         (struct catcher) <state, exception>: Initialize inline.
4882         <prev>: Remove member.
4883         (current_catcher): Remove.
4884         (catchers): New global.
4885         (exceptions_state_mc_init): Simplify.
4886         (catcher_pop): Remove.
4887         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4888         (try_scope_depth, exception_try_scope_entry)
4889         (exception_try_scope_exit): Remove.
4890         (throw_exception_sjlj): Update.
4891         (exception_messages, exception_messages_size): Remove.
4892         (throw_it): Simplify.
4893         (gdb_exception_sliced_copy): Remove.
4894         (throw_exception_cxx): Update.
4895         * cli/cli-script.c (script_from_file): Update.
4896         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4897         Update.
4898         * ada-valprint.c (ada_val_print): Update.
4899         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4900         (create_excep_cond_exprs): Update.
4901
4902 2019-04-08  Tom Tromey  <tom@tromey.com>
4903
4904         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4905         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4906         (TRY, CATCH, END_CATCH): Remove some definitions.
4907         * common/common-exceptions.c: Don't use GDB_XCPT.
4908         (catcher_list_size): Remove.
4909         (throw_exception, throw_it): Simplify.
4910
4911 2019-04-05  Tom Tromey  <tom@tromey.com>
4912
4913         Revert the header-sorting patch.
4914         * ft32-tdep.c: Revert.
4915         * frv-tdep.c: Revert.
4916         * frv-linux-tdep.c: Revert.
4917         * frame.c: Revert.
4918         * frame-unwind.c: Revert.
4919         * frame-base.c: Revert.
4920         * fork-child.c: Revert.
4921         * findvar.c: Revert.
4922         * findcmd.c: Revert.
4923         * filesystem.c: Revert.
4924         * filename-seen-cache.h: Revert.
4925         * filename-seen-cache.c: Revert.
4926         * fbsd-tdep.c: Revert.
4927         * fbsd-nat.h: Revert.
4928         * fbsd-nat.c: Revert.
4929         * f-valprint.c: Revert.
4930         * f-typeprint.c: Revert.
4931         * f-lang.c: Revert.
4932         * extension.h: Revert.
4933         * extension.c: Revert.
4934         * extension-priv.h: Revert.
4935         * expprint.c: Revert.
4936         * exec.h: Revert.
4937         * exec.c: Revert.
4938         * exceptions.c: Revert.
4939         * event-top.c: Revert.
4940         * event-loop.c: Revert.
4941         * eval.c: Revert.
4942         * elfread.c: Revert.
4943         * dwarf2read.h: Revert.
4944         * dwarf2read.c: Revert.
4945         * dwarf2loc.c: Revert.
4946         * dwarf2expr.h: Revert.
4947         * dwarf2expr.c: Revert.
4948         * dwarf2-frame.c: Revert.
4949         * dwarf2-frame-tailcall.c: Revert.
4950         * dwarf-index-write.h: Revert.
4951         * dwarf-index-write.c: Revert.
4952         * dwarf-index-common.c: Revert.
4953         * dwarf-index-cache.h: Revert.
4954         * dwarf-index-cache.c: Revert.
4955         * dummy-frame.c: Revert.
4956         * dtrace-probe.c: Revert.
4957         * disasm.h: Revert.
4958         * disasm.c: Revert.
4959         * disasm-selftests.c: Revert.
4960         * dictionary.c: Revert.
4961         * dicos-tdep.c: Revert.
4962         * demangle.c: Revert.
4963         * dcache.h: Revert.
4964         * dcache.c: Revert.
4965         * darwin-nat.h: Revert.
4966         * darwin-nat.c: Revert.
4967         * darwin-nat-info.c: Revert.
4968         * d-valprint.c: Revert.
4969         * d-namespace.c: Revert.
4970         * d-lang.c: Revert.
4971         * ctf.c: Revert.
4972         * csky-tdep.c: Revert.
4973         * csky-linux-tdep.c: Revert.
4974         * cris-tdep.c: Revert.
4975         * cris-linux-tdep.c: Revert.
4976         * cp-valprint.c: Revert.
4977         * cp-support.c: Revert.
4978         * cp-namespace.c: Revert.
4979         * cp-abi.c: Revert.
4980         * corelow.c: Revert.
4981         * corefile.c: Revert.
4982         * continuations.c: Revert.
4983         * completer.h: Revert.
4984         * completer.c: Revert.
4985         * complaints.c: Revert.
4986         * coffread.c: Revert.
4987         * coff-pe-read.c: Revert.
4988         * cli-out.h: Revert.
4989         * cli-out.c: Revert.
4990         * charset.c: Revert.
4991         * c-varobj.c: Revert.
4992         * c-valprint.c: Revert.
4993         * c-typeprint.c: Revert.
4994         * c-lang.c: Revert.
4995         * buildsym.c: Revert.
4996         * buildsym-legacy.c: Revert.
4997         * build-id.h: Revert.
4998         * build-id.c: Revert.
4999         * btrace.c: Revert.
5000         * bsd-uthread.c: Revert.
5001         * breakpoint.h: Revert.
5002         * breakpoint.c: Revert.
5003         * break-catch-throw.c: Revert.
5004         * break-catch-syscall.c: Revert.
5005         * break-catch-sig.c: Revert.
5006         * blockframe.c: Revert.
5007         * block.c: Revert.
5008         * bfin-tdep.c: Revert.
5009         * bfin-linux-tdep.c: Revert.
5010         * bfd-target.c: Revert.
5011         * bcache.c: Revert.
5012         * ax-general.c: Revert.
5013         * ax-gdb.h: Revert.
5014         * ax-gdb.c: Revert.
5015         * avr-tdep.c: Revert.
5016         * auxv.c: Revert.
5017         * auto-load.c: Revert.
5018         * arm-wince-tdep.c: Revert.
5019         * arm-tdep.c: Revert.
5020         * arm-symbian-tdep.c: Revert.
5021         * arm-pikeos-tdep.c: Revert.
5022         * arm-obsd-tdep.c: Revert.
5023         * arm-nbsd-tdep.c: Revert.
5024         * arm-nbsd-nat.c: Revert.
5025         * arm-linux-tdep.c: Revert.
5026         * arm-linux-nat.c: Revert.
5027         * arm-fbsd-tdep.c: Revert.
5028         * arm-fbsd-nat.c: Revert.
5029         * arm-bsd-tdep.c: Revert.
5030         * arch-utils.c: Revert.
5031         * arc-tdep.c: Revert.
5032         * arc-newlib-tdep.c: Revert.
5033         * annotate.h: Revert.
5034         * annotate.c: Revert.
5035         * amd64-windows-tdep.c: Revert.
5036         * amd64-windows-nat.c: Revert.
5037         * amd64-tdep.c: Revert.
5038         * amd64-sol2-tdep.c: Revert.
5039         * amd64-obsd-tdep.c: Revert.
5040         * amd64-obsd-nat.c: Revert.
5041         * amd64-nbsd-tdep.c: Revert.
5042         * amd64-nbsd-nat.c: Revert.
5043         * amd64-nat.c: Revert.
5044         * amd64-linux-tdep.c: Revert.
5045         * amd64-linux-nat.c: Revert.
5046         * amd64-fbsd-tdep.c: Revert.
5047         * amd64-fbsd-nat.c: Revert.
5048         * amd64-dicos-tdep.c: Revert.
5049         * amd64-darwin-tdep.c: Revert.
5050         * amd64-bsd-nat.c: Revert.
5051         * alpha-tdep.c: Revert.
5052         * alpha-obsd-tdep.c: Revert.
5053         * alpha-nbsd-tdep.c: Revert.
5054         * alpha-mdebug-tdep.c: Revert.
5055         * alpha-linux-tdep.c: Revert.
5056         * alpha-linux-nat.c: Revert.
5057         * alpha-bsd-tdep.c: Revert.
5058         * alpha-bsd-nat.c: Revert.
5059         * aix-thread.c: Revert.
5060         * agent.c: Revert.
5061         * addrmap.c: Revert.
5062         * ada-varobj.c: Revert.
5063         * ada-valprint.c: Revert.
5064         * ada-typeprint.c: Revert.
5065         * ada-tasks.c: Revert.
5066         * ada-lang.c: Revert.
5067         * aarch64-tdep.c: Revert.
5068         * aarch64-ravenscar-thread.c: Revert.
5069         * aarch64-newlib-tdep.c: Revert.
5070         * aarch64-linux-tdep.c: Revert.
5071         * aarch64-linux-nat.c: Revert.
5072         * aarch64-fbsd-tdep.c: Revert.
5073         * aarch64-fbsd-nat.c: Revert.
5074         * aarch32-linux-nat.c: Revert.
5075
5076 2019-04-05  Tom Tromey  <tom@tromey.com>
5077
5078         * ft32-tdep.c: Sort headers.
5079         * frv-tdep.c: Sort headers.
5080         * frv-linux-tdep.c: Sort headers.
5081         * frame.c: Sort headers.
5082         * frame-unwind.c: Sort headers.
5083         * frame-base.c: Sort headers.
5084         * fork-child.c: Sort headers.
5085         * findvar.c: Sort headers.
5086         * findcmd.c: Sort headers.
5087         * filesystem.c: Sort headers.
5088         * filename-seen-cache.h: Sort headers.
5089         * filename-seen-cache.c: Sort headers.
5090         * fbsd-tdep.c: Sort headers.
5091         * fbsd-nat.h: Sort headers.
5092         * fbsd-nat.c: Sort headers.
5093         * f-valprint.c: Sort headers.
5094         * f-typeprint.c: Sort headers.
5095         * f-lang.c: Sort headers.
5096         * extension.h: Sort headers.
5097         * extension.c: Sort headers.
5098         * extension-priv.h: Sort headers.
5099         * expprint.c: Sort headers.
5100         * exec.h: Sort headers.
5101         * exec.c: Sort headers.
5102         * exceptions.c: Sort headers.
5103         * event-top.c: Sort headers.
5104         * event-loop.c: Sort headers.
5105         * eval.c: Sort headers.
5106         * elfread.c: Sort headers.
5107         * dwarf2read.h: Sort headers.
5108         * dwarf2read.c: Sort headers.
5109         * dwarf2loc.c: Sort headers.
5110         * dwarf2expr.h: Sort headers.
5111         * dwarf2expr.c: Sort headers.
5112         * dwarf2-frame.c: Sort headers.
5113         * dwarf2-frame-tailcall.c: Sort headers.
5114         * dwarf-index-write.h: Sort headers.
5115         * dwarf-index-write.c: Sort headers.
5116         * dwarf-index-common.c: Sort headers.
5117         * dwarf-index-cache.h: Sort headers.
5118         * dwarf-index-cache.c: Sort headers.
5119         * dummy-frame.c: Sort headers.
5120         * dtrace-probe.c: Sort headers.
5121         * disasm.h: Sort headers.
5122         * disasm.c: Sort headers.
5123         * disasm-selftests.c: Sort headers.
5124         * dictionary.c: Sort headers.
5125         * dicos-tdep.c: Sort headers.
5126         * demangle.c: Sort headers.
5127         * dcache.h: Sort headers.
5128         * dcache.c: Sort headers.
5129         * darwin-nat.h: Sort headers.
5130         * darwin-nat.c: Sort headers.
5131         * darwin-nat-info.c: Sort headers.
5132         * d-valprint.c: Sort headers.
5133         * d-namespace.c: Sort headers.
5134         * d-lang.c: Sort headers.
5135         * ctf.c: Sort headers.
5136         * csky-tdep.c: Sort headers.
5137         * csky-linux-tdep.c: Sort headers.
5138         * cris-tdep.c: Sort headers.
5139         * cris-linux-tdep.c: Sort headers.
5140         * cp-valprint.c: Sort headers.
5141         * cp-support.c: Sort headers.
5142         * cp-namespace.c: Sort headers.
5143         * cp-abi.c: Sort headers.
5144         * corelow.c: Sort headers.
5145         * corefile.c: Sort headers.
5146         * continuations.c: Sort headers.
5147         * completer.h: Sort headers.
5148         * completer.c: Sort headers.
5149         * complaints.c: Sort headers.
5150         * coffread.c: Sort headers.
5151         * coff-pe-read.c: Sort headers.
5152         * cli-out.h: Sort headers.
5153         * cli-out.c: Sort headers.
5154         * charset.c: Sort headers.
5155         * c-varobj.c: Sort headers.
5156         * c-valprint.c: Sort headers.
5157         * c-typeprint.c: Sort headers.
5158         * c-lang.c: Sort headers.
5159         * buildsym.c: Sort headers.
5160         * buildsym-legacy.c: Sort headers.
5161         * build-id.h: Sort headers.
5162         * build-id.c: Sort headers.
5163         * btrace.c: Sort headers.
5164         * bsd-uthread.c: Sort headers.
5165         * breakpoint.h: Sort headers.
5166         * breakpoint.c: Sort headers.
5167         * break-catch-throw.c: Sort headers.
5168         * break-catch-syscall.c: Sort headers.
5169         * break-catch-sig.c: Sort headers.
5170         * blockframe.c: Sort headers.
5171         * block.c: Sort headers.
5172         * bfin-tdep.c: Sort headers.
5173         * bfin-linux-tdep.c: Sort headers.
5174         * bfd-target.c: Sort headers.
5175         * bcache.c: Sort headers.
5176         * ax-general.c: Sort headers.
5177         * ax-gdb.h: Sort headers.
5178         * ax-gdb.c: Sort headers.
5179         * avr-tdep.c: Sort headers.
5180         * auxv.c: Sort headers.
5181         * auto-load.c: Sort headers.
5182         * arm-wince-tdep.c: Sort headers.
5183         * arm-tdep.c: Sort headers.
5184         * arm-symbian-tdep.c: Sort headers.
5185         * arm-pikeos-tdep.c: Sort headers.
5186         * arm-obsd-tdep.c: Sort headers.
5187         * arm-nbsd-tdep.c: Sort headers.
5188         * arm-nbsd-nat.c: Sort headers.
5189         * arm-linux-tdep.c: Sort headers.
5190         * arm-linux-nat.c: Sort headers.
5191         * arm-fbsd-tdep.c: Sort headers.
5192         * arm-fbsd-nat.c: Sort headers.
5193         * arm-bsd-tdep.c: Sort headers.
5194         * arch-utils.c: Sort headers.
5195         * arc-tdep.c: Sort headers.
5196         * arc-newlib-tdep.c: Sort headers.
5197         * annotate.h: Sort headers.
5198         * annotate.c: Sort headers.
5199         * amd64-windows-tdep.c: Sort headers.
5200         * amd64-windows-nat.c: Sort headers.
5201         * amd64-tdep.c: Sort headers.
5202         * amd64-sol2-tdep.c: Sort headers.
5203         * amd64-obsd-tdep.c: Sort headers.
5204         * amd64-obsd-nat.c: Sort headers.
5205         * amd64-nbsd-tdep.c: Sort headers.
5206         * amd64-nbsd-nat.c: Sort headers.
5207         * amd64-nat.c: Sort headers.
5208         * amd64-linux-tdep.c: Sort headers.
5209         * amd64-linux-nat.c: Sort headers.
5210         * amd64-fbsd-tdep.c: Sort headers.
5211         * amd64-fbsd-nat.c: Sort headers.
5212         * amd64-dicos-tdep.c: Sort headers.
5213         * amd64-darwin-tdep.c: Sort headers.
5214         * amd64-bsd-nat.c: Sort headers.
5215         * alpha-tdep.c: Sort headers.
5216         * alpha-obsd-tdep.c: Sort headers.
5217         * alpha-nbsd-tdep.c: Sort headers.
5218         * alpha-mdebug-tdep.c: Sort headers.
5219         * alpha-linux-tdep.c: Sort headers.
5220         * alpha-linux-nat.c: Sort headers.
5221         * alpha-bsd-tdep.c: Sort headers.
5222         * alpha-bsd-nat.c: Sort headers.
5223         * aix-thread.c: Sort headers.
5224         * agent.c: Sort headers.
5225         * addrmap.c: Sort headers.
5226         * ada-varobj.c: Sort headers.
5227         * ada-valprint.c: Sort headers.
5228         * ada-typeprint.c: Sort headers.
5229         * ada-tasks.c: Sort headers.
5230         * ada-lang.c: Sort headers.
5231         * aarch64-tdep.c: Sort headers.
5232         * aarch64-ravenscar-thread.c: Sort headers.
5233         * aarch64-newlib-tdep.c: Sort headers.
5234         * aarch64-linux-tdep.c: Sort headers.
5235         * aarch64-linux-nat.c: Sort headers.
5236         * aarch64-fbsd-tdep.c: Sort headers.
5237         * aarch64-fbsd-nat.c: Sort headers.
5238         * aarch32-linux-nat.c: Sort headers.
5239
5240 2019-04-04  Tom Tromey  <tom@tromey.com>
5241
5242         * varobj.c (varobj_create): Update.
5243         * rust-exp.y (struct rust_parser) <update_innermost_block,
5244         lookup_symbol>: New methods.
5245         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5246         Rename.
5247         (rust_parser::rust_lookup_type)
5248         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5249         * printcmd.c (display_command, do_one_display): Update.
5250         * parser-defs.h (struct parser_state) <parser_state>: Add
5251         "tracker" parameter.
5252         (block_tracker): New member.
5253         (class innermost_block_tracker) <innermost_block_tracker>: Add
5254         "types" parameter.
5255         <reset>: Remove method.
5256         (innermost_block): Don't declare.
5257         (null_post_parser): Update.
5258         * parse.c (innermost_block): Remove global.
5259         (write_dollar_variable): Update.
5260         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5261         Remove "tracker_types" parameter.
5262         (parse_expression): Add "tracker" parameter.
5263         (parse_expression_for_completion): Update.
5264         (null_post_parser): Add "tracker" parameter.
5265         * p-exp.y: Update rules.
5266         * m2-exp.y: Update rules.
5267         * language.h (struct language_defn) <la_post_parser>: Add
5268         "tracker" parameter.
5269         * go-exp.y: Update rules.
5270         * f-exp.y: Update rules.
5271         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5272         parameter.
5273         * d-exp.y: Update rules.
5274         * c-exp.y: Update rules.
5275         * breakpoint.c (set_breakpoint_condition): Create an
5276         innermost_block_tracker.
5277         (watch_command_1): Likewise.
5278         * ada-lang.c (resolve): Add "tracker" parameter.
5279         (resolve_subexp): Likewise.
5280         * ada-exp.y (write_var_from_sym): Update.
5281
5282 2019-04-04  Tom Tromey  <tom@tromey.com>
5283
5284         * type-stack.h: New file.
5285         * type-stack.c: New file.
5286         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5287         type-stack.h.
5288         (insert_into_type_stack, insert_type, push_type, push_type_int)
5289         (insert_type_address_space, pop_type, pop_type_int)
5290         (pop_typelist, pop_type_stack, append_type_stack)
5291         (push_type_stack, get_type_stack, push_typelist)
5292         (follow_type_instance_flags, follow_types): Don't declare.
5293         * parse.c (type_stack): Remove global.
5294         (parse_exp_in_context): Update.
5295         (insert_into_type_stack, insert_type, push_type, push_type_int)
5296         (insert_type_address_space, pop_type, pop_type_int)
5297         (pop_typelist, pop_type_stack, append_type_stack)
5298         (push_type_stack, get_type_stack, push_typelist)
5299         (follow_type_instance_flags, follow_types): Remove (moved to
5300         type-stack.c).
5301         * f-exp.y (type_stack): New global.
5302         Update rules.
5303         (push_kind_type, f_parse): Update.
5304         * d-exp.y (type_stack): New global.
5305         Update rules.
5306         (d_parse): Update.
5307         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5308         Update rules.
5309         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5310         (HFILES_NO_SRCDIR): Add type-stack.h.
5311
5312 2019-04-04  Tom Tromey  <tom@tromey.com>
5313
5314         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5315         (rust_parser::convert_ast_to_expression, rust_parse)
5316         (rust_lex_test_completion, rust_lex_tests): Update.
5317         * parser-defs.h (struct expr_completion_state): New.
5318         (struct parser_state) <parser_state>: Add completion parameter.
5319         <mark_struct_expression, mark_completion_tag>: New methods.
5320         <parse_completion, m_completion_state>: New members.
5321         (prefixify_expression, null_post_parser): Update.
5322         (mark_struct_expression, mark_completion_tag): Don't declare.
5323         * parse.c (parse_completion, expout_last_struct)
5324         (expout_tag_completion_type, expout_completion_name): Remove
5325         globals.
5326         (parser_state::mark_struct_expression)
5327         (parser_state::mark_completion_tag): Now methods.
5328         (prefixify_expression): Add last_struct parameter.
5329         (prefixify_subexp): Likewise.
5330         (parse_exp_1): Update.
5331         (parse_exp_in_context): Add cstate parameter.  Update.
5332         (parse_expression_for_completion): Create an
5333         expr_completion_state.
5334         (null_post_parser): Add "completion" parameter.
5335         * p-exp.y: Update rules.
5336         (yylex): Update.
5337         * language.h (struct language_defn) <la_post_parser>: Add
5338         "completing" parameter.
5339         * go-exp.y: Update rules.
5340         (lex_one_token): Update.
5341         * expression.h (parse_completion): Don't declare.
5342         * d-exp.y: Update rules.
5343         (lex_one_token): Update rules.
5344         * c-exp.y: Update rules.
5345         (lex_one_token): Update.
5346         * ada-lang.c (resolve): Add "parse_completion" parameter.
5347         (resolve_subexp): Likewise.
5348         (ada_resolve_function): Likewise.
5349
5350 2019-04-04  Tom Tromey  <tom@tromey.com>
5351
5352         * parser-defs.h (struct parser_state) <start_arglist,
5353         end_arglist>: New methods.
5354         <arglist_len, m_funcall_chain>: New members.
5355         (arglist_len, start_arglist, end_arglist): Don't declare.
5356         * parse.c (arglist_len, funcall_chain): Remove global.
5357         (start_arglist, end_arglist): Remove functions.
5358         (parse_exp_in_context): Update.
5359         * p-exp.y: Update rules.
5360         * m2-exp.y: Update rules.
5361         * go-exp.y: Update rules.
5362         * f-exp.y: Update rules.
5363         * d-exp.y: Update rules.
5364         * c-exp.y: Update rules.
5365
5366 2019-04-04  Tom Tromey  <tom@tromey.com>
5367
5368         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5369         lex_operator, push_back>: New methods.
5370         Update all rules.
5371         (rust_parser::lex_hex, lex_escape): Rename and update.
5372         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5373         (rust_parser::lex_operator): Rename and update.
5374         (rust_parser::lex_number, rustyylex, rustyyerror)
5375         (rust_lex_test_init, rust_lex_test_sequence)
5376         (rust_lex_test_push_back, rust_lex_tests): Update.
5377         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5378         parameter.
5379         <lexptr, prev_lexptr>: New members.
5380         (lexptr, prev_lexptr): Don't declare.
5381         * parse.c (lexptr, prev_lexptr): Remove globals.
5382         (parse_exp_in_context): Update.
5383         * p-exp.y (yylex, yyerror): Update.
5384         * m2-exp.y (parse_number, yylex, yyerror): Update.
5385         * go-exp.y (lex_one_token, yyerror): Update.
5386         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5387         * d-exp.y (lex_one_token, yyerror): Update.
5388         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5389         (lex_one_token, yyerror): Update.
5390         * ada-lex.l (YY_INPUT): Update.
5391         (rewind_to_char): Update.
5392         * ada-exp.y (yyerror): Update.
5393
5394 2019-04-04  Tom Tromey  <tom@tromey.com>
5395
5396         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5397         * parser-defs.h (struct parser_state) <parser_state>: Add new
5398         parameter.
5399         <comma_terminates>: New member.
5400         (comma_terminates): Don't declare global.
5401         * parse.c (comma_terminates): Remove global.
5402         (parse_exp_in_context): Update.
5403         * p-exp.y (yylex): Update.
5404         * m2-exp.y (yylex): Update.
5405         * go-exp.y (lex_one_token): Update.
5406         * f-exp.y (yylex): Update.
5407         * d-exp.y (lex_one_token): Update.
5408         * c-exp.y (lex_one_token): Update.
5409         * ada-lex.l: Update.
5410
5411 2019-04-04  Tom Tromey  <tom@tromey.com>
5412
5413         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5414         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5415         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5416         * parser-defs.h (paren_depth): Don't declare.
5417         * parse.c (paren_depth): Remove global.
5418         (parse_exp_in_context): Update.
5419         * p-exp.y (paren_depth): New global.
5420         (pascal_parse): Initialize it.
5421         * m2-exp.y (paren_depth): New global.
5422         (m2_parse): Initialize it.
5423         * go-exp.y (paren_depth): New global.
5424         (go_parse): Initialize it.
5425         * f-exp.y (paren_depth): New global.
5426         (f_parse): Initialize it.
5427         * d-exp.y (paren_depth): New global.
5428         (d_parse): Initialize it.
5429         * c-exp.y (paren_depth): New global.
5430         (c_parse): Initialize it.
5431         * ada-lex.l (paren_depth): New global.
5432         (lexer_init): Initialize it.
5433
5434 2019-04-04  Tom Tromey  <tom@tromey.com>
5435
5436         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5437         (rust_parser::convert_ast_to_type)
5438         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5439         * parser-defs.h (struct parser_state) <parser_state>: Add
5440         parameters.  Initialize new members.
5441         <expression_context_block, expression_context_pc>: New members.
5442         * parse.c (expression_context_block, expression_context_pc):
5443         Remove globals.
5444         (parse_exp_in_context): Update.
5445         * p-exp.y: Update all rules.
5446         (yylex): Update.
5447         * m2-exp.y: Update all rules.
5448         (yylex): Update.
5449         * go-exp.y (yylex): Update.
5450         * f-exp.y (yylex): Update.
5451         * d-exp.y: Update all rules.
5452         (yylex): Update.
5453         * c-exp.y: Update all rules.
5454         (lex_one_token, classify_name, yylex, c_parse): Update.
5455         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5456
5457 2019-04-04  Tom Tromey  <tom@tromey.com>
5458
5459         * gdbarch.h, gdbarch.c: Rebuild.
5460         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5461         * stap-probe.h:
5462         (struct stap_parse_info): Replace "parser_state" with
5463         "expr_builder".
5464         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5465         (parser_state): New class.
5466         * parse.c (expr_builder): Rename.
5467         (expr_builder::release): Rename.
5468         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5469         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5470         (write_exp_elt_longcst, write_exp_elt_floatcst)
5471         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5472         (write_exp_string_vector, write_exp_bitstring)
5473         (write_exp_msymbol, mark_struct_expression)
5474         (write_dollar_variable)
5475         (insert_type_address_space, increase_expout_size): Replace
5476         "parser_state" with "expr_builder".
5477         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5478         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5479         "parser_state" with "expr_builder".
5480
5481 2019-04-04  Tom Tromey  <tom@tromey.com>
5482
5483         * rust-exp.y: Replace "parse_language" with method call.
5484         * p-exp.y:
5485         (yylex): Replace "parse_language" with method call.
5486         * m2-exp.y:
5487         (yylex): Replace "parse_language" with method call.
5488         * go-exp.y (classify_name): Replace "parse_language" with method
5489         call.
5490         * f-exp.y (yylex): Replace "parse_language" with method call.
5491         * d-exp.y (lex_one_token): Replace "parse_language" with method
5492         call.
5493         * c-exp.y:
5494         (lex_one_token, classify_name, yylex): Replace "parse_language"
5495         with method call.
5496         * ada-exp.y (find_primitive_type, type_char)
5497         (type_system_address): Replace "parse_language" with method call.
5498
5499 2019-04-04  Tom Tromey  <tom@tromey.com>
5500
5501         * rust-exp.y: Replace "parse_gdbarch" with method call.
5502         * parse.c (write_dollar_variable, insert_type_address_space):
5503         Replace "parse_gdbarch" with method call.
5504         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5505         call.
5506         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5507         call.
5508         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5509         "parse_gdbarch" with method call.
5510         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5511         with method call.
5512         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5513         "parse_gdbarch" with method call.
5514         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5515         "parse_gdbarch" with method call.
5516         * c-exp.y (parse_type, parse_number, classify_name): Replace
5517         "parse_gdbarch" with method call.
5518         * ada-lex.l: Replace "parse_gdbarch" with method call.
5519         * ada-exp.y (parse_type, find_primitive_type, type_char)
5520         (type_system_address): Replace "parse_gdbarch" with method call.
5521
5522 2019-04-04  Tom Tromey  <tom@tromey.com>
5523
5524         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5525         * stap-probe.c (stap_parse_argument): Update.
5526         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5527         initial_size parameter.
5528         * rust-exp.y (rust_lex_tests): Update.
5529         * parse.c (parser_state): Update.
5530         (parse_exp_in_context): Update.
5531         * parser-defs.h (struct parser_state) <parser_state>: Remove
5532         "initial_size" parameter.
5533
5534 2019-04-04  Tom Tromey  <tom@tromey.com>
5535
5536         * parser-defs.h (increase_expout_size): Don't declare.
5537         * parse.c (increase_expout_size): Now static.
5538
5539 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5540
5541         * gnu-nat.c (gnu_nat_target::wait): Fix
5542         target_waitstatus_to_string call.
5543
5544 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5545
5546         * eval.c (evaluate_subexp_standard): Handle internal functions
5547         during Fortran function call handling.
5548
5549 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5550
5551         * NEWS: Mention new internal functions.
5552         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5553         (read_base_type): Use dwarf2_init_complex_target_type.
5554         * value.c (creal_internal_fn): New function.
5555         (cimag_internal_fn): New function.
5556         (_initialize_values): Register new internal functions.
5557
5558 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5559
5560         * infrun.c (stop_all_threads): If debug_infrun, always
5561         trace the wait status after wait_one, using
5562         target_waitstatus_to_string and target_pid_to_str.
5563         (handle_inferior_event): Replace various trace of
5564         wait status kind by a single trace.
5565         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5566         wait status kind image by target_waitstatus_to_string.
5567         * target/waitstatus.c (target_waitstatus_to_string): Fix
5568         obsolete comment.
5569
5570 2019-04-01  Tom Tromey  <tromey@adacore.com>
5571
5572         PR symtab/23331:
5573         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5574
5575 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5576             Pedro Alves  <palves@redhat.com>
5577
5578         * top.c (quit_force): Call 'finalize_values'.
5579         * value.c (finalize_values): New function.
5580         * value.h (finalize_values): Declare.
5581
5582 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5583
5584         * NEWS: Announce $_gdb_major and $_gdb_minor.
5585
5586         * top.c (init_gdb_version_vars): New function.
5587         (gdb_init): Call init_gdb_version_vars.
5588
5589 2019-03-29  Tom Tromey  <tromey@adacore.com>
5590
5591         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5592         help text.  Remove dead code.
5593
5594 2019-03-29  Keith Seitz  <keiths@redhat.com>
5595
5596         From Siddhesh Poyarekar:
5597         * f-lang.h (f77_get_upperbound): Return LONGEST.
5598         (f77_get_lowerbound): Likewise.
5599         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5600         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5601         print them.
5602         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5603         plongest to format print it.
5604         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5605         (f77_get_upperbound): Likewise.
5606         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5607         LOWER_BOUND to LONGEST.
5608         (f77_create_arrayprint_offset_tbl): Likewise.
5609
5610 2019-03-29  Keith Seitz  <keiths@redhat.com>
5611
5612         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5613         %s/pulongest for TYPE_LENGTH instead of %d in format
5614         strings.
5615         * ada-typerint.c (ada_print_type): Likewise.
5616         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5617         * compile/compile-c-support.c (generate_register_struct): Likewise.
5618         * gdbtypes.c (recursive_dump_type): Likewise.
5619         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5620         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5621         instead of %d in format strings.
5622         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5623         to std::min to ULONGEST.
5624         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5625         instead of %d in format strings.
5626         * tracepoint.c (info_scope_command): Likewise.
5627         * typeprint.c (print_offset_data::update)
5628         (print_offset_data::finish): Likewise.
5629         * xtensa-tdep.c (xtensa_store_return_value)
5630         (xtensa_push_dummy_call): Likewise.
5631
5632 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5633
5634         * windows-nat.c (display_selector): Fixed format specifications
5635         for 64-bit Cygwin.
5636
5637 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5638
5639         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5640
5641 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5642
5643         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5644         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5645         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5646         (nios2_linux_init_abi): Install it.
5647
5648 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5649
5650         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5651
5652 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5653
5654         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5655
5656 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5657             Tom Tromey  <tromey@adacore.com>
5658
5659         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5660
5661 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5662
5663         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5664         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5665         method to compute the bounds of range types. Also print "[evaluated]"
5666         if the bounds' values come from a dynamic evaluation.
5667
5668 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5669
5670         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5671         whitespace when pretty printing is on.
5672
5673 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5674
5675         * ppc-linux-nat.c: Add include.
5676
5677 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5678
5679         * NEWS: Mention AArch64 Pointer Authentication.
5680
5681 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5682
5683         * arm-linux-nat.c: Add include.
5684
5685 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5686
5687         * source-cache.c (source_cache::get_source_lines): Re-read
5688         fullname after calling open_source_file.
5689
5690 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5691
5692         * NEWS: Mention TLS support for FreeBSD.
5693
5694 2019-03-25  Tom Tromey  <tromey@adacore.com>
5695
5696         * minsyms.c (BUNCH_SIZE): Update comment.
5697         (~minimal_symbol_reader): Remove old comment.
5698         (compact_minimal_symbols): Update comment.
5699         (minimal_symbol_reader::install): Remove old comment.  Update
5700         other comments.
5701
5702 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5703
5704         * s390-linux-nat.c: Add include.
5705
5706 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5707
5708         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5709         Call linux_get_hwcap.
5710         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5711         Likewise.
5712         (aarch64_linux_get_hwcap): Remove function.
5713         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5714         declaration.
5715         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5716         linux_get_hwcap.
5717         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5718         * linux-tdep.c (linux_get_hwcap): Add function.
5719         (linux_get_hwcap2): Likewise.
5720         * linux-tdep.h (linux_get_hwcap): Add declaration.
5721         (linux_get_hwcap2): Likewise.
5722         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5723         (ppc_linux_get_hwcap2): Likewise.
5724         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5725         linux_get_hwcap.
5726         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5727         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5728         (ppc_linux_nat_target::read_description): Likewise.
5729         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5730         * s390-linux-nat.c: Likewise.
5731         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5732
5733 2019-03-24  Tom Tromey  <tom@tromey.com>
5734
5735         * ada-lang.c (standard_lookup): Simplify initialization.
5736         (ada_lookup_symbol_nonlocal): Simplify return.
5737         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5738         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5739         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5740         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5741         initialization.
5742         * solib.c (solib_global_lookup): Simplify.
5743         * symtab.c (null_block_symbol): Remove.
5744         (symbol_cache_lookup): Simplify returns.
5745         (lookup_language_this): Simplify returns.
5746         (lookup_symbol_aux): Simplify return.
5747         (lookup_local_symbol): Simplify returns.
5748         (lookup_global_symbol_from_objfile): Simplify return.
5749         (lookup_symbol_in_objfile_symtabs)
5750         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5751         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5752         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5753         * cp-namespace.c (cp_lookup_bare_symbol)
5754         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5755         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5756         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5757         (cp_lookup_symbol_via_imports): Simplify initialization.
5758         (find_symbol_in_baseclass): Likewise.
5759         * symtab.h (null_block_symbol): Remove.
5760         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5761         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5762         (d_lookup_symbol_module): Likewise.
5763         (find_symbol_in_baseclass): Simplify initialization.
5764
5765 2019-03-24  Tom Tromey  <tom@tromey.com>
5766
5767         * expression.h: Don't include symtab.h.
5768         (struct block): Forward declare.
5769
5770 2019-03-24  Tom Tromey  <tom@tromey.com>
5771
5772         * c-exp.y (typebase): Remove casts.
5773         * gdbtypes.c (lookup_unsigned_typename, )
5774         (lookup_signed_typename): Remove cast.
5775         * eval.c (parse_to_comma_and_eval): Remove cast.
5776         * parse.c (write_dollar_variable): Remove cast.
5777         * block.h (struct block) <superblock>: Now const.
5778         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5779         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5780         (map_block): Make "block" const.
5781         * symfile.h (struct quick_symbol_functions)
5782         <map_matching_symbols>: Constify block argument to "callback".
5783         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5784         const.
5785         (find_pc_sect_compunit_symtab): Make "b" const.
5786         (find_symbol_at_address): Likewise.
5787         (search_symbols): Likewise.
5788         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5789         (dw2_debug_names_lookup_symbol): Likewise.
5790         (dw2_map_matching_symbols): Update.
5791         * p-valprint.c (pascal_val_print): Remove "block".
5792         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5793         (aux_add_nonlocal_symbols): Make "block" const.
5794         (resolve_subexp): Remove cast.
5795         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5796         const.
5797         (iterate_over_file_blocks): Likewise.
5798         * f-exp.y (%union) <bval>: Remove.
5799         * coffread.c (patch_opaque_types): Make "b" const.
5800         * spu-tdep.c (spu_catch_start): Make "block" const.
5801         * c-valprint.c (print_unpacked_pointer): Remove "block".
5802         * symmisc.c (dump_symtab_1): Make "b" const.
5803         (block_depth): Make "block" const.
5804         * d-exp.y (%union) <bval>: Remove.
5805         * cp-support.h (cp_lookup_rtti_type): Update.
5806         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5807         * psymtab.c (psym_lookup_symbol): Make "block" const.
5808         (maintenance_check_psymtabs): Make "b" const.
5809         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5810         (enumerate_locals, enumerate_args): Update.
5811         * python/py-symtab.c (stpy_global_block): Make "block" const.
5812         (stpy_static_block): Likewise.
5813         * inline-frame.c (block_starting_point_at): Make "new_block"
5814         const.
5815         * block.c (find_block_in_blockvector): Make return type const.
5816         (blockvector_for_pc_sect): Make "b" const.
5817         (find_block_in_blockvector): Make "b" const.
5818
5819 2019-03-23  Tom Tromey  <tom@tromey.com>
5820
5821         * varobj.c (varobj_create): Update.
5822         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5823         * printcmd.c (display_command, do_one_display): Don't reset
5824         innermost_block.
5825         * parser-defs.h (enum innermost_block_tracker_type): Move to
5826         expression.h.
5827         (innermost_block): Update comment.
5828         * parse.c (parse_exp_1): Add tracker_types parameter.
5829         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5830         tracker_types parameter.  Reset innermost_block.
5831         (parse_exp_in_context): Remove.
5832         (parse_expression_for_completion): Update.
5833         * objfiles.c (~objfile): Don't reset expression_context_block or
5834         innermost_block.
5835         * expression.h (enum innermost_block_tracker_type): Move from
5836         parser-defs.h.
5837         (parse_exp_1): Add tracker_types parameter.
5838         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5839         reset innermost_block.
5840
5841 2019-03-23  Tom Tromey  <tom@tromey.com>
5842
5843         * objfiles.h: Include bcache.h.
5844
5845 2019-03-23  Tom Tromey  <tom@tromey.com>
5846
5847         * linespec.c (get_current_search_block): Use
5848         scoped_restore_current_language.
5849         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5850
5851 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5852             Jiong Wang  <jiong.wang@arm.com>
5853
5854         * aarch64-linux-tdep.c
5855         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5856         section.
5857         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5858
5859 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5860             Jiong Wang  <jiong.wang@arm.com>
5861
5862         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5863         instructions.
5864         (aarch64_analyze_prologue_test): Add PACIASP test.
5865         (aarch64_prologue_prev_register): Unmask PC value.
5866
5867 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5868             Jiong Wang  <jiong.wang@arm.com>
5869
5870         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5871         (aarch64_dwarf2_prev_register): Unmask PC value.
5872         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5873         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5874         DW_CFA_AARCH64_negate_ra_state.
5875         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5876
5877 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5878             Jiong Wang  <jiong.wang@arm.com>
5879
5880         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5881         registers.
5882         (aarch64_pseudo_register_name): Likewise.
5883         (aarch64_pseudo_register_type): Likewise.
5884         (aarch64_pseudo_register_reggroup_p): Likewise.
5885         (aarch64_gdbarch_init): Add pauth registers.
5886         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5887         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5888         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5889         (struct gdbarch_tdep): Add regnum for ra_state.
5890
5891 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5892             Jiong Wang  <jiong.wang@arm.com>
5893
5894         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5895
5896 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5897             Jiong Wang  <jiong.wang@arm.com>
5898
5899         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5900         function.
5901         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5902         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5903         (aarch64_gdbarch_init): Add puth registers.
5904         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5905         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5906         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5907
5908 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5909             Jiong Wang  <jiong.wang@arm.com>
5910
5911         * aarch64-linux-nat.c
5912         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5913         * aarch64-linux-tdep.c
5914         (aarch64_linux_core_read_description): Likewise.
5915         (aarch64_linux_get_hwcap): New function.
5916         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5917         (aarch64_linux_get_hwcap): New declaration.
5918
5919 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5920             Jiong Wang  <jiong.wang@arm.com>
5921
5922         * aarch64-linux-nat.c
5923         (aarch64_linux_nat_target::read_description): Add pauth param.
5924         * aarch64-linux-tdep.c
5925         (aarch64_linux_core_read_description): Likewise.
5926         * aarch64-tdep.c (struct target_desc): Add in pauth.
5927         (aarch64_read_description): Add pauth param.
5928         (aarch64_gdbarch_init): Likewise.
5929         * aarch64-tdep.h (aarch64_read_description): Likewise.
5930         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5931         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5932         * features/Makefile: Add new files.
5933         * features/aarch64-pauth.c: New file.
5934         * features/aarch64-pauth.xml: New file.
5935
5936 2019-03-20  Tom Tromey  <tromey@adacore.com>
5937
5938         * infrun.c (handle_inferior_event): Rename from
5939         handle_inferior_event_1.  Create a scoped_value_mark.
5940         (handle_inferior_event): Remove.
5941
5942 2019-03-19  Tom Tromey  <tromey@adacore.com>
5943
5944         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5945         * infrun.h (print_stop_event): Add "displays" parameter.
5946         * infrun.c (print_stop_event): Add "displays" parameter.
5947
5948 2019-03-19  Pedro Alves  <palves@redhat.com>
5949
5950         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5951         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5952         to -1.  Fix TABs vs spaces.
5953         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5954         * tui/tui-out.h (tui_ui_out) Add intro comments.
5955         <m_line, m_start_of_line>: In-class initialize, and add describing
5956         comment.
5957
5958 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5959
5960         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5961         variable names.
5962         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5963
5964 2019-03-18  Pedro Alves  <palves@redhat.com>
5965             Eli Zaretskii <eliz@gnu.org>
5966
5967         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5968         m_line and m_start_of_line.
5969
5970 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5971
5972         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5973         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5974         it returns a newline.  This fixes a regression in TU mode, whereby
5975         the next line is output on the same screen line as the user input.
5976
5977 2019-03-18  Tom Tromey  <tromey@adacore.com>
5978
5979         * minsyms.c (minimal_symbol_reader::install): Remove call to
5980         obstack_blank.
5981
5982 2019-03-18  Pedro Alves  <palves@redhat.com>
5983
5984         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5985         New globals.
5986         (apply_style): New, factored out from ...
5987         (apply_ansi_escape): ... this.  Handle reverse video mode.
5988         (tui_set_reverse_mode): New function.
5989         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5990         * tui/tui-winsource.c (tui_show_source_line): Use
5991         tui_set_reverse_mode instead of setting A_STANDOUT.
5992         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5993         New setter methods.
5994
5995 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5996
5997         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5998         Handle tabs.
5999
6000 2019-03-18  Tom Tromey  <tromey@adacore.com>
6001
6002         * ada-lang.c (empty_array): Add "high" parameter.
6003         (ada_evaluate_subexp): Update.
6004
6005 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6006
6007         * unittests/string_view-selftests.c: Define
6008         _initialize_string_view_selftests unconditionally.
6009
6010 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6011
6012         PR gdb/24350
6013         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6014
6015 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6016
6017         PR gdb/24351
6018         * windows-nat.c (display_selector): Fix format specifiers.
6019
6020 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6021
6022         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6023         tui_refill_source_window instead of tui_refresh_win, to update the
6024         current execution line.  This fixes redisplay of the current line
6025         when stepping through the code with "next" or "step".
6026
6027 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6028
6029         * source-cache.c (source_cache::get_source_lines): Call
6030         find_source_lines to initialize s->nlines.  This fixes vertical
6031         scrolling of TUI source window when the DOWN arrow is pressed.
6032
6033 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6034
6035         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6036         linux-thread-db.c (_initialize_thread_db): Likewise.
6037
6038 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6039
6040         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6041         wclrtoeol in tui_show_source_line".  This reverts changes made in
6042         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6043
6044 2019-03-15  Tom Tromey  <tom@tromey.com>
6045
6046         * symtab.h (struct minimal_symbol): Derive from
6047         general_symbol_info.
6048         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6049         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6050         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6051         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6052         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6053         (MSYMBOL_SEARCH_NAME): Update.
6054         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6055         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6056         * minsyms.c (minimal_symbol_reader::record_full): Update.
6057
6058 2019-03-15  Tom Tromey  <tom@tromey.com>
6059
6060         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6061
6062 2019-03-15  Tom Tromey  <tom@tromey.com>
6063
6064         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6065         unique_xmalloc_ptr.
6066         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6067         Update.
6068         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6069         (build_minimal_symbol_hash_tables)
6070         (minimal_symbol_reader::install): Update.
6071
6072 2019-03-15  Tom Tromey  <tom@tromey.com>
6073
6074         * symtab.c (create_demangled_names_hash): Update.
6075         (symbol_set_names): Update.
6076         * objfiles.h (struct objfile_per_bfd_storage)
6077         <demangled_names_hash>: Now an htab_up.
6078         * objfiles.c (objfile_per_bfd_storage): Simplify.
6079
6080 2019-03-15  Tom Tromey  <tom@tromey.com>
6081
6082         * objfiles.h (struct objfile_per_bfd_storage): Declare
6083         destructor.
6084         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6085         New.
6086         (get_objfile_bfd_data): Use new.  Don't initialize
6087         language_of_main.
6088         (free_objfile_per_bfd_storage): Remove.
6089         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6090
6091 2019-03-15  Tom Tromey  <tom@tromey.com>
6092
6093         * symfile.c (reread_symbols): Update.
6094         * objfiles.c (objfile::objfile): Update.
6095         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6096         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6097         comment.
6098         (minimal_symbol_reader::install): Update.
6099         (terminate_minimal_symbol_table): Remove.
6100         * jit.c (jit_object_close_impl): Update.
6101
6102 2019-03-15  Tom Tromey  <tom@tromey.com>
6103
6104         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6105         initializations.
6106
6107 2019-03-15  Tom Tromey  <tom@tromey.com>
6108
6109         * objfiles.h (struct objfile_per_bfd_storage)
6110         <demangled_hash_languages>: Now a bitset.
6111         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6112         (lookup_minimal_symbol): Update.
6113
6114 2019-03-15  Tom Tromey  <tom@tromey.com>
6115
6116         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6117         Don't return the symbol.
6118         * coffread.c (record_minimal_symbol): Use record_full.
6119
6120 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6121
6122         The MS-Windows port of ncurses fails to switch to a color pair if
6123         one or both of the colors are the implicit default colors.  This
6124         change records the default colors when TUI is initialized, and
6125         then specifies them explicitly when a color pair uses the default
6126         colors.  This allows color styling in TUI mode on MS-Windows.
6127
6128         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6129         ncurses_norm_attr.
6130         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6131         colors in ncurses_norm_attr.
6132         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6133         "none", replace it with the default color recorded in
6134         ncurses_norm_attr.
6135
6136 2019-03-14  Tom Tromey  <tromey@adacore.com>
6137
6138         * source-cache.h (class source_cache) <get_source_lines>: Return
6139         std::string.
6140         * source-cache.c (source_cache::extract_lines): Handle case where
6141         first_pos==npos.  Return std::string.
6142         (source_cache::get_source_lines): Update.
6143
6144 2019-03-14  Tom Tromey  <tromey@adacore.com>
6145
6146         * NEWS: Add item for "style sources" commands.
6147         * source-cache.c (source_cache::get_source_lines): Check
6148         source_styling.
6149         * cli/cli-style.c (source_styling): New global.
6150         (_initialize_cli_style): Add "style sources" commands.
6151         (show_style_sources): New function.
6152         * cli/cli-style.h (source_styling): Declare.
6153
6154 2019-03-14  Pedro Alves  <palves@redhat.com>
6155             Tom Tromey  <tromey@adacore.com>
6156
6157         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6158         * tui/tui-winsource.c (tui_refill_source_window): New function,
6159         from...
6160         (tui_horizontal_source_scroll): ... here.  Move some logic.
6161         * cli/cli-style.c (set_style_enabled): Notify new observable.
6162         * tui/tui-hooks.c (tui_redisplay_source): New function.
6163         (tui_attach_detach_observers): Attach or detach
6164         tui_redisplay_source.
6165         * observable.h (source_styling_changed): New observable.
6166         * observable.c: Define source_styling_changed observable.
6167
6168 2019-03-13  Tom Tromey  <tromey@adacore.com>
6169
6170         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6171         (i386_gnu_nat_target::store_registers): Update.
6172         * target-debug.h (target_debug_print_std_string): New macro.
6173         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6174         * windows-tdep.c (display_one_tib): Update.
6175         * tui/tui-stack.c (tui_make_status_line): Update.
6176         * top.c (print_inferior_quit_action): Update.
6177         * thread.c (thr_try_catch_cmd): Update.
6178         (add_thread_with_info): Update.
6179         (thread_target_id_str): Update.
6180         (thr_try_catch_cmd): Update.
6181         (thread_command): Update.
6182         (thread_find_command): Update.
6183         * record-btrace.c (record_btrace_target::info_record)
6184         (record_btrace_resume_thread, record_btrace_target::resume)
6185         (record_btrace_cancel_resume, record_btrace_step_thread)
6186         (record_btrace_target::wait, record_btrace_target::wait)
6187         (record_btrace_target::wait, record_btrace_target::stop): Update.
6188         * progspace.c (print_program_space): Update.
6189         * process-stratum-target.c
6190         (process_stratum_target::thread_address_space): Update.
6191         * linux-fork.c (linux_fork_mourn_inferior)
6192         (detach_checkpoint_command, info_checkpoints_command)
6193         (linux_fork_context): Update.
6194         (linux_fork_detach): Update.
6195         (class scoped_switch_fork_info): Update.
6196         (delete_checkpoint_command): Update.
6197         * infrun.c (follow_fork_inferior): Update.
6198         (follow_fork_inferior): Update.
6199         (proceed_after_vfork_done): Update.
6200         (handle_vfork_child_exec_or_exit): Update.
6201         (follow_exec): Update.
6202         (displaced_step_prepare_throw): Update.
6203         (displaced_step_restore): Update.
6204         (start_step_over): Update.
6205         (resume_1): Update.
6206         (clear_proceed_status_thread): Update.
6207         (proceed): Update.
6208         (print_target_wait_results): Update.
6209         (do_target_wait): Update.
6210         (context_switch): Update.
6211         (stop_all_threads): Update.
6212         (restart_threads): Update.
6213         (finish_step_over): Update.
6214         (handle_signal_stop): Update.
6215         (switch_back_to_stepped_thread): Update.
6216         (keep_going_pass_signal): Update.
6217         (print_exited_reason): Update.
6218         (normal_stop): Update.
6219         * inferior.c (inferior_pid_to_str): Change return type.
6220         (print_selected_inferior): Update.
6221         (add_inferior): Update.
6222         (detach_inferior): Update.
6223         * dummy-frame.c (fprint_dummy_frames): Update.
6224         * dcache.c (dcache_info_1): Update.
6225         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6226         (btrace_fetch, btrace_clear): Update.
6227         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6228         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6229         type.
6230         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6231         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6232         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6233         * gdbarch.c, gdbarch.h: Rebuild.
6234         * gdbarch.sh (core_pid_to_str): Change return type.
6235         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6236         return type.
6237         (windows_nat_target::pid_to_str): Change return type.
6238         (windows_delete_thread): Update.
6239         (windows_nat_target::attach): Update.
6240         (windows_nat_target::files_info): Update.
6241         * target-delegates.c: Rebuild.
6242         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6243         return type.
6244         (sol_thread_target::pid_to_str): Change return type.
6245         * remote.c (class remote_target) <pid_to_str>: Change return
6246         type.
6247         (remote_target::pid_to_str): Change return type.
6248         (extended_remote_target::attach, remote_target::remote_stop_ns)
6249         (remote_target::remote_notif_remove_queued_reply)
6250         (remote_target::push_stop_reply, remote_target::disable_btrace):
6251         Update.
6252         (extended_remote_target::attach): Update.
6253         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6254         type.
6255         (gdbsim_target::pid_to_str): Change return type.
6256         * ravenscar-thread.c (struct ravenscar_thread_target)
6257         <pid_to_str>: Change return type.
6258         (ravenscar_thread_target::pid_to_str): Change return type.
6259         * procfs.c (class procfs_target) <pid_to_str>: Change return
6260         type.
6261         (procfs_target::pid_to_str): Change return type.
6262         (procfs_target::attach): Update.
6263         (procfs_target::detach): Update.
6264         (procfs_target::fetch_registers): Update.
6265         (procfs_target::store_registers): Update.
6266         (procfs_target::wait): Update.
6267         (procfs_target::files_info): Update.
6268         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6269         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6270         return type.
6271         (nto_procfs_target::pid_to_str): Change return type.
6272         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6273         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6274         return type.
6275         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6276         (exit_lwp): Update.
6277         (attach_proc_task_lwp_callback, get_detach_signal)
6278         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6279         (linux_nat_target::resume, wait_lwp, stop_callback)
6280         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6281         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6282         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6283         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6284         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6285         type.
6286         (inf_ptrace_target::attach): Update.
6287         (inf_ptrace_target::files_info): Update.
6288         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6289         type.
6290         (go32_nat_target::pid_to_str): Change return type.
6291         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6292         (gnu_nat_target::wait): Update.
6293         (gnu_nat_target::wait): Update.
6294         (gnu_nat_target::resume): Update.
6295         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6296         (fbsd_nat_target::wait): Update.
6297         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6298         type.
6299         (darwin_nat_target::attach): Update.
6300         * corelow.c (class core_target) <pid_to_str>: Change return type.
6301         (core_target::pid_to_str): Change return type.
6302         * target.c (normal_pid_to_str): Change return type.
6303         (default_pid_to_str): Likewise.
6304         (target_pid_to_str): Change return type.
6305         (target_translate_tls_address): Update.
6306         (target_announce_detach): Update.
6307         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6308         return type.
6309         (bsd_uthread_target::pid_to_str): Change return type.
6310         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6311         type.
6312         (bsd_kvm_target::pid_to_str): Change return type.
6313         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6314         return type.
6315         (aix_thread_target::pid_to_str): Change return type.
6316         * target.h (struct target_ops) <pid_to_str>: Change return type.
6317         (target_pid_to_str, normal_pid_to_str): Likewise.
6318         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6319         type.
6320         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6321         type.
6322         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6323         return type.
6324         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6325         type.
6326         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6327         type.
6328         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6329         return type.
6330
6331 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6332
6333         * NEWS: Mention that the new default MI version is 3.  Mention
6334         changes to the output of commands and events that deal with
6335         multi-location breakpoints.
6336         * breakpoint.c: Include "mi/mi-out.h".
6337         (print_one_breakpoint): Change output syntax if using MI version
6338         >= 3.
6339         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6340         New.
6341         (mi_multi_location_breakpoint_output_fixed): New.
6342         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6343         (mi_cmd_fix_multi_location_breakpoint_output): New.
6344         (mi_multi_location_breakpoint_output_fixed): New.
6345         * mi/mi-cmds.c (mi_cmds): Register command
6346         -fix-multi-location-breakpoint-output.
6347         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6348         interpreter "mi".
6349
6350 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6351
6352         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6353         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6354         instantiate mi_ui_out based on interpreter name.
6355         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6356         * mi/mi-main.c (mi_load_progress): Likewise.
6357
6358 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6359
6360         * NEWS: Combine separate "New targets" sections for 8.3.
6361
6362 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6363
6364         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6365         (ppcfbsd_init_abi): Install gdbarch
6366         "fetch_tls_load_module_address" and "get_thread_local_address"
6367         methods.
6368
6369 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6370
6371         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6372         (riscv_fbsd_init_abi): Install gdbarch
6373         "fetch_tls_load_module_address" and "get_thread_local_address"
6374         methods.
6375
6376 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6377
6378         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6379         (i386fbsd_init_abi): Install gdbarch
6380         "fetch_tls_load_module_address" and "get_thread_local_address"
6381         methods.
6382
6383 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6384
6385         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6386         (amd64fbsd_init_abi): Install gdbarch
6387         "fetch_tls_load_module_address" and "get_thread_local_address"
6388         methods.
6389
6390 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6391
6392         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6393         (struct fbsd_pspace_data): New type.
6394         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6395         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6396         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6397         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6398         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6399
6400 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6401
6402         * gdbtypes.c (lookup_struct_elt): New function.
6403         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6404         * gdbtypes.h (struct struct_elt): New type.
6405         (lookup_struct_elt): New prototype.
6406
6407 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6408
6409         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6410         remove disabled code block.
6411
6412 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6413
6414         * gdbarch.sh (get_thread_local_address): New method.
6415         * gdbarch.h, gdbarch.c: Regenerate.
6416         * target.c (target_translate_tls_address): Use
6417         gdbarch_get_thread_local_address if present instead of
6418         target::get_thread_local_address.
6419
6420 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6421
6422         * target.h (target::get_thread_local_address): Update comment.
6423
6424 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6425
6426         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6427         objfile->separate_debug_objfile_backlink if not NULL.
6428
6429 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6430
6431         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6432         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6433         (amd64bsd_store_inferior_registers): Likewise.
6434         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6435         Enable segment base registers.
6436         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6437         PT_GETFSBASE and PT_GETGSBASE.
6438         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6439         PT_SETGSBASE.
6440         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6441         segment base registers.
6442         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6443
6444 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6445
6446         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6447         Update calls to i386_target_description to add 'segments'
6448         parameter.
6449         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6450         add segment base registers.
6451         * arch/i386.c (i386_create_target_description): Add 'segments'
6452         parameter to enable segment base registers.
6453         * arch/i386.h (i386_create_target_description): Likewise.
6454         * features/i386/32bit-segments.xml: New file.
6455         * features/i386/32bit-segments.c: Generate.
6456         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6457         call to i386_target_description to add 'segments' parameter.
6458         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6459         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6460         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6461         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6462         if feature is present.
6463         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6464         Add 'segments' parameter to call to i386_target_description.
6465         (i386_target_description): Add 'segments' parameter to enable
6466         segment base registers.
6467         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6468         to call to i386_target_description.
6469         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6470         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6471         Define I386_NUM_REGS.
6472         (i386_target_description): Add 'segments' parameter to enable
6473         segment base registers.
6474
6475 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6476
6477         PR/24325
6478         * source-cache.c: #undef open and close, to avoid unresolved
6479         externals during linking.
6480
6481 2019-03-12  Tom Tromey  <tromey@adacore.com>
6482
6483         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6484         const.  Add initializers.
6485         (_initialize_remote): Don't initialize ptid globals.
6486
6487 2019-03-12  Pedro Alves  <palves@redhat.com>
6488
6489         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6490
6491 2019-03-12  Pedro Alves  <palves@redhat.com>
6492
6493         * cp-name-parser.y (main): Remove unused 'len' variable.
6494
6495 2019-03-12  Tom Tromey  <tromey@adacore.com>
6496
6497         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6498         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6499
6500 2019-03-12  Tom Tromey  <tromey@adacore.com>
6501
6502         * linux-nat.c (iterate_over_lwps): Update.
6503         (stop_callback): Remove parameter.
6504         (stop_wait_callback, detach_callback, resume_set_callback)
6505         (select_singlestep_lwp_callback, set_ignore_sigint)
6506         (status_callback, resumed_callback, resume_clear_callback)
6507         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6508         data parameter.
6509         (linux_nat_target::detach, linux_nat_target::resume)
6510         (linux_stop_and_wait_all_lwps, select_event_lwp)
6511         (linux_nat_filter_event, linux_nat_wait_1)
6512         (linux_nat_target::kill, linux_nat_target::stop)
6513         (linux_nat_target::stop): Update.
6514         (linux_nat_resume_callback): Change type.
6515         (resume_stopped_resumed_lwps, count_events_callback)
6516         (select_event_lwp_callback): Likewise.
6517         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6518         * arm-linux-nat.c (struct update_registers_data): Remove.
6519         (update_registers_callback): Change type.
6520         (arm_linux_insert_hw_breakpoint1): Update.
6521         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6522         parameter.
6523         (x86_linux_dr_set_addr): Update.
6524         (x86_linux_dr_set_control): Update.
6525         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6526         (iterate_over_lwps): Use gdb::function_view.
6527         * nat/aarch64-linux-hw-point.c (struct
6528         aarch64_dr_update_callback_param): Remove.
6529         (debug_reg_change_callback): Change type.
6530         (aarch64_notify_debug_reg_change): Update.
6531         * s390-linux-nat.c (s390_refresh_per_info): Update.
6532
6533 2019-03-11  Tom Tromey  <tromey@adacore.com>
6534
6535         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6536         redundant assignment to "this_cu".
6537
6538 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6539
6540         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6541
6542 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6543
6544         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6545         from...
6546         (rank_one_type): ... this.
6547
6548 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6549
6550         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6551         from...
6552         (rank_one_type): ... this.
6553
6554 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6555
6556         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6557         from...
6558         (rank_one_type): ... this.
6559
6560 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6561
6562         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6563         from...
6564         (rank_one_type): ... this.
6565
6566 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6567
6568         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6569         from...
6570         (rank_one_type): ... this.
6571
6572 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6573
6574         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6575         from...
6576         (rank_one_type): ... this.
6577
6578 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6579
6580         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6581         from...
6582         (rank_one_type): ... this.
6583
6584 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6585
6586         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6587         from...
6588         (rank_one_type): ... this.
6589
6590 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6591
6592         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6593         from...
6594         (rank_one_type): ... this.
6595
6596 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6597
6598         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6599         from...
6600         (rank_one_type): ... this.
6601
6602 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6603
6604         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6605         from...
6606         (rank_one_type): ... this.
6607
6608 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6609
6610         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6611         from...
6612         (rank_one_type): ... this.
6613
6614 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6615
6616         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6617         inferior-events' shows the example events.
6618
6619 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6620
6621         Support styling on native MS-Windows console
6622
6623         PR/24315
6624         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6625         on MS-Windows if $TERM is not defined.
6626
6627         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6628
6629         * posix-hdep.c (gdb_console_fputs):
6630         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6631         functions.
6632         * ui-file.h (gdb_console_fputs): Add prototype.
6633
6634         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6635         back to fputs only if the former returns zero.
6636
6637 2019-03-07  Tom Tromey  <tom@tromey.com>
6638
6639         * symmisc.c (print_symbol_bcache_statistics): Update.
6640         (print_objfile_statistics): Update.
6641         * symfile.c (allocate_symtab): Update.
6642         * stabsread.c: Don't include bcache.h.
6643         * psymtab.h (struct psymbol_bcache): Don't declare.
6644         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6645         (psymbol_bcache_init, psymbol_bcache_free)
6646         (psymbol_bcache_get_bcache): Don't declare.
6647         * psymtab.c (struct psymbol_bcache): Remove.
6648         (psymtab_storage::psymtab_storage): Update.
6649         (psymtab_storage::~psymtab_storage): Update.
6650         (psymbol_bcache_init, psymbol_bcache_free)
6651         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6652         (add_psymbol_to_bcache): Update.
6653         (allocate_psymtab): Update.
6654         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6655         macro_cache>: No longer pointers.
6656         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6657         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6658         * macrotab.c (macro_bcache): Update.
6659         * macroexp.c: Don't include bcache.h.
6660         * gdbtypes.c (check_types_worklist): Update.
6661         (types_deeply_equal): Remove TRY/CATCH.  Update.
6662         * elfread.c (elf_symtab_read): Update.
6663         * dwarf2read.c: Don't include bcache.h.
6664         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6665         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6666         (print_bcache_statistics, bcache_memory_used): Don't declare.
6667         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6668         methods.  Rename all data members.
6669         * bcache.c (struct bcache): Move to bcache.h.
6670         (bcache::expand_hash_table): Rename from expand_hash_table.
6671         (bcache): Remove.
6672         (bcache::insert): Rename from bcache_full.
6673         (bcache::compare): Rename from bcache_compare.
6674         (bcache_xmalloc): Remove.
6675         (bcache::~bcache): Rename from bcache_xfree.
6676         (bcache::print_statistics): Rename from print_bcache_statistics.
6677         (bcache::memory_used): Rename from bcache_memory_used.
6678
6679 2019-03-07  Pedro Alves  <palves@redhat.com>
6680
6681         * infrun.c (normal_stop): Also check for
6682         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6683
6684 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6685
6686         * f-lang.c (value_from_host_double): Moved to...
6687         * value.c (value_from_host_double): ...here.
6688         * value.h (value_from_host_double): Declare.
6689         * guile/scm-math.c (vlscm_convert_typed_number): Use
6690         value_from_host_double.
6691         (vlscm_convert_number): Likewise.
6692         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6693         * python/py-value.c (convert_value_from_python): Likewise.
6694
6695 2019-03-06  Tom Tromey  <tom@tromey.com>
6696
6697         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6698
6699 2019-03-06  Tom Tromey  <tom@tromey.com>
6700
6701         * utils.h (free_current_contents): Don't declare.
6702         * utils.c (free_current_contents): Remove.
6703
6704 2019-03-06  Tom Tromey  <tom@tromey.com>
6705
6706         * top.c (quit_force): Update.
6707         * main.c (captured_command_loop): Update.
6708         * common/new-op.c (operator new): Update.
6709         * common/common-exceptions.c (struct catcher)
6710         <save_cleanup_chain>: Remove member.
6711         (exceptions_state_mc_init): Update.
6712         (exception_try_scope_entry): Return nullptr.
6713         (exception_try_scope_exit, exception_rethrow)
6714         (throw_exception_sjlj, throw_exception_cxx): Update.
6715         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6716         (all_cleanups, do_cleanups, discard_cleanups)
6717         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6718         (restore_cleanups, restore_final_cleanups): Don't declare.
6719         (do_final_cleanups): Remove parameter.
6720         * common/cleanups.c (cleanup_chain, make_cleanup)
6721         (make_cleanup_dtor, all_cleanups, do_cleanups)
6722         (discard_my_cleanups, discard_cleanups)
6723         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6724         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6725         (null_cleanup): Remove.
6726         (do_final_cleanups): Remove parameter.
6727
6728 2019-03-06  Tom Tromey  <tom@tromey.com>
6729
6730         * remote.c (remote_target::remote_parse_stop_reply): Use
6731         unique_xmalloc_ptr.
6732
6733 2019-03-06  Tom Tromey  <tom@tromey.com>
6734
6735         * stabsread.c (struct stabs_field_info): Rename from field_info.
6736         <list, fnlist>: Add initializers.
6737         <obstack>: New member.
6738         (read_member_functions, read_struct_fields, read_baseclasses):
6739         Allocate on obstack.  Don't use cleanups.
6740         (read_one_struct_field, read_member_functions, read_struct_fields)
6741         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6742         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6743         (read_struct_type): Update.
6744
6745 2019-03-06  Tom Tromey  <tom@tromey.com>
6746
6747         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6748         * common/filestuff.h (make_cleanup_close): Don't declare.
6749         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6750         Remove.
6751
6752 2019-03-06  Tom Tromey  <tom@tromey.com>
6753
6754         * solib-aix.c: Use make_scope_exit.
6755
6756 2019-03-06  Tom Tromey  <tom@tromey.com>
6757
6758         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6759         Use make_scope_exit.
6760
6761 2019-03-06  Tom Tromey  <tom@tromey.com>
6762
6763         * solib-svr4.c (disable_probes_interface): Remove parameter.
6764         (svr4_handle_solib_event): Use make_scope_exit.
6765
6766 2019-03-06  Tom Tromey  <tom@tromey.com>
6767
6768         * remote.c (struct stop_reply_deleter): Remove.
6769         (stop_reply_up): Update.
6770         (struct stop_reply): Derive from notif_event.  Don't typedef.
6771         <regcache>: Now a std::vector.
6772         (stop_reply_xfree): Remove.
6773         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6774         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6775         (remote_target::discard_pending_stop_replies): Use delete.
6776         (remote_target::remote_parse_stop_reply): Update.
6777         (remote_target::process_stop_reply): Update.
6778         * remote-notif.h (struct notif_event): Add virtual destructor.
6779         Remove "dtr" member.
6780         (struct notif_client) <alloc_event>: Return a unique_ptr.
6781         (notif_event_xfree): Don't declare.
6782         (notif_event_up): New typedef.
6783         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6784         (notif_event_xfree, do_notif_event_xfree): Remove.
6785         (remote_notif_state_xfree): Update.
6786
6787 2019-03-06  Tom Tromey  <tom@tromey.com>
6788
6789         * infrun.c (displaced_step_clear_cleanup): Now a
6790         forward_scope_exit type.
6791         (displaced_step_prepare_throw): Update.
6792         (displaced_step_fixup): Update.
6793
6794 2019-03-06  Tom Tromey  <tom@tromey.com>
6795
6796         * inferior.h (class inferior): Update comment.
6797         * gdbthread.h (class thread_info): Update comment.
6798
6799 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6800             Tom Tromey  <tom@tromey.com>
6801
6802         * stabsread.h (struct stab_section_list): Remove.
6803         (coffstab_build_psymtabs): Update.
6804         * dbxread.c (symbuf_sections): Now a std::vector.
6805         (sect_idx): New global.
6806         (fill_symbuf): Update.
6807         (coffstab_build_psymtabs): Change type of stabsects parameter.
6808         Update.
6809         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6810         std::vector.
6811         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6812         (coff_locate_sections): Update.
6813         (coff_symfile_read): Remove cleanups.  Update.
6814         (init_stringtab): Add storage parameter.
6815         (free_stringtab, free_stringtab_cleanup): Remove.
6816         (init_lineno): Add storage parameter.
6817         (free_linetab, free_linetab_cleanup): Remove.
6818
6819 2019-03-06  Pedro Alves  <palves@redhat.com>
6820
6821         * linux-fork.c (fork_info::clobber_regs): Delete.
6822         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6823         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6824         comment.  Adjust.
6825         (scoped_switch_fork_info::scoped_switch_fork_info)
6826         (checkpoint_command, linux_fork_context): Adjust
6827         fork_save_infrun_state calls.
6828
6829 2019-03-06  Pedro Alves  <palves@redhat.com>
6830
6831         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6832         (inf_has_multiple_threads): Return 'bool' and rewrite using
6833         inferior_info::threads().
6834
6835 2019-03-06  Pedro Alves  <palves@redhat.com>
6836
6837         * linux-fork.c: Include <list>.
6838         (fork_list): Now a std::list instance.
6839         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6840         (forks_exist_p, find_last_fork): Adjust.
6841         (new_fork): Delete.
6842         (one_fork_p): New.
6843         (add_fork): Adjust.
6844         (free_fork): Delete, folded into fork_info::~fork_info().
6845         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6846         Adjust.
6847         (init_fork_list): Delete.
6848         (linux_fork_killall, linux_fork_mourn_inferior)
6849         (linux_fork_detach, info_checkpoints_command): Adjust.
6850         (_initialize_linux_fork): No longer call init_fork_list.
6851
6852 2019-03-06  Pedro Alves  <palves@redhat.com>
6853
6854         * linux-fork.c (new_fork): New, split out of ...
6855         (add_fork): ... this.  Return void.  Move "first fork" special
6856         case from here, to ...
6857         (checkpoint_command): ... here.
6858         * linux-linux.h (add_fork): Return void.
6859
6860 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6861
6862         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6863
6864 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6865             Chris January  <chris.january@arm.com>
6866             David Lecomber  <david.lecomber@arm.com>
6867
6868         * f-exp.y: New token, UNOP_INTRINSIC.
6869         (exp): New pattern using UNOP_INTRINSIC token.
6870         (f77_keywords): Add 'abs' keyword.
6871         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6872         (value_from_host_double): New function.
6873         (evaluate_subexp_f): Support UNOP_ABS.
6874
6875 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6876
6877         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6878         types.
6879
6880 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6881
6882         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6883         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6884         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6885
6886 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6887
6888         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6889
6890 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6891             Chris January  <chris.january@arm.com>
6892
6893         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6894         * f-exp.y: Define 'KIND' token.
6895         (exp): New pattern for KIND expressions.
6896         (ptype): Handle types with a kind extension.
6897         (direct_abs_decl): Extend to spot kind extensions.
6898         (f77_keywords): Add 'kind' to the list.
6899         (push_kind_type): New function.
6900         (convert_to_kind_type): New function.
6901         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6902         * parse.c (operator_length_standard): Likewise.
6903         * parser-defs.h (enum type_pieces): Add tp_kind.
6904         * std-operator.def: Add UNOP_KIND.
6905
6906 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6907
6908         * f-exp.y (f_parse): Set yydebug.
6909
6910 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6911
6912         * f-lang.c (evaluate_subexp_f): New function.
6913         (exp_descriptor_f): New global.
6914         (f_language_defn): Use exp_descriptor_f instead of
6915         exp_descriptor_standard.
6916
6917 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6918
6919         * f-exp.y (struct token): Add comments.
6920         (dot_ops): Remove uppercase versions and the end marker.
6921         (f77_keywords): Likewise.
6922         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6923         entries in the dot_ops array are case insensitive, and use
6924         strncasecmp to compare strings.  Also some whitespace cleanup in
6925         this area.  Similar for the f77_keywords array, except entries in
6926         this list might be case sensitive.
6927
6928 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6929
6930         * f-exp.y (struct f77_boolean_val): Add comments.
6931         (boolean_values): Remove uppercase versions, and end marker.
6932         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6933         and use strncasecmp to achieve case insensitivity.  Additionally,
6934         perform whitespace cleanup around this code.
6935
6936 2019-03-06  Tom Tromey  <tromey@adacore.com>
6937
6938         * remote-sim.c (gdbsim_target_open): Use result of
6939         gdb_argv::release.
6940
6941 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6942         Dirk Schubert  <dirk.schubert@arm.com>
6943         Chris January  <chris.january@arm.com>
6944
6945         * eval.c (evaluate_subexp_standard): Call Fortran argument
6946         wrapping logic.
6947         * f-lang.c (struct value): A value which can be passed into a
6948         Fortran function call.
6949         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6950         where appropriate.
6951         (struct type): Value ready for a Fortran function call.
6952         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6953         is needed.
6954         * f-lang.h (fortran_argument_convert): Declaration.
6955         (fortran_preserve_arg_pointer): Declaration.
6956         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6957
6958 2019-03-05  Tom Tromey  <tromey@adacore.com>
6959
6960         * python/py-prettyprint.c (print_string_repr): Remove #if.
6961         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6962
6963 2019-03-05  Tom Tromey  <tromey@adacore.com>
6964
6965         * target.c (the_dummy_target): Move later.  Change type to
6966         "dummy_target".
6967         (initialize_targets): Don't initialize the_dummy_target.
6968
6969 2019-03-05  Tom Tromey  <tromey@adacore.com>
6970
6971         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6972         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6973
6974 2019-03-05  Tom Tromey  <tromey@adacore.com>
6975
6976         * windows-nat.c (windows_nat_target::attach)
6977         (windows_nat_target::detach): Don't call gdb_flush.
6978         * valprint.c (generic_val_print, val_print, val_print_string):
6979         Don't call gdb_flush.
6980         * utils.c (defaulted_query): Don't call gdb_flush.
6981         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6982         * target.c (target_announce_detach): Don't call gdb_flush.
6983         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6984         * remote.c (extended_remote_target::attach): Don't call
6985         gdb_flush.
6986         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6987         * printcmd.c (do_examine): Don't call gdb_flush.
6988         (info_display_command): Don't call gdb_flush.
6989         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6990         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6991         * memattr.c (info_mem_command): Don't call gdb_flush.
6992         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6993         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6994         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6995         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6996         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6997         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6998         (gnu_nat_target::detach): Don't call gdb_flush.
6999         * f-valprint.c (f_val_print): Don't call gdb_flush.
7000         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7001         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7002         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7003         gdb_flush.
7004         * c-valprint.c (c_val_print): Don't call gdb_flush.
7005         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7006
7007 2019-03-05  Tom Tromey  <tromey@adacore.com>
7008
7009         * varobj.c (update_dynamic_varobj_children): Update.
7010         (install_default_visualizer): Use reset, not release.
7011         * value.c (set_internalvar): Update.
7012         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7013         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7014         ATTRIBUTE_UNUSED_RESULT.
7015
7016 2019-03-05  Tom Tromey  <tromey@adacore.com>
7017
7018         * remote.c (class scoped_remote_fd) <release>: Add
7019         ATTRIBUTE_UNUSED_RESULT.
7020
7021 2019-03-05  Tom Tromey  <tromey@adacore.com>
7022
7023         * macroexp.c (struct macro_buffer) <release>: Add
7024         ATTRIBUTE_UNUSED_RESULT.
7025
7026 2019-03-05  Tom Tromey  <tromey@adacore.com>
7027
7028         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7029         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7030         ATTRIBUTE_UNUSED_RESULT.
7031
7032 2019-03-05  Tom Tromey  <tromey@adacore.com>
7033
7034         * common/scoped_fd.h (class scoped_fd) <release>: Add
7035         ATTRIBUTE_UNUSED_RESULT.
7036
7037 2019-03-05  Tom Tromey  <tromey@adacore.com>
7038
7039         * parser-defs.h (struct parser_state) <release>: Add
7040         ATTRIBUTE_UNUSED_RESULT.
7041
7042 2019-03-05  Tom Tromey  <tromey@adacore.com>
7043
7044         * utils.h (class gdb_argv) <release>: Add
7045         ATTRIBUTE_UNUSED_RESULT.
7046         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7047
7048 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7049
7050         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7051         for-loop range, to avoid compiler warnings.
7052
7053         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7054         avoid compiler warnings about unused variables.
7055
7056         * NEWS: Mention end of support for native debugging on MS-Windows
7057         before XP.
7058
7059         PR gdb/24292
7060         * common/netstuff.c:
7061         * gdbserver/gdbreplay.c
7062         * gdbserver/remote-utils.c:
7063         * ser-tcp.c:
7064         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7065         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7066         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7067         'getaddrinfo' and 'freeaddrinfo' were not available before
7068         Windows XP, and mingw.org's MinGW headers by default define
7069         _WIN32_WINNT to 0x500.
7070
7071 2019-03-01  Gary Benson <gbenson@redhat.com>
7072
7073         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7074
7075 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7076             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7077
7078         PR gdb/8527
7079         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7080         set_sigint_trap, clear_sigint_trap.
7081
7082 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7083
7084         * target.c (target_detach): Clear the regcache and the
7085         frame cache.
7086
7087 2019-02-27  Pedro Alves  <palves@redhat.com>
7088
7089         * utils.c (set_screen_size): When we cap the height/width sizes,
7090         tweak the corresponding command variable to show "unlimited":
7091
7092 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7093             Pedro Alves  <palves@redhat.com>
7094
7095         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7096         before calling rl_set_screen_size.
7097
7098 2019-02-27  Tom Tromey  <tromey@adacore.com>
7099
7100         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7101         define.
7102         * python/py-value.c: Remove Python 2.4 workaround.
7103         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7104         workaround.
7105         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7106         Python 2.4 workaround.
7107         * python/python-internal.h: Remove Python 2.4 comment.
7108         (Py_ssize_t): Don't define.
7109         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7110         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7111         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7112         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7113         * python/python.c (do_start_initialization): Remove Python 2.4
7114         workaround.
7115         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7116         (print_children): Remove Python 2.4 workaround.
7117         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7118         workaround.
7119         (CHARBUFFERPROC_NAME): Remove.
7120         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7121         Python 2.4 workaround.
7122
7123 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7124
7125         * NEWS: Note minimum Python version.
7126
7127 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7128
7129         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7130         code from these functions.  Remove corresponding ifdefs.  Use
7131         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7132         Remove gotos and target of gotos.
7133         (infpy_search_memory): Likewise.
7134
7135 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7136
7137         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7138         (hppa_gdbarch_init): Don't register deleted functions with
7139         gdbarch.
7140
7141 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7142
7143         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7144         (h8300_unwind_sp): Delete.
7145         (h8300_dummy_id): Delete.
7146         (h8300_gdbarch_init): Don't register deleted functions with
7147         gdbarch.
7148
7149 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7150
7151         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7152         (ft32_unwind_pc): Delete.
7153         (ft32_unwind_sp): Delete.
7154         (ft32_gdbarch_init): Don't register deleted functions with
7155         gdbarch.
7156
7157 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7158
7159         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7160         (frv_unwind_pc): Delete.
7161         (frv_unwind_sp): Delete.
7162         (frv_gdbarch_init): Don't register deleted functions with
7163         gdbarch.
7164
7165 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7166
7167         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7168         (riscv_unwind_pc): Delete.
7169         (riscv_unwind_sp): Delete.
7170         (riscv_gdbarch_init): Don't register deleted functions with
7171         gdbarch.
7172
7173 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7174
7175         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7176         (csky_unwind_pc): Delete.
7177         (csky_unwind_sp): Delete.
7178         (csky_gdbarch_init): Don't register deleted functions with
7179         gdbarch.
7180
7181 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7182
7183         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7184         (cris_unwind_pc): Delete.
7185         (cris_unwind_sp): Delete.
7186         (cris_gdbarch_init): Don't register deleted functions with
7187         gdbarch.
7188
7189 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7190
7191         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7192         (bfin_unwind_pc): Delete.
7193         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7194
7195 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7196
7197         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7198         (arm_unwind_pc): Delete.
7199         (arm_unwind_sp): Delete.
7200         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7201
7202 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7203
7204         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7205         (arc_unwind_pc): Delete.
7206         (arc_unwind_sp): Delete.
7207         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7208
7209 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7210
7211         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7212         (alpha_unwind_pc): Delete.
7213         (alpha_gdbarch_init): Don't register deleted functions with
7214         gdbarch.
7215
7216 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7217
7218         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7219         (aarch64_unwind_pc): Delete.
7220         (aarch64_unwind_sp): Delete.
7221         (aarch64_gdbarch_init): Don't register deleted functions with
7222         gdbarch.
7223
7224 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7225
7226         * gdbtypes.c (type_align): Don't consider static members when
7227         computing structure alignment.
7228
7229 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7230
7231         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7232         return 0 for other types.
7233         * arch-utils.c (default_type_align): Always return 0.
7234         * gdbarch.h: Regenerate.
7235         * gdbarch.sh (type_align): Extend comment.
7236         * gdbtypes.c (type_align): Add additional comments, always call
7237         gdbarch_type_align before applying the default rules.
7238         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7239         generic code will then apply a suitable default.
7240         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7241         types, return 0 for other types.
7242
7243 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7244
7245         * NEWS: Create a new section for the next release branch.
7246         Rename the section of the current branch, now that it has
7247         been cut.
7248
7249 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7250
7251         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7252         * version.in: Bump version to 8.3.50.DATE-git.
7253
7254 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7255
7256         * aix-thread.c (ptid_cmp): Remove unused variable.
7257         (get_signaled_thread): Likewise.
7258         (store_regs_user_thread): Likewise.
7259         (store_regs_kernel_thread): Likewise.
7260         (fetch_regs_kernel_thread): Remove shadowed variable.
7261
7262 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7263
7264         * features/riscv/32bit-cpu.xml: Add register numbers.
7265         * features/riscv/32bit-fpu.c: Regenerate.
7266         * features/riscv/32bit-fpu.xml: Add register numbers.
7267         * features/riscv/64bit-cpu.xml: Add register numbers.
7268         * features/riscv/64bit-fpu.c: Regenerate.
7269         * features/riscv/64bit-fpu.xml: Add register numbers.
7270
7271 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7272
7273         * NEWS: Mention two argument form of gdb.Value constructor.
7274         * python/py-value.c (convert_buffer_and_type_to_value): New
7275         function.
7276         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7277         Add support for handling an optional second argument.  Call
7278         convert_buffer_and_type_to_value as appropriate.
7279         * python/python-internal.h (Py_buffer_deleter): New struct.
7280         (Py_buffer_up): New typedef.
7281
7282 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7283
7284         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7285         instead of releasing ownership.
7286
7287 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7288
7289         * dwarf2read.c (open_and_init_dwp_file): Call
7290         elf_numsections instead of bfd_count_sections to initialize
7291         dwp_file->num_sections.
7292
7293 2019-02-25  Tom Tromey  <tromey@adacore.com>
7294
7295         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7296
7297 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7298
7299         * gcore.in: Add '--readnever' option when invoking GDB.
7300
7301 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7302
7303         * MAINTAINERS: Update my email address.
7304
7305 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7306
7307         * build-id.c (build_id_to_debug_bfd_1): New function.
7308         (build_id_to_debug_bfd): Look for separate debug file in
7309         sysroot.
7310
7311 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7312
7313         * gdbarch.sh: Update the copyright year range that is placed into
7314         generated files.
7315
7316 2019-02-22  Keith Seitz  <keiths@redhat.com>
7317
7318         PR symtab/23853
7319         * linespec.c (create_sals_line_offset): Search for the default
7320         symtab's filename instead of its fullname.
7321
7322 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7323
7324         * NEWS: Update style defaults.
7325
7326 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7327
7328         * main.c (captured_main_1): Disable styling in batch mode.
7329
7330 2019-02-20  Tom Tromey  <tom@tromey.com>
7331
7332         * symtab.c (symtab_symbol_info): Fix typos.
7333
7334 2019-02-20  Tom Tromey  <tromey@adacore.com>
7335
7336         * findcmd.c (_initialize_mem_search): Use upper case for
7337         metasyntactic variables.
7338
7339 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7340
7341         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7342         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7343
7344 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7345
7346         * top.h (source_file_name): Change to std::string.
7347         * top.c (source_file_name): Likewise.
7348         (command_line_input): Adjust.
7349         * cli/cli-script.c (script_from_file): Adjust.
7350
7351 2019-02-19  Tom Tromey  <tromey@adacore.com>
7352
7353         * ravenscar-thread.c
7354         (ravenscar_thread_target::update_thread_list): Don't call
7355         ada_build_task_list.
7356         * ada-lang.h (ada_build_task_list): Don't declare.
7357         * ada-tasks.c (struct ada_tasks_inferior_data)
7358         <task_list_valid_p>: Now bool.
7359         (read_known_tasks, ada_task_list_changed)
7360         (ada_tasks_invalidate_inferior_data): Update.
7361         (read_known_tasks_array): Return bool.
7362         (read_known_tasks_list): Likewise.
7363         (read_known_tasks): Return void.
7364         (ada_build_task_list): Now static.
7365
7366 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7367
7368         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7369         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7370
7371 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7372
7373         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7374         variant for ada_tasks_pspace_data_handle and
7375         ada_tasks_inferior_data_handle.
7376         (ada_tasks_pspace_data_cleanup): New function.
7377         (ada_tasks_inferior_data_cleanup): New function.
7378
7379 2019-02-17  Tom Tromey  <tom@tromey.com>
7380
7381         * macrotab.h (macro_source_fullname): Return a std::string.
7382         * macrotab.c (macro_include, check_for_redefinition)
7383         (macro_undef, macro_lookup_definition, foreach_macro)
7384         (foreach_macro_in_scope): Update.
7385         (macro_source_fullname): Return a std::string.
7386         * macrocmd.c (show_pp_source_pos): Update.
7387
7388 2019-02-17  Tom Tromey  <tom@tromey.com>
7389
7390         * macrocmd.c (show_pp_source_pos): Style the file names.
7391
7392 2019-02-17  Tom Tromey  <tom@tromey.com>
7393
7394         PR tui/24197:
7395         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7396
7397 2019-02-17  Tom Tromey  <tom@tromey.com>
7398
7399         * ada-lang.c (user_select_syms): Use filtered printing.
7400         * utils.c (wrap_style): New global.
7401         (desired_style): Remove.
7402         (emit_style_escape): Add stream parameter.
7403         (set_output_style, reset_terminal_style, prompt_for_continue):
7404         Update.
7405         (flush_wrap_buffer): Only flush gdb_stdout.
7406         (wrap_here): Set wrap_style.
7407         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7408         treat escape sequences as a character.  Change when wrap buffer is
7409         flushed.
7410         (fputs_styled): Do not set the output style when the default is
7411         requested.
7412         * ui-style.h (struct ui_file_style) <is_default>: New method.
7413         * source.c (print_source_lines_base): Emit escape sequences in one
7414         piece.
7415
7416 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7417
7418         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7419         integers and enumeration types.
7420
7421 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7422
7423         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7424         instead of lookup_symbol_in_language
7425         (do_exact_match): New function.
7426         (ada_get_symbol_name_matcher): Return do_exact_match when
7427         doing a verbatim match.
7428
7429 2019-02-15  Tom Tromey  <tromey@adacore.com>
7430
7431         * ravenscar-thread.c (ravenscar_thread_target::resume)
7432         (ravenscar_thread_target::wait): Special case wildcard requests.
7433
7434 2019-02-15  Tom Tromey  <tromey@adacore.com>
7435
7436         * ravenscar-thread.c (base_ptid): Remove.
7437         (struct ravenscar_thread_target) <close>: New method.
7438         <m_base_ptid>: New member.
7439         <update_inferior_ptid, active_task, task_is_currently_active,
7440         runtime_initialized>: Declare methods.
7441         <ravenscar_thread_target>: Add constructor.
7442         (ravenscar_thread_target::task_is_currently_active)
7443         (ravenscar_thread_target::update_inferior_ptid)
7444         (ravenscar_runtime_initialized): Rename.  Now methods.
7445         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7446         (ravenscar_thread_target::update_thread_list): Update.
7447         (ravenscar_thread_target::active_task): Now method.
7448         (ravenscar_thread_target::store_registers)
7449         (ravenscar_thread_target::prepare_to_store)
7450         (ravenscar_thread_target::prepare_to_store)
7451         (ravenscar_thread_target::mourn_inferior): Update.
7452         (ravenscar_inferior_created): Use "new" to create target.
7453         (ravenscar_thread_target::get_ada_task_ptid): Update.
7454         (_initialize_ravenscar): Don't initialize base_ptid.
7455         (ravenscar_ops): Remove global.
7456
7457 2019-02-15  Tom Tromey  <tromey@adacore.com>
7458
7459         * target.h (push_target): Declare new overload.
7460         * target.c (push_target): New overload, taking an rvalue reference.
7461         * remote.c (remote_target::open_1): Use push_target overload.
7462         * corelow.c (core_target_open): Use push_target overload.
7463
7464 2019-02-15  Tom Tromey  <tromey@adacore.com>
7465
7466         * ravenscar-thread.c (is_ravenscar_task)
7467         (ravenscar_task_is_currently_active): Return bool.
7468         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7469         (_initialize_ravenscar): Remove "(void)".
7470         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7471         Return bool.
7472
7473 2019-02-15  Tom Tromey  <tromey@adacore.com>
7474
7475         * ravenscar-thread.c (ravenscar_runtime_initializer)
7476         (has_ravenscar_runtime, get_running_thread_id)
7477         (ravenscar_thread_target::resume): Fix indentation.
7478
7479 2019-02-15  Tom Tromey  <tromey@adacore.com>
7480
7481         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7482         from ravenscar_arch_ops.
7483         (sparc_ravenscar_ops::fetch_registers)
7484         (sparc_ravenscar_ops::store_registers): Now methods.
7485         (sparc_ravenscar_prepare_to_store): Remove.
7486         (sparc_ravenscar_ops): Redefine.
7487         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7488         methods and destructor.  Remove members.
7489         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7490         (ravenscar_thread_target::store_registers)
7491         (ravenscar_thread_target::prepare_to_store): Update.
7492         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7493         Remove.
7494         (struct ppc_ravenscar_powerpc_ops): Derive from
7495         ravenscar_arch_ops.
7496         (ppc_ravenscar_powerpc_ops::fetch_registers)
7497         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7498         (ppc_ravenscar_powerpc_ops): Redefine.
7499         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7500         (ppc_ravenscar_e500_ops::fetch_registers)
7501         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7502         (ppc_ravenscar_e500_ops): Redefine.
7503         * aarch64-ravenscar-thread.c
7504         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7505         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7506         (aarch64_ravenscar_fetch_registers)
7507         (aarch64_ravenscar_store_registers): Now methods.
7508         (aarch64_ravenscar_ops): Redefine.
7509
7510 2019-02-15  Tom Tromey  <tromey@adacore.com>
7511
7512         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7513         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7514         (ravenscar_thread_target::stopped_by_watchpoint)
7515         (ravenscar_thread_target::stopped_data_address)
7516         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7517
7518 2019-02-15  Tom Tromey  <tromey@adacore.com>
7519
7520         * ravenscar-thread.c: Fix some typos.
7521
7522 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7523             Tom Tromey  <tromey@adacore.com>
7524
7525         * ada-lang.c (ada_exception_sal): Change addr_string to a
7526         std::string.
7527         (create_ada_exception_catchpoint): Update.
7528
7529 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7530             Tom Tromey  <tromey@adacore.com>
7531
7532         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7533         (bp_location_ops): Remove.
7534         (base_breakpoint_allocate_location): Update.
7535         (free_bp_location): Update.
7536         * ada-lang.c (class ada_catchpoint_location)
7537         <ada_catchpoint_location>: Remove ops parameter.
7538         (ada_catchpoint_location_dtor): Remove.
7539         (ada_catchpoint_location_ops): Remove.
7540         (allocate_location_exception): Update.
7541         * breakpoint.h (struct bp_location_ops): Remove.
7542         (class bp_location) <bp_location>: Remove bp_location_ops
7543         parameter.
7544         <~bp_location>: Add destructor.
7545         <ops>: Remove.
7546
7547 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7548             Pedro Alves  <palves@redhat.com>
7549
7550         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7551         'PATH_MAX'.
7552
7553 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7554             Samuel Thibault  <samuel.thibault@gnu.org>
7555             Thomas Schwinge  <thomas@codesourcery.com>
7556
7557         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7558         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7559
7560 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7561
7562         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7563         (check_empty): Use "const char *".
7564
7565         * gnu-nat.c (gnu_nat_target::detach): Instead of
7566         'detach_inferior (pid)' call
7567         'detach_inferior (find_inferior_pid (pid))'.
7568
7569         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7570         'nat/fork-inferior.o'.
7571         * gnu-nat.c: #include "nat/fork-inferior.h".
7572
7573         * gnu-nat.c (gnu_nat_target::detach): Instead of
7574         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7575         * gnu-nat.h: #include "inf-child.h".
7576         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7577         'i386_gnu_nat_target::fetch_registers'.
7578         (gnu_store_registers): Rename/move to
7579         'i386_gnu_nat_target::store_registers'.
7580
7581         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7582         * gnu-nat.h (mach_thread_info): New function.
7583         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7584
7585         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7586
7587 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7588
7589         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7590
7591 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7592
7593         * windows-nat.c (windows_add_thread): Add new parameter
7594         "main_thread_p" with default value set to false.  Update
7595         function documentation as well as all callers.
7596         (windows_delete_thread): Likewise.
7597         (fake_create_process): Update call to windows_add_thread.
7598         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7599         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7600         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7601         call to windows_delete_thread.
7602
7603 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7604
7605         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7606
7607 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7608
7609         * symfile.c (find_separate_debug_file): Use canonical path of
7610         sysroot with child_path instead of gdb_sysroot if it is valid.
7611
7612 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7613
7614         * symfile.c (find_separate_debug_file): Use child_path to
7615         determine if an object file is under a sysroot.
7616
7617 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7618
7619         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7620         unittests/child-path-selftests.c.
7621         * common/pathstuff.c (child_path): New function.
7622         * common/pathstuff.h (child_path): New prototype.
7623         * unittests/child-path-selftests.c: New file.
7624
7625 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7626
7627         * symfile.c (find_separate_debug_file): Look for separate debug
7628         files in debug directories under the sysroot.
7629
7630 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7631
7632         * symtab.h (struct minimal_symbol data_p): New const method.
7633         (struct minimal_symbol text_p): Likewise.
7634         * symtab.c (output_source_filename): Use file name style
7635         to print file name.
7636         (print_symbol_info): Likewise.
7637         (print_msymbol_info): Use address style to print addresses.
7638         Use function name style to print executable text symbols.
7639         (expand_symtab_containing_pc): Use data_p.
7640         (find_pc_sect_compunit_symtab): Likewise.
7641
7642 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7643
7644         * breakpoint.c (describe_other_breakpoints): Use address style
7645         to print addresses.
7646         (say_where): Likewise.
7647
7648 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7649
7650         * ada-typeprint.c (print_func_type): Print function name
7651         style to print function name.
7652         * c-typeprint.c (c_print_type_1): Likewise.
7653
7654 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7655
7656         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7657         for execve.
7658
7659 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7660
7661         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7662         type_stack.
7663
7664 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7665
7666         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7667         TYPE_CODE_REF types.
7668
7669 2019-02-08  Jim Wilson  <jimw@sifive.com>
7670
7671         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7672         (riscv_linux_fregset): New.
7673         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7674
7675 2019-02-07  Tom Tromey  <tom@tromey.com>
7676
7677         * thread.c (thread_cancel_execution_command): Update.
7678         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7679         methods.
7680         (struct thread_fsm_ops): Remove.
7681         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7682         (thread_fsm_should_stop, thread_fsm_return_value)
7683         (thread_fsm_set_finished, thread_fsm_finished_p)
7684         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7685         Don't declare.
7686         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7687         * infrun.c (clear_proceed_status_thread)
7688         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7689         (print_stop_event): Update.
7690         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7691         Add constructor.
7692         (step_command_fsm_ops): Remove.
7693         (new_step_command_fsm): Remove.
7694         (step_1): Update.
7695         (step_command_fsm::should_stop): Rename from
7696         step_command_fsm_should_stop.
7697         (step_command_fsm::clean_up): Rename from
7698         step_command_fsm_clean_up.
7699         (step_command_fsm::do_async_reply_reason): Rename from
7700         step_command_fsm_async_reply_reason.
7701         (struct until_next_fsm): Inherit from thread_fsm.  Add
7702         constructor.
7703         (until_next_fsm_ops): Remove.
7704         (new_until_next_fsm): Remove.
7705         (until_next_fsm::should_stop): Rename from
7706         until_next_fsm_should_stop.
7707         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7708         (until_next_fsm::do_async_reply_reason): Rename from
7709         until_next_fsm_async_reply_reason.
7710         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7711         constructor.  Change type of breakpoint.
7712         (finish_command_fsm_ops): Remove.
7713         (new_finish_command_fsm): Remove.
7714         (finish_command_fsm::should_stop): Rename from
7715         finish_command_fsm_should_stop.
7716         (finish_command_fsm::clean_up): Rename from
7717         finish_command_fsm_clean_up.
7718         (finish_command_fsm::return_value): Rename from
7719         finish_command_fsm_return_value.
7720         (finish_command_fsm::do_async_reply_reason): Rename from
7721         finish_command_fsm_async_reply_reason.
7722         (finish_command): Update.
7723         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7724         Add constructor.
7725         (call_thread_fsm_ops): Remove.
7726         (call_thread_fsm::call_thread_fsm): Rename from
7727         new_call_thread_fsm.
7728         (call_thread_fsm::should_stop): Rename from
7729         call_thread_fsm_should_stop.
7730         (call_thread_fsm::should_notify_stop): Rename from
7731         call_thread_fsm_should_notify_stop.
7732         (run_inferior_call, call_function_by_hand_dummy): Update.
7733         * cli/cli-interp.c (should_print_stop_to_console): Update.
7734         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7735         Add constructor.  Change type of location_breakpoint,
7736         caller_breakpoint.
7737         (until_break_fsm_ops): Remove.
7738         (new_until_break_fsm): Remove.
7739         (until_break_fsm::should_stop): Rename from
7740         until_break_fsm_should_stop.
7741         (until_break_fsm::clean_up): Rename from
7742         until_break_fsm_clean_up.
7743         (until_break_fsm::do_async_reply_reason): Rename from
7744         until_break_fsm_async_reply_reason.
7745         (until_break_command): Update.
7746         * thread-fsm.c: Remove.
7747         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7748
7749 2019-02-07  Tom Tromey  <tom@tromey.com>
7750
7751         * yy-remap.h: Add include guard.
7752         * xtensa-tdep.h: Add include guard.
7753         * xcoffread.h: Rename include guard.
7754         * varobj-iter.h: Add include guard.
7755         * tui/tui.h: Rename include guard.
7756         * tui/tui-winsource.h: Rename include guard.
7757         * tui/tui-wingeneral.h: Rename include guard.
7758         * tui/tui-windata.h: Rename include guard.
7759         * tui/tui-win.h: Rename include guard.
7760         * tui/tui-stack.h: Rename include guard.
7761         * tui/tui-source.h: Rename include guard.
7762         * tui/tui-regs.h: Rename include guard.
7763         * tui/tui-out.h: Rename include guard.
7764         * tui/tui-layout.h: Rename include guard.
7765         * tui/tui-io.h: Rename include guard.
7766         * tui/tui-hooks.h: Rename include guard.
7767         * tui/tui-file.h: Rename include guard.
7768         * tui/tui-disasm.h: Rename include guard.
7769         * tui/tui-data.h: Rename include guard.
7770         * tui/tui-command.h: Rename include guard.
7771         * tic6x-tdep.h: Add include guard.
7772         * target/waitstatus.h: Rename include guard.
7773         * target/wait.h: Rename include guard.
7774         * target/target.h: Rename include guard.
7775         * target/resume.h: Rename include guard.
7776         * target-float.h: Rename include guard.
7777         * stabsread.h: Add include guard.
7778         * rs6000-tdep.h: Add include guard.
7779         * riscv-fbsd-tdep.h: Add include guard.
7780         * regformats/regdef.h: Rename include guard.
7781         * record.h: Rename include guard.
7782         * python/python.h: Rename include guard.
7783         * python/python-internal.h: Rename include guard.
7784         * python/py-stopevent.h: Rename include guard.
7785         * python/py-ref.h: Rename include guard.
7786         * python/py-record.h: Rename include guard.
7787         * python/py-record-full.h: Rename include guard.
7788         * python/py-record-btrace.h: Rename include guard.
7789         * python/py-instruction.h: Rename include guard.
7790         * python/py-events.h: Rename include guard.
7791         * python/py-event.h: Rename include guard.
7792         * procfs.h: Add include guard.
7793         * proc-utils.h: Add include guard.
7794         * p-lang.h: Add include guard.
7795         * or1k-tdep.h: Rename include guard.
7796         * observable.h: Rename include guard.
7797         * nto-tdep.h: Rename include guard.
7798         * nat/x86-linux.h: Rename include guard.
7799         * nat/x86-linux-dregs.h: Rename include guard.
7800         * nat/x86-gcc-cpuid.h: Add include guard.
7801         * nat/x86-dregs.h: Rename include guard.
7802         * nat/x86-cpuid.h: Rename include guard.
7803         * nat/ppc-linux.h: Rename include guard.
7804         * nat/mips-linux-watch.h: Rename include guard.
7805         * nat/linux-waitpid.h: Rename include guard.
7806         * nat/linux-ptrace.h: Rename include guard.
7807         * nat/linux-procfs.h: Rename include guard.
7808         * nat/linux-osdata.h: Rename include guard.
7809         * nat/linux-nat.h: Rename include guard.
7810         * nat/linux-namespaces.h: Rename include guard.
7811         * nat/linux-btrace.h: Rename include guard.
7812         * nat/glibc_thread_db.h: Rename include guard.
7813         * nat/gdb_thread_db.h: Rename include guard.
7814         * nat/gdb_ptrace.h: Rename include guard.
7815         * nat/fork-inferior.h: Rename include guard.
7816         * nat/amd64-linux-siginfo.h: Rename include guard.
7817         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7818         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7819         * nat/aarch64-linux.h: Rename include guard.
7820         * nat/aarch64-linux-hw-point.h: Rename include guard.
7821         * mn10300-tdep.h: Add include guard.
7822         * mips-linux-tdep.h: Add include guard.
7823         * mi/mi-parse.h: Rename include guard.
7824         * mi/mi-out.h: Rename include guard.
7825         * mi/mi-main.h: Rename include guard.
7826         * mi/mi-interp.h: Rename include guard.
7827         * mi/mi-getopt.h: Rename include guard.
7828         * mi/mi-console.h: Rename include guard.
7829         * mi/mi-common.h: Rename include guard.
7830         * mi/mi-cmds.h: Rename include guard.
7831         * mi/mi-cmd-break.h: Rename include guard.
7832         * m2-lang.h: Add include guard.
7833         * location.h: Rename include guard.
7834         * linux-record.h: Rename include guard.
7835         * linux-nat.h: Add include guard.
7836         * linux-fork.h: Add include guard.
7837         * i386-darwin-tdep.h: Rename include guard.
7838         * hppa-linux-offsets.h: Add include guard.
7839         * guile/guile.h: Rename include guard.
7840         * guile/guile-internal.h: Rename include guard.
7841         * gnu-nat.h: Rename include guard.
7842         * gdb-stabs.h: Rename include guard.
7843         * frv-tdep.h: Add include guard.
7844         * f-lang.h: Add include guard.
7845         * event-loop.h: Add include guard.
7846         * darwin-nat.h: Rename include guard.
7847         * cp-abi.h: Rename include guard.
7848         * config/sparc/nm-sol2.h: Rename include guard.
7849         * config/nm-nto.h: Rename include guard.
7850         * config/nm-linux.h: Add include guard.
7851         * config/i386/nm-i386gnu.h: Rename include guard.
7852         * config/djgpp/nl_types.h: Rename include guard.
7853         * config/djgpp/langinfo.h: Rename include guard.
7854         * compile/gcc-cp-plugin.h: Add include guard.
7855         * compile/gcc-c-plugin.h: Add include guard.
7856         * compile/compile.h: Rename include guard.
7857         * compile/compile-object-run.h: Rename include guard.
7858         * compile/compile-object-load.h: Rename include guard.
7859         * compile/compile-internal.h: Rename include guard.
7860         * compile/compile-cplus.h: Rename include guard.
7861         * compile/compile-c.h: Rename include guard.
7862         * common/xml-utils.h: Rename include guard.
7863         * common/x86-xstate.h: Rename include guard.
7864         * common/version.h: Rename include guard.
7865         * common/vec.h: Rename include guard.
7866         * common/tdesc.h: Rename include guard.
7867         * common/selftest.h: Rename include guard.
7868         * common/scoped_restore.h: Rename include guard.
7869         * common/scoped_mmap.h: Rename include guard.
7870         * common/scoped_fd.h: Rename include guard.
7871         * common/safe-iterator.h: Rename include guard.
7872         * common/run-time-clock.h: Rename include guard.
7873         * common/refcounted-object.h: Rename include guard.
7874         * common/queue.h: Rename include guard.
7875         * common/ptid.h: Rename include guard.
7876         * common/print-utils.h: Rename include guard.
7877         * common/preprocessor.h: Rename include guard.
7878         * common/pathstuff.h: Rename include guard.
7879         * common/observable.h: Rename include guard.
7880         * common/netstuff.h: Rename include guard.
7881         * common/job-control.h: Rename include guard.
7882         * common/host-defs.h: Rename include guard.
7883         * common/gdb_wait.h: Rename include guard.
7884         * common/gdb_vecs.h: Rename include guard.
7885         * common/gdb_unlinker.h: Rename include guard.
7886         * common/gdb_unique_ptr.h: Rename include guard.
7887         * common/gdb_tilde_expand.h: Rename include guard.
7888         * common/gdb_sys_time.h: Rename include guard.
7889         * common/gdb_string_view.h: Rename include guard.
7890         * common/gdb_splay_tree.h: Rename include guard.
7891         * common/gdb_setjmp.h: Rename include guard.
7892         * common/gdb_ref_ptr.h: Rename include guard.
7893         * common/gdb_optional.h: Rename include guard.
7894         * common/gdb_locale.h: Rename include guard.
7895         * common/gdb_assert.h: Rename include guard.
7896         * common/filtered-iterator.h: Rename include guard.
7897         * common/filestuff.h: Rename include guard.
7898         * common/fileio.h: Rename include guard.
7899         * common/environ.h: Rename include guard.
7900         * common/common-utils.h: Rename include guard.
7901         * common/common-types.h: Rename include guard.
7902         * common/common-regcache.h: Rename include guard.
7903         * common/common-inferior.h: Rename include guard.
7904         * common/common-gdbthread.h: Rename include guard.
7905         * common/common-exceptions.h: Rename include guard.
7906         * common/common-defs.h: Rename include guard.
7907         * common/common-debug.h: Rename include guard.
7908         * common/cleanups.h: Rename include guard.
7909         * common/buffer.h: Rename include guard.
7910         * common/btrace-common.h: Rename include guard.
7911         * common/break-common.h: Rename include guard.
7912         * cli/cli-utils.h: Rename include guard.
7913         * cli/cli-style.h: Rename include guard.
7914         * cli/cli-setshow.h: Rename include guard.
7915         * cli/cli-script.h: Rename include guard.
7916         * cli/cli-interp.h: Rename include guard.
7917         * cli/cli-decode.h: Rename include guard.
7918         * cli/cli-cmds.h: Rename include guard.
7919         * charset-list.h: Add include guard.
7920         * buildsym-legacy.h: Rename include guard.
7921         * bfin-tdep.h: Add include guard.
7922         * ax.h: Rename include guard.
7923         * arm-linux-tdep.h: Add include guard.
7924         * arm-fbsd-tdep.h: Add include guard.
7925         * arch/xtensa.h: Rename include guard.
7926         * arch/tic6x.h: Add include guard.
7927         * arch/i386.h: Add include guard.
7928         * arch/arm.h: Rename include guard.
7929         * arch/arm-linux.h: Rename include guard.
7930         * arch/arm-get-next-pcs.h: Rename include guard.
7931         * arch/amd64.h: Add include guard.
7932         * arch/aarch64-insn.h: Rename include guard.
7933         * arch-utils.h: Rename include guard.
7934         * annotate.h: Add include guard.
7935         * amd64-darwin-tdep.h: Rename include guard.
7936         * aarch64-linux-tdep.h: Add include guard.
7937         * aarch64-fbsd-tdep.h: Add include guard.
7938         * aarch32-linux-nat.h: Add include guard.
7939
7940 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7941
7942         * macrotab.c (macro_define_internal): New function that
7943         factorizes macro_define_object_internal and macro_define_function
7944         code.
7945         (macro_define_object_internal): Use macro_define_internal.
7946         (macro_define_function): Likewise.
7947
7948 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7949
7950         * macrocmd.c (extract_identifier): Return
7951         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7952         callers.
7953
7954 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7955
7956         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7957
7958 2019-02-05  Tom Tromey  <tom@tromey.com>
7959
7960         * target.c (target_stack::unpush): Move assertion earlier.
7961
7962 2019-01-30  Tom Tromey  <tom@tromey.com>
7963
7964         PR python/23615:
7965         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7966         (gdbpy_parse_and_eval): Likewise.
7967         * python/python-internal.h (gdbpy_allow_threads): New class.
7968
7969 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7970
7971         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7972         (aarch64_fbsd_fpregmap): Move earlier.
7973         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7974         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7975         instead of individual calls to trad_frame_set_reg_addr.
7976         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7977         earlier.
7978         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7979         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7980         instead of individual calls to trad_frame_set_reg_addr.
7981
7982 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7983
7984         * CONTRIBUTE: Replace contribution list with wiki link.
7985
7986 2019-01-25  Tom Tromey  <tom@tromey.com>
7987
7988         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7989
7990 2019-01-25  Tom Tromey  <tom@tromey.com>
7991
7992         * xtensa-linux-nat.c: Fix common/ includes.
7993         * xml-support.h: Fix common/ includes.
7994         * xml-support.c: Fix common/ includes.
7995         * x86-linux-nat.c: Fix common/ includes.
7996         * windows-nat.c: Fix common/ includes.
7997         * varobj.h: Fix common/ includes.
7998         * varobj.c: Fix common/ includes.
7999         * value.c: Fix common/ includes.
8000         * valops.c: Fix common/ includes.
8001         * utils.c: Fix common/ includes.
8002         * unittests/xml-utils-selftests.c: Fix common/ includes.
8003         * unittests/utils-selftests.c: Fix common/ includes.
8004         * unittests/unpack-selftests.c: Fix common/ includes.
8005         * unittests/tracepoint-selftests.c: Fix common/ includes.
8006         * unittests/style-selftests.c: Fix common/ includes.
8007         * unittests/string_view-selftests.c: Fix common/ includes.
8008         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8009         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8010         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8011         * unittests/rsp-low-selftests.c: Fix common/ includes.
8012         * unittests/parse-connection-spec-selftests.c: Fix common/
8013         includes.
8014         * unittests/optional-selftests.c: Fix common/ includes.
8015         * unittests/offset-type-selftests.c: Fix common/ includes.
8016         * unittests/observable-selftests.c: Fix common/ includes.
8017         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8018         * unittests/memrange-selftests.c: Fix common/ includes.
8019         * unittests/memory-map-selftests.c: Fix common/ includes.
8020         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8021         * unittests/function-view-selftests.c: Fix common/ includes.
8022         * unittests/environ-selftests.c: Fix common/ includes.
8023         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8024         * unittests/common-utils-selftests.c: Fix common/ includes.
8025         * unittests/cli-utils-selftests.c: Fix common/ includes.
8026         * unittests/array-view-selftests.c: Fix common/ includes.
8027         * ui-file.c: Fix common/ includes.
8028         * tui/tui-io.c: Fix common/ includes.
8029         * tracepoint.h: Fix common/ includes.
8030         * tracepoint.c: Fix common/ includes.
8031         * tracefile-tfile.c: Fix common/ includes.
8032         * top.h: Fix common/ includes.
8033         * top.c: Fix common/ includes.
8034         * thread.c: Fix common/ includes.
8035         * target/waitstatus.h: Fix common/ includes.
8036         * target/waitstatus.c: Fix common/ includes.
8037         * target.h: Fix common/ includes.
8038         * target.c: Fix common/ includes.
8039         * target-memory.c: Fix common/ includes.
8040         * target-descriptions.c: Fix common/ includes.
8041         * symtab.h: Fix common/ includes.
8042         * symfile.c: Fix common/ includes.
8043         * stap-probe.c: Fix common/ includes.
8044         * spu-linux-nat.c: Fix common/ includes.
8045         * sparc-nat.c: Fix common/ includes.
8046         * source.c: Fix common/ includes.
8047         * solib.c: Fix common/ includes.
8048         * solib-target.c: Fix common/ includes.
8049         * ser-unix.c: Fix common/ includes.
8050         * ser-tcp.c: Fix common/ includes.
8051         * ser-pipe.c: Fix common/ includes.
8052         * ser-base.c: Fix common/ includes.
8053         * selftest-arch.c: Fix common/ includes.
8054         * s12z-tdep.c: Fix common/ includes.
8055         * rust-exp.y: Fix common/ includes.
8056         * rs6000-aix-tdep.c: Fix common/ includes.
8057         * riscv-tdep.c: Fix common/ includes.
8058         * remote.c: Fix common/ includes.
8059         * remote-notif.h: Fix common/ includes.
8060         * remote-fileio.h: Fix common/ includes.
8061         * remote-fileio.c: Fix common/ includes.
8062         * regcache.h: Fix common/ includes.
8063         * regcache.c: Fix common/ includes.
8064         * record-btrace.c: Fix common/ includes.
8065         * python/python.c: Fix common/ includes.
8066         * python/py-type.c: Fix common/ includes.
8067         * python/py-inferior.c: Fix common/ includes.
8068         * progspace.h: Fix common/ includes.
8069         * producer.c: Fix common/ includes.
8070         * procfs.c: Fix common/ includes.
8071         * proc-api.c: Fix common/ includes.
8072         * printcmd.c: Fix common/ includes.
8073         * ppc-linux-nat.c: Fix common/ includes.
8074         * parser-defs.h: Fix common/ includes.
8075         * osdata.c: Fix common/ includes.
8076         * obsd-nat.c: Fix common/ includes.
8077         * nat/x86-linux.c: Fix common/ includes.
8078         * nat/x86-linux-dregs.c: Fix common/ includes.
8079         * nat/x86-dregs.h: Fix common/ includes.
8080         * nat/x86-dregs.c: Fix common/ includes.
8081         * nat/ppc-linux.c: Fix common/ includes.
8082         * nat/mips-linux-watch.h: Fix common/ includes.
8083         * nat/mips-linux-watch.c: Fix common/ includes.
8084         * nat/linux-waitpid.c: Fix common/ includes.
8085         * nat/linux-ptrace.h: Fix common/ includes.
8086         * nat/linux-ptrace.c: Fix common/ includes.
8087         * nat/linux-procfs.c: Fix common/ includes.
8088         * nat/linux-personality.c: Fix common/ includes.
8089         * nat/linux-osdata.c: Fix common/ includes.
8090         * nat/linux-namespaces.c: Fix common/ includes.
8091         * nat/linux-btrace.h: Fix common/ includes.
8092         * nat/linux-btrace.c: Fix common/ includes.
8093         * nat/fork-inferior.c: Fix common/ includes.
8094         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8095         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8096         * nat/aarch64-linux.c: Fix common/ includes.
8097         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8098         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8099         * namespace.h: Fix common/ includes.
8100         * mips-linux-tdep.c: Fix common/ includes.
8101         * minsyms.c: Fix common/ includes.
8102         * mi/mi-parse.h: Fix common/ includes.
8103         * mi/mi-main.c: Fix common/ includes.
8104         * mi/mi-cmd-env.c: Fix common/ includes.
8105         * memrange.h: Fix common/ includes.
8106         * memattr.c: Fix common/ includes.
8107         * maint.h: Fix common/ includes.
8108         * maint.c: Fix common/ includes.
8109         * main.c: Fix common/ includes.
8110         * machoread.c: Fix common/ includes.
8111         * location.c: Fix common/ includes.
8112         * linux-thread-db.c: Fix common/ includes.
8113         * linux-nat.c: Fix common/ includes.
8114         * linux-fork.c: Fix common/ includes.
8115         * inline-frame.c: Fix common/ includes.
8116         * infrun.c: Fix common/ includes.
8117         * inflow.c: Fix common/ includes.
8118         * inferior.h: Fix common/ includes.
8119         * inferior.c: Fix common/ includes.
8120         * infcmd.c: Fix common/ includes.
8121         * inf-ptrace.c: Fix common/ includes.
8122         * inf-child.c: Fix common/ includes.
8123         * ia64-linux-nat.c: Fix common/ includes.
8124         * i387-tdep.c: Fix common/ includes.
8125         * i386-tdep.c: Fix common/ includes.
8126         * i386-linux-tdep.c: Fix common/ includes.
8127         * i386-linux-nat.c: Fix common/ includes.
8128         * i386-go32-tdep.c: Fix common/ includes.
8129         * i386-fbsd-tdep.c: Fix common/ includes.
8130         * i386-fbsd-nat.c: Fix common/ includes.
8131         * guile/scm-type.c: Fix common/ includes.
8132         * guile/guile.c: Fix common/ includes.
8133         * go32-nat.c: Fix common/ includes.
8134         * gnu-nat.c: Fix common/ includes.
8135         * gdbthread.h: Fix common/ includes.
8136         * gdbarch-selftests.c: Fix common/ includes.
8137         * gdb_usleep.c: Fix common/ includes.
8138         * gdb_select.h: Fix common/ includes.
8139         * gdb_bfd.c: Fix common/ includes.
8140         * gcore.c: Fix common/ includes.
8141         * fork-child.c: Fix common/ includes.
8142         * findvar.c: Fix common/ includes.
8143         * fbsd-nat.c: Fix common/ includes.
8144         * event-top.c: Fix common/ includes.
8145         * event-loop.c: Fix common/ includes.
8146         * dwarf2read.c: Fix common/ includes.
8147         * dwarf2loc.c: Fix common/ includes.
8148         * dwarf2-frame.c: Fix common/ includes.
8149         * dwarf-index-cache.c: Fix common/ includes.
8150         * dtrace-probe.c: Fix common/ includes.
8151         * disasm-selftests.c: Fix common/ includes.
8152         * defs.h: Fix common/ includes.
8153         * csky-tdep.c: Fix common/ includes.
8154         * cp-valprint.c: Fix common/ includes.
8155         * cp-support.h: Fix common/ includes.
8156         * cp-support.c: Fix common/ includes.
8157         * corelow.c: Fix common/ includes.
8158         * completer.h: Fix common/ includes.
8159         * completer.c: Fix common/ includes.
8160         * compile/compile.c: Fix common/ includes.
8161         * compile/compile-loc2c.c: Fix common/ includes.
8162         * compile/compile-cplus-types.c: Fix common/ includes.
8163         * compile/compile-cplus-symbols.c: Fix common/ includes.
8164         * command.h: Fix common/ includes.
8165         * cli/cli-dump.c: Fix common/ includes.
8166         * cli/cli-cmds.c: Fix common/ includes.
8167         * charset.c: Fix common/ includes.
8168         * build-id.c: Fix common/ includes.
8169         * btrace.h: Fix common/ includes.
8170         * btrace.c: Fix common/ includes.
8171         * breakpoint.h: Fix common/ includes.
8172         * breakpoint.c: Fix common/ includes.
8173         * ax.h:
8174         (enum agent_op): Fix common/ includes.
8175         * ax-general.c (struct aop_map): Fix common/ includes.
8176         * ax-gdb.c: Fix common/ includes.
8177         * auxv.c: Fix common/ includes.
8178         * auto-load.c: Fix common/ includes.
8179         * arm-tdep.c: Fix common/ includes.
8180         * arch/riscv.c: Fix common/ includes.
8181         * arch/ppc-linux-common.c: Fix common/ includes.
8182         * arch/i386.c: Fix common/ includes.
8183         * arch/arm.c: Fix common/ includes.
8184         * arch/arm-linux.c: Fix common/ includes.
8185         * arch/arm-get-next-pcs.c: Fix common/ includes.
8186         * arch/amd64.c: Fix common/ includes.
8187         * arch/aarch64.c: Fix common/ includes.
8188         * arch/aarch64-insn.c: Fix common/ includes.
8189         * arch-utils.c: Fix common/ includes.
8190         * amd64-windows-tdep.c: Fix common/ includes.
8191         * amd64-tdep.c: Fix common/ includes.
8192         * amd64-sol2-tdep.c: Fix common/ includes.
8193         * amd64-obsd-tdep.c: Fix common/ includes.
8194         * amd64-nbsd-tdep.c: Fix common/ includes.
8195         * amd64-linux-tdep.c: Fix common/ includes.
8196         * amd64-linux-nat.c: Fix common/ includes.
8197         * amd64-fbsd-tdep.c: Fix common/ includes.
8198         * amd64-fbsd-nat.c: Fix common/ includes.
8199         * amd64-dicos-tdep.c: Fix common/ includes.
8200         * amd64-darwin-tdep.c: Fix common/ includes.
8201         * agent.c: Fix common/ includes.
8202         * ada-lang.h: Fix common/ includes.
8203         * ada-lang.c: Fix common/ includes.
8204         * aarch64-tdep.c: Fix common/ includes.
8205
8206 2019-01-25  Tom Tromey  <tom@tromey.com>
8207
8208         * common/create-version.sh: Use common/version.h.
8209
8210 2019-01-24  Pedro Alves  <palves@redhat.com>
8211
8212         * infrun.c (signal_stop, signal_print, signal_program)
8213         (signal_catch, signal_pass): Now arrays instead of pointers.
8214         (update_signals_program_target, do_target_resume)
8215         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8216         * linux-nat.c (linux_nat_target::pass_signals)
8217         (linux_nat_target::create_inferior, linux_nat_target::attach):
8218         Adjust.
8219         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8220         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8221         * procfs.c (procfs_target::pass_signals): Adjust.
8222         * record-full.c (record_full_target::resume): Adjust.
8223         * remote.c (remote_target::pass_signals)
8224         (remote_target::program_signals): Adjust.
8225         * target-debug.h (target_debug_print_signals): Now takes a
8226         gdb::array_view as parameter.  Adjust.
8227         * target.h (target_ops) <pass_signals, program_signals>: Replace
8228         pointer and length parameters with gdb::array_view.
8229         (target_pass_signals, target_program_signals): Likewise.
8230         * target-delegates.c: Regenerate.
8231
8232 2019-01-24  Pedro Alves  <palves@redhat.com>
8233
8234         * common/forward-scope-exit.h
8235         (forward_scope_exit::forward_scope_exit): Pass arguments to
8236         m_bind_function directly, instead of creating a std::bind and
8237         copying that.
8238
8239 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8240
8241         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8242         for static members.
8243         (pass_in_v_vfp_candidate): Likewise.
8244
8245 2019-01-23  Tom Tromey  <tom@tromey.com>
8246             Pedro Alves  <palves@redhat.com>
8247
8248         * regcache.c (class regcache_invalidator): Remove.
8249         (regcache::raw_write): Use make_scope_exit.
8250
8251 2019-01-23  Tom Tromey  <tom@tromey.com>
8252
8253         * ui-out.h (class ui_out_emit_type): Update comment.
8254
8255 2019-01-23  Tom Tromey  <tom@tromey.com>
8256
8257         * infrun.c (fetch_inferior_event): Update comment.
8258
8259 2019-01-23  Tom Tromey  <tom@tromey.com>
8260             Pedro Alves  <palves@redhat.com>
8261
8262         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8263         parameter.
8264         (fetch_inferior_event): Use SCOPE_EXIT.
8265
8266
8267 2019-01-23  Tom Tromey  <tom@tromey.com>
8268             Pedro Alves  <palves@redhat.com>
8269
8270         * infrun.c (disable_thread_events): Delete.
8271         (stop_all_threads): Use SCOPE_EXIT.
8272
8273 2019-01-23  Tom Tromey  <tom@tromey.com>
8274             Pedro Alves  <palves@redhat.com>
8275
8276         * symfile.c: Include forward-scope-exit.h.
8277         (clear_symtab_users_cleanup): Replace forward declaration with
8278         a FORWARD_SCOPE_EXIT.
8279         (syms_from_objfile_1): Use the forward_scope_exit and
8280         gdb::optional instead of cleanup_function.
8281         (reread_symbols): Use the forward_scope_exit instead of
8282         cleanup_function.
8283         (clear_symtab_users_cleanup): Remove function.
8284
8285 2019-01-23  Tom Tromey  <tom@tromey.com>
8286             Pedro Alves  <palves@redhat.com>
8287
8288         * linux-nat.c: Include scope-exit.h.
8289         (cleanup_target_stop): Remove.
8290         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8291         SCOPE_EXIT.
8292
8293 2019-01-23  Tom Tromey  <tom@tromey.com>
8294             Pedro Alves  <palves@redhat.com>
8295
8296         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8297         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8298
8299 2019-01-23  Tom Tromey  <tom@tromey.com>
8300             Andrew Burgess  <andrew.burgess@embecosm.com>
8301             Pedro Alves  <palves@redhat.com>
8302
8303         * infrun.c (fetch_inferior_event): Use scope_exit.
8304         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8305         * top.c (execute_command): Use scope_exit.
8306         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8307         * utils.c (do_bpstat_clear_actions_cleanup)
8308         (make_bpstat_clear_actions_cleanup): Remove.
8309
8310 2019-01-23  Tom Tromey  <tom@tromey.com>
8311             Pedro Alves  <palves@redhat.com>
8312
8313         * infrun.c: Include "common/scope-exit.h"
8314         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8315         (wait_for_inferior): Use SCOPE_EXIT.
8316         (fetch_inferior_event): Use scope_exit.
8317
8318 2019-01-23  Tom Tromey  <tom@tromey.com>
8319             Pedro Alves  <palves@redhat.com>
8320
8321         * breakpoint.c (create_breakpoint): Remove cleanup.
8322
8323 2019-01-23  Tom Tromey  <tom@tromey.com>
8324             Andrew Burgess  <andrew.burgess@embecosm.com>
8325             Pedro Alves  <palves@redhat.com>
8326
8327 2019-01-23  Pedro Alves  <palves@redhat.com>
8328
8329         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8330
8331 2019-01-23  Pedro Alves  <palves@redhat.com>
8332             Andrew Burgess  <andrew.burgess@embecosm.com>
8333
8334         * gdbthread.h: Include "common/forward-scope-exit.h".
8335         (scoped_finish_thread_state): Redefine custom class in terms of
8336         forward_scope_exit.
8337
8338 2019-01-23  Pedro Alves  <palves@redhat.com>
8339             Andrew Burgess  <andrew.burgess@embecosm.com>
8340
8341         * common/forward-scope-exit.h: New file.
8342
8343 2019-01-23  Pedro Alves  <palves@redhat.com>
8344             Andrew Burgess  <andrew.burgess@embecosm.com>
8345             Tom Tromey  <tom@tromey.com>
8346
8347         * common/scope-exit.h: New file.
8348
8349 2019-01-23  Pedro Alves  <palves@redhat.com>
8350
8351         * common/preprocessor.h (ESC): Rename to ...
8352         (ESC_PARENS): ... this.
8353         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8354         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8355
8356 2019-01-23  Tom Tromey  <tom@tromey.com>
8357
8358         * language.h (class scoped_switch_to_sym_language_if_auto):
8359         Initialize m_lang in both cases.
8360
8361 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8362
8363         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8364         with XCNEW.
8365
8366 2019-01-22  Tom Tromey  <tom@tromey.com>
8367
8368         * corelow.c: Do not include sys/file.h.
8369
8370 2019-01-22  Tom Tromey  <tom@tromey.com>
8371
8372         * tui/tui-wingeneral.h: Include gdb_curses.h.
8373
8374 2019-01-22  Tom Tromey  <tom@tromey.com>
8375
8376         * source-cache.h (class source_cache) <get_source_lines,
8377         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8378
8379 2019-01-22  Tom Tromey  <tom@tromey.com>
8380
8381         * remote-fileio.h (struct remote_target): Declare.
8382
8383 2019-01-22  Tom Tromey  <tom@tromey.com>
8384
8385         * python/py-arch.c: Do not include py-ref.h.
8386         * python/py-bpevent.c: Do not include py-ref.h.
8387         * python/py-cmd.c: Do not include py-ref.h.
8388         * python/py-continueevent.c: Do not include py-ref.h.
8389         * python/py-event.h: Do not include py-ref.h.
8390         * python/py-evtregistry.c: Do not include py-ref.h.
8391         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8392         * python/py-frame.c: Do not include py-ref.h.
8393         * python/py-framefilter.c: Do not include py-ref.h.
8394         * python/py-function.c: Do not include py-ref.h.
8395         * python/py-infevents.c: Do not include py-ref.h.
8396         * python/py-linetable.c: Do not include py-ref.h.
8397         * python/py-objfile.c: Do not include py-ref.h.
8398         * python/py-param.c: Do not include py-ref.h.
8399         * python/py-prettyprint.c: Do not include py-ref.h.
8400         * python/py-progspace.c: Do not include py-ref.h.
8401         * python/py-symbol.c: Do not include py-ref.h.
8402         * python/py-symtab.c: Do not include py-ref.h.
8403         * python/py-type.c: Do not include py-ref.h.
8404         * python/py-unwind.c: Do not include py-ref.h.
8405         * python/py-utils.c: Do not include py-ref.h.
8406         * python/py-value.c: Do not include py-ref.h.
8407         * python/py-varobj.c: Do not include py-ref.h.
8408         * python/py-xmethods.c: Do not include py-ref.h.
8409         * python/python.c: Do not include py-ref.h.
8410         * varobj.c: Do not include py-ref.h.
8411
8412 2019-01-22  Tom Tromey  <tom@tromey.com>
8413
8414         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8415         keyword for bcache.
8416
8417 2019-01-22  Tom Tromey  <tom@tromey.com>
8418
8419         * compile/compile-cplus-types.c: Remove a comment by #include.
8420
8421 2019-01-22  Tom Tromey  <tom@tromey.com>
8422
8423         * compile/gcc-c-plugin.h: Include compile-internal.h.
8424
8425 2019-01-22  Tom Tromey  <tom@tromey.com>
8426
8427         * stabsread.c (EXTERN): Do not define.
8428         (symnum, next_symbol_text_func, processing_gcc_compilation)
8429         (within_function, global_sym_chain, global_stabs)
8430         (previous_stab_code, this_object_header_files)
8431         (n_this_object_header_files)
8432         (n_allocated_this_object_header_files): Define.
8433         * stabsread.h (EXTERN): Never define.  Use "extern".
8434
8435 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8436
8437         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8438         history_value.
8439
8440 2019-01-21  Tom Tromey  <tom@tromey.com>
8441
8442         * ui-out.c: Fix includes.
8443         * tui/tui-source.c: Fix includes.
8444         * target.c: Fix includes.
8445         * remote.c: Fix includes.
8446         * regcache.c: Fix includes.
8447         * python/py-block.c: Fix includes.
8448         * printcmd.c: Fix includes.
8449         * or1k-tdep.c: Fix includes.
8450         * mi/mi-main.c: Fix includes.
8451         * m32r-tdep.c: Fix includes.
8452         * csky-tdep.c: Fix includes.
8453         * compile/compile-cplus-types.c: Fix includes.
8454         * cli/cli-interp.c: Fix includes.
8455
8456 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8457
8458         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8459         for padding.
8460
8461 2019-01-16  Tom Tromey  <tom@tromey.com>
8462
8463         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8464         earlier.
8465         (struct objfile) <msymbols_range>: Move from top level.
8466         <msymbols>: New method.
8467         (class objfile_msymbols): Remove.
8468         * symtab.c (default_collect_symbol_completion_matches_break_on):
8469         Update.
8470         * symmisc.c (dump_msymbols): Update.
8471         * stabsread.c (scan_file_globals): Update.
8472         * objc-lang.c (info_selectors_command, info_classes_command)
8473         (find_methods): Update.
8474         * minsyms.c (find_solib_trampoline_target): Update.
8475         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8476         * coffread.c (coff_symfile_read): Update.
8477         * ada-lang.c (ada_lookup_simple_minsym)
8478         (ada_collect_symbol_completion_matches): Update.
8479
8480 2019-01-16  Tom Tromey  <tom@tromey.com>
8481
8482         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8483         type.  Remove no-argument constructor.
8484         <iterator::operator++>: Simplify.
8485         <begin>: Update.
8486         <end>: Use minimal_symbol_count.
8487
8488 2019-01-16  Tom Tromey  <tom@tromey.com>
8489
8490         * objfiles.h (struct objfile) <psymtabs>: New method.
8491         (class objfile_psymtabs): Remove.
8492         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8493         typedef.
8494         <range>: New method.
8495         (require_partial_symbols): Change return type.
8496         * psymtab.c (require_partial_symbols)
8497         (psym_expand_symtabs_matching): Update.
8498         * mdebugread.c (parse_partial_symbols): Update.
8499         * dbxread.c (dbx_end_psymtab): Update.
8500
8501 2019-01-15  Tom Tromey  <tom@tromey.com>
8502
8503         * symtab.c (lookup_objfile_from_block)
8504         (lookup_symbol_in_objfile_symtabs)
8505         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8506         (find_line_symtab, info_sources_command)
8507         (default_collect_symbol_completion_matches_break_on)
8508         (make_source_files_completion_list): Update.
8509         * symmisc.c (print_objfile_statistics, dump_objfile)
8510         (maintenance_print_symbols, maintenance_info_symtabs)
8511         (maintenance_check_symtabs, maintenance_info_line_tables):
8512         Update.
8513         * source.c (select_source_symtab)
8514         (forget_cached_source_info_for_objfile): Update.
8515         * objfiles.h (class objfile_compunits): Remove.
8516         (struct objfile) <compunits_range>: New typedef.
8517         (compunits): New method.
8518         * objfiles.c (objfile_relocate1): Update.
8519         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8520         * maint.c (count_symtabs_and_blocks): Update.
8521         * linespec.c (iterate_over_all_matching_symtabs): Update.
8522         * cp-support.c (add_symbol_overload_list_qualified): Update.
8523         * coffread.c (coff_symtab_read): Update.
8524         * ada-lang.c (add_nonlocal_symbols)
8525         (ada_collect_symbol_completion_matches)
8526         (ada_add_global_exceptions): Update.
8527
8528 2019-01-15  Tom Tromey  <tom@tromey.com>
8529
8530         * progspace.h (program_space) <objfiles_safe_range>: New
8531         typedef.
8532         <objfiles_safe>: New method.
8533         * objfiles.h (class all_objfiles_safe): Remove.
8534         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8535         * jit.c (jit_inferior_exit_hook): Update.
8536
8537 2019-01-17  Tom Tromey  <tom@tromey.com>
8538
8539         * progspace.h (program_space) <objfiles_range>: New typedef.
8540         <objfiles>: New method.
8541         <objfiles_head>: Rename from objfiles.
8542         (object_files): Update.
8543         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8544         * guile/scm-pretty-print.c
8545         (ppscm_find_pretty_printer_from_objfiles): Update.
8546         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8547         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8548         Update.
8549         * python/py-progspace.c (pspy_get_objfiles): Update.
8550         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8551         Update.
8552         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8553         (objfpy_lookup_objfile_by_build_id): Update.
8554         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8555         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8556         Update.
8557         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8558         (expand_symtab_containing_pc, lookup_objfile_from_block)
8559         (lookup_static_symbol, basic_lookup_transparent_type)
8560         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8561         (find_line_symtab, info_sources_command)
8562         (default_collect_symbol_completion_matches_break_on)
8563         (make_source_files_completion_list, find_main_name): Update.
8564         * symmisc.c (print_symbol_bcache_statistics)
8565         (print_objfile_statistics, maintenance_print_symbols)
8566         (maintenance_print_msymbols, maintenance_print_objfiles)
8567         (maintenance_info_symtabs, maintenance_check_symtabs)
8568         (maintenance_expand_symtabs, maintenance_info_line_tables):
8569         Update.
8570         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8571         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8572         (map_overlay_command, unmap_overlay_command)
8573         (simple_overlay_update, expand_symtabs_matching)
8574         (map_symbol_filenames): Update.
8575         * symfile-debug.c (set_debug_symfile): Update.
8576         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8577         Update.
8578         * source.c (select_source_symtab, forget_cached_source_info):
8579         Update.
8580         * solib.c (solib_read_symbols): Update.
8581         * solib-spu.c (append_ocl_sos): Update.
8582         * psymtab.c (maintenance_print_psymbols)
8583         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8584         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8585         * printcmd.c (info_symbol_command): Update.
8586         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8587         Update.
8588         * objfiles.h (class all_objfiles): Remove.
8589         * objfiles.c (have_partial_symbols, have_full_symbols)
8590         (have_minimal_symbols, qsort_cmp, update_section_map)
8591         (shared_objfile_contains_address_p)
8592         (default_iterate_over_objfiles_in_search_order): Update.
8593         * objc-lang.c (info_selectors_command, info_classes_command)
8594         (find_methods): Update.
8595         * minsyms.c (find_solib_trampoline_target): Update.
8596         * maint.c (maintenance_info_sections)
8597         (maintenance_translate_address, count_symtabs_and_blocks):
8598         Update.
8599         * main.c (captured_main_1): Update.
8600         * linux-thread-db.c (try_thread_db_load_from_pdir)
8601         (has_libpthread): Update.
8602         * linespec.c (iterate_over_all_matching_symtabs)
8603         (search_minsyms_for_name): Update.
8604         * jit.c (jit_find_objf_with_entry_addr): Update.
8605         * hppa-tdep.c (find_unwind_entry)
8606         (hppa_lookup_stub_minimal_symbol): Update.
8607         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8608         Update.
8609         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8610         (elf_gnu_ifunc_resolve_by_got): Update.
8611         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8612         * dwarf-index-write.c (save_gdb_index_command): Update.
8613         * cp-support.c (add_symbol_overload_list_qualified): Update.
8614         * breakpoint.c (create_overlay_event_breakpoint)
8615         (create_longjmp_master_breakpoint)
8616         (create_std_terminate_master_breakpoint)
8617         (create_exception_master_breakpoint): Update.
8618         * blockframe.c (find_pc_partial_function): Update.
8619         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8620         (ada_collect_symbol_completion_matches)
8621         (ada_add_global_exceptions): Update.
8622
8623 2019-01-17  Tom Tromey  <tom@tromey.com>
8624
8625         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8626         declare VEC.
8627         (solib_target_parse_libraries): Change return type.
8628         (library_list_start_segment, library_list_start_section)
8629         (library_list_end_library, library_list_start_library); Update.
8630         (solib_target_free_library_list): Remove.
8631         (solib_target_parse_libraries): Remove cleanup.  Change return
8632         type.
8633         (solib_target_current_sos): Update.
8634
8635 2019-01-17  Tom Tromey  <tromey@bapiya>
8636
8637         * valprint.c: Replace "the the" with "the".
8638         * symtab.c: Replace "the the" with "the".
8639         * solib.c: Replace "the the" with "the".
8640         * solib-dsbt.c: Replace "the the" with "the".
8641         * linespec.c: Replace "the the" with "the".
8642         * dwarf2loc.h: Replace "the the" with "the".
8643         * amd64-windows-tdep.c: Replace "the the" with "the".
8644         * aarch64-tdep.c: Replace "the the" with "the".
8645
8646 2019-01-16  Keith Seitz  <keiths@redhat.com>
8647
8648         PR gdb/23773
8649         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8650         <builder>: Rename to ..
8651         <m_builder>: ... this and make private.
8652         (dwarf2_cu::get_builder): New method.  Change all users of
8653         `builder' to use this method.
8654         (dwarf2_start_symtab): Move to ...
8655         (dwarf2_cu::start_symtab): ... here.  Update all callers
8656         (setup_type_unit_groups): Move to ...
8657         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8658         callers.
8659         (dwarf2_cu::reset_builder): New method.
8660         (process_full_compunit, process_full_type_unit): Use
8661         dwarf2_cu::reset_builder.
8662         (follow_die_offset): Record the ancestor CU if it is different
8663         from the followed DIE's CU.
8664         (follow_die_sig_1): Likewise.
8665
8666 2019-01-15  Tom Tromey  <tom@tromey.com>
8667
8668         * remote.c (class remote_state) <buf>: Now a char_vector.
8669         <buf_size>: Remove.
8670         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8671         parameter.
8672         (remote_target::getpkt_or_notif_sane_1)
8673         (remote_target::getpkt_sane)
8674         (remote_target::getpkt_or_notif_sane): Likewise.
8675         (class remote_target) <putpkt>: New overload.
8676         (remote_target::read_frame): Change type of "buf_p".  Remove
8677         sizeof_p parameter.
8678         (packet_ok): New overload.
8679         (packet_check_result): New overload.
8680         Update all uses.
8681
8682 2019-01-14  Tom Tromey  <tom@tromey.com>
8683
8684         * remote-notif.c (handle_notification, remote_notif_ack)
8685         (remote_notif_parse): Make "buf" const.
8686         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8687         const.
8688         (remote_notif_parse, remote_notif_ack, handle_notification):
8689         Likewise.
8690         * remote.c (remote_notif_stop_parse): Make "buf" const.
8691         (remote_target::remote_parse_stop_reply): Make "buf" const.
8692         (remote_notif_stop_ack): Make "buf" const.
8693
8694 2019-01-14  Tom Tromey  <tom@tromey.com>
8695
8696         * remote.c (remote_console_output): Make parameter const.
8697
8698 2019-01-14  Tom Tromey  <tom@tromey.com>
8699
8700         * target-debug.h (target_debug_print_signals): Constify.
8701         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8702         * procfs.c (procfs_target::pass_signals): Update.
8703         * linux-nat.c (linux_nat_target::pass_signals): Update.
8704         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8705         * target-delegates.c: Rebuild.
8706         * remote.c (remote_target::program_signals): Update.
8707         (remote_target::pass_signals): Update.
8708         * target.c (target_pass_signals): Constify argument.
8709         (target_program_signals): Likewise.
8710         * target.h (struct target_ops) <pass_signals, program_signals>:
8711         Constify argument.
8712         (target_pass_signals, target_program_signals): Constify argument.
8713
8714 2019-01-14  Tom Tromey  <tom@tromey.com>
8715
8716         PR tui/28819:
8717         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8718
8719 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8720
8721         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8722         field.
8723         * rs6000-tdep.c: Include reggroups.h.
8724         (IS_V_ALIAS_PSEUDOREG): Define.
8725         (rs6000_register_name): Return names for the "vX" aliases.
8726         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8727         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8728         aliases.  Call default_register_reggroup_p for all other
8729         pseudo-registers.
8730         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8731         New functions.
8732         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8733         Handle "vX" aliases.
8734         (v_alias_pseudo_register_collect): New function.
8735         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8736         (rs6000_gdbarch_init): Initialize "vX" aliases as
8737         pseudo-registers.  Restore registration of
8738         rs6000_pseudo_register_reggroup_p with
8739         set_tdesc_pseudo_register_reggroup_p.
8740
8741 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8742
8743         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8744         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8745         set_gdbarch_num_pseudo_regs.
8746
8747 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8748
8749         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8750         Remove arg prefixname, add do_set and do_show.
8751         Add member functions set_list and show_list.
8752         * cli/cli-style.c (class cli_style_option): Update accordingly.
8753         (style_set_list): Move to file scope.
8754         (style_show_list): Likewise.
8755         (set_style): Call help_list.
8756         (show_style): Call cmd_show_list.
8757         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8758         Update to use the new macro.
8759
8760 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8761
8762         * ada-lang.c (_initialize_ada_language): Expand the help text
8763         for the "catch exception" command.
8764
8765 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8766
8767         * symtab.c (matching_obj_sections): Initialize obj,
8768         declare it closer to its usage.
8769
8770 2019-01-10  Tom Tromey  <tom@tromey.com>
8771
8772         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8773         (basic_inf_threads_range): Remove.
8774         (inf_threads_range, inf_non_exited_threads_range)
8775         (safe_inf_threads_range): Use next_adapter.
8776
8777 2019-01-10  Keith Seitz  <keiths@redhat.com>
8778
8779         PR gdb/23712
8780         PR symtab/23010
8781         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8782         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8783
8784 2019-01-10  Keith Seitz  <keiths@redhat.com>
8785
8786         PR gdb/23712
8787         PR symtab/23010
8788         * dictionary.c (pending_to_vector): Remove.
8789         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8790         Remove _1 suffix, replacing functions of the same name.  Update
8791         all callers.
8792         (dict_create_hashed, dict_create_hashed_expandable)
8793         (dict_create_linear, dict_create_linear_expandable, dict_free)
8794         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8795         Make functions static.
8796
8797 2019-01-10  Keith Seitz  <keiths@redhat.com>
8798
8799         PR gdb/23712
8800         PR symtab/23010
8801         * dictionary.h (struct dictionary): Replace declaration with
8802         multidictionary.
8803         (dict_create_hashed, dict_create_hashed_expandable)
8804         (dict_create_linear, dict_create_linear_expandable)
8805         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8806         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8807         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8808         taking multidictionary argument.
8809         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8810         * block.h (struct block) <dict>: Change to multidictionary
8811         and rename `multidict'.
8812         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8813         symmisc.c: Update all dictionary references to multidictionary.
8814
8815 2019-01-10  Keith Seitz  <keiths@redhat.com>
8816
8817         PR gdb/23712
8818         PR symtab/23010
8819         * dictionary.c: Include unordered_map.
8820         (pending_to_vector): New function.
8821         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8822         Rewrite the non-"_1" functions to take vector instead
8823         of linked list.
8824         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8825         "new" _1 versions of the same name.
8826         (multidictionary): Define.
8827         (std::hash<enum language): New definition.
8828         (collate_pending_symbols_by_language, mdict_create_hashed)
8829         (mdict_create_hashed_expandable, mdict_create_linear)
8830         (mdict_create_linear_expandable, mdict_free)
8831         (find_language_dictionary, create_new_language_dictionary)
8832         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8833         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8834         (mdict_size, mdict_empty): New functions.
8835         * dictionary.h (mdict_iterator): Define.
8836
8837 2019-01-10  Pedro Alves  <palves@redhat.com>
8838
8839         * breakpoint.c (read_uploaded_action)
8840         (create_tracepoint_from_upload): Adjust to use
8841         gdb::unique_xmalloc_ptr.
8842         * ctf.c (ctf_write_uploaded_tp):
8843         (SET_ARRAY_FIELD): Use emplace_back.
8844         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8845         * tracefile-tfile.c (tfile_write_uploaded_tp):
8846         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8847         gdb::unique_xmalloc_ptr.
8848         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8849         at_string, cond_string, cmd_strings>: Replace char pointers
8850         with gdb::unique_xmalloc_ptr.
8851
8852 2019-01-10  Pedro Alves  <palves@redhat.com>
8853
8854         * solib-target.c (library_list_start_library): Don't xstrdup name.
8855
8856 2019-01-10  Pedro Alves  <palves@redhat.com>
8857
8858         * mdebugread.c (parse_partial_symbols): Use
8859         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8860
8861 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8862
8863         * linux-fork.c (scoped_switch_fork_info)
8864         <~scoped_switch_fork_info>: Fix incorrect variable name.
8865
8866 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8867
8868         * linux-fork.c (scoped_switch_fork_info)
8869         <scoped_switch_fork_info>: Make explicit.
8870         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8871
8872 2019-01-10  Tom Tromey  <tom@tromey.com>
8873
8874         * objfiles.h (objfile::reset_psymtabs): Update.
8875         * objfiles.c (objfile::objfile): Update.
8876         * psymtab.h (psymtab_storage::obstack): Update.
8877         (psymtab_storage::m_obstack): Use gdb::optional.
8878         (class psymtab_storage): Update comment.  Remove objfile
8879         parameter.
8880         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8881
8882 2019-01-10  Tom Tromey  <tom@tromey.com>
8883
8884         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8885         <free_psymtabs>: Now private.
8886         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8887         (allocate_psymtab): Use new method.
8888
8889 2019-01-10  Tom Tromey  <tom@tromey.com>
8890
8891         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8892         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8893         * mdebugread.c (parse_partial_symbols): Use
8894         allocate_dependencies.
8895         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8896         allocate_dependencies.
8897         (process_psymtab_comp_unit_reader)
8898         (build_type_psymtab_dependencies): Likewise.
8899         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8900
8901 2019-01-10  Tom Tromey  <tom@tromey.com>
8902
8903         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8904         PSYMBOL_SET_LANGUAGE.
8905         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8906
8907 2019-01-10  Tom Tromey  <tom@tromey.com>
8908
8909         * psymtab.h (psymtab_storage::obstack): New method.
8910         <m_obstack>: Rename from obstack; now private.
8911         * psymtab.c (psymtab_storage): Update.
8912         * dwarf2read.c (create_addrmap_from_index)
8913         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8914         Update.
8915
8916 2019-01-10  Tom Tromey  <tom@tromey.com>
8917
8918         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8919         * objfiles.h (objfile::reset_psymtabs): New method.
8920
8921 2019-01-10  Tom Tromey  <tom@tromey.com>
8922
8923         * symmisc.c (print_symbol_bcache_statistics): Update.
8924         (print_objfile_statistics): Update.
8925         * symfile.c (reread_symbols): Update.
8926         * psymtab.h (class psymtab_storage): New.
8927         * psymtab.c (psymtab_storage): New constructor.
8928         (~psymtab_storage): New destructor.
8929         (require_partial_symbols): Update.
8930         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8931         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8932         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8933         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8934         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8935         (start_psymtab_common, end_psymtab_common)
8936         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8937         (allocate_psymtab): Update.
8938         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8939         Update.
8940         (dump_psymtab_addrmap, maintenance_print_psymbols)
8941         (maintenance_check_psymtabs): Update.
8942         (class objfile_psymtabs): Move to objfiles.h.
8943         * psympriv.h (discard_psymtab): Now inline.
8944         (psymtab_discarder::psymtab_discarder): Update.
8945         (psymtab_discarder::~psymtab_discarder): Update.
8946         (ALL_OBJFILE_PSYMTABS): Rewrite.
8947         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8948         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8949         Remove fields.
8950         <partial_symtabs>: New field.
8951         (class objfile_psymtabs): Move from psymtab.h.  Update.
8952         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8953         psymbol_cache.
8954         (objfile::~objfile): Don't destroy psymbol_cache.
8955         * mdebugread.c (parse_partial_symbols): Update.
8956         * dwarf2read.c (create_addrmap_from_index)
8957         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8958         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8959         (add_partial_subprogram, dwarf2_ranges_read): Update.
8960         * dwarf-index-write.c (write_address_map)
8961         (write_one_signatured_type, recursively_write_psymbols)
8962         (class debug_names, class debug_names, write_psymtabs_to_index):
8963         Update.
8964
8965 2019-01-10  Tom Tromey  <tom@tromey.com>
8966
8967         * symtab.h (SYMBOL_SET_NAMES): Update.
8968         (symbol_set_names): Update.
8969         (MSYMBOL_SET_NAMES): Update.
8970         * symtab.c (symbol_set_names): Change argument to be an
8971         objfile_per_bfd_storage.
8972         * psymtab.c (add_psymbol_to_bcache): Update.
8973         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8974
8975 2019-01-10  Tom Tromey  <tom@tromey.com>
8976
8977         * symtab.c (create_demangled_names_hash): Change argument to be an
8978         objfile_per_bfd_storage.
8979         (symbol_set_names): Update.
8980
8981 2019-01-10  Tom Tromey  <tom@tromey.com>
8982
8983         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8984         init_psymbol_list.
8985         * psymtab.c (init_psymbol_list): Do nothing if already called.
8986         * psympriv.h (init_psymbol_list): Add comment.
8987         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8988         init_psymbol_list.
8989         * dbxread.c (dbx_symfile_read): Unconditionally call
8990         init_psymbol_list.
8991
8992 2019-01-10  Tom Tromey  <tom@tromey.com>
8993
8994         * xcoffread.c (scan_xcoff_symtab): Update.
8995         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8996         "where".
8997         * mdebugread.c (parse_partial_symbols)
8998         (handle_psymbol_enumerators): Update.
8999         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9000         * dbxread.c (read_dbx_symtab): Update.
9001         * psympriv.h (psymbol_placement): New enum.
9002         (add_psymbol_to_list): Update.
9003
9004 2019-01-10  Tom Tromey  <tom@tromey.com>
9005
9006         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9007         static_psymbols parameters.
9008         (scan_xcoff_symtab): Update.
9009         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9010         static_psymbols parameters.
9011         * psympriv.h (start_psymtab_common): Update.
9012         * mdebugread.c (parse_partial_symbols): Update.
9013         * dwarf2read.c (create_partial_symtab): Update.
9014         * dbxread.c (read_dbx_symtab): Update.
9015         (start_psymtab): Remove global_psymbols and static_psymbols
9016         parameters.
9017
9018 2019-01-10  Tom Tromey  <tom@tromey.com>
9019
9020         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9021         * psymtab.c (allocate_psymtab): Add comment.
9022         * psympriv.h (allocate_psymtab): Add comment.
9023         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9024         initializations.
9025         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9026
9027 2019-01-10  Tom Tromey  <tom@tromey.com>
9028
9029         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9030         Don't declare.
9031         * mipsread.c: Include mdebugread.h.
9032         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9033         Declare.
9034         * elfread.c: Include mdebugread.h.
9035
9036 2019-01-09  Tom Tromey  <tom@tromey.com>
9037
9038         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9039         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9040         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9041         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9042         (psym_lookup_symbol, psym_find_last_source_symtab)
9043         (psym_forget_cached_source_info, psym_print_stats)
9044         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9045         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9046         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9047         (psym_find_compunit_symtab_by_address)
9048         (maintenance_print_psymbols, maintenance_info_psymtabs)
9049         (maintenance_check_psymtabs): Use ranged for.
9050         * psymtab.h (class objfile_psymtabs): New.
9051         (require_partial_symbols): Return objfile_psymtabs.
9052         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9053
9054 2019-01-09  Tom Tromey  <tom@tromey.com>
9055
9056         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9057         (find_pc_mapped_section, list_overlays_command)
9058         (map_overlay_command, unmap_overlay_command)
9059         (simple_overlay_update): Use all_objfiles.
9060         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9061         * printcmd.c (info_symbol_command): Use all_objfiles.
9062         * objfiles.h (ALL_OBJSECTIONS): Remove.
9063         * maint.c (maintenance_translate_address): Use all_objfiles.
9064         * gcore.c (gcore_create_callback): Use all_objfiles.
9065         (objfile_find_memory_regions): Likewise.
9066
9067 2019-01-09  Tom Tromey  <tom@tromey.com>
9068
9069         * symtab.c (find_line_symtab, info_sources_command)
9070         (make_source_files_completion_list): Use objfile_compunits.
9071         * source.c (select_source_symtab): Use objfile_compunits.
9072         * objfiles.h (struct objfile): Update comment.
9073         (ALL_OBJFILES): Remove.
9074         (ALL_FILETABS): Remove.
9075         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9076         objfile_compunits.
9077
9078 2019-01-09  Tom Tromey  <tom@tromey.com>
9079
9080         * symmisc.c (print_objfile_statistics, dump_objfile)
9081         (maintenance_print_symbols): Use compunit_filetabs.
9082         * source.c (forget_cached_source_info_for_objfile): Use
9083         compunit_filetabs.
9084         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9085         (ALL_FILETABS): Use compunit_filetabs.
9086         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9087         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9088
9089 2019-01-09  Tom Tromey  <tom@tromey.com>
9090
9091         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9092         (compunit_filetabs): New.
9093         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9094         compunit_filetabs.
9095         (info_sources_command, make_source_files_completion_list): Remove
9096         declaration.
9097         * symmisc.c (print_objfile_statistics, dump_objfile)
9098         (maintenance_print_symbols): Remove declaration.
9099         (maintenance_info_symtabs): Use compunit_filetabs.
9100         (maintenance_info_line_tables): Likewise.
9101         * source.c (select_source_symtab): Change local variable name.
9102         (forget_cached_source_info_for_objfile): Remove declaration.
9103         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9104         * objfiles.c (objfile_relocate1): Remove declaration.
9105         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9106         declaration.
9107         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9108         * coffread.c (coff_symtab_read): Remove declaration.
9109         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9110         compunit_filetabs.
9111
9112 2019-01-09  Tom Tromey  <tom@tromey.com>
9113
9114         * symtab.c (lookup_objfile_from_block)
9115         (find_pc_sect_compunit_symtab, search_symbols)
9116         (default_collect_symbol_completion_matches_break_on): Use
9117         objfile_compunits.
9118         * objfiles.h (ALL_COMPUNITS): Remove.
9119         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9120         * cp-support.c (add_symbol_overload_list_qualified): Use
9121         objfile_compunits.
9122         * ada-lang.c (ada_collect_symbol_completion_matches)
9123         (ada_add_global_exceptions): Use objfile_compunits.
9124
9125 2019-01-09  Tom Tromey  <tom@tromey.com>
9126
9127         * source.c (select_source_symtab)
9128         (forget_cached_source_info_for_objfile): Remove declaration.
9129         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9130         declaration.
9131         * maint.c (count_symtabs_and_blocks): Remove declaration.
9132         * cp-support.c (add_symbol_overload_list_qualified): Remove
9133         declaration.
9134         * coffread.c (coff_symtab_read): Remove declaration.
9135         * symtab.c (lookup_symbol_in_objfile_symtabs)
9136         (basic_lookup_transparent_type_1): Use objfile_compunits.
9137         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9138         (info_sources_command, search_symbols)
9139         (default_collect_symbol_completion_matches_break_on)
9140         (make_source_files_completion_list): Remove declaration.
9141         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9142         (ada_collect_symbol_completion_matches)
9143         (ada_add_global_exceptions): Remove declaration.
9144         * linespec.c (iterate_over_all_matching_symtabs): Use
9145         objfile_compunits.
9146         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9147         (class objfile_compunits): New.
9148         (ALL_COMPUNITS): Use objfile_compunits.
9149         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9150         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9151         objfile_compunits.
9152         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9153
9154 2019-01-09  Tom Tromey  <tom@tromey.com>
9155
9156         * symtab.c (search_symbols)
9157         (default_collect_symbol_completion_matches_break_on): Use
9158         objfile_msymbols.
9159         * ada-lang.c (ada_lookup_simple_minsym)
9160         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9161         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9162         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9163         objfile_msymbols.
9164         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9165         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9166         * objc-lang.c (find_methods): Use objfile_msymbols.
9167         (info_selectors_command, info_classes_command): Likewise.
9168         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9169         * objfiles.h (class objfile_msymbols): New.
9170         (ALL_OBJFILE_MSYMBOLS): Remove.
9171         (ALL_MSYMBOLS): Remove.
9172
9173 2019-01-09  Tom Tromey  <tom@tromey.com>
9174
9175         * common/next-iterator.h (next_adapter): Add Iterator template
9176         parameter.
9177         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9178         (class all_objfiles_safe): New.
9179         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9180         * objfiles.c (put_objfile_before): Update comment.
9181         (add_separate_debug_objfile): Likewise.
9182         (free_all_objfiles): Use all_objfiles_safe.
9183         (objfile_purge_solibs): Likewise.
9184
9185 2019-01-09  Tom Tromey  <tom@tromey.com>
9186
9187         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9188         (expand_symtab_containing_pc, lookup_static_symbol)
9189         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9190         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9191         all_objfiles.
9192         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9193         * breakpoint.c (create_overlay_event_breakpoint)
9194         (create_longjmp_master_breakpoint)
9195         (create_std_terminate_master_breakpoint)
9196         (create_exception_master_breakpoint): Use all_objfiles.
9197         * linux-thread-db.c (try_thread_db_load_from_pdir)
9198         (has_libpthread): Use all_objfiles.
9199         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9200         * linespec.c (iterate_over_all_matching_symtabs)
9201         (search_minsyms_for_name): Use all_objfiles.
9202         * maint.c (maintenance_info_sections): Use all_objfiles.
9203         * main.c (captured_main_1): Use all_objfiles.
9204         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9205         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9206         * guile/scm-pretty-print.c
9207         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9208         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9209         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9210         (maintenance_print_msymbols): Use all_objfiles.
9211         * source.c (select_source_symtab): Use all_objfiles.
9212         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9213         * symfile.c (remove_symbol_file_command)
9214         (expand_symtabs_matching, map_symbol_filenames): Use
9215         all_objfiles.
9216         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9217         all_objfiles.
9218         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9219         * objc-lang.c (find_methods): Use all_objfiles.
9220         * objfiles.c (have_partial_symbols, have_full_symbols)
9221         (have_minimal_symbols, qsort_cmp)
9222         (default_iterate_over_objfiles_in_search_order): Use
9223         all_objfiles.
9224         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9225         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9226         (maintenance_check_psymtabs): Use all_objfiles.
9227         (ALL_PSYMTABS): Remove.
9228         * compile/compile-object-run.c (do_module_cleanup): Use
9229         all_objfiles.
9230         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9231         * cp-support.c (add_symbol_overload_list_qualified): Use
9232         all_objfiles.
9233         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9234         Use all_objfiles.
9235         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9236         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9237         all_objfiles.
9238         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9239         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9240         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9241         Uses all_objfiles.
9242         * solib.c (solib_read_symbols): Use all_objfiles
9243
9244 2019-01-09  Tom Tromey  <tom@tromey.com>
9245
9246         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9247         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9248         all_objfiles.
9249         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9250         * symmisc.c (print_symbol_bcache_statistics)
9251         (print_objfile_statistics, maintenance_print_objfiles)
9252         (maintenance_info_symtabs, maintenance_check_symtabs)
9253         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9254         all_objfiles.
9255         * source.c (forget_cached_source_info): Use all_objfiles.
9256         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9257         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9258         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9259         * objfiles.c (update_section_map): Use all_objfiles.
9260         (shared_objfile_contains_address_p): Likewise.
9261         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9262         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9263
9264 2019-01-09  Tom Tromey  <tom@tromey.com>
9265
9266         * common/next-iterator.h: New file.
9267         * objfiles.h (class all_objfiles): New.
9268         (struct objfile_iterator): New.
9269
9270 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9271
9272         * NEWS: Move the description of the changed "frame", "select-frame",
9273          and "info frame" commands to the Changed commands section.
9274
9275 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9276
9277         * gdbtypes.c (check_stub_method_group): Remove handling of old
9278         mangling schemes.
9279         * linespec.c (find_methods): Likewise.
9280         * stabsread.c (read_member_functions): Likewise.
9281         * valops.c (search_struct_method): Likewise.
9282         (value_struct_elt_for_reference): Likewise.
9283         * NEWS: Mention this change.
9284
9285 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9286
9287         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9288         print_source_lines.
9289         * source.c (print_source_lines_base): Update line number check.
9290         (print_source_lines): New function.
9291         (source_lines_range::source_lines_range): New function.
9292         * source.h (class source_lines_range): New class.
9293         (print_source_lines): New declaration.
9294
9295 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9296
9297         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9298
9299 2019-01-08  Tom Tromey  <tom@tromey.com>
9300             Simon Marchi  <simon.marchi@ericsson.com>
9301
9302         PR gdb/24060
9303         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9304         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9305         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9306         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9307         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9308         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9309
9310 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9311
9312         * source.c (select_source_symtab): Move header comment to
9313         declaration in source.h.
9314         (forget_cached_source_info_for_objfile): Likewise.
9315         (forget_cached_source_info): Likewise.
9316         (identify_source_line): Likewise.
9317         * source.h (identify_source_line): Move declaration from symtab.h
9318         and add comment from source.c
9319         (print_source_lines): Likewise.
9320         (forget_cached_source_info_for_objfile): Likewise.
9321         (forget_cached_source_info): Likewise.
9322         (select_source_symtab): Likewise.
9323         (enum print_source_lines_flag): Move definition from symtab.h.
9324         * symtab.h (identify_source_line): Move declaration to source.h.
9325         (print_source_lines): Likewise.
9326         (forget_cached_source_info_for_objfile): Likewise.
9327         (forget_cached_source_info): Likewise.
9328         (select_source_symtab): Likewise.
9329         (enum print_source_lines_flag): Move definition to source.h.
9330         * tui/tui-hooks.c: Add 'source.h' include.
9331
9332 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9333
9334         * source.c (print_source_lines_base): Handle requests to print
9335         reverse line number sequences, and guard against empty lines
9336         string.
9337
9338 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9339
9340         * source.c (print_source_lines_base): Fix skip of '\r' if next
9341         character is '\n'.
9342
9343 2019-01-06  Tom Tromey  <tom@tromey.com>
9344
9345         * c-exp.y (struct c_parse_state) <macro_original_text,
9346         expansion_obstack>: New member.
9347         (macro_original_text, expansion_obstack): Remove globals.
9348         (scan_macro_expansion, scanning_macro_expansion)
9349         (finished_macro_expansion): Update.
9350         (scan_macro_cleanup): Remove.
9351         (yylex, c_parse): Update.
9352
9353 2019-01-06  Tom Tromey  <tom@tromey.com>
9354
9355         * c-exp.y (struct c_parse_state) <strings>: New member.
9356         (operator_stoken): Update.
9357
9358 2019-01-06  Tom Tromey  <tom@tromey.com>
9359
9360         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9361         (union type_stack_elt) <typelist_val>: Now a pointer to
9362         std::vector.
9363         (type_stack_cleanup): Don't declare.
9364         (push_typelist): Update.
9365         * parse.c (pop_typelist): Return a std::vector.
9366         (push_typelist): Take a std::vector.
9367         (follow_types): Update.  Do not free args.
9368         (type_stack_cleanup): Remove.
9369         * c-exp.y (struct c_parse_state): New.
9370         (cpstate): New global.
9371         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9372         (nonempty_typelist): Update.
9373         (func_mod): Create a new vector.
9374         (c_parse): Create a c_parse_state.
9375         (check_parameter_typelist): Do not delete params.
9376         (function_method): Update.  Do not delete type_list.
9377
9378 2019-01-06  Tom Tromey  <tom@tromey.com>
9379
9380         PR gdb/28155:
9381         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9382         check_typedef.
9383         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9384         (print_return_value): Likewise.
9385
9386 2019-01-05  Tom Tromey  <tom@tromey.com>
9387
9388         * contrib/cleanup_check.py: Remove.
9389         * contrib/gcc-with-excheck: Remove.
9390         * contrib/exsummary.py: Remove.
9391         * contrib/excheck.py: Remove.
9392
9393 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9394
9395         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9396         NULL. Initialize tpprev to NULL instead of assigning it
9397         to NULL on the next statement.
9398         * windows-nat.c (windows_delete_thread): Remove check for
9399         main_thread_id before printing thread exit notifications.
9400         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9401         Remove thread ID check against main_thread_id.
9402         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9403         windows_delete_thread.
9404         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9405
9406 2019-01-04  Tom Tromey  <tom@tromey.com>
9407
9408         * compile/compile.c (_initialize_compile): Use upper case for
9409         metasyntactic variables.
9410         * symmisc.c (_initialize_symmisc): Use upper case for
9411         metasyntactic variables.
9412         * psymtab.c (_initialize_psymtab): Use upper case for
9413         metasyntactic variables.
9414         * demangle.c (demangle_command): Use upper case for metasyntactic
9415         variables.
9416         (_initialize_demangler): Likewise.
9417         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9418         variables.
9419
9420 2019-01-03  Tom Tromey  <tom@tromey.com>
9421
9422         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9423
9424 2019-01-03  Tom Tromey  <tom@tromey.com>
9425
9426         * python/py-symtab.c (salpy_str): Update.
9427         (struct salpy_sal_object) <symtab>: Now a PyObject.
9428         (salpy_dealloc): Update.
9429         (del_objfile_sal): Use gdbpy_ref.
9430
9431 2019-01-03  Tom Tromey  <tom@tromey.com>
9432
9433         * python/py-type.c (convert_field): Use new_reference.  Return
9434         gdbpy_ref.
9435         (make_fielditem): Return gdbpy_ref.
9436         (typy_fields): Update.
9437         (typy_getitem): Update.
9438         (field_name): Return gdbpy_ref.  Use new_reference.
9439         (typy_iterator_iternext): Update.
9440
9441 2019-01-03  Tom Tromey  <tom@tromey.com>
9442
9443         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9444
9445 2019-01-03  Tom Tromey  <tom@tromey.com>
9446
9447         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9448         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9449         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9450         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9451         (pspy_set_type_printers): Likewise.
9452         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9453         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9454         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9455         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9456         (objfpy_set_type_printers): Likewise.
9457
9458 2019-01-03  Tom Tromey  <tom@tromey.com>
9459
9460         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9461         (gdbpy_print_stack): Use gdbpy_err_fetch.
9462         * python/python-internal.h (class gdbpy_err_fetch): New class.
9463         (class gdbpy_enter) <m_error_type, m_error_value,
9464         m_error_traceback>: Remove.
9465         <m_error>: New member.
9466         (gdbpy_exception_to_string): Don't declare.
9467         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9468         * python/py-value.c (convert_value_from_python): Use
9469         gdbpy_err_fetch.
9470         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9471         gdbpy_exception_to_string.
9472         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9473         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9474         gdbpy_err_fetch.
9475
9476 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9477
9478         * linux-nat.c (delete_lwp_cleanup): Delete.
9479         (struct lwp_deleter): New struct.
9480         (lwp_info_up): New typedef.
9481         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9482         lwp_info_up.
9483
9484 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9485
9486         * linux-fork.c (class scoped_switch_fork_info): New class.
9487         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9488
9489 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9490
9491         * valops.c (find_overload_match): Remove use of null_cleanup, and
9492         calls to do_cleanups.
9493
9494 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9495
9496         * compile/compile-cplus-types.c
9497         (compile_cplus_instance::decl_name): Handle changes to
9498         cp_func_name.
9499         * cp-support.c (cp_func_name): Update header comment, update
9500         return type.
9501         * cp-support.h (cp_func_name): Update return type in declaration.
9502         * valops.c (find_overload_match): Move temp_func local to top
9503         level of function and change its type.  Use temp_func to hold and
9504         delete temporary string obtained from cp_func_name.
9505
9506 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9507
9508         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9509         gdb::char_vector, remove cleanup, and update uses of `msg`.
9510
9511 2019-01-03  Jim Wilson  <jimw@sifive.com>
9512
9513         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9514
9515 2019-01-02  Tom Tromey  <tom@tromey.com>
9516
9517         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9518         (tdesc_parse_xml): Remove cleanups.
9519         * target-descriptions.h (make_cleanup_free_target_description):
9520         Don't declare.
9521         (target_desc_deleter): New struct.
9522         (target_desc_up): New typedef.
9523         * target-descriptions.c (target_desc_deleter::operator()): Rename
9524         from free_target_description.
9525         (make_cleanup_free_target_description): Remove.
9526
9527 2019-01-02  Tom Tromey  <tom@tromey.com>
9528
9529         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9530         constructor, destructor.
9531         (linespec_parser): Remove typedef.
9532         (~linespec_parser): Rename from linespec_parser_delete.
9533         (linespec_lex_to_end, linespec_complete_label)
9534         (linespec_complete): Update.
9535         (decode_line_full): Remove cleanups.
9536         (decode_line_1): Update.
9537
9538 2019-01-02  Tom Tromey  <tom@tromey.com>
9539
9540         * python/python-internal.h (inferior_to_inferior_object): Change
9541         return type.
9542         * python/py-exitedevent.c (create_exited_event_object): Update.
9543         * python/py-inferior.c (inferior_to_inferior_object): Return
9544         gdbpy_ref.
9545         (python_new_inferior, python_inferior_deleted)
9546         (thread_to_thread_object, delete_thread_object)
9547         (build_inferior_list, gdbpy_selected_inferior): Update.
9548         * python/py-infthread.c (create_thread_object): Update.  Also fail
9549         if inferior_to_inferior_object fails.
9550
9551 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9552
9553         * inferior.h (class inferior) <displaced_step_state>: New field.
9554         * infrun.h (struct displaced_step_state): Move here from
9555         infrun.c.  Initialize fields, add constructor.
9556         <inf>: Remove field.
9557         <reset>: New method.
9558         * infrun.c (struct displaced_step_inferior_state): Move to
9559         infrun.h.
9560         (displaced_step_inferior_states): Remove.
9561         (get_displaced_stepping_state): Adust.
9562         (displaced_step_in_progress_any_inferior): Adjust.
9563         (displaced_step_in_progress_thread): Adjust.
9564         (displaced_step_in_progress): Adjust.
9565         (add_displaced_stepping_state): Remove.
9566         (get_displaced_step_closure_by_addr): Adjust.
9567         (remove_displaced_stepping_state): Remove.
9568         (infrun_inferior_exit): Call displaced_step_state.reset.
9569         (use_displaced_stepping): Don't check for NULL.
9570         (displaced_step_prepare_throw): Call
9571         get_displaced_stepping_state.
9572         (displaced_step_fixup): Don't check for NULL.
9573         (prepare_for_detach): Don't check for NULL.
9574
9575 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9576
9577         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9578          in case of call that did not complete.
9579
9580 2019-01-02  Andrey Utkin  <autkin@undo.io>
9581
9582         * symfile.c (find_separate_debug_file): Fix search of debug files for
9583         remote debuggee.
9584
9585 2019-01-02  Tom Tromey  <tom@tromey.com>
9586
9587         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9588         indentation.
9589         * python/py-frame.c (frapy_older): Remove cast.
9590         (frapy_newer): Likewise.
9591         * python/py-breakpoint.c (local_setattro): Remove cast.
9592         * python/py-arch.c (archpy_name): Remove local variable.
9593         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9594
9595 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9596
9597         * unittests/basic_string_view/element_access/char/empty.cc:
9598         Fix year range in copyright header.
9599
9600 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9601
9602         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9603         Delete.
9604         <operator==>: Update with for removed field.
9605         <hash>: Likewise.
9606         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9607         <isa_features>: ...this.
9608         <abi_features>: New field.
9609         (riscv_isa_flen): Update comment.
9610         (riscv_abi_xlen): New declaration.
9611         (riscv_abi_flen): New declaration.
9612         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9613         isa_features.
9614         (riscv_abi_xlen): New function.
9615         (riscv_isa_flen): Update to get answer from isa_features.
9616         (riscv_abi_flen): New function.
9617         (riscv_has_fp_abi): Update to get answer from abi_features.
9618         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9619         xlen and flen.
9620         (riscv_call_info) <xlen, flen>: Update comment.
9621         (riscv_call_arg_struct): Remove invalid assertions
9622         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9623         is removed.
9624         (riscv_gdbarch_init): Gather isa features and abi features
9625         separately, ensure both match on the gdbarch when reusing an old
9626         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9627         a target with 64-bit float hardware.
9628
9629 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9630
9631         * source.c (search_command_helper): Stop reverse search
9632         when line 1 has been searched.
9633
9634 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9635
9636         * record-full.c (record_full_base_target::close): Rewrite
9637         record_full_core_buf_list free logic.
9638
9639 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9640
9641         * break-catch-syscall.c (print_one_catch_syscall): xfree
9642         the last text.
9643
9644 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9645
9646         * top.c (print_gdb_version): Update Copyright year in version
9647         message.
9648
9649 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9650
9651         Update copyright year range in all GDB files.
9652
9653 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9654
9655         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9656
9657 For older changes see ChangeLog-2018.
9658 \f
9659 Local Variables:
9660 mode: change-log
9661 left-margin: 8
9662 fill-column: 74
9663 version-control: never
9664 coding: utf-8
9665 End:
9666