Fix Solaris build
[external/binutils.git] / gdb / ChangeLog
1 2018-04-12  Pedro Alves  <palves@redhat.com>
2
3         * procfs.c (procfs_detach): Make forward declaration's prototype
4         match definition's protototype.
5         (proc_get_LDT_entry): Remove stale do_cleanups call.
6
7 2018-04-12  Pedro Alves  <palves@redhat.com>
8
9         * target.h (target_ops::to_has_exited): Delete.
10         (target_has_exited): Delete.
11         * target-delegates.c: Regenerate.
12
13 2018-04-11  Pedro Alves  <palves@redhat.com>
14
15         * target.c (fileio_fh_t::t): Add comment.
16         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
17         (target_fileio_close): Handle a NULL target.
18         (invalidate_fileio_fh): New.
19         (target_close): Call it.
20         * remote.c (remote_hostio_send_command): No longer check whether
21         remote_desc is open.
22
23 2018-04-11  Pedro Alves  <palves@redhat.com>
24
25         * target.c (fileio_fh_t): Make it a named struct instead of a
26         typedef.
27         (fileio_fh_t::is_closed): New method.
28         (DEF_VEC_O (fileio_fh_t)): Remove.
29         (fileio_fhandles): Now a std::vector.
30         (is_closed_fileio_fh): Delete.
31         (acquire_fileio_fd): Adjust.  Rename parameters.
32         (release_fileio_fd): Adjust.
33         (fileio_fd_to_fh): Reimplement as a function instead of a macro.
34         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
35         (target_fileio_close): Adjust.
36
37 2018-04-10  Simon Marchi  <simon.marchi@ericsson.com>
38
39         * auto-load.c (auto_load_safe_path_vec_update): Iterate by
40         index.
41
42 2018-04-10  Pedro Alves  <palves@redhat.com>
43
44         * gdbthread.h (finish_thread_state_cleanup): Delete declaration.
45         (scoped_finish_thread_state): New class.
46         * infcmd.c (run_command_1): Use it instead of finish_thread_state
47         cleanup.
48         * infrun.c (proceed, prepare_for_detach, wait_for_inferior)
49         (fetch_inferior_event, normal_stop): Likewise.
50         * thread.c (finish_thread_state_cleanup): Delete.
51
52 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
53             Pedro Alves  <palves@redhat.com>
54
55         * value.c: Include "selftest.h" and "common/array-view.h".
56         (struct range) <operator ==>: New.
57         (test_ranges_contain): New.
58         (check_ranges_vector): New.
59         (test_insert_into_bit_range_vector): New.
60         (_initialize_values): Register selftests.
61         * common/array-view.h (operator==, operator!=): New.
62
63 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
64
65         * common/gdb_vecs.h (unordered_remove): Add overload that takes
66         an iterator.
67         * inline-frame.c: Include <algorithm>.
68         (struct inline_state): Add constructor.
69         (inline_state_s): Remove.
70         (DEF_VEC_O(inline_state_s)): Remove.
71         (inline_states): Change type to std::vector.
72         (find_inline_frame_state): Adjust to std::vector.
73         (allocate_inline_frame_state): Remove.
74         (clear_inline_frame_state): Adjust to std::vector.
75         (skip_inline_frames): Adjust to std::vector.
76
77 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
78
79         * tracepoint.h (struct trace_state_variable): Add constructor.
80         <name>: Change type to std::string.
81         * tracepoint.c (tsv_s): Remove.
82         (DEF_VEC_O(tsv_s)): Remove.
83         (tvariables): Change to std::vector.
84         (create_trace_state_variable): Adjust to std::vector.
85         (find_trace_state_variable): Likewise.
86         (find_trace_state_variable_by_number): Likewise.
87         (delete_trace_state_variable): Likewise.
88         (trace_variable_command): Adjust to std::string.
89         (delete_trace_variable_command): Likewise.
90         (tvariables_info_1): Adjust to std::vector.
91         (save_trace_state_variables): Likewise.
92         (start_tracing): Likewise.
93         (merge_uploaded_trace_state_variables): Adjust to std::vector
94         and std::string.
95         * target.h (struct target_ops)
96         <to_download_trace_state_variable>: Pass reference to
97         trace_state_variable.
98         * target-debug.h (target_debug_print_const_trace_state_variable_r): New.
99         * target-delegates.c: Re-generate.
100         * mi/mi-interp.c (mi_tsv_created): Adjust to std::string.
101         (mi_tsv_deleted): Likewise.
102         * mi/mi-main.c (mi_cmd_trace_frame_collected): Likewise.
103         * remote.c (remote_download_trace_state_variable): Change
104         pointer to reference and adjust.
105         * make-target-delegates (parse_argtypes): Handle references.
106         (write_function_header): Likewise.
107         (munge_type): Likewise.
108
109 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
110
111         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
112         string_view-selftests.c.
113         * unittests/basic_string_view/capacity/1.cc: Adapt to GDB
114         testsuite.
115         * unittests/basic_string_view/cons/char/1.cc: Likewise.
116         * unittests/basic_string_view/cons/char/2.cc: Likewise.
117         * unittests/basic_string_view/cons/char/3.cc: Likewise.
118         * unittests/basic_string_view/element_access/char/1.cc:
119         Likewise.
120         * unittests/basic_string_view/element_access/char/empty.cc:
121         Likewise.
122         * unittests/basic_string_view/element_access/char/front_back.cc:
123         Likewise.
124         * unittests/basic_string_view/inserters/char/2.cc: Likewise.
125         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc:
126         Likewise.
127         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc:
128         Likewise.
129         * unittests/basic_string_view/modifiers/swap/char/1.cc:
130         Likewise.
131         * unittests/basic_string_view/operations/compare/char/1.cc:
132         Likewise.
133         * unittests/basic_string_view/operations/compare/char/13650.cc:
134         Likewise.
135         * unittests/basic_string_view/operations/copy/char/1.cc:
136         Likewise.
137         * unittests/basic_string_view/operations/data/char/1.cc:
138         Likewise.
139         * unittests/basic_string_view/operations/find/char/1.cc:
140         Likewise.
141         * unittests/basic_string_view/operations/find/char/2.cc:
142         Likewise.
143         * unittests/basic_string_view/operations/find/char/3.cc:
144         Likewise.
145         * unittests/basic_string_view/operations/find/char/4.cc:
146         Likewise.
147         * unittests/basic_string_view/operations/rfind/char/1.cc:
148         Likewise.
149         * unittests/basic_string_view/operations/rfind/char/2.cc:
150         Likewise.
151         * unittests/basic_string_view/operations/rfind/char/3.cc:
152         Likewise.
153         * unittests/basic_string_view/operations/substr/char/1.cc:
154         Likewise.
155         * unittests/basic_string_view/operators/char/2.cc: Likewise.
156         * unittests/string_view-selftests.c: New file.
157
158 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
159
160         * unittests/basic_string_view/capacity/1.cc: New file.
161         * unittests/basic_string_view/capacity/empty_neg.cc: New file.
162         * unittests/basic_string_view/cons/char/1.cc: New file.
163         * unittests/basic_string_view/cons/char/2.cc: New file.
164         * unittests/basic_string_view/cons/char/3.cc: New file.
165         * unittests/basic_string_view/cons/wchar_t/1.cc: New file.
166         * unittests/basic_string_view/cons/wchar_t/2.cc: New file.
167         * unittests/basic_string_view/cons/wchar_t/3.cc: New file.
168         * unittests/basic_string_view/element_access/char/1.cc: New file.
169         * unittests/basic_string_view/element_access/char/2.cc: New file.
170         * unittests/basic_string_view/element_access/char/empty.cc: New file.
171         * unittests/basic_string_view/element_access/char/front_back.cc: New file.
172         * unittests/basic_string_view/element_access/wchar_t/1.cc: New file.
173         * unittests/basic_string_view/element_access/wchar_t/2.cc: New file.
174         * unittests/basic_string_view/element_access/wchar_t/empty.cc: New file.
175         * unittests/basic_string_view/element_access/wchar_t/front_back.cc: New file.
176         * unittests/basic_string_view/include.cc: New file.
177         * unittests/basic_string_view/inserters/char/1.cc: New file.
178         * unittests/basic_string_view/inserters/char/2.cc: New file.
179         * unittests/basic_string_view/inserters/char/3.cc: New file.
180         * unittests/basic_string_view/inserters/pod/10081-out.cc: New file.
181         * unittests/basic_string_view/inserters/wchar_t/1.cc: New file.
182         * unittests/basic_string_view/inserters/wchar_t/2.cc: New file.
183         * unittests/basic_string_view/inserters/wchar_t/3.cc: New file.
184         * unittests/basic_string_view/literals/types.cc: New file.
185         * unittests/basic_string_view/literals/values.cc: New file.
186         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc: New file.
187         * unittests/basic_string_view/modifiers/remove_prefix/wchar_t/1.cc: New file.
188         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc: New file.
189         * unittests/basic_string_view/modifiers/remove_suffix/wchar_t/1.cc: New file.
190         * unittests/basic_string_view/modifiers/swap/char/1.cc: New file.
191         * unittests/basic_string_view/modifiers/swap/wchar_t/1.cc: New file.
192         * unittests/basic_string_view/operations/compare/char/1.cc: New file.
193         * unittests/basic_string_view/operations/compare/char/13650.cc: New file.
194         * unittests/basic_string_view/operations/compare/char/2.cc: New file.
195         * unittests/basic_string_view/operations/compare/char/70483.cc: New file.
196         * unittests/basic_string_view/operations/compare/wchar_t/1.cc: New file.
197         * unittests/basic_string_view/operations/compare/wchar_t/13650.cc: New file.
198         * unittests/basic_string_view/operations/compare/wchar_t/2.cc: New file.
199         * unittests/basic_string_view/operations/copy/char/1.cc: New file.
200         * unittests/basic_string_view/operations/copy/wchar_t/1.cc: New file.
201         * unittests/basic_string_view/operations/data/char/1.cc: New file.
202         * unittests/basic_string_view/operations/data/wchar_t/1.cc: New file.
203         * unittests/basic_string_view/operations/find/char/1.cc: New file.
204         * unittests/basic_string_view/operations/find/char/2.cc: New file.
205         * unittests/basic_string_view/operations/find/char/3.cc: New file.
206         * unittests/basic_string_view/operations/find/char/4.cc: New file.
207         * unittests/basic_string_view/operations/find/wchar_t/1.cc: New file.
208         * unittests/basic_string_view/operations/find/wchar_t/2.cc: New file.
209         * unittests/basic_string_view/operations/find/wchar_t/3.cc: New file.
210         * unittests/basic_string_view/operations/find/wchar_t/4.cc: New file.
211         * unittests/basic_string_view/operations/rfind/char/1.cc: New file.
212         * unittests/basic_string_view/operations/rfind/char/2.cc: New file.
213         * unittests/basic_string_view/operations/rfind/char/3.cc: New file.
214         * unittests/basic_string_view/operations/rfind/wchar_t/1.cc: New file.
215         * unittests/basic_string_view/operations/rfind/wchar_t/2.cc: New file.
216         * unittests/basic_string_view/operations/rfind/wchar_t/3.cc: New file.
217         * unittests/basic_string_view/operations/string_conversion/1.cc: New file.
218         * unittests/basic_string_view/operations/substr/char/1.cc: New file.
219         * unittests/basic_string_view/operations/substr/wchar_t/1.cc: New file.
220         * unittests/basic_string_view/operators/char/2.cc: New file.
221         * unittests/basic_string_view/operators/wchar_t/2.cc: New file.
222         * unittests/basic_string_view/range_access/char/1.cc: New file.
223         * unittests/basic_string_view/range_access/wchar_t/1.cc: New file.
224         * unittests/basic_string_view/requirements/explicit_instantiation/1.cc: New file.
225         * unittests/basic_string_view/requirements/explicit_instantiation/char/1.cc: New file.
226         * unittests/basic_string_view/requirements/explicit_instantiation/char16_t/1.cc: New file.
227         * unittests/basic_string_view/requirements/explicit_instantiation/char32_t/1.cc: New file.
228         * unittests/basic_string_view/requirements/explicit_instantiation/wchar_t/1.cc: New file.
229         * unittests/basic_string_view/requirements/typedefs.cc: New file.
230         * unittests/basic_string_view/typedefs.cc: New file.
231         * unittests/basic_string_view/types/1.cc: New file.
232
233 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
234
235         * common/gdb_string_view.h: Remove libstdc++ implementation
236         details, adjust to gdb reality.
237         * common/gdb_string_view.tcc: Likewise.
238         * cli/cli-script.c (struct string_view): Remove.
239         (user_args) <m_args>: Change element type to gdb::string_view.
240         (user_args::insert_args): Adjust.
241
242 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
243
244         * common/gdb_string_view.h: New file.
245         * common/gdb_string_view.tcc: New file.
246
247 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
248
249         * ax_cxx_compile_stdcxx.m4: Sync with upstream.
250         * configure: Re-generate.
251
252 2018-04-09  Pedro Alves  <palves@redhat.com>
253
254         * gdbarch.sh: Include "observable.h" instead of "observer.h".
255         (set_target_gdbarch): Call
256         gdb::observers::architecture_changed.notify instead of
257         observer_notify_architecture_changed.
258
259 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
260
261         * tracepoint.c (struct current_traceframe_cleanup): Remove.
262         (do_restore_current_traceframe_cleanup): Remove.
263         (restore_current_traceframe_cleanup_dtor): Remove.
264         (make_cleanup_restore_current_traceframe): Remove.
265         (scoped_restore_current_traceframe::scoped_restore_current_traceframe):
266         New.
267         * tracepoint.h (struct scoped_restore_current_traceframe): New.
268         * infrun.c (fetch_inferior_event): Use
269         scoped_restore_current_traceframe.
270
271 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
272
273         * dwarf2read.h (struct dwarf2_per_objfile) <n_type_units>:
274         Remove.
275         <n_allocated_type_units>: Remove.
276         <all_type_units>: Change to std::vector.
277         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
278         to std::vector change.
279         (dwarf2_per_objfile::get_cutu): Likewise.
280         (dwarf2_per_objfile::get_tu): Likewise.
281         (create_signatured_type_table_from_index): Likewise.
282         (create_signatured_type_table_from_debug_names): Likewise.
283         (dw2_symtab_iter_next): Likewise.
284         (dw2_print_stats): Likewise.
285         (dw2_expand_all_symtabs): Likewise.
286         (dw2_expand_marked_cus): Likewise.
287         (dw2_debug_names_iterator::next): Likewise.
288         (dwarf2_initialize_objfile): Likewise.
289         (add_signatured_type_cu_to_table): Likewise.
290         (create_all_type_units): Likewise.
291         (add_type_unit): Likewise.
292         (struct tu_abbrev_offset): Add constructor.
293         (build_type_psymtabs_1): Adjust to std::vector change.
294         (print_tu_stats): Likewise.
295         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
296         (write_debug_names): Likewise.
297
298 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
299
300         * dwarf2read.h (struct dwarf2_per_objfile) <all_comp_units>: Likewise.
301         Make an std::vector.
302         <n_comp_units>: Remove.
303         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
304         to std::vector change.
305         (dwarf2_per_objfile::get_cutu): Likewise.
306         (dwarf2_per_objfile::get_cu): Likewise.
307         (create_cus_from_index): Likewise.
308         (create_addrmap_from_index): Likewise.
309         (create_addrmap_from_aranges): Likewise.
310         (dwarf2_read_index): Likewise.
311         (dw2_find_last_source_symtab): Likewise.
312         (dw2_map_symtabs_matching_filename): Likewise.
313         (dw2_symtab_iter_next): Likewise.
314         (dw2_print_stats): Likewise.
315         (dw2_expand_all_symtabs): Likewise.
316         (dw2_expand_symtabs_with_fullname): Likewise.
317         (dw2_expand_marked_cus): Likewise.
318         (dw2_map_symbol_filenames): Likewise.
319         (create_cus_from_debug_names): Likewise.
320         (dwarf2_read_debug_names): Likewise.
321         (dw2_debug_names_iterator::next): Likewise.
322         (dwarf2_initialize_objfile): Likewise.
323         (set_partial_user): Likewise.
324         (dwarf2_build_psymtabs_hard): Likewise.
325         (read_comp_units_from_section): Remove arguments, adjust to
326         std::vector change.
327         (create_all_comp_units): Adjust to std::vector and
328         read_comp_units_from_section changes.
329         (dwarf2_find_containing_comp_unit): Adjust to std::vector
330         change.
331         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
332         (psyms_seen_size): Likewise.
333         (write_gdbindex): Likewise.
334         (write_debug_names): Likewise.
335
336 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
337
338         * dwarf2read.c (create_cus_from_index_list): Replace objfile arg
339         with dwarf2_per_objfile.
340         (create_cus_from_index): Likewise.
341         (create_signatured_type_table_from_index): Likewise.
342         (dwarf2_read_index): Likewise.
343         (dwarf2_initialize_objfile): Likewise.
344         (dwarf2_fetch_die_loc_sect_off):  Get dwarf2_per_objfile from
345         per_cu rather than get_dwarf2_per_objfile.
346
347 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
348
349         * dwarf2read.h (struct signatured_type): Forward declare.
350         (struct dwarf2_per_objfile) <get_cutu, get_cu, get_tu>:
351         New methods.
352         * dwarf2read.c (dwarf2_per_objfile::get_cutu): Rename from...
353         (dw2_get_cutu): ...this.
354         (dwarf2_per_objfile::get_cu): Rename from...
355         (dw2_get_cu): ...this.
356         (dwarf2_per_objfile::get_tu): New.
357         (create_addrmap_from_index): Adjust.
358         (create_addrmap_from_aranges): Adjust.
359         (dw2_find_last_source_symtab): Adjust.
360         (dw2_map_symtabs_matching_filename): Adjust.
361         (dw2_symtab_iter_next): Adjust.
362         (dw2_print_stats): Adjust.
363         (dw2_expand_all_symtabs): Adjust.
364         (dw2_expand_symtabs_with_fullname): Adjust.
365         (dw2_expand_marked_cus): Adjust.
366         (dw_expand_symtabs_matching_file_matcher): Adjust.
367         (dw2_map_symbol_filenames): Adjust.
368         (dw2_debug_names_iterator::next): Adjust.
369         (dwarf2_initialize_objfile): Adjust.
370         (set_partial_user): Adjust.
371         (dwarf2_build_psymtabs_hard): Adjust.
372
373 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
374
375         * dwarf2read.c (create_signatured_type_table_from_debug_names):
376         Remove unused variables.
377         (dw2_map_symtabs_matching_filename): Likewise.
378         (dwarf2_record_block_ranges): Likewise.
379         (dwarf2_read_addr_index): Likewise.
380         (follow_die_offset): Likewise.
381
382 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
383
384         * progspace.c (clone_program_space): Pass SYMFILE_DEFER_BP_RESET
385         to symbol_file_add_main.
386
387 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
388
389         PR mi/22299
390         * mi/mi-console.c (do_fputc_async_safe): New.
391         (mi_console_file::write_async_safe): New.
392         (mi_console_file::flush): Adjust calls to fputstrn_unfiltered.
393         * mi/mi-console.h (class mi_console_file) <write_async_safe>:
394         New.
395         * ui-file.c (ui_file::putstrn): Adjust call to
396         fputstrn_unfiltered.
397         * utils.c (printchar): Replace do_fputs and do_fprintf
398         parameters by do_fputc.
399         (fputstr_filtered): Adjust call to printchar.
400         (fputstr_unfiltered): Likewise.
401         (fputstrn_filtered): Likewise.
402         (fputstrn_unfiltered): Add do_fputc parameter, pass to
403         printchar.
404         * utils.h (do_fputc_ftype): New typedef.
405         (fputstrn_unfiltered): Add do_fputc parameter.
406
407 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
408
409         * regformats/i386/i386-avx.dat: Remove.
410
411 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
412
413         PR gdb/22979
414         * amd64-tdep.c (amd64_none_init_abi): New function.
415         (amd64_x32_none_init_abi): New function.
416         (_initialize_amd64_tdep): Register handlers for x86-64 and
417         x64_32 with GDB_OSABI_NONE.
418         * osabi.c (gdbarch_init_osabi): Allow running handlers for the
419         GDB_OSABI_NONE osabi.
420
421 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
422
423         PR gdb/22980
424         * defs.h (enum gdb_osabi): Remove GDB_OSABI_UNINITIALIZED, add
425         GDB_OSABI_NONE.
426         * arch-utils.c (gdbarch_info_init): Don't set info->osabi.
427         * osabi.c (gdb_osabi_names): Add "unknown" entry.
428
429 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
430
431         * common/byte-vector.h (char_vector): New type.
432         * target.h (target_read_alloc): Return
433         gdb::optional<byte_vector>.
434         (target_read_stralloc): Return gdb::optional<char_vector>.
435         (target_get_osdata): Return gdb::optional<char_vector>.
436         * target.c (target_read_alloc_1): Templatize.  Replacement
437         manual memory management with vector.
438         (target_read_alloc): Change return type, adjust.
439         (target_read_stralloc): Change return type, adjust.
440         (target_get_osdata): Change return type, adjust.
441         * auxv.c (struct auxv_info) <length>: Remove.
442         <data>: Change type to gdb::optional<byte_vector>.
443         (auxv_inferior_data_cleanup): Free auxv_info with delete.
444         (get_auxv_inferior_data): Allocate auxv_info with new, adjust.
445         (target_auxv_search): Adjust.
446         (fprint_target_auxv): Adjust.
447         * avr-tdep.c (avr_io_reg_read_command): Adjust.
448         * linux-tdep.c (linux_spu_make_corefile_notes): Adjust.
449         (linux_make_corefile_notes): Adjust.
450         * osdata.c (get_osdata): Adjust.
451         * remote.c (remote_get_threads_with_qxfer): Adjust.
452         (remote_memory_map): Adjust.
453         (remote_traceframe_info): Adjust.
454         (btrace_read_config): Adjust.
455         (remote_read_btrace): Adjust.
456         (remote_pid_to_exec_file): Adjust.
457         * solib-aix.c (solib_aix_get_library_list): Adjust.
458         * solib-dsbt.c (decode_loadmap): Don't free buf.
459         (dsbt_get_initial_loadmaps): Adjust.
460         * solib-svr4.c (svr4_current_sos_via_xfer_libraries): Adjust.
461         * solib-target.c (solib_target_current_sos): Adjust.
462         * tracepoint.c (sdata_make_value): Adjust.
463         * xml-support.c (xinclude_start_include): Adjust.
464         (xml_fetch_content_from_file): Adjust.
465         * xml-support.h (xml_fetch_another): Change return type.
466         (xml_fetch_content_from_file): Change return type.
467         * xml-syscall.c (xml_init_syscalls_info): Adjust.
468         * xml-tdesc.c (file_read_description_xml): Adjust.
469         (fetch_available_features_from_target): Change return type.
470         (target_fetch_description_xml): Adjust.
471         (target_read_description_xml): Adjust.
472
473 2018-04-06  Tom Tromey  <tom@tromey.com>
474
475         * value.c (~value): Update.
476         (struct value) <contents>: Now unique_xmalloc_ptr.
477         (value_contents_bits_eq, allocate_value_contents)
478         (value_contents_raw, value_contents_all_raw)
479         (value_contents_for_printing, value_contents_for_printing_const)
480         (set_value_enclosing_type): Update.
481
482 2018-04-06  Tom Tromey  <tom@tromey.com>
483
484         * value.c (range_s): Remove typedef, VEC.
485         (struct range): Add operator<.
486         (range_lessthan): Remove.
487         (ranges_contain): Change type.
488         (~value): Update.
489         (struct value) <unavailable, optimized_out>: Now std::vector.
490         (value_entirely_available)
491         (value_entirely_covered_by_range_vector)
492         (value_entirely_unavailable, value_entirely_optimized_out):
493         Update.
494         (insert_into_bit_range_vector): Change argument type.
495         (find_first_range_overlap): Likewise.
496         (struct ranges_and_idx, value_contents_bits_eq)
497         (require_not_optimized_out, require_available): Update.
498         (ranges_copy_adjusted): Change argument types.
499         (value_optimized_out, value_copy, value_fetch_lazy): Update.
500
501 2018-04-06  Tom Tromey  <tom@tromey.com>
502
503         * value.c (~value): Update.
504         (struct value) <parent>: Now a value_ref_ptr.
505         (value_parent, set_value_parent, value_address, value_copy):
506         Update.
507
508 2018-04-06  Tom Tromey  <tom@tromey.com>
509
510         * value.c (struct value): Add constructor, destructor, and member
511         initializers.
512         (allocate_value_lazy, value_decref): Update.
513
514 2018-04-06  Tom Tromey  <tom@tromey.com>
515
516         * value.c (struct value) <released, next>: Remove.
517         (all_values): Now a std::vector.
518         (allocate_value_lazy): Update.
519         (value_next): Remove.
520         (value_mark, value_free_to_mark, release_value)
521         (value_release_to_mark): Update.
522
523 2018-04-06  Tom Tromey  <tom@tromey.com>
524
525         * value.h (fetch_subexp_value, value_release_to_mark): Update.
526         (free_value_chain): Remove.
527         * value.c (free_value_chain): Remove.
528         (value_release_to_mark): Return a std::vector.
529         * ppc-linux-nat.c (num_memory_accesses): Change "chain" to a
530         std::vector.
531         (check_condition): Update.
532         * eval.c (fetch_subexp_value): Change "val_chain" to a
533         std::vector.
534         * breakpoint.c (update_watchpoint): Update.
535         (can_use_hardware_watchpoint): Change "vals" to a std::vector.
536
537 2018-04-06  Tom Tromey  <tom@tromey.com>
538
539         * value.h (free_all_values): Remove.
540         * value.c (free_all_values): Remove.
541
542 2018-04-06  Tom Tromey  <tom@tromey.com>
543
544         * value.c (VALUE_HISTORY_CHUNK, struct value_history_chunk)
545         (value_history_chain, value_history_count): Remove.
546         (value_history): New global.
547         (record_latest_value, access_value_history, show_values)
548         (preserve_values): Update.
549
550 2018-04-06  Tom Tromey  <tom@tromey.com>
551
552         * varobj.h (struct varobj) <value>: Now a value_ref_ptr.
553         * varobj.c (varobj_set_display_format, varobj_set_value)
554         (install_default_visualizer, construct_visualizer)
555         (install_new_value, ~varobj, varobj_get_value_type)
556         (my_value_of_variable, varobj_editable_p): Update.
557         * c-varobj.c (c_describe_child, c_value_of_variable)
558         (cplus_number_of_children, cplus_describe_child): Update.
559         * ada-varobj.c (ada_number_of_children, ada_name_of_child)
560         (ada_path_expr_of_child, ada_value_of_child, ada_type_of_child)
561         (ada_value_of_variable, ada_value_is_changeable_p): Update.
562
563 2018-04-06  Tom Tromey  <tom@tromey.com>
564
565         * printcmd.c (last_examine_address): Change type to
566         value_ref_ptr.
567         (do_examine, x_command): Update.
568
569 2018-04-06  Tom Tromey  <tom@tromey.com>
570
571         * value.c (release_value): Update.
572         * breakpoint.h (struct watchpoint) <val>: Now a value_ref_ptr.
573         (struct bpstats) <val>: Now a value_ref_ptr.
574         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
575         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
576         (~watchpoint, print_it_watchpoint, watch_command_1)
577         (invalidate_bp_value_on_memory_change): Update.
578
579 2018-04-06  Tom Tromey  <tom@tromey.com>
580
581         * varobj.c (varobj_clear_saved_item)
582         (update_dynamic_varobj_children, install_new_value, ~varobj):
583         Update.
584         * value.h (value_incref): Move declaration earlier.
585         (value_decref): Rename from value_free.
586         (struct value_ref_policy): New.
587         (value_ref_ptr): New typedef.
588         (struct value_deleter): Remove.
589         (gdb_value_up): Remove typedef.
590         (release_value): Change return type.
591         (release_value_or_incref): Remove.
592         * value.c (set_value_parent): Update.
593         (value_incref): Change return type.
594         (value_decref): Rename from value_free.
595         (value_free_to_mark, free_all_values, free_value_chain): Update.
596         (release_value): Return value_ref_ptr.
597         (release_value_or_incref): Remove.
598         (record_latest_value, set_internalvar, clear_internalvar):
599         Update.
600         * stack.c (info_frame_command): Don't call value_free.
601         * python/py-value.c (valpy_dealloc, valpy_new)
602         (value_to_value_object): Update.
603         * printcmd.c (do_examine): Update.
604         * opencl-lang.c (lval_func_free_closure): Update.
605         * mi/mi-main.c (register_changed_p): Don't call value_free.
606         * mep-tdep.c (mep_frame_prev_register): Don't call value_free.
607         * m88k-tdep.c (m88k_frame_prev_register): Don't call value_free.
608         * m68hc11-tdep.c (m68hc11_frame_prev_register): Don't call
609         value_free.
610         * guile/scm-value.c (vlscm_free_value_smob)
611         (vlscm_scm_from_value): Update.
612         * frame.c (frame_register_unwind, frame_unwind_register_signed)
613         (frame_unwind_register_unsigned, get_frame_register_bytes)
614         (put_frame_register_bytes): Don't call value_free.
615         * findvar.c (address_from_register): Don't call value_free.
616         * dwarf2read.c (dwarf2_compute_name): Don't call value_free.
617         * dwarf2loc.c (entry_data_value_free_closure)
618         (value_of_dwarf_reg_entry, free_pieced_value_closure)
619         (dwarf2_evaluate_loc_desc_full): Update.
620         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
621         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
622         (~watchpoint, watch_command_1)
623         (invalidate_bp_value_on_memory_change): Update.
624         * alpha-tdep.c (alpha_register_to_value): Don't call value_free.
625
626 2018-04-06  Simon Marchi  <simon.marchi@polymtl.ca>
627
628         PR gdb/23022
629         * warning.m4: Add -Wno-error=deprecated-register.
630         * configure: Re-generate.
631
632 2018-04-05  Tom Tromey  <tom@tromey.com>
633
634         * linespec.h: Remove include of "vec.h".
635
636 2018-04-05  Tom Tromey  <tom@tromey.com>
637
638         * linespec.c (typep): Remove typedef.
639         (find_methods, find_superclass_methods): Take a std::vector.
640         (find_method): Use std::vector.
641
642 2018-04-05  Tom Tromey  <tom@tromey.com>
643
644         * utils.c (compare_strings): Remove.
645         * utils.h (compare_strings): Remove.
646         * objc-lang.h (find_imps): Update.
647         * objc-lang.c (find_methods): Take a std::vector.
648         (uniquify_strings, find_imps): Likewise.
649         * linespec.c (find_methods): Take a std::vector.
650         (decode_objc): Use std::vector.
651         (add_all_symbol_names_from_pspace, find_superclass_methods): Take
652         a std::vector.
653         (find_method, find_function_symbols): Use std::vector.
654
655 2018-04-05  Tom Tromey  <tom@tromey.com>
656
657         * completer.c (completion_tracker::completion_tracker): Remove
658         cast.
659         (completion_tracker::discard_completions): Likewise.
660         * breakpoint.c (ambiguous_names_p): Remove cast.
661         * ada-lang.c (_initialize_ada_language): Remove cast.
662         * utils.h (streq): Update.
663         (streq_hash): Add new declaration.
664         * utils.c (streq): Return bool.
665         (streq_hash): New function.
666
667 2018-04-05  Tom Tromey  <tom@tromey.com>
668
669         * linespec.c (event_location_to_sals) <case ADDRESS_LOCATION>:
670         Remove a string copy.
671
672 2018-04-05  Tom Tromey  <tom@tromey.com>
673
674         * linespec.c (filter_results): Use std::vector.
675         (decode_line_2, decode_line_full): Update.
676
677 2018-04-05  Tom Tromey  <tom@tromey.com>
678
679         * linespec.c (canonical_to_fullform): Return std::string.
680         (filter_results): Update.
681         (struct decode_line_2_item): Add constructor.
682         <fullform, displayform>: Now std::string.
683         (decode_line_2_compare_items): Now a std::sort comparator.
684         (decode_line_2): Update.
685
686 2018-04-05  Tom Tromey  <tom@tromey.com>
687
688         * linespec.c (copy_token_string): Return a unique_xmalloc_ptr.
689         (unexpected_linespec_error): Update.
690         (linespec_parse_basic, parse_linespec): Update.
691
692 2018-04-05  Tom Tromey  <tom@tromey.com>
693
694         * linespec.c (linespec_parse_basic): Reindent.
695
696 2018-04-05  Tom Tromey  <tom@tromey.com>
697
698         * minsyms.h (iterate_over_minimal_symbols): Update.
699         * minsyms.c (iterate_over_minimal_symbols): Take a
700         gdb::function_view.
701         * linespec.c (struct collect_minsyms): Remove.
702         (compare_msyms): Now a std::sort comparator.
703         (add_minsym): Add parameters.
704         (search_minsyms_for_name): Update.  Use std::vector.
705
706 2018-04-03  Tom Tromey  <tom@tromey.com>
707
708         * mipsread.c (read_alphacoff_dynamic_symtab): Use
709         gdb::byte_vector.
710
711 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
712
713         * MAINTAINERS (Write After Approval): Add Weimin Pan.
714
715 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
716
717         PR gdb/16959
718         * cp-valprint.c: (cp_print_static_field) Fix infinite recursion when 
719         printing static type.
720
721 2018-04-01  Tom Tromey  <tom@tromey.com>
722
723         * rs6000-nat.c (rs6000_ptrace_ldinfo): Return a byte_vector.
724         (rs6000_xfer_shared_libraries): Update.
725
726 2018-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
727
728         * common/gdb_vecs.h (char_ptr): Remove.
729         * tracepoint.c (encode_actions_1): Remove usage of char_ptr.
730
731 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
732
733         * guile/scm-utils.c (gdbscm_parse_function_args): Replace VEC
734         with std::vector.
735         * common/gdb_vecs.h (DEF_VEC_P (char_ptr)): Remove.
736
737 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
738
739         * tracepoint.h (struct uploaded_tp): Initialize fields.
740         <actions, step_actions, cmd_strings>: Change type to
741         std::vector<char *>.
742         * tracepoint.c (get_uploaded_tp): Allocate with new.
743         (free_uploaded_tps): Free with delete.
744         (parse_tracepoint_definition): Adjust to std::vector change.
745         * breakpoint.c (read_uploaded_action): Likewise.
746         (create_tracepoint_from_upload): Likewise.
747         * ctf.c (ctf_write_uploaded_tp): Likewise.
748         (SET_ARRAY_FIELD): Likewise.
749         * tracefile-tfile.c (tfile_write_uploaded_tp): Likewise.
750
751 2018-03-30  Tom Tromey  <tom@tromey.com>
752
753         * solib-svr4.c (lm_info_read): Use gdb::byte_vector.  Return
754         std::unique_ptr.
755         (svr4_keep_data_in_core): Update.
756         (svr4_read_so_list): Update.
757
758 2018-03-30  Tom Tromey  <tom@tromey.com>
759
760         * windows-nat.c (handle_output_debug_string, handle_exception):
761         Update.
762         * target.h (target_read_string): Update.
763         * target.c (target_read_string): Change "string" to
764         unique_xmalloc_ptr.
765         * solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
766         Update.
767         * solib-frv.c (frv_current_sos): Update.
768         * solib-dsbt.c (dsbt_current_sos): Update.
769         * solib-darwin.c (darwin_current_sos): Update.
770         * linux-thread-db.c (inferior_has_bug): Update.
771         * expprint.c (print_subexp_standard) <case OP_OBJC_MSGCALL>:
772         Update.  Remove alloca.
773         * ada-lang.c (ada_main_name): Update.
774
775 2018-03-30  Tom Tromey  <tom@tromey.com>
776
777         * dwarf2read.c (struct free_dwo_file_cleanup_data): Remove.
778         (struct dwo_file_deleter): New.
779         (dwo_file_up): New typedef.
780         (open_and_init_dwo_file): Use dwo_file_up.
781         (free_dwo_file_cleanup): Remove.
782
783 2018-03-30  Tom Tromey  <tom@tromey.com>
784
785         * dwarf2read.c (free_dwo_file): Remove "objfile" parameter.
786         (free_dwo_file_cleanup, free_dwo_file_from_slot): Update.
787
788 2018-03-30  Tom Tromey  <tom@tromey.com>
789
790         * dwarf2read.c (class free_cached_comp_units): New class.
791         (dw2_instantiate_symtab, dwarf2_build_psymtabs_hard): Use it.
792         (free_cached_comp_units): Remove function.
793
794 2018-03-30  Tom Tromey  <tom@tromey.com>
795
796         * utils.h (make_cleanup_unpush_target): Remove.
797         * inf-ptrace.c (struct target_unpusher): New.
798         (target_unpush_up) New typedef.
799         (inf_ptrace_create_inferior, inf_ptrace_attach): Use
800         target_unpush_up.
801         * utils.c (do_unpush_target, make_cleanup_unpush_target): Remove.
802
803 2018-03-27  Tom Tromey  <tom@tromey.com>
804
805         * utils.c (prompt_for_continue): Use unique_xmalloc_ptr.
806
807 2018-03-27  Pedro Alves  <palves@redhat.com>
808             Tom Tromey  <tom@tromey.com>
809
810         * top.c (class gdb_readline_wrapper_cleanup): Add constructor,
811         destructor.  Now a class.
812         (gdb_readline_wrapper_cleanup): Remove function.
813         (gdb_readline_wrapper): Remove cleanups.
814
815 2018-03-27  Tom Tromey  <tom@tromey.com>
816
817         * typeprint.h (struct type_print_options) <local_typedefs,
818         global_typedefs>: Remove "struct" keyword.
819         (class typedef_hash_table): New class.
820         (recursively_update_typedef_hash, add_template_parameters)
821         (create_typedef_hash, free_typedef_hash, copy_typedef_hash)
822         (find_typedef_in_hash): Don't declare.
823         * typeprint.c (struct typedef_hash_table): Move to typeprint.h.
824         (typedef_hash_table::recursively_update): Rename from
825         recursively_update_typedef_hash.  Now a member.
826         (typedef_hash_table::add_template_parameters): Rename from
827         add_template_parameters.  Now a member.
828         (typedef_hash_table::typedef_hash_table): Now a constructor;
829         rename from create_typedef_hash.
830         (typedef_hash_table::~typedef_hash_table): Now a destructor;
831         rename from free_typedef_hash.
832         (do_free_typedef_hash, make_cleanup_free_typedef_hash)
833         (do_free_global_table): Remove.
834         (typedef_hash_table::typedef_hash_table): New constructor; renamed
835         from copy_type_recursive.
836         (create_global_typedef_table): Remove.
837         (typedef_hash_table::find_global_typedef): Now a member of
838         typedef_hash_table.
839         (typedef_hash_table::find_typedef): Rename from
840         find_typedef_in_hash; now a member.
841         (whatis_exp): Update.
842         * extension.h (struct ext_lang_type_printers): Add constructor and
843         destructor.
844         (start_ext_lang_type_printers, free_ext_lang_type_printers): Don't
845         declare.
846         * extension.c (ext_lang_type_printers::ext_lang_type_printers):
847         Now a constructor; rename from start_ext_lang_type_printers.
848         (ext_lang_type_printers): Now a destructor; rename from
849         free_ext_lang_type_printers.
850         * c-typeprint.c (find_typedef_for_canonicalize, c_print_type_1):
851         Update.
852         (c_type_print_base_struct_union): Update.  Remove cleanups.
853
854 2018-03-27  Tom Tromey  <tom@tromey.com>
855
856         * dwarf-index-write.c: Include <cmath>.
857
858 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
859
860         * NEWS: Add entry describing new "set|show varsize-limit" command.
861         * ada-lang.c (_initialize_ada_language): Add "set/show varsize-limit"
862         command.
863         * printcmd.c (_initialize_printcmd): Add "set var" alias of
864         "set variable".
865
866 2018-03-27  Simon Marchi  <simon.marchi@ericsson.com>
867
868         * Makefile.in (COMMON_SFILES): Add dwarf-index-common.c and
869         dwarf-index-write.c
870         (HFILES_NO_SRCDIR): Add dwarf-index-common.h and dwarf2read.h.
871         * dwarf-index-common.c: New file.
872         * dwarf-index-common.h: New file.
873         * dwarf-index-write.c: New file.
874         * dwarf2read.c: Include dwarf2read.h and dwarf-index-common.h.
875         (struct dwarf2_section_info): Move from here.
876         (dwarf2_section_info_def): Likewise.
877         (DEF_VEC_O (dwarf2_section_info_def)): Likewise.
878         (offset_type): Likewise.
879         (DW2_GDB_INDEX_SYMBOL_STATIC_SET_VALUE): Likewise.
880         (DW2_GDB_INDEX_SYMBOL_KIND_SET_VALUE): Likewise.
881         (DW2_GDB_INDEX_CU_SET_VALUE): Likewise.
882         (byte_swap): Likewise.
883         (MAYBE_SWAP): Likewise.
884         (dwarf2_per_cu_ptr): Likewise.
885         (DEF_VEC_P (dwarf2_per_cu_ptr)): Likewise.
886         (struct tu_stats): Likewise.
887         (struct dwarf2_per_objfile): Likewise.
888         (struct dwarf2_per_cu_data): Likewise.
889         (struct signatured_type): Likewise.
890         (sig_type_ptr): Likewise.
891         (DEF_VEC_P (sig_type_ptr)): Likewise.
892         (INDEX4_SUFFIX): Likewise.
893         (INDEX5_SUFFIX): Likewise.
894         (DEBUG_STR_SUFFIX): Likewise.
895         (dwarf2_read_section): Make non-static.
896         (mapped_index_string_hash): Move from here.
897         (dwarf5_djb_hash): Likewise.
898         (file_write): Likewise.
899         (class data_buf): Likewise.
900         (struct symtab_index_entry): Likewise.
901         (struct mapped_symtab): Likewise.
902         (find_slot): Likewise.
903         (hash_expand): Likewise.
904         (add_index_entry): Likewise.
905         (uniquify_cu_indices): Likewise.
906         (class c_str_view): Likewise.
907         (class c_str_view_hasher): Likewise.
908         (class vector_hasher): Likewise.
909         (write_hash_table): Likewise.
910         (psym_index_map): Likewise.
911         (struct addrmap_index_data): Likewise.
912         (add_address_entry): Likewise.
913         (add_address_entry_worker): Likewise.
914         (write_address_map): Likewise.
915         (symbol_kind): Likewise.
916         (write_psymbols): Likewise.
917         (struct signatured_type_index_data): Likewise.
918         (write_one_signatured_type): Likewise.
919         (recursively_count_psymbols): Likewise.
920         (recursively_write_psymbols): Likewise.
921         (class debug_names): Likewise.
922         (check_dwarf64_offsets): Likewise.
923         (psyms_seen_size): Likewise.
924         (write_gdbindex): Likewise.
925         (write_debug_names): Likewise.
926         (assert_file_size): Likewise.
927         (write_psymtabs_to_index): Likewise.
928         (save_gdb_index_command): Likewise.
929         (_initialize_dwarf2_read): Don't register the "save gdb-index"
930         command.
931         * dwarf2read.h: New file.
932
933 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
934
935         PR gdb/22670
936         * dwarf2read.c (dwarf2_physname): Do not return the demangled
937         symbol name if the CU's language stores symbol names in linkage
938         format.
939         * language.h (struct language_defn)
940         <la_store_sym_names_in_linkage_form_p>: New field.  Adjust
941         all instances of this struct.
942
943 2018-03-26  Tom Tromey  <tom@tromey.com>
944
945         * stack.c (backtrace_command_1): Remove verbose code.
946
947 2018-03-26  Tom Tromey  <tom@tromey.com>
948
949         * python/py-framefilter.c (py_print_type): Don't catch
950         exceptions.  Return void.
951         (py_print_value): Likewise.
952         (py_print_single_arg): Likewise.
953         (enumerate_args): Don't catch exceptions.
954         (py_print_args): Likewise.
955         (py_print_frame): Likewise.
956         (gdbpy_apply_frame_filter): Catch exceptions here.
957
958 2018-03-26  Tom Tromey  <tom@tromey.com>
959
960         * stack.c (_initialize_stack): Remove trailing newlines from help
961         text.  Add "Usage" line to "backtrace" help.
962
963 2018-03-26  Tom Tromey  <tom@tromey.com>
964
965         PR python/16486:
966         * python/py-framefilter.c (py_print_args): Call wrap_hint.
967
968 2018-03-26  Tom Tromey  <tom@tromey.com>
969
970         * python/py-framefilter.c (py_print_single_arg): Return
971         EXT_LANG_BT_ERROR from catch.
972
973 2018-03-26  Tom Tromey  <tom@tromey.com>
974
975         PR backtrace/15584:
976         * stack.c (backtrace_command_1): Move some code into no-filters
977         "if".
978
979 2018-03-26  Tom Tromey  <tom@tromey.com>
980
981         * python/py-framefilter.c (throw_quit_or_print_exception): New
982         function.
983         (gdbpy_apply_frame_filter): Use it.
984
985 2018-03-26  Tom Tromey  <tom@tromey.com>
986
987         PR cli/17716:
988         * python/py-framefilter.c (py_print_type, py_print_value)
989         (enumerate_args, py_print_args, gdbpy_apply_frame_filter): Use
990         RETURN_MASK_ERROR.
991
992 2018-03-26  Tom Tromey  <tom@tromey.com>
993
994         * python/py-framefilter.c (enumerate_args): Use
995         gdb::unique_xmalloc_ptr.
996
997 2018-03-26  Tom Tromey  <tom@tromey.com>
998
999         * python/py-framefilter.c (py_print_frame): Return
1000         EXT_LANG_BT_OK.
1001         (gdbpy_apply_frame_filter): Update comment.
1002         * extension.h (enum ext_lang_bt_status) <EXT_LANG_BT_COMPLETED>:
1003         Remove.
1004         <EXT_LANG_BT_NO_FILTERS>: Change value.
1005
1006 2018-03-26  Tom Tromey  <tom@tromey.com>
1007
1008         PR backtrace/15582:
1009         * stack.c (backtrace_command): Parse "hide" argument.
1010         * python/py-framefilter.c (py_print_frame): Handle PRINT_HIDE.
1011         * extension.h (enum frame_filter_flags) <PRINT_HIDE>: New
1012         constant.
1013
1014 2018-03-26  Tom Tromey  <tom@tromey.com>
1015
1016         * stack.c (backtrace_command_1): Remove "show_locals" parameter,
1017         add "flags".
1018         (backtrace_command): Remove "fulltrace", add "flags".
1019
1020 2018-03-26  Tom Tromey  <tom@tromey.com>
1021
1022         * stack.c (backtrace_command): Rewrite command line parsing.
1023
1024 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
1025
1026         * dwarf2read.c (DEF_VEC_I(offset_type)): Remove.
1027
1028 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
1029
1030         * filename-seen-cache.h: Add include guard.
1031
1032 2018-03-26  Keith Seitz  <keiths@redhat.com>
1033
1034         * symfile.c (place_section): Remove "struct" from section_addr_info
1035         in comment.
1036         * windows-nat.c (struct safe_symbol_file_add_args) <addrs>: Remove
1037         "struct" keyword from section_addr_info.
1038
1039 2018-03-26  Alan Hayward  <alan.hayward@arm.com>
1040
1041         * regformats/regdef.h (reg): Add constructors.
1042
1043 2018-03-25  Pedro Alves  <palves@redhat.com>
1044
1045         * eval.c (evaluate_funcall): Swap OP_VAR_MSYM_VALUE/OP_VAR_VALUE
1046         if then/else bodies in var_func_name extraction.
1047
1048 2018-03-23  Weimin Pan  <weimin.pan@oracle.com>
1049
1050         * minsyms.c (lookup_minimal_symbol_and_objfile): Use
1051         lookup_minimal_symbol() to find symbol entry.
1052         * minsyms.h (lookup_minimal_symbol_and_objfile): Update comment.
1053
1054 2018-03-23  Keith Seitz  <keiths@redhat.com>
1055
1056         PR c++/22968
1057         * dwarf2read.c (scan_partial_symbols): Scan structs/classes for
1058         nested type definitions for C++, too.
1059
1060 2018-03-23  Tom Tromey  <tom@tromey.com>
1061
1062         * machoread.c (struct oso_el): Add a constructor.  Don't define as
1063         a typedef.
1064         (macho_register_oso): Remove.
1065         (macho_symtab_read): Take a std::vector.
1066         (oso_el_compare_name): Now a std::sort comparator.
1067         (macho_symfile_read_all_oso): Take a std::vector.
1068         (macho_symfile_read): Use std::vector.  Remove cleanups.
1069
1070 2018-03-22  Tom Tromey  <tom@tromey.com>
1071
1072         * record-full.c (record_full_exec_insn): Use gdb::byte_vector.
1073         (record_full_goto_bookmark): Use std::string.
1074
1075 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
1076
1077         PR tdep/18295
1078         * rs6000-tdep.c (skip_prologue): Match both stwux and stdux
1079         a single mask.
1080
1081 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
1082
1083         * rs6000-tdep.c (store_insn_p): New function.
1084         (skip_prologue): New variable alloca_reg_offset. Set lr_reg
1085         and cr_reg to their unshifted values. Use store_insn_p to
1086         match LR saves using either R1 or fdata->alloca_reg. Use
1087         store_insn_p to match CR saves. Set alloca_reg_offset
1088         when alloca_reg and framep are set. Remove lr_reg shift
1089         when assigning to fdata->lr_register.
1090
1091 2018-03-22  Andreas Arnez  <arnez@linux.vnet.ibm.com>
1092
1093         * linux-tdep.c (linux_info_proc): For "info proc cmdline", print
1094         command line args instead of emitting a warning.
1095
1096 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
1097
1098         * tracepoint.h (struct static_tracepoint_marker): Initialize
1099         fields, define default constructor, move constructor and move
1100         assignment, disable the rest.
1101         <str_id, extra>: Make std::string.
1102         (release_static_tracepoint_marker): Remove.
1103         (free_current_marker): Remove.
1104         * tracepoint.c (free_current_marker): Remove.
1105         (parse_static_tracepoint_marker_definition): Adjust to
1106         std::string, use new hex2str overload.
1107         (release_static_tracepoint_marker): Remove.
1108         (print_one_static_tracepoint_marker): Get marker by reference
1109         and adjust to std::string.
1110         (info_static_tracepoint_markers_command): Adjust to std::vector
1111         changes
1112         * target.h (static_tracepoint_marker_p): Remove typedef.
1113         (DEF_VEC_P(static_tracepoint_marker_p)): Remove.
1114         (struct target_ops) <to_static_tracepoint_marker_at>: Return
1115         bool.
1116         <to_static_tracepoint_markers_by_strid>: Return std::vector.
1117         * target-debug.h
1118         (target_debug_print_VEC_static_tracepoint_marker_p_p): Remove.
1119         (target_debug_print_std_vector_static_tracepoint_marker): New.
1120         (target_debug_print_struct_static_tracepoint_marker_p): Rename
1121         to...
1122         (target_debug_print_static_tracepoint_marker_p): ... this.
1123         * target-delegates.c: Re-generate.
1124         * breakpoint.h (struct tracepoint) <static_trace_marker_id>:
1125         Make std::string.
1126         * breakpoint.c (init_breakpoint_sal): Adjust to std::string.
1127         (decode_static_tracepoint_spec): Adjust to std::vector.
1128         (tracepoint_print_one_detail): Adjust to std::string.
1129         (strace_marker_decode_location): Adjust to std::string.
1130         (update_static_tracepoint): Adjust to std::string, remove call
1131         to release_static_tracepoint_marker.
1132         * linux-nat.c (linux_child_static_tracepoint_markers_by_strid):
1133         Adjust to std::vector.
1134         * remote.c (remote_static_tracepoint_marker_at): Return bool.
1135         (remote_static_tracepoint_markers_by_strid): Adjust to
1136         std::vector.
1137         * common/rsp-low.h (hex2str): New overload with explicit count
1138         of bytes.
1139         * common/rsp-low.c (hex2str): New overload with explicit count
1140         of bytes.
1141         * unittests/rsp-low-selftests.c (test_hex2str): New function.
1142         (_initialize_rsp_low_selftests): Add test_hex2str test.
1143         * unittests/tracepoint-selftests.c
1144         (test_parse_static_tracepoint_marker_definition): Adjust to
1145         std::string.
1146
1147 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
1148
1149         * tracepoint.c (parse_static_tracepoint_marker_definition):
1150         Consider case where the definition is followed by more
1151         definitions.
1152         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1153         tracepoint-selftests.c.
1154         * unittests/tracepoint-selftests.c: New.
1155
1156 2018-03-21  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
1157
1158         * MAINTAINERS (Write After Approval): Add Pedro Franco de
1159         Carvalho.
1160
1161 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
1162
1163         * symtab.c (find_pc_sect_line): fixed indentation.
1164
1165 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
1166
1167         * symtab.c (find_pc_sect_line): now uses binary search.
1168
1169 2018-03-19  Tom Tromey  <tom@tromey.com>
1170
1171         * rust-exp.y (struct_expr_tail, struct_expr_list): Add plain
1172         "IDENT" production.
1173
1174 2018-03-19  Pedro Alves  <palves@redhat.com>
1175             Tom Tromey  <tom@tromey.com>
1176
1177         * unittests/observable-selftests.c: New file.
1178         * common/observable.h: New file.
1179         * observable.h: New file.
1180         * ada-lang.c, ada-tasks.c, agent.c, aix-thread.c, annotate.c,
1181         arm-tdep.c, auto-load.c, auxv.c, break-catch-syscall.c,
1182         breakpoint.c, bsd-uthread.c, cli/cli-interp.c, cli/cli-setshow.c,
1183         corefile.c, dummy-frame.c, event-loop.c, event-top.c, exec.c,
1184         extension.c, frame.c, gdbarch.c, guile/scm-breakpoint.c,
1185         infcall.c, infcmd.c, inferior.c, inflow.c, infrun.c, jit.c,
1186         linux-tdep.c, linux-thread-db.c, m68klinux-tdep.c,
1187         mi/mi-cmd-break.c, mi/mi-interp.c, mi/mi-main.c, objfiles.c,
1188         ppc-linux-nat.c, ppc-linux-tdep.c, printcmd.c, procfs.c,
1189         python/py-breakpoint.c, python/py-finishbreakpoint.c,
1190         python/py-inferior.c, python/py-unwind.c, ravenscar-thread.c,
1191         record-btrace.c, record-full.c, record.c, regcache.c, remote.c,
1192         riscv-tdep.c, sol-thread.c, solib-aix.c, solib-spu.c, solib.c,
1193         spu-multiarch.c, spu-tdep.c, stack.c, symfile-mem.c, symfile.c,
1194         symtab.c, thread.c, top.c, tracepoint.c, tui/tui-hooks.c,
1195         tui/tui-interp.c, valops.c: Update all users.
1196         * tui/tui-hooks.c (tui_bp_created_observer)
1197         (tui_bp_deleted_observer, tui_bp_modified_observer)
1198         (tui_inferior_exit_observer, tui_before_prompt_observer)
1199         (tui_normal_stop_observer, tui_register_changed_observer):
1200         Remove.
1201         (tui_observers_token): New global.
1202         (attach_or_detach, tui_attach_detach_observers): New functions.
1203         (tui_install_hooks, tui_remove_hooks): Use
1204         tui_attach_detach_observers.
1205         * record-btrace.c (record_btrace_thread_observer): Remove.
1206         (record_btrace_thread_observer_token): New global.
1207         * observer.sh: Remove.
1208         * observer.c: Rename to observable.c.
1209         * observable.c (namespace gdb_observers): Define new objects.
1210         (observer_debug): Move into gdb_observers namespace.
1211         (struct observer, struct observer_list, xalloc_observer_list_node)
1212         (xfree_observer_list_node, generic_observer_attach)
1213         (generic_observer_detach, generic_observer_notify): Remove.
1214         (_initialize_observer): Update.
1215         Don't include observer.inc.
1216         * Makefile.in (generated_files): Remove observer.h, observer.inc.
1217         (clean mostlyclean): Likewise.
1218         (observer.h, observer.inc): Remove targets.
1219         (SUBDIR_UNITTESTS_SRCS): Add observable-selftests.c.
1220         (COMMON_SFILES): Use observable.c, not observer.c.
1221         * .gitignore: Remove observer.h.
1222
1223 2018-03-18  Tom Tromey  <tom@tromey.com>
1224
1225         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Use
1226         gdb::def_vector.
1227         (bfd_lookup_symbol_from_dyn_symtab): Likewise.
1228
1229 2018-03-17  Tom Tromey  <tom@tromey.com>
1230
1231         * auto-load.c (auto_load_objfile_script_1): Use std::string.
1232
1233 2018-03-17  Tom Tromey  <tom@tromey.com>
1234
1235         * target.c (class scoped_target_fd): New.
1236         (target_fileio_close_cleanup): Remove.
1237         (target_fileio_read_alloc_1): Use scoped_target_fd.
1238
1239 2018-03-16  Simon Marchi  <simon.marchi@polymtl.ca>
1240
1241         * silent-rules.mk: New.
1242         * Makefile.in: Include silent-rules.mk
1243         (srcdir, VPATH, top_srcdir): Move up.
1244         (COMPILE): Add ECHO_CXX.
1245         (test-cp-name-parser$(EXEEXT)): Add ECHO_CXXLD.
1246         (init.c): Add ECHO_INIT_C.
1247         (gdb$(EXEEXT)): Add SILENCE and ECHO_CXXLD.
1248         (version.c): Add ECHO_GEN.
1249         (printcmd.o): Add ECHO_CXX.
1250         (target-float.o): Add ECHO_CXX.
1251         (ada-exp.o): Add ECHO_CXX.
1252         (stamp-xml): Add SILENCE and ECHO_GEN_XML_BUILTIN.
1253         (insight$(EXEEXT)): Add ECHO_CXXLD.
1254         * gnulib/configure.ac: Add AM_SILENT_RULES.
1255         * gnulib/aclocal.m4: Re-generate.
1256         * gnulib/configure: Re-generate.
1257         * gnulib/import/Makefile.in: Re-generate.
1258
1259 2018-03-16  Tom Tromey  <tom@tromey.com>
1260
1261         * xcoffread.c (xcoff_symfile_offsets): Change type of "addrs".
1262         * utils.h (make_cleanup_free_section_addr_info): Don't declare.
1263         * utils.c (do_free_section_addr_info)
1264         (make_cleanup_free_section_addr_info): Remove.
1265         * symfile.h (struct other_sections): Add constructor.
1266         (struct section_addr_info): Remove.
1267         (section_addr_info): New typedef.
1268         (struct sym_fns) <sym_offsets>: Change type of parameter.
1269         (build_section_addr_info_from_objfile)
1270         (relative_addr_info_to_section_offsets, addr_info_make_relative)
1271         (default_symfile_offsets, symbol_file_add)
1272         (symbol_file_add_from_bfd)
1273         (build_section_addr_info_from_section_table): Update.
1274         (alloc_section_addr_info, free_section_addr_info): Don't declare.
1275         * symfile.c (alloc_section_addr_info): Remove.
1276         (build_section_addr_info_from_section_table): Change return type.
1277         Update.
1278         (build_section_addr_info_from_bfd)
1279         (build_section_addr_info_from_objfile): Likewise.
1280         (free_section_addr_info): Remove.
1281         (relative_addr_info_to_section_offsets): Change type of "addrs".
1282         (addrs_section_compar): Now a std::sort comparator.
1283         (addrs_section_sort): Change return type.
1284         (addr_info_make_relative): Change type of "addrs".  Update.
1285         (default_symfile_offsets, syms_from_objfile_1)
1286         (syms_from_objfile, symbol_file_add_with_addrs): Likewise.
1287         (symbol_file_add_separate): Update.
1288         (symbol_file_add): Change type of "addrs".  Update.
1289         (add_symbol_file_command): Update.  Remove cleanups.
1290         * symfile-mem.c (symbol_file_add_from_memory): Update.  Remove
1291         cleanups.
1292         * symfile-debug.c (debug_sym_offsets): Change type of "info".
1293         * solib.c (solib_read_symbols): Update.
1294         * objfiles.c (objfile_relocate): Update.  Remove cleanups.
1295         * machoread.c (macho_symfile_offsets): Update.
1296         * jit.c (jit_bfd_try_read_symtab): Update.
1297
1298 2018-03-15  Simon Marchi  <simon.marchi@polymtl.ca>
1299
1300         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1301         unittests/utils-selftests.c.
1302         * unittests/utils-selftests.c: New file.
1303
1304 2018-03-14  Tom Tromey  <tom@tromey.com>
1305
1306         PR cli/14977:
1307         * printcmd.c (printf_c_string, printf_wide_c_string): Special case
1308         for NULL.
1309
1310 2018-03-14  Tom Tromey  <tom@tromey.com>
1311
1312         PR cli/19918:
1313         * printcmd.c (printf_pointer): Allow "-" in format.
1314
1315 2018-03-14  Tom Tromey  <tom@tromey.com>
1316
1317         * printcmd.c (_initialize_printcmd): Add usage to printf.
1318
1319 2018-03-14  Yao Qi  <qiyao@sourceware.org>
1320
1321         * MAINTAINERS: Update my email address.
1322
1323 2018-03-13  Tom Tromey  <tom@tromey.com>
1324
1325         * machoread.c (macho_check_dsym): Change filenamep to a
1326         std::string*.
1327         (macho_symfile_read): Update.
1328         * symfile.c (load_command): Use std::string.
1329
1330 2018-03-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1331
1332         * riscv-tdep.c (riscv_sw_breakpoint_from_kind): Add localization
1333         to error message string.
1334         (riscv_register_name): Use xsnprintf instead of sprintf.
1335         (riscv_insn::fetch_instruction): Use gdb_assert instead of
1336         internal_error.
1337         (riscv_print_arg_location): Use gdb_assert_not_reached instead of
1338         error.
1339         (riscv_push_dummy_call): Likewise.
1340
1341 2018-03-12  Tom Tromey  <tom@tromey.com>
1342
1343         * rs6000-aix-tdep.c (rs6000_aix_core_xfer_shared_libraries_aix):
1344         Use gdb::byte_vector.
1345         * arm-tdep.c (arm_exidx_new_objfile): Use gdb::byte_vector.
1346
1347 2018-03-12  Yao Qi  <yao.qi@linaro.org>
1348
1349         * ia64-libunwind-tdep.c (libunwind_get_reg_special): Change
1350         parameter type to readable_regcache.
1351         * ia64-libunwind-tdep.h (libunwind_get_reg_special): Update
1352         the declaration.
1353
1354 2018-03-11  Tom Tromey  <tom@tromey.com>
1355
1356         * dwarf2read.c (struct nextfield): Add initializers.
1357         (struct nextfnfield): Remove.
1358         (struct fnfieldlist): Add initializers.  Remove "length" and
1359         "head", use std::vector.
1360         (struct decl_field_list): Remove.
1361         (struct field_info): Add initializers.
1362         <fields, baseclasses>: Now std::vector.
1363         <nbaseclasses, nfnfields, typedef_field_list_count,
1364         nested_types_list_count>: Remove.
1365         (dwarf2_add_field, dwarf2_add_type_defn)
1366         (dwarf2_attach_fields_to_type, dwarf2_add_member_fn)
1367         (dwarf2_attach_fn_fields_to_type, handle_struct_member_die)
1368         (process_structure_scope): Update.
1369
1370 2018-03-11  Tom Tromey  <tom@tromey.com>
1371
1372         * dwarf2read.c (sort_tu_by_abbrev_offset): Change to be suitable
1373         for use by std::sort.
1374         (build_type_psymtabs_1): Use std::vector.
1375
1376 2018-03-09  Eli Zaretskii  <eliz@gnu.org>
1377
1378         * top.c (print_gdb_configuration): Reflect LIBIPT, LIBMEMCHECK,
1379         and LIBMPFR in the printed configuration.
1380
1381 2018-03-08  Tom Tromey  <tom@tromey.com>
1382
1383         * source.c (get_filename_and_charpos): Use scoped_fd.
1384         * nto-procfs.c (procfs_open_1): Use scoped_fd.
1385         (procfs_pidlist): Likewise.
1386         * procfs.c (proc_get_LDT_entry): Use scoped_fd.
1387         (iterate_over_mappings): Likewise.
1388
1389 2018-03-08  Tom Tromey  <tom@tromey.com>
1390
1391         * infcall.c (struct call_return_meta_info)
1392         <stack_temporaries_enabled>: Remove.
1393         (get_call_return_value, call_function_by_hand_dummy): Update.
1394         * thread.c (disable_thread_stack_temporaries): Remove.
1395         (enable_thread_stack_temporaries): Remove.
1396         (thread_stack_temporaries_enabled_p): Return bool.
1397         (push_thread_stack_temporary, value_in_thread_stack_temporaries)
1398         (get_last_thread_stack_temporary): Update.
1399         * eval.c (evaluate_subexp): Update.
1400         * gdbthread.h (class enable_thread_stack_temporaries): Now a
1401         class, not a function.
1402         (value_ptr, value_vec): Remove typedefs.
1403         (class thread_info) <stack_temporaries_enabled>: Now bool.
1404         <stack_temporaries>: Now a std::vector.
1405         (thread_stack_temporaries_enabled_p)
1406         (value_in_thread_stack_temporaries): Return bool.
1407
1408 2018-03-08  Simon Marchi  <simon.marchi@ericsson.com>
1409
1410         * remote.c (putpkt_binary): Fix omitted bytes reporting.
1411         (getpkt_or_notif_sane_1): Likewise.
1412
1413 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
1414
1415         * build-id.c (build_id_to_debug_bfd): Use std::string.
1416
1417 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
1418
1419         * build-id.c (find_separate_debug_file_by_buildid): Return
1420         std::string.
1421         * build-id.h (find_separate_debug_file_by_buildid): Return
1422         std::string.
1423         * coffread.c (coff_symfile_read): Adjust to std::string.
1424         * elfread.c (elf_symfile_read): Adjust to std::string.
1425         * symfile.c (separate_debug_file_exists): Change parameter to
1426         std::string.
1427         (find_separate_debug_file): Return std::string.
1428         (find_separate_debug_file_by_debuglink): Return std::string.
1429         * symfile.h (find_separate_debug_file_by_debuglink): Return
1430         std::string.
1431
1432 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
1433
1434         * common/xml-utils.c (xml_escape_text): Move code to...
1435         (xml_escape_text_append): ... this new function.
1436         * common/xml-utils.h (xml_escape_text_append): New declaration.
1437         * unittests/xml-utils-selftests.c (test_xml_escape_text_append):
1438         New function.
1439         (_initialize_xml_utils): register test_xml_escape_text_append as
1440         a selftest.
1441
1442 2018-03-07  Alan Hayward  <alan.hayward@arm.com>
1443
1444         * defs.h: Remove MAX_REGISTER_SIZE.
1445         * regcache.c (init_regcache_descr): Remove MAX_REGISTER_SIZE
1446         asserts.
1447         * python/py-unwind.c (pyuw_sniffer): Likewise.
1448
1449 2018-03-07  Tom Tromey  <tom@tromey.com>
1450
1451         * linux-tdep.c (linux_info_proc): Update.
1452         * target.h (struct target_ops) <to_fileio_readlink>: Return
1453         optional<string>.
1454         (target_fileio_readlink): Return optional<string>.
1455         * remote.c (remote_hostio_readlink): Return optional<string>.
1456         * inf-child.c (inf_child_fileio_readlink): Return
1457         optional<string>.
1458         * target.c (target_fileio_readlink): Return optional<string>.
1459
1460 2018-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1461
1462         * regcache.c (cooked_read_test): Add riscv to the list of
1463         architectures that have a save_reggroup.
1464
1465 2018-03-07  Andreas Arnez  <arnez@linux.vnet.ibm.com>
1466
1467         * gnu-v3-abi.c (gnuv3_rtti_type): Add early exit if the given
1468         value is not a dynamic class object.
1469
1470 2018-03-06  Tom Tromey  <tom@tromey.com>
1471
1472         * rust-exp.y: Formatting fixes.
1473
1474 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1475
1476         * riscv-tdep.c (riscv_register_name): Remove target description
1477         support.
1478         (riscv_gdbarch_init): Remove target description check.
1479
1480 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1481
1482         * riscv-tdep.c: Remove 'Contributed by ...' lines from header
1483         comment.
1484         * riscv-tdep.h: Likewise.
1485
1486 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1487
1488         * riscv-tdep.c (riscv_pseudo_register_read): Delete.
1489         (riscv_pseudo_register_write): Delete.
1490         (riscv_gdbarch_init): Remove all use of pseudo registers.
1491
1492 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
1493
1494         * record-btrace.c (btrace_print_lines): Replace cleanup
1495         parameter with RAII equivalents.
1496         (btrace_insn_history): Replace cleanup with RAII equivalents.
1497         * ui-out.h (make_cleanup_ui_out_list_begin_end,
1498         make_cleanup_ui_out_tuple_begin_end): Remove.
1499         * ui-out.c (struct ui_out_end_cleanup_data, do_cleanup_end,
1500         make_cleanup_ui_out_end, make_cleanup_ui_out_tuple_begin_end,
1501         make_cleanup_ui_out_list_begin_end): Remove.
1502
1503 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
1504
1505         * record-btrace.c (record_btrace_maybe_mark_async_event): Change
1506         parameter types to std::vector.  Use bool.
1507         (record_btrace_wait): Replace VEC(tp_t) with
1508         std::vector<thread_info *>.
1509         * common/gdb_vecs.h (unordered_remove, ordered_remove): New.
1510
1511 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
1512
1513         * record-btrace.c (record_btrace_disable_callback): Remove.
1514         (struct scoped_btrace_disable): New.
1515         (record_btrace_open): Use scoped_btrace_disable.
1516
1517 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1518
1519         * riscv-tdep.c (riscv_return_value): Change type to ULONGEST for
1520         reading values from registers.
1521
1522 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1523
1524         * riscv-tdep.c (riscv_push_dummy_call): Use core_addr_to_string_nz
1525         where appropriate.
1526
1527 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1528
1529         * riscv-tdep.c (riscv_print_arg_location): Add header comment,
1530         change parameter type.  Use GDB's print functions, and use
1531         core_addr_to_string where appropriate.
1532         (riscv_push_dummy_call): Use core_addr_to_string where
1533         appropriate, update call to riscv_print_arg_location, and reindent
1534         a few lines.
1535         (riscv_return_value): Update call to riscv_print_arg_location.
1536
1537 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1538             Tim Newsome <tim@sifive.com>
1539             Albert Ou <a0u@eecs.berkeley.edu>
1540             Darius Rad <darius@bluespec.com>
1541
1542         * Makefile.in (ALL_TARGET_OBS): Add riscv-tdep.o
1543         (HFILES_NO_SRCDIR): Add riscv-tdep.h.
1544         (ALLDEPFILES): Add riscv-tdep.c
1545         * configure.tgt: Add riscv support.
1546         * riscv-tdep.c: New file.
1547         * riscv-tdep.h: New file.
1548         * NEWS: Mention new target.
1549         * MAINTAINERS: Add entry for riscv.
1550
1551 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1552
1553         * amd64-tdep.c (amd64_classify_aggregate): Ignore zero sized
1554         fields within aggregates.
1555
1556 2018-03-04  Simon Marchi  <simon.marchi@polymtl.ca>
1557
1558         * record-btrace.c (btrace_print_lines): Change type of flags to
1559         gdb_disassembly_flags.
1560
1561 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
1562
1563         * fbsd-nat.c: Include "inf-ptrace.h".
1564         (USE_SIGTRAP_SIGINFO): Conditionally define.
1565         [USE_SIGTRAP_SIGINFO] (fbsd_handle_debug_trap): New function.
1566         (fbsd_wait) [USE_SIGTRAP_SIGINFO]: Call "fbsd_handle_debug_trap".
1567         [USE_SIGTRAP_SIGINFO] (fbsd_stopped_by_sw_breakpoint): New
1568         function.
1569         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_sw_breakpoint):
1570         Likewise.
1571         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_hw_breakpoint):
1572         Likewise.
1573         (fbsd_nat_add_target) [USE_SIGTRAP_SIGINFO]: Set
1574         "stopped_by_sw_breakpoint", "supports_stopped_by_sw_breakpoint",
1575         "supports_stopped_by_hw_breakpoint" target methods.
1576
1577 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
1578
1579         * NEWS (Changes since GDB 8.1): Add "set/show debug fbsd-nat".
1580         * fbsd-nat.c (debug_fbsd_nat): New variable.
1581         (show_fbsd_nat_debug): New function.
1582         (fbsd_wait): Log LWP info if "debug_fbsd_nat" is enabled.
1583         (_initialize_fbsd_nat): Add "fbsd-nat" debug boolean command.
1584
1585 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
1586
1587         * nat/x86-dregs.c (x86_dr_stopped_by_hw_breakpoint): New function.
1588         * nat/x86-dregs.h (x86_dr_stopped_by_hw_breakpoint): New
1589         prototype.
1590         * x86-nat.c (x86_stopped_by_hw_breakpoint): New function.
1591         (x86_use_watchpoints): Set "stopped_by_hw_breakpoint" target
1592         method.
1593
1594 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
1595
1596         * common/gdb_vecs.c (free_char_ptr_vec): Remove.
1597         * common/gdb_vecs.h (free_char_ptr_vec): Remove.
1598
1599 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
1600
1601         * charset.c (struct charset_vector): New.
1602         (charsets): Change type to charset_vector.
1603         (find_charset_names): Adjust.
1604         (add_one): Adjust.
1605         (_initialize_charset): Adjust.
1606
1607 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
1608
1609         * progspace.h (struct program_space) <deleted_solibs>: Change
1610         type to std::vector<std::string>.
1611         * progspace.c (clear_program_space_solib_cache): Adjust.
1612         * breakpoint.c (print_solib_event): Adjust.
1613         (check_status_catch_solib): Adjust.
1614         * solib.c (update_solib_list): Adjust.
1615         * ui-out.h (class ui_out) <field_string>: New overload.
1616         * ui-out.c (ui_out::field_string): New overload.
1617
1618 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
1619
1620         * progspace.h (struct program_space): Add constructor and
1621         destructor, initialize fields.
1622         (add_program_space): Remove.
1623         * progspace.c (add_program_space): Rename to...
1624         (program_space::program_space): ... this.
1625         (release_program_space): Rename to...
1626         (program_space::~program_space): ... this.
1627         (delete_program_space): Use delete to delete program_space.
1628         (initialize_progspace): Use new to allocate program_space.
1629         * inferior.c (add_inferior_with_spaces): Likewise.
1630         (clone_inferior_command): Likewise.
1631         * infrun.c (follow_fork_inferior): Likewise.
1632         (handle_vfork_child_exec_or_exit): Likewise.
1633
1634 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
1635
1636         * common/gdb_vecs.h (make_cleanup_free_char_ptr_vec): Remove.
1637         (delim_string_to_char_ptr_vec): Return std::vector of
1638         gdb::unique_xmalloc_ptr.
1639         (dirnames_to_char_ptr_vec_append): Take std::vector of
1640         gdb::unique_xmalloc_ptr.
1641         (dirnames_to_char_ptr_vec): Return std::vector of
1642         gdb::unique_xmalloc_ptr.
1643         * common/gdb_vecs.c (delim_string_to_char_ptr_vec_append):
1644         Take std::vector of gdb::unique_xmalloc_ptr, adjust the code.
1645         (delim_string_to_char_ptr_vec): Return an std::vector of
1646         gdb::unique_xmalloc_ptr, adjust the code.
1647         (dirnames_to_char_ptr_vec_append): Take an std::vector of
1648         gdb::unique_xmalloc_ptr, adjust the code.
1649         (dirnames_to_char_ptr_vec): Return an std::vector of
1650         gdb::unique_xmalloc_ptr, adjust the code.
1651         * auto-load.c (auto_load_safe_path_vec): Change type to
1652         std::vector of gdb::unique_xmalloc_ptr.
1653         (auto_load_expand_dir_vars): Return an std::vector of
1654         gdb::unique_xmalloc_ptr, adjust the code.
1655         (auto_load_safe_path_vec_update): Adjust.
1656         (filename_is_in_auto_load_safe_path_vec): Adjust.
1657         (auto_load_objfile_script_1): Adjust.
1658         * build-id.c (build_id_to_debug_bfd): Adjust.
1659         * linux-thread-db.c (thread_db_load_search): Adjust.
1660         * source.c (add_path): Adjust.
1661         (openp): Adjust.
1662         * symfile.c (find_separate_debug_file): Adjust.
1663         * utils.c (do_free_char_ptr_vec): Remove.
1664         (make_cleanup_free_char_ptr_vec): Remove.
1665
1666 2018-03-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1667
1668         PR gdb/22907
1669         * common/pathstuff.c: Conditionally include "<windows.h>".
1670
1671 2018-03-01  Georg Sauthoff  <mail@georg.so>
1672
1673         PR gdb/22888
1674         * gcore.in: Quote variables and switch interpreter to bash.
1675
1676 2018-03-01  Tom Tromey  <tom@tromey.com>
1677
1678         * dwarf2read.c (alloc_discriminant_info): Fix default_index
1679         assertion.  Add assertion for discriminant_index.
1680         (quirk_rust_enum): Use correct base type name in univariant case.
1681
1682 2018-03-01  Simon Marchi  <simon.marchi@ericsson.com>
1683
1684         * record.c (get_call_history_modifiers): Return a
1685         record_print_flags.
1686         (cmd_record_call_history): Adjust.
1687         * record-btrace.c (record_btrace_call_history): Adjust.
1688         (record_btrace_call_history_range): Adjust.
1689         (record_btrace_call_history_from): Adjust.
1690         * target-debug.h (target_debug_print_record_print_flags): New.
1691         * target-delegates.c: Re-generate.
1692         * target.c (target_call_history): Change flags type.
1693         (target_call_history_from): Likewise.
1694         (target_call_history_range): Likewise.
1695         * target.h (struct target_ops) <target_call_history>: Likewise.
1696         (target_call_history_from): Likewise.
1697         (target_call_history_range): Likewise.
1698
1699 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1700             Simon Marchi  <simon.marchi@polymtl.ca>
1701
1702         * common/common-utils.c: Include "sys/stat.h".
1703         (is_regular_file): Move here from "source.c"; change return
1704         type to "bool".
1705         * common/common-utils.h (is_regular_file): New prototype.
1706         * common/pathstuff.c (contains_dir_separator): New function.
1707         * common/pathstuff.h (contains_dir_separator): New prototype.
1708         * source.c: Don't include "sys/stat.h".
1709         (is_regular_file): Move to "common/common-utils.c".
1710
1711 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1712
1713         * Makefile.in (COMMON_SFILES): Add "common/pathstuff.c".
1714         (HFILES_NO_SRCDIR): Add "common/pathstuff.h".
1715         * auto-load.c: Include "common/pathstuff.h".
1716         * common/common-def.h (current_directory): Move here.
1717         * common/gdb_tilde_expand.c (gdb_tilde_expand_up): New
1718         function.
1719         * common/gdb_tilde_expand.h (gdb_tilde_expand_up): New
1720         prototype.
1721         * common/pathstuff.c: New file.
1722         * common/pathstuff.h: New file.
1723         * compile/compile.c: Include "common/pathstuff.h".
1724         * defs.h (current_directory): Move to "common/common-defs.h".
1725         * dwarf2read.c: Include "common/pathstuff.h".
1726         * exec.c: Likewise.
1727         * guile/scm-safe-call.c: Likewise.
1728         * linux-thread-db.c: Likewise.
1729         * main.c: Likewise.
1730         * nto-tdep.c: Likewise.
1731         * objfiles.c: Likewise.
1732         * source.c: Likewise.
1733         * symtab.c: Likewise.
1734         * utils.c: Include "common/pathstuff.h".
1735         (gdb_realpath): Move to "common/pathstuff.c".
1736         (gdb_realpath_keepfile): Likewise.
1737         (gdb_abspath): Likewise.
1738         * utils.h (gdb_realpath): Move to "common/pathstuff.h".
1739         (gdb_realpath_keepfile): Likewise.
1740         (gdb_abspath): Likewise.
1741
1742 2018-02-28  John Baldwin  <jhb@FreeBSD.org>
1743
1744         * fbsd-nat.c (fbsd_resume): Use PT_SETSTEP for stepping and a
1745         wildcard process pid for super_resume for kernels with a
1746         specific bug.
1747
1748 2018-02-27  Phil Muldoon  <pmuldoon@redhat.com>
1749
1750         * compile/compile.c (get_args): Add additional comments
1751         explaining function.
1752
1753 2018-02-27  Simon Marchi  <simon.marchi@polymtl.ca>
1754             Tom Tromey  <tom@tromey.com>
1755
1756         * target.h (memory_write_request_s): Remove typedef.  Don't define
1757         VEC.
1758         (target_write_memory_blocks): Change argument to std::vector.
1759         (struct memory_write_request): Add constructor.
1760         * target-memory.c (compare_block_starting_address): Return bool.
1761         Change argument types.
1762         (claim_memory): Change arguments to use std::vector.
1763         (split_regular_and_flash_blocks, blocks_to_erase)
1764         (compute_garbled_blocks): Likewise.
1765         (cleanup_request_data, cleanup_write_requests_vector): Remove.
1766         (target_write_memory_blocks): Change argument to std::vector.
1767         * symfile.c (struct load_section_data): Add constructor and
1768         destructor.  Use std::vector for "requests".
1769         (struct load_progress_data): Add initializers.
1770         (load_section_callback): Update.  Use "new".
1771         (clear_memory_write_data): Remove.
1772         (generic_load): Update.
1773
1774 2018-02-27  Alan Hayward  <alan.hayward@arm.com>
1775
1776         * arch/aarch64.h: Use common/tdesc.h.
1777
1778 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
1779
1780         * mips-tdep.c (mips_gdbarch_init): Don't use a 32-bit BFD
1781         architecture with a 64-bit ABI.
1782
1783 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
1784
1785         * gdb/mips-tdep.c (mips_gdbarch_init): Reorder ABI determination
1786         ahead of target description loading.
1787
1788 2018-02-26  Tom Tromey  <tom@tromey.com>
1789
1790         * stack.c (backtrace_command_1): Update.
1791         * python/python-internal.h (gdbpy_apply_frame_filter): Change type
1792         of "flags".
1793         * python/py-framefilter.c (py_print_frame)
1794         (gdbpy_apply_frame_filter): Change type of "flags".
1795         * mi/mi-cmd-stack.c (mi_apply_ext_lang_frame_filter): Change type
1796         of "flags".
1797         (mi_cmd_stack_list_frames, mi_cmd_stack_list_locals)
1798         (mi_cmd_stack_list_args, mi_cmd_stack_list_variables): Update.
1799         * extension.h (enum frame_filter_flag): Rename from
1800         frame_filter_flags.
1801         (frame_filter_flags): Define using DEF_ENUM_FLAGS_TYPE.
1802         (apply_ext_lang_frame_filter): Change type of "flags".
1803         * extension.c (apply_ext_lang_frame_filter): Change type of
1804         "flags".
1805         * extension-priv.h (struct extension_language_ops)
1806         <apply_frame_filter>: Change type of "flags".
1807
1808 2018-02-26  Tom Tromey  <tom@tromey.com>
1809
1810         PR python/16497:
1811         * stack.c (backtrace_command_1): Set PRINT_MORE_FRAMES flag.  Fix
1812         off-by-one in py_end computation.
1813         * python/py-framefilter.c (gdbpy_apply_frame_filter): Handle
1814         PRINT_MORE_FRAMES.
1815         * extension.h (enum frame_filter_flags) <PRINT_MORE_FRAMES>: New
1816         constant.
1817
1818 2018-02-26  Tom Tromey  <tom@tromey.com>
1819
1820         * dwarf2read.c (struct variant_field): New.
1821         (struct nextfield) <variant>: New field.
1822         (dwarf2_add_field): Handle DW_TAG_variant_part.
1823         (dwarf2_attach_fields_to_type): Attach a discriminant_info to a
1824         discriminated union.
1825         (read_structure_type): Handle DW_TAG_variant_part.
1826         (handle_struct_member_die): New function, extracted from
1827         process_structure_scope.  Handle DW_TAG_variant.
1828         (process_structure_scope): Handle discriminated unions.  Call
1829         handle_struct_member_die.
1830
1831 2018-02-26  Tom Tromey  <tom@tromey.com>
1832
1833         * rust-lang.h (rust_last_path_segment): Declare.
1834         * rust-lang.c (rust_last_path_segment): Now public.  Change
1835         contract.
1836         (struct disr_info): Remove.
1837         (RUST_ENUM_PREFIX, RUST_ENCODED_ENUM_REAL)
1838         (RUST_ENCODED_ENUM_HIDDEN, rust_union_is_untagged)
1839         (rust_get_disr_info, rust_tuple_variant_type_p): Remove.
1840         (rust_enum_p, rust_enum_variant): New function.
1841         (rust_underscore_fields): Remove "offset" parameter.
1842         (rust_print_enum): New function.
1843         (rust_val_print) <TYPE_CODE_UNION>: Remove enum code.
1844         <TYPE_CODE_STRUCT>: Call rust_print_enum when appropriate.
1845         (rust_print_struct_def): Add "for_rust_enum" parameter.  Handle
1846         enums.
1847         (rust_internal_print_type): New function, from rust_print_type.
1848         Remove enum code.
1849         (rust_print_type): Call rust_internal_print_type.
1850         (rust_evaluate_subexp) <STRUCTOP_ANONYMOUS, STRUCTOP_STRUCT>:
1851         Update enum handling.
1852         * dwarf2read.c (struct dwarf2_cu) <rust_unions>: New field.
1853         (rust_fully_qualify, alloc_discriminant_info, quirk_rust_enum)
1854         (rust_union_quirks): New functions.
1855         (process_full_comp_unit, process_full_type_unit): Call
1856         rust_union_quirks.
1857         (process_structure_scope): Update rust_unions if necessary.
1858
1859 2018-02-26  Tom Tromey  <tom@tromey.com>
1860
1861         * value.h (value_union_variant): Declare.
1862         * valops.c (value_union_variant): New function.
1863         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): New macro.
1864         (struct discriminant_info): New.
1865         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: New
1866         enumerator.
1867         (struct main_type) <flag_discriminated_union>: New field.
1868
1869 2018-02-26  Tom Tromey  <tom@tromey.com>
1870
1871         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1872         unittests/unpack-selftests.c.
1873         * unittests/unpack-selftests.c: New file.
1874         * value.c (unpack_bits_as_long): Fix bugs in non-bitfield cases.
1875
1876 2018-02-26  Yao Qi  <yao.qi@linaro.org>
1877
1878         * dwarf2read.c (struct partial_die_info) <read>: New method.
1879         (read_partial_die): Remove the declaration.
1880         (load_partial_dies): Update.
1881         (partial_die_info::partial_die_info):
1882         (read_partial_die): Change it to partial_die_info::read.
1883
1884 2018-02-26  Yao Qi  <yao.qi@linaro.org>
1885
1886         * dwarf2read.c (struct partial_die_info) <fixup>: New method.
1887         (fixup_partial_die): Remove declaration.
1888         (scan_partial_symbols): Update.
1889         (partial_die_parent_scope): Likewise.
1890         (partial_die_full_name): Likewise.
1891         (fixup_partial_die): Change it to partial_die_info::fixup.
1892
1893 2018-02-26  Yao Qi  <yao.qi@linaro.org>
1894
1895         * dwarf2read.c (read_partial_die): Update the declaration.
1896         (load_partial_dies): Caller update.
1897         (read_partial_die): Remove one argument abbrev_len.
1898
1899 2018-02-26  Yao Qi  <yao.qi@linaro.org>
1900
1901         * dwarf2read.c (struct partial_die_info): Add ctor, delete
1902         assignment operator.
1903         (load_partial_dies): Use ctor and copy ctor.
1904         (read_partial_die): Update.
1905         (dwarf2_cu::find_partial_die): Use ctor.
1906
1907 2018-02-26  Yao Qi  <yao.qi@linaro.org>
1908
1909         * dwarf2read.c (struct dwarf2_cu) <find_partial_die>: New method.
1910         (find_partial_die_in_comp_unit): Change it to
1911         dwarf2_cu::find_partial_die.
1912         (find_partial_die): Update.
1913
1914 2018-02-26  Yao Qi  <yao.qi@linaro.org>
1915
1916         * dwarf2read.c (read_partial_die): Remove the code checking abbrev
1917         is NULL.
1918
1919 2018-02-26  Yao Qi  <yao.qi@linaro.org>
1920
1921         * dwarf2read.c (load_partial_dies): Move the location of XOBNEW.
1922
1923 2018-02-26  Alan Hayward  <alan.hayward@arm.com>
1924
1925         * arch/amd64.h: Use common/tdesc.h.
1926         * arch/i386.c: Likewise.
1927         * arch/i386.h: Likewise.
1928         * arch/tic6x.c: Likewise.
1929         * arch/tdesc.h: Move file from here...
1930         * common/tdesc.h: ...to here.
1931         * features/aarch64-core.c: Regenerate.
1932         * features/aarch64-fpu.c: Regenerate.
1933         * features/i386/32bit-avx.c: Regenerate.
1934         * features/i386/32bit-avx512.c: Regenerate.
1935         * features/i386/32bit-core.c: Regenerate.
1936         * features/i386/32bit-linux.c: Regenerate.
1937         * features/i386/32bit-mpx.c: Regenerate.
1938         * features/i386/32bit-pkeys.c: Regenerate.
1939         * features/i386/32bit-sse.c: Regenerate.
1940         * features/i386/64bit-avx.c: Regenerate.
1941         * features/i386/64bit-avx512.c: Regenerate.
1942         * features/i386/64bit-core.c: Regenerate.
1943         * features/i386/64bit-linux.c: Regenerate.
1944         * features/i386/64bit-mpx.c: Regenerate.
1945         * features/i386/64bit-pkeys.c: Regenerate.
1946         * features/i386/64bit-segments.c: Regenerate.
1947         * features/i386/64bit-sse.c: Regenerate.
1948         * features/i386/x32-core.c: Regenerate.
1949         * features/tic6x-c6xp.c: Regenerate.
1950         * features/tic6x-core.c: Regenerate.
1951         * features/tic6x-gp.c: Regenerate.
1952         * target-descriptions.c: Use common/tdesc.h.
1953         * target-descriptions.h: Likewise.
1954
1955 2018-02-24  Tom Tromey  <tom@tromey.com>
1956
1957         * linux-thread-db.c (try_thread_db_load_from_pdir_1)
1958         (try_thread_db_load_from_dir, thread_db_load_search): Use
1959         std::string.
1960         (info_auto_load_libthread_db_compare): Return bool.  Change
1961         argument types.
1962         (info_auto_load_libthread_db): Use std::vector, std::string.
1963         Remove cleanups.
1964
1965 2018-02-24  Tom Tromey  <tom@tromey.com>
1966
1967         * i386-tdep.c (i386_fast_tracepoint_valid_at): "msg" now a
1968         std::string.
1969         * gdbarch.sh (fast_tracepoint_valid_at): Change "msg" to a
1970         std::string*.
1971         * gdbarch.c: Rebuild.
1972         * gdbarch.h: Rebuild.
1973         * breakpoint.c (check_fast_tracepoint_sals): Use std::string.
1974         * arch-utils.h (default_fast_tracepoint_valid_at): Update.
1975         * arch-utils.c (default_fast_tracepoint_valid_at): "msg" now a
1976         std::string*.
1977
1978 2018-02-23  Simon Marchi  <simon.marchi@polymtl.ca>
1979
1980         * gdbtypes.h (sect_offset): Change type to uint64_t.
1981         (sect_offset_str): New function.
1982         * dwarf2read.c (create_addrmap_from_aranges): Use
1983         sect_offset_str.
1984         (error_check_comp_unit_head): Likewise.
1985         (create_debug_type_hash_table): Likewise.
1986         (read_cutu_die_from_dwo): Likewise.
1987         (init_cutu_and_read_dies): Likewise.
1988         (init_cutu_and_read_dies_no_follow): Likewise.
1989         (process_psymtab_comp_unit_reader): Likewise.
1990         (partial_die_parent_scope): Likewise.
1991         (peek_die_abbrev): Likewise.
1992         (process_queue): Likewise.
1993         (dwarf2_physname): Likewise.
1994         (read_namespace_alias): Likewise.
1995         (read_import_statement): Likewise.
1996         (create_dwo_cu_reader): Likewise.
1997         (create_cus_hash_table): Likewise.
1998         (lookup_dwo_cutu): Likewise.
1999         (inherit_abstract_dies): Likewise.
2000         (read_func_scope): Likewise.
2001         (read_call_site_scope): Likewise.
2002         (dwarf2_add_member_fn): Likewise.
2003         (read_common_block): Likewise.
2004         (read_module_type): Likewise.
2005         (read_typedef): Likewise.
2006         (read_subrange_type): Likewise.
2007         (load_partial_dies): Likewise.
2008         (read_partial_die): Likewise.
2009         (find_partial_die): Likewise.
2010         (read_str_index): Likewise.
2011         (dwarf2_string_attr): Likewise.
2012         (build_error_marker_type): Likewise.
2013         (lookup_die_type): Likewise.
2014         (dump_die_shallow): Likewise.
2015         (follow_die_ref): Likewise.
2016         (dwarf2_fetch_die_loc_sect_off): Likewise.
2017         (dwarf2_fetch_constant_bytes): Likewise.
2018         (follow_die_sig): Likewise.
2019         (get_signatured_type): Likewise.
2020         (get_DW_AT_signature_type): Likewise.
2021         (dwarf2_find_containing_comp_unit): Likewise.
2022         (set_die_type): Likewise.
2023
2024 2018-02-21  John Baldwin  <jhb@FreeBSD.org>
2025
2026         * arch/aarch64.c: Include "common-defs.h".
2027         * arch/amd64.c: Likewise.
2028         * arch/i386.c: Likewise.
2029
2030 2018-02-21  Tom Tromey  <tom@tromey.com>
2031
2032         * value.h: (extract_field_op): Update.
2033         * eval.c (extract_field_op): Return a const char *.
2034         * expression.h (parse_expression_for_completion): Update.
2035         * completer.c (complete_expression): Update.
2036         (add_struct_fields): Make fieldname const.
2037         * parse.c (expout_completion_name): Now a unique_xmalloc_ptr.
2038         (mark_completion_tag, parse_exp_in_context_1): Update.
2039         (parse_expression_for_completion): Change "name" to
2040         unique_xmalloc_ptr*.
2041
2042 2018-02-21  Tom Tromey  <tom@tromey.com>
2043
2044         * infcall.c (call_function_by_hand_dummy): Use std::vector.
2045
2046 2018-02-21  Yao Qi  <yao.qi@linaro.org>
2047
2048         * avr-tdep.c (avr_read_pc): Change parameter type to
2049         readable_regcache.
2050         * gdbarch.sh (read_pc): Likewise.
2051         * gdbarch.c: Re-generated.
2052         * gdbarch.h: Re-generated.
2053         * hppa-tdep.c (hppa_read_pc): Change parameter type to
2054         readable_regcache.
2055         * ia64-tdep.c (ia64_read_pc): Likewise.
2056         * mips-tdep.c (mips_read_pc): Likewise.
2057         * spu-tdep.c (spu_read_pc): Likewise.
2058
2059 2018-02-21  Yao Qi  <yao.qi@linaro.org>
2060
2061         * Makefile.in (COMMON_SFILES): Add regcache-dump.c
2062         * regcache-dump.c: New file.
2063         * regcache.c: Move register_dump to regcache-dump.c.
2064         (maintenance_print_registers): Likewise.
2065         (maintenance_print_raw_registers): Likewise.
2066         (maintenance_print_cooked_registers): Likewise.
2067         (maintenance_print_register_groups): Likewise.
2068         (maintenance_print_remote_registers): Likewise.
2069         (_initialize_regcache): Likewise.
2070         * regcache.h (register_dump): Moved from regcache.c.
2071
2072 2018-02-21  Yao Qi  <yao.qi@linaro.org>
2073
2074         * regcache.c (regcache::regcache): Update.
2075         (regcache::invalidate): Move it to detached_regcache::invalidate.
2076         (get_thread_arch_aspace_regcache): Update.
2077         (regcache::raw_update): Update.
2078         (regcache::cooked_read): Remove some code.
2079         (regcache::cooked_read_value): Likewise.
2080         (regcache::raw_write): Remove assert on m_readonly_p.
2081         (regcache::raw_supply_integer): Move it to
2082         detached_regcache::raw_supply_integer.
2083         (regcache::raw_supply_zeroed): Likewise.
2084         * regcache.h (detached_regcache) <raw_supply_integer>: New
2085         declaration.
2086         <raw_supply_zeroed, invalidate>: Likewise.
2087         (regcache) <raw_supply_integer, raw_supply_zeroed>: Removed.
2088         <invalidate>: Likewise.
2089         <m_readonly_p>: Removed.
2090
2091 2018-02-21  Yao Qi  <yao.qi@linaro.org>
2092
2093         * infcmd.c (get_return_value): Let stop_regs point to
2094         get_current_regcache.
2095         * regcache.c (regcache::regcache): Remove.
2096         (register_dump_reg_buffer): New class.
2097         (regcache_print): Adjust.
2098         * regcache.h (regcache): Remove constructors.
2099
2100 2018-02-21  Yao Qi  <yao.qi@linaro.org>
2101
2102         * regcache.c (class register_dump): New class.
2103         (register_dump_regcache, register_dump_none): New class.
2104         (register_dump_remote, register_dump_groups): New class.
2105         (regcache_print): Update.
2106         * regcache.h (regcache_dump_what): Move it to regcache.c.
2107         (regcache) <dump>: Remove.
2108
2109 2018-02-21  Yao Qi  <yao.qi@linaro.org>
2110
2111         * jit.c (struct jit_unwind_private) <regcache>: Change its type to
2112          reg_buffer_rw *.
2113         (jit_unwind_reg_set_impl): Call raw_supply.
2114         (jit_frame_sniffer): Use reg_buffer_rw.
2115         * record-full.c (record_full_core_regbuf): Change its type.
2116         (record_full_core_open_1): Use reg_buffer_rw.
2117         (record_full_close): Likewise.
2118         (record_full_core_fetch_registers): Use regcache->raw_supply.
2119         (record_full_core_store_registers): Likewise.
2120         * regcache.c (regcache::get_register_status): Move it to
2121         reg_buffer.
2122         (regcache_raw_set_cached_value): Remove.
2123         (regcache::raw_set_cached_value): Remove.
2124         (regcache::raw_write): Call raw_supply.
2125         (regcache::raw_supply): Move it to reg_buffer_rw.
2126         * regcache.h (regcache_raw_set_cached_value): Remove.
2127         (reg_buffer_rw): New class.
2128
2129 2018-02-21  Yao Qi  <yao.qi@linaro.org>
2130
2131         * dummy-frame.c (dummy_frame_cache) <prev_regcache>: Use
2132         readonly_detached_regcache.
2133         (dummy_frame_prev_register): Use regcache->cooked_read.
2134         * frame.c (frame_save_as_regcache): Change return type.
2135         (frame_pop): Update.
2136         * frame.h (frame_save_as_regcache): Update declaration.
2137         * inferior.h (get_infcall_suspend_state_regcache): Update
2138         declaration.
2139         * infrun.c (infcall_suspend_state) <registers>: use
2140         readonly_detached_regcache.
2141         (save_infcall_suspend_state): Don't use regcache_dup.
2142         (get_infcall_suspend_state_regcache): Change return type.
2143         * linux-fork.c (struct fork_info) <savedregs>: Change to
2144         readonly_detached_regcache.
2145         <pc>: New field.
2146         (fork_save_infrun_state): Don't use regcache_dup.
2147         (info_checkpoints_command): Adjust.
2148         * mi/mi-main.c (register_changed_p): Update declaration.
2149         (mi_cmd_data_list_changed_registers): Use
2150         readonly_detached_regcache.
2151         (register_changed_p): Change parameter type to
2152         readonly_detached_regcache.
2153         * ppc-linux-tdep.c (ppu2spu_cache) <regcache>: Use
2154         readonly_detached_regcache.
2155         (ppu2spu_sniffer): Construct a new readonly_detached_regcache.
2156         * regcache.c (readonly_detached_regcache::readonly_detached_regcache):
2157         New.
2158         (regcache::save): Move it to reg_buffer.
2159         (regcache::restore): Change parameter type.
2160         (regcache_dup): Remove.
2161         * regcache.h (reg_buffer) <save>: New method.
2162         (readonly_detached_regcache): New class.
2163         * spu-tdep.c (spu2ppu_cache) <regcache>: Use
2164         readonly_detached_regcache.
2165         (spu2ppu_sniffer): Construct a new readonly_detached_regcache.
2166
2167 2018-02-21  Yao Qi  <yao.qi@linaro.org>
2168
2169         * frame.c (frame_save_as_regcache): Use regcache method save.
2170         (frame_pop): Use regcache method restore.
2171         * infrun.c (restore_infcall_suspend_state): Likewise.
2172         * linux-fork.c (fork_load_infrun_state): Likewise.
2173         * ppc-linux-tdep.c (ppu2spu_sniffer): User regcache method
2174         save.
2175         * regcache.c (regcache_save): Remove.
2176         (regcache::restore): More asserts.
2177         (regcache_cpy): Remove.
2178         * regcache.h (regcache_save): Remove the declaration.
2179         (regcache::restore): Move from private to public.
2180         Remove the friend declaration of regcache_cpy.
2181         (regcache_cpy): Remove declaration.
2182
2183 2018-02-21  Yao Qi  <yao.qi@linaro.org>
2184
2185         * aarch64-tdep.c (aarch64_pseudo_register_read_value): Change
2186         parameter type to 'readable_regcache *'.
2187         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
2188         * arm-tdep.c (arm_neon_quad_read): Likewise.
2189         (arm_pseudo_read): Likewise.
2190         * avr-tdep.c (avr_pseudo_register_read): Likewise.
2191         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
2192         * frv-tdep.c (frv_pseudo_register_read): Likewise.
2193         * gdbarch.c: Re-generated.
2194         * gdbarch.h: Re-generated.
2195         * gdbarch.sh (pseudo_register_read): Change parameter type to
2196         'readable_regcache *'.
2197         (pseudo_register_read_value): Likewise.
2198         * h8300-tdep.c (pseudo_from_raw_register): Likewise.
2199         (h8300_pseudo_register_read): Likewise.
2200         * hppa-tdep.c (hppa_pseudo_register_read): Likewise.
2201         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
2202         (i386_pseudo_register_read_into_value): Likewise.
2203         (i386_pseudo_register_read_value): Likewise.
2204         * i386-tdep.h (i386_pseudo_register_read_into_value): Update
2205         declaration.
2206         * ia64-tdep.c (ia64_pseudo_register_read): Likewise.
2207         * m32c-tdep.c (m32c_raw_read): Likewise.
2208         (m32c_read_flg): Likewise.
2209         (m32c_banked_register): Likewise.
2210         (m32c_banked_read): Likewise.
2211         (m32c_sb_read): Likewise.
2212         (m32c_part_read): Likewise.
2213         (m32c_cat_read): Likewise.
2214         (m32c_r3r2r1r0_read): Likewise.
2215         (m32c_pseudo_register_read): Likewise.
2216         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
2217         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
2218         (mep_pseudo_cr64_read): Likewise.
2219         (mep_pseudo_register_read): Likewise.
2220         * mips-tdep.c (mips_pseudo_register_read): Likewise.
2221         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
2222         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
2223         * regcache.c (regcache::raw_read): Move it to readable_regcache.
2224         (regcache::cooked_read): Likewise.
2225         (regcache::cooked_read_value): Likewise.
2226         (regcache_cooked_read_signed):
2227         (regcache::cooked_read): Likewise.
2228         * regcache.h (readable_regcache): New class.
2229         (regcache): Inherit readable_regcache.  Move some methods to
2230         readable_regcache.
2231         * rl78-tdep.c (rl78_pseudo_register_read): Change
2232         parameter type to 'readable_regcache *'.
2233         * rs6000-tdep.c (do_regcache_raw_read): Remove.
2234         (e500_pseudo_register_read): Change parameter type to
2235         'readable_regcache *'.
2236         (dfp_pseudo_register_read): Likewise.
2237         (vsx_pseudo_register_read): Likewise.
2238         (efpr_pseudo_register_read): Likewise.
2239         * s390-tdep.c (s390_pseudo_register_read): Likewise.
2240         * sh-tdep.c (sh_pseudo_register_read): Likewise.
2241         * sh64-tdep.c (pseudo_register_read_portions): Likewise.
2242         (sh64_pseudo_register_read): Likewise.
2243         * sparc-tdep.c (sparc32_pseudo_register_read): Likewise.
2244         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
2245         * spu-tdep.c (spu_pseudo_register_read_spu): Likewise.
2246         (spu_pseudo_register_read): Likewise.
2247         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
2248         (xtensa_pseudo_register_read): Likewise.
2249
2250 2018-02-21  Yao Qi  <yao.qi@linaro.org>
2251
2252         * regcache.c (regcache::regcache): Call reg_buffer ctor.
2253         (regcache::arch): Move it to reg_buffer::arch.
2254         (regcache::register_buffer): Likewise.
2255         (regcache::assert_regnum): Likewise.
2256         (regcache::num_raw_registers): Likewise.
2257         * regcache.h (reg_buffer): New class.
2258         (regcache): Inherit reg_buffer.
2259
2260 2018-02-20  Simon Marchi  <simon.marchi@ericsson.com>
2261
2262         * remote-sim.c (gdb_os_printf_filtered, gdb_os_vprintf_filtered,
2263         gdb_os_evprintf_filtered, gdb_os_error): Add ATTRIBUTE_PRINTF.
2264
2265 2018-02-20  Markus Metzger  <markus.t.metzger@intel.com>
2266
2267         * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add mkstemp.
2268
2269 2018-02-19  Alan Hayward  <alan.hayward@arm.com>
2270
2271         * Makefile.in: (COMMON_SFILES): Add common/*.c files.
2272         (SFILES): Remove common/*.c files.
2273         (COMMON_OBS): Remove some *.o files built from common/*.c files.
2274         * common/common.host: Add common reference.
2275         * configure.ac: Likewise.
2276         * configure: Regenerate.
2277
2278 2018-02-16  Yao Qi  <yao.qi@linaro.org>
2279
2280         * block.c (block_namespace_info): Inherit allocate_on_obstack.
2281         (block_initialize_namespace): Use new.
2282         * dwarf2read.c (dwarf2_per_objfile): Inherit allocate_on_obstack.
2283         (dwarf2_free_objfile): Use delete.
2284         * gdbtypes.c (type_pair): Inherit allocate_on_obstack.
2285         (copy_type_recursive): Use new.
2286         * gdb_obstack.h (allocate_on_obstack): New.
2287
2288 2018-02-15  Yao Qi  <yao.qi@linaro.org>
2289
2290         PR gdb/22849
2291         * inferior.c (exit_inferior_1): Reset inf->control.
2292
2293 2018-02-15  Joel Brobecker  <brobecker@adacore.com>
2294
2295         * ada-lang.c (ada_to_fixed_value_create): Delete advance
2296         declaration.
2297
2298 2018-02-14  Pedro Alves  <palves@redhat.com>
2299
2300         * frame-unwind.c (frame_unwind_try_unwinder): Always call
2301         frame_cleanup_after_sniffer on exception.
2302
2303 2018-02-14  Tom Tromey  <tom@tromey.com>
2304
2305         * solist.h (struct target_so_ops) <bfd_open>: Make pathname
2306         const.
2307         (solib_bfd_open): Make pathname const.
2308         * solib.c (solib_bfd_open): Make pathname const.
2309         * solib-spu.c (spu_bfd_fopen): Make name const.
2310         (spu_bfd_open): Make pathname const.
2311         * solib-darwin.c (darwin_bfd_open): Make pathname const.
2312         * solib-aix.c (solib_aix_bfd_open): Make pathname const.
2313
2314 2018-02-14  Tom Tromey  <tom@tromey.com>
2315
2316         * symfile.c (symfile_bfd_open): Update.
2317         * source.h (openp, source_full_path_of, find_and_open_source):
2318         Change argument type to unique_xmalloc_ptr.
2319         * source.c (openp): Take a unique_xmalloc_ptr.
2320         (source_full_path_of, find_and_open_source): Likewise.
2321         (open_source_file, symtab_to_fullname): Update.
2322         * solist.h (struct target_so_ops) <find_and_open_solib>: Take a
2323         unique_xmalloc_ptr.
2324         * solib.c (solib_find_1): Use unique_xmalloc_ptr.
2325         (exec_file_find): Update.
2326         * psymtab.c (psymtab_to_fullname): Update.
2327         * nto-tdep.h (nto_find_and_open_solib): Update.
2328         * nto-tdep.c (nto_find_and_open_solib): Change temp_path to a
2329         unique_xmalloc_ptr.
2330         * exec.c (exec_file_attach): Update.
2331         * dwarf2read.c (try_open_dwop_file): Use unique_xmalloc_ptr.
2332         * cli/cli-cmds.c (find_and_open_script): Use unique_xmalloc_ptr.
2333
2334 2018-02-14  Tom Tromey  <tom@tromey.com>
2335
2336         * solib.c: Include source.h.
2337         * nto-tdep.c: Include source.h.
2338         * mi/mi-cmd-env.c: Include source.h.
2339         * infcmd.c: Include source.h.
2340         * exec.c: Include source.h.
2341         * defs.h (enum openp_flag, openp, source_full_path_of, mod_path)
2342         (add_path, directory_switch, source_path, init_source_path): Move
2343         declarations...
2344         * source.h (enum openp_flag, openp, source_full_path_of, mod_path)
2345         (add_path, directory_switch, source_path, init_source_path):
2346         ...here.
2347
2348 2018-02-14  Tom Tromey  <tom@tromey.com>
2349
2350         * solist.h (exec_file_find, solib_find): Return
2351         unique_xmalloc_ptr.
2352         (solib_bfd_fopen): Take a const char *.
2353         * solib.c (solib_find_1): Return unique_xmalloc_ptr.
2354         (exec_file_find, solib_find): Likewise.
2355         (solib_bfd_fopen): Do not take ownership of "pathname".
2356         (solib_bfd_open): Use unique_xmalloc_ptr.
2357         * solib-darwin.c (darwin_bfd_open): Use unique_xmalloc_ptr.
2358         * solib-aix.c (solib_aix_bfd_open): Use unique_xmalloc_ptr.
2359         * infrun.c (follow_exec): Use unique_xmalloc_ptr.
2360         * exec.c (exec_file_locate_attach): Use unique_xmalloc_ptr.
2361
2362 2018-02-14  Joel Brobecker  <brobecker@adacore.com>
2363
2364         * ada-lang.c (name_match_type_from_name): Remove reference to
2365         ada_name_for_lookup in function's documentation.
2366         * ada-lang.h (ada_name_for_lookup): Delete declaration.
2367
2368 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
2369
2370         * defs.h (enum openp_flags): New enum.
2371         (OPF_TRY_CWD_FIRST, OPF_SEARCH_IN_PATH, OPF_RETURN_REALPATH):
2372         Move to enum openp_flags.
2373         (openp_flags): New enum flags.
2374         (openp): Change parameter type to openp_flags.
2375         * source.c (openp): Change parameter type to openp_flags.
2376         * cli/cli-cmds.c (find_and_open_script): Use openp_flags.
2377         * dwarf2read.c (try_open_dwop_file): Use openp_flags.
2378
2379 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
2380
2381         * maint.c (_initialize_maint_cmds): Fix prefix of maint set/show
2382         per-command.
2383
2384 2018-02-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2385
2386         * dwarf2read.c (dwarf2_release_queue): Delete function, move body
2387         into...
2388         (class dwarf2_queue_guard): ...the destructor of this new class.
2389         (dw2_do_instantiate_symtab): Create instance of the new class
2390         dwarf2_queue_guard, remove cleanup.
2391
2392 2018-02-09  Tom Tromey  <tom@tromey.com>
2393
2394         * source.c (find_source_lines): Don't reference past the end of
2395         the vector.
2396
2397 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
2398
2399         * remote.c (remote_btrace_maybe_reopen): Change error message.
2400         * btrace.c (btrace_enable): Likewise.
2401         (parse_xml_btrace): Likewise.
2402         (parse_xml_btrace_conf): Likewise.
2403
2404 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
2405
2406         * nat/linux-btrace.c (diagnose_perf_event_open_fail): New.
2407         (linux_enable_pt, linux_enable_bts): Call
2408         diagnose_perf_event_open_fail.
2409
2410 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
2411
2412         * nat/linux-btrace.c (perf_event_pt_event_type): Improve error message.
2413         Remove parameter and change return type.  Update callers.  Move it.
2414         (linux_enable_bts, linux_enable_pt): Improve error message.
2415         (linux_enable_pt): Remove zero buffer size check.
2416         (linux_enable_btrace): Improve error messages.  Remove NULL return
2417         check.
2418
2419 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
2420
2421         * btrace.c (btrace_enable): Remove target_supports_btrace call.
2422         * nat/linux-btrace.c (perf_event_pt_event_type): Move.
2423         (kernel_supports_bts, kernel_supports_pt, linux_supports_bts)
2424         (linux_supports_pt, linux_supports_btrace): Remove.
2425         (linux_enable_bts): Call cpu_supports_bts.
2426         * nat/linux-btrace.h (linux_supports_btrace): Remove.
2427         * remote.c (remote_supports_btrace): Remove.
2428         (init_remote_ops): Remove remote_supports_btrace.
2429         * target-delegates.c: Regenerated.
2430         * target.c (target_supports_btrace): Remove.
2431         * target.h (target_ops) <to_supports_btrace>: Remove
2432         (target_supports_btrace): Remove.
2433         * x86-linux-nat.c (x86_linux_create_target): Remove
2434         linux_supports_btrace.
2435
2436 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
2437
2438         * nat/linux-btrace.c (linux_enable_btrace): Throw exception if enabling
2439         btrace failed.
2440         * x86-linux-nat.c (x86_linux_enable_btrace): Catch btrace enabling
2441         exception and use message in own exception.
2442
2443 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
2444
2445         * nat/linux-btrace.c: Include scoped_fd.h and scoped_mmap.h.
2446         (perf_event_pt_event_type): Use gdb_file_up.
2447         (linux_enable_bts, linux_enable_pt): Use gdb::unique_xmalloc_ptr,
2448         scoped_fd, and scoped_mmap.
2449
2450 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
2451
2452         * common/scoped_mmap.h: New.
2453         * unittests/scoped_mmap-selftest.c: New.
2454         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
2455         unittests/scoped_mmap-selftest.c.
2456
2457 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
2458
2459         * common/scoped_fd.h: New.
2460         * unittests/scoped_fd-selftest.c: New.
2461         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
2462         unittests/scoped_fd-selftest.c.
2463
2464 2018-02-09  Tom Tromey  <tom@tromey.com>
2465
2466         * auto-load.c (auto_load_section_scripts): Use
2467         gdb::unique_xmalloc_ptr.
2468
2469 2018-02-09  Tom Tromey  <tom@tromey.com>
2470
2471         * auto-load.c (execute_script_contents): Use std::string.
2472
2473 2018-02-09  Joel Brobecker  <brobecker@adacore.com>
2474
2475         * NEWS <Changes in GDB 8.1>: Clarify that "rbreak" is a new
2476         Python function, rather than a new command.
2477
2478 2018-02-08  Tom Tromey  <tom@tromey.com>
2479
2480         * solib.c (solib_find_1): Use std::string.
2481         (solib_bfd_fopen): Use unique_xmalloc_ptr.
2482
2483 2018-02-08  Tom Tromey  <tom@tromey.com>
2484
2485         * build-id.c (build_id_to_debug_bfd): Use unique_xmalloc_ptr.
2486
2487 2018-02-08  Tom Tromey  <tom@tromey.com>
2488
2489         * source.c (find_source_lines): Use gdb::def_vector.
2490
2491 2018-02-08  Tom Tromey  <tom@tromey.com>
2492
2493         * macrocmd.c (struct temporary_macro_definition): New.
2494         (macro_define_command): Use temporary_macro_definition.  Remove
2495         cleanups.
2496         (free_macro_definition_ptr): Remove.
2497
2498 2018-02-08  Tom Tromey  <tom@tromey.com>
2499
2500         * macroexp.c (maybe_expand): Use std::string.
2501
2502 2018-02-08  Tom Tromey  <tom@tromey.com>
2503
2504         * macroexp.c (struct macro_buffer): Add initializers for some
2505         members.
2506         (init_buffer, init_shared_buffer, free_buffer)
2507         (free_buffer_return_text): Remove.
2508         (macro_buffer): New constructors.
2509         (~macro_buffer): New destructor.
2510         (macro_buffer::set_shared): New method.
2511         (macro_buffer::resize_buffer, macro_buffer::appendc)
2512         (macro_buffer::appendmem): Now methods, not free functions.
2513         (set_token, append_tokens_without_splicing, stringify)
2514         (macro_stringify): Update.
2515         (gather_arguments): Change return type.  Remove argc_p argument,
2516         add args_ptr argument.  Use std::vector.
2517         (substitute_args): Remove argc argument.  Accept std::vector.
2518         (expand): Update.  Use std::vector.
2519         (scan, macro_expand, macro_expand_next): Update.
2520
2521 2018-02-08  Tom Tromey  <tom@tromey.com>
2522
2523         * symtab.c (default_collect_symbol_completion_matches_break_on):
2524         Use unique_xmalloc_ptr.
2525         * macroscope.h: (sal_macro_scope, user_macro_scope)
2526         (default_macro_scope): Return unique_xmalloc_ptr.
2527         * macroscope.c (sal_macro_scope, user_macro_scope)
2528         (default_macro_scope): Return unique_xmalloc_ptr.
2529         * macroexp.h (macro_expand, macro_expand_once): Return
2530         unique_xmalloc_ptr.
2531         * macroexp.c (macro_expand, macro_expand_once): Return
2532         unique_xmalloc_ptr.
2533         * macrocmd.c (macro_expand_command, macro_expand_once_command)
2534         (info_macro_command, info_macros_command): Use
2535         unique_xmalloc_ptr.
2536         * compile/compile-c-support.c (write_macro_definitions): Use
2537         unique_xmalloc_ptr.
2538         * c-exp.y (c_parse): Use unique_xmalloc_ptr.
2539
2540 2018-02-07  Simon Marchi  <simon.marchi@ericsson.com>
2541
2542         * value.c (value_static_field): Assign field type instead of
2543         containing type when returning an optimized out value.
2544
2545 2018-02-06  Yao Qi  <yao.qi@linaro.org>
2546
2547         * ft32-tdep.c (ft32_read_pc): Remove.
2548         (ft32_write_pc): Remove.
2549         (ft32_gdbarch_init): Update.
2550         * m32r-tdep.c (m32r_read_pc): Remove.
2551         (m32r_gdbarch_init): Update.
2552         * mep-tdep.c (mep_read_pc): Remove.
2553         (mep_gdbarch_init): Update.
2554         * microblaze-tdep.c (microblaze_write_pc): Remove.
2555         (microblaze_gdbarch_init): Update.
2556         * mn10300-tdep.c (mn10300_read_pc): Remove.
2557         (mn10300_write_pc): Remove.
2558         (mn10300_gdbarch_init): Update.
2559         * moxie-tdep.c (moxie_read_pc): Remove.
2560         (moxie_write_pc): Remove.
2561         (moxie_gdbarch_init): Update.
2562
2563 2018-02-06  Yao Qi  <yao.qi@linaro.org>
2564
2565         * expprint.c (print_subexp_standard): Handle
2566         OP_F77_UNDETERMINED_ARGLIST.
2567         (dump_subexp_body_standard): Likewise.
2568
2569 2018-02-05  Alan Hayward  <alan.hayward@arm.com>
2570
2571         * target-descriptions.c (tdesc_element_visitor) Add empty
2572         implementations.
2573         (tdesc_type): Move make_gdb_type from here.
2574         (tdesc_type_builtin): Likewise.
2575         (tdesc_type_vector): Likewise.
2576         (tdesc_type_with_fields): Move make_gdb_type_ functions from here.
2577         (make_gdb_type_struct): Move from tdesc_type_with_fields.
2578         (make_gdb_type_union): Likewise.
2579         (make_gdb_type_flags): Likewise.
2580         (make_gdb_type_enum): Likewise.
2581         (make_gdb_type): New function.
2582         (tdesc_register_type): Use static make_gdb_type.
2583
2584 2018-02-05  Ruslan Kabatsayev <b7.10110111@gmail.com>
2585
2586         * infcmd.c (default_print_one_register_info): Align natural-format
2587         column values consistently one under another.
2588         (pad_to_column): New function.
2589
2590 2018-02-05  Joel Brobecker  <brobecker@adacore.com>
2591
2592         * dwarf2read.c (dwarf2_physname): Move commment.
2593
2594 2018-02-01  Leszek Swirski  <leszeks@google.com>
2595
2596         * varobj.c (varobj_formatted_print_options): Allow recursive
2597         pretty printing if pretty printing is enabled.
2598
2599 2018-02-01  Leszek Swirski  <leszeks@google.com>
2600
2601         * c-exp.y (lex_one_token, classify_name, yylex): Don't classify
2602         names after a structop as a filename.
2603
2604 2018-02-01  Yao Qi  <yao.qi@linaro.org>
2605
2606         * arm-tdep.c (arm_record_data_proc_misc_ld_str): Rewrite it.
2607         (arm_record_coproc_data_proc): Likewise.
2608
2609 2018-02-01  Yao Qi  <yao.qi@linaro.org>
2610
2611         * arm-tdep.c (arm_record_extension_space): Change ret to signed.
2612
2613 2018-01-31  Nikola Prica  <nikola.prica@rt-rk.com>
2614
2615         * rs6000-tdep.c (skip_prologue): Remove shifting for lr_reg and
2616         assign shifted lr_reg to fdata->lr_register when lr_reg is set.
2617
2618 2018-01-31  Pedro Alves  <palves@redhat.com>
2619
2620         * darwin-nat.c (darwin_interrupt): Remove ptid_t parameter.
2621         * inflow.c (child_terminal_save_inferior): Wrap reference to
2622         tcgetpgrp in HAVE_TERMIOS_H.
2623         (child_interrupt, child_pass_ctrlc): Wrap references to signal in
2624         _WIN32.
2625         * remote-sim.c (gdbsim_interrupt): Remove ptid_t parameter and
2626         always iterate over all inferiors.
2627         (gdbsim_cntrl_c): Adjust.
2628         * windows-nat.c (windows_interrupt): Remove 'ptid_t' parameter.
2629
2630 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
2631
2632         * gdbtypes.c (lookup_array_range_type): Make sure the array's
2633         index type is objfile-owned if the element type is as well.
2634
2635 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
2636
2637         GDB 8.1 released.
2638
2639 2018-01-30  Philipp Rudo  <prudo@linux.vnet.ibm.com>
2640
2641         * s390-linux-tdep.c: Remove includes "features/s390-linux32.c" and
2642         "features/s390x-linux64.c".
2643         (_initialize_s390_linux_tdep): Remove initialization of tdescs
2644         s390_linux32 and s390x_linux64.
2645         (s390_linux_init_abi_31, s390_linux_init_abi_64): Don't set
2646         default tdesc.
2647         * s390-tdep.c: Include "features/s390-linux32.c" and
2648         "features/s390x-linux64.c".
2649         (s390_tdesc_valid): Add check for tdesc_has_registers.
2650         (s390_gdbarch_init): Make sure there is always a valid tdesc.
2651         (_initialize_s390_tdep): Initialize tdesc_s390_linux32 and
2652         tdesc_s390x_linux64.
2653         * s390-linux-tdep.h: Move export of tdesc_s390_linux32 and
2654         tdesc_s390x_linux64 to...
2655         * s390-tdep.h: ...here.
2656
2657 2018-01-30  Pedro Alves  <palves@redhat.com>
2658
2659         PR gdb/13211
2660         * config.in, configure: Regenerate.
2661         * configure.ac: Check for getpgid.
2662         * go32-nat.c (go32_pass_ctrlc): New.
2663         (go32_target): Install it.
2664         * inf-child.c (inf_child_target): Install
2665         child_terminal_save_inferior, child_pass_ctrlc and
2666         child_interrupt.
2667         * inf-ptrace.c (inf_ptrace_interrupt): Delete.
2668         (inf_ptrace_target): No longer install it.
2669         * infcmd.c (interrupt_target_1): Adjust.
2670         * inferior.h (child_terminal_save_inferior, child_pass_ctrlc)
2671         (child_interrupt): Declare.
2672         (inferior::terminal_state): New.
2673         * inflow.c (struct terminal_info): Update comments.
2674         (inferior_process_group): Delete.
2675         (terminal_is_ours): Delete.
2676         (gdb_tty_state): New.
2677         (child_terminal_init): Adjust.
2678         (is_gdb_terminal, sharing_input_terminal_1)
2679         (sharing_input_terminal): New functions.
2680         (child_terminal_inferior): Adjust.  Use sharing_input_terminal.
2681         Set the process's actual process group in the foreground if
2682         possible.  Handle is_ours_for_output/is_ours distinction.  Don't
2683         mark terminal as the inferior's if not sharing GDB's terminal.
2684         Don't check attach_flag.
2685         (child_terminal_ours_for_output, child_terminal_ours): Adjust to
2686         pass down a target_terminal_state.
2687         (child_terminal_save_inferior): New, factored out from ...
2688         (child_terminal_ours_1): ... this.  Handle
2689         target_terminal_state::is_ours_for_output.
2690         (child_interrupt, child_pass_ctrlc): New.
2691         (inflow_inferior_exit): Clear the inferior's terminal_state.
2692         (copy_terminal_info): Copy the inferior's terminal state.
2693         (_initialize_inflow): Remove reference to terminal_is_ours.
2694         * inflow.h (inferior_process_group): Delete.
2695         * nto-procfs.c (nto_handle_sigint, procfs_interrupt): Adjust.
2696         * procfs.c (procfs_target): Don't install procfs_interrupt.
2697         (procfs_interrupt): Delete.
2698         * remote.c (remote_serial_quit_handler): Adjust.
2699         (remote_interrupt): Remove ptid parameter.  Adjust.
2700         * target-delegates.c: Regenerate.
2701         * target.c: Include "terminal.h".
2702         (target_terminal::terminal_state): Rename to ...
2703         (target_terminal::m_terminal_state): ... this.
2704         (target_terminal::init): Adjust.
2705         (target_terminal::inferior): Adjust to per-inferior
2706         terminal_state.
2707         (target_terminal::restore_inferior, target_terminal_is_ours_kind): New.
2708         (target_terminal::ours, target_terminal::ours_for_output): Use
2709         target_terminal_is_ours_kind.
2710         (target_interrupt): Remove ptid parameter.  Adjust.
2711         (default_target_pass_ctrlc): Adjust.
2712         * target.h (target_ops::to_terminal_save_inferior): New field.
2713         (target_ops::to_interrupt): Remove ptid_t parameter.
2714         (target_interrupt): Remove ptid_t parameter.  Update comment.
2715         (target_pass_ctrlc): Update comment.
2716         * target/target.h (target_terminal_state): New scoped enum,
2717         factored out of ...
2718         (target_terminal::terminal_state): ... here.
2719         (target_terminal::inferior): Update comments.
2720         (target_terminal::restore_inferior): New.
2721         (target_terminal::is_inferior, target_terminal::is_ours)
2722         (target_terminal::is_ours_for_output): Adjust.
2723         (target_terminal::scoped_restore_terminal_state): Adjust to
2724         rename, and call restore_inferior() instead of inferior().
2725         (target_terminal::scoped_restore_terminal_state::m_state): Change
2726         type.
2727         (target_terminal::terminal_state): Rename to ...
2728         (target_terminal::m_terminal_state): ... this and change type.
2729
2730 2018-01-30  Pedro Alves  <palves@redhat.com>
2731
2732         * linux-nat.c (wait_for_signal): New function.
2733         (wait_lwp, linux_nat_wait_1): Use it instead of calling sigsuspend
2734         directly.
2735         (async_terminal_is_ours)
2736         (linux_nat_terminal_inferior, linux_nat_terminal_ours): Delete.
2737         (linux_nat_add_target): Don't override
2738         to_terminal_inferior/to_terminal_ours.
2739
2740 2018-01-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2741
2742         * remote.c (remote_follow_fork): Don't call "detach_inferior".
2743
2744 2018-01-28  Simon Marchi  <simon.marchi@ericsson.com>
2745
2746         * dwarf2read.c (free_dwo_files): Add forward-declaration.
2747         (dwarf2_per_objfile::~dwarf2_per_objfile): Move content from
2748         dwarf2_per_objfile_free here.
2749         (dwarf2_per_objfile_free): Remove.
2750         (_initialize_dwarf2_read): Don't register
2751         dwarf2_per_objfile_free as a registry cleanup.
2752
2753 2018-01-27  Eli Zaretskii  <eliz@gnu.org>
2754
2755         Avoid compilation errors in MinGW native builds
2756
2757         The error is triggered by including python-internal.h, and the
2758         error message is:
2759
2760              In file included from d:\usr\lib\gcc\mingw32\6.3.0\include\c++\math.h:36:0,
2761                       from build-gnulib/import/math.h:27,
2762                       from d:/usr/Python26/include/pyport.h:235,
2763                       from d:/usr/Python26/include/Python.h:58,
2764                       from python/python-internal.h:94,
2765                       from python/py-arch.c:24:
2766              d:\usr\lib\gcc\mingw32\6.3.0\include\c++\cmath:1157:11: error: '::hypot' has not been declared
2767         using ::hypot;
2768                 ^~~~~
2769
2770         This happens because Python headers define 'hypot' to expand t
2771         '_hypot' in the Windows builds.
2772         * python/python-internal.h (_hypot) [__MINGW32__]: Define back to
2773         'hypoth'.  This avoids a compilation error.
2774
2775 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
2776
2777         * MAINTAINERS (Write After Approval): Fix ordering.
2778
2779 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
2780
2781         * MAINTAINERS (Write After Approval): Add Alan Hayward.
2782
2783 2018-01-26  Alan Modra  <amodra@gmail.com>
2784
2785         * ppc-linux-tdep.c (powerpc32_plt_stub): Make const.
2786         (powerpc32_plt_stub_so_1): Rename from powerpc32_plt_stub_so.
2787         Remove nop.  Make const.  Comment.
2788         (powerpc32_plt_stub_so_2): New.
2789         (POWERPC32_PLT_CHECK_LEN): Rename from POWERPC32_PLT_STUB_LEN.
2790         Correct count.  Update uses.
2791         (ppc_skip_trampoline_code): Match powerpc32_plt_stub_so_2 too.
2792         Move common code reading PLT entry word.  Correct
2793         powerpc32_plt_stub PLT address calculation.
2794         * ppc64-tdep.c (ppc64_standard_linkage1): Make const.
2795         (ppc64_standard_linkage2, ppc64_standard_linkage3): Likewise.
2796         (ppc64_standard_linkage4, ppc64_standard_linkage5): Likewise.
2797         (ppc64_standard_linkage6, ppc64_standard_linkage7): Likewise.
2798         (ppc64_standard_linkage8): Likewise.
2799         * rs6000-tdep.c (ppc_insns_match_pattern): Make pattern const.
2800         Correct insns description.
2801         * ppc-tdep.h (ppc_insns_match_pattern): Update prototype.
2802
2803 2018-01-24  Pedro Alves  <palves@redhat.com>
2804
2805         GCC PR libstdc++/83906
2806         * gdbtypes.c (operator==(const dynamic_prop &,
2807         const dynamic_prop &)): New.
2808         (operator==(const range_bounds &, const range_bounds &)): New.
2809         (check_types_equal): Use them instead of memcmp.
2810         * gdbtypes.h (operator==(const dynamic_prop &,
2811         const dynamic_prop &)): Declare.
2812         (operator!=(const dynamic_prop &, const dynamic_prop &)): Declare.
2813         (operator==(const range_bounds &, const range_bounds &)): Declare.
2814         (operator!=(const range_bounds &, const range_bounds &)): Declare.
2815
2816 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
2817
2818         * s390-linux-tdep.c (s390_record_address_mask)
2819         (s390_record_calc_disp_common, s390_record_calc_disp)
2820         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
2821         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
2822         (s390_process_record): Move to s390-tdep.c.
2823         (s390_linux_init_abi_any): Adjust.
2824         * s390-tdep.c (s390_record_address_mask)
2825         (s390_record_calc_disp_common, s390_record_calc_disp)
2826         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
2827         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
2828         (s390_process_record): Moved from s390-linux-tdep.c
2829         (s390_gdbarch_init): Adjust.
2830
2831 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
2832
2833         * s390-linux-nat.c (s390-tdep.h): New include.
2834         * Makefile.in (ALL_TARGET_OBS): Add s390-tdep.o.
2835         (HFILES_NO_SRCDIR): Add s390-tdep.h.
2836         (ALLDEPFILES): Add s390-tdep.c.
2837         * configure.tgt (s390*-*-linux*): Add s390-tdep.o.
2838         * s390-linux-tdep.h (HWCAP_S390_*, S390_*_REGNUM): Move to...
2839         * s390-tdep.h: ...this.  New file.
2840         * s390-linux-tdep.c (s390-tdep.h): New include.
2841         (_initialize_s390_tdep): Rename to...
2842         (_initialize_s390_linux_tdep): ...this and adjust.
2843         (s390_abi_kind, s390_vector_abi_kind, gdbarch_tdep)
2844         (enum named opcodes, S390_NUM_GPRS, S390_NUM_FPRS): Move to
2845         s390-tdep.h.
2846         (s390_break_insn, s390_breakpoint, s390_readinstruction, is_ri)
2847         (is_ril, is_rr, is_rre, is_rs, is_rsy, is_rx, is_rxy)
2848         (s390_is_partial_instruction, s390_software_single_step)
2849         (is_non_branch_ril, s390_displaced_step_copy_insn)
2850         (s390_displaced_step_fixup, s390_displaced_step_hw_singlestep)
2851         (s390_prologue_data, s390_addr, s390_store, s390_load)
2852         (s390_check_for_saved, s390_analyze_prologue, s390_skip_prologue)
2853         (s390_register_call_saved, s390_guess_tracepoint_registers)
2854         (s390_register_name, s390_dwarf_regmap, s390_dwarf_reg_to_regnum)
2855         (regnum_is_gpr_full, regnum_is_vxr_full, s390_value_from_register)
2856         (s390_pseudo_register_name, s390_pseudo_register_type)
2857         (s390_pseudo_register_read, s390_pseudo_register_write)
2858         (s390_pseudo_register_reggroup_p, s390_ax_pseudo_register_collect)
2859         (s390_ax_pseudo_register_push_stack, s390_gen_return_address)
2860         (s390_addr_bits_remove, s390_address_class_type_flags)
2861         (s390_address_class_type_flags_to_name)
2862         (s390_address_class_name_to_type_flags, s390_effective_inner_type)
2863         (s390_function_arg_float, s390_function_arg_vector)
2864         (is_power_of_two, s390_function_arg_integer, s390_arg_state)
2865         (s390_handle_arg, s390_push_dummy_call, s390_dummy_id)
2866         (s390_frame_align, s390_register_return_value, s390_return_value)
2867         (s390_stack_frame_destroyed_p, s390_unwind_pc, s390_unwind_sp)
2868         (s390_unwind_pseudo_register, s390_adjust_frame_regnum)
2869         (s390_dwarf2_prev_register, s390_dwarf2_frame_init_reg)
2870         (s390_trad_frame_prev_register, s390_unwind_cache)
2871         (s390_prologue_frame_unwind_cache)
2872         (s390_backchain_frame_unwind_cache, s390_frame_unwind_cache)
2873         (s390_frame_this_id, s390_frame_prev_register, s390_frame_unwind)
2874         (s390_stub_unwind_cache, s390_stub_frame_unwind_cache)
2875         (s390_stub_frame_this_id, s390_stub_frame_prev_register)
2876         (s390_stub_frame_sniffer, s390_stub_frame_unwind)
2877         (s390_frame_base_address, s390_local_base_address)
2878         (s390_frame_base, s390_gcc_target_options)
2879         (s390_gnu_triplet_regexp, s390_stap_is_single_operand)
2880         (s390_validate_reg_range, s390_tdesc_valid)
2881         (s390_gdbarch_tdep_alloc, s390_gdbarch_init): Move to...
2882         * s390-tdep.c: ...this.  New file.
2883
2884 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
2885
2886         * s390-linux-tdep.c (gdbarch_tdep.s390_syscall_record): New hook.
2887         (s390_process_record, s390_gdbarch_tdep_alloc)
2888         (s390_linux_init_abi_any): Use/set new hook.
2889
2890 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
2891
2892         * s390-linux-tdep.c (osabi.h): New include.
2893         (s390_linux_init_abi_31, s390_linux_init_abi_64)
2894         (s390_linux_init_abi_any): New functions.
2895         (s390_gdbarch_init, _initialize_s390_tdep): Adjust.
2896
2897 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
2898
2899         * s390-linux-tdep.c (s390_gdbarch_init): Use gdb_assert for
2900         tdesc_has_registers check
2901
2902 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
2903
2904         * s390-linux-tdep.c (s390_tdesc_valid): New function.
2905         (s390_validate_reg_range): New macro.
2906         (s390_gdbarch_init): Adjust.
2907
2908 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
2909
2910         * s390-linux-tdep.c (gdbarch_tdep) <tdesc>: New field.
2911         (s390_gdbarch_tdep_alloc): Adjust.
2912         (s390_gdbarch_init): Adjust.
2913
2914 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
2915
2916         * s390-linux-tdep.c (gdbarch_tdep) <have_linux_v1, have_linux_v2>
2917         <have_tdb>: Change type to bool.
2918         (s390_gdbarch_tdep_alloc): Adjust.
2919         (s390_gdbarch_init): Adjust.
2920
2921 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
2922
2923         * s390-linux-tdep (s390_abi_kind) <ABI_NONE>: New default field.
2924         (gdbarch_tdep) <have_upper, have_vx>: New fields.
2925         (s390_gdbarch_tdep_alloc): New function.
2926         (s390_gdbarch_init): Allocate tdep at start and use its fields
2927         instead of separate variables.
2928
2929 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
2930
2931         * s390-linux-tdep.c (s390_gdbarch_init): Remove duplicate checks
2932         when looking for cached gdbarch and add comment for remaining.
2933
2934 2018-01-22  Pedro Alves  <palves@redhat.com>
2935             Sergio Durigan Junior  <sergiodj@redhat.com>
2936
2937         * typeprint.c (whatis_exp): Initialize "val" in the "whatis type"
2938         case.
2939
2940 2018-01-22  Maciej W. Rozycki  <macro@mips.com>
2941
2942         * MAINTAINERS: Update my company e-mail address.
2943
2944 2018-01-22  Yao Qi  <yao.qi@linaro.org>
2945
2946         * regcache.c (cooked_write_test): New function.
2947         (_initialize_regcache): Register the test.
2948
2949 2018-01-22  Yao Qi  <yao.qi@linaro.org>
2950
2951         * ia64-tdep.c (ia64_pseudo_register_read): Call
2952         regcache->cooked_read instead of regcache_cooked_read_unsigned.
2953         * m32c-tdep.c (m32c_cat_read): Likewise.
2954         (m32c_r3r2r1r0_read): Likewise.
2955         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
2956         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
2957
2958 2018-01-22  Yao Qi  <yao.qi@linaro.org>
2959
2960         * aarch64-tdep.c (aarch64_pseudo_read_value): Call regcache
2961         method raw_read instead of regcache_raw_read.
2962         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
2963         * arm-tdep.c (arm_neon_quad_read): Likewise.
2964         * avr-tdep.c (avr_pseudo_register_read): Likewise.
2965         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
2966         * frv-tdep.c (frv_pseudo_register_read): Likewise.
2967         * h8300-tdep.c (h8300_pseudo_register_read): Likewise.
2968         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
2969         (i386_pseudo_register_read_into_value): Likewise.
2970         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
2971         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
2972         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
2973         * rl78-tdep.c (rl78_pseudo_register_read): Likewise.
2974         * s390-linux-tdep.c (s390_pseudo_register_read): Likewise.
2975         * sparc-tdep.c (sparc32_pseudo_register_read):  Likewise.
2976         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
2977         * spu-tdep.c (spu_pseudo_register_read_spu):  Likewise.
2978         * xtensa-tdep.c (xtensa_pseudo_register_read): Likewise.
2979
2980 2018-01-22  Yao Qi  <yao.qi@linaro.org>
2981
2982         * Makefile.in (ALL_TARGET_OBS): Remove mt-tdep.o.
2983         * configure.tgt: Remove target mt.
2984         * mt-tdep.c: Remove.
2985         * regcache.c (cooked_read_test): Remove the check for mt.
2986
2987 2018-01-22  Yao Qi  <yao.qi@linaro.org>
2988
2989         * jit.c (jit_frame_prev_register): Call regcache::cooked_read
2990         instead of gdbarch_pseudo_register_read_value.
2991
2992 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
2993
2994         * dwarf2read.c (need_gnat_info): Return nonzero if the cu's
2995         language is Ada.
2996
2997 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
2998
2999         * linespec.c (create_sals_line_offset): Remove code that preserved
3000         the symtab_and_line's line number.
3001
3002 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3003
3004         * varobj.c (varobj_create): Don't set valid_block when creating a
3005         floating varobj.
3006
3007 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3008
3009         * varobj.c (varobj_create): Remove out of date comment.
3010
3011 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3012
3013         PR mi/20395
3014         * ada-exp.y (write_var_from_sym): Pass extra parameter when
3015         updating innermost block.
3016         * parse.c (innermost_block_tracker::update): Take extra type
3017         parameter, and check types match before updating innermost block.
3018         (write_dollar_variable): Update innermost block for registers.
3019         * parser-defs.h (enum innermost_block_tracker_type): New enum.
3020         (innermost_block_tracker::innermost_block_tracker): Initialise
3021         m_types member.
3022         (innermost_block_tracker::reset): Take type parameter.
3023         (innermost_block_tracker::update): Take type parameter, and pass
3024         type through as needed.
3025         (innermost_block_tracker::m_types): New member.
3026         * varobj.c (varobj_create): Pass type when reseting innermost
3027         block.
3028
3029 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3030
3031         * ada-exp.y (write_var_from_sym): Switch to innermost_block API.
3032         * ada-lang.c (resolve_subexp): Likewise.
3033         * breakpoint.c (set_breakpoint_condition) Likewise.
3034         (watch_command_1) Likewise.
3035         * c-exp.y (variable): Likewise.
3036         * d-exp.y (PrimaryExpression): Likewise.
3037         * f-exp.y (variable): Likewise.
3038         * go-exp.y (variable): Likewise.
3039         * m2-exp.y (variable): Likewise.
3040         * objfiles.c (objfile::~objfile): Likewise.
3041         * p-exp.y (variable): Likewise.
3042         * parse.c (innermost_block): Change type.
3043         * parser-defs.h (class innermost_block_tracker): New.
3044         (innermost_block): Change to innermost_block_tracker.
3045         * printcmd.c (display_command): Switch to innermost_block API.
3046         (do_one_display): Likewise.
3047         * rust-exp.y (do_one_display): Likewise.
3048         * symfile.c (clear_symtab_users): Likewise.
3049         * varobj.c (varobj_create): Switch to innermost_block API, replace
3050         use of innermost_block with block stored on varobj object.
3051
3052 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3053
3054         * expression.h (innermost_block): Remove declaration.
3055         * varobj.c: Add 'parser-defs.h' include.
3056
3057 2018-01-19  Tom Tromey  <tom@tromey.com>
3058
3059         * rust-lang.c (rust_lookup_symbol_nonlocal): Look up qualified
3060         symbols in the static and global blocks.
3061
3062 2018-01-19  James Clarke  <jrtc27@jrtc27.com>
3063
3064         * nat/linux-ptrace.c: Remove unnecessary reinclusion of
3065         gdb_ptrace.h, and move including gdb_wait.h ...
3066         * nat/linux-ptrace.h: ... to here.
3067
3068 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
3069
3070         * inf-ptrace.c (inf_ptrace_detach): Adjust call to
3071         inf_ptrace_detach_success.
3072         (inf_ptrace_detach_success): Add inferior parameter, use it
3073         instead of inferior_ptid, pass it to detach_inferior.
3074         * inf-ptrace.h (inf_ptrace_detach_success): Add inferior
3075         parameter.
3076         * inferior.c (detach_inferior): Add overload that takes an
3077         inferior object.
3078         * inferior.h (detach_inferior): Likewise.
3079         * linux-nat.c (linux_nat_detach): Use the inf parameter, don't
3080         use inferior_ptid, adjust call to inf_ptrace_detach_success.
3081         * linux-thread-db.c (thread_db_detach): Use inf parameter.
3082
3083 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
3084
3085         * target.h (struct target_ops) <to_detach>: Add inferior
3086         parameter.
3087         (target_detach): Likewise.
3088         * target.c (dispose_inferior): Pass inferior down.
3089         (target_detach): Pass inferior down.  Assert that it is equal to
3090         the current inferior.
3091         * aix-thread.c (aix_thread_detach): Pass inferior down.
3092         * corefile.c (core_file_command): Pass current_inferior() down.
3093         * corelow.c (core_detach): Add inferior parameter.
3094         * darwin-nat.c (darwin_detach): Likewise.
3095         * gnu-nat.c (gnu_detach): Likewise.
3096         * inf-ptrace.c (inf_ptrace_detach): Likewise.
3097         * infcmd.c (detach_command): Pass current_inferior() down to
3098         target_detach.
3099         * infrun.c (follow_fork_inferior): Pass parent_inf to
3100         target_detach.
3101         (handle_vfork_child_exec_or_exit): Pass inf->vfork_parent to
3102         target_detach.
3103         * linux-nat.c (linux_nat_detach): Add inferior parameter.
3104         * linux-thread-db.c (thread_db_detach): Likewise.
3105         * nto-procfs.c (procfs_detach): Likewise.
3106         * procfs.c (procfs_detach): Likewise.
3107         * record.c (record_detach): Likewise.
3108         * record.h (struct inferior): Forward-declare.
3109         (record_detach): Add inferior parameter.
3110         * remote-sim.c (gdbsim_detach): Likewise.
3111         * remote.c (remote_detach_1): Likewise.
3112         (remote_detach): Likewise.
3113         (extended_remote_detach): Likewise.
3114         * sol-thread.c (sol_thread_detach): Likewise.
3115         * target-debug.h (target_debug_print_inferior_p): New macro.
3116         * target-delegates.c: Re-generate.
3117         * top.c (kill_or_detach): Pass inferior down to target_detach.
3118         * windows-nat.c (windows_detach): Add inferior parameter.
3119
3120 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
3121
3122         * target.h (struct target_ops) <to_detach>: Remove args
3123         parameter.
3124         (target_detach): Likewise.
3125         * target.c (dispose_inferior): Adjust.
3126         (target_detach): Remove args parameter, adjust.
3127         * aix-thread.c (aix_thread_detach): Adjust.
3128         * corefile.c (core_file_command): Adjust.
3129         * corelow.c (core_detach): Adjust.
3130         * darwin-nat.c (darwin_detach): Adjust.
3131         * gnu-nat.c (gnu_detach): Adjust.
3132         * inf-ptrace.c (inf_ptrace_detach): Adjust.
3133         * infcmd.c (detach_command): Adjust
3134         * infrun.c (follow_fork_inferior): Adjust.
3135         (handle_vfork_child_exec_or_exit): Adjust.
3136         * linux-fork.c (linux_fork_detach): Remove args parameter.
3137         * linux-fork.h (linux_fork_detach): Likewise.
3138         * linux-nat.c (linux_nat_detach): Likewise, and adjust.
3139         * linux-thread-db.c (thread_db_detach): Likewise.
3140         * nto-procfs.c (procfs_detach): Likewise.
3141         * procfs.c (procfs_detach): Likewise.
3142         (do_detach): Remove signo parameter.
3143         * record.c (record_detach): Remove args parameter.
3144         * record.h (record_detach): Likewise.
3145         * remote-sim.c (gdbsim_detach): Likewise.
3146         * remote.c (remote_detach_1): Likewise.
3147         (remote_detach): Likewise.
3148         (extended_remote_detach): Likewise.
3149         * sol-thread.c (sol_thread_detach): Likewise.
3150         * target-delegates.c: Re-generate.
3151         * top.c (struct qt_args) <args>: Remove field.
3152         (kill_or_detach): Don't pass args.
3153         (quit_force): Don't set args.
3154         * windows-nat.c (windows_detach): Remove args parameter.
3155
3156 2018-01-19  Yao Qi  <yao.qi@linaro.org>
3157
3158         * arm-linux-tdep.c (arm_linux_gcc_target_options): New function.
3159         (arm_linux_init_abi): Install it.
3160
3161 2018-01-19  Yao Qi  <yao.qi@linaro.org>
3162
3163         * osabi.c (gdb_osabi_names): Extend the regexp for
3164         arm-linux-gnueabihf.
3165
3166 2018-01-18  Yao Qi  <yao.qi@linaro.org>
3167
3168         * dwarf2read.c (abbrev_table) <abbrevs>: Rename it to
3169         m_abbrevs.
3170         (abbrev_table::add_abbrev): Update.
3171         (abbrev_table::lookup_abbrev): Update.
3172
3173 2018-01-18  Yao Qi  <yao.qi@linaro.org>
3174
3175         * ppc-linux-tdep.c (ppu2spu_prev_register): Call cooked_read.
3176
3177 2018-01-17  Sergio Durigan Junior  <sergiodj@redhat.com>
3178
3179         * compile/compile.c (compile_to_object): Convert "triplet_rx"
3180         to "std::string".
3181
3182 2018-01-17  Tom Tromey  <tom@tromey.com>
3183
3184         * dwarf2read.c (symbolp): Remove typedef.  Don't instantiate VEC.
3185
3186 2018-01-17  Tom Tromey  <tom@tromey.com>
3187
3188         * gdbtypes.h (add_dyn_prop): Remove objfile parameter.
3189         * gdbtypes.c (add_dyn_prop): Remove objfile parameter.
3190         (create_array_type_with_stride): Update.
3191         * dwarf2read.c (set_die_type): Update.
3192
3193 2018-01-17  Tom Tromey  <tom@tromey.com>
3194
3195         * dwarf2read.c (delayed_method_info): Remove typedef.
3196         (dwarf2_cu::method_info): Now a std::vector.
3197         (add_to_method_list): Update.
3198         (free_delayed_list): Remove.
3199         (compute_delayed_physnames): Update.
3200         (process_full_comp_unit, process_full_type_unit): Clear the method
3201         list.  Remove cleanups.
3202         (psymtab_include_file_name): Add name_holder parameter.  Use
3203         unique_xmalloc_ptr.
3204         (dwarf_decode_lines): Update.
3205
3206 2018-01-17  Tom Tromey  <tom@tromey.com>
3207             Simon Marchi  <simon.marchi@ericsson.com>
3208
3209         * dwarf2read.c (struct dwarf2_cu): Add constructor, destructor.
3210         (dwarf2_per_objfile::free_cached_comp_units)
3211         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
3212         (init_cutu_and_read_dies_no_follow): Update.
3213         (dwarf2_cu::dwarf2_cu): Rename from init_one_comp_unit.
3214         (dwarf2_cu::~dwarf2_cu): New.
3215         (free_heap_comp_unit, free_stack_comp_unit): Remove.
3216         (age_cached_comp_units, free_one_cached_comp_unit): Update.
3217
3218 2018-01-17  Tom Tromey  <tom@tromey.com>
3219             Simon Marchi  <simon.marchi@ericsson.com>
3220
3221         * dwarf2read.c (struct dwarf2_cu) <abbrev_table>: Remove.
3222         (struct die_reader_specs) <abbrev_table>: New member.
3223         (struct abbrev_table): Add constructor.
3224         <alloc_abbrev, add_abbrev, lookup_abbrev>: Declare.
3225         <abbrev_obstack>: Now an auto_obstack.
3226         (abbrev_table_up): New typedef.
3227         (init_cu_die_reader): Add abbrev_table parameter.
3228         (read_cutu_die_from_dwo): Remove abbrev_table_provided parameter.
3229         Add result_dwo_abbrev_table.
3230         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
3231         (init_cutu_and_read_dies_no_follow, build_type_psymtabs_1):
3232         Update.
3233         (peek_die_abbrev): Take die_reader_specs, not dwarf_cu as
3234         parameter.
3235         (skip_children): Update.
3236         (abbrev_table::alloc_abbrev): Rename from
3237         abbrev_table_alloc_abbrev.
3238         (abbrev_table::add_abbrev): Rename from abbrev_table_add_abbrev.
3239         (abbrev_table::lookup_abbrev): Rename from
3240         abbrev_table_lookup_abbrev.
3241         (abbrev_table_read_table): Return abbrev_table_up.
3242         (abbrev_table_free, abbrev_table_free_cleanup)
3243         (dwarf2_read_abbrevs, dwarf2_free_abbrev_table): Remove.
3244         (load_partial_dies): Update.
3245
3246 2018-01-17  Tom Tromey  <tom@tromey.com>
3247
3248         * dwarf2read.c (dwarf2_compute_name): Update comment.
3249         (read_func_scope, read_variable): Update.
3250         (new_symbol): Remove.
3251         (new_symbol_full): Rename to new_symbol.
3252
3253 2018-01-17  Mike Gulick  <mgulick@mathworks.com>
3254
3255         PR gdb/16577
3256         * gdb_bfd.c (gdb_bfd_map_section): If unable to read object file, issue
3257         a warning instead of throwing an error, set section size to 0 and return
3258         NULL.
3259         * gdb_bfd.h (gdb_bfd_map_section): Update description.
3260
3261 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
3262
3263         * nat/linux-ptrace.h (linux_ptrace_attach_fail_reason): Return
3264         std::string.
3265         (linux_ptrace_attach_fail_reason_string): Likewise.
3266         * nat/linux-ptrace.c (linux_ptrace_attach_fail_reason):
3267         Likewise.
3268         (linux_ptrace_attach_fail_reason_string): Likewise.
3269         * linux-nat.c (attach_proc_task_lwp_callback): Adjust.
3270
3271 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
3272
3273         * linux-nat.c (linux_nat_attach): Remove xstrdup.
3274
3275 2018-01-17  Eldar Abusalimov  <eldar.abusalimov@jetbrains.com>
3276
3277         PR gdb/21559
3278         * configure.ac: Include <sys/types.h> prior to <sys/user.h> when
3279         checking for fs_base/gs_base fields in struct user_regs_struct.
3280         * configure: Regenerate.
3281
3282 2018-01-17  Yao Qi  <yao.qi@linaro.org>
3283
3284         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): New
3285         function.
3286         (aarch64_linux_init_abi): Install it to gdbarch hook
3287         gcc_target_options.
3288
3289 2018-01-15  Pedro Alves  <palves@redhat.com>
3290
3291         * common/signals-state-save-restore.c
3292         (save_original_signals_state): Fix typos.
3293
3294 2017-01-12  Tom Tromey  <tom@tromey.com>
3295             Sergio Durigan Junior  <sergiodj@redhat.com>
3296
3297         * Makefile.in (install-only): Install gdb-add-index.
3298
3299 2018-01-12  John Baldwin  <jhb@FreeBSD.org>
3300
3301         * fbsd-tdep.c (KVE_PROTECTION): Correct value.
3302
3303 2018-01-12  Andreas Arnez  <arnez@linux.vnet.ibm.com>
3304
3305         * infrun.c (keep_going_pass_signal): Clear step-over info when
3306         insert_breakpoints fails.
3307
3308 2018-01-11  Pedro Alves  <palves@redhat.com>
3309
3310         PR gdb/22583
3311         * infrun.c (resume): Rename to ...
3312         (resume_1): ... this.
3313         (resume): Reimplement as wrapper around resume_1.
3314
3315 2018-01-11  Pedro Alves  <palves@redhat.com>
3316
3317         PR remote/22597
3318         * remote.c (remote_parse_stop_reply): Default to the last-set
3319         general thread instead of to 'magic_null_ptid'.
3320
3321 2018-01-10  Pedro Alves  <palves@redhat.com>
3322
3323         * language.h (language_get_symbol_name_matcher): Rename ...
3324         (get_symbol_name_matcher): ... this.
3325         * language.c (language_get_symbol_name_matcher): Ditto.
3326         * dictionary.c, linespec.c, minsyms.c, psymtab.c, symtab.c: All
3327         callers adjusted.
3328
3329 2018-01-10  Pedro Alves  <palves@redhat.com>
3330
3331         PR gdb/22670
3332         * dwarf2read.c
3333         (gdb_index_symbol_name_matcher::gdb_index_symbol_name_matcher):
3334         Adjust to use language_get_symbol_name_matcher instead of
3335         language_defn::la_get_symbol_name_matcher.
3336         * language.c (language_get_symbol_name_matcher): If in Ada mode
3337         and the lookup name is a verbatim match, return Ada's matcher.
3338         * language.h (language_get_symbol_name_matcher): Adjust comment.
3339         (ada_lookup_name_info::verbatim_p):: New method.
3340
3341 2018-01-10  Pedro Alves  <palves@redhat.com>
3342
3343         PR gdb/22670
3344         * ada-lang.c (ada_collect_symbol_completion_matches): If the
3345         minsym's language is language_auto or language_cplus, pass down
3346         language_ada instead.
3347         * symtab.c (compare_symbol_name): Don't frob symbol language here.
3348
3349 2018-01-10  Pedro Alves  <palves@redhat.com>
3350
3351         PR gdb/22670
3352         * minsyms.c (linkage_name_str): New function.
3353         (iterate_over_minimal_symbols): Use it.
3354
3355 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
3356
3357         * NEWS: Document that 'info proc' now works on FreeBSD.
3358
3359 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
3360
3361         * configure.ac: Check for kinfo_getfile in libutil.
3362         * configure: Regenerate.
3363         * config.in: Regenerate.
3364         * fbsd-nat.c: Include "fbsd-tdep.h".
3365         (fbsd_fetch_cmdline): New.
3366         (fbsd_fetch_kinfo_proc): Move earlier and change to return a bool
3367         rather than calling error.
3368         (fbsd_info_proc): New.
3369         (fbsd_thread_name): Report error if fbsd_fetch_kinfo_proc fails.
3370         (fbsd_wait): Report warning if fbsd_fetch_kinfo_proc fails.
3371         (fbsd_nat_add_target): Set "to_info_proc" to "fbsd_info_proc".
3372
3373 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
3374
3375         * fbsd-nat.c (struct free_deleter): Remove.
3376         (fbsd_find_memory_regions): Use gdb::unique_xmalloc_ptr<>.
3377
3378 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
3379
3380         * fbsd-nat.c (fbsd_pid_to_exec_file) [KERN_PROC_PATHNAME]: Return
3381         NULL for an empty pathname.
3382
3383 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
3384
3385         * fbsd-tdep.c (KVE_STRUCTSIZE, KVE_START, KVE_END, KVE_OFFSET)
3386         (KVE_FLAGS, KVE_PROTECTION, KVE_PATH, KINFO_VME_PROT_READ)
3387         (KINFO_VME_PROT_WRITE, KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
3388         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
3389         (KINFO_VME_FLAG_SUPER, KINFO_VME_FLAG_GROWS_UP)
3390         (KINFO_VME_FLAG_GROWS_DOWN, KF_STRUCTSIZE, KF_TYPE, KF_FD)
3391         (KF_PATH, KINFO_FILE_TYPE_VNODE, KINFO_FILE_FD_TYPE_CWD)
3392         (KINFO_FILE_FD_TYPE_TEXT, SIG_WORDS, struct kinfo_proc_layout)
3393         (kinfo_proc_layout_32, kinfo_proc_layout_i386)
3394         (kinfo_proc_layout_64, fbsd_vm_map_entry_flags)
3395         (fbsd_core_info_proc_mappings, fbsd_core_vnode_path)
3396         (fbsd_core_fetch_timeval, fbsd_print_sigset)
3397         (fbsd_core_info_proc_status, fbsd_core_info_proc): New.
3398         (fbsd_init_abi):  Install gdbarch "core_info_proc" method.
3399         * fbsd-tdep.h (fbsd_vm_map_entry_flags): New.
3400
3401 2018-01-08  Samuel Thibault  <samuel.thibault@ens-lyon.org>
3402
3403         * gdb/gnu-nat.c: Include <elf.h> and <link.h>.
3404         (gnu_xfer_auxv): New function.
3405         (gnu_xfer_partial): Call gnu_xfer_auxv when `object' is
3406         TARGET_OBJECT_AUXV.
3407
3408 2018-01-08  Yao Qi  <yao.qi@linaro.org>
3409             Simon Marchi  <simon.marchi@ericsson.com>
3410
3411         * Makefile.in (COMMON_SFILES): Remove selftest-arch.c and
3412         common/selftest.c.
3413         (COMMON_OBS): Remove selftest.o.
3414         * configure.ac: Append selftest-arch.c and common/selftest.c to
3415         CONFIG_SRCS.  Append selftest-arch.o and selftest.o to COMMON_OBS.
3416         * configure: Re-generated.
3417         * maint.c (maintenance_selftest): Wrap selftests::run_tests with
3418         GDB_SELF_TEST.
3419         (maintenance_info_selftests): Likewise.
3420
3421 2018-01-08  Xavier Roirand  <roirand@adacore.com>
3422
3423         * ada-valprint.c (val_print_packed_array_elements): Use
3424         proper number of elements when printing an array indexed
3425         by an enumeration type.
3426
3427 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
3428
3429         * dwarf2read.c (struct dwarf2_cu) <dwarf2_per_objfile>: Remove.
3430         (dw2_get_file_names_reader): Adjust.
3431         (lookup_dwo_signatured_type): Adjust.
3432         (lookup_dwp_signatured_type): Adjust.
3433         (lookup_signatured_type): Adjust.
3434         (create_type_unit_group): Adjust.
3435         (get_type_unit_group): Adjust.
3436         (process_psymtab_comp_unit_reader): Adjust.
3437         (build_type_psymtabs_reader): Adjust.
3438         (scan_partial_symbols): Adjust.
3439         (add_partial_symbol): Adjust.
3440         (add_partial_subprogram): Adjust.
3441         (peek_die_abbrev): Adjust.
3442         (fixup_go_packaging): Adjust.
3443         (process_imported_unit_die): Adjust.
3444         (dwarf2_compute_name): Adjust.
3445         (dwarf2_physname): Adjust.
3446         (read_import_statement): Adjust.
3447         (handle_DW_AT_stmt_list): Adjust.
3448         (read_file_scope): Adjust.
3449         (read_func_scope): Adjust.
3450         (read_lexical_block_scope): Adjust.
3451         (read_call_site_scope): Adjust.
3452         (read_variable): Adjust.
3453         (dwarf2_rnglists_process): Adjust.
3454         (dwarf2_ranges_process): Adjust.
3455         (dwarf2_ranges_read): Adjust.
3456         (dwarf2_get_pc_bounds): Adjust.
3457         (dwarf2_record_block_ranges): Adjust.
3458         (dwarf2_add_field): Adjust.
3459         (dwarf2_add_member_fn): Adjust.
3460         (read_structure_type): Adjust.
3461         (process_structure_scope): Adjust.
3462         (read_enumeration_type): Adjust.
3463         (read_array_type): Adjust.
3464         (mark_common_block_symbol_computed): Adjust.
3465         (read_common_block): Adjust.
3466         (read_namespace_type): Adjust.
3467         (read_namespace): Adjust.
3468         (read_module_type): Adjust.
3469         (read_tag_pointer_type): Adjust.
3470         (read_tag_ptr_to_member_type): Adjust.
3471         (read_tag_string_type): Adjust.
3472         (read_subroutine_type): Adjust.
3473         (read_typedef): Adjust.
3474         (read_base_type): Adjust.
3475         (attr_to_dynamic_prop): Adjust.
3476         (read_subrange_type): Adjust.
3477         (read_unspecified_type): Adjust.
3478         (dwarf2_read_abbrevs): Adjust.
3479         (load_partial_dies): Adjust.
3480         (read_partial_die): Adjust.
3481         (find_partial_die): Adjust.
3482         (guess_partial_die_structure_name): Adjust.
3483         (fixup_partial_die): Adjust.
3484         (read_attribute_value): Adjust.
3485         (read_addr_index): Adjust.
3486         (read_addr_index_from_leb128): Adjust.
3487         (read_str_index): Adjust.
3488         (dwarf2_string_attr): Adjust.
3489         (get_debug_line_section): Adjust.
3490         (dwarf_decode_line_header): Adjust.
3491         (lnp_state_machine::check_line_address): Adjust.
3492         (dwarf_decode_lines_1): Adjust.
3493         (dwarf_decode_lines): Adjust.
3494         (dwarf2_start_symtab): Adjust.
3495         (var_decode_location): Adjust.
3496         (new_symbol_full): Adjust.
3497         (dwarf2_const_value_data): Adjust.
3498         (dwarf2_const_value_attr): Adjust.
3499         (dwarf2_const_value): Adjust.
3500         (die_type): Adjust.
3501         (die_containing_type): Adjust.
3502         (build_error_marker_type): Adjust.
3503         (lookup_die_type): Adjust.
3504         (guess_full_die_structure_name): Adjust.
3505         (anonymous_struct_prefix): Adjust.
3506         (determine_prefix): Adjust.
3507         (dwarf2_name): Adjust.
3508         (follow_die_ref_or_sig): Adjust.
3509         (follow_die_offset): Adjust.
3510         (follow_die_ref): Adjust.
3511         (follow_die_sig_1): Adjust.
3512         (follow_die_sig): Adjust.
3513         (get_signatured_type): Adjust.
3514         (get_DW_AT_signature_type): Adjust.
3515         (decode_locdesc): Adjust.
3516         (dwarf_decode_macros): Adjust.
3517         (cu_debug_loc_section): Adjust.
3518         (fill_in_loclist_baton): Adjust.
3519         (dwarf2_symbol_mark_computed): Adjust.
3520         (init_one_comp_unit): Don't assign
3521         dwarf2_cu::dwarf2_per_objfile.
3522         (set_die_type): Adjust.
3523
3524 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
3525
3526         * dwarf2read.c (struct mapped_debug_names): Add constructor.
3527         <dwarf2_per_objfile>: New field.
3528         (dwarf2_per_objfile): Remove global.
3529         (get_dwarf2_per_objfile): New function.
3530         (set_dwarf2_per_objfile): New function.
3531         (dwarf2_build_psymtabs_hard): Change objfile parameter to
3532         dwarf2_per_objfile.
3533         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
3534         (read_abbrev_offset): Likewise.
3535         (read_indirect_string): Likewise.
3536         (read_indirect_line_string): Likewise.
3537         (read_indirect_string_at_offset): Likewise.
3538         (read_indirect_string_from_dwz): Likewise.
3539         (dwarf2_find_containing_comp_unit): Change objfile parameter to
3540         dwarf2_per_objfile.
3541         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
3542         (create_all_comp_units): Change objfile parameter to
3543         dwarf2_per_objfile.
3544         (create_all_type_units): Likewise.
3545         (process_queue): Add dwarf2_per_objfile parameter.
3546         (read_and_check_comp_unit_head): Likewise.
3547         (lookup_dwo_unit_in_dwp): Likewise.
3548         (get_dwp_file): Likewise.
3549         (process_cu_includes): Likewise.
3550         (struct free_dwo_file_cleanup_data): New struct.
3551         (dwarf2_has_info): Use get_dwarf2_per_objfile and
3552         set_dwarf2_per_objfile.
3553         (dwarf2_get_dwz_file): Add dwarf2_per_objfile parameter.
3554         (dw2_do_instantiate_symtab): Get dwarf2_per_objfile from
3555         context, adjust calls.
3556         (dw2_instantiate_symtab): Likewise.
3557         (dw2_get_cutu): Add dwarf2_per_objfile parameter.
3558         (dw2_get_cu): Likewise.
3559         (create_cu_from_index_list): Change objfile parameter to
3560         dwarf2_per_objfile.
3561         (create_cus_from_index_list): Get dwarf2_per_objfile from
3562         context, adjust calls.
3563         (create_cus_from_index): Likewise.
3564         (create_signatured_type_table_from_index): Change objfile
3565         parameter to dwarf2_per_objfile.
3566         (create_signatured_type_table_from_debug_names): Change objfile
3567         parameter to dwarf2_per_objfile.
3568         (create_addrmap_from_index): Likewise.
3569         (create_addrmap_from_aranges): Likewise.
3570         (dwarf2_read_index): Use get_dwarf2_per_objfile, adjust calls.
3571         (dw2_setup): Remove.
3572         (dw2_get_file_names_reader): Get dwarf2_per_objfile from
3573         context.
3574         (dw2_find_last_source_symtab): Get dwarf2_per_objfile using
3575         get_dwarf2_per_objfile.
3576         (dw2_forget_cached_source_info): Likewise.
3577         (dw2_map_symtabs_matching_filename): Likewise.
3578         (struct dw2_symtab_iterator) <index>: Remove.
3579         <dwarf2_per_objfile>: New field.
3580         (dw2_symtab_iter_init): Replace index parameter with
3581         dwarf2_per_objfile.
3582         (dw2_symtab_iter_next): Use dwarf2_per_objfile from iter.
3583         (dw2_lookup_symbol): Use get_dwarf2_per_objfile and adjust.
3584         (dw2_print_stats): Likewise.
3585         (dw2_dump): Likewise.
3586         (dw2_expand_symtabs_for_function): Likewise.
3587         (dw2_expand_all_symtabs): Likewise.
3588         (dw2_expand_symtabs_with_fullname): Likewise.
3589         (dw2_expand_marked_cus): Replace index and objfile parameters
3590         with dwarf2_per_objfile.
3591         (dw_expand_symtabs_matching_file_matcher): Add
3592         dwarf2_per_objfile parameter and adjust calls.
3593         (dw2_expand_symtabs_matching): Use get_dwarf2_per_objfile and
3594         adjust calls.
3595         (dw2_find_pc_sect_compunit_symtab): Don't call dw2_setup.
3596         (dw2_map_symbol_filenames): Use get_dwarf2_per_objfile and
3597         adjust calls.
3598         (create_cus_from_debug_names_list): Replace objfile parameter
3599         with dwarf2_per_objfile and adjust calls.
3600         (create_cus_from_debug_names): Likewise.
3601         (dwarf2_read_debug_names): Likewise.
3602         (mapped_debug_names::namei_to_name): Adjust call.
3603         (dw2_debug_names_iterator::next): Likewise.
3604         (dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
3605         (dw2_debug_names_lookup_symbol): Use get_dwarf2_per_objfile.
3606         (dw2_debug_names_dump): Likewise.
3607         (dw2_debug_names_expand_symtabs_for_function): Likewise.
3608         (dw2_debug_names_expand_symtabs_matching): Likewise.
3609         (dwarf2_initialize_objfile): Likewise.
3610         (dwarf2_build_psymtabs): Likewise.
3611         (get_abbrev_section_for_cu): Get dwarf2_per_objfile from
3612         this_cu.
3613         (error_check_comp_unit_head): Add dwarf2_per_objfile parameter.
3614         (read_and_check_comp_unit_head): Likewise.
3615         (read_abbrev_offset): Likewise.
3616         (create_debug_type_hash_table): Likewise.
3617         (create_debug_types_hash_table): Likewise.
3618         (create_all_type_units): Replace objfile parameter with
3619         dwarf2_per_objfile.
3620         (add_type_unit): Add dwarf2_per_objfile parameter.
3621         (fill_in_sig_entry_from_dwo_entry): Replace objfile parameter
3622         with dwarf2_per_objfile.
3623         (lookup_dwo_signatured_type): Get dwarf2_per_objfile from cu.
3624         (lookup_dwp_signatured_type): Likewise.
3625         (lookup_signatured_type): Likewise.
3626         (read_cutu_die_from_dwo): Likewise.
3627         (init_tu_and_read_dwo_dies): Likewise.
3628         (init_cutu_and_read_dies): Likewise.
3629         (init_cutu_and_read_dies_no_follow): Likewise.
3630         (allocate_type_unit_groups_table): Add objfile parameter.
3631         (create_type_unit_group): Use dwarf2_per_objfile from cu.
3632         (get_type_unit_group): Likewise.
3633         (process_psymtab_comp_unit): Update call.
3634         (build_type_psymtabs_reader): Use dwarf2_per_objfile from cu.
3635         (build_type_psymtabs_1): Add dwarf2_per_objfile parameter.
3636         (print_tu_stats): Likewise.
3637         (build_type_psymtab_dependencies): Use dwarf2_per_objfile passed
3638         in void* parameter.
3639         (build_type_psymtabs): Change objfile parameter to
3640         dwarf2_per_objfile.
3641         (process_skeletonless_type_unit): Use dwarf2_per_objfile
3642         passed in void* parameter.
3643         (process_skeletonless_type_units): Change objfile parameter to
3644         dwarf2_per_objfile.
3645         (set_partial_user): Likewise.
3646         (dwarf2_build_psymtabs_hard): Likewise.
3647         (read_comp_units_from_section): Likewise.
3648         (create_all_comp_units): Likewise.
3649         (scan_partial_symbols): Update calls.
3650         (add_partial_symbol): Likewise.
3651         (dwarf2_read_symtab): Use get_dwarf2_per_objfile.
3652         (maybe_queue_comp_unit): Use dwarf2_read_symtab from cu.
3653         (process_queue): Add dwarf2_per_objfile parameter.
3654         (get_compunit_symtab): Use dwarf2_per_objfile from cu.
3655         (compute_compunit_symtab_includes): Likewise.
3656         (process_cu_includes): Add dwarf2_per_objfile parameter.
3657         (process_full_comp_unit): Use dwarf2_per_objfile from cu.
3658         (process_full_type_unit): Likewise.
3659         (process_imported_unit_die): Update call.
3660         (handle_DW_AT_stmt_list): Use dwarf2_per_objfile from cu.
3661         (read_file_scope): Likewise.
3662         (allocate_dwo_file_hash_table): Add objfile parameter.
3663         (lookup_dwo_file_slot): Add dwarf2_per_objfile parameter.
3664         (create_cus_hash_table): Likewise.
3665         (create_dwp_hash_table): Likewise.
3666         (create_dwo_unit_in_dwp_v1): Likewise.
3667         (create_dwp_v2_section): Likewise.
3668         (create_dwo_unit_in_dwp_v2): Likewise.
3669         (lookup_dwo_unit_in_dwp): Likewise.
3670         (try_open_dwop_file): Likewise.
3671         (open_dwo_file): Likewise. Use dwarf2_per_objfile from cu.
3672         (open_and_init_dwo_file): Use dwarf2_per_objfile from cu, update
3673         cleanup to include a reference to dwarf2_per_objfile.
3674         (open_dwp_file): Add dwarf2_per_objfile parameter.
3675         (open_and_init_dwp_file): Likewise.
3676         (get_dwp_file): Likewise.
3677         (lookup_dwo_cutu): Use dwarf2_per_objfile from cu.
3678         (queue_and_load_all_dwo_tus): Update call.
3679         (free_dwo_file_cleanup): Use dwarf2_per_objfile from cleanup
3680         data.
3681         (dwarf2_rnglists_process): Use dwarf2_per_objfile from cu.
3682         (dwarf2_ranges_process): Likewise.
3683         (dwarf2_get_pc_bounds): Likewise.
3684         (mark_common_block_symbol_computed): Likewise.
3685         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
3686         (dwarf2_read_abbrevs): Update call.
3687         (read_partial_die): Use dwarf2_per_objfile from cu.
3688         (find_partial_die): Likewise.
3689         (fixup_partial_die): Likewise.
3690         (read_attribute_value): Likewise.
3691         (read_indirect_string_at_offset_from): Add objfile parameter.
3692         (read_indirect_string_at_offset): Add dwarf2_per_objfile
3693         parameter.
3694         (read_indirect_string_from_dwz): Add objfile parameter.
3695         (read_indirect_string): Add objfile parameter.
3696         (read_addr_index_1): Add dwarf2_per_objfile parameter.
3697         (read_addr_index): Use dwarf2_per_objfile from cu.
3698         (dwarf2_read_addr_index): Use dwarf2_per_objfile from cu, don't
3699         call dw2_setup.
3700         (read_str_index): Use dwarf2_per_objfile from cu.
3701         (get_debug_line_section): Likewise.
3702         (read_formatted_entries): Add dwarf2_per_objfile parameter.
3703         (dwarf_decode_line_header): Use dwarf2_per_objfile from cu.
3704         (new_symbol_full): Use dwarf2_per_objfile from cu.
3705         (build_error_marker_type): Likewise.
3706         (lookup_die_type): Likewise.
3707         (determine_prefix): Likewise.
3708         (follow_die_offset): Likewise.
3709         (dwarf2_fetch_die_loc_sect_off): Use get_dwarf2_per_objfile.
3710         (dwarf2_fetch_constant_bytes): Don't call dw2_setup.
3711         (dwarf2_fetch_die_type_sect_off): Likewise.
3712         (dwarf2_get_die_type): Likewise.
3713         (follow_die_sig_1): Use dwarf2_per_objfile from cu.
3714         (get_signatured_type): Likewise.
3715         (get_DW_AT_signature_type): Likewise.
3716         (dwarf_decode_macro_bytes): Add dwarf2_per_objfile parameter.
3717         (dwarf_decode_macros): Use dwarf2_per_objfile from cu.
3718         (cu_debug_loc_section): Likewise.
3719         (fill_in_loclist_baton): Likewise.
3720         (dwarf2_symbol_mark_computed): Likewise.
3721         (dwarf2_find_containing_comp_unit): Change objfile parameter to
3722         dwarf2_per_objfile.
3723         (free_cached_comp_units): Use dwarf2_per_objfile passed in void*
3724         parameter.
3725         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
3726         (free_one_cached_comp_unit): Use dwarf2_per_objfile from cu.
3727         (dwarf2_free_objfile): Use get_dwarf2_per_objfile.
3728         (set_die_type): Use dwarf2_free_objfile from cu.
3729         (get_die_type_at_offset): Likewise.
3730         (dwarf2_per_objfile_free): Don't assign global variable.
3731         (debug_names) <constructor>: Add dwarf2_per_objfile
3732         parameter, update m_debugstrlookup construction.
3733         (debug_names::debug_str_lookup): Add dwarf2_per_objfile
3734         parameter.
3735         <m_dwarf2_per_objfile>: New field.
3736         <lookup>: Use m_dwarf2_per_objfile.
3737         (check_dwarf64_offsets): Add dwarf2_per_objfile parameter.
3738         (psyms_seen_size): Likewise.
3739         (write_gdbindex): Replace objfile parameter with
3740         dwarf2_per_objfile.
3741         (write_debug_names): Likewise.
3742         (write_psymtabs_to_index): Likewise.
3743         (save_gdb_index_command): Use get_dwarf2_per_objfile, update
3744         calls.
3745
3746 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
3747
3748         * dwarf2read.c (struct dwarf2_cu) <objfile>: Remove.
3749         <dwarf2_per_objfile>: New field.
3750         (struct dwarf2_per_cu_data) <objfile>: Remove.
3751         <dwarf2_per_objfile>: New field.
3752         (create_cu_from_index_list): Assign dwarf2_per_objfile instead
3753         of objfile.
3754         (create_signatured_type_table_from_index): Likewise.
3755         (create_debug_type_hash_table): Likewise.
3756         (fill_in_sig_entry_from_dwo_entry): Likewise.
3757         (lookup_dwo_unit): Access objfile through dwarf2_per_objfile.
3758         (create_type_unit_group): Assign dwarf2_per_objfile instead of
3759         objfile.
3760         (create_partial_symtab): Access objfile through
3761         dwarf2_per_objfile.
3762         (process_psymtab_comp_unit_reader): Likewise.
3763         (read_comp_units_from_section): Likewise.
3764         (scan_partial_symbols): Likewise.
3765         (add_partial_symbol): Likewise.
3766         (add_partial_subprogram): Likewise.
3767         (peek_die_abbrev): Likewise.
3768         (fixup_go_packaging): Likewise.
3769         (process_full_comp_unit): Likewise.
3770         (process_full_type_unit): Likewise.
3771         (process_imported_unit_die): Likewise.
3772         (dwarf2_compute_name): Likewise.
3773         (dwarf2_physname): Likewise.
3774         (read_import_statement): Likewise.
3775         (create_cus_hash_table): Assign dwarf2_physname instead of
3776         objfile.
3777         (read_func_scope): Access objfile through dwarf2_per_objfile.
3778         (read_lexical_block_scope): Likewise.
3779         (read_call_site_scope): Likewise.
3780         (read_variable): Likewise.
3781         (dwarf2_rnglists_process): Likewise.
3782         (dwarf2_ranges_process): Likewise.
3783         (dwarf2_ranges_read): Likewise.
3784         (dwarf2_record_block_ranges): Likewise.
3785         (dwarf2_add_field): Likewise.
3786         (dwarf2_add_member_fn): Likewise.
3787         (read_structure_type): Likewise.
3788         (process_structure_scope): Likewise.
3789         (read_enumeration_type): Likewise.
3790         (read_array_type): Likewise.
3791         (read_common_block): Likewise.
3792         (read_namespace_type): Likewise.
3793         (read_namespace): Likewise.
3794         (read_module_type): Likewise.
3795         (read_tag_pointer_type): Likewise.
3796         (read_tag_ptr_to_member_type): Likewise.
3797         (read_tag_string_type): Likewise.
3798         (read_subroutine_type): Likewise.
3799         (read_typedef): Likewise.
3800         (read_base_type): Likewise.
3801         (attr_to_dynamic_prop): Likewise.
3802         (read_subrange_type): Likewise.
3803         (read_unspecified_type): Likewise.
3804         (load_partial_dies): Likewise.
3805         (read_partial_die): Likewise.
3806         (find_partial_die): Likewise.
3807         (guess_partial_die_structure_name): Likewise.
3808         (fixup_partial_die): Likewise.
3809         (read_attribute_value): Likewise.
3810         (read_addr_index_from_leb128): Likewise.
3811         (dwarf2_read_addr_index): Likewise.
3812         (dwarf2_string_attr): Likewise.
3813         (lnp_state_machine::check_line_address): Likewise.
3814         (dwarf_decode_lines_1): Likewise.
3815         (dwarf_decode_lines): Likewise.
3816         (dwarf2_start_symtab): Likewise.
3817         (var_decode_location): Likewise.
3818         (new_symbol_full): Likewise.
3819         (dwarf2_const_value_data): Likewise.
3820         (dwarf2_const_value_attr): Likewise.
3821         (dwarf2_const_value): Likewise.
3822         (die_type): Likewise.
3823         (die_containing_type): Likewise.
3824         (lookup_die_type): Likewise.
3825         (guess_full_die_structure_name): Likewise.
3826         (anonymous_struct_prefix): Likewise.
3827         (dwarf2_name): Likewise.
3828         (follow_die_ref_or_sig): Likewise.
3829         (follow_die_offset): Likewise.
3830         (follow_die_ref): Likewise.
3831         (dwarf2_fetch_die_loc_sect_off): Likewise.
3832         (dwarf2_fetch_constant_bytes): Likewise.
3833         (dwarf2_fetch_die_type_sect_off): Likewise.
3834         (dwarf2_get_die_type): Likewise.
3835         (follow_die_sig): Likewise.
3836         (decode_locdesc): Likewise.
3837         (dwarf2_per_cu_objfile): Likewise.
3838         (dwarf2_per_cu_text_offset): Likewise.
3839         (init_one_comp_unit): Assign dwarf2_per_objfile instead of
3840         objfile.
3841         (set_die_type): Access objfile through
3842         dwarf2_per_objfile.
3843
3844 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
3845
3846         * valprint.c (converted_character_d): Remove typedef.
3847         (DEF_VEC_O (converted_character_d)): Remove.
3848         (count_next_character): Use std::vector.
3849         (print_converted_chars_to_obstack): Likewise.
3850         (generic_printstr): Likewise.
3851
3852 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
3853
3854         * xml-support.h (struct gdb_xml_value): Add constructor.
3855         <value>: Change type to unique_xmalloc_ptr.
3856         (gdb_xml_value_s): Remove typedef.
3857         (DEF_VEC_O (gdb_xml_value_s)): Remove.
3858         (gdb_xml_element_start_handler): Change parameter type to
3859         std::vector.
3860         (xml_find_attribute): Likewise.
3861         * xml-support.c (xml_find_attribute): Change parameter type to
3862         std::vector and adjust.
3863         (gdb_xml_values_cleanup): Remove.
3864         (gdb_xml_parser::start_element): Adjust to std::vector.
3865         (xinclude_start_include): Change paraeter type to std::vector
3866         and adjust.
3867         * btrace.c (check_xml_btrace_version): Likewise.
3868         (parse_xml_btrace_block): Likewise.
3869         (parse_xml_btrace_pt_config_cpu): Likewise.
3870         (parse_xml_btrace_pt): Likewise.
3871         (parse_xml_btrace_conf_bts): Likewise.
3872         (parse_xml_btrace_conf_pt): Likewise.
3873         * memory-map.c (memory_map_start_memory): Likewise.
3874         (memory_map_start_property): Likewise.
3875         * osdata.c (osdata_start_osdata): Likewise.
3876         (osdata_start_item): Likewise.
3877         (osdata_start_column): Likewise.
3878         * remote.c (start_thread): Likewise.
3879         * solib-aix.c (library_list_start_library): Likewise.
3880         (library_list_start_list): Likewise.
3881         * solib-svr4.c (library_list_start_library): Likewise.
3882         (svr4_library_list_start_list): Likewise.
3883         * solib-target.c (library_list_start_segment): Likewise.
3884         (library_list_start_section): Likewise.
3885         (library_list_start_library): Likewise.
3886         (library_list_start_list): Likewise.
3887         * tracepoint.c (traceframe_info_start_memory): Likewise.
3888         (traceframe_info_start_tvar): Likewise.
3889         * xml-syscall.c (syscall_start_syscall): Likewise.
3890         * xml-tdesc.c (tdesc_start_target): Likewise.
3891         (tdesc_start_feature): Likewise.
3892         (tdesc_start_reg): Likewise.
3893         (tdesc_start_union): Likewise.
3894         (tdesc_start_struct): Likewise.
3895         (tdesc_start_flags): Likewise.
3896         (tdesc_start_enum): Likewise.
3897         (tdesc_start_field): Likewise.
3898         (tdesc_start_enum_value): Likewise.
3899         (tdesc_start_vector): Likewise.
3900
3901 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
3902
3903         * extension.h (struct xmethod_worker) <clone>: Remove.
3904         * python/py-xmethods.c (struct python_xmethod_worker) <clone>:
3905         Remove.
3906         (python_xmethod_worker::clone): Remove.
3907         * valops.c (find_overload_match): Use std::move instead of
3908         clone.
3909
3910 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
3911
3912         * extension-priv.h (enum ext_lang_rc): Remove, move to extension.h.
3913         (struct extension_language_ops) <clone_xmethod_worker_data>: Remove.
3914         <free_xmethod_worker_data>: Remove.
3915         <get_matching_xmethod_workers>: Chance VEC to std::vector.
3916         <get_xmethod_arg_types>: Remove.
3917         <get_xmethod_result_type>: Remove.
3918         <invoke_xmethod>: Remove.
3919         * extension.c (new_xmethod_worker): Remove.
3920         (clone_xmethod_worker): Remove.
3921         (get_matching_xmethod_workers): Return void, pass std::vector by
3922         pointer.
3923         (get_xmethod_arg_types): Rename to...
3924         (xmethod_worker::get_arg_types): ... this, and adjust.
3925         (get_xmethod_result_type): Rename to...
3926         (xmethod_worker::get_result_type): ... this, and adjust.
3927         (invoke_xmethod): Remove.
3928         (free_xmethod_worker): Remove.
3929         (free_xmethod_worker_vec): Remove.
3930         * extension.h (enum ext_lang_rc): Move here from
3931         extension-priv.h.
3932         (struct xmethod_worker): Add constructor and destructor.
3933         <data>: Remove.
3934         <value>: Remove.
3935         <invoke, clone, do_get_result_type, do_get_arg_types>: New
3936         virtual pure methods.
3937         <get_arg_types, get_result_type>: New methods.
3938         (xmethod_worker_ptr): Remove typedef.
3939         (DEF_VEC_P (xmethod_worker_ptr)): Remove.
3940         (xmethod_worker_vec): Remove typedef.
3941         (xmethod_worker_up): New typedef.
3942         (invoke_xmethod): Remove.
3943         (clone_xmethod_worker): Remove.
3944         (free_xmethod_worker): Remove.
3945         (free_xmethod_worker_vec): Remove.
3946         (get_xmethod_arg_types): Remove.
3947         (get_xmethod_result_type): Remove.
3948         * valops.c (find_method_list): Use std::vector, don't use
3949         intermediate vector.
3950         (value_find_oload_method_list): Use std::vector.
3951         (find_overload_match): Use std::vector.
3952         (find_oload_champ): Use std::vector.
3953         * value.c (value_free): Use operator delete.
3954         (value_of_xmethod): Rename to...
3955         (value_from_xmethod): ... this.  Don't assign
3956         xmethod_worker::value, take rvalue-reference.
3957         (result_type_of_xmethod): Adjust.
3958         (call_xmethod): Adjust.
3959         * value.h: Include extension.h.
3960         (struct xmethod_worker): Don't forward-declare.
3961         (value_of_xmethod): Rename to...
3962         (value_from_xmethod): ... this, take rvalue-reference.
3963         * python/py-xmethods.c (struct gdbpy_worker_data): Rename to...
3964         (struct python_xmethod_worker): ... this, add constructor and
3965         destructor.
3966         <invoke, clone, do_get_arg_types, do_get_result_type>: Implement.
3967         (gdbpy_free_xmethod_worker_data): Rename to...
3968         (python_xmethod_worker::~python_xmethod_worker): ... this and
3969         adjust.
3970         (gdbpy_clone_xmethod_worker_data): Rename to...
3971         (python_xmethod_worker::clone): ... this and adjust.
3972         (gdbpy_get_matching_xmethod_workers): Use std::vector, don't use
3973         temporary vector.
3974         (gdbpy_get_xmethod_arg_types): Rename to...
3975         (python_xmethod_worker::do_get_arg_types): ... this and adjust.
3976         (gdbpy_get_xmethod_result_type): Rename to...
3977         (python_xmethod_worker::do_get_result_type): ... this and
3978         adjust.
3979         (gdbpy_invoke_xmethod): Rename to...
3980         (python_xmethod_worker::invoke): ... this and adjust.
3981         (new_python_xmethod_worker): Rename to...
3982         (python_xmethod_worker::python_xmethod_worker): ... this and
3983         adjust.
3984         * python/python-internal.h (gdbpy_clone_xmethod_worker_data):
3985         Remove.
3986         (gdbpy_free_xmethod_worker_data): Remove.
3987         (gdbpy_get_matching_xmethod_workers): Use std::vector.
3988         (gdbpy_get_xmethod_arg_types): Remove.
3989         (gdbpy_get_xmethod_result_type): Remove.
3990         (gdbpy_invoke_xmethod): Remove.
3991         * python/python.c (python_extension_ops): Remove obsolete
3992         callbacks.
3993
3994 2018-01-05  Pedro Alves  <palves@redhat.com>
3995
3996         PR gdb/18653
3997         * common/signals-state-save-restore.c
3998         (save_original_signals_state): New parameter 'quiet'.  Warn if we
3999         find a custom handler preinstalled, instead of internal erroring.
4000         But only warn if !quiet.
4001         * common/signals-state-save-restore.h
4002         (save_original_signals_state): New parameter 'quiet'.
4003         * main.c (captured_main_1): Move save_original_signals_state call
4004         after option handling, and pass QUIET.
4005
4006 2018-01-05  Pedro Alves  <palves@redhat.com>
4007
4008         * spu-tdep.c (spu_catch_start): Pass
4009         symbol_name_match_type::SEARCH_NAME to block_lookup_symbol.
4010
4011 2018-01-05  Pedro Alves  <palves@redhat.com>
4012
4013         PR gdb/22670
4014         * ada-lang.c (literal_symbol_name_matcher): New function.
4015         (ada_get_symbol_name_matcher): Use it for
4016         symbol_name_match_type::SEARCH_NAME.
4017         * block.c (block_lookup_symbol): New parameter 'match_type'.  Pass
4018         it down instead of assuming symbol_name_match_type::FULL.
4019         * block.h (block_lookup_symbol): New parameter 'match_type'.
4020         * c-valprint.c (print_unpacked_pointer): Use
4021         lookup_symbol_search_name instead of lookup_symbol.
4022         * compile/compile-object-load.c (get_out_value_type): Pass down
4023         symbol_name_match_type::SEARCH_NAME.
4024         * cp-namespace.c (cp_basic_lookup_symbol): Pass down
4025         symbol_name_match_type::FULL.
4026         * cp-support.c (cp_get_symbol_name_matcher): Handle
4027         symbol_name_match_type::SEARCH_NAME.
4028         * infrun.c (insert_exception_resume_breakpoint): Use
4029         lookup_symbol_search_name.
4030         * p-valprint.c (pascal_val_print): Use lookup_symbol_search_name.
4031         * psymtab.c (maintenance_check_psymtabs): Use
4032         symbol_name_match_type::SEARCH_NAME and SYMBOL_SEARCH_NAME.
4033         * stack.c (print_frame_args): Use lookup_symbol_search_name and
4034         SYMBOL_SEARCH_NAME.
4035         * symtab.c (lookup_local_symbol): Don't demangle the lookup name
4036         if symbol_name_match_type::SEARCH_NAME.
4037         (lookup_symbol_in_language): Pass down
4038         symbol_name_match_type::FULL.
4039         (lookup_symbol_search_name): New.
4040         (lookup_language_this): Pass down
4041         symbol_name_match_type::SEARCH_NAME.
4042         (lookup_symbol_aux, lookup_local_symbol): New parameter
4043         'match_type'.  Pass it down.
4044         * symtab.h (symbol_name_match_type::SEARCH_NAME): New enumerator.
4045         (lookup_symbol_search_name): New declaration.
4046         (lookup_symbol_in_block): New 'match_type' parameter.
4047
4048 2018-01-05  Pedro Alves  <palves@redhat.com>
4049
4050         PR gdb/22670
4051         * ada-lang.c (ada_lookup_encoded_symbol): Reimplement in terms of
4052         ada_lookup_symbol.
4053         (ada_lookup_symbol): Reimplement in terms of
4054         ada_lookup_symbol_list, bits factored out from
4055         ada_lookup_encoded_symbol.
4056
4057 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
4058
4059         * ada-exp.y (write_object_renaming): When subscripting an array
4060         using a symbol as the index, pass the block in call to
4061         ada_lookup_encoded_symbol when looking that symbol up.
4062
4063 2018-01-05  Jerome Guitton  <guitton@adacore.com>
4064
4065         * ada-lang.c (ada_array_length): Use ada_index_type instead of
4066         TYPE_INDEX_TYPE.
4067
4068 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
4069
4070         * ada-lang.c (ada_to_fixed_value_create): Add handling of
4071         the case where VALUE_LVAL (val0) is not lval_memory.
4072
4073 2018-01-05  Xavier Roirand  <roirand@adacore.com>
4074
4075         * ada-valprint.c (print_optional_low_bound): Handle
4076         character-indexed array printing like boolean-indexed array
4077         printing.
4078
4079 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
4080
4081         * NEWS: Create a new section for the next release branch.
4082         Rename the section of the current branch, now that it has
4083         been cut.
4084
4085 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
4086
4087         GDB 8.1 branch created (5219ac6237c272b938c28517bf371429260c71e7):
4088         * version.in: Bump version to 8.1.50.DATE-git.
4089
4090 2018-01-03  Xavier Roirand  <roirand@adacore.com>
4091
4092         * ada-lang.h (ada_exception_catchpoint_kind) <ada_catch_handlers>:
4093         Add field.
4094         * ada-lang.c (struct exception_support_info) <catch_handlers_sym>:
4095         Add field.
4096         (default_exception_support_info) <catch_handlers_sym>: Add field.
4097         (exception_support_info_fallback) <catch_handlers_sym>: Add field.
4098         (ada_exception_name_addr_1): Add "catch handlers" handling.
4099         (ada_exception_catchpoint_cond_string) <ex>: New parameter.
4100         Update all callers.
4101         (create_excep_cond_exprs) <ex>: Add parameter.
4102         (re_set_exception): Update create_excep_cond_exprs call.
4103         (print_it_exception, print_one_exception, print_mention_exception)
4104         (print_recreate_exception): Add "catch handler" handling.
4105         (allocate_location_catch_handlers, re_set_catch_handlers)
4106         (check_status_catch_handlers, print_it_catch_handlers)
4107         (print_one_catch_handlers, print_mention_catch_handlers)
4108         (print_recreate_catch_handlers): New function.
4109         (catch_handlers_breakpoint_ops): New variable.
4110         (catch_ada_exception_command_split) <is_catch_handlers_cmd>:
4111         Add parameter.  Add "catch handler" handling.
4112         (ada_exception_sym_name, ada_exception_breakpoint_ops):
4113         Add "catch handler" handling.
4114         (ada_exception_catchpoint_cond_string): Add "catch handler"
4115         handling.
4116         (create_ada_exception_catchpoint): Update create_excep_cond_exprs
4117         call.
4118         (catch_ada_handlers_command): New function.
4119         (initialize_ada_catchpoint_ops): Initialize "catch handlers"
4120         operations structure.
4121         (_initialize_ada_language): Add "catch handlers" command entry.
4122         * NEWS: Document "catch handlers" feature.
4123
4124 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
4125
4126         * ada-lang.c (ada_value_slice_from_ptr): Take array stride into
4127         account when creating the array type of the slice.
4128         (ada_value_slice): Likewise.
4129
4130 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
4131
4132         * gdbtypes.h (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_STRIDE>:
4133         New enum value.
4134         (create_array_type_with_stride): Add byte_stride_prop parameter.
4135         * gdbtypes.c (create_array_type_with_stride) <byte_stride_prop>:
4136         New parameter.  Update all callers in this file.
4137         (array_type_has_dynamic_stride): New function.
4138         (is_dynamic_type_internal, resolve_dynamic_array): Add handling
4139         of arrays with dynamic byte strides.
4140         * dwarf2read.c (read_array_type): Add support for dynamic
4141         DW_AT_byte_stride attributes.
4142
4143 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
4144
4145         * dwarf2read.c (read_unspecified_type): Treat
4146         DW_TAG_enumeration_type DIEs from Ada units as stubs.
4147
4148 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
4149
4150         Update copyright year range in all GDB files.
4151
4152 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
4153
4154         * copyright.py (BY_HAND): Remove gdb/testsuite/gdb.base/step-line.inp
4155         and gdb/testsuite/gdb.base/step-line.c.
4156
4157 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
4158
4159         * copyright.py (main): Dump the contents of
4160         MULTIPLE_COPYRIGHT_HEADERS (separately) from BY_HAND,
4161         even if BY_HAND is empty.
4162
4163 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
4164
4165         * top.c (print_gdb_version): Update Copyright year in version
4166         message.
4167
4168 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
4169
4170         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2017.
4171
4172 For older changes see ChangeLog-2017.
4173 \f
4174 Local Variables:
4175 mode: change-log
4176 left-margin: 8
4177 fill-column: 74
4178 version-control: never
4179 coding: utf-8
4180 End: