gdb/ChangeLog

   1 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
   2
   3         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
   4         (aarch64_fbsd_fpregmap): Move earlier.
   5         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
   6         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
   7         instead of individual calls to trad_frame_set_reg_addr.
   8         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
   9         earlier.
  10         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
  11         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
  12         instead of individual calls to trad_frame_set_reg_addr.
  13
  14 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
  15
  16         * CONTRIBUTE: Replace contribution list with wiki link.
  17
  18 2019-01-25  Tom Tromey  <tom@tromey.com>
  19
  20         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
  21
  22 2019-01-25  Tom Tromey  <tom@tromey.com>
  23
  24         * xtensa-linux-nat.c: Fix common/ includes.
  25         * xml-support.h: Fix common/ includes.
  26         * xml-support.c: Fix common/ includes.
  27         * x86-linux-nat.c: Fix common/ includes.
  28         * windows-nat.c: Fix common/ includes.
  29         * varobj.h: Fix common/ includes.
  30         * varobj.c: Fix common/ includes.
  31         * value.c: Fix common/ includes.
  32         * valops.c: Fix common/ includes.
  33         * utils.c: Fix common/ includes.
  34         * unittests/xml-utils-selftests.c: Fix common/ includes.
  35         * unittests/utils-selftests.c: Fix common/ includes.
  36         * unittests/unpack-selftests.c: Fix common/ includes.
  37         * unittests/tracepoint-selftests.c: Fix common/ includes.
  38         * unittests/style-selftests.c: Fix common/ includes.
  39         * unittests/string_view-selftests.c: Fix common/ includes.
  40         * unittests/scoped_restore-selftests.c: Fix common/ includes.
  41         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
  42         * unittests/scoped_fd-selftests.c: Fix common/ includes.
  43         * unittests/rsp-low-selftests.c: Fix common/ includes.
  44         * unittests/parse-connection-spec-selftests.c: Fix common/
  45         includes.
  46         * unittests/optional-selftests.c: Fix common/ includes.
  47         * unittests/offset-type-selftests.c: Fix common/ includes.
  48         * unittests/observable-selftests.c: Fix common/ includes.
  49         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
  50         * unittests/memrange-selftests.c: Fix common/ includes.
  51         * unittests/memory-map-selftests.c: Fix common/ includes.
  52         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
  53         * unittests/function-view-selftests.c: Fix common/ includes.
  54         * unittests/environ-selftests.c: Fix common/ includes.
  55         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
  56         * unittests/common-utils-selftests.c: Fix common/ includes.
  57         * unittests/cli-utils-selftests.c: Fix common/ includes.
  58         * unittests/array-view-selftests.c: Fix common/ includes.
  59         * ui-file.c: Fix common/ includes.
  60         * tui/tui-io.c: Fix common/ includes.
  61         * tracepoint.h: Fix common/ includes.
  62         * tracepoint.c: Fix common/ includes.
  63         * tracefile-tfile.c: Fix common/ includes.
  64         * top.h: Fix common/ includes.
  65         * top.c: Fix common/ includes.
  66         * thread.c: Fix common/ includes.
  67         * target/waitstatus.h: Fix common/ includes.
  68         * target/waitstatus.c: Fix common/ includes.
  69         * target.h: Fix common/ includes.
  70         * target.c: Fix common/ includes.
  71         * target-memory.c: Fix common/ includes.
  72         * target-descriptions.c: Fix common/ includes.
  73         * symtab.h: Fix common/ includes.
  74         * symfile.c: Fix common/ includes.
  75         * stap-probe.c: Fix common/ includes.
  76         * spu-linux-nat.c: Fix common/ includes.
  77         * sparc-nat.c: Fix common/ includes.
  78         * source.c: Fix common/ includes.
  79         * solib.c: Fix common/ includes.
  80         * solib-target.c: Fix common/ includes.
  81         * ser-unix.c: Fix common/ includes.
  82         * ser-tcp.c: Fix common/ includes.
  83         * ser-pipe.c: Fix common/ includes.
  84         * ser-base.c: Fix common/ includes.
  85         * selftest-arch.c: Fix common/ includes.
  86         * s12z-tdep.c: Fix common/ includes.
  87         * rust-exp.y: Fix common/ includes.
  88         * rs6000-aix-tdep.c: Fix common/ includes.
  89         * riscv-tdep.c: Fix common/ includes.
  90         * remote.c: Fix common/ includes.
  91         * remote-notif.h: Fix common/ includes.
  92         * remote-fileio.h: Fix common/ includes.
  93         * remote-fileio.c: Fix common/ includes.
  94         * regcache.h: Fix common/ includes.
  95         * regcache.c: Fix common/ includes.
  96         * record-btrace.c: Fix common/ includes.
  97         * python/python.c: Fix common/ includes.
  98         * python/py-type.c: Fix common/ includes.
  99         * python/py-inferior.c: Fix common/ includes.
 100         * progspace.h: Fix common/ includes.
 101         * producer.c: Fix common/ includes.
 102         * procfs.c: Fix common/ includes.
 103         * proc-api.c: Fix common/ includes.
 104         * printcmd.c: Fix common/ includes.
 105         * ppc-linux-nat.c: Fix common/ includes.
 106         * parser-defs.h: Fix common/ includes.
 107         * osdata.c: Fix common/ includes.
 108         * obsd-nat.c: Fix common/ includes.
 109         * nat/x86-linux.c: Fix common/ includes.
 110         * nat/x86-linux-dregs.c: Fix common/ includes.
 111         * nat/x86-dregs.h: Fix common/ includes.
 112         * nat/x86-dregs.c: Fix common/ includes.
 113         * nat/ppc-linux.c: Fix common/ includes.
 114         * nat/mips-linux-watch.h: Fix common/ includes.
 115         * nat/mips-linux-watch.c: Fix common/ includes.
 116         * nat/linux-waitpid.c: Fix common/ includes.
 117         * nat/linux-ptrace.h: Fix common/ includes.
 118         * nat/linux-ptrace.c: Fix common/ includes.
 119         * nat/linux-procfs.c: Fix common/ includes.
 120         * nat/linux-personality.c: Fix common/ includes.
 121         * nat/linux-osdata.c: Fix common/ includes.
 122         * nat/linux-namespaces.c: Fix common/ includes.
 123         * nat/linux-btrace.h: Fix common/ includes.
 124         * nat/linux-btrace.c: Fix common/ includes.
 125         * nat/fork-inferior.c: Fix common/ includes.
 126         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 127         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 128         * nat/aarch64-linux.c: Fix common/ includes.
 129         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 130         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 131         * namespace.h: Fix common/ includes.
 132         * mips-linux-tdep.c: Fix common/ includes.
 133         * minsyms.c: Fix common/ includes.
 134         * mi/mi-parse.h: Fix common/ includes.
 135         * mi/mi-main.c: Fix common/ includes.
 136         * mi/mi-cmd-env.c: Fix common/ includes.
 137         * memrange.h: Fix common/ includes.
 138         * memattr.c: Fix common/ includes.
 139         * maint.h: Fix common/ includes.
 140         * maint.c: Fix common/ includes.
 141         * main.c: Fix common/ includes.
 142         * machoread.c: Fix common/ includes.
 143         * location.c: Fix common/ includes.
 144         * linux-thread-db.c: Fix common/ includes.
 145         * linux-nat.c: Fix common/ includes.
 146         * linux-fork.c: Fix common/ includes.
 147         * inline-frame.c: Fix common/ includes.
 148         * infrun.c: Fix common/ includes.
 149         * inflow.c: Fix common/ includes.
 150         * inferior.h: Fix common/ includes.
 151         * inferior.c: Fix common/ includes.
 152         * infcmd.c: Fix common/ includes.
 153         * inf-ptrace.c: Fix common/ includes.
 154         * inf-child.c: Fix common/ includes.
 155         * ia64-linux-nat.c: Fix common/ includes.
 156         * i387-tdep.c: Fix common/ includes.
 157         * i386-tdep.c: Fix common/ includes.
 158         * i386-linux-tdep.c: Fix common/ includes.
 159         * i386-linux-nat.c: Fix common/ includes.
 160         * i386-go32-tdep.c: Fix common/ includes.
 161         * i386-fbsd-tdep.c: Fix common/ includes.
 162         * i386-fbsd-nat.c: Fix common/ includes.
 163         * guile/scm-type.c: Fix common/ includes.
 164         * guile/guile.c: Fix common/ includes.
 165         * go32-nat.c: Fix common/ includes.
 166         * gnu-nat.c: Fix common/ includes.
 167         * gdbthread.h: Fix common/ includes.
 168         * gdbarch-selftests.c: Fix common/ includes.
 169         * gdb_usleep.c: Fix common/ includes.
 170         * gdb_select.h: Fix common/ includes.
 171         * gdb_bfd.c: Fix common/ includes.
 172         * gcore.c: Fix common/ includes.
 173         * fork-child.c: Fix common/ includes.
 174         * findvar.c: Fix common/ includes.
 175         * fbsd-nat.c: Fix common/ includes.
 176         * event-top.c: Fix common/ includes.
 177         * event-loop.c: Fix common/ includes.
 178         * dwarf2read.c: Fix common/ includes.
 179         * dwarf2loc.c: Fix common/ includes.
 180         * dwarf2-frame.c: Fix common/ includes.
 181         * dwarf-index-cache.c: Fix common/ includes.
 182         * dtrace-probe.c: Fix common/ includes.
 183         * disasm-selftests.c: Fix common/ includes.
 184         * defs.h: Fix common/ includes.
 185         * csky-tdep.c: Fix common/ includes.
 186         * cp-valprint.c: Fix common/ includes.
 187         * cp-support.h: Fix common/ includes.
 188         * cp-support.c: Fix common/ includes.
 189         * corelow.c: Fix common/ includes.
 190         * completer.h: Fix common/ includes.
 191         * completer.c: Fix common/ includes.
 192         * compile/compile.c: Fix common/ includes.
 193         * compile/compile-loc2c.c: Fix common/ includes.
 194         * compile/compile-cplus-types.c: Fix common/ includes.
 195         * compile/compile-cplus-symbols.c: Fix common/ includes.
 196         * command.h: Fix common/ includes.
 197         * cli/cli-dump.c: Fix common/ includes.
 198         * cli/cli-cmds.c: Fix common/ includes.
 199         * charset.c: Fix common/ includes.
 200         * build-id.c: Fix common/ includes.
 201         * btrace.h: Fix common/ includes.
 202         * btrace.c: Fix common/ includes.
 203         * breakpoint.h: Fix common/ includes.
 204         * breakpoint.c: Fix common/ includes.
 205         * ax.h:
 206         (enum agent_op): Fix common/ includes.
 207         * ax-general.c (struct aop_map): Fix common/ includes.
 208         * ax-gdb.c: Fix common/ includes.
 209         * auxv.c: Fix common/ includes.
 210         * auto-load.c: Fix common/ includes.
 211         * arm-tdep.c: Fix common/ includes.
 212         * arch/riscv.c: Fix common/ includes.
 213         * arch/ppc-linux-common.c: Fix common/ includes.
 214         * arch/i386.c: Fix common/ includes.
 215         * arch/arm.c: Fix common/ includes.
 216         * arch/arm-linux.c: Fix common/ includes.
 217         * arch/arm-get-next-pcs.c: Fix common/ includes.
 218         * arch/amd64.c: Fix common/ includes.
 219         * arch/aarch64.c: Fix common/ includes.
 220         * arch/aarch64-insn.c: Fix common/ includes.
 221         * arch-utils.c: Fix common/ includes.
 222         * amd64-windows-tdep.c: Fix common/ includes.
 223         * amd64-tdep.c: Fix common/ includes.
 224         * amd64-sol2-tdep.c: Fix common/ includes.
 225         * amd64-obsd-tdep.c: Fix common/ includes.
 226         * amd64-nbsd-tdep.c: Fix common/ includes.
 227         * amd64-linux-tdep.c: Fix common/ includes.
 228         * amd64-linux-nat.c: Fix common/ includes.
 229         * amd64-fbsd-tdep.c: Fix common/ includes.
 230         * amd64-fbsd-nat.c: Fix common/ includes.
 231         * amd64-dicos-tdep.c: Fix common/ includes.
 232         * amd64-darwin-tdep.c: Fix common/ includes.
 233         * agent.c: Fix common/ includes.
 234         * ada-lang.h: Fix common/ includes.
 235         * ada-lang.c: Fix common/ includes.
 236         * aarch64-tdep.c: Fix common/ includes.
 237
 238 2019-01-25  Tom Tromey  <tom@tromey.com>
 239
 240         * common/create-version.sh: Use common/version.h.
 241
 242 2019-01-24  Pedro Alves  <palves@redhat.com>
 243
 244         * infrun.c (signal_stop, signal_print, signal_program)
 245         (signal_catch, signal_pass): Now arrays instead of pointers.
 246         (update_signals_program_target, do_target_resume)
 247         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 248         * linux-nat.c (linux_nat_target::pass_signals)
 249         (linux_nat_target::create_inferior, linux_nat_target::attach):
 250         Adjust.
 251         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 252         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 253         * procfs.c (procfs_target::pass_signals): Adjust.
 254         * record-full.c (record_full_target::resume): Adjust.
 255         * remote.c (remote_target::pass_signals)
 256         (remote_target::program_signals): Adjust.
 257         * target-debug.h (target_debug_print_signals): Now takes a
 258         gdb::array_view as parameter.  Adjust.
 259         * target.h (target_ops) <pass_signals, program_signals>: Replace
 260         pointer and length parameters with gdb::array_view.
 261         (target_pass_signals, target_program_signals): Likewise.
 262         * target-delegates.c: Regenerate.
 263
 264 2019-01-24  Pedro Alves  <palves@redhat.com>
 265
 266         * common/forward-scope-exit.h
 267         (forward_scope_exit::forward_scope_exit): Pass arguments to
 268         m_bind_function directly, instead of creating a std::bind and
 269         copying that.
 270
 271 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 272
 273         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 274         for static members.
 275         (pass_in_v_vfp_candidate): Likewise.
 276
 277 2019-01-23  Tom Tromey  <tom@tromey.com>
 278             Pedro Alves  <palves@redhat.com>
 279
 280         * regcache.c (class regcache_invalidator): Remove.
 281         (regcache::raw_write): Use make_scope_exit.
 282
 283 2019-01-23  Tom Tromey  <tom@tromey.com>
 284
 285         * ui-out.h (class ui_out_emit_type): Update comment.
 286
 287 2019-01-23  Tom Tromey  <tom@tromey.com>
 288
 289         * infrun.c (fetch_inferior_event): Update comment.
 290
 291 2019-01-23  Tom Tromey  <tom@tromey.com>
 292             Pedro Alves  <palves@redhat.com>
 293
 294         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 295         parameter.
 296         (fetch_inferior_event): Use SCOPE_EXIT.
 297
 298
 299 2019-01-23  Tom Tromey  <tom@tromey.com>
 300             Pedro Alves  <palves@redhat.com>
 301
 302         * infrun.c (disable_thread_events): Delete.
 303         (stop_all_threads): Use SCOPE_EXIT.
 304
 305 2019-01-23  Tom Tromey  <tom@tromey.com>
 306             Pedro Alves  <palves@redhat.com>
 307
 308         * symfile.c: Include forward-scope-exit.h.
 309         (clear_symtab_users_cleanup): Replace forward declaration with
 310         a FORWARD_SCOPE_EXIT.
 311         (syms_from_objfile_1): Use the forward_scope_exit and
 312         gdb::optional instead of cleanup_function.
 313         (reread_symbols): Use the forward_scope_exit instead of
 314         cleanup_function.
 315         (clear_symtab_users_cleanup): Remove function.
 316
 317 2019-01-23  Tom Tromey  <tom@tromey.com>
 318             Pedro Alves  <palves@redhat.com>
 319
 320         * linux-nat.c: Include scope-exit.h.
 321         (cleanup_target_stop): Remove.
 322         (linux_nat_target::static_tracepoint_markers_by_strid): Use
 323         SCOPE_EXIT.
 324
 325 2019-01-23  Tom Tromey  <tom@tromey.com>
 326             Pedro Alves  <palves@redhat.com>
 327
 328         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
 329         (call_function_by_hand_dummy): Use SCOPE_EXIT.
 330
 331 2019-01-23  Tom Tromey  <tom@tromey.com>
 332             Andrew Burgess  <andrew.burgess@embecosm.com>
 333             Pedro Alves  <palves@redhat.com>
 334
 335         * infrun.c (fetch_inferior_event): Use scope_exit.
 336         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
 337         * top.c (execute_command): Use scope_exit.
 338         * breakpoint.c (bpstat_do_actions): Use scope_exit.
 339         * utils.c (do_bpstat_clear_actions_cleanup)
 340         (make_bpstat_clear_actions_cleanup): Remove.
 341
 342 2019-01-23  Tom Tromey  <tom@tromey.com>
 343             Pedro Alves  <palves@redhat.com>
 344
 345         * infrun.c: Include "common/scope-exit.h"
 346         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
 347         (wait_for_inferior): Use SCOPE_EXIT.
 348         (fetch_inferior_event): Use scope_exit.
 349
 350 2019-01-23  Tom Tromey  <tom@tromey.com>
 351             Pedro Alves  <palves@redhat.com>
 352
 353         * breakpoint.c (create_breakpoint): Remove cleanup.
 354
 355 2019-01-23  Tom Tromey  <tom@tromey.com>
 356             Andrew Burgess  <andrew.burgess@embecosm.com>
 357             Pedro Alves  <palves@redhat.com>
 358
 359 2019-01-23  Pedro Alves  <palves@redhat.com>
 360
 361         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
 362
 363 2019-01-23  Pedro Alves  <palves@redhat.com>
 364             Andrew Burgess  <andrew.burgess@embecosm.com>
 365
 366         * gdbthread.h: Include "common/forward-scope-exit.h".
 367         (scoped_finish_thread_state): Redefine custom class in terms of
 368         forward_scope_exit.
 369
 370 2019-01-23  Pedro Alves  <palves@redhat.com>
 371             Andrew Burgess  <andrew.burgess@embecosm.com>
 372
 373         * common/forward-scope-exit.h: New file.
 374
 375 2019-01-23  Pedro Alves  <palves@redhat.com>
 376             Andrew Burgess  <andrew.burgess@embecosm.com>
 377             Tom Tromey  <tom@tromey.com>
 378
 379         * common/scope-exit.h: New file.
 380
 381 2019-01-23  Pedro Alves  <palves@redhat.com>
 382
 383         * common/preprocessor.h (ESC): Rename to ...
 384         (ESC_PARENS): ... this.
 385         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
 386         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
 387
 388 2019-01-23  Tom Tromey  <tom@tromey.com>
 389
 390         * language.h (class scoped_switch_to_sym_language_if_auto):
 391         Initialize m_lang in both cases.
 392
 393 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
 394
 395         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
 396         with XCNEW.
 397
 398 2019-01-22  Tom Tromey  <tom@tromey.com>
 399
 400         * corelow.c: Do not include sys/file.h.
 401
 402 2019-01-22  Tom Tromey  <tom@tromey.com>
 403
 404         * tui/tui-wingeneral.h: Include gdb_curses.h.
 405
 406 2019-01-22  Tom Tromey  <tom@tromey.com>
 407
 408         * source-cache.h (class source_cache) <get_source_lines,
 409         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
 410
 411 2019-01-22  Tom Tromey  <tom@tromey.com>
 412
 413         * remote-fileio.h (struct remote_target): Declare.
 414
 415 2019-01-22  Tom Tromey  <tom@tromey.com>
 416
 417         * python/py-arch.c: Do not include py-ref.h.
 418         * python/py-bpevent.c: Do not include py-ref.h.
 419         * python/py-cmd.c: Do not include py-ref.h.
 420         * python/py-continueevent.c: Do not include py-ref.h.
 421         * python/py-event.h: Do not include py-ref.h.
 422         * python/py-evtregistry.c: Do not include py-ref.h.
 423         * python/py-finishbreakpoint.c: Do not include py-ref.h.
 424         * python/py-frame.c: Do not include py-ref.h.
 425         * python/py-framefilter.c: Do not include py-ref.h.
 426         * python/py-function.c: Do not include py-ref.h.
 427         * python/py-infevents.c: Do not include py-ref.h.
 428         * python/py-linetable.c: Do not include py-ref.h.
 429         * python/py-objfile.c: Do not include py-ref.h.
 430         * python/py-param.c: Do not include py-ref.h.
 431         * python/py-prettyprint.c: Do not include py-ref.h.
 432         * python/py-progspace.c: Do not include py-ref.h.
 433         * python/py-symbol.c: Do not include py-ref.h.
 434         * python/py-symtab.c: Do not include py-ref.h.
 435         * python/py-type.c: Do not include py-ref.h.
 436         * python/py-unwind.c: Do not include py-ref.h.
 437         * python/py-utils.c: Do not include py-ref.h.
 438         * python/py-value.c: Do not include py-ref.h.
 439         * python/py-varobj.c: Do not include py-ref.h.
 440         * python/py-xmethods.c: Do not include py-ref.h.
 441         * python/python.c: Do not include py-ref.h.
 442         * varobj.c: Do not include py-ref.h.
 443
 444 2019-01-22  Tom Tromey  <tom@tromey.com>
 445
 446         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
 447         keyword for bcache.
 448
 449 2019-01-22  Tom Tromey  <tom@tromey.com>
 450
 451         * compile/compile-cplus-types.c: Remove a comment by #include.
 452
 453 2019-01-22  Tom Tromey  <tom@tromey.com>
 454
 455         * compile/gcc-c-plugin.h: Include compile-internal.h.
 456
 457 2019-01-22  Tom Tromey  <tom@tromey.com>
 458
 459         * stabsread.c (EXTERN): Do not define.
 460         (symnum, next_symbol_text_func, processing_gcc_compilation)
 461         (within_function, global_sym_chain, global_stabs)
 462         (previous_stab_code, this_object_header_files)
 463         (n_this_object_header_files)
 464         (n_allocated_this_object_header_files): Define.
 465         * stabsread.h (EXTERN): Never define.  Use "extern".
 466
 467 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 468
 469         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
 470         history_value.
 471
 472 2019-01-21  Tom Tromey  <tom@tromey.com>
 473
 474         * ui-out.c: Fix includes.
 475         * tui/tui-source.c: Fix includes.
 476         * target.c: Fix includes.
 477         * remote.c: Fix includes.
 478         * regcache.c: Fix includes.
 479         * python/py-block.c: Fix includes.
 480         * printcmd.c: Fix includes.
 481         * or1k-tdep.c: Fix includes.
 482         * mi/mi-main.c: Fix includes.
 483         * m32r-tdep.c: Fix includes.
 484         * csky-tdep.c: Fix includes.
 485         * compile/compile-cplus-types.c: Fix includes.
 486         * cli/cli-interp.c: Fix includes.
 487
 488 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
 489
 490         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 491         for padding.
 492
 493 2019-01-16  Tom Tromey  <tom@tromey.com>
 494
 495         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
 496         earlier.
 497         (struct objfile) <msymbols_range>: Move from top level.
 498         <msymbols>: New method.
 499         (class objfile_msymbols): Remove.
 500         * symtab.c (default_collect_symbol_completion_matches_break_on):
 501         Update.
 502         * symmisc.c (dump_msymbols): Update.
 503         * stabsread.c (scan_file_globals): Update.
 504         * objc-lang.c (info_selectors_command, info_classes_command)
 505         (find_methods): Update.
 506         * minsyms.c (find_solib_trampoline_target): Update.
 507         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 508         * coffread.c (coff_symfile_read): Update.
 509         * ada-lang.c (ada_lookup_simple_minsym)
 510         (ada_collect_symbol_completion_matches): Update.
 511
 512 2019-01-16  Tom Tromey  <tom@tromey.com>
 513
 514         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
 515         type.  Remove no-argument constructor.
 516         <iterator::operator++>: Simplify.
 517         <begin>: Update.
 518         <end>: Use minimal_symbol_count.
 519
 520 2019-01-16  Tom Tromey  <tom@tromey.com>
 521
 522         * objfiles.h (struct objfile) <psymtabs>: New method.
 523         (class objfile_psymtabs): Remove.
 524         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
 525         typedef.
 526         <range>: New method.
 527         (require_partial_symbols): Change return type.
 528         * psymtab.c (require_partial_symbols)
 529         (psym_expand_symtabs_matching): Update.
 530         * mdebugread.c (parse_partial_symbols): Update.
 531         * dbxread.c (dbx_end_psymtab): Update.
 532
 533 2019-01-15  Tom Tromey  <tom@tromey.com>
 534
 535         * symtab.c (lookup_objfile_from_block)
 536         (lookup_symbol_in_objfile_symtabs)
 537         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
 538         (find_line_symtab, info_sources_command)
 539         (default_collect_symbol_completion_matches_break_on)
 540         (make_source_files_completion_list): Update.
 541         * symmisc.c (print_objfile_statistics, dump_objfile)
 542         (maintenance_print_symbols, maintenance_info_symtabs)
 543         (maintenance_check_symtabs, maintenance_info_line_tables):
 544         Update.
 545         * source.c (select_source_symtab)
 546         (forget_cached_source_info_for_objfile): Update.
 547         * objfiles.h (class objfile_compunits): Remove.
 548         (struct objfile) <compunits_range>: New typedef.
 549         (compunits): New method.
 550         * objfiles.c (objfile_relocate1): Update.
 551         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 552         * maint.c (count_symtabs_and_blocks): Update.
 553         * linespec.c (iterate_over_all_matching_symtabs): Update.
 554         * cp-support.c (add_symbol_overload_list_qualified): Update.
 555         * coffread.c (coff_symtab_read): Update.
 556         * ada-lang.c (add_nonlocal_symbols)
 557         (ada_collect_symbol_completion_matches)
 558         (ada_add_global_exceptions): Update.
 559
 560 2019-01-15  Tom Tromey  <tom@tromey.com>
 561
 562         * progspace.h (program_space) <objfiles_safe_range>: New
 563         typedef.
 564         <objfiles_safe>: New method.
 565         * objfiles.h (class all_objfiles_safe): Remove.
 566         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
 567         * jit.c (jit_inferior_exit_hook): Update.
 568
 569 2019-01-17  Tom Tromey  <tom@tromey.com>
 570
 571         * progspace.h (program_space) <objfiles_range>: New typedef.
 572         <objfiles>: New method.
 573         <objfiles_head>: Rename from objfiles.
 574         (object_files): Update.
 575         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
 576         * guile/scm-pretty-print.c
 577         (ppscm_find_pretty_printer_from_objfiles): Update.
 578         * guile/scm-objfile.c (gdbscm_objfiles): Update.
 579         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
 580         Update.
 581         * python/py-progspace.c (pspy_get_objfiles): Update.
 582         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 583         Update.
 584         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 585         (objfpy_lookup_objfile_by_build_id): Update.
 586         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 587         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 588         Update.
 589         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 590         (expand_symtab_containing_pc, lookup_objfile_from_block)
 591         (lookup_static_symbol, basic_lookup_transparent_type)
 592         (find_pc_sect_compunit_symtab, find_symbol_at_address)
 593         (find_line_symtab, info_sources_command)
 594         (default_collect_symbol_completion_matches_break_on)
 595         (make_source_files_completion_list, find_main_name): Update.
 596         * symmisc.c (print_symbol_bcache_statistics)
 597         (print_objfile_statistics, maintenance_print_symbols)
 598         (maintenance_print_msymbols, maintenance_print_objfiles)
 599         (maintenance_info_symtabs, maintenance_check_symtabs)
 600         (maintenance_expand_symtabs, maintenance_info_line_tables):
 601         Update.
 602         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
 603         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
 604         (map_overlay_command, unmap_overlay_command)
 605         (simple_overlay_update, expand_symtabs_matching)
 606         (map_symbol_filenames): Update.
 607         * symfile-debug.c (set_debug_symfile): Update.
 608         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
 609         Update.
 610         * source.c (select_source_symtab, forget_cached_source_info):
 611         Update.
 612         * solib.c (solib_read_symbols): Update.
 613         * solib-spu.c (append_ocl_sos): Update.
 614         * psymtab.c (maintenance_print_psymbols)
 615         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
 616         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
 617         * printcmd.c (info_symbol_command): Update.
 618         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
 619         Update.
 620         * objfiles.h (class all_objfiles): Remove.
 621         * objfiles.c (have_partial_symbols, have_full_symbols)
 622         (have_minimal_symbols, qsort_cmp, update_section_map)
 623         (shared_objfile_contains_address_p)
 624         (default_iterate_over_objfiles_in_search_order): Update.
 625         * objc-lang.c (info_selectors_command, info_classes_command)
 626         (find_methods): Update.
 627         * minsyms.c (find_solib_trampoline_target): Update.
 628         * maint.c (maintenance_info_sections)
 629         (maintenance_translate_address, count_symtabs_and_blocks):
 630         Update.
 631         * main.c (captured_main_1): Update.
 632         * linux-thread-db.c (try_thread_db_load_from_pdir)
 633         (has_libpthread): Update.
 634         * linespec.c (iterate_over_all_matching_symtabs)
 635         (search_minsyms_for_name): Update.
 636         * jit.c (jit_find_objf_with_entry_addr): Update.
 637         * hppa-tdep.c (find_unwind_entry)
 638         (hppa_lookup_stub_minimal_symbol): Update.
 639         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
 640         Update.
 641         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 642         (elf_gnu_ifunc_resolve_by_got): Update.
 643         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
 644         * dwarf-index-write.c (save_gdb_index_command): Update.
 645         * cp-support.c (add_symbol_overload_list_qualified): Update.
 646         * breakpoint.c (create_overlay_event_breakpoint)
 647         (create_longjmp_master_breakpoint)
 648         (create_std_terminate_master_breakpoint)
 649         (create_exception_master_breakpoint): Update.
 650         * blockframe.c (find_pc_partial_function): Update.
 651         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
 652         (ada_collect_symbol_completion_matches)
 653         (ada_add_global_exceptions): Update.
 654
 655 2019-01-17  Tom Tromey  <tom@tromey.com>
 656
 657         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
 658         declare VEC.
 659         (solib_target_parse_libraries): Change return type.
 660         (library_list_start_segment, library_list_start_section)
 661         (library_list_end_library, library_list_start_library); Update.
 662         (solib_target_free_library_list): Remove.
 663         (solib_target_parse_libraries): Remove cleanup.  Change return
 664         type.
 665         (solib_target_current_sos): Update.
 666
 667 2019-01-17  Tom Tromey  <tromey@bapiya>
 668
 669         * valprint.c: Replace "the the" with "the".
 670         * symtab.c: Replace "the the" with "the".
 671         * solib.c: Replace "the the" with "the".
 672         * solib-dsbt.c: Replace "the the" with "the".
 673         * linespec.c: Replace "the the" with "the".
 674         * dwarf2loc.h: Replace "the the" with "the".
 675         * amd64-windows-tdep.c: Replace "the the" with "the".
 676         * aarch64-tdep.c: Replace "the the" with "the".
 677
 678 2019-01-16  Keith Seitz  <keiths@redhat.com>
 679
 680         PR gdb/23773
 681         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
 682         <builder>: Rename to ..
 683         <m_builder>: ... this and make private.
 684         (dwarf2_cu::get_builder): New method.  Change all users of
 685         `builder' to use this method.
 686         (dwarf2_start_symtab): Move to ...
 687         (dwarf2_cu::start_symtab): ... here.  Update all callers
 688         (setup_type_unit_groups): Move to ...
 689         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
 690         callers.
 691         (dwarf2_cu::reset_builder): New method.
 692         (process_full_compunit, process_full_type_unit): Use
 693         dwarf2_cu::reset_builder.
 694         (follow_die_offset): Record the ancestor CU if it is different
 695         from the followed DIE's CU.
 696         (follow_die_sig_1): Likewise.
 697
 698 2019-01-15  Tom Tromey  <tom@tromey.com>
 699
 700         * remote.c (class remote_state) <buf>: Now a char_vector.
 701         <buf_size>: Remove.
 702         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
 703         parameter.
 704         (remote_target::getpkt_or_notif_sane_1)
 705         (remote_target::getpkt_sane)
 706         (remote_target::getpkt_or_notif_sane): Likewise.
 707         (class remote_target) <putpkt>: New overload.
 708         (remote_target::read_frame): Change type of "buf_p".  Remove
 709         sizeof_p parameter.
 710         (packet_ok): New overload.
 711         (packet_check_result): New overload.
 712         Update all uses.
 713
 714 2019-01-14  Tom Tromey  <tom@tromey.com>
 715
 716         * remote-notif.c (handle_notification, remote_notif_ack)
 717         (remote_notif_parse): Make "buf" const.
 718         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
 719         const.
 720         (remote_notif_parse, remote_notif_ack, handle_notification):
 721         Likewise.
 722         * remote.c (remote_notif_stop_parse): Make "buf" const.
 723         (remote_target::remote_parse_stop_reply): Make "buf" const.
 724         (remote_notif_stop_ack): Make "buf" const.
 725
 726 2019-01-14  Tom Tromey  <tom@tromey.com>
 727
 728         * remote.c (remote_console_output): Make parameter const.
 729
 730 2019-01-14  Tom Tromey  <tom@tromey.com>
 731
 732         * target-debug.h (target_debug_print_signals): Constify.
 733         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
 734         * procfs.c (procfs_target::pass_signals): Update.
 735         * linux-nat.c (linux_nat_target::pass_signals): Update.
 736         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
 737         * target-delegates.c: Rebuild.
 738         * remote.c (remote_target::program_signals): Update.
 739         (remote_target::pass_signals): Update.
 740         * target.c (target_pass_signals): Constify argument.
 741         (target_program_signals): Likewise.
 742         * target.h (struct target_ops) <pass_signals, program_signals>:
 743         Constify argument.
 744         (target_pass_signals, target_program_signals): Constify argument.
 745
 746 2019-01-14  Tom Tromey  <tom@tromey.com>
 747
 748         PR tui/28819:
 749         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
 750
 751 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 752
 753         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
 754         field.
 755         * rs6000-tdep.c: Include reggroups.h.
 756         (IS_V_ALIAS_PSEUDOREG): Define.
 757         (rs6000_register_name): Return names for the "vX" aliases.
 758         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
 759         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
 760         aliases.  Call default_register_reggroup_p for all other
 761         pseudo-registers.
 762         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
 763         New functions.
 764         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
 765         Handle "vX" aliases.
 766         (v_alias_pseudo_register_collect): New function.
 767         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
 768         (rs6000_gdbarch_init): Initialize "vX" aliases as
 769         pseudo-registers.  Restore registration of
 770         rs6000_pseudo_register_reggroup_p with
 771         set_tdesc_pseudo_register_reggroup_p.
 772
 773 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
 774
 775         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
 776         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
 777         set_gdbarch_num_pseudo_regs.
 778
 779 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 780
 781         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
 782         Remove arg prefixname, add do_set and do_show.
 783         Add member functions set_list and show_list.
 784         * cli/cli-style.c (class cli_style_option): Update accordingly.
 785         (style_set_list): Move to file scope.
 786         (style_show_list): Likewise.
 787         (set_style): Call help_list.
 788         (show_style): Call cmd_show_list.
 789         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
 790         Update to use the new macro.
 791
 792 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
 793
 794         * ada-lang.c (_initialize_ada_language): Expand the help text
 795         for the "catch exception" command.
 796
 797 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 798
 799         * symtab.c (matching_obj_sections): Initialize obj,
 800         declare it closer to its usage.
 801
 802 2019-01-10  Tom Tromey  <tom@tromey.com>
 803
 804         * thread-iter.h (inf_threads_iterator): Use next_iterator.
 805         (basic_inf_threads_range): Remove.
 806         (inf_threads_range, inf_non_exited_threads_range)
 807         (safe_inf_threads_range): Use next_adapter.
 808
 809 2019-01-10  Keith Seitz  <keiths@redhat.com>
 810
 811         PR gdb/23712
 812         PR symtab/23010
 813         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
 814         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
 815
 816 2019-01-10  Keith Seitz  <keiths@redhat.com>
 817
 818         PR gdb/23712
 819         PR symtab/23010
 820         * dictionary.c (pending_to_vector): Remove.
 821         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 822         Remove _1 suffix, replacing functions of the same name.  Update
 823         all callers.
 824         (dict_create_hashed, dict_create_hashed_expandable)
 825         (dict_create_linear, dict_create_linear_expandable, dict_free)
 826         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
 827         Make functions static.
 828
 829 2019-01-10  Keith Seitz  <keiths@redhat.com>
 830
 831         PR gdb/23712
 832         PR symtab/23010
 833         * dictionary.h (struct dictionary): Replace declaration with
 834         multidictionary.
 835         (dict_create_hashed, dict_create_hashed_expandable)
 836         (dict_create_linear, dict_create_linear_expandable)
 837         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
 838         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
 839         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
 840         taking multidictionary argument.
 841         [ALL_DICT_SYMBOLS]: Update for multidictionary.
 842         * block.h (struct block) <dict>: Change to multidictionary
 843         and rename `multidict'.
 844         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
 845         symmisc.c: Update all dictionary references to multidictionary.
 846
 847 2019-01-10  Keith Seitz  <keiths@redhat.com>
 848
 849         PR gdb/23712
 850         PR symtab/23010
 851         * dictionary.c: Include unordered_map.
 852         (pending_to_vector): New function.
 853         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 854         Rewrite the non-"_1" functions to take vector instead
 855         of linked list.
 856         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
 857         "new" _1 versions of the same name.
 858         (multidictionary): Define.
 859         (std::hash<enum language): New definition.
 860         (collate_pending_symbols_by_language, mdict_create_hashed)
 861         (mdict_create_hashed_expandable, mdict_create_linear)
 862         (mdict_create_linear_expandable, mdict_free)
 863         (find_language_dictionary, create_new_language_dictionary)
 864         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
 865         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
 866         (mdict_size, mdict_empty): New functions.
 867         * dictionary.h (mdict_iterator): Define.
 868
 869 2019-01-10  Pedro Alves  <palves@redhat.com>
 870
 871         * breakpoint.c (read_uploaded_action)
 872         (create_tracepoint_from_upload): Adjust to use
 873         gdb::unique_xmalloc_ptr.
 874         * ctf.c (ctf_write_uploaded_tp):
 875         (SET_ARRAY_FIELD): Use emplace_back.
 876         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
 877         * tracefile-tfile.c (tfile_write_uploaded_tp):
 878         * tracepoint.c (parse_tracepoint_definition): Adjust to use
 879         gdb::unique_xmalloc_ptr.
 880         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
 881         at_string, cond_string, cmd_strings>: Replace char pointers
 882         with gdb::unique_xmalloc_ptr.
 883
 884 2019-01-10  Pedro Alves  <palves@redhat.com>
 885
 886         * solib-target.c (library_list_start_library): Don't xstrdup name.
 887
 888 2019-01-10  Pedro Alves  <palves@redhat.com>
 889
 890         * mdebugread.c (parse_partial_symbols): Use
 891         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
 892
 893 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 894
 895         * linux-fork.c (scoped_switch_fork_info)
 896         <~scoped_switch_fork_info>: Fix incorrect variable name.
 897
 898 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 899
 900         * linux-fork.c (scoped_switch_fork_info)
 901         <scoped_switch_fork_info>: Make explicit.
 902         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
 903
 904 2019-01-10  Tom Tromey  <tom@tromey.com>
 905
 906         * objfiles.h (objfile::reset_psymtabs): Update.
 907         * objfiles.c (objfile::objfile): Update.
 908         * psymtab.h (psymtab_storage::obstack): Update.
 909         (psymtab_storage::m_obstack): Use gdb::optional.
 910         (class psymtab_storage): Update comment.  Remove objfile
 911         parameter.
 912         * psymtab.c (psymtab_storage::psymtab_storage): Update.
 913
 914 2019-01-10  Tom Tromey  <tom@tromey.com>
 915
 916         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
 917         <free_psymtabs>: Now private.
 918         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
 919         (allocate_psymtab): Use new method.
 920
 921 2019-01-10  Tom Tromey  <tom@tromey.com>
 922
 923         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
 924         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
 925         * mdebugread.c (parse_partial_symbols): Use
 926         allocate_dependencies.
 927         * dwarf2read.c (dwarf2_create_include_psymtab): Use
 928         allocate_dependencies.
 929         (process_psymtab_comp_unit_reader)
 930         (build_type_psymtab_dependencies): Likewise.
 931         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
 932
 933 2019-01-10  Tom Tromey  <tom@tromey.com>
 934
 935         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
 936         PSYMBOL_SET_LANGUAGE.
 937         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
 938
 939 2019-01-10  Tom Tromey  <tom@tromey.com>
 940
 941         * psymtab.h (psymtab_storage::obstack): New method.
 942         <m_obstack>: Rename from obstack; now private.
 943         * psymtab.c (psymtab_storage): Update.
 944         * dwarf2read.c (create_addrmap_from_index)
 945         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
 946         Update.
 947
 948 2019-01-10  Tom Tromey  <tom@tromey.com>
 949
 950         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
 951         * objfiles.h (objfile::reset_psymtabs): New method.
 952
 953 2019-01-10  Tom Tromey  <tom@tromey.com>
 954
 955         * symmisc.c (print_symbol_bcache_statistics): Update.
 956         (print_objfile_statistics): Update.
 957         * symfile.c (reread_symbols): Update.
 958         * psymtab.h (class psymtab_storage): New.
 959         * psymtab.c (psymtab_storage): New constructor.
 960         (~psymtab_storage): New destructor.
 961         (require_partial_symbols): Update.
 962         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
 963         (find_pc_sect_psymtab, find_pc_sect_psymbol)
 964         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
 965         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
 966         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
 967         (start_psymtab_common, end_psymtab_common)
 968         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
 969         (allocate_psymtab): Update.
 970         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
 971         Update.
 972         (dump_psymtab_addrmap, maintenance_print_psymbols)
 973         (maintenance_check_psymtabs): Update.
 974         (class objfile_psymtabs): Move to objfiles.h.
 975         * psympriv.h (discard_psymtab): Now inline.
 976         (psymtab_discarder::psymtab_discarder): Update.
 977         (psymtab_discarder::~psymtab_discarder): Update.
 978         (ALL_OBJFILE_PSYMTABS): Rewrite.
 979         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
 980         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
 981         Remove fields.
 982         <partial_symtabs>: New field.
 983         (class objfile_psymtabs): Move from psymtab.h.  Update.
 984         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
 985         psymbol_cache.
 986         (objfile::~objfile): Don't destroy psymbol_cache.
 987         * mdebugread.c (parse_partial_symbols): Update.
 988         * dwarf2read.c (create_addrmap_from_index)
 989         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 990         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
 991         (add_partial_subprogram, dwarf2_ranges_read): Update.
 992         * dwarf-index-write.c (write_address_map)
 993         (write_one_signatured_type, recursively_write_psymbols)
 994         (class debug_names, class debug_names, write_psymtabs_to_index):
 995         Update.
 996
 997 2019-01-10  Tom Tromey  <tom@tromey.com>
 998
 999         * symtab.h (SYMBOL_SET_NAMES): Update.
1000         (symbol_set_names): Update.
1001         (MSYMBOL_SET_NAMES): Update.
1002         * symtab.c (symbol_set_names): Change argument to be an
1003         objfile_per_bfd_storage.
1004         * psymtab.c (add_psymbol_to_bcache): Update.
1005         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1006
1007 2019-01-10  Tom Tromey  <tom@tromey.com>
1008
1009         * symtab.c (create_demangled_names_hash): Change argument to be an
1010         objfile_per_bfd_storage.
1011         (symbol_set_names): Update.
1012
1013 2019-01-10  Tom Tromey  <tom@tromey.com>
1014
1015         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1016         init_psymbol_list.
1017         * psymtab.c (init_psymbol_list): Do nothing if already called.
1018         * psympriv.h (init_psymbol_list): Add comment.
1019         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1020         init_psymbol_list.
1021         * dbxread.c (dbx_symfile_read): Unconditionally call
1022         init_psymbol_list.
1023
1024 2019-01-10  Tom Tromey  <tom@tromey.com>
1025
1026         * xcoffread.c (scan_xcoff_symtab): Update.
1027         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1028         "where".
1029         * mdebugread.c (parse_partial_symbols)
1030         (handle_psymbol_enumerators): Update.
1031         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1032         * dbxread.c (read_dbx_symtab): Update.
1033         * psympriv.h (psymbol_placement): New enum.
1034         (add_psymbol_to_list): Update.
1035
1036 2019-01-10  Tom Tromey  <tom@tromey.com>
1037
1038         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1039         static_psymbols parameters.
1040         (scan_xcoff_symtab): Update.
1041         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1042         static_psymbols parameters.
1043         * psympriv.h (start_psymtab_common): Update.
1044         * mdebugread.c (parse_partial_symbols): Update.
1045         * dwarf2read.c (create_partial_symtab): Update.
1046         * dbxread.c (read_dbx_symtab): Update.
1047         (start_psymtab): Remove global_psymbols and static_psymbols
1048         parameters.
1049
1050 2019-01-10  Tom Tromey  <tom@tromey.com>
1051
1052         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1053         * psymtab.c (allocate_psymtab): Add comment.
1054         * psympriv.h (allocate_psymtab): Add comment.
1055         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1056         initializations.
1057         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1058
1059 2019-01-10  Tom Tromey  <tom@tromey.com>
1060
1061         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1062         Don't declare.
1063         * mipsread.c: Include mdebugread.h.
1064         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1065         Declare.
1066         * elfread.c: Include mdebugread.h.
1067
1068 2019-01-09  Tom Tromey  <tom@tromey.com>
1069
1070         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1071         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1072         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1073         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1074         (psym_lookup_symbol, psym_find_last_source_symtab)
1075         (psym_forget_cached_source_info, psym_print_stats)
1076         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1077         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1078         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1079         (psym_find_compunit_symtab_by_address)
1080         (maintenance_print_psymbols, maintenance_info_psymtabs)
1081         (maintenance_check_psymtabs): Use ranged for.
1082         * psymtab.h (class objfile_psymtabs): New.
1083         (require_partial_symbols): Return objfile_psymtabs.
1084         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1085
1086 2019-01-09  Tom Tromey  <tom@tromey.com>
1087
1088         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1089         (find_pc_mapped_section, list_overlays_command)
1090         (map_overlay_command, unmap_overlay_command)
1091         (simple_overlay_update): Use all_objfiles.
1092         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1093         * printcmd.c (info_symbol_command): Use all_objfiles.
1094         * objfiles.h (ALL_OBJSECTIONS): Remove.
1095         * maint.c (maintenance_translate_address): Use all_objfiles.
1096         * gcore.c (gcore_create_callback): Use all_objfiles.
1097         (objfile_find_memory_regions): Likewise.
1098
1099 2019-01-09  Tom Tromey  <tom@tromey.com>
1100
1101         * symtab.c (find_line_symtab, info_sources_command)
1102         (make_source_files_completion_list): Use objfile_compunits.
1103         * source.c (select_source_symtab): Use objfile_compunits.
1104         * objfiles.h (struct objfile): Update comment.
1105         (ALL_OBJFILES): Remove.
1106         (ALL_FILETABS): Remove.
1107         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1108         objfile_compunits.
1109
1110 2019-01-09  Tom Tromey  <tom@tromey.com>
1111
1112         * symmisc.c (print_objfile_statistics, dump_objfile)
1113         (maintenance_print_symbols): Use compunit_filetabs.
1114         * source.c (forget_cached_source_info_for_objfile): Use
1115         compunit_filetabs.
1116         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1117         (ALL_FILETABS): Use compunit_filetabs.
1118         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1119         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1120
1121 2019-01-09  Tom Tromey  <tom@tromey.com>
1122
1123         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1124         (compunit_filetabs): New.
1125         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1126         compunit_filetabs.
1127         (info_sources_command, make_source_files_completion_list): Remove
1128         declaration.
1129         * symmisc.c (print_objfile_statistics, dump_objfile)
1130         (maintenance_print_symbols): Remove declaration.
1131         (maintenance_info_symtabs): Use compunit_filetabs.
1132         (maintenance_info_line_tables): Likewise.
1133         * source.c (select_source_symtab): Change local variable name.
1134         (forget_cached_source_info_for_objfile): Remove declaration.
1135         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1136         * objfiles.c (objfile_relocate1): Remove declaration.
1137         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1138         declaration.
1139         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1140         * coffread.c (coff_symtab_read): Remove declaration.
1141         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1142         compunit_filetabs.
1143
1144 2019-01-09  Tom Tromey  <tom@tromey.com>
1145
1146         * symtab.c (lookup_objfile_from_block)
1147         (find_pc_sect_compunit_symtab, search_symbols)
1148         (default_collect_symbol_completion_matches_break_on): Use
1149         objfile_compunits.
1150         * objfiles.h (ALL_COMPUNITS): Remove.
1151         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1152         * cp-support.c (add_symbol_overload_list_qualified): Use
1153         objfile_compunits.
1154         * ada-lang.c (ada_collect_symbol_completion_matches)
1155         (ada_add_global_exceptions): Use objfile_compunits.
1156
1157 2019-01-09  Tom Tromey  <tom@tromey.com>
1158
1159         * source.c (select_source_symtab)
1160         (forget_cached_source_info_for_objfile): Remove declaration.
1161         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1162         declaration.
1163         * maint.c (count_symtabs_and_blocks): Remove declaration.
1164         * cp-support.c (add_symbol_overload_list_qualified): Remove
1165         declaration.
1166         * coffread.c (coff_symtab_read): Remove declaration.
1167         * symtab.c (lookup_symbol_in_objfile_symtabs)
1168         (basic_lookup_transparent_type_1): Use objfile_compunits.
1169         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1170         (info_sources_command, search_symbols)
1171         (default_collect_symbol_completion_matches_break_on)
1172         (make_source_files_completion_list): Remove declaration.
1173         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1174         (ada_collect_symbol_completion_matches)
1175         (ada_add_global_exceptions): Remove declaration.
1176         * linespec.c (iterate_over_all_matching_symtabs): Use
1177         objfile_compunits.
1178         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1179         (class objfile_compunits): New.
1180         (ALL_COMPUNITS): Use objfile_compunits.
1181         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1182         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1183         objfile_compunits.
1184         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1185
1186 2019-01-09  Tom Tromey  <tom@tromey.com>
1187
1188         * symtab.c (search_symbols)
1189         (default_collect_symbol_completion_matches_break_on): Use
1190         objfile_msymbols.
1191         * ada-lang.c (ada_lookup_simple_minsym)
1192         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1193         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1194         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1195         objfile_msymbols.
1196         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1197         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1198         * objc-lang.c (find_methods): Use objfile_msymbols.
1199         (info_selectors_command, info_classes_command): Likewise.
1200         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1201         * objfiles.h (class objfile_msymbols): New.
1202         (ALL_OBJFILE_MSYMBOLS): Remove.
1203         (ALL_MSYMBOLS): Remove.
1204
1205 2019-01-09  Tom Tromey  <tom@tromey.com>
1206
1207         * common/next-iterator.h (next_adapter): Add Iterator template
1208         parameter.
1209         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1210         (class all_objfiles_safe): New.
1211         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1212         * objfiles.c (put_objfile_before): Update comment.
1213         (add_separate_debug_objfile): Likewise.
1214         (free_all_objfiles): Use all_objfiles_safe.
1215         (objfile_purge_solibs): Likewise.
1216
1217 2019-01-09  Tom Tromey  <tom@tromey.com>
1218
1219         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1220         (expand_symtab_containing_pc, lookup_static_symbol)
1221         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1222         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1223         all_objfiles.
1224         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1225         * breakpoint.c (create_overlay_event_breakpoint)
1226         (create_longjmp_master_breakpoint)
1227         (create_std_terminate_master_breakpoint)
1228         (create_exception_master_breakpoint): Use all_objfiles.
1229         * linux-thread-db.c (try_thread_db_load_from_pdir)
1230         (has_libpthread): Use all_objfiles.
1231         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1232         * linespec.c (iterate_over_all_matching_symtabs)
1233         (search_minsyms_for_name): Use all_objfiles.
1234         * maint.c (maintenance_info_sections): Use all_objfiles.
1235         * main.c (captured_main_1): Use all_objfiles.
1236         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1237         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1238         * guile/scm-pretty-print.c
1239         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1240         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1241         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1242         (maintenance_print_msymbols): Use all_objfiles.
1243         * source.c (select_source_symtab): Use all_objfiles.
1244         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1245         * symfile.c (remove_symbol_file_command)
1246         (expand_symtabs_matching, map_symbol_filenames): Use
1247         all_objfiles.
1248         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1249         all_objfiles.
1250         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1251         * objc-lang.c (find_methods): Use all_objfiles.
1252         * objfiles.c (have_partial_symbols, have_full_symbols)
1253         (have_minimal_symbols, qsort_cmp)
1254         (default_iterate_over_objfiles_in_search_order): Use
1255         all_objfiles.
1256         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1257         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1258         (maintenance_check_psymtabs): Use all_objfiles.
1259         (ALL_PSYMTABS): Remove.
1260         * compile/compile-object-run.c (do_module_cleanup): Use
1261         all_objfiles.
1262         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1263         * cp-support.c (add_symbol_overload_list_qualified): Use
1264         all_objfiles.
1265         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1266         Use all_objfiles.
1267         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1268         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1269         all_objfiles.
1270         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1271         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1272         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1273         Uses all_objfiles.
1274         * solib.c (solib_read_symbols): Use all_objfiles
1275
1276 2019-01-09  Tom Tromey  <tom@tromey.com>
1277
1278         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1279         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1280         all_objfiles.
1281         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1282         * symmisc.c (print_symbol_bcache_statistics)
1283         (print_objfile_statistics, maintenance_print_objfiles)
1284         (maintenance_info_symtabs, maintenance_check_symtabs)
1285         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1286         all_objfiles.
1287         * source.c (forget_cached_source_info): Use all_objfiles.
1288         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1289         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1290         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1291         * objfiles.c (update_section_map): Use all_objfiles.
1292         (shared_objfile_contains_address_p): Likewise.
1293         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1294         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1295
1296 2019-01-09  Tom Tromey  <tom@tromey.com>
1297
1298         * common/next-iterator.h: New file.
1299         * objfiles.h (class all_objfiles): New.
1300         (struct objfile_iterator): New.
1301
1302 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1303
1304         * NEWS: Move the description of the changed "frame", "select-frame",
1305          and "info frame" commands to the Changed commands section.
1306
1307 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1308
1309         * gdbtypes.c (check_stub_method_group): Remove handling of old
1310         mangling schemes.
1311         * linespec.c (find_methods): Likewise.
1312         * stabsread.c (read_member_functions): Likewise.
1313         * valops.c (search_struct_method): Likewise.
1314         (value_struct_elt_for_reference): Likewise.
1315         * NEWS: Mention this change.
1316
1317 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1318
1319         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1320         print_source_lines.
1321         * source.c (print_source_lines_base): Update line number check.
1322         (print_source_lines): New function.
1323         (source_lines_range::source_lines_range): New function.
1324         * source.h (class source_lines_range): New class.
1325         (print_source_lines): New declaration.
1326
1327 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1328
1329         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1330
1331 2019-01-08  Tom Tromey  <tom@tromey.com>
1332             Simon Marchi  <simon.marchi@ericsson.com>
1333
1334         PR gdb/24060
1335         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1336         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1337         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1338         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1339         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1340         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1341
1342 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1343
1344         * source.c (select_source_symtab): Move header comment to
1345         declaration in source.h.
1346         (forget_cached_source_info_for_objfile): Likewise.
1347         (forget_cached_source_info): Likewise.
1348         (identify_source_line): Likewise.
1349         * source.h (identify_source_line): Move declaration from symtab.h
1350         and add comment from source.c
1351         (print_source_lines): Likewise.
1352         (forget_cached_source_info_for_objfile): Likewise.
1353         (forget_cached_source_info): Likewise.
1354         (select_source_symtab): Likewise.
1355         (enum print_source_lines_flag): Move definition from symtab.h.
1356         * symtab.h (identify_source_line): Move declaration to source.h.
1357         (print_source_lines): Likewise.
1358         (forget_cached_source_info_for_objfile): Likewise.
1359         (forget_cached_source_info): Likewise.
1360         (select_source_symtab): Likewise.
1361         (enum print_source_lines_flag): Move definition to source.h.
1362         * tui/tui-hooks.c: Add 'source.h' include.
1363
1364 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1365
1366         * source.c (print_source_lines_base): Handle requests to print
1367         reverse line number sequences, and guard against empty lines
1368         string.
1369
1370 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1371
1372         * source.c (print_source_lines_base): Fix skip of '\r' if next
1373         character is '\n'.
1374
1375 2019-01-06  Tom Tromey  <tom@tromey.com>
1376
1377         * c-exp.y (struct c_parse_state) <macro_original_text,
1378         expansion_obstack>: New member.
1379         (macro_original_text, expansion_obstack): Remove globals.
1380         (scan_macro_expansion, scanning_macro_expansion)
1381         (finished_macro_expansion): Update.
1382         (scan_macro_cleanup): Remove.
1383         (yylex, c_parse): Update.
1384
1385 2019-01-06  Tom Tromey  <tom@tromey.com>
1386
1387         * c-exp.y (struct c_parse_state) <strings>: New member.
1388         (operator_stoken): Update.
1389
1390 2019-01-06  Tom Tromey  <tom@tromey.com>
1391
1392         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1393         (union type_stack_elt) <typelist_val>: Now a pointer to
1394         std::vector.
1395         (type_stack_cleanup): Don't declare.
1396         (push_typelist): Update.
1397         * parse.c (pop_typelist): Return a std::vector.
1398         (push_typelist): Take a std::vector.
1399         (follow_types): Update.  Do not free args.
1400         (type_stack_cleanup): Remove.
1401         * c-exp.y (struct c_parse_state): New.
1402         (cpstate): New global.
1403         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1404         (nonempty_typelist): Update.
1405         (func_mod): Create a new vector.
1406         (c_parse): Create a c_parse_state.
1407         (check_parameter_typelist): Do not delete params.
1408         (function_method): Update.  Do not delete type_list.
1409
1410 2019-01-06  Tom Tromey  <tom@tromey.com>
1411
1412         PR gdb/28155:
1413         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1414         check_typedef.
1415         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1416         (print_return_value): Likewise.
1417
1418 2019-01-05  Tom Tromey  <tom@tromey.com>
1419
1420         * contrib/cleanup_check.py: Remove.
1421         * contrib/gcc-with-excheck: Remove.
1422         * contrib/exsummary.py: Remove.
1423         * contrib/excheck.py: Remove.
1424
1425 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1426
1427         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1428         NULL. Initialize tpprev to NULL instead of assigning it
1429         to NULL on the next statement.
1430         * windows-nat.c (windows_delete_thread): Remove check for
1431         main_thread_id before printing thread exit notifications.
1432         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1433         Remove thread ID check against main_thread_id.
1434         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1435         windows_delete_thread.
1436         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1437
1438 2019-01-04  Tom Tromey  <tom@tromey.com>
1439
1440         * compile/compile.c (_initialize_compile): Use upper case for
1441         metasyntactic variables.
1442         * symmisc.c (_initialize_symmisc): Use upper case for
1443         metasyntactic variables.
1444         * psymtab.c (_initialize_psymtab): Use upper case for
1445         metasyntactic variables.
1446         * demangle.c (demangle_command): Use upper case for metasyntactic
1447         variables.
1448         (_initialize_demangler): Likewise.
1449         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1450         variables.
1451
1452 2019-01-03  Tom Tromey  <tom@tromey.com>
1453
1454         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1455
1456 2019-01-03  Tom Tromey  <tom@tromey.com>
1457
1458         * python/py-symtab.c (salpy_str): Update.
1459         (struct salpy_sal_object) <symtab>: Now a PyObject.
1460         (salpy_dealloc): Update.
1461         (del_objfile_sal): Use gdbpy_ref.
1462
1463 2019-01-03  Tom Tromey  <tom@tromey.com>
1464
1465         * python/py-type.c (convert_field): Use new_reference.  Return
1466         gdbpy_ref.
1467         (make_fielditem): Return gdbpy_ref.
1468         (typy_fields): Update.
1469         (typy_getitem): Update.
1470         (field_name): Return gdbpy_ref.  Use new_reference.
1471         (typy_iterator_iternext): Update.
1472
1473 2019-01-03  Tom Tromey  <tom@tromey.com>
1474
1475         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1476
1477 2019-01-03  Tom Tromey  <tom@tromey.com>
1478
1479         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1480         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1481         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1482         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1483         (pspy_set_type_printers): Likewise.
1484         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1485         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1486         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1487         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1488         (objfpy_set_type_printers): Likewise.
1489
1490 2019-01-03  Tom Tromey  <tom@tromey.com>
1491
1492         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1493         (gdbpy_print_stack): Use gdbpy_err_fetch.
1494         * python/python-internal.h (class gdbpy_err_fetch): New class.
1495         (class gdbpy_enter) <m_error_type, m_error_value,
1496         m_error_traceback>: Remove.
1497         <m_error>: New member.
1498         (gdbpy_exception_to_string): Don't declare.
1499         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1500         * python/py-value.c (convert_value_from_python): Use
1501         gdbpy_err_fetch.
1502         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1503         gdbpy_exception_to_string.
1504         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1505         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1506         gdbpy_err_fetch.
1507
1508 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1509
1510         * linux-nat.c (delete_lwp_cleanup): Delete.
1511         (struct lwp_deleter): New struct.
1512         (lwp_info_up): New typedef.
1513         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1514         lwp_info_up.
1515
1516 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1517
1518         * linux-fork.c (class scoped_switch_fork_info): New class.
1519         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1520
1521 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1522
1523         * valops.c (find_overload_match): Remove use of null_cleanup, and
1524         calls to do_cleanups.
1525
1526 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1527
1528         * compile/compile-cplus-types.c
1529         (compile_cplus_instance::decl_name): Handle changes to
1530         cp_func_name.
1531         * cp-support.c (cp_func_name): Update header comment, update
1532         return type.
1533         * cp-support.h (cp_func_name): Update return type in declaration.
1534         * valops.c (find_overload_match): Move temp_func local to top
1535         level of function and change its type.  Use temp_func to hold and
1536         delete temporary string obtained from cp_func_name.
1537
1538 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1539
1540         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1541         gdb::char_vector, remove cleanup, and update uses of `msg`.
1542
1543 2019-01-03  Jim Wilson  <jimw@sifive.com>
1544
1545         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1546
1547 2019-01-02  Tom Tromey  <tom@tromey.com>
1548
1549         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1550         (tdesc_parse_xml): Remove cleanups.
1551         * target-descriptions.h (make_cleanup_free_target_description):
1552         Don't declare.
1553         (target_desc_deleter): New struct.
1554         (target_desc_up): New typedef.
1555         * target-descriptions.c (target_desc_deleter::operator()): Rename
1556         from free_target_description.
1557         (make_cleanup_free_target_description): Remove.
1558
1559 2019-01-02  Tom Tromey  <tom@tromey.com>
1560
1561         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1562         constructor, destructor.
1563         (linespec_parser): Remove typedef.
1564         (~linespec_parser): Rename from linespec_parser_delete.
1565         (linespec_lex_to_end, linespec_complete_label)
1566         (linespec_complete): Update.
1567         (decode_line_full): Remove cleanups.
1568         (decode_line_1): Update.
1569
1570 2019-01-02  Tom Tromey  <tom@tromey.com>
1571
1572         * python/python-internal.h (inferior_to_inferior_object): Change
1573         return type.
1574         * python/py-exitedevent.c (create_exited_event_object): Update.
1575         * python/py-inferior.c (inferior_to_inferior_object): Return
1576         gdbpy_ref.
1577         (python_new_inferior, python_inferior_deleted)
1578         (thread_to_thread_object, delete_thread_object)
1579         (build_inferior_list, gdbpy_selected_inferior): Update.
1580         * python/py-infthread.c (create_thread_object): Update.  Also fail
1581         if inferior_to_inferior_object fails.
1582
1583 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1584
1585         * inferior.h (class inferior) <displaced_step_state>: New field.
1586         * infrun.h (struct displaced_step_state): Move here from
1587         infrun.c.  Initialize fields, add constructor.
1588         <inf>: Remove field.
1589         <reset>: New method.
1590         * infrun.c (struct displaced_step_inferior_state): Move to
1591         infrun.h.
1592         (displaced_step_inferior_states): Remove.
1593         (get_displaced_stepping_state): Adust.
1594         (displaced_step_in_progress_any_inferior): Adjust.
1595         (displaced_step_in_progress_thread): Adjust.
1596         (displaced_step_in_progress): Adjust.
1597         (add_displaced_stepping_state): Remove.
1598         (get_displaced_step_closure_by_addr): Adjust.
1599         (remove_displaced_stepping_state): Remove.
1600         (infrun_inferior_exit): Call displaced_step_state.reset.
1601         (use_displaced_stepping): Don't check for NULL.
1602         (displaced_step_prepare_throw): Call
1603         get_displaced_stepping_state.
1604         (displaced_step_fixup): Don't check for NULL.
1605         (prepare_for_detach): Don't check for NULL.
1606
1607 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1608
1609         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
1610          in case of call that did not complete.
1611
1612 2019-01-02  Andrey Utkin  <autkin@undo.io>
1613
1614         * symfile.c (find_separate_debug_file): Fix search of debug files for
1615         remote debuggee.
1616
1617 2019-01-02  Tom Tromey  <tom@tromey.com>
1618
1619         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
1620         indentation.
1621         * python/py-frame.c (frapy_older): Remove cast.
1622         (frapy_newer): Likewise.
1623         * python/py-breakpoint.c (local_setattro): Remove cast.
1624         * python/py-arch.c (archpy_name): Remove local variable.
1625         * python/py-type.c (gdbpy_lookup_type): Remove cast.
1626
1627 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
1628
1629         * unittests/basic_string_view/element_access/char/empty.cc:
1630         Fix year range in copyright header.
1631
1632 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1633
1634         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
1635         Delete.
1636         <operator==>: Update with for removed field.
1637         <hash>: Likewise.
1638         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
1639         <isa_features>: ...this.
1640         <abi_features>: New field.
1641         (riscv_isa_flen): Update comment.
1642         (riscv_abi_xlen): New declaration.
1643         (riscv_abi_flen): New declaration.
1644         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
1645         isa_features.
1646         (riscv_abi_xlen): New function.
1647         (riscv_isa_flen): Update to get answer from isa_features.
1648         (riscv_abi_flen): New function.
1649         (riscv_has_fp_abi): Update to get answer from abi_features.
1650         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
1651         xlen and flen.
1652         (riscv_call_info) <xlen, flen>: Update comment.
1653         (riscv_call_arg_struct): Remove invalid assertions
1654         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
1655         is removed.
1656         (riscv_gdbarch_init): Gather isa features and abi features
1657         separately, ensure both match on the gdbarch when reusing an old
1658         gdbarch.  Relax an error check to allow 32-bit abi float to run on
1659         a target with 64-bit float hardware.
1660
1661 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1662
1663         * source.c (search_command_helper): Stop reverse search
1664         when line 1 has been searched.
1665
1666 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1667
1668         * record-full.c (record_full_base_target::close): Rewrite
1669         record_full_core_buf_list free logic.
1670
1671 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1672
1673         * break-catch-syscall.c (print_one_catch_syscall): xfree
1674         the last text.
1675
1676 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1677
1678         * top.c (print_gdb_version): Update Copyright year in version
1679         message.
1680
1681 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1682
1683         Update copyright year range in all GDB files.
1684
1685 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
1686
1687         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
1688
1689 For older changes see ChangeLog-2018.
1690 \f
1691 Local Variables:
1692 mode: change-log
1693 left-margin: 8
1694 fill-column: 74
1695 version-control: never
1696 coding: utf-8
1697 End:
1698