gdb/ChangeLog

   1 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
   2
   3         * NEWS: Note minimum Python version.
   4
   5 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
   6
   7         * version.in: Set GDB version number to 8.2.90.DATE-git.
   8
   9 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
  10
  11         GDB 8.2.90 released.
  12
  13 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
  14
  15         * version.in: Set GDB version number to 8.2.90.
  16
  17 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
  18
  19         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
  20
  21 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
  22
  23         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
  24         * version.in: Bump version to 8.2.90.DATE-git.
  25
  26 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
  27
  28         * aix-thread.c (ptid_cmp): Remove unused variable.
  29         (get_signaled_thread): Likewise.
  30         (store_regs_user_thread): Likewise.
  31         (store_regs_kernel_thread): Likewise.
  32         (fetch_regs_kernel_thread): Remove shadowed variable.
  33
  34 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
  35
  36         * features/riscv/32bit-cpu.xml: Add register numbers.
  37         * features/riscv/32bit-fpu.c: Regenerate.
  38         * features/riscv/32bit-fpu.xml: Add register numbers.
  39         * features/riscv/64bit-cpu.xml: Add register numbers.
  40         * features/riscv/64bit-fpu.c: Regenerate.
  41         * features/riscv/64bit-fpu.xml: Add register numbers.
  42
  43 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
  44
  45         * NEWS: Mention two argument form of gdb.Value constructor.
  46         * python/py-value.c (convert_buffer_and_type_to_value): New
  47         function.
  48         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
  49         Add support for handling an optional second argument.  Call
  50         convert_buffer_and_type_to_value as appropriate.
  51         * python/python-internal.h (Py_buffer_deleter): New struct.
  52         (Py_buffer_up): New typedef.
  53
  54 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
  55
  56         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
  57         instead of releasing ownership.
  58
  59 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
  60
  61         * dwarf2read.c (open_and_init_dwp_file): Call
  62         elf_numsections instead of bfd_count_sections to initialize
  63         dwp_file->num_sections.
  64
  65 2019-02-25  Tom Tromey  <tromey@adacore.com>
  66
  67         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
  68
  69 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
  70
  71         * gcore.in: Add '--readnever' option when invoking GDB.
  72
  73 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
  74
  75         * MAINTAINERS: Update my email address.
  76
  77 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
  78
  79         * build-id.c (build_id_to_debug_bfd_1): New function.
  80         (build_id_to_debug_bfd): Look for separate debug file in
  81         sysroot.
  82
  83 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  84
  85         * gdbarch.sh: Update the copyright year range that is placed into
  86         generated files.
  87
  88 2019-02-22  Keith Seitz  <keiths@redhat.com>
  89
  90         PR symtab/23853
  91         * linespec.c (create_sals_line_offset): Search for the default
  92         symtab's filename instead of its fullname.
  93
  94 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
  95
  96         * NEWS: Update style defaults.
  97
  98 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
  99
 100         * main.c (captured_main_1): Disable styling in batch mode.
 101
 102 2019-02-20  Tom Tromey  <tom@tromey.com>
 103
 104         * symtab.c (symtab_symbol_info): Fix typos.
 105
 106 2019-02-20  Tom Tromey  <tromey@adacore.com>
 107
 108         * findcmd.c (_initialize_mem_search): Use upper case for
 109         metasyntactic variables.
 110
 111 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
 112
 113         * aarch64-tdep.c (aarch64_add_reggroups): New function.
 114         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
 115
 116 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
 117
 118         * top.h (source_file_name): Change to std::string.
 119         * top.c (source_file_name): Likewise.
 120         (command_line_input): Adjust.
 121         * cli/cli-script.c (script_from_file): Adjust.
 122
 123 2019-02-19  Tom Tromey  <tromey@adacore.com>
 124
 125         * ravenscar-thread.c
 126         (ravenscar_thread_target::update_thread_list): Don't call
 127         ada_build_task_list.
 128         * ada-lang.h (ada_build_task_list): Don't declare.
 129         * ada-tasks.c (struct ada_tasks_inferior_data)
 130         <task_list_valid_p>: Now bool.
 131         (read_known_tasks, ada_task_list_changed)
 132         (ada_tasks_invalidate_inferior_data): Update.
 133         (read_known_tasks_array): Return bool.
 134         (read_known_tasks_list): Likewise.
 135         (read_known_tasks): Return void.
 136         (ada_build_task_list): Now static.
 137
 138 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 139
 140         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
 141         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
 142
 143 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 144
 145         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
 146         variant for ada_tasks_pspace_data_handle and
 147         ada_tasks_inferior_data_handle.
 148         (ada_tasks_pspace_data_cleanup): New function.
 149         (ada_tasks_inferior_data_cleanup): New function.
 150
 151 2019-02-17  Tom Tromey  <tom@tromey.com>
 152
 153         * macrotab.h (macro_source_fullname): Return a std::string.
 154         * macrotab.c (macro_include, check_for_redefinition)
 155         (macro_undef, macro_lookup_definition, foreach_macro)
 156         (foreach_macro_in_scope): Update.
 157         (macro_source_fullname): Return a std::string.
 158         * macrocmd.c (show_pp_source_pos): Update.
 159
 160 2019-02-17  Tom Tromey  <tom@tromey.com>
 161
 162         * macrocmd.c (show_pp_source_pos): Style the file names.
 163
 164 2019-02-17  Tom Tromey  <tom@tromey.com>
 165
 166         PR tui/24197:
 167         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 168
 169 2019-02-17  Tom Tromey  <tom@tromey.com>
 170
 171         * ada-lang.c (user_select_syms): Use filtered printing.
 172         * utils.c (wrap_style): New global.
 173         (desired_style): Remove.
 174         (emit_style_escape): Add stream parameter.
 175         (set_output_style, reset_terminal_style, prompt_for_continue):
 176         Update.
 177         (flush_wrap_buffer): Only flush gdb_stdout.
 178         (wrap_here): Set wrap_style.
 179         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 180         treat escape sequences as a character.  Change when wrap buffer is
 181         flushed.
 182         (fputs_styled): Do not set the output style when the default is
 183         requested.
 184         * ui-style.h (struct ui_file_style) <is_default>: New method.
 185         * source.c (print_source_lines_base): Emit escape sequences in one
 186         piece.
 187
 188 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 189
 190         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 191         integers and enumeration types.
 192
 193 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 194
 195         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 196         instead of lookup_symbol_in_language
 197         (do_exact_match): New function.
 198         (ada_get_symbol_name_matcher): Return do_exact_match when
 199         doing a verbatim match.
 200
 201 2019-02-15  Tom Tromey  <tromey@adacore.com>
 202
 203         * ravenscar-thread.c (ravenscar_thread_target::resume)
 204         (ravenscar_thread_target::wait): Special case wildcard requests.
 205
 206 2019-02-15  Tom Tromey  <tromey@adacore.com>
 207
 208         * ravenscar-thread.c (base_ptid): Remove.
 209         (struct ravenscar_thread_target) <close>: New method.
 210         <m_base_ptid>: New member.
 211         <update_inferior_ptid, active_task, task_is_currently_active,
 212         runtime_initialized>: Declare methods.
 213         <ravenscar_thread_target>: Add constructor.
 214         (ravenscar_thread_target::task_is_currently_active)
 215         (ravenscar_thread_target::update_inferior_ptid)
 216         (ravenscar_runtime_initialized): Rename.  Now methods.
 217         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 218         (ravenscar_thread_target::update_thread_list): Update.
 219         (ravenscar_thread_target::active_task): Now method.
 220         (ravenscar_thread_target::store_registers)
 221         (ravenscar_thread_target::prepare_to_store)
 222         (ravenscar_thread_target::prepare_to_store)
 223         (ravenscar_thread_target::mourn_inferior): Update.
 224         (ravenscar_inferior_created): Use "new" to create target.
 225         (ravenscar_thread_target::get_ada_task_ptid): Update.
 226         (_initialize_ravenscar): Don't initialize base_ptid.
 227         (ravenscar_ops): Remove global.
 228
 229 2019-02-15  Tom Tromey  <tromey@adacore.com>
 230
 231         * target.h (push_target): Declare new overload.
 232         * target.c (push_target): New overload, taking an rvalue reference.
 233         * remote.c (remote_target::open_1): Use push_target overload.
 234         * corelow.c (core_target_open): Use push_target overload.
 235
 236 2019-02-15  Tom Tromey  <tromey@adacore.com>
 237
 238         * ravenscar-thread.c (is_ravenscar_task)
 239         (ravenscar_task_is_currently_active): Return bool.
 240         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 241         (_initialize_ravenscar): Remove "(void)".
 242         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 243         Return bool.
 244
 245 2019-02-15  Tom Tromey  <tromey@adacore.com>
 246
 247         * ravenscar-thread.c (ravenscar_runtime_initializer)
 248         (has_ravenscar_runtime, get_running_thread_id)
 249         (ravenscar_thread_target::resume): Fix indentation.
 250
 251 2019-02-15  Tom Tromey  <tromey@adacore.com>
 252
 253         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 254         from ravenscar_arch_ops.
 255         (sparc_ravenscar_ops::fetch_registers)
 256         (sparc_ravenscar_ops::store_registers): Now methods.
 257         (sparc_ravenscar_prepare_to_store): Remove.
 258         (sparc_ravenscar_ops): Redefine.
 259         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 260         methods and destructor.  Remove members.
 261         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 262         (ravenscar_thread_target::store_registers)
 263         (ravenscar_thread_target::prepare_to_store): Update.
 264         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 265         Remove.
 266         (struct ppc_ravenscar_powerpc_ops): Derive from
 267         ravenscar_arch_ops.
 268         (ppc_ravenscar_powerpc_ops::fetch_registers)
 269         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 270         (ppc_ravenscar_powerpc_ops): Redefine.
 271         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 272         (ppc_ravenscar_e500_ops::fetch_registers)
 273         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 274         (ppc_ravenscar_e500_ops): Redefine.
 275         * aarch64-ravenscar-thread.c
 276         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 277         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 278         (aarch64_ravenscar_fetch_registers)
 279         (aarch64_ravenscar_store_registers): Now methods.
 280         (aarch64_ravenscar_ops): Redefine.
 281
 282 2019-02-15  Tom Tromey  <tromey@adacore.com>
 283
 284         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 285         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 286         (ravenscar_thread_target::stopped_by_watchpoint)
 287         (ravenscar_thread_target::stopped_data_address)
 288         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 289
 290 2019-02-15  Tom Tromey  <tromey@adacore.com>
 291
 292         * ravenscar-thread.c: Fix some typos.
 293
 294 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 295             Tom Tromey  <tromey@adacore.com>
 296
 297         * ada-lang.c (ada_exception_sal): Change addr_string to a
 298         std::string.
 299         (create_ada_exception_catchpoint): Update.
 300
 301 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 302             Tom Tromey  <tromey@adacore.com>
 303
 304         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 305         (bp_location_ops): Remove.
 306         (base_breakpoint_allocate_location): Update.
 307         (free_bp_location): Update.
 308         * ada-lang.c (class ada_catchpoint_location)
 309         <ada_catchpoint_location>: Remove ops parameter.
 310         (ada_catchpoint_location_dtor): Remove.
 311         (ada_catchpoint_location_ops): Remove.
 312         (allocate_location_exception): Update.
 313         * breakpoint.h (struct bp_location_ops): Remove.
 314         (class bp_location) <bp_location>: Remove bp_location_ops
 315         parameter.
 316         <~bp_location>: Add destructor.
 317         <ops>: Remove.
 318
 319 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 320             Pedro Alves  <palves@redhat.com>
 321
 322         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 323         'PATH_MAX'.
 324
 325 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 326             Samuel Thibault  <samuel.thibault@gnu.org>
 327             Thomas Schwinge  <thomas@codesourcery.com>
 328
 329         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 330         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 331
 332 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 333
 334         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 335         (check_empty): Use "const char *".
 336
 337         * gnu-nat.c (gnu_nat_target::detach): Instead of
 338         'detach_inferior (pid)' call
 339         'detach_inferior (find_inferior_pid (pid))'.
 340
 341         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 342         'nat/fork-inferior.o'.
 343         * gnu-nat.c: #include "nat/fork-inferior.h".
 344
 345         * gnu-nat.c (gnu_nat_target::detach): Instead of
 346         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 347         * gnu-nat.h: #include "inf-child.h".
 348         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 349         'i386_gnu_nat_target::fetch_registers'.
 350         (gnu_store_registers): Rename/move to
 351         'i386_gnu_nat_target::store_registers'.
 352
 353         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 354         * gnu-nat.h (mach_thread_info): New function.
 355         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 356
 357         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 358
 359 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 360
 361         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 362
 363 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 364
 365         * windows-nat.c (windows_add_thread): Add new parameter
 366         "main_thread_p" with default value set to false.  Update
 367         function documentation as well as all callers.
 368         (windows_delete_thread): Likewise.
 369         (fake_create_process): Update call to windows_add_thread.
 370         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 371         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 372         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 373         call to windows_delete_thread.
 374
 375 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 376
 377         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 378
 379 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 380
 381         * symfile.c (find_separate_debug_file): Use canonical path of
 382         sysroot with child_path instead of gdb_sysroot if it is valid.
 383
 384 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 385
 386         * symfile.c (find_separate_debug_file): Use child_path to
 387         determine if an object file is under a sysroot.
 388
 389 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 390
 391         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 392         unittests/child-path-selftests.c.
 393         * common/pathstuff.c (child_path): New function.
 394         * common/pathstuff.h (child_path): New prototype.
 395         * unittests/child-path-selftests.c: New file.
 396
 397 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 398
 399         * symfile.c (find_separate_debug_file): Look for separate debug
 400         files in debug directories under the sysroot.
 401
 402 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 403
 404         * symtab.h (struct minimal_symbol data_p): New const method.
 405         (struct minimal_symbol text_p): Likewise.
 406         * symtab.c (output_source_filename): Use file name style
 407         to print file name.
 408         (print_symbol_info): Likewise.
 409         (print_msymbol_info): Use address style to print addresses.
 410         Use function name style to print executable text symbols.
 411         (expand_symtab_containing_pc): Use data_p.
 412         (find_pc_sect_compunit_symtab): Likewise.
 413
 414 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 415
 416         * breakpoint.c (describe_other_breakpoints): Use address style
 417         to print addresses.
 418         (say_where): Likewise.
 419
 420 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 421
 422         * ada-typeprint.c (print_func_type): Print function name
 423         style to print function name.
 424         * c-typeprint.c (c_print_type_1): Likewise.
 425
 426 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 427
 428         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 429         for execve.
 430
 431 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 432
 433         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 434         type_stack.
 435
 436 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 437
 438         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 439         TYPE_CODE_REF types.
 440
 441 2019-02-08  Jim Wilson  <jimw@sifive.com>
 442
 443         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 444         (riscv_linux_fregset): New.
 445         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 446
 447 2019-02-07  Tom Tromey  <tom@tromey.com>
 448
 449         * thread.c (thread_cancel_execution_command): Update.
 450         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 451         methods.
 452         (struct thread_fsm_ops): Remove.
 453         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 454         (thread_fsm_should_stop, thread_fsm_return_value)
 455         (thread_fsm_set_finished, thread_fsm_finished_p)
 456         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 457         Don't declare.
 458         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 459         * infrun.c (clear_proceed_status_thread)
 460         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 461         (print_stop_event): Update.
 462         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 463         Add constructor.
 464         (step_command_fsm_ops): Remove.
 465         (new_step_command_fsm): Remove.
 466         (step_1): Update.
 467         (step_command_fsm::should_stop): Rename from
 468         step_command_fsm_should_stop.
 469         (step_command_fsm::clean_up): Rename from
 470         step_command_fsm_clean_up.
 471         (step_command_fsm::do_async_reply_reason): Rename from
 472         step_command_fsm_async_reply_reason.
 473         (struct until_next_fsm): Inherit from thread_fsm.  Add
 474         constructor.
 475         (until_next_fsm_ops): Remove.
 476         (new_until_next_fsm): Remove.
 477         (until_next_fsm::should_stop): Rename from
 478         until_next_fsm_should_stop.
 479         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 480         (until_next_fsm::do_async_reply_reason): Rename from
 481         until_next_fsm_async_reply_reason.
 482         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 483         constructor.  Change type of breakpoint.
 484         (finish_command_fsm_ops): Remove.
 485         (new_finish_command_fsm): Remove.
 486         (finish_command_fsm::should_stop): Rename from
 487         finish_command_fsm_should_stop.
 488         (finish_command_fsm::clean_up): Rename from
 489         finish_command_fsm_clean_up.
 490         (finish_command_fsm::return_value): Rename from
 491         finish_command_fsm_return_value.
 492         (finish_command_fsm::do_async_reply_reason): Rename from
 493         finish_command_fsm_async_reply_reason.
 494         (finish_command): Update.
 495         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 496         Add constructor.
 497         (call_thread_fsm_ops): Remove.
 498         (call_thread_fsm::call_thread_fsm): Rename from
 499         new_call_thread_fsm.
 500         (call_thread_fsm::should_stop): Rename from
 501         call_thread_fsm_should_stop.
 502         (call_thread_fsm::should_notify_stop): Rename from
 503         call_thread_fsm_should_notify_stop.
 504         (run_inferior_call, call_function_by_hand_dummy): Update.
 505         * cli/cli-interp.c (should_print_stop_to_console): Update.
 506         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 507         Add constructor.  Change type of location_breakpoint,
 508         caller_breakpoint.
 509         (until_break_fsm_ops): Remove.
 510         (new_until_break_fsm): Remove.
 511         (until_break_fsm::should_stop): Rename from
 512         until_break_fsm_should_stop.
 513         (until_break_fsm::clean_up): Rename from
 514         until_break_fsm_clean_up.
 515         (until_break_fsm::do_async_reply_reason): Rename from
 516         until_break_fsm_async_reply_reason.
 517         (until_break_command): Update.
 518         * thread-fsm.c: Remove.
 519         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 520
 521 2019-02-07  Tom Tromey  <tom@tromey.com>
 522
 523         * yy-remap.h: Add include guard.
 524         * xtensa-tdep.h: Add include guard.
 525         * xcoffread.h: Rename include guard.
 526         * varobj-iter.h: Add include guard.
 527         * tui/tui.h: Rename include guard.
 528         * tui/tui-winsource.h: Rename include guard.
 529         * tui/tui-wingeneral.h: Rename include guard.
 530         * tui/tui-windata.h: Rename include guard.
 531         * tui/tui-win.h: Rename include guard.
 532         * tui/tui-stack.h: Rename include guard.
 533         * tui/tui-source.h: Rename include guard.
 534         * tui/tui-regs.h: Rename include guard.
 535         * tui/tui-out.h: Rename include guard.
 536         * tui/tui-layout.h: Rename include guard.
 537         * tui/tui-io.h: Rename include guard.
 538         * tui/tui-hooks.h: Rename include guard.
 539         * tui/tui-file.h: Rename include guard.
 540         * tui/tui-disasm.h: Rename include guard.
 541         * tui/tui-data.h: Rename include guard.
 542         * tui/tui-command.h: Rename include guard.
 543         * tic6x-tdep.h: Add include guard.
 544         * target/waitstatus.h: Rename include guard.
 545         * target/wait.h: Rename include guard.
 546         * target/target.h: Rename include guard.
 547         * target/resume.h: Rename include guard.
 548         * target-float.h: Rename include guard.
 549         * stabsread.h: Add include guard.
 550         * rs6000-tdep.h: Add include guard.
 551         * riscv-fbsd-tdep.h: Add include guard.
 552         * regformats/regdef.h: Rename include guard.
 553         * record.h: Rename include guard.
 554         * python/python.h: Rename include guard.
 555         * python/python-internal.h: Rename include guard.
 556         * python/py-stopevent.h: Rename include guard.
 557         * python/py-ref.h: Rename include guard.
 558         * python/py-record.h: Rename include guard.
 559         * python/py-record-full.h: Rename include guard.
 560         * python/py-record-btrace.h: Rename include guard.
 561         * python/py-instruction.h: Rename include guard.
 562         * python/py-events.h: Rename include guard.
 563         * python/py-event.h: Rename include guard.
 564         * procfs.h: Add include guard.
 565         * proc-utils.h: Add include guard.
 566         * p-lang.h: Add include guard.
 567         * or1k-tdep.h: Rename include guard.
 568         * observable.h: Rename include guard.
 569         * nto-tdep.h: Rename include guard.
 570         * nat/x86-linux.h: Rename include guard.
 571         * nat/x86-linux-dregs.h: Rename include guard.
 572         * nat/x86-gcc-cpuid.h: Add include guard.
 573         * nat/x86-dregs.h: Rename include guard.
 574         * nat/x86-cpuid.h: Rename include guard.
 575         * nat/ppc-linux.h: Rename include guard.
 576         * nat/mips-linux-watch.h: Rename include guard.
 577         * nat/linux-waitpid.h: Rename include guard.
 578         * nat/linux-ptrace.h: Rename include guard.
 579         * nat/linux-procfs.h: Rename include guard.
 580         * nat/linux-osdata.h: Rename include guard.
 581         * nat/linux-nat.h: Rename include guard.
 582         * nat/linux-namespaces.h: Rename include guard.
 583         * nat/linux-btrace.h: Rename include guard.
 584         * nat/glibc_thread_db.h: Rename include guard.
 585         * nat/gdb_thread_db.h: Rename include guard.
 586         * nat/gdb_ptrace.h: Rename include guard.
 587         * nat/fork-inferior.h: Rename include guard.
 588         * nat/amd64-linux-siginfo.h: Rename include guard.
 589         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 590         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 591         * nat/aarch64-linux.h: Rename include guard.
 592         * nat/aarch64-linux-hw-point.h: Rename include guard.
 593         * mn10300-tdep.h: Add include guard.
 594         * mips-linux-tdep.h: Add include guard.
 595         * mi/mi-parse.h: Rename include guard.
 596         * mi/mi-out.h: Rename include guard.
 597         * mi/mi-main.h: Rename include guard.
 598         * mi/mi-interp.h: Rename include guard.
 599         * mi/mi-getopt.h: Rename include guard.
 600         * mi/mi-console.h: Rename include guard.
 601         * mi/mi-common.h: Rename include guard.
 602         * mi/mi-cmds.h: Rename include guard.
 603         * mi/mi-cmd-break.h: Rename include guard.
 604         * m2-lang.h: Add include guard.
 605         * location.h: Rename include guard.
 606         * linux-record.h: Rename include guard.
 607         * linux-nat.h: Add include guard.
 608         * linux-fork.h: Add include guard.
 609         * i386-darwin-tdep.h: Rename include guard.
 610         * hppa-linux-offsets.h: Add include guard.
 611         * guile/guile.h: Rename include guard.
 612         * guile/guile-internal.h: Rename include guard.
 613         * gnu-nat.h: Rename include guard.
 614         * gdb-stabs.h: Rename include guard.
 615         * frv-tdep.h: Add include guard.
 616         * f-lang.h: Add include guard.
 617         * event-loop.h: Add include guard.
 618         * darwin-nat.h: Rename include guard.
 619         * cp-abi.h: Rename include guard.
 620         * config/sparc/nm-sol2.h: Rename include guard.
 621         * config/nm-nto.h: Rename include guard.
 622         * config/nm-linux.h: Add include guard.
 623         * config/i386/nm-i386gnu.h: Rename include guard.
 624         * config/djgpp/nl_types.h: Rename include guard.
 625         * config/djgpp/langinfo.h: Rename include guard.
 626         * compile/gcc-cp-plugin.h: Add include guard.
 627         * compile/gcc-c-plugin.h: Add include guard.
 628         * compile/compile.h: Rename include guard.
 629         * compile/compile-object-run.h: Rename include guard.
 630         * compile/compile-object-load.h: Rename include guard.
 631         * compile/compile-internal.h: Rename include guard.
 632         * compile/compile-cplus.h: Rename include guard.
 633         * compile/compile-c.h: Rename include guard.
 634         * common/xml-utils.h: Rename include guard.
 635         * common/x86-xstate.h: Rename include guard.
 636         * common/version.h: Rename include guard.
 637         * common/vec.h: Rename include guard.
 638         * common/tdesc.h: Rename include guard.
 639         * common/selftest.h: Rename include guard.
 640         * common/scoped_restore.h: Rename include guard.
 641         * common/scoped_mmap.h: Rename include guard.
 642         * common/scoped_fd.h: Rename include guard.
 643         * common/safe-iterator.h: Rename include guard.
 644         * common/run-time-clock.h: Rename include guard.
 645         * common/refcounted-object.h: Rename include guard.
 646         * common/queue.h: Rename include guard.
 647         * common/ptid.h: Rename include guard.
 648         * common/print-utils.h: Rename include guard.
 649         * common/preprocessor.h: Rename include guard.
 650         * common/pathstuff.h: Rename include guard.
 651         * common/observable.h: Rename include guard.
 652         * common/netstuff.h: Rename include guard.
 653         * common/job-control.h: Rename include guard.
 654         * common/host-defs.h: Rename include guard.
 655         * common/gdb_wait.h: Rename include guard.
 656         * common/gdb_vecs.h: Rename include guard.
 657         * common/gdb_unlinker.h: Rename include guard.
 658         * common/gdb_unique_ptr.h: Rename include guard.
 659         * common/gdb_tilde_expand.h: Rename include guard.
 660         * common/gdb_sys_time.h: Rename include guard.
 661         * common/gdb_string_view.h: Rename include guard.
 662         * common/gdb_splay_tree.h: Rename include guard.
 663         * common/gdb_setjmp.h: Rename include guard.
 664         * common/gdb_ref_ptr.h: Rename include guard.
 665         * common/gdb_optional.h: Rename include guard.
 666         * common/gdb_locale.h: Rename include guard.
 667         * common/gdb_assert.h: Rename include guard.
 668         * common/filtered-iterator.h: Rename include guard.
 669         * common/filestuff.h: Rename include guard.
 670         * common/fileio.h: Rename include guard.
 671         * common/environ.h: Rename include guard.
 672         * common/common-utils.h: Rename include guard.
 673         * common/common-types.h: Rename include guard.
 674         * common/common-regcache.h: Rename include guard.
 675         * common/common-inferior.h: Rename include guard.
 676         * common/common-gdbthread.h: Rename include guard.
 677         * common/common-exceptions.h: Rename include guard.
 678         * common/common-defs.h: Rename include guard.
 679         * common/common-debug.h: Rename include guard.
 680         * common/cleanups.h: Rename include guard.
 681         * common/buffer.h: Rename include guard.
 682         * common/btrace-common.h: Rename include guard.
 683         * common/break-common.h: Rename include guard.
 684         * cli/cli-utils.h: Rename include guard.
 685         * cli/cli-style.h: Rename include guard.
 686         * cli/cli-setshow.h: Rename include guard.
 687         * cli/cli-script.h: Rename include guard.
 688         * cli/cli-interp.h: Rename include guard.
 689         * cli/cli-decode.h: Rename include guard.
 690         * cli/cli-cmds.h: Rename include guard.
 691         * charset-list.h: Add include guard.
 692         * buildsym-legacy.h: Rename include guard.
 693         * bfin-tdep.h: Add include guard.
 694         * ax.h: Rename include guard.
 695         * arm-linux-tdep.h: Add include guard.
 696         * arm-fbsd-tdep.h: Add include guard.
 697         * arch/xtensa.h: Rename include guard.
 698         * arch/tic6x.h: Add include guard.
 699         * arch/i386.h: Add include guard.
 700         * arch/arm.h: Rename include guard.
 701         * arch/arm-linux.h: Rename include guard.
 702         * arch/arm-get-next-pcs.h: Rename include guard.
 703         * arch/amd64.h: Add include guard.
 704         * arch/aarch64-insn.h: Rename include guard.
 705         * arch-utils.h: Rename include guard.
 706         * annotate.h: Add include guard.
 707         * amd64-darwin-tdep.h: Rename include guard.
 708         * aarch64-linux-tdep.h: Add include guard.
 709         * aarch64-fbsd-tdep.h: Add include guard.
 710         * aarch32-linux-nat.h: Add include guard.
 711
 712 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 713
 714         * macrotab.c (macro_define_internal): New function that
 715         factorizes macro_define_object_internal and macro_define_function
 716         code.
 717         (macro_define_object_internal): Use macro_define_internal.
 718         (macro_define_function): Likewise.
 719
 720 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 721
 722         * macrocmd.c (extract_identifier): Return
 723         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 724         callers.
 725
 726 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 727
 728         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 729
 730 2019-02-05  Tom Tromey  <tom@tromey.com>
 731
 732         * target.c (target_stack::unpush): Move assertion earlier.
 733
 734 2019-01-30  Tom Tromey  <tom@tromey.com>
 735
 736         PR python/23615:
 737         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 738         (gdbpy_parse_and_eval): Likewise.
 739         * python/python-internal.h (gdbpy_allow_threads): New class.
 740
 741 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 742
 743         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 744         (aarch64_fbsd_fpregmap): Move earlier.
 745         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 746         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 747         instead of individual calls to trad_frame_set_reg_addr.
 748         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 749         earlier.
 750         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 751         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 752         instead of individual calls to trad_frame_set_reg_addr.
 753
 754 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 755
 756         * CONTRIBUTE: Replace contribution list with wiki link.
 757
 758 2019-01-25  Tom Tromey  <tom@tromey.com>
 759
 760         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 761
 762 2019-01-25  Tom Tromey  <tom@tromey.com>
 763
 764         * xtensa-linux-nat.c: Fix common/ includes.
 765         * xml-support.h: Fix common/ includes.
 766         * xml-support.c: Fix common/ includes.
 767         * x86-linux-nat.c: Fix common/ includes.
 768         * windows-nat.c: Fix common/ includes.
 769         * varobj.h: Fix common/ includes.
 770         * varobj.c: Fix common/ includes.
 771         * value.c: Fix common/ includes.
 772         * valops.c: Fix common/ includes.
 773         * utils.c: Fix common/ includes.
 774         * unittests/xml-utils-selftests.c: Fix common/ includes.
 775         * unittests/utils-selftests.c: Fix common/ includes.
 776         * unittests/unpack-selftests.c: Fix common/ includes.
 777         * unittests/tracepoint-selftests.c: Fix common/ includes.
 778         * unittests/style-selftests.c: Fix common/ includes.
 779         * unittests/string_view-selftests.c: Fix common/ includes.
 780         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 781         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 782         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 783         * unittests/rsp-low-selftests.c: Fix common/ includes.
 784         * unittests/parse-connection-spec-selftests.c: Fix common/
 785         includes.
 786         * unittests/optional-selftests.c: Fix common/ includes.
 787         * unittests/offset-type-selftests.c: Fix common/ includes.
 788         * unittests/observable-selftests.c: Fix common/ includes.
 789         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 790         * unittests/memrange-selftests.c: Fix common/ includes.
 791         * unittests/memory-map-selftests.c: Fix common/ includes.
 792         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 793         * unittests/function-view-selftests.c: Fix common/ includes.
 794         * unittests/environ-selftests.c: Fix common/ includes.
 795         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 796         * unittests/common-utils-selftests.c: Fix common/ includes.
 797         * unittests/cli-utils-selftests.c: Fix common/ includes.
 798         * unittests/array-view-selftests.c: Fix common/ includes.
 799         * ui-file.c: Fix common/ includes.
 800         * tui/tui-io.c: Fix common/ includes.
 801         * tracepoint.h: Fix common/ includes.
 802         * tracepoint.c: Fix common/ includes.
 803         * tracefile-tfile.c: Fix common/ includes.
 804         * top.h: Fix common/ includes.
 805         * top.c: Fix common/ includes.
 806         * thread.c: Fix common/ includes.
 807         * target/waitstatus.h: Fix common/ includes.
 808         * target/waitstatus.c: Fix common/ includes.
 809         * target.h: Fix common/ includes.
 810         * target.c: Fix common/ includes.
 811         * target-memory.c: Fix common/ includes.
 812         * target-descriptions.c: Fix common/ includes.
 813         * symtab.h: Fix common/ includes.
 814         * symfile.c: Fix common/ includes.
 815         * stap-probe.c: Fix common/ includes.
 816         * spu-linux-nat.c: Fix common/ includes.
 817         * sparc-nat.c: Fix common/ includes.
 818         * source.c: Fix common/ includes.
 819         * solib.c: Fix common/ includes.
 820         * solib-target.c: Fix common/ includes.
 821         * ser-unix.c: Fix common/ includes.
 822         * ser-tcp.c: Fix common/ includes.
 823         * ser-pipe.c: Fix common/ includes.
 824         * ser-base.c: Fix common/ includes.
 825         * selftest-arch.c: Fix common/ includes.
 826         * s12z-tdep.c: Fix common/ includes.
 827         * rust-exp.y: Fix common/ includes.
 828         * rs6000-aix-tdep.c: Fix common/ includes.
 829         * riscv-tdep.c: Fix common/ includes.
 830         * remote.c: Fix common/ includes.
 831         * remote-notif.h: Fix common/ includes.
 832         * remote-fileio.h: Fix common/ includes.
 833         * remote-fileio.c: Fix common/ includes.
 834         * regcache.h: Fix common/ includes.
 835         * regcache.c: Fix common/ includes.
 836         * record-btrace.c: Fix common/ includes.
 837         * python/python.c: Fix common/ includes.
 838         * python/py-type.c: Fix common/ includes.
 839         * python/py-inferior.c: Fix common/ includes.
 840         * progspace.h: Fix common/ includes.
 841         * producer.c: Fix common/ includes.
 842         * procfs.c: Fix common/ includes.
 843         * proc-api.c: Fix common/ includes.
 844         * printcmd.c: Fix common/ includes.
 845         * ppc-linux-nat.c: Fix common/ includes.
 846         * parser-defs.h: Fix common/ includes.
 847         * osdata.c: Fix common/ includes.
 848         * obsd-nat.c: Fix common/ includes.
 849         * nat/x86-linux.c: Fix common/ includes.
 850         * nat/x86-linux-dregs.c: Fix common/ includes.
 851         * nat/x86-dregs.h: Fix common/ includes.
 852         * nat/x86-dregs.c: Fix common/ includes.
 853         * nat/ppc-linux.c: Fix common/ includes.
 854         * nat/mips-linux-watch.h: Fix common/ includes.
 855         * nat/mips-linux-watch.c: Fix common/ includes.
 856         * nat/linux-waitpid.c: Fix common/ includes.
 857         * nat/linux-ptrace.h: Fix common/ includes.
 858         * nat/linux-ptrace.c: Fix common/ includes.
 859         * nat/linux-procfs.c: Fix common/ includes.
 860         * nat/linux-personality.c: Fix common/ includes.
 861         * nat/linux-osdata.c: Fix common/ includes.
 862         * nat/linux-namespaces.c: Fix common/ includes.
 863         * nat/linux-btrace.h: Fix common/ includes.
 864         * nat/linux-btrace.c: Fix common/ includes.
 865         * nat/fork-inferior.c: Fix common/ includes.
 866         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 867         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 868         * nat/aarch64-linux.c: Fix common/ includes.
 869         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 870         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 871         * namespace.h: Fix common/ includes.
 872         * mips-linux-tdep.c: Fix common/ includes.
 873         * minsyms.c: Fix common/ includes.
 874         * mi/mi-parse.h: Fix common/ includes.
 875         * mi/mi-main.c: Fix common/ includes.
 876         * mi/mi-cmd-env.c: Fix common/ includes.
 877         * memrange.h: Fix common/ includes.
 878         * memattr.c: Fix common/ includes.
 879         * maint.h: Fix common/ includes.
 880         * maint.c: Fix common/ includes.
 881         * main.c: Fix common/ includes.
 882         * machoread.c: Fix common/ includes.
 883         * location.c: Fix common/ includes.
 884         * linux-thread-db.c: Fix common/ includes.
 885         * linux-nat.c: Fix common/ includes.
 886         * linux-fork.c: Fix common/ includes.
 887         * inline-frame.c: Fix common/ includes.
 888         * infrun.c: Fix common/ includes.
 889         * inflow.c: Fix common/ includes.
 890         * inferior.h: Fix common/ includes.
 891         * inferior.c: Fix common/ includes.
 892         * infcmd.c: Fix common/ includes.
 893         * inf-ptrace.c: Fix common/ includes.
 894         * inf-child.c: Fix common/ includes.
 895         * ia64-linux-nat.c: Fix common/ includes.
 896         * i387-tdep.c: Fix common/ includes.
 897         * i386-tdep.c: Fix common/ includes.
 898         * i386-linux-tdep.c: Fix common/ includes.
 899         * i386-linux-nat.c: Fix common/ includes.
 900         * i386-go32-tdep.c: Fix common/ includes.
 901         * i386-fbsd-tdep.c: Fix common/ includes.
 902         * i386-fbsd-nat.c: Fix common/ includes.
 903         * guile/scm-type.c: Fix common/ includes.
 904         * guile/guile.c: Fix common/ includes.
 905         * go32-nat.c: Fix common/ includes.
 906         * gnu-nat.c: Fix common/ includes.
 907         * gdbthread.h: Fix common/ includes.
 908         * gdbarch-selftests.c: Fix common/ includes.
 909         * gdb_usleep.c: Fix common/ includes.
 910         * gdb_select.h: Fix common/ includes.
 911         * gdb_bfd.c: Fix common/ includes.
 912         * gcore.c: Fix common/ includes.
 913         * fork-child.c: Fix common/ includes.
 914         * findvar.c: Fix common/ includes.
 915         * fbsd-nat.c: Fix common/ includes.
 916         * event-top.c: Fix common/ includes.
 917         * event-loop.c: Fix common/ includes.
 918         * dwarf2read.c: Fix common/ includes.
 919         * dwarf2loc.c: Fix common/ includes.
 920         * dwarf2-frame.c: Fix common/ includes.
 921         * dwarf-index-cache.c: Fix common/ includes.
 922         * dtrace-probe.c: Fix common/ includes.
 923         * disasm-selftests.c: Fix common/ includes.
 924         * defs.h: Fix common/ includes.
 925         * csky-tdep.c: Fix common/ includes.
 926         * cp-valprint.c: Fix common/ includes.
 927         * cp-support.h: Fix common/ includes.
 928         * cp-support.c: Fix common/ includes.
 929         * corelow.c: Fix common/ includes.
 930         * completer.h: Fix common/ includes.
 931         * completer.c: Fix common/ includes.
 932         * compile/compile.c: Fix common/ includes.
 933         * compile/compile-loc2c.c: Fix common/ includes.
 934         * compile/compile-cplus-types.c: Fix common/ includes.
 935         * compile/compile-cplus-symbols.c: Fix common/ includes.
 936         * command.h: Fix common/ includes.
 937         * cli/cli-dump.c: Fix common/ includes.
 938         * cli/cli-cmds.c: Fix common/ includes.
 939         * charset.c: Fix common/ includes.
 940         * build-id.c: Fix common/ includes.
 941         * btrace.h: Fix common/ includes.
 942         * btrace.c: Fix common/ includes.
 943         * breakpoint.h: Fix common/ includes.
 944         * breakpoint.c: Fix common/ includes.
 945         * ax.h:
 946         (enum agent_op): Fix common/ includes.
 947         * ax-general.c (struct aop_map): Fix common/ includes.
 948         * ax-gdb.c: Fix common/ includes.
 949         * auxv.c: Fix common/ includes.
 950         * auto-load.c: Fix common/ includes.
 951         * arm-tdep.c: Fix common/ includes.
 952         * arch/riscv.c: Fix common/ includes.
 953         * arch/ppc-linux-common.c: Fix common/ includes.
 954         * arch/i386.c: Fix common/ includes.
 955         * arch/arm.c: Fix common/ includes.
 956         * arch/arm-linux.c: Fix common/ includes.
 957         * arch/arm-get-next-pcs.c: Fix common/ includes.
 958         * arch/amd64.c: Fix common/ includes.
 959         * arch/aarch64.c: Fix common/ includes.
 960         * arch/aarch64-insn.c: Fix common/ includes.
 961         * arch-utils.c: Fix common/ includes.
 962         * amd64-windows-tdep.c: Fix common/ includes.
 963         * amd64-tdep.c: Fix common/ includes.
 964         * amd64-sol2-tdep.c: Fix common/ includes.
 965         * amd64-obsd-tdep.c: Fix common/ includes.
 966         * amd64-nbsd-tdep.c: Fix common/ includes.
 967         * amd64-linux-tdep.c: Fix common/ includes.
 968         * amd64-linux-nat.c: Fix common/ includes.
 969         * amd64-fbsd-tdep.c: Fix common/ includes.
 970         * amd64-fbsd-nat.c: Fix common/ includes.
 971         * amd64-dicos-tdep.c: Fix common/ includes.
 972         * amd64-darwin-tdep.c: Fix common/ includes.
 973         * agent.c: Fix common/ includes.
 974         * ada-lang.h: Fix common/ includes.
 975         * ada-lang.c: Fix common/ includes.
 976         * aarch64-tdep.c: Fix common/ includes.
 977
 978 2019-01-25  Tom Tromey  <tom@tromey.com>
 979
 980         * common/create-version.sh: Use common/version.h.
 981
 982 2019-01-24  Pedro Alves  <palves@redhat.com>
 983
 984         * infrun.c (signal_stop, signal_print, signal_program)
 985         (signal_catch, signal_pass): Now arrays instead of pointers.
 986         (update_signals_program_target, do_target_resume)
 987         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 988         * linux-nat.c (linux_nat_target::pass_signals)
 989         (linux_nat_target::create_inferior, linux_nat_target::attach):
 990         Adjust.
 991         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 992         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 993         * procfs.c (procfs_target::pass_signals): Adjust.
 994         * record-full.c (record_full_target::resume): Adjust.
 995         * remote.c (remote_target::pass_signals)
 996         (remote_target::program_signals): Adjust.
 997         * target-debug.h (target_debug_print_signals): Now takes a
 998         gdb::array_view as parameter.  Adjust.
 999         * target.h (target_ops) <pass_signals, program_signals>: Replace
1000         pointer and length parameters with gdb::array_view.
1001         (target_pass_signals, target_program_signals): Likewise.
1002         * target-delegates.c: Regenerate.
1003
1004 2019-01-24  Pedro Alves  <palves@redhat.com>
1005
1006         * common/forward-scope-exit.h
1007         (forward_scope_exit::forward_scope_exit): Pass arguments to
1008         m_bind_function directly, instead of creating a std::bind and
1009         copying that.
1010
1011 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1012
1013         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1014         for static members.
1015         (pass_in_v_vfp_candidate): Likewise.
1016
1017 2019-01-23  Tom Tromey  <tom@tromey.com>
1018             Pedro Alves  <palves@redhat.com>
1019
1020         * regcache.c (class regcache_invalidator): Remove.
1021         (regcache::raw_write): Use make_scope_exit.
1022
1023 2019-01-23  Tom Tromey  <tom@tromey.com>
1024
1025         * ui-out.h (class ui_out_emit_type): Update comment.
1026
1027 2019-01-23  Tom Tromey  <tom@tromey.com>
1028
1029         * infrun.c (fetch_inferior_event): Update comment.
1030
1031 2019-01-23  Tom Tromey  <tom@tromey.com>
1032             Pedro Alves  <palves@redhat.com>
1033
1034         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1035         parameter.
1036         (fetch_inferior_event): Use SCOPE_EXIT.
1037
1038
1039 2019-01-23  Tom Tromey  <tom@tromey.com>
1040             Pedro Alves  <palves@redhat.com>
1041
1042         * infrun.c (disable_thread_events): Delete.
1043         (stop_all_threads): Use SCOPE_EXIT.
1044
1045 2019-01-23  Tom Tromey  <tom@tromey.com>
1046             Pedro Alves  <palves@redhat.com>
1047
1048         * symfile.c: Include forward-scope-exit.h.
1049         (clear_symtab_users_cleanup): Replace forward declaration with
1050         a FORWARD_SCOPE_EXIT.
1051         (syms_from_objfile_1): Use the forward_scope_exit and
1052         gdb::optional instead of cleanup_function.
1053         (reread_symbols): Use the forward_scope_exit instead of
1054         cleanup_function.
1055         (clear_symtab_users_cleanup): Remove function.
1056
1057 2019-01-23  Tom Tromey  <tom@tromey.com>
1058             Pedro Alves  <palves@redhat.com>
1059
1060         * linux-nat.c: Include scope-exit.h.
1061         (cleanup_target_stop): Remove.
1062         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1063         SCOPE_EXIT.
1064
1065 2019-01-23  Tom Tromey  <tom@tromey.com>
1066             Pedro Alves  <palves@redhat.com>
1067
1068         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1069         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1070
1071 2019-01-23  Tom Tromey  <tom@tromey.com>
1072             Andrew Burgess  <andrew.burgess@embecosm.com>
1073             Pedro Alves  <palves@redhat.com>
1074
1075         * infrun.c (fetch_inferior_event): Use scope_exit.
1076         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1077         * top.c (execute_command): Use scope_exit.
1078         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1079         * utils.c (do_bpstat_clear_actions_cleanup)
1080         (make_bpstat_clear_actions_cleanup): Remove.
1081
1082 2019-01-23  Tom Tromey  <tom@tromey.com>
1083             Pedro Alves  <palves@redhat.com>
1084
1085         * infrun.c: Include "common/scope-exit.h"
1086         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1087         (wait_for_inferior): Use SCOPE_EXIT.
1088         (fetch_inferior_event): Use scope_exit.
1089
1090 2019-01-23  Tom Tromey  <tom@tromey.com>
1091             Pedro Alves  <palves@redhat.com>
1092
1093         * breakpoint.c (create_breakpoint): Remove cleanup.
1094
1095 2019-01-23  Tom Tromey  <tom@tromey.com>
1096             Andrew Burgess  <andrew.burgess@embecosm.com>
1097             Pedro Alves  <palves@redhat.com>
1098
1099 2019-01-23  Pedro Alves  <palves@redhat.com>
1100
1101         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1102
1103 2019-01-23  Pedro Alves  <palves@redhat.com>
1104             Andrew Burgess  <andrew.burgess@embecosm.com>
1105
1106         * gdbthread.h: Include "common/forward-scope-exit.h".
1107         (scoped_finish_thread_state): Redefine custom class in terms of
1108         forward_scope_exit.
1109
1110 2019-01-23  Pedro Alves  <palves@redhat.com>
1111             Andrew Burgess  <andrew.burgess@embecosm.com>
1112
1113         * common/forward-scope-exit.h: New file.
1114
1115 2019-01-23  Pedro Alves  <palves@redhat.com>
1116             Andrew Burgess  <andrew.burgess@embecosm.com>
1117             Tom Tromey  <tom@tromey.com>
1118
1119         * common/scope-exit.h: New file.
1120
1121 2019-01-23  Pedro Alves  <palves@redhat.com>
1122
1123         * common/preprocessor.h (ESC): Rename to ...
1124         (ESC_PARENS): ... this.
1125         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1126         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1127
1128 2019-01-23  Tom Tromey  <tom@tromey.com>
1129
1130         * language.h (class scoped_switch_to_sym_language_if_auto):
1131         Initialize m_lang in both cases.
1132
1133 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1134
1135         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1136         with XCNEW.
1137
1138 2019-01-22  Tom Tromey  <tom@tromey.com>
1139
1140         * corelow.c: Do not include sys/file.h.
1141
1142 2019-01-22  Tom Tromey  <tom@tromey.com>
1143
1144         * tui/tui-wingeneral.h: Include gdb_curses.h.
1145
1146 2019-01-22  Tom Tromey  <tom@tromey.com>
1147
1148         * source-cache.h (class source_cache) <get_source_lines,
1149         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1150
1151 2019-01-22  Tom Tromey  <tom@tromey.com>
1152
1153         * remote-fileio.h (struct remote_target): Declare.
1154
1155 2019-01-22  Tom Tromey  <tom@tromey.com>
1156
1157         * python/py-arch.c: Do not include py-ref.h.
1158         * python/py-bpevent.c: Do not include py-ref.h.
1159         * python/py-cmd.c: Do not include py-ref.h.
1160         * python/py-continueevent.c: Do not include py-ref.h.
1161         * python/py-event.h: Do not include py-ref.h.
1162         * python/py-evtregistry.c: Do not include py-ref.h.
1163         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1164         * python/py-frame.c: Do not include py-ref.h.
1165         * python/py-framefilter.c: Do not include py-ref.h.
1166         * python/py-function.c: Do not include py-ref.h.
1167         * python/py-infevents.c: Do not include py-ref.h.
1168         * python/py-linetable.c: Do not include py-ref.h.
1169         * python/py-objfile.c: Do not include py-ref.h.
1170         * python/py-param.c: Do not include py-ref.h.
1171         * python/py-prettyprint.c: Do not include py-ref.h.
1172         * python/py-progspace.c: Do not include py-ref.h.
1173         * python/py-symbol.c: Do not include py-ref.h.
1174         * python/py-symtab.c: Do not include py-ref.h.
1175         * python/py-type.c: Do not include py-ref.h.
1176         * python/py-unwind.c: Do not include py-ref.h.
1177         * python/py-utils.c: Do not include py-ref.h.
1178         * python/py-value.c: Do not include py-ref.h.
1179         * python/py-varobj.c: Do not include py-ref.h.
1180         * python/py-xmethods.c: Do not include py-ref.h.
1181         * python/python.c: Do not include py-ref.h.
1182         * varobj.c: Do not include py-ref.h.
1183
1184 2019-01-22  Tom Tromey  <tom@tromey.com>
1185
1186         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1187         keyword for bcache.
1188
1189 2019-01-22  Tom Tromey  <tom@tromey.com>
1190
1191         * compile/compile-cplus-types.c: Remove a comment by #include.
1192
1193 2019-01-22  Tom Tromey  <tom@tromey.com>
1194
1195         * compile/gcc-c-plugin.h: Include compile-internal.h.
1196
1197 2019-01-22  Tom Tromey  <tom@tromey.com>
1198
1199         * stabsread.c (EXTERN): Do not define.
1200         (symnum, next_symbol_text_func, processing_gcc_compilation)
1201         (within_function, global_sym_chain, global_stabs)
1202         (previous_stab_code, this_object_header_files)
1203         (n_this_object_header_files)
1204         (n_allocated_this_object_header_files): Define.
1205         * stabsread.h (EXTERN): Never define.  Use "extern".
1206
1207 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1208
1209         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1210         history_value.
1211
1212 2019-01-21  Tom Tromey  <tom@tromey.com>
1213
1214         * ui-out.c: Fix includes.
1215         * tui/tui-source.c: Fix includes.
1216         * target.c: Fix includes.
1217         * remote.c: Fix includes.
1218         * regcache.c: Fix includes.
1219         * python/py-block.c: Fix includes.
1220         * printcmd.c: Fix includes.
1221         * or1k-tdep.c: Fix includes.
1222         * mi/mi-main.c: Fix includes.
1223         * m32r-tdep.c: Fix includes.
1224         * csky-tdep.c: Fix includes.
1225         * compile/compile-cplus-types.c: Fix includes.
1226         * cli/cli-interp.c: Fix includes.
1227
1228 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1229
1230         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1231         for padding.
1232
1233 2019-01-16  Tom Tromey  <tom@tromey.com>
1234
1235         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1236         earlier.
1237         (struct objfile) <msymbols_range>: Move from top level.
1238         <msymbols>: New method.
1239         (class objfile_msymbols): Remove.
1240         * symtab.c (default_collect_symbol_completion_matches_break_on):
1241         Update.
1242         * symmisc.c (dump_msymbols): Update.
1243         * stabsread.c (scan_file_globals): Update.
1244         * objc-lang.c (info_selectors_command, info_classes_command)
1245         (find_methods): Update.
1246         * minsyms.c (find_solib_trampoline_target): Update.
1247         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1248         * coffread.c (coff_symfile_read): Update.
1249         * ada-lang.c (ada_lookup_simple_minsym)
1250         (ada_collect_symbol_completion_matches): Update.
1251
1252 2019-01-16  Tom Tromey  <tom@tromey.com>
1253
1254         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1255         type.  Remove no-argument constructor.
1256         <iterator::operator++>: Simplify.
1257         <begin>: Update.
1258         <end>: Use minimal_symbol_count.
1259
1260 2019-01-16  Tom Tromey  <tom@tromey.com>
1261
1262         * objfiles.h (struct objfile) <psymtabs>: New method.
1263         (class objfile_psymtabs): Remove.
1264         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1265         typedef.
1266         <range>: New method.
1267         (require_partial_symbols): Change return type.
1268         * psymtab.c (require_partial_symbols)
1269         (psym_expand_symtabs_matching): Update.
1270         * mdebugread.c (parse_partial_symbols): Update.
1271         * dbxread.c (dbx_end_psymtab): Update.
1272
1273 2019-01-15  Tom Tromey  <tom@tromey.com>
1274
1275         * symtab.c (lookup_objfile_from_block)
1276         (lookup_symbol_in_objfile_symtabs)
1277         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1278         (find_line_symtab, info_sources_command)
1279         (default_collect_symbol_completion_matches_break_on)
1280         (make_source_files_completion_list): Update.
1281         * symmisc.c (print_objfile_statistics, dump_objfile)
1282         (maintenance_print_symbols, maintenance_info_symtabs)
1283         (maintenance_check_symtabs, maintenance_info_line_tables):
1284         Update.
1285         * source.c (select_source_symtab)
1286         (forget_cached_source_info_for_objfile): Update.
1287         * objfiles.h (class objfile_compunits): Remove.
1288         (struct objfile) <compunits_range>: New typedef.
1289         (compunits): New method.
1290         * objfiles.c (objfile_relocate1): Update.
1291         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1292         * maint.c (count_symtabs_and_blocks): Update.
1293         * linespec.c (iterate_over_all_matching_symtabs): Update.
1294         * cp-support.c (add_symbol_overload_list_qualified): Update.
1295         * coffread.c (coff_symtab_read): Update.
1296         * ada-lang.c (add_nonlocal_symbols)
1297         (ada_collect_symbol_completion_matches)
1298         (ada_add_global_exceptions): Update.
1299
1300 2019-01-15  Tom Tromey  <tom@tromey.com>
1301
1302         * progspace.h (program_space) <objfiles_safe_range>: New
1303         typedef.
1304         <objfiles_safe>: New method.
1305         * objfiles.h (class all_objfiles_safe): Remove.
1306         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1307         * jit.c (jit_inferior_exit_hook): Update.
1308
1309 2019-01-17  Tom Tromey  <tom@tromey.com>
1310
1311         * progspace.h (program_space) <objfiles_range>: New typedef.
1312         <objfiles>: New method.
1313         <objfiles_head>: Rename from objfiles.
1314         (object_files): Update.
1315         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1316         * guile/scm-pretty-print.c
1317         (ppscm_find_pretty_printer_from_objfiles): Update.
1318         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1319         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1320         Update.
1321         * python/py-progspace.c (pspy_get_objfiles): Update.
1322         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1323         Update.
1324         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1325         (objfpy_lookup_objfile_by_build_id): Update.
1326         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1327         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1328         Update.
1329         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1330         (expand_symtab_containing_pc, lookup_objfile_from_block)
1331         (lookup_static_symbol, basic_lookup_transparent_type)
1332         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1333         (find_line_symtab, info_sources_command)
1334         (default_collect_symbol_completion_matches_break_on)
1335         (make_source_files_completion_list, find_main_name): Update.
1336         * symmisc.c (print_symbol_bcache_statistics)
1337         (print_objfile_statistics, maintenance_print_symbols)
1338         (maintenance_print_msymbols, maintenance_print_objfiles)
1339         (maintenance_info_symtabs, maintenance_check_symtabs)
1340         (maintenance_expand_symtabs, maintenance_info_line_tables):
1341         Update.
1342         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1343         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1344         (map_overlay_command, unmap_overlay_command)
1345         (simple_overlay_update, expand_symtabs_matching)
1346         (map_symbol_filenames): Update.
1347         * symfile-debug.c (set_debug_symfile): Update.
1348         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1349         Update.
1350         * source.c (select_source_symtab, forget_cached_source_info):
1351         Update.
1352         * solib.c (solib_read_symbols): Update.
1353         * solib-spu.c (append_ocl_sos): Update.
1354         * psymtab.c (maintenance_print_psymbols)
1355         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1356         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1357         * printcmd.c (info_symbol_command): Update.
1358         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1359         Update.
1360         * objfiles.h (class all_objfiles): Remove.
1361         * objfiles.c (have_partial_symbols, have_full_symbols)
1362         (have_minimal_symbols, qsort_cmp, update_section_map)
1363         (shared_objfile_contains_address_p)
1364         (default_iterate_over_objfiles_in_search_order): Update.
1365         * objc-lang.c (info_selectors_command, info_classes_command)
1366         (find_methods): Update.
1367         * minsyms.c (find_solib_trampoline_target): Update.
1368         * maint.c (maintenance_info_sections)
1369         (maintenance_translate_address, count_symtabs_and_blocks):
1370         Update.
1371         * main.c (captured_main_1): Update.
1372         * linux-thread-db.c (try_thread_db_load_from_pdir)
1373         (has_libpthread): Update.
1374         * linespec.c (iterate_over_all_matching_symtabs)
1375         (search_minsyms_for_name): Update.
1376         * jit.c (jit_find_objf_with_entry_addr): Update.
1377         * hppa-tdep.c (find_unwind_entry)
1378         (hppa_lookup_stub_minimal_symbol): Update.
1379         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1380         Update.
1381         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1382         (elf_gnu_ifunc_resolve_by_got): Update.
1383         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1384         * dwarf-index-write.c (save_gdb_index_command): Update.
1385         * cp-support.c (add_symbol_overload_list_qualified): Update.
1386         * breakpoint.c (create_overlay_event_breakpoint)
1387         (create_longjmp_master_breakpoint)
1388         (create_std_terminate_master_breakpoint)
1389         (create_exception_master_breakpoint): Update.
1390         * blockframe.c (find_pc_partial_function): Update.
1391         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1392         (ada_collect_symbol_completion_matches)
1393         (ada_add_global_exceptions): Update.
1394
1395 2019-01-17  Tom Tromey  <tom@tromey.com>
1396
1397         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1398         declare VEC.
1399         (solib_target_parse_libraries): Change return type.
1400         (library_list_start_segment, library_list_start_section)
1401         (library_list_end_library, library_list_start_library); Update.
1402         (solib_target_free_library_list): Remove.
1403         (solib_target_parse_libraries): Remove cleanup.  Change return
1404         type.
1405         (solib_target_current_sos): Update.
1406
1407 2019-01-17  Tom Tromey  <tromey@bapiya>
1408
1409         * valprint.c: Replace "the the" with "the".
1410         * symtab.c: Replace "the the" with "the".
1411         * solib.c: Replace "the the" with "the".
1412         * solib-dsbt.c: Replace "the the" with "the".
1413         * linespec.c: Replace "the the" with "the".
1414         * dwarf2loc.h: Replace "the the" with "the".
1415         * amd64-windows-tdep.c: Replace "the the" with "the".
1416         * aarch64-tdep.c: Replace "the the" with "the".
1417
1418 2019-01-16  Keith Seitz  <keiths@redhat.com>
1419
1420         PR gdb/23773
1421         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1422         <builder>: Rename to ..
1423         <m_builder>: ... this and make private.
1424         (dwarf2_cu::get_builder): New method.  Change all users of
1425         `builder' to use this method.
1426         (dwarf2_start_symtab): Move to ...
1427         (dwarf2_cu::start_symtab): ... here.  Update all callers
1428         (setup_type_unit_groups): Move to ...
1429         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1430         callers.
1431         (dwarf2_cu::reset_builder): New method.
1432         (process_full_compunit, process_full_type_unit): Use
1433         dwarf2_cu::reset_builder.
1434         (follow_die_offset): Record the ancestor CU if it is different
1435         from the followed DIE's CU.
1436         (follow_die_sig_1): Likewise.
1437
1438 2019-01-15  Tom Tromey  <tom@tromey.com>
1439
1440         * remote.c (class remote_state) <buf>: Now a char_vector.
1441         <buf_size>: Remove.
1442         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1443         parameter.
1444         (remote_target::getpkt_or_notif_sane_1)
1445         (remote_target::getpkt_sane)
1446         (remote_target::getpkt_or_notif_sane): Likewise.
1447         (class remote_target) <putpkt>: New overload.
1448         (remote_target::read_frame): Change type of "buf_p".  Remove
1449         sizeof_p parameter.
1450         (packet_ok): New overload.
1451         (packet_check_result): New overload.
1452         Update all uses.
1453
1454 2019-01-14  Tom Tromey  <tom@tromey.com>
1455
1456         * remote-notif.c (handle_notification, remote_notif_ack)
1457         (remote_notif_parse): Make "buf" const.
1458         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1459         const.
1460         (remote_notif_parse, remote_notif_ack, handle_notification):
1461         Likewise.
1462         * remote.c (remote_notif_stop_parse): Make "buf" const.
1463         (remote_target::remote_parse_stop_reply): Make "buf" const.
1464         (remote_notif_stop_ack): Make "buf" const.
1465
1466 2019-01-14  Tom Tromey  <tom@tromey.com>
1467
1468         * remote.c (remote_console_output): Make parameter const.
1469
1470 2019-01-14  Tom Tromey  <tom@tromey.com>
1471
1472         * target-debug.h (target_debug_print_signals): Constify.
1473         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1474         * procfs.c (procfs_target::pass_signals): Update.
1475         * linux-nat.c (linux_nat_target::pass_signals): Update.
1476         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1477         * target-delegates.c: Rebuild.
1478         * remote.c (remote_target::program_signals): Update.
1479         (remote_target::pass_signals): Update.
1480         * target.c (target_pass_signals): Constify argument.
1481         (target_program_signals): Likewise.
1482         * target.h (struct target_ops) <pass_signals, program_signals>:
1483         Constify argument.
1484         (target_pass_signals, target_program_signals): Constify argument.
1485
1486 2019-01-14  Tom Tromey  <tom@tromey.com>
1487
1488         PR tui/28819:
1489         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1490
1491 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1492
1493         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1494         field.
1495         * rs6000-tdep.c: Include reggroups.h.
1496         (IS_V_ALIAS_PSEUDOREG): Define.
1497         (rs6000_register_name): Return names for the "vX" aliases.
1498         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1499         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1500         aliases.  Call default_register_reggroup_p for all other
1501         pseudo-registers.
1502         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1503         New functions.
1504         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1505         Handle "vX" aliases.
1506         (v_alias_pseudo_register_collect): New function.
1507         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1508         (rs6000_gdbarch_init): Initialize "vX" aliases as
1509         pseudo-registers.  Restore registration of
1510         rs6000_pseudo_register_reggroup_p with
1511         set_tdesc_pseudo_register_reggroup_p.
1512
1513 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1514
1515         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1516         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1517         set_gdbarch_num_pseudo_regs.
1518
1519 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1520
1521         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1522         Remove arg prefixname, add do_set and do_show.
1523         Add member functions set_list and show_list.
1524         * cli/cli-style.c (class cli_style_option): Update accordingly.
1525         (style_set_list): Move to file scope.
1526         (style_show_list): Likewise.
1527         (set_style): Call help_list.
1528         (show_style): Call cmd_show_list.
1529         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1530         Update to use the new macro.
1531
1532 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1533
1534         * ada-lang.c (_initialize_ada_language): Expand the help text
1535         for the "catch exception" command.
1536
1537 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1538
1539         * symtab.c (matching_obj_sections): Initialize obj,
1540         declare it closer to its usage.
1541
1542 2019-01-10  Tom Tromey  <tom@tromey.com>
1543
1544         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1545         (basic_inf_threads_range): Remove.
1546         (inf_threads_range, inf_non_exited_threads_range)
1547         (safe_inf_threads_range): Use next_adapter.
1548
1549 2019-01-10  Keith Seitz  <keiths@redhat.com>
1550
1551         PR gdb/23712
1552         PR symtab/23010
1553         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1554         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1555
1556 2019-01-10  Keith Seitz  <keiths@redhat.com>
1557
1558         PR gdb/23712
1559         PR symtab/23010
1560         * dictionary.c (pending_to_vector): Remove.
1561         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1562         Remove _1 suffix, replacing functions of the same name.  Update
1563         all callers.
1564         (dict_create_hashed, dict_create_hashed_expandable)
1565         (dict_create_linear, dict_create_linear_expandable, dict_free)
1566         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1567         Make functions static.
1568
1569 2019-01-10  Keith Seitz  <keiths@redhat.com>
1570
1571         PR gdb/23712
1572         PR symtab/23010
1573         * dictionary.h (struct dictionary): Replace declaration with
1574         multidictionary.
1575         (dict_create_hashed, dict_create_hashed_expandable)
1576         (dict_create_linear, dict_create_linear_expandable)
1577         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1578         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1579         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1580         taking multidictionary argument.
1581         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1582         * block.h (struct block) <dict>: Change to multidictionary
1583         and rename `multidict'.
1584         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1585         symmisc.c: Update all dictionary references to multidictionary.
1586
1587 2019-01-10  Keith Seitz  <keiths@redhat.com>
1588
1589         PR gdb/23712
1590         PR symtab/23010
1591         * dictionary.c: Include unordered_map.
1592         (pending_to_vector): New function.
1593         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1594         Rewrite the non-"_1" functions to take vector instead
1595         of linked list.
1596         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1597         "new" _1 versions of the same name.
1598         (multidictionary): Define.
1599         (std::hash<enum language): New definition.
1600         (collate_pending_symbols_by_language, mdict_create_hashed)
1601         (mdict_create_hashed_expandable, mdict_create_linear)
1602         (mdict_create_linear_expandable, mdict_free)
1603         (find_language_dictionary, create_new_language_dictionary)
1604         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1605         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1606         (mdict_size, mdict_empty): New functions.
1607         * dictionary.h (mdict_iterator): Define.
1608
1609 2019-01-10  Pedro Alves  <palves@redhat.com>
1610
1611         * breakpoint.c (read_uploaded_action)
1612         (create_tracepoint_from_upload): Adjust to use
1613         gdb::unique_xmalloc_ptr.
1614         * ctf.c (ctf_write_uploaded_tp):
1615         (SET_ARRAY_FIELD): Use emplace_back.
1616         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1617         * tracefile-tfile.c (tfile_write_uploaded_tp):
1618         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1619         gdb::unique_xmalloc_ptr.
1620         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1621         at_string, cond_string, cmd_strings>: Replace char pointers
1622         with gdb::unique_xmalloc_ptr.
1623
1624 2019-01-10  Pedro Alves  <palves@redhat.com>
1625
1626         * solib-target.c (library_list_start_library): Don't xstrdup name.
1627
1628 2019-01-10  Pedro Alves  <palves@redhat.com>
1629
1630         * mdebugread.c (parse_partial_symbols): Use
1631         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1632
1633 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1634
1635         * linux-fork.c (scoped_switch_fork_info)
1636         <~scoped_switch_fork_info>: Fix incorrect variable name.
1637
1638 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1639
1640         * linux-fork.c (scoped_switch_fork_info)
1641         <scoped_switch_fork_info>: Make explicit.
1642         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1643
1644 2019-01-10  Tom Tromey  <tom@tromey.com>
1645
1646         * objfiles.h (objfile::reset_psymtabs): Update.
1647         * objfiles.c (objfile::objfile): Update.
1648         * psymtab.h (psymtab_storage::obstack): Update.
1649         (psymtab_storage::m_obstack): Use gdb::optional.
1650         (class psymtab_storage): Update comment.  Remove objfile
1651         parameter.
1652         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1653
1654 2019-01-10  Tom Tromey  <tom@tromey.com>
1655
1656         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1657         <free_psymtabs>: Now private.
1658         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1659         (allocate_psymtab): Use new method.
1660
1661 2019-01-10  Tom Tromey  <tom@tromey.com>
1662
1663         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1664         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1665         * mdebugread.c (parse_partial_symbols): Use
1666         allocate_dependencies.
1667         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1668         allocate_dependencies.
1669         (process_psymtab_comp_unit_reader)
1670         (build_type_psymtab_dependencies): Likewise.
1671         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1672
1673 2019-01-10  Tom Tromey  <tom@tromey.com>
1674
1675         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1676         PSYMBOL_SET_LANGUAGE.
1677         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1678
1679 2019-01-10  Tom Tromey  <tom@tromey.com>
1680
1681         * psymtab.h (psymtab_storage::obstack): New method.
1682         <m_obstack>: Rename from obstack; now private.
1683         * psymtab.c (psymtab_storage): Update.
1684         * dwarf2read.c (create_addrmap_from_index)
1685         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1686         Update.
1687
1688 2019-01-10  Tom Tromey  <tom@tromey.com>
1689
1690         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1691         * objfiles.h (objfile::reset_psymtabs): New method.
1692
1693 2019-01-10  Tom Tromey  <tom@tromey.com>
1694
1695         * symmisc.c (print_symbol_bcache_statistics): Update.
1696         (print_objfile_statistics): Update.
1697         * symfile.c (reread_symbols): Update.
1698         * psymtab.h (class psymtab_storage): New.
1699         * psymtab.c (psymtab_storage): New constructor.
1700         (~psymtab_storage): New destructor.
1701         (require_partial_symbols): Update.
1702         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1703         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1704         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1705         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1706         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1707         (start_psymtab_common, end_psymtab_common)
1708         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1709         (allocate_psymtab): Update.
1710         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1711         Update.
1712         (dump_psymtab_addrmap, maintenance_print_psymbols)
1713         (maintenance_check_psymtabs): Update.
1714         (class objfile_psymtabs): Move to objfiles.h.
1715         * psympriv.h (discard_psymtab): Now inline.
1716         (psymtab_discarder::psymtab_discarder): Update.
1717         (psymtab_discarder::~psymtab_discarder): Update.
1718         (ALL_OBJFILE_PSYMTABS): Rewrite.
1719         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1720         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1721         Remove fields.
1722         <partial_symtabs>: New field.
1723         (class objfile_psymtabs): Move from psymtab.h.  Update.
1724         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1725         psymbol_cache.
1726         (objfile::~objfile): Don't destroy psymbol_cache.
1727         * mdebugread.c (parse_partial_symbols): Update.
1728         * dwarf2read.c (create_addrmap_from_index)
1729         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1730         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1731         (add_partial_subprogram, dwarf2_ranges_read): Update.
1732         * dwarf-index-write.c (write_address_map)
1733         (write_one_signatured_type, recursively_write_psymbols)
1734         (class debug_names, class debug_names, write_psymtabs_to_index):
1735         Update.
1736
1737 2019-01-10  Tom Tromey  <tom@tromey.com>
1738
1739         * symtab.h (SYMBOL_SET_NAMES): Update.
1740         (symbol_set_names): Update.
1741         (MSYMBOL_SET_NAMES): Update.
1742         * symtab.c (symbol_set_names): Change argument to be an
1743         objfile_per_bfd_storage.
1744         * psymtab.c (add_psymbol_to_bcache): Update.
1745         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1746
1747 2019-01-10  Tom Tromey  <tom@tromey.com>
1748
1749         * symtab.c (create_demangled_names_hash): Change argument to be an
1750         objfile_per_bfd_storage.
1751         (symbol_set_names): Update.
1752
1753 2019-01-10  Tom Tromey  <tom@tromey.com>
1754
1755         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1756         init_psymbol_list.
1757         * psymtab.c (init_psymbol_list): Do nothing if already called.
1758         * psympriv.h (init_psymbol_list): Add comment.
1759         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1760         init_psymbol_list.
1761         * dbxread.c (dbx_symfile_read): Unconditionally call
1762         init_psymbol_list.
1763
1764 2019-01-10  Tom Tromey  <tom@tromey.com>
1765
1766         * xcoffread.c (scan_xcoff_symtab): Update.
1767         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1768         "where".
1769         * mdebugread.c (parse_partial_symbols)
1770         (handle_psymbol_enumerators): Update.
1771         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1772         * dbxread.c (read_dbx_symtab): Update.
1773         * psympriv.h (psymbol_placement): New enum.
1774         (add_psymbol_to_list): Update.
1775
1776 2019-01-10  Tom Tromey  <tom@tromey.com>
1777
1778         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1779         static_psymbols parameters.
1780         (scan_xcoff_symtab): Update.
1781         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1782         static_psymbols parameters.
1783         * psympriv.h (start_psymtab_common): Update.
1784         * mdebugread.c (parse_partial_symbols): Update.
1785         * dwarf2read.c (create_partial_symtab): Update.
1786         * dbxread.c (read_dbx_symtab): Update.
1787         (start_psymtab): Remove global_psymbols and static_psymbols
1788         parameters.
1789
1790 2019-01-10  Tom Tromey  <tom@tromey.com>
1791
1792         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1793         * psymtab.c (allocate_psymtab): Add comment.
1794         * psympriv.h (allocate_psymtab): Add comment.
1795         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1796         initializations.
1797         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1798
1799 2019-01-10  Tom Tromey  <tom@tromey.com>
1800
1801         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1802         Don't declare.
1803         * mipsread.c: Include mdebugread.h.
1804         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1805         Declare.
1806         * elfread.c: Include mdebugread.h.
1807
1808 2019-01-09  Tom Tromey  <tom@tromey.com>
1809
1810         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1811         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1812         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1813         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1814         (psym_lookup_symbol, psym_find_last_source_symtab)
1815         (psym_forget_cached_source_info, psym_print_stats)
1816         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1817         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1818         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1819         (psym_find_compunit_symtab_by_address)
1820         (maintenance_print_psymbols, maintenance_info_psymtabs)
1821         (maintenance_check_psymtabs): Use ranged for.
1822         * psymtab.h (class objfile_psymtabs): New.
1823         (require_partial_symbols): Return objfile_psymtabs.
1824         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1825
1826 2019-01-09  Tom Tromey  <tom@tromey.com>
1827
1828         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1829         (find_pc_mapped_section, list_overlays_command)
1830         (map_overlay_command, unmap_overlay_command)
1831         (simple_overlay_update): Use all_objfiles.
1832         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1833         * printcmd.c (info_symbol_command): Use all_objfiles.
1834         * objfiles.h (ALL_OBJSECTIONS): Remove.
1835         * maint.c (maintenance_translate_address): Use all_objfiles.
1836         * gcore.c (gcore_create_callback): Use all_objfiles.
1837         (objfile_find_memory_regions): Likewise.
1838
1839 2019-01-09  Tom Tromey  <tom@tromey.com>
1840
1841         * symtab.c (find_line_symtab, info_sources_command)
1842         (make_source_files_completion_list): Use objfile_compunits.
1843         * source.c (select_source_symtab): Use objfile_compunits.
1844         * objfiles.h (struct objfile): Update comment.
1845         (ALL_OBJFILES): Remove.
1846         (ALL_FILETABS): Remove.
1847         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1848         objfile_compunits.
1849
1850 2019-01-09  Tom Tromey  <tom@tromey.com>
1851
1852         * symmisc.c (print_objfile_statistics, dump_objfile)
1853         (maintenance_print_symbols): Use compunit_filetabs.
1854         * source.c (forget_cached_source_info_for_objfile): Use
1855         compunit_filetabs.
1856         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1857         (ALL_FILETABS): Use compunit_filetabs.
1858         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1859         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1860
1861 2019-01-09  Tom Tromey  <tom@tromey.com>
1862
1863         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1864         (compunit_filetabs): New.
1865         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1866         compunit_filetabs.
1867         (info_sources_command, make_source_files_completion_list): Remove
1868         declaration.
1869         * symmisc.c (print_objfile_statistics, dump_objfile)
1870         (maintenance_print_symbols): Remove declaration.
1871         (maintenance_info_symtabs): Use compunit_filetabs.
1872         (maintenance_info_line_tables): Likewise.
1873         * source.c (select_source_symtab): Change local variable name.
1874         (forget_cached_source_info_for_objfile): Remove declaration.
1875         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1876         * objfiles.c (objfile_relocate1): Remove declaration.
1877         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1878         declaration.
1879         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1880         * coffread.c (coff_symtab_read): Remove declaration.
1881         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1882         compunit_filetabs.
1883
1884 2019-01-09  Tom Tromey  <tom@tromey.com>
1885
1886         * symtab.c (lookup_objfile_from_block)
1887         (find_pc_sect_compunit_symtab, search_symbols)
1888         (default_collect_symbol_completion_matches_break_on): Use
1889         objfile_compunits.
1890         * objfiles.h (ALL_COMPUNITS): Remove.
1891         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1892         * cp-support.c (add_symbol_overload_list_qualified): Use
1893         objfile_compunits.
1894         * ada-lang.c (ada_collect_symbol_completion_matches)
1895         (ada_add_global_exceptions): Use objfile_compunits.
1896
1897 2019-01-09  Tom Tromey  <tom@tromey.com>
1898
1899         * source.c (select_source_symtab)
1900         (forget_cached_source_info_for_objfile): Remove declaration.
1901         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1902         declaration.
1903         * maint.c (count_symtabs_and_blocks): Remove declaration.
1904         * cp-support.c (add_symbol_overload_list_qualified): Remove
1905         declaration.
1906         * coffread.c (coff_symtab_read): Remove declaration.
1907         * symtab.c (lookup_symbol_in_objfile_symtabs)
1908         (basic_lookup_transparent_type_1): Use objfile_compunits.
1909         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1910         (info_sources_command, search_symbols)
1911         (default_collect_symbol_completion_matches_break_on)
1912         (make_source_files_completion_list): Remove declaration.
1913         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1914         (ada_collect_symbol_completion_matches)
1915         (ada_add_global_exceptions): Remove declaration.
1916         * linespec.c (iterate_over_all_matching_symtabs): Use
1917         objfile_compunits.
1918         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1919         (class objfile_compunits): New.
1920         (ALL_COMPUNITS): Use objfile_compunits.
1921         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1922         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1923         objfile_compunits.
1924         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1925
1926 2019-01-09  Tom Tromey  <tom@tromey.com>
1927
1928         * symtab.c (search_symbols)
1929         (default_collect_symbol_completion_matches_break_on): Use
1930         objfile_msymbols.
1931         * ada-lang.c (ada_lookup_simple_minsym)
1932         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1933         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1934         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1935         objfile_msymbols.
1936         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1937         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1938         * objc-lang.c (find_methods): Use objfile_msymbols.
1939         (info_selectors_command, info_classes_command): Likewise.
1940         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1941         * objfiles.h (class objfile_msymbols): New.
1942         (ALL_OBJFILE_MSYMBOLS): Remove.
1943         (ALL_MSYMBOLS): Remove.
1944
1945 2019-01-09  Tom Tromey  <tom@tromey.com>
1946
1947         * common/next-iterator.h (next_adapter): Add Iterator template
1948         parameter.
1949         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1950         (class all_objfiles_safe): New.
1951         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1952         * objfiles.c (put_objfile_before): Update comment.
1953         (add_separate_debug_objfile): Likewise.
1954         (free_all_objfiles): Use all_objfiles_safe.
1955         (objfile_purge_solibs): Likewise.
1956
1957 2019-01-09  Tom Tromey  <tom@tromey.com>
1958
1959         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1960         (expand_symtab_containing_pc, lookup_static_symbol)
1961         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1962         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1963         all_objfiles.
1964         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1965         * breakpoint.c (create_overlay_event_breakpoint)
1966         (create_longjmp_master_breakpoint)
1967         (create_std_terminate_master_breakpoint)
1968         (create_exception_master_breakpoint): Use all_objfiles.
1969         * linux-thread-db.c (try_thread_db_load_from_pdir)
1970         (has_libpthread): Use all_objfiles.
1971         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1972         * linespec.c (iterate_over_all_matching_symtabs)
1973         (search_minsyms_for_name): Use all_objfiles.
1974         * maint.c (maintenance_info_sections): Use all_objfiles.
1975         * main.c (captured_main_1): Use all_objfiles.
1976         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1977         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1978         * guile/scm-pretty-print.c
1979         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1980         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1981         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1982         (maintenance_print_msymbols): Use all_objfiles.
1983         * source.c (select_source_symtab): Use all_objfiles.
1984         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1985         * symfile.c (remove_symbol_file_command)
1986         (expand_symtabs_matching, map_symbol_filenames): Use
1987         all_objfiles.
1988         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1989         all_objfiles.
1990         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1991         * objc-lang.c (find_methods): Use all_objfiles.
1992         * objfiles.c (have_partial_symbols, have_full_symbols)
1993         (have_minimal_symbols, qsort_cmp)
1994         (default_iterate_over_objfiles_in_search_order): Use
1995         all_objfiles.
1996         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1997         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1998         (maintenance_check_psymtabs): Use all_objfiles.
1999         (ALL_PSYMTABS): Remove.
2000         * compile/compile-object-run.c (do_module_cleanup): Use
2001         all_objfiles.
2002         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2003         * cp-support.c (add_symbol_overload_list_qualified): Use
2004         all_objfiles.
2005         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2006         Use all_objfiles.
2007         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2008         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2009         all_objfiles.
2010         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2011         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2012         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2013         Uses all_objfiles.
2014         * solib.c (solib_read_symbols): Use all_objfiles
2015
2016 2019-01-09  Tom Tromey  <tom@tromey.com>
2017
2018         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2019         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2020         all_objfiles.
2021         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2022         * symmisc.c (print_symbol_bcache_statistics)
2023         (print_objfile_statistics, maintenance_print_objfiles)
2024         (maintenance_info_symtabs, maintenance_check_symtabs)
2025         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2026         all_objfiles.
2027         * source.c (forget_cached_source_info): Use all_objfiles.
2028         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2029         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2030         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2031         * objfiles.c (update_section_map): Use all_objfiles.
2032         (shared_objfile_contains_address_p): Likewise.
2033         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2034         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2035
2036 2019-01-09  Tom Tromey  <tom@tromey.com>
2037
2038         * common/next-iterator.h: New file.
2039         * objfiles.h (class all_objfiles): New.
2040         (struct objfile_iterator): New.
2041
2042 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2043
2044         * NEWS: Move the description of the changed "frame", "select-frame",
2045          and "info frame" commands to the Changed commands section.
2046
2047 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2048
2049         * gdbtypes.c (check_stub_method_group): Remove handling of old
2050         mangling schemes.
2051         * linespec.c (find_methods): Likewise.
2052         * stabsread.c (read_member_functions): Likewise.
2053         * valops.c (search_struct_method): Likewise.
2054         (value_struct_elt_for_reference): Likewise.
2055         * NEWS: Mention this change.
2056
2057 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2058
2059         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2060         print_source_lines.
2061         * source.c (print_source_lines_base): Update line number check.
2062         (print_source_lines): New function.
2063         (source_lines_range::source_lines_range): New function.
2064         * source.h (class source_lines_range): New class.
2065         (print_source_lines): New declaration.
2066
2067 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2068
2069         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2070
2071 2019-01-08  Tom Tromey  <tom@tromey.com>
2072             Simon Marchi  <simon.marchi@ericsson.com>
2073
2074         PR gdb/24060
2075         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2076         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2077         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2078         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2079         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2080         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2081
2082 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2083
2084         * source.c (select_source_symtab): Move header comment to
2085         declaration in source.h.
2086         (forget_cached_source_info_for_objfile): Likewise.
2087         (forget_cached_source_info): Likewise.
2088         (identify_source_line): Likewise.
2089         * source.h (identify_source_line): Move declaration from symtab.h
2090         and add comment from source.c
2091         (print_source_lines): Likewise.
2092         (forget_cached_source_info_for_objfile): Likewise.
2093         (forget_cached_source_info): Likewise.
2094         (select_source_symtab): Likewise.
2095         (enum print_source_lines_flag): Move definition from symtab.h.
2096         * symtab.h (identify_source_line): Move declaration to source.h.
2097         (print_source_lines): Likewise.
2098         (forget_cached_source_info_for_objfile): Likewise.
2099         (forget_cached_source_info): Likewise.
2100         (select_source_symtab): Likewise.
2101         (enum print_source_lines_flag): Move definition to source.h.
2102         * tui/tui-hooks.c: Add 'source.h' include.
2103
2104 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2105
2106         * source.c (print_source_lines_base): Handle requests to print
2107         reverse line number sequences, and guard against empty lines
2108         string.
2109
2110 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2111
2112         * source.c (print_source_lines_base): Fix skip of '\r' if next
2113         character is '\n'.
2114
2115 2019-01-06  Tom Tromey  <tom@tromey.com>
2116
2117         * c-exp.y (struct c_parse_state) <macro_original_text,
2118         expansion_obstack>: New member.
2119         (macro_original_text, expansion_obstack): Remove globals.
2120         (scan_macro_expansion, scanning_macro_expansion)
2121         (finished_macro_expansion): Update.
2122         (scan_macro_cleanup): Remove.
2123         (yylex, c_parse): Update.
2124
2125 2019-01-06  Tom Tromey  <tom@tromey.com>
2126
2127         * c-exp.y (struct c_parse_state) <strings>: New member.
2128         (operator_stoken): Update.
2129
2130 2019-01-06  Tom Tromey  <tom@tromey.com>
2131
2132         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2133         (union type_stack_elt) <typelist_val>: Now a pointer to
2134         std::vector.
2135         (type_stack_cleanup): Don't declare.
2136         (push_typelist): Update.
2137         * parse.c (pop_typelist): Return a std::vector.
2138         (push_typelist): Take a std::vector.
2139         (follow_types): Update.  Do not free args.
2140         (type_stack_cleanup): Remove.
2141         * c-exp.y (struct c_parse_state): New.
2142         (cpstate): New global.
2143         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2144         (nonempty_typelist): Update.
2145         (func_mod): Create a new vector.
2146         (c_parse): Create a c_parse_state.
2147         (check_parameter_typelist): Do not delete params.
2148         (function_method): Update.  Do not delete type_list.
2149
2150 2019-01-06  Tom Tromey  <tom@tromey.com>
2151
2152         PR gdb/28155:
2153         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2154         check_typedef.
2155         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2156         (print_return_value): Likewise.
2157
2158 2019-01-05  Tom Tromey  <tom@tromey.com>
2159
2160         * contrib/cleanup_check.py: Remove.
2161         * contrib/gcc-with-excheck: Remove.
2162         * contrib/exsummary.py: Remove.
2163         * contrib/excheck.py: Remove.
2164
2165 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2166
2167         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2168         NULL. Initialize tpprev to NULL instead of assigning it
2169         to NULL on the next statement.
2170         * windows-nat.c (windows_delete_thread): Remove check for
2171         main_thread_id before printing thread exit notifications.
2172         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2173         Remove thread ID check against main_thread_id.
2174         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2175         windows_delete_thread.
2176         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2177
2178 2019-01-04  Tom Tromey  <tom@tromey.com>
2179
2180         * compile/compile.c (_initialize_compile): Use upper case for
2181         metasyntactic variables.
2182         * symmisc.c (_initialize_symmisc): Use upper case for
2183         metasyntactic variables.
2184         * psymtab.c (_initialize_psymtab): Use upper case for
2185         metasyntactic variables.
2186         * demangle.c (demangle_command): Use upper case for metasyntactic
2187         variables.
2188         (_initialize_demangler): Likewise.
2189         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2190         variables.
2191
2192 2019-01-03  Tom Tromey  <tom@tromey.com>
2193
2194         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2195
2196 2019-01-03  Tom Tromey  <tom@tromey.com>
2197
2198         * python/py-symtab.c (salpy_str): Update.
2199         (struct salpy_sal_object) <symtab>: Now a PyObject.
2200         (salpy_dealloc): Update.
2201         (del_objfile_sal): Use gdbpy_ref.
2202
2203 2019-01-03  Tom Tromey  <tom@tromey.com>
2204
2205         * python/py-type.c (convert_field): Use new_reference.  Return
2206         gdbpy_ref.
2207         (make_fielditem): Return gdbpy_ref.
2208         (typy_fields): Update.
2209         (typy_getitem): Update.
2210         (field_name): Return gdbpy_ref.  Use new_reference.
2211         (typy_iterator_iternext): Update.
2212
2213 2019-01-03  Tom Tromey  <tom@tromey.com>
2214
2215         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2216
2217 2019-01-03  Tom Tromey  <tom@tromey.com>
2218
2219         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2220         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2221         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2222         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2223         (pspy_set_type_printers): Likewise.
2224         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2225         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2226         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2227         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2228         (objfpy_set_type_printers): Likewise.
2229
2230 2019-01-03  Tom Tromey  <tom@tromey.com>
2231
2232         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2233         (gdbpy_print_stack): Use gdbpy_err_fetch.
2234         * python/python-internal.h (class gdbpy_err_fetch): New class.
2235         (class gdbpy_enter) <m_error_type, m_error_value,
2236         m_error_traceback>: Remove.
2237         <m_error>: New member.
2238         (gdbpy_exception_to_string): Don't declare.
2239         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2240         * python/py-value.c (convert_value_from_python): Use
2241         gdbpy_err_fetch.
2242         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2243         gdbpy_exception_to_string.
2244         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2245         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2246         gdbpy_err_fetch.
2247
2248 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2249
2250         * linux-nat.c (delete_lwp_cleanup): Delete.
2251         (struct lwp_deleter): New struct.
2252         (lwp_info_up): New typedef.
2253         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2254         lwp_info_up.
2255
2256 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2257
2258         * linux-fork.c (class scoped_switch_fork_info): New class.
2259         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2260
2261 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2262
2263         * valops.c (find_overload_match): Remove use of null_cleanup, and
2264         calls to do_cleanups.
2265
2266 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2267
2268         * compile/compile-cplus-types.c
2269         (compile_cplus_instance::decl_name): Handle changes to
2270         cp_func_name.
2271         * cp-support.c (cp_func_name): Update header comment, update
2272         return type.
2273         * cp-support.h (cp_func_name): Update return type in declaration.
2274         * valops.c (find_overload_match): Move temp_func local to top
2275         level of function and change its type.  Use temp_func to hold and
2276         delete temporary string obtained from cp_func_name.
2277
2278 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2279
2280         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2281         gdb::char_vector, remove cleanup, and update uses of `msg`.
2282
2283 2019-01-03  Jim Wilson  <jimw@sifive.com>
2284
2285         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2286
2287 2019-01-02  Tom Tromey  <tom@tromey.com>
2288
2289         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2290         (tdesc_parse_xml): Remove cleanups.
2291         * target-descriptions.h (make_cleanup_free_target_description):
2292         Don't declare.
2293         (target_desc_deleter): New struct.
2294         (target_desc_up): New typedef.
2295         * target-descriptions.c (target_desc_deleter::operator()): Rename
2296         from free_target_description.
2297         (make_cleanup_free_target_description): Remove.
2298
2299 2019-01-02  Tom Tromey  <tom@tromey.com>
2300
2301         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2302         constructor, destructor.
2303         (linespec_parser): Remove typedef.
2304         (~linespec_parser): Rename from linespec_parser_delete.
2305         (linespec_lex_to_end, linespec_complete_label)
2306         (linespec_complete): Update.
2307         (decode_line_full): Remove cleanups.
2308         (decode_line_1): Update.
2309
2310 2019-01-02  Tom Tromey  <tom@tromey.com>
2311
2312         * python/python-internal.h (inferior_to_inferior_object): Change
2313         return type.
2314         * python/py-exitedevent.c (create_exited_event_object): Update.
2315         * python/py-inferior.c (inferior_to_inferior_object): Return
2316         gdbpy_ref.
2317         (python_new_inferior, python_inferior_deleted)
2318         (thread_to_thread_object, delete_thread_object)
2319         (build_inferior_list, gdbpy_selected_inferior): Update.
2320         * python/py-infthread.c (create_thread_object): Update.  Also fail
2321         if inferior_to_inferior_object fails.
2322
2323 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2324
2325         * inferior.h (class inferior) <displaced_step_state>: New field.
2326         * infrun.h (struct displaced_step_state): Move here from
2327         infrun.c.  Initialize fields, add constructor.
2328         <inf>: Remove field.
2329         <reset>: New method.
2330         * infrun.c (struct displaced_step_inferior_state): Move to
2331         infrun.h.
2332         (displaced_step_inferior_states): Remove.
2333         (get_displaced_stepping_state): Adust.
2334         (displaced_step_in_progress_any_inferior): Adjust.
2335         (displaced_step_in_progress_thread): Adjust.
2336         (displaced_step_in_progress): Adjust.
2337         (add_displaced_stepping_state): Remove.
2338         (get_displaced_step_closure_by_addr): Adjust.
2339         (remove_displaced_stepping_state): Remove.
2340         (infrun_inferior_exit): Call displaced_step_state.reset.
2341         (use_displaced_stepping): Don't check for NULL.
2342         (displaced_step_prepare_throw): Call
2343         get_displaced_stepping_state.
2344         (displaced_step_fixup): Don't check for NULL.
2345         (prepare_for_detach): Don't check for NULL.
2346
2347 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2348
2349         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2350          in case of call that did not complete.
2351
2352 2019-01-02  Andrey Utkin  <autkin@undo.io>
2353
2354         * symfile.c (find_separate_debug_file): Fix search of debug files for
2355         remote debuggee.
2356
2357 2019-01-02  Tom Tromey  <tom@tromey.com>
2358
2359         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2360         indentation.
2361         * python/py-frame.c (frapy_older): Remove cast.
2362         (frapy_newer): Likewise.
2363         * python/py-breakpoint.c (local_setattro): Remove cast.
2364         * python/py-arch.c (archpy_name): Remove local variable.
2365         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2366
2367 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2368
2369         * unittests/basic_string_view/element_access/char/empty.cc:
2370         Fix year range in copyright header.
2371
2372 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2373
2374         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2375         Delete.
2376         <operator==>: Update with for removed field.
2377         <hash>: Likewise.
2378         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2379         <isa_features>: ...this.
2380         <abi_features>: New field.
2381         (riscv_isa_flen): Update comment.
2382         (riscv_abi_xlen): New declaration.
2383         (riscv_abi_flen): New declaration.
2384         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2385         isa_features.
2386         (riscv_abi_xlen): New function.
2387         (riscv_isa_flen): Update to get answer from isa_features.
2388         (riscv_abi_flen): New function.
2389         (riscv_has_fp_abi): Update to get answer from abi_features.
2390         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2391         xlen and flen.
2392         (riscv_call_info) <xlen, flen>: Update comment.
2393         (riscv_call_arg_struct): Remove invalid assertions
2394         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2395         is removed.
2396         (riscv_gdbarch_init): Gather isa features and abi features
2397         separately, ensure both match on the gdbarch when reusing an old
2398         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2399         a target with 64-bit float hardware.
2400
2401 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2402
2403         * source.c (search_command_helper): Stop reverse search
2404         when line 1 has been searched.
2405
2406 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2407
2408         * record-full.c (record_full_base_target::close): Rewrite
2409         record_full_core_buf_list free logic.
2410
2411 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2412
2413         * break-catch-syscall.c (print_one_catch_syscall): xfree
2414         the last text.
2415
2416 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2417
2418         * top.c (print_gdb_version): Update Copyright year in version
2419         message.
2420
2421 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2422
2423         Update copyright year range in all GDB files.
2424
2425 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2426
2427         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2428
2429 For older changes see ChangeLog-2018.
2430 \f
2431 Local Variables:
2432 mode: change-log
2433 left-margin: 8
2434 fill-column: 74
2435 version-control: never
2436 coding: utf-8
2437 End:
2438