gdb/ChangeLog

   1 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
   2
   3         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
   4         field.
   5         * rs6000-tdep.c: Include reggroups.h.
   6         (IS_V_ALIAS_PSEUDOREG): Define.
   7         (rs6000_register_name): Return names for the "vX" aliases.
   8         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
   9         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
  10         aliases.  Call default_register_reggroup_p for all other
  11         pseudo-registers.
  12         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
  13         New functions.
  14         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
  15         Handle "vX" aliases.
  16         (v_alias_pseudo_register_collect): New function.
  17         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
  18         (rs6000_gdbarch_init): Initialize "vX" aliases as
  19         pseudo-registers.  Restore registration of
  20         rs6000_pseudo_register_reggroup_p with
  21         set_tdesc_pseudo_register_reggroup_p.
  22
  23 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
  24
  25         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
  26         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
  27         set_gdbarch_num_pseudo_regs.
  28
  29 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  30
  31         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
  32         Remove arg prefixname, add do_set and do_show.
  33         Add member functions set_list and show_list.
  34         * cli/cli-style.c (class cli_style_option): Update accordingly.
  35         (style_set_list): Move to file scope.
  36         (style_show_list): Likewise.
  37         (set_style): Call help_list.
  38         (show_style): Call cmd_show_list.
  39         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
  40         Update to use the new macro.
  41
  42 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
  43
  44         * ada-lang.c (_initialize_ada_language): Expand the help text
  45         for the "catch exception" command.
  46
  47 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  48
  49         * symtab.c (matching_obj_sections): Initialize obj,
  50         declare it closer to its usage.
  51
  52 2019-01-10  Tom Tromey  <tom@tromey.com>
  53
  54         * thread-iter.h (inf_threads_iterator): Use next_iterator.
  55         (basic_inf_threads_range): Remove.
  56         (inf_threads_range, inf_non_exited_threads_range)
  57         (safe_inf_threads_range): Use next_adapter.
  58
  59 2019-01-10  Keith Seitz  <keiths@redhat.com>
  60
  61         PR gdb/23712
  62         PR symtab/23010
  63         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
  64         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
  65
  66 2019-01-10  Keith Seitz  <keiths@redhat.com>
  67
  68         PR gdb/23712
  69         PR symtab/23010
  70         * dictionary.c (pending_to_vector): Remove.
  71         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
  72         Remove _1 suffix, replacing functions of the same name.  Update
  73         all callers.
  74         (dict_create_hashed, dict_create_hashed_expandable)
  75         (dict_create_linear, dict_create_linear_expandable, dict_free)
  76         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
  77         Make functions static.
  78
  79 2019-01-10  Keith Seitz  <keiths@redhat.com>
  80
  81         PR gdb/23712
  82         PR symtab/23010
  83         * dictionary.h (struct dictionary): Replace declaration with
  84         multidictionary.
  85         (dict_create_hashed, dict_create_hashed_expandable)
  86         (dict_create_linear, dict_create_linear_expandable)
  87         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
  88         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
  89         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
  90         taking multidictionary argument.
  91         [ALL_DICT_SYMBOLS]: Update for multidictionary.
  92         * block.h (struct block) <dict>: Change to multidictionary
  93         and rename `multidict'.
  94         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
  95         symmisc.c: Update all dictionary references to multidictionary.
  96
  97 2019-01-10  Keith Seitz  <keiths@redhat.com>
  98
  99         PR gdb/23712
 100         PR symtab/23010
 101         * dictionary.c: Include unordered_map.
 102         (pending_to_vector): New function.
 103         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 104         Rewrite the non-"_1" functions to take vector instead
 105         of linked list.
 106         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
 107         "new" _1 versions of the same name.
 108         (multidictionary): Define.
 109         (std::hash<enum language): New definition.
 110         (collate_pending_symbols_by_language, mdict_create_hashed)
 111         (mdict_create_hashed_expandable, mdict_create_linear)
 112         (mdict_create_linear_expandable, mdict_free)
 113         (find_language_dictionary, create_new_language_dictionary)
 114         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
 115         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
 116         (mdict_size, mdict_empty): New functions.
 117         * dictionary.h (mdict_iterator): Define.
 118
 119 2019-01-10  Pedro Alves  <palves@redhat.com>
 120
 121         * breakpoint.c (read_uploaded_action)
 122         (create_tracepoint_from_upload): Adjust to use
 123         gdb::unique_xmalloc_ptr.
 124         * ctf.c (ctf_write_uploaded_tp):
 125         (SET_ARRAY_FIELD): Use emplace_back.
 126         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
 127         * tracefile-tfile.c (tfile_write_uploaded_tp):
 128         * tracepoint.c (parse_tracepoint_definition): Adjust to use
 129         gdb::unique_xmalloc_ptr.
 130         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
 131         at_string, cond_string, cmd_strings>: Replace char pointers
 132         with gdb::unique_xmalloc_ptr.
 133
 134 2019-01-10  Pedro Alves  <palves@redhat.com>
 135
 136         * solib-target.c (library_list_start_library): Don't xstrdup name.
 137
 138 2019-01-10  Pedro Alves  <palves@redhat.com>
 139
 140         * mdebugread.c (parse_partial_symbols): Use
 141         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
 142
 143 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 144
 145         * linux-fork.c (scoped_switch_fork_info)
 146         <~scoped_switch_fork_info>: Fix incorrect variable name.
 147
 148 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 149
 150         * linux-fork.c (scoped_switch_fork_info)
 151         <scoped_switch_fork_info>: Make explicit.
 152         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
 153
 154 2019-01-10  Tom Tromey  <tom@tromey.com>
 155
 156         * objfiles.h (objfile::reset_psymtabs): Update.
 157         * objfiles.c (objfile::objfile): Update.
 158         * psymtab.h (psymtab_storage::obstack): Update.
 159         (psymtab_storage::m_obstack): Use gdb::optional.
 160         (class psymtab_storage): Update comment.  Remove objfile
 161         parameter.
 162         * psymtab.c (psymtab_storage::psymtab_storage): Update.
 163
 164 2019-01-10  Tom Tromey  <tom@tromey.com>
 165
 166         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
 167         <free_psymtabs>: Now private.
 168         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
 169         (allocate_psymtab): Use new method.
 170
 171 2019-01-10  Tom Tromey  <tom@tromey.com>
 172
 173         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
 174         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
 175         * mdebugread.c (parse_partial_symbols): Use
 176         allocate_dependencies.
 177         * dwarf2read.c (dwarf2_create_include_psymtab): Use
 178         allocate_dependencies.
 179         (process_psymtab_comp_unit_reader)
 180         (build_type_psymtab_dependencies): Likewise.
 181         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
 182
 183 2019-01-10  Tom Tromey  <tom@tromey.com>
 184
 185         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
 186         PSYMBOL_SET_LANGUAGE.
 187         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
 188
 189 2019-01-10  Tom Tromey  <tom@tromey.com>
 190
 191         * psymtab.h (psymtab_storage::obstack): New method.
 192         <m_obstack>: Rename from obstack; now private.
 193         * psymtab.c (psymtab_storage): Update.
 194         * dwarf2read.c (create_addrmap_from_index)
 195         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
 196         Update.
 197
 198 2019-01-10  Tom Tromey  <tom@tromey.com>
 199
 200         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
 201         * objfiles.h (objfile::reset_psymtabs): New method.
 202
 203 2019-01-10  Tom Tromey  <tom@tromey.com>
 204
 205         * symmisc.c (print_symbol_bcache_statistics): Update.
 206         (print_objfile_statistics): Update.
 207         * symfile.c (reread_symbols): Update.
 208         * psymtab.h (class psymtab_storage): New.
 209         * psymtab.c (psymtab_storage): New constructor.
 210         (~psymtab_storage): New destructor.
 211         (require_partial_symbols): Update.
 212         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
 213         (find_pc_sect_psymtab, find_pc_sect_psymbol)
 214         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
 215         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
 216         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
 217         (start_psymtab_common, end_psymtab_common)
 218         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
 219         (allocate_psymtab): Update.
 220         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
 221         Update.
 222         (dump_psymtab_addrmap, maintenance_print_psymbols)
 223         (maintenance_check_psymtabs): Update.
 224         (class objfile_psymtabs): Move to objfiles.h.
 225         * psympriv.h (discard_psymtab): Now inline.
 226         (psymtab_discarder::psymtab_discarder): Update.
 227         (psymtab_discarder::~psymtab_discarder): Update.
 228         (ALL_OBJFILE_PSYMTABS): Rewrite.
 229         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
 230         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
 231         Remove fields.
 232         <partial_symtabs>: New field.
 233         (class objfile_psymtabs): Move from psymtab.h.  Update.
 234         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
 235         psymbol_cache.
 236         (objfile::~objfile): Don't destroy psymbol_cache.
 237         * mdebugread.c (parse_partial_symbols): Update.
 238         * dwarf2read.c (create_addrmap_from_index)
 239         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 240         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
 241         (add_partial_subprogram, dwarf2_ranges_read): Update.
 242         * dwarf-index-write.c (write_address_map)
 243         (write_one_signatured_type, recursively_write_psymbols)
 244         (class debug_names, class debug_names, write_psymtabs_to_index):
 245         Update.
 246
 247 2019-01-10  Tom Tromey  <tom@tromey.com>
 248
 249         * symtab.h (SYMBOL_SET_NAMES): Update.
 250         (symbol_set_names): Update.
 251         (MSYMBOL_SET_NAMES): Update.
 252         * symtab.c (symbol_set_names): Change argument to be an
 253         objfile_per_bfd_storage.
 254         * psymtab.c (add_psymbol_to_bcache): Update.
 255         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
 256
 257 2019-01-10  Tom Tromey  <tom@tromey.com>
 258
 259         * symtab.c (create_demangled_names_hash): Change argument to be an
 260         objfile_per_bfd_storage.
 261         (symbol_set_names): Update.
 262
 263 2019-01-10  Tom Tromey  <tom@tromey.com>
 264
 265         * xcoffread.c (xcoff_initial_scan): Unconditionally call
 266         init_psymbol_list.
 267         * psymtab.c (init_psymbol_list): Do nothing if already called.
 268         * psympriv.h (init_psymbol_list): Add comment.
 269         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
 270         init_psymbol_list.
 271         * dbxread.c (dbx_symfile_read): Unconditionally call
 272         init_psymbol_list.
 273
 274 2019-01-10  Tom Tromey  <tom@tromey.com>
 275
 276         * xcoffread.c (scan_xcoff_symtab): Update.
 277         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
 278         "where".
 279         * mdebugread.c (parse_partial_symbols)
 280         (handle_psymbol_enumerators): Update.
 281         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
 282         * dbxread.c (read_dbx_symtab): Update.
 283         * psympriv.h (psymbol_placement): New enum.
 284         (add_psymbol_to_list): Update.
 285
 286 2019-01-10  Tom Tromey  <tom@tromey.com>
 287
 288         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
 289         static_psymbols parameters.
 290         (scan_xcoff_symtab): Update.
 291         * psymtab.c (start_psymtab_common): Remove global_psymbols and
 292         static_psymbols parameters.
 293         * psympriv.h (start_psymtab_common): Update.
 294         * mdebugread.c (parse_partial_symbols): Update.
 295         * dwarf2read.c (create_partial_symtab): Update.
 296         * dbxread.c (read_dbx_symtab): Update.
 297         (start_psymtab): Remove global_psymbols and static_psymbols
 298         parameters.
 299
 300 2019-01-10  Tom Tromey  <tom@tromey.com>
 301
 302         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
 303         * psymtab.c (allocate_psymtab): Add comment.
 304         * psympriv.h (allocate_psymtab): Add comment.
 305         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
 306         initializations.
 307         * dbxread.c (dbx_end_psymtab): Remove some initializations.
 308
 309 2019-01-10  Tom Tromey  <tom@tromey.com>
 310
 311         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 312         Don't declare.
 313         * mipsread.c: Include mdebugread.h.
 314         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 315         Declare.
 316         * elfread.c: Include mdebugread.h.
 317
 318 2019-01-09  Tom Tromey  <tom@tromey.com>
 319
 320         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
 321         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
 322         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
 323         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 324         (psym_lookup_symbol, psym_find_last_source_symtab)
 325         (psym_forget_cached_source_info, psym_print_stats)
 326         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 327         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 328         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 329         (psym_find_compunit_symtab_by_address)
 330         (maintenance_print_psymbols, maintenance_info_psymtabs)
 331         (maintenance_check_psymtabs): Use ranged for.
 332         * psymtab.h (class objfile_psymtabs): New.
 333         (require_partial_symbols): Return objfile_psymtabs.
 334         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
 335
 336 2019-01-09  Tom Tromey  <tom@tromey.com>
 337
 338         * symfile.c (overlay_invalidate_all, find_pc_overlay)
 339         (find_pc_mapped_section, list_overlays_command)
 340         (map_overlay_command, unmap_overlay_command)
 341         (simple_overlay_update): Use all_objfiles.
 342         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
 343         * printcmd.c (info_symbol_command): Use all_objfiles.
 344         * objfiles.h (ALL_OBJSECTIONS): Remove.
 345         * maint.c (maintenance_translate_address): Use all_objfiles.
 346         * gcore.c (gcore_create_callback): Use all_objfiles.
 347         (objfile_find_memory_regions): Likewise.
 348
 349 2019-01-09  Tom Tromey  <tom@tromey.com>
 350
 351         * symtab.c (find_line_symtab, info_sources_command)
 352         (make_source_files_completion_list): Use objfile_compunits.
 353         * source.c (select_source_symtab): Use objfile_compunits.
 354         * objfiles.h (struct objfile): Update comment.
 355         (ALL_OBJFILES): Remove.
 356         (ALL_FILETABS): Remove.
 357         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
 358         objfile_compunits.
 359
 360 2019-01-09  Tom Tromey  <tom@tromey.com>
 361
 362         * symmisc.c (print_objfile_statistics, dump_objfile)
 363         (maintenance_print_symbols): Use compunit_filetabs.
 364         * source.c (forget_cached_source_info_for_objfile): Use
 365         compunit_filetabs.
 366         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
 367         (ALL_FILETABS): Use compunit_filetabs.
 368         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
 369         * coffread.c (coff_symtab_read): Use compunit_filetabs.
 370
 371 2019-01-09  Tom Tromey  <tom@tromey.com>
 372
 373         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
 374         (compunit_filetabs): New.
 375         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
 376         compunit_filetabs.
 377         (info_sources_command, make_source_files_completion_list): Remove
 378         declaration.
 379         * symmisc.c (print_objfile_statistics, dump_objfile)
 380         (maintenance_print_symbols): Remove declaration.
 381         (maintenance_info_symtabs): Use compunit_filetabs.
 382         (maintenance_info_line_tables): Likewise.
 383         * source.c (select_source_symtab): Change local variable name.
 384         (forget_cached_source_info_for_objfile): Remove declaration.
 385         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
 386         * objfiles.c (objfile_relocate1): Remove declaration.
 387         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 388         declaration.
 389         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
 390         * coffread.c (coff_symtab_read): Remove declaration.
 391         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 392         compunit_filetabs.
 393
 394 2019-01-09  Tom Tromey  <tom@tromey.com>
 395
 396         * symtab.c (lookup_objfile_from_block)
 397         (find_pc_sect_compunit_symtab, search_symbols)
 398         (default_collect_symbol_completion_matches_break_on): Use
 399         objfile_compunits.
 400         * objfiles.h (ALL_COMPUNITS): Remove.
 401         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
 402         * cp-support.c (add_symbol_overload_list_qualified): Use
 403         objfile_compunits.
 404         * ada-lang.c (ada_collect_symbol_completion_matches)
 405         (ada_add_global_exceptions): Use objfile_compunits.
 406
 407 2019-01-09  Tom Tromey  <tom@tromey.com>
 408
 409         * source.c (select_source_symtab)
 410         (forget_cached_source_info_for_objfile): Remove declaration.
 411         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 412         declaration.
 413         * maint.c (count_symtabs_and_blocks): Remove declaration.
 414         * cp-support.c (add_symbol_overload_list_qualified): Remove
 415         declaration.
 416         * coffread.c (coff_symtab_read): Remove declaration.
 417         * symtab.c (lookup_symbol_in_objfile_symtabs)
 418         (basic_lookup_transparent_type_1): Use objfile_compunits.
 419         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
 420         (info_sources_command, search_symbols)
 421         (default_collect_symbol_completion_matches_break_on)
 422         (make_source_files_completion_list): Remove declaration.
 423         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
 424         (ada_collect_symbol_completion_matches)
 425         (ada_add_global_exceptions): Remove declaration.
 426         * linespec.c (iterate_over_all_matching_symtabs): Use
 427         objfile_compunits.
 428         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
 429         (class objfile_compunits): New.
 430         (ALL_COMPUNITS): Use objfile_compunits.
 431         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
 432         (maintenance_check_symtabs, maintenance_info_line_tables): Use
 433         objfile_compunits.
 434         * objfiles.c (objfile_relocate1): Use objfile_compunits.
 435
 436 2019-01-09  Tom Tromey  <tom@tromey.com>
 437
 438         * symtab.c (search_symbols)
 439         (default_collect_symbol_completion_matches_break_on): Use
 440         objfile_msymbols.
 441         * ada-lang.c (ada_lookup_simple_minsym)
 442         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
 443         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
 444         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
 445         objfile_msymbols.
 446         * coffread.c (coff_symfile_read): Use objfile_msymbols.
 447         * symmisc.c (dump_msymbols): Use objfile_msymbols.
 448         * objc-lang.c (find_methods): Use objfile_msymbols.
 449         (info_selectors_command, info_classes_command): Likewise.
 450         * stabsread.c (scan_file_globals): Use objfile_msymbols.
 451         * objfiles.h (class objfile_msymbols): New.
 452         (ALL_OBJFILE_MSYMBOLS): Remove.
 453         (ALL_MSYMBOLS): Remove.
 454
 455 2019-01-09  Tom Tromey  <tom@tromey.com>
 456
 457         * common/next-iterator.h (next_adapter): Add Iterator template
 458         parameter.
 459         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
 460         (class all_objfiles_safe): New.
 461         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
 462         * objfiles.c (put_objfile_before): Update comment.
 463         (add_separate_debug_objfile): Likewise.
 464         (free_all_objfiles): Use all_objfiles_safe.
 465         (objfile_purge_solibs): Likewise.
 466
 467 2019-01-09  Tom Tromey  <tom@tromey.com>
 468
 469         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 470         (expand_symtab_containing_pc, lookup_static_symbol)
 471         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
 472         (find_symbol_at_address, find_line_symtab, find_main_name): Use
 473         all_objfiles.
 474         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
 475         * breakpoint.c (create_overlay_event_breakpoint)
 476         (create_longjmp_master_breakpoint)
 477         (create_std_terminate_master_breakpoint)
 478         (create_exception_master_breakpoint): Use all_objfiles.
 479         * linux-thread-db.c (try_thread_db_load_from_pdir)
 480         (has_libpthread): Use all_objfiles.
 481         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
 482         * linespec.c (iterate_over_all_matching_symtabs)
 483         (search_minsyms_for_name): Use all_objfiles.
 484         * maint.c (maintenance_info_sections): Use all_objfiles.
 485         * main.c (captured_main_1): Use all_objfiles.
 486         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
 487         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
 488         * guile/scm-pretty-print.c
 489         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
 490         * solib-spu.c (append_ocl_sos): Use all_objfiles.
 491         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
 492         (maintenance_print_msymbols): Use all_objfiles.
 493         * source.c (select_source_symtab): Use all_objfiles.
 494         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
 495         * symfile.c (remove_symbol_file_command)
 496         (expand_symtabs_matching, map_symbol_filenames): Use
 497         all_objfiles.
 498         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
 499         all_objfiles.
 500         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
 501         * objc-lang.c (find_methods): Use all_objfiles.
 502         * objfiles.c (have_partial_symbols, have_full_symbols)
 503         (have_minimal_symbols, qsort_cmp)
 504         (default_iterate_over_objfiles_in_search_order): Use
 505         all_objfiles.
 506         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
 507         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
 508         (maintenance_check_psymtabs): Use all_objfiles.
 509         (ALL_PSYMTABS): Remove.
 510         * compile/compile-object-run.c (do_module_cleanup): Use
 511         all_objfiles.
 512         * blockframe.c (find_pc_partial_function): Use all_objfiles.
 513         * cp-support.c (add_symbol_overload_list_qualified): Use
 514         all_objfiles.
 515         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 516         Use all_objfiles.
 517         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
 518         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
 519         all_objfiles.
 520         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 521         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
 522         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 523         Uses all_objfiles.
 524         * solib.c (solib_read_symbols): Use all_objfiles
 525
 526 2019-01-09  Tom Tromey  <tom@tromey.com>
 527
 528         * probe.c (parse_probes_in_pspace): Use all_objfiles.
 529         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
 530         all_objfiles.
 531         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
 532         * symmisc.c (print_symbol_bcache_statistics)
 533         (print_objfile_statistics, maintenance_print_objfiles)
 534         (maintenance_info_symtabs, maintenance_check_symtabs)
 535         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
 536         all_objfiles.
 537         * source.c (forget_cached_source_info): Use all_objfiles.
 538         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
 539         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 540         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
 541         * objfiles.c (update_section_map): Use all_objfiles.
 542         (shared_objfile_contains_address_p): Likewise.
 543         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
 544         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
 545
 546 2019-01-09  Tom Tromey  <tom@tromey.com>
 547
 548         * common/next-iterator.h: New file.
 549         * objfiles.h (class all_objfiles): New.
 550         (struct objfile_iterator): New.
 551
 552 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 553
 554         * NEWS: Move the description of the changed "frame", "select-frame",
 555          and "info frame" commands to the Changed commands section.
 556
 557 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
 558
 559         * gdbtypes.c (check_stub_method_group): Remove handling of old
 560         mangling schemes.
 561         * linespec.c (find_methods): Likewise.
 562         * stabsread.c (read_member_functions): Likewise.
 563         * valops.c (search_struct_method): Likewise.
 564         (value_struct_elt_for_reference): Likewise.
 565         * NEWS: Mention this change.
 566
 567 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 568
 569         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
 570         print_source_lines.
 571         * source.c (print_source_lines_base): Update line number check.
 572         (print_source_lines): New function.
 573         (source_lines_range::source_lines_range): New function.
 574         * source.h (class source_lines_range): New class.
 575         (print_source_lines): New declaration.
 576
 577 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 578
 579         * linespec.c (linespec_state_destructor): Free self->canonical_names.
 580
 581 2019-01-08  Tom Tromey  <tom@tromey.com>
 582             Simon Marchi  <simon.marchi@ericsson.com>
 583
 584         PR gdb/24060
 585         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
 586         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
 587         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 588         * f-exp.y (DOLLAR_VARIABLE): Likewise.
 589         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
 590         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 591
 592 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 593
 594         * source.c (select_source_symtab): Move header comment to
 595         declaration in source.h.
 596         (forget_cached_source_info_for_objfile): Likewise.
 597         (forget_cached_source_info): Likewise.
 598         (identify_source_line): Likewise.
 599         * source.h (identify_source_line): Move declaration from symtab.h
 600         and add comment from source.c
 601         (print_source_lines): Likewise.
 602         (forget_cached_source_info_for_objfile): Likewise.
 603         (forget_cached_source_info): Likewise.
 604         (select_source_symtab): Likewise.
 605         (enum print_source_lines_flag): Move definition from symtab.h.
 606         * symtab.h (identify_source_line): Move declaration to source.h.
 607         (print_source_lines): Likewise.
 608         (forget_cached_source_info_for_objfile): Likewise.
 609         (forget_cached_source_info): Likewise.
 610         (select_source_symtab): Likewise.
 611         (enum print_source_lines_flag): Move definition to source.h.
 612         * tui/tui-hooks.c: Add 'source.h' include.
 613
 614 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 615
 616         * source.c (print_source_lines_base): Handle requests to print
 617         reverse line number sequences, and guard against empty lines
 618         string.
 619
 620 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 621
 622         * source.c (print_source_lines_base): Fix skip of '\r' if next
 623         character is '\n'.
 624
 625 2019-01-06  Tom Tromey  <tom@tromey.com>
 626
 627         * c-exp.y (struct c_parse_state) <macro_original_text,
 628         expansion_obstack>: New member.
 629         (macro_original_text, expansion_obstack): Remove globals.
 630         (scan_macro_expansion, scanning_macro_expansion)
 631         (finished_macro_expansion): Update.
 632         (scan_macro_cleanup): Remove.
 633         (yylex, c_parse): Update.
 634
 635 2019-01-06  Tom Tromey  <tom@tromey.com>
 636
 637         * c-exp.y (struct c_parse_state) <strings>: New member.
 638         (operator_stoken): Update.
 639
 640 2019-01-06  Tom Tromey  <tom@tromey.com>
 641
 642         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
 643         (union type_stack_elt) <typelist_val>: Now a pointer to
 644         std::vector.
 645         (type_stack_cleanup): Don't declare.
 646         (push_typelist): Update.
 647         * parse.c (pop_typelist): Return a std::vector.
 648         (push_typelist): Take a std::vector.
 649         (follow_types): Update.  Do not free args.
 650         (type_stack_cleanup): Remove.
 651         * c-exp.y (struct c_parse_state): New.
 652         (cpstate): New global.
 653         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
 654         (nonempty_typelist): Update.
 655         (func_mod): Create a new vector.
 656         (c_parse): Create a c_parse_state.
 657         (check_parameter_typelist): Do not delete params.
 658         (function_method): Update.  Do not delete type_list.
 659
 660 2019-01-06  Tom Tromey  <tom@tromey.com>
 661
 662         PR gdb/28155:
 663         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
 664         check_typedef.
 665         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
 666         (print_return_value): Likewise.
 667
 668 2019-01-05  Tom Tromey  <tom@tromey.com>
 669
 670         * contrib/cleanup_check.py: Remove.
 671         * contrib/gcc-with-excheck: Remove.
 672         * contrib/exsummary.py: Remove.
 673         * contrib/excheck.py: Remove.
 674
 675 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
 676
 677         * thread.c (delete_thread_1): Add gdb_assert that THR is not
 678         NULL. Initialize tpprev to NULL instead of assigning it
 679         to NULL on the next statement.
 680         * windows-nat.c (windows_delete_thread): Remove check for
 681         main_thread_id before printing thread exit notifications.
 682         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
 683         Remove thread ID check against main_thread_id.
 684         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
 685         windows_delete_thread.
 686         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
 687
 688 2019-01-04  Tom Tromey  <tom@tromey.com>
 689
 690         * compile/compile.c (_initialize_compile): Use upper case for
 691         metasyntactic variables.
 692         * symmisc.c (_initialize_symmisc): Use upper case for
 693         metasyntactic variables.
 694         * psymtab.c (_initialize_psymtab): Use upper case for
 695         metasyntactic variables.
 696         * demangle.c (demangle_command): Use upper case for metasyntactic
 697         variables.
 698         (_initialize_demangler): Likewise.
 699         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
 700         variables.
 701
 702 2019-01-03  Tom Tromey  <tom@tromey.com>
 703
 704         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
 705
 706 2019-01-03  Tom Tromey  <tom@tromey.com>
 707
 708         * python/py-symtab.c (salpy_str): Update.
 709         (struct salpy_sal_object) <symtab>: Now a PyObject.
 710         (salpy_dealloc): Update.
 711         (del_objfile_sal): Use gdbpy_ref.
 712
 713 2019-01-03  Tom Tromey  <tom@tromey.com>
 714
 715         * python/py-type.c (convert_field): Use new_reference.  Return
 716         gdbpy_ref.
 717         (make_fielditem): Return gdbpy_ref.
 718         (typy_fields): Update.
 719         (typy_getitem): Update.
 720         (field_name): Return gdbpy_ref.  Use new_reference.
 721         (typy_iterator_iternext): Update.
 722
 723 2019-01-03  Tom Tromey  <tom@tromey.com>
 724
 725         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
 726
 727 2019-01-03  Tom Tromey  <tom@tromey.com>
 728
 729         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
 730         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
 731         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
 732         (pspy_set_frame_filters, pspy_set_frame_unwinders)
 733         (pspy_set_type_printers): Likewise.
 734         * python/py-function.c (fnpy_init): Use gdbpy_ref.
 735         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
 736         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
 737         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
 738         (objfpy_set_type_printers): Likewise.
 739
 740 2019-01-03  Tom Tromey  <tom@tromey.com>
 741
 742         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
 743         (gdbpy_print_stack): Use gdbpy_err_fetch.
 744         * python/python-internal.h (class gdbpy_err_fetch): New class.
 745         (class gdbpy_enter) <m_error_type, m_error_value,
 746         m_error_traceback>: Remove.
 747         <m_error>: New member.
 748         (gdbpy_exception_to_string): Don't declare.
 749         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
 750         * python/py-value.c (convert_value_from_python): Use
 751         gdbpy_err_fetch.
 752         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
 753         gdbpy_exception_to_string.
 754         (gdbpy_handle_exception): Use gdbpy_err_fetch.
 755         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 756         gdbpy_err_fetch.
 757
 758 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 759
 760         * linux-nat.c (delete_lwp_cleanup): Delete.
 761         (struct lwp_deleter): New struct.
 762         (lwp_info_up): New typedef.
 763         (linux_nat_target::follow_fork): Delete cleanup, and make use of
 764         lwp_info_up.
 765
 766 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 767
 768         * linux-fork.c (class scoped_switch_fork_info): New class.
 769         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
 770
 771 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 772
 773         * valops.c (find_overload_match): Remove use of null_cleanup, and
 774         calls to do_cleanups.
 775
 776 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 777
 778         * compile/compile-cplus-types.c
 779         (compile_cplus_instance::decl_name): Handle changes to
 780         cp_func_name.
 781         * cp-support.c (cp_func_name): Update header comment, update
 782         return type.
 783         * cp-support.h (cp_func_name): Update return type in declaration.
 784         * valops.c (find_overload_match): Move temp_func local to top
 785         level of function and change its type.  Use temp_func to hold and
 786         delete temporary string obtained from cp_func_name.
 787
 788 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 789
 790         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
 791         gdb::char_vector, remove cleanup, and update uses of `msg`.
 792
 793 2019-01-03  Jim Wilson  <jimw@sifive.com>
 794
 795         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
 796
 797 2019-01-02  Tom Tromey  <tom@tromey.com>
 798
 799         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
 800         (tdesc_parse_xml): Remove cleanups.
 801         * target-descriptions.h (make_cleanup_free_target_description):
 802         Don't declare.
 803         (target_desc_deleter): New struct.
 804         (target_desc_up): New typedef.
 805         * target-descriptions.c (target_desc_deleter::operator()): Rename
 806         from free_target_description.
 807         (make_cleanup_free_target_description): Remove.
 808
 809 2019-01-02  Tom Tromey  <tom@tromey.com>
 810
 811         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
 812         constructor, destructor.
 813         (linespec_parser): Remove typedef.
 814         (~linespec_parser): Rename from linespec_parser_delete.
 815         (linespec_lex_to_end, linespec_complete_label)
 816         (linespec_complete): Update.
 817         (decode_line_full): Remove cleanups.
 818         (decode_line_1): Update.
 819
 820 2019-01-02  Tom Tromey  <tom@tromey.com>
 821
 822         * python/python-internal.h (inferior_to_inferior_object): Change
 823         return type.
 824         * python/py-exitedevent.c (create_exited_event_object): Update.
 825         * python/py-inferior.c (inferior_to_inferior_object): Return
 826         gdbpy_ref.
 827         (python_new_inferior, python_inferior_deleted)
 828         (thread_to_thread_object, delete_thread_object)
 829         (build_inferior_list, gdbpy_selected_inferior): Update.
 830         * python/py-infthread.c (create_thread_object): Update.  Also fail
 831         if inferior_to_inferior_object fails.
 832
 833 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
 834
 835         * inferior.h (class inferior) <displaced_step_state>: New field.
 836         * infrun.h (struct displaced_step_state): Move here from
 837         infrun.c.  Initialize fields, add constructor.
 838         <inf>: Remove field.
 839         <reset>: New method.
 840         * infrun.c (struct displaced_step_inferior_state): Move to
 841         infrun.h.
 842         (displaced_step_inferior_states): Remove.
 843         (get_displaced_stepping_state): Adust.
 844         (displaced_step_in_progress_any_inferior): Adjust.
 845         (displaced_step_in_progress_thread): Adjust.
 846         (displaced_step_in_progress): Adjust.
 847         (add_displaced_stepping_state): Remove.
 848         (get_displaced_step_closure_by_addr): Adjust.
 849         (remove_displaced_stepping_state): Remove.
 850         (infrun_inferior_exit): Call displaced_step_state.reset.
 851         (use_displaced_stepping): Don't check for NULL.
 852         (displaced_step_prepare_throw): Call
 853         get_displaced_stepping_state.
 854         (displaced_step_fixup): Don't check for NULL.
 855         (prepare_for_detach): Don't check for NULL.
 856
 857 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 858
 859         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
 860          in case of call that did not complete.
 861
 862 2019-01-02  Andrey Utkin  <autkin@undo.io>
 863
 864         * symfile.c (find_separate_debug_file): Fix search of debug files for
 865         remote debuggee.
 866
 867 2019-01-02  Tom Tromey  <tom@tromey.com>
 868
 869         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
 870         indentation.
 871         * python/py-frame.c (frapy_older): Remove cast.
 872         (frapy_newer): Likewise.
 873         * python/py-breakpoint.c (local_setattro): Remove cast.
 874         * python/py-arch.c (archpy_name): Remove local variable.
 875         * python/py-type.c (gdbpy_lookup_type): Remove cast.
 876
 877 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
 878
 879         * unittests/basic_string_view/element_access/char/empty.cc:
 880         Fix year range in copyright header.
 881
 882 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 883
 884         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
 885         Delete.
 886         <operator==>: Update with for removed field.
 887         <hash>: Likewise.
 888         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
 889         <isa_features>: ...this.
 890         <abi_features>: New field.
 891         (riscv_isa_flen): Update comment.
 892         (riscv_abi_xlen): New declaration.
 893         (riscv_abi_flen): New declaration.
 894         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
 895         isa_features.
 896         (riscv_abi_xlen): New function.
 897         (riscv_isa_flen): Update to get answer from isa_features.
 898         (riscv_abi_flen): New function.
 899         (riscv_has_fp_abi): Update to get answer from abi_features.
 900         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
 901         xlen and flen.
 902         (riscv_call_info) <xlen, flen>: Update comment.
 903         (riscv_call_arg_struct): Remove invalid assertions
 904         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
 905         is removed.
 906         (riscv_gdbarch_init): Gather isa features and abi features
 907         separately, ensure both match on the gdbarch when reusing an old
 908         gdbarch.  Relax an error check to allow 32-bit abi float to run on
 909         a target with 64-bit float hardware.
 910
 911 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 912
 913         * source.c (search_command_helper): Stop reverse search
 914         when line 1 has been searched.
 915
 916 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 917
 918         * record-full.c (record_full_base_target::close): Rewrite
 919         record_full_core_buf_list free logic.
 920
 921 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 922
 923         * break-catch-syscall.c (print_one_catch_syscall): xfree
 924         the last text.
 925
 926 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
 927
 928         * top.c (print_gdb_version): Update Copyright year in version
 929         message.
 930
 931 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
 932
 933         Update copyright year range in all GDB files.
 934
 935 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
 936
 937         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
 938
 939 For older changes see ChangeLog-2018.
 940 \f
 941 Local Variables:
 942 mode: change-log
 943 left-margin: 8
 944 fill-column: 74
 945 version-control: never
 946 coding: utf-8
 947 End:
 948