Simplify calls to init_psymbol_list
[external/binutils.git] / gdb / ChangeLog
1 2019-01-10  Tom Tromey  <tom@tromey.com>
2
3         * xcoffread.c (xcoff_initial_scan): Unconditionally call
4         init_psymbol_list.
5         * psymtab.c (init_psymbol_list): Do nothing if already called.
6         * psympriv.h (init_psymbol_list): Add comment.
7         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8         init_psymbol_list.
9         * dbxread.c (dbx_symfile_read): Unconditionally call
10         init_psymbol_list.
11
12 2019-01-10  Tom Tromey  <tom@tromey.com>
13
14         * xcoffread.c (scan_xcoff_symtab): Update.
15         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16         "where".
17         * mdebugread.c (parse_partial_symbols)
18         (handle_psymbol_enumerators): Update.
19         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
20         * dbxread.c (read_dbx_symtab): Update.
21         * psympriv.h (psymbol_placement): New enum.
22         (add_psymbol_to_list): Update.
23
24 2019-01-10  Tom Tromey  <tom@tromey.com>
25
26         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
27         static_psymbols parameters.
28         (scan_xcoff_symtab): Update.
29         * psymtab.c (start_psymtab_common): Remove global_psymbols and
30         static_psymbols parameters.
31         * psympriv.h (start_psymtab_common): Update.
32         * mdebugread.c (parse_partial_symbols): Update.
33         * dwarf2read.c (create_partial_symtab): Update.
34         * dbxread.c (read_dbx_symtab): Update.
35         (start_psymtab): Remove global_psymbols and static_psymbols
36         parameters.
37
38 2019-01-10  Tom Tromey  <tom@tromey.com>
39
40         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
41         * psymtab.c (allocate_psymtab): Add comment.
42         * psympriv.h (allocate_psymtab): Add comment.
43         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
44         initializations.
45         * dbxread.c (dbx_end_psymtab): Remove some initializations.
46
47 2019-01-10  Tom Tromey  <tom@tromey.com>
48
49         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
50         Don't declare.
51         * mipsread.c: Include mdebugread.h.
52         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
53         Declare.
54         * elfread.c: Include mdebugread.h.
55
56 2019-01-09  Tom Tromey  <tom@tromey.com>
57
58         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
59         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
60         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
61         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
62         (psym_lookup_symbol, psym_find_last_source_symtab)
63         (psym_forget_cached_source_info, psym_print_stats)
64         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
65         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
66         (psym_map_matching_symbols, psym_expand_symtabs_matching)
67         (psym_find_compunit_symtab_by_address)
68         (maintenance_print_psymbols, maintenance_info_psymtabs)
69         (maintenance_check_psymtabs): Use ranged for.
70         * psymtab.h (class objfile_psymtabs): New.
71         (require_partial_symbols): Return objfile_psymtabs.
72         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
73
74 2019-01-09  Tom Tromey  <tom@tromey.com>
75
76         * symfile.c (overlay_invalidate_all, find_pc_overlay)
77         (find_pc_mapped_section, list_overlays_command)
78         (map_overlay_command, unmap_overlay_command)
79         (simple_overlay_update): Use all_objfiles.
80         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
81         * printcmd.c (info_symbol_command): Use all_objfiles.
82         * objfiles.h (ALL_OBJSECTIONS): Remove.
83         * maint.c (maintenance_translate_address): Use all_objfiles.
84         * gcore.c (gcore_create_callback): Use all_objfiles.
85         (objfile_find_memory_regions): Likewise.
86
87 2019-01-09  Tom Tromey  <tom@tromey.com>
88
89         * symtab.c (find_line_symtab, info_sources_command)
90         (make_source_files_completion_list): Use objfile_compunits.
91         * source.c (select_source_symtab): Use objfile_compunits.
92         * objfiles.h (struct objfile): Update comment.
93         (ALL_OBJFILES): Remove.
94         (ALL_FILETABS): Remove.
95         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
96         objfile_compunits.
97
98 2019-01-09  Tom Tromey  <tom@tromey.com>
99
100         * symmisc.c (print_objfile_statistics, dump_objfile)
101         (maintenance_print_symbols): Use compunit_filetabs.
102         * source.c (forget_cached_source_info_for_objfile): Use
103         compunit_filetabs.
104         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
105         (ALL_FILETABS): Use compunit_filetabs.
106         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
107         * coffread.c (coff_symtab_read): Use compunit_filetabs.
108
109 2019-01-09  Tom Tromey  <tom@tromey.com>
110
111         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
112         (compunit_filetabs): New.
113         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
114         compunit_filetabs.
115         (info_sources_command, make_source_files_completion_list): Remove
116         declaration.
117         * symmisc.c (print_objfile_statistics, dump_objfile)
118         (maintenance_print_symbols): Remove declaration.
119         (maintenance_info_symtabs): Use compunit_filetabs.
120         (maintenance_info_line_tables): Likewise.
121         * source.c (select_source_symtab): Change local variable name.
122         (forget_cached_source_info_for_objfile): Remove declaration.
123         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
124         * objfiles.c (objfile_relocate1): Remove declaration.
125         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
126         declaration.
127         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
128         * coffread.c (coff_symtab_read): Remove declaration.
129         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
130         compunit_filetabs.
131
132 2019-01-09  Tom Tromey  <tom@tromey.com>
133
134         * symtab.c (lookup_objfile_from_block)
135         (find_pc_sect_compunit_symtab, search_symbols)
136         (default_collect_symbol_completion_matches_break_on): Use
137         objfile_compunits.
138         * objfiles.h (ALL_COMPUNITS): Remove.
139         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
140         * cp-support.c (add_symbol_overload_list_qualified): Use
141         objfile_compunits.
142         * ada-lang.c (ada_collect_symbol_completion_matches)
143         (ada_add_global_exceptions): Use objfile_compunits.
144
145 2019-01-09  Tom Tromey  <tom@tromey.com>
146
147         * source.c (select_source_symtab)
148         (forget_cached_source_info_for_objfile): Remove declaration.
149         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
150         declaration.
151         * maint.c (count_symtabs_and_blocks): Remove declaration.
152         * cp-support.c (add_symbol_overload_list_qualified): Remove
153         declaration.
154         * coffread.c (coff_symtab_read): Remove declaration.
155         * symtab.c (lookup_symbol_in_objfile_symtabs)
156         (basic_lookup_transparent_type_1): Use objfile_compunits.
157         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
158         (info_sources_command, search_symbols)
159         (default_collect_symbol_completion_matches_break_on)
160         (make_source_files_completion_list): Remove declaration.
161         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
162         (ada_collect_symbol_completion_matches)
163         (ada_add_global_exceptions): Remove declaration.
164         * linespec.c (iterate_over_all_matching_symtabs): Use
165         objfile_compunits.
166         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
167         (class objfile_compunits): New.
168         (ALL_COMPUNITS): Use objfile_compunits.
169         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
170         (maintenance_check_symtabs, maintenance_info_line_tables): Use
171         objfile_compunits.
172         * objfiles.c (objfile_relocate1): Use objfile_compunits.
173
174 2019-01-09  Tom Tromey  <tom@tromey.com>
175
176         * symtab.c (search_symbols)
177         (default_collect_symbol_completion_matches_break_on): Use
178         objfile_msymbols.
179         * ada-lang.c (ada_lookup_simple_minsym)
180         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
181         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
182         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
183         objfile_msymbols.
184         * coffread.c (coff_symfile_read): Use objfile_msymbols.
185         * symmisc.c (dump_msymbols): Use objfile_msymbols.
186         * objc-lang.c (find_methods): Use objfile_msymbols.
187         (info_selectors_command, info_classes_command): Likewise.
188         * stabsread.c (scan_file_globals): Use objfile_msymbols.
189         * objfiles.h (class objfile_msymbols): New.
190         (ALL_OBJFILE_MSYMBOLS): Remove.
191         (ALL_MSYMBOLS): Remove.
192
193 2019-01-09  Tom Tromey  <tom@tromey.com>
194
195         * common/next-iterator.h (next_adapter): Add Iterator template
196         parameter.
197         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
198         (class all_objfiles_safe): New.
199         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
200         * objfiles.c (put_objfile_before): Update comment.
201         (add_separate_debug_objfile): Likewise.
202         (free_all_objfiles): Use all_objfiles_safe.
203         (objfile_purge_solibs): Likewise.
204
205 2019-01-09  Tom Tromey  <tom@tromey.com>
206
207         * symtab.c (iterate_over_symtabs, matching_obj_sections)
208         (expand_symtab_containing_pc, lookup_static_symbol)
209         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
210         (find_symbol_at_address, find_line_symtab, find_main_name): Use
211         all_objfiles.
212         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
213         * breakpoint.c (create_overlay_event_breakpoint)
214         (create_longjmp_master_breakpoint)
215         (create_std_terminate_master_breakpoint)
216         (create_exception_master_breakpoint): Use all_objfiles.
217         * linux-thread-db.c (try_thread_db_load_from_pdir)
218         (has_libpthread): Use all_objfiles.
219         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
220         * linespec.c (iterate_over_all_matching_symtabs)
221         (search_minsyms_for_name): Use all_objfiles.
222         * maint.c (maintenance_info_sections): Use all_objfiles.
223         * main.c (captured_main_1): Use all_objfiles.
224         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
225         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
226         * guile/scm-pretty-print.c
227         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
228         * solib-spu.c (append_ocl_sos): Use all_objfiles.
229         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
230         (maintenance_print_msymbols): Use all_objfiles.
231         * source.c (select_source_symtab): Use all_objfiles.
232         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
233         * symfile.c (remove_symbol_file_command)
234         (expand_symtabs_matching, map_symbol_filenames): Use
235         all_objfiles.
236         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
237         all_objfiles.
238         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
239         * objc-lang.c (find_methods): Use all_objfiles.
240         * objfiles.c (have_partial_symbols, have_full_symbols)
241         (have_minimal_symbols, qsort_cmp)
242         (default_iterate_over_objfiles_in_search_order): Use
243         all_objfiles.
244         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
245         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
246         (maintenance_check_psymtabs): Use all_objfiles.
247         (ALL_PSYMTABS): Remove.
248         * compile/compile-object-run.c (do_module_cleanup): Use
249         all_objfiles.
250         * blockframe.c (find_pc_partial_function): Use all_objfiles.
251         * cp-support.c (add_symbol_overload_list_qualified): Use
252         all_objfiles.
253         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
254         Use all_objfiles.
255         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
256         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
257         all_objfiles.
258         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
259         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
260         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
261         Uses all_objfiles.
262         * solib.c (solib_read_symbols): Use all_objfiles
263
264 2019-01-09  Tom Tromey  <tom@tromey.com>
265
266         * probe.c (parse_probes_in_pspace): Use all_objfiles.
267         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
268         all_objfiles.
269         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
270         * symmisc.c (print_symbol_bcache_statistics)
271         (print_objfile_statistics, maintenance_print_objfiles)
272         (maintenance_info_symtabs, maintenance_check_symtabs)
273         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
274         all_objfiles.
275         * source.c (forget_cached_source_info): Use all_objfiles.
276         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
277         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
278         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
279         * objfiles.c (update_section_map): Use all_objfiles.
280         (shared_objfile_contains_address_p): Likewise.
281         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
282         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
283
284 2019-01-09  Tom Tromey  <tom@tromey.com>
285
286         * common/next-iterator.h: New file.
287         * objfiles.h (class all_objfiles): New.
288         (struct objfile_iterator): New.
289
290 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
291
292         * NEWS: Move the description of the changed "frame", "select-frame",
293          and "info frame" commands to the Changed commands section.
294
295 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
296
297         * gdbtypes.c (check_stub_method_group): Remove handling of old
298         mangling schemes.
299         * linespec.c (find_methods): Likewise.
300         * stabsread.c (read_member_functions): Likewise.
301         * valops.c (search_struct_method): Likewise.
302         (value_struct_elt_for_reference): Likewise.
303         * NEWS: Mention this change.
304
305 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
306
307         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
308         print_source_lines.
309         * source.c (print_source_lines_base): Update line number check.
310         (print_source_lines): New function.
311         (source_lines_range::source_lines_range): New function.
312         * source.h (class source_lines_range): New class.
313         (print_source_lines): New declaration.
314
315 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
316
317         * linespec.c (linespec_state_destructor): Free self->canonical_names.
318
319 2019-01-08  Tom Tromey  <tom@tromey.com>
320             Simon Marchi  <simon.marchi@ericsson.com>
321
322         PR gdb/24060
323         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
324         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
325         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
326         * f-exp.y (DOLLAR_VARIABLE): Likewise.
327         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
328         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
329
330 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
331
332         * source.c (select_source_symtab): Move header comment to
333         declaration in source.h.
334         (forget_cached_source_info_for_objfile): Likewise.
335         (forget_cached_source_info): Likewise.
336         (identify_source_line): Likewise.
337         * source.h (identify_source_line): Move declaration from symtab.h
338         and add comment from source.c
339         (print_source_lines): Likewise.
340         (forget_cached_source_info_for_objfile): Likewise.
341         (forget_cached_source_info): Likewise.
342         (select_source_symtab): Likewise.
343         (enum print_source_lines_flag): Move definition from symtab.h.
344         * symtab.h (identify_source_line): Move declaration to source.h.
345         (print_source_lines): Likewise.
346         (forget_cached_source_info_for_objfile): Likewise.
347         (forget_cached_source_info): Likewise.
348         (select_source_symtab): Likewise.
349         (enum print_source_lines_flag): Move definition to source.h.
350         * tui/tui-hooks.c: Add 'source.h' include.
351
352 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
353
354         * source.c (print_source_lines_base): Handle requests to print
355         reverse line number sequences, and guard against empty lines
356         string.
357
358 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
359
360         * source.c (print_source_lines_base): Fix skip of '\r' if next
361         character is '\n'.
362
363 2019-01-06  Tom Tromey  <tom@tromey.com>
364
365         * c-exp.y (struct c_parse_state) <macro_original_text,
366         expansion_obstack>: New member.
367         (macro_original_text, expansion_obstack): Remove globals.
368         (scan_macro_expansion, scanning_macro_expansion)
369         (finished_macro_expansion): Update.
370         (scan_macro_cleanup): Remove.
371         (yylex, c_parse): Update.
372
373 2019-01-06  Tom Tromey  <tom@tromey.com>
374
375         * c-exp.y (struct c_parse_state) <strings>: New member.
376         (operator_stoken): Update.
377
378 2019-01-06  Tom Tromey  <tom@tromey.com>
379
380         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
381         (union type_stack_elt) <typelist_val>: Now a pointer to
382         std::vector.
383         (type_stack_cleanup): Don't declare.
384         (push_typelist): Update.
385         * parse.c (pop_typelist): Return a std::vector.
386         (push_typelist): Take a std::vector.
387         (follow_types): Update.  Do not free args.
388         (type_stack_cleanup): Remove.
389         * c-exp.y (struct c_parse_state): New.
390         (cpstate): New global.
391         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
392         (nonempty_typelist): Update.
393         (func_mod): Create a new vector.
394         (c_parse): Create a c_parse_state.
395         (check_parameter_typelist): Do not delete params.
396         (function_method): Update.  Do not delete type_list.
397
398 2019-01-06  Tom Tromey  <tom@tromey.com>
399
400         PR gdb/28155:
401         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
402         check_typedef.
403         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
404         (print_return_value): Likewise.
405
406 2019-01-05  Tom Tromey  <tom@tromey.com>
407
408         * contrib/cleanup_check.py: Remove.
409         * contrib/gcc-with-excheck: Remove.
410         * contrib/exsummary.py: Remove.
411         * contrib/excheck.py: Remove.
412
413 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
414
415         * thread.c (delete_thread_1): Add gdb_assert that THR is not
416         NULL. Initialize tpprev to NULL instead of assigning it
417         to NULL on the next statement.
418         * windows-nat.c (windows_delete_thread): Remove check for
419         main_thread_id before printing thread exit notifications.
420         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
421         Remove thread ID check against main_thread_id.
422         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
423         windows_delete_thread.
424         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
425
426 2019-01-04  Tom Tromey  <tom@tromey.com>
427
428         * compile/compile.c (_initialize_compile): Use upper case for
429         metasyntactic variables.
430         * symmisc.c (_initialize_symmisc): Use upper case for
431         metasyntactic variables.
432         * psymtab.c (_initialize_psymtab): Use upper case for
433         metasyntactic variables.
434         * demangle.c (demangle_command): Use upper case for metasyntactic
435         variables.
436         (_initialize_demangler): Likewise.
437         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
438         variables.
439
440 2019-01-03  Tom Tromey  <tom@tromey.com>
441
442         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
443
444 2019-01-03  Tom Tromey  <tom@tromey.com>
445
446         * python/py-symtab.c (salpy_str): Update.
447         (struct salpy_sal_object) <symtab>: Now a PyObject.
448         (salpy_dealloc): Update.
449         (del_objfile_sal): Use gdbpy_ref.
450
451 2019-01-03  Tom Tromey  <tom@tromey.com>
452
453         * python/py-type.c (convert_field): Use new_reference.  Return
454         gdbpy_ref.
455         (make_fielditem): Return gdbpy_ref.
456         (typy_fields): Update.
457         (typy_getitem): Update.
458         (field_name): Return gdbpy_ref.  Use new_reference.
459         (typy_iterator_iternext): Update.
460
461 2019-01-03  Tom Tromey  <tom@tromey.com>
462
463         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
464
465 2019-01-03  Tom Tromey  <tom@tromey.com>
466
467         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
468         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
469         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
470         (pspy_set_frame_filters, pspy_set_frame_unwinders)
471         (pspy_set_type_printers): Likewise.
472         * python/py-function.c (fnpy_init): Use gdbpy_ref.
473         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
474         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
475         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
476         (objfpy_set_type_printers): Likewise.
477
478 2019-01-03  Tom Tromey  <tom@tromey.com>
479
480         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
481         (gdbpy_print_stack): Use gdbpy_err_fetch.
482         * python/python-internal.h (class gdbpy_err_fetch): New class.
483         (class gdbpy_enter) <m_error_type, m_error_value,
484         m_error_traceback>: Remove.
485         <m_error>: New member.
486         (gdbpy_exception_to_string): Don't declare.
487         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
488         * python/py-value.c (convert_value_from_python): Use
489         gdbpy_err_fetch.
490         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
491         gdbpy_exception_to_string.
492         (gdbpy_handle_exception): Use gdbpy_err_fetch.
493         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
494         gdbpy_err_fetch.
495
496 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
497
498         * linux-nat.c (delete_lwp_cleanup): Delete.
499         (struct lwp_deleter): New struct.
500         (lwp_info_up): New typedef.
501         (linux_nat_target::follow_fork): Delete cleanup, and make use of
502         lwp_info_up.
503
504 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
505
506         * linux-fork.c (class scoped_switch_fork_info): New class.
507         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
508
509 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
510
511         * valops.c (find_overload_match): Remove use of null_cleanup, and
512         calls to do_cleanups.
513
514 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
515
516         * compile/compile-cplus-types.c
517         (compile_cplus_instance::decl_name): Handle changes to
518         cp_func_name.
519         * cp-support.c (cp_func_name): Update header comment, update
520         return type.
521         * cp-support.h (cp_func_name): Update return type in declaration.
522         * valops.c (find_overload_match): Move temp_func local to top
523         level of function and change its type.  Use temp_func to hold and
524         delete temporary string obtained from cp_func_name.
525
526 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
527
528         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
529         gdb::char_vector, remove cleanup, and update uses of `msg`.
530
531 2019-01-03  Jim Wilson  <jimw@sifive.com>
532
533         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
534
535 2019-01-02  Tom Tromey  <tom@tromey.com>
536
537         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
538         (tdesc_parse_xml): Remove cleanups.
539         * target-descriptions.h (make_cleanup_free_target_description):
540         Don't declare.
541         (target_desc_deleter): New struct.
542         (target_desc_up): New typedef.
543         * target-descriptions.c (target_desc_deleter::operator()): Rename
544         from free_target_description.
545         (make_cleanup_free_target_description): Remove.
546
547 2019-01-02  Tom Tromey  <tom@tromey.com>
548
549         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
550         constructor, destructor.
551         (linespec_parser): Remove typedef.
552         (~linespec_parser): Rename from linespec_parser_delete.
553         (linespec_lex_to_end, linespec_complete_label)
554         (linespec_complete): Update.
555         (decode_line_full): Remove cleanups.
556         (decode_line_1): Update.
557
558 2019-01-02  Tom Tromey  <tom@tromey.com>
559
560         * python/python-internal.h (inferior_to_inferior_object): Change
561         return type.
562         * python/py-exitedevent.c (create_exited_event_object): Update.
563         * python/py-inferior.c (inferior_to_inferior_object): Return
564         gdbpy_ref.
565         (python_new_inferior, python_inferior_deleted)
566         (thread_to_thread_object, delete_thread_object)
567         (build_inferior_list, gdbpy_selected_inferior): Update.
568         * python/py-infthread.c (create_thread_object): Update.  Also fail
569         if inferior_to_inferior_object fails.
570
571 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
572
573         * inferior.h (class inferior) <displaced_step_state>: New field.
574         * infrun.h (struct displaced_step_state): Move here from
575         infrun.c.  Initialize fields, add constructor.
576         <inf>: Remove field.
577         <reset>: New method.
578         * infrun.c (struct displaced_step_inferior_state): Move to
579         infrun.h.
580         (displaced_step_inferior_states): Remove.
581         (get_displaced_stepping_state): Adust.
582         (displaced_step_in_progress_any_inferior): Adjust.
583         (displaced_step_in_progress_thread): Adjust.
584         (displaced_step_in_progress): Adjust.
585         (add_displaced_stepping_state): Remove.
586         (get_displaced_step_closure_by_addr): Adjust.
587         (remove_displaced_stepping_state): Remove.
588         (infrun_inferior_exit): Call displaced_step_state.reset.
589         (use_displaced_stepping): Don't check for NULL.
590         (displaced_step_prepare_throw): Call
591         get_displaced_stepping_state.
592         (displaced_step_fixup): Don't check for NULL.
593         (prepare_for_detach): Don't check for NULL.
594
595 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
596
597         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
598          in case of call that did not complete.
599
600 2019-01-02  Andrey Utkin  <autkin@undo.io>
601
602         * symfile.c (find_separate_debug_file): Fix search of debug files for
603         remote debuggee.
604
605 2019-01-02  Tom Tromey  <tom@tromey.com>
606
607         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
608         indentation.
609         * python/py-frame.c (frapy_older): Remove cast.
610         (frapy_newer): Likewise.
611         * python/py-breakpoint.c (local_setattro): Remove cast.
612         * python/py-arch.c (archpy_name): Remove local variable.
613         * python/py-type.c (gdbpy_lookup_type): Remove cast.
614
615 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
616
617         * unittests/basic_string_view/element_access/char/empty.cc:
618         Fix year range in copyright header.
619
620 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
621
622         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
623         Delete.
624         <operator==>: Update with for removed field.
625         <hash>: Likewise.
626         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
627         <isa_features>: ...this.
628         <abi_features>: New field.
629         (riscv_isa_flen): Update comment.
630         (riscv_abi_xlen): New declaration.
631         (riscv_abi_flen): New declaration.
632         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
633         isa_features.
634         (riscv_abi_xlen): New function.
635         (riscv_isa_flen): Update to get answer from isa_features.
636         (riscv_abi_flen): New function.
637         (riscv_has_fp_abi): Update to get answer from abi_features.
638         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
639         xlen and flen.
640         (riscv_call_info) <xlen, flen>: Update comment.
641         (riscv_call_arg_struct): Remove invalid assertions
642         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
643         is removed.
644         (riscv_gdbarch_init): Gather isa features and abi features
645         separately, ensure both match on the gdbarch when reusing an old
646         gdbarch.  Relax an error check to allow 32-bit abi float to run on
647         a target with 64-bit float hardware.
648
649 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
650
651         * source.c (search_command_helper): Stop reverse search
652         when line 1 has been searched.
653
654 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
655
656         * record-full.c (record_full_base_target::close): Rewrite
657         record_full_core_buf_list free logic.
658
659 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
660
661         * break-catch-syscall.c (print_one_catch_syscall): xfree
662         the last text.
663
664 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
665
666         * top.c (print_gdb_version): Update Copyright year in version
667         message.
668
669 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
670
671         Update copyright year range in all GDB files.
672
673 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
674
675         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
676
677 For older changes see ChangeLog-2018.
678 \f
679 Local Variables:
680 mode: change-log
681 left-margin: 8
682 fill-column: 74
683 version-control: never
684 coding: utf-8
685 End:
686