gdb/ChangeLog

   1 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
   2
   3         * gdbarch.sh (get_thread_local_address): New method.
   4         * gdbarch.h, gdbarch.c: Regenerate.
   5         * target.c (target_translate_tls_address): Use
   6         gdbarch_get_thread_local_address if present instead of
   7         target::get_thread_local_address.
   8
   9 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  10
  11         * target.h (target::get_thread_local_address): Update comment.
  12
  13 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  14
  15         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
  16         objfile->separate_debug_objfile_backlink if not NULL.
  17
  18 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  19
  20         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
  21         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
  22         (amd64bsd_store_inferior_registers): Likewise.
  23         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
  24         Enable segment base registers.
  25         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
  26         PT_GETFSBASE and PT_GETGSBASE.
  27         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
  28         PT_SETGSBASE.
  29         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
  30         segment base registers.
  31         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
  32
  33 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
  34
  35         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
  36         Update calls to i386_target_description to add 'segments'
  37         parameter.
  38         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
  39         add segment base registers.
  40         * arch/i386.c (i386_create_target_description): Add 'segments'
  41         parameter to enable segment base registers.
  42         * arch/i386.h (i386_create_target_description): Likewise.
  43         * features/i386/32bit-segments.xml: New file.
  44         * features/i386/32bit-segments.c: Generate.
  45         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
  46         call to i386_target_description to add 'segments' parameter.
  47         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
  48         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
  49         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
  50         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
  51         if feature is present.
  52         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
  53         Add 'segments' parameter to call to i386_target_description.
  54         (i386_target_description): Add 'segments' parameter to enable
  55         segment base registers.
  56         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
  57         to call to i386_target_description.
  58         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
  59         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
  60         Define I386_NUM_REGS.
  61         (i386_target_description): Add 'segments' parameter to enable
  62         segment base registers.
  63
  64 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
  65
  66         PR/24325
  67         * source-cache.c: #undef open and close, to avoid unresolved
  68         externals during linking.
  69
  70 2019-03-12  Tom Tromey  <tromey@adacore.com>
  71
  72         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
  73         const.  Add initializers.
  74         (_initialize_remote): Don't initialize ptid globals.
  75
  76 2019-03-12  Pedro Alves  <palves@redhat.com>
  77
  78         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
  79
  80 2019-03-12  Pedro Alves  <palves@redhat.com>
  81
  82         * cp-name-parser.y (main): Remove unused 'len' variable.
  83
  84 2019-03-12  Tom Tromey  <tromey@adacore.com>
  85
  86         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
  87         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
  88
  89 2019-03-12  Tom Tromey  <tromey@adacore.com>
  90
  91         * linux-nat.c (iterate_over_lwps): Update.
  92         (stop_callback): Remove parameter.
  93         (stop_wait_callback, detach_callback, resume_set_callback)
  94         (select_singlestep_lwp_callback, set_ignore_sigint)
  95         (status_callback, resumed_callback, resume_clear_callback)
  96         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
  97         data parameter.
  98         (linux_nat_target::detach, linux_nat_target::resume)
  99         (linux_stop_and_wait_all_lwps, select_event_lwp)
 100         (linux_nat_filter_event, linux_nat_wait_1)
 101         (linux_nat_target::kill, linux_nat_target::stop)
 102         (linux_nat_target::stop): Update.
 103         (linux_nat_resume_callback): Change type.
 104         (resume_stopped_resumed_lwps, count_events_callback)
 105         (select_event_lwp_callback): Likewise.
 106         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 107         * arm-linux-nat.c (struct update_registers_data): Remove.
 108         (update_registers_callback): Change type.
 109         (arm_linux_insert_hw_breakpoint1): Update.
 110         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 111         parameter.
 112         (x86_linux_dr_set_addr): Update.
 113         (x86_linux_dr_set_control): Update.
 114         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 115         (iterate_over_lwps): Use gdb::function_view.
 116         * nat/aarch64-linux-hw-point.c (struct
 117         aarch64_dr_update_callback_param): Remove.
 118         (debug_reg_change_callback): Change type.
 119         (aarch64_notify_debug_reg_change): Update.
 120         * s390-linux-nat.c (s390_refresh_per_info): Update.
 121
 122 2019-03-11  Tom Tromey  <tromey@adacore.com>
 123
 124         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 125         redundant assignment to "this_cu".
 126
 127 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 128
 129         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 130
 131 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 132
 133         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 134         from...
 135         (rank_one_type): ... this.
 136
 137 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 138
 139         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 140         from...
 141         (rank_one_type): ... this.
 142
 143 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 144
 145         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 146         from...
 147         (rank_one_type): ... this.
 148
 149 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 150
 151         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 152         from...
 153         (rank_one_type): ... this.
 154
 155 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 156
 157         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 158         from...
 159         (rank_one_type): ... this.
 160
 161 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 162
 163         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 164         from...
 165         (rank_one_type): ... this.
 166
 167 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 168
 169         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 170         from...
 171         (rank_one_type): ... this.
 172
 173 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 174
 175         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 176         from...
 177         (rank_one_type): ... this.
 178
 179 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 180
 181         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 182         from...
 183         (rank_one_type): ... this.
 184
 185 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 186
 187         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 188         from...
 189         (rank_one_type): ... this.
 190
 191 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 192
 193         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 194         from...
 195         (rank_one_type): ... this.
 196
 197 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 198
 199         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 200         from...
 201         (rank_one_type): ... this.
 202
 203 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 204
 205         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 206         inferior-events' shows the example events.
 207
 208 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 209
 210         Support styling on native MS-Windows console
 211
 212         PR/24315
 213         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 214         on MS-Windows if $TERM is not defined.
 215
 216         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 217
 218         * posix-hdep.c (gdb_console_fputs):
 219         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 220         functions.
 221         * ui-file.h (gdb_console_fputs): Add prototype.
 222
 223         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 224         back to fputs only if the former returns zero.
 225
 226 2019-03-07  Tom Tromey  <tom@tromey.com>
 227
 228         * symmisc.c (print_symbol_bcache_statistics): Update.
 229         (print_objfile_statistics): Update.
 230         * symfile.c (allocate_symtab): Update.
 231         * stabsread.c: Don't include bcache.h.
 232         * psymtab.h (struct psymbol_bcache): Don't declare.
 233         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 234         (psymbol_bcache_init, psymbol_bcache_free)
 235         (psymbol_bcache_get_bcache): Don't declare.
 236         * psymtab.c (struct psymbol_bcache): Remove.
 237         (psymtab_storage::psymtab_storage): Update.
 238         (psymtab_storage::~psymtab_storage): Update.
 239         (psymbol_bcache_init, psymbol_bcache_free)
 240         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
 241         (add_psymbol_to_bcache): Update.
 242         (allocate_psymtab): Update.
 243         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 244         macro_cache>: No longer pointers.
 245         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
 246         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
 247         * macrotab.c (macro_bcache): Update.
 248         * macroexp.c: Don't include bcache.h.
 249         * gdbtypes.c (check_types_worklist): Update.
 250         (types_deeply_equal): Remove TRY/CATCH.  Update.
 251         * elfread.c (elf_symtab_read): Update.
 252         * dwarf2read.c: Don't include bcache.h.
 253         * buildsym.c (buildsym_compunit::get_macro_table): Update.
 254         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
 255         (print_bcache_statistics, bcache_memory_used): Don't declare.
 256         (struct bcache): Move from bcache.c.  Add constructor, destructor,
 257         methods.  Rename all data members.
 258         * bcache.c (struct bcache): Move to bcache.h.
 259         (bcache::expand_hash_table): Rename from expand_hash_table.
 260         (bcache): Remove.
 261         (bcache::insert): Rename from bcache_full.
 262         (bcache::compare): Rename from bcache_compare.
 263         (bcache_xmalloc): Remove.
 264         (bcache::~bcache): Rename from bcache_xfree.
 265         (bcache::print_statistics): Rename from print_bcache_statistics.
 266         (bcache::memory_used): Rename from bcache_memory_used.
 267
 268 2019-03-07  Pedro Alves  <palves@redhat.com>
 269
 270         * infrun.c (normal_stop): Also check for
 271         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
 272
 273 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 274
 275         * f-lang.c (value_from_host_double): Moved to...
 276         * value.c (value_from_host_double): ...here.
 277         * value.h (value_from_host_double): Declare.
 278         * guile/scm-math.c (vlscm_convert_typed_number): Use
 279         value_from_host_double.
 280         (vlscm_convert_number): Likewise.
 281         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
 282         * python/py-value.c (convert_value_from_python): Likewise.
 283
 284 2019-03-06  Tom Tromey  <tom@tromey.com>
 285
 286         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
 287
 288 2019-03-06  Tom Tromey  <tom@tromey.com>
 289
 290         * utils.h (free_current_contents): Don't declare.
 291         * utils.c (free_current_contents): Remove.
 292
 293 2019-03-06  Tom Tromey  <tom@tromey.com>
 294
 295         * top.c (quit_force): Update.
 296         * main.c (captured_command_loop): Update.
 297         * common/new-op.c (operator new): Update.
 298         * common/common-exceptions.c (struct catcher)
 299         <save_cleanup_chain>: Remove member.
 300         (exceptions_state_mc_init): Update.
 301         (exception_try_scope_entry): Return nullptr.
 302         (exception_try_scope_exit, exception_rethrow)
 303         (throw_exception_sjlj, throw_exception_cxx): Update.
 304         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
 305         (all_cleanups, do_cleanups, discard_cleanups)
 306         (discard_final_cleanups, save_cleanups, save_final_cleanups)
 307         (restore_cleanups, restore_final_cleanups): Don't declare.
 308         (do_final_cleanups): Remove parameter.
 309         * common/cleanups.c (cleanup_chain, make_cleanup)
 310         (make_cleanup_dtor, all_cleanups, do_cleanups)
 311         (discard_my_cleanups, discard_cleanups)
 312         (discard_final_cleanups, save_my_cleanups, save_cleanups)
 313         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
 314         (null_cleanup): Remove.
 315         (do_final_cleanups): Remove parameter.
 316
 317 2019-03-06  Tom Tromey  <tom@tromey.com>
 318
 319         * remote.c (remote_target::remote_parse_stop_reply): Use
 320         unique_xmalloc_ptr.
 321
 322 2019-03-06  Tom Tromey  <tom@tromey.com>
 323
 324         * stabsread.c (struct stabs_field_info): Rename from field_info.
 325         <list, fnlist>: Add initializers.
 326         <obstack>: New member.
 327         (read_member_functions, read_struct_fields, read_baseclasses):
 328         Allocate on obstack.  Don't use cleanups.
 329         (read_one_struct_field, read_member_functions, read_struct_fields)
 330         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
 331         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
 332         (read_struct_type): Update.
 333
 334 2019-03-06  Tom Tromey  <tom@tromey.com>
 335
 336         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
 337         * common/filestuff.h (make_cleanup_close): Don't declare.
 338         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
 339         Remove.
 340
 341 2019-03-06  Tom Tromey  <tom@tromey.com>
 342
 343         * solib-aix.c: Use make_scope_exit.
 344
 345 2019-03-06  Tom Tromey  <tom@tromey.com>
 346
 347         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
 348         Use make_scope_exit.
 349
 350 2019-03-06  Tom Tromey  <tom@tromey.com>
 351
 352         * solib-svr4.c (disable_probes_interface): Remove parameter.
 353         (svr4_handle_solib_event): Use make_scope_exit.
 354
 355 2019-03-06  Tom Tromey  <tom@tromey.com>
 356
 357         * remote.c (struct stop_reply_deleter): Remove.
 358         (stop_reply_up): Update.
 359         (struct stop_reply): Derive from notif_event.  Don't typedef.
 360         <regcache>: Now a std::vector.
 361         (stop_reply_xfree): Remove.
 362         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
 363         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
 364         (remote_target::discard_pending_stop_replies): Use delete.
 365         (remote_target::remote_parse_stop_reply): Update.
 366         (remote_target::process_stop_reply): Update.
 367         * remote-notif.h (struct notif_event): Add virtual destructor.
 368         Remove "dtr" member.
 369         (struct notif_client) <alloc_event>: Return a unique_ptr.
 370         (notif_event_xfree): Don't declare.
 371         (notif_event_up): New typedef.
 372         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
 373         (notif_event_xfree, do_notif_event_xfree): Remove.
 374         (remote_notif_state_xfree): Update.
 375
 376 2019-03-06  Tom Tromey  <tom@tromey.com>
 377
 378         * infrun.c (displaced_step_clear_cleanup): Now a
 379         forward_scope_exit type.
 380         (displaced_step_prepare_throw): Update.
 381         (displaced_step_fixup): Update.
 382
 383 2019-03-06  Tom Tromey  <tom@tromey.com>
 384
 385         * inferior.h (class inferior): Update comment.
 386         * gdbthread.h (class thread_info): Update comment.
 387
 388 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
 389             Tom Tromey  <tom@tromey.com>
 390
 391         * stabsread.h (struct stab_section_list): Remove.
 392         (coffstab_build_psymtabs): Update.
 393         * dbxread.c (symbuf_sections): Now a std::vector.
 394         (sect_idx): New global.
 395         (fill_symbuf): Update.
 396         (coffstab_build_psymtabs): Change type of stabsects parameter.
 397         Update.
 398         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
 399         std::vector.
 400         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
 401         (coff_locate_sections): Update.
 402         (coff_symfile_read): Remove cleanups.  Update.
 403         (init_stringtab): Add storage parameter.
 404         (free_stringtab, free_stringtab_cleanup): Remove.
 405         (init_lineno): Add storage parameter.
 406         (free_linetab, free_linetab_cleanup): Remove.
 407
 408 2019-03-06  Pedro Alves  <palves@redhat.com>
 409
 410         * linux-fork.c (fork_info::clobber_regs): Delete.
 411         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
 412         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
 413         comment.  Adjust.
 414         (scoped_switch_fork_info::scoped_switch_fork_info)
 415         (checkpoint_command, linux_fork_context): Adjust
 416         fork_save_infrun_state calls.
 417
 418 2019-03-06  Pedro Alves  <palves@redhat.com>
 419
 420         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
 421         (inf_has_multiple_threads): Return 'bool' and rewrite using
 422         inferior_info::threads().
 423
 424 2019-03-06  Pedro Alves  <palves@redhat.com>
 425
 426         * linux-fork.c: Include <list>.
 427         (fork_list): Now a std::list instance.
 428         (fork_info): Add ctor, dtor, and in-class initialize all fields.
 429         (forks_exist_p, find_last_fork): Adjust.
 430         (new_fork): Delete.
 431         (one_fork_p): New.
 432         (add_fork): Adjust.
 433         (free_fork): Delete, folded into fork_info::~fork_info().
 434         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
 435         Adjust.
 436         (init_fork_list): Delete.
 437         (linux_fork_killall, linux_fork_mourn_inferior)
 438         (linux_fork_detach, info_checkpoints_command): Adjust.
 439         (_initialize_linux_fork): No longer call init_fork_list.
 440
 441 2019-03-06  Pedro Alves  <palves@redhat.com>
 442
 443         * linux-fork.c (new_fork): New, split out of ...
 444         (add_fork): ... this.  Return void.  Move "first fork" special
 445         case from here, to ...
 446         (checkpoint_command): ... here.
 447         * linux-linux.h (add_fork): Return void.
 448
 449 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 450
 451         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
 452
 453 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 454             Chris January  <chris.january@arm.com>
 455             David Lecomber  <david.lecomber@arm.com>
 456
 457         * f-exp.y: New token, UNOP_INTRINSIC.
 458         (exp): New pattern using UNOP_INTRINSIC token.
 459         (f77_keywords): Add 'abs' keyword.
 460         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
 461         (value_from_host_double): New function.
 462         (evaluate_subexp_f): Support UNOP_ABS.
 463
 464 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 465
 466         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
 467         types.
 468
 469 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 470
 471         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
 472         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
 473         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
 474
 475 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 476
 477         * f-exp.y (convert_to_kind_type): Handle more type kinds.
 478
 479 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 480             Chris January  <chris.january@arm.com>
 481
 482         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
 483         * f-exp.y: Define 'KIND' token.
 484         (exp): New pattern for KIND expressions.
 485         (ptype): Handle types with a kind extension.
 486         (direct_abs_decl): Extend to spot kind extensions.
 487         (f77_keywords): Add 'kind' to the list.
 488         (push_kind_type): New function.
 489         (convert_to_kind_type): New function.
 490         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
 491         * parse.c (operator_length_standard): Likewise.
 492         * parser-defs.h (enum type_pieces): Add tp_kind.
 493         * std-operator.def: Add UNOP_KIND.
 494
 495 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 496
 497         * f-exp.y (f_parse): Set yydebug.
 498
 499 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 500
 501         * f-lang.c (evaluate_subexp_f): New function.
 502         (exp_descriptor_f): New global.
 503         (f_language_defn): Use exp_descriptor_f instead of
 504         exp_descriptor_standard.
 505
 506 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 507
 508         * f-exp.y (struct token): Add comments.
 509         (dot_ops): Remove uppercase versions and the end marker.
 510         (f77_keywords): Likewise.
 511         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
 512         entries in the dot_ops array are case insensitive, and use
 513         strncasecmp to compare strings.  Also some whitespace cleanup in
 514         this area.  Similar for the f77_keywords array, except entries in
 515         this list might be case sensitive.
 516
 517 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 518
 519         * f-exp.y (struct f77_boolean_val): Add comments.
 520         (boolean_values): Remove uppercase versions, and end marker.
 521         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
 522         and use strncasecmp to achieve case insensitivity.  Additionally,
 523         perform whitespace cleanup around this code.
 524
 525 2019-03-06  Tom Tromey  <tromey@adacore.com>
 526
 527         * remote-sim.c (gdbsim_target_open): Use result of
 528         gdb_argv::release.
 529
 530 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
 531         Dirk Schubert  <dirk.schubert@arm.com>
 532         Chris January  <chris.january@arm.com>
 533
 534         * eval.c (evaluate_subexp_standard): Call Fortran argument
 535         wrapping logic.
 536         * f-lang.c (struct value): A value which can be passed into a
 537         Fortran function call.
 538         (fortran_argument_convert): Wrap Fortran arguments in a pointer
 539         where appropriate.
 540         (struct type): Value ready for a Fortran function call.
 541         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
 542         is needed.
 543         * f-lang.h (fortran_argument_convert): Declaration.
 544         (fortran_preserve_arg_pointer): Declaration.
 545         * infcall.c (value_arg_coerce): Call Fortran argument logic.
 546
 547 2019-03-05  Tom Tromey  <tromey@adacore.com>
 548
 549         * python/py-prettyprint.c (print_string_repr): Remove #if.
 550         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
 551
 552 2019-03-05  Tom Tromey  <tromey@adacore.com>
 553
 554         * target.c (the_dummy_target): Move later.  Change type to
 555         "dummy_target".
 556         (initialize_targets): Don't initialize the_dummy_target.
 557
 558 2019-03-05  Tom Tromey  <tromey@adacore.com>
 559
 560         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
 561         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
 562
 563 2019-03-05  Tom Tromey  <tromey@adacore.com>
 564
 565         * windows-nat.c (windows_nat_target::attach)
 566         (windows_nat_target::detach): Don't call gdb_flush.
 567         * valprint.c (generic_val_print, val_print, val_print_string):
 568         Don't call gdb_flush.
 569         * utils.c (defaulted_query): Don't call gdb_flush.
 570         * typeprint.c (print_type_scalar): Don't call gdb_flush.
 571         * target.c (target_announce_detach): Don't call gdb_flush.
 572         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
 573         * remote.c (extended_remote_target::attach): Don't call
 574         gdb_flush.
 575         * procfs.c (procfs_target::detach): Don't call gdb_flush.
 576         * printcmd.c (do_examine): Don't call gdb_flush.
 577         (info_display_command): Don't call gdb_flush.
 578         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
 579         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
 580         * memattr.c (info_mem_command): Don't call gdb_flush.
 581         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
 582         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
 583         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
 584         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
 585         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
 586         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
 587         (gnu_nat_target::detach): Don't call gdb_flush.
 588         * f-valprint.c (f_val_print): Don't call gdb_flush.
 589         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
 590         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
 591         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
 592         gdb_flush.
 593         * c-valprint.c (c_val_print): Don't call gdb_flush.
 594         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
 595
 596 2019-03-05  Tom Tromey  <tromey@adacore.com>
 597
 598         * varobj.c (update_dynamic_varobj_children): Update.
 599         (install_default_visualizer): Use reset, not release.
 600         * value.c (set_internalvar): Update.
 601         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
 602         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
 603         ATTRIBUTE_UNUSED_RESULT.
 604
 605 2019-03-05  Tom Tromey  <tromey@adacore.com>
 606
 607         * remote.c (class scoped_remote_fd) <release>: Add
 608         ATTRIBUTE_UNUSED_RESULT.
 609
 610 2019-03-05  Tom Tromey  <tromey@adacore.com>
 611
 612         * macroexp.c (struct macro_buffer) <release>: Add
 613         ATTRIBUTE_UNUSED_RESULT.
 614
 615 2019-03-05  Tom Tromey  <tromey@adacore.com>
 616
 617         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
 618         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
 619         ATTRIBUTE_UNUSED_RESULT.
 620
 621 2019-03-05  Tom Tromey  <tromey@adacore.com>
 622
 623         * common/scoped_fd.h (class scoped_fd) <release>: Add
 624         ATTRIBUTE_UNUSED_RESULT.
 625
 626 2019-03-05  Tom Tromey  <tromey@adacore.com>
 627
 628         * parser-defs.h (struct parser_state) <release>: Add
 629         ATTRIBUTE_UNUSED_RESULT.
 630
 631 2019-03-05  Tom Tromey  <tromey@adacore.com>
 632
 633         * utils.h (class gdb_argv) <release>: Add
 634         ATTRIBUTE_UNUSED_RESULT.
 635         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
 636
 637 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
 638
 639         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
 640         for-loop range, to avoid compiler warnings.
 641
 642         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
 643         avoid compiler warnings about unused variables.
 644
 645         * NEWS: Mention end of support for native debugging on MS-Windows
 646         before XP.
 647
 648         PR gdb/24292
 649         * common/netstuff.c:
 650         * gdbserver/gdbreplay.c
 651         * gdbserver/remote-utils.c:
 652         * ser-tcp.c:
 653         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
 654         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
 655         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
 656         'getaddrinfo' and 'freeaddrinfo' were not available before
 657         Windows XP, and mingw.org's MinGW headers by default define
 658         _WIN32_WINNT to 0x500.
 659
 660 2019-03-01  Gary Benson <gbenson@redhat.com>
 661
 662         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
 663
 664 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
 665             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 666
 667         PR gdb/8527
 668         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
 669         set_sigint_trap, clear_sigint_trap.
 670
 671 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 672
 673         * target.c (target_detach): Clear the regcache and the
 674         frame cache.
 675
 676 2019-02-27  Pedro Alves  <palves@redhat.com>
 677
 678         * utils.c (set_screen_size): When we cap the height/width sizes,
 679         tweak the corresponding command variable to show "unlimited":
 680
 681 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
 682             Pedro Alves  <palves@redhat.com>
 683
 684         * utils.c (set_screen_size): Reduce "infinite" rows and columns
 685         before calling rl_set_screen_size.
 686
 687 2019-02-27  Tom Tromey  <tromey@adacore.com>
 688
 689         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
 690         define.
 691         * python/py-value.c: Remove Python 2.4 workaround.
 692         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
 693         workaround.
 694         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
 695         Python 2.4 workaround.
 696         * python/python-internal.h: Remove Python 2.4 comment.
 697         (Py_ssize_t): Don't define.
 698         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
 699         (gdb_Py_DECREF): Remove Python 2.4 workaround.
 700         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
 701         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
 702         * python/python.c (do_start_initialization): Remove Python 2.4
 703         workaround.
 704         * python/py-prettyprint.c (class dummy_python_frame): Remove.
 705         (print_children): Remove Python 2.4 workaround.
 706         * python/py-inferior.c (buffer_procs): Remove Python 2.4
 707         workaround.
 708         (CHARBUFFERPROC_NAME): Remove.
 709         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
 710         Python 2.4 workaround.
 711
 712 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 713
 714         * NEWS: Note minimum Python version.
 715
 716 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
 717
 718         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
 719         code from these functions.  Remove corresponding ifdefs.  Use
 720         Py_buffer_up instead of explicit calls to PyBuffer_Release.
 721         Remove gotos and target of gotos.
 722         (infpy_search_memory): Likewise.
 723
 724 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 725
 726         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
 727         (hppa_gdbarch_init): Don't register deleted functions with
 728         gdbarch.
 729
 730 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 731
 732         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
 733         (h8300_unwind_sp): Delete.
 734         (h8300_dummy_id): Delete.
 735         (h8300_gdbarch_init): Don't register deleted functions with
 736         gdbarch.
 737
 738 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 739
 740         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
 741         (ft32_unwind_pc): Delete.
 742         (ft32_unwind_sp): Delete.
 743         (ft32_gdbarch_init): Don't register deleted functions with
 744         gdbarch.
 745
 746 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 747
 748         * gdb/frv-tdep.c (frv_dummy_id): Delete.
 749         (frv_unwind_pc): Delete.
 750         (frv_unwind_sp): Delete.
 751         (frv_gdbarch_init): Don't register deleted functions with
 752         gdbarch.
 753
 754 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 755
 756         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
 757         (riscv_unwind_pc): Delete.
 758         (riscv_unwind_sp): Delete.
 759         (riscv_gdbarch_init): Don't register deleted functions with
 760         gdbarch.
 761
 762 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 763
 764         * gdb/csky-tdep.c (csky_dummy_id): Delete.
 765         (csky_unwind_pc): Delete.
 766         (csky_unwind_sp): Delete.
 767         (csky_gdbarch_init): Don't register deleted functions with
 768         gdbarch.
 769
 770 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 771
 772         * gdb/cris-tdep.c (cris_dummy_id): Delete.
 773         (cris_unwind_pc): Delete.
 774         (cris_unwind_sp): Delete.
 775         (cris_gdbarch_init): Don't register deleted functions with
 776         gdbarch.
 777
 778 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 779
 780         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
 781         (bfin_unwind_pc): Delete.
 782         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
 783
 784 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 785
 786         * gdb/arm-tdep.c (arm_dummy_id): Delete.
 787         (arm_unwind_pc): Delete.
 788         (arm_unwind_sp): Delete.
 789         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
 790
 791 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 792
 793         * gdb/arc-tdep.c (arc_dummy_id): Delete.
 794         (arc_unwind_pc): Delete.
 795         (arc_unwind_sp): Delete.
 796         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
 797
 798 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 799
 800         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
 801         (alpha_unwind_pc): Delete.
 802         (alpha_gdbarch_init): Don't register deleted functions with
 803         gdbarch.
 804
 805 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 806
 807         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
 808         (aarch64_unwind_pc): Delete.
 809         (aarch64_unwind_sp): Delete.
 810         (aarch64_gdbarch_init): Don't register deleted functions with
 811         gdbarch.
 812
 813 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 814
 815         * gdbtypes.c (type_align): Don't consider static members when
 816         computing structure alignment.
 817
 818 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 819
 820         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
 821         return 0 for other types.
 822         * arch-utils.c (default_type_align): Always return 0.
 823         * gdbarch.h: Regenerate.
 824         * gdbarch.sh (type_align): Extend comment.
 825         * gdbtypes.c (type_align): Add additional comments, always call
 826         gdbarch_type_align before applying the default rules.
 827         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
 828         generic code will then apply a suitable default.
 829         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
 830         types, return 0 for other types.
 831
 832 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 833
 834         * NEWS: Create a new section for the next release branch.
 835         Rename the section of the current branch, now that it has
 836         been cut.
 837
 838 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 839
 840         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
 841         * version.in: Bump version to 8.3.50.DATE-git.
 842
 843 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
 844
 845         * aix-thread.c (ptid_cmp): Remove unused variable.
 846         (get_signaled_thread): Likewise.
 847         (store_regs_user_thread): Likewise.
 848         (store_regs_kernel_thread): Likewise.
 849         (fetch_regs_kernel_thread): Remove shadowed variable.
 850
 851 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 852
 853         * features/riscv/32bit-cpu.xml: Add register numbers.
 854         * features/riscv/32bit-fpu.c: Regenerate.
 855         * features/riscv/32bit-fpu.xml: Add register numbers.
 856         * features/riscv/64bit-cpu.xml: Add register numbers.
 857         * features/riscv/64bit-fpu.c: Regenerate.
 858         * features/riscv/64bit-fpu.xml: Add register numbers.
 859
 860 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
 861
 862         * NEWS: Mention two argument form of gdb.Value constructor.
 863         * python/py-value.c (convert_buffer_and_type_to_value): New
 864         function.
 865         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
 866         Add support for handling an optional second argument.  Call
 867         convert_buffer_and_type_to_value as appropriate.
 868         * python/python-internal.h (Py_buffer_deleter): New struct.
 869         (Py_buffer_up): New typedef.
 870
 871 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
 872
 873         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
 874         instead of releasing ownership.
 875
 876 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
 877
 878         * dwarf2read.c (open_and_init_dwp_file): Call
 879         elf_numsections instead of bfd_count_sections to initialize
 880         dwp_file->num_sections.
 881
 882 2019-02-25  Tom Tromey  <tromey@adacore.com>
 883
 884         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
 885
 886 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 887
 888         * gcore.in: Add '--readnever' option when invoking GDB.
 889
 890 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 891
 892         * MAINTAINERS: Update my email address.
 893
 894 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 895
 896         * build-id.c (build_id_to_debug_bfd_1): New function.
 897         (build_id_to_debug_bfd): Look for separate debug file in
 898         sysroot.
 899
 900 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 901
 902         * gdbarch.sh: Update the copyright year range that is placed into
 903         generated files.
 904
 905 2019-02-22  Keith Seitz  <keiths@redhat.com>
 906
 907         PR symtab/23853
 908         * linespec.c (create_sals_line_offset): Search for the default
 909         symtab's filename instead of its fullname.
 910
 911 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 912
 913         * NEWS: Update style defaults.
 914
 915 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 916
 917         * main.c (captured_main_1): Disable styling in batch mode.
 918
 919 2019-02-20  Tom Tromey  <tom@tromey.com>
 920
 921         * symtab.c (symtab_symbol_info): Fix typos.
 922
 923 2019-02-20  Tom Tromey  <tromey@adacore.com>
 924
 925         * findcmd.c (_initialize_mem_search): Use upper case for
 926         metasyntactic variables.
 927
 928 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
 929
 930         * aarch64-tdep.c (aarch64_add_reggroups): New function.
 931         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
 932
 933 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
 934
 935         * top.h (source_file_name): Change to std::string.
 936         * top.c (source_file_name): Likewise.
 937         (command_line_input): Adjust.
 938         * cli/cli-script.c (script_from_file): Adjust.
 939
 940 2019-02-19  Tom Tromey  <tromey@adacore.com>
 941
 942         * ravenscar-thread.c
 943         (ravenscar_thread_target::update_thread_list): Don't call
 944         ada_build_task_list.
 945         * ada-lang.h (ada_build_task_list): Don't declare.
 946         * ada-tasks.c (struct ada_tasks_inferior_data)
 947         <task_list_valid_p>: Now bool.
 948         (read_known_tasks, ada_task_list_changed)
 949         (ada_tasks_invalidate_inferior_data): Update.
 950         (read_known_tasks_array): Return bool.
 951         (read_known_tasks_list): Likewise.
 952         (read_known_tasks): Return void.
 953         (ada_build_task_list): Now static.
 954
 955 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 956
 957         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
 958         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
 959
 960 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 961
 962         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
 963         variant for ada_tasks_pspace_data_handle and
 964         ada_tasks_inferior_data_handle.
 965         (ada_tasks_pspace_data_cleanup): New function.
 966         (ada_tasks_inferior_data_cleanup): New function.
 967
 968 2019-02-17  Tom Tromey  <tom@tromey.com>
 969
 970         * macrotab.h (macro_source_fullname): Return a std::string.
 971         * macrotab.c (macro_include, check_for_redefinition)
 972         (macro_undef, macro_lookup_definition, foreach_macro)
 973         (foreach_macro_in_scope): Update.
 974         (macro_source_fullname): Return a std::string.
 975         * macrocmd.c (show_pp_source_pos): Update.
 976
 977 2019-02-17  Tom Tromey  <tom@tromey.com>
 978
 979         * macrocmd.c (show_pp_source_pos): Style the file names.
 980
 981 2019-02-17  Tom Tromey  <tom@tromey.com>
 982
 983         PR tui/24197:
 984         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 985
 986 2019-02-17  Tom Tromey  <tom@tromey.com>
 987
 988         * ada-lang.c (user_select_syms): Use filtered printing.
 989         * utils.c (wrap_style): New global.
 990         (desired_style): Remove.
 991         (emit_style_escape): Add stream parameter.
 992         (set_output_style, reset_terminal_style, prompt_for_continue):
 993         Update.
 994         (flush_wrap_buffer): Only flush gdb_stdout.
 995         (wrap_here): Set wrap_style.
 996         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 997         treat escape sequences as a character.  Change when wrap buffer is
 998         flushed.
 999         (fputs_styled): Do not set the output style when the default is
1000         requested.
1001         * ui-style.h (struct ui_file_style) <is_default>: New method.
1002         * source.c (print_source_lines_base): Emit escape sequences in one
1003         piece.
1004
1005 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1006
1007         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1008         integers and enumeration types.
1009
1010 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1011
1012         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1013         instead of lookup_symbol_in_language
1014         (do_exact_match): New function.
1015         (ada_get_symbol_name_matcher): Return do_exact_match when
1016         doing a verbatim match.
1017
1018 2019-02-15  Tom Tromey  <tromey@adacore.com>
1019
1020         * ravenscar-thread.c (ravenscar_thread_target::resume)
1021         (ravenscar_thread_target::wait): Special case wildcard requests.
1022
1023 2019-02-15  Tom Tromey  <tromey@adacore.com>
1024
1025         * ravenscar-thread.c (base_ptid): Remove.
1026         (struct ravenscar_thread_target) <close>: New method.
1027         <m_base_ptid>: New member.
1028         <update_inferior_ptid, active_task, task_is_currently_active,
1029         runtime_initialized>: Declare methods.
1030         <ravenscar_thread_target>: Add constructor.
1031         (ravenscar_thread_target::task_is_currently_active)
1032         (ravenscar_thread_target::update_inferior_ptid)
1033         (ravenscar_runtime_initialized): Rename.  Now methods.
1034         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1035         (ravenscar_thread_target::update_thread_list): Update.
1036         (ravenscar_thread_target::active_task): Now method.
1037         (ravenscar_thread_target::store_registers)
1038         (ravenscar_thread_target::prepare_to_store)
1039         (ravenscar_thread_target::prepare_to_store)
1040         (ravenscar_thread_target::mourn_inferior): Update.
1041         (ravenscar_inferior_created): Use "new" to create target.
1042         (ravenscar_thread_target::get_ada_task_ptid): Update.
1043         (_initialize_ravenscar): Don't initialize base_ptid.
1044         (ravenscar_ops): Remove global.
1045
1046 2019-02-15  Tom Tromey  <tromey@adacore.com>
1047
1048         * target.h (push_target): Declare new overload.
1049         * target.c (push_target): New overload, taking an rvalue reference.
1050         * remote.c (remote_target::open_1): Use push_target overload.
1051         * corelow.c (core_target_open): Use push_target overload.
1052
1053 2019-02-15  Tom Tromey  <tromey@adacore.com>
1054
1055         * ravenscar-thread.c (is_ravenscar_task)
1056         (ravenscar_task_is_currently_active): Return bool.
1057         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1058         (_initialize_ravenscar): Remove "(void)".
1059         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1060         Return bool.
1061
1062 2019-02-15  Tom Tromey  <tromey@adacore.com>
1063
1064         * ravenscar-thread.c (ravenscar_runtime_initializer)
1065         (has_ravenscar_runtime, get_running_thread_id)
1066         (ravenscar_thread_target::resume): Fix indentation.
1067
1068 2019-02-15  Tom Tromey  <tromey@adacore.com>
1069
1070         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1071         from ravenscar_arch_ops.
1072         (sparc_ravenscar_ops::fetch_registers)
1073         (sparc_ravenscar_ops::store_registers): Now methods.
1074         (sparc_ravenscar_prepare_to_store): Remove.
1075         (sparc_ravenscar_ops): Redefine.
1076         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1077         methods and destructor.  Remove members.
1078         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1079         (ravenscar_thread_target::store_registers)
1080         (ravenscar_thread_target::prepare_to_store): Update.
1081         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1082         Remove.
1083         (struct ppc_ravenscar_powerpc_ops): Derive from
1084         ravenscar_arch_ops.
1085         (ppc_ravenscar_powerpc_ops::fetch_registers)
1086         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1087         (ppc_ravenscar_powerpc_ops): Redefine.
1088         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1089         (ppc_ravenscar_e500_ops::fetch_registers)
1090         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1091         (ppc_ravenscar_e500_ops): Redefine.
1092         * aarch64-ravenscar-thread.c
1093         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1094         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1095         (aarch64_ravenscar_fetch_registers)
1096         (aarch64_ravenscar_store_registers): Now methods.
1097         (aarch64_ravenscar_ops): Redefine.
1098
1099 2019-02-15  Tom Tromey  <tromey@adacore.com>
1100
1101         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1102         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1103         (ravenscar_thread_target::stopped_by_watchpoint)
1104         (ravenscar_thread_target::stopped_data_address)
1105         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1106
1107 2019-02-15  Tom Tromey  <tromey@adacore.com>
1108
1109         * ravenscar-thread.c: Fix some typos.
1110
1111 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1112             Tom Tromey  <tromey@adacore.com>
1113
1114         * ada-lang.c (ada_exception_sal): Change addr_string to a
1115         std::string.
1116         (create_ada_exception_catchpoint): Update.
1117
1118 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1119             Tom Tromey  <tromey@adacore.com>
1120
1121         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1122         (bp_location_ops): Remove.
1123         (base_breakpoint_allocate_location): Update.
1124         (free_bp_location): Update.
1125         * ada-lang.c (class ada_catchpoint_location)
1126         <ada_catchpoint_location>: Remove ops parameter.
1127         (ada_catchpoint_location_dtor): Remove.
1128         (ada_catchpoint_location_ops): Remove.
1129         (allocate_location_exception): Update.
1130         * breakpoint.h (struct bp_location_ops): Remove.
1131         (class bp_location) <bp_location>: Remove bp_location_ops
1132         parameter.
1133         <~bp_location>: Add destructor.
1134         <ops>: Remove.
1135
1136 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1137             Pedro Alves  <palves@redhat.com>
1138
1139         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1140         'PATH_MAX'.
1141
1142 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1143             Samuel Thibault  <samuel.thibault@gnu.org>
1144             Thomas Schwinge  <thomas@codesourcery.com>
1145
1146         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1147         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1148
1149 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1150
1151         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1152         (check_empty): Use "const char *".
1153
1154         * gnu-nat.c (gnu_nat_target::detach): Instead of
1155         'detach_inferior (pid)' call
1156         'detach_inferior (find_inferior_pid (pid))'.
1157
1158         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1159         'nat/fork-inferior.o'.
1160         * gnu-nat.c: #include "nat/fork-inferior.h".
1161
1162         * gnu-nat.c (gnu_nat_target::detach): Instead of
1163         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1164         * gnu-nat.h: #include "inf-child.h".
1165         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1166         'i386_gnu_nat_target::fetch_registers'.
1167         (gnu_store_registers): Rename/move to
1168         'i386_gnu_nat_target::store_registers'.
1169
1170         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1171         * gnu-nat.h (mach_thread_info): New function.
1172         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1173
1174         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1175
1176 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1177
1178         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1179
1180 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1181
1182         * windows-nat.c (windows_add_thread): Add new parameter
1183         "main_thread_p" with default value set to false.  Update
1184         function documentation as well as all callers.
1185         (windows_delete_thread): Likewise.
1186         (fake_create_process): Update call to windows_add_thread.
1187         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1188         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1189         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1190         call to windows_delete_thread.
1191
1192 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1193
1194         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1195
1196 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1197
1198         * symfile.c (find_separate_debug_file): Use canonical path of
1199         sysroot with child_path instead of gdb_sysroot if it is valid.
1200
1201 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1202
1203         * symfile.c (find_separate_debug_file): Use child_path to
1204         determine if an object file is under a sysroot.
1205
1206 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1207
1208         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1209         unittests/child-path-selftests.c.
1210         * common/pathstuff.c (child_path): New function.
1211         * common/pathstuff.h (child_path): New prototype.
1212         * unittests/child-path-selftests.c: New file.
1213
1214 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1215
1216         * symfile.c (find_separate_debug_file): Look for separate debug
1217         files in debug directories under the sysroot.
1218
1219 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1220
1221         * symtab.h (struct minimal_symbol data_p): New const method.
1222         (struct minimal_symbol text_p): Likewise.
1223         * symtab.c (output_source_filename): Use file name style
1224         to print file name.
1225         (print_symbol_info): Likewise.
1226         (print_msymbol_info): Use address style to print addresses.
1227         Use function name style to print executable text symbols.
1228         (expand_symtab_containing_pc): Use data_p.
1229         (find_pc_sect_compunit_symtab): Likewise.
1230
1231 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1232
1233         * breakpoint.c (describe_other_breakpoints): Use address style
1234         to print addresses.
1235         (say_where): Likewise.
1236
1237 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1238
1239         * ada-typeprint.c (print_func_type): Print function name
1240         style to print function name.
1241         * c-typeprint.c (c_print_type_1): Likewise.
1242
1243 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1244
1245         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1246         for execve.
1247
1248 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1249
1250         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1251         type_stack.
1252
1253 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1254
1255         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1256         TYPE_CODE_REF types.
1257
1258 2019-02-08  Jim Wilson  <jimw@sifive.com>
1259
1260         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1261         (riscv_linux_fregset): New.
1262         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1263
1264 2019-02-07  Tom Tromey  <tom@tromey.com>
1265
1266         * thread.c (thread_cancel_execution_command): Update.
1267         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1268         methods.
1269         (struct thread_fsm_ops): Remove.
1270         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1271         (thread_fsm_should_stop, thread_fsm_return_value)
1272         (thread_fsm_set_finished, thread_fsm_finished_p)
1273         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1274         Don't declare.
1275         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1276         * infrun.c (clear_proceed_status_thread)
1277         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1278         (print_stop_event): Update.
1279         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1280         Add constructor.
1281         (step_command_fsm_ops): Remove.
1282         (new_step_command_fsm): Remove.
1283         (step_1): Update.
1284         (step_command_fsm::should_stop): Rename from
1285         step_command_fsm_should_stop.
1286         (step_command_fsm::clean_up): Rename from
1287         step_command_fsm_clean_up.
1288         (step_command_fsm::do_async_reply_reason): Rename from
1289         step_command_fsm_async_reply_reason.
1290         (struct until_next_fsm): Inherit from thread_fsm.  Add
1291         constructor.
1292         (until_next_fsm_ops): Remove.
1293         (new_until_next_fsm): Remove.
1294         (until_next_fsm::should_stop): Rename from
1295         until_next_fsm_should_stop.
1296         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1297         (until_next_fsm::do_async_reply_reason): Rename from
1298         until_next_fsm_async_reply_reason.
1299         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1300         constructor.  Change type of breakpoint.
1301         (finish_command_fsm_ops): Remove.
1302         (new_finish_command_fsm): Remove.
1303         (finish_command_fsm::should_stop): Rename from
1304         finish_command_fsm_should_stop.
1305         (finish_command_fsm::clean_up): Rename from
1306         finish_command_fsm_clean_up.
1307         (finish_command_fsm::return_value): Rename from
1308         finish_command_fsm_return_value.
1309         (finish_command_fsm::do_async_reply_reason): Rename from
1310         finish_command_fsm_async_reply_reason.
1311         (finish_command): Update.
1312         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1313         Add constructor.
1314         (call_thread_fsm_ops): Remove.
1315         (call_thread_fsm::call_thread_fsm): Rename from
1316         new_call_thread_fsm.
1317         (call_thread_fsm::should_stop): Rename from
1318         call_thread_fsm_should_stop.
1319         (call_thread_fsm::should_notify_stop): Rename from
1320         call_thread_fsm_should_notify_stop.
1321         (run_inferior_call, call_function_by_hand_dummy): Update.
1322         * cli/cli-interp.c (should_print_stop_to_console): Update.
1323         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1324         Add constructor.  Change type of location_breakpoint,
1325         caller_breakpoint.
1326         (until_break_fsm_ops): Remove.
1327         (new_until_break_fsm): Remove.
1328         (until_break_fsm::should_stop): Rename from
1329         until_break_fsm_should_stop.
1330         (until_break_fsm::clean_up): Rename from
1331         until_break_fsm_clean_up.
1332         (until_break_fsm::do_async_reply_reason): Rename from
1333         until_break_fsm_async_reply_reason.
1334         (until_break_command): Update.
1335         * thread-fsm.c: Remove.
1336         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1337
1338 2019-02-07  Tom Tromey  <tom@tromey.com>
1339
1340         * yy-remap.h: Add include guard.
1341         * xtensa-tdep.h: Add include guard.
1342         * xcoffread.h: Rename include guard.
1343         * varobj-iter.h: Add include guard.
1344         * tui/tui.h: Rename include guard.
1345         * tui/tui-winsource.h: Rename include guard.
1346         * tui/tui-wingeneral.h: Rename include guard.
1347         * tui/tui-windata.h: Rename include guard.
1348         * tui/tui-win.h: Rename include guard.
1349         * tui/tui-stack.h: Rename include guard.
1350         * tui/tui-source.h: Rename include guard.
1351         * tui/tui-regs.h: Rename include guard.
1352         * tui/tui-out.h: Rename include guard.
1353         * tui/tui-layout.h: Rename include guard.
1354         * tui/tui-io.h: Rename include guard.
1355         * tui/tui-hooks.h: Rename include guard.
1356         * tui/tui-file.h: Rename include guard.
1357         * tui/tui-disasm.h: Rename include guard.
1358         * tui/tui-data.h: Rename include guard.
1359         * tui/tui-command.h: Rename include guard.
1360         * tic6x-tdep.h: Add include guard.
1361         * target/waitstatus.h: Rename include guard.
1362         * target/wait.h: Rename include guard.
1363         * target/target.h: Rename include guard.
1364         * target/resume.h: Rename include guard.
1365         * target-float.h: Rename include guard.
1366         * stabsread.h: Add include guard.
1367         * rs6000-tdep.h: Add include guard.
1368         * riscv-fbsd-tdep.h: Add include guard.
1369         * regformats/regdef.h: Rename include guard.
1370         * record.h: Rename include guard.
1371         * python/python.h: Rename include guard.
1372         * python/python-internal.h: Rename include guard.
1373         * python/py-stopevent.h: Rename include guard.
1374         * python/py-ref.h: Rename include guard.
1375         * python/py-record.h: Rename include guard.
1376         * python/py-record-full.h: Rename include guard.
1377         * python/py-record-btrace.h: Rename include guard.
1378         * python/py-instruction.h: Rename include guard.
1379         * python/py-events.h: Rename include guard.
1380         * python/py-event.h: Rename include guard.
1381         * procfs.h: Add include guard.
1382         * proc-utils.h: Add include guard.
1383         * p-lang.h: Add include guard.
1384         * or1k-tdep.h: Rename include guard.
1385         * observable.h: Rename include guard.
1386         * nto-tdep.h: Rename include guard.
1387         * nat/x86-linux.h: Rename include guard.
1388         * nat/x86-linux-dregs.h: Rename include guard.
1389         * nat/x86-gcc-cpuid.h: Add include guard.
1390         * nat/x86-dregs.h: Rename include guard.
1391         * nat/x86-cpuid.h: Rename include guard.
1392         * nat/ppc-linux.h: Rename include guard.
1393         * nat/mips-linux-watch.h: Rename include guard.
1394         * nat/linux-waitpid.h: Rename include guard.
1395         * nat/linux-ptrace.h: Rename include guard.
1396         * nat/linux-procfs.h: Rename include guard.
1397         * nat/linux-osdata.h: Rename include guard.
1398         * nat/linux-nat.h: Rename include guard.
1399         * nat/linux-namespaces.h: Rename include guard.
1400         * nat/linux-btrace.h: Rename include guard.
1401         * nat/glibc_thread_db.h: Rename include guard.
1402         * nat/gdb_thread_db.h: Rename include guard.
1403         * nat/gdb_ptrace.h: Rename include guard.
1404         * nat/fork-inferior.h: Rename include guard.
1405         * nat/amd64-linux-siginfo.h: Rename include guard.
1406         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1407         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1408         * nat/aarch64-linux.h: Rename include guard.
1409         * nat/aarch64-linux-hw-point.h: Rename include guard.
1410         * mn10300-tdep.h: Add include guard.
1411         * mips-linux-tdep.h: Add include guard.
1412         * mi/mi-parse.h: Rename include guard.
1413         * mi/mi-out.h: Rename include guard.
1414         * mi/mi-main.h: Rename include guard.
1415         * mi/mi-interp.h: Rename include guard.
1416         * mi/mi-getopt.h: Rename include guard.
1417         * mi/mi-console.h: Rename include guard.
1418         * mi/mi-common.h: Rename include guard.
1419         * mi/mi-cmds.h: Rename include guard.
1420         * mi/mi-cmd-break.h: Rename include guard.
1421         * m2-lang.h: Add include guard.
1422         * location.h: Rename include guard.
1423         * linux-record.h: Rename include guard.
1424         * linux-nat.h: Add include guard.
1425         * linux-fork.h: Add include guard.
1426         * i386-darwin-tdep.h: Rename include guard.
1427         * hppa-linux-offsets.h: Add include guard.
1428         * guile/guile.h: Rename include guard.
1429         * guile/guile-internal.h: Rename include guard.
1430         * gnu-nat.h: Rename include guard.
1431         * gdb-stabs.h: Rename include guard.
1432         * frv-tdep.h: Add include guard.
1433         * f-lang.h: Add include guard.
1434         * event-loop.h: Add include guard.
1435         * darwin-nat.h: Rename include guard.
1436         * cp-abi.h: Rename include guard.
1437         * config/sparc/nm-sol2.h: Rename include guard.
1438         * config/nm-nto.h: Rename include guard.
1439         * config/nm-linux.h: Add include guard.
1440         * config/i386/nm-i386gnu.h: Rename include guard.
1441         * config/djgpp/nl_types.h: Rename include guard.
1442         * config/djgpp/langinfo.h: Rename include guard.
1443         * compile/gcc-cp-plugin.h: Add include guard.
1444         * compile/gcc-c-plugin.h: Add include guard.
1445         * compile/compile.h: Rename include guard.
1446         * compile/compile-object-run.h: Rename include guard.
1447         * compile/compile-object-load.h: Rename include guard.
1448         * compile/compile-internal.h: Rename include guard.
1449         * compile/compile-cplus.h: Rename include guard.
1450         * compile/compile-c.h: Rename include guard.
1451         * common/xml-utils.h: Rename include guard.
1452         * common/x86-xstate.h: Rename include guard.
1453         * common/version.h: Rename include guard.
1454         * common/vec.h: Rename include guard.
1455         * common/tdesc.h: Rename include guard.
1456         * common/selftest.h: Rename include guard.
1457         * common/scoped_restore.h: Rename include guard.
1458         * common/scoped_mmap.h: Rename include guard.
1459         * common/scoped_fd.h: Rename include guard.
1460         * common/safe-iterator.h: Rename include guard.
1461         * common/run-time-clock.h: Rename include guard.
1462         * common/refcounted-object.h: Rename include guard.
1463         * common/queue.h: Rename include guard.
1464         * common/ptid.h: Rename include guard.
1465         * common/print-utils.h: Rename include guard.
1466         * common/preprocessor.h: Rename include guard.
1467         * common/pathstuff.h: Rename include guard.
1468         * common/observable.h: Rename include guard.
1469         * common/netstuff.h: Rename include guard.
1470         * common/job-control.h: Rename include guard.
1471         * common/host-defs.h: Rename include guard.
1472         * common/gdb_wait.h: Rename include guard.
1473         * common/gdb_vecs.h: Rename include guard.
1474         * common/gdb_unlinker.h: Rename include guard.
1475         * common/gdb_unique_ptr.h: Rename include guard.
1476         * common/gdb_tilde_expand.h: Rename include guard.
1477         * common/gdb_sys_time.h: Rename include guard.
1478         * common/gdb_string_view.h: Rename include guard.
1479         * common/gdb_splay_tree.h: Rename include guard.
1480         * common/gdb_setjmp.h: Rename include guard.
1481         * common/gdb_ref_ptr.h: Rename include guard.
1482         * common/gdb_optional.h: Rename include guard.
1483         * common/gdb_locale.h: Rename include guard.
1484         * common/gdb_assert.h: Rename include guard.
1485         * common/filtered-iterator.h: Rename include guard.
1486         * common/filestuff.h: Rename include guard.
1487         * common/fileio.h: Rename include guard.
1488         * common/environ.h: Rename include guard.
1489         * common/common-utils.h: Rename include guard.
1490         * common/common-types.h: Rename include guard.
1491         * common/common-regcache.h: Rename include guard.
1492         * common/common-inferior.h: Rename include guard.
1493         * common/common-gdbthread.h: Rename include guard.
1494         * common/common-exceptions.h: Rename include guard.
1495         * common/common-defs.h: Rename include guard.
1496         * common/common-debug.h: Rename include guard.
1497         * common/cleanups.h: Rename include guard.
1498         * common/buffer.h: Rename include guard.
1499         * common/btrace-common.h: Rename include guard.
1500         * common/break-common.h: Rename include guard.
1501         * cli/cli-utils.h: Rename include guard.
1502         * cli/cli-style.h: Rename include guard.
1503         * cli/cli-setshow.h: Rename include guard.
1504         * cli/cli-script.h: Rename include guard.
1505         * cli/cli-interp.h: Rename include guard.
1506         * cli/cli-decode.h: Rename include guard.
1507         * cli/cli-cmds.h: Rename include guard.
1508         * charset-list.h: Add include guard.
1509         * buildsym-legacy.h: Rename include guard.
1510         * bfin-tdep.h: Add include guard.
1511         * ax.h: Rename include guard.
1512         * arm-linux-tdep.h: Add include guard.
1513         * arm-fbsd-tdep.h: Add include guard.
1514         * arch/xtensa.h: Rename include guard.
1515         * arch/tic6x.h: Add include guard.
1516         * arch/i386.h: Add include guard.
1517         * arch/arm.h: Rename include guard.
1518         * arch/arm-linux.h: Rename include guard.
1519         * arch/arm-get-next-pcs.h: Rename include guard.
1520         * arch/amd64.h: Add include guard.
1521         * arch/aarch64-insn.h: Rename include guard.
1522         * arch-utils.h: Rename include guard.
1523         * annotate.h: Add include guard.
1524         * amd64-darwin-tdep.h: Rename include guard.
1525         * aarch64-linux-tdep.h: Add include guard.
1526         * aarch64-fbsd-tdep.h: Add include guard.
1527         * aarch32-linux-nat.h: Add include guard.
1528
1529 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1530
1531         * macrotab.c (macro_define_internal): New function that
1532         factorizes macro_define_object_internal and macro_define_function
1533         code.
1534         (macro_define_object_internal): Use macro_define_internal.
1535         (macro_define_function): Likewise.
1536
1537 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1538
1539         * macrocmd.c (extract_identifier): Return
1540         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1541         callers.
1542
1543 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1544
1545         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1546
1547 2019-02-05  Tom Tromey  <tom@tromey.com>
1548
1549         * target.c (target_stack::unpush): Move assertion earlier.
1550
1551 2019-01-30  Tom Tromey  <tom@tromey.com>
1552
1553         PR python/23615:
1554         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1555         (gdbpy_parse_and_eval): Likewise.
1556         * python/python-internal.h (gdbpy_allow_threads): New class.
1557
1558 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1559
1560         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1561         (aarch64_fbsd_fpregmap): Move earlier.
1562         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1563         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1564         instead of individual calls to trad_frame_set_reg_addr.
1565         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1566         earlier.
1567         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1568         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1569         instead of individual calls to trad_frame_set_reg_addr.
1570
1571 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1572
1573         * CONTRIBUTE: Replace contribution list with wiki link.
1574
1575 2019-01-25  Tom Tromey  <tom@tromey.com>
1576
1577         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1578
1579 2019-01-25  Tom Tromey  <tom@tromey.com>
1580
1581         * xtensa-linux-nat.c: Fix common/ includes.
1582         * xml-support.h: Fix common/ includes.
1583         * xml-support.c: Fix common/ includes.
1584         * x86-linux-nat.c: Fix common/ includes.
1585         * windows-nat.c: Fix common/ includes.
1586         * varobj.h: Fix common/ includes.
1587         * varobj.c: Fix common/ includes.
1588         * value.c: Fix common/ includes.
1589         * valops.c: Fix common/ includes.
1590         * utils.c: Fix common/ includes.
1591         * unittests/xml-utils-selftests.c: Fix common/ includes.
1592         * unittests/utils-selftests.c: Fix common/ includes.
1593         * unittests/unpack-selftests.c: Fix common/ includes.
1594         * unittests/tracepoint-selftests.c: Fix common/ includes.
1595         * unittests/style-selftests.c: Fix common/ includes.
1596         * unittests/string_view-selftests.c: Fix common/ includes.
1597         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1598         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1599         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1600         * unittests/rsp-low-selftests.c: Fix common/ includes.
1601         * unittests/parse-connection-spec-selftests.c: Fix common/
1602         includes.
1603         * unittests/optional-selftests.c: Fix common/ includes.
1604         * unittests/offset-type-selftests.c: Fix common/ includes.
1605         * unittests/observable-selftests.c: Fix common/ includes.
1606         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1607         * unittests/memrange-selftests.c: Fix common/ includes.
1608         * unittests/memory-map-selftests.c: Fix common/ includes.
1609         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1610         * unittests/function-view-selftests.c: Fix common/ includes.
1611         * unittests/environ-selftests.c: Fix common/ includes.
1612         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1613         * unittests/common-utils-selftests.c: Fix common/ includes.
1614         * unittests/cli-utils-selftests.c: Fix common/ includes.
1615         * unittests/array-view-selftests.c: Fix common/ includes.
1616         * ui-file.c: Fix common/ includes.
1617         * tui/tui-io.c: Fix common/ includes.
1618         * tracepoint.h: Fix common/ includes.
1619         * tracepoint.c: Fix common/ includes.
1620         * tracefile-tfile.c: Fix common/ includes.
1621         * top.h: Fix common/ includes.
1622         * top.c: Fix common/ includes.
1623         * thread.c: Fix common/ includes.
1624         * target/waitstatus.h: Fix common/ includes.
1625         * target/waitstatus.c: Fix common/ includes.
1626         * target.h: Fix common/ includes.
1627         * target.c: Fix common/ includes.
1628         * target-memory.c: Fix common/ includes.
1629         * target-descriptions.c: Fix common/ includes.
1630         * symtab.h: Fix common/ includes.
1631         * symfile.c: Fix common/ includes.
1632         * stap-probe.c: Fix common/ includes.
1633         * spu-linux-nat.c: Fix common/ includes.
1634         * sparc-nat.c: Fix common/ includes.
1635         * source.c: Fix common/ includes.
1636         * solib.c: Fix common/ includes.
1637         * solib-target.c: Fix common/ includes.
1638         * ser-unix.c: Fix common/ includes.
1639         * ser-tcp.c: Fix common/ includes.
1640         * ser-pipe.c: Fix common/ includes.
1641         * ser-base.c: Fix common/ includes.
1642         * selftest-arch.c: Fix common/ includes.
1643         * s12z-tdep.c: Fix common/ includes.
1644         * rust-exp.y: Fix common/ includes.
1645         * rs6000-aix-tdep.c: Fix common/ includes.
1646         * riscv-tdep.c: Fix common/ includes.
1647         * remote.c: Fix common/ includes.
1648         * remote-notif.h: Fix common/ includes.
1649         * remote-fileio.h: Fix common/ includes.
1650         * remote-fileio.c: Fix common/ includes.
1651         * regcache.h: Fix common/ includes.
1652         * regcache.c: Fix common/ includes.
1653         * record-btrace.c: Fix common/ includes.
1654         * python/python.c: Fix common/ includes.
1655         * python/py-type.c: Fix common/ includes.
1656         * python/py-inferior.c: Fix common/ includes.
1657         * progspace.h: Fix common/ includes.
1658         * producer.c: Fix common/ includes.
1659         * procfs.c: Fix common/ includes.
1660         * proc-api.c: Fix common/ includes.
1661         * printcmd.c: Fix common/ includes.
1662         * ppc-linux-nat.c: Fix common/ includes.
1663         * parser-defs.h: Fix common/ includes.
1664         * osdata.c: Fix common/ includes.
1665         * obsd-nat.c: Fix common/ includes.
1666         * nat/x86-linux.c: Fix common/ includes.
1667         * nat/x86-linux-dregs.c: Fix common/ includes.
1668         * nat/x86-dregs.h: Fix common/ includes.
1669         * nat/x86-dregs.c: Fix common/ includes.
1670         * nat/ppc-linux.c: Fix common/ includes.
1671         * nat/mips-linux-watch.h: Fix common/ includes.
1672         * nat/mips-linux-watch.c: Fix common/ includes.
1673         * nat/linux-waitpid.c: Fix common/ includes.
1674         * nat/linux-ptrace.h: Fix common/ includes.
1675         * nat/linux-ptrace.c: Fix common/ includes.
1676         * nat/linux-procfs.c: Fix common/ includes.
1677         * nat/linux-personality.c: Fix common/ includes.
1678         * nat/linux-osdata.c: Fix common/ includes.
1679         * nat/linux-namespaces.c: Fix common/ includes.
1680         * nat/linux-btrace.h: Fix common/ includes.
1681         * nat/linux-btrace.c: Fix common/ includes.
1682         * nat/fork-inferior.c: Fix common/ includes.
1683         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1684         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1685         * nat/aarch64-linux.c: Fix common/ includes.
1686         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1687         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1688         * namespace.h: Fix common/ includes.
1689         * mips-linux-tdep.c: Fix common/ includes.
1690         * minsyms.c: Fix common/ includes.
1691         * mi/mi-parse.h: Fix common/ includes.
1692         * mi/mi-main.c: Fix common/ includes.
1693         * mi/mi-cmd-env.c: Fix common/ includes.
1694         * memrange.h: Fix common/ includes.
1695         * memattr.c: Fix common/ includes.
1696         * maint.h: Fix common/ includes.
1697         * maint.c: Fix common/ includes.
1698         * main.c: Fix common/ includes.
1699         * machoread.c: Fix common/ includes.
1700         * location.c: Fix common/ includes.
1701         * linux-thread-db.c: Fix common/ includes.
1702         * linux-nat.c: Fix common/ includes.
1703         * linux-fork.c: Fix common/ includes.
1704         * inline-frame.c: Fix common/ includes.
1705         * infrun.c: Fix common/ includes.
1706         * inflow.c: Fix common/ includes.
1707         * inferior.h: Fix common/ includes.
1708         * inferior.c: Fix common/ includes.
1709         * infcmd.c: Fix common/ includes.
1710         * inf-ptrace.c: Fix common/ includes.
1711         * inf-child.c: Fix common/ includes.
1712         * ia64-linux-nat.c: Fix common/ includes.
1713         * i387-tdep.c: Fix common/ includes.
1714         * i386-tdep.c: Fix common/ includes.
1715         * i386-linux-tdep.c: Fix common/ includes.
1716         * i386-linux-nat.c: Fix common/ includes.
1717         * i386-go32-tdep.c: Fix common/ includes.
1718         * i386-fbsd-tdep.c: Fix common/ includes.
1719         * i386-fbsd-nat.c: Fix common/ includes.
1720         * guile/scm-type.c: Fix common/ includes.
1721         * guile/guile.c: Fix common/ includes.
1722         * go32-nat.c: Fix common/ includes.
1723         * gnu-nat.c: Fix common/ includes.
1724         * gdbthread.h: Fix common/ includes.
1725         * gdbarch-selftests.c: Fix common/ includes.
1726         * gdb_usleep.c: Fix common/ includes.
1727         * gdb_select.h: Fix common/ includes.
1728         * gdb_bfd.c: Fix common/ includes.
1729         * gcore.c: Fix common/ includes.
1730         * fork-child.c: Fix common/ includes.
1731         * findvar.c: Fix common/ includes.
1732         * fbsd-nat.c: Fix common/ includes.
1733         * event-top.c: Fix common/ includes.
1734         * event-loop.c: Fix common/ includes.
1735         * dwarf2read.c: Fix common/ includes.
1736         * dwarf2loc.c: Fix common/ includes.
1737         * dwarf2-frame.c: Fix common/ includes.
1738         * dwarf-index-cache.c: Fix common/ includes.
1739         * dtrace-probe.c: Fix common/ includes.
1740         * disasm-selftests.c: Fix common/ includes.
1741         * defs.h: Fix common/ includes.
1742         * csky-tdep.c: Fix common/ includes.
1743         * cp-valprint.c: Fix common/ includes.
1744         * cp-support.h: Fix common/ includes.
1745         * cp-support.c: Fix common/ includes.
1746         * corelow.c: Fix common/ includes.
1747         * completer.h: Fix common/ includes.
1748         * completer.c: Fix common/ includes.
1749         * compile/compile.c: Fix common/ includes.
1750         * compile/compile-loc2c.c: Fix common/ includes.
1751         * compile/compile-cplus-types.c: Fix common/ includes.
1752         * compile/compile-cplus-symbols.c: Fix common/ includes.
1753         * command.h: Fix common/ includes.
1754         * cli/cli-dump.c: Fix common/ includes.
1755         * cli/cli-cmds.c: Fix common/ includes.
1756         * charset.c: Fix common/ includes.
1757         * build-id.c: Fix common/ includes.
1758         * btrace.h: Fix common/ includes.
1759         * btrace.c: Fix common/ includes.
1760         * breakpoint.h: Fix common/ includes.
1761         * breakpoint.c: Fix common/ includes.
1762         * ax.h:
1763         (enum agent_op): Fix common/ includes.
1764         * ax-general.c (struct aop_map): Fix common/ includes.
1765         * ax-gdb.c: Fix common/ includes.
1766         * auxv.c: Fix common/ includes.
1767         * auto-load.c: Fix common/ includes.
1768         * arm-tdep.c: Fix common/ includes.
1769         * arch/riscv.c: Fix common/ includes.
1770         * arch/ppc-linux-common.c: Fix common/ includes.
1771         * arch/i386.c: Fix common/ includes.
1772         * arch/arm.c: Fix common/ includes.
1773         * arch/arm-linux.c: Fix common/ includes.
1774         * arch/arm-get-next-pcs.c: Fix common/ includes.
1775         * arch/amd64.c: Fix common/ includes.
1776         * arch/aarch64.c: Fix common/ includes.
1777         * arch/aarch64-insn.c: Fix common/ includes.
1778         * arch-utils.c: Fix common/ includes.
1779         * amd64-windows-tdep.c: Fix common/ includes.
1780         * amd64-tdep.c: Fix common/ includes.
1781         * amd64-sol2-tdep.c: Fix common/ includes.
1782         * amd64-obsd-tdep.c: Fix common/ includes.
1783         * amd64-nbsd-tdep.c: Fix common/ includes.
1784         * amd64-linux-tdep.c: Fix common/ includes.
1785         * amd64-linux-nat.c: Fix common/ includes.
1786         * amd64-fbsd-tdep.c: Fix common/ includes.
1787         * amd64-fbsd-nat.c: Fix common/ includes.
1788         * amd64-dicos-tdep.c: Fix common/ includes.
1789         * amd64-darwin-tdep.c: Fix common/ includes.
1790         * agent.c: Fix common/ includes.
1791         * ada-lang.h: Fix common/ includes.
1792         * ada-lang.c: Fix common/ includes.
1793         * aarch64-tdep.c: Fix common/ includes.
1794
1795 2019-01-25  Tom Tromey  <tom@tromey.com>
1796
1797         * common/create-version.sh: Use common/version.h.
1798
1799 2019-01-24  Pedro Alves  <palves@redhat.com>
1800
1801         * infrun.c (signal_stop, signal_print, signal_program)
1802         (signal_catch, signal_pass): Now arrays instead of pointers.
1803         (update_signals_program_target, do_target_resume)
1804         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1805         * linux-nat.c (linux_nat_target::pass_signals)
1806         (linux_nat_target::create_inferior, linux_nat_target::attach):
1807         Adjust.
1808         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1809         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1810         * procfs.c (procfs_target::pass_signals): Adjust.
1811         * record-full.c (record_full_target::resume): Adjust.
1812         * remote.c (remote_target::pass_signals)
1813         (remote_target::program_signals): Adjust.
1814         * target-debug.h (target_debug_print_signals): Now takes a
1815         gdb::array_view as parameter.  Adjust.
1816         * target.h (target_ops) <pass_signals, program_signals>: Replace
1817         pointer and length parameters with gdb::array_view.
1818         (target_pass_signals, target_program_signals): Likewise.
1819         * target-delegates.c: Regenerate.
1820
1821 2019-01-24  Pedro Alves  <palves@redhat.com>
1822
1823         * common/forward-scope-exit.h
1824         (forward_scope_exit::forward_scope_exit): Pass arguments to
1825         m_bind_function directly, instead of creating a std::bind and
1826         copying that.
1827
1828 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1829
1830         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1831         for static members.
1832         (pass_in_v_vfp_candidate): Likewise.
1833
1834 2019-01-23  Tom Tromey  <tom@tromey.com>
1835             Pedro Alves  <palves@redhat.com>
1836
1837         * regcache.c (class regcache_invalidator): Remove.
1838         (regcache::raw_write): Use make_scope_exit.
1839
1840 2019-01-23  Tom Tromey  <tom@tromey.com>
1841
1842         * ui-out.h (class ui_out_emit_type): Update comment.
1843
1844 2019-01-23  Tom Tromey  <tom@tromey.com>
1845
1846         * infrun.c (fetch_inferior_event): Update comment.
1847
1848 2019-01-23  Tom Tromey  <tom@tromey.com>
1849             Pedro Alves  <palves@redhat.com>
1850
1851         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1852         parameter.
1853         (fetch_inferior_event): Use SCOPE_EXIT.
1854
1855
1856 2019-01-23  Tom Tromey  <tom@tromey.com>
1857             Pedro Alves  <palves@redhat.com>
1858
1859         * infrun.c (disable_thread_events): Delete.
1860         (stop_all_threads): Use SCOPE_EXIT.
1861
1862 2019-01-23  Tom Tromey  <tom@tromey.com>
1863             Pedro Alves  <palves@redhat.com>
1864
1865         * symfile.c: Include forward-scope-exit.h.
1866         (clear_symtab_users_cleanup): Replace forward declaration with
1867         a FORWARD_SCOPE_EXIT.
1868         (syms_from_objfile_1): Use the forward_scope_exit and
1869         gdb::optional instead of cleanup_function.
1870         (reread_symbols): Use the forward_scope_exit instead of
1871         cleanup_function.
1872         (clear_symtab_users_cleanup): Remove function.
1873
1874 2019-01-23  Tom Tromey  <tom@tromey.com>
1875             Pedro Alves  <palves@redhat.com>
1876
1877         * linux-nat.c: Include scope-exit.h.
1878         (cleanup_target_stop): Remove.
1879         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1880         SCOPE_EXIT.
1881
1882 2019-01-23  Tom Tromey  <tom@tromey.com>
1883             Pedro Alves  <palves@redhat.com>
1884
1885         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1886         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1887
1888 2019-01-23  Tom Tromey  <tom@tromey.com>
1889             Andrew Burgess  <andrew.burgess@embecosm.com>
1890             Pedro Alves  <palves@redhat.com>
1891
1892         * infrun.c (fetch_inferior_event): Use scope_exit.
1893         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1894         * top.c (execute_command): Use scope_exit.
1895         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1896         * utils.c (do_bpstat_clear_actions_cleanup)
1897         (make_bpstat_clear_actions_cleanup): Remove.
1898
1899 2019-01-23  Tom Tromey  <tom@tromey.com>
1900             Pedro Alves  <palves@redhat.com>
1901
1902         * infrun.c: Include "common/scope-exit.h"
1903         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1904         (wait_for_inferior): Use SCOPE_EXIT.
1905         (fetch_inferior_event): Use scope_exit.
1906
1907 2019-01-23  Tom Tromey  <tom@tromey.com>
1908             Pedro Alves  <palves@redhat.com>
1909
1910         * breakpoint.c (create_breakpoint): Remove cleanup.
1911
1912 2019-01-23  Tom Tromey  <tom@tromey.com>
1913             Andrew Burgess  <andrew.burgess@embecosm.com>
1914             Pedro Alves  <palves@redhat.com>
1915
1916 2019-01-23  Pedro Alves  <palves@redhat.com>
1917
1918         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1919
1920 2019-01-23  Pedro Alves  <palves@redhat.com>
1921             Andrew Burgess  <andrew.burgess@embecosm.com>
1922
1923         * gdbthread.h: Include "common/forward-scope-exit.h".
1924         (scoped_finish_thread_state): Redefine custom class in terms of
1925         forward_scope_exit.
1926
1927 2019-01-23  Pedro Alves  <palves@redhat.com>
1928             Andrew Burgess  <andrew.burgess@embecosm.com>
1929
1930         * common/forward-scope-exit.h: New file.
1931
1932 2019-01-23  Pedro Alves  <palves@redhat.com>
1933             Andrew Burgess  <andrew.burgess@embecosm.com>
1934             Tom Tromey  <tom@tromey.com>
1935
1936         * common/scope-exit.h: New file.
1937
1938 2019-01-23  Pedro Alves  <palves@redhat.com>
1939
1940         * common/preprocessor.h (ESC): Rename to ...
1941         (ESC_PARENS): ... this.
1942         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1943         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1944
1945 2019-01-23  Tom Tromey  <tom@tromey.com>
1946
1947         * language.h (class scoped_switch_to_sym_language_if_auto):
1948         Initialize m_lang in both cases.
1949
1950 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1951
1952         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1953         with XCNEW.
1954
1955 2019-01-22  Tom Tromey  <tom@tromey.com>
1956
1957         * corelow.c: Do not include sys/file.h.
1958
1959 2019-01-22  Tom Tromey  <tom@tromey.com>
1960
1961         * tui/tui-wingeneral.h: Include gdb_curses.h.
1962
1963 2019-01-22  Tom Tromey  <tom@tromey.com>
1964
1965         * source-cache.h (class source_cache) <get_source_lines,
1966         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1967
1968 2019-01-22  Tom Tromey  <tom@tromey.com>
1969
1970         * remote-fileio.h (struct remote_target): Declare.
1971
1972 2019-01-22  Tom Tromey  <tom@tromey.com>
1973
1974         * python/py-arch.c: Do not include py-ref.h.
1975         * python/py-bpevent.c: Do not include py-ref.h.
1976         * python/py-cmd.c: Do not include py-ref.h.
1977         * python/py-continueevent.c: Do not include py-ref.h.
1978         * python/py-event.h: Do not include py-ref.h.
1979         * python/py-evtregistry.c: Do not include py-ref.h.
1980         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1981         * python/py-frame.c: Do not include py-ref.h.
1982         * python/py-framefilter.c: Do not include py-ref.h.
1983         * python/py-function.c: Do not include py-ref.h.
1984         * python/py-infevents.c: Do not include py-ref.h.
1985         * python/py-linetable.c: Do not include py-ref.h.
1986         * python/py-objfile.c: Do not include py-ref.h.
1987         * python/py-param.c: Do not include py-ref.h.
1988         * python/py-prettyprint.c: Do not include py-ref.h.
1989         * python/py-progspace.c: Do not include py-ref.h.
1990         * python/py-symbol.c: Do not include py-ref.h.
1991         * python/py-symtab.c: Do not include py-ref.h.
1992         * python/py-type.c: Do not include py-ref.h.
1993         * python/py-unwind.c: Do not include py-ref.h.
1994         * python/py-utils.c: Do not include py-ref.h.
1995         * python/py-value.c: Do not include py-ref.h.
1996         * python/py-varobj.c: Do not include py-ref.h.
1997         * python/py-xmethods.c: Do not include py-ref.h.
1998         * python/python.c: Do not include py-ref.h.
1999         * varobj.c: Do not include py-ref.h.
2000
2001 2019-01-22  Tom Tromey  <tom@tromey.com>
2002
2003         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2004         keyword for bcache.
2005
2006 2019-01-22  Tom Tromey  <tom@tromey.com>
2007
2008         * compile/compile-cplus-types.c: Remove a comment by #include.
2009
2010 2019-01-22  Tom Tromey  <tom@tromey.com>
2011
2012         * compile/gcc-c-plugin.h: Include compile-internal.h.
2013
2014 2019-01-22  Tom Tromey  <tom@tromey.com>
2015
2016         * stabsread.c (EXTERN): Do not define.
2017         (symnum, next_symbol_text_func, processing_gcc_compilation)
2018         (within_function, global_sym_chain, global_stabs)
2019         (previous_stab_code, this_object_header_files)
2020         (n_this_object_header_files)
2021         (n_allocated_this_object_header_files): Define.
2022         * stabsread.h (EXTERN): Never define.  Use "extern".
2023
2024 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2025
2026         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2027         history_value.
2028
2029 2019-01-21  Tom Tromey  <tom@tromey.com>
2030
2031         * ui-out.c: Fix includes.
2032         * tui/tui-source.c: Fix includes.
2033         * target.c: Fix includes.
2034         * remote.c: Fix includes.
2035         * regcache.c: Fix includes.
2036         * python/py-block.c: Fix includes.
2037         * printcmd.c: Fix includes.
2038         * or1k-tdep.c: Fix includes.
2039         * mi/mi-main.c: Fix includes.
2040         * m32r-tdep.c: Fix includes.
2041         * csky-tdep.c: Fix includes.
2042         * compile/compile-cplus-types.c: Fix includes.
2043         * cli/cli-interp.c: Fix includes.
2044
2045 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2046
2047         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2048         for padding.
2049
2050 2019-01-16  Tom Tromey  <tom@tromey.com>
2051
2052         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2053         earlier.
2054         (struct objfile) <msymbols_range>: Move from top level.
2055         <msymbols>: New method.
2056         (class objfile_msymbols): Remove.
2057         * symtab.c (default_collect_symbol_completion_matches_break_on):
2058         Update.
2059         * symmisc.c (dump_msymbols): Update.
2060         * stabsread.c (scan_file_globals): Update.
2061         * objc-lang.c (info_selectors_command, info_classes_command)
2062         (find_methods): Update.
2063         * minsyms.c (find_solib_trampoline_target): Update.
2064         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2065         * coffread.c (coff_symfile_read): Update.
2066         * ada-lang.c (ada_lookup_simple_minsym)
2067         (ada_collect_symbol_completion_matches): Update.
2068
2069 2019-01-16  Tom Tromey  <tom@tromey.com>
2070
2071         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2072         type.  Remove no-argument constructor.
2073         <iterator::operator++>: Simplify.
2074         <begin>: Update.
2075         <end>: Use minimal_symbol_count.
2076
2077 2019-01-16  Tom Tromey  <tom@tromey.com>
2078
2079         * objfiles.h (struct objfile) <psymtabs>: New method.
2080         (class objfile_psymtabs): Remove.
2081         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2082         typedef.
2083         <range>: New method.
2084         (require_partial_symbols): Change return type.
2085         * psymtab.c (require_partial_symbols)
2086         (psym_expand_symtabs_matching): Update.
2087         * mdebugread.c (parse_partial_symbols): Update.
2088         * dbxread.c (dbx_end_psymtab): Update.
2089
2090 2019-01-15  Tom Tromey  <tom@tromey.com>
2091
2092         * symtab.c (lookup_objfile_from_block)
2093         (lookup_symbol_in_objfile_symtabs)
2094         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2095         (find_line_symtab, info_sources_command)
2096         (default_collect_symbol_completion_matches_break_on)
2097         (make_source_files_completion_list): Update.
2098         * symmisc.c (print_objfile_statistics, dump_objfile)
2099         (maintenance_print_symbols, maintenance_info_symtabs)
2100         (maintenance_check_symtabs, maintenance_info_line_tables):
2101         Update.
2102         * source.c (select_source_symtab)
2103         (forget_cached_source_info_for_objfile): Update.
2104         * objfiles.h (class objfile_compunits): Remove.
2105         (struct objfile) <compunits_range>: New typedef.
2106         (compunits): New method.
2107         * objfiles.c (objfile_relocate1): Update.
2108         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2109         * maint.c (count_symtabs_and_blocks): Update.
2110         * linespec.c (iterate_over_all_matching_symtabs): Update.
2111         * cp-support.c (add_symbol_overload_list_qualified): Update.
2112         * coffread.c (coff_symtab_read): Update.
2113         * ada-lang.c (add_nonlocal_symbols)
2114         (ada_collect_symbol_completion_matches)
2115         (ada_add_global_exceptions): Update.
2116
2117 2019-01-15  Tom Tromey  <tom@tromey.com>
2118
2119         * progspace.h (program_space) <objfiles_safe_range>: New
2120         typedef.
2121         <objfiles_safe>: New method.
2122         * objfiles.h (class all_objfiles_safe): Remove.
2123         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2124         * jit.c (jit_inferior_exit_hook): Update.
2125
2126 2019-01-17  Tom Tromey  <tom@tromey.com>
2127
2128         * progspace.h (program_space) <objfiles_range>: New typedef.
2129         <objfiles>: New method.
2130         <objfiles_head>: Rename from objfiles.
2131         (object_files): Update.
2132         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2133         * guile/scm-pretty-print.c
2134         (ppscm_find_pretty_printer_from_objfiles): Update.
2135         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2136         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2137         Update.
2138         * python/py-progspace.c (pspy_get_objfiles): Update.
2139         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2140         Update.
2141         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2142         (objfpy_lookup_objfile_by_build_id): Update.
2143         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2144         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2145         Update.
2146         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2147         (expand_symtab_containing_pc, lookup_objfile_from_block)
2148         (lookup_static_symbol, basic_lookup_transparent_type)
2149         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2150         (find_line_symtab, info_sources_command)
2151         (default_collect_symbol_completion_matches_break_on)
2152         (make_source_files_completion_list, find_main_name): Update.
2153         * symmisc.c (print_symbol_bcache_statistics)
2154         (print_objfile_statistics, maintenance_print_symbols)
2155         (maintenance_print_msymbols, maintenance_print_objfiles)
2156         (maintenance_info_symtabs, maintenance_check_symtabs)
2157         (maintenance_expand_symtabs, maintenance_info_line_tables):
2158         Update.
2159         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2160         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2161         (map_overlay_command, unmap_overlay_command)
2162         (simple_overlay_update, expand_symtabs_matching)
2163         (map_symbol_filenames): Update.
2164         * symfile-debug.c (set_debug_symfile): Update.
2165         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2166         Update.
2167         * source.c (select_source_symtab, forget_cached_source_info):
2168         Update.
2169         * solib.c (solib_read_symbols): Update.
2170         * solib-spu.c (append_ocl_sos): Update.
2171         * psymtab.c (maintenance_print_psymbols)
2172         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2173         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2174         * printcmd.c (info_symbol_command): Update.
2175         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2176         Update.
2177         * objfiles.h (class all_objfiles): Remove.
2178         * objfiles.c (have_partial_symbols, have_full_symbols)
2179         (have_minimal_symbols, qsort_cmp, update_section_map)
2180         (shared_objfile_contains_address_p)
2181         (default_iterate_over_objfiles_in_search_order): Update.
2182         * objc-lang.c (info_selectors_command, info_classes_command)
2183         (find_methods): Update.
2184         * minsyms.c (find_solib_trampoline_target): Update.
2185         * maint.c (maintenance_info_sections)
2186         (maintenance_translate_address, count_symtabs_and_blocks):
2187         Update.
2188         * main.c (captured_main_1): Update.
2189         * linux-thread-db.c (try_thread_db_load_from_pdir)
2190         (has_libpthread): Update.
2191         * linespec.c (iterate_over_all_matching_symtabs)
2192         (search_minsyms_for_name): Update.
2193         * jit.c (jit_find_objf_with_entry_addr): Update.
2194         * hppa-tdep.c (find_unwind_entry)
2195         (hppa_lookup_stub_minimal_symbol): Update.
2196         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2197         Update.
2198         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2199         (elf_gnu_ifunc_resolve_by_got): Update.
2200         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2201         * dwarf-index-write.c (save_gdb_index_command): Update.
2202         * cp-support.c (add_symbol_overload_list_qualified): Update.
2203         * breakpoint.c (create_overlay_event_breakpoint)
2204         (create_longjmp_master_breakpoint)
2205         (create_std_terminate_master_breakpoint)
2206         (create_exception_master_breakpoint): Update.
2207         * blockframe.c (find_pc_partial_function): Update.
2208         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2209         (ada_collect_symbol_completion_matches)
2210         (ada_add_global_exceptions): Update.
2211
2212 2019-01-17  Tom Tromey  <tom@tromey.com>
2213
2214         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2215         declare VEC.
2216         (solib_target_parse_libraries): Change return type.
2217         (library_list_start_segment, library_list_start_section)
2218         (library_list_end_library, library_list_start_library); Update.
2219         (solib_target_free_library_list): Remove.
2220         (solib_target_parse_libraries): Remove cleanup.  Change return
2221         type.
2222         (solib_target_current_sos): Update.
2223
2224 2019-01-17  Tom Tromey  <tromey@bapiya>
2225
2226         * valprint.c: Replace "the the" with "the".
2227         * symtab.c: Replace "the the" with "the".
2228         * solib.c: Replace "the the" with "the".
2229         * solib-dsbt.c: Replace "the the" with "the".
2230         * linespec.c: Replace "the the" with "the".
2231         * dwarf2loc.h: Replace "the the" with "the".
2232         * amd64-windows-tdep.c: Replace "the the" with "the".
2233         * aarch64-tdep.c: Replace "the the" with "the".
2234
2235 2019-01-16  Keith Seitz  <keiths@redhat.com>
2236
2237         PR gdb/23773
2238         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2239         <builder>: Rename to ..
2240         <m_builder>: ... this and make private.
2241         (dwarf2_cu::get_builder): New method.  Change all users of
2242         `builder' to use this method.
2243         (dwarf2_start_symtab): Move to ...
2244         (dwarf2_cu::start_symtab): ... here.  Update all callers
2245         (setup_type_unit_groups): Move to ...
2246         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2247         callers.
2248         (dwarf2_cu::reset_builder): New method.
2249         (process_full_compunit, process_full_type_unit): Use
2250         dwarf2_cu::reset_builder.
2251         (follow_die_offset): Record the ancestor CU if it is different
2252         from the followed DIE's CU.
2253         (follow_die_sig_1): Likewise.
2254
2255 2019-01-15  Tom Tromey  <tom@tromey.com>
2256
2257         * remote.c (class remote_state) <buf>: Now a char_vector.
2258         <buf_size>: Remove.
2259         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2260         parameter.
2261         (remote_target::getpkt_or_notif_sane_1)
2262         (remote_target::getpkt_sane)
2263         (remote_target::getpkt_or_notif_sane): Likewise.
2264         (class remote_target) <putpkt>: New overload.
2265         (remote_target::read_frame): Change type of "buf_p".  Remove
2266         sizeof_p parameter.
2267         (packet_ok): New overload.
2268         (packet_check_result): New overload.
2269         Update all uses.
2270
2271 2019-01-14  Tom Tromey  <tom@tromey.com>
2272
2273         * remote-notif.c (handle_notification, remote_notif_ack)
2274         (remote_notif_parse): Make "buf" const.
2275         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2276         const.
2277         (remote_notif_parse, remote_notif_ack, handle_notification):
2278         Likewise.
2279         * remote.c (remote_notif_stop_parse): Make "buf" const.
2280         (remote_target::remote_parse_stop_reply): Make "buf" const.
2281         (remote_notif_stop_ack): Make "buf" const.
2282
2283 2019-01-14  Tom Tromey  <tom@tromey.com>
2284
2285         * remote.c (remote_console_output): Make parameter const.
2286
2287 2019-01-14  Tom Tromey  <tom@tromey.com>
2288
2289         * target-debug.h (target_debug_print_signals): Constify.
2290         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2291         * procfs.c (procfs_target::pass_signals): Update.
2292         * linux-nat.c (linux_nat_target::pass_signals): Update.
2293         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2294         * target-delegates.c: Rebuild.
2295         * remote.c (remote_target::program_signals): Update.
2296         (remote_target::pass_signals): Update.
2297         * target.c (target_pass_signals): Constify argument.
2298         (target_program_signals): Likewise.
2299         * target.h (struct target_ops) <pass_signals, program_signals>:
2300         Constify argument.
2301         (target_pass_signals, target_program_signals): Constify argument.
2302
2303 2019-01-14  Tom Tromey  <tom@tromey.com>
2304
2305         PR tui/28819:
2306         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2307
2308 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2309
2310         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2311         field.
2312         * rs6000-tdep.c: Include reggroups.h.
2313         (IS_V_ALIAS_PSEUDOREG): Define.
2314         (rs6000_register_name): Return names for the "vX" aliases.
2315         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2316         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2317         aliases.  Call default_register_reggroup_p for all other
2318         pseudo-registers.
2319         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2320         New functions.
2321         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2322         Handle "vX" aliases.
2323         (v_alias_pseudo_register_collect): New function.
2324         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2325         (rs6000_gdbarch_init): Initialize "vX" aliases as
2326         pseudo-registers.  Restore registration of
2327         rs6000_pseudo_register_reggroup_p with
2328         set_tdesc_pseudo_register_reggroup_p.
2329
2330 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2331
2332         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2333         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2334         set_gdbarch_num_pseudo_regs.
2335
2336 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2337
2338         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2339         Remove arg prefixname, add do_set and do_show.
2340         Add member functions set_list and show_list.
2341         * cli/cli-style.c (class cli_style_option): Update accordingly.
2342         (style_set_list): Move to file scope.
2343         (style_show_list): Likewise.
2344         (set_style): Call help_list.
2345         (show_style): Call cmd_show_list.
2346         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2347         Update to use the new macro.
2348
2349 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2350
2351         * ada-lang.c (_initialize_ada_language): Expand the help text
2352         for the "catch exception" command.
2353
2354 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2355
2356         * symtab.c (matching_obj_sections): Initialize obj,
2357         declare it closer to its usage.
2358
2359 2019-01-10  Tom Tromey  <tom@tromey.com>
2360
2361         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2362         (basic_inf_threads_range): Remove.
2363         (inf_threads_range, inf_non_exited_threads_range)
2364         (safe_inf_threads_range): Use next_adapter.
2365
2366 2019-01-10  Keith Seitz  <keiths@redhat.com>
2367
2368         PR gdb/23712
2369         PR symtab/23010
2370         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2371         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2372
2373 2019-01-10  Keith Seitz  <keiths@redhat.com>
2374
2375         PR gdb/23712
2376         PR symtab/23010
2377         * dictionary.c (pending_to_vector): Remove.
2378         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2379         Remove _1 suffix, replacing functions of the same name.  Update
2380         all callers.
2381         (dict_create_hashed, dict_create_hashed_expandable)
2382         (dict_create_linear, dict_create_linear_expandable, dict_free)
2383         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2384         Make functions static.
2385
2386 2019-01-10  Keith Seitz  <keiths@redhat.com>
2387
2388         PR gdb/23712
2389         PR symtab/23010
2390         * dictionary.h (struct dictionary): Replace declaration with
2391         multidictionary.
2392         (dict_create_hashed, dict_create_hashed_expandable)
2393         (dict_create_linear, dict_create_linear_expandable)
2394         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2395         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2396         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2397         taking multidictionary argument.
2398         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2399         * block.h (struct block) <dict>: Change to multidictionary
2400         and rename `multidict'.
2401         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2402         symmisc.c: Update all dictionary references to multidictionary.
2403
2404 2019-01-10  Keith Seitz  <keiths@redhat.com>
2405
2406         PR gdb/23712
2407         PR symtab/23010
2408         * dictionary.c: Include unordered_map.
2409         (pending_to_vector): New function.
2410         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2411         Rewrite the non-"_1" functions to take vector instead
2412         of linked list.
2413         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2414         "new" _1 versions of the same name.
2415         (multidictionary): Define.
2416         (std::hash<enum language): New definition.
2417         (collate_pending_symbols_by_language, mdict_create_hashed)
2418         (mdict_create_hashed_expandable, mdict_create_linear)
2419         (mdict_create_linear_expandable, mdict_free)
2420         (find_language_dictionary, create_new_language_dictionary)
2421         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2422         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2423         (mdict_size, mdict_empty): New functions.
2424         * dictionary.h (mdict_iterator): Define.
2425
2426 2019-01-10  Pedro Alves  <palves@redhat.com>
2427
2428         * breakpoint.c (read_uploaded_action)
2429         (create_tracepoint_from_upload): Adjust to use
2430         gdb::unique_xmalloc_ptr.
2431         * ctf.c (ctf_write_uploaded_tp):
2432         (SET_ARRAY_FIELD): Use emplace_back.
2433         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2434         * tracefile-tfile.c (tfile_write_uploaded_tp):
2435         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2436         gdb::unique_xmalloc_ptr.
2437         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2438         at_string, cond_string, cmd_strings>: Replace char pointers
2439         with gdb::unique_xmalloc_ptr.
2440
2441 2019-01-10  Pedro Alves  <palves@redhat.com>
2442
2443         * solib-target.c (library_list_start_library): Don't xstrdup name.
2444
2445 2019-01-10  Pedro Alves  <palves@redhat.com>
2446
2447         * mdebugread.c (parse_partial_symbols): Use
2448         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2449
2450 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2451
2452         * linux-fork.c (scoped_switch_fork_info)
2453         <~scoped_switch_fork_info>: Fix incorrect variable name.
2454
2455 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2456
2457         * linux-fork.c (scoped_switch_fork_info)
2458         <scoped_switch_fork_info>: Make explicit.
2459         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2460
2461 2019-01-10  Tom Tromey  <tom@tromey.com>
2462
2463         * objfiles.h (objfile::reset_psymtabs): Update.
2464         * objfiles.c (objfile::objfile): Update.
2465         * psymtab.h (psymtab_storage::obstack): Update.
2466         (psymtab_storage::m_obstack): Use gdb::optional.
2467         (class psymtab_storage): Update comment.  Remove objfile
2468         parameter.
2469         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2470
2471 2019-01-10  Tom Tromey  <tom@tromey.com>
2472
2473         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2474         <free_psymtabs>: Now private.
2475         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2476         (allocate_psymtab): Use new method.
2477
2478 2019-01-10  Tom Tromey  <tom@tromey.com>
2479
2480         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2481         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2482         * mdebugread.c (parse_partial_symbols): Use
2483         allocate_dependencies.
2484         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2485         allocate_dependencies.
2486         (process_psymtab_comp_unit_reader)
2487         (build_type_psymtab_dependencies): Likewise.
2488         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2489
2490 2019-01-10  Tom Tromey  <tom@tromey.com>
2491
2492         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2493         PSYMBOL_SET_LANGUAGE.
2494         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2495
2496 2019-01-10  Tom Tromey  <tom@tromey.com>
2497
2498         * psymtab.h (psymtab_storage::obstack): New method.
2499         <m_obstack>: Rename from obstack; now private.
2500         * psymtab.c (psymtab_storage): Update.
2501         * dwarf2read.c (create_addrmap_from_index)
2502         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2503         Update.
2504
2505 2019-01-10  Tom Tromey  <tom@tromey.com>
2506
2507         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2508         * objfiles.h (objfile::reset_psymtabs): New method.
2509
2510 2019-01-10  Tom Tromey  <tom@tromey.com>
2511
2512         * symmisc.c (print_symbol_bcache_statistics): Update.
2513         (print_objfile_statistics): Update.
2514         * symfile.c (reread_symbols): Update.
2515         * psymtab.h (class psymtab_storage): New.
2516         * psymtab.c (psymtab_storage): New constructor.
2517         (~psymtab_storage): New destructor.
2518         (require_partial_symbols): Update.
2519         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2520         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2521         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2522         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2523         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2524         (start_psymtab_common, end_psymtab_common)
2525         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2526         (allocate_psymtab): Update.
2527         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2528         Update.
2529         (dump_psymtab_addrmap, maintenance_print_psymbols)
2530         (maintenance_check_psymtabs): Update.
2531         (class objfile_psymtabs): Move to objfiles.h.
2532         * psympriv.h (discard_psymtab): Now inline.
2533         (psymtab_discarder::psymtab_discarder): Update.
2534         (psymtab_discarder::~psymtab_discarder): Update.
2535         (ALL_OBJFILE_PSYMTABS): Rewrite.
2536         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2537         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2538         Remove fields.
2539         <partial_symtabs>: New field.
2540         (class objfile_psymtabs): Move from psymtab.h.  Update.
2541         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2542         psymbol_cache.
2543         (objfile::~objfile): Don't destroy psymbol_cache.
2544         * mdebugread.c (parse_partial_symbols): Update.
2545         * dwarf2read.c (create_addrmap_from_index)
2546         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2547         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2548         (add_partial_subprogram, dwarf2_ranges_read): Update.
2549         * dwarf-index-write.c (write_address_map)
2550         (write_one_signatured_type, recursively_write_psymbols)
2551         (class debug_names, class debug_names, write_psymtabs_to_index):
2552         Update.
2553
2554 2019-01-10  Tom Tromey  <tom@tromey.com>
2555
2556         * symtab.h (SYMBOL_SET_NAMES): Update.
2557         (symbol_set_names): Update.
2558         (MSYMBOL_SET_NAMES): Update.
2559         * symtab.c (symbol_set_names): Change argument to be an
2560         objfile_per_bfd_storage.
2561         * psymtab.c (add_psymbol_to_bcache): Update.
2562         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2563
2564 2019-01-10  Tom Tromey  <tom@tromey.com>
2565
2566         * symtab.c (create_demangled_names_hash): Change argument to be an
2567         objfile_per_bfd_storage.
2568         (symbol_set_names): Update.
2569
2570 2019-01-10  Tom Tromey  <tom@tromey.com>
2571
2572         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2573         init_psymbol_list.
2574         * psymtab.c (init_psymbol_list): Do nothing if already called.
2575         * psympriv.h (init_psymbol_list): Add comment.
2576         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2577         init_psymbol_list.
2578         * dbxread.c (dbx_symfile_read): Unconditionally call
2579         init_psymbol_list.
2580
2581 2019-01-10  Tom Tromey  <tom@tromey.com>
2582
2583         * xcoffread.c (scan_xcoff_symtab): Update.
2584         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2585         "where".
2586         * mdebugread.c (parse_partial_symbols)
2587         (handle_psymbol_enumerators): Update.
2588         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2589         * dbxread.c (read_dbx_symtab): Update.
2590         * psympriv.h (psymbol_placement): New enum.
2591         (add_psymbol_to_list): Update.
2592
2593 2019-01-10  Tom Tromey  <tom@tromey.com>
2594
2595         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2596         static_psymbols parameters.
2597         (scan_xcoff_symtab): Update.
2598         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2599         static_psymbols parameters.
2600         * psympriv.h (start_psymtab_common): Update.
2601         * mdebugread.c (parse_partial_symbols): Update.
2602         * dwarf2read.c (create_partial_symtab): Update.
2603         * dbxread.c (read_dbx_symtab): Update.
2604         (start_psymtab): Remove global_psymbols and static_psymbols
2605         parameters.
2606
2607 2019-01-10  Tom Tromey  <tom@tromey.com>
2608
2609         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2610         * psymtab.c (allocate_psymtab): Add comment.
2611         * psympriv.h (allocate_psymtab): Add comment.
2612         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2613         initializations.
2614         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2615
2616 2019-01-10  Tom Tromey  <tom@tromey.com>
2617
2618         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2619         Don't declare.
2620         * mipsread.c: Include mdebugread.h.
2621         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2622         Declare.
2623         * elfread.c: Include mdebugread.h.
2624
2625 2019-01-09  Tom Tromey  <tom@tromey.com>
2626
2627         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2628         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2629         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2630         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2631         (psym_lookup_symbol, psym_find_last_source_symtab)
2632         (psym_forget_cached_source_info, psym_print_stats)
2633         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2634         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2635         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2636         (psym_find_compunit_symtab_by_address)
2637         (maintenance_print_psymbols, maintenance_info_psymtabs)
2638         (maintenance_check_psymtabs): Use ranged for.
2639         * psymtab.h (class objfile_psymtabs): New.
2640         (require_partial_symbols): Return objfile_psymtabs.
2641         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2642
2643 2019-01-09  Tom Tromey  <tom@tromey.com>
2644
2645         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2646         (find_pc_mapped_section, list_overlays_command)
2647         (map_overlay_command, unmap_overlay_command)
2648         (simple_overlay_update): Use all_objfiles.
2649         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2650         * printcmd.c (info_symbol_command): Use all_objfiles.
2651         * objfiles.h (ALL_OBJSECTIONS): Remove.
2652         * maint.c (maintenance_translate_address): Use all_objfiles.
2653         * gcore.c (gcore_create_callback): Use all_objfiles.
2654         (objfile_find_memory_regions): Likewise.
2655
2656 2019-01-09  Tom Tromey  <tom@tromey.com>
2657
2658         * symtab.c (find_line_symtab, info_sources_command)
2659         (make_source_files_completion_list): Use objfile_compunits.
2660         * source.c (select_source_symtab): Use objfile_compunits.
2661         * objfiles.h (struct objfile): Update comment.
2662         (ALL_OBJFILES): Remove.
2663         (ALL_FILETABS): Remove.
2664         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2665         objfile_compunits.
2666
2667 2019-01-09  Tom Tromey  <tom@tromey.com>
2668
2669         * symmisc.c (print_objfile_statistics, dump_objfile)
2670         (maintenance_print_symbols): Use compunit_filetabs.
2671         * source.c (forget_cached_source_info_for_objfile): Use
2672         compunit_filetabs.
2673         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2674         (ALL_FILETABS): Use compunit_filetabs.
2675         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2676         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2677
2678 2019-01-09  Tom Tromey  <tom@tromey.com>
2679
2680         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2681         (compunit_filetabs): New.
2682         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2683         compunit_filetabs.
2684         (info_sources_command, make_source_files_completion_list): Remove
2685         declaration.
2686         * symmisc.c (print_objfile_statistics, dump_objfile)
2687         (maintenance_print_symbols): Remove declaration.
2688         (maintenance_info_symtabs): Use compunit_filetabs.
2689         (maintenance_info_line_tables): Likewise.
2690         * source.c (select_source_symtab): Change local variable name.
2691         (forget_cached_source_info_for_objfile): Remove declaration.
2692         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2693         * objfiles.c (objfile_relocate1): Remove declaration.
2694         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2695         declaration.
2696         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2697         * coffread.c (coff_symtab_read): Remove declaration.
2698         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2699         compunit_filetabs.
2700
2701 2019-01-09  Tom Tromey  <tom@tromey.com>
2702
2703         * symtab.c (lookup_objfile_from_block)
2704         (find_pc_sect_compunit_symtab, search_symbols)
2705         (default_collect_symbol_completion_matches_break_on): Use
2706         objfile_compunits.
2707         * objfiles.h (ALL_COMPUNITS): Remove.
2708         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2709         * cp-support.c (add_symbol_overload_list_qualified): Use
2710         objfile_compunits.
2711         * ada-lang.c (ada_collect_symbol_completion_matches)
2712         (ada_add_global_exceptions): Use objfile_compunits.
2713
2714 2019-01-09  Tom Tromey  <tom@tromey.com>
2715
2716         * source.c (select_source_symtab)
2717         (forget_cached_source_info_for_objfile): Remove declaration.
2718         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2719         declaration.
2720         * maint.c (count_symtabs_and_blocks): Remove declaration.
2721         * cp-support.c (add_symbol_overload_list_qualified): Remove
2722         declaration.
2723         * coffread.c (coff_symtab_read): Remove declaration.
2724         * symtab.c (lookup_symbol_in_objfile_symtabs)
2725         (basic_lookup_transparent_type_1): Use objfile_compunits.
2726         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2727         (info_sources_command, search_symbols)
2728         (default_collect_symbol_completion_matches_break_on)
2729         (make_source_files_completion_list): Remove declaration.
2730         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2731         (ada_collect_symbol_completion_matches)
2732         (ada_add_global_exceptions): Remove declaration.
2733         * linespec.c (iterate_over_all_matching_symtabs): Use
2734         objfile_compunits.
2735         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2736         (class objfile_compunits): New.
2737         (ALL_COMPUNITS): Use objfile_compunits.
2738         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2739         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2740         objfile_compunits.
2741         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2742
2743 2019-01-09  Tom Tromey  <tom@tromey.com>
2744
2745         * symtab.c (search_symbols)
2746         (default_collect_symbol_completion_matches_break_on): Use
2747         objfile_msymbols.
2748         * ada-lang.c (ada_lookup_simple_minsym)
2749         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2750         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2751         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2752         objfile_msymbols.
2753         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2754         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2755         * objc-lang.c (find_methods): Use objfile_msymbols.
2756         (info_selectors_command, info_classes_command): Likewise.
2757         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2758         * objfiles.h (class objfile_msymbols): New.
2759         (ALL_OBJFILE_MSYMBOLS): Remove.
2760         (ALL_MSYMBOLS): Remove.
2761
2762 2019-01-09  Tom Tromey  <tom@tromey.com>
2763
2764         * common/next-iterator.h (next_adapter): Add Iterator template
2765         parameter.
2766         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2767         (class all_objfiles_safe): New.
2768         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2769         * objfiles.c (put_objfile_before): Update comment.
2770         (add_separate_debug_objfile): Likewise.
2771         (free_all_objfiles): Use all_objfiles_safe.
2772         (objfile_purge_solibs): Likewise.
2773
2774 2019-01-09  Tom Tromey  <tom@tromey.com>
2775
2776         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2777         (expand_symtab_containing_pc, lookup_static_symbol)
2778         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2779         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2780         all_objfiles.
2781         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2782         * breakpoint.c (create_overlay_event_breakpoint)
2783         (create_longjmp_master_breakpoint)
2784         (create_std_terminate_master_breakpoint)
2785         (create_exception_master_breakpoint): Use all_objfiles.
2786         * linux-thread-db.c (try_thread_db_load_from_pdir)
2787         (has_libpthread): Use all_objfiles.
2788         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2789         * linespec.c (iterate_over_all_matching_symtabs)
2790         (search_minsyms_for_name): Use all_objfiles.
2791         * maint.c (maintenance_info_sections): Use all_objfiles.
2792         * main.c (captured_main_1): Use all_objfiles.
2793         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2794         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2795         * guile/scm-pretty-print.c
2796         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2797         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2798         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2799         (maintenance_print_msymbols): Use all_objfiles.
2800         * source.c (select_source_symtab): Use all_objfiles.
2801         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2802         * symfile.c (remove_symbol_file_command)
2803         (expand_symtabs_matching, map_symbol_filenames): Use
2804         all_objfiles.
2805         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2806         all_objfiles.
2807         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2808         * objc-lang.c (find_methods): Use all_objfiles.
2809         * objfiles.c (have_partial_symbols, have_full_symbols)
2810         (have_minimal_symbols, qsort_cmp)
2811         (default_iterate_over_objfiles_in_search_order): Use
2812         all_objfiles.
2813         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2814         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2815         (maintenance_check_psymtabs): Use all_objfiles.
2816         (ALL_PSYMTABS): Remove.
2817         * compile/compile-object-run.c (do_module_cleanup): Use
2818         all_objfiles.
2819         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2820         * cp-support.c (add_symbol_overload_list_qualified): Use
2821         all_objfiles.
2822         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2823         Use all_objfiles.
2824         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2825         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2826         all_objfiles.
2827         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2828         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2829         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2830         Uses all_objfiles.
2831         * solib.c (solib_read_symbols): Use all_objfiles
2832
2833 2019-01-09  Tom Tromey  <tom@tromey.com>
2834
2835         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2836         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2837         all_objfiles.
2838         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2839         * symmisc.c (print_symbol_bcache_statistics)
2840         (print_objfile_statistics, maintenance_print_objfiles)
2841         (maintenance_info_symtabs, maintenance_check_symtabs)
2842         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2843         all_objfiles.
2844         * source.c (forget_cached_source_info): Use all_objfiles.
2845         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2846         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2847         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2848         * objfiles.c (update_section_map): Use all_objfiles.
2849         (shared_objfile_contains_address_p): Likewise.
2850         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2851         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2852
2853 2019-01-09  Tom Tromey  <tom@tromey.com>
2854
2855         * common/next-iterator.h: New file.
2856         * objfiles.h (class all_objfiles): New.
2857         (struct objfile_iterator): New.
2858
2859 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2860
2861         * NEWS: Move the description of the changed "frame", "select-frame",
2862          and "info frame" commands to the Changed commands section.
2863
2864 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2865
2866         * gdbtypes.c (check_stub_method_group): Remove handling of old
2867         mangling schemes.
2868         * linespec.c (find_methods): Likewise.
2869         * stabsread.c (read_member_functions): Likewise.
2870         * valops.c (search_struct_method): Likewise.
2871         (value_struct_elt_for_reference): Likewise.
2872         * NEWS: Mention this change.
2873
2874 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2875
2876         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2877         print_source_lines.
2878         * source.c (print_source_lines_base): Update line number check.
2879         (print_source_lines): New function.
2880         (source_lines_range::source_lines_range): New function.
2881         * source.h (class source_lines_range): New class.
2882         (print_source_lines): New declaration.
2883
2884 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2885
2886         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2887
2888 2019-01-08  Tom Tromey  <tom@tromey.com>
2889             Simon Marchi  <simon.marchi@ericsson.com>
2890
2891         PR gdb/24060
2892         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2893         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2894         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2895         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2896         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2897         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2898
2899 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2900
2901         * source.c (select_source_symtab): Move header comment to
2902         declaration in source.h.
2903         (forget_cached_source_info_for_objfile): Likewise.
2904         (forget_cached_source_info): Likewise.
2905         (identify_source_line): Likewise.
2906         * source.h (identify_source_line): Move declaration from symtab.h
2907         and add comment from source.c
2908         (print_source_lines): Likewise.
2909         (forget_cached_source_info_for_objfile): Likewise.
2910         (forget_cached_source_info): Likewise.
2911         (select_source_symtab): Likewise.
2912         (enum print_source_lines_flag): Move definition from symtab.h.
2913         * symtab.h (identify_source_line): Move declaration to source.h.
2914         (print_source_lines): Likewise.
2915         (forget_cached_source_info_for_objfile): Likewise.
2916         (forget_cached_source_info): Likewise.
2917         (select_source_symtab): Likewise.
2918         (enum print_source_lines_flag): Move definition to source.h.
2919         * tui/tui-hooks.c: Add 'source.h' include.
2920
2921 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2922
2923         * source.c (print_source_lines_base): Handle requests to print
2924         reverse line number sequences, and guard against empty lines
2925         string.
2926
2927 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2928
2929         * source.c (print_source_lines_base): Fix skip of '\r' if next
2930         character is '\n'.
2931
2932 2019-01-06  Tom Tromey  <tom@tromey.com>
2933
2934         * c-exp.y (struct c_parse_state) <macro_original_text,
2935         expansion_obstack>: New member.
2936         (macro_original_text, expansion_obstack): Remove globals.
2937         (scan_macro_expansion, scanning_macro_expansion)
2938         (finished_macro_expansion): Update.
2939         (scan_macro_cleanup): Remove.
2940         (yylex, c_parse): Update.
2941
2942 2019-01-06  Tom Tromey  <tom@tromey.com>
2943
2944         * c-exp.y (struct c_parse_state) <strings>: New member.
2945         (operator_stoken): Update.
2946
2947 2019-01-06  Tom Tromey  <tom@tromey.com>
2948
2949         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2950         (union type_stack_elt) <typelist_val>: Now a pointer to
2951         std::vector.
2952         (type_stack_cleanup): Don't declare.
2953         (push_typelist): Update.
2954         * parse.c (pop_typelist): Return a std::vector.
2955         (push_typelist): Take a std::vector.
2956         (follow_types): Update.  Do not free args.
2957         (type_stack_cleanup): Remove.
2958         * c-exp.y (struct c_parse_state): New.
2959         (cpstate): New global.
2960         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2961         (nonempty_typelist): Update.
2962         (func_mod): Create a new vector.
2963         (c_parse): Create a c_parse_state.
2964         (check_parameter_typelist): Do not delete params.
2965         (function_method): Update.  Do not delete type_list.
2966
2967 2019-01-06  Tom Tromey  <tom@tromey.com>
2968
2969         PR gdb/28155:
2970         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2971         check_typedef.
2972         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2973         (print_return_value): Likewise.
2974
2975 2019-01-05  Tom Tromey  <tom@tromey.com>
2976
2977         * contrib/cleanup_check.py: Remove.
2978         * contrib/gcc-with-excheck: Remove.
2979         * contrib/exsummary.py: Remove.
2980         * contrib/excheck.py: Remove.
2981
2982 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2983
2984         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2985         NULL. Initialize tpprev to NULL instead of assigning it
2986         to NULL on the next statement.
2987         * windows-nat.c (windows_delete_thread): Remove check for
2988         main_thread_id before printing thread exit notifications.
2989         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2990         Remove thread ID check against main_thread_id.
2991         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2992         windows_delete_thread.
2993         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2994
2995 2019-01-04  Tom Tromey  <tom@tromey.com>
2996
2997         * compile/compile.c (_initialize_compile): Use upper case for
2998         metasyntactic variables.
2999         * symmisc.c (_initialize_symmisc): Use upper case for
3000         metasyntactic variables.
3001         * psymtab.c (_initialize_psymtab): Use upper case for
3002         metasyntactic variables.
3003         * demangle.c (demangle_command): Use upper case for metasyntactic
3004         variables.
3005         (_initialize_demangler): Likewise.
3006         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3007         variables.
3008
3009 2019-01-03  Tom Tromey  <tom@tromey.com>
3010
3011         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3012
3013 2019-01-03  Tom Tromey  <tom@tromey.com>
3014
3015         * python/py-symtab.c (salpy_str): Update.
3016         (struct salpy_sal_object) <symtab>: Now a PyObject.
3017         (salpy_dealloc): Update.
3018         (del_objfile_sal): Use gdbpy_ref.
3019
3020 2019-01-03  Tom Tromey  <tom@tromey.com>
3021
3022         * python/py-type.c (convert_field): Use new_reference.  Return
3023         gdbpy_ref.
3024         (make_fielditem): Return gdbpy_ref.
3025         (typy_fields): Update.
3026         (typy_getitem): Update.
3027         (field_name): Return gdbpy_ref.  Use new_reference.
3028         (typy_iterator_iternext): Update.
3029
3030 2019-01-03  Tom Tromey  <tom@tromey.com>
3031
3032         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3033
3034 2019-01-03  Tom Tromey  <tom@tromey.com>
3035
3036         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3037         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3038         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3039         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3040         (pspy_set_type_printers): Likewise.
3041         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3042         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3043         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3044         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3045         (objfpy_set_type_printers): Likewise.
3046
3047 2019-01-03  Tom Tromey  <tom@tromey.com>
3048
3049         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3050         (gdbpy_print_stack): Use gdbpy_err_fetch.
3051         * python/python-internal.h (class gdbpy_err_fetch): New class.
3052         (class gdbpy_enter) <m_error_type, m_error_value,
3053         m_error_traceback>: Remove.
3054         <m_error>: New member.
3055         (gdbpy_exception_to_string): Don't declare.
3056         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3057         * python/py-value.c (convert_value_from_python): Use
3058         gdbpy_err_fetch.
3059         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3060         gdbpy_exception_to_string.
3061         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3062         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3063         gdbpy_err_fetch.
3064
3065 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3066
3067         * linux-nat.c (delete_lwp_cleanup): Delete.
3068         (struct lwp_deleter): New struct.
3069         (lwp_info_up): New typedef.
3070         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3071         lwp_info_up.
3072
3073 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3074
3075         * linux-fork.c (class scoped_switch_fork_info): New class.
3076         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3077
3078 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3079
3080         * valops.c (find_overload_match): Remove use of null_cleanup, and
3081         calls to do_cleanups.
3082
3083 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3084
3085         * compile/compile-cplus-types.c
3086         (compile_cplus_instance::decl_name): Handle changes to
3087         cp_func_name.
3088         * cp-support.c (cp_func_name): Update header comment, update
3089         return type.
3090         * cp-support.h (cp_func_name): Update return type in declaration.
3091         * valops.c (find_overload_match): Move temp_func local to top
3092         level of function and change its type.  Use temp_func to hold and
3093         delete temporary string obtained from cp_func_name.
3094
3095 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3096
3097         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3098         gdb::char_vector, remove cleanup, and update uses of `msg`.
3099
3100 2019-01-03  Jim Wilson  <jimw@sifive.com>
3101
3102         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3103
3104 2019-01-02  Tom Tromey  <tom@tromey.com>
3105
3106         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3107         (tdesc_parse_xml): Remove cleanups.
3108         * target-descriptions.h (make_cleanup_free_target_description):
3109         Don't declare.
3110         (target_desc_deleter): New struct.
3111         (target_desc_up): New typedef.
3112         * target-descriptions.c (target_desc_deleter::operator()): Rename
3113         from free_target_description.
3114         (make_cleanup_free_target_description): Remove.
3115
3116 2019-01-02  Tom Tromey  <tom@tromey.com>
3117
3118         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3119         constructor, destructor.
3120         (linespec_parser): Remove typedef.
3121         (~linespec_parser): Rename from linespec_parser_delete.
3122         (linespec_lex_to_end, linespec_complete_label)
3123         (linespec_complete): Update.
3124         (decode_line_full): Remove cleanups.
3125         (decode_line_1): Update.
3126
3127 2019-01-02  Tom Tromey  <tom@tromey.com>
3128
3129         * python/python-internal.h (inferior_to_inferior_object): Change
3130         return type.
3131         * python/py-exitedevent.c (create_exited_event_object): Update.
3132         * python/py-inferior.c (inferior_to_inferior_object): Return
3133         gdbpy_ref.
3134         (python_new_inferior, python_inferior_deleted)
3135         (thread_to_thread_object, delete_thread_object)
3136         (build_inferior_list, gdbpy_selected_inferior): Update.
3137         * python/py-infthread.c (create_thread_object): Update.  Also fail
3138         if inferior_to_inferior_object fails.
3139
3140 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3141
3142         * inferior.h (class inferior) <displaced_step_state>: New field.
3143         * infrun.h (struct displaced_step_state): Move here from
3144         infrun.c.  Initialize fields, add constructor.
3145         <inf>: Remove field.
3146         <reset>: New method.
3147         * infrun.c (struct displaced_step_inferior_state): Move to
3148         infrun.h.
3149         (displaced_step_inferior_states): Remove.
3150         (get_displaced_stepping_state): Adust.
3151         (displaced_step_in_progress_any_inferior): Adjust.
3152         (displaced_step_in_progress_thread): Adjust.
3153         (displaced_step_in_progress): Adjust.
3154         (add_displaced_stepping_state): Remove.
3155         (get_displaced_step_closure_by_addr): Adjust.
3156         (remove_displaced_stepping_state): Remove.
3157         (infrun_inferior_exit): Call displaced_step_state.reset.
3158         (use_displaced_stepping): Don't check for NULL.
3159         (displaced_step_prepare_throw): Call
3160         get_displaced_stepping_state.
3161         (displaced_step_fixup): Don't check for NULL.
3162         (prepare_for_detach): Don't check for NULL.
3163
3164 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3165
3166         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3167          in case of call that did not complete.
3168
3169 2019-01-02  Andrey Utkin  <autkin@undo.io>
3170
3171         * symfile.c (find_separate_debug_file): Fix search of debug files for
3172         remote debuggee.
3173
3174 2019-01-02  Tom Tromey  <tom@tromey.com>
3175
3176         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3177         indentation.
3178         * python/py-frame.c (frapy_older): Remove cast.
3179         (frapy_newer): Likewise.
3180         * python/py-breakpoint.c (local_setattro): Remove cast.
3181         * python/py-arch.c (archpy_name): Remove local variable.
3182         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3183
3184 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3185
3186         * unittests/basic_string_view/element_access/char/empty.cc:
3187         Fix year range in copyright header.
3188
3189 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3190
3191         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3192         Delete.
3193         <operator==>: Update with for removed field.
3194         <hash>: Likewise.
3195         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3196         <isa_features>: ...this.
3197         <abi_features>: New field.
3198         (riscv_isa_flen): Update comment.
3199         (riscv_abi_xlen): New declaration.
3200         (riscv_abi_flen): New declaration.
3201         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3202         isa_features.
3203         (riscv_abi_xlen): New function.
3204         (riscv_isa_flen): Update to get answer from isa_features.
3205         (riscv_abi_flen): New function.
3206         (riscv_has_fp_abi): Update to get answer from abi_features.
3207         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3208         xlen and flen.
3209         (riscv_call_info) <xlen, flen>: Update comment.
3210         (riscv_call_arg_struct): Remove invalid assertions
3211         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3212         is removed.
3213         (riscv_gdbarch_init): Gather isa features and abi features
3214         separately, ensure both match on the gdbarch when reusing an old
3215         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3216         a target with 64-bit float hardware.
3217
3218 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3219
3220         * source.c (search_command_helper): Stop reverse search
3221         when line 1 has been searched.
3222
3223 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3224
3225         * record-full.c (record_full_base_target::close): Rewrite
3226         record_full_core_buf_list free logic.
3227
3228 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3229
3230         * break-catch-syscall.c (print_one_catch_syscall): xfree
3231         the last text.
3232
3233 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3234
3235         * top.c (print_gdb_version): Update Copyright year in version
3236         message.
3237
3238 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3239
3240         Update copyright year range in all GDB files.
3241
3242 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3243
3244         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3245
3246 For older changes see ChangeLog-2018.
3247 \f
3248 Local Variables:
3249 mode: change-log
3250 left-margin: 8
3251 fill-column: 74
3252 version-control: never
3253 coding: utf-8
3254 End:
3255