gdb/ChangeLog

   1 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
   2
   3         * completer.h (complete): New function.
   4         * completer.c (complete): Likewise.
   5         * cli/cli-cmds.c: (complete_command): Update to use new complete()
   6         function defined in completer.h.
   7
   8 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
   9
  10        * MAINTAINERS (Write After Approval): Add myself.
  11
  12 2019-05-17  Tom de Vries  <tdevries@suse.de>
  13
  14         PR gdb/24094
  15         * dwarf2read.c (struct cu_partial_die_info): New struct.
  16         (find_partial_die): Return cu_partial_die_info.
  17         (partial_die_parent_scope, guess_partial_die_structure_name)
  18         (partial_die_info::fixup): Handle new return type of find_partial_die.
  19
  20 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
  21
  22         * stap-probe.c (stap_parse_register_operand): Make "regname" an
  23         "std::string", simplifying the algorithm.
  24
  25 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
  26
  27         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
  28         (stap_static_probe_ops::get_probes): Likewise.
  29
  30 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
  31
  32         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
  33         '-')" and "else if".
  34         (stap_parse_single_operand): Join checks for
  35         "gdbarch_stap_parse_special_token_p" and
  36         "gdbarch_stap_parse_special_token" in the same "if" statement.
  37         Invert check when verifying for operation on register
  38         displacement.
  39
  40 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
  41
  42         * stap-probe.c (stap_get_opcode): Update comment.
  43         (stap_get_expected_argument_type): Likewise.
  44         (handle_stap_probe): Likewise.
  45
  46 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
  47
  48         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
  49         return type to 'bool'.  Adjust comment.  Use 'bool' when
  50         appropriate.
  51         (i386_stap_parse_special_token_three_arg_disp): Likewise.
  52         * stap-probe.c (stap_parse_argument_1): Likewise.
  53         (stap_is_operator): Likewise.
  54         (stap_is_generic_prefix): Likewise.
  55         (stap_is_register_prefix): Likewise.
  56         (stap_is_register_indirection_prefix): Likewise.
  57         (stap_is_integer_prefix): Likewise.
  58         (stap_generic_check_suffix): Likewise.
  59         (stap_check_integer_suffix): Likewise.
  60         (stap_check_register_suffix): Likewise.
  61         (stap_check_register_indirection_suffix): Likewise.
  62         (stap_parse_register_operand): Likewise.
  63         (stap_parse_single_operand): Likewise.
  64         (stap_parse_argument_1): Likewise.
  65         (stap_probe::get_argument_count): Likewise.
  66         (stap_is_operator): Likewise.
  67
  68 2019-05-16  Tom Tromey  <tromey@adacore.com>
  69
  70         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
  71         keyword to foreach.
  72
  73 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
  74
  75         * linux-thread-db.c (try_thread_db_load_1): Change return type
  76         to bool.
  77         (try_thread_db_load): Likewise.
  78         (try_thread_db_load_from_pdir_1): Likewise.
  79         (try_thread_db_load_from_pdir): Likewise.
  80         (try_thread_db_load_from_sdir): Likewise.
  81         (try_thread_db_load_from_dir): Likewise.
  82         (thread_db_load_search): Likewise.
  83         (has_libpthread): Likewise.
  84         (thread_db_load): Likewise.
  85
  86 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
  87
  88         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
  89         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
  90         NULL, and complain/return if that's the case.
  91
  92 2019-05-15  John Darrington <john@darrington.wattle.id.au>
  93
  94         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
  95         (advance, posn, abstract_read_memory): New functions.
  96         [struct mem_read_abstraction]: New struct.
  97         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
  98
  99 2019-05-14  Tom Tromey  <tromey@adacore.com>
 100
 101         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 102         value is not lval_memory.
 103
 104 2019-05-14  Tom Tromey  <tromey@adacore.com>
 105
 106         * solib.c (info_sharedlibrary_command): Style the file name.
 107
 108 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 109
 110         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 111         (aarch64_vnv_type): Likewise.
 112         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 113         * common/tdesc.c: Likewise.
 114         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 115         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 116         * features/aarch64-fpu.xml: Add ieee half view.
 117         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 118         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 119         * gdbtypes.h (struct builtin_type): Likewise.
 120         (struct objfile_type): Likewise.
 121
 122 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 123
 124         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 125         typo.
 126         * location.h (string_to_event_location): Likewise.
 127
 128 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 129
 130         GDB 8.3 released.
 131
 132 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 133
 134         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 135         New variable declaration.
 136         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 137         New variable.
 138         (print_one_breakpoint): Use ui_out::test_flags and new global
 139         variable to compute use_fixed_output.
 140         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 141         Remove.
 142         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 143         (mi_multi_location_breakpoint_output_fixed): Remove.
 144         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 145         new variable.
 146         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 147         fix_multi_location_breakpoint_output flag if version >= 3.
 148         * ui-out.h (enum ui_out_flag)
 149         <fix_multi_location_breakpoint_output>: New enumerator.
 150
 151 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 152
 153         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 154
 155 2019-05-10  Tom Tromey  <tromey@adacore.com>
 156
 157         * ada-lang.c (catch_ada_completer): New function.
 158         (_initialize_ada_language): Use it.
 159
 160 2019-05-10  Tom Tromey  <tromey@adacore.com>
 161
 162         * thread.c (print_thread_info): Make "requested_threads" const.
 163         * gdbthread.h (print_thread_info): Make "requested_threads"
 164         const.
 165         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 166         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 167
 168 2019-05-08  Tom Tromey  <tom@tromey.com>
 169
 170         * gdbtypes.c (objfile_type_data): Change type.
 171         (objfile_type, _initialize_gdbtypes): Update.
 172
 173 2019-05-08  Tom Tromey  <tom@tromey.com>
 174
 175         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 176         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 177         (_initialize_dwarf2_frame): Update.
 178
 179 2019-05-08  Tom Tromey  <tom@tromey.com>
 180
 181         * objc-lang.c (objc_objfile_data): Change type.
 182         (find_methods): Update.
 183         (_initialize_objc_lang): Remove.
 184
 185 2019-05-08  Tom Tromey  <tom@tromey.com>
 186
 187         * stabsread.c (rs6000_builtin_type_data): Change type.
 188         (rs6000_builtin_type, _initialize_stabsread): Update.
 189
 190 2019-05-08  Tom Tromey  <tom@tromey.com>
 191
 192         * mips-tdep.c (mips_pdr_data): Remove.
 193         (_initialize_mips_tdep): Update.
 194
 195 2019-05-08  Tom Tromey  <tom@tromey.com>
 196
 197         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 198         (hppa_init_objfile_priv_data, read_unwind_info)
 199         (find_unwind_entry, _initialize_hppa_tdep): Update.
 200
 201 2019-05-08  Tom Tromey  <tom@tromey.com>
 202
 203         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 204         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 205         on obstack.
 206         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 207
 208 2019-05-08  Tom Tromey  <tom@tromey.com>
 209
 210         * mdebugread.c (basic_type_data): Change type.
 211         (basic_type, _initialize_mdebugread): Update.
 212
 213 2019-05-08  Tom Tromey  <tom@tromey.com>
 214
 215         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 216
 217 2019-05-08  Tom Tromey  <tom@tromey.com>
 218
 219         * nto-tdep.c (nto_inferior_data_reg): Change type.
 220         (nto_inferior_data): Update.
 221         (nto_inferior_data_cleanup, nto_new_inferior_data)
 222         (_initialize_nto_tdep): Remove.
 223         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 224
 225 2019-05-08  Tom Tromey  <tom@tromey.com>
 226
 227         * ada-lang.c (struct ada_inferior_data): Add initializers.
 228         (ada_inferior_data): Change type.
 229         (ada_inferior_data_cleanup): Remove.
 230         (get_ada_inferior_data, ada_inferior_exit)
 231         (struct ada_pspace_data): Add initializers, destructor.
 232         (ada_pspace_data_handle): Change type.
 233         (get_ada_pspace_data): Update.
 234         (ada_pspace_data_cleanup): Remove.
 235
 236 2019-05-08  Tom Tromey  <tom@tromey.com>
 237
 238         * coffread.c (struct coff_symfile_info): Add initializers.
 239         (coff_objfile_data_key): Move lower.  Change type.
 240         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 241         Update.
 242         (coff_free_info): Remove.
 243
 244 2019-05-08  Tom Tromey  <tom@tromey.com>
 245
 246         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 247         (fbsd_pspace_data_handle): Move lower.  Change type.
 248         (get_fbsd_pspace_data): Update.
 249         (fbsd_pspace_data_cleanup): Remove.
 250         (_initialize_fbsd_tdep): Update.
 251
 252 2019-05-08  Tom Tromey  <tom@tromey.com>
 253
 254         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 255         (get_ada_tasks_pspace_data): Update.
 256         (ada_tasks_pspace_data_cleanup): Remove.
 257         (_initialize_tasks): Update.
 258         (ada_tasks_inferior_data_handle): Change type.
 259         (get_ada_tasks_inferior_data): Update.
 260         (ada_tasks_inferior_data_cleanup): Remove.
 261         (struct ada_tasks_pspace_data): Add initializers.
 262
 263 2019-05-08  Tom Tromey  <tom@tromey.com>
 264
 265         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 266         * symfile-debug.c (debug_sym_get_probes): Change type.
 267         * stap-probe.c (handle_stap_probe):
 268         (stap_static_probe_ops::get_probes): Change type.
 269         * probe.h (class static_probe_ops) <get_probes>: Change type.
 270         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 271         (parse_probes_in_pspace): Update.
 272         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 273         Update.
 274         (any_static_probe_ops::get_probes): Change type.
 275         * elfread.c (elfread_data): New typedef.
 276         (probe_key): Change type.
 277         (elf_get_probes): Likewise.  Update.
 278         (probe_key_free): Remove.
 279         (_initialize_elfread): Update.
 280         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 281         Change type.
 282         (dtrace_process_dof_probe, dtrace_process_dof)
 283         (dtrace_static_probe_ops::get_probe): Change type.
 284
 285 2019-05-08  Tom Tromey  <tom@tromey.com>
 286
 287         * xcoffread.c (struct xcoff_symfile_info): Rename from
 288         coff_symfile_info.  Add initializers.
 289         (xcoff_objfile_data_key): Move lower.  Change type.
 290         (XCOFF_DATA): Rewrite.
 291         (xcoff_free_info): Remove.
 292         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 293         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 294         (xcoff_initial_scan): Update.
 295
 296 2019-05-08  Tom Tromey  <tom@tromey.com>
 297
 298         * solib-svr4.c (struct svr4_info): Add initializers and
 299         destructor.
 300         <probes_table>: Now an htab_up.
 301         (solib_svr4_pspace_data): Change type.
 302         (free_probes_table): Simplify.
 303         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 304         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 305         (probes_table_remove_objfile_probes, register_solib_event_probe)
 306         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 307         (_initialize_svr4_solib): Update.
 308
 309 2019-05-08  Tom Tromey  <tom@tromey.com>
 310
 311         * remote.c (remote_pspace_data): Change type.
 312         (remote_pspace_data_cleanup): Remove.
 313         (get_remote_exec_file, set_pspace_remote_exec_file)
 314         (_initialize_remote): Update.
 315
 316 2019-05-08  Tom Tromey  <tom@tromey.com>
 317
 318         * breakpoint.c (breakpoint_objfile_key): Change type.
 319         (get_breakpoint_objfile_data): Update.
 320         (free_breakpoint_objfile_data): Remove.
 321         (_initialize_breakpoint): Update.
 322
 323 2019-05-08  Tom Tromey  <tom@tromey.com>
 324
 325         * linux-tdep.c (struct linux_info): Add initializers.
 326         (linux_inferior_data): Move.  Change type.
 327         (invalidate_linux_cache_inf): Update.
 328         (linux_inferior_data_cleanup): Remove.
 329         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 330
 331 2019-05-08  Tom Tromey  <tom@tromey.com>
 332
 333         * auxv.c (auxv_inferior_data): Move.  Change type.
 334         (auxv_inferior_data_cleanup): Remove.
 335         (invalidate_auxv_cache_inf): Rewrite.
 336         (get_auxv_inferior_data, _initialize_auxv): Update.
 337
 338 2019-05-08  Tom Tromey  <tom@tromey.com>
 339
 340         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 341         (symfile_debug_objfile_data_key): Change type.
 342         (symfile_debug_installed, debug_qf_has_symbols)
 343         (debug_qf_find_last_source_symtab)
 344         (debug_qf_forget_cached_source_info)
 345         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 346         (debug_qf_print_stats, debug_qf_dump)
 347         (debug_qf_expand_symtabs_for_function)
 348         (debug_qf_expand_all_symtabs)
 349         (debug_qf_expand_symtabs_with_fullname)
 350         (debug_qf_map_matching_symbols)
 351         (debug_qf_expand_symtabs_matching)
 352         (debug_qf_find_pc_sect_compunit_symtab)
 353         (debug_qf_map_symbol_filenames)
 354         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 355         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 356         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 357         (debug_sym_read_linetable, debug_sym_relocate): Update.
 358         (symfile_debug_free_objfile): Remove.
 359         (install_symfile_debug_logging, _initialize_symfile_debug):
 360         Update.
 361
 362 2019-05-08  Tom Tromey  <tom@tromey.com>
 363
 364         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 365         allocate_on_obstack.
 366         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 367         (get_dwarf2_per_objfile): Update.
 368         (set_dwarf2_per_objfile): Remove.
 369         (dwarf2_has_info, dwarf2_get_section_info): Update.
 370         (dwarf2_free_objfile): Remove.
 371         (_initialize_dwarf2_read): Update.
 372
 373 2019-05-08  Tom Tromey  <tom@tromey.com>
 374
 375         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 376         initializers.
 377         <unsupported_script_warning_printed,
 378         script_not_found_warning_printed>: Now bool.
 379         (auto_load_pspace_data): Change type.
 380         (~auto_load_pspace_info): Rename from
 381         auto_load_pspace_data_cleanup.
 382         (get_auto_load_pspace_data, init_loaded_scripts_info)
 383         (clear_section_scripts, maybe_print_unsupported_script_warning)
 384         (maybe_print_script_not_found_warning, _initialize_auto_load):
 385         Update.
 386
 387 2019-05-08  Tom Tromey  <tom@tromey.com>
 388
 389         * objfiles.c (objfile_pspace_info): Add destructor and
 390         initializers.
 391         (objfiles_pspace_data): Change type.
 392         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 393         (get_objfile_pspace_data): Update.
 394         (objfiles_bfd_data): Change type.
 395         (get_objfile_bfd_data): Update.
 396         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 397
 398 2019-05-08  Tom Tromey  <tom@tromey.com>
 399
 400         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 401         Change type.
 402         (get_catch_syscall_inferior_data): Update.
 403         (catch_syscall_inferior_data_cleanup): Remove.
 404         (_initialize_break_catch_syscall): Update.
 405
 406 2019-05-08  Tom Tromey  <tom@tromey.com>
 407
 408         * inflow.c (struct terminal_info): Add destructor and
 409         initializers.
 410         (inflow_inferior_data): Change type.
 411         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 412         (get_inflow_inferior_data, inflow_inferior_exit)
 413         (swap_terminal_info, _initialize_inflow): Update.
 414
 415 2019-05-08  Tom Tromey  <tom@tromey.com>
 416
 417         * target-dcache.c (target_dcache_cleanup): Remove.
 418         (target_dcache_aspace_key): Change type.
 419         (target_dcache_init_p, target_dcache_invalidate)
 420         (target_dcache_get, target_dcache_get_or_init)
 421         (_initialize_target_dcache): Update.
 422         * dcache.h (struct dcache_deleter): New.
 423
 424 2019-05-08  Tom Tromey  <tom@tromey.com>
 425
 426         * symtab.c (struct symbol_cache): Add destructor and
 427         initializers.
 428         (symbol_cache_key): Move.  Change type.
 429         (make_symbol_cache, free_symbol_cache): Remove.
 430         (get_symbol_cache): Update.
 431         (symbol_cache_cleanup): Remove.
 432         (ALL_PSPACES, symbol_cache_flush)
 433         (maintenance_print_symbol_cache)
 434         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 435         Update.
 436
 437 2019-05-08  Tom Tromey  <tom@tromey.com>
 438
 439         * symtab.c (struct main_info): Add destructor and initializers.
 440         (main_progspace_key): Move.  Change type.
 441         (get_main_info): Update.
 442         (main_info_cleanup): Remove.
 443         (_initialize_symtab): Update.
 444
 445 2019-05-08  Tom Tromey  <tom@tromey.com>
 446
 447         * registry.h (DECLARE_REGISTRY): Define the _key class.
 448
 449 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 450
 451         * NEWS: Merge two 'New commands' sections.
 452
 453 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 454
 455         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 456         parameter and use Ada language definition instead.
 457         (ada_val_print_ptr): Remove unused language parameter.
 458         (ada_val_print_num): Remove language parameter and use Ada language
 459         definition instead.
 460         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 461         parameter.
 462         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 463         parameter and use Ada language definition instead.
 464         (ada_val_print_1): Update all ada_val_print_xxx calls.
 465         Remove language parameter.
 466         (ada_val_print): Update ada_val_print_1 call.
 467
 468 2019-05-08  Tom Tromey  <tromey@adacore.com>
 469
 470         * remote.c (remote_hw_watchpoint_limit)
 471         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 472         Now static.
 473
 474 2019-05-08  Tom Tromey  <tromey@adacore.com>
 475
 476         * maint.c (_initialize_maint_cmds): Move initialization code to
 477         remote.c.
 478         (watchdog, show_watchdog): Move to remote.c.
 479         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 480         "watchdog" static.
 481         (_initialize_remote): Move initialization code from maint.c.
 482         * defs.h (watchdog): Don't declare.
 483
 484 2019-05-08  Tom Tromey  <tromey@adacore.com>
 485
 486         * tui/tui-interp.c: Include main.h.
 487         * interps.c: Include main.h.
 488         * main.h (interpreter_p): Declare.
 489         * defs.h (interpreter_p): Don't declare.
 490
 491 2019-05-08  Tom Tromey  <tromey@adacore.com>
 492
 493         * dwarf2loc.c: Include dwarf2read.h.
 494         * defs.h (read_unsigned_leb128): Don't declare.
 495         * dwarf2read.h (read_unsigned_leb128): Declare.
 496
 497 2019-05-08  Tom Tromey  <tromey@adacore.com>
 498
 499         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 500         method.
 501
 502 2019-05-08  Tom Tromey  <tromey@adacore.com>
 503
 504         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 505         when no wrap column is set.
 506
 507 2019-05-08  Tom Tromey  <tromey@adacore.com>
 508
 509         * c-lang.c (c_get_string): Handle non-C-style arrays.
 510
 511 2019-05-08  Tom Tromey  <tromey@adacore.com>
 512
 513         * typeprint.c (print_offset_data::update): Print the bit offset,
 514         not the number of bits remaining.
 515
 516 2019-05-08  Tom Tromey  <tromey@adacore.com>
 517
 518         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 519         padding at end of comment.
 520
 521 2019-05-08  Tom Tromey  <tromey@adacore.com>
 522
 523         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 524         Compare main types.
 525
 526 2019-05-06  Tom Tromey  <tom@tromey.com>
 527
 528         * common/scoped_mmap.c: Include common-defs.h.
 529         * common/scoped_mmap.h: Don't include config.h.
 530
 531 2019-05-04  Tom Tromey  <tom@tromey.com>
 532
 533         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 534         (struct aarch64_call_info): Add initializers.
 535         <si>: Now a std::vector.
 536         (pass_on_stack, aarch64_push_dummy_call): Update.
 537
 538 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 539             Tom Tromey  <tom@tromey.com>
 540
 541         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 542         (ppc_threads): Now a std::vector.  Now static.
 543         (hwdebug_find_thread_points_by_tid)
 544         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 545         Update.
 546
 547 2019-05-04  Tom Tromey  <tom@tromey.com>
 548
 549         * arc-tdep.c (arc_tdesc_init): Return bool.
 550
 551 2019-05-04  Tom Tromey  <tom@tromey.com>
 552
 553         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 554         Use gdb_assert_not_reached.
 555
 556 2019-05-04  Tom Tromey  <tom@tromey.com>
 557
 558         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 559         "false".
 560
 561 2019-05-04  Tom Tromey  <tom@tromey.com>
 562
 563         * arc-tdep.c (arc_tdesc_init): Use bool.
 564
 565 2019-05-04  Tom Tromey  <tom@tromey.com>
 566
 567         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 568
 569 2019-05-04  Tom Tromey  <tom@tromey.com>
 570
 571         * cli/cli-cmds.c (valid_command_p): Return bool.
 572
 573 2019-05-04  Tom Tromey  <tom@tromey.com>
 574
 575         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 576         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 577
 578 2019-05-04  Raul Tambre  <raul@tambre.ee>
 579
 580         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 581         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 582         operator for comparison.
 583
 584 2019-05-04  Tom Tromey  <tom@tromey.com>
 585
 586         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 587         (lookup_partial_symbol, print_partial_symbols)
 588         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 589         (psymbol_compare): Update.
 590         (add_psymbol_to_bcache): Clear the entire psymbol.
 591         (maintenance_check_psymtabs): Update.
 592         * psympriv.h (struct partial_symbol): Don't derive from
 593         general_symbol_info.
 594         <obj_section, unrelocated_address, address,
 595         set_unrelocated_address>: Update.
 596         <ginfo>: New member.
 597         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 598         (debug_names::write_psymbols): Update.
 599
 600 2019-05-04  Tom de Vries  <tdevries@suse.de>
 601
 602         * contrib/cc-with-tweaks.sh: Support -n arg.
 603
 604 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 605
 606         * corelow.c (core_target::detach): Ensure frame cache and
 607         register caches are cleared.
 608         inferior.c (exit_inferior_1): Likewise.
 609
 610 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 611             Tom Tromey  <tom@tromey.com>
 612
 613         * dictionary.c (collate_pending_symbols_by_language): Remove
 614         "struct" from foreach.
 615         * symtab.c (lookup_global_symbol_from_objfile)
 616         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 617         foreach.
 618         * ser-tcp.c (net_open): Remove "struct" from foreach.
 619         * objfiles.c (objfile_relocate, objfile_rebase)
 620         (objfile_has_symbols): Remove "struct" from foreach.
 621         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 622         from foreach.
 623         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 624         foreach.
 625         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 626         "struct" from foreach.
 627         * ada-lang.c (create_excep_cond_exprs)
 628         (ada_exception_catchpoint_cond_string): Remove "struct" from
 629         foreach.
 630
 631 2019-05-03  Tom Tromey  <tromey@adacore.com>
 632
 633         * ada-exp.y (convert_char_literal): Check suffix of each
 634         enumerator.
 635
 636 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 637
 638         PR ada/21406:
 639         * ada-exp.y (yywrap): Don't define.
 640         * ada-lex.l (%option): Add noyywrap
 641         (yywrap): Remove.
 642
 643 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 644
 645         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 646         _WIN32_WINNT to the XP level, unless already defined to a higher
 647         level.
 648
 649         * unittests/parse-connection-spec-selftests.c:
 650         * ser-tcp.c:
 651         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 652         override.
 653
 654         * symfile.c (find_separate_debug_file): Remove colon from the
 655         drive spec of DOS/Windows file names of the target, so that the
 656         file name produced from DEBUGDIR and the target's directory will
 657         be valid on DOS/Windows systems.
 658
 659 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 660
 661         * rust-lang.c (val_print_struct): Handle printing structures
 662         containing strings.
 663
 664 2019-05-02  Tom Tromey  <tromey@adacore.com>
 665
 666         * valarith.c (_initialize_valarith): Remove.
 667
 668 2019-05-01  Tom Tromey  <tromey@adacore.com>
 669
 670         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 671         bitfields.
 672
 673 2019-05-01  Tom Tromey  <tromey@adacore.com>
 674
 675         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 676         for big-endian copies.
 677
 678 2019-04-30  Ali Tamur  <tamur@google.com>
 679         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 680         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 681         (read_3_bytes): New function.
 682
 683 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 684
 685         * windows-nat.c (main_thread_id): Delete.
 686         (handle_output_debug_string): Replace main_thread_id by
 687         current_event.dwThreadId.
 688         (fake_create_process): Likewise.
 689         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 690         Do not set main_thread_id.
 691         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 692         current_event.dwThreadId.
 693         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 694
 695 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 696
 697         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 698         Use current_event.dwThreadId instead of main_thread_id.
 699
 700 2019-04-30  Tom Tromey  <tromey@adacore.com>
 701
 702         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 703         (create_excep_cond_exprs): Iterate over program spaces.
 704         (ada_exception_catchpoint_cond_string): Examine all minimal
 705         symbols for exception types.
 706
 707 2019-04-30  Tom Tromey  <tromey@adacore.com>
 708
 709         PR c++/24470:
 710         * dwarf2read.c (process_structure_scope): Handle case where type
 711         has template parameters but no symbol was created.
 712
 713 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 714             Chris January  <chris.january@arm.com>
 715
 716         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 717         qualifier.
 718         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 719
 720 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 721
 722         * f-typeprint.c (f_print_type): Update rules for printing
 723         whitespace.
 724         (f_type_print_varspec_suffix): Likewise.
 725
 726 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 727             Chris January  <chris.january@arm.com>
 728
 729         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 730         function arguments.
 731
 732 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 733
 734         * f-lang.c (build_fortran_types): Change name of void type to
 735         lower case.
 736         * f-typeprint.c (f_type_print_base): Print the name of the void
 737         type, rather than a fixed string.
 738         * f-valprint.c (f_decorations): Use lower case void string.
 739
 740 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 741             Chris January  <chris.january@arm.com>
 742
 743         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 744         types for Fortran.
 745
 746 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 747             Chris January  <chris.january@arm.com>
 748             David Lecomber  <david.lecomber@arm.com>
 749
 750         * f-exp.y (BINOP_INTRINSIC): New token.
 751         (exp): New parser rule handling BINOP_INTRINSIC.
 752         (f77_keywords): Add new builtin procedures.
 753         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 754         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 755         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 756         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 757         (print_unop_subexp_f): New function.
 758         (print_binop_subexp_f): New function.
 759         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 760         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 761         (dump_subexp_body_f): Likewise.
 762         (operator_check_f): Likewise.
 763         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 764         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 765
 766 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 767
 768         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 769         UNOP_KIND.
 770         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 771         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 772         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 773         (operator_length_f): New fuction.
 774         (print_subexp_f): New function.
 775         (op_name_f): New function.
 776         (dump_subexp_body_f): New function.
 777         (operator_check_f): New function.
 778         (exp_descriptor_f): Replace standard expression handling functions
 779         with new functions.
 780         * gdb/fortran-operator.def: New file.
 781         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 782         * gdb/std-operator.def: Remove UNOP_KIND.
 783
 784 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 785
 786         * std-operator.def: Remove unbalanced, stray double quote
 787         character.
 788
 789 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 790             Chris January  <chris.january@arm.com>
 791             Daniel Everett  <daniel.everett@arm.com>
 792             Nick Forrington  <nick.forrington@arm.com>
 793             Richard Bunt  <richard.bunt@arm.com>
 794
 795         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 796         of depth when printing anonymous structs or unions.
 797         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 798         Don't print either the top-level value, or the children if the
 799         max-depth is exceeded.
 800         (ppscm_print_children): When printing the key of a map, allow one
 801         extra level of depth.
 802         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 803         print either the top-level value, or the children if the max-depth
 804         is exceeded.
 805         (print_children): When printing the key of a map, allow one extra
 806         level of depth.
 807         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 808         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 809         (user_print_options): Initialise max_depth field.
 810         (val_print_scalar_or_string_type_p): New function.
 811         (val_print): Check to see if the max depth has been reached.
 812         (val_print_check_max_depth): Define new function.
 813         (show_print_max_depth): New function.
 814         (_initialize_valprint): Add 'print max-depth' option.
 815         * valprint.h (struct value_print_options) <max_depth>: New field.
 816         (val_print_check_max_depth): Declare new function.
 817         * NEWS: Document new feature.
 818
 819 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 820
 821         * ada-lang.c (ada_language_defn): Initialise new field.
 822         * c-lang.c (c_is_string_type_p): New function.
 823         (c_language_defn): Initialise new field.
 824         (cplus_language_defn): Initialise new field.
 825         (asm_language_defn): Initialise new field.
 826         (minimal_language_defn): Initialise new field.
 827         * c-lang.h (c_is_string_type_p): Declare new function.
 828         * d-lang.c (d_language_defn): Initialise new field.
 829         * f-lang.c (f_is_string_type_p): New function.
 830         (f_language_defn): Initialise new field.
 831         * go-lang.c (go_is_string_type_p): New function.
 832         (go_language_defn): Initialise new field.
 833         * language.c (default_is_string_type_p): New function.
 834         (unknown_language_defn): Initialise new field.
 835         (auto_language_defn): Initialise new field.
 836         * language.h (struct language_defn) <la_is_string_type_p>: New
 837         member variable.
 838         (default_is_string_type_p): Declare new function.
 839         * m2-lang.c (m2_language_defn): Initialise new field.
 840         * objc-lang.c (objc_language_defn): Initialise new field.
 841         * opencl-lang.c (opencl_language_defn): Initialise new field.
 842         * p-lang.c (pascal_is_string_type_p): New function.
 843         (pascal_language_defn): Initialise new field.
 844         * rust-lang.c (rust_is_string_type_p): New function.
 845         (rust_language_defn): Initialise new field.
 846
 847 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 848
 849         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 850         New field.
 851         * ada-lang.c (ada_language_defn): Initialise new field.
 852         * c-lang.c (c_language_defn): Likewise.
 853         (cplus_language_defn): Likewise.
 854         (asm_language_defn): Likewise.
 855         (minimal_language_defn): Likewise.
 856         * d-lang.c (d_language_defn): Likewise.
 857         * f-lang.c (f_language_defn): Likewise.
 858         * go-lang.c (go_language_defn): Likewise.
 859         * language.c (unknown_language_defn): Likewise.
 860         (auto_language_defn): Likewise.
 861         * m2-lang.c (m2_language_defn): Likewise.
 862         * objc-lang.c (objc_language_defn): Likewise.
 863         * opencl-lang.c (opencl_language_defn): Likewise.
 864         * p-lang.c (pascal_language_defn): Likewise.
 865         * rust-lang.c (rust_language_defn): Likewise.
 866
 867 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 868
 869         * ada-lang.c (ada_is_character_type): Change return type to bool.
 870         (ada_is_string_type): Likewise.
 871         * ada-lang.h (ada_is_character_type): Update declaration
 872         (ada_is_string_type): Likewise.
 873
 874 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 875
 876         Support style in 'frame|thread apply'
 877
 878         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 879         * record.c (record_start, record_stop): Update callers of
 880         execute_command_to_string with false.
 881         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 882         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 883         methods.
 884         (class string_file): New constructor with term_out parameter.
 885         Override methods term_out and can_emit_style_escape.  New member
 886         term_out.
 887         (class stdio_file): Override can_emit_style_escape.
 888         (class tee_file): Override term_out and can_emit_style_escape.
 889         * utils.h (can_emit_style_escape): Remove.
 890         * utils.c (can_emit_style_escape): Likewise.
 891         Update all callers of can_emit_style_escape (SOMESTREAM) to
 892         SOMESTREAM->can_emit_style_escape.
 893         * source-cache.c (source_cache::get_source_lines): Likewise.
 894         * stack.c (frame_apply_command_count): Call execute_command_to_string
 895         passing the term_out characteristic of the current gdb_stdout.
 896         * thread.c (thr_try_catch_cmd): Likewise.
 897         * top.c (execute_command_to_string): pass term_out parameter
 898         to construct the string_file for the command output.
 899         * ui-file.c (term_cli_styling): New function (most code moved
 900         from utils.c can_emit_style_escape).
 901         (string_file::string_file, string_file::can_emit_style_escape,
 902         stdio_file::can_emit_style_escape, tee_file::term_out,
 903         tee_file::can_emit_style_escape): New functions.
 904
 905 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 906
 907         * NEWS: Mention the new set|show may-call-functions.
 908         * infcall.c (may_call_functions_p): New variable.
 909         (show_may_call_functions_p): New function.
 910         (call_function_by_hand_dummy): Throws an error if not
 911         may-call-functions.
 912         (_initialize_infcall): Call add_setshow_boolean_cmd for
 913         may-call-functions.
 914
 915 2019-04-25  Keith Seitz  <keiths@redhat.com>
 916
 917         PR c++/24367
 918         * cp-support.c (inspect_type): Don't attempt substitutions
 919         of symbol with the same name.
 920
 921 2019-04-25  Tom Tromey  <tromey@adacore.com>
 922
 923         PR gdb/24475:
 924         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 925         static.
 926
 927 2019-04-25  Tom Tromey  <tromey@adacore.com>
 928
 929         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 930         rvalue reference.
 931         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 932         (gdb_xml_parser::parse): Use std::move.
 933         * python/python-internal.h (gdbpy_convert_exception): Take a const
 934         reference.
 935         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 936         std::move.
 937         * python/py-utils.c (gdbpy_convert_exception): Take a const
 938         reference.
 939         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 940         Use std::move.
 941         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 942         Use std::move.
 943         * mi/mi-main.c (mi_print_exception): Take a const reference.
 944         * main.c (handle_command_errors): Take a const reference.
 945         * linespec.c (parse_linespec): Use std::move.
 946         * infcall.c (run_inferior_call): Use std::move.
 947         (call_function_by_hand_dummy): Use std::move.
 948         * exec.c (try_open_exec_file): Use std::move.
 949         * exceptions.h (exception_print, exception_fprintf)
 950         (exception_print_same): Update.
 951         * exceptions.c (print_exception, exception_print)
 952         (exception_fprintf, exception_print_same): Change parameters to
 953         const reference.
 954         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 955         * common/new-op.c: Use std::move.
 956         * common/common-exceptions.h (struct gdb_exception): Add move
 957         constructor.
 958         (struct gdb_exception_error, struct gdb_exception_quit, struct
 959         gdb_quit_bad_alloc): Change constructor to move constructor.
 960         (throw_exception): Change parameter to rvalue reference.
 961         * common/common-exceptions.c (throw_exception): Take rvalue
 962         reference.
 963         * cli/cli-interp.c (safe_execute_command): Use std::move.
 964         * breakpoint.c (insert_bp_location, location_to_sals): Use
 965         std::move.
 966
 967 2019-04-25  Tom Tromey  <tromey@adacore.com>
 968
 969         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 970         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 971         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 972         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 973         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 974         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 975         guile/scm-value.c: Use unpack.
 976         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 977         gdbscm_gdb_exception.
 978         (gdbscm_throw_gdb_exception): Likewise.
 979         (struct gdbscm_gdb_exception): New.
 980         (unpack): New function.
 981         (gdbscm_wrap): Use unpack.
 982
 983 2019-04-25  Tom Tromey  <tromey@adacore.com>
 984
 985         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 986         (gdb_rl_callback_handler): Use std::move.
 987         * common/common-exceptions.h (struct gdb_exception): Add move
 988         assignment operator.
 989         (throw_exception_sjlj): Change "exception" to const reference.
 990         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 991         (throw_exception_sjlj): Change "exception" to const reference.
 992
 993 2019-04-25  Tom Tromey  <tromey@adacore.com>
 994
 995         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 996         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 997         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 998         Update.
 999         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1000         Update.
1001         * mi/mi-interp.c (mi_interp::exec): Update.
1002         * linespec.c (parse_linespec): Update.
1003         * infcall.c (run_inferior_call): Update.
1004         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1005         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1006         (gdbscm_lookup_global_symbol): Update.
1007         * guile/scm-param.c (gdbscm_parameter_value): Update.
1008         * guile/scm-frame.c (gdbscm_frame_read_register)
1009         (gdbscm_frame_read_var): Update.
1010         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1011         * exec.c (try_open_exec_file): Update.
1012         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1013         (gdb_rl_callback_handler): Update.
1014         * common/common-exceptions.h (exception_none): Don't declare.
1015         * common/common-exceptions.c (exception_none): Don't define.
1016         (struct catcher) <exception>: Update.
1017         * cli/cli-interp.c (safe_execute_command): Update.
1018         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1019
1020 2019-04-25  Ali Tamur  <tamur@google.com>
1021
1022         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1023         (read_attribute_value): Likewise.
1024         (dwarf2_read_addr_index): Update comment.
1025         (read_str_index): Add DW_FORM_strx.
1026         (dwarf2_string_attr): Likewise.
1027         (dwarf2_const_value_attr): Likewise.
1028         (dump_die_shallow): Likewise.
1029         (dwarf2_fetch_constant_bytes): Likewise.
1030         (skip_form_bytes): Likewise.
1031         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1032
1033 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1034
1035         PR corefiles/11608
1036         PR corefiles/18187
1037         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1038         OFFSET.  Verify if current mapping contains an ELF header.
1039         (linux_find_memory_regions_full): Adjust call to
1040         dump_mapping_p.
1041
1042 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1043             Kang Li <kanglictf@gmail.com>
1044
1045         PR gdb/21600
1046
1047         * dwarf2-frame.c (read_initial_length): Be consistent about using
1048         unsigned representation of length.
1049         (decode_frame_entry_1): Likewise.  Check for wraparound of
1050         end pointer as well as buffer overflow.
1051
1052 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1053
1054         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1055         "vq".
1056
1057 2019-04-24  Tom Tromey  <tromey@adacore.com>
1058
1059         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1060
1061 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1062
1063         * s12z-tdep.c (s12z_unwind_pc): Delete.
1064         (s12z_unwind_sp): Delete.
1065         (s12z_gdbarch_init): Don't register deleted functions with
1066         gdbarch.
1067
1068 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1069
1070         * rl78-tdep.c (rl78_unwind_sp): Delete.
1071         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1072
1073 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1074
1075         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1076         (xstormy16_unwind_pc): Delete.
1077         (xstormy16_dummy_id): Delete.
1078         (xstormy16_gdbarch_init): Don't register deleted functions with
1079         gdbarch.
1080
1081 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1082
1083         * vax-tdep.c (vax_unwind_pc): Delete.
1084         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1085
1086 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1087
1088         * v850-tdep.c (v850_unwind_sp): Delete.
1089         (v850_unwind_pc): Delete.
1090         (v850_dummy_id): Delete.
1091         (v850_gdbarch_init): Don't register deleted functions with
1092         gdbarch.
1093
1094 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1095
1096         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1097         (tilegx_unwind_pc): Delete.
1098         (tilegx_unwind_dummy_id): Delete.
1099         (tilegx_gdbarch_init): Don't register deleted functions with
1100         gdbarch.
1101
1102 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1103
1104         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1105         (tic6x_dummy_id): Delete.
1106         (tic6x_gdbarch_init): Don't register deleted functions with
1107         gdbarch.
1108
1109 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1110
1111         * sparc-tdep.c (sparc_unwind_pc): Delete.
1112         (sparc32_gdbarch_init): Don't register deleted function with
1113         gdbarch.
1114
1115 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1116
1117         * sh-tdep.c (sh_unwind_sp): Delete.
1118         (sh_unwind_pc): Delete.
1119         (sh_dummy_id): Delete.
1120         (sh_gdbarch_init): Don't register deleted functions with
1121         gdbarch.
1122
1123 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1124
1125         * score-tdep.c (score_unwind_sp): Delete.
1126         (score_unwind_pc): Delete.
1127         (score_dummy_id): Delete.
1128         (score_gdbarch_init): Don't register deleted functions with
1129         gdbarch.
1130
1131 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1132
1133         * rx-tdep.c (rx_unwind_pc): Delete.
1134         (rx_unwind_sp): Delete.
1135         (rx_dummy_id): Delete.
1136         (rx_gdbarch_init): Don't register deleted functions with
1137         gdbarch.  Update comment.
1138
1139 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1140
1141         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1142         (rs6000_dummy_id): Delete.
1143         (rs6000_gdbarch_init): Don't register deleted functions with
1144         gdbarch.
1145
1146 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1147
1148         * or1k-tdep.c (or1k_dummy_id): Delete.
1149         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1150
1151 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1152
1153         * nios2-tdep.c (nios2_dummy_id): Delete.
1154         (nios2_unwind_sp): Delete.
1155         (nios2_gdbarch_init): Don't register deleted functions with
1156         gdbarch.
1157
1158 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1159
1160         * nds32-tdep.c (nds32_dummy_id): Delete.
1161         (nds32_unwind_pc): Delete.
1162         (nds32_unwind_sp): Delete.
1163         (nds32_gdbarch_init): Don't register deleted functions with
1164         gdbarch.
1165
1166 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1167
1168         * msp430-tdep.c (msp430_unwind_pc): Delete.
1169         (msp430_unwind_sp): Delete.
1170         (msp430_dummy_id): Delete.
1171         (msp430_gdbarch_init): Don't register deleted functions with
1172         gdbarch.
1173
1174 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1175
1176         * moxie-tdep.c (moxie_unwind_sp): Delete.
1177         (moxie_unwind_pc): Delete.
1178         (moxie_dummy_id): Delete.
1179         (moxie_gdbarch_init): Don't register deleted functions with
1180         gdbarch.
1181
1182 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1183
1184         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1185         (mn10300_unwind_pc): Delete.
1186         (mn10300_unwind_sp): Delete.
1187         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1188         mn10300_unwind_sp.
1189         (mn10300_frame_unwind_init): Don't register deleted functions with
1190         gdbarch.
1191
1192 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1193
1194         * mep-tdep.c (mep_unwind_pc): Delete.
1195         (mep_unwind_sp): Delete.
1196         (mep_dummy_id): Delete.
1197         (mep_gdbarch_init): Don't register deleted functions with
1198         gdbarch.
1199
1200 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1201
1202         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1203         (m68hc11_unwind_sp): Delete.
1204         (m68hc11_gdbarch_init): Don't register deleted functions with
1205         gdbarch.
1206
1207 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1208
1209         * m32r-tdep.c (m32r_unwind_sp): Delete.
1210         (m32r_unwind_pc): Delete.
1211         (m32r_dummy_id): Delete.
1212         (m32r_gdbarch_init): Don't register deleted functions with
1213         gdbarch.
1214
1215 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1216
1217         * m32c-tdep.c (m32c_unwind_pc): Delete.
1218         (m32c_unwind_sp): Delete.
1219         (m32c_dummy_id): Delete.
1220         (m32c_gdbarch_init): Don't register deleted functions with
1221         gdbarch.
1222
1223 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1224
1225         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1226         (lm32_unwind_pc): Delete.
1227         (lm32_dummy_id): Delete.
1228         (lm32_gdbarch_init): Don't register deleted functions with
1229         gdbarch.
1230
1231 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1232
1233         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1234         (iq2000_unwind_pc): Delete.
1235         (iq2000_dummy_id): Delete.
1236         (iq2000_gdbarch_init): Don't register deleted functions with
1237         gdbarch.
1238
1239 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1240
1241         * nds32-tdep.c (nds32_type_align): Delete.
1242         (nds32_push_dummy_call): Use type_align instead.
1243
1244 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1245
1246         * arm-tdep.c (arm_type_align): Only handle vector override case.
1247         (arm_push_dummy_call): Use type_align.
1248         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1249
1250 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1251
1252         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1253         case.
1254         (pass_on_stack): Use type_align.
1255         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1256         function.
1257
1258 2019-04-23  Tom Tromey  <tromey@adacore.com>
1259
1260         * dwarf2read.c (line_header::file_name_at): Remove unused
1261         overload.
1262
1263 2019-04-23  Tom de Vries  <tdevries@suse.de>
1264
1265         PR gdb/24438
1266         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1267         invocation.
1268
1269
1270 2019-03-27  Ali Tamur  <tamur@google.com>
1271
1272         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1273         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1274         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1275         (dwarf_expr_context::get_addr_index): Likewise
1276         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1277         (symbol_needs_eval_context::get_addr_index): Likewise
1278         (disassemble_dwarf_expression): Add DW_OP_addrx
1279         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1280         (read_cutu_die_from_dwo): Update comment
1281         (skip_one_die): Add DW_FORM_addrx
1282         (read_attribute_value): Likewise
1283         (var_decode_location): Add DW_OP_addrx
1284         (dwarf2_const_value_attr): Add DW_FORM_addrx
1285         (dump_die_shallow): Likewise
1286         (dwarf2_fetch_constant_bytes): Likewise
1287         (decode_locdesc): Add DW_OP_addrx
1288         (skip_form_bytes): Add DW_FORM_addrx
1289
1290 2019-04-22  Ali Tamur  <tamur@google.com>
1291
1292         * MAINTAINERS (Write After Approval): Add self.
1293
1294 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1295
1296         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1297         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1298         (open_symbol_file_object): Likewise.
1299         (svr4_default_sos): Add info parameter.
1300         (svr4_read_so_list): Likewise.
1301         (svr4_current_sos_direct): Adjust functions calls to pass down
1302         info.
1303         (svr4_current_sos_1): Add info parameter.
1304         (svr4_current_sos): Call get_svr4_info, pass info down to
1305         svr4_current_sos_1.
1306         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1307         get_svr4_info.
1308         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1309         get_svr4_info.
1310         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1311         to get_svr4_info.
1312         (probes_table_remove_objfile_probes): Likewise.
1313         (register_solib_event_probe): Add info parameter.
1314         (solist_update_incremental): Pass info parameter down to
1315         svr4_read_so_list.
1316         (disable_probes_interface): Add info parameter.
1317         (svr4_handle_solib_event): Pass current_program_space to
1318         get_svr4_info.  Adjust disable_probes_interface cleanup.
1319         (svr4_create_probe_breakpoints): Add info parameter, pass it
1320         down to register_solib_event_probe.
1321         (svr4_create_solib_event_breakpoints): Add info parameter,
1322         pass it down to svr4_create_probe_breakpoints.
1323         (enable_break): Pass info down to
1324         svr4_create_solib_event_breakpoints.
1325         (svr4_solib_create_inferior_hook): Pass current_program_space to
1326         get_svr4_info.
1327         (svr4_clear_solib): Likewise.
1328
1329 2019-04-22  Pedro Alves  <palves@redhat.com>
1330
1331         * solib-svr4.c (svr4_free_objfile_observer): New.
1332         (probe_and_action::objfile): New field.
1333         (probes_table_htab_remove_objfile_probes)
1334         (probes_table_remove_objfile_probes): New functions.
1335         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1336         in the new probe_and_action.  Don't store the probe in 'lookup'.
1337         (svr4_create_probe_breakpoints): Pass objfile to
1338         register_solib_event_probe.
1339         (_initialize_svr4_solib): Register a free_objfile observer.
1340
1341 2019-04-19  Tom Tromey  <tom@tromey.com>
1342
1343         * common/queue.h: Remove.
1344
1345 2019-04-19  Tom Tromey  <tom@tromey.com>
1346
1347         * event-loop.c: Don't include "common/queue.h".
1348
1349 2019-04-19  Tom Tromey  <tom@tromey.com>
1350
1351         * remote.c (remote_target): Use delete.
1352         * remote-notif.h: Include <list>, not "common/queue.h".
1353         (notif_client_p): Remove typedef.
1354         (remote_notif_state): Add constructor, destructor, initializer.
1355         <notif_queue>: Now a std::list.
1356         (remote_notif_state_xfree): Don't declare.
1357         * remote-notif.c (remote_notif_process, handle_notification)
1358         (remote_notif_state_allocate): Update.
1359         (~remote_notif_state): Rename from remote_notif_state_xfree.
1360
1361 2019-04-19  Tom Tromey  <tom@tromey.com>
1362
1363         * symfile.c (reread_symbols): Update.
1364         * objfiles.c (objfile_register_static_link)
1365         (objfile_lookup_static_link): Update
1366         (~objfile) Don't delete static_links.
1367         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1368
1369 2019-04-19  Tom Tromey  <tom@tromey.com>
1370
1371         * type-stack.h (struct type_stack) <insert>: Constify string.
1372         * type-stack.c (type_stack::insert): Constify string.
1373         * gdbtypes.h (lookup_template_type): Update.
1374         (address_space_name_to_int): Update.
1375         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1376         const.
1377         (lookup_template_type): Make name const.
1378         * c-exp.y: Update rules.
1379         (lex_one_token, classify_name, classify_inner_name)
1380         (c_print_token): Update.
1381         * p-exp.y: Update rules.
1382         (yylex): Update.
1383         * f-exp.y: Update rules.
1384         (yylex): Update.
1385         * d-exp.y: Update rules.
1386         (lex_one_token, classify_name, classify_inner_name): Update.
1387         * parse.c (write_dollar_variable, copy_name): Return std::string.
1388         * parser-defs.h (copy_name): Change return type.
1389         * m2-exp.y: Update rules.
1390         (yylex): Update.
1391         * go-exp.y (lex_one_token): Update.
1392         Update rules.
1393         (classify_unsafe_function, classify_packaged_name)
1394         (classify_name, yylex): Update.
1395
1396 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1397
1398         * configure.ac: add --enable-source-highlight switch.
1399         * configure: Regenerate.
1400         * top.c (print_gdb_version): plumb --enable-source-highlight
1401         status to "show configuration".
1402
1403 2019-04-19  Tom Tromey  <tromey@adacore.com>
1404
1405         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1406         Check ADA_TYPE_P.
1407         (empty_record, ada_template_to_fixed_record_type_1)
1408         (template_to_static_fixed_type)
1409         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1410         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1411         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1412         macros.
1413
1414 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1415
1416         PR symtab/24423:
1417         * source.c (print_source_lines_base): Advance "iter" when a
1418         control character is seen.
1419
1420 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1421
1422         * inferior.h (struct infcall_suspend_state_deleter):
1423         Catch exception in destructor to avoid crash.
1424
1425 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1426
1427         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1428         close to the add_com "shell".
1429
1430 2019-04-18  Tom Tromey  <tromey@adacore.com>
1431
1432         * process-stratum-target.h (class process_stratum_target)
1433         <stratum>: Add "final".
1434
1435 2019-04-17  Tom Tromey  <tromey@adacore.com>
1436
1437         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1438         against nullptr before use.
1439
1440 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1441
1442         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1443
1444 2019-04-17  Jim Wilson  <jimw@sifive.com>
1445             Andrew Burgess  <andrew.burgess@embecosm.com>
1446
1447         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1448         code read might fail, assume 4-byte breakpoint in that case.
1449
1450 2019-04-15  Leszek Swirski  <leszeks@google.com>
1451
1452         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1453         rather than a hand-rolled POD check when checking for forced MEMORY
1454         classification.
1455
1456 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1457
1458         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1459         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1460         function.
1461         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1462         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1463         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1464         declaration.
1465
1466 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1467
1468         * aarch64-linux-nat.c
1469         (aarch64_linux_nat_target::thread_architecture): Add override.
1470         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1471         each VQ.
1472
1473 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1474
1475         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1476
1477 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1478
1479         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1480         target types of size 96-bits, add some additional comments, and
1481         check that the builtin type we found was the correct size.
1482
1483 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1484
1485         * utils.c (prompt_for_continue): Don't restore the styling at the
1486         end, as applied_style has the wrong value.  This fixes styling in
1487         long lists of file names that are interrupted by the "Continue?"
1488         prompt.
1489
1490 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1491
1492         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1493         * c-lang.c (c_language_defn): Likewise.
1494         (cplus_language_defn): Likewise.
1495         (asm_language_defn): Likewise.
1496         (minimal_language_defn): Likewise.
1497         * d-lang.c (d_language_defn): Likewise.
1498         * f-lang.c (f_language_defn): Likewise.
1499         * go-lang.c (go_language_defn): Likewise.
1500         * language.c (unknown_language_defn): Likewise.
1501         (auto_language_defn): Likewise.
1502         * language.h (struct language_defn): Remove la_magic field.
1503         (LANG_MAGIC): Delete.
1504         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1505         * objc-lang.c (objc_language_defn): Likewise.
1506         * opencl-lang.c (opencl_language_defn): Likewise.
1507         * p-lang.c (pascal_language_defn): Likewise.
1508         * rust-lang.c (rust_language_defn): Likewise.
1509
1510 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1511
1512         * riscv-tdep.c (riscv_type_align): New function.
1513         (riscv_type_alignment): Delete.
1514         (riscv_arg_location): Use 'type_align'.
1515         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1516
1517 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1518
1519         * gdbtypes.c (type_align): A struct with no non-static fields also
1520         has alignment of 1.
1521
1522 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1523
1524         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1525         component to 0.
1526         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1527         member.
1528         (riscv_struct_info::analyse): New implementation using new
1529         analyse_inner member function.
1530         (riscv_struct_info::field_offset): New member function.
1531         (riscv_struct_info::m_offsets): New member variable.
1532         (riscv_struct_info::analyse_inner): New private member function,
1533         takes the old implementation of riscv_struct_info::analyse but
1534         extended to track field offsets.
1535         (riscv_call_arg_struct): Update the struct folding special cases
1536         to handle cases where empty C++ structs, which are non-zero
1537         length, are found.
1538         (riscv_arg_location): Initialise the length of each location, a
1539         non-zero length now indicates the location is in use.
1540         (riscv_push_dummy_call): Allow for the first location having a
1541         non-zero offset when setting up arguments.
1542         (riscv_return_value): Likewise, but for return values.
1543
1544 2019-04-11  Tom Tromey  <tromey@adacore.com>
1545
1546         * utils.c (internal_vproblem): Make "msg" const.
1547
1548 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1549
1550         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1551         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1552         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1553         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1554
1555 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1556
1557         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1558         function.
1559         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1560         of amd64_collect_native_gregset.
1561         (amd64_linux_nat_target::store_registers): Likewise.
1562
1563 2019-04-10  Tom Tromey  <tom@tromey.com>
1564
1565         * symtab.c (lookup_global_symbol_from_objfile)
1566         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1567         * objfiles.h (class separate_debug_iterator): New.
1568         (class separate_debug_range): New.
1569         (struct objfile) <separate_debug_objfiles>: New method.
1570         (objfile_separate_debug_iterate): Don't declare.
1571         * objfiles.c (separate_debug_iterator::operator++): Rename from
1572         objfile_separate_debug_iterate.
1573         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1574         iterator.
1575         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1576         iterator.
1577
1578 2019-04-10  Tom Tromey  <tom@tromey.com>
1579
1580         * symfile.c (reread_symbols): Remove old comment.
1581         * objfiles.c (free_all_objfiles): Fix a typo.
1582
1583 2019-04-10  Tom Tromey  <tom@tromey.com>
1584
1585         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1586         * minsyms.c (lookup_minimal_symbol): Use foreach.
1587         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1588         (lookup_minimal_symbol_solib_trampoline): Likewise.
1589         * symfile.c (reread_symbols): Use foreach.
1590
1591 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1592             Tom Tromey  <tromey@adacore.com>
1593
1594         PR rust/24414:
1595         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1596         (rust_lex_int_test): Change "value" to be LONGEST.
1597         (rust_lex_tests): Add test for long integer literal.
1598
1599 2019-04-09  Tom Tromey  <tromey@adacore.com>
1600
1601         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1602         to bool.
1603         (extended_remote_target::attach): Update.
1604         (remote_target::remote_notice_new_inferior): Update.
1605         (remote_target::add_current_inferior_and_thread): Update.
1606         * inferior.c (exit_inferior_1): Use "false".
1607         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1608
1609 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1610
1611         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1612         the "start" command.
1613
1614 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1615
1616         * python/py-inferior.c (infpy_thread_from_thread_handle):
1617         Adjust comments to reflect renaming of thread_from_thread_handle
1618         to thread_from_handle.  Adjust keywords.  Fix type error message.
1619         (inferior_object_methods): Add thread_from_handle.  Retain
1620         thread_from_thread_handle, but mark it as deprecated.
1621
1622 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1623
1624         * gdbthread.h (find_thread_by_handle): Revise declaration.
1625         * thread.c (find_thread_by_handle): Likewise.  Adjust
1626         implementation too.
1627         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1628         support for buffer objects as handles.
1629
1630 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1631
1632         * python/py-infthread.c (thpy_thread_handle): New function.
1633         (thread_object_methods): Register thpy_thread_handle.
1634
1635 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1636
1637         * gdbthread.h (thread_to_thread_handle): Declare.
1638         * thread.c (gdbtypes.h): Include.
1639         (thread_to_thread_handle): New function.
1640
1641         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1642         (target_thread_info_to_thread_handle): Declare.
1643         * target.c (target_thread_info_to_thread_handle): New function.
1644         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1645         * target-delegates.c: Regenerate.
1646
1647         * linux-thread-db.c (class thread_db_target): Add method
1648         thread_info_to_thread_handle.
1649         (thread_db_target::thread_info_to_thread_handle): Define.
1650         * remote.c (class remote_target): Add new method
1651         thread_info_to_thread_handle.
1652         (remote_target::thread_info_to_thread_handle): Define.
1653
1654 2019-04-08  Pedro Alves  <palves@redhat.com>
1655
1656         * common/common-exceptions.c (throw_exception): Don't create
1657         named object to throw; throw directly.
1658         (throw_it): Likewise.  Don't initialize gdb_exception::message
1659         here, with new; pass FMT and AP to the ctor instead.
1660         * common/common-exceptions.h: Include <string>.
1661         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1662         const char *, va_list)): New ctor.  Use std::make_shared.
1663         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1664         errors)): Delete.
1665         (gdb_exception_error::gdb_exception_error(enum errors, const char
1666         *, va_list)): New.
1667         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1668         Add assertion.
1669         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1670         errors)): Delete.
1671         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1672         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1673         Add assertion.
1674
1675 2019-04-08  Tom Tromey  <tom@tromey.com>
1676
1677         * valops.c (value_rtti_indirect_type): Replace throw_exception
1678         with throw.
1679         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1680         with throw.
1681         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1682         throw.
1683         * target.c (target_translate_tls_address): Replace throw_exception
1684         with throw.
1685         * stack.c (frame_apply_command_count): Replace throw_exception
1686         with throw.
1687         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1688         throw.
1689         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1690         with throw.
1691         * rs6000-tdep.c (rs6000_frame_cache)
1692         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1693         * remote.c: Replace throw_exception with throw.
1694         * record-full.c (record_full_message, record_full_wait_1)
1695         (record_full_restore): Replace throw_exception with throw.
1696         * record-btrace.c:
1697         (get_thread_current_frame_id, record_btrace_start_replaying)
1698         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1699         (cmd_record_btrace_start): Replace throw_exception with throw.
1700         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1701         throw.
1702         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1703         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1704         * linespec.c:
1705         (find_linespec_symbols): Replace throw_exception with throw.
1706         * infrun.c (displaced_step_prepare, resume): Replace
1707         throw_exception with throw.
1708         * infcmd.c (post_create_inferior): Replace throw_exception with
1709         throw.
1710         * inf-loop.c (inferior_event_handler): Replace throw_exception
1711         with throw.
1712         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1713         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1714         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1715         (get_prev_frame_always, get_frame_pc_if_available)
1716         (get_frame_address_in_block_if_available, get_frame_language):
1717         Replace throw_exception with throw.
1718         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1719         throw_exception with throw.
1720         * eval.c (fetch_subexp_value, evaluate_var_value)
1721         (evaluate_funcall, evaluate_subexp_standard): Replace
1722         throw_exception with throw.
1723         * dwarf2loc.c (call_site_find_chain)
1724         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1725         Replace throw_exception with throw.
1726         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1727         with throw.
1728         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1729         throw.
1730         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1731         * completer.c (complete_line_internal): Replace throw_exception
1732         with throw.
1733         * compile/compile-object-run.c (compile_object_run): Replace
1734         throw_exception with throw.
1735         * cli/cli-script.c (process_next_line): Replace throw_exception
1736         with throw.
1737         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1738         (btrace_enable, btrace_maint_update_pt_packets): Replace
1739         throw_exception with throw.
1740         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1741         throw_exception with throw.
1742         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1743         throw_exception with throw.
1744         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1745         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1746         * aarch64-tdep.c (aarch64_make_prologue_cache)
1747         (aarch64_make_stub_cache): Replace throw_exception with throw.
1748
1749 2019-04-08  Tom Tromey  <tom@tromey.com>
1750
1751         * common/common-exceptions.c (throw_exception): Rename from
1752         throw_exception_cxx.  Remove old copy.  Make argument const.
1753         (throw_it): Create and throw exception objects directly.
1754         * common/common-exceptions.h (throw_exception): Make argument
1755         const.
1756         (struct gdb_exception_error): Add constructor.
1757         (struct gdb_exception_quit): Add constructor.
1758
1759 2019-04-08  Tom Tromey  <tom@tromey.com>
1760
1761         * common/common-exceptions.h (exception_rethrow): Don't declare.
1762         (TRY_SJLJ): Update comment.
1763         (TRY, CATCH, END_CATCH): Remove.
1764         * common/common-exceptions.c (exception_rethrow): Remove.
1765
1766 2019-04-08  Tom Tromey  <tom@tromey.com>
1767
1768         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1769         Remove.
1770         (gdb_exception_error): Rename from
1771         gdb_exception_RETURN_MASK_ERROR.
1772         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1773         (gdb_quit_bad_alloc): Update.
1774         * aarch64-tdep.c: Update.
1775         * ada-lang.c: Update.
1776         * ada-typeprint.c: Update.
1777         * ada-valprint.c: Update.
1778         * amd64-tdep.c: Update.
1779         * arch-utils.c: Update.
1780         * break-catch-throw.c: Update.
1781         * breakpoint.c: Update.
1782         * btrace.c: Update.
1783         * c-varobj.c: Update.
1784         * cli/cli-cmds.c: Update.
1785         * cli/cli-interp.c: Update.
1786         * cli/cli-script.c: Update.
1787         * common/common-exceptions.c: Update.
1788         * common/new-op.c: Update.
1789         * common/selftest.c: Update.
1790         * compile/compile-c-symbols.c: Update.
1791         * compile/compile-cplus-symbols.c: Update.
1792         * compile/compile-object-load.c: Update.
1793         * compile/compile-object-run.c: Update.
1794         * completer.c: Update.
1795         * corelow.c: Update.
1796         * cp-abi.c: Update.
1797         * cp-support.c: Update.
1798         * cp-valprint.c: Update.
1799         * darwin-nat.c: Update.
1800         * disasm-selftests.c: Update.
1801         * dtrace-probe.c: Update.
1802         * dwarf-index-cache.c: Update.
1803         * dwarf-index-write.c: Update.
1804         * dwarf2-frame-tailcall.c: Update.
1805         * dwarf2-frame.c: Update.
1806         * dwarf2loc.c: Update.
1807         * dwarf2read.c: Update.
1808         * eval.c: Update.
1809         * event-loop.c: Update.
1810         * event-top.c: Update.
1811         * exec.c: Update.
1812         * f-valprint.c: Update.
1813         * fbsd-tdep.c: Update.
1814         * frame-unwind.c: Update.
1815         * frame.c: Update.
1816         * gdbtypes.c: Update.
1817         * gnu-v3-abi.c: Update.
1818         * guile/guile-internal.h: Update.
1819         * guile/scm-block.c: Update.
1820         * guile/scm-breakpoint.c: Update.
1821         * guile/scm-cmd.c: Update.
1822         * guile/scm-disasm.c: Update.
1823         * guile/scm-frame.c: Update.
1824         * guile/scm-lazy-string.c: Update.
1825         * guile/scm-math.c: Update.
1826         * guile/scm-param.c: Update.
1827         * guile/scm-ports.c: Update.
1828         * guile/scm-pretty-print.c: Update.
1829         * guile/scm-symbol.c: Update.
1830         * guile/scm-symtab.c: Update.
1831         * guile/scm-type.c: Update.
1832         * guile/scm-value.c: Update.
1833         * i386-linux-tdep.c: Update.
1834         * i386-tdep.c: Update.
1835         * inf-loop.c: Update.
1836         * infcall.c: Update.
1837         * infcmd.c: Update.
1838         * infrun.c: Update.
1839         * jit.c: Update.
1840         * language.c: Update.
1841         * linespec.c: Update.
1842         * linux-fork.c: Update.
1843         * linux-nat.c: Update.
1844         * linux-tdep.c: Update.
1845         * linux-thread-db.c: Update.
1846         * main.c: Update.
1847         * mi/mi-cmd-break.c: Update.
1848         * mi/mi-cmd-stack.c: Update.
1849         * mi/mi-interp.c: Update.
1850         * mi/mi-main.c: Update.
1851         * objc-lang.c: Update.
1852         * p-valprint.c: Update.
1853         * parse.c: Update.
1854         * ppc-linux-tdep.c: Update.
1855         * printcmd.c: Update.
1856         * python/py-arch.c: Update.
1857         * python/py-breakpoint.c: Update.
1858         * python/py-cmd.c: Update.
1859         * python/py-finishbreakpoint.c: Update.
1860         * python/py-frame.c: Update.
1861         * python/py-framefilter.c: Update.
1862         * python/py-gdb-readline.c: Update.
1863         * python/py-inferior.c: Update.
1864         * python/py-infthread.c: Update.
1865         * python/py-lazy-string.c: Update.
1866         * python/py-linetable.c: Update.
1867         * python/py-objfile.c: Update.
1868         * python/py-param.c: Update.
1869         * python/py-prettyprint.c: Update.
1870         * python/py-progspace.c: Update.
1871         * python/py-record-btrace.c: Update.
1872         * python/py-record.c: Update.
1873         * python/py-symbol.c: Update.
1874         * python/py-type.c: Update.
1875         * python/py-unwind.c: Update.
1876         * python/py-utils.c: Update.
1877         * python/py-value.c: Update.
1878         * python/python.c: Update.
1879         * record-btrace.c: Update.
1880         * record-full.c: Update.
1881         * remote-fileio.c: Update.
1882         * remote.c: Update.
1883         * riscv-tdep.c: Update.
1884         * rs6000-aix-tdep.c: Update.
1885         * rs6000-tdep.c: Update.
1886         * rust-exp.y: Update.
1887         * rust-lang.c: Update.
1888         * s390-tdep.c: Update.
1889         * selftest-arch.c: Update.
1890         * solib-dsbt.c: Update.
1891         * solib-frv.c: Update.
1892         * solib-spu.c: Update.
1893         * solib-svr4.c: Update.
1894         * solib.c: Update.
1895         * sparc64-linux-tdep.c: Update.
1896         * stack.c: Update.
1897         * symfile-mem.c: Update.
1898         * symmisc.c: Update.
1899         * target.c: Update.
1900         * thread.c: Update.
1901         * top.c: Update.
1902         * tracefile-tfile.c: Update.
1903         * tui/tui.c: Update.
1904         * typeprint.c: Update.
1905         * unittests/cli-utils-selftests.c: Update.
1906         * unittests/parse-connection-spec-selftests.c: Update.
1907         * valops.c: Update.
1908         * valprint.c: Update.
1909         * value.c: Update.
1910         * varobj.c: Update.
1911         * windows-nat.c: Update.
1912         * x86-linux-nat.c: Update.
1913         * xml-support.c: Update.
1914
1915 2019-04-08  Tom Tromey  <tom@tromey.com>
1916
1917         * xml-support.c: Use C++ exception handling.
1918         * x86-linux-nat.c: Use C++ exception handling.
1919         * windows-nat.c: Use C++ exception handling.
1920         * varobj.c: Use C++ exception handling.
1921         * value.c: Use C++ exception handling.
1922         * valprint.c: Use C++ exception handling.
1923         * valops.c: Use C++ exception handling.
1924         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1925         handling.
1926         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1927         * typeprint.c: Use C++ exception handling.
1928         * tui/tui.c: Use C++ exception handling.
1929         * tracefile-tfile.c: Use C++ exception handling.
1930         * top.c: Use C++ exception handling.
1931         * thread.c: Use C++ exception handling.
1932         * target.c: Use C++ exception handling.
1933         * symmisc.c: Use C++ exception handling.
1934         * symfile-mem.c: Use C++ exception handling.
1935         * stack.c: Use C++ exception handling.
1936         * sparc64-linux-tdep.c: Use C++ exception handling.
1937         * solib.c: Use C++ exception handling.
1938         * solib-svr4.c: Use C++ exception handling.
1939         * solib-spu.c: Use C++ exception handling.
1940         * solib-frv.c: Use C++ exception handling.
1941         * solib-dsbt.c: Use C++ exception handling.
1942         * selftest-arch.c: Use C++ exception handling.
1943         * s390-tdep.c: Use C++ exception handling.
1944         * rust-lang.c: Use C++ exception handling.
1945         * rust-exp.y: Use C++ exception handling.
1946         * rs6000-tdep.c: Use C++ exception handling.
1947         * rs6000-aix-tdep.c: Use C++ exception handling.
1948         * riscv-tdep.c: Use C++ exception handling.
1949         * remote.c: Use C++ exception handling.
1950         * remote-fileio.c: Use C++ exception handling.
1951         * record-full.c: Use C++ exception handling.
1952         * record-btrace.c: Use C++ exception handling.
1953         * python/python.c: Use C++ exception handling.
1954         * python/py-value.c: Use C++ exception handling.
1955         * python/py-utils.c: Use C++ exception handling.
1956         * python/py-unwind.c: Use C++ exception handling.
1957         * python/py-type.c: Use C++ exception handling.
1958         * python/py-symbol.c: Use C++ exception handling.
1959         * python/py-record.c: Use C++ exception handling.
1960         * python/py-record-btrace.c: Use C++ exception handling.
1961         * python/py-progspace.c: Use C++ exception handling.
1962         * python/py-prettyprint.c: Use C++ exception handling.
1963         * python/py-param.c: Use C++ exception handling.
1964         * python/py-objfile.c: Use C++ exception handling.
1965         * python/py-linetable.c: Use C++ exception handling.
1966         * python/py-lazy-string.c: Use C++ exception handling.
1967         * python/py-infthread.c: Use C++ exception handling.
1968         * python/py-inferior.c: Use C++ exception handling.
1969         * python/py-gdb-readline.c: Use C++ exception handling.
1970         * python/py-framefilter.c: Use C++ exception handling.
1971         * python/py-frame.c: Use C++ exception handling.
1972         * python/py-finishbreakpoint.c: Use C++ exception handling.
1973         * python/py-cmd.c: Use C++ exception handling.
1974         * python/py-breakpoint.c: Use C++ exception handling.
1975         * python/py-arch.c: Use C++ exception handling.
1976         * printcmd.c: Use C++ exception handling.
1977         * ppc-linux-tdep.c: Use C++ exception handling.
1978         * parse.c: Use C++ exception handling.
1979         * p-valprint.c: Use C++ exception handling.
1980         * objc-lang.c: Use C++ exception handling.
1981         * mi/mi-main.c: Use C++ exception handling.
1982         * mi/mi-interp.c: Use C++ exception handling.
1983         * mi/mi-cmd-stack.c: Use C++ exception handling.
1984         * mi/mi-cmd-break.c: Use C++ exception handling.
1985         * main.c: Use C++ exception handling.
1986         * linux-thread-db.c: Use C++ exception handling.
1987         * linux-tdep.c: Use C++ exception handling.
1988         * linux-nat.c: Use C++ exception handling.
1989         * linux-fork.c: Use C++ exception handling.
1990         * linespec.c: Use C++ exception handling.
1991         * language.c: Use C++ exception handling.
1992         * jit.c: Use C++ exception handling.
1993         * infrun.c: Use C++ exception handling.
1994         * infcmd.c: Use C++ exception handling.
1995         * infcall.c: Use C++ exception handling.
1996         * inf-loop.c: Use C++ exception handling.
1997         * i386-tdep.c: Use C++ exception handling.
1998         * i386-linux-tdep.c: Use C++ exception handling.
1999         * guile/scm-value.c: Use C++ exception handling.
2000         * guile/scm-type.c: Use C++ exception handling.
2001         * guile/scm-symtab.c: Use C++ exception handling.
2002         * guile/scm-symbol.c: Use C++ exception handling.
2003         * guile/scm-pretty-print.c: Use C++ exception handling.
2004         * guile/scm-ports.c: Use C++ exception handling.
2005         * guile/scm-param.c: Use C++ exception handling.
2006         * guile/scm-math.c: Use C++ exception handling.
2007         * guile/scm-lazy-string.c: Use C++ exception handling.
2008         * guile/scm-frame.c: Use C++ exception handling.
2009         * guile/scm-disasm.c: Use C++ exception handling.
2010         * guile/scm-cmd.c: Use C++ exception handling.
2011         * guile/scm-breakpoint.c: Use C++ exception handling.
2012         * guile/scm-block.c: Use C++ exception handling.
2013         * guile/guile-internal.h: Use C++ exception handling.
2014         * gnu-v3-abi.c: Use C++ exception handling.
2015         * gdbtypes.c: Use C++ exception handling.
2016         * frame.c: Use C++ exception handling.
2017         * frame-unwind.c: Use C++ exception handling.
2018         * fbsd-tdep.c: Use C++ exception handling.
2019         * f-valprint.c: Use C++ exception handling.
2020         * exec.c: Use C++ exception handling.
2021         * event-top.c: Use C++ exception handling.
2022         * event-loop.c: Use C++ exception handling.
2023         * eval.c: Use C++ exception handling.
2024         * dwarf2read.c: Use C++ exception handling.
2025         * dwarf2loc.c: Use C++ exception handling.
2026         * dwarf2-frame.c: Use C++ exception handling.
2027         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2028         * dwarf-index-write.c: Use C++ exception handling.
2029         * dwarf-index-cache.c: Use C++ exception handling.
2030         * dtrace-probe.c: Use C++ exception handling.
2031         * disasm-selftests.c: Use C++ exception handling.
2032         * darwin-nat.c: Use C++ exception handling.
2033         * cp-valprint.c: Use C++ exception handling.
2034         * cp-support.c: Use C++ exception handling.
2035         * cp-abi.c: Use C++ exception handling.
2036         * corelow.c: Use C++ exception handling.
2037         * completer.c: Use C++ exception handling.
2038         * compile/compile-object-run.c: Use C++ exception handling.
2039         * compile/compile-object-load.c: Use C++ exception handling.
2040         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2041         * compile/compile-c-symbols.c: Use C++ exception handling.
2042         * common/selftest.c: Use C++ exception handling.
2043         * common/new-op.c: Use C++ exception handling.
2044         * cli/cli-script.c: Use C++ exception handling.
2045         * cli/cli-interp.c: Use C++ exception handling.
2046         * cli/cli-cmds.c: Use C++ exception handling.
2047         * c-varobj.c: Use C++ exception handling.
2048         * btrace.c: Use C++ exception handling.
2049         * breakpoint.c: Use C++ exception handling.
2050         * break-catch-throw.c: Use C++ exception handling.
2051         * arch-utils.c: Use C++ exception handling.
2052         * amd64-tdep.c: Use C++ exception handling.
2053         * ada-valprint.c: Use C++ exception handling.
2054         * ada-typeprint.c: Use C++ exception handling.
2055         * ada-lang.c: Use C++ exception handling.
2056         * aarch64-tdep.c: Use C++ exception handling.
2057
2058 2019-04-08  Tom Tromey  <tom@tromey.com>
2059
2060         * xml-support.c (gdb_xml_parser::parse): Update.
2061         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2062         * value.c (show_convenience): Update.
2063         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2064         (test_parse_flags_qcs): Update.
2065         * thread.c (thr_try_catch_cmd): Update.
2066         * target.c (target_translate_tls_address): Update.
2067         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2068         (info_frame_command_core, frame_apply_command_count): Update.
2069         * rust-exp.y (rust_lex_exception_test): Update.
2070         * riscv-tdep.c (riscv_print_one_register_info): Update.
2071         * remote.c (remote_target::enable_btrace): Update.
2072         * record-btrace.c (record_btrace_enable_warn): Update.
2073         * python/py-utils.c (gdbpy_convert_exception): Update.
2074         * printcmd.c (do_one_display, print_variable_and_value): Update.
2075         * mi/mi-main.c (mi_print_exception): Update.
2076         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2077         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2078         * linux-nat.c (linux_nat_target::attach): Update.
2079         * linux-fork.c (class scoped_switch_fork_info): Update.
2080         * infrun.c (displaced_step_prepare): Update.
2081         * infcall.c (call_function_by_hand_dummy): Update.
2082         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2083         * gnu-v3-abi.c (print_one_vtable): Update.
2084         * frame.c (get_prev_frame_always): Update.
2085         * f-valprint.c (info_common_command_for_block): Update.
2086         * exec.c (try_open_exec_file): Update.
2087         * exceptions.c (print_exception, exception_print)
2088         (exception_fprintf, exception_print_same): Update.
2089         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2090         * dwarf-index-cache.c (index_cache::store)
2091         (index_cache::lookup_gdb_index): Update.
2092         * darwin-nat.c (maybe_cache_shell): Update.
2093         * cp-valprint.c (cp_print_value_fields): Update.
2094         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2095         (gcc_cplus_symbol_address): Update.
2096         * compile/compile-c-symbols.c (gcc_convert_symbol)
2097         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2098         * common/selftest.c: Update.
2099         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2100         a std::string.
2101         (exception_try_scope_entry, exception_try_scope_exit): Don't
2102         declare.
2103         (struct exception_try_scope): Remove.
2104         (TRY): Don't use exception_try_scope.
2105         (struct gdb_exception): Add constructor, operator=.
2106         <what>: New method.
2107         (struct gdb_exception_RETURN_MASK_ALL)
2108         (struct gdb_exception_RETURN_MASK_ERROR)
2109         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2110         (struct gdb_quit_bad_alloc): Update.
2111         * common/common-exceptions.c (exception_none): Change
2112         initializer.
2113         (struct catcher) <state, exception>: Initialize inline.
2114         <prev>: Remove member.
2115         (current_catcher): Remove.
2116         (catchers): New global.
2117         (exceptions_state_mc_init): Simplify.
2118         (catcher_pop): Remove.
2119         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2120         (try_scope_depth, exception_try_scope_entry)
2121         (exception_try_scope_exit): Remove.
2122         (throw_exception_sjlj): Update.
2123         (exception_messages, exception_messages_size): Remove.
2124         (throw_it): Simplify.
2125         (gdb_exception_sliced_copy): Remove.
2126         (throw_exception_cxx): Update.
2127         * cli/cli-script.c (script_from_file): Update.
2128         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2129         Update.
2130         * ada-valprint.c (ada_val_print): Update.
2131         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2132         (create_excep_cond_exprs): Update.
2133
2134 2019-04-08  Tom Tromey  <tom@tromey.com>
2135
2136         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2137         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2138         (TRY, CATCH, END_CATCH): Remove some definitions.
2139         * common/common-exceptions.c: Don't use GDB_XCPT.
2140         (catcher_list_size): Remove.
2141         (throw_exception, throw_it): Simplify.
2142
2143 2019-04-05  Tom Tromey  <tom@tromey.com>
2144
2145         Revert the header-sorting patch.
2146         * ft32-tdep.c: Revert.
2147         * frv-tdep.c: Revert.
2148         * frv-linux-tdep.c: Revert.
2149         * frame.c: Revert.
2150         * frame-unwind.c: Revert.
2151         * frame-base.c: Revert.
2152         * fork-child.c: Revert.
2153         * findvar.c: Revert.
2154         * findcmd.c: Revert.
2155         * filesystem.c: Revert.
2156         * filename-seen-cache.h: Revert.
2157         * filename-seen-cache.c: Revert.
2158         * fbsd-tdep.c: Revert.
2159         * fbsd-nat.h: Revert.
2160         * fbsd-nat.c: Revert.
2161         * f-valprint.c: Revert.
2162         * f-typeprint.c: Revert.
2163         * f-lang.c: Revert.
2164         * extension.h: Revert.
2165         * extension.c: Revert.
2166         * extension-priv.h: Revert.
2167         * expprint.c: Revert.
2168         * exec.h: Revert.
2169         * exec.c: Revert.
2170         * exceptions.c: Revert.
2171         * event-top.c: Revert.
2172         * event-loop.c: Revert.
2173         * eval.c: Revert.
2174         * elfread.c: Revert.
2175         * dwarf2read.h: Revert.
2176         * dwarf2read.c: Revert.
2177         * dwarf2loc.c: Revert.
2178         * dwarf2expr.h: Revert.
2179         * dwarf2expr.c: Revert.
2180         * dwarf2-frame.c: Revert.
2181         * dwarf2-frame-tailcall.c: Revert.
2182         * dwarf-index-write.h: Revert.
2183         * dwarf-index-write.c: Revert.
2184         * dwarf-index-common.c: Revert.
2185         * dwarf-index-cache.h: Revert.
2186         * dwarf-index-cache.c: Revert.
2187         * dummy-frame.c: Revert.
2188         * dtrace-probe.c: Revert.
2189         * disasm.h: Revert.
2190         * disasm.c: Revert.
2191         * disasm-selftests.c: Revert.
2192         * dictionary.c: Revert.
2193         * dicos-tdep.c: Revert.
2194         * demangle.c: Revert.
2195         * dcache.h: Revert.
2196         * dcache.c: Revert.
2197         * darwin-nat.h: Revert.
2198         * darwin-nat.c: Revert.
2199         * darwin-nat-info.c: Revert.
2200         * d-valprint.c: Revert.
2201         * d-namespace.c: Revert.
2202         * d-lang.c: Revert.
2203         * ctf.c: Revert.
2204         * csky-tdep.c: Revert.
2205         * csky-linux-tdep.c: Revert.
2206         * cris-tdep.c: Revert.
2207         * cris-linux-tdep.c: Revert.
2208         * cp-valprint.c: Revert.
2209         * cp-support.c: Revert.
2210         * cp-namespace.c: Revert.
2211         * cp-abi.c: Revert.
2212         * corelow.c: Revert.
2213         * corefile.c: Revert.
2214         * continuations.c: Revert.
2215         * completer.h: Revert.
2216         * completer.c: Revert.
2217         * complaints.c: Revert.
2218         * coffread.c: Revert.
2219         * coff-pe-read.c: Revert.
2220         * cli-out.h: Revert.
2221         * cli-out.c: Revert.
2222         * charset.c: Revert.
2223         * c-varobj.c: Revert.
2224         * c-valprint.c: Revert.
2225         * c-typeprint.c: Revert.
2226         * c-lang.c: Revert.
2227         * buildsym.c: Revert.
2228         * buildsym-legacy.c: Revert.
2229         * build-id.h: Revert.
2230         * build-id.c: Revert.
2231         * btrace.c: Revert.
2232         * bsd-uthread.c: Revert.
2233         * breakpoint.h: Revert.
2234         * breakpoint.c: Revert.
2235         * break-catch-throw.c: Revert.
2236         * break-catch-syscall.c: Revert.
2237         * break-catch-sig.c: Revert.
2238         * blockframe.c: Revert.
2239         * block.c: Revert.
2240         * bfin-tdep.c: Revert.
2241         * bfin-linux-tdep.c: Revert.
2242         * bfd-target.c: Revert.
2243         * bcache.c: Revert.
2244         * ax-general.c: Revert.
2245         * ax-gdb.h: Revert.
2246         * ax-gdb.c: Revert.
2247         * avr-tdep.c: Revert.
2248         * auxv.c: Revert.
2249         * auto-load.c: Revert.
2250         * arm-wince-tdep.c: Revert.
2251         * arm-tdep.c: Revert.
2252         * arm-symbian-tdep.c: Revert.
2253         * arm-pikeos-tdep.c: Revert.
2254         * arm-obsd-tdep.c: Revert.
2255         * arm-nbsd-tdep.c: Revert.
2256         * arm-nbsd-nat.c: Revert.
2257         * arm-linux-tdep.c: Revert.
2258         * arm-linux-nat.c: Revert.
2259         * arm-fbsd-tdep.c: Revert.
2260         * arm-fbsd-nat.c: Revert.
2261         * arm-bsd-tdep.c: Revert.
2262         * arch-utils.c: Revert.
2263         * arc-tdep.c: Revert.
2264         * arc-newlib-tdep.c: Revert.
2265         * annotate.h: Revert.
2266         * annotate.c: Revert.
2267         * amd64-windows-tdep.c: Revert.
2268         * amd64-windows-nat.c: Revert.
2269         * amd64-tdep.c: Revert.
2270         * amd64-sol2-tdep.c: Revert.
2271         * amd64-obsd-tdep.c: Revert.
2272         * amd64-obsd-nat.c: Revert.
2273         * amd64-nbsd-tdep.c: Revert.
2274         * amd64-nbsd-nat.c: Revert.
2275         * amd64-nat.c: Revert.
2276         * amd64-linux-tdep.c: Revert.
2277         * amd64-linux-nat.c: Revert.
2278         * amd64-fbsd-tdep.c: Revert.
2279         * amd64-fbsd-nat.c: Revert.
2280         * amd64-dicos-tdep.c: Revert.
2281         * amd64-darwin-tdep.c: Revert.
2282         * amd64-bsd-nat.c: Revert.
2283         * alpha-tdep.c: Revert.
2284         * alpha-obsd-tdep.c: Revert.
2285         * alpha-nbsd-tdep.c: Revert.
2286         * alpha-mdebug-tdep.c: Revert.
2287         * alpha-linux-tdep.c: Revert.
2288         * alpha-linux-nat.c: Revert.
2289         * alpha-bsd-tdep.c: Revert.
2290         * alpha-bsd-nat.c: Revert.
2291         * aix-thread.c: Revert.
2292         * agent.c: Revert.
2293         * addrmap.c: Revert.
2294         * ada-varobj.c: Revert.
2295         * ada-valprint.c: Revert.
2296         * ada-typeprint.c: Revert.
2297         * ada-tasks.c: Revert.
2298         * ada-lang.c: Revert.
2299         * aarch64-tdep.c: Revert.
2300         * aarch64-ravenscar-thread.c: Revert.
2301         * aarch64-newlib-tdep.c: Revert.
2302         * aarch64-linux-tdep.c: Revert.
2303         * aarch64-linux-nat.c: Revert.
2304         * aarch64-fbsd-tdep.c: Revert.
2305         * aarch64-fbsd-nat.c: Revert.
2306         * aarch32-linux-nat.c: Revert.
2307
2308 2019-04-05  Tom Tromey  <tom@tromey.com>
2309
2310         * ft32-tdep.c: Sort headers.
2311         * frv-tdep.c: Sort headers.
2312         * frv-linux-tdep.c: Sort headers.
2313         * frame.c: Sort headers.
2314         * frame-unwind.c: Sort headers.
2315         * frame-base.c: Sort headers.
2316         * fork-child.c: Sort headers.
2317         * findvar.c: Sort headers.
2318         * findcmd.c: Sort headers.
2319         * filesystem.c: Sort headers.
2320         * filename-seen-cache.h: Sort headers.
2321         * filename-seen-cache.c: Sort headers.
2322         * fbsd-tdep.c: Sort headers.
2323         * fbsd-nat.h: Sort headers.
2324         * fbsd-nat.c: Sort headers.
2325         * f-valprint.c: Sort headers.
2326         * f-typeprint.c: Sort headers.
2327         * f-lang.c: Sort headers.
2328         * extension.h: Sort headers.
2329         * extension.c: Sort headers.
2330         * extension-priv.h: Sort headers.
2331         * expprint.c: Sort headers.
2332         * exec.h: Sort headers.
2333         * exec.c: Sort headers.
2334         * exceptions.c: Sort headers.
2335         * event-top.c: Sort headers.
2336         * event-loop.c: Sort headers.
2337         * eval.c: Sort headers.
2338         * elfread.c: Sort headers.
2339         * dwarf2read.h: Sort headers.
2340         * dwarf2read.c: Sort headers.
2341         * dwarf2loc.c: Sort headers.
2342         * dwarf2expr.h: Sort headers.
2343         * dwarf2expr.c: Sort headers.
2344         * dwarf2-frame.c: Sort headers.
2345         * dwarf2-frame-tailcall.c: Sort headers.
2346         * dwarf-index-write.h: Sort headers.
2347         * dwarf-index-write.c: Sort headers.
2348         * dwarf-index-common.c: Sort headers.
2349         * dwarf-index-cache.h: Sort headers.
2350         * dwarf-index-cache.c: Sort headers.
2351         * dummy-frame.c: Sort headers.
2352         * dtrace-probe.c: Sort headers.
2353         * disasm.h: Sort headers.
2354         * disasm.c: Sort headers.
2355         * disasm-selftests.c: Sort headers.
2356         * dictionary.c: Sort headers.
2357         * dicos-tdep.c: Sort headers.
2358         * demangle.c: Sort headers.
2359         * dcache.h: Sort headers.
2360         * dcache.c: Sort headers.
2361         * darwin-nat.h: Sort headers.
2362         * darwin-nat.c: Sort headers.
2363         * darwin-nat-info.c: Sort headers.
2364         * d-valprint.c: Sort headers.
2365         * d-namespace.c: Sort headers.
2366         * d-lang.c: Sort headers.
2367         * ctf.c: Sort headers.
2368         * csky-tdep.c: Sort headers.
2369         * csky-linux-tdep.c: Sort headers.
2370         * cris-tdep.c: Sort headers.
2371         * cris-linux-tdep.c: Sort headers.
2372         * cp-valprint.c: Sort headers.
2373         * cp-support.c: Sort headers.
2374         * cp-namespace.c: Sort headers.
2375         * cp-abi.c: Sort headers.
2376         * corelow.c: Sort headers.
2377         * corefile.c: Sort headers.
2378         * continuations.c: Sort headers.
2379         * completer.h: Sort headers.
2380         * completer.c: Sort headers.
2381         * complaints.c: Sort headers.
2382         * coffread.c: Sort headers.
2383         * coff-pe-read.c: Sort headers.
2384         * cli-out.h: Sort headers.
2385         * cli-out.c: Sort headers.
2386         * charset.c: Sort headers.
2387         * c-varobj.c: Sort headers.
2388         * c-valprint.c: Sort headers.
2389         * c-typeprint.c: Sort headers.
2390         * c-lang.c: Sort headers.
2391         * buildsym.c: Sort headers.
2392         * buildsym-legacy.c: Sort headers.
2393         * build-id.h: Sort headers.
2394         * build-id.c: Sort headers.
2395         * btrace.c: Sort headers.
2396         * bsd-uthread.c: Sort headers.
2397         * breakpoint.h: Sort headers.
2398         * breakpoint.c: Sort headers.
2399         * break-catch-throw.c: Sort headers.
2400         * break-catch-syscall.c: Sort headers.
2401         * break-catch-sig.c: Sort headers.
2402         * blockframe.c: Sort headers.
2403         * block.c: Sort headers.
2404         * bfin-tdep.c: Sort headers.
2405         * bfin-linux-tdep.c: Sort headers.
2406         * bfd-target.c: Sort headers.
2407         * bcache.c: Sort headers.
2408         * ax-general.c: Sort headers.
2409         * ax-gdb.h: Sort headers.
2410         * ax-gdb.c: Sort headers.
2411         * avr-tdep.c: Sort headers.
2412         * auxv.c: Sort headers.
2413         * auto-load.c: Sort headers.
2414         * arm-wince-tdep.c: Sort headers.
2415         * arm-tdep.c: Sort headers.
2416         * arm-symbian-tdep.c: Sort headers.
2417         * arm-pikeos-tdep.c: Sort headers.
2418         * arm-obsd-tdep.c: Sort headers.
2419         * arm-nbsd-tdep.c: Sort headers.
2420         * arm-nbsd-nat.c: Sort headers.
2421         * arm-linux-tdep.c: Sort headers.
2422         * arm-linux-nat.c: Sort headers.
2423         * arm-fbsd-tdep.c: Sort headers.
2424         * arm-fbsd-nat.c: Sort headers.
2425         * arm-bsd-tdep.c: Sort headers.
2426         * arch-utils.c: Sort headers.
2427         * arc-tdep.c: Sort headers.
2428         * arc-newlib-tdep.c: Sort headers.
2429         * annotate.h: Sort headers.
2430         * annotate.c: Sort headers.
2431         * amd64-windows-tdep.c: Sort headers.
2432         * amd64-windows-nat.c: Sort headers.
2433         * amd64-tdep.c: Sort headers.
2434         * amd64-sol2-tdep.c: Sort headers.
2435         * amd64-obsd-tdep.c: Sort headers.
2436         * amd64-obsd-nat.c: Sort headers.
2437         * amd64-nbsd-tdep.c: Sort headers.
2438         * amd64-nbsd-nat.c: Sort headers.
2439         * amd64-nat.c: Sort headers.
2440         * amd64-linux-tdep.c: Sort headers.
2441         * amd64-linux-nat.c: Sort headers.
2442         * amd64-fbsd-tdep.c: Sort headers.
2443         * amd64-fbsd-nat.c: Sort headers.
2444         * amd64-dicos-tdep.c: Sort headers.
2445         * amd64-darwin-tdep.c: Sort headers.
2446         * amd64-bsd-nat.c: Sort headers.
2447         * alpha-tdep.c: Sort headers.
2448         * alpha-obsd-tdep.c: Sort headers.
2449         * alpha-nbsd-tdep.c: Sort headers.
2450         * alpha-mdebug-tdep.c: Sort headers.
2451         * alpha-linux-tdep.c: Sort headers.
2452         * alpha-linux-nat.c: Sort headers.
2453         * alpha-bsd-tdep.c: Sort headers.
2454         * alpha-bsd-nat.c: Sort headers.
2455         * aix-thread.c: Sort headers.
2456         * agent.c: Sort headers.
2457         * addrmap.c: Sort headers.
2458         * ada-varobj.c: Sort headers.
2459         * ada-valprint.c: Sort headers.
2460         * ada-typeprint.c: Sort headers.
2461         * ada-tasks.c: Sort headers.
2462         * ada-lang.c: Sort headers.
2463         * aarch64-tdep.c: Sort headers.
2464         * aarch64-ravenscar-thread.c: Sort headers.
2465         * aarch64-newlib-tdep.c: Sort headers.
2466         * aarch64-linux-tdep.c: Sort headers.
2467         * aarch64-linux-nat.c: Sort headers.
2468         * aarch64-fbsd-tdep.c: Sort headers.
2469         * aarch64-fbsd-nat.c: Sort headers.
2470         * aarch32-linux-nat.c: Sort headers.
2471
2472 2019-04-04  Tom Tromey  <tom@tromey.com>
2473
2474         * varobj.c (varobj_create): Update.
2475         * rust-exp.y (struct rust_parser) <update_innermost_block,
2476         lookup_symbol>: New methods.
2477         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2478         Rename.
2479         (rust_parser::rust_lookup_type)
2480         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2481         * printcmd.c (display_command, do_one_display): Update.
2482         * parser-defs.h (struct parser_state) <parser_state>: Add
2483         "tracker" parameter.
2484         (block_tracker): New member.
2485         (class innermost_block_tracker) <innermost_block_tracker>: Add
2486         "types" parameter.
2487         <reset>: Remove method.
2488         (innermost_block): Don't declare.
2489         (null_post_parser): Update.
2490         * parse.c (innermost_block): Remove global.
2491         (write_dollar_variable): Update.
2492         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2493         Remove "tracker_types" parameter.
2494         (parse_expression): Add "tracker" parameter.
2495         (parse_expression_for_completion): Update.
2496         (null_post_parser): Add "tracker" parameter.
2497         * p-exp.y: Update rules.
2498         * m2-exp.y: Update rules.
2499         * language.h (struct language_defn) <la_post_parser>: Add
2500         "tracker" parameter.
2501         * go-exp.y: Update rules.
2502         * f-exp.y: Update rules.
2503         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2504         parameter.
2505         * d-exp.y: Update rules.
2506         * c-exp.y: Update rules.
2507         * breakpoint.c (set_breakpoint_condition): Create an
2508         innermost_block_tracker.
2509         (watch_command_1): Likewise.
2510         * ada-lang.c (resolve): Add "tracker" parameter.
2511         (resolve_subexp): Likewise.
2512         * ada-exp.y (write_var_from_sym): Update.
2513
2514 2019-04-04  Tom Tromey  <tom@tromey.com>
2515
2516         * type-stack.h: New file.
2517         * type-stack.c: New file.
2518         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2519         type-stack.h.
2520         (insert_into_type_stack, insert_type, push_type, push_type_int)
2521         (insert_type_address_space, pop_type, pop_type_int)
2522         (pop_typelist, pop_type_stack, append_type_stack)
2523         (push_type_stack, get_type_stack, push_typelist)
2524         (follow_type_instance_flags, follow_types): Don't declare.
2525         * parse.c (type_stack): Remove global.
2526         (parse_exp_in_context): Update.
2527         (insert_into_type_stack, insert_type, push_type, push_type_int)
2528         (insert_type_address_space, pop_type, pop_type_int)
2529         (pop_typelist, pop_type_stack, append_type_stack)
2530         (push_type_stack, get_type_stack, push_typelist)
2531         (follow_type_instance_flags, follow_types): Remove (moved to
2532         type-stack.c).
2533         * f-exp.y (type_stack): New global.
2534         Update rules.
2535         (push_kind_type, f_parse): Update.
2536         * d-exp.y (type_stack): New global.
2537         Update rules.
2538         (d_parse): Update.
2539         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2540         Update rules.
2541         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2542         (HFILES_NO_SRCDIR): Add type-stack.h.
2543
2544 2019-04-04  Tom Tromey  <tom@tromey.com>
2545
2546         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2547         (rust_parser::convert_ast_to_expression, rust_parse)
2548         (rust_lex_test_completion, rust_lex_tests): Update.
2549         * parser-defs.h (struct expr_completion_state): New.
2550         (struct parser_state) <parser_state>: Add completion parameter.
2551         <mark_struct_expression, mark_completion_tag>: New methods.
2552         <parse_completion, m_completion_state>: New members.
2553         (prefixify_expression, null_post_parser): Update.
2554         (mark_struct_expression, mark_completion_tag): Don't declare.
2555         * parse.c (parse_completion, expout_last_struct)
2556         (expout_tag_completion_type, expout_completion_name): Remove
2557         globals.
2558         (parser_state::mark_struct_expression)
2559         (parser_state::mark_completion_tag): Now methods.
2560         (prefixify_expression): Add last_struct parameter.
2561         (prefixify_subexp): Likewise.
2562         (parse_exp_1): Update.
2563         (parse_exp_in_context): Add cstate parameter.  Update.
2564         (parse_expression_for_completion): Create an
2565         expr_completion_state.
2566         (null_post_parser): Add "completion" parameter.
2567         * p-exp.y: Update rules.
2568         (yylex): Update.
2569         * language.h (struct language_defn) <la_post_parser>: Add
2570         "completing" parameter.
2571         * go-exp.y: Update rules.
2572         (lex_one_token): Update.
2573         * expression.h (parse_completion): Don't declare.
2574         * d-exp.y: Update rules.
2575         (lex_one_token): Update rules.
2576         * c-exp.y: Update rules.
2577         (lex_one_token): Update.
2578         * ada-lang.c (resolve): Add "parse_completion" parameter.
2579         (resolve_subexp): Likewise.
2580         (ada_resolve_function): Likewise.
2581
2582 2019-04-04  Tom Tromey  <tom@tromey.com>
2583
2584         * parser-defs.h (struct parser_state) <start_arglist,
2585         end_arglist>: New methods.
2586         <arglist_len, m_funcall_chain>: New members.
2587         (arglist_len, start_arglist, end_arglist): Don't declare.
2588         * parse.c (arglist_len, funcall_chain): Remove global.
2589         (start_arglist, end_arglist): Remove functions.
2590         (parse_exp_in_context): Update.
2591         * p-exp.y: Update rules.
2592         * m2-exp.y: Update rules.
2593         * go-exp.y: Update rules.
2594         * f-exp.y: Update rules.
2595         * d-exp.y: Update rules.
2596         * c-exp.y: Update rules.
2597
2598 2019-04-04  Tom Tromey  <tom@tromey.com>
2599
2600         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2601         lex_operator, push_back>: New methods.
2602         Update all rules.
2603         (rust_parser::lex_hex, lex_escape): Rename and update.
2604         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2605         (rust_parser::lex_operator): Rename and update.
2606         (rust_parser::lex_number, rustyylex, rustyyerror)
2607         (rust_lex_test_init, rust_lex_test_sequence)
2608         (rust_lex_test_push_back, rust_lex_tests): Update.
2609         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2610         parameter.
2611         <lexptr, prev_lexptr>: New members.
2612         (lexptr, prev_lexptr): Don't declare.
2613         * parse.c (lexptr, prev_lexptr): Remove globals.
2614         (parse_exp_in_context): Update.
2615         * p-exp.y (yylex, yyerror): Update.
2616         * m2-exp.y (parse_number, yylex, yyerror): Update.
2617         * go-exp.y (lex_one_token, yyerror): Update.
2618         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2619         * d-exp.y (lex_one_token, yyerror): Update.
2620         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2621         (lex_one_token, yyerror): Update.
2622         * ada-lex.l (YY_INPUT): Update.
2623         (rewind_to_char): Update.
2624         * ada-exp.y (yyerror): Update.
2625
2626 2019-04-04  Tom Tromey  <tom@tromey.com>
2627
2628         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2629         * parser-defs.h (struct parser_state) <parser_state>: Add new
2630         parameter.
2631         <comma_terminates>: New member.
2632         (comma_terminates): Don't declare global.
2633         * parse.c (comma_terminates): Remove global.
2634         (parse_exp_in_context): Update.
2635         * p-exp.y (yylex): Update.
2636         * m2-exp.y (yylex): Update.
2637         * go-exp.y (lex_one_token): Update.
2638         * f-exp.y (yylex): Update.
2639         * d-exp.y (lex_one_token): Update.
2640         * c-exp.y (lex_one_token): Update.
2641         * ada-lex.l: Update.
2642
2643 2019-04-04  Tom Tromey  <tom@tromey.com>
2644
2645         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2646         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2647         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2648         * parser-defs.h (paren_depth): Don't declare.
2649         * parse.c (paren_depth): Remove global.
2650         (parse_exp_in_context): Update.
2651         * p-exp.y (paren_depth): New global.
2652         (pascal_parse): Initialize it.
2653         * m2-exp.y (paren_depth): New global.
2654         (m2_parse): Initialize it.
2655         * go-exp.y (paren_depth): New global.
2656         (go_parse): Initialize it.
2657         * f-exp.y (paren_depth): New global.
2658         (f_parse): Initialize it.
2659         * d-exp.y (paren_depth): New global.
2660         (d_parse): Initialize it.
2661         * c-exp.y (paren_depth): New global.
2662         (c_parse): Initialize it.
2663         * ada-lex.l (paren_depth): New global.
2664         (lexer_init): Initialize it.
2665
2666 2019-04-04  Tom Tromey  <tom@tromey.com>
2667
2668         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2669         (rust_parser::convert_ast_to_type)
2670         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2671         * parser-defs.h (struct parser_state) <parser_state>: Add
2672         parameters.  Initialize new members.
2673         <expression_context_block, expression_context_pc>: New members.
2674         * parse.c (expression_context_block, expression_context_pc):
2675         Remove globals.
2676         (parse_exp_in_context): Update.
2677         * p-exp.y: Update all rules.
2678         (yylex): Update.
2679         * m2-exp.y: Update all rules.
2680         (yylex): Update.
2681         * go-exp.y (yylex): Update.
2682         * f-exp.y (yylex): Update.
2683         * d-exp.y: Update all rules.
2684         (yylex): Update.
2685         * c-exp.y: Update all rules.
2686         (lex_one_token, classify_name, yylex, c_parse): Update.
2687         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2688
2689 2019-04-04  Tom Tromey  <tom@tromey.com>
2690
2691         * gdbarch.h, gdbarch.c: Rebuild.
2692         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2693         * stap-probe.h:
2694         (struct stap_parse_info): Replace "parser_state" with
2695         "expr_builder".
2696         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2697         (parser_state): New class.
2698         * parse.c (expr_builder): Rename.
2699         (expr_builder::release): Rename.
2700         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2701         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2702         (write_exp_elt_longcst, write_exp_elt_floatcst)
2703         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2704         (write_exp_string_vector, write_exp_bitstring)
2705         (write_exp_msymbol, mark_struct_expression)
2706         (write_dollar_variable)
2707         (insert_type_address_space, increase_expout_size): Replace
2708         "parser_state" with "expr_builder".
2709         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2710         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2711         "parser_state" with "expr_builder".
2712
2713 2019-04-04  Tom Tromey  <tom@tromey.com>
2714
2715         * rust-exp.y: Replace "parse_language" with method call.
2716         * p-exp.y:
2717         (yylex): Replace "parse_language" with method call.
2718         * m2-exp.y:
2719         (yylex): Replace "parse_language" with method call.
2720         * go-exp.y (classify_name): Replace "parse_language" with method
2721         call.
2722         * f-exp.y (yylex): Replace "parse_language" with method call.
2723         * d-exp.y (lex_one_token): Replace "parse_language" with method
2724         call.
2725         * c-exp.y:
2726         (lex_one_token, classify_name, yylex): Replace "parse_language"
2727         with method call.
2728         * ada-exp.y (find_primitive_type, type_char)
2729         (type_system_address): Replace "parse_language" with method call.
2730
2731 2019-04-04  Tom Tromey  <tom@tromey.com>
2732
2733         * rust-exp.y: Replace "parse_gdbarch" with method call.
2734         * parse.c (write_dollar_variable, insert_type_address_space):
2735         Replace "parse_gdbarch" with method call.
2736         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2737         call.
2738         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2739         call.
2740         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2741         "parse_gdbarch" with method call.
2742         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2743         with method call.
2744         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2745         "parse_gdbarch" with method call.
2746         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2747         "parse_gdbarch" with method call.
2748         * c-exp.y (parse_type, parse_number, classify_name): Replace
2749         "parse_gdbarch" with method call.
2750         * ada-lex.l: Replace "parse_gdbarch" with method call.
2751         * ada-exp.y (parse_type, find_primitive_type, type_char)
2752         (type_system_address): Replace "parse_gdbarch" with method call.
2753
2754 2019-04-04  Tom Tromey  <tom@tromey.com>
2755
2756         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2757         * stap-probe.c (stap_parse_argument): Update.
2758         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2759         initial_size parameter.
2760         * rust-exp.y (rust_lex_tests): Update.
2761         * parse.c (parser_state): Update.
2762         (parse_exp_in_context): Update.
2763         * parser-defs.h (struct parser_state) <parser_state>: Remove
2764         "initial_size" parameter.
2765
2766 2019-04-04  Tom Tromey  <tom@tromey.com>
2767
2768         * parser-defs.h (increase_expout_size): Don't declare.
2769         * parse.c (increase_expout_size): Now static.
2770
2771 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2772
2773         * gnu-nat.c (gnu_nat_target::wait): Fix
2774         target_waitstatus_to_string call.
2775
2776 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2777
2778         * eval.c (evaluate_subexp_standard): Handle internal functions
2779         during Fortran function call handling.
2780
2781 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2782
2783         * NEWS: Mention new internal functions.
2784         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2785         (read_base_type): Use dwarf2_init_complex_target_type.
2786         * value.c (creal_internal_fn): New function.
2787         (cimag_internal_fn): New function.
2788         (_initialize_values): Register new internal functions.
2789
2790 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2791
2792         * infrun.c (stop_all_threads): If debug_infrun, always
2793         trace the wait status after wait_one, using
2794         target_waitstatus_to_string and target_pid_to_str.
2795         (handle_inferior_event): Replace various trace of
2796         wait status kind by a single trace.
2797         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2798         wait status kind image by target_waitstatus_to_string.
2799         * target/waitstatus.c (target_waitstatus_to_string): Fix
2800         obsolete comment.
2801
2802 2019-04-01  Tom Tromey  <tromey@adacore.com>
2803
2804         PR symtab/23331:
2805         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2806
2807 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2808             Pedro Alves  <palves@redhat.com>
2809
2810         * top.c (quit_force): Call 'finalize_values'.
2811         * value.c (finalize_values): New function.
2812         * value.h (finalize_values): Declare.
2813
2814 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2815
2816         * NEWS: Announce $_gdb_major and $_gdb_minor.
2817
2818         * top.c (init_gdb_version_vars): New function.
2819         (gdb_init): Call init_gdb_version_vars.
2820
2821 2019-03-29  Tom Tromey  <tromey@adacore.com>
2822
2823         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2824         help text.  Remove dead code.
2825
2826 2019-03-29  Keith Seitz  <keiths@redhat.com>
2827
2828         From Siddhesh Poyarekar:
2829         * f-lang.h (f77_get_upperbound): Return LONGEST.
2830         (f77_get_lowerbound): Likewise.
2831         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2832         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2833         print them.
2834         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2835         plongest to format print it.
2836         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2837         (f77_get_upperbound): Likewise.
2838         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2839         LOWER_BOUND to LONGEST.
2840         (f77_create_arrayprint_offset_tbl): Likewise.
2841
2842 2019-03-29  Keith Seitz  <keiths@redhat.com>
2843
2844         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2845         %s/pulongest for TYPE_LENGTH instead of %d in format
2846         strings.
2847         * ada-typerint.c (ada_print_type): Likewise.
2848         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2849         * compile/compile-c-support.c (generate_register_struct): Likewise.
2850         * gdbtypes.c (recursive_dump_type): Likewise.
2851         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2852         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2853         instead of %d in format strings.
2854         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2855         to std::min to ULONGEST.
2856         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2857         instead of %d in format strings.
2858         * tracepoint.c (info_scope_command): Likewise.
2859         * typeprint.c (print_offset_data::update)
2860         (print_offset_data::finish): Likewise.
2861         * xtensa-tdep.c (xtensa_store_return_value)
2862         (xtensa_push_dummy_call): Likewise.
2863
2864 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2865
2866         * windows-nat.c (display_selector): Fixed format specifications
2867         for 64-bit Cygwin.
2868
2869 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2870
2871         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2872
2873 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2874
2875         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2876         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2877         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2878         (nios2_linux_init_abi): Install it.
2879
2880 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2881
2882         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2883
2884 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2885
2886         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2887
2888 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2889             Tom Tromey  <tromey@adacore.com>
2890
2891         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2892
2893 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2894
2895         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2896         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2897         method to compute the bounds of range types. Also print "[evaluated]"
2898         if the bounds' values come from a dynamic evaluation.
2899
2900 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2901
2902         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2903         whitespace when pretty printing is on.
2904
2905 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2906
2907         * ppc-linux-nat.c: Add include.
2908
2909 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2910
2911         * NEWS: Mention AArch64 Pointer Authentication.
2912
2913 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2914
2915         * arm-linux-nat.c: Add include.
2916
2917 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2918
2919         * source-cache.c (source_cache::get_source_lines): Re-read
2920         fullname after calling open_source_file.
2921
2922 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2923
2924         * NEWS: Mention TLS support for FreeBSD.
2925
2926 2019-03-25  Tom Tromey  <tromey@adacore.com>
2927
2928         * minsyms.c (BUNCH_SIZE): Update comment.
2929         (~minimal_symbol_reader): Remove old comment.
2930         (compact_minimal_symbols): Update comment.
2931         (minimal_symbol_reader::install): Remove old comment.  Update
2932         other comments.
2933
2934 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2935
2936         * s390-linux-nat.c: Add include.
2937
2938 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2939
2940         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2941         Call linux_get_hwcap.
2942         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2943         Likewise.
2944         (aarch64_linux_get_hwcap): Remove function.
2945         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2946         declaration.
2947         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2948         linux_get_hwcap.
2949         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2950         * linux-tdep.c (linux_get_hwcap): Add function.
2951         (linux_get_hwcap2): Likewise.
2952         * linux-tdep.h (linux_get_hwcap): Add declaration.
2953         (linux_get_hwcap2): Likewise.
2954         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2955         (ppc_linux_get_hwcap2): Likewise.
2956         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2957         linux_get_hwcap.
2958         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2959         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2960         (ppc_linux_nat_target::read_description): Likewise.
2961         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2962         * s390-linux-nat.c: Likewise.
2963         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2964
2965 2019-03-24  Tom Tromey  <tom@tromey.com>
2966
2967         * ada-lang.c (standard_lookup): Simplify initialization.
2968         (ada_lookup_symbol_nonlocal): Simplify return.
2969         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2970         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2971         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2972         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2973         initialization.
2974         * solib.c (solib_global_lookup): Simplify.
2975         * symtab.c (null_block_symbol): Remove.
2976         (symbol_cache_lookup): Simplify returns.
2977         (lookup_language_this): Simplify returns.
2978         (lookup_symbol_aux): Simplify return.
2979         (lookup_local_symbol): Simplify returns.
2980         (lookup_global_symbol_from_objfile): Simplify return.
2981         (lookup_symbol_in_objfile_symtabs)
2982         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2983         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2984         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2985         * cp-namespace.c (cp_lookup_bare_symbol)
2986         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2987         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2988         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2989         (cp_lookup_symbol_via_imports): Simplify initialization.
2990         (find_symbol_in_baseclass): Likewise.
2991         * symtab.h (null_block_symbol): Remove.
2992         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2993         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2994         (d_lookup_symbol_module): Likewise.
2995         (find_symbol_in_baseclass): Simplify initialization.
2996
2997 2019-03-24  Tom Tromey  <tom@tromey.com>
2998
2999         * expression.h: Don't include symtab.h.
3000         (struct block): Forward declare.
3001
3002 2019-03-24  Tom Tromey  <tom@tromey.com>
3003
3004         * c-exp.y (typebase): Remove casts.
3005         * gdbtypes.c (lookup_unsigned_typename, )
3006         (lookup_signed_typename): Remove cast.
3007         * eval.c (parse_to_comma_and_eval): Remove cast.
3008         * parse.c (write_dollar_variable): Remove cast.
3009         * block.h (struct block) <superblock>: Now const.
3010         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3011         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3012         (map_block): Make "block" const.
3013         * symfile.h (struct quick_symbol_functions)
3014         <map_matching_symbols>: Constify block argument to "callback".
3015         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3016         const.
3017         (find_pc_sect_compunit_symtab): Make "b" const.
3018         (find_symbol_at_address): Likewise.
3019         (search_symbols): Likewise.
3020         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3021         (dw2_debug_names_lookup_symbol): Likewise.
3022         (dw2_map_matching_symbols): Update.
3023         * p-valprint.c (pascal_val_print): Remove "block".
3024         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3025         (aux_add_nonlocal_symbols): Make "block" const.
3026         (resolve_subexp): Remove cast.
3027         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3028         const.
3029         (iterate_over_file_blocks): Likewise.
3030         * f-exp.y (%union) <bval>: Remove.
3031         * coffread.c (patch_opaque_types): Make "b" const.
3032         * spu-tdep.c (spu_catch_start): Make "block" const.
3033         * c-valprint.c (print_unpacked_pointer): Remove "block".
3034         * symmisc.c (dump_symtab_1): Make "b" const.
3035         (block_depth): Make "block" const.
3036         * d-exp.y (%union) <bval>: Remove.
3037         * cp-support.h (cp_lookup_rtti_type): Update.
3038         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3039         * psymtab.c (psym_lookup_symbol): Make "block" const.
3040         (maintenance_check_psymtabs): Make "b" const.
3041         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3042         (enumerate_locals, enumerate_args): Update.
3043         * python/py-symtab.c (stpy_global_block): Make "block" const.
3044         (stpy_static_block): Likewise.
3045         * inline-frame.c (block_starting_point_at): Make "new_block"
3046         const.
3047         * block.c (find_block_in_blockvector): Make return type const.
3048         (blockvector_for_pc_sect): Make "b" const.
3049         (find_block_in_blockvector): Make "b" const.
3050
3051 2019-03-23  Tom Tromey  <tom@tromey.com>
3052
3053         * varobj.c (varobj_create): Update.
3054         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3055         * printcmd.c (display_command, do_one_display): Don't reset
3056         innermost_block.
3057         * parser-defs.h (enum innermost_block_tracker_type): Move to
3058         expression.h.
3059         (innermost_block): Update comment.
3060         * parse.c (parse_exp_1): Add tracker_types parameter.
3061         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3062         tracker_types parameter.  Reset innermost_block.
3063         (parse_exp_in_context): Remove.
3064         (parse_expression_for_completion): Update.
3065         * objfiles.c (~objfile): Don't reset expression_context_block or
3066         innermost_block.
3067         * expression.h (enum innermost_block_tracker_type): Move from
3068         parser-defs.h.
3069         (parse_exp_1): Add tracker_types parameter.
3070         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3071         reset innermost_block.
3072
3073 2019-03-23  Tom Tromey  <tom@tromey.com>
3074
3075         * objfiles.h: Include bcache.h.
3076
3077 2019-03-23  Tom Tromey  <tom@tromey.com>
3078
3079         * linespec.c (get_current_search_block): Use
3080         scoped_restore_current_language.
3081         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3082
3083 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3084             Jiong Wang  <jiong.wang@arm.com>
3085
3086         * aarch64-linux-tdep.c
3087         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3088         section.
3089         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3090
3091 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3092             Jiong Wang  <jiong.wang@arm.com>
3093
3094         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3095         instructions.
3096         (aarch64_analyze_prologue_test): Add PACIASP test.
3097         (aarch64_prologue_prev_register): Unmask PC value.
3098
3099 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3100             Jiong Wang  <jiong.wang@arm.com>
3101
3102         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3103         (aarch64_dwarf2_prev_register): Unmask PC value.
3104         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3105         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3106         DW_CFA_AARCH64_negate_ra_state.
3107         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3108
3109 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3110             Jiong Wang  <jiong.wang@arm.com>
3111
3112         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3113         registers.
3114         (aarch64_pseudo_register_name): Likewise.
3115         (aarch64_pseudo_register_type): Likewise.
3116         (aarch64_pseudo_register_reggroup_p): Likewise.
3117         (aarch64_gdbarch_init): Add pauth registers.
3118         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3119         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3120         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3121         (struct gdbarch_tdep): Add regnum for ra_state.
3122
3123 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3124             Jiong Wang  <jiong.wang@arm.com>
3125
3126         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3127
3128 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3129             Jiong Wang  <jiong.wang@arm.com>
3130
3131         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3132         function.
3133         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3134         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3135         (aarch64_gdbarch_init): Add puth registers.
3136         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3137         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3138         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3139
3140 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3141             Jiong Wang  <jiong.wang@arm.com>
3142
3143         * aarch64-linux-nat.c
3144         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3145         * aarch64-linux-tdep.c
3146         (aarch64_linux_core_read_description): Likewise.
3147         (aarch64_linux_get_hwcap): New function.
3148         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3149         (aarch64_linux_get_hwcap): New declaration.
3150
3151 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3152             Jiong Wang  <jiong.wang@arm.com>
3153
3154         * aarch64-linux-nat.c
3155         (aarch64_linux_nat_target::read_description): Add pauth param.
3156         * aarch64-linux-tdep.c
3157         (aarch64_linux_core_read_description): Likewise.
3158         * aarch64-tdep.c (struct target_desc): Add in pauth.
3159         (aarch64_read_description): Add pauth param.
3160         (aarch64_gdbarch_init): Likewise.
3161         * aarch64-tdep.h (aarch64_read_description): Likewise.
3162         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3163         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3164         * features/Makefile: Add new files.
3165         * features/aarch64-pauth.c: New file.
3166         * features/aarch64-pauth.xml: New file.
3167
3168 2019-03-20  Tom Tromey  <tromey@adacore.com>
3169
3170         * infrun.c (handle_inferior_event): Rename from
3171         handle_inferior_event_1.  Create a scoped_value_mark.
3172         (handle_inferior_event): Remove.
3173
3174 2019-03-19  Tom Tromey  <tromey@adacore.com>
3175
3176         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3177         * infrun.h (print_stop_event): Add "displays" parameter.
3178         * infrun.c (print_stop_event): Add "displays" parameter.
3179
3180 2019-03-19  Pedro Alves  <palves@redhat.com>
3181
3182         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3183         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3184         to -1.  Fix TABs vs spaces.
3185         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3186         * tui/tui-out.h (tui_ui_out) Add intro comments.
3187         <m_line, m_start_of_line>: In-class initialize, and add describing
3188         comment.
3189
3190 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3191
3192         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3193         variable names.
3194         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3195
3196 2019-03-18  Pedro Alves  <palves@redhat.com>
3197             Eli Zaretskii <eliz@gnu.org>
3198
3199         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3200         m_line and m_start_of_line.
3201
3202 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3203
3204         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3205         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3206         it returns a newline.  This fixes a regression in TU mode, whereby
3207         the next line is output on the same screen line as the user input.
3208
3209 2019-03-18  Tom Tromey  <tromey@adacore.com>
3210
3211         * minsyms.c (minimal_symbol_reader::install): Remove call to
3212         obstack_blank.
3213
3214 2019-03-18  Pedro Alves  <palves@redhat.com>
3215
3216         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3217         New globals.
3218         (apply_style): New, factored out from ...
3219         (apply_ansi_escape): ... this.  Handle reverse video mode.
3220         (tui_set_reverse_mode): New function.
3221         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3222         * tui/tui-winsource.c (tui_show_source_line): Use
3223         tui_set_reverse_mode instead of setting A_STANDOUT.
3224         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3225         New setter methods.
3226
3227 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3228
3229         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3230         Handle tabs.
3231
3232 2019-03-18  Tom Tromey  <tromey@adacore.com>
3233
3234         * ada-lang.c (empty_array): Add "high" parameter.
3235         (ada_evaluate_subexp): Update.
3236
3237 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3238
3239         * unittests/string_view-selftests.c: Define
3240         _initialize_string_view_selftests unconditionally.
3241
3242 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3243
3244         PR gdb/24350
3245         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3246
3247 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3248
3249         PR gdb/24351
3250         * windows-nat.c (display_selector): Fix format specifiers.
3251
3252 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3253
3254         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3255         tui_refill_source_window instead of tui_refresh_win, to update the
3256         current execution line.  This fixes redisplay of the current line
3257         when stepping through the code with "next" or "step".
3258
3259 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3260
3261         * source-cache.c (source_cache::get_source_lines): Call
3262         find_source_lines to initialize s->nlines.  This fixes vertical
3263         scrolling of TUI source window when the DOWN arrow is pressed.
3264
3265 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3266
3267         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3268         linux-thread-db.c (_initialize_thread_db): Likewise.
3269
3270 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3271
3272         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3273         wclrtoeol in tui_show_source_line".  This reverts changes made in
3274         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3275
3276 2019-03-15  Tom Tromey  <tom@tromey.com>
3277
3278         * symtab.h (struct minimal_symbol): Derive from
3279         general_symbol_info.
3280         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3281         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3282         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3283         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3284         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3285         (MSYMBOL_SEARCH_NAME): Update.
3286         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3287         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3288         * minsyms.c (minimal_symbol_reader::record_full): Update.
3289
3290 2019-03-15  Tom Tromey  <tom@tromey.com>
3291
3292         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3293
3294 2019-03-15  Tom Tromey  <tom@tromey.com>
3295
3296         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3297         unique_xmalloc_ptr.
3298         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3299         Update.
3300         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3301         (build_minimal_symbol_hash_tables)
3302         (minimal_symbol_reader::install): Update.
3303
3304 2019-03-15  Tom Tromey  <tom@tromey.com>
3305
3306         * symtab.c (create_demangled_names_hash): Update.
3307         (symbol_set_names): Update.
3308         * objfiles.h (struct objfile_per_bfd_storage)
3309         <demangled_names_hash>: Now an htab_up.
3310         * objfiles.c (objfile_per_bfd_storage): Simplify.
3311
3312 2019-03-15  Tom Tromey  <tom@tromey.com>
3313
3314         * objfiles.h (struct objfile_per_bfd_storage): Declare
3315         destructor.
3316         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3317         New.
3318         (get_objfile_bfd_data): Use new.  Don't initialize
3319         language_of_main.
3320         (free_objfile_per_bfd_storage): Remove.
3321         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3322
3323 2019-03-15  Tom Tromey  <tom@tromey.com>
3324
3325         * symfile.c (reread_symbols): Update.
3326         * objfiles.c (objfile::objfile): Update.
3327         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3328         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3329         comment.
3330         (minimal_symbol_reader::install): Update.
3331         (terminate_minimal_symbol_table): Remove.
3332         * jit.c (jit_object_close_impl): Update.
3333
3334 2019-03-15  Tom Tromey  <tom@tromey.com>
3335
3336         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3337         initializations.
3338
3339 2019-03-15  Tom Tromey  <tom@tromey.com>
3340
3341         * objfiles.h (struct objfile_per_bfd_storage)
3342         <demangled_hash_languages>: Now a bitset.
3343         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3344         (lookup_minimal_symbol): Update.
3345
3346 2019-03-15  Tom Tromey  <tom@tromey.com>
3347
3348         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3349         Don't return the symbol.
3350         * coffread.c (record_minimal_symbol): Use record_full.
3351
3352 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3353
3354         The MS-Windows port of ncurses fails to switch to a color pair if
3355         one or both of the colors are the implicit default colors.  This
3356         change records the default colors when TUI is initialized, and
3357         then specifies them explicitly when a color pair uses the default
3358         colors.  This allows color styling in TUI mode on MS-Windows.
3359
3360         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3361         ncurses_norm_attr.
3362         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3363         colors in ncurses_norm_attr.
3364         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3365         "none", replace it with the default color recorded in
3366         ncurses_norm_attr.
3367
3368 2019-03-14  Tom Tromey  <tromey@adacore.com>
3369
3370         * source-cache.h (class source_cache) <get_source_lines>: Return
3371         std::string.
3372         * source-cache.c (source_cache::extract_lines): Handle case where
3373         first_pos==npos.  Return std::string.
3374         (source_cache::get_source_lines): Update.
3375
3376 2019-03-14  Tom Tromey  <tromey@adacore.com>
3377
3378         * NEWS: Add item for "style sources" commands.
3379         * source-cache.c (source_cache::get_source_lines): Check
3380         source_styling.
3381         * cli/cli-style.c (source_styling): New global.
3382         (_initialize_cli_style): Add "style sources" commands.
3383         (show_style_sources): New function.
3384         * cli/cli-style.h (source_styling): Declare.
3385
3386 2019-03-14  Pedro Alves  <palves@redhat.com>
3387             Tom Tromey  <tromey@adacore.com>
3388
3389         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3390         * tui/tui-winsource.c (tui_refill_source_window): New function,
3391         from...
3392         (tui_horizontal_source_scroll): ... here.  Move some logic.
3393         * cli/cli-style.c (set_style_enabled): Notify new observable.
3394         * tui/tui-hooks.c (tui_redisplay_source): New function.
3395         (tui_attach_detach_observers): Attach or detach
3396         tui_redisplay_source.
3397         * observable.h (source_styling_changed): New observable.
3398         * observable.c: Define source_styling_changed observable.
3399
3400 2019-03-13  Tom Tromey  <tromey@adacore.com>
3401
3402         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3403         (i386_gnu_nat_target::store_registers): Update.
3404         * target-debug.h (target_debug_print_std_string): New macro.
3405         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3406         * windows-tdep.c (display_one_tib): Update.
3407         * tui/tui-stack.c (tui_make_status_line): Update.
3408         * top.c (print_inferior_quit_action): Update.
3409         * thread.c (thr_try_catch_cmd): Update.
3410         (add_thread_with_info): Update.
3411         (thread_target_id_str): Update.
3412         (thr_try_catch_cmd): Update.
3413         (thread_command): Update.
3414         (thread_find_command): Update.
3415         * record-btrace.c (record_btrace_target::info_record)
3416         (record_btrace_resume_thread, record_btrace_target::resume)
3417         (record_btrace_cancel_resume, record_btrace_step_thread)
3418         (record_btrace_target::wait, record_btrace_target::wait)
3419         (record_btrace_target::wait, record_btrace_target::stop): Update.
3420         * progspace.c (print_program_space): Update.
3421         * process-stratum-target.c
3422         (process_stratum_target::thread_address_space): Update.
3423         * linux-fork.c (linux_fork_mourn_inferior)
3424         (detach_checkpoint_command, info_checkpoints_command)
3425         (linux_fork_context): Update.
3426         (linux_fork_detach): Update.
3427         (class scoped_switch_fork_info): Update.
3428         (delete_checkpoint_command): Update.
3429         * infrun.c (follow_fork_inferior): Update.
3430         (follow_fork_inferior): Update.
3431         (proceed_after_vfork_done): Update.
3432         (handle_vfork_child_exec_or_exit): Update.
3433         (follow_exec): Update.
3434         (displaced_step_prepare_throw): Update.
3435         (displaced_step_restore): Update.
3436         (start_step_over): Update.
3437         (resume_1): Update.
3438         (clear_proceed_status_thread): Update.
3439         (proceed): Update.
3440         (print_target_wait_results): Update.
3441         (do_target_wait): Update.
3442         (context_switch): Update.
3443         (stop_all_threads): Update.
3444         (restart_threads): Update.
3445         (finish_step_over): Update.
3446         (handle_signal_stop): Update.
3447         (switch_back_to_stepped_thread): Update.
3448         (keep_going_pass_signal): Update.
3449         (print_exited_reason): Update.
3450         (normal_stop): Update.
3451         * inferior.c (inferior_pid_to_str): Change return type.
3452         (print_selected_inferior): Update.
3453         (add_inferior): Update.
3454         (detach_inferior): Update.
3455         * dummy-frame.c (fprint_dummy_frames): Update.
3456         * dcache.c (dcache_info_1): Update.
3457         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3458         (btrace_fetch, btrace_clear): Update.
3459         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3460         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3461         type.
3462         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3463         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3464         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3465         * gdbarch.c, gdbarch.h: Rebuild.
3466         * gdbarch.sh (core_pid_to_str): Change return type.
3467         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3468         return type.
3469         (windows_nat_target::pid_to_str): Change return type.
3470         (windows_delete_thread): Update.
3471         (windows_nat_target::attach): Update.
3472         (windows_nat_target::files_info): Update.
3473         * target-delegates.c: Rebuild.
3474         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3475         return type.
3476         (sol_thread_target::pid_to_str): Change return type.
3477         * remote.c (class remote_target) <pid_to_str>: Change return
3478         type.
3479         (remote_target::pid_to_str): Change return type.
3480         (extended_remote_target::attach, remote_target::remote_stop_ns)
3481         (remote_target::remote_notif_remove_queued_reply)
3482         (remote_target::push_stop_reply, remote_target::disable_btrace):
3483         Update.
3484         (extended_remote_target::attach): Update.
3485         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3486         type.
3487         (gdbsim_target::pid_to_str): Change return type.
3488         * ravenscar-thread.c (struct ravenscar_thread_target)
3489         <pid_to_str>: Change return type.
3490         (ravenscar_thread_target::pid_to_str): Change return type.
3491         * procfs.c (class procfs_target) <pid_to_str>: Change return
3492         type.
3493         (procfs_target::pid_to_str): Change return type.
3494         (procfs_target::attach): Update.
3495         (procfs_target::detach): Update.
3496         (procfs_target::fetch_registers): Update.
3497         (procfs_target::store_registers): Update.
3498         (procfs_target::wait): Update.
3499         (procfs_target::files_info): Update.
3500         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3501         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3502         return type.
3503         (nto_procfs_target::pid_to_str): Change return type.
3504         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3505         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3506         return type.
3507         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3508         (exit_lwp): Update.
3509         (attach_proc_task_lwp_callback, get_detach_signal)
3510         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3511         (linux_nat_target::resume, wait_lwp, stop_callback)
3512         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3513         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3514         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3515         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3516         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3517         type.
3518         (inf_ptrace_target::attach): Update.
3519         (inf_ptrace_target::files_info): Update.
3520         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3521         type.
3522         (go32_nat_target::pid_to_str): Change return type.
3523         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3524         (gnu_nat_target::wait): Update.
3525         (gnu_nat_target::wait): Update.
3526         (gnu_nat_target::resume): Update.
3527         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3528         (fbsd_nat_target::wait): Update.
3529         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3530         type.
3531         (darwin_nat_target::attach): Update.
3532         * corelow.c (class core_target) <pid_to_str>: Change return type.
3533         (core_target::pid_to_str): Change return type.
3534         * target.c (normal_pid_to_str): Change return type.
3535         (default_pid_to_str): Likewise.
3536         (target_pid_to_str): Change return type.
3537         (target_translate_tls_address): Update.
3538         (target_announce_detach): Update.
3539         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3540         return type.
3541         (bsd_uthread_target::pid_to_str): Change return type.
3542         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3543         type.
3544         (bsd_kvm_target::pid_to_str): Change return type.
3545         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3546         return type.
3547         (aix_thread_target::pid_to_str): Change return type.
3548         * target.h (struct target_ops) <pid_to_str>: Change return type.
3549         (target_pid_to_str, normal_pid_to_str): Likewise.
3550         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3551         type.
3552         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3553         type.
3554         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3555         return type.
3556         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3557         type.
3558         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3559         type.
3560         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3561         return type.
3562
3563 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3564
3565         * NEWS: Mention that the new default MI version is 3.  Mention
3566         changes to the output of commands and events that deal with
3567         multi-location breakpoints.
3568         * breakpoint.c: Include "mi/mi-out.h".
3569         (print_one_breakpoint): Change output syntax if using MI version
3570         >= 3.
3571         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3572         New.
3573         (mi_multi_location_breakpoint_output_fixed): New.
3574         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3575         (mi_cmd_fix_multi_location_breakpoint_output): New.
3576         (mi_multi_location_breakpoint_output_fixed): New.
3577         * mi/mi-cmds.c (mi_cmds): Register command
3578         -fix-multi-location-breakpoint-output.
3579         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3580         interpreter "mi".
3581
3582 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3583
3584         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3585         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3586         instantiate mi_ui_out based on interpreter name.
3587         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3588         * mi/mi-main.c (mi_load_progress): Likewise.
3589
3590 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3591
3592         * NEWS: Combine separate "New targets" sections for 8.3.
3593
3594 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3595
3596         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3597         (ppcfbsd_init_abi): Install gdbarch
3598         "fetch_tls_load_module_address" and "get_thread_local_address"
3599         methods.
3600
3601 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3602
3603         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3604         (riscv_fbsd_init_abi): Install gdbarch
3605         "fetch_tls_load_module_address" and "get_thread_local_address"
3606         methods.
3607
3608 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3609
3610         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3611         (i386fbsd_init_abi): Install gdbarch
3612         "fetch_tls_load_module_address" and "get_thread_local_address"
3613         methods.
3614
3615 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3616
3617         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3618         (amd64fbsd_init_abi): Install gdbarch
3619         "fetch_tls_load_module_address" and "get_thread_local_address"
3620         methods.
3621
3622 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3623
3624         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3625         (struct fbsd_pspace_data): New type.
3626         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3627         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3628         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3629         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3630         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3631
3632 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3633
3634         * gdbtypes.c (lookup_struct_elt): New function.
3635         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3636         * gdbtypes.h (struct struct_elt): New type.
3637         (lookup_struct_elt): New prototype.
3638
3639 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3640
3641         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3642         remove disabled code block.
3643
3644 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3645
3646         * gdbarch.sh (get_thread_local_address): New method.
3647         * gdbarch.h, gdbarch.c: Regenerate.
3648         * target.c (target_translate_tls_address): Use
3649         gdbarch_get_thread_local_address if present instead of
3650         target::get_thread_local_address.
3651
3652 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3653
3654         * target.h (target::get_thread_local_address): Update comment.
3655
3656 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3657
3658         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3659         objfile->separate_debug_objfile_backlink if not NULL.
3660
3661 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3662
3663         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3664         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3665         (amd64bsd_store_inferior_registers): Likewise.
3666         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3667         Enable segment base registers.
3668         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3669         PT_GETFSBASE and PT_GETGSBASE.
3670         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3671         PT_SETGSBASE.
3672         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3673         segment base registers.
3674         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3675
3676 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3677
3678         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3679         Update calls to i386_target_description to add 'segments'
3680         parameter.
3681         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3682         add segment base registers.
3683         * arch/i386.c (i386_create_target_description): Add 'segments'
3684         parameter to enable segment base registers.
3685         * arch/i386.h (i386_create_target_description): Likewise.
3686         * features/i386/32bit-segments.xml: New file.
3687         * features/i386/32bit-segments.c: Generate.
3688         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3689         call to i386_target_description to add 'segments' parameter.
3690         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3691         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3692         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3693         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3694         if feature is present.
3695         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3696         Add 'segments' parameter to call to i386_target_description.
3697         (i386_target_description): Add 'segments' parameter to enable
3698         segment base registers.
3699         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3700         to call to i386_target_description.
3701         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3702         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3703         Define I386_NUM_REGS.
3704         (i386_target_description): Add 'segments' parameter to enable
3705         segment base registers.
3706
3707 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3708
3709         PR/24325
3710         * source-cache.c: #undef open and close, to avoid unresolved
3711         externals during linking.
3712
3713 2019-03-12  Tom Tromey  <tromey@adacore.com>
3714
3715         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3716         const.  Add initializers.
3717         (_initialize_remote): Don't initialize ptid globals.
3718
3719 2019-03-12  Pedro Alves  <palves@redhat.com>
3720
3721         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3722
3723 2019-03-12  Pedro Alves  <palves@redhat.com>
3724
3725         * cp-name-parser.y (main): Remove unused 'len' variable.
3726
3727 2019-03-12  Tom Tromey  <tromey@adacore.com>
3728
3729         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3730         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3731
3732 2019-03-12  Tom Tromey  <tromey@adacore.com>
3733
3734         * linux-nat.c (iterate_over_lwps): Update.
3735         (stop_callback): Remove parameter.
3736         (stop_wait_callback, detach_callback, resume_set_callback)
3737         (select_singlestep_lwp_callback, set_ignore_sigint)
3738         (status_callback, resumed_callback, resume_clear_callback)
3739         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3740         data parameter.
3741         (linux_nat_target::detach, linux_nat_target::resume)
3742         (linux_stop_and_wait_all_lwps, select_event_lwp)
3743         (linux_nat_filter_event, linux_nat_wait_1)
3744         (linux_nat_target::kill, linux_nat_target::stop)
3745         (linux_nat_target::stop): Update.
3746         (linux_nat_resume_callback): Change type.
3747         (resume_stopped_resumed_lwps, count_events_callback)
3748         (select_event_lwp_callback): Likewise.
3749         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3750         * arm-linux-nat.c (struct update_registers_data): Remove.
3751         (update_registers_callback): Change type.
3752         (arm_linux_insert_hw_breakpoint1): Update.
3753         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3754         parameter.
3755         (x86_linux_dr_set_addr): Update.
3756         (x86_linux_dr_set_control): Update.
3757         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3758         (iterate_over_lwps): Use gdb::function_view.
3759         * nat/aarch64-linux-hw-point.c (struct
3760         aarch64_dr_update_callback_param): Remove.
3761         (debug_reg_change_callback): Change type.
3762         (aarch64_notify_debug_reg_change): Update.
3763         * s390-linux-nat.c (s390_refresh_per_info): Update.
3764
3765 2019-03-11  Tom Tromey  <tromey@adacore.com>
3766
3767         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3768         redundant assignment to "this_cu".
3769
3770 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3771
3772         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3773
3774 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3775
3776         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3777         from...
3778         (rank_one_type): ... this.
3779
3780 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3781
3782         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3783         from...
3784         (rank_one_type): ... this.
3785
3786 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3787
3788         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3789         from...
3790         (rank_one_type): ... this.
3791
3792 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3793
3794         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3795         from...
3796         (rank_one_type): ... this.
3797
3798 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3799
3800         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3801         from...
3802         (rank_one_type): ... this.
3803
3804 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3805
3806         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3807         from...
3808         (rank_one_type): ... this.
3809
3810 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3811
3812         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3813         from...
3814         (rank_one_type): ... this.
3815
3816 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3817
3818         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3819         from...
3820         (rank_one_type): ... this.
3821
3822 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3823
3824         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3825         from...
3826         (rank_one_type): ... this.
3827
3828 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3829
3830         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3831         from...
3832         (rank_one_type): ... this.
3833
3834 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3835
3836         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3837         from...
3838         (rank_one_type): ... this.
3839
3840 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3841
3842         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3843         from...
3844         (rank_one_type): ... this.
3845
3846 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3847
3848         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3849         inferior-events' shows the example events.
3850
3851 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3852
3853         Support styling on native MS-Windows console
3854
3855         PR/24315
3856         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3857         on MS-Windows if $TERM is not defined.
3858
3859         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3860
3861         * posix-hdep.c (gdb_console_fputs):
3862         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3863         functions.
3864         * ui-file.h (gdb_console_fputs): Add prototype.
3865
3866         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3867         back to fputs only if the former returns zero.
3868
3869 2019-03-07  Tom Tromey  <tom@tromey.com>
3870
3871         * symmisc.c (print_symbol_bcache_statistics): Update.
3872         (print_objfile_statistics): Update.
3873         * symfile.c (allocate_symtab): Update.
3874         * stabsread.c: Don't include bcache.h.
3875         * psymtab.h (struct psymbol_bcache): Don't declare.
3876         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3877         (psymbol_bcache_init, psymbol_bcache_free)
3878         (psymbol_bcache_get_bcache): Don't declare.
3879         * psymtab.c (struct psymbol_bcache): Remove.
3880         (psymtab_storage::psymtab_storage): Update.
3881         (psymtab_storage::~psymtab_storage): Update.
3882         (psymbol_bcache_init, psymbol_bcache_free)
3883         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3884         (add_psymbol_to_bcache): Update.
3885         (allocate_psymtab): Update.
3886         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3887         macro_cache>: No longer pointers.
3888         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3889         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3890         * macrotab.c (macro_bcache): Update.
3891         * macroexp.c: Don't include bcache.h.
3892         * gdbtypes.c (check_types_worklist): Update.
3893         (types_deeply_equal): Remove TRY/CATCH.  Update.
3894         * elfread.c (elf_symtab_read): Update.
3895         * dwarf2read.c: Don't include bcache.h.
3896         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3897         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3898         (print_bcache_statistics, bcache_memory_used): Don't declare.
3899         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3900         methods.  Rename all data members.
3901         * bcache.c (struct bcache): Move to bcache.h.
3902         (bcache::expand_hash_table): Rename from expand_hash_table.
3903         (bcache): Remove.
3904         (bcache::insert): Rename from bcache_full.
3905         (bcache::compare): Rename from bcache_compare.
3906         (bcache_xmalloc): Remove.
3907         (bcache::~bcache): Rename from bcache_xfree.
3908         (bcache::print_statistics): Rename from print_bcache_statistics.
3909         (bcache::memory_used): Rename from bcache_memory_used.
3910
3911 2019-03-07  Pedro Alves  <palves@redhat.com>
3912
3913         * infrun.c (normal_stop): Also check for
3914         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3915
3916 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3917
3918         * f-lang.c (value_from_host_double): Moved to...
3919         * value.c (value_from_host_double): ...here.
3920         * value.h (value_from_host_double): Declare.
3921         * guile/scm-math.c (vlscm_convert_typed_number): Use
3922         value_from_host_double.
3923         (vlscm_convert_number): Likewise.
3924         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3925         * python/py-value.c (convert_value_from_python): Likewise.
3926
3927 2019-03-06  Tom Tromey  <tom@tromey.com>
3928
3929         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3930
3931 2019-03-06  Tom Tromey  <tom@tromey.com>
3932
3933         * utils.h (free_current_contents): Don't declare.
3934         * utils.c (free_current_contents): Remove.
3935
3936 2019-03-06  Tom Tromey  <tom@tromey.com>
3937
3938         * top.c (quit_force): Update.
3939         * main.c (captured_command_loop): Update.
3940         * common/new-op.c (operator new): Update.
3941         * common/common-exceptions.c (struct catcher)
3942         <save_cleanup_chain>: Remove member.
3943         (exceptions_state_mc_init): Update.
3944         (exception_try_scope_entry): Return nullptr.
3945         (exception_try_scope_exit, exception_rethrow)
3946         (throw_exception_sjlj, throw_exception_cxx): Update.
3947         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3948         (all_cleanups, do_cleanups, discard_cleanups)
3949         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3950         (restore_cleanups, restore_final_cleanups): Don't declare.
3951         (do_final_cleanups): Remove parameter.
3952         * common/cleanups.c (cleanup_chain, make_cleanup)
3953         (make_cleanup_dtor, all_cleanups, do_cleanups)
3954         (discard_my_cleanups, discard_cleanups)
3955         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3956         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3957         (null_cleanup): Remove.
3958         (do_final_cleanups): Remove parameter.
3959
3960 2019-03-06  Tom Tromey  <tom@tromey.com>
3961
3962         * remote.c (remote_target::remote_parse_stop_reply): Use
3963         unique_xmalloc_ptr.
3964
3965 2019-03-06  Tom Tromey  <tom@tromey.com>
3966
3967         * stabsread.c (struct stabs_field_info): Rename from field_info.
3968         <list, fnlist>: Add initializers.
3969         <obstack>: New member.
3970         (read_member_functions, read_struct_fields, read_baseclasses):
3971         Allocate on obstack.  Don't use cleanups.
3972         (read_one_struct_field, read_member_functions, read_struct_fields)
3973         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3974         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3975         (read_struct_type): Update.
3976
3977 2019-03-06  Tom Tromey  <tom@tromey.com>
3978
3979         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3980         * common/filestuff.h (make_cleanup_close): Don't declare.
3981         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3982         Remove.
3983
3984 2019-03-06  Tom Tromey  <tom@tromey.com>
3985
3986         * solib-aix.c: Use make_scope_exit.
3987
3988 2019-03-06  Tom Tromey  <tom@tromey.com>
3989
3990         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3991         Use make_scope_exit.
3992
3993 2019-03-06  Tom Tromey  <tom@tromey.com>
3994
3995         * solib-svr4.c (disable_probes_interface): Remove parameter.
3996         (svr4_handle_solib_event): Use make_scope_exit.
3997
3998 2019-03-06  Tom Tromey  <tom@tromey.com>
3999
4000         * remote.c (struct stop_reply_deleter): Remove.
4001         (stop_reply_up): Update.
4002         (struct stop_reply): Derive from notif_event.  Don't typedef.
4003         <regcache>: Now a std::vector.
4004         (stop_reply_xfree): Remove.
4005         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4006         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4007         (remote_target::discard_pending_stop_replies): Use delete.
4008         (remote_target::remote_parse_stop_reply): Update.
4009         (remote_target::process_stop_reply): Update.
4010         * remote-notif.h (struct notif_event): Add virtual destructor.
4011         Remove "dtr" member.
4012         (struct notif_client) <alloc_event>: Return a unique_ptr.
4013         (notif_event_xfree): Don't declare.
4014         (notif_event_up): New typedef.
4015         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4016         (notif_event_xfree, do_notif_event_xfree): Remove.
4017         (remote_notif_state_xfree): Update.
4018
4019 2019-03-06  Tom Tromey  <tom@tromey.com>
4020
4021         * infrun.c (displaced_step_clear_cleanup): Now a
4022         forward_scope_exit type.
4023         (displaced_step_prepare_throw): Update.
4024         (displaced_step_fixup): Update.
4025
4026 2019-03-06  Tom Tromey  <tom@tromey.com>
4027
4028         * inferior.h (class inferior): Update comment.
4029         * gdbthread.h (class thread_info): Update comment.
4030
4031 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4032             Tom Tromey  <tom@tromey.com>
4033
4034         * stabsread.h (struct stab_section_list): Remove.
4035         (coffstab_build_psymtabs): Update.
4036         * dbxread.c (symbuf_sections): Now a std::vector.
4037         (sect_idx): New global.
4038         (fill_symbuf): Update.
4039         (coffstab_build_psymtabs): Change type of stabsects parameter.
4040         Update.
4041         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4042         std::vector.
4043         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4044         (coff_locate_sections): Update.
4045         (coff_symfile_read): Remove cleanups.  Update.
4046         (init_stringtab): Add storage parameter.
4047         (free_stringtab, free_stringtab_cleanup): Remove.
4048         (init_lineno): Add storage parameter.
4049         (free_linetab, free_linetab_cleanup): Remove.
4050
4051 2019-03-06  Pedro Alves  <palves@redhat.com>
4052
4053         * linux-fork.c (fork_info::clobber_regs): Delete.
4054         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4055         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4056         comment.  Adjust.
4057         (scoped_switch_fork_info::scoped_switch_fork_info)
4058         (checkpoint_command, linux_fork_context): Adjust
4059         fork_save_infrun_state calls.
4060
4061 2019-03-06  Pedro Alves  <palves@redhat.com>
4062
4063         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4064         (inf_has_multiple_threads): Return 'bool' and rewrite using
4065         inferior_info::threads().
4066
4067 2019-03-06  Pedro Alves  <palves@redhat.com>
4068
4069         * linux-fork.c: Include <list>.
4070         (fork_list): Now a std::list instance.
4071         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4072         (forks_exist_p, find_last_fork): Adjust.
4073         (new_fork): Delete.
4074         (one_fork_p): New.
4075         (add_fork): Adjust.
4076         (free_fork): Delete, folded into fork_info::~fork_info().
4077         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4078         Adjust.
4079         (init_fork_list): Delete.
4080         (linux_fork_killall, linux_fork_mourn_inferior)
4081         (linux_fork_detach, info_checkpoints_command): Adjust.
4082         (_initialize_linux_fork): No longer call init_fork_list.
4083
4084 2019-03-06  Pedro Alves  <palves@redhat.com>
4085
4086         * linux-fork.c (new_fork): New, split out of ...
4087         (add_fork): ... this.  Return void.  Move "first fork" special
4088         case from here, to ...
4089         (checkpoint_command): ... here.
4090         * linux-linux.h (add_fork): Return void.
4091
4092 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4093
4094         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4095
4096 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4097             Chris January  <chris.january@arm.com>
4098             David Lecomber  <david.lecomber@arm.com>
4099
4100         * f-exp.y: New token, UNOP_INTRINSIC.
4101         (exp): New pattern using UNOP_INTRINSIC token.
4102         (f77_keywords): Add 'abs' keyword.
4103         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4104         (value_from_host_double): New function.
4105         (evaluate_subexp_f): Support UNOP_ABS.
4106
4107 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4108
4109         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4110         types.
4111
4112 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4113
4114         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4115         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4116         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4117
4118 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4119
4120         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4121
4122 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4123             Chris January  <chris.january@arm.com>
4124
4125         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4126         * f-exp.y: Define 'KIND' token.
4127         (exp): New pattern for KIND expressions.
4128         (ptype): Handle types with a kind extension.
4129         (direct_abs_decl): Extend to spot kind extensions.
4130         (f77_keywords): Add 'kind' to the list.
4131         (push_kind_type): New function.
4132         (convert_to_kind_type): New function.
4133         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4134         * parse.c (operator_length_standard): Likewise.
4135         * parser-defs.h (enum type_pieces): Add tp_kind.
4136         * std-operator.def: Add UNOP_KIND.
4137
4138 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4139
4140         * f-exp.y (f_parse): Set yydebug.
4141
4142 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4143
4144         * f-lang.c (evaluate_subexp_f): New function.
4145         (exp_descriptor_f): New global.
4146         (f_language_defn): Use exp_descriptor_f instead of
4147         exp_descriptor_standard.
4148
4149 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4150
4151         * f-exp.y (struct token): Add comments.
4152         (dot_ops): Remove uppercase versions and the end marker.
4153         (f77_keywords): Likewise.
4154         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4155         entries in the dot_ops array are case insensitive, and use
4156         strncasecmp to compare strings.  Also some whitespace cleanup in
4157         this area.  Similar for the f77_keywords array, except entries in
4158         this list might be case sensitive.
4159
4160 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4161
4162         * f-exp.y (struct f77_boolean_val): Add comments.
4163         (boolean_values): Remove uppercase versions, and end marker.
4164         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4165         and use strncasecmp to achieve case insensitivity.  Additionally,
4166         perform whitespace cleanup around this code.
4167
4168 2019-03-06  Tom Tromey  <tromey@adacore.com>
4169
4170         * remote-sim.c (gdbsim_target_open): Use result of
4171         gdb_argv::release.
4172
4173 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4174         Dirk Schubert  <dirk.schubert@arm.com>
4175         Chris January  <chris.january@arm.com>
4176
4177         * eval.c (evaluate_subexp_standard): Call Fortran argument
4178         wrapping logic.
4179         * f-lang.c (struct value): A value which can be passed into a
4180         Fortran function call.
4181         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4182         where appropriate.
4183         (struct type): Value ready for a Fortran function call.
4184         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4185         is needed.
4186         * f-lang.h (fortran_argument_convert): Declaration.
4187         (fortran_preserve_arg_pointer): Declaration.
4188         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4189
4190 2019-03-05  Tom Tromey  <tromey@adacore.com>
4191
4192         * python/py-prettyprint.c (print_string_repr): Remove #if.
4193         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4194
4195 2019-03-05  Tom Tromey  <tromey@adacore.com>
4196
4197         * target.c (the_dummy_target): Move later.  Change type to
4198         "dummy_target".
4199         (initialize_targets): Don't initialize the_dummy_target.
4200
4201 2019-03-05  Tom Tromey  <tromey@adacore.com>
4202
4203         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4204         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4205
4206 2019-03-05  Tom Tromey  <tromey@adacore.com>
4207
4208         * windows-nat.c (windows_nat_target::attach)
4209         (windows_nat_target::detach): Don't call gdb_flush.
4210         * valprint.c (generic_val_print, val_print, val_print_string):
4211         Don't call gdb_flush.
4212         * utils.c (defaulted_query): Don't call gdb_flush.
4213         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4214         * target.c (target_announce_detach): Don't call gdb_flush.
4215         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4216         * remote.c (extended_remote_target::attach): Don't call
4217         gdb_flush.
4218         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4219         * printcmd.c (do_examine): Don't call gdb_flush.
4220         (info_display_command): Don't call gdb_flush.
4221         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4222         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4223         * memattr.c (info_mem_command): Don't call gdb_flush.
4224         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4225         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4226         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4227         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4228         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4229         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4230         (gnu_nat_target::detach): Don't call gdb_flush.
4231         * f-valprint.c (f_val_print): Don't call gdb_flush.
4232         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4233         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4234         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4235         gdb_flush.
4236         * c-valprint.c (c_val_print): Don't call gdb_flush.
4237         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4238
4239 2019-03-05  Tom Tromey  <tromey@adacore.com>
4240
4241         * varobj.c (update_dynamic_varobj_children): Update.
4242         (install_default_visualizer): Use reset, not release.
4243         * value.c (set_internalvar): Update.
4244         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4245         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4246         ATTRIBUTE_UNUSED_RESULT.
4247
4248 2019-03-05  Tom Tromey  <tromey@adacore.com>
4249
4250         * remote.c (class scoped_remote_fd) <release>: Add
4251         ATTRIBUTE_UNUSED_RESULT.
4252
4253 2019-03-05  Tom Tromey  <tromey@adacore.com>
4254
4255         * macroexp.c (struct macro_buffer) <release>: Add
4256         ATTRIBUTE_UNUSED_RESULT.
4257
4258 2019-03-05  Tom Tromey  <tromey@adacore.com>
4259
4260         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4261         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4262         ATTRIBUTE_UNUSED_RESULT.
4263
4264 2019-03-05  Tom Tromey  <tromey@adacore.com>
4265
4266         * common/scoped_fd.h (class scoped_fd) <release>: Add
4267         ATTRIBUTE_UNUSED_RESULT.
4268
4269 2019-03-05  Tom Tromey  <tromey@adacore.com>
4270
4271         * parser-defs.h (struct parser_state) <release>: Add
4272         ATTRIBUTE_UNUSED_RESULT.
4273
4274 2019-03-05  Tom Tromey  <tromey@adacore.com>
4275
4276         * utils.h (class gdb_argv) <release>: Add
4277         ATTRIBUTE_UNUSED_RESULT.
4278         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4279
4280 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4281
4282         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4283         for-loop range, to avoid compiler warnings.
4284
4285         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4286         avoid compiler warnings about unused variables.
4287
4288         * NEWS: Mention end of support for native debugging on MS-Windows
4289         before XP.
4290
4291         PR gdb/24292
4292         * common/netstuff.c:
4293         * gdbserver/gdbreplay.c
4294         * gdbserver/remote-utils.c:
4295         * ser-tcp.c:
4296         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4297         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4298         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4299         'getaddrinfo' and 'freeaddrinfo' were not available before
4300         Windows XP, and mingw.org's MinGW headers by default define
4301         _WIN32_WINNT to 0x500.
4302
4303 2019-03-01  Gary Benson <gbenson@redhat.com>
4304
4305         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4306
4307 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4308             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4309
4310         PR gdb/8527
4311         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4312         set_sigint_trap, clear_sigint_trap.
4313
4314 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4315
4316         * target.c (target_detach): Clear the regcache and the
4317         frame cache.
4318
4319 2019-02-27  Pedro Alves  <palves@redhat.com>
4320
4321         * utils.c (set_screen_size): When we cap the height/width sizes,
4322         tweak the corresponding command variable to show "unlimited":
4323
4324 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4325             Pedro Alves  <palves@redhat.com>
4326
4327         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4328         before calling rl_set_screen_size.
4329
4330 2019-02-27  Tom Tromey  <tromey@adacore.com>
4331
4332         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4333         define.
4334         * python/py-value.c: Remove Python 2.4 workaround.
4335         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4336         workaround.
4337         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4338         Python 2.4 workaround.
4339         * python/python-internal.h: Remove Python 2.4 comment.
4340         (Py_ssize_t): Don't define.
4341         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4342         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4343         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4344         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4345         * python/python.c (do_start_initialization): Remove Python 2.4
4346         workaround.
4347         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4348         (print_children): Remove Python 2.4 workaround.
4349         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4350         workaround.
4351         (CHARBUFFERPROC_NAME): Remove.
4352         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4353         Python 2.4 workaround.
4354
4355 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4356
4357         * NEWS: Note minimum Python version.
4358
4359 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4360
4361         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4362         code from these functions.  Remove corresponding ifdefs.  Use
4363         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4364         Remove gotos and target of gotos.
4365         (infpy_search_memory): Likewise.
4366
4367 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4368
4369         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4370         (hppa_gdbarch_init): Don't register deleted functions with
4371         gdbarch.
4372
4373 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4374
4375         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4376         (h8300_unwind_sp): Delete.
4377         (h8300_dummy_id): Delete.
4378         (h8300_gdbarch_init): Don't register deleted functions with
4379         gdbarch.
4380
4381 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4382
4383         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4384         (ft32_unwind_pc): Delete.
4385         (ft32_unwind_sp): Delete.
4386         (ft32_gdbarch_init): Don't register deleted functions with
4387         gdbarch.
4388
4389 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4390
4391         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4392         (frv_unwind_pc): Delete.
4393         (frv_unwind_sp): Delete.
4394         (frv_gdbarch_init): Don't register deleted functions with
4395         gdbarch.
4396
4397 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4398
4399         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4400         (riscv_unwind_pc): Delete.
4401         (riscv_unwind_sp): Delete.
4402         (riscv_gdbarch_init): Don't register deleted functions with
4403         gdbarch.
4404
4405 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4406
4407         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4408         (csky_unwind_pc): Delete.
4409         (csky_unwind_sp): Delete.
4410         (csky_gdbarch_init): Don't register deleted functions with
4411         gdbarch.
4412
4413 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4414
4415         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4416         (cris_unwind_pc): Delete.
4417         (cris_unwind_sp): Delete.
4418         (cris_gdbarch_init): Don't register deleted functions with
4419         gdbarch.
4420
4421 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4422
4423         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4424         (bfin_unwind_pc): Delete.
4425         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4426
4427 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4428
4429         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4430         (arm_unwind_pc): Delete.
4431         (arm_unwind_sp): Delete.
4432         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4433
4434 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4435
4436         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4437         (arc_unwind_pc): Delete.
4438         (arc_unwind_sp): Delete.
4439         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4440
4441 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4442
4443         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4444         (alpha_unwind_pc): Delete.
4445         (alpha_gdbarch_init): Don't register deleted functions with
4446         gdbarch.
4447
4448 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4449
4450         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4451         (aarch64_unwind_pc): Delete.
4452         (aarch64_unwind_sp): Delete.
4453         (aarch64_gdbarch_init): Don't register deleted functions with
4454         gdbarch.
4455
4456 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4457
4458         * gdbtypes.c (type_align): Don't consider static members when
4459         computing structure alignment.
4460
4461 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4462
4463         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4464         return 0 for other types.
4465         * arch-utils.c (default_type_align): Always return 0.
4466         * gdbarch.h: Regenerate.
4467         * gdbarch.sh (type_align): Extend comment.
4468         * gdbtypes.c (type_align): Add additional comments, always call
4469         gdbarch_type_align before applying the default rules.
4470         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4471         generic code will then apply a suitable default.
4472         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4473         types, return 0 for other types.
4474
4475 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4476
4477         * NEWS: Create a new section for the next release branch.
4478         Rename the section of the current branch, now that it has
4479         been cut.
4480
4481 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4482
4483         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4484         * version.in: Bump version to 8.3.50.DATE-git.
4485
4486 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4487
4488         * aix-thread.c (ptid_cmp): Remove unused variable.
4489         (get_signaled_thread): Likewise.
4490         (store_regs_user_thread): Likewise.
4491         (store_regs_kernel_thread): Likewise.
4492         (fetch_regs_kernel_thread): Remove shadowed variable.
4493
4494 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4495
4496         * features/riscv/32bit-cpu.xml: Add register numbers.
4497         * features/riscv/32bit-fpu.c: Regenerate.
4498         * features/riscv/32bit-fpu.xml: Add register numbers.
4499         * features/riscv/64bit-cpu.xml: Add register numbers.
4500         * features/riscv/64bit-fpu.c: Regenerate.
4501         * features/riscv/64bit-fpu.xml: Add register numbers.
4502
4503 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4504
4505         * NEWS: Mention two argument form of gdb.Value constructor.
4506         * python/py-value.c (convert_buffer_and_type_to_value): New
4507         function.
4508         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4509         Add support for handling an optional second argument.  Call
4510         convert_buffer_and_type_to_value as appropriate.
4511         * python/python-internal.h (Py_buffer_deleter): New struct.
4512         (Py_buffer_up): New typedef.
4513
4514 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4515
4516         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4517         instead of releasing ownership.
4518
4519 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4520
4521         * dwarf2read.c (open_and_init_dwp_file): Call
4522         elf_numsections instead of bfd_count_sections to initialize
4523         dwp_file->num_sections.
4524
4525 2019-02-25  Tom Tromey  <tromey@adacore.com>
4526
4527         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4528
4529 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4530
4531         * gcore.in: Add '--readnever' option when invoking GDB.
4532
4533 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4534
4535         * MAINTAINERS: Update my email address.
4536
4537 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4538
4539         * build-id.c (build_id_to_debug_bfd_1): New function.
4540         (build_id_to_debug_bfd): Look for separate debug file in
4541         sysroot.
4542
4543 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4544
4545         * gdbarch.sh: Update the copyright year range that is placed into
4546         generated files.
4547
4548 2019-02-22  Keith Seitz  <keiths@redhat.com>
4549
4550         PR symtab/23853
4551         * linespec.c (create_sals_line_offset): Search for the default
4552         symtab's filename instead of its fullname.
4553
4554 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4555
4556         * NEWS: Update style defaults.
4557
4558 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4559
4560         * main.c (captured_main_1): Disable styling in batch mode.
4561
4562 2019-02-20  Tom Tromey  <tom@tromey.com>
4563
4564         * symtab.c (symtab_symbol_info): Fix typos.
4565
4566 2019-02-20  Tom Tromey  <tromey@adacore.com>
4567
4568         * findcmd.c (_initialize_mem_search): Use upper case for
4569         metasyntactic variables.
4570
4571 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4572
4573         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4574         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4575
4576 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4577
4578         * top.h (source_file_name): Change to std::string.
4579         * top.c (source_file_name): Likewise.
4580         (command_line_input): Adjust.
4581         * cli/cli-script.c (script_from_file): Adjust.
4582
4583 2019-02-19  Tom Tromey  <tromey@adacore.com>
4584
4585         * ravenscar-thread.c
4586         (ravenscar_thread_target::update_thread_list): Don't call
4587         ada_build_task_list.
4588         * ada-lang.h (ada_build_task_list): Don't declare.
4589         * ada-tasks.c (struct ada_tasks_inferior_data)
4590         <task_list_valid_p>: Now bool.
4591         (read_known_tasks, ada_task_list_changed)
4592         (ada_tasks_invalidate_inferior_data): Update.
4593         (read_known_tasks_array): Return bool.
4594         (read_known_tasks_list): Likewise.
4595         (read_known_tasks): Return void.
4596         (ada_build_task_list): Now static.
4597
4598 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4599
4600         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4601         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4602
4603 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4604
4605         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4606         variant for ada_tasks_pspace_data_handle and
4607         ada_tasks_inferior_data_handle.
4608         (ada_tasks_pspace_data_cleanup): New function.
4609         (ada_tasks_inferior_data_cleanup): New function.
4610
4611 2019-02-17  Tom Tromey  <tom@tromey.com>
4612
4613         * macrotab.h (macro_source_fullname): Return a std::string.
4614         * macrotab.c (macro_include, check_for_redefinition)
4615         (macro_undef, macro_lookup_definition, foreach_macro)
4616         (foreach_macro_in_scope): Update.
4617         (macro_source_fullname): Return a std::string.
4618         * macrocmd.c (show_pp_source_pos): Update.
4619
4620 2019-02-17  Tom Tromey  <tom@tromey.com>
4621
4622         * macrocmd.c (show_pp_source_pos): Style the file names.
4623
4624 2019-02-17  Tom Tromey  <tom@tromey.com>
4625
4626         PR tui/24197:
4627         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4628
4629 2019-02-17  Tom Tromey  <tom@tromey.com>
4630
4631         * ada-lang.c (user_select_syms): Use filtered printing.
4632         * utils.c (wrap_style): New global.
4633         (desired_style): Remove.
4634         (emit_style_escape): Add stream parameter.
4635         (set_output_style, reset_terminal_style, prompt_for_continue):
4636         Update.
4637         (flush_wrap_buffer): Only flush gdb_stdout.
4638         (wrap_here): Set wrap_style.
4639         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4640         treat escape sequences as a character.  Change when wrap buffer is
4641         flushed.
4642         (fputs_styled): Do not set the output style when the default is
4643         requested.
4644         * ui-style.h (struct ui_file_style) <is_default>: New method.
4645         * source.c (print_source_lines_base): Emit escape sequences in one
4646         piece.
4647
4648 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4649
4650         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4651         integers and enumeration types.
4652
4653 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4654
4655         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4656         instead of lookup_symbol_in_language
4657         (do_exact_match): New function.
4658         (ada_get_symbol_name_matcher): Return do_exact_match when
4659         doing a verbatim match.
4660
4661 2019-02-15  Tom Tromey  <tromey@adacore.com>
4662
4663         * ravenscar-thread.c (ravenscar_thread_target::resume)
4664         (ravenscar_thread_target::wait): Special case wildcard requests.
4665
4666 2019-02-15  Tom Tromey  <tromey@adacore.com>
4667
4668         * ravenscar-thread.c (base_ptid): Remove.
4669         (struct ravenscar_thread_target) <close>: New method.
4670         <m_base_ptid>: New member.
4671         <update_inferior_ptid, active_task, task_is_currently_active,
4672         runtime_initialized>: Declare methods.
4673         <ravenscar_thread_target>: Add constructor.
4674         (ravenscar_thread_target::task_is_currently_active)
4675         (ravenscar_thread_target::update_inferior_ptid)
4676         (ravenscar_runtime_initialized): Rename.  Now methods.
4677         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4678         (ravenscar_thread_target::update_thread_list): Update.
4679         (ravenscar_thread_target::active_task): Now method.
4680         (ravenscar_thread_target::store_registers)
4681         (ravenscar_thread_target::prepare_to_store)
4682         (ravenscar_thread_target::prepare_to_store)
4683         (ravenscar_thread_target::mourn_inferior): Update.
4684         (ravenscar_inferior_created): Use "new" to create target.
4685         (ravenscar_thread_target::get_ada_task_ptid): Update.
4686         (_initialize_ravenscar): Don't initialize base_ptid.
4687         (ravenscar_ops): Remove global.
4688
4689 2019-02-15  Tom Tromey  <tromey@adacore.com>
4690
4691         * target.h (push_target): Declare new overload.
4692         * target.c (push_target): New overload, taking an rvalue reference.
4693         * remote.c (remote_target::open_1): Use push_target overload.
4694         * corelow.c (core_target_open): Use push_target overload.
4695
4696 2019-02-15  Tom Tromey  <tromey@adacore.com>
4697
4698         * ravenscar-thread.c (is_ravenscar_task)
4699         (ravenscar_task_is_currently_active): Return bool.
4700         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4701         (_initialize_ravenscar): Remove "(void)".
4702         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4703         Return bool.
4704
4705 2019-02-15  Tom Tromey  <tromey@adacore.com>
4706
4707         * ravenscar-thread.c (ravenscar_runtime_initializer)
4708         (has_ravenscar_runtime, get_running_thread_id)
4709         (ravenscar_thread_target::resume): Fix indentation.
4710
4711 2019-02-15  Tom Tromey  <tromey@adacore.com>
4712
4713         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4714         from ravenscar_arch_ops.
4715         (sparc_ravenscar_ops::fetch_registers)
4716         (sparc_ravenscar_ops::store_registers): Now methods.
4717         (sparc_ravenscar_prepare_to_store): Remove.
4718         (sparc_ravenscar_ops): Redefine.
4719         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4720         methods and destructor.  Remove members.
4721         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4722         (ravenscar_thread_target::store_registers)
4723         (ravenscar_thread_target::prepare_to_store): Update.
4724         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4725         Remove.
4726         (struct ppc_ravenscar_powerpc_ops): Derive from
4727         ravenscar_arch_ops.
4728         (ppc_ravenscar_powerpc_ops::fetch_registers)
4729         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4730         (ppc_ravenscar_powerpc_ops): Redefine.
4731         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4732         (ppc_ravenscar_e500_ops::fetch_registers)
4733         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4734         (ppc_ravenscar_e500_ops): Redefine.
4735         * aarch64-ravenscar-thread.c
4736         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4737         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4738         (aarch64_ravenscar_fetch_registers)
4739         (aarch64_ravenscar_store_registers): Now methods.
4740         (aarch64_ravenscar_ops): Redefine.
4741
4742 2019-02-15  Tom Tromey  <tromey@adacore.com>
4743
4744         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4745         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4746         (ravenscar_thread_target::stopped_by_watchpoint)
4747         (ravenscar_thread_target::stopped_data_address)
4748         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4749
4750 2019-02-15  Tom Tromey  <tromey@adacore.com>
4751
4752         * ravenscar-thread.c: Fix some typos.
4753
4754 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4755             Tom Tromey  <tromey@adacore.com>
4756
4757         * ada-lang.c (ada_exception_sal): Change addr_string to a
4758         std::string.
4759         (create_ada_exception_catchpoint): Update.
4760
4761 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4762             Tom Tromey  <tromey@adacore.com>
4763
4764         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4765         (bp_location_ops): Remove.
4766         (base_breakpoint_allocate_location): Update.
4767         (free_bp_location): Update.
4768         * ada-lang.c (class ada_catchpoint_location)
4769         <ada_catchpoint_location>: Remove ops parameter.
4770         (ada_catchpoint_location_dtor): Remove.
4771         (ada_catchpoint_location_ops): Remove.
4772         (allocate_location_exception): Update.
4773         * breakpoint.h (struct bp_location_ops): Remove.
4774         (class bp_location) <bp_location>: Remove bp_location_ops
4775         parameter.
4776         <~bp_location>: Add destructor.
4777         <ops>: Remove.
4778
4779 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4780             Pedro Alves  <palves@redhat.com>
4781
4782         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4783         'PATH_MAX'.
4784
4785 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4786             Samuel Thibault  <samuel.thibault@gnu.org>
4787             Thomas Schwinge  <thomas@codesourcery.com>
4788
4789         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4790         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4791
4792 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4793
4794         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4795         (check_empty): Use "const char *".
4796
4797         * gnu-nat.c (gnu_nat_target::detach): Instead of
4798         'detach_inferior (pid)' call
4799         'detach_inferior (find_inferior_pid (pid))'.
4800
4801         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4802         'nat/fork-inferior.o'.
4803         * gnu-nat.c: #include "nat/fork-inferior.h".
4804
4805         * gnu-nat.c (gnu_nat_target::detach): Instead of
4806         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4807         * gnu-nat.h: #include "inf-child.h".
4808         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4809         'i386_gnu_nat_target::fetch_registers'.
4810         (gnu_store_registers): Rename/move to
4811         'i386_gnu_nat_target::store_registers'.
4812
4813         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4814         * gnu-nat.h (mach_thread_info): New function.
4815         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4816
4817         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4818
4819 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4820
4821         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4822
4823 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4824
4825         * windows-nat.c (windows_add_thread): Add new parameter
4826         "main_thread_p" with default value set to false.  Update
4827         function documentation as well as all callers.
4828         (windows_delete_thread): Likewise.
4829         (fake_create_process): Update call to windows_add_thread.
4830         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4831         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4832         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4833         call to windows_delete_thread.
4834
4835 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4836
4837         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4838
4839 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4840
4841         * symfile.c (find_separate_debug_file): Use canonical path of
4842         sysroot with child_path instead of gdb_sysroot if it is valid.
4843
4844 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4845
4846         * symfile.c (find_separate_debug_file): Use child_path to
4847         determine if an object file is under a sysroot.
4848
4849 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4850
4851         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4852         unittests/child-path-selftests.c.
4853         * common/pathstuff.c (child_path): New function.
4854         * common/pathstuff.h (child_path): New prototype.
4855         * unittests/child-path-selftests.c: New file.
4856
4857 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4858
4859         * symfile.c (find_separate_debug_file): Look for separate debug
4860         files in debug directories under the sysroot.
4861
4862 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4863
4864         * symtab.h (struct minimal_symbol data_p): New const method.
4865         (struct minimal_symbol text_p): Likewise.
4866         * symtab.c (output_source_filename): Use file name style
4867         to print file name.
4868         (print_symbol_info): Likewise.
4869         (print_msymbol_info): Use address style to print addresses.
4870         Use function name style to print executable text symbols.
4871         (expand_symtab_containing_pc): Use data_p.
4872         (find_pc_sect_compunit_symtab): Likewise.
4873
4874 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4875
4876         * breakpoint.c (describe_other_breakpoints): Use address style
4877         to print addresses.
4878         (say_where): Likewise.
4879
4880 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4881
4882         * ada-typeprint.c (print_func_type): Print function name
4883         style to print function name.
4884         * c-typeprint.c (c_print_type_1): Likewise.
4885
4886 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4887
4888         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4889         for execve.
4890
4891 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4892
4893         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4894         type_stack.
4895
4896 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4897
4898         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4899         TYPE_CODE_REF types.
4900
4901 2019-02-08  Jim Wilson  <jimw@sifive.com>
4902
4903         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4904         (riscv_linux_fregset): New.
4905         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4906
4907 2019-02-07  Tom Tromey  <tom@tromey.com>
4908
4909         * thread.c (thread_cancel_execution_command): Update.
4910         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4911         methods.
4912         (struct thread_fsm_ops): Remove.
4913         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4914         (thread_fsm_should_stop, thread_fsm_return_value)
4915         (thread_fsm_set_finished, thread_fsm_finished_p)
4916         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4917         Don't declare.
4918         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4919         * infrun.c (clear_proceed_status_thread)
4920         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4921         (print_stop_event): Update.
4922         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4923         Add constructor.
4924         (step_command_fsm_ops): Remove.
4925         (new_step_command_fsm): Remove.
4926         (step_1): Update.
4927         (step_command_fsm::should_stop): Rename from
4928         step_command_fsm_should_stop.
4929         (step_command_fsm::clean_up): Rename from
4930         step_command_fsm_clean_up.
4931         (step_command_fsm::do_async_reply_reason): Rename from
4932         step_command_fsm_async_reply_reason.
4933         (struct until_next_fsm): Inherit from thread_fsm.  Add
4934         constructor.
4935         (until_next_fsm_ops): Remove.
4936         (new_until_next_fsm): Remove.
4937         (until_next_fsm::should_stop): Rename from
4938         until_next_fsm_should_stop.
4939         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4940         (until_next_fsm::do_async_reply_reason): Rename from
4941         until_next_fsm_async_reply_reason.
4942         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4943         constructor.  Change type of breakpoint.
4944         (finish_command_fsm_ops): Remove.
4945         (new_finish_command_fsm): Remove.
4946         (finish_command_fsm::should_stop): Rename from
4947         finish_command_fsm_should_stop.
4948         (finish_command_fsm::clean_up): Rename from
4949         finish_command_fsm_clean_up.
4950         (finish_command_fsm::return_value): Rename from
4951         finish_command_fsm_return_value.
4952         (finish_command_fsm::do_async_reply_reason): Rename from
4953         finish_command_fsm_async_reply_reason.
4954         (finish_command): Update.
4955         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4956         Add constructor.
4957         (call_thread_fsm_ops): Remove.
4958         (call_thread_fsm::call_thread_fsm): Rename from
4959         new_call_thread_fsm.
4960         (call_thread_fsm::should_stop): Rename from
4961         call_thread_fsm_should_stop.
4962         (call_thread_fsm::should_notify_stop): Rename from
4963         call_thread_fsm_should_notify_stop.
4964         (run_inferior_call, call_function_by_hand_dummy): Update.
4965         * cli/cli-interp.c (should_print_stop_to_console): Update.
4966         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4967         Add constructor.  Change type of location_breakpoint,
4968         caller_breakpoint.
4969         (until_break_fsm_ops): Remove.
4970         (new_until_break_fsm): Remove.
4971         (until_break_fsm::should_stop): Rename from
4972         until_break_fsm_should_stop.
4973         (until_break_fsm::clean_up): Rename from
4974         until_break_fsm_clean_up.
4975         (until_break_fsm::do_async_reply_reason): Rename from
4976         until_break_fsm_async_reply_reason.
4977         (until_break_command): Update.
4978         * thread-fsm.c: Remove.
4979         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4980
4981 2019-02-07  Tom Tromey  <tom@tromey.com>
4982
4983         * yy-remap.h: Add include guard.
4984         * xtensa-tdep.h: Add include guard.
4985         * xcoffread.h: Rename include guard.
4986         * varobj-iter.h: Add include guard.
4987         * tui/tui.h: Rename include guard.
4988         * tui/tui-winsource.h: Rename include guard.
4989         * tui/tui-wingeneral.h: Rename include guard.
4990         * tui/tui-windata.h: Rename include guard.
4991         * tui/tui-win.h: Rename include guard.
4992         * tui/tui-stack.h: Rename include guard.
4993         * tui/tui-source.h: Rename include guard.
4994         * tui/tui-regs.h: Rename include guard.
4995         * tui/tui-out.h: Rename include guard.
4996         * tui/tui-layout.h: Rename include guard.
4997         * tui/tui-io.h: Rename include guard.
4998         * tui/tui-hooks.h: Rename include guard.
4999         * tui/tui-file.h: Rename include guard.
5000         * tui/tui-disasm.h: Rename include guard.
5001         * tui/tui-data.h: Rename include guard.
5002         * tui/tui-command.h: Rename include guard.
5003         * tic6x-tdep.h: Add include guard.
5004         * target/waitstatus.h: Rename include guard.
5005         * target/wait.h: Rename include guard.
5006         * target/target.h: Rename include guard.
5007         * target/resume.h: Rename include guard.
5008         * target-float.h: Rename include guard.
5009         * stabsread.h: Add include guard.
5010         * rs6000-tdep.h: Add include guard.
5011         * riscv-fbsd-tdep.h: Add include guard.
5012         * regformats/regdef.h: Rename include guard.
5013         * record.h: Rename include guard.
5014         * python/python.h: Rename include guard.
5015         * python/python-internal.h: Rename include guard.
5016         * python/py-stopevent.h: Rename include guard.
5017         * python/py-ref.h: Rename include guard.
5018         * python/py-record.h: Rename include guard.
5019         * python/py-record-full.h: Rename include guard.
5020         * python/py-record-btrace.h: Rename include guard.
5021         * python/py-instruction.h: Rename include guard.
5022         * python/py-events.h: Rename include guard.
5023         * python/py-event.h: Rename include guard.
5024         * procfs.h: Add include guard.
5025         * proc-utils.h: Add include guard.
5026         * p-lang.h: Add include guard.
5027         * or1k-tdep.h: Rename include guard.
5028         * observable.h: Rename include guard.
5029         * nto-tdep.h: Rename include guard.
5030         * nat/x86-linux.h: Rename include guard.
5031         * nat/x86-linux-dregs.h: Rename include guard.
5032         * nat/x86-gcc-cpuid.h: Add include guard.
5033         * nat/x86-dregs.h: Rename include guard.
5034         * nat/x86-cpuid.h: Rename include guard.
5035         * nat/ppc-linux.h: Rename include guard.
5036         * nat/mips-linux-watch.h: Rename include guard.
5037         * nat/linux-waitpid.h: Rename include guard.
5038         * nat/linux-ptrace.h: Rename include guard.
5039         * nat/linux-procfs.h: Rename include guard.
5040         * nat/linux-osdata.h: Rename include guard.
5041         * nat/linux-nat.h: Rename include guard.
5042         * nat/linux-namespaces.h: Rename include guard.
5043         * nat/linux-btrace.h: Rename include guard.
5044         * nat/glibc_thread_db.h: Rename include guard.
5045         * nat/gdb_thread_db.h: Rename include guard.
5046         * nat/gdb_ptrace.h: Rename include guard.
5047         * nat/fork-inferior.h: Rename include guard.
5048         * nat/amd64-linux-siginfo.h: Rename include guard.
5049         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5050         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5051         * nat/aarch64-linux.h: Rename include guard.
5052         * nat/aarch64-linux-hw-point.h: Rename include guard.
5053         * mn10300-tdep.h: Add include guard.
5054         * mips-linux-tdep.h: Add include guard.
5055         * mi/mi-parse.h: Rename include guard.
5056         * mi/mi-out.h: Rename include guard.
5057         * mi/mi-main.h: Rename include guard.
5058         * mi/mi-interp.h: Rename include guard.
5059         * mi/mi-getopt.h: Rename include guard.
5060         * mi/mi-console.h: Rename include guard.
5061         * mi/mi-common.h: Rename include guard.
5062         * mi/mi-cmds.h: Rename include guard.
5063         * mi/mi-cmd-break.h: Rename include guard.
5064         * m2-lang.h: Add include guard.
5065         * location.h: Rename include guard.
5066         * linux-record.h: Rename include guard.
5067         * linux-nat.h: Add include guard.
5068         * linux-fork.h: Add include guard.
5069         * i386-darwin-tdep.h: Rename include guard.
5070         * hppa-linux-offsets.h: Add include guard.
5071         * guile/guile.h: Rename include guard.
5072         * guile/guile-internal.h: Rename include guard.
5073         * gnu-nat.h: Rename include guard.
5074         * gdb-stabs.h: Rename include guard.
5075         * frv-tdep.h: Add include guard.
5076         * f-lang.h: Add include guard.
5077         * event-loop.h: Add include guard.
5078         * darwin-nat.h: Rename include guard.
5079         * cp-abi.h: Rename include guard.
5080         * config/sparc/nm-sol2.h: Rename include guard.
5081         * config/nm-nto.h: Rename include guard.
5082         * config/nm-linux.h: Add include guard.
5083         * config/i386/nm-i386gnu.h: Rename include guard.
5084         * config/djgpp/nl_types.h: Rename include guard.
5085         * config/djgpp/langinfo.h: Rename include guard.
5086         * compile/gcc-cp-plugin.h: Add include guard.
5087         * compile/gcc-c-plugin.h: Add include guard.
5088         * compile/compile.h: Rename include guard.
5089         * compile/compile-object-run.h: Rename include guard.
5090         * compile/compile-object-load.h: Rename include guard.
5091         * compile/compile-internal.h: Rename include guard.
5092         * compile/compile-cplus.h: Rename include guard.
5093         * compile/compile-c.h: Rename include guard.
5094         * common/xml-utils.h: Rename include guard.
5095         * common/x86-xstate.h: Rename include guard.
5096         * common/version.h: Rename include guard.
5097         * common/vec.h: Rename include guard.
5098         * common/tdesc.h: Rename include guard.
5099         * common/selftest.h: Rename include guard.
5100         * common/scoped_restore.h: Rename include guard.
5101         * common/scoped_mmap.h: Rename include guard.
5102         * common/scoped_fd.h: Rename include guard.
5103         * common/safe-iterator.h: Rename include guard.
5104         * common/run-time-clock.h: Rename include guard.
5105         * common/refcounted-object.h: Rename include guard.
5106         * common/queue.h: Rename include guard.
5107         * common/ptid.h: Rename include guard.
5108         * common/print-utils.h: Rename include guard.
5109         * common/preprocessor.h: Rename include guard.
5110         * common/pathstuff.h: Rename include guard.
5111         * common/observable.h: Rename include guard.
5112         * common/netstuff.h: Rename include guard.
5113         * common/job-control.h: Rename include guard.
5114         * common/host-defs.h: Rename include guard.
5115         * common/gdb_wait.h: Rename include guard.
5116         * common/gdb_vecs.h: Rename include guard.
5117         * common/gdb_unlinker.h: Rename include guard.
5118         * common/gdb_unique_ptr.h: Rename include guard.
5119         * common/gdb_tilde_expand.h: Rename include guard.
5120         * common/gdb_sys_time.h: Rename include guard.
5121         * common/gdb_string_view.h: Rename include guard.
5122         * common/gdb_splay_tree.h: Rename include guard.
5123         * common/gdb_setjmp.h: Rename include guard.
5124         * common/gdb_ref_ptr.h: Rename include guard.
5125         * common/gdb_optional.h: Rename include guard.
5126         * common/gdb_locale.h: Rename include guard.
5127         * common/gdb_assert.h: Rename include guard.
5128         * common/filtered-iterator.h: Rename include guard.
5129         * common/filestuff.h: Rename include guard.
5130         * common/fileio.h: Rename include guard.
5131         * common/environ.h: Rename include guard.
5132         * common/common-utils.h: Rename include guard.
5133         * common/common-types.h: Rename include guard.
5134         * common/common-regcache.h: Rename include guard.
5135         * common/common-inferior.h: Rename include guard.
5136         * common/common-gdbthread.h: Rename include guard.
5137         * common/common-exceptions.h: Rename include guard.
5138         * common/common-defs.h: Rename include guard.
5139         * common/common-debug.h: Rename include guard.
5140         * common/cleanups.h: Rename include guard.
5141         * common/buffer.h: Rename include guard.
5142         * common/btrace-common.h: Rename include guard.
5143         * common/break-common.h: Rename include guard.
5144         * cli/cli-utils.h: Rename include guard.
5145         * cli/cli-style.h: Rename include guard.
5146         * cli/cli-setshow.h: Rename include guard.
5147         * cli/cli-script.h: Rename include guard.
5148         * cli/cli-interp.h: Rename include guard.
5149         * cli/cli-decode.h: Rename include guard.
5150         * cli/cli-cmds.h: Rename include guard.
5151         * charset-list.h: Add include guard.
5152         * buildsym-legacy.h: Rename include guard.
5153         * bfin-tdep.h: Add include guard.
5154         * ax.h: Rename include guard.
5155         * arm-linux-tdep.h: Add include guard.
5156         * arm-fbsd-tdep.h: Add include guard.
5157         * arch/xtensa.h: Rename include guard.
5158         * arch/tic6x.h: Add include guard.
5159         * arch/i386.h: Add include guard.
5160         * arch/arm.h: Rename include guard.
5161         * arch/arm-linux.h: Rename include guard.
5162         * arch/arm-get-next-pcs.h: Rename include guard.
5163         * arch/amd64.h: Add include guard.
5164         * arch/aarch64-insn.h: Rename include guard.
5165         * arch-utils.h: Rename include guard.
5166         * annotate.h: Add include guard.
5167         * amd64-darwin-tdep.h: Rename include guard.
5168         * aarch64-linux-tdep.h: Add include guard.
5169         * aarch64-fbsd-tdep.h: Add include guard.
5170         * aarch32-linux-nat.h: Add include guard.
5171
5172 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5173
5174         * macrotab.c (macro_define_internal): New function that
5175         factorizes macro_define_object_internal and macro_define_function
5176         code.
5177         (macro_define_object_internal): Use macro_define_internal.
5178         (macro_define_function): Likewise.
5179
5180 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5181
5182         * macrocmd.c (extract_identifier): Return
5183         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5184         callers.
5185
5186 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5187
5188         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5189
5190 2019-02-05  Tom Tromey  <tom@tromey.com>
5191
5192         * target.c (target_stack::unpush): Move assertion earlier.
5193
5194 2019-01-30  Tom Tromey  <tom@tromey.com>
5195
5196         PR python/23615:
5197         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5198         (gdbpy_parse_and_eval): Likewise.
5199         * python/python-internal.h (gdbpy_allow_threads): New class.
5200
5201 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5202
5203         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5204         (aarch64_fbsd_fpregmap): Move earlier.
5205         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5206         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5207         instead of individual calls to trad_frame_set_reg_addr.
5208         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5209         earlier.
5210         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5211         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5212         instead of individual calls to trad_frame_set_reg_addr.
5213
5214 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5215
5216         * CONTRIBUTE: Replace contribution list with wiki link.
5217
5218 2019-01-25  Tom Tromey  <tom@tromey.com>
5219
5220         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5221
5222 2019-01-25  Tom Tromey  <tom@tromey.com>
5223
5224         * xtensa-linux-nat.c: Fix common/ includes.
5225         * xml-support.h: Fix common/ includes.
5226         * xml-support.c: Fix common/ includes.
5227         * x86-linux-nat.c: Fix common/ includes.
5228         * windows-nat.c: Fix common/ includes.
5229         * varobj.h: Fix common/ includes.
5230         * varobj.c: Fix common/ includes.
5231         * value.c: Fix common/ includes.
5232         * valops.c: Fix common/ includes.
5233         * utils.c: Fix common/ includes.
5234         * unittests/xml-utils-selftests.c: Fix common/ includes.
5235         * unittests/utils-selftests.c: Fix common/ includes.
5236         * unittests/unpack-selftests.c: Fix common/ includes.
5237         * unittests/tracepoint-selftests.c: Fix common/ includes.
5238         * unittests/style-selftests.c: Fix common/ includes.
5239         * unittests/string_view-selftests.c: Fix common/ includes.
5240         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5241         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5242         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5243         * unittests/rsp-low-selftests.c: Fix common/ includes.
5244         * unittests/parse-connection-spec-selftests.c: Fix common/
5245         includes.
5246         * unittests/optional-selftests.c: Fix common/ includes.
5247         * unittests/offset-type-selftests.c: Fix common/ includes.
5248         * unittests/observable-selftests.c: Fix common/ includes.
5249         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5250         * unittests/memrange-selftests.c: Fix common/ includes.
5251         * unittests/memory-map-selftests.c: Fix common/ includes.
5252         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5253         * unittests/function-view-selftests.c: Fix common/ includes.
5254         * unittests/environ-selftests.c: Fix common/ includes.
5255         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5256         * unittests/common-utils-selftests.c: Fix common/ includes.
5257         * unittests/cli-utils-selftests.c: Fix common/ includes.
5258         * unittests/array-view-selftests.c: Fix common/ includes.
5259         * ui-file.c: Fix common/ includes.
5260         * tui/tui-io.c: Fix common/ includes.
5261         * tracepoint.h: Fix common/ includes.
5262         * tracepoint.c: Fix common/ includes.
5263         * tracefile-tfile.c: Fix common/ includes.
5264         * top.h: Fix common/ includes.
5265         * top.c: Fix common/ includes.
5266         * thread.c: Fix common/ includes.
5267         * target/waitstatus.h: Fix common/ includes.
5268         * target/waitstatus.c: Fix common/ includes.
5269         * target.h: Fix common/ includes.
5270         * target.c: Fix common/ includes.
5271         * target-memory.c: Fix common/ includes.
5272         * target-descriptions.c: Fix common/ includes.
5273         * symtab.h: Fix common/ includes.
5274         * symfile.c: Fix common/ includes.
5275         * stap-probe.c: Fix common/ includes.
5276         * spu-linux-nat.c: Fix common/ includes.
5277         * sparc-nat.c: Fix common/ includes.
5278         * source.c: Fix common/ includes.
5279         * solib.c: Fix common/ includes.
5280         * solib-target.c: Fix common/ includes.
5281         * ser-unix.c: Fix common/ includes.
5282         * ser-tcp.c: Fix common/ includes.
5283         * ser-pipe.c: Fix common/ includes.
5284         * ser-base.c: Fix common/ includes.
5285         * selftest-arch.c: Fix common/ includes.
5286         * s12z-tdep.c: Fix common/ includes.
5287         * rust-exp.y: Fix common/ includes.
5288         * rs6000-aix-tdep.c: Fix common/ includes.
5289         * riscv-tdep.c: Fix common/ includes.
5290         * remote.c: Fix common/ includes.
5291         * remote-notif.h: Fix common/ includes.
5292         * remote-fileio.h: Fix common/ includes.
5293         * remote-fileio.c: Fix common/ includes.
5294         * regcache.h: Fix common/ includes.
5295         * regcache.c: Fix common/ includes.
5296         * record-btrace.c: Fix common/ includes.
5297         * python/python.c: Fix common/ includes.
5298         * python/py-type.c: Fix common/ includes.
5299         * python/py-inferior.c: Fix common/ includes.
5300         * progspace.h: Fix common/ includes.
5301         * producer.c: Fix common/ includes.
5302         * procfs.c: Fix common/ includes.
5303         * proc-api.c: Fix common/ includes.
5304         * printcmd.c: Fix common/ includes.
5305         * ppc-linux-nat.c: Fix common/ includes.
5306         * parser-defs.h: Fix common/ includes.
5307         * osdata.c: Fix common/ includes.
5308         * obsd-nat.c: Fix common/ includes.
5309         * nat/x86-linux.c: Fix common/ includes.
5310         * nat/x86-linux-dregs.c: Fix common/ includes.
5311         * nat/x86-dregs.h: Fix common/ includes.
5312         * nat/x86-dregs.c: Fix common/ includes.
5313         * nat/ppc-linux.c: Fix common/ includes.
5314         * nat/mips-linux-watch.h: Fix common/ includes.
5315         * nat/mips-linux-watch.c: Fix common/ includes.
5316         * nat/linux-waitpid.c: Fix common/ includes.
5317         * nat/linux-ptrace.h: Fix common/ includes.
5318         * nat/linux-ptrace.c: Fix common/ includes.
5319         * nat/linux-procfs.c: Fix common/ includes.
5320         * nat/linux-personality.c: Fix common/ includes.
5321         * nat/linux-osdata.c: Fix common/ includes.
5322         * nat/linux-namespaces.c: Fix common/ includes.
5323         * nat/linux-btrace.h: Fix common/ includes.
5324         * nat/linux-btrace.c: Fix common/ includes.
5325         * nat/fork-inferior.c: Fix common/ includes.
5326         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5327         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5328         * nat/aarch64-linux.c: Fix common/ includes.
5329         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5330         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5331         * namespace.h: Fix common/ includes.
5332         * mips-linux-tdep.c: Fix common/ includes.
5333         * minsyms.c: Fix common/ includes.
5334         * mi/mi-parse.h: Fix common/ includes.
5335         * mi/mi-main.c: Fix common/ includes.
5336         * mi/mi-cmd-env.c: Fix common/ includes.
5337         * memrange.h: Fix common/ includes.
5338         * memattr.c: Fix common/ includes.
5339         * maint.h: Fix common/ includes.
5340         * maint.c: Fix common/ includes.
5341         * main.c: Fix common/ includes.
5342         * machoread.c: Fix common/ includes.
5343         * location.c: Fix common/ includes.
5344         * linux-thread-db.c: Fix common/ includes.
5345         * linux-nat.c: Fix common/ includes.
5346         * linux-fork.c: Fix common/ includes.
5347         * inline-frame.c: Fix common/ includes.
5348         * infrun.c: Fix common/ includes.
5349         * inflow.c: Fix common/ includes.
5350         * inferior.h: Fix common/ includes.
5351         * inferior.c: Fix common/ includes.
5352         * infcmd.c: Fix common/ includes.
5353         * inf-ptrace.c: Fix common/ includes.
5354         * inf-child.c: Fix common/ includes.
5355         * ia64-linux-nat.c: Fix common/ includes.
5356         * i387-tdep.c: Fix common/ includes.
5357         * i386-tdep.c: Fix common/ includes.
5358         * i386-linux-tdep.c: Fix common/ includes.
5359         * i386-linux-nat.c: Fix common/ includes.
5360         * i386-go32-tdep.c: Fix common/ includes.
5361         * i386-fbsd-tdep.c: Fix common/ includes.
5362         * i386-fbsd-nat.c: Fix common/ includes.
5363         * guile/scm-type.c: Fix common/ includes.
5364         * guile/guile.c: Fix common/ includes.
5365         * go32-nat.c: Fix common/ includes.
5366         * gnu-nat.c: Fix common/ includes.
5367         * gdbthread.h: Fix common/ includes.
5368         * gdbarch-selftests.c: Fix common/ includes.
5369         * gdb_usleep.c: Fix common/ includes.
5370         * gdb_select.h: Fix common/ includes.
5371         * gdb_bfd.c: Fix common/ includes.
5372         * gcore.c: Fix common/ includes.
5373         * fork-child.c: Fix common/ includes.
5374         * findvar.c: Fix common/ includes.
5375         * fbsd-nat.c: Fix common/ includes.
5376         * event-top.c: Fix common/ includes.
5377         * event-loop.c: Fix common/ includes.
5378         * dwarf2read.c: Fix common/ includes.
5379         * dwarf2loc.c: Fix common/ includes.
5380         * dwarf2-frame.c: Fix common/ includes.
5381         * dwarf-index-cache.c: Fix common/ includes.
5382         * dtrace-probe.c: Fix common/ includes.
5383         * disasm-selftests.c: Fix common/ includes.
5384         * defs.h: Fix common/ includes.
5385         * csky-tdep.c: Fix common/ includes.
5386         * cp-valprint.c: Fix common/ includes.
5387         * cp-support.h: Fix common/ includes.
5388         * cp-support.c: Fix common/ includes.
5389         * corelow.c: Fix common/ includes.
5390         * completer.h: Fix common/ includes.
5391         * completer.c: Fix common/ includes.
5392         * compile/compile.c: Fix common/ includes.
5393         * compile/compile-loc2c.c: Fix common/ includes.
5394         * compile/compile-cplus-types.c: Fix common/ includes.
5395         * compile/compile-cplus-symbols.c: Fix common/ includes.
5396         * command.h: Fix common/ includes.
5397         * cli/cli-dump.c: Fix common/ includes.
5398         * cli/cli-cmds.c: Fix common/ includes.
5399         * charset.c: Fix common/ includes.
5400         * build-id.c: Fix common/ includes.
5401         * btrace.h: Fix common/ includes.
5402         * btrace.c: Fix common/ includes.
5403         * breakpoint.h: Fix common/ includes.
5404         * breakpoint.c: Fix common/ includes.
5405         * ax.h:
5406         (enum agent_op): Fix common/ includes.
5407         * ax-general.c (struct aop_map): Fix common/ includes.
5408         * ax-gdb.c: Fix common/ includes.
5409         * auxv.c: Fix common/ includes.
5410         * auto-load.c: Fix common/ includes.
5411         * arm-tdep.c: Fix common/ includes.
5412         * arch/riscv.c: Fix common/ includes.
5413         * arch/ppc-linux-common.c: Fix common/ includes.
5414         * arch/i386.c: Fix common/ includes.
5415         * arch/arm.c: Fix common/ includes.
5416         * arch/arm-linux.c: Fix common/ includes.
5417         * arch/arm-get-next-pcs.c: Fix common/ includes.
5418         * arch/amd64.c: Fix common/ includes.
5419         * arch/aarch64.c: Fix common/ includes.
5420         * arch/aarch64-insn.c: Fix common/ includes.
5421         * arch-utils.c: Fix common/ includes.
5422         * amd64-windows-tdep.c: Fix common/ includes.
5423         * amd64-tdep.c: Fix common/ includes.
5424         * amd64-sol2-tdep.c: Fix common/ includes.
5425         * amd64-obsd-tdep.c: Fix common/ includes.
5426         * amd64-nbsd-tdep.c: Fix common/ includes.
5427         * amd64-linux-tdep.c: Fix common/ includes.
5428         * amd64-linux-nat.c: Fix common/ includes.
5429         * amd64-fbsd-tdep.c: Fix common/ includes.
5430         * amd64-fbsd-nat.c: Fix common/ includes.
5431         * amd64-dicos-tdep.c: Fix common/ includes.
5432         * amd64-darwin-tdep.c: Fix common/ includes.
5433         * agent.c: Fix common/ includes.
5434         * ada-lang.h: Fix common/ includes.
5435         * ada-lang.c: Fix common/ includes.
5436         * aarch64-tdep.c: Fix common/ includes.
5437
5438 2019-01-25  Tom Tromey  <tom@tromey.com>
5439
5440         * common/create-version.sh: Use common/version.h.
5441
5442 2019-01-24  Pedro Alves  <palves@redhat.com>
5443
5444         * infrun.c (signal_stop, signal_print, signal_program)
5445         (signal_catch, signal_pass): Now arrays instead of pointers.
5446         (update_signals_program_target, do_target_resume)
5447         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5448         * linux-nat.c (linux_nat_target::pass_signals)
5449         (linux_nat_target::create_inferior, linux_nat_target::attach):
5450         Adjust.
5451         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5452         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5453         * procfs.c (procfs_target::pass_signals): Adjust.
5454         * record-full.c (record_full_target::resume): Adjust.
5455         * remote.c (remote_target::pass_signals)
5456         (remote_target::program_signals): Adjust.
5457         * target-debug.h (target_debug_print_signals): Now takes a
5458         gdb::array_view as parameter.  Adjust.
5459         * target.h (target_ops) <pass_signals, program_signals>: Replace
5460         pointer and length parameters with gdb::array_view.
5461         (target_pass_signals, target_program_signals): Likewise.
5462         * target-delegates.c: Regenerate.
5463
5464 2019-01-24  Pedro Alves  <palves@redhat.com>
5465
5466         * common/forward-scope-exit.h
5467         (forward_scope_exit::forward_scope_exit): Pass arguments to
5468         m_bind_function directly, instead of creating a std::bind and
5469         copying that.
5470
5471 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5472
5473         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5474         for static members.
5475         (pass_in_v_vfp_candidate): Likewise.
5476
5477 2019-01-23  Tom Tromey  <tom@tromey.com>
5478             Pedro Alves  <palves@redhat.com>
5479
5480         * regcache.c (class regcache_invalidator): Remove.
5481         (regcache::raw_write): Use make_scope_exit.
5482
5483 2019-01-23  Tom Tromey  <tom@tromey.com>
5484
5485         * ui-out.h (class ui_out_emit_type): Update comment.
5486
5487 2019-01-23  Tom Tromey  <tom@tromey.com>
5488
5489         * infrun.c (fetch_inferior_event): Update comment.
5490
5491 2019-01-23  Tom Tromey  <tom@tromey.com>
5492             Pedro Alves  <palves@redhat.com>
5493
5494         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5495         parameter.
5496         (fetch_inferior_event): Use SCOPE_EXIT.
5497
5498
5499 2019-01-23  Tom Tromey  <tom@tromey.com>
5500             Pedro Alves  <palves@redhat.com>
5501
5502         * infrun.c (disable_thread_events): Delete.
5503         (stop_all_threads): Use SCOPE_EXIT.
5504
5505 2019-01-23  Tom Tromey  <tom@tromey.com>
5506             Pedro Alves  <palves@redhat.com>
5507
5508         * symfile.c: Include forward-scope-exit.h.
5509         (clear_symtab_users_cleanup): Replace forward declaration with
5510         a FORWARD_SCOPE_EXIT.
5511         (syms_from_objfile_1): Use the forward_scope_exit and
5512         gdb::optional instead of cleanup_function.
5513         (reread_symbols): Use the forward_scope_exit instead of
5514         cleanup_function.
5515         (clear_symtab_users_cleanup): Remove function.
5516
5517 2019-01-23  Tom Tromey  <tom@tromey.com>
5518             Pedro Alves  <palves@redhat.com>
5519
5520         * linux-nat.c: Include scope-exit.h.
5521         (cleanup_target_stop): Remove.
5522         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5523         SCOPE_EXIT.
5524
5525 2019-01-23  Tom Tromey  <tom@tromey.com>
5526             Pedro Alves  <palves@redhat.com>
5527
5528         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5529         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5530
5531 2019-01-23  Tom Tromey  <tom@tromey.com>
5532             Andrew Burgess  <andrew.burgess@embecosm.com>
5533             Pedro Alves  <palves@redhat.com>
5534
5535         * infrun.c (fetch_inferior_event): Use scope_exit.
5536         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5537         * top.c (execute_command): Use scope_exit.
5538         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5539         * utils.c (do_bpstat_clear_actions_cleanup)
5540         (make_bpstat_clear_actions_cleanup): Remove.
5541
5542 2019-01-23  Tom Tromey  <tom@tromey.com>
5543             Pedro Alves  <palves@redhat.com>
5544
5545         * infrun.c: Include "common/scope-exit.h"
5546         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5547         (wait_for_inferior): Use SCOPE_EXIT.
5548         (fetch_inferior_event): Use scope_exit.
5549
5550 2019-01-23  Tom Tromey  <tom@tromey.com>
5551             Pedro Alves  <palves@redhat.com>
5552
5553         * breakpoint.c (create_breakpoint): Remove cleanup.
5554
5555 2019-01-23  Tom Tromey  <tom@tromey.com>
5556             Andrew Burgess  <andrew.burgess@embecosm.com>
5557             Pedro Alves  <palves@redhat.com>
5558
5559 2019-01-23  Pedro Alves  <palves@redhat.com>
5560
5561         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5562
5563 2019-01-23  Pedro Alves  <palves@redhat.com>
5564             Andrew Burgess  <andrew.burgess@embecosm.com>
5565
5566         * gdbthread.h: Include "common/forward-scope-exit.h".
5567         (scoped_finish_thread_state): Redefine custom class in terms of
5568         forward_scope_exit.
5569
5570 2019-01-23  Pedro Alves  <palves@redhat.com>
5571             Andrew Burgess  <andrew.burgess@embecosm.com>
5572
5573         * common/forward-scope-exit.h: New file.
5574
5575 2019-01-23  Pedro Alves  <palves@redhat.com>
5576             Andrew Burgess  <andrew.burgess@embecosm.com>
5577             Tom Tromey  <tom@tromey.com>
5578
5579         * common/scope-exit.h: New file.
5580
5581 2019-01-23  Pedro Alves  <palves@redhat.com>
5582
5583         * common/preprocessor.h (ESC): Rename to ...
5584         (ESC_PARENS): ... this.
5585         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5586         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5587
5588 2019-01-23  Tom Tromey  <tom@tromey.com>
5589
5590         * language.h (class scoped_switch_to_sym_language_if_auto):
5591         Initialize m_lang in both cases.
5592
5593 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5594
5595         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5596         with XCNEW.
5597
5598 2019-01-22  Tom Tromey  <tom@tromey.com>
5599
5600         * corelow.c: Do not include sys/file.h.
5601
5602 2019-01-22  Tom Tromey  <tom@tromey.com>
5603
5604         * tui/tui-wingeneral.h: Include gdb_curses.h.
5605
5606 2019-01-22  Tom Tromey  <tom@tromey.com>
5607
5608         * source-cache.h (class source_cache) <get_source_lines,
5609         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5610
5611 2019-01-22  Tom Tromey  <tom@tromey.com>
5612
5613         * remote-fileio.h (struct remote_target): Declare.
5614
5615 2019-01-22  Tom Tromey  <tom@tromey.com>
5616
5617         * python/py-arch.c: Do not include py-ref.h.
5618         * python/py-bpevent.c: Do not include py-ref.h.
5619         * python/py-cmd.c: Do not include py-ref.h.
5620         * python/py-continueevent.c: Do not include py-ref.h.
5621         * python/py-event.h: Do not include py-ref.h.
5622         * python/py-evtregistry.c: Do not include py-ref.h.
5623         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5624         * python/py-frame.c: Do not include py-ref.h.
5625         * python/py-framefilter.c: Do not include py-ref.h.
5626         * python/py-function.c: Do not include py-ref.h.
5627         * python/py-infevents.c: Do not include py-ref.h.
5628         * python/py-linetable.c: Do not include py-ref.h.
5629         * python/py-objfile.c: Do not include py-ref.h.
5630         * python/py-param.c: Do not include py-ref.h.
5631         * python/py-prettyprint.c: Do not include py-ref.h.
5632         * python/py-progspace.c: Do not include py-ref.h.
5633         * python/py-symbol.c: Do not include py-ref.h.
5634         * python/py-symtab.c: Do not include py-ref.h.
5635         * python/py-type.c: Do not include py-ref.h.
5636         * python/py-unwind.c: Do not include py-ref.h.
5637         * python/py-utils.c: Do not include py-ref.h.
5638         * python/py-value.c: Do not include py-ref.h.
5639         * python/py-varobj.c: Do not include py-ref.h.
5640         * python/py-xmethods.c: Do not include py-ref.h.
5641         * python/python.c: Do not include py-ref.h.
5642         * varobj.c: Do not include py-ref.h.
5643
5644 2019-01-22  Tom Tromey  <tom@tromey.com>
5645
5646         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5647         keyword for bcache.
5648
5649 2019-01-22  Tom Tromey  <tom@tromey.com>
5650
5651         * compile/compile-cplus-types.c: Remove a comment by #include.
5652
5653 2019-01-22  Tom Tromey  <tom@tromey.com>
5654
5655         * compile/gcc-c-plugin.h: Include compile-internal.h.
5656
5657 2019-01-22  Tom Tromey  <tom@tromey.com>
5658
5659         * stabsread.c (EXTERN): Do not define.
5660         (symnum, next_symbol_text_func, processing_gcc_compilation)
5661         (within_function, global_sym_chain, global_stabs)
5662         (previous_stab_code, this_object_header_files)
5663         (n_this_object_header_files)
5664         (n_allocated_this_object_header_files): Define.
5665         * stabsread.h (EXTERN): Never define.  Use "extern".
5666
5667 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5668
5669         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5670         history_value.
5671
5672 2019-01-21  Tom Tromey  <tom@tromey.com>
5673
5674         * ui-out.c: Fix includes.
5675         * tui/tui-source.c: Fix includes.
5676         * target.c: Fix includes.
5677         * remote.c: Fix includes.
5678         * regcache.c: Fix includes.
5679         * python/py-block.c: Fix includes.
5680         * printcmd.c: Fix includes.
5681         * or1k-tdep.c: Fix includes.
5682         * mi/mi-main.c: Fix includes.
5683         * m32r-tdep.c: Fix includes.
5684         * csky-tdep.c: Fix includes.
5685         * compile/compile-cplus-types.c: Fix includes.
5686         * cli/cli-interp.c: Fix includes.
5687
5688 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5689
5690         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5691         for padding.
5692
5693 2019-01-16  Tom Tromey  <tom@tromey.com>
5694
5695         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5696         earlier.
5697         (struct objfile) <msymbols_range>: Move from top level.
5698         <msymbols>: New method.
5699         (class objfile_msymbols): Remove.
5700         * symtab.c (default_collect_symbol_completion_matches_break_on):
5701         Update.
5702         * symmisc.c (dump_msymbols): Update.
5703         * stabsread.c (scan_file_globals): Update.
5704         * objc-lang.c (info_selectors_command, info_classes_command)
5705         (find_methods): Update.
5706         * minsyms.c (find_solib_trampoline_target): Update.
5707         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5708         * coffread.c (coff_symfile_read): Update.
5709         * ada-lang.c (ada_lookup_simple_minsym)
5710         (ada_collect_symbol_completion_matches): Update.
5711
5712 2019-01-16  Tom Tromey  <tom@tromey.com>
5713
5714         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5715         type.  Remove no-argument constructor.
5716         <iterator::operator++>: Simplify.
5717         <begin>: Update.
5718         <end>: Use minimal_symbol_count.
5719
5720 2019-01-16  Tom Tromey  <tom@tromey.com>
5721
5722         * objfiles.h (struct objfile) <psymtabs>: New method.
5723         (class objfile_psymtabs): Remove.
5724         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5725         typedef.
5726         <range>: New method.
5727         (require_partial_symbols): Change return type.
5728         * psymtab.c (require_partial_symbols)
5729         (psym_expand_symtabs_matching): Update.
5730         * mdebugread.c (parse_partial_symbols): Update.
5731         * dbxread.c (dbx_end_psymtab): Update.
5732
5733 2019-01-15  Tom Tromey  <tom@tromey.com>
5734
5735         * symtab.c (lookup_objfile_from_block)
5736         (lookup_symbol_in_objfile_symtabs)
5737         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5738         (find_line_symtab, info_sources_command)
5739         (default_collect_symbol_completion_matches_break_on)
5740         (make_source_files_completion_list): Update.
5741         * symmisc.c (print_objfile_statistics, dump_objfile)
5742         (maintenance_print_symbols, maintenance_info_symtabs)
5743         (maintenance_check_symtabs, maintenance_info_line_tables):
5744         Update.
5745         * source.c (select_source_symtab)
5746         (forget_cached_source_info_for_objfile): Update.
5747         * objfiles.h (class objfile_compunits): Remove.
5748         (struct objfile) <compunits_range>: New typedef.
5749         (compunits): New method.
5750         * objfiles.c (objfile_relocate1): Update.
5751         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5752         * maint.c (count_symtabs_and_blocks): Update.
5753         * linespec.c (iterate_over_all_matching_symtabs): Update.
5754         * cp-support.c (add_symbol_overload_list_qualified): Update.
5755         * coffread.c (coff_symtab_read): Update.
5756         * ada-lang.c (add_nonlocal_symbols)
5757         (ada_collect_symbol_completion_matches)
5758         (ada_add_global_exceptions): Update.
5759
5760 2019-01-15  Tom Tromey  <tom@tromey.com>
5761
5762         * progspace.h (program_space) <objfiles_safe_range>: New
5763         typedef.
5764         <objfiles_safe>: New method.
5765         * objfiles.h (class all_objfiles_safe): Remove.
5766         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5767         * jit.c (jit_inferior_exit_hook): Update.
5768
5769 2019-01-17  Tom Tromey  <tom@tromey.com>
5770
5771         * progspace.h (program_space) <objfiles_range>: New typedef.
5772         <objfiles>: New method.
5773         <objfiles_head>: Rename from objfiles.
5774         (object_files): Update.
5775         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5776         * guile/scm-pretty-print.c
5777         (ppscm_find_pretty_printer_from_objfiles): Update.
5778         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5779         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5780         Update.
5781         * python/py-progspace.c (pspy_get_objfiles): Update.
5782         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5783         Update.
5784         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5785         (objfpy_lookup_objfile_by_build_id): Update.
5786         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5787         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5788         Update.
5789         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5790         (expand_symtab_containing_pc, lookup_objfile_from_block)
5791         (lookup_static_symbol, basic_lookup_transparent_type)
5792         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5793         (find_line_symtab, info_sources_command)
5794         (default_collect_symbol_completion_matches_break_on)
5795         (make_source_files_completion_list, find_main_name): Update.
5796         * symmisc.c (print_symbol_bcache_statistics)
5797         (print_objfile_statistics, maintenance_print_symbols)
5798         (maintenance_print_msymbols, maintenance_print_objfiles)
5799         (maintenance_info_symtabs, maintenance_check_symtabs)
5800         (maintenance_expand_symtabs, maintenance_info_line_tables):
5801         Update.
5802         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5803         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5804         (map_overlay_command, unmap_overlay_command)
5805         (simple_overlay_update, expand_symtabs_matching)
5806         (map_symbol_filenames): Update.
5807         * symfile-debug.c (set_debug_symfile): Update.
5808         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5809         Update.
5810         * source.c (select_source_symtab, forget_cached_source_info):
5811         Update.
5812         * solib.c (solib_read_symbols): Update.
5813         * solib-spu.c (append_ocl_sos): Update.
5814         * psymtab.c (maintenance_print_psymbols)
5815         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5816         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5817         * printcmd.c (info_symbol_command): Update.
5818         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5819         Update.
5820         * objfiles.h (class all_objfiles): Remove.
5821         * objfiles.c (have_partial_symbols, have_full_symbols)
5822         (have_minimal_symbols, qsort_cmp, update_section_map)
5823         (shared_objfile_contains_address_p)
5824         (default_iterate_over_objfiles_in_search_order): Update.
5825         * objc-lang.c (info_selectors_command, info_classes_command)
5826         (find_methods): Update.
5827         * minsyms.c (find_solib_trampoline_target): Update.
5828         * maint.c (maintenance_info_sections)
5829         (maintenance_translate_address, count_symtabs_and_blocks):
5830         Update.
5831         * main.c (captured_main_1): Update.
5832         * linux-thread-db.c (try_thread_db_load_from_pdir)
5833         (has_libpthread): Update.
5834         * linespec.c (iterate_over_all_matching_symtabs)
5835         (search_minsyms_for_name): Update.
5836         * jit.c (jit_find_objf_with_entry_addr): Update.
5837         * hppa-tdep.c (find_unwind_entry)
5838         (hppa_lookup_stub_minimal_symbol): Update.
5839         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5840         Update.
5841         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5842         (elf_gnu_ifunc_resolve_by_got): Update.
5843         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5844         * dwarf-index-write.c (save_gdb_index_command): Update.
5845         * cp-support.c (add_symbol_overload_list_qualified): Update.
5846         * breakpoint.c (create_overlay_event_breakpoint)
5847         (create_longjmp_master_breakpoint)
5848         (create_std_terminate_master_breakpoint)
5849         (create_exception_master_breakpoint): Update.
5850         * blockframe.c (find_pc_partial_function): Update.
5851         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5852         (ada_collect_symbol_completion_matches)
5853         (ada_add_global_exceptions): Update.
5854
5855 2019-01-17  Tom Tromey  <tom@tromey.com>
5856
5857         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5858         declare VEC.
5859         (solib_target_parse_libraries): Change return type.
5860         (library_list_start_segment, library_list_start_section)
5861         (library_list_end_library, library_list_start_library); Update.
5862         (solib_target_free_library_list): Remove.
5863         (solib_target_parse_libraries): Remove cleanup.  Change return
5864         type.
5865         (solib_target_current_sos): Update.
5866
5867 2019-01-17  Tom Tromey  <tromey@bapiya>
5868
5869         * valprint.c: Replace "the the" with "the".
5870         * symtab.c: Replace "the the" with "the".
5871         * solib.c: Replace "the the" with "the".
5872         * solib-dsbt.c: Replace "the the" with "the".
5873         * linespec.c: Replace "the the" with "the".
5874         * dwarf2loc.h: Replace "the the" with "the".
5875         * amd64-windows-tdep.c: Replace "the the" with "the".
5876         * aarch64-tdep.c: Replace "the the" with "the".
5877
5878 2019-01-16  Keith Seitz  <keiths@redhat.com>
5879
5880         PR gdb/23773
5881         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5882         <builder>: Rename to ..
5883         <m_builder>: ... this and make private.
5884         (dwarf2_cu::get_builder): New method.  Change all users of
5885         `builder' to use this method.
5886         (dwarf2_start_symtab): Move to ...
5887         (dwarf2_cu::start_symtab): ... here.  Update all callers
5888         (setup_type_unit_groups): Move to ...
5889         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5890         callers.
5891         (dwarf2_cu::reset_builder): New method.
5892         (process_full_compunit, process_full_type_unit): Use
5893         dwarf2_cu::reset_builder.
5894         (follow_die_offset): Record the ancestor CU if it is different
5895         from the followed DIE's CU.
5896         (follow_die_sig_1): Likewise.
5897
5898 2019-01-15  Tom Tromey  <tom@tromey.com>
5899
5900         * remote.c (class remote_state) <buf>: Now a char_vector.
5901         <buf_size>: Remove.
5902         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5903         parameter.
5904         (remote_target::getpkt_or_notif_sane_1)
5905         (remote_target::getpkt_sane)
5906         (remote_target::getpkt_or_notif_sane): Likewise.
5907         (class remote_target) <putpkt>: New overload.
5908         (remote_target::read_frame): Change type of "buf_p".  Remove
5909         sizeof_p parameter.
5910         (packet_ok): New overload.
5911         (packet_check_result): New overload.
5912         Update all uses.
5913
5914 2019-01-14  Tom Tromey  <tom@tromey.com>
5915
5916         * remote-notif.c (handle_notification, remote_notif_ack)
5917         (remote_notif_parse): Make "buf" const.
5918         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5919         const.
5920         (remote_notif_parse, remote_notif_ack, handle_notification):
5921         Likewise.
5922         * remote.c (remote_notif_stop_parse): Make "buf" const.
5923         (remote_target::remote_parse_stop_reply): Make "buf" const.
5924         (remote_notif_stop_ack): Make "buf" const.
5925
5926 2019-01-14  Tom Tromey  <tom@tromey.com>
5927
5928         * remote.c (remote_console_output): Make parameter const.
5929
5930 2019-01-14  Tom Tromey  <tom@tromey.com>
5931
5932         * target-debug.h (target_debug_print_signals): Constify.
5933         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5934         * procfs.c (procfs_target::pass_signals): Update.
5935         * linux-nat.c (linux_nat_target::pass_signals): Update.
5936         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5937         * target-delegates.c: Rebuild.
5938         * remote.c (remote_target::program_signals): Update.
5939         (remote_target::pass_signals): Update.
5940         * target.c (target_pass_signals): Constify argument.
5941         (target_program_signals): Likewise.
5942         * target.h (struct target_ops) <pass_signals, program_signals>:
5943         Constify argument.
5944         (target_pass_signals, target_program_signals): Constify argument.
5945
5946 2019-01-14  Tom Tromey  <tom@tromey.com>
5947
5948         PR tui/28819:
5949         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5950
5951 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5952
5953         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5954         field.
5955         * rs6000-tdep.c: Include reggroups.h.
5956         (IS_V_ALIAS_PSEUDOREG): Define.
5957         (rs6000_register_name): Return names for the "vX" aliases.
5958         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5959         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5960         aliases.  Call default_register_reggroup_p for all other
5961         pseudo-registers.
5962         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5963         New functions.
5964         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5965         Handle "vX" aliases.
5966         (v_alias_pseudo_register_collect): New function.
5967         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5968         (rs6000_gdbarch_init): Initialize "vX" aliases as
5969         pseudo-registers.  Restore registration of
5970         rs6000_pseudo_register_reggroup_p with
5971         set_tdesc_pseudo_register_reggroup_p.
5972
5973 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5974
5975         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5976         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5977         set_gdbarch_num_pseudo_regs.
5978
5979 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5980
5981         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5982         Remove arg prefixname, add do_set and do_show.
5983         Add member functions set_list and show_list.
5984         * cli/cli-style.c (class cli_style_option): Update accordingly.
5985         (style_set_list): Move to file scope.
5986         (style_show_list): Likewise.
5987         (set_style): Call help_list.
5988         (show_style): Call cmd_show_list.
5989         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5990         Update to use the new macro.
5991
5992 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5993
5994         * ada-lang.c (_initialize_ada_language): Expand the help text
5995         for the "catch exception" command.
5996
5997 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5998
5999         * symtab.c (matching_obj_sections): Initialize obj,
6000         declare it closer to its usage.
6001
6002 2019-01-10  Tom Tromey  <tom@tromey.com>
6003
6004         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6005         (basic_inf_threads_range): Remove.
6006         (inf_threads_range, inf_non_exited_threads_range)
6007         (safe_inf_threads_range): Use next_adapter.
6008
6009 2019-01-10  Keith Seitz  <keiths@redhat.com>
6010
6011         PR gdb/23712
6012         PR symtab/23010
6013         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6014         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6015
6016 2019-01-10  Keith Seitz  <keiths@redhat.com>
6017
6018         PR gdb/23712
6019         PR symtab/23010
6020         * dictionary.c (pending_to_vector): Remove.
6021         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6022         Remove _1 suffix, replacing functions of the same name.  Update
6023         all callers.
6024         (dict_create_hashed, dict_create_hashed_expandable)
6025         (dict_create_linear, dict_create_linear_expandable, dict_free)
6026         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6027         Make functions static.
6028
6029 2019-01-10  Keith Seitz  <keiths@redhat.com>
6030
6031         PR gdb/23712
6032         PR symtab/23010
6033         * dictionary.h (struct dictionary): Replace declaration with
6034         multidictionary.
6035         (dict_create_hashed, dict_create_hashed_expandable)
6036         (dict_create_linear, dict_create_linear_expandable)
6037         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6038         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6039         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6040         taking multidictionary argument.
6041         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6042         * block.h (struct block) <dict>: Change to multidictionary
6043         and rename `multidict'.
6044         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6045         symmisc.c: Update all dictionary references to multidictionary.
6046
6047 2019-01-10  Keith Seitz  <keiths@redhat.com>
6048
6049         PR gdb/23712
6050         PR symtab/23010
6051         * dictionary.c: Include unordered_map.
6052         (pending_to_vector): New function.
6053         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6054         Rewrite the non-"_1" functions to take vector instead
6055         of linked list.
6056         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6057         "new" _1 versions of the same name.
6058         (multidictionary): Define.
6059         (std::hash<enum language): New definition.
6060         (collate_pending_symbols_by_language, mdict_create_hashed)
6061         (mdict_create_hashed_expandable, mdict_create_linear)
6062         (mdict_create_linear_expandable, mdict_free)
6063         (find_language_dictionary, create_new_language_dictionary)
6064         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6065         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6066         (mdict_size, mdict_empty): New functions.
6067         * dictionary.h (mdict_iterator): Define.
6068
6069 2019-01-10  Pedro Alves  <palves@redhat.com>
6070
6071         * breakpoint.c (read_uploaded_action)
6072         (create_tracepoint_from_upload): Adjust to use
6073         gdb::unique_xmalloc_ptr.
6074         * ctf.c (ctf_write_uploaded_tp):
6075         (SET_ARRAY_FIELD): Use emplace_back.
6076         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6077         * tracefile-tfile.c (tfile_write_uploaded_tp):
6078         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6079         gdb::unique_xmalloc_ptr.
6080         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6081         at_string, cond_string, cmd_strings>: Replace char pointers
6082         with gdb::unique_xmalloc_ptr.
6083
6084 2019-01-10  Pedro Alves  <palves@redhat.com>
6085
6086         * solib-target.c (library_list_start_library): Don't xstrdup name.
6087
6088 2019-01-10  Pedro Alves  <palves@redhat.com>
6089
6090         * mdebugread.c (parse_partial_symbols): Use
6091         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6092
6093 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6094
6095         * linux-fork.c (scoped_switch_fork_info)
6096         <~scoped_switch_fork_info>: Fix incorrect variable name.
6097
6098 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6099
6100         * linux-fork.c (scoped_switch_fork_info)
6101         <scoped_switch_fork_info>: Make explicit.
6102         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6103
6104 2019-01-10  Tom Tromey  <tom@tromey.com>
6105
6106         * objfiles.h (objfile::reset_psymtabs): Update.
6107         * objfiles.c (objfile::objfile): Update.
6108         * psymtab.h (psymtab_storage::obstack): Update.
6109         (psymtab_storage::m_obstack): Use gdb::optional.
6110         (class psymtab_storage): Update comment.  Remove objfile
6111         parameter.
6112         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6113
6114 2019-01-10  Tom Tromey  <tom@tromey.com>
6115
6116         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6117         <free_psymtabs>: Now private.
6118         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6119         (allocate_psymtab): Use new method.
6120
6121 2019-01-10  Tom Tromey  <tom@tromey.com>
6122
6123         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6124         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6125         * mdebugread.c (parse_partial_symbols): Use
6126         allocate_dependencies.
6127         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6128         allocate_dependencies.
6129         (process_psymtab_comp_unit_reader)
6130         (build_type_psymtab_dependencies): Likewise.
6131         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6132
6133 2019-01-10  Tom Tromey  <tom@tromey.com>
6134
6135         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6136         PSYMBOL_SET_LANGUAGE.
6137         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6138
6139 2019-01-10  Tom Tromey  <tom@tromey.com>
6140
6141         * psymtab.h (psymtab_storage::obstack): New method.
6142         <m_obstack>: Rename from obstack; now private.
6143         * psymtab.c (psymtab_storage): Update.
6144         * dwarf2read.c (create_addrmap_from_index)
6145         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6146         Update.
6147
6148 2019-01-10  Tom Tromey  <tom@tromey.com>
6149
6150         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6151         * objfiles.h (objfile::reset_psymtabs): New method.
6152
6153 2019-01-10  Tom Tromey  <tom@tromey.com>
6154
6155         * symmisc.c (print_symbol_bcache_statistics): Update.
6156         (print_objfile_statistics): Update.
6157         * symfile.c (reread_symbols): Update.
6158         * psymtab.h (class psymtab_storage): New.
6159         * psymtab.c (psymtab_storage): New constructor.
6160         (~psymtab_storage): New destructor.
6161         (require_partial_symbols): Update.
6162         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6163         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6164         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6165         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6166         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6167         (start_psymtab_common, end_psymtab_common)
6168         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6169         (allocate_psymtab): Update.
6170         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6171         Update.
6172         (dump_psymtab_addrmap, maintenance_print_psymbols)
6173         (maintenance_check_psymtabs): Update.
6174         (class objfile_psymtabs): Move to objfiles.h.
6175         * psympriv.h (discard_psymtab): Now inline.
6176         (psymtab_discarder::psymtab_discarder): Update.
6177         (psymtab_discarder::~psymtab_discarder): Update.
6178         (ALL_OBJFILE_PSYMTABS): Rewrite.
6179         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6180         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6181         Remove fields.
6182         <partial_symtabs>: New field.
6183         (class objfile_psymtabs): Move from psymtab.h.  Update.
6184         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6185         psymbol_cache.
6186         (objfile::~objfile): Don't destroy psymbol_cache.
6187         * mdebugread.c (parse_partial_symbols): Update.
6188         * dwarf2read.c (create_addrmap_from_index)
6189         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6190         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6191         (add_partial_subprogram, dwarf2_ranges_read): Update.
6192         * dwarf-index-write.c (write_address_map)
6193         (write_one_signatured_type, recursively_write_psymbols)
6194         (class debug_names, class debug_names, write_psymtabs_to_index):
6195         Update.
6196
6197 2019-01-10  Tom Tromey  <tom@tromey.com>
6198
6199         * symtab.h (SYMBOL_SET_NAMES): Update.
6200         (symbol_set_names): Update.
6201         (MSYMBOL_SET_NAMES): Update.
6202         * symtab.c (symbol_set_names): Change argument to be an
6203         objfile_per_bfd_storage.
6204         * psymtab.c (add_psymbol_to_bcache): Update.
6205         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6206
6207 2019-01-10  Tom Tromey  <tom@tromey.com>
6208
6209         * symtab.c (create_demangled_names_hash): Change argument to be an
6210         objfile_per_bfd_storage.
6211         (symbol_set_names): Update.
6212
6213 2019-01-10  Tom Tromey  <tom@tromey.com>
6214
6215         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6216         init_psymbol_list.
6217         * psymtab.c (init_psymbol_list): Do nothing if already called.
6218         * psympriv.h (init_psymbol_list): Add comment.
6219         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6220         init_psymbol_list.
6221         * dbxread.c (dbx_symfile_read): Unconditionally call
6222         init_psymbol_list.
6223
6224 2019-01-10  Tom Tromey  <tom@tromey.com>
6225
6226         * xcoffread.c (scan_xcoff_symtab): Update.
6227         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6228         "where".
6229         * mdebugread.c (parse_partial_symbols)
6230         (handle_psymbol_enumerators): Update.
6231         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6232         * dbxread.c (read_dbx_symtab): Update.
6233         * psympriv.h (psymbol_placement): New enum.
6234         (add_psymbol_to_list): Update.
6235
6236 2019-01-10  Tom Tromey  <tom@tromey.com>
6237
6238         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6239         static_psymbols parameters.
6240         (scan_xcoff_symtab): Update.
6241         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6242         static_psymbols parameters.
6243         * psympriv.h (start_psymtab_common): Update.
6244         * mdebugread.c (parse_partial_symbols): Update.
6245         * dwarf2read.c (create_partial_symtab): Update.
6246         * dbxread.c (read_dbx_symtab): Update.
6247         (start_psymtab): Remove global_psymbols and static_psymbols
6248         parameters.
6249
6250 2019-01-10  Tom Tromey  <tom@tromey.com>
6251
6252         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6253         * psymtab.c (allocate_psymtab): Add comment.
6254         * psympriv.h (allocate_psymtab): Add comment.
6255         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6256         initializations.
6257         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6258
6259 2019-01-10  Tom Tromey  <tom@tromey.com>
6260
6261         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6262         Don't declare.
6263         * mipsread.c: Include mdebugread.h.
6264         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6265         Declare.
6266         * elfread.c: Include mdebugread.h.
6267
6268 2019-01-09  Tom Tromey  <tom@tromey.com>
6269
6270         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6271         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6272         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6273         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6274         (psym_lookup_symbol, psym_find_last_source_symtab)
6275         (psym_forget_cached_source_info, psym_print_stats)
6276         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6277         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6278         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6279         (psym_find_compunit_symtab_by_address)
6280         (maintenance_print_psymbols, maintenance_info_psymtabs)
6281         (maintenance_check_psymtabs): Use ranged for.
6282         * psymtab.h (class objfile_psymtabs): New.
6283         (require_partial_symbols): Return objfile_psymtabs.
6284         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6285
6286 2019-01-09  Tom Tromey  <tom@tromey.com>
6287
6288         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6289         (find_pc_mapped_section, list_overlays_command)
6290         (map_overlay_command, unmap_overlay_command)
6291         (simple_overlay_update): Use all_objfiles.
6292         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6293         * printcmd.c (info_symbol_command): Use all_objfiles.
6294         * objfiles.h (ALL_OBJSECTIONS): Remove.
6295         * maint.c (maintenance_translate_address): Use all_objfiles.
6296         * gcore.c (gcore_create_callback): Use all_objfiles.
6297         (objfile_find_memory_regions): Likewise.
6298
6299 2019-01-09  Tom Tromey  <tom@tromey.com>
6300
6301         * symtab.c (find_line_symtab, info_sources_command)
6302         (make_source_files_completion_list): Use objfile_compunits.
6303         * source.c (select_source_symtab): Use objfile_compunits.
6304         * objfiles.h (struct objfile): Update comment.
6305         (ALL_OBJFILES): Remove.
6306         (ALL_FILETABS): Remove.
6307         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6308         objfile_compunits.
6309
6310 2019-01-09  Tom Tromey  <tom@tromey.com>
6311
6312         * symmisc.c (print_objfile_statistics, dump_objfile)
6313         (maintenance_print_symbols): Use compunit_filetabs.
6314         * source.c (forget_cached_source_info_for_objfile): Use
6315         compunit_filetabs.
6316         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6317         (ALL_FILETABS): Use compunit_filetabs.
6318         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6319         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6320
6321 2019-01-09  Tom Tromey  <tom@tromey.com>
6322
6323         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6324         (compunit_filetabs): New.
6325         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6326         compunit_filetabs.
6327         (info_sources_command, make_source_files_completion_list): Remove
6328         declaration.
6329         * symmisc.c (print_objfile_statistics, dump_objfile)
6330         (maintenance_print_symbols): Remove declaration.
6331         (maintenance_info_symtabs): Use compunit_filetabs.
6332         (maintenance_info_line_tables): Likewise.
6333         * source.c (select_source_symtab): Change local variable name.
6334         (forget_cached_source_info_for_objfile): Remove declaration.
6335         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6336         * objfiles.c (objfile_relocate1): Remove declaration.
6337         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6338         declaration.
6339         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6340         * coffread.c (coff_symtab_read): Remove declaration.
6341         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6342         compunit_filetabs.
6343
6344 2019-01-09  Tom Tromey  <tom@tromey.com>
6345
6346         * symtab.c (lookup_objfile_from_block)
6347         (find_pc_sect_compunit_symtab, search_symbols)
6348         (default_collect_symbol_completion_matches_break_on): Use
6349         objfile_compunits.
6350         * objfiles.h (ALL_COMPUNITS): Remove.
6351         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6352         * cp-support.c (add_symbol_overload_list_qualified): Use
6353         objfile_compunits.
6354         * ada-lang.c (ada_collect_symbol_completion_matches)
6355         (ada_add_global_exceptions): Use objfile_compunits.
6356
6357 2019-01-09  Tom Tromey  <tom@tromey.com>
6358
6359         * source.c (select_source_symtab)
6360         (forget_cached_source_info_for_objfile): Remove declaration.
6361         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6362         declaration.
6363         * maint.c (count_symtabs_and_blocks): Remove declaration.
6364         * cp-support.c (add_symbol_overload_list_qualified): Remove
6365         declaration.
6366         * coffread.c (coff_symtab_read): Remove declaration.
6367         * symtab.c (lookup_symbol_in_objfile_symtabs)
6368         (basic_lookup_transparent_type_1): Use objfile_compunits.
6369         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6370         (info_sources_command, search_symbols)
6371         (default_collect_symbol_completion_matches_break_on)
6372         (make_source_files_completion_list): Remove declaration.
6373         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6374         (ada_collect_symbol_completion_matches)
6375         (ada_add_global_exceptions): Remove declaration.
6376         * linespec.c (iterate_over_all_matching_symtabs): Use
6377         objfile_compunits.
6378         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6379         (class objfile_compunits): New.
6380         (ALL_COMPUNITS): Use objfile_compunits.
6381         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6382         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6383         objfile_compunits.
6384         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6385
6386 2019-01-09  Tom Tromey  <tom@tromey.com>
6387
6388         * symtab.c (search_symbols)
6389         (default_collect_symbol_completion_matches_break_on): Use
6390         objfile_msymbols.
6391         * ada-lang.c (ada_lookup_simple_minsym)
6392         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6393         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6394         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6395         objfile_msymbols.
6396         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6397         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6398         * objc-lang.c (find_methods): Use objfile_msymbols.
6399         (info_selectors_command, info_classes_command): Likewise.
6400         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6401         * objfiles.h (class objfile_msymbols): New.
6402         (ALL_OBJFILE_MSYMBOLS): Remove.
6403         (ALL_MSYMBOLS): Remove.
6404
6405 2019-01-09  Tom Tromey  <tom@tromey.com>
6406
6407         * common/next-iterator.h (next_adapter): Add Iterator template
6408         parameter.
6409         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6410         (class all_objfiles_safe): New.
6411         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6412         * objfiles.c (put_objfile_before): Update comment.
6413         (add_separate_debug_objfile): Likewise.
6414         (free_all_objfiles): Use all_objfiles_safe.
6415         (objfile_purge_solibs): Likewise.
6416
6417 2019-01-09  Tom Tromey  <tom@tromey.com>
6418
6419         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6420         (expand_symtab_containing_pc, lookup_static_symbol)
6421         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6422         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6423         all_objfiles.
6424         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6425         * breakpoint.c (create_overlay_event_breakpoint)
6426         (create_longjmp_master_breakpoint)
6427         (create_std_terminate_master_breakpoint)
6428         (create_exception_master_breakpoint): Use all_objfiles.
6429         * linux-thread-db.c (try_thread_db_load_from_pdir)
6430         (has_libpthread): Use all_objfiles.
6431         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6432         * linespec.c (iterate_over_all_matching_symtabs)
6433         (search_minsyms_for_name): Use all_objfiles.
6434         * maint.c (maintenance_info_sections): Use all_objfiles.
6435         * main.c (captured_main_1): Use all_objfiles.
6436         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6437         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6438         * guile/scm-pretty-print.c
6439         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6440         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6441         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6442         (maintenance_print_msymbols): Use all_objfiles.
6443         * source.c (select_source_symtab): Use all_objfiles.
6444         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6445         * symfile.c (remove_symbol_file_command)
6446         (expand_symtabs_matching, map_symbol_filenames): Use
6447         all_objfiles.
6448         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6449         all_objfiles.
6450         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6451         * objc-lang.c (find_methods): Use all_objfiles.
6452         * objfiles.c (have_partial_symbols, have_full_symbols)
6453         (have_minimal_symbols, qsort_cmp)
6454         (default_iterate_over_objfiles_in_search_order): Use
6455         all_objfiles.
6456         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6457         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6458         (maintenance_check_psymtabs): Use all_objfiles.
6459         (ALL_PSYMTABS): Remove.
6460         * compile/compile-object-run.c (do_module_cleanup): Use
6461         all_objfiles.
6462         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6463         * cp-support.c (add_symbol_overload_list_qualified): Use
6464         all_objfiles.
6465         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6466         Use all_objfiles.
6467         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6468         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6469         all_objfiles.
6470         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6471         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6472         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6473         Uses all_objfiles.
6474         * solib.c (solib_read_symbols): Use all_objfiles
6475
6476 2019-01-09  Tom Tromey  <tom@tromey.com>
6477
6478         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6479         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6480         all_objfiles.
6481         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6482         * symmisc.c (print_symbol_bcache_statistics)
6483         (print_objfile_statistics, maintenance_print_objfiles)
6484         (maintenance_info_symtabs, maintenance_check_symtabs)
6485         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6486         all_objfiles.
6487         * source.c (forget_cached_source_info): Use all_objfiles.
6488         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6489         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6490         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6491         * objfiles.c (update_section_map): Use all_objfiles.
6492         (shared_objfile_contains_address_p): Likewise.
6493         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6494         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6495
6496 2019-01-09  Tom Tromey  <tom@tromey.com>
6497
6498         * common/next-iterator.h: New file.
6499         * objfiles.h (class all_objfiles): New.
6500         (struct objfile_iterator): New.
6501
6502 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6503
6504         * NEWS: Move the description of the changed "frame", "select-frame",
6505          and "info frame" commands to the Changed commands section.
6506
6507 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6508
6509         * gdbtypes.c (check_stub_method_group): Remove handling of old
6510         mangling schemes.
6511         * linespec.c (find_methods): Likewise.
6512         * stabsread.c (read_member_functions): Likewise.
6513         * valops.c (search_struct_method): Likewise.
6514         (value_struct_elt_for_reference): Likewise.
6515         * NEWS: Mention this change.
6516
6517 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6518
6519         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6520         print_source_lines.
6521         * source.c (print_source_lines_base): Update line number check.
6522         (print_source_lines): New function.
6523         (source_lines_range::source_lines_range): New function.
6524         * source.h (class source_lines_range): New class.
6525         (print_source_lines): New declaration.
6526
6527 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6528
6529         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6530
6531 2019-01-08  Tom Tromey  <tom@tromey.com>
6532             Simon Marchi  <simon.marchi@ericsson.com>
6533
6534         PR gdb/24060
6535         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6536         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6537         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6538         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6539         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6540         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6541
6542 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6543
6544         * source.c (select_source_symtab): Move header comment to
6545         declaration in source.h.
6546         (forget_cached_source_info_for_objfile): Likewise.
6547         (forget_cached_source_info): Likewise.
6548         (identify_source_line): Likewise.
6549         * source.h (identify_source_line): Move declaration from symtab.h
6550         and add comment from source.c
6551         (print_source_lines): Likewise.
6552         (forget_cached_source_info_for_objfile): Likewise.
6553         (forget_cached_source_info): Likewise.
6554         (select_source_symtab): Likewise.
6555         (enum print_source_lines_flag): Move definition from symtab.h.
6556         * symtab.h (identify_source_line): Move declaration to source.h.
6557         (print_source_lines): Likewise.
6558         (forget_cached_source_info_for_objfile): Likewise.
6559         (forget_cached_source_info): Likewise.
6560         (select_source_symtab): Likewise.
6561         (enum print_source_lines_flag): Move definition to source.h.
6562         * tui/tui-hooks.c: Add 'source.h' include.
6563
6564 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6565
6566         * source.c (print_source_lines_base): Handle requests to print
6567         reverse line number sequences, and guard against empty lines
6568         string.
6569
6570 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6571
6572         * source.c (print_source_lines_base): Fix skip of '\r' if next
6573         character is '\n'.
6574
6575 2019-01-06  Tom Tromey  <tom@tromey.com>
6576
6577         * c-exp.y (struct c_parse_state) <macro_original_text,
6578         expansion_obstack>: New member.
6579         (macro_original_text, expansion_obstack): Remove globals.
6580         (scan_macro_expansion, scanning_macro_expansion)
6581         (finished_macro_expansion): Update.
6582         (scan_macro_cleanup): Remove.
6583         (yylex, c_parse): Update.
6584
6585 2019-01-06  Tom Tromey  <tom@tromey.com>
6586
6587         * c-exp.y (struct c_parse_state) <strings>: New member.
6588         (operator_stoken): Update.
6589
6590 2019-01-06  Tom Tromey  <tom@tromey.com>
6591
6592         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6593         (union type_stack_elt) <typelist_val>: Now a pointer to
6594         std::vector.
6595         (type_stack_cleanup): Don't declare.
6596         (push_typelist): Update.
6597         * parse.c (pop_typelist): Return a std::vector.
6598         (push_typelist): Take a std::vector.
6599         (follow_types): Update.  Do not free args.
6600         (type_stack_cleanup): Remove.
6601         * c-exp.y (struct c_parse_state): New.
6602         (cpstate): New global.
6603         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6604         (nonempty_typelist): Update.
6605         (func_mod): Create a new vector.
6606         (c_parse): Create a c_parse_state.
6607         (check_parameter_typelist): Do not delete params.
6608         (function_method): Update.  Do not delete type_list.
6609
6610 2019-01-06  Tom Tromey  <tom@tromey.com>
6611
6612         PR gdb/28155:
6613         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6614         check_typedef.
6615         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6616         (print_return_value): Likewise.
6617
6618 2019-01-05  Tom Tromey  <tom@tromey.com>
6619
6620         * contrib/cleanup_check.py: Remove.
6621         * contrib/gcc-with-excheck: Remove.
6622         * contrib/exsummary.py: Remove.
6623         * contrib/excheck.py: Remove.
6624
6625 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6626
6627         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6628         NULL. Initialize tpprev to NULL instead of assigning it
6629         to NULL on the next statement.
6630         * windows-nat.c (windows_delete_thread): Remove check for
6631         main_thread_id before printing thread exit notifications.
6632         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6633         Remove thread ID check against main_thread_id.
6634         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6635         windows_delete_thread.
6636         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6637
6638 2019-01-04  Tom Tromey  <tom@tromey.com>
6639
6640         * compile/compile.c (_initialize_compile): Use upper case for
6641         metasyntactic variables.
6642         * symmisc.c (_initialize_symmisc): Use upper case for
6643         metasyntactic variables.
6644         * psymtab.c (_initialize_psymtab): Use upper case for
6645         metasyntactic variables.
6646         * demangle.c (demangle_command): Use upper case for metasyntactic
6647         variables.
6648         (_initialize_demangler): Likewise.
6649         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6650         variables.
6651
6652 2019-01-03  Tom Tromey  <tom@tromey.com>
6653
6654         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6655
6656 2019-01-03  Tom Tromey  <tom@tromey.com>
6657
6658         * python/py-symtab.c (salpy_str): Update.
6659         (struct salpy_sal_object) <symtab>: Now a PyObject.
6660         (salpy_dealloc): Update.
6661         (del_objfile_sal): Use gdbpy_ref.
6662
6663 2019-01-03  Tom Tromey  <tom@tromey.com>
6664
6665         * python/py-type.c (convert_field): Use new_reference.  Return
6666         gdbpy_ref.
6667         (make_fielditem): Return gdbpy_ref.
6668         (typy_fields): Update.
6669         (typy_getitem): Update.
6670         (field_name): Return gdbpy_ref.  Use new_reference.
6671         (typy_iterator_iternext): Update.
6672
6673 2019-01-03  Tom Tromey  <tom@tromey.com>
6674
6675         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6676
6677 2019-01-03  Tom Tromey  <tom@tromey.com>
6678
6679         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6680         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6681         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6682         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6683         (pspy_set_type_printers): Likewise.
6684         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6685         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6686         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6687         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6688         (objfpy_set_type_printers): Likewise.
6689
6690 2019-01-03  Tom Tromey  <tom@tromey.com>
6691
6692         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6693         (gdbpy_print_stack): Use gdbpy_err_fetch.
6694         * python/python-internal.h (class gdbpy_err_fetch): New class.
6695         (class gdbpy_enter) <m_error_type, m_error_value,
6696         m_error_traceback>: Remove.
6697         <m_error>: New member.
6698         (gdbpy_exception_to_string): Don't declare.
6699         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6700         * python/py-value.c (convert_value_from_python): Use
6701         gdbpy_err_fetch.
6702         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6703         gdbpy_exception_to_string.
6704         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6705         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6706         gdbpy_err_fetch.
6707
6708 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6709
6710         * linux-nat.c (delete_lwp_cleanup): Delete.
6711         (struct lwp_deleter): New struct.
6712         (lwp_info_up): New typedef.
6713         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6714         lwp_info_up.
6715
6716 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6717
6718         * linux-fork.c (class scoped_switch_fork_info): New class.
6719         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6720
6721 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6722
6723         * valops.c (find_overload_match): Remove use of null_cleanup, and
6724         calls to do_cleanups.
6725
6726 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6727
6728         * compile/compile-cplus-types.c
6729         (compile_cplus_instance::decl_name): Handle changes to
6730         cp_func_name.
6731         * cp-support.c (cp_func_name): Update header comment, update
6732         return type.
6733         * cp-support.h (cp_func_name): Update return type in declaration.
6734         * valops.c (find_overload_match): Move temp_func local to top
6735         level of function and change its type.  Use temp_func to hold and
6736         delete temporary string obtained from cp_func_name.
6737
6738 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6739
6740         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6741         gdb::char_vector, remove cleanup, and update uses of `msg`.
6742
6743 2019-01-03  Jim Wilson  <jimw@sifive.com>
6744
6745         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6746
6747 2019-01-02  Tom Tromey  <tom@tromey.com>
6748
6749         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6750         (tdesc_parse_xml): Remove cleanups.
6751         * target-descriptions.h (make_cleanup_free_target_description):
6752         Don't declare.
6753         (target_desc_deleter): New struct.
6754         (target_desc_up): New typedef.
6755         * target-descriptions.c (target_desc_deleter::operator()): Rename
6756         from free_target_description.
6757         (make_cleanup_free_target_description): Remove.
6758
6759 2019-01-02  Tom Tromey  <tom@tromey.com>
6760
6761         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6762         constructor, destructor.
6763         (linespec_parser): Remove typedef.
6764         (~linespec_parser): Rename from linespec_parser_delete.
6765         (linespec_lex_to_end, linespec_complete_label)
6766         (linespec_complete): Update.
6767         (decode_line_full): Remove cleanups.
6768         (decode_line_1): Update.
6769
6770 2019-01-02  Tom Tromey  <tom@tromey.com>
6771
6772         * python/python-internal.h (inferior_to_inferior_object): Change
6773         return type.
6774         * python/py-exitedevent.c (create_exited_event_object): Update.
6775         * python/py-inferior.c (inferior_to_inferior_object): Return
6776         gdbpy_ref.
6777         (python_new_inferior, python_inferior_deleted)
6778         (thread_to_thread_object, delete_thread_object)
6779         (build_inferior_list, gdbpy_selected_inferior): Update.
6780         * python/py-infthread.c (create_thread_object): Update.  Also fail
6781         if inferior_to_inferior_object fails.
6782
6783 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6784
6785         * inferior.h (class inferior) <displaced_step_state>: New field.
6786         * infrun.h (struct displaced_step_state): Move here from
6787         infrun.c.  Initialize fields, add constructor.
6788         <inf>: Remove field.
6789         <reset>: New method.
6790         * infrun.c (struct displaced_step_inferior_state): Move to
6791         infrun.h.
6792         (displaced_step_inferior_states): Remove.
6793         (get_displaced_stepping_state): Adust.
6794         (displaced_step_in_progress_any_inferior): Adjust.
6795         (displaced_step_in_progress_thread): Adjust.
6796         (displaced_step_in_progress): Adjust.
6797         (add_displaced_stepping_state): Remove.
6798         (get_displaced_step_closure_by_addr): Adjust.
6799         (remove_displaced_stepping_state): Remove.
6800         (infrun_inferior_exit): Call displaced_step_state.reset.
6801         (use_displaced_stepping): Don't check for NULL.
6802         (displaced_step_prepare_throw): Call
6803         get_displaced_stepping_state.
6804         (displaced_step_fixup): Don't check for NULL.
6805         (prepare_for_detach): Don't check for NULL.
6806
6807 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6808
6809         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6810          in case of call that did not complete.
6811
6812 2019-01-02  Andrey Utkin  <autkin@undo.io>
6813
6814         * symfile.c (find_separate_debug_file): Fix search of debug files for
6815         remote debuggee.
6816
6817 2019-01-02  Tom Tromey  <tom@tromey.com>
6818
6819         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6820         indentation.
6821         * python/py-frame.c (frapy_older): Remove cast.
6822         (frapy_newer): Likewise.
6823         * python/py-breakpoint.c (local_setattro): Remove cast.
6824         * python/py-arch.c (archpy_name): Remove local variable.
6825         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6826
6827 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6828
6829         * unittests/basic_string_view/element_access/char/empty.cc:
6830         Fix year range in copyright header.
6831
6832 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6833
6834         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6835         Delete.
6836         <operator==>: Update with for removed field.
6837         <hash>: Likewise.
6838         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6839         <isa_features>: ...this.
6840         <abi_features>: New field.
6841         (riscv_isa_flen): Update comment.
6842         (riscv_abi_xlen): New declaration.
6843         (riscv_abi_flen): New declaration.
6844         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6845         isa_features.
6846         (riscv_abi_xlen): New function.
6847         (riscv_isa_flen): Update to get answer from isa_features.
6848         (riscv_abi_flen): New function.
6849         (riscv_has_fp_abi): Update to get answer from abi_features.
6850         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6851         xlen and flen.
6852         (riscv_call_info) <xlen, flen>: Update comment.
6853         (riscv_call_arg_struct): Remove invalid assertions
6854         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6855         is removed.
6856         (riscv_gdbarch_init): Gather isa features and abi features
6857         separately, ensure both match on the gdbarch when reusing an old
6858         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6859         a target with 64-bit float hardware.
6860
6861 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6862
6863         * source.c (search_command_helper): Stop reverse search
6864         when line 1 has been searched.
6865
6866 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6867
6868         * record-full.c (record_full_base_target::close): Rewrite
6869         record_full_core_buf_list free logic.
6870
6871 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6872
6873         * break-catch-syscall.c (print_one_catch_syscall): xfree
6874         the last text.
6875
6876 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6877
6878         * top.c (print_gdb_version): Update Copyright year in version
6879         message.
6880
6881 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6882
6883         Update copyright year range in all GDB files.
6884
6885 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6886
6887         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6888
6889 For older changes see ChangeLog-2018.
6890 \f
6891 Local Variables:
6892 mode: change-log
6893 left-margin: 8
6894 fill-column: 74
6895 version-control: never
6896 coding: utf-8
6897 End:
6898