Fix formatting in ravenscar-thread.c
[external/binutils.git] / gdb / ChangeLog
1 2019-02-15  Tom Tromey  <tromey@adacore.com>
2
3         * ravenscar-thread.c (ravenscar_runtime_initializer)
4         (has_ravenscar_runtime, get_running_thread_id)
5         (ravenscar_thread_target::resume): Fix indentation.
6
7 2019-02-15  Tom Tromey  <tromey@adacore.com>
8
9         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10         from ravenscar_arch_ops.
11         (sparc_ravenscar_ops::fetch_registers)
12         (sparc_ravenscar_ops::store_registers): Now methods.
13         (sparc_ravenscar_prepare_to_store): Remove.
14         (sparc_ravenscar_ops): Redefine.
15         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
16         methods and destructor.  Remove members.
17         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
18         (ravenscar_thread_target::store_registers)
19         (ravenscar_thread_target::prepare_to_store): Update.
20         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
21         Remove.
22         (struct ppc_ravenscar_powerpc_ops): Derive from
23         ravenscar_arch_ops.
24         (ppc_ravenscar_powerpc_ops::fetch_registers)
25         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
26         (ppc_ravenscar_powerpc_ops): Redefine.
27         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
28         (ppc_ravenscar_e500_ops::fetch_registers)
29         (ppc_ravenscar_e500_ops::store_registers): Now methods.
30         (ppc_ravenscar_e500_ops): Redefine.
31         * aarch64-ravenscar-thread.c
32         (aarch64_ravenscar_generic_prepare_to_store): Remove.
33         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
34         (aarch64_ravenscar_fetch_registers)
35         (aarch64_ravenscar_store_registers): Now methods.
36         (aarch64_ravenscar_ops): Redefine.
37
38 2019-02-15  Tom Tromey  <tromey@adacore.com>
39
40         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
41         (ravenscar_thread_target::stopped_by_hw_breakpoint)
42         (ravenscar_thread_target::stopped_by_watchpoint)
43         (ravenscar_thread_target::stopped_data_address)
44         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
45
46 2019-02-15  Tom Tromey  <tromey@adacore.com>
47
48         * ravenscar-thread.c: Fix some typos.
49
50 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
51             Tom Tromey  <tromey@adacore.com>
52
53         * ada-lang.c (ada_exception_sal): Change addr_string to a
54         std::string.
55         (create_ada_exception_catchpoint): Update.
56
57 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
58             Tom Tromey  <tromey@adacore.com>
59
60         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
61         (bp_location_ops): Remove.
62         (base_breakpoint_allocate_location): Update.
63         (free_bp_location): Update.
64         * ada-lang.c (class ada_catchpoint_location)
65         <ada_catchpoint_location>: Remove ops parameter.
66         (ada_catchpoint_location_dtor): Remove.
67         (ada_catchpoint_location_ops): Remove.
68         (allocate_location_exception): Update.
69         * breakpoint.h (struct bp_location_ops): Remove.
70         (class bp_location) <bp_location>: Remove bp_location_ops
71         parameter.
72         <~bp_location>: Add destructor.
73         <ops>: Remove.
74
75 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
76             Pedro Alves  <palves@redhat.com>
77
78         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
79         'PATH_MAX'.
80
81 2019-02-14  David Michael  <fedora.dm0@gmail.com>
82             Samuel Thibault  <samuel.thibault@gnu.org>
83             Thomas Schwinge  <thomas@codesourcery.com>
84
85         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
86         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
87
88 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
89
90         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
91         (check_empty): Use "const char *".
92
93         * gnu-nat.c (gnu_nat_target::detach): Instead of
94         'detach_inferior (pid)' call
95         'detach_inferior (find_inferior_pid (pid))'.
96
97         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
98         'nat/fork-inferior.o'.
99         * gnu-nat.c: #include "nat/fork-inferior.h".
100
101         * gnu-nat.c (gnu_nat_target::detach): Instead of
102         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
103         * gnu-nat.h: #include "inf-child.h".
104         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
105         'i386_gnu_nat_target::fetch_registers'.
106         (gnu_store_registers): Rename/move to
107         'i386_gnu_nat_target::store_registers'.
108
109         * config/i386/nm-i386gnu.h: Don't "#include" any files.
110         * gnu-nat.h (mach_thread_info): New function.
111         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
112
113         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
114
115 2019-02-14  Frederic Konrad  <konrad@adacore.com>
116
117         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
118
119 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
120
121         * windows-nat.c (windows_add_thread): Add new parameter
122         "main_thread_p" with default value set to false.  Update
123         function documentation as well as all callers.
124         (windows_delete_thread): Likewise.
125         (fake_create_process): Update call to windows_add_thread.
126         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
127         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
128         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
129         call to windows_delete_thread.
130
131 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
132
133         * MAINTAINERS: Add Andrew Burgess as global maintainer.
134
135 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
136
137         * symfile.c (find_separate_debug_file): Use canonical path of
138         sysroot with child_path instead of gdb_sysroot if it is valid.
139
140 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
141
142         * symfile.c (find_separate_debug_file): Use child_path to
143         determine if an object file is under a sysroot.
144
145 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
146
147         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
148         unittests/child-path-selftests.c.
149         * common/pathstuff.c (child_path): New function.
150         * common/pathstuff.h (child_path): New prototype.
151         * unittests/child-path-selftests.c: New file.
152
153 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
154
155         * symfile.c (find_separate_debug_file): Look for separate debug
156         files in debug directories under the sysroot.
157
158 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
159
160         * symtab.h (struct minimal_symbol data_p): New const method.
161         (struct minimal_symbol text_p): Likewise.
162         * symtab.c (output_source_filename): Use file name style
163         to print file name.
164         (print_symbol_info): Likewise.
165         (print_msymbol_info): Use address style to print addresses.
166         Use function name style to print executable text symbols.
167         (expand_symtab_containing_pc): Use data_p.
168         (find_pc_sect_compunit_symtab): Likewise.
169
170 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
171
172         * breakpoint.c (describe_other_breakpoints): Use address style
173         to print addresses.
174         (say_where): Likewise.
175
176 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
177
178         * ada-typeprint.c (print_func_type): Print function name
179         style to print function name.
180         * c-typeprint.c (c_print_type_1): Likewise.
181
182 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
183
184         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
185         for execve.
186
187 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
188
189         * c-exp.y (direct_abs_decl): Use emplace_back to record the
190         type_stack.
191
192 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
193
194         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
195         TYPE_CODE_REF types.
196
197 2019-02-08  Jim Wilson  <jimw@sifive.com>
198
199         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
200         (riscv_linux_fregset): New.
201         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
202
203 2019-02-07  Tom Tromey  <tom@tromey.com>
204
205         * thread.c (thread_cancel_execution_command): Update.
206         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
207         methods.
208         (struct thread_fsm_ops): Remove.
209         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
210         (thread_fsm_should_stop, thread_fsm_return_value)
211         (thread_fsm_set_finished, thread_fsm_finished_p)
212         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
213         Don't declare.
214         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
215         * infrun.c (clear_proceed_status_thread)
216         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
217         (print_stop_event): Update.
218         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
219         Add constructor.
220         (step_command_fsm_ops): Remove.
221         (new_step_command_fsm): Remove.
222         (step_1): Update.
223         (step_command_fsm::should_stop): Rename from
224         step_command_fsm_should_stop.
225         (step_command_fsm::clean_up): Rename from
226         step_command_fsm_clean_up.
227         (step_command_fsm::do_async_reply_reason): Rename from
228         step_command_fsm_async_reply_reason.
229         (struct until_next_fsm): Inherit from thread_fsm.  Add
230         constructor.
231         (until_next_fsm_ops): Remove.
232         (new_until_next_fsm): Remove.
233         (until_next_fsm::should_stop): Rename from
234         until_next_fsm_should_stop.
235         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
236         (until_next_fsm::do_async_reply_reason): Rename from
237         until_next_fsm_async_reply_reason.
238         (struct finish_command_fsm): Inherit from thread_fsm.  Add
239         constructor.  Change type of breakpoint.
240         (finish_command_fsm_ops): Remove.
241         (new_finish_command_fsm): Remove.
242         (finish_command_fsm::should_stop): Rename from
243         finish_command_fsm_should_stop.
244         (finish_command_fsm::clean_up): Rename from
245         finish_command_fsm_clean_up.
246         (finish_command_fsm::return_value): Rename from
247         finish_command_fsm_return_value.
248         (finish_command_fsm::do_async_reply_reason): Rename from
249         finish_command_fsm_async_reply_reason.
250         (finish_command): Update.
251         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
252         Add constructor.
253         (call_thread_fsm_ops): Remove.
254         (call_thread_fsm::call_thread_fsm): Rename from
255         new_call_thread_fsm.
256         (call_thread_fsm::should_stop): Rename from
257         call_thread_fsm_should_stop.
258         (call_thread_fsm::should_notify_stop): Rename from
259         call_thread_fsm_should_notify_stop.
260         (run_inferior_call, call_function_by_hand_dummy): Update.
261         * cli/cli-interp.c (should_print_stop_to_console): Update.
262         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
263         Add constructor.  Change type of location_breakpoint,
264         caller_breakpoint.
265         (until_break_fsm_ops): Remove.
266         (new_until_break_fsm): Remove.
267         (until_break_fsm::should_stop): Rename from
268         until_break_fsm_should_stop.
269         (until_break_fsm::clean_up): Rename from
270         until_break_fsm_clean_up.
271         (until_break_fsm::do_async_reply_reason): Rename from
272         until_break_fsm_async_reply_reason.
273         (until_break_command): Update.
274         * thread-fsm.c: Remove.
275         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
276
277 2019-02-07  Tom Tromey  <tom@tromey.com>
278
279         * yy-remap.h: Add include guard.
280         * xtensa-tdep.h: Add include guard.
281         * xcoffread.h: Rename include guard.
282         * varobj-iter.h: Add include guard.
283         * tui/tui.h: Rename include guard.
284         * tui/tui-winsource.h: Rename include guard.
285         * tui/tui-wingeneral.h: Rename include guard.
286         * tui/tui-windata.h: Rename include guard.
287         * tui/tui-win.h: Rename include guard.
288         * tui/tui-stack.h: Rename include guard.
289         * tui/tui-source.h: Rename include guard.
290         * tui/tui-regs.h: Rename include guard.
291         * tui/tui-out.h: Rename include guard.
292         * tui/tui-layout.h: Rename include guard.
293         * tui/tui-io.h: Rename include guard.
294         * tui/tui-hooks.h: Rename include guard.
295         * tui/tui-file.h: Rename include guard.
296         * tui/tui-disasm.h: Rename include guard.
297         * tui/tui-data.h: Rename include guard.
298         * tui/tui-command.h: Rename include guard.
299         * tic6x-tdep.h: Add include guard.
300         * target/waitstatus.h: Rename include guard.
301         * target/wait.h: Rename include guard.
302         * target/target.h: Rename include guard.
303         * target/resume.h: Rename include guard.
304         * target-float.h: Rename include guard.
305         * stabsread.h: Add include guard.
306         * rs6000-tdep.h: Add include guard.
307         * riscv-fbsd-tdep.h: Add include guard.
308         * regformats/regdef.h: Rename include guard.
309         * record.h: Rename include guard.
310         * python/python.h: Rename include guard.
311         * python/python-internal.h: Rename include guard.
312         * python/py-stopevent.h: Rename include guard.
313         * python/py-ref.h: Rename include guard.
314         * python/py-record.h: Rename include guard.
315         * python/py-record-full.h: Rename include guard.
316         * python/py-record-btrace.h: Rename include guard.
317         * python/py-instruction.h: Rename include guard.
318         * python/py-events.h: Rename include guard.
319         * python/py-event.h: Rename include guard.
320         * procfs.h: Add include guard.
321         * proc-utils.h: Add include guard.
322         * p-lang.h: Add include guard.
323         * or1k-tdep.h: Rename include guard.
324         * observable.h: Rename include guard.
325         * nto-tdep.h: Rename include guard.
326         * nat/x86-linux.h: Rename include guard.
327         * nat/x86-linux-dregs.h: Rename include guard.
328         * nat/x86-gcc-cpuid.h: Add include guard.
329         * nat/x86-dregs.h: Rename include guard.
330         * nat/x86-cpuid.h: Rename include guard.
331         * nat/ppc-linux.h: Rename include guard.
332         * nat/mips-linux-watch.h: Rename include guard.
333         * nat/linux-waitpid.h: Rename include guard.
334         * nat/linux-ptrace.h: Rename include guard.
335         * nat/linux-procfs.h: Rename include guard.
336         * nat/linux-osdata.h: Rename include guard.
337         * nat/linux-nat.h: Rename include guard.
338         * nat/linux-namespaces.h: Rename include guard.
339         * nat/linux-btrace.h: Rename include guard.
340         * nat/glibc_thread_db.h: Rename include guard.
341         * nat/gdb_thread_db.h: Rename include guard.
342         * nat/gdb_ptrace.h: Rename include guard.
343         * nat/fork-inferior.h: Rename include guard.
344         * nat/amd64-linux-siginfo.h: Rename include guard.
345         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
346         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
347         * nat/aarch64-linux.h: Rename include guard.
348         * nat/aarch64-linux-hw-point.h: Rename include guard.
349         * mn10300-tdep.h: Add include guard.
350         * mips-linux-tdep.h: Add include guard.
351         * mi/mi-parse.h: Rename include guard.
352         * mi/mi-out.h: Rename include guard.
353         * mi/mi-main.h: Rename include guard.
354         * mi/mi-interp.h: Rename include guard.
355         * mi/mi-getopt.h: Rename include guard.
356         * mi/mi-console.h: Rename include guard.
357         * mi/mi-common.h: Rename include guard.
358         * mi/mi-cmds.h: Rename include guard.
359         * mi/mi-cmd-break.h: Rename include guard.
360         * m2-lang.h: Add include guard.
361         * location.h: Rename include guard.
362         * linux-record.h: Rename include guard.
363         * linux-nat.h: Add include guard.
364         * linux-fork.h: Add include guard.
365         * i386-darwin-tdep.h: Rename include guard.
366         * hppa-linux-offsets.h: Add include guard.
367         * guile/guile.h: Rename include guard.
368         * guile/guile-internal.h: Rename include guard.
369         * gnu-nat.h: Rename include guard.
370         * gdb-stabs.h: Rename include guard.
371         * frv-tdep.h: Add include guard.
372         * f-lang.h: Add include guard.
373         * event-loop.h: Add include guard.
374         * darwin-nat.h: Rename include guard.
375         * cp-abi.h: Rename include guard.
376         * config/sparc/nm-sol2.h: Rename include guard.
377         * config/nm-nto.h: Rename include guard.
378         * config/nm-linux.h: Add include guard.
379         * config/i386/nm-i386gnu.h: Rename include guard.
380         * config/djgpp/nl_types.h: Rename include guard.
381         * config/djgpp/langinfo.h: Rename include guard.
382         * compile/gcc-cp-plugin.h: Add include guard.
383         * compile/gcc-c-plugin.h: Add include guard.
384         * compile/compile.h: Rename include guard.
385         * compile/compile-object-run.h: Rename include guard.
386         * compile/compile-object-load.h: Rename include guard.
387         * compile/compile-internal.h: Rename include guard.
388         * compile/compile-cplus.h: Rename include guard.
389         * compile/compile-c.h: Rename include guard.
390         * common/xml-utils.h: Rename include guard.
391         * common/x86-xstate.h: Rename include guard.
392         * common/version.h: Rename include guard.
393         * common/vec.h: Rename include guard.
394         * common/tdesc.h: Rename include guard.
395         * common/selftest.h: Rename include guard.
396         * common/scoped_restore.h: Rename include guard.
397         * common/scoped_mmap.h: Rename include guard.
398         * common/scoped_fd.h: Rename include guard.
399         * common/safe-iterator.h: Rename include guard.
400         * common/run-time-clock.h: Rename include guard.
401         * common/refcounted-object.h: Rename include guard.
402         * common/queue.h: Rename include guard.
403         * common/ptid.h: Rename include guard.
404         * common/print-utils.h: Rename include guard.
405         * common/preprocessor.h: Rename include guard.
406         * common/pathstuff.h: Rename include guard.
407         * common/observable.h: Rename include guard.
408         * common/netstuff.h: Rename include guard.
409         * common/job-control.h: Rename include guard.
410         * common/host-defs.h: Rename include guard.
411         * common/gdb_wait.h: Rename include guard.
412         * common/gdb_vecs.h: Rename include guard.
413         * common/gdb_unlinker.h: Rename include guard.
414         * common/gdb_unique_ptr.h: Rename include guard.
415         * common/gdb_tilde_expand.h: Rename include guard.
416         * common/gdb_sys_time.h: Rename include guard.
417         * common/gdb_string_view.h: Rename include guard.
418         * common/gdb_splay_tree.h: Rename include guard.
419         * common/gdb_setjmp.h: Rename include guard.
420         * common/gdb_ref_ptr.h: Rename include guard.
421         * common/gdb_optional.h: Rename include guard.
422         * common/gdb_locale.h: Rename include guard.
423         * common/gdb_assert.h: Rename include guard.
424         * common/filtered-iterator.h: Rename include guard.
425         * common/filestuff.h: Rename include guard.
426         * common/fileio.h: Rename include guard.
427         * common/environ.h: Rename include guard.
428         * common/common-utils.h: Rename include guard.
429         * common/common-types.h: Rename include guard.
430         * common/common-regcache.h: Rename include guard.
431         * common/common-inferior.h: Rename include guard.
432         * common/common-gdbthread.h: Rename include guard.
433         * common/common-exceptions.h: Rename include guard.
434         * common/common-defs.h: Rename include guard.
435         * common/common-debug.h: Rename include guard.
436         * common/cleanups.h: Rename include guard.
437         * common/buffer.h: Rename include guard.
438         * common/btrace-common.h: Rename include guard.
439         * common/break-common.h: Rename include guard.
440         * cli/cli-utils.h: Rename include guard.
441         * cli/cli-style.h: Rename include guard.
442         * cli/cli-setshow.h: Rename include guard.
443         * cli/cli-script.h: Rename include guard.
444         * cli/cli-interp.h: Rename include guard.
445         * cli/cli-decode.h: Rename include guard.
446         * cli/cli-cmds.h: Rename include guard.
447         * charset-list.h: Add include guard.
448         * buildsym-legacy.h: Rename include guard.
449         * bfin-tdep.h: Add include guard.
450         * ax.h: Rename include guard.
451         * arm-linux-tdep.h: Add include guard.
452         * arm-fbsd-tdep.h: Add include guard.
453         * arch/xtensa.h: Rename include guard.
454         * arch/tic6x.h: Add include guard.
455         * arch/i386.h: Add include guard.
456         * arch/arm.h: Rename include guard.
457         * arch/arm-linux.h: Rename include guard.
458         * arch/arm-get-next-pcs.h: Rename include guard.
459         * arch/amd64.h: Add include guard.
460         * arch/aarch64-insn.h: Rename include guard.
461         * arch-utils.h: Rename include guard.
462         * annotate.h: Add include guard.
463         * amd64-darwin-tdep.h: Rename include guard.
464         * aarch64-linux-tdep.h: Add include guard.
465         * aarch64-fbsd-tdep.h: Add include guard.
466         * aarch32-linux-nat.h: Add include guard.
467
468 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
469
470         * macrotab.c (macro_define_internal): New function that
471         factorizes macro_define_object_internal and macro_define_function
472         code.
473         (macro_define_object_internal): Use macro_define_internal.
474         (macro_define_function): Likewise.
475
476 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
477
478         * macrocmd.c (extract_identifier): Return
479         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
480         callers.
481
482 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
483
484         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
485
486 2019-02-05  Tom Tromey  <tom@tromey.com>
487
488         * target.c (target_stack::unpush): Move assertion earlier.
489
490 2019-01-30  Tom Tromey  <tom@tromey.com>
491
492         PR python/23615:
493         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
494         (gdbpy_parse_and_eval): Likewise.
495         * python/python-internal.h (gdbpy_allow_threads): New class.
496
497 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
498
499         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
500         (aarch64_fbsd_fpregmap): Move earlier.
501         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
502         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
503         instead of individual calls to trad_frame_set_reg_addr.
504         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
505         earlier.
506         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
507         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
508         instead of individual calls to trad_frame_set_reg_addr.
509
510 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
511
512         * CONTRIBUTE: Replace contribution list with wiki link.
513
514 2019-01-25  Tom Tromey  <tom@tromey.com>
515
516         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
517
518 2019-01-25  Tom Tromey  <tom@tromey.com>
519
520         * xtensa-linux-nat.c: Fix common/ includes.
521         * xml-support.h: Fix common/ includes.
522         * xml-support.c: Fix common/ includes.
523         * x86-linux-nat.c: Fix common/ includes.
524         * windows-nat.c: Fix common/ includes.
525         * varobj.h: Fix common/ includes.
526         * varobj.c: Fix common/ includes.
527         * value.c: Fix common/ includes.
528         * valops.c: Fix common/ includes.
529         * utils.c: Fix common/ includes.
530         * unittests/xml-utils-selftests.c: Fix common/ includes.
531         * unittests/utils-selftests.c: Fix common/ includes.
532         * unittests/unpack-selftests.c: Fix common/ includes.
533         * unittests/tracepoint-selftests.c: Fix common/ includes.
534         * unittests/style-selftests.c: Fix common/ includes.
535         * unittests/string_view-selftests.c: Fix common/ includes.
536         * unittests/scoped_restore-selftests.c: Fix common/ includes.
537         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
538         * unittests/scoped_fd-selftests.c: Fix common/ includes.
539         * unittests/rsp-low-selftests.c: Fix common/ includes.
540         * unittests/parse-connection-spec-selftests.c: Fix common/
541         includes.
542         * unittests/optional-selftests.c: Fix common/ includes.
543         * unittests/offset-type-selftests.c: Fix common/ includes.
544         * unittests/observable-selftests.c: Fix common/ includes.
545         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
546         * unittests/memrange-selftests.c: Fix common/ includes.
547         * unittests/memory-map-selftests.c: Fix common/ includes.
548         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
549         * unittests/function-view-selftests.c: Fix common/ includes.
550         * unittests/environ-selftests.c: Fix common/ includes.
551         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
552         * unittests/common-utils-selftests.c: Fix common/ includes.
553         * unittests/cli-utils-selftests.c: Fix common/ includes.
554         * unittests/array-view-selftests.c: Fix common/ includes.
555         * ui-file.c: Fix common/ includes.
556         * tui/tui-io.c: Fix common/ includes.
557         * tracepoint.h: Fix common/ includes.
558         * tracepoint.c: Fix common/ includes.
559         * tracefile-tfile.c: Fix common/ includes.
560         * top.h: Fix common/ includes.
561         * top.c: Fix common/ includes.
562         * thread.c: Fix common/ includes.
563         * target/waitstatus.h: Fix common/ includes.
564         * target/waitstatus.c: Fix common/ includes.
565         * target.h: Fix common/ includes.
566         * target.c: Fix common/ includes.
567         * target-memory.c: Fix common/ includes.
568         * target-descriptions.c: Fix common/ includes.
569         * symtab.h: Fix common/ includes.
570         * symfile.c: Fix common/ includes.
571         * stap-probe.c: Fix common/ includes.
572         * spu-linux-nat.c: Fix common/ includes.
573         * sparc-nat.c: Fix common/ includes.
574         * source.c: Fix common/ includes.
575         * solib.c: Fix common/ includes.
576         * solib-target.c: Fix common/ includes.
577         * ser-unix.c: Fix common/ includes.
578         * ser-tcp.c: Fix common/ includes.
579         * ser-pipe.c: Fix common/ includes.
580         * ser-base.c: Fix common/ includes.
581         * selftest-arch.c: Fix common/ includes.
582         * s12z-tdep.c: Fix common/ includes.
583         * rust-exp.y: Fix common/ includes.
584         * rs6000-aix-tdep.c: Fix common/ includes.
585         * riscv-tdep.c: Fix common/ includes.
586         * remote.c: Fix common/ includes.
587         * remote-notif.h: Fix common/ includes.
588         * remote-fileio.h: Fix common/ includes.
589         * remote-fileio.c: Fix common/ includes.
590         * regcache.h: Fix common/ includes.
591         * regcache.c: Fix common/ includes.
592         * record-btrace.c: Fix common/ includes.
593         * python/python.c: Fix common/ includes.
594         * python/py-type.c: Fix common/ includes.
595         * python/py-inferior.c: Fix common/ includes.
596         * progspace.h: Fix common/ includes.
597         * producer.c: Fix common/ includes.
598         * procfs.c: Fix common/ includes.
599         * proc-api.c: Fix common/ includes.
600         * printcmd.c: Fix common/ includes.
601         * ppc-linux-nat.c: Fix common/ includes.
602         * parser-defs.h: Fix common/ includes.
603         * osdata.c: Fix common/ includes.
604         * obsd-nat.c: Fix common/ includes.
605         * nat/x86-linux.c: Fix common/ includes.
606         * nat/x86-linux-dregs.c: Fix common/ includes.
607         * nat/x86-dregs.h: Fix common/ includes.
608         * nat/x86-dregs.c: Fix common/ includes.
609         * nat/ppc-linux.c: Fix common/ includes.
610         * nat/mips-linux-watch.h: Fix common/ includes.
611         * nat/mips-linux-watch.c: Fix common/ includes.
612         * nat/linux-waitpid.c: Fix common/ includes.
613         * nat/linux-ptrace.h: Fix common/ includes.
614         * nat/linux-ptrace.c: Fix common/ includes.
615         * nat/linux-procfs.c: Fix common/ includes.
616         * nat/linux-personality.c: Fix common/ includes.
617         * nat/linux-osdata.c: Fix common/ includes.
618         * nat/linux-namespaces.c: Fix common/ includes.
619         * nat/linux-btrace.h: Fix common/ includes.
620         * nat/linux-btrace.c: Fix common/ includes.
621         * nat/fork-inferior.c: Fix common/ includes.
622         * nat/amd64-linux-siginfo.c: Fix common/ includes.
623         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
624         * nat/aarch64-linux.c: Fix common/ includes.
625         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
626         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
627         * namespace.h: Fix common/ includes.
628         * mips-linux-tdep.c: Fix common/ includes.
629         * minsyms.c: Fix common/ includes.
630         * mi/mi-parse.h: Fix common/ includes.
631         * mi/mi-main.c: Fix common/ includes.
632         * mi/mi-cmd-env.c: Fix common/ includes.
633         * memrange.h: Fix common/ includes.
634         * memattr.c: Fix common/ includes.
635         * maint.h: Fix common/ includes.
636         * maint.c: Fix common/ includes.
637         * main.c: Fix common/ includes.
638         * machoread.c: Fix common/ includes.
639         * location.c: Fix common/ includes.
640         * linux-thread-db.c: Fix common/ includes.
641         * linux-nat.c: Fix common/ includes.
642         * linux-fork.c: Fix common/ includes.
643         * inline-frame.c: Fix common/ includes.
644         * infrun.c: Fix common/ includes.
645         * inflow.c: Fix common/ includes.
646         * inferior.h: Fix common/ includes.
647         * inferior.c: Fix common/ includes.
648         * infcmd.c: Fix common/ includes.
649         * inf-ptrace.c: Fix common/ includes.
650         * inf-child.c: Fix common/ includes.
651         * ia64-linux-nat.c: Fix common/ includes.
652         * i387-tdep.c: Fix common/ includes.
653         * i386-tdep.c: Fix common/ includes.
654         * i386-linux-tdep.c: Fix common/ includes.
655         * i386-linux-nat.c: Fix common/ includes.
656         * i386-go32-tdep.c: Fix common/ includes.
657         * i386-fbsd-tdep.c: Fix common/ includes.
658         * i386-fbsd-nat.c: Fix common/ includes.
659         * guile/scm-type.c: Fix common/ includes.
660         * guile/guile.c: Fix common/ includes.
661         * go32-nat.c: Fix common/ includes.
662         * gnu-nat.c: Fix common/ includes.
663         * gdbthread.h: Fix common/ includes.
664         * gdbarch-selftests.c: Fix common/ includes.
665         * gdb_usleep.c: Fix common/ includes.
666         * gdb_select.h: Fix common/ includes.
667         * gdb_bfd.c: Fix common/ includes.
668         * gcore.c: Fix common/ includes.
669         * fork-child.c: Fix common/ includes.
670         * findvar.c: Fix common/ includes.
671         * fbsd-nat.c: Fix common/ includes.
672         * event-top.c: Fix common/ includes.
673         * event-loop.c: Fix common/ includes.
674         * dwarf2read.c: Fix common/ includes.
675         * dwarf2loc.c: Fix common/ includes.
676         * dwarf2-frame.c: Fix common/ includes.
677         * dwarf-index-cache.c: Fix common/ includes.
678         * dtrace-probe.c: Fix common/ includes.
679         * disasm-selftests.c: Fix common/ includes.
680         * defs.h: Fix common/ includes.
681         * csky-tdep.c: Fix common/ includes.
682         * cp-valprint.c: Fix common/ includes.
683         * cp-support.h: Fix common/ includes.
684         * cp-support.c: Fix common/ includes.
685         * corelow.c: Fix common/ includes.
686         * completer.h: Fix common/ includes.
687         * completer.c: Fix common/ includes.
688         * compile/compile.c: Fix common/ includes.
689         * compile/compile-loc2c.c: Fix common/ includes.
690         * compile/compile-cplus-types.c: Fix common/ includes.
691         * compile/compile-cplus-symbols.c: Fix common/ includes.
692         * command.h: Fix common/ includes.
693         * cli/cli-dump.c: Fix common/ includes.
694         * cli/cli-cmds.c: Fix common/ includes.
695         * charset.c: Fix common/ includes.
696         * build-id.c: Fix common/ includes.
697         * btrace.h: Fix common/ includes.
698         * btrace.c: Fix common/ includes.
699         * breakpoint.h: Fix common/ includes.
700         * breakpoint.c: Fix common/ includes.
701         * ax.h: 
702         (enum agent_op): Fix common/ includes.
703         * ax-general.c (struct aop_map): Fix common/ includes.
704         * ax-gdb.c: Fix common/ includes.
705         * auxv.c: Fix common/ includes.
706         * auto-load.c: Fix common/ includes.
707         * arm-tdep.c: Fix common/ includes.
708         * arch/riscv.c: Fix common/ includes.
709         * arch/ppc-linux-common.c: Fix common/ includes.
710         * arch/i386.c: Fix common/ includes.
711         * arch/arm.c: Fix common/ includes.
712         * arch/arm-linux.c: Fix common/ includes.
713         * arch/arm-get-next-pcs.c: Fix common/ includes.
714         * arch/amd64.c: Fix common/ includes.
715         * arch/aarch64.c: Fix common/ includes.
716         * arch/aarch64-insn.c: Fix common/ includes.
717         * arch-utils.c: Fix common/ includes.
718         * amd64-windows-tdep.c: Fix common/ includes.
719         * amd64-tdep.c: Fix common/ includes.
720         * amd64-sol2-tdep.c: Fix common/ includes.
721         * amd64-obsd-tdep.c: Fix common/ includes.
722         * amd64-nbsd-tdep.c: Fix common/ includes.
723         * amd64-linux-tdep.c: Fix common/ includes.
724         * amd64-linux-nat.c: Fix common/ includes.
725         * amd64-fbsd-tdep.c: Fix common/ includes.
726         * amd64-fbsd-nat.c: Fix common/ includes.
727         * amd64-dicos-tdep.c: Fix common/ includes.
728         * amd64-darwin-tdep.c: Fix common/ includes.
729         * agent.c: Fix common/ includes.
730         * ada-lang.h: Fix common/ includes.
731         * ada-lang.c: Fix common/ includes.
732         * aarch64-tdep.c: Fix common/ includes.
733
734 2019-01-25  Tom Tromey  <tom@tromey.com>
735
736         * common/create-version.sh: Use common/version.h.
737
738 2019-01-24  Pedro Alves  <palves@redhat.com>
739
740         * infrun.c (signal_stop, signal_print, signal_program)
741         (signal_catch, signal_pass): Now arrays instead of pointers.
742         (update_signals_program_target, do_target_resume)
743         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
744         * linux-nat.c (linux_nat_target::pass_signals)
745         (linux_nat_target::create_inferior, linux_nat_target::attach):
746         Adjust.
747         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
748         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
749         * procfs.c (procfs_target::pass_signals): Adjust.
750         * record-full.c (record_full_target::resume): Adjust.
751         * remote.c (remote_target::pass_signals)
752         (remote_target::program_signals): Adjust.
753         * target-debug.h (target_debug_print_signals): Now takes a
754         gdb::array_view as parameter.  Adjust.
755         * target.h (target_ops) <pass_signals, program_signals>: Replace
756         pointer and length parameters with gdb::array_view.
757         (target_pass_signals, target_program_signals): Likewise.
758         * target-delegates.c: Regenerate.
759
760 2019-01-24  Pedro Alves  <palves@redhat.com>
761
762         * common/forward-scope-exit.h
763         (forward_scope_exit::forward_scope_exit): Pass arguments to
764         m_bind_function directly, instead of creating a std::bind and
765         copying that.
766
767 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
768
769         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
770         for static members.
771         (pass_in_v_vfp_candidate): Likewise.
772
773 2019-01-23  Tom Tromey  <tom@tromey.com>
774             Pedro Alves  <palves@redhat.com>
775
776         * regcache.c (class regcache_invalidator): Remove.
777         (regcache::raw_write): Use make_scope_exit.
778
779 2019-01-23  Tom Tromey  <tom@tromey.com>
780
781         * ui-out.h (class ui_out_emit_type): Update comment.
782
783 2019-01-23  Tom Tromey  <tom@tromey.com>
784
785         * infrun.c (fetch_inferior_event): Update comment.
786
787 2019-01-23  Tom Tromey  <tom@tromey.com>
788             Pedro Alves  <palves@redhat.com>
789
790         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
791         parameter.
792         (fetch_inferior_event): Use SCOPE_EXIT.
793
794
795 2019-01-23  Tom Tromey  <tom@tromey.com>
796             Pedro Alves  <palves@redhat.com>
797
798         * infrun.c (disable_thread_events): Delete.
799         (stop_all_threads): Use SCOPE_EXIT.
800
801 2019-01-23  Tom Tromey  <tom@tromey.com>
802             Pedro Alves  <palves@redhat.com>
803
804         * symfile.c: Include forward-scope-exit.h.
805         (clear_symtab_users_cleanup): Replace forward declaration with
806         a FORWARD_SCOPE_EXIT.
807         (syms_from_objfile_1): Use the forward_scope_exit and
808         gdb::optional instead of cleanup_function.
809         (reread_symbols): Use the forward_scope_exit instead of
810         cleanup_function.
811         (clear_symtab_users_cleanup): Remove function.
812
813 2019-01-23  Tom Tromey  <tom@tromey.com>
814             Pedro Alves  <palves@redhat.com>
815
816         * linux-nat.c: Include scope-exit.h.
817         (cleanup_target_stop): Remove.
818         (linux_nat_target::static_tracepoint_markers_by_strid): Use
819         SCOPE_EXIT.
820
821 2019-01-23  Tom Tromey  <tom@tromey.com>
822             Pedro Alves  <palves@redhat.com>
823
824         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
825         (call_function_by_hand_dummy): Use SCOPE_EXIT.
826
827 2019-01-23  Tom Tromey  <tom@tromey.com>
828             Andrew Burgess  <andrew.burgess@embecosm.com>
829             Pedro Alves  <palves@redhat.com>
830
831         * infrun.c (fetch_inferior_event): Use scope_exit.
832         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
833         * top.c (execute_command): Use scope_exit.
834         * breakpoint.c (bpstat_do_actions): Use scope_exit.
835         * utils.c (do_bpstat_clear_actions_cleanup)
836         (make_bpstat_clear_actions_cleanup): Remove.
837
838 2019-01-23  Tom Tromey  <tom@tromey.com>
839             Pedro Alves  <palves@redhat.com>
840
841         * infrun.c: Include "common/scope-exit.h"
842         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
843         (wait_for_inferior): Use SCOPE_EXIT.
844         (fetch_inferior_event): Use scope_exit.
845
846 2019-01-23  Tom Tromey  <tom@tromey.com>
847             Pedro Alves  <palves@redhat.com>
848
849         * breakpoint.c (create_breakpoint): Remove cleanup.
850
851 2019-01-23  Tom Tromey  <tom@tromey.com>
852             Andrew Burgess  <andrew.burgess@embecosm.com>
853             Pedro Alves  <palves@redhat.com>
854
855 2019-01-23  Pedro Alves  <palves@redhat.com>
856
857         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
858
859 2019-01-23  Pedro Alves  <palves@redhat.com>
860             Andrew Burgess  <andrew.burgess@embecosm.com>
861
862         * gdbthread.h: Include "common/forward-scope-exit.h".
863         (scoped_finish_thread_state): Redefine custom class in terms of
864         forward_scope_exit.
865
866 2019-01-23  Pedro Alves  <palves@redhat.com>
867             Andrew Burgess  <andrew.burgess@embecosm.com>
868
869         * common/forward-scope-exit.h: New file.
870
871 2019-01-23  Pedro Alves  <palves@redhat.com>
872             Andrew Burgess  <andrew.burgess@embecosm.com>
873             Tom Tromey  <tom@tromey.com>
874
875         * common/scope-exit.h: New file.
876
877 2019-01-23  Pedro Alves  <palves@redhat.com>
878
879         * common/preprocessor.h (ESC): Rename to ...
880         (ESC_PARENS): ... this.
881         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
882         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
883
884 2019-01-23  Tom Tromey  <tom@tromey.com>
885
886         * language.h (class scoped_switch_to_sym_language_if_auto):
887         Initialize m_lang in both cases.
888
889 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
890
891         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
892         with XCNEW.
893
894 2019-01-22  Tom Tromey  <tom@tromey.com>
895
896         * corelow.c: Do not include sys/file.h.
897
898 2019-01-22  Tom Tromey  <tom@tromey.com>
899
900         * tui/tui-wingeneral.h: Include gdb_curses.h.
901
902 2019-01-22  Tom Tromey  <tom@tromey.com>
903
904         * source-cache.h (class source_cache) <get_source_lines,
905         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
906
907 2019-01-22  Tom Tromey  <tom@tromey.com>
908
909         * remote-fileio.h (struct remote_target): Declare.
910
911 2019-01-22  Tom Tromey  <tom@tromey.com>
912
913         * python/py-arch.c: Do not include py-ref.h.
914         * python/py-bpevent.c: Do not include py-ref.h.
915         * python/py-cmd.c: Do not include py-ref.h.
916         * python/py-continueevent.c: Do not include py-ref.h.
917         * python/py-event.h: Do not include py-ref.h.
918         * python/py-evtregistry.c: Do not include py-ref.h.
919         * python/py-finishbreakpoint.c: Do not include py-ref.h.
920         * python/py-frame.c: Do not include py-ref.h.
921         * python/py-framefilter.c: Do not include py-ref.h.
922         * python/py-function.c: Do not include py-ref.h.
923         * python/py-infevents.c: Do not include py-ref.h.
924         * python/py-linetable.c: Do not include py-ref.h.
925         * python/py-objfile.c: Do not include py-ref.h.
926         * python/py-param.c: Do not include py-ref.h.
927         * python/py-prettyprint.c: Do not include py-ref.h.
928         * python/py-progspace.c: Do not include py-ref.h.
929         * python/py-symbol.c: Do not include py-ref.h.
930         * python/py-symtab.c: Do not include py-ref.h.
931         * python/py-type.c: Do not include py-ref.h.
932         * python/py-unwind.c: Do not include py-ref.h.
933         * python/py-utils.c: Do not include py-ref.h.
934         * python/py-value.c: Do not include py-ref.h.
935         * python/py-varobj.c: Do not include py-ref.h.
936         * python/py-xmethods.c: Do not include py-ref.h.
937         * python/python.c: Do not include py-ref.h.
938         * varobj.c: Do not include py-ref.h.
939
940 2019-01-22  Tom Tromey  <tom@tromey.com>
941
942         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
943         keyword for bcache.
944
945 2019-01-22  Tom Tromey  <tom@tromey.com>
946
947         * compile/compile-cplus-types.c: Remove a comment by #include.
948
949 2019-01-22  Tom Tromey  <tom@tromey.com>
950
951         * compile/gcc-c-plugin.h: Include compile-internal.h.
952
953 2019-01-22  Tom Tromey  <tom@tromey.com>
954
955         * stabsread.c (EXTERN): Do not define.
956         (symnum, next_symbol_text_func, processing_gcc_compilation)
957         (within_function, global_sym_chain, global_stabs)
958         (previous_stab_code, this_object_header_files)
959         (n_this_object_header_files)
960         (n_allocated_this_object_header_files): Define.
961         * stabsread.h (EXTERN): Never define.  Use "extern".
962
963 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
964
965         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
966         history_value.
967
968 2019-01-21  Tom Tromey  <tom@tromey.com>
969
970         * ui-out.c: Fix includes.
971         * tui/tui-source.c: Fix includes.
972         * target.c: Fix includes.
973         * remote.c: Fix includes.
974         * regcache.c: Fix includes.
975         * python/py-block.c: Fix includes.
976         * printcmd.c: Fix includes.
977         * or1k-tdep.c: Fix includes.
978         * mi/mi-main.c: Fix includes.
979         * m32r-tdep.c: Fix includes.
980         * csky-tdep.c: Fix includes.
981         * compile/compile-cplus-types.c: Fix includes.
982         * cli/cli-interp.c: Fix includes.
983
984 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
985
986         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
987         for padding.
988
989 2019-01-16  Tom Tromey  <tom@tromey.com>
990
991         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
992         earlier.
993         (struct objfile) <msymbols_range>: Move from top level.
994         <msymbols>: New method.
995         (class objfile_msymbols): Remove.
996         * symtab.c (default_collect_symbol_completion_matches_break_on):
997         Update.
998         * symmisc.c (dump_msymbols): Update.
999         * stabsread.c (scan_file_globals): Update.
1000         * objc-lang.c (info_selectors_command, info_classes_command)
1001         (find_methods): Update.
1002         * minsyms.c (find_solib_trampoline_target): Update.
1003         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1004         * coffread.c (coff_symfile_read): Update.
1005         * ada-lang.c (ada_lookup_simple_minsym)
1006         (ada_collect_symbol_completion_matches): Update.
1007
1008 2019-01-16  Tom Tromey  <tom@tromey.com>
1009
1010         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1011         type.  Remove no-argument constructor.
1012         <iterator::operator++>: Simplify.
1013         <begin>: Update.
1014         <end>: Use minimal_symbol_count.
1015
1016 2019-01-16  Tom Tromey  <tom@tromey.com>
1017
1018         * objfiles.h (struct objfile) <psymtabs>: New method.
1019         (class objfile_psymtabs): Remove.
1020         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1021         typedef.
1022         <range>: New method.
1023         (require_partial_symbols): Change return type.
1024         * psymtab.c (require_partial_symbols)
1025         (psym_expand_symtabs_matching): Update.
1026         * mdebugread.c (parse_partial_symbols): Update.
1027         * dbxread.c (dbx_end_psymtab): Update.
1028
1029 2019-01-15  Tom Tromey  <tom@tromey.com>
1030
1031         * symtab.c (lookup_objfile_from_block)
1032         (lookup_symbol_in_objfile_symtabs)
1033         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1034         (find_line_symtab, info_sources_command)
1035         (default_collect_symbol_completion_matches_break_on)
1036         (make_source_files_completion_list): Update.
1037         * symmisc.c (print_objfile_statistics, dump_objfile)
1038         (maintenance_print_symbols, maintenance_info_symtabs)
1039         (maintenance_check_symtabs, maintenance_info_line_tables):
1040         Update.
1041         * source.c (select_source_symtab)
1042         (forget_cached_source_info_for_objfile): Update.
1043         * objfiles.h (class objfile_compunits): Remove.
1044         (struct objfile) <compunits_range>: New typedef.
1045         (compunits): New method.
1046         * objfiles.c (objfile_relocate1): Update.
1047         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1048         * maint.c (count_symtabs_and_blocks): Update.
1049         * linespec.c (iterate_over_all_matching_symtabs): Update.
1050         * cp-support.c (add_symbol_overload_list_qualified): Update.
1051         * coffread.c (coff_symtab_read): Update.
1052         * ada-lang.c (add_nonlocal_symbols)
1053         (ada_collect_symbol_completion_matches)
1054         (ada_add_global_exceptions): Update.
1055
1056 2019-01-15  Tom Tromey  <tom@tromey.com>
1057
1058         * progspace.h (program_space) <objfiles_safe_range>: New
1059         typedef.
1060         <objfiles_safe>: New method.
1061         * objfiles.h (class all_objfiles_safe): Remove.
1062         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1063         * jit.c (jit_inferior_exit_hook): Update.
1064
1065 2019-01-17  Tom Tromey  <tom@tromey.com>
1066
1067         * progspace.h (program_space) <objfiles_range>: New typedef.
1068         <objfiles>: New method.
1069         <objfiles_head>: Rename from objfiles.
1070         (object_files): Update.
1071         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1072         * guile/scm-pretty-print.c
1073         (ppscm_find_pretty_printer_from_objfiles): Update.
1074         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1075         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1076         Update.
1077         * python/py-progspace.c (pspy_get_objfiles): Update.
1078         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1079         Update.
1080         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1081         (objfpy_lookup_objfile_by_build_id): Update.
1082         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1083         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1084         Update.
1085         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1086         (expand_symtab_containing_pc, lookup_objfile_from_block)
1087         (lookup_static_symbol, basic_lookup_transparent_type)
1088         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1089         (find_line_symtab, info_sources_command)
1090         (default_collect_symbol_completion_matches_break_on)
1091         (make_source_files_completion_list, find_main_name): Update.
1092         * symmisc.c (print_symbol_bcache_statistics)
1093         (print_objfile_statistics, maintenance_print_symbols)
1094         (maintenance_print_msymbols, maintenance_print_objfiles)
1095         (maintenance_info_symtabs, maintenance_check_symtabs)
1096         (maintenance_expand_symtabs, maintenance_info_line_tables):
1097         Update.
1098         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1099         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1100         (map_overlay_command, unmap_overlay_command)
1101         (simple_overlay_update, expand_symtabs_matching)
1102         (map_symbol_filenames): Update.
1103         * symfile-debug.c (set_debug_symfile): Update.
1104         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1105         Update.
1106         * source.c (select_source_symtab, forget_cached_source_info):
1107         Update.
1108         * solib.c (solib_read_symbols): Update.
1109         * solib-spu.c (append_ocl_sos): Update.
1110         * psymtab.c (maintenance_print_psymbols)
1111         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1112         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1113         * printcmd.c (info_symbol_command): Update.
1114         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1115         Update.
1116         * objfiles.h (class all_objfiles): Remove.
1117         * objfiles.c (have_partial_symbols, have_full_symbols)
1118         (have_minimal_symbols, qsort_cmp, update_section_map)
1119         (shared_objfile_contains_address_p)
1120         (default_iterate_over_objfiles_in_search_order): Update.
1121         * objc-lang.c (info_selectors_command, info_classes_command)
1122         (find_methods): Update.
1123         * minsyms.c (find_solib_trampoline_target): Update.
1124         * maint.c (maintenance_info_sections)
1125         (maintenance_translate_address, count_symtabs_and_blocks):
1126         Update.
1127         * main.c (captured_main_1): Update.
1128         * linux-thread-db.c (try_thread_db_load_from_pdir)
1129         (has_libpthread): Update.
1130         * linespec.c (iterate_over_all_matching_symtabs)
1131         (search_minsyms_for_name): Update.
1132         * jit.c (jit_find_objf_with_entry_addr): Update.
1133         * hppa-tdep.c (find_unwind_entry)
1134         (hppa_lookup_stub_minimal_symbol): Update.
1135         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1136         Update.
1137         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1138         (elf_gnu_ifunc_resolve_by_got): Update.
1139         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1140         * dwarf-index-write.c (save_gdb_index_command): Update.
1141         * cp-support.c (add_symbol_overload_list_qualified): Update.
1142         * breakpoint.c (create_overlay_event_breakpoint)
1143         (create_longjmp_master_breakpoint)
1144         (create_std_terminate_master_breakpoint)
1145         (create_exception_master_breakpoint): Update.
1146         * blockframe.c (find_pc_partial_function): Update.
1147         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1148         (ada_collect_symbol_completion_matches)
1149         (ada_add_global_exceptions): Update.
1150
1151 2019-01-17  Tom Tromey  <tom@tromey.com>
1152
1153         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1154         declare VEC.
1155         (solib_target_parse_libraries): Change return type.
1156         (library_list_start_segment, library_list_start_section)
1157         (library_list_end_library, library_list_start_library); Update.
1158         (solib_target_free_library_list): Remove.
1159         (solib_target_parse_libraries): Remove cleanup.  Change return
1160         type.
1161         (solib_target_current_sos): Update.
1162
1163 2019-01-17  Tom Tromey  <tromey@bapiya>
1164
1165         * valprint.c: Replace "the the" with "the".
1166         * symtab.c: Replace "the the" with "the".
1167         * solib.c: Replace "the the" with "the".
1168         * solib-dsbt.c: Replace "the the" with "the".
1169         * linespec.c: Replace "the the" with "the".
1170         * dwarf2loc.h: Replace "the the" with "the".
1171         * amd64-windows-tdep.c: Replace "the the" with "the".
1172         * aarch64-tdep.c: Replace "the the" with "the".
1173
1174 2019-01-16  Keith Seitz  <keiths@redhat.com>
1175
1176         PR gdb/23773
1177         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1178         <builder>: Rename to ..
1179         <m_builder>: ... this and make private.
1180         (dwarf2_cu::get_builder): New method.  Change all users of
1181         `builder' to use this method.
1182         (dwarf2_start_symtab): Move to ...
1183         (dwarf2_cu::start_symtab): ... here.  Update all callers
1184         (setup_type_unit_groups): Move to ...
1185         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1186         callers.
1187         (dwarf2_cu::reset_builder): New method.
1188         (process_full_compunit, process_full_type_unit): Use
1189         dwarf2_cu::reset_builder.
1190         (follow_die_offset): Record the ancestor CU if it is different
1191         from the followed DIE's CU.
1192         (follow_die_sig_1): Likewise.
1193
1194 2019-01-15  Tom Tromey  <tom@tromey.com>
1195
1196         * remote.c (class remote_state) <buf>: Now a char_vector.
1197         <buf_size>: Remove.
1198         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1199         parameter.
1200         (remote_target::getpkt_or_notif_sane_1)
1201         (remote_target::getpkt_sane)
1202         (remote_target::getpkt_or_notif_sane): Likewise.
1203         (class remote_target) <putpkt>: New overload.
1204         (remote_target::read_frame): Change type of "buf_p".  Remove
1205         sizeof_p parameter.
1206         (packet_ok): New overload.
1207         (packet_check_result): New overload.
1208         Update all uses.
1209
1210 2019-01-14  Tom Tromey  <tom@tromey.com>
1211
1212         * remote-notif.c (handle_notification, remote_notif_ack)
1213         (remote_notif_parse): Make "buf" const.
1214         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1215         const.
1216         (remote_notif_parse, remote_notif_ack, handle_notification):
1217         Likewise.
1218         * remote.c (remote_notif_stop_parse): Make "buf" const.
1219         (remote_target::remote_parse_stop_reply): Make "buf" const.
1220         (remote_notif_stop_ack): Make "buf" const.
1221
1222 2019-01-14  Tom Tromey  <tom@tromey.com>
1223
1224         * remote.c (remote_console_output): Make parameter const.
1225
1226 2019-01-14  Tom Tromey  <tom@tromey.com>
1227
1228         * target-debug.h (target_debug_print_signals): Constify.
1229         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1230         * procfs.c (procfs_target::pass_signals): Update.
1231         * linux-nat.c (linux_nat_target::pass_signals): Update.
1232         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1233         * target-delegates.c: Rebuild.
1234         * remote.c (remote_target::program_signals): Update.
1235         (remote_target::pass_signals): Update.
1236         * target.c (target_pass_signals): Constify argument.
1237         (target_program_signals): Likewise.
1238         * target.h (struct target_ops) <pass_signals, program_signals>:
1239         Constify argument.
1240         (target_pass_signals, target_program_signals): Constify argument.
1241
1242 2019-01-14  Tom Tromey  <tom@tromey.com>
1243
1244         PR tui/28819:
1245         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1246
1247 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1248
1249         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1250         field.
1251         * rs6000-tdep.c: Include reggroups.h.
1252         (IS_V_ALIAS_PSEUDOREG): Define.
1253         (rs6000_register_name): Return names for the "vX" aliases.
1254         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1255         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1256         aliases.  Call default_register_reggroup_p for all other
1257         pseudo-registers.
1258         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1259         New functions.
1260         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1261         Handle "vX" aliases.
1262         (v_alias_pseudo_register_collect): New function.
1263         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1264         (rs6000_gdbarch_init): Initialize "vX" aliases as
1265         pseudo-registers.  Restore registration of
1266         rs6000_pseudo_register_reggroup_p with
1267         set_tdesc_pseudo_register_reggroup_p.
1268
1269 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1270
1271         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1272         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1273         set_gdbarch_num_pseudo_regs.
1274
1275 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1276
1277         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1278         Remove arg prefixname, add do_set and do_show.
1279         Add member functions set_list and show_list.
1280         * cli/cli-style.c (class cli_style_option): Update accordingly.
1281         (style_set_list): Move to file scope.
1282         (style_show_list): Likewise.
1283         (set_style): Call help_list.
1284         (show_style): Call cmd_show_list.
1285         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1286         Update to use the new macro.
1287
1288 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1289
1290         * ada-lang.c (_initialize_ada_language): Expand the help text
1291         for the "catch exception" command.
1292
1293 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1294
1295         * symtab.c (matching_obj_sections): Initialize obj,
1296         declare it closer to its usage.
1297
1298 2019-01-10  Tom Tromey  <tom@tromey.com>
1299
1300         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1301         (basic_inf_threads_range): Remove.
1302         (inf_threads_range, inf_non_exited_threads_range)
1303         (safe_inf_threads_range): Use next_adapter.
1304
1305 2019-01-10  Keith Seitz  <keiths@redhat.com>
1306
1307         PR gdb/23712
1308         PR symtab/23010
1309         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1310         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1311
1312 2019-01-10  Keith Seitz  <keiths@redhat.com>
1313
1314         PR gdb/23712
1315         PR symtab/23010
1316         * dictionary.c (pending_to_vector): Remove.
1317         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1318         Remove _1 suffix, replacing functions of the same name.  Update
1319         all callers.
1320         (dict_create_hashed, dict_create_hashed_expandable)
1321         (dict_create_linear, dict_create_linear_expandable, dict_free)
1322         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1323         Make functions static.
1324
1325 2019-01-10  Keith Seitz  <keiths@redhat.com>
1326
1327         PR gdb/23712
1328         PR symtab/23010
1329         * dictionary.h (struct dictionary): Replace declaration with
1330         multidictionary.
1331         (dict_create_hashed, dict_create_hashed_expandable)
1332         (dict_create_linear, dict_create_linear_expandable)
1333         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1334         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1335         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1336         taking multidictionary argument.
1337         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1338         * block.h (struct block) <dict>: Change to multidictionary
1339         and rename `multidict'.
1340         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1341         symmisc.c: Update all dictionary references to multidictionary.
1342
1343 2019-01-10  Keith Seitz  <keiths@redhat.com>
1344
1345         PR gdb/23712
1346         PR symtab/23010
1347         * dictionary.c: Include unordered_map.
1348         (pending_to_vector): New function.
1349         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1350         Rewrite the non-"_1" functions to take vector instead
1351         of linked list.
1352         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1353         "new" _1 versions of the same name.
1354         (multidictionary): Define.
1355         (std::hash<enum language): New definition.
1356         (collate_pending_symbols_by_language, mdict_create_hashed)
1357         (mdict_create_hashed_expandable, mdict_create_linear)
1358         (mdict_create_linear_expandable, mdict_free)
1359         (find_language_dictionary, create_new_language_dictionary)
1360         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1361         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1362         (mdict_size, mdict_empty): New functions.
1363         * dictionary.h (mdict_iterator): Define.
1364
1365 2019-01-10  Pedro Alves  <palves@redhat.com>
1366
1367         * breakpoint.c (read_uploaded_action)
1368         (create_tracepoint_from_upload): Adjust to use
1369         gdb::unique_xmalloc_ptr.
1370         * ctf.c (ctf_write_uploaded_tp):
1371         (SET_ARRAY_FIELD): Use emplace_back.
1372         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1373         * tracefile-tfile.c (tfile_write_uploaded_tp):
1374         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1375         gdb::unique_xmalloc_ptr.
1376         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1377         at_string, cond_string, cmd_strings>: Replace char pointers
1378         with gdb::unique_xmalloc_ptr.
1379
1380 2019-01-10  Pedro Alves  <palves@redhat.com>
1381
1382         * solib-target.c (library_list_start_library): Don't xstrdup name.
1383
1384 2019-01-10  Pedro Alves  <palves@redhat.com>
1385
1386         * mdebugread.c (parse_partial_symbols): Use
1387         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1388
1389 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1390
1391         * linux-fork.c (scoped_switch_fork_info)
1392         <~scoped_switch_fork_info>: Fix incorrect variable name.
1393
1394 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1395
1396         * linux-fork.c (scoped_switch_fork_info)
1397         <scoped_switch_fork_info>: Make explicit.
1398         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1399
1400 2019-01-10  Tom Tromey  <tom@tromey.com>
1401
1402         * objfiles.h (objfile::reset_psymtabs): Update.
1403         * objfiles.c (objfile::objfile): Update.
1404         * psymtab.h (psymtab_storage::obstack): Update.
1405         (psymtab_storage::m_obstack): Use gdb::optional.
1406         (class psymtab_storage): Update comment.  Remove objfile
1407         parameter.
1408         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1409
1410 2019-01-10  Tom Tromey  <tom@tromey.com>
1411
1412         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1413         <free_psymtabs>: Now private.
1414         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1415         (allocate_psymtab): Use new method.
1416
1417 2019-01-10  Tom Tromey  <tom@tromey.com>
1418
1419         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1420         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1421         * mdebugread.c (parse_partial_symbols): Use
1422         allocate_dependencies.
1423         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1424         allocate_dependencies.
1425         (process_psymtab_comp_unit_reader)
1426         (build_type_psymtab_dependencies): Likewise.
1427         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1428
1429 2019-01-10  Tom Tromey  <tom@tromey.com>
1430
1431         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1432         PSYMBOL_SET_LANGUAGE.
1433         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1434
1435 2019-01-10  Tom Tromey  <tom@tromey.com>
1436
1437         * psymtab.h (psymtab_storage::obstack): New method.
1438         <m_obstack>: Rename from obstack; now private.
1439         * psymtab.c (psymtab_storage): Update.
1440         * dwarf2read.c (create_addrmap_from_index)
1441         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1442         Update.
1443
1444 2019-01-10  Tom Tromey  <tom@tromey.com>
1445
1446         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1447         * objfiles.h (objfile::reset_psymtabs): New method.
1448
1449 2019-01-10  Tom Tromey  <tom@tromey.com>
1450
1451         * symmisc.c (print_symbol_bcache_statistics): Update.
1452         (print_objfile_statistics): Update.
1453         * symfile.c (reread_symbols): Update.
1454         * psymtab.h (class psymtab_storage): New.
1455         * psymtab.c (psymtab_storage): New constructor.
1456         (~psymtab_storage): New destructor.
1457         (require_partial_symbols): Update.
1458         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1459         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1460         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1461         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1462         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1463         (start_psymtab_common, end_psymtab_common)
1464         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1465         (allocate_psymtab): Update.
1466         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1467         Update.
1468         (dump_psymtab_addrmap, maintenance_print_psymbols)
1469         (maintenance_check_psymtabs): Update.
1470         (class objfile_psymtabs): Move to objfiles.h.
1471         * psympriv.h (discard_psymtab): Now inline.
1472         (psymtab_discarder::psymtab_discarder): Update.
1473         (psymtab_discarder::~psymtab_discarder): Update.
1474         (ALL_OBJFILE_PSYMTABS): Rewrite.
1475         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1476         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1477         Remove fields.
1478         <partial_symtabs>: New field.
1479         (class objfile_psymtabs): Move from psymtab.h.  Update.
1480         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1481         psymbol_cache.
1482         (objfile::~objfile): Don't destroy psymbol_cache.
1483         * mdebugread.c (parse_partial_symbols): Update.
1484         * dwarf2read.c (create_addrmap_from_index)
1485         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1486         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1487         (add_partial_subprogram, dwarf2_ranges_read): Update.
1488         * dwarf-index-write.c (write_address_map)
1489         (write_one_signatured_type, recursively_write_psymbols)
1490         (class debug_names, class debug_names, write_psymtabs_to_index):
1491         Update.
1492
1493 2019-01-10  Tom Tromey  <tom@tromey.com>
1494
1495         * symtab.h (SYMBOL_SET_NAMES): Update.
1496         (symbol_set_names): Update.
1497         (MSYMBOL_SET_NAMES): Update.
1498         * symtab.c (symbol_set_names): Change argument to be an
1499         objfile_per_bfd_storage.
1500         * psymtab.c (add_psymbol_to_bcache): Update.
1501         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1502
1503 2019-01-10  Tom Tromey  <tom@tromey.com>
1504
1505         * symtab.c (create_demangled_names_hash): Change argument to be an
1506         objfile_per_bfd_storage.
1507         (symbol_set_names): Update.
1508
1509 2019-01-10  Tom Tromey  <tom@tromey.com>
1510
1511         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1512         init_psymbol_list.
1513         * psymtab.c (init_psymbol_list): Do nothing if already called.
1514         * psympriv.h (init_psymbol_list): Add comment.
1515         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1516         init_psymbol_list.
1517         * dbxread.c (dbx_symfile_read): Unconditionally call
1518         init_psymbol_list.
1519
1520 2019-01-10  Tom Tromey  <tom@tromey.com>
1521
1522         * xcoffread.c (scan_xcoff_symtab): Update.
1523         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1524         "where".
1525         * mdebugread.c (parse_partial_symbols)
1526         (handle_psymbol_enumerators): Update.
1527         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1528         * dbxread.c (read_dbx_symtab): Update.
1529         * psympriv.h (psymbol_placement): New enum.
1530         (add_psymbol_to_list): Update.
1531
1532 2019-01-10  Tom Tromey  <tom@tromey.com>
1533
1534         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1535         static_psymbols parameters.
1536         (scan_xcoff_symtab): Update.
1537         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1538         static_psymbols parameters.
1539         * psympriv.h (start_psymtab_common): Update.
1540         * mdebugread.c (parse_partial_symbols): Update.
1541         * dwarf2read.c (create_partial_symtab): Update.
1542         * dbxread.c (read_dbx_symtab): Update.
1543         (start_psymtab): Remove global_psymbols and static_psymbols
1544         parameters.
1545
1546 2019-01-10  Tom Tromey  <tom@tromey.com>
1547
1548         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1549         * psymtab.c (allocate_psymtab): Add comment.
1550         * psympriv.h (allocate_psymtab): Add comment.
1551         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1552         initializations.
1553         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1554
1555 2019-01-10  Tom Tromey  <tom@tromey.com>
1556
1557         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1558         Don't declare.
1559         * mipsread.c: Include mdebugread.h.
1560         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1561         Declare.
1562         * elfread.c: Include mdebugread.h.
1563
1564 2019-01-09  Tom Tromey  <tom@tromey.com>
1565
1566         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1567         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1568         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1569         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1570         (psym_lookup_symbol, psym_find_last_source_symtab)
1571         (psym_forget_cached_source_info, psym_print_stats)
1572         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1573         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1574         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1575         (psym_find_compunit_symtab_by_address)
1576         (maintenance_print_psymbols, maintenance_info_psymtabs)
1577         (maintenance_check_psymtabs): Use ranged for.
1578         * psymtab.h (class objfile_psymtabs): New.
1579         (require_partial_symbols): Return objfile_psymtabs.
1580         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1581
1582 2019-01-09  Tom Tromey  <tom@tromey.com>
1583
1584         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1585         (find_pc_mapped_section, list_overlays_command)
1586         (map_overlay_command, unmap_overlay_command)
1587         (simple_overlay_update): Use all_objfiles.
1588         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1589         * printcmd.c (info_symbol_command): Use all_objfiles.
1590         * objfiles.h (ALL_OBJSECTIONS): Remove.
1591         * maint.c (maintenance_translate_address): Use all_objfiles.
1592         * gcore.c (gcore_create_callback): Use all_objfiles.
1593         (objfile_find_memory_regions): Likewise.
1594
1595 2019-01-09  Tom Tromey  <tom@tromey.com>
1596
1597         * symtab.c (find_line_symtab, info_sources_command)
1598         (make_source_files_completion_list): Use objfile_compunits.
1599         * source.c (select_source_symtab): Use objfile_compunits.
1600         * objfiles.h (struct objfile): Update comment.
1601         (ALL_OBJFILES): Remove.
1602         (ALL_FILETABS): Remove.
1603         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1604         objfile_compunits.
1605
1606 2019-01-09  Tom Tromey  <tom@tromey.com>
1607
1608         * symmisc.c (print_objfile_statistics, dump_objfile)
1609         (maintenance_print_symbols): Use compunit_filetabs.
1610         * source.c (forget_cached_source_info_for_objfile): Use
1611         compunit_filetabs.
1612         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1613         (ALL_FILETABS): Use compunit_filetabs.
1614         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1615         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1616
1617 2019-01-09  Tom Tromey  <tom@tromey.com>
1618
1619         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1620         (compunit_filetabs): New.
1621         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1622         compunit_filetabs.
1623         (info_sources_command, make_source_files_completion_list): Remove
1624         declaration.
1625         * symmisc.c (print_objfile_statistics, dump_objfile)
1626         (maintenance_print_symbols): Remove declaration.
1627         (maintenance_info_symtabs): Use compunit_filetabs.
1628         (maintenance_info_line_tables): Likewise.
1629         * source.c (select_source_symtab): Change local variable name.
1630         (forget_cached_source_info_for_objfile): Remove declaration.
1631         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1632         * objfiles.c (objfile_relocate1): Remove declaration.
1633         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1634         declaration.
1635         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1636         * coffread.c (coff_symtab_read): Remove declaration.
1637         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1638         compunit_filetabs.
1639
1640 2019-01-09  Tom Tromey  <tom@tromey.com>
1641
1642         * symtab.c (lookup_objfile_from_block)
1643         (find_pc_sect_compunit_symtab, search_symbols)
1644         (default_collect_symbol_completion_matches_break_on): Use
1645         objfile_compunits.
1646         * objfiles.h (ALL_COMPUNITS): Remove.
1647         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1648         * cp-support.c (add_symbol_overload_list_qualified): Use
1649         objfile_compunits.
1650         * ada-lang.c (ada_collect_symbol_completion_matches)
1651         (ada_add_global_exceptions): Use objfile_compunits.
1652
1653 2019-01-09  Tom Tromey  <tom@tromey.com>
1654
1655         * source.c (select_source_symtab)
1656         (forget_cached_source_info_for_objfile): Remove declaration.
1657         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1658         declaration.
1659         * maint.c (count_symtabs_and_blocks): Remove declaration.
1660         * cp-support.c (add_symbol_overload_list_qualified): Remove
1661         declaration.
1662         * coffread.c (coff_symtab_read): Remove declaration.
1663         * symtab.c (lookup_symbol_in_objfile_symtabs)
1664         (basic_lookup_transparent_type_1): Use objfile_compunits.
1665         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1666         (info_sources_command, search_symbols)
1667         (default_collect_symbol_completion_matches_break_on)
1668         (make_source_files_completion_list): Remove declaration.
1669         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1670         (ada_collect_symbol_completion_matches)
1671         (ada_add_global_exceptions): Remove declaration.
1672         * linespec.c (iterate_over_all_matching_symtabs): Use
1673         objfile_compunits.
1674         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1675         (class objfile_compunits): New.
1676         (ALL_COMPUNITS): Use objfile_compunits.
1677         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1678         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1679         objfile_compunits.
1680         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1681
1682 2019-01-09  Tom Tromey  <tom@tromey.com>
1683
1684         * symtab.c (search_symbols)
1685         (default_collect_symbol_completion_matches_break_on): Use
1686         objfile_msymbols.
1687         * ada-lang.c (ada_lookup_simple_minsym)
1688         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1689         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1690         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1691         objfile_msymbols.
1692         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1693         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1694         * objc-lang.c (find_methods): Use objfile_msymbols.
1695         (info_selectors_command, info_classes_command): Likewise.
1696         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1697         * objfiles.h (class objfile_msymbols): New.
1698         (ALL_OBJFILE_MSYMBOLS): Remove.
1699         (ALL_MSYMBOLS): Remove.
1700
1701 2019-01-09  Tom Tromey  <tom@tromey.com>
1702
1703         * common/next-iterator.h (next_adapter): Add Iterator template
1704         parameter.
1705         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1706         (class all_objfiles_safe): New.
1707         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1708         * objfiles.c (put_objfile_before): Update comment.
1709         (add_separate_debug_objfile): Likewise.
1710         (free_all_objfiles): Use all_objfiles_safe.
1711         (objfile_purge_solibs): Likewise.
1712
1713 2019-01-09  Tom Tromey  <tom@tromey.com>
1714
1715         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1716         (expand_symtab_containing_pc, lookup_static_symbol)
1717         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1718         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1719         all_objfiles.
1720         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1721         * breakpoint.c (create_overlay_event_breakpoint)
1722         (create_longjmp_master_breakpoint)
1723         (create_std_terminate_master_breakpoint)
1724         (create_exception_master_breakpoint): Use all_objfiles.
1725         * linux-thread-db.c (try_thread_db_load_from_pdir)
1726         (has_libpthread): Use all_objfiles.
1727         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1728         * linespec.c (iterate_over_all_matching_symtabs)
1729         (search_minsyms_for_name): Use all_objfiles.
1730         * maint.c (maintenance_info_sections): Use all_objfiles.
1731         * main.c (captured_main_1): Use all_objfiles.
1732         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1733         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1734         * guile/scm-pretty-print.c
1735         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1736         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1737         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1738         (maintenance_print_msymbols): Use all_objfiles.
1739         * source.c (select_source_symtab): Use all_objfiles.
1740         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1741         * symfile.c (remove_symbol_file_command)
1742         (expand_symtabs_matching, map_symbol_filenames): Use
1743         all_objfiles.
1744         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1745         all_objfiles.
1746         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1747         * objc-lang.c (find_methods): Use all_objfiles.
1748         * objfiles.c (have_partial_symbols, have_full_symbols)
1749         (have_minimal_symbols, qsort_cmp)
1750         (default_iterate_over_objfiles_in_search_order): Use
1751         all_objfiles.
1752         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1753         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1754         (maintenance_check_psymtabs): Use all_objfiles.
1755         (ALL_PSYMTABS): Remove.
1756         * compile/compile-object-run.c (do_module_cleanup): Use
1757         all_objfiles.
1758         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1759         * cp-support.c (add_symbol_overload_list_qualified): Use
1760         all_objfiles.
1761         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1762         Use all_objfiles.
1763         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1764         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1765         all_objfiles.
1766         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1767         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1768         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1769         Uses all_objfiles.
1770         * solib.c (solib_read_symbols): Use all_objfiles
1771
1772 2019-01-09  Tom Tromey  <tom@tromey.com>
1773
1774         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1775         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1776         all_objfiles.
1777         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1778         * symmisc.c (print_symbol_bcache_statistics)
1779         (print_objfile_statistics, maintenance_print_objfiles)
1780         (maintenance_info_symtabs, maintenance_check_symtabs)
1781         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1782         all_objfiles.
1783         * source.c (forget_cached_source_info): Use all_objfiles.
1784         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1785         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1786         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1787         * objfiles.c (update_section_map): Use all_objfiles.
1788         (shared_objfile_contains_address_p): Likewise.
1789         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1790         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1791
1792 2019-01-09  Tom Tromey  <tom@tromey.com>
1793
1794         * common/next-iterator.h: New file.
1795         * objfiles.h (class all_objfiles): New.
1796         (struct objfile_iterator): New.
1797
1798 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1799
1800         * NEWS: Move the description of the changed "frame", "select-frame",
1801          and "info frame" commands to the Changed commands section.
1802
1803 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1804
1805         * gdbtypes.c (check_stub_method_group): Remove handling of old
1806         mangling schemes.
1807         * linespec.c (find_methods): Likewise.
1808         * stabsread.c (read_member_functions): Likewise.
1809         * valops.c (search_struct_method): Likewise.
1810         (value_struct_elt_for_reference): Likewise.
1811         * NEWS: Mention this change.
1812
1813 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1814
1815         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1816         print_source_lines.
1817         * source.c (print_source_lines_base): Update line number check.
1818         (print_source_lines): New function.
1819         (source_lines_range::source_lines_range): New function.
1820         * source.h (class source_lines_range): New class.
1821         (print_source_lines): New declaration.
1822
1823 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1824
1825         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1826
1827 2019-01-08  Tom Tromey  <tom@tromey.com>
1828             Simon Marchi  <simon.marchi@ericsson.com>
1829
1830         PR gdb/24060
1831         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1832         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1833         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1834         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1835         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1836         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1837
1838 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1839
1840         * source.c (select_source_symtab): Move header comment to
1841         declaration in source.h.
1842         (forget_cached_source_info_for_objfile): Likewise.
1843         (forget_cached_source_info): Likewise.
1844         (identify_source_line): Likewise.
1845         * source.h (identify_source_line): Move declaration from symtab.h
1846         and add comment from source.c
1847         (print_source_lines): Likewise.
1848         (forget_cached_source_info_for_objfile): Likewise.
1849         (forget_cached_source_info): Likewise.
1850         (select_source_symtab): Likewise.
1851         (enum print_source_lines_flag): Move definition from symtab.h.
1852         * symtab.h (identify_source_line): Move declaration to source.h.
1853         (print_source_lines): Likewise.
1854         (forget_cached_source_info_for_objfile): Likewise.
1855         (forget_cached_source_info): Likewise.
1856         (select_source_symtab): Likewise.
1857         (enum print_source_lines_flag): Move definition to source.h.
1858         * tui/tui-hooks.c: Add 'source.h' include.
1859
1860 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1861
1862         * source.c (print_source_lines_base): Handle requests to print
1863         reverse line number sequences, and guard against empty lines
1864         string.
1865
1866 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1867
1868         * source.c (print_source_lines_base): Fix skip of '\r' if next
1869         character is '\n'.
1870
1871 2019-01-06  Tom Tromey  <tom@tromey.com>
1872
1873         * c-exp.y (struct c_parse_state) <macro_original_text,
1874         expansion_obstack>: New member.
1875         (macro_original_text, expansion_obstack): Remove globals.
1876         (scan_macro_expansion, scanning_macro_expansion)
1877         (finished_macro_expansion): Update.
1878         (scan_macro_cleanup): Remove.
1879         (yylex, c_parse): Update.
1880
1881 2019-01-06  Tom Tromey  <tom@tromey.com>
1882
1883         * c-exp.y (struct c_parse_state) <strings>: New member.
1884         (operator_stoken): Update.
1885
1886 2019-01-06  Tom Tromey  <tom@tromey.com>
1887
1888         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1889         (union type_stack_elt) <typelist_val>: Now a pointer to
1890         std::vector.
1891         (type_stack_cleanup): Don't declare.
1892         (push_typelist): Update.
1893         * parse.c (pop_typelist): Return a std::vector.
1894         (push_typelist): Take a std::vector.
1895         (follow_types): Update.  Do not free args.
1896         (type_stack_cleanup): Remove.
1897         * c-exp.y (struct c_parse_state): New.
1898         (cpstate): New global.
1899         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1900         (nonempty_typelist): Update.
1901         (func_mod): Create a new vector.
1902         (c_parse): Create a c_parse_state.
1903         (check_parameter_typelist): Do not delete params.
1904         (function_method): Update.  Do not delete type_list.
1905
1906 2019-01-06  Tom Tromey  <tom@tromey.com>
1907
1908         PR gdb/28155:
1909         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1910         check_typedef.
1911         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1912         (print_return_value): Likewise.
1913
1914 2019-01-05  Tom Tromey  <tom@tromey.com>
1915
1916         * contrib/cleanup_check.py: Remove.
1917         * contrib/gcc-with-excheck: Remove.
1918         * contrib/exsummary.py: Remove.
1919         * contrib/excheck.py: Remove.
1920
1921 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1922
1923         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1924         NULL. Initialize tpprev to NULL instead of assigning it
1925         to NULL on the next statement.
1926         * windows-nat.c (windows_delete_thread): Remove check for
1927         main_thread_id before printing thread exit notifications.
1928         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1929         Remove thread ID check against main_thread_id.
1930         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1931         windows_delete_thread.
1932         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1933
1934 2019-01-04  Tom Tromey  <tom@tromey.com>
1935
1936         * compile/compile.c (_initialize_compile): Use upper case for
1937         metasyntactic variables.
1938         * symmisc.c (_initialize_symmisc): Use upper case for
1939         metasyntactic variables.
1940         * psymtab.c (_initialize_psymtab): Use upper case for
1941         metasyntactic variables.
1942         * demangle.c (demangle_command): Use upper case for metasyntactic
1943         variables.
1944         (_initialize_demangler): Likewise.
1945         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1946         variables.
1947
1948 2019-01-03  Tom Tromey  <tom@tromey.com>
1949
1950         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1951
1952 2019-01-03  Tom Tromey  <tom@tromey.com>
1953
1954         * python/py-symtab.c (salpy_str): Update.
1955         (struct salpy_sal_object) <symtab>: Now a PyObject.
1956         (salpy_dealloc): Update.
1957         (del_objfile_sal): Use gdbpy_ref.
1958
1959 2019-01-03  Tom Tromey  <tom@tromey.com>
1960
1961         * python/py-type.c (convert_field): Use new_reference.  Return
1962         gdbpy_ref.
1963         (make_fielditem): Return gdbpy_ref.
1964         (typy_fields): Update.
1965         (typy_getitem): Update.
1966         (field_name): Return gdbpy_ref.  Use new_reference.
1967         (typy_iterator_iternext): Update.
1968
1969 2019-01-03  Tom Tromey  <tom@tromey.com>
1970
1971         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1972
1973 2019-01-03  Tom Tromey  <tom@tromey.com>
1974
1975         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1976         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1977         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1978         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1979         (pspy_set_type_printers): Likewise.
1980         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1981         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1982         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1983         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1984         (objfpy_set_type_printers): Likewise.
1985
1986 2019-01-03  Tom Tromey  <tom@tromey.com>
1987
1988         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1989         (gdbpy_print_stack): Use gdbpy_err_fetch.
1990         * python/python-internal.h (class gdbpy_err_fetch): New class.
1991         (class gdbpy_enter) <m_error_type, m_error_value,
1992         m_error_traceback>: Remove.
1993         <m_error>: New member.
1994         (gdbpy_exception_to_string): Don't declare.
1995         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1996         * python/py-value.c (convert_value_from_python): Use
1997         gdbpy_err_fetch.
1998         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1999         gdbpy_exception_to_string.
2000         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2001         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2002         gdbpy_err_fetch.
2003
2004 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2005
2006         * linux-nat.c (delete_lwp_cleanup): Delete.
2007         (struct lwp_deleter): New struct.
2008         (lwp_info_up): New typedef.
2009         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2010         lwp_info_up.
2011
2012 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2013
2014         * linux-fork.c (class scoped_switch_fork_info): New class.
2015         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2016
2017 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2018
2019         * valops.c (find_overload_match): Remove use of null_cleanup, and
2020         calls to do_cleanups.
2021
2022 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2023
2024         * compile/compile-cplus-types.c
2025         (compile_cplus_instance::decl_name): Handle changes to
2026         cp_func_name.
2027         * cp-support.c (cp_func_name): Update header comment, update
2028         return type.
2029         * cp-support.h (cp_func_name): Update return type in declaration.
2030         * valops.c (find_overload_match): Move temp_func local to top
2031         level of function and change its type.  Use temp_func to hold and
2032         delete temporary string obtained from cp_func_name.
2033
2034 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2035
2036         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2037         gdb::char_vector, remove cleanup, and update uses of `msg`.
2038
2039 2019-01-03  Jim Wilson  <jimw@sifive.com>
2040
2041         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2042
2043 2019-01-02  Tom Tromey  <tom@tromey.com>
2044
2045         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2046         (tdesc_parse_xml): Remove cleanups.
2047         * target-descriptions.h (make_cleanup_free_target_description):
2048         Don't declare.
2049         (target_desc_deleter): New struct.
2050         (target_desc_up): New typedef.
2051         * target-descriptions.c (target_desc_deleter::operator()): Rename
2052         from free_target_description.
2053         (make_cleanup_free_target_description): Remove.
2054
2055 2019-01-02  Tom Tromey  <tom@tromey.com>
2056
2057         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2058         constructor, destructor.
2059         (linespec_parser): Remove typedef.
2060         (~linespec_parser): Rename from linespec_parser_delete.
2061         (linespec_lex_to_end, linespec_complete_label)
2062         (linespec_complete): Update.
2063         (decode_line_full): Remove cleanups.
2064         (decode_line_1): Update.
2065
2066 2019-01-02  Tom Tromey  <tom@tromey.com>
2067
2068         * python/python-internal.h (inferior_to_inferior_object): Change
2069         return type.
2070         * python/py-exitedevent.c (create_exited_event_object): Update.
2071         * python/py-inferior.c (inferior_to_inferior_object): Return
2072         gdbpy_ref.
2073         (python_new_inferior, python_inferior_deleted)
2074         (thread_to_thread_object, delete_thread_object)
2075         (build_inferior_list, gdbpy_selected_inferior): Update.
2076         * python/py-infthread.c (create_thread_object): Update.  Also fail
2077         if inferior_to_inferior_object fails.
2078
2079 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2080
2081         * inferior.h (class inferior) <displaced_step_state>: New field.
2082         * infrun.h (struct displaced_step_state): Move here from
2083         infrun.c.  Initialize fields, add constructor.
2084         <inf>: Remove field.
2085         <reset>: New method.
2086         * infrun.c (struct displaced_step_inferior_state): Move to
2087         infrun.h.
2088         (displaced_step_inferior_states): Remove.
2089         (get_displaced_stepping_state): Adust.
2090         (displaced_step_in_progress_any_inferior): Adjust.
2091         (displaced_step_in_progress_thread): Adjust.
2092         (displaced_step_in_progress): Adjust.
2093         (add_displaced_stepping_state): Remove.
2094         (get_displaced_step_closure_by_addr): Adjust.
2095         (remove_displaced_stepping_state): Remove.
2096         (infrun_inferior_exit): Call displaced_step_state.reset.
2097         (use_displaced_stepping): Don't check for NULL.
2098         (displaced_step_prepare_throw): Call
2099         get_displaced_stepping_state.
2100         (displaced_step_fixup): Don't check for NULL.
2101         (prepare_for_detach): Don't check for NULL.
2102
2103 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2104
2105         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2106          in case of call that did not complete.
2107
2108 2019-01-02  Andrey Utkin  <autkin@undo.io>
2109
2110         * symfile.c (find_separate_debug_file): Fix search of debug files for
2111         remote debuggee.
2112
2113 2019-01-02  Tom Tromey  <tom@tromey.com>
2114
2115         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2116         indentation.
2117         * python/py-frame.c (frapy_older): Remove cast.
2118         (frapy_newer): Likewise.
2119         * python/py-breakpoint.c (local_setattro): Remove cast.
2120         * python/py-arch.c (archpy_name): Remove local variable.
2121         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2122
2123 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2124
2125         * unittests/basic_string_view/element_access/char/empty.cc:
2126         Fix year range in copyright header.
2127
2128 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2129
2130         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2131         Delete.
2132         <operator==>: Update with for removed field.
2133         <hash>: Likewise.
2134         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2135         <isa_features>: ...this.
2136         <abi_features>: New field.
2137         (riscv_isa_flen): Update comment.
2138         (riscv_abi_xlen): New declaration.
2139         (riscv_abi_flen): New declaration.
2140         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2141         isa_features.
2142         (riscv_abi_xlen): New function.
2143         (riscv_isa_flen): Update to get answer from isa_features.
2144         (riscv_abi_flen): New function.
2145         (riscv_has_fp_abi): Update to get answer from abi_features.
2146         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2147         xlen and flen.
2148         (riscv_call_info) <xlen, flen>: Update comment.
2149         (riscv_call_arg_struct): Remove invalid assertions
2150         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2151         is removed.
2152         (riscv_gdbarch_init): Gather isa features and abi features
2153         separately, ensure both match on the gdbarch when reusing an old
2154         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2155         a target with 64-bit float hardware.
2156
2157 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2158
2159         * source.c (search_command_helper): Stop reverse search
2160         when line 1 has been searched.
2161
2162 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2163
2164         * record-full.c (record_full_base_target::close): Rewrite
2165         record_full_core_buf_list free logic.
2166
2167 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2168
2169         * break-catch-syscall.c (print_one_catch_syscall): xfree
2170         the last text.
2171
2172 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2173
2174         * top.c (print_gdb_version): Update Copyright year in version
2175         message.
2176
2177 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2178
2179         Update copyright year range in all GDB files.
2180
2181 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2182
2183         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2184
2185 For older changes see ChangeLog-2018.
2186 \f
2187 Local Variables:
2188 mode: change-log
2189 left-margin: 8
2190 fill-column: 74
2191 version-control: never
2192 coding: utf-8
2193 End:
2194