gdb/ChangeLog

   1 2019-01-22  Tom Tromey  <tom@tromey.com>
   2
   3         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
   4         keyword for bcache.
   5
   6 2019-01-22  Tom Tromey  <tom@tromey.com>
   7
   8         * compile/compile-cplus-types.c: Remove a comment by #include.
   9
  10 2019-01-22  Tom Tromey  <tom@tromey.com>
  11
  12         * compile/gcc-c-plugin.h: Include compile-internal.h.
  13
  14 2019-01-22  Tom Tromey  <tom@tromey.com>
  15
  16         * stabsread.c (EXTERN): Do not define.
  17         (symnum, next_symbol_text_func, processing_gcc_compilation)
  18         (within_function, global_sym_chain, global_stabs)
  19         (previous_stab_code, this_object_header_files)
  20         (n_this_object_header_files)
  21         (n_allocated_this_object_header_files): Define.
  22         * stabsread.h (EXTERN): Never define.  Use "extern".
  23
  24 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  25
  26         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
  27         history_value.
  28
  29 2019-01-21  Tom Tromey  <tom@tromey.com>
  30
  31         * ui-out.c: Fix includes.
  32         * tui/tui-source.c: Fix includes.
  33         * target.c: Fix includes.
  34         * remote.c: Fix includes.
  35         * regcache.c: Fix includes.
  36         * python/py-block.c: Fix includes.
  37         * printcmd.c: Fix includes.
  38         * or1k-tdep.c: Fix includes.
  39         * mi/mi-main.c: Fix includes.
  40         * m32r-tdep.c: Fix includes.
  41         * csky-tdep.c: Fix includes.
  42         * compile/compile-cplus-types.c: Fix includes.
  43         * cli/cli-interp.c: Fix includes.
  44
  45 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
  46
  47         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
  48         for padding.
  49
  50 2019-01-16  Tom Tromey  <tom@tromey.com>
  51
  52         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
  53         earlier.
  54         (struct objfile) <msymbols_range>: Move from top level.
  55         <msymbols>: New method.
  56         (class objfile_msymbols): Remove.
  57         * symtab.c (default_collect_symbol_completion_matches_break_on):
  58         Update.
  59         * symmisc.c (dump_msymbols): Update.
  60         * stabsread.c (scan_file_globals): Update.
  61         * objc-lang.c (info_selectors_command, info_classes_command)
  62         (find_methods): Update.
  63         * minsyms.c (find_solib_trampoline_target): Update.
  64         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
  65         * coffread.c (coff_symfile_read): Update.
  66         * ada-lang.c (ada_lookup_simple_minsym)
  67         (ada_collect_symbol_completion_matches): Update.
  68
  69 2019-01-16  Tom Tromey  <tom@tromey.com>
  70
  71         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
  72         type.  Remove no-argument constructor.
  73         <iterator::operator++>: Simplify.
  74         <begin>: Update.
  75         <end>: Use minimal_symbol_count.
  76
  77 2019-01-16  Tom Tromey  <tom@tromey.com>
  78
  79         * objfiles.h (struct objfile) <psymtabs>: New method.
  80         (class objfile_psymtabs): Remove.
  81         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
  82         typedef.
  83         <range>: New method.
  84         (require_partial_symbols): Change return type.
  85         * psymtab.c (require_partial_symbols)
  86         (psym_expand_symtabs_matching): Update.
  87         * mdebugread.c (parse_partial_symbols): Update.
  88         * dbxread.c (dbx_end_psymtab): Update.
  89
  90 2019-01-15  Tom Tromey  <tom@tromey.com>
  91
  92         * symtab.c (lookup_objfile_from_block)
  93         (lookup_symbol_in_objfile_symtabs)
  94         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
  95         (find_line_symtab, info_sources_command)
  96         (default_collect_symbol_completion_matches_break_on)
  97         (make_source_files_completion_list): Update.
  98         * symmisc.c (print_objfile_statistics, dump_objfile)
  99         (maintenance_print_symbols, maintenance_info_symtabs)
 100         (maintenance_check_symtabs, maintenance_info_line_tables):
 101         Update.
 102         * source.c (select_source_symtab)
 103         (forget_cached_source_info_for_objfile): Update.
 104         * objfiles.h (class objfile_compunits): Remove.
 105         (struct objfile) <compunits_range>: New typedef.
 106         (compunits): New method.
 107         * objfiles.c (objfile_relocate1): Update.
 108         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 109         * maint.c (count_symtabs_and_blocks): Update.
 110         * linespec.c (iterate_over_all_matching_symtabs): Update.
 111         * cp-support.c (add_symbol_overload_list_qualified): Update.
 112         * coffread.c (coff_symtab_read): Update.
 113         * ada-lang.c (add_nonlocal_symbols)
 114         (ada_collect_symbol_completion_matches)
 115         (ada_add_global_exceptions): Update.
 116
 117 2019-01-15  Tom Tromey  <tom@tromey.com>
 118
 119         * progspace.h (program_space) <objfiles_safe_range>: New
 120         typedef.
 121         <objfiles_safe>: New method.
 122         * objfiles.h (class all_objfiles_safe): Remove.
 123         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
 124         * jit.c (jit_inferior_exit_hook): Update.
 125
 126 2019-01-17  Tom Tromey  <tom@tromey.com>
 127
 128         * progspace.h (program_space) <objfiles_range>: New typedef.
 129         <objfiles>: New method.
 130         <objfiles_head>: Rename from objfiles.
 131         (object_files): Update.
 132         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
 133         * guile/scm-pretty-print.c
 134         (ppscm_find_pretty_printer_from_objfiles): Update.
 135         * guile/scm-objfile.c (gdbscm_objfiles): Update.
 136         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
 137         Update.
 138         * python/py-progspace.c (pspy_get_objfiles): Update.
 139         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 140         Update.
 141         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 142         (objfpy_lookup_objfile_by_build_id): Update.
 143         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 144         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 145         Update.
 146         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 147         (expand_symtab_containing_pc, lookup_objfile_from_block)
 148         (lookup_static_symbol, basic_lookup_transparent_type)
 149         (find_pc_sect_compunit_symtab, find_symbol_at_address)
 150         (find_line_symtab, info_sources_command)
 151         (default_collect_symbol_completion_matches_break_on)
 152         (make_source_files_completion_list, find_main_name): Update.
 153         * symmisc.c (print_symbol_bcache_statistics)
 154         (print_objfile_statistics, maintenance_print_symbols)
 155         (maintenance_print_msymbols, maintenance_print_objfiles)
 156         (maintenance_info_symtabs, maintenance_check_symtabs)
 157         (maintenance_expand_symtabs, maintenance_info_line_tables):
 158         Update.
 159         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
 160         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
 161         (map_overlay_command, unmap_overlay_command)
 162         (simple_overlay_update, expand_symtabs_matching)
 163         (map_symbol_filenames): Update.
 164         * symfile-debug.c (set_debug_symfile): Update.
 165         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
 166         Update.
 167         * source.c (select_source_symtab, forget_cached_source_info):
 168         Update.
 169         * solib.c (solib_read_symbols): Update.
 170         * solib-spu.c (append_ocl_sos): Update.
 171         * psymtab.c (maintenance_print_psymbols)
 172         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
 173         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
 174         * printcmd.c (info_symbol_command): Update.
 175         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
 176         Update.
 177         * objfiles.h (class all_objfiles): Remove.
 178         * objfiles.c (have_partial_symbols, have_full_symbols)
 179         (have_minimal_symbols, qsort_cmp, update_section_map)
 180         (shared_objfile_contains_address_p)
 181         (default_iterate_over_objfiles_in_search_order): Update.
 182         * objc-lang.c (info_selectors_command, info_classes_command)
 183         (find_methods): Update.
 184         * minsyms.c (find_solib_trampoline_target): Update.
 185         * maint.c (maintenance_info_sections)
 186         (maintenance_translate_address, count_symtabs_and_blocks):
 187         Update.
 188         * main.c (captured_main_1): Update.
 189         * linux-thread-db.c (try_thread_db_load_from_pdir)
 190         (has_libpthread): Update.
 191         * linespec.c (iterate_over_all_matching_symtabs)
 192         (search_minsyms_for_name): Update.
 193         * jit.c (jit_find_objf_with_entry_addr): Update.
 194         * hppa-tdep.c (find_unwind_entry)
 195         (hppa_lookup_stub_minimal_symbol): Update.
 196         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
 197         Update.
 198         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 199         (elf_gnu_ifunc_resolve_by_got): Update.
 200         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
 201         * dwarf-index-write.c (save_gdb_index_command): Update.
 202         * cp-support.c (add_symbol_overload_list_qualified): Update.
 203         * breakpoint.c (create_overlay_event_breakpoint)
 204         (create_longjmp_master_breakpoint)
 205         (create_std_terminate_master_breakpoint)
 206         (create_exception_master_breakpoint): Update.
 207         * blockframe.c (find_pc_partial_function): Update.
 208         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
 209         (ada_collect_symbol_completion_matches)
 210         (ada_add_global_exceptions): Update.
 211
 212 2019-01-17  Tom Tromey  <tom@tromey.com>
 213
 214         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
 215         declare VEC.
 216         (solib_target_parse_libraries): Change return type.
 217         (library_list_start_segment, library_list_start_section)
 218         (library_list_end_library, library_list_start_library); Update.
 219         (solib_target_free_library_list): Remove.
 220         (solib_target_parse_libraries): Remove cleanup.  Change return
 221         type.
 222         (solib_target_current_sos): Update.
 223
 224 2019-01-17  Tom Tromey  <tromey@bapiya>
 225
 226         * valprint.c: Replace "the the" with "the".
 227         * symtab.c: Replace "the the" with "the".
 228         * solib.c: Replace "the the" with "the".
 229         * solib-dsbt.c: Replace "the the" with "the".
 230         * linespec.c: Replace "the the" with "the".
 231         * dwarf2loc.h: Replace "the the" with "the".
 232         * amd64-windows-tdep.c: Replace "the the" with "the".
 233         * aarch64-tdep.c: Replace "the the" with "the".
 234
 235 2019-01-16  Keith Seitz  <keiths@redhat.com>
 236
 237         PR gdb/23773
 238         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
 239         <builder>: Rename to ..
 240         <m_builder>: ... this and make private.
 241         (dwarf2_cu::get_builder): New method.  Change all users of
 242         `builder' to use this method.
 243         (dwarf2_start_symtab): Move to ...
 244         (dwarf2_cu::start_symtab): ... here.  Update all callers
 245         (setup_type_unit_groups): Move to ...
 246         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
 247         callers.
 248         (dwarf2_cu::reset_builder): New method.
 249         (process_full_compunit, process_full_type_unit): Use
 250         dwarf2_cu::reset_builder.
 251         (follow_die_offset): Record the ancestor CU if it is different
 252         from the followed DIE's CU.
 253         (follow_die_sig_1): Likewise.
 254
 255 2019-01-15  Tom Tromey  <tom@tromey.com>
 256
 257         * remote.c (class remote_state) <buf>: Now a char_vector.
 258         <buf_size>: Remove.
 259         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
 260         parameter.
 261         (remote_target::getpkt_or_notif_sane_1)
 262         (remote_target::getpkt_sane)
 263         (remote_target::getpkt_or_notif_sane): Likewise.
 264         (class remote_target) <putpkt>: New overload.
 265         (remote_target::read_frame): Change type of "buf_p".  Remove
 266         sizeof_p parameter.
 267         (packet_ok): New overload.
 268         (packet_check_result): New overload.
 269         Update all uses.
 270
 271 2019-01-14  Tom Tromey  <tom@tromey.com>
 272
 273         * remote-notif.c (handle_notification, remote_notif_ack)
 274         (remote_notif_parse): Make "buf" const.
 275         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
 276         const.
 277         (remote_notif_parse, remote_notif_ack, handle_notification):
 278         Likewise.
 279         * remote.c (remote_notif_stop_parse): Make "buf" const.
 280         (remote_target::remote_parse_stop_reply): Make "buf" const.
 281         (remote_notif_stop_ack): Make "buf" const.
 282
 283 2019-01-14  Tom Tromey  <tom@tromey.com>
 284
 285         * remote.c (remote_console_output): Make parameter const.
 286
 287 2019-01-14  Tom Tromey  <tom@tromey.com>
 288
 289         * target-debug.h (target_debug_print_signals): Constify.
 290         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
 291         * procfs.c (procfs_target::pass_signals): Update.
 292         * linux-nat.c (linux_nat_target::pass_signals): Update.
 293         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
 294         * target-delegates.c: Rebuild.
 295         * remote.c (remote_target::program_signals): Update.
 296         (remote_target::pass_signals): Update.
 297         * target.c (target_pass_signals): Constify argument.
 298         (target_program_signals): Likewise.
 299         * target.h (struct target_ops) <pass_signals, program_signals>:
 300         Constify argument.
 301         (target_pass_signals, target_program_signals): Constify argument.
 302
 303 2019-01-14  Tom Tromey  <tom@tromey.com>
 304
 305         PR tui/28819:
 306         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
 307
 308 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 309
 310         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
 311         field.
 312         * rs6000-tdep.c: Include reggroups.h.
 313         (IS_V_ALIAS_PSEUDOREG): Define.
 314         (rs6000_register_name): Return names for the "vX" aliases.
 315         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
 316         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
 317         aliases.  Call default_register_reggroup_p for all other
 318         pseudo-registers.
 319         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
 320         New functions.
 321         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
 322         Handle "vX" aliases.
 323         (v_alias_pseudo_register_collect): New function.
 324         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
 325         (rs6000_gdbarch_init): Initialize "vX" aliases as
 326         pseudo-registers.  Restore registration of
 327         rs6000_pseudo_register_reggroup_p with
 328         set_tdesc_pseudo_register_reggroup_p.
 329
 330 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
 331
 332         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
 333         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
 334         set_gdbarch_num_pseudo_regs.
 335
 336 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 337
 338         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
 339         Remove arg prefixname, add do_set and do_show.
 340         Add member functions set_list and show_list.
 341         * cli/cli-style.c (class cli_style_option): Update accordingly.
 342         (style_set_list): Move to file scope.
 343         (style_show_list): Likewise.
 344         (set_style): Call help_list.
 345         (show_style): Call cmd_show_list.
 346         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
 347         Update to use the new macro.
 348
 349 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
 350
 351         * ada-lang.c (_initialize_ada_language): Expand the help text
 352         for the "catch exception" command.
 353
 354 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 355
 356         * symtab.c (matching_obj_sections): Initialize obj,
 357         declare it closer to its usage.
 358
 359 2019-01-10  Tom Tromey  <tom@tromey.com>
 360
 361         * thread-iter.h (inf_threads_iterator): Use next_iterator.
 362         (basic_inf_threads_range): Remove.
 363         (inf_threads_range, inf_non_exited_threads_range)
 364         (safe_inf_threads_range): Use next_adapter.
 365
 366 2019-01-10  Keith Seitz  <keiths@redhat.com>
 367
 368         PR gdb/23712
 369         PR symtab/23010
 370         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
 371         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
 372
 373 2019-01-10  Keith Seitz  <keiths@redhat.com>
 374
 375         PR gdb/23712
 376         PR symtab/23010
 377         * dictionary.c (pending_to_vector): Remove.
 378         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 379         Remove _1 suffix, replacing functions of the same name.  Update
 380         all callers.
 381         (dict_create_hashed, dict_create_hashed_expandable)
 382         (dict_create_linear, dict_create_linear_expandable, dict_free)
 383         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
 384         Make functions static.
 385
 386 2019-01-10  Keith Seitz  <keiths@redhat.com>
 387
 388         PR gdb/23712
 389         PR symtab/23010
 390         * dictionary.h (struct dictionary): Replace declaration with
 391         multidictionary.
 392         (dict_create_hashed, dict_create_hashed_expandable)
 393         (dict_create_linear, dict_create_linear_expandable)
 394         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
 395         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
 396         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
 397         taking multidictionary argument.
 398         [ALL_DICT_SYMBOLS]: Update for multidictionary.
 399         * block.h (struct block) <dict>: Change to multidictionary
 400         and rename `multidict'.
 401         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
 402         symmisc.c: Update all dictionary references to multidictionary.
 403
 404 2019-01-10  Keith Seitz  <keiths@redhat.com>
 405
 406         PR gdb/23712
 407         PR symtab/23010
 408         * dictionary.c: Include unordered_map.
 409         (pending_to_vector): New function.
 410         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 411         Rewrite the non-"_1" functions to take vector instead
 412         of linked list.
 413         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
 414         "new" _1 versions of the same name.
 415         (multidictionary): Define.
 416         (std::hash<enum language): New definition.
 417         (collate_pending_symbols_by_language, mdict_create_hashed)
 418         (mdict_create_hashed_expandable, mdict_create_linear)
 419         (mdict_create_linear_expandable, mdict_free)
 420         (find_language_dictionary, create_new_language_dictionary)
 421         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
 422         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
 423         (mdict_size, mdict_empty): New functions.
 424         * dictionary.h (mdict_iterator): Define.
 425
 426 2019-01-10  Pedro Alves  <palves@redhat.com>
 427
 428         * breakpoint.c (read_uploaded_action)
 429         (create_tracepoint_from_upload): Adjust to use
 430         gdb::unique_xmalloc_ptr.
 431         * ctf.c (ctf_write_uploaded_tp):
 432         (SET_ARRAY_FIELD): Use emplace_back.
 433         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
 434         * tracefile-tfile.c (tfile_write_uploaded_tp):
 435         * tracepoint.c (parse_tracepoint_definition): Adjust to use
 436         gdb::unique_xmalloc_ptr.
 437         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
 438         at_string, cond_string, cmd_strings>: Replace char pointers
 439         with gdb::unique_xmalloc_ptr.
 440
 441 2019-01-10  Pedro Alves  <palves@redhat.com>
 442
 443         * solib-target.c (library_list_start_library): Don't xstrdup name.
 444
 445 2019-01-10  Pedro Alves  <palves@redhat.com>
 446
 447         * mdebugread.c (parse_partial_symbols): Use
 448         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
 449
 450 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 451
 452         * linux-fork.c (scoped_switch_fork_info)
 453         <~scoped_switch_fork_info>: Fix incorrect variable name.
 454
 455 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 456
 457         * linux-fork.c (scoped_switch_fork_info)
 458         <scoped_switch_fork_info>: Make explicit.
 459         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
 460
 461 2019-01-10  Tom Tromey  <tom@tromey.com>
 462
 463         * objfiles.h (objfile::reset_psymtabs): Update.
 464         * objfiles.c (objfile::objfile): Update.
 465         * psymtab.h (psymtab_storage::obstack): Update.
 466         (psymtab_storage::m_obstack): Use gdb::optional.
 467         (class psymtab_storage): Update comment.  Remove objfile
 468         parameter.
 469         * psymtab.c (psymtab_storage::psymtab_storage): Update.
 470
 471 2019-01-10  Tom Tromey  <tom@tromey.com>
 472
 473         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
 474         <free_psymtabs>: Now private.
 475         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
 476         (allocate_psymtab): Use new method.
 477
 478 2019-01-10  Tom Tromey  <tom@tromey.com>
 479
 480         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
 481         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
 482         * mdebugread.c (parse_partial_symbols): Use
 483         allocate_dependencies.
 484         * dwarf2read.c (dwarf2_create_include_psymtab): Use
 485         allocate_dependencies.
 486         (process_psymtab_comp_unit_reader)
 487         (build_type_psymtab_dependencies): Likewise.
 488         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
 489
 490 2019-01-10  Tom Tromey  <tom@tromey.com>
 491
 492         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
 493         PSYMBOL_SET_LANGUAGE.
 494         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
 495
 496 2019-01-10  Tom Tromey  <tom@tromey.com>
 497
 498         * psymtab.h (psymtab_storage::obstack): New method.
 499         <m_obstack>: Rename from obstack; now private.
 500         * psymtab.c (psymtab_storage): Update.
 501         * dwarf2read.c (create_addrmap_from_index)
 502         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
 503         Update.
 504
 505 2019-01-10  Tom Tromey  <tom@tromey.com>
 506
 507         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
 508         * objfiles.h (objfile::reset_psymtabs): New method.
 509
 510 2019-01-10  Tom Tromey  <tom@tromey.com>
 511
 512         * symmisc.c (print_symbol_bcache_statistics): Update.
 513         (print_objfile_statistics): Update.
 514         * symfile.c (reread_symbols): Update.
 515         * psymtab.h (class psymtab_storage): New.
 516         * psymtab.c (psymtab_storage): New constructor.
 517         (~psymtab_storage): New destructor.
 518         (require_partial_symbols): Update.
 519         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
 520         (find_pc_sect_psymtab, find_pc_sect_psymbol)
 521         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
 522         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
 523         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
 524         (start_psymtab_common, end_psymtab_common)
 525         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
 526         (allocate_psymtab): Update.
 527         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
 528         Update.
 529         (dump_psymtab_addrmap, maintenance_print_psymbols)
 530         (maintenance_check_psymtabs): Update.
 531         (class objfile_psymtabs): Move to objfiles.h.
 532         * psympriv.h (discard_psymtab): Now inline.
 533         (psymtab_discarder::psymtab_discarder): Update.
 534         (psymtab_discarder::~psymtab_discarder): Update.
 535         (ALL_OBJFILE_PSYMTABS): Rewrite.
 536         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
 537         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
 538         Remove fields.
 539         <partial_symtabs>: New field.
 540         (class objfile_psymtabs): Move from psymtab.h.  Update.
 541         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
 542         psymbol_cache.
 543         (objfile::~objfile): Don't destroy psymbol_cache.
 544         * mdebugread.c (parse_partial_symbols): Update.
 545         * dwarf2read.c (create_addrmap_from_index)
 546         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 547         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
 548         (add_partial_subprogram, dwarf2_ranges_read): Update.
 549         * dwarf-index-write.c (write_address_map)
 550         (write_one_signatured_type, recursively_write_psymbols)
 551         (class debug_names, class debug_names, write_psymtabs_to_index):
 552         Update.
 553
 554 2019-01-10  Tom Tromey  <tom@tromey.com>
 555
 556         * symtab.h (SYMBOL_SET_NAMES): Update.
 557         (symbol_set_names): Update.
 558         (MSYMBOL_SET_NAMES): Update.
 559         * symtab.c (symbol_set_names): Change argument to be an
 560         objfile_per_bfd_storage.
 561         * psymtab.c (add_psymbol_to_bcache): Update.
 562         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
 563
 564 2019-01-10  Tom Tromey  <tom@tromey.com>
 565
 566         * symtab.c (create_demangled_names_hash): Change argument to be an
 567         objfile_per_bfd_storage.
 568         (symbol_set_names): Update.
 569
 570 2019-01-10  Tom Tromey  <tom@tromey.com>
 571
 572         * xcoffread.c (xcoff_initial_scan): Unconditionally call
 573         init_psymbol_list.
 574         * psymtab.c (init_psymbol_list): Do nothing if already called.
 575         * psympriv.h (init_psymbol_list): Add comment.
 576         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
 577         init_psymbol_list.
 578         * dbxread.c (dbx_symfile_read): Unconditionally call
 579         init_psymbol_list.
 580
 581 2019-01-10  Tom Tromey  <tom@tromey.com>
 582
 583         * xcoffread.c (scan_xcoff_symtab): Update.
 584         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
 585         "where".
 586         * mdebugread.c (parse_partial_symbols)
 587         (handle_psymbol_enumerators): Update.
 588         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
 589         * dbxread.c (read_dbx_symtab): Update.
 590         * psympriv.h (psymbol_placement): New enum.
 591         (add_psymbol_to_list): Update.
 592
 593 2019-01-10  Tom Tromey  <tom@tromey.com>
 594
 595         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
 596         static_psymbols parameters.
 597         (scan_xcoff_symtab): Update.
 598         * psymtab.c (start_psymtab_common): Remove global_psymbols and
 599         static_psymbols parameters.
 600         * psympriv.h (start_psymtab_common): Update.
 601         * mdebugread.c (parse_partial_symbols): Update.
 602         * dwarf2read.c (create_partial_symtab): Update.
 603         * dbxread.c (read_dbx_symtab): Update.
 604         (start_psymtab): Remove global_psymbols and static_psymbols
 605         parameters.
 606
 607 2019-01-10  Tom Tromey  <tom@tromey.com>
 608
 609         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
 610         * psymtab.c (allocate_psymtab): Add comment.
 611         * psympriv.h (allocate_psymtab): Add comment.
 612         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
 613         initializations.
 614         * dbxread.c (dbx_end_psymtab): Remove some initializations.
 615
 616 2019-01-10  Tom Tromey  <tom@tromey.com>
 617
 618         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 619         Don't declare.
 620         * mipsread.c: Include mdebugread.h.
 621         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 622         Declare.
 623         * elfread.c: Include mdebugread.h.
 624
 625 2019-01-09  Tom Tromey  <tom@tromey.com>
 626
 627         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
 628         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
 629         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
 630         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 631         (psym_lookup_symbol, psym_find_last_source_symtab)
 632         (psym_forget_cached_source_info, psym_print_stats)
 633         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 634         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 635         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 636         (psym_find_compunit_symtab_by_address)
 637         (maintenance_print_psymbols, maintenance_info_psymtabs)
 638         (maintenance_check_psymtabs): Use ranged for.
 639         * psymtab.h (class objfile_psymtabs): New.
 640         (require_partial_symbols): Return objfile_psymtabs.
 641         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
 642
 643 2019-01-09  Tom Tromey  <tom@tromey.com>
 644
 645         * symfile.c (overlay_invalidate_all, find_pc_overlay)
 646         (find_pc_mapped_section, list_overlays_command)
 647         (map_overlay_command, unmap_overlay_command)
 648         (simple_overlay_update): Use all_objfiles.
 649         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
 650         * printcmd.c (info_symbol_command): Use all_objfiles.
 651         * objfiles.h (ALL_OBJSECTIONS): Remove.
 652         * maint.c (maintenance_translate_address): Use all_objfiles.
 653         * gcore.c (gcore_create_callback): Use all_objfiles.
 654         (objfile_find_memory_regions): Likewise.
 655
 656 2019-01-09  Tom Tromey  <tom@tromey.com>
 657
 658         * symtab.c (find_line_symtab, info_sources_command)
 659         (make_source_files_completion_list): Use objfile_compunits.
 660         * source.c (select_source_symtab): Use objfile_compunits.
 661         * objfiles.h (struct objfile): Update comment.
 662         (ALL_OBJFILES): Remove.
 663         (ALL_FILETABS): Remove.
 664         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
 665         objfile_compunits.
 666
 667 2019-01-09  Tom Tromey  <tom@tromey.com>
 668
 669         * symmisc.c (print_objfile_statistics, dump_objfile)
 670         (maintenance_print_symbols): Use compunit_filetabs.
 671         * source.c (forget_cached_source_info_for_objfile): Use
 672         compunit_filetabs.
 673         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
 674         (ALL_FILETABS): Use compunit_filetabs.
 675         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
 676         * coffread.c (coff_symtab_read): Use compunit_filetabs.
 677
 678 2019-01-09  Tom Tromey  <tom@tromey.com>
 679
 680         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
 681         (compunit_filetabs): New.
 682         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
 683         compunit_filetabs.
 684         (info_sources_command, make_source_files_completion_list): Remove
 685         declaration.
 686         * symmisc.c (print_objfile_statistics, dump_objfile)
 687         (maintenance_print_symbols): Remove declaration.
 688         (maintenance_info_symtabs): Use compunit_filetabs.
 689         (maintenance_info_line_tables): Likewise.
 690         * source.c (select_source_symtab): Change local variable name.
 691         (forget_cached_source_info_for_objfile): Remove declaration.
 692         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
 693         * objfiles.c (objfile_relocate1): Remove declaration.
 694         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 695         declaration.
 696         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
 697         * coffread.c (coff_symtab_read): Remove declaration.
 698         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 699         compunit_filetabs.
 700
 701 2019-01-09  Tom Tromey  <tom@tromey.com>
 702
 703         * symtab.c (lookup_objfile_from_block)
 704         (find_pc_sect_compunit_symtab, search_symbols)
 705         (default_collect_symbol_completion_matches_break_on): Use
 706         objfile_compunits.
 707         * objfiles.h (ALL_COMPUNITS): Remove.
 708         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
 709         * cp-support.c (add_symbol_overload_list_qualified): Use
 710         objfile_compunits.
 711         * ada-lang.c (ada_collect_symbol_completion_matches)
 712         (ada_add_global_exceptions): Use objfile_compunits.
 713
 714 2019-01-09  Tom Tromey  <tom@tromey.com>
 715
 716         * source.c (select_source_symtab)
 717         (forget_cached_source_info_for_objfile): Remove declaration.
 718         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 719         declaration.
 720         * maint.c (count_symtabs_and_blocks): Remove declaration.
 721         * cp-support.c (add_symbol_overload_list_qualified): Remove
 722         declaration.
 723         * coffread.c (coff_symtab_read): Remove declaration.
 724         * symtab.c (lookup_symbol_in_objfile_symtabs)
 725         (basic_lookup_transparent_type_1): Use objfile_compunits.
 726         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
 727         (info_sources_command, search_symbols)
 728         (default_collect_symbol_completion_matches_break_on)
 729         (make_source_files_completion_list): Remove declaration.
 730         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
 731         (ada_collect_symbol_completion_matches)
 732         (ada_add_global_exceptions): Remove declaration.
 733         * linespec.c (iterate_over_all_matching_symtabs): Use
 734         objfile_compunits.
 735         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
 736         (class objfile_compunits): New.
 737         (ALL_COMPUNITS): Use objfile_compunits.
 738         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
 739         (maintenance_check_symtabs, maintenance_info_line_tables): Use
 740         objfile_compunits.
 741         * objfiles.c (objfile_relocate1): Use objfile_compunits.
 742
 743 2019-01-09  Tom Tromey  <tom@tromey.com>
 744
 745         * symtab.c (search_symbols)
 746         (default_collect_symbol_completion_matches_break_on): Use
 747         objfile_msymbols.
 748         * ada-lang.c (ada_lookup_simple_minsym)
 749         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
 750         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
 751         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
 752         objfile_msymbols.
 753         * coffread.c (coff_symfile_read): Use objfile_msymbols.
 754         * symmisc.c (dump_msymbols): Use objfile_msymbols.
 755         * objc-lang.c (find_methods): Use objfile_msymbols.
 756         (info_selectors_command, info_classes_command): Likewise.
 757         * stabsread.c (scan_file_globals): Use objfile_msymbols.
 758         * objfiles.h (class objfile_msymbols): New.
 759         (ALL_OBJFILE_MSYMBOLS): Remove.
 760         (ALL_MSYMBOLS): Remove.
 761
 762 2019-01-09  Tom Tromey  <tom@tromey.com>
 763
 764         * common/next-iterator.h (next_adapter): Add Iterator template
 765         parameter.
 766         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
 767         (class all_objfiles_safe): New.
 768         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
 769         * objfiles.c (put_objfile_before): Update comment.
 770         (add_separate_debug_objfile): Likewise.
 771         (free_all_objfiles): Use all_objfiles_safe.
 772         (objfile_purge_solibs): Likewise.
 773
 774 2019-01-09  Tom Tromey  <tom@tromey.com>
 775
 776         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 777         (expand_symtab_containing_pc, lookup_static_symbol)
 778         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
 779         (find_symbol_at_address, find_line_symtab, find_main_name): Use
 780         all_objfiles.
 781         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
 782         * breakpoint.c (create_overlay_event_breakpoint)
 783         (create_longjmp_master_breakpoint)
 784         (create_std_terminate_master_breakpoint)
 785         (create_exception_master_breakpoint): Use all_objfiles.
 786         * linux-thread-db.c (try_thread_db_load_from_pdir)
 787         (has_libpthread): Use all_objfiles.
 788         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
 789         * linespec.c (iterate_over_all_matching_symtabs)
 790         (search_minsyms_for_name): Use all_objfiles.
 791         * maint.c (maintenance_info_sections): Use all_objfiles.
 792         * main.c (captured_main_1): Use all_objfiles.
 793         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
 794         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
 795         * guile/scm-pretty-print.c
 796         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
 797         * solib-spu.c (append_ocl_sos): Use all_objfiles.
 798         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
 799         (maintenance_print_msymbols): Use all_objfiles.
 800         * source.c (select_source_symtab): Use all_objfiles.
 801         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
 802         * symfile.c (remove_symbol_file_command)
 803         (expand_symtabs_matching, map_symbol_filenames): Use
 804         all_objfiles.
 805         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
 806         all_objfiles.
 807         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
 808         * objc-lang.c (find_methods): Use all_objfiles.
 809         * objfiles.c (have_partial_symbols, have_full_symbols)
 810         (have_minimal_symbols, qsort_cmp)
 811         (default_iterate_over_objfiles_in_search_order): Use
 812         all_objfiles.
 813         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
 814         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
 815         (maintenance_check_psymtabs): Use all_objfiles.
 816         (ALL_PSYMTABS): Remove.
 817         * compile/compile-object-run.c (do_module_cleanup): Use
 818         all_objfiles.
 819         * blockframe.c (find_pc_partial_function): Use all_objfiles.
 820         * cp-support.c (add_symbol_overload_list_qualified): Use
 821         all_objfiles.
 822         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 823         Use all_objfiles.
 824         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
 825         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
 826         all_objfiles.
 827         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 828         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
 829         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 830         Uses all_objfiles.
 831         * solib.c (solib_read_symbols): Use all_objfiles
 832
 833 2019-01-09  Tom Tromey  <tom@tromey.com>
 834
 835         * probe.c (parse_probes_in_pspace): Use all_objfiles.
 836         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
 837         all_objfiles.
 838         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
 839         * symmisc.c (print_symbol_bcache_statistics)
 840         (print_objfile_statistics, maintenance_print_objfiles)
 841         (maintenance_info_symtabs, maintenance_check_symtabs)
 842         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
 843         all_objfiles.
 844         * source.c (forget_cached_source_info): Use all_objfiles.
 845         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
 846         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 847         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
 848         * objfiles.c (update_section_map): Use all_objfiles.
 849         (shared_objfile_contains_address_p): Likewise.
 850         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
 851         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
 852
 853 2019-01-09  Tom Tromey  <tom@tromey.com>
 854
 855         * common/next-iterator.h: New file.
 856         * objfiles.h (class all_objfiles): New.
 857         (struct objfile_iterator): New.
 858
 859 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 860
 861         * NEWS: Move the description of the changed "frame", "select-frame",
 862          and "info frame" commands to the Changed commands section.
 863
 864 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
 865
 866         * gdbtypes.c (check_stub_method_group): Remove handling of old
 867         mangling schemes.
 868         * linespec.c (find_methods): Likewise.
 869         * stabsread.c (read_member_functions): Likewise.
 870         * valops.c (search_struct_method): Likewise.
 871         (value_struct_elt_for_reference): Likewise.
 872         * NEWS: Mention this change.
 873
 874 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 875
 876         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
 877         print_source_lines.
 878         * source.c (print_source_lines_base): Update line number check.
 879         (print_source_lines): New function.
 880         (source_lines_range::source_lines_range): New function.
 881         * source.h (class source_lines_range): New class.
 882         (print_source_lines): New declaration.
 883
 884 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 885
 886         * linespec.c (linespec_state_destructor): Free self->canonical_names.
 887
 888 2019-01-08  Tom Tromey  <tom@tromey.com>
 889             Simon Marchi  <simon.marchi@ericsson.com>
 890
 891         PR gdb/24060
 892         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
 893         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
 894         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 895         * f-exp.y (DOLLAR_VARIABLE): Likewise.
 896         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
 897         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 898
 899 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 900
 901         * source.c (select_source_symtab): Move header comment to
 902         declaration in source.h.
 903         (forget_cached_source_info_for_objfile): Likewise.
 904         (forget_cached_source_info): Likewise.
 905         (identify_source_line): Likewise.
 906         * source.h (identify_source_line): Move declaration from symtab.h
 907         and add comment from source.c
 908         (print_source_lines): Likewise.
 909         (forget_cached_source_info_for_objfile): Likewise.
 910         (forget_cached_source_info): Likewise.
 911         (select_source_symtab): Likewise.
 912         (enum print_source_lines_flag): Move definition from symtab.h.
 913         * symtab.h (identify_source_line): Move declaration to source.h.
 914         (print_source_lines): Likewise.
 915         (forget_cached_source_info_for_objfile): Likewise.
 916         (forget_cached_source_info): Likewise.
 917         (select_source_symtab): Likewise.
 918         (enum print_source_lines_flag): Move definition to source.h.
 919         * tui/tui-hooks.c: Add 'source.h' include.
 920
 921 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 922
 923         * source.c (print_source_lines_base): Handle requests to print
 924         reverse line number sequences, and guard against empty lines
 925         string.
 926
 927 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 928
 929         * source.c (print_source_lines_base): Fix skip of '\r' if next
 930         character is '\n'.
 931
 932 2019-01-06  Tom Tromey  <tom@tromey.com>
 933
 934         * c-exp.y (struct c_parse_state) <macro_original_text,
 935         expansion_obstack>: New member.
 936         (macro_original_text, expansion_obstack): Remove globals.
 937         (scan_macro_expansion, scanning_macro_expansion)
 938         (finished_macro_expansion): Update.
 939         (scan_macro_cleanup): Remove.
 940         (yylex, c_parse): Update.
 941
 942 2019-01-06  Tom Tromey  <tom@tromey.com>
 943
 944         * c-exp.y (struct c_parse_state) <strings>: New member.
 945         (operator_stoken): Update.
 946
 947 2019-01-06  Tom Tromey  <tom@tromey.com>
 948
 949         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
 950         (union type_stack_elt) <typelist_val>: Now a pointer to
 951         std::vector.
 952         (type_stack_cleanup): Don't declare.
 953         (push_typelist): Update.
 954         * parse.c (pop_typelist): Return a std::vector.
 955         (push_typelist): Take a std::vector.
 956         (follow_types): Update.  Do not free args.
 957         (type_stack_cleanup): Remove.
 958         * c-exp.y (struct c_parse_state): New.
 959         (cpstate): New global.
 960         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
 961         (nonempty_typelist): Update.
 962         (func_mod): Create a new vector.
 963         (c_parse): Create a c_parse_state.
 964         (check_parameter_typelist): Do not delete params.
 965         (function_method): Update.  Do not delete type_list.
 966
 967 2019-01-06  Tom Tromey  <tom@tromey.com>
 968
 969         PR gdb/28155:
 970         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
 971         check_typedef.
 972         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
 973         (print_return_value): Likewise.
 974
 975 2019-01-05  Tom Tromey  <tom@tromey.com>
 976
 977         * contrib/cleanup_check.py: Remove.
 978         * contrib/gcc-with-excheck: Remove.
 979         * contrib/exsummary.py: Remove.
 980         * contrib/excheck.py: Remove.
 981
 982 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
 983
 984         * thread.c (delete_thread_1): Add gdb_assert that THR is not
 985         NULL. Initialize tpprev to NULL instead of assigning it
 986         to NULL on the next statement.
 987         * windows-nat.c (windows_delete_thread): Remove check for
 988         main_thread_id before printing thread exit notifications.
 989         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
 990         Remove thread ID check against main_thread_id.
 991         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
 992         windows_delete_thread.
 993         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
 994
 995 2019-01-04  Tom Tromey  <tom@tromey.com>
 996
 997         * compile/compile.c (_initialize_compile): Use upper case for
 998         metasyntactic variables.
 999         * symmisc.c (_initialize_symmisc): Use upper case for
1000         metasyntactic variables.
1001         * psymtab.c (_initialize_psymtab): Use upper case for
1002         metasyntactic variables.
1003         * demangle.c (demangle_command): Use upper case for metasyntactic
1004         variables.
1005         (_initialize_demangler): Likewise.
1006         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1007         variables.
1008
1009 2019-01-03  Tom Tromey  <tom@tromey.com>
1010
1011         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1012
1013 2019-01-03  Tom Tromey  <tom@tromey.com>
1014
1015         * python/py-symtab.c (salpy_str): Update.
1016         (struct salpy_sal_object) <symtab>: Now a PyObject.
1017         (salpy_dealloc): Update.
1018         (del_objfile_sal): Use gdbpy_ref.
1019
1020 2019-01-03  Tom Tromey  <tom@tromey.com>
1021
1022         * python/py-type.c (convert_field): Use new_reference.  Return
1023         gdbpy_ref.
1024         (make_fielditem): Return gdbpy_ref.
1025         (typy_fields): Update.
1026         (typy_getitem): Update.
1027         (field_name): Return gdbpy_ref.  Use new_reference.
1028         (typy_iterator_iternext): Update.
1029
1030 2019-01-03  Tom Tromey  <tom@tromey.com>
1031
1032         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1033
1034 2019-01-03  Tom Tromey  <tom@tromey.com>
1035
1036         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1037         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1038         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1039         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1040         (pspy_set_type_printers): Likewise.
1041         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1042         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1043         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1044         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1045         (objfpy_set_type_printers): Likewise.
1046
1047 2019-01-03  Tom Tromey  <tom@tromey.com>
1048
1049         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1050         (gdbpy_print_stack): Use gdbpy_err_fetch.
1051         * python/python-internal.h (class gdbpy_err_fetch): New class.
1052         (class gdbpy_enter) <m_error_type, m_error_value,
1053         m_error_traceback>: Remove.
1054         <m_error>: New member.
1055         (gdbpy_exception_to_string): Don't declare.
1056         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1057         * python/py-value.c (convert_value_from_python): Use
1058         gdbpy_err_fetch.
1059         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1060         gdbpy_exception_to_string.
1061         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1062         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1063         gdbpy_err_fetch.
1064
1065 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1066
1067         * linux-nat.c (delete_lwp_cleanup): Delete.
1068         (struct lwp_deleter): New struct.
1069         (lwp_info_up): New typedef.
1070         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1071         lwp_info_up.
1072
1073 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1074
1075         * linux-fork.c (class scoped_switch_fork_info): New class.
1076         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1077
1078 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1079
1080         * valops.c (find_overload_match): Remove use of null_cleanup, and
1081         calls to do_cleanups.
1082
1083 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1084
1085         * compile/compile-cplus-types.c
1086         (compile_cplus_instance::decl_name): Handle changes to
1087         cp_func_name.
1088         * cp-support.c (cp_func_name): Update header comment, update
1089         return type.
1090         * cp-support.h (cp_func_name): Update return type in declaration.
1091         * valops.c (find_overload_match): Move temp_func local to top
1092         level of function and change its type.  Use temp_func to hold and
1093         delete temporary string obtained from cp_func_name.
1094
1095 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1096
1097         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1098         gdb::char_vector, remove cleanup, and update uses of `msg`.
1099
1100 2019-01-03  Jim Wilson  <jimw@sifive.com>
1101
1102         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1103
1104 2019-01-02  Tom Tromey  <tom@tromey.com>
1105
1106         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1107         (tdesc_parse_xml): Remove cleanups.
1108         * target-descriptions.h (make_cleanup_free_target_description):
1109         Don't declare.
1110         (target_desc_deleter): New struct.
1111         (target_desc_up): New typedef.
1112         * target-descriptions.c (target_desc_deleter::operator()): Rename
1113         from free_target_description.
1114         (make_cleanup_free_target_description): Remove.
1115
1116 2019-01-02  Tom Tromey  <tom@tromey.com>
1117
1118         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1119         constructor, destructor.
1120         (linespec_parser): Remove typedef.
1121         (~linespec_parser): Rename from linespec_parser_delete.
1122         (linespec_lex_to_end, linespec_complete_label)
1123         (linespec_complete): Update.
1124         (decode_line_full): Remove cleanups.
1125         (decode_line_1): Update.
1126
1127 2019-01-02  Tom Tromey  <tom@tromey.com>
1128
1129         * python/python-internal.h (inferior_to_inferior_object): Change
1130         return type.
1131         * python/py-exitedevent.c (create_exited_event_object): Update.
1132         * python/py-inferior.c (inferior_to_inferior_object): Return
1133         gdbpy_ref.
1134         (python_new_inferior, python_inferior_deleted)
1135         (thread_to_thread_object, delete_thread_object)
1136         (build_inferior_list, gdbpy_selected_inferior): Update.
1137         * python/py-infthread.c (create_thread_object): Update.  Also fail
1138         if inferior_to_inferior_object fails.
1139
1140 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1141
1142         * inferior.h (class inferior) <displaced_step_state>: New field.
1143         * infrun.h (struct displaced_step_state): Move here from
1144         infrun.c.  Initialize fields, add constructor.
1145         <inf>: Remove field.
1146         <reset>: New method.
1147         * infrun.c (struct displaced_step_inferior_state): Move to
1148         infrun.h.
1149         (displaced_step_inferior_states): Remove.
1150         (get_displaced_stepping_state): Adust.
1151         (displaced_step_in_progress_any_inferior): Adjust.
1152         (displaced_step_in_progress_thread): Adjust.
1153         (displaced_step_in_progress): Adjust.
1154         (add_displaced_stepping_state): Remove.
1155         (get_displaced_step_closure_by_addr): Adjust.
1156         (remove_displaced_stepping_state): Remove.
1157         (infrun_inferior_exit): Call displaced_step_state.reset.
1158         (use_displaced_stepping): Don't check for NULL.
1159         (displaced_step_prepare_throw): Call
1160         get_displaced_stepping_state.
1161         (displaced_step_fixup): Don't check for NULL.
1162         (prepare_for_detach): Don't check for NULL.
1163
1164 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1165
1166         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
1167          in case of call that did not complete.
1168
1169 2019-01-02  Andrey Utkin  <autkin@undo.io>
1170
1171         * symfile.c (find_separate_debug_file): Fix search of debug files for
1172         remote debuggee.
1173
1174 2019-01-02  Tom Tromey  <tom@tromey.com>
1175
1176         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
1177         indentation.
1178         * python/py-frame.c (frapy_older): Remove cast.
1179         (frapy_newer): Likewise.
1180         * python/py-breakpoint.c (local_setattro): Remove cast.
1181         * python/py-arch.c (archpy_name): Remove local variable.
1182         * python/py-type.c (gdbpy_lookup_type): Remove cast.
1183
1184 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
1185
1186         * unittests/basic_string_view/element_access/char/empty.cc:
1187         Fix year range in copyright header.
1188
1189 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1190
1191         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
1192         Delete.
1193         <operator==>: Update with for removed field.
1194         <hash>: Likewise.
1195         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
1196         <isa_features>: ...this.
1197         <abi_features>: New field.
1198         (riscv_isa_flen): Update comment.
1199         (riscv_abi_xlen): New declaration.
1200         (riscv_abi_flen): New declaration.
1201         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
1202         isa_features.
1203         (riscv_abi_xlen): New function.
1204         (riscv_isa_flen): Update to get answer from isa_features.
1205         (riscv_abi_flen): New function.
1206         (riscv_has_fp_abi): Update to get answer from abi_features.
1207         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
1208         xlen and flen.
1209         (riscv_call_info) <xlen, flen>: Update comment.
1210         (riscv_call_arg_struct): Remove invalid assertions
1211         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
1212         is removed.
1213         (riscv_gdbarch_init): Gather isa features and abi features
1214         separately, ensure both match on the gdbarch when reusing an old
1215         gdbarch.  Relax an error check to allow 32-bit abi float to run on
1216         a target with 64-bit float hardware.
1217
1218 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1219
1220         * source.c (search_command_helper): Stop reverse search
1221         when line 1 has been searched.
1222
1223 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1224
1225         * record-full.c (record_full_base_target::close): Rewrite
1226         record_full_core_buf_list free logic.
1227
1228 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1229
1230         * break-catch-syscall.c (print_one_catch_syscall): xfree
1231         the last text.
1232
1233 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1234
1235         * top.c (print_gdb_version): Update Copyright year in version
1236         message.
1237
1238 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1239
1240         Update copyright year range in all GDB files.
1241
1242 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
1243
1244         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
1245
1246 For older changes see ChangeLog-2018.
1247 \f
1248 Local Variables:
1249 mode: change-log
1250 left-margin: 8
1251 fill-column: 74
1252 version-control: never
1253 coding: utf-8
1254 End:
1255