gdb/ChangeLog

   1 2019-06-25  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
   4         NULL check.
   5
   6 2019-06-25  Tom Tromey  <tom@tromey.com>
   7
   8         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
   9         Inline constructor.  Add initializers for members.
  10         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
  11         constructors; now inline in class.
  12
  13 2019-06-25  Tom Tromey  <tom@tromey.com>
  14
  15         * tui/tui-regs.c (tui_show_registers): Update.
  16         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
  17         bool.
  18         * tui/tui-data.c (tui_data_window::clear_detail)
  19         (tui_data_window): Update.
  20
  21 2019-06-25  Tom Tromey  <tom@tromey.com>
  22
  23         * tui/tui-windata.c (tui_display_all_data)
  24         (tui_display_data_from_line, tui_display_data_from)
  25         (tui_check_data_values, tui_data_window::do_scroll_vertical):
  26         Update.
  27         * tui/tui-regs.c (tui_last_regs_line_no)
  28         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
  29         (tui_show_registers, tui_show_register_group)
  30         (tui_display_registers_from, tui_display_reg_element_at_line)
  31         (tui_display_registers_from_line, tui_check_register_values)
  32         (tui_reg_next, tui_reg_prev): Update.
  33         * tui/tui-layout.c (tui_set_layout, show_data): Update.
  34         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
  35         tui_data_window.
  36         (struct tui_win_info) <detail>: Remove.  Add new fields from
  37         tui_data_info.
  38         (TUI_DATA_WIN): Add cast.
  39         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
  40         (~tui_data_window): Simplify.
  41
  42 2019-06-25  Tom Tromey  <tom@tromey.com>
  43
  44         * tui/tui-layout.c (show_source_disasm_command)
  45         (show_source_or_disasm_and_command): Update.
  46         * tui/tui-io.c (update_cmdwin_start_line)
  47         (tui_redisplay_readline): Update.
  48         * tui/tui-data.h (struct tui_command_info): Remove.
  49         (struct tui_win_info) <detail>: Remove command_info member.
  50         (struct tui_data_window) <start_line>: New member, from
  51         tui_command_info.
  52         (TUI_CMD_WIN): Add casts.
  53
  54 2019-06-25  Tom Tromey  <tom@tromey.com>
  55
  56         * tui/tui-winsource.c (tui_update_source_window)
  57         (tui_refill_source_window)
  58         (tui_source_window_base::do_scroll_horizontal)
  59         (tui_update_breakpoint_info, tui_set_exec_info_content)
  60         (tui_show_exec_info_content, tui_erase_exec_info_content)
  61         (tui_clear_exec_info_content): Update.
  62         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
  63         Update.
  64         * tui/tui-win.c (make_invisible_and_set_new_height)
  65         (make_visible_with_new_height): Update.
  66         * tui/tui-source.c (tui_set_source_content)
  67         (tui_show_symtab_source): Update.
  68         * tui/tui-layout.c (extract_display_start_addr)
  69         (show_source_disasm_command, show_data)
  70         (make_source_or_disasm_window)
  71         (show_source_or_disasm_and_command): Update.
  72         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
  73         (tui_disasm_window::do_scroll_vertical): Remove shadowing
  74         "gdbarch".
  75         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
  76         to tui_source_window_base.
  77         (struct tui_win_info) <detail>: Remove source_info member.
  78         (struct tui_source_window_base) <has_locator>: Inline.
  79         Move contents from tui_source_info; rename has_locator member to
  80         m_has_locator.
  81         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
  82         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
  83         header file.
  84         (tui_source_window_base::clear_detail, ~tui_source_window_base):
  85         Simplify.
  86         (tui_free_all_source_wins_content): Cast to
  87         tui_source_window_base.
  88
  89 2019-06-25  Tom Tromey  <tom@tromey.com>
  90
  91         * tui/tui-win.c (make_invisible_and_set_new_height)
  92         (make_visible_with_new_height): Call has_locator method.
  93         * tui/tui-layout.c (show_source_disasm_command, show_data)
  94         (show_source_or_disasm_and_command): Update for bool change.
  95         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
  96         (tui_win_info) <has_locator>: New method.
  97         (struct tui_source_window_base) <has_locator>: New method.
  98         (tui_win_has_locator): Don't declare.
  99         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 100         from tui_win_has_locator.
 101         (tui_source_window_base): Use false, not FALSE.
 102
 103 2019-06-25  Tom Tromey  <tom@tromey.com>
 104
 105         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 106         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 107         clear_detail method directly.
 108         (tui_clear_win_detail): Remove.
 109
 110 2019-06-25  Tom Tromey  <tom@tromey.com>
 111
 112         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 113         "this", not TUI_DISASM_WIN.
 114
 115 2019-06-25  Tom Tromey  <tom@tromey.com>
 116
 117         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 118         declare.
 119         * tui/tui-winsource.c
 120         (tui_source_window_base::do_scroll_horizontal): Rename from
 121         tui_horizontal_source_scroll.
 122         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 123         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 124         from tui_vertical_data_scroll.
 125         * tui/tui-win.h (tui_scroll): Don't declare.
 126         * tui/tui-win.c (tui_win_info::forward_scroll)
 127         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 128         (tui_win_info::right_scroll): Rename and update.
 129         (tui_scroll_forward_command, tui_scroll_backward_command)
 130         (tui_scroll_left_command, tui_scroll_right_command): Update.
 131         (tui_scroll): Remove.
 132         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 133         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 134         from tui_vertical_source_scroll.
 135         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 136         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 137         from tui_vertical_disassem_scroll.
 138         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 139         do_scroll_horizontal>: New methods.
 140         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 141         Likewise.
 142         (struct tui_source_window_base): Add do_scroll_horizontal.
 143         (struct tui_source_window, struct tui_disasm_window): Add
 144         do_scroll_vertical.
 145         (struct tui_data_window, struct tui_cmd_window): Add
 146         do_scroll_horizontal and do_scroll_vertical.
 147         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 148
 149 2019-06-25  Tom Tromey  <tom@tromey.com>
 150
 151         * tui/tui-data.h (struct tui_source_window_base): New struct.
 152         (struct tui_source_window): Derive from tui_source_window_base.
 153         (struct tui_disasm_window): New struct.
 154         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 155         from tui_source_window::clear_detail.
 156         (tui_source_window_base): Rename from tui_source_window.
 157         (~tui_source_window_base): Rename from ~tui_source_window.
 158         (tui_alloc_win_info): Create a tui_disasm_window.
 159
 160 2019-06-25  Tom Tromey  <tom@tromey.com>
 161
 162         * tui/tui-data.h (struct tui_source_window)
 163         (struct tui_data_window): Declare destructors.
 164         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 165         destructors.
 166         (tui_win_info): Simplify.
 167
 168 2019-06-25  Tom Tromey  <tom@tromey.com>
 169
 170         * tui/tui-winsource.c (tui_display_main)
 171         (tui_update_source_windows_with_addr)
 172         (tui_update_all_breakpoint_info): Update.
 173         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 174         (new_height_ok, parse_scrolling_args): Update.
 175         * tui/tui-stack.c (tui_show_frame_info): Update.
 176         * tui/tui-data.h (struct tui_list): Remove.
 177         (tui_source_windows): Return a reference to a std::vector.
 178         * tui/tui-data.c (source_windows): Now a std::vector.
 179         (tui_source_windows): Change return type.
 180         (tui_clear_source_windows): Rewrite.
 181         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 182         (tui_free_all_source_wins_content): Rewrite.
 183
 184 2019-06-25  Tom Tromey  <tom@tromey.com>
 185
 186         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 187         (struct tui_data_window, struct tui_cmd_window): Declare
 188         clear_detail method.
 189         * tui/tui-data.c (tui_source_window::clear_detail)
 190         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 191         methods.
 192         (tui_clear_win_detail): Simplify.
 193
 194 2019-06-25  Tom Tromey  <tom@tromey.com>
 195
 196         * tui/tui-layout.c (make_source_window, make_disasm_window)
 197         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 198         Return the new window.
 199         (show_source_disasm_command, show_data)
 200         (show_source_or_disasm_and_command): Update.
 201
 202 2019-06-25  Tom Tromey  <tom@tromey.com>
 203
 204         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 205         parameter.  Return the new window.
 206         (show_source_disasm_command): Update and remove NULL check.
 207         (show_source_or_disasm_and_command): Update.
 208
 209 2019-06-25  Tom Tromey  <tom@tromey.com>
 210
 211         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 212
 213 2019-06-25  Tom Tromey  <tom@tromey.com>
 214
 215         * tui/tui-data.h (struct tui_win_info): Make constructor
 216         protected.  Make destructor virtual.  Add initializers.
 217         (tui_source_window, tui_data_window, tui_cmd_window): New
 218         classes.
 219         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 220         constructor.  Add "type" parameter.
 221         (tui_source_window, tui_data_window, tui_cmd_window): New
 222         constructors.
 223         (tui_alloc_win_info): Instantiate the appropriate subclass.
 224
 225 2019-06-25  Tom Tromey  <tom@tromey.com>
 226
 227         * tui/tui-win.c (tui_resize_all): Use delete.
 228         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 229         destructor.
 230         (tui_free_window): Don't declare.
 231         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 232         Update.
 233
 234 2019-06-25  Tom Tromey  <tom@tromey.com>
 235
 236         * tui/tui-data.h (struct tui_win_info): Add constructor.
 237         * tui/tui-data.c (tui_alloc_win_info): Use new.
 238         (tui_free_window): Use delete.
 239
 240 2019-06-22  Tom Tromey  <tom@tromey.com>
 241
 242         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 243         declare.
 244         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 245
 246 2019-06-22  Tom Tromey  <tom@tromey.com>
 247
 248         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 249         declare.
 250         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 251
 252 2019-06-22  Tom de Vries  <tdevries@suse.de>
 253
 254         * dwarf2read.c (create_addrmap_from_aranges)
 255         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 256         instead of '%zu'.
 257
 258 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 259
 260         * dwarf2read.h (dwarf2_section_info_def): Remove.
 261         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 262         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 263         std::vector<dwarf2_section_info>.
 264         (struct dwo_file) <~dwo_file>: Remove.
 265         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 266         types field.
 267         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 268         (dwarf2_read_debug_names): Likewise.
 269         (create_debug_types_hash_table): Change parameter type to
 270         array_view, adjust code accordingly.
 271         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 272         (partial_die_info::fixup): Likewise.
 273         (determine_prefix): Likewise.
 274         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 275
 276 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 277
 278         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 279         gdb_bfd_ref_ptr.
 280         <~dwo_file>: Remove call to gdb_bfd_unref.
 281         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 282         gdb_bfd_ref_ptr::get.
 283
 284 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 285
 286         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 287         type to htab_up.
 288         * dwarf2read.c (struct dwo_file): Initialize fields.
 289         <~dwo_file>: New.
 290         (free_dwo_file): Remove, move content to ~dwo_file.
 291         (struct dwo_file_deleter): Remove.
 292         (dwo_file_up>: Remove custom deleter.
 293         (free_dwo_files): Remove.
 294         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 295         dwo_files.
 296         (process_skeletonless_type_units): Call unique_ptr::get.
 297         (allocate_dwo_file_hash_table): Add deleter to created hash
 298         table.  Change return type to htab_up.
 299         (lookup_dwo_file_slot): Don't memset dwo_file, call
 300         unique_ptr::get.
 301         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 302         (create_dwo_unit_in_dwp_v2): Likewise.
 303         (open_and_init_dwo_file): Likewise.
 304         (free_dwo_file_from_slot): Remove.
 305
 306 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 307
 308         * dwarf2read.h (struct dwarf2_section_info) <readin,
 309         is_virtual>: Change type to bool.
 310         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 311         true instead of 1.
 312
 313 2019-06-19  Tom Tromey  <tom@tromey.com>
 314
 315         * tui/tui-data.h (tui_init_content_element): Don't declare.
 316
 317 2019-06-19  Tom Tromey  <tom@tromey.com>
 318
 319         * tui/tui-data.h (tui_init_win_info): Don't declare.
 320
 321 2019-06-19  Tom de Vries  <tdevries@suse.de>
 322
 323         * dwarf2read.h (abstract_to_concrete): Change type to
 324         std::unordered_map<sect_offset, std::vector<sect_offset>,
 325         gdb::hash_enum<sect_offset>>.
 326
 327 2019-06-19  Tom Tromey  <tromey@adacore.com>
 328
 329         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 330         EVAL_AVOID_SIDE_EFFECTS specially.
 331
 332 2019-06-19  Tom Tromey  <tromey@adacore.com>
 333
 334         * source-cache.c (highlighter): New global.
 335         (source_cache::get_source_lines): Create a highlighter on demand.
 336
 337 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 338
 339         * defs.h (deprecated_interactive_hook): Delete declaration.
 340         * interps.c (clear_interpreter_hooks): Remove use of
 341         deprecated_interactive_hook.
 342         * top.c (deprecated_interactive_hook): Delete definition.
 343         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 344
 345 2019-06-18  Tom de Vries  <tdevries@suse.de>
 346
 347         PR gdb/24515
 348         * dwarf2read.h (abstract_to_concrete): Change type from
 349         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 350         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 351         * dwarf2read.c (read_variable): Update.
 352         (dwarf2_fetch_die_loc_sect_off): Update.
 353
 354 2019-06-17  Tom de Vries  <tdevries@suse.de>
 355
 356         PR gdb/24617
 357         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 358         accessing parent[parent_len - 1].
 359
 360 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 361
 362         PR gdb/24364
 363         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 364         call dtrace_process_dof with NULL dof.
 365
 366 2019-06-16  Tom de Vries  <tdevries@suse.de>
 367
 368         PR gdb/24445
 369         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 370
 371 2019-06-16  Tom Tromey  <tom@tromey.com>
 372
 373         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 374         (make_all_visible): Use address of member.
 375
 376 2019-06-16  Tom Tromey  <tom@tromey.com>
 377
 378         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 379         (tui_free_window, free_content, free_content_elements): Remove
 380         unnecessary cast.
 381         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 382         cast.
 383         * tui/tui-regs.c (tui_show_register_group)
 384         (tui_display_registers_from, tui_display_reg_element_at_line):
 385         Remove unnecessary cast.
 386
 387 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 388
 389         * linux-nat.c (normal_mask): Delete.
 390         (_initialize_linux_nat): Don't initialise normal_mask.
 391
 392 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 393
 394         PR gdb/24445
 395         * dwarf-index-write.h (write_psymtabs_to_index): Add
 396         dwz_basename parameter.
 397         * dwarf-index-write.c (write_gdbindex): Move file writing to
 398         write_gdbindex_1.  Change return type void.
 399         (assert_file_size): Move up, remove filename parameter.
 400         (write_gdbindex_1): New function.
 401         (write_debug_names): Change return type to void, call
 402         assert_file_size.
 403         (struct index_wip_file): New struct.
 404         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 405         file logic to index_wip_file.  Write index for dwz file if
 406         needed.
 407         (save_gdb_index_command): Pass basename of dwz file, if present.
 408         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 409         build-id of dwz file, if present.
 410         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 411         (dwarf2_get_dwz_file): Likewise.
 412         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 413         (dwarf2_get_dwz_file): Likewise.
 414
 415 2019-06-16  Tom Tromey  <tom@tromey.com>
 416
 417         * coffread.c (process_coff_symbol): Use xstrdup.
 418         * value.c (create_internalvar): Use xstrdup.
 419
 420 2019-06-16  Tom Tromey  <tom@tromey.com>
 421
 422         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 423         * breakpoint.c (stopin_command, stopat_command)
 424         (until_break_command, decode_location_default): Remove unnecessary
 425         cast.
 426         * utils.c (subset_compare): Remove unnecessary cast.
 427         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 428         cast.
 429         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 430         cast.
 431         * infcmd.c (path_command): Remove unnecessary cast.
 432         * coffread.c (decode_type): Remove unnecessary cast.
 433         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 434         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 435         * tui/tui-stack.c (tui_show_locator_content)
 436         (tui_show_frame_info): Remove unnecessary cast.
 437         * tui/tui-win.c (tui_scroll_forward_command)
 438         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 439         (parse_scrolling_args): Remove unnecessary cast.
 440         * tui/tui-data.c (init_win_info, tui_del_window)
 441         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 442         (free_content_elements): Remove unnecessary cast.
 443         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 444         unnecessary cast.
 445         * tui/tui-source.c (tui_set_source_content)
 446         (tui_vertical_source_scroll): Remove unnecessary cast.
 447         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 448         cast.
 449         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 450         * tui/tui-regs.c (tui_display_registers_from)
 451         (tui_display_register): Remove unnecessary cast.
 452         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 453         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 454         (make_visible): Remove unnecessary cast.
 455         * tui/tui-winsource.c (tui_erase_source_content)
 456         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 457         unnecessary cast.
 458         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 459         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 460         * stabsread.c (read_type, read_array_type, read_range_type):
 461         Remove unnecessary cast.
 462         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 463         (parse_symbol, parse_type, upgrade_type, parse_external)
 464         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 465         unnecessary cast.
 466         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 467
 468 2019-06-16  Tom Tromey  <tom@tromey.com>
 469
 470         * tui/tui-data.c (tui_alloc_generic_win_info)
 471         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 472         checks.
 473
 474 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 475             Andrew Burgess  <andrew.burgess@embecosm.com>
 476
 477         * f-typeprint.c (f_print_type): Don't return early for not
 478         associated or not allocated types.
 479         (f_type_print_varspec_suffix): Add print_rank parameter and print
 480         ranks of array types in case they dangling.
 481         (f_type_print_base): Add print_rank parameter.
 482
 483 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 484
 485         * NEWS: Mention new MI commands.
 486         * break-catch-throw.c (enum exception_event_kind): Move to
 487         breakpoint.h.
 488         (print_mention_exception_catchpoint): Output text as a single
 489         message.
 490         (catch_exception_command_1): Rename to...
 491         (catch_exception_event): ...this, make non-static, update header
 492         command, and change some parameter types.
 493         (catch_catch_command): Update for changes to
 494         catch_exception_command_1.
 495         (catch_throw_command): Likewise.
 496         (catch_rethrow_command): Likewise.
 497         * breakpoint.c (enum exception_event_kind): Delete.
 498         * breakpoint.h (enum exception_event_kind): Moved here from
 499         break-catch-throw.c.
 500         (catch_exception_event): Declare.
 501         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 502         (mi_cmd_catch_throw): New function.
 503         (mi_cmd_catch_rethrow): New function.
 504         (mi_cmd_catch_catch): New function.
 505         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 506         'catch-catch' entries.
 507         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 508         (mi_cmd_catch_rethrow): Declare.
 509         (mi_cmd_catch_catch): Declare.
 510
 511 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 512
 513         * annotate.c (annotate_source_line): Change return type to void,
 514         update implementation to match.
 515         * annotate.h (annotate_source_line): Change return type to void,
 516         update header comment.
 517         * stack.c (print_frame_info): Don't change what frame information
 518         is printed based on whether annotations are on or not.
 519
 520 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 521
 522         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 523         (annotate_source): Make static.
 524         (annotate_source_line): Moved from source.c and renamed from
 525         identify_source_line.  Update the return type.
 526         * annotate.h (annotate_source): Delete declaration.
 527         (annotate_source_line): Declaration moved from source.h, and
 528         renamed from identify_source_line.  Return type updated.
 529         * source.c (identify_source_line): Moved to annotate.c and renamed
 530         to annotate_source_line.
 531         (info_line_command): Remove check of annotation_level.
 532         * source.h (identify_source_line): Move declaration to annotate.h
 533         and rename to annotate_source_line.
 534         * stack.c: Add 'annotate.h' include.
 535         (print_frame_info): Remove check of annotation_level before
 536         calling annotate_source_line.
 537
 538 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 539
 540         * source-cache.c (source_cache::get_plain_source_lines): Use
 541         open_source_file_with_line_charpos instead of just
 542         open_source_file, remove call to find_source_lines.
 543         (source_cache::get_source_lines): Likewise.
 544         * source.c (find_source_lines): Make static.
 545         (get_filename_and_charpos): Renamed into...
 546         (open_source_file_with_line_charpos): ..this along with changes to
 547         return a scoped_fd, and some other minor clean ups.
 548         (identify_source_line): Use open_source_file_with_line_charpos.
 549         (search_command_helper): Use open_source_file_with_line_charpos
 550         instead of just open_source_file, remove call to
 551         find_source_lines.
 552         * source.h (open_source_file_with_line_charpos): Declare new
 553         function.
 554         (find_source_lines): Delete declaration.
 555
 556 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 557
 558         * source.c (get_filename_and_charpos): Remove fullname
 559         parameter.
 560         (identify_source_line): Update call to get_filename_and_charpos.
 561
 562 2019-06-14  Tom Tromey  <tromey@adacore.com>
 563
 564         PR gdb/24502:
 565         * ui-style.h (skip_ansi_escape): Update comment.
 566         * ui-file.h (class no_terminal_escape_file): New class.
 567         * ui-file.c (no_terminal_escape_file::write)
 568         (no_terminal_escape_file::puts): New methods.
 569         * cli/cli-logging.c (handle_redirections): Use
 570         no_terminal_escape_file.
 571
 572 2019-06-14  Tom Tromey  <tromey@adacore.com>
 573
 574         * NEWS: Move convenience variable news above Python news.
 575
 576 2019-06-14  Tom Tromey  <tom@tromey.com>
 577
 578         * gnulib: Move directory to top-level.
 579         * configure.ac: Don't configure gnulib.
 580         * configure: Rebuild.
 581         * common/common-defs.h: Use new path to gnulib.
 582         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 583         (GNULIB_H): Remove.
 584         (INCGNU): Look in new gnulib location.
 585         (HFILES_NO_SRCDIR): Remove gnulib files.
 586         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 587         (generated_files): Remove GNULIB_H.
 588         ($(LIBGNU), all-lib): Remove targets.
 589         (distclean): Don't mention GNULIB_BUILDDIR.
 590         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 591
 592 2019-06-14  Tom Tromey  <tromey@adacore.com>
 593
 594         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 595         Warn if symbol file does not provide any symbols.
 596
 597 2019-06-14  Tom Tromey  <tromey@adacore.com>
 598
 599         * source.c (find_and_open_source): Respect basenames_may_differ.
 600
 601 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 602
 603         * annotate.c (annotate_breakpoints_invalid): Make use of
 604         scoped_restore_terminal_state.
 605         (annotate_frames_invalid): Likewise.
 606
 607 2019-06-14  Tom Tromey  <tromey@adacore.com>
 608
 609         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 610         allow assignment to an internalvar.
 611
 612 2019-06-14  Tom Tromey  <tromey@adacore.com>
 613
 614         * ada-lex.l: Allow "_" in attribute names.
 615
 616 2019-06-14  Tom Tromey  <tromey@adacore.com>
 617
 618         PR gdb/24653:
 619         * regcache.c (registers_changed): Don't call alloca.
 620         * top.c (execute_command): Don't call alloca.
 621
 622 2019-06-13  Pedro Alves  <palves@redhat.com>
 623
 624         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 625         'expression'.  When parsing an expression, error out if there's
 626         junk after "unlimited".
 627         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 628         (do_set_command): Adjust calls to is_unlimited_literal.
 629
 630 2019-06-13  Pedro Alves  <palves@redhat.com>
 631
 632         * compile/compile.c (make_compile_options_def_group): Add braces
 633         around array_view initializer.
 634         * thread.c (make_thread_apply_all_options_def_group)
 635         (make_thread_apply_all_options_def_group): Likewise.
 636
 637 2019-06-13  Pedro Alves  <palves@redhat.com>
 638
 639         * NEWS (New commands): Mention "maint test-options
 640         require-delimiter", "maint test-options unknown-is-error", "maint
 641         test-options unknown-is-operand" and "maint show
 642         test-options-completion-result".
 643         (New command options, command completion): New section.
 644         (Completion improvements): New section.
 645         Mention that you can abbreviate "unlimited".
 646
 647 2019-06-13  Pedro Alves  <palves@redhat.com>
 648
 649         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 650         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 651         * unittests/cli-utils-selftests.c (test_parse_flags)
 652         (test_parse_flags_qcs): Delete.
 653         (test_cli_utils): Don't call deleted functions.
 654
 655 2019-06-13  Pedro Alves  <palves@redhat.com>
 656
 657         * thread.c: Include "cli/cli-option.h".
 658         (tp_array_compar_ascending): Global.
 659         (tp_array_compar): Delete function.
 660         (tp_array_compar_ascending, tp_array_compar_descending): New
 661         functions.
 662         (ascending_option_def, qcs_flag_option_def)
 663         (thr_qcs_flags_option_defs)
 664         (make_thread_apply_all_options_def_group)
 665         (make_thread_apply_options_def_group): New.
 666         (thread_apply_all_command): Use gdb::option::process_options.
 667         (thread_apply_command_completer)
 668         (thread_apply_all_command_completer): New.
 669         (thread_apply_command): Use gdb::option::process_options.
 670         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 671         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 672         to generate help text of "thread apply".  Adjust "taas"'s help.
 673         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 674         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 675
 676 2019-06-13  Pedro Alves  <palves@redhat.com>
 677
 678         * thread.c (thread_apply_command): Check for invalid TID with
 679         isdigit instead of !isalpha.
 680
 681 2019-06-13  Pedro Alves  <palves@redhat.com>
 682
 683         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 684         (validate_flags_qcs): New.
 685         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 686         (validate_flags_qcs): Declare.
 687         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 688         (make_frame_apply_options_def_group): New.
 689         (frame_apply_command_count): Process options with
 690         gdb::option::process_options.
 691         (frame_apply_completer): New.
 692         (frame_apply_level_completer, frame_apply_all_completer)
 693         (frame_apply_completer): New.
 694         (_initialize_stack): Update help of "frame apply", "frame apply
 695         level", "frame apply all" and "faas" to mention supported options
 696         and install command completers.
 697         * stack.h (frame_apply_all_completer): Declare.
 698         * thread.c: Include "stack.h".
 699         (tfaas_command): Add "--".
 700         (_initialize_thread): Update help "tfaas" to mention supported
 701         options and install command completer.
 702
 703 2019-06-13  Pedro Alves  <palves@redhat.com>
 704
 705         * completer.c (complete_nested_command_line): New.
 706         (gdb_completion_word_break_characters_throw): Add assertion.
 707         * completer.h (complete_nested_command_line): Declare.
 708
 709 2019-06-13  Pedro Alves  <palves@redhat.com>
 710
 711         * stack.c (parse_backtrace_qualifiers): New.
 712         (backtrace_command): Use it.
 713         (backtrace_command_completer): Complete on qualifiers.
 714
 715 2019-06-13  Pedro Alves  <palves@redhat.com>
 716
 717         * frame.c: Include "cli/cli-option.h.
 718         (user_set_backtrace_options): New.
 719         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 720         Delete.
 721         (get_prev_frame): Adjust.
 722         (boolean_option_def, uinteger_option_def)
 723         (set_backtrace_option_defs): New.
 724         (_initialize_frame): Adjust and use
 725         gdb::option::add_setshow_cmds_for_options to install "set
 726         backtrace past-main" and "set backtrace past-entry".
 727         * frame.h: Include "cli/cli-option.h".
 728         (struct frame_print_options): Forward declare.
 729         (print_frame_arguments_all, print_frame_arguments_scalars)
 730         (print_frame_arguments_none): Declare.
 731         (print_entry_values): Delete declaration.
 732         (struct frame_print_options, user_frame_print_options): New.
 733         (struct set_backtrace_options): New.
 734         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 735         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 736         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 737         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 738         (list_args_or_locals): Add frame_print_options parameter.
 739         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 740         * python/py-framefilter.c (enumerate_args): Pass down
 741         USER_FRAME_PRINT_OPTIONS.
 742         * stack.c: Include "cli/cli-option.h".
 743         (print_frame_arguments_all, print_frame_arguments_scalars)
 744         (print_frame_arguments_none): Declare.
 745         (print_raw_frame_arguments, print_entry_values): Delete.
 746         (user_frame_print_options): New.
 747         (boolean_option_def, enum_option_def, frame_print_option_defs):
 748         New.
 749         (struct backtrace_cmd_options): New.
 750         (bt_flag_option_def): New.
 751         (backtrace_command_option_defs): New.
 752         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 753         (print_frame_arg, read_frame_arg, print_frame_args)
 754         (print_frame_info, print_frame): Add frame_print_options parameter
 755         and use it.
 756         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 757         (backtrace_command_1): Add frame_print_options and
 758         backtrace_cmd_options parameters and use them.
 759         (make_backtrace_options_def_group): New.
 760         (backtrace_command): Process command options with
 761         gdb::option::process_options.
 762         (backtrace_command_completer): New.
 763         (_initialize_stack): Extend "backtrace"'s help to mention
 764         supported options.  Install completer for "backtrace".
 765         Install some settings commands with add_setshow_cmds_for_options.
 766
 767 2019-06-13  Pedro Alves  <palves@redhat.com>
 768
 769         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 770         and that "set/show print raw frame-arguments" are now deprecated.
 771
 772         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 773         command.
 774         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 775         * stack.c (_initialize_stack): Install "set/show print
 776         raw-frame-arguments", and deprecate "set/show print raw
 777         frame-arguments".
 778         * valprint.c (_initialize_valprint): Deprecate "set/show print
 779         raw".
 780
 781 2019-06-13  Pedro Alves  <palves@redhat.com>
 782
 783         * compile/compile.c (struct compile_options): New.
 784         (compile_flag_option_def, compile_command_option_defs)
 785         (make_compile_options_def_group): New.
 786         (compile_file_command): Handle options with
 787         gdb::option::process_options.
 788         (compile_file_command_completer): New function.
 789         (compile_code_command): Handle options with
 790         gdb::option::process_options.
 791         (compile_code_command_completer): New function.
 792         (_initialize_compiler): Install completers for "compile code" and
 793         "compile file".  Mention available options in "compile code" and
 794         "compile code"'s help.
 795         * completer.c (advance_to_completion_word): New, factored out from
 796         ...
 797         (advance_to_expression_complete_word_point): ... this.
 798         (advance_to_filename_complete_word_point): New.
 799         * completer.h (advance_to_filename_complete_word_point): New
 800         declaration.
 801
 802 2019-06-13  Pedro Alves  <palves@redhat.com>
 803
 804         * compile/compile.c: Include "cli/cli-option.h".
 805         (compile_print_value): Scope data pointer is now a
 806         value_print_options pointer; adjust.
 807         (compile_print_command): Process options.  Scope data pointer is
 808         now a value_print_options pointer; adjust.
 809         (_initialize_compile): Update "compile print"'s help to include
 810         supported options.  Install a completer for "compile print".
 811         * cp-valprint.c (show_vtblprint, show_objectprint)
 812         (show_static_field_print): Delete.
 813         (_initialize_cp_valprint): Don't install "set print
 814         static-members", "set print vtbl", "set print object" here.
 815         * printcmd.c: Include "cli/cli-option.h" and
 816         "common/gdb_optional.h".
 817         (print_command_parse_format): Rework to fill in a
 818         value_print_options instead of a format_data.
 819         (print_value): Change parameter type from format_data pointer to
 820         value_print_options reference.  Adjust.
 821         (print_command_1): Process options.  Adjust to pass down a
 822         value_print_options.
 823         (print_command_completer): New.
 824         (_initialize_printcmd): Install print_command_completer as
 825         handle_brkchars completer for the "print" command.  Update
 826         "print"'s help to include supported options.
 827         * valprint.c: Include "cli/cli-option.h".
 828         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 829         here from cp-valprint.c.
 830         (boolean_option_def, uinteger_option_def)
 831         (value_print_option_defs, make_value_print_options_def_group):
 832         New.  Use gdb::option::add_setshow_cmds_for_options to install
 833         "set print elements", "set print null-stop", "set print repeats",
 834         "set print pretty", "set print union", "set print array", "set
 835         print address", "set print symbol", "set print array-indexes".
 836         * valprint.h: Include <string> and "cli/cli-option.h".
 837         (make_value_print_options_def_group): Declare.
 838         (print_value): Change parameter type from format_data pointer to
 839         value_print_options reference.
 840         (print_command_completer): Declare.
 841
 842 2019-06-13  Pedro Alves  <palves@redhat.com>
 843
 844         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 845         (COMMON_SFILES): Add maint-test-settings.c.
 846         * cli/cli-decode.c (boolean_enums): New global, factored out from
 847         ...
 848         (add_setshow_boolean_cmd): ... here.
 849         * cli/cli-decode.h (boolean_enums): Declare.
 850         * cli/cli-option.c: New file.
 851         * cli/cli-option.h: New file.
 852         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 853         factored out from ...
 854         (parse_cli_boolean_value(const char *)): ... this.
 855         (is_unlimited_literal): Change parameter type to pointer to
 856         pointer.  Adjust and advance ARG pointer.
 857         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 858         (parse_cli_var_enum): New, factored out from ...
 859         (do_set_command): ... this.  Adjust.
 860         * cli/cli-setshow.h (parse_cli_boolean_value)
 861         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 862         (parse_cli_var_enum): Declare.
 863         * cli/cli-utils.c: Include "cli/cli-option.h".
 864         (get_ulongest): New.
 865         * cli/cli-utils.h (get_ulongest): Declare.
 866         (check_for_argument): New overloads.
 867         * maint-test-options.c: New file.
 868
 869 2019-06-13  Pedro Alves  <palves@redhat.com>
 870
 871         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 872         parse a range if "-" is at the end of the string.
 873
 874 2019-06-13  Pedro Alves  <palves@redhat.com>
 875
 876         * cli/cli-setshow.c (parse_auto_binary_operation)
 877         (parse_cli_boolean_value): Don't allow "o".
 878
 879 2019-06-13  Pedro Alves  <palves@redhat.com>
 880
 881         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 882         * NEWS: Mention maint test-settings KIND.
 883         * maint-test-settings.c: New file.
 884
 885 2019-06-13  Pedro Alves  <palves@redhat.com>
 886
 887         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 888         completer.
 889         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 890         "set" completers.
 891
 892 2019-06-13  Pedro Alves  <palves@redhat.com>
 893
 894         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 895         after item.
 896
 897 2019-06-13  Pedro Alves  <palves@redhat.com>
 898
 899         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 900
 901 2019-06-13  Pedro Alves <palves@redhat.com>
 902
 903         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 904         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 905         call.
 906         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 907         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 908         calls.
 909         (check_for_argument): Skip spaces after argument.
 910
 911 2019-06-13  Pedro Alves  <palves@redhat.com>
 912
 913         * thread.c (thread_apply_command): Adjust TID parsing.
 914         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 915         detected before end of string.
 916         (tid_is_in_list): Error out if LIST is invalid.
 917
 918 2019-06-13  Pedro Alves  <palves@redhat.com>
 919
 920         * completer.c (complete_line_internal_1): Rewind completion word
 921         point.
 922         (completion_tracker::advance_custom_word_point_by): Change
 923         parameter type to int.
 924         * completer.h (completion_tracker::advance_custom_word_point_by):
 925         Likewise.
 926
 927 2019-06-13  Pedro Alves  <palves@redhat.com>
 928
 929         * completer.c (advance_to_completion_word): Handle delimiters.
 930
 931 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 932
 933         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 934
 935 2019-06-11  Tom Tromey  <tom@tromey.com>
 936
 937         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 938         (xmalloc_failed): Move to alloc.c.
 939         * alloc.c: New file.
 940         * Makefile.in (COMMON_SFILES): Add alloc.c.
 941
 942 2019-06-11  Tom Tromey  <tom@tromey.com>
 943
 944         * nat/linux-waitpid.c: Don't include server.h.
 945         (linux_debug): Remove.
 946         (my_waitpid): Update.
 947
 948 2019-06-11  Tom Tromey  <tromey@adacore.com>
 949
 950         * infcall.c (_initialize_infcall): Remove trailing newline from
 951         help.
 952         * user-regs.c (_initialize_user_regs): Remove trailing newline
 953         from help.
 954         * typeprint.c (_initialize_typeprint): Remove trailing newline
 955         from help.
 956         * reverse.c (_initialize_reverse): Remove trailing newlines from
 957         help.
 958         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 959         from help.
 960         * language.c (add_set_language_command): Remove trailing newline
 961         from help.
 962         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 963         help.
 964         * disasm.c (_initialize_disasm): Remove trailing newline from
 965         help.
 966         * top.c (init_main): Remove trailing newline from help.
 967         * interps.c (_initialize_interpreter): Remove trailing newline
 968         from help.
 969         * btrace.c (_initialize_btrace): Remove trailing newlines from
 970         help.
 971         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 972         from help.
 973         * python/python.c (_initialize_python): Remove trailing newline
 974         from help.
 975         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 976         help.
 977         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 978         from help.  Reformat some text.
 979         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 980         from help.
 981         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 982         newline from help.
 983
 984 2019-06-11  Tom Tromey  <tromey@adacore.com>
 985
 986         * darwin-nat.c (darwin_decode_exception_message)
 987         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 988
 989 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 990
 991         * valops.c (value_slice): Check for not allocated or not
 992         associated values.
 993
 994 2019-06-10  Tom de Vries  <tdevries@suse.de>
 995
 996         PR gdb/24618
 997         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 998         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 999         invalid.
1000
1001 2019-06-10  Tom de Vries  <tdevries@suse.de>
1002
1003         PR gdb/24611
1004         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1005         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1006
1007 2019-06-10  Tom de Vries  <tdevries@suse.de>
1008
1009         PR symtab/24545
1010         * symtab.c (struct demangled_name_entry): Add language field.
1011         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1012         static minimal symbol".  Set and use language field.
1013
1014 2019-06-10  Tom Tromey  <tromey@adacore.com>
1015
1016         * ada-lang.c (_initialize_ada_language): Update help text.
1017
1018 2019-06-10  Tom Tromey  <tromey@adacore.com>
1019
1020         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1021         with a newline.
1022         * guile/guile.c (handle_boot_error): Don't end warning with a
1023         newline.
1024         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1025         warning with a newline.
1026         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1027         newline.
1028         (s12z_frame_cache): Likewise.
1029         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1030         a newline.
1031         * solib-svr4.c (disable_probes_interface): Don't end warning with
1032         a newline.
1033         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1034         newline.
1035         * python/python.c (do_finish_initialization): Don't end warning
1036         with a newline.
1037
1038 2019-06-10  Tom Tromey  <tom@tromey.com>
1039
1040         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1041         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1042         gdbpy_enter.
1043
1044 2019-06-10  Tom Tromey  <tromey@adacore.com>
1045
1046         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1047         data.
1048         (elf_new_init): Don't call stabsread_new_init.
1049         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1050         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1051         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1052
1053 2019-06-10  Tom de Vries  <tdevries@suse.de>
1054
1055         PR symtab/16264
1056         PR symtab/24517
1057         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1058
1059 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1060
1061         * source.c (find_and_open_source): Also rewrite relative file
1062         names.
1063
1064 2019-04-26  Amos Bird  <amosbird@gmail.com>
1065
1066         * annotate.c (annotate_thread_exited): Add "thread-exited"
1067         annotation.
1068
1069 2019-06-06  Tom Tromey  <tromey@adacore.com>
1070
1071         * maint.h (class scoped_command_stats): Use
1072         DISABLE_COPY_AND_ASSIGN.
1073         <print_time>: New method.
1074         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1075         print_time.
1076         (scoped_command_stats::print_time): New method.
1077
1078 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1079
1080         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1081         instructions of lengths 6 or 8 bytes.
1082
1083 2019-06-04  Pedro Alves  <palves@redhat.com>
1084
1085         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1086
1087         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1088         * breakpoint.c (condition_completer): Likewise.
1089         * cli/cli-dump.c (scan_expression): Likewise.
1090         * common/filestuff.c (mkdir_recursive): Likewise.
1091         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1092         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1093         (gdb_abspath): Likewise.
1094         * compile/compile-cplus-types.c
1095         (compile_cplus_instance::decl_name): Likewise.
1096         * completer.c (complete_explicit_location):
1097         (signal_completer, reg_or_group_completer_1): Likewise.
1098         * cp-support.c (cp_remove_params_if_any): Likewise.
1099         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1100         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1101         * infcmd.c (strip_bg_char): Likewise.
1102         * linespec.c (copy_token_string): Likewise.
1103         * mi/mi-main.c (output_cores): Likewise.
1104         * psymtab.c (psymtab_search_name):
1105         * symfile.c (test_set_ext_lang_command): Likewise.
1106         * target.c (target_fileio_read_stralloc): Likewise.
1107         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1108         * value.c (complete_internalvar): Likewise.
1109
1110 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1111
1112         Add objfile property to gdb.Type.
1113         * NEWS: Mention Python API addition.
1114         * python/py-type.c (typy_get_objfile): New method.
1115
1116 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1117
1118         * NEWS: Mention the new set|show style [title|highlight].
1119         Mention changes to "show style", "help" and "apropos".
1120
1121 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1122
1123         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1124         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1125         instead of print_help_for_command.
1126         (print_doc_of_command): New function.
1127         (help_list): Add 'apropos -v word' suggestion.
1128         (print_help_for_command): Style the command name using title style.
1129         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1130         (_initialize_cli_cmds): Describe -v in apropos_command help.
1131
1132 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1133
1134         * cli/cli-style.h (cli_style_option): Add name in constructor,
1135         add m_name class member, add constructor with intensity,
1136         add name class function.
1137         (cli_style_option::add_setshow_commands): Remove name argument.
1138         (highlight_style, title_style): New styles.
1139         * cli/cli-style.c (do_show): New function that shows a style
1140         characteristic styling the style name with itself.
1141         (set_style_name): New function.
1142         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1143         Update all callers according to the changes in cli/cli-style.h.
1144         * utils.h (fputs_highlighted): New function.
1145         * utils.c (fputs_highlighted): Likewise.
1146
1147 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1148
1149         * NEWS: Mention new pipe command and new convenience variables.
1150
1151 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1152
1153         * cli/cli-cmds.c (pipe_command): New function.
1154         (_initialize_cli_cmds): Call add_com for pipe_command.
1155         Define | as an alias for pipe.
1156         (exit_status_set_internal_vars): New function.
1157         (shell_escape): Call exit_status_set_internal_vars.
1158         cli/cli-decode.c (find_command_name_length): Recognize | as
1159         a single character command.
1160
1161 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1162
1163         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1164         top.c (execute_command_to_ui_file): New function, mostly a copy
1165         of execute_command_to_string.
1166         (execute_command_to_string): Implement by calling
1167         execute_command_to_ui_file.
1168
1169 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1170
1171         * top.h (saved_command_line): Remove declaration.
1172         * top.c (previous_saved_command_line, previous_repeat_arguments):
1173         New variables.
1174         (saved_command_line): Make static, define together with other
1175         'repeat variables'.
1176         (dont_repeat): Clear repeat_arguments.
1177         (repeat_previous, get_saved_command_line, save_command_line):
1178         New functions.
1179         (gdb_init): Initialize saved_command_line
1180         and previous_saved_command_line.
1181         * main.c (captured_main_1): Remove saved_command_line initialization.
1182         * event-top.c (handle_line_of_input): Update to use
1183         the new 'repeat' related functions instead of direct access to
1184         saved_command_line.
1185         * command.h (repeat_previous, get_saved_command_line,
1186         save_command_line): New declarations.
1187         (dont_repeat): Add comment.
1188
1189 2019-05-30  Tom Tromey  <tromey@adacore.com>
1190
1191         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1192         Fix comment.
1193         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1194
1195 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1196
1197         PR cli/24587
1198         * completer.c (complete): Initialize variable word.
1199
1200 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1201
1202         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1203         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1204         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1205         'body' is NULL to the outter 'if', protecting the '!is_define'
1206         situation as well.
1207
1208 2019-05-29  Tom Tromey  <tromey@adacore.com>
1209
1210         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1211         (dwarf_unknown): New function.
1212         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1213         (dwarf_type_encoding_name): Use dwarf_unknown.
1214
1215 2019-05-29  Tom Tromey  <tromey@adacore.com>
1216
1217         PR c++/20020:
1218         * cp-valprint.c (cp_print_value_fields): Call
1219         cp_print_static_field inside "try".
1220
1221 2019-05-29  Tom Tromey  <tromey@adacore.com>
1222
1223         * inflow.c (struct terminal_info): Add default operator=.
1224         * configure: Rebuild.
1225         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1226         -Wdeprecated-copy-dtor, -Wredundant-move.
1227
1228 2019-05-29  Tom Tromey  <tromey@adacore.com>
1229
1230         * NEWS: Add entry.
1231         * infcmd.c (print_return_value_1): Handle finish_print
1232         option.
1233         (show_print_finish): New function.
1234         (_initialize_infcmd): Add "set/show print finish" commands.
1235         * valprint.c (user_print_options): Initialize new member.
1236         * valprint.h (struct value_print_options) <finish_print>: New
1237         member.
1238
1239 2019-05-28  Tom Tromey  <tromey@adacore.com>
1240
1241         * ada-lang.c (ada_remove_Xbn_suffix)
1242         (find_old_style_renaming_symbol)
1243         (parse_old_style_renaming): Remove.
1244         (ada_find_renaming_symbol): Don't call
1245         find_old_style_renaming_symbol.
1246         (ada_is_renaming_symbol): Rename from
1247         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1248         bool.  Now static.
1249         (ada_read_var_value): Update and simplify.
1250         * ada-exp.y (write_var_or_type): Remove old code.
1251
1252 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1253
1254         * event-top.c: Remove include comment.
1255         * inflow.c (class scoped_ignore_sigttou): Move from here...
1256         * inflow.h (class scoped_ignore_sigttou): ...to here.
1257         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1258         * top.c:  Remove include comment.
1259
1260 2019-05-27  Tom Tromey  <tom@tromey.com>
1261
1262         * NEWS: Fix typo.
1263
1264 2019-05-22  Tom Tromey  <tromey@adacore.com>
1265
1266         * target.c (target_follow_exec): Constify parameter.
1267         * target-delegates.c: Rebuild.
1268         * remote.c (remote_target::follow_exec): Constify parameter.
1269         * infrun.c (follow_exec): Constify parameter.
1270         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1271         (target_follow_exec): Likewise.
1272
1273 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1274
1275         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1276         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1277
1278 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1279
1280         * NEWS: Add debugredirect and testsuite sections.
1281
1282 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1283
1284         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1285         target descriptions using exclusively floating point register name
1286         aliases.
1287
1288 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1289
1290         PR gdb/18644:
1291         * f-lang.c (build_fortran_types): Handle the case where
1292         gdbarch_floatformat_for_type returns a nullptr.
1293
1294 2019-05-21  Tom de Vries  <tdevries@suse.de>
1295
1296         PR cli/24587
1297         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1298
1299 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1300
1301         PR gdb/18644:
1302         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1303         16-byte floats.
1304         * i386-tdep.c (i386_floatformat_for_type): Use
1305         floatformats_ia64_quad for the 16-byte floating point component
1306         within a fortran 32-byte complex number.
1307
1308 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1309
1310         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1311         delete default constructor.
1312         (find_partial_die): Update to return const struct.
1313         (partial_die_parent_scope): Move variable declaration into scope
1314         of its use and change its type to auto.
1315         (guess_partial_die_structure_name): Likewise.
1316         (partial_die_info::fixup): Likewise.
1317
1318 2019-05-17  Tom Tromey  <tromey@adacore.com>
1319
1320         * source.c (find_and_open_source): Remove cast.
1321
1322 2019-05-17  Tom Tromey  <tromey@adacore.com>
1323
1324         * annotate.c (annotate_source): Make "filename" const.
1325         * annotate.h (annotate_source): Use const.
1326
1327 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1328
1329         * disasm.c (set_disassembler_options): Send errors to stderr.
1330
1331 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1332
1333         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1334         (cli_interp_base::set_logging): Check debug_redirect.
1335         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1336         * cli/cli-logging.c (debug_redirect): Add static variable.
1337         (pop_output_files): Add default param.
1338         (handle_redirections): Print debug setting.
1339         (show_logging_command): Likewise.
1340         (_initialize_cli_logging): Add debugredirect command.
1341         * interps.c (current_interp_set_logging): Add debug_redirect
1342         parameter.
1343         * interps.h (set_logging): Add debug_redirect parameter.
1344         (current_interp_set_logging): Likewise.
1345         * mi/mi-common.h: Likewise.
1346         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1347
1348 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1349             Tom Tromey  <tromey@adacore.com>
1350
1351         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1352         directly.
1353         * cli/cli-interp.h (make_logging_output): Remove declaration.
1354         * cli/cli-logging.c (make_logging_output): Remove function.
1355         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1356         directly.
1357         * ui-file.c (tee_file::tee_file): Remove bools.
1358         (tee_file::~tee_file): Remove deletes.
1359         * ui-file.h (tee_file): Remove bools.
1360
1361 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1362
1363         * mi/mi-cmds.h (mi_cmd_complete): New function.
1364         * mi/mi-main.c (mi_cmd_complete): Likewise.
1365         * mi/mi-cmds.c: Define new MI command -complete.
1366         * NEWS: Mention new -complete command.
1367
1368 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1369
1370         * completer.h (complete): New function.
1371         * completer.c (complete): Likewise.
1372         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1373         function defined in completer.h.
1374
1375 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1376
1377         * MAINTAINERS (Write After Approval): Add myself.
1378
1379 2019-05-17  Tom de Vries  <tdevries@suse.de>
1380
1381         PR gdb/24094
1382         * dwarf2read.c (struct cu_partial_die_info): New struct.
1383         (find_partial_die): Return cu_partial_die_info.
1384         (partial_die_parent_scope, guess_partial_die_structure_name)
1385         (partial_die_info::fixup): Handle new return type of find_partial_die.
1386
1387 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1388
1389         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1390         "std::string", simplifying the algorithm.
1391
1392 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1393
1394         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1395         (stap_static_probe_ops::get_probes): Likewise.
1396
1397 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1398
1399         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1400         '-')" and "else if".
1401         (stap_parse_single_operand): Join checks for
1402         "gdbarch_stap_parse_special_token_p" and
1403         "gdbarch_stap_parse_special_token" in the same "if" statement.
1404         Invert check when verifying for operation on register
1405         displacement.
1406
1407 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1408
1409         * stap-probe.c (stap_get_opcode): Update comment.
1410         (stap_get_expected_argument_type): Likewise.
1411         (handle_stap_probe): Likewise.
1412
1413 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1414
1415         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1416         return type to 'bool'.  Adjust comment.  Use 'bool' when
1417         appropriate.
1418         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1419         * stap-probe.c (stap_parse_argument_1): Likewise.
1420         (stap_is_operator): Likewise.
1421         (stap_is_generic_prefix): Likewise.
1422         (stap_is_register_prefix): Likewise.
1423         (stap_is_register_indirection_prefix): Likewise.
1424         (stap_is_integer_prefix): Likewise.
1425         (stap_generic_check_suffix): Likewise.
1426         (stap_check_integer_suffix): Likewise.
1427         (stap_check_register_suffix): Likewise.
1428         (stap_check_register_indirection_suffix): Likewise.
1429         (stap_parse_register_operand): Likewise.
1430         (stap_parse_single_operand): Likewise.
1431         (stap_parse_argument_1): Likewise.
1432         (stap_probe::get_argument_count): Likewise.
1433         (stap_is_operator): Likewise.
1434
1435 2019-05-16  Tom Tromey  <tromey@adacore.com>
1436
1437         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1438         keyword to foreach.
1439
1440 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1441
1442         * linux-thread-db.c (try_thread_db_load_1): Change return type
1443         to bool.
1444         (try_thread_db_load): Likewise.
1445         (try_thread_db_load_from_pdir_1): Likewise.
1446         (try_thread_db_load_from_pdir): Likewise.
1447         (try_thread_db_load_from_sdir): Likewise.
1448         (try_thread_db_load_from_dir): Likewise.
1449         (thread_db_load_search): Likewise.
1450         (has_libpthread): Likewise.
1451         (thread_db_load): Likewise.
1452
1453 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1454
1455         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1456         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1457         NULL, and complain/return if that's the case.
1458
1459 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1460
1461         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1462         (advance, posn, abstract_read_memory): New functions.
1463         [struct mem_read_abstraction]: New struct.
1464         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1465
1466 2019-05-14  Tom Tromey  <tromey@adacore.com>
1467
1468         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1469         value is not lval_memory.
1470
1471 2019-05-14  Tom Tromey  <tromey@adacore.com>
1472
1473         * solib.c (info_sharedlibrary_command): Style the file name.
1474
1475 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1476
1477         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1478         (aarch64_vnv_type): Likewise.
1479         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1480         * common/tdesc.c: Likewise.
1481         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1482         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1483         * features/aarch64-fpu.xml: Add ieee half view.
1484         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1485         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1486         * gdbtypes.h (struct builtin_type): Likewise.
1487         (struct objfile_type): Likewise.
1488
1489 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1490
1491         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1492         typo.
1493         * location.h (string_to_event_location): Likewise.
1494
1495 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1496
1497         GDB 8.3 released.
1498
1499 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1500
1501         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1502         New variable declaration.
1503         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1504         New variable.
1505         (print_one_breakpoint): Use ui_out::test_flags and new global
1506         variable to compute use_fixed_output.
1507         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1508         Remove.
1509         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1510         (mi_multi_location_breakpoint_output_fixed): Remove.
1511         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1512         new variable.
1513         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1514         fix_multi_location_breakpoint_output flag if version >= 3.
1515         * ui-out.h (enum ui_out_flag)
1516         <fix_multi_location_breakpoint_output>: New enumerator.
1517
1518 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1519
1520         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1521
1522 2019-05-10  Tom Tromey  <tromey@adacore.com>
1523
1524         * ada-lang.c (catch_ada_completer): New function.
1525         (_initialize_ada_language): Use it.
1526
1527 2019-05-10  Tom Tromey  <tromey@adacore.com>
1528
1529         * thread.c (print_thread_info): Make "requested_threads" const.
1530         * gdbthread.h (print_thread_info): Make "requested_threads"
1531         const.
1532         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1533         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1534
1535 2019-05-08  Tom Tromey  <tom@tromey.com>
1536
1537         * gdbtypes.c (objfile_type_data): Change type.
1538         (objfile_type, _initialize_gdbtypes): Update.
1539
1540 2019-05-08  Tom Tromey  <tom@tromey.com>
1541
1542         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1543         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1544         (_initialize_dwarf2_frame): Update.
1545
1546 2019-05-08  Tom Tromey  <tom@tromey.com>
1547
1548         * objc-lang.c (objc_objfile_data): Change type.
1549         (find_methods): Update.
1550         (_initialize_objc_lang): Remove.
1551
1552 2019-05-08  Tom Tromey  <tom@tromey.com>
1553
1554         * stabsread.c (rs6000_builtin_type_data): Change type.
1555         (rs6000_builtin_type, _initialize_stabsread): Update.
1556
1557 2019-05-08  Tom Tromey  <tom@tromey.com>
1558
1559         * mips-tdep.c (mips_pdr_data): Remove.
1560         (_initialize_mips_tdep): Update.
1561
1562 2019-05-08  Tom Tromey  <tom@tromey.com>
1563
1564         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1565         (hppa_init_objfile_priv_data, read_unwind_info)
1566         (find_unwind_entry, _initialize_hppa_tdep): Update.
1567
1568 2019-05-08  Tom Tromey  <tom@tromey.com>
1569
1570         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1571         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1572         on obstack.
1573         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1574
1575 2019-05-08  Tom Tromey  <tom@tromey.com>
1576
1577         * mdebugread.c (basic_type_data): Change type.
1578         (basic_type, _initialize_mdebugread): Update.
1579
1580 2019-05-08  Tom Tromey  <tom@tromey.com>
1581
1582         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1583
1584 2019-05-08  Tom Tromey  <tom@tromey.com>
1585
1586         * nto-tdep.c (nto_inferior_data_reg): Change type.
1587         (nto_inferior_data): Update.
1588         (nto_inferior_data_cleanup, nto_new_inferior_data)
1589         (_initialize_nto_tdep): Remove.
1590         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1591
1592 2019-05-08  Tom Tromey  <tom@tromey.com>
1593
1594         * ada-lang.c (struct ada_inferior_data): Add initializers.
1595         (ada_inferior_data): Change type.
1596         (ada_inferior_data_cleanup): Remove.
1597         (get_ada_inferior_data, ada_inferior_exit)
1598         (struct ada_pspace_data): Add initializers, destructor.
1599         (ada_pspace_data_handle): Change type.
1600         (get_ada_pspace_data): Update.
1601         (ada_pspace_data_cleanup): Remove.
1602
1603 2019-05-08  Tom Tromey  <tom@tromey.com>
1604
1605         * coffread.c (struct coff_symfile_info): Add initializers.
1606         (coff_objfile_data_key): Move lower.  Change type.
1607         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1608         Update.
1609         (coff_free_info): Remove.
1610
1611 2019-05-08  Tom Tromey  <tom@tromey.com>
1612
1613         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1614         (fbsd_pspace_data_handle): Move lower.  Change type.
1615         (get_fbsd_pspace_data): Update.
1616         (fbsd_pspace_data_cleanup): Remove.
1617         (_initialize_fbsd_tdep): Update.
1618
1619 2019-05-08  Tom Tromey  <tom@tromey.com>
1620
1621         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1622         (get_ada_tasks_pspace_data): Update.
1623         (ada_tasks_pspace_data_cleanup): Remove.
1624         (_initialize_tasks): Update.
1625         (ada_tasks_inferior_data_handle): Change type.
1626         (get_ada_tasks_inferior_data): Update.
1627         (ada_tasks_inferior_data_cleanup): Remove.
1628         (struct ada_tasks_pspace_data): Add initializers.
1629
1630 2019-05-08  Tom Tromey  <tom@tromey.com>
1631
1632         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1633         * symfile-debug.c (debug_sym_get_probes): Change type.
1634         * stap-probe.c (handle_stap_probe):
1635         (stap_static_probe_ops::get_probes): Change type.
1636         * probe.h (class static_probe_ops) <get_probes>: Change type.
1637         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1638         (parse_probes_in_pspace): Update.
1639         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1640         Update.
1641         (any_static_probe_ops::get_probes): Change type.
1642         * elfread.c (elfread_data): New typedef.
1643         (probe_key): Change type.
1644         (elf_get_probes): Likewise.  Update.
1645         (probe_key_free): Remove.
1646         (_initialize_elfread): Update.
1647         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1648         Change type.
1649         (dtrace_process_dof_probe, dtrace_process_dof)
1650         (dtrace_static_probe_ops::get_probe): Change type.
1651
1652 2019-05-08  Tom Tromey  <tom@tromey.com>
1653
1654         * xcoffread.c (struct xcoff_symfile_info): Rename from
1655         coff_symfile_info.  Add initializers.
1656         (xcoff_objfile_data_key): Move lower.  Change type.
1657         (XCOFF_DATA): Rewrite.
1658         (xcoff_free_info): Remove.
1659         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1660         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1661         (xcoff_initial_scan): Update.
1662
1663 2019-05-08  Tom Tromey  <tom@tromey.com>
1664
1665         * solib-svr4.c (struct svr4_info): Add initializers and
1666         destructor.
1667         <probes_table>: Now an htab_up.
1668         (solib_svr4_pspace_data): Change type.
1669         (free_probes_table): Simplify.
1670         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1671         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1672         (probes_table_remove_objfile_probes, register_solib_event_probe)
1673         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1674         (_initialize_svr4_solib): Update.
1675
1676 2019-05-08  Tom Tromey  <tom@tromey.com>
1677
1678         * remote.c (remote_pspace_data): Change type.
1679         (remote_pspace_data_cleanup): Remove.
1680         (get_remote_exec_file, set_pspace_remote_exec_file)
1681         (_initialize_remote): Update.
1682
1683 2019-05-08  Tom Tromey  <tom@tromey.com>
1684
1685         * breakpoint.c (breakpoint_objfile_key): Change type.
1686         (get_breakpoint_objfile_data): Update.
1687         (free_breakpoint_objfile_data): Remove.
1688         (_initialize_breakpoint): Update.
1689
1690 2019-05-08  Tom Tromey  <tom@tromey.com>
1691
1692         * linux-tdep.c (struct linux_info): Add initializers.
1693         (linux_inferior_data): Move.  Change type.
1694         (invalidate_linux_cache_inf): Update.
1695         (linux_inferior_data_cleanup): Remove.
1696         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1697
1698 2019-05-08  Tom Tromey  <tom@tromey.com>
1699
1700         * auxv.c (auxv_inferior_data): Move.  Change type.
1701         (auxv_inferior_data_cleanup): Remove.
1702         (invalidate_auxv_cache_inf): Rewrite.
1703         (get_auxv_inferior_data, _initialize_auxv): Update.
1704
1705 2019-05-08  Tom Tromey  <tom@tromey.com>
1706
1707         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1708         (symfile_debug_objfile_data_key): Change type.
1709         (symfile_debug_installed, debug_qf_has_symbols)
1710         (debug_qf_find_last_source_symtab)
1711         (debug_qf_forget_cached_source_info)
1712         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1713         (debug_qf_print_stats, debug_qf_dump)
1714         (debug_qf_expand_symtabs_for_function)
1715         (debug_qf_expand_all_symtabs)
1716         (debug_qf_expand_symtabs_with_fullname)
1717         (debug_qf_map_matching_symbols)
1718         (debug_qf_expand_symtabs_matching)
1719         (debug_qf_find_pc_sect_compunit_symtab)
1720         (debug_qf_map_symbol_filenames)
1721         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1722         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1723         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1724         (debug_sym_read_linetable, debug_sym_relocate): Update.
1725         (symfile_debug_free_objfile): Remove.
1726         (install_symfile_debug_logging, _initialize_symfile_debug):
1727         Update.
1728
1729 2019-05-08  Tom Tromey  <tom@tromey.com>
1730
1731         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1732         allocate_on_obstack.
1733         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1734         (get_dwarf2_per_objfile): Update.
1735         (set_dwarf2_per_objfile): Remove.
1736         (dwarf2_has_info, dwarf2_get_section_info): Update.
1737         (dwarf2_free_objfile): Remove.
1738         (_initialize_dwarf2_read): Update.
1739
1740 2019-05-08  Tom Tromey  <tom@tromey.com>
1741
1742         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1743         initializers.
1744         <unsupported_script_warning_printed,
1745         script_not_found_warning_printed>: Now bool.
1746         (auto_load_pspace_data): Change type.
1747         (~auto_load_pspace_info): Rename from
1748         auto_load_pspace_data_cleanup.
1749         (get_auto_load_pspace_data, init_loaded_scripts_info)
1750         (clear_section_scripts, maybe_print_unsupported_script_warning)
1751         (maybe_print_script_not_found_warning, _initialize_auto_load):
1752         Update.
1753
1754 2019-05-08  Tom Tromey  <tom@tromey.com>
1755
1756         * objfiles.c (objfile_pspace_info): Add destructor and
1757         initializers.
1758         (objfiles_pspace_data): Change type.
1759         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1760         (get_objfile_pspace_data): Update.
1761         (objfiles_bfd_data): Change type.
1762         (get_objfile_bfd_data): Update.
1763         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1764
1765 2019-05-08  Tom Tromey  <tom@tromey.com>
1766
1767         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1768         Change type.
1769         (get_catch_syscall_inferior_data): Update.
1770         (catch_syscall_inferior_data_cleanup): Remove.
1771         (_initialize_break_catch_syscall): Update.
1772
1773 2019-05-08  Tom Tromey  <tom@tromey.com>
1774
1775         * inflow.c (struct terminal_info): Add destructor and
1776         initializers.
1777         (inflow_inferior_data): Change type.
1778         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1779         (get_inflow_inferior_data, inflow_inferior_exit)
1780         (swap_terminal_info, _initialize_inflow): Update.
1781
1782 2019-05-08  Tom Tromey  <tom@tromey.com>
1783
1784         * target-dcache.c (target_dcache_cleanup): Remove.
1785         (target_dcache_aspace_key): Change type.
1786         (target_dcache_init_p, target_dcache_invalidate)
1787         (target_dcache_get, target_dcache_get_or_init)
1788         (_initialize_target_dcache): Update.
1789         * dcache.h (struct dcache_deleter): New.
1790
1791 2019-05-08  Tom Tromey  <tom@tromey.com>
1792
1793         * symtab.c (struct symbol_cache): Add destructor and
1794         initializers.
1795         (symbol_cache_key): Move.  Change type.
1796         (make_symbol_cache, free_symbol_cache): Remove.
1797         (get_symbol_cache): Update.
1798         (symbol_cache_cleanup): Remove.
1799         (ALL_PSPACES, symbol_cache_flush)
1800         (maintenance_print_symbol_cache)
1801         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1802         Update.
1803
1804 2019-05-08  Tom Tromey  <tom@tromey.com>
1805
1806         * symtab.c (struct main_info): Add destructor and initializers.
1807         (main_progspace_key): Move.  Change type.
1808         (get_main_info): Update.
1809         (main_info_cleanup): Remove.
1810         (_initialize_symtab): Update.
1811
1812 2019-05-08  Tom Tromey  <tom@tromey.com>
1813
1814         * registry.h (DECLARE_REGISTRY): Define the _key class.
1815
1816 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1817
1818         * NEWS: Merge two 'New commands' sections.
1819
1820 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1821
1822         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1823         parameter and use Ada language definition instead.
1824         (ada_val_print_ptr): Remove unused language parameter.
1825         (ada_val_print_num): Remove language parameter and use Ada language
1826         definition instead.
1827         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1828         parameter.
1829         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1830         parameter and use Ada language definition instead.
1831         (ada_val_print_1): Update all ada_val_print_xxx calls.
1832         Remove language parameter.
1833         (ada_val_print): Update ada_val_print_1 call.
1834
1835 2019-05-08  Tom Tromey  <tromey@adacore.com>
1836
1837         * remote.c (remote_hw_watchpoint_limit)
1838         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1839         Now static.
1840
1841 2019-05-08  Tom Tromey  <tromey@adacore.com>
1842
1843         * maint.c (_initialize_maint_cmds): Move initialization code to
1844         remote.c.
1845         (watchdog, show_watchdog): Move to remote.c.
1846         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1847         "watchdog" static.
1848         (_initialize_remote): Move initialization code from maint.c.
1849         * defs.h (watchdog): Don't declare.
1850
1851 2019-05-08  Tom Tromey  <tromey@adacore.com>
1852
1853         * tui/tui-interp.c: Include main.h.
1854         * interps.c: Include main.h.
1855         * main.h (interpreter_p): Declare.
1856         * defs.h (interpreter_p): Don't declare.
1857
1858 2019-05-08  Tom Tromey  <tromey@adacore.com>
1859
1860         * dwarf2loc.c: Include dwarf2read.h.
1861         * defs.h (read_unsigned_leb128): Don't declare.
1862         * dwarf2read.h (read_unsigned_leb128): Declare.
1863
1864 2019-05-08  Tom Tromey  <tromey@adacore.com>
1865
1866         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1867         method.
1868
1869 2019-05-08  Tom Tromey  <tromey@adacore.com>
1870
1871         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1872         when no wrap column is set.
1873
1874 2019-05-08  Tom Tromey  <tromey@adacore.com>
1875
1876         * c-lang.c (c_get_string): Handle non-C-style arrays.
1877
1878 2019-05-08  Tom Tromey  <tromey@adacore.com>
1879
1880         * typeprint.c (print_offset_data::update): Print the bit offset,
1881         not the number of bits remaining.
1882
1883 2019-05-08  Tom Tromey  <tromey@adacore.com>
1884
1885         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1886         padding at end of comment.
1887
1888 2019-05-08  Tom Tromey  <tromey@adacore.com>
1889
1890         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1891         Compare main types.
1892
1893 2019-05-06  Tom Tromey  <tom@tromey.com>
1894
1895         * common/scoped_mmap.c: Include common-defs.h.
1896         * common/scoped_mmap.h: Don't include config.h.
1897
1898 2019-05-04  Tom Tromey  <tom@tromey.com>
1899
1900         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1901         (struct aarch64_call_info): Add initializers.
1902         <si>: Now a std::vector.
1903         (pass_on_stack, aarch64_push_dummy_call): Update.
1904
1905 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1906             Tom Tromey  <tom@tromey.com>
1907
1908         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1909         (ppc_threads): Now a std::vector.  Now static.
1910         (hwdebug_find_thread_points_by_tid)
1911         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1912         Update.
1913
1914 2019-05-04  Tom Tromey  <tom@tromey.com>
1915
1916         * arc-tdep.c (arc_tdesc_init): Return bool.
1917
1918 2019-05-04  Tom Tromey  <tom@tromey.com>
1919
1920         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1921         Use gdb_assert_not_reached.
1922
1923 2019-05-04  Tom Tromey  <tom@tromey.com>
1924
1925         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1926         "false".
1927
1928 2019-05-04  Tom Tromey  <tom@tromey.com>
1929
1930         * arc-tdep.c (arc_tdesc_init): Use bool.
1931
1932 2019-05-04  Tom Tromey  <tom@tromey.com>
1933
1934         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1935
1936 2019-05-04  Tom Tromey  <tom@tromey.com>
1937
1938         * cli/cli-cmds.c (valid_command_p): Return bool.
1939
1940 2019-05-04  Tom Tromey  <tom@tromey.com>
1941
1942         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1943         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1944
1945 2019-05-04  Raul Tambre  <raul@tambre.ee>
1946
1947         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1948         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1949         operator for comparison.
1950
1951 2019-05-04  Tom Tromey  <tom@tromey.com>
1952
1953         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1954         (lookup_partial_symbol, print_partial_symbols)
1955         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1956         (psymbol_compare): Update.
1957         (add_psymbol_to_bcache): Clear the entire psymbol.
1958         (maintenance_check_psymtabs): Update.
1959         * psympriv.h (struct partial_symbol): Don't derive from
1960         general_symbol_info.
1961         <obj_section, unrelocated_address, address,
1962         set_unrelocated_address>: Update.
1963         <ginfo>: New member.
1964         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1965         (debug_names::write_psymbols): Update.
1966
1967 2019-05-04  Tom de Vries  <tdevries@suse.de>
1968
1969         * contrib/cc-with-tweaks.sh: Support -n arg.
1970
1971 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1972
1973         * corelow.c (core_target::detach): Ensure frame cache and
1974         register caches are cleared.
1975         inferior.c (exit_inferior_1): Likewise.
1976
1977 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1978             Tom Tromey  <tom@tromey.com>
1979
1980         * dictionary.c (collate_pending_symbols_by_language): Remove
1981         "struct" from foreach.
1982         * symtab.c (lookup_global_symbol_from_objfile)
1983         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1984         foreach.
1985         * ser-tcp.c (net_open): Remove "struct" from foreach.
1986         * objfiles.c (objfile_relocate, objfile_rebase)
1987         (objfile_has_symbols): Remove "struct" from foreach.
1988         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1989         from foreach.
1990         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1991         foreach.
1992         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1993         "struct" from foreach.
1994         * ada-lang.c (create_excep_cond_exprs)
1995         (ada_exception_catchpoint_cond_string): Remove "struct" from
1996         foreach.
1997
1998 2019-05-03  Tom Tromey  <tromey@adacore.com>
1999
2000         * ada-exp.y (convert_char_literal): Check suffix of each
2001         enumerator.
2002
2003 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2004
2005         PR ada/21406:
2006         * ada-exp.y (yywrap): Don't define.
2007         * ada-lex.l (%option): Add noyywrap
2008         (yywrap): Remove.
2009
2010 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2011
2012         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2013         _WIN32_WINNT to the XP level, unless already defined to a higher
2014         level.
2015
2016         * unittests/parse-connection-spec-selftests.c:
2017         * ser-tcp.c:
2018         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2019         override.
2020
2021         * symfile.c (find_separate_debug_file): Remove colon from the
2022         drive spec of DOS/Windows file names of the target, so that the
2023         file name produced from DEBUGDIR and the target's directory will
2024         be valid on DOS/Windows systems.
2025
2026 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2027
2028         * rust-lang.c (val_print_struct): Handle printing structures
2029         containing strings.
2030
2031 2019-05-02  Tom Tromey  <tromey@adacore.com>
2032
2033         * valarith.c (_initialize_valarith): Remove.
2034
2035 2019-05-01  Tom Tromey  <tromey@adacore.com>
2036
2037         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2038         bitfields.
2039
2040 2019-05-01  Tom Tromey  <tromey@adacore.com>
2041
2042         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2043         for big-endian copies.
2044
2045 2019-04-30  Ali Tamur  <tamur@google.com>
2046         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2047         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2048         (read_3_bytes): New function.
2049
2050 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2051
2052         * windows-nat.c (main_thread_id): Delete.
2053         (handle_output_debug_string): Replace main_thread_id by
2054         current_event.dwThreadId.
2055         (fake_create_process): Likewise.
2056         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2057         Do not set main_thread_id.
2058         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2059         current_event.dwThreadId.
2060         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2061
2062 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2063
2064         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2065         Use current_event.dwThreadId instead of main_thread_id.
2066
2067 2019-04-30  Tom Tromey  <tromey@adacore.com>
2068
2069         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2070         (create_excep_cond_exprs): Iterate over program spaces.
2071         (ada_exception_catchpoint_cond_string): Examine all minimal
2072         symbols for exception types.
2073
2074 2019-04-30  Tom Tromey  <tromey@adacore.com>
2075
2076         PR c++/24470:
2077         * dwarf2read.c (process_structure_scope): Handle case where type
2078         has template parameters but no symbol was created.
2079
2080 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2081             Chris January  <chris.january@arm.com>
2082
2083         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2084         qualifier.
2085         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2086
2087 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2088
2089         * f-typeprint.c (f_print_type): Update rules for printing
2090         whitespace.
2091         (f_type_print_varspec_suffix): Likewise.
2092
2093 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2094             Chris January  <chris.january@arm.com>
2095
2096         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2097         function arguments.
2098
2099 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2100
2101         * f-lang.c (build_fortran_types): Change name of void type to
2102         lower case.
2103         * f-typeprint.c (f_type_print_base): Print the name of the void
2104         type, rather than a fixed string.
2105         * f-valprint.c (f_decorations): Use lower case void string.
2106
2107 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2108             Chris January  <chris.january@arm.com>
2109
2110         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2111         types for Fortran.
2112
2113 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2114             Chris January  <chris.january@arm.com>
2115             David Lecomber  <david.lecomber@arm.com>
2116
2117         * f-exp.y (BINOP_INTRINSIC): New token.
2118         (exp): New parser rule handling BINOP_INTRINSIC.
2119         (f77_keywords): Add new builtin procedures.
2120         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2121         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2122         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2123         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2124         (print_unop_subexp_f): New function.
2125         (print_binop_subexp_f): New function.
2126         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2127         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2128         (dump_subexp_body_f): Likewise.
2129         (operator_check_f): Likewise.
2130         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2131         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2132
2133 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2134
2135         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2136         UNOP_KIND.
2137         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2138         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2139         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2140         (operator_length_f): New fuction.
2141         (print_subexp_f): New function.
2142         (op_name_f): New function.
2143         (dump_subexp_body_f): New function.
2144         (operator_check_f): New function.
2145         (exp_descriptor_f): Replace standard expression handling functions
2146         with new functions.
2147         * gdb/fortran-operator.def: New file.
2148         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2149         * gdb/std-operator.def: Remove UNOP_KIND.
2150
2151 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2152
2153         * std-operator.def: Remove unbalanced, stray double quote
2154         character.
2155
2156 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2157             Chris January  <chris.january@arm.com>
2158             Daniel Everett  <daniel.everett@arm.com>
2159             Nick Forrington  <nick.forrington@arm.com>
2160             Richard Bunt  <richard.bunt@arm.com>
2161
2162         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2163         of depth when printing anonymous structs or unions.
2164         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2165         Don't print either the top-level value, or the children if the
2166         max-depth is exceeded.
2167         (ppscm_print_children): When printing the key of a map, allow one
2168         extra level of depth.
2169         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2170         print either the top-level value, or the children if the max-depth
2171         is exceeded.
2172         (print_children): When printing the key of a map, allow one extra
2173         level of depth.
2174         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2175         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2176         (user_print_options): Initialise max_depth field.
2177         (val_print_scalar_or_string_type_p): New function.
2178         (val_print): Check to see if the max depth has been reached.
2179         (val_print_check_max_depth): Define new function.
2180         (show_print_max_depth): New function.
2181         (_initialize_valprint): Add 'print max-depth' option.
2182         * valprint.h (struct value_print_options) <max_depth>: New field.
2183         (val_print_check_max_depth): Declare new function.
2184         * NEWS: Document new feature.
2185
2186 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2187
2188         * ada-lang.c (ada_language_defn): Initialise new field.
2189         * c-lang.c (c_is_string_type_p): New function.
2190         (c_language_defn): Initialise new field.
2191         (cplus_language_defn): Initialise new field.
2192         (asm_language_defn): Initialise new field.
2193         (minimal_language_defn): Initialise new field.
2194         * c-lang.h (c_is_string_type_p): Declare new function.
2195         * d-lang.c (d_language_defn): Initialise new field.
2196         * f-lang.c (f_is_string_type_p): New function.
2197         (f_language_defn): Initialise new field.
2198         * go-lang.c (go_is_string_type_p): New function.
2199         (go_language_defn): Initialise new field.
2200         * language.c (default_is_string_type_p): New function.
2201         (unknown_language_defn): Initialise new field.
2202         (auto_language_defn): Initialise new field.
2203         * language.h (struct language_defn) <la_is_string_type_p>: New
2204         member variable.
2205         (default_is_string_type_p): Declare new function.
2206         * m2-lang.c (m2_language_defn): Initialise new field.
2207         * objc-lang.c (objc_language_defn): Initialise new field.
2208         * opencl-lang.c (opencl_language_defn): Initialise new field.
2209         * p-lang.c (pascal_is_string_type_p): New function.
2210         (pascal_language_defn): Initialise new field.
2211         * rust-lang.c (rust_is_string_type_p): New function.
2212         (rust_language_defn): Initialise new field.
2213
2214 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2215
2216         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2217         New field.
2218         * ada-lang.c (ada_language_defn): Initialise new field.
2219         * c-lang.c (c_language_defn): Likewise.
2220         (cplus_language_defn): Likewise.
2221         (asm_language_defn): Likewise.
2222         (minimal_language_defn): Likewise.
2223         * d-lang.c (d_language_defn): Likewise.
2224         * f-lang.c (f_language_defn): Likewise.
2225         * go-lang.c (go_language_defn): Likewise.
2226         * language.c (unknown_language_defn): Likewise.
2227         (auto_language_defn): Likewise.
2228         * m2-lang.c (m2_language_defn): Likewise.
2229         * objc-lang.c (objc_language_defn): Likewise.
2230         * opencl-lang.c (opencl_language_defn): Likewise.
2231         * p-lang.c (pascal_language_defn): Likewise.
2232         * rust-lang.c (rust_language_defn): Likewise.
2233
2234 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2235
2236         * ada-lang.c (ada_is_character_type): Change return type to bool.
2237         (ada_is_string_type): Likewise.
2238         * ada-lang.h (ada_is_character_type): Update declaration
2239         (ada_is_string_type): Likewise.
2240
2241 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2242
2243         Support style in 'frame|thread apply'
2244
2245         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2246         * record.c (record_start, record_stop): Update callers of
2247         execute_command_to_string with false.
2248         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2249         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2250         methods.
2251         (class string_file): New constructor with term_out parameter.
2252         Override methods term_out and can_emit_style_escape.  New member
2253         term_out.
2254         (class stdio_file): Override can_emit_style_escape.
2255         (class tee_file): Override term_out and can_emit_style_escape.
2256         * utils.h (can_emit_style_escape): Remove.
2257         * utils.c (can_emit_style_escape): Likewise.
2258         Update all callers of can_emit_style_escape (SOMESTREAM) to
2259         SOMESTREAM->can_emit_style_escape.
2260         * source-cache.c (source_cache::get_source_lines): Likewise.
2261         * stack.c (frame_apply_command_count): Call execute_command_to_string
2262         passing the term_out characteristic of the current gdb_stdout.
2263         * thread.c (thr_try_catch_cmd): Likewise.
2264         * top.c (execute_command_to_string): pass term_out parameter
2265         to construct the string_file for the command output.
2266         * ui-file.c (term_cli_styling): New function (most code moved
2267         from utils.c can_emit_style_escape).
2268         (string_file::string_file, string_file::can_emit_style_escape,
2269         stdio_file::can_emit_style_escape, tee_file::term_out,
2270         tee_file::can_emit_style_escape): New functions.
2271
2272 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2273
2274         * NEWS: Mention the new set|show may-call-functions.
2275         * infcall.c (may_call_functions_p): New variable.
2276         (show_may_call_functions_p): New function.
2277         (call_function_by_hand_dummy): Throws an error if not
2278         may-call-functions.
2279         (_initialize_infcall): Call add_setshow_boolean_cmd for
2280         may-call-functions.
2281
2282 2019-04-25  Keith Seitz  <keiths@redhat.com>
2283
2284         PR c++/24367
2285         * cp-support.c (inspect_type): Don't attempt substitutions
2286         of symbol with the same name.
2287
2288 2019-04-25  Tom Tromey  <tromey@adacore.com>
2289
2290         PR gdb/24475:
2291         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2292         static.
2293
2294 2019-04-25  Tom Tromey  <tromey@adacore.com>
2295
2296         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2297         rvalue reference.
2298         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2299         (gdb_xml_parser::parse): Use std::move.
2300         * python/python-internal.h (gdbpy_convert_exception): Take a const
2301         reference.
2302         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2303         std::move.
2304         * python/py-utils.c (gdbpy_convert_exception): Take a const
2305         reference.
2306         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2307         Use std::move.
2308         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2309         Use std::move.
2310         * mi/mi-main.c (mi_print_exception): Take a const reference.
2311         * main.c (handle_command_errors): Take a const reference.
2312         * linespec.c (parse_linespec): Use std::move.
2313         * infcall.c (run_inferior_call): Use std::move.
2314         (call_function_by_hand_dummy): Use std::move.
2315         * exec.c (try_open_exec_file): Use std::move.
2316         * exceptions.h (exception_print, exception_fprintf)
2317         (exception_print_same): Update.
2318         * exceptions.c (print_exception, exception_print)
2319         (exception_fprintf, exception_print_same): Change parameters to
2320         const reference.
2321         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2322         * common/new-op.c: Use std::move.
2323         * common/common-exceptions.h (struct gdb_exception): Add move
2324         constructor.
2325         (struct gdb_exception_error, struct gdb_exception_quit, struct
2326         gdb_quit_bad_alloc): Change constructor to move constructor.
2327         (throw_exception): Change parameter to rvalue reference.
2328         * common/common-exceptions.c (throw_exception): Take rvalue
2329         reference.
2330         * cli/cli-interp.c (safe_execute_command): Use std::move.
2331         * breakpoint.c (insert_bp_location, location_to_sals): Use
2332         std::move.
2333
2334 2019-04-25  Tom Tromey  <tromey@adacore.com>
2335
2336         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2337         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2338         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2339         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2340         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2341         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2342         guile/scm-value.c: Use unpack.
2343         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2344         gdbscm_gdb_exception.
2345         (gdbscm_throw_gdb_exception): Likewise.
2346         (struct gdbscm_gdb_exception): New.
2347         (unpack): New function.
2348         (gdbscm_wrap): Use unpack.
2349
2350 2019-04-25  Tom Tromey  <tromey@adacore.com>
2351
2352         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2353         (gdb_rl_callback_handler): Use std::move.
2354         * common/common-exceptions.h (struct gdb_exception): Add move
2355         assignment operator.
2356         (throw_exception_sjlj): Change "exception" to const reference.
2357         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2358         (throw_exception_sjlj): Change "exception" to const reference.
2359
2360 2019-04-25  Tom Tromey  <tromey@adacore.com>
2361
2362         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2363         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2364         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2365         Update.
2366         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2367         Update.
2368         * mi/mi-interp.c (mi_interp::exec): Update.
2369         * linespec.c (parse_linespec): Update.
2370         * infcall.c (run_inferior_call): Update.
2371         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2372         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2373         (gdbscm_lookup_global_symbol): Update.
2374         * guile/scm-param.c (gdbscm_parameter_value): Update.
2375         * guile/scm-frame.c (gdbscm_frame_read_register)
2376         (gdbscm_frame_read_var): Update.
2377         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2378         * exec.c (try_open_exec_file): Update.
2379         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2380         (gdb_rl_callback_handler): Update.
2381         * common/common-exceptions.h (exception_none): Don't declare.
2382         * common/common-exceptions.c (exception_none): Don't define.
2383         (struct catcher) <exception>: Update.
2384         * cli/cli-interp.c (safe_execute_command): Update.
2385         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2386
2387 2019-04-25  Ali Tamur  <tamur@google.com>
2388
2389         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2390         (read_attribute_value): Likewise.
2391         (dwarf2_read_addr_index): Update comment.
2392         (read_str_index): Add DW_FORM_strx.
2393         (dwarf2_string_attr): Likewise.
2394         (dwarf2_const_value_attr): Likewise.
2395         (dump_die_shallow): Likewise.
2396         (dwarf2_fetch_constant_bytes): Likewise.
2397         (skip_form_bytes): Likewise.
2398         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2399
2400 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2401
2402         PR corefiles/11608
2403         PR corefiles/18187
2404         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2405         OFFSET.  Verify if current mapping contains an ELF header.
2406         (linux_find_memory_regions_full): Adjust call to
2407         dump_mapping_p.
2408
2409 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2410             Kang Li <kanglictf@gmail.com>
2411
2412         PR gdb/21600
2413
2414         * dwarf2-frame.c (read_initial_length): Be consistent about using
2415         unsigned representation of length.
2416         (decode_frame_entry_1): Likewise.  Check for wraparound of
2417         end pointer as well as buffer overflow.
2418
2419 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2420
2421         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2422         "vq".
2423
2424 2019-04-24  Tom Tromey  <tromey@adacore.com>
2425
2426         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2427
2428 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2429
2430         * s12z-tdep.c (s12z_unwind_pc): Delete.
2431         (s12z_unwind_sp): Delete.
2432         (s12z_gdbarch_init): Don't register deleted functions with
2433         gdbarch.
2434
2435 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2436
2437         * rl78-tdep.c (rl78_unwind_sp): Delete.
2438         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2439
2440 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2441
2442         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2443         (xstormy16_unwind_pc): Delete.
2444         (xstormy16_dummy_id): Delete.
2445         (xstormy16_gdbarch_init): Don't register deleted functions with
2446         gdbarch.
2447
2448 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2449
2450         * vax-tdep.c (vax_unwind_pc): Delete.
2451         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2452
2453 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2454
2455         * v850-tdep.c (v850_unwind_sp): Delete.
2456         (v850_unwind_pc): Delete.
2457         (v850_dummy_id): Delete.
2458         (v850_gdbarch_init): Don't register deleted functions with
2459         gdbarch.
2460
2461 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2462
2463         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2464         (tilegx_unwind_pc): Delete.
2465         (tilegx_unwind_dummy_id): Delete.
2466         (tilegx_gdbarch_init): Don't register deleted functions with
2467         gdbarch.
2468
2469 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2470
2471         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2472         (tic6x_dummy_id): Delete.
2473         (tic6x_gdbarch_init): Don't register deleted functions with
2474         gdbarch.
2475
2476 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2477
2478         * sparc-tdep.c (sparc_unwind_pc): Delete.
2479         (sparc32_gdbarch_init): Don't register deleted function with
2480         gdbarch.
2481
2482 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2483
2484         * sh-tdep.c (sh_unwind_sp): Delete.
2485         (sh_unwind_pc): Delete.
2486         (sh_dummy_id): Delete.
2487         (sh_gdbarch_init): Don't register deleted functions with
2488         gdbarch.
2489
2490 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2491
2492         * score-tdep.c (score_unwind_sp): Delete.
2493         (score_unwind_pc): Delete.
2494         (score_dummy_id): Delete.
2495         (score_gdbarch_init): Don't register deleted functions with
2496         gdbarch.
2497
2498 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2499
2500         * rx-tdep.c (rx_unwind_pc): Delete.
2501         (rx_unwind_sp): Delete.
2502         (rx_dummy_id): Delete.
2503         (rx_gdbarch_init): Don't register deleted functions with
2504         gdbarch.  Update comment.
2505
2506 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2507
2508         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2509         (rs6000_dummy_id): Delete.
2510         (rs6000_gdbarch_init): Don't register deleted functions with
2511         gdbarch.
2512
2513 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2514
2515         * or1k-tdep.c (or1k_dummy_id): Delete.
2516         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2517
2518 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2519
2520         * nios2-tdep.c (nios2_dummy_id): Delete.
2521         (nios2_unwind_sp): Delete.
2522         (nios2_gdbarch_init): Don't register deleted functions with
2523         gdbarch.
2524
2525 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2526
2527         * nds32-tdep.c (nds32_dummy_id): Delete.
2528         (nds32_unwind_pc): Delete.
2529         (nds32_unwind_sp): Delete.
2530         (nds32_gdbarch_init): Don't register deleted functions with
2531         gdbarch.
2532
2533 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2534
2535         * msp430-tdep.c (msp430_unwind_pc): Delete.
2536         (msp430_unwind_sp): Delete.
2537         (msp430_dummy_id): Delete.
2538         (msp430_gdbarch_init): Don't register deleted functions with
2539         gdbarch.
2540
2541 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2542
2543         * moxie-tdep.c (moxie_unwind_sp): Delete.
2544         (moxie_unwind_pc): Delete.
2545         (moxie_dummy_id): Delete.
2546         (moxie_gdbarch_init): Don't register deleted functions with
2547         gdbarch.
2548
2549 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2550
2551         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2552         (mn10300_unwind_pc): Delete.
2553         (mn10300_unwind_sp): Delete.
2554         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2555         mn10300_unwind_sp.
2556         (mn10300_frame_unwind_init): Don't register deleted functions with
2557         gdbarch.
2558
2559 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2560
2561         * mep-tdep.c (mep_unwind_pc): Delete.
2562         (mep_unwind_sp): Delete.
2563         (mep_dummy_id): Delete.
2564         (mep_gdbarch_init): Don't register deleted functions with
2565         gdbarch.
2566
2567 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2568
2569         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2570         (m68hc11_unwind_sp): Delete.
2571         (m68hc11_gdbarch_init): Don't register deleted functions with
2572         gdbarch.
2573
2574 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2575
2576         * m32r-tdep.c (m32r_unwind_sp): Delete.
2577         (m32r_unwind_pc): Delete.
2578         (m32r_dummy_id): Delete.
2579         (m32r_gdbarch_init): Don't register deleted functions with
2580         gdbarch.
2581
2582 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2583
2584         * m32c-tdep.c (m32c_unwind_pc): Delete.
2585         (m32c_unwind_sp): Delete.
2586         (m32c_dummy_id): Delete.
2587         (m32c_gdbarch_init): Don't register deleted functions with
2588         gdbarch.
2589
2590 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2591
2592         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2593         (lm32_unwind_pc): Delete.
2594         (lm32_dummy_id): Delete.
2595         (lm32_gdbarch_init): Don't register deleted functions with
2596         gdbarch.
2597
2598 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2599
2600         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2601         (iq2000_unwind_pc): Delete.
2602         (iq2000_dummy_id): Delete.
2603         (iq2000_gdbarch_init): Don't register deleted functions with
2604         gdbarch.
2605
2606 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2607
2608         * nds32-tdep.c (nds32_type_align): Delete.
2609         (nds32_push_dummy_call): Use type_align instead.
2610
2611 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2612
2613         * arm-tdep.c (arm_type_align): Only handle vector override case.
2614         (arm_push_dummy_call): Use type_align.
2615         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2616
2617 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2618
2619         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2620         case.
2621         (pass_on_stack): Use type_align.
2622         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2623         function.
2624
2625 2019-04-23  Tom Tromey  <tromey@adacore.com>
2626
2627         * dwarf2read.c (line_header::file_name_at): Remove unused
2628         overload.
2629
2630 2019-04-23  Tom de Vries  <tdevries@suse.de>
2631
2632         PR gdb/24438
2633         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2634         invocation.
2635
2636
2637 2019-03-27  Ali Tamur  <tamur@google.com>
2638
2639         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2640         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2641         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2642         (dwarf_expr_context::get_addr_index): Likewise
2643         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2644         (symbol_needs_eval_context::get_addr_index): Likewise
2645         (disassemble_dwarf_expression): Add DW_OP_addrx
2646         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2647         (read_cutu_die_from_dwo): Update comment
2648         (skip_one_die): Add DW_FORM_addrx
2649         (read_attribute_value): Likewise
2650         (var_decode_location): Add DW_OP_addrx
2651         (dwarf2_const_value_attr): Add DW_FORM_addrx
2652         (dump_die_shallow): Likewise
2653         (dwarf2_fetch_constant_bytes): Likewise
2654         (decode_locdesc): Add DW_OP_addrx
2655         (skip_form_bytes): Add DW_FORM_addrx
2656
2657 2019-04-22  Ali Tamur  <tamur@google.com>
2658
2659         * MAINTAINERS (Write After Approval): Add self.
2660
2661 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2662
2663         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2664         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2665         (open_symbol_file_object): Likewise.
2666         (svr4_default_sos): Add info parameter.
2667         (svr4_read_so_list): Likewise.
2668         (svr4_current_sos_direct): Adjust functions calls to pass down
2669         info.
2670         (svr4_current_sos_1): Add info parameter.
2671         (svr4_current_sos): Call get_svr4_info, pass info down to
2672         svr4_current_sos_1.
2673         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2674         get_svr4_info.
2675         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2676         get_svr4_info.
2677         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2678         to get_svr4_info.
2679         (probes_table_remove_objfile_probes): Likewise.
2680         (register_solib_event_probe): Add info parameter.
2681         (solist_update_incremental): Pass info parameter down to
2682         svr4_read_so_list.
2683         (disable_probes_interface): Add info parameter.
2684         (svr4_handle_solib_event): Pass current_program_space to
2685         get_svr4_info.  Adjust disable_probes_interface cleanup.
2686         (svr4_create_probe_breakpoints): Add info parameter, pass it
2687         down to register_solib_event_probe.
2688         (svr4_create_solib_event_breakpoints): Add info parameter,
2689         pass it down to svr4_create_probe_breakpoints.
2690         (enable_break): Pass info down to
2691         svr4_create_solib_event_breakpoints.
2692         (svr4_solib_create_inferior_hook): Pass current_program_space to
2693         get_svr4_info.
2694         (svr4_clear_solib): Likewise.
2695
2696 2019-04-22  Pedro Alves  <palves@redhat.com>
2697
2698         * solib-svr4.c (svr4_free_objfile_observer): New.
2699         (probe_and_action::objfile): New field.
2700         (probes_table_htab_remove_objfile_probes)
2701         (probes_table_remove_objfile_probes): New functions.
2702         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2703         in the new probe_and_action.  Don't store the probe in 'lookup'.
2704         (svr4_create_probe_breakpoints): Pass objfile to
2705         register_solib_event_probe.
2706         (_initialize_svr4_solib): Register a free_objfile observer.
2707
2708 2019-04-19  Tom Tromey  <tom@tromey.com>
2709
2710         * common/queue.h: Remove.
2711
2712 2019-04-19  Tom Tromey  <tom@tromey.com>
2713
2714         * event-loop.c: Don't include "common/queue.h".
2715
2716 2019-04-19  Tom Tromey  <tom@tromey.com>
2717
2718         * remote.c (remote_target): Use delete.
2719         * remote-notif.h: Include <list>, not "common/queue.h".
2720         (notif_client_p): Remove typedef.
2721         (remote_notif_state): Add constructor, destructor, initializer.
2722         <notif_queue>: Now a std::list.
2723         (remote_notif_state_xfree): Don't declare.
2724         * remote-notif.c (remote_notif_process, handle_notification)
2725         (remote_notif_state_allocate): Update.
2726         (~remote_notif_state): Rename from remote_notif_state_xfree.
2727
2728 2019-04-19  Tom Tromey  <tom@tromey.com>
2729
2730         * symfile.c (reread_symbols): Update.
2731         * objfiles.c (objfile_register_static_link)
2732         (objfile_lookup_static_link): Update
2733         (~objfile) Don't delete static_links.
2734         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2735
2736 2019-04-19  Tom Tromey  <tom@tromey.com>
2737
2738         * type-stack.h (struct type_stack) <insert>: Constify string.
2739         * type-stack.c (type_stack::insert): Constify string.
2740         * gdbtypes.h (lookup_template_type): Update.
2741         (address_space_name_to_int): Update.
2742         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2743         const.
2744         (lookup_template_type): Make name const.
2745         * c-exp.y: Update rules.
2746         (lex_one_token, classify_name, classify_inner_name)
2747         (c_print_token): Update.
2748         * p-exp.y: Update rules.
2749         (yylex): Update.
2750         * f-exp.y: Update rules.
2751         (yylex): Update.
2752         * d-exp.y: Update rules.
2753         (lex_one_token, classify_name, classify_inner_name): Update.
2754         * parse.c (write_dollar_variable, copy_name): Return std::string.
2755         * parser-defs.h (copy_name): Change return type.
2756         * m2-exp.y: Update rules.
2757         (yylex): Update.
2758         * go-exp.y (lex_one_token): Update.
2759         Update rules.
2760         (classify_unsafe_function, classify_packaged_name)
2761         (classify_name, yylex): Update.
2762
2763 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2764
2765         * configure.ac: add --enable-source-highlight switch.
2766         * configure: Regenerate.
2767         * top.c (print_gdb_version): plumb --enable-source-highlight
2768         status to "show configuration".
2769
2770 2019-04-19  Tom Tromey  <tromey@adacore.com>
2771
2772         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2773         Check ADA_TYPE_P.
2774         (empty_record, ada_template_to_fixed_record_type_1)
2775         (template_to_static_fixed_type)
2776         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2777         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2778         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2779         macros.
2780
2781 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2782
2783         PR symtab/24423:
2784         * source.c (print_source_lines_base): Advance "iter" when a
2785         control character is seen.
2786
2787 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2788
2789         * inferior.h (struct infcall_suspend_state_deleter):
2790         Catch exception in destructor to avoid crash.
2791
2792 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2793
2794         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2795         close to the add_com "shell".
2796
2797 2019-04-18  Tom Tromey  <tromey@adacore.com>
2798
2799         * process-stratum-target.h (class process_stratum_target)
2800         <stratum>: Add "final".
2801
2802 2019-04-17  Tom Tromey  <tromey@adacore.com>
2803
2804         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2805         against nullptr before use.
2806
2807 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2808
2809         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2810
2811 2019-04-17  Jim Wilson  <jimw@sifive.com>
2812             Andrew Burgess  <andrew.burgess@embecosm.com>
2813
2814         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2815         code read might fail, assume 4-byte breakpoint in that case.
2816
2817 2019-04-15  Leszek Swirski  <leszeks@google.com>
2818
2819         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2820         rather than a hand-rolled POD check when checking for forced MEMORY
2821         classification.
2822
2823 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2824
2825         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2826         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2827         function.
2828         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2829         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2830         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2831         declaration.
2832
2833 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2834
2835         * aarch64-linux-nat.c
2836         (aarch64_linux_nat_target::thread_architecture): Add override.
2837         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2838         each VQ.
2839
2840 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2841
2842         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2843
2844 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2845
2846         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2847         target types of size 96-bits, add some additional comments, and
2848         check that the builtin type we found was the correct size.
2849
2850 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2851
2852         * utils.c (prompt_for_continue): Don't restore the styling at the
2853         end, as applied_style has the wrong value.  This fixes styling in
2854         long lists of file names that are interrupted by the "Continue?"
2855         prompt.
2856
2857 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2858
2859         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2860         * c-lang.c (c_language_defn): Likewise.
2861         (cplus_language_defn): Likewise.
2862         (asm_language_defn): Likewise.
2863         (minimal_language_defn): Likewise.
2864         * d-lang.c (d_language_defn): Likewise.
2865         * f-lang.c (f_language_defn): Likewise.
2866         * go-lang.c (go_language_defn): Likewise.
2867         * language.c (unknown_language_defn): Likewise.
2868         (auto_language_defn): Likewise.
2869         * language.h (struct language_defn): Remove la_magic field.
2870         (LANG_MAGIC): Delete.
2871         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2872         * objc-lang.c (objc_language_defn): Likewise.
2873         * opencl-lang.c (opencl_language_defn): Likewise.
2874         * p-lang.c (pascal_language_defn): Likewise.
2875         * rust-lang.c (rust_language_defn): Likewise.
2876
2877 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2878
2879         * riscv-tdep.c (riscv_type_align): New function.
2880         (riscv_type_alignment): Delete.
2881         (riscv_arg_location): Use 'type_align'.
2882         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2883
2884 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2885
2886         * gdbtypes.c (type_align): A struct with no non-static fields also
2887         has alignment of 1.
2888
2889 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2890
2891         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2892         component to 0.
2893         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2894         member.
2895         (riscv_struct_info::analyse): New implementation using new
2896         analyse_inner member function.
2897         (riscv_struct_info::field_offset): New member function.
2898         (riscv_struct_info::m_offsets): New member variable.
2899         (riscv_struct_info::analyse_inner): New private member function,
2900         takes the old implementation of riscv_struct_info::analyse but
2901         extended to track field offsets.
2902         (riscv_call_arg_struct): Update the struct folding special cases
2903         to handle cases where empty C++ structs, which are non-zero
2904         length, are found.
2905         (riscv_arg_location): Initialise the length of each location, a
2906         non-zero length now indicates the location is in use.
2907         (riscv_push_dummy_call): Allow for the first location having a
2908         non-zero offset when setting up arguments.
2909         (riscv_return_value): Likewise, but for return values.
2910
2911 2019-04-11  Tom Tromey  <tromey@adacore.com>
2912
2913         * utils.c (internal_vproblem): Make "msg" const.
2914
2915 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2916
2917         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2918         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2919         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2920         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2921
2922 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2923
2924         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2925         function.
2926         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2927         of amd64_collect_native_gregset.
2928         (amd64_linux_nat_target::store_registers): Likewise.
2929
2930 2019-04-10  Tom Tromey  <tom@tromey.com>
2931
2932         * symtab.c (lookup_global_symbol_from_objfile)
2933         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2934         * objfiles.h (class separate_debug_iterator): New.
2935         (class separate_debug_range): New.
2936         (struct objfile) <separate_debug_objfiles>: New method.
2937         (objfile_separate_debug_iterate): Don't declare.
2938         * objfiles.c (separate_debug_iterator::operator++): Rename from
2939         objfile_separate_debug_iterate.
2940         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2941         iterator.
2942         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2943         iterator.
2944
2945 2019-04-10  Tom Tromey  <tom@tromey.com>
2946
2947         * symfile.c (reread_symbols): Remove old comment.
2948         * objfiles.c (free_all_objfiles): Fix a typo.
2949
2950 2019-04-10  Tom Tromey  <tom@tromey.com>
2951
2952         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2953         * minsyms.c (lookup_minimal_symbol): Use foreach.
2954         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2955         (lookup_minimal_symbol_solib_trampoline): Likewise.
2956         * symfile.c (reread_symbols): Use foreach.
2957
2958 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2959             Tom Tromey  <tromey@adacore.com>
2960
2961         PR rust/24414:
2962         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2963         (rust_lex_int_test): Change "value" to be LONGEST.
2964         (rust_lex_tests): Add test for long integer literal.
2965
2966 2019-04-09  Tom Tromey  <tromey@adacore.com>
2967
2968         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2969         to bool.
2970         (extended_remote_target::attach): Update.
2971         (remote_target::remote_notice_new_inferior): Update.
2972         (remote_target::add_current_inferior_and_thread): Update.
2973         * inferior.c (exit_inferior_1): Use "false".
2974         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2975
2976 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2977
2978         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2979         the "start" command.
2980
2981 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2982
2983         * python/py-inferior.c (infpy_thread_from_thread_handle):
2984         Adjust comments to reflect renaming of thread_from_thread_handle
2985         to thread_from_handle.  Adjust keywords.  Fix type error message.
2986         (inferior_object_methods): Add thread_from_handle.  Retain
2987         thread_from_thread_handle, but mark it as deprecated.
2988
2989 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2990
2991         * gdbthread.h (find_thread_by_handle): Revise declaration.
2992         * thread.c (find_thread_by_handle): Likewise.  Adjust
2993         implementation too.
2994         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2995         support for buffer objects as handles.
2996
2997 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2998
2999         * python/py-infthread.c (thpy_thread_handle): New function.
3000         (thread_object_methods): Register thpy_thread_handle.
3001
3002 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3003
3004         * gdbthread.h (thread_to_thread_handle): Declare.
3005         * thread.c (gdbtypes.h): Include.
3006         (thread_to_thread_handle): New function.
3007
3008         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3009         (target_thread_info_to_thread_handle): Declare.
3010         * target.c (target_thread_info_to_thread_handle): New function.
3011         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3012         * target-delegates.c: Regenerate.
3013
3014         * linux-thread-db.c (class thread_db_target): Add method
3015         thread_info_to_thread_handle.
3016         (thread_db_target::thread_info_to_thread_handle): Define.
3017         * remote.c (class remote_target): Add new method
3018         thread_info_to_thread_handle.
3019         (remote_target::thread_info_to_thread_handle): Define.
3020
3021 2019-04-08  Pedro Alves  <palves@redhat.com>
3022
3023         * common/common-exceptions.c (throw_exception): Don't create
3024         named object to throw; throw directly.
3025         (throw_it): Likewise.  Don't initialize gdb_exception::message
3026         here, with new; pass FMT and AP to the ctor instead.
3027         * common/common-exceptions.h: Include <string>.
3028         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3029         const char *, va_list)): New ctor.  Use std::make_shared.
3030         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3031         errors)): Delete.
3032         (gdb_exception_error::gdb_exception_error(enum errors, const char
3033         *, va_list)): New.
3034         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3035         Add assertion.
3036         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3037         errors)): Delete.
3038         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3039         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3040         Add assertion.
3041
3042 2019-04-08  Tom Tromey  <tom@tromey.com>
3043
3044         * valops.c (value_rtti_indirect_type): Replace throw_exception
3045         with throw.
3046         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3047         with throw.
3048         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3049         throw.
3050         * target.c (target_translate_tls_address): Replace throw_exception
3051         with throw.
3052         * stack.c (frame_apply_command_count): Replace throw_exception
3053         with throw.
3054         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3055         throw.
3056         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3057         with throw.
3058         * rs6000-tdep.c (rs6000_frame_cache)
3059         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3060         * remote.c: Replace throw_exception with throw.
3061         * record-full.c (record_full_message, record_full_wait_1)
3062         (record_full_restore): Replace throw_exception with throw.
3063         * record-btrace.c:
3064         (get_thread_current_frame_id, record_btrace_start_replaying)
3065         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3066         (cmd_record_btrace_start): Replace throw_exception with throw.
3067         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3068         throw.
3069         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3070         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3071         * linespec.c:
3072         (find_linespec_symbols): Replace throw_exception with throw.
3073         * infrun.c (displaced_step_prepare, resume): Replace
3074         throw_exception with throw.
3075         * infcmd.c (post_create_inferior): Replace throw_exception with
3076         throw.
3077         * inf-loop.c (inferior_event_handler): Replace throw_exception
3078         with throw.
3079         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3080         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3081         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3082         (get_prev_frame_always, get_frame_pc_if_available)
3083         (get_frame_address_in_block_if_available, get_frame_language):
3084         Replace throw_exception with throw.
3085         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3086         throw_exception with throw.
3087         * eval.c (fetch_subexp_value, evaluate_var_value)
3088         (evaluate_funcall, evaluate_subexp_standard): Replace
3089         throw_exception with throw.
3090         * dwarf2loc.c (call_site_find_chain)
3091         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3092         Replace throw_exception with throw.
3093         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3094         with throw.
3095         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3096         throw.
3097         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3098         * completer.c (complete_line_internal): Replace throw_exception
3099         with throw.
3100         * compile/compile-object-run.c (compile_object_run): Replace
3101         throw_exception with throw.
3102         * cli/cli-script.c (process_next_line): Replace throw_exception
3103         with throw.
3104         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3105         (btrace_enable, btrace_maint_update_pt_packets): Replace
3106         throw_exception with throw.
3107         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3108         throw_exception with throw.
3109         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3110         throw_exception with throw.
3111         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3112         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3113         * aarch64-tdep.c (aarch64_make_prologue_cache)
3114         (aarch64_make_stub_cache): Replace throw_exception with throw.
3115
3116 2019-04-08  Tom Tromey  <tom@tromey.com>
3117
3118         * common/common-exceptions.c (throw_exception): Rename from
3119         throw_exception_cxx.  Remove old copy.  Make argument const.
3120         (throw_it): Create and throw exception objects directly.
3121         * common/common-exceptions.h (throw_exception): Make argument
3122         const.
3123         (struct gdb_exception_error): Add constructor.
3124         (struct gdb_exception_quit): Add constructor.
3125
3126 2019-04-08  Tom Tromey  <tom@tromey.com>
3127
3128         * common/common-exceptions.h (exception_rethrow): Don't declare.
3129         (TRY_SJLJ): Update comment.
3130         (TRY, CATCH, END_CATCH): Remove.
3131         * common/common-exceptions.c (exception_rethrow): Remove.
3132
3133 2019-04-08  Tom Tromey  <tom@tromey.com>
3134
3135         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3136         Remove.
3137         (gdb_exception_error): Rename from
3138         gdb_exception_RETURN_MASK_ERROR.
3139         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3140         (gdb_quit_bad_alloc): Update.
3141         * aarch64-tdep.c: Update.
3142         * ada-lang.c: Update.
3143         * ada-typeprint.c: Update.
3144         * ada-valprint.c: Update.
3145         * amd64-tdep.c: Update.
3146         * arch-utils.c: Update.
3147         * break-catch-throw.c: Update.
3148         * breakpoint.c: Update.
3149         * btrace.c: Update.
3150         * c-varobj.c: Update.
3151         * cli/cli-cmds.c: Update.
3152         * cli/cli-interp.c: Update.
3153         * cli/cli-script.c: Update.
3154         * common/common-exceptions.c: Update.
3155         * common/new-op.c: Update.
3156         * common/selftest.c: Update.
3157         * compile/compile-c-symbols.c: Update.
3158         * compile/compile-cplus-symbols.c: Update.
3159         * compile/compile-object-load.c: Update.
3160         * compile/compile-object-run.c: Update.
3161         * completer.c: Update.
3162         * corelow.c: Update.
3163         * cp-abi.c: Update.
3164         * cp-support.c: Update.
3165         * cp-valprint.c: Update.
3166         * darwin-nat.c: Update.
3167         * disasm-selftests.c: Update.
3168         * dtrace-probe.c: Update.
3169         * dwarf-index-cache.c: Update.
3170         * dwarf-index-write.c: Update.
3171         * dwarf2-frame-tailcall.c: Update.
3172         * dwarf2-frame.c: Update.
3173         * dwarf2loc.c: Update.
3174         * dwarf2read.c: Update.
3175         * eval.c: Update.
3176         * event-loop.c: Update.
3177         * event-top.c: Update.
3178         * exec.c: Update.
3179         * f-valprint.c: Update.
3180         * fbsd-tdep.c: Update.
3181         * frame-unwind.c: Update.
3182         * frame.c: Update.
3183         * gdbtypes.c: Update.
3184         * gnu-v3-abi.c: Update.
3185         * guile/guile-internal.h: Update.
3186         * guile/scm-block.c: Update.
3187         * guile/scm-breakpoint.c: Update.
3188         * guile/scm-cmd.c: Update.
3189         * guile/scm-disasm.c: Update.
3190         * guile/scm-frame.c: Update.
3191         * guile/scm-lazy-string.c: Update.
3192         * guile/scm-math.c: Update.
3193         * guile/scm-param.c: Update.
3194         * guile/scm-ports.c: Update.
3195         * guile/scm-pretty-print.c: Update.
3196         * guile/scm-symbol.c: Update.
3197         * guile/scm-symtab.c: Update.
3198         * guile/scm-type.c: Update.
3199         * guile/scm-value.c: Update.
3200         * i386-linux-tdep.c: Update.
3201         * i386-tdep.c: Update.
3202         * inf-loop.c: Update.
3203         * infcall.c: Update.
3204         * infcmd.c: Update.
3205         * infrun.c: Update.
3206         * jit.c: Update.
3207         * language.c: Update.
3208         * linespec.c: Update.
3209         * linux-fork.c: Update.
3210         * linux-nat.c: Update.
3211         * linux-tdep.c: Update.
3212         * linux-thread-db.c: Update.
3213         * main.c: Update.
3214         * mi/mi-cmd-break.c: Update.
3215         * mi/mi-cmd-stack.c: Update.
3216         * mi/mi-interp.c: Update.
3217         * mi/mi-main.c: Update.
3218         * objc-lang.c: Update.
3219         * p-valprint.c: Update.
3220         * parse.c: Update.
3221         * ppc-linux-tdep.c: Update.
3222         * printcmd.c: Update.
3223         * python/py-arch.c: Update.
3224         * python/py-breakpoint.c: Update.
3225         * python/py-cmd.c: Update.
3226         * python/py-finishbreakpoint.c: Update.
3227         * python/py-frame.c: Update.
3228         * python/py-framefilter.c: Update.
3229         * python/py-gdb-readline.c: Update.
3230         * python/py-inferior.c: Update.
3231         * python/py-infthread.c: Update.
3232         * python/py-lazy-string.c: Update.
3233         * python/py-linetable.c: Update.
3234         * python/py-objfile.c: Update.
3235         * python/py-param.c: Update.
3236         * python/py-prettyprint.c: Update.
3237         * python/py-progspace.c: Update.
3238         * python/py-record-btrace.c: Update.
3239         * python/py-record.c: Update.
3240         * python/py-symbol.c: Update.
3241         * python/py-type.c: Update.
3242         * python/py-unwind.c: Update.
3243         * python/py-utils.c: Update.
3244         * python/py-value.c: Update.
3245         * python/python.c: Update.
3246         * record-btrace.c: Update.
3247         * record-full.c: Update.
3248         * remote-fileio.c: Update.
3249         * remote.c: Update.
3250         * riscv-tdep.c: Update.
3251         * rs6000-aix-tdep.c: Update.
3252         * rs6000-tdep.c: Update.
3253         * rust-exp.y: Update.
3254         * rust-lang.c: Update.
3255         * s390-tdep.c: Update.
3256         * selftest-arch.c: Update.
3257         * solib-dsbt.c: Update.
3258         * solib-frv.c: Update.
3259         * solib-spu.c: Update.
3260         * solib-svr4.c: Update.
3261         * solib.c: Update.
3262         * sparc64-linux-tdep.c: Update.
3263         * stack.c: Update.
3264         * symfile-mem.c: Update.
3265         * symmisc.c: Update.
3266         * target.c: Update.
3267         * thread.c: Update.
3268         * top.c: Update.
3269         * tracefile-tfile.c: Update.
3270         * tui/tui.c: Update.
3271         * typeprint.c: Update.
3272         * unittests/cli-utils-selftests.c: Update.
3273         * unittests/parse-connection-spec-selftests.c: Update.
3274         * valops.c: Update.
3275         * valprint.c: Update.
3276         * value.c: Update.
3277         * varobj.c: Update.
3278         * windows-nat.c: Update.
3279         * x86-linux-nat.c: Update.
3280         * xml-support.c: Update.
3281
3282 2019-04-08  Tom Tromey  <tom@tromey.com>
3283
3284         * xml-support.c: Use C++ exception handling.
3285         * x86-linux-nat.c: Use C++ exception handling.
3286         * windows-nat.c: Use C++ exception handling.
3287         * varobj.c: Use C++ exception handling.
3288         * value.c: Use C++ exception handling.
3289         * valprint.c: Use C++ exception handling.
3290         * valops.c: Use C++ exception handling.
3291         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3292         handling.
3293         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3294         * typeprint.c: Use C++ exception handling.
3295         * tui/tui.c: Use C++ exception handling.
3296         * tracefile-tfile.c: Use C++ exception handling.
3297         * top.c: Use C++ exception handling.
3298         * thread.c: Use C++ exception handling.
3299         * target.c: Use C++ exception handling.
3300         * symmisc.c: Use C++ exception handling.
3301         * symfile-mem.c: Use C++ exception handling.
3302         * stack.c: Use C++ exception handling.
3303         * sparc64-linux-tdep.c: Use C++ exception handling.
3304         * solib.c: Use C++ exception handling.
3305         * solib-svr4.c: Use C++ exception handling.
3306         * solib-spu.c: Use C++ exception handling.
3307         * solib-frv.c: Use C++ exception handling.
3308         * solib-dsbt.c: Use C++ exception handling.
3309         * selftest-arch.c: Use C++ exception handling.
3310         * s390-tdep.c: Use C++ exception handling.
3311         * rust-lang.c: Use C++ exception handling.
3312         * rust-exp.y: Use C++ exception handling.
3313         * rs6000-tdep.c: Use C++ exception handling.
3314         * rs6000-aix-tdep.c: Use C++ exception handling.
3315         * riscv-tdep.c: Use C++ exception handling.
3316         * remote.c: Use C++ exception handling.
3317         * remote-fileio.c: Use C++ exception handling.
3318         * record-full.c: Use C++ exception handling.
3319         * record-btrace.c: Use C++ exception handling.
3320         * python/python.c: Use C++ exception handling.
3321         * python/py-value.c: Use C++ exception handling.
3322         * python/py-utils.c: Use C++ exception handling.
3323         * python/py-unwind.c: Use C++ exception handling.
3324         * python/py-type.c: Use C++ exception handling.
3325         * python/py-symbol.c: Use C++ exception handling.
3326         * python/py-record.c: Use C++ exception handling.
3327         * python/py-record-btrace.c: Use C++ exception handling.
3328         * python/py-progspace.c: Use C++ exception handling.
3329         * python/py-prettyprint.c: Use C++ exception handling.
3330         * python/py-param.c: Use C++ exception handling.
3331         * python/py-objfile.c: Use C++ exception handling.
3332         * python/py-linetable.c: Use C++ exception handling.
3333         * python/py-lazy-string.c: Use C++ exception handling.
3334         * python/py-infthread.c: Use C++ exception handling.
3335         * python/py-inferior.c: Use C++ exception handling.
3336         * python/py-gdb-readline.c: Use C++ exception handling.
3337         * python/py-framefilter.c: Use C++ exception handling.
3338         * python/py-frame.c: Use C++ exception handling.
3339         * python/py-finishbreakpoint.c: Use C++ exception handling.
3340         * python/py-cmd.c: Use C++ exception handling.
3341         * python/py-breakpoint.c: Use C++ exception handling.
3342         * python/py-arch.c: Use C++ exception handling.
3343         * printcmd.c: Use C++ exception handling.
3344         * ppc-linux-tdep.c: Use C++ exception handling.
3345         * parse.c: Use C++ exception handling.
3346         * p-valprint.c: Use C++ exception handling.
3347         * objc-lang.c: Use C++ exception handling.
3348         * mi/mi-main.c: Use C++ exception handling.
3349         * mi/mi-interp.c: Use C++ exception handling.
3350         * mi/mi-cmd-stack.c: Use C++ exception handling.
3351         * mi/mi-cmd-break.c: Use C++ exception handling.
3352         * main.c: Use C++ exception handling.
3353         * linux-thread-db.c: Use C++ exception handling.
3354         * linux-tdep.c: Use C++ exception handling.
3355         * linux-nat.c: Use C++ exception handling.
3356         * linux-fork.c: Use C++ exception handling.
3357         * linespec.c: Use C++ exception handling.
3358         * language.c: Use C++ exception handling.
3359         * jit.c: Use C++ exception handling.
3360         * infrun.c: Use C++ exception handling.
3361         * infcmd.c: Use C++ exception handling.
3362         * infcall.c: Use C++ exception handling.
3363         * inf-loop.c: Use C++ exception handling.
3364         * i386-tdep.c: Use C++ exception handling.
3365         * i386-linux-tdep.c: Use C++ exception handling.
3366         * guile/scm-value.c: Use C++ exception handling.
3367         * guile/scm-type.c: Use C++ exception handling.
3368         * guile/scm-symtab.c: Use C++ exception handling.
3369         * guile/scm-symbol.c: Use C++ exception handling.
3370         * guile/scm-pretty-print.c: Use C++ exception handling.
3371         * guile/scm-ports.c: Use C++ exception handling.
3372         * guile/scm-param.c: Use C++ exception handling.
3373         * guile/scm-math.c: Use C++ exception handling.
3374         * guile/scm-lazy-string.c: Use C++ exception handling.
3375         * guile/scm-frame.c: Use C++ exception handling.
3376         * guile/scm-disasm.c: Use C++ exception handling.
3377         * guile/scm-cmd.c: Use C++ exception handling.
3378         * guile/scm-breakpoint.c: Use C++ exception handling.
3379         * guile/scm-block.c: Use C++ exception handling.
3380         * guile/guile-internal.h: Use C++ exception handling.
3381         * gnu-v3-abi.c: Use C++ exception handling.
3382         * gdbtypes.c: Use C++ exception handling.
3383         * frame.c: Use C++ exception handling.
3384         * frame-unwind.c: Use C++ exception handling.
3385         * fbsd-tdep.c: Use C++ exception handling.
3386         * f-valprint.c: Use C++ exception handling.
3387         * exec.c: Use C++ exception handling.
3388         * event-top.c: Use C++ exception handling.
3389         * event-loop.c: Use C++ exception handling.
3390         * eval.c: Use C++ exception handling.
3391         * dwarf2read.c: Use C++ exception handling.
3392         * dwarf2loc.c: Use C++ exception handling.
3393         * dwarf2-frame.c: Use C++ exception handling.
3394         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3395         * dwarf-index-write.c: Use C++ exception handling.
3396         * dwarf-index-cache.c: Use C++ exception handling.
3397         * dtrace-probe.c: Use C++ exception handling.
3398         * disasm-selftests.c: Use C++ exception handling.
3399         * darwin-nat.c: Use C++ exception handling.
3400         * cp-valprint.c: Use C++ exception handling.
3401         * cp-support.c: Use C++ exception handling.
3402         * cp-abi.c: Use C++ exception handling.
3403         * corelow.c: Use C++ exception handling.
3404         * completer.c: Use C++ exception handling.
3405         * compile/compile-object-run.c: Use C++ exception handling.
3406         * compile/compile-object-load.c: Use C++ exception handling.
3407         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3408         * compile/compile-c-symbols.c: Use C++ exception handling.
3409         * common/selftest.c: Use C++ exception handling.
3410         * common/new-op.c: Use C++ exception handling.
3411         * cli/cli-script.c: Use C++ exception handling.
3412         * cli/cli-interp.c: Use C++ exception handling.
3413         * cli/cli-cmds.c: Use C++ exception handling.
3414         * c-varobj.c: Use C++ exception handling.
3415         * btrace.c: Use C++ exception handling.
3416         * breakpoint.c: Use C++ exception handling.
3417         * break-catch-throw.c: Use C++ exception handling.
3418         * arch-utils.c: Use C++ exception handling.
3419         * amd64-tdep.c: Use C++ exception handling.
3420         * ada-valprint.c: Use C++ exception handling.
3421         * ada-typeprint.c: Use C++ exception handling.
3422         * ada-lang.c: Use C++ exception handling.
3423         * aarch64-tdep.c: Use C++ exception handling.
3424
3425 2019-04-08  Tom Tromey  <tom@tromey.com>
3426
3427         * xml-support.c (gdb_xml_parser::parse): Update.
3428         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3429         * value.c (show_convenience): Update.
3430         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3431         (test_parse_flags_qcs): Update.
3432         * thread.c (thr_try_catch_cmd): Update.
3433         * target.c (target_translate_tls_address): Update.
3434         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3435         (info_frame_command_core, frame_apply_command_count): Update.
3436         * rust-exp.y (rust_lex_exception_test): Update.
3437         * riscv-tdep.c (riscv_print_one_register_info): Update.
3438         * remote.c (remote_target::enable_btrace): Update.
3439         * record-btrace.c (record_btrace_enable_warn): Update.
3440         * python/py-utils.c (gdbpy_convert_exception): Update.
3441         * printcmd.c (do_one_display, print_variable_and_value): Update.
3442         * mi/mi-main.c (mi_print_exception): Update.
3443         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3444         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3445         * linux-nat.c (linux_nat_target::attach): Update.
3446         * linux-fork.c (class scoped_switch_fork_info): Update.
3447         * infrun.c (displaced_step_prepare): Update.
3448         * infcall.c (call_function_by_hand_dummy): Update.
3449         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3450         * gnu-v3-abi.c (print_one_vtable): Update.
3451         * frame.c (get_prev_frame_always): Update.
3452         * f-valprint.c (info_common_command_for_block): Update.
3453         * exec.c (try_open_exec_file): Update.
3454         * exceptions.c (print_exception, exception_print)
3455         (exception_fprintf, exception_print_same): Update.
3456         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3457         * dwarf-index-cache.c (index_cache::store)
3458         (index_cache::lookup_gdb_index): Update.
3459         * darwin-nat.c (maybe_cache_shell): Update.
3460         * cp-valprint.c (cp_print_value_fields): Update.
3461         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3462         (gcc_cplus_symbol_address): Update.
3463         * compile/compile-c-symbols.c (gcc_convert_symbol)
3464         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3465         * common/selftest.c: Update.
3466         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3467         a std::string.
3468         (exception_try_scope_entry, exception_try_scope_exit): Don't
3469         declare.
3470         (struct exception_try_scope): Remove.
3471         (TRY): Don't use exception_try_scope.
3472         (struct gdb_exception): Add constructor, operator=.
3473         <what>: New method.
3474         (struct gdb_exception_RETURN_MASK_ALL)
3475         (struct gdb_exception_RETURN_MASK_ERROR)
3476         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3477         (struct gdb_quit_bad_alloc): Update.
3478         * common/common-exceptions.c (exception_none): Change
3479         initializer.
3480         (struct catcher) <state, exception>: Initialize inline.
3481         <prev>: Remove member.
3482         (current_catcher): Remove.
3483         (catchers): New global.
3484         (exceptions_state_mc_init): Simplify.
3485         (catcher_pop): Remove.
3486         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3487         (try_scope_depth, exception_try_scope_entry)
3488         (exception_try_scope_exit): Remove.
3489         (throw_exception_sjlj): Update.
3490         (exception_messages, exception_messages_size): Remove.
3491         (throw_it): Simplify.
3492         (gdb_exception_sliced_copy): Remove.
3493         (throw_exception_cxx): Update.
3494         * cli/cli-script.c (script_from_file): Update.
3495         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3496         Update.
3497         * ada-valprint.c (ada_val_print): Update.
3498         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3499         (create_excep_cond_exprs): Update.
3500
3501 2019-04-08  Tom Tromey  <tom@tromey.com>
3502
3503         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3504         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3505         (TRY, CATCH, END_CATCH): Remove some definitions.
3506         * common/common-exceptions.c: Don't use GDB_XCPT.
3507         (catcher_list_size): Remove.
3508         (throw_exception, throw_it): Simplify.
3509
3510 2019-04-05  Tom Tromey  <tom@tromey.com>
3511
3512         Revert the header-sorting patch.
3513         * ft32-tdep.c: Revert.
3514         * frv-tdep.c: Revert.
3515         * frv-linux-tdep.c: Revert.
3516         * frame.c: Revert.
3517         * frame-unwind.c: Revert.
3518         * frame-base.c: Revert.
3519         * fork-child.c: Revert.
3520         * findvar.c: Revert.
3521         * findcmd.c: Revert.
3522         * filesystem.c: Revert.
3523         * filename-seen-cache.h: Revert.
3524         * filename-seen-cache.c: Revert.
3525         * fbsd-tdep.c: Revert.
3526         * fbsd-nat.h: Revert.
3527         * fbsd-nat.c: Revert.
3528         * f-valprint.c: Revert.
3529         * f-typeprint.c: Revert.
3530         * f-lang.c: Revert.
3531         * extension.h: Revert.
3532         * extension.c: Revert.
3533         * extension-priv.h: Revert.
3534         * expprint.c: Revert.
3535         * exec.h: Revert.
3536         * exec.c: Revert.
3537         * exceptions.c: Revert.
3538         * event-top.c: Revert.
3539         * event-loop.c: Revert.
3540         * eval.c: Revert.
3541         * elfread.c: Revert.
3542         * dwarf2read.h: Revert.
3543         * dwarf2read.c: Revert.
3544         * dwarf2loc.c: Revert.
3545         * dwarf2expr.h: Revert.
3546         * dwarf2expr.c: Revert.
3547         * dwarf2-frame.c: Revert.
3548         * dwarf2-frame-tailcall.c: Revert.
3549         * dwarf-index-write.h: Revert.
3550         * dwarf-index-write.c: Revert.
3551         * dwarf-index-common.c: Revert.
3552         * dwarf-index-cache.h: Revert.
3553         * dwarf-index-cache.c: Revert.
3554         * dummy-frame.c: Revert.
3555         * dtrace-probe.c: Revert.
3556         * disasm.h: Revert.
3557         * disasm.c: Revert.
3558         * disasm-selftests.c: Revert.
3559         * dictionary.c: Revert.
3560         * dicos-tdep.c: Revert.
3561         * demangle.c: Revert.
3562         * dcache.h: Revert.
3563         * dcache.c: Revert.
3564         * darwin-nat.h: Revert.
3565         * darwin-nat.c: Revert.
3566         * darwin-nat-info.c: Revert.
3567         * d-valprint.c: Revert.
3568         * d-namespace.c: Revert.
3569         * d-lang.c: Revert.
3570         * ctf.c: Revert.
3571         * csky-tdep.c: Revert.
3572         * csky-linux-tdep.c: Revert.
3573         * cris-tdep.c: Revert.
3574         * cris-linux-tdep.c: Revert.
3575         * cp-valprint.c: Revert.
3576         * cp-support.c: Revert.
3577         * cp-namespace.c: Revert.
3578         * cp-abi.c: Revert.
3579         * corelow.c: Revert.
3580         * corefile.c: Revert.
3581         * continuations.c: Revert.
3582         * completer.h: Revert.
3583         * completer.c: Revert.
3584         * complaints.c: Revert.
3585         * coffread.c: Revert.
3586         * coff-pe-read.c: Revert.
3587         * cli-out.h: Revert.
3588         * cli-out.c: Revert.
3589         * charset.c: Revert.
3590         * c-varobj.c: Revert.
3591         * c-valprint.c: Revert.
3592         * c-typeprint.c: Revert.
3593         * c-lang.c: Revert.
3594         * buildsym.c: Revert.
3595         * buildsym-legacy.c: Revert.
3596         * build-id.h: Revert.
3597         * build-id.c: Revert.
3598         * btrace.c: Revert.
3599         * bsd-uthread.c: Revert.
3600         * breakpoint.h: Revert.
3601         * breakpoint.c: Revert.
3602         * break-catch-throw.c: Revert.
3603         * break-catch-syscall.c: Revert.
3604         * break-catch-sig.c: Revert.
3605         * blockframe.c: Revert.
3606         * block.c: Revert.
3607         * bfin-tdep.c: Revert.
3608         * bfin-linux-tdep.c: Revert.
3609         * bfd-target.c: Revert.
3610         * bcache.c: Revert.
3611         * ax-general.c: Revert.
3612         * ax-gdb.h: Revert.
3613         * ax-gdb.c: Revert.
3614         * avr-tdep.c: Revert.
3615         * auxv.c: Revert.
3616         * auto-load.c: Revert.
3617         * arm-wince-tdep.c: Revert.
3618         * arm-tdep.c: Revert.
3619         * arm-symbian-tdep.c: Revert.
3620         * arm-pikeos-tdep.c: Revert.
3621         * arm-obsd-tdep.c: Revert.
3622         * arm-nbsd-tdep.c: Revert.
3623         * arm-nbsd-nat.c: Revert.
3624         * arm-linux-tdep.c: Revert.
3625         * arm-linux-nat.c: Revert.
3626         * arm-fbsd-tdep.c: Revert.
3627         * arm-fbsd-nat.c: Revert.
3628         * arm-bsd-tdep.c: Revert.
3629         * arch-utils.c: Revert.
3630         * arc-tdep.c: Revert.
3631         * arc-newlib-tdep.c: Revert.
3632         * annotate.h: Revert.
3633         * annotate.c: Revert.
3634         * amd64-windows-tdep.c: Revert.
3635         * amd64-windows-nat.c: Revert.
3636         * amd64-tdep.c: Revert.
3637         * amd64-sol2-tdep.c: Revert.
3638         * amd64-obsd-tdep.c: Revert.
3639         * amd64-obsd-nat.c: Revert.
3640         * amd64-nbsd-tdep.c: Revert.
3641         * amd64-nbsd-nat.c: Revert.
3642         * amd64-nat.c: Revert.
3643         * amd64-linux-tdep.c: Revert.
3644         * amd64-linux-nat.c: Revert.
3645         * amd64-fbsd-tdep.c: Revert.
3646         * amd64-fbsd-nat.c: Revert.
3647         * amd64-dicos-tdep.c: Revert.
3648         * amd64-darwin-tdep.c: Revert.
3649         * amd64-bsd-nat.c: Revert.
3650         * alpha-tdep.c: Revert.
3651         * alpha-obsd-tdep.c: Revert.
3652         * alpha-nbsd-tdep.c: Revert.
3653         * alpha-mdebug-tdep.c: Revert.
3654         * alpha-linux-tdep.c: Revert.
3655         * alpha-linux-nat.c: Revert.
3656         * alpha-bsd-tdep.c: Revert.
3657         * alpha-bsd-nat.c: Revert.
3658         * aix-thread.c: Revert.
3659         * agent.c: Revert.
3660         * addrmap.c: Revert.
3661         * ada-varobj.c: Revert.
3662         * ada-valprint.c: Revert.
3663         * ada-typeprint.c: Revert.
3664         * ada-tasks.c: Revert.
3665         * ada-lang.c: Revert.
3666         * aarch64-tdep.c: Revert.
3667         * aarch64-ravenscar-thread.c: Revert.
3668         * aarch64-newlib-tdep.c: Revert.
3669         * aarch64-linux-tdep.c: Revert.
3670         * aarch64-linux-nat.c: Revert.
3671         * aarch64-fbsd-tdep.c: Revert.
3672         * aarch64-fbsd-nat.c: Revert.
3673         * aarch32-linux-nat.c: Revert.
3674
3675 2019-04-05  Tom Tromey  <tom@tromey.com>
3676
3677         * ft32-tdep.c: Sort headers.
3678         * frv-tdep.c: Sort headers.
3679         * frv-linux-tdep.c: Sort headers.
3680         * frame.c: Sort headers.
3681         * frame-unwind.c: Sort headers.
3682         * frame-base.c: Sort headers.
3683         * fork-child.c: Sort headers.
3684         * findvar.c: Sort headers.
3685         * findcmd.c: Sort headers.
3686         * filesystem.c: Sort headers.
3687         * filename-seen-cache.h: Sort headers.
3688         * filename-seen-cache.c: Sort headers.
3689         * fbsd-tdep.c: Sort headers.
3690         * fbsd-nat.h: Sort headers.
3691         * fbsd-nat.c: Sort headers.
3692         * f-valprint.c: Sort headers.
3693         * f-typeprint.c: Sort headers.
3694         * f-lang.c: Sort headers.
3695         * extension.h: Sort headers.
3696         * extension.c: Sort headers.
3697         * extension-priv.h: Sort headers.
3698         * expprint.c: Sort headers.
3699         * exec.h: Sort headers.
3700         * exec.c: Sort headers.
3701         * exceptions.c: Sort headers.
3702         * event-top.c: Sort headers.
3703         * event-loop.c: Sort headers.
3704         * eval.c: Sort headers.
3705         * elfread.c: Sort headers.
3706         * dwarf2read.h: Sort headers.
3707         * dwarf2read.c: Sort headers.
3708         * dwarf2loc.c: Sort headers.
3709         * dwarf2expr.h: Sort headers.
3710         * dwarf2expr.c: Sort headers.
3711         * dwarf2-frame.c: Sort headers.
3712         * dwarf2-frame-tailcall.c: Sort headers.
3713         * dwarf-index-write.h: Sort headers.
3714         * dwarf-index-write.c: Sort headers.
3715         * dwarf-index-common.c: Sort headers.
3716         * dwarf-index-cache.h: Sort headers.
3717         * dwarf-index-cache.c: Sort headers.
3718         * dummy-frame.c: Sort headers.
3719         * dtrace-probe.c: Sort headers.
3720         * disasm.h: Sort headers.
3721         * disasm.c: Sort headers.
3722         * disasm-selftests.c: Sort headers.
3723         * dictionary.c: Sort headers.
3724         * dicos-tdep.c: Sort headers.
3725         * demangle.c: Sort headers.
3726         * dcache.h: Sort headers.
3727         * dcache.c: Sort headers.
3728         * darwin-nat.h: Sort headers.
3729         * darwin-nat.c: Sort headers.
3730         * darwin-nat-info.c: Sort headers.
3731         * d-valprint.c: Sort headers.
3732         * d-namespace.c: Sort headers.
3733         * d-lang.c: Sort headers.
3734         * ctf.c: Sort headers.
3735         * csky-tdep.c: Sort headers.
3736         * csky-linux-tdep.c: Sort headers.
3737         * cris-tdep.c: Sort headers.
3738         * cris-linux-tdep.c: Sort headers.
3739         * cp-valprint.c: Sort headers.
3740         * cp-support.c: Sort headers.
3741         * cp-namespace.c: Sort headers.
3742         * cp-abi.c: Sort headers.
3743         * corelow.c: Sort headers.
3744         * corefile.c: Sort headers.
3745         * continuations.c: Sort headers.
3746         * completer.h: Sort headers.
3747         * completer.c: Sort headers.
3748         * complaints.c: Sort headers.
3749         * coffread.c: Sort headers.
3750         * coff-pe-read.c: Sort headers.
3751         * cli-out.h: Sort headers.
3752         * cli-out.c: Sort headers.
3753         * charset.c: Sort headers.
3754         * c-varobj.c: Sort headers.
3755         * c-valprint.c: Sort headers.
3756         * c-typeprint.c: Sort headers.
3757         * c-lang.c: Sort headers.
3758         * buildsym.c: Sort headers.
3759         * buildsym-legacy.c: Sort headers.
3760         * build-id.h: Sort headers.
3761         * build-id.c: Sort headers.
3762         * btrace.c: Sort headers.
3763         * bsd-uthread.c: Sort headers.
3764         * breakpoint.h: Sort headers.
3765         * breakpoint.c: Sort headers.
3766         * break-catch-throw.c: Sort headers.
3767         * break-catch-syscall.c: Sort headers.
3768         * break-catch-sig.c: Sort headers.
3769         * blockframe.c: Sort headers.
3770         * block.c: Sort headers.
3771         * bfin-tdep.c: Sort headers.
3772         * bfin-linux-tdep.c: Sort headers.
3773         * bfd-target.c: Sort headers.
3774         * bcache.c: Sort headers.
3775         * ax-general.c: Sort headers.
3776         * ax-gdb.h: Sort headers.
3777         * ax-gdb.c: Sort headers.
3778         * avr-tdep.c: Sort headers.
3779         * auxv.c: Sort headers.
3780         * auto-load.c: Sort headers.
3781         * arm-wince-tdep.c: Sort headers.
3782         * arm-tdep.c: Sort headers.
3783         * arm-symbian-tdep.c: Sort headers.
3784         * arm-pikeos-tdep.c: Sort headers.
3785         * arm-obsd-tdep.c: Sort headers.
3786         * arm-nbsd-tdep.c: Sort headers.
3787         * arm-nbsd-nat.c: Sort headers.
3788         * arm-linux-tdep.c: Sort headers.
3789         * arm-linux-nat.c: Sort headers.
3790         * arm-fbsd-tdep.c: Sort headers.
3791         * arm-fbsd-nat.c: Sort headers.
3792         * arm-bsd-tdep.c: Sort headers.
3793         * arch-utils.c: Sort headers.
3794         * arc-tdep.c: Sort headers.
3795         * arc-newlib-tdep.c: Sort headers.
3796         * annotate.h: Sort headers.
3797         * annotate.c: Sort headers.
3798         * amd64-windows-tdep.c: Sort headers.
3799         * amd64-windows-nat.c: Sort headers.
3800         * amd64-tdep.c: Sort headers.
3801         * amd64-sol2-tdep.c: Sort headers.
3802         * amd64-obsd-tdep.c: Sort headers.
3803         * amd64-obsd-nat.c: Sort headers.
3804         * amd64-nbsd-tdep.c: Sort headers.
3805         * amd64-nbsd-nat.c: Sort headers.
3806         * amd64-nat.c: Sort headers.
3807         * amd64-linux-tdep.c: Sort headers.
3808         * amd64-linux-nat.c: Sort headers.
3809         * amd64-fbsd-tdep.c: Sort headers.
3810         * amd64-fbsd-nat.c: Sort headers.
3811         * amd64-dicos-tdep.c: Sort headers.
3812         * amd64-darwin-tdep.c: Sort headers.
3813         * amd64-bsd-nat.c: Sort headers.
3814         * alpha-tdep.c: Sort headers.
3815         * alpha-obsd-tdep.c: Sort headers.
3816         * alpha-nbsd-tdep.c: Sort headers.
3817         * alpha-mdebug-tdep.c: Sort headers.
3818         * alpha-linux-tdep.c: Sort headers.
3819         * alpha-linux-nat.c: Sort headers.
3820         * alpha-bsd-tdep.c: Sort headers.
3821         * alpha-bsd-nat.c: Sort headers.
3822         * aix-thread.c: Sort headers.
3823         * agent.c: Sort headers.
3824         * addrmap.c: Sort headers.
3825         * ada-varobj.c: Sort headers.
3826         * ada-valprint.c: Sort headers.
3827         * ada-typeprint.c: Sort headers.
3828         * ada-tasks.c: Sort headers.
3829         * ada-lang.c: Sort headers.
3830         * aarch64-tdep.c: Sort headers.
3831         * aarch64-ravenscar-thread.c: Sort headers.
3832         * aarch64-newlib-tdep.c: Sort headers.
3833         * aarch64-linux-tdep.c: Sort headers.
3834         * aarch64-linux-nat.c: Sort headers.
3835         * aarch64-fbsd-tdep.c: Sort headers.
3836         * aarch64-fbsd-nat.c: Sort headers.
3837         * aarch32-linux-nat.c: Sort headers.
3838
3839 2019-04-04  Tom Tromey  <tom@tromey.com>
3840
3841         * varobj.c (varobj_create): Update.
3842         * rust-exp.y (struct rust_parser) <update_innermost_block,
3843         lookup_symbol>: New methods.
3844         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3845         Rename.
3846         (rust_parser::rust_lookup_type)
3847         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3848         * printcmd.c (display_command, do_one_display): Update.
3849         * parser-defs.h (struct parser_state) <parser_state>: Add
3850         "tracker" parameter.
3851         (block_tracker): New member.
3852         (class innermost_block_tracker) <innermost_block_tracker>: Add
3853         "types" parameter.
3854         <reset>: Remove method.
3855         (innermost_block): Don't declare.
3856         (null_post_parser): Update.
3857         * parse.c (innermost_block): Remove global.
3858         (write_dollar_variable): Update.
3859         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3860         Remove "tracker_types" parameter.
3861         (parse_expression): Add "tracker" parameter.
3862         (parse_expression_for_completion): Update.
3863         (null_post_parser): Add "tracker" parameter.
3864         * p-exp.y: Update rules.
3865         * m2-exp.y: Update rules.
3866         * language.h (struct language_defn) <la_post_parser>: Add
3867         "tracker" parameter.
3868         * go-exp.y: Update rules.
3869         * f-exp.y: Update rules.
3870         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3871         parameter.
3872         * d-exp.y: Update rules.
3873         * c-exp.y: Update rules.
3874         * breakpoint.c (set_breakpoint_condition): Create an
3875         innermost_block_tracker.
3876         (watch_command_1): Likewise.
3877         * ada-lang.c (resolve): Add "tracker" parameter.
3878         (resolve_subexp): Likewise.
3879         * ada-exp.y (write_var_from_sym): Update.
3880
3881 2019-04-04  Tom Tromey  <tom@tromey.com>
3882
3883         * type-stack.h: New file.
3884         * type-stack.c: New file.
3885         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3886         type-stack.h.
3887         (insert_into_type_stack, insert_type, push_type, push_type_int)
3888         (insert_type_address_space, pop_type, pop_type_int)
3889         (pop_typelist, pop_type_stack, append_type_stack)
3890         (push_type_stack, get_type_stack, push_typelist)
3891         (follow_type_instance_flags, follow_types): Don't declare.
3892         * parse.c (type_stack): Remove global.
3893         (parse_exp_in_context): Update.
3894         (insert_into_type_stack, insert_type, push_type, push_type_int)
3895         (insert_type_address_space, pop_type, pop_type_int)
3896         (pop_typelist, pop_type_stack, append_type_stack)
3897         (push_type_stack, get_type_stack, push_typelist)
3898         (follow_type_instance_flags, follow_types): Remove (moved to
3899         type-stack.c).
3900         * f-exp.y (type_stack): New global.
3901         Update rules.
3902         (push_kind_type, f_parse): Update.
3903         * d-exp.y (type_stack): New global.
3904         Update rules.
3905         (d_parse): Update.
3906         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3907         Update rules.
3908         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3909         (HFILES_NO_SRCDIR): Add type-stack.h.
3910
3911 2019-04-04  Tom Tromey  <tom@tromey.com>
3912
3913         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3914         (rust_parser::convert_ast_to_expression, rust_parse)
3915         (rust_lex_test_completion, rust_lex_tests): Update.
3916         * parser-defs.h (struct expr_completion_state): New.
3917         (struct parser_state) <parser_state>: Add completion parameter.
3918         <mark_struct_expression, mark_completion_tag>: New methods.
3919         <parse_completion, m_completion_state>: New members.
3920         (prefixify_expression, null_post_parser): Update.
3921         (mark_struct_expression, mark_completion_tag): Don't declare.
3922         * parse.c (parse_completion, expout_last_struct)
3923         (expout_tag_completion_type, expout_completion_name): Remove
3924         globals.
3925         (parser_state::mark_struct_expression)
3926         (parser_state::mark_completion_tag): Now methods.
3927         (prefixify_expression): Add last_struct parameter.
3928         (prefixify_subexp): Likewise.
3929         (parse_exp_1): Update.
3930         (parse_exp_in_context): Add cstate parameter.  Update.
3931         (parse_expression_for_completion): Create an
3932         expr_completion_state.
3933         (null_post_parser): Add "completion" parameter.
3934         * p-exp.y: Update rules.
3935         (yylex): Update.
3936         * language.h (struct language_defn) <la_post_parser>: Add
3937         "completing" parameter.
3938         * go-exp.y: Update rules.
3939         (lex_one_token): Update.
3940         * expression.h (parse_completion): Don't declare.
3941         * d-exp.y: Update rules.
3942         (lex_one_token): Update rules.
3943         * c-exp.y: Update rules.
3944         (lex_one_token): Update.
3945         * ada-lang.c (resolve): Add "parse_completion" parameter.
3946         (resolve_subexp): Likewise.
3947         (ada_resolve_function): Likewise.
3948
3949 2019-04-04  Tom Tromey  <tom@tromey.com>
3950
3951         * parser-defs.h (struct parser_state) <start_arglist,
3952         end_arglist>: New methods.
3953         <arglist_len, m_funcall_chain>: New members.
3954         (arglist_len, start_arglist, end_arglist): Don't declare.
3955         * parse.c (arglist_len, funcall_chain): Remove global.
3956         (start_arglist, end_arglist): Remove functions.
3957         (parse_exp_in_context): Update.
3958         * p-exp.y: Update rules.
3959         * m2-exp.y: Update rules.
3960         * go-exp.y: Update rules.
3961         * f-exp.y: Update rules.
3962         * d-exp.y: Update rules.
3963         * c-exp.y: Update rules.
3964
3965 2019-04-04  Tom Tromey  <tom@tromey.com>
3966
3967         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3968         lex_operator, push_back>: New methods.
3969         Update all rules.
3970         (rust_parser::lex_hex, lex_escape): Rename and update.
3971         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3972         (rust_parser::lex_operator): Rename and update.
3973         (rust_parser::lex_number, rustyylex, rustyyerror)
3974         (rust_lex_test_init, rust_lex_test_sequence)
3975         (rust_lex_test_push_back, rust_lex_tests): Update.
3976         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3977         parameter.
3978         <lexptr, prev_lexptr>: New members.
3979         (lexptr, prev_lexptr): Don't declare.
3980         * parse.c (lexptr, prev_lexptr): Remove globals.
3981         (parse_exp_in_context): Update.
3982         * p-exp.y (yylex, yyerror): Update.
3983         * m2-exp.y (parse_number, yylex, yyerror): Update.
3984         * go-exp.y (lex_one_token, yyerror): Update.
3985         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3986         * d-exp.y (lex_one_token, yyerror): Update.
3987         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3988         (lex_one_token, yyerror): Update.
3989         * ada-lex.l (YY_INPUT): Update.
3990         (rewind_to_char): Update.
3991         * ada-exp.y (yyerror): Update.
3992
3993 2019-04-04  Tom Tromey  <tom@tromey.com>
3994
3995         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3996         * parser-defs.h (struct parser_state) <parser_state>: Add new
3997         parameter.
3998         <comma_terminates>: New member.
3999         (comma_terminates): Don't declare global.
4000         * parse.c (comma_terminates): Remove global.
4001         (parse_exp_in_context): Update.
4002         * p-exp.y (yylex): Update.
4003         * m2-exp.y (yylex): Update.
4004         * go-exp.y (lex_one_token): Update.
4005         * f-exp.y (yylex): Update.
4006         * d-exp.y (lex_one_token): Update.
4007         * c-exp.y (lex_one_token): Update.
4008         * ada-lex.l: Update.
4009
4010 2019-04-04  Tom Tromey  <tom@tromey.com>
4011
4012         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4013         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4014         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4015         * parser-defs.h (paren_depth): Don't declare.
4016         * parse.c (paren_depth): Remove global.
4017         (parse_exp_in_context): Update.
4018         * p-exp.y (paren_depth): New global.
4019         (pascal_parse): Initialize it.
4020         * m2-exp.y (paren_depth): New global.
4021         (m2_parse): Initialize it.
4022         * go-exp.y (paren_depth): New global.
4023         (go_parse): Initialize it.
4024         * f-exp.y (paren_depth): New global.
4025         (f_parse): Initialize it.
4026         * d-exp.y (paren_depth): New global.
4027         (d_parse): Initialize it.
4028         * c-exp.y (paren_depth): New global.
4029         (c_parse): Initialize it.
4030         * ada-lex.l (paren_depth): New global.
4031         (lexer_init): Initialize it.
4032
4033 2019-04-04  Tom Tromey  <tom@tromey.com>
4034
4035         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4036         (rust_parser::convert_ast_to_type)
4037         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4038         * parser-defs.h (struct parser_state) <parser_state>: Add
4039         parameters.  Initialize new members.
4040         <expression_context_block, expression_context_pc>: New members.
4041         * parse.c (expression_context_block, expression_context_pc):
4042         Remove globals.
4043         (parse_exp_in_context): Update.
4044         * p-exp.y: Update all rules.
4045         (yylex): Update.
4046         * m2-exp.y: Update all rules.
4047         (yylex): Update.
4048         * go-exp.y (yylex): Update.
4049         * f-exp.y (yylex): Update.
4050         * d-exp.y: Update all rules.
4051         (yylex): Update.
4052         * c-exp.y: Update all rules.
4053         (lex_one_token, classify_name, yylex, c_parse): Update.
4054         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4055
4056 2019-04-04  Tom Tromey  <tom@tromey.com>
4057
4058         * gdbarch.h, gdbarch.c: Rebuild.
4059         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4060         * stap-probe.h:
4061         (struct stap_parse_info): Replace "parser_state" with
4062         "expr_builder".
4063         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4064         (parser_state): New class.
4065         * parse.c (expr_builder): Rename.
4066         (expr_builder::release): Rename.
4067         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4068         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4069         (write_exp_elt_longcst, write_exp_elt_floatcst)
4070         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4071         (write_exp_string_vector, write_exp_bitstring)
4072         (write_exp_msymbol, mark_struct_expression)
4073         (write_dollar_variable)
4074         (insert_type_address_space, increase_expout_size): Replace
4075         "parser_state" with "expr_builder".
4076         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4077         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4078         "parser_state" with "expr_builder".
4079
4080 2019-04-04  Tom Tromey  <tom@tromey.com>
4081
4082         * rust-exp.y: Replace "parse_language" with method call.
4083         * p-exp.y:
4084         (yylex): Replace "parse_language" with method call.
4085         * m2-exp.y:
4086         (yylex): Replace "parse_language" with method call.
4087         * go-exp.y (classify_name): Replace "parse_language" with method
4088         call.
4089         * f-exp.y (yylex): Replace "parse_language" with method call.
4090         * d-exp.y (lex_one_token): Replace "parse_language" with method
4091         call.
4092         * c-exp.y:
4093         (lex_one_token, classify_name, yylex): Replace "parse_language"
4094         with method call.
4095         * ada-exp.y (find_primitive_type, type_char)
4096         (type_system_address): Replace "parse_language" with method call.
4097
4098 2019-04-04  Tom Tromey  <tom@tromey.com>
4099
4100         * rust-exp.y: Replace "parse_gdbarch" with method call.
4101         * parse.c (write_dollar_variable, insert_type_address_space):
4102         Replace "parse_gdbarch" with method call.
4103         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4104         call.
4105         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4106         call.
4107         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4108         "parse_gdbarch" with method call.
4109         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4110         with method call.
4111         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4112         "parse_gdbarch" with method call.
4113         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4114         "parse_gdbarch" with method call.
4115         * c-exp.y (parse_type, parse_number, classify_name): Replace
4116         "parse_gdbarch" with method call.
4117         * ada-lex.l: Replace "parse_gdbarch" with method call.
4118         * ada-exp.y (parse_type, find_primitive_type, type_char)
4119         (type_system_address): Replace "parse_gdbarch" with method call.
4120
4121 2019-04-04  Tom Tromey  <tom@tromey.com>
4122
4123         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4124         * stap-probe.c (stap_parse_argument): Update.
4125         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4126         initial_size parameter.
4127         * rust-exp.y (rust_lex_tests): Update.
4128         * parse.c (parser_state): Update.
4129         (parse_exp_in_context): Update.
4130         * parser-defs.h (struct parser_state) <parser_state>: Remove
4131         "initial_size" parameter.
4132
4133 2019-04-04  Tom Tromey  <tom@tromey.com>
4134
4135         * parser-defs.h (increase_expout_size): Don't declare.
4136         * parse.c (increase_expout_size): Now static.
4137
4138 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4139
4140         * gnu-nat.c (gnu_nat_target::wait): Fix
4141         target_waitstatus_to_string call.
4142
4143 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4144
4145         * eval.c (evaluate_subexp_standard): Handle internal functions
4146         during Fortran function call handling.
4147
4148 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4149
4150         * NEWS: Mention new internal functions.
4151         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4152         (read_base_type): Use dwarf2_init_complex_target_type.
4153         * value.c (creal_internal_fn): New function.
4154         (cimag_internal_fn): New function.
4155         (_initialize_values): Register new internal functions.
4156
4157 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4158
4159         * infrun.c (stop_all_threads): If debug_infrun, always
4160         trace the wait status after wait_one, using
4161         target_waitstatus_to_string and target_pid_to_str.
4162         (handle_inferior_event): Replace various trace of
4163         wait status kind by a single trace.
4164         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4165         wait status kind image by target_waitstatus_to_string.
4166         * target/waitstatus.c (target_waitstatus_to_string): Fix
4167         obsolete comment.
4168
4169 2019-04-01  Tom Tromey  <tromey@adacore.com>
4170
4171         PR symtab/23331:
4172         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4173
4174 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4175             Pedro Alves  <palves@redhat.com>
4176
4177         * top.c (quit_force): Call 'finalize_values'.
4178         * value.c (finalize_values): New function.
4179         * value.h (finalize_values): Declare.
4180
4181 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4182
4183         * NEWS: Announce $_gdb_major and $_gdb_minor.
4184
4185         * top.c (init_gdb_version_vars): New function.
4186         (gdb_init): Call init_gdb_version_vars.
4187
4188 2019-03-29  Tom Tromey  <tromey@adacore.com>
4189
4190         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4191         help text.  Remove dead code.
4192
4193 2019-03-29  Keith Seitz  <keiths@redhat.com>
4194
4195         From Siddhesh Poyarekar:
4196         * f-lang.h (f77_get_upperbound): Return LONGEST.
4197         (f77_get_lowerbound): Likewise.
4198         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4199         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4200         print them.
4201         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4202         plongest to format print it.
4203         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4204         (f77_get_upperbound): Likewise.
4205         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4206         LOWER_BOUND to LONGEST.
4207         (f77_create_arrayprint_offset_tbl): Likewise.
4208
4209 2019-03-29  Keith Seitz  <keiths@redhat.com>
4210
4211         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4212         %s/pulongest for TYPE_LENGTH instead of %d in format
4213         strings.
4214         * ada-typerint.c (ada_print_type): Likewise.
4215         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4216         * compile/compile-c-support.c (generate_register_struct): Likewise.
4217         * gdbtypes.c (recursive_dump_type): Likewise.
4218         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4219         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4220         instead of %d in format strings.
4221         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4222         to std::min to ULONGEST.
4223         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4224         instead of %d in format strings.
4225         * tracepoint.c (info_scope_command): Likewise.
4226         * typeprint.c (print_offset_data::update)
4227         (print_offset_data::finish): Likewise.
4228         * xtensa-tdep.c (xtensa_store_return_value)
4229         (xtensa_push_dummy_call): Likewise.
4230
4231 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4232
4233         * windows-nat.c (display_selector): Fixed format specifications
4234         for 64-bit Cygwin.
4235
4236 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4237
4238         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4239
4240 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4241
4242         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4243         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4244         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4245         (nios2_linux_init_abi): Install it.
4246
4247 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4248
4249         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4250
4251 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4252
4253         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4254
4255 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4256             Tom Tromey  <tromey@adacore.com>
4257
4258         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4259
4260 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4261
4262         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4263         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4264         method to compute the bounds of range types. Also print "[evaluated]"
4265         if the bounds' values come from a dynamic evaluation.
4266
4267 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4268
4269         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4270         whitespace when pretty printing is on.
4271
4272 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4273
4274         * ppc-linux-nat.c: Add include.
4275
4276 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4277
4278         * NEWS: Mention AArch64 Pointer Authentication.
4279
4280 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4281
4282         * arm-linux-nat.c: Add include.
4283
4284 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4285
4286         * source-cache.c (source_cache::get_source_lines): Re-read
4287         fullname after calling open_source_file.
4288
4289 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4290
4291         * NEWS: Mention TLS support for FreeBSD.
4292
4293 2019-03-25  Tom Tromey  <tromey@adacore.com>
4294
4295         * minsyms.c (BUNCH_SIZE): Update comment.
4296         (~minimal_symbol_reader): Remove old comment.
4297         (compact_minimal_symbols): Update comment.
4298         (minimal_symbol_reader::install): Remove old comment.  Update
4299         other comments.
4300
4301 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4302
4303         * s390-linux-nat.c: Add include.
4304
4305 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4306
4307         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4308         Call linux_get_hwcap.
4309         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4310         Likewise.
4311         (aarch64_linux_get_hwcap): Remove function.
4312         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4313         declaration.
4314         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4315         linux_get_hwcap.
4316         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4317         * linux-tdep.c (linux_get_hwcap): Add function.
4318         (linux_get_hwcap2): Likewise.
4319         * linux-tdep.h (linux_get_hwcap): Add declaration.
4320         (linux_get_hwcap2): Likewise.
4321         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4322         (ppc_linux_get_hwcap2): Likewise.
4323         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4324         linux_get_hwcap.
4325         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4326         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4327         (ppc_linux_nat_target::read_description): Likewise.
4328         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4329         * s390-linux-nat.c: Likewise.
4330         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4331
4332 2019-03-24  Tom Tromey  <tom@tromey.com>
4333
4334         * ada-lang.c (standard_lookup): Simplify initialization.
4335         (ada_lookup_symbol_nonlocal): Simplify return.
4336         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4337         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4338         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4339         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4340         initialization.
4341         * solib.c (solib_global_lookup): Simplify.
4342         * symtab.c (null_block_symbol): Remove.
4343         (symbol_cache_lookup): Simplify returns.
4344         (lookup_language_this): Simplify returns.
4345         (lookup_symbol_aux): Simplify return.
4346         (lookup_local_symbol): Simplify returns.
4347         (lookup_global_symbol_from_objfile): Simplify return.
4348         (lookup_symbol_in_objfile_symtabs)
4349         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4350         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4351         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4352         * cp-namespace.c (cp_lookup_bare_symbol)
4353         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4354         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4355         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4356         (cp_lookup_symbol_via_imports): Simplify initialization.
4357         (find_symbol_in_baseclass): Likewise.
4358         * symtab.h (null_block_symbol): Remove.
4359         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4360         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4361         (d_lookup_symbol_module): Likewise.
4362         (find_symbol_in_baseclass): Simplify initialization.
4363
4364 2019-03-24  Tom Tromey  <tom@tromey.com>
4365
4366         * expression.h: Don't include symtab.h.
4367         (struct block): Forward declare.
4368
4369 2019-03-24  Tom Tromey  <tom@tromey.com>
4370
4371         * c-exp.y (typebase): Remove casts.
4372         * gdbtypes.c (lookup_unsigned_typename, )
4373         (lookup_signed_typename): Remove cast.
4374         * eval.c (parse_to_comma_and_eval): Remove cast.
4375         * parse.c (write_dollar_variable): Remove cast.
4376         * block.h (struct block) <superblock>: Now const.
4377         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4378         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4379         (map_block): Make "block" const.
4380         * symfile.h (struct quick_symbol_functions)
4381         <map_matching_symbols>: Constify block argument to "callback".
4382         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4383         const.
4384         (find_pc_sect_compunit_symtab): Make "b" const.
4385         (find_symbol_at_address): Likewise.
4386         (search_symbols): Likewise.
4387         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4388         (dw2_debug_names_lookup_symbol): Likewise.
4389         (dw2_map_matching_symbols): Update.
4390         * p-valprint.c (pascal_val_print): Remove "block".
4391         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4392         (aux_add_nonlocal_symbols): Make "block" const.
4393         (resolve_subexp): Remove cast.
4394         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4395         const.
4396         (iterate_over_file_blocks): Likewise.
4397         * f-exp.y (%union) <bval>: Remove.
4398         * coffread.c (patch_opaque_types): Make "b" const.
4399         * spu-tdep.c (spu_catch_start): Make "block" const.
4400         * c-valprint.c (print_unpacked_pointer): Remove "block".
4401         * symmisc.c (dump_symtab_1): Make "b" const.
4402         (block_depth): Make "block" const.
4403         * d-exp.y (%union) <bval>: Remove.
4404         * cp-support.h (cp_lookup_rtti_type): Update.
4405         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4406         * psymtab.c (psym_lookup_symbol): Make "block" const.
4407         (maintenance_check_psymtabs): Make "b" const.
4408         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4409         (enumerate_locals, enumerate_args): Update.
4410         * python/py-symtab.c (stpy_global_block): Make "block" const.
4411         (stpy_static_block): Likewise.
4412         * inline-frame.c (block_starting_point_at): Make "new_block"
4413         const.
4414         * block.c (find_block_in_blockvector): Make return type const.
4415         (blockvector_for_pc_sect): Make "b" const.
4416         (find_block_in_blockvector): Make "b" const.
4417
4418 2019-03-23  Tom Tromey  <tom@tromey.com>
4419
4420         * varobj.c (varobj_create): Update.
4421         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4422         * printcmd.c (display_command, do_one_display): Don't reset
4423         innermost_block.
4424         * parser-defs.h (enum innermost_block_tracker_type): Move to
4425         expression.h.
4426         (innermost_block): Update comment.
4427         * parse.c (parse_exp_1): Add tracker_types parameter.
4428         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4429         tracker_types parameter.  Reset innermost_block.
4430         (parse_exp_in_context): Remove.
4431         (parse_expression_for_completion): Update.
4432         * objfiles.c (~objfile): Don't reset expression_context_block or
4433         innermost_block.
4434         * expression.h (enum innermost_block_tracker_type): Move from
4435         parser-defs.h.
4436         (parse_exp_1): Add tracker_types parameter.
4437         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4438         reset innermost_block.
4439
4440 2019-03-23  Tom Tromey  <tom@tromey.com>
4441
4442         * objfiles.h: Include bcache.h.
4443
4444 2019-03-23  Tom Tromey  <tom@tromey.com>
4445
4446         * linespec.c (get_current_search_block): Use
4447         scoped_restore_current_language.
4448         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4449
4450 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4451             Jiong Wang  <jiong.wang@arm.com>
4452
4453         * aarch64-linux-tdep.c
4454         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4455         section.
4456         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4457
4458 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4459             Jiong Wang  <jiong.wang@arm.com>
4460
4461         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4462         instructions.
4463         (aarch64_analyze_prologue_test): Add PACIASP test.
4464         (aarch64_prologue_prev_register): Unmask PC value.
4465
4466 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4467             Jiong Wang  <jiong.wang@arm.com>
4468
4469         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4470         (aarch64_dwarf2_prev_register): Unmask PC value.
4471         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4472         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4473         DW_CFA_AARCH64_negate_ra_state.
4474         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4475
4476 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4477             Jiong Wang  <jiong.wang@arm.com>
4478
4479         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4480         registers.
4481         (aarch64_pseudo_register_name): Likewise.
4482         (aarch64_pseudo_register_type): Likewise.
4483         (aarch64_pseudo_register_reggroup_p): Likewise.
4484         (aarch64_gdbarch_init): Add pauth registers.
4485         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4486         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4487         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4488         (struct gdbarch_tdep): Add regnum for ra_state.
4489
4490 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4491             Jiong Wang  <jiong.wang@arm.com>
4492
4493         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4494
4495 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4496             Jiong Wang  <jiong.wang@arm.com>
4497
4498         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4499         function.
4500         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4501         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4502         (aarch64_gdbarch_init): Add puth registers.
4503         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4504         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4505         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4506
4507 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4508             Jiong Wang  <jiong.wang@arm.com>
4509
4510         * aarch64-linux-nat.c
4511         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4512         * aarch64-linux-tdep.c
4513         (aarch64_linux_core_read_description): Likewise.
4514         (aarch64_linux_get_hwcap): New function.
4515         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4516         (aarch64_linux_get_hwcap): New declaration.
4517
4518 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4519             Jiong Wang  <jiong.wang@arm.com>
4520
4521         * aarch64-linux-nat.c
4522         (aarch64_linux_nat_target::read_description): Add pauth param.
4523         * aarch64-linux-tdep.c
4524         (aarch64_linux_core_read_description): Likewise.
4525         * aarch64-tdep.c (struct target_desc): Add in pauth.
4526         (aarch64_read_description): Add pauth param.
4527         (aarch64_gdbarch_init): Likewise.
4528         * aarch64-tdep.h (aarch64_read_description): Likewise.
4529         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4530         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4531         * features/Makefile: Add new files.
4532         * features/aarch64-pauth.c: New file.
4533         * features/aarch64-pauth.xml: New file.
4534
4535 2019-03-20  Tom Tromey  <tromey@adacore.com>
4536
4537         * infrun.c (handle_inferior_event): Rename from
4538         handle_inferior_event_1.  Create a scoped_value_mark.
4539         (handle_inferior_event): Remove.
4540
4541 2019-03-19  Tom Tromey  <tromey@adacore.com>
4542
4543         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4544         * infrun.h (print_stop_event): Add "displays" parameter.
4545         * infrun.c (print_stop_event): Add "displays" parameter.
4546
4547 2019-03-19  Pedro Alves  <palves@redhat.com>
4548
4549         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4550         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4551         to -1.  Fix TABs vs spaces.
4552         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4553         * tui/tui-out.h (tui_ui_out) Add intro comments.
4554         <m_line, m_start_of_line>: In-class initialize, and add describing
4555         comment.
4556
4557 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4558
4559         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4560         variable names.
4561         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4562
4563 2019-03-18  Pedro Alves  <palves@redhat.com>
4564             Eli Zaretskii <eliz@gnu.org>
4565
4566         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4567         m_line and m_start_of_line.
4568
4569 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4570
4571         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4572         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4573         it returns a newline.  This fixes a regression in TU mode, whereby
4574         the next line is output on the same screen line as the user input.
4575
4576 2019-03-18  Tom Tromey  <tromey@adacore.com>
4577
4578         * minsyms.c (minimal_symbol_reader::install): Remove call to
4579         obstack_blank.
4580
4581 2019-03-18  Pedro Alves  <palves@redhat.com>
4582
4583         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4584         New globals.
4585         (apply_style): New, factored out from ...
4586         (apply_ansi_escape): ... this.  Handle reverse video mode.
4587         (tui_set_reverse_mode): New function.
4588         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4589         * tui/tui-winsource.c (tui_show_source_line): Use
4590         tui_set_reverse_mode instead of setting A_STANDOUT.
4591         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4592         New setter methods.
4593
4594 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4595
4596         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4597         Handle tabs.
4598
4599 2019-03-18  Tom Tromey  <tromey@adacore.com>
4600
4601         * ada-lang.c (empty_array): Add "high" parameter.
4602         (ada_evaluate_subexp): Update.
4603
4604 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4605
4606         * unittests/string_view-selftests.c: Define
4607         _initialize_string_view_selftests unconditionally.
4608
4609 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4610
4611         PR gdb/24350
4612         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4613
4614 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4615
4616         PR gdb/24351
4617         * windows-nat.c (display_selector): Fix format specifiers.
4618
4619 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4620
4621         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4622         tui_refill_source_window instead of tui_refresh_win, to update the
4623         current execution line.  This fixes redisplay of the current line
4624         when stepping through the code with "next" or "step".
4625
4626 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4627
4628         * source-cache.c (source_cache::get_source_lines): Call
4629         find_source_lines to initialize s->nlines.  This fixes vertical
4630         scrolling of TUI source window when the DOWN arrow is pressed.
4631
4632 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4633
4634         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4635         linux-thread-db.c (_initialize_thread_db): Likewise.
4636
4637 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4638
4639         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4640         wclrtoeol in tui_show_source_line".  This reverts changes made in
4641         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4642
4643 2019-03-15  Tom Tromey  <tom@tromey.com>
4644
4645         * symtab.h (struct minimal_symbol): Derive from
4646         general_symbol_info.
4647         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4648         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4649         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4650         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4651         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4652         (MSYMBOL_SEARCH_NAME): Update.
4653         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4654         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4655         * minsyms.c (minimal_symbol_reader::record_full): Update.
4656
4657 2019-03-15  Tom Tromey  <tom@tromey.com>
4658
4659         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4660
4661 2019-03-15  Tom Tromey  <tom@tromey.com>
4662
4663         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4664         unique_xmalloc_ptr.
4665         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4666         Update.
4667         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4668         (build_minimal_symbol_hash_tables)
4669         (minimal_symbol_reader::install): Update.
4670
4671 2019-03-15  Tom Tromey  <tom@tromey.com>
4672
4673         * symtab.c (create_demangled_names_hash): Update.
4674         (symbol_set_names): Update.
4675         * objfiles.h (struct objfile_per_bfd_storage)
4676         <demangled_names_hash>: Now an htab_up.
4677         * objfiles.c (objfile_per_bfd_storage): Simplify.
4678
4679 2019-03-15  Tom Tromey  <tom@tromey.com>
4680
4681         * objfiles.h (struct objfile_per_bfd_storage): Declare
4682         destructor.
4683         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4684         New.
4685         (get_objfile_bfd_data): Use new.  Don't initialize
4686         language_of_main.
4687         (free_objfile_per_bfd_storage): Remove.
4688         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4689
4690 2019-03-15  Tom Tromey  <tom@tromey.com>
4691
4692         * symfile.c (reread_symbols): Update.
4693         * objfiles.c (objfile::objfile): Update.
4694         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4695         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4696         comment.
4697         (minimal_symbol_reader::install): Update.
4698         (terminate_minimal_symbol_table): Remove.
4699         * jit.c (jit_object_close_impl): Update.
4700
4701 2019-03-15  Tom Tromey  <tom@tromey.com>
4702
4703         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4704         initializations.
4705
4706 2019-03-15  Tom Tromey  <tom@tromey.com>
4707
4708         * objfiles.h (struct objfile_per_bfd_storage)
4709         <demangled_hash_languages>: Now a bitset.
4710         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4711         (lookup_minimal_symbol): Update.
4712
4713 2019-03-15  Tom Tromey  <tom@tromey.com>
4714
4715         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4716         Don't return the symbol.
4717         * coffread.c (record_minimal_symbol): Use record_full.
4718
4719 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4720
4721         The MS-Windows port of ncurses fails to switch to a color pair if
4722         one or both of the colors are the implicit default colors.  This
4723         change records the default colors when TUI is initialized, and
4724         then specifies them explicitly when a color pair uses the default
4725         colors.  This allows color styling in TUI mode on MS-Windows.
4726
4727         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4728         ncurses_norm_attr.
4729         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4730         colors in ncurses_norm_attr.
4731         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4732         "none", replace it with the default color recorded in
4733         ncurses_norm_attr.
4734
4735 2019-03-14  Tom Tromey  <tromey@adacore.com>
4736
4737         * source-cache.h (class source_cache) <get_source_lines>: Return
4738         std::string.
4739         * source-cache.c (source_cache::extract_lines): Handle case where
4740         first_pos==npos.  Return std::string.
4741         (source_cache::get_source_lines): Update.
4742
4743 2019-03-14  Tom Tromey  <tromey@adacore.com>
4744
4745         * NEWS: Add item for "style sources" commands.
4746         * source-cache.c (source_cache::get_source_lines): Check
4747         source_styling.
4748         * cli/cli-style.c (source_styling): New global.
4749         (_initialize_cli_style): Add "style sources" commands.
4750         (show_style_sources): New function.
4751         * cli/cli-style.h (source_styling): Declare.
4752
4753 2019-03-14  Pedro Alves  <palves@redhat.com>
4754             Tom Tromey  <tromey@adacore.com>
4755
4756         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4757         * tui/tui-winsource.c (tui_refill_source_window): New function,
4758         from...
4759         (tui_horizontal_source_scroll): ... here.  Move some logic.
4760         * cli/cli-style.c (set_style_enabled): Notify new observable.
4761         * tui/tui-hooks.c (tui_redisplay_source): New function.
4762         (tui_attach_detach_observers): Attach or detach
4763         tui_redisplay_source.
4764         * observable.h (source_styling_changed): New observable.
4765         * observable.c: Define source_styling_changed observable.
4766
4767 2019-03-13  Tom Tromey  <tromey@adacore.com>
4768
4769         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4770         (i386_gnu_nat_target::store_registers): Update.
4771         * target-debug.h (target_debug_print_std_string): New macro.
4772         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4773         * windows-tdep.c (display_one_tib): Update.
4774         * tui/tui-stack.c (tui_make_status_line): Update.
4775         * top.c (print_inferior_quit_action): Update.
4776         * thread.c (thr_try_catch_cmd): Update.
4777         (add_thread_with_info): Update.
4778         (thread_target_id_str): Update.
4779         (thr_try_catch_cmd): Update.
4780         (thread_command): Update.
4781         (thread_find_command): Update.
4782         * record-btrace.c (record_btrace_target::info_record)
4783         (record_btrace_resume_thread, record_btrace_target::resume)
4784         (record_btrace_cancel_resume, record_btrace_step_thread)
4785         (record_btrace_target::wait, record_btrace_target::wait)
4786         (record_btrace_target::wait, record_btrace_target::stop): Update.
4787         * progspace.c (print_program_space): Update.
4788         * process-stratum-target.c
4789         (process_stratum_target::thread_address_space): Update.
4790         * linux-fork.c (linux_fork_mourn_inferior)
4791         (detach_checkpoint_command, info_checkpoints_command)
4792         (linux_fork_context): Update.
4793         (linux_fork_detach): Update.
4794         (class scoped_switch_fork_info): Update.
4795         (delete_checkpoint_command): Update.
4796         * infrun.c (follow_fork_inferior): Update.
4797         (follow_fork_inferior): Update.
4798         (proceed_after_vfork_done): Update.
4799         (handle_vfork_child_exec_or_exit): Update.
4800         (follow_exec): Update.
4801         (displaced_step_prepare_throw): Update.
4802         (displaced_step_restore): Update.
4803         (start_step_over): Update.
4804         (resume_1): Update.
4805         (clear_proceed_status_thread): Update.
4806         (proceed): Update.
4807         (print_target_wait_results): Update.
4808         (do_target_wait): Update.
4809         (context_switch): Update.
4810         (stop_all_threads): Update.
4811         (restart_threads): Update.
4812         (finish_step_over): Update.
4813         (handle_signal_stop): Update.
4814         (switch_back_to_stepped_thread): Update.
4815         (keep_going_pass_signal): Update.
4816         (print_exited_reason): Update.
4817         (normal_stop): Update.
4818         * inferior.c (inferior_pid_to_str): Change return type.
4819         (print_selected_inferior): Update.
4820         (add_inferior): Update.
4821         (detach_inferior): Update.
4822         * dummy-frame.c (fprint_dummy_frames): Update.
4823         * dcache.c (dcache_info_1): Update.
4824         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4825         (btrace_fetch, btrace_clear): Update.
4826         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4827         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4828         type.
4829         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4830         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4831         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4832         * gdbarch.c, gdbarch.h: Rebuild.
4833         * gdbarch.sh (core_pid_to_str): Change return type.
4834         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4835         return type.
4836         (windows_nat_target::pid_to_str): Change return type.
4837         (windows_delete_thread): Update.
4838         (windows_nat_target::attach): Update.
4839         (windows_nat_target::files_info): Update.
4840         * target-delegates.c: Rebuild.
4841         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4842         return type.
4843         (sol_thread_target::pid_to_str): Change return type.
4844         * remote.c (class remote_target) <pid_to_str>: Change return
4845         type.
4846         (remote_target::pid_to_str): Change return type.
4847         (extended_remote_target::attach, remote_target::remote_stop_ns)
4848         (remote_target::remote_notif_remove_queued_reply)
4849         (remote_target::push_stop_reply, remote_target::disable_btrace):
4850         Update.
4851         (extended_remote_target::attach): Update.
4852         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4853         type.
4854         (gdbsim_target::pid_to_str): Change return type.
4855         * ravenscar-thread.c (struct ravenscar_thread_target)
4856         <pid_to_str>: Change return type.
4857         (ravenscar_thread_target::pid_to_str): Change return type.
4858         * procfs.c (class procfs_target) <pid_to_str>: Change return
4859         type.
4860         (procfs_target::pid_to_str): Change return type.
4861         (procfs_target::attach): Update.
4862         (procfs_target::detach): Update.
4863         (procfs_target::fetch_registers): Update.
4864         (procfs_target::store_registers): Update.
4865         (procfs_target::wait): Update.
4866         (procfs_target::files_info): Update.
4867         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4868         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4869         return type.
4870         (nto_procfs_target::pid_to_str): Change return type.
4871         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4872         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4873         return type.
4874         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4875         (exit_lwp): Update.
4876         (attach_proc_task_lwp_callback, get_detach_signal)
4877         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4878         (linux_nat_target::resume, wait_lwp, stop_callback)
4879         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4880         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4881         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4882         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4883         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4884         type.
4885         (inf_ptrace_target::attach): Update.
4886         (inf_ptrace_target::files_info): Update.
4887         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4888         type.
4889         (go32_nat_target::pid_to_str): Change return type.
4890         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4891         (gnu_nat_target::wait): Update.
4892         (gnu_nat_target::wait): Update.
4893         (gnu_nat_target::resume): Update.
4894         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4895         (fbsd_nat_target::wait): Update.
4896         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4897         type.
4898         (darwin_nat_target::attach): Update.
4899         * corelow.c (class core_target) <pid_to_str>: Change return type.
4900         (core_target::pid_to_str): Change return type.
4901         * target.c (normal_pid_to_str): Change return type.
4902         (default_pid_to_str): Likewise.
4903         (target_pid_to_str): Change return type.
4904         (target_translate_tls_address): Update.
4905         (target_announce_detach): Update.
4906         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4907         return type.
4908         (bsd_uthread_target::pid_to_str): Change return type.
4909         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4910         type.
4911         (bsd_kvm_target::pid_to_str): Change return type.
4912         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4913         return type.
4914         (aix_thread_target::pid_to_str): Change return type.
4915         * target.h (struct target_ops) <pid_to_str>: Change return type.
4916         (target_pid_to_str, normal_pid_to_str): Likewise.
4917         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4918         type.
4919         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4920         type.
4921         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4922         return type.
4923         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4924         type.
4925         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4926         type.
4927         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4928         return type.
4929
4930 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4931
4932         * NEWS: Mention that the new default MI version is 3.  Mention
4933         changes to the output of commands and events that deal with
4934         multi-location breakpoints.
4935         * breakpoint.c: Include "mi/mi-out.h".
4936         (print_one_breakpoint): Change output syntax if using MI version
4937         >= 3.
4938         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4939         New.
4940         (mi_multi_location_breakpoint_output_fixed): New.
4941         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4942         (mi_cmd_fix_multi_location_breakpoint_output): New.
4943         (mi_multi_location_breakpoint_output_fixed): New.
4944         * mi/mi-cmds.c (mi_cmds): Register command
4945         -fix-multi-location-breakpoint-output.
4946         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4947         interpreter "mi".
4948
4949 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4950
4951         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4952         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4953         instantiate mi_ui_out based on interpreter name.
4954         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4955         * mi/mi-main.c (mi_load_progress): Likewise.
4956
4957 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4958
4959         * NEWS: Combine separate "New targets" sections for 8.3.
4960
4961 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4962
4963         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4964         (ppcfbsd_init_abi): Install gdbarch
4965         "fetch_tls_load_module_address" and "get_thread_local_address"
4966         methods.
4967
4968 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4969
4970         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4971         (riscv_fbsd_init_abi): Install gdbarch
4972         "fetch_tls_load_module_address" and "get_thread_local_address"
4973         methods.
4974
4975 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4976
4977         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4978         (i386fbsd_init_abi): Install gdbarch
4979         "fetch_tls_load_module_address" and "get_thread_local_address"
4980         methods.
4981
4982 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4983
4984         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4985         (amd64fbsd_init_abi): Install gdbarch
4986         "fetch_tls_load_module_address" and "get_thread_local_address"
4987         methods.
4988
4989 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4990
4991         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4992         (struct fbsd_pspace_data): New type.
4993         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4994         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4995         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4996         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4997         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4998
4999 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5000
5001         * gdbtypes.c (lookup_struct_elt): New function.
5002         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5003         * gdbtypes.h (struct struct_elt): New type.
5004         (lookup_struct_elt): New prototype.
5005
5006 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5007
5008         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5009         remove disabled code block.
5010
5011 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5012
5013         * gdbarch.sh (get_thread_local_address): New method.
5014         * gdbarch.h, gdbarch.c: Regenerate.
5015         * target.c (target_translate_tls_address): Use
5016         gdbarch_get_thread_local_address if present instead of
5017         target::get_thread_local_address.
5018
5019 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5020
5021         * target.h (target::get_thread_local_address): Update comment.
5022
5023 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5024
5025         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5026         objfile->separate_debug_objfile_backlink if not NULL.
5027
5028 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5029
5030         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5031         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5032         (amd64bsd_store_inferior_registers): Likewise.
5033         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5034         Enable segment base registers.
5035         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5036         PT_GETFSBASE and PT_GETGSBASE.
5037         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5038         PT_SETGSBASE.
5039         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5040         segment base registers.
5041         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5042
5043 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5044
5045         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5046         Update calls to i386_target_description to add 'segments'
5047         parameter.
5048         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5049         add segment base registers.
5050         * arch/i386.c (i386_create_target_description): Add 'segments'
5051         parameter to enable segment base registers.
5052         * arch/i386.h (i386_create_target_description): Likewise.
5053         * features/i386/32bit-segments.xml: New file.
5054         * features/i386/32bit-segments.c: Generate.
5055         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5056         call to i386_target_description to add 'segments' parameter.
5057         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5058         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5059         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5060         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5061         if feature is present.
5062         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5063         Add 'segments' parameter to call to i386_target_description.
5064         (i386_target_description): Add 'segments' parameter to enable
5065         segment base registers.
5066         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5067         to call to i386_target_description.
5068         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5069         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5070         Define I386_NUM_REGS.
5071         (i386_target_description): Add 'segments' parameter to enable
5072         segment base registers.
5073
5074 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5075
5076         PR/24325
5077         * source-cache.c: #undef open and close, to avoid unresolved
5078         externals during linking.
5079
5080 2019-03-12  Tom Tromey  <tromey@adacore.com>
5081
5082         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5083         const.  Add initializers.
5084         (_initialize_remote): Don't initialize ptid globals.
5085
5086 2019-03-12  Pedro Alves  <palves@redhat.com>
5087
5088         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5089
5090 2019-03-12  Pedro Alves  <palves@redhat.com>
5091
5092         * cp-name-parser.y (main): Remove unused 'len' variable.
5093
5094 2019-03-12  Tom Tromey  <tromey@adacore.com>
5095
5096         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5097         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5098
5099 2019-03-12  Tom Tromey  <tromey@adacore.com>
5100
5101         * linux-nat.c (iterate_over_lwps): Update.
5102         (stop_callback): Remove parameter.
5103         (stop_wait_callback, detach_callback, resume_set_callback)
5104         (select_singlestep_lwp_callback, set_ignore_sigint)
5105         (status_callback, resumed_callback, resume_clear_callback)
5106         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5107         data parameter.
5108         (linux_nat_target::detach, linux_nat_target::resume)
5109         (linux_stop_and_wait_all_lwps, select_event_lwp)
5110         (linux_nat_filter_event, linux_nat_wait_1)
5111         (linux_nat_target::kill, linux_nat_target::stop)
5112         (linux_nat_target::stop): Update.
5113         (linux_nat_resume_callback): Change type.
5114         (resume_stopped_resumed_lwps, count_events_callback)
5115         (select_event_lwp_callback): Likewise.
5116         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5117         * arm-linux-nat.c (struct update_registers_data): Remove.
5118         (update_registers_callback): Change type.
5119         (arm_linux_insert_hw_breakpoint1): Update.
5120         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5121         parameter.
5122         (x86_linux_dr_set_addr): Update.
5123         (x86_linux_dr_set_control): Update.
5124         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5125         (iterate_over_lwps): Use gdb::function_view.
5126         * nat/aarch64-linux-hw-point.c (struct
5127         aarch64_dr_update_callback_param): Remove.
5128         (debug_reg_change_callback): Change type.
5129         (aarch64_notify_debug_reg_change): Update.
5130         * s390-linux-nat.c (s390_refresh_per_info): Update.
5131
5132 2019-03-11  Tom Tromey  <tromey@adacore.com>
5133
5134         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5135         redundant assignment to "this_cu".
5136
5137 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5138
5139         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5140
5141 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5142
5143         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5144         from...
5145         (rank_one_type): ... this.
5146
5147 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5148
5149         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5150         from...
5151         (rank_one_type): ... this.
5152
5153 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5154
5155         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5156         from...
5157         (rank_one_type): ... this.
5158
5159 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5160
5161         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5162         from...
5163         (rank_one_type): ... this.
5164
5165 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5166
5167         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5168         from...
5169         (rank_one_type): ... this.
5170
5171 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5172
5173         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5174         from...
5175         (rank_one_type): ... this.
5176
5177 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5178
5179         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5180         from...
5181         (rank_one_type): ... this.
5182
5183 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5184
5185         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5186         from...
5187         (rank_one_type): ... this.
5188
5189 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5190
5191         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5192         from...
5193         (rank_one_type): ... this.
5194
5195 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5196
5197         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5198         from...
5199         (rank_one_type): ... this.
5200
5201 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5202
5203         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5204         from...
5205         (rank_one_type): ... this.
5206
5207 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5208
5209         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5210         from...
5211         (rank_one_type): ... this.
5212
5213 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5214
5215         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5216         inferior-events' shows the example events.
5217
5218 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5219
5220         Support styling on native MS-Windows console
5221
5222         PR/24315
5223         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5224         on MS-Windows if $TERM is not defined.
5225
5226         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5227
5228         * posix-hdep.c (gdb_console_fputs):
5229         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5230         functions.
5231         * ui-file.h (gdb_console_fputs): Add prototype.
5232
5233         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5234         back to fputs only if the former returns zero.
5235
5236 2019-03-07  Tom Tromey  <tom@tromey.com>
5237
5238         * symmisc.c (print_symbol_bcache_statistics): Update.
5239         (print_objfile_statistics): Update.
5240         * symfile.c (allocate_symtab): Update.
5241         * stabsread.c: Don't include bcache.h.
5242         * psymtab.h (struct psymbol_bcache): Don't declare.
5243         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5244         (psymbol_bcache_init, psymbol_bcache_free)
5245         (psymbol_bcache_get_bcache): Don't declare.
5246         * psymtab.c (struct psymbol_bcache): Remove.
5247         (psymtab_storage::psymtab_storage): Update.
5248         (psymtab_storage::~psymtab_storage): Update.
5249         (psymbol_bcache_init, psymbol_bcache_free)
5250         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5251         (add_psymbol_to_bcache): Update.
5252         (allocate_psymtab): Update.
5253         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5254         macro_cache>: No longer pointers.
5255         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5256         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5257         * macrotab.c (macro_bcache): Update.
5258         * macroexp.c: Don't include bcache.h.
5259         * gdbtypes.c (check_types_worklist): Update.
5260         (types_deeply_equal): Remove TRY/CATCH.  Update.
5261         * elfread.c (elf_symtab_read): Update.
5262         * dwarf2read.c: Don't include bcache.h.
5263         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5264         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5265         (print_bcache_statistics, bcache_memory_used): Don't declare.
5266         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5267         methods.  Rename all data members.
5268         * bcache.c (struct bcache): Move to bcache.h.
5269         (bcache::expand_hash_table): Rename from expand_hash_table.
5270         (bcache): Remove.
5271         (bcache::insert): Rename from bcache_full.
5272         (bcache::compare): Rename from bcache_compare.
5273         (bcache_xmalloc): Remove.
5274         (bcache::~bcache): Rename from bcache_xfree.
5275         (bcache::print_statistics): Rename from print_bcache_statistics.
5276         (bcache::memory_used): Rename from bcache_memory_used.
5277
5278 2019-03-07  Pedro Alves  <palves@redhat.com>
5279
5280         * infrun.c (normal_stop): Also check for
5281         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5282
5283 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5284
5285         * f-lang.c (value_from_host_double): Moved to...
5286         * value.c (value_from_host_double): ...here.
5287         * value.h (value_from_host_double): Declare.
5288         * guile/scm-math.c (vlscm_convert_typed_number): Use
5289         value_from_host_double.
5290         (vlscm_convert_number): Likewise.
5291         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5292         * python/py-value.c (convert_value_from_python): Likewise.
5293
5294 2019-03-06  Tom Tromey  <tom@tromey.com>
5295
5296         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5297
5298 2019-03-06  Tom Tromey  <tom@tromey.com>
5299
5300         * utils.h (free_current_contents): Don't declare.
5301         * utils.c (free_current_contents): Remove.
5302
5303 2019-03-06  Tom Tromey  <tom@tromey.com>
5304
5305         * top.c (quit_force): Update.
5306         * main.c (captured_command_loop): Update.
5307         * common/new-op.c (operator new): Update.
5308         * common/common-exceptions.c (struct catcher)
5309         <save_cleanup_chain>: Remove member.
5310         (exceptions_state_mc_init): Update.
5311         (exception_try_scope_entry): Return nullptr.
5312         (exception_try_scope_exit, exception_rethrow)
5313         (throw_exception_sjlj, throw_exception_cxx): Update.
5314         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5315         (all_cleanups, do_cleanups, discard_cleanups)
5316         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5317         (restore_cleanups, restore_final_cleanups): Don't declare.
5318         (do_final_cleanups): Remove parameter.
5319         * common/cleanups.c (cleanup_chain, make_cleanup)
5320         (make_cleanup_dtor, all_cleanups, do_cleanups)
5321         (discard_my_cleanups, discard_cleanups)
5322         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5323         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5324         (null_cleanup): Remove.
5325         (do_final_cleanups): Remove parameter.
5326
5327 2019-03-06  Tom Tromey  <tom@tromey.com>
5328
5329         * remote.c (remote_target::remote_parse_stop_reply): Use
5330         unique_xmalloc_ptr.
5331
5332 2019-03-06  Tom Tromey  <tom@tromey.com>
5333
5334         * stabsread.c (struct stabs_field_info): Rename from field_info.
5335         <list, fnlist>: Add initializers.
5336         <obstack>: New member.
5337         (read_member_functions, read_struct_fields, read_baseclasses):
5338         Allocate on obstack.  Don't use cleanups.
5339         (read_one_struct_field, read_member_functions, read_struct_fields)
5340         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5341         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5342         (read_struct_type): Update.
5343
5344 2019-03-06  Tom Tromey  <tom@tromey.com>
5345
5346         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5347         * common/filestuff.h (make_cleanup_close): Don't declare.
5348         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5349         Remove.
5350
5351 2019-03-06  Tom Tromey  <tom@tromey.com>
5352
5353         * solib-aix.c: Use make_scope_exit.
5354
5355 2019-03-06  Tom Tromey  <tom@tromey.com>
5356
5357         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5358         Use make_scope_exit.
5359
5360 2019-03-06  Tom Tromey  <tom@tromey.com>
5361
5362         * solib-svr4.c (disable_probes_interface): Remove parameter.
5363         (svr4_handle_solib_event): Use make_scope_exit.
5364
5365 2019-03-06  Tom Tromey  <tom@tromey.com>
5366
5367         * remote.c (struct stop_reply_deleter): Remove.
5368         (stop_reply_up): Update.
5369         (struct stop_reply): Derive from notif_event.  Don't typedef.
5370         <regcache>: Now a std::vector.
5371         (stop_reply_xfree): Remove.
5372         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5373         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5374         (remote_target::discard_pending_stop_replies): Use delete.
5375         (remote_target::remote_parse_stop_reply): Update.
5376         (remote_target::process_stop_reply): Update.
5377         * remote-notif.h (struct notif_event): Add virtual destructor.
5378         Remove "dtr" member.
5379         (struct notif_client) <alloc_event>: Return a unique_ptr.
5380         (notif_event_xfree): Don't declare.
5381         (notif_event_up): New typedef.
5382         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5383         (notif_event_xfree, do_notif_event_xfree): Remove.
5384         (remote_notif_state_xfree): Update.
5385
5386 2019-03-06  Tom Tromey  <tom@tromey.com>
5387
5388         * infrun.c (displaced_step_clear_cleanup): Now a
5389         forward_scope_exit type.
5390         (displaced_step_prepare_throw): Update.
5391         (displaced_step_fixup): Update.
5392
5393 2019-03-06  Tom Tromey  <tom@tromey.com>
5394
5395         * inferior.h (class inferior): Update comment.
5396         * gdbthread.h (class thread_info): Update comment.
5397
5398 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5399             Tom Tromey  <tom@tromey.com>
5400
5401         * stabsread.h (struct stab_section_list): Remove.
5402         (coffstab_build_psymtabs): Update.
5403         * dbxread.c (symbuf_sections): Now a std::vector.
5404         (sect_idx): New global.
5405         (fill_symbuf): Update.
5406         (coffstab_build_psymtabs): Change type of stabsects parameter.
5407         Update.
5408         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5409         std::vector.
5410         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5411         (coff_locate_sections): Update.
5412         (coff_symfile_read): Remove cleanups.  Update.
5413         (init_stringtab): Add storage parameter.
5414         (free_stringtab, free_stringtab_cleanup): Remove.
5415         (init_lineno): Add storage parameter.
5416         (free_linetab, free_linetab_cleanup): Remove.
5417
5418 2019-03-06  Pedro Alves  <palves@redhat.com>
5419
5420         * linux-fork.c (fork_info::clobber_regs): Delete.
5421         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5422         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5423         comment.  Adjust.
5424         (scoped_switch_fork_info::scoped_switch_fork_info)
5425         (checkpoint_command, linux_fork_context): Adjust
5426         fork_save_infrun_state calls.
5427
5428 2019-03-06  Pedro Alves  <palves@redhat.com>
5429
5430         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5431         (inf_has_multiple_threads): Return 'bool' and rewrite using
5432         inferior_info::threads().
5433
5434 2019-03-06  Pedro Alves  <palves@redhat.com>
5435
5436         * linux-fork.c: Include <list>.
5437         (fork_list): Now a std::list instance.
5438         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5439         (forks_exist_p, find_last_fork): Adjust.
5440         (new_fork): Delete.
5441         (one_fork_p): New.
5442         (add_fork): Adjust.
5443         (free_fork): Delete, folded into fork_info::~fork_info().
5444         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5445         Adjust.
5446         (init_fork_list): Delete.
5447         (linux_fork_killall, linux_fork_mourn_inferior)
5448         (linux_fork_detach, info_checkpoints_command): Adjust.
5449         (_initialize_linux_fork): No longer call init_fork_list.
5450
5451 2019-03-06  Pedro Alves  <palves@redhat.com>
5452
5453         * linux-fork.c (new_fork): New, split out of ...
5454         (add_fork): ... this.  Return void.  Move "first fork" special
5455         case from here, to ...
5456         (checkpoint_command): ... here.
5457         * linux-linux.h (add_fork): Return void.
5458
5459 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5460
5461         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5462
5463 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5464             Chris January  <chris.january@arm.com>
5465             David Lecomber  <david.lecomber@arm.com>
5466
5467         * f-exp.y: New token, UNOP_INTRINSIC.
5468         (exp): New pattern using UNOP_INTRINSIC token.
5469         (f77_keywords): Add 'abs' keyword.
5470         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5471         (value_from_host_double): New function.
5472         (evaluate_subexp_f): Support UNOP_ABS.
5473
5474 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5475
5476         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5477         types.
5478
5479 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5480
5481         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5482         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5483         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5484
5485 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5486
5487         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5488
5489 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5490             Chris January  <chris.january@arm.com>
5491
5492         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5493         * f-exp.y: Define 'KIND' token.
5494         (exp): New pattern for KIND expressions.
5495         (ptype): Handle types with a kind extension.
5496         (direct_abs_decl): Extend to spot kind extensions.
5497         (f77_keywords): Add 'kind' to the list.
5498         (push_kind_type): New function.
5499         (convert_to_kind_type): New function.
5500         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5501         * parse.c (operator_length_standard): Likewise.
5502         * parser-defs.h (enum type_pieces): Add tp_kind.
5503         * std-operator.def: Add UNOP_KIND.
5504
5505 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5506
5507         * f-exp.y (f_parse): Set yydebug.
5508
5509 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5510
5511         * f-lang.c (evaluate_subexp_f): New function.
5512         (exp_descriptor_f): New global.
5513         (f_language_defn): Use exp_descriptor_f instead of
5514         exp_descriptor_standard.
5515
5516 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5517
5518         * f-exp.y (struct token): Add comments.
5519         (dot_ops): Remove uppercase versions and the end marker.
5520         (f77_keywords): Likewise.
5521         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5522         entries in the dot_ops array are case insensitive, and use
5523         strncasecmp to compare strings.  Also some whitespace cleanup in
5524         this area.  Similar for the f77_keywords array, except entries in
5525         this list might be case sensitive.
5526
5527 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5528
5529         * f-exp.y (struct f77_boolean_val): Add comments.
5530         (boolean_values): Remove uppercase versions, and end marker.
5531         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5532         and use strncasecmp to achieve case insensitivity.  Additionally,
5533         perform whitespace cleanup around this code.
5534
5535 2019-03-06  Tom Tromey  <tromey@adacore.com>
5536
5537         * remote-sim.c (gdbsim_target_open): Use result of
5538         gdb_argv::release.
5539
5540 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5541         Dirk Schubert  <dirk.schubert@arm.com>
5542         Chris January  <chris.january@arm.com>
5543
5544         * eval.c (evaluate_subexp_standard): Call Fortran argument
5545         wrapping logic.
5546         * f-lang.c (struct value): A value which can be passed into a
5547         Fortran function call.
5548         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5549         where appropriate.
5550         (struct type): Value ready for a Fortran function call.
5551         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5552         is needed.
5553         * f-lang.h (fortran_argument_convert): Declaration.
5554         (fortran_preserve_arg_pointer): Declaration.
5555         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5556
5557 2019-03-05  Tom Tromey  <tromey@adacore.com>
5558
5559         * python/py-prettyprint.c (print_string_repr): Remove #if.
5560         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5561
5562 2019-03-05  Tom Tromey  <tromey@adacore.com>
5563
5564         * target.c (the_dummy_target): Move later.  Change type to
5565         "dummy_target".
5566         (initialize_targets): Don't initialize the_dummy_target.
5567
5568 2019-03-05  Tom Tromey  <tromey@adacore.com>
5569
5570         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5571         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5572
5573 2019-03-05  Tom Tromey  <tromey@adacore.com>
5574
5575         * windows-nat.c (windows_nat_target::attach)
5576         (windows_nat_target::detach): Don't call gdb_flush.
5577         * valprint.c (generic_val_print, val_print, val_print_string):
5578         Don't call gdb_flush.
5579         * utils.c (defaulted_query): Don't call gdb_flush.
5580         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5581         * target.c (target_announce_detach): Don't call gdb_flush.
5582         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5583         * remote.c (extended_remote_target::attach): Don't call
5584         gdb_flush.
5585         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5586         * printcmd.c (do_examine): Don't call gdb_flush.
5587         (info_display_command): Don't call gdb_flush.
5588         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5589         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5590         * memattr.c (info_mem_command): Don't call gdb_flush.
5591         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5592         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5593         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5594         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5595         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5596         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5597         (gnu_nat_target::detach): Don't call gdb_flush.
5598         * f-valprint.c (f_val_print): Don't call gdb_flush.
5599         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5600         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5601         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5602         gdb_flush.
5603         * c-valprint.c (c_val_print): Don't call gdb_flush.
5604         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5605
5606 2019-03-05  Tom Tromey  <tromey@adacore.com>
5607
5608         * varobj.c (update_dynamic_varobj_children): Update.
5609         (install_default_visualizer): Use reset, not release.
5610         * value.c (set_internalvar): Update.
5611         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5612         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5613         ATTRIBUTE_UNUSED_RESULT.
5614
5615 2019-03-05  Tom Tromey  <tromey@adacore.com>
5616
5617         * remote.c (class scoped_remote_fd) <release>: Add
5618         ATTRIBUTE_UNUSED_RESULT.
5619
5620 2019-03-05  Tom Tromey  <tromey@adacore.com>
5621
5622         * macroexp.c (struct macro_buffer) <release>: Add
5623         ATTRIBUTE_UNUSED_RESULT.
5624
5625 2019-03-05  Tom Tromey  <tromey@adacore.com>
5626
5627         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5628         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5629         ATTRIBUTE_UNUSED_RESULT.
5630
5631 2019-03-05  Tom Tromey  <tromey@adacore.com>
5632
5633         * common/scoped_fd.h (class scoped_fd) <release>: Add
5634         ATTRIBUTE_UNUSED_RESULT.
5635
5636 2019-03-05  Tom Tromey  <tromey@adacore.com>
5637
5638         * parser-defs.h (struct parser_state) <release>: Add
5639         ATTRIBUTE_UNUSED_RESULT.
5640
5641 2019-03-05  Tom Tromey  <tromey@adacore.com>
5642
5643         * utils.h (class gdb_argv) <release>: Add
5644         ATTRIBUTE_UNUSED_RESULT.
5645         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5646
5647 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5648
5649         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5650         for-loop range, to avoid compiler warnings.
5651
5652         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5653         avoid compiler warnings about unused variables.
5654
5655         * NEWS: Mention end of support for native debugging on MS-Windows
5656         before XP.
5657
5658         PR gdb/24292
5659         * common/netstuff.c:
5660         * gdbserver/gdbreplay.c
5661         * gdbserver/remote-utils.c:
5662         * ser-tcp.c:
5663         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5664         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5665         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5666         'getaddrinfo' and 'freeaddrinfo' were not available before
5667         Windows XP, and mingw.org's MinGW headers by default define
5668         _WIN32_WINNT to 0x500.
5669
5670 2019-03-01  Gary Benson <gbenson@redhat.com>
5671
5672         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5673
5674 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5675             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5676
5677         PR gdb/8527
5678         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5679         set_sigint_trap, clear_sigint_trap.
5680
5681 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5682
5683         * target.c (target_detach): Clear the regcache and the
5684         frame cache.
5685
5686 2019-02-27  Pedro Alves  <palves@redhat.com>
5687
5688         * utils.c (set_screen_size): When we cap the height/width sizes,
5689         tweak the corresponding command variable to show "unlimited":
5690
5691 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5692             Pedro Alves  <palves@redhat.com>
5693
5694         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5695         before calling rl_set_screen_size.
5696
5697 2019-02-27  Tom Tromey  <tromey@adacore.com>
5698
5699         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5700         define.
5701         * python/py-value.c: Remove Python 2.4 workaround.
5702         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5703         workaround.
5704         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5705         Python 2.4 workaround.
5706         * python/python-internal.h: Remove Python 2.4 comment.
5707         (Py_ssize_t): Don't define.
5708         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5709         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5710         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5711         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5712         * python/python.c (do_start_initialization): Remove Python 2.4
5713         workaround.
5714         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5715         (print_children): Remove Python 2.4 workaround.
5716         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5717         workaround.
5718         (CHARBUFFERPROC_NAME): Remove.
5719         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5720         Python 2.4 workaround.
5721
5722 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5723
5724         * NEWS: Note minimum Python version.
5725
5726 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5727
5728         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5729         code from these functions.  Remove corresponding ifdefs.  Use
5730         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5731         Remove gotos and target of gotos.
5732         (infpy_search_memory): Likewise.
5733
5734 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5735
5736         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5737         (hppa_gdbarch_init): Don't register deleted functions with
5738         gdbarch.
5739
5740 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5741
5742         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5743         (h8300_unwind_sp): Delete.
5744         (h8300_dummy_id): Delete.
5745         (h8300_gdbarch_init): Don't register deleted functions with
5746         gdbarch.
5747
5748 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5749
5750         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5751         (ft32_unwind_pc): Delete.
5752         (ft32_unwind_sp): Delete.
5753         (ft32_gdbarch_init): Don't register deleted functions with
5754         gdbarch.
5755
5756 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5757
5758         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5759         (frv_unwind_pc): Delete.
5760         (frv_unwind_sp): Delete.
5761         (frv_gdbarch_init): Don't register deleted functions with
5762         gdbarch.
5763
5764 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5765
5766         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5767         (riscv_unwind_pc): Delete.
5768         (riscv_unwind_sp): Delete.
5769         (riscv_gdbarch_init): Don't register deleted functions with
5770         gdbarch.
5771
5772 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5773
5774         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5775         (csky_unwind_pc): Delete.
5776         (csky_unwind_sp): Delete.
5777         (csky_gdbarch_init): Don't register deleted functions with
5778         gdbarch.
5779
5780 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5781
5782         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5783         (cris_unwind_pc): Delete.
5784         (cris_unwind_sp): Delete.
5785         (cris_gdbarch_init): Don't register deleted functions with
5786         gdbarch.
5787
5788 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5789
5790         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5791         (bfin_unwind_pc): Delete.
5792         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5793
5794 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5795
5796         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5797         (arm_unwind_pc): Delete.
5798         (arm_unwind_sp): Delete.
5799         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5800
5801 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5802
5803         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5804         (arc_unwind_pc): Delete.
5805         (arc_unwind_sp): Delete.
5806         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5807
5808 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5809
5810         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5811         (alpha_unwind_pc): Delete.
5812         (alpha_gdbarch_init): Don't register deleted functions with
5813         gdbarch.
5814
5815 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5816
5817         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5818         (aarch64_unwind_pc): Delete.
5819         (aarch64_unwind_sp): Delete.
5820         (aarch64_gdbarch_init): Don't register deleted functions with
5821         gdbarch.
5822
5823 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5824
5825         * gdbtypes.c (type_align): Don't consider static members when
5826         computing structure alignment.
5827
5828 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5829
5830         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5831         return 0 for other types.
5832         * arch-utils.c (default_type_align): Always return 0.
5833         * gdbarch.h: Regenerate.
5834         * gdbarch.sh (type_align): Extend comment.
5835         * gdbtypes.c (type_align): Add additional comments, always call
5836         gdbarch_type_align before applying the default rules.
5837         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5838         generic code will then apply a suitable default.
5839         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5840         types, return 0 for other types.
5841
5842 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5843
5844         * NEWS: Create a new section for the next release branch.
5845         Rename the section of the current branch, now that it has
5846         been cut.
5847
5848 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5849
5850         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5851         * version.in: Bump version to 8.3.50.DATE-git.
5852
5853 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5854
5855         * aix-thread.c (ptid_cmp): Remove unused variable.
5856         (get_signaled_thread): Likewise.
5857         (store_regs_user_thread): Likewise.
5858         (store_regs_kernel_thread): Likewise.
5859         (fetch_regs_kernel_thread): Remove shadowed variable.
5860
5861 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5862
5863         * features/riscv/32bit-cpu.xml: Add register numbers.
5864         * features/riscv/32bit-fpu.c: Regenerate.
5865         * features/riscv/32bit-fpu.xml: Add register numbers.
5866         * features/riscv/64bit-cpu.xml: Add register numbers.
5867         * features/riscv/64bit-fpu.c: Regenerate.
5868         * features/riscv/64bit-fpu.xml: Add register numbers.
5869
5870 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5871
5872         * NEWS: Mention two argument form of gdb.Value constructor.
5873         * python/py-value.c (convert_buffer_and_type_to_value): New
5874         function.
5875         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5876         Add support for handling an optional second argument.  Call
5877         convert_buffer_and_type_to_value as appropriate.
5878         * python/python-internal.h (Py_buffer_deleter): New struct.
5879         (Py_buffer_up): New typedef.
5880
5881 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5882
5883         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5884         instead of releasing ownership.
5885
5886 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5887
5888         * dwarf2read.c (open_and_init_dwp_file): Call
5889         elf_numsections instead of bfd_count_sections to initialize
5890         dwp_file->num_sections.
5891
5892 2019-02-25  Tom Tromey  <tromey@adacore.com>
5893
5894         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5895
5896 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5897
5898         * gcore.in: Add '--readnever' option when invoking GDB.
5899
5900 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5901
5902         * MAINTAINERS: Update my email address.
5903
5904 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5905
5906         * build-id.c (build_id_to_debug_bfd_1): New function.
5907         (build_id_to_debug_bfd): Look for separate debug file in
5908         sysroot.
5909
5910 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5911
5912         * gdbarch.sh: Update the copyright year range that is placed into
5913         generated files.
5914
5915 2019-02-22  Keith Seitz  <keiths@redhat.com>
5916
5917         PR symtab/23853
5918         * linespec.c (create_sals_line_offset): Search for the default
5919         symtab's filename instead of its fullname.
5920
5921 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5922
5923         * NEWS: Update style defaults.
5924
5925 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5926
5927         * main.c (captured_main_1): Disable styling in batch mode.
5928
5929 2019-02-20  Tom Tromey  <tom@tromey.com>
5930
5931         * symtab.c (symtab_symbol_info): Fix typos.
5932
5933 2019-02-20  Tom Tromey  <tromey@adacore.com>
5934
5935         * findcmd.c (_initialize_mem_search): Use upper case for
5936         metasyntactic variables.
5937
5938 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5939
5940         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5941         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5942
5943 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5944
5945         * top.h (source_file_name): Change to std::string.
5946         * top.c (source_file_name): Likewise.
5947         (command_line_input): Adjust.
5948         * cli/cli-script.c (script_from_file): Adjust.
5949
5950 2019-02-19  Tom Tromey  <tromey@adacore.com>
5951
5952         * ravenscar-thread.c
5953         (ravenscar_thread_target::update_thread_list): Don't call
5954         ada_build_task_list.
5955         * ada-lang.h (ada_build_task_list): Don't declare.
5956         * ada-tasks.c (struct ada_tasks_inferior_data)
5957         <task_list_valid_p>: Now bool.
5958         (read_known_tasks, ada_task_list_changed)
5959         (ada_tasks_invalidate_inferior_data): Update.
5960         (read_known_tasks_array): Return bool.
5961         (read_known_tasks_list): Likewise.
5962         (read_known_tasks): Return void.
5963         (ada_build_task_list): Now static.
5964
5965 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5966
5967         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5968         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5969
5970 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5971
5972         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5973         variant for ada_tasks_pspace_data_handle and
5974         ada_tasks_inferior_data_handle.
5975         (ada_tasks_pspace_data_cleanup): New function.
5976         (ada_tasks_inferior_data_cleanup): New function.
5977
5978 2019-02-17  Tom Tromey  <tom@tromey.com>
5979
5980         * macrotab.h (macro_source_fullname): Return a std::string.
5981         * macrotab.c (macro_include, check_for_redefinition)
5982         (macro_undef, macro_lookup_definition, foreach_macro)
5983         (foreach_macro_in_scope): Update.
5984         (macro_source_fullname): Return a std::string.
5985         * macrocmd.c (show_pp_source_pos): Update.
5986
5987 2019-02-17  Tom Tromey  <tom@tromey.com>
5988
5989         * macrocmd.c (show_pp_source_pos): Style the file names.
5990
5991 2019-02-17  Tom Tromey  <tom@tromey.com>
5992
5993         PR tui/24197:
5994         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5995
5996 2019-02-17  Tom Tromey  <tom@tromey.com>
5997
5998         * ada-lang.c (user_select_syms): Use filtered printing.
5999         * utils.c (wrap_style): New global.
6000         (desired_style): Remove.
6001         (emit_style_escape): Add stream parameter.
6002         (set_output_style, reset_terminal_style, prompt_for_continue):
6003         Update.
6004         (flush_wrap_buffer): Only flush gdb_stdout.
6005         (wrap_here): Set wrap_style.
6006         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6007         treat escape sequences as a character.  Change when wrap buffer is
6008         flushed.
6009         (fputs_styled): Do not set the output style when the default is
6010         requested.
6011         * ui-style.h (struct ui_file_style) <is_default>: New method.
6012         * source.c (print_source_lines_base): Emit escape sequences in one
6013         piece.
6014
6015 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6016
6017         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6018         integers and enumeration types.
6019
6020 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6021
6022         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6023         instead of lookup_symbol_in_language
6024         (do_exact_match): New function.
6025         (ada_get_symbol_name_matcher): Return do_exact_match when
6026         doing a verbatim match.
6027
6028 2019-02-15  Tom Tromey  <tromey@adacore.com>
6029
6030         * ravenscar-thread.c (ravenscar_thread_target::resume)
6031         (ravenscar_thread_target::wait): Special case wildcard requests.
6032
6033 2019-02-15  Tom Tromey  <tromey@adacore.com>
6034
6035         * ravenscar-thread.c (base_ptid): Remove.
6036         (struct ravenscar_thread_target) <close>: New method.
6037         <m_base_ptid>: New member.
6038         <update_inferior_ptid, active_task, task_is_currently_active,
6039         runtime_initialized>: Declare methods.
6040         <ravenscar_thread_target>: Add constructor.
6041         (ravenscar_thread_target::task_is_currently_active)
6042         (ravenscar_thread_target::update_inferior_ptid)
6043         (ravenscar_runtime_initialized): Rename.  Now methods.
6044         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6045         (ravenscar_thread_target::update_thread_list): Update.
6046         (ravenscar_thread_target::active_task): Now method.
6047         (ravenscar_thread_target::store_registers)
6048         (ravenscar_thread_target::prepare_to_store)
6049         (ravenscar_thread_target::prepare_to_store)
6050         (ravenscar_thread_target::mourn_inferior): Update.
6051         (ravenscar_inferior_created): Use "new" to create target.
6052         (ravenscar_thread_target::get_ada_task_ptid): Update.
6053         (_initialize_ravenscar): Don't initialize base_ptid.
6054         (ravenscar_ops): Remove global.
6055
6056 2019-02-15  Tom Tromey  <tromey@adacore.com>
6057
6058         * target.h (push_target): Declare new overload.
6059         * target.c (push_target): New overload, taking an rvalue reference.
6060         * remote.c (remote_target::open_1): Use push_target overload.
6061         * corelow.c (core_target_open): Use push_target overload.
6062
6063 2019-02-15  Tom Tromey  <tromey@adacore.com>
6064
6065         * ravenscar-thread.c (is_ravenscar_task)
6066         (ravenscar_task_is_currently_active): Return bool.
6067         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6068         (_initialize_ravenscar): Remove "(void)".
6069         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6070         Return bool.
6071
6072 2019-02-15  Tom Tromey  <tromey@adacore.com>
6073
6074         * ravenscar-thread.c (ravenscar_runtime_initializer)
6075         (has_ravenscar_runtime, get_running_thread_id)
6076         (ravenscar_thread_target::resume): Fix indentation.
6077
6078 2019-02-15  Tom Tromey  <tromey@adacore.com>
6079
6080         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6081         from ravenscar_arch_ops.
6082         (sparc_ravenscar_ops::fetch_registers)
6083         (sparc_ravenscar_ops::store_registers): Now methods.
6084         (sparc_ravenscar_prepare_to_store): Remove.
6085         (sparc_ravenscar_ops): Redefine.
6086         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6087         methods and destructor.  Remove members.
6088         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6089         (ravenscar_thread_target::store_registers)
6090         (ravenscar_thread_target::prepare_to_store): Update.
6091         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6092         Remove.
6093         (struct ppc_ravenscar_powerpc_ops): Derive from
6094         ravenscar_arch_ops.
6095         (ppc_ravenscar_powerpc_ops::fetch_registers)
6096         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6097         (ppc_ravenscar_powerpc_ops): Redefine.
6098         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6099         (ppc_ravenscar_e500_ops::fetch_registers)
6100         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6101         (ppc_ravenscar_e500_ops): Redefine.
6102         * aarch64-ravenscar-thread.c
6103         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6104         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6105         (aarch64_ravenscar_fetch_registers)
6106         (aarch64_ravenscar_store_registers): Now methods.
6107         (aarch64_ravenscar_ops): Redefine.
6108
6109 2019-02-15  Tom Tromey  <tromey@adacore.com>
6110
6111         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6112         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6113         (ravenscar_thread_target::stopped_by_watchpoint)
6114         (ravenscar_thread_target::stopped_data_address)
6115         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6116
6117 2019-02-15  Tom Tromey  <tromey@adacore.com>
6118
6119         * ravenscar-thread.c: Fix some typos.
6120
6121 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6122             Tom Tromey  <tromey@adacore.com>
6123
6124         * ada-lang.c (ada_exception_sal): Change addr_string to a
6125         std::string.
6126         (create_ada_exception_catchpoint): Update.
6127
6128 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6129             Tom Tromey  <tromey@adacore.com>
6130
6131         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6132         (bp_location_ops): Remove.
6133         (base_breakpoint_allocate_location): Update.
6134         (free_bp_location): Update.
6135         * ada-lang.c (class ada_catchpoint_location)
6136         <ada_catchpoint_location>: Remove ops parameter.
6137         (ada_catchpoint_location_dtor): Remove.
6138         (ada_catchpoint_location_ops): Remove.
6139         (allocate_location_exception): Update.
6140         * breakpoint.h (struct bp_location_ops): Remove.
6141         (class bp_location) <bp_location>: Remove bp_location_ops
6142         parameter.
6143         <~bp_location>: Add destructor.
6144         <ops>: Remove.
6145
6146 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6147             Pedro Alves  <palves@redhat.com>
6148
6149         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6150         'PATH_MAX'.
6151
6152 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6153             Samuel Thibault  <samuel.thibault@gnu.org>
6154             Thomas Schwinge  <thomas@codesourcery.com>
6155
6156         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6157         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6158
6159 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6160
6161         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6162         (check_empty): Use "const char *".
6163
6164         * gnu-nat.c (gnu_nat_target::detach): Instead of
6165         'detach_inferior (pid)' call
6166         'detach_inferior (find_inferior_pid (pid))'.
6167
6168         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6169         'nat/fork-inferior.o'.
6170         * gnu-nat.c: #include "nat/fork-inferior.h".
6171
6172         * gnu-nat.c (gnu_nat_target::detach): Instead of
6173         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6174         * gnu-nat.h: #include "inf-child.h".
6175         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6176         'i386_gnu_nat_target::fetch_registers'.
6177         (gnu_store_registers): Rename/move to
6178         'i386_gnu_nat_target::store_registers'.
6179
6180         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6181         * gnu-nat.h (mach_thread_info): New function.
6182         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6183
6184         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6185
6186 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6187
6188         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6189
6190 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6191
6192         * windows-nat.c (windows_add_thread): Add new parameter
6193         "main_thread_p" with default value set to false.  Update
6194         function documentation as well as all callers.
6195         (windows_delete_thread): Likewise.
6196         (fake_create_process): Update call to windows_add_thread.
6197         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6198         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6199         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6200         call to windows_delete_thread.
6201
6202 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6203
6204         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6205
6206 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6207
6208         * symfile.c (find_separate_debug_file): Use canonical path of
6209         sysroot with child_path instead of gdb_sysroot if it is valid.
6210
6211 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6212
6213         * symfile.c (find_separate_debug_file): Use child_path to
6214         determine if an object file is under a sysroot.
6215
6216 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6217
6218         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6219         unittests/child-path-selftests.c.
6220         * common/pathstuff.c (child_path): New function.
6221         * common/pathstuff.h (child_path): New prototype.
6222         * unittests/child-path-selftests.c: New file.
6223
6224 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6225
6226         * symfile.c (find_separate_debug_file): Look for separate debug
6227         files in debug directories under the sysroot.
6228
6229 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6230
6231         * symtab.h (struct minimal_symbol data_p): New const method.
6232         (struct minimal_symbol text_p): Likewise.
6233         * symtab.c (output_source_filename): Use file name style
6234         to print file name.
6235         (print_symbol_info): Likewise.
6236         (print_msymbol_info): Use address style to print addresses.
6237         Use function name style to print executable text symbols.
6238         (expand_symtab_containing_pc): Use data_p.
6239         (find_pc_sect_compunit_symtab): Likewise.
6240
6241 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6242
6243         * breakpoint.c (describe_other_breakpoints): Use address style
6244         to print addresses.
6245         (say_where): Likewise.
6246
6247 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6248
6249         * ada-typeprint.c (print_func_type): Print function name
6250         style to print function name.
6251         * c-typeprint.c (c_print_type_1): Likewise.
6252
6253 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6254
6255         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6256         for execve.
6257
6258 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6259
6260         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6261         type_stack.
6262
6263 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6264
6265         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6266         TYPE_CODE_REF types.
6267
6268 2019-02-08  Jim Wilson  <jimw@sifive.com>
6269
6270         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6271         (riscv_linux_fregset): New.
6272         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6273
6274 2019-02-07  Tom Tromey  <tom@tromey.com>
6275
6276         * thread.c (thread_cancel_execution_command): Update.
6277         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6278         methods.
6279         (struct thread_fsm_ops): Remove.
6280         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6281         (thread_fsm_should_stop, thread_fsm_return_value)
6282         (thread_fsm_set_finished, thread_fsm_finished_p)
6283         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6284         Don't declare.
6285         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6286         * infrun.c (clear_proceed_status_thread)
6287         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6288         (print_stop_event): Update.
6289         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6290         Add constructor.
6291         (step_command_fsm_ops): Remove.
6292         (new_step_command_fsm): Remove.
6293         (step_1): Update.
6294         (step_command_fsm::should_stop): Rename from
6295         step_command_fsm_should_stop.
6296         (step_command_fsm::clean_up): Rename from
6297         step_command_fsm_clean_up.
6298         (step_command_fsm::do_async_reply_reason): Rename from
6299         step_command_fsm_async_reply_reason.
6300         (struct until_next_fsm): Inherit from thread_fsm.  Add
6301         constructor.
6302         (until_next_fsm_ops): Remove.
6303         (new_until_next_fsm): Remove.
6304         (until_next_fsm::should_stop): Rename from
6305         until_next_fsm_should_stop.
6306         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6307         (until_next_fsm::do_async_reply_reason): Rename from
6308         until_next_fsm_async_reply_reason.
6309         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6310         constructor.  Change type of breakpoint.
6311         (finish_command_fsm_ops): Remove.
6312         (new_finish_command_fsm): Remove.
6313         (finish_command_fsm::should_stop): Rename from
6314         finish_command_fsm_should_stop.
6315         (finish_command_fsm::clean_up): Rename from
6316         finish_command_fsm_clean_up.
6317         (finish_command_fsm::return_value): Rename from
6318         finish_command_fsm_return_value.
6319         (finish_command_fsm::do_async_reply_reason): Rename from
6320         finish_command_fsm_async_reply_reason.
6321         (finish_command): Update.
6322         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6323         Add constructor.
6324         (call_thread_fsm_ops): Remove.
6325         (call_thread_fsm::call_thread_fsm): Rename from
6326         new_call_thread_fsm.
6327         (call_thread_fsm::should_stop): Rename from
6328         call_thread_fsm_should_stop.
6329         (call_thread_fsm::should_notify_stop): Rename from
6330         call_thread_fsm_should_notify_stop.
6331         (run_inferior_call, call_function_by_hand_dummy): Update.
6332         * cli/cli-interp.c (should_print_stop_to_console): Update.
6333         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6334         Add constructor.  Change type of location_breakpoint,
6335         caller_breakpoint.
6336         (until_break_fsm_ops): Remove.
6337         (new_until_break_fsm): Remove.
6338         (until_break_fsm::should_stop): Rename from
6339         until_break_fsm_should_stop.
6340         (until_break_fsm::clean_up): Rename from
6341         until_break_fsm_clean_up.
6342         (until_break_fsm::do_async_reply_reason): Rename from
6343         until_break_fsm_async_reply_reason.
6344         (until_break_command): Update.
6345         * thread-fsm.c: Remove.
6346         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6347
6348 2019-02-07  Tom Tromey  <tom@tromey.com>
6349
6350         * yy-remap.h: Add include guard.
6351         * xtensa-tdep.h: Add include guard.
6352         * xcoffread.h: Rename include guard.
6353         * varobj-iter.h: Add include guard.
6354         * tui/tui.h: Rename include guard.
6355         * tui/tui-winsource.h: Rename include guard.
6356         * tui/tui-wingeneral.h: Rename include guard.
6357         * tui/tui-windata.h: Rename include guard.
6358         * tui/tui-win.h: Rename include guard.
6359         * tui/tui-stack.h: Rename include guard.
6360         * tui/tui-source.h: Rename include guard.
6361         * tui/tui-regs.h: Rename include guard.
6362         * tui/tui-out.h: Rename include guard.
6363         * tui/tui-layout.h: Rename include guard.
6364         * tui/tui-io.h: Rename include guard.
6365         * tui/tui-hooks.h: Rename include guard.
6366         * tui/tui-file.h: Rename include guard.
6367         * tui/tui-disasm.h: Rename include guard.
6368         * tui/tui-data.h: Rename include guard.
6369         * tui/tui-command.h: Rename include guard.
6370         * tic6x-tdep.h: Add include guard.
6371         * target/waitstatus.h: Rename include guard.
6372         * target/wait.h: Rename include guard.
6373         * target/target.h: Rename include guard.
6374         * target/resume.h: Rename include guard.
6375         * target-float.h: Rename include guard.
6376         * stabsread.h: Add include guard.
6377         * rs6000-tdep.h: Add include guard.
6378         * riscv-fbsd-tdep.h: Add include guard.
6379         * regformats/regdef.h: Rename include guard.
6380         * record.h: Rename include guard.
6381         * python/python.h: Rename include guard.
6382         * python/python-internal.h: Rename include guard.
6383         * python/py-stopevent.h: Rename include guard.
6384         * python/py-ref.h: Rename include guard.
6385         * python/py-record.h: Rename include guard.
6386         * python/py-record-full.h: Rename include guard.
6387         * python/py-record-btrace.h: Rename include guard.
6388         * python/py-instruction.h: Rename include guard.
6389         * python/py-events.h: Rename include guard.
6390         * python/py-event.h: Rename include guard.
6391         * procfs.h: Add include guard.
6392         * proc-utils.h: Add include guard.
6393         * p-lang.h: Add include guard.
6394         * or1k-tdep.h: Rename include guard.
6395         * observable.h: Rename include guard.
6396         * nto-tdep.h: Rename include guard.
6397         * nat/x86-linux.h: Rename include guard.
6398         * nat/x86-linux-dregs.h: Rename include guard.
6399         * nat/x86-gcc-cpuid.h: Add include guard.
6400         * nat/x86-dregs.h: Rename include guard.
6401         * nat/x86-cpuid.h: Rename include guard.
6402         * nat/ppc-linux.h: Rename include guard.
6403         * nat/mips-linux-watch.h: Rename include guard.
6404         * nat/linux-waitpid.h: Rename include guard.
6405         * nat/linux-ptrace.h: Rename include guard.
6406         * nat/linux-procfs.h: Rename include guard.
6407         * nat/linux-osdata.h: Rename include guard.
6408         * nat/linux-nat.h: Rename include guard.
6409         * nat/linux-namespaces.h: Rename include guard.
6410         * nat/linux-btrace.h: Rename include guard.
6411         * nat/glibc_thread_db.h: Rename include guard.
6412         * nat/gdb_thread_db.h: Rename include guard.
6413         * nat/gdb_ptrace.h: Rename include guard.
6414         * nat/fork-inferior.h: Rename include guard.
6415         * nat/amd64-linux-siginfo.h: Rename include guard.
6416         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6417         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6418         * nat/aarch64-linux.h: Rename include guard.
6419         * nat/aarch64-linux-hw-point.h: Rename include guard.
6420         * mn10300-tdep.h: Add include guard.
6421         * mips-linux-tdep.h: Add include guard.
6422         * mi/mi-parse.h: Rename include guard.
6423         * mi/mi-out.h: Rename include guard.
6424         * mi/mi-main.h: Rename include guard.
6425         * mi/mi-interp.h: Rename include guard.
6426         * mi/mi-getopt.h: Rename include guard.
6427         * mi/mi-console.h: Rename include guard.
6428         * mi/mi-common.h: Rename include guard.
6429         * mi/mi-cmds.h: Rename include guard.
6430         * mi/mi-cmd-break.h: Rename include guard.
6431         * m2-lang.h: Add include guard.
6432         * location.h: Rename include guard.
6433         * linux-record.h: Rename include guard.
6434         * linux-nat.h: Add include guard.
6435         * linux-fork.h: Add include guard.
6436         * i386-darwin-tdep.h: Rename include guard.
6437         * hppa-linux-offsets.h: Add include guard.
6438         * guile/guile.h: Rename include guard.
6439         * guile/guile-internal.h: Rename include guard.
6440         * gnu-nat.h: Rename include guard.
6441         * gdb-stabs.h: Rename include guard.
6442         * frv-tdep.h: Add include guard.
6443         * f-lang.h: Add include guard.
6444         * event-loop.h: Add include guard.
6445         * darwin-nat.h: Rename include guard.
6446         * cp-abi.h: Rename include guard.
6447         * config/sparc/nm-sol2.h: Rename include guard.
6448         * config/nm-nto.h: Rename include guard.
6449         * config/nm-linux.h: Add include guard.
6450         * config/i386/nm-i386gnu.h: Rename include guard.
6451         * config/djgpp/nl_types.h: Rename include guard.
6452         * config/djgpp/langinfo.h: Rename include guard.
6453         * compile/gcc-cp-plugin.h: Add include guard.
6454         * compile/gcc-c-plugin.h: Add include guard.
6455         * compile/compile.h: Rename include guard.
6456         * compile/compile-object-run.h: Rename include guard.
6457         * compile/compile-object-load.h: Rename include guard.
6458         * compile/compile-internal.h: Rename include guard.
6459         * compile/compile-cplus.h: Rename include guard.
6460         * compile/compile-c.h: Rename include guard.
6461         * common/xml-utils.h: Rename include guard.
6462         * common/x86-xstate.h: Rename include guard.
6463         * common/version.h: Rename include guard.
6464         * common/vec.h: Rename include guard.
6465         * common/tdesc.h: Rename include guard.
6466         * common/selftest.h: Rename include guard.
6467         * common/scoped_restore.h: Rename include guard.
6468         * common/scoped_mmap.h: Rename include guard.
6469         * common/scoped_fd.h: Rename include guard.
6470         * common/safe-iterator.h: Rename include guard.
6471         * common/run-time-clock.h: Rename include guard.
6472         * common/refcounted-object.h: Rename include guard.
6473         * common/queue.h: Rename include guard.
6474         * common/ptid.h: Rename include guard.
6475         * common/print-utils.h: Rename include guard.
6476         * common/preprocessor.h: Rename include guard.
6477         * common/pathstuff.h: Rename include guard.
6478         * common/observable.h: Rename include guard.
6479         * common/netstuff.h: Rename include guard.
6480         * common/job-control.h: Rename include guard.
6481         * common/host-defs.h: Rename include guard.
6482         * common/gdb_wait.h: Rename include guard.
6483         * common/gdb_vecs.h: Rename include guard.
6484         * common/gdb_unlinker.h: Rename include guard.
6485         * common/gdb_unique_ptr.h: Rename include guard.
6486         * common/gdb_tilde_expand.h: Rename include guard.
6487         * common/gdb_sys_time.h: Rename include guard.
6488         * common/gdb_string_view.h: Rename include guard.
6489         * common/gdb_splay_tree.h: Rename include guard.
6490         * common/gdb_setjmp.h: Rename include guard.
6491         * common/gdb_ref_ptr.h: Rename include guard.
6492         * common/gdb_optional.h: Rename include guard.
6493         * common/gdb_locale.h: Rename include guard.
6494         * common/gdb_assert.h: Rename include guard.
6495         * common/filtered-iterator.h: Rename include guard.
6496         * common/filestuff.h: Rename include guard.
6497         * common/fileio.h: Rename include guard.
6498         * common/environ.h: Rename include guard.
6499         * common/common-utils.h: Rename include guard.
6500         * common/common-types.h: Rename include guard.
6501         * common/common-regcache.h: Rename include guard.
6502         * common/common-inferior.h: Rename include guard.
6503         * common/common-gdbthread.h: Rename include guard.
6504         * common/common-exceptions.h: Rename include guard.
6505         * common/common-defs.h: Rename include guard.
6506         * common/common-debug.h: Rename include guard.
6507         * common/cleanups.h: Rename include guard.
6508         * common/buffer.h: Rename include guard.
6509         * common/btrace-common.h: Rename include guard.
6510         * common/break-common.h: Rename include guard.
6511         * cli/cli-utils.h: Rename include guard.
6512         * cli/cli-style.h: Rename include guard.
6513         * cli/cli-setshow.h: Rename include guard.
6514         * cli/cli-script.h: Rename include guard.
6515         * cli/cli-interp.h: Rename include guard.
6516         * cli/cli-decode.h: Rename include guard.
6517         * cli/cli-cmds.h: Rename include guard.
6518         * charset-list.h: Add include guard.
6519         * buildsym-legacy.h: Rename include guard.
6520         * bfin-tdep.h: Add include guard.
6521         * ax.h: Rename include guard.
6522         * arm-linux-tdep.h: Add include guard.
6523         * arm-fbsd-tdep.h: Add include guard.
6524         * arch/xtensa.h: Rename include guard.
6525         * arch/tic6x.h: Add include guard.
6526         * arch/i386.h: Add include guard.
6527         * arch/arm.h: Rename include guard.
6528         * arch/arm-linux.h: Rename include guard.
6529         * arch/arm-get-next-pcs.h: Rename include guard.
6530         * arch/amd64.h: Add include guard.
6531         * arch/aarch64-insn.h: Rename include guard.
6532         * arch-utils.h: Rename include guard.
6533         * annotate.h: Add include guard.
6534         * amd64-darwin-tdep.h: Rename include guard.
6535         * aarch64-linux-tdep.h: Add include guard.
6536         * aarch64-fbsd-tdep.h: Add include guard.
6537         * aarch32-linux-nat.h: Add include guard.
6538
6539 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6540
6541         * macrotab.c (macro_define_internal): New function that
6542         factorizes macro_define_object_internal and macro_define_function
6543         code.
6544         (macro_define_object_internal): Use macro_define_internal.
6545         (macro_define_function): Likewise.
6546
6547 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6548
6549         * macrocmd.c (extract_identifier): Return
6550         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6551         callers.
6552
6553 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6554
6555         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6556
6557 2019-02-05  Tom Tromey  <tom@tromey.com>
6558
6559         * target.c (target_stack::unpush): Move assertion earlier.
6560
6561 2019-01-30  Tom Tromey  <tom@tromey.com>
6562
6563         PR python/23615:
6564         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6565         (gdbpy_parse_and_eval): Likewise.
6566         * python/python-internal.h (gdbpy_allow_threads): New class.
6567
6568 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6569
6570         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6571         (aarch64_fbsd_fpregmap): Move earlier.
6572         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6573         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6574         instead of individual calls to trad_frame_set_reg_addr.
6575         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6576         earlier.
6577         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6578         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6579         instead of individual calls to trad_frame_set_reg_addr.
6580
6581 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6582
6583         * CONTRIBUTE: Replace contribution list with wiki link.
6584
6585 2019-01-25  Tom Tromey  <tom@tromey.com>
6586
6587         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6588
6589 2019-01-25  Tom Tromey  <tom@tromey.com>
6590
6591         * xtensa-linux-nat.c: Fix common/ includes.
6592         * xml-support.h: Fix common/ includes.
6593         * xml-support.c: Fix common/ includes.
6594         * x86-linux-nat.c: Fix common/ includes.
6595         * windows-nat.c: Fix common/ includes.
6596         * varobj.h: Fix common/ includes.
6597         * varobj.c: Fix common/ includes.
6598         * value.c: Fix common/ includes.
6599         * valops.c: Fix common/ includes.
6600         * utils.c: Fix common/ includes.
6601         * unittests/xml-utils-selftests.c: Fix common/ includes.
6602         * unittests/utils-selftests.c: Fix common/ includes.
6603         * unittests/unpack-selftests.c: Fix common/ includes.
6604         * unittests/tracepoint-selftests.c: Fix common/ includes.
6605         * unittests/style-selftests.c: Fix common/ includes.
6606         * unittests/string_view-selftests.c: Fix common/ includes.
6607         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6608         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6609         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6610         * unittests/rsp-low-selftests.c: Fix common/ includes.
6611         * unittests/parse-connection-spec-selftests.c: Fix common/
6612         includes.
6613         * unittests/optional-selftests.c: Fix common/ includes.
6614         * unittests/offset-type-selftests.c: Fix common/ includes.
6615         * unittests/observable-selftests.c: Fix common/ includes.
6616         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6617         * unittests/memrange-selftests.c: Fix common/ includes.
6618         * unittests/memory-map-selftests.c: Fix common/ includes.
6619         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6620         * unittests/function-view-selftests.c: Fix common/ includes.
6621         * unittests/environ-selftests.c: Fix common/ includes.
6622         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6623         * unittests/common-utils-selftests.c: Fix common/ includes.
6624         * unittests/cli-utils-selftests.c: Fix common/ includes.
6625         * unittests/array-view-selftests.c: Fix common/ includes.
6626         * ui-file.c: Fix common/ includes.
6627         * tui/tui-io.c: Fix common/ includes.
6628         * tracepoint.h: Fix common/ includes.
6629         * tracepoint.c: Fix common/ includes.
6630         * tracefile-tfile.c: Fix common/ includes.
6631         * top.h: Fix common/ includes.
6632         * top.c: Fix common/ includes.
6633         * thread.c: Fix common/ includes.
6634         * target/waitstatus.h: Fix common/ includes.
6635         * target/waitstatus.c: Fix common/ includes.
6636         * target.h: Fix common/ includes.
6637         * target.c: Fix common/ includes.
6638         * target-memory.c: Fix common/ includes.
6639         * target-descriptions.c: Fix common/ includes.
6640         * symtab.h: Fix common/ includes.
6641         * symfile.c: Fix common/ includes.
6642         * stap-probe.c: Fix common/ includes.
6643         * spu-linux-nat.c: Fix common/ includes.
6644         * sparc-nat.c: Fix common/ includes.
6645         * source.c: Fix common/ includes.
6646         * solib.c: Fix common/ includes.
6647         * solib-target.c: Fix common/ includes.
6648         * ser-unix.c: Fix common/ includes.
6649         * ser-tcp.c: Fix common/ includes.
6650         * ser-pipe.c: Fix common/ includes.
6651         * ser-base.c: Fix common/ includes.
6652         * selftest-arch.c: Fix common/ includes.
6653         * s12z-tdep.c: Fix common/ includes.
6654         * rust-exp.y: Fix common/ includes.
6655         * rs6000-aix-tdep.c: Fix common/ includes.
6656         * riscv-tdep.c: Fix common/ includes.
6657         * remote.c: Fix common/ includes.
6658         * remote-notif.h: Fix common/ includes.
6659         * remote-fileio.h: Fix common/ includes.
6660         * remote-fileio.c: Fix common/ includes.
6661         * regcache.h: Fix common/ includes.
6662         * regcache.c: Fix common/ includes.
6663         * record-btrace.c: Fix common/ includes.
6664         * python/python.c: Fix common/ includes.
6665         * python/py-type.c: Fix common/ includes.
6666         * python/py-inferior.c: Fix common/ includes.
6667         * progspace.h: Fix common/ includes.
6668         * producer.c: Fix common/ includes.
6669         * procfs.c: Fix common/ includes.
6670         * proc-api.c: Fix common/ includes.
6671         * printcmd.c: Fix common/ includes.
6672         * ppc-linux-nat.c: Fix common/ includes.
6673         * parser-defs.h: Fix common/ includes.
6674         * osdata.c: Fix common/ includes.
6675         * obsd-nat.c: Fix common/ includes.
6676         * nat/x86-linux.c: Fix common/ includes.
6677         * nat/x86-linux-dregs.c: Fix common/ includes.
6678         * nat/x86-dregs.h: Fix common/ includes.
6679         * nat/x86-dregs.c: Fix common/ includes.
6680         * nat/ppc-linux.c: Fix common/ includes.
6681         * nat/mips-linux-watch.h: Fix common/ includes.
6682         * nat/mips-linux-watch.c: Fix common/ includes.
6683         * nat/linux-waitpid.c: Fix common/ includes.
6684         * nat/linux-ptrace.h: Fix common/ includes.
6685         * nat/linux-ptrace.c: Fix common/ includes.
6686         * nat/linux-procfs.c: Fix common/ includes.
6687         * nat/linux-personality.c: Fix common/ includes.
6688         * nat/linux-osdata.c: Fix common/ includes.
6689         * nat/linux-namespaces.c: Fix common/ includes.
6690         * nat/linux-btrace.h: Fix common/ includes.
6691         * nat/linux-btrace.c: Fix common/ includes.
6692         * nat/fork-inferior.c: Fix common/ includes.
6693         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6694         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6695         * nat/aarch64-linux.c: Fix common/ includes.
6696         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6697         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6698         * namespace.h: Fix common/ includes.
6699         * mips-linux-tdep.c: Fix common/ includes.
6700         * minsyms.c: Fix common/ includes.
6701         * mi/mi-parse.h: Fix common/ includes.
6702         * mi/mi-main.c: Fix common/ includes.
6703         * mi/mi-cmd-env.c: Fix common/ includes.
6704         * memrange.h: Fix common/ includes.
6705         * memattr.c: Fix common/ includes.
6706         * maint.h: Fix common/ includes.
6707         * maint.c: Fix common/ includes.
6708         * main.c: Fix common/ includes.
6709         * machoread.c: Fix common/ includes.
6710         * location.c: Fix common/ includes.
6711         * linux-thread-db.c: Fix common/ includes.
6712         * linux-nat.c: Fix common/ includes.
6713         * linux-fork.c: Fix common/ includes.
6714         * inline-frame.c: Fix common/ includes.
6715         * infrun.c: Fix common/ includes.
6716         * inflow.c: Fix common/ includes.
6717         * inferior.h: Fix common/ includes.
6718         * inferior.c: Fix common/ includes.
6719         * infcmd.c: Fix common/ includes.
6720         * inf-ptrace.c: Fix common/ includes.
6721         * inf-child.c: Fix common/ includes.
6722         * ia64-linux-nat.c: Fix common/ includes.
6723         * i387-tdep.c: Fix common/ includes.
6724         * i386-tdep.c: Fix common/ includes.
6725         * i386-linux-tdep.c: Fix common/ includes.
6726         * i386-linux-nat.c: Fix common/ includes.
6727         * i386-go32-tdep.c: Fix common/ includes.
6728         * i386-fbsd-tdep.c: Fix common/ includes.
6729         * i386-fbsd-nat.c: Fix common/ includes.
6730         * guile/scm-type.c: Fix common/ includes.
6731         * guile/guile.c: Fix common/ includes.
6732         * go32-nat.c: Fix common/ includes.
6733         * gnu-nat.c: Fix common/ includes.
6734         * gdbthread.h: Fix common/ includes.
6735         * gdbarch-selftests.c: Fix common/ includes.
6736         * gdb_usleep.c: Fix common/ includes.
6737         * gdb_select.h: Fix common/ includes.
6738         * gdb_bfd.c: Fix common/ includes.
6739         * gcore.c: Fix common/ includes.
6740         * fork-child.c: Fix common/ includes.
6741         * findvar.c: Fix common/ includes.
6742         * fbsd-nat.c: Fix common/ includes.
6743         * event-top.c: Fix common/ includes.
6744         * event-loop.c: Fix common/ includes.
6745         * dwarf2read.c: Fix common/ includes.
6746         * dwarf2loc.c: Fix common/ includes.
6747         * dwarf2-frame.c: Fix common/ includes.
6748         * dwarf-index-cache.c: Fix common/ includes.
6749         * dtrace-probe.c: Fix common/ includes.
6750         * disasm-selftests.c: Fix common/ includes.
6751         * defs.h: Fix common/ includes.
6752         * csky-tdep.c: Fix common/ includes.
6753         * cp-valprint.c: Fix common/ includes.
6754         * cp-support.h: Fix common/ includes.
6755         * cp-support.c: Fix common/ includes.
6756         * corelow.c: Fix common/ includes.
6757         * completer.h: Fix common/ includes.
6758         * completer.c: Fix common/ includes.
6759         * compile/compile.c: Fix common/ includes.
6760         * compile/compile-loc2c.c: Fix common/ includes.
6761         * compile/compile-cplus-types.c: Fix common/ includes.
6762         * compile/compile-cplus-symbols.c: Fix common/ includes.
6763         * command.h: Fix common/ includes.
6764         * cli/cli-dump.c: Fix common/ includes.
6765         * cli/cli-cmds.c: Fix common/ includes.
6766         * charset.c: Fix common/ includes.
6767         * build-id.c: Fix common/ includes.
6768         * btrace.h: Fix common/ includes.
6769         * btrace.c: Fix common/ includes.
6770         * breakpoint.h: Fix common/ includes.
6771         * breakpoint.c: Fix common/ includes.
6772         * ax.h:
6773         (enum agent_op): Fix common/ includes.
6774         * ax-general.c (struct aop_map): Fix common/ includes.
6775         * ax-gdb.c: Fix common/ includes.
6776         * auxv.c: Fix common/ includes.
6777         * auto-load.c: Fix common/ includes.
6778         * arm-tdep.c: Fix common/ includes.
6779         * arch/riscv.c: Fix common/ includes.
6780         * arch/ppc-linux-common.c: Fix common/ includes.
6781         * arch/i386.c: Fix common/ includes.
6782         * arch/arm.c: Fix common/ includes.
6783         * arch/arm-linux.c: Fix common/ includes.
6784         * arch/arm-get-next-pcs.c: Fix common/ includes.
6785         * arch/amd64.c: Fix common/ includes.
6786         * arch/aarch64.c: Fix common/ includes.
6787         * arch/aarch64-insn.c: Fix common/ includes.
6788         * arch-utils.c: Fix common/ includes.
6789         * amd64-windows-tdep.c: Fix common/ includes.
6790         * amd64-tdep.c: Fix common/ includes.
6791         * amd64-sol2-tdep.c: Fix common/ includes.
6792         * amd64-obsd-tdep.c: Fix common/ includes.
6793         * amd64-nbsd-tdep.c: Fix common/ includes.
6794         * amd64-linux-tdep.c: Fix common/ includes.
6795         * amd64-linux-nat.c: Fix common/ includes.
6796         * amd64-fbsd-tdep.c: Fix common/ includes.
6797         * amd64-fbsd-nat.c: Fix common/ includes.
6798         * amd64-dicos-tdep.c: Fix common/ includes.
6799         * amd64-darwin-tdep.c: Fix common/ includes.
6800         * agent.c: Fix common/ includes.
6801         * ada-lang.h: Fix common/ includes.
6802         * ada-lang.c: Fix common/ includes.
6803         * aarch64-tdep.c: Fix common/ includes.
6804
6805 2019-01-25  Tom Tromey  <tom@tromey.com>
6806
6807         * common/create-version.sh: Use common/version.h.
6808
6809 2019-01-24  Pedro Alves  <palves@redhat.com>
6810
6811         * infrun.c (signal_stop, signal_print, signal_program)
6812         (signal_catch, signal_pass): Now arrays instead of pointers.
6813         (update_signals_program_target, do_target_resume)
6814         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6815         * linux-nat.c (linux_nat_target::pass_signals)
6816         (linux_nat_target::create_inferior, linux_nat_target::attach):
6817         Adjust.
6818         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6819         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6820         * procfs.c (procfs_target::pass_signals): Adjust.
6821         * record-full.c (record_full_target::resume): Adjust.
6822         * remote.c (remote_target::pass_signals)
6823         (remote_target::program_signals): Adjust.
6824         * target-debug.h (target_debug_print_signals): Now takes a
6825         gdb::array_view as parameter.  Adjust.
6826         * target.h (target_ops) <pass_signals, program_signals>: Replace
6827         pointer and length parameters with gdb::array_view.
6828         (target_pass_signals, target_program_signals): Likewise.
6829         * target-delegates.c: Regenerate.
6830
6831 2019-01-24  Pedro Alves  <palves@redhat.com>
6832
6833         * common/forward-scope-exit.h
6834         (forward_scope_exit::forward_scope_exit): Pass arguments to
6835         m_bind_function directly, instead of creating a std::bind and
6836         copying that.
6837
6838 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6839
6840         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6841         for static members.
6842         (pass_in_v_vfp_candidate): Likewise.
6843
6844 2019-01-23  Tom Tromey  <tom@tromey.com>
6845             Pedro Alves  <palves@redhat.com>
6846
6847         * regcache.c (class regcache_invalidator): Remove.
6848         (regcache::raw_write): Use make_scope_exit.
6849
6850 2019-01-23  Tom Tromey  <tom@tromey.com>
6851
6852         * ui-out.h (class ui_out_emit_type): Update comment.
6853
6854 2019-01-23  Tom Tromey  <tom@tromey.com>
6855
6856         * infrun.c (fetch_inferior_event): Update comment.
6857
6858 2019-01-23  Tom Tromey  <tom@tromey.com>
6859             Pedro Alves  <palves@redhat.com>
6860
6861         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6862         parameter.
6863         (fetch_inferior_event): Use SCOPE_EXIT.
6864
6865
6866 2019-01-23  Tom Tromey  <tom@tromey.com>
6867             Pedro Alves  <palves@redhat.com>
6868
6869         * infrun.c (disable_thread_events): Delete.
6870         (stop_all_threads): Use SCOPE_EXIT.
6871
6872 2019-01-23  Tom Tromey  <tom@tromey.com>
6873             Pedro Alves  <palves@redhat.com>
6874
6875         * symfile.c: Include forward-scope-exit.h.
6876         (clear_symtab_users_cleanup): Replace forward declaration with
6877         a FORWARD_SCOPE_EXIT.
6878         (syms_from_objfile_1): Use the forward_scope_exit and
6879         gdb::optional instead of cleanup_function.
6880         (reread_symbols): Use the forward_scope_exit instead of
6881         cleanup_function.
6882         (clear_symtab_users_cleanup): Remove function.
6883
6884 2019-01-23  Tom Tromey  <tom@tromey.com>
6885             Pedro Alves  <palves@redhat.com>
6886
6887         * linux-nat.c: Include scope-exit.h.
6888         (cleanup_target_stop): Remove.
6889         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6890         SCOPE_EXIT.
6891
6892 2019-01-23  Tom Tromey  <tom@tromey.com>
6893             Pedro Alves  <palves@redhat.com>
6894
6895         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6896         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6897
6898 2019-01-23  Tom Tromey  <tom@tromey.com>
6899             Andrew Burgess  <andrew.burgess@embecosm.com>
6900             Pedro Alves  <palves@redhat.com>
6901
6902         * infrun.c (fetch_inferior_event): Use scope_exit.
6903         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6904         * top.c (execute_command): Use scope_exit.
6905         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6906         * utils.c (do_bpstat_clear_actions_cleanup)
6907         (make_bpstat_clear_actions_cleanup): Remove.
6908
6909 2019-01-23  Tom Tromey  <tom@tromey.com>
6910             Pedro Alves  <palves@redhat.com>
6911
6912         * infrun.c: Include "common/scope-exit.h"
6913         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6914         (wait_for_inferior): Use SCOPE_EXIT.
6915         (fetch_inferior_event): Use scope_exit.
6916
6917 2019-01-23  Tom Tromey  <tom@tromey.com>
6918             Pedro Alves  <palves@redhat.com>
6919
6920         * breakpoint.c (create_breakpoint): Remove cleanup.
6921
6922 2019-01-23  Tom Tromey  <tom@tromey.com>
6923             Andrew Burgess  <andrew.burgess@embecosm.com>
6924             Pedro Alves  <palves@redhat.com>
6925
6926 2019-01-23  Pedro Alves  <palves@redhat.com>
6927
6928         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6929
6930 2019-01-23  Pedro Alves  <palves@redhat.com>
6931             Andrew Burgess  <andrew.burgess@embecosm.com>
6932
6933         * gdbthread.h: Include "common/forward-scope-exit.h".
6934         (scoped_finish_thread_state): Redefine custom class in terms of
6935         forward_scope_exit.
6936
6937 2019-01-23  Pedro Alves  <palves@redhat.com>
6938             Andrew Burgess  <andrew.burgess@embecosm.com>
6939
6940         * common/forward-scope-exit.h: New file.
6941
6942 2019-01-23  Pedro Alves  <palves@redhat.com>
6943             Andrew Burgess  <andrew.burgess@embecosm.com>
6944             Tom Tromey  <tom@tromey.com>
6945
6946         * common/scope-exit.h: New file.
6947
6948 2019-01-23  Pedro Alves  <palves@redhat.com>
6949
6950         * common/preprocessor.h (ESC): Rename to ...
6951         (ESC_PARENS): ... this.
6952         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6953         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6954
6955 2019-01-23  Tom Tromey  <tom@tromey.com>
6956
6957         * language.h (class scoped_switch_to_sym_language_if_auto):
6958         Initialize m_lang in both cases.
6959
6960 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6961
6962         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6963         with XCNEW.
6964
6965 2019-01-22  Tom Tromey  <tom@tromey.com>
6966
6967         * corelow.c: Do not include sys/file.h.
6968
6969 2019-01-22  Tom Tromey  <tom@tromey.com>
6970
6971         * tui/tui-wingeneral.h: Include gdb_curses.h.
6972
6973 2019-01-22  Tom Tromey  <tom@tromey.com>
6974
6975         * source-cache.h (class source_cache) <get_source_lines,
6976         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6977
6978 2019-01-22  Tom Tromey  <tom@tromey.com>
6979
6980         * remote-fileio.h (struct remote_target): Declare.
6981
6982 2019-01-22  Tom Tromey  <tom@tromey.com>
6983
6984         * python/py-arch.c: Do not include py-ref.h.
6985         * python/py-bpevent.c: Do not include py-ref.h.
6986         * python/py-cmd.c: Do not include py-ref.h.
6987         * python/py-continueevent.c: Do not include py-ref.h.
6988         * python/py-event.h: Do not include py-ref.h.
6989         * python/py-evtregistry.c: Do not include py-ref.h.
6990         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6991         * python/py-frame.c: Do not include py-ref.h.
6992         * python/py-framefilter.c: Do not include py-ref.h.
6993         * python/py-function.c: Do not include py-ref.h.
6994         * python/py-infevents.c: Do not include py-ref.h.
6995         * python/py-linetable.c: Do not include py-ref.h.
6996         * python/py-objfile.c: Do not include py-ref.h.
6997         * python/py-param.c: Do not include py-ref.h.
6998         * python/py-prettyprint.c: Do not include py-ref.h.
6999         * python/py-progspace.c: Do not include py-ref.h.
7000         * python/py-symbol.c: Do not include py-ref.h.
7001         * python/py-symtab.c: Do not include py-ref.h.
7002         * python/py-type.c: Do not include py-ref.h.
7003         * python/py-unwind.c: Do not include py-ref.h.
7004         * python/py-utils.c: Do not include py-ref.h.
7005         * python/py-value.c: Do not include py-ref.h.
7006         * python/py-varobj.c: Do not include py-ref.h.
7007         * python/py-xmethods.c: Do not include py-ref.h.
7008         * python/python.c: Do not include py-ref.h.
7009         * varobj.c: Do not include py-ref.h.
7010
7011 2019-01-22  Tom Tromey  <tom@tromey.com>
7012
7013         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7014         keyword for bcache.
7015
7016 2019-01-22  Tom Tromey  <tom@tromey.com>
7017
7018         * compile/compile-cplus-types.c: Remove a comment by #include.
7019
7020 2019-01-22  Tom Tromey  <tom@tromey.com>
7021
7022         * compile/gcc-c-plugin.h: Include compile-internal.h.
7023
7024 2019-01-22  Tom Tromey  <tom@tromey.com>
7025
7026         * stabsread.c (EXTERN): Do not define.
7027         (symnum, next_symbol_text_func, processing_gcc_compilation)
7028         (within_function, global_sym_chain, global_stabs)
7029         (previous_stab_code, this_object_header_files)
7030         (n_this_object_header_files)
7031         (n_allocated_this_object_header_files): Define.
7032         * stabsread.h (EXTERN): Never define.  Use "extern".
7033
7034 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7035
7036         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7037         history_value.
7038
7039 2019-01-21  Tom Tromey  <tom@tromey.com>
7040
7041         * ui-out.c: Fix includes.
7042         * tui/tui-source.c: Fix includes.
7043         * target.c: Fix includes.
7044         * remote.c: Fix includes.
7045         * regcache.c: Fix includes.
7046         * python/py-block.c: Fix includes.
7047         * printcmd.c: Fix includes.
7048         * or1k-tdep.c: Fix includes.
7049         * mi/mi-main.c: Fix includes.
7050         * m32r-tdep.c: Fix includes.
7051         * csky-tdep.c: Fix includes.
7052         * compile/compile-cplus-types.c: Fix includes.
7053         * cli/cli-interp.c: Fix includes.
7054
7055 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7056
7057         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7058         for padding.
7059
7060 2019-01-16  Tom Tromey  <tom@tromey.com>
7061
7062         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7063         earlier.
7064         (struct objfile) <msymbols_range>: Move from top level.
7065         <msymbols>: New method.
7066         (class objfile_msymbols): Remove.
7067         * symtab.c (default_collect_symbol_completion_matches_break_on):
7068         Update.
7069         * symmisc.c (dump_msymbols): Update.
7070         * stabsread.c (scan_file_globals): Update.
7071         * objc-lang.c (info_selectors_command, info_classes_command)
7072         (find_methods): Update.
7073         * minsyms.c (find_solib_trampoline_target): Update.
7074         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7075         * coffread.c (coff_symfile_read): Update.
7076         * ada-lang.c (ada_lookup_simple_minsym)
7077         (ada_collect_symbol_completion_matches): Update.
7078
7079 2019-01-16  Tom Tromey  <tom@tromey.com>
7080
7081         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7082         type.  Remove no-argument constructor.
7083         <iterator::operator++>: Simplify.
7084         <begin>: Update.
7085         <end>: Use minimal_symbol_count.
7086
7087 2019-01-16  Tom Tromey  <tom@tromey.com>
7088
7089         * objfiles.h (struct objfile) <psymtabs>: New method.
7090         (class objfile_psymtabs): Remove.
7091         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7092         typedef.
7093         <range>: New method.
7094         (require_partial_symbols): Change return type.
7095         * psymtab.c (require_partial_symbols)
7096         (psym_expand_symtabs_matching): Update.
7097         * mdebugread.c (parse_partial_symbols): Update.
7098         * dbxread.c (dbx_end_psymtab): Update.
7099
7100 2019-01-15  Tom Tromey  <tom@tromey.com>
7101
7102         * symtab.c (lookup_objfile_from_block)
7103         (lookup_symbol_in_objfile_symtabs)
7104         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7105         (find_line_symtab, info_sources_command)
7106         (default_collect_symbol_completion_matches_break_on)
7107         (make_source_files_completion_list): Update.
7108         * symmisc.c (print_objfile_statistics, dump_objfile)
7109         (maintenance_print_symbols, maintenance_info_symtabs)
7110         (maintenance_check_symtabs, maintenance_info_line_tables):
7111         Update.
7112         * source.c (select_source_symtab)
7113         (forget_cached_source_info_for_objfile): Update.
7114         * objfiles.h (class objfile_compunits): Remove.
7115         (struct objfile) <compunits_range>: New typedef.
7116         (compunits): New method.
7117         * objfiles.c (objfile_relocate1): Update.
7118         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7119         * maint.c (count_symtabs_and_blocks): Update.
7120         * linespec.c (iterate_over_all_matching_symtabs): Update.
7121         * cp-support.c (add_symbol_overload_list_qualified): Update.
7122         * coffread.c (coff_symtab_read): Update.
7123         * ada-lang.c (add_nonlocal_symbols)
7124         (ada_collect_symbol_completion_matches)
7125         (ada_add_global_exceptions): Update.
7126
7127 2019-01-15  Tom Tromey  <tom@tromey.com>
7128
7129         * progspace.h (program_space) <objfiles_safe_range>: New
7130         typedef.
7131         <objfiles_safe>: New method.
7132         * objfiles.h (class all_objfiles_safe): Remove.
7133         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7134         * jit.c (jit_inferior_exit_hook): Update.
7135
7136 2019-01-17  Tom Tromey  <tom@tromey.com>
7137
7138         * progspace.h (program_space) <objfiles_range>: New typedef.
7139         <objfiles>: New method.
7140         <objfiles_head>: Rename from objfiles.
7141         (object_files): Update.
7142         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7143         * guile/scm-pretty-print.c
7144         (ppscm_find_pretty_printer_from_objfiles): Update.
7145         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7146         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7147         Update.
7148         * python/py-progspace.c (pspy_get_objfiles): Update.
7149         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7150         Update.
7151         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7152         (objfpy_lookup_objfile_by_build_id): Update.
7153         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7154         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7155         Update.
7156         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7157         (expand_symtab_containing_pc, lookup_objfile_from_block)
7158         (lookup_static_symbol, basic_lookup_transparent_type)
7159         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7160         (find_line_symtab, info_sources_command)
7161         (default_collect_symbol_completion_matches_break_on)
7162         (make_source_files_completion_list, find_main_name): Update.
7163         * symmisc.c (print_symbol_bcache_statistics)
7164         (print_objfile_statistics, maintenance_print_symbols)
7165         (maintenance_print_msymbols, maintenance_print_objfiles)
7166         (maintenance_info_symtabs, maintenance_check_symtabs)
7167         (maintenance_expand_symtabs, maintenance_info_line_tables):
7168         Update.
7169         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7170         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7171         (map_overlay_command, unmap_overlay_command)
7172         (simple_overlay_update, expand_symtabs_matching)
7173         (map_symbol_filenames): Update.
7174         * symfile-debug.c (set_debug_symfile): Update.
7175         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7176         Update.
7177         * source.c (select_source_symtab, forget_cached_source_info):
7178         Update.
7179         * solib.c (solib_read_symbols): Update.
7180         * solib-spu.c (append_ocl_sos): Update.
7181         * psymtab.c (maintenance_print_psymbols)
7182         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7183         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7184         * printcmd.c (info_symbol_command): Update.
7185         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7186         Update.
7187         * objfiles.h (class all_objfiles): Remove.
7188         * objfiles.c (have_partial_symbols, have_full_symbols)
7189         (have_minimal_symbols, qsort_cmp, update_section_map)
7190         (shared_objfile_contains_address_p)
7191         (default_iterate_over_objfiles_in_search_order): Update.
7192         * objc-lang.c (info_selectors_command, info_classes_command)
7193         (find_methods): Update.
7194         * minsyms.c (find_solib_trampoline_target): Update.
7195         * maint.c (maintenance_info_sections)
7196         (maintenance_translate_address, count_symtabs_and_blocks):
7197         Update.
7198         * main.c (captured_main_1): Update.
7199         * linux-thread-db.c (try_thread_db_load_from_pdir)
7200         (has_libpthread): Update.
7201         * linespec.c (iterate_over_all_matching_symtabs)
7202         (search_minsyms_for_name): Update.
7203         * jit.c (jit_find_objf_with_entry_addr): Update.
7204         * hppa-tdep.c (find_unwind_entry)
7205         (hppa_lookup_stub_minimal_symbol): Update.
7206         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7207         Update.
7208         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7209         (elf_gnu_ifunc_resolve_by_got): Update.
7210         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7211         * dwarf-index-write.c (save_gdb_index_command): Update.
7212         * cp-support.c (add_symbol_overload_list_qualified): Update.
7213         * breakpoint.c (create_overlay_event_breakpoint)
7214         (create_longjmp_master_breakpoint)
7215         (create_std_terminate_master_breakpoint)
7216         (create_exception_master_breakpoint): Update.
7217         * blockframe.c (find_pc_partial_function): Update.
7218         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7219         (ada_collect_symbol_completion_matches)
7220         (ada_add_global_exceptions): Update.
7221
7222 2019-01-17  Tom Tromey  <tom@tromey.com>
7223
7224         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7225         declare VEC.
7226         (solib_target_parse_libraries): Change return type.
7227         (library_list_start_segment, library_list_start_section)
7228         (library_list_end_library, library_list_start_library); Update.
7229         (solib_target_free_library_list): Remove.
7230         (solib_target_parse_libraries): Remove cleanup.  Change return
7231         type.
7232         (solib_target_current_sos): Update.
7233
7234 2019-01-17  Tom Tromey  <tromey@bapiya>
7235
7236         * valprint.c: Replace "the the" with "the".
7237         * symtab.c: Replace "the the" with "the".
7238         * solib.c: Replace "the the" with "the".
7239         * solib-dsbt.c: Replace "the the" with "the".
7240         * linespec.c: Replace "the the" with "the".
7241         * dwarf2loc.h: Replace "the the" with "the".
7242         * amd64-windows-tdep.c: Replace "the the" with "the".
7243         * aarch64-tdep.c: Replace "the the" with "the".
7244
7245 2019-01-16  Keith Seitz  <keiths@redhat.com>
7246
7247         PR gdb/23773
7248         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7249         <builder>: Rename to ..
7250         <m_builder>: ... this and make private.
7251         (dwarf2_cu::get_builder): New method.  Change all users of
7252         `builder' to use this method.
7253         (dwarf2_start_symtab): Move to ...
7254         (dwarf2_cu::start_symtab): ... here.  Update all callers
7255         (setup_type_unit_groups): Move to ...
7256         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7257         callers.
7258         (dwarf2_cu::reset_builder): New method.
7259         (process_full_compunit, process_full_type_unit): Use
7260         dwarf2_cu::reset_builder.
7261         (follow_die_offset): Record the ancestor CU if it is different
7262         from the followed DIE's CU.
7263         (follow_die_sig_1): Likewise.
7264
7265 2019-01-15  Tom Tromey  <tom@tromey.com>
7266
7267         * remote.c (class remote_state) <buf>: Now a char_vector.
7268         <buf_size>: Remove.
7269         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7270         parameter.
7271         (remote_target::getpkt_or_notif_sane_1)
7272         (remote_target::getpkt_sane)
7273         (remote_target::getpkt_or_notif_sane): Likewise.
7274         (class remote_target) <putpkt>: New overload.
7275         (remote_target::read_frame): Change type of "buf_p".  Remove
7276         sizeof_p parameter.
7277         (packet_ok): New overload.
7278         (packet_check_result): New overload.
7279         Update all uses.
7280
7281 2019-01-14  Tom Tromey  <tom@tromey.com>
7282
7283         * remote-notif.c (handle_notification, remote_notif_ack)
7284         (remote_notif_parse): Make "buf" const.
7285         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7286         const.
7287         (remote_notif_parse, remote_notif_ack, handle_notification):
7288         Likewise.
7289         * remote.c (remote_notif_stop_parse): Make "buf" const.
7290         (remote_target::remote_parse_stop_reply): Make "buf" const.
7291         (remote_notif_stop_ack): Make "buf" const.
7292
7293 2019-01-14  Tom Tromey  <tom@tromey.com>
7294
7295         * remote.c (remote_console_output): Make parameter const.
7296
7297 2019-01-14  Tom Tromey  <tom@tromey.com>
7298
7299         * target-debug.h (target_debug_print_signals): Constify.
7300         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7301         * procfs.c (procfs_target::pass_signals): Update.
7302         * linux-nat.c (linux_nat_target::pass_signals): Update.
7303         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7304         * target-delegates.c: Rebuild.
7305         * remote.c (remote_target::program_signals): Update.
7306         (remote_target::pass_signals): Update.
7307         * target.c (target_pass_signals): Constify argument.
7308         (target_program_signals): Likewise.
7309         * target.h (struct target_ops) <pass_signals, program_signals>:
7310         Constify argument.
7311         (target_pass_signals, target_program_signals): Constify argument.
7312
7313 2019-01-14  Tom Tromey  <tom@tromey.com>
7314
7315         PR tui/28819:
7316         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7317
7318 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7319
7320         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7321         field.
7322         * rs6000-tdep.c: Include reggroups.h.
7323         (IS_V_ALIAS_PSEUDOREG): Define.
7324         (rs6000_register_name): Return names for the "vX" aliases.
7325         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7326         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7327         aliases.  Call default_register_reggroup_p for all other
7328         pseudo-registers.
7329         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7330         New functions.
7331         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7332         Handle "vX" aliases.
7333         (v_alias_pseudo_register_collect): New function.
7334         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7335         (rs6000_gdbarch_init): Initialize "vX" aliases as
7336         pseudo-registers.  Restore registration of
7337         rs6000_pseudo_register_reggroup_p with
7338         set_tdesc_pseudo_register_reggroup_p.
7339
7340 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7341
7342         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7343         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7344         set_gdbarch_num_pseudo_regs.
7345
7346 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7347
7348         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7349         Remove arg prefixname, add do_set and do_show.
7350         Add member functions set_list and show_list.
7351         * cli/cli-style.c (class cli_style_option): Update accordingly.
7352         (style_set_list): Move to file scope.
7353         (style_show_list): Likewise.
7354         (set_style): Call help_list.
7355         (show_style): Call cmd_show_list.
7356         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7357         Update to use the new macro.
7358
7359 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7360
7361         * ada-lang.c (_initialize_ada_language): Expand the help text
7362         for the "catch exception" command.
7363
7364 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7365
7366         * symtab.c (matching_obj_sections): Initialize obj,
7367         declare it closer to its usage.
7368
7369 2019-01-10  Tom Tromey  <tom@tromey.com>
7370
7371         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7372         (basic_inf_threads_range): Remove.
7373         (inf_threads_range, inf_non_exited_threads_range)
7374         (safe_inf_threads_range): Use next_adapter.
7375
7376 2019-01-10  Keith Seitz  <keiths@redhat.com>
7377
7378         PR gdb/23712
7379         PR symtab/23010
7380         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7381         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7382
7383 2019-01-10  Keith Seitz  <keiths@redhat.com>
7384
7385         PR gdb/23712
7386         PR symtab/23010
7387         * dictionary.c (pending_to_vector): Remove.
7388         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7389         Remove _1 suffix, replacing functions of the same name.  Update
7390         all callers.
7391         (dict_create_hashed, dict_create_hashed_expandable)
7392         (dict_create_linear, dict_create_linear_expandable, dict_free)
7393         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7394         Make functions static.
7395
7396 2019-01-10  Keith Seitz  <keiths@redhat.com>
7397
7398         PR gdb/23712
7399         PR symtab/23010
7400         * dictionary.h (struct dictionary): Replace declaration with
7401         multidictionary.
7402         (dict_create_hashed, dict_create_hashed_expandable)
7403         (dict_create_linear, dict_create_linear_expandable)
7404         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7405         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7406         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7407         taking multidictionary argument.
7408         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7409         * block.h (struct block) <dict>: Change to multidictionary
7410         and rename `multidict'.
7411         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7412         symmisc.c: Update all dictionary references to multidictionary.
7413
7414 2019-01-10  Keith Seitz  <keiths@redhat.com>
7415
7416         PR gdb/23712
7417         PR symtab/23010
7418         * dictionary.c: Include unordered_map.
7419         (pending_to_vector): New function.
7420         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7421         Rewrite the non-"_1" functions to take vector instead
7422         of linked list.
7423         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7424         "new" _1 versions of the same name.
7425         (multidictionary): Define.
7426         (std::hash<enum language): New definition.
7427         (collate_pending_symbols_by_language, mdict_create_hashed)
7428         (mdict_create_hashed_expandable, mdict_create_linear)
7429         (mdict_create_linear_expandable, mdict_free)
7430         (find_language_dictionary, create_new_language_dictionary)
7431         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7432         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7433         (mdict_size, mdict_empty): New functions.
7434         * dictionary.h (mdict_iterator): Define.
7435
7436 2019-01-10  Pedro Alves  <palves@redhat.com>
7437
7438         * breakpoint.c (read_uploaded_action)
7439         (create_tracepoint_from_upload): Adjust to use
7440         gdb::unique_xmalloc_ptr.
7441         * ctf.c (ctf_write_uploaded_tp):
7442         (SET_ARRAY_FIELD): Use emplace_back.
7443         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7444         * tracefile-tfile.c (tfile_write_uploaded_tp):
7445         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7446         gdb::unique_xmalloc_ptr.
7447         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7448         at_string, cond_string, cmd_strings>: Replace char pointers
7449         with gdb::unique_xmalloc_ptr.
7450
7451 2019-01-10  Pedro Alves  <palves@redhat.com>
7452
7453         * solib-target.c (library_list_start_library): Don't xstrdup name.
7454
7455 2019-01-10  Pedro Alves  <palves@redhat.com>
7456
7457         * mdebugread.c (parse_partial_symbols): Use
7458         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7459
7460 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7461
7462         * linux-fork.c (scoped_switch_fork_info)
7463         <~scoped_switch_fork_info>: Fix incorrect variable name.
7464
7465 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7466
7467         * linux-fork.c (scoped_switch_fork_info)
7468         <scoped_switch_fork_info>: Make explicit.
7469         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7470
7471 2019-01-10  Tom Tromey  <tom@tromey.com>
7472
7473         * objfiles.h (objfile::reset_psymtabs): Update.
7474         * objfiles.c (objfile::objfile): Update.
7475         * psymtab.h (psymtab_storage::obstack): Update.
7476         (psymtab_storage::m_obstack): Use gdb::optional.
7477         (class psymtab_storage): Update comment.  Remove objfile
7478         parameter.
7479         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7480
7481 2019-01-10  Tom Tromey  <tom@tromey.com>
7482
7483         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7484         <free_psymtabs>: Now private.
7485         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7486         (allocate_psymtab): Use new method.
7487
7488 2019-01-10  Tom Tromey  <tom@tromey.com>
7489
7490         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7491         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7492         * mdebugread.c (parse_partial_symbols): Use
7493         allocate_dependencies.
7494         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7495         allocate_dependencies.
7496         (process_psymtab_comp_unit_reader)
7497         (build_type_psymtab_dependencies): Likewise.
7498         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7499
7500 2019-01-10  Tom Tromey  <tom@tromey.com>
7501
7502         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7503         PSYMBOL_SET_LANGUAGE.
7504         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7505
7506 2019-01-10  Tom Tromey  <tom@tromey.com>
7507
7508         * psymtab.h (psymtab_storage::obstack): New method.
7509         <m_obstack>: Rename from obstack; now private.
7510         * psymtab.c (psymtab_storage): Update.
7511         * dwarf2read.c (create_addrmap_from_index)
7512         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7513         Update.
7514
7515 2019-01-10  Tom Tromey  <tom@tromey.com>
7516
7517         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7518         * objfiles.h (objfile::reset_psymtabs): New method.
7519
7520 2019-01-10  Tom Tromey  <tom@tromey.com>
7521
7522         * symmisc.c (print_symbol_bcache_statistics): Update.
7523         (print_objfile_statistics): Update.
7524         * symfile.c (reread_symbols): Update.
7525         * psymtab.h (class psymtab_storage): New.
7526         * psymtab.c (psymtab_storage): New constructor.
7527         (~psymtab_storage): New destructor.
7528         (require_partial_symbols): Update.
7529         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7530         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7531         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7532         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7533         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7534         (start_psymtab_common, end_psymtab_common)
7535         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7536         (allocate_psymtab): Update.
7537         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7538         Update.
7539         (dump_psymtab_addrmap, maintenance_print_psymbols)
7540         (maintenance_check_psymtabs): Update.
7541         (class objfile_psymtabs): Move to objfiles.h.
7542         * psympriv.h (discard_psymtab): Now inline.
7543         (psymtab_discarder::psymtab_discarder): Update.
7544         (psymtab_discarder::~psymtab_discarder): Update.
7545         (ALL_OBJFILE_PSYMTABS): Rewrite.
7546         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7547         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7548         Remove fields.
7549         <partial_symtabs>: New field.
7550         (class objfile_psymtabs): Move from psymtab.h.  Update.
7551         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7552         psymbol_cache.
7553         (objfile::~objfile): Don't destroy psymbol_cache.
7554         * mdebugread.c (parse_partial_symbols): Update.
7555         * dwarf2read.c (create_addrmap_from_index)
7556         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7557         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7558         (add_partial_subprogram, dwarf2_ranges_read): Update.
7559         * dwarf-index-write.c (write_address_map)
7560         (write_one_signatured_type, recursively_write_psymbols)
7561         (class debug_names, class debug_names, write_psymtabs_to_index):
7562         Update.
7563
7564 2019-01-10  Tom Tromey  <tom@tromey.com>
7565
7566         * symtab.h (SYMBOL_SET_NAMES): Update.
7567         (symbol_set_names): Update.
7568         (MSYMBOL_SET_NAMES): Update.
7569         * symtab.c (symbol_set_names): Change argument to be an
7570         objfile_per_bfd_storage.
7571         * psymtab.c (add_psymbol_to_bcache): Update.
7572         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7573
7574 2019-01-10  Tom Tromey  <tom@tromey.com>
7575
7576         * symtab.c (create_demangled_names_hash): Change argument to be an
7577         objfile_per_bfd_storage.
7578         (symbol_set_names): Update.
7579
7580 2019-01-10  Tom Tromey  <tom@tromey.com>
7581
7582         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7583         init_psymbol_list.
7584         * psymtab.c (init_psymbol_list): Do nothing if already called.
7585         * psympriv.h (init_psymbol_list): Add comment.
7586         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7587         init_psymbol_list.
7588         * dbxread.c (dbx_symfile_read): Unconditionally call
7589         init_psymbol_list.
7590
7591 2019-01-10  Tom Tromey  <tom@tromey.com>
7592
7593         * xcoffread.c (scan_xcoff_symtab): Update.
7594         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7595         "where".
7596         * mdebugread.c (parse_partial_symbols)
7597         (handle_psymbol_enumerators): Update.
7598         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7599         * dbxread.c (read_dbx_symtab): Update.
7600         * psympriv.h (psymbol_placement): New enum.
7601         (add_psymbol_to_list): Update.
7602
7603 2019-01-10  Tom Tromey  <tom@tromey.com>
7604
7605         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7606         static_psymbols parameters.
7607         (scan_xcoff_symtab): Update.
7608         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7609         static_psymbols parameters.
7610         * psympriv.h (start_psymtab_common): Update.
7611         * mdebugread.c (parse_partial_symbols): Update.
7612         * dwarf2read.c (create_partial_symtab): Update.
7613         * dbxread.c (read_dbx_symtab): Update.
7614         (start_psymtab): Remove global_psymbols and static_psymbols
7615         parameters.
7616
7617 2019-01-10  Tom Tromey  <tom@tromey.com>
7618
7619         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7620         * psymtab.c (allocate_psymtab): Add comment.
7621         * psympriv.h (allocate_psymtab): Add comment.
7622         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7623         initializations.
7624         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7625
7626 2019-01-10  Tom Tromey  <tom@tromey.com>
7627
7628         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7629         Don't declare.
7630         * mipsread.c: Include mdebugread.h.
7631         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7632         Declare.
7633         * elfread.c: Include mdebugread.h.
7634
7635 2019-01-09  Tom Tromey  <tom@tromey.com>
7636
7637         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7638         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7639         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7640         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7641         (psym_lookup_symbol, psym_find_last_source_symtab)
7642         (psym_forget_cached_source_info, psym_print_stats)
7643         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7644         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7645         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7646         (psym_find_compunit_symtab_by_address)
7647         (maintenance_print_psymbols, maintenance_info_psymtabs)
7648         (maintenance_check_psymtabs): Use ranged for.
7649         * psymtab.h (class objfile_psymtabs): New.
7650         (require_partial_symbols): Return objfile_psymtabs.
7651         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7652
7653 2019-01-09  Tom Tromey  <tom@tromey.com>
7654
7655         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7656         (find_pc_mapped_section, list_overlays_command)
7657         (map_overlay_command, unmap_overlay_command)
7658         (simple_overlay_update): Use all_objfiles.
7659         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7660         * printcmd.c (info_symbol_command): Use all_objfiles.
7661         * objfiles.h (ALL_OBJSECTIONS): Remove.
7662         * maint.c (maintenance_translate_address): Use all_objfiles.
7663         * gcore.c (gcore_create_callback): Use all_objfiles.
7664         (objfile_find_memory_regions): Likewise.
7665
7666 2019-01-09  Tom Tromey  <tom@tromey.com>
7667
7668         * symtab.c (find_line_symtab, info_sources_command)
7669         (make_source_files_completion_list): Use objfile_compunits.
7670         * source.c (select_source_symtab): Use objfile_compunits.
7671         * objfiles.h (struct objfile): Update comment.
7672         (ALL_OBJFILES): Remove.
7673         (ALL_FILETABS): Remove.
7674         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7675         objfile_compunits.
7676
7677 2019-01-09  Tom Tromey  <tom@tromey.com>
7678
7679         * symmisc.c (print_objfile_statistics, dump_objfile)
7680         (maintenance_print_symbols): Use compunit_filetabs.
7681         * source.c (forget_cached_source_info_for_objfile): Use
7682         compunit_filetabs.
7683         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7684         (ALL_FILETABS): Use compunit_filetabs.
7685         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7686         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7687
7688 2019-01-09  Tom Tromey  <tom@tromey.com>
7689
7690         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7691         (compunit_filetabs): New.
7692         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7693         compunit_filetabs.
7694         (info_sources_command, make_source_files_completion_list): Remove
7695         declaration.
7696         * symmisc.c (print_objfile_statistics, dump_objfile)
7697         (maintenance_print_symbols): Remove declaration.
7698         (maintenance_info_symtabs): Use compunit_filetabs.
7699         (maintenance_info_line_tables): Likewise.
7700         * source.c (select_source_symtab): Change local variable name.
7701         (forget_cached_source_info_for_objfile): Remove declaration.
7702         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7703         * objfiles.c (objfile_relocate1): Remove declaration.
7704         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7705         declaration.
7706         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7707         * coffread.c (coff_symtab_read): Remove declaration.
7708         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7709         compunit_filetabs.
7710
7711 2019-01-09  Tom Tromey  <tom@tromey.com>
7712
7713         * symtab.c (lookup_objfile_from_block)
7714         (find_pc_sect_compunit_symtab, search_symbols)
7715         (default_collect_symbol_completion_matches_break_on): Use
7716         objfile_compunits.
7717         * objfiles.h (ALL_COMPUNITS): Remove.
7718         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7719         * cp-support.c (add_symbol_overload_list_qualified): Use
7720         objfile_compunits.
7721         * ada-lang.c (ada_collect_symbol_completion_matches)
7722         (ada_add_global_exceptions): Use objfile_compunits.
7723
7724 2019-01-09  Tom Tromey  <tom@tromey.com>
7725
7726         * source.c (select_source_symtab)
7727         (forget_cached_source_info_for_objfile): Remove declaration.
7728         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7729         declaration.
7730         * maint.c (count_symtabs_and_blocks): Remove declaration.
7731         * cp-support.c (add_symbol_overload_list_qualified): Remove
7732         declaration.
7733         * coffread.c (coff_symtab_read): Remove declaration.
7734         * symtab.c (lookup_symbol_in_objfile_symtabs)
7735         (basic_lookup_transparent_type_1): Use objfile_compunits.
7736         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7737         (info_sources_command, search_symbols)
7738         (default_collect_symbol_completion_matches_break_on)
7739         (make_source_files_completion_list): Remove declaration.
7740         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7741         (ada_collect_symbol_completion_matches)
7742         (ada_add_global_exceptions): Remove declaration.
7743         * linespec.c (iterate_over_all_matching_symtabs): Use
7744         objfile_compunits.
7745         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7746         (class objfile_compunits): New.
7747         (ALL_COMPUNITS): Use objfile_compunits.
7748         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7749         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7750         objfile_compunits.
7751         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7752
7753 2019-01-09  Tom Tromey  <tom@tromey.com>
7754
7755         * symtab.c (search_symbols)
7756         (default_collect_symbol_completion_matches_break_on): Use
7757         objfile_msymbols.
7758         * ada-lang.c (ada_lookup_simple_minsym)
7759         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7760         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7761         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7762         objfile_msymbols.
7763         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7764         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7765         * objc-lang.c (find_methods): Use objfile_msymbols.
7766         (info_selectors_command, info_classes_command): Likewise.
7767         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7768         * objfiles.h (class objfile_msymbols): New.
7769         (ALL_OBJFILE_MSYMBOLS): Remove.
7770         (ALL_MSYMBOLS): Remove.
7771
7772 2019-01-09  Tom Tromey  <tom@tromey.com>
7773
7774         * common/next-iterator.h (next_adapter): Add Iterator template
7775         parameter.
7776         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7777         (class all_objfiles_safe): New.
7778         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7779         * objfiles.c (put_objfile_before): Update comment.
7780         (add_separate_debug_objfile): Likewise.
7781         (free_all_objfiles): Use all_objfiles_safe.
7782         (objfile_purge_solibs): Likewise.
7783
7784 2019-01-09  Tom Tromey  <tom@tromey.com>
7785
7786         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7787         (expand_symtab_containing_pc, lookup_static_symbol)
7788         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7789         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7790         all_objfiles.
7791         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7792         * breakpoint.c (create_overlay_event_breakpoint)
7793         (create_longjmp_master_breakpoint)
7794         (create_std_terminate_master_breakpoint)
7795         (create_exception_master_breakpoint): Use all_objfiles.
7796         * linux-thread-db.c (try_thread_db_load_from_pdir)
7797         (has_libpthread): Use all_objfiles.
7798         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7799         * linespec.c (iterate_over_all_matching_symtabs)
7800         (search_minsyms_for_name): Use all_objfiles.
7801         * maint.c (maintenance_info_sections): Use all_objfiles.
7802         * main.c (captured_main_1): Use all_objfiles.
7803         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7804         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7805         * guile/scm-pretty-print.c
7806         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7807         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7808         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7809         (maintenance_print_msymbols): Use all_objfiles.
7810         * source.c (select_source_symtab): Use all_objfiles.
7811         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7812         * symfile.c (remove_symbol_file_command)
7813         (expand_symtabs_matching, map_symbol_filenames): Use
7814         all_objfiles.
7815         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7816         all_objfiles.
7817         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7818         * objc-lang.c (find_methods): Use all_objfiles.
7819         * objfiles.c (have_partial_symbols, have_full_symbols)
7820         (have_minimal_symbols, qsort_cmp)
7821         (default_iterate_over_objfiles_in_search_order): Use
7822         all_objfiles.
7823         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7824         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7825         (maintenance_check_psymtabs): Use all_objfiles.
7826         (ALL_PSYMTABS): Remove.
7827         * compile/compile-object-run.c (do_module_cleanup): Use
7828         all_objfiles.
7829         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7830         * cp-support.c (add_symbol_overload_list_qualified): Use
7831         all_objfiles.
7832         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7833         Use all_objfiles.
7834         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7835         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7836         all_objfiles.
7837         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7838         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7839         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7840         Uses all_objfiles.
7841         * solib.c (solib_read_symbols): Use all_objfiles
7842
7843 2019-01-09  Tom Tromey  <tom@tromey.com>
7844
7845         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7846         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7847         all_objfiles.
7848         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7849         * symmisc.c (print_symbol_bcache_statistics)
7850         (print_objfile_statistics, maintenance_print_objfiles)
7851         (maintenance_info_symtabs, maintenance_check_symtabs)
7852         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7853         all_objfiles.
7854         * source.c (forget_cached_source_info): Use all_objfiles.
7855         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7856         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7857         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7858         * objfiles.c (update_section_map): Use all_objfiles.
7859         (shared_objfile_contains_address_p): Likewise.
7860         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7861         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7862
7863 2019-01-09  Tom Tromey  <tom@tromey.com>
7864
7865         * common/next-iterator.h: New file.
7866         * objfiles.h (class all_objfiles): New.
7867         (struct objfile_iterator): New.
7868
7869 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7870
7871         * NEWS: Move the description of the changed "frame", "select-frame",
7872          and "info frame" commands to the Changed commands section.
7873
7874 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7875
7876         * gdbtypes.c (check_stub_method_group): Remove handling of old
7877         mangling schemes.
7878         * linespec.c (find_methods): Likewise.
7879         * stabsread.c (read_member_functions): Likewise.
7880         * valops.c (search_struct_method): Likewise.
7881         (value_struct_elt_for_reference): Likewise.
7882         * NEWS: Mention this change.
7883
7884 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7885
7886         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7887         print_source_lines.
7888         * source.c (print_source_lines_base): Update line number check.
7889         (print_source_lines): New function.
7890         (source_lines_range::source_lines_range): New function.
7891         * source.h (class source_lines_range): New class.
7892         (print_source_lines): New declaration.
7893
7894 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7895
7896         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7897
7898 2019-01-08  Tom Tromey  <tom@tromey.com>
7899             Simon Marchi  <simon.marchi@ericsson.com>
7900
7901         PR gdb/24060
7902         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7903         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7904         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7905         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7906         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7907         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7908
7909 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7910
7911         * source.c (select_source_symtab): Move header comment to
7912         declaration in source.h.
7913         (forget_cached_source_info_for_objfile): Likewise.
7914         (forget_cached_source_info): Likewise.
7915         (identify_source_line): Likewise.
7916         * source.h (identify_source_line): Move declaration from symtab.h
7917         and add comment from source.c
7918         (print_source_lines): Likewise.
7919         (forget_cached_source_info_for_objfile): Likewise.
7920         (forget_cached_source_info): Likewise.
7921         (select_source_symtab): Likewise.
7922         (enum print_source_lines_flag): Move definition from symtab.h.
7923         * symtab.h (identify_source_line): Move declaration to source.h.
7924         (print_source_lines): Likewise.
7925         (forget_cached_source_info_for_objfile): Likewise.
7926         (forget_cached_source_info): Likewise.
7927         (select_source_symtab): Likewise.
7928         (enum print_source_lines_flag): Move definition to source.h.
7929         * tui/tui-hooks.c: Add 'source.h' include.
7930
7931 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7932
7933         * source.c (print_source_lines_base): Handle requests to print
7934         reverse line number sequences, and guard against empty lines
7935         string.
7936
7937 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7938
7939         * source.c (print_source_lines_base): Fix skip of '\r' if next
7940         character is '\n'.
7941
7942 2019-01-06  Tom Tromey  <tom@tromey.com>
7943
7944         * c-exp.y (struct c_parse_state) <macro_original_text,
7945         expansion_obstack>: New member.
7946         (macro_original_text, expansion_obstack): Remove globals.
7947         (scan_macro_expansion, scanning_macro_expansion)
7948         (finished_macro_expansion): Update.
7949         (scan_macro_cleanup): Remove.
7950         (yylex, c_parse): Update.
7951
7952 2019-01-06  Tom Tromey  <tom@tromey.com>
7953
7954         * c-exp.y (struct c_parse_state) <strings>: New member.
7955         (operator_stoken): Update.
7956
7957 2019-01-06  Tom Tromey  <tom@tromey.com>
7958
7959         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7960         (union type_stack_elt) <typelist_val>: Now a pointer to
7961         std::vector.
7962         (type_stack_cleanup): Don't declare.
7963         (push_typelist): Update.
7964         * parse.c (pop_typelist): Return a std::vector.
7965         (push_typelist): Take a std::vector.
7966         (follow_types): Update.  Do not free args.
7967         (type_stack_cleanup): Remove.
7968         * c-exp.y (struct c_parse_state): New.
7969         (cpstate): New global.
7970         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7971         (nonempty_typelist): Update.
7972         (func_mod): Create a new vector.
7973         (c_parse): Create a c_parse_state.
7974         (check_parameter_typelist): Do not delete params.
7975         (function_method): Update.  Do not delete type_list.
7976
7977 2019-01-06  Tom Tromey  <tom@tromey.com>
7978
7979         PR gdb/28155:
7980         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7981         check_typedef.
7982         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7983         (print_return_value): Likewise.
7984
7985 2019-01-05  Tom Tromey  <tom@tromey.com>
7986
7987         * contrib/cleanup_check.py: Remove.
7988         * contrib/gcc-with-excheck: Remove.
7989         * contrib/exsummary.py: Remove.
7990         * contrib/excheck.py: Remove.
7991
7992 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7993
7994         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7995         NULL. Initialize tpprev to NULL instead of assigning it
7996         to NULL on the next statement.
7997         * windows-nat.c (windows_delete_thread): Remove check for
7998         main_thread_id before printing thread exit notifications.
7999         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8000         Remove thread ID check against main_thread_id.
8001         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8002         windows_delete_thread.
8003         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8004
8005 2019-01-04  Tom Tromey  <tom@tromey.com>
8006
8007         * compile/compile.c (_initialize_compile): Use upper case for
8008         metasyntactic variables.
8009         * symmisc.c (_initialize_symmisc): Use upper case for
8010         metasyntactic variables.
8011         * psymtab.c (_initialize_psymtab): Use upper case for
8012         metasyntactic variables.
8013         * demangle.c (demangle_command): Use upper case for metasyntactic
8014         variables.
8015         (_initialize_demangler): Likewise.
8016         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8017         variables.
8018
8019 2019-01-03  Tom Tromey  <tom@tromey.com>
8020
8021         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8022
8023 2019-01-03  Tom Tromey  <tom@tromey.com>
8024
8025         * python/py-symtab.c (salpy_str): Update.
8026         (struct salpy_sal_object) <symtab>: Now a PyObject.
8027         (salpy_dealloc): Update.
8028         (del_objfile_sal): Use gdbpy_ref.
8029
8030 2019-01-03  Tom Tromey  <tom@tromey.com>
8031
8032         * python/py-type.c (convert_field): Use new_reference.  Return
8033         gdbpy_ref.
8034         (make_fielditem): Return gdbpy_ref.
8035         (typy_fields): Update.
8036         (typy_getitem): Update.
8037         (field_name): Return gdbpy_ref.  Use new_reference.
8038         (typy_iterator_iternext): Update.
8039
8040 2019-01-03  Tom Tromey  <tom@tromey.com>
8041
8042         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8043
8044 2019-01-03  Tom Tromey  <tom@tromey.com>
8045
8046         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8047         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8048         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8049         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8050         (pspy_set_type_printers): Likewise.
8051         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8052         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8053         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8054         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8055         (objfpy_set_type_printers): Likewise.
8056
8057 2019-01-03  Tom Tromey  <tom@tromey.com>
8058
8059         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8060         (gdbpy_print_stack): Use gdbpy_err_fetch.
8061         * python/python-internal.h (class gdbpy_err_fetch): New class.
8062         (class gdbpy_enter) <m_error_type, m_error_value,
8063         m_error_traceback>: Remove.
8064         <m_error>: New member.
8065         (gdbpy_exception_to_string): Don't declare.
8066         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8067         * python/py-value.c (convert_value_from_python): Use
8068         gdbpy_err_fetch.
8069         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8070         gdbpy_exception_to_string.
8071         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8072         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8073         gdbpy_err_fetch.
8074
8075 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8076
8077         * linux-nat.c (delete_lwp_cleanup): Delete.
8078         (struct lwp_deleter): New struct.
8079         (lwp_info_up): New typedef.
8080         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8081         lwp_info_up.
8082
8083 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8084
8085         * linux-fork.c (class scoped_switch_fork_info): New class.
8086         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8087
8088 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8089
8090         * valops.c (find_overload_match): Remove use of null_cleanup, and
8091         calls to do_cleanups.
8092
8093 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8094
8095         * compile/compile-cplus-types.c
8096         (compile_cplus_instance::decl_name): Handle changes to
8097         cp_func_name.
8098         * cp-support.c (cp_func_name): Update header comment, update
8099         return type.
8100         * cp-support.h (cp_func_name): Update return type in declaration.
8101         * valops.c (find_overload_match): Move temp_func local to top
8102         level of function and change its type.  Use temp_func to hold and
8103         delete temporary string obtained from cp_func_name.
8104
8105 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8106
8107         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8108         gdb::char_vector, remove cleanup, and update uses of `msg`.
8109
8110 2019-01-03  Jim Wilson  <jimw@sifive.com>
8111
8112         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8113
8114 2019-01-02  Tom Tromey  <tom@tromey.com>
8115
8116         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8117         (tdesc_parse_xml): Remove cleanups.
8118         * target-descriptions.h (make_cleanup_free_target_description):
8119         Don't declare.
8120         (target_desc_deleter): New struct.
8121         (target_desc_up): New typedef.
8122         * target-descriptions.c (target_desc_deleter::operator()): Rename
8123         from free_target_description.
8124         (make_cleanup_free_target_description): Remove.
8125
8126 2019-01-02  Tom Tromey  <tom@tromey.com>
8127
8128         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8129         constructor, destructor.
8130         (linespec_parser): Remove typedef.
8131         (~linespec_parser): Rename from linespec_parser_delete.
8132         (linespec_lex_to_end, linespec_complete_label)
8133         (linespec_complete): Update.
8134         (decode_line_full): Remove cleanups.
8135         (decode_line_1): Update.
8136
8137 2019-01-02  Tom Tromey  <tom@tromey.com>
8138
8139         * python/python-internal.h (inferior_to_inferior_object): Change
8140         return type.
8141         * python/py-exitedevent.c (create_exited_event_object): Update.
8142         * python/py-inferior.c (inferior_to_inferior_object): Return
8143         gdbpy_ref.
8144         (python_new_inferior, python_inferior_deleted)
8145         (thread_to_thread_object, delete_thread_object)
8146         (build_inferior_list, gdbpy_selected_inferior): Update.
8147         * python/py-infthread.c (create_thread_object): Update.  Also fail
8148         if inferior_to_inferior_object fails.
8149
8150 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8151
8152         * inferior.h (class inferior) <displaced_step_state>: New field.
8153         * infrun.h (struct displaced_step_state): Move here from
8154         infrun.c.  Initialize fields, add constructor.
8155         <inf>: Remove field.
8156         <reset>: New method.
8157         * infrun.c (struct displaced_step_inferior_state): Move to
8158         infrun.h.
8159         (displaced_step_inferior_states): Remove.
8160         (get_displaced_stepping_state): Adust.
8161         (displaced_step_in_progress_any_inferior): Adjust.
8162         (displaced_step_in_progress_thread): Adjust.
8163         (displaced_step_in_progress): Adjust.
8164         (add_displaced_stepping_state): Remove.
8165         (get_displaced_step_closure_by_addr): Adjust.
8166         (remove_displaced_stepping_state): Remove.
8167         (infrun_inferior_exit): Call displaced_step_state.reset.
8168         (use_displaced_stepping): Don't check for NULL.
8169         (displaced_step_prepare_throw): Call
8170         get_displaced_stepping_state.
8171         (displaced_step_fixup): Don't check for NULL.
8172         (prepare_for_detach): Don't check for NULL.
8173
8174 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8175
8176         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8177          in case of call that did not complete.
8178
8179 2019-01-02  Andrey Utkin  <autkin@undo.io>
8180
8181         * symfile.c (find_separate_debug_file): Fix search of debug files for
8182         remote debuggee.
8183
8184 2019-01-02  Tom Tromey  <tom@tromey.com>
8185
8186         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8187         indentation.
8188         * python/py-frame.c (frapy_older): Remove cast.
8189         (frapy_newer): Likewise.
8190         * python/py-breakpoint.c (local_setattro): Remove cast.
8191         * python/py-arch.c (archpy_name): Remove local variable.
8192         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8193
8194 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8195
8196         * unittests/basic_string_view/element_access/char/empty.cc:
8197         Fix year range in copyright header.
8198
8199 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8200
8201         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8202         Delete.
8203         <operator==>: Update with for removed field.
8204         <hash>: Likewise.
8205         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8206         <isa_features>: ...this.
8207         <abi_features>: New field.
8208         (riscv_isa_flen): Update comment.
8209         (riscv_abi_xlen): New declaration.
8210         (riscv_abi_flen): New declaration.
8211         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8212         isa_features.
8213         (riscv_abi_xlen): New function.
8214         (riscv_isa_flen): Update to get answer from isa_features.
8215         (riscv_abi_flen): New function.
8216         (riscv_has_fp_abi): Update to get answer from abi_features.
8217         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8218         xlen and flen.
8219         (riscv_call_info) <xlen, flen>: Update comment.
8220         (riscv_call_arg_struct): Remove invalid assertions
8221         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8222         is removed.
8223         (riscv_gdbarch_init): Gather isa features and abi features
8224         separately, ensure both match on the gdbarch when reusing an old
8225         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8226         a target with 64-bit float hardware.
8227
8228 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8229
8230         * source.c (search_command_helper): Stop reverse search
8231         when line 1 has been searched.
8232
8233 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8234
8235         * record-full.c (record_full_base_target::close): Rewrite
8236         record_full_core_buf_list free logic.
8237
8238 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8239
8240         * break-catch-syscall.c (print_one_catch_syscall): xfree
8241         the last text.
8242
8243 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8244
8245         * top.c (print_gdb_version): Update Copyright year in version
8246         message.
8247
8248 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8249
8250         Update copyright year range in all GDB files.
8251
8252 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8253
8254         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8255
8256 For older changes see ChangeLog-2018.
8257 \f
8258 Local Variables:
8259 mode: change-log
8260 left-margin: 8
8261 fill-column: 74
8262 version-control: never
8263 coding: utf-8
8264 End:
8265