gdb/ChangeLog

   1 2019-04-04  Tom Tromey  <tom@tromey.com>
   2
   3         * varobj.c (varobj_create): Update.
   4         * rust-exp.y (struct rust_parser) <update_innermost_block,
   5         lookup_symbol>: New methods.
   6         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
   7         Rename.
   8         (rust_parser::rust_lookup_type)
   9         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
  10         * printcmd.c (display_command, do_one_display): Update.
  11         * parser-defs.h (struct parser_state) <parser_state>: Add
  12         "tracker" parameter.
  13         (block_tracker): New member.
  14         (class innermost_block_tracker) <innermost_block_tracker>: Add
  15         "types" parameter.
  16         <reset>: Remove method.
  17         (innermost_block): Don't declare.
  18         (null_post_parser): Update.
  19         * parse.c (innermost_block): Remove global.
  20         (write_dollar_variable): Update.
  21         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
  22         Remove "tracker_types" parameter.
  23         (parse_expression): Add "tracker" parameter.
  24         (parse_expression_for_completion): Update.
  25         (null_post_parser): Add "tracker" parameter.
  26         * p-exp.y: Update rules.
  27         * m2-exp.y: Update rules.
  28         * language.h (struct language_defn) <la_post_parser>: Add
  29         "tracker" parameter.
  30         * go-exp.y: Update rules.
  31         * f-exp.y: Update rules.
  32         * expression.h (parse_expression, parse_exp_1): Add "tracker"
  33         parameter.
  34         * d-exp.y: Update rules.
  35         * c-exp.y: Update rules.
  36         * breakpoint.c (set_breakpoint_condition): Create an
  37         innermost_block_tracker.
  38         (watch_command_1): Likewise.
  39         * ada-lang.c (resolve): Add "tracker" parameter.
  40         (resolve_subexp): Likewise.
  41         * ada-exp.y (write_var_from_sym): Update.
  42
  43 2019-04-04  Tom Tromey  <tom@tromey.com>
  44
  45         * type-stack.h: New file.
  46         * type-stack.c: New file.
  47         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
  48         type-stack.h.
  49         (insert_into_type_stack, insert_type, push_type, push_type_int)
  50         (insert_type_address_space, pop_type, pop_type_int)
  51         (pop_typelist, pop_type_stack, append_type_stack)
  52         (push_type_stack, get_type_stack, push_typelist)
  53         (follow_type_instance_flags, follow_types): Don't declare.
  54         * parse.c (type_stack): Remove global.
  55         (parse_exp_in_context): Update.
  56         (insert_into_type_stack, insert_type, push_type, push_type_int)
  57         (insert_type_address_space, pop_type, pop_type_int)
  58         (pop_typelist, pop_type_stack, append_type_stack)
  59         (push_type_stack, get_type_stack, push_typelist)
  60         (follow_type_instance_flags, follow_types): Remove (moved to
  61         type-stack.c).
  62         * f-exp.y (type_stack): New global.
  63         Update rules.
  64         (push_kind_type, f_parse): Update.
  65         * d-exp.y (type_stack): New global.
  66         Update rules.
  67         (d_parse): Update.
  68         * c-exp.y (struct c_parse_state) <type_stack>: New member.
  69         Update rules.
  70         * Makefile.in (COMMON_SFILES): Add type-stack.c.
  71         (HFILES_NO_SRCDIR): Add type-stack.h.
  72
  73 2019-04-04  Tom Tromey  <tom@tromey.com>
  74
  75         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
  76         (rust_parser::convert_ast_to_expression, rust_parse)
  77         (rust_lex_test_completion, rust_lex_tests): Update.
  78         * parser-defs.h (struct expr_completion_state): New.
  79         (struct parser_state) <parser_state>: Add completion parameter.
  80         <mark_struct_expression, mark_completion_tag>: New methods.
  81         <parse_completion, m_completion_state>: New members.
  82         (prefixify_expression, null_post_parser): Update.
  83         (mark_struct_expression, mark_completion_tag): Don't declare.
  84         * parse.c (parse_completion, expout_last_struct)
  85         (expout_tag_completion_type, expout_completion_name): Remove
  86         globals.
  87         (parser_state::mark_struct_expression)
  88         (parser_state::mark_completion_tag): Now methods.
  89         (prefixify_expression): Add last_struct parameter.
  90         (prefixify_subexp): Likewise.
  91         (parse_exp_1): Update.
  92         (parse_exp_in_context): Add cstate parameter.  Update.
  93         (parse_expression_for_completion): Create an
  94         expr_completion_state.
  95         (null_post_parser): Add "completion" parameter.
  96         * p-exp.y: Update rules.
  97         (yylex): Update.
  98         * language.h (struct language_defn) <la_post_parser>: Add
  99         "completing" parameter.
 100         * go-exp.y: Update rules.
 101         (lex_one_token): Update.
 102         * expression.h (parse_completion): Don't declare.
 103         * d-exp.y: Update rules.
 104         (lex_one_token): Update rules.
 105         * c-exp.y: Update rules.
 106         (lex_one_token): Update.
 107         * ada-lang.c (resolve): Add "parse_completion" parameter.
 108         (resolve_subexp): Likewise.
 109         (ada_resolve_function): Likewise.
 110
 111 2019-04-04  Tom Tromey  <tom@tromey.com>
 112
 113         * parser-defs.h (struct parser_state) <start_arglist,
 114         end_arglist>: New methods.
 115         <arglist_len, m_funcall_chain>: New members.
 116         (arglist_len, start_arglist, end_arglist): Don't declare.
 117         * parse.c (arglist_len, funcall_chain): Remove global.
 118         (start_arglist, end_arglist): Remove functions.
 119         (parse_exp_in_context): Update.
 120         * p-exp.y: Update rules.
 121         * m2-exp.y: Update rules.
 122         * go-exp.y: Update rules.
 123         * f-exp.y: Update rules.
 124         * d-exp.y: Update rules.
 125         * c-exp.y: Update rules.
 126
 127 2019-04-04  Tom Tromey  <tom@tromey.com>
 128
 129         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
 130         lex_operator, push_back>: New methods.
 131         Update all rules.
 132         (rust_parser::lex_hex, lex_escape): Rename and update.
 133         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
 134         (rust_parser::lex_operator): Rename and update.
 135         (rust_parser::lex_number, rustyylex, rustyyerror)
 136         (rust_lex_test_init, rust_lex_test_sequence)
 137         (rust_lex_test_push_back, rust_lex_tests): Update.
 138         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
 139         parameter.
 140         <lexptr, prev_lexptr>: New members.
 141         (lexptr, prev_lexptr): Don't declare.
 142         * parse.c (lexptr, prev_lexptr): Remove globals.
 143         (parse_exp_in_context): Update.
 144         * p-exp.y (yylex, yyerror): Update.
 145         * m2-exp.y (parse_number, yylex, yyerror): Update.
 146         * go-exp.y (lex_one_token, yyerror): Update.
 147         * f-exp.y (match_string_literal, yylex, yyerror): Update.
 148         * d-exp.y (lex_one_token, yyerror): Update.
 149         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
 150         (lex_one_token, yyerror): Update.
 151         * ada-lex.l (YY_INPUT): Update.
 152         (rewind_to_char): Update.
 153         * ada-exp.y (yyerror): Update.
 154
 155 2019-04-04  Tom Tromey  <tom@tromey.com>
 156
 157         * rust-exp.y (rustyylex, rust_lex_tests): Update.
 158         * parser-defs.h (struct parser_state) <parser_state>: Add new
 159         parameter.
 160         <comma_terminates>: New member.
 161         (comma_terminates): Don't declare global.
 162         * parse.c (comma_terminates): Remove global.
 163         (parse_exp_in_context): Update.
 164         * p-exp.y (yylex): Update.
 165         * m2-exp.y (yylex): Update.
 166         * go-exp.y (lex_one_token): Update.
 167         * f-exp.y (yylex): Update.
 168         * d-exp.y (lex_one_token): Update.
 169         * c-exp.y (lex_one_token): Update.
 170         * ada-lex.l: Update.
 171
 172 2019-04-04  Tom Tromey  <tom@tromey.com>
 173
 174         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
 175         (rustyylex, rust_lex_test_init, rust_lex_test_one)
 176         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
 177         * parser-defs.h (paren_depth): Don't declare.
 178         * parse.c (paren_depth): Remove global.
 179         (parse_exp_in_context): Update.
 180         * p-exp.y (paren_depth): New global.
 181         (pascal_parse): Initialize it.
 182         * m2-exp.y (paren_depth): New global.
 183         (m2_parse): Initialize it.
 184         * go-exp.y (paren_depth): New global.
 185         (go_parse): Initialize it.
 186         * f-exp.y (paren_depth): New global.
 187         (f_parse): Initialize it.
 188         * d-exp.y (paren_depth): New global.
 189         (d_parse): Initialize it.
 190         * c-exp.y (paren_depth): New global.
 191         (c_parse): Initialize it.
 192         * ada-lex.l (paren_depth): New global.
 193         (lexer_init): Initialize it.
 194
 195 2019-04-04  Tom Tromey  <tom@tromey.com>
 196
 197         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
 198         (rust_parser::convert_ast_to_type)
 199         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
 200         * parser-defs.h (struct parser_state) <parser_state>: Add
 201         parameters.  Initialize new members.
 202         <expression_context_block, expression_context_pc>: New members.
 203         * parse.c (expression_context_block, expression_context_pc):
 204         Remove globals.
 205         (parse_exp_in_context): Update.
 206         * p-exp.y: Update all rules.
 207         (yylex): Update.
 208         * m2-exp.y: Update all rules.
 209         (yylex): Update.
 210         * go-exp.y (yylex): Update.
 211         * f-exp.y (yylex): Update.
 212         * d-exp.y: Update all rules.
 213         (yylex): Update.
 214         * c-exp.y: Update all rules.
 215         (lex_one_token, classify_name, yylex, c_parse): Update.
 216         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
 217
 218 2019-04-04  Tom Tromey  <tom@tromey.com>
 219
 220         * gdbarch.h, gdbarch.c: Rebuild.
 221         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
 222         * stap-probe.h:
 223         (struct stap_parse_info): Replace "parser_state" with
 224         "expr_builder".
 225         * parser-defs.h (struct expr_builder): Rename from "parser_state".
 226         (parser_state): New class.
 227         * parse.c (expr_builder): Rename.
 228         (expr_builder::release): Rename.
 229         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
 230         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
 231         (write_exp_elt_longcst, write_exp_elt_floatcst)
 232         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
 233         (write_exp_string_vector, write_exp_bitstring)
 234         (write_exp_msymbol, mark_struct_expression)
 235         (write_dollar_variable)
 236         (insert_type_address_space, increase_expout_size): Replace
 237         "parser_state" with "expr_builder".
 238         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
 239         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
 240         "parser_state" with "expr_builder".
 241
 242 2019-04-04  Tom Tromey  <tom@tromey.com>
 243
 244         * rust-exp.y: Replace "parse_language" with method call.
 245         * p-exp.y:
 246         (yylex): Replace "parse_language" with method call.
 247         * m2-exp.y:
 248         (yylex): Replace "parse_language" with method call.
 249         * go-exp.y (classify_name): Replace "parse_language" with method
 250         call.
 251         * f-exp.y (yylex): Replace "parse_language" with method call.
 252         * d-exp.y (lex_one_token): Replace "parse_language" with method
 253         call.
 254         * c-exp.y:
 255         (lex_one_token, classify_name, yylex): Replace "parse_language"
 256         with method call.
 257         * ada-exp.y (find_primitive_type, type_char)
 258         (type_system_address): Replace "parse_language" with method call.
 259
 260 2019-04-04  Tom Tromey  <tom@tromey.com>
 261
 262         * rust-exp.y: Replace "parse_gdbarch" with method call.
 263         * parse.c (write_dollar_variable, insert_type_address_space):
 264         Replace "parse_gdbarch" with method call.
 265         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
 266         call.
 267         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
 268         call.
 269         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
 270         "parse_gdbarch" with method call.
 271         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
 272         with method call.
 273         * f-exp.y (parse_type, parse_f_type, yylex): Replace
 274         "parse_gdbarch" with method call.
 275         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
 276         "parse_gdbarch" with method call.
 277         * c-exp.y (parse_type, parse_number, classify_name): Replace
 278         "parse_gdbarch" with method call.
 279         * ada-lex.l: Replace "parse_gdbarch" with method call.
 280         * ada-exp.y (parse_type, find_primitive_type, type_char)
 281         (type_system_address): Replace "parse_gdbarch" with method call.
 282
 283 2019-04-04  Tom Tromey  <tom@tromey.com>
 284
 285         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
 286         * stap-probe.c (stap_parse_argument): Update.
 287         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
 288         initial_size parameter.
 289         * rust-exp.y (rust_lex_tests): Update.
 290         * parse.c (parser_state): Update.
 291         (parse_exp_in_context): Update.
 292         * parser-defs.h (struct parser_state) <parser_state>: Remove
 293         "initial_size" parameter.
 294
 295 2019-04-04  Tom Tromey  <tom@tromey.com>
 296
 297         * parser-defs.h (increase_expout_size): Don't declare.
 298         * parse.c (increase_expout_size): Now static.
 299
 300 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
 301
 302         * gnu-nat.c (gnu_nat_target::wait): Fix
 303         target_waitstatus_to_string call.
 304
 305 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 306
 307         * eval.c (evaluate_subexp_standard): Handle internal functions
 308         during Fortran function call handling.
 309
 310 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 311
 312         * NEWS: Mention new internal functions.
 313         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
 314         (read_base_type): Use dwarf2_init_complex_target_type.
 315         * value.c (creal_internal_fn): New function.
 316         (cimag_internal_fn): New function.
 317         (_initialize_values): Register new internal functions.
 318
 319 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 320
 321         * infrun.c (stop_all_threads): If debug_infrun, always
 322         trace the wait status after wait_one, using
 323         target_waitstatus_to_string and target_pid_to_str.
 324         (handle_inferior_event): Replace various trace of
 325         wait status kind by a single trace.
 326         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
 327         wait status kind image by target_waitstatus_to_string.
 328         * target/waitstatus.c (target_waitstatus_to_string): Fix
 329         obsolete comment.
 330
 331 2019-04-01  Tom Tromey  <tromey@adacore.com>
 332
 333         PR symtab/23331:
 334         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
 335
 336 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
 337             Pedro Alves  <palves@redhat.com>
 338
 339         * top.c (quit_force): Call 'finalize_values'.
 340         * value.c (finalize_values): New function.
 341         * value.h (finalize_values): Declare.
 342
 343 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
 344
 345         * NEWS: Announce $_gdb_major and $_gdb_minor.
 346
 347         * top.c (init_gdb_version_vars): New function.
 348         (gdb_init): Call init_gdb_version_vars.
 349
 350 2019-03-29  Tom Tromey  <tromey@adacore.com>
 351
 352         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
 353         help text.  Remove dead code.
 354
 355 2019-03-29  Keith Seitz  <keiths@redhat.com>
 356
 357         From Siddhesh Poyarekar:
 358         * f-lang.h (f77_get_upperbound): Return LONGEST.
 359         (f77_get_lowerbound): Likewise.
 360         * f-typeprint.c (f_type_print_varspec_suffix): Expand
 361         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
 362         print them.
 363         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
 364         plongest to format print it.
 365         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
 366         (f77_get_upperbound): Likewise.
 367         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
 368         LOWER_BOUND to LONGEST.
 369         (f77_create_arrayprint_offset_tbl): Likewise.
 370
 371 2019-03-29  Keith Seitz  <keiths@redhat.com>
 372
 373         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
 374         %s/pulongest for TYPE_LENGTH instead of %d in format
 375         strings.
 376         * ada-typerint.c (ada_print_type): Likewise.
 377         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
 378         * compile/compile-c-support.c (generate_register_struct): Likewise.
 379         * gdbtypes.c (recursive_dump_type): Likewise.
 380         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
 381         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
 382         instead of %d in format strings.
 383         * riscv-tdep.c (riscv_type_alignment): Cast second argument
 384         to std::min to ULONGEST.
 385         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
 386         instead of %d in format strings.
 387         * tracepoint.c (info_scope_command): Likewise.
 388         * typeprint.c (print_offset_data::update)
 389         (print_offset_data::finish): Likewise.
 390         * xtensa-tdep.c (xtensa_store_return_value)
 391         (xtensa_push_dummy_call): Likewise.
 392
 393 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
 394
 395         * windows-nat.c (display_selector): Fixed format specifications
 396         for 64-bit Cygwin.
 397
 398 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 399
 400         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
 401
 402 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
 403
 404         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
 405         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
 406         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
 407         (nios2_linux_init_abi): Install it.
 408
 409 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
 410
 411         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
 412
 413 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
 414
 415         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
 416
 417 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 418             Tom Tromey  <tromey@adacore.com>
 419
 420         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
 421
 422 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
 423
 424         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
 425         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
 426         method to compute the bounds of range types. Also print "[evaluated]"
 427         if the bounds' values come from a dynamic evaluation.
 428
 429 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 430
 431         * cp-valprint.c (cp_print_value_fields): Don't print trailing
 432         whitespace when pretty printing is on.
 433
 434 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 435
 436         * ppc-linux-nat.c: Add include.
 437
 438 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 439
 440         * NEWS: Mention AArch64 Pointer Authentication.
 441
 442 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
 443
 444         * arm-linux-nat.c: Add include.
 445
 446 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
 447
 448         * source-cache.c (source_cache::get_source_lines): Re-read
 449         fullname after calling open_source_file.
 450
 451 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
 452
 453         * NEWS: Mention TLS support for FreeBSD.
 454
 455 2019-03-25  Tom Tromey  <tromey@adacore.com>
 456
 457         * minsyms.c (BUNCH_SIZE): Update comment.
 458         (~minimal_symbol_reader): Remove old comment.
 459         (compact_minimal_symbols): Update comment.
 460         (minimal_symbol_reader::install): Remove old comment.  Update
 461         other comments.
 462
 463 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 464
 465         * s390-linux-nat.c: Add include.
 466
 467 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
 468
 469         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 470         Call linux_get_hwcap.
 471         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
 472         Likewise.
 473         (aarch64_linux_get_hwcap): Remove function.
 474         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
 475         declaration.
 476         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
 477         linux_get_hwcap.
 478         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 479         * linux-tdep.c (linux_get_hwcap): Add function.
 480         (linux_get_hwcap2): Likewise.
 481         * linux-tdep.h (linux_get_hwcap): Add declaration.
 482         (linux_get_hwcap2): Likewise.
 483         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
 484         (ppc_linux_get_hwcap2): Likewise.
 485         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
 486         linux_get_hwcap.
 487         (ppc_linux_nat_target::insert_watchpoint): Likewise.
 488         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
 489         (ppc_linux_nat_target::read_description): Likewise.
 490         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
 491         * s390-linux-nat.c: Likewise.
 492         * s390-linux-tdep.c (s390_core_read_description): Likewise.
 493
 494 2019-03-24  Tom Tromey  <tom@tromey.com>
 495
 496         * ada-lang.c (standard_lookup): Simplify initialization.
 497         (ada_lookup_symbol_nonlocal): Simplify return.
 498         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
 499         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
 500         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
 501         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
 502         initialization.
 503         * solib.c (solib_global_lookup): Simplify.
 504         * symtab.c (null_block_symbol): Remove.
 505         (symbol_cache_lookup): Simplify returns.
 506         (lookup_language_this): Simplify returns.
 507         (lookup_symbol_aux): Simplify return.
 508         (lookup_local_symbol): Simplify returns.
 509         (lookup_global_symbol_from_objfile): Simplify return.
 510         (lookup_symbol_in_objfile_symtabs)
 511         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
 512         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
 513         (lookup_static_symbol, lookup_global_symbol): Simplify return.
 514         * cp-namespace.c (cp_lookup_bare_symbol)
 515         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
 516         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
 517         (cp_lookup_nested_symbol): Don't use null_block_symbol.
 518         (cp_lookup_symbol_via_imports): Simplify initialization.
 519         (find_symbol_in_baseclass): Likewise.
 520         * symtab.h (null_block_symbol): Remove.
 521         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
 522         (d_lookup_nested_symbol, d_lookup_symbol_imports)
 523         (d_lookup_symbol_module): Likewise.
 524         (find_symbol_in_baseclass): Simplify initialization.
 525
 526 2019-03-24  Tom Tromey  <tom@tromey.com>
 527
 528         * expression.h: Don't include symtab.h.
 529         (struct block): Forward declare.
 530
 531 2019-03-24  Tom Tromey  <tom@tromey.com>
 532
 533         * c-exp.y (typebase): Remove casts.
 534         * gdbtypes.c (lookup_unsigned_typename, )
 535         (lookup_signed_typename): Remove cast.
 536         * eval.c (parse_to_comma_and_eval): Remove cast.
 537         * parse.c (write_dollar_variable): Remove cast.
 538         * block.h (struct block) <superblock>: Now const.
 539         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
 540         * psymtab.c (psym_map_matching_symbols): Make "block" const.
 541         (map_block): Make "block" const.
 542         * symfile.h (struct quick_symbol_functions)
 543         <map_matching_symbols>: Constify block argument to "callback".
 544         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
 545         const.
 546         (find_pc_sect_compunit_symtab): Make "b" const.
 547         (find_symbol_at_address): Likewise.
 548         (search_symbols): Likewise.
 549         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
 550         (dw2_debug_names_lookup_symbol): Likewise.
 551         (dw2_map_matching_symbols): Update.
 552         * p-valprint.c (pascal_val_print): Remove "block".
 553         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
 554         (aux_add_nonlocal_symbols): Make "block" const.
 555         (resolve_subexp): Remove cast.
 556         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
 557         const.
 558         (iterate_over_file_blocks): Likewise.
 559         * f-exp.y (%union) <bval>: Remove.
 560         * coffread.c (patch_opaque_types): Make "b" const.
 561         * spu-tdep.c (spu_catch_start): Make "block" const.
 562         * c-valprint.c (print_unpacked_pointer): Remove "block".
 563         * symmisc.c (dump_symtab_1): Make "b" const.
 564         (block_depth): Make "block" const.
 565         * d-exp.y (%union) <bval>: Remove.
 566         * cp-support.h (cp_lookup_rtti_type): Update.
 567         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
 568         * psymtab.c (psym_lookup_symbol): Make "block" const.
 569         (maintenance_check_psymtabs): Make "b" const.
 570         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
 571         (enumerate_locals, enumerate_args): Update.
 572         * python/py-symtab.c (stpy_global_block): Make "block" const.
 573         (stpy_static_block): Likewise.
 574         * inline-frame.c (block_starting_point_at): Make "new_block"
 575         const.
 576         * block.c (find_block_in_blockvector): Make return type const.
 577         (blockvector_for_pc_sect): Make "b" const.
 578         (find_block_in_blockvector): Make "b" const.
 579
 580 2019-03-23  Tom Tromey  <tom@tromey.com>
 581
 582         * varobj.c (varobj_create): Update.
 583         * symfile.c (clear_symtab_users): Don't reset innermost_block.
 584         * printcmd.c (display_command, do_one_display): Don't reset
 585         innermost_block.
 586         * parser-defs.h (enum innermost_block_tracker_type): Move to
 587         expression.h.
 588         (innermost_block): Update comment.
 589         * parse.c (parse_exp_1): Add tracker_types parameter.
 590         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
 591         tracker_types parameter.  Reset innermost_block.
 592         (parse_exp_in_context): Remove.
 593         (parse_expression_for_completion): Update.
 594         * objfiles.c (~objfile): Don't reset expression_context_block or
 595         innermost_block.
 596         * expression.h (enum innermost_block_tracker_type): Move from
 597         parser-defs.h.
 598         (parse_exp_1): Add tracker_types parameter.
 599         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
 600         reset innermost_block.
 601
 602 2019-03-23  Tom Tromey  <tom@tromey.com>
 603
 604         * objfiles.h: Include bcache.h.
 605
 606 2019-03-23  Tom Tromey  <tom@tromey.com>
 607
 608         * linespec.c (get_current_search_block): Use
 609         scoped_restore_current_language.
 610         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
 611
 612 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 613             Jiong Wang  <jiong.wang@arm.com>
 614
 615         * aarch64-linux-tdep.c
 616         (aarch64_linux_iterate_over_regset_sections): Check for pauth
 617         section.
 618         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
 619
 620 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 621             Jiong Wang  <jiong.wang@arm.com>
 622
 623         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
 624         instructions.
 625         (aarch64_analyze_prologue_test): Add PACIASP test.
 626         (aarch64_prologue_prev_register): Unmask PC value.
 627
 628 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 629             Jiong Wang  <jiong.wang@arm.com>
 630
 631         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
 632         (aarch64_dwarf2_prev_register): Unmask PC value.
 633         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
 634         (aarch64_execute_dwarf_cfa_vendor_op): Check for
 635         DW_CFA_AARCH64_negate_ra_state.
 636         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
 637
 638 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 639             Jiong Wang  <jiong.wang@arm.com>
 640
 641         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
 642         registers.
 643         (aarch64_pseudo_register_name): Likewise.
 644         (aarch64_pseudo_register_type): Likewise.
 645         (aarch64_pseudo_register_reggroup_p): Likewise.
 646         (aarch64_gdbarch_init): Add pauth registers.
 647         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
 648         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
 649         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
 650         (struct gdbarch_tdep): Add regnum for ra_state.
 651
 652 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 653             Jiong Wang  <jiong.wang@arm.com>
 654
 655         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
 656
 657 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 658             Jiong Wang  <jiong.wang@arm.com>
 659
 660         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
 661         function.
 662         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
 663         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
 664         (aarch64_gdbarch_init): Add puth registers.
 665         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
 666         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
 667         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
 668
 669 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 670             Jiong Wang  <jiong.wang@arm.com>
 671
 672         * aarch64-linux-nat.c
 673         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
 674         * aarch64-linux-tdep.c
 675         (aarch64_linux_core_read_description): Likewise.
 676         (aarch64_linux_get_hwcap): New function.
 677         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
 678         (aarch64_linux_get_hwcap): New declaration.
 679
 680 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 681             Jiong Wang  <jiong.wang@arm.com>
 682
 683         * aarch64-linux-nat.c
 684         (aarch64_linux_nat_target::read_description): Add pauth param.
 685         * aarch64-linux-tdep.c
 686         (aarch64_linux_core_read_description): Likewise.
 687         * aarch64-tdep.c (struct target_desc): Add in pauth.
 688         (aarch64_read_description): Add pauth param.
 689         (aarch64_gdbarch_init): Likewise.
 690         * aarch64-tdep.h (aarch64_read_description): Likewise.
 691         * arch/aarch64.c (aarch64_create_target_description): Likewise.
 692         * arch/aarch64.h (aarch64_create_target_description): Likewise.
 693         * features/Makefile: Add new files.
 694         * features/aarch64-pauth.c: New file.
 695         * features/aarch64-pauth.xml: New file.
 696
 697 2019-03-20  Tom Tromey  <tromey@adacore.com>
 698
 699         * infrun.c (handle_inferior_event): Rename from
 700         handle_inferior_event_1.  Create a scoped_value_mark.
 701         (handle_inferior_event): Remove.
 702
 703 2019-03-19  Tom Tromey  <tromey@adacore.com>
 704
 705         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
 706         * infrun.h (print_stop_event): Add "displays" parameter.
 707         * infrun.c (print_stop_event): Add "displays" parameter.
 708
 709 2019-03-19  Pedro Alves  <palves@redhat.com>
 710
 711         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
 712         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
 713         to -1.  Fix TABs vs spaces.
 714         (tui_ui_out::tui_ui_out): Don't initialize fields here.
 715         * tui/tui-out.h (tui_ui_out) Add intro comments.
 716         <m_line, m_start_of_line>: In-class initialize, and add describing
 717         comment.
 718
 719 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
 720
 721         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
 722         variable names.
 723         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
 724
 725 2019-03-18  Pedro Alves  <palves@redhat.com>
 726             Eli Zaretskii <eliz@gnu.org>
 727
 728         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 729         m_line and m_start_of_line.
 730
 731 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 732
 733         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 734         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 735         it returns a newline.  This fixes a regression in TU mode, whereby
 736         the next line is output on the same screen line as the user input.
 737
 738 2019-03-18  Tom Tromey  <tromey@adacore.com>
 739
 740         * minsyms.c (minimal_symbol_reader::install): Remove call to
 741         obstack_blank.
 742
 743 2019-03-18  Pedro Alves  <palves@redhat.com>
 744
 745         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 746         New globals.
 747         (apply_style): New, factored out from ...
 748         (apply_ansi_escape): ... this.  Handle reverse video mode.
 749         (tui_set_reverse_mode): New function.
 750         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 751         * tui/tui-winsource.c (tui_show_source_line): Use
 752         tui_set_reverse_mode instead of setting A_STANDOUT.
 753         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 754         New setter methods.
 755
 756 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 757
 758         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 759         Handle tabs.
 760
 761 2019-03-18  Tom Tromey  <tromey@adacore.com>
 762
 763         * ada-lang.c (empty_array): Add "high" parameter.
 764         (ada_evaluate_subexp): Update.
 765
 766 2019-03-17  Sergei Trofimovich <siarheit@google.com>
 767
 768         * unittests/string_view-selftests.c: Define
 769         _initialize_string_view_selftests unconditionally.
 770
 771 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 772
 773         PR gdb/24350
 774         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
 775
 776 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 777
 778         PR gdb/24351
 779         * windows-nat.c (display_selector): Fix format specifiers.
 780
 781 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 782
 783         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 784         tui_refill_source_window instead of tui_refresh_win, to update the
 785         current execution line.  This fixes redisplay of the current line
 786         when stepping through the code with "next" or "step".
 787
 788 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 789
 790         * source-cache.c (source_cache::get_source_lines): Call
 791         find_source_lines to initialize s->nlines.  This fixes vertical
 792         scrolling of TUI source window when the DOWN arrow is pressed.
 793
 794 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 795
 796         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
 797         linux-thread-db.c (_initialize_thread_db): Likewise.
 798
 799 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 800
 801         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 802         wclrtoeol in tui_show_source_line".  This reverts changes made in
 803         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 804
 805 2019-03-15  Tom Tromey  <tom@tromey.com>
 806
 807         * symtab.h (struct minimal_symbol): Derive from
 808         general_symbol_info.
 809         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
 810         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
 811         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
 812         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
 813         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
 814         (MSYMBOL_SEARCH_NAME): Update.
 815         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
 816         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
 817         * minsyms.c (minimal_symbol_reader::record_full): Update.
 818
 819 2019-03-15  Tom Tromey  <tom@tromey.com>
 820
 821         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
 822
 823 2019-03-15  Tom Tromey  <tom@tromey.com>
 824
 825         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 826         unique_xmalloc_ptr.
 827         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 828         Update.
 829         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 830         (build_minimal_symbol_hash_tables)
 831         (minimal_symbol_reader::install): Update.
 832
 833 2019-03-15  Tom Tromey  <tom@tromey.com>
 834
 835         * symtab.c (create_demangled_names_hash): Update.
 836         (symbol_set_names): Update.
 837         * objfiles.h (struct objfile_per_bfd_storage)
 838         <demangled_names_hash>: Now an htab_up.
 839         * objfiles.c (objfile_per_bfd_storage): Simplify.
 840
 841 2019-03-15  Tom Tromey  <tom@tromey.com>
 842
 843         * objfiles.h (struct objfile_per_bfd_storage): Declare
 844         destructor.
 845         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 846         New.
 847         (get_objfile_bfd_data): Use new.  Don't initialize
 848         language_of_main.
 849         (free_objfile_per_bfd_storage): Remove.
 850         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 851
 852 2019-03-15  Tom Tromey  <tom@tromey.com>
 853
 854         * symfile.c (reread_symbols): Update.
 855         * objfiles.c (objfile::objfile): Update.
 856         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 857         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 858         comment.
 859         (minimal_symbol_reader::install): Update.
 860         (terminate_minimal_symbol_table): Remove.
 861         * jit.c (jit_object_close_impl): Update.
 862
 863 2019-03-15  Tom Tromey  <tom@tromey.com>
 864
 865         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 866         initializations.
 867
 868 2019-03-15  Tom Tromey  <tom@tromey.com>
 869
 870         * objfiles.h (struct objfile_per_bfd_storage)
 871         <demangled_hash_languages>: Now a bitset.
 872         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 873         (lookup_minimal_symbol): Update.
 874
 875 2019-03-15  Tom Tromey  <tom@tromey.com>
 876
 877         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 878         Don't return the symbol.
 879         * coffread.c (record_minimal_symbol): Use record_full.
 880
 881 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 882
 883         The MS-Windows port of ncurses fails to switch to a color pair if
 884         one or both of the colors are the implicit default colors.  This
 885         change records the default colors when TUI is initialized, and
 886         then specifies them explicitly when a color pair uses the default
 887         colors.  This allows color styling in TUI mode on MS-Windows.
 888
 889         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 890         ncurses_norm_attr.
 891         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 892         colors in ncurses_norm_attr.
 893         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 894         "none", replace it with the default color recorded in
 895         ncurses_norm_attr.
 896
 897 2019-03-14  Tom Tromey  <tromey@adacore.com>
 898
 899         * source-cache.h (class source_cache) <get_source_lines>: Return
 900         std::string.
 901         * source-cache.c (source_cache::extract_lines): Handle case where
 902         first_pos==npos.  Return std::string.
 903         (source_cache::get_source_lines): Update.
 904
 905 2019-03-14  Tom Tromey  <tromey@adacore.com>
 906
 907         * NEWS: Add item for "style sources" commands.
 908         * source-cache.c (source_cache::get_source_lines): Check
 909         source_styling.
 910         * cli/cli-style.c (source_styling): New global.
 911         (_initialize_cli_style): Add "style sources" commands.
 912         (show_style_sources): New function.
 913         * cli/cli-style.h (source_styling): Declare.
 914
 915 2019-03-14  Pedro Alves  <palves@redhat.com>
 916             Tom Tromey  <tromey@adacore.com>
 917
 918         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 919         * tui/tui-winsource.c (tui_refill_source_window): New function,
 920         from...
 921         (tui_horizontal_source_scroll): ... here.  Move some logic.
 922         * cli/cli-style.c (set_style_enabled): Notify new observable.
 923         * tui/tui-hooks.c (tui_redisplay_source): New function.
 924         (tui_attach_detach_observers): Attach or detach
 925         tui_redisplay_source.
 926         * observable.h (source_styling_changed): New observable.
 927         * observable.c: Define source_styling_changed observable.
 928
 929 2019-03-13  Tom Tromey  <tromey@adacore.com>
 930
 931         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 932         (i386_gnu_nat_target::store_registers): Update.
 933         * target-debug.h (target_debug_print_std_string): New macro.
 934         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 935         * windows-tdep.c (display_one_tib): Update.
 936         * tui/tui-stack.c (tui_make_status_line): Update.
 937         * top.c (print_inferior_quit_action): Update.
 938         * thread.c (thr_try_catch_cmd): Update.
 939         (add_thread_with_info): Update.
 940         (thread_target_id_str): Update.
 941         (thr_try_catch_cmd): Update.
 942         (thread_command): Update.
 943         (thread_find_command): Update.
 944         * record-btrace.c (record_btrace_target::info_record)
 945         (record_btrace_resume_thread, record_btrace_target::resume)
 946         (record_btrace_cancel_resume, record_btrace_step_thread)
 947         (record_btrace_target::wait, record_btrace_target::wait)
 948         (record_btrace_target::wait, record_btrace_target::stop): Update.
 949         * progspace.c (print_program_space): Update.
 950         * process-stratum-target.c
 951         (process_stratum_target::thread_address_space): Update.
 952         * linux-fork.c (linux_fork_mourn_inferior)
 953         (detach_checkpoint_command, info_checkpoints_command)
 954         (linux_fork_context): Update.
 955         (linux_fork_detach): Update.
 956         (class scoped_switch_fork_info): Update.
 957         (delete_checkpoint_command): Update.
 958         * infrun.c (follow_fork_inferior): Update.
 959         (follow_fork_inferior): Update.
 960         (proceed_after_vfork_done): Update.
 961         (handle_vfork_child_exec_or_exit): Update.
 962         (follow_exec): Update.
 963         (displaced_step_prepare_throw): Update.
 964         (displaced_step_restore): Update.
 965         (start_step_over): Update.
 966         (resume_1): Update.
 967         (clear_proceed_status_thread): Update.
 968         (proceed): Update.
 969         (print_target_wait_results): Update.
 970         (do_target_wait): Update.
 971         (context_switch): Update.
 972         (stop_all_threads): Update.
 973         (restart_threads): Update.
 974         (finish_step_over): Update.
 975         (handle_signal_stop): Update.
 976         (switch_back_to_stepped_thread): Update.
 977         (keep_going_pass_signal): Update.
 978         (print_exited_reason): Update.
 979         (normal_stop): Update.
 980         * inferior.c (inferior_pid_to_str): Change return type.
 981         (print_selected_inferior): Update.
 982         (add_inferior): Update.
 983         (detach_inferior): Update.
 984         * dummy-frame.c (fprint_dummy_frames): Update.
 985         * dcache.c (dcache_info_1): Update.
 986         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 987         (btrace_fetch, btrace_clear): Update.
 988         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 989         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 990         type.
 991         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 992         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 993         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 994         * gdbarch.c, gdbarch.h: Rebuild.
 995         * gdbarch.sh (core_pid_to_str): Change return type.
 996         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 997         return type.
 998         (windows_nat_target::pid_to_str): Change return type.
 999         (windows_delete_thread): Update.
1000         (windows_nat_target::attach): Update.
1001         (windows_nat_target::files_info): Update.
1002         * target-delegates.c: Rebuild.
1003         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
1004         return type.
1005         (sol_thread_target::pid_to_str): Change return type.
1006         * remote.c (class remote_target) <pid_to_str>: Change return
1007         type.
1008         (remote_target::pid_to_str): Change return type.
1009         (extended_remote_target::attach, remote_target::remote_stop_ns)
1010         (remote_target::remote_notif_remove_queued_reply)
1011         (remote_target::push_stop_reply, remote_target::disable_btrace):
1012         Update.
1013         (extended_remote_target::attach): Update.
1014         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
1015         type.
1016         (gdbsim_target::pid_to_str): Change return type.
1017         * ravenscar-thread.c (struct ravenscar_thread_target)
1018         <pid_to_str>: Change return type.
1019         (ravenscar_thread_target::pid_to_str): Change return type.
1020         * procfs.c (class procfs_target) <pid_to_str>: Change return
1021         type.
1022         (procfs_target::pid_to_str): Change return type.
1023         (procfs_target::attach): Update.
1024         (procfs_target::detach): Update.
1025         (procfs_target::fetch_registers): Update.
1026         (procfs_target::store_registers): Update.
1027         (procfs_target::wait): Update.
1028         (procfs_target::files_info): Update.
1029         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
1030         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
1031         return type.
1032         (nto_procfs_target::pid_to_str): Change return type.
1033         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
1034         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
1035         return type.
1036         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
1037         (exit_lwp): Update.
1038         (attach_proc_task_lwp_callback, get_detach_signal)
1039         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
1040         (linux_nat_target::resume, wait_lwp, stop_callback)
1041         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
1042         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
1043         (linux_nat_wait_1, resume_stopped_resumed_lwps)
1044         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
1045         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
1046         type.
1047         (inf_ptrace_target::attach): Update.
1048         (inf_ptrace_target::files_info): Update.
1049         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
1050         type.
1051         (go32_nat_target::pid_to_str): Change return type.
1052         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
1053         (gnu_nat_target::wait): Update.
1054         (gnu_nat_target::wait): Update.
1055         (gnu_nat_target::resume): Update.
1056         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
1057         (fbsd_nat_target::wait): Update.
1058         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
1059         type.
1060         (darwin_nat_target::attach): Update.
1061         * corelow.c (class core_target) <pid_to_str>: Change return type.
1062         (core_target::pid_to_str): Change return type.
1063         * target.c (normal_pid_to_str): Change return type.
1064         (default_pid_to_str): Likewise.
1065         (target_pid_to_str): Change return type.
1066         (target_translate_tls_address): Update.
1067         (target_announce_detach): Update.
1068         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
1069         return type.
1070         (bsd_uthread_target::pid_to_str): Change return type.
1071         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
1072         type.
1073         (bsd_kvm_target::pid_to_str): Change return type.
1074         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
1075         return type.
1076         (aix_thread_target::pid_to_str): Change return type.
1077         * target.h (struct target_ops) <pid_to_str>: Change return type.
1078         (target_pid_to_str, normal_pid_to_str): Likewise.
1079         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
1080         type.
1081         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
1082         type.
1083         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
1084         return type.
1085         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
1086         type.
1087         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
1088         type.
1089         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
1090         return type.
1091
1092 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
1093
1094         * NEWS: Mention that the new default MI version is 3.  Mention
1095         changes to the output of commands and events that deal with
1096         multi-location breakpoints.
1097         * breakpoint.c: Include "mi/mi-out.h".
1098         (print_one_breakpoint): Change output syntax if using MI version
1099         >= 3.
1100         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
1101         New.
1102         (mi_multi_location_breakpoint_output_fixed): New.
1103         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
1104         (mi_cmd_fix_multi_location_breakpoint_output): New.
1105         (mi_multi_location_breakpoint_output_fixed): New.
1106         * mi/mi-cmds.c (mi_cmds): Register command
1107         -fix-multi-location-breakpoint-output.
1108         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
1109         interpreter "mi".
1110
1111 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
1112
1113         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
1114         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
1115         instantiate mi_ui_out based on interpreter name.
1116         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
1117         * mi/mi-main.c (mi_load_progress): Likewise.
1118
1119 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1120
1121         * NEWS: Combine separate "New targets" sections for 8.3.
1122
1123 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1124
1125         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
1126         (ppcfbsd_init_abi): Install gdbarch
1127         "fetch_tls_load_module_address" and "get_thread_local_address"
1128         methods.
1129
1130 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1131
1132         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
1133         (riscv_fbsd_init_abi): Install gdbarch
1134         "fetch_tls_load_module_address" and "get_thread_local_address"
1135         methods.
1136
1137 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1138
1139         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
1140         (i386fbsd_init_abi): Install gdbarch
1141         "fetch_tls_load_module_address" and "get_thread_local_address"
1142         methods.
1143
1144 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1145
1146         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
1147         (amd64fbsd_init_abi): Install gdbarch
1148         "fetch_tls_load_module_address" and "get_thread_local_address"
1149         methods.
1150
1151 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1152
1153         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
1154         (struct fbsd_pspace_data): New type.
1155         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
1156         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
1157         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
1158         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
1159         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
1160
1161 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1162
1163         * gdbtypes.c (lookup_struct_elt): New function.
1164         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
1165         * gdbtypes.h (struct struct_elt): New type.
1166         (lookup_struct_elt): New prototype.
1167
1168 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1169
1170         * gdbtypes.c (lookup_struct_elt_type): Update comment and
1171         remove disabled code block.
1172
1173 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1174
1175         * gdbarch.sh (get_thread_local_address): New method.
1176         * gdbarch.h, gdbarch.c: Regenerate.
1177         * target.c (target_translate_tls_address): Use
1178         gdbarch_get_thread_local_address if present instead of
1179         target::get_thread_local_address.
1180
1181 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1182
1183         * target.h (target::get_thread_local_address): Update comment.
1184
1185 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1186
1187         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
1188         objfile->separate_debug_objfile_backlink if not NULL.
1189
1190 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1191
1192         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
1193         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
1194         (amd64bsd_store_inferior_registers): Likewise.
1195         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
1196         Enable segment base registers.
1197         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
1198         PT_GETFSBASE and PT_GETGSBASE.
1199         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
1200         PT_SETGSBASE.
1201         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
1202         segment base registers.
1203         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
1204
1205 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
1206
1207         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
1208         Update calls to i386_target_description to add 'segments'
1209         parameter.
1210         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
1211         add segment base registers.
1212         * arch/i386.c (i386_create_target_description): Add 'segments'
1213         parameter to enable segment base registers.
1214         * arch/i386.h (i386_create_target_description): Likewise.
1215         * features/i386/32bit-segments.xml: New file.
1216         * features/i386/32bit-segments.c: Generate.
1217         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
1218         call to i386_target_description to add 'segments' parameter.
1219         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
1220         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
1221         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
1222         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
1223         if feature is present.
1224         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
1225         Add 'segments' parameter to call to i386_target_description.
1226         (i386_target_description): Add 'segments' parameter to enable
1227         segment base registers.
1228         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
1229         to call to i386_target_description.
1230         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
1231         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
1232         Define I386_NUM_REGS.
1233         (i386_target_description): Add 'segments' parameter to enable
1234         segment base registers.
1235
1236 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
1237
1238         PR/24325
1239         * source-cache.c: #undef open and close, to avoid unresolved
1240         externals during linking.
1241
1242 2019-03-12  Tom Tromey  <tromey@adacore.com>
1243
1244         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
1245         const.  Add initializers.
1246         (_initialize_remote): Don't initialize ptid globals.
1247
1248 2019-03-12  Pedro Alves  <palves@redhat.com>
1249
1250         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
1251
1252 2019-03-12  Pedro Alves  <palves@redhat.com>
1253
1254         * cp-name-parser.y (main): Remove unused 'len' variable.
1255
1256 2019-03-12  Tom Tromey  <tromey@adacore.com>
1257
1258         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
1259         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
1260
1261 2019-03-12  Tom Tromey  <tromey@adacore.com>
1262
1263         * linux-nat.c (iterate_over_lwps): Update.
1264         (stop_callback): Remove parameter.
1265         (stop_wait_callback, detach_callback, resume_set_callback)
1266         (select_singlestep_lwp_callback, set_ignore_sigint)
1267         (status_callback, resumed_callback, resume_clear_callback)
1268         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
1269         data parameter.
1270         (linux_nat_target::detach, linux_nat_target::resume)
1271         (linux_stop_and_wait_all_lwps, select_event_lwp)
1272         (linux_nat_filter_event, linux_nat_wait_1)
1273         (linux_nat_target::kill, linux_nat_target::stop)
1274         (linux_nat_target::stop): Update.
1275         (linux_nat_resume_callback): Change type.
1276         (resume_stopped_resumed_lwps, count_events_callback)
1277         (select_event_lwp_callback): Likewise.
1278         (linux_stop_lwp, linux_nat_stop_lwp): Update.
1279         * arm-linux-nat.c (struct update_registers_data): Remove.
1280         (update_registers_callback): Change type.
1281         (arm_linux_insert_hw_breakpoint1): Update.
1282         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
1283         parameter.
1284         (x86_linux_dr_set_addr): Update.
1285         (x86_linux_dr_set_control): Update.
1286         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
1287         (iterate_over_lwps): Use gdb::function_view.
1288         * nat/aarch64-linux-hw-point.c (struct
1289         aarch64_dr_update_callback_param): Remove.
1290         (debug_reg_change_callback): Change type.
1291         (aarch64_notify_debug_reg_change): Update.
1292         * s390-linux-nat.c (s390_refresh_per_info): Update.
1293
1294 2019-03-11  Tom Tromey  <tromey@adacore.com>
1295
1296         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
1297         redundant assignment to "this_cu".
1298
1299 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1300
1301         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
1302
1303 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1304
1305         * gdbtypes.c (rank_one_type_parm_set): New function extracted
1306         from...
1307         (rank_one_type): ... this.
1308
1309 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1310
1311         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
1312         from...
1313         (rank_one_type): ... this.
1314
1315 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1316
1317         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
1318         from...
1319         (rank_one_type): ... this.
1320
1321 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1322
1323         * gdbtypes.c (rank_one_type_parm_float): New function extracted
1324         from...
1325         (rank_one_type): ... this.
1326
1327 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1328
1329         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
1330         from...
1331         (rank_one_type): ... this.
1332
1333 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1334
1335         * gdbtypes.c (rank_one_type_parm_range): New function extracted
1336         from...
1337         (rank_one_type): ... this.
1338
1339 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1340
1341         * gdbtypes.c (rank_one_type_parm_char): New function extracted
1342         from...
1343         (rank_one_type): ... this.
1344
1345 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1346
1347         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
1348         from...
1349         (rank_one_type): ... this.
1350
1351 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1352
1353         * gdbtypes.c (rank_one_type_parm_int): New function extracted
1354         from...
1355         (rank_one_type): ... this.
1356
1357 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1358
1359         * gdbtypes.c (rank_one_type_parm_func): New function extracted
1360         from...
1361         (rank_one_type): ... this.
1362
1363 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1364
1365         * gdbtypes.c (rank_one_type_parm_array): New function extracted
1366         from...
1367         (rank_one_type): ... this.
1368
1369 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
1370
1371         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
1372         from...
1373         (rank_one_type): ... this.
1374
1375 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1376
1377         * inferior.c (initialize_inferiors): Ensure 'help set/show print
1378         inferior-events' shows the example events.
1379
1380 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
1381
1382         Support styling on native MS-Windows console
1383
1384         PR/24315
1385         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
1386         on MS-Windows if $TERM is not defined.
1387
1388         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
1389
1390         * posix-hdep.c (gdb_console_fputs):
1391         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
1392         functions.
1393         * ui-file.h (gdb_console_fputs): Add prototype.
1394
1395         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
1396         back to fputs only if the former returns zero.
1397
1398 2019-03-07  Tom Tromey  <tom@tromey.com>
1399
1400         * symmisc.c (print_symbol_bcache_statistics): Update.
1401         (print_objfile_statistics): Update.
1402         * symfile.c (allocate_symtab): Update.
1403         * stabsread.c: Don't include bcache.h.
1404         * psymtab.h (struct psymbol_bcache): Don't declare.
1405         (class psymtab_storage) <psymbol_cache>: Now a bcache.
1406         (psymbol_bcache_init, psymbol_bcache_free)
1407         (psymbol_bcache_get_bcache): Don't declare.
1408         * psymtab.c (struct psymbol_bcache): Remove.
1409         (psymtab_storage::psymtab_storage): Update.
1410         (psymtab_storage::~psymtab_storage): Update.
1411         (psymbol_bcache_init, psymbol_bcache_free)
1412         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
1413         (add_psymbol_to_bcache): Update.
1414         (allocate_psymtab): Update.
1415         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
1416         macro_cache>: No longer pointers.
1417         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
1418         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
1419         * macrotab.c (macro_bcache): Update.
1420         * macroexp.c: Don't include bcache.h.
1421         * gdbtypes.c (check_types_worklist): Update.
1422         (types_deeply_equal): Remove TRY/CATCH.  Update.
1423         * elfread.c (elf_symtab_read): Update.
1424         * dwarf2read.c: Don't include bcache.h.
1425         * buildsym.c (buildsym_compunit::get_macro_table): Update.
1426         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
1427         (print_bcache_statistics, bcache_memory_used): Don't declare.
1428         (struct bcache): Move from bcache.c.  Add constructor, destructor,
1429         methods.  Rename all data members.
1430         * bcache.c (struct bcache): Move to bcache.h.
1431         (bcache::expand_hash_table): Rename from expand_hash_table.
1432         (bcache): Remove.
1433         (bcache::insert): Rename from bcache_full.
1434         (bcache::compare): Rename from bcache_compare.
1435         (bcache_xmalloc): Remove.
1436         (bcache::~bcache): Rename from bcache_xfree.
1437         (bcache::print_statistics): Rename from print_bcache_statistics.
1438         (bcache::memory_used): Rename from bcache_memory_used.
1439
1440 2019-03-07  Pedro Alves  <palves@redhat.com>
1441
1442         * infrun.c (normal_stop): Also check for
1443         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
1444
1445 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1446
1447         * f-lang.c (value_from_host_double): Moved to...
1448         * value.c (value_from_host_double): ...here.
1449         * value.h (value_from_host_double): Declare.
1450         * guile/scm-math.c (vlscm_convert_typed_number): Use
1451         value_from_host_double.
1452         (vlscm_convert_number): Likewise.
1453         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
1454         * python/py-value.c (convert_value_from_python): Likewise.
1455
1456 2019-03-06  Tom Tromey  <tom@tromey.com>
1457
1458         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
1459
1460 2019-03-06  Tom Tromey  <tom@tromey.com>
1461
1462         * utils.h (free_current_contents): Don't declare.
1463         * utils.c (free_current_contents): Remove.
1464
1465 2019-03-06  Tom Tromey  <tom@tromey.com>
1466
1467         * top.c (quit_force): Update.
1468         * main.c (captured_command_loop): Update.
1469         * common/new-op.c (operator new): Update.
1470         * common/common-exceptions.c (struct catcher)
1471         <save_cleanup_chain>: Remove member.
1472         (exceptions_state_mc_init): Update.
1473         (exception_try_scope_entry): Return nullptr.
1474         (exception_try_scope_exit, exception_rethrow)
1475         (throw_exception_sjlj, throw_exception_cxx): Update.
1476         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
1477         (all_cleanups, do_cleanups, discard_cleanups)
1478         (discard_final_cleanups, save_cleanups, save_final_cleanups)
1479         (restore_cleanups, restore_final_cleanups): Don't declare.
1480         (do_final_cleanups): Remove parameter.
1481         * common/cleanups.c (cleanup_chain, make_cleanup)
1482         (make_cleanup_dtor, all_cleanups, do_cleanups)
1483         (discard_my_cleanups, discard_cleanups)
1484         (discard_final_cleanups, save_my_cleanups, save_cleanups)
1485         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
1486         (null_cleanup): Remove.
1487         (do_final_cleanups): Remove parameter.
1488
1489 2019-03-06  Tom Tromey  <tom@tromey.com>
1490
1491         * remote.c (remote_target::remote_parse_stop_reply): Use
1492         unique_xmalloc_ptr.
1493
1494 2019-03-06  Tom Tromey  <tom@tromey.com>
1495
1496         * stabsread.c (struct stabs_field_info): Rename from field_info.
1497         <list, fnlist>: Add initializers.
1498         <obstack>: New member.
1499         (read_member_functions, read_struct_fields, read_baseclasses):
1500         Allocate on obstack.  Don't use cleanups.
1501         (read_one_struct_field, read_member_functions, read_struct_fields)
1502         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
1503         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
1504         (read_struct_type): Update.
1505
1506 2019-03-06  Tom Tromey  <tom@tromey.com>
1507
1508         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
1509         * common/filestuff.h (make_cleanup_close): Don't declare.
1510         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
1511         Remove.
1512
1513 2019-03-06  Tom Tromey  <tom@tromey.com>
1514
1515         * solib-aix.c: Use make_scope_exit.
1516
1517 2019-03-06  Tom Tromey  <tom@tromey.com>
1518
1519         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
1520         Use make_scope_exit.
1521
1522 2019-03-06  Tom Tromey  <tom@tromey.com>
1523
1524         * solib-svr4.c (disable_probes_interface): Remove parameter.
1525         (svr4_handle_solib_event): Use make_scope_exit.
1526
1527 2019-03-06  Tom Tromey  <tom@tromey.com>
1528
1529         * remote.c (struct stop_reply_deleter): Remove.
1530         (stop_reply_up): Update.
1531         (struct stop_reply): Derive from notif_event.  Don't typedef.
1532         <regcache>: Now a std::vector.
1533         (stop_reply_xfree): Remove.
1534         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
1535         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
1536         (remote_target::discard_pending_stop_replies): Use delete.
1537         (remote_target::remote_parse_stop_reply): Update.
1538         (remote_target::process_stop_reply): Update.
1539         * remote-notif.h (struct notif_event): Add virtual destructor.
1540         Remove "dtr" member.
1541         (struct notif_client) <alloc_event>: Return a unique_ptr.
1542         (notif_event_xfree): Don't declare.
1543         (notif_event_up): New typedef.
1544         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
1545         (notif_event_xfree, do_notif_event_xfree): Remove.
1546         (remote_notif_state_xfree): Update.
1547
1548 2019-03-06  Tom Tromey  <tom@tromey.com>
1549
1550         * infrun.c (displaced_step_clear_cleanup): Now a
1551         forward_scope_exit type.
1552         (displaced_step_prepare_throw): Update.
1553         (displaced_step_fixup): Update.
1554
1555 2019-03-06  Tom Tromey  <tom@tromey.com>
1556
1557         * inferior.h (class inferior): Update comment.
1558         * gdbthread.h (class thread_info): Update comment.
1559
1560 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
1561             Tom Tromey  <tom@tromey.com>
1562
1563         * stabsread.h (struct stab_section_list): Remove.
1564         (coffstab_build_psymtabs): Update.
1565         * dbxread.c (symbuf_sections): Now a std::vector.
1566         (sect_idx): New global.
1567         (fill_symbuf): Update.
1568         (coffstab_build_psymtabs): Change type of stabsects parameter.
1569         Update.
1570         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
1571         std::vector.
1572         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
1573         (coff_locate_sections): Update.
1574         (coff_symfile_read): Remove cleanups.  Update.
1575         (init_stringtab): Add storage parameter.
1576         (free_stringtab, free_stringtab_cleanup): Remove.
1577         (init_lineno): Add storage parameter.
1578         (free_linetab, free_linetab_cleanup): Remove.
1579
1580 2019-03-06  Pedro Alves  <palves@redhat.com>
1581
1582         * linux-fork.c (fork_info::clobber_regs): Delete.
1583         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
1584         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
1585         comment.  Adjust.
1586         (scoped_switch_fork_info::scoped_switch_fork_info)
1587         (checkpoint_command, linux_fork_context): Adjust
1588         fork_save_infrun_state calls.
1589
1590 2019-03-06  Pedro Alves  <palves@redhat.com>
1591
1592         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
1593         (inf_has_multiple_threads): Return 'bool' and rewrite using
1594         inferior_info::threads().
1595
1596 2019-03-06  Pedro Alves  <palves@redhat.com>
1597
1598         * linux-fork.c: Include <list>.
1599         (fork_list): Now a std::list instance.
1600         (fork_info): Add ctor, dtor, and in-class initialize all fields.
1601         (forks_exist_p, find_last_fork): Adjust.
1602         (new_fork): Delete.
1603         (one_fork_p): New.
1604         (add_fork): Adjust.
1605         (free_fork): Delete, folded into fork_info::~fork_info().
1606         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
1607         Adjust.
1608         (init_fork_list): Delete.
1609         (linux_fork_killall, linux_fork_mourn_inferior)
1610         (linux_fork_detach, info_checkpoints_command): Adjust.
1611         (_initialize_linux_fork): No longer call init_fork_list.
1612
1613 2019-03-06  Pedro Alves  <palves@redhat.com>
1614
1615         * linux-fork.c (new_fork): New, split out of ...
1616         (add_fork): ... this.  Return void.  Move "first fork" special
1617         case from here, to ...
1618         (checkpoint_command): ... here.
1619         * linux-linux.h (add_fork): Return void.
1620
1621 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1622
1623         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1624
1625 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1626             Chris January  <chris.january@arm.com>
1627             David Lecomber  <david.lecomber@arm.com>
1628
1629         * f-exp.y: New token, UNOP_INTRINSIC.
1630         (exp): New pattern using UNOP_INTRINSIC token.
1631         (f77_keywords): Add 'abs' keyword.
1632         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1633         (value_from_host_double): New function.
1634         (evaluate_subexp_f): Support UNOP_ABS.
1635
1636 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1637
1638         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1639         types.
1640
1641 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1642
1643         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1644         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1645         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1646
1647 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1648
1649         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1650
1651 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1652             Chris January  <chris.january@arm.com>
1653
1654         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1655         * f-exp.y: Define 'KIND' token.
1656         (exp): New pattern for KIND expressions.
1657         (ptype): Handle types with a kind extension.
1658         (direct_abs_decl): Extend to spot kind extensions.
1659         (f77_keywords): Add 'kind' to the list.
1660         (push_kind_type): New function.
1661         (convert_to_kind_type): New function.
1662         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1663         * parse.c (operator_length_standard): Likewise.
1664         * parser-defs.h (enum type_pieces): Add tp_kind.
1665         * std-operator.def: Add UNOP_KIND.
1666
1667 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1668
1669         * f-exp.y (f_parse): Set yydebug.
1670
1671 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1672
1673         * f-lang.c (evaluate_subexp_f): New function.
1674         (exp_descriptor_f): New global.
1675         (f_language_defn): Use exp_descriptor_f instead of
1676         exp_descriptor_standard.
1677
1678 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1679
1680         * f-exp.y (struct token): Add comments.
1681         (dot_ops): Remove uppercase versions and the end marker.
1682         (f77_keywords): Likewise.
1683         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1684         entries in the dot_ops array are case insensitive, and use
1685         strncasecmp to compare strings.  Also some whitespace cleanup in
1686         this area.  Similar for the f77_keywords array, except entries in
1687         this list might be case sensitive.
1688
1689 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1690
1691         * f-exp.y (struct f77_boolean_val): Add comments.
1692         (boolean_values): Remove uppercase versions, and end marker.
1693         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1694         and use strncasecmp to achieve case insensitivity.  Additionally,
1695         perform whitespace cleanup around this code.
1696
1697 2019-03-06  Tom Tromey  <tromey@adacore.com>
1698
1699         * remote-sim.c (gdbsim_target_open): Use result of
1700         gdb_argv::release.
1701
1702 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1703         Dirk Schubert  <dirk.schubert@arm.com>
1704         Chris January  <chris.january@arm.com>
1705
1706         * eval.c (evaluate_subexp_standard): Call Fortran argument
1707         wrapping logic.
1708         * f-lang.c (struct value): A value which can be passed into a
1709         Fortran function call.
1710         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1711         where appropriate.
1712         (struct type): Value ready for a Fortran function call.
1713         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1714         is needed.
1715         * f-lang.h (fortran_argument_convert): Declaration.
1716         (fortran_preserve_arg_pointer): Declaration.
1717         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1718
1719 2019-03-05  Tom Tromey  <tromey@adacore.com>
1720
1721         * python/py-prettyprint.c (print_string_repr): Remove #if.
1722         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1723
1724 2019-03-05  Tom Tromey  <tromey@adacore.com>
1725
1726         * target.c (the_dummy_target): Move later.  Change type to
1727         "dummy_target".
1728         (initialize_targets): Don't initialize the_dummy_target.
1729
1730 2019-03-05  Tom Tromey  <tromey@adacore.com>
1731
1732         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1733         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1734
1735 2019-03-05  Tom Tromey  <tromey@adacore.com>
1736
1737         * windows-nat.c (windows_nat_target::attach)
1738         (windows_nat_target::detach): Don't call gdb_flush.
1739         * valprint.c (generic_val_print, val_print, val_print_string):
1740         Don't call gdb_flush.
1741         * utils.c (defaulted_query): Don't call gdb_flush.
1742         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1743         * target.c (target_announce_detach): Don't call gdb_flush.
1744         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1745         * remote.c (extended_remote_target::attach): Don't call
1746         gdb_flush.
1747         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1748         * printcmd.c (do_examine): Don't call gdb_flush.
1749         (info_display_command): Don't call gdb_flush.
1750         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1751         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1752         * memattr.c (info_mem_command): Don't call gdb_flush.
1753         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1754         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1755         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1756         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1757         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1758         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1759         (gnu_nat_target::detach): Don't call gdb_flush.
1760         * f-valprint.c (f_val_print): Don't call gdb_flush.
1761         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1762         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1763         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1764         gdb_flush.
1765         * c-valprint.c (c_val_print): Don't call gdb_flush.
1766         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1767
1768 2019-03-05  Tom Tromey  <tromey@adacore.com>
1769
1770         * varobj.c (update_dynamic_varobj_children): Update.
1771         (install_default_visualizer): Use reset, not release.
1772         * value.c (set_internalvar): Update.
1773         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1774         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1775         ATTRIBUTE_UNUSED_RESULT.
1776
1777 2019-03-05  Tom Tromey  <tromey@adacore.com>
1778
1779         * remote.c (class scoped_remote_fd) <release>: Add
1780         ATTRIBUTE_UNUSED_RESULT.
1781
1782 2019-03-05  Tom Tromey  <tromey@adacore.com>
1783
1784         * macroexp.c (struct macro_buffer) <release>: Add
1785         ATTRIBUTE_UNUSED_RESULT.
1786
1787 2019-03-05  Tom Tromey  <tromey@adacore.com>
1788
1789         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1790         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1791         ATTRIBUTE_UNUSED_RESULT.
1792
1793 2019-03-05  Tom Tromey  <tromey@adacore.com>
1794
1795         * common/scoped_fd.h (class scoped_fd) <release>: Add
1796         ATTRIBUTE_UNUSED_RESULT.
1797
1798 2019-03-05  Tom Tromey  <tromey@adacore.com>
1799
1800         * parser-defs.h (struct parser_state) <release>: Add
1801         ATTRIBUTE_UNUSED_RESULT.
1802
1803 2019-03-05  Tom Tromey  <tromey@adacore.com>
1804
1805         * utils.h (class gdb_argv) <release>: Add
1806         ATTRIBUTE_UNUSED_RESULT.
1807         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1808
1809 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1810
1811         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1812         for-loop range, to avoid compiler warnings.
1813
1814         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1815         avoid compiler warnings about unused variables.
1816
1817         * NEWS: Mention end of support for native debugging on MS-Windows
1818         before XP.
1819
1820         PR gdb/24292
1821         * common/netstuff.c:
1822         * gdbserver/gdbreplay.c
1823         * gdbserver/remote-utils.c:
1824         * ser-tcp.c:
1825         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1826         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1827         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1828         'getaddrinfo' and 'freeaddrinfo' were not available before
1829         Windows XP, and mingw.org's MinGW headers by default define
1830         _WIN32_WINNT to 0x500.
1831
1832 2019-03-01  Gary Benson <gbenson@redhat.com>
1833
1834         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1835
1836 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1837             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1838
1839         PR gdb/8527
1840         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1841         set_sigint_trap, clear_sigint_trap.
1842
1843 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1844
1845         * target.c (target_detach): Clear the regcache and the
1846         frame cache.
1847
1848 2019-02-27  Pedro Alves  <palves@redhat.com>
1849
1850         * utils.c (set_screen_size): When we cap the height/width sizes,
1851         tweak the corresponding command variable to show "unlimited":
1852
1853 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1854             Pedro Alves  <palves@redhat.com>
1855
1856         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1857         before calling rl_set_screen_size.
1858
1859 2019-02-27  Tom Tromey  <tromey@adacore.com>
1860
1861         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1862         define.
1863         * python/py-value.c: Remove Python 2.4 workaround.
1864         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1865         workaround.
1866         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1867         Python 2.4 workaround.
1868         * python/python-internal.h: Remove Python 2.4 comment.
1869         (Py_ssize_t): Don't define.
1870         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1871         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1872         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1873         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1874         * python/python.c (do_start_initialization): Remove Python 2.4
1875         workaround.
1876         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1877         (print_children): Remove Python 2.4 workaround.
1878         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1879         workaround.
1880         (CHARBUFFERPROC_NAME): Remove.
1881         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1882         Python 2.4 workaround.
1883
1884 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1885
1886         * NEWS: Note minimum Python version.
1887
1888 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1889
1890         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1891         code from these functions.  Remove corresponding ifdefs.  Use
1892         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1893         Remove gotos and target of gotos.
1894         (infpy_search_memory): Likewise.
1895
1896 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1897
1898         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1899         (hppa_gdbarch_init): Don't register deleted functions with
1900         gdbarch.
1901
1902 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1903
1904         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1905         (h8300_unwind_sp): Delete.
1906         (h8300_dummy_id): Delete.
1907         (h8300_gdbarch_init): Don't register deleted functions with
1908         gdbarch.
1909
1910 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1911
1912         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1913         (ft32_unwind_pc): Delete.
1914         (ft32_unwind_sp): Delete.
1915         (ft32_gdbarch_init): Don't register deleted functions with
1916         gdbarch.
1917
1918 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1919
1920         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1921         (frv_unwind_pc): Delete.
1922         (frv_unwind_sp): Delete.
1923         (frv_gdbarch_init): Don't register deleted functions with
1924         gdbarch.
1925
1926 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1927
1928         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1929         (riscv_unwind_pc): Delete.
1930         (riscv_unwind_sp): Delete.
1931         (riscv_gdbarch_init): Don't register deleted functions with
1932         gdbarch.
1933
1934 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1935
1936         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1937         (csky_unwind_pc): Delete.
1938         (csky_unwind_sp): Delete.
1939         (csky_gdbarch_init): Don't register deleted functions with
1940         gdbarch.
1941
1942 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1943
1944         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1945         (cris_unwind_pc): Delete.
1946         (cris_unwind_sp): Delete.
1947         (cris_gdbarch_init): Don't register deleted functions with
1948         gdbarch.
1949
1950 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1951
1952         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1953         (bfin_unwind_pc): Delete.
1954         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1955
1956 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1957
1958         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1959         (arm_unwind_pc): Delete.
1960         (arm_unwind_sp): Delete.
1961         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1962
1963 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1964
1965         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1966         (arc_unwind_pc): Delete.
1967         (arc_unwind_sp): Delete.
1968         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1969
1970 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1971
1972         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1973         (alpha_unwind_pc): Delete.
1974         (alpha_gdbarch_init): Don't register deleted functions with
1975         gdbarch.
1976
1977 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1978
1979         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1980         (aarch64_unwind_pc): Delete.
1981         (aarch64_unwind_sp): Delete.
1982         (aarch64_gdbarch_init): Don't register deleted functions with
1983         gdbarch.
1984
1985 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1986
1987         * gdbtypes.c (type_align): Don't consider static members when
1988         computing structure alignment.
1989
1990 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1991
1992         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1993         return 0 for other types.
1994         * arch-utils.c (default_type_align): Always return 0.
1995         * gdbarch.h: Regenerate.
1996         * gdbarch.sh (type_align): Extend comment.
1997         * gdbtypes.c (type_align): Add additional comments, always call
1998         gdbarch_type_align before applying the default rules.
1999         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
2000         generic code will then apply a suitable default.
2001         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
2002         types, return 0 for other types.
2003
2004 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
2005
2006         * NEWS: Create a new section for the next release branch.
2007         Rename the section of the current branch, now that it has
2008         been cut.
2009
2010 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
2011
2012         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
2013         * version.in: Bump version to 8.3.50.DATE-git.
2014
2015 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
2016
2017         * aix-thread.c (ptid_cmp): Remove unused variable.
2018         (get_signaled_thread): Likewise.
2019         (store_regs_user_thread): Likewise.
2020         (store_regs_kernel_thread): Likewise.
2021         (fetch_regs_kernel_thread): Remove shadowed variable.
2022
2023 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2024
2025         * features/riscv/32bit-cpu.xml: Add register numbers.
2026         * features/riscv/32bit-fpu.c: Regenerate.
2027         * features/riscv/32bit-fpu.xml: Add register numbers.
2028         * features/riscv/64bit-cpu.xml: Add register numbers.
2029         * features/riscv/64bit-fpu.c: Regenerate.
2030         * features/riscv/64bit-fpu.xml: Add register numbers.
2031
2032 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
2033
2034         * NEWS: Mention two argument form of gdb.Value constructor.
2035         * python/py-value.c (convert_buffer_and_type_to_value): New
2036         function.
2037         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
2038         Add support for handling an optional second argument.  Call
2039         convert_buffer_and_type_to_value as appropriate.
2040         * python/python-internal.h (Py_buffer_deleter): New struct.
2041         (Py_buffer_up): New typedef.
2042
2043 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
2044
2045         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
2046         instead of releasing ownership.
2047
2048 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
2049
2050         * dwarf2read.c (open_and_init_dwp_file): Call
2051         elf_numsections instead of bfd_count_sections to initialize
2052         dwp_file->num_sections.
2053
2054 2019-02-25  Tom Tromey  <tromey@adacore.com>
2055
2056         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
2057
2058 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2059
2060         * gcore.in: Add '--readnever' option when invoking GDB.
2061
2062 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
2063
2064         * MAINTAINERS: Update my email address.
2065
2066 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
2067
2068         * build-id.c (build_id_to_debug_bfd_1): New function.
2069         (build_id_to_debug_bfd): Look for separate debug file in
2070         sysroot.
2071
2072 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2073
2074         * gdbarch.sh: Update the copyright year range that is placed into
2075         generated files.
2076
2077 2019-02-22  Keith Seitz  <keiths@redhat.com>
2078
2079         PR symtab/23853
2080         * linespec.c (create_sals_line_offset): Search for the default
2081         symtab's filename instead of its fullname.
2082
2083 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
2084
2085         * NEWS: Update style defaults.
2086
2087 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
2088
2089         * main.c (captured_main_1): Disable styling in batch mode.
2090
2091 2019-02-20  Tom Tromey  <tom@tromey.com>
2092
2093         * symtab.c (symtab_symbol_info): Fix typos.
2094
2095 2019-02-20  Tom Tromey  <tromey@adacore.com>
2096
2097         * findcmd.c (_initialize_mem_search): Use upper case for
2098         metasyntactic variables.
2099
2100 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
2101
2102         * aarch64-tdep.c (aarch64_add_reggroups): New function.
2103         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
2104
2105 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
2106
2107         * top.h (source_file_name): Change to std::string.
2108         * top.c (source_file_name): Likewise.
2109         (command_line_input): Adjust.
2110         * cli/cli-script.c (script_from_file): Adjust.
2111
2112 2019-02-19  Tom Tromey  <tromey@adacore.com>
2113
2114         * ravenscar-thread.c
2115         (ravenscar_thread_target::update_thread_list): Don't call
2116         ada_build_task_list.
2117         * ada-lang.h (ada_build_task_list): Don't declare.
2118         * ada-tasks.c (struct ada_tasks_inferior_data)
2119         <task_list_valid_p>: Now bool.
2120         (read_known_tasks, ada_task_list_changed)
2121         (ada_tasks_invalidate_inferior_data): Update.
2122         (read_known_tasks_array): Return bool.
2123         (read_known_tasks_list): Likewise.
2124         (read_known_tasks): Return void.
2125         (ada_build_task_list): Now static.
2126
2127 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2128
2129         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
2130         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
2131
2132 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2133
2134         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
2135         variant for ada_tasks_pspace_data_handle and
2136         ada_tasks_inferior_data_handle.
2137         (ada_tasks_pspace_data_cleanup): New function.
2138         (ada_tasks_inferior_data_cleanup): New function.
2139
2140 2019-02-17  Tom Tromey  <tom@tromey.com>
2141
2142         * macrotab.h (macro_source_fullname): Return a std::string.
2143         * macrotab.c (macro_include, check_for_redefinition)
2144         (macro_undef, macro_lookup_definition, foreach_macro)
2145         (foreach_macro_in_scope): Update.
2146         (macro_source_fullname): Return a std::string.
2147         * macrocmd.c (show_pp_source_pos): Update.
2148
2149 2019-02-17  Tom Tromey  <tom@tromey.com>
2150
2151         * macrocmd.c (show_pp_source_pos): Style the file names.
2152
2153 2019-02-17  Tom Tromey  <tom@tromey.com>
2154
2155         PR tui/24197:
2156         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
2157
2158 2019-02-17  Tom Tromey  <tom@tromey.com>
2159
2160         * ada-lang.c (user_select_syms): Use filtered printing.
2161         * utils.c (wrap_style): New global.
2162         (desired_style): Remove.
2163         (emit_style_escape): Add stream parameter.
2164         (set_output_style, reset_terminal_style, prompt_for_continue):
2165         Update.
2166         (flush_wrap_buffer): Only flush gdb_stdout.
2167         (wrap_here): Set wrap_style.
2168         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
2169         treat escape sequences as a character.  Change when wrap buffer is
2170         flushed.
2171         (fputs_styled): Do not set the output style when the default is
2172         requested.
2173         * ui-style.h (struct ui_file_style) <is_default>: New method.
2174         * source.c (print_source_lines_base): Emit escape sequences in one
2175         piece.
2176
2177 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
2178
2179         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
2180         integers and enumeration types.
2181
2182 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
2183
2184         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
2185         instead of lookup_symbol_in_language
2186         (do_exact_match): New function.
2187         (ada_get_symbol_name_matcher): Return do_exact_match when
2188         doing a verbatim match.
2189
2190 2019-02-15  Tom Tromey  <tromey@adacore.com>
2191
2192         * ravenscar-thread.c (ravenscar_thread_target::resume)
2193         (ravenscar_thread_target::wait): Special case wildcard requests.
2194
2195 2019-02-15  Tom Tromey  <tromey@adacore.com>
2196
2197         * ravenscar-thread.c (base_ptid): Remove.
2198         (struct ravenscar_thread_target) <close>: New method.
2199         <m_base_ptid>: New member.
2200         <update_inferior_ptid, active_task, task_is_currently_active,
2201         runtime_initialized>: Declare methods.
2202         <ravenscar_thread_target>: Add constructor.
2203         (ravenscar_thread_target::task_is_currently_active)
2204         (ravenscar_thread_target::update_inferior_ptid)
2205         (ravenscar_runtime_initialized): Rename.  Now methods.
2206         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
2207         (ravenscar_thread_target::update_thread_list): Update.
2208         (ravenscar_thread_target::active_task): Now method.
2209         (ravenscar_thread_target::store_registers)
2210         (ravenscar_thread_target::prepare_to_store)
2211         (ravenscar_thread_target::prepare_to_store)
2212         (ravenscar_thread_target::mourn_inferior): Update.
2213         (ravenscar_inferior_created): Use "new" to create target.
2214         (ravenscar_thread_target::get_ada_task_ptid): Update.
2215         (_initialize_ravenscar): Don't initialize base_ptid.
2216         (ravenscar_ops): Remove global.
2217
2218 2019-02-15  Tom Tromey  <tromey@adacore.com>
2219
2220         * target.h (push_target): Declare new overload.
2221         * target.c (push_target): New overload, taking an rvalue reference.
2222         * remote.c (remote_target::open_1): Use push_target overload.
2223         * corelow.c (core_target_open): Use push_target overload.
2224
2225 2019-02-15  Tom Tromey  <tromey@adacore.com>
2226
2227         * ravenscar-thread.c (is_ravenscar_task)
2228         (ravenscar_task_is_currently_active): Return bool.
2229         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
2230         (_initialize_ravenscar): Remove "(void)".
2231         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
2232         Return bool.
2233
2234 2019-02-15  Tom Tromey  <tromey@adacore.com>
2235
2236         * ravenscar-thread.c (ravenscar_runtime_initializer)
2237         (has_ravenscar_runtime, get_running_thread_id)
2238         (ravenscar_thread_target::resume): Fix indentation.
2239
2240 2019-02-15  Tom Tromey  <tromey@adacore.com>
2241
2242         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
2243         from ravenscar_arch_ops.
2244         (sparc_ravenscar_ops::fetch_registers)
2245         (sparc_ravenscar_ops::store_registers): Now methods.
2246         (sparc_ravenscar_prepare_to_store): Remove.
2247         (sparc_ravenscar_ops): Redefine.
2248         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
2249         methods and destructor.  Remove members.
2250         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
2251         (ravenscar_thread_target::store_registers)
2252         (ravenscar_thread_target::prepare_to_store): Update.
2253         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
2254         Remove.
2255         (struct ppc_ravenscar_powerpc_ops): Derive from
2256         ravenscar_arch_ops.
2257         (ppc_ravenscar_powerpc_ops::fetch_registers)
2258         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
2259         (ppc_ravenscar_powerpc_ops): Redefine.
2260         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
2261         (ppc_ravenscar_e500_ops::fetch_registers)
2262         (ppc_ravenscar_e500_ops::store_registers): Now methods.
2263         (ppc_ravenscar_e500_ops): Redefine.
2264         * aarch64-ravenscar-thread.c
2265         (aarch64_ravenscar_generic_prepare_to_store): Remove.
2266         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
2267         (aarch64_ravenscar_fetch_registers)
2268         (aarch64_ravenscar_store_registers): Now methods.
2269         (aarch64_ravenscar_ops): Redefine.
2270
2271 2019-02-15  Tom Tromey  <tromey@adacore.com>
2272
2273         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
2274         (ravenscar_thread_target::stopped_by_hw_breakpoint)
2275         (ravenscar_thread_target::stopped_by_watchpoint)
2276         (ravenscar_thread_target::stopped_data_address)
2277         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
2278
2279 2019-02-15  Tom Tromey  <tromey@adacore.com>
2280
2281         * ravenscar-thread.c: Fix some typos.
2282
2283 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2284             Tom Tromey  <tromey@adacore.com>
2285
2286         * ada-lang.c (ada_exception_sal): Change addr_string to a
2287         std::string.
2288         (create_ada_exception_catchpoint): Update.
2289
2290 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2291             Tom Tromey  <tromey@adacore.com>
2292
2293         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
2294         (bp_location_ops): Remove.
2295         (base_breakpoint_allocate_location): Update.
2296         (free_bp_location): Update.
2297         * ada-lang.c (class ada_catchpoint_location)
2298         <ada_catchpoint_location>: Remove ops parameter.
2299         (ada_catchpoint_location_dtor): Remove.
2300         (ada_catchpoint_location_ops): Remove.
2301         (allocate_location_exception): Update.
2302         * breakpoint.h (struct bp_location_ops): Remove.
2303         (class bp_location) <bp_location>: Remove bp_location_ops
2304         parameter.
2305         <~bp_location>: Add destructor.
2306         <ops>: Remove.
2307
2308 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
2309             Pedro Alves  <palves@redhat.com>
2310
2311         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
2312         'PATH_MAX'.
2313
2314 2019-02-14  David Michael  <fedora.dm0@gmail.com>
2315             Samuel Thibault  <samuel.thibault@gnu.org>
2316             Thomas Schwinge  <thomas@codesourcery.com>
2317
2318         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
2319         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
2320
2321 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
2322
2323         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
2324         (check_empty): Use "const char *".
2325
2326         * gnu-nat.c (gnu_nat_target::detach): Instead of
2327         'detach_inferior (pid)' call
2328         'detach_inferior (find_inferior_pid (pid))'.
2329
2330         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
2331         'nat/fork-inferior.o'.
2332         * gnu-nat.c: #include "nat/fork-inferior.h".
2333
2334         * gnu-nat.c (gnu_nat_target::detach): Instead of
2335         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
2336         * gnu-nat.h: #include "inf-child.h".
2337         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
2338         'i386_gnu_nat_target::fetch_registers'.
2339         (gnu_store_registers): Rename/move to
2340         'i386_gnu_nat_target::store_registers'.
2341
2342         * config/i386/nm-i386gnu.h: Don't "#include" any files.
2343         * gnu-nat.h (mach_thread_info): New function.
2344         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
2345
2346         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
2347
2348 2019-02-14  Frederic Konrad  <konrad@adacore.com>
2349
2350         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
2351
2352 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
2353
2354         * windows-nat.c (windows_add_thread): Add new parameter
2355         "main_thread_p" with default value set to false.  Update
2356         function documentation as well as all callers.
2357         (windows_delete_thread): Likewise.
2358         (fake_create_process): Update call to windows_add_thread.
2359         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
2360         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
2361         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
2362         call to windows_delete_thread.
2363
2364 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
2365
2366         * MAINTAINERS: Add Andrew Burgess as global maintainer.
2367
2368 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2369
2370         * symfile.c (find_separate_debug_file): Use canonical path of
2371         sysroot with child_path instead of gdb_sysroot if it is valid.
2372
2373 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2374
2375         * symfile.c (find_separate_debug_file): Use child_path to
2376         determine if an object file is under a sysroot.
2377
2378 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2379
2380         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
2381         unittests/child-path-selftests.c.
2382         * common/pathstuff.c (child_path): New function.
2383         * common/pathstuff.h (child_path): New prototype.
2384         * unittests/child-path-selftests.c: New file.
2385
2386 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
2387
2388         * symfile.c (find_separate_debug_file): Look for separate debug
2389         files in debug directories under the sysroot.
2390
2391 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2392
2393         * symtab.h (struct minimal_symbol data_p): New const method.
2394         (struct minimal_symbol text_p): Likewise.
2395         * symtab.c (output_source_filename): Use file name style
2396         to print file name.
2397         (print_symbol_info): Likewise.
2398         (print_msymbol_info): Use address style to print addresses.
2399         Use function name style to print executable text symbols.
2400         (expand_symtab_containing_pc): Use data_p.
2401         (find_pc_sect_compunit_symtab): Likewise.
2402
2403 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2404
2405         * breakpoint.c (describe_other_breakpoints): Use address style
2406         to print addresses.
2407         (say_where): Likewise.
2408
2409 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2410
2411         * ada-typeprint.c (print_func_type): Print function name
2412         style to print function name.
2413         * c-typeprint.c (c_print_type_1): Likewise.
2414
2415 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
2416
2417         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
2418         for execve.
2419
2420 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2421
2422         * c-exp.y (direct_abs_decl): Use emplace_back to record the
2423         type_stack.
2424
2425 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
2426
2427         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
2428         TYPE_CODE_REF types.
2429
2430 2019-02-08  Jim Wilson  <jimw@sifive.com>
2431
2432         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
2433         (riscv_linux_fregset): New.
2434         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
2435
2436 2019-02-07  Tom Tromey  <tom@tromey.com>
2437
2438         * thread.c (thread_cancel_execution_command): Update.
2439         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
2440         methods.
2441         (struct thread_fsm_ops): Remove.
2442         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
2443         (thread_fsm_should_stop, thread_fsm_return_value)
2444         (thread_fsm_set_finished, thread_fsm_finished_p)
2445         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
2446         Don't declare.
2447         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
2448         * infrun.c (clear_proceed_status_thread)
2449         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
2450         (print_stop_event): Update.
2451         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
2452         Add constructor.
2453         (step_command_fsm_ops): Remove.
2454         (new_step_command_fsm): Remove.
2455         (step_1): Update.
2456         (step_command_fsm::should_stop): Rename from
2457         step_command_fsm_should_stop.
2458         (step_command_fsm::clean_up): Rename from
2459         step_command_fsm_clean_up.
2460         (step_command_fsm::do_async_reply_reason): Rename from
2461         step_command_fsm_async_reply_reason.
2462         (struct until_next_fsm): Inherit from thread_fsm.  Add
2463         constructor.
2464         (until_next_fsm_ops): Remove.
2465         (new_until_next_fsm): Remove.
2466         (until_next_fsm::should_stop): Rename from
2467         until_next_fsm_should_stop.
2468         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
2469         (until_next_fsm::do_async_reply_reason): Rename from
2470         until_next_fsm_async_reply_reason.
2471         (struct finish_command_fsm): Inherit from thread_fsm.  Add
2472         constructor.  Change type of breakpoint.
2473         (finish_command_fsm_ops): Remove.
2474         (new_finish_command_fsm): Remove.
2475         (finish_command_fsm::should_stop): Rename from
2476         finish_command_fsm_should_stop.
2477         (finish_command_fsm::clean_up): Rename from
2478         finish_command_fsm_clean_up.
2479         (finish_command_fsm::return_value): Rename from
2480         finish_command_fsm_return_value.
2481         (finish_command_fsm::do_async_reply_reason): Rename from
2482         finish_command_fsm_async_reply_reason.
2483         (finish_command): Update.
2484         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
2485         Add constructor.
2486         (call_thread_fsm_ops): Remove.
2487         (call_thread_fsm::call_thread_fsm): Rename from
2488         new_call_thread_fsm.
2489         (call_thread_fsm::should_stop): Rename from
2490         call_thread_fsm_should_stop.
2491         (call_thread_fsm::should_notify_stop): Rename from
2492         call_thread_fsm_should_notify_stop.
2493         (run_inferior_call, call_function_by_hand_dummy): Update.
2494         * cli/cli-interp.c (should_print_stop_to_console): Update.
2495         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
2496         Add constructor.  Change type of location_breakpoint,
2497         caller_breakpoint.
2498         (until_break_fsm_ops): Remove.
2499         (new_until_break_fsm): Remove.
2500         (until_break_fsm::should_stop): Rename from
2501         until_break_fsm_should_stop.
2502         (until_break_fsm::clean_up): Rename from
2503         until_break_fsm_clean_up.
2504         (until_break_fsm::do_async_reply_reason): Rename from
2505         until_break_fsm_async_reply_reason.
2506         (until_break_command): Update.
2507         * thread-fsm.c: Remove.
2508         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
2509
2510 2019-02-07  Tom Tromey  <tom@tromey.com>
2511
2512         * yy-remap.h: Add include guard.
2513         * xtensa-tdep.h: Add include guard.
2514         * xcoffread.h: Rename include guard.
2515         * varobj-iter.h: Add include guard.
2516         * tui/tui.h: Rename include guard.
2517         * tui/tui-winsource.h: Rename include guard.
2518         * tui/tui-wingeneral.h: Rename include guard.
2519         * tui/tui-windata.h: Rename include guard.
2520         * tui/tui-win.h: Rename include guard.
2521         * tui/tui-stack.h: Rename include guard.
2522         * tui/tui-source.h: Rename include guard.
2523         * tui/tui-regs.h: Rename include guard.
2524         * tui/tui-out.h: Rename include guard.
2525         * tui/tui-layout.h: Rename include guard.
2526         * tui/tui-io.h: Rename include guard.
2527         * tui/tui-hooks.h: Rename include guard.
2528         * tui/tui-file.h: Rename include guard.
2529         * tui/tui-disasm.h: Rename include guard.
2530         * tui/tui-data.h: Rename include guard.
2531         * tui/tui-command.h: Rename include guard.
2532         * tic6x-tdep.h: Add include guard.
2533         * target/waitstatus.h: Rename include guard.
2534         * target/wait.h: Rename include guard.
2535         * target/target.h: Rename include guard.
2536         * target/resume.h: Rename include guard.
2537         * target-float.h: Rename include guard.
2538         * stabsread.h: Add include guard.
2539         * rs6000-tdep.h: Add include guard.
2540         * riscv-fbsd-tdep.h: Add include guard.
2541         * regformats/regdef.h: Rename include guard.
2542         * record.h: Rename include guard.
2543         * python/python.h: Rename include guard.
2544         * python/python-internal.h: Rename include guard.
2545         * python/py-stopevent.h: Rename include guard.
2546         * python/py-ref.h: Rename include guard.
2547         * python/py-record.h: Rename include guard.
2548         * python/py-record-full.h: Rename include guard.
2549         * python/py-record-btrace.h: Rename include guard.
2550         * python/py-instruction.h: Rename include guard.
2551         * python/py-events.h: Rename include guard.
2552         * python/py-event.h: Rename include guard.
2553         * procfs.h: Add include guard.
2554         * proc-utils.h: Add include guard.
2555         * p-lang.h: Add include guard.
2556         * or1k-tdep.h: Rename include guard.
2557         * observable.h: Rename include guard.
2558         * nto-tdep.h: Rename include guard.
2559         * nat/x86-linux.h: Rename include guard.
2560         * nat/x86-linux-dregs.h: Rename include guard.
2561         * nat/x86-gcc-cpuid.h: Add include guard.
2562         * nat/x86-dregs.h: Rename include guard.
2563         * nat/x86-cpuid.h: Rename include guard.
2564         * nat/ppc-linux.h: Rename include guard.
2565         * nat/mips-linux-watch.h: Rename include guard.
2566         * nat/linux-waitpid.h: Rename include guard.
2567         * nat/linux-ptrace.h: Rename include guard.
2568         * nat/linux-procfs.h: Rename include guard.
2569         * nat/linux-osdata.h: Rename include guard.
2570         * nat/linux-nat.h: Rename include guard.
2571         * nat/linux-namespaces.h: Rename include guard.
2572         * nat/linux-btrace.h: Rename include guard.
2573         * nat/glibc_thread_db.h: Rename include guard.
2574         * nat/gdb_thread_db.h: Rename include guard.
2575         * nat/gdb_ptrace.h: Rename include guard.
2576         * nat/fork-inferior.h: Rename include guard.
2577         * nat/amd64-linux-siginfo.h: Rename include guard.
2578         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
2579         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
2580         * nat/aarch64-linux.h: Rename include guard.
2581         * nat/aarch64-linux-hw-point.h: Rename include guard.
2582         * mn10300-tdep.h: Add include guard.
2583         * mips-linux-tdep.h: Add include guard.
2584         * mi/mi-parse.h: Rename include guard.
2585         * mi/mi-out.h: Rename include guard.
2586         * mi/mi-main.h: Rename include guard.
2587         * mi/mi-interp.h: Rename include guard.
2588         * mi/mi-getopt.h: Rename include guard.
2589         * mi/mi-console.h: Rename include guard.
2590         * mi/mi-common.h: Rename include guard.
2591         * mi/mi-cmds.h: Rename include guard.
2592         * mi/mi-cmd-break.h: Rename include guard.
2593         * m2-lang.h: Add include guard.
2594         * location.h: Rename include guard.
2595         * linux-record.h: Rename include guard.
2596         * linux-nat.h: Add include guard.
2597         * linux-fork.h: Add include guard.
2598         * i386-darwin-tdep.h: Rename include guard.
2599         * hppa-linux-offsets.h: Add include guard.
2600         * guile/guile.h: Rename include guard.
2601         * guile/guile-internal.h: Rename include guard.
2602         * gnu-nat.h: Rename include guard.
2603         * gdb-stabs.h: Rename include guard.
2604         * frv-tdep.h: Add include guard.
2605         * f-lang.h: Add include guard.
2606         * event-loop.h: Add include guard.
2607         * darwin-nat.h: Rename include guard.
2608         * cp-abi.h: Rename include guard.
2609         * config/sparc/nm-sol2.h: Rename include guard.
2610         * config/nm-nto.h: Rename include guard.
2611         * config/nm-linux.h: Add include guard.
2612         * config/i386/nm-i386gnu.h: Rename include guard.
2613         * config/djgpp/nl_types.h: Rename include guard.
2614         * config/djgpp/langinfo.h: Rename include guard.
2615         * compile/gcc-cp-plugin.h: Add include guard.
2616         * compile/gcc-c-plugin.h: Add include guard.
2617         * compile/compile.h: Rename include guard.
2618         * compile/compile-object-run.h: Rename include guard.
2619         * compile/compile-object-load.h: Rename include guard.
2620         * compile/compile-internal.h: Rename include guard.
2621         * compile/compile-cplus.h: Rename include guard.
2622         * compile/compile-c.h: Rename include guard.
2623         * common/xml-utils.h: Rename include guard.
2624         * common/x86-xstate.h: Rename include guard.
2625         * common/version.h: Rename include guard.
2626         * common/vec.h: Rename include guard.
2627         * common/tdesc.h: Rename include guard.
2628         * common/selftest.h: Rename include guard.
2629         * common/scoped_restore.h: Rename include guard.
2630         * common/scoped_mmap.h: Rename include guard.
2631         * common/scoped_fd.h: Rename include guard.
2632         * common/safe-iterator.h: Rename include guard.
2633         * common/run-time-clock.h: Rename include guard.
2634         * common/refcounted-object.h: Rename include guard.
2635         * common/queue.h: Rename include guard.
2636         * common/ptid.h: Rename include guard.
2637         * common/print-utils.h: Rename include guard.
2638         * common/preprocessor.h: Rename include guard.
2639         * common/pathstuff.h: Rename include guard.
2640         * common/observable.h: Rename include guard.
2641         * common/netstuff.h: Rename include guard.
2642         * common/job-control.h: Rename include guard.
2643         * common/host-defs.h: Rename include guard.
2644         * common/gdb_wait.h: Rename include guard.
2645         * common/gdb_vecs.h: Rename include guard.
2646         * common/gdb_unlinker.h: Rename include guard.
2647         * common/gdb_unique_ptr.h: Rename include guard.
2648         * common/gdb_tilde_expand.h: Rename include guard.
2649         * common/gdb_sys_time.h: Rename include guard.
2650         * common/gdb_string_view.h: Rename include guard.
2651         * common/gdb_splay_tree.h: Rename include guard.
2652         * common/gdb_setjmp.h: Rename include guard.
2653         * common/gdb_ref_ptr.h: Rename include guard.
2654         * common/gdb_optional.h: Rename include guard.
2655         * common/gdb_locale.h: Rename include guard.
2656         * common/gdb_assert.h: Rename include guard.
2657         * common/filtered-iterator.h: Rename include guard.
2658         * common/filestuff.h: Rename include guard.
2659         * common/fileio.h: Rename include guard.
2660         * common/environ.h: Rename include guard.
2661         * common/common-utils.h: Rename include guard.
2662         * common/common-types.h: Rename include guard.
2663         * common/common-regcache.h: Rename include guard.
2664         * common/common-inferior.h: Rename include guard.
2665         * common/common-gdbthread.h: Rename include guard.
2666         * common/common-exceptions.h: Rename include guard.
2667         * common/common-defs.h: Rename include guard.
2668         * common/common-debug.h: Rename include guard.
2669         * common/cleanups.h: Rename include guard.
2670         * common/buffer.h: Rename include guard.
2671         * common/btrace-common.h: Rename include guard.
2672         * common/break-common.h: Rename include guard.
2673         * cli/cli-utils.h: Rename include guard.
2674         * cli/cli-style.h: Rename include guard.
2675         * cli/cli-setshow.h: Rename include guard.
2676         * cli/cli-script.h: Rename include guard.
2677         * cli/cli-interp.h: Rename include guard.
2678         * cli/cli-decode.h: Rename include guard.
2679         * cli/cli-cmds.h: Rename include guard.
2680         * charset-list.h: Add include guard.
2681         * buildsym-legacy.h: Rename include guard.
2682         * bfin-tdep.h: Add include guard.
2683         * ax.h: Rename include guard.
2684         * arm-linux-tdep.h: Add include guard.
2685         * arm-fbsd-tdep.h: Add include guard.
2686         * arch/xtensa.h: Rename include guard.
2687         * arch/tic6x.h: Add include guard.
2688         * arch/i386.h: Add include guard.
2689         * arch/arm.h: Rename include guard.
2690         * arch/arm-linux.h: Rename include guard.
2691         * arch/arm-get-next-pcs.h: Rename include guard.
2692         * arch/amd64.h: Add include guard.
2693         * arch/aarch64-insn.h: Rename include guard.
2694         * arch-utils.h: Rename include guard.
2695         * annotate.h: Add include guard.
2696         * amd64-darwin-tdep.h: Rename include guard.
2697         * aarch64-linux-tdep.h: Add include guard.
2698         * aarch64-fbsd-tdep.h: Add include guard.
2699         * aarch32-linux-nat.h: Add include guard.
2700
2701 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2702
2703         * macrotab.c (macro_define_internal): New function that
2704         factorizes macro_define_object_internal and macro_define_function
2705         code.
2706         (macro_define_object_internal): Use macro_define_internal.
2707         (macro_define_function): Likewise.
2708
2709 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2710
2711         * macrocmd.c (extract_identifier): Return
2712         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2713         callers.
2714
2715 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2716
2717         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2718
2719 2019-02-05  Tom Tromey  <tom@tromey.com>
2720
2721         * target.c (target_stack::unpush): Move assertion earlier.
2722
2723 2019-01-30  Tom Tromey  <tom@tromey.com>
2724
2725         PR python/23615:
2726         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2727         (gdbpy_parse_and_eval): Likewise.
2728         * python/python-internal.h (gdbpy_allow_threads): New class.
2729
2730 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2731
2732         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2733         (aarch64_fbsd_fpregmap): Move earlier.
2734         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2735         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2736         instead of individual calls to trad_frame_set_reg_addr.
2737         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2738         earlier.
2739         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2740         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2741         instead of individual calls to trad_frame_set_reg_addr.
2742
2743 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2744
2745         * CONTRIBUTE: Replace contribution list with wiki link.
2746
2747 2019-01-25  Tom Tromey  <tom@tromey.com>
2748
2749         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2750
2751 2019-01-25  Tom Tromey  <tom@tromey.com>
2752
2753         * xtensa-linux-nat.c: Fix common/ includes.
2754         * xml-support.h: Fix common/ includes.
2755         * xml-support.c: Fix common/ includes.
2756         * x86-linux-nat.c: Fix common/ includes.
2757         * windows-nat.c: Fix common/ includes.
2758         * varobj.h: Fix common/ includes.
2759         * varobj.c: Fix common/ includes.
2760         * value.c: Fix common/ includes.
2761         * valops.c: Fix common/ includes.
2762         * utils.c: Fix common/ includes.
2763         * unittests/xml-utils-selftests.c: Fix common/ includes.
2764         * unittests/utils-selftests.c: Fix common/ includes.
2765         * unittests/unpack-selftests.c: Fix common/ includes.
2766         * unittests/tracepoint-selftests.c: Fix common/ includes.
2767         * unittests/style-selftests.c: Fix common/ includes.
2768         * unittests/string_view-selftests.c: Fix common/ includes.
2769         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2770         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2771         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2772         * unittests/rsp-low-selftests.c: Fix common/ includes.
2773         * unittests/parse-connection-spec-selftests.c: Fix common/
2774         includes.
2775         * unittests/optional-selftests.c: Fix common/ includes.
2776         * unittests/offset-type-selftests.c: Fix common/ includes.
2777         * unittests/observable-selftests.c: Fix common/ includes.
2778         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2779         * unittests/memrange-selftests.c: Fix common/ includes.
2780         * unittests/memory-map-selftests.c: Fix common/ includes.
2781         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2782         * unittests/function-view-selftests.c: Fix common/ includes.
2783         * unittests/environ-selftests.c: Fix common/ includes.
2784         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2785         * unittests/common-utils-selftests.c: Fix common/ includes.
2786         * unittests/cli-utils-selftests.c: Fix common/ includes.
2787         * unittests/array-view-selftests.c: Fix common/ includes.
2788         * ui-file.c: Fix common/ includes.
2789         * tui/tui-io.c: Fix common/ includes.
2790         * tracepoint.h: Fix common/ includes.
2791         * tracepoint.c: Fix common/ includes.
2792         * tracefile-tfile.c: Fix common/ includes.
2793         * top.h: Fix common/ includes.
2794         * top.c: Fix common/ includes.
2795         * thread.c: Fix common/ includes.
2796         * target/waitstatus.h: Fix common/ includes.
2797         * target/waitstatus.c: Fix common/ includes.
2798         * target.h: Fix common/ includes.
2799         * target.c: Fix common/ includes.
2800         * target-memory.c: Fix common/ includes.
2801         * target-descriptions.c: Fix common/ includes.
2802         * symtab.h: Fix common/ includes.
2803         * symfile.c: Fix common/ includes.
2804         * stap-probe.c: Fix common/ includes.
2805         * spu-linux-nat.c: Fix common/ includes.
2806         * sparc-nat.c: Fix common/ includes.
2807         * source.c: Fix common/ includes.
2808         * solib.c: Fix common/ includes.
2809         * solib-target.c: Fix common/ includes.
2810         * ser-unix.c: Fix common/ includes.
2811         * ser-tcp.c: Fix common/ includes.
2812         * ser-pipe.c: Fix common/ includes.
2813         * ser-base.c: Fix common/ includes.
2814         * selftest-arch.c: Fix common/ includes.
2815         * s12z-tdep.c: Fix common/ includes.
2816         * rust-exp.y: Fix common/ includes.
2817         * rs6000-aix-tdep.c: Fix common/ includes.
2818         * riscv-tdep.c: Fix common/ includes.
2819         * remote.c: Fix common/ includes.
2820         * remote-notif.h: Fix common/ includes.
2821         * remote-fileio.h: Fix common/ includes.
2822         * remote-fileio.c: Fix common/ includes.
2823         * regcache.h: Fix common/ includes.
2824         * regcache.c: Fix common/ includes.
2825         * record-btrace.c: Fix common/ includes.
2826         * python/python.c: Fix common/ includes.
2827         * python/py-type.c: Fix common/ includes.
2828         * python/py-inferior.c: Fix common/ includes.
2829         * progspace.h: Fix common/ includes.
2830         * producer.c: Fix common/ includes.
2831         * procfs.c: Fix common/ includes.
2832         * proc-api.c: Fix common/ includes.
2833         * printcmd.c: Fix common/ includes.
2834         * ppc-linux-nat.c: Fix common/ includes.
2835         * parser-defs.h: Fix common/ includes.
2836         * osdata.c: Fix common/ includes.
2837         * obsd-nat.c: Fix common/ includes.
2838         * nat/x86-linux.c: Fix common/ includes.
2839         * nat/x86-linux-dregs.c: Fix common/ includes.
2840         * nat/x86-dregs.h: Fix common/ includes.
2841         * nat/x86-dregs.c: Fix common/ includes.
2842         * nat/ppc-linux.c: Fix common/ includes.
2843         * nat/mips-linux-watch.h: Fix common/ includes.
2844         * nat/mips-linux-watch.c: Fix common/ includes.
2845         * nat/linux-waitpid.c: Fix common/ includes.
2846         * nat/linux-ptrace.h: Fix common/ includes.
2847         * nat/linux-ptrace.c: Fix common/ includes.
2848         * nat/linux-procfs.c: Fix common/ includes.
2849         * nat/linux-personality.c: Fix common/ includes.
2850         * nat/linux-osdata.c: Fix common/ includes.
2851         * nat/linux-namespaces.c: Fix common/ includes.
2852         * nat/linux-btrace.h: Fix common/ includes.
2853         * nat/linux-btrace.c: Fix common/ includes.
2854         * nat/fork-inferior.c: Fix common/ includes.
2855         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2856         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2857         * nat/aarch64-linux.c: Fix common/ includes.
2858         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2859         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2860         * namespace.h: Fix common/ includes.
2861         * mips-linux-tdep.c: Fix common/ includes.
2862         * minsyms.c: Fix common/ includes.
2863         * mi/mi-parse.h: Fix common/ includes.
2864         * mi/mi-main.c: Fix common/ includes.
2865         * mi/mi-cmd-env.c: Fix common/ includes.
2866         * memrange.h: Fix common/ includes.
2867         * memattr.c: Fix common/ includes.
2868         * maint.h: Fix common/ includes.
2869         * maint.c: Fix common/ includes.
2870         * main.c: Fix common/ includes.
2871         * machoread.c: Fix common/ includes.
2872         * location.c: Fix common/ includes.
2873         * linux-thread-db.c: Fix common/ includes.
2874         * linux-nat.c: Fix common/ includes.
2875         * linux-fork.c: Fix common/ includes.
2876         * inline-frame.c: Fix common/ includes.
2877         * infrun.c: Fix common/ includes.
2878         * inflow.c: Fix common/ includes.
2879         * inferior.h: Fix common/ includes.
2880         * inferior.c: Fix common/ includes.
2881         * infcmd.c: Fix common/ includes.
2882         * inf-ptrace.c: Fix common/ includes.
2883         * inf-child.c: Fix common/ includes.
2884         * ia64-linux-nat.c: Fix common/ includes.
2885         * i387-tdep.c: Fix common/ includes.
2886         * i386-tdep.c: Fix common/ includes.
2887         * i386-linux-tdep.c: Fix common/ includes.
2888         * i386-linux-nat.c: Fix common/ includes.
2889         * i386-go32-tdep.c: Fix common/ includes.
2890         * i386-fbsd-tdep.c: Fix common/ includes.
2891         * i386-fbsd-nat.c: Fix common/ includes.
2892         * guile/scm-type.c: Fix common/ includes.
2893         * guile/guile.c: Fix common/ includes.
2894         * go32-nat.c: Fix common/ includes.
2895         * gnu-nat.c: Fix common/ includes.
2896         * gdbthread.h: Fix common/ includes.
2897         * gdbarch-selftests.c: Fix common/ includes.
2898         * gdb_usleep.c: Fix common/ includes.
2899         * gdb_select.h: Fix common/ includes.
2900         * gdb_bfd.c: Fix common/ includes.
2901         * gcore.c: Fix common/ includes.
2902         * fork-child.c: Fix common/ includes.
2903         * findvar.c: Fix common/ includes.
2904         * fbsd-nat.c: Fix common/ includes.
2905         * event-top.c: Fix common/ includes.
2906         * event-loop.c: Fix common/ includes.
2907         * dwarf2read.c: Fix common/ includes.
2908         * dwarf2loc.c: Fix common/ includes.
2909         * dwarf2-frame.c: Fix common/ includes.
2910         * dwarf-index-cache.c: Fix common/ includes.
2911         * dtrace-probe.c: Fix common/ includes.
2912         * disasm-selftests.c: Fix common/ includes.
2913         * defs.h: Fix common/ includes.
2914         * csky-tdep.c: Fix common/ includes.
2915         * cp-valprint.c: Fix common/ includes.
2916         * cp-support.h: Fix common/ includes.
2917         * cp-support.c: Fix common/ includes.
2918         * corelow.c: Fix common/ includes.
2919         * completer.h: Fix common/ includes.
2920         * completer.c: Fix common/ includes.
2921         * compile/compile.c: Fix common/ includes.
2922         * compile/compile-loc2c.c: Fix common/ includes.
2923         * compile/compile-cplus-types.c: Fix common/ includes.
2924         * compile/compile-cplus-symbols.c: Fix common/ includes.
2925         * command.h: Fix common/ includes.
2926         * cli/cli-dump.c: Fix common/ includes.
2927         * cli/cli-cmds.c: Fix common/ includes.
2928         * charset.c: Fix common/ includes.
2929         * build-id.c: Fix common/ includes.
2930         * btrace.h: Fix common/ includes.
2931         * btrace.c: Fix common/ includes.
2932         * breakpoint.h: Fix common/ includes.
2933         * breakpoint.c: Fix common/ includes.
2934         * ax.h:
2935         (enum agent_op): Fix common/ includes.
2936         * ax-general.c (struct aop_map): Fix common/ includes.
2937         * ax-gdb.c: Fix common/ includes.
2938         * auxv.c: Fix common/ includes.
2939         * auto-load.c: Fix common/ includes.
2940         * arm-tdep.c: Fix common/ includes.
2941         * arch/riscv.c: Fix common/ includes.
2942         * arch/ppc-linux-common.c: Fix common/ includes.
2943         * arch/i386.c: Fix common/ includes.
2944         * arch/arm.c: Fix common/ includes.
2945         * arch/arm-linux.c: Fix common/ includes.
2946         * arch/arm-get-next-pcs.c: Fix common/ includes.
2947         * arch/amd64.c: Fix common/ includes.
2948         * arch/aarch64.c: Fix common/ includes.
2949         * arch/aarch64-insn.c: Fix common/ includes.
2950         * arch-utils.c: Fix common/ includes.
2951         * amd64-windows-tdep.c: Fix common/ includes.
2952         * amd64-tdep.c: Fix common/ includes.
2953         * amd64-sol2-tdep.c: Fix common/ includes.
2954         * amd64-obsd-tdep.c: Fix common/ includes.
2955         * amd64-nbsd-tdep.c: Fix common/ includes.
2956         * amd64-linux-tdep.c: Fix common/ includes.
2957         * amd64-linux-nat.c: Fix common/ includes.
2958         * amd64-fbsd-tdep.c: Fix common/ includes.
2959         * amd64-fbsd-nat.c: Fix common/ includes.
2960         * amd64-dicos-tdep.c: Fix common/ includes.
2961         * amd64-darwin-tdep.c: Fix common/ includes.
2962         * agent.c: Fix common/ includes.
2963         * ada-lang.h: Fix common/ includes.
2964         * ada-lang.c: Fix common/ includes.
2965         * aarch64-tdep.c: Fix common/ includes.
2966
2967 2019-01-25  Tom Tromey  <tom@tromey.com>
2968
2969         * common/create-version.sh: Use common/version.h.
2970
2971 2019-01-24  Pedro Alves  <palves@redhat.com>
2972
2973         * infrun.c (signal_stop, signal_print, signal_program)
2974         (signal_catch, signal_pass): Now arrays instead of pointers.
2975         (update_signals_program_target, do_target_resume)
2976         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2977         * linux-nat.c (linux_nat_target::pass_signals)
2978         (linux_nat_target::create_inferior, linux_nat_target::attach):
2979         Adjust.
2980         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2981         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2982         * procfs.c (procfs_target::pass_signals): Adjust.
2983         * record-full.c (record_full_target::resume): Adjust.
2984         * remote.c (remote_target::pass_signals)
2985         (remote_target::program_signals): Adjust.
2986         * target-debug.h (target_debug_print_signals): Now takes a
2987         gdb::array_view as parameter.  Adjust.
2988         * target.h (target_ops) <pass_signals, program_signals>: Replace
2989         pointer and length parameters with gdb::array_view.
2990         (target_pass_signals, target_program_signals): Likewise.
2991         * target-delegates.c: Regenerate.
2992
2993 2019-01-24  Pedro Alves  <palves@redhat.com>
2994
2995         * common/forward-scope-exit.h
2996         (forward_scope_exit::forward_scope_exit): Pass arguments to
2997         m_bind_function directly, instead of creating a std::bind and
2998         copying that.
2999
3000 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
3001
3002         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
3003         for static members.
3004         (pass_in_v_vfp_candidate): Likewise.
3005
3006 2019-01-23  Tom Tromey  <tom@tromey.com>
3007             Pedro Alves  <palves@redhat.com>
3008
3009         * regcache.c (class regcache_invalidator): Remove.
3010         (regcache::raw_write): Use make_scope_exit.
3011
3012 2019-01-23  Tom Tromey  <tom@tromey.com>
3013
3014         * ui-out.h (class ui_out_emit_type): Update comment.
3015
3016 2019-01-23  Tom Tromey  <tom@tromey.com>
3017
3018         * infrun.c (fetch_inferior_event): Update comment.
3019
3020 2019-01-23  Tom Tromey  <tom@tromey.com>
3021             Pedro Alves  <palves@redhat.com>
3022
3023         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
3024         parameter.
3025         (fetch_inferior_event): Use SCOPE_EXIT.
3026
3027
3028 2019-01-23  Tom Tromey  <tom@tromey.com>
3029             Pedro Alves  <palves@redhat.com>
3030
3031         * infrun.c (disable_thread_events): Delete.
3032         (stop_all_threads): Use SCOPE_EXIT.
3033
3034 2019-01-23  Tom Tromey  <tom@tromey.com>
3035             Pedro Alves  <palves@redhat.com>
3036
3037         * symfile.c: Include forward-scope-exit.h.
3038         (clear_symtab_users_cleanup): Replace forward declaration with
3039         a FORWARD_SCOPE_EXIT.
3040         (syms_from_objfile_1): Use the forward_scope_exit and
3041         gdb::optional instead of cleanup_function.
3042         (reread_symbols): Use the forward_scope_exit instead of
3043         cleanup_function.
3044         (clear_symtab_users_cleanup): Remove function.
3045
3046 2019-01-23  Tom Tromey  <tom@tromey.com>
3047             Pedro Alves  <palves@redhat.com>
3048
3049         * linux-nat.c: Include scope-exit.h.
3050         (cleanup_target_stop): Remove.
3051         (linux_nat_target::static_tracepoint_markers_by_strid): Use
3052         SCOPE_EXIT.
3053
3054 2019-01-23  Tom Tromey  <tom@tromey.com>
3055             Pedro Alves  <palves@redhat.com>
3056
3057         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
3058         (call_function_by_hand_dummy): Use SCOPE_EXIT.
3059
3060 2019-01-23  Tom Tromey  <tom@tromey.com>
3061             Andrew Burgess  <andrew.burgess@embecosm.com>
3062             Pedro Alves  <palves@redhat.com>
3063
3064         * infrun.c (fetch_inferior_event): Use scope_exit.
3065         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
3066         * top.c (execute_command): Use scope_exit.
3067         * breakpoint.c (bpstat_do_actions): Use scope_exit.
3068         * utils.c (do_bpstat_clear_actions_cleanup)
3069         (make_bpstat_clear_actions_cleanup): Remove.
3070
3071 2019-01-23  Tom Tromey  <tom@tromey.com>
3072             Pedro Alves  <palves@redhat.com>
3073
3074         * infrun.c: Include "common/scope-exit.h"
3075         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
3076         (wait_for_inferior): Use SCOPE_EXIT.
3077         (fetch_inferior_event): Use scope_exit.
3078
3079 2019-01-23  Tom Tromey  <tom@tromey.com>
3080             Pedro Alves  <palves@redhat.com>
3081
3082         * breakpoint.c (create_breakpoint): Remove cleanup.
3083
3084 2019-01-23  Tom Tromey  <tom@tromey.com>
3085             Andrew Burgess  <andrew.burgess@embecosm.com>
3086             Pedro Alves  <palves@redhat.com>
3087
3088 2019-01-23  Pedro Alves  <palves@redhat.com>
3089
3090         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
3091
3092 2019-01-23  Pedro Alves  <palves@redhat.com>
3093             Andrew Burgess  <andrew.burgess@embecosm.com>
3094
3095         * gdbthread.h: Include "common/forward-scope-exit.h".
3096         (scoped_finish_thread_state): Redefine custom class in terms of
3097         forward_scope_exit.
3098
3099 2019-01-23  Pedro Alves  <palves@redhat.com>
3100             Andrew Burgess  <andrew.burgess@embecosm.com>
3101
3102         * common/forward-scope-exit.h: New file.
3103
3104 2019-01-23  Pedro Alves  <palves@redhat.com>
3105             Andrew Burgess  <andrew.burgess@embecosm.com>
3106             Tom Tromey  <tom@tromey.com>
3107
3108         * common/scope-exit.h: New file.
3109
3110 2019-01-23  Pedro Alves  <palves@redhat.com>
3111
3112         * common/preprocessor.h (ESC): Rename to ...
3113         (ESC_PARENS): ... this.
3114         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
3115         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
3116
3117 2019-01-23  Tom Tromey  <tom@tromey.com>
3118
3119         * language.h (class scoped_switch_to_sym_language_if_auto):
3120         Initialize m_lang in both cases.
3121
3122 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
3123
3124         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
3125         with XCNEW.
3126
3127 2019-01-22  Tom Tromey  <tom@tromey.com>
3128
3129         * corelow.c: Do not include sys/file.h.
3130
3131 2019-01-22  Tom Tromey  <tom@tromey.com>
3132
3133         * tui/tui-wingeneral.h: Include gdb_curses.h.
3134
3135 2019-01-22  Tom Tromey  <tom@tromey.com>
3136
3137         * source-cache.h (class source_cache) <get_source_lines,
3138         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
3139
3140 2019-01-22  Tom Tromey  <tom@tromey.com>
3141
3142         * remote-fileio.h (struct remote_target): Declare.
3143
3144 2019-01-22  Tom Tromey  <tom@tromey.com>
3145
3146         * python/py-arch.c: Do not include py-ref.h.
3147         * python/py-bpevent.c: Do not include py-ref.h.
3148         * python/py-cmd.c: Do not include py-ref.h.
3149         * python/py-continueevent.c: Do not include py-ref.h.
3150         * python/py-event.h: Do not include py-ref.h.
3151         * python/py-evtregistry.c: Do not include py-ref.h.
3152         * python/py-finishbreakpoint.c: Do not include py-ref.h.
3153         * python/py-frame.c: Do not include py-ref.h.
3154         * python/py-framefilter.c: Do not include py-ref.h.
3155         * python/py-function.c: Do not include py-ref.h.
3156         * python/py-infevents.c: Do not include py-ref.h.
3157         * python/py-linetable.c: Do not include py-ref.h.
3158         * python/py-objfile.c: Do not include py-ref.h.
3159         * python/py-param.c: Do not include py-ref.h.
3160         * python/py-prettyprint.c: Do not include py-ref.h.
3161         * python/py-progspace.c: Do not include py-ref.h.
3162         * python/py-symbol.c: Do not include py-ref.h.
3163         * python/py-symtab.c: Do not include py-ref.h.
3164         * python/py-type.c: Do not include py-ref.h.
3165         * python/py-unwind.c: Do not include py-ref.h.
3166         * python/py-utils.c: Do not include py-ref.h.
3167         * python/py-value.c: Do not include py-ref.h.
3168         * python/py-varobj.c: Do not include py-ref.h.
3169         * python/py-xmethods.c: Do not include py-ref.h.
3170         * python/python.c: Do not include py-ref.h.
3171         * varobj.c: Do not include py-ref.h.
3172
3173 2019-01-22  Tom Tromey  <tom@tromey.com>
3174
3175         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
3176         keyword for bcache.
3177
3178 2019-01-22  Tom Tromey  <tom@tromey.com>
3179
3180         * compile/compile-cplus-types.c: Remove a comment by #include.
3181
3182 2019-01-22  Tom Tromey  <tom@tromey.com>
3183
3184         * compile/gcc-c-plugin.h: Include compile-internal.h.
3185
3186 2019-01-22  Tom Tromey  <tom@tromey.com>
3187
3188         * stabsread.c (EXTERN): Do not define.
3189         (symnum, next_symbol_text_func, processing_gcc_compilation)
3190         (within_function, global_sym_chain, global_stabs)
3191         (previous_stab_code, this_object_header_files)
3192         (n_this_object_header_files)
3193         (n_allocated_this_object_header_files): Define.
3194         * stabsread.h (EXTERN): Never define.  Use "extern".
3195
3196 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3197
3198         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
3199         history_value.
3200
3201 2019-01-21  Tom Tromey  <tom@tromey.com>
3202
3203         * ui-out.c: Fix includes.
3204         * tui/tui-source.c: Fix includes.
3205         * target.c: Fix includes.
3206         * remote.c: Fix includes.
3207         * regcache.c: Fix includes.
3208         * python/py-block.c: Fix includes.
3209         * printcmd.c: Fix includes.
3210         * or1k-tdep.c: Fix includes.
3211         * mi/mi-main.c: Fix includes.
3212         * m32r-tdep.c: Fix includes.
3213         * csky-tdep.c: Fix includes.
3214         * compile/compile-cplus-types.c: Fix includes.
3215         * cli/cli-interp.c: Fix includes.
3216
3217 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
3218
3219         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
3220         for padding.
3221
3222 2019-01-16  Tom Tromey  <tom@tromey.com>
3223
3224         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
3225         earlier.
3226         (struct objfile) <msymbols_range>: Move from top level.
3227         <msymbols>: New method.
3228         (class objfile_msymbols): Remove.
3229         * symtab.c (default_collect_symbol_completion_matches_break_on):
3230         Update.
3231         * symmisc.c (dump_msymbols): Update.
3232         * stabsread.c (scan_file_globals): Update.
3233         * objc-lang.c (info_selectors_command, info_classes_command)
3234         (find_methods): Update.
3235         * minsyms.c (find_solib_trampoline_target): Update.
3236         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
3237         * coffread.c (coff_symfile_read): Update.
3238         * ada-lang.c (ada_lookup_simple_minsym)
3239         (ada_collect_symbol_completion_matches): Update.
3240
3241 2019-01-16  Tom Tromey  <tom@tromey.com>
3242
3243         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
3244         type.  Remove no-argument constructor.
3245         <iterator::operator++>: Simplify.
3246         <begin>: Update.
3247         <end>: Use minimal_symbol_count.
3248
3249 2019-01-16  Tom Tromey  <tom@tromey.com>
3250
3251         * objfiles.h (struct objfile) <psymtabs>: New method.
3252         (class objfile_psymtabs): Remove.
3253         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
3254         typedef.
3255         <range>: New method.
3256         (require_partial_symbols): Change return type.
3257         * psymtab.c (require_partial_symbols)
3258         (psym_expand_symtabs_matching): Update.
3259         * mdebugread.c (parse_partial_symbols): Update.
3260         * dbxread.c (dbx_end_psymtab): Update.
3261
3262 2019-01-15  Tom Tromey  <tom@tromey.com>
3263
3264         * symtab.c (lookup_objfile_from_block)
3265         (lookup_symbol_in_objfile_symtabs)
3266         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
3267         (find_line_symtab, info_sources_command)
3268         (default_collect_symbol_completion_matches_break_on)
3269         (make_source_files_completion_list): Update.
3270         * symmisc.c (print_objfile_statistics, dump_objfile)
3271         (maintenance_print_symbols, maintenance_info_symtabs)
3272         (maintenance_check_symtabs, maintenance_info_line_tables):
3273         Update.
3274         * source.c (select_source_symtab)
3275         (forget_cached_source_info_for_objfile): Update.
3276         * objfiles.h (class objfile_compunits): Remove.
3277         (struct objfile) <compunits_range>: New typedef.
3278         (compunits): New method.
3279         * objfiles.c (objfile_relocate1): Update.
3280         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
3281         * maint.c (count_symtabs_and_blocks): Update.
3282         * linespec.c (iterate_over_all_matching_symtabs): Update.
3283         * cp-support.c (add_symbol_overload_list_qualified): Update.
3284         * coffread.c (coff_symtab_read): Update.
3285         * ada-lang.c (add_nonlocal_symbols)
3286         (ada_collect_symbol_completion_matches)
3287         (ada_add_global_exceptions): Update.
3288
3289 2019-01-15  Tom Tromey  <tom@tromey.com>
3290
3291         * progspace.h (program_space) <objfiles_safe_range>: New
3292         typedef.
3293         <objfiles_safe>: New method.
3294         * objfiles.h (class all_objfiles_safe): Remove.
3295         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
3296         * jit.c (jit_inferior_exit_hook): Update.
3297
3298 2019-01-17  Tom Tromey  <tom@tromey.com>
3299
3300         * progspace.h (program_space) <objfiles_range>: New typedef.
3301         <objfiles>: New method.
3302         <objfiles_head>: Rename from objfiles.
3303         (object_files): Update.
3304         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
3305         * guile/scm-pretty-print.c
3306         (ppscm_find_pretty_printer_from_objfiles): Update.
3307         * guile/scm-objfile.c (gdbscm_objfiles): Update.
3308         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
3309         Update.
3310         * python/py-progspace.c (pspy_get_objfiles): Update.
3311         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3312         Update.
3313         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3314         (objfpy_lookup_objfile_by_build_id): Update.
3315         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
3316         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3317         Update.
3318         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3319         (expand_symtab_containing_pc, lookup_objfile_from_block)
3320         (lookup_static_symbol, basic_lookup_transparent_type)
3321         (find_pc_sect_compunit_symtab, find_symbol_at_address)
3322         (find_line_symtab, info_sources_command)
3323         (default_collect_symbol_completion_matches_break_on)
3324         (make_source_files_completion_list, find_main_name): Update.
3325         * symmisc.c (print_symbol_bcache_statistics)
3326         (print_objfile_statistics, maintenance_print_symbols)
3327         (maintenance_print_msymbols, maintenance_print_objfiles)
3328         (maintenance_info_symtabs, maintenance_check_symtabs)
3329         (maintenance_expand_symtabs, maintenance_info_line_tables):
3330         Update.
3331         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
3332         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
3333         (map_overlay_command, unmap_overlay_command)
3334         (simple_overlay_update, expand_symtabs_matching)
3335         (map_symbol_filenames): Update.
3336         * symfile-debug.c (set_debug_symfile): Update.
3337         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
3338         Update.
3339         * source.c (select_source_symtab, forget_cached_source_info):
3340         Update.
3341         * solib.c (solib_read_symbols): Update.
3342         * solib-spu.c (append_ocl_sos): Update.
3343         * psymtab.c (maintenance_print_psymbols)
3344         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
3345         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
3346         * printcmd.c (info_symbol_command): Update.
3347         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
3348         Update.
3349         * objfiles.h (class all_objfiles): Remove.
3350         * objfiles.c (have_partial_symbols, have_full_symbols)
3351         (have_minimal_symbols, qsort_cmp, update_section_map)
3352         (shared_objfile_contains_address_p)
3353         (default_iterate_over_objfiles_in_search_order): Update.
3354         * objc-lang.c (info_selectors_command, info_classes_command)
3355         (find_methods): Update.
3356         * minsyms.c (find_solib_trampoline_target): Update.
3357         * maint.c (maintenance_info_sections)
3358         (maintenance_translate_address, count_symtabs_and_blocks):
3359         Update.
3360         * main.c (captured_main_1): Update.
3361         * linux-thread-db.c (try_thread_db_load_from_pdir)
3362         (has_libpthread): Update.
3363         * linespec.c (iterate_over_all_matching_symtabs)
3364         (search_minsyms_for_name): Update.
3365         * jit.c (jit_find_objf_with_entry_addr): Update.
3366         * hppa-tdep.c (find_unwind_entry)
3367         (hppa_lookup_stub_minimal_symbol): Update.
3368         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
3369         Update.
3370         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3371         (elf_gnu_ifunc_resolve_by_got): Update.
3372         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
3373         * dwarf-index-write.c (save_gdb_index_command): Update.
3374         * cp-support.c (add_symbol_overload_list_qualified): Update.
3375         * breakpoint.c (create_overlay_event_breakpoint)
3376         (create_longjmp_master_breakpoint)
3377         (create_std_terminate_master_breakpoint)
3378         (create_exception_master_breakpoint): Update.
3379         * blockframe.c (find_pc_partial_function): Update.
3380         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
3381         (ada_collect_symbol_completion_matches)
3382         (ada_add_global_exceptions): Update.
3383
3384 2019-01-17  Tom Tromey  <tom@tromey.com>
3385
3386         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
3387         declare VEC.
3388         (solib_target_parse_libraries): Change return type.
3389         (library_list_start_segment, library_list_start_section)
3390         (library_list_end_library, library_list_start_library); Update.
3391         (solib_target_free_library_list): Remove.
3392         (solib_target_parse_libraries): Remove cleanup.  Change return
3393         type.
3394         (solib_target_current_sos): Update.
3395
3396 2019-01-17  Tom Tromey  <tromey@bapiya>
3397
3398         * valprint.c: Replace "the the" with "the".
3399         * symtab.c: Replace "the the" with "the".
3400         * solib.c: Replace "the the" with "the".
3401         * solib-dsbt.c: Replace "the the" with "the".
3402         * linespec.c: Replace "the the" with "the".
3403         * dwarf2loc.h: Replace "the the" with "the".
3404         * amd64-windows-tdep.c: Replace "the the" with "the".
3405         * aarch64-tdep.c: Replace "the the" with "the".
3406
3407 2019-01-16  Keith Seitz  <keiths@redhat.com>
3408
3409         PR gdb/23773
3410         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
3411         <builder>: Rename to ..
3412         <m_builder>: ... this and make private.
3413         (dwarf2_cu::get_builder): New method.  Change all users of
3414         `builder' to use this method.
3415         (dwarf2_start_symtab): Move to ...
3416         (dwarf2_cu::start_symtab): ... here.  Update all callers
3417         (setup_type_unit_groups): Move to ...
3418         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
3419         callers.
3420         (dwarf2_cu::reset_builder): New method.
3421         (process_full_compunit, process_full_type_unit): Use
3422         dwarf2_cu::reset_builder.
3423         (follow_die_offset): Record the ancestor CU if it is different
3424         from the followed DIE's CU.
3425         (follow_die_sig_1): Likewise.
3426
3427 2019-01-15  Tom Tromey  <tom@tromey.com>
3428
3429         * remote.c (class remote_state) <buf>: Now a char_vector.
3430         <buf_size>: Remove.
3431         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
3432         parameter.
3433         (remote_target::getpkt_or_notif_sane_1)
3434         (remote_target::getpkt_sane)
3435         (remote_target::getpkt_or_notif_sane): Likewise.
3436         (class remote_target) <putpkt>: New overload.
3437         (remote_target::read_frame): Change type of "buf_p".  Remove
3438         sizeof_p parameter.
3439         (packet_ok): New overload.
3440         (packet_check_result): New overload.
3441         Update all uses.
3442
3443 2019-01-14  Tom Tromey  <tom@tromey.com>
3444
3445         * remote-notif.c (handle_notification, remote_notif_ack)
3446         (remote_notif_parse): Make "buf" const.
3447         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
3448         const.
3449         (remote_notif_parse, remote_notif_ack, handle_notification):
3450         Likewise.
3451         * remote.c (remote_notif_stop_parse): Make "buf" const.
3452         (remote_target::remote_parse_stop_reply): Make "buf" const.
3453         (remote_notif_stop_ack): Make "buf" const.
3454
3455 2019-01-14  Tom Tromey  <tom@tromey.com>
3456
3457         * remote.c (remote_console_output): Make parameter const.
3458
3459 2019-01-14  Tom Tromey  <tom@tromey.com>
3460
3461         * target-debug.h (target_debug_print_signals): Constify.
3462         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
3463         * procfs.c (procfs_target::pass_signals): Update.
3464         * linux-nat.c (linux_nat_target::pass_signals): Update.
3465         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
3466         * target-delegates.c: Rebuild.
3467         * remote.c (remote_target::program_signals): Update.
3468         (remote_target::pass_signals): Update.
3469         * target.c (target_pass_signals): Constify argument.
3470         (target_program_signals): Likewise.
3471         * target.h (struct target_ops) <pass_signals, program_signals>:
3472         Constify argument.
3473         (target_pass_signals, target_program_signals): Constify argument.
3474
3475 2019-01-14  Tom Tromey  <tom@tromey.com>
3476
3477         PR tui/28819:
3478         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
3479
3480 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3481
3482         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
3483         field.
3484         * rs6000-tdep.c: Include reggroups.h.
3485         (IS_V_ALIAS_PSEUDOREG): Define.
3486         (rs6000_register_name): Return names for the "vX" aliases.
3487         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
3488         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
3489         aliases.  Call default_register_reggroup_p for all other
3490         pseudo-registers.
3491         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
3492         New functions.
3493         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
3494         Handle "vX" aliases.
3495         (v_alias_pseudo_register_collect): New function.
3496         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
3497         (rs6000_gdbarch_init): Initialize "vX" aliases as
3498         pseudo-registers.  Restore registration of
3499         rs6000_pseudo_register_reggroup_p with
3500         set_tdesc_pseudo_register_reggroup_p.
3501
3502 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
3503
3504         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
3505         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
3506         set_gdbarch_num_pseudo_regs.
3507
3508 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3509
3510         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
3511         Remove arg prefixname, add do_set and do_show.
3512         Add member functions set_list and show_list.
3513         * cli/cli-style.c (class cli_style_option): Update accordingly.
3514         (style_set_list): Move to file scope.
3515         (style_show_list): Likewise.
3516         (set_style): Call help_list.
3517         (show_style): Call cmd_show_list.
3518         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
3519         Update to use the new macro.
3520
3521 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
3522
3523         * ada-lang.c (_initialize_ada_language): Expand the help text
3524         for the "catch exception" command.
3525
3526 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3527
3528         * symtab.c (matching_obj_sections): Initialize obj,
3529         declare it closer to its usage.
3530
3531 2019-01-10  Tom Tromey  <tom@tromey.com>
3532
3533         * thread-iter.h (inf_threads_iterator): Use next_iterator.
3534         (basic_inf_threads_range): Remove.
3535         (inf_threads_range, inf_non_exited_threads_range)
3536         (safe_inf_threads_range): Use next_adapter.
3537
3538 2019-01-10  Keith Seitz  <keiths@redhat.com>
3539
3540         PR gdb/23712
3541         PR symtab/23010
3542         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
3543         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
3544
3545 2019-01-10  Keith Seitz  <keiths@redhat.com>
3546
3547         PR gdb/23712
3548         PR symtab/23010
3549         * dictionary.c (pending_to_vector): Remove.
3550         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3551         Remove _1 suffix, replacing functions of the same name.  Update
3552         all callers.
3553         (dict_create_hashed, dict_create_hashed_expandable)
3554         (dict_create_linear, dict_create_linear_expandable, dict_free)
3555         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
3556         Make functions static.
3557
3558 2019-01-10  Keith Seitz  <keiths@redhat.com>
3559
3560         PR gdb/23712
3561         PR symtab/23010
3562         * dictionary.h (struct dictionary): Replace declaration with
3563         multidictionary.
3564         (dict_create_hashed, dict_create_hashed_expandable)
3565         (dict_create_linear, dict_create_linear_expandable)
3566         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
3567         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
3568         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
3569         taking multidictionary argument.
3570         [ALL_DICT_SYMBOLS]: Update for multidictionary.
3571         * block.h (struct block) <dict>: Change to multidictionary
3572         and rename `multidict'.
3573         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
3574         symmisc.c: Update all dictionary references to multidictionary.
3575
3576 2019-01-10  Keith Seitz  <keiths@redhat.com>
3577
3578         PR gdb/23712
3579         PR symtab/23010
3580         * dictionary.c: Include unordered_map.
3581         (pending_to_vector): New function.
3582         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3583         Rewrite the non-"_1" functions to take vector instead
3584         of linked list.
3585         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
3586         "new" _1 versions of the same name.
3587         (multidictionary): Define.
3588         (std::hash<enum language): New definition.
3589         (collate_pending_symbols_by_language, mdict_create_hashed)
3590         (mdict_create_hashed_expandable, mdict_create_linear)
3591         (mdict_create_linear_expandable, mdict_free)
3592         (find_language_dictionary, create_new_language_dictionary)
3593         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
3594         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
3595         (mdict_size, mdict_empty): New functions.
3596         * dictionary.h (mdict_iterator): Define.
3597
3598 2019-01-10  Pedro Alves  <palves@redhat.com>
3599
3600         * breakpoint.c (read_uploaded_action)
3601         (create_tracepoint_from_upload): Adjust to use
3602         gdb::unique_xmalloc_ptr.
3603         * ctf.c (ctf_write_uploaded_tp):
3604         (SET_ARRAY_FIELD): Use emplace_back.
3605         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
3606         * tracefile-tfile.c (tfile_write_uploaded_tp):
3607         * tracepoint.c (parse_tracepoint_definition): Adjust to use
3608         gdb::unique_xmalloc_ptr.
3609         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
3610         at_string, cond_string, cmd_strings>: Replace char pointers
3611         with gdb::unique_xmalloc_ptr.
3612
3613 2019-01-10  Pedro Alves  <palves@redhat.com>
3614
3615         * solib-target.c (library_list_start_library): Don't xstrdup name.
3616
3617 2019-01-10  Pedro Alves  <palves@redhat.com>
3618
3619         * mdebugread.c (parse_partial_symbols): Use
3620         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3621
3622 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3623
3624         * linux-fork.c (scoped_switch_fork_info)
3625         <~scoped_switch_fork_info>: Fix incorrect variable name.
3626
3627 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3628
3629         * linux-fork.c (scoped_switch_fork_info)
3630         <scoped_switch_fork_info>: Make explicit.
3631         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3632
3633 2019-01-10  Tom Tromey  <tom@tromey.com>
3634
3635         * objfiles.h (objfile::reset_psymtabs): Update.
3636         * objfiles.c (objfile::objfile): Update.
3637         * psymtab.h (psymtab_storage::obstack): Update.
3638         (psymtab_storage::m_obstack): Use gdb::optional.
3639         (class psymtab_storage): Update comment.  Remove objfile
3640         parameter.
3641         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3642
3643 2019-01-10  Tom Tromey  <tom@tromey.com>
3644
3645         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3646         <free_psymtabs>: Now private.
3647         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3648         (allocate_psymtab): Use new method.
3649
3650 2019-01-10  Tom Tromey  <tom@tromey.com>
3651
3652         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3653         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3654         * mdebugread.c (parse_partial_symbols): Use
3655         allocate_dependencies.
3656         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3657         allocate_dependencies.
3658         (process_psymtab_comp_unit_reader)
3659         (build_type_psymtab_dependencies): Likewise.
3660         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3661
3662 2019-01-10  Tom Tromey  <tom@tromey.com>
3663
3664         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3665         PSYMBOL_SET_LANGUAGE.
3666         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3667
3668 2019-01-10  Tom Tromey  <tom@tromey.com>
3669
3670         * psymtab.h (psymtab_storage::obstack): New method.
3671         <m_obstack>: Rename from obstack; now private.
3672         * psymtab.c (psymtab_storage): Update.
3673         * dwarf2read.c (create_addrmap_from_index)
3674         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3675         Update.
3676
3677 2019-01-10  Tom Tromey  <tom@tromey.com>
3678
3679         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3680         * objfiles.h (objfile::reset_psymtabs): New method.
3681
3682 2019-01-10  Tom Tromey  <tom@tromey.com>
3683
3684         * symmisc.c (print_symbol_bcache_statistics): Update.
3685         (print_objfile_statistics): Update.
3686         * symfile.c (reread_symbols): Update.
3687         * psymtab.h (class psymtab_storage): New.
3688         * psymtab.c (psymtab_storage): New constructor.
3689         (~psymtab_storage): New destructor.
3690         (require_partial_symbols): Update.
3691         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3692         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3693         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3694         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3695         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3696         (start_psymtab_common, end_psymtab_common)
3697         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3698         (allocate_psymtab): Update.
3699         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3700         Update.
3701         (dump_psymtab_addrmap, maintenance_print_psymbols)
3702         (maintenance_check_psymtabs): Update.
3703         (class objfile_psymtabs): Move to objfiles.h.
3704         * psympriv.h (discard_psymtab): Now inline.
3705         (psymtab_discarder::psymtab_discarder): Update.
3706         (psymtab_discarder::~psymtab_discarder): Update.
3707         (ALL_OBJFILE_PSYMTABS): Rewrite.
3708         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3709         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3710         Remove fields.
3711         <partial_symtabs>: New field.
3712         (class objfile_psymtabs): Move from psymtab.h.  Update.
3713         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3714         psymbol_cache.
3715         (objfile::~objfile): Don't destroy psymbol_cache.
3716         * mdebugread.c (parse_partial_symbols): Update.
3717         * dwarf2read.c (create_addrmap_from_index)
3718         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3719         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3720         (add_partial_subprogram, dwarf2_ranges_read): Update.
3721         * dwarf-index-write.c (write_address_map)
3722         (write_one_signatured_type, recursively_write_psymbols)
3723         (class debug_names, class debug_names, write_psymtabs_to_index):
3724         Update.
3725
3726 2019-01-10  Tom Tromey  <tom@tromey.com>
3727
3728         * symtab.h (SYMBOL_SET_NAMES): Update.
3729         (symbol_set_names): Update.
3730         (MSYMBOL_SET_NAMES): Update.
3731         * symtab.c (symbol_set_names): Change argument to be an
3732         objfile_per_bfd_storage.
3733         * psymtab.c (add_psymbol_to_bcache): Update.
3734         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3735
3736 2019-01-10  Tom Tromey  <tom@tromey.com>
3737
3738         * symtab.c (create_demangled_names_hash): Change argument to be an
3739         objfile_per_bfd_storage.
3740         (symbol_set_names): Update.
3741
3742 2019-01-10  Tom Tromey  <tom@tromey.com>
3743
3744         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3745         init_psymbol_list.
3746         * psymtab.c (init_psymbol_list): Do nothing if already called.
3747         * psympriv.h (init_psymbol_list): Add comment.
3748         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3749         init_psymbol_list.
3750         * dbxread.c (dbx_symfile_read): Unconditionally call
3751         init_psymbol_list.
3752
3753 2019-01-10  Tom Tromey  <tom@tromey.com>
3754
3755         * xcoffread.c (scan_xcoff_symtab): Update.
3756         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3757         "where".
3758         * mdebugread.c (parse_partial_symbols)
3759         (handle_psymbol_enumerators): Update.
3760         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3761         * dbxread.c (read_dbx_symtab): Update.
3762         * psympriv.h (psymbol_placement): New enum.
3763         (add_psymbol_to_list): Update.
3764
3765 2019-01-10  Tom Tromey  <tom@tromey.com>
3766
3767         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3768         static_psymbols parameters.
3769         (scan_xcoff_symtab): Update.
3770         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3771         static_psymbols parameters.
3772         * psympriv.h (start_psymtab_common): Update.
3773         * mdebugread.c (parse_partial_symbols): Update.
3774         * dwarf2read.c (create_partial_symtab): Update.
3775         * dbxread.c (read_dbx_symtab): Update.
3776         (start_psymtab): Remove global_psymbols and static_psymbols
3777         parameters.
3778
3779 2019-01-10  Tom Tromey  <tom@tromey.com>
3780
3781         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3782         * psymtab.c (allocate_psymtab): Add comment.
3783         * psympriv.h (allocate_psymtab): Add comment.
3784         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3785         initializations.
3786         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3787
3788 2019-01-10  Tom Tromey  <tom@tromey.com>
3789
3790         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3791         Don't declare.
3792         * mipsread.c: Include mdebugread.h.
3793         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3794         Declare.
3795         * elfread.c: Include mdebugread.h.
3796
3797 2019-01-09  Tom Tromey  <tom@tromey.com>
3798
3799         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3800         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3801         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3802         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3803         (psym_lookup_symbol, psym_find_last_source_symtab)
3804         (psym_forget_cached_source_info, psym_print_stats)
3805         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3806         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3807         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3808         (psym_find_compunit_symtab_by_address)
3809         (maintenance_print_psymbols, maintenance_info_psymtabs)
3810         (maintenance_check_psymtabs): Use ranged for.
3811         * psymtab.h (class objfile_psymtabs): New.
3812         (require_partial_symbols): Return objfile_psymtabs.
3813         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3814
3815 2019-01-09  Tom Tromey  <tom@tromey.com>
3816
3817         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3818         (find_pc_mapped_section, list_overlays_command)
3819         (map_overlay_command, unmap_overlay_command)
3820         (simple_overlay_update): Use all_objfiles.
3821         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3822         * printcmd.c (info_symbol_command): Use all_objfiles.
3823         * objfiles.h (ALL_OBJSECTIONS): Remove.
3824         * maint.c (maintenance_translate_address): Use all_objfiles.
3825         * gcore.c (gcore_create_callback): Use all_objfiles.
3826         (objfile_find_memory_regions): Likewise.
3827
3828 2019-01-09  Tom Tromey  <tom@tromey.com>
3829
3830         * symtab.c (find_line_symtab, info_sources_command)
3831         (make_source_files_completion_list): Use objfile_compunits.
3832         * source.c (select_source_symtab): Use objfile_compunits.
3833         * objfiles.h (struct objfile): Update comment.
3834         (ALL_OBJFILES): Remove.
3835         (ALL_FILETABS): Remove.
3836         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3837         objfile_compunits.
3838
3839 2019-01-09  Tom Tromey  <tom@tromey.com>
3840
3841         * symmisc.c (print_objfile_statistics, dump_objfile)
3842         (maintenance_print_symbols): Use compunit_filetabs.
3843         * source.c (forget_cached_source_info_for_objfile): Use
3844         compunit_filetabs.
3845         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3846         (ALL_FILETABS): Use compunit_filetabs.
3847         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3848         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3849
3850 2019-01-09  Tom Tromey  <tom@tromey.com>
3851
3852         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3853         (compunit_filetabs): New.
3854         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3855         compunit_filetabs.
3856         (info_sources_command, make_source_files_completion_list): Remove
3857         declaration.
3858         * symmisc.c (print_objfile_statistics, dump_objfile)
3859         (maintenance_print_symbols): Remove declaration.
3860         (maintenance_info_symtabs): Use compunit_filetabs.
3861         (maintenance_info_line_tables): Likewise.
3862         * source.c (select_source_symtab): Change local variable name.
3863         (forget_cached_source_info_for_objfile): Remove declaration.
3864         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3865         * objfiles.c (objfile_relocate1): Remove declaration.
3866         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3867         declaration.
3868         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3869         * coffread.c (coff_symtab_read): Remove declaration.
3870         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3871         compunit_filetabs.
3872
3873 2019-01-09  Tom Tromey  <tom@tromey.com>
3874
3875         * symtab.c (lookup_objfile_from_block)
3876         (find_pc_sect_compunit_symtab, search_symbols)
3877         (default_collect_symbol_completion_matches_break_on): Use
3878         objfile_compunits.
3879         * objfiles.h (ALL_COMPUNITS): Remove.
3880         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3881         * cp-support.c (add_symbol_overload_list_qualified): Use
3882         objfile_compunits.
3883         * ada-lang.c (ada_collect_symbol_completion_matches)
3884         (ada_add_global_exceptions): Use objfile_compunits.
3885
3886 2019-01-09  Tom Tromey  <tom@tromey.com>
3887
3888         * source.c (select_source_symtab)
3889         (forget_cached_source_info_for_objfile): Remove declaration.
3890         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3891         declaration.
3892         * maint.c (count_symtabs_and_blocks): Remove declaration.
3893         * cp-support.c (add_symbol_overload_list_qualified): Remove
3894         declaration.
3895         * coffread.c (coff_symtab_read): Remove declaration.
3896         * symtab.c (lookup_symbol_in_objfile_symtabs)
3897         (basic_lookup_transparent_type_1): Use objfile_compunits.
3898         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3899         (info_sources_command, search_symbols)
3900         (default_collect_symbol_completion_matches_break_on)
3901         (make_source_files_completion_list): Remove declaration.
3902         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3903         (ada_collect_symbol_completion_matches)
3904         (ada_add_global_exceptions): Remove declaration.
3905         * linespec.c (iterate_over_all_matching_symtabs): Use
3906         objfile_compunits.
3907         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3908         (class objfile_compunits): New.
3909         (ALL_COMPUNITS): Use objfile_compunits.
3910         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3911         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3912         objfile_compunits.
3913         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3914
3915 2019-01-09  Tom Tromey  <tom@tromey.com>
3916
3917         * symtab.c (search_symbols)
3918         (default_collect_symbol_completion_matches_break_on): Use
3919         objfile_msymbols.
3920         * ada-lang.c (ada_lookup_simple_minsym)
3921         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3922         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3923         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3924         objfile_msymbols.
3925         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3926         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3927         * objc-lang.c (find_methods): Use objfile_msymbols.
3928         (info_selectors_command, info_classes_command): Likewise.
3929         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3930         * objfiles.h (class objfile_msymbols): New.
3931         (ALL_OBJFILE_MSYMBOLS): Remove.
3932         (ALL_MSYMBOLS): Remove.
3933
3934 2019-01-09  Tom Tromey  <tom@tromey.com>
3935
3936         * common/next-iterator.h (next_adapter): Add Iterator template
3937         parameter.
3938         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3939         (class all_objfiles_safe): New.
3940         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3941         * objfiles.c (put_objfile_before): Update comment.
3942         (add_separate_debug_objfile): Likewise.
3943         (free_all_objfiles): Use all_objfiles_safe.
3944         (objfile_purge_solibs): Likewise.
3945
3946 2019-01-09  Tom Tromey  <tom@tromey.com>
3947
3948         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3949         (expand_symtab_containing_pc, lookup_static_symbol)
3950         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3951         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3952         all_objfiles.
3953         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3954         * breakpoint.c (create_overlay_event_breakpoint)
3955         (create_longjmp_master_breakpoint)
3956         (create_std_terminate_master_breakpoint)
3957         (create_exception_master_breakpoint): Use all_objfiles.
3958         * linux-thread-db.c (try_thread_db_load_from_pdir)
3959         (has_libpthread): Use all_objfiles.
3960         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3961         * linespec.c (iterate_over_all_matching_symtabs)
3962         (search_minsyms_for_name): Use all_objfiles.
3963         * maint.c (maintenance_info_sections): Use all_objfiles.
3964         * main.c (captured_main_1): Use all_objfiles.
3965         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3966         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3967         * guile/scm-pretty-print.c
3968         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3969         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3970         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3971         (maintenance_print_msymbols): Use all_objfiles.
3972         * source.c (select_source_symtab): Use all_objfiles.
3973         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3974         * symfile.c (remove_symbol_file_command)
3975         (expand_symtabs_matching, map_symbol_filenames): Use
3976         all_objfiles.
3977         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3978         all_objfiles.
3979         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3980         * objc-lang.c (find_methods): Use all_objfiles.
3981         * objfiles.c (have_partial_symbols, have_full_symbols)
3982         (have_minimal_symbols, qsort_cmp)
3983         (default_iterate_over_objfiles_in_search_order): Use
3984         all_objfiles.
3985         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3986         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3987         (maintenance_check_psymtabs): Use all_objfiles.
3988         (ALL_PSYMTABS): Remove.
3989         * compile/compile-object-run.c (do_module_cleanup): Use
3990         all_objfiles.
3991         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3992         * cp-support.c (add_symbol_overload_list_qualified): Use
3993         all_objfiles.
3994         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3995         Use all_objfiles.
3996         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3997         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3998         all_objfiles.
3999         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4000         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
4001         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4002         Uses all_objfiles.
4003         * solib.c (solib_read_symbols): Use all_objfiles
4004
4005 2019-01-09  Tom Tromey  <tom@tromey.com>
4006
4007         * probe.c (parse_probes_in_pspace): Use all_objfiles.
4008         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
4009         all_objfiles.
4010         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
4011         * symmisc.c (print_symbol_bcache_statistics)
4012         (print_objfile_statistics, maintenance_print_objfiles)
4013         (maintenance_info_symtabs, maintenance_check_symtabs)
4014         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
4015         all_objfiles.
4016         * source.c (forget_cached_source_info): Use all_objfiles.
4017         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
4018         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4019         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
4020         * objfiles.c (update_section_map): Use all_objfiles.
4021         (shared_objfile_contains_address_p): Likewise.
4022         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
4023         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
4024
4025 2019-01-09  Tom Tromey  <tom@tromey.com>
4026
4027         * common/next-iterator.h: New file.
4028         * objfiles.h (class all_objfiles): New.
4029         (struct objfile_iterator): New.
4030
4031 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4032
4033         * NEWS: Move the description of the changed "frame", "select-frame",
4034          and "info frame" commands to the Changed commands section.
4035
4036 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
4037
4038         * gdbtypes.c (check_stub_method_group): Remove handling of old
4039         mangling schemes.
4040         * linespec.c (find_methods): Likewise.
4041         * stabsread.c (read_member_functions): Likewise.
4042         * valops.c (search_struct_method): Likewise.
4043         (value_struct_elt_for_reference): Likewise.
4044         * NEWS: Mention this change.
4045
4046 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4047
4048         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
4049         print_source_lines.
4050         * source.c (print_source_lines_base): Update line number check.
4051         (print_source_lines): New function.
4052         (source_lines_range::source_lines_range): New function.
4053         * source.h (class source_lines_range): New class.
4054         (print_source_lines): New declaration.
4055
4056 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4057
4058         * linespec.c (linespec_state_destructor): Free self->canonical_names.
4059
4060 2019-01-08  Tom Tromey  <tom@tromey.com>
4061             Simon Marchi  <simon.marchi@ericsson.com>
4062
4063         PR gdb/24060
4064         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
4065         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
4066         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
4067         * f-exp.y (DOLLAR_VARIABLE): Likewise.
4068         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
4069         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
4070
4071 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4072
4073         * source.c (select_source_symtab): Move header comment to
4074         declaration in source.h.
4075         (forget_cached_source_info_for_objfile): Likewise.
4076         (forget_cached_source_info): Likewise.
4077         (identify_source_line): Likewise.
4078         * source.h (identify_source_line): Move declaration from symtab.h
4079         and add comment from source.c
4080         (print_source_lines): Likewise.
4081         (forget_cached_source_info_for_objfile): Likewise.
4082         (forget_cached_source_info): Likewise.
4083         (select_source_symtab): Likewise.
4084         (enum print_source_lines_flag): Move definition from symtab.h.
4085         * symtab.h (identify_source_line): Move declaration to source.h.
4086         (print_source_lines): Likewise.
4087         (forget_cached_source_info_for_objfile): Likewise.
4088         (forget_cached_source_info): Likewise.
4089         (select_source_symtab): Likewise.
4090         (enum print_source_lines_flag): Move definition to source.h.
4091         * tui/tui-hooks.c: Add 'source.h' include.
4092
4093 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4094
4095         * source.c (print_source_lines_base): Handle requests to print
4096         reverse line number sequences, and guard against empty lines
4097         string.
4098
4099 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4100
4101         * source.c (print_source_lines_base): Fix skip of '\r' if next
4102         character is '\n'.
4103
4104 2019-01-06  Tom Tromey  <tom@tromey.com>
4105
4106         * c-exp.y (struct c_parse_state) <macro_original_text,
4107         expansion_obstack>: New member.
4108         (macro_original_text, expansion_obstack): Remove globals.
4109         (scan_macro_expansion, scanning_macro_expansion)
4110         (finished_macro_expansion): Update.
4111         (scan_macro_cleanup): Remove.
4112         (yylex, c_parse): Update.
4113
4114 2019-01-06  Tom Tromey  <tom@tromey.com>
4115
4116         * c-exp.y (struct c_parse_state) <strings>: New member.
4117         (operator_stoken): Update.
4118
4119 2019-01-06  Tom Tromey  <tom@tromey.com>
4120
4121         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
4122         (union type_stack_elt) <typelist_val>: Now a pointer to
4123         std::vector.
4124         (type_stack_cleanup): Don't declare.
4125         (push_typelist): Update.
4126         * parse.c (pop_typelist): Return a std::vector.
4127         (push_typelist): Take a std::vector.
4128         (follow_types): Update.  Do not free args.
4129         (type_stack_cleanup): Remove.
4130         * c-exp.y (struct c_parse_state): New.
4131         (cpstate): New global.
4132         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
4133         (nonempty_typelist): Update.
4134         (func_mod): Create a new vector.
4135         (c_parse): Create a c_parse_state.
4136         (check_parameter_typelist): Do not delete params.
4137         (function_method): Update.  Do not delete type_list.
4138
4139 2019-01-06  Tom Tromey  <tom@tromey.com>
4140
4141         PR gdb/28155:
4142         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
4143         check_typedef.
4144         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
4145         (print_return_value): Likewise.
4146
4147 2019-01-05  Tom Tromey  <tom@tromey.com>
4148
4149         * contrib/cleanup_check.py: Remove.
4150         * contrib/gcc-with-excheck: Remove.
4151         * contrib/exsummary.py: Remove.
4152         * contrib/excheck.py: Remove.
4153
4154 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
4155
4156         * thread.c (delete_thread_1): Add gdb_assert that THR is not
4157         NULL. Initialize tpprev to NULL instead of assigning it
4158         to NULL on the next statement.
4159         * windows-nat.c (windows_delete_thread): Remove check for
4160         main_thread_id before printing thread exit notifications.
4161         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
4162         Remove thread ID check against main_thread_id.
4163         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
4164         windows_delete_thread.
4165         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
4166
4167 2019-01-04  Tom Tromey  <tom@tromey.com>
4168
4169         * compile/compile.c (_initialize_compile): Use upper case for
4170         metasyntactic variables.
4171         * symmisc.c (_initialize_symmisc): Use upper case for
4172         metasyntactic variables.
4173         * psymtab.c (_initialize_psymtab): Use upper case for
4174         metasyntactic variables.
4175         * demangle.c (demangle_command): Use upper case for metasyntactic
4176         variables.
4177         (_initialize_demangler): Likewise.
4178         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
4179         variables.
4180
4181 2019-01-03  Tom Tromey  <tom@tromey.com>
4182
4183         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
4184
4185 2019-01-03  Tom Tromey  <tom@tromey.com>
4186
4187         * python/py-symtab.c (salpy_str): Update.
4188         (struct salpy_sal_object) <symtab>: Now a PyObject.
4189         (salpy_dealloc): Update.
4190         (del_objfile_sal): Use gdbpy_ref.
4191
4192 2019-01-03  Tom Tromey  <tom@tromey.com>
4193
4194         * python/py-type.c (convert_field): Use new_reference.  Return
4195         gdbpy_ref.
4196         (make_fielditem): Return gdbpy_ref.
4197         (typy_fields): Update.
4198         (typy_getitem): Update.
4199         (field_name): Return gdbpy_ref.  Use new_reference.
4200         (typy_iterator_iternext): Update.
4201
4202 2019-01-03  Tom Tromey  <tom@tromey.com>
4203
4204         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
4205
4206 2019-01-03  Tom Tromey  <tom@tromey.com>
4207
4208         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
4209         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
4210         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
4211         (pspy_set_frame_filters, pspy_set_frame_unwinders)
4212         (pspy_set_type_printers): Likewise.
4213         * python/py-function.c (fnpy_init): Use gdbpy_ref.
4214         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
4215         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
4216         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
4217         (objfpy_set_type_printers): Likewise.
4218
4219 2019-01-03  Tom Tromey  <tom@tromey.com>
4220
4221         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
4222         (gdbpy_print_stack): Use gdbpy_err_fetch.
4223         * python/python-internal.h (class gdbpy_err_fetch): New class.
4224         (class gdbpy_enter) <m_error_type, m_error_value,
4225         m_error_traceback>: Remove.
4226         <m_error>: New member.
4227         (gdbpy_exception_to_string): Don't declare.
4228         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
4229         * python/py-value.c (convert_value_from_python): Use
4230         gdbpy_err_fetch.
4231         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
4232         gdbpy_exception_to_string.
4233         (gdbpy_handle_exception): Use gdbpy_err_fetch.
4234         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
4235         gdbpy_err_fetch.
4236
4237 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4238
4239         * linux-nat.c (delete_lwp_cleanup): Delete.
4240         (struct lwp_deleter): New struct.
4241         (lwp_info_up): New typedef.
4242         (linux_nat_target::follow_fork): Delete cleanup, and make use of
4243         lwp_info_up.
4244
4245 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4246
4247         * linux-fork.c (class scoped_switch_fork_info): New class.
4248         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
4249
4250 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4251
4252         * valops.c (find_overload_match): Remove use of null_cleanup, and
4253         calls to do_cleanups.
4254
4255 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4256
4257         * compile/compile-cplus-types.c
4258         (compile_cplus_instance::decl_name): Handle changes to
4259         cp_func_name.
4260         * cp-support.c (cp_func_name): Update header comment, update
4261         return type.
4262         * cp-support.h (cp_func_name): Update return type in declaration.
4263         * valops.c (find_overload_match): Move temp_func local to top
4264         level of function and change its type.  Use temp_func to hold and
4265         delete temporary string obtained from cp_func_name.
4266
4267 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4268
4269         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
4270         gdb::char_vector, remove cleanup, and update uses of `msg`.
4271
4272 2019-01-03  Jim Wilson  <jimw@sifive.com>
4273
4274         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
4275
4276 2019-01-02  Tom Tromey  <tom@tromey.com>
4277
4278         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
4279         (tdesc_parse_xml): Remove cleanups.
4280         * target-descriptions.h (make_cleanup_free_target_description):
4281         Don't declare.
4282         (target_desc_deleter): New struct.
4283         (target_desc_up): New typedef.
4284         * target-descriptions.c (target_desc_deleter::operator()): Rename
4285         from free_target_description.
4286         (make_cleanup_free_target_description): Remove.
4287
4288 2019-01-02  Tom Tromey  <tom@tromey.com>
4289
4290         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
4291         constructor, destructor.
4292         (linespec_parser): Remove typedef.
4293         (~linespec_parser): Rename from linespec_parser_delete.
4294         (linespec_lex_to_end, linespec_complete_label)
4295         (linespec_complete): Update.
4296         (decode_line_full): Remove cleanups.
4297         (decode_line_1): Update.
4298
4299 2019-01-02  Tom Tromey  <tom@tromey.com>
4300
4301         * python/python-internal.h (inferior_to_inferior_object): Change
4302         return type.
4303         * python/py-exitedevent.c (create_exited_event_object): Update.
4304         * python/py-inferior.c (inferior_to_inferior_object): Return
4305         gdbpy_ref.
4306         (python_new_inferior, python_inferior_deleted)
4307         (thread_to_thread_object, delete_thread_object)
4308         (build_inferior_list, gdbpy_selected_inferior): Update.
4309         * python/py-infthread.c (create_thread_object): Update.  Also fail
4310         if inferior_to_inferior_object fails.
4311
4312 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
4313
4314         * inferior.h (class inferior) <displaced_step_state>: New field.
4315         * infrun.h (struct displaced_step_state): Move here from
4316         infrun.c.  Initialize fields, add constructor.
4317         <inf>: Remove field.
4318         <reset>: New method.
4319         * infrun.c (struct displaced_step_inferior_state): Move to
4320         infrun.h.
4321         (displaced_step_inferior_states): Remove.
4322         (get_displaced_stepping_state): Adust.
4323         (displaced_step_in_progress_any_inferior): Adjust.
4324         (displaced_step_in_progress_thread): Adjust.
4325         (displaced_step_in_progress): Adjust.
4326         (add_displaced_stepping_state): Remove.
4327         (get_displaced_step_closure_by_addr): Adjust.
4328         (remove_displaced_stepping_state): Remove.
4329         (infrun_inferior_exit): Call displaced_step_state.reset.
4330         (use_displaced_stepping): Don't check for NULL.
4331         (displaced_step_prepare_throw): Call
4332         get_displaced_stepping_state.
4333         (displaced_step_fixup): Don't check for NULL.
4334         (prepare_for_detach): Don't check for NULL.
4335
4336 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4337
4338         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
4339          in case of call that did not complete.
4340
4341 2019-01-02  Andrey Utkin  <autkin@undo.io>
4342
4343         * symfile.c (find_separate_debug_file): Fix search of debug files for
4344         remote debuggee.
4345
4346 2019-01-02  Tom Tromey  <tom@tromey.com>
4347
4348         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
4349         indentation.
4350         * python/py-frame.c (frapy_older): Remove cast.
4351         (frapy_newer): Likewise.
4352         * python/py-breakpoint.c (local_setattro): Remove cast.
4353         * python/py-arch.c (archpy_name): Remove local variable.
4354         * python/py-type.c (gdbpy_lookup_type): Remove cast.
4355
4356 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
4357
4358         * unittests/basic_string_view/element_access/char/empty.cc:
4359         Fix year range in copyright header.
4360
4361 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4362
4363         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
4364         Delete.
4365         <operator==>: Update with for removed field.
4366         <hash>: Likewise.
4367         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
4368         <isa_features>: ...this.
4369         <abi_features>: New field.
4370         (riscv_isa_flen): Update comment.
4371         (riscv_abi_xlen): New declaration.
4372         (riscv_abi_flen): New declaration.
4373         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
4374         isa_features.
4375         (riscv_abi_xlen): New function.
4376         (riscv_isa_flen): Update to get answer from isa_features.
4377         (riscv_abi_flen): New function.
4378         (riscv_has_fp_abi): Update to get answer from abi_features.
4379         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
4380         xlen and flen.
4381         (riscv_call_info) <xlen, flen>: Update comment.
4382         (riscv_call_arg_struct): Remove invalid assertions
4383         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
4384         is removed.
4385         (riscv_gdbarch_init): Gather isa features and abi features
4386         separately, ensure both match on the gdbarch when reusing an old
4387         gdbarch.  Relax an error check to allow 32-bit abi float to run on
4388         a target with 64-bit float hardware.
4389
4390 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4391
4392         * source.c (search_command_helper): Stop reverse search
4393         when line 1 has been searched.
4394
4395 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4396
4397         * record-full.c (record_full_base_target::close): Rewrite
4398         record_full_core_buf_list free logic.
4399
4400 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4401
4402         * break-catch-syscall.c (print_one_catch_syscall): xfree
4403         the last text.
4404
4405 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4406
4407         * top.c (print_gdb_version): Update Copyright year in version
4408         message.
4409
4410 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4411
4412         Update copyright year range in all GDB files.
4413
4414 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
4415
4416         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
4417
4418 For older changes see ChangeLog-2018.
4419 \f
4420 Local Variables:
4421 mode: change-log
4422 left-margin: 8
4423 fill-column: 74
4424 version-control: never
4425 coding: utf-8
4426 End:
4427