gdb/ChangeLog

   1 2019-08-13  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
   4         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
   5
   6 2019-08-13  Tom Tromey  <tom@tromey.com>
   7
   8         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
   9         tui-data.c.
  10         (show_source_disasm_command, show_data)
  11         (show_source_or_disasm_and_command): Don't use
  12         tui_set_current_layout_to.
  13         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
  14         * tui/tui-data.c (current_layout, tui_current_layout): Move to
  15         tui-layout.c.
  16         (tui_set_current_layout_to): Remove.
  17
  18 2019-08-13  Tom Tromey  <tom@tromey.com>
  19
  20         * tui/tui-layout.c (tui_set_layout): Update.
  21         * tui/tui-data.h (struct tui_layout_def): Remove.
  22         (tui_layout_def): Don't declare.
  23         * tui/tui-data.c (layout_def): Remove.
  24         (tui_layout_def): Remove.
  25
  26 2019-08-13  Tom Tromey  <tom@tromey.com>
  27
  28         * tui/tui-winsource.h (struct tui_source_window_base)
  29         <clear_detail>: No longer "override".
  30         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
  31         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
  32         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
  33         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
  34         Remove.
  35         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
  36
  37 2019-08-13  Tom Tromey  <tromey@adacore.com>
  38
  39         * tracepoint.c: Don't include readline.h or history.h.
  40
  41 2019-08-12  Tom Tromey  <tom@tromey.com>
  42
  43         * configure: Rebuild.
  44         * configure.ac: Check for readline 7.
  45         * NEWS: Mention readline 7 requirement.
  46         * README: Update.
  47
  48 2019-08-12  Tom Tromey  <tom@tromey.com>
  49
  50         * mingw-hdep.c (gdb_select): Remove readline hack.
  51
  52 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
  53
  54         * blockframe.c (find_pc_partial_function): Set *block to nullptr
  55         when the function fails.
  56
  57 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
  58
  59         * s390-tdep.c (s390_type_align): New function.
  60         (s390_gdbarch_init): Set it as type_align gdbarch method.
  61
  62 2019-08-09  Tom de Vries  <tdevries@suse.de>
  63
  64         PR gdb/24591
  65         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
  66         pc_low with relocation offset.
  67
  68 2019-08-07  Tom Tromey  <tromey@adacore.com>
  69
  70         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
  71         (print_frame_args): Update.
  72         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
  73         Update.
  74         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
  75         * frame.h (struct frame_arg): Add initializers.
  76         <error>: Now a unique_xmalloc_ptr.
  77
  78 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
  79
  80         * NEWS: Expand the Pointer Authentication entry.
  81         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
  82         (aarch64_frame_unmask_lr): ... to this.
  83         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
  84         Call aarch64_frame_unmask_lr.
  85         * frame.c (struct frame_info): Add "masked" variable.
  86         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
  87         (fprint_frame): Check for masked pc.
  88         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
  89         declarations.
  90         * python/py-framefilter.c (py_print_frame): Check for masked pc.
  91         * stack.c (print_frame): Check for masked pc.
  92
  93 2019-08-06  Tom Tromey  <tom@tromey.com>
  94
  95         * stabsread.c (patch_block_stabs, read_one_struct_field)
  96         (read_enum_type): Use obstack_strndup.
  97         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
  98         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
  99         * dwarf2read.c (guess_full_die_structure_name)
 100         (anonymous_struct_prefix): Use obstack_strndup.
 101         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 102         * c-exp.y (yylex): Use obstack_strndup.
 103         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 104         (write_var_or_type): Use obstack_strndup.
 105
 106 2019-08-06  Tom Tromey  <tom@tromey.com>
 107
 108         * symfile.c (reread_symbols): Use obstack_strdup.
 109         * stabsread.c (read_type): Use obstack_strdup.
 110         * gdb_obstack.h (obstack_strdup): New overload.
 111         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 112         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 113         (dwarf2_canonicalize_name): Use obstack_strdup.
 114         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 115         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 116         Use obstack_strdup.
 117
 118 2019-08-06  Tom Tromey  <tom@tromey.com>
 119
 120         * gdb_obstack.h (obstack_strdup): Define.
 121         * gdb_obstack.c (obstack_strdup): Don't define.
 122
 123 2019-08-06  Tom Tromey  <tom@tromey.com>
 124
 125         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 126         obstack_strdup.
 127         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 128         obstack_strdup.
 129         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 130         * stabsread.c (common_block_start): Use obstack_strdup.
 131         * objfiles.c (set_objfile_main_name, objfile): Use
 132         obstack_strdup.
 133         * namespace.c (add_using_directive): Use obstack_strdup.
 134         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 135         * jit.c (finalize_symtab): Use obstack_strdup.
 136         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 137         (guess_partial_die_structure_name, partial_die_info::fixup)
 138         (dwarf2_name): Use obstack_strdup.
 139         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 140         obstack_strdup.
 141         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 142         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 143         obstack_strdup.
 144         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 145
 146 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 147
 148         * unittests/help-doc-selftests.c: New file.
 149         * Makefile.in: Add the new file.
 150
 151 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 152
 153         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 154         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 155         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 156         the trailing '.' is not output, and the first character is uppercased.
 157         (print_help_for_command): Update call to print_doc_line.
 158         (print_doc_of_command): Likewise.
 159         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 160         * cli/cli-option.c (append_indented_doc): Do not append newline.
 161         (build_help_option): Append newline after first appended_indented_doc
 162         only if a second call is done.
 163         (build_help): Append 2 new lines before each option, except the first
 164         one.
 165         * compile/compile.c (_initialize_compile): Add new lines after
 166         %OPTIONS%, when not at the end of the help.
 167         Change help doc or code
 168         producing the help doc to respect the invariants.
 169         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 170         Also removed the new line after 'Options:', as all other commands
 171         do not put an empty line between 'Options:' and the first option.
 172         * printcmd.c (_initialize_printcmd): Likewise.
 173         * stack.c (_initialize_stack): Likewise.
 174         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 175         incorrectly telling COMMAND is optional.
 176         * ada-lang.c (_initialize_ada_language): Change help doc or code
 177         producing the help doc to respect the invariants.
 178         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 179         * breakpoint.c (_initialize_breakpoint): Likewise.
 180         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 181         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 182         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 183         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 184         _initialize_cli_style): Likewise.
 185         * corelow.c (core_target_info): Likewise.
 186         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 187         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 188         * filesystem.c (_initialize_filesystem): Likewise.
 189         * frame.c (_initialize_frame): Likewise.
 190         * gnu-nat.c (add_task_commands): Likewise.
 191         * infcall.c (_initialize_infcall): Likewise.
 192         * infcmd.c (_initialize_infcmd): Likewise.
 193         * interps.c (_initialize_interpreter): Likewise.
 194         * language.c (_initialize_language): Likewise.
 195         * linux-fork.c (_initialize_linux_fork): Likewise.
 196         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 197         * maint.c (_initialize_maint_cmds): Likewise.
 198         * memattr.c (_initialize_mem): Likewise.
 199         * printcmd.c (_initialize_printcmd): Likewise.
 200         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 201         _RegEx): Likewise.
 202         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 203         * record-btrace.c (_initialize_record_btrace): Likewise.
 204         * record-full.c (_initialize_record_full): Likewise.
 205         * record.c (_initialize_record): Likewise.
 206         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 207         * regcache.c (_initialize_regcache): Likewise.
 208         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 209         _initialize_remote): Likewise.
 210         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 211         * serial.c (_initialize_serial): Likewise.
 212         * skip.c (_initialize_step_skip): Likewise.
 213         * source.c (_initialize_source): Likewise.
 214         * stack.c (_initialize_stack): Likewise.
 215         * symfile.c (_initialize_symfile): Likewise.
 216         * symtab.c (_initialize_symtab): Likewise.
 217         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 218         * top.c (init_main): Likewise.
 219         * tracefile-tfile.c (tfile_target_info): Likewise.
 220         * tracepoint.c (_initialize_tracepoint): Likewise.
 221         * tui/tui-win.c (_initialize_tui_win): Likewise.
 222         * utils.c (add_internal_problem_command): Likewise.
 223         * valprint.c (value_print_option_defs): Likewise.
 224
 225 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 226
 227         PR build/24886
 228         * configure.ac: Drop enable-libmcheck support.
 229         * configure, config.in: Rebuild.
 230         * libmcheck.m4: Remove.
 231         * acinclude.m4: Don't include it.
 232         * Makefile.in: Don't distribute it.
 233         * top.c (print_gdb_configuration): Don't mention it.
 234
 235 2019-08-06  Tom Tromey  <tom@tromey.com>
 236
 237         * utils.c (set_output_style): Sometimes pass stream to
 238         emit_style_escape.
 239         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 240         * record-btrace.c (btrace_insn_history): Update.
 241         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 242         method.
 243         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 244         Update initializers.
 245         <m_uiout>: New field.
 246         <m_di>: Move lower.
 247         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 248         Remove "uiout" parameter.
 249         (dump_insns): Update.
 250         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 251         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 252
 253 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 254
 255         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 256         (error_in_psymtab_expansion): Likewise.
 257         (lookup_symbol_via_quick_fns): Likewise.
 258         (basic_lookup_transparent_type_quick): Likewise.
 259         (basic_lookup_transparent_type_1): Likewise.
 260
 261 2019-08-06  Tom Tromey  <tromey@adacore.com>
 262
 263         * source.c (last_source_error): Now bool.
 264         (print_source_lines_base): Make "noprint" bool.  Only open
 265         source file when last_source_visited changes.
 266
 267 2019-08-06  Tom Tromey  <tromey@adacore.com>
 268
 269         * annotate.c (annotate_source_line): Use g_source_cache.
 270         * source-cache.c (source_cache::get_plain_source_lines): Change
 271         parameters.  Populate m_offset_cache.
 272         (source_cache::ensure): New method.
 273         (source_cache::get_line_charpos): New method.
 274         (extract_lines): Move lower.  Change parameters.
 275         (source_cache::get_source_lines): Move lower.
 276         * source-cache.h (class source_cache): Update comment.
 277         <get_line_charpos>: New method.
 278         <get_source_lines>: Update comment.
 279         <clear>: Clear m_offset_cache.
 280         <get_plain_source_lines>: Change parameters.
 281         <ensure>: New method
 282         <m_offset_cache>: New member.
 283         * source.c (forget_cached_source_info_for_objfile): Update.
 284         (info_source_command): Use g_source_cache.
 285         (find_source_lines, open_source_file_with_line_charpos): Remove.
 286         (print_source_lines_base, search_command_helper): Use g_source_cache.
 287         * source.h (open_source_file_with_line_charpos): Don't declare.
 288         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 289         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 290         Use g_source_cache.
 291
 292 2019-08-06  Tom Tromey  <tromey@adacore.com>
 293
 294         * source-cache.c (source_cache::get_plain_source_lines):
 295         Remove "first_line" and "last_line" parameters.
 296         (source_cache::get_source_lines): Cache plain text.
 297         * source-cache.h (class source_cache)
 298         <get_plain_source_lines>: Update.
 299
 300 2019-08-06  Tom Tromey  <tromey@adacore.com>
 301
 302         * source-cache.c (extract_lines): No longer a method.
 303         Changed type of parameter.  Include final newline.
 304         (selftests::extract_lines_test): New function.
 305         (_initialize_source_cache): Likewise.
 306         * source-cache.h (class source_cache)
 307         <extract_lines>: Don't declare.
 308
 309 2019-08-06  Tom Tromey  <tromey@adacore.com>
 310
 311         * breakpoint.c (init_breakpoint_sal): Update.
 312         (breakpoint): Update.
 313         * breakpoint.h (struct breakpoint) <filter>: Now a
 314         unique_xmalloc_ptr.
 315
 316 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 317
 318         * NEWS: Mention dictionary access on blocks.
 319         * python/py-block.c (blpy_getitem): New function.
 320         (block_object_as_mapping): New struct.
 321         (block_object_type): Use new struct for tp_as_mapping field.
 322
 323 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 324
 325         * objfiles.h (objfile): Add a comment describing partial symbols.
 326
 327 2019-08-05  Tom Tromey  <tromey@adacore.com>
 328
 329         * compile/compile.c (_initialize_compile): Use _(), not N_().
 330         * thread.c (_initialize_thread): Use _(), not N_().
 331         * stack.c (_initialize_stack): Use _(), not N_().
 332         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 333
 334 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 335
 336         * dwarf2read.c (struct dw2_symtab_iterator):
 337         <want_specific_block>: Remove.
 338         <block_index>: Change type to gdb::optional.
 339         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 340         change type of BLOCK_INDEX parameter to gdb::optional.
 341         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 342         (dw2_lookup_symbol): Don't pass argument for
 343         WANT_SPECIFIC_BLOCK.
 344         (dw2_expand_symtabs_for_function): Don't pass argument for
 345         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 346         (class dw2_debug_names_iterator)
 347         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 348         parameter, change BLOCK_INDEX type to gdb::optional.
 349         <m_want_specific_block>: Remove.
 350         <m_block_index>: Change type to gdb::optional.
 351         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 352         gdb::optional.  Re-write in function of gdb::optional.
 353         (dw2_debug_names_lookup_symbol): Don't pass argument for
 354         WANT_SPECIFIC_BLOCK.
 355         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 356         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 357         BLOCK_INDEX.
 358
 359 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 360
 361         * NEWS: Mention changes to "info sources" command.
 362
 363 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 364
 365         * symtab.c (filename_partial_match_opts): New struct type.
 366         (struct output_source_filename_data): New members
 367         regexp, c_regexp, partial_match.
 368         (output_source_filename): Use new members to decide to print file.
 369         (info_sources_option_defs): New variable.
 370         (make_info_sources_options_def_group, print_info_sources_header,
 371         info_sources_command_completer):
 372         New functions.
 373         (info_sources_command): Read new optional arguments.
 374         (_initialize_symtab): Update info sources help.
 375
 376 2019-08-02  Alexandre Oliva <oliva@adacore.com>
 377
 378         * ada-lang.c (exception_support_info_v0): Renamed from...
 379         (default_exception_support_info): ... this.  Create new
 380         definition for v1.
 381         (ada_has_this_exception_support): Look up catch_handlers_sym.
 382         (ada_exception_support_info_sniffer): Try v0 after default.
 383
 384 2019-08-01  Tom Tromey  <tromey@adacore.com>
 385
 386         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
 387         gdbarch.h.
 388
 389 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
 390
 391         * s12z-tdep.c: Fix include path for s12z-opc.h.
 392
 393 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
 394
 395         * NEWS: Require GNU make 3.82.
 396
 397 2019-07-16  Tom Tromey  <tom@tromey.com>
 398
 399         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 400         declare.
 401
 402 2019-07-30  Tom Tromey  <tromey@adacore.com>
 403
 404         * block.c (contained_in): Remove BLOCK_FUNCTION check.
 405
 406 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
 407
 408         * printcmd.c (print_address_symbolic): Print negative offsets.
 409         (build_address_symbolic): Force signed arithmetic when computing
 410         offset.
 411
 412 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 413
 414         PR/24474: Add a function to lookup static variables.
 415         * NEWS: Mention this new function.
 416         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 417         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 418         * python/python.c (python_GdbMethods): Add new function.
 419
 420 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 421
 422         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 423         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 424         (objfpy_lookup_static_symbol): New function.
 425         (objfile_object_methods): Add new functions.
 426
 427 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 428
 429         * NEWS: Mention 'set|show print frame-info'.  Mention new
 430         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 431         backtrace argument.  Mention that python frame filtering code
 432         is now consistent with what 'backtrace' command prints.
 433
 434 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 435
 436         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 437         comments.
 438         (print_frame_info_auto, print_frame_info_source_line,
 439         print_frame_info_location, print_frame_info_source_and_location,
 440         print_frame_info_location_and_address, print_frame_info_short_location):
 441         New declarations.
 442         (struct frame_print_options): New member print_frame_info.
 443         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 444         * stack.h (get_user_print_what_frame_info): New declaration.
 445         (frame_show_address): New declaration.
 446         * stack.c (print_frame_arguments_choices): New value 'presence'.
 447         (print_frame_info_auto, print_frame_info_source_line,
 448         print_frame_info_location, print_frame_info_source_and_location,
 449         print_frame_info_location_and_address, print_frame_info_short_location,
 450         print_frame_info_choices, print_frame_info_print_what): New definitions.
 451         (print_frame_args): Only print dots for args if print frame-arguments
 452         is 'presence'.
 453         (frame_print_option_defs): New element for "frame-info".
 454         (get_user_print_what_frame_info): New function.
 455         (frame_show_address): Make non static.  Move comment to stack.h.
 456         (print_frame_info_to_print_what): New function.
 457         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
 458         to decide what to print.
 459         (backtrace_command_1): Handle the new print_frame_arguments_presence
 460         value.
 461         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
 462         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
 463         (py_print_frame): In non-mi mode, use LOCATION as default for
 464         print_what, similarly to frame information printed directly by
 465         backtrace command. Handle frame-info user option in non MI mode.
 466
 467 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 468
 469         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
 470         Add case for debugging 32-bit target on 64-bit host.  Revise
 471         comment.
 472
 473 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 474
 475         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
 476         instead of find_function_entry_range_from_pc.
 477
 478 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 479
 480         * stack.c (find_frame_funname): Remove code which preferred
 481         minsym over symtab sym in "certain pathological cases".
 482
 483         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
 484         parameter.  Change type of "do_demangle" to bool.
 485         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 486         Pass suitable "prefer_sym_over_minsym" flag to
 487         build_address_symbolic().  Don't output "+" for negative offsets.
 488         * printcmd.c (print_address_symbolic): Update invocation of
 489         build_address_symbolic to include a "prefer_sym_over_minsym"
 490         flag.
 491         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 492         Restrict cases in which use of minimal symbol is preferred to that
 493         of a found symbol.  Update comments.
 494
 495         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 496         for entry pc when entry pc is out of range for that FDE.
 497
 498 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 499
 500         PR gdb/24839:
 501         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 502         type.
 503
 504 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 505
 506         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 507         this function's Python signature.
 508
 509
 510 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 511
 512         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 513         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 514         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 515         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 516         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 517
 518
 519 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 520
 521         * h8300-tdep.c (h8300_register_name_common): New.
 522         h8300_register_name): Use h8300_register_name_common.
 523         (h8300s_register_name): Likewise.
 524         (h8300sx_register_name): Likewise.
 525         (h8300h_register_nam): New.
 526         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 527
 528
 529 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 530
 531         * arm-tdep.c (arm_skip_cmse_entry): New function.
 532         (arm_is_sgstubs_section): New function.
 533         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 534
 535 2019-07-22  Tom Tromey  <tom@tromey.com>
 536
 537         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 538         Don't self-assign.
 539
 540 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 541
 542         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 543         type_print.
 544
 545 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 546
 547         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 548         so that GDB doesn't match any msymbols when searching in the
 549         TYPES_DOMAIN.
 550         (print_symbol_info): Print using typedef_print or type_print based
 551         on the type of the symbol.  Add updated FIXME comment moved from...
 552         (_initialize_symtab): ... move and update FIXME comment to above.
 553
 554 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 555
 556         * NEWS: Mention adding -q option to "info types".
 557         * symtab.c (struct info_types_options): New struct.
 558         (info_types_options_defs): New variable.
 559         (make_info_types_options_def_group): New function.
 560         (info_types_command): Use gdb::option framework to parse options.
 561         (info_types_command_completer): New function.
 562         (_initialize_symtab): Extend the help text on "info types" and
 563         register command completer.
 564
 565 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 566
 567         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 568         (lookup_symbol_in_objfile): Change int to block_enum and add a
 569         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 570
 571 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 572
 573         * MAINTAINERS (Write After Approval): Add self.
 574
 575 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 576
 577         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 578         instruction to the dummy code region.
 579
 580 2019-07-19  Tom Tromey  <tromey@adacore.com>
 581
 582         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 583         (ARGSUSED, PARAMS, __func__): Remove rules.
 584
 585 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 586
 587         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 588         * features/arm/arm-with-iwmmxt.c: Remove.
 589         * features/arm/arm-with-iwmmxt.xml: Remove.
 590         * features/arm/arm-with-m-fpa-layout.c: Remove.
 591         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 592         * features/arm/arm-with-m-vfp-d16.c: Remove.
 593         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 594         * features/arm/arm-with-m.c: Remove.
 595         * features/arm/arm-with-m.xml: Remove.
 596         * features/arm/arm-with-neon.c: Remove.
 597         * features/arm/arm-with-neon.xml: Remove.
 598         * features/arm/arm-with-vfpv2.c: Remove.
 599         * features/arm/arm-with-vfpv2.xml: Remove.
 600         * features/arm/arm-with-vfpv3.c: Remove.
 601         * features/arm/arm-with-vfpv3.xml: Remove.
 602
 603 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 604
 605         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 606
 607 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 608
 609         * arch/aarch32.c (aarch32_create_target_description): Create
 610         target descriptions using features.
 611         * arch/arm.c (arm_create_target_description)
 612         (arm_create_mprofile_target_description): Likewise.
 613         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 614
 615 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 616
 617         * Makefile.in: Add new files.
 618         * aarch32-tdep.c: New file.
 619         * aarch32-tdep.h: New file.
 620         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 621         Call aarch32_read_description.
 622         * arch/aarch32.c: New file.
 623         * arch/aarch32.h: New file.
 624         * arch/arm.c (arm_create_target_description)
 625         (arm_create_mprofile_target_description): New function.
 626         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 627         (arm_create_target_description)
 628         (arm_create_mprofile_target_description): New declaration.
 629         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 630         read_description functions.
 631         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 632         Likewise.
 633         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 634         * arm-tdep.c (tdesc_arm_list): New variable.
 635         (arm_register_g_packet_guesses): Call create description functions.
 636         (arm_read_description) (arm_read_mprofile_description): New
 637         function.
 638         * arm-tdep.h (arm_read_description)
 639         (arm_read_mprofile_description): Add declaration.
 640         * configure.tgt: Add new files.
 641
 642 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 643
 644         * top.c (new_ui_command): Open specified terminal just once.
 645
 646 2019-07-18  Tom Tromey  <tromey@adacore.com>
 647
 648         * symtab.c (main_name): Constify return type.
 649         * symfile.c (set_initial_language): Update.
 650         * symtab.h (main_name): Constify return type.
 651
 652 2019-07-17  Tom Tromey  <tom@tromey.com>
 653
 654         * tui/tui-winsource.c (tui_update_source_window)
 655         (tui_update_source_window_as_is)
 656         (tui_update_source_windows_with_line): Remove return.
 657         * tui/tui-disasm.c (tui_show_disassem)
 658         (tui_show_disassem_and_update_source): Remove return.
 659         * tui/tui.c (tui_reset): Remove return.
 660         * tui/tui-wingeneral.c
 661         (tui_check_and_display_highlight_if_needed): Remove return.
 662
 663 2019-07-17  Tom Tromey  <tom@tromey.com>
 664
 665         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 666
 667 2019-07-17  Tom Tromey  <tom@tromey.com>
 668
 669         * tui/tui-winsource.h (struct tui_exec_info_window)
 670         (struct tui_source_window_base): Move from tui-data.h.
 671         * tui/tui-winsource.c: Move many method definitions from
 672         elsewhere.  Remove "structuring" comments.
 673         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 674         (tui_source_window_base::refresh_window): Move to
 675         tui-winsource.c.
 676         * tui/tui-win.c (tui_source_window_base::refresh_all)
 677         (tui_source_window_base::update_tab_width)
 678         (tui_source_window_base::set_new_height)
 679         (tui_source_window_base::do_make_visible_with_new_height): Move to
 680         tui-winsource.c.
 681         * tui/tui-source.h: Update.
 682         * tui/tui-source.c (tui_source_window_base::reset): Move to
 683         tui-winsource.c.
 684         * tui/tui-disasm.h: Update.
 685         * tui/tui-data.h (struct tui_exec_info_window): Move to
 686         tui-winsource.h.
 687         (struct tui_source_window_base): Likewise.
 688         * tui/tui-data.c (tui_source_window_base::clear_detail)
 689         (tui_source_window_base, ~tui_source_window_base): Move to
 690         tui-winsource.c.
 691
 692 2019-07-17  Tom Tromey  <tom@tromey.com>
 693
 694         * tui/tui-win.c (tui_resize_all)
 695         (tui_source_window_base::update_tab_width)
 696         (tui_adjust_win_heights): Update.
 697         (tui_win_info::make_invisible_and_set_new_height): Rename from
 698         make_invisible_and_set_new_height.
 699         * tui/tui-data.h (struct tui_win_info)
 700         <make_invisible_and_set_new_height>: New method.
 701
 702 2019-07-17  Tom Tromey  <tom@tromey.com>
 703
 704         * tui/tui.c: Update.
 705         * tui/tui-source.h (struct tui_source_window): Move from
 706         tui-data.h.
 707         * tui/tui-layout.c: Update.
 708         * tui/tui-disasm.c: Update.
 709         * tui/tui-data.h (struct tui_source_window): Move to
 710         tui-source.h.
 711
 712 2019-07-17  Tom Tromey  <tom@tromey.com>
 713
 714         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 715         tui-data.h.
 716         * tui/tui-data.h (struct tui_disasm_window): Move to
 717         tui-disasm.h.
 718
 719 2019-07-17  Tom Tromey  <tom@tromey.com>
 720
 721         * tui/tui-regs.h (struct tui_data_item_window): Move from
 722         tui-data.h.
 723         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 724         * tui/tui-data.h (struct tui_data_item_window): Move to
 725         tui-regs.h.
 726         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 727
 728 2019-07-17  Tom Tromey  <tom@tromey.com>
 729
 730         * tui/tui.c: Update.
 731         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 732         (tui_cmd_window::max_height): Move to tui-command.c.
 733         * tui/tui-layout.c: Update.
 734         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 735         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 736         tui-command.c.
 737         * tui/tui-command.h (struct tui_cmd_window): Move from
 738         tui-data.h.
 739         * tui/tui-command.c: Remove "structuring" comments.
 740         (tui_cmd_window::clear_detail)
 741         (tui_cmd_window::do_make_visible_with_new_height)
 742         (tui_cmd_window::max_height): Move from elsewhere.
 743
 744 2019-07-17  Tom Tromey  <tom@tromey.com>
 745
 746         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 747         Now static.
 748         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 749         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 750
 751 2019-07-17  Tom Tromey  <tom@tromey.com>
 752
 753         * tui/tui.c: Update.
 754         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 755         tui-regs.c.
 756         * tui/tui-windata.h: Remove file.
 757         * tui/tui-windata.c: Remove file.
 758         * tui/tui-win.c (tui_data_window::set_new_height)
 759         (tui_data_window::do_make_visible_with_new_height): Move to
 760         tui-regs.c.
 761         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 762         * tui/tui-regs.c: Remove "structuring" comments.
 763         (tui_data_window::first_data_item_displayed)
 764         (tui_data_window::delete_data_content_windows)
 765         (tui_data_window::erase_data_content)
 766         (tui_data_window::display_all_data)
 767         (tui_data_window::refresh_all)
 768         (tui_data_window::do_scroll_vertical)
 769         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 770         (tui_data_window::do_make_visible_with_new_height)
 771         (tui_data_window::refresh_window): Move from elsewhere.
 772         (_initialize_tui_regs): Move to end of file.
 773         * tui/tui-layout.c: Update.
 774         * tui/tui-hooks.c: Update.
 775         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 776         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 777         tui-regs.c.
 778         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 779
 780 2019-07-17  Tom Tromey  <tom@tromey.com>
 781
 782         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 783         seen.
 784
 785 2019-07-17  Tom Tromey  <tom@tromey.com>
 786
 787         * tui/tui-win.c (tui_source_window_base::set_new_height)
 788         (tui_source_window_base::do_make_visible_with_new_height): Use
 789         m_has_locator field directly.
 790         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 791         method.
 792         (struct tui_source_window_base) <has_locator>: Likewise.
 793
 794 2019-07-17  Tom Tromey  <tom@tromey.com>
 795
 796         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 797         Don't declare.
 798         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 799         Remove.
 800         * tui/tui-win.c (tui_source_window_base::set_new_height)
 801         (tui_source_window_base::set_new_height)
 802         (make_invisible_and_set_new_height)
 803         (tui_source_window_base::do_make_visible_with_new_height)
 804         (tui_source_window_base::do_make_visible_with_new_height):
 805         Update.
 806         * tui/tui-layout.c (show_source_disasm_command, show_data)
 807         (show_source_or_disasm_and_command): Update.
 808         * tui/tui-layout.c (show_layout): Update.
 809
 810 2019-07-17  Tom Tromey  <tom@tromey.com>
 811
 812         * tui/tui-layout.c (make_data_window): Remove.
 813         (show_data): Unify creation and re-initialization cases.
 814
 815 2019-07-17  Tom Tromey  <tom@tromey.com>
 816
 817         * tui/tui-layout.c (make_source_window, make_disasm_window):
 818         Remove.
 819         (show_data): Unify creation and re-initialization cases.
 820
 821 2019-07-17  Tom Tromey  <tom@tromey.com>
 822
 823         * tui/tui-layout.c (make_command_window): Remove.
 824         (show_source_disasm_command, show_source_or_disasm_and_command):
 825         Unify creation and re-initialization cases.
 826
 827 2019-07-17  Tom Tromey  <tom@tromey.com>
 828
 829         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 830         creation and re-initialization cases.
 831
 832 2019-07-17  Tom Tromey  <tom@tromey.com>
 833
 834         * tui/tui-regs.c (tui_get_register): Return void.
 835
 836 2019-07-17  Tom Tromey  <tom@tromey.com>
 837
 838         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 839         Simplify.
 840
 841 2019-07-17  Tom Tromey  <tom@tromey.com>
 842
 843         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 844         resetting.
 845
 846 2019-07-17  Tom Tromey  <tom@tromey.com>
 847
 848         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 849         * tui/tui-regs.c (tui_reg_layout): New function.
 850         (tui_show_registers, tui_reg_command): Use it.
 851         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 852         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 853         parameters.
 854         (tui_layout_command): Remove.
 855
 856 2019-07-17  Tom Tromey  <tom@tromey.com>
 857
 858         * tui/tui-layout.h (tui/tui-layout): Return void.
 859         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 860
 861 2019-07-17  Tom Tromey  <tom@tromey.com>
 862
 863         * tui/tui-layout.c (show_source_disasm_command, show_data):
 864         Update.
 865         (reset_locator): Remove.
 866         (show_source_or_disasm_and_command): Update.
 867
 868 2019-07-17  Tom Tromey  <tom@tromey.com>
 869
 870         * tui/tui-source.c (tui_source_window_base::reset): Remove
 871         win_type parameter.
 872         * tui/tui-layout.c (make_command_window, make_source_window)
 873         (make_disasm_window, make_data_window)
 874         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 875         (reset_locator, show_source_or_disasm_and_command): Update.
 876         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 877         win_type parameter.
 878         (struct tui_source_window_base) <reset>: Likewise.
 879
 880 2019-07-17  Tom Tromey  <tom@tromey.com>
 881
 882         * tui/tui-layout.c (show_source_disasm_command): Use
 883         reset_locator.
 884         (reset_locator): New function.
 885         (init_and_make_win): Remove.
 886         (show_source_or_disasm_and_command): Use reset_locator.
 887
 888 2019-07-17  Tom Tromey  <tom@tromey.com>
 889
 890         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 891         condition.
 892         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 893         Remove condition.
 894         * tui/tui-source.c (tui_source_window_base::reset): New method.
 895         * tui/tui-layout.c (make_command_window): Don't call
 896         init_and_make_win.
 897         (make_source_window, make_disasm_window): Don't call
 898         make_source_or_disasm_window.
 899         (make_data_window): Don't call init_and_make_win.  Change calling
 900         convention.
 901         (show_source_disasm_command, show_data): Simplify.
 902         (make_source_or_disasm_window): Remove.
 903         (show_source_or_disasm_and_command): Simplify.
 904         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 905         (struct tui_source_window_base) <reset>: Likewise.
 906         <execution_info>: Remove initializer.
 907         * tui/tui-data.c (tui_source_window_base): Initialize
 908         execution_info.
 909
 910 2019-07-17  Tom Tromey  <tom@tromey.com>
 911
 912         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 913         variable.
 914
 915 2019-07-17  Tom Tromey  <tom@tromey.com>
 916
 917         * tui/tui.c (tui_rl_other_window): Update.
 918         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 919         superclass method first.  Always iterate over regs_content.
 920         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 921         method.
 922         * tui/tui-win.c (tui_set_focus_command): Update.
 923
 924 2019-07-17  Tom Tromey  <tom@tromey.com>
 925
 926         * tui/tui-win.c (tui_set_focus_command): Rename from
 927         tui_set_focus.  Call tui_enable.
 928         (tui_set_focus_command): Remove.
 929
 930 2019-07-17  Tom Tromey  <tom@tromey.com>
 931
 932         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 933         refresh_window.
 934         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 935         touchwin.
 936         (tui_data_window::refresh_window): Call refresh_window on data
 937         items.  Always call superclass refresh_window.
 938         (tui_win_info::refresh): Remove.
 939         (tui_source_window_base::refresh_window): Update.
 940         (tui_refresh_all): Update.
 941         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 942         refresh_window.
 943         (show_source_or_disasm_and_command): Likewise.
 944         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 945         (struct tui_source_window_base) <refresh>: Likewise.
 946
 947 2019-07-17  Tom Tromey  <tom@tromey.com>
 948
 949         * tui/tui-winsource.c (tui_clear_source_content)
 950         (tui_show_source_content): Update.
 951         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 952         whether content is empty.
 953         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 954         Remove.
 955
 956 2019-07-17  Tom Tromey  <tom@tromey.com>
 957
 958         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 959         window's contents.
 960         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 961         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 962
 963 2019-07-17  Tom Tromey  <tom@tromey.com>
 964
 965         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 966         (struct tui_data_item_window): Update.
 967
 968 2019-07-17  Tom Tromey  <tom@tromey.com>
 969
 970         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 971         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 972         defines.
 973
 974 2019-07-17  Tom Tromey  <tom@tromey.com>
 975
 976         * tui/tui-winsource.h (tui_erase_source_content)
 977         (tui_clear_source_content): Remove "display_prompt" parameter.
 978         * tui/tui-winsource.c (tui_update_source_window_as_is)
 979         (tui_update_source_windows_with_addr): Update.
 980         (tui_clear_source_content): Remove "display_prompt" parameter.
 981         (tui_erase_source_content): Likewise.  Simplify.
 982         (tui_show_source_content): Update.
 983         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 984         * tui/tui-stack.c (tui_show_frame_info): Update.
 985         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 986         Remove defines.
 987
 988 2019-07-17  Tom Tromey  <tom@tromey.com>
 989
 990         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 991         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 992         parameter.
 993         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 994         parameter.
 995
 996 2019-07-17  Tom Tromey  <tom@tromey.com>
 997
 998         * tui/tui-winsource.c (tui_clear_source_content)
 999         (tui_show_source_content, tui_show_exec_info_content)
1000         (tui_clear_exec_info_content): Update.
1001         * tui/tui-stack.c (tui_show_locator_content): Update.
1002         (tui_show_frame_info): Update.
1003         * tui/tui-source.h (tui_source_window): Don't declare.
1004         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1005         from tui_source_is_displayed.
1006         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1007         Remove field.
1008         (struct tui_source_window_base) <content_in_use>: New field.  Now
1009         bool.
1010         (struct tui_source_window) <showing_source_p>: New method.
1011         (TUI_SRC_WIN): Change cast.
1012         * tui/tui-data.c (tui_initialize_static_data): Update.
1013
1014 2019-07-17  Tom Tromey  <tom@tromey.com>
1015
1016         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1017         location_matches_p.
1018         * tui/tui-source.c (tui_source_window::location_matches_p): New
1019         method.
1020         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1021         method.
1022         * tui/tui-data.h (struct tui_source_window_base)
1023         <location_matches_p>: New method.
1024         (struct tui_source_window, struct tui_disasm_window)
1025         <location_matches_p>: Likewise.
1026
1027 2019-07-17  Tom Tromey  <tom@tromey.com>
1028
1029         * tui/tui-win.c (tui_set_win_height_command): Rename from
1030         tui_set_win_height.
1031         (tui_set_win_height_command): Remove.
1032
1033 2019-07-17  Tom Tromey  <tom@tromey.com>
1034
1035         * tui/tui-source.c (tui_source_window): New constructor.  Add
1036         observer.
1037         (~tui_source_window): New destructor.
1038         (tui_source_window::style_changed): New method.
1039         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1040         (tui_attach_detach_observers): Update.
1041         * tui/tui-data.h (struct tui_source_window): Make constructor not
1042         inline.  Add destructor.
1043         (struct tui_source_window) <style_changed>: New method.
1044         <m_observable>: New member.
1045
1046 2019-07-17  Tom Tromey  <tom@tromey.com>
1047
1048         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1049         * tui/tui-win.c (tui_resize_all): Fix typo.
1050
1051 2019-07-17  Tom Tromey  <tom@tromey.com>
1052
1053         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1054         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1055         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1056         * tui/tui-win.c (window_name_completer): Use foreach.
1057         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1058         (update_tab_width): Likewise.
1059         * tui/tui-layout.c (show_layout): Update.
1060         * tui/tui-data.h (class tui_window_iterator): New.
1061         (struct all_tui_windows): New.
1062         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1063
1064 2019-07-17  Tom Tromey  <tom@tromey.com>
1065
1066         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1067         parameter.  Don't reference globals.
1068         (tui_reg_command): Update.
1069
1070 2019-07-17  Tom Tromey  <tom@tromey.com>
1071
1072         * tui/tui-regs.c (tui_show_registers): Simplify.
1073
1074 2019-07-17  Tom Tromey  <tom@tromey.com>
1075
1076         * tui/tui-regs.c (tui_show_registers): Update.
1077         (tui_show_register_group): Add win_info parameter.
1078
1079 2019-07-17  Tom Tromey  <tom@tromey.com>
1080
1081         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1082         Rename from tui_display_reg_element_at_line.
1083         (tui_data_window::display_registers_from_line): Update.
1084         * tui/tui-data.h (struct tui_data_window)
1085         <display_reg_element_at_line>: New method.
1086
1087 2019-07-17  Tom Tromey  <tom@tromey.com>
1088
1089         * tui/tui-regs.h (tui_display_registers_from)
1090         (tui_display_registers_from_line): Don't declare.
1091         * tui/tui-windata.c (tui_data_window::display_all_data)
1092         (tui_data_window::refresh_all)
1093         (tui_data_window::do_scroll_vertical): Update.
1094         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1095         from tui_display_registers_from.
1096         (tui_display_reg_element_at_line): Update.
1097         (tui_data_window::display_registers_from_line): Rename from
1098         tui_display_registers_from_line.
1099         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1100         display_registers_from_line>: New methods.
1101
1102 2019-07-17  Tom Tromey  <tom@tromey.com>
1103
1104         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1105         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1106         from tui_erase_data_content.
1107         (tui_data_window::display_all_data)
1108         (tui_data_window::refresh_all)
1109         (tui_data_window::do_scroll_vertical): Update.
1110         * tui/tui-regs.c (tui_show_registers): Update.
1111         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1112         New method.
1113
1114 2019-07-17  Tom Tromey  <tom@tromey.com>
1115
1116         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1117         declare.
1118         * tui/tui-windata.c
1119         (tui_data_window::delete_data_content_windows): Rename from
1120         tui_delete_data_content_windows.
1121         (tui_data_window::display_all_data)
1122         (tui_data_window::do_scroll_vertical): Update.
1123         * tui/tui-data.h (struct tui_data_window)
1124         <delete_data_content_windows>: New method.
1125
1126 2019-07-17  Tom Tromey  <tom@tromey.com>
1127
1128         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1129         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1130
1131 2019-07-17  Tom Tromey  <tom@tromey.com>
1132
1133         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1134         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1135         from tui_display_all_data.
1136         * tui/tui-win.c
1137         (tui_data_window::do_make_visible_with_new_height): Update.
1138         * tui/tui-regs.c (tui_show_registers): Update.
1139         * tui/tui-layout.c (tui_set_layout): Update.
1140         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1141         method.
1142
1143 2019-07-17  Tom Tromey  <tom@tromey.com>
1144
1145         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1146         * tui/tui-windata.c (tui_display_data_from): Remove.
1147         (tui_data_window::refresh_all): Update.
1148
1149 2019-07-17  Tom Tromey  <tom@tromey.com>
1150
1151         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1152         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1153         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1154         tui_display_registers_from_line.
1155         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1156         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1157         "force_display" parameter.
1158
1159 2019-07-17  Tom Tromey  <tom@tromey.com>
1160
1161         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1162         declare.
1163         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1164         Rename from tui_first_reg_element_no_inline.
1165         (tui_display_reg_element_at_line)
1166         (tui_display_registers_from_line): Update.
1167         * tui/tui-data.h (struct tui_data_window)
1168         <first_reg_element_no_inline>: New method.
1169
1170 2019-07-17  Tom Tromey  <tom@tromey.com>
1171
1172         * tui/tui-windata.c (tui_display_data_from)
1173         (tui_data_window::do_scroll_vertical): Update.
1174         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1175         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1176         Rename from tui_line_from_reg_element_no.
1177         (tui_display_registers_from_line): Update.
1178         * tui/tui-data.h (struct tui_data_window)
1179         <line_from_reg_element_no>: New method.
1180
1181 2019-07-17  Tom Tromey  <tom@tromey.com>
1182
1183         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1184         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1185         tui_last_regs_line_no.
1186         (tui_display_reg_element_at_line)
1187         (tui_display_registers_from_line): Update.
1188         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1189         method.
1190
1191 2019-07-17  Tom Tromey  <tom@tromey.com>
1192
1193         PR tui/24722:
1194         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1195         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1196         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1197         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1198         (tui_update_breakpoint_info): Likewise.
1199         * tui/tui-hooks.c (tui_event_create_breakpoint)
1200         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1201         Update.
1202
1203 2019-07-17  Tom Tromey  <tom@tromey.com>
1204
1205         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1206
1207 2019-07-17  Tom Tromey  <tom@tromey.com>
1208
1209         * tui/tui-winsource.c (tui_update_source_window_as_is)
1210         (tui_update_source_windows_with_addr): Update.
1211         * tui/tui-source.h (tui_set_source_content)
1212         (tui_show_symtab_source): Add "win_info" parameter.
1213         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1214         parameter.
1215         (tui_show_symtab_source): Likewise.
1216
1217 2019-07-17  Tom Tromey  <tom@tromey.com>
1218
1219         * tui/tui-wingeneral.c
1220         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1221
1222 2019-07-17  Tom Tromey  <tom@tromey.com>
1223
1224         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1225         (struct tui_cmd_window) <can_scroll>: New method.
1226         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1227         method.
1228
1229 2019-07-17  Tom Tromey  <tromey@adacore.com>
1230
1231         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1232         do_field_signed>: Rename.  Change type of "value".
1233         * ui-out.c (ui_out::field_signed): Rename from field_int.
1234         Change type of "value".
1235         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1236         type of "value".
1237         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1238         do_field_int.  Change type of "value".
1239         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1240         do_field_int.  Change type of "value".
1241         * tracepoint.c (trace_status_mi, tfind_1)
1242         (print_one_static_tracepoint_marker): Update.
1243         * thread.c (print_thread_info_1, print_selected_thread_frame):
1244         Update.
1245         * stack.c (print_frame, print_frame_info): Update.
1246         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1247         Update.
1248         * source.c (print_source_lines_base): Update.
1249         * skip.c (info_skip_command): Update.
1250         * record-btrace.c (btrace_ui_out_decode_error)
1251         (btrace_call_history_src_line): Update.
1252         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1253         Update.
1254         * progspace.c (print_program_space): Update.
1255         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1256         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1257         do_field_int.  Change type of "value".
1258         * mi/mi-out.c (mi_ui_out::do_table_begin)
1259         (mi_ui_out::do_table_header): Update.
1260         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1261         type of "value".
1262         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1263         (mi_cmd_data_list_changed_registers, output_register)
1264         (mi_cmd_data_read_memory, mi_load_progress)
1265         (mi_cmd_trace_frame_collected): Update.
1266         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1267         Update.
1268         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1269         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1270         (mi_cmd_var_list_children, varobj_update_one): Update.
1271         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1272         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1273         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1274         * inferior.c (print_inferior): Update.
1275         * gdb_bfd.c (print_one_bfd): Update.
1276         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1277         Update.
1278         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1279         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1280         do_field_int.  Change type of "value".
1281         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1282         do_field_int.  Change type of "value".
1283         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1284         (print_one_breakpoint_location, print_it_catch_fork)
1285         (print_one_catch_fork, print_it_catch_vfork)
1286         (print_one_catch_vfork, print_it_catch_solib)
1287         (print_it_catch_exec, print_it_ranged_breakpoint)
1288         (print_mention_watchpoint, print_mention_masked_watchpoint)
1289         (bkpt_print_it, update_static_tracepoint): Update.
1290         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1291         * break-catch-syscall.c (print_it_catch_syscall): Update.
1292         * ada-tasks.c (print_ada_task_info): Update.
1293         * ada-lang.c (print_it_exception, print_mention_exception):
1294         Update.
1295
1296 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1297
1298         PR breakpoints/24541
1299         * gdbarch.c: Regenerate.
1300         * gdbarch.h: Regenerate.
1301         * gdbarch.sh: Adjust return type and parameter types for
1302         'stap_adjust_register'.
1303         (i386_stap_adjust_register): Adjust signature and return new
1304         register name.
1305         * stap-probe.c (stap_parse_register_operand): Adjust use of
1306         'gdbarch_stap_adjust_register'.
1307
1308 2019-07-17  Tom Tromey  <tromey@adacore.com>
1309
1310         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1311         declare VEC.
1312         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1313         std::vector.
1314         (struct s390_process_info): Add initializers.
1315         (s390_add_process): Use new.
1316         (s390_linux_nat_target::low_forget_process): Use delete.
1317         (s390_linux_nat_target::low_new_fork)
1318         (s390_linux_nat_target::stopped_by_watchpoint)
1319         (s390_linux_nat_target::low_prepare_to_resume)
1320         (s390_linux_nat_target::insert_watchpoint)
1321         (s390_linux_nat_target::insert_hw_breakpoint)
1322         (s390_linux_nat_target::remove_watchpoint)
1323         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1324
1325 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1326
1327         * aarch64-fbsd-nat.c: Include regcache.h.
1328         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1329         argument.
1330         (aarch64_fbsd_nat_target::fetch_registers)
1331         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1332         variable.
1333         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1334
1335 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1336
1337         * fbsd-nat.c: Include gdbarch.h.
1338
1339 2019-07-15  Tom Tromey  <tromey@adacore.com>
1340
1341         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1342
1343 2019-07-15  Tom Tromey  <tromey@adacore.com>
1344
1345         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1346         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1347         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1348         * cli-out.c (cli_ui_out::do_field_int): New method.
1349         * ui-out.c (ui_out::field_unsigned): New method.
1350         * symfile.c (generic_load): Use field_unsigned.
1351         (print_transfer_performance): Likewise.
1352         * record-btrace.c (ui_out_field_uint): Remove.
1353         (btrace_call_history_insn_range, btrace_call_history): Use
1354         field_unsigned.
1355         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1356         field_unsigned.
1357         * ui-out.h (class ui_out) <field_unsigned>: New method.
1358         <do_field_unsigned>: Likewise.
1359
1360 2019-07-15  Tom Tromey  <tromey@adacore.com>
1361
1362         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1363         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1364         * target.c (flash_erase_command): Use field_string.
1365         * infrun.c (print_signal_received_reason): Use field_string.
1366         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1367         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1368         field_string.
1369         * ada-tasks.c (print_ada_task_info): Use field_string.
1370
1371 2019-07-15  Tom Tromey  <tromey@adacore.com>
1372
1373         * target.c (flash_erase_command): Use field_core_addr.
1374         * symfile.c (generic_load): Use field_core_addr.
1375         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1376         Use field_core_addr.
1377         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1378         field_core_addr.
1379
1380 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1381
1382         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1383         value if its desired type is smaller than a CORE_ADDR and signed.
1384
1385 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1386
1387         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1388         of changes to field names, and use new is_reference field to
1389         decide if a property is a reference or not.
1390         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1391         field.
1392         (struct dwarf2_property_baton): Update header comment, rename
1393         'referenced_type' to 'property_type' and update comments.
1394         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1395         default property type, store in property baton, update to take
1396         accound of renamed field.
1397         (read_func_scope): Update call to attr_to_dynamic_prop.
1398         (read_array_type): Likewise.
1399         (dwarf2_per_cu_addr_sized_int_type): New function.
1400         (read_subrange_index_type): Move type finding code to
1401         dwarf2_per_cu_addr_sized_int_type.
1402         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1403         (dwarf2_per_cu_addr_type): New function.
1404         (set_die_type): Update calls to attr_to_dynamic_prop.
1405
1406 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1407
1408         * dwarf2read.c (read_subrange_index_type): New function.
1409         (read_subrange_type): Move code into new function and call it.
1410         * gdbtypes.c (create_range_type): Add some asserts.
1411
1412 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1413
1414         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1415         update return statements.
1416         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1417         declaration, and update comment to match.
1418         * gdbtypes.c (resolve_dynamic_array): Update call to
1419         dwarf2_evaluate_property to match new return type.
1420
1421 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1422
1423         * valarith.c (value_subscripted_rvalue): Change lowerbound
1424         parameter type from int to LONGEST.
1425         * value.h (value_subscripted_rvalue): Likewise in declaration.
1426
1427 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1428
1429         * cli/cli-utils.c (info_print_command_completer): New function.
1430         * cli/cli-utils.h: Add 'completer.h' include, and forward
1431         declaration for 'struct cmd_list_element'.
1432         (info_print_command_completer): Declare.
1433         * stack.c (_initialize_stack): Add completer for 'info locals' and
1434         'info args'.
1435         * symtab.c (_initialize_symtab): Add completer for 'info
1436         variables' and 'info functions'.
1437         * NEWS: Mention completion for additional info commands.
1438
1439 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1440
1441         * cli/cli-utils.c (extract_info_print_args): Delete.
1442         (extract_arg_maybe_quoted): Delete.
1443         (info_print_options_defs): New variable.
1444         (make_info_print_options_def_group): New function.
1445         (extract_info_print_options): Define new function.
1446         * cli/cli-utils.h (extract_info_print_args): Delete.
1447         (struct info_print_options): New structure.
1448         (extract_info_print_options): Declare new function.
1449         * stack.c (info_locals_command): Update to use new
1450         extract_info_print_options, also add a header comment.
1451         (info_args_command): Likewise.
1452         * symtab.c (info_variables_command): Likewise.
1453         (info_functions_command): Likewise.
1454
1455 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1456
1457         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1458         to extract string arguments.
1459         * common/common-utils.c (extract_string_maybe_quoted): New function.
1460         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1461
1462 2019-07-11  Tom Tromey  <tromey@adacore.com>
1463
1464         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1465         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1466         * top.h (gdbinit): Don't declare.
1467         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1468         into...
1469         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1470         * top.c (gdb_init): Don't call init_cli_cmds.
1471         (gdbinit): Remove.
1472         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1473
1474 2019-07-11  Tom Tromey  <tromey@adacore.com>
1475
1476         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1477         after it has been moved.
1478
1479 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1480
1481         * valops.c (value_must_coerce_to_target): Change return type to
1482         bool.
1483         * value.h (value_must_coerce_to_target): Likewise.
1484
1485 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1486
1487         * breakpoint.c (is_hardware_watchpoint): Remove
1488         forward-declaration.
1489         (is_masked_watchpoint): Change return type to bool.
1490         (is_tracepoint): Likewise.
1491         (is_breakpoint): Likewise.
1492         (is_hardware_watchpoint): Likewise.
1493         (is_watchpoint): Likewise.
1494         (is_no_memory_software_watchpoint): Likewise.
1495         (is_catchpoint): Likewise.
1496         (breakpoint_1): Make FILTER parameter's return type bool.
1497         is_masked_watchpoint): Change return type to bool.
1498         (save_breakpoints): Make FILTER parameter's return type bool.
1499         * breakpoint.h (is_breakpoint): Change return type to bool.
1500         (is_watchpoint): Likewise.
1501         (is_catchpoint): Likewise.
1502         (is_tracepoint): Likewise.
1503
1504 2019-07-10  Tom Tromey  <tom@tromey.com>
1505
1506         * defs.h: Don't include gdbarch.h.
1507         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1508         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1509         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1510         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1511         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1512         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1513         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1514         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1515         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1516         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1517         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1518         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1519         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1520         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1521         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1522         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1523         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1524         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1525         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1526         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1527         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1528         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1529         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1530         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1531         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1532         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1533         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1534
1535 2019-07-10  Tom Tromey  <tromey@adacore.com>
1536
1537         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1538         * breakpoint.c (init_ada_exception_breakpoint): Register as
1539         bp_catchpoint.
1540         (print_one_breakpoint_location, print_one_breakpoint): Use
1541         is_ada_exception_catchpoint.
1542         * ada-lang.c (class ada_catchpoint_location): Pass
1543         bp_loc_software_breakpoint to bp_location constructor.
1544         (is_ada_exception_catchpoint): New function.
1545
1546 2019-07-10  Tom Tromey  <tromey@adacore.com>
1547
1548         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1549         VEC.
1550         (struct arm_exidx_entry): New method operator<.
1551         (struct arm_exidx_data) <section_maps>: Change type.
1552         (arm_exidx_data_free): Remove.
1553         (arm_exidx_data_key): Change type.  Move lower.
1554         (arm_exidx_new_objfile): Update.
1555         (arm_compare_exidx_entries): Remove.
1556         (arm_find_exidx_entry, _initialize_arm_tdep)
1557
1558 2019-07-10  Tom Tromey  <tromey@adacore.com>
1559
1560         * solib-spu.c (ocl_program_data_key): Change type.
1561         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1562         Update.
1563
1564 2019-07-10  Tom Tromey  <tromey@adacore.com>
1565
1566         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1567         (struct solib_aix_inferior_data) <library_list>: Change type.
1568         (solib_aix_inferior_data_handle): Change type.
1569         (get_solib_aix_inferior_data): Update.
1570         (solib_aix_free_library_list): Remove.
1571         (library_list_start_library): Update.
1572         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1573         return type.
1574         (solib_aix_get_library_list)
1575         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1576         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1577
1578 2019-07-10  Tom Tromey  <tromey@adacore.com>
1579
1580         * solib-dsbt.c (struct dsbt_info): Add initializers.
1581         (solib_dsbt_pspace_data): Change type.
1582         (dsbt_pspace_data_cleanup): Remove.
1583         (get_dsbt_info, _initialize_dsbt_solib): Update.
1584
1585 2019-07-10  Tom Tromey  <tromey@adacore.com>
1586
1587         * spu-tdep.c (spu_overlay_data): Change type.
1588         (spu_get_overlay_table, spu_overlay_new_objfile)
1589         (_initialize_spu_tdep): Update.
1590
1591 2019-07-10  Tom Tromey  <tromey@adacore.com>
1592
1593         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1594         destructor.
1595         (dbx_objfile_data_key): Change type and declare later.
1596         (DBX_SYMFILE_INFO): Rewrite.
1597         * dbxread.c (dbx_objfile_data_key): Change type.
1598         (dbx_symfile_init): Update.
1599         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1600         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1601         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1602
1603 2019-07-10  Tom Tromey  <tromey@adacore.com>
1604
1605         * jit.c (jit_program_space_key): Change type.  Move lower.
1606         (get_jit_program_space_data): Update.
1607         (jit_program_space_data_cleanup): Remove.
1608         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1609         Update.
1610         (struct jit_program_space_data): Add initializers.
1611
1612 2019-07-10  Tom Tromey  <tromey@adacore.com>
1613
1614         * solib-darwin.c (struct darwin_info): Add initializers.
1615         (solib_darwin_pspace_data): Change type.
1616         (darwin_pspace_data_cleanup): Remove.
1617         (get_darwin_info, _initialize_darwin_solib): Update.
1618
1619 2019-07-10  Tom Tromey  <tromey@adacore.com>
1620
1621         * remote-sim.c (struct sim_inferior_data): Add initializers,
1622         constructor, and destructor.
1623         (sim_inferior_data_key): Change type.  Move lower.
1624         (check_for_duplicate_sim_descriptor): Update.
1625         (get_sim_inferior_data): Use new.  Update.
1626         (~sim_inferior_data_cleanup): Rename from
1627         sim_inferior_data_cleanup.  Simplify.
1628         (gdbsim_close_inferior, simulator_command)
1629         (sim_command_completer, _initialize_remote_sim): Update.
1630         (next_pid, INITIAL_PID): Move earlier.
1631
1632 2019-07-10  Tom Tromey  <tromey@adacore.com>
1633
1634         * python/python-internal.h (create_thread_object): Return
1635         gdbpy_ref.
1636         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1637         * python/py-inferior.c (struct threadlist_entry): Add
1638         constructor.
1639         <thread_obj>: Now a gdbpy_ref.
1640         (thread_to_thread_object): Update.
1641         (add_thread_object): Use new.
1642         (delete_thread_object): Use delete.
1643         (infpy_threads): Update.
1644         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1645         GIL.
1646
1647 2019-07-10  Tom Tromey  <tromey@adacore.com>
1648
1649         * valops.c (value_cast): Specialize error message for Ada.
1650
1651 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1652
1653         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1654
1655 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1656
1657         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1658         bpstat_should_step): Return bool, adjust comments.
1659         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1660         bpstat_should_step): Likewise.
1661
1662 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1663
1664         * features/Makefile: Use feature target descriptions for Arm.
1665         * features/arm/arm-core.c: Generate new file.
1666         * features/arm/arm-fpa.c: Likewise.
1667         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1668         * features/arm/arm-m-profile.c: Likewise.
1669         * features/arm/arm-vfpv2.c: Likewise.
1670         * features/arm/arm-vfpv3.c: Likewise.
1671         * features/arm/xscale-iwmmxt.c: Likewise.
1672         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1673
1674 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1675
1676         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1677         ptrace earlier.
1678
1679 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1680
1681         * features/aarch64-pauth.c: Regenerate.
1682
1683 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1684
1685         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1686         bool.
1687         (bpstat_what): Use false instead of 0.
1688
1689 2019-07-09  Pedro Alves  <palves@redhat.com>
1690
1691         * break-catch-throw.c (is_exception_catchpoint): New.
1692         * breakpoint.c (print_one_breakpoint_location): New parameter
1693         'raw_loc'.  Handle it.  Use
1694         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1695         looking at the breakpoint's type.
1696         (print_one_breakpoint): If handling "maint info breakpoints", also
1697         print locations of exception catchpoints.
1698         * breakpoint.h (is_exception_catchpoint): Declare.
1699
1700 2019-07-09  Pedro Alves  <palves@redhat.com>
1701
1702         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1703         "addr" field.
1704         (allocate_location_exception_catchpoint): New.
1705         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1706         (initialize_throw_catchpoint_ops): Install
1707         allocate_location_exception_catchpoint as allocate_location
1708         method.
1709         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1710         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1711         bp_loc_other.
1712         (breakpoint_address_is_meaningful): Delete.
1713         (bl_address_is_meaningful): New.
1714         (breakpoint_locations_match): Adjust comment.
1715         (bp_location_from_bp_type): New, factored out of...
1716         (bp_location::bp_location(breakpoint *)): ... this.
1717         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1718         factored out of...
1719         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1720         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1721         breakpoint_address_is_meaningful.
1722         (bp_locations_compare): Adjust comment.
1723         (update_global_location_list): Use bl_address_is_meaningful
1724         instead of breakpoint_address_is_meaningful.
1725         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1726         explicit.
1727         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1728         * python/py-breakpoint.c (bppy_get_location): No longer check
1729         whether location is null.
1730
1731 2019-07-09  Pedro Alves  <palves@redhat.com>
1732
1733         PR c++/15468
1734         * breakpoint.c (print_one_breakpoint_location): Remove
1735         single-location assert.
1736
1737 2019-07-09  Tom Tromey  <tom@tromey.com>
1738
1739         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1740         * configure: Rebuild.
1741         * configure.ac: Change common to gdbsupport.
1742         * gdbsupport: Rename from common.
1743         * acinclude.m4: Change common to gdbsupport.
1744         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1745         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1746         gdbsupport.
1747         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1748         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1749         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1750         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1751         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1752         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1753         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1754         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1755         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1756         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1757         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1758         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1759         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1760         coff-pe-read.c, command.h, compile/compile-c-support.c,
1761         compile/compile-c.h, compile/compile-cplus-symbols.c,
1762         compile/compile-cplus-types.c, compile/compile-cplus.h,
1763         compile/compile-loc2c.c, compile/compile.c, completer.c,
1764         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1765         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1766         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1767         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1768         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1769         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1770         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1771         features/aarch64-core.c, features/aarch64-fpu.c,
1772         features/aarch64-pauth.c, features/aarch64-sve.c,
1773         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1774         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1775         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1776         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1777         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1778         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1779         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1780         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1781         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1782         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1783         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1784         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1785         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1786         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1787         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1788         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1789         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1790         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1791         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1792         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1793         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1794         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1795         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1796         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1797         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1798         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1799         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1800         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1801         minsyms.c, mips-linux-tdep.c, namespace.h,
1802         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1803         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1804         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1805         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1806         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1807         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1808         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1809         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1810         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1811         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1812         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1813         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1814         procfs.c, producer.c, progspace.h, psymtab.h,
1815         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1816         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1817         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1818         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1819         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1820         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1821         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1822         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1823         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1824         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1825         target-memory.c, target.c, target.h, target/waitstatus.c,
1826         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1827         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1828         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1829         unittests/array-view-selftests.c,
1830         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1831         unittests/common-utils-selftests.c,
1832         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1833         unittests/format_pieces-selftests.c,
1834         unittests/function-view-selftests.c,
1835         unittests/lookup_name_info-selftests.c,
1836         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1837         unittests/mkdir-recursive-selftests.c,
1838         unittests/observable-selftests.c,
1839         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1840         unittests/parse-connection-spec-selftests.c,
1841         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1842         unittests/scoped_fd-selftests.c,
1843         unittests/scoped_mmap-selftests.c,
1844         unittests/scoped_restore-selftests.c,
1845         unittests/string_view-selftests.c, unittests/style-selftests.c,
1846         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1847         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1848         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1849         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1850         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1851         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1852
1853 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1854
1855         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1856         bool value.
1857         (decode_digits_ordinary): Set explicit_line field in sal.
1858         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1859         symtab_and_line that was set on an explicit line number in
1860         assembler code.  Do always update the recorded symtab and line if
1861         we do skip the prologue.
1862
1863 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1864
1865         * breakpoint.c (set_breakpoint_location_function): Remove
1866         explicit_loc parameter.
1867         (momentary_breakpoint_from_master): Update call to
1868         set_breakpoint_location_function.
1869         (add_location_to_breakpoint): Likewise.
1870
1871 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1872
1873         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1874         required features based on default bfd type when no specific bfd
1875         is present.
1876
1877 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1878
1879         * NEWS: Mention that GDB printf and eval commands can now print
1880         C-style and Ada-style convenience var strings without
1881         calling the inferior.
1882         * printcmd.c (printf_c_string): Locally print GDB internal var
1883         instead of transiting via the inferior.
1884         (printf_wide_c_string): Likewise.
1885
1886 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1887
1888         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1889
1890 2019-07-04  Tom Tromey  <tom@tromey.com>
1891
1892         PR tui/24724:
1893         * tui/tui-winsource.c (tui_clear_source_content): Update.
1894         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1895         (tui_update_breakpoint_info): Update.
1896         (tui_set_exec_info_content): Update.
1897         * tui/tui-source.c (tui_set_source_content_nil): Update.
1898         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1899         has_break.
1900         * tui/tui-data.h (enum tui_bp_flag): New.
1901         (tui_bp_flags): New enum flags type.
1902         (struct tui_source_element) <break_mode>: Change type.  Rename
1903         from has_break.
1904         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1905         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1906         constants.
1907         * tui/tui-winsource.h: Fix comment.
1908
1909 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1910
1911         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1912         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1913         (store_fpregs_to_thread)
1914         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1915         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1916         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1917         (IWMMXT_REGS_SIZE): Add define.
1918         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1919         (fetch_vfp_regs, store_vfp_regs)
1920         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1921         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1922
1923 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1924
1925         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1926         defines.
1927         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1928         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1929         (ARM_INT_REGISTER_SIZE): ...to this.
1930         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1931         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1932         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1933         (arm_linux_collect_gregset, supply_nwfpe_register)
1934         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1935         defines.
1936         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1937         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1938         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1939         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1940         (arm_return_in_memory, arm_store_return_value)
1941         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1942         (arm_record_ld_st_multiple): Likewise.
1943         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1944         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1945
1946 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1947
1948         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1949         AARCH64_DISPLACED_MODIFIED_INSNS.
1950         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1951         (aarch64_displaced_step_copy_insn): Likewise.
1952         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1953         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1954         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1955         ARM_DISPLACED_MODIFIED_INSNS.
1956         * arm-tdep.c (arm_gdbarch_init): Likewise.
1957         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1958         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1959         (struct arm_displaced_step_closure): Use
1960         ARM_DISPLACED_MODIFIED_INSNS.
1961
1962 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1963
1964         * features/Makefile: Remove unused xml files.
1965         * features/aarch64.xml: Remove.
1966         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1967         * features/i386/amd64-avx-avx512.xml: Remove.
1968         * features/i386/amd64-avx-linux.xml: Remove.
1969         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1970         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1971         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1972         * features/i386/amd64-avx-mpx.xml: Remove.
1973         * features/i386/amd64-avx.xml: Remove.
1974         * features/i386/amd64-linux.xml: Remove.
1975         * features/i386/amd64-mpx-linux.xml: Remove.
1976         * features/i386/amd64-mpx.xml: Remove.
1977         * features/i386/amd64.xml: Remove.
1978         * features/i386/i386-avx-avx512-linux.xml: Remove.
1979         * features/i386/i386-avx-avx512.xml: Remove.
1980         * features/i386/i386-avx-linux.xml: Remove.
1981         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1982         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1983         * features/i386/i386-avx-mpx-linux.xml: Remove.
1984         * features/i386/i386-avx-mpx.xml: Remove.
1985         * features/i386/i386-avx.xml: Remove.
1986         * features/i386/i386-linux.xml: Remove.
1987         * features/i386/i386-mmx-linux.xml: Remove.
1988         * features/i386/i386-mmx.xml: Remove.
1989         * features/i386/i386-mpx-linux.xml: Remove.
1990         * features/i386/i386-mpx.xml: Remove.
1991         * features/i386/i386.xml: Remove.
1992         * features/i386/x32-avx-avx512-linux.xml: Remove.
1993         * features/i386/x32-avx-linux.xml: Remove.
1994         * features/i386/x32-linux.xml: Remove.
1995
1996 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1997
1998         * regformats/aarch64.dat: Remove.
1999         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2000         * regformats/i386/amd64-avx-linux.dat: Remove.
2001         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2002         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2003         * regformats/i386/amd64-linux.dat: Remove.
2004         * regformats/i386/amd64-mpx-linux.dat: Remove.
2005         * regformats/i386/amd64.dat: Remove.
2006         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2007         * regformats/i386/i386-avx-linux.dat: Remove.
2008         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2009         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2010         * regformats/i386/i386-linux.dat: Remove.
2011         * regformats/i386/i386-mmx-linux.dat: Remove.
2012         * regformats/i386/i386-mpx-linux.dat: Remove.
2013         * regformats/i386/i386.dat: Remove.
2014         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2015         * regformats/i386/x32-avx-linux.dat: Remove.
2016         * regformats/i386/x32-linux.dat: Remove.
2017
2018 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2019
2020         * aarch64-tdep.c: Remove xml self tests.
2021         * amd64-linux-tdep.c: Likewise.
2022         * amd64-tdep.c: Likewise.
2023         * i386-linux-tdep.c: Likewise.
2024         * i386-tdep.c: Likewise.
2025
2026 2019-07-03  Pedro Alves  <palves@redhat.com>
2027
2028         PR cli/24732
2029         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2030         (pipe_cmd_option_defs): New.
2031         (make_pipe_cmd_options_def_group): New.
2032         (pipe_command): Use gdb::option::process_options.
2033         (pipe_command_completer): New function.
2034         (_initialize_cli_cmds): Install completer for "pipe" command.
2035
2036 2019-07-03  Pedro Alves  <palves@redhat.com>
2037
2038         * cli/cli-option.c (union option_value) <string>: New field.
2039         (struct option_def_and_value): Add ctor, move ctor, dtor and
2040         use DISABLE_COPY_AND_ASSIGN.
2041         (option_def_and_value::clear_value): New.
2042         (parse_option, save_option_value_in_ctx, get_val_type_str)
2043         (add_setshow_cmds_for_options): Handle var_string.
2044         * cli-option.h (union option_def::var_address) <string>: New
2045         field.
2046         (struct string_option_def): New.
2047         * maint-test-options.c (struct test_options_opts): Add default
2048         ctor and use DISABLE_COPY_AND_ASSIGN.
2049         <string_opt>: New field.
2050         (test_options_opts::~test_options_opts): New.
2051         (test_options_opts::dump): Also dump "-string".
2052         (test_options_option_defs): Install "string.
2053
2054 2019-07-03  Pedro Alves  <palves@redhat.com>
2055
2056         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2057         option_value with a null enumeration.
2058         (complete_options): Save the option values in the context.
2059         (save_option_value_in_ctx): New, factored out from ...
2060         (process_options): ... here.
2061         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2062         of the function.
2063         * maint-test-options.c (test_options_opts::dump): New, factored
2064         out from ...
2065         (maintenance_test_options_command_mode): ... here.
2066         (maintenance_test_options_command_completion_result): Delete.
2067         (maintenance_test_options_command_completion_text): Update
2068         comment.
2069         (maintenance_show_test_options_completion_result): Change
2070         prototype.  Just print
2071         maintenance_test_options_command_completion_text.
2072         (save_completion_result): New.
2073         (maintenance_test_options_completer_mode): Pass options context to
2074         complete_options, and then save a dump.
2075         (_initialize_maint_test_options): Use add_cmd to install "maint
2076         show test-options-completion-result".
2077
2078 2019-07-03  Pedro Alves  <palves@redhat.com>
2079
2080         * NEWS (New commands): Mention "with" and "maint with".
2081         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2082         (with_command, with_command_completer): New.
2083         (pipe_command): Adjust to new repeat_previous
2084         interface.
2085         (_initialize_cli_cmds): Install the "with" command and its "w"
2086         alias.
2087         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2088         declarations.
2089         * cli/cli-setshow.c (parse_cli_var_uinteger)
2090         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2091         argument strings for all var_types.
2092         (get_setshow_command_value_string): New, factored out from ...
2093         (do_show_command): ... this.
2094         * cli/cli-setshow.h: Include <string>.
2095         (get_setshow_command_value_string): Declare.
2096         * command.h (repeat_previous): Now returns const char *.  Adjust
2097         comment.
2098         * maint.c: Include "cli/cli-cmds.h".
2099         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2100         (_initialize_maint_cmds): Register the "maintenance with" command.
2101         * top.c (repeat_previous): Move bits from pipe_command here:
2102         Return the saved command line, if any; error out if there's no
2103         command to relaunch.
2104
2105 2019-07-03  Pedro Alves  <palves@redhat.com>
2106
2107         * NEWS (New commands): Mention "maint set/show test-settings"
2108         instead of "maint test-settings".
2109         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2110         (maintenance_test_settings_set_list): Rename to ...
2111         (maintenance_set_test_settings_list): ... this.
2112         (maintenance_test_settings_show_list): Rename to  ...
2113         (maintenance_show_test_settings_list): ... this.
2114         (maintenance_test_settings_cmd): Delete.
2115         (maintenance_test_settings_set_cmd): ...
2116         (maintenance_set_test_settings_cmd): ... this.
2117         (maintenance_test_settings_show_cmd): ...
2118         (maintenance_show_test_settings_cmd): ... this.
2119         (maintenance_test_settings_show_value_cmd):
2120         (maintenance_show_test_settings_value_cmd): ... this.
2121         (_initialize_maint_test_settings): No longer install the "maint
2122         test-settings" prefix command.  Rename "maint test-settings set"
2123         to "maint set test-settings", and "maint test-settings show" to
2124         "maint show test-settings".  Adjust all subcommands.
2125
2126 2019-07-03  Pedro Alves  <palves@redhat.com>
2127
2128         * maint-test-settings.c: Fix file's intro comment.  Replace all
2129         references to "test-options" with references to "test-settings",
2130         in comments.
2131
2132 2019-07-03  Pedro Alves  <palves@redhat.com>
2133
2134         * maint-test-settings.c (maintenance_test_settings_xxx)
2135         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2136         New.
2137         (maintenance_test_settings_enums): Use them.
2138         (maintenance_test_settings_enum): Default to
2139         maintenance_test_settings_xxx.
2140         (_initialize_maint_test_settings): Initialize
2141         MAINTENANCE_TEST_SETTINGS_FILENAME.
2142
2143 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2144
2145         * breakpoint.h (remove_breakpoints_inf): Change return type to
2146         void, move function documentation here.
2147         * breakpoint.c (remove_breakpoints_inf): Change return type to
2148         void, move function documentation to header.
2149
2150 2019-07-02  Pedro Alves  <palves@redhat.com>
2151
2152         * NEWS (Completion improvements): Mention "info threads".
2153         * thread.c (struct info_threads_opts, info_threads_option_defs)
2154         (make_info_threads_options_def_group): New.
2155         (info_threads_command): Use gdb::option::process_options.
2156         (info_threads_command_completer): New.
2157         (_initialize_thread): Use gdb::option::build_help to build the
2158         help text for "info threads".
2159
2160 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2161
2162         * defs.h (generic_load): Move from here...
2163         * symfile.h (generic_load): ... to here.  Rename name parameter
2164         to args.
2165         * symfile.c (generic_load): Add comment.
2166
2167 2019-07-01  Tom Tromey  <tromey@adacore.com>
2168
2169         * dwarf2read.c
2170         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2171         declaration of without_params.  Fix formatting.
2172
2173 2019-07-01  Tom Tromey  <tromey@adacore.com>
2174
2175         * ada-exp.y (find_primitive_type): Update.
2176         * ada-lang.h (ada_lookup_symbol): Update.
2177         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2178         parameter.
2179         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2180
2181 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2182
2183         PR breakpoints/24541
2184         * gdbarch.c: Regenerate.
2185         * gdbarch.h: Regenerate.
2186         * gdbarch.sh: Add 'stap_adjust_register'.
2187         * i386-tdep.c: Include '<unordered_set>'.
2188         (i386_stap_adjust_register): New function.
2189         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2190         * stap-probe.c (stap_parse_register_operand): Call
2191         'gdbarch_stap_adjust_register'.
2192
2193 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2194
2195         PR python/24742
2196         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2197         * python/python.c (do_start_initialization): Use 'xmalloc'
2198         instead of 'PyMem_Malloc'.
2199
2200 2019-06-28  Tom Tromey  <tromey@adacore.com>
2201
2202         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2203         for Ada.
2204
2205 2019-06-27  Tom Tromey  <tromey@adacore.com>
2206
2207         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2208         objfile_key.
2209         (arm_find_mapping_symbol, arm_record_special_symbol)
2210         (_initialize_arm_tdep): Update.
2211         (arm_objfile_data_free): Remove.
2212
2213 2019-06-27  Tom Tromey  <tromey@adacore.com>
2214
2215         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2216         to cp_print_static_field.
2217
2218 2019-06-26  Tom Tromey  <tromey@adacore.com>
2219
2220         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2221         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2222         declare.
2223
2224 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2225
2226         * features/aarch64-core.c (create_feature_aarch64_core):
2227         Regenerate.
2228         * features/aarch64-core.xml: Add cpsr flags.
2229
2230 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2231
2232         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2233         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2234
2235 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2236
2237         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2238         field.
2239         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2240         use.
2241         (arm_record_special_symbol): Don't insert new symbol in sorted
2242         position, push it at the end.
2243
2244 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2245
2246         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2247         (arm_mapping_symbol_s): Remove.
2248         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2249         (arm_mapping_symbol_vec): New typedef.
2250         (struct arm_per_objfile): Add constructor.
2251         <section_maps>: Change type to
2252         std::unique_ptr<arm_mapping_symbol_vec[]>.
2253         (arm_compare_mapping_symbols): Remove.
2254         (arm_find_mapping_symbol): Adjust to section_maps type change.
2255         (arm_objfile_data_free): Call delete on arm_per_objfile.
2256         (arm_record_special_symbol): Adjust to section_maps type change.
2257         Allocate arm_per_objfile with new.
2258
2259 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2260
2261         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2262         with the command prefix.
2263
2264 2019-06-25  Tom Tromey  <tom@tromey.com>
2265
2266         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2267         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2268
2269 2019-06-25  Tom Tromey  <tom@tromey.com>
2270
2271         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2272         type.
2273         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2274         protected.
2275
2276 2019-06-25  Tom Tromey  <tom@tromey.com>
2277
2278         * tui/tui-winsource.c
2279         (tui_source_window_base::set_is_exec_point_at): Add check against
2280         LOA_ADDRESS.
2281
2282 2019-06-25  Tom Tromey  <tom@tromey.com>
2283
2284         * tui/tui-source.c (tui_set_source_content): Don't check before
2285         xfree.
2286         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2287
2288 2019-06-25  Tom Tromey  <tom@tromey.com>
2289
2290         * tui/tui-winsource.h (tui_update_source_window_as_is)
2291         (tui_alloc_source_buffer, tui_line_is_displayed)
2292         (tui_addr_is_displayed): Change type of win_info.
2293         * tui/tui-winsource.c (tui_update_source_window_as_is)
2294         (tui_clear_source_content, tui_show_source_line)
2295         (tui_show_source_content, tui_source_window_base::refill)
2296         (tui_source_window_base::set_is_exec_point_at)
2297         (tui_source_window_base::set_is_exec_point_at)
2298         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2299         (tui_alloc_source_buffer, tui_line_is_displayed)
2300         (tui_addr_is_displayed): Change type of win_info.  Update.
2301         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2302         (tui_source_window_base::do_make_visible_with_new_height):
2303         Update.
2304         * tui/tui-source.c (tui_set_source_content)
2305         (tui_set_source_content_nil)
2306         (tui_source_window::do_scroll_vertical): Update.
2307         * tui/tui-layout.c (show_layout): Update.
2308         * tui/tui-disasm.c (tui_set_disassem_content)
2309         (tui_disasm_window::do_scroll_vertical): Update.
2310         * tui/tui-data.h (tui_win_content): Remove.
2311         (struct tui_gen_win_info) <content, content_size>: Remove.
2312         (struct tui_source_element): Add initializers and destructor.
2313         (union tui_which_element, struct tui_win_element): Remove.
2314         (struct tui_source_window_base) <content>: New field.
2315         (struct tui_data_window): Remove destructor.
2316         (tui_alloc_content, tui_free_win_content)
2317         (tui_free_all_source_wins_content): Don't declare.
2318         * tui/tui-data.c (tui_initialize_static_data): Update.
2319         (init_content_element, tui_alloc_content): Remove.
2320         (~tui_gen_win_info): Update.
2321         (~tui_data_window, tui_free_all_source_wins_content)
2322         (tui_free_win_content, free_content, free_content_elements):
2323         Remove.
2324
2325 2019-06-25  Tom Tromey  <tom@tromey.com>
2326
2327         * tui/tui-winsource.h (tui_clear_source_content)
2328         (tui_erase_source_content, tui_show_source_content): Change type
2329         of win_info.
2330         * tui/tui-winsource.c (tui_clear_source_content)
2331         (tui_erase_source_content, tui_show_source_content): Change type
2332         of win_info.
2333         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2334         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2335         win_info.
2336         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2337         win_info.
2338         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2339
2340 2019-06-25  Tom Tromey  <tom@tromey.com>
2341
2342         * tui/tui-winsource.c (tui_clear_source_content)
2343         (tui_source_window_base::set_is_exec_point_at): Update.
2344         * tui/tui-source.c (tui_set_source_content_nil): Update.
2345         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2346         a bool.
2347         * tui/tui-data.c (init_content_element): Update.
2348
2349 2019-06-25  Tom Tromey  <tom@tromey.com>
2350
2351         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2352         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2353         * tui/tui-layout.c (init_and_make_win): Update.
2354         * tui/tui.h (enum tui_win_type): Update.
2355         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2356         tui_win_is_auxillary.
2357         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2358         tui_win_is_auxillary.
2359
2360 2019-06-25  Tom Tromey  <tom@tromey.com>
2361
2362         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2363         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2364         (tui_delete_data_content_windows, tui_display_all_data)
2365         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2366         Update.
2367         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2368         * tui/tui-regs.c (tui_last_regs_line_no)
2369         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2370         (tui_show_registers): Update.
2371         (tui_show_register_group): Return void.  Update.
2372         (tui_display_registers_from, tui_display_reg_element_at_line)
2373         (tui_display_registers_from_line, tui_check_register_values):
2374         Update.
2375         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2376         member.
2377         (struct tui_data_window) <regs_content>: Now a std::vector.
2378         <regs_content_count>: Remove.
2379         (tui_add_content_elements, tui_free_data_content): Don't declare.
2380         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2381         (init_content_element): Remove DATA_WIN case.  Add assert.
2382         (tui_add_content_elements): Remove.
2383         (tui_data_window): Update.
2384         (tui_free_data_content): Remove.
2385         (free_content_elements): Remove DATA_WIN case.
2386
2387 2019-06-25  Tom Tromey  <tom@tromey.com>
2388
2389         * tui/tui-data.c (tui_data_item_window): Update.
2390         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2391         * tui/tui-windata.c (tui_display_all_data)
2392         (tui_display_data_from_line): Update.
2393         (tui_check_data_values): Remove.
2394         * tui/tui-regs.c (tui_show_register_group)
2395         (tui_display_reg_element_at_line): Update.
2396         * tui/tui-hooks.c (tui_register_changed)
2397         (tui_refresh_frame_and_register_information): Call
2398         tui_check_register_values.
2399         * tui/tui-data.h (struct tui_data_window) <data_content,
2400         data_content_count, data_type>: Remove.
2401         (enum tui_data_type): Remove.
2402
2403         * tui/tui-data.c (tui_data_window::clear_detail)
2404         (~tui_data_window): Update.
2405
2406 2019-06-25  Tom Tromey  <tom@tromey.com>
2407
2408         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2409         declare.
2410         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2411         Rename from tui_first_data_item_displayed.  Update.
2412         (tui_data_window::refresh_all)
2413         (tui_data_window::do_scroll_vertical): Update.
2414         * tui/tui-data.h (struct tui_data_window)
2415         <first_data_item_displayed>: Declare new method.
2416
2417 2019-06-25  Tom Tromey  <tom@tromey.com>
2418
2419         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2420         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2421         contents...
2422         (tui_initialize_static_data): ...here.
2423
2424 2019-06-25  Tom Tromey  <tom@tromey.com>
2425
2426         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2427         (tui_display_registers_from, tui_check_register_values): Update.
2428         (tui_display_register): Remove win_info parameter; update.
2429         (tui_get_register): Change type of parameters.
2430         * tui/tui-data.h (struct tui_data_element): Remove.
2431         (union tui_which_element) <data>: Remove.
2432         <data_window>: Change type.
2433         (struct tui_data_item_window): New.
2434         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2435         case.  Add assert.
2436         (~tui_data_item_window): New destructor.
2437         (free_content_elements): Remove DATA_ITEM_WIN case.
2438
2439 2019-06-25  Tom Tromey  <tom@tromey.com>
2440
2441         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2442         Remove.
2443
2444 2019-06-25  Tom Tromey  <tom@tromey.com>
2445
2446         * tui/tui-data.h (struct tui_command_element): Remove.
2447         (union tui_which_element) <command>: Remove.
2448         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2449         assert.
2450         (free_content_elements): Remove CMD_WIN case.
2451
2452 2019-06-25  Tom Tromey  <tom@tromey.com>
2453
2454         * tui/tui-layout.c (tui_set_layout): Update.
2455         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2456         * tui/tui-data.c (layout_def): Update.
2457
2458 2019-06-25  Tom Tromey  <tom@tromey.com>
2459
2460         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2461         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2462         (tui_source_window_base::set_new_height): Update.
2463         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2464         Update.
2465         (tui_set_locator_fullname, tui_set_locator_info)
2466         (tui_show_frame_info): Update.
2467         * tui/tui-source.c (tui_set_source_content)
2468         (tui_source_is_displayed): Update.
2469         * tui/tui-layout.c (show_source_disasm_command, show_data)
2470         (show_source_or_disasm_and_command): Update.
2471         * tui/tui-disasm.c (tui_set_disassem_content)
2472         (tui_get_begin_asm_address): Update.
2473         * tui/tui-data.h (struct tui_locator_element): Remove.
2474         (union tui_which_element) <locator>: Remove.
2475         (struct tui_locator_window): New.
2476         (tui_locator_win_info_ptr): Change return type.
2477         * tui/tui-data.c (_locator): Change type.
2478         (tui_locator_win_info_ptr): Change return type.
2479         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2480         (tui_alloc_content): Add assert.
2481
2482 2019-06-25  Tom Tromey  <tom@tromey.com>
2483
2484         * tui/tui-winsource.c
2485         (tui_exec_info_window::maybe_allocate_content): New method.
2486         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2487         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2488         (make_source_or_disasm_window): Add cast.
2489         * tui/tui-data.h (union tui_which_element) <simple_string>:
2490         Remove.
2491         (struct tui_source_info): New.
2492         (struct tui_source_window_base) <execution_info>: Change type.
2493         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2494         case, and add assert.
2495         (tui_alloc_content): Add assert.
2496
2497 2019-06-25  Tom Tromey  <tom@tromey.com>
2498
2499         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2500         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2501         * tui/tui-data.c (tui_alloc_win_info): Remove.
2502
2503 2019-06-25  Tom Tromey  <tom@tromey.com>
2504
2505         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2506         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2507         can_highlight.
2508
2509 2019-06-25  Tom Tromey  <tom@tromey.com>
2510
2511         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2512         make_visible_with_new_height method.
2513         (tui_win_info::make_visible_with_new_height): New method.
2514         (tui_source_window_base::do_make_visible_with_new_height)
2515         (tui_data_window::do_make_visible_with_new_height)
2516         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2517         (make_visible_with_new_height): Remove.
2518         (tui_resize_all, tui_adjust_win_heights): Use
2519         make_visible_with_new_height method.
2520         * tui/tui-data.h (struct tui_win_info)
2521         <do_make_visible_with_new_height, make_visible_with_new_height>:
2522         New methods.
2523         (struct tui_source_window_base, struct tui_data_window)
2524         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2525         methods.
2526
2527 2019-06-25  Tom Tromey  <tom@tromey.com>
2528
2529         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2530         method.
2531         (update_tab_width): Call update_tab_width method.
2532         * tui/tui-data.h (struct tui_win_info)
2533         (struct tui_source_window_base) <update_tab_width>: New methods.
2534
2535 2019-06-25  Tom Tromey  <tom@tromey.com>
2536
2537         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2538         parameter.
2539         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2540         parameter.
2541         (tui_gen_win_info::make_visible): Update.
2542         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2543         parameter.
2544         * tui/tui-data.h (enum tui_box): New enum.
2545         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2546
2547 2019-06-25  Tom Tromey  <tom@tromey.com>
2548
2549         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2550         init_and_make_win for EXEC_INFO_WIN.
2551         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2552         longer inline.
2553         (struct tui_win_info) <~tui_win_info>: Inline.
2554         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2555         Don't declare.
2556         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2557         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2558         Remove.
2559         (tui_initialize_static_data): Update.
2560         (~tui_gen_win_info): Handle more cleanup here.
2561         (~tui_source_window_base): Delete "execution_info".
2562         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2563
2564 2019-06-25  Tom Tromey  <tom@tromey.com>
2565
2566         * tui/tui-layout.c (make_command_window): Don't set
2567         can_highlight.
2568         (show_source_disasm_command): Call the reset method.
2569         (show_data): Don't set can_highlight.  Call the reset method.
2570         (tui_gen_win_info::reset): Rename from init_gen_win_info
2571         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2572         (show_source_or_disasm_and_command): Call the reset method.
2573         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2574         (struct tui_cmd_window): Set can_highlight.
2575
2576 2019-06-25  Tom Tromey  <tom@tromey.com>
2577
2578         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2579         from make_visible.
2580         (tui_make_visible, tui_make_invisible): Rewrite.
2581         (tui_win_info::make_visible): Remove.
2582         (tui_source_window_base::make_visible): Update.
2583         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2584         method.  Moved from...
2585         (struct tui_win_info) <make_visible>: ...here.
2586
2587 2019-06-25  Tom Tromey  <tom@tromey.com>
2588
2589         * tui/tui-winsource.c
2590         (tui_source_window_base::do_scroll_horizontal): Remove direction
2591         parameter.
2592         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2593         direction parameter.
2594         * tui/tui-win.c (tui_win_info::forward_scroll)
2595         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2596         (tui_win_info::right_scroll): Update.
2597         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2598         direction parameter.
2599         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2600         direction parameter.
2601         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2602         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2603         Remove direction parameter.
2604         (struct tui_source_window_base, struct tui_source_window)
2605         (struct tui_disasm_window, struct tui_data_window)
2606         (struct tui_cmd_window): Update.
2607
2608 2019-06-25  Tom Tromey  <tom@tromey.com>
2609
2610         * tui/tui-winsource.h (tui_set_exec_info_content)
2611         (tui_show_exec_info_content, tui_erase_exec_info_content)
2612         (tui_clear_exec_info_content, tui_update_exec_info): Change
2613         argument to tui_source_window_base.
2614         * tui/tui-winsource.c (tui_set_exec_info_content)
2615         (tui_show_exec_info_content, tui_erase_exec_info_content)
2616         (tui_clear_exec_info_content, tui_update_exec_info): Change
2617         argument to tui_source_window_base.
2618
2619 2019-06-25  Tom Tromey  <tom@tromey.com>
2620
2621         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2622         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2623
2624 2019-06-25  Tom Tromey  <tom@tromey.com>
2625
2626         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2627         check.
2628
2629 2019-06-25  Tom Tromey  <tom@tromey.com>
2630
2631         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2632         type to void.
2633         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2634         type to void.
2635         * tui/tui-source.c (tui_set_source_content): Update.
2636         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2637
2638 2019-06-25  Tom Tromey  <tom@tromey.com>
2639
2640         * tui/tui-win.c (window_name_completer, tui_set_focus)
2641         (tui_all_windows_info): Use name method.
2642         * tui/tui-data.h (struct tui_gen_win_info)
2643         (struct tui_source_window, struct tui_disasm_window)
2644         (struct tui_data_window, struct tui_cmd_window) <name>: New
2645         method.
2646         (tui_win_name): Don't declare.
2647         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2648         (tui_win_name): Remove.
2649
2650 2019-06-25  Tom Tromey  <tom@tromey.com>
2651
2652         * tui/tui-winsource.h (tui_update_source_window)
2653         (tui_update_source_window_as_is): Change parameter type.
2654         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2655         to be a tui_source_window_base.
2656         (tui_update_source_window_as_is): Likewise.
2657         * tui/tui-win.c (make_visible_with_new_height): Update.
2658
2659 2019-06-25  Tom Tromey  <tom@tromey.com>
2660
2661         * tui/tui-winsource.c (tui_erase_source_content)
2662         (tui_show_source_content, tui_show_exec_info_content)
2663         (tui_erase_exec_info_content): Use refresh_window method.
2664         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2665         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2666         from tui_refresh_win.
2667         (tui_data_window::refresh_window): New method.
2668         (tui_win_info::refresh, tui_source_window_base::refresh)
2669         (tui_refresh_all): Use refresh_window method.
2670         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2671         method.
2672         * tui/tui-regs.c (tui_display_register): Call refresh_window
2673         method.
2674         * tui/tui-layout.c (show_source_disasm_command)
2675         (show_source_or_disasm_and_command): Call refresh_window method.
2676         * tui/tui-data.h (struct tui_gen_win_info)
2677         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2678         New method.
2679
2680 2019-06-25  Tom Tromey  <tom@tromey.com>
2681
2682         * tui/tui.c (tui_rl_other_window, tui_enable)
2683         (tui_is_window_visible, tui_get_command_dimension): Update.
2684         * tui/tui-winsource.c (tui_update_source_window_as_is)
2685         (tui_clear_source_content, tui_erase_source_content)
2686         (tui_show_source_line, tui_source_window_base::refill)
2687         (tui_source_window_base::do_scroll_horizontal)
2688         (tui_source_window_base::set_is_exec_point_at)
2689         (tui_update_breakpoint_info, tui_set_exec_info_content)
2690         (tui_alloc_source_buffer, tui_line_is_displayed)
2691         (tui_addr_is_displayed): Update.
2692         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2693         (tui_check_and_display_highlight_if_needed)
2694         (tui_win_info::make_visible, tui_win_info::refresh)
2695         (tui_refresh_all): Update.
2696         * tui/tui-windata.c (tui_first_data_item_displayed)
2697         (tui_delete_data_content_windows, tui_erase_data_content)
2698         (tui_display_all_data, tui_data_window::refresh_all)
2699         (tui_check_data_values): Update.
2700         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2701         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2702         (tui_win_info::backward_scroll, tui_refresh_all_win)
2703         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2704         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2705         (tui_source_window_base::set_new_height)
2706         (tui_data_window::set_new_height)
2707         (make_invisible_and_set_new_height)
2708         (make_visible_with_new_height, new_height_ok)
2709         (parse_scrolling_args): Update.
2710         * tui/tui-stack.c (tui_show_frame_info): Update.
2711         * tui/tui-source.c (tui_set_source_content)
2712         (tui_set_source_content_nil, tui_source_is_displayed)
2713         (tui_source_window::do_scroll_vertical): Update.
2714         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2715         (tui_display_registers_from, tui_display_reg_element_at_line)
2716         (tui_check_register_values, tui_reg_command): Update.
2717         * tui/tui-layout.c (tui_default_win_height)
2718         (show_source_disasm_command, show_data, init_and_make_win)
2719         (show_source_or_disasm_and_command): Update.
2720         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2721         (tui_redisplay_readline, tui_mld_flush)
2722         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2723         (tui_getc): Update.
2724         * tui/tui-disasm.c (tui_set_disassem_content)
2725         (tui_disasm_window::do_scroll_vertical): Update.
2726         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2727         Now virtual.
2728         (struct tui_win_info): Derive from tui_gen_win_info.
2729         <~tui_win_info>: Mark as override.
2730         <generic>: Remove member.
2731         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2732         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2733         (~tui_data_window, ~tui_win_info)
2734         (tui_free_all_source_wins_content): Update.
2735         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2736
2737 2019-06-25  Tom Tromey  <tom@tromey.com>
2738
2739         * tui/tui-layout.c (init_and_make_win): Use new.
2740         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2741         destructor, initializers.
2742         (tui_alloc_generic_win_info): Don't declare.
2743         * tui/tui-data.c (_locator): Add argument to constructor.
2744         (source_win, disasm_win): New globals.
2745         (exec_info): Remove.
2746         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2747         Update.
2748         (tui_alloc_generic_win_info): Remove.
2749         (init_content_element): Use new.
2750         (tui_win_info::tui_win_info): Update.
2751         (free_content_elements) <case DATA_WIN>: Use delete.
2752
2753 2019-06-25  Tom Tromey  <tom@tromey.com>
2754
2755         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2756         * tui/tui-windata.c (tui_first_data_item_displayed)
2757         (tui_delete_data_content_windows): Update.
2758         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2759         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2760         (tui_display_registers_from, tui_check_register_values): Update.
2761         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2762         pointer.
2763         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2764         window.
2765         (tui_free_data_content): Update.
2766         (free_content_elements) <case DATA_WIN>: Free the window.
2767
2768 2019-06-25  Tom Tromey  <tom@tromey.com>
2769
2770         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2771         Update.
2772         * tui/tui-layout.c (make_command_window)
2773         (show_source_disasm_command, show_data, init_and_make_win)
2774         (show_source_or_disasm_and_command): Update.
2775         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2776         method.
2777         <can_highight, is_highlighted>: Now bool.
2778         (tui_set_win_highlight): Don't declare.
2779         * tui/tui-data.c (tui_set_win_highlight): Remove.
2780
2781 2019-06-25  Tom Tromey  <tom@tromey.com>
2782
2783         * tui/tui-wingeneral.c (make_visible): Remove check of window
2784         type.
2785
2786 2019-06-25  Tom Tromey  <tom@tromey.com>
2787
2788         * tui/tui-win.c (tui_win_info::max_height)
2789         (tui_cmd_window::max_height): New methods.
2790         (new_height_ok): Call max_height.
2791         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2792         <max_height>: New method.
2793
2794 2019-06-25  Tom Tromey  <tom@tromey.com>
2795
2796         * tui/tui-win.c (tui_source_window_base::set_new_height)
2797         (tui_data_window::set_new_height): New methods.
2798         (make_invisible_and_set_new_height): Call set_new_height method.
2799         * tui/tui-data.h (struct tui_win_info)
2800         (struct tui_source_window_base, struct tui_data_window)
2801         <set_new_height>: New method.
2802
2803 2019-06-25  Tom Tromey  <tom@tromey.com>
2804
2805         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2806         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2807         tui_refresh_data_win.
2808         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2809         method.
2810         (tui_refresh_all_win): Call the refresh_all method.
2811         (tui_set_focus): Likewise.
2812         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2813         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2814         Likewise.
2815
2816 2019-06-25  Tom Tromey  <tom@tromey.com>
2817
2818         * tui/tui-winsource.h (tui_refill_source_window)
2819         (tui_set_is_exec_point_at): Don't declare.
2820         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2821         (tui_source_window_base::refill): Rename from
2822         tui_refill_source_window.
2823         (tui_source_window_base::do_scroll_horizontal): Update.
2824         (tui_source_window_base::set_is_exec_point_at): Rename from
2825         tui_set_is_exec_point_at.
2826         (tui_update_all_breakpoint_info): Update.
2827         * tui/tui-stack.c (tui_show_frame_info): Update.
2828         * tui/tui-layout.c (show_data): Add cast.
2829         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2830         * tui/tui-data.h (struct tui_source_window_base) <refill,
2831         set_is_exec_point_at>: New methods.
2832         (tui_source_windows, tui_add_to_source_windows): Update types.
2833         (tui_add_to_source_windows): Remove redundant declaration.
2834         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2835         (tui_source_windows): Change return type.
2836         (tui_clear_source_windows_detail): Update.
2837         (tui_add_to_source_windows): Change type of parameter.
2838         (tui_free_all_source_wins_content): Update.
2839
2840 2019-06-25  Tom Tromey  <tom@tromey.com>
2841
2842         * tui/tui-wingeneral.c (tui_win_info::refresh)
2843         (tui_source_window_base::refresh): New methods.
2844         (tui_refresh_all): Call the refresh method.
2845         * tui/tui-data.h (struct tui_win_info)
2846         (struct tui_source_window_base) <refresh>: New method.
2847
2848 2019-06-25  Tom Tromey  <tom@tromey.com>
2849
2850         * tui/tui.h (tui_is_window_visible): Return bool.
2851         * tui/tui.c (tui_is_window_visible): Return bool.
2852         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2853         (tui_make_visible, tui_make_invisible)
2854         (tui_win_info::make_visible)
2855         (tui_source_window_base::make_visible, make_all_visible)
2856         (tui_make_all_visible, tui_make_all_invisible): Update.
2857         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2858         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2859         bool.
2860         (struct tui_win_info, struct tui_source_window_base)
2861         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2862         * tui/tui-data.c (tui_init_generic_part): Update.
2863
2864 2019-06-25  Tom Tromey  <tom@tromey.com>
2865
2866         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2867         (tui_source_window_base::make_visible): New methods.
2868         (make_all_visible): Make method call.
2869         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2870         (struct tui_source_window_base, struct tui_cmd_window): Override
2871         make_visible.
2872         (tui_win_is_source_type): Don't declare.
2873         * tui/tui-data.c (tui_win_is_source_type): Remove.
2874
2875 2019-06-25  Tom Tromey  <tom@tromey.com>
2876
2877         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2878         NULL check.
2879
2880 2019-06-25  Tom Tromey  <tom@tromey.com>
2881
2882         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2883         Inline constructor.  Add initializers for members.
2884         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2885         constructors; now inline in class.
2886
2887 2019-06-25  Tom Tromey  <tom@tromey.com>
2888
2889         * tui/tui-regs.c (tui_show_registers): Update.
2890         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2891         bool.
2892         * tui/tui-data.c (tui_data_window::clear_detail)
2893         (tui_data_window): Update.
2894
2895 2019-06-25  Tom Tromey  <tom@tromey.com>
2896
2897         * tui/tui-windata.c (tui_display_all_data)
2898         (tui_display_data_from_line, tui_display_data_from)
2899         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2900         Update.
2901         * tui/tui-regs.c (tui_last_regs_line_no)
2902         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2903         (tui_show_registers, tui_show_register_group)
2904         (tui_display_registers_from, tui_display_reg_element_at_line)
2905         (tui_display_registers_from_line, tui_check_register_values)
2906         (tui_reg_next, tui_reg_prev): Update.
2907         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2908         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2909         tui_data_window.
2910         (struct tui_win_info) <detail>: Remove.  Add new fields from
2911         tui_data_info.
2912         (TUI_DATA_WIN): Add cast.
2913         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2914         (~tui_data_window): Simplify.
2915
2916 2019-06-25  Tom Tromey  <tom@tromey.com>
2917
2918         * tui/tui-layout.c (show_source_disasm_command)
2919         (show_source_or_disasm_and_command): Update.
2920         * tui/tui-io.c (update_cmdwin_start_line)
2921         (tui_redisplay_readline): Update.
2922         * tui/tui-data.h (struct tui_command_info): Remove.
2923         (struct tui_win_info) <detail>: Remove command_info member.
2924         (struct tui_data_window) <start_line>: New member, from
2925         tui_command_info.
2926         (TUI_CMD_WIN): Add casts.
2927
2928 2019-06-25  Tom Tromey  <tom@tromey.com>
2929
2930         * tui/tui-winsource.c (tui_update_source_window)
2931         (tui_refill_source_window)
2932         (tui_source_window_base::do_scroll_horizontal)
2933         (tui_update_breakpoint_info, tui_set_exec_info_content)
2934         (tui_show_exec_info_content, tui_erase_exec_info_content)
2935         (tui_clear_exec_info_content): Update.
2936         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2937         Update.
2938         * tui/tui-win.c (make_invisible_and_set_new_height)
2939         (make_visible_with_new_height): Update.
2940         * tui/tui-source.c (tui_set_source_content)
2941         (tui_show_symtab_source): Update.
2942         * tui/tui-layout.c (extract_display_start_addr)
2943         (show_source_disasm_command, show_data)
2944         (make_source_or_disasm_window)
2945         (show_source_or_disasm_and_command): Update.
2946         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2947         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2948         "gdbarch".
2949         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2950         to tui_source_window_base.
2951         (struct tui_win_info) <detail>: Remove source_info member.
2952         (struct tui_source_window_base) <has_locator>: Inline.
2953         Move contents from tui_source_info; rename has_locator member to
2954         m_has_locator.
2955         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2956         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2957         header file.
2958         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2959         Simplify.
2960         (tui_free_all_source_wins_content): Cast to
2961         tui_source_window_base.
2962
2963 2019-06-25  Tom Tromey  <tom@tromey.com>
2964
2965         * tui/tui-win.c (make_invisible_and_set_new_height)
2966         (make_visible_with_new_height): Call has_locator method.
2967         * tui/tui-layout.c (show_source_disasm_command, show_data)
2968         (show_source_or_disasm_and_command): Update for bool change.
2969         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2970         (tui_win_info) <has_locator>: New method.
2971         (struct tui_source_window_base) <has_locator>: New method.
2972         (tui_win_has_locator): Don't declare.
2973         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2974         from tui_win_has_locator.
2975         (tui_source_window_base): Use false, not FALSE.
2976
2977 2019-06-25  Tom Tromey  <tom@tromey.com>
2978
2979         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2980         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2981         clear_detail method directly.
2982         (tui_clear_win_detail): Remove.
2983
2984 2019-06-25  Tom Tromey  <tom@tromey.com>
2985
2986         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2987         "this", not TUI_DISASM_WIN.
2988
2989 2019-06-25  Tom Tromey  <tom@tromey.com>
2990
2991         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2992         declare.
2993         * tui/tui-winsource.c
2994         (tui_source_window_base::do_scroll_horizontal): Rename from
2995         tui_horizontal_source_scroll.
2996         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2997         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2998         from tui_vertical_data_scroll.
2999         * tui/tui-win.h (tui_scroll): Don't declare.
3000         * tui/tui-win.c (tui_win_info::forward_scroll)
3001         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3002         (tui_win_info::right_scroll): Rename and update.
3003         (tui_scroll_forward_command, tui_scroll_backward_command)
3004         (tui_scroll_left_command, tui_scroll_right_command): Update.
3005         (tui_scroll): Remove.
3006         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3007         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3008         from tui_vertical_source_scroll.
3009         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3010         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3011         from tui_vertical_disassem_scroll.
3012         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3013         do_scroll_horizontal>: New methods.
3014         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3015         Likewise.
3016         (struct tui_source_window_base): Add do_scroll_horizontal.
3017         (struct tui_source_window, struct tui_disasm_window): Add
3018         do_scroll_vertical.
3019         (struct tui_data_window, struct tui_cmd_window): Add
3020         do_scroll_horizontal and do_scroll_vertical.
3021         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3022
3023 2019-06-25  Tom Tromey  <tom@tromey.com>
3024
3025         * tui/tui-data.h (struct tui_source_window_base): New struct.
3026         (struct tui_source_window): Derive from tui_source_window_base.
3027         (struct tui_disasm_window): New struct.
3028         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3029         from tui_source_window::clear_detail.
3030         (tui_source_window_base): Rename from tui_source_window.
3031         (~tui_source_window_base): Rename from ~tui_source_window.
3032         (tui_alloc_win_info): Create a tui_disasm_window.
3033
3034 2019-06-25  Tom Tromey  <tom@tromey.com>
3035
3036         * tui/tui-data.h (struct tui_source_window)
3037         (struct tui_data_window): Declare destructors.
3038         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3039         destructors.
3040         (tui_win_info): Simplify.
3041
3042 2019-06-25  Tom Tromey  <tom@tromey.com>
3043
3044         * tui/tui-winsource.c (tui_display_main)
3045         (tui_update_source_windows_with_addr)
3046         (tui_update_all_breakpoint_info): Update.
3047         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3048         (new_height_ok, parse_scrolling_args): Update.
3049         * tui/tui-stack.c (tui_show_frame_info): Update.
3050         * tui/tui-data.h (struct tui_list): Remove.
3051         (tui_source_windows): Return a reference to a std::vector.
3052         * tui/tui-data.c (source_windows): Now a std::vector.
3053         (tui_source_windows): Change return type.
3054         (tui_clear_source_windows): Rewrite.
3055         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3056         (tui_free_all_source_wins_content): Rewrite.
3057
3058 2019-06-25  Tom Tromey  <tom@tromey.com>
3059
3060         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3061         (struct tui_data_window, struct tui_cmd_window): Declare
3062         clear_detail method.
3063         * tui/tui-data.c (tui_source_window::clear_detail)
3064         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3065         methods.
3066         (tui_clear_win_detail): Simplify.
3067
3068 2019-06-25  Tom Tromey  <tom@tromey.com>
3069
3070         * tui/tui-layout.c (make_source_window, make_disasm_window)
3071         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3072         Return the new window.
3073         (show_source_disasm_command, show_data)
3074         (show_source_or_disasm_and_command): Update.
3075
3076 2019-06-25  Tom Tromey  <tom@tromey.com>
3077
3078         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3079         parameter.  Return the new window.
3080         (show_source_disasm_command): Update and remove NULL check.
3081         (show_source_or_disasm_and_command): Update.
3082
3083 2019-06-25  Tom Tromey  <tom@tromey.com>
3084
3085         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3086
3087 2019-06-25  Tom Tromey  <tom@tromey.com>
3088
3089         * tui/tui-data.h (struct tui_win_info): Make constructor
3090         protected.  Make destructor virtual.  Add initializers.
3091         (tui_source_window, tui_data_window, tui_cmd_window): New
3092         classes.
3093         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3094         constructor.  Add "type" parameter.
3095         (tui_source_window, tui_data_window, tui_cmd_window): New
3096         constructors.
3097         (tui_alloc_win_info): Instantiate the appropriate subclass.
3098
3099 2019-06-25  Tom Tromey  <tom@tromey.com>
3100
3101         * tui/tui-win.c (tui_resize_all): Use delete.
3102         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3103         destructor.
3104         (tui_free_window): Don't declare.
3105         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3106         Update.
3107
3108 2019-06-25  Tom Tromey  <tom@tromey.com>
3109
3110         * tui/tui-data.h (struct tui_win_info): Add constructor.
3111         * tui/tui-data.c (tui_alloc_win_info): Use new.
3112         (tui_free_window): Use delete.
3113
3114 2019-06-22  Tom Tromey  <tom@tromey.com>
3115
3116         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3117         declare.
3118         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3119
3120 2019-06-22  Tom Tromey  <tom@tromey.com>
3121
3122         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3123         declare.
3124         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3125
3126 2019-06-22  Tom de Vries  <tdevries@suse.de>
3127
3128         * dwarf2read.c (create_addrmap_from_aranges)
3129         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3130         instead of '%zu'.
3131
3132 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3133
3134         * dwarf2read.h (dwarf2_section_info_def): Remove.
3135         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3136         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3137         std::vector<dwarf2_section_info>.
3138         (struct dwo_file) <~dwo_file>: Remove.
3139         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3140         types field.
3141         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3142         (dwarf2_read_debug_names): Likewise.
3143         (create_debug_types_hash_table): Change parameter type to
3144         array_view, adjust code accordingly.
3145         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3146         (partial_die_info::fixup): Likewise.
3147         (determine_prefix): Likewise.
3148         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3149
3150 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3151
3152         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3153         gdb_bfd_ref_ptr.
3154         <~dwo_file>: Remove call to gdb_bfd_unref.
3155         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3156         gdb_bfd_ref_ptr::get.
3157
3158 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3159
3160         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3161         type to htab_up.
3162         * dwarf2read.c (struct dwo_file): Initialize fields.
3163         <~dwo_file>: New.
3164         (free_dwo_file): Remove, move content to ~dwo_file.
3165         (struct dwo_file_deleter): Remove.
3166         (dwo_file_up>: Remove custom deleter.
3167         (free_dwo_files): Remove.
3168         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3169         dwo_files.
3170         (process_skeletonless_type_units): Call unique_ptr::get.
3171         (allocate_dwo_file_hash_table): Add deleter to created hash
3172         table.  Change return type to htab_up.
3173         (lookup_dwo_file_slot): Don't memset dwo_file, call
3174         unique_ptr::get.
3175         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3176         (create_dwo_unit_in_dwp_v2): Likewise.
3177         (open_and_init_dwo_file): Likewise.
3178         (free_dwo_file_from_slot): Remove.
3179
3180 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3181
3182         * dwarf2read.h (struct dwarf2_section_info) <readin,
3183         is_virtual>: Change type to bool.
3184         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3185         true instead of 1.
3186
3187 2019-06-19  Tom Tromey  <tom@tromey.com>
3188
3189         * tui/tui-data.h (tui_init_content_element): Don't declare.
3190
3191 2019-06-19  Tom Tromey  <tom@tromey.com>
3192
3193         * tui/tui-data.h (tui_init_win_info): Don't declare.
3194
3195 2019-06-19  Tom de Vries  <tdevries@suse.de>
3196
3197         * dwarf2read.h (abstract_to_concrete): Change type to
3198         std::unordered_map<sect_offset, std::vector<sect_offset>,
3199         gdb::hash_enum<sect_offset>>.
3200
3201 2019-06-19  Tom Tromey  <tromey@adacore.com>
3202
3203         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3204         EVAL_AVOID_SIDE_EFFECTS specially.
3205
3206 2019-06-19  Tom Tromey  <tromey@adacore.com>
3207
3208         * source-cache.c (highlighter): New global.
3209         (source_cache::get_source_lines): Create a highlighter on demand.
3210
3211 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3212
3213         * defs.h (deprecated_interactive_hook): Delete declaration.
3214         * interps.c (clear_interpreter_hooks): Remove use of
3215         deprecated_interactive_hook.
3216         * top.c (deprecated_interactive_hook): Delete definition.
3217         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3218
3219 2019-06-18  Tom de Vries  <tdevries@suse.de>
3220
3221         PR gdb/24515
3222         * dwarf2read.h (abstract_to_concrete): Change type from
3223         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3224         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3225         * dwarf2read.c (read_variable): Update.
3226         (dwarf2_fetch_die_loc_sect_off): Update.
3227
3228 2019-06-17  Tom de Vries  <tdevries@suse.de>
3229
3230         PR gdb/24617
3231         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3232         accessing parent[parent_len - 1].
3233
3234 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3235
3236         PR gdb/24364
3237         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3238         call dtrace_process_dof with NULL dof.
3239
3240 2019-06-16  Tom de Vries  <tdevries@suse.de>
3241
3242         PR gdb/24445
3243         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3244
3245 2019-06-16  Tom Tromey  <tom@tromey.com>
3246
3247         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3248         (make_all_visible): Use address of member.
3249
3250 2019-06-16  Tom Tromey  <tom@tromey.com>
3251
3252         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3253         (tui_free_window, free_content, free_content_elements): Remove
3254         unnecessary cast.
3255         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3256         cast.
3257         * tui/tui-regs.c (tui_show_register_group)
3258         (tui_display_registers_from, tui_display_reg_element_at_line):
3259         Remove unnecessary cast.
3260
3261 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3262
3263         * linux-nat.c (normal_mask): Delete.
3264         (_initialize_linux_nat): Don't initialise normal_mask.
3265
3266 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3267
3268         PR gdb/24445
3269         * dwarf-index-write.h (write_psymtabs_to_index): Add
3270         dwz_basename parameter.
3271         * dwarf-index-write.c (write_gdbindex): Move file writing to
3272         write_gdbindex_1.  Change return type void.
3273         (assert_file_size): Move up, remove filename parameter.
3274         (write_gdbindex_1): New function.
3275         (write_debug_names): Change return type to void, call
3276         assert_file_size.
3277         (struct index_wip_file): New struct.
3278         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3279         file logic to index_wip_file.  Write index for dwz file if
3280         needed.
3281         (save_gdb_index_command): Pass basename of dwz file, if present.
3282         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3283         build-id of dwz file, if present.
3284         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3285         (dwarf2_get_dwz_file): Likewise.
3286         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3287         (dwarf2_get_dwz_file): Likewise.
3288
3289 2019-06-16  Tom Tromey  <tom@tromey.com>
3290
3291         * coffread.c (process_coff_symbol): Use xstrdup.
3292         * value.c (create_internalvar): Use xstrdup.
3293
3294 2019-06-16  Tom Tromey  <tom@tromey.com>
3295
3296         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3297         * breakpoint.c (stopin_command, stopat_command)
3298         (until_break_command, decode_location_default): Remove unnecessary
3299         cast.
3300         * utils.c (subset_compare): Remove unnecessary cast.
3301         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3302         cast.
3303         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3304         cast.
3305         * infcmd.c (path_command): Remove unnecessary cast.
3306         * coffread.c (decode_type): Remove unnecessary cast.
3307         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3308         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3309         * tui/tui-stack.c (tui_show_locator_content)
3310         (tui_show_frame_info): Remove unnecessary cast.
3311         * tui/tui-win.c (tui_scroll_forward_command)
3312         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3313         (parse_scrolling_args): Remove unnecessary cast.
3314         * tui/tui-data.c (init_win_info, tui_del_window)
3315         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3316         (free_content_elements): Remove unnecessary cast.
3317         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3318         unnecessary cast.
3319         * tui/tui-source.c (tui_set_source_content)
3320         (tui_vertical_source_scroll): Remove unnecessary cast.
3321         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3322         cast.
3323         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3324         * tui/tui-regs.c (tui_display_registers_from)
3325         (tui_display_register): Remove unnecessary cast.
3326         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3327         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3328         (make_visible): Remove unnecessary cast.
3329         * tui/tui-winsource.c (tui_erase_source_content)
3330         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3331         unnecessary cast.
3332         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3333         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3334         * stabsread.c (read_type, read_array_type, read_range_type):
3335         Remove unnecessary cast.
3336         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3337         (parse_symbol, parse_type, upgrade_type, parse_external)
3338         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3339         unnecessary cast.
3340         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3341
3342 2019-06-16  Tom Tromey  <tom@tromey.com>
3343
3344         * tui/tui-data.c (tui_alloc_generic_win_info)
3345         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3346         checks.
3347
3348 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3349             Andrew Burgess  <andrew.burgess@embecosm.com>
3350
3351         * f-typeprint.c (f_print_type): Don't return early for not
3352         associated or not allocated types.
3353         (f_type_print_varspec_suffix): Add print_rank parameter and print
3354         ranks of array types in case they dangling.
3355         (f_type_print_base): Add print_rank parameter.
3356
3357 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3358
3359         * NEWS: Mention new MI commands.
3360         * break-catch-throw.c (enum exception_event_kind): Move to
3361         breakpoint.h.
3362         (print_mention_exception_catchpoint): Output text as a single
3363         message.
3364         (catch_exception_command_1): Rename to...
3365         (catch_exception_event): ...this, make non-static, update header
3366         command, and change some parameter types.
3367         (catch_catch_command): Update for changes to
3368         catch_exception_command_1.
3369         (catch_throw_command): Likewise.
3370         (catch_rethrow_command): Likewise.
3371         * breakpoint.c (enum exception_event_kind): Delete.
3372         * breakpoint.h (enum exception_event_kind): Moved here from
3373         break-catch-throw.c.
3374         (catch_exception_event): Declare.
3375         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3376         (mi_cmd_catch_throw): New function.
3377         (mi_cmd_catch_rethrow): New function.
3378         (mi_cmd_catch_catch): New function.
3379         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3380         'catch-catch' entries.
3381         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3382         (mi_cmd_catch_rethrow): Declare.
3383         (mi_cmd_catch_catch): Declare.
3384
3385 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3386
3387         * annotate.c (annotate_source_line): Change return type to void,
3388         update implementation to match.
3389         * annotate.h (annotate_source_line): Change return type to void,
3390         update header comment.
3391         * stack.c (print_frame_info): Don't change what frame information
3392         is printed based on whether annotations are on or not.
3393
3394 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3395
3396         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3397         (annotate_source): Make static.
3398         (annotate_source_line): Moved from source.c and renamed from
3399         identify_source_line.  Update the return type.
3400         * annotate.h (annotate_source): Delete declaration.
3401         (annotate_source_line): Declaration moved from source.h, and
3402         renamed from identify_source_line.  Return type updated.
3403         * source.c (identify_source_line): Moved to annotate.c and renamed
3404         to annotate_source_line.
3405         (info_line_command): Remove check of annotation_level.
3406         * source.h (identify_source_line): Move declaration to annotate.h
3407         and rename to annotate_source_line.
3408         * stack.c: Add 'annotate.h' include.
3409         (print_frame_info): Remove check of annotation_level before
3410         calling annotate_source_line.
3411
3412 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3413
3414         * source-cache.c (source_cache::get_plain_source_lines): Use
3415         open_source_file_with_line_charpos instead of just
3416         open_source_file, remove call to find_source_lines.
3417         (source_cache::get_source_lines): Likewise.
3418         * source.c (find_source_lines): Make static.
3419         (get_filename_and_charpos): Renamed into...
3420         (open_source_file_with_line_charpos): ..this along with changes to
3421         return a scoped_fd, and some other minor clean ups.
3422         (identify_source_line): Use open_source_file_with_line_charpos.
3423         (search_command_helper): Use open_source_file_with_line_charpos
3424         instead of just open_source_file, remove call to
3425         find_source_lines.
3426         * source.h (open_source_file_with_line_charpos): Declare new
3427         function.
3428         (find_source_lines): Delete declaration.
3429
3430 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3431
3432         * source.c (get_filename_and_charpos): Remove fullname
3433         parameter.
3434         (identify_source_line): Update call to get_filename_and_charpos.
3435
3436 2019-06-14  Tom Tromey  <tromey@adacore.com>
3437
3438         PR gdb/24502:
3439         * ui-style.h (skip_ansi_escape): Update comment.
3440         * ui-file.h (class no_terminal_escape_file): New class.
3441         * ui-file.c (no_terminal_escape_file::write)
3442         (no_terminal_escape_file::puts): New methods.
3443         * cli/cli-logging.c (handle_redirections): Use
3444         no_terminal_escape_file.
3445
3446 2019-06-14  Tom Tromey  <tromey@adacore.com>
3447
3448         * NEWS: Move convenience variable news above Python news.
3449
3450 2019-06-14  Tom Tromey  <tom@tromey.com>
3451
3452         * gnulib: Move directory to top-level.
3453         * configure.ac: Don't configure gnulib.
3454         * configure: Rebuild.
3455         * common/common-defs.h: Use new path to gnulib.
3456         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3457         (GNULIB_H): Remove.
3458         (INCGNU): Look in new gnulib location.
3459         (HFILES_NO_SRCDIR): Remove gnulib files.
3460         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3461         (generated_files): Remove GNULIB_H.
3462         ($(LIBGNU), all-lib): Remove targets.
3463         (distclean): Don't mention GNULIB_BUILDDIR.
3464         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3465
3466 2019-06-14  Tom Tromey  <tromey@adacore.com>
3467
3468         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3469         Warn if symbol file does not provide any symbols.
3470
3471 2019-06-14  Tom Tromey  <tromey@adacore.com>
3472
3473         * source.c (find_and_open_source): Respect basenames_may_differ.
3474
3475 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3476
3477         * annotate.c (annotate_breakpoints_invalid): Make use of
3478         scoped_restore_terminal_state.
3479         (annotate_frames_invalid): Likewise.
3480
3481 2019-06-14  Tom Tromey  <tromey@adacore.com>
3482
3483         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3484         allow assignment to an internalvar.
3485
3486 2019-06-14  Tom Tromey  <tromey@adacore.com>
3487
3488         * ada-lex.l: Allow "_" in attribute names.
3489
3490 2019-06-14  Tom Tromey  <tromey@adacore.com>
3491
3492         PR gdb/24653:
3493         * regcache.c (registers_changed): Don't call alloca.
3494         * top.c (execute_command): Don't call alloca.
3495
3496 2019-06-13  Pedro Alves  <palves@redhat.com>
3497
3498         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3499         'expression'.  When parsing an expression, error out if there's
3500         junk after "unlimited".
3501         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3502         (do_set_command): Adjust calls to is_unlimited_literal.
3503
3504 2019-06-13  Pedro Alves  <palves@redhat.com>
3505
3506         * compile/compile.c (make_compile_options_def_group): Add braces
3507         around array_view initializer.
3508         * thread.c (make_thread_apply_all_options_def_group)
3509         (make_thread_apply_all_options_def_group): Likewise.
3510
3511 2019-06-13  Pedro Alves  <palves@redhat.com>
3512
3513         * NEWS (New commands): Mention "maint test-options
3514         require-delimiter", "maint test-options unknown-is-error", "maint
3515         test-options unknown-is-operand" and "maint show
3516         test-options-completion-result".
3517         (New command options, command completion): New section.
3518         (Completion improvements): New section.
3519         Mention that you can abbreviate "unlimited".
3520
3521 2019-06-13  Pedro Alves  <palves@redhat.com>
3522
3523         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3524         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3525         * unittests/cli-utils-selftests.c (test_parse_flags)
3526         (test_parse_flags_qcs): Delete.
3527         (test_cli_utils): Don't call deleted functions.
3528
3529 2019-06-13  Pedro Alves  <palves@redhat.com>
3530
3531         * thread.c: Include "cli/cli-option.h".
3532         (tp_array_compar_ascending): Global.
3533         (tp_array_compar): Delete function.
3534         (tp_array_compar_ascending, tp_array_compar_descending): New
3535         functions.
3536         (ascending_option_def, qcs_flag_option_def)
3537         (thr_qcs_flags_option_defs)
3538         (make_thread_apply_all_options_def_group)
3539         (make_thread_apply_options_def_group): New.
3540         (thread_apply_all_command): Use gdb::option::process_options.
3541         (thread_apply_command_completer)
3542         (thread_apply_all_command_completer): New.
3543         (thread_apply_command): Use gdb::option::process_options.
3544         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3545         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3546         to generate help text of "thread apply".  Adjust "taas"'s help.
3547         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3548         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3549
3550 2019-06-13  Pedro Alves  <palves@redhat.com>
3551
3552         * thread.c (thread_apply_command): Check for invalid TID with
3553         isdigit instead of !isalpha.
3554
3555 2019-06-13  Pedro Alves  <palves@redhat.com>
3556
3557         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3558         (validate_flags_qcs): New.
3559         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3560         (validate_flags_qcs): Declare.
3561         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3562         (make_frame_apply_options_def_group): New.
3563         (frame_apply_command_count): Process options with
3564         gdb::option::process_options.
3565         (frame_apply_completer): New.
3566         (frame_apply_level_completer, frame_apply_all_completer)
3567         (frame_apply_completer): New.
3568         (_initialize_stack): Update help of "frame apply", "frame apply
3569         level", "frame apply all" and "faas" to mention supported options
3570         and install command completers.
3571         * stack.h (frame_apply_all_completer): Declare.
3572         * thread.c: Include "stack.h".
3573         (tfaas_command): Add "--".
3574         (_initialize_thread): Update help "tfaas" to mention supported
3575         options and install command completer.
3576
3577 2019-06-13  Pedro Alves  <palves@redhat.com>
3578
3579         * completer.c (complete_nested_command_line): New.
3580         (gdb_completion_word_break_characters_throw): Add assertion.
3581         * completer.h (complete_nested_command_line): Declare.
3582
3583 2019-06-13  Pedro Alves  <palves@redhat.com>
3584
3585         * stack.c (parse_backtrace_qualifiers): New.
3586         (backtrace_command): Use it.
3587         (backtrace_command_completer): Complete on qualifiers.
3588
3589 2019-06-13  Pedro Alves  <palves@redhat.com>
3590
3591         * frame.c: Include "cli/cli-option.h.
3592         (user_set_backtrace_options): New.
3593         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3594         Delete.
3595         (get_prev_frame): Adjust.
3596         (boolean_option_def, uinteger_option_def)
3597         (set_backtrace_option_defs): New.
3598         (_initialize_frame): Adjust and use
3599         gdb::option::add_setshow_cmds_for_options to install "set
3600         backtrace past-main" and "set backtrace past-entry".
3601         * frame.h: Include "cli/cli-option.h".
3602         (struct frame_print_options): Forward declare.
3603         (print_frame_arguments_all, print_frame_arguments_scalars)
3604         (print_frame_arguments_none): Declare.
3605         (print_entry_values): Delete declaration.
3606         (struct frame_print_options, user_frame_print_options): New.
3607         (struct set_backtrace_options): New.
3608         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3609         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3610         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3611         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3612         (list_args_or_locals): Add frame_print_options parameter.
3613         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3614         * python/py-framefilter.c (enumerate_args): Pass down
3615         USER_FRAME_PRINT_OPTIONS.
3616         * stack.c: Include "cli/cli-option.h".
3617         (print_frame_arguments_all, print_frame_arguments_scalars)
3618         (print_frame_arguments_none): Declare.
3619         (print_raw_frame_arguments, print_entry_values): Delete.
3620         (user_frame_print_options): New.
3621         (boolean_option_def, enum_option_def, frame_print_option_defs):
3622         New.
3623         (struct backtrace_cmd_options): New.
3624         (bt_flag_option_def): New.
3625         (backtrace_command_option_defs): New.
3626         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3627         (print_frame_arg, read_frame_arg, print_frame_args)
3628         (print_frame_info, print_frame): Add frame_print_options parameter
3629         and use it.
3630         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3631         (backtrace_command_1): Add frame_print_options and
3632         backtrace_cmd_options parameters and use them.
3633         (make_backtrace_options_def_group): New.
3634         (backtrace_command): Process command options with
3635         gdb::option::process_options.
3636         (backtrace_command_completer): New.
3637         (_initialize_stack): Extend "backtrace"'s help to mention
3638         supported options.  Install completer for "backtrace".
3639         Install some settings commands with add_setshow_cmds_for_options.
3640
3641 2019-06-13  Pedro Alves  <palves@redhat.com>
3642
3643         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3644         and that "set/show print raw frame-arguments" are now deprecated.
3645
3646         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3647         command.
3648         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3649         * stack.c (_initialize_stack): Install "set/show print
3650         raw-frame-arguments", and deprecate "set/show print raw
3651         frame-arguments".
3652         * valprint.c (_initialize_valprint): Deprecate "set/show print
3653         raw".
3654
3655 2019-06-13  Pedro Alves  <palves@redhat.com>
3656
3657         * compile/compile.c (struct compile_options): New.
3658         (compile_flag_option_def, compile_command_option_defs)
3659         (make_compile_options_def_group): New.
3660         (compile_file_command): Handle options with
3661         gdb::option::process_options.
3662         (compile_file_command_completer): New function.
3663         (compile_code_command): Handle options with
3664         gdb::option::process_options.
3665         (compile_code_command_completer): New function.
3666         (_initialize_compiler): Install completers for "compile code" and
3667         "compile file".  Mention available options in "compile code" and
3668         "compile code"'s help.
3669         * completer.c (advance_to_completion_word): New, factored out from
3670         ...
3671         (advance_to_expression_complete_word_point): ... this.
3672         (advance_to_filename_complete_word_point): New.
3673         * completer.h (advance_to_filename_complete_word_point): New
3674         declaration.
3675
3676 2019-06-13  Pedro Alves  <palves@redhat.com>
3677
3678         * compile/compile.c: Include "cli/cli-option.h".
3679         (compile_print_value): Scope data pointer is now a
3680         value_print_options pointer; adjust.
3681         (compile_print_command): Process options.  Scope data pointer is
3682         now a value_print_options pointer; adjust.
3683         (_initialize_compile): Update "compile print"'s help to include
3684         supported options.  Install a completer for "compile print".
3685         * cp-valprint.c (show_vtblprint, show_objectprint)
3686         (show_static_field_print): Delete.
3687         (_initialize_cp_valprint): Don't install "set print
3688         static-members", "set print vtbl", "set print object" here.
3689         * printcmd.c: Include "cli/cli-option.h" and
3690         "common/gdb_optional.h".
3691         (print_command_parse_format): Rework to fill in a
3692         value_print_options instead of a format_data.
3693         (print_value): Change parameter type from format_data pointer to
3694         value_print_options reference.  Adjust.
3695         (print_command_1): Process options.  Adjust to pass down a
3696         value_print_options.
3697         (print_command_completer): New.
3698         (_initialize_printcmd): Install print_command_completer as
3699         handle_brkchars completer for the "print" command.  Update
3700         "print"'s help to include supported options.
3701         * valprint.c: Include "cli/cli-option.h".
3702         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3703         here from cp-valprint.c.
3704         (boolean_option_def, uinteger_option_def)
3705         (value_print_option_defs, make_value_print_options_def_group):
3706         New.  Use gdb::option::add_setshow_cmds_for_options to install
3707         "set print elements", "set print null-stop", "set print repeats",
3708         "set print pretty", "set print union", "set print array", "set
3709         print address", "set print symbol", "set print array-indexes".
3710         * valprint.h: Include <string> and "cli/cli-option.h".
3711         (make_value_print_options_def_group): Declare.
3712         (print_value): Change parameter type from format_data pointer to
3713         value_print_options reference.
3714         (print_command_completer): Declare.
3715
3716 2019-06-13  Pedro Alves  <palves@redhat.com>
3717
3718         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3719         (COMMON_SFILES): Add maint-test-settings.c.
3720         * cli/cli-decode.c (boolean_enums): New global, factored out from
3721         ...
3722         (add_setshow_boolean_cmd): ... here.
3723         * cli/cli-decode.h (boolean_enums): Declare.
3724         * cli/cli-option.c: New file.
3725         * cli/cli-option.h: New file.
3726         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3727         factored out from ...
3728         (parse_cli_boolean_value(const char *)): ... this.
3729         (is_unlimited_literal): Change parameter type to pointer to
3730         pointer.  Adjust and advance ARG pointer.
3731         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3732         (parse_cli_var_enum): New, factored out from ...
3733         (do_set_command): ... this.  Adjust.
3734         * cli/cli-setshow.h (parse_cli_boolean_value)
3735         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3736         (parse_cli_var_enum): Declare.
3737         * cli/cli-utils.c: Include "cli/cli-option.h".
3738         (get_ulongest): New.
3739         * cli/cli-utils.h (get_ulongest): Declare.
3740         (check_for_argument): New overloads.
3741         * maint-test-options.c: New file.
3742
3743 2019-06-13  Pedro Alves  <palves@redhat.com>
3744
3745         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3746         parse a range if "-" is at the end of the string.
3747
3748 2019-06-13  Pedro Alves  <palves@redhat.com>
3749
3750         * cli/cli-setshow.c (parse_auto_binary_operation)
3751         (parse_cli_boolean_value): Don't allow "o".
3752
3753 2019-06-13  Pedro Alves  <palves@redhat.com>
3754
3755         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3756         * NEWS: Mention maint test-settings KIND.
3757         * maint-test-settings.c: New file.
3758
3759 2019-06-13  Pedro Alves  <palves@redhat.com>
3760
3761         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3762         completer.
3763         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3764         "set" completers.
3765
3766 2019-06-13  Pedro Alves  <palves@redhat.com>
3767
3768         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3769         after item.
3770
3771 2019-06-13  Pedro Alves  <palves@redhat.com>
3772
3773         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3774
3775 2019-06-13  Pedro Alves <palves@redhat.com>
3776
3777         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3778         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3779         call.
3780         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3781         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3782         calls.
3783         (check_for_argument): Skip spaces after argument.
3784
3785 2019-06-13  Pedro Alves  <palves@redhat.com>
3786
3787         * thread.c (thread_apply_command): Adjust TID parsing.
3788         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3789         detected before end of string.
3790         (tid_is_in_list): Error out if LIST is invalid.
3791
3792 2019-06-13  Pedro Alves  <palves@redhat.com>
3793
3794         * completer.c (complete_line_internal_1): Rewind completion word
3795         point.
3796         (completion_tracker::advance_custom_word_point_by): Change
3797         parameter type to int.
3798         * completer.h (completion_tracker::advance_custom_word_point_by):
3799         Likewise.
3800
3801 2019-06-13  Pedro Alves  <palves@redhat.com>
3802
3803         * completer.c (advance_to_completion_word): Handle delimiters.
3804
3805 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3806
3807         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3808
3809 2019-06-11  Tom Tromey  <tom@tromey.com>
3810
3811         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3812         (xmalloc_failed): Move to alloc.c.
3813         * alloc.c: New file.
3814         * Makefile.in (COMMON_SFILES): Add alloc.c.
3815
3816 2019-06-11  Tom Tromey  <tom@tromey.com>
3817
3818         * nat/linux-waitpid.c: Don't include server.h.
3819         (linux_debug): Remove.
3820         (my_waitpid): Update.
3821
3822 2019-06-11  Tom Tromey  <tromey@adacore.com>
3823
3824         * infcall.c (_initialize_infcall): Remove trailing newline from
3825         help.
3826         * user-regs.c (_initialize_user_regs): Remove trailing newline
3827         from help.
3828         * typeprint.c (_initialize_typeprint): Remove trailing newline
3829         from help.
3830         * reverse.c (_initialize_reverse): Remove trailing newlines from
3831         help.
3832         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3833         from help.
3834         * language.c (add_set_language_command): Remove trailing newline
3835         from help.
3836         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3837         help.
3838         * disasm.c (_initialize_disasm): Remove trailing newline from
3839         help.
3840         * top.c (init_main): Remove trailing newline from help.
3841         * interps.c (_initialize_interpreter): Remove trailing newline
3842         from help.
3843         * btrace.c (_initialize_btrace): Remove trailing newlines from
3844         help.
3845         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3846         from help.
3847         * python/python.c (_initialize_python): Remove trailing newline
3848         from help.
3849         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3850         help.
3851         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3852         from help.  Reformat some text.
3853         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3854         from help.
3855         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3856         newline from help.
3857
3858 2019-06-11  Tom Tromey  <tromey@adacore.com>
3859
3860         * darwin-nat.c (darwin_decode_exception_message)
3861         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3862
3863 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3864
3865         * valops.c (value_slice): Check for not allocated or not
3866         associated values.
3867
3868 2019-06-10  Tom de Vries  <tdevries@suse.de>
3869
3870         PR gdb/24618
3871         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3872         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3873         invalid.
3874
3875 2019-06-10  Tom de Vries  <tdevries@suse.de>
3876
3877         PR gdb/24611
3878         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3879         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3880
3881 2019-06-10  Tom de Vries  <tdevries@suse.de>
3882
3883         PR symtab/24545
3884         * symtab.c (struct demangled_name_entry): Add language field.
3885         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3886         static minimal symbol".  Set and use language field.
3887
3888 2019-06-10  Tom Tromey  <tromey@adacore.com>
3889
3890         * ada-lang.c (_initialize_ada_language): Update help text.
3891
3892 2019-06-10  Tom Tromey  <tromey@adacore.com>
3893
3894         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3895         with a newline.
3896         * guile/guile.c (handle_boot_error): Don't end warning with a
3897         newline.
3898         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3899         warning with a newline.
3900         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3901         newline.
3902         (s12z_frame_cache): Likewise.
3903         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3904         a newline.
3905         * solib-svr4.c (disable_probes_interface): Don't end warning with
3906         a newline.
3907         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3908         newline.
3909         * python/python.c (do_finish_initialization): Don't end warning
3910         with a newline.
3911
3912 2019-06-10  Tom Tromey  <tom@tromey.com>
3913
3914         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3915         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3916         gdbpy_enter.
3917
3918 2019-06-10  Tom Tromey  <tromey@adacore.com>
3919
3920         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3921         data.
3922         (elf_new_init): Don't call stabsread_new_init.
3923         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3924         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3925         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3926
3927 2019-06-10  Tom de Vries  <tdevries@suse.de>
3928
3929         PR symtab/16264
3930         PR symtab/24517
3931         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3932
3933 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3934
3935         * source.c (find_and_open_source): Also rewrite relative file
3936         names.
3937
3938 2019-04-26  Amos Bird  <amosbird@gmail.com>
3939
3940         * annotate.c (annotate_thread_exited): Add "thread-exited"
3941         annotation.
3942
3943 2019-06-06  Tom Tromey  <tromey@adacore.com>
3944
3945         * maint.h (class scoped_command_stats): Use
3946         DISABLE_COPY_AND_ASSIGN.
3947         <print_time>: New method.
3948         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3949         print_time.
3950         (scoped_command_stats::print_time): New method.
3951
3952 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3953
3954         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3955         instructions of lengths 6 or 8 bytes.
3956
3957 2019-06-04  Pedro Alves  <palves@redhat.com>
3958
3959         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3960
3961         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3962         * breakpoint.c (condition_completer): Likewise.
3963         * cli/cli-dump.c (scan_expression): Likewise.
3964         * common/filestuff.c (mkdir_recursive): Likewise.
3965         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3966         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3967         (gdb_abspath): Likewise.
3968         * compile/compile-cplus-types.c
3969         (compile_cplus_instance::decl_name): Likewise.
3970         * completer.c (complete_explicit_location):
3971         (signal_completer, reg_or_group_completer_1): Likewise.
3972         * cp-support.c (cp_remove_params_if_any): Likewise.
3973         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3974         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3975         * infcmd.c (strip_bg_char): Likewise.
3976         * linespec.c (copy_token_string): Likewise.
3977         * mi/mi-main.c (output_cores): Likewise.
3978         * psymtab.c (psymtab_search_name):
3979         * symfile.c (test_set_ext_lang_command): Likewise.
3980         * target.c (target_fileio_read_stralloc): Likewise.
3981         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3982         * value.c (complete_internalvar): Likewise.
3983
3984 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3985
3986         Add objfile property to gdb.Type.
3987         * NEWS: Mention Python API addition.
3988         * python/py-type.c (typy_get_objfile): New method.
3989
3990 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3991
3992         * NEWS: Mention the new set|show style [title|highlight].
3993         Mention changes to "show style", "help" and "apropos".
3994
3995 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3996
3997         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3998         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3999         instead of print_help_for_command.
4000         (print_doc_of_command): New function.
4001         (help_list): Add 'apropos -v word' suggestion.
4002         (print_help_for_command): Style the command name using title style.
4003         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4004         (_initialize_cli_cmds): Describe -v in apropos_command help.
4005
4006 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4007
4008         * cli/cli-style.h (cli_style_option): Add name in constructor,
4009         add m_name class member, add constructor with intensity,
4010         add name class function.
4011         (cli_style_option::add_setshow_commands): Remove name argument.
4012         (highlight_style, title_style): New styles.
4013         * cli/cli-style.c (do_show): New function that shows a style
4014         characteristic styling the style name with itself.
4015         (set_style_name): New function.
4016         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4017         Update all callers according to the changes in cli/cli-style.h.
4018         * utils.h (fputs_highlighted): New function.
4019         * utils.c (fputs_highlighted): Likewise.
4020
4021 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4022
4023         * NEWS: Mention new pipe command and new convenience variables.
4024
4025 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4026
4027         * cli/cli-cmds.c (pipe_command): New function.
4028         (_initialize_cli_cmds): Call add_com for pipe_command.
4029         Define | as an alias for pipe.
4030         (exit_status_set_internal_vars): New function.
4031         (shell_escape): Call exit_status_set_internal_vars.
4032         cli/cli-decode.c (find_command_name_length): Recognize | as
4033         a single character command.
4034
4035 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4036
4037         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4038         top.c (execute_command_to_ui_file): New function, mostly a copy
4039         of execute_command_to_string.
4040         (execute_command_to_string): Implement by calling
4041         execute_command_to_ui_file.
4042
4043 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4044
4045         * top.h (saved_command_line): Remove declaration.
4046         * top.c (previous_saved_command_line, previous_repeat_arguments):
4047         New variables.
4048         (saved_command_line): Make static, define together with other
4049         'repeat variables'.
4050         (dont_repeat): Clear repeat_arguments.
4051         (repeat_previous, get_saved_command_line, save_command_line):
4052         New functions.
4053         (gdb_init): Initialize saved_command_line
4054         and previous_saved_command_line.
4055         * main.c (captured_main_1): Remove saved_command_line initialization.
4056         * event-top.c (handle_line_of_input): Update to use
4057         the new 'repeat' related functions instead of direct access to
4058         saved_command_line.
4059         * command.h (repeat_previous, get_saved_command_line,
4060         save_command_line): New declarations.
4061         (dont_repeat): Add comment.
4062
4063 2019-05-30  Tom Tromey  <tromey@adacore.com>
4064
4065         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4066         Fix comment.
4067         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4068
4069 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4070
4071         PR cli/24587
4072         * completer.c (complete): Initialize variable word.
4073
4074 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4075
4076         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4077         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4078         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4079         'body' is NULL to the outter 'if', protecting the '!is_define'
4080         situation as well.
4081
4082 2019-05-29  Tom Tromey  <tromey@adacore.com>
4083
4084         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4085         (dwarf_unknown): New function.
4086         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4087         (dwarf_type_encoding_name): Use dwarf_unknown.
4088
4089 2019-05-29  Tom Tromey  <tromey@adacore.com>
4090
4091         PR c++/20020:
4092         * cp-valprint.c (cp_print_value_fields): Call
4093         cp_print_static_field inside "try".
4094
4095 2019-05-29  Tom Tromey  <tromey@adacore.com>
4096
4097         * inflow.c (struct terminal_info): Add default operator=.
4098         * configure: Rebuild.
4099         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4100         -Wdeprecated-copy-dtor, -Wredundant-move.
4101
4102 2019-05-29  Tom Tromey  <tromey@adacore.com>
4103
4104         * NEWS: Add entry.
4105         * infcmd.c (print_return_value_1): Handle finish_print
4106         option.
4107         (show_print_finish): New function.
4108         (_initialize_infcmd): Add "set/show print finish" commands.
4109         * valprint.c (user_print_options): Initialize new member.
4110         * valprint.h (struct value_print_options) <finish_print>: New
4111         member.
4112
4113 2019-05-28  Tom Tromey  <tromey@adacore.com>
4114
4115         * ada-lang.c (ada_remove_Xbn_suffix)
4116         (find_old_style_renaming_symbol)
4117         (parse_old_style_renaming): Remove.
4118         (ada_find_renaming_symbol): Don't call
4119         find_old_style_renaming_symbol.
4120         (ada_is_renaming_symbol): Rename from
4121         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4122         bool.  Now static.
4123         (ada_read_var_value): Update and simplify.
4124         * ada-exp.y (write_var_or_type): Remove old code.
4125
4126 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4127
4128         * event-top.c: Remove include comment.
4129         * inflow.c (class scoped_ignore_sigttou): Move from here...
4130         * inflow.h (class scoped_ignore_sigttou): ...to here.
4131         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4132         * top.c:  Remove include comment.
4133
4134 2019-05-27  Tom Tromey  <tom@tromey.com>
4135
4136         * NEWS: Fix typo.
4137
4138 2019-05-22  Tom Tromey  <tromey@adacore.com>
4139
4140         * target.c (target_follow_exec): Constify parameter.
4141         * target-delegates.c: Rebuild.
4142         * remote.c (remote_target::follow_exec): Constify parameter.
4143         * infrun.c (follow_exec): Constify parameter.
4144         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4145         (target_follow_exec): Likewise.
4146
4147 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4148
4149         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4150         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4151
4152 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4153
4154         * NEWS: Add debugredirect and testsuite sections.
4155
4156 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4157
4158         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4159         target descriptions using exclusively floating point register name
4160         aliases.
4161
4162 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4163
4164         PR gdb/18644:
4165         * f-lang.c (build_fortran_types): Handle the case where
4166         gdbarch_floatformat_for_type returns a nullptr.
4167
4168 2019-05-21  Tom de Vries  <tdevries@suse.de>
4169
4170         PR cli/24587
4171         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4172
4173 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4174
4175         PR gdb/18644:
4176         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4177         16-byte floats.
4178         * i386-tdep.c (i386_floatformat_for_type): Use
4179         floatformats_ia64_quad for the 16-byte floating point component
4180         within a fortran 32-byte complex number.
4181
4182 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4183
4184         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4185         delete default constructor.
4186         (find_partial_die): Update to return const struct.
4187         (partial_die_parent_scope): Move variable declaration into scope
4188         of its use and change its type to auto.
4189         (guess_partial_die_structure_name): Likewise.
4190         (partial_die_info::fixup): Likewise.
4191
4192 2019-05-17  Tom Tromey  <tromey@adacore.com>
4193
4194         * source.c (find_and_open_source): Remove cast.
4195
4196 2019-05-17  Tom Tromey  <tromey@adacore.com>
4197
4198         * annotate.c (annotate_source): Make "filename" const.
4199         * annotate.h (annotate_source): Use const.
4200
4201 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4202
4203         * disasm.c (set_disassembler_options): Send errors to stderr.
4204
4205 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4206
4207         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4208         (cli_interp_base::set_logging): Check debug_redirect.
4209         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4210         * cli/cli-logging.c (debug_redirect): Add static variable.
4211         (pop_output_files): Add default param.
4212         (handle_redirections): Print debug setting.
4213         (show_logging_command): Likewise.
4214         (_initialize_cli_logging): Add debugredirect command.
4215         * interps.c (current_interp_set_logging): Add debug_redirect
4216         parameter.
4217         * interps.h (set_logging): Add debug_redirect parameter.
4218         (current_interp_set_logging): Likewise.
4219         * mi/mi-common.h: Likewise.
4220         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4221
4222 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4223             Tom Tromey  <tromey@adacore.com>
4224
4225         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4226         directly.
4227         * cli/cli-interp.h (make_logging_output): Remove declaration.
4228         * cli/cli-logging.c (make_logging_output): Remove function.
4229         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4230         directly.
4231         * ui-file.c (tee_file::tee_file): Remove bools.
4232         (tee_file::~tee_file): Remove deletes.
4233         * ui-file.h (tee_file): Remove bools.
4234
4235 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4236
4237         * mi/mi-cmds.h (mi_cmd_complete): New function.
4238         * mi/mi-main.c (mi_cmd_complete): Likewise.
4239         * mi/mi-cmds.c: Define new MI command -complete.
4240         * NEWS: Mention new -complete command.
4241
4242 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4243
4244         * completer.h (complete): New function.
4245         * completer.c (complete): Likewise.
4246         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4247         function defined in completer.h.
4248
4249 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4250
4251         * MAINTAINERS (Write After Approval): Add myself.
4252
4253 2019-05-17  Tom de Vries  <tdevries@suse.de>
4254
4255         PR gdb/24094
4256         * dwarf2read.c (struct cu_partial_die_info): New struct.
4257         (find_partial_die): Return cu_partial_die_info.
4258         (partial_die_parent_scope, guess_partial_die_structure_name)
4259         (partial_die_info::fixup): Handle new return type of find_partial_die.
4260
4261 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4262
4263         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4264         "std::string", simplifying the algorithm.
4265
4266 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4267
4268         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4269         (stap_static_probe_ops::get_probes): Likewise.
4270
4271 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4272
4273         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4274         '-')" and "else if".
4275         (stap_parse_single_operand): Join checks for
4276         "gdbarch_stap_parse_special_token_p" and
4277         "gdbarch_stap_parse_special_token" in the same "if" statement.
4278         Invert check when verifying for operation on register
4279         displacement.
4280
4281 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4282
4283         * stap-probe.c (stap_get_opcode): Update comment.
4284         (stap_get_expected_argument_type): Likewise.
4285         (handle_stap_probe): Likewise.
4286
4287 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4288
4289         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4290         return type to 'bool'.  Adjust comment.  Use 'bool' when
4291         appropriate.
4292         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4293         * stap-probe.c (stap_parse_argument_1): Likewise.
4294         (stap_is_operator): Likewise.
4295         (stap_is_generic_prefix): Likewise.
4296         (stap_is_register_prefix): Likewise.
4297         (stap_is_register_indirection_prefix): Likewise.
4298         (stap_is_integer_prefix): Likewise.
4299         (stap_generic_check_suffix): Likewise.
4300         (stap_check_integer_suffix): Likewise.
4301         (stap_check_register_suffix): Likewise.
4302         (stap_check_register_indirection_suffix): Likewise.
4303         (stap_parse_register_operand): Likewise.
4304         (stap_parse_single_operand): Likewise.
4305         (stap_parse_argument_1): Likewise.
4306         (stap_probe::get_argument_count): Likewise.
4307         (stap_is_operator): Likewise.
4308
4309 2019-05-16  Tom Tromey  <tromey@adacore.com>
4310
4311         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4312         keyword to foreach.
4313
4314 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4315
4316         * linux-thread-db.c (try_thread_db_load_1): Change return type
4317         to bool.
4318         (try_thread_db_load): Likewise.
4319         (try_thread_db_load_from_pdir_1): Likewise.
4320         (try_thread_db_load_from_pdir): Likewise.
4321         (try_thread_db_load_from_sdir): Likewise.
4322         (try_thread_db_load_from_dir): Likewise.
4323         (thread_db_load_search): Likewise.
4324         (has_libpthread): Likewise.
4325         (thread_db_load): Likewise.
4326
4327 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4328
4329         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4330         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4331         NULL, and complain/return if that's the case.
4332
4333 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4334
4335         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4336         (advance, posn, abstract_read_memory): New functions.
4337         [struct mem_read_abstraction]: New struct.
4338         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4339
4340 2019-05-14  Tom Tromey  <tromey@adacore.com>
4341
4342         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4343         value is not lval_memory.
4344
4345 2019-05-14  Tom Tromey  <tromey@adacore.com>
4346
4347         * solib.c (info_sharedlibrary_command): Style the file name.
4348
4349 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4350
4351         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4352         (aarch64_vnv_type): Likewise.
4353         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4354         * common/tdesc.c: Likewise.
4355         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4356         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4357         * features/aarch64-fpu.xml: Add ieee half view.
4358         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4359         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4360         * gdbtypes.h (struct builtin_type): Likewise.
4361         (struct objfile_type): Likewise.
4362
4363 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4364
4365         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4366         typo.
4367         * location.h (string_to_event_location): Likewise.
4368
4369 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4370
4371         GDB 8.3 released.
4372
4373 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4374
4375         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4376         New variable declaration.
4377         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4378         New variable.
4379         (print_one_breakpoint): Use ui_out::test_flags and new global
4380         variable to compute use_fixed_output.
4381         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4382         Remove.
4383         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4384         (mi_multi_location_breakpoint_output_fixed): Remove.
4385         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4386         new variable.
4387         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4388         fix_multi_location_breakpoint_output flag if version >= 3.
4389         * ui-out.h (enum ui_out_flag)
4390         <fix_multi_location_breakpoint_output>: New enumerator.
4391
4392 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4393
4394         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4395
4396 2019-05-10  Tom Tromey  <tromey@adacore.com>
4397
4398         * ada-lang.c (catch_ada_completer): New function.
4399         (_initialize_ada_language): Use it.
4400
4401 2019-05-10  Tom Tromey  <tromey@adacore.com>
4402
4403         * thread.c (print_thread_info): Make "requested_threads" const.
4404         * gdbthread.h (print_thread_info): Make "requested_threads"
4405         const.
4406         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4407         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4408
4409 2019-05-08  Tom Tromey  <tom@tromey.com>
4410
4411         * gdbtypes.c (objfile_type_data): Change type.
4412         (objfile_type, _initialize_gdbtypes): Update.
4413
4414 2019-05-08  Tom Tromey  <tom@tromey.com>
4415
4416         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4417         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4418         (_initialize_dwarf2_frame): Update.
4419
4420 2019-05-08  Tom Tromey  <tom@tromey.com>
4421
4422         * objc-lang.c (objc_objfile_data): Change type.
4423         (find_methods): Update.
4424         (_initialize_objc_lang): Remove.
4425
4426 2019-05-08  Tom Tromey  <tom@tromey.com>
4427
4428         * stabsread.c (rs6000_builtin_type_data): Change type.
4429         (rs6000_builtin_type, _initialize_stabsread): Update.
4430
4431 2019-05-08  Tom Tromey  <tom@tromey.com>
4432
4433         * mips-tdep.c (mips_pdr_data): Remove.
4434         (_initialize_mips_tdep): Update.
4435
4436 2019-05-08  Tom Tromey  <tom@tromey.com>
4437
4438         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4439         (hppa_init_objfile_priv_data, read_unwind_info)
4440         (find_unwind_entry, _initialize_hppa_tdep): Update.
4441
4442 2019-05-08  Tom Tromey  <tom@tromey.com>
4443
4444         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4445         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4446         on obstack.
4447         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4448
4449 2019-05-08  Tom Tromey  <tom@tromey.com>
4450
4451         * mdebugread.c (basic_type_data): Change type.
4452         (basic_type, _initialize_mdebugread): Update.
4453
4454 2019-05-08  Tom Tromey  <tom@tromey.com>
4455
4456         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4457
4458 2019-05-08  Tom Tromey  <tom@tromey.com>
4459
4460         * nto-tdep.c (nto_inferior_data_reg): Change type.
4461         (nto_inferior_data): Update.
4462         (nto_inferior_data_cleanup, nto_new_inferior_data)
4463         (_initialize_nto_tdep): Remove.
4464         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4465
4466 2019-05-08  Tom Tromey  <tom@tromey.com>
4467
4468         * ada-lang.c (struct ada_inferior_data): Add initializers.
4469         (ada_inferior_data): Change type.
4470         (ada_inferior_data_cleanup): Remove.
4471         (get_ada_inferior_data, ada_inferior_exit)
4472         (struct ada_pspace_data): Add initializers, destructor.
4473         (ada_pspace_data_handle): Change type.
4474         (get_ada_pspace_data): Update.
4475         (ada_pspace_data_cleanup): Remove.
4476
4477 2019-05-08  Tom Tromey  <tom@tromey.com>
4478
4479         * coffread.c (struct coff_symfile_info): Add initializers.
4480         (coff_objfile_data_key): Move lower.  Change type.
4481         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4482         Update.
4483         (coff_free_info): Remove.
4484
4485 2019-05-08  Tom Tromey  <tom@tromey.com>
4486
4487         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4488         (fbsd_pspace_data_handle): Move lower.  Change type.
4489         (get_fbsd_pspace_data): Update.
4490         (fbsd_pspace_data_cleanup): Remove.
4491         (_initialize_fbsd_tdep): Update.
4492
4493 2019-05-08  Tom Tromey  <tom@tromey.com>
4494
4495         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4496         (get_ada_tasks_pspace_data): Update.
4497         (ada_tasks_pspace_data_cleanup): Remove.
4498         (_initialize_tasks): Update.
4499         (ada_tasks_inferior_data_handle): Change type.
4500         (get_ada_tasks_inferior_data): Update.
4501         (ada_tasks_inferior_data_cleanup): Remove.
4502         (struct ada_tasks_pspace_data): Add initializers.
4503
4504 2019-05-08  Tom Tromey  <tom@tromey.com>
4505
4506         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4507         * symfile-debug.c (debug_sym_get_probes): Change type.
4508         * stap-probe.c (handle_stap_probe):
4509         (stap_static_probe_ops::get_probes): Change type.
4510         * probe.h (class static_probe_ops) <get_probes>: Change type.
4511         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4512         (parse_probes_in_pspace): Update.
4513         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4514         Update.
4515         (any_static_probe_ops::get_probes): Change type.
4516         * elfread.c (elfread_data): New typedef.
4517         (probe_key): Change type.
4518         (elf_get_probes): Likewise.  Update.
4519         (probe_key_free): Remove.
4520         (_initialize_elfread): Update.
4521         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4522         Change type.
4523         (dtrace_process_dof_probe, dtrace_process_dof)
4524         (dtrace_static_probe_ops::get_probe): Change type.
4525
4526 2019-05-08  Tom Tromey  <tom@tromey.com>
4527
4528         * xcoffread.c (struct xcoff_symfile_info): Rename from
4529         coff_symfile_info.  Add initializers.
4530         (xcoff_objfile_data_key): Move lower.  Change type.
4531         (XCOFF_DATA): Rewrite.
4532         (xcoff_free_info): Remove.
4533         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4534         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4535         (xcoff_initial_scan): Update.
4536
4537 2019-05-08  Tom Tromey  <tom@tromey.com>
4538
4539         * solib-svr4.c (struct svr4_info): Add initializers and
4540         destructor.
4541         <probes_table>: Now an htab_up.
4542         (solib_svr4_pspace_data): Change type.
4543         (free_probes_table): Simplify.
4544         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4545         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4546         (probes_table_remove_objfile_probes, register_solib_event_probe)
4547         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4548         (_initialize_svr4_solib): Update.
4549
4550 2019-05-08  Tom Tromey  <tom@tromey.com>
4551
4552         * remote.c (remote_pspace_data): Change type.
4553         (remote_pspace_data_cleanup): Remove.
4554         (get_remote_exec_file, set_pspace_remote_exec_file)
4555         (_initialize_remote): Update.
4556
4557 2019-05-08  Tom Tromey  <tom@tromey.com>
4558
4559         * breakpoint.c (breakpoint_objfile_key): Change type.
4560         (get_breakpoint_objfile_data): Update.
4561         (free_breakpoint_objfile_data): Remove.
4562         (_initialize_breakpoint): Update.
4563
4564 2019-05-08  Tom Tromey  <tom@tromey.com>
4565
4566         * linux-tdep.c (struct linux_info): Add initializers.
4567         (linux_inferior_data): Move.  Change type.
4568         (invalidate_linux_cache_inf): Update.
4569         (linux_inferior_data_cleanup): Remove.
4570         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4571
4572 2019-05-08  Tom Tromey  <tom@tromey.com>
4573
4574         * auxv.c (auxv_inferior_data): Move.  Change type.
4575         (auxv_inferior_data_cleanup): Remove.
4576         (invalidate_auxv_cache_inf): Rewrite.
4577         (get_auxv_inferior_data, _initialize_auxv): Update.
4578
4579 2019-05-08  Tom Tromey  <tom@tromey.com>
4580
4581         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4582         (symfile_debug_objfile_data_key): Change type.
4583         (symfile_debug_installed, debug_qf_has_symbols)
4584         (debug_qf_find_last_source_symtab)
4585         (debug_qf_forget_cached_source_info)
4586         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4587         (debug_qf_print_stats, debug_qf_dump)
4588         (debug_qf_expand_symtabs_for_function)
4589         (debug_qf_expand_all_symtabs)
4590         (debug_qf_expand_symtabs_with_fullname)
4591         (debug_qf_map_matching_symbols)
4592         (debug_qf_expand_symtabs_matching)
4593         (debug_qf_find_pc_sect_compunit_symtab)
4594         (debug_qf_map_symbol_filenames)
4595         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4596         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4597         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4598         (debug_sym_read_linetable, debug_sym_relocate): Update.
4599         (symfile_debug_free_objfile): Remove.
4600         (install_symfile_debug_logging, _initialize_symfile_debug):
4601         Update.
4602
4603 2019-05-08  Tom Tromey  <tom@tromey.com>
4604
4605         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4606         allocate_on_obstack.
4607         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4608         (get_dwarf2_per_objfile): Update.
4609         (set_dwarf2_per_objfile): Remove.
4610         (dwarf2_has_info, dwarf2_get_section_info): Update.
4611         (dwarf2_free_objfile): Remove.
4612         (_initialize_dwarf2_read): Update.
4613
4614 2019-05-08  Tom Tromey  <tom@tromey.com>
4615
4616         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4617         initializers.
4618         <unsupported_script_warning_printed,
4619         script_not_found_warning_printed>: Now bool.
4620         (auto_load_pspace_data): Change type.
4621         (~auto_load_pspace_info): Rename from
4622         auto_load_pspace_data_cleanup.
4623         (get_auto_load_pspace_data, init_loaded_scripts_info)
4624         (clear_section_scripts, maybe_print_unsupported_script_warning)
4625         (maybe_print_script_not_found_warning, _initialize_auto_load):
4626         Update.
4627
4628 2019-05-08  Tom Tromey  <tom@tromey.com>
4629
4630         * objfiles.c (objfile_pspace_info): Add destructor and
4631         initializers.
4632         (objfiles_pspace_data): Change type.
4633         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4634         (get_objfile_pspace_data): Update.
4635         (objfiles_bfd_data): Change type.
4636         (get_objfile_bfd_data): Update.
4637         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4638
4639 2019-05-08  Tom Tromey  <tom@tromey.com>
4640
4641         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4642         Change type.
4643         (get_catch_syscall_inferior_data): Update.
4644         (catch_syscall_inferior_data_cleanup): Remove.
4645         (_initialize_break_catch_syscall): Update.
4646
4647 2019-05-08  Tom Tromey  <tom@tromey.com>
4648
4649         * inflow.c (struct terminal_info): Add destructor and
4650         initializers.
4651         (inflow_inferior_data): Change type.
4652         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4653         (get_inflow_inferior_data, inflow_inferior_exit)
4654         (swap_terminal_info, _initialize_inflow): Update.
4655
4656 2019-05-08  Tom Tromey  <tom@tromey.com>
4657
4658         * target-dcache.c (target_dcache_cleanup): Remove.
4659         (target_dcache_aspace_key): Change type.
4660         (target_dcache_init_p, target_dcache_invalidate)
4661         (target_dcache_get, target_dcache_get_or_init)
4662         (_initialize_target_dcache): Update.
4663         * dcache.h (struct dcache_deleter): New.
4664
4665 2019-05-08  Tom Tromey  <tom@tromey.com>
4666
4667         * symtab.c (struct symbol_cache): Add destructor and
4668         initializers.
4669         (symbol_cache_key): Move.  Change type.
4670         (make_symbol_cache, free_symbol_cache): Remove.
4671         (get_symbol_cache): Update.
4672         (symbol_cache_cleanup): Remove.
4673         (ALL_PSPACES, symbol_cache_flush)
4674         (maintenance_print_symbol_cache)
4675         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4676         Update.
4677
4678 2019-05-08  Tom Tromey  <tom@tromey.com>
4679
4680         * symtab.c (struct main_info): Add destructor and initializers.
4681         (main_progspace_key): Move.  Change type.
4682         (get_main_info): Update.
4683         (main_info_cleanup): Remove.
4684         (_initialize_symtab): Update.
4685
4686 2019-05-08  Tom Tromey  <tom@tromey.com>
4687
4688         * registry.h (DECLARE_REGISTRY): Define the _key class.
4689
4690 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4691
4692         * NEWS: Merge two 'New commands' sections.
4693
4694 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4695
4696         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4697         parameter and use Ada language definition instead.
4698         (ada_val_print_ptr): Remove unused language parameter.
4699         (ada_val_print_num): Remove language parameter and use Ada language
4700         definition instead.
4701         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4702         parameter.
4703         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4704         parameter and use Ada language definition instead.
4705         (ada_val_print_1): Update all ada_val_print_xxx calls.
4706         Remove language parameter.
4707         (ada_val_print): Update ada_val_print_1 call.
4708
4709 2019-05-08  Tom Tromey  <tromey@adacore.com>
4710
4711         * remote.c (remote_hw_watchpoint_limit)
4712         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4713         Now static.
4714
4715 2019-05-08  Tom Tromey  <tromey@adacore.com>
4716
4717         * maint.c (_initialize_maint_cmds): Move initialization code to
4718         remote.c.
4719         (watchdog, show_watchdog): Move to remote.c.
4720         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4721         "watchdog" static.
4722         (_initialize_remote): Move initialization code from maint.c.
4723         * defs.h (watchdog): Don't declare.
4724
4725 2019-05-08  Tom Tromey  <tromey@adacore.com>
4726
4727         * tui/tui-interp.c: Include main.h.
4728         * interps.c: Include main.h.
4729         * main.h (interpreter_p): Declare.
4730         * defs.h (interpreter_p): Don't declare.
4731
4732 2019-05-08  Tom Tromey  <tromey@adacore.com>
4733
4734         * dwarf2loc.c: Include dwarf2read.h.
4735         * defs.h (read_unsigned_leb128): Don't declare.
4736         * dwarf2read.h (read_unsigned_leb128): Declare.
4737
4738 2019-05-08  Tom Tromey  <tromey@adacore.com>
4739
4740         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4741         method.
4742
4743 2019-05-08  Tom Tromey  <tromey@adacore.com>
4744
4745         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4746         when no wrap column is set.
4747
4748 2019-05-08  Tom Tromey  <tromey@adacore.com>
4749
4750         * c-lang.c (c_get_string): Handle non-C-style arrays.
4751
4752 2019-05-08  Tom Tromey  <tromey@adacore.com>
4753
4754         * typeprint.c (print_offset_data::update): Print the bit offset,
4755         not the number of bits remaining.
4756
4757 2019-05-08  Tom Tromey  <tromey@adacore.com>
4758
4759         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4760         padding at end of comment.
4761
4762 2019-05-08  Tom Tromey  <tromey@adacore.com>
4763
4764         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4765         Compare main types.
4766
4767 2019-05-06  Tom Tromey  <tom@tromey.com>
4768
4769         * common/scoped_mmap.c: Include common-defs.h.
4770         * common/scoped_mmap.h: Don't include config.h.
4771
4772 2019-05-04  Tom Tromey  <tom@tromey.com>
4773
4774         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4775         (struct aarch64_call_info): Add initializers.
4776         <si>: Now a std::vector.
4777         (pass_on_stack, aarch64_push_dummy_call): Update.
4778
4779 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4780             Tom Tromey  <tom@tromey.com>
4781
4782         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4783         (ppc_threads): Now a std::vector.  Now static.
4784         (hwdebug_find_thread_points_by_tid)
4785         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4786         Update.
4787
4788 2019-05-04  Tom Tromey  <tom@tromey.com>
4789
4790         * arc-tdep.c (arc_tdesc_init): Return bool.
4791
4792 2019-05-04  Tom Tromey  <tom@tromey.com>
4793
4794         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4795         Use gdb_assert_not_reached.
4796
4797 2019-05-04  Tom Tromey  <tom@tromey.com>
4798
4799         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4800         "false".
4801
4802 2019-05-04  Tom Tromey  <tom@tromey.com>
4803
4804         * arc-tdep.c (arc_tdesc_init): Use bool.
4805
4806 2019-05-04  Tom Tromey  <tom@tromey.com>
4807
4808         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4809
4810 2019-05-04  Tom Tromey  <tom@tromey.com>
4811
4812         * cli/cli-cmds.c (valid_command_p): Return bool.
4813
4814 2019-05-04  Tom Tromey  <tom@tromey.com>
4815
4816         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4817         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4818
4819 2019-05-04  Raul Tambre  <raul@tambre.ee>
4820
4821         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4822         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4823         operator for comparison.
4824
4825 2019-05-04  Tom Tromey  <tom@tromey.com>
4826
4827         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4828         (lookup_partial_symbol, print_partial_symbols)
4829         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4830         (psymbol_compare): Update.
4831         (add_psymbol_to_bcache): Clear the entire psymbol.
4832         (maintenance_check_psymtabs): Update.
4833         * psympriv.h (struct partial_symbol): Don't derive from
4834         general_symbol_info.
4835         <obj_section, unrelocated_address, address,
4836         set_unrelocated_address>: Update.
4837         <ginfo>: New member.
4838         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4839         (debug_names::write_psymbols): Update.
4840
4841 2019-05-04  Tom de Vries  <tdevries@suse.de>
4842
4843         * contrib/cc-with-tweaks.sh: Support -n arg.
4844
4845 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4846
4847         * corelow.c (core_target::detach): Ensure frame cache and
4848         register caches are cleared.
4849         inferior.c (exit_inferior_1): Likewise.
4850
4851 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4852             Tom Tromey  <tom@tromey.com>
4853
4854         * dictionary.c (collate_pending_symbols_by_language): Remove
4855         "struct" from foreach.
4856         * symtab.c (lookup_global_symbol_from_objfile)
4857         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4858         foreach.
4859         * ser-tcp.c (net_open): Remove "struct" from foreach.
4860         * objfiles.c (objfile_relocate, objfile_rebase)
4861         (objfile_has_symbols): Remove "struct" from foreach.
4862         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4863         from foreach.
4864         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4865         foreach.
4866         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4867         "struct" from foreach.
4868         * ada-lang.c (create_excep_cond_exprs)
4869         (ada_exception_catchpoint_cond_string): Remove "struct" from
4870         foreach.
4871
4872 2019-05-03  Tom Tromey  <tromey@adacore.com>
4873
4874         * ada-exp.y (convert_char_literal): Check suffix of each
4875         enumerator.
4876
4877 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4878
4879         PR ada/21406:
4880         * ada-exp.y (yywrap): Don't define.
4881         * ada-lex.l (%option): Add noyywrap
4882         (yywrap): Remove.
4883
4884 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4885
4886         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4887         _WIN32_WINNT to the XP level, unless already defined to a higher
4888         level.
4889
4890         * unittests/parse-connection-spec-selftests.c:
4891         * ser-tcp.c:
4892         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4893         override.
4894
4895         * symfile.c (find_separate_debug_file): Remove colon from the
4896         drive spec of DOS/Windows file names of the target, so that the
4897         file name produced from DEBUGDIR and the target's directory will
4898         be valid on DOS/Windows systems.
4899
4900 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4901
4902         * rust-lang.c (val_print_struct): Handle printing structures
4903         containing strings.
4904
4905 2019-05-02  Tom Tromey  <tromey@adacore.com>
4906
4907         * valarith.c (_initialize_valarith): Remove.
4908
4909 2019-05-01  Tom Tromey  <tromey@adacore.com>
4910
4911         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4912         bitfields.
4913
4914 2019-05-01  Tom Tromey  <tromey@adacore.com>
4915
4916         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4917         for big-endian copies.
4918
4919 2019-04-30  Ali Tamur  <tamur@google.com>
4920         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4921         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4922         (read_3_bytes): New function.
4923
4924 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4925
4926         * windows-nat.c (main_thread_id): Delete.
4927         (handle_output_debug_string): Replace main_thread_id by
4928         current_event.dwThreadId.
4929         (fake_create_process): Likewise.
4930         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4931         Do not set main_thread_id.
4932         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4933         current_event.dwThreadId.
4934         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4935
4936 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4937
4938         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4939         Use current_event.dwThreadId instead of main_thread_id.
4940
4941 2019-04-30  Tom Tromey  <tromey@adacore.com>
4942
4943         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4944         (create_excep_cond_exprs): Iterate over program spaces.
4945         (ada_exception_catchpoint_cond_string): Examine all minimal
4946         symbols for exception types.
4947
4948 2019-04-30  Tom Tromey  <tromey@adacore.com>
4949
4950         PR c++/24470:
4951         * dwarf2read.c (process_structure_scope): Handle case where type
4952         has template parameters but no symbol was created.
4953
4954 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4955             Chris January  <chris.january@arm.com>
4956
4957         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4958         qualifier.
4959         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4960
4961 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4962
4963         * f-typeprint.c (f_print_type): Update rules for printing
4964         whitespace.
4965         (f_type_print_varspec_suffix): Likewise.
4966
4967 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4968             Chris January  <chris.january@arm.com>
4969
4970         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4971         function arguments.
4972
4973 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4974
4975         * f-lang.c (build_fortran_types): Change name of void type to
4976         lower case.
4977         * f-typeprint.c (f_type_print_base): Print the name of the void
4978         type, rather than a fixed string.
4979         * f-valprint.c (f_decorations): Use lower case void string.
4980
4981 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4982             Chris January  <chris.january@arm.com>
4983
4984         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4985         types for Fortran.
4986
4987 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4988             Chris January  <chris.january@arm.com>
4989             David Lecomber  <david.lecomber@arm.com>
4990
4991         * f-exp.y (BINOP_INTRINSIC): New token.
4992         (exp): New parser rule handling BINOP_INTRINSIC.
4993         (f77_keywords): Add new builtin procedures.
4994         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4995         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4996         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4997         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4998         (print_unop_subexp_f): New function.
4999         (print_binop_subexp_f): New function.
5000         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5001         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5002         (dump_subexp_body_f): Likewise.
5003         (operator_check_f): Likewise.
5004         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5005         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5006
5007 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5008
5009         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5010         UNOP_KIND.
5011         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5012         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5013         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5014         (operator_length_f): New fuction.
5015         (print_subexp_f): New function.
5016         (op_name_f): New function.
5017         (dump_subexp_body_f): New function.
5018         (operator_check_f): New function.
5019         (exp_descriptor_f): Replace standard expression handling functions
5020         with new functions.
5021         * gdb/fortran-operator.def: New file.
5022         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5023         * gdb/std-operator.def: Remove UNOP_KIND.
5024
5025 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5026
5027         * std-operator.def: Remove unbalanced, stray double quote
5028         character.
5029
5030 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5031             Chris January  <chris.january@arm.com>
5032             Daniel Everett  <daniel.everett@arm.com>
5033             Nick Forrington  <nick.forrington@arm.com>
5034             Richard Bunt  <richard.bunt@arm.com>
5035
5036         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5037         of depth when printing anonymous structs or unions.
5038         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5039         Don't print either the top-level value, or the children if the
5040         max-depth is exceeded.
5041         (ppscm_print_children): When printing the key of a map, allow one
5042         extra level of depth.
5043         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5044         print either the top-level value, or the children if the max-depth
5045         is exceeded.
5046         (print_children): When printing the key of a map, allow one extra
5047         level of depth.
5048         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5049         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5050         (user_print_options): Initialise max_depth field.
5051         (val_print_scalar_or_string_type_p): New function.
5052         (val_print): Check to see if the max depth has been reached.
5053         (val_print_check_max_depth): Define new function.
5054         (show_print_max_depth): New function.
5055         (_initialize_valprint): Add 'print max-depth' option.
5056         * valprint.h (struct value_print_options) <max_depth>: New field.
5057         (val_print_check_max_depth): Declare new function.
5058         * NEWS: Document new feature.
5059
5060 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5061
5062         * ada-lang.c (ada_language_defn): Initialise new field.
5063         * c-lang.c (c_is_string_type_p): New function.
5064         (c_language_defn): Initialise new field.
5065         (cplus_language_defn): Initialise new field.
5066         (asm_language_defn): Initialise new field.
5067         (minimal_language_defn): Initialise new field.
5068         * c-lang.h (c_is_string_type_p): Declare new function.
5069         * d-lang.c (d_language_defn): Initialise new field.
5070         * f-lang.c (f_is_string_type_p): New function.
5071         (f_language_defn): Initialise new field.
5072         * go-lang.c (go_is_string_type_p): New function.
5073         (go_language_defn): Initialise new field.
5074         * language.c (default_is_string_type_p): New function.
5075         (unknown_language_defn): Initialise new field.
5076         (auto_language_defn): Initialise new field.
5077         * language.h (struct language_defn) <la_is_string_type_p>: New
5078         member variable.
5079         (default_is_string_type_p): Declare new function.
5080         * m2-lang.c (m2_language_defn): Initialise new field.
5081         * objc-lang.c (objc_language_defn): Initialise new field.
5082         * opencl-lang.c (opencl_language_defn): Initialise new field.
5083         * p-lang.c (pascal_is_string_type_p): New function.
5084         (pascal_language_defn): Initialise new field.
5085         * rust-lang.c (rust_is_string_type_p): New function.
5086         (rust_language_defn): Initialise new field.
5087
5088 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5089
5090         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5091         New field.
5092         * ada-lang.c (ada_language_defn): Initialise new field.
5093         * c-lang.c (c_language_defn): Likewise.
5094         (cplus_language_defn): Likewise.
5095         (asm_language_defn): Likewise.
5096         (minimal_language_defn): Likewise.
5097         * d-lang.c (d_language_defn): Likewise.
5098         * f-lang.c (f_language_defn): Likewise.
5099         * go-lang.c (go_language_defn): Likewise.
5100         * language.c (unknown_language_defn): Likewise.
5101         (auto_language_defn): Likewise.
5102         * m2-lang.c (m2_language_defn): Likewise.
5103         * objc-lang.c (objc_language_defn): Likewise.
5104         * opencl-lang.c (opencl_language_defn): Likewise.
5105         * p-lang.c (pascal_language_defn): Likewise.
5106         * rust-lang.c (rust_language_defn): Likewise.
5107
5108 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5109
5110         * ada-lang.c (ada_is_character_type): Change return type to bool.
5111         (ada_is_string_type): Likewise.
5112         * ada-lang.h (ada_is_character_type): Update declaration
5113         (ada_is_string_type): Likewise.
5114
5115 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5116
5117         Support style in 'frame|thread apply'
5118
5119         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5120         * record.c (record_start, record_stop): Update callers of
5121         execute_command_to_string with false.
5122         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5123         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5124         methods.
5125         (class string_file): New constructor with term_out parameter.
5126         Override methods term_out and can_emit_style_escape.  New member
5127         term_out.
5128         (class stdio_file): Override can_emit_style_escape.
5129         (class tee_file): Override term_out and can_emit_style_escape.
5130         * utils.h (can_emit_style_escape): Remove.
5131         * utils.c (can_emit_style_escape): Likewise.
5132         Update all callers of can_emit_style_escape (SOMESTREAM) to
5133         SOMESTREAM->can_emit_style_escape.
5134         * source-cache.c (source_cache::get_source_lines): Likewise.
5135         * stack.c (frame_apply_command_count): Call execute_command_to_string
5136         passing the term_out characteristic of the current gdb_stdout.
5137         * thread.c (thr_try_catch_cmd): Likewise.
5138         * top.c (execute_command_to_string): pass term_out parameter
5139         to construct the string_file for the command output.
5140         * ui-file.c (term_cli_styling): New function (most code moved
5141         from utils.c can_emit_style_escape).
5142         (string_file::string_file, string_file::can_emit_style_escape,
5143         stdio_file::can_emit_style_escape, tee_file::term_out,
5144         tee_file::can_emit_style_escape): New functions.
5145
5146 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5147
5148         * NEWS: Mention the new set|show may-call-functions.
5149         * infcall.c (may_call_functions_p): New variable.
5150         (show_may_call_functions_p): New function.
5151         (call_function_by_hand_dummy): Throws an error if not
5152         may-call-functions.
5153         (_initialize_infcall): Call add_setshow_boolean_cmd for
5154         may-call-functions.
5155
5156 2019-04-25  Keith Seitz  <keiths@redhat.com>
5157
5158         PR c++/24367
5159         * cp-support.c (inspect_type): Don't attempt substitutions
5160         of symbol with the same name.
5161
5162 2019-04-25  Tom Tromey  <tromey@adacore.com>
5163
5164         PR gdb/24475:
5165         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5166         static.
5167
5168 2019-04-25  Tom Tromey  <tromey@adacore.com>
5169
5170         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5171         rvalue reference.
5172         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5173         (gdb_xml_parser::parse): Use std::move.
5174         * python/python-internal.h (gdbpy_convert_exception): Take a const
5175         reference.
5176         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5177         std::move.
5178         * python/py-utils.c (gdbpy_convert_exception): Take a const
5179         reference.
5180         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5181         Use std::move.
5182         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5183         Use std::move.
5184         * mi/mi-main.c (mi_print_exception): Take a const reference.
5185         * main.c (handle_command_errors): Take a const reference.
5186         * linespec.c (parse_linespec): Use std::move.
5187         * infcall.c (run_inferior_call): Use std::move.
5188         (call_function_by_hand_dummy): Use std::move.
5189         * exec.c (try_open_exec_file): Use std::move.
5190         * exceptions.h (exception_print, exception_fprintf)
5191         (exception_print_same): Update.
5192         * exceptions.c (print_exception, exception_print)
5193         (exception_fprintf, exception_print_same): Change parameters to
5194         const reference.
5195         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5196         * common/new-op.c: Use std::move.
5197         * common/common-exceptions.h (struct gdb_exception): Add move
5198         constructor.
5199         (struct gdb_exception_error, struct gdb_exception_quit, struct
5200         gdb_quit_bad_alloc): Change constructor to move constructor.
5201         (throw_exception): Change parameter to rvalue reference.
5202         * common/common-exceptions.c (throw_exception): Take rvalue
5203         reference.
5204         * cli/cli-interp.c (safe_execute_command): Use std::move.
5205         * breakpoint.c (insert_bp_location, location_to_sals): Use
5206         std::move.
5207
5208 2019-04-25  Tom Tromey  <tromey@adacore.com>
5209
5210         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5211         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5212         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5213         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5214         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5215         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5216         guile/scm-value.c: Use unpack.
5217         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5218         gdbscm_gdb_exception.
5219         (gdbscm_throw_gdb_exception): Likewise.
5220         (struct gdbscm_gdb_exception): New.
5221         (unpack): New function.
5222         (gdbscm_wrap): Use unpack.
5223
5224 2019-04-25  Tom Tromey  <tromey@adacore.com>
5225
5226         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5227         (gdb_rl_callback_handler): Use std::move.
5228         * common/common-exceptions.h (struct gdb_exception): Add move
5229         assignment operator.
5230         (throw_exception_sjlj): Change "exception" to const reference.
5231         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5232         (throw_exception_sjlj): Change "exception" to const reference.
5233
5234 2019-04-25  Tom Tromey  <tromey@adacore.com>
5235
5236         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5237         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5238         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5239         Update.
5240         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5241         Update.
5242         * mi/mi-interp.c (mi_interp::exec): Update.
5243         * linespec.c (parse_linespec): Update.
5244         * infcall.c (run_inferior_call): Update.
5245         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5246         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5247         (gdbscm_lookup_global_symbol): Update.
5248         * guile/scm-param.c (gdbscm_parameter_value): Update.
5249         * guile/scm-frame.c (gdbscm_frame_read_register)
5250         (gdbscm_frame_read_var): Update.
5251         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5252         * exec.c (try_open_exec_file): Update.
5253         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5254         (gdb_rl_callback_handler): Update.
5255         * common/common-exceptions.h (exception_none): Don't declare.
5256         * common/common-exceptions.c (exception_none): Don't define.
5257         (struct catcher) <exception>: Update.
5258         * cli/cli-interp.c (safe_execute_command): Update.
5259         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5260
5261 2019-04-25  Ali Tamur  <tamur@google.com>
5262
5263         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5264         (read_attribute_value): Likewise.
5265         (dwarf2_read_addr_index): Update comment.
5266         (read_str_index): Add DW_FORM_strx.
5267         (dwarf2_string_attr): Likewise.
5268         (dwarf2_const_value_attr): Likewise.
5269         (dump_die_shallow): Likewise.
5270         (dwarf2_fetch_constant_bytes): Likewise.
5271         (skip_form_bytes): Likewise.
5272         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5273
5274 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5275
5276         PR corefiles/11608
5277         PR corefiles/18187
5278         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5279         OFFSET.  Verify if current mapping contains an ELF header.
5280         (linux_find_memory_regions_full): Adjust call to
5281         dump_mapping_p.
5282
5283 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5284             Kang Li <kanglictf@gmail.com>
5285
5286         PR gdb/21600
5287
5288         * dwarf2-frame.c (read_initial_length): Be consistent about using
5289         unsigned representation of length.
5290         (decode_frame_entry_1): Likewise.  Check for wraparound of
5291         end pointer as well as buffer overflow.
5292
5293 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5294
5295         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5296         "vq".
5297
5298 2019-04-24  Tom Tromey  <tromey@adacore.com>
5299
5300         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5301
5302 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5303
5304         * s12z-tdep.c (s12z_unwind_pc): Delete.
5305         (s12z_unwind_sp): Delete.
5306         (s12z_gdbarch_init): Don't register deleted functions with
5307         gdbarch.
5308
5309 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5310
5311         * rl78-tdep.c (rl78_unwind_sp): Delete.
5312         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5313
5314 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5315
5316         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5317         (xstormy16_unwind_pc): Delete.
5318         (xstormy16_dummy_id): Delete.
5319         (xstormy16_gdbarch_init): Don't register deleted functions with
5320         gdbarch.
5321
5322 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5323
5324         * vax-tdep.c (vax_unwind_pc): Delete.
5325         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5326
5327 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5328
5329         * v850-tdep.c (v850_unwind_sp): Delete.
5330         (v850_unwind_pc): Delete.
5331         (v850_dummy_id): Delete.
5332         (v850_gdbarch_init): Don't register deleted functions with
5333         gdbarch.
5334
5335 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5336
5337         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5338         (tilegx_unwind_pc): Delete.
5339         (tilegx_unwind_dummy_id): Delete.
5340         (tilegx_gdbarch_init): Don't register deleted functions with
5341         gdbarch.
5342
5343 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5344
5345         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5346         (tic6x_dummy_id): Delete.
5347         (tic6x_gdbarch_init): Don't register deleted functions with
5348         gdbarch.
5349
5350 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5351
5352         * sparc-tdep.c (sparc_unwind_pc): Delete.
5353         (sparc32_gdbarch_init): Don't register deleted function with
5354         gdbarch.
5355
5356 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5357
5358         * sh-tdep.c (sh_unwind_sp): Delete.
5359         (sh_unwind_pc): Delete.
5360         (sh_dummy_id): Delete.
5361         (sh_gdbarch_init): Don't register deleted functions with
5362         gdbarch.
5363
5364 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5365
5366         * score-tdep.c (score_unwind_sp): Delete.
5367         (score_unwind_pc): Delete.
5368         (score_dummy_id): Delete.
5369         (score_gdbarch_init): Don't register deleted functions with
5370         gdbarch.
5371
5372 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5373
5374         * rx-tdep.c (rx_unwind_pc): Delete.
5375         (rx_unwind_sp): Delete.
5376         (rx_dummy_id): Delete.
5377         (rx_gdbarch_init): Don't register deleted functions with
5378         gdbarch.  Update comment.
5379
5380 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5381
5382         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5383         (rs6000_dummy_id): Delete.
5384         (rs6000_gdbarch_init): Don't register deleted functions with
5385         gdbarch.
5386
5387 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5388
5389         * or1k-tdep.c (or1k_dummy_id): Delete.
5390         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5391
5392 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5393
5394         * nios2-tdep.c (nios2_dummy_id): Delete.
5395         (nios2_unwind_sp): Delete.
5396         (nios2_gdbarch_init): Don't register deleted functions with
5397         gdbarch.
5398
5399 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5400
5401         * nds32-tdep.c (nds32_dummy_id): Delete.
5402         (nds32_unwind_pc): Delete.
5403         (nds32_unwind_sp): Delete.
5404         (nds32_gdbarch_init): Don't register deleted functions with
5405         gdbarch.
5406
5407 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5408
5409         * msp430-tdep.c (msp430_unwind_pc): Delete.
5410         (msp430_unwind_sp): Delete.
5411         (msp430_dummy_id): Delete.
5412         (msp430_gdbarch_init): Don't register deleted functions with
5413         gdbarch.
5414
5415 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5416
5417         * moxie-tdep.c (moxie_unwind_sp): Delete.
5418         (moxie_unwind_pc): Delete.
5419         (moxie_dummy_id): Delete.
5420         (moxie_gdbarch_init): Don't register deleted functions with
5421         gdbarch.
5422
5423 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5424
5425         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5426         (mn10300_unwind_pc): Delete.
5427         (mn10300_unwind_sp): Delete.
5428         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5429         mn10300_unwind_sp.
5430         (mn10300_frame_unwind_init): Don't register deleted functions with
5431         gdbarch.
5432
5433 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5434
5435         * mep-tdep.c (mep_unwind_pc): Delete.
5436         (mep_unwind_sp): Delete.
5437         (mep_dummy_id): Delete.
5438         (mep_gdbarch_init): Don't register deleted functions with
5439         gdbarch.
5440
5441 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5442
5443         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5444         (m68hc11_unwind_sp): Delete.
5445         (m68hc11_gdbarch_init): Don't register deleted functions with
5446         gdbarch.
5447
5448 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5449
5450         * m32r-tdep.c (m32r_unwind_sp): Delete.
5451         (m32r_unwind_pc): Delete.
5452         (m32r_dummy_id): Delete.
5453         (m32r_gdbarch_init): Don't register deleted functions with
5454         gdbarch.
5455
5456 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5457
5458         * m32c-tdep.c (m32c_unwind_pc): Delete.
5459         (m32c_unwind_sp): Delete.
5460         (m32c_dummy_id): Delete.
5461         (m32c_gdbarch_init): Don't register deleted functions with
5462         gdbarch.
5463
5464 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5465
5466         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5467         (lm32_unwind_pc): Delete.
5468         (lm32_dummy_id): Delete.
5469         (lm32_gdbarch_init): Don't register deleted functions with
5470         gdbarch.
5471
5472 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5473
5474         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5475         (iq2000_unwind_pc): Delete.
5476         (iq2000_dummy_id): Delete.
5477         (iq2000_gdbarch_init): Don't register deleted functions with
5478         gdbarch.
5479
5480 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5481
5482         * nds32-tdep.c (nds32_type_align): Delete.
5483         (nds32_push_dummy_call): Use type_align instead.
5484
5485 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5486
5487         * arm-tdep.c (arm_type_align): Only handle vector override case.
5488         (arm_push_dummy_call): Use type_align.
5489         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5490
5491 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5492
5493         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5494         case.
5495         (pass_on_stack): Use type_align.
5496         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5497         function.
5498
5499 2019-04-23  Tom Tromey  <tromey@adacore.com>
5500
5501         * dwarf2read.c (line_header::file_name_at): Remove unused
5502         overload.
5503
5504 2019-04-23  Tom de Vries  <tdevries@suse.de>
5505
5506         PR gdb/24438
5507         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5508         invocation.
5509
5510
5511 2019-03-27  Ali Tamur  <tamur@google.com>
5512
5513         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5514         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5515         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5516         (dwarf_expr_context::get_addr_index): Likewise
5517         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5518         (symbol_needs_eval_context::get_addr_index): Likewise
5519         (disassemble_dwarf_expression): Add DW_OP_addrx
5520         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5521         (read_cutu_die_from_dwo): Update comment
5522         (skip_one_die): Add DW_FORM_addrx
5523         (read_attribute_value): Likewise
5524         (var_decode_location): Add DW_OP_addrx
5525         (dwarf2_const_value_attr): Add DW_FORM_addrx
5526         (dump_die_shallow): Likewise
5527         (dwarf2_fetch_constant_bytes): Likewise
5528         (decode_locdesc): Add DW_OP_addrx
5529         (skip_form_bytes): Add DW_FORM_addrx
5530
5531 2019-04-22  Ali Tamur  <tamur@google.com>
5532
5533         * MAINTAINERS (Write After Approval): Add self.
5534
5535 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5536
5537         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5538         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5539         (open_symbol_file_object): Likewise.
5540         (svr4_default_sos): Add info parameter.
5541         (svr4_read_so_list): Likewise.
5542         (svr4_current_sos_direct): Adjust functions calls to pass down
5543         info.
5544         (svr4_current_sos_1): Add info parameter.
5545         (svr4_current_sos): Call get_svr4_info, pass info down to
5546         svr4_current_sos_1.
5547         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5548         get_svr4_info.
5549         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5550         get_svr4_info.
5551         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5552         to get_svr4_info.
5553         (probes_table_remove_objfile_probes): Likewise.
5554         (register_solib_event_probe): Add info parameter.
5555         (solist_update_incremental): Pass info parameter down to
5556         svr4_read_so_list.
5557         (disable_probes_interface): Add info parameter.
5558         (svr4_handle_solib_event): Pass current_program_space to
5559         get_svr4_info.  Adjust disable_probes_interface cleanup.
5560         (svr4_create_probe_breakpoints): Add info parameter, pass it
5561         down to register_solib_event_probe.
5562         (svr4_create_solib_event_breakpoints): Add info parameter,
5563         pass it down to svr4_create_probe_breakpoints.
5564         (enable_break): Pass info down to
5565         svr4_create_solib_event_breakpoints.
5566         (svr4_solib_create_inferior_hook): Pass current_program_space to
5567         get_svr4_info.
5568         (svr4_clear_solib): Likewise.
5569
5570 2019-04-22  Pedro Alves  <palves@redhat.com>
5571
5572         * solib-svr4.c (svr4_free_objfile_observer): New.
5573         (probe_and_action::objfile): New field.
5574         (probes_table_htab_remove_objfile_probes)
5575         (probes_table_remove_objfile_probes): New functions.
5576         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5577         in the new probe_and_action.  Don't store the probe in 'lookup'.
5578         (svr4_create_probe_breakpoints): Pass objfile to
5579         register_solib_event_probe.
5580         (_initialize_svr4_solib): Register a free_objfile observer.
5581
5582 2019-04-19  Tom Tromey  <tom@tromey.com>
5583
5584         * common/queue.h: Remove.
5585
5586 2019-04-19  Tom Tromey  <tom@tromey.com>
5587
5588         * event-loop.c: Don't include "common/queue.h".
5589
5590 2019-04-19  Tom Tromey  <tom@tromey.com>
5591
5592         * remote.c (remote_target): Use delete.
5593         * remote-notif.h: Include <list>, not "common/queue.h".
5594         (notif_client_p): Remove typedef.
5595         (remote_notif_state): Add constructor, destructor, initializer.
5596         <notif_queue>: Now a std::list.
5597         (remote_notif_state_xfree): Don't declare.
5598         * remote-notif.c (remote_notif_process, handle_notification)
5599         (remote_notif_state_allocate): Update.
5600         (~remote_notif_state): Rename from remote_notif_state_xfree.
5601
5602 2019-04-19  Tom Tromey  <tom@tromey.com>
5603
5604         * symfile.c (reread_symbols): Update.
5605         * objfiles.c (objfile_register_static_link)
5606         (objfile_lookup_static_link): Update
5607         (~objfile) Don't delete static_links.
5608         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5609
5610 2019-04-19  Tom Tromey  <tom@tromey.com>
5611
5612         * type-stack.h (struct type_stack) <insert>: Constify string.
5613         * type-stack.c (type_stack::insert): Constify string.
5614         * gdbtypes.h (lookup_template_type): Update.
5615         (address_space_name_to_int): Update.
5616         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5617         const.
5618         (lookup_template_type): Make name const.
5619         * c-exp.y: Update rules.
5620         (lex_one_token, classify_name, classify_inner_name)
5621         (c_print_token): Update.
5622         * p-exp.y: Update rules.
5623         (yylex): Update.
5624         * f-exp.y: Update rules.
5625         (yylex): Update.
5626         * d-exp.y: Update rules.
5627         (lex_one_token, classify_name, classify_inner_name): Update.
5628         * parse.c (write_dollar_variable, copy_name): Return std::string.
5629         * parser-defs.h (copy_name): Change return type.
5630         * m2-exp.y: Update rules.
5631         (yylex): Update.
5632         * go-exp.y (lex_one_token): Update.
5633         Update rules.
5634         (classify_unsafe_function, classify_packaged_name)
5635         (classify_name, yylex): Update.
5636
5637 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5638
5639         * configure.ac: add --enable-source-highlight switch.
5640         * configure: Regenerate.
5641         * top.c (print_gdb_version): plumb --enable-source-highlight
5642         status to "show configuration".
5643
5644 2019-04-19  Tom Tromey  <tromey@adacore.com>
5645
5646         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5647         Check ADA_TYPE_P.
5648         (empty_record, ada_template_to_fixed_record_type_1)
5649         (template_to_static_fixed_type)
5650         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5651         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5652         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5653         macros.
5654
5655 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5656
5657         PR symtab/24423:
5658         * source.c (print_source_lines_base): Advance "iter" when a
5659         control character is seen.
5660
5661 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5662
5663         * inferior.h (struct infcall_suspend_state_deleter):
5664         Catch exception in destructor to avoid crash.
5665
5666 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5667
5668         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5669         close to the add_com "shell".
5670
5671 2019-04-18  Tom Tromey  <tromey@adacore.com>
5672
5673         * process-stratum-target.h (class process_stratum_target)
5674         <stratum>: Add "final".
5675
5676 2019-04-17  Tom Tromey  <tromey@adacore.com>
5677
5678         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5679         against nullptr before use.
5680
5681 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5682
5683         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5684
5685 2019-04-17  Jim Wilson  <jimw@sifive.com>
5686             Andrew Burgess  <andrew.burgess@embecosm.com>
5687
5688         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5689         code read might fail, assume 4-byte breakpoint in that case.
5690
5691 2019-04-15  Leszek Swirski  <leszeks@google.com>
5692
5693         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5694         rather than a hand-rolled POD check when checking for forced MEMORY
5695         classification.
5696
5697 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5698
5699         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5700         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5701         function.
5702         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5703         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5704         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5705         declaration.
5706
5707 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5708
5709         * aarch64-linux-nat.c
5710         (aarch64_linux_nat_target::thread_architecture): Add override.
5711         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5712         each VQ.
5713
5714 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5715
5716         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5717
5718 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5719
5720         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5721         target types of size 96-bits, add some additional comments, and
5722         check that the builtin type we found was the correct size.
5723
5724 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5725
5726         * utils.c (prompt_for_continue): Don't restore the styling at the
5727         end, as applied_style has the wrong value.  This fixes styling in
5728         long lists of file names that are interrupted by the "Continue?"
5729         prompt.
5730
5731 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5732
5733         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5734         * c-lang.c (c_language_defn): Likewise.
5735         (cplus_language_defn): Likewise.
5736         (asm_language_defn): Likewise.
5737         (minimal_language_defn): Likewise.
5738         * d-lang.c (d_language_defn): Likewise.
5739         * f-lang.c (f_language_defn): Likewise.
5740         * go-lang.c (go_language_defn): Likewise.
5741         * language.c (unknown_language_defn): Likewise.
5742         (auto_language_defn): Likewise.
5743         * language.h (struct language_defn): Remove la_magic field.
5744         (LANG_MAGIC): Delete.
5745         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5746         * objc-lang.c (objc_language_defn): Likewise.
5747         * opencl-lang.c (opencl_language_defn): Likewise.
5748         * p-lang.c (pascal_language_defn): Likewise.
5749         * rust-lang.c (rust_language_defn): Likewise.
5750
5751 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5752
5753         * riscv-tdep.c (riscv_type_align): New function.
5754         (riscv_type_alignment): Delete.
5755         (riscv_arg_location): Use 'type_align'.
5756         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5757
5758 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5759
5760         * gdbtypes.c (type_align): A struct with no non-static fields also
5761         has alignment of 1.
5762
5763 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5764
5765         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5766         component to 0.
5767         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5768         member.
5769         (riscv_struct_info::analyse): New implementation using new
5770         analyse_inner member function.
5771         (riscv_struct_info::field_offset): New member function.
5772         (riscv_struct_info::m_offsets): New member variable.
5773         (riscv_struct_info::analyse_inner): New private member function,
5774         takes the old implementation of riscv_struct_info::analyse but
5775         extended to track field offsets.
5776         (riscv_call_arg_struct): Update the struct folding special cases
5777         to handle cases where empty C++ structs, which are non-zero
5778         length, are found.
5779         (riscv_arg_location): Initialise the length of each location, a
5780         non-zero length now indicates the location is in use.
5781         (riscv_push_dummy_call): Allow for the first location having a
5782         non-zero offset when setting up arguments.
5783         (riscv_return_value): Likewise, but for return values.
5784
5785 2019-04-11  Tom Tromey  <tromey@adacore.com>
5786
5787         * utils.c (internal_vproblem): Make "msg" const.
5788
5789 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5790
5791         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5792         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5793         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5794         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5795
5796 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5797
5798         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5799         function.
5800         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5801         of amd64_collect_native_gregset.
5802         (amd64_linux_nat_target::store_registers): Likewise.
5803
5804 2019-04-10  Tom Tromey  <tom@tromey.com>
5805
5806         * symtab.c (lookup_global_symbol_from_objfile)
5807         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5808         * objfiles.h (class separate_debug_iterator): New.
5809         (class separate_debug_range): New.
5810         (struct objfile) <separate_debug_objfiles>: New method.
5811         (objfile_separate_debug_iterate): Don't declare.
5812         * objfiles.c (separate_debug_iterator::operator++): Rename from
5813         objfile_separate_debug_iterate.
5814         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5815         iterator.
5816         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5817         iterator.
5818
5819 2019-04-10  Tom Tromey  <tom@tromey.com>
5820
5821         * symfile.c (reread_symbols): Remove old comment.
5822         * objfiles.c (free_all_objfiles): Fix a typo.
5823
5824 2019-04-10  Tom Tromey  <tom@tromey.com>
5825
5826         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5827         * minsyms.c (lookup_minimal_symbol): Use foreach.
5828         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5829         (lookup_minimal_symbol_solib_trampoline): Likewise.
5830         * symfile.c (reread_symbols): Use foreach.
5831
5832 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5833             Tom Tromey  <tromey@adacore.com>
5834
5835         PR rust/24414:
5836         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5837         (rust_lex_int_test): Change "value" to be LONGEST.
5838         (rust_lex_tests): Add test for long integer literal.
5839
5840 2019-04-09  Tom Tromey  <tromey@adacore.com>
5841
5842         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5843         to bool.
5844         (extended_remote_target::attach): Update.
5845         (remote_target::remote_notice_new_inferior): Update.
5846         (remote_target::add_current_inferior_and_thread): Update.
5847         * inferior.c (exit_inferior_1): Use "false".
5848         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5849
5850 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5851
5852         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5853         the "start" command.
5854
5855 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5856
5857         * python/py-inferior.c (infpy_thread_from_thread_handle):
5858         Adjust comments to reflect renaming of thread_from_thread_handle
5859         to thread_from_handle.  Adjust keywords.  Fix type error message.
5860         (inferior_object_methods): Add thread_from_handle.  Retain
5861         thread_from_thread_handle, but mark it as deprecated.
5862
5863 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5864
5865         * gdbthread.h (find_thread_by_handle): Revise declaration.
5866         * thread.c (find_thread_by_handle): Likewise.  Adjust
5867         implementation too.
5868         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5869         support for buffer objects as handles.
5870
5871 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5872
5873         * python/py-infthread.c (thpy_thread_handle): New function.
5874         (thread_object_methods): Register thpy_thread_handle.
5875
5876 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5877
5878         * gdbthread.h (thread_to_thread_handle): Declare.
5879         * thread.c (gdbtypes.h): Include.
5880         (thread_to_thread_handle): New function.
5881
5882         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5883         (target_thread_info_to_thread_handle): Declare.
5884         * target.c (target_thread_info_to_thread_handle): New function.
5885         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5886         * target-delegates.c: Regenerate.
5887
5888         * linux-thread-db.c (class thread_db_target): Add method
5889         thread_info_to_thread_handle.
5890         (thread_db_target::thread_info_to_thread_handle): Define.
5891         * remote.c (class remote_target): Add new method
5892         thread_info_to_thread_handle.
5893         (remote_target::thread_info_to_thread_handle): Define.
5894
5895 2019-04-08  Pedro Alves  <palves@redhat.com>
5896
5897         * common/common-exceptions.c (throw_exception): Don't create
5898         named object to throw; throw directly.
5899         (throw_it): Likewise.  Don't initialize gdb_exception::message
5900         here, with new; pass FMT and AP to the ctor instead.
5901         * common/common-exceptions.h: Include <string>.
5902         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5903         const char *, va_list)): New ctor.  Use std::make_shared.
5904         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5905         errors)): Delete.
5906         (gdb_exception_error::gdb_exception_error(enum errors, const char
5907         *, va_list)): New.
5908         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5909         Add assertion.
5910         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5911         errors)): Delete.
5912         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5913         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5914         Add assertion.
5915
5916 2019-04-08  Tom Tromey  <tom@tromey.com>
5917
5918         * valops.c (value_rtti_indirect_type): Replace throw_exception
5919         with throw.
5920         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5921         with throw.
5922         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5923         throw.
5924         * target.c (target_translate_tls_address): Replace throw_exception
5925         with throw.
5926         * stack.c (frame_apply_command_count): Replace throw_exception
5927         with throw.
5928         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5929         throw.
5930         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5931         with throw.
5932         * rs6000-tdep.c (rs6000_frame_cache)
5933         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5934         * remote.c: Replace throw_exception with throw.
5935         * record-full.c (record_full_message, record_full_wait_1)
5936         (record_full_restore): Replace throw_exception with throw.
5937         * record-btrace.c:
5938         (get_thread_current_frame_id, record_btrace_start_replaying)
5939         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5940         (cmd_record_btrace_start): Replace throw_exception with throw.
5941         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5942         throw.
5943         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5944         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5945         * linespec.c:
5946         (find_linespec_symbols): Replace throw_exception with throw.
5947         * infrun.c (displaced_step_prepare, resume): Replace
5948         throw_exception with throw.
5949         * infcmd.c (post_create_inferior): Replace throw_exception with
5950         throw.
5951         * inf-loop.c (inferior_event_handler): Replace throw_exception
5952         with throw.
5953         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5954         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5955         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5956         (get_prev_frame_always, get_frame_pc_if_available)
5957         (get_frame_address_in_block_if_available, get_frame_language):
5958         Replace throw_exception with throw.
5959         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5960         throw_exception with throw.
5961         * eval.c (fetch_subexp_value, evaluate_var_value)
5962         (evaluate_funcall, evaluate_subexp_standard): Replace
5963         throw_exception with throw.
5964         * dwarf2loc.c (call_site_find_chain)
5965         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5966         Replace throw_exception with throw.
5967         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5968         with throw.
5969         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5970         throw.
5971         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5972         * completer.c (complete_line_internal): Replace throw_exception
5973         with throw.
5974         * compile/compile-object-run.c (compile_object_run): Replace
5975         throw_exception with throw.
5976         * cli/cli-script.c (process_next_line): Replace throw_exception
5977         with throw.
5978         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5979         (btrace_enable, btrace_maint_update_pt_packets): Replace
5980         throw_exception with throw.
5981         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5982         throw_exception with throw.
5983         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5984         throw_exception with throw.
5985         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5986         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5987         * aarch64-tdep.c (aarch64_make_prologue_cache)
5988         (aarch64_make_stub_cache): Replace throw_exception with throw.
5989
5990 2019-04-08  Tom Tromey  <tom@tromey.com>
5991
5992         * common/common-exceptions.c (throw_exception): Rename from
5993         throw_exception_cxx.  Remove old copy.  Make argument const.
5994         (throw_it): Create and throw exception objects directly.
5995         * common/common-exceptions.h (throw_exception): Make argument
5996         const.
5997         (struct gdb_exception_error): Add constructor.
5998         (struct gdb_exception_quit): Add constructor.
5999
6000 2019-04-08  Tom Tromey  <tom@tromey.com>
6001
6002         * common/common-exceptions.h (exception_rethrow): Don't declare.
6003         (TRY_SJLJ): Update comment.
6004         (TRY, CATCH, END_CATCH): Remove.
6005         * common/common-exceptions.c (exception_rethrow): Remove.
6006
6007 2019-04-08  Tom Tromey  <tom@tromey.com>
6008
6009         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6010         Remove.
6011         (gdb_exception_error): Rename from
6012         gdb_exception_RETURN_MASK_ERROR.
6013         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6014         (gdb_quit_bad_alloc): Update.
6015         * aarch64-tdep.c: Update.
6016         * ada-lang.c: Update.
6017         * ada-typeprint.c: Update.
6018         * ada-valprint.c: Update.
6019         * amd64-tdep.c: Update.
6020         * arch-utils.c: Update.
6021         * break-catch-throw.c: Update.
6022         * breakpoint.c: Update.
6023         * btrace.c: Update.
6024         * c-varobj.c: Update.
6025         * cli/cli-cmds.c: Update.
6026         * cli/cli-interp.c: Update.
6027         * cli/cli-script.c: Update.
6028         * common/common-exceptions.c: Update.
6029         * common/new-op.c: Update.
6030         * common/selftest.c: Update.
6031         * compile/compile-c-symbols.c: Update.
6032         * compile/compile-cplus-symbols.c: Update.
6033         * compile/compile-object-load.c: Update.
6034         * compile/compile-object-run.c: Update.
6035         * completer.c: Update.
6036         * corelow.c: Update.
6037         * cp-abi.c: Update.
6038         * cp-support.c: Update.
6039         * cp-valprint.c: Update.
6040         * darwin-nat.c: Update.
6041         * disasm-selftests.c: Update.
6042         * dtrace-probe.c: Update.
6043         * dwarf-index-cache.c: Update.
6044         * dwarf-index-write.c: Update.
6045         * dwarf2-frame-tailcall.c: Update.
6046         * dwarf2-frame.c: Update.
6047         * dwarf2loc.c: Update.
6048         * dwarf2read.c: Update.
6049         * eval.c: Update.
6050         * event-loop.c: Update.
6051         * event-top.c: Update.
6052         * exec.c: Update.
6053         * f-valprint.c: Update.
6054         * fbsd-tdep.c: Update.
6055         * frame-unwind.c: Update.
6056         * frame.c: Update.
6057         * gdbtypes.c: Update.
6058         * gnu-v3-abi.c: Update.
6059         * guile/guile-internal.h: Update.
6060         * guile/scm-block.c: Update.
6061         * guile/scm-breakpoint.c: Update.
6062         * guile/scm-cmd.c: Update.
6063         * guile/scm-disasm.c: Update.
6064         * guile/scm-frame.c: Update.
6065         * guile/scm-lazy-string.c: Update.
6066         * guile/scm-math.c: Update.
6067         * guile/scm-param.c: Update.
6068         * guile/scm-ports.c: Update.
6069         * guile/scm-pretty-print.c: Update.
6070         * guile/scm-symbol.c: Update.
6071         * guile/scm-symtab.c: Update.
6072         * guile/scm-type.c: Update.
6073         * guile/scm-value.c: Update.
6074         * i386-linux-tdep.c: Update.
6075         * i386-tdep.c: Update.
6076         * inf-loop.c: Update.
6077         * infcall.c: Update.
6078         * infcmd.c: Update.
6079         * infrun.c: Update.
6080         * jit.c: Update.
6081         * language.c: Update.
6082         * linespec.c: Update.
6083         * linux-fork.c: Update.
6084         * linux-nat.c: Update.
6085         * linux-tdep.c: Update.
6086         * linux-thread-db.c: Update.
6087         * main.c: Update.
6088         * mi/mi-cmd-break.c: Update.
6089         * mi/mi-cmd-stack.c: Update.
6090         * mi/mi-interp.c: Update.
6091         * mi/mi-main.c: Update.
6092         * objc-lang.c: Update.
6093         * p-valprint.c: Update.
6094         * parse.c: Update.
6095         * ppc-linux-tdep.c: Update.
6096         * printcmd.c: Update.
6097         * python/py-arch.c: Update.
6098         * python/py-breakpoint.c: Update.
6099         * python/py-cmd.c: Update.
6100         * python/py-finishbreakpoint.c: Update.
6101         * python/py-frame.c: Update.
6102         * python/py-framefilter.c: Update.
6103         * python/py-gdb-readline.c: Update.
6104         * python/py-inferior.c: Update.
6105         * python/py-infthread.c: Update.
6106         * python/py-lazy-string.c: Update.
6107         * python/py-linetable.c: Update.
6108         * python/py-objfile.c: Update.
6109         * python/py-param.c: Update.
6110         * python/py-prettyprint.c: Update.
6111         * python/py-progspace.c: Update.
6112         * python/py-record-btrace.c: Update.
6113         * python/py-record.c: Update.
6114         * python/py-symbol.c: Update.
6115         * python/py-type.c: Update.
6116         * python/py-unwind.c: Update.
6117         * python/py-utils.c: Update.
6118         * python/py-value.c: Update.
6119         * python/python.c: Update.
6120         * record-btrace.c: Update.
6121         * record-full.c: Update.
6122         * remote-fileio.c: Update.
6123         * remote.c: Update.
6124         * riscv-tdep.c: Update.
6125         * rs6000-aix-tdep.c: Update.
6126         * rs6000-tdep.c: Update.
6127         * rust-exp.y: Update.
6128         * rust-lang.c: Update.
6129         * s390-tdep.c: Update.
6130         * selftest-arch.c: Update.
6131         * solib-dsbt.c: Update.
6132         * solib-frv.c: Update.
6133         * solib-spu.c: Update.
6134         * solib-svr4.c: Update.
6135         * solib.c: Update.
6136         * sparc64-linux-tdep.c: Update.
6137         * stack.c: Update.
6138         * symfile-mem.c: Update.
6139         * symmisc.c: Update.
6140         * target.c: Update.
6141         * thread.c: Update.
6142         * top.c: Update.
6143         * tracefile-tfile.c: Update.
6144         * tui/tui.c: Update.
6145         * typeprint.c: Update.
6146         * unittests/cli-utils-selftests.c: Update.
6147         * unittests/parse-connection-spec-selftests.c: Update.
6148         * valops.c: Update.
6149         * valprint.c: Update.
6150         * value.c: Update.
6151         * varobj.c: Update.
6152         * windows-nat.c: Update.
6153         * x86-linux-nat.c: Update.
6154         * xml-support.c: Update.
6155
6156 2019-04-08  Tom Tromey  <tom@tromey.com>
6157
6158         * xml-support.c: Use C++ exception handling.
6159         * x86-linux-nat.c: Use C++ exception handling.
6160         * windows-nat.c: Use C++ exception handling.
6161         * varobj.c: Use C++ exception handling.
6162         * value.c: Use C++ exception handling.
6163         * valprint.c: Use C++ exception handling.
6164         * valops.c: Use C++ exception handling.
6165         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6166         handling.
6167         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6168         * typeprint.c: Use C++ exception handling.
6169         * tui/tui.c: Use C++ exception handling.
6170         * tracefile-tfile.c: Use C++ exception handling.
6171         * top.c: Use C++ exception handling.
6172         * thread.c: Use C++ exception handling.
6173         * target.c: Use C++ exception handling.
6174         * symmisc.c: Use C++ exception handling.
6175         * symfile-mem.c: Use C++ exception handling.
6176         * stack.c: Use C++ exception handling.
6177         * sparc64-linux-tdep.c: Use C++ exception handling.
6178         * solib.c: Use C++ exception handling.
6179         * solib-svr4.c: Use C++ exception handling.
6180         * solib-spu.c: Use C++ exception handling.
6181         * solib-frv.c: Use C++ exception handling.
6182         * solib-dsbt.c: Use C++ exception handling.
6183         * selftest-arch.c: Use C++ exception handling.
6184         * s390-tdep.c: Use C++ exception handling.
6185         * rust-lang.c: Use C++ exception handling.
6186         * rust-exp.y: Use C++ exception handling.
6187         * rs6000-tdep.c: Use C++ exception handling.
6188         * rs6000-aix-tdep.c: Use C++ exception handling.
6189         * riscv-tdep.c: Use C++ exception handling.
6190         * remote.c: Use C++ exception handling.
6191         * remote-fileio.c: Use C++ exception handling.
6192         * record-full.c: Use C++ exception handling.
6193         * record-btrace.c: Use C++ exception handling.
6194         * python/python.c: Use C++ exception handling.
6195         * python/py-value.c: Use C++ exception handling.
6196         * python/py-utils.c: Use C++ exception handling.
6197         * python/py-unwind.c: Use C++ exception handling.
6198         * python/py-type.c: Use C++ exception handling.
6199         * python/py-symbol.c: Use C++ exception handling.
6200         * python/py-record.c: Use C++ exception handling.
6201         * python/py-record-btrace.c: Use C++ exception handling.
6202         * python/py-progspace.c: Use C++ exception handling.
6203         * python/py-prettyprint.c: Use C++ exception handling.
6204         * python/py-param.c: Use C++ exception handling.
6205         * python/py-objfile.c: Use C++ exception handling.
6206         * python/py-linetable.c: Use C++ exception handling.
6207         * python/py-lazy-string.c: Use C++ exception handling.
6208         * python/py-infthread.c: Use C++ exception handling.
6209         * python/py-inferior.c: Use C++ exception handling.
6210         * python/py-gdb-readline.c: Use C++ exception handling.
6211         * python/py-framefilter.c: Use C++ exception handling.
6212         * python/py-frame.c: Use C++ exception handling.
6213         * python/py-finishbreakpoint.c: Use C++ exception handling.
6214         * python/py-cmd.c: Use C++ exception handling.
6215         * python/py-breakpoint.c: Use C++ exception handling.
6216         * python/py-arch.c: Use C++ exception handling.
6217         * printcmd.c: Use C++ exception handling.
6218         * ppc-linux-tdep.c: Use C++ exception handling.
6219         * parse.c: Use C++ exception handling.
6220         * p-valprint.c: Use C++ exception handling.
6221         * objc-lang.c: Use C++ exception handling.
6222         * mi/mi-main.c: Use C++ exception handling.
6223         * mi/mi-interp.c: Use C++ exception handling.
6224         * mi/mi-cmd-stack.c: Use C++ exception handling.
6225         * mi/mi-cmd-break.c: Use C++ exception handling.
6226         * main.c: Use C++ exception handling.
6227         * linux-thread-db.c: Use C++ exception handling.
6228         * linux-tdep.c: Use C++ exception handling.
6229         * linux-nat.c: Use C++ exception handling.
6230         * linux-fork.c: Use C++ exception handling.
6231         * linespec.c: Use C++ exception handling.
6232         * language.c: Use C++ exception handling.
6233         * jit.c: Use C++ exception handling.
6234         * infrun.c: Use C++ exception handling.
6235         * infcmd.c: Use C++ exception handling.
6236         * infcall.c: Use C++ exception handling.
6237         * inf-loop.c: Use C++ exception handling.
6238         * i386-tdep.c: Use C++ exception handling.
6239         * i386-linux-tdep.c: Use C++ exception handling.
6240         * guile/scm-value.c: Use C++ exception handling.
6241         * guile/scm-type.c: Use C++ exception handling.
6242         * guile/scm-symtab.c: Use C++ exception handling.
6243         * guile/scm-symbol.c: Use C++ exception handling.
6244         * guile/scm-pretty-print.c: Use C++ exception handling.
6245         * guile/scm-ports.c: Use C++ exception handling.
6246         * guile/scm-param.c: Use C++ exception handling.
6247         * guile/scm-math.c: Use C++ exception handling.
6248         * guile/scm-lazy-string.c: Use C++ exception handling.
6249         * guile/scm-frame.c: Use C++ exception handling.
6250         * guile/scm-disasm.c: Use C++ exception handling.
6251         * guile/scm-cmd.c: Use C++ exception handling.
6252         * guile/scm-breakpoint.c: Use C++ exception handling.
6253         * guile/scm-block.c: Use C++ exception handling.
6254         * guile/guile-internal.h: Use C++ exception handling.
6255         * gnu-v3-abi.c: Use C++ exception handling.
6256         * gdbtypes.c: Use C++ exception handling.
6257         * frame.c: Use C++ exception handling.
6258         * frame-unwind.c: Use C++ exception handling.
6259         * fbsd-tdep.c: Use C++ exception handling.
6260         * f-valprint.c: Use C++ exception handling.
6261         * exec.c: Use C++ exception handling.
6262         * event-top.c: Use C++ exception handling.
6263         * event-loop.c: Use C++ exception handling.
6264         * eval.c: Use C++ exception handling.
6265         * dwarf2read.c: Use C++ exception handling.
6266         * dwarf2loc.c: Use C++ exception handling.
6267         * dwarf2-frame.c: Use C++ exception handling.
6268         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6269         * dwarf-index-write.c: Use C++ exception handling.
6270         * dwarf-index-cache.c: Use C++ exception handling.
6271         * dtrace-probe.c: Use C++ exception handling.
6272         * disasm-selftests.c: Use C++ exception handling.
6273         * darwin-nat.c: Use C++ exception handling.
6274         * cp-valprint.c: Use C++ exception handling.
6275         * cp-support.c: Use C++ exception handling.
6276         * cp-abi.c: Use C++ exception handling.
6277         * corelow.c: Use C++ exception handling.
6278         * completer.c: Use C++ exception handling.
6279         * compile/compile-object-run.c: Use C++ exception handling.
6280         * compile/compile-object-load.c: Use C++ exception handling.
6281         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6282         * compile/compile-c-symbols.c: Use C++ exception handling.
6283         * common/selftest.c: Use C++ exception handling.
6284         * common/new-op.c: Use C++ exception handling.
6285         * cli/cli-script.c: Use C++ exception handling.
6286         * cli/cli-interp.c: Use C++ exception handling.
6287         * cli/cli-cmds.c: Use C++ exception handling.
6288         * c-varobj.c: Use C++ exception handling.
6289         * btrace.c: Use C++ exception handling.
6290         * breakpoint.c: Use C++ exception handling.
6291         * break-catch-throw.c: Use C++ exception handling.
6292         * arch-utils.c: Use C++ exception handling.
6293         * amd64-tdep.c: Use C++ exception handling.
6294         * ada-valprint.c: Use C++ exception handling.
6295         * ada-typeprint.c: Use C++ exception handling.
6296         * ada-lang.c: Use C++ exception handling.
6297         * aarch64-tdep.c: Use C++ exception handling.
6298
6299 2019-04-08  Tom Tromey  <tom@tromey.com>
6300
6301         * xml-support.c (gdb_xml_parser::parse): Update.
6302         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6303         * value.c (show_convenience): Update.
6304         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6305         (test_parse_flags_qcs): Update.
6306         * thread.c (thr_try_catch_cmd): Update.
6307         * target.c (target_translate_tls_address): Update.
6308         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6309         (info_frame_command_core, frame_apply_command_count): Update.
6310         * rust-exp.y (rust_lex_exception_test): Update.
6311         * riscv-tdep.c (riscv_print_one_register_info): Update.
6312         * remote.c (remote_target::enable_btrace): Update.
6313         * record-btrace.c (record_btrace_enable_warn): Update.
6314         * python/py-utils.c (gdbpy_convert_exception): Update.
6315         * printcmd.c (do_one_display, print_variable_and_value): Update.
6316         * mi/mi-main.c (mi_print_exception): Update.
6317         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6318         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6319         * linux-nat.c (linux_nat_target::attach): Update.
6320         * linux-fork.c (class scoped_switch_fork_info): Update.
6321         * infrun.c (displaced_step_prepare): Update.
6322         * infcall.c (call_function_by_hand_dummy): Update.
6323         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6324         * gnu-v3-abi.c (print_one_vtable): Update.
6325         * frame.c (get_prev_frame_always): Update.
6326         * f-valprint.c (info_common_command_for_block): Update.
6327         * exec.c (try_open_exec_file): Update.
6328         * exceptions.c (print_exception, exception_print)
6329         (exception_fprintf, exception_print_same): Update.
6330         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6331         * dwarf-index-cache.c (index_cache::store)
6332         (index_cache::lookup_gdb_index): Update.
6333         * darwin-nat.c (maybe_cache_shell): Update.
6334         * cp-valprint.c (cp_print_value_fields): Update.
6335         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6336         (gcc_cplus_symbol_address): Update.
6337         * compile/compile-c-symbols.c (gcc_convert_symbol)
6338         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6339         * common/selftest.c: Update.
6340         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6341         a std::string.
6342         (exception_try_scope_entry, exception_try_scope_exit): Don't
6343         declare.
6344         (struct exception_try_scope): Remove.
6345         (TRY): Don't use exception_try_scope.
6346         (struct gdb_exception): Add constructor, operator=.
6347         <what>: New method.
6348         (struct gdb_exception_RETURN_MASK_ALL)
6349         (struct gdb_exception_RETURN_MASK_ERROR)
6350         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6351         (struct gdb_quit_bad_alloc): Update.
6352         * common/common-exceptions.c (exception_none): Change
6353         initializer.
6354         (struct catcher) <state, exception>: Initialize inline.
6355         <prev>: Remove member.
6356         (current_catcher): Remove.
6357         (catchers): New global.
6358         (exceptions_state_mc_init): Simplify.
6359         (catcher_pop): Remove.
6360         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6361         (try_scope_depth, exception_try_scope_entry)
6362         (exception_try_scope_exit): Remove.
6363         (throw_exception_sjlj): Update.
6364         (exception_messages, exception_messages_size): Remove.
6365         (throw_it): Simplify.
6366         (gdb_exception_sliced_copy): Remove.
6367         (throw_exception_cxx): Update.
6368         * cli/cli-script.c (script_from_file): Update.
6369         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6370         Update.
6371         * ada-valprint.c (ada_val_print): Update.
6372         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6373         (create_excep_cond_exprs): Update.
6374
6375 2019-04-08  Tom Tromey  <tom@tromey.com>
6376
6377         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6378         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6379         (TRY, CATCH, END_CATCH): Remove some definitions.
6380         * common/common-exceptions.c: Don't use GDB_XCPT.
6381         (catcher_list_size): Remove.
6382         (throw_exception, throw_it): Simplify.
6383
6384 2019-04-05  Tom Tromey  <tom@tromey.com>
6385
6386         Revert the header-sorting patch.
6387         * ft32-tdep.c: Revert.
6388         * frv-tdep.c: Revert.
6389         * frv-linux-tdep.c: Revert.
6390         * frame.c: Revert.
6391         * frame-unwind.c: Revert.
6392         * frame-base.c: Revert.
6393         * fork-child.c: Revert.
6394         * findvar.c: Revert.
6395         * findcmd.c: Revert.
6396         * filesystem.c: Revert.
6397         * filename-seen-cache.h: Revert.
6398         * filename-seen-cache.c: Revert.
6399         * fbsd-tdep.c: Revert.
6400         * fbsd-nat.h: Revert.
6401         * fbsd-nat.c: Revert.
6402         * f-valprint.c: Revert.
6403         * f-typeprint.c: Revert.
6404         * f-lang.c: Revert.
6405         * extension.h: Revert.
6406         * extension.c: Revert.
6407         * extension-priv.h: Revert.
6408         * expprint.c: Revert.
6409         * exec.h: Revert.
6410         * exec.c: Revert.
6411         * exceptions.c: Revert.
6412         * event-top.c: Revert.
6413         * event-loop.c: Revert.
6414         * eval.c: Revert.
6415         * elfread.c: Revert.
6416         * dwarf2read.h: Revert.
6417         * dwarf2read.c: Revert.
6418         * dwarf2loc.c: Revert.
6419         * dwarf2expr.h: Revert.
6420         * dwarf2expr.c: Revert.
6421         * dwarf2-frame.c: Revert.
6422         * dwarf2-frame-tailcall.c: Revert.
6423         * dwarf-index-write.h: Revert.
6424         * dwarf-index-write.c: Revert.
6425         * dwarf-index-common.c: Revert.
6426         * dwarf-index-cache.h: Revert.
6427         * dwarf-index-cache.c: Revert.
6428         * dummy-frame.c: Revert.
6429         * dtrace-probe.c: Revert.
6430         * disasm.h: Revert.
6431         * disasm.c: Revert.
6432         * disasm-selftests.c: Revert.
6433         * dictionary.c: Revert.
6434         * dicos-tdep.c: Revert.
6435         * demangle.c: Revert.
6436         * dcache.h: Revert.
6437         * dcache.c: Revert.
6438         * darwin-nat.h: Revert.
6439         * darwin-nat.c: Revert.
6440         * darwin-nat-info.c: Revert.
6441         * d-valprint.c: Revert.
6442         * d-namespace.c: Revert.
6443         * d-lang.c: Revert.
6444         * ctf.c: Revert.
6445         * csky-tdep.c: Revert.
6446         * csky-linux-tdep.c: Revert.
6447         * cris-tdep.c: Revert.
6448         * cris-linux-tdep.c: Revert.
6449         * cp-valprint.c: Revert.
6450         * cp-support.c: Revert.
6451         * cp-namespace.c: Revert.
6452         * cp-abi.c: Revert.
6453         * corelow.c: Revert.
6454         * corefile.c: Revert.
6455         * continuations.c: Revert.
6456         * completer.h: Revert.
6457         * completer.c: Revert.
6458         * complaints.c: Revert.
6459         * coffread.c: Revert.
6460         * coff-pe-read.c: Revert.
6461         * cli-out.h: Revert.
6462         * cli-out.c: Revert.
6463         * charset.c: Revert.
6464         * c-varobj.c: Revert.
6465         * c-valprint.c: Revert.
6466         * c-typeprint.c: Revert.
6467         * c-lang.c: Revert.
6468         * buildsym.c: Revert.
6469         * buildsym-legacy.c: Revert.
6470         * build-id.h: Revert.
6471         * build-id.c: Revert.
6472         * btrace.c: Revert.
6473         * bsd-uthread.c: Revert.
6474         * breakpoint.h: Revert.
6475         * breakpoint.c: Revert.
6476         * break-catch-throw.c: Revert.
6477         * break-catch-syscall.c: Revert.
6478         * break-catch-sig.c: Revert.
6479         * blockframe.c: Revert.
6480         * block.c: Revert.
6481         * bfin-tdep.c: Revert.
6482         * bfin-linux-tdep.c: Revert.
6483         * bfd-target.c: Revert.
6484         * bcache.c: Revert.
6485         * ax-general.c: Revert.
6486         * ax-gdb.h: Revert.
6487         * ax-gdb.c: Revert.
6488         * avr-tdep.c: Revert.
6489         * auxv.c: Revert.
6490         * auto-load.c: Revert.
6491         * arm-wince-tdep.c: Revert.
6492         * arm-tdep.c: Revert.
6493         * arm-symbian-tdep.c: Revert.
6494         * arm-pikeos-tdep.c: Revert.
6495         * arm-obsd-tdep.c: Revert.
6496         * arm-nbsd-tdep.c: Revert.
6497         * arm-nbsd-nat.c: Revert.
6498         * arm-linux-tdep.c: Revert.
6499         * arm-linux-nat.c: Revert.
6500         * arm-fbsd-tdep.c: Revert.
6501         * arm-fbsd-nat.c: Revert.
6502         * arm-bsd-tdep.c: Revert.
6503         * arch-utils.c: Revert.
6504         * arc-tdep.c: Revert.
6505         * arc-newlib-tdep.c: Revert.
6506         * annotate.h: Revert.
6507         * annotate.c: Revert.
6508         * amd64-windows-tdep.c: Revert.
6509         * amd64-windows-nat.c: Revert.
6510         * amd64-tdep.c: Revert.
6511         * amd64-sol2-tdep.c: Revert.
6512         * amd64-obsd-tdep.c: Revert.
6513         * amd64-obsd-nat.c: Revert.
6514         * amd64-nbsd-tdep.c: Revert.
6515         * amd64-nbsd-nat.c: Revert.
6516         * amd64-nat.c: Revert.
6517         * amd64-linux-tdep.c: Revert.
6518         * amd64-linux-nat.c: Revert.
6519         * amd64-fbsd-tdep.c: Revert.
6520         * amd64-fbsd-nat.c: Revert.
6521         * amd64-dicos-tdep.c: Revert.
6522         * amd64-darwin-tdep.c: Revert.
6523         * amd64-bsd-nat.c: Revert.
6524         * alpha-tdep.c: Revert.
6525         * alpha-obsd-tdep.c: Revert.
6526         * alpha-nbsd-tdep.c: Revert.
6527         * alpha-mdebug-tdep.c: Revert.
6528         * alpha-linux-tdep.c: Revert.
6529         * alpha-linux-nat.c: Revert.
6530         * alpha-bsd-tdep.c: Revert.
6531         * alpha-bsd-nat.c: Revert.
6532         * aix-thread.c: Revert.
6533         * agent.c: Revert.
6534         * addrmap.c: Revert.
6535         * ada-varobj.c: Revert.
6536         * ada-valprint.c: Revert.
6537         * ada-typeprint.c: Revert.
6538         * ada-tasks.c: Revert.
6539         * ada-lang.c: Revert.
6540         * aarch64-tdep.c: Revert.
6541         * aarch64-ravenscar-thread.c: Revert.
6542         * aarch64-newlib-tdep.c: Revert.
6543         * aarch64-linux-tdep.c: Revert.
6544         * aarch64-linux-nat.c: Revert.
6545         * aarch64-fbsd-tdep.c: Revert.
6546         * aarch64-fbsd-nat.c: Revert.
6547         * aarch32-linux-nat.c: Revert.
6548
6549 2019-04-05  Tom Tromey  <tom@tromey.com>
6550
6551         * ft32-tdep.c: Sort headers.
6552         * frv-tdep.c: Sort headers.
6553         * frv-linux-tdep.c: Sort headers.
6554         * frame.c: Sort headers.
6555         * frame-unwind.c: Sort headers.
6556         * frame-base.c: Sort headers.
6557         * fork-child.c: Sort headers.
6558         * findvar.c: Sort headers.
6559         * findcmd.c: Sort headers.
6560         * filesystem.c: Sort headers.
6561         * filename-seen-cache.h: Sort headers.
6562         * filename-seen-cache.c: Sort headers.
6563         * fbsd-tdep.c: Sort headers.
6564         * fbsd-nat.h: Sort headers.
6565         * fbsd-nat.c: Sort headers.
6566         * f-valprint.c: Sort headers.
6567         * f-typeprint.c: Sort headers.
6568         * f-lang.c: Sort headers.
6569         * extension.h: Sort headers.
6570         * extension.c: Sort headers.
6571         * extension-priv.h: Sort headers.
6572         * expprint.c: Sort headers.
6573         * exec.h: Sort headers.
6574         * exec.c: Sort headers.
6575         * exceptions.c: Sort headers.
6576         * event-top.c: Sort headers.
6577         * event-loop.c: Sort headers.
6578         * eval.c: Sort headers.
6579         * elfread.c: Sort headers.
6580         * dwarf2read.h: Sort headers.
6581         * dwarf2read.c: Sort headers.
6582         * dwarf2loc.c: Sort headers.
6583         * dwarf2expr.h: Sort headers.
6584         * dwarf2expr.c: Sort headers.
6585         * dwarf2-frame.c: Sort headers.
6586         * dwarf2-frame-tailcall.c: Sort headers.
6587         * dwarf-index-write.h: Sort headers.
6588         * dwarf-index-write.c: Sort headers.
6589         * dwarf-index-common.c: Sort headers.
6590         * dwarf-index-cache.h: Sort headers.
6591         * dwarf-index-cache.c: Sort headers.
6592         * dummy-frame.c: Sort headers.
6593         * dtrace-probe.c: Sort headers.
6594         * disasm.h: Sort headers.
6595         * disasm.c: Sort headers.
6596         * disasm-selftests.c: Sort headers.
6597         * dictionary.c: Sort headers.
6598         * dicos-tdep.c: Sort headers.
6599         * demangle.c: Sort headers.
6600         * dcache.h: Sort headers.
6601         * dcache.c: Sort headers.
6602         * darwin-nat.h: Sort headers.
6603         * darwin-nat.c: Sort headers.
6604         * darwin-nat-info.c: Sort headers.
6605         * d-valprint.c: Sort headers.
6606         * d-namespace.c: Sort headers.
6607         * d-lang.c: Sort headers.
6608         * ctf.c: Sort headers.
6609         * csky-tdep.c: Sort headers.
6610         * csky-linux-tdep.c: Sort headers.
6611         * cris-tdep.c: Sort headers.
6612         * cris-linux-tdep.c: Sort headers.
6613         * cp-valprint.c: Sort headers.
6614         * cp-support.c: Sort headers.
6615         * cp-namespace.c: Sort headers.
6616         * cp-abi.c: Sort headers.
6617         * corelow.c: Sort headers.
6618         * corefile.c: Sort headers.
6619         * continuations.c: Sort headers.
6620         * completer.h: Sort headers.
6621         * completer.c: Sort headers.
6622         * complaints.c: Sort headers.
6623         * coffread.c: Sort headers.
6624         * coff-pe-read.c: Sort headers.
6625         * cli-out.h: Sort headers.
6626         * cli-out.c: Sort headers.
6627         * charset.c: Sort headers.
6628         * c-varobj.c: Sort headers.
6629         * c-valprint.c: Sort headers.
6630         * c-typeprint.c: Sort headers.
6631         * c-lang.c: Sort headers.
6632         * buildsym.c: Sort headers.
6633         * buildsym-legacy.c: Sort headers.
6634         * build-id.h: Sort headers.
6635         * build-id.c: Sort headers.
6636         * btrace.c: Sort headers.
6637         * bsd-uthread.c: Sort headers.
6638         * breakpoint.h: Sort headers.
6639         * breakpoint.c: Sort headers.
6640         * break-catch-throw.c: Sort headers.
6641         * break-catch-syscall.c: Sort headers.
6642         * break-catch-sig.c: Sort headers.
6643         * blockframe.c: Sort headers.
6644         * block.c: Sort headers.
6645         * bfin-tdep.c: Sort headers.
6646         * bfin-linux-tdep.c: Sort headers.
6647         * bfd-target.c: Sort headers.
6648         * bcache.c: Sort headers.
6649         * ax-general.c: Sort headers.
6650         * ax-gdb.h: Sort headers.
6651         * ax-gdb.c: Sort headers.
6652         * avr-tdep.c: Sort headers.
6653         * auxv.c: Sort headers.
6654         * auto-load.c: Sort headers.
6655         * arm-wince-tdep.c: Sort headers.
6656         * arm-tdep.c: Sort headers.
6657         * arm-symbian-tdep.c: Sort headers.
6658         * arm-pikeos-tdep.c: Sort headers.
6659         * arm-obsd-tdep.c: Sort headers.
6660         * arm-nbsd-tdep.c: Sort headers.
6661         * arm-nbsd-nat.c: Sort headers.
6662         * arm-linux-tdep.c: Sort headers.
6663         * arm-linux-nat.c: Sort headers.
6664         * arm-fbsd-tdep.c: Sort headers.
6665         * arm-fbsd-nat.c: Sort headers.
6666         * arm-bsd-tdep.c: Sort headers.
6667         * arch-utils.c: Sort headers.
6668         * arc-tdep.c: Sort headers.
6669         * arc-newlib-tdep.c: Sort headers.
6670         * annotate.h: Sort headers.
6671         * annotate.c: Sort headers.
6672         * amd64-windows-tdep.c: Sort headers.
6673         * amd64-windows-nat.c: Sort headers.
6674         * amd64-tdep.c: Sort headers.
6675         * amd64-sol2-tdep.c: Sort headers.
6676         * amd64-obsd-tdep.c: Sort headers.
6677         * amd64-obsd-nat.c: Sort headers.
6678         * amd64-nbsd-tdep.c: Sort headers.
6679         * amd64-nbsd-nat.c: Sort headers.
6680         * amd64-nat.c: Sort headers.
6681         * amd64-linux-tdep.c: Sort headers.
6682         * amd64-linux-nat.c: Sort headers.
6683         * amd64-fbsd-tdep.c: Sort headers.
6684         * amd64-fbsd-nat.c: Sort headers.
6685         * amd64-dicos-tdep.c: Sort headers.
6686         * amd64-darwin-tdep.c: Sort headers.
6687         * amd64-bsd-nat.c: Sort headers.
6688         * alpha-tdep.c: Sort headers.
6689         * alpha-obsd-tdep.c: Sort headers.
6690         * alpha-nbsd-tdep.c: Sort headers.
6691         * alpha-mdebug-tdep.c: Sort headers.
6692         * alpha-linux-tdep.c: Sort headers.
6693         * alpha-linux-nat.c: Sort headers.
6694         * alpha-bsd-tdep.c: Sort headers.
6695         * alpha-bsd-nat.c: Sort headers.
6696         * aix-thread.c: Sort headers.
6697         * agent.c: Sort headers.
6698         * addrmap.c: Sort headers.
6699         * ada-varobj.c: Sort headers.
6700         * ada-valprint.c: Sort headers.
6701         * ada-typeprint.c: Sort headers.
6702         * ada-tasks.c: Sort headers.
6703         * ada-lang.c: Sort headers.
6704         * aarch64-tdep.c: Sort headers.
6705         * aarch64-ravenscar-thread.c: Sort headers.
6706         * aarch64-newlib-tdep.c: Sort headers.
6707         * aarch64-linux-tdep.c: Sort headers.
6708         * aarch64-linux-nat.c: Sort headers.
6709         * aarch64-fbsd-tdep.c: Sort headers.
6710         * aarch64-fbsd-nat.c: Sort headers.
6711         * aarch32-linux-nat.c: Sort headers.
6712
6713 2019-04-04  Tom Tromey  <tom@tromey.com>
6714
6715         * varobj.c (varobj_create): Update.
6716         * rust-exp.y (struct rust_parser) <update_innermost_block,
6717         lookup_symbol>: New methods.
6718         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6719         Rename.
6720         (rust_parser::rust_lookup_type)
6721         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6722         * printcmd.c (display_command, do_one_display): Update.
6723         * parser-defs.h (struct parser_state) <parser_state>: Add
6724         "tracker" parameter.
6725         (block_tracker): New member.
6726         (class innermost_block_tracker) <innermost_block_tracker>: Add
6727         "types" parameter.
6728         <reset>: Remove method.
6729         (innermost_block): Don't declare.
6730         (null_post_parser): Update.
6731         * parse.c (innermost_block): Remove global.
6732         (write_dollar_variable): Update.
6733         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6734         Remove "tracker_types" parameter.
6735         (parse_expression): Add "tracker" parameter.
6736         (parse_expression_for_completion): Update.
6737         (null_post_parser): Add "tracker" parameter.
6738         * p-exp.y: Update rules.
6739         * m2-exp.y: Update rules.
6740         * language.h (struct language_defn) <la_post_parser>: Add
6741         "tracker" parameter.
6742         * go-exp.y: Update rules.
6743         * f-exp.y: Update rules.
6744         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6745         parameter.
6746         * d-exp.y: Update rules.
6747         * c-exp.y: Update rules.
6748         * breakpoint.c (set_breakpoint_condition): Create an
6749         innermost_block_tracker.
6750         (watch_command_1): Likewise.
6751         * ada-lang.c (resolve): Add "tracker" parameter.
6752         (resolve_subexp): Likewise.
6753         * ada-exp.y (write_var_from_sym): Update.
6754
6755 2019-04-04  Tom Tromey  <tom@tromey.com>
6756
6757         * type-stack.h: New file.
6758         * type-stack.c: New file.
6759         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6760         type-stack.h.
6761         (insert_into_type_stack, insert_type, push_type, push_type_int)
6762         (insert_type_address_space, pop_type, pop_type_int)
6763         (pop_typelist, pop_type_stack, append_type_stack)
6764         (push_type_stack, get_type_stack, push_typelist)
6765         (follow_type_instance_flags, follow_types): Don't declare.
6766         * parse.c (type_stack): Remove global.
6767         (parse_exp_in_context): Update.
6768         (insert_into_type_stack, insert_type, push_type, push_type_int)
6769         (insert_type_address_space, pop_type, pop_type_int)
6770         (pop_typelist, pop_type_stack, append_type_stack)
6771         (push_type_stack, get_type_stack, push_typelist)
6772         (follow_type_instance_flags, follow_types): Remove (moved to
6773         type-stack.c).
6774         * f-exp.y (type_stack): New global.
6775         Update rules.
6776         (push_kind_type, f_parse): Update.
6777         * d-exp.y (type_stack): New global.
6778         Update rules.
6779         (d_parse): Update.
6780         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6781         Update rules.
6782         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6783         (HFILES_NO_SRCDIR): Add type-stack.h.
6784
6785 2019-04-04  Tom Tromey  <tom@tromey.com>
6786
6787         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6788         (rust_parser::convert_ast_to_expression, rust_parse)
6789         (rust_lex_test_completion, rust_lex_tests): Update.
6790         * parser-defs.h (struct expr_completion_state): New.
6791         (struct parser_state) <parser_state>: Add completion parameter.
6792         <mark_struct_expression, mark_completion_tag>: New methods.
6793         <parse_completion, m_completion_state>: New members.
6794         (prefixify_expression, null_post_parser): Update.
6795         (mark_struct_expression, mark_completion_tag): Don't declare.
6796         * parse.c (parse_completion, expout_last_struct)
6797         (expout_tag_completion_type, expout_completion_name): Remove
6798         globals.
6799         (parser_state::mark_struct_expression)
6800         (parser_state::mark_completion_tag): Now methods.
6801         (prefixify_expression): Add last_struct parameter.
6802         (prefixify_subexp): Likewise.
6803         (parse_exp_1): Update.
6804         (parse_exp_in_context): Add cstate parameter.  Update.
6805         (parse_expression_for_completion): Create an
6806         expr_completion_state.
6807         (null_post_parser): Add "completion" parameter.
6808         * p-exp.y: Update rules.
6809         (yylex): Update.
6810         * language.h (struct language_defn) <la_post_parser>: Add
6811         "completing" parameter.
6812         * go-exp.y: Update rules.
6813         (lex_one_token): Update.
6814         * expression.h (parse_completion): Don't declare.
6815         * d-exp.y: Update rules.
6816         (lex_one_token): Update rules.
6817         * c-exp.y: Update rules.
6818         (lex_one_token): Update.
6819         * ada-lang.c (resolve): Add "parse_completion" parameter.
6820         (resolve_subexp): Likewise.
6821         (ada_resolve_function): Likewise.
6822
6823 2019-04-04  Tom Tromey  <tom@tromey.com>
6824
6825         * parser-defs.h (struct parser_state) <start_arglist,
6826         end_arglist>: New methods.
6827         <arglist_len, m_funcall_chain>: New members.
6828         (arglist_len, start_arglist, end_arglist): Don't declare.
6829         * parse.c (arglist_len, funcall_chain): Remove global.
6830         (start_arglist, end_arglist): Remove functions.
6831         (parse_exp_in_context): Update.
6832         * p-exp.y: Update rules.
6833         * m2-exp.y: Update rules.
6834         * go-exp.y: Update rules.
6835         * f-exp.y: Update rules.
6836         * d-exp.y: Update rules.
6837         * c-exp.y: Update rules.
6838
6839 2019-04-04  Tom Tromey  <tom@tromey.com>
6840
6841         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6842         lex_operator, push_back>: New methods.
6843         Update all rules.
6844         (rust_parser::lex_hex, lex_escape): Rename and update.
6845         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6846         (rust_parser::lex_operator): Rename and update.
6847         (rust_parser::lex_number, rustyylex, rustyyerror)
6848         (rust_lex_test_init, rust_lex_test_sequence)
6849         (rust_lex_test_push_back, rust_lex_tests): Update.
6850         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6851         parameter.
6852         <lexptr, prev_lexptr>: New members.
6853         (lexptr, prev_lexptr): Don't declare.
6854         * parse.c (lexptr, prev_lexptr): Remove globals.
6855         (parse_exp_in_context): Update.
6856         * p-exp.y (yylex, yyerror): Update.
6857         * m2-exp.y (parse_number, yylex, yyerror): Update.
6858         * go-exp.y (lex_one_token, yyerror): Update.
6859         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6860         * d-exp.y (lex_one_token, yyerror): Update.
6861         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6862         (lex_one_token, yyerror): Update.
6863         * ada-lex.l (YY_INPUT): Update.
6864         (rewind_to_char): Update.
6865         * ada-exp.y (yyerror): Update.
6866
6867 2019-04-04  Tom Tromey  <tom@tromey.com>
6868
6869         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6870         * parser-defs.h (struct parser_state) <parser_state>: Add new
6871         parameter.
6872         <comma_terminates>: New member.
6873         (comma_terminates): Don't declare global.
6874         * parse.c (comma_terminates): Remove global.
6875         (parse_exp_in_context): Update.
6876         * p-exp.y (yylex): Update.
6877         * m2-exp.y (yylex): Update.
6878         * go-exp.y (lex_one_token): Update.
6879         * f-exp.y (yylex): Update.
6880         * d-exp.y (lex_one_token): Update.
6881         * c-exp.y (lex_one_token): Update.
6882         * ada-lex.l: Update.
6883
6884 2019-04-04  Tom Tromey  <tom@tromey.com>
6885
6886         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6887         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6888         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6889         * parser-defs.h (paren_depth): Don't declare.
6890         * parse.c (paren_depth): Remove global.
6891         (parse_exp_in_context): Update.
6892         * p-exp.y (paren_depth): New global.
6893         (pascal_parse): Initialize it.
6894         * m2-exp.y (paren_depth): New global.
6895         (m2_parse): Initialize it.
6896         * go-exp.y (paren_depth): New global.
6897         (go_parse): Initialize it.
6898         * f-exp.y (paren_depth): New global.
6899         (f_parse): Initialize it.
6900         * d-exp.y (paren_depth): New global.
6901         (d_parse): Initialize it.
6902         * c-exp.y (paren_depth): New global.
6903         (c_parse): Initialize it.
6904         * ada-lex.l (paren_depth): New global.
6905         (lexer_init): Initialize it.
6906
6907 2019-04-04  Tom Tromey  <tom@tromey.com>
6908
6909         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6910         (rust_parser::convert_ast_to_type)
6911         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6912         * parser-defs.h (struct parser_state) <parser_state>: Add
6913         parameters.  Initialize new members.
6914         <expression_context_block, expression_context_pc>: New members.
6915         * parse.c (expression_context_block, expression_context_pc):
6916         Remove globals.
6917         (parse_exp_in_context): Update.
6918         * p-exp.y: Update all rules.
6919         (yylex): Update.
6920         * m2-exp.y: Update all rules.
6921         (yylex): Update.
6922         * go-exp.y (yylex): Update.
6923         * f-exp.y (yylex): Update.
6924         * d-exp.y: Update all rules.
6925         (yylex): Update.
6926         * c-exp.y: Update all rules.
6927         (lex_one_token, classify_name, yylex, c_parse): Update.
6928         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6929
6930 2019-04-04  Tom Tromey  <tom@tromey.com>
6931
6932         * gdbarch.h, gdbarch.c: Rebuild.
6933         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6934         * stap-probe.h:
6935         (struct stap_parse_info): Replace "parser_state" with
6936         "expr_builder".
6937         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6938         (parser_state): New class.
6939         * parse.c (expr_builder): Rename.
6940         (expr_builder::release): Rename.
6941         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6942         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6943         (write_exp_elt_longcst, write_exp_elt_floatcst)
6944         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6945         (write_exp_string_vector, write_exp_bitstring)
6946         (write_exp_msymbol, mark_struct_expression)
6947         (write_dollar_variable)
6948         (insert_type_address_space, increase_expout_size): Replace
6949         "parser_state" with "expr_builder".
6950         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6951         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6952         "parser_state" with "expr_builder".
6953
6954 2019-04-04  Tom Tromey  <tom@tromey.com>
6955
6956         * rust-exp.y: Replace "parse_language" with method call.
6957         * p-exp.y:
6958         (yylex): Replace "parse_language" with method call.
6959         * m2-exp.y:
6960         (yylex): Replace "parse_language" with method call.
6961         * go-exp.y (classify_name): Replace "parse_language" with method
6962         call.
6963         * f-exp.y (yylex): Replace "parse_language" with method call.
6964         * d-exp.y (lex_one_token): Replace "parse_language" with method
6965         call.
6966         * c-exp.y:
6967         (lex_one_token, classify_name, yylex): Replace "parse_language"
6968         with method call.
6969         * ada-exp.y (find_primitive_type, type_char)
6970         (type_system_address): Replace "parse_language" with method call.
6971
6972 2019-04-04  Tom Tromey  <tom@tromey.com>
6973
6974         * rust-exp.y: Replace "parse_gdbarch" with method call.
6975         * parse.c (write_dollar_variable, insert_type_address_space):
6976         Replace "parse_gdbarch" with method call.
6977         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6978         call.
6979         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6980         call.
6981         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6982         "parse_gdbarch" with method call.
6983         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6984         with method call.
6985         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6986         "parse_gdbarch" with method call.
6987         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6988         "parse_gdbarch" with method call.
6989         * c-exp.y (parse_type, parse_number, classify_name): Replace
6990         "parse_gdbarch" with method call.
6991         * ada-lex.l: Replace "parse_gdbarch" with method call.
6992         * ada-exp.y (parse_type, find_primitive_type, type_char)
6993         (type_system_address): Replace "parse_gdbarch" with method call.
6994
6995 2019-04-04  Tom Tromey  <tom@tromey.com>
6996
6997         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6998         * stap-probe.c (stap_parse_argument): Update.
6999         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7000         initial_size parameter.
7001         * rust-exp.y (rust_lex_tests): Update.
7002         * parse.c (parser_state): Update.
7003         (parse_exp_in_context): Update.
7004         * parser-defs.h (struct parser_state) <parser_state>: Remove
7005         "initial_size" parameter.
7006
7007 2019-04-04  Tom Tromey  <tom@tromey.com>
7008
7009         * parser-defs.h (increase_expout_size): Don't declare.
7010         * parse.c (increase_expout_size): Now static.
7011
7012 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7013
7014         * gnu-nat.c (gnu_nat_target::wait): Fix
7015         target_waitstatus_to_string call.
7016
7017 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7018
7019         * eval.c (evaluate_subexp_standard): Handle internal functions
7020         during Fortran function call handling.
7021
7022 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7023
7024         * NEWS: Mention new internal functions.
7025         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7026         (read_base_type): Use dwarf2_init_complex_target_type.
7027         * value.c (creal_internal_fn): New function.
7028         (cimag_internal_fn): New function.
7029         (_initialize_values): Register new internal functions.
7030
7031 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7032
7033         * infrun.c (stop_all_threads): If debug_infrun, always
7034         trace the wait status after wait_one, using
7035         target_waitstatus_to_string and target_pid_to_str.
7036         (handle_inferior_event): Replace various trace of
7037         wait status kind by a single trace.
7038         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7039         wait status kind image by target_waitstatus_to_string.
7040         * target/waitstatus.c (target_waitstatus_to_string): Fix
7041         obsolete comment.
7042
7043 2019-04-01  Tom Tromey  <tromey@adacore.com>
7044
7045         PR symtab/23331:
7046         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7047
7048 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7049             Pedro Alves  <palves@redhat.com>
7050
7051         * top.c (quit_force): Call 'finalize_values'.
7052         * value.c (finalize_values): New function.
7053         * value.h (finalize_values): Declare.
7054
7055 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7056
7057         * NEWS: Announce $_gdb_major and $_gdb_minor.
7058
7059         * top.c (init_gdb_version_vars): New function.
7060         (gdb_init): Call init_gdb_version_vars.
7061
7062 2019-03-29  Tom Tromey  <tromey@adacore.com>
7063
7064         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7065         help text.  Remove dead code.
7066
7067 2019-03-29  Keith Seitz  <keiths@redhat.com>
7068
7069         From Siddhesh Poyarekar:
7070         * f-lang.h (f77_get_upperbound): Return LONGEST.
7071         (f77_get_lowerbound): Likewise.
7072         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7073         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7074         print them.
7075         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7076         plongest to format print it.
7077         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7078         (f77_get_upperbound): Likewise.
7079         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7080         LOWER_BOUND to LONGEST.
7081         (f77_create_arrayprint_offset_tbl): Likewise.
7082
7083 2019-03-29  Keith Seitz  <keiths@redhat.com>
7084
7085         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7086         %s/pulongest for TYPE_LENGTH instead of %d in format
7087         strings.
7088         * ada-typerint.c (ada_print_type): Likewise.
7089         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7090         * compile/compile-c-support.c (generate_register_struct): Likewise.
7091         * gdbtypes.c (recursive_dump_type): Likewise.
7092         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7093         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7094         instead of %d in format strings.
7095         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7096         to std::min to ULONGEST.
7097         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7098         instead of %d in format strings.
7099         * tracepoint.c (info_scope_command): Likewise.
7100         * typeprint.c (print_offset_data::update)
7101         (print_offset_data::finish): Likewise.
7102         * xtensa-tdep.c (xtensa_store_return_value)
7103         (xtensa_push_dummy_call): Likewise.
7104
7105 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7106
7107         * windows-nat.c (display_selector): Fixed format specifications
7108         for 64-bit Cygwin.
7109
7110 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7111
7112         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7113
7114 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7115
7116         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7117         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7118         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7119         (nios2_linux_init_abi): Install it.
7120
7121 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7122
7123         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7124
7125 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7126
7127         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7128
7129 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7130             Tom Tromey  <tromey@adacore.com>
7131
7132         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7133
7134 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7135
7136         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7137         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7138         method to compute the bounds of range types. Also print "[evaluated]"
7139         if the bounds' values come from a dynamic evaluation.
7140
7141 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7142
7143         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7144         whitespace when pretty printing is on.
7145
7146 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7147
7148         * ppc-linux-nat.c: Add include.
7149
7150 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7151
7152         * NEWS: Mention AArch64 Pointer Authentication.
7153
7154 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7155
7156         * arm-linux-nat.c: Add include.
7157
7158 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7159
7160         * source-cache.c (source_cache::get_source_lines): Re-read
7161         fullname after calling open_source_file.
7162
7163 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7164
7165         * NEWS: Mention TLS support for FreeBSD.
7166
7167 2019-03-25  Tom Tromey  <tromey@adacore.com>
7168
7169         * minsyms.c (BUNCH_SIZE): Update comment.
7170         (~minimal_symbol_reader): Remove old comment.
7171         (compact_minimal_symbols): Update comment.
7172         (minimal_symbol_reader::install): Remove old comment.  Update
7173         other comments.
7174
7175 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7176
7177         * s390-linux-nat.c: Add include.
7178
7179 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7180
7181         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7182         Call linux_get_hwcap.
7183         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7184         Likewise.
7185         (aarch64_linux_get_hwcap): Remove function.
7186         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7187         declaration.
7188         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7189         linux_get_hwcap.
7190         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7191         * linux-tdep.c (linux_get_hwcap): Add function.
7192         (linux_get_hwcap2): Likewise.
7193         * linux-tdep.h (linux_get_hwcap): Add declaration.
7194         (linux_get_hwcap2): Likewise.
7195         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7196         (ppc_linux_get_hwcap2): Likewise.
7197         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7198         linux_get_hwcap.
7199         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7200         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7201         (ppc_linux_nat_target::read_description): Likewise.
7202         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7203         * s390-linux-nat.c: Likewise.
7204         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7205
7206 2019-03-24  Tom Tromey  <tom@tromey.com>
7207
7208         * ada-lang.c (standard_lookup): Simplify initialization.
7209         (ada_lookup_symbol_nonlocal): Simplify return.
7210         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7211         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7212         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7213         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7214         initialization.
7215         * solib.c (solib_global_lookup): Simplify.
7216         * symtab.c (null_block_symbol): Remove.
7217         (symbol_cache_lookup): Simplify returns.
7218         (lookup_language_this): Simplify returns.
7219         (lookup_symbol_aux): Simplify return.
7220         (lookup_local_symbol): Simplify returns.
7221         (lookup_global_symbol_from_objfile): Simplify return.
7222         (lookup_symbol_in_objfile_symtabs)
7223         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7224         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7225         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7226         * cp-namespace.c (cp_lookup_bare_symbol)
7227         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7228         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7229         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7230         (cp_lookup_symbol_via_imports): Simplify initialization.
7231         (find_symbol_in_baseclass): Likewise.
7232         * symtab.h (null_block_symbol): Remove.
7233         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7234         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7235         (d_lookup_symbol_module): Likewise.
7236         (find_symbol_in_baseclass): Simplify initialization.
7237
7238 2019-03-24  Tom Tromey  <tom@tromey.com>
7239
7240         * expression.h: Don't include symtab.h.
7241         (struct block): Forward declare.
7242
7243 2019-03-24  Tom Tromey  <tom@tromey.com>
7244
7245         * c-exp.y (typebase): Remove casts.
7246         * gdbtypes.c (lookup_unsigned_typename, )
7247         (lookup_signed_typename): Remove cast.
7248         * eval.c (parse_to_comma_and_eval): Remove cast.
7249         * parse.c (write_dollar_variable): Remove cast.
7250         * block.h (struct block) <superblock>: Now const.
7251         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7252         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7253         (map_block): Make "block" const.
7254         * symfile.h (struct quick_symbol_functions)
7255         <map_matching_symbols>: Constify block argument to "callback".
7256         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7257         const.
7258         (find_pc_sect_compunit_symtab): Make "b" const.
7259         (find_symbol_at_address): Likewise.
7260         (search_symbols): Likewise.
7261         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7262         (dw2_debug_names_lookup_symbol): Likewise.
7263         (dw2_map_matching_symbols): Update.
7264         * p-valprint.c (pascal_val_print): Remove "block".
7265         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7266         (aux_add_nonlocal_symbols): Make "block" const.
7267         (resolve_subexp): Remove cast.
7268         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7269         const.
7270         (iterate_over_file_blocks): Likewise.
7271         * f-exp.y (%union) <bval>: Remove.
7272         * coffread.c (patch_opaque_types): Make "b" const.
7273         * spu-tdep.c (spu_catch_start): Make "block" const.
7274         * c-valprint.c (print_unpacked_pointer): Remove "block".
7275         * symmisc.c (dump_symtab_1): Make "b" const.
7276         (block_depth): Make "block" const.
7277         * d-exp.y (%union) <bval>: Remove.
7278         * cp-support.h (cp_lookup_rtti_type): Update.
7279         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7280         * psymtab.c (psym_lookup_symbol): Make "block" const.
7281         (maintenance_check_psymtabs): Make "b" const.
7282         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7283         (enumerate_locals, enumerate_args): Update.
7284         * python/py-symtab.c (stpy_global_block): Make "block" const.
7285         (stpy_static_block): Likewise.
7286         * inline-frame.c (block_starting_point_at): Make "new_block"
7287         const.
7288         * block.c (find_block_in_blockvector): Make return type const.
7289         (blockvector_for_pc_sect): Make "b" const.
7290         (find_block_in_blockvector): Make "b" const.
7291
7292 2019-03-23  Tom Tromey  <tom@tromey.com>
7293
7294         * varobj.c (varobj_create): Update.
7295         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7296         * printcmd.c (display_command, do_one_display): Don't reset
7297         innermost_block.
7298         * parser-defs.h (enum innermost_block_tracker_type): Move to
7299         expression.h.
7300         (innermost_block): Update comment.
7301         * parse.c (parse_exp_1): Add tracker_types parameter.
7302         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7303         tracker_types parameter.  Reset innermost_block.
7304         (parse_exp_in_context): Remove.
7305         (parse_expression_for_completion): Update.
7306         * objfiles.c (~objfile): Don't reset expression_context_block or
7307         innermost_block.
7308         * expression.h (enum innermost_block_tracker_type): Move from
7309         parser-defs.h.
7310         (parse_exp_1): Add tracker_types parameter.
7311         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7312         reset innermost_block.
7313
7314 2019-03-23  Tom Tromey  <tom@tromey.com>
7315
7316         * objfiles.h: Include bcache.h.
7317
7318 2019-03-23  Tom Tromey  <tom@tromey.com>
7319
7320         * linespec.c (get_current_search_block): Use
7321         scoped_restore_current_language.
7322         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7323
7324 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7325             Jiong Wang  <jiong.wang@arm.com>
7326
7327         * aarch64-linux-tdep.c
7328         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7329         section.
7330         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7331
7332 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7333             Jiong Wang  <jiong.wang@arm.com>
7334
7335         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7336         instructions.
7337         (aarch64_analyze_prologue_test): Add PACIASP test.
7338         (aarch64_prologue_prev_register): Unmask PC value.
7339
7340 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7341             Jiong Wang  <jiong.wang@arm.com>
7342
7343         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7344         (aarch64_dwarf2_prev_register): Unmask PC value.
7345         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7346         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7347         DW_CFA_AARCH64_negate_ra_state.
7348         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7349
7350 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7351             Jiong Wang  <jiong.wang@arm.com>
7352
7353         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7354         registers.
7355         (aarch64_pseudo_register_name): Likewise.
7356         (aarch64_pseudo_register_type): Likewise.
7357         (aarch64_pseudo_register_reggroup_p): Likewise.
7358         (aarch64_gdbarch_init): Add pauth registers.
7359         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7360         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7361         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7362         (struct gdbarch_tdep): Add regnum for ra_state.
7363
7364 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7365             Jiong Wang  <jiong.wang@arm.com>
7366
7367         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7368
7369 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7370             Jiong Wang  <jiong.wang@arm.com>
7371
7372         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7373         function.
7374         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7375         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7376         (aarch64_gdbarch_init): Add puth registers.
7377         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7378         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7379         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7380
7381 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7382             Jiong Wang  <jiong.wang@arm.com>
7383
7384         * aarch64-linux-nat.c
7385         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7386         * aarch64-linux-tdep.c
7387         (aarch64_linux_core_read_description): Likewise.
7388         (aarch64_linux_get_hwcap): New function.
7389         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7390         (aarch64_linux_get_hwcap): New declaration.
7391
7392 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7393             Jiong Wang  <jiong.wang@arm.com>
7394
7395         * aarch64-linux-nat.c
7396         (aarch64_linux_nat_target::read_description): Add pauth param.
7397         * aarch64-linux-tdep.c
7398         (aarch64_linux_core_read_description): Likewise.
7399         * aarch64-tdep.c (struct target_desc): Add in pauth.
7400         (aarch64_read_description): Add pauth param.
7401         (aarch64_gdbarch_init): Likewise.
7402         * aarch64-tdep.h (aarch64_read_description): Likewise.
7403         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7404         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7405         * features/Makefile: Add new files.
7406         * features/aarch64-pauth.c: New file.
7407         * features/aarch64-pauth.xml: New file.
7408
7409 2019-03-20  Tom Tromey  <tromey@adacore.com>
7410
7411         * infrun.c (handle_inferior_event): Rename from
7412         handle_inferior_event_1.  Create a scoped_value_mark.
7413         (handle_inferior_event): Remove.
7414
7415 2019-03-19  Tom Tromey  <tromey@adacore.com>
7416
7417         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7418         * infrun.h (print_stop_event): Add "displays" parameter.
7419         * infrun.c (print_stop_event): Add "displays" parameter.
7420
7421 2019-03-19  Pedro Alves  <palves@redhat.com>
7422
7423         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7424         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7425         to -1.  Fix TABs vs spaces.
7426         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7427         * tui/tui-out.h (tui_ui_out) Add intro comments.
7428         <m_line, m_start_of_line>: In-class initialize, and add describing
7429         comment.
7430
7431 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7432
7433         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7434         variable names.
7435         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7436
7437 2019-03-18  Pedro Alves  <palves@redhat.com>
7438             Eli Zaretskii <eliz@gnu.org>
7439
7440         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7441         m_line and m_start_of_line.
7442
7443 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7444
7445         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7446         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7447         it returns a newline.  This fixes a regression in TU mode, whereby
7448         the next line is output on the same screen line as the user input.
7449
7450 2019-03-18  Tom Tromey  <tromey@adacore.com>
7451
7452         * minsyms.c (minimal_symbol_reader::install): Remove call to
7453         obstack_blank.
7454
7455 2019-03-18  Pedro Alves  <palves@redhat.com>
7456
7457         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7458         New globals.
7459         (apply_style): New, factored out from ...
7460         (apply_ansi_escape): ... this.  Handle reverse video mode.
7461         (tui_set_reverse_mode): New function.
7462         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7463         * tui/tui-winsource.c (tui_show_source_line): Use
7464         tui_set_reverse_mode instead of setting A_STANDOUT.
7465         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7466         New setter methods.
7467
7468 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7469
7470         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7471         Handle tabs.
7472
7473 2019-03-18  Tom Tromey  <tromey@adacore.com>
7474
7475         * ada-lang.c (empty_array): Add "high" parameter.
7476         (ada_evaluate_subexp): Update.
7477
7478 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7479
7480         * unittests/string_view-selftests.c: Define
7481         _initialize_string_view_selftests unconditionally.
7482
7483 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7484
7485         PR gdb/24350
7486         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7487
7488 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7489
7490         PR gdb/24351
7491         * windows-nat.c (display_selector): Fix format specifiers.
7492
7493 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7494
7495         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7496         tui_refill_source_window instead of tui_refresh_win, to update the
7497         current execution line.  This fixes redisplay of the current line
7498         when stepping through the code with "next" or "step".
7499
7500 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7501
7502         * source-cache.c (source_cache::get_source_lines): Call
7503         find_source_lines to initialize s->nlines.  This fixes vertical
7504         scrolling of TUI source window when the DOWN arrow is pressed.
7505
7506 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7507
7508         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7509         linux-thread-db.c (_initialize_thread_db): Likewise.
7510
7511 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7512
7513         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7514         wclrtoeol in tui_show_source_line".  This reverts changes made in
7515         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7516
7517 2019-03-15  Tom Tromey  <tom@tromey.com>
7518
7519         * symtab.h (struct minimal_symbol): Derive from
7520         general_symbol_info.
7521         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7522         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7523         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7524         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7525         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7526         (MSYMBOL_SEARCH_NAME): Update.
7527         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7528         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7529         * minsyms.c (minimal_symbol_reader::record_full): Update.
7530
7531 2019-03-15  Tom Tromey  <tom@tromey.com>
7532
7533         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7534
7535 2019-03-15  Tom Tromey  <tom@tromey.com>
7536
7537         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7538         unique_xmalloc_ptr.
7539         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7540         Update.
7541         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7542         (build_minimal_symbol_hash_tables)
7543         (minimal_symbol_reader::install): Update.
7544
7545 2019-03-15  Tom Tromey  <tom@tromey.com>
7546
7547         * symtab.c (create_demangled_names_hash): Update.
7548         (symbol_set_names): Update.
7549         * objfiles.h (struct objfile_per_bfd_storage)
7550         <demangled_names_hash>: Now an htab_up.
7551         * objfiles.c (objfile_per_bfd_storage): Simplify.
7552
7553 2019-03-15  Tom Tromey  <tom@tromey.com>
7554
7555         * objfiles.h (struct objfile_per_bfd_storage): Declare
7556         destructor.
7557         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7558         New.
7559         (get_objfile_bfd_data): Use new.  Don't initialize
7560         language_of_main.
7561         (free_objfile_per_bfd_storage): Remove.
7562         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7563
7564 2019-03-15  Tom Tromey  <tom@tromey.com>
7565
7566         * symfile.c (reread_symbols): Update.
7567         * objfiles.c (objfile::objfile): Update.
7568         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7569         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7570         comment.
7571         (minimal_symbol_reader::install): Update.
7572         (terminate_minimal_symbol_table): Remove.
7573         * jit.c (jit_object_close_impl): Update.
7574
7575 2019-03-15  Tom Tromey  <tom@tromey.com>
7576
7577         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7578         initializations.
7579
7580 2019-03-15  Tom Tromey  <tom@tromey.com>
7581
7582         * objfiles.h (struct objfile_per_bfd_storage)
7583         <demangled_hash_languages>: Now a bitset.
7584         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7585         (lookup_minimal_symbol): Update.
7586
7587 2019-03-15  Tom Tromey  <tom@tromey.com>
7588
7589         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7590         Don't return the symbol.
7591         * coffread.c (record_minimal_symbol): Use record_full.
7592
7593 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7594
7595         The MS-Windows port of ncurses fails to switch to a color pair if
7596         one or both of the colors are the implicit default colors.  This
7597         change records the default colors when TUI is initialized, and
7598         then specifies them explicitly when a color pair uses the default
7599         colors.  This allows color styling in TUI mode on MS-Windows.
7600
7601         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7602         ncurses_norm_attr.
7603         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7604         colors in ncurses_norm_attr.
7605         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7606         "none", replace it with the default color recorded in
7607         ncurses_norm_attr.
7608
7609 2019-03-14  Tom Tromey  <tromey@adacore.com>
7610
7611         * source-cache.h (class source_cache) <get_source_lines>: Return
7612         std::string.
7613         * source-cache.c (source_cache::extract_lines): Handle case where
7614         first_pos==npos.  Return std::string.
7615         (source_cache::get_source_lines): Update.
7616
7617 2019-03-14  Tom Tromey  <tromey@adacore.com>
7618
7619         * NEWS: Add item for "style sources" commands.
7620         * source-cache.c (source_cache::get_source_lines): Check
7621         source_styling.
7622         * cli/cli-style.c (source_styling): New global.
7623         (_initialize_cli_style): Add "style sources" commands.
7624         (show_style_sources): New function.
7625         * cli/cli-style.h (source_styling): Declare.
7626
7627 2019-03-14  Pedro Alves  <palves@redhat.com>
7628             Tom Tromey  <tromey@adacore.com>
7629
7630         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7631         * tui/tui-winsource.c (tui_refill_source_window): New function,
7632         from...
7633         (tui_horizontal_source_scroll): ... here.  Move some logic.
7634         * cli/cli-style.c (set_style_enabled): Notify new observable.
7635         * tui/tui-hooks.c (tui_redisplay_source): New function.
7636         (tui_attach_detach_observers): Attach or detach
7637         tui_redisplay_source.
7638         * observable.h (source_styling_changed): New observable.
7639         * observable.c: Define source_styling_changed observable.
7640
7641 2019-03-13  Tom Tromey  <tromey@adacore.com>
7642
7643         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7644         (i386_gnu_nat_target::store_registers): Update.
7645         * target-debug.h (target_debug_print_std_string): New macro.
7646         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7647         * windows-tdep.c (display_one_tib): Update.
7648         * tui/tui-stack.c (tui_make_status_line): Update.
7649         * top.c (print_inferior_quit_action): Update.
7650         * thread.c (thr_try_catch_cmd): Update.
7651         (add_thread_with_info): Update.
7652         (thread_target_id_str): Update.
7653         (thr_try_catch_cmd): Update.
7654         (thread_command): Update.
7655         (thread_find_command): Update.
7656         * record-btrace.c (record_btrace_target::info_record)
7657         (record_btrace_resume_thread, record_btrace_target::resume)
7658         (record_btrace_cancel_resume, record_btrace_step_thread)
7659         (record_btrace_target::wait, record_btrace_target::wait)
7660         (record_btrace_target::wait, record_btrace_target::stop): Update.
7661         * progspace.c (print_program_space): Update.
7662         * process-stratum-target.c
7663         (process_stratum_target::thread_address_space): Update.
7664         * linux-fork.c (linux_fork_mourn_inferior)
7665         (detach_checkpoint_command, info_checkpoints_command)
7666         (linux_fork_context): Update.
7667         (linux_fork_detach): Update.
7668         (class scoped_switch_fork_info): Update.
7669         (delete_checkpoint_command): Update.
7670         * infrun.c (follow_fork_inferior): Update.
7671         (follow_fork_inferior): Update.
7672         (proceed_after_vfork_done): Update.
7673         (handle_vfork_child_exec_or_exit): Update.
7674         (follow_exec): Update.
7675         (displaced_step_prepare_throw): Update.
7676         (displaced_step_restore): Update.
7677         (start_step_over): Update.
7678         (resume_1): Update.
7679         (clear_proceed_status_thread): Update.
7680         (proceed): Update.
7681         (print_target_wait_results): Update.
7682         (do_target_wait): Update.
7683         (context_switch): Update.
7684         (stop_all_threads): Update.
7685         (restart_threads): Update.
7686         (finish_step_over): Update.
7687         (handle_signal_stop): Update.
7688         (switch_back_to_stepped_thread): Update.
7689         (keep_going_pass_signal): Update.
7690         (print_exited_reason): Update.
7691         (normal_stop): Update.
7692         * inferior.c (inferior_pid_to_str): Change return type.
7693         (print_selected_inferior): Update.
7694         (add_inferior): Update.
7695         (detach_inferior): Update.
7696         * dummy-frame.c (fprint_dummy_frames): Update.
7697         * dcache.c (dcache_info_1): Update.
7698         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7699         (btrace_fetch, btrace_clear): Update.
7700         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7701         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7702         type.
7703         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7704         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7705         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7706         * gdbarch.c, gdbarch.h: Rebuild.
7707         * gdbarch.sh (core_pid_to_str): Change return type.
7708         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7709         return type.
7710         (windows_nat_target::pid_to_str): Change return type.
7711         (windows_delete_thread): Update.
7712         (windows_nat_target::attach): Update.
7713         (windows_nat_target::files_info): Update.
7714         * target-delegates.c: Rebuild.
7715         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7716         return type.
7717         (sol_thread_target::pid_to_str): Change return type.
7718         * remote.c (class remote_target) <pid_to_str>: Change return
7719         type.
7720         (remote_target::pid_to_str): Change return type.
7721         (extended_remote_target::attach, remote_target::remote_stop_ns)
7722         (remote_target::remote_notif_remove_queued_reply)
7723         (remote_target::push_stop_reply, remote_target::disable_btrace):
7724         Update.
7725         (extended_remote_target::attach): Update.
7726         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7727         type.
7728         (gdbsim_target::pid_to_str): Change return type.
7729         * ravenscar-thread.c (struct ravenscar_thread_target)
7730         <pid_to_str>: Change return type.
7731         (ravenscar_thread_target::pid_to_str): Change return type.
7732         * procfs.c (class procfs_target) <pid_to_str>: Change return
7733         type.
7734         (procfs_target::pid_to_str): Change return type.
7735         (procfs_target::attach): Update.
7736         (procfs_target::detach): Update.
7737         (procfs_target::fetch_registers): Update.
7738         (procfs_target::store_registers): Update.
7739         (procfs_target::wait): Update.
7740         (procfs_target::files_info): Update.
7741         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7742         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7743         return type.
7744         (nto_procfs_target::pid_to_str): Change return type.
7745         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7746         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7747         return type.
7748         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7749         (exit_lwp): Update.
7750         (attach_proc_task_lwp_callback, get_detach_signal)
7751         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7752         (linux_nat_target::resume, wait_lwp, stop_callback)
7753         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7754         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7755         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7756         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7757         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7758         type.
7759         (inf_ptrace_target::attach): Update.
7760         (inf_ptrace_target::files_info): Update.
7761         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7762         type.
7763         (go32_nat_target::pid_to_str): Change return type.
7764         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7765         (gnu_nat_target::wait): Update.
7766         (gnu_nat_target::wait): Update.
7767         (gnu_nat_target::resume): Update.
7768         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7769         (fbsd_nat_target::wait): Update.
7770         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7771         type.
7772         (darwin_nat_target::attach): Update.
7773         * corelow.c (class core_target) <pid_to_str>: Change return type.
7774         (core_target::pid_to_str): Change return type.
7775         * target.c (normal_pid_to_str): Change return type.
7776         (default_pid_to_str): Likewise.
7777         (target_pid_to_str): Change return type.
7778         (target_translate_tls_address): Update.
7779         (target_announce_detach): Update.
7780         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7781         return type.
7782         (bsd_uthread_target::pid_to_str): Change return type.
7783         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7784         type.
7785         (bsd_kvm_target::pid_to_str): Change return type.
7786         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7787         return type.
7788         (aix_thread_target::pid_to_str): Change return type.
7789         * target.h (struct target_ops) <pid_to_str>: Change return type.
7790         (target_pid_to_str, normal_pid_to_str): Likewise.
7791         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7792         type.
7793         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7794         type.
7795         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7796         return type.
7797         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7798         type.
7799         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7800         type.
7801         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7802         return type.
7803
7804 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7805
7806         * NEWS: Mention that the new default MI version is 3.  Mention
7807         changes to the output of commands and events that deal with
7808         multi-location breakpoints.
7809         * breakpoint.c: Include "mi/mi-out.h".
7810         (print_one_breakpoint): Change output syntax if using MI version
7811         >= 3.
7812         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7813         New.
7814         (mi_multi_location_breakpoint_output_fixed): New.
7815         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7816         (mi_cmd_fix_multi_location_breakpoint_output): New.
7817         (mi_multi_location_breakpoint_output_fixed): New.
7818         * mi/mi-cmds.c (mi_cmds): Register command
7819         -fix-multi-location-breakpoint-output.
7820         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7821         interpreter "mi".
7822
7823 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7824
7825         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7826         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7827         instantiate mi_ui_out based on interpreter name.
7828         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7829         * mi/mi-main.c (mi_load_progress): Likewise.
7830
7831 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7832
7833         * NEWS: Combine separate "New targets" sections for 8.3.
7834
7835 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7836
7837         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7838         (ppcfbsd_init_abi): Install gdbarch
7839         "fetch_tls_load_module_address" and "get_thread_local_address"
7840         methods.
7841
7842 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7843
7844         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7845         (riscv_fbsd_init_abi): Install gdbarch
7846         "fetch_tls_load_module_address" and "get_thread_local_address"
7847         methods.
7848
7849 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7850
7851         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7852         (i386fbsd_init_abi): Install gdbarch
7853         "fetch_tls_load_module_address" and "get_thread_local_address"
7854         methods.
7855
7856 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7857
7858         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7859         (amd64fbsd_init_abi): Install gdbarch
7860         "fetch_tls_load_module_address" and "get_thread_local_address"
7861         methods.
7862
7863 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7864
7865         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7866         (struct fbsd_pspace_data): New type.
7867         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7868         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7869         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7870         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7871         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7872
7873 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7874
7875         * gdbtypes.c (lookup_struct_elt): New function.
7876         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7877         * gdbtypes.h (struct struct_elt): New type.
7878         (lookup_struct_elt): New prototype.
7879
7880 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7881
7882         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7883         remove disabled code block.
7884
7885 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7886
7887         * gdbarch.sh (get_thread_local_address): New method.
7888         * gdbarch.h, gdbarch.c: Regenerate.
7889         * target.c (target_translate_tls_address): Use
7890         gdbarch_get_thread_local_address if present instead of
7891         target::get_thread_local_address.
7892
7893 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7894
7895         * target.h (target::get_thread_local_address): Update comment.
7896
7897 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7898
7899         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7900         objfile->separate_debug_objfile_backlink if not NULL.
7901
7902 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7903
7904         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7905         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7906         (amd64bsd_store_inferior_registers): Likewise.
7907         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7908         Enable segment base registers.
7909         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7910         PT_GETFSBASE and PT_GETGSBASE.
7911         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7912         PT_SETGSBASE.
7913         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7914         segment base registers.
7915         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7916
7917 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7918
7919         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7920         Update calls to i386_target_description to add 'segments'
7921         parameter.
7922         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7923         add segment base registers.
7924         * arch/i386.c (i386_create_target_description): Add 'segments'
7925         parameter to enable segment base registers.
7926         * arch/i386.h (i386_create_target_description): Likewise.
7927         * features/i386/32bit-segments.xml: New file.
7928         * features/i386/32bit-segments.c: Generate.
7929         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7930         call to i386_target_description to add 'segments' parameter.
7931         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7932         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7933         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7934         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7935         if feature is present.
7936         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7937         Add 'segments' parameter to call to i386_target_description.
7938         (i386_target_description): Add 'segments' parameter to enable
7939         segment base registers.
7940         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7941         to call to i386_target_description.
7942         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7943         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7944         Define I386_NUM_REGS.
7945         (i386_target_description): Add 'segments' parameter to enable
7946         segment base registers.
7947
7948 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7949
7950         PR/24325
7951         * source-cache.c: #undef open and close, to avoid unresolved
7952         externals during linking.
7953
7954 2019-03-12  Tom Tromey  <tromey@adacore.com>
7955
7956         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7957         const.  Add initializers.
7958         (_initialize_remote): Don't initialize ptid globals.
7959
7960 2019-03-12  Pedro Alves  <palves@redhat.com>
7961
7962         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7963
7964 2019-03-12  Pedro Alves  <palves@redhat.com>
7965
7966         * cp-name-parser.y (main): Remove unused 'len' variable.
7967
7968 2019-03-12  Tom Tromey  <tromey@adacore.com>
7969
7970         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7971         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7972
7973 2019-03-12  Tom Tromey  <tromey@adacore.com>
7974
7975         * linux-nat.c (iterate_over_lwps): Update.
7976         (stop_callback): Remove parameter.
7977         (stop_wait_callback, detach_callback, resume_set_callback)
7978         (select_singlestep_lwp_callback, set_ignore_sigint)
7979         (status_callback, resumed_callback, resume_clear_callback)
7980         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7981         data parameter.
7982         (linux_nat_target::detach, linux_nat_target::resume)
7983         (linux_stop_and_wait_all_lwps, select_event_lwp)
7984         (linux_nat_filter_event, linux_nat_wait_1)
7985         (linux_nat_target::kill, linux_nat_target::stop)
7986         (linux_nat_target::stop): Update.
7987         (linux_nat_resume_callback): Change type.
7988         (resume_stopped_resumed_lwps, count_events_callback)
7989         (select_event_lwp_callback): Likewise.
7990         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7991         * arm-linux-nat.c (struct update_registers_data): Remove.
7992         (update_registers_callback): Change type.
7993         (arm_linux_insert_hw_breakpoint1): Update.
7994         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7995         parameter.
7996         (x86_linux_dr_set_addr): Update.
7997         (x86_linux_dr_set_control): Update.
7998         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7999         (iterate_over_lwps): Use gdb::function_view.
8000         * nat/aarch64-linux-hw-point.c (struct
8001         aarch64_dr_update_callback_param): Remove.
8002         (debug_reg_change_callback): Change type.
8003         (aarch64_notify_debug_reg_change): Update.
8004         * s390-linux-nat.c (s390_refresh_per_info): Update.
8005
8006 2019-03-11  Tom Tromey  <tromey@adacore.com>
8007
8008         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8009         redundant assignment to "this_cu".
8010
8011 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8012
8013         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8014
8015 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8016
8017         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8018         from...
8019         (rank_one_type): ... this.
8020
8021 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8022
8023         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8024         from...
8025         (rank_one_type): ... this.
8026
8027 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8028
8029         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8030         from...
8031         (rank_one_type): ... this.
8032
8033 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8034
8035         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8036         from...
8037         (rank_one_type): ... this.
8038
8039 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8040
8041         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8042         from...
8043         (rank_one_type): ... this.
8044
8045 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8046
8047         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8048         from...
8049         (rank_one_type): ... this.
8050
8051 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8052
8053         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8054         from...
8055         (rank_one_type): ... this.
8056
8057 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8058
8059         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8060         from...
8061         (rank_one_type): ... this.
8062
8063 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8064
8065         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8066         from...
8067         (rank_one_type): ... this.
8068
8069 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8070
8071         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8072         from...
8073         (rank_one_type): ... this.
8074
8075 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8076
8077         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8078         from...
8079         (rank_one_type): ... this.
8080
8081 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8082
8083         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8084         from...
8085         (rank_one_type): ... this.
8086
8087 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8088
8089         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8090         inferior-events' shows the example events.
8091
8092 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8093
8094         Support styling on native MS-Windows console
8095
8096         PR/24315
8097         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8098         on MS-Windows if $TERM is not defined.
8099
8100         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8101
8102         * posix-hdep.c (gdb_console_fputs):
8103         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8104         functions.
8105         * ui-file.h (gdb_console_fputs): Add prototype.
8106
8107         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8108         back to fputs only if the former returns zero.
8109
8110 2019-03-07  Tom Tromey  <tom@tromey.com>
8111
8112         * symmisc.c (print_symbol_bcache_statistics): Update.
8113         (print_objfile_statistics): Update.
8114         * symfile.c (allocate_symtab): Update.
8115         * stabsread.c: Don't include bcache.h.
8116         * psymtab.h (struct psymbol_bcache): Don't declare.
8117         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8118         (psymbol_bcache_init, psymbol_bcache_free)
8119         (psymbol_bcache_get_bcache): Don't declare.
8120         * psymtab.c (struct psymbol_bcache): Remove.
8121         (psymtab_storage::psymtab_storage): Update.
8122         (psymtab_storage::~psymtab_storage): Update.
8123         (psymbol_bcache_init, psymbol_bcache_free)
8124         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8125         (add_psymbol_to_bcache): Update.
8126         (allocate_psymtab): Update.
8127         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8128         macro_cache>: No longer pointers.
8129         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8130         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8131         * macrotab.c (macro_bcache): Update.
8132         * macroexp.c: Don't include bcache.h.
8133         * gdbtypes.c (check_types_worklist): Update.
8134         (types_deeply_equal): Remove TRY/CATCH.  Update.
8135         * elfread.c (elf_symtab_read): Update.
8136         * dwarf2read.c: Don't include bcache.h.
8137         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8138         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8139         (print_bcache_statistics, bcache_memory_used): Don't declare.
8140         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8141         methods.  Rename all data members.
8142         * bcache.c (struct bcache): Move to bcache.h.
8143         (bcache::expand_hash_table): Rename from expand_hash_table.
8144         (bcache): Remove.
8145         (bcache::insert): Rename from bcache_full.
8146         (bcache::compare): Rename from bcache_compare.
8147         (bcache_xmalloc): Remove.
8148         (bcache::~bcache): Rename from bcache_xfree.
8149         (bcache::print_statistics): Rename from print_bcache_statistics.
8150         (bcache::memory_used): Rename from bcache_memory_used.
8151
8152 2019-03-07  Pedro Alves  <palves@redhat.com>
8153
8154         * infrun.c (normal_stop): Also check for
8155         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8156
8157 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8158
8159         * f-lang.c (value_from_host_double): Moved to...
8160         * value.c (value_from_host_double): ...here.
8161         * value.h (value_from_host_double): Declare.
8162         * guile/scm-math.c (vlscm_convert_typed_number): Use
8163         value_from_host_double.
8164         (vlscm_convert_number): Likewise.
8165         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8166         * python/py-value.c (convert_value_from_python): Likewise.
8167
8168 2019-03-06  Tom Tromey  <tom@tromey.com>
8169
8170         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8171
8172 2019-03-06  Tom Tromey  <tom@tromey.com>
8173
8174         * utils.h (free_current_contents): Don't declare.
8175         * utils.c (free_current_contents): Remove.
8176
8177 2019-03-06  Tom Tromey  <tom@tromey.com>
8178
8179         * top.c (quit_force): Update.
8180         * main.c (captured_command_loop): Update.
8181         * common/new-op.c (operator new): Update.
8182         * common/common-exceptions.c (struct catcher)
8183         <save_cleanup_chain>: Remove member.
8184         (exceptions_state_mc_init): Update.
8185         (exception_try_scope_entry): Return nullptr.
8186         (exception_try_scope_exit, exception_rethrow)
8187         (throw_exception_sjlj, throw_exception_cxx): Update.
8188         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8189         (all_cleanups, do_cleanups, discard_cleanups)
8190         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8191         (restore_cleanups, restore_final_cleanups): Don't declare.
8192         (do_final_cleanups): Remove parameter.
8193         * common/cleanups.c (cleanup_chain, make_cleanup)
8194         (make_cleanup_dtor, all_cleanups, do_cleanups)
8195         (discard_my_cleanups, discard_cleanups)
8196         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8197         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8198         (null_cleanup): Remove.
8199         (do_final_cleanups): Remove parameter.
8200
8201 2019-03-06  Tom Tromey  <tom@tromey.com>
8202
8203         * remote.c (remote_target::remote_parse_stop_reply): Use
8204         unique_xmalloc_ptr.
8205
8206 2019-03-06  Tom Tromey  <tom@tromey.com>
8207
8208         * stabsread.c (struct stabs_field_info): Rename from field_info.
8209         <list, fnlist>: Add initializers.
8210         <obstack>: New member.
8211         (read_member_functions, read_struct_fields, read_baseclasses):
8212         Allocate on obstack.  Don't use cleanups.
8213         (read_one_struct_field, read_member_functions, read_struct_fields)
8214         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8215         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8216         (read_struct_type): Update.
8217
8218 2019-03-06  Tom Tromey  <tom@tromey.com>
8219
8220         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8221         * common/filestuff.h (make_cleanup_close): Don't declare.
8222         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8223         Remove.
8224
8225 2019-03-06  Tom Tromey  <tom@tromey.com>
8226
8227         * solib-aix.c: Use make_scope_exit.
8228
8229 2019-03-06  Tom Tromey  <tom@tromey.com>
8230
8231         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8232         Use make_scope_exit.
8233
8234 2019-03-06  Tom Tromey  <tom@tromey.com>
8235
8236         * solib-svr4.c (disable_probes_interface): Remove parameter.
8237         (svr4_handle_solib_event): Use make_scope_exit.
8238
8239 2019-03-06  Tom Tromey  <tom@tromey.com>
8240
8241         * remote.c (struct stop_reply_deleter): Remove.
8242         (stop_reply_up): Update.
8243         (struct stop_reply): Derive from notif_event.  Don't typedef.
8244         <regcache>: Now a std::vector.
8245         (stop_reply_xfree): Remove.
8246         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8247         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8248         (remote_target::discard_pending_stop_replies): Use delete.
8249         (remote_target::remote_parse_stop_reply): Update.
8250         (remote_target::process_stop_reply): Update.
8251         * remote-notif.h (struct notif_event): Add virtual destructor.
8252         Remove "dtr" member.
8253         (struct notif_client) <alloc_event>: Return a unique_ptr.
8254         (notif_event_xfree): Don't declare.
8255         (notif_event_up): New typedef.
8256         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8257         (notif_event_xfree, do_notif_event_xfree): Remove.
8258         (remote_notif_state_xfree): Update.
8259
8260 2019-03-06  Tom Tromey  <tom@tromey.com>
8261
8262         * infrun.c (displaced_step_clear_cleanup): Now a
8263         forward_scope_exit type.
8264         (displaced_step_prepare_throw): Update.
8265         (displaced_step_fixup): Update.
8266
8267 2019-03-06  Tom Tromey  <tom@tromey.com>
8268
8269         * inferior.h (class inferior): Update comment.
8270         * gdbthread.h (class thread_info): Update comment.
8271
8272 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8273             Tom Tromey  <tom@tromey.com>
8274
8275         * stabsread.h (struct stab_section_list): Remove.
8276         (coffstab_build_psymtabs): Update.
8277         * dbxread.c (symbuf_sections): Now a std::vector.
8278         (sect_idx): New global.
8279         (fill_symbuf): Update.
8280         (coffstab_build_psymtabs): Change type of stabsects parameter.
8281         Update.
8282         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8283         std::vector.
8284         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8285         (coff_locate_sections): Update.
8286         (coff_symfile_read): Remove cleanups.  Update.
8287         (init_stringtab): Add storage parameter.
8288         (free_stringtab, free_stringtab_cleanup): Remove.
8289         (init_lineno): Add storage parameter.
8290         (free_linetab, free_linetab_cleanup): Remove.
8291
8292 2019-03-06  Pedro Alves  <palves@redhat.com>
8293
8294         * linux-fork.c (fork_info::clobber_regs): Delete.
8295         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8296         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8297         comment.  Adjust.
8298         (scoped_switch_fork_info::scoped_switch_fork_info)
8299         (checkpoint_command, linux_fork_context): Adjust
8300         fork_save_infrun_state calls.
8301
8302 2019-03-06  Pedro Alves  <palves@redhat.com>
8303
8304         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8305         (inf_has_multiple_threads): Return 'bool' and rewrite using
8306         inferior_info::threads().
8307
8308 2019-03-06  Pedro Alves  <palves@redhat.com>
8309
8310         * linux-fork.c: Include <list>.
8311         (fork_list): Now a std::list instance.
8312         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8313         (forks_exist_p, find_last_fork): Adjust.
8314         (new_fork): Delete.
8315         (one_fork_p): New.
8316         (add_fork): Adjust.
8317         (free_fork): Delete, folded into fork_info::~fork_info().
8318         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8319         Adjust.
8320         (init_fork_list): Delete.
8321         (linux_fork_killall, linux_fork_mourn_inferior)
8322         (linux_fork_detach, info_checkpoints_command): Adjust.
8323         (_initialize_linux_fork): No longer call init_fork_list.
8324
8325 2019-03-06  Pedro Alves  <palves@redhat.com>
8326
8327         * linux-fork.c (new_fork): New, split out of ...
8328         (add_fork): ... this.  Return void.  Move "first fork" special
8329         case from here, to ...
8330         (checkpoint_command): ... here.
8331         * linux-linux.h (add_fork): Return void.
8332
8333 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8334
8335         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8336
8337 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8338             Chris January  <chris.january@arm.com>
8339             David Lecomber  <david.lecomber@arm.com>
8340
8341         * f-exp.y: New token, UNOP_INTRINSIC.
8342         (exp): New pattern using UNOP_INTRINSIC token.
8343         (f77_keywords): Add 'abs' keyword.
8344         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8345         (value_from_host_double): New function.
8346         (evaluate_subexp_f): Support UNOP_ABS.
8347
8348 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8349
8350         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8351         types.
8352
8353 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8354
8355         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8356         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8357         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8358
8359 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8360
8361         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8362
8363 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8364             Chris January  <chris.january@arm.com>
8365
8366         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8367         * f-exp.y: Define 'KIND' token.
8368         (exp): New pattern for KIND expressions.
8369         (ptype): Handle types with a kind extension.
8370         (direct_abs_decl): Extend to spot kind extensions.
8371         (f77_keywords): Add 'kind' to the list.
8372         (push_kind_type): New function.
8373         (convert_to_kind_type): New function.
8374         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8375         * parse.c (operator_length_standard): Likewise.
8376         * parser-defs.h (enum type_pieces): Add tp_kind.
8377         * std-operator.def: Add UNOP_KIND.
8378
8379 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8380
8381         * f-exp.y (f_parse): Set yydebug.
8382
8383 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8384
8385         * f-lang.c (evaluate_subexp_f): New function.
8386         (exp_descriptor_f): New global.
8387         (f_language_defn): Use exp_descriptor_f instead of
8388         exp_descriptor_standard.
8389
8390 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8391
8392         * f-exp.y (struct token): Add comments.
8393         (dot_ops): Remove uppercase versions and the end marker.
8394         (f77_keywords): Likewise.
8395         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8396         entries in the dot_ops array are case insensitive, and use
8397         strncasecmp to compare strings.  Also some whitespace cleanup in
8398         this area.  Similar for the f77_keywords array, except entries in
8399         this list might be case sensitive.
8400
8401 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8402
8403         * f-exp.y (struct f77_boolean_val): Add comments.
8404         (boolean_values): Remove uppercase versions, and end marker.
8405         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8406         and use strncasecmp to achieve case insensitivity.  Additionally,
8407         perform whitespace cleanup around this code.
8408
8409 2019-03-06  Tom Tromey  <tromey@adacore.com>
8410
8411         * remote-sim.c (gdbsim_target_open): Use result of
8412         gdb_argv::release.
8413
8414 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8415         Dirk Schubert  <dirk.schubert@arm.com>
8416         Chris January  <chris.january@arm.com>
8417
8418         * eval.c (evaluate_subexp_standard): Call Fortran argument
8419         wrapping logic.
8420         * f-lang.c (struct value): A value which can be passed into a
8421         Fortran function call.
8422         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8423         where appropriate.
8424         (struct type): Value ready for a Fortran function call.
8425         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8426         is needed.
8427         * f-lang.h (fortran_argument_convert): Declaration.
8428         (fortran_preserve_arg_pointer): Declaration.
8429         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8430
8431 2019-03-05  Tom Tromey  <tromey@adacore.com>
8432
8433         * python/py-prettyprint.c (print_string_repr): Remove #if.
8434         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8435
8436 2019-03-05  Tom Tromey  <tromey@adacore.com>
8437
8438         * target.c (the_dummy_target): Move later.  Change type to
8439         "dummy_target".
8440         (initialize_targets): Don't initialize the_dummy_target.
8441
8442 2019-03-05  Tom Tromey  <tromey@adacore.com>
8443
8444         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8445         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8446
8447 2019-03-05  Tom Tromey  <tromey@adacore.com>
8448
8449         * windows-nat.c (windows_nat_target::attach)
8450         (windows_nat_target::detach): Don't call gdb_flush.
8451         * valprint.c (generic_val_print, val_print, val_print_string):
8452         Don't call gdb_flush.
8453         * utils.c (defaulted_query): Don't call gdb_flush.
8454         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8455         * target.c (target_announce_detach): Don't call gdb_flush.
8456         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8457         * remote.c (extended_remote_target::attach): Don't call
8458         gdb_flush.
8459         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8460         * printcmd.c (do_examine): Don't call gdb_flush.
8461         (info_display_command): Don't call gdb_flush.
8462         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8463         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8464         * memattr.c (info_mem_command): Don't call gdb_flush.
8465         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8466         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8467         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8468         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8469         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8470         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8471         (gnu_nat_target::detach): Don't call gdb_flush.
8472         * f-valprint.c (f_val_print): Don't call gdb_flush.
8473         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8474         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8475         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8476         gdb_flush.
8477         * c-valprint.c (c_val_print): Don't call gdb_flush.
8478         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8479
8480 2019-03-05  Tom Tromey  <tromey@adacore.com>
8481
8482         * varobj.c (update_dynamic_varobj_children): Update.
8483         (install_default_visualizer): Use reset, not release.
8484         * value.c (set_internalvar): Update.
8485         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8486         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8487         ATTRIBUTE_UNUSED_RESULT.
8488
8489 2019-03-05  Tom Tromey  <tromey@adacore.com>
8490
8491         * remote.c (class scoped_remote_fd) <release>: Add
8492         ATTRIBUTE_UNUSED_RESULT.
8493
8494 2019-03-05  Tom Tromey  <tromey@adacore.com>
8495
8496         * macroexp.c (struct macro_buffer) <release>: Add
8497         ATTRIBUTE_UNUSED_RESULT.
8498
8499 2019-03-05  Tom Tromey  <tromey@adacore.com>
8500
8501         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8502         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8503         ATTRIBUTE_UNUSED_RESULT.
8504
8505 2019-03-05  Tom Tromey  <tromey@adacore.com>
8506
8507         * common/scoped_fd.h (class scoped_fd) <release>: Add
8508         ATTRIBUTE_UNUSED_RESULT.
8509
8510 2019-03-05  Tom Tromey  <tromey@adacore.com>
8511
8512         * parser-defs.h (struct parser_state) <release>: Add
8513         ATTRIBUTE_UNUSED_RESULT.
8514
8515 2019-03-05  Tom Tromey  <tromey@adacore.com>
8516
8517         * utils.h (class gdb_argv) <release>: Add
8518         ATTRIBUTE_UNUSED_RESULT.
8519         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8520
8521 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8522
8523         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8524         for-loop range, to avoid compiler warnings.
8525
8526         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8527         avoid compiler warnings about unused variables.
8528
8529         * NEWS: Mention end of support for native debugging on MS-Windows
8530         before XP.
8531
8532         PR gdb/24292
8533         * common/netstuff.c:
8534         * gdbserver/gdbreplay.c
8535         * gdbserver/remote-utils.c:
8536         * ser-tcp.c:
8537         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8538         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8539         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8540         'getaddrinfo' and 'freeaddrinfo' were not available before
8541         Windows XP, and mingw.org's MinGW headers by default define
8542         _WIN32_WINNT to 0x500.
8543
8544 2019-03-01  Gary Benson <gbenson@redhat.com>
8545
8546         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8547
8548 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8549             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8550
8551         PR gdb/8527
8552         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8553         set_sigint_trap, clear_sigint_trap.
8554
8555 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8556
8557         * target.c (target_detach): Clear the regcache and the
8558         frame cache.
8559
8560 2019-02-27  Pedro Alves  <palves@redhat.com>
8561
8562         * utils.c (set_screen_size): When we cap the height/width sizes,
8563         tweak the corresponding command variable to show "unlimited":
8564
8565 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8566             Pedro Alves  <palves@redhat.com>
8567
8568         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8569         before calling rl_set_screen_size.
8570
8571 2019-02-27  Tom Tromey  <tromey@adacore.com>
8572
8573         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8574         define.
8575         * python/py-value.c: Remove Python 2.4 workaround.
8576         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8577         workaround.
8578         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8579         Python 2.4 workaround.
8580         * python/python-internal.h: Remove Python 2.4 comment.
8581         (Py_ssize_t): Don't define.
8582         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8583         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8584         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8585         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8586         * python/python.c (do_start_initialization): Remove Python 2.4
8587         workaround.
8588         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8589         (print_children): Remove Python 2.4 workaround.
8590         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8591         workaround.
8592         (CHARBUFFERPROC_NAME): Remove.
8593         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8594         Python 2.4 workaround.
8595
8596 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8597
8598         * NEWS: Note minimum Python version.
8599
8600 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8601
8602         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8603         code from these functions.  Remove corresponding ifdefs.  Use
8604         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8605         Remove gotos and target of gotos.
8606         (infpy_search_memory): Likewise.
8607
8608 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8609
8610         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8611         (hppa_gdbarch_init): Don't register deleted functions with
8612         gdbarch.
8613
8614 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8615
8616         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8617         (h8300_unwind_sp): Delete.
8618         (h8300_dummy_id): Delete.
8619         (h8300_gdbarch_init): Don't register deleted functions with
8620         gdbarch.
8621
8622 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8623
8624         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8625         (ft32_unwind_pc): Delete.
8626         (ft32_unwind_sp): Delete.
8627         (ft32_gdbarch_init): Don't register deleted functions with
8628         gdbarch.
8629
8630 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8631
8632         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8633         (frv_unwind_pc): Delete.
8634         (frv_unwind_sp): Delete.
8635         (frv_gdbarch_init): Don't register deleted functions with
8636         gdbarch.
8637
8638 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8639
8640         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8641         (riscv_unwind_pc): Delete.
8642         (riscv_unwind_sp): Delete.
8643         (riscv_gdbarch_init): Don't register deleted functions with
8644         gdbarch.
8645
8646 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8647
8648         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8649         (csky_unwind_pc): Delete.
8650         (csky_unwind_sp): Delete.
8651         (csky_gdbarch_init): Don't register deleted functions with
8652         gdbarch.
8653
8654 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8655
8656         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8657         (cris_unwind_pc): Delete.
8658         (cris_unwind_sp): Delete.
8659         (cris_gdbarch_init): Don't register deleted functions with
8660         gdbarch.
8661
8662 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8663
8664         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8665         (bfin_unwind_pc): Delete.
8666         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8667
8668 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8669
8670         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8671         (arm_unwind_pc): Delete.
8672         (arm_unwind_sp): Delete.
8673         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8674
8675 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8676
8677         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8678         (arc_unwind_pc): Delete.
8679         (arc_unwind_sp): Delete.
8680         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8681
8682 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8683
8684         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8685         (alpha_unwind_pc): Delete.
8686         (alpha_gdbarch_init): Don't register deleted functions with
8687         gdbarch.
8688
8689 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8690
8691         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8692         (aarch64_unwind_pc): Delete.
8693         (aarch64_unwind_sp): Delete.
8694         (aarch64_gdbarch_init): Don't register deleted functions with
8695         gdbarch.
8696
8697 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8698
8699         * gdbtypes.c (type_align): Don't consider static members when
8700         computing structure alignment.
8701
8702 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8703
8704         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8705         return 0 for other types.
8706         * arch-utils.c (default_type_align): Always return 0.
8707         * gdbarch.h: Regenerate.
8708         * gdbarch.sh (type_align): Extend comment.
8709         * gdbtypes.c (type_align): Add additional comments, always call
8710         gdbarch_type_align before applying the default rules.
8711         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8712         generic code will then apply a suitable default.
8713         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8714         types, return 0 for other types.
8715
8716 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8717
8718         * NEWS: Create a new section for the next release branch.
8719         Rename the section of the current branch, now that it has
8720         been cut.
8721
8722 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8723
8724         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8725         * version.in: Bump version to 8.3.50.DATE-git.
8726
8727 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8728
8729         * aix-thread.c (ptid_cmp): Remove unused variable.
8730         (get_signaled_thread): Likewise.
8731         (store_regs_user_thread): Likewise.
8732         (store_regs_kernel_thread): Likewise.
8733         (fetch_regs_kernel_thread): Remove shadowed variable.
8734
8735 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8736
8737         * features/riscv/32bit-cpu.xml: Add register numbers.
8738         * features/riscv/32bit-fpu.c: Regenerate.
8739         * features/riscv/32bit-fpu.xml: Add register numbers.
8740         * features/riscv/64bit-cpu.xml: Add register numbers.
8741         * features/riscv/64bit-fpu.c: Regenerate.
8742         * features/riscv/64bit-fpu.xml: Add register numbers.
8743
8744 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8745
8746         * NEWS: Mention two argument form of gdb.Value constructor.
8747         * python/py-value.c (convert_buffer_and_type_to_value): New
8748         function.
8749         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8750         Add support for handling an optional second argument.  Call
8751         convert_buffer_and_type_to_value as appropriate.
8752         * python/python-internal.h (Py_buffer_deleter): New struct.
8753         (Py_buffer_up): New typedef.
8754
8755 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8756
8757         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8758         instead of releasing ownership.
8759
8760 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8761
8762         * dwarf2read.c (open_and_init_dwp_file): Call
8763         elf_numsections instead of bfd_count_sections to initialize
8764         dwp_file->num_sections.
8765
8766 2019-02-25  Tom Tromey  <tromey@adacore.com>
8767
8768         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8769
8770 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8771
8772         * gcore.in: Add '--readnever' option when invoking GDB.
8773
8774 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8775
8776         * MAINTAINERS: Update my email address.
8777
8778 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8779
8780         * build-id.c (build_id_to_debug_bfd_1): New function.
8781         (build_id_to_debug_bfd): Look for separate debug file in
8782         sysroot.
8783
8784 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8785
8786         * gdbarch.sh: Update the copyright year range that is placed into
8787         generated files.
8788
8789 2019-02-22  Keith Seitz  <keiths@redhat.com>
8790
8791         PR symtab/23853
8792         * linespec.c (create_sals_line_offset): Search for the default
8793         symtab's filename instead of its fullname.
8794
8795 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8796
8797         * NEWS: Update style defaults.
8798
8799 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8800
8801         * main.c (captured_main_1): Disable styling in batch mode.
8802
8803 2019-02-20  Tom Tromey  <tom@tromey.com>
8804
8805         * symtab.c (symtab_symbol_info): Fix typos.
8806
8807 2019-02-20  Tom Tromey  <tromey@adacore.com>
8808
8809         * findcmd.c (_initialize_mem_search): Use upper case for
8810         metasyntactic variables.
8811
8812 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8813
8814         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8815         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8816
8817 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8818
8819         * top.h (source_file_name): Change to std::string.
8820         * top.c (source_file_name): Likewise.
8821         (command_line_input): Adjust.
8822         * cli/cli-script.c (script_from_file): Adjust.
8823
8824 2019-02-19  Tom Tromey  <tromey@adacore.com>
8825
8826         * ravenscar-thread.c
8827         (ravenscar_thread_target::update_thread_list): Don't call
8828         ada_build_task_list.
8829         * ada-lang.h (ada_build_task_list): Don't declare.
8830         * ada-tasks.c (struct ada_tasks_inferior_data)
8831         <task_list_valid_p>: Now bool.
8832         (read_known_tasks, ada_task_list_changed)
8833         (ada_tasks_invalidate_inferior_data): Update.
8834         (read_known_tasks_array): Return bool.
8835         (read_known_tasks_list): Likewise.
8836         (read_known_tasks): Return void.
8837         (ada_build_task_list): Now static.
8838
8839 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8840
8841         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8842         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8843
8844 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8845
8846         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8847         variant for ada_tasks_pspace_data_handle and
8848         ada_tasks_inferior_data_handle.
8849         (ada_tasks_pspace_data_cleanup): New function.
8850         (ada_tasks_inferior_data_cleanup): New function.
8851
8852 2019-02-17  Tom Tromey  <tom@tromey.com>
8853
8854         * macrotab.h (macro_source_fullname): Return a std::string.
8855         * macrotab.c (macro_include, check_for_redefinition)
8856         (macro_undef, macro_lookup_definition, foreach_macro)
8857         (foreach_macro_in_scope): Update.
8858         (macro_source_fullname): Return a std::string.
8859         * macrocmd.c (show_pp_source_pos): Update.
8860
8861 2019-02-17  Tom Tromey  <tom@tromey.com>
8862
8863         * macrocmd.c (show_pp_source_pos): Style the file names.
8864
8865 2019-02-17  Tom Tromey  <tom@tromey.com>
8866
8867         PR tui/24197:
8868         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8869
8870 2019-02-17  Tom Tromey  <tom@tromey.com>
8871
8872         * ada-lang.c (user_select_syms): Use filtered printing.
8873         * utils.c (wrap_style): New global.
8874         (desired_style): Remove.
8875         (emit_style_escape): Add stream parameter.
8876         (set_output_style, reset_terminal_style, prompt_for_continue):
8877         Update.
8878         (flush_wrap_buffer): Only flush gdb_stdout.
8879         (wrap_here): Set wrap_style.
8880         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8881         treat escape sequences as a character.  Change when wrap buffer is
8882         flushed.
8883         (fputs_styled): Do not set the output style when the default is
8884         requested.
8885         * ui-style.h (struct ui_file_style) <is_default>: New method.
8886         * source.c (print_source_lines_base): Emit escape sequences in one
8887         piece.
8888
8889 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8890
8891         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8892         integers and enumeration types.
8893
8894 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8895
8896         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8897         instead of lookup_symbol_in_language
8898         (do_exact_match): New function.
8899         (ada_get_symbol_name_matcher): Return do_exact_match when
8900         doing a verbatim match.
8901
8902 2019-02-15  Tom Tromey  <tromey@adacore.com>
8903
8904         * ravenscar-thread.c (ravenscar_thread_target::resume)
8905         (ravenscar_thread_target::wait): Special case wildcard requests.
8906
8907 2019-02-15  Tom Tromey  <tromey@adacore.com>
8908
8909         * ravenscar-thread.c (base_ptid): Remove.
8910         (struct ravenscar_thread_target) <close>: New method.
8911         <m_base_ptid>: New member.
8912         <update_inferior_ptid, active_task, task_is_currently_active,
8913         runtime_initialized>: Declare methods.
8914         <ravenscar_thread_target>: Add constructor.
8915         (ravenscar_thread_target::task_is_currently_active)
8916         (ravenscar_thread_target::update_inferior_ptid)
8917         (ravenscar_runtime_initialized): Rename.  Now methods.
8918         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8919         (ravenscar_thread_target::update_thread_list): Update.
8920         (ravenscar_thread_target::active_task): Now method.
8921         (ravenscar_thread_target::store_registers)
8922         (ravenscar_thread_target::prepare_to_store)
8923         (ravenscar_thread_target::prepare_to_store)
8924         (ravenscar_thread_target::mourn_inferior): Update.
8925         (ravenscar_inferior_created): Use "new" to create target.
8926         (ravenscar_thread_target::get_ada_task_ptid): Update.
8927         (_initialize_ravenscar): Don't initialize base_ptid.
8928         (ravenscar_ops): Remove global.
8929
8930 2019-02-15  Tom Tromey  <tromey@adacore.com>
8931
8932         * target.h (push_target): Declare new overload.
8933         * target.c (push_target): New overload, taking an rvalue reference.
8934         * remote.c (remote_target::open_1): Use push_target overload.
8935         * corelow.c (core_target_open): Use push_target overload.
8936
8937 2019-02-15  Tom Tromey  <tromey@adacore.com>
8938
8939         * ravenscar-thread.c (is_ravenscar_task)
8940         (ravenscar_task_is_currently_active): Return bool.
8941         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8942         (_initialize_ravenscar): Remove "(void)".
8943         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8944         Return bool.
8945
8946 2019-02-15  Tom Tromey  <tromey@adacore.com>
8947
8948         * ravenscar-thread.c (ravenscar_runtime_initializer)
8949         (has_ravenscar_runtime, get_running_thread_id)
8950         (ravenscar_thread_target::resume): Fix indentation.
8951
8952 2019-02-15  Tom Tromey  <tromey@adacore.com>
8953
8954         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8955         from ravenscar_arch_ops.
8956         (sparc_ravenscar_ops::fetch_registers)
8957         (sparc_ravenscar_ops::store_registers): Now methods.
8958         (sparc_ravenscar_prepare_to_store): Remove.
8959         (sparc_ravenscar_ops): Redefine.
8960         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8961         methods and destructor.  Remove members.
8962         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8963         (ravenscar_thread_target::store_registers)
8964         (ravenscar_thread_target::prepare_to_store): Update.
8965         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8966         Remove.
8967         (struct ppc_ravenscar_powerpc_ops): Derive from
8968         ravenscar_arch_ops.
8969         (ppc_ravenscar_powerpc_ops::fetch_registers)
8970         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8971         (ppc_ravenscar_powerpc_ops): Redefine.
8972         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8973         (ppc_ravenscar_e500_ops::fetch_registers)
8974         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8975         (ppc_ravenscar_e500_ops): Redefine.
8976         * aarch64-ravenscar-thread.c
8977         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8978         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8979         (aarch64_ravenscar_fetch_registers)
8980         (aarch64_ravenscar_store_registers): Now methods.
8981         (aarch64_ravenscar_ops): Redefine.
8982
8983 2019-02-15  Tom Tromey  <tromey@adacore.com>
8984
8985         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8986         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8987         (ravenscar_thread_target::stopped_by_watchpoint)
8988         (ravenscar_thread_target::stopped_data_address)
8989         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8990
8991 2019-02-15  Tom Tromey  <tromey@adacore.com>
8992
8993         * ravenscar-thread.c: Fix some typos.
8994
8995 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8996             Tom Tromey  <tromey@adacore.com>
8997
8998         * ada-lang.c (ada_exception_sal): Change addr_string to a
8999         std::string.
9000         (create_ada_exception_catchpoint): Update.
9001
9002 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9003             Tom Tromey  <tromey@adacore.com>
9004
9005         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9006         (bp_location_ops): Remove.
9007         (base_breakpoint_allocate_location): Update.
9008         (free_bp_location): Update.
9009         * ada-lang.c (class ada_catchpoint_location)
9010         <ada_catchpoint_location>: Remove ops parameter.
9011         (ada_catchpoint_location_dtor): Remove.
9012         (ada_catchpoint_location_ops): Remove.
9013         (allocate_location_exception): Update.
9014         * breakpoint.h (struct bp_location_ops): Remove.
9015         (class bp_location) <bp_location>: Remove bp_location_ops
9016         parameter.
9017         <~bp_location>: Add destructor.
9018         <ops>: Remove.
9019
9020 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9021             Pedro Alves  <palves@redhat.com>
9022
9023         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9024         'PATH_MAX'.
9025
9026 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9027             Samuel Thibault  <samuel.thibault@gnu.org>
9028             Thomas Schwinge  <thomas@codesourcery.com>
9029
9030         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9031         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9032
9033 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9034
9035         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9036         (check_empty): Use "const char *".
9037
9038         * gnu-nat.c (gnu_nat_target::detach): Instead of
9039         'detach_inferior (pid)' call
9040         'detach_inferior (find_inferior_pid (pid))'.
9041
9042         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9043         'nat/fork-inferior.o'.
9044         * gnu-nat.c: #include "nat/fork-inferior.h".
9045
9046         * gnu-nat.c (gnu_nat_target::detach): Instead of
9047         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9048         * gnu-nat.h: #include "inf-child.h".
9049         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9050         'i386_gnu_nat_target::fetch_registers'.
9051         (gnu_store_registers): Rename/move to
9052         'i386_gnu_nat_target::store_registers'.
9053
9054         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9055         * gnu-nat.h (mach_thread_info): New function.
9056         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9057
9058         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9059
9060 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9061
9062         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9063
9064 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9065
9066         * windows-nat.c (windows_add_thread): Add new parameter
9067         "main_thread_p" with default value set to false.  Update
9068         function documentation as well as all callers.
9069         (windows_delete_thread): Likewise.
9070         (fake_create_process): Update call to windows_add_thread.
9071         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9072         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9073         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9074         call to windows_delete_thread.
9075
9076 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9077
9078         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9079
9080 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9081
9082         * symfile.c (find_separate_debug_file): Use canonical path of
9083         sysroot with child_path instead of gdb_sysroot if it is valid.
9084
9085 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9086
9087         * symfile.c (find_separate_debug_file): Use child_path to
9088         determine if an object file is under a sysroot.
9089
9090 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9091
9092         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9093         unittests/child-path-selftests.c.
9094         * common/pathstuff.c (child_path): New function.
9095         * common/pathstuff.h (child_path): New prototype.
9096         * unittests/child-path-selftests.c: New file.
9097
9098 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9099
9100         * symfile.c (find_separate_debug_file): Look for separate debug
9101         files in debug directories under the sysroot.
9102
9103 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9104
9105         * symtab.h (struct minimal_symbol data_p): New const method.
9106         (struct minimal_symbol text_p): Likewise.
9107         * symtab.c (output_source_filename): Use file name style
9108         to print file name.
9109         (print_symbol_info): Likewise.
9110         (print_msymbol_info): Use address style to print addresses.
9111         Use function name style to print executable text symbols.
9112         (expand_symtab_containing_pc): Use data_p.
9113         (find_pc_sect_compunit_symtab): Likewise.
9114
9115 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9116
9117         * breakpoint.c (describe_other_breakpoints): Use address style
9118         to print addresses.
9119         (say_where): Likewise.
9120
9121 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9122
9123         * ada-typeprint.c (print_func_type): Print function name
9124         style to print function name.
9125         * c-typeprint.c (c_print_type_1): Likewise.
9126
9127 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9128
9129         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9130         for execve.
9131
9132 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9133
9134         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9135         type_stack.
9136
9137 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9138
9139         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9140         TYPE_CODE_REF types.
9141
9142 2019-02-08  Jim Wilson  <jimw@sifive.com>
9143
9144         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9145         (riscv_linux_fregset): New.
9146         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9147
9148 2019-02-07  Tom Tromey  <tom@tromey.com>
9149
9150         * thread.c (thread_cancel_execution_command): Update.
9151         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9152         methods.
9153         (struct thread_fsm_ops): Remove.
9154         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9155         (thread_fsm_should_stop, thread_fsm_return_value)
9156         (thread_fsm_set_finished, thread_fsm_finished_p)
9157         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9158         Don't declare.
9159         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9160         * infrun.c (clear_proceed_status_thread)
9161         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9162         (print_stop_event): Update.
9163         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9164         Add constructor.
9165         (step_command_fsm_ops): Remove.
9166         (new_step_command_fsm): Remove.
9167         (step_1): Update.
9168         (step_command_fsm::should_stop): Rename from
9169         step_command_fsm_should_stop.
9170         (step_command_fsm::clean_up): Rename from
9171         step_command_fsm_clean_up.
9172         (step_command_fsm::do_async_reply_reason): Rename from
9173         step_command_fsm_async_reply_reason.
9174         (struct until_next_fsm): Inherit from thread_fsm.  Add
9175         constructor.
9176         (until_next_fsm_ops): Remove.
9177         (new_until_next_fsm): Remove.
9178         (until_next_fsm::should_stop): Rename from
9179         until_next_fsm_should_stop.
9180         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9181         (until_next_fsm::do_async_reply_reason): Rename from
9182         until_next_fsm_async_reply_reason.
9183         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9184         constructor.  Change type of breakpoint.
9185         (finish_command_fsm_ops): Remove.
9186         (new_finish_command_fsm): Remove.
9187         (finish_command_fsm::should_stop): Rename from
9188         finish_command_fsm_should_stop.
9189         (finish_command_fsm::clean_up): Rename from
9190         finish_command_fsm_clean_up.
9191         (finish_command_fsm::return_value): Rename from
9192         finish_command_fsm_return_value.
9193         (finish_command_fsm::do_async_reply_reason): Rename from
9194         finish_command_fsm_async_reply_reason.
9195         (finish_command): Update.
9196         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9197         Add constructor.
9198         (call_thread_fsm_ops): Remove.
9199         (call_thread_fsm::call_thread_fsm): Rename from
9200         new_call_thread_fsm.
9201         (call_thread_fsm::should_stop): Rename from
9202         call_thread_fsm_should_stop.
9203         (call_thread_fsm::should_notify_stop): Rename from
9204         call_thread_fsm_should_notify_stop.
9205         (run_inferior_call, call_function_by_hand_dummy): Update.
9206         * cli/cli-interp.c (should_print_stop_to_console): Update.
9207         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9208         Add constructor.  Change type of location_breakpoint,
9209         caller_breakpoint.
9210         (until_break_fsm_ops): Remove.
9211         (new_until_break_fsm): Remove.
9212         (until_break_fsm::should_stop): Rename from
9213         until_break_fsm_should_stop.
9214         (until_break_fsm::clean_up): Rename from
9215         until_break_fsm_clean_up.
9216         (until_break_fsm::do_async_reply_reason): Rename from
9217         until_break_fsm_async_reply_reason.
9218         (until_break_command): Update.
9219         * thread-fsm.c: Remove.
9220         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9221
9222 2019-02-07  Tom Tromey  <tom@tromey.com>
9223
9224         * yy-remap.h: Add include guard.
9225         * xtensa-tdep.h: Add include guard.
9226         * xcoffread.h: Rename include guard.
9227         * varobj-iter.h: Add include guard.
9228         * tui/tui.h: Rename include guard.
9229         * tui/tui-winsource.h: Rename include guard.
9230         * tui/tui-wingeneral.h: Rename include guard.
9231         * tui/tui-windata.h: Rename include guard.
9232         * tui/tui-win.h: Rename include guard.
9233         * tui/tui-stack.h: Rename include guard.
9234         * tui/tui-source.h: Rename include guard.
9235         * tui/tui-regs.h: Rename include guard.
9236         * tui/tui-out.h: Rename include guard.
9237         * tui/tui-layout.h: Rename include guard.
9238         * tui/tui-io.h: Rename include guard.
9239         * tui/tui-hooks.h: Rename include guard.
9240         * tui/tui-file.h: Rename include guard.
9241         * tui/tui-disasm.h: Rename include guard.
9242         * tui/tui-data.h: Rename include guard.
9243         * tui/tui-command.h: Rename include guard.
9244         * tic6x-tdep.h: Add include guard.
9245         * target/waitstatus.h: Rename include guard.
9246         * target/wait.h: Rename include guard.
9247         * target/target.h: Rename include guard.
9248         * target/resume.h: Rename include guard.
9249         * target-float.h: Rename include guard.
9250         * stabsread.h: Add include guard.
9251         * rs6000-tdep.h: Add include guard.
9252         * riscv-fbsd-tdep.h: Add include guard.
9253         * regformats/regdef.h: Rename include guard.
9254         * record.h: Rename include guard.
9255         * python/python.h: Rename include guard.
9256         * python/python-internal.h: Rename include guard.
9257         * python/py-stopevent.h: Rename include guard.
9258         * python/py-ref.h: Rename include guard.
9259         * python/py-record.h: Rename include guard.
9260         * python/py-record-full.h: Rename include guard.
9261         * python/py-record-btrace.h: Rename include guard.
9262         * python/py-instruction.h: Rename include guard.
9263         * python/py-events.h: Rename include guard.
9264         * python/py-event.h: Rename include guard.
9265         * procfs.h: Add include guard.
9266         * proc-utils.h: Add include guard.
9267         * p-lang.h: Add include guard.
9268         * or1k-tdep.h: Rename include guard.
9269         * observable.h: Rename include guard.
9270         * nto-tdep.h: Rename include guard.
9271         * nat/x86-linux.h: Rename include guard.
9272         * nat/x86-linux-dregs.h: Rename include guard.
9273         * nat/x86-gcc-cpuid.h: Add include guard.
9274         * nat/x86-dregs.h: Rename include guard.
9275         * nat/x86-cpuid.h: Rename include guard.
9276         * nat/ppc-linux.h: Rename include guard.
9277         * nat/mips-linux-watch.h: Rename include guard.
9278         * nat/linux-waitpid.h: Rename include guard.
9279         * nat/linux-ptrace.h: Rename include guard.
9280         * nat/linux-procfs.h: Rename include guard.
9281         * nat/linux-osdata.h: Rename include guard.
9282         * nat/linux-nat.h: Rename include guard.
9283         * nat/linux-namespaces.h: Rename include guard.
9284         * nat/linux-btrace.h: Rename include guard.
9285         * nat/glibc_thread_db.h: Rename include guard.
9286         * nat/gdb_thread_db.h: Rename include guard.
9287         * nat/gdb_ptrace.h: Rename include guard.
9288         * nat/fork-inferior.h: Rename include guard.
9289         * nat/amd64-linux-siginfo.h: Rename include guard.
9290         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9291         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9292         * nat/aarch64-linux.h: Rename include guard.
9293         * nat/aarch64-linux-hw-point.h: Rename include guard.
9294         * mn10300-tdep.h: Add include guard.
9295         * mips-linux-tdep.h: Add include guard.
9296         * mi/mi-parse.h: Rename include guard.
9297         * mi/mi-out.h: Rename include guard.
9298         * mi/mi-main.h: Rename include guard.
9299         * mi/mi-interp.h: Rename include guard.
9300         * mi/mi-getopt.h: Rename include guard.
9301         * mi/mi-console.h: Rename include guard.
9302         * mi/mi-common.h: Rename include guard.
9303         * mi/mi-cmds.h: Rename include guard.
9304         * mi/mi-cmd-break.h: Rename include guard.
9305         * m2-lang.h: Add include guard.
9306         * location.h: Rename include guard.
9307         * linux-record.h: Rename include guard.
9308         * linux-nat.h: Add include guard.
9309         * linux-fork.h: Add include guard.
9310         * i386-darwin-tdep.h: Rename include guard.
9311         * hppa-linux-offsets.h: Add include guard.
9312         * guile/guile.h: Rename include guard.
9313         * guile/guile-internal.h: Rename include guard.
9314         * gnu-nat.h: Rename include guard.
9315         * gdb-stabs.h: Rename include guard.
9316         * frv-tdep.h: Add include guard.
9317         * f-lang.h: Add include guard.
9318         * event-loop.h: Add include guard.
9319         * darwin-nat.h: Rename include guard.
9320         * cp-abi.h: Rename include guard.
9321         * config/sparc/nm-sol2.h: Rename include guard.
9322         * config/nm-nto.h: Rename include guard.
9323         * config/nm-linux.h: Add include guard.
9324         * config/i386/nm-i386gnu.h: Rename include guard.
9325         * config/djgpp/nl_types.h: Rename include guard.
9326         * config/djgpp/langinfo.h: Rename include guard.
9327         * compile/gcc-cp-plugin.h: Add include guard.
9328         * compile/gcc-c-plugin.h: Add include guard.
9329         * compile/compile.h: Rename include guard.
9330         * compile/compile-object-run.h: Rename include guard.
9331         * compile/compile-object-load.h: Rename include guard.
9332         * compile/compile-internal.h: Rename include guard.
9333         * compile/compile-cplus.h: Rename include guard.
9334         * compile/compile-c.h: Rename include guard.
9335         * common/xml-utils.h: Rename include guard.
9336         * common/x86-xstate.h: Rename include guard.
9337         * common/version.h: Rename include guard.
9338         * common/vec.h: Rename include guard.
9339         * common/tdesc.h: Rename include guard.
9340         * common/selftest.h: Rename include guard.
9341         * common/scoped_restore.h: Rename include guard.
9342         * common/scoped_mmap.h: Rename include guard.
9343         * common/scoped_fd.h: Rename include guard.
9344         * common/safe-iterator.h: Rename include guard.
9345         * common/run-time-clock.h: Rename include guard.
9346         * common/refcounted-object.h: Rename include guard.
9347         * common/queue.h: Rename include guard.
9348         * common/ptid.h: Rename include guard.
9349         * common/print-utils.h: Rename include guard.
9350         * common/preprocessor.h: Rename include guard.
9351         * common/pathstuff.h: Rename include guard.
9352         * common/observable.h: Rename include guard.
9353         * common/netstuff.h: Rename include guard.
9354         * common/job-control.h: Rename include guard.
9355         * common/host-defs.h: Rename include guard.
9356         * common/gdb_wait.h: Rename include guard.
9357         * common/gdb_vecs.h: Rename include guard.
9358         * common/gdb_unlinker.h: Rename include guard.
9359         * common/gdb_unique_ptr.h: Rename include guard.
9360         * common/gdb_tilde_expand.h: Rename include guard.
9361         * common/gdb_sys_time.h: Rename include guard.
9362         * common/gdb_string_view.h: Rename include guard.
9363         * common/gdb_splay_tree.h: Rename include guard.
9364         * common/gdb_setjmp.h: Rename include guard.
9365         * common/gdb_ref_ptr.h: Rename include guard.
9366         * common/gdb_optional.h: Rename include guard.
9367         * common/gdb_locale.h: Rename include guard.
9368         * common/gdb_assert.h: Rename include guard.
9369         * common/filtered-iterator.h: Rename include guard.
9370         * common/filestuff.h: Rename include guard.
9371         * common/fileio.h: Rename include guard.
9372         * common/environ.h: Rename include guard.
9373         * common/common-utils.h: Rename include guard.
9374         * common/common-types.h: Rename include guard.
9375         * common/common-regcache.h: Rename include guard.
9376         * common/common-inferior.h: Rename include guard.
9377         * common/common-gdbthread.h: Rename include guard.
9378         * common/common-exceptions.h: Rename include guard.
9379         * common/common-defs.h: Rename include guard.
9380         * common/common-debug.h: Rename include guard.
9381         * common/cleanups.h: Rename include guard.
9382         * common/buffer.h: Rename include guard.
9383         * common/btrace-common.h: Rename include guard.
9384         * common/break-common.h: Rename include guard.
9385         * cli/cli-utils.h: Rename include guard.
9386         * cli/cli-style.h: Rename include guard.
9387         * cli/cli-setshow.h: Rename include guard.
9388         * cli/cli-script.h: Rename include guard.
9389         * cli/cli-interp.h: Rename include guard.
9390         * cli/cli-decode.h: Rename include guard.
9391         * cli/cli-cmds.h: Rename include guard.
9392         * charset-list.h: Add include guard.
9393         * buildsym-legacy.h: Rename include guard.
9394         * bfin-tdep.h: Add include guard.
9395         * ax.h: Rename include guard.
9396         * arm-linux-tdep.h: Add include guard.
9397         * arm-fbsd-tdep.h: Add include guard.
9398         * arch/xtensa.h: Rename include guard.
9399         * arch/tic6x.h: Add include guard.
9400         * arch/i386.h: Add include guard.
9401         * arch/arm.h: Rename include guard.
9402         * arch/arm-linux.h: Rename include guard.
9403         * arch/arm-get-next-pcs.h: Rename include guard.
9404         * arch/amd64.h: Add include guard.
9405         * arch/aarch64-insn.h: Rename include guard.
9406         * arch-utils.h: Rename include guard.
9407         * annotate.h: Add include guard.
9408         * amd64-darwin-tdep.h: Rename include guard.
9409         * aarch64-linux-tdep.h: Add include guard.
9410         * aarch64-fbsd-tdep.h: Add include guard.
9411         * aarch32-linux-nat.h: Add include guard.
9412
9413 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9414
9415         * macrotab.c (macro_define_internal): New function that
9416         factorizes macro_define_object_internal and macro_define_function
9417         code.
9418         (macro_define_object_internal): Use macro_define_internal.
9419         (macro_define_function): Likewise.
9420
9421 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9422
9423         * macrocmd.c (extract_identifier): Return
9424         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9425         callers.
9426
9427 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9428
9429         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9430
9431 2019-02-05  Tom Tromey  <tom@tromey.com>
9432
9433         * target.c (target_stack::unpush): Move assertion earlier.
9434
9435 2019-01-30  Tom Tromey  <tom@tromey.com>
9436
9437         PR python/23615:
9438         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9439         (gdbpy_parse_and_eval): Likewise.
9440         * python/python-internal.h (gdbpy_allow_threads): New class.
9441
9442 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9443
9444         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9445         (aarch64_fbsd_fpregmap): Move earlier.
9446         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9447         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9448         instead of individual calls to trad_frame_set_reg_addr.
9449         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9450         earlier.
9451         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9452         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9453         instead of individual calls to trad_frame_set_reg_addr.
9454
9455 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9456
9457         * CONTRIBUTE: Replace contribution list with wiki link.
9458
9459 2019-01-25  Tom Tromey  <tom@tromey.com>
9460
9461         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9462
9463 2019-01-25  Tom Tromey  <tom@tromey.com>
9464
9465         * xtensa-linux-nat.c: Fix common/ includes.
9466         * xml-support.h: Fix common/ includes.
9467         * xml-support.c: Fix common/ includes.
9468         * x86-linux-nat.c: Fix common/ includes.
9469         * windows-nat.c: Fix common/ includes.
9470         * varobj.h: Fix common/ includes.
9471         * varobj.c: Fix common/ includes.
9472         * value.c: Fix common/ includes.
9473         * valops.c: Fix common/ includes.
9474         * utils.c: Fix common/ includes.
9475         * unittests/xml-utils-selftests.c: Fix common/ includes.
9476         * unittests/utils-selftests.c: Fix common/ includes.
9477         * unittests/unpack-selftests.c: Fix common/ includes.
9478         * unittests/tracepoint-selftests.c: Fix common/ includes.
9479         * unittests/style-selftests.c: Fix common/ includes.
9480         * unittests/string_view-selftests.c: Fix common/ includes.
9481         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9482         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9483         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9484         * unittests/rsp-low-selftests.c: Fix common/ includes.
9485         * unittests/parse-connection-spec-selftests.c: Fix common/
9486         includes.
9487         * unittests/optional-selftests.c: Fix common/ includes.
9488         * unittests/offset-type-selftests.c: Fix common/ includes.
9489         * unittests/observable-selftests.c: Fix common/ includes.
9490         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9491         * unittests/memrange-selftests.c: Fix common/ includes.
9492         * unittests/memory-map-selftests.c: Fix common/ includes.
9493         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9494         * unittests/function-view-selftests.c: Fix common/ includes.
9495         * unittests/environ-selftests.c: Fix common/ includes.
9496         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9497         * unittests/common-utils-selftests.c: Fix common/ includes.
9498         * unittests/cli-utils-selftests.c: Fix common/ includes.
9499         * unittests/array-view-selftests.c: Fix common/ includes.
9500         * ui-file.c: Fix common/ includes.
9501         * tui/tui-io.c: Fix common/ includes.
9502         * tracepoint.h: Fix common/ includes.
9503         * tracepoint.c: Fix common/ includes.
9504         * tracefile-tfile.c: Fix common/ includes.
9505         * top.h: Fix common/ includes.
9506         * top.c: Fix common/ includes.
9507         * thread.c: Fix common/ includes.
9508         * target/waitstatus.h: Fix common/ includes.
9509         * target/waitstatus.c: Fix common/ includes.
9510         * target.h: Fix common/ includes.
9511         * target.c: Fix common/ includes.
9512         * target-memory.c: Fix common/ includes.
9513         * target-descriptions.c: Fix common/ includes.
9514         * symtab.h: Fix common/ includes.
9515         * symfile.c: Fix common/ includes.
9516         * stap-probe.c: Fix common/ includes.
9517         * spu-linux-nat.c: Fix common/ includes.
9518         * sparc-nat.c: Fix common/ includes.
9519         * source.c: Fix common/ includes.
9520         * solib.c: Fix common/ includes.
9521         * solib-target.c: Fix common/ includes.
9522         * ser-unix.c: Fix common/ includes.
9523         * ser-tcp.c: Fix common/ includes.
9524         * ser-pipe.c: Fix common/ includes.
9525         * ser-base.c: Fix common/ includes.
9526         * selftest-arch.c: Fix common/ includes.
9527         * s12z-tdep.c: Fix common/ includes.
9528         * rust-exp.y: Fix common/ includes.
9529         * rs6000-aix-tdep.c: Fix common/ includes.
9530         * riscv-tdep.c: Fix common/ includes.
9531         * remote.c: Fix common/ includes.
9532         * remote-notif.h: Fix common/ includes.
9533         * remote-fileio.h: Fix common/ includes.
9534         * remote-fileio.c: Fix common/ includes.
9535         * regcache.h: Fix common/ includes.
9536         * regcache.c: Fix common/ includes.
9537         * record-btrace.c: Fix common/ includes.
9538         * python/python.c: Fix common/ includes.
9539         * python/py-type.c: Fix common/ includes.
9540         * python/py-inferior.c: Fix common/ includes.
9541         * progspace.h: Fix common/ includes.
9542         * producer.c: Fix common/ includes.
9543         * procfs.c: Fix common/ includes.
9544         * proc-api.c: Fix common/ includes.
9545         * printcmd.c: Fix common/ includes.
9546         * ppc-linux-nat.c: Fix common/ includes.
9547         * parser-defs.h: Fix common/ includes.
9548         * osdata.c: Fix common/ includes.
9549         * obsd-nat.c: Fix common/ includes.
9550         * nat/x86-linux.c: Fix common/ includes.
9551         * nat/x86-linux-dregs.c: Fix common/ includes.
9552         * nat/x86-dregs.h: Fix common/ includes.
9553         * nat/x86-dregs.c: Fix common/ includes.
9554         * nat/ppc-linux.c: Fix common/ includes.
9555         * nat/mips-linux-watch.h: Fix common/ includes.
9556         * nat/mips-linux-watch.c: Fix common/ includes.
9557         * nat/linux-waitpid.c: Fix common/ includes.
9558         * nat/linux-ptrace.h: Fix common/ includes.
9559         * nat/linux-ptrace.c: Fix common/ includes.
9560         * nat/linux-procfs.c: Fix common/ includes.
9561         * nat/linux-personality.c: Fix common/ includes.
9562         * nat/linux-osdata.c: Fix common/ includes.
9563         * nat/linux-namespaces.c: Fix common/ includes.
9564         * nat/linux-btrace.h: Fix common/ includes.
9565         * nat/linux-btrace.c: Fix common/ includes.
9566         * nat/fork-inferior.c: Fix common/ includes.
9567         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9568         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9569         * nat/aarch64-linux.c: Fix common/ includes.
9570         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9571         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9572         * namespace.h: Fix common/ includes.
9573         * mips-linux-tdep.c: Fix common/ includes.
9574         * minsyms.c: Fix common/ includes.
9575         * mi/mi-parse.h: Fix common/ includes.
9576         * mi/mi-main.c: Fix common/ includes.
9577         * mi/mi-cmd-env.c: Fix common/ includes.
9578         * memrange.h: Fix common/ includes.
9579         * memattr.c: Fix common/ includes.
9580         * maint.h: Fix common/ includes.
9581         * maint.c: Fix common/ includes.
9582         * main.c: Fix common/ includes.
9583         * machoread.c: Fix common/ includes.
9584         * location.c: Fix common/ includes.
9585         * linux-thread-db.c: Fix common/ includes.
9586         * linux-nat.c: Fix common/ includes.
9587         * linux-fork.c: Fix common/ includes.
9588         * inline-frame.c: Fix common/ includes.
9589         * infrun.c: Fix common/ includes.
9590         * inflow.c: Fix common/ includes.
9591         * inferior.h: Fix common/ includes.
9592         * inferior.c: Fix common/ includes.
9593         * infcmd.c: Fix common/ includes.
9594         * inf-ptrace.c: Fix common/ includes.
9595         * inf-child.c: Fix common/ includes.
9596         * ia64-linux-nat.c: Fix common/ includes.
9597         * i387-tdep.c: Fix common/ includes.
9598         * i386-tdep.c: Fix common/ includes.
9599         * i386-linux-tdep.c: Fix common/ includes.
9600         * i386-linux-nat.c: Fix common/ includes.
9601         * i386-go32-tdep.c: Fix common/ includes.
9602         * i386-fbsd-tdep.c: Fix common/ includes.
9603         * i386-fbsd-nat.c: Fix common/ includes.
9604         * guile/scm-type.c: Fix common/ includes.
9605         * guile/guile.c: Fix common/ includes.
9606         * go32-nat.c: Fix common/ includes.
9607         * gnu-nat.c: Fix common/ includes.
9608         * gdbthread.h: Fix common/ includes.
9609         * gdbarch-selftests.c: Fix common/ includes.
9610         * gdb_usleep.c: Fix common/ includes.
9611         * gdb_select.h: Fix common/ includes.
9612         * gdb_bfd.c: Fix common/ includes.
9613         * gcore.c: Fix common/ includes.
9614         * fork-child.c: Fix common/ includes.
9615         * findvar.c: Fix common/ includes.
9616         * fbsd-nat.c: Fix common/ includes.
9617         * event-top.c: Fix common/ includes.
9618         * event-loop.c: Fix common/ includes.
9619         * dwarf2read.c: Fix common/ includes.
9620         * dwarf2loc.c: Fix common/ includes.
9621         * dwarf2-frame.c: Fix common/ includes.
9622         * dwarf-index-cache.c: Fix common/ includes.
9623         * dtrace-probe.c: Fix common/ includes.
9624         * disasm-selftests.c: Fix common/ includes.
9625         * defs.h: Fix common/ includes.
9626         * csky-tdep.c: Fix common/ includes.
9627         * cp-valprint.c: Fix common/ includes.
9628         * cp-support.h: Fix common/ includes.
9629         * cp-support.c: Fix common/ includes.
9630         * corelow.c: Fix common/ includes.
9631         * completer.h: Fix common/ includes.
9632         * completer.c: Fix common/ includes.
9633         * compile/compile.c: Fix common/ includes.
9634         * compile/compile-loc2c.c: Fix common/ includes.
9635         * compile/compile-cplus-types.c: Fix common/ includes.
9636         * compile/compile-cplus-symbols.c: Fix common/ includes.
9637         * command.h: Fix common/ includes.
9638         * cli/cli-dump.c: Fix common/ includes.
9639         * cli/cli-cmds.c: Fix common/ includes.
9640         * charset.c: Fix common/ includes.
9641         * build-id.c: Fix common/ includes.
9642         * btrace.h: Fix common/ includes.
9643         * btrace.c: Fix common/ includes.
9644         * breakpoint.h: Fix common/ includes.
9645         * breakpoint.c: Fix common/ includes.
9646         * ax.h:
9647         (enum agent_op): Fix common/ includes.
9648         * ax-general.c (struct aop_map): Fix common/ includes.
9649         * ax-gdb.c: Fix common/ includes.
9650         * auxv.c: Fix common/ includes.
9651         * auto-load.c: Fix common/ includes.
9652         * arm-tdep.c: Fix common/ includes.
9653         * arch/riscv.c: Fix common/ includes.
9654         * arch/ppc-linux-common.c: Fix common/ includes.
9655         * arch/i386.c: Fix common/ includes.
9656         * arch/arm.c: Fix common/ includes.
9657         * arch/arm-linux.c: Fix common/ includes.
9658         * arch/arm-get-next-pcs.c: Fix common/ includes.
9659         * arch/amd64.c: Fix common/ includes.
9660         * arch/aarch64.c: Fix common/ includes.
9661         * arch/aarch64-insn.c: Fix common/ includes.
9662         * arch-utils.c: Fix common/ includes.
9663         * amd64-windows-tdep.c: Fix common/ includes.
9664         * amd64-tdep.c: Fix common/ includes.
9665         * amd64-sol2-tdep.c: Fix common/ includes.
9666         * amd64-obsd-tdep.c: Fix common/ includes.
9667         * amd64-nbsd-tdep.c: Fix common/ includes.
9668         * amd64-linux-tdep.c: Fix common/ includes.
9669         * amd64-linux-nat.c: Fix common/ includes.
9670         * amd64-fbsd-tdep.c: Fix common/ includes.
9671         * amd64-fbsd-nat.c: Fix common/ includes.
9672         * amd64-dicos-tdep.c: Fix common/ includes.
9673         * amd64-darwin-tdep.c: Fix common/ includes.
9674         * agent.c: Fix common/ includes.
9675         * ada-lang.h: Fix common/ includes.
9676         * ada-lang.c: Fix common/ includes.
9677         * aarch64-tdep.c: Fix common/ includes.
9678
9679 2019-01-25  Tom Tromey  <tom@tromey.com>
9680
9681         * common/create-version.sh: Use common/version.h.
9682
9683 2019-01-24  Pedro Alves  <palves@redhat.com>
9684
9685         * infrun.c (signal_stop, signal_print, signal_program)
9686         (signal_catch, signal_pass): Now arrays instead of pointers.
9687         (update_signals_program_target, do_target_resume)
9688         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9689         * linux-nat.c (linux_nat_target::pass_signals)
9690         (linux_nat_target::create_inferior, linux_nat_target::attach):
9691         Adjust.
9692         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9693         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9694         * procfs.c (procfs_target::pass_signals): Adjust.
9695         * record-full.c (record_full_target::resume): Adjust.
9696         * remote.c (remote_target::pass_signals)
9697         (remote_target::program_signals): Adjust.
9698         * target-debug.h (target_debug_print_signals): Now takes a
9699         gdb::array_view as parameter.  Adjust.
9700         * target.h (target_ops) <pass_signals, program_signals>: Replace
9701         pointer and length parameters with gdb::array_view.
9702         (target_pass_signals, target_program_signals): Likewise.
9703         * target-delegates.c: Regenerate.
9704
9705 2019-01-24  Pedro Alves  <palves@redhat.com>
9706
9707         * common/forward-scope-exit.h
9708         (forward_scope_exit::forward_scope_exit): Pass arguments to
9709         m_bind_function directly, instead of creating a std::bind and
9710         copying that.
9711
9712 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9713
9714         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9715         for static members.
9716         (pass_in_v_vfp_candidate): Likewise.
9717
9718 2019-01-23  Tom Tromey  <tom@tromey.com>
9719             Pedro Alves  <palves@redhat.com>
9720
9721         * regcache.c (class regcache_invalidator): Remove.
9722         (regcache::raw_write): Use make_scope_exit.
9723
9724 2019-01-23  Tom Tromey  <tom@tromey.com>
9725
9726         * ui-out.h (class ui_out_emit_type): Update comment.
9727
9728 2019-01-23  Tom Tromey  <tom@tromey.com>
9729
9730         * infrun.c (fetch_inferior_event): Update comment.
9731
9732 2019-01-23  Tom Tromey  <tom@tromey.com>
9733             Pedro Alves  <palves@redhat.com>
9734
9735         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9736         parameter.
9737         (fetch_inferior_event): Use SCOPE_EXIT.
9738
9739
9740 2019-01-23  Tom Tromey  <tom@tromey.com>
9741             Pedro Alves  <palves@redhat.com>
9742
9743         * infrun.c (disable_thread_events): Delete.
9744         (stop_all_threads): Use SCOPE_EXIT.
9745
9746 2019-01-23  Tom Tromey  <tom@tromey.com>
9747             Pedro Alves  <palves@redhat.com>
9748
9749         * symfile.c: Include forward-scope-exit.h.
9750         (clear_symtab_users_cleanup): Replace forward declaration with
9751         a FORWARD_SCOPE_EXIT.
9752         (syms_from_objfile_1): Use the forward_scope_exit and
9753         gdb::optional instead of cleanup_function.
9754         (reread_symbols): Use the forward_scope_exit instead of
9755         cleanup_function.
9756         (clear_symtab_users_cleanup): Remove function.
9757
9758 2019-01-23  Tom Tromey  <tom@tromey.com>
9759             Pedro Alves  <palves@redhat.com>
9760
9761         * linux-nat.c: Include scope-exit.h.
9762         (cleanup_target_stop): Remove.
9763         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9764         SCOPE_EXIT.
9765
9766 2019-01-23  Tom Tromey  <tom@tromey.com>
9767             Pedro Alves  <palves@redhat.com>
9768
9769         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9770         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9771
9772 2019-01-23  Tom Tromey  <tom@tromey.com>
9773             Andrew Burgess  <andrew.burgess@embecosm.com>
9774             Pedro Alves  <palves@redhat.com>
9775
9776         * infrun.c (fetch_inferior_event): Use scope_exit.
9777         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9778         * top.c (execute_command): Use scope_exit.
9779         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9780         * utils.c (do_bpstat_clear_actions_cleanup)
9781         (make_bpstat_clear_actions_cleanup): Remove.
9782
9783 2019-01-23  Tom Tromey  <tom@tromey.com>
9784             Pedro Alves  <palves@redhat.com>
9785
9786         * infrun.c: Include "common/scope-exit.h"
9787         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9788         (wait_for_inferior): Use SCOPE_EXIT.
9789         (fetch_inferior_event): Use scope_exit.
9790
9791 2019-01-23  Tom Tromey  <tom@tromey.com>
9792             Pedro Alves  <palves@redhat.com>
9793
9794         * breakpoint.c (create_breakpoint): Remove cleanup.
9795
9796 2019-01-23  Tom Tromey  <tom@tromey.com>
9797             Andrew Burgess  <andrew.burgess@embecosm.com>
9798             Pedro Alves  <palves@redhat.com>
9799
9800 2019-01-23  Pedro Alves  <palves@redhat.com>
9801
9802         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9803
9804 2019-01-23  Pedro Alves  <palves@redhat.com>
9805             Andrew Burgess  <andrew.burgess@embecosm.com>
9806
9807         * gdbthread.h: Include "common/forward-scope-exit.h".
9808         (scoped_finish_thread_state): Redefine custom class in terms of
9809         forward_scope_exit.
9810
9811 2019-01-23  Pedro Alves  <palves@redhat.com>
9812             Andrew Burgess  <andrew.burgess@embecosm.com>
9813
9814         * common/forward-scope-exit.h: New file.
9815
9816 2019-01-23  Pedro Alves  <palves@redhat.com>
9817             Andrew Burgess  <andrew.burgess@embecosm.com>
9818             Tom Tromey  <tom@tromey.com>
9819
9820         * common/scope-exit.h: New file.
9821
9822 2019-01-23  Pedro Alves  <palves@redhat.com>
9823
9824         * common/preprocessor.h (ESC): Rename to ...
9825         (ESC_PARENS): ... this.
9826         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9827         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9828
9829 2019-01-23  Tom Tromey  <tom@tromey.com>
9830
9831         * language.h (class scoped_switch_to_sym_language_if_auto):
9832         Initialize m_lang in both cases.
9833
9834 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9835
9836         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9837         with XCNEW.
9838
9839 2019-01-22  Tom Tromey  <tom@tromey.com>
9840
9841         * corelow.c: Do not include sys/file.h.
9842
9843 2019-01-22  Tom Tromey  <tom@tromey.com>
9844
9845         * tui/tui-wingeneral.h: Include gdb_curses.h.
9846
9847 2019-01-22  Tom Tromey  <tom@tromey.com>
9848
9849         * source-cache.h (class source_cache) <get_source_lines,
9850         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9851
9852 2019-01-22  Tom Tromey  <tom@tromey.com>
9853
9854         * remote-fileio.h (struct remote_target): Declare.
9855
9856 2019-01-22  Tom Tromey  <tom@tromey.com>
9857
9858         * python/py-arch.c: Do not include py-ref.h.
9859         * python/py-bpevent.c: Do not include py-ref.h.
9860         * python/py-cmd.c: Do not include py-ref.h.
9861         * python/py-continueevent.c: Do not include py-ref.h.
9862         * python/py-event.h: Do not include py-ref.h.
9863         * python/py-evtregistry.c: Do not include py-ref.h.
9864         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9865         * python/py-frame.c: Do not include py-ref.h.
9866         * python/py-framefilter.c: Do not include py-ref.h.
9867         * python/py-function.c: Do not include py-ref.h.
9868         * python/py-infevents.c: Do not include py-ref.h.
9869         * python/py-linetable.c: Do not include py-ref.h.
9870         * python/py-objfile.c: Do not include py-ref.h.
9871         * python/py-param.c: Do not include py-ref.h.
9872         * python/py-prettyprint.c: Do not include py-ref.h.
9873         * python/py-progspace.c: Do not include py-ref.h.
9874         * python/py-symbol.c: Do not include py-ref.h.
9875         * python/py-symtab.c: Do not include py-ref.h.
9876         * python/py-type.c: Do not include py-ref.h.
9877         * python/py-unwind.c: Do not include py-ref.h.
9878         * python/py-utils.c: Do not include py-ref.h.
9879         * python/py-value.c: Do not include py-ref.h.
9880         * python/py-varobj.c: Do not include py-ref.h.
9881         * python/py-xmethods.c: Do not include py-ref.h.
9882         * python/python.c: Do not include py-ref.h.
9883         * varobj.c: Do not include py-ref.h.
9884
9885 2019-01-22  Tom Tromey  <tom@tromey.com>
9886
9887         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9888         keyword for bcache.
9889
9890 2019-01-22  Tom Tromey  <tom@tromey.com>
9891
9892         * compile/compile-cplus-types.c: Remove a comment by #include.
9893
9894 2019-01-22  Tom Tromey  <tom@tromey.com>
9895
9896         * compile/gcc-c-plugin.h: Include compile-internal.h.
9897
9898 2019-01-22  Tom Tromey  <tom@tromey.com>
9899
9900         * stabsread.c (EXTERN): Do not define.
9901         (symnum, next_symbol_text_func, processing_gcc_compilation)
9902         (within_function, global_sym_chain, global_stabs)
9903         (previous_stab_code, this_object_header_files)
9904         (n_this_object_header_files)
9905         (n_allocated_this_object_header_files): Define.
9906         * stabsread.h (EXTERN): Never define.  Use "extern".
9907
9908 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9909
9910         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9911         history_value.
9912
9913 2019-01-21  Tom Tromey  <tom@tromey.com>
9914
9915         * ui-out.c: Fix includes.
9916         * tui/tui-source.c: Fix includes.
9917         * target.c: Fix includes.
9918         * remote.c: Fix includes.
9919         * regcache.c: Fix includes.
9920         * python/py-block.c: Fix includes.
9921         * printcmd.c: Fix includes.
9922         * or1k-tdep.c: Fix includes.
9923         * mi/mi-main.c: Fix includes.
9924         * m32r-tdep.c: Fix includes.
9925         * csky-tdep.c: Fix includes.
9926         * compile/compile-cplus-types.c: Fix includes.
9927         * cli/cli-interp.c: Fix includes.
9928
9929 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9930
9931         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9932         for padding.
9933
9934 2019-01-16  Tom Tromey  <tom@tromey.com>
9935
9936         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9937         earlier.
9938         (struct objfile) <msymbols_range>: Move from top level.
9939         <msymbols>: New method.
9940         (class objfile_msymbols): Remove.
9941         * symtab.c (default_collect_symbol_completion_matches_break_on):
9942         Update.
9943         * symmisc.c (dump_msymbols): Update.
9944         * stabsread.c (scan_file_globals): Update.
9945         * objc-lang.c (info_selectors_command, info_classes_command)
9946         (find_methods): Update.
9947         * minsyms.c (find_solib_trampoline_target): Update.
9948         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9949         * coffread.c (coff_symfile_read): Update.
9950         * ada-lang.c (ada_lookup_simple_minsym)
9951         (ada_collect_symbol_completion_matches): Update.
9952
9953 2019-01-16  Tom Tromey  <tom@tromey.com>
9954
9955         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9956         type.  Remove no-argument constructor.
9957         <iterator::operator++>: Simplify.
9958         <begin>: Update.
9959         <end>: Use minimal_symbol_count.
9960
9961 2019-01-16  Tom Tromey  <tom@tromey.com>
9962
9963         * objfiles.h (struct objfile) <psymtabs>: New method.
9964         (class objfile_psymtabs): Remove.
9965         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9966         typedef.
9967         <range>: New method.
9968         (require_partial_symbols): Change return type.
9969         * psymtab.c (require_partial_symbols)
9970         (psym_expand_symtabs_matching): Update.
9971         * mdebugread.c (parse_partial_symbols): Update.
9972         * dbxread.c (dbx_end_psymtab): Update.
9973
9974 2019-01-15  Tom Tromey  <tom@tromey.com>
9975
9976         * symtab.c (lookup_objfile_from_block)
9977         (lookup_symbol_in_objfile_symtabs)
9978         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9979         (find_line_symtab, info_sources_command)
9980         (default_collect_symbol_completion_matches_break_on)
9981         (make_source_files_completion_list): Update.
9982         * symmisc.c (print_objfile_statistics, dump_objfile)
9983         (maintenance_print_symbols, maintenance_info_symtabs)
9984         (maintenance_check_symtabs, maintenance_info_line_tables):
9985         Update.
9986         * source.c (select_source_symtab)
9987         (forget_cached_source_info_for_objfile): Update.
9988         * objfiles.h (class objfile_compunits): Remove.
9989         (struct objfile) <compunits_range>: New typedef.
9990         (compunits): New method.
9991         * objfiles.c (objfile_relocate1): Update.
9992         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9993         * maint.c (count_symtabs_and_blocks): Update.
9994         * linespec.c (iterate_over_all_matching_symtabs): Update.
9995         * cp-support.c (add_symbol_overload_list_qualified): Update.
9996         * coffread.c (coff_symtab_read): Update.
9997         * ada-lang.c (add_nonlocal_symbols)
9998         (ada_collect_symbol_completion_matches)
9999         (ada_add_global_exceptions): Update.
10000
10001 2019-01-15  Tom Tromey  <tom@tromey.com>
10002
10003         * progspace.h (program_space) <objfiles_safe_range>: New
10004         typedef.
10005         <objfiles_safe>: New method.
10006         * objfiles.h (class all_objfiles_safe): Remove.
10007         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10008         * jit.c (jit_inferior_exit_hook): Update.
10009
10010 2019-01-17  Tom Tromey  <tom@tromey.com>
10011
10012         * progspace.h (program_space) <objfiles_range>: New typedef.
10013         <objfiles>: New method.
10014         <objfiles_head>: Rename from objfiles.
10015         (object_files): Update.
10016         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10017         * guile/scm-pretty-print.c
10018         (ppscm_find_pretty_printer_from_objfiles): Update.
10019         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10020         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10021         Update.
10022         * python/py-progspace.c (pspy_get_objfiles): Update.
10023         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10024         Update.
10025         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10026         (objfpy_lookup_objfile_by_build_id): Update.
10027         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10028         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10029         Update.
10030         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10031         (expand_symtab_containing_pc, lookup_objfile_from_block)
10032         (lookup_static_symbol, basic_lookup_transparent_type)
10033         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10034         (find_line_symtab, info_sources_command)
10035         (default_collect_symbol_completion_matches_break_on)
10036         (make_source_files_completion_list, find_main_name): Update.
10037         * symmisc.c (print_symbol_bcache_statistics)
10038         (print_objfile_statistics, maintenance_print_symbols)
10039         (maintenance_print_msymbols, maintenance_print_objfiles)
10040         (maintenance_info_symtabs, maintenance_check_symtabs)
10041         (maintenance_expand_symtabs, maintenance_info_line_tables):
10042         Update.
10043         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10044         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10045         (map_overlay_command, unmap_overlay_command)
10046         (simple_overlay_update, expand_symtabs_matching)
10047         (map_symbol_filenames): Update.
10048         * symfile-debug.c (set_debug_symfile): Update.
10049         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10050         Update.
10051         * source.c (select_source_symtab, forget_cached_source_info):
10052         Update.
10053         * solib.c (solib_read_symbols): Update.
10054         * solib-spu.c (append_ocl_sos): Update.
10055         * psymtab.c (maintenance_print_psymbols)
10056         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10057         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10058         * printcmd.c (info_symbol_command): Update.
10059         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10060         Update.
10061         * objfiles.h (class all_objfiles): Remove.
10062         * objfiles.c (have_partial_symbols, have_full_symbols)
10063         (have_minimal_symbols, qsort_cmp, update_section_map)
10064         (shared_objfile_contains_address_p)
10065         (default_iterate_over_objfiles_in_search_order): Update.
10066         * objc-lang.c (info_selectors_command, info_classes_command)
10067         (find_methods): Update.
10068         * minsyms.c (find_solib_trampoline_target): Update.
10069         * maint.c (maintenance_info_sections)
10070         (maintenance_translate_address, count_symtabs_and_blocks):
10071         Update.
10072         * main.c (captured_main_1): Update.
10073         * linux-thread-db.c (try_thread_db_load_from_pdir)
10074         (has_libpthread): Update.
10075         * linespec.c (iterate_over_all_matching_symtabs)
10076         (search_minsyms_for_name): Update.
10077         * jit.c (jit_find_objf_with_entry_addr): Update.
10078         * hppa-tdep.c (find_unwind_entry)
10079         (hppa_lookup_stub_minimal_symbol): Update.
10080         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10081         Update.
10082         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10083         (elf_gnu_ifunc_resolve_by_got): Update.
10084         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10085         * dwarf-index-write.c (save_gdb_index_command): Update.
10086         * cp-support.c (add_symbol_overload_list_qualified): Update.
10087         * breakpoint.c (create_overlay_event_breakpoint)
10088         (create_longjmp_master_breakpoint)
10089         (create_std_terminate_master_breakpoint)
10090         (create_exception_master_breakpoint): Update.
10091         * blockframe.c (find_pc_partial_function): Update.
10092         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10093         (ada_collect_symbol_completion_matches)
10094         (ada_add_global_exceptions): Update.
10095
10096 2019-01-17  Tom Tromey  <tom@tromey.com>
10097
10098         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10099         declare VEC.
10100         (solib_target_parse_libraries): Change return type.
10101         (library_list_start_segment, library_list_start_section)
10102         (library_list_end_library, library_list_start_library); Update.
10103         (solib_target_free_library_list): Remove.
10104         (solib_target_parse_libraries): Remove cleanup.  Change return
10105         type.
10106         (solib_target_current_sos): Update.
10107
10108 2019-01-17  Tom Tromey  <tromey@bapiya>
10109
10110         * valprint.c: Replace "the the" with "the".
10111         * symtab.c: Replace "the the" with "the".
10112         * solib.c: Replace "the the" with "the".
10113         * solib-dsbt.c: Replace "the the" with "the".
10114         * linespec.c: Replace "the the" with "the".
10115         * dwarf2loc.h: Replace "the the" with "the".
10116         * amd64-windows-tdep.c: Replace "the the" with "the".
10117         * aarch64-tdep.c: Replace "the the" with "the".
10118
10119 2019-01-16  Keith Seitz  <keiths@redhat.com>
10120
10121         PR gdb/23773
10122         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10123         <builder>: Rename to ..
10124         <m_builder>: ... this and make private.
10125         (dwarf2_cu::get_builder): New method.  Change all users of
10126         `builder' to use this method.
10127         (dwarf2_start_symtab): Move to ...
10128         (dwarf2_cu::start_symtab): ... here.  Update all callers
10129         (setup_type_unit_groups): Move to ...
10130         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10131         callers.
10132         (dwarf2_cu::reset_builder): New method.
10133         (process_full_compunit, process_full_type_unit): Use
10134         dwarf2_cu::reset_builder.
10135         (follow_die_offset): Record the ancestor CU if it is different
10136         from the followed DIE's CU.
10137         (follow_die_sig_1): Likewise.
10138
10139 2019-01-15  Tom Tromey  <tom@tromey.com>
10140
10141         * remote.c (class remote_state) <buf>: Now a char_vector.
10142         <buf_size>: Remove.
10143         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10144         parameter.
10145         (remote_target::getpkt_or_notif_sane_1)
10146         (remote_target::getpkt_sane)
10147         (remote_target::getpkt_or_notif_sane): Likewise.
10148         (class remote_target) <putpkt>: New overload.
10149         (remote_target::read_frame): Change type of "buf_p".  Remove
10150         sizeof_p parameter.
10151         (packet_ok): New overload.
10152         (packet_check_result): New overload.
10153         Update all uses.
10154
10155 2019-01-14  Tom Tromey  <tom@tromey.com>
10156
10157         * remote-notif.c (handle_notification, remote_notif_ack)
10158         (remote_notif_parse): Make "buf" const.
10159         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10160         const.
10161         (remote_notif_parse, remote_notif_ack, handle_notification):
10162         Likewise.
10163         * remote.c (remote_notif_stop_parse): Make "buf" const.
10164         (remote_target::remote_parse_stop_reply): Make "buf" const.
10165         (remote_notif_stop_ack): Make "buf" const.
10166
10167 2019-01-14  Tom Tromey  <tom@tromey.com>
10168
10169         * remote.c (remote_console_output): Make parameter const.
10170
10171 2019-01-14  Tom Tromey  <tom@tromey.com>
10172
10173         * target-debug.h (target_debug_print_signals): Constify.
10174         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10175         * procfs.c (procfs_target::pass_signals): Update.
10176         * linux-nat.c (linux_nat_target::pass_signals): Update.
10177         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10178         * target-delegates.c: Rebuild.
10179         * remote.c (remote_target::program_signals): Update.
10180         (remote_target::pass_signals): Update.
10181         * target.c (target_pass_signals): Constify argument.
10182         (target_program_signals): Likewise.
10183         * target.h (struct target_ops) <pass_signals, program_signals>:
10184         Constify argument.
10185         (target_pass_signals, target_program_signals): Constify argument.
10186
10187 2019-01-14  Tom Tromey  <tom@tromey.com>
10188
10189         PR tui/28819:
10190         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10191
10192 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10193
10194         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10195         field.
10196         * rs6000-tdep.c: Include reggroups.h.
10197         (IS_V_ALIAS_PSEUDOREG): Define.
10198         (rs6000_register_name): Return names for the "vX" aliases.
10199         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10200         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10201         aliases.  Call default_register_reggroup_p for all other
10202         pseudo-registers.
10203         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10204         New functions.
10205         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10206         Handle "vX" aliases.
10207         (v_alias_pseudo_register_collect): New function.
10208         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10209         (rs6000_gdbarch_init): Initialize "vX" aliases as
10210         pseudo-registers.  Restore registration of
10211         rs6000_pseudo_register_reggroup_p with
10212         set_tdesc_pseudo_register_reggroup_p.
10213
10214 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10215
10216         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10217         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10218         set_gdbarch_num_pseudo_regs.
10219
10220 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10221
10222         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10223         Remove arg prefixname, add do_set and do_show.
10224         Add member functions set_list and show_list.
10225         * cli/cli-style.c (class cli_style_option): Update accordingly.
10226         (style_set_list): Move to file scope.
10227         (style_show_list): Likewise.
10228         (set_style): Call help_list.
10229         (show_style): Call cmd_show_list.
10230         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10231         Update to use the new macro.
10232
10233 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10234
10235         * ada-lang.c (_initialize_ada_language): Expand the help text
10236         for the "catch exception" command.
10237
10238 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10239
10240         * symtab.c (matching_obj_sections): Initialize obj,
10241         declare it closer to its usage.
10242
10243 2019-01-10  Tom Tromey  <tom@tromey.com>
10244
10245         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10246         (basic_inf_threads_range): Remove.
10247         (inf_threads_range, inf_non_exited_threads_range)
10248         (safe_inf_threads_range): Use next_adapter.
10249
10250 2019-01-10  Keith Seitz  <keiths@redhat.com>
10251
10252         PR gdb/23712
10253         PR symtab/23010
10254         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10255         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10256
10257 2019-01-10  Keith Seitz  <keiths@redhat.com>
10258
10259         PR gdb/23712
10260         PR symtab/23010
10261         * dictionary.c (pending_to_vector): Remove.
10262         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10263         Remove _1 suffix, replacing functions of the same name.  Update
10264         all callers.
10265         (dict_create_hashed, dict_create_hashed_expandable)
10266         (dict_create_linear, dict_create_linear_expandable, dict_free)
10267         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10268         Make functions static.
10269
10270 2019-01-10  Keith Seitz  <keiths@redhat.com>
10271
10272         PR gdb/23712
10273         PR symtab/23010
10274         * dictionary.h (struct dictionary): Replace declaration with
10275         multidictionary.
10276         (dict_create_hashed, dict_create_hashed_expandable)
10277         (dict_create_linear, dict_create_linear_expandable)
10278         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10279         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10280         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10281         taking multidictionary argument.
10282         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10283         * block.h (struct block) <dict>: Change to multidictionary
10284         and rename `multidict'.
10285         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10286         symmisc.c: Update all dictionary references to multidictionary.
10287
10288 2019-01-10  Keith Seitz  <keiths@redhat.com>
10289
10290         PR gdb/23712
10291         PR symtab/23010
10292         * dictionary.c: Include unordered_map.
10293         (pending_to_vector): New function.
10294         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10295         Rewrite the non-"_1" functions to take vector instead
10296         of linked list.
10297         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10298         "new" _1 versions of the same name.
10299         (multidictionary): Define.
10300         (std::hash<enum language): New definition.
10301         (collate_pending_symbols_by_language, mdict_create_hashed)
10302         (mdict_create_hashed_expandable, mdict_create_linear)
10303         (mdict_create_linear_expandable, mdict_free)
10304         (find_language_dictionary, create_new_language_dictionary)
10305         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10306         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10307         (mdict_size, mdict_empty): New functions.
10308         * dictionary.h (mdict_iterator): Define.
10309
10310 2019-01-10  Pedro Alves  <palves@redhat.com>
10311
10312         * breakpoint.c (read_uploaded_action)
10313         (create_tracepoint_from_upload): Adjust to use
10314         gdb::unique_xmalloc_ptr.
10315         * ctf.c (ctf_write_uploaded_tp):
10316         (SET_ARRAY_FIELD): Use emplace_back.
10317         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10318         * tracefile-tfile.c (tfile_write_uploaded_tp):
10319         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10320         gdb::unique_xmalloc_ptr.
10321         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10322         at_string, cond_string, cmd_strings>: Replace char pointers
10323         with gdb::unique_xmalloc_ptr.
10324
10325 2019-01-10  Pedro Alves  <palves@redhat.com>
10326
10327         * solib-target.c (library_list_start_library): Don't xstrdup name.
10328
10329 2019-01-10  Pedro Alves  <palves@redhat.com>
10330
10331         * mdebugread.c (parse_partial_symbols): Use
10332         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10333
10334 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10335
10336         * linux-fork.c (scoped_switch_fork_info)
10337         <~scoped_switch_fork_info>: Fix incorrect variable name.
10338
10339 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10340
10341         * linux-fork.c (scoped_switch_fork_info)
10342         <scoped_switch_fork_info>: Make explicit.
10343         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10344
10345 2019-01-10  Tom Tromey  <tom@tromey.com>
10346
10347         * objfiles.h (objfile::reset_psymtabs): Update.
10348         * objfiles.c (objfile::objfile): Update.
10349         * psymtab.h (psymtab_storage::obstack): Update.
10350         (psymtab_storage::m_obstack): Use gdb::optional.
10351         (class psymtab_storage): Update comment.  Remove objfile
10352         parameter.
10353         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10354
10355 2019-01-10  Tom Tromey  <tom@tromey.com>
10356
10357         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10358         <free_psymtabs>: Now private.
10359         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10360         (allocate_psymtab): Use new method.
10361
10362 2019-01-10  Tom Tromey  <tom@tromey.com>
10363
10364         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10365         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10366         * mdebugread.c (parse_partial_symbols): Use
10367         allocate_dependencies.
10368         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10369         allocate_dependencies.
10370         (process_psymtab_comp_unit_reader)
10371         (build_type_psymtab_dependencies): Likewise.
10372         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10373
10374 2019-01-10  Tom Tromey  <tom@tromey.com>
10375
10376         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10377         PSYMBOL_SET_LANGUAGE.
10378         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10379
10380 2019-01-10  Tom Tromey  <tom@tromey.com>
10381
10382         * psymtab.h (psymtab_storage::obstack): New method.
10383         <m_obstack>: Rename from obstack; now private.
10384         * psymtab.c (psymtab_storage): Update.
10385         * dwarf2read.c (create_addrmap_from_index)
10386         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10387         Update.
10388
10389 2019-01-10  Tom Tromey  <tom@tromey.com>
10390
10391         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10392         * objfiles.h (objfile::reset_psymtabs): New method.
10393
10394 2019-01-10  Tom Tromey  <tom@tromey.com>
10395
10396         * symmisc.c (print_symbol_bcache_statistics): Update.
10397         (print_objfile_statistics): Update.
10398         * symfile.c (reread_symbols): Update.
10399         * psymtab.h (class psymtab_storage): New.
10400         * psymtab.c (psymtab_storage): New constructor.
10401         (~psymtab_storage): New destructor.
10402         (require_partial_symbols): Update.
10403         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10404         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10405         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10406         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10407         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10408         (start_psymtab_common, end_psymtab_common)
10409         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10410         (allocate_psymtab): Update.
10411         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10412         Update.
10413         (dump_psymtab_addrmap, maintenance_print_psymbols)
10414         (maintenance_check_psymtabs): Update.
10415         (class objfile_psymtabs): Move to objfiles.h.
10416         * psympriv.h (discard_psymtab): Now inline.
10417         (psymtab_discarder::psymtab_discarder): Update.
10418         (psymtab_discarder::~psymtab_discarder): Update.
10419         (ALL_OBJFILE_PSYMTABS): Rewrite.
10420         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10421         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10422         Remove fields.
10423         <partial_symtabs>: New field.
10424         (class objfile_psymtabs): Move from psymtab.h.  Update.
10425         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10426         psymbol_cache.
10427         (objfile::~objfile): Don't destroy psymbol_cache.
10428         * mdebugread.c (parse_partial_symbols): Update.
10429         * dwarf2read.c (create_addrmap_from_index)
10430         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10431         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10432         (add_partial_subprogram, dwarf2_ranges_read): Update.
10433         * dwarf-index-write.c (write_address_map)
10434         (write_one_signatured_type, recursively_write_psymbols)
10435         (class debug_names, class debug_names, write_psymtabs_to_index):
10436         Update.
10437
10438 2019-01-10  Tom Tromey  <tom@tromey.com>
10439
10440         * symtab.h (SYMBOL_SET_NAMES): Update.
10441         (symbol_set_names): Update.
10442         (MSYMBOL_SET_NAMES): Update.
10443         * symtab.c (symbol_set_names): Change argument to be an
10444         objfile_per_bfd_storage.
10445         * psymtab.c (add_psymbol_to_bcache): Update.
10446         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10447
10448 2019-01-10  Tom Tromey  <tom@tromey.com>
10449
10450         * symtab.c (create_demangled_names_hash): Change argument to be an
10451         objfile_per_bfd_storage.
10452         (symbol_set_names): Update.
10453
10454 2019-01-10  Tom Tromey  <tom@tromey.com>
10455
10456         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10457         init_psymbol_list.
10458         * psymtab.c (init_psymbol_list): Do nothing if already called.
10459         * psympriv.h (init_psymbol_list): Add comment.
10460         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10461         init_psymbol_list.
10462         * dbxread.c (dbx_symfile_read): Unconditionally call
10463         init_psymbol_list.
10464
10465 2019-01-10  Tom Tromey  <tom@tromey.com>
10466
10467         * xcoffread.c (scan_xcoff_symtab): Update.
10468         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10469         "where".
10470         * mdebugread.c (parse_partial_symbols)
10471         (handle_psymbol_enumerators): Update.
10472         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10473         * dbxread.c (read_dbx_symtab): Update.
10474         * psympriv.h (psymbol_placement): New enum.
10475         (add_psymbol_to_list): Update.
10476
10477 2019-01-10  Tom Tromey  <tom@tromey.com>
10478
10479         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10480         static_psymbols parameters.
10481         (scan_xcoff_symtab): Update.
10482         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10483         static_psymbols parameters.
10484         * psympriv.h (start_psymtab_common): Update.
10485         * mdebugread.c (parse_partial_symbols): Update.
10486         * dwarf2read.c (create_partial_symtab): Update.
10487         * dbxread.c (read_dbx_symtab): Update.
10488         (start_psymtab): Remove global_psymbols and static_psymbols
10489         parameters.
10490
10491 2019-01-10  Tom Tromey  <tom@tromey.com>
10492
10493         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10494         * psymtab.c (allocate_psymtab): Add comment.
10495         * psympriv.h (allocate_psymtab): Add comment.
10496         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10497         initializations.
10498         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10499
10500 2019-01-10  Tom Tromey  <tom@tromey.com>
10501
10502         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10503         Don't declare.
10504         * mipsread.c: Include mdebugread.h.
10505         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10506         Declare.
10507         * elfread.c: Include mdebugread.h.
10508
10509 2019-01-09  Tom Tromey  <tom@tromey.com>
10510
10511         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10512         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10513         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10514         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10515         (psym_lookup_symbol, psym_find_last_source_symtab)
10516         (psym_forget_cached_source_info, psym_print_stats)
10517         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10518         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10519         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10520         (psym_find_compunit_symtab_by_address)
10521         (maintenance_print_psymbols, maintenance_info_psymtabs)
10522         (maintenance_check_psymtabs): Use ranged for.
10523         * psymtab.h (class objfile_psymtabs): New.
10524         (require_partial_symbols): Return objfile_psymtabs.
10525         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10526
10527 2019-01-09  Tom Tromey  <tom@tromey.com>
10528
10529         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10530         (find_pc_mapped_section, list_overlays_command)
10531         (map_overlay_command, unmap_overlay_command)
10532         (simple_overlay_update): Use all_objfiles.
10533         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10534         * printcmd.c (info_symbol_command): Use all_objfiles.
10535         * objfiles.h (ALL_OBJSECTIONS): Remove.
10536         * maint.c (maintenance_translate_address): Use all_objfiles.
10537         * gcore.c (gcore_create_callback): Use all_objfiles.
10538         (objfile_find_memory_regions): Likewise.
10539
10540 2019-01-09  Tom Tromey  <tom@tromey.com>
10541
10542         * symtab.c (find_line_symtab, info_sources_command)
10543         (make_source_files_completion_list): Use objfile_compunits.
10544         * source.c (select_source_symtab): Use objfile_compunits.
10545         * objfiles.h (struct objfile): Update comment.
10546         (ALL_OBJFILES): Remove.
10547         (ALL_FILETABS): Remove.
10548         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10549         objfile_compunits.
10550
10551 2019-01-09  Tom Tromey  <tom@tromey.com>
10552
10553         * symmisc.c (print_objfile_statistics, dump_objfile)
10554         (maintenance_print_symbols): Use compunit_filetabs.
10555         * source.c (forget_cached_source_info_for_objfile): Use
10556         compunit_filetabs.
10557         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10558         (ALL_FILETABS): Use compunit_filetabs.
10559         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10560         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10561
10562 2019-01-09  Tom Tromey  <tom@tromey.com>
10563
10564         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10565         (compunit_filetabs): New.
10566         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10567         compunit_filetabs.
10568         (info_sources_command, make_source_files_completion_list): Remove
10569         declaration.
10570         * symmisc.c (print_objfile_statistics, dump_objfile)
10571         (maintenance_print_symbols): Remove declaration.
10572         (maintenance_info_symtabs): Use compunit_filetabs.
10573         (maintenance_info_line_tables): Likewise.
10574         * source.c (select_source_symtab): Change local variable name.
10575         (forget_cached_source_info_for_objfile): Remove declaration.
10576         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10577         * objfiles.c (objfile_relocate1): Remove declaration.
10578         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10579         declaration.
10580         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10581         * coffread.c (coff_symtab_read): Remove declaration.
10582         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10583         compunit_filetabs.
10584
10585 2019-01-09  Tom Tromey  <tom@tromey.com>
10586
10587         * symtab.c (lookup_objfile_from_block)
10588         (find_pc_sect_compunit_symtab, search_symbols)
10589         (default_collect_symbol_completion_matches_break_on): Use
10590         objfile_compunits.
10591         * objfiles.h (ALL_COMPUNITS): Remove.
10592         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10593         * cp-support.c (add_symbol_overload_list_qualified): Use
10594         objfile_compunits.
10595         * ada-lang.c (ada_collect_symbol_completion_matches)
10596         (ada_add_global_exceptions): Use objfile_compunits.
10597
10598 2019-01-09  Tom Tromey  <tom@tromey.com>
10599
10600         * source.c (select_source_symtab)
10601         (forget_cached_source_info_for_objfile): Remove declaration.
10602         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10603         declaration.
10604         * maint.c (count_symtabs_and_blocks): Remove declaration.
10605         * cp-support.c (add_symbol_overload_list_qualified): Remove
10606         declaration.
10607         * coffread.c (coff_symtab_read): Remove declaration.
10608         * symtab.c (lookup_symbol_in_objfile_symtabs)
10609         (basic_lookup_transparent_type_1): Use objfile_compunits.
10610         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10611         (info_sources_command, search_symbols)
10612         (default_collect_symbol_completion_matches_break_on)
10613         (make_source_files_completion_list): Remove declaration.
10614         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10615         (ada_collect_symbol_completion_matches)
10616         (ada_add_global_exceptions): Remove declaration.
10617         * linespec.c (iterate_over_all_matching_symtabs): Use
10618         objfile_compunits.
10619         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10620         (class objfile_compunits): New.
10621         (ALL_COMPUNITS): Use objfile_compunits.
10622         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10623         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10624         objfile_compunits.
10625         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10626
10627 2019-01-09  Tom Tromey  <tom@tromey.com>
10628
10629         * symtab.c (search_symbols)
10630         (default_collect_symbol_completion_matches_break_on): Use
10631         objfile_msymbols.
10632         * ada-lang.c (ada_lookup_simple_minsym)
10633         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10634         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10635         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10636         objfile_msymbols.
10637         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10638         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10639         * objc-lang.c (find_methods): Use objfile_msymbols.
10640         (info_selectors_command, info_classes_command): Likewise.
10641         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10642         * objfiles.h (class objfile_msymbols): New.
10643         (ALL_OBJFILE_MSYMBOLS): Remove.
10644         (ALL_MSYMBOLS): Remove.
10645
10646 2019-01-09  Tom Tromey  <tom@tromey.com>
10647
10648         * common/next-iterator.h (next_adapter): Add Iterator template
10649         parameter.
10650         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10651         (class all_objfiles_safe): New.
10652         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10653         * objfiles.c (put_objfile_before): Update comment.
10654         (add_separate_debug_objfile): Likewise.
10655         (free_all_objfiles): Use all_objfiles_safe.
10656         (objfile_purge_solibs): Likewise.
10657
10658 2019-01-09  Tom Tromey  <tom@tromey.com>
10659
10660         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10661         (expand_symtab_containing_pc, lookup_static_symbol)
10662         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10663         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10664         all_objfiles.
10665         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10666         * breakpoint.c (create_overlay_event_breakpoint)
10667         (create_longjmp_master_breakpoint)
10668         (create_std_terminate_master_breakpoint)
10669         (create_exception_master_breakpoint): Use all_objfiles.
10670         * linux-thread-db.c (try_thread_db_load_from_pdir)
10671         (has_libpthread): Use all_objfiles.
10672         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10673         * linespec.c (iterate_over_all_matching_symtabs)
10674         (search_minsyms_for_name): Use all_objfiles.
10675         * maint.c (maintenance_info_sections): Use all_objfiles.
10676         * main.c (captured_main_1): Use all_objfiles.
10677         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10678         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10679         * guile/scm-pretty-print.c
10680         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10681         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10682         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10683         (maintenance_print_msymbols): Use all_objfiles.
10684         * source.c (select_source_symtab): Use all_objfiles.
10685         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10686         * symfile.c (remove_symbol_file_command)
10687         (expand_symtabs_matching, map_symbol_filenames): Use
10688         all_objfiles.
10689         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10690         all_objfiles.
10691         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10692         * objc-lang.c (find_methods): Use all_objfiles.
10693         * objfiles.c (have_partial_symbols, have_full_symbols)
10694         (have_minimal_symbols, qsort_cmp)
10695         (default_iterate_over_objfiles_in_search_order): Use
10696         all_objfiles.
10697         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10698         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10699         (maintenance_check_psymtabs): Use all_objfiles.
10700         (ALL_PSYMTABS): Remove.
10701         * compile/compile-object-run.c (do_module_cleanup): Use
10702         all_objfiles.
10703         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10704         * cp-support.c (add_symbol_overload_list_qualified): Use
10705         all_objfiles.
10706         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10707         Use all_objfiles.
10708         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10709         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10710         all_objfiles.
10711         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10712         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10713         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10714         Uses all_objfiles.
10715         * solib.c (solib_read_symbols): Use all_objfiles
10716
10717 2019-01-09  Tom Tromey  <tom@tromey.com>
10718
10719         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10720         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10721         all_objfiles.
10722         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10723         * symmisc.c (print_symbol_bcache_statistics)
10724         (print_objfile_statistics, maintenance_print_objfiles)
10725         (maintenance_info_symtabs, maintenance_check_symtabs)
10726         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10727         all_objfiles.
10728         * source.c (forget_cached_source_info): Use all_objfiles.
10729         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10730         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10731         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10732         * objfiles.c (update_section_map): Use all_objfiles.
10733         (shared_objfile_contains_address_p): Likewise.
10734         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10735         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10736
10737 2019-01-09  Tom Tromey  <tom@tromey.com>
10738
10739         * common/next-iterator.h: New file.
10740         * objfiles.h (class all_objfiles): New.
10741         (struct objfile_iterator): New.
10742
10743 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10744
10745         * NEWS: Move the description of the changed "frame", "select-frame",
10746          and "info frame" commands to the Changed commands section.
10747
10748 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10749
10750         * gdbtypes.c (check_stub_method_group): Remove handling of old
10751         mangling schemes.
10752         * linespec.c (find_methods): Likewise.
10753         * stabsread.c (read_member_functions): Likewise.
10754         * valops.c (search_struct_method): Likewise.
10755         (value_struct_elt_for_reference): Likewise.
10756         * NEWS: Mention this change.
10757
10758 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10759
10760         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10761         print_source_lines.
10762         * source.c (print_source_lines_base): Update line number check.
10763         (print_source_lines): New function.
10764         (source_lines_range::source_lines_range): New function.
10765         * source.h (class source_lines_range): New class.
10766         (print_source_lines): New declaration.
10767
10768 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10769
10770         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10771
10772 2019-01-08  Tom Tromey  <tom@tromey.com>
10773             Simon Marchi  <simon.marchi@ericsson.com>
10774
10775         PR gdb/24060
10776         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10777         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10778         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10779         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10780         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10781         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10782
10783 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10784
10785         * source.c (select_source_symtab): Move header comment to
10786         declaration in source.h.
10787         (forget_cached_source_info_for_objfile): Likewise.
10788         (forget_cached_source_info): Likewise.
10789         (identify_source_line): Likewise.
10790         * source.h (identify_source_line): Move declaration from symtab.h
10791         and add comment from source.c
10792         (print_source_lines): Likewise.
10793         (forget_cached_source_info_for_objfile): Likewise.
10794         (forget_cached_source_info): Likewise.
10795         (select_source_symtab): Likewise.
10796         (enum print_source_lines_flag): Move definition from symtab.h.
10797         * symtab.h (identify_source_line): Move declaration to source.h.
10798         (print_source_lines): Likewise.
10799         (forget_cached_source_info_for_objfile): Likewise.
10800         (forget_cached_source_info): Likewise.
10801         (select_source_symtab): Likewise.
10802         (enum print_source_lines_flag): Move definition to source.h.
10803         * tui/tui-hooks.c: Add 'source.h' include.
10804
10805 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10806
10807         * source.c (print_source_lines_base): Handle requests to print
10808         reverse line number sequences, and guard against empty lines
10809         string.
10810
10811 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10812
10813         * source.c (print_source_lines_base): Fix skip of '\r' if next
10814         character is '\n'.
10815
10816 2019-01-06  Tom Tromey  <tom@tromey.com>
10817
10818         * c-exp.y (struct c_parse_state) <macro_original_text,
10819         expansion_obstack>: New member.
10820         (macro_original_text, expansion_obstack): Remove globals.
10821         (scan_macro_expansion, scanning_macro_expansion)
10822         (finished_macro_expansion): Update.
10823         (scan_macro_cleanup): Remove.
10824         (yylex, c_parse): Update.
10825
10826 2019-01-06  Tom Tromey  <tom@tromey.com>
10827
10828         * c-exp.y (struct c_parse_state) <strings>: New member.
10829         (operator_stoken): Update.
10830
10831 2019-01-06  Tom Tromey  <tom@tromey.com>
10832
10833         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10834         (union type_stack_elt) <typelist_val>: Now a pointer to
10835         std::vector.
10836         (type_stack_cleanup): Don't declare.
10837         (push_typelist): Update.
10838         * parse.c (pop_typelist): Return a std::vector.
10839         (push_typelist): Take a std::vector.
10840         (follow_types): Update.  Do not free args.
10841         (type_stack_cleanup): Remove.
10842         * c-exp.y (struct c_parse_state): New.
10843         (cpstate): New global.
10844         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10845         (nonempty_typelist): Update.
10846         (func_mod): Create a new vector.
10847         (c_parse): Create a c_parse_state.
10848         (check_parameter_typelist): Do not delete params.
10849         (function_method): Update.  Do not delete type_list.
10850
10851 2019-01-06  Tom Tromey  <tom@tromey.com>
10852
10853         PR gdb/28155:
10854         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10855         check_typedef.
10856         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10857         (print_return_value): Likewise.
10858
10859 2019-01-05  Tom Tromey  <tom@tromey.com>
10860
10861         * contrib/cleanup_check.py: Remove.
10862         * contrib/gcc-with-excheck: Remove.
10863         * contrib/exsummary.py: Remove.
10864         * contrib/excheck.py: Remove.
10865
10866 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10867
10868         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10869         NULL. Initialize tpprev to NULL instead of assigning it
10870         to NULL on the next statement.
10871         * windows-nat.c (windows_delete_thread): Remove check for
10872         main_thread_id before printing thread exit notifications.
10873         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10874         Remove thread ID check against main_thread_id.
10875         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10876         windows_delete_thread.
10877         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10878
10879 2019-01-04  Tom Tromey  <tom@tromey.com>
10880
10881         * compile/compile.c (_initialize_compile): Use upper case for
10882         metasyntactic variables.
10883         * symmisc.c (_initialize_symmisc): Use upper case for
10884         metasyntactic variables.
10885         * psymtab.c (_initialize_psymtab): Use upper case for
10886         metasyntactic variables.
10887         * demangle.c (demangle_command): Use upper case for metasyntactic
10888         variables.
10889         (_initialize_demangler): Likewise.
10890         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10891         variables.
10892
10893 2019-01-03  Tom Tromey  <tom@tromey.com>
10894
10895         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10896
10897 2019-01-03  Tom Tromey  <tom@tromey.com>
10898
10899         * python/py-symtab.c (salpy_str): Update.
10900         (struct salpy_sal_object) <symtab>: Now a PyObject.
10901         (salpy_dealloc): Update.
10902         (del_objfile_sal): Use gdbpy_ref.
10903
10904 2019-01-03  Tom Tromey  <tom@tromey.com>
10905
10906         * python/py-type.c (convert_field): Use new_reference.  Return
10907         gdbpy_ref.
10908         (make_fielditem): Return gdbpy_ref.
10909         (typy_fields): Update.
10910         (typy_getitem): Update.
10911         (field_name): Return gdbpy_ref.  Use new_reference.
10912         (typy_iterator_iternext): Update.
10913
10914 2019-01-03  Tom Tromey  <tom@tromey.com>
10915
10916         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10917
10918 2019-01-03  Tom Tromey  <tom@tromey.com>
10919
10920         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10921         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10922         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10923         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10924         (pspy_set_type_printers): Likewise.
10925         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10926         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10927         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10928         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10929         (objfpy_set_type_printers): Likewise.
10930
10931 2019-01-03  Tom Tromey  <tom@tromey.com>
10932
10933         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10934         (gdbpy_print_stack): Use gdbpy_err_fetch.
10935         * python/python-internal.h (class gdbpy_err_fetch): New class.
10936         (class gdbpy_enter) <m_error_type, m_error_value,
10937         m_error_traceback>: Remove.
10938         <m_error>: New member.
10939         (gdbpy_exception_to_string): Don't declare.
10940         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10941         * python/py-value.c (convert_value_from_python): Use
10942         gdbpy_err_fetch.
10943         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10944         gdbpy_exception_to_string.
10945         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10946         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10947         gdbpy_err_fetch.
10948
10949 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10950
10951         * linux-nat.c (delete_lwp_cleanup): Delete.
10952         (struct lwp_deleter): New struct.
10953         (lwp_info_up): New typedef.
10954         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10955         lwp_info_up.
10956
10957 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10958
10959         * linux-fork.c (class scoped_switch_fork_info): New class.
10960         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10961
10962 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10963
10964         * valops.c (find_overload_match): Remove use of null_cleanup, and
10965         calls to do_cleanups.
10966
10967 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10968
10969         * compile/compile-cplus-types.c
10970         (compile_cplus_instance::decl_name): Handle changes to
10971         cp_func_name.
10972         * cp-support.c (cp_func_name): Update header comment, update
10973         return type.
10974         * cp-support.h (cp_func_name): Update return type in declaration.
10975         * valops.c (find_overload_match): Move temp_func local to top
10976         level of function and change its type.  Use temp_func to hold and
10977         delete temporary string obtained from cp_func_name.
10978
10979 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10980
10981         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10982         gdb::char_vector, remove cleanup, and update uses of `msg`.
10983
10984 2019-01-03  Jim Wilson  <jimw@sifive.com>
10985
10986         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10987
10988 2019-01-02  Tom Tromey  <tom@tromey.com>
10989
10990         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10991         (tdesc_parse_xml): Remove cleanups.
10992         * target-descriptions.h (make_cleanup_free_target_description):
10993         Don't declare.
10994         (target_desc_deleter): New struct.
10995         (target_desc_up): New typedef.
10996         * target-descriptions.c (target_desc_deleter::operator()): Rename
10997         from free_target_description.
10998         (make_cleanup_free_target_description): Remove.
10999
11000 2019-01-02  Tom Tromey  <tom@tromey.com>
11001
11002         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11003         constructor, destructor.
11004         (linespec_parser): Remove typedef.
11005         (~linespec_parser): Rename from linespec_parser_delete.
11006         (linespec_lex_to_end, linespec_complete_label)
11007         (linespec_complete): Update.
11008         (decode_line_full): Remove cleanups.
11009         (decode_line_1): Update.
11010
11011 2019-01-02  Tom Tromey  <tom@tromey.com>
11012
11013         * python/python-internal.h (inferior_to_inferior_object): Change
11014         return type.
11015         * python/py-exitedevent.c (create_exited_event_object): Update.
11016         * python/py-inferior.c (inferior_to_inferior_object): Return
11017         gdbpy_ref.
11018         (python_new_inferior, python_inferior_deleted)
11019         (thread_to_thread_object, delete_thread_object)
11020         (build_inferior_list, gdbpy_selected_inferior): Update.
11021         * python/py-infthread.c (create_thread_object): Update.  Also fail
11022         if inferior_to_inferior_object fails.
11023
11024 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11025
11026         * inferior.h (class inferior) <displaced_step_state>: New field.
11027         * infrun.h (struct displaced_step_state): Move here from
11028         infrun.c.  Initialize fields, add constructor.
11029         <inf>: Remove field.
11030         <reset>: New method.
11031         * infrun.c (struct displaced_step_inferior_state): Move to
11032         infrun.h.
11033         (displaced_step_inferior_states): Remove.
11034         (get_displaced_stepping_state): Adust.
11035         (displaced_step_in_progress_any_inferior): Adjust.
11036         (displaced_step_in_progress_thread): Adjust.
11037         (displaced_step_in_progress): Adjust.
11038         (add_displaced_stepping_state): Remove.
11039         (get_displaced_step_closure_by_addr): Adjust.
11040         (remove_displaced_stepping_state): Remove.
11041         (infrun_inferior_exit): Call displaced_step_state.reset.
11042         (use_displaced_stepping): Don't check for NULL.
11043         (displaced_step_prepare_throw): Call
11044         get_displaced_stepping_state.
11045         (displaced_step_fixup): Don't check for NULL.
11046         (prepare_for_detach): Don't check for NULL.
11047
11048 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11049
11050         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11051          in case of call that did not complete.
11052
11053 2019-01-02  Andrey Utkin  <autkin@undo.io>
11054
11055         * symfile.c (find_separate_debug_file): Fix search of debug files for
11056         remote debuggee.
11057
11058 2019-01-02  Tom Tromey  <tom@tromey.com>
11059
11060         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11061         indentation.
11062         * python/py-frame.c (frapy_older): Remove cast.
11063         (frapy_newer): Likewise.
11064         * python/py-breakpoint.c (local_setattro): Remove cast.
11065         * python/py-arch.c (archpy_name): Remove local variable.
11066         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11067
11068 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11069
11070         * unittests/basic_string_view/element_access/char/empty.cc:
11071         Fix year range in copyright header.
11072
11073 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11074
11075         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11076         Delete.
11077         <operator==>: Update with for removed field.
11078         <hash>: Likewise.
11079         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11080         <isa_features>: ...this.
11081         <abi_features>: New field.
11082         (riscv_isa_flen): Update comment.
11083         (riscv_abi_xlen): New declaration.
11084         (riscv_abi_flen): New declaration.
11085         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11086         isa_features.
11087         (riscv_abi_xlen): New function.
11088         (riscv_isa_flen): Update to get answer from isa_features.
11089         (riscv_abi_flen): New function.
11090         (riscv_has_fp_abi): Update to get answer from abi_features.
11091         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11092         xlen and flen.
11093         (riscv_call_info) <xlen, flen>: Update comment.
11094         (riscv_call_arg_struct): Remove invalid assertions
11095         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11096         is removed.
11097         (riscv_gdbarch_init): Gather isa features and abi features
11098         separately, ensure both match on the gdbarch when reusing an old
11099         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11100         a target with 64-bit float hardware.
11101
11102 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11103
11104         * source.c (search_command_helper): Stop reverse search
11105         when line 1 has been searched.
11106
11107 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11108
11109         * record-full.c (record_full_base_target::close): Rewrite
11110         record_full_core_buf_list free logic.
11111
11112 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11113
11114         * break-catch-syscall.c (print_one_catch_syscall): xfree
11115         the last text.
11116
11117 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11118
11119         * top.c (print_gdb_version): Update Copyright year in version
11120         message.
11121
11122 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11123
11124         Update copyright year range in all GDB files.
11125
11126 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11127
11128         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11129
11130 For older changes see ChangeLog-2018.
11131 \f
11132 Local Variables:
11133 mode: change-log
11134 left-margin: 8
11135 fill-column: 74
11136 version-control: never
11137 coding: utf-8
11138 End:
11139