1 2019-03-18 Hannes Domani <ssbssa@yahoo.de>
3 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6 2019-03-17 Eli Zaretskii <eliz@gnu.org>
8 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9 tui_refill_source_window instead of tui_refresh_win, to update the
10 current execution line. This fixes redisplay of the current line
11 when stepping through the code with "next" or "step".
13 2019-03-16 Eli Zaretskii <eliz@gnu.org>
15 * source-cache.c (source_cache::get_source_lines): Call
16 find_source_lines to initialize s->nlines. This fixes vertical
17 scrolling of TUI source window when the DOWN arrow is pressed.
19 2019-03-16 Eli Zaretskii <eliz@gnu.org>
21 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
22 wclrtoeol in tui_show_source_line". This reverts changes made in
23 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
25 2019-03-12 John Baldwin <jhb@FreeBSD.org>
27 * NEWS: Combine separate "New targets" sections for 8.3.
29 2019-03-14 Eli Zaretskii <eliz@gnu.org>
31 The MS-Windows port of ncurses fails to switch to a color pair if
32 one or both of the colors are the implicit default colors. This
33 change records the default colors when TUI is initialized, and
34 then specifies them explicitly when a color pair uses the default
35 colors. This allows color styling in TUI mode on MS-Windows.
37 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
39 (tui_initialize_io) [__MINGW32__]: Record the default terminal
40 colors in ncurses_norm_attr.
41 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
42 "none", replace it with the default color recorded in
45 2019-03-14 Tom Tromey <tromey@adacore.com>
47 * source-cache.h (class source_cache) <get_source_lines>: Return
49 * source-cache.c (source_cache::extract_lines): Handle case where
50 first_pos==npos. Return std::string.
51 (source_cache::get_source_lines): Update.
53 2019-03-14 Tom Tromey <tromey@adacore.com>
55 * NEWS: Add item for "style sources" commands.
56 * source-cache.c (source_cache::get_source_lines): Check
58 * cli/cli-style.c (source_styling): New global.
59 (_initialize_cli_style): Add "style sources" commands.
60 (show_style_sources): New function.
61 * cli/cli-style.h (source_styling): Declare.
63 2019-03-14 Pedro Alves <palves@redhat.com>
64 Tom Tromey <tromey@adacore.com>
66 * tui/tui-winsource.h (tui_refill_source_window): Declare.
67 * tui/tui-winsource.c (tui_refill_source_window): New function,
69 (tui_horizontal_source_scroll): ... here. Move some logic.
70 * cli/cli-style.c (set_style_enabled): Notify new observable.
71 * tui/tui-hooks.c (tui_redisplay_source): New function.
72 (tui_attach_detach_observers): Attach or detach
74 * observable.h (source_styling_changed): New observable.
75 * observable.c: Define source_styling_changed observable.
77 2019-03-12 Eli Zaretskii <eliz@gnu.org>
80 * source-cache.c: #undef open and close, to avoid unresolved
81 externals during linking.
83 2019-03-08 Eli Zaretskii <eliz@gnu.org>
85 Support styling on native MS-Windows console
88 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
89 on MS-Windows if $TERM is not defined.
91 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
93 * posix-hdep.c (gdb_console_fputs):
94 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
96 * ui-file.h (gdb_console_fputs): Add prototype.
98 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
99 back to fputs only if the former returns zero.
101 2019-03-07 Brian Vandenberg <phantall@gmail.com>
102 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
105 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
106 set_sigint_trap, clear_sigint_trap.
108 2019-03-02 Eli Zaretskii <eliz@gnu.org>
110 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
111 for-loop range, to avoid compiler warnings.
113 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
114 avoid compiler warnings about unused variables.
116 2019-03-02 Eli Zaretskii <eliz@gnu.org>
118 * NEWS: Mention end of support for native debugging on MS-Windows
121 2019-03-02 Eli Zaretskii <eliz@gnu.org>
125 * gdbserver/gdbreplay.c
126 * gdbserver/remote-utils.c:
128 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
129 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
130 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
131 'getaddrinfo' and 'freeaddrinfo' were not available before
132 Windows XP, and mingw.org's MinGW headers by default define
133 _WIN32_WINNT to 0x500.
135 2019-02-27 Kevin Buettner <kevinb@redhat.com>
137 * NEWS: Note minimum Python version.
139 2019-02-27 Joel Brobecker <brobecker@adacore.com>
141 * version.in: Set GDB version number to 8.2.90.DATE-git.
143 2019-02-27 Joel Brobecker <brobecker@adacore.com>
147 2019-02-27 Joel Brobecker <brobecker@adacore.com>
149 * version.in: Set GDB version number to 8.2.90.
151 2019-02-27 Joel Brobecker <brobecker@adacore.com>
153 * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
155 2019-02-27 Joel Brobecker <brobecker@adacore.com>
157 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
158 * version.in: Bump version to 8.2.90.DATE-git.
160 2019-02-26 Simon Marchi <simon.marchi@efficios.com>
162 * aix-thread.c (ptid_cmp): Remove unused variable.
163 (get_signaled_thread): Likewise.
164 (store_regs_user_thread): Likewise.
165 (store_regs_kernel_thread): Likewise.
166 (fetch_regs_kernel_thread): Remove shadowed variable.
168 2019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
170 * features/riscv/32bit-cpu.xml: Add register numbers.
171 * features/riscv/32bit-fpu.c: Regenerate.
172 * features/riscv/32bit-fpu.xml: Add register numbers.
173 * features/riscv/64bit-cpu.xml: Add register numbers.
174 * features/riscv/64bit-fpu.c: Regenerate.
175 * features/riscv/64bit-fpu.xml: Add register numbers.
177 2019-02-26 Kevin Buettner <kevinb@redhat.com>
179 * NEWS: Mention two argument form of gdb.Value constructor.
180 * python/py-value.c (convert_buffer_and_type_to_value): New
182 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
183 Add support for handling an optional second argument. Call
184 convert_buffer_and_type_to_value as appropriate.
185 * python/python-internal.h (Py_buffer_deleter): New struct.
186 (Py_buffer_up): New typedef.
188 2019-02-25 John Baldwin <jhb@FreeBSD.org>
190 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
191 instead of releasing ownership.
193 2019-02-25 Jordan Rupprecht <rupprecht@google.com>
195 * dwarf2read.c (open_and_init_dwp_file): Call
196 elf_numsections instead of bfd_count_sections to initialize
197 dwp_file->num_sections.
199 2019-02-25 Tom Tromey <tromey@adacore.com>
201 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
203 2019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
205 * gcore.in: Add '--readnever' option when invoking GDB.
207 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
209 * MAINTAINERS: Update my email address.
211 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
213 * build-id.c (build_id_to_debug_bfd_1): New function.
214 (build_id_to_debug_bfd): Look for separate debug file in
217 2019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
219 * gdbarch.sh: Update the copyright year range that is placed into
222 2019-02-22 Keith Seitz <keiths@redhat.com>
225 * linespec.c (create_sals_line_offset): Search for the default
226 symtab's filename instead of its fullname.
228 2019-02-21 Alan Hayward <alan.hayward@arm.com>
230 * NEWS: Update style defaults.
232 2019-02-21 Alan Hayward <alan.hayward@arm.com>
234 * main.c (captured_main_1): Disable styling in batch mode.
236 2019-02-20 Tom Tromey <tom@tromey.com>
238 * symtab.c (symtab_symbol_info): Fix typos.
240 2019-02-20 Tom Tromey <tromey@adacore.com>
242 * findcmd.c (_initialize_mem_search): Use upper case for
243 metasyntactic variables.
245 2019-02-20 Alan Hayward <alan.hayward@arm.com>
247 * aarch64-tdep.c (aarch64_add_reggroups): New function.
248 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
250 2019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
252 * top.h (source_file_name): Change to std::string.
253 * top.c (source_file_name): Likewise.
254 (command_line_input): Adjust.
255 * cli/cli-script.c (script_from_file): Adjust.
257 2019-02-19 Tom Tromey <tromey@adacore.com>
260 (ravenscar_thread_target::update_thread_list): Don't call
262 * ada-lang.h (ada_build_task_list): Don't declare.
263 * ada-tasks.c (struct ada_tasks_inferior_data)
264 <task_list_valid_p>: Now bool.
265 (read_known_tasks, ada_task_list_changed)
266 (ada_tasks_invalidate_inferior_data): Update.
267 (read_known_tasks_array): Return bool.
268 (read_known_tasks_list): Likewise.
269 (read_known_tasks): Return void.
270 (ada_build_task_list): Now static.
272 2019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
274 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
275 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
277 2019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
279 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
280 variant for ada_tasks_pspace_data_handle and
281 ada_tasks_inferior_data_handle.
282 (ada_tasks_pspace_data_cleanup): New function.
283 (ada_tasks_inferior_data_cleanup): New function.
285 2019-02-17 Tom Tromey <tom@tromey.com>
287 * macrotab.h (macro_source_fullname): Return a std::string.
288 * macrotab.c (macro_include, check_for_redefinition)
289 (macro_undef, macro_lookup_definition, foreach_macro)
290 (foreach_macro_in_scope): Update.
291 (macro_source_fullname): Return a std::string.
292 * macrocmd.c (show_pp_source_pos): Update.
294 2019-02-17 Tom Tromey <tom@tromey.com>
296 * macrocmd.c (show_pp_source_pos): Style the file names.
298 2019-02-17 Tom Tromey <tom@tromey.com>
301 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
303 2019-02-17 Tom Tromey <tom@tromey.com>
305 * ada-lang.c (user_select_syms): Use filtered printing.
306 * utils.c (wrap_style): New global.
307 (desired_style): Remove.
308 (emit_style_escape): Add stream parameter.
309 (set_output_style, reset_terminal_style, prompt_for_continue):
311 (flush_wrap_buffer): Only flush gdb_stdout.
312 (wrap_here): Set wrap_style.
313 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
314 treat escape sequences as a character. Change when wrap buffer is
316 (fputs_styled): Do not set the output style when the default is
318 * ui-style.h (struct ui_file_style) <is_default>: New method.
319 * source.c (print_source_lines_base): Emit escape sequences in one
322 2019-02-17 Joel Brobecker <brobecker@adacore.com>
324 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
325 integers and enumeration types.
327 2019-02-17 Joel Brobecker <brobecker@adacore.com>
329 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
330 instead of lookup_symbol_in_language
331 (do_exact_match): New function.
332 (ada_get_symbol_name_matcher): Return do_exact_match when
333 doing a verbatim match.
335 2019-02-15 Tom Tromey <tromey@adacore.com>
337 * ravenscar-thread.c (ravenscar_thread_target::resume)
338 (ravenscar_thread_target::wait): Special case wildcard requests.
340 2019-02-15 Tom Tromey <tromey@adacore.com>
342 * ravenscar-thread.c (base_ptid): Remove.
343 (struct ravenscar_thread_target) <close>: New method.
344 <m_base_ptid>: New member.
345 <update_inferior_ptid, active_task, task_is_currently_active,
346 runtime_initialized>: Declare methods.
347 <ravenscar_thread_target>: Add constructor.
348 (ravenscar_thread_target::task_is_currently_active)
349 (ravenscar_thread_target::update_inferior_ptid)
350 (ravenscar_runtime_initialized): Rename. Now methods.
351 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
352 (ravenscar_thread_target::update_thread_list): Update.
353 (ravenscar_thread_target::active_task): Now method.
354 (ravenscar_thread_target::store_registers)
355 (ravenscar_thread_target::prepare_to_store)
356 (ravenscar_thread_target::prepare_to_store)
357 (ravenscar_thread_target::mourn_inferior): Update.
358 (ravenscar_inferior_created): Use "new" to create target.
359 (ravenscar_thread_target::get_ada_task_ptid): Update.
360 (_initialize_ravenscar): Don't initialize base_ptid.
361 (ravenscar_ops): Remove global.
363 2019-02-15 Tom Tromey <tromey@adacore.com>
365 * target.h (push_target): Declare new overload.
366 * target.c (push_target): New overload, taking an rvalue reference.
367 * remote.c (remote_target::open_1): Use push_target overload.
368 * corelow.c (core_target_open): Use push_target overload.
370 2019-02-15 Tom Tromey <tromey@adacore.com>
372 * ravenscar-thread.c (is_ravenscar_task)
373 (ravenscar_task_is_currently_active): Return bool.
374 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
375 (_initialize_ravenscar): Remove "(void)".
376 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
379 2019-02-15 Tom Tromey <tromey@adacore.com>
381 * ravenscar-thread.c (ravenscar_runtime_initializer)
382 (has_ravenscar_runtime, get_running_thread_id)
383 (ravenscar_thread_target::resume): Fix indentation.
385 2019-02-15 Tom Tromey <tromey@adacore.com>
387 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
388 from ravenscar_arch_ops.
389 (sparc_ravenscar_ops::fetch_registers)
390 (sparc_ravenscar_ops::store_registers): Now methods.
391 (sparc_ravenscar_prepare_to_store): Remove.
392 (sparc_ravenscar_ops): Redefine.
393 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
394 methods and destructor. Remove members.
395 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
396 (ravenscar_thread_target::store_registers)
397 (ravenscar_thread_target::prepare_to_store): Update.
398 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
400 (struct ppc_ravenscar_powerpc_ops): Derive from
402 (ppc_ravenscar_powerpc_ops::fetch_registers)
403 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
404 (ppc_ravenscar_powerpc_ops): Redefine.
405 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
406 (ppc_ravenscar_e500_ops::fetch_registers)
407 (ppc_ravenscar_e500_ops::store_registers): Now methods.
408 (ppc_ravenscar_e500_ops): Redefine.
409 * aarch64-ravenscar-thread.c
410 (aarch64_ravenscar_generic_prepare_to_store): Remove.
411 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
412 (aarch64_ravenscar_fetch_registers)
413 (aarch64_ravenscar_store_registers): Now methods.
414 (aarch64_ravenscar_ops): Redefine.
416 2019-02-15 Tom Tromey <tromey@adacore.com>
418 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
419 (ravenscar_thread_target::stopped_by_hw_breakpoint)
420 (ravenscar_thread_target::stopped_by_watchpoint)
421 (ravenscar_thread_target::stopped_data_address)
422 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
424 2019-02-15 Tom Tromey <tromey@adacore.com>
426 * ravenscar-thread.c: Fix some typos.
428 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
429 Tom Tromey <tromey@adacore.com>
431 * ada-lang.c (ada_exception_sal): Change addr_string to a
433 (create_ada_exception_catchpoint): Update.
435 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
436 Tom Tromey <tromey@adacore.com>
438 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
439 (bp_location_ops): Remove.
440 (base_breakpoint_allocate_location): Update.
441 (free_bp_location): Update.
442 * ada-lang.c (class ada_catchpoint_location)
443 <ada_catchpoint_location>: Remove ops parameter.
444 (ada_catchpoint_location_dtor): Remove.
445 (ada_catchpoint_location_ops): Remove.
446 (allocate_location_exception): Update.
447 * breakpoint.h (struct bp_location_ops): Remove.
448 (class bp_location) <bp_location>: Remove bp_location_ops
450 <~bp_location>: Add destructor.
453 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
454 Pedro Alves <palves@redhat.com>
456 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
459 2019-02-14 David Michael <fedora.dm0@gmail.com>
460 Samuel Thibault <samuel.thibault@gnu.org>
461 Thomas Schwinge <thomas@codesourcery.com>
463 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
464 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
466 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
468 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
469 (check_empty): Use "const char *".
471 * gnu-nat.c (gnu_nat_target::detach): Instead of
472 'detach_inferior (pid)' call
473 'detach_inferior (find_inferior_pid (pid))'.
475 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
476 'nat/fork-inferior.o'.
477 * gnu-nat.c: #include "nat/fork-inferior.h".
479 * gnu-nat.c (gnu_nat_target::detach): Instead of
480 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
481 * gnu-nat.h: #include "inf-child.h".
482 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
483 'i386_gnu_nat_target::fetch_registers'.
484 (gnu_store_registers): Rename/move to
485 'i386_gnu_nat_target::store_registers'.
487 * config/i386/nm-i386gnu.h: Don't "#include" any files.
488 * gnu-nat.h (mach_thread_info): New function.
489 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
491 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
493 2019-02-14 Frederic Konrad <konrad@adacore.com>
495 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
497 2019-02-14 Joel Brobecker <brobecker@adacore.com>
499 * windows-nat.c (windows_add_thread): Add new parameter
500 "main_thread_p" with default value set to false. Update
501 function documentation as well as all callers.
502 (windows_delete_thread): Likewise.
503 (fake_create_process): Update call to windows_add_thread.
504 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
505 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
506 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
507 call to windows_delete_thread.
509 2019-02-13 Simon Marchi <simon.marchi@ericsson.com>
511 * MAINTAINERS: Add Andrew Burgess as global maintainer.
513 2019-02-12 John Baldwin <jhb@FreeBSD.org>
515 * symfile.c (find_separate_debug_file): Use canonical path of
516 sysroot with child_path instead of gdb_sysroot if it is valid.
518 2019-02-12 John Baldwin <jhb@FreeBSD.org>
520 * symfile.c (find_separate_debug_file): Use child_path to
521 determine if an object file is under a sysroot.
523 2019-02-12 John Baldwin <jhb@FreeBSD.org>
525 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
526 unittests/child-path-selftests.c.
527 * common/pathstuff.c (child_path): New function.
528 * common/pathstuff.h (child_path): New prototype.
529 * unittests/child-path-selftests.c: New file.
531 2019-02-12 John Baldwin <jhb@FreeBSD.org>
533 * symfile.c (find_separate_debug_file): Look for separate debug
534 files in debug directories under the sysroot.
536 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
538 * symtab.h (struct minimal_symbol data_p): New const method.
539 (struct minimal_symbol text_p): Likewise.
540 * symtab.c (output_source_filename): Use file name style
542 (print_symbol_info): Likewise.
543 (print_msymbol_info): Use address style to print addresses.
544 Use function name style to print executable text symbols.
545 (expand_symtab_containing_pc): Use data_p.
546 (find_pc_sect_compunit_symtab): Likewise.
548 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
550 * breakpoint.c (describe_other_breakpoints): Use address style
552 (say_where): Likewise.
554 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
556 * ada-typeprint.c (print_func_type): Print function name
557 style to print function name.
558 * c-typeprint.c (c_print_type_1): Likewise.
560 2019-02-11 Alan Hayward <alan.hayward@arm.com>
562 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
565 2019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
567 * c-exp.y (direct_abs_decl): Use emplace_back to record the
570 2019-02-10 Joel Brobecker <brobecker@adacore.com>
572 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
575 2019-02-08 Jim Wilson <jimw@sifive.com>
577 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
578 (riscv_linux_fregset): New.
579 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
581 2019-02-07 Tom Tromey <tom@tromey.com>
583 * thread.c (thread_cancel_execution_command): Update.
584 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
586 (struct thread_fsm_ops): Remove.
587 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
588 (thread_fsm_should_stop, thread_fsm_return_value)
589 (thread_fsm_set_finished, thread_fsm_finished_p)
590 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
592 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
593 * infrun.c (clear_proceed_status_thread)
594 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
595 (print_stop_event): Update.
596 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
598 (step_command_fsm_ops): Remove.
599 (new_step_command_fsm): Remove.
601 (step_command_fsm::should_stop): Rename from
602 step_command_fsm_should_stop.
603 (step_command_fsm::clean_up): Rename from
604 step_command_fsm_clean_up.
605 (step_command_fsm::do_async_reply_reason): Rename from
606 step_command_fsm_async_reply_reason.
607 (struct until_next_fsm): Inherit from thread_fsm. Add
609 (until_next_fsm_ops): Remove.
610 (new_until_next_fsm): Remove.
611 (until_next_fsm::should_stop): Rename from
612 until_next_fsm_should_stop.
613 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
614 (until_next_fsm::do_async_reply_reason): Rename from
615 until_next_fsm_async_reply_reason.
616 (struct finish_command_fsm): Inherit from thread_fsm. Add
617 constructor. Change type of breakpoint.
618 (finish_command_fsm_ops): Remove.
619 (new_finish_command_fsm): Remove.
620 (finish_command_fsm::should_stop): Rename from
621 finish_command_fsm_should_stop.
622 (finish_command_fsm::clean_up): Rename from
623 finish_command_fsm_clean_up.
624 (finish_command_fsm::return_value): Rename from
625 finish_command_fsm_return_value.
626 (finish_command_fsm::do_async_reply_reason): Rename from
627 finish_command_fsm_async_reply_reason.
628 (finish_command): Update.
629 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
631 (call_thread_fsm_ops): Remove.
632 (call_thread_fsm::call_thread_fsm): Rename from
634 (call_thread_fsm::should_stop): Rename from
635 call_thread_fsm_should_stop.
636 (call_thread_fsm::should_notify_stop): Rename from
637 call_thread_fsm_should_notify_stop.
638 (run_inferior_call, call_function_by_hand_dummy): Update.
639 * cli/cli-interp.c (should_print_stop_to_console): Update.
640 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
641 Add constructor. Change type of location_breakpoint,
643 (until_break_fsm_ops): Remove.
644 (new_until_break_fsm): Remove.
645 (until_break_fsm::should_stop): Rename from
646 until_break_fsm_should_stop.
647 (until_break_fsm::clean_up): Rename from
648 until_break_fsm_clean_up.
649 (until_break_fsm::do_async_reply_reason): Rename from
650 until_break_fsm_async_reply_reason.
651 (until_break_command): Update.
652 * thread-fsm.c: Remove.
653 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
655 2019-02-07 Tom Tromey <tom@tromey.com>
657 * yy-remap.h: Add include guard.
658 * xtensa-tdep.h: Add include guard.
659 * xcoffread.h: Rename include guard.
660 * varobj-iter.h: Add include guard.
661 * tui/tui.h: Rename include guard.
662 * tui/tui-winsource.h: Rename include guard.
663 * tui/tui-wingeneral.h: Rename include guard.
664 * tui/tui-windata.h: Rename include guard.
665 * tui/tui-win.h: Rename include guard.
666 * tui/tui-stack.h: Rename include guard.
667 * tui/tui-source.h: Rename include guard.
668 * tui/tui-regs.h: Rename include guard.
669 * tui/tui-out.h: Rename include guard.
670 * tui/tui-layout.h: Rename include guard.
671 * tui/tui-io.h: Rename include guard.
672 * tui/tui-hooks.h: Rename include guard.
673 * tui/tui-file.h: Rename include guard.
674 * tui/tui-disasm.h: Rename include guard.
675 * tui/tui-data.h: Rename include guard.
676 * tui/tui-command.h: Rename include guard.
677 * tic6x-tdep.h: Add include guard.
678 * target/waitstatus.h: Rename include guard.
679 * target/wait.h: Rename include guard.
680 * target/target.h: Rename include guard.
681 * target/resume.h: Rename include guard.
682 * target-float.h: Rename include guard.
683 * stabsread.h: Add include guard.
684 * rs6000-tdep.h: Add include guard.
685 * riscv-fbsd-tdep.h: Add include guard.
686 * regformats/regdef.h: Rename include guard.
687 * record.h: Rename include guard.
688 * python/python.h: Rename include guard.
689 * python/python-internal.h: Rename include guard.
690 * python/py-stopevent.h: Rename include guard.
691 * python/py-ref.h: Rename include guard.
692 * python/py-record.h: Rename include guard.
693 * python/py-record-full.h: Rename include guard.
694 * python/py-record-btrace.h: Rename include guard.
695 * python/py-instruction.h: Rename include guard.
696 * python/py-events.h: Rename include guard.
697 * python/py-event.h: Rename include guard.
698 * procfs.h: Add include guard.
699 * proc-utils.h: Add include guard.
700 * p-lang.h: Add include guard.
701 * or1k-tdep.h: Rename include guard.
702 * observable.h: Rename include guard.
703 * nto-tdep.h: Rename include guard.
704 * nat/x86-linux.h: Rename include guard.
705 * nat/x86-linux-dregs.h: Rename include guard.
706 * nat/x86-gcc-cpuid.h: Add include guard.
707 * nat/x86-dregs.h: Rename include guard.
708 * nat/x86-cpuid.h: Rename include guard.
709 * nat/ppc-linux.h: Rename include guard.
710 * nat/mips-linux-watch.h: Rename include guard.
711 * nat/linux-waitpid.h: Rename include guard.
712 * nat/linux-ptrace.h: Rename include guard.
713 * nat/linux-procfs.h: Rename include guard.
714 * nat/linux-osdata.h: Rename include guard.
715 * nat/linux-nat.h: Rename include guard.
716 * nat/linux-namespaces.h: Rename include guard.
717 * nat/linux-btrace.h: Rename include guard.
718 * nat/glibc_thread_db.h: Rename include guard.
719 * nat/gdb_thread_db.h: Rename include guard.
720 * nat/gdb_ptrace.h: Rename include guard.
721 * nat/fork-inferior.h: Rename include guard.
722 * nat/amd64-linux-siginfo.h: Rename include guard.
723 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
724 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
725 * nat/aarch64-linux.h: Rename include guard.
726 * nat/aarch64-linux-hw-point.h: Rename include guard.
727 * mn10300-tdep.h: Add include guard.
728 * mips-linux-tdep.h: Add include guard.
729 * mi/mi-parse.h: Rename include guard.
730 * mi/mi-out.h: Rename include guard.
731 * mi/mi-main.h: Rename include guard.
732 * mi/mi-interp.h: Rename include guard.
733 * mi/mi-getopt.h: Rename include guard.
734 * mi/mi-console.h: Rename include guard.
735 * mi/mi-common.h: Rename include guard.
736 * mi/mi-cmds.h: Rename include guard.
737 * mi/mi-cmd-break.h: Rename include guard.
738 * m2-lang.h: Add include guard.
739 * location.h: Rename include guard.
740 * linux-record.h: Rename include guard.
741 * linux-nat.h: Add include guard.
742 * linux-fork.h: Add include guard.
743 * i386-darwin-tdep.h: Rename include guard.
744 * hppa-linux-offsets.h: Add include guard.
745 * guile/guile.h: Rename include guard.
746 * guile/guile-internal.h: Rename include guard.
747 * gnu-nat.h: Rename include guard.
748 * gdb-stabs.h: Rename include guard.
749 * frv-tdep.h: Add include guard.
750 * f-lang.h: Add include guard.
751 * event-loop.h: Add include guard.
752 * darwin-nat.h: Rename include guard.
753 * cp-abi.h: Rename include guard.
754 * config/sparc/nm-sol2.h: Rename include guard.
755 * config/nm-nto.h: Rename include guard.
756 * config/nm-linux.h: Add include guard.
757 * config/i386/nm-i386gnu.h: Rename include guard.
758 * config/djgpp/nl_types.h: Rename include guard.
759 * config/djgpp/langinfo.h: Rename include guard.
760 * compile/gcc-cp-plugin.h: Add include guard.
761 * compile/gcc-c-plugin.h: Add include guard.
762 * compile/compile.h: Rename include guard.
763 * compile/compile-object-run.h: Rename include guard.
764 * compile/compile-object-load.h: Rename include guard.
765 * compile/compile-internal.h: Rename include guard.
766 * compile/compile-cplus.h: Rename include guard.
767 * compile/compile-c.h: Rename include guard.
768 * common/xml-utils.h: Rename include guard.
769 * common/x86-xstate.h: Rename include guard.
770 * common/version.h: Rename include guard.
771 * common/vec.h: Rename include guard.
772 * common/tdesc.h: Rename include guard.
773 * common/selftest.h: Rename include guard.
774 * common/scoped_restore.h: Rename include guard.
775 * common/scoped_mmap.h: Rename include guard.
776 * common/scoped_fd.h: Rename include guard.
777 * common/safe-iterator.h: Rename include guard.
778 * common/run-time-clock.h: Rename include guard.
779 * common/refcounted-object.h: Rename include guard.
780 * common/queue.h: Rename include guard.
781 * common/ptid.h: Rename include guard.
782 * common/print-utils.h: Rename include guard.
783 * common/preprocessor.h: Rename include guard.
784 * common/pathstuff.h: Rename include guard.
785 * common/observable.h: Rename include guard.
786 * common/netstuff.h: Rename include guard.
787 * common/job-control.h: Rename include guard.
788 * common/host-defs.h: Rename include guard.
789 * common/gdb_wait.h: Rename include guard.
790 * common/gdb_vecs.h: Rename include guard.
791 * common/gdb_unlinker.h: Rename include guard.
792 * common/gdb_unique_ptr.h: Rename include guard.
793 * common/gdb_tilde_expand.h: Rename include guard.
794 * common/gdb_sys_time.h: Rename include guard.
795 * common/gdb_string_view.h: Rename include guard.
796 * common/gdb_splay_tree.h: Rename include guard.
797 * common/gdb_setjmp.h: Rename include guard.
798 * common/gdb_ref_ptr.h: Rename include guard.
799 * common/gdb_optional.h: Rename include guard.
800 * common/gdb_locale.h: Rename include guard.
801 * common/gdb_assert.h: Rename include guard.
802 * common/filtered-iterator.h: Rename include guard.
803 * common/filestuff.h: Rename include guard.
804 * common/fileio.h: Rename include guard.
805 * common/environ.h: Rename include guard.
806 * common/common-utils.h: Rename include guard.
807 * common/common-types.h: Rename include guard.
808 * common/common-regcache.h: Rename include guard.
809 * common/common-inferior.h: Rename include guard.
810 * common/common-gdbthread.h: Rename include guard.
811 * common/common-exceptions.h: Rename include guard.
812 * common/common-defs.h: Rename include guard.
813 * common/common-debug.h: Rename include guard.
814 * common/cleanups.h: Rename include guard.
815 * common/buffer.h: Rename include guard.
816 * common/btrace-common.h: Rename include guard.
817 * common/break-common.h: Rename include guard.
818 * cli/cli-utils.h: Rename include guard.
819 * cli/cli-style.h: Rename include guard.
820 * cli/cli-setshow.h: Rename include guard.
821 * cli/cli-script.h: Rename include guard.
822 * cli/cli-interp.h: Rename include guard.
823 * cli/cli-decode.h: Rename include guard.
824 * cli/cli-cmds.h: Rename include guard.
825 * charset-list.h: Add include guard.
826 * buildsym-legacy.h: Rename include guard.
827 * bfin-tdep.h: Add include guard.
828 * ax.h: Rename include guard.
829 * arm-linux-tdep.h: Add include guard.
830 * arm-fbsd-tdep.h: Add include guard.
831 * arch/xtensa.h: Rename include guard.
832 * arch/tic6x.h: Add include guard.
833 * arch/i386.h: Add include guard.
834 * arch/arm.h: Rename include guard.
835 * arch/arm-linux.h: Rename include guard.
836 * arch/arm-get-next-pcs.h: Rename include guard.
837 * arch/amd64.h: Add include guard.
838 * arch/aarch64-insn.h: Rename include guard.
839 * arch-utils.h: Rename include guard.
840 * annotate.h: Add include guard.
841 * amd64-darwin-tdep.h: Rename include guard.
842 * aarch64-linux-tdep.h: Add include guard.
843 * aarch64-fbsd-tdep.h: Add include guard.
844 * aarch32-linux-nat.h: Add include guard.
846 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
848 * macrotab.c (macro_define_internal): New function that
849 factorizes macro_define_object_internal and macro_define_function
851 (macro_define_object_internal): Use macro_define_internal.
852 (macro_define_function): Likewise.
854 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
856 * macrocmd.c (extract_identifier): Return
857 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
860 2019-02-06 John Baldwin <jhb@FreeBSD.org>
862 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
864 2019-02-05 Tom Tromey <tom@tromey.com>
866 * target.c (target_stack::unpush): Move assertion earlier.
868 2019-01-30 Tom Tromey <tom@tromey.com>
871 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
872 (gdbpy_parse_and_eval): Likewise.
873 * python/python-internal.h (gdbpy_allow_threads): New class.
875 2019-01-28 John Baldwin <jhb@FreeBSD.org>
877 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
878 (aarch64_fbsd_fpregmap): Move earlier.
879 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
880 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
881 instead of individual calls to trad_frame_set_reg_addr.
882 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
884 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
885 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
886 instead of individual calls to trad_frame_set_reg_addr.
888 2019-01-28 Alan Hayward <alan.hayward@arm.com>
890 * CONTRIBUTE: Replace contribution list with wiki link.
892 2019-01-25 Tom Tromey <tom@tromey.com>
894 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
896 2019-01-25 Tom Tromey <tom@tromey.com>
898 * xtensa-linux-nat.c: Fix common/ includes.
899 * xml-support.h: Fix common/ includes.
900 * xml-support.c: Fix common/ includes.
901 * x86-linux-nat.c: Fix common/ includes.
902 * windows-nat.c: Fix common/ includes.
903 * varobj.h: Fix common/ includes.
904 * varobj.c: Fix common/ includes.
905 * value.c: Fix common/ includes.
906 * valops.c: Fix common/ includes.
907 * utils.c: Fix common/ includes.
908 * unittests/xml-utils-selftests.c: Fix common/ includes.
909 * unittests/utils-selftests.c: Fix common/ includes.
910 * unittests/unpack-selftests.c: Fix common/ includes.
911 * unittests/tracepoint-selftests.c: Fix common/ includes.
912 * unittests/style-selftests.c: Fix common/ includes.
913 * unittests/string_view-selftests.c: Fix common/ includes.
914 * unittests/scoped_restore-selftests.c: Fix common/ includes.
915 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
916 * unittests/scoped_fd-selftests.c: Fix common/ includes.
917 * unittests/rsp-low-selftests.c: Fix common/ includes.
918 * unittests/parse-connection-spec-selftests.c: Fix common/
920 * unittests/optional-selftests.c: Fix common/ includes.
921 * unittests/offset-type-selftests.c: Fix common/ includes.
922 * unittests/observable-selftests.c: Fix common/ includes.
923 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
924 * unittests/memrange-selftests.c: Fix common/ includes.
925 * unittests/memory-map-selftests.c: Fix common/ includes.
926 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
927 * unittests/function-view-selftests.c: Fix common/ includes.
928 * unittests/environ-selftests.c: Fix common/ includes.
929 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
930 * unittests/common-utils-selftests.c: Fix common/ includes.
931 * unittests/cli-utils-selftests.c: Fix common/ includes.
932 * unittests/array-view-selftests.c: Fix common/ includes.
933 * ui-file.c: Fix common/ includes.
934 * tui/tui-io.c: Fix common/ includes.
935 * tracepoint.h: Fix common/ includes.
936 * tracepoint.c: Fix common/ includes.
937 * tracefile-tfile.c: Fix common/ includes.
938 * top.h: Fix common/ includes.
939 * top.c: Fix common/ includes.
940 * thread.c: Fix common/ includes.
941 * target/waitstatus.h: Fix common/ includes.
942 * target/waitstatus.c: Fix common/ includes.
943 * target.h: Fix common/ includes.
944 * target.c: Fix common/ includes.
945 * target-memory.c: Fix common/ includes.
946 * target-descriptions.c: Fix common/ includes.
947 * symtab.h: Fix common/ includes.
948 * symfile.c: Fix common/ includes.
949 * stap-probe.c: Fix common/ includes.
950 * spu-linux-nat.c: Fix common/ includes.
951 * sparc-nat.c: Fix common/ includes.
952 * source.c: Fix common/ includes.
953 * solib.c: Fix common/ includes.
954 * solib-target.c: Fix common/ includes.
955 * ser-unix.c: Fix common/ includes.
956 * ser-tcp.c: Fix common/ includes.
957 * ser-pipe.c: Fix common/ includes.
958 * ser-base.c: Fix common/ includes.
959 * selftest-arch.c: Fix common/ includes.
960 * s12z-tdep.c: Fix common/ includes.
961 * rust-exp.y: Fix common/ includes.
962 * rs6000-aix-tdep.c: Fix common/ includes.
963 * riscv-tdep.c: Fix common/ includes.
964 * remote.c: Fix common/ includes.
965 * remote-notif.h: Fix common/ includes.
966 * remote-fileio.h: Fix common/ includes.
967 * remote-fileio.c: Fix common/ includes.
968 * regcache.h: Fix common/ includes.
969 * regcache.c: Fix common/ includes.
970 * record-btrace.c: Fix common/ includes.
971 * python/python.c: Fix common/ includes.
972 * python/py-type.c: Fix common/ includes.
973 * python/py-inferior.c: Fix common/ includes.
974 * progspace.h: Fix common/ includes.
975 * producer.c: Fix common/ includes.
976 * procfs.c: Fix common/ includes.
977 * proc-api.c: Fix common/ includes.
978 * printcmd.c: Fix common/ includes.
979 * ppc-linux-nat.c: Fix common/ includes.
980 * parser-defs.h: Fix common/ includes.
981 * osdata.c: Fix common/ includes.
982 * obsd-nat.c: Fix common/ includes.
983 * nat/x86-linux.c: Fix common/ includes.
984 * nat/x86-linux-dregs.c: Fix common/ includes.
985 * nat/x86-dregs.h: Fix common/ includes.
986 * nat/x86-dregs.c: Fix common/ includes.
987 * nat/ppc-linux.c: Fix common/ includes.
988 * nat/mips-linux-watch.h: Fix common/ includes.
989 * nat/mips-linux-watch.c: Fix common/ includes.
990 * nat/linux-waitpid.c: Fix common/ includes.
991 * nat/linux-ptrace.h: Fix common/ includes.
992 * nat/linux-ptrace.c: Fix common/ includes.
993 * nat/linux-procfs.c: Fix common/ includes.
994 * nat/linux-personality.c: Fix common/ includes.
995 * nat/linux-osdata.c: Fix common/ includes.
996 * nat/linux-namespaces.c: Fix common/ includes.
997 * nat/linux-btrace.h: Fix common/ includes.
998 * nat/linux-btrace.c: Fix common/ includes.
999 * nat/fork-inferior.c: Fix common/ includes.
1000 * nat/amd64-linux-siginfo.c: Fix common/ includes.
1001 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1002 * nat/aarch64-linux.c: Fix common/ includes.
1003 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1004 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1005 * namespace.h: Fix common/ includes.
1006 * mips-linux-tdep.c: Fix common/ includes.
1007 * minsyms.c: Fix common/ includes.
1008 * mi/mi-parse.h: Fix common/ includes.
1009 * mi/mi-main.c: Fix common/ includes.
1010 * mi/mi-cmd-env.c: Fix common/ includes.
1011 * memrange.h: Fix common/ includes.
1012 * memattr.c: Fix common/ includes.
1013 * maint.h: Fix common/ includes.
1014 * maint.c: Fix common/ includes.
1015 * main.c: Fix common/ includes.
1016 * machoread.c: Fix common/ includes.
1017 * location.c: Fix common/ includes.
1018 * linux-thread-db.c: Fix common/ includes.
1019 * linux-nat.c: Fix common/ includes.
1020 * linux-fork.c: Fix common/ includes.
1021 * inline-frame.c: Fix common/ includes.
1022 * infrun.c: Fix common/ includes.
1023 * inflow.c: Fix common/ includes.
1024 * inferior.h: Fix common/ includes.
1025 * inferior.c: Fix common/ includes.
1026 * infcmd.c: Fix common/ includes.
1027 * inf-ptrace.c: Fix common/ includes.
1028 * inf-child.c: Fix common/ includes.
1029 * ia64-linux-nat.c: Fix common/ includes.
1030 * i387-tdep.c: Fix common/ includes.
1031 * i386-tdep.c: Fix common/ includes.
1032 * i386-linux-tdep.c: Fix common/ includes.
1033 * i386-linux-nat.c: Fix common/ includes.
1034 * i386-go32-tdep.c: Fix common/ includes.
1035 * i386-fbsd-tdep.c: Fix common/ includes.
1036 * i386-fbsd-nat.c: Fix common/ includes.
1037 * guile/scm-type.c: Fix common/ includes.
1038 * guile/guile.c: Fix common/ includes.
1039 * go32-nat.c: Fix common/ includes.
1040 * gnu-nat.c: Fix common/ includes.
1041 * gdbthread.h: Fix common/ includes.
1042 * gdbarch-selftests.c: Fix common/ includes.
1043 * gdb_usleep.c: Fix common/ includes.
1044 * gdb_select.h: Fix common/ includes.
1045 * gdb_bfd.c: Fix common/ includes.
1046 * gcore.c: Fix common/ includes.
1047 * fork-child.c: Fix common/ includes.
1048 * findvar.c: Fix common/ includes.
1049 * fbsd-nat.c: Fix common/ includes.
1050 * event-top.c: Fix common/ includes.
1051 * event-loop.c: Fix common/ includes.
1052 * dwarf2read.c: Fix common/ includes.
1053 * dwarf2loc.c: Fix common/ includes.
1054 * dwarf2-frame.c: Fix common/ includes.
1055 * dwarf-index-cache.c: Fix common/ includes.
1056 * dtrace-probe.c: Fix common/ includes.
1057 * disasm-selftests.c: Fix common/ includes.
1058 * defs.h: Fix common/ includes.
1059 * csky-tdep.c: Fix common/ includes.
1060 * cp-valprint.c: Fix common/ includes.
1061 * cp-support.h: Fix common/ includes.
1062 * cp-support.c: Fix common/ includes.
1063 * corelow.c: Fix common/ includes.
1064 * completer.h: Fix common/ includes.
1065 * completer.c: Fix common/ includes.
1066 * compile/compile.c: Fix common/ includes.
1067 * compile/compile-loc2c.c: Fix common/ includes.
1068 * compile/compile-cplus-types.c: Fix common/ includes.
1069 * compile/compile-cplus-symbols.c: Fix common/ includes.
1070 * command.h: Fix common/ includes.
1071 * cli/cli-dump.c: Fix common/ includes.
1072 * cli/cli-cmds.c: Fix common/ includes.
1073 * charset.c: Fix common/ includes.
1074 * build-id.c: Fix common/ includes.
1075 * btrace.h: Fix common/ includes.
1076 * btrace.c: Fix common/ includes.
1077 * breakpoint.h: Fix common/ includes.
1078 * breakpoint.c: Fix common/ includes.
1080 (enum agent_op): Fix common/ includes.
1081 * ax-general.c (struct aop_map): Fix common/ includes.
1082 * ax-gdb.c: Fix common/ includes.
1083 * auxv.c: Fix common/ includes.
1084 * auto-load.c: Fix common/ includes.
1085 * arm-tdep.c: Fix common/ includes.
1086 * arch/riscv.c: Fix common/ includes.
1087 * arch/ppc-linux-common.c: Fix common/ includes.
1088 * arch/i386.c: Fix common/ includes.
1089 * arch/arm.c: Fix common/ includes.
1090 * arch/arm-linux.c: Fix common/ includes.
1091 * arch/arm-get-next-pcs.c: Fix common/ includes.
1092 * arch/amd64.c: Fix common/ includes.
1093 * arch/aarch64.c: Fix common/ includes.
1094 * arch/aarch64-insn.c: Fix common/ includes.
1095 * arch-utils.c: Fix common/ includes.
1096 * amd64-windows-tdep.c: Fix common/ includes.
1097 * amd64-tdep.c: Fix common/ includes.
1098 * amd64-sol2-tdep.c: Fix common/ includes.
1099 * amd64-obsd-tdep.c: Fix common/ includes.
1100 * amd64-nbsd-tdep.c: Fix common/ includes.
1101 * amd64-linux-tdep.c: Fix common/ includes.
1102 * amd64-linux-nat.c: Fix common/ includes.
1103 * amd64-fbsd-tdep.c: Fix common/ includes.
1104 * amd64-fbsd-nat.c: Fix common/ includes.
1105 * amd64-dicos-tdep.c: Fix common/ includes.
1106 * amd64-darwin-tdep.c: Fix common/ includes.
1107 * agent.c: Fix common/ includes.
1108 * ada-lang.h: Fix common/ includes.
1109 * ada-lang.c: Fix common/ includes.
1110 * aarch64-tdep.c: Fix common/ includes.
1112 2019-01-25 Tom Tromey <tom@tromey.com>
1114 * common/create-version.sh: Use common/version.h.
1116 2019-01-24 Pedro Alves <palves@redhat.com>
1118 * infrun.c (signal_stop, signal_print, signal_program)
1119 (signal_catch, signal_pass): Now arrays instead of pointers.
1120 (update_signals_program_target, do_target_resume)
1121 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1122 * linux-nat.c (linux_nat_target::pass_signals)
1123 (linux_nat_target::create_inferior, linux_nat_target::attach):
1125 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1126 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1127 * procfs.c (procfs_target::pass_signals): Adjust.
1128 * record-full.c (record_full_target::resume): Adjust.
1129 * remote.c (remote_target::pass_signals)
1130 (remote_target::program_signals): Adjust.
1131 * target-debug.h (target_debug_print_signals): Now takes a
1132 gdb::array_view as parameter. Adjust.
1133 * target.h (target_ops) <pass_signals, program_signals>: Replace
1134 pointer and length parameters with gdb::array_view.
1135 (target_pass_signals, target_program_signals): Likewise.
1136 * target-delegates.c: Regenerate.
1138 2019-01-24 Pedro Alves <palves@redhat.com>
1140 * common/forward-scope-exit.h
1141 (forward_scope_exit::forward_scope_exit): Pass arguments to
1142 m_bind_function directly, instead of creating a std::bind and
1145 2019-01-24 Alan Hayward <alan.hayward@arm.com>
1147 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1149 (pass_in_v_vfp_candidate): Likewise.
1151 2019-01-23 Tom Tromey <tom@tromey.com>
1152 Pedro Alves <palves@redhat.com>
1154 * regcache.c (class regcache_invalidator): Remove.
1155 (regcache::raw_write): Use make_scope_exit.
1157 2019-01-23 Tom Tromey <tom@tromey.com>
1159 * ui-out.h (class ui_out_emit_type): Update comment.
1161 2019-01-23 Tom Tromey <tom@tromey.com>
1163 * infrun.c (fetch_inferior_event): Update comment.
1165 2019-01-23 Tom Tromey <tom@tromey.com>
1166 Pedro Alves <palves@redhat.com>
1168 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1170 (fetch_inferior_event): Use SCOPE_EXIT.
1173 2019-01-23 Tom Tromey <tom@tromey.com>
1174 Pedro Alves <palves@redhat.com>
1176 * infrun.c (disable_thread_events): Delete.
1177 (stop_all_threads): Use SCOPE_EXIT.
1179 2019-01-23 Tom Tromey <tom@tromey.com>
1180 Pedro Alves <palves@redhat.com>
1182 * symfile.c: Include forward-scope-exit.h.
1183 (clear_symtab_users_cleanup): Replace forward declaration with
1184 a FORWARD_SCOPE_EXIT.
1185 (syms_from_objfile_1): Use the forward_scope_exit and
1186 gdb::optional instead of cleanup_function.
1187 (reread_symbols): Use the forward_scope_exit instead of
1189 (clear_symtab_users_cleanup): Remove function.
1191 2019-01-23 Tom Tromey <tom@tromey.com>
1192 Pedro Alves <palves@redhat.com>
1194 * linux-nat.c: Include scope-exit.h.
1195 (cleanup_target_stop): Remove.
1196 (linux_nat_target::static_tracepoint_markers_by_strid): Use
1199 2019-01-23 Tom Tromey <tom@tromey.com>
1200 Pedro Alves <palves@redhat.com>
1202 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1203 (call_function_by_hand_dummy): Use SCOPE_EXIT.
1205 2019-01-23 Tom Tromey <tom@tromey.com>
1206 Andrew Burgess <andrew.burgess@embecosm.com>
1207 Pedro Alves <palves@redhat.com>
1209 * infrun.c (fetch_inferior_event): Use scope_exit.
1210 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1211 * top.c (execute_command): Use scope_exit.
1212 * breakpoint.c (bpstat_do_actions): Use scope_exit.
1213 * utils.c (do_bpstat_clear_actions_cleanup)
1214 (make_bpstat_clear_actions_cleanup): Remove.
1216 2019-01-23 Tom Tromey <tom@tromey.com>
1217 Pedro Alves <palves@redhat.com>
1219 * infrun.c: Include "common/scope-exit.h"
1220 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1221 (wait_for_inferior): Use SCOPE_EXIT.
1222 (fetch_inferior_event): Use scope_exit.
1224 2019-01-23 Tom Tromey <tom@tromey.com>
1225 Pedro Alves <palves@redhat.com>
1227 * breakpoint.c (create_breakpoint): Remove cleanup.
1229 2019-01-23 Tom Tromey <tom@tromey.com>
1230 Andrew Burgess <andrew.burgess@embecosm.com>
1231 Pedro Alves <palves@redhat.com>
1233 2019-01-23 Pedro Alves <palves@redhat.com>
1235 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1237 2019-01-23 Pedro Alves <palves@redhat.com>
1238 Andrew Burgess <andrew.burgess@embecosm.com>
1240 * gdbthread.h: Include "common/forward-scope-exit.h".
1241 (scoped_finish_thread_state): Redefine custom class in terms of
1244 2019-01-23 Pedro Alves <palves@redhat.com>
1245 Andrew Burgess <andrew.burgess@embecosm.com>
1247 * common/forward-scope-exit.h: New file.
1249 2019-01-23 Pedro Alves <palves@redhat.com>
1250 Andrew Burgess <andrew.burgess@embecosm.com>
1251 Tom Tromey <tom@tromey.com>
1253 * common/scope-exit.h: New file.
1255 2019-01-23 Pedro Alves <palves@redhat.com>
1257 * common/preprocessor.h (ESC): Rename to ...
1258 (ESC_PARENS): ... this.
1259 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1260 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1262 2019-01-23 Tom Tromey <tom@tromey.com>
1264 * language.h (class scoped_switch_to_sym_language_if_auto):
1265 Initialize m_lang in both cases.
1267 2019-01-23 Alan Hayward <alan.hayward@arm.com>
1269 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1272 2019-01-22 Tom Tromey <tom@tromey.com>
1274 * corelow.c: Do not include sys/file.h.
1276 2019-01-22 Tom Tromey <tom@tromey.com>
1278 * tui/tui-wingeneral.h: Include gdb_curses.h.
1280 2019-01-22 Tom Tromey <tom@tromey.com>
1282 * source-cache.h (class source_cache) <get_source_lines,
1283 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1285 2019-01-22 Tom Tromey <tom@tromey.com>
1287 * remote-fileio.h (struct remote_target): Declare.
1289 2019-01-22 Tom Tromey <tom@tromey.com>
1291 * python/py-arch.c: Do not include py-ref.h.
1292 * python/py-bpevent.c: Do not include py-ref.h.
1293 * python/py-cmd.c: Do not include py-ref.h.
1294 * python/py-continueevent.c: Do not include py-ref.h.
1295 * python/py-event.h: Do not include py-ref.h.
1296 * python/py-evtregistry.c: Do not include py-ref.h.
1297 * python/py-finishbreakpoint.c: Do not include py-ref.h.
1298 * python/py-frame.c: Do not include py-ref.h.
1299 * python/py-framefilter.c: Do not include py-ref.h.
1300 * python/py-function.c: Do not include py-ref.h.
1301 * python/py-infevents.c: Do not include py-ref.h.
1302 * python/py-linetable.c: Do not include py-ref.h.
1303 * python/py-objfile.c: Do not include py-ref.h.
1304 * python/py-param.c: Do not include py-ref.h.
1305 * python/py-prettyprint.c: Do not include py-ref.h.
1306 * python/py-progspace.c: Do not include py-ref.h.
1307 * python/py-symbol.c: Do not include py-ref.h.
1308 * python/py-symtab.c: Do not include py-ref.h.
1309 * python/py-type.c: Do not include py-ref.h.
1310 * python/py-unwind.c: Do not include py-ref.h.
1311 * python/py-utils.c: Do not include py-ref.h.
1312 * python/py-value.c: Do not include py-ref.h.
1313 * python/py-varobj.c: Do not include py-ref.h.
1314 * python/py-xmethods.c: Do not include py-ref.h.
1315 * python/python.c: Do not include py-ref.h.
1316 * varobj.c: Do not include py-ref.h.
1318 2019-01-22 Tom Tromey <tom@tromey.com>
1320 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1323 2019-01-22 Tom Tromey <tom@tromey.com>
1325 * compile/compile-cplus-types.c: Remove a comment by #include.
1327 2019-01-22 Tom Tromey <tom@tromey.com>
1329 * compile/gcc-c-plugin.h: Include compile-internal.h.
1331 2019-01-22 Tom Tromey <tom@tromey.com>
1333 * stabsread.c (EXTERN): Do not define.
1334 (symnum, next_symbol_text_func, processing_gcc_compilation)
1335 (within_function, global_sym_chain, global_stabs)
1336 (previous_stab_code, this_object_header_files)
1337 (n_this_object_header_files)
1338 (n_allocated_this_object_header_files): Define.
1339 * stabsread.h (EXTERN): Never define. Use "extern".
1341 2019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1343 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1346 2019-01-21 Tom Tromey <tom@tromey.com>
1348 * ui-out.c: Fix includes.
1349 * tui/tui-source.c: Fix includes.
1350 * target.c: Fix includes.
1351 * remote.c: Fix includes.
1352 * regcache.c: Fix includes.
1353 * python/py-block.c: Fix includes.
1354 * printcmd.c: Fix includes.
1355 * or1k-tdep.c: Fix includes.
1356 * mi/mi-main.c: Fix includes.
1357 * m32r-tdep.c: Fix includes.
1358 * csky-tdep.c: Fix includes.
1359 * compile/compile-cplus-types.c: Fix includes.
1360 * cli/cli-interp.c: Fix includes.
1362 2019-01-21 Alan Hayward <alan.hayward@arm.com>
1364 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1367 2019-01-16 Tom Tromey <tom@tromey.com>
1369 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
1371 (struct objfile) <msymbols_range>: Move from top level.
1372 <msymbols>: New method.
1373 (class objfile_msymbols): Remove.
1374 * symtab.c (default_collect_symbol_completion_matches_break_on):
1376 * symmisc.c (dump_msymbols): Update.
1377 * stabsread.c (scan_file_globals): Update.
1378 * objc-lang.c (info_selectors_command, info_classes_command)
1379 (find_methods): Update.
1380 * minsyms.c (find_solib_trampoline_target): Update.
1381 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1382 * coffread.c (coff_symfile_read): Update.
1383 * ada-lang.c (ada_lookup_simple_minsym)
1384 (ada_collect_symbol_completion_matches): Update.
1386 2019-01-16 Tom Tromey <tom@tromey.com>
1388 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1389 type. Remove no-argument constructor.
1390 <iterator::operator++>: Simplify.
1392 <end>: Use minimal_symbol_count.
1394 2019-01-16 Tom Tromey <tom@tromey.com>
1396 * objfiles.h (struct objfile) <psymtabs>: New method.
1397 (class objfile_psymtabs): Remove.
1398 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1400 <range>: New method.
1401 (require_partial_symbols): Change return type.
1402 * psymtab.c (require_partial_symbols)
1403 (psym_expand_symtabs_matching): Update.
1404 * mdebugread.c (parse_partial_symbols): Update.
1405 * dbxread.c (dbx_end_psymtab): Update.
1407 2019-01-15 Tom Tromey <tom@tromey.com>
1409 * symtab.c (lookup_objfile_from_block)
1410 (lookup_symbol_in_objfile_symtabs)
1411 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1412 (find_line_symtab, info_sources_command)
1413 (default_collect_symbol_completion_matches_break_on)
1414 (make_source_files_completion_list): Update.
1415 * symmisc.c (print_objfile_statistics, dump_objfile)
1416 (maintenance_print_symbols, maintenance_info_symtabs)
1417 (maintenance_check_symtabs, maintenance_info_line_tables):
1419 * source.c (select_source_symtab)
1420 (forget_cached_source_info_for_objfile): Update.
1421 * objfiles.h (class objfile_compunits): Remove.
1422 (struct objfile) <compunits_range>: New typedef.
1423 (compunits): New method.
1424 * objfiles.c (objfile_relocate1): Update.
1425 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1426 * maint.c (count_symtabs_and_blocks): Update.
1427 * linespec.c (iterate_over_all_matching_symtabs): Update.
1428 * cp-support.c (add_symbol_overload_list_qualified): Update.
1429 * coffread.c (coff_symtab_read): Update.
1430 * ada-lang.c (add_nonlocal_symbols)
1431 (ada_collect_symbol_completion_matches)
1432 (ada_add_global_exceptions): Update.
1434 2019-01-15 Tom Tromey <tom@tromey.com>
1436 * progspace.h (program_space) <objfiles_safe_range>: New
1438 <objfiles_safe>: New method.
1439 * objfiles.h (class all_objfiles_safe): Remove.
1440 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1441 * jit.c (jit_inferior_exit_hook): Update.
1443 2019-01-17 Tom Tromey <tom@tromey.com>
1445 * progspace.h (program_space) <objfiles_range>: New typedef.
1446 <objfiles>: New method.
1447 <objfiles_head>: Rename from objfiles.
1448 (object_files): Update.
1449 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1450 * guile/scm-pretty-print.c
1451 (ppscm_find_pretty_printer_from_objfiles): Update.
1452 * guile/scm-objfile.c (gdbscm_objfiles): Update.
1453 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1455 * python/py-progspace.c (pspy_get_objfiles): Update.
1456 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1458 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1459 (objfpy_lookup_objfile_by_build_id): Update.
1460 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1461 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1463 * symtab.c (iterate_over_symtabs, matching_obj_sections)
1464 (expand_symtab_containing_pc, lookup_objfile_from_block)
1465 (lookup_static_symbol, basic_lookup_transparent_type)
1466 (find_pc_sect_compunit_symtab, find_symbol_at_address)
1467 (find_line_symtab, info_sources_command)
1468 (default_collect_symbol_completion_matches_break_on)
1469 (make_source_files_completion_list, find_main_name): Update.
1470 * symmisc.c (print_symbol_bcache_statistics)
1471 (print_objfile_statistics, maintenance_print_symbols)
1472 (maintenance_print_msymbols, maintenance_print_objfiles)
1473 (maintenance_info_symtabs, maintenance_check_symtabs)
1474 (maintenance_expand_symtabs, maintenance_info_line_tables):
1476 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1477 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1478 (map_overlay_command, unmap_overlay_command)
1479 (simple_overlay_update, expand_symtabs_matching)
1480 (map_symbol_filenames): Update.
1481 * symfile-debug.c (set_debug_symfile): Update.
1482 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1484 * source.c (select_source_symtab, forget_cached_source_info):
1486 * solib.c (solib_read_symbols): Update.
1487 * solib-spu.c (append_ocl_sos): Update.
1488 * psymtab.c (maintenance_print_psymbols)
1489 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1490 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1491 * printcmd.c (info_symbol_command): Update.
1492 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1494 * objfiles.h (class all_objfiles): Remove.
1495 * objfiles.c (have_partial_symbols, have_full_symbols)
1496 (have_minimal_symbols, qsort_cmp, update_section_map)
1497 (shared_objfile_contains_address_p)
1498 (default_iterate_over_objfiles_in_search_order): Update.
1499 * objc-lang.c (info_selectors_command, info_classes_command)
1500 (find_methods): Update.
1501 * minsyms.c (find_solib_trampoline_target): Update.
1502 * maint.c (maintenance_info_sections)
1503 (maintenance_translate_address, count_symtabs_and_blocks):
1505 * main.c (captured_main_1): Update.
1506 * linux-thread-db.c (try_thread_db_load_from_pdir)
1507 (has_libpthread): Update.
1508 * linespec.c (iterate_over_all_matching_symtabs)
1509 (search_minsyms_for_name): Update.
1510 * jit.c (jit_find_objf_with_entry_addr): Update.
1511 * hppa-tdep.c (find_unwind_entry)
1512 (hppa_lookup_stub_minimal_symbol): Update.
1513 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1515 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1516 (elf_gnu_ifunc_resolve_by_got): Update.
1517 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1518 * dwarf-index-write.c (save_gdb_index_command): Update.
1519 * cp-support.c (add_symbol_overload_list_qualified): Update.
1520 * breakpoint.c (create_overlay_event_breakpoint)
1521 (create_longjmp_master_breakpoint)
1522 (create_std_terminate_master_breakpoint)
1523 (create_exception_master_breakpoint): Update.
1524 * blockframe.c (find_pc_partial_function): Update.
1525 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1526 (ada_collect_symbol_completion_matches)
1527 (ada_add_global_exceptions): Update.
1529 2019-01-17 Tom Tromey <tom@tromey.com>
1531 * solib-target.c (lm_info_target_p): Remove typedef. Don't
1533 (solib_target_parse_libraries): Change return type.
1534 (library_list_start_segment, library_list_start_section)
1535 (library_list_end_library, library_list_start_library); Update.
1536 (solib_target_free_library_list): Remove.
1537 (solib_target_parse_libraries): Remove cleanup. Change return
1539 (solib_target_current_sos): Update.
1541 2019-01-17 Tom Tromey <tromey@bapiya>
1543 * valprint.c: Replace "the the" with "the".
1544 * symtab.c: Replace "the the" with "the".
1545 * solib.c: Replace "the the" with "the".
1546 * solib-dsbt.c: Replace "the the" with "the".
1547 * linespec.c: Replace "the the" with "the".
1548 * dwarf2loc.h: Replace "the the" with "the".
1549 * amd64-windows-tdep.c: Replace "the the" with "the".
1550 * aarch64-tdep.c: Replace "the the" with "the".
1552 2019-01-16 Keith Seitz <keiths@redhat.com>
1555 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1556 <builder>: Rename to ..
1557 <m_builder>: ... this and make private.
1558 (dwarf2_cu::get_builder): New method. Change all users of
1559 `builder' to use this method.
1560 (dwarf2_start_symtab): Move to ...
1561 (dwarf2_cu::start_symtab): ... here. Update all callers
1562 (setup_type_unit_groups): Move to ...
1563 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
1565 (dwarf2_cu::reset_builder): New method.
1566 (process_full_compunit, process_full_type_unit): Use
1567 dwarf2_cu::reset_builder.
1568 (follow_die_offset): Record the ancestor CU if it is different
1569 from the followed DIE's CU.
1570 (follow_die_sig_1): Likewise.
1572 2019-01-15 Tom Tromey <tom@tromey.com>
1574 * remote.c (class remote_state) <buf>: Now a char_vector.
1576 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
1578 (remote_target::getpkt_or_notif_sane_1)
1579 (remote_target::getpkt_sane)
1580 (remote_target::getpkt_or_notif_sane): Likewise.
1581 (class remote_target) <putpkt>: New overload.
1582 (remote_target::read_frame): Change type of "buf_p". Remove
1584 (packet_ok): New overload.
1585 (packet_check_result): New overload.
1588 2019-01-14 Tom Tromey <tom@tromey.com>
1590 * remote-notif.c (handle_notification, remote_notif_ack)
1591 (remote_notif_parse): Make "buf" const.
1592 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1594 (remote_notif_parse, remote_notif_ack, handle_notification):
1596 * remote.c (remote_notif_stop_parse): Make "buf" const.
1597 (remote_target::remote_parse_stop_reply): Make "buf" const.
1598 (remote_notif_stop_ack): Make "buf" const.
1600 2019-01-14 Tom Tromey <tom@tromey.com>
1602 * remote.c (remote_console_output): Make parameter const.
1604 2019-01-14 Tom Tromey <tom@tromey.com>
1606 * target-debug.h (target_debug_print_signals): Constify.
1607 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1608 * procfs.c (procfs_target::pass_signals): Update.
1609 * linux-nat.c (linux_nat_target::pass_signals): Update.
1610 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1611 * target-delegates.c: Rebuild.
1612 * remote.c (remote_target::program_signals): Update.
1613 (remote_target::pass_signals): Update.
1614 * target.c (target_pass_signals): Constify argument.
1615 (target_program_signals): Likewise.
1616 * target.h (struct target_ops) <pass_signals, program_signals>:
1618 (target_pass_signals, target_program_signals): Constify argument.
1620 2019-01-14 Tom Tromey <tom@tromey.com>
1623 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1625 2019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
1627 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1629 * rs6000-tdep.c: Include reggroups.h.
1630 (IS_V_ALIAS_PSEUDOREG): Define.
1631 (rs6000_register_name): Return names for the "vX" aliases.
1632 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1633 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
1634 aliases. Call default_register_reggroup_p for all other
1636 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1638 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1639 Handle "vX" aliases.
1640 (v_alias_pseudo_register_collect): New function.
1641 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1642 (rs6000_gdbarch_init): Initialize "vX" aliases as
1643 pseudo-registers. Restore registration of
1644 rs6000_pseudo_register_reggroup_p with
1645 set_tdesc_pseudo_register_reggroup_p.
1647 2019-01-13 Max Filippov <jcmvbkbc@gmail.com>
1649 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1650 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1651 set_gdbarch_num_pseudo_regs.
1653 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1655 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1656 Remove arg prefixname, add do_set and do_show.
1657 Add member functions set_list and show_list.
1658 * cli/cli-style.c (class cli_style_option): Update accordingly.
1659 (style_set_list): Move to file scope.
1660 (style_show_list): Likewise.
1661 (set_style): Call help_list.
1662 (show_style): Call cmd_show_list.
1663 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1664 Update to use the new macro.
1666 2019-10-12 Joel Brobecker <brobecker@adacore.com>
1668 * ada-lang.c (_initialize_ada_language): Expand the help text
1669 for the "catch exception" command.
1671 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1673 * symtab.c (matching_obj_sections): Initialize obj,
1674 declare it closer to its usage.
1676 2019-01-10 Tom Tromey <tom@tromey.com>
1678 * thread-iter.h (inf_threads_iterator): Use next_iterator.
1679 (basic_inf_threads_range): Remove.
1680 (inf_threads_range, inf_non_exited_threads_range)
1681 (safe_inf_threads_range): Use next_adapter.
1683 2019-01-10 Keith Seitz <keiths@redhat.com>
1687 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1688 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1690 2019-01-10 Keith Seitz <keiths@redhat.com>
1694 * dictionary.c (pending_to_vector): Remove.
1695 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1696 Remove _1 suffix, replacing functions of the same name. Update
1698 (dict_create_hashed, dict_create_hashed_expandable)
1699 (dict_create_linear, dict_create_linear_expandable, dict_free)
1700 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1701 Make functions static.
1703 2019-01-10 Keith Seitz <keiths@redhat.com>
1707 * dictionary.h (struct dictionary): Replace declaration with
1709 (dict_create_hashed, dict_create_hashed_expandable)
1710 (dict_create_linear, dict_create_linear_expandable)
1711 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1712 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1713 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1714 taking multidictionary argument.
1715 [ALL_DICT_SYMBOLS]: Update for multidictionary.
1716 * block.h (struct block) <dict>: Change to multidictionary
1717 and rename `multidict'.
1718 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1719 symmisc.c: Update all dictionary references to multidictionary.
1721 2019-01-10 Keith Seitz <keiths@redhat.com>
1725 * dictionary.c: Include unordered_map.
1726 (pending_to_vector): New function.
1727 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1728 Rewrite the non-"_1" functions to take vector instead
1730 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1731 "new" _1 versions of the same name.
1732 (multidictionary): Define.
1733 (std::hash<enum language): New definition.
1734 (collate_pending_symbols_by_language, mdict_create_hashed)
1735 (mdict_create_hashed_expandable, mdict_create_linear)
1736 (mdict_create_linear_expandable, mdict_free)
1737 (find_language_dictionary, create_new_language_dictionary)
1738 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1739 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1740 (mdict_size, mdict_empty): New functions.
1741 * dictionary.h (mdict_iterator): Define.
1743 2019-01-10 Pedro Alves <palves@redhat.com>
1745 * breakpoint.c (read_uploaded_action)
1746 (create_tracepoint_from_upload): Adjust to use
1747 gdb::unique_xmalloc_ptr.
1748 * ctf.c (ctf_write_uploaded_tp):
1749 (SET_ARRAY_FIELD): Use emplace_back.
1750 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1751 * tracefile-tfile.c (tfile_write_uploaded_tp):
1752 * tracepoint.c (parse_tracepoint_definition): Adjust to use
1753 gdb::unique_xmalloc_ptr.
1754 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1755 at_string, cond_string, cmd_strings>: Replace char pointers
1756 with gdb::unique_xmalloc_ptr.
1758 2019-01-10 Pedro Alves <palves@redhat.com>
1760 * solib-target.c (library_list_start_library): Don't xstrdup name.
1762 2019-01-10 Pedro Alves <palves@redhat.com>
1764 * mdebugread.c (parse_partial_symbols): Use
1765 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1767 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
1769 * linux-fork.c (scoped_switch_fork_info)
1770 <~scoped_switch_fork_info>: Fix incorrect variable name.
1772 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
1774 * linux-fork.c (scoped_switch_fork_info)
1775 <scoped_switch_fork_info>: Make explicit.
1776 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1778 2019-01-10 Tom Tromey <tom@tromey.com>
1780 * objfiles.h (objfile::reset_psymtabs): Update.
1781 * objfiles.c (objfile::objfile): Update.
1782 * psymtab.h (psymtab_storage::obstack): Update.
1783 (psymtab_storage::m_obstack): Use gdb::optional.
1784 (class psymtab_storage): Update comment. Remove objfile
1786 * psymtab.c (psymtab_storage::psymtab_storage): Update.
1788 2019-01-10 Tom Tromey <tom@tromey.com>
1790 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1791 <free_psymtabs>: Now private.
1792 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1793 (allocate_psymtab): Use new method.
1795 2019-01-10 Tom Tromey <tom@tromey.com>
1797 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1798 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1799 * mdebugread.c (parse_partial_symbols): Use
1800 allocate_dependencies.
1801 * dwarf2read.c (dwarf2_create_include_psymtab): Use
1802 allocate_dependencies.
1803 (process_psymtab_comp_unit_reader)
1804 (build_type_psymtab_dependencies): Likewise.
1805 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1807 2019-01-10 Tom Tromey <tom@tromey.com>
1809 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1810 PSYMBOL_SET_LANGUAGE.
1811 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1813 2019-01-10 Tom Tromey <tom@tromey.com>
1815 * psymtab.h (psymtab_storage::obstack): New method.
1816 <m_obstack>: Rename from obstack; now private.
1817 * psymtab.c (psymtab_storage): Update.
1818 * dwarf2read.c (create_addrmap_from_index)
1819 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1822 2019-01-10 Tom Tromey <tom@tromey.com>
1824 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1825 * objfiles.h (objfile::reset_psymtabs): New method.
1827 2019-01-10 Tom Tromey <tom@tromey.com>
1829 * symmisc.c (print_symbol_bcache_statistics): Update.
1830 (print_objfile_statistics): Update.
1831 * symfile.c (reread_symbols): Update.
1832 * psymtab.h (class psymtab_storage): New.
1833 * psymtab.c (psymtab_storage): New constructor.
1834 (~psymtab_storage): New destructor.
1835 (require_partial_symbols): Update.
1836 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1837 (find_pc_sect_psymtab, find_pc_sect_psymbol)
1838 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1839 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1840 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1841 (start_psymtab_common, end_psymtab_common)
1842 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1843 (allocate_psymtab): Update.
1844 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1846 (dump_psymtab_addrmap, maintenance_print_psymbols)
1847 (maintenance_check_psymtabs): Update.
1848 (class objfile_psymtabs): Move to objfiles.h.
1849 * psympriv.h (discard_psymtab): Now inline.
1850 (psymtab_discarder::psymtab_discarder): Update.
1851 (psymtab_discarder::~psymtab_discarder): Update.
1852 (ALL_OBJFILE_PSYMTABS): Rewrite.
1853 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1854 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1856 <partial_symtabs>: New field.
1857 (class objfile_psymtabs): Move from psymtab.h. Update.
1858 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1860 (objfile::~objfile): Don't destroy psymbol_cache.
1861 * mdebugread.c (parse_partial_symbols): Update.
1862 * dwarf2read.c (create_addrmap_from_index)
1863 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1864 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1865 (add_partial_subprogram, dwarf2_ranges_read): Update.
1866 * dwarf-index-write.c (write_address_map)
1867 (write_one_signatured_type, recursively_write_psymbols)
1868 (class debug_names, class debug_names, write_psymtabs_to_index):
1871 2019-01-10 Tom Tromey <tom@tromey.com>
1873 * symtab.h (SYMBOL_SET_NAMES): Update.
1874 (symbol_set_names): Update.
1875 (MSYMBOL_SET_NAMES): Update.
1876 * symtab.c (symbol_set_names): Change argument to be an
1877 objfile_per_bfd_storage.
1878 * psymtab.c (add_psymbol_to_bcache): Update.
1879 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1881 2019-01-10 Tom Tromey <tom@tromey.com>
1883 * symtab.c (create_demangled_names_hash): Change argument to be an
1884 objfile_per_bfd_storage.
1885 (symbol_set_names): Update.
1887 2019-01-10 Tom Tromey <tom@tromey.com>
1889 * xcoffread.c (xcoff_initial_scan): Unconditionally call
1891 * psymtab.c (init_psymbol_list): Do nothing if already called.
1892 * psympriv.h (init_psymbol_list): Add comment.
1893 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1895 * dbxread.c (dbx_symfile_read): Unconditionally call
1898 2019-01-10 Tom Tromey <tom@tromey.com>
1900 * xcoffread.c (scan_xcoff_symtab): Update.
1901 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1903 * mdebugread.c (parse_partial_symbols)
1904 (handle_psymbol_enumerators): Update.
1905 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1906 * dbxread.c (read_dbx_symtab): Update.
1907 * psympriv.h (psymbol_placement): New enum.
1908 (add_psymbol_to_list): Update.
1910 2019-01-10 Tom Tromey <tom@tromey.com>
1912 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1913 static_psymbols parameters.
1914 (scan_xcoff_symtab): Update.
1915 * psymtab.c (start_psymtab_common): Remove global_psymbols and
1916 static_psymbols parameters.
1917 * psympriv.h (start_psymtab_common): Update.
1918 * mdebugread.c (parse_partial_symbols): Update.
1919 * dwarf2read.c (create_partial_symtab): Update.
1920 * dbxread.c (read_dbx_symtab): Update.
1921 (start_psymtab): Remove global_psymbols and static_psymbols
1924 2019-01-10 Tom Tromey <tom@tromey.com>
1926 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1927 * psymtab.c (allocate_psymtab): Add comment.
1928 * psympriv.h (allocate_psymtab): Add comment.
1929 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1931 * dbxread.c (dbx_end_psymtab): Remove some initializations.
1933 2019-01-10 Tom Tromey <tom@tromey.com>
1935 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1937 * mipsread.c: Include mdebugread.h.
1938 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1940 * elfread.c: Include mdebugread.h.
1942 2019-01-09 Tom Tromey <tom@tromey.com>
1944 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1945 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1946 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1947 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1948 (psym_lookup_symbol, psym_find_last_source_symtab)
1949 (psym_forget_cached_source_info, psym_print_stats)
1950 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1951 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1952 (psym_map_matching_symbols, psym_expand_symtabs_matching)
1953 (psym_find_compunit_symtab_by_address)
1954 (maintenance_print_psymbols, maintenance_info_psymtabs)
1955 (maintenance_check_psymtabs): Use ranged for.
1956 * psymtab.h (class objfile_psymtabs): New.
1957 (require_partial_symbols): Return objfile_psymtabs.
1958 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1960 2019-01-09 Tom Tromey <tom@tromey.com>
1962 * symfile.c (overlay_invalidate_all, find_pc_overlay)
1963 (find_pc_mapped_section, list_overlays_command)
1964 (map_overlay_command, unmap_overlay_command)
1965 (simple_overlay_update): Use all_objfiles.
1966 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1967 * printcmd.c (info_symbol_command): Use all_objfiles.
1968 * objfiles.h (ALL_OBJSECTIONS): Remove.
1969 * maint.c (maintenance_translate_address): Use all_objfiles.
1970 * gcore.c (gcore_create_callback): Use all_objfiles.
1971 (objfile_find_memory_regions): Likewise.
1973 2019-01-09 Tom Tromey <tom@tromey.com>
1975 * symtab.c (find_line_symtab, info_sources_command)
1976 (make_source_files_completion_list): Use objfile_compunits.
1977 * source.c (select_source_symtab): Use objfile_compunits.
1978 * objfiles.h (struct objfile): Update comment.
1979 (ALL_OBJFILES): Remove.
1980 (ALL_FILETABS): Remove.
1981 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1984 2019-01-09 Tom Tromey <tom@tromey.com>
1986 * symmisc.c (print_objfile_statistics, dump_objfile)
1987 (maintenance_print_symbols): Use compunit_filetabs.
1988 * source.c (forget_cached_source_info_for_objfile): Use
1990 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1991 (ALL_FILETABS): Use compunit_filetabs.
1992 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1993 * coffread.c (coff_symtab_read): Use compunit_filetabs.
1995 2019-01-09 Tom Tromey <tom@tromey.com>
1997 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1998 (compunit_filetabs): New.
1999 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2001 (info_sources_command, make_source_files_completion_list): Remove
2003 * symmisc.c (print_objfile_statistics, dump_objfile)
2004 (maintenance_print_symbols): Remove declaration.
2005 (maintenance_info_symtabs): Use compunit_filetabs.
2006 (maintenance_info_line_tables): Likewise.
2007 * source.c (select_source_symtab): Change local variable name.
2008 (forget_cached_source_info_for_objfile): Remove declaration.
2009 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2010 * objfiles.c (objfile_relocate1): Remove declaration.
2011 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2013 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2014 * coffread.c (coff_symtab_read): Remove declaration.
2015 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2018 2019-01-09 Tom Tromey <tom@tromey.com>
2020 * symtab.c (lookup_objfile_from_block)
2021 (find_pc_sect_compunit_symtab, search_symbols)
2022 (default_collect_symbol_completion_matches_break_on): Use
2024 * objfiles.h (ALL_COMPUNITS): Remove.
2025 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2026 * cp-support.c (add_symbol_overload_list_qualified): Use
2028 * ada-lang.c (ada_collect_symbol_completion_matches)
2029 (ada_add_global_exceptions): Use objfile_compunits.
2031 2019-01-09 Tom Tromey <tom@tromey.com>
2033 * source.c (select_source_symtab)
2034 (forget_cached_source_info_for_objfile): Remove declaration.
2035 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2037 * maint.c (count_symtabs_and_blocks): Remove declaration.
2038 * cp-support.c (add_symbol_overload_list_qualified): Remove
2040 * coffread.c (coff_symtab_read): Remove declaration.
2041 * symtab.c (lookup_symbol_in_objfile_symtabs)
2042 (basic_lookup_transparent_type_1): Use objfile_compunits.
2043 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2044 (info_sources_command, search_symbols)
2045 (default_collect_symbol_completion_matches_break_on)
2046 (make_source_files_completion_list): Remove declaration.
2047 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2048 (ada_collect_symbol_completion_matches)
2049 (ada_add_global_exceptions): Remove declaration.
2050 * linespec.c (iterate_over_all_matching_symtabs): Use
2052 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2053 (class objfile_compunits): New.
2054 (ALL_COMPUNITS): Use objfile_compunits.
2055 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2056 (maintenance_check_symtabs, maintenance_info_line_tables): Use
2058 * objfiles.c (objfile_relocate1): Use objfile_compunits.
2060 2019-01-09 Tom Tromey <tom@tromey.com>
2062 * symtab.c (search_symbols)
2063 (default_collect_symbol_completion_matches_break_on): Use
2065 * ada-lang.c (ada_lookup_simple_minsym)
2066 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2067 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2068 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2070 * coffread.c (coff_symfile_read): Use objfile_msymbols.
2071 * symmisc.c (dump_msymbols): Use objfile_msymbols.
2072 * objc-lang.c (find_methods): Use objfile_msymbols.
2073 (info_selectors_command, info_classes_command): Likewise.
2074 * stabsread.c (scan_file_globals): Use objfile_msymbols.
2075 * objfiles.h (class objfile_msymbols): New.
2076 (ALL_OBJFILE_MSYMBOLS): Remove.
2077 (ALL_MSYMBOLS): Remove.
2079 2019-01-09 Tom Tromey <tom@tromey.com>
2081 * common/next-iterator.h (next_adapter): Add Iterator template
2083 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2084 (class all_objfiles_safe): New.
2085 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2086 * objfiles.c (put_objfile_before): Update comment.
2087 (add_separate_debug_objfile): Likewise.
2088 (free_all_objfiles): Use all_objfiles_safe.
2089 (objfile_purge_solibs): Likewise.
2091 2019-01-09 Tom Tromey <tom@tromey.com>
2093 * symtab.c (iterate_over_symtabs, matching_obj_sections)
2094 (expand_symtab_containing_pc, lookup_static_symbol)
2095 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2096 (find_symbol_at_address, find_line_symtab, find_main_name): Use
2098 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2099 * breakpoint.c (create_overlay_event_breakpoint)
2100 (create_longjmp_master_breakpoint)
2101 (create_std_terminate_master_breakpoint)
2102 (create_exception_master_breakpoint): Use all_objfiles.
2103 * linux-thread-db.c (try_thread_db_load_from_pdir)
2104 (has_libpthread): Use all_objfiles.
2105 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2106 * linespec.c (iterate_over_all_matching_symtabs)
2107 (search_minsyms_for_name): Use all_objfiles.
2108 * maint.c (maintenance_info_sections): Use all_objfiles.
2109 * main.c (captured_main_1): Use all_objfiles.
2110 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2111 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2112 * guile/scm-pretty-print.c
2113 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2114 * solib-spu.c (append_ocl_sos): Use all_objfiles.
2115 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2116 (maintenance_print_msymbols): Use all_objfiles.
2117 * source.c (select_source_symtab): Use all_objfiles.
2118 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2119 * symfile.c (remove_symbol_file_command)
2120 (expand_symtabs_matching, map_symbol_filenames): Use
2122 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2124 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2125 * objc-lang.c (find_methods): Use all_objfiles.
2126 * objfiles.c (have_partial_symbols, have_full_symbols)
2127 (have_minimal_symbols, qsort_cmp)
2128 (default_iterate_over_objfiles_in_search_order): Use
2130 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2131 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2132 (maintenance_check_psymtabs): Use all_objfiles.
2133 (ALL_PSYMTABS): Remove.
2134 * compile/compile-object-run.c (do_module_cleanup): Use
2136 * blockframe.c (find_pc_partial_function): Use all_objfiles.
2137 * cp-support.c (add_symbol_overload_list_qualified): Use
2139 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2141 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2142 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2144 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2145 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2146 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2148 * solib.c (solib_read_symbols): Use all_objfiles
2150 2019-01-09 Tom Tromey <tom@tromey.com>
2152 * probe.c (parse_probes_in_pspace): Use all_objfiles.
2153 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2155 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2156 * symmisc.c (print_symbol_bcache_statistics)
2157 (print_objfile_statistics, maintenance_print_objfiles)
2158 (maintenance_info_symtabs, maintenance_check_symtabs)
2159 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2161 * source.c (forget_cached_source_info): Use all_objfiles.
2162 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2163 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2164 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2165 * objfiles.c (update_section_map): Use all_objfiles.
2166 (shared_objfile_contains_address_p): Likewise.
2167 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2168 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2170 2019-01-09 Tom Tromey <tom@tromey.com>
2172 * common/next-iterator.h: New file.
2173 * objfiles.h (class all_objfiles): New.
2174 (struct objfile_iterator): New.
2176 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2178 * NEWS: Move the description of the changed "frame", "select-frame",
2179 and "info frame" commands to the Changed commands section.
2181 2019-01-09 Simon Marchi <simon.marchi@ericsson.com>
2183 * gdbtypes.c (check_stub_method_group): Remove handling of old
2185 * linespec.c (find_methods): Likewise.
2186 * stabsread.c (read_member_functions): Likewise.
2187 * valops.c (search_struct_method): Likewise.
2188 (value_struct_elt_for_reference): Likewise.
2189 * NEWS: Mention this change.
2191 2019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
2193 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2195 * source.c (print_source_lines_base): Update line number check.
2196 (print_source_lines): New function.
2197 (source_lines_range::source_lines_range): New function.
2198 * source.h (class source_lines_range): New class.
2199 (print_source_lines): New declaration.
2201 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2203 * linespec.c (linespec_state_destructor): Free self->canonical_names.
2205 2019-01-08 Tom Tromey <tom@tromey.com>
2206 Simon Marchi <simon.marchi@ericsson.com>
2209 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2210 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2211 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2212 * f-exp.y (DOLLAR_VARIABLE): Likewise.
2213 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2214 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2216 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
2218 * source.c (select_source_symtab): Move header comment to
2219 declaration in source.h.
2220 (forget_cached_source_info_for_objfile): Likewise.
2221 (forget_cached_source_info): Likewise.
2222 (identify_source_line): Likewise.
2223 * source.h (identify_source_line): Move declaration from symtab.h
2224 and add comment from source.c
2225 (print_source_lines): Likewise.
2226 (forget_cached_source_info_for_objfile): Likewise.
2227 (forget_cached_source_info): Likewise.
2228 (select_source_symtab): Likewise.
2229 (enum print_source_lines_flag): Move definition from symtab.h.
2230 * symtab.h (identify_source_line): Move declaration to source.h.
2231 (print_source_lines): Likewise.
2232 (forget_cached_source_info_for_objfile): Likewise.
2233 (forget_cached_source_info): Likewise.
2234 (select_source_symtab): Likewise.
2235 (enum print_source_lines_flag): Move definition to source.h.
2236 * tui/tui-hooks.c: Add 'source.h' include.
2238 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
2240 * source.c (print_source_lines_base): Handle requests to print
2241 reverse line number sequences, and guard against empty lines
2244 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
2246 * source.c (print_source_lines_base): Fix skip of '\r' if next
2249 2019-01-06 Tom Tromey <tom@tromey.com>
2251 * c-exp.y (struct c_parse_state) <macro_original_text,
2252 expansion_obstack>: New member.
2253 (macro_original_text, expansion_obstack): Remove globals.
2254 (scan_macro_expansion, scanning_macro_expansion)
2255 (finished_macro_expansion): Update.
2256 (scan_macro_cleanup): Remove.
2257 (yylex, c_parse): Update.
2259 2019-01-06 Tom Tromey <tom@tromey.com>
2261 * c-exp.y (struct c_parse_state) <strings>: New member.
2262 (operator_stoken): Update.
2264 2019-01-06 Tom Tromey <tom@tromey.com>
2266 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
2267 (union type_stack_elt) <typelist_val>: Now a pointer to
2269 (type_stack_cleanup): Don't declare.
2270 (push_typelist): Update.
2271 * parse.c (pop_typelist): Return a std::vector.
2272 (push_typelist): Take a std::vector.
2273 (follow_types): Update. Do not free args.
2274 (type_stack_cleanup): Remove.
2275 * c-exp.y (struct c_parse_state): New.
2276 (cpstate): New global.
2277 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2278 (nonempty_typelist): Update.
2279 (func_mod): Create a new vector.
2280 (c_parse): Create a c_parse_state.
2281 (check_parameter_typelist): Do not delete params.
2282 (function_method): Update. Do not delete type_list.
2284 2019-01-06 Tom Tromey <tom@tromey.com>
2287 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2289 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2290 (print_return_value): Likewise.
2292 2019-01-05 Tom Tromey <tom@tromey.com>
2294 * contrib/cleanup_check.py: Remove.
2295 * contrib/gcc-with-excheck: Remove.
2296 * contrib/exsummary.py: Remove.
2297 * contrib/excheck.py: Remove.
2299 2019-01-05 Joel Brobecker <brobecker@adacore.com>
2301 * thread.c (delete_thread_1): Add gdb_assert that THR is not
2302 NULL. Initialize tpprev to NULL instead of assigning it
2303 to NULL on the next statement.
2304 * windows-nat.c (windows_delete_thread): Remove check for
2305 main_thread_id before printing thread exit notifications.
2306 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2307 Remove thread ID check against main_thread_id.
2308 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2309 windows_delete_thread.
2310 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2312 2019-01-04 Tom Tromey <tom@tromey.com>
2314 * compile/compile.c (_initialize_compile): Use upper case for
2315 metasyntactic variables.
2316 * symmisc.c (_initialize_symmisc): Use upper case for
2317 metasyntactic variables.
2318 * psymtab.c (_initialize_psymtab): Use upper case for
2319 metasyntactic variables.
2320 * demangle.c (demangle_command): Use upper case for metasyntactic
2322 (_initialize_demangler): Likewise.
2323 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2326 2019-01-03 Tom Tromey <tom@tromey.com>
2328 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2330 2019-01-03 Tom Tromey <tom@tromey.com>
2332 * python/py-symtab.c (salpy_str): Update.
2333 (struct salpy_sal_object) <symtab>: Now a PyObject.
2334 (salpy_dealloc): Update.
2335 (del_objfile_sal): Use gdbpy_ref.
2337 2019-01-03 Tom Tromey <tom@tromey.com>
2339 * python/py-type.c (convert_field): Use new_reference. Return
2341 (make_fielditem): Return gdbpy_ref.
2342 (typy_fields): Update.
2343 (typy_getitem): Update.
2344 (field_name): Return gdbpy_ref. Use new_reference.
2345 (typy_iterator_iternext): Update.
2347 2019-01-03 Tom Tromey <tom@tromey.com>
2349 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2351 2019-01-03 Tom Tromey <tom@tromey.com>
2353 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2354 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2355 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2356 (pspy_set_frame_filters, pspy_set_frame_unwinders)
2357 (pspy_set_type_printers): Likewise.
2358 * python/py-function.c (fnpy_init): Use gdbpy_ref.
2359 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2360 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2361 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2362 (objfpy_set_type_printers): Likewise.
2364 2019-01-03 Tom Tromey <tom@tromey.com>
2366 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2367 (gdbpy_print_stack): Use gdbpy_err_fetch.
2368 * python/python-internal.h (class gdbpy_err_fetch): New class.
2369 (class gdbpy_enter) <m_error_type, m_error_value,
2370 m_error_traceback>: Remove.
2371 <m_error>: New member.
2372 (gdbpy_exception_to_string): Don't declare.
2373 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2374 * python/py-value.c (convert_value_from_python): Use
2376 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2377 gdbpy_exception_to_string.
2378 (gdbpy_handle_exception): Use gdbpy_err_fetch.
2379 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2382 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
2384 * linux-nat.c (delete_lwp_cleanup): Delete.
2385 (struct lwp_deleter): New struct.
2386 (lwp_info_up): New typedef.
2387 (linux_nat_target::follow_fork): Delete cleanup, and make use of
2390 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
2392 * linux-fork.c (class scoped_switch_fork_info): New class.
2393 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2395 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
2397 * valops.c (find_overload_match): Remove use of null_cleanup, and
2398 calls to do_cleanups.
2400 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
2402 * compile/compile-cplus-types.c
2403 (compile_cplus_instance::decl_name): Handle changes to
2405 * cp-support.c (cp_func_name): Update header comment, update
2407 * cp-support.h (cp_func_name): Update return type in declaration.
2408 * valops.c (find_overload_match): Move temp_func local to top
2409 level of function and change its type. Use temp_func to hold and
2410 delete temporary string obtained from cp_func_name.
2412 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
2414 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2415 gdb::char_vector, remove cleanup, and update uses of `msg`.
2417 2019-01-03 Jim Wilson <jimw@sifive.com>
2419 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2421 2019-01-02 Tom Tromey <tom@tromey.com>
2423 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2424 (tdesc_parse_xml): Remove cleanups.
2425 * target-descriptions.h (make_cleanup_free_target_description):
2427 (target_desc_deleter): New struct.
2428 (target_desc_up): New typedef.
2429 * target-descriptions.c (target_desc_deleter::operator()): Rename
2430 from free_target_description.
2431 (make_cleanup_free_target_description): Remove.
2433 2019-01-02 Tom Tromey <tom@tromey.com>
2435 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
2436 constructor, destructor.
2437 (linespec_parser): Remove typedef.
2438 (~linespec_parser): Rename from linespec_parser_delete.
2439 (linespec_lex_to_end, linespec_complete_label)
2440 (linespec_complete): Update.
2441 (decode_line_full): Remove cleanups.
2442 (decode_line_1): Update.
2444 2019-01-02 Tom Tromey <tom@tromey.com>
2446 * python/python-internal.h (inferior_to_inferior_object): Change
2448 * python/py-exitedevent.c (create_exited_event_object): Update.
2449 * python/py-inferior.c (inferior_to_inferior_object): Return
2451 (python_new_inferior, python_inferior_deleted)
2452 (thread_to_thread_object, delete_thread_object)
2453 (build_inferior_list, gdbpy_selected_inferior): Update.
2454 * python/py-infthread.c (create_thread_object): Update. Also fail
2455 if inferior_to_inferior_object fails.
2457 2019-01-02 Simon Marchi <simon.marchi@ericsson.com>
2459 * inferior.h (class inferior) <displaced_step_state>: New field.
2460 * infrun.h (struct displaced_step_state): Move here from
2461 infrun.c. Initialize fields, add constructor.
2462 <inf>: Remove field.
2463 <reset>: New method.
2464 * infrun.c (struct displaced_step_inferior_state): Move to
2466 (displaced_step_inferior_states): Remove.
2467 (get_displaced_stepping_state): Adust.
2468 (displaced_step_in_progress_any_inferior): Adjust.
2469 (displaced_step_in_progress_thread): Adjust.
2470 (displaced_step_in_progress): Adjust.
2471 (add_displaced_stepping_state): Remove.
2472 (get_displaced_step_closure_by_addr): Adjust.
2473 (remove_displaced_stepping_state): Remove.
2474 (infrun_inferior_exit): Call displaced_step_state.reset.
2475 (use_displaced_stepping): Don't check for NULL.
2476 (displaced_step_prepare_throw): Call
2477 get_displaced_stepping_state.
2478 (displaced_step_fixup): Don't check for NULL.
2479 (prepare_for_detach): Don't check for NULL.
2481 2019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2483 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2484 in case of call that did not complete.
2486 2019-01-02 Andrey Utkin <autkin@undo.io>
2488 * symfile.c (find_separate_debug_file): Fix search of debug files for
2491 2019-01-02 Tom Tromey <tom@tromey.com>
2493 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2495 * python/py-frame.c (frapy_older): Remove cast.
2496 (frapy_newer): Likewise.
2497 * python/py-breakpoint.c (local_setattro): Remove cast.
2498 * python/py-arch.c (archpy_name): Remove local variable.
2499 * python/py-type.c (gdbpy_lookup_type): Remove cast.
2501 2019-01-02 Joel Brobecker <brobecker@adacore.com>
2503 * unittests/basic_string_view/element_access/char/empty.cc:
2504 Fix year range in copyright header.
2506 2019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
2508 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2510 <operator==>: Update with for removed field.
2512 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2513 <isa_features>: ...this.
2514 <abi_features>: New field.
2515 (riscv_isa_flen): Update comment.
2516 (riscv_abi_xlen): New declaration.
2517 (riscv_abi_flen): New declaration.
2518 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2520 (riscv_abi_xlen): New function.
2521 (riscv_isa_flen): Update to get answer from isa_features.
2522 (riscv_abi_flen): New function.
2523 (riscv_has_fp_abi): Update to get answer from abi_features.
2524 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2526 (riscv_call_info) <xlen, flen>: Update comment.
2527 (riscv_call_arg_struct): Remove invalid assertions
2528 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2530 (riscv_gdbarch_init): Gather isa features and abi features
2531 separately, ensure both match on the gdbarch when reusing an old
2532 gdbarch. Relax an error check to allow 32-bit abi float to run on
2533 a target with 64-bit float hardware.
2535 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2537 * source.c (search_command_helper): Stop reverse search
2538 when line 1 has been searched.
2540 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2542 * record-full.c (record_full_base_target::close): Rewrite
2543 record_full_core_buf_list free logic.
2545 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2547 * break-catch-syscall.c (print_one_catch_syscall): xfree
2550 2019-01-01 Joel Brobecker <brobecker@adacore.com>
2552 * top.c (print_gdb_version): Update Copyright year in version
2555 2019-01-01 Joel Brobecker <brobecker@adacore.com>
2557 Update copyright year range in all GDB files.
2559 2019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2561 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2563 For older changes see ChangeLog-2018.
2569 version-control: never