AArch64: Ensure regcache is reset between tests
[external/binutils.git] / gdb / ChangeLog
1 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2
3         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
7
8 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
9
10         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11         function.
12         (fill_gregset): Call amd64_linux_collect_native_gregset instead
13         of amd64_collect_native_gregset.
14         (amd64_linux_nat_target::store_registers): Likewise.
15
16 2019-04-10  Tom Tromey  <tom@tromey.com>
17
18         * symtab.c (lookup_global_symbol_from_objfile)
19         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
20         * objfiles.h (class separate_debug_iterator): New.
21         (class separate_debug_range): New.
22         (struct objfile) <separate_debug_objfiles>: New method.
23         (objfile_separate_debug_iterate): Don't declare.
24         * objfiles.c (separate_debug_iterator::operator++): Rename from
25         objfile_separate_debug_iterate.
26         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
27         iterator.
28         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
29         iterator.
30
31 2019-04-10  Tom Tromey  <tom@tromey.com>
32
33         * symfile.c (reread_symbols): Remove old comment.
34         * objfiles.c (free_all_objfiles): Fix a typo.
35
36 2019-04-10  Tom Tromey  <tom@tromey.com>
37
38         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
39         * minsyms.c (lookup_minimal_symbol): Use foreach.
40         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
41         (lookup_minimal_symbol_solib_trampoline): Likewise.
42         * symfile.c (reread_symbols): Use foreach.
43
44 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
45             Tom Tromey  <tromey@adacore.com>
46
47         PR rust/24414:
48         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
49         (rust_lex_int_test): Change "value" to be LONGEST.
50         (rust_lex_tests): Add test for long integer literal.
51
52 2019-04-09  Tom Tromey  <tromey@adacore.com>
53
54         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
55         to bool.
56         (extended_remote_target::attach): Update.
57         (remote_target::remote_notice_new_inferior): Update.
58         (remote_target::add_current_inferior_and_thread): Update.
59         * inferior.c (exit_inferior_1): Use "false".
60         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
61
62 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
63
64         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
65         the "start" command.
66
67 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
68
69         * python/py-inferior.c (infpy_thread_from_thread_handle):
70         Adjust comments to reflect renaming of thread_from_thread_handle
71         to thread_from_handle.  Adjust keywords.  Fix type error message.
72         (inferior_object_methods): Add thread_from_handle.  Retain
73         thread_from_thread_handle, but mark it as deprecated.
74
75 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
76
77         * gdbthread.h (find_thread_by_handle): Revise declaration.
78         * thread.c (find_thread_by_handle): Likewise.  Adjust
79         implementation too.
80         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
81         support for buffer objects as handles.
82
83 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
84
85         * python/py-infthread.c (thpy_thread_handle): New function.
86         (thread_object_methods): Register thpy_thread_handle.
87
88 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
89
90         * gdbthread.h (thread_to_thread_handle): Declare.
91         * thread.c (gdbtypes.h): Include.
92         (thread_to_thread_handle): New function.
93
94         * target.h (struct target_ops): Add thread_info_to_thread_handle.
95         (target_thread_info_to_thread_handle): Declare.
96         * target.c (target_thread_info_to_thread_handle): New function.
97         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
98         * target-delegates.c: Regenerate.
99
100         * linux-thread-db.c (class thread_db_target): Add method
101         thread_info_to_thread_handle.
102         (thread_db_target::thread_info_to_thread_handle): Define.
103         * remote.c (class remote_target): Add new method
104         thread_info_to_thread_handle.
105         (remote_target::thread_info_to_thread_handle): Define.
106
107 2019-04-08  Pedro Alves  <palves@redhat.com>
108
109         * common/common-exceptions.c (throw_exception): Don't create
110         named object to throw; throw directly.
111         (throw_it): Likewise.  Don't initialize gdb_exception::message
112         here, with new; pass FMT and AP to the ctor instead.
113         * common/common-exceptions.h: Include <string>.
114         (gdb_exception::gdb_exception(enum return_reason, enum errors,
115         const char *, va_list)): New ctor.  Use std::make_shared.
116         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
117         errors)): Delete.
118         (gdb_exception_error::gdb_exception_error(enum errors, const char
119         *, va_list)): New.
120         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
121         Add assertion.
122         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
123         errors)): Delete.
124         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
125         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
126         Add assertion.
127
128 2019-04-08  Tom Tromey  <tom@tromey.com>
129
130         * valops.c (value_rtti_indirect_type): Replace throw_exception
131         with throw.
132         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
133         with throw.
134         * thread.c (thr_try_catch_cmd): Replace throw_exception with
135         throw.
136         * target.c (target_translate_tls_address): Replace throw_exception
137         with throw.
138         * stack.c (frame_apply_command_count): Replace throw_exception
139         with throw.
140         * solib-spu.c (append_ocl_sos): Replace throw_exception with
141         throw.
142         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
143         with throw.
144         * rs6000-tdep.c (rs6000_frame_cache)
145         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
146         * remote.c: Replace throw_exception with throw.
147         * record-full.c (record_full_message, record_full_wait_1)
148         (record_full_restore): Replace throw_exception with throw.
149         * record-btrace.c:
150         (get_thread_current_frame_id, record_btrace_start_replaying)
151         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
152         (cmd_record_btrace_start): Replace throw_exception with throw.
153         * parse.c (parse_exp_in_context_1): Replace throw_exception with
154         throw.
155         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
156         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
157         * linespec.c:
158         (find_linespec_symbols): Replace throw_exception with throw.
159         * infrun.c (displaced_step_prepare, resume): Replace
160         throw_exception with throw.
161         * infcmd.c (post_create_inferior): Replace throw_exception with
162         throw.
163         * inf-loop.c (inferior_event_handler): Replace throw_exception
164         with throw.
165         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
166         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
167         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
168         (get_prev_frame_always, get_frame_pc_if_available)
169         (get_frame_address_in_block_if_available, get_frame_language):
170         Replace throw_exception with throw.
171         * frame-unwind.c (frame_unwind_try_unwinder): Replace
172         throw_exception with throw.
173         * eval.c (fetch_subexp_value, evaluate_var_value)
174         (evaluate_funcall, evaluate_subexp_standard): Replace
175         throw_exception with throw.
176         * dwarf2loc.c (call_site_find_chain)
177         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
178         Replace throw_exception with throw.
179         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
180         with throw.
181         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
182         throw.
183         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
184         * completer.c (complete_line_internal): Replace throw_exception
185         with throw.
186         * compile/compile-object-run.c (compile_object_run): Replace
187         throw_exception with throw.
188         * cli/cli-script.c (process_next_line): Replace throw_exception
189         with throw.
190         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
191         (btrace_enable, btrace_maint_update_pt_packets): Replace
192         throw_exception with throw.
193         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
194         throw_exception with throw.
195         * break-catch-throw.c (re_set_exception_catchpoint): Replace
196         throw_exception with throw.
197         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
198         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
199         * aarch64-tdep.c (aarch64_make_prologue_cache)
200         (aarch64_make_stub_cache): Replace throw_exception with throw.
201
202 2019-04-08  Tom Tromey  <tom@tromey.com>
203
204         * common/common-exceptions.c (throw_exception): Rename from
205         throw_exception_cxx.  Remove old copy.  Make argument const.
206         (throw_it): Create and throw exception objects directly.
207         * common/common-exceptions.h (throw_exception): Make argument
208         const.
209         (struct gdb_exception_error): Add constructor.
210         (struct gdb_exception_quit): Add constructor.
211
212 2019-04-08  Tom Tromey  <tom@tromey.com>
213
214         * common/common-exceptions.h (exception_rethrow): Don't declare.
215         (TRY_SJLJ): Update comment.
216         (TRY, CATCH, END_CATCH): Remove.
217         * common/common-exceptions.c (exception_rethrow): Remove.
218
219 2019-04-08  Tom Tromey  <tom@tromey.com>
220
221         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
222         Remove.
223         (gdb_exception_error): Rename from
224         gdb_exception_RETURN_MASK_ERROR.
225         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
226         (gdb_quit_bad_alloc): Update.
227         * aarch64-tdep.c: Update.
228         * ada-lang.c: Update.
229         * ada-typeprint.c: Update.
230         * ada-valprint.c: Update.
231         * amd64-tdep.c: Update.
232         * arch-utils.c: Update.
233         * break-catch-throw.c: Update.
234         * breakpoint.c: Update.
235         * btrace.c: Update.
236         * c-varobj.c: Update.
237         * cli/cli-cmds.c: Update.
238         * cli/cli-interp.c: Update.
239         * cli/cli-script.c: Update.
240         * common/common-exceptions.c: Update.
241         * common/new-op.c: Update.
242         * common/selftest.c: Update.
243         * compile/compile-c-symbols.c: Update.
244         * compile/compile-cplus-symbols.c: Update.
245         * compile/compile-object-load.c: Update.
246         * compile/compile-object-run.c: Update.
247         * completer.c: Update.
248         * corelow.c: Update.
249         * cp-abi.c: Update.
250         * cp-support.c: Update.
251         * cp-valprint.c: Update.
252         * darwin-nat.c: Update.
253         * disasm-selftests.c: Update.
254         * dtrace-probe.c: Update.
255         * dwarf-index-cache.c: Update.
256         * dwarf-index-write.c: Update.
257         * dwarf2-frame-tailcall.c: Update.
258         * dwarf2-frame.c: Update.
259         * dwarf2loc.c: Update.
260         * dwarf2read.c: Update.
261         * eval.c: Update.
262         * event-loop.c: Update.
263         * event-top.c: Update.
264         * exec.c: Update.
265         * f-valprint.c: Update.
266         * fbsd-tdep.c: Update.
267         * frame-unwind.c: Update.
268         * frame.c: Update.
269         * gdbtypes.c: Update.
270         * gnu-v3-abi.c: Update.
271         * guile/guile-internal.h: Update.
272         * guile/scm-block.c: Update.
273         * guile/scm-breakpoint.c: Update.
274         * guile/scm-cmd.c: Update.
275         * guile/scm-disasm.c: Update.
276         * guile/scm-frame.c: Update.
277         * guile/scm-lazy-string.c: Update.
278         * guile/scm-math.c: Update.
279         * guile/scm-param.c: Update.
280         * guile/scm-ports.c: Update.
281         * guile/scm-pretty-print.c: Update.
282         * guile/scm-symbol.c: Update.
283         * guile/scm-symtab.c: Update.
284         * guile/scm-type.c: Update.
285         * guile/scm-value.c: Update.
286         * i386-linux-tdep.c: Update.
287         * i386-tdep.c: Update.
288         * inf-loop.c: Update.
289         * infcall.c: Update.
290         * infcmd.c: Update.
291         * infrun.c: Update.
292         * jit.c: Update.
293         * language.c: Update.
294         * linespec.c: Update.
295         * linux-fork.c: Update.
296         * linux-nat.c: Update.
297         * linux-tdep.c: Update.
298         * linux-thread-db.c: Update.
299         * main.c: Update.
300         * mi/mi-cmd-break.c: Update.
301         * mi/mi-cmd-stack.c: Update.
302         * mi/mi-interp.c: Update.
303         * mi/mi-main.c: Update.
304         * objc-lang.c: Update.
305         * p-valprint.c: Update.
306         * parse.c: Update.
307         * ppc-linux-tdep.c: Update.
308         * printcmd.c: Update.
309         * python/py-arch.c: Update.
310         * python/py-breakpoint.c: Update.
311         * python/py-cmd.c: Update.
312         * python/py-finishbreakpoint.c: Update.
313         * python/py-frame.c: Update.
314         * python/py-framefilter.c: Update.
315         * python/py-gdb-readline.c: Update.
316         * python/py-inferior.c: Update.
317         * python/py-infthread.c: Update.
318         * python/py-lazy-string.c: Update.
319         * python/py-linetable.c: Update.
320         * python/py-objfile.c: Update.
321         * python/py-param.c: Update.
322         * python/py-prettyprint.c: Update.
323         * python/py-progspace.c: Update.
324         * python/py-record-btrace.c: Update.
325         * python/py-record.c: Update.
326         * python/py-symbol.c: Update.
327         * python/py-type.c: Update.
328         * python/py-unwind.c: Update.
329         * python/py-utils.c: Update.
330         * python/py-value.c: Update.
331         * python/python.c: Update.
332         * record-btrace.c: Update.
333         * record-full.c: Update.
334         * remote-fileio.c: Update.
335         * remote.c: Update.
336         * riscv-tdep.c: Update.
337         * rs6000-aix-tdep.c: Update.
338         * rs6000-tdep.c: Update.
339         * rust-exp.y: Update.
340         * rust-lang.c: Update.
341         * s390-tdep.c: Update.
342         * selftest-arch.c: Update.
343         * solib-dsbt.c: Update.
344         * solib-frv.c: Update.
345         * solib-spu.c: Update.
346         * solib-svr4.c: Update.
347         * solib.c: Update.
348         * sparc64-linux-tdep.c: Update.
349         * stack.c: Update.
350         * symfile-mem.c: Update.
351         * symmisc.c: Update.
352         * target.c: Update.
353         * thread.c: Update.
354         * top.c: Update.
355         * tracefile-tfile.c: Update.
356         * tui/tui.c: Update.
357         * typeprint.c: Update.
358         * unittests/cli-utils-selftests.c: Update.
359         * unittests/parse-connection-spec-selftests.c: Update.
360         * valops.c: Update.
361         * valprint.c: Update.
362         * value.c: Update.
363         * varobj.c: Update.
364         * windows-nat.c: Update.
365         * x86-linux-nat.c: Update.
366         * xml-support.c: Update.
367
368 2019-04-08  Tom Tromey  <tom@tromey.com>
369
370         * xml-support.c: Use C++ exception handling.
371         * x86-linux-nat.c: Use C++ exception handling.
372         * windows-nat.c: Use C++ exception handling.
373         * varobj.c: Use C++ exception handling.
374         * value.c: Use C++ exception handling.
375         * valprint.c: Use C++ exception handling.
376         * valops.c: Use C++ exception handling.
377         * unittests/parse-connection-spec-selftests.c: Use C++ exception
378         handling.
379         * unittests/cli-utils-selftests.c: Use C++ exception handling.
380         * typeprint.c: Use C++ exception handling.
381         * tui/tui.c: Use C++ exception handling.
382         * tracefile-tfile.c: Use C++ exception handling.
383         * top.c: Use C++ exception handling.
384         * thread.c: Use C++ exception handling.
385         * target.c: Use C++ exception handling.
386         * symmisc.c: Use C++ exception handling.
387         * symfile-mem.c: Use C++ exception handling.
388         * stack.c: Use C++ exception handling.
389         * sparc64-linux-tdep.c: Use C++ exception handling.
390         * solib.c: Use C++ exception handling.
391         * solib-svr4.c: Use C++ exception handling.
392         * solib-spu.c: Use C++ exception handling.
393         * solib-frv.c: Use C++ exception handling.
394         * solib-dsbt.c: Use C++ exception handling.
395         * selftest-arch.c: Use C++ exception handling.
396         * s390-tdep.c: Use C++ exception handling.
397         * rust-lang.c: Use C++ exception handling.
398         * rust-exp.y: Use C++ exception handling.
399         * rs6000-tdep.c: Use C++ exception handling.
400         * rs6000-aix-tdep.c: Use C++ exception handling.
401         * riscv-tdep.c: Use C++ exception handling.
402         * remote.c: Use C++ exception handling.
403         * remote-fileio.c: Use C++ exception handling.
404         * record-full.c: Use C++ exception handling.
405         * record-btrace.c: Use C++ exception handling.
406         * python/python.c: Use C++ exception handling.
407         * python/py-value.c: Use C++ exception handling.
408         * python/py-utils.c: Use C++ exception handling.
409         * python/py-unwind.c: Use C++ exception handling.
410         * python/py-type.c: Use C++ exception handling.
411         * python/py-symbol.c: Use C++ exception handling.
412         * python/py-record.c: Use C++ exception handling.
413         * python/py-record-btrace.c: Use C++ exception handling.
414         * python/py-progspace.c: Use C++ exception handling.
415         * python/py-prettyprint.c: Use C++ exception handling.
416         * python/py-param.c: Use C++ exception handling.
417         * python/py-objfile.c: Use C++ exception handling.
418         * python/py-linetable.c: Use C++ exception handling.
419         * python/py-lazy-string.c: Use C++ exception handling.
420         * python/py-infthread.c: Use C++ exception handling.
421         * python/py-inferior.c: Use C++ exception handling.
422         * python/py-gdb-readline.c: Use C++ exception handling.
423         * python/py-framefilter.c: Use C++ exception handling.
424         * python/py-frame.c: Use C++ exception handling.
425         * python/py-finishbreakpoint.c: Use C++ exception handling.
426         * python/py-cmd.c: Use C++ exception handling.
427         * python/py-breakpoint.c: Use C++ exception handling.
428         * python/py-arch.c: Use C++ exception handling.
429         * printcmd.c: Use C++ exception handling.
430         * ppc-linux-tdep.c: Use C++ exception handling.
431         * parse.c: Use C++ exception handling.
432         * p-valprint.c: Use C++ exception handling.
433         * objc-lang.c: Use C++ exception handling.
434         * mi/mi-main.c: Use C++ exception handling.
435         * mi/mi-interp.c: Use C++ exception handling.
436         * mi/mi-cmd-stack.c: Use C++ exception handling.
437         * mi/mi-cmd-break.c: Use C++ exception handling.
438         * main.c: Use C++ exception handling.
439         * linux-thread-db.c: Use C++ exception handling.
440         * linux-tdep.c: Use C++ exception handling.
441         * linux-nat.c: Use C++ exception handling.
442         * linux-fork.c: Use C++ exception handling.
443         * linespec.c: Use C++ exception handling.
444         * language.c: Use C++ exception handling.
445         * jit.c: Use C++ exception handling.
446         * infrun.c: Use C++ exception handling.
447         * infcmd.c: Use C++ exception handling.
448         * infcall.c: Use C++ exception handling.
449         * inf-loop.c: Use C++ exception handling.
450         * i386-tdep.c: Use C++ exception handling.
451         * i386-linux-tdep.c: Use C++ exception handling.
452         * guile/scm-value.c: Use C++ exception handling.
453         * guile/scm-type.c: Use C++ exception handling.
454         * guile/scm-symtab.c: Use C++ exception handling.
455         * guile/scm-symbol.c: Use C++ exception handling.
456         * guile/scm-pretty-print.c: Use C++ exception handling.
457         * guile/scm-ports.c: Use C++ exception handling.
458         * guile/scm-param.c: Use C++ exception handling.
459         * guile/scm-math.c: Use C++ exception handling.
460         * guile/scm-lazy-string.c: Use C++ exception handling.
461         * guile/scm-frame.c: Use C++ exception handling.
462         * guile/scm-disasm.c: Use C++ exception handling.
463         * guile/scm-cmd.c: Use C++ exception handling.
464         * guile/scm-breakpoint.c: Use C++ exception handling.
465         * guile/scm-block.c: Use C++ exception handling.
466         * guile/guile-internal.h: Use C++ exception handling.
467         * gnu-v3-abi.c: Use C++ exception handling.
468         * gdbtypes.c: Use C++ exception handling.
469         * frame.c: Use C++ exception handling.
470         * frame-unwind.c: Use C++ exception handling.
471         * fbsd-tdep.c: Use C++ exception handling.
472         * f-valprint.c: Use C++ exception handling.
473         * exec.c: Use C++ exception handling.
474         * event-top.c: Use C++ exception handling.
475         * event-loop.c: Use C++ exception handling.
476         * eval.c: Use C++ exception handling.
477         * dwarf2read.c: Use C++ exception handling.
478         * dwarf2loc.c: Use C++ exception handling.
479         * dwarf2-frame.c: Use C++ exception handling.
480         * dwarf2-frame-tailcall.c: Use C++ exception handling.
481         * dwarf-index-write.c: Use C++ exception handling.
482         * dwarf-index-cache.c: Use C++ exception handling.
483         * dtrace-probe.c: Use C++ exception handling.
484         * disasm-selftests.c: Use C++ exception handling.
485         * darwin-nat.c: Use C++ exception handling.
486         * cp-valprint.c: Use C++ exception handling.
487         * cp-support.c: Use C++ exception handling.
488         * cp-abi.c: Use C++ exception handling.
489         * corelow.c: Use C++ exception handling.
490         * completer.c: Use C++ exception handling.
491         * compile/compile-object-run.c: Use C++ exception handling.
492         * compile/compile-object-load.c: Use C++ exception handling.
493         * compile/compile-cplus-symbols.c: Use C++ exception handling.
494         * compile/compile-c-symbols.c: Use C++ exception handling.
495         * common/selftest.c: Use C++ exception handling.
496         * common/new-op.c: Use C++ exception handling.
497         * cli/cli-script.c: Use C++ exception handling.
498         * cli/cli-interp.c: Use C++ exception handling.
499         * cli/cli-cmds.c: Use C++ exception handling.
500         * c-varobj.c: Use C++ exception handling.
501         * btrace.c: Use C++ exception handling.
502         * breakpoint.c: Use C++ exception handling.
503         * break-catch-throw.c: Use C++ exception handling.
504         * arch-utils.c: Use C++ exception handling.
505         * amd64-tdep.c: Use C++ exception handling.
506         * ada-valprint.c: Use C++ exception handling.
507         * ada-typeprint.c: Use C++ exception handling.
508         * ada-lang.c: Use C++ exception handling.
509         * aarch64-tdep.c: Use C++ exception handling.
510
511 2019-04-08  Tom Tromey  <tom@tromey.com>
512
513         * xml-support.c (gdb_xml_parser::parse): Update.
514         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
515         * value.c (show_convenience): Update.
516         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
517         (test_parse_flags_qcs): Update.
518         * thread.c (thr_try_catch_cmd): Update.
519         * target.c (target_translate_tls_address): Update.
520         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
521         (info_frame_command_core, frame_apply_command_count): Update.
522         * rust-exp.y (rust_lex_exception_test): Update.
523         * riscv-tdep.c (riscv_print_one_register_info): Update.
524         * remote.c (remote_target::enable_btrace): Update.
525         * record-btrace.c (record_btrace_enable_warn): Update.
526         * python/py-utils.c (gdbpy_convert_exception): Update.
527         * printcmd.c (do_one_display, print_variable_and_value): Update.
528         * mi/mi-main.c (mi_print_exception): Update.
529         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
530         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
531         * linux-nat.c (linux_nat_target::attach): Update.
532         * linux-fork.c (class scoped_switch_fork_info): Update.
533         * infrun.c (displaced_step_prepare): Update.
534         * infcall.c (call_function_by_hand_dummy): Update.
535         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
536         * gnu-v3-abi.c (print_one_vtable): Update.
537         * frame.c (get_prev_frame_always): Update.
538         * f-valprint.c (info_common_command_for_block): Update.
539         * exec.c (try_open_exec_file): Update.
540         * exceptions.c (print_exception, exception_print)
541         (exception_fprintf, exception_print_same): Update.
542         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
543         * dwarf-index-cache.c (index_cache::store)
544         (index_cache::lookup_gdb_index): Update.
545         * darwin-nat.c (maybe_cache_shell): Update.
546         * cp-valprint.c (cp_print_value_fields): Update.
547         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
548         (gcc_cplus_symbol_address): Update.
549         * compile/compile-c-symbols.c (gcc_convert_symbol)
550         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
551         * common/selftest.c: Update.
552         * common/common-exceptions.h (struct gdb_exception) <message>: Now
553         a std::string.
554         (exception_try_scope_entry, exception_try_scope_exit): Don't
555         declare.
556         (struct exception_try_scope): Remove.
557         (TRY): Don't use exception_try_scope.
558         (struct gdb_exception): Add constructor, operator=.
559         <what>: New method.
560         (struct gdb_exception_RETURN_MASK_ALL)
561         (struct gdb_exception_RETURN_MASK_ERROR)
562         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
563         (struct gdb_quit_bad_alloc): Update.
564         * common/common-exceptions.c (exception_none): Change
565         initializer.
566         (struct catcher) <state, exception>: Initialize inline.
567         <prev>: Remove member.
568         (current_catcher): Remove.
569         (catchers): New global.
570         (exceptions_state_mc_init): Simplify.
571         (catcher_pop): Remove.
572         (exceptions_state_mc, exceptions_state_mc_catch): Update.
573         (try_scope_depth, exception_try_scope_entry)
574         (exception_try_scope_exit): Remove.
575         (throw_exception_sjlj): Update.
576         (exception_messages, exception_messages_size): Remove.
577         (throw_it): Simplify.
578         (gdb_exception_sliced_copy): Remove.
579         (throw_exception_cxx): Update.
580         * cli/cli-script.c (script_from_file): Update.
581         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
582         Update.
583         * ada-valprint.c (ada_val_print): Update.
584         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
585         (create_excep_cond_exprs): Update.
586
587 2019-04-08  Tom Tromey  <tom@tromey.com>
588
589         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
590         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
591         (TRY, CATCH, END_CATCH): Remove some definitions.
592         * common/common-exceptions.c: Don't use GDB_XCPT.
593         (catcher_list_size): Remove.
594         (throw_exception, throw_it): Simplify.
595
596 2019-04-05  Tom Tromey  <tom@tromey.com>
597
598         Revert the header-sorting patch.
599         * ft32-tdep.c: Revert.
600         * frv-tdep.c: Revert.
601         * frv-linux-tdep.c: Revert.
602         * frame.c: Revert.
603         * frame-unwind.c: Revert.
604         * frame-base.c: Revert.
605         * fork-child.c: Revert.
606         * findvar.c: Revert.
607         * findcmd.c: Revert.
608         * filesystem.c: Revert.
609         * filename-seen-cache.h: Revert.
610         * filename-seen-cache.c: Revert.
611         * fbsd-tdep.c: Revert.
612         * fbsd-nat.h: Revert.
613         * fbsd-nat.c: Revert.
614         * f-valprint.c: Revert.
615         * f-typeprint.c: Revert.
616         * f-lang.c: Revert.
617         * extension.h: Revert.
618         * extension.c: Revert.
619         * extension-priv.h: Revert.
620         * expprint.c: Revert.
621         * exec.h: Revert.
622         * exec.c: Revert.
623         * exceptions.c: Revert.
624         * event-top.c: Revert.
625         * event-loop.c: Revert.
626         * eval.c: Revert.
627         * elfread.c: Revert.
628         * dwarf2read.h: Revert.
629         * dwarf2read.c: Revert.
630         * dwarf2loc.c: Revert.
631         * dwarf2expr.h: Revert.
632         * dwarf2expr.c: Revert.
633         * dwarf2-frame.c: Revert.
634         * dwarf2-frame-tailcall.c: Revert.
635         * dwarf-index-write.h: Revert.
636         * dwarf-index-write.c: Revert.
637         * dwarf-index-common.c: Revert.
638         * dwarf-index-cache.h: Revert.
639         * dwarf-index-cache.c: Revert.
640         * dummy-frame.c: Revert.
641         * dtrace-probe.c: Revert.
642         * disasm.h: Revert.
643         * disasm.c: Revert.
644         * disasm-selftests.c: Revert.
645         * dictionary.c: Revert.
646         * dicos-tdep.c: Revert.
647         * demangle.c: Revert.
648         * dcache.h: Revert.
649         * dcache.c: Revert.
650         * darwin-nat.h: Revert.
651         * darwin-nat.c: Revert.
652         * darwin-nat-info.c: Revert.
653         * d-valprint.c: Revert.
654         * d-namespace.c: Revert.
655         * d-lang.c: Revert.
656         * ctf.c: Revert.
657         * csky-tdep.c: Revert.
658         * csky-linux-tdep.c: Revert.
659         * cris-tdep.c: Revert.
660         * cris-linux-tdep.c: Revert.
661         * cp-valprint.c: Revert.
662         * cp-support.c: Revert.
663         * cp-namespace.c: Revert.
664         * cp-abi.c: Revert.
665         * corelow.c: Revert.
666         * corefile.c: Revert.
667         * continuations.c: Revert.
668         * completer.h: Revert.
669         * completer.c: Revert.
670         * complaints.c: Revert.
671         * coffread.c: Revert.
672         * coff-pe-read.c: Revert.
673         * cli-out.h: Revert.
674         * cli-out.c: Revert.
675         * charset.c: Revert.
676         * c-varobj.c: Revert.
677         * c-valprint.c: Revert.
678         * c-typeprint.c: Revert.
679         * c-lang.c: Revert.
680         * buildsym.c: Revert.
681         * buildsym-legacy.c: Revert.
682         * build-id.h: Revert.
683         * build-id.c: Revert.
684         * btrace.c: Revert.
685         * bsd-uthread.c: Revert.
686         * breakpoint.h: Revert.
687         * breakpoint.c: Revert.
688         * break-catch-throw.c: Revert.
689         * break-catch-syscall.c: Revert.
690         * break-catch-sig.c: Revert.
691         * blockframe.c: Revert.
692         * block.c: Revert.
693         * bfin-tdep.c: Revert.
694         * bfin-linux-tdep.c: Revert.
695         * bfd-target.c: Revert.
696         * bcache.c: Revert.
697         * ax-general.c: Revert.
698         * ax-gdb.h: Revert.
699         * ax-gdb.c: Revert.
700         * avr-tdep.c: Revert.
701         * auxv.c: Revert.
702         * auto-load.c: Revert.
703         * arm-wince-tdep.c: Revert.
704         * arm-tdep.c: Revert.
705         * arm-symbian-tdep.c: Revert.
706         * arm-pikeos-tdep.c: Revert.
707         * arm-obsd-tdep.c: Revert.
708         * arm-nbsd-tdep.c: Revert.
709         * arm-nbsd-nat.c: Revert.
710         * arm-linux-tdep.c: Revert.
711         * arm-linux-nat.c: Revert.
712         * arm-fbsd-tdep.c: Revert.
713         * arm-fbsd-nat.c: Revert.
714         * arm-bsd-tdep.c: Revert.
715         * arch-utils.c: Revert.
716         * arc-tdep.c: Revert.
717         * arc-newlib-tdep.c: Revert.
718         * annotate.h: Revert.
719         * annotate.c: Revert.
720         * amd64-windows-tdep.c: Revert.
721         * amd64-windows-nat.c: Revert.
722         * amd64-tdep.c: Revert.
723         * amd64-sol2-tdep.c: Revert.
724         * amd64-obsd-tdep.c: Revert.
725         * amd64-obsd-nat.c: Revert.
726         * amd64-nbsd-tdep.c: Revert.
727         * amd64-nbsd-nat.c: Revert.
728         * amd64-nat.c: Revert.
729         * amd64-linux-tdep.c: Revert.
730         * amd64-linux-nat.c: Revert.
731         * amd64-fbsd-tdep.c: Revert.
732         * amd64-fbsd-nat.c: Revert.
733         * amd64-dicos-tdep.c: Revert.
734         * amd64-darwin-tdep.c: Revert.
735         * amd64-bsd-nat.c: Revert.
736         * alpha-tdep.c: Revert.
737         * alpha-obsd-tdep.c: Revert.
738         * alpha-nbsd-tdep.c: Revert.
739         * alpha-mdebug-tdep.c: Revert.
740         * alpha-linux-tdep.c: Revert.
741         * alpha-linux-nat.c: Revert.
742         * alpha-bsd-tdep.c: Revert.
743         * alpha-bsd-nat.c: Revert.
744         * aix-thread.c: Revert.
745         * agent.c: Revert.
746         * addrmap.c: Revert.
747         * ada-varobj.c: Revert.
748         * ada-valprint.c: Revert.
749         * ada-typeprint.c: Revert.
750         * ada-tasks.c: Revert.
751         * ada-lang.c: Revert.
752         * aarch64-tdep.c: Revert.
753         * aarch64-ravenscar-thread.c: Revert.
754         * aarch64-newlib-tdep.c: Revert.
755         * aarch64-linux-tdep.c: Revert.
756         * aarch64-linux-nat.c: Revert.
757         * aarch64-fbsd-tdep.c: Revert.
758         * aarch64-fbsd-nat.c: Revert.
759         * aarch32-linux-nat.c: Revert.
760
761 2019-04-05  Tom Tromey  <tom@tromey.com>
762
763         * ft32-tdep.c: Sort headers.
764         * frv-tdep.c: Sort headers.
765         * frv-linux-tdep.c: Sort headers.
766         * frame.c: Sort headers.
767         * frame-unwind.c: Sort headers.
768         * frame-base.c: Sort headers.
769         * fork-child.c: Sort headers.
770         * findvar.c: Sort headers.
771         * findcmd.c: Sort headers.
772         * filesystem.c: Sort headers.
773         * filename-seen-cache.h: Sort headers.
774         * filename-seen-cache.c: Sort headers.
775         * fbsd-tdep.c: Sort headers.
776         * fbsd-nat.h: Sort headers.
777         * fbsd-nat.c: Sort headers.
778         * f-valprint.c: Sort headers.
779         * f-typeprint.c: Sort headers.
780         * f-lang.c: Sort headers.
781         * extension.h: Sort headers.
782         * extension.c: Sort headers.
783         * extension-priv.h: Sort headers.
784         * expprint.c: Sort headers.
785         * exec.h: Sort headers.
786         * exec.c: Sort headers.
787         * exceptions.c: Sort headers.
788         * event-top.c: Sort headers.
789         * event-loop.c: Sort headers.
790         * eval.c: Sort headers.
791         * elfread.c: Sort headers.
792         * dwarf2read.h: Sort headers.
793         * dwarf2read.c: Sort headers.
794         * dwarf2loc.c: Sort headers.
795         * dwarf2expr.h: Sort headers.
796         * dwarf2expr.c: Sort headers.
797         * dwarf2-frame.c: Sort headers.
798         * dwarf2-frame-tailcall.c: Sort headers.
799         * dwarf-index-write.h: Sort headers.
800         * dwarf-index-write.c: Sort headers.
801         * dwarf-index-common.c: Sort headers.
802         * dwarf-index-cache.h: Sort headers.
803         * dwarf-index-cache.c: Sort headers.
804         * dummy-frame.c: Sort headers.
805         * dtrace-probe.c: Sort headers.
806         * disasm.h: Sort headers.
807         * disasm.c: Sort headers.
808         * disasm-selftests.c: Sort headers.
809         * dictionary.c: Sort headers.
810         * dicos-tdep.c: Sort headers.
811         * demangle.c: Sort headers.
812         * dcache.h: Sort headers.
813         * dcache.c: Sort headers.
814         * darwin-nat.h: Sort headers.
815         * darwin-nat.c: Sort headers.
816         * darwin-nat-info.c: Sort headers.
817         * d-valprint.c: Sort headers.
818         * d-namespace.c: Sort headers.
819         * d-lang.c: Sort headers.
820         * ctf.c: Sort headers.
821         * csky-tdep.c: Sort headers.
822         * csky-linux-tdep.c: Sort headers.
823         * cris-tdep.c: Sort headers.
824         * cris-linux-tdep.c: Sort headers.
825         * cp-valprint.c: Sort headers.
826         * cp-support.c: Sort headers.
827         * cp-namespace.c: Sort headers.
828         * cp-abi.c: Sort headers.
829         * corelow.c: Sort headers.
830         * corefile.c: Sort headers.
831         * continuations.c: Sort headers.
832         * completer.h: Sort headers.
833         * completer.c: Sort headers.
834         * complaints.c: Sort headers.
835         * coffread.c: Sort headers.
836         * coff-pe-read.c: Sort headers.
837         * cli-out.h: Sort headers.
838         * cli-out.c: Sort headers.
839         * charset.c: Sort headers.
840         * c-varobj.c: Sort headers.
841         * c-valprint.c: Sort headers.
842         * c-typeprint.c: Sort headers.
843         * c-lang.c: Sort headers.
844         * buildsym.c: Sort headers.
845         * buildsym-legacy.c: Sort headers.
846         * build-id.h: Sort headers.
847         * build-id.c: Sort headers.
848         * btrace.c: Sort headers.
849         * bsd-uthread.c: Sort headers.
850         * breakpoint.h: Sort headers.
851         * breakpoint.c: Sort headers.
852         * break-catch-throw.c: Sort headers.
853         * break-catch-syscall.c: Sort headers.
854         * break-catch-sig.c: Sort headers.
855         * blockframe.c: Sort headers.
856         * block.c: Sort headers.
857         * bfin-tdep.c: Sort headers.
858         * bfin-linux-tdep.c: Sort headers.
859         * bfd-target.c: Sort headers.
860         * bcache.c: Sort headers.
861         * ax-general.c: Sort headers.
862         * ax-gdb.h: Sort headers.
863         * ax-gdb.c: Sort headers.
864         * avr-tdep.c: Sort headers.
865         * auxv.c: Sort headers.
866         * auto-load.c: Sort headers.
867         * arm-wince-tdep.c: Sort headers.
868         * arm-tdep.c: Sort headers.
869         * arm-symbian-tdep.c: Sort headers.
870         * arm-pikeos-tdep.c: Sort headers.
871         * arm-obsd-tdep.c: Sort headers.
872         * arm-nbsd-tdep.c: Sort headers.
873         * arm-nbsd-nat.c: Sort headers.
874         * arm-linux-tdep.c: Sort headers.
875         * arm-linux-nat.c: Sort headers.
876         * arm-fbsd-tdep.c: Sort headers.
877         * arm-fbsd-nat.c: Sort headers.
878         * arm-bsd-tdep.c: Sort headers.
879         * arch-utils.c: Sort headers.
880         * arc-tdep.c: Sort headers.
881         * arc-newlib-tdep.c: Sort headers.
882         * annotate.h: Sort headers.
883         * annotate.c: Sort headers.
884         * amd64-windows-tdep.c: Sort headers.
885         * amd64-windows-nat.c: Sort headers.
886         * amd64-tdep.c: Sort headers.
887         * amd64-sol2-tdep.c: Sort headers.
888         * amd64-obsd-tdep.c: Sort headers.
889         * amd64-obsd-nat.c: Sort headers.
890         * amd64-nbsd-tdep.c: Sort headers.
891         * amd64-nbsd-nat.c: Sort headers.
892         * amd64-nat.c: Sort headers.
893         * amd64-linux-tdep.c: Sort headers.
894         * amd64-linux-nat.c: Sort headers.
895         * amd64-fbsd-tdep.c: Sort headers.
896         * amd64-fbsd-nat.c: Sort headers.
897         * amd64-dicos-tdep.c: Sort headers.
898         * amd64-darwin-tdep.c: Sort headers.
899         * amd64-bsd-nat.c: Sort headers.
900         * alpha-tdep.c: Sort headers.
901         * alpha-obsd-tdep.c: Sort headers.
902         * alpha-nbsd-tdep.c: Sort headers.
903         * alpha-mdebug-tdep.c: Sort headers.
904         * alpha-linux-tdep.c: Sort headers.
905         * alpha-linux-nat.c: Sort headers.
906         * alpha-bsd-tdep.c: Sort headers.
907         * alpha-bsd-nat.c: Sort headers.
908         * aix-thread.c: Sort headers.
909         * agent.c: Sort headers.
910         * addrmap.c: Sort headers.
911         * ada-varobj.c: Sort headers.
912         * ada-valprint.c: Sort headers.
913         * ada-typeprint.c: Sort headers.
914         * ada-tasks.c: Sort headers.
915         * ada-lang.c: Sort headers.
916         * aarch64-tdep.c: Sort headers.
917         * aarch64-ravenscar-thread.c: Sort headers.
918         * aarch64-newlib-tdep.c: Sort headers.
919         * aarch64-linux-tdep.c: Sort headers.
920         * aarch64-linux-nat.c: Sort headers.
921         * aarch64-fbsd-tdep.c: Sort headers.
922         * aarch64-fbsd-nat.c: Sort headers.
923         * aarch32-linux-nat.c: Sort headers.
924
925 2019-04-04  Tom Tromey  <tom@tromey.com>
926
927         * varobj.c (varobj_create): Update.
928         * rust-exp.y (struct rust_parser) <update_innermost_block,
929         lookup_symbol>: New methods.
930         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
931         Rename.
932         (rust_parser::rust_lookup_type)
933         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
934         * printcmd.c (display_command, do_one_display): Update.
935         * parser-defs.h (struct parser_state) <parser_state>: Add
936         "tracker" parameter.
937         (block_tracker): New member.
938         (class innermost_block_tracker) <innermost_block_tracker>: Add
939         "types" parameter.
940         <reset>: Remove method.
941         (innermost_block): Don't declare.
942         (null_post_parser): Update.
943         * parse.c (innermost_block): Remove global.
944         (write_dollar_variable): Update.
945         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
946         Remove "tracker_types" parameter.
947         (parse_expression): Add "tracker" parameter.
948         (parse_expression_for_completion): Update.
949         (null_post_parser): Add "tracker" parameter.
950         * p-exp.y: Update rules.
951         * m2-exp.y: Update rules.
952         * language.h (struct language_defn) <la_post_parser>: Add
953         "tracker" parameter.
954         * go-exp.y: Update rules.
955         * f-exp.y: Update rules.
956         * expression.h (parse_expression, parse_exp_1): Add "tracker"
957         parameter.
958         * d-exp.y: Update rules.
959         * c-exp.y: Update rules.
960         * breakpoint.c (set_breakpoint_condition): Create an
961         innermost_block_tracker.
962         (watch_command_1): Likewise.
963         * ada-lang.c (resolve): Add "tracker" parameter.
964         (resolve_subexp): Likewise.
965         * ada-exp.y (write_var_from_sym): Update.
966
967 2019-04-04  Tom Tromey  <tom@tromey.com>
968
969         * type-stack.h: New file.
970         * type-stack.c: New file.
971         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
972         type-stack.h.
973         (insert_into_type_stack, insert_type, push_type, push_type_int)
974         (insert_type_address_space, pop_type, pop_type_int)
975         (pop_typelist, pop_type_stack, append_type_stack)
976         (push_type_stack, get_type_stack, push_typelist)
977         (follow_type_instance_flags, follow_types): Don't declare.
978         * parse.c (type_stack): Remove global.
979         (parse_exp_in_context): Update.
980         (insert_into_type_stack, insert_type, push_type, push_type_int)
981         (insert_type_address_space, pop_type, pop_type_int)
982         (pop_typelist, pop_type_stack, append_type_stack)
983         (push_type_stack, get_type_stack, push_typelist)
984         (follow_type_instance_flags, follow_types): Remove (moved to
985         type-stack.c).
986         * f-exp.y (type_stack): New global.
987         Update rules.
988         (push_kind_type, f_parse): Update.
989         * d-exp.y (type_stack): New global.
990         Update rules.
991         (d_parse): Update.
992         * c-exp.y (struct c_parse_state) <type_stack>: New member.
993         Update rules.
994         * Makefile.in (COMMON_SFILES): Add type-stack.c.
995         (HFILES_NO_SRCDIR): Add type-stack.h.
996
997 2019-04-04  Tom Tromey  <tom@tromey.com>
998
999         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1000         (rust_parser::convert_ast_to_expression, rust_parse)
1001         (rust_lex_test_completion, rust_lex_tests): Update.
1002         * parser-defs.h (struct expr_completion_state): New.
1003         (struct parser_state) <parser_state>: Add completion parameter.
1004         <mark_struct_expression, mark_completion_tag>: New methods.
1005         <parse_completion, m_completion_state>: New members.
1006         (prefixify_expression, null_post_parser): Update.
1007         (mark_struct_expression, mark_completion_tag): Don't declare.
1008         * parse.c (parse_completion, expout_last_struct)
1009         (expout_tag_completion_type, expout_completion_name): Remove
1010         globals.
1011         (parser_state::mark_struct_expression)
1012         (parser_state::mark_completion_tag): Now methods.
1013         (prefixify_expression): Add last_struct parameter.
1014         (prefixify_subexp): Likewise.
1015         (parse_exp_1): Update.
1016         (parse_exp_in_context): Add cstate parameter.  Update.
1017         (parse_expression_for_completion): Create an
1018         expr_completion_state.
1019         (null_post_parser): Add "completion" parameter.
1020         * p-exp.y: Update rules.
1021         (yylex): Update.
1022         * language.h (struct language_defn) <la_post_parser>: Add
1023         "completing" parameter.
1024         * go-exp.y: Update rules.
1025         (lex_one_token): Update.
1026         * expression.h (parse_completion): Don't declare.
1027         * d-exp.y: Update rules.
1028         (lex_one_token): Update rules.
1029         * c-exp.y: Update rules.
1030         (lex_one_token): Update.
1031         * ada-lang.c (resolve): Add "parse_completion" parameter.
1032         (resolve_subexp): Likewise.
1033         (ada_resolve_function): Likewise.
1034
1035 2019-04-04  Tom Tromey  <tom@tromey.com>
1036
1037         * parser-defs.h (struct parser_state) <start_arglist,
1038         end_arglist>: New methods.
1039         <arglist_len, m_funcall_chain>: New members.
1040         (arglist_len, start_arglist, end_arglist): Don't declare.
1041         * parse.c (arglist_len, funcall_chain): Remove global.
1042         (start_arglist, end_arglist): Remove functions.
1043         (parse_exp_in_context): Update.
1044         * p-exp.y: Update rules.
1045         * m2-exp.y: Update rules.
1046         * go-exp.y: Update rules.
1047         * f-exp.y: Update rules.
1048         * d-exp.y: Update rules.
1049         * c-exp.y: Update rules.
1050
1051 2019-04-04  Tom Tromey  <tom@tromey.com>
1052
1053         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1054         lex_operator, push_back>: New methods.
1055         Update all rules.
1056         (rust_parser::lex_hex, lex_escape): Rename and update.
1057         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1058         (rust_parser::lex_operator): Rename and update.
1059         (rust_parser::lex_number, rustyylex, rustyyerror)
1060         (rust_lex_test_init, rust_lex_test_sequence)
1061         (rust_lex_test_push_back, rust_lex_tests): Update.
1062         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1063         parameter.
1064         <lexptr, prev_lexptr>: New members.
1065         (lexptr, prev_lexptr): Don't declare.
1066         * parse.c (lexptr, prev_lexptr): Remove globals.
1067         (parse_exp_in_context): Update.
1068         * p-exp.y (yylex, yyerror): Update.
1069         * m2-exp.y (parse_number, yylex, yyerror): Update.
1070         * go-exp.y (lex_one_token, yyerror): Update.
1071         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1072         * d-exp.y (lex_one_token, yyerror): Update.
1073         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1074         (lex_one_token, yyerror): Update.
1075         * ada-lex.l (YY_INPUT): Update.
1076         (rewind_to_char): Update.
1077         * ada-exp.y (yyerror): Update.
1078
1079 2019-04-04  Tom Tromey  <tom@tromey.com>
1080
1081         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1082         * parser-defs.h (struct parser_state) <parser_state>: Add new
1083         parameter.
1084         <comma_terminates>: New member.
1085         (comma_terminates): Don't declare global.
1086         * parse.c (comma_terminates): Remove global.
1087         (parse_exp_in_context): Update.
1088         * p-exp.y (yylex): Update.
1089         * m2-exp.y (yylex): Update.
1090         * go-exp.y (lex_one_token): Update.
1091         * f-exp.y (yylex): Update.
1092         * d-exp.y (lex_one_token): Update.
1093         * c-exp.y (lex_one_token): Update.
1094         * ada-lex.l: Update.
1095
1096 2019-04-04  Tom Tromey  <tom@tromey.com>
1097
1098         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1099         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1100         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1101         * parser-defs.h (paren_depth): Don't declare.
1102         * parse.c (paren_depth): Remove global.
1103         (parse_exp_in_context): Update.
1104         * p-exp.y (paren_depth): New global.
1105         (pascal_parse): Initialize it.
1106         * m2-exp.y (paren_depth): New global.
1107         (m2_parse): Initialize it.
1108         * go-exp.y (paren_depth): New global.
1109         (go_parse): Initialize it.
1110         * f-exp.y (paren_depth): New global.
1111         (f_parse): Initialize it.
1112         * d-exp.y (paren_depth): New global.
1113         (d_parse): Initialize it.
1114         * c-exp.y (paren_depth): New global.
1115         (c_parse): Initialize it.
1116         * ada-lex.l (paren_depth): New global.
1117         (lexer_init): Initialize it.
1118
1119 2019-04-04  Tom Tromey  <tom@tromey.com>
1120
1121         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1122         (rust_parser::convert_ast_to_type)
1123         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1124         * parser-defs.h (struct parser_state) <parser_state>: Add
1125         parameters.  Initialize new members.
1126         <expression_context_block, expression_context_pc>: New members.
1127         * parse.c (expression_context_block, expression_context_pc):
1128         Remove globals.
1129         (parse_exp_in_context): Update.
1130         * p-exp.y: Update all rules.
1131         (yylex): Update.
1132         * m2-exp.y: Update all rules.
1133         (yylex): Update.
1134         * go-exp.y (yylex): Update.
1135         * f-exp.y (yylex): Update.
1136         * d-exp.y: Update all rules.
1137         (yylex): Update.
1138         * c-exp.y: Update all rules.
1139         (lex_one_token, classify_name, yylex, c_parse): Update.
1140         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1141
1142 2019-04-04  Tom Tromey  <tom@tromey.com>
1143
1144         * gdbarch.h, gdbarch.c: Rebuild.
1145         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1146         * stap-probe.h: 
1147         (struct stap_parse_info): Replace "parser_state" with
1148         "expr_builder".
1149         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1150         (parser_state): New class.
1151         * parse.c (expr_builder): Rename.
1152         (expr_builder::release): Rename.
1153         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1154         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1155         (write_exp_elt_longcst, write_exp_elt_floatcst)
1156         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1157         (write_exp_string_vector, write_exp_bitstring)
1158         (write_exp_msymbol, mark_struct_expression)
1159         (write_dollar_variable)
1160         (insert_type_address_space, increase_expout_size): Replace
1161         "parser_state" with "expr_builder".
1162         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1163         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1164         "parser_state" with "expr_builder".
1165
1166 2019-04-04  Tom Tromey  <tom@tromey.com>
1167
1168         * rust-exp.y: Replace "parse_language" with method call.
1169         * p-exp.y: 
1170         (yylex): Replace "parse_language" with method call.
1171         * m2-exp.y: 
1172         (yylex): Replace "parse_language" with method call.
1173         * go-exp.y (classify_name): Replace "parse_language" with method
1174         call.
1175         * f-exp.y (yylex): Replace "parse_language" with method call.
1176         * d-exp.y (lex_one_token): Replace "parse_language" with method
1177         call.
1178         * c-exp.y: 
1179         (lex_one_token, classify_name, yylex): Replace "parse_language"
1180         with method call.
1181         * ada-exp.y (find_primitive_type, type_char)
1182         (type_system_address): Replace "parse_language" with method call.
1183
1184 2019-04-04  Tom Tromey  <tom@tromey.com>
1185
1186         * rust-exp.y: Replace "parse_gdbarch" with method call.
1187         * parse.c (write_dollar_variable, insert_type_address_space):
1188         Replace "parse_gdbarch" with method call.
1189         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
1190         call.
1191         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
1192         call.
1193         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
1194         "parse_gdbarch" with method call.
1195         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
1196         with method call.
1197         * f-exp.y (parse_type, parse_f_type, yylex): Replace
1198         "parse_gdbarch" with method call.
1199         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
1200         "parse_gdbarch" with method call.
1201         * c-exp.y (parse_type, parse_number, classify_name): Replace
1202         "parse_gdbarch" with method call.
1203         * ada-lex.l: Replace "parse_gdbarch" with method call.
1204         * ada-exp.y (parse_type, find_primitive_type, type_char)
1205         (type_system_address): Replace "parse_gdbarch" with method call.
1206
1207 2019-04-04  Tom Tromey  <tom@tromey.com>
1208
1209         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
1210         * stap-probe.c (stap_parse_argument): Update.
1211         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
1212         initial_size parameter.
1213         * rust-exp.y (rust_lex_tests): Update.
1214         * parse.c (parser_state): Update.
1215         (parse_exp_in_context): Update.
1216         * parser-defs.h (struct parser_state) <parser_state>: Remove
1217         "initial_size" parameter.
1218
1219 2019-04-04  Tom Tromey  <tom@tromey.com>
1220
1221         * parser-defs.h (increase_expout_size): Don't declare.
1222         * parse.c (increase_expout_size): Now static.
1223
1224 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1225
1226         * gnu-nat.c (gnu_nat_target::wait): Fix
1227         target_waitstatus_to_string call.
1228
1229 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1230
1231         * eval.c (evaluate_subexp_standard): Handle internal functions
1232         during Fortran function call handling.
1233
1234 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1235
1236         * NEWS: Mention new internal functions.
1237         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1238         (read_base_type): Use dwarf2_init_complex_target_type.
1239         * value.c (creal_internal_fn): New function.
1240         (cimag_internal_fn): New function.
1241         (_initialize_values): Register new internal functions.
1242
1243 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1244
1245         * infrun.c (stop_all_threads): If debug_infrun, always
1246         trace the wait status after wait_one, using
1247         target_waitstatus_to_string and target_pid_to_str.
1248         (handle_inferior_event): Replace various trace of
1249         wait status kind by a single trace.
1250         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
1251         wait status kind image by target_waitstatus_to_string.
1252         * target/waitstatus.c (target_waitstatus_to_string): Fix
1253         obsolete comment.
1254
1255 2019-04-01  Tom Tromey  <tromey@adacore.com>
1256
1257         PR symtab/23331:
1258         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
1259
1260 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1261             Pedro Alves  <palves@redhat.com>
1262
1263         * top.c (quit_force): Call 'finalize_values'.
1264         * value.c (finalize_values): New function.
1265         * value.h (finalize_values): Declare.
1266
1267 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
1268
1269         * NEWS: Announce $_gdb_major and $_gdb_minor.
1270
1271         * top.c (init_gdb_version_vars): New function.
1272         (gdb_init): Call init_gdb_version_vars.
1273
1274 2019-03-29  Tom Tromey  <tromey@adacore.com>
1275
1276         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
1277         help text.  Remove dead code.
1278
1279 2019-03-29  Keith Seitz  <keiths@redhat.com>
1280
1281         From Siddhesh Poyarekar:
1282         * f-lang.h (f77_get_upperbound): Return LONGEST.
1283         (f77_get_lowerbound): Likewise.
1284         * f-typeprint.c (f_type_print_varspec_suffix): Expand
1285         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
1286         print them.
1287         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
1288         plongest to format print it.
1289         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
1290         (f77_get_upperbound): Likewise.
1291         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
1292         LOWER_BOUND to LONGEST.
1293         (f77_create_arrayprint_offset_tbl): Likewise.
1294
1295 2019-03-29  Keith Seitz  <keiths@redhat.com>
1296
1297         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
1298         %s/pulongest for TYPE_LENGTH instead of %d in format
1299         strings.
1300         * ada-typerint.c (ada_print_type): Likewise.
1301         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
1302         * compile/compile-c-support.c (generate_register_struct): Likewise.
1303         * gdbtypes.c (recursive_dump_type): Likewise.
1304         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
1305         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
1306         instead of %d in format strings.
1307         * riscv-tdep.c (riscv_type_alignment): Cast second argument
1308         to std::min to ULONGEST.
1309         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
1310         instead of %d in format strings.
1311         * tracepoint.c (info_scope_command): Likewise.
1312         * typeprint.c (print_offset_data::update)
1313         (print_offset_data::finish): Likewise.
1314         * xtensa-tdep.c (xtensa_store_return_value)
1315         (xtensa_push_dummy_call): Likewise.
1316
1317 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
1318
1319         * windows-nat.c (display_selector): Fixed format specifications
1320         for 64-bit Cygwin.
1321
1322 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1323
1324         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
1325
1326 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
1327
1328         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
1329         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
1330         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
1331         (nios2_linux_init_abi): Install it.
1332
1333 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1334
1335         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
1336
1337 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1338
1339         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
1340
1341 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1342             Tom Tromey  <tromey@adacore.com>
1343
1344         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
1345
1346 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
1347
1348         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
1349         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
1350         method to compute the bounds of range types. Also print "[evaluated]"
1351         if the bounds' values come from a dynamic evaluation.
1352
1353 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1354
1355         * cp-valprint.c (cp_print_value_fields): Don't print trailing
1356         whitespace when pretty printing is on.
1357
1358 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1359
1360         * ppc-linux-nat.c: Add include.
1361
1362 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1363
1364         * NEWS: Mention AArch64 Pointer Authentication.
1365
1366 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1367
1368         * arm-linux-nat.c: Add include.
1369
1370 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
1371
1372         * source-cache.c (source_cache::get_source_lines): Re-read
1373         fullname after calling open_source_file.
1374
1375 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
1376
1377         * NEWS: Mention TLS support for FreeBSD.
1378
1379 2019-03-25  Tom Tromey  <tromey@adacore.com>
1380
1381         * minsyms.c (BUNCH_SIZE): Update comment.
1382         (~minimal_symbol_reader): Remove old comment.
1383         (compact_minimal_symbols): Update comment.
1384         (minimal_symbol_reader::install): Remove old comment.  Update
1385         other comments.
1386
1387 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1388
1389         * s390-linux-nat.c: Add include.
1390
1391 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1392
1393         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1394         Call linux_get_hwcap.
1395         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
1396         Likewise.
1397         (aarch64_linux_get_hwcap): Remove function.
1398         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
1399         declaration.
1400         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
1401         linux_get_hwcap.
1402         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1403         * linux-tdep.c (linux_get_hwcap): Add function.
1404         (linux_get_hwcap2): Likewise.
1405         * linux-tdep.h (linux_get_hwcap): Add declaration.
1406         (linux_get_hwcap2): Likewise.
1407         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
1408         (ppc_linux_get_hwcap2): Likewise.
1409         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
1410         linux_get_hwcap.
1411         (ppc_linux_nat_target::insert_watchpoint): Likewise.
1412         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
1413         (ppc_linux_nat_target::read_description): Likewise.
1414         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
1415         * s390-linux-nat.c: Likewise.
1416         * s390-linux-tdep.c (s390_core_read_description): Likewise.
1417
1418 2019-03-24  Tom Tromey  <tom@tromey.com>
1419
1420         * ada-lang.c (standard_lookup): Simplify initialization.
1421         (ada_lookup_symbol_nonlocal): Simplify return.
1422         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
1423         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
1424         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
1425         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
1426         initialization.
1427         * solib.c (solib_global_lookup): Simplify.
1428         * symtab.c (null_block_symbol): Remove.
1429         (symbol_cache_lookup): Simplify returns.
1430         (lookup_language_this): Simplify returns.
1431         (lookup_symbol_aux): Simplify return.
1432         (lookup_local_symbol): Simplify returns.
1433         (lookup_global_symbol_from_objfile): Simplify return.
1434         (lookup_symbol_in_objfile_symtabs)
1435         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
1436         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
1437         (lookup_static_symbol, lookup_global_symbol): Simplify return.
1438         * cp-namespace.c (cp_lookup_bare_symbol)
1439         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
1440         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
1441         (cp_lookup_nested_symbol): Don't use null_block_symbol.
1442         (cp_lookup_symbol_via_imports): Simplify initialization.
1443         (find_symbol_in_baseclass): Likewise.
1444         * symtab.h (null_block_symbol): Remove.
1445         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
1446         (d_lookup_nested_symbol, d_lookup_symbol_imports)
1447         (d_lookup_symbol_module): Likewise.
1448         (find_symbol_in_baseclass): Simplify initialization.
1449
1450 2019-03-24  Tom Tromey  <tom@tromey.com>
1451
1452         * expression.h: Don't include symtab.h.
1453         (struct block): Forward declare.
1454
1455 2019-03-24  Tom Tromey  <tom@tromey.com>
1456
1457         * c-exp.y (typebase): Remove casts.
1458         * gdbtypes.c (lookup_unsigned_typename, )
1459         (lookup_signed_typename): Remove cast.
1460         * eval.c (parse_to_comma_and_eval): Remove cast.
1461         * parse.c (write_dollar_variable): Remove cast.
1462         * block.h (struct block) <superblock>: Now const.
1463         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
1464         * psymtab.c (psym_map_matching_symbols): Make "block" const.
1465         (map_block): Make "block" const.
1466         * symfile.h (struct quick_symbol_functions)
1467         <map_matching_symbols>: Constify block argument to "callback".
1468         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
1469         const.
1470         (find_pc_sect_compunit_symtab): Make "b" const.
1471         (find_symbol_at_address): Likewise.
1472         (search_symbols): Likewise.
1473         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
1474         (dw2_debug_names_lookup_symbol): Likewise.
1475         (dw2_map_matching_symbols): Update.
1476         * p-valprint.c (pascal_val_print): Remove "block".
1477         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
1478         (aux_add_nonlocal_symbols): Make "block" const.
1479         (resolve_subexp): Remove cast.
1480         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
1481         const.
1482         (iterate_over_file_blocks): Likewise.
1483         * f-exp.y (%union) <bval>: Remove.
1484         * coffread.c (patch_opaque_types): Make "b" const.
1485         * spu-tdep.c (spu_catch_start): Make "block" const.
1486         * c-valprint.c (print_unpacked_pointer): Remove "block".
1487         * symmisc.c (dump_symtab_1): Make "b" const.
1488         (block_depth): Make "block" const.
1489         * d-exp.y (%union) <bval>: Remove.
1490         * cp-support.h (cp_lookup_rtti_type): Update.
1491         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
1492         * psymtab.c (psym_lookup_symbol): Make "block" const.
1493         (maintenance_check_psymtabs): Make "b" const.
1494         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
1495         (enumerate_locals, enumerate_args): Update.
1496         * python/py-symtab.c (stpy_global_block): Make "block" const.
1497         (stpy_static_block): Likewise.
1498         * inline-frame.c (block_starting_point_at): Make "new_block"
1499         const.
1500         * block.c (find_block_in_blockvector): Make return type const.
1501         (blockvector_for_pc_sect): Make "b" const.
1502         (find_block_in_blockvector): Make "b" const.
1503
1504 2019-03-23  Tom Tromey  <tom@tromey.com>
1505
1506         * varobj.c (varobj_create): Update.
1507         * symfile.c (clear_symtab_users): Don't reset innermost_block.
1508         * printcmd.c (display_command, do_one_display): Don't reset
1509         innermost_block.
1510         * parser-defs.h (enum innermost_block_tracker_type): Move to
1511         expression.h.
1512         (innermost_block): Update comment.
1513         * parse.c (parse_exp_1): Add tracker_types parameter.
1514         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
1515         tracker_types parameter.  Reset innermost_block.
1516         (parse_exp_in_context): Remove.
1517         (parse_expression_for_completion): Update.
1518         * objfiles.c (~objfile): Don't reset expression_context_block or
1519         innermost_block.
1520         * expression.h (enum innermost_block_tracker_type): Move from
1521         parser-defs.h.
1522         (parse_exp_1): Add tracker_types parameter.
1523         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
1524         reset innermost_block.
1525
1526 2019-03-23  Tom Tromey  <tom@tromey.com>
1527
1528         * objfiles.h: Include bcache.h.
1529
1530 2019-03-23  Tom Tromey  <tom@tromey.com>
1531
1532         * linespec.c (get_current_search_block): Use
1533         scoped_restore_current_language.
1534         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
1535
1536 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1537             Jiong Wang  <jiong.wang@arm.com>
1538
1539         * aarch64-linux-tdep.c
1540         (aarch64_linux_iterate_over_regset_sections): Check for pauth
1541         section.
1542         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
1543
1544 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1545             Jiong Wang  <jiong.wang@arm.com>
1546
1547         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
1548         instructions.
1549         (aarch64_analyze_prologue_test): Add PACIASP test.
1550         (aarch64_prologue_prev_register): Unmask PC value.
1551
1552 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1553             Jiong Wang  <jiong.wang@arm.com>
1554
1555         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
1556         (aarch64_dwarf2_prev_register): Unmask PC value.
1557         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
1558         (aarch64_execute_dwarf_cfa_vendor_op): Check for
1559         DW_CFA_AARCH64_negate_ra_state.
1560         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
1561
1562 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1563             Jiong Wang  <jiong.wang@arm.com>
1564
1565         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
1566         registers.
1567         (aarch64_pseudo_register_name): Likewise.
1568         (aarch64_pseudo_register_type): Likewise.
1569         (aarch64_pseudo_register_reggroup_p): Likewise.
1570         (aarch64_gdbarch_init): Add pauth registers.
1571         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
1572         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
1573         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
1574         (struct gdbarch_tdep): Add regnum for ra_state.
1575
1576 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1577             Jiong Wang  <jiong.wang@arm.com>
1578
1579         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
1580
1581 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1582             Jiong Wang  <jiong.wang@arm.com>
1583
1584         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
1585         function.
1586         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
1587         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
1588         (aarch64_gdbarch_init): Add puth registers.
1589         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
1590         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
1591         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
1592
1593 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1594             Jiong Wang  <jiong.wang@arm.com>
1595
1596         * aarch64-linux-nat.c
1597         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
1598         * aarch64-linux-tdep.c
1599         (aarch64_linux_core_read_description): Likewise.
1600         (aarch64_linux_get_hwcap): New function.
1601         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
1602         (aarch64_linux_get_hwcap): New declaration.
1603
1604 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1605             Jiong Wang  <jiong.wang@arm.com>
1606
1607         * aarch64-linux-nat.c
1608         (aarch64_linux_nat_target::read_description): Add pauth param.
1609         * aarch64-linux-tdep.c
1610         (aarch64_linux_core_read_description): Likewise.
1611         * aarch64-tdep.c (struct target_desc): Add in pauth.
1612         (aarch64_read_description): Add pauth param.
1613         (aarch64_gdbarch_init): Likewise.
1614         * aarch64-tdep.h (aarch64_read_description): Likewise.
1615         * arch/aarch64.c (aarch64_create_target_description): Likewise.
1616         * arch/aarch64.h (aarch64_create_target_description): Likewise.
1617         * features/Makefile: Add new files.
1618         * features/aarch64-pauth.c: New file.
1619         * features/aarch64-pauth.xml: New file.
1620
1621 2019-03-20  Tom Tromey  <tromey@adacore.com>
1622
1623         * infrun.c (handle_inferior_event): Rename from
1624         handle_inferior_event_1.  Create a scoped_value_mark.
1625         (handle_inferior_event): Remove.
1626
1627 2019-03-19  Tom Tromey  <tromey@adacore.com>
1628
1629         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
1630         * infrun.h (print_stop_event): Add "displays" parameter.
1631         * infrun.c (print_stop_event): Add "displays" parameter.
1632
1633 2019-03-19  Pedro Alves  <palves@redhat.com>
1634
1635         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
1636         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
1637         to -1.  Fix TABs vs spaces.
1638         (tui_ui_out::tui_ui_out): Don't initialize fields here.
1639         * tui/tui-out.h (tui_ui_out) Add intro comments.
1640         <m_line, m_start_of_line>: In-class initialize, and add describing
1641         comment.
1642
1643 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
1644
1645         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
1646         variable names.
1647         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
1648
1649 2019-03-18  Pedro Alves  <palves@redhat.com>
1650             Eli Zaretskii <eliz@gnu.org>
1651
1652         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
1653         m_line and m_start_of_line.
1654
1655 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
1656
1657         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
1658         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
1659         it returns a newline.  This fixes a regression in TU mode, whereby
1660         the next line is output on the same screen line as the user input.
1661
1662 2019-03-18  Tom Tromey  <tromey@adacore.com>
1663
1664         * minsyms.c (minimal_symbol_reader::install): Remove call to
1665         obstack_blank.
1666
1667 2019-03-18  Pedro Alves  <palves@redhat.com>
1668
1669         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
1670         New globals.
1671         (apply_style): New, factored out from ...
1672         (apply_ansi_escape): ... this.  Handle reverse video mode.
1673         (tui_set_reverse_mode): New function.
1674         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
1675         * tui/tui-winsource.c (tui_show_source_line): Use
1676         tui_set_reverse_mode instead of setting A_STANDOUT.
1677         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
1678         New setter methods.
1679
1680 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
1681
1682         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
1683         Handle tabs.
1684
1685 2019-03-18  Tom Tromey  <tromey@adacore.com>
1686
1687         * ada-lang.c (empty_array): Add "high" parameter.
1688         (ada_evaluate_subexp): Update.
1689
1690 2019-03-17  Sergei Trofimovich <siarheit@google.com>
1691
1692         * unittests/string_view-selftests.c: Define
1693         _initialize_string_view_selftests unconditionally.
1694
1695 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1696
1697         PR gdb/24350
1698         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
1699
1700 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1701
1702         PR gdb/24351
1703         * windows-nat.c (display_selector): Fix format specifiers.
1704
1705 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
1706
1707         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
1708         tui_refill_source_window instead of tui_refresh_win, to update the
1709         current execution line.  This fixes redisplay of the current line
1710         when stepping through the code with "next" or "step".
1711
1712 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1713
1714         * source-cache.c (source_cache::get_source_lines): Call
1715         find_source_lines to initialize s->nlines.  This fixes vertical
1716         scrolling of TUI source window when the DOWN arrow is pressed.
1717
1718 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1719
1720         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
1721         linux-thread-db.c (_initialize_thread_db): Likewise.
1722
1723 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1724
1725         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
1726         wclrtoeol in tui_show_source_line".  This reverts changes made in
1727         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
1728
1729 2019-03-15  Tom Tromey  <tom@tromey.com>
1730
1731         * symtab.h (struct minimal_symbol): Derive from
1732         general_symbol_info.
1733         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
1734         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
1735         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
1736         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
1737         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
1738         (MSYMBOL_SEARCH_NAME): Update.
1739         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
1740         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
1741         * minsyms.c (minimal_symbol_reader::record_full): Update.
1742
1743 2019-03-15  Tom Tromey  <tom@tromey.com>
1744
1745         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
1746
1747 2019-03-15  Tom Tromey  <tom@tromey.com>
1748
1749         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
1750         unique_xmalloc_ptr.
1751         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
1752         Update.
1753         * minsyms.c (lookup_minimal_symbol_by_pc_section)
1754         (build_minimal_symbol_hash_tables)
1755         (minimal_symbol_reader::install): Update.
1756
1757 2019-03-15  Tom Tromey  <tom@tromey.com>
1758
1759         * symtab.c (create_demangled_names_hash): Update.
1760         (symbol_set_names): Update.
1761         * objfiles.h (struct objfile_per_bfd_storage)
1762         <demangled_names_hash>: Now an htab_up.
1763         * objfiles.c (objfile_per_bfd_storage): Simplify.
1764
1765 2019-03-15  Tom Tromey  <tom@tromey.com>
1766
1767         * objfiles.h (struct objfile_per_bfd_storage): Declare
1768         destructor.
1769         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
1770         New.
1771         (get_objfile_bfd_data): Use new.  Don't initialize
1772         language_of_main.
1773         (free_objfile_per_bfd_storage): Remove.
1774         (objfile_bfd_data_free, objfile::~objfile): Use delete.
1775
1776 2019-03-15  Tom Tromey  <tom@tromey.com>
1777
1778         * symfile.c (reread_symbols): Update.
1779         * objfiles.c (objfile::objfile): Update.
1780         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
1781         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
1782         comment.
1783         (minimal_symbol_reader::install): Update.
1784         (terminate_minimal_symbol_table): Remove.
1785         * jit.c (jit_object_close_impl): Update.
1786
1787 2019-03-15  Tom Tromey  <tom@tromey.com>
1788
1789         * minsyms.c (minimal_symbol_reader::record_full): Remove some
1790         initializations.
1791
1792 2019-03-15  Tom Tromey  <tom@tromey.com>
1793
1794         * objfiles.h (struct objfile_per_bfd_storage)
1795         <demangled_hash_languages>: Now a bitset.
1796         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
1797         (lookup_minimal_symbol): Update.
1798
1799 2019-03-15  Tom Tromey  <tom@tromey.com>
1800
1801         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
1802         Don't return the symbol.
1803         * coffread.c (record_minimal_symbol): Use record_full.
1804
1805 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
1806
1807         The MS-Windows port of ncurses fails to switch to a color pair if
1808         one or both of the colors are the implicit default colors.  This
1809         change records the default colors when TUI is initialized, and
1810         then specifies them explicitly when a color pair uses the default
1811         colors.  This allows color styling in TUI mode on MS-Windows.
1812
1813         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
1814         ncurses_norm_attr.
1815         (tui_initialize_io) [__MINGW32__]: Record the default terminal
1816         colors in ncurses_norm_attr.
1817         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
1818         "none", replace it with the default color recorded in
1819         ncurses_norm_attr.
1820
1821 2019-03-14  Tom Tromey  <tromey@adacore.com>
1822
1823         * source-cache.h (class source_cache) <get_source_lines>: Return
1824         std::string.
1825         * source-cache.c (source_cache::extract_lines): Handle case where
1826         first_pos==npos.  Return std::string.
1827         (source_cache::get_source_lines): Update.
1828
1829 2019-03-14  Tom Tromey  <tromey@adacore.com>
1830
1831         * NEWS: Add item for "style sources" commands.
1832         * source-cache.c (source_cache::get_source_lines): Check
1833         source_styling.
1834         * cli/cli-style.c (source_styling): New global.
1835         (_initialize_cli_style): Add "style sources" commands.
1836         (show_style_sources): New function.
1837         * cli/cli-style.h (source_styling): Declare.
1838
1839 2019-03-14  Pedro Alves  <palves@redhat.com>
1840             Tom Tromey  <tromey@adacore.com>
1841
1842         * tui/tui-winsource.h (tui_refill_source_window): Declare.
1843         * tui/tui-winsource.c (tui_refill_source_window): New function,
1844         from...
1845         (tui_horizontal_source_scroll): ... here.  Move some logic.
1846         * cli/cli-style.c (set_style_enabled): Notify new observable.
1847         * tui/tui-hooks.c (tui_redisplay_source): New function.
1848         (tui_attach_detach_observers): Attach or detach
1849         tui_redisplay_source.
1850         * observable.h (source_styling_changed): New observable.
1851         * observable.c: Define source_styling_changed observable.
1852
1853 2019-03-13  Tom Tromey  <tromey@adacore.com>
1854
1855         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
1856         (i386_gnu_nat_target::store_registers): Update.
1857         * target-debug.h (target_debug_print_std_string): New macro.
1858         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1859         * windows-tdep.c (display_one_tib): Update.
1860         * tui/tui-stack.c (tui_make_status_line): Update.
1861         * top.c (print_inferior_quit_action): Update.
1862         * thread.c (thr_try_catch_cmd): Update.
1863         (add_thread_with_info): Update.
1864         (thread_target_id_str): Update.
1865         (thr_try_catch_cmd): Update.
1866         (thread_command): Update.
1867         (thread_find_command): Update.
1868         * record-btrace.c (record_btrace_target::info_record)
1869         (record_btrace_resume_thread, record_btrace_target::resume)
1870         (record_btrace_cancel_resume, record_btrace_step_thread)
1871         (record_btrace_target::wait, record_btrace_target::wait)
1872         (record_btrace_target::wait, record_btrace_target::stop): Update.
1873         * progspace.c (print_program_space): Update.
1874         * process-stratum-target.c
1875         (process_stratum_target::thread_address_space): Update.
1876         * linux-fork.c (linux_fork_mourn_inferior)
1877         (detach_checkpoint_command, info_checkpoints_command)
1878         (linux_fork_context): Update.
1879         (linux_fork_detach): Update.
1880         (class scoped_switch_fork_info): Update.
1881         (delete_checkpoint_command): Update.
1882         * infrun.c (follow_fork_inferior): Update.
1883         (follow_fork_inferior): Update.
1884         (proceed_after_vfork_done): Update.
1885         (handle_vfork_child_exec_or_exit): Update.
1886         (follow_exec): Update.
1887         (displaced_step_prepare_throw): Update.
1888         (displaced_step_restore): Update.
1889         (start_step_over): Update.
1890         (resume_1): Update.
1891         (clear_proceed_status_thread): Update.
1892         (proceed): Update.
1893         (print_target_wait_results): Update.
1894         (do_target_wait): Update.
1895         (context_switch): Update.
1896         (stop_all_threads): Update.
1897         (restart_threads): Update.
1898         (finish_step_over): Update.
1899         (handle_signal_stop): Update.
1900         (switch_back_to_stepped_thread): Update.
1901         (keep_going_pass_signal): Update.
1902         (print_exited_reason): Update.
1903         (normal_stop): Update.
1904         * inferior.c (inferior_pid_to_str): Change return type.
1905         (print_selected_inferior): Update.
1906         (add_inferior): Update.
1907         (detach_inferior): Update.
1908         * dummy-frame.c (fprint_dummy_frames): Update.
1909         * dcache.c (dcache_info_1): Update.
1910         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
1911         (btrace_fetch, btrace_clear): Update.
1912         * linux-tdep.c (linux_core_pid_to_str): Change return type.
1913         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
1914         type.
1915         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
1916         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
1917         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
1918         * gdbarch.c, gdbarch.h: Rebuild.
1919         * gdbarch.sh (core_pid_to_str): Change return type.
1920         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
1921         return type.
1922         (windows_nat_target::pid_to_str): Change return type.
1923         (windows_delete_thread): Update.
1924         (windows_nat_target::attach): Update.
1925         (windows_nat_target::files_info): Update.
1926         * target-delegates.c: Rebuild.
1927         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
1928         return type.
1929         (sol_thread_target::pid_to_str): Change return type.
1930         * remote.c (class remote_target) <pid_to_str>: Change return
1931         type.
1932         (remote_target::pid_to_str): Change return type.
1933         (extended_remote_target::attach, remote_target::remote_stop_ns)
1934         (remote_target::remote_notif_remove_queued_reply)
1935         (remote_target::push_stop_reply, remote_target::disable_btrace):
1936         Update.
1937         (extended_remote_target::attach): Update.
1938         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
1939         type.
1940         (gdbsim_target::pid_to_str): Change return type.
1941         * ravenscar-thread.c (struct ravenscar_thread_target)
1942         <pid_to_str>: Change return type.
1943         (ravenscar_thread_target::pid_to_str): Change return type.
1944         * procfs.c (class procfs_target) <pid_to_str>: Change return
1945         type.
1946         (procfs_target::pid_to_str): Change return type.
1947         (procfs_target::attach): Update.
1948         (procfs_target::detach): Update.
1949         (procfs_target::fetch_registers): Update.
1950         (procfs_target::store_registers): Update.
1951         (procfs_target::wait): Update.
1952         (procfs_target::files_info): Update.
1953         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
1954         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
1955         return type.
1956         (nto_procfs_target::pid_to_str): Change return type.
1957         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
1958         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
1959         return type.
1960         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
1961         (exit_lwp): Update.
1962         (attach_proc_task_lwp_callback, get_detach_signal)
1963         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
1964         (linux_nat_target::resume, wait_lwp, stop_callback)
1965         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
1966         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
1967         (linux_nat_wait_1, resume_stopped_resumed_lwps)
1968         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
1969         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
1970         type.
1971         (inf_ptrace_target::attach): Update.
1972         (inf_ptrace_target::files_info): Update.
1973         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
1974         type.
1975         (go32_nat_target::pid_to_str): Change return type.
1976         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
1977         (gnu_nat_target::wait): Update.
1978         (gnu_nat_target::wait): Update.
1979         (gnu_nat_target::resume): Update.
1980         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
1981         (fbsd_nat_target::wait): Update.
1982         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
1983         type.
1984         (darwin_nat_target::attach): Update.
1985         * corelow.c (class core_target) <pid_to_str>: Change return type.
1986         (core_target::pid_to_str): Change return type.
1987         * target.c (normal_pid_to_str): Change return type.
1988         (default_pid_to_str): Likewise.
1989         (target_pid_to_str): Change return type.
1990         (target_translate_tls_address): Update.
1991         (target_announce_detach): Update.
1992         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
1993         return type.
1994         (bsd_uthread_target::pid_to_str): Change return type.
1995         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
1996         type.
1997         (bsd_kvm_target::pid_to_str): Change return type.
1998         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
1999         return type.
2000         (aix_thread_target::pid_to_str): Change return type.
2001         * target.h (struct target_ops) <pid_to_str>: Change return type.
2002         (target_pid_to_str, normal_pid_to_str): Likewise.
2003         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2004         type.
2005         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2006         type.
2007         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2008         return type.
2009         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2010         type.
2011         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2012         type.
2013         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2014         return type.
2015
2016 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2017
2018         * NEWS: Mention that the new default MI version is 3.  Mention
2019         changes to the output of commands and events that deal with
2020         multi-location breakpoints.
2021         * breakpoint.c: Include "mi/mi-out.h".
2022         (print_one_breakpoint): Change output syntax if using MI version
2023         >= 3.
2024         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2025         New.
2026         (mi_multi_location_breakpoint_output_fixed): New.
2027         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2028         (mi_cmd_fix_multi_location_breakpoint_output): New.
2029         (mi_multi_location_breakpoint_output_fixed): New.
2030         * mi/mi-cmds.c (mi_cmds): Register command
2031         -fix-multi-location-breakpoint-output.
2032         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2033         interpreter "mi".
2034
2035 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2036
2037         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2038         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2039         instantiate mi_ui_out based on interpreter name.
2040         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2041         * mi/mi-main.c (mi_load_progress): Likewise.
2042
2043 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2044
2045         * NEWS: Combine separate "New targets" sections for 8.3.
2046
2047 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2048
2049         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2050         (ppcfbsd_init_abi): Install gdbarch
2051         "fetch_tls_load_module_address" and "get_thread_local_address"
2052         methods.
2053
2054 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2055
2056         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2057         (riscv_fbsd_init_abi): Install gdbarch
2058         "fetch_tls_load_module_address" and "get_thread_local_address"
2059         methods.
2060
2061 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2062
2063         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2064         (i386fbsd_init_abi): Install gdbarch
2065         "fetch_tls_load_module_address" and "get_thread_local_address"
2066         methods.
2067
2068 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2069
2070         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2071         (amd64fbsd_init_abi): Install gdbarch
2072         "fetch_tls_load_module_address" and "get_thread_local_address"
2073         methods.
2074
2075 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2076
2077         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2078         (struct fbsd_pspace_data): New type.
2079         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2080         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2081         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2082         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2083         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2084
2085 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2086
2087         * gdbtypes.c (lookup_struct_elt): New function.
2088         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2089         * gdbtypes.h (struct struct_elt): New type.
2090         (lookup_struct_elt): New prototype.
2091
2092 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2093
2094         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2095         remove disabled code block.
2096
2097 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2098
2099         * gdbarch.sh (get_thread_local_address): New method.
2100         * gdbarch.h, gdbarch.c: Regenerate.
2101         * target.c (target_translate_tls_address): Use
2102         gdbarch_get_thread_local_address if present instead of
2103         target::get_thread_local_address.
2104
2105 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2106
2107         * target.h (target::get_thread_local_address): Update comment.
2108
2109 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2110
2111         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2112         objfile->separate_debug_objfile_backlink if not NULL.
2113
2114 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2115
2116         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2117         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2118         (amd64bsd_store_inferior_registers): Likewise.
2119         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2120         Enable segment base registers.
2121         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2122         PT_GETFSBASE and PT_GETGSBASE.
2123         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2124         PT_SETGSBASE.
2125         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2126         segment base registers.
2127         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2128
2129 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2130
2131         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2132         Update calls to i386_target_description to add 'segments'
2133         parameter.
2134         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2135         add segment base registers.
2136         * arch/i386.c (i386_create_target_description): Add 'segments'
2137         parameter to enable segment base registers.
2138         * arch/i386.h (i386_create_target_description): Likewise.
2139         * features/i386/32bit-segments.xml: New file.
2140         * features/i386/32bit-segments.c: Generate.
2141         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2142         call to i386_target_description to add 'segments' parameter.
2143         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2144         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2145         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2146         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2147         if feature is present.
2148         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2149         Add 'segments' parameter to call to i386_target_description.
2150         (i386_target_description): Add 'segments' parameter to enable
2151         segment base registers.
2152         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2153         to call to i386_target_description.
2154         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2155         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2156         Define I386_NUM_REGS.
2157         (i386_target_description): Add 'segments' parameter to enable
2158         segment base registers.
2159
2160 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2161
2162         PR/24325
2163         * source-cache.c: #undef open and close, to avoid unresolved
2164         externals during linking.
2165
2166 2019-03-12  Tom Tromey  <tromey@adacore.com>
2167
2168         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2169         const.  Add initializers.
2170         (_initialize_remote): Don't initialize ptid globals.
2171
2172 2019-03-12  Pedro Alves  <palves@redhat.com>
2173
2174         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
2175
2176 2019-03-12  Pedro Alves  <palves@redhat.com>
2177
2178         * cp-name-parser.y (main): Remove unused 'len' variable.
2179
2180 2019-03-12  Tom Tromey  <tromey@adacore.com>
2181
2182         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
2183         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
2184
2185 2019-03-12  Tom Tromey  <tromey@adacore.com>
2186
2187         * linux-nat.c (iterate_over_lwps): Update.
2188         (stop_callback): Remove parameter.
2189         (stop_wait_callback, detach_callback, resume_set_callback)
2190         (select_singlestep_lwp_callback, set_ignore_sigint)
2191         (status_callback, resumed_callback, resume_clear_callback)
2192         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
2193         data parameter.
2194         (linux_nat_target::detach, linux_nat_target::resume)
2195         (linux_stop_and_wait_all_lwps, select_event_lwp)
2196         (linux_nat_filter_event, linux_nat_wait_1)
2197         (linux_nat_target::kill, linux_nat_target::stop)
2198         (linux_nat_target::stop): Update.
2199         (linux_nat_resume_callback): Change type.
2200         (resume_stopped_resumed_lwps, count_events_callback)
2201         (select_event_lwp_callback): Likewise.
2202         (linux_stop_lwp, linux_nat_stop_lwp): Update.
2203         * arm-linux-nat.c (struct update_registers_data): Remove.
2204         (update_registers_callback): Change type.
2205         (arm_linux_insert_hw_breakpoint1): Update.
2206         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
2207         parameter.
2208         (x86_linux_dr_set_addr): Update.
2209         (x86_linux_dr_set_control): Update.
2210         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
2211         (iterate_over_lwps): Use gdb::function_view.
2212         * nat/aarch64-linux-hw-point.c (struct
2213         aarch64_dr_update_callback_param): Remove.
2214         (debug_reg_change_callback): Change type.
2215         (aarch64_notify_debug_reg_change): Update.
2216         * s390-linux-nat.c (s390_refresh_per_info): Update.
2217
2218 2019-03-11  Tom Tromey  <tromey@adacore.com>
2219
2220         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2221         redundant assignment to "this_cu".
2222
2223 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2224
2225         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2226
2227 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2228
2229         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2230         from...
2231         (rank_one_type): ... this.
2232
2233 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2234
2235         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2236         from...
2237         (rank_one_type): ... this.
2238
2239 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2240
2241         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
2242         from...
2243         (rank_one_type): ... this.
2244
2245 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2246
2247         * gdbtypes.c (rank_one_type_parm_float): New function extracted
2248         from...
2249         (rank_one_type): ... this.
2250
2251 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2252
2253         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
2254         from...
2255         (rank_one_type): ... this.
2256
2257 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2258
2259         * gdbtypes.c (rank_one_type_parm_range): New function extracted
2260         from...
2261         (rank_one_type): ... this.
2262
2263 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2264
2265         * gdbtypes.c (rank_one_type_parm_char): New function extracted
2266         from...
2267         (rank_one_type): ... this.
2268
2269 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2270
2271         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
2272         from...
2273         (rank_one_type): ... this.
2274
2275 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2276
2277         * gdbtypes.c (rank_one_type_parm_int): New function extracted
2278         from...
2279         (rank_one_type): ... this.
2280
2281 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2282
2283         * gdbtypes.c (rank_one_type_parm_func): New function extracted
2284         from...
2285         (rank_one_type): ... this.
2286
2287 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2288
2289         * gdbtypes.c (rank_one_type_parm_array): New function extracted
2290         from...
2291         (rank_one_type): ... this.
2292
2293 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2294
2295         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
2296         from...
2297         (rank_one_type): ... this.
2298
2299 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2300
2301         * inferior.c (initialize_inferiors): Ensure 'help set/show print
2302         inferior-events' shows the example events.
2303
2304 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
2305
2306         Support styling on native MS-Windows console
2307
2308         PR/24315
2309         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
2310         on MS-Windows if $TERM is not defined.
2311
2312         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
2313
2314         * posix-hdep.c (gdb_console_fputs):
2315         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
2316         functions.
2317         * ui-file.h (gdb_console_fputs): Add prototype.
2318
2319         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
2320         back to fputs only if the former returns zero.
2321
2322 2019-03-07  Tom Tromey  <tom@tromey.com>
2323
2324         * symmisc.c (print_symbol_bcache_statistics): Update.
2325         (print_objfile_statistics): Update.
2326         * symfile.c (allocate_symtab): Update.
2327         * stabsread.c: Don't include bcache.h.
2328         * psymtab.h (struct psymbol_bcache): Don't declare.
2329         (class psymtab_storage) <psymbol_cache>: Now a bcache.
2330         (psymbol_bcache_init, psymbol_bcache_free)
2331         (psymbol_bcache_get_bcache): Don't declare.
2332         * psymtab.c (struct psymbol_bcache): Remove.
2333         (psymtab_storage::psymtab_storage): Update.
2334         (psymtab_storage::~psymtab_storage): Update.
2335         (psymbol_bcache_init, psymbol_bcache_free)
2336         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
2337         (add_psymbol_to_bcache): Update.
2338         (allocate_psymtab): Update.
2339         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2340         macro_cache>: No longer pointers.
2341         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
2342         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
2343         * macrotab.c (macro_bcache): Update.
2344         * macroexp.c: Don't include bcache.h.
2345         * gdbtypes.c (check_types_worklist): Update.
2346         (types_deeply_equal): Remove TRY/CATCH.  Update.
2347         * elfread.c (elf_symtab_read): Update.
2348         * dwarf2read.c: Don't include bcache.h.
2349         * buildsym.c (buildsym_compunit::get_macro_table): Update.
2350         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
2351         (print_bcache_statistics, bcache_memory_used): Don't declare.
2352         (struct bcache): Move from bcache.c.  Add constructor, destructor,
2353         methods.  Rename all data members.
2354         * bcache.c (struct bcache): Move to bcache.h.
2355         (bcache::expand_hash_table): Rename from expand_hash_table.
2356         (bcache): Remove.
2357         (bcache::insert): Rename from bcache_full.
2358         (bcache::compare): Rename from bcache_compare.
2359         (bcache_xmalloc): Remove.
2360         (bcache::~bcache): Rename from bcache_xfree.
2361         (bcache::print_statistics): Rename from print_bcache_statistics.
2362         (bcache::memory_used): Rename from bcache_memory_used.
2363
2364 2019-03-07  Pedro Alves  <palves@redhat.com>
2365
2366         * infrun.c (normal_stop): Also check for
2367         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
2368
2369 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2370
2371         * f-lang.c (value_from_host_double): Moved to...
2372         * value.c (value_from_host_double): ...here.
2373         * value.h (value_from_host_double): Declare.
2374         * guile/scm-math.c (vlscm_convert_typed_number): Use
2375         value_from_host_double.
2376         (vlscm_convert_number): Likewise.
2377         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
2378         * python/py-value.c (convert_value_from_python): Likewise.
2379
2380 2019-03-06  Tom Tromey  <tom@tromey.com>
2381
2382         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
2383
2384 2019-03-06  Tom Tromey  <tom@tromey.com>
2385
2386         * utils.h (free_current_contents): Don't declare.
2387         * utils.c (free_current_contents): Remove.
2388
2389 2019-03-06  Tom Tromey  <tom@tromey.com>
2390
2391         * top.c (quit_force): Update.
2392         * main.c (captured_command_loop): Update.
2393         * common/new-op.c (operator new): Update.
2394         * common/common-exceptions.c (struct catcher)
2395         <save_cleanup_chain>: Remove member.
2396         (exceptions_state_mc_init): Update.
2397         (exception_try_scope_entry): Return nullptr.
2398         (exception_try_scope_exit, exception_rethrow)
2399         (throw_exception_sjlj, throw_exception_cxx): Update.
2400         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
2401         (all_cleanups, do_cleanups, discard_cleanups)
2402         (discard_final_cleanups, save_cleanups, save_final_cleanups)
2403         (restore_cleanups, restore_final_cleanups): Don't declare.
2404         (do_final_cleanups): Remove parameter.
2405         * common/cleanups.c (cleanup_chain, make_cleanup)
2406         (make_cleanup_dtor, all_cleanups, do_cleanups)
2407         (discard_my_cleanups, discard_cleanups)
2408         (discard_final_cleanups, save_my_cleanups, save_cleanups)
2409         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
2410         (null_cleanup): Remove.
2411         (do_final_cleanups): Remove parameter.
2412
2413 2019-03-06  Tom Tromey  <tom@tromey.com>
2414
2415         * remote.c (remote_target::remote_parse_stop_reply): Use
2416         unique_xmalloc_ptr.
2417
2418 2019-03-06  Tom Tromey  <tom@tromey.com>
2419
2420         * stabsread.c (struct stabs_field_info): Rename from field_info.
2421         <list, fnlist>: Add initializers.
2422         <obstack>: New member.
2423         (read_member_functions, read_struct_fields, read_baseclasses):
2424         Allocate on obstack.  Don't use cleanups.
2425         (read_one_struct_field, read_member_functions, read_struct_fields)
2426         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
2427         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
2428         (read_struct_type): Update.
2429
2430 2019-03-06  Tom Tromey  <tom@tromey.com>
2431
2432         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
2433         * common/filestuff.h (make_cleanup_close): Don't declare.
2434         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
2435         Remove.
2436
2437 2019-03-06  Tom Tromey  <tom@tromey.com>
2438
2439         * solib-aix.c: Use make_scope_exit.
2440
2441 2019-03-06  Tom Tromey  <tom@tromey.com>
2442
2443         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
2444         Use make_scope_exit.
2445
2446 2019-03-06  Tom Tromey  <tom@tromey.com>
2447
2448         * solib-svr4.c (disable_probes_interface): Remove parameter.
2449         (svr4_handle_solib_event): Use make_scope_exit.
2450
2451 2019-03-06  Tom Tromey  <tom@tromey.com>
2452
2453         * remote.c (struct stop_reply_deleter): Remove.
2454         (stop_reply_up): Update.
2455         (struct stop_reply): Derive from notif_event.  Don't typedef.
2456         <regcache>: Now a std::vector.
2457         (stop_reply_xfree): Remove.
2458         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
2459         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
2460         (remote_target::discard_pending_stop_replies): Use delete.
2461         (remote_target::remote_parse_stop_reply): Update.
2462         (remote_target::process_stop_reply): Update.
2463         * remote-notif.h (struct notif_event): Add virtual destructor.
2464         Remove "dtr" member.
2465         (struct notif_client) <alloc_event>: Return a unique_ptr.
2466         (notif_event_xfree): Don't declare.
2467         (notif_event_up): New typedef.
2468         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
2469         (notif_event_xfree, do_notif_event_xfree): Remove.
2470         (remote_notif_state_xfree): Update.
2471
2472 2019-03-06  Tom Tromey  <tom@tromey.com>
2473
2474         * infrun.c (displaced_step_clear_cleanup): Now a
2475         forward_scope_exit type.
2476         (displaced_step_prepare_throw): Update.
2477         (displaced_step_fixup): Update.
2478
2479 2019-03-06  Tom Tromey  <tom@tromey.com>
2480
2481         * inferior.h (class inferior): Update comment.
2482         * gdbthread.h (class thread_info): Update comment.
2483
2484 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
2485             Tom Tromey  <tom@tromey.com>
2486
2487         * stabsread.h (struct stab_section_list): Remove.
2488         (coffstab_build_psymtabs): Update.
2489         * dbxread.c (symbuf_sections): Now a std::vector.
2490         (sect_idx): New global.
2491         (fill_symbuf): Update.
2492         (coffstab_build_psymtabs): Change type of stabsects parameter.
2493         Update.
2494         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
2495         std::vector.
2496         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
2497         (coff_locate_sections): Update.
2498         (coff_symfile_read): Remove cleanups.  Update.
2499         (init_stringtab): Add storage parameter.
2500         (free_stringtab, free_stringtab_cleanup): Remove.
2501         (init_lineno): Add storage parameter.
2502         (free_linetab, free_linetab_cleanup): Remove.
2503
2504 2019-03-06  Pedro Alves  <palves@redhat.com>
2505
2506         * linux-fork.c (fork_info::clobber_regs): Delete.
2507         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
2508         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
2509         comment.  Adjust.
2510         (scoped_switch_fork_info::scoped_switch_fork_info)
2511         (checkpoint_command, linux_fork_context): Adjust
2512         fork_save_infrun_state calls.
2513
2514 2019-03-06  Pedro Alves  <palves@redhat.com>
2515
2516         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
2517         (inf_has_multiple_threads): Return 'bool' and rewrite using
2518         inferior_info::threads().
2519
2520 2019-03-06  Pedro Alves  <palves@redhat.com>
2521
2522         * linux-fork.c: Include <list>.
2523         (fork_list): Now a std::list instance.
2524         (fork_info): Add ctor, dtor, and in-class initialize all fields.
2525         (forks_exist_p, find_last_fork): Adjust.
2526         (new_fork): Delete.
2527         (one_fork_p): New.
2528         (add_fork): Adjust.
2529         (free_fork): Delete, folded into fork_info::~fork_info().
2530         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
2531         Adjust.
2532         (init_fork_list): Delete.
2533         (linux_fork_killall, linux_fork_mourn_inferior)
2534         (linux_fork_detach, info_checkpoints_command): Adjust.
2535         (_initialize_linux_fork): No longer call init_fork_list.
2536
2537 2019-03-06  Pedro Alves  <palves@redhat.com>
2538
2539         * linux-fork.c (new_fork): New, split out of ...
2540         (add_fork): ... this.  Return void.  Move "first fork" special
2541         case from here, to ...
2542         (checkpoint_command): ... here.
2543         * linux-linux.h (add_fork): Return void.
2544
2545 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2546
2547         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
2548
2549 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2550             Chris January  <chris.january@arm.com>
2551             David Lecomber  <david.lecomber@arm.com>
2552
2553         * f-exp.y: New token, UNOP_INTRINSIC.
2554         (exp): New pattern using UNOP_INTRINSIC token.
2555         (f77_keywords): Add 'abs' keyword.
2556         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
2557         (value_from_host_double): New function.
2558         (evaluate_subexp_f): Support UNOP_ABS.
2559
2560 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2561
2562         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
2563         types.
2564
2565 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2566
2567         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
2568         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
2569         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
2570
2571 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2572
2573         * f-exp.y (convert_to_kind_type): Handle more type kinds.
2574
2575 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2576             Chris January  <chris.january@arm.com>
2577
2578         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
2579         * f-exp.y: Define 'KIND' token.
2580         (exp): New pattern for KIND expressions.
2581         (ptype): Handle types with a kind extension.
2582         (direct_abs_decl): Extend to spot kind extensions.
2583         (f77_keywords): Add 'kind' to the list.
2584         (push_kind_type): New function.
2585         (convert_to_kind_type): New function.
2586         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
2587         * parse.c (operator_length_standard): Likewise.
2588         * parser-defs.h (enum type_pieces): Add tp_kind.
2589         * std-operator.def: Add UNOP_KIND.
2590
2591 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2592
2593         * f-exp.y (f_parse): Set yydebug.
2594
2595 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2596
2597         * f-lang.c (evaluate_subexp_f): New function.
2598         (exp_descriptor_f): New global.
2599         (f_language_defn): Use exp_descriptor_f instead of
2600         exp_descriptor_standard.
2601
2602 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2603
2604         * f-exp.y (struct token): Add comments.
2605         (dot_ops): Remove uppercase versions and the end marker.
2606         (f77_keywords): Likewise.
2607         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
2608         entries in the dot_ops array are case insensitive, and use
2609         strncasecmp to compare strings.  Also some whitespace cleanup in
2610         this area.  Similar for the f77_keywords array, except entries in
2611         this list might be case sensitive.
2612
2613 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2614
2615         * f-exp.y (struct f77_boolean_val): Add comments.
2616         (boolean_values): Remove uppercase versions, and end marker.
2617         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
2618         and use strncasecmp to achieve case insensitivity.  Additionally,
2619         perform whitespace cleanup around this code.
2620
2621 2019-03-06  Tom Tromey  <tromey@adacore.com>
2622
2623         * remote-sim.c (gdbsim_target_open): Use result of
2624         gdb_argv::release.
2625
2626 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
2627         Dirk Schubert  <dirk.schubert@arm.com>
2628         Chris January  <chris.january@arm.com>
2629
2630         * eval.c (evaluate_subexp_standard): Call Fortran argument
2631         wrapping logic.
2632         * f-lang.c (struct value): A value which can be passed into a
2633         Fortran function call.
2634         (fortran_argument_convert): Wrap Fortran arguments in a pointer
2635         where appropriate.
2636         (struct type): Value ready for a Fortran function call.
2637         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
2638         is needed.
2639         * f-lang.h (fortran_argument_convert): Declaration.
2640         (fortran_preserve_arg_pointer): Declaration.
2641         * infcall.c (value_arg_coerce): Call Fortran argument logic.
2642
2643 2019-03-05  Tom Tromey  <tromey@adacore.com>
2644
2645         * python/py-prettyprint.c (print_string_repr): Remove #if.
2646         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
2647
2648 2019-03-05  Tom Tromey  <tromey@adacore.com>
2649
2650         * target.c (the_dummy_target): Move later.  Change type to
2651         "dummy_target".
2652         (initialize_targets): Don't initialize the_dummy_target.
2653
2654 2019-03-05  Tom Tromey  <tromey@adacore.com>
2655
2656         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
2657         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
2658
2659 2019-03-05  Tom Tromey  <tromey@adacore.com>
2660
2661         * windows-nat.c (windows_nat_target::attach)
2662         (windows_nat_target::detach): Don't call gdb_flush.
2663         * valprint.c (generic_val_print, val_print, val_print_string):
2664         Don't call gdb_flush.
2665         * utils.c (defaulted_query): Don't call gdb_flush.
2666         * typeprint.c (print_type_scalar): Don't call gdb_flush.
2667         * target.c (target_announce_detach): Don't call gdb_flush.
2668         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
2669         * remote.c (extended_remote_target::attach): Don't call
2670         gdb_flush.
2671         * procfs.c (procfs_target::detach): Don't call gdb_flush.
2672         * printcmd.c (do_examine): Don't call gdb_flush.
2673         (info_display_command): Don't call gdb_flush.
2674         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
2675         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
2676         * memattr.c (info_mem_command): Don't call gdb_flush.
2677         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
2678         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
2679         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
2680         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
2681         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
2682         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
2683         (gnu_nat_target::detach): Don't call gdb_flush.
2684         * f-valprint.c (f_val_print): Don't call gdb_flush.
2685         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
2686         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
2687         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
2688         gdb_flush.
2689         * c-valprint.c (c_val_print): Don't call gdb_flush.
2690         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
2691
2692 2019-03-05  Tom Tromey  <tromey@adacore.com>
2693
2694         * varobj.c (update_dynamic_varobj_children): Update.
2695         (install_default_visualizer): Use reset, not release.
2696         * value.c (set_internalvar): Update.
2697         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
2698         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
2699         ATTRIBUTE_UNUSED_RESULT.
2700
2701 2019-03-05  Tom Tromey  <tromey@adacore.com>
2702
2703         * remote.c (class scoped_remote_fd) <release>: Add
2704         ATTRIBUTE_UNUSED_RESULT.
2705
2706 2019-03-05  Tom Tromey  <tromey@adacore.com>
2707
2708         * macroexp.c (struct macro_buffer) <release>: Add
2709         ATTRIBUTE_UNUSED_RESULT.
2710
2711 2019-03-05  Tom Tromey  <tromey@adacore.com>
2712
2713         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
2714         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
2715         ATTRIBUTE_UNUSED_RESULT.
2716
2717 2019-03-05  Tom Tromey  <tromey@adacore.com>
2718
2719         * common/scoped_fd.h (class scoped_fd) <release>: Add
2720         ATTRIBUTE_UNUSED_RESULT.
2721
2722 2019-03-05  Tom Tromey  <tromey@adacore.com>
2723
2724         * parser-defs.h (struct parser_state) <release>: Add
2725         ATTRIBUTE_UNUSED_RESULT.
2726
2727 2019-03-05  Tom Tromey  <tromey@adacore.com>
2728
2729         * utils.h (class gdb_argv) <release>: Add
2730         ATTRIBUTE_UNUSED_RESULT.
2731         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
2732
2733 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
2734
2735         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
2736         for-loop range, to avoid compiler warnings.
2737
2738         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
2739         avoid compiler warnings about unused variables.
2740
2741         * NEWS: Mention end of support for native debugging on MS-Windows
2742         before XP.
2743
2744         PR gdb/24292
2745         * common/netstuff.c:
2746         * gdbserver/gdbreplay.c
2747         * gdbserver/remote-utils.c:
2748         * ser-tcp.c:
2749         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
2750         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
2751         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
2752         'getaddrinfo' and 'freeaddrinfo' were not available before
2753         Windows XP, and mingw.org's MinGW headers by default define
2754         _WIN32_WINNT to 0x500.
2755
2756 2019-03-01  Gary Benson <gbenson@redhat.com>
2757
2758         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
2759
2760 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
2761             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2762
2763         PR gdb/8527
2764         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
2765         set_sigint_trap, clear_sigint_trap.
2766
2767 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2768
2769         * target.c (target_detach): Clear the regcache and the
2770         frame cache.
2771
2772 2019-02-27  Pedro Alves  <palves@redhat.com>
2773
2774         * utils.c (set_screen_size): When we cap the height/width sizes,
2775         tweak the corresponding command variable to show "unlimited":
2776
2777 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
2778             Pedro Alves  <palves@redhat.com>
2779
2780         * utils.c (set_screen_size): Reduce "infinite" rows and columns
2781         before calling rl_set_screen_size.
2782
2783 2019-02-27  Tom Tromey  <tromey@adacore.com>
2784
2785         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
2786         define.
2787         * python/py-value.c: Remove Python 2.4 workaround.
2788         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
2789         workaround.
2790         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
2791         Python 2.4 workaround.
2792         * python/python-internal.h: Remove Python 2.4 comment.
2793         (Py_ssize_t): Don't define.
2794         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
2795         (gdb_Py_DECREF): Remove Python 2.4 workaround.
2796         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
2797         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
2798         * python/python.c (do_start_initialization): Remove Python 2.4
2799         workaround.
2800         * python/py-prettyprint.c (class dummy_python_frame): Remove.
2801         (print_children): Remove Python 2.4 workaround.
2802         * python/py-inferior.c (buffer_procs): Remove Python 2.4
2803         workaround.
2804         (CHARBUFFERPROC_NAME): Remove.
2805         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
2806         Python 2.4 workaround.
2807
2808 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2809
2810         * NEWS: Note minimum Python version.
2811
2812 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2813
2814         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
2815         code from these functions.  Remove corresponding ifdefs.  Use
2816         Py_buffer_up instead of explicit calls to PyBuffer_Release.
2817         Remove gotos and target of gotos.
2818         (infpy_search_memory): Likewise.
2819
2820 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2821
2822         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
2823         (hppa_gdbarch_init): Don't register deleted functions with
2824         gdbarch.
2825
2826 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2827
2828         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
2829         (h8300_unwind_sp): Delete.
2830         (h8300_dummy_id): Delete.
2831         (h8300_gdbarch_init): Don't register deleted functions with
2832         gdbarch.
2833
2834 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2835
2836         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
2837         (ft32_unwind_pc): Delete.
2838         (ft32_unwind_sp): Delete.
2839         (ft32_gdbarch_init): Don't register deleted functions with
2840         gdbarch.
2841
2842 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2843
2844         * gdb/frv-tdep.c (frv_dummy_id): Delete.
2845         (frv_unwind_pc): Delete.
2846         (frv_unwind_sp): Delete.
2847         (frv_gdbarch_init): Don't register deleted functions with
2848         gdbarch.
2849
2850 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2851
2852         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
2853         (riscv_unwind_pc): Delete.
2854         (riscv_unwind_sp): Delete.
2855         (riscv_gdbarch_init): Don't register deleted functions with
2856         gdbarch.
2857
2858 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2859
2860         * gdb/csky-tdep.c (csky_dummy_id): Delete.
2861         (csky_unwind_pc): Delete.
2862         (csky_unwind_sp): Delete.
2863         (csky_gdbarch_init): Don't register deleted functions with
2864         gdbarch.
2865
2866 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2867
2868         * gdb/cris-tdep.c (cris_dummy_id): Delete.
2869         (cris_unwind_pc): Delete.
2870         (cris_unwind_sp): Delete.
2871         (cris_gdbarch_init): Don't register deleted functions with
2872         gdbarch.
2873
2874 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2875
2876         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
2877         (bfin_unwind_pc): Delete.
2878         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
2879
2880 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2881
2882         * gdb/arm-tdep.c (arm_dummy_id): Delete.
2883         (arm_unwind_pc): Delete.
2884         (arm_unwind_sp): Delete.
2885         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
2886
2887 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2888
2889         * gdb/arc-tdep.c (arc_dummy_id): Delete.
2890         (arc_unwind_pc): Delete.
2891         (arc_unwind_sp): Delete.
2892         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
2893
2894 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2895
2896         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
2897         (alpha_unwind_pc): Delete.
2898         (alpha_gdbarch_init): Don't register deleted functions with
2899         gdbarch.
2900
2901 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2902
2903         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
2904         (aarch64_unwind_pc): Delete.
2905         (aarch64_unwind_sp): Delete.
2906         (aarch64_gdbarch_init): Don't register deleted functions with
2907         gdbarch.
2908
2909 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2910
2911         * gdbtypes.c (type_align): Don't consider static members when
2912         computing structure alignment.
2913
2914 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2915
2916         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
2917         return 0 for other types.
2918         * arch-utils.c (default_type_align): Always return 0.
2919         * gdbarch.h: Regenerate.
2920         * gdbarch.sh (type_align): Extend comment.
2921         * gdbtypes.c (type_align): Add additional comments, always call
2922         gdbarch_type_align before applying the default rules.
2923         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
2924         generic code will then apply a suitable default.
2925         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
2926         types, return 0 for other types.
2927
2928 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
2929
2930         * NEWS: Create a new section for the next release branch.
2931         Rename the section of the current branch, now that it has
2932         been cut.
2933
2934 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
2935
2936         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
2937         * version.in: Bump version to 8.3.50.DATE-git.
2938
2939 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
2940
2941         * aix-thread.c (ptid_cmp): Remove unused variable.
2942         (get_signaled_thread): Likewise.
2943         (store_regs_user_thread): Likewise.
2944         (store_regs_kernel_thread): Likewise.
2945         (fetch_regs_kernel_thread): Remove shadowed variable.
2946
2947 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2948
2949         * features/riscv/32bit-cpu.xml: Add register numbers.
2950         * features/riscv/32bit-fpu.c: Regenerate.
2951         * features/riscv/32bit-fpu.xml: Add register numbers.
2952         * features/riscv/64bit-cpu.xml: Add register numbers.
2953         * features/riscv/64bit-fpu.c: Regenerate.
2954         * features/riscv/64bit-fpu.xml: Add register numbers.
2955
2956 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
2957
2958         * NEWS: Mention two argument form of gdb.Value constructor.
2959         * python/py-value.c (convert_buffer_and_type_to_value): New
2960         function.
2961         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
2962         Add support for handling an optional second argument.  Call
2963         convert_buffer_and_type_to_value as appropriate.
2964         * python/python-internal.h (Py_buffer_deleter): New struct.
2965         (Py_buffer_up): New typedef.
2966
2967 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
2968
2969         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
2970         instead of releasing ownership.
2971
2972 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
2973
2974         * dwarf2read.c (open_and_init_dwp_file): Call
2975         elf_numsections instead of bfd_count_sections to initialize
2976         dwp_file->num_sections.
2977
2978 2019-02-25  Tom Tromey  <tromey@adacore.com>
2979
2980         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
2981
2982 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2983
2984         * gcore.in: Add '--readnever' option when invoking GDB.
2985
2986 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
2987
2988         * MAINTAINERS: Update my email address.
2989
2990 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
2991
2992         * build-id.c (build_id_to_debug_bfd_1): New function.
2993         (build_id_to_debug_bfd): Look for separate debug file in
2994         sysroot.
2995
2996 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2997
2998         * gdbarch.sh: Update the copyright year range that is placed into
2999         generated files.
3000
3001 2019-02-22  Keith Seitz  <keiths@redhat.com>
3002
3003         PR symtab/23853
3004         * linespec.c (create_sals_line_offset): Search for the default
3005         symtab's filename instead of its fullname.
3006
3007 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3008
3009         * NEWS: Update style defaults.
3010
3011 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3012
3013         * main.c (captured_main_1): Disable styling in batch mode.
3014
3015 2019-02-20  Tom Tromey  <tom@tromey.com>
3016
3017         * symtab.c (symtab_symbol_info): Fix typos.
3018
3019 2019-02-20  Tom Tromey  <tromey@adacore.com>
3020
3021         * findcmd.c (_initialize_mem_search): Use upper case for
3022         metasyntactic variables.
3023
3024 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3025
3026         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3027         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3028
3029 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3030
3031         * top.h (source_file_name): Change to std::string.
3032         * top.c (source_file_name): Likewise.
3033         (command_line_input): Adjust.
3034         * cli/cli-script.c (script_from_file): Adjust.
3035
3036 2019-02-19  Tom Tromey  <tromey@adacore.com>
3037
3038         * ravenscar-thread.c
3039         (ravenscar_thread_target::update_thread_list): Don't call
3040         ada_build_task_list.
3041         * ada-lang.h (ada_build_task_list): Don't declare.
3042         * ada-tasks.c (struct ada_tasks_inferior_data)
3043         <task_list_valid_p>: Now bool.
3044         (read_known_tasks, ada_task_list_changed)
3045         (ada_tasks_invalidate_inferior_data): Update.
3046         (read_known_tasks_array): Return bool.
3047         (read_known_tasks_list): Likewise.
3048         (read_known_tasks): Return void.
3049         (ada_build_task_list): Now static.
3050
3051 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3052
3053         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3054         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3055
3056 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3057
3058         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3059         variant for ada_tasks_pspace_data_handle and
3060         ada_tasks_inferior_data_handle.
3061         (ada_tasks_pspace_data_cleanup): New function.
3062         (ada_tasks_inferior_data_cleanup): New function.
3063
3064 2019-02-17  Tom Tromey  <tom@tromey.com>
3065
3066         * macrotab.h (macro_source_fullname): Return a std::string.
3067         * macrotab.c (macro_include, check_for_redefinition)
3068         (macro_undef, macro_lookup_definition, foreach_macro)
3069         (foreach_macro_in_scope): Update.
3070         (macro_source_fullname): Return a std::string.
3071         * macrocmd.c (show_pp_source_pos): Update.
3072
3073 2019-02-17  Tom Tromey  <tom@tromey.com>
3074
3075         * macrocmd.c (show_pp_source_pos): Style the file names.
3076
3077 2019-02-17  Tom Tromey  <tom@tromey.com>
3078
3079         PR tui/24197:
3080         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3081
3082 2019-02-17  Tom Tromey  <tom@tromey.com>
3083
3084         * ada-lang.c (user_select_syms): Use filtered printing.
3085         * utils.c (wrap_style): New global.
3086         (desired_style): Remove.
3087         (emit_style_escape): Add stream parameter.
3088         (set_output_style, reset_terminal_style, prompt_for_continue):
3089         Update.
3090         (flush_wrap_buffer): Only flush gdb_stdout.
3091         (wrap_here): Set wrap_style.
3092         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3093         treat escape sequences as a character.  Change when wrap buffer is
3094         flushed.
3095         (fputs_styled): Do not set the output style when the default is
3096         requested.
3097         * ui-style.h (struct ui_file_style) <is_default>: New method.
3098         * source.c (print_source_lines_base): Emit escape sequences in one
3099         piece.
3100
3101 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3102
3103         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3104         integers and enumeration types.
3105
3106 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3107
3108         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3109         instead of lookup_symbol_in_language
3110         (do_exact_match): New function.
3111         (ada_get_symbol_name_matcher): Return do_exact_match when
3112         doing a verbatim match.
3113
3114 2019-02-15  Tom Tromey  <tromey@adacore.com>
3115
3116         * ravenscar-thread.c (ravenscar_thread_target::resume)
3117         (ravenscar_thread_target::wait): Special case wildcard requests.
3118
3119 2019-02-15  Tom Tromey  <tromey@adacore.com>
3120
3121         * ravenscar-thread.c (base_ptid): Remove.
3122         (struct ravenscar_thread_target) <close>: New method.
3123         <m_base_ptid>: New member.
3124         <update_inferior_ptid, active_task, task_is_currently_active,
3125         runtime_initialized>: Declare methods.
3126         <ravenscar_thread_target>: Add constructor.
3127         (ravenscar_thread_target::task_is_currently_active)
3128         (ravenscar_thread_target::update_inferior_ptid)
3129         (ravenscar_runtime_initialized): Rename.  Now methods.
3130         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3131         (ravenscar_thread_target::update_thread_list): Update.
3132         (ravenscar_thread_target::active_task): Now method.
3133         (ravenscar_thread_target::store_registers)
3134         (ravenscar_thread_target::prepare_to_store)
3135         (ravenscar_thread_target::prepare_to_store)
3136         (ravenscar_thread_target::mourn_inferior): Update.
3137         (ravenscar_inferior_created): Use "new" to create target.
3138         (ravenscar_thread_target::get_ada_task_ptid): Update.
3139         (_initialize_ravenscar): Don't initialize base_ptid.
3140         (ravenscar_ops): Remove global.
3141
3142 2019-02-15  Tom Tromey  <tromey@adacore.com>
3143
3144         * target.h (push_target): Declare new overload.
3145         * target.c (push_target): New overload, taking an rvalue reference.
3146         * remote.c (remote_target::open_1): Use push_target overload.
3147         * corelow.c (core_target_open): Use push_target overload.
3148
3149 2019-02-15  Tom Tromey  <tromey@adacore.com>
3150
3151         * ravenscar-thread.c (is_ravenscar_task)
3152         (ravenscar_task_is_currently_active): Return bool.
3153         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3154         (_initialize_ravenscar): Remove "(void)".
3155         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3156         Return bool.
3157
3158 2019-02-15  Tom Tromey  <tromey@adacore.com>
3159
3160         * ravenscar-thread.c (ravenscar_runtime_initializer)
3161         (has_ravenscar_runtime, get_running_thread_id)
3162         (ravenscar_thread_target::resume): Fix indentation.
3163
3164 2019-02-15  Tom Tromey  <tromey@adacore.com>
3165
3166         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3167         from ravenscar_arch_ops.
3168         (sparc_ravenscar_ops::fetch_registers)
3169         (sparc_ravenscar_ops::store_registers): Now methods.
3170         (sparc_ravenscar_prepare_to_store): Remove.
3171         (sparc_ravenscar_ops): Redefine.
3172         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
3173         methods and destructor.  Remove members.
3174         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
3175         (ravenscar_thread_target::store_registers)
3176         (ravenscar_thread_target::prepare_to_store): Update.
3177         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
3178         Remove.
3179         (struct ppc_ravenscar_powerpc_ops): Derive from
3180         ravenscar_arch_ops.
3181         (ppc_ravenscar_powerpc_ops::fetch_registers)
3182         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
3183         (ppc_ravenscar_powerpc_ops): Redefine.
3184         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
3185         (ppc_ravenscar_e500_ops::fetch_registers)
3186         (ppc_ravenscar_e500_ops::store_registers): Now methods.
3187         (ppc_ravenscar_e500_ops): Redefine.
3188         * aarch64-ravenscar-thread.c
3189         (aarch64_ravenscar_generic_prepare_to_store): Remove.
3190         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
3191         (aarch64_ravenscar_fetch_registers)
3192         (aarch64_ravenscar_store_registers): Now methods.
3193         (aarch64_ravenscar_ops): Redefine.
3194
3195 2019-02-15  Tom Tromey  <tromey@adacore.com>
3196
3197         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
3198         (ravenscar_thread_target::stopped_by_hw_breakpoint)
3199         (ravenscar_thread_target::stopped_by_watchpoint)
3200         (ravenscar_thread_target::stopped_data_address)
3201         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
3202
3203 2019-02-15  Tom Tromey  <tromey@adacore.com>
3204
3205         * ravenscar-thread.c: Fix some typos.
3206
3207 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3208             Tom Tromey  <tromey@adacore.com>
3209
3210         * ada-lang.c (ada_exception_sal): Change addr_string to a
3211         std::string.
3212         (create_ada_exception_catchpoint): Update.
3213
3214 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3215             Tom Tromey  <tromey@adacore.com>
3216
3217         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3218         (bp_location_ops): Remove.
3219         (base_breakpoint_allocate_location): Update.
3220         (free_bp_location): Update.
3221         * ada-lang.c (class ada_catchpoint_location)
3222         <ada_catchpoint_location>: Remove ops parameter.
3223         (ada_catchpoint_location_dtor): Remove.
3224         (ada_catchpoint_location_ops): Remove.
3225         (allocate_location_exception): Update.
3226         * breakpoint.h (struct bp_location_ops): Remove.
3227         (class bp_location) <bp_location>: Remove bp_location_ops
3228         parameter.
3229         <~bp_location>: Add destructor.
3230         <ops>: Remove.
3231
3232 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3233             Pedro Alves  <palves@redhat.com>
3234
3235         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3236         'PATH_MAX'.
3237
3238 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3239             Samuel Thibault  <samuel.thibault@gnu.org>
3240             Thomas Schwinge  <thomas@codesourcery.com>
3241
3242         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
3243         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
3244
3245 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3246
3247         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
3248         (check_empty): Use "const char *".
3249
3250         * gnu-nat.c (gnu_nat_target::detach): Instead of
3251         'detach_inferior (pid)' call
3252         'detach_inferior (find_inferior_pid (pid))'.
3253
3254         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
3255         'nat/fork-inferior.o'.
3256         * gnu-nat.c: #include "nat/fork-inferior.h".
3257
3258         * gnu-nat.c (gnu_nat_target::detach): Instead of
3259         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
3260         * gnu-nat.h: #include "inf-child.h".
3261         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
3262         'i386_gnu_nat_target::fetch_registers'.
3263         (gnu_store_registers): Rename/move to
3264         'i386_gnu_nat_target::store_registers'.
3265
3266         * config/i386/nm-i386gnu.h: Don't "#include" any files.
3267         * gnu-nat.h (mach_thread_info): New function.
3268         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
3269
3270         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
3271
3272 2019-02-14  Frederic Konrad  <konrad@adacore.com>
3273
3274         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
3275
3276 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
3277
3278         * windows-nat.c (windows_add_thread): Add new parameter
3279         "main_thread_p" with default value set to false.  Update
3280         function documentation as well as all callers.
3281         (windows_delete_thread): Likewise.
3282         (fake_create_process): Update call to windows_add_thread.
3283         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
3284         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
3285         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
3286         call to windows_delete_thread.
3287
3288 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
3289
3290         * MAINTAINERS: Add Andrew Burgess as global maintainer.
3291
3292 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3293
3294         * symfile.c (find_separate_debug_file): Use canonical path of
3295         sysroot with child_path instead of gdb_sysroot if it is valid.
3296
3297 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3298
3299         * symfile.c (find_separate_debug_file): Use child_path to
3300         determine if an object file is under a sysroot.
3301
3302 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3303
3304         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3305         unittests/child-path-selftests.c.
3306         * common/pathstuff.c (child_path): New function.
3307         * common/pathstuff.h (child_path): New prototype.
3308         * unittests/child-path-selftests.c: New file.
3309
3310 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3311
3312         * symfile.c (find_separate_debug_file): Look for separate debug
3313         files in debug directories under the sysroot.
3314
3315 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3316
3317         * symtab.h (struct minimal_symbol data_p): New const method.
3318         (struct minimal_symbol text_p): Likewise.
3319         * symtab.c (output_source_filename): Use file name style
3320         to print file name.
3321         (print_symbol_info): Likewise.
3322         (print_msymbol_info): Use address style to print addresses.
3323         Use function name style to print executable text symbols.
3324         (expand_symtab_containing_pc): Use data_p.
3325         (find_pc_sect_compunit_symtab): Likewise.
3326
3327 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3328
3329         * breakpoint.c (describe_other_breakpoints): Use address style
3330         to print addresses.
3331         (say_where): Likewise.
3332
3333 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3334
3335         * ada-typeprint.c (print_func_type): Print function name
3336         style to print function name.
3337         * c-typeprint.c (c_print_type_1): Likewise.
3338
3339 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
3340
3341         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
3342         for execve.
3343
3344 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3345
3346         * c-exp.y (direct_abs_decl): Use emplace_back to record the
3347         type_stack.
3348
3349 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
3350
3351         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
3352         TYPE_CODE_REF types.
3353
3354 2019-02-08  Jim Wilson  <jimw@sifive.com>
3355
3356         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
3357         (riscv_linux_fregset): New.
3358         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
3359
3360 2019-02-07  Tom Tromey  <tom@tromey.com>
3361
3362         * thread.c (thread_cancel_execution_command): Update.
3363         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
3364         methods.
3365         (struct thread_fsm_ops): Remove.
3366         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
3367         (thread_fsm_should_stop, thread_fsm_return_value)
3368         (thread_fsm_set_finished, thread_fsm_finished_p)
3369         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
3370         Don't declare.
3371         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
3372         * infrun.c (clear_proceed_status_thread)
3373         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
3374         (print_stop_event): Update.
3375         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
3376         Add constructor.
3377         (step_command_fsm_ops): Remove.
3378         (new_step_command_fsm): Remove.
3379         (step_1): Update.
3380         (step_command_fsm::should_stop): Rename from
3381         step_command_fsm_should_stop.
3382         (step_command_fsm::clean_up): Rename from
3383         step_command_fsm_clean_up.
3384         (step_command_fsm::do_async_reply_reason): Rename from
3385         step_command_fsm_async_reply_reason.
3386         (struct until_next_fsm): Inherit from thread_fsm.  Add
3387         constructor.
3388         (until_next_fsm_ops): Remove.
3389         (new_until_next_fsm): Remove.
3390         (until_next_fsm::should_stop): Rename from
3391         until_next_fsm_should_stop.
3392         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
3393         (until_next_fsm::do_async_reply_reason): Rename from
3394         until_next_fsm_async_reply_reason.
3395         (struct finish_command_fsm): Inherit from thread_fsm.  Add
3396         constructor.  Change type of breakpoint.
3397         (finish_command_fsm_ops): Remove.
3398         (new_finish_command_fsm): Remove.
3399         (finish_command_fsm::should_stop): Rename from
3400         finish_command_fsm_should_stop.
3401         (finish_command_fsm::clean_up): Rename from
3402         finish_command_fsm_clean_up.
3403         (finish_command_fsm::return_value): Rename from
3404         finish_command_fsm_return_value.
3405         (finish_command_fsm::do_async_reply_reason): Rename from
3406         finish_command_fsm_async_reply_reason.
3407         (finish_command): Update.
3408         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
3409         Add constructor.
3410         (call_thread_fsm_ops): Remove.
3411         (call_thread_fsm::call_thread_fsm): Rename from
3412         new_call_thread_fsm.
3413         (call_thread_fsm::should_stop): Rename from
3414         call_thread_fsm_should_stop.
3415         (call_thread_fsm::should_notify_stop): Rename from
3416         call_thread_fsm_should_notify_stop.
3417         (run_inferior_call, call_function_by_hand_dummy): Update.
3418         * cli/cli-interp.c (should_print_stop_to_console): Update.
3419         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
3420         Add constructor.  Change type of location_breakpoint,
3421         caller_breakpoint.
3422         (until_break_fsm_ops): Remove.
3423         (new_until_break_fsm): Remove.
3424         (until_break_fsm::should_stop): Rename from
3425         until_break_fsm_should_stop.
3426         (until_break_fsm::clean_up): Rename from
3427         until_break_fsm_clean_up.
3428         (until_break_fsm::do_async_reply_reason): Rename from
3429         until_break_fsm_async_reply_reason.
3430         (until_break_command): Update.
3431         * thread-fsm.c: Remove.
3432         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
3433
3434 2019-02-07  Tom Tromey  <tom@tromey.com>
3435
3436         * yy-remap.h: Add include guard.
3437         * xtensa-tdep.h: Add include guard.
3438         * xcoffread.h: Rename include guard.
3439         * varobj-iter.h: Add include guard.
3440         * tui/tui.h: Rename include guard.
3441         * tui/tui-winsource.h: Rename include guard.
3442         * tui/tui-wingeneral.h: Rename include guard.
3443         * tui/tui-windata.h: Rename include guard.
3444         * tui/tui-win.h: Rename include guard.
3445         * tui/tui-stack.h: Rename include guard.
3446         * tui/tui-source.h: Rename include guard.
3447         * tui/tui-regs.h: Rename include guard.
3448         * tui/tui-out.h: Rename include guard.
3449         * tui/tui-layout.h: Rename include guard.
3450         * tui/tui-io.h: Rename include guard.
3451         * tui/tui-hooks.h: Rename include guard.
3452         * tui/tui-file.h: Rename include guard.
3453         * tui/tui-disasm.h: Rename include guard.
3454         * tui/tui-data.h: Rename include guard.
3455         * tui/tui-command.h: Rename include guard.
3456         * tic6x-tdep.h: Add include guard.
3457         * target/waitstatus.h: Rename include guard.
3458         * target/wait.h: Rename include guard.
3459         * target/target.h: Rename include guard.
3460         * target/resume.h: Rename include guard.
3461         * target-float.h: Rename include guard.
3462         * stabsread.h: Add include guard.
3463         * rs6000-tdep.h: Add include guard.
3464         * riscv-fbsd-tdep.h: Add include guard.
3465         * regformats/regdef.h: Rename include guard.
3466         * record.h: Rename include guard.
3467         * python/python.h: Rename include guard.
3468         * python/python-internal.h: Rename include guard.
3469         * python/py-stopevent.h: Rename include guard.
3470         * python/py-ref.h: Rename include guard.
3471         * python/py-record.h: Rename include guard.
3472         * python/py-record-full.h: Rename include guard.
3473         * python/py-record-btrace.h: Rename include guard.
3474         * python/py-instruction.h: Rename include guard.
3475         * python/py-events.h: Rename include guard.
3476         * python/py-event.h: Rename include guard.
3477         * procfs.h: Add include guard.
3478         * proc-utils.h: Add include guard.
3479         * p-lang.h: Add include guard.
3480         * or1k-tdep.h: Rename include guard.
3481         * observable.h: Rename include guard.
3482         * nto-tdep.h: Rename include guard.
3483         * nat/x86-linux.h: Rename include guard.
3484         * nat/x86-linux-dregs.h: Rename include guard.
3485         * nat/x86-gcc-cpuid.h: Add include guard.
3486         * nat/x86-dregs.h: Rename include guard.
3487         * nat/x86-cpuid.h: Rename include guard.
3488         * nat/ppc-linux.h: Rename include guard.
3489         * nat/mips-linux-watch.h: Rename include guard.
3490         * nat/linux-waitpid.h: Rename include guard.
3491         * nat/linux-ptrace.h: Rename include guard.
3492         * nat/linux-procfs.h: Rename include guard.
3493         * nat/linux-osdata.h: Rename include guard.
3494         * nat/linux-nat.h: Rename include guard.
3495         * nat/linux-namespaces.h: Rename include guard.
3496         * nat/linux-btrace.h: Rename include guard.
3497         * nat/glibc_thread_db.h: Rename include guard.
3498         * nat/gdb_thread_db.h: Rename include guard.
3499         * nat/gdb_ptrace.h: Rename include guard.
3500         * nat/fork-inferior.h: Rename include guard.
3501         * nat/amd64-linux-siginfo.h: Rename include guard.
3502         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
3503         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
3504         * nat/aarch64-linux.h: Rename include guard.
3505         * nat/aarch64-linux-hw-point.h: Rename include guard.
3506         * mn10300-tdep.h: Add include guard.
3507         * mips-linux-tdep.h: Add include guard.
3508         * mi/mi-parse.h: Rename include guard.
3509         * mi/mi-out.h: Rename include guard.
3510         * mi/mi-main.h: Rename include guard.
3511         * mi/mi-interp.h: Rename include guard.
3512         * mi/mi-getopt.h: Rename include guard.
3513         * mi/mi-console.h: Rename include guard.
3514         * mi/mi-common.h: Rename include guard.
3515         * mi/mi-cmds.h: Rename include guard.
3516         * mi/mi-cmd-break.h: Rename include guard.
3517         * m2-lang.h: Add include guard.
3518         * location.h: Rename include guard.
3519         * linux-record.h: Rename include guard.
3520         * linux-nat.h: Add include guard.
3521         * linux-fork.h: Add include guard.
3522         * i386-darwin-tdep.h: Rename include guard.
3523         * hppa-linux-offsets.h: Add include guard.
3524         * guile/guile.h: Rename include guard.
3525         * guile/guile-internal.h: Rename include guard.
3526         * gnu-nat.h: Rename include guard.
3527         * gdb-stabs.h: Rename include guard.
3528         * frv-tdep.h: Add include guard.
3529         * f-lang.h: Add include guard.
3530         * event-loop.h: Add include guard.
3531         * darwin-nat.h: Rename include guard.
3532         * cp-abi.h: Rename include guard.
3533         * config/sparc/nm-sol2.h: Rename include guard.
3534         * config/nm-nto.h: Rename include guard.
3535         * config/nm-linux.h: Add include guard.
3536         * config/i386/nm-i386gnu.h: Rename include guard.
3537         * config/djgpp/nl_types.h: Rename include guard.
3538         * config/djgpp/langinfo.h: Rename include guard.
3539         * compile/gcc-cp-plugin.h: Add include guard.
3540         * compile/gcc-c-plugin.h: Add include guard.
3541         * compile/compile.h: Rename include guard.
3542         * compile/compile-object-run.h: Rename include guard.
3543         * compile/compile-object-load.h: Rename include guard.
3544         * compile/compile-internal.h: Rename include guard.
3545         * compile/compile-cplus.h: Rename include guard.
3546         * compile/compile-c.h: Rename include guard.
3547         * common/xml-utils.h: Rename include guard.
3548         * common/x86-xstate.h: Rename include guard.
3549         * common/version.h: Rename include guard.
3550         * common/vec.h: Rename include guard.
3551         * common/tdesc.h: Rename include guard.
3552         * common/selftest.h: Rename include guard.
3553         * common/scoped_restore.h: Rename include guard.
3554         * common/scoped_mmap.h: Rename include guard.
3555         * common/scoped_fd.h: Rename include guard.
3556         * common/safe-iterator.h: Rename include guard.
3557         * common/run-time-clock.h: Rename include guard.
3558         * common/refcounted-object.h: Rename include guard.
3559         * common/queue.h: Rename include guard.
3560         * common/ptid.h: Rename include guard.
3561         * common/print-utils.h: Rename include guard.
3562         * common/preprocessor.h: Rename include guard.
3563         * common/pathstuff.h: Rename include guard.
3564         * common/observable.h: Rename include guard.
3565         * common/netstuff.h: Rename include guard.
3566         * common/job-control.h: Rename include guard.
3567         * common/host-defs.h: Rename include guard.
3568         * common/gdb_wait.h: Rename include guard.
3569         * common/gdb_vecs.h: Rename include guard.
3570         * common/gdb_unlinker.h: Rename include guard.
3571         * common/gdb_unique_ptr.h: Rename include guard.
3572         * common/gdb_tilde_expand.h: Rename include guard.
3573         * common/gdb_sys_time.h: Rename include guard.
3574         * common/gdb_string_view.h: Rename include guard.
3575         * common/gdb_splay_tree.h: Rename include guard.
3576         * common/gdb_setjmp.h: Rename include guard.
3577         * common/gdb_ref_ptr.h: Rename include guard.
3578         * common/gdb_optional.h: Rename include guard.
3579         * common/gdb_locale.h: Rename include guard.
3580         * common/gdb_assert.h: Rename include guard.
3581         * common/filtered-iterator.h: Rename include guard.
3582         * common/filestuff.h: Rename include guard.
3583         * common/fileio.h: Rename include guard.
3584         * common/environ.h: Rename include guard.
3585         * common/common-utils.h: Rename include guard.
3586         * common/common-types.h: Rename include guard.
3587         * common/common-regcache.h: Rename include guard.
3588         * common/common-inferior.h: Rename include guard.
3589         * common/common-gdbthread.h: Rename include guard.
3590         * common/common-exceptions.h: Rename include guard.
3591         * common/common-defs.h: Rename include guard.
3592         * common/common-debug.h: Rename include guard.
3593         * common/cleanups.h: Rename include guard.
3594         * common/buffer.h: Rename include guard.
3595         * common/btrace-common.h: Rename include guard.
3596         * common/break-common.h: Rename include guard.
3597         * cli/cli-utils.h: Rename include guard.
3598         * cli/cli-style.h: Rename include guard.
3599         * cli/cli-setshow.h: Rename include guard.
3600         * cli/cli-script.h: Rename include guard.
3601         * cli/cli-interp.h: Rename include guard.
3602         * cli/cli-decode.h: Rename include guard.
3603         * cli/cli-cmds.h: Rename include guard.
3604         * charset-list.h: Add include guard.
3605         * buildsym-legacy.h: Rename include guard.
3606         * bfin-tdep.h: Add include guard.
3607         * ax.h: Rename include guard.
3608         * arm-linux-tdep.h: Add include guard.
3609         * arm-fbsd-tdep.h: Add include guard.
3610         * arch/xtensa.h: Rename include guard.
3611         * arch/tic6x.h: Add include guard.
3612         * arch/i386.h: Add include guard.
3613         * arch/arm.h: Rename include guard.
3614         * arch/arm-linux.h: Rename include guard.
3615         * arch/arm-get-next-pcs.h: Rename include guard.
3616         * arch/amd64.h: Add include guard.
3617         * arch/aarch64-insn.h: Rename include guard.
3618         * arch-utils.h: Rename include guard.
3619         * annotate.h: Add include guard.
3620         * amd64-darwin-tdep.h: Rename include guard.
3621         * aarch64-linux-tdep.h: Add include guard.
3622         * aarch64-fbsd-tdep.h: Add include guard.
3623         * aarch32-linux-nat.h: Add include guard.
3624
3625 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3626
3627         * macrotab.c (macro_define_internal): New function that
3628         factorizes macro_define_object_internal and macro_define_function
3629         code.
3630         (macro_define_object_internal): Use macro_define_internal.
3631         (macro_define_function): Likewise.
3632
3633 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3634
3635         * macrocmd.c (extract_identifier): Return
3636         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
3637         callers.
3638
3639 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
3640
3641         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
3642
3643 2019-02-05  Tom Tromey  <tom@tromey.com>
3644
3645         * target.c (target_stack::unpush): Move assertion earlier.
3646
3647 2019-01-30  Tom Tromey  <tom@tromey.com>
3648
3649         PR python/23615:
3650         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
3651         (gdbpy_parse_and_eval): Likewise.
3652         * python/python-internal.h (gdbpy_allow_threads): New class.
3653
3654 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
3655
3656         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
3657         (aarch64_fbsd_fpregmap): Move earlier.
3658         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
3659         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3660         instead of individual calls to trad_frame_set_reg_addr.
3661         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
3662         earlier.
3663         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
3664         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3665         instead of individual calls to trad_frame_set_reg_addr.
3666
3667 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
3668
3669         * CONTRIBUTE: Replace contribution list with wiki link.
3670
3671 2019-01-25  Tom Tromey  <tom@tromey.com>
3672
3673         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
3674
3675 2019-01-25  Tom Tromey  <tom@tromey.com>
3676
3677         * xtensa-linux-nat.c: Fix common/ includes.
3678         * xml-support.h: Fix common/ includes.
3679         * xml-support.c: Fix common/ includes.
3680         * x86-linux-nat.c: Fix common/ includes.
3681         * windows-nat.c: Fix common/ includes.
3682         * varobj.h: Fix common/ includes.
3683         * varobj.c: Fix common/ includes.
3684         * value.c: Fix common/ includes.
3685         * valops.c: Fix common/ includes.
3686         * utils.c: Fix common/ includes.
3687         * unittests/xml-utils-selftests.c: Fix common/ includes.
3688         * unittests/utils-selftests.c: Fix common/ includes.
3689         * unittests/unpack-selftests.c: Fix common/ includes.
3690         * unittests/tracepoint-selftests.c: Fix common/ includes.
3691         * unittests/style-selftests.c: Fix common/ includes.
3692         * unittests/string_view-selftests.c: Fix common/ includes.
3693         * unittests/scoped_restore-selftests.c: Fix common/ includes.
3694         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
3695         * unittests/scoped_fd-selftests.c: Fix common/ includes.
3696         * unittests/rsp-low-selftests.c: Fix common/ includes.
3697         * unittests/parse-connection-spec-selftests.c: Fix common/
3698         includes.
3699         * unittests/optional-selftests.c: Fix common/ includes.
3700         * unittests/offset-type-selftests.c: Fix common/ includes.
3701         * unittests/observable-selftests.c: Fix common/ includes.
3702         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
3703         * unittests/memrange-selftests.c: Fix common/ includes.
3704         * unittests/memory-map-selftests.c: Fix common/ includes.
3705         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
3706         * unittests/function-view-selftests.c: Fix common/ includes.
3707         * unittests/environ-selftests.c: Fix common/ includes.
3708         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
3709         * unittests/common-utils-selftests.c: Fix common/ includes.
3710         * unittests/cli-utils-selftests.c: Fix common/ includes.
3711         * unittests/array-view-selftests.c: Fix common/ includes.
3712         * ui-file.c: Fix common/ includes.
3713         * tui/tui-io.c: Fix common/ includes.
3714         * tracepoint.h: Fix common/ includes.
3715         * tracepoint.c: Fix common/ includes.
3716         * tracefile-tfile.c: Fix common/ includes.
3717         * top.h: Fix common/ includes.
3718         * top.c: Fix common/ includes.
3719         * thread.c: Fix common/ includes.
3720         * target/waitstatus.h: Fix common/ includes.
3721         * target/waitstatus.c: Fix common/ includes.
3722         * target.h: Fix common/ includes.
3723         * target.c: Fix common/ includes.
3724         * target-memory.c: Fix common/ includes.
3725         * target-descriptions.c: Fix common/ includes.
3726         * symtab.h: Fix common/ includes.
3727         * symfile.c: Fix common/ includes.
3728         * stap-probe.c: Fix common/ includes.
3729         * spu-linux-nat.c: Fix common/ includes.
3730         * sparc-nat.c: Fix common/ includes.
3731         * source.c: Fix common/ includes.
3732         * solib.c: Fix common/ includes.
3733         * solib-target.c: Fix common/ includes.
3734         * ser-unix.c: Fix common/ includes.
3735         * ser-tcp.c: Fix common/ includes.
3736         * ser-pipe.c: Fix common/ includes.
3737         * ser-base.c: Fix common/ includes.
3738         * selftest-arch.c: Fix common/ includes.
3739         * s12z-tdep.c: Fix common/ includes.
3740         * rust-exp.y: Fix common/ includes.
3741         * rs6000-aix-tdep.c: Fix common/ includes.
3742         * riscv-tdep.c: Fix common/ includes.
3743         * remote.c: Fix common/ includes.
3744         * remote-notif.h: Fix common/ includes.
3745         * remote-fileio.h: Fix common/ includes.
3746         * remote-fileio.c: Fix common/ includes.
3747         * regcache.h: Fix common/ includes.
3748         * regcache.c: Fix common/ includes.
3749         * record-btrace.c: Fix common/ includes.
3750         * python/python.c: Fix common/ includes.
3751         * python/py-type.c: Fix common/ includes.
3752         * python/py-inferior.c: Fix common/ includes.
3753         * progspace.h: Fix common/ includes.
3754         * producer.c: Fix common/ includes.
3755         * procfs.c: Fix common/ includes.
3756         * proc-api.c: Fix common/ includes.
3757         * printcmd.c: Fix common/ includes.
3758         * ppc-linux-nat.c: Fix common/ includes.
3759         * parser-defs.h: Fix common/ includes.
3760         * osdata.c: Fix common/ includes.
3761         * obsd-nat.c: Fix common/ includes.
3762         * nat/x86-linux.c: Fix common/ includes.
3763         * nat/x86-linux-dregs.c: Fix common/ includes.
3764         * nat/x86-dregs.h: Fix common/ includes.
3765         * nat/x86-dregs.c: Fix common/ includes.
3766         * nat/ppc-linux.c: Fix common/ includes.
3767         * nat/mips-linux-watch.h: Fix common/ includes.
3768         * nat/mips-linux-watch.c: Fix common/ includes.
3769         * nat/linux-waitpid.c: Fix common/ includes.
3770         * nat/linux-ptrace.h: Fix common/ includes.
3771         * nat/linux-ptrace.c: Fix common/ includes.
3772         * nat/linux-procfs.c: Fix common/ includes.
3773         * nat/linux-personality.c: Fix common/ includes.
3774         * nat/linux-osdata.c: Fix common/ includes.
3775         * nat/linux-namespaces.c: Fix common/ includes.
3776         * nat/linux-btrace.h: Fix common/ includes.
3777         * nat/linux-btrace.c: Fix common/ includes.
3778         * nat/fork-inferior.c: Fix common/ includes.
3779         * nat/amd64-linux-siginfo.c: Fix common/ includes.
3780         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
3781         * nat/aarch64-linux.c: Fix common/ includes.
3782         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
3783         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
3784         * namespace.h: Fix common/ includes.
3785         * mips-linux-tdep.c: Fix common/ includes.
3786         * minsyms.c: Fix common/ includes.
3787         * mi/mi-parse.h: Fix common/ includes.
3788         * mi/mi-main.c: Fix common/ includes.
3789         * mi/mi-cmd-env.c: Fix common/ includes.
3790         * memrange.h: Fix common/ includes.
3791         * memattr.c: Fix common/ includes.
3792         * maint.h: Fix common/ includes.
3793         * maint.c: Fix common/ includes.
3794         * main.c: Fix common/ includes.
3795         * machoread.c: Fix common/ includes.
3796         * location.c: Fix common/ includes.
3797         * linux-thread-db.c: Fix common/ includes.
3798         * linux-nat.c: Fix common/ includes.
3799         * linux-fork.c: Fix common/ includes.
3800         * inline-frame.c: Fix common/ includes.
3801         * infrun.c: Fix common/ includes.
3802         * inflow.c: Fix common/ includes.
3803         * inferior.h: Fix common/ includes.
3804         * inferior.c: Fix common/ includes.
3805         * infcmd.c: Fix common/ includes.
3806         * inf-ptrace.c: Fix common/ includes.
3807         * inf-child.c: Fix common/ includes.
3808         * ia64-linux-nat.c: Fix common/ includes.
3809         * i387-tdep.c: Fix common/ includes.
3810         * i386-tdep.c: Fix common/ includes.
3811         * i386-linux-tdep.c: Fix common/ includes.
3812         * i386-linux-nat.c: Fix common/ includes.
3813         * i386-go32-tdep.c: Fix common/ includes.
3814         * i386-fbsd-tdep.c: Fix common/ includes.
3815         * i386-fbsd-nat.c: Fix common/ includes.
3816         * guile/scm-type.c: Fix common/ includes.
3817         * guile/guile.c: Fix common/ includes.
3818         * go32-nat.c: Fix common/ includes.
3819         * gnu-nat.c: Fix common/ includes.
3820         * gdbthread.h: Fix common/ includes.
3821         * gdbarch-selftests.c: Fix common/ includes.
3822         * gdb_usleep.c: Fix common/ includes.
3823         * gdb_select.h: Fix common/ includes.
3824         * gdb_bfd.c: Fix common/ includes.
3825         * gcore.c: Fix common/ includes.
3826         * fork-child.c: Fix common/ includes.
3827         * findvar.c: Fix common/ includes.
3828         * fbsd-nat.c: Fix common/ includes.
3829         * event-top.c: Fix common/ includes.
3830         * event-loop.c: Fix common/ includes.
3831         * dwarf2read.c: Fix common/ includes.
3832         * dwarf2loc.c: Fix common/ includes.
3833         * dwarf2-frame.c: Fix common/ includes.
3834         * dwarf-index-cache.c: Fix common/ includes.
3835         * dtrace-probe.c: Fix common/ includes.
3836         * disasm-selftests.c: Fix common/ includes.
3837         * defs.h: Fix common/ includes.
3838         * csky-tdep.c: Fix common/ includes.
3839         * cp-valprint.c: Fix common/ includes.
3840         * cp-support.h: Fix common/ includes.
3841         * cp-support.c: Fix common/ includes.
3842         * corelow.c: Fix common/ includes.
3843         * completer.h: Fix common/ includes.
3844         * completer.c: Fix common/ includes.
3845         * compile/compile.c: Fix common/ includes.
3846         * compile/compile-loc2c.c: Fix common/ includes.
3847         * compile/compile-cplus-types.c: Fix common/ includes.
3848         * compile/compile-cplus-symbols.c: Fix common/ includes.
3849         * command.h: Fix common/ includes.
3850         * cli/cli-dump.c: Fix common/ includes.
3851         * cli/cli-cmds.c: Fix common/ includes.
3852         * charset.c: Fix common/ includes.
3853         * build-id.c: Fix common/ includes.
3854         * btrace.h: Fix common/ includes.
3855         * btrace.c: Fix common/ includes.
3856         * breakpoint.h: Fix common/ includes.
3857         * breakpoint.c: Fix common/ includes.
3858         * ax.h: 
3859         (enum agent_op): Fix common/ includes.
3860         * ax-general.c (struct aop_map): Fix common/ includes.
3861         * ax-gdb.c: Fix common/ includes.
3862         * auxv.c: Fix common/ includes.
3863         * auto-load.c: Fix common/ includes.
3864         * arm-tdep.c: Fix common/ includes.
3865         * arch/riscv.c: Fix common/ includes.
3866         * arch/ppc-linux-common.c: Fix common/ includes.
3867         * arch/i386.c: Fix common/ includes.
3868         * arch/arm.c: Fix common/ includes.
3869         * arch/arm-linux.c: Fix common/ includes.
3870         * arch/arm-get-next-pcs.c: Fix common/ includes.
3871         * arch/amd64.c: Fix common/ includes.
3872         * arch/aarch64.c: Fix common/ includes.
3873         * arch/aarch64-insn.c: Fix common/ includes.
3874         * arch-utils.c: Fix common/ includes.
3875         * amd64-windows-tdep.c: Fix common/ includes.
3876         * amd64-tdep.c: Fix common/ includes.
3877         * amd64-sol2-tdep.c: Fix common/ includes.
3878         * amd64-obsd-tdep.c: Fix common/ includes.
3879         * amd64-nbsd-tdep.c: Fix common/ includes.
3880         * amd64-linux-tdep.c: Fix common/ includes.
3881         * amd64-linux-nat.c: Fix common/ includes.
3882         * amd64-fbsd-tdep.c: Fix common/ includes.
3883         * amd64-fbsd-nat.c: Fix common/ includes.
3884         * amd64-dicos-tdep.c: Fix common/ includes.
3885         * amd64-darwin-tdep.c: Fix common/ includes.
3886         * agent.c: Fix common/ includes.
3887         * ada-lang.h: Fix common/ includes.
3888         * ada-lang.c: Fix common/ includes.
3889         * aarch64-tdep.c: Fix common/ includes.
3890
3891 2019-01-25  Tom Tromey  <tom@tromey.com>
3892
3893         * common/create-version.sh: Use common/version.h.
3894
3895 2019-01-24  Pedro Alves  <palves@redhat.com>
3896
3897         * infrun.c (signal_stop, signal_print, signal_program)
3898         (signal_catch, signal_pass): Now arrays instead of pointers.
3899         (update_signals_program_target, do_target_resume)
3900         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
3901         * linux-nat.c (linux_nat_target::pass_signals)
3902         (linux_nat_target::create_inferior, linux_nat_target::attach):
3903         Adjust.
3904         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
3905         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
3906         * procfs.c (procfs_target::pass_signals): Adjust.
3907         * record-full.c (record_full_target::resume): Adjust.
3908         * remote.c (remote_target::pass_signals)
3909         (remote_target::program_signals): Adjust.
3910         * target-debug.h (target_debug_print_signals): Now takes a
3911         gdb::array_view as parameter.  Adjust.
3912         * target.h (target_ops) <pass_signals, program_signals>: Replace
3913         pointer and length parameters with gdb::array_view.
3914         (target_pass_signals, target_program_signals): Likewise.
3915         * target-delegates.c: Regenerate.
3916
3917 2019-01-24  Pedro Alves  <palves@redhat.com>
3918
3919         * common/forward-scope-exit.h
3920         (forward_scope_exit::forward_scope_exit): Pass arguments to
3921         m_bind_function directly, instead of creating a std::bind and
3922         copying that.
3923
3924 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
3925
3926         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
3927         for static members.
3928         (pass_in_v_vfp_candidate): Likewise.
3929
3930 2019-01-23  Tom Tromey  <tom@tromey.com>
3931             Pedro Alves  <palves@redhat.com>
3932
3933         * regcache.c (class regcache_invalidator): Remove.
3934         (regcache::raw_write): Use make_scope_exit.
3935
3936 2019-01-23  Tom Tromey  <tom@tromey.com>
3937
3938         * ui-out.h (class ui_out_emit_type): Update comment.
3939
3940 2019-01-23  Tom Tromey  <tom@tromey.com>
3941
3942         * infrun.c (fetch_inferior_event): Update comment.
3943
3944 2019-01-23  Tom Tromey  <tom@tromey.com>
3945             Pedro Alves  <palves@redhat.com>
3946
3947         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
3948         parameter.
3949         (fetch_inferior_event): Use SCOPE_EXIT.
3950
3951
3952 2019-01-23  Tom Tromey  <tom@tromey.com>
3953             Pedro Alves  <palves@redhat.com>
3954
3955         * infrun.c (disable_thread_events): Delete.
3956         (stop_all_threads): Use SCOPE_EXIT.
3957
3958 2019-01-23  Tom Tromey  <tom@tromey.com>
3959             Pedro Alves  <palves@redhat.com>
3960
3961         * symfile.c: Include forward-scope-exit.h.
3962         (clear_symtab_users_cleanup): Replace forward declaration with
3963         a FORWARD_SCOPE_EXIT.
3964         (syms_from_objfile_1): Use the forward_scope_exit and
3965         gdb::optional instead of cleanup_function.
3966         (reread_symbols): Use the forward_scope_exit instead of
3967         cleanup_function.
3968         (clear_symtab_users_cleanup): Remove function.
3969
3970 2019-01-23  Tom Tromey  <tom@tromey.com>
3971             Pedro Alves  <palves@redhat.com>
3972
3973         * linux-nat.c: Include scope-exit.h.
3974         (cleanup_target_stop): Remove.
3975         (linux_nat_target::static_tracepoint_markers_by_strid): Use
3976         SCOPE_EXIT.
3977
3978 2019-01-23  Tom Tromey  <tom@tromey.com>
3979             Pedro Alves  <palves@redhat.com>
3980
3981         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
3982         (call_function_by_hand_dummy): Use SCOPE_EXIT.
3983
3984 2019-01-23  Tom Tromey  <tom@tromey.com>
3985             Andrew Burgess  <andrew.burgess@embecosm.com>
3986             Pedro Alves  <palves@redhat.com>
3987
3988         * infrun.c (fetch_inferior_event): Use scope_exit.
3989         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
3990         * top.c (execute_command): Use scope_exit.
3991         * breakpoint.c (bpstat_do_actions): Use scope_exit.
3992         * utils.c (do_bpstat_clear_actions_cleanup)
3993         (make_bpstat_clear_actions_cleanup): Remove.
3994
3995 2019-01-23  Tom Tromey  <tom@tromey.com>
3996             Pedro Alves  <palves@redhat.com>
3997
3998         * infrun.c: Include "common/scope-exit.h"
3999         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4000         (wait_for_inferior): Use SCOPE_EXIT.
4001         (fetch_inferior_event): Use scope_exit.
4002
4003 2019-01-23  Tom Tromey  <tom@tromey.com>
4004             Pedro Alves  <palves@redhat.com>
4005
4006         * breakpoint.c (create_breakpoint): Remove cleanup.
4007
4008 2019-01-23  Tom Tromey  <tom@tromey.com>
4009             Andrew Burgess  <andrew.burgess@embecosm.com>
4010             Pedro Alves  <palves@redhat.com>
4011
4012 2019-01-23  Pedro Alves  <palves@redhat.com>
4013
4014         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4015
4016 2019-01-23  Pedro Alves  <palves@redhat.com>
4017             Andrew Burgess  <andrew.burgess@embecosm.com>
4018
4019         * gdbthread.h: Include "common/forward-scope-exit.h".
4020         (scoped_finish_thread_state): Redefine custom class in terms of
4021         forward_scope_exit.
4022
4023 2019-01-23  Pedro Alves  <palves@redhat.com>
4024             Andrew Burgess  <andrew.burgess@embecosm.com>
4025
4026         * common/forward-scope-exit.h: New file.
4027
4028 2019-01-23  Pedro Alves  <palves@redhat.com>
4029             Andrew Burgess  <andrew.burgess@embecosm.com>
4030             Tom Tromey  <tom@tromey.com>
4031
4032         * common/scope-exit.h: New file.
4033
4034 2019-01-23  Pedro Alves  <palves@redhat.com>
4035
4036         * common/preprocessor.h (ESC): Rename to ...
4037         (ESC_PARENS): ... this.
4038         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4039         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4040
4041 2019-01-23  Tom Tromey  <tom@tromey.com>
4042
4043         * language.h (class scoped_switch_to_sym_language_if_auto):
4044         Initialize m_lang in both cases.
4045
4046 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4047
4048         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4049         with XCNEW.
4050
4051 2019-01-22  Tom Tromey  <tom@tromey.com>
4052
4053         * corelow.c: Do not include sys/file.h.
4054
4055 2019-01-22  Tom Tromey  <tom@tromey.com>
4056
4057         * tui/tui-wingeneral.h: Include gdb_curses.h.
4058
4059 2019-01-22  Tom Tromey  <tom@tromey.com>
4060
4061         * source-cache.h (class source_cache) <get_source_lines,
4062         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4063
4064 2019-01-22  Tom Tromey  <tom@tromey.com>
4065
4066         * remote-fileio.h (struct remote_target): Declare.
4067
4068 2019-01-22  Tom Tromey  <tom@tromey.com>
4069
4070         * python/py-arch.c: Do not include py-ref.h.
4071         * python/py-bpevent.c: Do not include py-ref.h.
4072         * python/py-cmd.c: Do not include py-ref.h.
4073         * python/py-continueevent.c: Do not include py-ref.h.
4074         * python/py-event.h: Do not include py-ref.h.
4075         * python/py-evtregistry.c: Do not include py-ref.h.
4076         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4077         * python/py-frame.c: Do not include py-ref.h.
4078         * python/py-framefilter.c: Do not include py-ref.h.
4079         * python/py-function.c: Do not include py-ref.h.
4080         * python/py-infevents.c: Do not include py-ref.h.
4081         * python/py-linetable.c: Do not include py-ref.h.
4082         * python/py-objfile.c: Do not include py-ref.h.
4083         * python/py-param.c: Do not include py-ref.h.
4084         * python/py-prettyprint.c: Do not include py-ref.h.
4085         * python/py-progspace.c: Do not include py-ref.h.
4086         * python/py-symbol.c: Do not include py-ref.h.
4087         * python/py-symtab.c: Do not include py-ref.h.
4088         * python/py-type.c: Do not include py-ref.h.
4089         * python/py-unwind.c: Do not include py-ref.h.
4090         * python/py-utils.c: Do not include py-ref.h.
4091         * python/py-value.c: Do not include py-ref.h.
4092         * python/py-varobj.c: Do not include py-ref.h.
4093         * python/py-xmethods.c: Do not include py-ref.h.
4094         * python/python.c: Do not include py-ref.h.
4095         * varobj.c: Do not include py-ref.h.
4096
4097 2019-01-22  Tom Tromey  <tom@tromey.com>
4098
4099         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4100         keyword for bcache.
4101
4102 2019-01-22  Tom Tromey  <tom@tromey.com>
4103
4104         * compile/compile-cplus-types.c: Remove a comment by #include.
4105
4106 2019-01-22  Tom Tromey  <tom@tromey.com>
4107
4108         * compile/gcc-c-plugin.h: Include compile-internal.h.
4109
4110 2019-01-22  Tom Tromey  <tom@tromey.com>
4111
4112         * stabsread.c (EXTERN): Do not define.
4113         (symnum, next_symbol_text_func, processing_gcc_compilation)
4114         (within_function, global_sym_chain, global_stabs)
4115         (previous_stab_code, this_object_header_files)
4116         (n_this_object_header_files)
4117         (n_allocated_this_object_header_files): Define.
4118         * stabsread.h (EXTERN): Never define.  Use "extern".
4119
4120 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4121
4122         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4123         history_value.
4124
4125 2019-01-21  Tom Tromey  <tom@tromey.com>
4126
4127         * ui-out.c: Fix includes.
4128         * tui/tui-source.c: Fix includes.
4129         * target.c: Fix includes.
4130         * remote.c: Fix includes.
4131         * regcache.c: Fix includes.
4132         * python/py-block.c: Fix includes.
4133         * printcmd.c: Fix includes.
4134         * or1k-tdep.c: Fix includes.
4135         * mi/mi-main.c: Fix includes.
4136         * m32r-tdep.c: Fix includes.
4137         * csky-tdep.c: Fix includes.
4138         * compile/compile-cplus-types.c: Fix includes.
4139         * cli/cli-interp.c: Fix includes.
4140
4141 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4142
4143         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4144         for padding.
4145
4146 2019-01-16  Tom Tromey  <tom@tromey.com>
4147
4148         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4149         earlier.
4150         (struct objfile) <msymbols_range>: Move from top level.
4151         <msymbols>: New method.
4152         (class objfile_msymbols): Remove.
4153         * symtab.c (default_collect_symbol_completion_matches_break_on):
4154         Update.
4155         * symmisc.c (dump_msymbols): Update.
4156         * stabsread.c (scan_file_globals): Update.
4157         * objc-lang.c (info_selectors_command, info_classes_command)
4158         (find_methods): Update.
4159         * minsyms.c (find_solib_trampoline_target): Update.
4160         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4161         * coffread.c (coff_symfile_read): Update.
4162         * ada-lang.c (ada_lookup_simple_minsym)
4163         (ada_collect_symbol_completion_matches): Update.
4164
4165 2019-01-16  Tom Tromey  <tom@tromey.com>
4166
4167         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4168         type.  Remove no-argument constructor.
4169         <iterator::operator++>: Simplify.
4170         <begin>: Update.
4171         <end>: Use minimal_symbol_count.
4172
4173 2019-01-16  Tom Tromey  <tom@tromey.com>
4174
4175         * objfiles.h (struct objfile) <psymtabs>: New method.
4176         (class objfile_psymtabs): Remove.
4177         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
4178         typedef.
4179         <range>: New method.
4180         (require_partial_symbols): Change return type.
4181         * psymtab.c (require_partial_symbols)
4182         (psym_expand_symtabs_matching): Update.
4183         * mdebugread.c (parse_partial_symbols): Update.
4184         * dbxread.c (dbx_end_psymtab): Update.
4185
4186 2019-01-15  Tom Tromey  <tom@tromey.com>
4187
4188         * symtab.c (lookup_objfile_from_block)
4189         (lookup_symbol_in_objfile_symtabs)
4190         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
4191         (find_line_symtab, info_sources_command)
4192         (default_collect_symbol_completion_matches_break_on)
4193         (make_source_files_completion_list): Update.
4194         * symmisc.c (print_objfile_statistics, dump_objfile)
4195         (maintenance_print_symbols, maintenance_info_symtabs)
4196         (maintenance_check_symtabs, maintenance_info_line_tables):
4197         Update.
4198         * source.c (select_source_symtab)
4199         (forget_cached_source_info_for_objfile): Update.
4200         * objfiles.h (class objfile_compunits): Remove.
4201         (struct objfile) <compunits_range>: New typedef.
4202         (compunits): New method.
4203         * objfiles.c (objfile_relocate1): Update.
4204         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4205         * maint.c (count_symtabs_and_blocks): Update.
4206         * linespec.c (iterate_over_all_matching_symtabs): Update.
4207         * cp-support.c (add_symbol_overload_list_qualified): Update.
4208         * coffread.c (coff_symtab_read): Update.
4209         * ada-lang.c (add_nonlocal_symbols)
4210         (ada_collect_symbol_completion_matches)
4211         (ada_add_global_exceptions): Update.
4212
4213 2019-01-15  Tom Tromey  <tom@tromey.com>
4214
4215         * progspace.h (program_space) <objfiles_safe_range>: New
4216         typedef.
4217         <objfiles_safe>: New method.
4218         * objfiles.h (class all_objfiles_safe): Remove.
4219         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4220         * jit.c (jit_inferior_exit_hook): Update.
4221
4222 2019-01-17  Tom Tromey  <tom@tromey.com>
4223
4224         * progspace.h (program_space) <objfiles_range>: New typedef.
4225         <objfiles>: New method.
4226         <objfiles_head>: Rename from objfiles.
4227         (object_files): Update.
4228         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4229         * guile/scm-pretty-print.c
4230         (ppscm_find_pretty_printer_from_objfiles): Update.
4231         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4232         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4233         Update.
4234         * python/py-progspace.c (pspy_get_objfiles): Update.
4235         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4236         Update.
4237         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4238         (objfpy_lookup_objfile_by_build_id): Update.
4239         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4240         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4241         Update.
4242         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4243         (expand_symtab_containing_pc, lookup_objfile_from_block)
4244         (lookup_static_symbol, basic_lookup_transparent_type)
4245         (find_pc_sect_compunit_symtab, find_symbol_at_address)
4246         (find_line_symtab, info_sources_command)
4247         (default_collect_symbol_completion_matches_break_on)
4248         (make_source_files_completion_list, find_main_name): Update.
4249         * symmisc.c (print_symbol_bcache_statistics)
4250         (print_objfile_statistics, maintenance_print_symbols)
4251         (maintenance_print_msymbols, maintenance_print_objfiles)
4252         (maintenance_info_symtabs, maintenance_check_symtabs)
4253         (maintenance_expand_symtabs, maintenance_info_line_tables):
4254         Update.
4255         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
4256         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
4257         (map_overlay_command, unmap_overlay_command)
4258         (simple_overlay_update, expand_symtabs_matching)
4259         (map_symbol_filenames): Update.
4260         * symfile-debug.c (set_debug_symfile): Update.
4261         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
4262         Update.
4263         * source.c (select_source_symtab, forget_cached_source_info):
4264         Update.
4265         * solib.c (solib_read_symbols): Update.
4266         * solib-spu.c (append_ocl_sos): Update.
4267         * psymtab.c (maintenance_print_psymbols)
4268         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
4269         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
4270         * printcmd.c (info_symbol_command): Update.
4271         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
4272         Update.
4273         * objfiles.h (class all_objfiles): Remove.
4274         * objfiles.c (have_partial_symbols, have_full_symbols)
4275         (have_minimal_symbols, qsort_cmp, update_section_map)
4276         (shared_objfile_contains_address_p)
4277         (default_iterate_over_objfiles_in_search_order): Update.
4278         * objc-lang.c (info_selectors_command, info_classes_command)
4279         (find_methods): Update.
4280         * minsyms.c (find_solib_trampoline_target): Update.
4281         * maint.c (maintenance_info_sections)
4282         (maintenance_translate_address, count_symtabs_and_blocks):
4283         Update.
4284         * main.c (captured_main_1): Update.
4285         * linux-thread-db.c (try_thread_db_load_from_pdir)
4286         (has_libpthread): Update.
4287         * linespec.c (iterate_over_all_matching_symtabs)
4288         (search_minsyms_for_name): Update.
4289         * jit.c (jit_find_objf_with_entry_addr): Update.
4290         * hppa-tdep.c (find_unwind_entry)
4291         (hppa_lookup_stub_minimal_symbol): Update.
4292         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
4293         Update.
4294         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4295         (elf_gnu_ifunc_resolve_by_got): Update.
4296         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
4297         * dwarf-index-write.c (save_gdb_index_command): Update.
4298         * cp-support.c (add_symbol_overload_list_qualified): Update.
4299         * breakpoint.c (create_overlay_event_breakpoint)
4300         (create_longjmp_master_breakpoint)
4301         (create_std_terminate_master_breakpoint)
4302         (create_exception_master_breakpoint): Update.
4303         * blockframe.c (find_pc_partial_function): Update.
4304         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
4305         (ada_collect_symbol_completion_matches)
4306         (ada_add_global_exceptions): Update.
4307
4308 2019-01-17  Tom Tromey  <tom@tromey.com>
4309
4310         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
4311         declare VEC.
4312         (solib_target_parse_libraries): Change return type.
4313         (library_list_start_segment, library_list_start_section)
4314         (library_list_end_library, library_list_start_library); Update.
4315         (solib_target_free_library_list): Remove.
4316         (solib_target_parse_libraries): Remove cleanup.  Change return
4317         type.
4318         (solib_target_current_sos): Update.
4319
4320 2019-01-17  Tom Tromey  <tromey@bapiya>
4321
4322         * valprint.c: Replace "the the" with "the".
4323         * symtab.c: Replace "the the" with "the".
4324         * solib.c: Replace "the the" with "the".
4325         * solib-dsbt.c: Replace "the the" with "the".
4326         * linespec.c: Replace "the the" with "the".
4327         * dwarf2loc.h: Replace "the the" with "the".
4328         * amd64-windows-tdep.c: Replace "the the" with "the".
4329         * aarch64-tdep.c: Replace "the the" with "the".
4330
4331 2019-01-16  Keith Seitz  <keiths@redhat.com>
4332
4333         PR gdb/23773
4334         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
4335         <builder>: Rename to ..
4336         <m_builder>: ... this and make private.
4337         (dwarf2_cu::get_builder): New method.  Change all users of
4338         `builder' to use this method.
4339         (dwarf2_start_symtab): Move to ...
4340         (dwarf2_cu::start_symtab): ... here.  Update all callers
4341         (setup_type_unit_groups): Move to ...
4342         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
4343         callers.
4344         (dwarf2_cu::reset_builder): New method.
4345         (process_full_compunit, process_full_type_unit): Use
4346         dwarf2_cu::reset_builder.
4347         (follow_die_offset): Record the ancestor CU if it is different
4348         from the followed DIE's CU.
4349         (follow_die_sig_1): Likewise.
4350
4351 2019-01-15  Tom Tromey  <tom@tromey.com>
4352
4353         * remote.c (class remote_state) <buf>: Now a char_vector.
4354         <buf_size>: Remove.
4355         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
4356         parameter.
4357         (remote_target::getpkt_or_notif_sane_1)
4358         (remote_target::getpkt_sane)
4359         (remote_target::getpkt_or_notif_sane): Likewise.
4360         (class remote_target) <putpkt>: New overload.
4361         (remote_target::read_frame): Change type of "buf_p".  Remove
4362         sizeof_p parameter.
4363         (packet_ok): New overload.
4364         (packet_check_result): New overload.
4365         Update all uses.
4366
4367 2019-01-14  Tom Tromey  <tom@tromey.com>
4368
4369         * remote-notif.c (handle_notification, remote_notif_ack)
4370         (remote_notif_parse): Make "buf" const.
4371         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
4372         const.
4373         (remote_notif_parse, remote_notif_ack, handle_notification):
4374         Likewise.
4375         * remote.c (remote_notif_stop_parse): Make "buf" const.
4376         (remote_target::remote_parse_stop_reply): Make "buf" const.
4377         (remote_notif_stop_ack): Make "buf" const.
4378
4379 2019-01-14  Tom Tromey  <tom@tromey.com>
4380
4381         * remote.c (remote_console_output): Make parameter const.
4382
4383 2019-01-14  Tom Tromey  <tom@tromey.com>
4384
4385         * target-debug.h (target_debug_print_signals): Constify.
4386         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
4387         * procfs.c (procfs_target::pass_signals): Update.
4388         * linux-nat.c (linux_nat_target::pass_signals): Update.
4389         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
4390         * target-delegates.c: Rebuild.
4391         * remote.c (remote_target::program_signals): Update.
4392         (remote_target::pass_signals): Update.
4393         * target.c (target_pass_signals): Constify argument.
4394         (target_program_signals): Likewise.
4395         * target.h (struct target_ops) <pass_signals, program_signals>:
4396         Constify argument.
4397         (target_pass_signals, target_program_signals): Constify argument.
4398
4399 2019-01-14  Tom Tromey  <tom@tromey.com>
4400
4401         PR tui/28819:
4402         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
4403
4404 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4405
4406         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
4407         field.
4408         * rs6000-tdep.c: Include reggroups.h.
4409         (IS_V_ALIAS_PSEUDOREG): Define.
4410         (rs6000_register_name): Return names for the "vX" aliases.
4411         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
4412         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
4413         aliases.  Call default_register_reggroup_p for all other
4414         pseudo-registers.
4415         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
4416         New functions.
4417         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
4418         Handle "vX" aliases.
4419         (v_alias_pseudo_register_collect): New function.
4420         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
4421         (rs6000_gdbarch_init): Initialize "vX" aliases as
4422         pseudo-registers.  Restore registration of
4423         rs6000_pseudo_register_reggroup_p with
4424         set_tdesc_pseudo_register_reggroup_p.
4425
4426 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
4427
4428         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
4429         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
4430         set_gdbarch_num_pseudo_regs.
4431
4432 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4433
4434         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
4435         Remove arg prefixname, add do_set and do_show.
4436         Add member functions set_list and show_list.
4437         * cli/cli-style.c (class cli_style_option): Update accordingly.
4438         (style_set_list): Move to file scope.
4439         (style_show_list): Likewise.
4440         (set_style): Call help_list.
4441         (show_style): Call cmd_show_list.
4442         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
4443         Update to use the new macro.
4444
4445 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
4446
4447         * ada-lang.c (_initialize_ada_language): Expand the help text
4448         for the "catch exception" command.
4449
4450 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4451
4452         * symtab.c (matching_obj_sections): Initialize obj,
4453         declare it closer to its usage.
4454
4455 2019-01-10  Tom Tromey  <tom@tromey.com>
4456
4457         * thread-iter.h (inf_threads_iterator): Use next_iterator.
4458         (basic_inf_threads_range): Remove.
4459         (inf_threads_range, inf_non_exited_threads_range)
4460         (safe_inf_threads_range): Use next_adapter.
4461
4462 2019-01-10  Keith Seitz  <keiths@redhat.com>
4463
4464         PR gdb/23712
4465         PR symtab/23010
4466         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
4467         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
4468
4469 2019-01-10  Keith Seitz  <keiths@redhat.com>
4470
4471         PR gdb/23712
4472         PR symtab/23010
4473         * dictionary.c (pending_to_vector): Remove.
4474         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4475         Remove _1 suffix, replacing functions of the same name.  Update
4476         all callers.
4477         (dict_create_hashed, dict_create_hashed_expandable)
4478         (dict_create_linear, dict_create_linear_expandable, dict_free)
4479         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
4480         Make functions static.
4481
4482 2019-01-10  Keith Seitz  <keiths@redhat.com>
4483
4484         PR gdb/23712
4485         PR symtab/23010
4486         * dictionary.h (struct dictionary): Replace declaration with
4487         multidictionary.
4488         (dict_create_hashed, dict_create_hashed_expandable)
4489         (dict_create_linear, dict_create_linear_expandable)
4490         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
4491         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
4492         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
4493         taking multidictionary argument.
4494         [ALL_DICT_SYMBOLS]: Update for multidictionary.
4495         * block.h (struct block) <dict>: Change to multidictionary
4496         and rename `multidict'.
4497         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
4498         symmisc.c: Update all dictionary references to multidictionary.
4499
4500 2019-01-10  Keith Seitz  <keiths@redhat.com>
4501
4502         PR gdb/23712
4503         PR symtab/23010
4504         * dictionary.c: Include unordered_map.
4505         (pending_to_vector): New function.
4506         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4507         Rewrite the non-"_1" functions to take vector instead
4508         of linked list.
4509         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
4510         "new" _1 versions of the same name.
4511         (multidictionary): Define.
4512         (std::hash<enum language): New definition.
4513         (collate_pending_symbols_by_language, mdict_create_hashed)
4514         (mdict_create_hashed_expandable, mdict_create_linear)
4515         (mdict_create_linear_expandable, mdict_free)
4516         (find_language_dictionary, create_new_language_dictionary)
4517         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
4518         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
4519         (mdict_size, mdict_empty): New functions.
4520         * dictionary.h (mdict_iterator): Define.
4521
4522 2019-01-10  Pedro Alves  <palves@redhat.com>
4523
4524         * breakpoint.c (read_uploaded_action)
4525         (create_tracepoint_from_upload): Adjust to use
4526         gdb::unique_xmalloc_ptr.
4527         * ctf.c (ctf_write_uploaded_tp):
4528         (SET_ARRAY_FIELD): Use emplace_back.
4529         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
4530         * tracefile-tfile.c (tfile_write_uploaded_tp):
4531         * tracepoint.c (parse_tracepoint_definition): Adjust to use
4532         gdb::unique_xmalloc_ptr.
4533         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
4534         at_string, cond_string, cmd_strings>: Replace char pointers
4535         with gdb::unique_xmalloc_ptr.
4536
4537 2019-01-10  Pedro Alves  <palves@redhat.com>
4538
4539         * solib-target.c (library_list_start_library): Don't xstrdup name.
4540
4541 2019-01-10  Pedro Alves  <palves@redhat.com>
4542
4543         * mdebugread.c (parse_partial_symbols): Use
4544         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
4545
4546 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4547
4548         * linux-fork.c (scoped_switch_fork_info)
4549         <~scoped_switch_fork_info>: Fix incorrect variable name.
4550
4551 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4552
4553         * linux-fork.c (scoped_switch_fork_info)
4554         <scoped_switch_fork_info>: Make explicit.
4555         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
4556
4557 2019-01-10  Tom Tromey  <tom@tromey.com>
4558
4559         * objfiles.h (objfile::reset_psymtabs): Update.
4560         * objfiles.c (objfile::objfile): Update.
4561         * psymtab.h (psymtab_storage::obstack): Update.
4562         (psymtab_storage::m_obstack): Use gdb::optional.
4563         (class psymtab_storage): Update comment.  Remove objfile
4564         parameter.
4565         * psymtab.c (psymtab_storage::psymtab_storage): Update.
4566
4567 2019-01-10  Tom Tromey  <tom@tromey.com>
4568
4569         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
4570         <free_psymtabs>: Now private.
4571         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
4572         (allocate_psymtab): Use new method.
4573
4574 2019-01-10  Tom Tromey  <tom@tromey.com>
4575
4576         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
4577         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
4578         * mdebugread.c (parse_partial_symbols): Use
4579         allocate_dependencies.
4580         * dwarf2read.c (dwarf2_create_include_psymtab): Use
4581         allocate_dependencies.
4582         (process_psymtab_comp_unit_reader)
4583         (build_type_psymtab_dependencies): Likewise.
4584         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
4585
4586 2019-01-10  Tom Tromey  <tom@tromey.com>
4587
4588         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
4589         PSYMBOL_SET_LANGUAGE.
4590         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
4591
4592 2019-01-10  Tom Tromey  <tom@tromey.com>
4593
4594         * psymtab.h (psymtab_storage::obstack): New method.
4595         <m_obstack>: Rename from obstack; now private.
4596         * psymtab.c (psymtab_storage): Update.
4597         * dwarf2read.c (create_addrmap_from_index)
4598         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
4599         Update.
4600
4601 2019-01-10  Tom Tromey  <tom@tromey.com>
4602
4603         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
4604         * objfiles.h (objfile::reset_psymtabs): New method.
4605
4606 2019-01-10  Tom Tromey  <tom@tromey.com>
4607
4608         * symmisc.c (print_symbol_bcache_statistics): Update.
4609         (print_objfile_statistics): Update.
4610         * symfile.c (reread_symbols): Update.
4611         * psymtab.h (class psymtab_storage): New.
4612         * psymtab.c (psymtab_storage): New constructor.
4613         (~psymtab_storage): New destructor.
4614         (require_partial_symbols): Update.
4615         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
4616         (find_pc_sect_psymtab, find_pc_sect_psymbol)
4617         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
4618         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
4619         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
4620         (start_psymtab_common, end_psymtab_common)
4621         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
4622         (allocate_psymtab): Update.
4623         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
4624         Update.
4625         (dump_psymtab_addrmap, maintenance_print_psymbols)
4626         (maintenance_check_psymtabs): Update.
4627         (class objfile_psymtabs): Move to objfiles.h.
4628         * psympriv.h (discard_psymtab): Now inline.
4629         (psymtab_discarder::psymtab_discarder): Update.
4630         (psymtab_discarder::~psymtab_discarder): Update.
4631         (ALL_OBJFILE_PSYMTABS): Rewrite.
4632         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
4633         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
4634         Remove fields.
4635         <partial_symtabs>: New field.
4636         (class objfile_psymtabs): Move from psymtab.h.  Update.
4637         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
4638         psymbol_cache.
4639         (objfile::~objfile): Don't destroy psymbol_cache.
4640         * mdebugread.c (parse_partial_symbols): Update.
4641         * dwarf2read.c (create_addrmap_from_index)
4642         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4643         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
4644         (add_partial_subprogram, dwarf2_ranges_read): Update.
4645         * dwarf-index-write.c (write_address_map)
4646         (write_one_signatured_type, recursively_write_psymbols)
4647         (class debug_names, class debug_names, write_psymtabs_to_index):
4648         Update.
4649
4650 2019-01-10  Tom Tromey  <tom@tromey.com>
4651
4652         * symtab.h (SYMBOL_SET_NAMES): Update.
4653         (symbol_set_names): Update.
4654         (MSYMBOL_SET_NAMES): Update.
4655         * symtab.c (symbol_set_names): Change argument to be an
4656         objfile_per_bfd_storage.
4657         * psymtab.c (add_psymbol_to_bcache): Update.
4658         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
4659
4660 2019-01-10  Tom Tromey  <tom@tromey.com>
4661
4662         * symtab.c (create_demangled_names_hash): Change argument to be an
4663         objfile_per_bfd_storage.
4664         (symbol_set_names): Update.
4665
4666 2019-01-10  Tom Tromey  <tom@tromey.com>
4667
4668         * xcoffread.c (xcoff_initial_scan): Unconditionally call
4669         init_psymbol_list.
4670         * psymtab.c (init_psymbol_list): Do nothing if already called.
4671         * psympriv.h (init_psymbol_list): Add comment.
4672         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
4673         init_psymbol_list.
4674         * dbxread.c (dbx_symfile_read): Unconditionally call
4675         init_psymbol_list.
4676
4677 2019-01-10  Tom Tromey  <tom@tromey.com>
4678
4679         * xcoffread.c (scan_xcoff_symtab): Update.
4680         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
4681         "where".
4682         * mdebugread.c (parse_partial_symbols)
4683         (handle_psymbol_enumerators): Update.
4684         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
4685         * dbxread.c (read_dbx_symtab): Update.
4686         * psympriv.h (psymbol_placement): New enum.
4687         (add_psymbol_to_list): Update.
4688
4689 2019-01-10  Tom Tromey  <tom@tromey.com>
4690
4691         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
4692         static_psymbols parameters.
4693         (scan_xcoff_symtab): Update.
4694         * psymtab.c (start_psymtab_common): Remove global_psymbols and
4695         static_psymbols parameters.
4696         * psympriv.h (start_psymtab_common): Update.
4697         * mdebugread.c (parse_partial_symbols): Update.
4698         * dwarf2read.c (create_partial_symtab): Update.
4699         * dbxread.c (read_dbx_symtab): Update.
4700         (start_psymtab): Remove global_psymbols and static_psymbols
4701         parameters.
4702
4703 2019-01-10  Tom Tromey  <tom@tromey.com>
4704
4705         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
4706         * psymtab.c (allocate_psymtab): Add comment.
4707         * psympriv.h (allocate_psymtab): Add comment.
4708         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
4709         initializations.
4710         * dbxread.c (dbx_end_psymtab): Remove some initializations.
4711
4712 2019-01-10  Tom Tromey  <tom@tromey.com>
4713
4714         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4715         Don't declare.
4716         * mipsread.c: Include mdebugread.h.
4717         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4718         Declare.
4719         * elfread.c: Include mdebugread.h.
4720
4721 2019-01-09  Tom Tromey  <tom@tromey.com>
4722
4723         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
4724         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
4725         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
4726         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
4727         (psym_lookup_symbol, psym_find_last_source_symtab)
4728         (psym_forget_cached_source_info, psym_print_stats)
4729         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
4730         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
4731         (psym_map_matching_symbols, psym_expand_symtabs_matching)
4732         (psym_find_compunit_symtab_by_address)
4733         (maintenance_print_psymbols, maintenance_info_psymtabs)
4734         (maintenance_check_psymtabs): Use ranged for.
4735         * psymtab.h (class objfile_psymtabs): New.
4736         (require_partial_symbols): Return objfile_psymtabs.
4737         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
4738
4739 2019-01-09  Tom Tromey  <tom@tromey.com>
4740
4741         * symfile.c (overlay_invalidate_all, find_pc_overlay)
4742         (find_pc_mapped_section, list_overlays_command)
4743         (map_overlay_command, unmap_overlay_command)
4744         (simple_overlay_update): Use all_objfiles.
4745         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
4746         * printcmd.c (info_symbol_command): Use all_objfiles.
4747         * objfiles.h (ALL_OBJSECTIONS): Remove.
4748         * maint.c (maintenance_translate_address): Use all_objfiles.
4749         * gcore.c (gcore_create_callback): Use all_objfiles.
4750         (objfile_find_memory_regions): Likewise.
4751
4752 2019-01-09  Tom Tromey  <tom@tromey.com>
4753
4754         * symtab.c (find_line_symtab, info_sources_command)
4755         (make_source_files_completion_list): Use objfile_compunits.
4756         * source.c (select_source_symtab): Use objfile_compunits.
4757         * objfiles.h (struct objfile): Update comment.
4758         (ALL_OBJFILES): Remove.
4759         (ALL_FILETABS): Remove.
4760         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
4761         objfile_compunits.
4762
4763 2019-01-09  Tom Tromey  <tom@tromey.com>
4764
4765         * symmisc.c (print_objfile_statistics, dump_objfile)
4766         (maintenance_print_symbols): Use compunit_filetabs.
4767         * source.c (forget_cached_source_info_for_objfile): Use
4768         compunit_filetabs.
4769         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
4770         (ALL_FILETABS): Use compunit_filetabs.
4771         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
4772         * coffread.c (coff_symtab_read): Use compunit_filetabs.
4773
4774 2019-01-09  Tom Tromey  <tom@tromey.com>
4775
4776         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
4777         (compunit_filetabs): New.
4778         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
4779         compunit_filetabs.
4780         (info_sources_command, make_source_files_completion_list): Remove
4781         declaration.
4782         * symmisc.c (print_objfile_statistics, dump_objfile)
4783         (maintenance_print_symbols): Remove declaration.
4784         (maintenance_info_symtabs): Use compunit_filetabs.
4785         (maintenance_info_line_tables): Likewise.
4786         * source.c (select_source_symtab): Change local variable name.
4787         (forget_cached_source_info_for_objfile): Remove declaration.
4788         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
4789         * objfiles.c (objfile_relocate1): Remove declaration.
4790         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4791         declaration.
4792         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
4793         * coffread.c (coff_symtab_read): Remove declaration.
4794         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4795         compunit_filetabs.
4796
4797 2019-01-09  Tom Tromey  <tom@tromey.com>
4798
4799         * symtab.c (lookup_objfile_from_block)
4800         (find_pc_sect_compunit_symtab, search_symbols)
4801         (default_collect_symbol_completion_matches_break_on): Use
4802         objfile_compunits.
4803         * objfiles.h (ALL_COMPUNITS): Remove.
4804         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
4805         * cp-support.c (add_symbol_overload_list_qualified): Use
4806         objfile_compunits.
4807         * ada-lang.c (ada_collect_symbol_completion_matches)
4808         (ada_add_global_exceptions): Use objfile_compunits.
4809
4810 2019-01-09  Tom Tromey  <tom@tromey.com>
4811
4812         * source.c (select_source_symtab)
4813         (forget_cached_source_info_for_objfile): Remove declaration.
4814         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4815         declaration.
4816         * maint.c (count_symtabs_and_blocks): Remove declaration.
4817         * cp-support.c (add_symbol_overload_list_qualified): Remove
4818         declaration.
4819         * coffread.c (coff_symtab_read): Remove declaration.
4820         * symtab.c (lookup_symbol_in_objfile_symtabs)
4821         (basic_lookup_transparent_type_1): Use objfile_compunits.
4822         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
4823         (info_sources_command, search_symbols)
4824         (default_collect_symbol_completion_matches_break_on)
4825         (make_source_files_completion_list): Remove declaration.
4826         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
4827         (ada_collect_symbol_completion_matches)
4828         (ada_add_global_exceptions): Remove declaration.
4829         * linespec.c (iterate_over_all_matching_symtabs): Use
4830         objfile_compunits.
4831         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
4832         (class objfile_compunits): New.
4833         (ALL_COMPUNITS): Use objfile_compunits.
4834         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
4835         (maintenance_check_symtabs, maintenance_info_line_tables): Use
4836         objfile_compunits.
4837         * objfiles.c (objfile_relocate1): Use objfile_compunits.
4838
4839 2019-01-09  Tom Tromey  <tom@tromey.com>
4840
4841         * symtab.c (search_symbols)
4842         (default_collect_symbol_completion_matches_break_on): Use
4843         objfile_msymbols.
4844         * ada-lang.c (ada_lookup_simple_minsym)
4845         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
4846         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
4847         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
4848         objfile_msymbols.
4849         * coffread.c (coff_symfile_read): Use objfile_msymbols.
4850         * symmisc.c (dump_msymbols): Use objfile_msymbols.
4851         * objc-lang.c (find_methods): Use objfile_msymbols.
4852         (info_selectors_command, info_classes_command): Likewise.
4853         * stabsread.c (scan_file_globals): Use objfile_msymbols.
4854         * objfiles.h (class objfile_msymbols): New.
4855         (ALL_OBJFILE_MSYMBOLS): Remove.
4856         (ALL_MSYMBOLS): Remove.
4857
4858 2019-01-09  Tom Tromey  <tom@tromey.com>
4859
4860         * common/next-iterator.h (next_adapter): Add Iterator template
4861         parameter.
4862         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
4863         (class all_objfiles_safe): New.
4864         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
4865         * objfiles.c (put_objfile_before): Update comment.
4866         (add_separate_debug_objfile): Likewise.
4867         (free_all_objfiles): Use all_objfiles_safe.
4868         (objfile_purge_solibs): Likewise.
4869
4870 2019-01-09  Tom Tromey  <tom@tromey.com>
4871
4872         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4873         (expand_symtab_containing_pc, lookup_static_symbol)
4874         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
4875         (find_symbol_at_address, find_line_symtab, find_main_name): Use
4876         all_objfiles.
4877         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
4878         * breakpoint.c (create_overlay_event_breakpoint)
4879         (create_longjmp_master_breakpoint)
4880         (create_std_terminate_master_breakpoint)
4881         (create_exception_master_breakpoint): Use all_objfiles.
4882         * linux-thread-db.c (try_thread_db_load_from_pdir)
4883         (has_libpthread): Use all_objfiles.
4884         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
4885         * linespec.c (iterate_over_all_matching_symtabs)
4886         (search_minsyms_for_name): Use all_objfiles.
4887         * maint.c (maintenance_info_sections): Use all_objfiles.
4888         * main.c (captured_main_1): Use all_objfiles.
4889         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
4890         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
4891         * guile/scm-pretty-print.c
4892         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
4893         * solib-spu.c (append_ocl_sos): Use all_objfiles.
4894         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
4895         (maintenance_print_msymbols): Use all_objfiles.
4896         * source.c (select_source_symtab): Use all_objfiles.
4897         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
4898         * symfile.c (remove_symbol_file_command)
4899         (expand_symtabs_matching, map_symbol_filenames): Use
4900         all_objfiles.
4901         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
4902         all_objfiles.
4903         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
4904         * objc-lang.c (find_methods): Use all_objfiles.
4905         * objfiles.c (have_partial_symbols, have_full_symbols)
4906         (have_minimal_symbols, qsort_cmp)
4907         (default_iterate_over_objfiles_in_search_order): Use
4908         all_objfiles.
4909         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
4910         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
4911         (maintenance_check_psymtabs): Use all_objfiles.
4912         (ALL_PSYMTABS): Remove.
4913         * compile/compile-object-run.c (do_module_cleanup): Use
4914         all_objfiles.
4915         * blockframe.c (find_pc_partial_function): Use all_objfiles.
4916         * cp-support.c (add_symbol_overload_list_qualified): Use
4917         all_objfiles.
4918         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4919         Use all_objfiles.
4920         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
4921         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
4922         all_objfiles.
4923         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4924         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
4925         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4926         Uses all_objfiles.
4927         * solib.c (solib_read_symbols): Use all_objfiles
4928
4929 2019-01-09  Tom Tromey  <tom@tromey.com>
4930
4931         * probe.c (parse_probes_in_pspace): Use all_objfiles.
4932         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
4933         all_objfiles.
4934         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
4935         * symmisc.c (print_symbol_bcache_statistics)
4936         (print_objfile_statistics, maintenance_print_objfiles)
4937         (maintenance_info_symtabs, maintenance_check_symtabs)
4938         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
4939         all_objfiles.
4940         * source.c (forget_cached_source_info): Use all_objfiles.
4941         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
4942         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4943         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
4944         * objfiles.c (update_section_map): Use all_objfiles.
4945         (shared_objfile_contains_address_p): Likewise.
4946         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
4947         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
4948
4949 2019-01-09  Tom Tromey  <tom@tromey.com>
4950
4951         * common/next-iterator.h: New file.
4952         * objfiles.h (class all_objfiles): New.
4953         (struct objfile_iterator): New.
4954
4955 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4956
4957         * NEWS: Move the description of the changed "frame", "select-frame",
4958          and "info frame" commands to the Changed commands section.
4959
4960 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
4961
4962         * gdbtypes.c (check_stub_method_group): Remove handling of old
4963         mangling schemes.
4964         * linespec.c (find_methods): Likewise.
4965         * stabsread.c (read_member_functions): Likewise.
4966         * valops.c (search_struct_method): Likewise.
4967         (value_struct_elt_for_reference): Likewise.
4968         * NEWS: Mention this change.
4969
4970 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4971
4972         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
4973         print_source_lines.
4974         * source.c (print_source_lines_base): Update line number check.
4975         (print_source_lines): New function.
4976         (source_lines_range::source_lines_range): New function.
4977         * source.h (class source_lines_range): New class.
4978         (print_source_lines): New declaration.
4979
4980 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4981
4982         * linespec.c (linespec_state_destructor): Free self->canonical_names.
4983
4984 2019-01-08  Tom Tromey  <tom@tromey.com>
4985             Simon Marchi  <simon.marchi@ericsson.com>
4986
4987         PR gdb/24060
4988         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
4989         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
4990         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
4991         * f-exp.y (DOLLAR_VARIABLE): Likewise.
4992         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
4993         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
4994
4995 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4996
4997         * source.c (select_source_symtab): Move header comment to
4998         declaration in source.h.
4999         (forget_cached_source_info_for_objfile): Likewise.
5000         (forget_cached_source_info): Likewise.
5001         (identify_source_line): Likewise.
5002         * source.h (identify_source_line): Move declaration from symtab.h
5003         and add comment from source.c
5004         (print_source_lines): Likewise.
5005         (forget_cached_source_info_for_objfile): Likewise.
5006         (forget_cached_source_info): Likewise.
5007         (select_source_symtab): Likewise.
5008         (enum print_source_lines_flag): Move definition from symtab.h.
5009         * symtab.h (identify_source_line): Move declaration to source.h.
5010         (print_source_lines): Likewise.
5011         (forget_cached_source_info_for_objfile): Likewise.
5012         (forget_cached_source_info): Likewise.
5013         (select_source_symtab): Likewise.
5014         (enum print_source_lines_flag): Move definition to source.h.
5015         * tui/tui-hooks.c: Add 'source.h' include.
5016
5017 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5018
5019         * source.c (print_source_lines_base): Handle requests to print
5020         reverse line number sequences, and guard against empty lines
5021         string.
5022
5023 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5024
5025         * source.c (print_source_lines_base): Fix skip of '\r' if next
5026         character is '\n'.
5027
5028 2019-01-06  Tom Tromey  <tom@tromey.com>
5029
5030         * c-exp.y (struct c_parse_state) <macro_original_text,
5031         expansion_obstack>: New member.
5032         (macro_original_text, expansion_obstack): Remove globals.
5033         (scan_macro_expansion, scanning_macro_expansion)
5034         (finished_macro_expansion): Update.
5035         (scan_macro_cleanup): Remove.
5036         (yylex, c_parse): Update.
5037
5038 2019-01-06  Tom Tromey  <tom@tromey.com>
5039
5040         * c-exp.y (struct c_parse_state) <strings>: New member.
5041         (operator_stoken): Update.
5042
5043 2019-01-06  Tom Tromey  <tom@tromey.com>
5044
5045         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5046         (union type_stack_elt) <typelist_val>: Now a pointer to
5047         std::vector.
5048         (type_stack_cleanup): Don't declare.
5049         (push_typelist): Update.
5050         * parse.c (pop_typelist): Return a std::vector.
5051         (push_typelist): Take a std::vector.
5052         (follow_types): Update.  Do not free args.
5053         (type_stack_cleanup): Remove.
5054         * c-exp.y (struct c_parse_state): New.
5055         (cpstate): New global.
5056         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5057         (nonempty_typelist): Update.
5058         (func_mod): Create a new vector.
5059         (c_parse): Create a c_parse_state.
5060         (check_parameter_typelist): Do not delete params.
5061         (function_method): Update.  Do not delete type_list.
5062
5063 2019-01-06  Tom Tromey  <tom@tromey.com>
5064
5065         PR gdb/28155:
5066         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5067         check_typedef.
5068         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5069         (print_return_value): Likewise.
5070
5071 2019-01-05  Tom Tromey  <tom@tromey.com>
5072
5073         * contrib/cleanup_check.py: Remove.
5074         * contrib/gcc-with-excheck: Remove.
5075         * contrib/exsummary.py: Remove.
5076         * contrib/excheck.py: Remove.
5077
5078 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5079
5080         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5081         NULL. Initialize tpprev to NULL instead of assigning it
5082         to NULL on the next statement.
5083         * windows-nat.c (windows_delete_thread): Remove check for
5084         main_thread_id before printing thread exit notifications.
5085         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5086         Remove thread ID check against main_thread_id.
5087         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5088         windows_delete_thread.
5089         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5090
5091 2019-01-04  Tom Tromey  <tom@tromey.com>
5092
5093         * compile/compile.c (_initialize_compile): Use upper case for
5094         metasyntactic variables.
5095         * symmisc.c (_initialize_symmisc): Use upper case for
5096         metasyntactic variables.
5097         * psymtab.c (_initialize_psymtab): Use upper case for
5098         metasyntactic variables.
5099         * demangle.c (demangle_command): Use upper case for metasyntactic
5100         variables.
5101         (_initialize_demangler): Likewise.
5102         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5103         variables.
5104
5105 2019-01-03  Tom Tromey  <tom@tromey.com>
5106
5107         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5108
5109 2019-01-03  Tom Tromey  <tom@tromey.com>
5110
5111         * python/py-symtab.c (salpy_str): Update.
5112         (struct salpy_sal_object) <symtab>: Now a PyObject.
5113         (salpy_dealloc): Update.
5114         (del_objfile_sal): Use gdbpy_ref.
5115
5116 2019-01-03  Tom Tromey  <tom@tromey.com>
5117
5118         * python/py-type.c (convert_field): Use new_reference.  Return
5119         gdbpy_ref.
5120         (make_fielditem): Return gdbpy_ref.
5121         (typy_fields): Update.
5122         (typy_getitem): Update.
5123         (field_name): Return gdbpy_ref.  Use new_reference.
5124         (typy_iterator_iternext): Update.
5125
5126 2019-01-03  Tom Tromey  <tom@tromey.com>
5127
5128         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5129
5130 2019-01-03  Tom Tromey  <tom@tromey.com>
5131
5132         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5133         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5134         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5135         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5136         (pspy_set_type_printers): Likewise.
5137         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5138         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5139         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5140         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5141         (objfpy_set_type_printers): Likewise.
5142
5143 2019-01-03  Tom Tromey  <tom@tromey.com>
5144
5145         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5146         (gdbpy_print_stack): Use gdbpy_err_fetch.
5147         * python/python-internal.h (class gdbpy_err_fetch): New class.
5148         (class gdbpy_enter) <m_error_type, m_error_value,
5149         m_error_traceback>: Remove.
5150         <m_error>: New member.
5151         (gdbpy_exception_to_string): Don't declare.
5152         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5153         * python/py-value.c (convert_value_from_python): Use
5154         gdbpy_err_fetch.
5155         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5156         gdbpy_exception_to_string.
5157         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5158         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5159         gdbpy_err_fetch.
5160
5161 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5162
5163         * linux-nat.c (delete_lwp_cleanup): Delete.
5164         (struct lwp_deleter): New struct.
5165         (lwp_info_up): New typedef.
5166         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5167         lwp_info_up.
5168
5169 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5170
5171         * linux-fork.c (class scoped_switch_fork_info): New class.
5172         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
5173
5174 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5175
5176         * valops.c (find_overload_match): Remove use of null_cleanup, and
5177         calls to do_cleanups.
5178
5179 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5180
5181         * compile/compile-cplus-types.c
5182         (compile_cplus_instance::decl_name): Handle changes to
5183         cp_func_name.
5184         * cp-support.c (cp_func_name): Update header comment, update
5185         return type.
5186         * cp-support.h (cp_func_name): Update return type in declaration.
5187         * valops.c (find_overload_match): Move temp_func local to top
5188         level of function and change its type.  Use temp_func to hold and
5189         delete temporary string obtained from cp_func_name.
5190
5191 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5192
5193         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
5194         gdb::char_vector, remove cleanup, and update uses of `msg`.
5195
5196 2019-01-03  Jim Wilson  <jimw@sifive.com>
5197
5198         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
5199
5200 2019-01-02  Tom Tromey  <tom@tromey.com>
5201
5202         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
5203         (tdesc_parse_xml): Remove cleanups.
5204         * target-descriptions.h (make_cleanup_free_target_description):
5205         Don't declare.
5206         (target_desc_deleter): New struct.
5207         (target_desc_up): New typedef.
5208         * target-descriptions.c (target_desc_deleter::operator()): Rename
5209         from free_target_description.
5210         (make_cleanup_free_target_description): Remove.
5211
5212 2019-01-02  Tom Tromey  <tom@tromey.com>
5213
5214         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
5215         constructor, destructor.
5216         (linespec_parser): Remove typedef.
5217         (~linespec_parser): Rename from linespec_parser_delete.
5218         (linespec_lex_to_end, linespec_complete_label)
5219         (linespec_complete): Update.
5220         (decode_line_full): Remove cleanups.
5221         (decode_line_1): Update.
5222
5223 2019-01-02  Tom Tromey  <tom@tromey.com>
5224
5225         * python/python-internal.h (inferior_to_inferior_object): Change
5226         return type.
5227         * python/py-exitedevent.c (create_exited_event_object): Update.
5228         * python/py-inferior.c (inferior_to_inferior_object): Return
5229         gdbpy_ref.
5230         (python_new_inferior, python_inferior_deleted)
5231         (thread_to_thread_object, delete_thread_object)
5232         (build_inferior_list, gdbpy_selected_inferior): Update.
5233         * python/py-infthread.c (create_thread_object): Update.  Also fail
5234         if inferior_to_inferior_object fails.
5235
5236 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5237
5238         * inferior.h (class inferior) <displaced_step_state>: New field.
5239         * infrun.h (struct displaced_step_state): Move here from
5240         infrun.c.  Initialize fields, add constructor.
5241         <inf>: Remove field.
5242         <reset>: New method.
5243         * infrun.c (struct displaced_step_inferior_state): Move to
5244         infrun.h.
5245         (displaced_step_inferior_states): Remove.
5246         (get_displaced_stepping_state): Adust.
5247         (displaced_step_in_progress_any_inferior): Adjust.
5248         (displaced_step_in_progress_thread): Adjust.
5249         (displaced_step_in_progress): Adjust.
5250         (add_displaced_stepping_state): Remove.
5251         (get_displaced_step_closure_by_addr): Adjust.
5252         (remove_displaced_stepping_state): Remove.
5253         (infrun_inferior_exit): Call displaced_step_state.reset.
5254         (use_displaced_stepping): Don't check for NULL.
5255         (displaced_step_prepare_throw): Call
5256         get_displaced_stepping_state.
5257         (displaced_step_fixup): Don't check for NULL.
5258         (prepare_for_detach): Don't check for NULL.
5259
5260 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5261
5262         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
5263          in case of call that did not complete.
5264
5265 2019-01-02  Andrey Utkin  <autkin@undo.io>
5266
5267         * symfile.c (find_separate_debug_file): Fix search of debug files for
5268         remote debuggee.
5269
5270 2019-01-02  Tom Tromey  <tom@tromey.com>
5271
5272         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
5273         indentation.
5274         * python/py-frame.c (frapy_older): Remove cast.
5275         (frapy_newer): Likewise.
5276         * python/py-breakpoint.c (local_setattro): Remove cast.
5277         * python/py-arch.c (archpy_name): Remove local variable.
5278         * python/py-type.c (gdbpy_lookup_type): Remove cast.
5279
5280 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
5281
5282         * unittests/basic_string_view/element_access/char/empty.cc:
5283         Fix year range in copyright header.
5284
5285 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5286
5287         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
5288         Delete.
5289         <operator==>: Update with for removed field.
5290         <hash>: Likewise.
5291         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
5292         <isa_features>: ...this.
5293         <abi_features>: New field.
5294         (riscv_isa_flen): Update comment.
5295         (riscv_abi_xlen): New declaration.
5296         (riscv_abi_flen): New declaration.
5297         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
5298         isa_features.
5299         (riscv_abi_xlen): New function.
5300         (riscv_isa_flen): Update to get answer from isa_features.
5301         (riscv_abi_flen): New function.
5302         (riscv_has_fp_abi): Update to get answer from abi_features.
5303         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
5304         xlen and flen.
5305         (riscv_call_info) <xlen, flen>: Update comment.
5306         (riscv_call_arg_struct): Remove invalid assertions
5307         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
5308         is removed.
5309         (riscv_gdbarch_init): Gather isa features and abi features
5310         separately, ensure both match on the gdbarch when reusing an old
5311         gdbarch.  Relax an error check to allow 32-bit abi float to run on
5312         a target with 64-bit float hardware.
5313
5314 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5315
5316         * source.c (search_command_helper): Stop reverse search
5317         when line 1 has been searched.
5318
5319 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5320
5321         * record-full.c (record_full_base_target::close): Rewrite
5322         record_full_core_buf_list free logic.
5323
5324 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5325
5326         * break-catch-syscall.c (print_one_catch_syscall): xfree
5327         the last text.
5328
5329 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5330
5331         * top.c (print_gdb_version): Update Copyright year in version
5332         message.
5333
5334 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5335
5336         Update copyright year range in all GDB files.
5337
5338 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
5339
5340         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
5341
5342 For older changes see ChangeLog-2018.
5343 \f
5344 Local Variables:
5345 mode: change-log
5346 left-margin: 8
5347 fill-column: 74
5348 version-control: never
5349 coding: utf-8
5350 End:
5351