gdb/ChangeLog

   1 2019-06-25  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-data.h (struct tui_win_info): Add constructor.
   4         * tui/tui-data.c (tui_alloc_win_info): Use new.
   5         (tui_free_window): Use delete.
   6
   7 2019-06-22  Tom Tromey  <tom@tromey.com>
   8
   9         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
  10         declare.
  11         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
  12
  13 2019-06-22  Tom Tromey  <tom@tromey.com>
  14
  15         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
  16         declare.
  17         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
  18
  19 2019-06-22  Tom de Vries  <tdevries@suse.de>
  20
  21         * dwarf2read.c (create_addrmap_from_aranges)
  22         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
  23         instead of '%zu'.
  24
  25 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
  26
  27         * dwarf2read.h (dwarf2_section_info_def): Remove.
  28         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
  29         * dwarf2read.c (struct dwo_sections) <types>: Change type to
  30         std::vector<dwarf2_section_info>.
  31         (struct dwo_file) <~dwo_file>: Remove.
  32         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
  33         types field.
  34         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
  35         (dwarf2_read_debug_names): Likewise.
  36         (create_debug_types_hash_table): Change parameter type to
  37         array_view, adjust code accordingly.
  38         (dwarf2_locate_dwo_sections): Adjust to std::vector.
  39         (partial_die_info::fixup): Likewise.
  40         (determine_prefix): Likewise.
  41         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
  42
  43 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
  44
  45         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
  46         gdb_bfd_ref_ptr.
  47         <~dwo_file>: Remove call to gdb_bfd_unref.
  48         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
  49         gdb_bfd_ref_ptr::get.
  50
  51 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
  52
  53         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
  54         type to htab_up.
  55         * dwarf2read.c (struct dwo_file): Initialize fields.
  56         <~dwo_file>: New.
  57         (free_dwo_file): Remove, move content to ~dwo_file.
  58         (struct dwo_file_deleter): Remove.
  59         (dwo_file_up>: Remove custom deleter.
  60         (free_dwo_files): Remove.
  61         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
  62         dwo_files.
  63         (process_skeletonless_type_units): Call unique_ptr::get.
  64         (allocate_dwo_file_hash_table): Add deleter to created hash
  65         table.  Change return type to htab_up.
  66         (lookup_dwo_file_slot): Don't memset dwo_file, call
  67         unique_ptr::get.
  68         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
  69         (create_dwo_unit_in_dwp_v2): Likewise.
  70         (open_and_init_dwo_file): Likewise.
  71         (free_dwo_file_from_slot): Remove.
  72
  73 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
  74
  75         * dwarf2read.h (struct dwarf2_section_info) <readin,
  76         is_virtual>: Change type to bool.
  77         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
  78         true instead of 1.
  79
  80 2019-06-19  Tom Tromey  <tom@tromey.com>
  81
  82         * tui/tui-data.h (tui_init_content_element): Don't declare.
  83
  84 2019-06-19  Tom Tromey  <tom@tromey.com>
  85
  86         * tui/tui-data.h (tui_init_win_info): Don't declare.
  87
  88 2019-06-19  Tom de Vries  <tdevries@suse.de>
  89
  90         * dwarf2read.h (abstract_to_concrete): Change type to
  91         std::unordered_map<sect_offset, std::vector<sect_offset>,
  92         gdb::hash_enum<sect_offset>>.
  93
  94 2019-06-19  Tom Tromey  <tromey@adacore.com>
  95
  96         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
  97         EVAL_AVOID_SIDE_EFFECTS specially.
  98
  99 2019-06-19  Tom Tromey  <tromey@adacore.com>
 100
 101         * source-cache.c (highlighter): New global.
 102         (source_cache::get_source_lines): Create a highlighter on demand.
 103
 104 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 105
 106         * defs.h (deprecated_interactive_hook): Delete declaration.
 107         * interps.c (clear_interpreter_hooks): Remove use of
 108         deprecated_interactive_hook.
 109         * top.c (deprecated_interactive_hook): Delete definition.
 110         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 111
 112 2019-06-18  Tom de Vries  <tdevries@suse.de>
 113
 114         PR gdb/24515
 115         * dwarf2read.h (abstract_to_concrete): Change type from
 116         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 117         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 118         * dwarf2read.c (read_variable): Update.
 119         (dwarf2_fetch_die_loc_sect_off): Update.
 120
 121 2019-06-17  Tom de Vries  <tdevries@suse.de>
 122
 123         PR gdb/24617
 124         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 125         accessing parent[parent_len - 1].
 126
 127 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 128
 129         PR gdb/24364
 130         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 131         call dtrace_process_dof with NULL dof.
 132
 133 2019-06-16  Tom de Vries  <tdevries@suse.de>
 134
 135         PR gdb/24445
 136         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 137
 138 2019-06-16  Tom Tromey  <tom@tromey.com>
 139
 140         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 141         (make_all_visible): Use address of member.
 142
 143 2019-06-16  Tom Tromey  <tom@tromey.com>
 144
 145         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 146         (tui_free_window, free_content, free_content_elements): Remove
 147         unnecessary cast.
 148         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 149         cast.
 150         * tui/tui-regs.c (tui_show_register_group)
 151         (tui_display_registers_from, tui_display_reg_element_at_line):
 152         Remove unnecessary cast.
 153
 154 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 155
 156         * linux-nat.c (normal_mask): Delete.
 157         (_initialize_linux_nat): Don't initialise normal_mask.
 158
 159 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 160
 161         PR gdb/24445
 162         * dwarf-index-write.h (write_psymtabs_to_index): Add
 163         dwz_basename parameter.
 164         * dwarf-index-write.c (write_gdbindex): Move file writing to
 165         write_gdbindex_1.  Change return type void.
 166         (assert_file_size): Move up, remove filename parameter.
 167         (write_gdbindex_1): New function.
 168         (write_debug_names): Change return type to void, call
 169         assert_file_size.
 170         (struct index_wip_file): New struct.
 171         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 172         file logic to index_wip_file.  Write index for dwz file if
 173         needed.
 174         (save_gdb_index_command): Pass basename of dwz file, if present.
 175         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 176         build-id of dwz file, if present.
 177         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 178         (dwarf2_get_dwz_file): Likewise.
 179         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 180         (dwarf2_get_dwz_file): Likewise.
 181
 182 2019-06-16  Tom Tromey  <tom@tromey.com>
 183
 184         * coffread.c (process_coff_symbol): Use xstrdup.
 185         * value.c (create_internalvar): Use xstrdup.
 186
 187 2019-06-16  Tom Tromey  <tom@tromey.com>
 188
 189         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 190         * breakpoint.c (stopin_command, stopat_command)
 191         (until_break_command, decode_location_default): Remove unnecessary
 192         cast.
 193         * utils.c (subset_compare): Remove unnecessary cast.
 194         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 195         cast.
 196         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 197         cast.
 198         * infcmd.c (path_command): Remove unnecessary cast.
 199         * coffread.c (decode_type): Remove unnecessary cast.
 200         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 201         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 202         * tui/tui-stack.c (tui_show_locator_content)
 203         (tui_show_frame_info): Remove unnecessary cast.
 204         * tui/tui-win.c (tui_scroll_forward_command)
 205         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 206         (parse_scrolling_args): Remove unnecessary cast.
 207         * tui/tui-data.c (init_win_info, tui_del_window)
 208         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 209         (free_content_elements): Remove unnecessary cast.
 210         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 211         unnecessary cast.
 212         * tui/tui-source.c (tui_set_source_content)
 213         (tui_vertical_source_scroll): Remove unnecessary cast.
 214         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 215         cast.
 216         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 217         * tui/tui-regs.c (tui_display_registers_from)
 218         (tui_display_register): Remove unnecessary cast.
 219         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 220         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 221         (make_visible): Remove unnecessary cast.
 222         * tui/tui-winsource.c (tui_erase_source_content)
 223         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 224         unnecessary cast.
 225         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 226         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 227         * stabsread.c (read_type, read_array_type, read_range_type):
 228         Remove unnecessary cast.
 229         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 230         (parse_symbol, parse_type, upgrade_type, parse_external)
 231         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 232         unnecessary cast.
 233         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 234
 235 2019-06-16  Tom Tromey  <tom@tromey.com>
 236
 237         * tui/tui-data.c (tui_alloc_generic_win_info)
 238         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 239         checks.
 240
 241 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 242             Andrew Burgess  <andrew.burgess@embecosm.com>
 243
 244         * f-typeprint.c (f_print_type): Don't return early for not
 245         associated or not allocated types.
 246         (f_type_print_varspec_suffix): Add print_rank parameter and print
 247         ranks of array types in case they dangling.
 248         (f_type_print_base): Add print_rank parameter.
 249
 250 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 251
 252         * NEWS: Mention new MI commands.
 253         * break-catch-throw.c (enum exception_event_kind): Move to
 254         breakpoint.h.
 255         (print_mention_exception_catchpoint): Output text as a single
 256         message.
 257         (catch_exception_command_1): Rename to...
 258         (catch_exception_event): ...this, make non-static, update header
 259         command, and change some parameter types.
 260         (catch_catch_command): Update for changes to
 261         catch_exception_command_1.
 262         (catch_throw_command): Likewise.
 263         (catch_rethrow_command): Likewise.
 264         * breakpoint.c (enum exception_event_kind): Delete.
 265         * breakpoint.h (enum exception_event_kind): Moved here from
 266         break-catch-throw.c.
 267         (catch_exception_event): Declare.
 268         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 269         (mi_cmd_catch_throw): New function.
 270         (mi_cmd_catch_rethrow): New function.
 271         (mi_cmd_catch_catch): New function.
 272         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 273         'catch-catch' entries.
 274         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 275         (mi_cmd_catch_rethrow): Declare.
 276         (mi_cmd_catch_catch): Declare.
 277
 278 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 279
 280         * annotate.c (annotate_source_line): Change return type to void,
 281         update implementation to match.
 282         * annotate.h (annotate_source_line): Change return type to void,
 283         update header comment.
 284         * stack.c (print_frame_info): Don't change what frame information
 285         is printed based on whether annotations are on or not.
 286
 287 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 288
 289         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 290         (annotate_source): Make static.
 291         (annotate_source_line): Moved from source.c and renamed from
 292         identify_source_line.  Update the return type.
 293         * annotate.h (annotate_source): Delete declaration.
 294         (annotate_source_line): Declaration moved from source.h, and
 295         renamed from identify_source_line.  Return type updated.
 296         * source.c (identify_source_line): Moved to annotate.c and renamed
 297         to annotate_source_line.
 298         (info_line_command): Remove check of annotation_level.
 299         * source.h (identify_source_line): Move declaration to annotate.h
 300         and rename to annotate_source_line.
 301         * stack.c: Add 'annotate.h' include.
 302         (print_frame_info): Remove check of annotation_level before
 303         calling annotate_source_line.
 304
 305 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 306
 307         * source-cache.c (source_cache::get_plain_source_lines): Use
 308         open_source_file_with_line_charpos instead of just
 309         open_source_file, remove call to find_source_lines.
 310         (source_cache::get_source_lines): Likewise.
 311         * source.c (find_source_lines): Make static.
 312         (get_filename_and_charpos): Renamed into...
 313         (open_source_file_with_line_charpos): ..this along with changes to
 314         return a scoped_fd, and some other minor clean ups.
 315         (identify_source_line): Use open_source_file_with_line_charpos.
 316         (search_command_helper): Use open_source_file_with_line_charpos
 317         instead of just open_source_file, remove call to
 318         find_source_lines.
 319         * source.h (open_source_file_with_line_charpos): Declare new
 320         function.
 321         (find_source_lines): Delete declaration.
 322
 323 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 324
 325         * source.c (get_filename_and_charpos): Remove fullname
 326         parameter.
 327         (identify_source_line): Update call to get_filename_and_charpos.
 328
 329 2019-06-14  Tom Tromey  <tromey@adacore.com>
 330
 331         PR gdb/24502:
 332         * ui-style.h (skip_ansi_escape): Update comment.
 333         * ui-file.h (class no_terminal_escape_file): New class.
 334         * ui-file.c (no_terminal_escape_file::write)
 335         (no_terminal_escape_file::puts): New methods.
 336         * cli/cli-logging.c (handle_redirections): Use
 337         no_terminal_escape_file.
 338
 339 2019-06-14  Tom Tromey  <tromey@adacore.com>
 340
 341         * NEWS: Move convenience variable news above Python news.
 342
 343 2019-06-14  Tom Tromey  <tom@tromey.com>
 344
 345         * gnulib: Move directory to top-level.
 346         * configure.ac: Don't configure gnulib.
 347         * configure: Rebuild.
 348         * common/common-defs.h: Use new path to gnulib.
 349         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 350         (GNULIB_H): Remove.
 351         (INCGNU): Look in new gnulib location.
 352         (HFILES_NO_SRCDIR): Remove gnulib files.
 353         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 354         (generated_files): Remove GNULIB_H.
 355         ($(LIBGNU), all-lib): Remove targets.
 356         (distclean): Don't mention GNULIB_BUILDDIR.
 357         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 358
 359 2019-06-14  Tom Tromey  <tromey@adacore.com>
 360
 361         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 362         Warn if symbol file does not provide any symbols.
 363
 364 2019-06-14  Tom Tromey  <tromey@adacore.com>
 365
 366         * source.c (find_and_open_source): Respect basenames_may_differ.
 367
 368 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 369
 370         * annotate.c (annotate_breakpoints_invalid): Make use of
 371         scoped_restore_terminal_state.
 372         (annotate_frames_invalid): Likewise.
 373
 374 2019-06-14  Tom Tromey  <tromey@adacore.com>
 375
 376         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 377         allow assignment to an internalvar.
 378
 379 2019-06-14  Tom Tromey  <tromey@adacore.com>
 380
 381         * ada-lex.l: Allow "_" in attribute names.
 382
 383 2019-06-14  Tom Tromey  <tromey@adacore.com>
 384
 385         PR gdb/24653:
 386         * regcache.c (registers_changed): Don't call alloca.
 387         * top.c (execute_command): Don't call alloca.
 388
 389 2019-06-13  Pedro Alves  <palves@redhat.com>
 390
 391         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 392         'expression'.  When parsing an expression, error out if there's
 393         junk after "unlimited".
 394         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 395         (do_set_command): Adjust calls to is_unlimited_literal.
 396
 397 2019-06-13  Pedro Alves  <palves@redhat.com>
 398
 399         * compile/compile.c (make_compile_options_def_group): Add braces
 400         around array_view initializer.
 401         * thread.c (make_thread_apply_all_options_def_group)
 402         (make_thread_apply_all_options_def_group): Likewise.
 403
 404 2019-06-13  Pedro Alves  <palves@redhat.com>
 405
 406         * NEWS (New commands): Mention "maint test-options
 407         require-delimiter", "maint test-options unknown-is-error", "maint
 408         test-options unknown-is-operand" and "maint show
 409         test-options-completion-result".
 410         (New command options, command completion): New section.
 411         (Completion improvements): New section.
 412         Mention that you can abbreviate "unlimited".
 413
 414 2019-06-13  Pedro Alves  <palves@redhat.com>
 415
 416         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 417         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 418         * unittests/cli-utils-selftests.c (test_parse_flags)
 419         (test_parse_flags_qcs): Delete.
 420         (test_cli_utils): Don't call deleted functions.
 421
 422 2019-06-13  Pedro Alves  <palves@redhat.com>
 423
 424         * thread.c: Include "cli/cli-option.h".
 425         (tp_array_compar_ascending): Global.
 426         (tp_array_compar): Delete function.
 427         (tp_array_compar_ascending, tp_array_compar_descending): New
 428         functions.
 429         (ascending_option_def, qcs_flag_option_def)
 430         (thr_qcs_flags_option_defs)
 431         (make_thread_apply_all_options_def_group)
 432         (make_thread_apply_options_def_group): New.
 433         (thread_apply_all_command): Use gdb::option::process_options.
 434         (thread_apply_command_completer)
 435         (thread_apply_all_command_completer): New.
 436         (thread_apply_command): Use gdb::option::process_options.
 437         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 438         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 439         to generate help text of "thread apply".  Adjust "taas"'s help.
 440         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 441         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 442
 443 2019-06-13  Pedro Alves  <palves@redhat.com>
 444
 445         * thread.c (thread_apply_command): Check for invalid TID with
 446         isdigit instead of !isalpha.
 447
 448 2019-06-13  Pedro Alves  <palves@redhat.com>
 449
 450         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 451         (validate_flags_qcs): New.
 452         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 453         (validate_flags_qcs): Declare.
 454         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 455         (make_frame_apply_options_def_group): New.
 456         (frame_apply_command_count): Process options with
 457         gdb::option::process_options.
 458         (frame_apply_completer): New.
 459         (frame_apply_level_completer, frame_apply_all_completer)
 460         (frame_apply_completer): New.
 461         (_initialize_stack): Update help of "frame apply", "frame apply
 462         level", "frame apply all" and "faas" to mention supported options
 463         and install command completers.
 464         * stack.h (frame_apply_all_completer): Declare.
 465         * thread.c: Include "stack.h".
 466         (tfaas_command): Add "--".
 467         (_initialize_thread): Update help "tfaas" to mention supported
 468         options and install command completer.
 469
 470 2019-06-13  Pedro Alves  <palves@redhat.com>
 471
 472         * completer.c (complete_nested_command_line): New.
 473         (gdb_completion_word_break_characters_throw): Add assertion.
 474         * completer.h (complete_nested_command_line): Declare.
 475
 476 2019-06-13  Pedro Alves  <palves@redhat.com>
 477
 478         * stack.c (parse_backtrace_qualifiers): New.
 479         (backtrace_command): Use it.
 480         (backtrace_command_completer): Complete on qualifiers.
 481
 482 2019-06-13  Pedro Alves  <palves@redhat.com>
 483
 484         * frame.c: Include "cli/cli-option.h.
 485         (user_set_backtrace_options): New.
 486         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 487         Delete.
 488         (get_prev_frame): Adjust.
 489         (boolean_option_def, uinteger_option_def)
 490         (set_backtrace_option_defs): New.
 491         (_initialize_frame): Adjust and use
 492         gdb::option::add_setshow_cmds_for_options to install "set
 493         backtrace past-main" and "set backtrace past-entry".
 494         * frame.h: Include "cli/cli-option.h".
 495         (struct frame_print_options): Forward declare.
 496         (print_frame_arguments_all, print_frame_arguments_scalars)
 497         (print_frame_arguments_none): Declare.
 498         (print_entry_values): Delete declaration.
 499         (struct frame_print_options, user_frame_print_options): New.
 500         (struct set_backtrace_options): New.
 501         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 502         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 503         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 504         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 505         (list_args_or_locals): Add frame_print_options parameter.
 506         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 507         * python/py-framefilter.c (enumerate_args): Pass down
 508         USER_FRAME_PRINT_OPTIONS.
 509         * stack.c: Include "cli/cli-option.h".
 510         (print_frame_arguments_all, print_frame_arguments_scalars)
 511         (print_frame_arguments_none): Declare.
 512         (print_raw_frame_arguments, print_entry_values): Delete.
 513         (user_frame_print_options): New.
 514         (boolean_option_def, enum_option_def, frame_print_option_defs):
 515         New.
 516         (struct backtrace_cmd_options): New.
 517         (bt_flag_option_def): New.
 518         (backtrace_command_option_defs): New.
 519         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 520         (print_frame_arg, read_frame_arg, print_frame_args)
 521         (print_frame_info, print_frame): Add frame_print_options parameter
 522         and use it.
 523         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 524         (backtrace_command_1): Add frame_print_options and
 525         backtrace_cmd_options parameters and use them.
 526         (make_backtrace_options_def_group): New.
 527         (backtrace_command): Process command options with
 528         gdb::option::process_options.
 529         (backtrace_command_completer): New.
 530         (_initialize_stack): Extend "backtrace"'s help to mention
 531         supported options.  Install completer for "backtrace".
 532         Install some settings commands with add_setshow_cmds_for_options.
 533
 534 2019-06-13  Pedro Alves  <palves@redhat.com>
 535
 536         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 537         and that "set/show print raw frame-arguments" are now deprecated.
 538
 539         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 540         command.
 541         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 542         * stack.c (_initialize_stack): Install "set/show print
 543         raw-frame-arguments", and deprecate "set/show print raw
 544         frame-arguments".
 545         * valprint.c (_initialize_valprint): Deprecate "set/show print
 546         raw".
 547
 548 2019-06-13  Pedro Alves  <palves@redhat.com>
 549
 550         * compile/compile.c (struct compile_options): New.
 551         (compile_flag_option_def, compile_command_option_defs)
 552         (make_compile_options_def_group): New.
 553         (compile_file_command): Handle options with
 554         gdb::option::process_options.
 555         (compile_file_command_completer): New function.
 556         (compile_code_command): Handle options with
 557         gdb::option::process_options.
 558         (compile_code_command_completer): New function.
 559         (_initialize_compiler): Install completers for "compile code" and
 560         "compile file".  Mention available options in "compile code" and
 561         "compile code"'s help.
 562         * completer.c (advance_to_completion_word): New, factored out from
 563         ...
 564         (advance_to_expression_complete_word_point): ... this.
 565         (advance_to_filename_complete_word_point): New.
 566         * completer.h (advance_to_filename_complete_word_point): New
 567         declaration.
 568
 569 2019-06-13  Pedro Alves  <palves@redhat.com>
 570
 571         * compile/compile.c: Include "cli/cli-option.h".
 572         (compile_print_value): Scope data pointer is now a
 573         value_print_options pointer; adjust.
 574         (compile_print_command): Process options.  Scope data pointer is
 575         now a value_print_options pointer; adjust.
 576         (_initialize_compile): Update "compile print"'s help to include
 577         supported options.  Install a completer for "compile print".
 578         * cp-valprint.c (show_vtblprint, show_objectprint)
 579         (show_static_field_print): Delete.
 580         (_initialize_cp_valprint): Don't install "set print
 581         static-members", "set print vtbl", "set print object" here.
 582         * printcmd.c: Include "cli/cli-option.h" and
 583         "common/gdb_optional.h".
 584         (print_command_parse_format): Rework to fill in a
 585         value_print_options instead of a format_data.
 586         (print_value): Change parameter type from format_data pointer to
 587         value_print_options reference.  Adjust.
 588         (print_command_1): Process options.  Adjust to pass down a
 589         value_print_options.
 590         (print_command_completer): New.
 591         (_initialize_printcmd): Install print_command_completer as
 592         handle_brkchars completer for the "print" command.  Update
 593         "print"'s help to include supported options.
 594         * valprint.c: Include "cli/cli-option.h".
 595         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 596         here from cp-valprint.c.
 597         (boolean_option_def, uinteger_option_def)
 598         (value_print_option_defs, make_value_print_options_def_group):
 599         New.  Use gdb::option::add_setshow_cmds_for_options to install
 600         "set print elements", "set print null-stop", "set print repeats",
 601         "set print pretty", "set print union", "set print array", "set
 602         print address", "set print symbol", "set print array-indexes".
 603         * valprint.h: Include <string> and "cli/cli-option.h".
 604         (make_value_print_options_def_group): Declare.
 605         (print_value): Change parameter type from format_data pointer to
 606         value_print_options reference.
 607         (print_command_completer): Declare.
 608
 609 2019-06-13  Pedro Alves  <palves@redhat.com>
 610
 611         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 612         (COMMON_SFILES): Add maint-test-settings.c.
 613         * cli/cli-decode.c (boolean_enums): New global, factored out from
 614         ...
 615         (add_setshow_boolean_cmd): ... here.
 616         * cli/cli-decode.h (boolean_enums): Declare.
 617         * cli/cli-option.c: New file.
 618         * cli/cli-option.h: New file.
 619         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 620         factored out from ...
 621         (parse_cli_boolean_value(const char *)): ... this.
 622         (is_unlimited_literal): Change parameter type to pointer to
 623         pointer.  Adjust and advance ARG pointer.
 624         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 625         (parse_cli_var_enum): New, factored out from ...
 626         (do_set_command): ... this.  Adjust.
 627         * cli/cli-setshow.h (parse_cli_boolean_value)
 628         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 629         (parse_cli_var_enum): Declare.
 630         * cli/cli-utils.c: Include "cli/cli-option.h".
 631         (get_ulongest): New.
 632         * cli/cli-utils.h (get_ulongest): Declare.
 633         (check_for_argument): New overloads.
 634         * maint-test-options.c: New file.
 635
 636 2019-06-13  Pedro Alves  <palves@redhat.com>
 637
 638         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 639         parse a range if "-" is at the end of the string.
 640
 641 2019-06-13  Pedro Alves  <palves@redhat.com>
 642
 643         * cli/cli-setshow.c (parse_auto_binary_operation)
 644         (parse_cli_boolean_value): Don't allow "o".
 645
 646 2019-06-13  Pedro Alves  <palves@redhat.com>
 647
 648         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 649         * NEWS: Mention maint test-settings KIND.
 650         * maint-test-settings.c: New file.
 651
 652 2019-06-13  Pedro Alves  <palves@redhat.com>
 653
 654         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 655         completer.
 656         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 657         "set" completers.
 658
 659 2019-06-13  Pedro Alves  <palves@redhat.com>
 660
 661         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 662         after item.
 663
 664 2019-06-13  Pedro Alves  <palves@redhat.com>
 665
 666         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 667
 668 2019-06-13  Pedro Alves <palves@redhat.com>
 669
 670         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 671         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 672         call.
 673         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 674         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 675         calls.
 676         (check_for_argument): Skip spaces after argument.
 677
 678 2019-06-13  Pedro Alves  <palves@redhat.com>
 679
 680         * thread.c (thread_apply_command): Adjust TID parsing.
 681         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 682         detected before end of string.
 683         (tid_is_in_list): Error out if LIST is invalid.
 684
 685 2019-06-13  Pedro Alves  <palves@redhat.com>
 686
 687         * completer.c (complete_line_internal_1): Rewind completion word
 688         point.
 689         (completion_tracker::advance_custom_word_point_by): Change
 690         parameter type to int.
 691         * completer.h (completion_tracker::advance_custom_word_point_by):
 692         Likewise.
 693
 694 2019-06-13  Pedro Alves  <palves@redhat.com>
 695
 696         * completer.c (advance_to_completion_word): Handle delimiters.
 697
 698 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 699
 700         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 701
 702 2019-06-11  Tom Tromey  <tom@tromey.com>
 703
 704         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 705         (xmalloc_failed): Move to alloc.c.
 706         * alloc.c: New file.
 707         * Makefile.in (COMMON_SFILES): Add alloc.c.
 708
 709 2019-06-11  Tom Tromey  <tom@tromey.com>
 710
 711         * nat/linux-waitpid.c: Don't include server.h.
 712         (linux_debug): Remove.
 713         (my_waitpid): Update.
 714
 715 2019-06-11  Tom Tromey  <tromey@adacore.com>
 716
 717         * infcall.c (_initialize_infcall): Remove trailing newline from
 718         help.
 719         * user-regs.c (_initialize_user_regs): Remove trailing newline
 720         from help.
 721         * typeprint.c (_initialize_typeprint): Remove trailing newline
 722         from help.
 723         * reverse.c (_initialize_reverse): Remove trailing newlines from
 724         help.
 725         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 726         from help.
 727         * language.c (add_set_language_command): Remove trailing newline
 728         from help.
 729         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 730         help.
 731         * disasm.c (_initialize_disasm): Remove trailing newline from
 732         help.
 733         * top.c (init_main): Remove trailing newline from help.
 734         * interps.c (_initialize_interpreter): Remove trailing newline
 735         from help.
 736         * btrace.c (_initialize_btrace): Remove trailing newlines from
 737         help.
 738         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 739         from help.
 740         * python/python.c (_initialize_python): Remove trailing newline
 741         from help.
 742         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 743         help.
 744         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 745         from help.  Reformat some text.
 746         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 747         from help.
 748         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 749         newline from help.
 750
 751 2019-06-11  Tom Tromey  <tromey@adacore.com>
 752
 753         * darwin-nat.c (darwin_decode_exception_message)
 754         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 755
 756 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 757
 758         * valops.c (value_slice): Check for not allocated or not
 759         associated values.
 760
 761 2019-06-10  Tom de Vries  <tdevries@suse.de>
 762
 763         PR gdb/24618
 764         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 765         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 766         invalid.
 767
 768 2019-06-10  Tom de Vries  <tdevries@suse.de>
 769
 770         PR gdb/24611
 771         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 772         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 773
 774 2019-06-10  Tom de Vries  <tdevries@suse.de>
 775
 776         PR symtab/24545
 777         * symtab.c (struct demangled_name_entry): Add language field.
 778         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 779         static minimal symbol".  Set and use language field.
 780
 781 2019-06-10  Tom Tromey  <tromey@adacore.com>
 782
 783         * ada-lang.c (_initialize_ada_language): Update help text.
 784
 785 2019-06-10  Tom Tromey  <tromey@adacore.com>
 786
 787         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 788         with a newline.
 789         * guile/guile.c (handle_boot_error): Don't end warning with a
 790         newline.
 791         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 792         warning with a newline.
 793         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 794         newline.
 795         (s12z_frame_cache): Likewise.
 796         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 797         a newline.
 798         * solib-svr4.c (disable_probes_interface): Don't end warning with
 799         a newline.
 800         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 801         newline.
 802         * python/python.c (do_finish_initialization): Don't end warning
 803         with a newline.
 804
 805 2019-06-10  Tom Tromey  <tom@tromey.com>
 806
 807         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 808         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 809         gdbpy_enter.
 810
 811 2019-06-10  Tom Tromey  <tromey@adacore.com>
 812
 813         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 814         data.
 815         (elf_new_init): Don't call stabsread_new_init.
 816         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 817         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 818         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 819
 820 2019-06-10  Tom de Vries  <tdevries@suse.de>
 821
 822         PR symtab/16264
 823         PR symtab/24517
 824         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 825
 826 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 827
 828         * source.c (find_and_open_source): Also rewrite relative file
 829         names.
 830
 831 2019-04-26  Amos Bird  <amosbird@gmail.com>
 832
 833         * annotate.c (annotate_thread_exited): Add "thread-exited"
 834         annotation.
 835
 836 2019-06-06  Tom Tromey  <tromey@adacore.com>
 837
 838         * maint.h (class scoped_command_stats): Use
 839         DISABLE_COPY_AND_ASSIGN.
 840         <print_time>: New method.
 841         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 842         print_time.
 843         (scoped_command_stats::print_time): New method.
 844
 845 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 846
 847         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 848         instructions of lengths 6 or 8 bytes.
 849
 850 2019-06-04  Pedro Alves  <palves@redhat.com>
 851
 852         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 853
 854         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 855         * breakpoint.c (condition_completer): Likewise.
 856         * cli/cli-dump.c (scan_expression): Likewise.
 857         * common/filestuff.c (mkdir_recursive): Likewise.
 858         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 859         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 860         (gdb_abspath): Likewise.
 861         * compile/compile-cplus-types.c
 862         (compile_cplus_instance::decl_name): Likewise.
 863         * completer.c (complete_explicit_location):
 864         (signal_completer, reg_or_group_completer_1): Likewise.
 865         * cp-support.c (cp_remove_params_if_any): Likewise.
 866         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 867         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 868         * infcmd.c (strip_bg_char): Likewise.
 869         * linespec.c (copy_token_string): Likewise.
 870         * mi/mi-main.c (output_cores): Likewise.
 871         * psymtab.c (psymtab_search_name):
 872         * symfile.c (test_set_ext_lang_command): Likewise.
 873         * target.c (target_fileio_read_stralloc): Likewise.
 874         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 875         * value.c (complete_internalvar): Likewise.
 876
 877 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 878
 879         Add objfile property to gdb.Type.
 880         * NEWS: Mention Python API addition.
 881         * python/py-type.c (typy_get_objfile): New method.
 882
 883 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 884
 885         * NEWS: Mention the new set|show style [title|highlight].
 886         Mention changes to "show style", "help" and "apropos".
 887
 888 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 889
 890         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 891         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 892         instead of print_help_for_command.
 893         (print_doc_of_command): New function.
 894         (help_list): Add 'apropos -v word' suggestion.
 895         (print_help_for_command): Style the command name using title style.
 896         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 897         (_initialize_cli_cmds): Describe -v in apropos_command help.
 898
 899 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 900
 901         * cli/cli-style.h (cli_style_option): Add name in constructor,
 902         add m_name class member, add constructor with intensity,
 903         add name class function.
 904         (cli_style_option::add_setshow_commands): Remove name argument.
 905         (highlight_style, title_style): New styles.
 906         * cli/cli-style.c (do_show): New function that shows a style
 907         characteristic styling the style name with itself.
 908         (set_style_name): New function.
 909         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 910         Update all callers according to the changes in cli/cli-style.h.
 911         * utils.h (fputs_highlighted): New function.
 912         * utils.c (fputs_highlighted): Likewise.
 913
 914 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 915
 916         * NEWS: Mention new pipe command and new convenience variables.
 917
 918 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 919
 920         * cli/cli-cmds.c (pipe_command): New function.
 921         (_initialize_cli_cmds): Call add_com for pipe_command.
 922         Define | as an alias for pipe.
 923         (exit_status_set_internal_vars): New function.
 924         (shell_escape): Call exit_status_set_internal_vars.
 925         cli/cli-decode.c (find_command_name_length): Recognize | as
 926         a single character command.
 927
 928 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 929
 930         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 931         top.c (execute_command_to_ui_file): New function, mostly a copy
 932         of execute_command_to_string.
 933         (execute_command_to_string): Implement by calling
 934         execute_command_to_ui_file.
 935
 936 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 937
 938         * top.h (saved_command_line): Remove declaration.
 939         * top.c (previous_saved_command_line, previous_repeat_arguments):
 940         New variables.
 941         (saved_command_line): Make static, define together with other
 942         'repeat variables'.
 943         (dont_repeat): Clear repeat_arguments.
 944         (repeat_previous, get_saved_command_line, save_command_line):
 945         New functions.
 946         (gdb_init): Initialize saved_command_line
 947         and previous_saved_command_line.
 948         * main.c (captured_main_1): Remove saved_command_line initialization.
 949         * event-top.c (handle_line_of_input): Update to use
 950         the new 'repeat' related functions instead of direct access to
 951         saved_command_line.
 952         * command.h (repeat_previous, get_saved_command_line,
 953         save_command_line): New declarations.
 954         (dont_repeat): Add comment.
 955
 956 2019-05-30  Tom Tromey  <tromey@adacore.com>
 957
 958         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 959         Fix comment.
 960         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 961
 962 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 963
 964         PR cli/24587
 965         * completer.c (complete): Initialize variable word.
 966
 967 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 968
 969         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 970         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 971         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 972         'body' is NULL to the outter 'if', protecting the '!is_define'
 973         situation as well.
 974
 975 2019-05-29  Tom Tromey  <tromey@adacore.com>
 976
 977         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 978         (dwarf_unknown): New function.
 979         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 980         (dwarf_type_encoding_name): Use dwarf_unknown.
 981
 982 2019-05-29  Tom Tromey  <tromey@adacore.com>
 983
 984         PR c++/20020:
 985         * cp-valprint.c (cp_print_value_fields): Call
 986         cp_print_static_field inside "try".
 987
 988 2019-05-29  Tom Tromey  <tromey@adacore.com>
 989
 990         * inflow.c (struct terminal_info): Add default operator=.
 991         * configure: Rebuild.
 992         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 993         -Wdeprecated-copy-dtor, -Wredundant-move.
 994
 995 2019-05-29  Tom Tromey  <tromey@adacore.com>
 996
 997         * NEWS: Add entry.
 998         * infcmd.c (print_return_value_1): Handle finish_print
 999         option.
1000         (show_print_finish): New function.
1001         (_initialize_infcmd): Add "set/show print finish" commands.
1002         * valprint.c (user_print_options): Initialize new member.
1003         * valprint.h (struct value_print_options) <finish_print>: New
1004         member.
1005
1006 2019-05-28  Tom Tromey  <tromey@adacore.com>
1007
1008         * ada-lang.c (ada_remove_Xbn_suffix)
1009         (find_old_style_renaming_symbol)
1010         (parse_old_style_renaming): Remove.
1011         (ada_find_renaming_symbol): Don't call
1012         find_old_style_renaming_symbol.
1013         (ada_is_renaming_symbol): Rename from
1014         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1015         bool.  Now static.
1016         (ada_read_var_value): Update and simplify.
1017         * ada-exp.y (write_var_or_type): Remove old code.
1018
1019 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1020
1021         * event-top.c: Remove include comment.
1022         * inflow.c (class scoped_ignore_sigttou): Move from here...
1023         * inflow.h (class scoped_ignore_sigttou): ...to here.
1024         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1025         * top.c:  Remove include comment.
1026
1027 2019-05-27  Tom Tromey  <tom@tromey.com>
1028
1029         * NEWS: Fix typo.
1030
1031 2019-05-22  Tom Tromey  <tromey@adacore.com>
1032
1033         * target.c (target_follow_exec): Constify parameter.
1034         * target-delegates.c: Rebuild.
1035         * remote.c (remote_target::follow_exec): Constify parameter.
1036         * infrun.c (follow_exec): Constify parameter.
1037         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1038         (target_follow_exec): Likewise.
1039
1040 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1041
1042         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1043         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1044
1045 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1046
1047         * NEWS: Add debugredirect and testsuite sections.
1048
1049 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1050
1051         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1052         target descriptions using exclusively floating point register name
1053         aliases.
1054
1055 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1056
1057         PR gdb/18644:
1058         * f-lang.c (build_fortran_types): Handle the case where
1059         gdbarch_floatformat_for_type returns a nullptr.
1060
1061 2019-05-21  Tom de Vries  <tdevries@suse.de>
1062
1063         PR cli/24587
1064         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1065
1066 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1067
1068         PR gdb/18644:
1069         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1070         16-byte floats.
1071         * i386-tdep.c (i386_floatformat_for_type): Use
1072         floatformats_ia64_quad for the 16-byte floating point component
1073         within a fortran 32-byte complex number.
1074
1075 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1076
1077         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1078         delete default constructor.
1079         (find_partial_die): Update to return const struct.
1080         (partial_die_parent_scope): Move variable declaration into scope
1081         of its use and change its type to auto.
1082         (guess_partial_die_structure_name): Likewise.
1083         (partial_die_info::fixup): Likewise.
1084
1085 2019-05-17  Tom Tromey  <tromey@adacore.com>
1086
1087         * source.c (find_and_open_source): Remove cast.
1088
1089 2019-05-17  Tom Tromey  <tromey@adacore.com>
1090
1091         * annotate.c (annotate_source): Make "filename" const.
1092         * annotate.h (annotate_source): Use const.
1093
1094 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1095
1096         * disasm.c (set_disassembler_options): Send errors to stderr.
1097
1098 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1099
1100         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1101         (cli_interp_base::set_logging): Check debug_redirect.
1102         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1103         * cli/cli-logging.c (debug_redirect): Add static variable.
1104         (pop_output_files): Add default param.
1105         (handle_redirections): Print debug setting.
1106         (show_logging_command): Likewise.
1107         (_initialize_cli_logging): Add debugredirect command.
1108         * interps.c (current_interp_set_logging): Add debug_redirect
1109         parameter.
1110         * interps.h (set_logging): Add debug_redirect parameter.
1111         (current_interp_set_logging): Likewise.
1112         * mi/mi-common.h: Likewise.
1113         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1114
1115 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1116             Tom Tromey  <tromey@adacore.com>
1117
1118         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1119         directly.
1120         * cli/cli-interp.h (make_logging_output): Remove declaration.
1121         * cli/cli-logging.c (make_logging_output): Remove function.
1122         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1123         directly.
1124         * ui-file.c (tee_file::tee_file): Remove bools.
1125         (tee_file::~tee_file): Remove deletes.
1126         * ui-file.h (tee_file): Remove bools.
1127
1128 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1129
1130         * mi/mi-cmds.h (mi_cmd_complete): New function.
1131         * mi/mi-main.c (mi_cmd_complete): Likewise.
1132         * mi/mi-cmds.c: Define new MI command -complete.
1133         * NEWS: Mention new -complete command.
1134
1135 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1136
1137         * completer.h (complete): New function.
1138         * completer.c (complete): Likewise.
1139         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1140         function defined in completer.h.
1141
1142 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1143
1144         * MAINTAINERS (Write After Approval): Add myself.
1145
1146 2019-05-17  Tom de Vries  <tdevries@suse.de>
1147
1148         PR gdb/24094
1149         * dwarf2read.c (struct cu_partial_die_info): New struct.
1150         (find_partial_die): Return cu_partial_die_info.
1151         (partial_die_parent_scope, guess_partial_die_structure_name)
1152         (partial_die_info::fixup): Handle new return type of find_partial_die.
1153
1154 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1155
1156         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1157         "std::string", simplifying the algorithm.
1158
1159 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1160
1161         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1162         (stap_static_probe_ops::get_probes): Likewise.
1163
1164 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1165
1166         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1167         '-')" and "else if".
1168         (stap_parse_single_operand): Join checks for
1169         "gdbarch_stap_parse_special_token_p" and
1170         "gdbarch_stap_parse_special_token" in the same "if" statement.
1171         Invert check when verifying for operation on register
1172         displacement.
1173
1174 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1175
1176         * stap-probe.c (stap_get_opcode): Update comment.
1177         (stap_get_expected_argument_type): Likewise.
1178         (handle_stap_probe): Likewise.
1179
1180 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1181
1182         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1183         return type to 'bool'.  Adjust comment.  Use 'bool' when
1184         appropriate.
1185         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1186         * stap-probe.c (stap_parse_argument_1): Likewise.
1187         (stap_is_operator): Likewise.
1188         (stap_is_generic_prefix): Likewise.
1189         (stap_is_register_prefix): Likewise.
1190         (stap_is_register_indirection_prefix): Likewise.
1191         (stap_is_integer_prefix): Likewise.
1192         (stap_generic_check_suffix): Likewise.
1193         (stap_check_integer_suffix): Likewise.
1194         (stap_check_register_suffix): Likewise.
1195         (stap_check_register_indirection_suffix): Likewise.
1196         (stap_parse_register_operand): Likewise.
1197         (stap_parse_single_operand): Likewise.
1198         (stap_parse_argument_1): Likewise.
1199         (stap_probe::get_argument_count): Likewise.
1200         (stap_is_operator): Likewise.
1201
1202 2019-05-16  Tom Tromey  <tromey@adacore.com>
1203
1204         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1205         keyword to foreach.
1206
1207 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1208
1209         * linux-thread-db.c (try_thread_db_load_1): Change return type
1210         to bool.
1211         (try_thread_db_load): Likewise.
1212         (try_thread_db_load_from_pdir_1): Likewise.
1213         (try_thread_db_load_from_pdir): Likewise.
1214         (try_thread_db_load_from_sdir): Likewise.
1215         (try_thread_db_load_from_dir): Likewise.
1216         (thread_db_load_search): Likewise.
1217         (has_libpthread): Likewise.
1218         (thread_db_load): Likewise.
1219
1220 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1221
1222         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1223         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1224         NULL, and complain/return if that's the case.
1225
1226 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1227
1228         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1229         (advance, posn, abstract_read_memory): New functions.
1230         [struct mem_read_abstraction]: New struct.
1231         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1232
1233 2019-05-14  Tom Tromey  <tromey@adacore.com>
1234
1235         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1236         value is not lval_memory.
1237
1238 2019-05-14  Tom Tromey  <tromey@adacore.com>
1239
1240         * solib.c (info_sharedlibrary_command): Style the file name.
1241
1242 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1243
1244         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1245         (aarch64_vnv_type): Likewise.
1246         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1247         * common/tdesc.c: Likewise.
1248         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1249         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1250         * features/aarch64-fpu.xml: Add ieee half view.
1251         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1252         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1253         * gdbtypes.h (struct builtin_type): Likewise.
1254         (struct objfile_type): Likewise.
1255
1256 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1257
1258         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1259         typo.
1260         * location.h (string_to_event_location): Likewise.
1261
1262 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1263
1264         GDB 8.3 released.
1265
1266 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1267
1268         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1269         New variable declaration.
1270         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1271         New variable.
1272         (print_one_breakpoint): Use ui_out::test_flags and new global
1273         variable to compute use_fixed_output.
1274         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1275         Remove.
1276         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1277         (mi_multi_location_breakpoint_output_fixed): Remove.
1278         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1279         new variable.
1280         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1281         fix_multi_location_breakpoint_output flag if version >= 3.
1282         * ui-out.h (enum ui_out_flag)
1283         <fix_multi_location_breakpoint_output>: New enumerator.
1284
1285 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1286
1287         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1288
1289 2019-05-10  Tom Tromey  <tromey@adacore.com>
1290
1291         * ada-lang.c (catch_ada_completer): New function.
1292         (_initialize_ada_language): Use it.
1293
1294 2019-05-10  Tom Tromey  <tromey@adacore.com>
1295
1296         * thread.c (print_thread_info): Make "requested_threads" const.
1297         * gdbthread.h (print_thread_info): Make "requested_threads"
1298         const.
1299         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1300         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1301
1302 2019-05-08  Tom Tromey  <tom@tromey.com>
1303
1304         * gdbtypes.c (objfile_type_data): Change type.
1305         (objfile_type, _initialize_gdbtypes): Update.
1306
1307 2019-05-08  Tom Tromey  <tom@tromey.com>
1308
1309         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1310         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1311         (_initialize_dwarf2_frame): Update.
1312
1313 2019-05-08  Tom Tromey  <tom@tromey.com>
1314
1315         * objc-lang.c (objc_objfile_data): Change type.
1316         (find_methods): Update.
1317         (_initialize_objc_lang): Remove.
1318
1319 2019-05-08  Tom Tromey  <tom@tromey.com>
1320
1321         * stabsread.c (rs6000_builtin_type_data): Change type.
1322         (rs6000_builtin_type, _initialize_stabsread): Update.
1323
1324 2019-05-08  Tom Tromey  <tom@tromey.com>
1325
1326         * mips-tdep.c (mips_pdr_data): Remove.
1327         (_initialize_mips_tdep): Update.
1328
1329 2019-05-08  Tom Tromey  <tom@tromey.com>
1330
1331         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1332         (hppa_init_objfile_priv_data, read_unwind_info)
1333         (find_unwind_entry, _initialize_hppa_tdep): Update.
1334
1335 2019-05-08  Tom Tromey  <tom@tromey.com>
1336
1337         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1338         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1339         on obstack.
1340         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1341
1342 2019-05-08  Tom Tromey  <tom@tromey.com>
1343
1344         * mdebugread.c (basic_type_data): Change type.
1345         (basic_type, _initialize_mdebugread): Update.
1346
1347 2019-05-08  Tom Tromey  <tom@tromey.com>
1348
1349         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1350
1351 2019-05-08  Tom Tromey  <tom@tromey.com>
1352
1353         * nto-tdep.c (nto_inferior_data_reg): Change type.
1354         (nto_inferior_data): Update.
1355         (nto_inferior_data_cleanup, nto_new_inferior_data)
1356         (_initialize_nto_tdep): Remove.
1357         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1358
1359 2019-05-08  Tom Tromey  <tom@tromey.com>
1360
1361         * ada-lang.c (struct ada_inferior_data): Add initializers.
1362         (ada_inferior_data): Change type.
1363         (ada_inferior_data_cleanup): Remove.
1364         (get_ada_inferior_data, ada_inferior_exit)
1365         (struct ada_pspace_data): Add initializers, destructor.
1366         (ada_pspace_data_handle): Change type.
1367         (get_ada_pspace_data): Update.
1368         (ada_pspace_data_cleanup): Remove.
1369
1370 2019-05-08  Tom Tromey  <tom@tromey.com>
1371
1372         * coffread.c (struct coff_symfile_info): Add initializers.
1373         (coff_objfile_data_key): Move lower.  Change type.
1374         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1375         Update.
1376         (coff_free_info): Remove.
1377
1378 2019-05-08  Tom Tromey  <tom@tromey.com>
1379
1380         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1381         (fbsd_pspace_data_handle): Move lower.  Change type.
1382         (get_fbsd_pspace_data): Update.
1383         (fbsd_pspace_data_cleanup): Remove.
1384         (_initialize_fbsd_tdep): Update.
1385
1386 2019-05-08  Tom Tromey  <tom@tromey.com>
1387
1388         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1389         (get_ada_tasks_pspace_data): Update.
1390         (ada_tasks_pspace_data_cleanup): Remove.
1391         (_initialize_tasks): Update.
1392         (ada_tasks_inferior_data_handle): Change type.
1393         (get_ada_tasks_inferior_data): Update.
1394         (ada_tasks_inferior_data_cleanup): Remove.
1395         (struct ada_tasks_pspace_data): Add initializers.
1396
1397 2019-05-08  Tom Tromey  <tom@tromey.com>
1398
1399         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1400         * symfile-debug.c (debug_sym_get_probes): Change type.
1401         * stap-probe.c (handle_stap_probe):
1402         (stap_static_probe_ops::get_probes): Change type.
1403         * probe.h (class static_probe_ops) <get_probes>: Change type.
1404         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1405         (parse_probes_in_pspace): Update.
1406         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1407         Update.
1408         (any_static_probe_ops::get_probes): Change type.
1409         * elfread.c (elfread_data): New typedef.
1410         (probe_key): Change type.
1411         (elf_get_probes): Likewise.  Update.
1412         (probe_key_free): Remove.
1413         (_initialize_elfread): Update.
1414         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1415         Change type.
1416         (dtrace_process_dof_probe, dtrace_process_dof)
1417         (dtrace_static_probe_ops::get_probe): Change type.
1418
1419 2019-05-08  Tom Tromey  <tom@tromey.com>
1420
1421         * xcoffread.c (struct xcoff_symfile_info): Rename from
1422         coff_symfile_info.  Add initializers.
1423         (xcoff_objfile_data_key): Move lower.  Change type.
1424         (XCOFF_DATA): Rewrite.
1425         (xcoff_free_info): Remove.
1426         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1427         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1428         (xcoff_initial_scan): Update.
1429
1430 2019-05-08  Tom Tromey  <tom@tromey.com>
1431
1432         * solib-svr4.c (struct svr4_info): Add initializers and
1433         destructor.
1434         <probes_table>: Now an htab_up.
1435         (solib_svr4_pspace_data): Change type.
1436         (free_probes_table): Simplify.
1437         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1438         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1439         (probes_table_remove_objfile_probes, register_solib_event_probe)
1440         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1441         (_initialize_svr4_solib): Update.
1442
1443 2019-05-08  Tom Tromey  <tom@tromey.com>
1444
1445         * remote.c (remote_pspace_data): Change type.
1446         (remote_pspace_data_cleanup): Remove.
1447         (get_remote_exec_file, set_pspace_remote_exec_file)
1448         (_initialize_remote): Update.
1449
1450 2019-05-08  Tom Tromey  <tom@tromey.com>
1451
1452         * breakpoint.c (breakpoint_objfile_key): Change type.
1453         (get_breakpoint_objfile_data): Update.
1454         (free_breakpoint_objfile_data): Remove.
1455         (_initialize_breakpoint): Update.
1456
1457 2019-05-08  Tom Tromey  <tom@tromey.com>
1458
1459         * linux-tdep.c (struct linux_info): Add initializers.
1460         (linux_inferior_data): Move.  Change type.
1461         (invalidate_linux_cache_inf): Update.
1462         (linux_inferior_data_cleanup): Remove.
1463         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1464
1465 2019-05-08  Tom Tromey  <tom@tromey.com>
1466
1467         * auxv.c (auxv_inferior_data): Move.  Change type.
1468         (auxv_inferior_data_cleanup): Remove.
1469         (invalidate_auxv_cache_inf): Rewrite.
1470         (get_auxv_inferior_data, _initialize_auxv): Update.
1471
1472 2019-05-08  Tom Tromey  <tom@tromey.com>
1473
1474         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1475         (symfile_debug_objfile_data_key): Change type.
1476         (symfile_debug_installed, debug_qf_has_symbols)
1477         (debug_qf_find_last_source_symtab)
1478         (debug_qf_forget_cached_source_info)
1479         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1480         (debug_qf_print_stats, debug_qf_dump)
1481         (debug_qf_expand_symtabs_for_function)
1482         (debug_qf_expand_all_symtabs)
1483         (debug_qf_expand_symtabs_with_fullname)
1484         (debug_qf_map_matching_symbols)
1485         (debug_qf_expand_symtabs_matching)
1486         (debug_qf_find_pc_sect_compunit_symtab)
1487         (debug_qf_map_symbol_filenames)
1488         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1489         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1490         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1491         (debug_sym_read_linetable, debug_sym_relocate): Update.
1492         (symfile_debug_free_objfile): Remove.
1493         (install_symfile_debug_logging, _initialize_symfile_debug):
1494         Update.
1495
1496 2019-05-08  Tom Tromey  <tom@tromey.com>
1497
1498         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1499         allocate_on_obstack.
1500         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1501         (get_dwarf2_per_objfile): Update.
1502         (set_dwarf2_per_objfile): Remove.
1503         (dwarf2_has_info, dwarf2_get_section_info): Update.
1504         (dwarf2_free_objfile): Remove.
1505         (_initialize_dwarf2_read): Update.
1506
1507 2019-05-08  Tom Tromey  <tom@tromey.com>
1508
1509         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1510         initializers.
1511         <unsupported_script_warning_printed,
1512         script_not_found_warning_printed>: Now bool.
1513         (auto_load_pspace_data): Change type.
1514         (~auto_load_pspace_info): Rename from
1515         auto_load_pspace_data_cleanup.
1516         (get_auto_load_pspace_data, init_loaded_scripts_info)
1517         (clear_section_scripts, maybe_print_unsupported_script_warning)
1518         (maybe_print_script_not_found_warning, _initialize_auto_load):
1519         Update.
1520
1521 2019-05-08  Tom Tromey  <tom@tromey.com>
1522
1523         * objfiles.c (objfile_pspace_info): Add destructor and
1524         initializers.
1525         (objfiles_pspace_data): Change type.
1526         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1527         (get_objfile_pspace_data): Update.
1528         (objfiles_bfd_data): Change type.
1529         (get_objfile_bfd_data): Update.
1530         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1531
1532 2019-05-08  Tom Tromey  <tom@tromey.com>
1533
1534         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1535         Change type.
1536         (get_catch_syscall_inferior_data): Update.
1537         (catch_syscall_inferior_data_cleanup): Remove.
1538         (_initialize_break_catch_syscall): Update.
1539
1540 2019-05-08  Tom Tromey  <tom@tromey.com>
1541
1542         * inflow.c (struct terminal_info): Add destructor and
1543         initializers.
1544         (inflow_inferior_data): Change type.
1545         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1546         (get_inflow_inferior_data, inflow_inferior_exit)
1547         (swap_terminal_info, _initialize_inflow): Update.
1548
1549 2019-05-08  Tom Tromey  <tom@tromey.com>
1550
1551         * target-dcache.c (target_dcache_cleanup): Remove.
1552         (target_dcache_aspace_key): Change type.
1553         (target_dcache_init_p, target_dcache_invalidate)
1554         (target_dcache_get, target_dcache_get_or_init)
1555         (_initialize_target_dcache): Update.
1556         * dcache.h (struct dcache_deleter): New.
1557
1558 2019-05-08  Tom Tromey  <tom@tromey.com>
1559
1560         * symtab.c (struct symbol_cache): Add destructor and
1561         initializers.
1562         (symbol_cache_key): Move.  Change type.
1563         (make_symbol_cache, free_symbol_cache): Remove.
1564         (get_symbol_cache): Update.
1565         (symbol_cache_cleanup): Remove.
1566         (ALL_PSPACES, symbol_cache_flush)
1567         (maintenance_print_symbol_cache)
1568         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1569         Update.
1570
1571 2019-05-08  Tom Tromey  <tom@tromey.com>
1572
1573         * symtab.c (struct main_info): Add destructor and initializers.
1574         (main_progspace_key): Move.  Change type.
1575         (get_main_info): Update.
1576         (main_info_cleanup): Remove.
1577         (_initialize_symtab): Update.
1578
1579 2019-05-08  Tom Tromey  <tom@tromey.com>
1580
1581         * registry.h (DECLARE_REGISTRY): Define the _key class.
1582
1583 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1584
1585         * NEWS: Merge two 'New commands' sections.
1586
1587 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1588
1589         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1590         parameter and use Ada language definition instead.
1591         (ada_val_print_ptr): Remove unused language parameter.
1592         (ada_val_print_num): Remove language parameter and use Ada language
1593         definition instead.
1594         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1595         parameter.
1596         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1597         parameter and use Ada language definition instead.
1598         (ada_val_print_1): Update all ada_val_print_xxx calls.
1599         Remove language parameter.
1600         (ada_val_print): Update ada_val_print_1 call.
1601
1602 2019-05-08  Tom Tromey  <tromey@adacore.com>
1603
1604         * remote.c (remote_hw_watchpoint_limit)
1605         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1606         Now static.
1607
1608 2019-05-08  Tom Tromey  <tromey@adacore.com>
1609
1610         * maint.c (_initialize_maint_cmds): Move initialization code to
1611         remote.c.
1612         (watchdog, show_watchdog): Move to remote.c.
1613         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1614         "watchdog" static.
1615         (_initialize_remote): Move initialization code from maint.c.
1616         * defs.h (watchdog): Don't declare.
1617
1618 2019-05-08  Tom Tromey  <tromey@adacore.com>
1619
1620         * tui/tui-interp.c: Include main.h.
1621         * interps.c: Include main.h.
1622         * main.h (interpreter_p): Declare.
1623         * defs.h (interpreter_p): Don't declare.
1624
1625 2019-05-08  Tom Tromey  <tromey@adacore.com>
1626
1627         * dwarf2loc.c: Include dwarf2read.h.
1628         * defs.h (read_unsigned_leb128): Don't declare.
1629         * dwarf2read.h (read_unsigned_leb128): Declare.
1630
1631 2019-05-08  Tom Tromey  <tromey@adacore.com>
1632
1633         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1634         method.
1635
1636 2019-05-08  Tom Tromey  <tromey@adacore.com>
1637
1638         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1639         when no wrap column is set.
1640
1641 2019-05-08  Tom Tromey  <tromey@adacore.com>
1642
1643         * c-lang.c (c_get_string): Handle non-C-style arrays.
1644
1645 2019-05-08  Tom Tromey  <tromey@adacore.com>
1646
1647         * typeprint.c (print_offset_data::update): Print the bit offset,
1648         not the number of bits remaining.
1649
1650 2019-05-08  Tom Tromey  <tromey@adacore.com>
1651
1652         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1653         padding at end of comment.
1654
1655 2019-05-08  Tom Tromey  <tromey@adacore.com>
1656
1657         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1658         Compare main types.
1659
1660 2019-05-06  Tom Tromey  <tom@tromey.com>
1661
1662         * common/scoped_mmap.c: Include common-defs.h.
1663         * common/scoped_mmap.h: Don't include config.h.
1664
1665 2019-05-04  Tom Tromey  <tom@tromey.com>
1666
1667         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1668         (struct aarch64_call_info): Add initializers.
1669         <si>: Now a std::vector.
1670         (pass_on_stack, aarch64_push_dummy_call): Update.
1671
1672 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1673             Tom Tromey  <tom@tromey.com>
1674
1675         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1676         (ppc_threads): Now a std::vector.  Now static.
1677         (hwdebug_find_thread_points_by_tid)
1678         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1679         Update.
1680
1681 2019-05-04  Tom Tromey  <tom@tromey.com>
1682
1683         * arc-tdep.c (arc_tdesc_init): Return bool.
1684
1685 2019-05-04  Tom Tromey  <tom@tromey.com>
1686
1687         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1688         Use gdb_assert_not_reached.
1689
1690 2019-05-04  Tom Tromey  <tom@tromey.com>
1691
1692         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1693         "false".
1694
1695 2019-05-04  Tom Tromey  <tom@tromey.com>
1696
1697         * arc-tdep.c (arc_tdesc_init): Use bool.
1698
1699 2019-05-04  Tom Tromey  <tom@tromey.com>
1700
1701         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1702
1703 2019-05-04  Tom Tromey  <tom@tromey.com>
1704
1705         * cli/cli-cmds.c (valid_command_p): Return bool.
1706
1707 2019-05-04  Tom Tromey  <tom@tromey.com>
1708
1709         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1710         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1711
1712 2019-05-04  Raul Tambre  <raul@tambre.ee>
1713
1714         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1715         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1716         operator for comparison.
1717
1718 2019-05-04  Tom Tromey  <tom@tromey.com>
1719
1720         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1721         (lookup_partial_symbol, print_partial_symbols)
1722         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1723         (psymbol_compare): Update.
1724         (add_psymbol_to_bcache): Clear the entire psymbol.
1725         (maintenance_check_psymtabs): Update.
1726         * psympriv.h (struct partial_symbol): Don't derive from
1727         general_symbol_info.
1728         <obj_section, unrelocated_address, address,
1729         set_unrelocated_address>: Update.
1730         <ginfo>: New member.
1731         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1732         (debug_names::write_psymbols): Update.
1733
1734 2019-05-04  Tom de Vries  <tdevries@suse.de>
1735
1736         * contrib/cc-with-tweaks.sh: Support -n arg.
1737
1738 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1739
1740         * corelow.c (core_target::detach): Ensure frame cache and
1741         register caches are cleared.
1742         inferior.c (exit_inferior_1): Likewise.
1743
1744 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1745             Tom Tromey  <tom@tromey.com>
1746
1747         * dictionary.c (collate_pending_symbols_by_language): Remove
1748         "struct" from foreach.
1749         * symtab.c (lookup_global_symbol_from_objfile)
1750         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1751         foreach.
1752         * ser-tcp.c (net_open): Remove "struct" from foreach.
1753         * objfiles.c (objfile_relocate, objfile_rebase)
1754         (objfile_has_symbols): Remove "struct" from foreach.
1755         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1756         from foreach.
1757         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1758         foreach.
1759         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1760         "struct" from foreach.
1761         * ada-lang.c (create_excep_cond_exprs)
1762         (ada_exception_catchpoint_cond_string): Remove "struct" from
1763         foreach.
1764
1765 2019-05-03  Tom Tromey  <tromey@adacore.com>
1766
1767         * ada-exp.y (convert_char_literal): Check suffix of each
1768         enumerator.
1769
1770 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1771
1772         PR ada/21406:
1773         * ada-exp.y (yywrap): Don't define.
1774         * ada-lex.l (%option): Add noyywrap
1775         (yywrap): Remove.
1776
1777 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1778
1779         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1780         _WIN32_WINNT to the XP level, unless already defined to a higher
1781         level.
1782
1783         * unittests/parse-connection-spec-selftests.c:
1784         * ser-tcp.c:
1785         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1786         override.
1787
1788         * symfile.c (find_separate_debug_file): Remove colon from the
1789         drive spec of DOS/Windows file names of the target, so that the
1790         file name produced from DEBUGDIR and the target's directory will
1791         be valid on DOS/Windows systems.
1792
1793 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1794
1795         * rust-lang.c (val_print_struct): Handle printing structures
1796         containing strings.
1797
1798 2019-05-02  Tom Tromey  <tromey@adacore.com>
1799
1800         * valarith.c (_initialize_valarith): Remove.
1801
1802 2019-05-01  Tom Tromey  <tromey@adacore.com>
1803
1804         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1805         bitfields.
1806
1807 2019-05-01  Tom Tromey  <tromey@adacore.com>
1808
1809         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1810         for big-endian copies.
1811
1812 2019-04-30  Ali Tamur  <tamur@google.com>
1813         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1814         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1815         (read_3_bytes): New function.
1816
1817 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1818
1819         * windows-nat.c (main_thread_id): Delete.
1820         (handle_output_debug_string): Replace main_thread_id by
1821         current_event.dwThreadId.
1822         (fake_create_process): Likewise.
1823         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1824         Do not set main_thread_id.
1825         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1826         current_event.dwThreadId.
1827         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1828
1829 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1830
1831         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1832         Use current_event.dwThreadId instead of main_thread_id.
1833
1834 2019-04-30  Tom Tromey  <tromey@adacore.com>
1835
1836         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1837         (create_excep_cond_exprs): Iterate over program spaces.
1838         (ada_exception_catchpoint_cond_string): Examine all minimal
1839         symbols for exception types.
1840
1841 2019-04-30  Tom Tromey  <tromey@adacore.com>
1842
1843         PR c++/24470:
1844         * dwarf2read.c (process_structure_scope): Handle case where type
1845         has template parameters but no symbol was created.
1846
1847 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1848             Chris January  <chris.january@arm.com>
1849
1850         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1851         qualifier.
1852         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1853
1854 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1855
1856         * f-typeprint.c (f_print_type): Update rules for printing
1857         whitespace.
1858         (f_type_print_varspec_suffix): Likewise.
1859
1860 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1861             Chris January  <chris.january@arm.com>
1862
1863         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1864         function arguments.
1865
1866 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1867
1868         * f-lang.c (build_fortran_types): Change name of void type to
1869         lower case.
1870         * f-typeprint.c (f_type_print_base): Print the name of the void
1871         type, rather than a fixed string.
1872         * f-valprint.c (f_decorations): Use lower case void string.
1873
1874 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1875             Chris January  <chris.january@arm.com>
1876
1877         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1878         types for Fortran.
1879
1880 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1881             Chris January  <chris.january@arm.com>
1882             David Lecomber  <david.lecomber@arm.com>
1883
1884         * f-exp.y (BINOP_INTRINSIC): New token.
1885         (exp): New parser rule handling BINOP_INTRINSIC.
1886         (f77_keywords): Add new builtin procedures.
1887         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1888         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1889         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1890         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1891         (print_unop_subexp_f): New function.
1892         (print_binop_subexp_f): New function.
1893         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1894         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1895         (dump_subexp_body_f): Likewise.
1896         (operator_check_f): Likewise.
1897         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1898         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1899
1900 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1901
1902         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1903         UNOP_KIND.
1904         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1905         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1906         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1907         (operator_length_f): New fuction.
1908         (print_subexp_f): New function.
1909         (op_name_f): New function.
1910         (dump_subexp_body_f): New function.
1911         (operator_check_f): New function.
1912         (exp_descriptor_f): Replace standard expression handling functions
1913         with new functions.
1914         * gdb/fortran-operator.def: New file.
1915         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1916         * gdb/std-operator.def: Remove UNOP_KIND.
1917
1918 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1919
1920         * std-operator.def: Remove unbalanced, stray double quote
1921         character.
1922
1923 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1924             Chris January  <chris.january@arm.com>
1925             Daniel Everett  <daniel.everett@arm.com>
1926             Nick Forrington  <nick.forrington@arm.com>
1927             Richard Bunt  <richard.bunt@arm.com>
1928
1929         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1930         of depth when printing anonymous structs or unions.
1931         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1932         Don't print either the top-level value, or the children if the
1933         max-depth is exceeded.
1934         (ppscm_print_children): When printing the key of a map, allow one
1935         extra level of depth.
1936         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1937         print either the top-level value, or the children if the max-depth
1938         is exceeded.
1939         (print_children): When printing the key of a map, allow one extra
1940         level of depth.
1941         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1942         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1943         (user_print_options): Initialise max_depth field.
1944         (val_print_scalar_or_string_type_p): New function.
1945         (val_print): Check to see if the max depth has been reached.
1946         (val_print_check_max_depth): Define new function.
1947         (show_print_max_depth): New function.
1948         (_initialize_valprint): Add 'print max-depth' option.
1949         * valprint.h (struct value_print_options) <max_depth>: New field.
1950         (val_print_check_max_depth): Declare new function.
1951         * NEWS: Document new feature.
1952
1953 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1954
1955         * ada-lang.c (ada_language_defn): Initialise new field.
1956         * c-lang.c (c_is_string_type_p): New function.
1957         (c_language_defn): Initialise new field.
1958         (cplus_language_defn): Initialise new field.
1959         (asm_language_defn): Initialise new field.
1960         (minimal_language_defn): Initialise new field.
1961         * c-lang.h (c_is_string_type_p): Declare new function.
1962         * d-lang.c (d_language_defn): Initialise new field.
1963         * f-lang.c (f_is_string_type_p): New function.
1964         (f_language_defn): Initialise new field.
1965         * go-lang.c (go_is_string_type_p): New function.
1966         (go_language_defn): Initialise new field.
1967         * language.c (default_is_string_type_p): New function.
1968         (unknown_language_defn): Initialise new field.
1969         (auto_language_defn): Initialise new field.
1970         * language.h (struct language_defn) <la_is_string_type_p>: New
1971         member variable.
1972         (default_is_string_type_p): Declare new function.
1973         * m2-lang.c (m2_language_defn): Initialise new field.
1974         * objc-lang.c (objc_language_defn): Initialise new field.
1975         * opencl-lang.c (opencl_language_defn): Initialise new field.
1976         * p-lang.c (pascal_is_string_type_p): New function.
1977         (pascal_language_defn): Initialise new field.
1978         * rust-lang.c (rust_is_string_type_p): New function.
1979         (rust_language_defn): Initialise new field.
1980
1981 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1982
1983         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1984         New field.
1985         * ada-lang.c (ada_language_defn): Initialise new field.
1986         * c-lang.c (c_language_defn): Likewise.
1987         (cplus_language_defn): Likewise.
1988         (asm_language_defn): Likewise.
1989         (minimal_language_defn): Likewise.
1990         * d-lang.c (d_language_defn): Likewise.
1991         * f-lang.c (f_language_defn): Likewise.
1992         * go-lang.c (go_language_defn): Likewise.
1993         * language.c (unknown_language_defn): Likewise.
1994         (auto_language_defn): Likewise.
1995         * m2-lang.c (m2_language_defn): Likewise.
1996         * objc-lang.c (objc_language_defn): Likewise.
1997         * opencl-lang.c (opencl_language_defn): Likewise.
1998         * p-lang.c (pascal_language_defn): Likewise.
1999         * rust-lang.c (rust_language_defn): Likewise.
2000
2001 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2002
2003         * ada-lang.c (ada_is_character_type): Change return type to bool.
2004         (ada_is_string_type): Likewise.
2005         * ada-lang.h (ada_is_character_type): Update declaration
2006         (ada_is_string_type): Likewise.
2007
2008 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2009
2010         Support style in 'frame|thread apply'
2011
2012         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2013         * record.c (record_start, record_stop): Update callers of
2014         execute_command_to_string with false.
2015         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2016         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2017         methods.
2018         (class string_file): New constructor with term_out parameter.
2019         Override methods term_out and can_emit_style_escape.  New member
2020         term_out.
2021         (class stdio_file): Override can_emit_style_escape.
2022         (class tee_file): Override term_out and can_emit_style_escape.
2023         * utils.h (can_emit_style_escape): Remove.
2024         * utils.c (can_emit_style_escape): Likewise.
2025         Update all callers of can_emit_style_escape (SOMESTREAM) to
2026         SOMESTREAM->can_emit_style_escape.
2027         * source-cache.c (source_cache::get_source_lines): Likewise.
2028         * stack.c (frame_apply_command_count): Call execute_command_to_string
2029         passing the term_out characteristic of the current gdb_stdout.
2030         * thread.c (thr_try_catch_cmd): Likewise.
2031         * top.c (execute_command_to_string): pass term_out parameter
2032         to construct the string_file for the command output.
2033         * ui-file.c (term_cli_styling): New function (most code moved
2034         from utils.c can_emit_style_escape).
2035         (string_file::string_file, string_file::can_emit_style_escape,
2036         stdio_file::can_emit_style_escape, tee_file::term_out,
2037         tee_file::can_emit_style_escape): New functions.
2038
2039 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2040
2041         * NEWS: Mention the new set|show may-call-functions.
2042         * infcall.c (may_call_functions_p): New variable.
2043         (show_may_call_functions_p): New function.
2044         (call_function_by_hand_dummy): Throws an error if not
2045         may-call-functions.
2046         (_initialize_infcall): Call add_setshow_boolean_cmd for
2047         may-call-functions.
2048
2049 2019-04-25  Keith Seitz  <keiths@redhat.com>
2050
2051         PR c++/24367
2052         * cp-support.c (inspect_type): Don't attempt substitutions
2053         of symbol with the same name.
2054
2055 2019-04-25  Tom Tromey  <tromey@adacore.com>
2056
2057         PR gdb/24475:
2058         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2059         static.
2060
2061 2019-04-25  Tom Tromey  <tromey@adacore.com>
2062
2063         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2064         rvalue reference.
2065         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2066         (gdb_xml_parser::parse): Use std::move.
2067         * python/python-internal.h (gdbpy_convert_exception): Take a const
2068         reference.
2069         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2070         std::move.
2071         * python/py-utils.c (gdbpy_convert_exception): Take a const
2072         reference.
2073         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2074         Use std::move.
2075         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2076         Use std::move.
2077         * mi/mi-main.c (mi_print_exception): Take a const reference.
2078         * main.c (handle_command_errors): Take a const reference.
2079         * linespec.c (parse_linespec): Use std::move.
2080         * infcall.c (run_inferior_call): Use std::move.
2081         (call_function_by_hand_dummy): Use std::move.
2082         * exec.c (try_open_exec_file): Use std::move.
2083         * exceptions.h (exception_print, exception_fprintf)
2084         (exception_print_same): Update.
2085         * exceptions.c (print_exception, exception_print)
2086         (exception_fprintf, exception_print_same): Change parameters to
2087         const reference.
2088         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2089         * common/new-op.c: Use std::move.
2090         * common/common-exceptions.h (struct gdb_exception): Add move
2091         constructor.
2092         (struct gdb_exception_error, struct gdb_exception_quit, struct
2093         gdb_quit_bad_alloc): Change constructor to move constructor.
2094         (throw_exception): Change parameter to rvalue reference.
2095         * common/common-exceptions.c (throw_exception): Take rvalue
2096         reference.
2097         * cli/cli-interp.c (safe_execute_command): Use std::move.
2098         * breakpoint.c (insert_bp_location, location_to_sals): Use
2099         std::move.
2100
2101 2019-04-25  Tom Tromey  <tromey@adacore.com>
2102
2103         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2104         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2105         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2106         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2107         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2108         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2109         guile/scm-value.c: Use unpack.
2110         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2111         gdbscm_gdb_exception.
2112         (gdbscm_throw_gdb_exception): Likewise.
2113         (struct gdbscm_gdb_exception): New.
2114         (unpack): New function.
2115         (gdbscm_wrap): Use unpack.
2116
2117 2019-04-25  Tom Tromey  <tromey@adacore.com>
2118
2119         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2120         (gdb_rl_callback_handler): Use std::move.
2121         * common/common-exceptions.h (struct gdb_exception): Add move
2122         assignment operator.
2123         (throw_exception_sjlj): Change "exception" to const reference.
2124         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2125         (throw_exception_sjlj): Change "exception" to const reference.
2126
2127 2019-04-25  Tom Tromey  <tromey@adacore.com>
2128
2129         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2130         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2131         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2132         Update.
2133         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2134         Update.
2135         * mi/mi-interp.c (mi_interp::exec): Update.
2136         * linespec.c (parse_linespec): Update.
2137         * infcall.c (run_inferior_call): Update.
2138         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2139         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2140         (gdbscm_lookup_global_symbol): Update.
2141         * guile/scm-param.c (gdbscm_parameter_value): Update.
2142         * guile/scm-frame.c (gdbscm_frame_read_register)
2143         (gdbscm_frame_read_var): Update.
2144         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2145         * exec.c (try_open_exec_file): Update.
2146         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2147         (gdb_rl_callback_handler): Update.
2148         * common/common-exceptions.h (exception_none): Don't declare.
2149         * common/common-exceptions.c (exception_none): Don't define.
2150         (struct catcher) <exception>: Update.
2151         * cli/cli-interp.c (safe_execute_command): Update.
2152         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2153
2154 2019-04-25  Ali Tamur  <tamur@google.com>
2155
2156         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2157         (read_attribute_value): Likewise.
2158         (dwarf2_read_addr_index): Update comment.
2159         (read_str_index): Add DW_FORM_strx.
2160         (dwarf2_string_attr): Likewise.
2161         (dwarf2_const_value_attr): Likewise.
2162         (dump_die_shallow): Likewise.
2163         (dwarf2_fetch_constant_bytes): Likewise.
2164         (skip_form_bytes): Likewise.
2165         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2166
2167 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2168
2169         PR corefiles/11608
2170         PR corefiles/18187
2171         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2172         OFFSET.  Verify if current mapping contains an ELF header.
2173         (linux_find_memory_regions_full): Adjust call to
2174         dump_mapping_p.
2175
2176 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2177             Kang Li <kanglictf@gmail.com>
2178
2179         PR gdb/21600
2180
2181         * dwarf2-frame.c (read_initial_length): Be consistent about using
2182         unsigned representation of length.
2183         (decode_frame_entry_1): Likewise.  Check for wraparound of
2184         end pointer as well as buffer overflow.
2185
2186 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2187
2188         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2189         "vq".
2190
2191 2019-04-24  Tom Tromey  <tromey@adacore.com>
2192
2193         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2194
2195 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2196
2197         * s12z-tdep.c (s12z_unwind_pc): Delete.
2198         (s12z_unwind_sp): Delete.
2199         (s12z_gdbarch_init): Don't register deleted functions with
2200         gdbarch.
2201
2202 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2203
2204         * rl78-tdep.c (rl78_unwind_sp): Delete.
2205         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2206
2207 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2208
2209         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2210         (xstormy16_unwind_pc): Delete.
2211         (xstormy16_dummy_id): Delete.
2212         (xstormy16_gdbarch_init): Don't register deleted functions with
2213         gdbarch.
2214
2215 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2216
2217         * vax-tdep.c (vax_unwind_pc): Delete.
2218         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2219
2220 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2221
2222         * v850-tdep.c (v850_unwind_sp): Delete.
2223         (v850_unwind_pc): Delete.
2224         (v850_dummy_id): Delete.
2225         (v850_gdbarch_init): Don't register deleted functions with
2226         gdbarch.
2227
2228 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2229
2230         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2231         (tilegx_unwind_pc): Delete.
2232         (tilegx_unwind_dummy_id): Delete.
2233         (tilegx_gdbarch_init): Don't register deleted functions with
2234         gdbarch.
2235
2236 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2237
2238         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2239         (tic6x_dummy_id): Delete.
2240         (tic6x_gdbarch_init): Don't register deleted functions with
2241         gdbarch.
2242
2243 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2244
2245         * sparc-tdep.c (sparc_unwind_pc): Delete.
2246         (sparc32_gdbarch_init): Don't register deleted function with
2247         gdbarch.
2248
2249 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2250
2251         * sh-tdep.c (sh_unwind_sp): Delete.
2252         (sh_unwind_pc): Delete.
2253         (sh_dummy_id): Delete.
2254         (sh_gdbarch_init): Don't register deleted functions with
2255         gdbarch.
2256
2257 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2258
2259         * score-tdep.c (score_unwind_sp): Delete.
2260         (score_unwind_pc): Delete.
2261         (score_dummy_id): Delete.
2262         (score_gdbarch_init): Don't register deleted functions with
2263         gdbarch.
2264
2265 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2266
2267         * rx-tdep.c (rx_unwind_pc): Delete.
2268         (rx_unwind_sp): Delete.
2269         (rx_dummy_id): Delete.
2270         (rx_gdbarch_init): Don't register deleted functions with
2271         gdbarch.  Update comment.
2272
2273 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2274
2275         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2276         (rs6000_dummy_id): Delete.
2277         (rs6000_gdbarch_init): Don't register deleted functions with
2278         gdbarch.
2279
2280 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2281
2282         * or1k-tdep.c (or1k_dummy_id): Delete.
2283         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2284
2285 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2286
2287         * nios2-tdep.c (nios2_dummy_id): Delete.
2288         (nios2_unwind_sp): Delete.
2289         (nios2_gdbarch_init): Don't register deleted functions with
2290         gdbarch.
2291
2292 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2293
2294         * nds32-tdep.c (nds32_dummy_id): Delete.
2295         (nds32_unwind_pc): Delete.
2296         (nds32_unwind_sp): Delete.
2297         (nds32_gdbarch_init): Don't register deleted functions with
2298         gdbarch.
2299
2300 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2301
2302         * msp430-tdep.c (msp430_unwind_pc): Delete.
2303         (msp430_unwind_sp): Delete.
2304         (msp430_dummy_id): Delete.
2305         (msp430_gdbarch_init): Don't register deleted functions with
2306         gdbarch.
2307
2308 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2309
2310         * moxie-tdep.c (moxie_unwind_sp): Delete.
2311         (moxie_unwind_pc): Delete.
2312         (moxie_dummy_id): Delete.
2313         (moxie_gdbarch_init): Don't register deleted functions with
2314         gdbarch.
2315
2316 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2317
2318         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2319         (mn10300_unwind_pc): Delete.
2320         (mn10300_unwind_sp): Delete.
2321         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2322         mn10300_unwind_sp.
2323         (mn10300_frame_unwind_init): Don't register deleted functions with
2324         gdbarch.
2325
2326 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2327
2328         * mep-tdep.c (mep_unwind_pc): Delete.
2329         (mep_unwind_sp): Delete.
2330         (mep_dummy_id): Delete.
2331         (mep_gdbarch_init): Don't register deleted functions with
2332         gdbarch.
2333
2334 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2335
2336         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2337         (m68hc11_unwind_sp): Delete.
2338         (m68hc11_gdbarch_init): Don't register deleted functions with
2339         gdbarch.
2340
2341 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2342
2343         * m32r-tdep.c (m32r_unwind_sp): Delete.
2344         (m32r_unwind_pc): Delete.
2345         (m32r_dummy_id): Delete.
2346         (m32r_gdbarch_init): Don't register deleted functions with
2347         gdbarch.
2348
2349 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2350
2351         * m32c-tdep.c (m32c_unwind_pc): Delete.
2352         (m32c_unwind_sp): Delete.
2353         (m32c_dummy_id): Delete.
2354         (m32c_gdbarch_init): Don't register deleted functions with
2355         gdbarch.
2356
2357 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2358
2359         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2360         (lm32_unwind_pc): Delete.
2361         (lm32_dummy_id): Delete.
2362         (lm32_gdbarch_init): Don't register deleted functions with
2363         gdbarch.
2364
2365 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2366
2367         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2368         (iq2000_unwind_pc): Delete.
2369         (iq2000_dummy_id): Delete.
2370         (iq2000_gdbarch_init): Don't register deleted functions with
2371         gdbarch.
2372
2373 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2374
2375         * nds32-tdep.c (nds32_type_align): Delete.
2376         (nds32_push_dummy_call): Use type_align instead.
2377
2378 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2379
2380         * arm-tdep.c (arm_type_align): Only handle vector override case.
2381         (arm_push_dummy_call): Use type_align.
2382         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2383
2384 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2385
2386         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2387         case.
2388         (pass_on_stack): Use type_align.
2389         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2390         function.
2391
2392 2019-04-23  Tom Tromey  <tromey@adacore.com>
2393
2394         * dwarf2read.c (line_header::file_name_at): Remove unused
2395         overload.
2396
2397 2019-04-23  Tom de Vries  <tdevries@suse.de>
2398
2399         PR gdb/24438
2400         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2401         invocation.
2402
2403
2404 2019-03-27  Ali Tamur  <tamur@google.com>
2405
2406         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2407         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2408         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2409         (dwarf_expr_context::get_addr_index): Likewise
2410         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2411         (symbol_needs_eval_context::get_addr_index): Likewise
2412         (disassemble_dwarf_expression): Add DW_OP_addrx
2413         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2414         (read_cutu_die_from_dwo): Update comment
2415         (skip_one_die): Add DW_FORM_addrx
2416         (read_attribute_value): Likewise
2417         (var_decode_location): Add DW_OP_addrx
2418         (dwarf2_const_value_attr): Add DW_FORM_addrx
2419         (dump_die_shallow): Likewise
2420         (dwarf2_fetch_constant_bytes): Likewise
2421         (decode_locdesc): Add DW_OP_addrx
2422         (skip_form_bytes): Add DW_FORM_addrx
2423
2424 2019-04-22  Ali Tamur  <tamur@google.com>
2425
2426         * MAINTAINERS (Write After Approval): Add self.
2427
2428 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2429
2430         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2431         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2432         (open_symbol_file_object): Likewise.
2433         (svr4_default_sos): Add info parameter.
2434         (svr4_read_so_list): Likewise.
2435         (svr4_current_sos_direct): Adjust functions calls to pass down
2436         info.
2437         (svr4_current_sos_1): Add info parameter.
2438         (svr4_current_sos): Call get_svr4_info, pass info down to
2439         svr4_current_sos_1.
2440         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2441         get_svr4_info.
2442         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2443         get_svr4_info.
2444         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2445         to get_svr4_info.
2446         (probes_table_remove_objfile_probes): Likewise.
2447         (register_solib_event_probe): Add info parameter.
2448         (solist_update_incremental): Pass info parameter down to
2449         svr4_read_so_list.
2450         (disable_probes_interface): Add info parameter.
2451         (svr4_handle_solib_event): Pass current_program_space to
2452         get_svr4_info.  Adjust disable_probes_interface cleanup.
2453         (svr4_create_probe_breakpoints): Add info parameter, pass it
2454         down to register_solib_event_probe.
2455         (svr4_create_solib_event_breakpoints): Add info parameter,
2456         pass it down to svr4_create_probe_breakpoints.
2457         (enable_break): Pass info down to
2458         svr4_create_solib_event_breakpoints.
2459         (svr4_solib_create_inferior_hook): Pass current_program_space to
2460         get_svr4_info.
2461         (svr4_clear_solib): Likewise.
2462
2463 2019-04-22  Pedro Alves  <palves@redhat.com>
2464
2465         * solib-svr4.c (svr4_free_objfile_observer): New.
2466         (probe_and_action::objfile): New field.
2467         (probes_table_htab_remove_objfile_probes)
2468         (probes_table_remove_objfile_probes): New functions.
2469         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2470         in the new probe_and_action.  Don't store the probe in 'lookup'.
2471         (svr4_create_probe_breakpoints): Pass objfile to
2472         register_solib_event_probe.
2473         (_initialize_svr4_solib): Register a free_objfile observer.
2474
2475 2019-04-19  Tom Tromey  <tom@tromey.com>
2476
2477         * common/queue.h: Remove.
2478
2479 2019-04-19  Tom Tromey  <tom@tromey.com>
2480
2481         * event-loop.c: Don't include "common/queue.h".
2482
2483 2019-04-19  Tom Tromey  <tom@tromey.com>
2484
2485         * remote.c (remote_target): Use delete.
2486         * remote-notif.h: Include <list>, not "common/queue.h".
2487         (notif_client_p): Remove typedef.
2488         (remote_notif_state): Add constructor, destructor, initializer.
2489         <notif_queue>: Now a std::list.
2490         (remote_notif_state_xfree): Don't declare.
2491         * remote-notif.c (remote_notif_process, handle_notification)
2492         (remote_notif_state_allocate): Update.
2493         (~remote_notif_state): Rename from remote_notif_state_xfree.
2494
2495 2019-04-19  Tom Tromey  <tom@tromey.com>
2496
2497         * symfile.c (reread_symbols): Update.
2498         * objfiles.c (objfile_register_static_link)
2499         (objfile_lookup_static_link): Update
2500         (~objfile) Don't delete static_links.
2501         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2502
2503 2019-04-19  Tom Tromey  <tom@tromey.com>
2504
2505         * type-stack.h (struct type_stack) <insert>: Constify string.
2506         * type-stack.c (type_stack::insert): Constify string.
2507         * gdbtypes.h (lookup_template_type): Update.
2508         (address_space_name_to_int): Update.
2509         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2510         const.
2511         (lookup_template_type): Make name const.
2512         * c-exp.y: Update rules.
2513         (lex_one_token, classify_name, classify_inner_name)
2514         (c_print_token): Update.
2515         * p-exp.y: Update rules.
2516         (yylex): Update.
2517         * f-exp.y: Update rules.
2518         (yylex): Update.
2519         * d-exp.y: Update rules.
2520         (lex_one_token, classify_name, classify_inner_name): Update.
2521         * parse.c (write_dollar_variable, copy_name): Return std::string.
2522         * parser-defs.h (copy_name): Change return type.
2523         * m2-exp.y: Update rules.
2524         (yylex): Update.
2525         * go-exp.y (lex_one_token): Update.
2526         Update rules.
2527         (classify_unsafe_function, classify_packaged_name)
2528         (classify_name, yylex): Update.
2529
2530 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2531
2532         * configure.ac: add --enable-source-highlight switch.
2533         * configure: Regenerate.
2534         * top.c (print_gdb_version): plumb --enable-source-highlight
2535         status to "show configuration".
2536
2537 2019-04-19  Tom Tromey  <tromey@adacore.com>
2538
2539         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2540         Check ADA_TYPE_P.
2541         (empty_record, ada_template_to_fixed_record_type_1)
2542         (template_to_static_fixed_type)
2543         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2544         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2545         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2546         macros.
2547
2548 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2549
2550         PR symtab/24423:
2551         * source.c (print_source_lines_base): Advance "iter" when a
2552         control character is seen.
2553
2554 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2555
2556         * inferior.h (struct infcall_suspend_state_deleter):
2557         Catch exception in destructor to avoid crash.
2558
2559 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2560
2561         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2562         close to the add_com "shell".
2563
2564 2019-04-18  Tom Tromey  <tromey@adacore.com>
2565
2566         * process-stratum-target.h (class process_stratum_target)
2567         <stratum>: Add "final".
2568
2569 2019-04-17  Tom Tromey  <tromey@adacore.com>
2570
2571         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2572         against nullptr before use.
2573
2574 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2575
2576         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2577
2578 2019-04-17  Jim Wilson  <jimw@sifive.com>
2579             Andrew Burgess  <andrew.burgess@embecosm.com>
2580
2581         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2582         code read might fail, assume 4-byte breakpoint in that case.
2583
2584 2019-04-15  Leszek Swirski  <leszeks@google.com>
2585
2586         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2587         rather than a hand-rolled POD check when checking for forced MEMORY
2588         classification.
2589
2590 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2591
2592         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2593         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2594         function.
2595         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2596         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2597         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2598         declaration.
2599
2600 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2601
2602         * aarch64-linux-nat.c
2603         (aarch64_linux_nat_target::thread_architecture): Add override.
2604         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2605         each VQ.
2606
2607 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2608
2609         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2610
2611 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2612
2613         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2614         target types of size 96-bits, add some additional comments, and
2615         check that the builtin type we found was the correct size.
2616
2617 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2618
2619         * utils.c (prompt_for_continue): Don't restore the styling at the
2620         end, as applied_style has the wrong value.  This fixes styling in
2621         long lists of file names that are interrupted by the "Continue?"
2622         prompt.
2623
2624 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2625
2626         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2627         * c-lang.c (c_language_defn): Likewise.
2628         (cplus_language_defn): Likewise.
2629         (asm_language_defn): Likewise.
2630         (minimal_language_defn): Likewise.
2631         * d-lang.c (d_language_defn): Likewise.
2632         * f-lang.c (f_language_defn): Likewise.
2633         * go-lang.c (go_language_defn): Likewise.
2634         * language.c (unknown_language_defn): Likewise.
2635         (auto_language_defn): Likewise.
2636         * language.h (struct language_defn): Remove la_magic field.
2637         (LANG_MAGIC): Delete.
2638         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2639         * objc-lang.c (objc_language_defn): Likewise.
2640         * opencl-lang.c (opencl_language_defn): Likewise.
2641         * p-lang.c (pascal_language_defn): Likewise.
2642         * rust-lang.c (rust_language_defn): Likewise.
2643
2644 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2645
2646         * riscv-tdep.c (riscv_type_align): New function.
2647         (riscv_type_alignment): Delete.
2648         (riscv_arg_location): Use 'type_align'.
2649         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2650
2651 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2652
2653         * gdbtypes.c (type_align): A struct with no non-static fields also
2654         has alignment of 1.
2655
2656 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2657
2658         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2659         component to 0.
2660         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2661         member.
2662         (riscv_struct_info::analyse): New implementation using new
2663         analyse_inner member function.
2664         (riscv_struct_info::field_offset): New member function.
2665         (riscv_struct_info::m_offsets): New member variable.
2666         (riscv_struct_info::analyse_inner): New private member function,
2667         takes the old implementation of riscv_struct_info::analyse but
2668         extended to track field offsets.
2669         (riscv_call_arg_struct): Update the struct folding special cases
2670         to handle cases where empty C++ structs, which are non-zero
2671         length, are found.
2672         (riscv_arg_location): Initialise the length of each location, a
2673         non-zero length now indicates the location is in use.
2674         (riscv_push_dummy_call): Allow for the first location having a
2675         non-zero offset when setting up arguments.
2676         (riscv_return_value): Likewise, but for return values.
2677
2678 2019-04-11  Tom Tromey  <tromey@adacore.com>
2679
2680         * utils.c (internal_vproblem): Make "msg" const.
2681
2682 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2683
2684         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2685         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2686         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2687         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2688
2689 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2690
2691         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2692         function.
2693         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2694         of amd64_collect_native_gregset.
2695         (amd64_linux_nat_target::store_registers): Likewise.
2696
2697 2019-04-10  Tom Tromey  <tom@tromey.com>
2698
2699         * symtab.c (lookup_global_symbol_from_objfile)
2700         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2701         * objfiles.h (class separate_debug_iterator): New.
2702         (class separate_debug_range): New.
2703         (struct objfile) <separate_debug_objfiles>: New method.
2704         (objfile_separate_debug_iterate): Don't declare.
2705         * objfiles.c (separate_debug_iterator::operator++): Rename from
2706         objfile_separate_debug_iterate.
2707         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2708         iterator.
2709         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2710         iterator.
2711
2712 2019-04-10  Tom Tromey  <tom@tromey.com>
2713
2714         * symfile.c (reread_symbols): Remove old comment.
2715         * objfiles.c (free_all_objfiles): Fix a typo.
2716
2717 2019-04-10  Tom Tromey  <tom@tromey.com>
2718
2719         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2720         * minsyms.c (lookup_minimal_symbol): Use foreach.
2721         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2722         (lookup_minimal_symbol_solib_trampoline): Likewise.
2723         * symfile.c (reread_symbols): Use foreach.
2724
2725 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2726             Tom Tromey  <tromey@adacore.com>
2727
2728         PR rust/24414:
2729         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2730         (rust_lex_int_test): Change "value" to be LONGEST.
2731         (rust_lex_tests): Add test for long integer literal.
2732
2733 2019-04-09  Tom Tromey  <tromey@adacore.com>
2734
2735         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2736         to bool.
2737         (extended_remote_target::attach): Update.
2738         (remote_target::remote_notice_new_inferior): Update.
2739         (remote_target::add_current_inferior_and_thread): Update.
2740         * inferior.c (exit_inferior_1): Use "false".
2741         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2742
2743 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2744
2745         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2746         the "start" command.
2747
2748 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2749
2750         * python/py-inferior.c (infpy_thread_from_thread_handle):
2751         Adjust comments to reflect renaming of thread_from_thread_handle
2752         to thread_from_handle.  Adjust keywords.  Fix type error message.
2753         (inferior_object_methods): Add thread_from_handle.  Retain
2754         thread_from_thread_handle, but mark it as deprecated.
2755
2756 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2757
2758         * gdbthread.h (find_thread_by_handle): Revise declaration.
2759         * thread.c (find_thread_by_handle): Likewise.  Adjust
2760         implementation too.
2761         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2762         support for buffer objects as handles.
2763
2764 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2765
2766         * python/py-infthread.c (thpy_thread_handle): New function.
2767         (thread_object_methods): Register thpy_thread_handle.
2768
2769 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2770
2771         * gdbthread.h (thread_to_thread_handle): Declare.
2772         * thread.c (gdbtypes.h): Include.
2773         (thread_to_thread_handle): New function.
2774
2775         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2776         (target_thread_info_to_thread_handle): Declare.
2777         * target.c (target_thread_info_to_thread_handle): New function.
2778         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2779         * target-delegates.c: Regenerate.
2780
2781         * linux-thread-db.c (class thread_db_target): Add method
2782         thread_info_to_thread_handle.
2783         (thread_db_target::thread_info_to_thread_handle): Define.
2784         * remote.c (class remote_target): Add new method
2785         thread_info_to_thread_handle.
2786         (remote_target::thread_info_to_thread_handle): Define.
2787
2788 2019-04-08  Pedro Alves  <palves@redhat.com>
2789
2790         * common/common-exceptions.c (throw_exception): Don't create
2791         named object to throw; throw directly.
2792         (throw_it): Likewise.  Don't initialize gdb_exception::message
2793         here, with new; pass FMT and AP to the ctor instead.
2794         * common/common-exceptions.h: Include <string>.
2795         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2796         const char *, va_list)): New ctor.  Use std::make_shared.
2797         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2798         errors)): Delete.
2799         (gdb_exception_error::gdb_exception_error(enum errors, const char
2800         *, va_list)): New.
2801         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2802         Add assertion.
2803         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2804         errors)): Delete.
2805         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2806         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2807         Add assertion.
2808
2809 2019-04-08  Tom Tromey  <tom@tromey.com>
2810
2811         * valops.c (value_rtti_indirect_type): Replace throw_exception
2812         with throw.
2813         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2814         with throw.
2815         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2816         throw.
2817         * target.c (target_translate_tls_address): Replace throw_exception
2818         with throw.
2819         * stack.c (frame_apply_command_count): Replace throw_exception
2820         with throw.
2821         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2822         throw.
2823         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2824         with throw.
2825         * rs6000-tdep.c (rs6000_frame_cache)
2826         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2827         * remote.c: Replace throw_exception with throw.
2828         * record-full.c (record_full_message, record_full_wait_1)
2829         (record_full_restore): Replace throw_exception with throw.
2830         * record-btrace.c:
2831         (get_thread_current_frame_id, record_btrace_start_replaying)
2832         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2833         (cmd_record_btrace_start): Replace throw_exception with throw.
2834         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2835         throw.
2836         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2837         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2838         * linespec.c:
2839         (find_linespec_symbols): Replace throw_exception with throw.
2840         * infrun.c (displaced_step_prepare, resume): Replace
2841         throw_exception with throw.
2842         * infcmd.c (post_create_inferior): Replace throw_exception with
2843         throw.
2844         * inf-loop.c (inferior_event_handler): Replace throw_exception
2845         with throw.
2846         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2847         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2848         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2849         (get_prev_frame_always, get_frame_pc_if_available)
2850         (get_frame_address_in_block_if_available, get_frame_language):
2851         Replace throw_exception with throw.
2852         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2853         throw_exception with throw.
2854         * eval.c (fetch_subexp_value, evaluate_var_value)
2855         (evaluate_funcall, evaluate_subexp_standard): Replace
2856         throw_exception with throw.
2857         * dwarf2loc.c (call_site_find_chain)
2858         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2859         Replace throw_exception with throw.
2860         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2861         with throw.
2862         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2863         throw.
2864         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2865         * completer.c (complete_line_internal): Replace throw_exception
2866         with throw.
2867         * compile/compile-object-run.c (compile_object_run): Replace
2868         throw_exception with throw.
2869         * cli/cli-script.c (process_next_line): Replace throw_exception
2870         with throw.
2871         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2872         (btrace_enable, btrace_maint_update_pt_packets): Replace
2873         throw_exception with throw.
2874         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2875         throw_exception with throw.
2876         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2877         throw_exception with throw.
2878         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2879         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2880         * aarch64-tdep.c (aarch64_make_prologue_cache)
2881         (aarch64_make_stub_cache): Replace throw_exception with throw.
2882
2883 2019-04-08  Tom Tromey  <tom@tromey.com>
2884
2885         * common/common-exceptions.c (throw_exception): Rename from
2886         throw_exception_cxx.  Remove old copy.  Make argument const.
2887         (throw_it): Create and throw exception objects directly.
2888         * common/common-exceptions.h (throw_exception): Make argument
2889         const.
2890         (struct gdb_exception_error): Add constructor.
2891         (struct gdb_exception_quit): Add constructor.
2892
2893 2019-04-08  Tom Tromey  <tom@tromey.com>
2894
2895         * common/common-exceptions.h (exception_rethrow): Don't declare.
2896         (TRY_SJLJ): Update comment.
2897         (TRY, CATCH, END_CATCH): Remove.
2898         * common/common-exceptions.c (exception_rethrow): Remove.
2899
2900 2019-04-08  Tom Tromey  <tom@tromey.com>
2901
2902         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2903         Remove.
2904         (gdb_exception_error): Rename from
2905         gdb_exception_RETURN_MASK_ERROR.
2906         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2907         (gdb_quit_bad_alloc): Update.
2908         * aarch64-tdep.c: Update.
2909         * ada-lang.c: Update.
2910         * ada-typeprint.c: Update.
2911         * ada-valprint.c: Update.
2912         * amd64-tdep.c: Update.
2913         * arch-utils.c: Update.
2914         * break-catch-throw.c: Update.
2915         * breakpoint.c: Update.
2916         * btrace.c: Update.
2917         * c-varobj.c: Update.
2918         * cli/cli-cmds.c: Update.
2919         * cli/cli-interp.c: Update.
2920         * cli/cli-script.c: Update.
2921         * common/common-exceptions.c: Update.
2922         * common/new-op.c: Update.
2923         * common/selftest.c: Update.
2924         * compile/compile-c-symbols.c: Update.
2925         * compile/compile-cplus-symbols.c: Update.
2926         * compile/compile-object-load.c: Update.
2927         * compile/compile-object-run.c: Update.
2928         * completer.c: Update.
2929         * corelow.c: Update.
2930         * cp-abi.c: Update.
2931         * cp-support.c: Update.
2932         * cp-valprint.c: Update.
2933         * darwin-nat.c: Update.
2934         * disasm-selftests.c: Update.
2935         * dtrace-probe.c: Update.
2936         * dwarf-index-cache.c: Update.
2937         * dwarf-index-write.c: Update.
2938         * dwarf2-frame-tailcall.c: Update.
2939         * dwarf2-frame.c: Update.
2940         * dwarf2loc.c: Update.
2941         * dwarf2read.c: Update.
2942         * eval.c: Update.
2943         * event-loop.c: Update.
2944         * event-top.c: Update.
2945         * exec.c: Update.
2946         * f-valprint.c: Update.
2947         * fbsd-tdep.c: Update.
2948         * frame-unwind.c: Update.
2949         * frame.c: Update.
2950         * gdbtypes.c: Update.
2951         * gnu-v3-abi.c: Update.
2952         * guile/guile-internal.h: Update.
2953         * guile/scm-block.c: Update.
2954         * guile/scm-breakpoint.c: Update.
2955         * guile/scm-cmd.c: Update.
2956         * guile/scm-disasm.c: Update.
2957         * guile/scm-frame.c: Update.
2958         * guile/scm-lazy-string.c: Update.
2959         * guile/scm-math.c: Update.
2960         * guile/scm-param.c: Update.
2961         * guile/scm-ports.c: Update.
2962         * guile/scm-pretty-print.c: Update.
2963         * guile/scm-symbol.c: Update.
2964         * guile/scm-symtab.c: Update.
2965         * guile/scm-type.c: Update.
2966         * guile/scm-value.c: Update.
2967         * i386-linux-tdep.c: Update.
2968         * i386-tdep.c: Update.
2969         * inf-loop.c: Update.
2970         * infcall.c: Update.
2971         * infcmd.c: Update.
2972         * infrun.c: Update.
2973         * jit.c: Update.
2974         * language.c: Update.
2975         * linespec.c: Update.
2976         * linux-fork.c: Update.
2977         * linux-nat.c: Update.
2978         * linux-tdep.c: Update.
2979         * linux-thread-db.c: Update.
2980         * main.c: Update.
2981         * mi/mi-cmd-break.c: Update.
2982         * mi/mi-cmd-stack.c: Update.
2983         * mi/mi-interp.c: Update.
2984         * mi/mi-main.c: Update.
2985         * objc-lang.c: Update.
2986         * p-valprint.c: Update.
2987         * parse.c: Update.
2988         * ppc-linux-tdep.c: Update.
2989         * printcmd.c: Update.
2990         * python/py-arch.c: Update.
2991         * python/py-breakpoint.c: Update.
2992         * python/py-cmd.c: Update.
2993         * python/py-finishbreakpoint.c: Update.
2994         * python/py-frame.c: Update.
2995         * python/py-framefilter.c: Update.
2996         * python/py-gdb-readline.c: Update.
2997         * python/py-inferior.c: Update.
2998         * python/py-infthread.c: Update.
2999         * python/py-lazy-string.c: Update.
3000         * python/py-linetable.c: Update.
3001         * python/py-objfile.c: Update.
3002         * python/py-param.c: Update.
3003         * python/py-prettyprint.c: Update.
3004         * python/py-progspace.c: Update.
3005         * python/py-record-btrace.c: Update.
3006         * python/py-record.c: Update.
3007         * python/py-symbol.c: Update.
3008         * python/py-type.c: Update.
3009         * python/py-unwind.c: Update.
3010         * python/py-utils.c: Update.
3011         * python/py-value.c: Update.
3012         * python/python.c: Update.
3013         * record-btrace.c: Update.
3014         * record-full.c: Update.
3015         * remote-fileio.c: Update.
3016         * remote.c: Update.
3017         * riscv-tdep.c: Update.
3018         * rs6000-aix-tdep.c: Update.
3019         * rs6000-tdep.c: Update.
3020         * rust-exp.y: Update.
3021         * rust-lang.c: Update.
3022         * s390-tdep.c: Update.
3023         * selftest-arch.c: Update.
3024         * solib-dsbt.c: Update.
3025         * solib-frv.c: Update.
3026         * solib-spu.c: Update.
3027         * solib-svr4.c: Update.
3028         * solib.c: Update.
3029         * sparc64-linux-tdep.c: Update.
3030         * stack.c: Update.
3031         * symfile-mem.c: Update.
3032         * symmisc.c: Update.
3033         * target.c: Update.
3034         * thread.c: Update.
3035         * top.c: Update.
3036         * tracefile-tfile.c: Update.
3037         * tui/tui.c: Update.
3038         * typeprint.c: Update.
3039         * unittests/cli-utils-selftests.c: Update.
3040         * unittests/parse-connection-spec-selftests.c: Update.
3041         * valops.c: Update.
3042         * valprint.c: Update.
3043         * value.c: Update.
3044         * varobj.c: Update.
3045         * windows-nat.c: Update.
3046         * x86-linux-nat.c: Update.
3047         * xml-support.c: Update.
3048
3049 2019-04-08  Tom Tromey  <tom@tromey.com>
3050
3051         * xml-support.c: Use C++ exception handling.
3052         * x86-linux-nat.c: Use C++ exception handling.
3053         * windows-nat.c: Use C++ exception handling.
3054         * varobj.c: Use C++ exception handling.
3055         * value.c: Use C++ exception handling.
3056         * valprint.c: Use C++ exception handling.
3057         * valops.c: Use C++ exception handling.
3058         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3059         handling.
3060         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3061         * typeprint.c: Use C++ exception handling.
3062         * tui/tui.c: Use C++ exception handling.
3063         * tracefile-tfile.c: Use C++ exception handling.
3064         * top.c: Use C++ exception handling.
3065         * thread.c: Use C++ exception handling.
3066         * target.c: Use C++ exception handling.
3067         * symmisc.c: Use C++ exception handling.
3068         * symfile-mem.c: Use C++ exception handling.
3069         * stack.c: Use C++ exception handling.
3070         * sparc64-linux-tdep.c: Use C++ exception handling.
3071         * solib.c: Use C++ exception handling.
3072         * solib-svr4.c: Use C++ exception handling.
3073         * solib-spu.c: Use C++ exception handling.
3074         * solib-frv.c: Use C++ exception handling.
3075         * solib-dsbt.c: Use C++ exception handling.
3076         * selftest-arch.c: Use C++ exception handling.
3077         * s390-tdep.c: Use C++ exception handling.
3078         * rust-lang.c: Use C++ exception handling.
3079         * rust-exp.y: Use C++ exception handling.
3080         * rs6000-tdep.c: Use C++ exception handling.
3081         * rs6000-aix-tdep.c: Use C++ exception handling.
3082         * riscv-tdep.c: Use C++ exception handling.
3083         * remote.c: Use C++ exception handling.
3084         * remote-fileio.c: Use C++ exception handling.
3085         * record-full.c: Use C++ exception handling.
3086         * record-btrace.c: Use C++ exception handling.
3087         * python/python.c: Use C++ exception handling.
3088         * python/py-value.c: Use C++ exception handling.
3089         * python/py-utils.c: Use C++ exception handling.
3090         * python/py-unwind.c: Use C++ exception handling.
3091         * python/py-type.c: Use C++ exception handling.
3092         * python/py-symbol.c: Use C++ exception handling.
3093         * python/py-record.c: Use C++ exception handling.
3094         * python/py-record-btrace.c: Use C++ exception handling.
3095         * python/py-progspace.c: Use C++ exception handling.
3096         * python/py-prettyprint.c: Use C++ exception handling.
3097         * python/py-param.c: Use C++ exception handling.
3098         * python/py-objfile.c: Use C++ exception handling.
3099         * python/py-linetable.c: Use C++ exception handling.
3100         * python/py-lazy-string.c: Use C++ exception handling.
3101         * python/py-infthread.c: Use C++ exception handling.
3102         * python/py-inferior.c: Use C++ exception handling.
3103         * python/py-gdb-readline.c: Use C++ exception handling.
3104         * python/py-framefilter.c: Use C++ exception handling.
3105         * python/py-frame.c: Use C++ exception handling.
3106         * python/py-finishbreakpoint.c: Use C++ exception handling.
3107         * python/py-cmd.c: Use C++ exception handling.
3108         * python/py-breakpoint.c: Use C++ exception handling.
3109         * python/py-arch.c: Use C++ exception handling.
3110         * printcmd.c: Use C++ exception handling.
3111         * ppc-linux-tdep.c: Use C++ exception handling.
3112         * parse.c: Use C++ exception handling.
3113         * p-valprint.c: Use C++ exception handling.
3114         * objc-lang.c: Use C++ exception handling.
3115         * mi/mi-main.c: Use C++ exception handling.
3116         * mi/mi-interp.c: Use C++ exception handling.
3117         * mi/mi-cmd-stack.c: Use C++ exception handling.
3118         * mi/mi-cmd-break.c: Use C++ exception handling.
3119         * main.c: Use C++ exception handling.
3120         * linux-thread-db.c: Use C++ exception handling.
3121         * linux-tdep.c: Use C++ exception handling.
3122         * linux-nat.c: Use C++ exception handling.
3123         * linux-fork.c: Use C++ exception handling.
3124         * linespec.c: Use C++ exception handling.
3125         * language.c: Use C++ exception handling.
3126         * jit.c: Use C++ exception handling.
3127         * infrun.c: Use C++ exception handling.
3128         * infcmd.c: Use C++ exception handling.
3129         * infcall.c: Use C++ exception handling.
3130         * inf-loop.c: Use C++ exception handling.
3131         * i386-tdep.c: Use C++ exception handling.
3132         * i386-linux-tdep.c: Use C++ exception handling.
3133         * guile/scm-value.c: Use C++ exception handling.
3134         * guile/scm-type.c: Use C++ exception handling.
3135         * guile/scm-symtab.c: Use C++ exception handling.
3136         * guile/scm-symbol.c: Use C++ exception handling.
3137         * guile/scm-pretty-print.c: Use C++ exception handling.
3138         * guile/scm-ports.c: Use C++ exception handling.
3139         * guile/scm-param.c: Use C++ exception handling.
3140         * guile/scm-math.c: Use C++ exception handling.
3141         * guile/scm-lazy-string.c: Use C++ exception handling.
3142         * guile/scm-frame.c: Use C++ exception handling.
3143         * guile/scm-disasm.c: Use C++ exception handling.
3144         * guile/scm-cmd.c: Use C++ exception handling.
3145         * guile/scm-breakpoint.c: Use C++ exception handling.
3146         * guile/scm-block.c: Use C++ exception handling.
3147         * guile/guile-internal.h: Use C++ exception handling.
3148         * gnu-v3-abi.c: Use C++ exception handling.
3149         * gdbtypes.c: Use C++ exception handling.
3150         * frame.c: Use C++ exception handling.
3151         * frame-unwind.c: Use C++ exception handling.
3152         * fbsd-tdep.c: Use C++ exception handling.
3153         * f-valprint.c: Use C++ exception handling.
3154         * exec.c: Use C++ exception handling.
3155         * event-top.c: Use C++ exception handling.
3156         * event-loop.c: Use C++ exception handling.
3157         * eval.c: Use C++ exception handling.
3158         * dwarf2read.c: Use C++ exception handling.
3159         * dwarf2loc.c: Use C++ exception handling.
3160         * dwarf2-frame.c: Use C++ exception handling.
3161         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3162         * dwarf-index-write.c: Use C++ exception handling.
3163         * dwarf-index-cache.c: Use C++ exception handling.
3164         * dtrace-probe.c: Use C++ exception handling.
3165         * disasm-selftests.c: Use C++ exception handling.
3166         * darwin-nat.c: Use C++ exception handling.
3167         * cp-valprint.c: Use C++ exception handling.
3168         * cp-support.c: Use C++ exception handling.
3169         * cp-abi.c: Use C++ exception handling.
3170         * corelow.c: Use C++ exception handling.
3171         * completer.c: Use C++ exception handling.
3172         * compile/compile-object-run.c: Use C++ exception handling.
3173         * compile/compile-object-load.c: Use C++ exception handling.
3174         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3175         * compile/compile-c-symbols.c: Use C++ exception handling.
3176         * common/selftest.c: Use C++ exception handling.
3177         * common/new-op.c: Use C++ exception handling.
3178         * cli/cli-script.c: Use C++ exception handling.
3179         * cli/cli-interp.c: Use C++ exception handling.
3180         * cli/cli-cmds.c: Use C++ exception handling.
3181         * c-varobj.c: Use C++ exception handling.
3182         * btrace.c: Use C++ exception handling.
3183         * breakpoint.c: Use C++ exception handling.
3184         * break-catch-throw.c: Use C++ exception handling.
3185         * arch-utils.c: Use C++ exception handling.
3186         * amd64-tdep.c: Use C++ exception handling.
3187         * ada-valprint.c: Use C++ exception handling.
3188         * ada-typeprint.c: Use C++ exception handling.
3189         * ada-lang.c: Use C++ exception handling.
3190         * aarch64-tdep.c: Use C++ exception handling.
3191
3192 2019-04-08  Tom Tromey  <tom@tromey.com>
3193
3194         * xml-support.c (gdb_xml_parser::parse): Update.
3195         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3196         * value.c (show_convenience): Update.
3197         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3198         (test_parse_flags_qcs): Update.
3199         * thread.c (thr_try_catch_cmd): Update.
3200         * target.c (target_translate_tls_address): Update.
3201         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3202         (info_frame_command_core, frame_apply_command_count): Update.
3203         * rust-exp.y (rust_lex_exception_test): Update.
3204         * riscv-tdep.c (riscv_print_one_register_info): Update.
3205         * remote.c (remote_target::enable_btrace): Update.
3206         * record-btrace.c (record_btrace_enable_warn): Update.
3207         * python/py-utils.c (gdbpy_convert_exception): Update.
3208         * printcmd.c (do_one_display, print_variable_and_value): Update.
3209         * mi/mi-main.c (mi_print_exception): Update.
3210         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3211         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3212         * linux-nat.c (linux_nat_target::attach): Update.
3213         * linux-fork.c (class scoped_switch_fork_info): Update.
3214         * infrun.c (displaced_step_prepare): Update.
3215         * infcall.c (call_function_by_hand_dummy): Update.
3216         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3217         * gnu-v3-abi.c (print_one_vtable): Update.
3218         * frame.c (get_prev_frame_always): Update.
3219         * f-valprint.c (info_common_command_for_block): Update.
3220         * exec.c (try_open_exec_file): Update.
3221         * exceptions.c (print_exception, exception_print)
3222         (exception_fprintf, exception_print_same): Update.
3223         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3224         * dwarf-index-cache.c (index_cache::store)
3225         (index_cache::lookup_gdb_index): Update.
3226         * darwin-nat.c (maybe_cache_shell): Update.
3227         * cp-valprint.c (cp_print_value_fields): Update.
3228         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3229         (gcc_cplus_symbol_address): Update.
3230         * compile/compile-c-symbols.c (gcc_convert_symbol)
3231         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3232         * common/selftest.c: Update.
3233         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3234         a std::string.
3235         (exception_try_scope_entry, exception_try_scope_exit): Don't
3236         declare.
3237         (struct exception_try_scope): Remove.
3238         (TRY): Don't use exception_try_scope.
3239         (struct gdb_exception): Add constructor, operator=.
3240         <what>: New method.
3241         (struct gdb_exception_RETURN_MASK_ALL)
3242         (struct gdb_exception_RETURN_MASK_ERROR)
3243         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3244         (struct gdb_quit_bad_alloc): Update.
3245         * common/common-exceptions.c (exception_none): Change
3246         initializer.
3247         (struct catcher) <state, exception>: Initialize inline.
3248         <prev>: Remove member.
3249         (current_catcher): Remove.
3250         (catchers): New global.
3251         (exceptions_state_mc_init): Simplify.
3252         (catcher_pop): Remove.
3253         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3254         (try_scope_depth, exception_try_scope_entry)
3255         (exception_try_scope_exit): Remove.
3256         (throw_exception_sjlj): Update.
3257         (exception_messages, exception_messages_size): Remove.
3258         (throw_it): Simplify.
3259         (gdb_exception_sliced_copy): Remove.
3260         (throw_exception_cxx): Update.
3261         * cli/cli-script.c (script_from_file): Update.
3262         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3263         Update.
3264         * ada-valprint.c (ada_val_print): Update.
3265         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3266         (create_excep_cond_exprs): Update.
3267
3268 2019-04-08  Tom Tromey  <tom@tromey.com>
3269
3270         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3271         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3272         (TRY, CATCH, END_CATCH): Remove some definitions.
3273         * common/common-exceptions.c: Don't use GDB_XCPT.
3274         (catcher_list_size): Remove.
3275         (throw_exception, throw_it): Simplify.
3276
3277 2019-04-05  Tom Tromey  <tom@tromey.com>
3278
3279         Revert the header-sorting patch.
3280         * ft32-tdep.c: Revert.
3281         * frv-tdep.c: Revert.
3282         * frv-linux-tdep.c: Revert.
3283         * frame.c: Revert.
3284         * frame-unwind.c: Revert.
3285         * frame-base.c: Revert.
3286         * fork-child.c: Revert.
3287         * findvar.c: Revert.
3288         * findcmd.c: Revert.
3289         * filesystem.c: Revert.
3290         * filename-seen-cache.h: Revert.
3291         * filename-seen-cache.c: Revert.
3292         * fbsd-tdep.c: Revert.
3293         * fbsd-nat.h: Revert.
3294         * fbsd-nat.c: Revert.
3295         * f-valprint.c: Revert.
3296         * f-typeprint.c: Revert.
3297         * f-lang.c: Revert.
3298         * extension.h: Revert.
3299         * extension.c: Revert.
3300         * extension-priv.h: Revert.
3301         * expprint.c: Revert.
3302         * exec.h: Revert.
3303         * exec.c: Revert.
3304         * exceptions.c: Revert.
3305         * event-top.c: Revert.
3306         * event-loop.c: Revert.
3307         * eval.c: Revert.
3308         * elfread.c: Revert.
3309         * dwarf2read.h: Revert.
3310         * dwarf2read.c: Revert.
3311         * dwarf2loc.c: Revert.
3312         * dwarf2expr.h: Revert.
3313         * dwarf2expr.c: Revert.
3314         * dwarf2-frame.c: Revert.
3315         * dwarf2-frame-tailcall.c: Revert.
3316         * dwarf-index-write.h: Revert.
3317         * dwarf-index-write.c: Revert.
3318         * dwarf-index-common.c: Revert.
3319         * dwarf-index-cache.h: Revert.
3320         * dwarf-index-cache.c: Revert.
3321         * dummy-frame.c: Revert.
3322         * dtrace-probe.c: Revert.
3323         * disasm.h: Revert.
3324         * disasm.c: Revert.
3325         * disasm-selftests.c: Revert.
3326         * dictionary.c: Revert.
3327         * dicos-tdep.c: Revert.
3328         * demangle.c: Revert.
3329         * dcache.h: Revert.
3330         * dcache.c: Revert.
3331         * darwin-nat.h: Revert.
3332         * darwin-nat.c: Revert.
3333         * darwin-nat-info.c: Revert.
3334         * d-valprint.c: Revert.
3335         * d-namespace.c: Revert.
3336         * d-lang.c: Revert.
3337         * ctf.c: Revert.
3338         * csky-tdep.c: Revert.
3339         * csky-linux-tdep.c: Revert.
3340         * cris-tdep.c: Revert.
3341         * cris-linux-tdep.c: Revert.
3342         * cp-valprint.c: Revert.
3343         * cp-support.c: Revert.
3344         * cp-namespace.c: Revert.
3345         * cp-abi.c: Revert.
3346         * corelow.c: Revert.
3347         * corefile.c: Revert.
3348         * continuations.c: Revert.
3349         * completer.h: Revert.
3350         * completer.c: Revert.
3351         * complaints.c: Revert.
3352         * coffread.c: Revert.
3353         * coff-pe-read.c: Revert.
3354         * cli-out.h: Revert.
3355         * cli-out.c: Revert.
3356         * charset.c: Revert.
3357         * c-varobj.c: Revert.
3358         * c-valprint.c: Revert.
3359         * c-typeprint.c: Revert.
3360         * c-lang.c: Revert.
3361         * buildsym.c: Revert.
3362         * buildsym-legacy.c: Revert.
3363         * build-id.h: Revert.
3364         * build-id.c: Revert.
3365         * btrace.c: Revert.
3366         * bsd-uthread.c: Revert.
3367         * breakpoint.h: Revert.
3368         * breakpoint.c: Revert.
3369         * break-catch-throw.c: Revert.
3370         * break-catch-syscall.c: Revert.
3371         * break-catch-sig.c: Revert.
3372         * blockframe.c: Revert.
3373         * block.c: Revert.
3374         * bfin-tdep.c: Revert.
3375         * bfin-linux-tdep.c: Revert.
3376         * bfd-target.c: Revert.
3377         * bcache.c: Revert.
3378         * ax-general.c: Revert.
3379         * ax-gdb.h: Revert.
3380         * ax-gdb.c: Revert.
3381         * avr-tdep.c: Revert.
3382         * auxv.c: Revert.
3383         * auto-load.c: Revert.
3384         * arm-wince-tdep.c: Revert.
3385         * arm-tdep.c: Revert.
3386         * arm-symbian-tdep.c: Revert.
3387         * arm-pikeos-tdep.c: Revert.
3388         * arm-obsd-tdep.c: Revert.
3389         * arm-nbsd-tdep.c: Revert.
3390         * arm-nbsd-nat.c: Revert.
3391         * arm-linux-tdep.c: Revert.
3392         * arm-linux-nat.c: Revert.
3393         * arm-fbsd-tdep.c: Revert.
3394         * arm-fbsd-nat.c: Revert.
3395         * arm-bsd-tdep.c: Revert.
3396         * arch-utils.c: Revert.
3397         * arc-tdep.c: Revert.
3398         * arc-newlib-tdep.c: Revert.
3399         * annotate.h: Revert.
3400         * annotate.c: Revert.
3401         * amd64-windows-tdep.c: Revert.
3402         * amd64-windows-nat.c: Revert.
3403         * amd64-tdep.c: Revert.
3404         * amd64-sol2-tdep.c: Revert.
3405         * amd64-obsd-tdep.c: Revert.
3406         * amd64-obsd-nat.c: Revert.
3407         * amd64-nbsd-tdep.c: Revert.
3408         * amd64-nbsd-nat.c: Revert.
3409         * amd64-nat.c: Revert.
3410         * amd64-linux-tdep.c: Revert.
3411         * amd64-linux-nat.c: Revert.
3412         * amd64-fbsd-tdep.c: Revert.
3413         * amd64-fbsd-nat.c: Revert.
3414         * amd64-dicos-tdep.c: Revert.
3415         * amd64-darwin-tdep.c: Revert.
3416         * amd64-bsd-nat.c: Revert.
3417         * alpha-tdep.c: Revert.
3418         * alpha-obsd-tdep.c: Revert.
3419         * alpha-nbsd-tdep.c: Revert.
3420         * alpha-mdebug-tdep.c: Revert.
3421         * alpha-linux-tdep.c: Revert.
3422         * alpha-linux-nat.c: Revert.
3423         * alpha-bsd-tdep.c: Revert.
3424         * alpha-bsd-nat.c: Revert.
3425         * aix-thread.c: Revert.
3426         * agent.c: Revert.
3427         * addrmap.c: Revert.
3428         * ada-varobj.c: Revert.
3429         * ada-valprint.c: Revert.
3430         * ada-typeprint.c: Revert.
3431         * ada-tasks.c: Revert.
3432         * ada-lang.c: Revert.
3433         * aarch64-tdep.c: Revert.
3434         * aarch64-ravenscar-thread.c: Revert.
3435         * aarch64-newlib-tdep.c: Revert.
3436         * aarch64-linux-tdep.c: Revert.
3437         * aarch64-linux-nat.c: Revert.
3438         * aarch64-fbsd-tdep.c: Revert.
3439         * aarch64-fbsd-nat.c: Revert.
3440         * aarch32-linux-nat.c: Revert.
3441
3442 2019-04-05  Tom Tromey  <tom@tromey.com>
3443
3444         * ft32-tdep.c: Sort headers.
3445         * frv-tdep.c: Sort headers.
3446         * frv-linux-tdep.c: Sort headers.
3447         * frame.c: Sort headers.
3448         * frame-unwind.c: Sort headers.
3449         * frame-base.c: Sort headers.
3450         * fork-child.c: Sort headers.
3451         * findvar.c: Sort headers.
3452         * findcmd.c: Sort headers.
3453         * filesystem.c: Sort headers.
3454         * filename-seen-cache.h: Sort headers.
3455         * filename-seen-cache.c: Sort headers.
3456         * fbsd-tdep.c: Sort headers.
3457         * fbsd-nat.h: Sort headers.
3458         * fbsd-nat.c: Sort headers.
3459         * f-valprint.c: Sort headers.
3460         * f-typeprint.c: Sort headers.
3461         * f-lang.c: Sort headers.
3462         * extension.h: Sort headers.
3463         * extension.c: Sort headers.
3464         * extension-priv.h: Sort headers.
3465         * expprint.c: Sort headers.
3466         * exec.h: Sort headers.
3467         * exec.c: Sort headers.
3468         * exceptions.c: Sort headers.
3469         * event-top.c: Sort headers.
3470         * event-loop.c: Sort headers.
3471         * eval.c: Sort headers.
3472         * elfread.c: Sort headers.
3473         * dwarf2read.h: Sort headers.
3474         * dwarf2read.c: Sort headers.
3475         * dwarf2loc.c: Sort headers.
3476         * dwarf2expr.h: Sort headers.
3477         * dwarf2expr.c: Sort headers.
3478         * dwarf2-frame.c: Sort headers.
3479         * dwarf2-frame-tailcall.c: Sort headers.
3480         * dwarf-index-write.h: Sort headers.
3481         * dwarf-index-write.c: Sort headers.
3482         * dwarf-index-common.c: Sort headers.
3483         * dwarf-index-cache.h: Sort headers.
3484         * dwarf-index-cache.c: Sort headers.
3485         * dummy-frame.c: Sort headers.
3486         * dtrace-probe.c: Sort headers.
3487         * disasm.h: Sort headers.
3488         * disasm.c: Sort headers.
3489         * disasm-selftests.c: Sort headers.
3490         * dictionary.c: Sort headers.
3491         * dicos-tdep.c: Sort headers.
3492         * demangle.c: Sort headers.
3493         * dcache.h: Sort headers.
3494         * dcache.c: Sort headers.
3495         * darwin-nat.h: Sort headers.
3496         * darwin-nat.c: Sort headers.
3497         * darwin-nat-info.c: Sort headers.
3498         * d-valprint.c: Sort headers.
3499         * d-namespace.c: Sort headers.
3500         * d-lang.c: Sort headers.
3501         * ctf.c: Sort headers.
3502         * csky-tdep.c: Sort headers.
3503         * csky-linux-tdep.c: Sort headers.
3504         * cris-tdep.c: Sort headers.
3505         * cris-linux-tdep.c: Sort headers.
3506         * cp-valprint.c: Sort headers.
3507         * cp-support.c: Sort headers.
3508         * cp-namespace.c: Sort headers.
3509         * cp-abi.c: Sort headers.
3510         * corelow.c: Sort headers.
3511         * corefile.c: Sort headers.
3512         * continuations.c: Sort headers.
3513         * completer.h: Sort headers.
3514         * completer.c: Sort headers.
3515         * complaints.c: Sort headers.
3516         * coffread.c: Sort headers.
3517         * coff-pe-read.c: Sort headers.
3518         * cli-out.h: Sort headers.
3519         * cli-out.c: Sort headers.
3520         * charset.c: Sort headers.
3521         * c-varobj.c: Sort headers.
3522         * c-valprint.c: Sort headers.
3523         * c-typeprint.c: Sort headers.
3524         * c-lang.c: Sort headers.
3525         * buildsym.c: Sort headers.
3526         * buildsym-legacy.c: Sort headers.
3527         * build-id.h: Sort headers.
3528         * build-id.c: Sort headers.
3529         * btrace.c: Sort headers.
3530         * bsd-uthread.c: Sort headers.
3531         * breakpoint.h: Sort headers.
3532         * breakpoint.c: Sort headers.
3533         * break-catch-throw.c: Sort headers.
3534         * break-catch-syscall.c: Sort headers.
3535         * break-catch-sig.c: Sort headers.
3536         * blockframe.c: Sort headers.
3537         * block.c: Sort headers.
3538         * bfin-tdep.c: Sort headers.
3539         * bfin-linux-tdep.c: Sort headers.
3540         * bfd-target.c: Sort headers.
3541         * bcache.c: Sort headers.
3542         * ax-general.c: Sort headers.
3543         * ax-gdb.h: Sort headers.
3544         * ax-gdb.c: Sort headers.
3545         * avr-tdep.c: Sort headers.
3546         * auxv.c: Sort headers.
3547         * auto-load.c: Sort headers.
3548         * arm-wince-tdep.c: Sort headers.
3549         * arm-tdep.c: Sort headers.
3550         * arm-symbian-tdep.c: Sort headers.
3551         * arm-pikeos-tdep.c: Sort headers.
3552         * arm-obsd-tdep.c: Sort headers.
3553         * arm-nbsd-tdep.c: Sort headers.
3554         * arm-nbsd-nat.c: Sort headers.
3555         * arm-linux-tdep.c: Sort headers.
3556         * arm-linux-nat.c: Sort headers.
3557         * arm-fbsd-tdep.c: Sort headers.
3558         * arm-fbsd-nat.c: Sort headers.
3559         * arm-bsd-tdep.c: Sort headers.
3560         * arch-utils.c: Sort headers.
3561         * arc-tdep.c: Sort headers.
3562         * arc-newlib-tdep.c: Sort headers.
3563         * annotate.h: Sort headers.
3564         * annotate.c: Sort headers.
3565         * amd64-windows-tdep.c: Sort headers.
3566         * amd64-windows-nat.c: Sort headers.
3567         * amd64-tdep.c: Sort headers.
3568         * amd64-sol2-tdep.c: Sort headers.
3569         * amd64-obsd-tdep.c: Sort headers.
3570         * amd64-obsd-nat.c: Sort headers.
3571         * amd64-nbsd-tdep.c: Sort headers.
3572         * amd64-nbsd-nat.c: Sort headers.
3573         * amd64-nat.c: Sort headers.
3574         * amd64-linux-tdep.c: Sort headers.
3575         * amd64-linux-nat.c: Sort headers.
3576         * amd64-fbsd-tdep.c: Sort headers.
3577         * amd64-fbsd-nat.c: Sort headers.
3578         * amd64-dicos-tdep.c: Sort headers.
3579         * amd64-darwin-tdep.c: Sort headers.
3580         * amd64-bsd-nat.c: Sort headers.
3581         * alpha-tdep.c: Sort headers.
3582         * alpha-obsd-tdep.c: Sort headers.
3583         * alpha-nbsd-tdep.c: Sort headers.
3584         * alpha-mdebug-tdep.c: Sort headers.
3585         * alpha-linux-tdep.c: Sort headers.
3586         * alpha-linux-nat.c: Sort headers.
3587         * alpha-bsd-tdep.c: Sort headers.
3588         * alpha-bsd-nat.c: Sort headers.
3589         * aix-thread.c: Sort headers.
3590         * agent.c: Sort headers.
3591         * addrmap.c: Sort headers.
3592         * ada-varobj.c: Sort headers.
3593         * ada-valprint.c: Sort headers.
3594         * ada-typeprint.c: Sort headers.
3595         * ada-tasks.c: Sort headers.
3596         * ada-lang.c: Sort headers.
3597         * aarch64-tdep.c: Sort headers.
3598         * aarch64-ravenscar-thread.c: Sort headers.
3599         * aarch64-newlib-tdep.c: Sort headers.
3600         * aarch64-linux-tdep.c: Sort headers.
3601         * aarch64-linux-nat.c: Sort headers.
3602         * aarch64-fbsd-tdep.c: Sort headers.
3603         * aarch64-fbsd-nat.c: Sort headers.
3604         * aarch32-linux-nat.c: Sort headers.
3605
3606 2019-04-04  Tom Tromey  <tom@tromey.com>
3607
3608         * varobj.c (varobj_create): Update.
3609         * rust-exp.y (struct rust_parser) <update_innermost_block,
3610         lookup_symbol>: New methods.
3611         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3612         Rename.
3613         (rust_parser::rust_lookup_type)
3614         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3615         * printcmd.c (display_command, do_one_display): Update.
3616         * parser-defs.h (struct parser_state) <parser_state>: Add
3617         "tracker" parameter.
3618         (block_tracker): New member.
3619         (class innermost_block_tracker) <innermost_block_tracker>: Add
3620         "types" parameter.
3621         <reset>: Remove method.
3622         (innermost_block): Don't declare.
3623         (null_post_parser): Update.
3624         * parse.c (innermost_block): Remove global.
3625         (write_dollar_variable): Update.
3626         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3627         Remove "tracker_types" parameter.
3628         (parse_expression): Add "tracker" parameter.
3629         (parse_expression_for_completion): Update.
3630         (null_post_parser): Add "tracker" parameter.
3631         * p-exp.y: Update rules.
3632         * m2-exp.y: Update rules.
3633         * language.h (struct language_defn) <la_post_parser>: Add
3634         "tracker" parameter.
3635         * go-exp.y: Update rules.
3636         * f-exp.y: Update rules.
3637         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3638         parameter.
3639         * d-exp.y: Update rules.
3640         * c-exp.y: Update rules.
3641         * breakpoint.c (set_breakpoint_condition): Create an
3642         innermost_block_tracker.
3643         (watch_command_1): Likewise.
3644         * ada-lang.c (resolve): Add "tracker" parameter.
3645         (resolve_subexp): Likewise.
3646         * ada-exp.y (write_var_from_sym): Update.
3647
3648 2019-04-04  Tom Tromey  <tom@tromey.com>
3649
3650         * type-stack.h: New file.
3651         * type-stack.c: New file.
3652         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3653         type-stack.h.
3654         (insert_into_type_stack, insert_type, push_type, push_type_int)
3655         (insert_type_address_space, pop_type, pop_type_int)
3656         (pop_typelist, pop_type_stack, append_type_stack)
3657         (push_type_stack, get_type_stack, push_typelist)
3658         (follow_type_instance_flags, follow_types): Don't declare.
3659         * parse.c (type_stack): Remove global.
3660         (parse_exp_in_context): Update.
3661         (insert_into_type_stack, insert_type, push_type, push_type_int)
3662         (insert_type_address_space, pop_type, pop_type_int)
3663         (pop_typelist, pop_type_stack, append_type_stack)
3664         (push_type_stack, get_type_stack, push_typelist)
3665         (follow_type_instance_flags, follow_types): Remove (moved to
3666         type-stack.c).
3667         * f-exp.y (type_stack): New global.
3668         Update rules.
3669         (push_kind_type, f_parse): Update.
3670         * d-exp.y (type_stack): New global.
3671         Update rules.
3672         (d_parse): Update.
3673         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3674         Update rules.
3675         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3676         (HFILES_NO_SRCDIR): Add type-stack.h.
3677
3678 2019-04-04  Tom Tromey  <tom@tromey.com>
3679
3680         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3681         (rust_parser::convert_ast_to_expression, rust_parse)
3682         (rust_lex_test_completion, rust_lex_tests): Update.
3683         * parser-defs.h (struct expr_completion_state): New.
3684         (struct parser_state) <parser_state>: Add completion parameter.
3685         <mark_struct_expression, mark_completion_tag>: New methods.
3686         <parse_completion, m_completion_state>: New members.
3687         (prefixify_expression, null_post_parser): Update.
3688         (mark_struct_expression, mark_completion_tag): Don't declare.
3689         * parse.c (parse_completion, expout_last_struct)
3690         (expout_tag_completion_type, expout_completion_name): Remove
3691         globals.
3692         (parser_state::mark_struct_expression)
3693         (parser_state::mark_completion_tag): Now methods.
3694         (prefixify_expression): Add last_struct parameter.
3695         (prefixify_subexp): Likewise.
3696         (parse_exp_1): Update.
3697         (parse_exp_in_context): Add cstate parameter.  Update.
3698         (parse_expression_for_completion): Create an
3699         expr_completion_state.
3700         (null_post_parser): Add "completion" parameter.
3701         * p-exp.y: Update rules.
3702         (yylex): Update.
3703         * language.h (struct language_defn) <la_post_parser>: Add
3704         "completing" parameter.
3705         * go-exp.y: Update rules.
3706         (lex_one_token): Update.
3707         * expression.h (parse_completion): Don't declare.
3708         * d-exp.y: Update rules.
3709         (lex_one_token): Update rules.
3710         * c-exp.y: Update rules.
3711         (lex_one_token): Update.
3712         * ada-lang.c (resolve): Add "parse_completion" parameter.
3713         (resolve_subexp): Likewise.
3714         (ada_resolve_function): Likewise.
3715
3716 2019-04-04  Tom Tromey  <tom@tromey.com>
3717
3718         * parser-defs.h (struct parser_state) <start_arglist,
3719         end_arglist>: New methods.
3720         <arglist_len, m_funcall_chain>: New members.
3721         (arglist_len, start_arglist, end_arglist): Don't declare.
3722         * parse.c (arglist_len, funcall_chain): Remove global.
3723         (start_arglist, end_arglist): Remove functions.
3724         (parse_exp_in_context): Update.
3725         * p-exp.y: Update rules.
3726         * m2-exp.y: Update rules.
3727         * go-exp.y: Update rules.
3728         * f-exp.y: Update rules.
3729         * d-exp.y: Update rules.
3730         * c-exp.y: Update rules.
3731
3732 2019-04-04  Tom Tromey  <tom@tromey.com>
3733
3734         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3735         lex_operator, push_back>: New methods.
3736         Update all rules.
3737         (rust_parser::lex_hex, lex_escape): Rename and update.
3738         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3739         (rust_parser::lex_operator): Rename and update.
3740         (rust_parser::lex_number, rustyylex, rustyyerror)
3741         (rust_lex_test_init, rust_lex_test_sequence)
3742         (rust_lex_test_push_back, rust_lex_tests): Update.
3743         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3744         parameter.
3745         <lexptr, prev_lexptr>: New members.
3746         (lexptr, prev_lexptr): Don't declare.
3747         * parse.c (lexptr, prev_lexptr): Remove globals.
3748         (parse_exp_in_context): Update.
3749         * p-exp.y (yylex, yyerror): Update.
3750         * m2-exp.y (parse_number, yylex, yyerror): Update.
3751         * go-exp.y (lex_one_token, yyerror): Update.
3752         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3753         * d-exp.y (lex_one_token, yyerror): Update.
3754         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3755         (lex_one_token, yyerror): Update.
3756         * ada-lex.l (YY_INPUT): Update.
3757         (rewind_to_char): Update.
3758         * ada-exp.y (yyerror): Update.
3759
3760 2019-04-04  Tom Tromey  <tom@tromey.com>
3761
3762         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3763         * parser-defs.h (struct parser_state) <parser_state>: Add new
3764         parameter.
3765         <comma_terminates>: New member.
3766         (comma_terminates): Don't declare global.
3767         * parse.c (comma_terminates): Remove global.
3768         (parse_exp_in_context): Update.
3769         * p-exp.y (yylex): Update.
3770         * m2-exp.y (yylex): Update.
3771         * go-exp.y (lex_one_token): Update.
3772         * f-exp.y (yylex): Update.
3773         * d-exp.y (lex_one_token): Update.
3774         * c-exp.y (lex_one_token): Update.
3775         * ada-lex.l: Update.
3776
3777 2019-04-04  Tom Tromey  <tom@tromey.com>
3778
3779         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3780         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3781         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3782         * parser-defs.h (paren_depth): Don't declare.
3783         * parse.c (paren_depth): Remove global.
3784         (parse_exp_in_context): Update.
3785         * p-exp.y (paren_depth): New global.
3786         (pascal_parse): Initialize it.
3787         * m2-exp.y (paren_depth): New global.
3788         (m2_parse): Initialize it.
3789         * go-exp.y (paren_depth): New global.
3790         (go_parse): Initialize it.
3791         * f-exp.y (paren_depth): New global.
3792         (f_parse): Initialize it.
3793         * d-exp.y (paren_depth): New global.
3794         (d_parse): Initialize it.
3795         * c-exp.y (paren_depth): New global.
3796         (c_parse): Initialize it.
3797         * ada-lex.l (paren_depth): New global.
3798         (lexer_init): Initialize it.
3799
3800 2019-04-04  Tom Tromey  <tom@tromey.com>
3801
3802         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3803         (rust_parser::convert_ast_to_type)
3804         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3805         * parser-defs.h (struct parser_state) <parser_state>: Add
3806         parameters.  Initialize new members.
3807         <expression_context_block, expression_context_pc>: New members.
3808         * parse.c (expression_context_block, expression_context_pc):
3809         Remove globals.
3810         (parse_exp_in_context): Update.
3811         * p-exp.y: Update all rules.
3812         (yylex): Update.
3813         * m2-exp.y: Update all rules.
3814         (yylex): Update.
3815         * go-exp.y (yylex): Update.
3816         * f-exp.y (yylex): Update.
3817         * d-exp.y: Update all rules.
3818         (yylex): Update.
3819         * c-exp.y: Update all rules.
3820         (lex_one_token, classify_name, yylex, c_parse): Update.
3821         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3822
3823 2019-04-04  Tom Tromey  <tom@tromey.com>
3824
3825         * gdbarch.h, gdbarch.c: Rebuild.
3826         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3827         * stap-probe.h:
3828         (struct stap_parse_info): Replace "parser_state" with
3829         "expr_builder".
3830         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3831         (parser_state): New class.
3832         * parse.c (expr_builder): Rename.
3833         (expr_builder::release): Rename.
3834         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3835         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3836         (write_exp_elt_longcst, write_exp_elt_floatcst)
3837         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3838         (write_exp_string_vector, write_exp_bitstring)
3839         (write_exp_msymbol, mark_struct_expression)
3840         (write_dollar_variable)
3841         (insert_type_address_space, increase_expout_size): Replace
3842         "parser_state" with "expr_builder".
3843         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3844         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3845         "parser_state" with "expr_builder".
3846
3847 2019-04-04  Tom Tromey  <tom@tromey.com>
3848
3849         * rust-exp.y: Replace "parse_language" with method call.
3850         * p-exp.y:
3851         (yylex): Replace "parse_language" with method call.
3852         * m2-exp.y:
3853         (yylex): Replace "parse_language" with method call.
3854         * go-exp.y (classify_name): Replace "parse_language" with method
3855         call.
3856         * f-exp.y (yylex): Replace "parse_language" with method call.
3857         * d-exp.y (lex_one_token): Replace "parse_language" with method
3858         call.
3859         * c-exp.y:
3860         (lex_one_token, classify_name, yylex): Replace "parse_language"
3861         with method call.
3862         * ada-exp.y (find_primitive_type, type_char)
3863         (type_system_address): Replace "parse_language" with method call.
3864
3865 2019-04-04  Tom Tromey  <tom@tromey.com>
3866
3867         * rust-exp.y: Replace "parse_gdbarch" with method call.
3868         * parse.c (write_dollar_variable, insert_type_address_space):
3869         Replace "parse_gdbarch" with method call.
3870         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3871         call.
3872         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3873         call.
3874         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3875         "parse_gdbarch" with method call.
3876         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3877         with method call.
3878         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3879         "parse_gdbarch" with method call.
3880         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3881         "parse_gdbarch" with method call.
3882         * c-exp.y (parse_type, parse_number, classify_name): Replace
3883         "parse_gdbarch" with method call.
3884         * ada-lex.l: Replace "parse_gdbarch" with method call.
3885         * ada-exp.y (parse_type, find_primitive_type, type_char)
3886         (type_system_address): Replace "parse_gdbarch" with method call.
3887
3888 2019-04-04  Tom Tromey  <tom@tromey.com>
3889
3890         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3891         * stap-probe.c (stap_parse_argument): Update.
3892         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3893         initial_size parameter.
3894         * rust-exp.y (rust_lex_tests): Update.
3895         * parse.c (parser_state): Update.
3896         (parse_exp_in_context): Update.
3897         * parser-defs.h (struct parser_state) <parser_state>: Remove
3898         "initial_size" parameter.
3899
3900 2019-04-04  Tom Tromey  <tom@tromey.com>
3901
3902         * parser-defs.h (increase_expout_size): Don't declare.
3903         * parse.c (increase_expout_size): Now static.
3904
3905 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3906
3907         * gnu-nat.c (gnu_nat_target::wait): Fix
3908         target_waitstatus_to_string call.
3909
3910 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3911
3912         * eval.c (evaluate_subexp_standard): Handle internal functions
3913         during Fortran function call handling.
3914
3915 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3916
3917         * NEWS: Mention new internal functions.
3918         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3919         (read_base_type): Use dwarf2_init_complex_target_type.
3920         * value.c (creal_internal_fn): New function.
3921         (cimag_internal_fn): New function.
3922         (_initialize_values): Register new internal functions.
3923
3924 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3925
3926         * infrun.c (stop_all_threads): If debug_infrun, always
3927         trace the wait status after wait_one, using
3928         target_waitstatus_to_string and target_pid_to_str.
3929         (handle_inferior_event): Replace various trace of
3930         wait status kind by a single trace.
3931         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3932         wait status kind image by target_waitstatus_to_string.
3933         * target/waitstatus.c (target_waitstatus_to_string): Fix
3934         obsolete comment.
3935
3936 2019-04-01  Tom Tromey  <tromey@adacore.com>
3937
3938         PR symtab/23331:
3939         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3940
3941 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3942             Pedro Alves  <palves@redhat.com>
3943
3944         * top.c (quit_force): Call 'finalize_values'.
3945         * value.c (finalize_values): New function.
3946         * value.h (finalize_values): Declare.
3947
3948 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3949
3950         * NEWS: Announce $_gdb_major and $_gdb_minor.
3951
3952         * top.c (init_gdb_version_vars): New function.
3953         (gdb_init): Call init_gdb_version_vars.
3954
3955 2019-03-29  Tom Tromey  <tromey@adacore.com>
3956
3957         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3958         help text.  Remove dead code.
3959
3960 2019-03-29  Keith Seitz  <keiths@redhat.com>
3961
3962         From Siddhesh Poyarekar:
3963         * f-lang.h (f77_get_upperbound): Return LONGEST.
3964         (f77_get_lowerbound): Likewise.
3965         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3966         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3967         print them.
3968         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3969         plongest to format print it.
3970         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3971         (f77_get_upperbound): Likewise.
3972         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3973         LOWER_BOUND to LONGEST.
3974         (f77_create_arrayprint_offset_tbl): Likewise.
3975
3976 2019-03-29  Keith Seitz  <keiths@redhat.com>
3977
3978         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3979         %s/pulongest for TYPE_LENGTH instead of %d in format
3980         strings.
3981         * ada-typerint.c (ada_print_type): Likewise.
3982         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3983         * compile/compile-c-support.c (generate_register_struct): Likewise.
3984         * gdbtypes.c (recursive_dump_type): Likewise.
3985         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3986         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3987         instead of %d in format strings.
3988         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3989         to std::min to ULONGEST.
3990         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3991         instead of %d in format strings.
3992         * tracepoint.c (info_scope_command): Likewise.
3993         * typeprint.c (print_offset_data::update)
3994         (print_offset_data::finish): Likewise.
3995         * xtensa-tdep.c (xtensa_store_return_value)
3996         (xtensa_push_dummy_call): Likewise.
3997
3998 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3999
4000         * windows-nat.c (display_selector): Fixed format specifications
4001         for 64-bit Cygwin.
4002
4003 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4004
4005         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4006
4007 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4008
4009         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4010         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4011         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4012         (nios2_linux_init_abi): Install it.
4013
4014 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4015
4016         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4017
4018 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4019
4020         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4021
4022 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4023             Tom Tromey  <tromey@adacore.com>
4024
4025         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4026
4027 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4028
4029         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4030         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4031         method to compute the bounds of range types. Also print "[evaluated]"
4032         if the bounds' values come from a dynamic evaluation.
4033
4034 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4035
4036         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4037         whitespace when pretty printing is on.
4038
4039 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4040
4041         * ppc-linux-nat.c: Add include.
4042
4043 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4044
4045         * NEWS: Mention AArch64 Pointer Authentication.
4046
4047 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4048
4049         * arm-linux-nat.c: Add include.
4050
4051 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4052
4053         * source-cache.c (source_cache::get_source_lines): Re-read
4054         fullname after calling open_source_file.
4055
4056 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4057
4058         * NEWS: Mention TLS support for FreeBSD.
4059
4060 2019-03-25  Tom Tromey  <tromey@adacore.com>
4061
4062         * minsyms.c (BUNCH_SIZE): Update comment.
4063         (~minimal_symbol_reader): Remove old comment.
4064         (compact_minimal_symbols): Update comment.
4065         (minimal_symbol_reader::install): Remove old comment.  Update
4066         other comments.
4067
4068 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4069
4070         * s390-linux-nat.c: Add include.
4071
4072 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4073
4074         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4075         Call linux_get_hwcap.
4076         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4077         Likewise.
4078         (aarch64_linux_get_hwcap): Remove function.
4079         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4080         declaration.
4081         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4082         linux_get_hwcap.
4083         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4084         * linux-tdep.c (linux_get_hwcap): Add function.
4085         (linux_get_hwcap2): Likewise.
4086         * linux-tdep.h (linux_get_hwcap): Add declaration.
4087         (linux_get_hwcap2): Likewise.
4088         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4089         (ppc_linux_get_hwcap2): Likewise.
4090         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4091         linux_get_hwcap.
4092         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4093         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4094         (ppc_linux_nat_target::read_description): Likewise.
4095         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4096         * s390-linux-nat.c: Likewise.
4097         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4098
4099 2019-03-24  Tom Tromey  <tom@tromey.com>
4100
4101         * ada-lang.c (standard_lookup): Simplify initialization.
4102         (ada_lookup_symbol_nonlocal): Simplify return.
4103         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4104         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4105         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4106         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4107         initialization.
4108         * solib.c (solib_global_lookup): Simplify.
4109         * symtab.c (null_block_symbol): Remove.
4110         (symbol_cache_lookup): Simplify returns.
4111         (lookup_language_this): Simplify returns.
4112         (lookup_symbol_aux): Simplify return.
4113         (lookup_local_symbol): Simplify returns.
4114         (lookup_global_symbol_from_objfile): Simplify return.
4115         (lookup_symbol_in_objfile_symtabs)
4116         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4117         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4118         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4119         * cp-namespace.c (cp_lookup_bare_symbol)
4120         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4121         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4122         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4123         (cp_lookup_symbol_via_imports): Simplify initialization.
4124         (find_symbol_in_baseclass): Likewise.
4125         * symtab.h (null_block_symbol): Remove.
4126         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4127         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4128         (d_lookup_symbol_module): Likewise.
4129         (find_symbol_in_baseclass): Simplify initialization.
4130
4131 2019-03-24  Tom Tromey  <tom@tromey.com>
4132
4133         * expression.h: Don't include symtab.h.
4134         (struct block): Forward declare.
4135
4136 2019-03-24  Tom Tromey  <tom@tromey.com>
4137
4138         * c-exp.y (typebase): Remove casts.
4139         * gdbtypes.c (lookup_unsigned_typename, )
4140         (lookup_signed_typename): Remove cast.
4141         * eval.c (parse_to_comma_and_eval): Remove cast.
4142         * parse.c (write_dollar_variable): Remove cast.
4143         * block.h (struct block) <superblock>: Now const.
4144         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4145         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4146         (map_block): Make "block" const.
4147         * symfile.h (struct quick_symbol_functions)
4148         <map_matching_symbols>: Constify block argument to "callback".
4149         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4150         const.
4151         (find_pc_sect_compunit_symtab): Make "b" const.
4152         (find_symbol_at_address): Likewise.
4153         (search_symbols): Likewise.
4154         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4155         (dw2_debug_names_lookup_symbol): Likewise.
4156         (dw2_map_matching_symbols): Update.
4157         * p-valprint.c (pascal_val_print): Remove "block".
4158         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4159         (aux_add_nonlocal_symbols): Make "block" const.
4160         (resolve_subexp): Remove cast.
4161         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4162         const.
4163         (iterate_over_file_blocks): Likewise.
4164         * f-exp.y (%union) <bval>: Remove.
4165         * coffread.c (patch_opaque_types): Make "b" const.
4166         * spu-tdep.c (spu_catch_start): Make "block" const.
4167         * c-valprint.c (print_unpacked_pointer): Remove "block".
4168         * symmisc.c (dump_symtab_1): Make "b" const.
4169         (block_depth): Make "block" const.
4170         * d-exp.y (%union) <bval>: Remove.
4171         * cp-support.h (cp_lookup_rtti_type): Update.
4172         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4173         * psymtab.c (psym_lookup_symbol): Make "block" const.
4174         (maintenance_check_psymtabs): Make "b" const.
4175         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4176         (enumerate_locals, enumerate_args): Update.
4177         * python/py-symtab.c (stpy_global_block): Make "block" const.
4178         (stpy_static_block): Likewise.
4179         * inline-frame.c (block_starting_point_at): Make "new_block"
4180         const.
4181         * block.c (find_block_in_blockvector): Make return type const.
4182         (blockvector_for_pc_sect): Make "b" const.
4183         (find_block_in_blockvector): Make "b" const.
4184
4185 2019-03-23  Tom Tromey  <tom@tromey.com>
4186
4187         * varobj.c (varobj_create): Update.
4188         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4189         * printcmd.c (display_command, do_one_display): Don't reset
4190         innermost_block.
4191         * parser-defs.h (enum innermost_block_tracker_type): Move to
4192         expression.h.
4193         (innermost_block): Update comment.
4194         * parse.c (parse_exp_1): Add tracker_types parameter.
4195         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4196         tracker_types parameter.  Reset innermost_block.
4197         (parse_exp_in_context): Remove.
4198         (parse_expression_for_completion): Update.
4199         * objfiles.c (~objfile): Don't reset expression_context_block or
4200         innermost_block.
4201         * expression.h (enum innermost_block_tracker_type): Move from
4202         parser-defs.h.
4203         (parse_exp_1): Add tracker_types parameter.
4204         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4205         reset innermost_block.
4206
4207 2019-03-23  Tom Tromey  <tom@tromey.com>
4208
4209         * objfiles.h: Include bcache.h.
4210
4211 2019-03-23  Tom Tromey  <tom@tromey.com>
4212
4213         * linespec.c (get_current_search_block): Use
4214         scoped_restore_current_language.
4215         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4216
4217 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4218             Jiong Wang  <jiong.wang@arm.com>
4219
4220         * aarch64-linux-tdep.c
4221         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4222         section.
4223         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4224
4225 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4226             Jiong Wang  <jiong.wang@arm.com>
4227
4228         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4229         instructions.
4230         (aarch64_analyze_prologue_test): Add PACIASP test.
4231         (aarch64_prologue_prev_register): Unmask PC value.
4232
4233 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4234             Jiong Wang  <jiong.wang@arm.com>
4235
4236         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4237         (aarch64_dwarf2_prev_register): Unmask PC value.
4238         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4239         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4240         DW_CFA_AARCH64_negate_ra_state.
4241         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4242
4243 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4244             Jiong Wang  <jiong.wang@arm.com>
4245
4246         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4247         registers.
4248         (aarch64_pseudo_register_name): Likewise.
4249         (aarch64_pseudo_register_type): Likewise.
4250         (aarch64_pseudo_register_reggroup_p): Likewise.
4251         (aarch64_gdbarch_init): Add pauth registers.
4252         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4253         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4254         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4255         (struct gdbarch_tdep): Add regnum for ra_state.
4256
4257 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4258             Jiong Wang  <jiong.wang@arm.com>
4259
4260         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4261
4262 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4263             Jiong Wang  <jiong.wang@arm.com>
4264
4265         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4266         function.
4267         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4268         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4269         (aarch64_gdbarch_init): Add puth registers.
4270         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4271         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4272         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4273
4274 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4275             Jiong Wang  <jiong.wang@arm.com>
4276
4277         * aarch64-linux-nat.c
4278         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4279         * aarch64-linux-tdep.c
4280         (aarch64_linux_core_read_description): Likewise.
4281         (aarch64_linux_get_hwcap): New function.
4282         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4283         (aarch64_linux_get_hwcap): New declaration.
4284
4285 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4286             Jiong Wang  <jiong.wang@arm.com>
4287
4288         * aarch64-linux-nat.c
4289         (aarch64_linux_nat_target::read_description): Add pauth param.
4290         * aarch64-linux-tdep.c
4291         (aarch64_linux_core_read_description): Likewise.
4292         * aarch64-tdep.c (struct target_desc): Add in pauth.
4293         (aarch64_read_description): Add pauth param.
4294         (aarch64_gdbarch_init): Likewise.
4295         * aarch64-tdep.h (aarch64_read_description): Likewise.
4296         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4297         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4298         * features/Makefile: Add new files.
4299         * features/aarch64-pauth.c: New file.
4300         * features/aarch64-pauth.xml: New file.
4301
4302 2019-03-20  Tom Tromey  <tromey@adacore.com>
4303
4304         * infrun.c (handle_inferior_event): Rename from
4305         handle_inferior_event_1.  Create a scoped_value_mark.
4306         (handle_inferior_event): Remove.
4307
4308 2019-03-19  Tom Tromey  <tromey@adacore.com>
4309
4310         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4311         * infrun.h (print_stop_event): Add "displays" parameter.
4312         * infrun.c (print_stop_event): Add "displays" parameter.
4313
4314 2019-03-19  Pedro Alves  <palves@redhat.com>
4315
4316         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4317         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4318         to -1.  Fix TABs vs spaces.
4319         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4320         * tui/tui-out.h (tui_ui_out) Add intro comments.
4321         <m_line, m_start_of_line>: In-class initialize, and add describing
4322         comment.
4323
4324 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4325
4326         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4327         variable names.
4328         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4329
4330 2019-03-18  Pedro Alves  <palves@redhat.com>
4331             Eli Zaretskii <eliz@gnu.org>
4332
4333         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4334         m_line and m_start_of_line.
4335
4336 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4337
4338         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4339         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4340         it returns a newline.  This fixes a regression in TU mode, whereby
4341         the next line is output on the same screen line as the user input.
4342
4343 2019-03-18  Tom Tromey  <tromey@adacore.com>
4344
4345         * minsyms.c (minimal_symbol_reader::install): Remove call to
4346         obstack_blank.
4347
4348 2019-03-18  Pedro Alves  <palves@redhat.com>
4349
4350         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4351         New globals.
4352         (apply_style): New, factored out from ...
4353         (apply_ansi_escape): ... this.  Handle reverse video mode.
4354         (tui_set_reverse_mode): New function.
4355         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4356         * tui/tui-winsource.c (tui_show_source_line): Use
4357         tui_set_reverse_mode instead of setting A_STANDOUT.
4358         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4359         New setter methods.
4360
4361 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4362
4363         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4364         Handle tabs.
4365
4366 2019-03-18  Tom Tromey  <tromey@adacore.com>
4367
4368         * ada-lang.c (empty_array): Add "high" parameter.
4369         (ada_evaluate_subexp): Update.
4370
4371 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4372
4373         * unittests/string_view-selftests.c: Define
4374         _initialize_string_view_selftests unconditionally.
4375
4376 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4377
4378         PR gdb/24350
4379         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4380
4381 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4382
4383         PR gdb/24351
4384         * windows-nat.c (display_selector): Fix format specifiers.
4385
4386 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4387
4388         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4389         tui_refill_source_window instead of tui_refresh_win, to update the
4390         current execution line.  This fixes redisplay of the current line
4391         when stepping through the code with "next" or "step".
4392
4393 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4394
4395         * source-cache.c (source_cache::get_source_lines): Call
4396         find_source_lines to initialize s->nlines.  This fixes vertical
4397         scrolling of TUI source window when the DOWN arrow is pressed.
4398
4399 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4400
4401         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4402         linux-thread-db.c (_initialize_thread_db): Likewise.
4403
4404 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4405
4406         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4407         wclrtoeol in tui_show_source_line".  This reverts changes made in
4408         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4409
4410 2019-03-15  Tom Tromey  <tom@tromey.com>
4411
4412         * symtab.h (struct minimal_symbol): Derive from
4413         general_symbol_info.
4414         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4415         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4416         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4417         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4418         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4419         (MSYMBOL_SEARCH_NAME): Update.
4420         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4421         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4422         * minsyms.c (minimal_symbol_reader::record_full): Update.
4423
4424 2019-03-15  Tom Tromey  <tom@tromey.com>
4425
4426         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4427
4428 2019-03-15  Tom Tromey  <tom@tromey.com>
4429
4430         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4431         unique_xmalloc_ptr.
4432         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4433         Update.
4434         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4435         (build_minimal_symbol_hash_tables)
4436         (minimal_symbol_reader::install): Update.
4437
4438 2019-03-15  Tom Tromey  <tom@tromey.com>
4439
4440         * symtab.c (create_demangled_names_hash): Update.
4441         (symbol_set_names): Update.
4442         * objfiles.h (struct objfile_per_bfd_storage)
4443         <demangled_names_hash>: Now an htab_up.
4444         * objfiles.c (objfile_per_bfd_storage): Simplify.
4445
4446 2019-03-15  Tom Tromey  <tom@tromey.com>
4447
4448         * objfiles.h (struct objfile_per_bfd_storage): Declare
4449         destructor.
4450         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4451         New.
4452         (get_objfile_bfd_data): Use new.  Don't initialize
4453         language_of_main.
4454         (free_objfile_per_bfd_storage): Remove.
4455         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4456
4457 2019-03-15  Tom Tromey  <tom@tromey.com>
4458
4459         * symfile.c (reread_symbols): Update.
4460         * objfiles.c (objfile::objfile): Update.
4461         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4462         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4463         comment.
4464         (minimal_symbol_reader::install): Update.
4465         (terminate_minimal_symbol_table): Remove.
4466         * jit.c (jit_object_close_impl): Update.
4467
4468 2019-03-15  Tom Tromey  <tom@tromey.com>
4469
4470         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4471         initializations.
4472
4473 2019-03-15  Tom Tromey  <tom@tromey.com>
4474
4475         * objfiles.h (struct objfile_per_bfd_storage)
4476         <demangled_hash_languages>: Now a bitset.
4477         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4478         (lookup_minimal_symbol): Update.
4479
4480 2019-03-15  Tom Tromey  <tom@tromey.com>
4481
4482         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4483         Don't return the symbol.
4484         * coffread.c (record_minimal_symbol): Use record_full.
4485
4486 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4487
4488         The MS-Windows port of ncurses fails to switch to a color pair if
4489         one or both of the colors are the implicit default colors.  This
4490         change records the default colors when TUI is initialized, and
4491         then specifies them explicitly when a color pair uses the default
4492         colors.  This allows color styling in TUI mode on MS-Windows.
4493
4494         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4495         ncurses_norm_attr.
4496         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4497         colors in ncurses_norm_attr.
4498         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4499         "none", replace it with the default color recorded in
4500         ncurses_norm_attr.
4501
4502 2019-03-14  Tom Tromey  <tromey@adacore.com>
4503
4504         * source-cache.h (class source_cache) <get_source_lines>: Return
4505         std::string.
4506         * source-cache.c (source_cache::extract_lines): Handle case where
4507         first_pos==npos.  Return std::string.
4508         (source_cache::get_source_lines): Update.
4509
4510 2019-03-14  Tom Tromey  <tromey@adacore.com>
4511
4512         * NEWS: Add item for "style sources" commands.
4513         * source-cache.c (source_cache::get_source_lines): Check
4514         source_styling.
4515         * cli/cli-style.c (source_styling): New global.
4516         (_initialize_cli_style): Add "style sources" commands.
4517         (show_style_sources): New function.
4518         * cli/cli-style.h (source_styling): Declare.
4519
4520 2019-03-14  Pedro Alves  <palves@redhat.com>
4521             Tom Tromey  <tromey@adacore.com>
4522
4523         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4524         * tui/tui-winsource.c (tui_refill_source_window): New function,
4525         from...
4526         (tui_horizontal_source_scroll): ... here.  Move some logic.
4527         * cli/cli-style.c (set_style_enabled): Notify new observable.
4528         * tui/tui-hooks.c (tui_redisplay_source): New function.
4529         (tui_attach_detach_observers): Attach or detach
4530         tui_redisplay_source.
4531         * observable.h (source_styling_changed): New observable.
4532         * observable.c: Define source_styling_changed observable.
4533
4534 2019-03-13  Tom Tromey  <tromey@adacore.com>
4535
4536         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4537         (i386_gnu_nat_target::store_registers): Update.
4538         * target-debug.h (target_debug_print_std_string): New macro.
4539         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4540         * windows-tdep.c (display_one_tib): Update.
4541         * tui/tui-stack.c (tui_make_status_line): Update.
4542         * top.c (print_inferior_quit_action): Update.
4543         * thread.c (thr_try_catch_cmd): Update.
4544         (add_thread_with_info): Update.
4545         (thread_target_id_str): Update.
4546         (thr_try_catch_cmd): Update.
4547         (thread_command): Update.
4548         (thread_find_command): Update.
4549         * record-btrace.c (record_btrace_target::info_record)
4550         (record_btrace_resume_thread, record_btrace_target::resume)
4551         (record_btrace_cancel_resume, record_btrace_step_thread)
4552         (record_btrace_target::wait, record_btrace_target::wait)
4553         (record_btrace_target::wait, record_btrace_target::stop): Update.
4554         * progspace.c (print_program_space): Update.
4555         * process-stratum-target.c
4556         (process_stratum_target::thread_address_space): Update.
4557         * linux-fork.c (linux_fork_mourn_inferior)
4558         (detach_checkpoint_command, info_checkpoints_command)
4559         (linux_fork_context): Update.
4560         (linux_fork_detach): Update.
4561         (class scoped_switch_fork_info): Update.
4562         (delete_checkpoint_command): Update.
4563         * infrun.c (follow_fork_inferior): Update.
4564         (follow_fork_inferior): Update.
4565         (proceed_after_vfork_done): Update.
4566         (handle_vfork_child_exec_or_exit): Update.
4567         (follow_exec): Update.
4568         (displaced_step_prepare_throw): Update.
4569         (displaced_step_restore): Update.
4570         (start_step_over): Update.
4571         (resume_1): Update.
4572         (clear_proceed_status_thread): Update.
4573         (proceed): Update.
4574         (print_target_wait_results): Update.
4575         (do_target_wait): Update.
4576         (context_switch): Update.
4577         (stop_all_threads): Update.
4578         (restart_threads): Update.
4579         (finish_step_over): Update.
4580         (handle_signal_stop): Update.
4581         (switch_back_to_stepped_thread): Update.
4582         (keep_going_pass_signal): Update.
4583         (print_exited_reason): Update.
4584         (normal_stop): Update.
4585         * inferior.c (inferior_pid_to_str): Change return type.
4586         (print_selected_inferior): Update.
4587         (add_inferior): Update.
4588         (detach_inferior): Update.
4589         * dummy-frame.c (fprint_dummy_frames): Update.
4590         * dcache.c (dcache_info_1): Update.
4591         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4592         (btrace_fetch, btrace_clear): Update.
4593         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4594         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4595         type.
4596         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4597         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4598         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4599         * gdbarch.c, gdbarch.h: Rebuild.
4600         * gdbarch.sh (core_pid_to_str): Change return type.
4601         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4602         return type.
4603         (windows_nat_target::pid_to_str): Change return type.
4604         (windows_delete_thread): Update.
4605         (windows_nat_target::attach): Update.
4606         (windows_nat_target::files_info): Update.
4607         * target-delegates.c: Rebuild.
4608         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4609         return type.
4610         (sol_thread_target::pid_to_str): Change return type.
4611         * remote.c (class remote_target) <pid_to_str>: Change return
4612         type.
4613         (remote_target::pid_to_str): Change return type.
4614         (extended_remote_target::attach, remote_target::remote_stop_ns)
4615         (remote_target::remote_notif_remove_queued_reply)
4616         (remote_target::push_stop_reply, remote_target::disable_btrace):
4617         Update.
4618         (extended_remote_target::attach): Update.
4619         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4620         type.
4621         (gdbsim_target::pid_to_str): Change return type.
4622         * ravenscar-thread.c (struct ravenscar_thread_target)
4623         <pid_to_str>: Change return type.
4624         (ravenscar_thread_target::pid_to_str): Change return type.
4625         * procfs.c (class procfs_target) <pid_to_str>: Change return
4626         type.
4627         (procfs_target::pid_to_str): Change return type.
4628         (procfs_target::attach): Update.
4629         (procfs_target::detach): Update.
4630         (procfs_target::fetch_registers): Update.
4631         (procfs_target::store_registers): Update.
4632         (procfs_target::wait): Update.
4633         (procfs_target::files_info): Update.
4634         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4635         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4636         return type.
4637         (nto_procfs_target::pid_to_str): Change return type.
4638         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4639         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4640         return type.
4641         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4642         (exit_lwp): Update.
4643         (attach_proc_task_lwp_callback, get_detach_signal)
4644         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4645         (linux_nat_target::resume, wait_lwp, stop_callback)
4646         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4647         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4648         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4649         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4650         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4651         type.
4652         (inf_ptrace_target::attach): Update.
4653         (inf_ptrace_target::files_info): Update.
4654         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4655         type.
4656         (go32_nat_target::pid_to_str): Change return type.
4657         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4658         (gnu_nat_target::wait): Update.
4659         (gnu_nat_target::wait): Update.
4660         (gnu_nat_target::resume): Update.
4661         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4662         (fbsd_nat_target::wait): Update.
4663         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4664         type.
4665         (darwin_nat_target::attach): Update.
4666         * corelow.c (class core_target) <pid_to_str>: Change return type.
4667         (core_target::pid_to_str): Change return type.
4668         * target.c (normal_pid_to_str): Change return type.
4669         (default_pid_to_str): Likewise.
4670         (target_pid_to_str): Change return type.
4671         (target_translate_tls_address): Update.
4672         (target_announce_detach): Update.
4673         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4674         return type.
4675         (bsd_uthread_target::pid_to_str): Change return type.
4676         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4677         type.
4678         (bsd_kvm_target::pid_to_str): Change return type.
4679         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4680         return type.
4681         (aix_thread_target::pid_to_str): Change return type.
4682         * target.h (struct target_ops) <pid_to_str>: Change return type.
4683         (target_pid_to_str, normal_pid_to_str): Likewise.
4684         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4685         type.
4686         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4687         type.
4688         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4689         return type.
4690         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4691         type.
4692         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4693         type.
4694         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4695         return type.
4696
4697 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4698
4699         * NEWS: Mention that the new default MI version is 3.  Mention
4700         changes to the output of commands and events that deal with
4701         multi-location breakpoints.
4702         * breakpoint.c: Include "mi/mi-out.h".
4703         (print_one_breakpoint): Change output syntax if using MI version
4704         >= 3.
4705         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4706         New.
4707         (mi_multi_location_breakpoint_output_fixed): New.
4708         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4709         (mi_cmd_fix_multi_location_breakpoint_output): New.
4710         (mi_multi_location_breakpoint_output_fixed): New.
4711         * mi/mi-cmds.c (mi_cmds): Register command
4712         -fix-multi-location-breakpoint-output.
4713         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4714         interpreter "mi".
4715
4716 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4717
4718         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4719         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4720         instantiate mi_ui_out based on interpreter name.
4721         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4722         * mi/mi-main.c (mi_load_progress): Likewise.
4723
4724 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4725
4726         * NEWS: Combine separate "New targets" sections for 8.3.
4727
4728 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4729
4730         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4731         (ppcfbsd_init_abi): Install gdbarch
4732         "fetch_tls_load_module_address" and "get_thread_local_address"
4733         methods.
4734
4735 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4736
4737         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4738         (riscv_fbsd_init_abi): Install gdbarch
4739         "fetch_tls_load_module_address" and "get_thread_local_address"
4740         methods.
4741
4742 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4743
4744         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4745         (i386fbsd_init_abi): Install gdbarch
4746         "fetch_tls_load_module_address" and "get_thread_local_address"
4747         methods.
4748
4749 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4750
4751         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4752         (amd64fbsd_init_abi): Install gdbarch
4753         "fetch_tls_load_module_address" and "get_thread_local_address"
4754         methods.
4755
4756 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4757
4758         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4759         (struct fbsd_pspace_data): New type.
4760         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4761         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4762         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4763         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4764         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4765
4766 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4767
4768         * gdbtypes.c (lookup_struct_elt): New function.
4769         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4770         * gdbtypes.h (struct struct_elt): New type.
4771         (lookup_struct_elt): New prototype.
4772
4773 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4774
4775         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4776         remove disabled code block.
4777
4778 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4779
4780         * gdbarch.sh (get_thread_local_address): New method.
4781         * gdbarch.h, gdbarch.c: Regenerate.
4782         * target.c (target_translate_tls_address): Use
4783         gdbarch_get_thread_local_address if present instead of
4784         target::get_thread_local_address.
4785
4786 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4787
4788         * target.h (target::get_thread_local_address): Update comment.
4789
4790 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4791
4792         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4793         objfile->separate_debug_objfile_backlink if not NULL.
4794
4795 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4796
4797         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4798         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4799         (amd64bsd_store_inferior_registers): Likewise.
4800         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4801         Enable segment base registers.
4802         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4803         PT_GETFSBASE and PT_GETGSBASE.
4804         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4805         PT_SETGSBASE.
4806         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4807         segment base registers.
4808         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4809
4810 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4811
4812         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4813         Update calls to i386_target_description to add 'segments'
4814         parameter.
4815         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4816         add segment base registers.
4817         * arch/i386.c (i386_create_target_description): Add 'segments'
4818         parameter to enable segment base registers.
4819         * arch/i386.h (i386_create_target_description): Likewise.
4820         * features/i386/32bit-segments.xml: New file.
4821         * features/i386/32bit-segments.c: Generate.
4822         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4823         call to i386_target_description to add 'segments' parameter.
4824         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4825         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4826         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4827         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4828         if feature is present.
4829         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4830         Add 'segments' parameter to call to i386_target_description.
4831         (i386_target_description): Add 'segments' parameter to enable
4832         segment base registers.
4833         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4834         to call to i386_target_description.
4835         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4836         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4837         Define I386_NUM_REGS.
4838         (i386_target_description): Add 'segments' parameter to enable
4839         segment base registers.
4840
4841 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4842
4843         PR/24325
4844         * source-cache.c: #undef open and close, to avoid unresolved
4845         externals during linking.
4846
4847 2019-03-12  Tom Tromey  <tromey@adacore.com>
4848
4849         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4850         const.  Add initializers.
4851         (_initialize_remote): Don't initialize ptid globals.
4852
4853 2019-03-12  Pedro Alves  <palves@redhat.com>
4854
4855         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4856
4857 2019-03-12  Pedro Alves  <palves@redhat.com>
4858
4859         * cp-name-parser.y (main): Remove unused 'len' variable.
4860
4861 2019-03-12  Tom Tromey  <tromey@adacore.com>
4862
4863         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4864         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4865
4866 2019-03-12  Tom Tromey  <tromey@adacore.com>
4867
4868         * linux-nat.c (iterate_over_lwps): Update.
4869         (stop_callback): Remove parameter.
4870         (stop_wait_callback, detach_callback, resume_set_callback)
4871         (select_singlestep_lwp_callback, set_ignore_sigint)
4872         (status_callback, resumed_callback, resume_clear_callback)
4873         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4874         data parameter.
4875         (linux_nat_target::detach, linux_nat_target::resume)
4876         (linux_stop_and_wait_all_lwps, select_event_lwp)
4877         (linux_nat_filter_event, linux_nat_wait_1)
4878         (linux_nat_target::kill, linux_nat_target::stop)
4879         (linux_nat_target::stop): Update.
4880         (linux_nat_resume_callback): Change type.
4881         (resume_stopped_resumed_lwps, count_events_callback)
4882         (select_event_lwp_callback): Likewise.
4883         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4884         * arm-linux-nat.c (struct update_registers_data): Remove.
4885         (update_registers_callback): Change type.
4886         (arm_linux_insert_hw_breakpoint1): Update.
4887         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4888         parameter.
4889         (x86_linux_dr_set_addr): Update.
4890         (x86_linux_dr_set_control): Update.
4891         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4892         (iterate_over_lwps): Use gdb::function_view.
4893         * nat/aarch64-linux-hw-point.c (struct
4894         aarch64_dr_update_callback_param): Remove.
4895         (debug_reg_change_callback): Change type.
4896         (aarch64_notify_debug_reg_change): Update.
4897         * s390-linux-nat.c (s390_refresh_per_info): Update.
4898
4899 2019-03-11  Tom Tromey  <tromey@adacore.com>
4900
4901         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4902         redundant assignment to "this_cu".
4903
4904 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4905
4906         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4907
4908 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4909
4910         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4911         from...
4912         (rank_one_type): ... this.
4913
4914 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4915
4916         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4917         from...
4918         (rank_one_type): ... this.
4919
4920 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4921
4922         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4923         from...
4924         (rank_one_type): ... this.
4925
4926 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4927
4928         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4929         from...
4930         (rank_one_type): ... this.
4931
4932 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4933
4934         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4935         from...
4936         (rank_one_type): ... this.
4937
4938 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4939
4940         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4941         from...
4942         (rank_one_type): ... this.
4943
4944 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4945
4946         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4947         from...
4948         (rank_one_type): ... this.
4949
4950 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4951
4952         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4953         from...
4954         (rank_one_type): ... this.
4955
4956 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4957
4958         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4959         from...
4960         (rank_one_type): ... this.
4961
4962 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4963
4964         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4965         from...
4966         (rank_one_type): ... this.
4967
4968 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4969
4970         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4971         from...
4972         (rank_one_type): ... this.
4973
4974 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4975
4976         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4977         from...
4978         (rank_one_type): ... this.
4979
4980 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4981
4982         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4983         inferior-events' shows the example events.
4984
4985 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4986
4987         Support styling on native MS-Windows console
4988
4989         PR/24315
4990         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4991         on MS-Windows if $TERM is not defined.
4992
4993         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4994
4995         * posix-hdep.c (gdb_console_fputs):
4996         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4997         functions.
4998         * ui-file.h (gdb_console_fputs): Add prototype.
4999
5000         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5001         back to fputs only if the former returns zero.
5002
5003 2019-03-07  Tom Tromey  <tom@tromey.com>
5004
5005         * symmisc.c (print_symbol_bcache_statistics): Update.
5006         (print_objfile_statistics): Update.
5007         * symfile.c (allocate_symtab): Update.
5008         * stabsread.c: Don't include bcache.h.
5009         * psymtab.h (struct psymbol_bcache): Don't declare.
5010         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5011         (psymbol_bcache_init, psymbol_bcache_free)
5012         (psymbol_bcache_get_bcache): Don't declare.
5013         * psymtab.c (struct psymbol_bcache): Remove.
5014         (psymtab_storage::psymtab_storage): Update.
5015         (psymtab_storage::~psymtab_storage): Update.
5016         (psymbol_bcache_init, psymbol_bcache_free)
5017         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5018         (add_psymbol_to_bcache): Update.
5019         (allocate_psymtab): Update.
5020         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5021         macro_cache>: No longer pointers.
5022         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5023         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5024         * macrotab.c (macro_bcache): Update.
5025         * macroexp.c: Don't include bcache.h.
5026         * gdbtypes.c (check_types_worklist): Update.
5027         (types_deeply_equal): Remove TRY/CATCH.  Update.
5028         * elfread.c (elf_symtab_read): Update.
5029         * dwarf2read.c: Don't include bcache.h.
5030         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5031         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5032         (print_bcache_statistics, bcache_memory_used): Don't declare.
5033         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5034         methods.  Rename all data members.
5035         * bcache.c (struct bcache): Move to bcache.h.
5036         (bcache::expand_hash_table): Rename from expand_hash_table.
5037         (bcache): Remove.
5038         (bcache::insert): Rename from bcache_full.
5039         (bcache::compare): Rename from bcache_compare.
5040         (bcache_xmalloc): Remove.
5041         (bcache::~bcache): Rename from bcache_xfree.
5042         (bcache::print_statistics): Rename from print_bcache_statistics.
5043         (bcache::memory_used): Rename from bcache_memory_used.
5044
5045 2019-03-07  Pedro Alves  <palves@redhat.com>
5046
5047         * infrun.c (normal_stop): Also check for
5048         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5049
5050 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5051
5052         * f-lang.c (value_from_host_double): Moved to...
5053         * value.c (value_from_host_double): ...here.
5054         * value.h (value_from_host_double): Declare.
5055         * guile/scm-math.c (vlscm_convert_typed_number): Use
5056         value_from_host_double.
5057         (vlscm_convert_number): Likewise.
5058         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5059         * python/py-value.c (convert_value_from_python): Likewise.
5060
5061 2019-03-06  Tom Tromey  <tom@tromey.com>
5062
5063         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5064
5065 2019-03-06  Tom Tromey  <tom@tromey.com>
5066
5067         * utils.h (free_current_contents): Don't declare.
5068         * utils.c (free_current_contents): Remove.
5069
5070 2019-03-06  Tom Tromey  <tom@tromey.com>
5071
5072         * top.c (quit_force): Update.
5073         * main.c (captured_command_loop): Update.
5074         * common/new-op.c (operator new): Update.
5075         * common/common-exceptions.c (struct catcher)
5076         <save_cleanup_chain>: Remove member.
5077         (exceptions_state_mc_init): Update.
5078         (exception_try_scope_entry): Return nullptr.
5079         (exception_try_scope_exit, exception_rethrow)
5080         (throw_exception_sjlj, throw_exception_cxx): Update.
5081         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5082         (all_cleanups, do_cleanups, discard_cleanups)
5083         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5084         (restore_cleanups, restore_final_cleanups): Don't declare.
5085         (do_final_cleanups): Remove parameter.
5086         * common/cleanups.c (cleanup_chain, make_cleanup)
5087         (make_cleanup_dtor, all_cleanups, do_cleanups)
5088         (discard_my_cleanups, discard_cleanups)
5089         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5090         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5091         (null_cleanup): Remove.
5092         (do_final_cleanups): Remove parameter.
5093
5094 2019-03-06  Tom Tromey  <tom@tromey.com>
5095
5096         * remote.c (remote_target::remote_parse_stop_reply): Use
5097         unique_xmalloc_ptr.
5098
5099 2019-03-06  Tom Tromey  <tom@tromey.com>
5100
5101         * stabsread.c (struct stabs_field_info): Rename from field_info.
5102         <list, fnlist>: Add initializers.
5103         <obstack>: New member.
5104         (read_member_functions, read_struct_fields, read_baseclasses):
5105         Allocate on obstack.  Don't use cleanups.
5106         (read_one_struct_field, read_member_functions, read_struct_fields)
5107         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5108         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5109         (read_struct_type): Update.
5110
5111 2019-03-06  Tom Tromey  <tom@tromey.com>
5112
5113         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5114         * common/filestuff.h (make_cleanup_close): Don't declare.
5115         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5116         Remove.
5117
5118 2019-03-06  Tom Tromey  <tom@tromey.com>
5119
5120         * solib-aix.c: Use make_scope_exit.
5121
5122 2019-03-06  Tom Tromey  <tom@tromey.com>
5123
5124         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5125         Use make_scope_exit.
5126
5127 2019-03-06  Tom Tromey  <tom@tromey.com>
5128
5129         * solib-svr4.c (disable_probes_interface): Remove parameter.
5130         (svr4_handle_solib_event): Use make_scope_exit.
5131
5132 2019-03-06  Tom Tromey  <tom@tromey.com>
5133
5134         * remote.c (struct stop_reply_deleter): Remove.
5135         (stop_reply_up): Update.
5136         (struct stop_reply): Derive from notif_event.  Don't typedef.
5137         <regcache>: Now a std::vector.
5138         (stop_reply_xfree): Remove.
5139         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5140         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5141         (remote_target::discard_pending_stop_replies): Use delete.
5142         (remote_target::remote_parse_stop_reply): Update.
5143         (remote_target::process_stop_reply): Update.
5144         * remote-notif.h (struct notif_event): Add virtual destructor.
5145         Remove "dtr" member.
5146         (struct notif_client) <alloc_event>: Return a unique_ptr.
5147         (notif_event_xfree): Don't declare.
5148         (notif_event_up): New typedef.
5149         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5150         (notif_event_xfree, do_notif_event_xfree): Remove.
5151         (remote_notif_state_xfree): Update.
5152
5153 2019-03-06  Tom Tromey  <tom@tromey.com>
5154
5155         * infrun.c (displaced_step_clear_cleanup): Now a
5156         forward_scope_exit type.
5157         (displaced_step_prepare_throw): Update.
5158         (displaced_step_fixup): Update.
5159
5160 2019-03-06  Tom Tromey  <tom@tromey.com>
5161
5162         * inferior.h (class inferior): Update comment.
5163         * gdbthread.h (class thread_info): Update comment.
5164
5165 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5166             Tom Tromey  <tom@tromey.com>
5167
5168         * stabsread.h (struct stab_section_list): Remove.
5169         (coffstab_build_psymtabs): Update.
5170         * dbxread.c (symbuf_sections): Now a std::vector.
5171         (sect_idx): New global.
5172         (fill_symbuf): Update.
5173         (coffstab_build_psymtabs): Change type of stabsects parameter.
5174         Update.
5175         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5176         std::vector.
5177         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5178         (coff_locate_sections): Update.
5179         (coff_symfile_read): Remove cleanups.  Update.
5180         (init_stringtab): Add storage parameter.
5181         (free_stringtab, free_stringtab_cleanup): Remove.
5182         (init_lineno): Add storage parameter.
5183         (free_linetab, free_linetab_cleanup): Remove.
5184
5185 2019-03-06  Pedro Alves  <palves@redhat.com>
5186
5187         * linux-fork.c (fork_info::clobber_regs): Delete.
5188         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5189         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5190         comment.  Adjust.
5191         (scoped_switch_fork_info::scoped_switch_fork_info)
5192         (checkpoint_command, linux_fork_context): Adjust
5193         fork_save_infrun_state calls.
5194
5195 2019-03-06  Pedro Alves  <palves@redhat.com>
5196
5197         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5198         (inf_has_multiple_threads): Return 'bool' and rewrite using
5199         inferior_info::threads().
5200
5201 2019-03-06  Pedro Alves  <palves@redhat.com>
5202
5203         * linux-fork.c: Include <list>.
5204         (fork_list): Now a std::list instance.
5205         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5206         (forks_exist_p, find_last_fork): Adjust.
5207         (new_fork): Delete.
5208         (one_fork_p): New.
5209         (add_fork): Adjust.
5210         (free_fork): Delete, folded into fork_info::~fork_info().
5211         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5212         Adjust.
5213         (init_fork_list): Delete.
5214         (linux_fork_killall, linux_fork_mourn_inferior)
5215         (linux_fork_detach, info_checkpoints_command): Adjust.
5216         (_initialize_linux_fork): No longer call init_fork_list.
5217
5218 2019-03-06  Pedro Alves  <palves@redhat.com>
5219
5220         * linux-fork.c (new_fork): New, split out of ...
5221         (add_fork): ... this.  Return void.  Move "first fork" special
5222         case from here, to ...
5223         (checkpoint_command): ... here.
5224         * linux-linux.h (add_fork): Return void.
5225
5226 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5227
5228         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5229
5230 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5231             Chris January  <chris.january@arm.com>
5232             David Lecomber  <david.lecomber@arm.com>
5233
5234         * f-exp.y: New token, UNOP_INTRINSIC.
5235         (exp): New pattern using UNOP_INTRINSIC token.
5236         (f77_keywords): Add 'abs' keyword.
5237         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5238         (value_from_host_double): New function.
5239         (evaluate_subexp_f): Support UNOP_ABS.
5240
5241 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5242
5243         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5244         types.
5245
5246 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5247
5248         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5249         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5250         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5251
5252 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5253
5254         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5255
5256 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5257             Chris January  <chris.january@arm.com>
5258
5259         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5260         * f-exp.y: Define 'KIND' token.
5261         (exp): New pattern for KIND expressions.
5262         (ptype): Handle types with a kind extension.
5263         (direct_abs_decl): Extend to spot kind extensions.
5264         (f77_keywords): Add 'kind' to the list.
5265         (push_kind_type): New function.
5266         (convert_to_kind_type): New function.
5267         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5268         * parse.c (operator_length_standard): Likewise.
5269         * parser-defs.h (enum type_pieces): Add tp_kind.
5270         * std-operator.def: Add UNOP_KIND.
5271
5272 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5273
5274         * f-exp.y (f_parse): Set yydebug.
5275
5276 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5277
5278         * f-lang.c (evaluate_subexp_f): New function.
5279         (exp_descriptor_f): New global.
5280         (f_language_defn): Use exp_descriptor_f instead of
5281         exp_descriptor_standard.
5282
5283 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5284
5285         * f-exp.y (struct token): Add comments.
5286         (dot_ops): Remove uppercase versions and the end marker.
5287         (f77_keywords): Likewise.
5288         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5289         entries in the dot_ops array are case insensitive, and use
5290         strncasecmp to compare strings.  Also some whitespace cleanup in
5291         this area.  Similar for the f77_keywords array, except entries in
5292         this list might be case sensitive.
5293
5294 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5295
5296         * f-exp.y (struct f77_boolean_val): Add comments.
5297         (boolean_values): Remove uppercase versions, and end marker.
5298         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5299         and use strncasecmp to achieve case insensitivity.  Additionally,
5300         perform whitespace cleanup around this code.
5301
5302 2019-03-06  Tom Tromey  <tromey@adacore.com>
5303
5304         * remote-sim.c (gdbsim_target_open): Use result of
5305         gdb_argv::release.
5306
5307 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5308         Dirk Schubert  <dirk.schubert@arm.com>
5309         Chris January  <chris.january@arm.com>
5310
5311         * eval.c (evaluate_subexp_standard): Call Fortran argument
5312         wrapping logic.
5313         * f-lang.c (struct value): A value which can be passed into a
5314         Fortran function call.
5315         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5316         where appropriate.
5317         (struct type): Value ready for a Fortran function call.
5318         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5319         is needed.
5320         * f-lang.h (fortran_argument_convert): Declaration.
5321         (fortran_preserve_arg_pointer): Declaration.
5322         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5323
5324 2019-03-05  Tom Tromey  <tromey@adacore.com>
5325
5326         * python/py-prettyprint.c (print_string_repr): Remove #if.
5327         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5328
5329 2019-03-05  Tom Tromey  <tromey@adacore.com>
5330
5331         * target.c (the_dummy_target): Move later.  Change type to
5332         "dummy_target".
5333         (initialize_targets): Don't initialize the_dummy_target.
5334
5335 2019-03-05  Tom Tromey  <tromey@adacore.com>
5336
5337         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5338         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5339
5340 2019-03-05  Tom Tromey  <tromey@adacore.com>
5341
5342         * windows-nat.c (windows_nat_target::attach)
5343         (windows_nat_target::detach): Don't call gdb_flush.
5344         * valprint.c (generic_val_print, val_print, val_print_string):
5345         Don't call gdb_flush.
5346         * utils.c (defaulted_query): Don't call gdb_flush.
5347         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5348         * target.c (target_announce_detach): Don't call gdb_flush.
5349         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5350         * remote.c (extended_remote_target::attach): Don't call
5351         gdb_flush.
5352         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5353         * printcmd.c (do_examine): Don't call gdb_flush.
5354         (info_display_command): Don't call gdb_flush.
5355         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5356         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5357         * memattr.c (info_mem_command): Don't call gdb_flush.
5358         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5359         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5360         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5361         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5362         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5363         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5364         (gnu_nat_target::detach): Don't call gdb_flush.
5365         * f-valprint.c (f_val_print): Don't call gdb_flush.
5366         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5367         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5368         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5369         gdb_flush.
5370         * c-valprint.c (c_val_print): Don't call gdb_flush.
5371         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5372
5373 2019-03-05  Tom Tromey  <tromey@adacore.com>
5374
5375         * varobj.c (update_dynamic_varobj_children): Update.
5376         (install_default_visualizer): Use reset, not release.
5377         * value.c (set_internalvar): Update.
5378         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5379         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5380         ATTRIBUTE_UNUSED_RESULT.
5381
5382 2019-03-05  Tom Tromey  <tromey@adacore.com>
5383
5384         * remote.c (class scoped_remote_fd) <release>: Add
5385         ATTRIBUTE_UNUSED_RESULT.
5386
5387 2019-03-05  Tom Tromey  <tromey@adacore.com>
5388
5389         * macroexp.c (struct macro_buffer) <release>: Add
5390         ATTRIBUTE_UNUSED_RESULT.
5391
5392 2019-03-05  Tom Tromey  <tromey@adacore.com>
5393
5394         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5395         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5396         ATTRIBUTE_UNUSED_RESULT.
5397
5398 2019-03-05  Tom Tromey  <tromey@adacore.com>
5399
5400         * common/scoped_fd.h (class scoped_fd) <release>: Add
5401         ATTRIBUTE_UNUSED_RESULT.
5402
5403 2019-03-05  Tom Tromey  <tromey@adacore.com>
5404
5405         * parser-defs.h (struct parser_state) <release>: Add
5406         ATTRIBUTE_UNUSED_RESULT.
5407
5408 2019-03-05  Tom Tromey  <tromey@adacore.com>
5409
5410         * utils.h (class gdb_argv) <release>: Add
5411         ATTRIBUTE_UNUSED_RESULT.
5412         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5413
5414 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5415
5416         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5417         for-loop range, to avoid compiler warnings.
5418
5419         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5420         avoid compiler warnings about unused variables.
5421
5422         * NEWS: Mention end of support for native debugging on MS-Windows
5423         before XP.
5424
5425         PR gdb/24292
5426         * common/netstuff.c:
5427         * gdbserver/gdbreplay.c
5428         * gdbserver/remote-utils.c:
5429         * ser-tcp.c:
5430         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5431         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5432         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5433         'getaddrinfo' and 'freeaddrinfo' were not available before
5434         Windows XP, and mingw.org's MinGW headers by default define
5435         _WIN32_WINNT to 0x500.
5436
5437 2019-03-01  Gary Benson <gbenson@redhat.com>
5438
5439         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5440
5441 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5442             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5443
5444         PR gdb/8527
5445         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5446         set_sigint_trap, clear_sigint_trap.
5447
5448 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5449
5450         * target.c (target_detach): Clear the regcache and the
5451         frame cache.
5452
5453 2019-02-27  Pedro Alves  <palves@redhat.com>
5454
5455         * utils.c (set_screen_size): When we cap the height/width sizes,
5456         tweak the corresponding command variable to show "unlimited":
5457
5458 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5459             Pedro Alves  <palves@redhat.com>
5460
5461         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5462         before calling rl_set_screen_size.
5463
5464 2019-02-27  Tom Tromey  <tromey@adacore.com>
5465
5466         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5467         define.
5468         * python/py-value.c: Remove Python 2.4 workaround.
5469         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5470         workaround.
5471         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5472         Python 2.4 workaround.
5473         * python/python-internal.h: Remove Python 2.4 comment.
5474         (Py_ssize_t): Don't define.
5475         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5476         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5477         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5478         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5479         * python/python.c (do_start_initialization): Remove Python 2.4
5480         workaround.
5481         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5482         (print_children): Remove Python 2.4 workaround.
5483         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5484         workaround.
5485         (CHARBUFFERPROC_NAME): Remove.
5486         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5487         Python 2.4 workaround.
5488
5489 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5490
5491         * NEWS: Note minimum Python version.
5492
5493 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5494
5495         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5496         code from these functions.  Remove corresponding ifdefs.  Use
5497         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5498         Remove gotos and target of gotos.
5499         (infpy_search_memory): Likewise.
5500
5501 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5502
5503         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5504         (hppa_gdbarch_init): Don't register deleted functions with
5505         gdbarch.
5506
5507 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5508
5509         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5510         (h8300_unwind_sp): Delete.
5511         (h8300_dummy_id): Delete.
5512         (h8300_gdbarch_init): Don't register deleted functions with
5513         gdbarch.
5514
5515 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5516
5517         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5518         (ft32_unwind_pc): Delete.
5519         (ft32_unwind_sp): Delete.
5520         (ft32_gdbarch_init): Don't register deleted functions with
5521         gdbarch.
5522
5523 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5524
5525         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5526         (frv_unwind_pc): Delete.
5527         (frv_unwind_sp): Delete.
5528         (frv_gdbarch_init): Don't register deleted functions with
5529         gdbarch.
5530
5531 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5532
5533         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5534         (riscv_unwind_pc): Delete.
5535         (riscv_unwind_sp): Delete.
5536         (riscv_gdbarch_init): Don't register deleted functions with
5537         gdbarch.
5538
5539 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5540
5541         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5542         (csky_unwind_pc): Delete.
5543         (csky_unwind_sp): Delete.
5544         (csky_gdbarch_init): Don't register deleted functions with
5545         gdbarch.
5546
5547 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5548
5549         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5550         (cris_unwind_pc): Delete.
5551         (cris_unwind_sp): Delete.
5552         (cris_gdbarch_init): Don't register deleted functions with
5553         gdbarch.
5554
5555 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5556
5557         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5558         (bfin_unwind_pc): Delete.
5559         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5560
5561 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5562
5563         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5564         (arm_unwind_pc): Delete.
5565         (arm_unwind_sp): Delete.
5566         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5567
5568 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5569
5570         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5571         (arc_unwind_pc): Delete.
5572         (arc_unwind_sp): Delete.
5573         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5574
5575 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5576
5577         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5578         (alpha_unwind_pc): Delete.
5579         (alpha_gdbarch_init): Don't register deleted functions with
5580         gdbarch.
5581
5582 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5583
5584         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5585         (aarch64_unwind_pc): Delete.
5586         (aarch64_unwind_sp): Delete.
5587         (aarch64_gdbarch_init): Don't register deleted functions with
5588         gdbarch.
5589
5590 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5591
5592         * gdbtypes.c (type_align): Don't consider static members when
5593         computing structure alignment.
5594
5595 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5596
5597         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5598         return 0 for other types.
5599         * arch-utils.c (default_type_align): Always return 0.
5600         * gdbarch.h: Regenerate.
5601         * gdbarch.sh (type_align): Extend comment.
5602         * gdbtypes.c (type_align): Add additional comments, always call
5603         gdbarch_type_align before applying the default rules.
5604         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5605         generic code will then apply a suitable default.
5606         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5607         types, return 0 for other types.
5608
5609 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5610
5611         * NEWS: Create a new section for the next release branch.
5612         Rename the section of the current branch, now that it has
5613         been cut.
5614
5615 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5616
5617         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5618         * version.in: Bump version to 8.3.50.DATE-git.
5619
5620 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5621
5622         * aix-thread.c (ptid_cmp): Remove unused variable.
5623         (get_signaled_thread): Likewise.
5624         (store_regs_user_thread): Likewise.
5625         (store_regs_kernel_thread): Likewise.
5626         (fetch_regs_kernel_thread): Remove shadowed variable.
5627
5628 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5629
5630         * features/riscv/32bit-cpu.xml: Add register numbers.
5631         * features/riscv/32bit-fpu.c: Regenerate.
5632         * features/riscv/32bit-fpu.xml: Add register numbers.
5633         * features/riscv/64bit-cpu.xml: Add register numbers.
5634         * features/riscv/64bit-fpu.c: Regenerate.
5635         * features/riscv/64bit-fpu.xml: Add register numbers.
5636
5637 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5638
5639         * NEWS: Mention two argument form of gdb.Value constructor.
5640         * python/py-value.c (convert_buffer_and_type_to_value): New
5641         function.
5642         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5643         Add support for handling an optional second argument.  Call
5644         convert_buffer_and_type_to_value as appropriate.
5645         * python/python-internal.h (Py_buffer_deleter): New struct.
5646         (Py_buffer_up): New typedef.
5647
5648 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5649
5650         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5651         instead of releasing ownership.
5652
5653 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5654
5655         * dwarf2read.c (open_and_init_dwp_file): Call
5656         elf_numsections instead of bfd_count_sections to initialize
5657         dwp_file->num_sections.
5658
5659 2019-02-25  Tom Tromey  <tromey@adacore.com>
5660
5661         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5662
5663 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5664
5665         * gcore.in: Add '--readnever' option when invoking GDB.
5666
5667 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5668
5669         * MAINTAINERS: Update my email address.
5670
5671 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5672
5673         * build-id.c (build_id_to_debug_bfd_1): New function.
5674         (build_id_to_debug_bfd): Look for separate debug file in
5675         sysroot.
5676
5677 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5678
5679         * gdbarch.sh: Update the copyright year range that is placed into
5680         generated files.
5681
5682 2019-02-22  Keith Seitz  <keiths@redhat.com>
5683
5684         PR symtab/23853
5685         * linespec.c (create_sals_line_offset): Search for the default
5686         symtab's filename instead of its fullname.
5687
5688 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5689
5690         * NEWS: Update style defaults.
5691
5692 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5693
5694         * main.c (captured_main_1): Disable styling in batch mode.
5695
5696 2019-02-20  Tom Tromey  <tom@tromey.com>
5697
5698         * symtab.c (symtab_symbol_info): Fix typos.
5699
5700 2019-02-20  Tom Tromey  <tromey@adacore.com>
5701
5702         * findcmd.c (_initialize_mem_search): Use upper case for
5703         metasyntactic variables.
5704
5705 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5706
5707         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5708         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5709
5710 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5711
5712         * top.h (source_file_name): Change to std::string.
5713         * top.c (source_file_name): Likewise.
5714         (command_line_input): Adjust.
5715         * cli/cli-script.c (script_from_file): Adjust.
5716
5717 2019-02-19  Tom Tromey  <tromey@adacore.com>
5718
5719         * ravenscar-thread.c
5720         (ravenscar_thread_target::update_thread_list): Don't call
5721         ada_build_task_list.
5722         * ada-lang.h (ada_build_task_list): Don't declare.
5723         * ada-tasks.c (struct ada_tasks_inferior_data)
5724         <task_list_valid_p>: Now bool.
5725         (read_known_tasks, ada_task_list_changed)
5726         (ada_tasks_invalidate_inferior_data): Update.
5727         (read_known_tasks_array): Return bool.
5728         (read_known_tasks_list): Likewise.
5729         (read_known_tasks): Return void.
5730         (ada_build_task_list): Now static.
5731
5732 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5733
5734         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5735         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5736
5737 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5738
5739         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5740         variant for ada_tasks_pspace_data_handle and
5741         ada_tasks_inferior_data_handle.
5742         (ada_tasks_pspace_data_cleanup): New function.
5743         (ada_tasks_inferior_data_cleanup): New function.
5744
5745 2019-02-17  Tom Tromey  <tom@tromey.com>
5746
5747         * macrotab.h (macro_source_fullname): Return a std::string.
5748         * macrotab.c (macro_include, check_for_redefinition)
5749         (macro_undef, macro_lookup_definition, foreach_macro)
5750         (foreach_macro_in_scope): Update.
5751         (macro_source_fullname): Return a std::string.
5752         * macrocmd.c (show_pp_source_pos): Update.
5753
5754 2019-02-17  Tom Tromey  <tom@tromey.com>
5755
5756         * macrocmd.c (show_pp_source_pos): Style the file names.
5757
5758 2019-02-17  Tom Tromey  <tom@tromey.com>
5759
5760         PR tui/24197:
5761         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5762
5763 2019-02-17  Tom Tromey  <tom@tromey.com>
5764
5765         * ada-lang.c (user_select_syms): Use filtered printing.
5766         * utils.c (wrap_style): New global.
5767         (desired_style): Remove.
5768         (emit_style_escape): Add stream parameter.
5769         (set_output_style, reset_terminal_style, prompt_for_continue):
5770         Update.
5771         (flush_wrap_buffer): Only flush gdb_stdout.
5772         (wrap_here): Set wrap_style.
5773         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5774         treat escape sequences as a character.  Change when wrap buffer is
5775         flushed.
5776         (fputs_styled): Do not set the output style when the default is
5777         requested.
5778         * ui-style.h (struct ui_file_style) <is_default>: New method.
5779         * source.c (print_source_lines_base): Emit escape sequences in one
5780         piece.
5781
5782 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5783
5784         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5785         integers and enumeration types.
5786
5787 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5788
5789         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5790         instead of lookup_symbol_in_language
5791         (do_exact_match): New function.
5792         (ada_get_symbol_name_matcher): Return do_exact_match when
5793         doing a verbatim match.
5794
5795 2019-02-15  Tom Tromey  <tromey@adacore.com>
5796
5797         * ravenscar-thread.c (ravenscar_thread_target::resume)
5798         (ravenscar_thread_target::wait): Special case wildcard requests.
5799
5800 2019-02-15  Tom Tromey  <tromey@adacore.com>
5801
5802         * ravenscar-thread.c (base_ptid): Remove.
5803         (struct ravenscar_thread_target) <close>: New method.
5804         <m_base_ptid>: New member.
5805         <update_inferior_ptid, active_task, task_is_currently_active,
5806         runtime_initialized>: Declare methods.
5807         <ravenscar_thread_target>: Add constructor.
5808         (ravenscar_thread_target::task_is_currently_active)
5809         (ravenscar_thread_target::update_inferior_ptid)
5810         (ravenscar_runtime_initialized): Rename.  Now methods.
5811         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5812         (ravenscar_thread_target::update_thread_list): Update.
5813         (ravenscar_thread_target::active_task): Now method.
5814         (ravenscar_thread_target::store_registers)
5815         (ravenscar_thread_target::prepare_to_store)
5816         (ravenscar_thread_target::prepare_to_store)
5817         (ravenscar_thread_target::mourn_inferior): Update.
5818         (ravenscar_inferior_created): Use "new" to create target.
5819         (ravenscar_thread_target::get_ada_task_ptid): Update.
5820         (_initialize_ravenscar): Don't initialize base_ptid.
5821         (ravenscar_ops): Remove global.
5822
5823 2019-02-15  Tom Tromey  <tromey@adacore.com>
5824
5825         * target.h (push_target): Declare new overload.
5826         * target.c (push_target): New overload, taking an rvalue reference.
5827         * remote.c (remote_target::open_1): Use push_target overload.
5828         * corelow.c (core_target_open): Use push_target overload.
5829
5830 2019-02-15  Tom Tromey  <tromey@adacore.com>
5831
5832         * ravenscar-thread.c (is_ravenscar_task)
5833         (ravenscar_task_is_currently_active): Return bool.
5834         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5835         (_initialize_ravenscar): Remove "(void)".
5836         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5837         Return bool.
5838
5839 2019-02-15  Tom Tromey  <tromey@adacore.com>
5840
5841         * ravenscar-thread.c (ravenscar_runtime_initializer)
5842         (has_ravenscar_runtime, get_running_thread_id)
5843         (ravenscar_thread_target::resume): Fix indentation.
5844
5845 2019-02-15  Tom Tromey  <tromey@adacore.com>
5846
5847         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5848         from ravenscar_arch_ops.
5849         (sparc_ravenscar_ops::fetch_registers)
5850         (sparc_ravenscar_ops::store_registers): Now methods.
5851         (sparc_ravenscar_prepare_to_store): Remove.
5852         (sparc_ravenscar_ops): Redefine.
5853         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5854         methods and destructor.  Remove members.
5855         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5856         (ravenscar_thread_target::store_registers)
5857         (ravenscar_thread_target::prepare_to_store): Update.
5858         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5859         Remove.
5860         (struct ppc_ravenscar_powerpc_ops): Derive from
5861         ravenscar_arch_ops.
5862         (ppc_ravenscar_powerpc_ops::fetch_registers)
5863         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5864         (ppc_ravenscar_powerpc_ops): Redefine.
5865         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5866         (ppc_ravenscar_e500_ops::fetch_registers)
5867         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5868         (ppc_ravenscar_e500_ops): Redefine.
5869         * aarch64-ravenscar-thread.c
5870         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5871         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5872         (aarch64_ravenscar_fetch_registers)
5873         (aarch64_ravenscar_store_registers): Now methods.
5874         (aarch64_ravenscar_ops): Redefine.
5875
5876 2019-02-15  Tom Tromey  <tromey@adacore.com>
5877
5878         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5879         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5880         (ravenscar_thread_target::stopped_by_watchpoint)
5881         (ravenscar_thread_target::stopped_data_address)
5882         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5883
5884 2019-02-15  Tom Tromey  <tromey@adacore.com>
5885
5886         * ravenscar-thread.c: Fix some typos.
5887
5888 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5889             Tom Tromey  <tromey@adacore.com>
5890
5891         * ada-lang.c (ada_exception_sal): Change addr_string to a
5892         std::string.
5893         (create_ada_exception_catchpoint): Update.
5894
5895 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5896             Tom Tromey  <tromey@adacore.com>
5897
5898         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5899         (bp_location_ops): Remove.
5900         (base_breakpoint_allocate_location): Update.
5901         (free_bp_location): Update.
5902         * ada-lang.c (class ada_catchpoint_location)
5903         <ada_catchpoint_location>: Remove ops parameter.
5904         (ada_catchpoint_location_dtor): Remove.
5905         (ada_catchpoint_location_ops): Remove.
5906         (allocate_location_exception): Update.
5907         * breakpoint.h (struct bp_location_ops): Remove.
5908         (class bp_location) <bp_location>: Remove bp_location_ops
5909         parameter.
5910         <~bp_location>: Add destructor.
5911         <ops>: Remove.
5912
5913 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5914             Pedro Alves  <palves@redhat.com>
5915
5916         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5917         'PATH_MAX'.
5918
5919 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5920             Samuel Thibault  <samuel.thibault@gnu.org>
5921             Thomas Schwinge  <thomas@codesourcery.com>
5922
5923         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5924         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5925
5926 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5927
5928         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5929         (check_empty): Use "const char *".
5930
5931         * gnu-nat.c (gnu_nat_target::detach): Instead of
5932         'detach_inferior (pid)' call
5933         'detach_inferior (find_inferior_pid (pid))'.
5934
5935         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5936         'nat/fork-inferior.o'.
5937         * gnu-nat.c: #include "nat/fork-inferior.h".
5938
5939         * gnu-nat.c (gnu_nat_target::detach): Instead of
5940         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5941         * gnu-nat.h: #include "inf-child.h".
5942         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5943         'i386_gnu_nat_target::fetch_registers'.
5944         (gnu_store_registers): Rename/move to
5945         'i386_gnu_nat_target::store_registers'.
5946
5947         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5948         * gnu-nat.h (mach_thread_info): New function.
5949         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5950
5951         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5952
5953 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5954
5955         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5956
5957 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5958
5959         * windows-nat.c (windows_add_thread): Add new parameter
5960         "main_thread_p" with default value set to false.  Update
5961         function documentation as well as all callers.
5962         (windows_delete_thread): Likewise.
5963         (fake_create_process): Update call to windows_add_thread.
5964         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5965         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5966         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5967         call to windows_delete_thread.
5968
5969 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5970
5971         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5972
5973 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5974
5975         * symfile.c (find_separate_debug_file): Use canonical path of
5976         sysroot with child_path instead of gdb_sysroot if it is valid.
5977
5978 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5979
5980         * symfile.c (find_separate_debug_file): Use child_path to
5981         determine if an object file is under a sysroot.
5982
5983 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5984
5985         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5986         unittests/child-path-selftests.c.
5987         * common/pathstuff.c (child_path): New function.
5988         * common/pathstuff.h (child_path): New prototype.
5989         * unittests/child-path-selftests.c: New file.
5990
5991 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5992
5993         * symfile.c (find_separate_debug_file): Look for separate debug
5994         files in debug directories under the sysroot.
5995
5996 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5997
5998         * symtab.h (struct minimal_symbol data_p): New const method.
5999         (struct minimal_symbol text_p): Likewise.
6000         * symtab.c (output_source_filename): Use file name style
6001         to print file name.
6002         (print_symbol_info): Likewise.
6003         (print_msymbol_info): Use address style to print addresses.
6004         Use function name style to print executable text symbols.
6005         (expand_symtab_containing_pc): Use data_p.
6006         (find_pc_sect_compunit_symtab): Likewise.
6007
6008 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6009
6010         * breakpoint.c (describe_other_breakpoints): Use address style
6011         to print addresses.
6012         (say_where): Likewise.
6013
6014 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6015
6016         * ada-typeprint.c (print_func_type): Print function name
6017         style to print function name.
6018         * c-typeprint.c (c_print_type_1): Likewise.
6019
6020 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6021
6022         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6023         for execve.
6024
6025 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6026
6027         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6028         type_stack.
6029
6030 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6031
6032         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6033         TYPE_CODE_REF types.
6034
6035 2019-02-08  Jim Wilson  <jimw@sifive.com>
6036
6037         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6038         (riscv_linux_fregset): New.
6039         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6040
6041 2019-02-07  Tom Tromey  <tom@tromey.com>
6042
6043         * thread.c (thread_cancel_execution_command): Update.
6044         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6045         methods.
6046         (struct thread_fsm_ops): Remove.
6047         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6048         (thread_fsm_should_stop, thread_fsm_return_value)
6049         (thread_fsm_set_finished, thread_fsm_finished_p)
6050         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6051         Don't declare.
6052         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6053         * infrun.c (clear_proceed_status_thread)
6054         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6055         (print_stop_event): Update.
6056         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6057         Add constructor.
6058         (step_command_fsm_ops): Remove.
6059         (new_step_command_fsm): Remove.
6060         (step_1): Update.
6061         (step_command_fsm::should_stop): Rename from
6062         step_command_fsm_should_stop.
6063         (step_command_fsm::clean_up): Rename from
6064         step_command_fsm_clean_up.
6065         (step_command_fsm::do_async_reply_reason): Rename from
6066         step_command_fsm_async_reply_reason.
6067         (struct until_next_fsm): Inherit from thread_fsm.  Add
6068         constructor.
6069         (until_next_fsm_ops): Remove.
6070         (new_until_next_fsm): Remove.
6071         (until_next_fsm::should_stop): Rename from
6072         until_next_fsm_should_stop.
6073         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6074         (until_next_fsm::do_async_reply_reason): Rename from
6075         until_next_fsm_async_reply_reason.
6076         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6077         constructor.  Change type of breakpoint.
6078         (finish_command_fsm_ops): Remove.
6079         (new_finish_command_fsm): Remove.
6080         (finish_command_fsm::should_stop): Rename from
6081         finish_command_fsm_should_stop.
6082         (finish_command_fsm::clean_up): Rename from
6083         finish_command_fsm_clean_up.
6084         (finish_command_fsm::return_value): Rename from
6085         finish_command_fsm_return_value.
6086         (finish_command_fsm::do_async_reply_reason): Rename from
6087         finish_command_fsm_async_reply_reason.
6088         (finish_command): Update.
6089         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6090         Add constructor.
6091         (call_thread_fsm_ops): Remove.
6092         (call_thread_fsm::call_thread_fsm): Rename from
6093         new_call_thread_fsm.
6094         (call_thread_fsm::should_stop): Rename from
6095         call_thread_fsm_should_stop.
6096         (call_thread_fsm::should_notify_stop): Rename from
6097         call_thread_fsm_should_notify_stop.
6098         (run_inferior_call, call_function_by_hand_dummy): Update.
6099         * cli/cli-interp.c (should_print_stop_to_console): Update.
6100         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6101         Add constructor.  Change type of location_breakpoint,
6102         caller_breakpoint.
6103         (until_break_fsm_ops): Remove.
6104         (new_until_break_fsm): Remove.
6105         (until_break_fsm::should_stop): Rename from
6106         until_break_fsm_should_stop.
6107         (until_break_fsm::clean_up): Rename from
6108         until_break_fsm_clean_up.
6109         (until_break_fsm::do_async_reply_reason): Rename from
6110         until_break_fsm_async_reply_reason.
6111         (until_break_command): Update.
6112         * thread-fsm.c: Remove.
6113         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6114
6115 2019-02-07  Tom Tromey  <tom@tromey.com>
6116
6117         * yy-remap.h: Add include guard.
6118         * xtensa-tdep.h: Add include guard.
6119         * xcoffread.h: Rename include guard.
6120         * varobj-iter.h: Add include guard.
6121         * tui/tui.h: Rename include guard.
6122         * tui/tui-winsource.h: Rename include guard.
6123         * tui/tui-wingeneral.h: Rename include guard.
6124         * tui/tui-windata.h: Rename include guard.
6125         * tui/tui-win.h: Rename include guard.
6126         * tui/tui-stack.h: Rename include guard.
6127         * tui/tui-source.h: Rename include guard.
6128         * tui/tui-regs.h: Rename include guard.
6129         * tui/tui-out.h: Rename include guard.
6130         * tui/tui-layout.h: Rename include guard.
6131         * tui/tui-io.h: Rename include guard.
6132         * tui/tui-hooks.h: Rename include guard.
6133         * tui/tui-file.h: Rename include guard.
6134         * tui/tui-disasm.h: Rename include guard.
6135         * tui/tui-data.h: Rename include guard.
6136         * tui/tui-command.h: Rename include guard.
6137         * tic6x-tdep.h: Add include guard.
6138         * target/waitstatus.h: Rename include guard.
6139         * target/wait.h: Rename include guard.
6140         * target/target.h: Rename include guard.
6141         * target/resume.h: Rename include guard.
6142         * target-float.h: Rename include guard.
6143         * stabsread.h: Add include guard.
6144         * rs6000-tdep.h: Add include guard.
6145         * riscv-fbsd-tdep.h: Add include guard.
6146         * regformats/regdef.h: Rename include guard.
6147         * record.h: Rename include guard.
6148         * python/python.h: Rename include guard.
6149         * python/python-internal.h: Rename include guard.
6150         * python/py-stopevent.h: Rename include guard.
6151         * python/py-ref.h: Rename include guard.
6152         * python/py-record.h: Rename include guard.
6153         * python/py-record-full.h: Rename include guard.
6154         * python/py-record-btrace.h: Rename include guard.
6155         * python/py-instruction.h: Rename include guard.
6156         * python/py-events.h: Rename include guard.
6157         * python/py-event.h: Rename include guard.
6158         * procfs.h: Add include guard.
6159         * proc-utils.h: Add include guard.
6160         * p-lang.h: Add include guard.
6161         * or1k-tdep.h: Rename include guard.
6162         * observable.h: Rename include guard.
6163         * nto-tdep.h: Rename include guard.
6164         * nat/x86-linux.h: Rename include guard.
6165         * nat/x86-linux-dregs.h: Rename include guard.
6166         * nat/x86-gcc-cpuid.h: Add include guard.
6167         * nat/x86-dregs.h: Rename include guard.
6168         * nat/x86-cpuid.h: Rename include guard.
6169         * nat/ppc-linux.h: Rename include guard.
6170         * nat/mips-linux-watch.h: Rename include guard.
6171         * nat/linux-waitpid.h: Rename include guard.
6172         * nat/linux-ptrace.h: Rename include guard.
6173         * nat/linux-procfs.h: Rename include guard.
6174         * nat/linux-osdata.h: Rename include guard.
6175         * nat/linux-nat.h: Rename include guard.
6176         * nat/linux-namespaces.h: Rename include guard.
6177         * nat/linux-btrace.h: Rename include guard.
6178         * nat/glibc_thread_db.h: Rename include guard.
6179         * nat/gdb_thread_db.h: Rename include guard.
6180         * nat/gdb_ptrace.h: Rename include guard.
6181         * nat/fork-inferior.h: Rename include guard.
6182         * nat/amd64-linux-siginfo.h: Rename include guard.
6183         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6184         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6185         * nat/aarch64-linux.h: Rename include guard.
6186         * nat/aarch64-linux-hw-point.h: Rename include guard.
6187         * mn10300-tdep.h: Add include guard.
6188         * mips-linux-tdep.h: Add include guard.
6189         * mi/mi-parse.h: Rename include guard.
6190         * mi/mi-out.h: Rename include guard.
6191         * mi/mi-main.h: Rename include guard.
6192         * mi/mi-interp.h: Rename include guard.
6193         * mi/mi-getopt.h: Rename include guard.
6194         * mi/mi-console.h: Rename include guard.
6195         * mi/mi-common.h: Rename include guard.
6196         * mi/mi-cmds.h: Rename include guard.
6197         * mi/mi-cmd-break.h: Rename include guard.
6198         * m2-lang.h: Add include guard.
6199         * location.h: Rename include guard.
6200         * linux-record.h: Rename include guard.
6201         * linux-nat.h: Add include guard.
6202         * linux-fork.h: Add include guard.
6203         * i386-darwin-tdep.h: Rename include guard.
6204         * hppa-linux-offsets.h: Add include guard.
6205         * guile/guile.h: Rename include guard.
6206         * guile/guile-internal.h: Rename include guard.
6207         * gnu-nat.h: Rename include guard.
6208         * gdb-stabs.h: Rename include guard.
6209         * frv-tdep.h: Add include guard.
6210         * f-lang.h: Add include guard.
6211         * event-loop.h: Add include guard.
6212         * darwin-nat.h: Rename include guard.
6213         * cp-abi.h: Rename include guard.
6214         * config/sparc/nm-sol2.h: Rename include guard.
6215         * config/nm-nto.h: Rename include guard.
6216         * config/nm-linux.h: Add include guard.
6217         * config/i386/nm-i386gnu.h: Rename include guard.
6218         * config/djgpp/nl_types.h: Rename include guard.
6219         * config/djgpp/langinfo.h: Rename include guard.
6220         * compile/gcc-cp-plugin.h: Add include guard.
6221         * compile/gcc-c-plugin.h: Add include guard.
6222         * compile/compile.h: Rename include guard.
6223         * compile/compile-object-run.h: Rename include guard.
6224         * compile/compile-object-load.h: Rename include guard.
6225         * compile/compile-internal.h: Rename include guard.
6226         * compile/compile-cplus.h: Rename include guard.
6227         * compile/compile-c.h: Rename include guard.
6228         * common/xml-utils.h: Rename include guard.
6229         * common/x86-xstate.h: Rename include guard.
6230         * common/version.h: Rename include guard.
6231         * common/vec.h: Rename include guard.
6232         * common/tdesc.h: Rename include guard.
6233         * common/selftest.h: Rename include guard.
6234         * common/scoped_restore.h: Rename include guard.
6235         * common/scoped_mmap.h: Rename include guard.
6236         * common/scoped_fd.h: Rename include guard.
6237         * common/safe-iterator.h: Rename include guard.
6238         * common/run-time-clock.h: Rename include guard.
6239         * common/refcounted-object.h: Rename include guard.
6240         * common/queue.h: Rename include guard.
6241         * common/ptid.h: Rename include guard.
6242         * common/print-utils.h: Rename include guard.
6243         * common/preprocessor.h: Rename include guard.
6244         * common/pathstuff.h: Rename include guard.
6245         * common/observable.h: Rename include guard.
6246         * common/netstuff.h: Rename include guard.
6247         * common/job-control.h: Rename include guard.
6248         * common/host-defs.h: Rename include guard.
6249         * common/gdb_wait.h: Rename include guard.
6250         * common/gdb_vecs.h: Rename include guard.
6251         * common/gdb_unlinker.h: Rename include guard.
6252         * common/gdb_unique_ptr.h: Rename include guard.
6253         * common/gdb_tilde_expand.h: Rename include guard.
6254         * common/gdb_sys_time.h: Rename include guard.
6255         * common/gdb_string_view.h: Rename include guard.
6256         * common/gdb_splay_tree.h: Rename include guard.
6257         * common/gdb_setjmp.h: Rename include guard.
6258         * common/gdb_ref_ptr.h: Rename include guard.
6259         * common/gdb_optional.h: Rename include guard.
6260         * common/gdb_locale.h: Rename include guard.
6261         * common/gdb_assert.h: Rename include guard.
6262         * common/filtered-iterator.h: Rename include guard.
6263         * common/filestuff.h: Rename include guard.
6264         * common/fileio.h: Rename include guard.
6265         * common/environ.h: Rename include guard.
6266         * common/common-utils.h: Rename include guard.
6267         * common/common-types.h: Rename include guard.
6268         * common/common-regcache.h: Rename include guard.
6269         * common/common-inferior.h: Rename include guard.
6270         * common/common-gdbthread.h: Rename include guard.
6271         * common/common-exceptions.h: Rename include guard.
6272         * common/common-defs.h: Rename include guard.
6273         * common/common-debug.h: Rename include guard.
6274         * common/cleanups.h: Rename include guard.
6275         * common/buffer.h: Rename include guard.
6276         * common/btrace-common.h: Rename include guard.
6277         * common/break-common.h: Rename include guard.
6278         * cli/cli-utils.h: Rename include guard.
6279         * cli/cli-style.h: Rename include guard.
6280         * cli/cli-setshow.h: Rename include guard.
6281         * cli/cli-script.h: Rename include guard.
6282         * cli/cli-interp.h: Rename include guard.
6283         * cli/cli-decode.h: Rename include guard.
6284         * cli/cli-cmds.h: Rename include guard.
6285         * charset-list.h: Add include guard.
6286         * buildsym-legacy.h: Rename include guard.
6287         * bfin-tdep.h: Add include guard.
6288         * ax.h: Rename include guard.
6289         * arm-linux-tdep.h: Add include guard.
6290         * arm-fbsd-tdep.h: Add include guard.
6291         * arch/xtensa.h: Rename include guard.
6292         * arch/tic6x.h: Add include guard.
6293         * arch/i386.h: Add include guard.
6294         * arch/arm.h: Rename include guard.
6295         * arch/arm-linux.h: Rename include guard.
6296         * arch/arm-get-next-pcs.h: Rename include guard.
6297         * arch/amd64.h: Add include guard.
6298         * arch/aarch64-insn.h: Rename include guard.
6299         * arch-utils.h: Rename include guard.
6300         * annotate.h: Add include guard.
6301         * amd64-darwin-tdep.h: Rename include guard.
6302         * aarch64-linux-tdep.h: Add include guard.
6303         * aarch64-fbsd-tdep.h: Add include guard.
6304         * aarch32-linux-nat.h: Add include guard.
6305
6306 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6307
6308         * macrotab.c (macro_define_internal): New function that
6309         factorizes macro_define_object_internal and macro_define_function
6310         code.
6311         (macro_define_object_internal): Use macro_define_internal.
6312         (macro_define_function): Likewise.
6313
6314 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6315
6316         * macrocmd.c (extract_identifier): Return
6317         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6318         callers.
6319
6320 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6321
6322         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6323
6324 2019-02-05  Tom Tromey  <tom@tromey.com>
6325
6326         * target.c (target_stack::unpush): Move assertion earlier.
6327
6328 2019-01-30  Tom Tromey  <tom@tromey.com>
6329
6330         PR python/23615:
6331         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6332         (gdbpy_parse_and_eval): Likewise.
6333         * python/python-internal.h (gdbpy_allow_threads): New class.
6334
6335 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6336
6337         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6338         (aarch64_fbsd_fpregmap): Move earlier.
6339         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6340         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6341         instead of individual calls to trad_frame_set_reg_addr.
6342         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6343         earlier.
6344         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6345         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6346         instead of individual calls to trad_frame_set_reg_addr.
6347
6348 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6349
6350         * CONTRIBUTE: Replace contribution list with wiki link.
6351
6352 2019-01-25  Tom Tromey  <tom@tromey.com>
6353
6354         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6355
6356 2019-01-25  Tom Tromey  <tom@tromey.com>
6357
6358         * xtensa-linux-nat.c: Fix common/ includes.
6359         * xml-support.h: Fix common/ includes.
6360         * xml-support.c: Fix common/ includes.
6361         * x86-linux-nat.c: Fix common/ includes.
6362         * windows-nat.c: Fix common/ includes.
6363         * varobj.h: Fix common/ includes.
6364         * varobj.c: Fix common/ includes.
6365         * value.c: Fix common/ includes.
6366         * valops.c: Fix common/ includes.
6367         * utils.c: Fix common/ includes.
6368         * unittests/xml-utils-selftests.c: Fix common/ includes.
6369         * unittests/utils-selftests.c: Fix common/ includes.
6370         * unittests/unpack-selftests.c: Fix common/ includes.
6371         * unittests/tracepoint-selftests.c: Fix common/ includes.
6372         * unittests/style-selftests.c: Fix common/ includes.
6373         * unittests/string_view-selftests.c: Fix common/ includes.
6374         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6375         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6376         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6377         * unittests/rsp-low-selftests.c: Fix common/ includes.
6378         * unittests/parse-connection-spec-selftests.c: Fix common/
6379         includes.
6380         * unittests/optional-selftests.c: Fix common/ includes.
6381         * unittests/offset-type-selftests.c: Fix common/ includes.
6382         * unittests/observable-selftests.c: Fix common/ includes.
6383         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6384         * unittests/memrange-selftests.c: Fix common/ includes.
6385         * unittests/memory-map-selftests.c: Fix common/ includes.
6386         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6387         * unittests/function-view-selftests.c: Fix common/ includes.
6388         * unittests/environ-selftests.c: Fix common/ includes.
6389         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6390         * unittests/common-utils-selftests.c: Fix common/ includes.
6391         * unittests/cli-utils-selftests.c: Fix common/ includes.
6392         * unittests/array-view-selftests.c: Fix common/ includes.
6393         * ui-file.c: Fix common/ includes.
6394         * tui/tui-io.c: Fix common/ includes.
6395         * tracepoint.h: Fix common/ includes.
6396         * tracepoint.c: Fix common/ includes.
6397         * tracefile-tfile.c: Fix common/ includes.
6398         * top.h: Fix common/ includes.
6399         * top.c: Fix common/ includes.
6400         * thread.c: Fix common/ includes.
6401         * target/waitstatus.h: Fix common/ includes.
6402         * target/waitstatus.c: Fix common/ includes.
6403         * target.h: Fix common/ includes.
6404         * target.c: Fix common/ includes.
6405         * target-memory.c: Fix common/ includes.
6406         * target-descriptions.c: Fix common/ includes.
6407         * symtab.h: Fix common/ includes.
6408         * symfile.c: Fix common/ includes.
6409         * stap-probe.c: Fix common/ includes.
6410         * spu-linux-nat.c: Fix common/ includes.
6411         * sparc-nat.c: Fix common/ includes.
6412         * source.c: Fix common/ includes.
6413         * solib.c: Fix common/ includes.
6414         * solib-target.c: Fix common/ includes.
6415         * ser-unix.c: Fix common/ includes.
6416         * ser-tcp.c: Fix common/ includes.
6417         * ser-pipe.c: Fix common/ includes.
6418         * ser-base.c: Fix common/ includes.
6419         * selftest-arch.c: Fix common/ includes.
6420         * s12z-tdep.c: Fix common/ includes.
6421         * rust-exp.y: Fix common/ includes.
6422         * rs6000-aix-tdep.c: Fix common/ includes.
6423         * riscv-tdep.c: Fix common/ includes.
6424         * remote.c: Fix common/ includes.
6425         * remote-notif.h: Fix common/ includes.
6426         * remote-fileio.h: Fix common/ includes.
6427         * remote-fileio.c: Fix common/ includes.
6428         * regcache.h: Fix common/ includes.
6429         * regcache.c: Fix common/ includes.
6430         * record-btrace.c: Fix common/ includes.
6431         * python/python.c: Fix common/ includes.
6432         * python/py-type.c: Fix common/ includes.
6433         * python/py-inferior.c: Fix common/ includes.
6434         * progspace.h: Fix common/ includes.
6435         * producer.c: Fix common/ includes.
6436         * procfs.c: Fix common/ includes.
6437         * proc-api.c: Fix common/ includes.
6438         * printcmd.c: Fix common/ includes.
6439         * ppc-linux-nat.c: Fix common/ includes.
6440         * parser-defs.h: Fix common/ includes.
6441         * osdata.c: Fix common/ includes.
6442         * obsd-nat.c: Fix common/ includes.
6443         * nat/x86-linux.c: Fix common/ includes.
6444         * nat/x86-linux-dregs.c: Fix common/ includes.
6445         * nat/x86-dregs.h: Fix common/ includes.
6446         * nat/x86-dregs.c: Fix common/ includes.
6447         * nat/ppc-linux.c: Fix common/ includes.
6448         * nat/mips-linux-watch.h: Fix common/ includes.
6449         * nat/mips-linux-watch.c: Fix common/ includes.
6450         * nat/linux-waitpid.c: Fix common/ includes.
6451         * nat/linux-ptrace.h: Fix common/ includes.
6452         * nat/linux-ptrace.c: Fix common/ includes.
6453         * nat/linux-procfs.c: Fix common/ includes.
6454         * nat/linux-personality.c: Fix common/ includes.
6455         * nat/linux-osdata.c: Fix common/ includes.
6456         * nat/linux-namespaces.c: Fix common/ includes.
6457         * nat/linux-btrace.h: Fix common/ includes.
6458         * nat/linux-btrace.c: Fix common/ includes.
6459         * nat/fork-inferior.c: Fix common/ includes.
6460         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6461         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6462         * nat/aarch64-linux.c: Fix common/ includes.
6463         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6464         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6465         * namespace.h: Fix common/ includes.
6466         * mips-linux-tdep.c: Fix common/ includes.
6467         * minsyms.c: Fix common/ includes.
6468         * mi/mi-parse.h: Fix common/ includes.
6469         * mi/mi-main.c: Fix common/ includes.
6470         * mi/mi-cmd-env.c: Fix common/ includes.
6471         * memrange.h: Fix common/ includes.
6472         * memattr.c: Fix common/ includes.
6473         * maint.h: Fix common/ includes.
6474         * maint.c: Fix common/ includes.
6475         * main.c: Fix common/ includes.
6476         * machoread.c: Fix common/ includes.
6477         * location.c: Fix common/ includes.
6478         * linux-thread-db.c: Fix common/ includes.
6479         * linux-nat.c: Fix common/ includes.
6480         * linux-fork.c: Fix common/ includes.
6481         * inline-frame.c: Fix common/ includes.
6482         * infrun.c: Fix common/ includes.
6483         * inflow.c: Fix common/ includes.
6484         * inferior.h: Fix common/ includes.
6485         * inferior.c: Fix common/ includes.
6486         * infcmd.c: Fix common/ includes.
6487         * inf-ptrace.c: Fix common/ includes.
6488         * inf-child.c: Fix common/ includes.
6489         * ia64-linux-nat.c: Fix common/ includes.
6490         * i387-tdep.c: Fix common/ includes.
6491         * i386-tdep.c: Fix common/ includes.
6492         * i386-linux-tdep.c: Fix common/ includes.
6493         * i386-linux-nat.c: Fix common/ includes.
6494         * i386-go32-tdep.c: Fix common/ includes.
6495         * i386-fbsd-tdep.c: Fix common/ includes.
6496         * i386-fbsd-nat.c: Fix common/ includes.
6497         * guile/scm-type.c: Fix common/ includes.
6498         * guile/guile.c: Fix common/ includes.
6499         * go32-nat.c: Fix common/ includes.
6500         * gnu-nat.c: Fix common/ includes.
6501         * gdbthread.h: Fix common/ includes.
6502         * gdbarch-selftests.c: Fix common/ includes.
6503         * gdb_usleep.c: Fix common/ includes.
6504         * gdb_select.h: Fix common/ includes.
6505         * gdb_bfd.c: Fix common/ includes.
6506         * gcore.c: Fix common/ includes.
6507         * fork-child.c: Fix common/ includes.
6508         * findvar.c: Fix common/ includes.
6509         * fbsd-nat.c: Fix common/ includes.
6510         * event-top.c: Fix common/ includes.
6511         * event-loop.c: Fix common/ includes.
6512         * dwarf2read.c: Fix common/ includes.
6513         * dwarf2loc.c: Fix common/ includes.
6514         * dwarf2-frame.c: Fix common/ includes.
6515         * dwarf-index-cache.c: Fix common/ includes.
6516         * dtrace-probe.c: Fix common/ includes.
6517         * disasm-selftests.c: Fix common/ includes.
6518         * defs.h: Fix common/ includes.
6519         * csky-tdep.c: Fix common/ includes.
6520         * cp-valprint.c: Fix common/ includes.
6521         * cp-support.h: Fix common/ includes.
6522         * cp-support.c: Fix common/ includes.
6523         * corelow.c: Fix common/ includes.
6524         * completer.h: Fix common/ includes.
6525         * completer.c: Fix common/ includes.
6526         * compile/compile.c: Fix common/ includes.
6527         * compile/compile-loc2c.c: Fix common/ includes.
6528         * compile/compile-cplus-types.c: Fix common/ includes.
6529         * compile/compile-cplus-symbols.c: Fix common/ includes.
6530         * command.h: Fix common/ includes.
6531         * cli/cli-dump.c: Fix common/ includes.
6532         * cli/cli-cmds.c: Fix common/ includes.
6533         * charset.c: Fix common/ includes.
6534         * build-id.c: Fix common/ includes.
6535         * btrace.h: Fix common/ includes.
6536         * btrace.c: Fix common/ includes.
6537         * breakpoint.h: Fix common/ includes.
6538         * breakpoint.c: Fix common/ includes.
6539         * ax.h:
6540         (enum agent_op): Fix common/ includes.
6541         * ax-general.c (struct aop_map): Fix common/ includes.
6542         * ax-gdb.c: Fix common/ includes.
6543         * auxv.c: Fix common/ includes.
6544         * auto-load.c: Fix common/ includes.
6545         * arm-tdep.c: Fix common/ includes.
6546         * arch/riscv.c: Fix common/ includes.
6547         * arch/ppc-linux-common.c: Fix common/ includes.
6548         * arch/i386.c: Fix common/ includes.
6549         * arch/arm.c: Fix common/ includes.
6550         * arch/arm-linux.c: Fix common/ includes.
6551         * arch/arm-get-next-pcs.c: Fix common/ includes.
6552         * arch/amd64.c: Fix common/ includes.
6553         * arch/aarch64.c: Fix common/ includes.
6554         * arch/aarch64-insn.c: Fix common/ includes.
6555         * arch-utils.c: Fix common/ includes.
6556         * amd64-windows-tdep.c: Fix common/ includes.
6557         * amd64-tdep.c: Fix common/ includes.
6558         * amd64-sol2-tdep.c: Fix common/ includes.
6559         * amd64-obsd-tdep.c: Fix common/ includes.
6560         * amd64-nbsd-tdep.c: Fix common/ includes.
6561         * amd64-linux-tdep.c: Fix common/ includes.
6562         * amd64-linux-nat.c: Fix common/ includes.
6563         * amd64-fbsd-tdep.c: Fix common/ includes.
6564         * amd64-fbsd-nat.c: Fix common/ includes.
6565         * amd64-dicos-tdep.c: Fix common/ includes.
6566         * amd64-darwin-tdep.c: Fix common/ includes.
6567         * agent.c: Fix common/ includes.
6568         * ada-lang.h: Fix common/ includes.
6569         * ada-lang.c: Fix common/ includes.
6570         * aarch64-tdep.c: Fix common/ includes.
6571
6572 2019-01-25  Tom Tromey  <tom@tromey.com>
6573
6574         * common/create-version.sh: Use common/version.h.
6575
6576 2019-01-24  Pedro Alves  <palves@redhat.com>
6577
6578         * infrun.c (signal_stop, signal_print, signal_program)
6579         (signal_catch, signal_pass): Now arrays instead of pointers.
6580         (update_signals_program_target, do_target_resume)
6581         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6582         * linux-nat.c (linux_nat_target::pass_signals)
6583         (linux_nat_target::create_inferior, linux_nat_target::attach):
6584         Adjust.
6585         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6586         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6587         * procfs.c (procfs_target::pass_signals): Adjust.
6588         * record-full.c (record_full_target::resume): Adjust.
6589         * remote.c (remote_target::pass_signals)
6590         (remote_target::program_signals): Adjust.
6591         * target-debug.h (target_debug_print_signals): Now takes a
6592         gdb::array_view as parameter.  Adjust.
6593         * target.h (target_ops) <pass_signals, program_signals>: Replace
6594         pointer and length parameters with gdb::array_view.
6595         (target_pass_signals, target_program_signals): Likewise.
6596         * target-delegates.c: Regenerate.
6597
6598 2019-01-24  Pedro Alves  <palves@redhat.com>
6599
6600         * common/forward-scope-exit.h
6601         (forward_scope_exit::forward_scope_exit): Pass arguments to
6602         m_bind_function directly, instead of creating a std::bind and
6603         copying that.
6604
6605 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6606
6607         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6608         for static members.
6609         (pass_in_v_vfp_candidate): Likewise.
6610
6611 2019-01-23  Tom Tromey  <tom@tromey.com>
6612             Pedro Alves  <palves@redhat.com>
6613
6614         * regcache.c (class regcache_invalidator): Remove.
6615         (regcache::raw_write): Use make_scope_exit.
6616
6617 2019-01-23  Tom Tromey  <tom@tromey.com>
6618
6619         * ui-out.h (class ui_out_emit_type): Update comment.
6620
6621 2019-01-23  Tom Tromey  <tom@tromey.com>
6622
6623         * infrun.c (fetch_inferior_event): Update comment.
6624
6625 2019-01-23  Tom Tromey  <tom@tromey.com>
6626             Pedro Alves  <palves@redhat.com>
6627
6628         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6629         parameter.
6630         (fetch_inferior_event): Use SCOPE_EXIT.
6631
6632
6633 2019-01-23  Tom Tromey  <tom@tromey.com>
6634             Pedro Alves  <palves@redhat.com>
6635
6636         * infrun.c (disable_thread_events): Delete.
6637         (stop_all_threads): Use SCOPE_EXIT.
6638
6639 2019-01-23  Tom Tromey  <tom@tromey.com>
6640             Pedro Alves  <palves@redhat.com>
6641
6642         * symfile.c: Include forward-scope-exit.h.
6643         (clear_symtab_users_cleanup): Replace forward declaration with
6644         a FORWARD_SCOPE_EXIT.
6645         (syms_from_objfile_1): Use the forward_scope_exit and
6646         gdb::optional instead of cleanup_function.
6647         (reread_symbols): Use the forward_scope_exit instead of
6648         cleanup_function.
6649         (clear_symtab_users_cleanup): Remove function.
6650
6651 2019-01-23  Tom Tromey  <tom@tromey.com>
6652             Pedro Alves  <palves@redhat.com>
6653
6654         * linux-nat.c: Include scope-exit.h.
6655         (cleanup_target_stop): Remove.
6656         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6657         SCOPE_EXIT.
6658
6659 2019-01-23  Tom Tromey  <tom@tromey.com>
6660             Pedro Alves  <palves@redhat.com>
6661
6662         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6663         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6664
6665 2019-01-23  Tom Tromey  <tom@tromey.com>
6666             Andrew Burgess  <andrew.burgess@embecosm.com>
6667             Pedro Alves  <palves@redhat.com>
6668
6669         * infrun.c (fetch_inferior_event): Use scope_exit.
6670         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6671         * top.c (execute_command): Use scope_exit.
6672         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6673         * utils.c (do_bpstat_clear_actions_cleanup)
6674         (make_bpstat_clear_actions_cleanup): Remove.
6675
6676 2019-01-23  Tom Tromey  <tom@tromey.com>
6677             Pedro Alves  <palves@redhat.com>
6678
6679         * infrun.c: Include "common/scope-exit.h"
6680         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6681         (wait_for_inferior): Use SCOPE_EXIT.
6682         (fetch_inferior_event): Use scope_exit.
6683
6684 2019-01-23  Tom Tromey  <tom@tromey.com>
6685             Pedro Alves  <palves@redhat.com>
6686
6687         * breakpoint.c (create_breakpoint): Remove cleanup.
6688
6689 2019-01-23  Tom Tromey  <tom@tromey.com>
6690             Andrew Burgess  <andrew.burgess@embecosm.com>
6691             Pedro Alves  <palves@redhat.com>
6692
6693 2019-01-23  Pedro Alves  <palves@redhat.com>
6694
6695         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6696
6697 2019-01-23  Pedro Alves  <palves@redhat.com>
6698             Andrew Burgess  <andrew.burgess@embecosm.com>
6699
6700         * gdbthread.h: Include "common/forward-scope-exit.h".
6701         (scoped_finish_thread_state): Redefine custom class in terms of
6702         forward_scope_exit.
6703
6704 2019-01-23  Pedro Alves  <palves@redhat.com>
6705             Andrew Burgess  <andrew.burgess@embecosm.com>
6706
6707         * common/forward-scope-exit.h: New file.
6708
6709 2019-01-23  Pedro Alves  <palves@redhat.com>
6710             Andrew Burgess  <andrew.burgess@embecosm.com>
6711             Tom Tromey  <tom@tromey.com>
6712
6713         * common/scope-exit.h: New file.
6714
6715 2019-01-23  Pedro Alves  <palves@redhat.com>
6716
6717         * common/preprocessor.h (ESC): Rename to ...
6718         (ESC_PARENS): ... this.
6719         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6720         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6721
6722 2019-01-23  Tom Tromey  <tom@tromey.com>
6723
6724         * language.h (class scoped_switch_to_sym_language_if_auto):
6725         Initialize m_lang in both cases.
6726
6727 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6728
6729         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6730         with XCNEW.
6731
6732 2019-01-22  Tom Tromey  <tom@tromey.com>
6733
6734         * corelow.c: Do not include sys/file.h.
6735
6736 2019-01-22  Tom Tromey  <tom@tromey.com>
6737
6738         * tui/tui-wingeneral.h: Include gdb_curses.h.
6739
6740 2019-01-22  Tom Tromey  <tom@tromey.com>
6741
6742         * source-cache.h (class source_cache) <get_source_lines,
6743         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6744
6745 2019-01-22  Tom Tromey  <tom@tromey.com>
6746
6747         * remote-fileio.h (struct remote_target): Declare.
6748
6749 2019-01-22  Tom Tromey  <tom@tromey.com>
6750
6751         * python/py-arch.c: Do not include py-ref.h.
6752         * python/py-bpevent.c: Do not include py-ref.h.
6753         * python/py-cmd.c: Do not include py-ref.h.
6754         * python/py-continueevent.c: Do not include py-ref.h.
6755         * python/py-event.h: Do not include py-ref.h.
6756         * python/py-evtregistry.c: Do not include py-ref.h.
6757         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6758         * python/py-frame.c: Do not include py-ref.h.
6759         * python/py-framefilter.c: Do not include py-ref.h.
6760         * python/py-function.c: Do not include py-ref.h.
6761         * python/py-infevents.c: Do not include py-ref.h.
6762         * python/py-linetable.c: Do not include py-ref.h.
6763         * python/py-objfile.c: Do not include py-ref.h.
6764         * python/py-param.c: Do not include py-ref.h.
6765         * python/py-prettyprint.c: Do not include py-ref.h.
6766         * python/py-progspace.c: Do not include py-ref.h.
6767         * python/py-symbol.c: Do not include py-ref.h.
6768         * python/py-symtab.c: Do not include py-ref.h.
6769         * python/py-type.c: Do not include py-ref.h.
6770         * python/py-unwind.c: Do not include py-ref.h.
6771         * python/py-utils.c: Do not include py-ref.h.
6772         * python/py-value.c: Do not include py-ref.h.
6773         * python/py-varobj.c: Do not include py-ref.h.
6774         * python/py-xmethods.c: Do not include py-ref.h.
6775         * python/python.c: Do not include py-ref.h.
6776         * varobj.c: Do not include py-ref.h.
6777
6778 2019-01-22  Tom Tromey  <tom@tromey.com>
6779
6780         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6781         keyword for bcache.
6782
6783 2019-01-22  Tom Tromey  <tom@tromey.com>
6784
6785         * compile/compile-cplus-types.c: Remove a comment by #include.
6786
6787 2019-01-22  Tom Tromey  <tom@tromey.com>
6788
6789         * compile/gcc-c-plugin.h: Include compile-internal.h.
6790
6791 2019-01-22  Tom Tromey  <tom@tromey.com>
6792
6793         * stabsread.c (EXTERN): Do not define.
6794         (symnum, next_symbol_text_func, processing_gcc_compilation)
6795         (within_function, global_sym_chain, global_stabs)
6796         (previous_stab_code, this_object_header_files)
6797         (n_this_object_header_files)
6798         (n_allocated_this_object_header_files): Define.
6799         * stabsread.h (EXTERN): Never define.  Use "extern".
6800
6801 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6802
6803         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6804         history_value.
6805
6806 2019-01-21  Tom Tromey  <tom@tromey.com>
6807
6808         * ui-out.c: Fix includes.
6809         * tui/tui-source.c: Fix includes.
6810         * target.c: Fix includes.
6811         * remote.c: Fix includes.
6812         * regcache.c: Fix includes.
6813         * python/py-block.c: Fix includes.
6814         * printcmd.c: Fix includes.
6815         * or1k-tdep.c: Fix includes.
6816         * mi/mi-main.c: Fix includes.
6817         * m32r-tdep.c: Fix includes.
6818         * csky-tdep.c: Fix includes.
6819         * compile/compile-cplus-types.c: Fix includes.
6820         * cli/cli-interp.c: Fix includes.
6821
6822 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6823
6824         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6825         for padding.
6826
6827 2019-01-16  Tom Tromey  <tom@tromey.com>
6828
6829         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6830         earlier.
6831         (struct objfile) <msymbols_range>: Move from top level.
6832         <msymbols>: New method.
6833         (class objfile_msymbols): Remove.
6834         * symtab.c (default_collect_symbol_completion_matches_break_on):
6835         Update.
6836         * symmisc.c (dump_msymbols): Update.
6837         * stabsread.c (scan_file_globals): Update.
6838         * objc-lang.c (info_selectors_command, info_classes_command)
6839         (find_methods): Update.
6840         * minsyms.c (find_solib_trampoline_target): Update.
6841         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6842         * coffread.c (coff_symfile_read): Update.
6843         * ada-lang.c (ada_lookup_simple_minsym)
6844         (ada_collect_symbol_completion_matches): Update.
6845
6846 2019-01-16  Tom Tromey  <tom@tromey.com>
6847
6848         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6849         type.  Remove no-argument constructor.
6850         <iterator::operator++>: Simplify.
6851         <begin>: Update.
6852         <end>: Use minimal_symbol_count.
6853
6854 2019-01-16  Tom Tromey  <tom@tromey.com>
6855
6856         * objfiles.h (struct objfile) <psymtabs>: New method.
6857         (class objfile_psymtabs): Remove.
6858         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6859         typedef.
6860         <range>: New method.
6861         (require_partial_symbols): Change return type.
6862         * psymtab.c (require_partial_symbols)
6863         (psym_expand_symtabs_matching): Update.
6864         * mdebugread.c (parse_partial_symbols): Update.
6865         * dbxread.c (dbx_end_psymtab): Update.
6866
6867 2019-01-15  Tom Tromey  <tom@tromey.com>
6868
6869         * symtab.c (lookup_objfile_from_block)
6870         (lookup_symbol_in_objfile_symtabs)
6871         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6872         (find_line_symtab, info_sources_command)
6873         (default_collect_symbol_completion_matches_break_on)
6874         (make_source_files_completion_list): Update.
6875         * symmisc.c (print_objfile_statistics, dump_objfile)
6876         (maintenance_print_symbols, maintenance_info_symtabs)
6877         (maintenance_check_symtabs, maintenance_info_line_tables):
6878         Update.
6879         * source.c (select_source_symtab)
6880         (forget_cached_source_info_for_objfile): Update.
6881         * objfiles.h (class objfile_compunits): Remove.
6882         (struct objfile) <compunits_range>: New typedef.
6883         (compunits): New method.
6884         * objfiles.c (objfile_relocate1): Update.
6885         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6886         * maint.c (count_symtabs_and_blocks): Update.
6887         * linespec.c (iterate_over_all_matching_symtabs): Update.
6888         * cp-support.c (add_symbol_overload_list_qualified): Update.
6889         * coffread.c (coff_symtab_read): Update.
6890         * ada-lang.c (add_nonlocal_symbols)
6891         (ada_collect_symbol_completion_matches)
6892         (ada_add_global_exceptions): Update.
6893
6894 2019-01-15  Tom Tromey  <tom@tromey.com>
6895
6896         * progspace.h (program_space) <objfiles_safe_range>: New
6897         typedef.
6898         <objfiles_safe>: New method.
6899         * objfiles.h (class all_objfiles_safe): Remove.
6900         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6901         * jit.c (jit_inferior_exit_hook): Update.
6902
6903 2019-01-17  Tom Tromey  <tom@tromey.com>
6904
6905         * progspace.h (program_space) <objfiles_range>: New typedef.
6906         <objfiles>: New method.
6907         <objfiles_head>: Rename from objfiles.
6908         (object_files): Update.
6909         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6910         * guile/scm-pretty-print.c
6911         (ppscm_find_pretty_printer_from_objfiles): Update.
6912         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6913         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6914         Update.
6915         * python/py-progspace.c (pspy_get_objfiles): Update.
6916         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6917         Update.
6918         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6919         (objfpy_lookup_objfile_by_build_id): Update.
6920         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6921         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6922         Update.
6923         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6924         (expand_symtab_containing_pc, lookup_objfile_from_block)
6925         (lookup_static_symbol, basic_lookup_transparent_type)
6926         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6927         (find_line_symtab, info_sources_command)
6928         (default_collect_symbol_completion_matches_break_on)
6929         (make_source_files_completion_list, find_main_name): Update.
6930         * symmisc.c (print_symbol_bcache_statistics)
6931         (print_objfile_statistics, maintenance_print_symbols)
6932         (maintenance_print_msymbols, maintenance_print_objfiles)
6933         (maintenance_info_symtabs, maintenance_check_symtabs)
6934         (maintenance_expand_symtabs, maintenance_info_line_tables):
6935         Update.
6936         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6937         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6938         (map_overlay_command, unmap_overlay_command)
6939         (simple_overlay_update, expand_symtabs_matching)
6940         (map_symbol_filenames): Update.
6941         * symfile-debug.c (set_debug_symfile): Update.
6942         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6943         Update.
6944         * source.c (select_source_symtab, forget_cached_source_info):
6945         Update.
6946         * solib.c (solib_read_symbols): Update.
6947         * solib-spu.c (append_ocl_sos): Update.
6948         * psymtab.c (maintenance_print_psymbols)
6949         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6950         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6951         * printcmd.c (info_symbol_command): Update.
6952         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6953         Update.
6954         * objfiles.h (class all_objfiles): Remove.
6955         * objfiles.c (have_partial_symbols, have_full_symbols)
6956         (have_minimal_symbols, qsort_cmp, update_section_map)
6957         (shared_objfile_contains_address_p)
6958         (default_iterate_over_objfiles_in_search_order): Update.
6959         * objc-lang.c (info_selectors_command, info_classes_command)
6960         (find_methods): Update.
6961         * minsyms.c (find_solib_trampoline_target): Update.
6962         * maint.c (maintenance_info_sections)
6963         (maintenance_translate_address, count_symtabs_and_blocks):
6964         Update.
6965         * main.c (captured_main_1): Update.
6966         * linux-thread-db.c (try_thread_db_load_from_pdir)
6967         (has_libpthread): Update.
6968         * linespec.c (iterate_over_all_matching_symtabs)
6969         (search_minsyms_for_name): Update.
6970         * jit.c (jit_find_objf_with_entry_addr): Update.
6971         * hppa-tdep.c (find_unwind_entry)
6972         (hppa_lookup_stub_minimal_symbol): Update.
6973         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6974         Update.
6975         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6976         (elf_gnu_ifunc_resolve_by_got): Update.
6977         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6978         * dwarf-index-write.c (save_gdb_index_command): Update.
6979         * cp-support.c (add_symbol_overload_list_qualified): Update.
6980         * breakpoint.c (create_overlay_event_breakpoint)
6981         (create_longjmp_master_breakpoint)
6982         (create_std_terminate_master_breakpoint)
6983         (create_exception_master_breakpoint): Update.
6984         * blockframe.c (find_pc_partial_function): Update.
6985         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6986         (ada_collect_symbol_completion_matches)
6987         (ada_add_global_exceptions): Update.
6988
6989 2019-01-17  Tom Tromey  <tom@tromey.com>
6990
6991         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6992         declare VEC.
6993         (solib_target_parse_libraries): Change return type.
6994         (library_list_start_segment, library_list_start_section)
6995         (library_list_end_library, library_list_start_library); Update.
6996         (solib_target_free_library_list): Remove.
6997         (solib_target_parse_libraries): Remove cleanup.  Change return
6998         type.
6999         (solib_target_current_sos): Update.
7000
7001 2019-01-17  Tom Tromey  <tromey@bapiya>
7002
7003         * valprint.c: Replace "the the" with "the".
7004         * symtab.c: Replace "the the" with "the".
7005         * solib.c: Replace "the the" with "the".
7006         * solib-dsbt.c: Replace "the the" with "the".
7007         * linespec.c: Replace "the the" with "the".
7008         * dwarf2loc.h: Replace "the the" with "the".
7009         * amd64-windows-tdep.c: Replace "the the" with "the".
7010         * aarch64-tdep.c: Replace "the the" with "the".
7011
7012 2019-01-16  Keith Seitz  <keiths@redhat.com>
7013
7014         PR gdb/23773
7015         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7016         <builder>: Rename to ..
7017         <m_builder>: ... this and make private.
7018         (dwarf2_cu::get_builder): New method.  Change all users of
7019         `builder' to use this method.
7020         (dwarf2_start_symtab): Move to ...
7021         (dwarf2_cu::start_symtab): ... here.  Update all callers
7022         (setup_type_unit_groups): Move to ...
7023         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7024         callers.
7025         (dwarf2_cu::reset_builder): New method.
7026         (process_full_compunit, process_full_type_unit): Use
7027         dwarf2_cu::reset_builder.
7028         (follow_die_offset): Record the ancestor CU if it is different
7029         from the followed DIE's CU.
7030         (follow_die_sig_1): Likewise.
7031
7032 2019-01-15  Tom Tromey  <tom@tromey.com>
7033
7034         * remote.c (class remote_state) <buf>: Now a char_vector.
7035         <buf_size>: Remove.
7036         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7037         parameter.
7038         (remote_target::getpkt_or_notif_sane_1)
7039         (remote_target::getpkt_sane)
7040         (remote_target::getpkt_or_notif_sane): Likewise.
7041         (class remote_target) <putpkt>: New overload.
7042         (remote_target::read_frame): Change type of "buf_p".  Remove
7043         sizeof_p parameter.
7044         (packet_ok): New overload.
7045         (packet_check_result): New overload.
7046         Update all uses.
7047
7048 2019-01-14  Tom Tromey  <tom@tromey.com>
7049
7050         * remote-notif.c (handle_notification, remote_notif_ack)
7051         (remote_notif_parse): Make "buf" const.
7052         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7053         const.
7054         (remote_notif_parse, remote_notif_ack, handle_notification):
7055         Likewise.
7056         * remote.c (remote_notif_stop_parse): Make "buf" const.
7057         (remote_target::remote_parse_stop_reply): Make "buf" const.
7058         (remote_notif_stop_ack): Make "buf" const.
7059
7060 2019-01-14  Tom Tromey  <tom@tromey.com>
7061
7062         * remote.c (remote_console_output): Make parameter const.
7063
7064 2019-01-14  Tom Tromey  <tom@tromey.com>
7065
7066         * target-debug.h (target_debug_print_signals): Constify.
7067         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7068         * procfs.c (procfs_target::pass_signals): Update.
7069         * linux-nat.c (linux_nat_target::pass_signals): Update.
7070         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7071         * target-delegates.c: Rebuild.
7072         * remote.c (remote_target::program_signals): Update.
7073         (remote_target::pass_signals): Update.
7074         * target.c (target_pass_signals): Constify argument.
7075         (target_program_signals): Likewise.
7076         * target.h (struct target_ops) <pass_signals, program_signals>:
7077         Constify argument.
7078         (target_pass_signals, target_program_signals): Constify argument.
7079
7080 2019-01-14  Tom Tromey  <tom@tromey.com>
7081
7082         PR tui/28819:
7083         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7084
7085 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7086
7087         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7088         field.
7089         * rs6000-tdep.c: Include reggroups.h.
7090         (IS_V_ALIAS_PSEUDOREG): Define.
7091         (rs6000_register_name): Return names for the "vX" aliases.
7092         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7093         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7094         aliases.  Call default_register_reggroup_p for all other
7095         pseudo-registers.
7096         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7097         New functions.
7098         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7099         Handle "vX" aliases.
7100         (v_alias_pseudo_register_collect): New function.
7101         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7102         (rs6000_gdbarch_init): Initialize "vX" aliases as
7103         pseudo-registers.  Restore registration of
7104         rs6000_pseudo_register_reggroup_p with
7105         set_tdesc_pseudo_register_reggroup_p.
7106
7107 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7108
7109         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7110         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7111         set_gdbarch_num_pseudo_regs.
7112
7113 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7114
7115         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7116         Remove arg prefixname, add do_set and do_show.
7117         Add member functions set_list and show_list.
7118         * cli/cli-style.c (class cli_style_option): Update accordingly.
7119         (style_set_list): Move to file scope.
7120         (style_show_list): Likewise.
7121         (set_style): Call help_list.
7122         (show_style): Call cmd_show_list.
7123         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7124         Update to use the new macro.
7125
7126 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7127
7128         * ada-lang.c (_initialize_ada_language): Expand the help text
7129         for the "catch exception" command.
7130
7131 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7132
7133         * symtab.c (matching_obj_sections): Initialize obj,
7134         declare it closer to its usage.
7135
7136 2019-01-10  Tom Tromey  <tom@tromey.com>
7137
7138         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7139         (basic_inf_threads_range): Remove.
7140         (inf_threads_range, inf_non_exited_threads_range)
7141         (safe_inf_threads_range): Use next_adapter.
7142
7143 2019-01-10  Keith Seitz  <keiths@redhat.com>
7144
7145         PR gdb/23712
7146         PR symtab/23010
7147         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7148         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7149
7150 2019-01-10  Keith Seitz  <keiths@redhat.com>
7151
7152         PR gdb/23712
7153         PR symtab/23010
7154         * dictionary.c (pending_to_vector): Remove.
7155         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7156         Remove _1 suffix, replacing functions of the same name.  Update
7157         all callers.
7158         (dict_create_hashed, dict_create_hashed_expandable)
7159         (dict_create_linear, dict_create_linear_expandable, dict_free)
7160         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7161         Make functions static.
7162
7163 2019-01-10  Keith Seitz  <keiths@redhat.com>
7164
7165         PR gdb/23712
7166         PR symtab/23010
7167         * dictionary.h (struct dictionary): Replace declaration with
7168         multidictionary.
7169         (dict_create_hashed, dict_create_hashed_expandable)
7170         (dict_create_linear, dict_create_linear_expandable)
7171         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7172         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7173         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7174         taking multidictionary argument.
7175         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7176         * block.h (struct block) <dict>: Change to multidictionary
7177         and rename `multidict'.
7178         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7179         symmisc.c: Update all dictionary references to multidictionary.
7180
7181 2019-01-10  Keith Seitz  <keiths@redhat.com>
7182
7183         PR gdb/23712
7184         PR symtab/23010
7185         * dictionary.c: Include unordered_map.
7186         (pending_to_vector): New function.
7187         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7188         Rewrite the non-"_1" functions to take vector instead
7189         of linked list.
7190         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7191         "new" _1 versions of the same name.
7192         (multidictionary): Define.
7193         (std::hash<enum language): New definition.
7194         (collate_pending_symbols_by_language, mdict_create_hashed)
7195         (mdict_create_hashed_expandable, mdict_create_linear)
7196         (mdict_create_linear_expandable, mdict_free)
7197         (find_language_dictionary, create_new_language_dictionary)
7198         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7199         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7200         (mdict_size, mdict_empty): New functions.
7201         * dictionary.h (mdict_iterator): Define.
7202
7203 2019-01-10  Pedro Alves  <palves@redhat.com>
7204
7205         * breakpoint.c (read_uploaded_action)
7206         (create_tracepoint_from_upload): Adjust to use
7207         gdb::unique_xmalloc_ptr.
7208         * ctf.c (ctf_write_uploaded_tp):
7209         (SET_ARRAY_FIELD): Use emplace_back.
7210         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7211         * tracefile-tfile.c (tfile_write_uploaded_tp):
7212         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7213         gdb::unique_xmalloc_ptr.
7214         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7215         at_string, cond_string, cmd_strings>: Replace char pointers
7216         with gdb::unique_xmalloc_ptr.
7217
7218 2019-01-10  Pedro Alves  <palves@redhat.com>
7219
7220         * solib-target.c (library_list_start_library): Don't xstrdup name.
7221
7222 2019-01-10  Pedro Alves  <palves@redhat.com>
7223
7224         * mdebugread.c (parse_partial_symbols): Use
7225         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7226
7227 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7228
7229         * linux-fork.c (scoped_switch_fork_info)
7230         <~scoped_switch_fork_info>: Fix incorrect variable name.
7231
7232 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7233
7234         * linux-fork.c (scoped_switch_fork_info)
7235         <scoped_switch_fork_info>: Make explicit.
7236         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7237
7238 2019-01-10  Tom Tromey  <tom@tromey.com>
7239
7240         * objfiles.h (objfile::reset_psymtabs): Update.
7241         * objfiles.c (objfile::objfile): Update.
7242         * psymtab.h (psymtab_storage::obstack): Update.
7243         (psymtab_storage::m_obstack): Use gdb::optional.
7244         (class psymtab_storage): Update comment.  Remove objfile
7245         parameter.
7246         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7247
7248 2019-01-10  Tom Tromey  <tom@tromey.com>
7249
7250         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7251         <free_psymtabs>: Now private.
7252         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7253         (allocate_psymtab): Use new method.
7254
7255 2019-01-10  Tom Tromey  <tom@tromey.com>
7256
7257         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7258         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7259         * mdebugread.c (parse_partial_symbols): Use
7260         allocate_dependencies.
7261         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7262         allocate_dependencies.
7263         (process_psymtab_comp_unit_reader)
7264         (build_type_psymtab_dependencies): Likewise.
7265         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7266
7267 2019-01-10  Tom Tromey  <tom@tromey.com>
7268
7269         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7270         PSYMBOL_SET_LANGUAGE.
7271         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7272
7273 2019-01-10  Tom Tromey  <tom@tromey.com>
7274
7275         * psymtab.h (psymtab_storage::obstack): New method.
7276         <m_obstack>: Rename from obstack; now private.
7277         * psymtab.c (psymtab_storage): Update.
7278         * dwarf2read.c (create_addrmap_from_index)
7279         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7280         Update.
7281
7282 2019-01-10  Tom Tromey  <tom@tromey.com>
7283
7284         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7285         * objfiles.h (objfile::reset_psymtabs): New method.
7286
7287 2019-01-10  Tom Tromey  <tom@tromey.com>
7288
7289         * symmisc.c (print_symbol_bcache_statistics): Update.
7290         (print_objfile_statistics): Update.
7291         * symfile.c (reread_symbols): Update.
7292         * psymtab.h (class psymtab_storage): New.
7293         * psymtab.c (psymtab_storage): New constructor.
7294         (~psymtab_storage): New destructor.
7295         (require_partial_symbols): Update.
7296         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7297         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7298         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7299         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7300         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7301         (start_psymtab_common, end_psymtab_common)
7302         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7303         (allocate_psymtab): Update.
7304         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7305         Update.
7306         (dump_psymtab_addrmap, maintenance_print_psymbols)
7307         (maintenance_check_psymtabs): Update.
7308         (class objfile_psymtabs): Move to objfiles.h.
7309         * psympriv.h (discard_psymtab): Now inline.
7310         (psymtab_discarder::psymtab_discarder): Update.
7311         (psymtab_discarder::~psymtab_discarder): Update.
7312         (ALL_OBJFILE_PSYMTABS): Rewrite.
7313         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7314         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7315         Remove fields.
7316         <partial_symtabs>: New field.
7317         (class objfile_psymtabs): Move from psymtab.h.  Update.
7318         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7319         psymbol_cache.
7320         (objfile::~objfile): Don't destroy psymbol_cache.
7321         * mdebugread.c (parse_partial_symbols): Update.
7322         * dwarf2read.c (create_addrmap_from_index)
7323         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7324         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7325         (add_partial_subprogram, dwarf2_ranges_read): Update.
7326         * dwarf-index-write.c (write_address_map)
7327         (write_one_signatured_type, recursively_write_psymbols)
7328         (class debug_names, class debug_names, write_psymtabs_to_index):
7329         Update.
7330
7331 2019-01-10  Tom Tromey  <tom@tromey.com>
7332
7333         * symtab.h (SYMBOL_SET_NAMES): Update.
7334         (symbol_set_names): Update.
7335         (MSYMBOL_SET_NAMES): Update.
7336         * symtab.c (symbol_set_names): Change argument to be an
7337         objfile_per_bfd_storage.
7338         * psymtab.c (add_psymbol_to_bcache): Update.
7339         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7340
7341 2019-01-10  Tom Tromey  <tom@tromey.com>
7342
7343         * symtab.c (create_demangled_names_hash): Change argument to be an
7344         objfile_per_bfd_storage.
7345         (symbol_set_names): Update.
7346
7347 2019-01-10  Tom Tromey  <tom@tromey.com>
7348
7349         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7350         init_psymbol_list.
7351         * psymtab.c (init_psymbol_list): Do nothing if already called.
7352         * psympriv.h (init_psymbol_list): Add comment.
7353         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7354         init_psymbol_list.
7355         * dbxread.c (dbx_symfile_read): Unconditionally call
7356         init_psymbol_list.
7357
7358 2019-01-10  Tom Tromey  <tom@tromey.com>
7359
7360         * xcoffread.c (scan_xcoff_symtab): Update.
7361         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7362         "where".
7363         * mdebugread.c (parse_partial_symbols)
7364         (handle_psymbol_enumerators): Update.
7365         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7366         * dbxread.c (read_dbx_symtab): Update.
7367         * psympriv.h (psymbol_placement): New enum.
7368         (add_psymbol_to_list): Update.
7369
7370 2019-01-10  Tom Tromey  <tom@tromey.com>
7371
7372         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7373         static_psymbols parameters.
7374         (scan_xcoff_symtab): Update.
7375         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7376         static_psymbols parameters.
7377         * psympriv.h (start_psymtab_common): Update.
7378         * mdebugread.c (parse_partial_symbols): Update.
7379         * dwarf2read.c (create_partial_symtab): Update.
7380         * dbxread.c (read_dbx_symtab): Update.
7381         (start_psymtab): Remove global_psymbols and static_psymbols
7382         parameters.
7383
7384 2019-01-10  Tom Tromey  <tom@tromey.com>
7385
7386         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7387         * psymtab.c (allocate_psymtab): Add comment.
7388         * psympriv.h (allocate_psymtab): Add comment.
7389         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7390         initializations.
7391         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7392
7393 2019-01-10  Tom Tromey  <tom@tromey.com>
7394
7395         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7396         Don't declare.
7397         * mipsread.c: Include mdebugread.h.
7398         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7399         Declare.
7400         * elfread.c: Include mdebugread.h.
7401
7402 2019-01-09  Tom Tromey  <tom@tromey.com>
7403
7404         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7405         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7406         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7407         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7408         (psym_lookup_symbol, psym_find_last_source_symtab)
7409         (psym_forget_cached_source_info, psym_print_stats)
7410         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7411         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7412         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7413         (psym_find_compunit_symtab_by_address)
7414         (maintenance_print_psymbols, maintenance_info_psymtabs)
7415         (maintenance_check_psymtabs): Use ranged for.
7416         * psymtab.h (class objfile_psymtabs): New.
7417         (require_partial_symbols): Return objfile_psymtabs.
7418         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7419
7420 2019-01-09  Tom Tromey  <tom@tromey.com>
7421
7422         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7423         (find_pc_mapped_section, list_overlays_command)
7424         (map_overlay_command, unmap_overlay_command)
7425         (simple_overlay_update): Use all_objfiles.
7426         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7427         * printcmd.c (info_symbol_command): Use all_objfiles.
7428         * objfiles.h (ALL_OBJSECTIONS): Remove.
7429         * maint.c (maintenance_translate_address): Use all_objfiles.
7430         * gcore.c (gcore_create_callback): Use all_objfiles.
7431         (objfile_find_memory_regions): Likewise.
7432
7433 2019-01-09  Tom Tromey  <tom@tromey.com>
7434
7435         * symtab.c (find_line_symtab, info_sources_command)
7436         (make_source_files_completion_list): Use objfile_compunits.
7437         * source.c (select_source_symtab): Use objfile_compunits.
7438         * objfiles.h (struct objfile): Update comment.
7439         (ALL_OBJFILES): Remove.
7440         (ALL_FILETABS): Remove.
7441         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7442         objfile_compunits.
7443
7444 2019-01-09  Tom Tromey  <tom@tromey.com>
7445
7446         * symmisc.c (print_objfile_statistics, dump_objfile)
7447         (maintenance_print_symbols): Use compunit_filetabs.
7448         * source.c (forget_cached_source_info_for_objfile): Use
7449         compunit_filetabs.
7450         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7451         (ALL_FILETABS): Use compunit_filetabs.
7452         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7453         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7454
7455 2019-01-09  Tom Tromey  <tom@tromey.com>
7456
7457         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7458         (compunit_filetabs): New.
7459         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7460         compunit_filetabs.
7461         (info_sources_command, make_source_files_completion_list): Remove
7462         declaration.
7463         * symmisc.c (print_objfile_statistics, dump_objfile)
7464         (maintenance_print_symbols): Remove declaration.
7465         (maintenance_info_symtabs): Use compunit_filetabs.
7466         (maintenance_info_line_tables): Likewise.
7467         * source.c (select_source_symtab): Change local variable name.
7468         (forget_cached_source_info_for_objfile): Remove declaration.
7469         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7470         * objfiles.c (objfile_relocate1): Remove declaration.
7471         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7472         declaration.
7473         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7474         * coffread.c (coff_symtab_read): Remove declaration.
7475         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7476         compunit_filetabs.
7477
7478 2019-01-09  Tom Tromey  <tom@tromey.com>
7479
7480         * symtab.c (lookup_objfile_from_block)
7481         (find_pc_sect_compunit_symtab, search_symbols)
7482         (default_collect_symbol_completion_matches_break_on): Use
7483         objfile_compunits.
7484         * objfiles.h (ALL_COMPUNITS): Remove.
7485         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7486         * cp-support.c (add_symbol_overload_list_qualified): Use
7487         objfile_compunits.
7488         * ada-lang.c (ada_collect_symbol_completion_matches)
7489         (ada_add_global_exceptions): Use objfile_compunits.
7490
7491 2019-01-09  Tom Tromey  <tom@tromey.com>
7492
7493         * source.c (select_source_symtab)
7494         (forget_cached_source_info_for_objfile): Remove declaration.
7495         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7496         declaration.
7497         * maint.c (count_symtabs_and_blocks): Remove declaration.
7498         * cp-support.c (add_symbol_overload_list_qualified): Remove
7499         declaration.
7500         * coffread.c (coff_symtab_read): Remove declaration.
7501         * symtab.c (lookup_symbol_in_objfile_symtabs)
7502         (basic_lookup_transparent_type_1): Use objfile_compunits.
7503         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7504         (info_sources_command, search_symbols)
7505         (default_collect_symbol_completion_matches_break_on)
7506         (make_source_files_completion_list): Remove declaration.
7507         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7508         (ada_collect_symbol_completion_matches)
7509         (ada_add_global_exceptions): Remove declaration.
7510         * linespec.c (iterate_over_all_matching_symtabs): Use
7511         objfile_compunits.
7512         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7513         (class objfile_compunits): New.
7514         (ALL_COMPUNITS): Use objfile_compunits.
7515         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7516         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7517         objfile_compunits.
7518         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7519
7520 2019-01-09  Tom Tromey  <tom@tromey.com>
7521
7522         * symtab.c (search_symbols)
7523         (default_collect_symbol_completion_matches_break_on): Use
7524         objfile_msymbols.
7525         * ada-lang.c (ada_lookup_simple_minsym)
7526         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7527         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7528         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7529         objfile_msymbols.
7530         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7531         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7532         * objc-lang.c (find_methods): Use objfile_msymbols.
7533         (info_selectors_command, info_classes_command): Likewise.
7534         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7535         * objfiles.h (class objfile_msymbols): New.
7536         (ALL_OBJFILE_MSYMBOLS): Remove.
7537         (ALL_MSYMBOLS): Remove.
7538
7539 2019-01-09  Tom Tromey  <tom@tromey.com>
7540
7541         * common/next-iterator.h (next_adapter): Add Iterator template
7542         parameter.
7543         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7544         (class all_objfiles_safe): New.
7545         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7546         * objfiles.c (put_objfile_before): Update comment.
7547         (add_separate_debug_objfile): Likewise.
7548         (free_all_objfiles): Use all_objfiles_safe.
7549         (objfile_purge_solibs): Likewise.
7550
7551 2019-01-09  Tom Tromey  <tom@tromey.com>
7552
7553         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7554         (expand_symtab_containing_pc, lookup_static_symbol)
7555         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7556         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7557         all_objfiles.
7558         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7559         * breakpoint.c (create_overlay_event_breakpoint)
7560         (create_longjmp_master_breakpoint)
7561         (create_std_terminate_master_breakpoint)
7562         (create_exception_master_breakpoint): Use all_objfiles.
7563         * linux-thread-db.c (try_thread_db_load_from_pdir)
7564         (has_libpthread): Use all_objfiles.
7565         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7566         * linespec.c (iterate_over_all_matching_symtabs)
7567         (search_minsyms_for_name): Use all_objfiles.
7568         * maint.c (maintenance_info_sections): Use all_objfiles.
7569         * main.c (captured_main_1): Use all_objfiles.
7570         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7571         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7572         * guile/scm-pretty-print.c
7573         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7574         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7575         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7576         (maintenance_print_msymbols): Use all_objfiles.
7577         * source.c (select_source_symtab): Use all_objfiles.
7578         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7579         * symfile.c (remove_symbol_file_command)
7580         (expand_symtabs_matching, map_symbol_filenames): Use
7581         all_objfiles.
7582         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7583         all_objfiles.
7584         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7585         * objc-lang.c (find_methods): Use all_objfiles.
7586         * objfiles.c (have_partial_symbols, have_full_symbols)
7587         (have_minimal_symbols, qsort_cmp)
7588         (default_iterate_over_objfiles_in_search_order): Use
7589         all_objfiles.
7590         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7591         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7592         (maintenance_check_psymtabs): Use all_objfiles.
7593         (ALL_PSYMTABS): Remove.
7594         * compile/compile-object-run.c (do_module_cleanup): Use
7595         all_objfiles.
7596         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7597         * cp-support.c (add_symbol_overload_list_qualified): Use
7598         all_objfiles.
7599         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7600         Use all_objfiles.
7601         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7602         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7603         all_objfiles.
7604         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7605         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7606         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7607         Uses all_objfiles.
7608         * solib.c (solib_read_symbols): Use all_objfiles
7609
7610 2019-01-09  Tom Tromey  <tom@tromey.com>
7611
7612         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7613         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7614         all_objfiles.
7615         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7616         * symmisc.c (print_symbol_bcache_statistics)
7617         (print_objfile_statistics, maintenance_print_objfiles)
7618         (maintenance_info_symtabs, maintenance_check_symtabs)
7619         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7620         all_objfiles.
7621         * source.c (forget_cached_source_info): Use all_objfiles.
7622         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7623         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7624         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7625         * objfiles.c (update_section_map): Use all_objfiles.
7626         (shared_objfile_contains_address_p): Likewise.
7627         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7628         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7629
7630 2019-01-09  Tom Tromey  <tom@tromey.com>
7631
7632         * common/next-iterator.h: New file.
7633         * objfiles.h (class all_objfiles): New.
7634         (struct objfile_iterator): New.
7635
7636 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7637
7638         * NEWS: Move the description of the changed "frame", "select-frame",
7639          and "info frame" commands to the Changed commands section.
7640
7641 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7642
7643         * gdbtypes.c (check_stub_method_group): Remove handling of old
7644         mangling schemes.
7645         * linespec.c (find_methods): Likewise.
7646         * stabsread.c (read_member_functions): Likewise.
7647         * valops.c (search_struct_method): Likewise.
7648         (value_struct_elt_for_reference): Likewise.
7649         * NEWS: Mention this change.
7650
7651 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7652
7653         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7654         print_source_lines.
7655         * source.c (print_source_lines_base): Update line number check.
7656         (print_source_lines): New function.
7657         (source_lines_range::source_lines_range): New function.
7658         * source.h (class source_lines_range): New class.
7659         (print_source_lines): New declaration.
7660
7661 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7662
7663         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7664
7665 2019-01-08  Tom Tromey  <tom@tromey.com>
7666             Simon Marchi  <simon.marchi@ericsson.com>
7667
7668         PR gdb/24060
7669         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7670         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7671         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7672         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7673         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7674         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7675
7676 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7677
7678         * source.c (select_source_symtab): Move header comment to
7679         declaration in source.h.
7680         (forget_cached_source_info_for_objfile): Likewise.
7681         (forget_cached_source_info): Likewise.
7682         (identify_source_line): Likewise.
7683         * source.h (identify_source_line): Move declaration from symtab.h
7684         and add comment from source.c
7685         (print_source_lines): Likewise.
7686         (forget_cached_source_info_for_objfile): Likewise.
7687         (forget_cached_source_info): Likewise.
7688         (select_source_symtab): Likewise.
7689         (enum print_source_lines_flag): Move definition from symtab.h.
7690         * symtab.h (identify_source_line): Move declaration to source.h.
7691         (print_source_lines): Likewise.
7692         (forget_cached_source_info_for_objfile): Likewise.
7693         (forget_cached_source_info): Likewise.
7694         (select_source_symtab): Likewise.
7695         (enum print_source_lines_flag): Move definition to source.h.
7696         * tui/tui-hooks.c: Add 'source.h' include.
7697
7698 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7699
7700         * source.c (print_source_lines_base): Handle requests to print
7701         reverse line number sequences, and guard against empty lines
7702         string.
7703
7704 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7705
7706         * source.c (print_source_lines_base): Fix skip of '\r' if next
7707         character is '\n'.
7708
7709 2019-01-06  Tom Tromey  <tom@tromey.com>
7710
7711         * c-exp.y (struct c_parse_state) <macro_original_text,
7712         expansion_obstack>: New member.
7713         (macro_original_text, expansion_obstack): Remove globals.
7714         (scan_macro_expansion, scanning_macro_expansion)
7715         (finished_macro_expansion): Update.
7716         (scan_macro_cleanup): Remove.
7717         (yylex, c_parse): Update.
7718
7719 2019-01-06  Tom Tromey  <tom@tromey.com>
7720
7721         * c-exp.y (struct c_parse_state) <strings>: New member.
7722         (operator_stoken): Update.
7723
7724 2019-01-06  Tom Tromey  <tom@tromey.com>
7725
7726         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7727         (union type_stack_elt) <typelist_val>: Now a pointer to
7728         std::vector.
7729         (type_stack_cleanup): Don't declare.
7730         (push_typelist): Update.
7731         * parse.c (pop_typelist): Return a std::vector.
7732         (push_typelist): Take a std::vector.
7733         (follow_types): Update.  Do not free args.
7734         (type_stack_cleanup): Remove.
7735         * c-exp.y (struct c_parse_state): New.
7736         (cpstate): New global.
7737         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7738         (nonempty_typelist): Update.
7739         (func_mod): Create a new vector.
7740         (c_parse): Create a c_parse_state.
7741         (check_parameter_typelist): Do not delete params.
7742         (function_method): Update.  Do not delete type_list.
7743
7744 2019-01-06  Tom Tromey  <tom@tromey.com>
7745
7746         PR gdb/28155:
7747         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7748         check_typedef.
7749         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7750         (print_return_value): Likewise.
7751
7752 2019-01-05  Tom Tromey  <tom@tromey.com>
7753
7754         * contrib/cleanup_check.py: Remove.
7755         * contrib/gcc-with-excheck: Remove.
7756         * contrib/exsummary.py: Remove.
7757         * contrib/excheck.py: Remove.
7758
7759 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7760
7761         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7762         NULL. Initialize tpprev to NULL instead of assigning it
7763         to NULL on the next statement.
7764         * windows-nat.c (windows_delete_thread): Remove check for
7765         main_thread_id before printing thread exit notifications.
7766         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7767         Remove thread ID check against main_thread_id.
7768         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7769         windows_delete_thread.
7770         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7771
7772 2019-01-04  Tom Tromey  <tom@tromey.com>
7773
7774         * compile/compile.c (_initialize_compile): Use upper case for
7775         metasyntactic variables.
7776         * symmisc.c (_initialize_symmisc): Use upper case for
7777         metasyntactic variables.
7778         * psymtab.c (_initialize_psymtab): Use upper case for
7779         metasyntactic variables.
7780         * demangle.c (demangle_command): Use upper case for metasyntactic
7781         variables.
7782         (_initialize_demangler): Likewise.
7783         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7784         variables.
7785
7786 2019-01-03  Tom Tromey  <tom@tromey.com>
7787
7788         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7789
7790 2019-01-03  Tom Tromey  <tom@tromey.com>
7791
7792         * python/py-symtab.c (salpy_str): Update.
7793         (struct salpy_sal_object) <symtab>: Now a PyObject.
7794         (salpy_dealloc): Update.
7795         (del_objfile_sal): Use gdbpy_ref.
7796
7797 2019-01-03  Tom Tromey  <tom@tromey.com>
7798
7799         * python/py-type.c (convert_field): Use new_reference.  Return
7800         gdbpy_ref.
7801         (make_fielditem): Return gdbpy_ref.
7802         (typy_fields): Update.
7803         (typy_getitem): Update.
7804         (field_name): Return gdbpy_ref.  Use new_reference.
7805         (typy_iterator_iternext): Update.
7806
7807 2019-01-03  Tom Tromey  <tom@tromey.com>
7808
7809         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7810
7811 2019-01-03  Tom Tromey  <tom@tromey.com>
7812
7813         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7814         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7815         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7816         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7817         (pspy_set_type_printers): Likewise.
7818         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7819         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7820         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7821         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7822         (objfpy_set_type_printers): Likewise.
7823
7824 2019-01-03  Tom Tromey  <tom@tromey.com>
7825
7826         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7827         (gdbpy_print_stack): Use gdbpy_err_fetch.
7828         * python/python-internal.h (class gdbpy_err_fetch): New class.
7829         (class gdbpy_enter) <m_error_type, m_error_value,
7830         m_error_traceback>: Remove.
7831         <m_error>: New member.
7832         (gdbpy_exception_to_string): Don't declare.
7833         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7834         * python/py-value.c (convert_value_from_python): Use
7835         gdbpy_err_fetch.
7836         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7837         gdbpy_exception_to_string.
7838         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7839         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7840         gdbpy_err_fetch.
7841
7842 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7843
7844         * linux-nat.c (delete_lwp_cleanup): Delete.
7845         (struct lwp_deleter): New struct.
7846         (lwp_info_up): New typedef.
7847         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7848         lwp_info_up.
7849
7850 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7851
7852         * linux-fork.c (class scoped_switch_fork_info): New class.
7853         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7854
7855 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7856
7857         * valops.c (find_overload_match): Remove use of null_cleanup, and
7858         calls to do_cleanups.
7859
7860 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7861
7862         * compile/compile-cplus-types.c
7863         (compile_cplus_instance::decl_name): Handle changes to
7864         cp_func_name.
7865         * cp-support.c (cp_func_name): Update header comment, update
7866         return type.
7867         * cp-support.h (cp_func_name): Update return type in declaration.
7868         * valops.c (find_overload_match): Move temp_func local to top
7869         level of function and change its type.  Use temp_func to hold and
7870         delete temporary string obtained from cp_func_name.
7871
7872 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7873
7874         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7875         gdb::char_vector, remove cleanup, and update uses of `msg`.
7876
7877 2019-01-03  Jim Wilson  <jimw@sifive.com>
7878
7879         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7880
7881 2019-01-02  Tom Tromey  <tom@tromey.com>
7882
7883         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7884         (tdesc_parse_xml): Remove cleanups.
7885         * target-descriptions.h (make_cleanup_free_target_description):
7886         Don't declare.
7887         (target_desc_deleter): New struct.
7888         (target_desc_up): New typedef.
7889         * target-descriptions.c (target_desc_deleter::operator()): Rename
7890         from free_target_description.
7891         (make_cleanup_free_target_description): Remove.
7892
7893 2019-01-02  Tom Tromey  <tom@tromey.com>
7894
7895         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7896         constructor, destructor.
7897         (linespec_parser): Remove typedef.
7898         (~linespec_parser): Rename from linespec_parser_delete.
7899         (linespec_lex_to_end, linespec_complete_label)
7900         (linespec_complete): Update.
7901         (decode_line_full): Remove cleanups.
7902         (decode_line_1): Update.
7903
7904 2019-01-02  Tom Tromey  <tom@tromey.com>
7905
7906         * python/python-internal.h (inferior_to_inferior_object): Change
7907         return type.
7908         * python/py-exitedevent.c (create_exited_event_object): Update.
7909         * python/py-inferior.c (inferior_to_inferior_object): Return
7910         gdbpy_ref.
7911         (python_new_inferior, python_inferior_deleted)
7912         (thread_to_thread_object, delete_thread_object)
7913         (build_inferior_list, gdbpy_selected_inferior): Update.
7914         * python/py-infthread.c (create_thread_object): Update.  Also fail
7915         if inferior_to_inferior_object fails.
7916
7917 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7918
7919         * inferior.h (class inferior) <displaced_step_state>: New field.
7920         * infrun.h (struct displaced_step_state): Move here from
7921         infrun.c.  Initialize fields, add constructor.
7922         <inf>: Remove field.
7923         <reset>: New method.
7924         * infrun.c (struct displaced_step_inferior_state): Move to
7925         infrun.h.
7926         (displaced_step_inferior_states): Remove.
7927         (get_displaced_stepping_state): Adust.
7928         (displaced_step_in_progress_any_inferior): Adjust.
7929         (displaced_step_in_progress_thread): Adjust.
7930         (displaced_step_in_progress): Adjust.
7931         (add_displaced_stepping_state): Remove.
7932         (get_displaced_step_closure_by_addr): Adjust.
7933         (remove_displaced_stepping_state): Remove.
7934         (infrun_inferior_exit): Call displaced_step_state.reset.
7935         (use_displaced_stepping): Don't check for NULL.
7936         (displaced_step_prepare_throw): Call
7937         get_displaced_stepping_state.
7938         (displaced_step_fixup): Don't check for NULL.
7939         (prepare_for_detach): Don't check for NULL.
7940
7941 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7942
7943         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7944          in case of call that did not complete.
7945
7946 2019-01-02  Andrey Utkin  <autkin@undo.io>
7947
7948         * symfile.c (find_separate_debug_file): Fix search of debug files for
7949         remote debuggee.
7950
7951 2019-01-02  Tom Tromey  <tom@tromey.com>
7952
7953         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7954         indentation.
7955         * python/py-frame.c (frapy_older): Remove cast.
7956         (frapy_newer): Likewise.
7957         * python/py-breakpoint.c (local_setattro): Remove cast.
7958         * python/py-arch.c (archpy_name): Remove local variable.
7959         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7960
7961 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7962
7963         * unittests/basic_string_view/element_access/char/empty.cc:
7964         Fix year range in copyright header.
7965
7966 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7967
7968         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7969         Delete.
7970         <operator==>: Update with for removed field.
7971         <hash>: Likewise.
7972         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7973         <isa_features>: ...this.
7974         <abi_features>: New field.
7975         (riscv_isa_flen): Update comment.
7976         (riscv_abi_xlen): New declaration.
7977         (riscv_abi_flen): New declaration.
7978         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7979         isa_features.
7980         (riscv_abi_xlen): New function.
7981         (riscv_isa_flen): Update to get answer from isa_features.
7982         (riscv_abi_flen): New function.
7983         (riscv_has_fp_abi): Update to get answer from abi_features.
7984         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7985         xlen and flen.
7986         (riscv_call_info) <xlen, flen>: Update comment.
7987         (riscv_call_arg_struct): Remove invalid assertions
7988         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7989         is removed.
7990         (riscv_gdbarch_init): Gather isa features and abi features
7991         separately, ensure both match on the gdbarch when reusing an old
7992         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7993         a target with 64-bit float hardware.
7994
7995 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7996
7997         * source.c (search_command_helper): Stop reverse search
7998         when line 1 has been searched.
7999
8000 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8001
8002         * record-full.c (record_full_base_target::close): Rewrite
8003         record_full_core_buf_list free logic.
8004
8005 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8006
8007         * break-catch-syscall.c (print_one_catch_syscall): xfree
8008         the last text.
8009
8010 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8011
8012         * top.c (print_gdb_version): Update Copyright year in version
8013         message.
8014
8015 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8016
8017         Update copyright year range in all GDB files.
8018
8019 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8020
8021         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8022
8023 For older changes see ChangeLog-2018.
8024 \f
8025 Local Variables:
8026 mode: change-log
8027 left-margin: 8
8028 fill-column: 74
8029 version-control: never
8030 coding: utf-8
8031 End:
8032