Fix lookup of separate debug file on MS-Windows.
[external/binutils.git] / gdb / ChangeLog
1 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2
3         * symfile.c (find_separate_debug_file): Remove colon from the
4         drive spec of DOS/Windows file names of the target, so that the
5         file name produced from DEBUGDIR and the target's directory will
6         be valid on DOS/Windows systems.
7
8 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
9
10         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
11         Use current_event.dwThreadId instead of main_thread_id.
12
13 2019-04-30  Tom Tromey  <tromey@adacore.com>
14
15         PR c++/24470:
16         * dwarf2read.c (process_structure_scope): Handle case where type
17         has template parameters but no symbol was created.
18
19 2019-04-19  Sergei Trofimovich <siarheit@google.com>
20
21         * configure.ac: add --enable-source-highlight switch.
22         * configure: Regenerate.
23         * top.c (print_gdb_version): plumb --enable-source-highlight
24         status to "show configuration".
25
26 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
27
28         PR symtab/24423:
29         * source.c (print_source_lines_base): Advance "iter" when a
30         control character is seen.
31
32 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
33
34         * inferior.h (struct infcall_suspend_state_deleter):
35         Catch exception in destructor to avoid crash.
36
37 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
38
39         * utils.c (prompt_for_continue): Don't restore the styling at the
40         end, as applied_style has the wrong value.  This fixes styling in
41         long lists of file names that are interrupted by the "Continue?"
42         prompt.
43
44 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
45
46         * version.in: Set GDB version number to 8.2.91.DATE-git.
47
48 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
49
50         GDB 8.2.91 released.
51
52 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
53
54         * version.in: Set GDB version number to 8.2.91.
55
56 2019-03-20  Tom Tromey  <tromey@adacore.com>
57
58         PR gdb/24391
59         * infrun.c (handle_inferior_event): Rename from
60         handle_inferior_event_1.  Create a scoped_value_mark.
61         (handle_inferior_event): Remove.
62
63 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
64
65         * source-cache.c (source_cache::get_source_lines): Re-read
66         fullname after calling open_source_file.
67
68 2019-03-18  Pedro Alves  <palves@redhat.com>
69             Eli Zaretskii <eliz@gnu.org>
70
71         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
72         m_line and m_start_of_line.
73
74 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
75
76         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
77         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
78         it returns a newline.  This fixes a regression in TU mode, whereby
79         the next line is output on the same screen line as the user input.
80
81 2019-03-18  Pedro Alves  <palves@redhat.com>
82
83         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
84         New globals.
85         (apply_style): New, factored out from ...
86         (apply_ansi_escape): ... this.  Handle reverse video mode.
87         (tui_set_reverse_mode): New function.
88         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
89         * tui/tui-winsource.c (tui_show_source_line): Use
90         tui_set_reverse_mode instead of setting A_STANDOUT.
91         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
92         New setter methods.
93
94 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
95
96         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
97         Handle tabs.
98
99 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
100
101         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
102         tui_refill_source_window instead of tui_refresh_win, to update the
103         current execution line.  This fixes redisplay of the current line
104         when stepping through the code with "next" or "step".
105
106 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
107
108         * source-cache.c (source_cache::get_source_lines): Call
109         find_source_lines to initialize s->nlines.  This fixes vertical
110         scrolling of TUI source window when the DOWN arrow is pressed.
111
112 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
113
114         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
115         wclrtoeol in tui_show_source_line".  This reverts changes made in
116         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
117
118 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
119
120         * NEWS: Combine separate "New targets" sections for 8.3.
121
122 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
123
124         The MS-Windows port of ncurses fails to switch to a color pair if
125         one or both of the colors are the implicit default colors.  This
126         change records the default colors when TUI is initialized, and
127         then specifies them explicitly when a color pair uses the default
128         colors.  This allows color styling in TUI mode on MS-Windows.
129
130         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
131         ncurses_norm_attr.
132         (tui_initialize_io) [__MINGW32__]: Record the default terminal
133         colors in ncurses_norm_attr.
134         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
135         "none", replace it with the default color recorded in
136         ncurses_norm_attr.
137
138 2019-03-14  Tom Tromey  <tromey@adacore.com>
139
140         * source-cache.h (class source_cache) <get_source_lines>: Return
141         std::string.
142         * source-cache.c (source_cache::extract_lines): Handle case where
143         first_pos==npos.  Return std::string.
144         (source_cache::get_source_lines): Update.
145
146 2019-03-14  Tom Tromey  <tromey@adacore.com>
147
148         * NEWS: Add item for "style sources" commands.
149         * source-cache.c (source_cache::get_source_lines): Check
150         source_styling.
151         * cli/cli-style.c (source_styling): New global.
152         (_initialize_cli_style): Add "style sources" commands.
153         (show_style_sources): New function.
154         * cli/cli-style.h (source_styling): Declare.
155
156 2019-03-14  Pedro Alves  <palves@redhat.com>
157             Tom Tromey  <tromey@adacore.com>
158
159         * tui/tui-winsource.h (tui_refill_source_window): Declare.
160         * tui/tui-winsource.c (tui_refill_source_window): New function,
161         from...
162         (tui_horizontal_source_scroll): ... here.  Move some logic.
163         * cli/cli-style.c (set_style_enabled): Notify new observable.
164         * tui/tui-hooks.c (tui_redisplay_source): New function.
165         (tui_attach_detach_observers): Attach or detach
166         tui_redisplay_source.
167         * observable.h (source_styling_changed): New observable.
168         * observable.c: Define source_styling_changed observable.
169
170 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
171
172         PR/24325
173         * source-cache.c: #undef open and close, to avoid unresolved
174         externals during linking.
175
176 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
177
178         Support styling on native MS-Windows console
179
180         PR/24315
181         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
182         on MS-Windows if $TERM is not defined.
183
184         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
185
186         * posix-hdep.c (gdb_console_fputs):
187         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
188         functions.
189         * ui-file.h (gdb_console_fputs): Add prototype.
190
191         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
192         back to fputs only if the former returns zero.
193
194 2019-03-07  Brian Vandenberg  <phantall@gmail.com>
195             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
196
197         PR gdb/8527
198         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
199         set_sigint_trap, clear_sigint_trap.
200
201 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
202
203         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
204         for-loop range, to avoid compiler warnings.
205
206         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
207         avoid compiler warnings about unused variables.
208
209 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
210
211         * NEWS: Mention end of support for native debugging on MS-Windows
212         before XP.
213
214 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
215
216         PR gdb/24292
217         * common/netstuff.c:
218         * gdbserver/gdbreplay.c
219         * gdbserver/remote-utils.c:
220         * ser-tcp.c:
221         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
222         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
223         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
224         'getaddrinfo' and 'freeaddrinfo' were not available before
225         Windows XP, and mingw.org's MinGW headers by default define
226         _WIN32_WINNT to 0x500.
227
228 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
229     
230         * NEWS: Note minimum Python version.
231
232 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
233
234         * version.in: Set GDB version number to 8.2.90.DATE-git.
235
236 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
237
238         GDB 8.2.90 released.
239
240 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
241
242         * version.in: Set GDB version number to 8.2.90.
243
244 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
245
246         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
247
248 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
249
250         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
251         * version.in: Bump version to 8.2.90.DATE-git.
252
253 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
254
255         * aix-thread.c (ptid_cmp): Remove unused variable.
256         (get_signaled_thread): Likewise.
257         (store_regs_user_thread): Likewise.
258         (store_regs_kernel_thread): Likewise.
259         (fetch_regs_kernel_thread): Remove shadowed variable.
260
261 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
262
263         * features/riscv/32bit-cpu.xml: Add register numbers.
264         * features/riscv/32bit-fpu.c: Regenerate.
265         * features/riscv/32bit-fpu.xml: Add register numbers.
266         * features/riscv/64bit-cpu.xml: Add register numbers.
267         * features/riscv/64bit-fpu.c: Regenerate.
268         * features/riscv/64bit-fpu.xml: Add register numbers.
269
270 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
271
272         * NEWS: Mention two argument form of gdb.Value constructor.
273         * python/py-value.c (convert_buffer_and_type_to_value): New
274         function.
275         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
276         Add support for handling an optional second argument.  Call
277         convert_buffer_and_type_to_value as appropriate.
278         * python/python-internal.h (Py_buffer_deleter): New struct.
279         (Py_buffer_up): New typedef.
280
281 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
282
283         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
284         instead of releasing ownership.
285
286 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
287
288         * dwarf2read.c (open_and_init_dwp_file): Call
289         elf_numsections instead of bfd_count_sections to initialize
290         dwp_file->num_sections.
291
292 2019-02-25  Tom Tromey  <tromey@adacore.com>
293
294         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
295
296 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
297
298         * gcore.in: Add '--readnever' option when invoking GDB.
299
300 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
301
302         * MAINTAINERS: Update my email address.
303
304 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
305
306         * build-id.c (build_id_to_debug_bfd_1): New function.
307         (build_id_to_debug_bfd): Look for separate debug file in
308         sysroot.
309
310 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
311
312         * gdbarch.sh: Update the copyright year range that is placed into
313         generated files.
314
315 2019-02-22  Keith Seitz  <keiths@redhat.com>
316
317         PR symtab/23853
318         * linespec.c (create_sals_line_offset): Search for the default
319         symtab's filename instead of its fullname.
320
321 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
322
323         * NEWS: Update style defaults.
324
325 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
326
327         * main.c (captured_main_1): Disable styling in batch mode.
328
329 2019-02-20  Tom Tromey  <tom@tromey.com>
330
331         * symtab.c (symtab_symbol_info): Fix typos.
332
333 2019-02-20  Tom Tromey  <tromey@adacore.com>
334
335         * findcmd.c (_initialize_mem_search): Use upper case for
336         metasyntactic variables.
337
338 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
339
340         * aarch64-tdep.c (aarch64_add_reggroups): New function.
341         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
342
343 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
344
345         * top.h (source_file_name): Change to std::string.
346         * top.c (source_file_name): Likewise.
347         (command_line_input): Adjust.
348         * cli/cli-script.c (script_from_file): Adjust.
349
350 2019-02-19  Tom Tromey  <tromey@adacore.com>
351
352         * ravenscar-thread.c
353         (ravenscar_thread_target::update_thread_list): Don't call
354         ada_build_task_list.
355         * ada-lang.h (ada_build_task_list): Don't declare.
356         * ada-tasks.c (struct ada_tasks_inferior_data)
357         <task_list_valid_p>: Now bool.
358         (read_known_tasks, ada_task_list_changed)
359         (ada_tasks_invalidate_inferior_data): Update.
360         (read_known_tasks_array): Return bool.
361         (read_known_tasks_list): Likewise.
362         (read_known_tasks): Return void.
363         (ada_build_task_list): Now static.
364
365 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
366
367         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
368         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
369
370 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
371
372         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
373         variant for ada_tasks_pspace_data_handle and
374         ada_tasks_inferior_data_handle.
375         (ada_tasks_pspace_data_cleanup): New function.
376         (ada_tasks_inferior_data_cleanup): New function.
377
378 2019-02-17  Tom Tromey  <tom@tromey.com>
379
380         * macrotab.h (macro_source_fullname): Return a std::string.
381         * macrotab.c (macro_include, check_for_redefinition)
382         (macro_undef, macro_lookup_definition, foreach_macro)
383         (foreach_macro_in_scope): Update.
384         (macro_source_fullname): Return a std::string.
385         * macrocmd.c (show_pp_source_pos): Update.
386
387 2019-02-17  Tom Tromey  <tom@tromey.com>
388
389         * macrocmd.c (show_pp_source_pos): Style the file names.
390
391 2019-02-17  Tom Tromey  <tom@tromey.com>
392
393         PR tui/24197:
394         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
395
396 2019-02-17  Tom Tromey  <tom@tromey.com>
397
398         * ada-lang.c (user_select_syms): Use filtered printing.
399         * utils.c (wrap_style): New global.
400         (desired_style): Remove.
401         (emit_style_escape): Add stream parameter.
402         (set_output_style, reset_terminal_style, prompt_for_continue):
403         Update.
404         (flush_wrap_buffer): Only flush gdb_stdout.
405         (wrap_here): Set wrap_style.
406         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
407         treat escape sequences as a character.  Change when wrap buffer is
408         flushed.
409         (fputs_styled): Do not set the output style when the default is
410         requested.
411         * ui-style.h (struct ui_file_style) <is_default>: New method.
412         * source.c (print_source_lines_base): Emit escape sequences in one
413         piece.
414
415 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
416
417         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
418         integers and enumeration types.
419
420 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
421
422         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
423         instead of lookup_symbol_in_language
424         (do_exact_match): New function.
425         (ada_get_symbol_name_matcher): Return do_exact_match when
426         doing a verbatim match.
427
428 2019-02-15  Tom Tromey  <tromey@adacore.com>
429
430         * ravenscar-thread.c (ravenscar_thread_target::resume)
431         (ravenscar_thread_target::wait): Special case wildcard requests.
432
433 2019-02-15  Tom Tromey  <tromey@adacore.com>
434
435         * ravenscar-thread.c (base_ptid): Remove.
436         (struct ravenscar_thread_target) <close>: New method.
437         <m_base_ptid>: New member.
438         <update_inferior_ptid, active_task, task_is_currently_active,
439         runtime_initialized>: Declare methods.
440         <ravenscar_thread_target>: Add constructor.
441         (ravenscar_thread_target::task_is_currently_active)
442         (ravenscar_thread_target::update_inferior_ptid)
443         (ravenscar_runtime_initialized): Rename.  Now methods.
444         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
445         (ravenscar_thread_target::update_thread_list): Update.
446         (ravenscar_thread_target::active_task): Now method.
447         (ravenscar_thread_target::store_registers)
448         (ravenscar_thread_target::prepare_to_store)
449         (ravenscar_thread_target::prepare_to_store)
450         (ravenscar_thread_target::mourn_inferior): Update.
451         (ravenscar_inferior_created): Use "new" to create target.
452         (ravenscar_thread_target::get_ada_task_ptid): Update.
453         (_initialize_ravenscar): Don't initialize base_ptid.
454         (ravenscar_ops): Remove global.
455
456 2019-02-15  Tom Tromey  <tromey@adacore.com>
457
458         * target.h (push_target): Declare new overload.
459         * target.c (push_target): New overload, taking an rvalue reference.
460         * remote.c (remote_target::open_1): Use push_target overload.
461         * corelow.c (core_target_open): Use push_target overload.
462
463 2019-02-15  Tom Tromey  <tromey@adacore.com>
464
465         * ravenscar-thread.c (is_ravenscar_task)
466         (ravenscar_task_is_currently_active): Return bool.
467         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
468         (_initialize_ravenscar): Remove "(void)".
469         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
470         Return bool.
471
472 2019-02-15  Tom Tromey  <tromey@adacore.com>
473
474         * ravenscar-thread.c (ravenscar_runtime_initializer)
475         (has_ravenscar_runtime, get_running_thread_id)
476         (ravenscar_thread_target::resume): Fix indentation.
477
478 2019-02-15  Tom Tromey  <tromey@adacore.com>
479
480         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
481         from ravenscar_arch_ops.
482         (sparc_ravenscar_ops::fetch_registers)
483         (sparc_ravenscar_ops::store_registers): Now methods.
484         (sparc_ravenscar_prepare_to_store): Remove.
485         (sparc_ravenscar_ops): Redefine.
486         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
487         methods and destructor.  Remove members.
488         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
489         (ravenscar_thread_target::store_registers)
490         (ravenscar_thread_target::prepare_to_store): Update.
491         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
492         Remove.
493         (struct ppc_ravenscar_powerpc_ops): Derive from
494         ravenscar_arch_ops.
495         (ppc_ravenscar_powerpc_ops::fetch_registers)
496         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
497         (ppc_ravenscar_powerpc_ops): Redefine.
498         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
499         (ppc_ravenscar_e500_ops::fetch_registers)
500         (ppc_ravenscar_e500_ops::store_registers): Now methods.
501         (ppc_ravenscar_e500_ops): Redefine.
502         * aarch64-ravenscar-thread.c
503         (aarch64_ravenscar_generic_prepare_to_store): Remove.
504         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
505         (aarch64_ravenscar_fetch_registers)
506         (aarch64_ravenscar_store_registers): Now methods.
507         (aarch64_ravenscar_ops): Redefine.
508
509 2019-02-15  Tom Tromey  <tromey@adacore.com>
510
511         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
512         (ravenscar_thread_target::stopped_by_hw_breakpoint)
513         (ravenscar_thread_target::stopped_by_watchpoint)
514         (ravenscar_thread_target::stopped_data_address)
515         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
516
517 2019-02-15  Tom Tromey  <tromey@adacore.com>
518
519         * ravenscar-thread.c: Fix some typos.
520
521 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
522             Tom Tromey  <tromey@adacore.com>
523
524         * ada-lang.c (ada_exception_sal): Change addr_string to a
525         std::string.
526         (create_ada_exception_catchpoint): Update.
527
528 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
529             Tom Tromey  <tromey@adacore.com>
530
531         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
532         (bp_location_ops): Remove.
533         (base_breakpoint_allocate_location): Update.
534         (free_bp_location): Update.
535         * ada-lang.c (class ada_catchpoint_location)
536         <ada_catchpoint_location>: Remove ops parameter.
537         (ada_catchpoint_location_dtor): Remove.
538         (ada_catchpoint_location_ops): Remove.
539         (allocate_location_exception): Update.
540         * breakpoint.h (struct bp_location_ops): Remove.
541         (class bp_location) <bp_location>: Remove bp_location_ops
542         parameter.
543         <~bp_location>: Add destructor.
544         <ops>: Remove.
545
546 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
547             Pedro Alves  <palves@redhat.com>
548
549         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
550         'PATH_MAX'.
551
552 2019-02-14  David Michael  <fedora.dm0@gmail.com>
553             Samuel Thibault  <samuel.thibault@gnu.org>
554             Thomas Schwinge  <thomas@codesourcery.com>
555
556         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
557         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
558
559 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
560
561         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
562         (check_empty): Use "const char *".
563
564         * gnu-nat.c (gnu_nat_target::detach): Instead of
565         'detach_inferior (pid)' call
566         'detach_inferior (find_inferior_pid (pid))'.
567
568         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
569         'nat/fork-inferior.o'.
570         * gnu-nat.c: #include "nat/fork-inferior.h".
571
572         * gnu-nat.c (gnu_nat_target::detach): Instead of
573         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
574         * gnu-nat.h: #include "inf-child.h".
575         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
576         'i386_gnu_nat_target::fetch_registers'.
577         (gnu_store_registers): Rename/move to
578         'i386_gnu_nat_target::store_registers'.
579
580         * config/i386/nm-i386gnu.h: Don't "#include" any files.
581         * gnu-nat.h (mach_thread_info): New function.
582         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
583
584         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
585
586 2019-02-14  Frederic Konrad  <konrad@adacore.com>
587
588         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
589
590 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
591
592         * windows-nat.c (windows_add_thread): Add new parameter
593         "main_thread_p" with default value set to false.  Update
594         function documentation as well as all callers.
595         (windows_delete_thread): Likewise.
596         (fake_create_process): Update call to windows_add_thread.
597         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
598         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
599         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
600         call to windows_delete_thread.
601
602 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
603
604         * MAINTAINERS: Add Andrew Burgess as global maintainer.
605
606 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
607
608         * symfile.c (find_separate_debug_file): Use canonical path of
609         sysroot with child_path instead of gdb_sysroot if it is valid.
610
611 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
612
613         * symfile.c (find_separate_debug_file): Use child_path to
614         determine if an object file is under a sysroot.
615
616 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
617
618         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
619         unittests/child-path-selftests.c.
620         * common/pathstuff.c (child_path): New function.
621         * common/pathstuff.h (child_path): New prototype.
622         * unittests/child-path-selftests.c: New file.
623
624 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
625
626         * symfile.c (find_separate_debug_file): Look for separate debug
627         files in debug directories under the sysroot.
628
629 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
630
631         * symtab.h (struct minimal_symbol data_p): New const method.
632         (struct minimal_symbol text_p): Likewise.
633         * symtab.c (output_source_filename): Use file name style
634         to print file name.
635         (print_symbol_info): Likewise.
636         (print_msymbol_info): Use address style to print addresses.
637         Use function name style to print executable text symbols.
638         (expand_symtab_containing_pc): Use data_p.
639         (find_pc_sect_compunit_symtab): Likewise.
640
641 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
642
643         * breakpoint.c (describe_other_breakpoints): Use address style
644         to print addresses.
645         (say_where): Likewise.
646
647 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
648
649         * ada-typeprint.c (print_func_type): Print function name
650         style to print function name.
651         * c-typeprint.c (c_print_type_1): Likewise.
652
653 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
654
655         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
656         for execve.
657
658 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
659
660         * c-exp.y (direct_abs_decl): Use emplace_back to record the
661         type_stack.
662
663 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
664
665         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
666         TYPE_CODE_REF types.
667
668 2019-02-08  Jim Wilson  <jimw@sifive.com>
669
670         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
671         (riscv_linux_fregset): New.
672         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
673
674 2019-02-07  Tom Tromey  <tom@tromey.com>
675
676         * thread.c (thread_cancel_execution_command): Update.
677         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
678         methods.
679         (struct thread_fsm_ops): Remove.
680         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
681         (thread_fsm_should_stop, thread_fsm_return_value)
682         (thread_fsm_set_finished, thread_fsm_finished_p)
683         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
684         Don't declare.
685         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
686         * infrun.c (clear_proceed_status_thread)
687         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
688         (print_stop_event): Update.
689         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
690         Add constructor.
691         (step_command_fsm_ops): Remove.
692         (new_step_command_fsm): Remove.
693         (step_1): Update.
694         (step_command_fsm::should_stop): Rename from
695         step_command_fsm_should_stop.
696         (step_command_fsm::clean_up): Rename from
697         step_command_fsm_clean_up.
698         (step_command_fsm::do_async_reply_reason): Rename from
699         step_command_fsm_async_reply_reason.
700         (struct until_next_fsm): Inherit from thread_fsm.  Add
701         constructor.
702         (until_next_fsm_ops): Remove.
703         (new_until_next_fsm): Remove.
704         (until_next_fsm::should_stop): Rename from
705         until_next_fsm_should_stop.
706         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
707         (until_next_fsm::do_async_reply_reason): Rename from
708         until_next_fsm_async_reply_reason.
709         (struct finish_command_fsm): Inherit from thread_fsm.  Add
710         constructor.  Change type of breakpoint.
711         (finish_command_fsm_ops): Remove.
712         (new_finish_command_fsm): Remove.
713         (finish_command_fsm::should_stop): Rename from
714         finish_command_fsm_should_stop.
715         (finish_command_fsm::clean_up): Rename from
716         finish_command_fsm_clean_up.
717         (finish_command_fsm::return_value): Rename from
718         finish_command_fsm_return_value.
719         (finish_command_fsm::do_async_reply_reason): Rename from
720         finish_command_fsm_async_reply_reason.
721         (finish_command): Update.
722         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
723         Add constructor.
724         (call_thread_fsm_ops): Remove.
725         (call_thread_fsm::call_thread_fsm): Rename from
726         new_call_thread_fsm.
727         (call_thread_fsm::should_stop): Rename from
728         call_thread_fsm_should_stop.
729         (call_thread_fsm::should_notify_stop): Rename from
730         call_thread_fsm_should_notify_stop.
731         (run_inferior_call, call_function_by_hand_dummy): Update.
732         * cli/cli-interp.c (should_print_stop_to_console): Update.
733         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
734         Add constructor.  Change type of location_breakpoint,
735         caller_breakpoint.
736         (until_break_fsm_ops): Remove.
737         (new_until_break_fsm): Remove.
738         (until_break_fsm::should_stop): Rename from
739         until_break_fsm_should_stop.
740         (until_break_fsm::clean_up): Rename from
741         until_break_fsm_clean_up.
742         (until_break_fsm::do_async_reply_reason): Rename from
743         until_break_fsm_async_reply_reason.
744         (until_break_command): Update.
745         * thread-fsm.c: Remove.
746         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
747
748 2019-02-07  Tom Tromey  <tom@tromey.com>
749
750         * yy-remap.h: Add include guard.
751         * xtensa-tdep.h: Add include guard.
752         * xcoffread.h: Rename include guard.
753         * varobj-iter.h: Add include guard.
754         * tui/tui.h: Rename include guard.
755         * tui/tui-winsource.h: Rename include guard.
756         * tui/tui-wingeneral.h: Rename include guard.
757         * tui/tui-windata.h: Rename include guard.
758         * tui/tui-win.h: Rename include guard.
759         * tui/tui-stack.h: Rename include guard.
760         * tui/tui-source.h: Rename include guard.
761         * tui/tui-regs.h: Rename include guard.
762         * tui/tui-out.h: Rename include guard.
763         * tui/tui-layout.h: Rename include guard.
764         * tui/tui-io.h: Rename include guard.
765         * tui/tui-hooks.h: Rename include guard.
766         * tui/tui-file.h: Rename include guard.
767         * tui/tui-disasm.h: Rename include guard.
768         * tui/tui-data.h: Rename include guard.
769         * tui/tui-command.h: Rename include guard.
770         * tic6x-tdep.h: Add include guard.
771         * target/waitstatus.h: Rename include guard.
772         * target/wait.h: Rename include guard.
773         * target/target.h: Rename include guard.
774         * target/resume.h: Rename include guard.
775         * target-float.h: Rename include guard.
776         * stabsread.h: Add include guard.
777         * rs6000-tdep.h: Add include guard.
778         * riscv-fbsd-tdep.h: Add include guard.
779         * regformats/regdef.h: Rename include guard.
780         * record.h: Rename include guard.
781         * python/python.h: Rename include guard.
782         * python/python-internal.h: Rename include guard.
783         * python/py-stopevent.h: Rename include guard.
784         * python/py-ref.h: Rename include guard.
785         * python/py-record.h: Rename include guard.
786         * python/py-record-full.h: Rename include guard.
787         * python/py-record-btrace.h: Rename include guard.
788         * python/py-instruction.h: Rename include guard.
789         * python/py-events.h: Rename include guard.
790         * python/py-event.h: Rename include guard.
791         * procfs.h: Add include guard.
792         * proc-utils.h: Add include guard.
793         * p-lang.h: Add include guard.
794         * or1k-tdep.h: Rename include guard.
795         * observable.h: Rename include guard.
796         * nto-tdep.h: Rename include guard.
797         * nat/x86-linux.h: Rename include guard.
798         * nat/x86-linux-dregs.h: Rename include guard.
799         * nat/x86-gcc-cpuid.h: Add include guard.
800         * nat/x86-dregs.h: Rename include guard.
801         * nat/x86-cpuid.h: Rename include guard.
802         * nat/ppc-linux.h: Rename include guard.
803         * nat/mips-linux-watch.h: Rename include guard.
804         * nat/linux-waitpid.h: Rename include guard.
805         * nat/linux-ptrace.h: Rename include guard.
806         * nat/linux-procfs.h: Rename include guard.
807         * nat/linux-osdata.h: Rename include guard.
808         * nat/linux-nat.h: Rename include guard.
809         * nat/linux-namespaces.h: Rename include guard.
810         * nat/linux-btrace.h: Rename include guard.
811         * nat/glibc_thread_db.h: Rename include guard.
812         * nat/gdb_thread_db.h: Rename include guard.
813         * nat/gdb_ptrace.h: Rename include guard.
814         * nat/fork-inferior.h: Rename include guard.
815         * nat/amd64-linux-siginfo.h: Rename include guard.
816         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
817         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
818         * nat/aarch64-linux.h: Rename include guard.
819         * nat/aarch64-linux-hw-point.h: Rename include guard.
820         * mn10300-tdep.h: Add include guard.
821         * mips-linux-tdep.h: Add include guard.
822         * mi/mi-parse.h: Rename include guard.
823         * mi/mi-out.h: Rename include guard.
824         * mi/mi-main.h: Rename include guard.
825         * mi/mi-interp.h: Rename include guard.
826         * mi/mi-getopt.h: Rename include guard.
827         * mi/mi-console.h: Rename include guard.
828         * mi/mi-common.h: Rename include guard.
829         * mi/mi-cmds.h: Rename include guard.
830         * mi/mi-cmd-break.h: Rename include guard.
831         * m2-lang.h: Add include guard.
832         * location.h: Rename include guard.
833         * linux-record.h: Rename include guard.
834         * linux-nat.h: Add include guard.
835         * linux-fork.h: Add include guard.
836         * i386-darwin-tdep.h: Rename include guard.
837         * hppa-linux-offsets.h: Add include guard.
838         * guile/guile.h: Rename include guard.
839         * guile/guile-internal.h: Rename include guard.
840         * gnu-nat.h: Rename include guard.
841         * gdb-stabs.h: Rename include guard.
842         * frv-tdep.h: Add include guard.
843         * f-lang.h: Add include guard.
844         * event-loop.h: Add include guard.
845         * darwin-nat.h: Rename include guard.
846         * cp-abi.h: Rename include guard.
847         * config/sparc/nm-sol2.h: Rename include guard.
848         * config/nm-nto.h: Rename include guard.
849         * config/nm-linux.h: Add include guard.
850         * config/i386/nm-i386gnu.h: Rename include guard.
851         * config/djgpp/nl_types.h: Rename include guard.
852         * config/djgpp/langinfo.h: Rename include guard.
853         * compile/gcc-cp-plugin.h: Add include guard.
854         * compile/gcc-c-plugin.h: Add include guard.
855         * compile/compile.h: Rename include guard.
856         * compile/compile-object-run.h: Rename include guard.
857         * compile/compile-object-load.h: Rename include guard.
858         * compile/compile-internal.h: Rename include guard.
859         * compile/compile-cplus.h: Rename include guard.
860         * compile/compile-c.h: Rename include guard.
861         * common/xml-utils.h: Rename include guard.
862         * common/x86-xstate.h: Rename include guard.
863         * common/version.h: Rename include guard.
864         * common/vec.h: Rename include guard.
865         * common/tdesc.h: Rename include guard.
866         * common/selftest.h: Rename include guard.
867         * common/scoped_restore.h: Rename include guard.
868         * common/scoped_mmap.h: Rename include guard.
869         * common/scoped_fd.h: Rename include guard.
870         * common/safe-iterator.h: Rename include guard.
871         * common/run-time-clock.h: Rename include guard.
872         * common/refcounted-object.h: Rename include guard.
873         * common/queue.h: Rename include guard.
874         * common/ptid.h: Rename include guard.
875         * common/print-utils.h: Rename include guard.
876         * common/preprocessor.h: Rename include guard.
877         * common/pathstuff.h: Rename include guard.
878         * common/observable.h: Rename include guard.
879         * common/netstuff.h: Rename include guard.
880         * common/job-control.h: Rename include guard.
881         * common/host-defs.h: Rename include guard.
882         * common/gdb_wait.h: Rename include guard.
883         * common/gdb_vecs.h: Rename include guard.
884         * common/gdb_unlinker.h: Rename include guard.
885         * common/gdb_unique_ptr.h: Rename include guard.
886         * common/gdb_tilde_expand.h: Rename include guard.
887         * common/gdb_sys_time.h: Rename include guard.
888         * common/gdb_string_view.h: Rename include guard.
889         * common/gdb_splay_tree.h: Rename include guard.
890         * common/gdb_setjmp.h: Rename include guard.
891         * common/gdb_ref_ptr.h: Rename include guard.
892         * common/gdb_optional.h: Rename include guard.
893         * common/gdb_locale.h: Rename include guard.
894         * common/gdb_assert.h: Rename include guard.
895         * common/filtered-iterator.h: Rename include guard.
896         * common/filestuff.h: Rename include guard.
897         * common/fileio.h: Rename include guard.
898         * common/environ.h: Rename include guard.
899         * common/common-utils.h: Rename include guard.
900         * common/common-types.h: Rename include guard.
901         * common/common-regcache.h: Rename include guard.
902         * common/common-inferior.h: Rename include guard.
903         * common/common-gdbthread.h: Rename include guard.
904         * common/common-exceptions.h: Rename include guard.
905         * common/common-defs.h: Rename include guard.
906         * common/common-debug.h: Rename include guard.
907         * common/cleanups.h: Rename include guard.
908         * common/buffer.h: Rename include guard.
909         * common/btrace-common.h: Rename include guard.
910         * common/break-common.h: Rename include guard.
911         * cli/cli-utils.h: Rename include guard.
912         * cli/cli-style.h: Rename include guard.
913         * cli/cli-setshow.h: Rename include guard.
914         * cli/cli-script.h: Rename include guard.
915         * cli/cli-interp.h: Rename include guard.
916         * cli/cli-decode.h: Rename include guard.
917         * cli/cli-cmds.h: Rename include guard.
918         * charset-list.h: Add include guard.
919         * buildsym-legacy.h: Rename include guard.
920         * bfin-tdep.h: Add include guard.
921         * ax.h: Rename include guard.
922         * arm-linux-tdep.h: Add include guard.
923         * arm-fbsd-tdep.h: Add include guard.
924         * arch/xtensa.h: Rename include guard.
925         * arch/tic6x.h: Add include guard.
926         * arch/i386.h: Add include guard.
927         * arch/arm.h: Rename include guard.
928         * arch/arm-linux.h: Rename include guard.
929         * arch/arm-get-next-pcs.h: Rename include guard.
930         * arch/amd64.h: Add include guard.
931         * arch/aarch64-insn.h: Rename include guard.
932         * arch-utils.h: Rename include guard.
933         * annotate.h: Add include guard.
934         * amd64-darwin-tdep.h: Rename include guard.
935         * aarch64-linux-tdep.h: Add include guard.
936         * aarch64-fbsd-tdep.h: Add include guard.
937         * aarch32-linux-nat.h: Add include guard.
938
939 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
940
941         * macrotab.c (macro_define_internal): New function that
942         factorizes macro_define_object_internal and macro_define_function
943         code.
944         (macro_define_object_internal): Use macro_define_internal.
945         (macro_define_function): Likewise.
946
947 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
948
949         * macrocmd.c (extract_identifier): Return
950         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
951         callers.
952
953 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
954
955         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
956
957 2019-02-05  Tom Tromey  <tom@tromey.com>
958
959         * target.c (target_stack::unpush): Move assertion earlier.
960
961 2019-01-30  Tom Tromey  <tom@tromey.com>
962
963         PR python/23615:
964         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
965         (gdbpy_parse_and_eval): Likewise.
966         * python/python-internal.h (gdbpy_allow_threads): New class.
967
968 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
969
970         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
971         (aarch64_fbsd_fpregmap): Move earlier.
972         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
973         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
974         instead of individual calls to trad_frame_set_reg_addr.
975         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
976         earlier.
977         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
978         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
979         instead of individual calls to trad_frame_set_reg_addr.
980
981 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
982
983         * CONTRIBUTE: Replace contribution list with wiki link.
984
985 2019-01-25  Tom Tromey  <tom@tromey.com>
986
987         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
988
989 2019-01-25  Tom Tromey  <tom@tromey.com>
990
991         * xtensa-linux-nat.c: Fix common/ includes.
992         * xml-support.h: Fix common/ includes.
993         * xml-support.c: Fix common/ includes.
994         * x86-linux-nat.c: Fix common/ includes.
995         * windows-nat.c: Fix common/ includes.
996         * varobj.h: Fix common/ includes.
997         * varobj.c: Fix common/ includes.
998         * value.c: Fix common/ includes.
999         * valops.c: Fix common/ includes.
1000         * utils.c: Fix common/ includes.
1001         * unittests/xml-utils-selftests.c: Fix common/ includes.
1002         * unittests/utils-selftests.c: Fix common/ includes.
1003         * unittests/unpack-selftests.c: Fix common/ includes.
1004         * unittests/tracepoint-selftests.c: Fix common/ includes.
1005         * unittests/style-selftests.c: Fix common/ includes.
1006         * unittests/string_view-selftests.c: Fix common/ includes.
1007         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1008         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1009         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1010         * unittests/rsp-low-selftests.c: Fix common/ includes.
1011         * unittests/parse-connection-spec-selftests.c: Fix common/
1012         includes.
1013         * unittests/optional-selftests.c: Fix common/ includes.
1014         * unittests/offset-type-selftests.c: Fix common/ includes.
1015         * unittests/observable-selftests.c: Fix common/ includes.
1016         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1017         * unittests/memrange-selftests.c: Fix common/ includes.
1018         * unittests/memory-map-selftests.c: Fix common/ includes.
1019         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1020         * unittests/function-view-selftests.c: Fix common/ includes.
1021         * unittests/environ-selftests.c: Fix common/ includes.
1022         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1023         * unittests/common-utils-selftests.c: Fix common/ includes.
1024         * unittests/cli-utils-selftests.c: Fix common/ includes.
1025         * unittests/array-view-selftests.c: Fix common/ includes.
1026         * ui-file.c: Fix common/ includes.
1027         * tui/tui-io.c: Fix common/ includes.
1028         * tracepoint.h: Fix common/ includes.
1029         * tracepoint.c: Fix common/ includes.
1030         * tracefile-tfile.c: Fix common/ includes.
1031         * top.h: Fix common/ includes.
1032         * top.c: Fix common/ includes.
1033         * thread.c: Fix common/ includes.
1034         * target/waitstatus.h: Fix common/ includes.
1035         * target/waitstatus.c: Fix common/ includes.
1036         * target.h: Fix common/ includes.
1037         * target.c: Fix common/ includes.
1038         * target-memory.c: Fix common/ includes.
1039         * target-descriptions.c: Fix common/ includes.
1040         * symtab.h: Fix common/ includes.
1041         * symfile.c: Fix common/ includes.
1042         * stap-probe.c: Fix common/ includes.
1043         * spu-linux-nat.c: Fix common/ includes.
1044         * sparc-nat.c: Fix common/ includes.
1045         * source.c: Fix common/ includes.
1046         * solib.c: Fix common/ includes.
1047         * solib-target.c: Fix common/ includes.
1048         * ser-unix.c: Fix common/ includes.
1049         * ser-tcp.c: Fix common/ includes.
1050         * ser-pipe.c: Fix common/ includes.
1051         * ser-base.c: Fix common/ includes.
1052         * selftest-arch.c: Fix common/ includes.
1053         * s12z-tdep.c: Fix common/ includes.
1054         * rust-exp.y: Fix common/ includes.
1055         * rs6000-aix-tdep.c: Fix common/ includes.
1056         * riscv-tdep.c: Fix common/ includes.
1057         * remote.c: Fix common/ includes.
1058         * remote-notif.h: Fix common/ includes.
1059         * remote-fileio.h: Fix common/ includes.
1060         * remote-fileio.c: Fix common/ includes.
1061         * regcache.h: Fix common/ includes.
1062         * regcache.c: Fix common/ includes.
1063         * record-btrace.c: Fix common/ includes.
1064         * python/python.c: Fix common/ includes.
1065         * python/py-type.c: Fix common/ includes.
1066         * python/py-inferior.c: Fix common/ includes.
1067         * progspace.h: Fix common/ includes.
1068         * producer.c: Fix common/ includes.
1069         * procfs.c: Fix common/ includes.
1070         * proc-api.c: Fix common/ includes.
1071         * printcmd.c: Fix common/ includes.
1072         * ppc-linux-nat.c: Fix common/ includes.
1073         * parser-defs.h: Fix common/ includes.
1074         * osdata.c: Fix common/ includes.
1075         * obsd-nat.c: Fix common/ includes.
1076         * nat/x86-linux.c: Fix common/ includes.
1077         * nat/x86-linux-dregs.c: Fix common/ includes.
1078         * nat/x86-dregs.h: Fix common/ includes.
1079         * nat/x86-dregs.c: Fix common/ includes.
1080         * nat/ppc-linux.c: Fix common/ includes.
1081         * nat/mips-linux-watch.h: Fix common/ includes.
1082         * nat/mips-linux-watch.c: Fix common/ includes.
1083         * nat/linux-waitpid.c: Fix common/ includes.
1084         * nat/linux-ptrace.h: Fix common/ includes.
1085         * nat/linux-ptrace.c: Fix common/ includes.
1086         * nat/linux-procfs.c: Fix common/ includes.
1087         * nat/linux-personality.c: Fix common/ includes.
1088         * nat/linux-osdata.c: Fix common/ includes.
1089         * nat/linux-namespaces.c: Fix common/ includes.
1090         * nat/linux-btrace.h: Fix common/ includes.
1091         * nat/linux-btrace.c: Fix common/ includes.
1092         * nat/fork-inferior.c: Fix common/ includes.
1093         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1094         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1095         * nat/aarch64-linux.c: Fix common/ includes.
1096         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1097         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1098         * namespace.h: Fix common/ includes.
1099         * mips-linux-tdep.c: Fix common/ includes.
1100         * minsyms.c: Fix common/ includes.
1101         * mi/mi-parse.h: Fix common/ includes.
1102         * mi/mi-main.c: Fix common/ includes.
1103         * mi/mi-cmd-env.c: Fix common/ includes.
1104         * memrange.h: Fix common/ includes.
1105         * memattr.c: Fix common/ includes.
1106         * maint.h: Fix common/ includes.
1107         * maint.c: Fix common/ includes.
1108         * main.c: Fix common/ includes.
1109         * machoread.c: Fix common/ includes.
1110         * location.c: Fix common/ includes.
1111         * linux-thread-db.c: Fix common/ includes.
1112         * linux-nat.c: Fix common/ includes.
1113         * linux-fork.c: Fix common/ includes.
1114         * inline-frame.c: Fix common/ includes.
1115         * infrun.c: Fix common/ includes.
1116         * inflow.c: Fix common/ includes.
1117         * inferior.h: Fix common/ includes.
1118         * inferior.c: Fix common/ includes.
1119         * infcmd.c: Fix common/ includes.
1120         * inf-ptrace.c: Fix common/ includes.
1121         * inf-child.c: Fix common/ includes.
1122         * ia64-linux-nat.c: Fix common/ includes.
1123         * i387-tdep.c: Fix common/ includes.
1124         * i386-tdep.c: Fix common/ includes.
1125         * i386-linux-tdep.c: Fix common/ includes.
1126         * i386-linux-nat.c: Fix common/ includes.
1127         * i386-go32-tdep.c: Fix common/ includes.
1128         * i386-fbsd-tdep.c: Fix common/ includes.
1129         * i386-fbsd-nat.c: Fix common/ includes.
1130         * guile/scm-type.c: Fix common/ includes.
1131         * guile/guile.c: Fix common/ includes.
1132         * go32-nat.c: Fix common/ includes.
1133         * gnu-nat.c: Fix common/ includes.
1134         * gdbthread.h: Fix common/ includes.
1135         * gdbarch-selftests.c: Fix common/ includes.
1136         * gdb_usleep.c: Fix common/ includes.
1137         * gdb_select.h: Fix common/ includes.
1138         * gdb_bfd.c: Fix common/ includes.
1139         * gcore.c: Fix common/ includes.
1140         * fork-child.c: Fix common/ includes.
1141         * findvar.c: Fix common/ includes.
1142         * fbsd-nat.c: Fix common/ includes.
1143         * event-top.c: Fix common/ includes.
1144         * event-loop.c: Fix common/ includes.
1145         * dwarf2read.c: Fix common/ includes.
1146         * dwarf2loc.c: Fix common/ includes.
1147         * dwarf2-frame.c: Fix common/ includes.
1148         * dwarf-index-cache.c: Fix common/ includes.
1149         * dtrace-probe.c: Fix common/ includes.
1150         * disasm-selftests.c: Fix common/ includes.
1151         * defs.h: Fix common/ includes.
1152         * csky-tdep.c: Fix common/ includes.
1153         * cp-valprint.c: Fix common/ includes.
1154         * cp-support.h: Fix common/ includes.
1155         * cp-support.c: Fix common/ includes.
1156         * corelow.c: Fix common/ includes.
1157         * completer.h: Fix common/ includes.
1158         * completer.c: Fix common/ includes.
1159         * compile/compile.c: Fix common/ includes.
1160         * compile/compile-loc2c.c: Fix common/ includes.
1161         * compile/compile-cplus-types.c: Fix common/ includes.
1162         * compile/compile-cplus-symbols.c: Fix common/ includes.
1163         * command.h: Fix common/ includes.
1164         * cli/cli-dump.c: Fix common/ includes.
1165         * cli/cli-cmds.c: Fix common/ includes.
1166         * charset.c: Fix common/ includes.
1167         * build-id.c: Fix common/ includes.
1168         * btrace.h: Fix common/ includes.
1169         * btrace.c: Fix common/ includes.
1170         * breakpoint.h: Fix common/ includes.
1171         * breakpoint.c: Fix common/ includes.
1172         * ax.h: 
1173         (enum agent_op): Fix common/ includes.
1174         * ax-general.c (struct aop_map): Fix common/ includes.
1175         * ax-gdb.c: Fix common/ includes.
1176         * auxv.c: Fix common/ includes.
1177         * auto-load.c: Fix common/ includes.
1178         * arm-tdep.c: Fix common/ includes.
1179         * arch/riscv.c: Fix common/ includes.
1180         * arch/ppc-linux-common.c: Fix common/ includes.
1181         * arch/i386.c: Fix common/ includes.
1182         * arch/arm.c: Fix common/ includes.
1183         * arch/arm-linux.c: Fix common/ includes.
1184         * arch/arm-get-next-pcs.c: Fix common/ includes.
1185         * arch/amd64.c: Fix common/ includes.
1186         * arch/aarch64.c: Fix common/ includes.
1187         * arch/aarch64-insn.c: Fix common/ includes.
1188         * arch-utils.c: Fix common/ includes.
1189         * amd64-windows-tdep.c: Fix common/ includes.
1190         * amd64-tdep.c: Fix common/ includes.
1191         * amd64-sol2-tdep.c: Fix common/ includes.
1192         * amd64-obsd-tdep.c: Fix common/ includes.
1193         * amd64-nbsd-tdep.c: Fix common/ includes.
1194         * amd64-linux-tdep.c: Fix common/ includes.
1195         * amd64-linux-nat.c: Fix common/ includes.
1196         * amd64-fbsd-tdep.c: Fix common/ includes.
1197         * amd64-fbsd-nat.c: Fix common/ includes.
1198         * amd64-dicos-tdep.c: Fix common/ includes.
1199         * amd64-darwin-tdep.c: Fix common/ includes.
1200         * agent.c: Fix common/ includes.
1201         * ada-lang.h: Fix common/ includes.
1202         * ada-lang.c: Fix common/ includes.
1203         * aarch64-tdep.c: Fix common/ includes.
1204
1205 2019-01-25  Tom Tromey  <tom@tromey.com>
1206
1207         * common/create-version.sh: Use common/version.h.
1208
1209 2019-01-24  Pedro Alves  <palves@redhat.com>
1210
1211         * infrun.c (signal_stop, signal_print, signal_program)
1212         (signal_catch, signal_pass): Now arrays instead of pointers.
1213         (update_signals_program_target, do_target_resume)
1214         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1215         * linux-nat.c (linux_nat_target::pass_signals)
1216         (linux_nat_target::create_inferior, linux_nat_target::attach):
1217         Adjust.
1218         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1219         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1220         * procfs.c (procfs_target::pass_signals): Adjust.
1221         * record-full.c (record_full_target::resume): Adjust.
1222         * remote.c (remote_target::pass_signals)
1223         (remote_target::program_signals): Adjust.
1224         * target-debug.h (target_debug_print_signals): Now takes a
1225         gdb::array_view as parameter.  Adjust.
1226         * target.h (target_ops) <pass_signals, program_signals>: Replace
1227         pointer and length parameters with gdb::array_view.
1228         (target_pass_signals, target_program_signals): Likewise.
1229         * target-delegates.c: Regenerate.
1230
1231 2019-01-24  Pedro Alves  <palves@redhat.com>
1232
1233         * common/forward-scope-exit.h
1234         (forward_scope_exit::forward_scope_exit): Pass arguments to
1235         m_bind_function directly, instead of creating a std::bind and
1236         copying that.
1237
1238 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1239
1240         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1241         for static members.
1242         (pass_in_v_vfp_candidate): Likewise.
1243
1244 2019-01-23  Tom Tromey  <tom@tromey.com>
1245             Pedro Alves  <palves@redhat.com>
1246
1247         * regcache.c (class regcache_invalidator): Remove.
1248         (regcache::raw_write): Use make_scope_exit.
1249
1250 2019-01-23  Tom Tromey  <tom@tromey.com>
1251
1252         * ui-out.h (class ui_out_emit_type): Update comment.
1253
1254 2019-01-23  Tom Tromey  <tom@tromey.com>
1255
1256         * infrun.c (fetch_inferior_event): Update comment.
1257
1258 2019-01-23  Tom Tromey  <tom@tromey.com>
1259             Pedro Alves  <palves@redhat.com>
1260
1261         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1262         parameter.
1263         (fetch_inferior_event): Use SCOPE_EXIT.
1264
1265
1266 2019-01-23  Tom Tromey  <tom@tromey.com>
1267             Pedro Alves  <palves@redhat.com>
1268
1269         * infrun.c (disable_thread_events): Delete.
1270         (stop_all_threads): Use SCOPE_EXIT.
1271
1272 2019-01-23  Tom Tromey  <tom@tromey.com>
1273             Pedro Alves  <palves@redhat.com>
1274
1275         * symfile.c: Include forward-scope-exit.h.
1276         (clear_symtab_users_cleanup): Replace forward declaration with
1277         a FORWARD_SCOPE_EXIT.
1278         (syms_from_objfile_1): Use the forward_scope_exit and
1279         gdb::optional instead of cleanup_function.
1280         (reread_symbols): Use the forward_scope_exit instead of
1281         cleanup_function.
1282         (clear_symtab_users_cleanup): Remove function.
1283
1284 2019-01-23  Tom Tromey  <tom@tromey.com>
1285             Pedro Alves  <palves@redhat.com>
1286
1287         * linux-nat.c: Include scope-exit.h.
1288         (cleanup_target_stop): Remove.
1289         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1290         SCOPE_EXIT.
1291
1292 2019-01-23  Tom Tromey  <tom@tromey.com>
1293             Pedro Alves  <palves@redhat.com>
1294
1295         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1296         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1297
1298 2019-01-23  Tom Tromey  <tom@tromey.com>
1299             Andrew Burgess  <andrew.burgess@embecosm.com>
1300             Pedro Alves  <palves@redhat.com>
1301
1302         * infrun.c (fetch_inferior_event): Use scope_exit.
1303         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1304         * top.c (execute_command): Use scope_exit.
1305         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1306         * utils.c (do_bpstat_clear_actions_cleanup)
1307         (make_bpstat_clear_actions_cleanup): Remove.
1308
1309 2019-01-23  Tom Tromey  <tom@tromey.com>
1310             Pedro Alves  <palves@redhat.com>
1311
1312         * infrun.c: Include "common/scope-exit.h"
1313         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1314         (wait_for_inferior): Use SCOPE_EXIT.
1315         (fetch_inferior_event): Use scope_exit.
1316
1317 2019-01-23  Tom Tromey  <tom@tromey.com>
1318             Pedro Alves  <palves@redhat.com>
1319
1320         * breakpoint.c (create_breakpoint): Remove cleanup.
1321
1322 2019-01-23  Tom Tromey  <tom@tromey.com>
1323             Andrew Burgess  <andrew.burgess@embecosm.com>
1324             Pedro Alves  <palves@redhat.com>
1325
1326 2019-01-23  Pedro Alves  <palves@redhat.com>
1327
1328         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1329
1330 2019-01-23  Pedro Alves  <palves@redhat.com>
1331             Andrew Burgess  <andrew.burgess@embecosm.com>
1332
1333         * gdbthread.h: Include "common/forward-scope-exit.h".
1334         (scoped_finish_thread_state): Redefine custom class in terms of
1335         forward_scope_exit.
1336
1337 2019-01-23  Pedro Alves  <palves@redhat.com>
1338             Andrew Burgess  <andrew.burgess@embecosm.com>
1339
1340         * common/forward-scope-exit.h: New file.
1341
1342 2019-01-23  Pedro Alves  <palves@redhat.com>
1343             Andrew Burgess  <andrew.burgess@embecosm.com>
1344             Tom Tromey  <tom@tromey.com>
1345
1346         * common/scope-exit.h: New file.
1347
1348 2019-01-23  Pedro Alves  <palves@redhat.com>
1349
1350         * common/preprocessor.h (ESC): Rename to ...
1351         (ESC_PARENS): ... this.
1352         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1353         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1354
1355 2019-01-23  Tom Tromey  <tom@tromey.com>
1356
1357         * language.h (class scoped_switch_to_sym_language_if_auto):
1358         Initialize m_lang in both cases.
1359
1360 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1361
1362         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1363         with XCNEW.
1364
1365 2019-01-22  Tom Tromey  <tom@tromey.com>
1366
1367         * corelow.c: Do not include sys/file.h.
1368
1369 2019-01-22  Tom Tromey  <tom@tromey.com>
1370
1371         * tui/tui-wingeneral.h: Include gdb_curses.h.
1372
1373 2019-01-22  Tom Tromey  <tom@tromey.com>
1374
1375         * source-cache.h (class source_cache) <get_source_lines,
1376         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1377
1378 2019-01-22  Tom Tromey  <tom@tromey.com>
1379
1380         * remote-fileio.h (struct remote_target): Declare.
1381
1382 2019-01-22  Tom Tromey  <tom@tromey.com>
1383
1384         * python/py-arch.c: Do not include py-ref.h.
1385         * python/py-bpevent.c: Do not include py-ref.h.
1386         * python/py-cmd.c: Do not include py-ref.h.
1387         * python/py-continueevent.c: Do not include py-ref.h.
1388         * python/py-event.h: Do not include py-ref.h.
1389         * python/py-evtregistry.c: Do not include py-ref.h.
1390         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1391         * python/py-frame.c: Do not include py-ref.h.
1392         * python/py-framefilter.c: Do not include py-ref.h.
1393         * python/py-function.c: Do not include py-ref.h.
1394         * python/py-infevents.c: Do not include py-ref.h.
1395         * python/py-linetable.c: Do not include py-ref.h.
1396         * python/py-objfile.c: Do not include py-ref.h.
1397         * python/py-param.c: Do not include py-ref.h.
1398         * python/py-prettyprint.c: Do not include py-ref.h.
1399         * python/py-progspace.c: Do not include py-ref.h.
1400         * python/py-symbol.c: Do not include py-ref.h.
1401         * python/py-symtab.c: Do not include py-ref.h.
1402         * python/py-type.c: Do not include py-ref.h.
1403         * python/py-unwind.c: Do not include py-ref.h.
1404         * python/py-utils.c: Do not include py-ref.h.
1405         * python/py-value.c: Do not include py-ref.h.
1406         * python/py-varobj.c: Do not include py-ref.h.
1407         * python/py-xmethods.c: Do not include py-ref.h.
1408         * python/python.c: Do not include py-ref.h.
1409         * varobj.c: Do not include py-ref.h.
1410
1411 2019-01-22  Tom Tromey  <tom@tromey.com>
1412
1413         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1414         keyword for bcache.
1415
1416 2019-01-22  Tom Tromey  <tom@tromey.com>
1417
1418         * compile/compile-cplus-types.c: Remove a comment by #include.
1419
1420 2019-01-22  Tom Tromey  <tom@tromey.com>
1421
1422         * compile/gcc-c-plugin.h: Include compile-internal.h.
1423
1424 2019-01-22  Tom Tromey  <tom@tromey.com>
1425
1426         * stabsread.c (EXTERN): Do not define.
1427         (symnum, next_symbol_text_func, processing_gcc_compilation)
1428         (within_function, global_sym_chain, global_stabs)
1429         (previous_stab_code, this_object_header_files)
1430         (n_this_object_header_files)
1431         (n_allocated_this_object_header_files): Define.
1432         * stabsread.h (EXTERN): Never define.  Use "extern".
1433
1434 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1435
1436         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1437         history_value.
1438
1439 2019-01-21  Tom Tromey  <tom@tromey.com>
1440
1441         * ui-out.c: Fix includes.
1442         * tui/tui-source.c: Fix includes.
1443         * target.c: Fix includes.
1444         * remote.c: Fix includes.
1445         * regcache.c: Fix includes.
1446         * python/py-block.c: Fix includes.
1447         * printcmd.c: Fix includes.
1448         * or1k-tdep.c: Fix includes.
1449         * mi/mi-main.c: Fix includes.
1450         * m32r-tdep.c: Fix includes.
1451         * csky-tdep.c: Fix includes.
1452         * compile/compile-cplus-types.c: Fix includes.
1453         * cli/cli-interp.c: Fix includes.
1454
1455 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1456
1457         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1458         for padding.
1459
1460 2019-01-16  Tom Tromey  <tom@tromey.com>
1461
1462         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1463         earlier.
1464         (struct objfile) <msymbols_range>: Move from top level.
1465         <msymbols>: New method.
1466         (class objfile_msymbols): Remove.
1467         * symtab.c (default_collect_symbol_completion_matches_break_on):
1468         Update.
1469         * symmisc.c (dump_msymbols): Update.
1470         * stabsread.c (scan_file_globals): Update.
1471         * objc-lang.c (info_selectors_command, info_classes_command)
1472         (find_methods): Update.
1473         * minsyms.c (find_solib_trampoline_target): Update.
1474         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1475         * coffread.c (coff_symfile_read): Update.
1476         * ada-lang.c (ada_lookup_simple_minsym)
1477         (ada_collect_symbol_completion_matches): Update.
1478
1479 2019-01-16  Tom Tromey  <tom@tromey.com>
1480
1481         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1482         type.  Remove no-argument constructor.
1483         <iterator::operator++>: Simplify.
1484         <begin>: Update.
1485         <end>: Use minimal_symbol_count.
1486
1487 2019-01-16  Tom Tromey  <tom@tromey.com>
1488
1489         * objfiles.h (struct objfile) <psymtabs>: New method.
1490         (class objfile_psymtabs): Remove.
1491         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1492         typedef.
1493         <range>: New method.
1494         (require_partial_symbols): Change return type.
1495         * psymtab.c (require_partial_symbols)
1496         (psym_expand_symtabs_matching): Update.
1497         * mdebugread.c (parse_partial_symbols): Update.
1498         * dbxread.c (dbx_end_psymtab): Update.
1499
1500 2019-01-15  Tom Tromey  <tom@tromey.com>
1501
1502         * symtab.c (lookup_objfile_from_block)
1503         (lookup_symbol_in_objfile_symtabs)
1504         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1505         (find_line_symtab, info_sources_command)
1506         (default_collect_symbol_completion_matches_break_on)
1507         (make_source_files_completion_list): Update.
1508         * symmisc.c (print_objfile_statistics, dump_objfile)
1509         (maintenance_print_symbols, maintenance_info_symtabs)
1510         (maintenance_check_symtabs, maintenance_info_line_tables):
1511         Update.
1512         * source.c (select_source_symtab)
1513         (forget_cached_source_info_for_objfile): Update.
1514         * objfiles.h (class objfile_compunits): Remove.
1515         (struct objfile) <compunits_range>: New typedef.
1516         (compunits): New method.
1517         * objfiles.c (objfile_relocate1): Update.
1518         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1519         * maint.c (count_symtabs_and_blocks): Update.
1520         * linespec.c (iterate_over_all_matching_symtabs): Update.
1521         * cp-support.c (add_symbol_overload_list_qualified): Update.
1522         * coffread.c (coff_symtab_read): Update.
1523         * ada-lang.c (add_nonlocal_symbols)
1524         (ada_collect_symbol_completion_matches)
1525         (ada_add_global_exceptions): Update.
1526
1527 2019-01-15  Tom Tromey  <tom@tromey.com>
1528
1529         * progspace.h (program_space) <objfiles_safe_range>: New
1530         typedef.
1531         <objfiles_safe>: New method.
1532         * objfiles.h (class all_objfiles_safe): Remove.
1533         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1534         * jit.c (jit_inferior_exit_hook): Update.
1535
1536 2019-01-17  Tom Tromey  <tom@tromey.com>
1537
1538         * progspace.h (program_space) <objfiles_range>: New typedef.
1539         <objfiles>: New method.
1540         <objfiles_head>: Rename from objfiles.
1541         (object_files): Update.
1542         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1543         * guile/scm-pretty-print.c
1544         (ppscm_find_pretty_printer_from_objfiles): Update.
1545         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1546         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1547         Update.
1548         * python/py-progspace.c (pspy_get_objfiles): Update.
1549         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1550         Update.
1551         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1552         (objfpy_lookup_objfile_by_build_id): Update.
1553         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1554         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1555         Update.
1556         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1557         (expand_symtab_containing_pc, lookup_objfile_from_block)
1558         (lookup_static_symbol, basic_lookup_transparent_type)
1559         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1560         (find_line_symtab, info_sources_command)
1561         (default_collect_symbol_completion_matches_break_on)
1562         (make_source_files_completion_list, find_main_name): Update.
1563         * symmisc.c (print_symbol_bcache_statistics)
1564         (print_objfile_statistics, maintenance_print_symbols)
1565         (maintenance_print_msymbols, maintenance_print_objfiles)
1566         (maintenance_info_symtabs, maintenance_check_symtabs)
1567         (maintenance_expand_symtabs, maintenance_info_line_tables):
1568         Update.
1569         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1570         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1571         (map_overlay_command, unmap_overlay_command)
1572         (simple_overlay_update, expand_symtabs_matching)
1573         (map_symbol_filenames): Update.
1574         * symfile-debug.c (set_debug_symfile): Update.
1575         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1576         Update.
1577         * source.c (select_source_symtab, forget_cached_source_info):
1578         Update.
1579         * solib.c (solib_read_symbols): Update.
1580         * solib-spu.c (append_ocl_sos): Update.
1581         * psymtab.c (maintenance_print_psymbols)
1582         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1583         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1584         * printcmd.c (info_symbol_command): Update.
1585         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1586         Update.
1587         * objfiles.h (class all_objfiles): Remove.
1588         * objfiles.c (have_partial_symbols, have_full_symbols)
1589         (have_minimal_symbols, qsort_cmp, update_section_map)
1590         (shared_objfile_contains_address_p)
1591         (default_iterate_over_objfiles_in_search_order): Update.
1592         * objc-lang.c (info_selectors_command, info_classes_command)
1593         (find_methods): Update.
1594         * minsyms.c (find_solib_trampoline_target): Update.
1595         * maint.c (maintenance_info_sections)
1596         (maintenance_translate_address, count_symtabs_and_blocks):
1597         Update.
1598         * main.c (captured_main_1): Update.
1599         * linux-thread-db.c (try_thread_db_load_from_pdir)
1600         (has_libpthread): Update.
1601         * linespec.c (iterate_over_all_matching_symtabs)
1602         (search_minsyms_for_name): Update.
1603         * jit.c (jit_find_objf_with_entry_addr): Update.
1604         * hppa-tdep.c (find_unwind_entry)
1605         (hppa_lookup_stub_minimal_symbol): Update.
1606         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1607         Update.
1608         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1609         (elf_gnu_ifunc_resolve_by_got): Update.
1610         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1611         * dwarf-index-write.c (save_gdb_index_command): Update.
1612         * cp-support.c (add_symbol_overload_list_qualified): Update.
1613         * breakpoint.c (create_overlay_event_breakpoint)
1614         (create_longjmp_master_breakpoint)
1615         (create_std_terminate_master_breakpoint)
1616         (create_exception_master_breakpoint): Update.
1617         * blockframe.c (find_pc_partial_function): Update.
1618         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1619         (ada_collect_symbol_completion_matches)
1620         (ada_add_global_exceptions): Update.
1621
1622 2019-01-17  Tom Tromey  <tom@tromey.com>
1623
1624         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1625         declare VEC.
1626         (solib_target_parse_libraries): Change return type.
1627         (library_list_start_segment, library_list_start_section)
1628         (library_list_end_library, library_list_start_library); Update.
1629         (solib_target_free_library_list): Remove.
1630         (solib_target_parse_libraries): Remove cleanup.  Change return
1631         type.
1632         (solib_target_current_sos): Update.
1633
1634 2019-01-17  Tom Tromey  <tromey@bapiya>
1635
1636         * valprint.c: Replace "the the" with "the".
1637         * symtab.c: Replace "the the" with "the".
1638         * solib.c: Replace "the the" with "the".
1639         * solib-dsbt.c: Replace "the the" with "the".
1640         * linespec.c: Replace "the the" with "the".
1641         * dwarf2loc.h: Replace "the the" with "the".
1642         * amd64-windows-tdep.c: Replace "the the" with "the".
1643         * aarch64-tdep.c: Replace "the the" with "the".
1644
1645 2019-01-16  Keith Seitz  <keiths@redhat.com>
1646
1647         PR gdb/23773
1648         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1649         <builder>: Rename to ..
1650         <m_builder>: ... this and make private.
1651         (dwarf2_cu::get_builder): New method.  Change all users of
1652         `builder' to use this method.
1653         (dwarf2_start_symtab): Move to ...
1654         (dwarf2_cu::start_symtab): ... here.  Update all callers
1655         (setup_type_unit_groups): Move to ...
1656         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1657         callers.
1658         (dwarf2_cu::reset_builder): New method.
1659         (process_full_compunit, process_full_type_unit): Use
1660         dwarf2_cu::reset_builder.
1661         (follow_die_offset): Record the ancestor CU if it is different
1662         from the followed DIE's CU.
1663         (follow_die_sig_1): Likewise.
1664
1665 2019-01-15  Tom Tromey  <tom@tromey.com>
1666
1667         * remote.c (class remote_state) <buf>: Now a char_vector.
1668         <buf_size>: Remove.
1669         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1670         parameter.
1671         (remote_target::getpkt_or_notif_sane_1)
1672         (remote_target::getpkt_sane)
1673         (remote_target::getpkt_or_notif_sane): Likewise.
1674         (class remote_target) <putpkt>: New overload.
1675         (remote_target::read_frame): Change type of "buf_p".  Remove
1676         sizeof_p parameter.
1677         (packet_ok): New overload.
1678         (packet_check_result): New overload.
1679         Update all uses.
1680
1681 2019-01-14  Tom Tromey  <tom@tromey.com>
1682
1683         * remote-notif.c (handle_notification, remote_notif_ack)
1684         (remote_notif_parse): Make "buf" const.
1685         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1686         const.
1687         (remote_notif_parse, remote_notif_ack, handle_notification):
1688         Likewise.
1689         * remote.c (remote_notif_stop_parse): Make "buf" const.
1690         (remote_target::remote_parse_stop_reply): Make "buf" const.
1691         (remote_notif_stop_ack): Make "buf" const.
1692
1693 2019-01-14  Tom Tromey  <tom@tromey.com>
1694
1695         * remote.c (remote_console_output): Make parameter const.
1696
1697 2019-01-14  Tom Tromey  <tom@tromey.com>
1698
1699         * target-debug.h (target_debug_print_signals): Constify.
1700         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1701         * procfs.c (procfs_target::pass_signals): Update.
1702         * linux-nat.c (linux_nat_target::pass_signals): Update.
1703         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1704         * target-delegates.c: Rebuild.
1705         * remote.c (remote_target::program_signals): Update.
1706         (remote_target::pass_signals): Update.
1707         * target.c (target_pass_signals): Constify argument.
1708         (target_program_signals): Likewise.
1709         * target.h (struct target_ops) <pass_signals, program_signals>:
1710         Constify argument.
1711         (target_pass_signals, target_program_signals): Constify argument.
1712
1713 2019-01-14  Tom Tromey  <tom@tromey.com>
1714
1715         PR tui/28819:
1716         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1717
1718 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1719
1720         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1721         field.
1722         * rs6000-tdep.c: Include reggroups.h.
1723         (IS_V_ALIAS_PSEUDOREG): Define.
1724         (rs6000_register_name): Return names for the "vX" aliases.
1725         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1726         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1727         aliases.  Call default_register_reggroup_p for all other
1728         pseudo-registers.
1729         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1730         New functions.
1731         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1732         Handle "vX" aliases.
1733         (v_alias_pseudo_register_collect): New function.
1734         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1735         (rs6000_gdbarch_init): Initialize "vX" aliases as
1736         pseudo-registers.  Restore registration of
1737         rs6000_pseudo_register_reggroup_p with
1738         set_tdesc_pseudo_register_reggroup_p.
1739
1740 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1741
1742         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1743         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1744         set_gdbarch_num_pseudo_regs.
1745
1746 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1747
1748         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1749         Remove arg prefixname, add do_set and do_show.
1750         Add member functions set_list and show_list.
1751         * cli/cli-style.c (class cli_style_option): Update accordingly.
1752         (style_set_list): Move to file scope.
1753         (style_show_list): Likewise.
1754         (set_style): Call help_list.
1755         (show_style): Call cmd_show_list.
1756         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1757         Update to use the new macro.
1758
1759 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1760
1761         * ada-lang.c (_initialize_ada_language): Expand the help text
1762         for the "catch exception" command.
1763
1764 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1765
1766         * symtab.c (matching_obj_sections): Initialize obj,
1767         declare it closer to its usage.
1768
1769 2019-01-10  Tom Tromey  <tom@tromey.com>
1770
1771         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1772         (basic_inf_threads_range): Remove.
1773         (inf_threads_range, inf_non_exited_threads_range)
1774         (safe_inf_threads_range): Use next_adapter.
1775
1776 2019-01-10  Keith Seitz  <keiths@redhat.com>
1777
1778         PR gdb/23712
1779         PR symtab/23010
1780         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1781         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1782
1783 2019-01-10  Keith Seitz  <keiths@redhat.com>
1784
1785         PR gdb/23712
1786         PR symtab/23010
1787         * dictionary.c (pending_to_vector): Remove.
1788         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1789         Remove _1 suffix, replacing functions of the same name.  Update
1790         all callers.
1791         (dict_create_hashed, dict_create_hashed_expandable)
1792         (dict_create_linear, dict_create_linear_expandable, dict_free)
1793         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1794         Make functions static.
1795
1796 2019-01-10  Keith Seitz  <keiths@redhat.com>
1797
1798         PR gdb/23712
1799         PR symtab/23010
1800         * dictionary.h (struct dictionary): Replace declaration with
1801         multidictionary.
1802         (dict_create_hashed, dict_create_hashed_expandable)
1803         (dict_create_linear, dict_create_linear_expandable)
1804         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1805         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1806         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1807         taking multidictionary argument.
1808         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1809         * block.h (struct block) <dict>: Change to multidictionary
1810         and rename `multidict'.
1811         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1812         symmisc.c: Update all dictionary references to multidictionary.
1813
1814 2019-01-10  Keith Seitz  <keiths@redhat.com>
1815
1816         PR gdb/23712
1817         PR symtab/23010
1818         * dictionary.c: Include unordered_map.
1819         (pending_to_vector): New function.
1820         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1821         Rewrite the non-"_1" functions to take vector instead
1822         of linked list.
1823         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1824         "new" _1 versions of the same name.
1825         (multidictionary): Define.
1826         (std::hash<enum language): New definition.
1827         (collate_pending_symbols_by_language, mdict_create_hashed)
1828         (mdict_create_hashed_expandable, mdict_create_linear)
1829         (mdict_create_linear_expandable, mdict_free)
1830         (find_language_dictionary, create_new_language_dictionary)
1831         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1832         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1833         (mdict_size, mdict_empty): New functions.
1834         * dictionary.h (mdict_iterator): Define.
1835
1836 2019-01-10  Pedro Alves  <palves@redhat.com>
1837
1838         * breakpoint.c (read_uploaded_action)
1839         (create_tracepoint_from_upload): Adjust to use
1840         gdb::unique_xmalloc_ptr.
1841         * ctf.c (ctf_write_uploaded_tp):
1842         (SET_ARRAY_FIELD): Use emplace_back.
1843         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1844         * tracefile-tfile.c (tfile_write_uploaded_tp):
1845         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1846         gdb::unique_xmalloc_ptr.
1847         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1848         at_string, cond_string, cmd_strings>: Replace char pointers
1849         with gdb::unique_xmalloc_ptr.
1850
1851 2019-01-10  Pedro Alves  <palves@redhat.com>
1852
1853         * solib-target.c (library_list_start_library): Don't xstrdup name.
1854
1855 2019-01-10  Pedro Alves  <palves@redhat.com>
1856
1857         * mdebugread.c (parse_partial_symbols): Use
1858         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1859
1860 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1861
1862         * linux-fork.c (scoped_switch_fork_info)
1863         <~scoped_switch_fork_info>: Fix incorrect variable name.
1864
1865 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1866
1867         * linux-fork.c (scoped_switch_fork_info)
1868         <scoped_switch_fork_info>: Make explicit.
1869         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1870
1871 2019-01-10  Tom Tromey  <tom@tromey.com>
1872
1873         * objfiles.h (objfile::reset_psymtabs): Update.
1874         * objfiles.c (objfile::objfile): Update.
1875         * psymtab.h (psymtab_storage::obstack): Update.
1876         (psymtab_storage::m_obstack): Use gdb::optional.
1877         (class psymtab_storage): Update comment.  Remove objfile
1878         parameter.
1879         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1880
1881 2019-01-10  Tom Tromey  <tom@tromey.com>
1882
1883         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1884         <free_psymtabs>: Now private.
1885         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1886         (allocate_psymtab): Use new method.
1887
1888 2019-01-10  Tom Tromey  <tom@tromey.com>
1889
1890         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1891         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1892         * mdebugread.c (parse_partial_symbols): Use
1893         allocate_dependencies.
1894         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1895         allocate_dependencies.
1896         (process_psymtab_comp_unit_reader)
1897         (build_type_psymtab_dependencies): Likewise.
1898         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1899
1900 2019-01-10  Tom Tromey  <tom@tromey.com>
1901
1902         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1903         PSYMBOL_SET_LANGUAGE.
1904         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1905
1906 2019-01-10  Tom Tromey  <tom@tromey.com>
1907
1908         * psymtab.h (psymtab_storage::obstack): New method.
1909         <m_obstack>: Rename from obstack; now private.
1910         * psymtab.c (psymtab_storage): Update.
1911         * dwarf2read.c (create_addrmap_from_index)
1912         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1913         Update.
1914
1915 2019-01-10  Tom Tromey  <tom@tromey.com>
1916
1917         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1918         * objfiles.h (objfile::reset_psymtabs): New method.
1919
1920 2019-01-10  Tom Tromey  <tom@tromey.com>
1921
1922         * symmisc.c (print_symbol_bcache_statistics): Update.
1923         (print_objfile_statistics): Update.
1924         * symfile.c (reread_symbols): Update.
1925         * psymtab.h (class psymtab_storage): New.
1926         * psymtab.c (psymtab_storage): New constructor.
1927         (~psymtab_storage): New destructor.
1928         (require_partial_symbols): Update.
1929         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1930         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1931         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1932         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1933         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1934         (start_psymtab_common, end_psymtab_common)
1935         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1936         (allocate_psymtab): Update.
1937         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1938         Update.
1939         (dump_psymtab_addrmap, maintenance_print_psymbols)
1940         (maintenance_check_psymtabs): Update.
1941         (class objfile_psymtabs): Move to objfiles.h.
1942         * psympriv.h (discard_psymtab): Now inline.
1943         (psymtab_discarder::psymtab_discarder): Update.
1944         (psymtab_discarder::~psymtab_discarder): Update.
1945         (ALL_OBJFILE_PSYMTABS): Rewrite.
1946         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1947         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1948         Remove fields.
1949         <partial_symtabs>: New field.
1950         (class objfile_psymtabs): Move from psymtab.h.  Update.
1951         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1952         psymbol_cache.
1953         (objfile::~objfile): Don't destroy psymbol_cache.
1954         * mdebugread.c (parse_partial_symbols): Update.
1955         * dwarf2read.c (create_addrmap_from_index)
1956         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1957         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1958         (add_partial_subprogram, dwarf2_ranges_read): Update.
1959         * dwarf-index-write.c (write_address_map)
1960         (write_one_signatured_type, recursively_write_psymbols)
1961         (class debug_names, class debug_names, write_psymtabs_to_index):
1962         Update.
1963
1964 2019-01-10  Tom Tromey  <tom@tromey.com>
1965
1966         * symtab.h (SYMBOL_SET_NAMES): Update.
1967         (symbol_set_names): Update.
1968         (MSYMBOL_SET_NAMES): Update.
1969         * symtab.c (symbol_set_names): Change argument to be an
1970         objfile_per_bfd_storage.
1971         * psymtab.c (add_psymbol_to_bcache): Update.
1972         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1973
1974 2019-01-10  Tom Tromey  <tom@tromey.com>
1975
1976         * symtab.c (create_demangled_names_hash): Change argument to be an
1977         objfile_per_bfd_storage.
1978         (symbol_set_names): Update.
1979
1980 2019-01-10  Tom Tromey  <tom@tromey.com>
1981
1982         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1983         init_psymbol_list.
1984         * psymtab.c (init_psymbol_list): Do nothing if already called.
1985         * psympriv.h (init_psymbol_list): Add comment.
1986         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1987         init_psymbol_list.
1988         * dbxread.c (dbx_symfile_read): Unconditionally call
1989         init_psymbol_list.
1990
1991 2019-01-10  Tom Tromey  <tom@tromey.com>
1992
1993         * xcoffread.c (scan_xcoff_symtab): Update.
1994         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1995         "where".
1996         * mdebugread.c (parse_partial_symbols)
1997         (handle_psymbol_enumerators): Update.
1998         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1999         * dbxread.c (read_dbx_symtab): Update.
2000         * psympriv.h (psymbol_placement): New enum.
2001         (add_psymbol_to_list): Update.
2002
2003 2019-01-10  Tom Tromey  <tom@tromey.com>
2004
2005         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2006         static_psymbols parameters.
2007         (scan_xcoff_symtab): Update.
2008         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2009         static_psymbols parameters.
2010         * psympriv.h (start_psymtab_common): Update.
2011         * mdebugread.c (parse_partial_symbols): Update.
2012         * dwarf2read.c (create_partial_symtab): Update.
2013         * dbxread.c (read_dbx_symtab): Update.
2014         (start_psymtab): Remove global_psymbols and static_psymbols
2015         parameters.
2016
2017 2019-01-10  Tom Tromey  <tom@tromey.com>
2018
2019         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2020         * psymtab.c (allocate_psymtab): Add comment.
2021         * psympriv.h (allocate_psymtab): Add comment.
2022         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2023         initializations.
2024         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2025
2026 2019-01-10  Tom Tromey  <tom@tromey.com>
2027
2028         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2029         Don't declare.
2030         * mipsread.c: Include mdebugread.h.
2031         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2032         Declare.
2033         * elfread.c: Include mdebugread.h.
2034
2035 2019-01-09  Tom Tromey  <tom@tromey.com>
2036
2037         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
2038         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
2039         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
2040         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
2041         (psym_lookup_symbol, psym_find_last_source_symtab)
2042         (psym_forget_cached_source_info, psym_print_stats)
2043         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
2044         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
2045         (psym_map_matching_symbols, psym_expand_symtabs_matching)
2046         (psym_find_compunit_symtab_by_address)
2047         (maintenance_print_psymbols, maintenance_info_psymtabs)
2048         (maintenance_check_psymtabs): Use ranged for.
2049         * psymtab.h (class objfile_psymtabs): New.
2050         (require_partial_symbols): Return objfile_psymtabs.
2051         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
2052
2053 2019-01-09  Tom Tromey  <tom@tromey.com>
2054
2055         * symfile.c (overlay_invalidate_all, find_pc_overlay)
2056         (find_pc_mapped_section, list_overlays_command)
2057         (map_overlay_command, unmap_overlay_command)
2058         (simple_overlay_update): Use all_objfiles.
2059         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
2060         * printcmd.c (info_symbol_command): Use all_objfiles.
2061         * objfiles.h (ALL_OBJSECTIONS): Remove.
2062         * maint.c (maintenance_translate_address): Use all_objfiles.
2063         * gcore.c (gcore_create_callback): Use all_objfiles.
2064         (objfile_find_memory_regions): Likewise.
2065
2066 2019-01-09  Tom Tromey  <tom@tromey.com>
2067
2068         * symtab.c (find_line_symtab, info_sources_command)
2069         (make_source_files_completion_list): Use objfile_compunits.
2070         * source.c (select_source_symtab): Use objfile_compunits.
2071         * objfiles.h (struct objfile): Update comment.
2072         (ALL_OBJFILES): Remove.
2073         (ALL_FILETABS): Remove.
2074         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
2075         objfile_compunits.
2076
2077 2019-01-09  Tom Tromey  <tom@tromey.com>
2078
2079         * symmisc.c (print_objfile_statistics, dump_objfile)
2080         (maintenance_print_symbols): Use compunit_filetabs.
2081         * source.c (forget_cached_source_info_for_objfile): Use
2082         compunit_filetabs.
2083         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
2084         (ALL_FILETABS): Use compunit_filetabs.
2085         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2086         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2087
2088 2019-01-09  Tom Tromey  <tom@tromey.com>
2089
2090         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2091         (compunit_filetabs): New.
2092         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2093         compunit_filetabs.
2094         (info_sources_command, make_source_files_completion_list): Remove
2095         declaration.
2096         * symmisc.c (print_objfile_statistics, dump_objfile)
2097         (maintenance_print_symbols): Remove declaration.
2098         (maintenance_info_symtabs): Use compunit_filetabs.
2099         (maintenance_info_line_tables): Likewise.
2100         * source.c (select_source_symtab): Change local variable name.
2101         (forget_cached_source_info_for_objfile): Remove declaration.
2102         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2103         * objfiles.c (objfile_relocate1): Remove declaration.
2104         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2105         declaration.
2106         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2107         * coffread.c (coff_symtab_read): Remove declaration.
2108         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2109         compunit_filetabs.
2110
2111 2019-01-09  Tom Tromey  <tom@tromey.com>
2112
2113         * symtab.c (lookup_objfile_from_block)
2114         (find_pc_sect_compunit_symtab, search_symbols)
2115         (default_collect_symbol_completion_matches_break_on): Use
2116         objfile_compunits.
2117         * objfiles.h (ALL_COMPUNITS): Remove.
2118         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2119         * cp-support.c (add_symbol_overload_list_qualified): Use
2120         objfile_compunits.
2121         * ada-lang.c (ada_collect_symbol_completion_matches)
2122         (ada_add_global_exceptions): Use objfile_compunits.
2123
2124 2019-01-09  Tom Tromey  <tom@tromey.com>
2125
2126         * source.c (select_source_symtab)
2127         (forget_cached_source_info_for_objfile): Remove declaration.
2128         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2129         declaration.
2130         * maint.c (count_symtabs_and_blocks): Remove declaration.
2131         * cp-support.c (add_symbol_overload_list_qualified): Remove
2132         declaration.
2133         * coffread.c (coff_symtab_read): Remove declaration.
2134         * symtab.c (lookup_symbol_in_objfile_symtabs)
2135         (basic_lookup_transparent_type_1): Use objfile_compunits.
2136         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2137         (info_sources_command, search_symbols)
2138         (default_collect_symbol_completion_matches_break_on)
2139         (make_source_files_completion_list): Remove declaration.
2140         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2141         (ada_collect_symbol_completion_matches)
2142         (ada_add_global_exceptions): Remove declaration.
2143         * linespec.c (iterate_over_all_matching_symtabs): Use
2144         objfile_compunits.
2145         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2146         (class objfile_compunits): New.
2147         (ALL_COMPUNITS): Use objfile_compunits.
2148         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2149         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2150         objfile_compunits.
2151         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2152
2153 2019-01-09  Tom Tromey  <tom@tromey.com>
2154
2155         * symtab.c (search_symbols)
2156         (default_collect_symbol_completion_matches_break_on): Use
2157         objfile_msymbols.
2158         * ada-lang.c (ada_lookup_simple_minsym)
2159         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2160         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2161         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2162         objfile_msymbols.
2163         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2164         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2165         * objc-lang.c (find_methods): Use objfile_msymbols.
2166         (info_selectors_command, info_classes_command): Likewise.
2167         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2168         * objfiles.h (class objfile_msymbols): New.
2169         (ALL_OBJFILE_MSYMBOLS): Remove.
2170         (ALL_MSYMBOLS): Remove.
2171
2172 2019-01-09  Tom Tromey  <tom@tromey.com>
2173
2174         * common/next-iterator.h (next_adapter): Add Iterator template
2175         parameter.
2176         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2177         (class all_objfiles_safe): New.
2178         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2179         * objfiles.c (put_objfile_before): Update comment.
2180         (add_separate_debug_objfile): Likewise.
2181         (free_all_objfiles): Use all_objfiles_safe.
2182         (objfile_purge_solibs): Likewise.
2183
2184 2019-01-09  Tom Tromey  <tom@tromey.com>
2185
2186         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2187         (expand_symtab_containing_pc, lookup_static_symbol)
2188         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2189         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2190         all_objfiles.
2191         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2192         * breakpoint.c (create_overlay_event_breakpoint)
2193         (create_longjmp_master_breakpoint)
2194         (create_std_terminate_master_breakpoint)
2195         (create_exception_master_breakpoint): Use all_objfiles.
2196         * linux-thread-db.c (try_thread_db_load_from_pdir)
2197         (has_libpthread): Use all_objfiles.
2198         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2199         * linespec.c (iterate_over_all_matching_symtabs)
2200         (search_minsyms_for_name): Use all_objfiles.
2201         * maint.c (maintenance_info_sections): Use all_objfiles.
2202         * main.c (captured_main_1): Use all_objfiles.
2203         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2204         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2205         * guile/scm-pretty-print.c
2206         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2207         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2208         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2209         (maintenance_print_msymbols): Use all_objfiles.
2210         * source.c (select_source_symtab): Use all_objfiles.
2211         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2212         * symfile.c (remove_symbol_file_command)
2213         (expand_symtabs_matching, map_symbol_filenames): Use
2214         all_objfiles.
2215         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2216         all_objfiles.
2217         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2218         * objc-lang.c (find_methods): Use all_objfiles.
2219         * objfiles.c (have_partial_symbols, have_full_symbols)
2220         (have_minimal_symbols, qsort_cmp)
2221         (default_iterate_over_objfiles_in_search_order): Use
2222         all_objfiles.
2223         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2224         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2225         (maintenance_check_psymtabs): Use all_objfiles.
2226         (ALL_PSYMTABS): Remove.
2227         * compile/compile-object-run.c (do_module_cleanup): Use
2228         all_objfiles.
2229         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2230         * cp-support.c (add_symbol_overload_list_qualified): Use
2231         all_objfiles.
2232         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2233         Use all_objfiles.
2234         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2235         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2236         all_objfiles.
2237         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2238         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2239         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2240         Uses all_objfiles.
2241         * solib.c (solib_read_symbols): Use all_objfiles
2242
2243 2019-01-09  Tom Tromey  <tom@tromey.com>
2244
2245         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2246         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2247         all_objfiles.
2248         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2249         * symmisc.c (print_symbol_bcache_statistics)
2250         (print_objfile_statistics, maintenance_print_objfiles)
2251         (maintenance_info_symtabs, maintenance_check_symtabs)
2252         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2253         all_objfiles.
2254         * source.c (forget_cached_source_info): Use all_objfiles.
2255         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2256         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2257         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2258         * objfiles.c (update_section_map): Use all_objfiles.
2259         (shared_objfile_contains_address_p): Likewise.
2260         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2261         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2262
2263 2019-01-09  Tom Tromey  <tom@tromey.com>
2264
2265         * common/next-iterator.h: New file.
2266         * objfiles.h (class all_objfiles): New.
2267         (struct objfile_iterator): New.
2268
2269 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2270
2271         * NEWS: Move the description of the changed "frame", "select-frame",
2272          and "info frame" commands to the Changed commands section.
2273
2274 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2275
2276         * gdbtypes.c (check_stub_method_group): Remove handling of old
2277         mangling schemes.
2278         * linespec.c (find_methods): Likewise.
2279         * stabsread.c (read_member_functions): Likewise.
2280         * valops.c (search_struct_method): Likewise.
2281         (value_struct_elt_for_reference): Likewise.
2282         * NEWS: Mention this change.
2283
2284 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2285
2286         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2287         print_source_lines.
2288         * source.c (print_source_lines_base): Update line number check.
2289         (print_source_lines): New function.
2290         (source_lines_range::source_lines_range): New function.
2291         * source.h (class source_lines_range): New class.
2292         (print_source_lines): New declaration.
2293
2294 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2295
2296         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2297
2298 2019-01-08  Tom Tromey  <tom@tromey.com>
2299             Simon Marchi  <simon.marchi@ericsson.com>
2300
2301         PR gdb/24060
2302         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2303         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2304         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2305         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2306         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2307         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2308
2309 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2310
2311         * source.c (select_source_symtab): Move header comment to
2312         declaration in source.h.
2313         (forget_cached_source_info_for_objfile): Likewise.
2314         (forget_cached_source_info): Likewise.
2315         (identify_source_line): Likewise.
2316         * source.h (identify_source_line): Move declaration from symtab.h
2317         and add comment from source.c
2318         (print_source_lines): Likewise.
2319         (forget_cached_source_info_for_objfile): Likewise.
2320         (forget_cached_source_info): Likewise.
2321         (select_source_symtab): Likewise.
2322         (enum print_source_lines_flag): Move definition from symtab.h.
2323         * symtab.h (identify_source_line): Move declaration to source.h.
2324         (print_source_lines): Likewise.
2325         (forget_cached_source_info_for_objfile): Likewise.
2326         (forget_cached_source_info): Likewise.
2327         (select_source_symtab): Likewise.
2328         (enum print_source_lines_flag): Move definition to source.h.
2329         * tui/tui-hooks.c: Add 'source.h' include.
2330
2331 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2332
2333         * source.c (print_source_lines_base): Handle requests to print
2334         reverse line number sequences, and guard against empty lines
2335         string.
2336
2337 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2338
2339         * source.c (print_source_lines_base): Fix skip of '\r' if next
2340         character is '\n'.
2341
2342 2019-01-06  Tom Tromey  <tom@tromey.com>
2343
2344         * c-exp.y (struct c_parse_state) <macro_original_text,
2345         expansion_obstack>: New member.
2346         (macro_original_text, expansion_obstack): Remove globals.
2347         (scan_macro_expansion, scanning_macro_expansion)
2348         (finished_macro_expansion): Update.
2349         (scan_macro_cleanup): Remove.
2350         (yylex, c_parse): Update.
2351
2352 2019-01-06  Tom Tromey  <tom@tromey.com>
2353
2354         * c-exp.y (struct c_parse_state) <strings>: New member.
2355         (operator_stoken): Update.
2356
2357 2019-01-06  Tom Tromey  <tom@tromey.com>
2358
2359         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2360         (union type_stack_elt) <typelist_val>: Now a pointer to
2361         std::vector.
2362         (type_stack_cleanup): Don't declare.
2363         (push_typelist): Update.
2364         * parse.c (pop_typelist): Return a std::vector.
2365         (push_typelist): Take a std::vector.
2366         (follow_types): Update.  Do not free args.
2367         (type_stack_cleanup): Remove.
2368         * c-exp.y (struct c_parse_state): New.
2369         (cpstate): New global.
2370         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2371         (nonempty_typelist): Update.
2372         (func_mod): Create a new vector.
2373         (c_parse): Create a c_parse_state.
2374         (check_parameter_typelist): Do not delete params.
2375         (function_method): Update.  Do not delete type_list.
2376
2377 2019-01-06  Tom Tromey  <tom@tromey.com>
2378
2379         PR gdb/28155:
2380         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2381         check_typedef.
2382         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2383         (print_return_value): Likewise.
2384
2385 2019-01-05  Tom Tromey  <tom@tromey.com>
2386
2387         * contrib/cleanup_check.py: Remove.
2388         * contrib/gcc-with-excheck: Remove.
2389         * contrib/exsummary.py: Remove.
2390         * contrib/excheck.py: Remove.
2391
2392 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2393
2394         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2395         NULL. Initialize tpprev to NULL instead of assigning it
2396         to NULL on the next statement.
2397         * windows-nat.c (windows_delete_thread): Remove check for
2398         main_thread_id before printing thread exit notifications.
2399         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2400         Remove thread ID check against main_thread_id.
2401         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2402         windows_delete_thread.
2403         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2404
2405 2019-01-04  Tom Tromey  <tom@tromey.com>
2406
2407         * compile/compile.c (_initialize_compile): Use upper case for
2408         metasyntactic variables.
2409         * symmisc.c (_initialize_symmisc): Use upper case for
2410         metasyntactic variables.
2411         * psymtab.c (_initialize_psymtab): Use upper case for
2412         metasyntactic variables.
2413         * demangle.c (demangle_command): Use upper case for metasyntactic
2414         variables.
2415         (_initialize_demangler): Likewise.
2416         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2417         variables.
2418
2419 2019-01-03  Tom Tromey  <tom@tromey.com>
2420
2421         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2422
2423 2019-01-03  Tom Tromey  <tom@tromey.com>
2424
2425         * python/py-symtab.c (salpy_str): Update.
2426         (struct salpy_sal_object) <symtab>: Now a PyObject.
2427         (salpy_dealloc): Update.
2428         (del_objfile_sal): Use gdbpy_ref.
2429
2430 2019-01-03  Tom Tromey  <tom@tromey.com>
2431
2432         * python/py-type.c (convert_field): Use new_reference.  Return
2433         gdbpy_ref.
2434         (make_fielditem): Return gdbpy_ref.
2435         (typy_fields): Update.
2436         (typy_getitem): Update.
2437         (field_name): Return gdbpy_ref.  Use new_reference.
2438         (typy_iterator_iternext): Update.
2439
2440 2019-01-03  Tom Tromey  <tom@tromey.com>
2441
2442         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2443
2444 2019-01-03  Tom Tromey  <tom@tromey.com>
2445
2446         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2447         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2448         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2449         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2450         (pspy_set_type_printers): Likewise.
2451         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2452         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2453         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2454         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2455         (objfpy_set_type_printers): Likewise.
2456
2457 2019-01-03  Tom Tromey  <tom@tromey.com>
2458
2459         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2460         (gdbpy_print_stack): Use gdbpy_err_fetch.
2461         * python/python-internal.h (class gdbpy_err_fetch): New class.
2462         (class gdbpy_enter) <m_error_type, m_error_value,
2463         m_error_traceback>: Remove.
2464         <m_error>: New member.
2465         (gdbpy_exception_to_string): Don't declare.
2466         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2467         * python/py-value.c (convert_value_from_python): Use
2468         gdbpy_err_fetch.
2469         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2470         gdbpy_exception_to_string.
2471         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2472         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2473         gdbpy_err_fetch.
2474
2475 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2476
2477         * linux-nat.c (delete_lwp_cleanup): Delete.
2478         (struct lwp_deleter): New struct.
2479         (lwp_info_up): New typedef.
2480         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2481         lwp_info_up.
2482
2483 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2484
2485         * linux-fork.c (class scoped_switch_fork_info): New class.
2486         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2487
2488 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2489
2490         * valops.c (find_overload_match): Remove use of null_cleanup, and
2491         calls to do_cleanups.
2492
2493 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2494
2495         * compile/compile-cplus-types.c
2496         (compile_cplus_instance::decl_name): Handle changes to
2497         cp_func_name.
2498         * cp-support.c (cp_func_name): Update header comment, update
2499         return type.
2500         * cp-support.h (cp_func_name): Update return type in declaration.
2501         * valops.c (find_overload_match): Move temp_func local to top
2502         level of function and change its type.  Use temp_func to hold and
2503         delete temporary string obtained from cp_func_name.
2504
2505 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2506
2507         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2508         gdb::char_vector, remove cleanup, and update uses of `msg`.
2509
2510 2019-01-03  Jim Wilson  <jimw@sifive.com>
2511
2512         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2513
2514 2019-01-02  Tom Tromey  <tom@tromey.com>
2515
2516         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2517         (tdesc_parse_xml): Remove cleanups.
2518         * target-descriptions.h (make_cleanup_free_target_description):
2519         Don't declare.
2520         (target_desc_deleter): New struct.
2521         (target_desc_up): New typedef.
2522         * target-descriptions.c (target_desc_deleter::operator()): Rename
2523         from free_target_description.
2524         (make_cleanup_free_target_description): Remove.
2525
2526 2019-01-02  Tom Tromey  <tom@tromey.com>
2527
2528         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2529         constructor, destructor.
2530         (linespec_parser): Remove typedef.
2531         (~linespec_parser): Rename from linespec_parser_delete.
2532         (linespec_lex_to_end, linespec_complete_label)
2533         (linespec_complete): Update.
2534         (decode_line_full): Remove cleanups.
2535         (decode_line_1): Update.
2536
2537 2019-01-02  Tom Tromey  <tom@tromey.com>
2538
2539         * python/python-internal.h (inferior_to_inferior_object): Change
2540         return type.
2541         * python/py-exitedevent.c (create_exited_event_object): Update.
2542         * python/py-inferior.c (inferior_to_inferior_object): Return
2543         gdbpy_ref.
2544         (python_new_inferior, python_inferior_deleted)
2545         (thread_to_thread_object, delete_thread_object)
2546         (build_inferior_list, gdbpy_selected_inferior): Update.
2547         * python/py-infthread.c (create_thread_object): Update.  Also fail
2548         if inferior_to_inferior_object fails.
2549
2550 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2551
2552         * inferior.h (class inferior) <displaced_step_state>: New field.
2553         * infrun.h (struct displaced_step_state): Move here from
2554         infrun.c.  Initialize fields, add constructor.
2555         <inf>: Remove field.
2556         <reset>: New method.
2557         * infrun.c (struct displaced_step_inferior_state): Move to
2558         infrun.h.
2559         (displaced_step_inferior_states): Remove.
2560         (get_displaced_stepping_state): Adust.
2561         (displaced_step_in_progress_any_inferior): Adjust.
2562         (displaced_step_in_progress_thread): Adjust.
2563         (displaced_step_in_progress): Adjust.
2564         (add_displaced_stepping_state): Remove.
2565         (get_displaced_step_closure_by_addr): Adjust.
2566         (remove_displaced_stepping_state): Remove.
2567         (infrun_inferior_exit): Call displaced_step_state.reset.
2568         (use_displaced_stepping): Don't check for NULL.
2569         (displaced_step_prepare_throw): Call
2570         get_displaced_stepping_state.
2571         (displaced_step_fixup): Don't check for NULL.
2572         (prepare_for_detach): Don't check for NULL.
2573
2574 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2575
2576         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2577          in case of call that did not complete.
2578
2579 2019-01-02  Andrey Utkin  <autkin@undo.io>
2580
2581         * symfile.c (find_separate_debug_file): Fix search of debug files for
2582         remote debuggee.
2583
2584 2019-01-02  Tom Tromey  <tom@tromey.com>
2585
2586         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2587         indentation.
2588         * python/py-frame.c (frapy_older): Remove cast.
2589         (frapy_newer): Likewise.
2590         * python/py-breakpoint.c (local_setattro): Remove cast.
2591         * python/py-arch.c (archpy_name): Remove local variable.
2592         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2593
2594 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2595
2596         * unittests/basic_string_view/element_access/char/empty.cc:
2597         Fix year range in copyright header.
2598
2599 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2600
2601         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2602         Delete.
2603         <operator==>: Update with for removed field.
2604         <hash>: Likewise.
2605         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2606         <isa_features>: ...this.
2607         <abi_features>: New field.
2608         (riscv_isa_flen): Update comment.
2609         (riscv_abi_xlen): New declaration.
2610         (riscv_abi_flen): New declaration.
2611         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2612         isa_features.
2613         (riscv_abi_xlen): New function.
2614         (riscv_isa_flen): Update to get answer from isa_features.
2615         (riscv_abi_flen): New function.
2616         (riscv_has_fp_abi): Update to get answer from abi_features.
2617         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2618         xlen and flen.
2619         (riscv_call_info) <xlen, flen>: Update comment.
2620         (riscv_call_arg_struct): Remove invalid assertions
2621         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2622         is removed.
2623         (riscv_gdbarch_init): Gather isa features and abi features
2624         separately, ensure both match on the gdbarch when reusing an old
2625         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2626         a target with 64-bit float hardware.
2627
2628 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2629
2630         * source.c (search_command_helper): Stop reverse search
2631         when line 1 has been searched.
2632
2633 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2634
2635         * record-full.c (record_full_base_target::close): Rewrite
2636         record_full_core_buf_list free logic.
2637
2638 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2639
2640         * break-catch-syscall.c (print_one_catch_syscall): xfree
2641         the last text.
2642
2643 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2644
2645         * top.c (print_gdb_version): Update Copyright year in version
2646         message.
2647
2648 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2649
2650         Update copyright year range in all GDB files.
2651
2652 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2653
2654         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2655
2656 For older changes see ChangeLog-2018.
2657 \f
2658 Local Variables:
2659 mode: change-log
2660 left-margin: 8
2661 fill-column: 74
2662 version-control: never
2663 coding: utf-8
2664 End:
2665