gdb/ChangeLog

   1 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   2
   3         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
   4
   5 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
   6
   7         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
   8         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
   9         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
  10         (nios2_linux_init_abi): Install it.
  11
  12 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
  13
  14         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
  15
  16 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
  17
  18         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
  19
  20 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  21             Tom Tromey  <tromey@adacore.com>
  22
  23         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
  24
  25 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
  26
  27         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
  28         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
  29         method to compute the bounds of range types. Also print "[evaluated]"
  30         if the bounds' values come from a dynamic evaluation.
  31
  32 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
  33
  34         * cp-valprint.c (cp_print_value_fields): Don't print trailing
  35         whitespace when pretty printing is on.
  36
  37 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
  38
  39         * ppc-linux-nat.c: Add include.
  40
  41 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
  42
  43         * NEWS: Mention AArch64 Pointer Authentication.
  44
  45 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
  46
  47         * arm-linux-nat.c: Add include.
  48
  49 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
  50
  51         * source-cache.c (source_cache::get_source_lines): Re-read
  52         fullname after calling open_source_file.
  53
  54 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
  55
  56         * NEWS: Mention TLS support for FreeBSD.
  57
  58 2019-03-25  Tom Tromey  <tromey@adacore.com>
  59
  60         * minsyms.c (BUNCH_SIZE): Update comment.
  61         (~minimal_symbol_reader): Remove old comment.
  62         (compact_minimal_symbols): Update comment.
  63         (minimal_symbol_reader::install): Remove old comment.  Update
  64         other comments.
  65
  66 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
  67
  68         * s390-linux-nat.c: Add include.
  69
  70 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
  71
  72         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
  73         Call linux_get_hwcap.
  74         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
  75         Likewise.
  76         (aarch64_linux_get_hwcap): Remove function.
  77         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
  78         declaration.
  79         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
  80         linux_get_hwcap.
  81         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
  82         * linux-tdep.c (linux_get_hwcap): Add function.
  83         (linux_get_hwcap2): Likewise.
  84         * linux-tdep.h (linux_get_hwcap): Add declaration.
  85         (linux_get_hwcap2): Likewise.
  86         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
  87         (ppc_linux_get_hwcap2): Likewise.
  88         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
  89         linux_get_hwcap.
  90         (ppc_linux_nat_target::insert_watchpoint): Likewise.
  91         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
  92         (ppc_linux_nat_target::read_description): Likewise.
  93         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
  94         * s390-linux-nat.c: Likewise.
  95         * s390-linux-tdep.c (s390_core_read_description): Likewise.
  96
  97 2019-03-24  Tom Tromey  <tom@tromey.com>
  98
  99         * ada-lang.c (standard_lookup): Simplify initialization.
 100         (ada_lookup_symbol_nonlocal): Simplify return.
 101         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
 102         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
 103         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
 104         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
 105         initialization.
 106         * solib.c (solib_global_lookup): Simplify.
 107         * symtab.c (null_block_symbol): Remove.
 108         (symbol_cache_lookup): Simplify returns.
 109         (lookup_language_this): Simplify returns.
 110         (lookup_symbol_aux): Simplify return.
 111         (lookup_local_symbol): Simplify returns.
 112         (lookup_global_symbol_from_objfile): Simplify return.
 113         (lookup_symbol_in_objfile_symtabs)
 114         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
 115         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
 116         (lookup_static_symbol, lookup_global_symbol): Simplify return.
 117         * cp-namespace.c (cp_lookup_bare_symbol)
 118         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
 119         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
 120         (cp_lookup_nested_symbol): Don't use null_block_symbol.
 121         (cp_lookup_symbol_via_imports): Simplify initialization.
 122         (find_symbol_in_baseclass): Likewise.
 123         * symtab.h (null_block_symbol): Remove.
 124         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
 125         (d_lookup_nested_symbol, d_lookup_symbol_imports)
 126         (d_lookup_symbol_module): Likewise.
 127         (find_symbol_in_baseclass): Simplify initialization.
 128
 129 2019-03-24  Tom Tromey  <tom@tromey.com>
 130
 131         * expression.h: Don't include symtab.h.
 132         (struct block): Forward declare.
 133
 134 2019-03-24  Tom Tromey  <tom@tromey.com>
 135
 136         * c-exp.y (typebase): Remove casts.
 137         * gdbtypes.c (lookup_unsigned_typename, )
 138         (lookup_signed_typename): Remove cast.
 139         * eval.c (parse_to_comma_and_eval): Remove cast.
 140         * parse.c (write_dollar_variable): Remove cast.
 141         * block.h (struct block) <superblock>: Now const.
 142         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
 143         * psymtab.c (psym_map_matching_symbols): Make "block" const.
 144         (map_block): Make "block" const.
 145         * symfile.h (struct quick_symbol_functions)
 146         <map_matching_symbols>: Constify block argument to "callback".
 147         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
 148         const.
 149         (find_pc_sect_compunit_symtab): Make "b" const.
 150         (find_symbol_at_address): Likewise.
 151         (search_symbols): Likewise.
 152         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
 153         (dw2_debug_names_lookup_symbol): Likewise.
 154         (dw2_map_matching_symbols): Update.
 155         * p-valprint.c (pascal_val_print): Remove "block".
 156         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
 157         (aux_add_nonlocal_symbols): Make "block" const.
 158         (resolve_subexp): Remove cast.
 159         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
 160         const.
 161         (iterate_over_file_blocks): Likewise.
 162         * f-exp.y (%union) <bval>: Remove.
 163         * coffread.c (patch_opaque_types): Make "b" const.
 164         * spu-tdep.c (spu_catch_start): Make "block" const.
 165         * c-valprint.c (print_unpacked_pointer): Remove "block".
 166         * symmisc.c (dump_symtab_1): Make "b" const.
 167         (block_depth): Make "block" const.
 168         * d-exp.y (%union) <bval>: Remove.
 169         * cp-support.h (cp_lookup_rtti_type): Update.
 170         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
 171         * psymtab.c (psym_lookup_symbol): Make "block" const.
 172         (maintenance_check_psymtabs): Make "b" const.
 173         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
 174         (enumerate_locals, enumerate_args): Update.
 175         * python/py-symtab.c (stpy_global_block): Make "block" const.
 176         (stpy_static_block): Likewise.
 177         * inline-frame.c (block_starting_point_at): Make "new_block"
 178         const.
 179         * block.c (find_block_in_blockvector): Make return type const.
 180         (blockvector_for_pc_sect): Make "b" const.
 181         (find_block_in_blockvector): Make "b" const.
 182
 183 2019-03-23  Tom Tromey  <tom@tromey.com>
 184
 185         * varobj.c (varobj_create): Update.
 186         * symfile.c (clear_symtab_users): Don't reset innermost_block.
 187         * printcmd.c (display_command, do_one_display): Don't reset
 188         innermost_block.
 189         * parser-defs.h (enum innermost_block_tracker_type): Move to
 190         expression.h.
 191         (innermost_block): Update comment.
 192         * parse.c (parse_exp_1): Add tracker_types parameter.
 193         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
 194         tracker_types parameter.  Reset innermost_block.
 195         (parse_exp_in_context): Remove.
 196         (parse_expression_for_completion): Update.
 197         * objfiles.c (~objfile): Don't reset expression_context_block or
 198         innermost_block.
 199         * expression.h (enum innermost_block_tracker_type): Move from
 200         parser-defs.h.
 201         (parse_exp_1): Add tracker_types parameter.
 202         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
 203         reset innermost_block.
 204
 205 2019-03-23  Tom Tromey  <tom@tromey.com>
 206
 207         * objfiles.h: Include bcache.h.
 208
 209 2019-03-23  Tom Tromey  <tom@tromey.com>
 210
 211         * linespec.c (get_current_search_block): Use
 212         scoped_restore_current_language.
 213         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
 214
 215 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 216             Jiong Wang  <jiong.wang@arm.com>
 217
 218         * aarch64-linux-tdep.c
 219         (aarch64_linux_iterate_over_regset_sections): Check for pauth
 220         section.
 221         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
 222
 223 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 224             Jiong Wang  <jiong.wang@arm.com>
 225
 226         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
 227         instructions.
 228         (aarch64_analyze_prologue_test): Add PACIASP test.
 229         (aarch64_prologue_prev_register): Unmask PC value.
 230
 231 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 232             Jiong Wang  <jiong.wang@arm.com>
 233
 234         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
 235         (aarch64_dwarf2_prev_register): Unmask PC value.
 236         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
 237         (aarch64_execute_dwarf_cfa_vendor_op): Check for
 238         DW_CFA_AARCH64_negate_ra_state.
 239         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
 240
 241 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 242             Jiong Wang  <jiong.wang@arm.com>
 243
 244         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
 245         registers.
 246         (aarch64_pseudo_register_name): Likewise.
 247         (aarch64_pseudo_register_type): Likewise.
 248         (aarch64_pseudo_register_reggroup_p): Likewise.
 249         (aarch64_gdbarch_init): Add pauth registers.
 250         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
 251         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
 252         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
 253         (struct gdbarch_tdep): Add regnum for ra_state.
 254
 255 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 256             Jiong Wang  <jiong.wang@arm.com>
 257
 258         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
 259
 260 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 261             Jiong Wang  <jiong.wang@arm.com>
 262
 263         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
 264         function.
 265         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
 266         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
 267         (aarch64_gdbarch_init): Add puth registers.
 268         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
 269         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
 270         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
 271
 272 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 273             Jiong Wang  <jiong.wang@arm.com>
 274
 275         * aarch64-linux-nat.c
 276         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
 277         * aarch64-linux-tdep.c
 278         (aarch64_linux_core_read_description): Likewise.
 279         (aarch64_linux_get_hwcap): New function.
 280         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
 281         (aarch64_linux_get_hwcap): New declaration.
 282
 283 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
 284             Jiong Wang  <jiong.wang@arm.com>
 285
 286         * aarch64-linux-nat.c
 287         (aarch64_linux_nat_target::read_description): Add pauth param.
 288         * aarch64-linux-tdep.c
 289         (aarch64_linux_core_read_description): Likewise.
 290         * aarch64-tdep.c (struct target_desc): Add in pauth.
 291         (aarch64_read_description): Add pauth param.
 292         (aarch64_gdbarch_init): Likewise.
 293         * aarch64-tdep.h (aarch64_read_description): Likewise.
 294         * arch/aarch64.c (aarch64_create_target_description): Likewise.
 295         * arch/aarch64.h (aarch64_create_target_description): Likewise.
 296         * features/Makefile: Add new files.
 297         * features/aarch64-pauth.c: New file.
 298         * features/aarch64-pauth.xml: New file.
 299
 300 2019-03-20  Tom Tromey  <tromey@adacore.com>
 301
 302         * infrun.c (handle_inferior_event): Rename from
 303         handle_inferior_event_1.  Create a scoped_value_mark.
 304         (handle_inferior_event): Remove.
 305
 306 2019-03-19  Tom Tromey  <tromey@adacore.com>
 307
 308         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
 309         * infrun.h (print_stop_event): Add "displays" parameter.
 310         * infrun.c (print_stop_event): Add "displays" parameter.
 311
 312 2019-03-19  Pedro Alves  <palves@redhat.com>
 313
 314         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
 315         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
 316         to -1.  Fix TABs vs spaces.
 317         (tui_ui_out::tui_ui_out): Don't initialize fields here.
 318         * tui/tui-out.h (tui_ui_out) Add intro comments.
 319         <m_line, m_start_of_line>: In-class initialize, and add describing
 320         comment.
 321
 322 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
 323
 324         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
 325         variable names.
 326         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
 327
 328 2019-03-18  Pedro Alves  <palves@redhat.com>
 329             Eli Zaretskii <eliz@gnu.org>
 330
 331         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
 332         m_line and m_start_of_line.
 333
 334 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
 335
 336         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
 337         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
 338         it returns a newline.  This fixes a regression in TU mode, whereby
 339         the next line is output on the same screen line as the user input.
 340
 341 2019-03-18  Tom Tromey  <tromey@adacore.com>
 342
 343         * minsyms.c (minimal_symbol_reader::install): Remove call to
 344         obstack_blank.
 345
 346 2019-03-18  Pedro Alves  <palves@redhat.com>
 347
 348         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
 349         New globals.
 350         (apply_style): New, factored out from ...
 351         (apply_ansi_escape): ... this.  Handle reverse video mode.
 352         (tui_set_reverse_mode): New function.
 353         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
 354         * tui/tui-winsource.c (tui_show_source_line): Use
 355         tui_set_reverse_mode instead of setting A_STANDOUT.
 356         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
 357         New setter methods.
 358
 359 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
 360
 361         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
 362         Handle tabs.
 363
 364 2019-03-18  Tom Tromey  <tromey@adacore.com>
 365
 366         * ada-lang.c (empty_array): Add "high" parameter.
 367         (ada_evaluate_subexp): Update.
 368
 369 2019-03-17  Sergei Trofimovich <siarheit@google.com>
 370
 371         * unittests/string_view-selftests.c: Define
 372         _initialize_string_view_selftests unconditionally.
 373
 374 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 375
 376         PR gdb/24350
 377         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
 378
 379 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
 380
 381         PR gdb/24351
 382         * windows-nat.c (display_selector): Fix format specifiers.
 383
 384 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
 385
 386         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
 387         tui_refill_source_window instead of tui_refresh_win, to update the
 388         current execution line.  This fixes redisplay of the current line
 389         when stepping through the code with "next" or "step".
 390
 391 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 392
 393         * source-cache.c (source_cache::get_source_lines): Call
 394         find_source_lines to initialize s->nlines.  This fixes vertical
 395         scrolling of TUI source window when the DOWN arrow is pressed.
 396
 397 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 398
 399         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
 400         linux-thread-db.c (_initialize_thread_db): Likewise.
 401
 402 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
 403
 404         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
 405         wclrtoeol in tui_show_source_line".  This reverts changes made in
 406         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
 407
 408 2019-03-15  Tom Tromey  <tom@tromey.com>
 409
 410         * symtab.h (struct minimal_symbol): Derive from
 411         general_symbol_info.
 412         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
 413         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
 414         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
 415         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
 416         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
 417         (MSYMBOL_SEARCH_NAME): Update.
 418         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
 419         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
 420         * minsyms.c (minimal_symbol_reader::record_full): Update.
 421
 422 2019-03-15  Tom Tromey  <tom@tromey.com>
 423
 424         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
 425
 426 2019-03-15  Tom Tromey  <tom@tromey.com>
 427
 428         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
 429         unique_xmalloc_ptr.
 430         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
 431         Update.
 432         * minsyms.c (lookup_minimal_symbol_by_pc_section)
 433         (build_minimal_symbol_hash_tables)
 434         (minimal_symbol_reader::install): Update.
 435
 436 2019-03-15  Tom Tromey  <tom@tromey.com>
 437
 438         * symtab.c (create_demangled_names_hash): Update.
 439         (symbol_set_names): Update.
 440         * objfiles.h (struct objfile_per_bfd_storage)
 441         <demangled_names_hash>: Now an htab_up.
 442         * objfiles.c (objfile_per_bfd_storage): Simplify.
 443
 444 2019-03-15  Tom Tromey  <tom@tromey.com>
 445
 446         * objfiles.h (struct objfile_per_bfd_storage): Declare
 447         destructor.
 448         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 449         New.
 450         (get_objfile_bfd_data): Use new.  Don't initialize
 451         language_of_main.
 452         (free_objfile_per_bfd_storage): Remove.
 453         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 454
 455 2019-03-15  Tom Tromey  <tom@tromey.com>
 456
 457         * symfile.c (reread_symbols): Update.
 458         * objfiles.c (objfile::objfile): Update.
 459         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 460         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 461         comment.
 462         (minimal_symbol_reader::install): Update.
 463         (terminate_minimal_symbol_table): Remove.
 464         * jit.c (jit_object_close_impl): Update.
 465
 466 2019-03-15  Tom Tromey  <tom@tromey.com>
 467
 468         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 469         initializations.
 470
 471 2019-03-15  Tom Tromey  <tom@tromey.com>
 472
 473         * objfiles.h (struct objfile_per_bfd_storage)
 474         <demangled_hash_languages>: Now a bitset.
 475         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 476         (lookup_minimal_symbol): Update.
 477
 478 2019-03-15  Tom Tromey  <tom@tromey.com>
 479
 480         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 481         Don't return the symbol.
 482         * coffread.c (record_minimal_symbol): Use record_full.
 483
 484 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 485
 486         The MS-Windows port of ncurses fails to switch to a color pair if
 487         one or both of the colors are the implicit default colors.  This
 488         change records the default colors when TUI is initialized, and
 489         then specifies them explicitly when a color pair uses the default
 490         colors.  This allows color styling in TUI mode on MS-Windows.
 491
 492         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 493         ncurses_norm_attr.
 494         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 495         colors in ncurses_norm_attr.
 496         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 497         "none", replace it with the default color recorded in
 498         ncurses_norm_attr.
 499
 500 2019-03-14  Tom Tromey  <tromey@adacore.com>
 501
 502         * source-cache.h (class source_cache) <get_source_lines>: Return
 503         std::string.
 504         * source-cache.c (source_cache::extract_lines): Handle case where
 505         first_pos==npos.  Return std::string.
 506         (source_cache::get_source_lines): Update.
 507
 508 2019-03-14  Tom Tromey  <tromey@adacore.com>
 509
 510         * NEWS: Add item for "style sources" commands.
 511         * source-cache.c (source_cache::get_source_lines): Check
 512         source_styling.
 513         * cli/cli-style.c (source_styling): New global.
 514         (_initialize_cli_style): Add "style sources" commands.
 515         (show_style_sources): New function.
 516         * cli/cli-style.h (source_styling): Declare.
 517
 518 2019-03-14  Pedro Alves  <palves@redhat.com>
 519             Tom Tromey  <tromey@adacore.com>
 520
 521         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 522         * tui/tui-winsource.c (tui_refill_source_window): New function,
 523         from...
 524         (tui_horizontal_source_scroll): ... here.  Move some logic.
 525         * cli/cli-style.c (set_style_enabled): Notify new observable.
 526         * tui/tui-hooks.c (tui_redisplay_source): New function.
 527         (tui_attach_detach_observers): Attach or detach
 528         tui_redisplay_source.
 529         * observable.h (source_styling_changed): New observable.
 530         * observable.c: Define source_styling_changed observable.
 531
 532 2019-03-13  Tom Tromey  <tromey@adacore.com>
 533
 534         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 535         (i386_gnu_nat_target::store_registers): Update.
 536         * target-debug.h (target_debug_print_std_string): New macro.
 537         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 538         * windows-tdep.c (display_one_tib): Update.
 539         * tui/tui-stack.c (tui_make_status_line): Update.
 540         * top.c (print_inferior_quit_action): Update.
 541         * thread.c (thr_try_catch_cmd): Update.
 542         (add_thread_with_info): Update.
 543         (thread_target_id_str): Update.
 544         (thr_try_catch_cmd): Update.
 545         (thread_command): Update.
 546         (thread_find_command): Update.
 547         * record-btrace.c (record_btrace_target::info_record)
 548         (record_btrace_resume_thread, record_btrace_target::resume)
 549         (record_btrace_cancel_resume, record_btrace_step_thread)
 550         (record_btrace_target::wait, record_btrace_target::wait)
 551         (record_btrace_target::wait, record_btrace_target::stop): Update.
 552         * progspace.c (print_program_space): Update.
 553         * process-stratum-target.c
 554         (process_stratum_target::thread_address_space): Update.
 555         * linux-fork.c (linux_fork_mourn_inferior)
 556         (detach_checkpoint_command, info_checkpoints_command)
 557         (linux_fork_context): Update.
 558         (linux_fork_detach): Update.
 559         (class scoped_switch_fork_info): Update.
 560         (delete_checkpoint_command): Update.
 561         * infrun.c (follow_fork_inferior): Update.
 562         (follow_fork_inferior): Update.
 563         (proceed_after_vfork_done): Update.
 564         (handle_vfork_child_exec_or_exit): Update.
 565         (follow_exec): Update.
 566         (displaced_step_prepare_throw): Update.
 567         (displaced_step_restore): Update.
 568         (start_step_over): Update.
 569         (resume_1): Update.
 570         (clear_proceed_status_thread): Update.
 571         (proceed): Update.
 572         (print_target_wait_results): Update.
 573         (do_target_wait): Update.
 574         (context_switch): Update.
 575         (stop_all_threads): Update.
 576         (restart_threads): Update.
 577         (finish_step_over): Update.
 578         (handle_signal_stop): Update.
 579         (switch_back_to_stepped_thread): Update.
 580         (keep_going_pass_signal): Update.
 581         (print_exited_reason): Update.
 582         (normal_stop): Update.
 583         * inferior.c (inferior_pid_to_str): Change return type.
 584         (print_selected_inferior): Update.
 585         (add_inferior): Update.
 586         (detach_inferior): Update.
 587         * dummy-frame.c (fprint_dummy_frames): Update.
 588         * dcache.c (dcache_info_1): Update.
 589         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 590         (btrace_fetch, btrace_clear): Update.
 591         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 592         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 593         type.
 594         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 595         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 596         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 597         * gdbarch.c, gdbarch.h: Rebuild.
 598         * gdbarch.sh (core_pid_to_str): Change return type.
 599         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 600         return type.
 601         (windows_nat_target::pid_to_str): Change return type.
 602         (windows_delete_thread): Update.
 603         (windows_nat_target::attach): Update.
 604         (windows_nat_target::files_info): Update.
 605         * target-delegates.c: Rebuild.
 606         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 607         return type.
 608         (sol_thread_target::pid_to_str): Change return type.
 609         * remote.c (class remote_target) <pid_to_str>: Change return
 610         type.
 611         (remote_target::pid_to_str): Change return type.
 612         (extended_remote_target::attach, remote_target::remote_stop_ns)
 613         (remote_target::remote_notif_remove_queued_reply)
 614         (remote_target::push_stop_reply, remote_target::disable_btrace):
 615         Update.
 616         (extended_remote_target::attach): Update.
 617         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 618         type.
 619         (gdbsim_target::pid_to_str): Change return type.
 620         * ravenscar-thread.c (struct ravenscar_thread_target)
 621         <pid_to_str>: Change return type.
 622         (ravenscar_thread_target::pid_to_str): Change return type.
 623         * procfs.c (class procfs_target) <pid_to_str>: Change return
 624         type.
 625         (procfs_target::pid_to_str): Change return type.
 626         (procfs_target::attach): Update.
 627         (procfs_target::detach): Update.
 628         (procfs_target::fetch_registers): Update.
 629         (procfs_target::store_registers): Update.
 630         (procfs_target::wait): Update.
 631         (procfs_target::files_info): Update.
 632         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 633         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 634         return type.
 635         (nto_procfs_target::pid_to_str): Change return type.
 636         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 637         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 638         return type.
 639         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 640         (exit_lwp): Update.
 641         (attach_proc_task_lwp_callback, get_detach_signal)
 642         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 643         (linux_nat_target::resume, wait_lwp, stop_callback)
 644         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 645         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 646         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 647         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 648         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 649         type.
 650         (inf_ptrace_target::attach): Update.
 651         (inf_ptrace_target::files_info): Update.
 652         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 653         type.
 654         (go32_nat_target::pid_to_str): Change return type.
 655         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 656         (gnu_nat_target::wait): Update.
 657         (gnu_nat_target::wait): Update.
 658         (gnu_nat_target::resume): Update.
 659         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 660         (fbsd_nat_target::wait): Update.
 661         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 662         type.
 663         (darwin_nat_target::attach): Update.
 664         * corelow.c (class core_target) <pid_to_str>: Change return type.
 665         (core_target::pid_to_str): Change return type.
 666         * target.c (normal_pid_to_str): Change return type.
 667         (default_pid_to_str): Likewise.
 668         (target_pid_to_str): Change return type.
 669         (target_translate_tls_address): Update.
 670         (target_announce_detach): Update.
 671         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 672         return type.
 673         (bsd_uthread_target::pid_to_str): Change return type.
 674         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 675         type.
 676         (bsd_kvm_target::pid_to_str): Change return type.
 677         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 678         return type.
 679         (aix_thread_target::pid_to_str): Change return type.
 680         * target.h (struct target_ops) <pid_to_str>: Change return type.
 681         (target_pid_to_str, normal_pid_to_str): Likewise.
 682         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 683         type.
 684         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 685         type.
 686         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 687         return type.
 688         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 689         type.
 690         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 691         type.
 692         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 693         return type.
 694
 695 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 696
 697         * NEWS: Mention that the new default MI version is 3.  Mention
 698         changes to the output of commands and events that deal with
 699         multi-location breakpoints.
 700         * breakpoint.c: Include "mi/mi-out.h".
 701         (print_one_breakpoint): Change output syntax if using MI version
 702         >= 3.
 703         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 704         New.
 705         (mi_multi_location_breakpoint_output_fixed): New.
 706         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 707         (mi_cmd_fix_multi_location_breakpoint_output): New.
 708         (mi_multi_location_breakpoint_output_fixed): New.
 709         * mi/mi-cmds.c (mi_cmds): Register command
 710         -fix-multi-location-breakpoint-output.
 711         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 712         interpreter "mi".
 713
 714 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 715
 716         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 717         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 718         instantiate mi_ui_out based on interpreter name.
 719         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 720         * mi/mi-main.c (mi_load_progress): Likewise.
 721
 722 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 723
 724         * NEWS: Combine separate "New targets" sections for 8.3.
 725
 726 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 727
 728         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 729         (ppcfbsd_init_abi): Install gdbarch
 730         "fetch_tls_load_module_address" and "get_thread_local_address"
 731         methods.
 732
 733 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 734
 735         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 736         (riscv_fbsd_init_abi): Install gdbarch
 737         "fetch_tls_load_module_address" and "get_thread_local_address"
 738         methods.
 739
 740 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 741
 742         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 743         (i386fbsd_init_abi): Install gdbarch
 744         "fetch_tls_load_module_address" and "get_thread_local_address"
 745         methods.
 746
 747 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 748
 749         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 750         (amd64fbsd_init_abi): Install gdbarch
 751         "fetch_tls_load_module_address" and "get_thread_local_address"
 752         methods.
 753
 754 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 755
 756         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 757         (struct fbsd_pspace_data): New type.
 758         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 759         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 760         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 761         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 762         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 763
 764 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 765
 766         * gdbtypes.c (lookup_struct_elt): New function.
 767         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 768         * gdbtypes.h (struct struct_elt): New type.
 769         (lookup_struct_elt): New prototype.
 770
 771 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 772
 773         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 774         remove disabled code block.
 775
 776 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 777
 778         * gdbarch.sh (get_thread_local_address): New method.
 779         * gdbarch.h, gdbarch.c: Regenerate.
 780         * target.c (target_translate_tls_address): Use
 781         gdbarch_get_thread_local_address if present instead of
 782         target::get_thread_local_address.
 783
 784 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 785
 786         * target.h (target::get_thread_local_address): Update comment.
 787
 788 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 789
 790         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 791         objfile->separate_debug_objfile_backlink if not NULL.
 792
 793 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 794
 795         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 796         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 797         (amd64bsd_store_inferior_registers): Likewise.
 798         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 799         Enable segment base registers.
 800         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 801         PT_GETFSBASE and PT_GETGSBASE.
 802         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 803         PT_SETGSBASE.
 804         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 805         segment base registers.
 806         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 807
 808 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 809
 810         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 811         Update calls to i386_target_description to add 'segments'
 812         parameter.
 813         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 814         add segment base registers.
 815         * arch/i386.c (i386_create_target_description): Add 'segments'
 816         parameter to enable segment base registers.
 817         * arch/i386.h (i386_create_target_description): Likewise.
 818         * features/i386/32bit-segments.xml: New file.
 819         * features/i386/32bit-segments.c: Generate.
 820         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 821         call to i386_target_description to add 'segments' parameter.
 822         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 823         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 824         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 825         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 826         if feature is present.
 827         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 828         Add 'segments' parameter to call to i386_target_description.
 829         (i386_target_description): Add 'segments' parameter to enable
 830         segment base registers.
 831         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 832         to call to i386_target_description.
 833         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 834         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 835         Define I386_NUM_REGS.
 836         (i386_target_description): Add 'segments' parameter to enable
 837         segment base registers.
 838
 839 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 840
 841         PR/24325
 842         * source-cache.c: #undef open and close, to avoid unresolved
 843         externals during linking.
 844
 845 2019-03-12  Tom Tromey  <tromey@adacore.com>
 846
 847         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 848         const.  Add initializers.
 849         (_initialize_remote): Don't initialize ptid globals.
 850
 851 2019-03-12  Pedro Alves  <palves@redhat.com>
 852
 853         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 854
 855 2019-03-12  Pedro Alves  <palves@redhat.com>
 856
 857         * cp-name-parser.y (main): Remove unused 'len' variable.
 858
 859 2019-03-12  Tom Tromey  <tromey@adacore.com>
 860
 861         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 862         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 863
 864 2019-03-12  Tom Tromey  <tromey@adacore.com>
 865
 866         * linux-nat.c (iterate_over_lwps): Update.
 867         (stop_callback): Remove parameter.
 868         (stop_wait_callback, detach_callback, resume_set_callback)
 869         (select_singlestep_lwp_callback, set_ignore_sigint)
 870         (status_callback, resumed_callback, resume_clear_callback)
 871         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 872         data parameter.
 873         (linux_nat_target::detach, linux_nat_target::resume)
 874         (linux_stop_and_wait_all_lwps, select_event_lwp)
 875         (linux_nat_filter_event, linux_nat_wait_1)
 876         (linux_nat_target::kill, linux_nat_target::stop)
 877         (linux_nat_target::stop): Update.
 878         (linux_nat_resume_callback): Change type.
 879         (resume_stopped_resumed_lwps, count_events_callback)
 880         (select_event_lwp_callback): Likewise.
 881         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 882         * arm-linux-nat.c (struct update_registers_data): Remove.
 883         (update_registers_callback): Change type.
 884         (arm_linux_insert_hw_breakpoint1): Update.
 885         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 886         parameter.
 887         (x86_linux_dr_set_addr): Update.
 888         (x86_linux_dr_set_control): Update.
 889         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 890         (iterate_over_lwps): Use gdb::function_view.
 891         * nat/aarch64-linux-hw-point.c (struct
 892         aarch64_dr_update_callback_param): Remove.
 893         (debug_reg_change_callback): Change type.
 894         (aarch64_notify_debug_reg_change): Update.
 895         * s390-linux-nat.c (s390_refresh_per_info): Update.
 896
 897 2019-03-11  Tom Tromey  <tromey@adacore.com>
 898
 899         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 900         redundant assignment to "this_cu".
 901
 902 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 903
 904         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 905
 906 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 907
 908         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 909         from...
 910         (rank_one_type): ... this.
 911
 912 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 913
 914         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 915         from...
 916         (rank_one_type): ... this.
 917
 918 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 919
 920         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 921         from...
 922         (rank_one_type): ... this.
 923
 924 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 925
 926         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 927         from...
 928         (rank_one_type): ... this.
 929
 930 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 931
 932         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 933         from...
 934         (rank_one_type): ... this.
 935
 936 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 937
 938         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 939         from...
 940         (rank_one_type): ... this.
 941
 942 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 943
 944         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 945         from...
 946         (rank_one_type): ... this.
 947
 948 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 949
 950         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 951         from...
 952         (rank_one_type): ... this.
 953
 954 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 955
 956         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 957         from...
 958         (rank_one_type): ... this.
 959
 960 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 961
 962         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 963         from...
 964         (rank_one_type): ... this.
 965
 966 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 967
 968         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 969         from...
 970         (rank_one_type): ... this.
 971
 972 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 973
 974         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 975         from...
 976         (rank_one_type): ... this.
 977
 978 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 979
 980         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 981         inferior-events' shows the example events.
 982
 983 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 984
 985         Support styling on native MS-Windows console
 986
 987         PR/24315
 988         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 989         on MS-Windows if $TERM is not defined.
 990
 991         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 992
 993         * posix-hdep.c (gdb_console_fputs):
 994         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 995         functions.
 996         * ui-file.h (gdb_console_fputs): Add prototype.
 997
 998         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 999         back to fputs only if the former returns zero.
1000
1001 2019-03-07  Tom Tromey  <tom@tromey.com>
1002
1003         * symmisc.c (print_symbol_bcache_statistics): Update.
1004         (print_objfile_statistics): Update.
1005         * symfile.c (allocate_symtab): Update.
1006         * stabsread.c: Don't include bcache.h.
1007         * psymtab.h (struct psymbol_bcache): Don't declare.
1008         (class psymtab_storage) <psymbol_cache>: Now a bcache.
1009         (psymbol_bcache_init, psymbol_bcache_free)
1010         (psymbol_bcache_get_bcache): Don't declare.
1011         * psymtab.c (struct psymbol_bcache): Remove.
1012         (psymtab_storage::psymtab_storage): Update.
1013         (psymtab_storage::~psymtab_storage): Update.
1014         (psymbol_bcache_init, psymbol_bcache_free)
1015         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
1016         (add_psymbol_to_bcache): Update.
1017         (allocate_psymtab): Update.
1018         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
1019         macro_cache>: No longer pointers.
1020         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
1021         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
1022         * macrotab.c (macro_bcache): Update.
1023         * macroexp.c: Don't include bcache.h.
1024         * gdbtypes.c (check_types_worklist): Update.
1025         (types_deeply_equal): Remove TRY/CATCH.  Update.
1026         * elfread.c (elf_symtab_read): Update.
1027         * dwarf2read.c: Don't include bcache.h.
1028         * buildsym.c (buildsym_compunit::get_macro_table): Update.
1029         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
1030         (print_bcache_statistics, bcache_memory_used): Don't declare.
1031         (struct bcache): Move from bcache.c.  Add constructor, destructor,
1032         methods.  Rename all data members.
1033         * bcache.c (struct bcache): Move to bcache.h.
1034         (bcache::expand_hash_table): Rename from expand_hash_table.
1035         (bcache): Remove.
1036         (bcache::insert): Rename from bcache_full.
1037         (bcache::compare): Rename from bcache_compare.
1038         (bcache_xmalloc): Remove.
1039         (bcache::~bcache): Rename from bcache_xfree.
1040         (bcache::print_statistics): Rename from print_bcache_statistics.
1041         (bcache::memory_used): Rename from bcache_memory_used.
1042
1043 2019-03-07  Pedro Alves  <palves@redhat.com>
1044
1045         * infrun.c (normal_stop): Also check for
1046         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
1047
1048 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1049
1050         * f-lang.c (value_from_host_double): Moved to...
1051         * value.c (value_from_host_double): ...here.
1052         * value.h (value_from_host_double): Declare.
1053         * guile/scm-math.c (vlscm_convert_typed_number): Use
1054         value_from_host_double.
1055         (vlscm_convert_number): Likewise.
1056         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
1057         * python/py-value.c (convert_value_from_python): Likewise.
1058
1059 2019-03-06  Tom Tromey  <tom@tromey.com>
1060
1061         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
1062
1063 2019-03-06  Tom Tromey  <tom@tromey.com>
1064
1065         * utils.h (free_current_contents): Don't declare.
1066         * utils.c (free_current_contents): Remove.
1067
1068 2019-03-06  Tom Tromey  <tom@tromey.com>
1069
1070         * top.c (quit_force): Update.
1071         * main.c (captured_command_loop): Update.
1072         * common/new-op.c (operator new): Update.
1073         * common/common-exceptions.c (struct catcher)
1074         <save_cleanup_chain>: Remove member.
1075         (exceptions_state_mc_init): Update.
1076         (exception_try_scope_entry): Return nullptr.
1077         (exception_try_scope_exit, exception_rethrow)
1078         (throw_exception_sjlj, throw_exception_cxx): Update.
1079         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
1080         (all_cleanups, do_cleanups, discard_cleanups)
1081         (discard_final_cleanups, save_cleanups, save_final_cleanups)
1082         (restore_cleanups, restore_final_cleanups): Don't declare.
1083         (do_final_cleanups): Remove parameter.
1084         * common/cleanups.c (cleanup_chain, make_cleanup)
1085         (make_cleanup_dtor, all_cleanups, do_cleanups)
1086         (discard_my_cleanups, discard_cleanups)
1087         (discard_final_cleanups, save_my_cleanups, save_cleanups)
1088         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
1089         (null_cleanup): Remove.
1090         (do_final_cleanups): Remove parameter.
1091
1092 2019-03-06  Tom Tromey  <tom@tromey.com>
1093
1094         * remote.c (remote_target::remote_parse_stop_reply): Use
1095         unique_xmalloc_ptr.
1096
1097 2019-03-06  Tom Tromey  <tom@tromey.com>
1098
1099         * stabsread.c (struct stabs_field_info): Rename from field_info.
1100         <list, fnlist>: Add initializers.
1101         <obstack>: New member.
1102         (read_member_functions, read_struct_fields, read_baseclasses):
1103         Allocate on obstack.  Don't use cleanups.
1104         (read_one_struct_field, read_member_functions, read_struct_fields)
1105         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
1106         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
1107         (read_struct_type): Update.
1108
1109 2019-03-06  Tom Tromey  <tom@tromey.com>
1110
1111         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
1112         * common/filestuff.h (make_cleanup_close): Don't declare.
1113         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
1114         Remove.
1115
1116 2019-03-06  Tom Tromey  <tom@tromey.com>
1117
1118         * solib-aix.c: Use make_scope_exit.
1119
1120 2019-03-06  Tom Tromey  <tom@tromey.com>
1121
1122         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
1123         Use make_scope_exit.
1124
1125 2019-03-06  Tom Tromey  <tom@tromey.com>
1126
1127         * solib-svr4.c (disable_probes_interface): Remove parameter.
1128         (svr4_handle_solib_event): Use make_scope_exit.
1129
1130 2019-03-06  Tom Tromey  <tom@tromey.com>
1131
1132         * remote.c (struct stop_reply_deleter): Remove.
1133         (stop_reply_up): Update.
1134         (struct stop_reply): Derive from notif_event.  Don't typedef.
1135         <regcache>: Now a std::vector.
1136         (stop_reply_xfree): Remove.
1137         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
1138         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
1139         (remote_target::discard_pending_stop_replies): Use delete.
1140         (remote_target::remote_parse_stop_reply): Update.
1141         (remote_target::process_stop_reply): Update.
1142         * remote-notif.h (struct notif_event): Add virtual destructor.
1143         Remove "dtr" member.
1144         (struct notif_client) <alloc_event>: Return a unique_ptr.
1145         (notif_event_xfree): Don't declare.
1146         (notif_event_up): New typedef.
1147         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
1148         (notif_event_xfree, do_notif_event_xfree): Remove.
1149         (remote_notif_state_xfree): Update.
1150
1151 2019-03-06  Tom Tromey  <tom@tromey.com>
1152
1153         * infrun.c (displaced_step_clear_cleanup): Now a
1154         forward_scope_exit type.
1155         (displaced_step_prepare_throw): Update.
1156         (displaced_step_fixup): Update.
1157
1158 2019-03-06  Tom Tromey  <tom@tromey.com>
1159
1160         * inferior.h (class inferior): Update comment.
1161         * gdbthread.h (class thread_info): Update comment.
1162
1163 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
1164             Tom Tromey  <tom@tromey.com>
1165
1166         * stabsread.h (struct stab_section_list): Remove.
1167         (coffstab_build_psymtabs): Update.
1168         * dbxread.c (symbuf_sections): Now a std::vector.
1169         (sect_idx): New global.
1170         (fill_symbuf): Update.
1171         (coffstab_build_psymtabs): Change type of stabsects parameter.
1172         Update.
1173         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
1174         std::vector.
1175         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
1176         (coff_locate_sections): Update.
1177         (coff_symfile_read): Remove cleanups.  Update.
1178         (init_stringtab): Add storage parameter.
1179         (free_stringtab, free_stringtab_cleanup): Remove.
1180         (init_lineno): Add storage parameter.
1181         (free_linetab, free_linetab_cleanup): Remove.
1182
1183 2019-03-06  Pedro Alves  <palves@redhat.com>
1184
1185         * linux-fork.c (fork_info::clobber_regs): Delete.
1186         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
1187         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
1188         comment.  Adjust.
1189         (scoped_switch_fork_info::scoped_switch_fork_info)
1190         (checkpoint_command, linux_fork_context): Adjust
1191         fork_save_infrun_state calls.
1192
1193 2019-03-06  Pedro Alves  <palves@redhat.com>
1194
1195         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
1196         (inf_has_multiple_threads): Return 'bool' and rewrite using
1197         inferior_info::threads().
1198
1199 2019-03-06  Pedro Alves  <palves@redhat.com>
1200
1201         * linux-fork.c: Include <list>.
1202         (fork_list): Now a std::list instance.
1203         (fork_info): Add ctor, dtor, and in-class initialize all fields.
1204         (forks_exist_p, find_last_fork): Adjust.
1205         (new_fork): Delete.
1206         (one_fork_p): New.
1207         (add_fork): Adjust.
1208         (free_fork): Delete, folded into fork_info::~fork_info().
1209         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
1210         Adjust.
1211         (init_fork_list): Delete.
1212         (linux_fork_killall, linux_fork_mourn_inferior)
1213         (linux_fork_detach, info_checkpoints_command): Adjust.
1214         (_initialize_linux_fork): No longer call init_fork_list.
1215
1216 2019-03-06  Pedro Alves  <palves@redhat.com>
1217
1218         * linux-fork.c (new_fork): New, split out of ...
1219         (add_fork): ... this.  Return void.  Move "first fork" special
1220         case from here, to ...
1221         (checkpoint_command): ... here.
1222         * linux-linux.h (add_fork): Return void.
1223
1224 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1225
1226         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1227
1228 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1229             Chris January  <chris.january@arm.com>
1230             David Lecomber  <david.lecomber@arm.com>
1231
1232         * f-exp.y: New token, UNOP_INTRINSIC.
1233         (exp): New pattern using UNOP_INTRINSIC token.
1234         (f77_keywords): Add 'abs' keyword.
1235         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1236         (value_from_host_double): New function.
1237         (evaluate_subexp_f): Support UNOP_ABS.
1238
1239 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1240
1241         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1242         types.
1243
1244 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1245
1246         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1247         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1248         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1249
1250 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1251
1252         * f-exp.y (convert_to_kind_type): Handle more type kinds.
1253
1254 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1255             Chris January  <chris.january@arm.com>
1256
1257         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1258         * f-exp.y: Define 'KIND' token.
1259         (exp): New pattern for KIND expressions.
1260         (ptype): Handle types with a kind extension.
1261         (direct_abs_decl): Extend to spot kind extensions.
1262         (f77_keywords): Add 'kind' to the list.
1263         (push_kind_type): New function.
1264         (convert_to_kind_type): New function.
1265         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1266         * parse.c (operator_length_standard): Likewise.
1267         * parser-defs.h (enum type_pieces): Add tp_kind.
1268         * std-operator.def: Add UNOP_KIND.
1269
1270 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1271
1272         * f-exp.y (f_parse): Set yydebug.
1273
1274 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1275
1276         * f-lang.c (evaluate_subexp_f): New function.
1277         (exp_descriptor_f): New global.
1278         (f_language_defn): Use exp_descriptor_f instead of
1279         exp_descriptor_standard.
1280
1281 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1282
1283         * f-exp.y (struct token): Add comments.
1284         (dot_ops): Remove uppercase versions and the end marker.
1285         (f77_keywords): Likewise.
1286         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1287         entries in the dot_ops array are case insensitive, and use
1288         strncasecmp to compare strings.  Also some whitespace cleanup in
1289         this area.  Similar for the f77_keywords array, except entries in
1290         this list might be case sensitive.
1291
1292 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
1293
1294         * f-exp.y (struct f77_boolean_val): Add comments.
1295         (boolean_values): Remove uppercase versions, and end marker.
1296         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1297         and use strncasecmp to achieve case insensitivity.  Additionally,
1298         perform whitespace cleanup around this code.
1299
1300 2019-03-06  Tom Tromey  <tromey@adacore.com>
1301
1302         * remote-sim.c (gdbsim_target_open): Use result of
1303         gdb_argv::release.
1304
1305 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
1306         Dirk Schubert  <dirk.schubert@arm.com>
1307         Chris January  <chris.january@arm.com>
1308
1309         * eval.c (evaluate_subexp_standard): Call Fortran argument
1310         wrapping logic.
1311         * f-lang.c (struct value): A value which can be passed into a
1312         Fortran function call.
1313         (fortran_argument_convert): Wrap Fortran arguments in a pointer
1314         where appropriate.
1315         (struct type): Value ready for a Fortran function call.
1316         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1317         is needed.
1318         * f-lang.h (fortran_argument_convert): Declaration.
1319         (fortran_preserve_arg_pointer): Declaration.
1320         * infcall.c (value_arg_coerce): Call Fortran argument logic.
1321
1322 2019-03-05  Tom Tromey  <tromey@adacore.com>
1323
1324         * python/py-prettyprint.c (print_string_repr): Remove #if.
1325         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1326
1327 2019-03-05  Tom Tromey  <tromey@adacore.com>
1328
1329         * target.c (the_dummy_target): Move later.  Change type to
1330         "dummy_target".
1331         (initialize_targets): Don't initialize the_dummy_target.
1332
1333 2019-03-05  Tom Tromey  <tromey@adacore.com>
1334
1335         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1336         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1337
1338 2019-03-05  Tom Tromey  <tromey@adacore.com>
1339
1340         * windows-nat.c (windows_nat_target::attach)
1341         (windows_nat_target::detach): Don't call gdb_flush.
1342         * valprint.c (generic_val_print, val_print, val_print_string):
1343         Don't call gdb_flush.
1344         * utils.c (defaulted_query): Don't call gdb_flush.
1345         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1346         * target.c (target_announce_detach): Don't call gdb_flush.
1347         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1348         * remote.c (extended_remote_target::attach): Don't call
1349         gdb_flush.
1350         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1351         * printcmd.c (do_examine): Don't call gdb_flush.
1352         (info_display_command): Don't call gdb_flush.
1353         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1354         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1355         * memattr.c (info_mem_command): Don't call gdb_flush.
1356         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1357         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1358         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1359         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1360         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1361         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1362         (gnu_nat_target::detach): Don't call gdb_flush.
1363         * f-valprint.c (f_val_print): Don't call gdb_flush.
1364         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1365         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1366         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1367         gdb_flush.
1368         * c-valprint.c (c_val_print): Don't call gdb_flush.
1369         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1370
1371 2019-03-05  Tom Tromey  <tromey@adacore.com>
1372
1373         * varobj.c (update_dynamic_varobj_children): Update.
1374         (install_default_visualizer): Use reset, not release.
1375         * value.c (set_internalvar): Update.
1376         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1377         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1378         ATTRIBUTE_UNUSED_RESULT.
1379
1380 2019-03-05  Tom Tromey  <tromey@adacore.com>
1381
1382         * remote.c (class scoped_remote_fd) <release>: Add
1383         ATTRIBUTE_UNUSED_RESULT.
1384
1385 2019-03-05  Tom Tromey  <tromey@adacore.com>
1386
1387         * macroexp.c (struct macro_buffer) <release>: Add
1388         ATTRIBUTE_UNUSED_RESULT.
1389
1390 2019-03-05  Tom Tromey  <tromey@adacore.com>
1391
1392         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1393         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1394         ATTRIBUTE_UNUSED_RESULT.
1395
1396 2019-03-05  Tom Tromey  <tromey@adacore.com>
1397
1398         * common/scoped_fd.h (class scoped_fd) <release>: Add
1399         ATTRIBUTE_UNUSED_RESULT.
1400
1401 2019-03-05  Tom Tromey  <tromey@adacore.com>
1402
1403         * parser-defs.h (struct parser_state) <release>: Add
1404         ATTRIBUTE_UNUSED_RESULT.
1405
1406 2019-03-05  Tom Tromey  <tromey@adacore.com>
1407
1408         * utils.h (class gdb_argv) <release>: Add
1409         ATTRIBUTE_UNUSED_RESULT.
1410         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1411
1412 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1413
1414         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1415         for-loop range, to avoid compiler warnings.
1416
1417         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1418         avoid compiler warnings about unused variables.
1419
1420         * NEWS: Mention end of support for native debugging on MS-Windows
1421         before XP.
1422
1423         PR gdb/24292
1424         * common/netstuff.c:
1425         * gdbserver/gdbreplay.c
1426         * gdbserver/remote-utils.c:
1427         * ser-tcp.c:
1428         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1429         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1430         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1431         'getaddrinfo' and 'freeaddrinfo' were not available before
1432         Windows XP, and mingw.org's MinGW headers by default define
1433         _WIN32_WINNT to 0x500.
1434
1435 2019-03-01  Gary Benson <gbenson@redhat.com>
1436
1437         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1438
1439 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1440             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1441
1442         PR gdb/8527
1443         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1444         set_sigint_trap, clear_sigint_trap.
1445
1446 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1447
1448         * target.c (target_detach): Clear the regcache and the
1449         frame cache.
1450
1451 2019-02-27  Pedro Alves  <palves@redhat.com>
1452
1453         * utils.c (set_screen_size): When we cap the height/width sizes,
1454         tweak the corresponding command variable to show "unlimited":
1455
1456 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1457             Pedro Alves  <palves@redhat.com>
1458
1459         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1460         before calling rl_set_screen_size.
1461
1462 2019-02-27  Tom Tromey  <tromey@adacore.com>
1463
1464         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1465         define.
1466         * python/py-value.c: Remove Python 2.4 workaround.
1467         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1468         workaround.
1469         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1470         Python 2.4 workaround.
1471         * python/python-internal.h: Remove Python 2.4 comment.
1472         (Py_ssize_t): Don't define.
1473         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1474         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1475         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1476         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1477         * python/python.c (do_start_initialization): Remove Python 2.4
1478         workaround.
1479         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1480         (print_children): Remove Python 2.4 workaround.
1481         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1482         workaround.
1483         (CHARBUFFERPROC_NAME): Remove.
1484         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1485         Python 2.4 workaround.
1486
1487 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1488
1489         * NEWS: Note minimum Python version.
1490
1491 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1492
1493         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1494         code from these functions.  Remove corresponding ifdefs.  Use
1495         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1496         Remove gotos and target of gotos.
1497         (infpy_search_memory): Likewise.
1498
1499 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1500
1501         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1502         (hppa_gdbarch_init): Don't register deleted functions with
1503         gdbarch.
1504
1505 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1506
1507         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1508         (h8300_unwind_sp): Delete.
1509         (h8300_dummy_id): Delete.
1510         (h8300_gdbarch_init): Don't register deleted functions with
1511         gdbarch.
1512
1513 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1514
1515         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1516         (ft32_unwind_pc): Delete.
1517         (ft32_unwind_sp): Delete.
1518         (ft32_gdbarch_init): Don't register deleted functions with
1519         gdbarch.
1520
1521 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1522
1523         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1524         (frv_unwind_pc): Delete.
1525         (frv_unwind_sp): Delete.
1526         (frv_gdbarch_init): Don't register deleted functions with
1527         gdbarch.
1528
1529 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1530
1531         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1532         (riscv_unwind_pc): Delete.
1533         (riscv_unwind_sp): Delete.
1534         (riscv_gdbarch_init): Don't register deleted functions with
1535         gdbarch.
1536
1537 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1538
1539         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1540         (csky_unwind_pc): Delete.
1541         (csky_unwind_sp): Delete.
1542         (csky_gdbarch_init): Don't register deleted functions with
1543         gdbarch.
1544
1545 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1546
1547         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1548         (cris_unwind_pc): Delete.
1549         (cris_unwind_sp): Delete.
1550         (cris_gdbarch_init): Don't register deleted functions with
1551         gdbarch.
1552
1553 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1554
1555         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1556         (bfin_unwind_pc): Delete.
1557         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1558
1559 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1560
1561         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1562         (arm_unwind_pc): Delete.
1563         (arm_unwind_sp): Delete.
1564         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1565
1566 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1567
1568         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1569         (arc_unwind_pc): Delete.
1570         (arc_unwind_sp): Delete.
1571         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1572
1573 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1574
1575         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1576         (alpha_unwind_pc): Delete.
1577         (alpha_gdbarch_init): Don't register deleted functions with
1578         gdbarch.
1579
1580 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1581
1582         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1583         (aarch64_unwind_pc): Delete.
1584         (aarch64_unwind_sp): Delete.
1585         (aarch64_gdbarch_init): Don't register deleted functions with
1586         gdbarch.
1587
1588 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1589
1590         * gdbtypes.c (type_align): Don't consider static members when
1591         computing structure alignment.
1592
1593 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1594
1595         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1596         return 0 for other types.
1597         * arch-utils.c (default_type_align): Always return 0.
1598         * gdbarch.h: Regenerate.
1599         * gdbarch.sh (type_align): Extend comment.
1600         * gdbtypes.c (type_align): Add additional comments, always call
1601         gdbarch_type_align before applying the default rules.
1602         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1603         generic code will then apply a suitable default.
1604         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1605         types, return 0 for other types.
1606
1607 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1608
1609         * NEWS: Create a new section for the next release branch.
1610         Rename the section of the current branch, now that it has
1611         been cut.
1612
1613 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1614
1615         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1616         * version.in: Bump version to 8.3.50.DATE-git.
1617
1618 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1619
1620         * aix-thread.c (ptid_cmp): Remove unused variable.
1621         (get_signaled_thread): Likewise.
1622         (store_regs_user_thread): Likewise.
1623         (store_regs_kernel_thread): Likewise.
1624         (fetch_regs_kernel_thread): Remove shadowed variable.
1625
1626 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1627
1628         * features/riscv/32bit-cpu.xml: Add register numbers.
1629         * features/riscv/32bit-fpu.c: Regenerate.
1630         * features/riscv/32bit-fpu.xml: Add register numbers.
1631         * features/riscv/64bit-cpu.xml: Add register numbers.
1632         * features/riscv/64bit-fpu.c: Regenerate.
1633         * features/riscv/64bit-fpu.xml: Add register numbers.
1634
1635 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1636
1637         * NEWS: Mention two argument form of gdb.Value constructor.
1638         * python/py-value.c (convert_buffer_and_type_to_value): New
1639         function.
1640         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1641         Add support for handling an optional second argument.  Call
1642         convert_buffer_and_type_to_value as appropriate.
1643         * python/python-internal.h (Py_buffer_deleter): New struct.
1644         (Py_buffer_up): New typedef.
1645
1646 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1647
1648         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1649         instead of releasing ownership.
1650
1651 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1652
1653         * dwarf2read.c (open_and_init_dwp_file): Call
1654         elf_numsections instead of bfd_count_sections to initialize
1655         dwp_file->num_sections.
1656
1657 2019-02-25  Tom Tromey  <tromey@adacore.com>
1658
1659         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1660
1661 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1662
1663         * gcore.in: Add '--readnever' option when invoking GDB.
1664
1665 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1666
1667         * MAINTAINERS: Update my email address.
1668
1669 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1670
1671         * build-id.c (build_id_to_debug_bfd_1): New function.
1672         (build_id_to_debug_bfd): Look for separate debug file in
1673         sysroot.
1674
1675 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1676
1677         * gdbarch.sh: Update the copyright year range that is placed into
1678         generated files.
1679
1680 2019-02-22  Keith Seitz  <keiths@redhat.com>
1681
1682         PR symtab/23853
1683         * linespec.c (create_sals_line_offset): Search for the default
1684         symtab's filename instead of its fullname.
1685
1686 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1687
1688         * NEWS: Update style defaults.
1689
1690 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1691
1692         * main.c (captured_main_1): Disable styling in batch mode.
1693
1694 2019-02-20  Tom Tromey  <tom@tromey.com>
1695
1696         * symtab.c (symtab_symbol_info): Fix typos.
1697
1698 2019-02-20  Tom Tromey  <tromey@adacore.com>
1699
1700         * findcmd.c (_initialize_mem_search): Use upper case for
1701         metasyntactic variables.
1702
1703 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1704
1705         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1706         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1707
1708 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1709
1710         * top.h (source_file_name): Change to std::string.
1711         * top.c (source_file_name): Likewise.
1712         (command_line_input): Adjust.
1713         * cli/cli-script.c (script_from_file): Adjust.
1714
1715 2019-02-19  Tom Tromey  <tromey@adacore.com>
1716
1717         * ravenscar-thread.c
1718         (ravenscar_thread_target::update_thread_list): Don't call
1719         ada_build_task_list.
1720         * ada-lang.h (ada_build_task_list): Don't declare.
1721         * ada-tasks.c (struct ada_tasks_inferior_data)
1722         <task_list_valid_p>: Now bool.
1723         (read_known_tasks, ada_task_list_changed)
1724         (ada_tasks_invalidate_inferior_data): Update.
1725         (read_known_tasks_array): Return bool.
1726         (read_known_tasks_list): Likewise.
1727         (read_known_tasks): Return void.
1728         (ada_build_task_list): Now static.
1729
1730 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1731
1732         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1733         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1734
1735 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1736
1737         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1738         variant for ada_tasks_pspace_data_handle and
1739         ada_tasks_inferior_data_handle.
1740         (ada_tasks_pspace_data_cleanup): New function.
1741         (ada_tasks_inferior_data_cleanup): New function.
1742
1743 2019-02-17  Tom Tromey  <tom@tromey.com>
1744
1745         * macrotab.h (macro_source_fullname): Return a std::string.
1746         * macrotab.c (macro_include, check_for_redefinition)
1747         (macro_undef, macro_lookup_definition, foreach_macro)
1748         (foreach_macro_in_scope): Update.
1749         (macro_source_fullname): Return a std::string.
1750         * macrocmd.c (show_pp_source_pos): Update.
1751
1752 2019-02-17  Tom Tromey  <tom@tromey.com>
1753
1754         * macrocmd.c (show_pp_source_pos): Style the file names.
1755
1756 2019-02-17  Tom Tromey  <tom@tromey.com>
1757
1758         PR tui/24197:
1759         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1760
1761 2019-02-17  Tom Tromey  <tom@tromey.com>
1762
1763         * ada-lang.c (user_select_syms): Use filtered printing.
1764         * utils.c (wrap_style): New global.
1765         (desired_style): Remove.
1766         (emit_style_escape): Add stream parameter.
1767         (set_output_style, reset_terminal_style, prompt_for_continue):
1768         Update.
1769         (flush_wrap_buffer): Only flush gdb_stdout.
1770         (wrap_here): Set wrap_style.
1771         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1772         treat escape sequences as a character.  Change when wrap buffer is
1773         flushed.
1774         (fputs_styled): Do not set the output style when the default is
1775         requested.
1776         * ui-style.h (struct ui_file_style) <is_default>: New method.
1777         * source.c (print_source_lines_base): Emit escape sequences in one
1778         piece.
1779
1780 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1781
1782         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1783         integers and enumeration types.
1784
1785 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1786
1787         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1788         instead of lookup_symbol_in_language
1789         (do_exact_match): New function.
1790         (ada_get_symbol_name_matcher): Return do_exact_match when
1791         doing a verbatim match.
1792
1793 2019-02-15  Tom Tromey  <tromey@adacore.com>
1794
1795         * ravenscar-thread.c (ravenscar_thread_target::resume)
1796         (ravenscar_thread_target::wait): Special case wildcard requests.
1797
1798 2019-02-15  Tom Tromey  <tromey@adacore.com>
1799
1800         * ravenscar-thread.c (base_ptid): Remove.
1801         (struct ravenscar_thread_target) <close>: New method.
1802         <m_base_ptid>: New member.
1803         <update_inferior_ptid, active_task, task_is_currently_active,
1804         runtime_initialized>: Declare methods.
1805         <ravenscar_thread_target>: Add constructor.
1806         (ravenscar_thread_target::task_is_currently_active)
1807         (ravenscar_thread_target::update_inferior_ptid)
1808         (ravenscar_runtime_initialized): Rename.  Now methods.
1809         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1810         (ravenscar_thread_target::update_thread_list): Update.
1811         (ravenscar_thread_target::active_task): Now method.
1812         (ravenscar_thread_target::store_registers)
1813         (ravenscar_thread_target::prepare_to_store)
1814         (ravenscar_thread_target::prepare_to_store)
1815         (ravenscar_thread_target::mourn_inferior): Update.
1816         (ravenscar_inferior_created): Use "new" to create target.
1817         (ravenscar_thread_target::get_ada_task_ptid): Update.
1818         (_initialize_ravenscar): Don't initialize base_ptid.
1819         (ravenscar_ops): Remove global.
1820
1821 2019-02-15  Tom Tromey  <tromey@adacore.com>
1822
1823         * target.h (push_target): Declare new overload.
1824         * target.c (push_target): New overload, taking an rvalue reference.
1825         * remote.c (remote_target::open_1): Use push_target overload.
1826         * corelow.c (core_target_open): Use push_target overload.
1827
1828 2019-02-15  Tom Tromey  <tromey@adacore.com>
1829
1830         * ravenscar-thread.c (is_ravenscar_task)
1831         (ravenscar_task_is_currently_active): Return bool.
1832         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1833         (_initialize_ravenscar): Remove "(void)".
1834         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1835         Return bool.
1836
1837 2019-02-15  Tom Tromey  <tromey@adacore.com>
1838
1839         * ravenscar-thread.c (ravenscar_runtime_initializer)
1840         (has_ravenscar_runtime, get_running_thread_id)
1841         (ravenscar_thread_target::resume): Fix indentation.
1842
1843 2019-02-15  Tom Tromey  <tromey@adacore.com>
1844
1845         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1846         from ravenscar_arch_ops.
1847         (sparc_ravenscar_ops::fetch_registers)
1848         (sparc_ravenscar_ops::store_registers): Now methods.
1849         (sparc_ravenscar_prepare_to_store): Remove.
1850         (sparc_ravenscar_ops): Redefine.
1851         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1852         methods and destructor.  Remove members.
1853         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1854         (ravenscar_thread_target::store_registers)
1855         (ravenscar_thread_target::prepare_to_store): Update.
1856         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1857         Remove.
1858         (struct ppc_ravenscar_powerpc_ops): Derive from
1859         ravenscar_arch_ops.
1860         (ppc_ravenscar_powerpc_ops::fetch_registers)
1861         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1862         (ppc_ravenscar_powerpc_ops): Redefine.
1863         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1864         (ppc_ravenscar_e500_ops::fetch_registers)
1865         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1866         (ppc_ravenscar_e500_ops): Redefine.
1867         * aarch64-ravenscar-thread.c
1868         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1869         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1870         (aarch64_ravenscar_fetch_registers)
1871         (aarch64_ravenscar_store_registers): Now methods.
1872         (aarch64_ravenscar_ops): Redefine.
1873
1874 2019-02-15  Tom Tromey  <tromey@adacore.com>
1875
1876         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1877         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1878         (ravenscar_thread_target::stopped_by_watchpoint)
1879         (ravenscar_thread_target::stopped_data_address)
1880         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1881
1882 2019-02-15  Tom Tromey  <tromey@adacore.com>
1883
1884         * ravenscar-thread.c: Fix some typos.
1885
1886 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1887             Tom Tromey  <tromey@adacore.com>
1888
1889         * ada-lang.c (ada_exception_sal): Change addr_string to a
1890         std::string.
1891         (create_ada_exception_catchpoint): Update.
1892
1893 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1894             Tom Tromey  <tromey@adacore.com>
1895
1896         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1897         (bp_location_ops): Remove.
1898         (base_breakpoint_allocate_location): Update.
1899         (free_bp_location): Update.
1900         * ada-lang.c (class ada_catchpoint_location)
1901         <ada_catchpoint_location>: Remove ops parameter.
1902         (ada_catchpoint_location_dtor): Remove.
1903         (ada_catchpoint_location_ops): Remove.
1904         (allocate_location_exception): Update.
1905         * breakpoint.h (struct bp_location_ops): Remove.
1906         (class bp_location) <bp_location>: Remove bp_location_ops
1907         parameter.
1908         <~bp_location>: Add destructor.
1909         <ops>: Remove.
1910
1911 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1912             Pedro Alves  <palves@redhat.com>
1913
1914         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1915         'PATH_MAX'.
1916
1917 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1918             Samuel Thibault  <samuel.thibault@gnu.org>
1919             Thomas Schwinge  <thomas@codesourcery.com>
1920
1921         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1922         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1923
1924 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1925
1926         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1927         (check_empty): Use "const char *".
1928
1929         * gnu-nat.c (gnu_nat_target::detach): Instead of
1930         'detach_inferior (pid)' call
1931         'detach_inferior (find_inferior_pid (pid))'.
1932
1933         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1934         'nat/fork-inferior.o'.
1935         * gnu-nat.c: #include "nat/fork-inferior.h".
1936
1937         * gnu-nat.c (gnu_nat_target::detach): Instead of
1938         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1939         * gnu-nat.h: #include "inf-child.h".
1940         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1941         'i386_gnu_nat_target::fetch_registers'.
1942         (gnu_store_registers): Rename/move to
1943         'i386_gnu_nat_target::store_registers'.
1944
1945         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1946         * gnu-nat.h (mach_thread_info): New function.
1947         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1948
1949         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1950
1951 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1952
1953         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1954
1955 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1956
1957         * windows-nat.c (windows_add_thread): Add new parameter
1958         "main_thread_p" with default value set to false.  Update
1959         function documentation as well as all callers.
1960         (windows_delete_thread): Likewise.
1961         (fake_create_process): Update call to windows_add_thread.
1962         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1963         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1964         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1965         call to windows_delete_thread.
1966
1967 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1968
1969         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1970
1971 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1972
1973         * symfile.c (find_separate_debug_file): Use canonical path of
1974         sysroot with child_path instead of gdb_sysroot if it is valid.
1975
1976 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1977
1978         * symfile.c (find_separate_debug_file): Use child_path to
1979         determine if an object file is under a sysroot.
1980
1981 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1982
1983         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1984         unittests/child-path-selftests.c.
1985         * common/pathstuff.c (child_path): New function.
1986         * common/pathstuff.h (child_path): New prototype.
1987         * unittests/child-path-selftests.c: New file.
1988
1989 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1990
1991         * symfile.c (find_separate_debug_file): Look for separate debug
1992         files in debug directories under the sysroot.
1993
1994 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1995
1996         * symtab.h (struct minimal_symbol data_p): New const method.
1997         (struct minimal_symbol text_p): Likewise.
1998         * symtab.c (output_source_filename): Use file name style
1999         to print file name.
2000         (print_symbol_info): Likewise.
2001         (print_msymbol_info): Use address style to print addresses.
2002         Use function name style to print executable text symbols.
2003         (expand_symtab_containing_pc): Use data_p.
2004         (find_pc_sect_compunit_symtab): Likewise.
2005
2006 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2007
2008         * breakpoint.c (describe_other_breakpoints): Use address style
2009         to print addresses.
2010         (say_where): Likewise.
2011
2012 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2013
2014         * ada-typeprint.c (print_func_type): Print function name
2015         style to print function name.
2016         * c-typeprint.c (c_print_type_1): Likewise.
2017
2018 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
2019
2020         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
2021         for execve.
2022
2023 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2024
2025         * c-exp.y (direct_abs_decl): Use emplace_back to record the
2026         type_stack.
2027
2028 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
2029
2030         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
2031         TYPE_CODE_REF types.
2032
2033 2019-02-08  Jim Wilson  <jimw@sifive.com>
2034
2035         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
2036         (riscv_linux_fregset): New.
2037         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
2038
2039 2019-02-07  Tom Tromey  <tom@tromey.com>
2040
2041         * thread.c (thread_cancel_execution_command): Update.
2042         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
2043         methods.
2044         (struct thread_fsm_ops): Remove.
2045         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
2046         (thread_fsm_should_stop, thread_fsm_return_value)
2047         (thread_fsm_set_finished, thread_fsm_finished_p)
2048         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
2049         Don't declare.
2050         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
2051         * infrun.c (clear_proceed_status_thread)
2052         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
2053         (print_stop_event): Update.
2054         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
2055         Add constructor.
2056         (step_command_fsm_ops): Remove.
2057         (new_step_command_fsm): Remove.
2058         (step_1): Update.
2059         (step_command_fsm::should_stop): Rename from
2060         step_command_fsm_should_stop.
2061         (step_command_fsm::clean_up): Rename from
2062         step_command_fsm_clean_up.
2063         (step_command_fsm::do_async_reply_reason): Rename from
2064         step_command_fsm_async_reply_reason.
2065         (struct until_next_fsm): Inherit from thread_fsm.  Add
2066         constructor.
2067         (until_next_fsm_ops): Remove.
2068         (new_until_next_fsm): Remove.
2069         (until_next_fsm::should_stop): Rename from
2070         until_next_fsm_should_stop.
2071         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
2072         (until_next_fsm::do_async_reply_reason): Rename from
2073         until_next_fsm_async_reply_reason.
2074         (struct finish_command_fsm): Inherit from thread_fsm.  Add
2075         constructor.  Change type of breakpoint.
2076         (finish_command_fsm_ops): Remove.
2077         (new_finish_command_fsm): Remove.
2078         (finish_command_fsm::should_stop): Rename from
2079         finish_command_fsm_should_stop.
2080         (finish_command_fsm::clean_up): Rename from
2081         finish_command_fsm_clean_up.
2082         (finish_command_fsm::return_value): Rename from
2083         finish_command_fsm_return_value.
2084         (finish_command_fsm::do_async_reply_reason): Rename from
2085         finish_command_fsm_async_reply_reason.
2086         (finish_command): Update.
2087         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
2088         Add constructor.
2089         (call_thread_fsm_ops): Remove.
2090         (call_thread_fsm::call_thread_fsm): Rename from
2091         new_call_thread_fsm.
2092         (call_thread_fsm::should_stop): Rename from
2093         call_thread_fsm_should_stop.
2094         (call_thread_fsm::should_notify_stop): Rename from
2095         call_thread_fsm_should_notify_stop.
2096         (run_inferior_call, call_function_by_hand_dummy): Update.
2097         * cli/cli-interp.c (should_print_stop_to_console): Update.
2098         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
2099         Add constructor.  Change type of location_breakpoint,
2100         caller_breakpoint.
2101         (until_break_fsm_ops): Remove.
2102         (new_until_break_fsm): Remove.
2103         (until_break_fsm::should_stop): Rename from
2104         until_break_fsm_should_stop.
2105         (until_break_fsm::clean_up): Rename from
2106         until_break_fsm_clean_up.
2107         (until_break_fsm::do_async_reply_reason): Rename from
2108         until_break_fsm_async_reply_reason.
2109         (until_break_command): Update.
2110         * thread-fsm.c: Remove.
2111         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
2112
2113 2019-02-07  Tom Tromey  <tom@tromey.com>
2114
2115         * yy-remap.h: Add include guard.
2116         * xtensa-tdep.h: Add include guard.
2117         * xcoffread.h: Rename include guard.
2118         * varobj-iter.h: Add include guard.
2119         * tui/tui.h: Rename include guard.
2120         * tui/tui-winsource.h: Rename include guard.
2121         * tui/tui-wingeneral.h: Rename include guard.
2122         * tui/tui-windata.h: Rename include guard.
2123         * tui/tui-win.h: Rename include guard.
2124         * tui/tui-stack.h: Rename include guard.
2125         * tui/tui-source.h: Rename include guard.
2126         * tui/tui-regs.h: Rename include guard.
2127         * tui/tui-out.h: Rename include guard.
2128         * tui/tui-layout.h: Rename include guard.
2129         * tui/tui-io.h: Rename include guard.
2130         * tui/tui-hooks.h: Rename include guard.
2131         * tui/tui-file.h: Rename include guard.
2132         * tui/tui-disasm.h: Rename include guard.
2133         * tui/tui-data.h: Rename include guard.
2134         * tui/tui-command.h: Rename include guard.
2135         * tic6x-tdep.h: Add include guard.
2136         * target/waitstatus.h: Rename include guard.
2137         * target/wait.h: Rename include guard.
2138         * target/target.h: Rename include guard.
2139         * target/resume.h: Rename include guard.
2140         * target-float.h: Rename include guard.
2141         * stabsread.h: Add include guard.
2142         * rs6000-tdep.h: Add include guard.
2143         * riscv-fbsd-tdep.h: Add include guard.
2144         * regformats/regdef.h: Rename include guard.
2145         * record.h: Rename include guard.
2146         * python/python.h: Rename include guard.
2147         * python/python-internal.h: Rename include guard.
2148         * python/py-stopevent.h: Rename include guard.
2149         * python/py-ref.h: Rename include guard.
2150         * python/py-record.h: Rename include guard.
2151         * python/py-record-full.h: Rename include guard.
2152         * python/py-record-btrace.h: Rename include guard.
2153         * python/py-instruction.h: Rename include guard.
2154         * python/py-events.h: Rename include guard.
2155         * python/py-event.h: Rename include guard.
2156         * procfs.h: Add include guard.
2157         * proc-utils.h: Add include guard.
2158         * p-lang.h: Add include guard.
2159         * or1k-tdep.h: Rename include guard.
2160         * observable.h: Rename include guard.
2161         * nto-tdep.h: Rename include guard.
2162         * nat/x86-linux.h: Rename include guard.
2163         * nat/x86-linux-dregs.h: Rename include guard.
2164         * nat/x86-gcc-cpuid.h: Add include guard.
2165         * nat/x86-dregs.h: Rename include guard.
2166         * nat/x86-cpuid.h: Rename include guard.
2167         * nat/ppc-linux.h: Rename include guard.
2168         * nat/mips-linux-watch.h: Rename include guard.
2169         * nat/linux-waitpid.h: Rename include guard.
2170         * nat/linux-ptrace.h: Rename include guard.
2171         * nat/linux-procfs.h: Rename include guard.
2172         * nat/linux-osdata.h: Rename include guard.
2173         * nat/linux-nat.h: Rename include guard.
2174         * nat/linux-namespaces.h: Rename include guard.
2175         * nat/linux-btrace.h: Rename include guard.
2176         * nat/glibc_thread_db.h: Rename include guard.
2177         * nat/gdb_thread_db.h: Rename include guard.
2178         * nat/gdb_ptrace.h: Rename include guard.
2179         * nat/fork-inferior.h: Rename include guard.
2180         * nat/amd64-linux-siginfo.h: Rename include guard.
2181         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
2182         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
2183         * nat/aarch64-linux.h: Rename include guard.
2184         * nat/aarch64-linux-hw-point.h: Rename include guard.
2185         * mn10300-tdep.h: Add include guard.
2186         * mips-linux-tdep.h: Add include guard.
2187         * mi/mi-parse.h: Rename include guard.
2188         * mi/mi-out.h: Rename include guard.
2189         * mi/mi-main.h: Rename include guard.
2190         * mi/mi-interp.h: Rename include guard.
2191         * mi/mi-getopt.h: Rename include guard.
2192         * mi/mi-console.h: Rename include guard.
2193         * mi/mi-common.h: Rename include guard.
2194         * mi/mi-cmds.h: Rename include guard.
2195         * mi/mi-cmd-break.h: Rename include guard.
2196         * m2-lang.h: Add include guard.
2197         * location.h: Rename include guard.
2198         * linux-record.h: Rename include guard.
2199         * linux-nat.h: Add include guard.
2200         * linux-fork.h: Add include guard.
2201         * i386-darwin-tdep.h: Rename include guard.
2202         * hppa-linux-offsets.h: Add include guard.
2203         * guile/guile.h: Rename include guard.
2204         * guile/guile-internal.h: Rename include guard.
2205         * gnu-nat.h: Rename include guard.
2206         * gdb-stabs.h: Rename include guard.
2207         * frv-tdep.h: Add include guard.
2208         * f-lang.h: Add include guard.
2209         * event-loop.h: Add include guard.
2210         * darwin-nat.h: Rename include guard.
2211         * cp-abi.h: Rename include guard.
2212         * config/sparc/nm-sol2.h: Rename include guard.
2213         * config/nm-nto.h: Rename include guard.
2214         * config/nm-linux.h: Add include guard.
2215         * config/i386/nm-i386gnu.h: Rename include guard.
2216         * config/djgpp/nl_types.h: Rename include guard.
2217         * config/djgpp/langinfo.h: Rename include guard.
2218         * compile/gcc-cp-plugin.h: Add include guard.
2219         * compile/gcc-c-plugin.h: Add include guard.
2220         * compile/compile.h: Rename include guard.
2221         * compile/compile-object-run.h: Rename include guard.
2222         * compile/compile-object-load.h: Rename include guard.
2223         * compile/compile-internal.h: Rename include guard.
2224         * compile/compile-cplus.h: Rename include guard.
2225         * compile/compile-c.h: Rename include guard.
2226         * common/xml-utils.h: Rename include guard.
2227         * common/x86-xstate.h: Rename include guard.
2228         * common/version.h: Rename include guard.
2229         * common/vec.h: Rename include guard.
2230         * common/tdesc.h: Rename include guard.
2231         * common/selftest.h: Rename include guard.
2232         * common/scoped_restore.h: Rename include guard.
2233         * common/scoped_mmap.h: Rename include guard.
2234         * common/scoped_fd.h: Rename include guard.
2235         * common/safe-iterator.h: Rename include guard.
2236         * common/run-time-clock.h: Rename include guard.
2237         * common/refcounted-object.h: Rename include guard.
2238         * common/queue.h: Rename include guard.
2239         * common/ptid.h: Rename include guard.
2240         * common/print-utils.h: Rename include guard.
2241         * common/preprocessor.h: Rename include guard.
2242         * common/pathstuff.h: Rename include guard.
2243         * common/observable.h: Rename include guard.
2244         * common/netstuff.h: Rename include guard.
2245         * common/job-control.h: Rename include guard.
2246         * common/host-defs.h: Rename include guard.
2247         * common/gdb_wait.h: Rename include guard.
2248         * common/gdb_vecs.h: Rename include guard.
2249         * common/gdb_unlinker.h: Rename include guard.
2250         * common/gdb_unique_ptr.h: Rename include guard.
2251         * common/gdb_tilde_expand.h: Rename include guard.
2252         * common/gdb_sys_time.h: Rename include guard.
2253         * common/gdb_string_view.h: Rename include guard.
2254         * common/gdb_splay_tree.h: Rename include guard.
2255         * common/gdb_setjmp.h: Rename include guard.
2256         * common/gdb_ref_ptr.h: Rename include guard.
2257         * common/gdb_optional.h: Rename include guard.
2258         * common/gdb_locale.h: Rename include guard.
2259         * common/gdb_assert.h: Rename include guard.
2260         * common/filtered-iterator.h: Rename include guard.
2261         * common/filestuff.h: Rename include guard.
2262         * common/fileio.h: Rename include guard.
2263         * common/environ.h: Rename include guard.
2264         * common/common-utils.h: Rename include guard.
2265         * common/common-types.h: Rename include guard.
2266         * common/common-regcache.h: Rename include guard.
2267         * common/common-inferior.h: Rename include guard.
2268         * common/common-gdbthread.h: Rename include guard.
2269         * common/common-exceptions.h: Rename include guard.
2270         * common/common-defs.h: Rename include guard.
2271         * common/common-debug.h: Rename include guard.
2272         * common/cleanups.h: Rename include guard.
2273         * common/buffer.h: Rename include guard.
2274         * common/btrace-common.h: Rename include guard.
2275         * common/break-common.h: Rename include guard.
2276         * cli/cli-utils.h: Rename include guard.
2277         * cli/cli-style.h: Rename include guard.
2278         * cli/cli-setshow.h: Rename include guard.
2279         * cli/cli-script.h: Rename include guard.
2280         * cli/cli-interp.h: Rename include guard.
2281         * cli/cli-decode.h: Rename include guard.
2282         * cli/cli-cmds.h: Rename include guard.
2283         * charset-list.h: Add include guard.
2284         * buildsym-legacy.h: Rename include guard.
2285         * bfin-tdep.h: Add include guard.
2286         * ax.h: Rename include guard.
2287         * arm-linux-tdep.h: Add include guard.
2288         * arm-fbsd-tdep.h: Add include guard.
2289         * arch/xtensa.h: Rename include guard.
2290         * arch/tic6x.h: Add include guard.
2291         * arch/i386.h: Add include guard.
2292         * arch/arm.h: Rename include guard.
2293         * arch/arm-linux.h: Rename include guard.
2294         * arch/arm-get-next-pcs.h: Rename include guard.
2295         * arch/amd64.h: Add include guard.
2296         * arch/aarch64-insn.h: Rename include guard.
2297         * arch-utils.h: Rename include guard.
2298         * annotate.h: Add include guard.
2299         * amd64-darwin-tdep.h: Rename include guard.
2300         * aarch64-linux-tdep.h: Add include guard.
2301         * aarch64-fbsd-tdep.h: Add include guard.
2302         * aarch32-linux-nat.h: Add include guard.
2303
2304 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2305
2306         * macrotab.c (macro_define_internal): New function that
2307         factorizes macro_define_object_internal and macro_define_function
2308         code.
2309         (macro_define_object_internal): Use macro_define_internal.
2310         (macro_define_function): Likewise.
2311
2312 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2313
2314         * macrocmd.c (extract_identifier): Return
2315         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2316         callers.
2317
2318 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
2319
2320         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2321
2322 2019-02-05  Tom Tromey  <tom@tromey.com>
2323
2324         * target.c (target_stack::unpush): Move assertion earlier.
2325
2326 2019-01-30  Tom Tromey  <tom@tromey.com>
2327
2328         PR python/23615:
2329         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2330         (gdbpy_parse_and_eval): Likewise.
2331         * python/python-internal.h (gdbpy_allow_threads): New class.
2332
2333 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
2334
2335         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2336         (aarch64_fbsd_fpregmap): Move earlier.
2337         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2338         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2339         instead of individual calls to trad_frame_set_reg_addr.
2340         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2341         earlier.
2342         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2343         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2344         instead of individual calls to trad_frame_set_reg_addr.
2345
2346 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2347
2348         * CONTRIBUTE: Replace contribution list with wiki link.
2349
2350 2019-01-25  Tom Tromey  <tom@tromey.com>
2351
2352         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2353
2354 2019-01-25  Tom Tromey  <tom@tromey.com>
2355
2356         * xtensa-linux-nat.c: Fix common/ includes.
2357         * xml-support.h: Fix common/ includes.
2358         * xml-support.c: Fix common/ includes.
2359         * x86-linux-nat.c: Fix common/ includes.
2360         * windows-nat.c: Fix common/ includes.
2361         * varobj.h: Fix common/ includes.
2362         * varobj.c: Fix common/ includes.
2363         * value.c: Fix common/ includes.
2364         * valops.c: Fix common/ includes.
2365         * utils.c: Fix common/ includes.
2366         * unittests/xml-utils-selftests.c: Fix common/ includes.
2367         * unittests/utils-selftests.c: Fix common/ includes.
2368         * unittests/unpack-selftests.c: Fix common/ includes.
2369         * unittests/tracepoint-selftests.c: Fix common/ includes.
2370         * unittests/style-selftests.c: Fix common/ includes.
2371         * unittests/string_view-selftests.c: Fix common/ includes.
2372         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2373         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2374         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2375         * unittests/rsp-low-selftests.c: Fix common/ includes.
2376         * unittests/parse-connection-spec-selftests.c: Fix common/
2377         includes.
2378         * unittests/optional-selftests.c: Fix common/ includes.
2379         * unittests/offset-type-selftests.c: Fix common/ includes.
2380         * unittests/observable-selftests.c: Fix common/ includes.
2381         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2382         * unittests/memrange-selftests.c: Fix common/ includes.
2383         * unittests/memory-map-selftests.c: Fix common/ includes.
2384         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2385         * unittests/function-view-selftests.c: Fix common/ includes.
2386         * unittests/environ-selftests.c: Fix common/ includes.
2387         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2388         * unittests/common-utils-selftests.c: Fix common/ includes.
2389         * unittests/cli-utils-selftests.c: Fix common/ includes.
2390         * unittests/array-view-selftests.c: Fix common/ includes.
2391         * ui-file.c: Fix common/ includes.
2392         * tui/tui-io.c: Fix common/ includes.
2393         * tracepoint.h: Fix common/ includes.
2394         * tracepoint.c: Fix common/ includes.
2395         * tracefile-tfile.c: Fix common/ includes.
2396         * top.h: Fix common/ includes.
2397         * top.c: Fix common/ includes.
2398         * thread.c: Fix common/ includes.
2399         * target/waitstatus.h: Fix common/ includes.
2400         * target/waitstatus.c: Fix common/ includes.
2401         * target.h: Fix common/ includes.
2402         * target.c: Fix common/ includes.
2403         * target-memory.c: Fix common/ includes.
2404         * target-descriptions.c: Fix common/ includes.
2405         * symtab.h: Fix common/ includes.
2406         * symfile.c: Fix common/ includes.
2407         * stap-probe.c: Fix common/ includes.
2408         * spu-linux-nat.c: Fix common/ includes.
2409         * sparc-nat.c: Fix common/ includes.
2410         * source.c: Fix common/ includes.
2411         * solib.c: Fix common/ includes.
2412         * solib-target.c: Fix common/ includes.
2413         * ser-unix.c: Fix common/ includes.
2414         * ser-tcp.c: Fix common/ includes.
2415         * ser-pipe.c: Fix common/ includes.
2416         * ser-base.c: Fix common/ includes.
2417         * selftest-arch.c: Fix common/ includes.
2418         * s12z-tdep.c: Fix common/ includes.
2419         * rust-exp.y: Fix common/ includes.
2420         * rs6000-aix-tdep.c: Fix common/ includes.
2421         * riscv-tdep.c: Fix common/ includes.
2422         * remote.c: Fix common/ includes.
2423         * remote-notif.h: Fix common/ includes.
2424         * remote-fileio.h: Fix common/ includes.
2425         * remote-fileio.c: Fix common/ includes.
2426         * regcache.h: Fix common/ includes.
2427         * regcache.c: Fix common/ includes.
2428         * record-btrace.c: Fix common/ includes.
2429         * python/python.c: Fix common/ includes.
2430         * python/py-type.c: Fix common/ includes.
2431         * python/py-inferior.c: Fix common/ includes.
2432         * progspace.h: Fix common/ includes.
2433         * producer.c: Fix common/ includes.
2434         * procfs.c: Fix common/ includes.
2435         * proc-api.c: Fix common/ includes.
2436         * printcmd.c: Fix common/ includes.
2437         * ppc-linux-nat.c: Fix common/ includes.
2438         * parser-defs.h: Fix common/ includes.
2439         * osdata.c: Fix common/ includes.
2440         * obsd-nat.c: Fix common/ includes.
2441         * nat/x86-linux.c: Fix common/ includes.
2442         * nat/x86-linux-dregs.c: Fix common/ includes.
2443         * nat/x86-dregs.h: Fix common/ includes.
2444         * nat/x86-dregs.c: Fix common/ includes.
2445         * nat/ppc-linux.c: Fix common/ includes.
2446         * nat/mips-linux-watch.h: Fix common/ includes.
2447         * nat/mips-linux-watch.c: Fix common/ includes.
2448         * nat/linux-waitpid.c: Fix common/ includes.
2449         * nat/linux-ptrace.h: Fix common/ includes.
2450         * nat/linux-ptrace.c: Fix common/ includes.
2451         * nat/linux-procfs.c: Fix common/ includes.
2452         * nat/linux-personality.c: Fix common/ includes.
2453         * nat/linux-osdata.c: Fix common/ includes.
2454         * nat/linux-namespaces.c: Fix common/ includes.
2455         * nat/linux-btrace.h: Fix common/ includes.
2456         * nat/linux-btrace.c: Fix common/ includes.
2457         * nat/fork-inferior.c: Fix common/ includes.
2458         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2459         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2460         * nat/aarch64-linux.c: Fix common/ includes.
2461         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2462         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2463         * namespace.h: Fix common/ includes.
2464         * mips-linux-tdep.c: Fix common/ includes.
2465         * minsyms.c: Fix common/ includes.
2466         * mi/mi-parse.h: Fix common/ includes.
2467         * mi/mi-main.c: Fix common/ includes.
2468         * mi/mi-cmd-env.c: Fix common/ includes.
2469         * memrange.h: Fix common/ includes.
2470         * memattr.c: Fix common/ includes.
2471         * maint.h: Fix common/ includes.
2472         * maint.c: Fix common/ includes.
2473         * main.c: Fix common/ includes.
2474         * machoread.c: Fix common/ includes.
2475         * location.c: Fix common/ includes.
2476         * linux-thread-db.c: Fix common/ includes.
2477         * linux-nat.c: Fix common/ includes.
2478         * linux-fork.c: Fix common/ includes.
2479         * inline-frame.c: Fix common/ includes.
2480         * infrun.c: Fix common/ includes.
2481         * inflow.c: Fix common/ includes.
2482         * inferior.h: Fix common/ includes.
2483         * inferior.c: Fix common/ includes.
2484         * infcmd.c: Fix common/ includes.
2485         * inf-ptrace.c: Fix common/ includes.
2486         * inf-child.c: Fix common/ includes.
2487         * ia64-linux-nat.c: Fix common/ includes.
2488         * i387-tdep.c: Fix common/ includes.
2489         * i386-tdep.c: Fix common/ includes.
2490         * i386-linux-tdep.c: Fix common/ includes.
2491         * i386-linux-nat.c: Fix common/ includes.
2492         * i386-go32-tdep.c: Fix common/ includes.
2493         * i386-fbsd-tdep.c: Fix common/ includes.
2494         * i386-fbsd-nat.c: Fix common/ includes.
2495         * guile/scm-type.c: Fix common/ includes.
2496         * guile/guile.c: Fix common/ includes.
2497         * go32-nat.c: Fix common/ includes.
2498         * gnu-nat.c: Fix common/ includes.
2499         * gdbthread.h: Fix common/ includes.
2500         * gdbarch-selftests.c: Fix common/ includes.
2501         * gdb_usleep.c: Fix common/ includes.
2502         * gdb_select.h: Fix common/ includes.
2503         * gdb_bfd.c: Fix common/ includes.
2504         * gcore.c: Fix common/ includes.
2505         * fork-child.c: Fix common/ includes.
2506         * findvar.c: Fix common/ includes.
2507         * fbsd-nat.c: Fix common/ includes.
2508         * event-top.c: Fix common/ includes.
2509         * event-loop.c: Fix common/ includes.
2510         * dwarf2read.c: Fix common/ includes.
2511         * dwarf2loc.c: Fix common/ includes.
2512         * dwarf2-frame.c: Fix common/ includes.
2513         * dwarf-index-cache.c: Fix common/ includes.
2514         * dtrace-probe.c: Fix common/ includes.
2515         * disasm-selftests.c: Fix common/ includes.
2516         * defs.h: Fix common/ includes.
2517         * csky-tdep.c: Fix common/ includes.
2518         * cp-valprint.c: Fix common/ includes.
2519         * cp-support.h: Fix common/ includes.
2520         * cp-support.c: Fix common/ includes.
2521         * corelow.c: Fix common/ includes.
2522         * completer.h: Fix common/ includes.
2523         * completer.c: Fix common/ includes.
2524         * compile/compile.c: Fix common/ includes.
2525         * compile/compile-loc2c.c: Fix common/ includes.
2526         * compile/compile-cplus-types.c: Fix common/ includes.
2527         * compile/compile-cplus-symbols.c: Fix common/ includes.
2528         * command.h: Fix common/ includes.
2529         * cli/cli-dump.c: Fix common/ includes.
2530         * cli/cli-cmds.c: Fix common/ includes.
2531         * charset.c: Fix common/ includes.
2532         * build-id.c: Fix common/ includes.
2533         * btrace.h: Fix common/ includes.
2534         * btrace.c: Fix common/ includes.
2535         * breakpoint.h: Fix common/ includes.
2536         * breakpoint.c: Fix common/ includes.
2537         * ax.h:
2538         (enum agent_op): Fix common/ includes.
2539         * ax-general.c (struct aop_map): Fix common/ includes.
2540         * ax-gdb.c: Fix common/ includes.
2541         * auxv.c: Fix common/ includes.
2542         * auto-load.c: Fix common/ includes.
2543         * arm-tdep.c: Fix common/ includes.
2544         * arch/riscv.c: Fix common/ includes.
2545         * arch/ppc-linux-common.c: Fix common/ includes.
2546         * arch/i386.c: Fix common/ includes.
2547         * arch/arm.c: Fix common/ includes.
2548         * arch/arm-linux.c: Fix common/ includes.
2549         * arch/arm-get-next-pcs.c: Fix common/ includes.
2550         * arch/amd64.c: Fix common/ includes.
2551         * arch/aarch64.c: Fix common/ includes.
2552         * arch/aarch64-insn.c: Fix common/ includes.
2553         * arch-utils.c: Fix common/ includes.
2554         * amd64-windows-tdep.c: Fix common/ includes.
2555         * amd64-tdep.c: Fix common/ includes.
2556         * amd64-sol2-tdep.c: Fix common/ includes.
2557         * amd64-obsd-tdep.c: Fix common/ includes.
2558         * amd64-nbsd-tdep.c: Fix common/ includes.
2559         * amd64-linux-tdep.c: Fix common/ includes.
2560         * amd64-linux-nat.c: Fix common/ includes.
2561         * amd64-fbsd-tdep.c: Fix common/ includes.
2562         * amd64-fbsd-nat.c: Fix common/ includes.
2563         * amd64-dicos-tdep.c: Fix common/ includes.
2564         * amd64-darwin-tdep.c: Fix common/ includes.
2565         * agent.c: Fix common/ includes.
2566         * ada-lang.h: Fix common/ includes.
2567         * ada-lang.c: Fix common/ includes.
2568         * aarch64-tdep.c: Fix common/ includes.
2569
2570 2019-01-25  Tom Tromey  <tom@tromey.com>
2571
2572         * common/create-version.sh: Use common/version.h.
2573
2574 2019-01-24  Pedro Alves  <palves@redhat.com>
2575
2576         * infrun.c (signal_stop, signal_print, signal_program)
2577         (signal_catch, signal_pass): Now arrays instead of pointers.
2578         (update_signals_program_target, do_target_resume)
2579         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2580         * linux-nat.c (linux_nat_target::pass_signals)
2581         (linux_nat_target::create_inferior, linux_nat_target::attach):
2582         Adjust.
2583         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2584         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2585         * procfs.c (procfs_target::pass_signals): Adjust.
2586         * record-full.c (record_full_target::resume): Adjust.
2587         * remote.c (remote_target::pass_signals)
2588         (remote_target::program_signals): Adjust.
2589         * target-debug.h (target_debug_print_signals): Now takes a
2590         gdb::array_view as parameter.  Adjust.
2591         * target.h (target_ops) <pass_signals, program_signals>: Replace
2592         pointer and length parameters with gdb::array_view.
2593         (target_pass_signals, target_program_signals): Likewise.
2594         * target-delegates.c: Regenerate.
2595
2596 2019-01-24  Pedro Alves  <palves@redhat.com>
2597
2598         * common/forward-scope-exit.h
2599         (forward_scope_exit::forward_scope_exit): Pass arguments to
2600         m_bind_function directly, instead of creating a std::bind and
2601         copying that.
2602
2603 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2604
2605         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2606         for static members.
2607         (pass_in_v_vfp_candidate): Likewise.
2608
2609 2019-01-23  Tom Tromey  <tom@tromey.com>
2610             Pedro Alves  <palves@redhat.com>
2611
2612         * regcache.c (class regcache_invalidator): Remove.
2613         (regcache::raw_write): Use make_scope_exit.
2614
2615 2019-01-23  Tom Tromey  <tom@tromey.com>
2616
2617         * ui-out.h (class ui_out_emit_type): Update comment.
2618
2619 2019-01-23  Tom Tromey  <tom@tromey.com>
2620
2621         * infrun.c (fetch_inferior_event): Update comment.
2622
2623 2019-01-23  Tom Tromey  <tom@tromey.com>
2624             Pedro Alves  <palves@redhat.com>
2625
2626         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2627         parameter.
2628         (fetch_inferior_event): Use SCOPE_EXIT.
2629
2630
2631 2019-01-23  Tom Tromey  <tom@tromey.com>
2632             Pedro Alves  <palves@redhat.com>
2633
2634         * infrun.c (disable_thread_events): Delete.
2635         (stop_all_threads): Use SCOPE_EXIT.
2636
2637 2019-01-23  Tom Tromey  <tom@tromey.com>
2638             Pedro Alves  <palves@redhat.com>
2639
2640         * symfile.c: Include forward-scope-exit.h.
2641         (clear_symtab_users_cleanup): Replace forward declaration with
2642         a FORWARD_SCOPE_EXIT.
2643         (syms_from_objfile_1): Use the forward_scope_exit and
2644         gdb::optional instead of cleanup_function.
2645         (reread_symbols): Use the forward_scope_exit instead of
2646         cleanup_function.
2647         (clear_symtab_users_cleanup): Remove function.
2648
2649 2019-01-23  Tom Tromey  <tom@tromey.com>
2650             Pedro Alves  <palves@redhat.com>
2651
2652         * linux-nat.c: Include scope-exit.h.
2653         (cleanup_target_stop): Remove.
2654         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2655         SCOPE_EXIT.
2656
2657 2019-01-23  Tom Tromey  <tom@tromey.com>
2658             Pedro Alves  <palves@redhat.com>
2659
2660         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2661         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2662
2663 2019-01-23  Tom Tromey  <tom@tromey.com>
2664             Andrew Burgess  <andrew.burgess@embecosm.com>
2665             Pedro Alves  <palves@redhat.com>
2666
2667         * infrun.c (fetch_inferior_event): Use scope_exit.
2668         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2669         * top.c (execute_command): Use scope_exit.
2670         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2671         * utils.c (do_bpstat_clear_actions_cleanup)
2672         (make_bpstat_clear_actions_cleanup): Remove.
2673
2674 2019-01-23  Tom Tromey  <tom@tromey.com>
2675             Pedro Alves  <palves@redhat.com>
2676
2677         * infrun.c: Include "common/scope-exit.h"
2678         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2679         (wait_for_inferior): Use SCOPE_EXIT.
2680         (fetch_inferior_event): Use scope_exit.
2681
2682 2019-01-23  Tom Tromey  <tom@tromey.com>
2683             Pedro Alves  <palves@redhat.com>
2684
2685         * breakpoint.c (create_breakpoint): Remove cleanup.
2686
2687 2019-01-23  Tom Tromey  <tom@tromey.com>
2688             Andrew Burgess  <andrew.burgess@embecosm.com>
2689             Pedro Alves  <palves@redhat.com>
2690
2691 2019-01-23  Pedro Alves  <palves@redhat.com>
2692
2693         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2694
2695 2019-01-23  Pedro Alves  <palves@redhat.com>
2696             Andrew Burgess  <andrew.burgess@embecosm.com>
2697
2698         * gdbthread.h: Include "common/forward-scope-exit.h".
2699         (scoped_finish_thread_state): Redefine custom class in terms of
2700         forward_scope_exit.
2701
2702 2019-01-23  Pedro Alves  <palves@redhat.com>
2703             Andrew Burgess  <andrew.burgess@embecosm.com>
2704
2705         * common/forward-scope-exit.h: New file.
2706
2707 2019-01-23  Pedro Alves  <palves@redhat.com>
2708             Andrew Burgess  <andrew.burgess@embecosm.com>
2709             Tom Tromey  <tom@tromey.com>
2710
2711         * common/scope-exit.h: New file.
2712
2713 2019-01-23  Pedro Alves  <palves@redhat.com>
2714
2715         * common/preprocessor.h (ESC): Rename to ...
2716         (ESC_PARENS): ... this.
2717         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2718         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2719
2720 2019-01-23  Tom Tromey  <tom@tromey.com>
2721
2722         * language.h (class scoped_switch_to_sym_language_if_auto):
2723         Initialize m_lang in both cases.
2724
2725 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2726
2727         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2728         with XCNEW.
2729
2730 2019-01-22  Tom Tromey  <tom@tromey.com>
2731
2732         * corelow.c: Do not include sys/file.h.
2733
2734 2019-01-22  Tom Tromey  <tom@tromey.com>
2735
2736         * tui/tui-wingeneral.h: Include gdb_curses.h.
2737
2738 2019-01-22  Tom Tromey  <tom@tromey.com>
2739
2740         * source-cache.h (class source_cache) <get_source_lines,
2741         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2742
2743 2019-01-22  Tom Tromey  <tom@tromey.com>
2744
2745         * remote-fileio.h (struct remote_target): Declare.
2746
2747 2019-01-22  Tom Tromey  <tom@tromey.com>
2748
2749         * python/py-arch.c: Do not include py-ref.h.
2750         * python/py-bpevent.c: Do not include py-ref.h.
2751         * python/py-cmd.c: Do not include py-ref.h.
2752         * python/py-continueevent.c: Do not include py-ref.h.
2753         * python/py-event.h: Do not include py-ref.h.
2754         * python/py-evtregistry.c: Do not include py-ref.h.
2755         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2756         * python/py-frame.c: Do not include py-ref.h.
2757         * python/py-framefilter.c: Do not include py-ref.h.
2758         * python/py-function.c: Do not include py-ref.h.
2759         * python/py-infevents.c: Do not include py-ref.h.
2760         * python/py-linetable.c: Do not include py-ref.h.
2761         * python/py-objfile.c: Do not include py-ref.h.
2762         * python/py-param.c: Do not include py-ref.h.
2763         * python/py-prettyprint.c: Do not include py-ref.h.
2764         * python/py-progspace.c: Do not include py-ref.h.
2765         * python/py-symbol.c: Do not include py-ref.h.
2766         * python/py-symtab.c: Do not include py-ref.h.
2767         * python/py-type.c: Do not include py-ref.h.
2768         * python/py-unwind.c: Do not include py-ref.h.
2769         * python/py-utils.c: Do not include py-ref.h.
2770         * python/py-value.c: Do not include py-ref.h.
2771         * python/py-varobj.c: Do not include py-ref.h.
2772         * python/py-xmethods.c: Do not include py-ref.h.
2773         * python/python.c: Do not include py-ref.h.
2774         * varobj.c: Do not include py-ref.h.
2775
2776 2019-01-22  Tom Tromey  <tom@tromey.com>
2777
2778         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2779         keyword for bcache.
2780
2781 2019-01-22  Tom Tromey  <tom@tromey.com>
2782
2783         * compile/compile-cplus-types.c: Remove a comment by #include.
2784
2785 2019-01-22  Tom Tromey  <tom@tromey.com>
2786
2787         * compile/gcc-c-plugin.h: Include compile-internal.h.
2788
2789 2019-01-22  Tom Tromey  <tom@tromey.com>
2790
2791         * stabsread.c (EXTERN): Do not define.
2792         (symnum, next_symbol_text_func, processing_gcc_compilation)
2793         (within_function, global_sym_chain, global_stabs)
2794         (previous_stab_code, this_object_header_files)
2795         (n_this_object_header_files)
2796         (n_allocated_this_object_header_files): Define.
2797         * stabsread.h (EXTERN): Never define.  Use "extern".
2798
2799 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2800
2801         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2802         history_value.
2803
2804 2019-01-21  Tom Tromey  <tom@tromey.com>
2805
2806         * ui-out.c: Fix includes.
2807         * tui/tui-source.c: Fix includes.
2808         * target.c: Fix includes.
2809         * remote.c: Fix includes.
2810         * regcache.c: Fix includes.
2811         * python/py-block.c: Fix includes.
2812         * printcmd.c: Fix includes.
2813         * or1k-tdep.c: Fix includes.
2814         * mi/mi-main.c: Fix includes.
2815         * m32r-tdep.c: Fix includes.
2816         * csky-tdep.c: Fix includes.
2817         * compile/compile-cplus-types.c: Fix includes.
2818         * cli/cli-interp.c: Fix includes.
2819
2820 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2821
2822         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2823         for padding.
2824
2825 2019-01-16  Tom Tromey  <tom@tromey.com>
2826
2827         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2828         earlier.
2829         (struct objfile) <msymbols_range>: Move from top level.
2830         <msymbols>: New method.
2831         (class objfile_msymbols): Remove.
2832         * symtab.c (default_collect_symbol_completion_matches_break_on):
2833         Update.
2834         * symmisc.c (dump_msymbols): Update.
2835         * stabsread.c (scan_file_globals): Update.
2836         * objc-lang.c (info_selectors_command, info_classes_command)
2837         (find_methods): Update.
2838         * minsyms.c (find_solib_trampoline_target): Update.
2839         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2840         * coffread.c (coff_symfile_read): Update.
2841         * ada-lang.c (ada_lookup_simple_minsym)
2842         (ada_collect_symbol_completion_matches): Update.
2843
2844 2019-01-16  Tom Tromey  <tom@tromey.com>
2845
2846         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2847         type.  Remove no-argument constructor.
2848         <iterator::operator++>: Simplify.
2849         <begin>: Update.
2850         <end>: Use minimal_symbol_count.
2851
2852 2019-01-16  Tom Tromey  <tom@tromey.com>
2853
2854         * objfiles.h (struct objfile) <psymtabs>: New method.
2855         (class objfile_psymtabs): Remove.
2856         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2857         typedef.
2858         <range>: New method.
2859         (require_partial_symbols): Change return type.
2860         * psymtab.c (require_partial_symbols)
2861         (psym_expand_symtabs_matching): Update.
2862         * mdebugread.c (parse_partial_symbols): Update.
2863         * dbxread.c (dbx_end_psymtab): Update.
2864
2865 2019-01-15  Tom Tromey  <tom@tromey.com>
2866
2867         * symtab.c (lookup_objfile_from_block)
2868         (lookup_symbol_in_objfile_symtabs)
2869         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2870         (find_line_symtab, info_sources_command)
2871         (default_collect_symbol_completion_matches_break_on)
2872         (make_source_files_completion_list): Update.
2873         * symmisc.c (print_objfile_statistics, dump_objfile)
2874         (maintenance_print_symbols, maintenance_info_symtabs)
2875         (maintenance_check_symtabs, maintenance_info_line_tables):
2876         Update.
2877         * source.c (select_source_symtab)
2878         (forget_cached_source_info_for_objfile): Update.
2879         * objfiles.h (class objfile_compunits): Remove.
2880         (struct objfile) <compunits_range>: New typedef.
2881         (compunits): New method.
2882         * objfiles.c (objfile_relocate1): Update.
2883         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2884         * maint.c (count_symtabs_and_blocks): Update.
2885         * linespec.c (iterate_over_all_matching_symtabs): Update.
2886         * cp-support.c (add_symbol_overload_list_qualified): Update.
2887         * coffread.c (coff_symtab_read): Update.
2888         * ada-lang.c (add_nonlocal_symbols)
2889         (ada_collect_symbol_completion_matches)
2890         (ada_add_global_exceptions): Update.
2891
2892 2019-01-15  Tom Tromey  <tom@tromey.com>
2893
2894         * progspace.h (program_space) <objfiles_safe_range>: New
2895         typedef.
2896         <objfiles_safe>: New method.
2897         * objfiles.h (class all_objfiles_safe): Remove.
2898         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2899         * jit.c (jit_inferior_exit_hook): Update.
2900
2901 2019-01-17  Tom Tromey  <tom@tromey.com>
2902
2903         * progspace.h (program_space) <objfiles_range>: New typedef.
2904         <objfiles>: New method.
2905         <objfiles_head>: Rename from objfiles.
2906         (object_files): Update.
2907         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2908         * guile/scm-pretty-print.c
2909         (ppscm_find_pretty_printer_from_objfiles): Update.
2910         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2911         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2912         Update.
2913         * python/py-progspace.c (pspy_get_objfiles): Update.
2914         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2915         Update.
2916         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2917         (objfpy_lookup_objfile_by_build_id): Update.
2918         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2919         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2920         Update.
2921         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2922         (expand_symtab_containing_pc, lookup_objfile_from_block)
2923         (lookup_static_symbol, basic_lookup_transparent_type)
2924         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2925         (find_line_symtab, info_sources_command)
2926         (default_collect_symbol_completion_matches_break_on)
2927         (make_source_files_completion_list, find_main_name): Update.
2928         * symmisc.c (print_symbol_bcache_statistics)
2929         (print_objfile_statistics, maintenance_print_symbols)
2930         (maintenance_print_msymbols, maintenance_print_objfiles)
2931         (maintenance_info_symtabs, maintenance_check_symtabs)
2932         (maintenance_expand_symtabs, maintenance_info_line_tables):
2933         Update.
2934         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2935         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2936         (map_overlay_command, unmap_overlay_command)
2937         (simple_overlay_update, expand_symtabs_matching)
2938         (map_symbol_filenames): Update.
2939         * symfile-debug.c (set_debug_symfile): Update.
2940         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2941         Update.
2942         * source.c (select_source_symtab, forget_cached_source_info):
2943         Update.
2944         * solib.c (solib_read_symbols): Update.
2945         * solib-spu.c (append_ocl_sos): Update.
2946         * psymtab.c (maintenance_print_psymbols)
2947         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2948         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2949         * printcmd.c (info_symbol_command): Update.
2950         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2951         Update.
2952         * objfiles.h (class all_objfiles): Remove.
2953         * objfiles.c (have_partial_symbols, have_full_symbols)
2954         (have_minimal_symbols, qsort_cmp, update_section_map)
2955         (shared_objfile_contains_address_p)
2956         (default_iterate_over_objfiles_in_search_order): Update.
2957         * objc-lang.c (info_selectors_command, info_classes_command)
2958         (find_methods): Update.
2959         * minsyms.c (find_solib_trampoline_target): Update.
2960         * maint.c (maintenance_info_sections)
2961         (maintenance_translate_address, count_symtabs_and_blocks):
2962         Update.
2963         * main.c (captured_main_1): Update.
2964         * linux-thread-db.c (try_thread_db_load_from_pdir)
2965         (has_libpthread): Update.
2966         * linespec.c (iterate_over_all_matching_symtabs)
2967         (search_minsyms_for_name): Update.
2968         * jit.c (jit_find_objf_with_entry_addr): Update.
2969         * hppa-tdep.c (find_unwind_entry)
2970         (hppa_lookup_stub_minimal_symbol): Update.
2971         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2972         Update.
2973         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2974         (elf_gnu_ifunc_resolve_by_got): Update.
2975         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2976         * dwarf-index-write.c (save_gdb_index_command): Update.
2977         * cp-support.c (add_symbol_overload_list_qualified): Update.
2978         * breakpoint.c (create_overlay_event_breakpoint)
2979         (create_longjmp_master_breakpoint)
2980         (create_std_terminate_master_breakpoint)
2981         (create_exception_master_breakpoint): Update.
2982         * blockframe.c (find_pc_partial_function): Update.
2983         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2984         (ada_collect_symbol_completion_matches)
2985         (ada_add_global_exceptions): Update.
2986
2987 2019-01-17  Tom Tromey  <tom@tromey.com>
2988
2989         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2990         declare VEC.
2991         (solib_target_parse_libraries): Change return type.
2992         (library_list_start_segment, library_list_start_section)
2993         (library_list_end_library, library_list_start_library); Update.
2994         (solib_target_free_library_list): Remove.
2995         (solib_target_parse_libraries): Remove cleanup.  Change return
2996         type.
2997         (solib_target_current_sos): Update.
2998
2999 2019-01-17  Tom Tromey  <tromey@bapiya>
3000
3001         * valprint.c: Replace "the the" with "the".
3002         * symtab.c: Replace "the the" with "the".
3003         * solib.c: Replace "the the" with "the".
3004         * solib-dsbt.c: Replace "the the" with "the".
3005         * linespec.c: Replace "the the" with "the".
3006         * dwarf2loc.h: Replace "the the" with "the".
3007         * amd64-windows-tdep.c: Replace "the the" with "the".
3008         * aarch64-tdep.c: Replace "the the" with "the".
3009
3010 2019-01-16  Keith Seitz  <keiths@redhat.com>
3011
3012         PR gdb/23773
3013         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
3014         <builder>: Rename to ..
3015         <m_builder>: ... this and make private.
3016         (dwarf2_cu::get_builder): New method.  Change all users of
3017         `builder' to use this method.
3018         (dwarf2_start_symtab): Move to ...
3019         (dwarf2_cu::start_symtab): ... here.  Update all callers
3020         (setup_type_unit_groups): Move to ...
3021         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
3022         callers.
3023         (dwarf2_cu::reset_builder): New method.
3024         (process_full_compunit, process_full_type_unit): Use
3025         dwarf2_cu::reset_builder.
3026         (follow_die_offset): Record the ancestor CU if it is different
3027         from the followed DIE's CU.
3028         (follow_die_sig_1): Likewise.
3029
3030 2019-01-15  Tom Tromey  <tom@tromey.com>
3031
3032         * remote.c (class remote_state) <buf>: Now a char_vector.
3033         <buf_size>: Remove.
3034         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
3035         parameter.
3036         (remote_target::getpkt_or_notif_sane_1)
3037         (remote_target::getpkt_sane)
3038         (remote_target::getpkt_or_notif_sane): Likewise.
3039         (class remote_target) <putpkt>: New overload.
3040         (remote_target::read_frame): Change type of "buf_p".  Remove
3041         sizeof_p parameter.
3042         (packet_ok): New overload.
3043         (packet_check_result): New overload.
3044         Update all uses.
3045
3046 2019-01-14  Tom Tromey  <tom@tromey.com>
3047
3048         * remote-notif.c (handle_notification, remote_notif_ack)
3049         (remote_notif_parse): Make "buf" const.
3050         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
3051         const.
3052         (remote_notif_parse, remote_notif_ack, handle_notification):
3053         Likewise.
3054         * remote.c (remote_notif_stop_parse): Make "buf" const.
3055         (remote_target::remote_parse_stop_reply): Make "buf" const.
3056         (remote_notif_stop_ack): Make "buf" const.
3057
3058 2019-01-14  Tom Tromey  <tom@tromey.com>
3059
3060         * remote.c (remote_console_output): Make parameter const.
3061
3062 2019-01-14  Tom Tromey  <tom@tromey.com>
3063
3064         * target-debug.h (target_debug_print_signals): Constify.
3065         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
3066         * procfs.c (procfs_target::pass_signals): Update.
3067         * linux-nat.c (linux_nat_target::pass_signals): Update.
3068         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
3069         * target-delegates.c: Rebuild.
3070         * remote.c (remote_target::program_signals): Update.
3071         (remote_target::pass_signals): Update.
3072         * target.c (target_pass_signals): Constify argument.
3073         (target_program_signals): Likewise.
3074         * target.h (struct target_ops) <pass_signals, program_signals>:
3075         Constify argument.
3076         (target_pass_signals, target_program_signals): Constify argument.
3077
3078 2019-01-14  Tom Tromey  <tom@tromey.com>
3079
3080         PR tui/28819:
3081         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
3082
3083 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3084
3085         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
3086         field.
3087         * rs6000-tdep.c: Include reggroups.h.
3088         (IS_V_ALIAS_PSEUDOREG): Define.
3089         (rs6000_register_name): Return names for the "vX" aliases.
3090         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
3091         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
3092         aliases.  Call default_register_reggroup_p for all other
3093         pseudo-registers.
3094         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
3095         New functions.
3096         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
3097         Handle "vX" aliases.
3098         (v_alias_pseudo_register_collect): New function.
3099         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
3100         (rs6000_gdbarch_init): Initialize "vX" aliases as
3101         pseudo-registers.  Restore registration of
3102         rs6000_pseudo_register_reggroup_p with
3103         set_tdesc_pseudo_register_reggroup_p.
3104
3105 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
3106
3107         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
3108         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
3109         set_gdbarch_num_pseudo_regs.
3110
3111 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3112
3113         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
3114         Remove arg prefixname, add do_set and do_show.
3115         Add member functions set_list and show_list.
3116         * cli/cli-style.c (class cli_style_option): Update accordingly.
3117         (style_set_list): Move to file scope.
3118         (style_show_list): Likewise.
3119         (set_style): Call help_list.
3120         (show_style): Call cmd_show_list.
3121         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
3122         Update to use the new macro.
3123
3124 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
3125
3126         * ada-lang.c (_initialize_ada_language): Expand the help text
3127         for the "catch exception" command.
3128
3129 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3130
3131         * symtab.c (matching_obj_sections): Initialize obj,
3132         declare it closer to its usage.
3133
3134 2019-01-10  Tom Tromey  <tom@tromey.com>
3135
3136         * thread-iter.h (inf_threads_iterator): Use next_iterator.
3137         (basic_inf_threads_range): Remove.
3138         (inf_threads_range, inf_non_exited_threads_range)
3139         (safe_inf_threads_range): Use next_adapter.
3140
3141 2019-01-10  Keith Seitz  <keiths@redhat.com>
3142
3143         PR gdb/23712
3144         PR symtab/23010
3145         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
3146         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
3147
3148 2019-01-10  Keith Seitz  <keiths@redhat.com>
3149
3150         PR gdb/23712
3151         PR symtab/23010
3152         * dictionary.c (pending_to_vector): Remove.
3153         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3154         Remove _1 suffix, replacing functions of the same name.  Update
3155         all callers.
3156         (dict_create_hashed, dict_create_hashed_expandable)
3157         (dict_create_linear, dict_create_linear_expandable, dict_free)
3158         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
3159         Make functions static.
3160
3161 2019-01-10  Keith Seitz  <keiths@redhat.com>
3162
3163         PR gdb/23712
3164         PR symtab/23010
3165         * dictionary.h (struct dictionary): Replace declaration with
3166         multidictionary.
3167         (dict_create_hashed, dict_create_hashed_expandable)
3168         (dict_create_linear, dict_create_linear_expandable)
3169         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
3170         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
3171         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
3172         taking multidictionary argument.
3173         [ALL_DICT_SYMBOLS]: Update for multidictionary.
3174         * block.h (struct block) <dict>: Change to multidictionary
3175         and rename `multidict'.
3176         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
3177         symmisc.c: Update all dictionary references to multidictionary.
3178
3179 2019-01-10  Keith Seitz  <keiths@redhat.com>
3180
3181         PR gdb/23712
3182         PR symtab/23010
3183         * dictionary.c: Include unordered_map.
3184         (pending_to_vector): New function.
3185         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
3186         Rewrite the non-"_1" functions to take vector instead
3187         of linked list.
3188         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
3189         "new" _1 versions of the same name.
3190         (multidictionary): Define.
3191         (std::hash<enum language): New definition.
3192         (collate_pending_symbols_by_language, mdict_create_hashed)
3193         (mdict_create_hashed_expandable, mdict_create_linear)
3194         (mdict_create_linear_expandable, mdict_free)
3195         (find_language_dictionary, create_new_language_dictionary)
3196         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
3197         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
3198         (mdict_size, mdict_empty): New functions.
3199         * dictionary.h (mdict_iterator): Define.
3200
3201 2019-01-10  Pedro Alves  <palves@redhat.com>
3202
3203         * breakpoint.c (read_uploaded_action)
3204         (create_tracepoint_from_upload): Adjust to use
3205         gdb::unique_xmalloc_ptr.
3206         * ctf.c (ctf_write_uploaded_tp):
3207         (SET_ARRAY_FIELD): Use emplace_back.
3208         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
3209         * tracefile-tfile.c (tfile_write_uploaded_tp):
3210         * tracepoint.c (parse_tracepoint_definition): Adjust to use
3211         gdb::unique_xmalloc_ptr.
3212         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
3213         at_string, cond_string, cmd_strings>: Replace char pointers
3214         with gdb::unique_xmalloc_ptr.
3215
3216 2019-01-10  Pedro Alves  <palves@redhat.com>
3217
3218         * solib-target.c (library_list_start_library): Don't xstrdup name.
3219
3220 2019-01-10  Pedro Alves  <palves@redhat.com>
3221
3222         * mdebugread.c (parse_partial_symbols): Use
3223         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3224
3225 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3226
3227         * linux-fork.c (scoped_switch_fork_info)
3228         <~scoped_switch_fork_info>: Fix incorrect variable name.
3229
3230 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3231
3232         * linux-fork.c (scoped_switch_fork_info)
3233         <scoped_switch_fork_info>: Make explicit.
3234         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3235
3236 2019-01-10  Tom Tromey  <tom@tromey.com>
3237
3238         * objfiles.h (objfile::reset_psymtabs): Update.
3239         * objfiles.c (objfile::objfile): Update.
3240         * psymtab.h (psymtab_storage::obstack): Update.
3241         (psymtab_storage::m_obstack): Use gdb::optional.
3242         (class psymtab_storage): Update comment.  Remove objfile
3243         parameter.
3244         * psymtab.c (psymtab_storage::psymtab_storage): Update.
3245
3246 2019-01-10  Tom Tromey  <tom@tromey.com>
3247
3248         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3249         <free_psymtabs>: Now private.
3250         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3251         (allocate_psymtab): Use new method.
3252
3253 2019-01-10  Tom Tromey  <tom@tromey.com>
3254
3255         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3256         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3257         * mdebugread.c (parse_partial_symbols): Use
3258         allocate_dependencies.
3259         * dwarf2read.c (dwarf2_create_include_psymtab): Use
3260         allocate_dependencies.
3261         (process_psymtab_comp_unit_reader)
3262         (build_type_psymtab_dependencies): Likewise.
3263         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3264
3265 2019-01-10  Tom Tromey  <tom@tromey.com>
3266
3267         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3268         PSYMBOL_SET_LANGUAGE.
3269         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3270
3271 2019-01-10  Tom Tromey  <tom@tromey.com>
3272
3273         * psymtab.h (psymtab_storage::obstack): New method.
3274         <m_obstack>: Rename from obstack; now private.
3275         * psymtab.c (psymtab_storage): Update.
3276         * dwarf2read.c (create_addrmap_from_index)
3277         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3278         Update.
3279
3280 2019-01-10  Tom Tromey  <tom@tromey.com>
3281
3282         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3283         * objfiles.h (objfile::reset_psymtabs): New method.
3284
3285 2019-01-10  Tom Tromey  <tom@tromey.com>
3286
3287         * symmisc.c (print_symbol_bcache_statistics): Update.
3288         (print_objfile_statistics): Update.
3289         * symfile.c (reread_symbols): Update.
3290         * psymtab.h (class psymtab_storage): New.
3291         * psymtab.c (psymtab_storage): New constructor.
3292         (~psymtab_storage): New destructor.
3293         (require_partial_symbols): Update.
3294         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3295         (find_pc_sect_psymtab, find_pc_sect_psymbol)
3296         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3297         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3298         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3299         (start_psymtab_common, end_psymtab_common)
3300         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3301         (allocate_psymtab): Update.
3302         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3303         Update.
3304         (dump_psymtab_addrmap, maintenance_print_psymbols)
3305         (maintenance_check_psymtabs): Update.
3306         (class objfile_psymtabs): Move to objfiles.h.
3307         * psympriv.h (discard_psymtab): Now inline.
3308         (psymtab_discarder::psymtab_discarder): Update.
3309         (psymtab_discarder::~psymtab_discarder): Update.
3310         (ALL_OBJFILE_PSYMTABS): Rewrite.
3311         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3312         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3313         Remove fields.
3314         <partial_symtabs>: New field.
3315         (class objfile_psymtabs): Move from psymtab.h.  Update.
3316         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3317         psymbol_cache.
3318         (objfile::~objfile): Don't destroy psymbol_cache.
3319         * mdebugread.c (parse_partial_symbols): Update.
3320         * dwarf2read.c (create_addrmap_from_index)
3321         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3322         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3323         (add_partial_subprogram, dwarf2_ranges_read): Update.
3324         * dwarf-index-write.c (write_address_map)
3325         (write_one_signatured_type, recursively_write_psymbols)
3326         (class debug_names, class debug_names, write_psymtabs_to_index):
3327         Update.
3328
3329 2019-01-10  Tom Tromey  <tom@tromey.com>
3330
3331         * symtab.h (SYMBOL_SET_NAMES): Update.
3332         (symbol_set_names): Update.
3333         (MSYMBOL_SET_NAMES): Update.
3334         * symtab.c (symbol_set_names): Change argument to be an
3335         objfile_per_bfd_storage.
3336         * psymtab.c (add_psymbol_to_bcache): Update.
3337         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3338
3339 2019-01-10  Tom Tromey  <tom@tromey.com>
3340
3341         * symtab.c (create_demangled_names_hash): Change argument to be an
3342         objfile_per_bfd_storage.
3343         (symbol_set_names): Update.
3344
3345 2019-01-10  Tom Tromey  <tom@tromey.com>
3346
3347         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3348         init_psymbol_list.
3349         * psymtab.c (init_psymbol_list): Do nothing if already called.
3350         * psympriv.h (init_psymbol_list): Add comment.
3351         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3352         init_psymbol_list.
3353         * dbxread.c (dbx_symfile_read): Unconditionally call
3354         init_psymbol_list.
3355
3356 2019-01-10  Tom Tromey  <tom@tromey.com>
3357
3358         * xcoffread.c (scan_xcoff_symtab): Update.
3359         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3360         "where".
3361         * mdebugread.c (parse_partial_symbols)
3362         (handle_psymbol_enumerators): Update.
3363         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3364         * dbxread.c (read_dbx_symtab): Update.
3365         * psympriv.h (psymbol_placement): New enum.
3366         (add_psymbol_to_list): Update.
3367
3368 2019-01-10  Tom Tromey  <tom@tromey.com>
3369
3370         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3371         static_psymbols parameters.
3372         (scan_xcoff_symtab): Update.
3373         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3374         static_psymbols parameters.
3375         * psympriv.h (start_psymtab_common): Update.
3376         * mdebugread.c (parse_partial_symbols): Update.
3377         * dwarf2read.c (create_partial_symtab): Update.
3378         * dbxread.c (read_dbx_symtab): Update.
3379         (start_psymtab): Remove global_psymbols and static_psymbols
3380         parameters.
3381
3382 2019-01-10  Tom Tromey  <tom@tromey.com>
3383
3384         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3385         * psymtab.c (allocate_psymtab): Add comment.
3386         * psympriv.h (allocate_psymtab): Add comment.
3387         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3388         initializations.
3389         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3390
3391 2019-01-10  Tom Tromey  <tom@tromey.com>
3392
3393         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3394         Don't declare.
3395         * mipsread.c: Include mdebugread.h.
3396         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3397         Declare.
3398         * elfread.c: Include mdebugread.h.
3399
3400 2019-01-09  Tom Tromey  <tom@tromey.com>
3401
3402         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3403         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3404         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3405         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3406         (psym_lookup_symbol, psym_find_last_source_symtab)
3407         (psym_forget_cached_source_info, psym_print_stats)
3408         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3409         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3410         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3411         (psym_find_compunit_symtab_by_address)
3412         (maintenance_print_psymbols, maintenance_info_psymtabs)
3413         (maintenance_check_psymtabs): Use ranged for.
3414         * psymtab.h (class objfile_psymtabs): New.
3415         (require_partial_symbols): Return objfile_psymtabs.
3416         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3417
3418 2019-01-09  Tom Tromey  <tom@tromey.com>
3419
3420         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3421         (find_pc_mapped_section, list_overlays_command)
3422         (map_overlay_command, unmap_overlay_command)
3423         (simple_overlay_update): Use all_objfiles.
3424         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3425         * printcmd.c (info_symbol_command): Use all_objfiles.
3426         * objfiles.h (ALL_OBJSECTIONS): Remove.
3427         * maint.c (maintenance_translate_address): Use all_objfiles.
3428         * gcore.c (gcore_create_callback): Use all_objfiles.
3429         (objfile_find_memory_regions): Likewise.
3430
3431 2019-01-09  Tom Tromey  <tom@tromey.com>
3432
3433         * symtab.c (find_line_symtab, info_sources_command)
3434         (make_source_files_completion_list): Use objfile_compunits.
3435         * source.c (select_source_symtab): Use objfile_compunits.
3436         * objfiles.h (struct objfile): Update comment.
3437         (ALL_OBJFILES): Remove.
3438         (ALL_FILETABS): Remove.
3439         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3440         objfile_compunits.
3441
3442 2019-01-09  Tom Tromey  <tom@tromey.com>
3443
3444         * symmisc.c (print_objfile_statistics, dump_objfile)
3445         (maintenance_print_symbols): Use compunit_filetabs.
3446         * source.c (forget_cached_source_info_for_objfile): Use
3447         compunit_filetabs.
3448         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3449         (ALL_FILETABS): Use compunit_filetabs.
3450         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3451         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3452
3453 2019-01-09  Tom Tromey  <tom@tromey.com>
3454
3455         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3456         (compunit_filetabs): New.
3457         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3458         compunit_filetabs.
3459         (info_sources_command, make_source_files_completion_list): Remove
3460         declaration.
3461         * symmisc.c (print_objfile_statistics, dump_objfile)
3462         (maintenance_print_symbols): Remove declaration.
3463         (maintenance_info_symtabs): Use compunit_filetabs.
3464         (maintenance_info_line_tables): Likewise.
3465         * source.c (select_source_symtab): Change local variable name.
3466         (forget_cached_source_info_for_objfile): Remove declaration.
3467         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3468         * objfiles.c (objfile_relocate1): Remove declaration.
3469         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3470         declaration.
3471         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3472         * coffread.c (coff_symtab_read): Remove declaration.
3473         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3474         compunit_filetabs.
3475
3476 2019-01-09  Tom Tromey  <tom@tromey.com>
3477
3478         * symtab.c (lookup_objfile_from_block)
3479         (find_pc_sect_compunit_symtab, search_symbols)
3480         (default_collect_symbol_completion_matches_break_on): Use
3481         objfile_compunits.
3482         * objfiles.h (ALL_COMPUNITS): Remove.
3483         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3484         * cp-support.c (add_symbol_overload_list_qualified): Use
3485         objfile_compunits.
3486         * ada-lang.c (ada_collect_symbol_completion_matches)
3487         (ada_add_global_exceptions): Use objfile_compunits.
3488
3489 2019-01-09  Tom Tromey  <tom@tromey.com>
3490
3491         * source.c (select_source_symtab)
3492         (forget_cached_source_info_for_objfile): Remove declaration.
3493         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3494         declaration.
3495         * maint.c (count_symtabs_and_blocks): Remove declaration.
3496         * cp-support.c (add_symbol_overload_list_qualified): Remove
3497         declaration.
3498         * coffread.c (coff_symtab_read): Remove declaration.
3499         * symtab.c (lookup_symbol_in_objfile_symtabs)
3500         (basic_lookup_transparent_type_1): Use objfile_compunits.
3501         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3502         (info_sources_command, search_symbols)
3503         (default_collect_symbol_completion_matches_break_on)
3504         (make_source_files_completion_list): Remove declaration.
3505         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3506         (ada_collect_symbol_completion_matches)
3507         (ada_add_global_exceptions): Remove declaration.
3508         * linespec.c (iterate_over_all_matching_symtabs): Use
3509         objfile_compunits.
3510         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3511         (class objfile_compunits): New.
3512         (ALL_COMPUNITS): Use objfile_compunits.
3513         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3514         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3515         objfile_compunits.
3516         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3517
3518 2019-01-09  Tom Tromey  <tom@tromey.com>
3519
3520         * symtab.c (search_symbols)
3521         (default_collect_symbol_completion_matches_break_on): Use
3522         objfile_msymbols.
3523         * ada-lang.c (ada_lookup_simple_minsym)
3524         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3525         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3526         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3527         objfile_msymbols.
3528         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3529         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3530         * objc-lang.c (find_methods): Use objfile_msymbols.
3531         (info_selectors_command, info_classes_command): Likewise.
3532         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3533         * objfiles.h (class objfile_msymbols): New.
3534         (ALL_OBJFILE_MSYMBOLS): Remove.
3535         (ALL_MSYMBOLS): Remove.
3536
3537 2019-01-09  Tom Tromey  <tom@tromey.com>
3538
3539         * common/next-iterator.h (next_adapter): Add Iterator template
3540         parameter.
3541         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3542         (class all_objfiles_safe): New.
3543         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3544         * objfiles.c (put_objfile_before): Update comment.
3545         (add_separate_debug_objfile): Likewise.
3546         (free_all_objfiles): Use all_objfiles_safe.
3547         (objfile_purge_solibs): Likewise.
3548
3549 2019-01-09  Tom Tromey  <tom@tromey.com>
3550
3551         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3552         (expand_symtab_containing_pc, lookup_static_symbol)
3553         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3554         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3555         all_objfiles.
3556         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3557         * breakpoint.c (create_overlay_event_breakpoint)
3558         (create_longjmp_master_breakpoint)
3559         (create_std_terminate_master_breakpoint)
3560         (create_exception_master_breakpoint): Use all_objfiles.
3561         * linux-thread-db.c (try_thread_db_load_from_pdir)
3562         (has_libpthread): Use all_objfiles.
3563         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3564         * linespec.c (iterate_over_all_matching_symtabs)
3565         (search_minsyms_for_name): Use all_objfiles.
3566         * maint.c (maintenance_info_sections): Use all_objfiles.
3567         * main.c (captured_main_1): Use all_objfiles.
3568         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3569         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3570         * guile/scm-pretty-print.c
3571         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3572         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3573         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3574         (maintenance_print_msymbols): Use all_objfiles.
3575         * source.c (select_source_symtab): Use all_objfiles.
3576         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3577         * symfile.c (remove_symbol_file_command)
3578         (expand_symtabs_matching, map_symbol_filenames): Use
3579         all_objfiles.
3580         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3581         all_objfiles.
3582         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3583         * objc-lang.c (find_methods): Use all_objfiles.
3584         * objfiles.c (have_partial_symbols, have_full_symbols)
3585         (have_minimal_symbols, qsort_cmp)
3586         (default_iterate_over_objfiles_in_search_order): Use
3587         all_objfiles.
3588         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3589         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3590         (maintenance_check_psymtabs): Use all_objfiles.
3591         (ALL_PSYMTABS): Remove.
3592         * compile/compile-object-run.c (do_module_cleanup): Use
3593         all_objfiles.
3594         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3595         * cp-support.c (add_symbol_overload_list_qualified): Use
3596         all_objfiles.
3597         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3598         Use all_objfiles.
3599         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3600         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3601         all_objfiles.
3602         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3603         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3604         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3605         Uses all_objfiles.
3606         * solib.c (solib_read_symbols): Use all_objfiles
3607
3608 2019-01-09  Tom Tromey  <tom@tromey.com>
3609
3610         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3611         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3612         all_objfiles.
3613         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3614         * symmisc.c (print_symbol_bcache_statistics)
3615         (print_objfile_statistics, maintenance_print_objfiles)
3616         (maintenance_info_symtabs, maintenance_check_symtabs)
3617         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3618         all_objfiles.
3619         * source.c (forget_cached_source_info): Use all_objfiles.
3620         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3621         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3622         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3623         * objfiles.c (update_section_map): Use all_objfiles.
3624         (shared_objfile_contains_address_p): Likewise.
3625         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3626         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3627
3628 2019-01-09  Tom Tromey  <tom@tromey.com>
3629
3630         * common/next-iterator.h: New file.
3631         * objfiles.h (class all_objfiles): New.
3632         (struct objfile_iterator): New.
3633
3634 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3635
3636         * NEWS: Move the description of the changed "frame", "select-frame",
3637          and "info frame" commands to the Changed commands section.
3638
3639 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3640
3641         * gdbtypes.c (check_stub_method_group): Remove handling of old
3642         mangling schemes.
3643         * linespec.c (find_methods): Likewise.
3644         * stabsread.c (read_member_functions): Likewise.
3645         * valops.c (search_struct_method): Likewise.
3646         (value_struct_elt_for_reference): Likewise.
3647         * NEWS: Mention this change.
3648
3649 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3650
3651         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3652         print_source_lines.
3653         * source.c (print_source_lines_base): Update line number check.
3654         (print_source_lines): New function.
3655         (source_lines_range::source_lines_range): New function.
3656         * source.h (class source_lines_range): New class.
3657         (print_source_lines): New declaration.
3658
3659 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3660
3661         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3662
3663 2019-01-08  Tom Tromey  <tom@tromey.com>
3664             Simon Marchi  <simon.marchi@ericsson.com>
3665
3666         PR gdb/24060
3667         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3668         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3669         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3670         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3671         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3672         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3673
3674 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3675
3676         * source.c (select_source_symtab): Move header comment to
3677         declaration in source.h.
3678         (forget_cached_source_info_for_objfile): Likewise.
3679         (forget_cached_source_info): Likewise.
3680         (identify_source_line): Likewise.
3681         * source.h (identify_source_line): Move declaration from symtab.h
3682         and add comment from source.c
3683         (print_source_lines): Likewise.
3684         (forget_cached_source_info_for_objfile): Likewise.
3685         (forget_cached_source_info): Likewise.
3686         (select_source_symtab): Likewise.
3687         (enum print_source_lines_flag): Move definition from symtab.h.
3688         * symtab.h (identify_source_line): Move declaration to source.h.
3689         (print_source_lines): Likewise.
3690         (forget_cached_source_info_for_objfile): Likewise.
3691         (forget_cached_source_info): Likewise.
3692         (select_source_symtab): Likewise.
3693         (enum print_source_lines_flag): Move definition to source.h.
3694         * tui/tui-hooks.c: Add 'source.h' include.
3695
3696 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3697
3698         * source.c (print_source_lines_base): Handle requests to print
3699         reverse line number sequences, and guard against empty lines
3700         string.
3701
3702 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3703
3704         * source.c (print_source_lines_base): Fix skip of '\r' if next
3705         character is '\n'.
3706
3707 2019-01-06  Tom Tromey  <tom@tromey.com>
3708
3709         * c-exp.y (struct c_parse_state) <macro_original_text,
3710         expansion_obstack>: New member.
3711         (macro_original_text, expansion_obstack): Remove globals.
3712         (scan_macro_expansion, scanning_macro_expansion)
3713         (finished_macro_expansion): Update.
3714         (scan_macro_cleanup): Remove.
3715         (yylex, c_parse): Update.
3716
3717 2019-01-06  Tom Tromey  <tom@tromey.com>
3718
3719         * c-exp.y (struct c_parse_state) <strings>: New member.
3720         (operator_stoken): Update.
3721
3722 2019-01-06  Tom Tromey  <tom@tromey.com>
3723
3724         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3725         (union type_stack_elt) <typelist_val>: Now a pointer to
3726         std::vector.
3727         (type_stack_cleanup): Don't declare.
3728         (push_typelist): Update.
3729         * parse.c (pop_typelist): Return a std::vector.
3730         (push_typelist): Take a std::vector.
3731         (follow_types): Update.  Do not free args.
3732         (type_stack_cleanup): Remove.
3733         * c-exp.y (struct c_parse_state): New.
3734         (cpstate): New global.
3735         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3736         (nonempty_typelist): Update.
3737         (func_mod): Create a new vector.
3738         (c_parse): Create a c_parse_state.
3739         (check_parameter_typelist): Do not delete params.
3740         (function_method): Update.  Do not delete type_list.
3741
3742 2019-01-06  Tom Tromey  <tom@tromey.com>
3743
3744         PR gdb/28155:
3745         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3746         check_typedef.
3747         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3748         (print_return_value): Likewise.
3749
3750 2019-01-05  Tom Tromey  <tom@tromey.com>
3751
3752         * contrib/cleanup_check.py: Remove.
3753         * contrib/gcc-with-excheck: Remove.
3754         * contrib/exsummary.py: Remove.
3755         * contrib/excheck.py: Remove.
3756
3757 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3758
3759         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3760         NULL. Initialize tpprev to NULL instead of assigning it
3761         to NULL on the next statement.
3762         * windows-nat.c (windows_delete_thread): Remove check for
3763         main_thread_id before printing thread exit notifications.
3764         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3765         Remove thread ID check against main_thread_id.
3766         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3767         windows_delete_thread.
3768         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3769
3770 2019-01-04  Tom Tromey  <tom@tromey.com>
3771
3772         * compile/compile.c (_initialize_compile): Use upper case for
3773         metasyntactic variables.
3774         * symmisc.c (_initialize_symmisc): Use upper case for
3775         metasyntactic variables.
3776         * psymtab.c (_initialize_psymtab): Use upper case for
3777         metasyntactic variables.
3778         * demangle.c (demangle_command): Use upper case for metasyntactic
3779         variables.
3780         (_initialize_demangler): Likewise.
3781         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3782         variables.
3783
3784 2019-01-03  Tom Tromey  <tom@tromey.com>
3785
3786         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3787
3788 2019-01-03  Tom Tromey  <tom@tromey.com>
3789
3790         * python/py-symtab.c (salpy_str): Update.
3791         (struct salpy_sal_object) <symtab>: Now a PyObject.
3792         (salpy_dealloc): Update.
3793         (del_objfile_sal): Use gdbpy_ref.
3794
3795 2019-01-03  Tom Tromey  <tom@tromey.com>
3796
3797         * python/py-type.c (convert_field): Use new_reference.  Return
3798         gdbpy_ref.
3799         (make_fielditem): Return gdbpy_ref.
3800         (typy_fields): Update.
3801         (typy_getitem): Update.
3802         (field_name): Return gdbpy_ref.  Use new_reference.
3803         (typy_iterator_iternext): Update.
3804
3805 2019-01-03  Tom Tromey  <tom@tromey.com>
3806
3807         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3808
3809 2019-01-03  Tom Tromey  <tom@tromey.com>
3810
3811         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3812         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3813         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3814         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3815         (pspy_set_type_printers): Likewise.
3816         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3817         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3818         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3819         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3820         (objfpy_set_type_printers): Likewise.
3821
3822 2019-01-03  Tom Tromey  <tom@tromey.com>
3823
3824         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3825         (gdbpy_print_stack): Use gdbpy_err_fetch.
3826         * python/python-internal.h (class gdbpy_err_fetch): New class.
3827         (class gdbpy_enter) <m_error_type, m_error_value,
3828         m_error_traceback>: Remove.
3829         <m_error>: New member.
3830         (gdbpy_exception_to_string): Don't declare.
3831         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3832         * python/py-value.c (convert_value_from_python): Use
3833         gdbpy_err_fetch.
3834         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3835         gdbpy_exception_to_string.
3836         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3837         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3838         gdbpy_err_fetch.
3839
3840 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3841
3842         * linux-nat.c (delete_lwp_cleanup): Delete.
3843         (struct lwp_deleter): New struct.
3844         (lwp_info_up): New typedef.
3845         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3846         lwp_info_up.
3847
3848 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3849
3850         * linux-fork.c (class scoped_switch_fork_info): New class.
3851         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3852
3853 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3854
3855         * valops.c (find_overload_match): Remove use of null_cleanup, and
3856         calls to do_cleanups.
3857
3858 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3859
3860         * compile/compile-cplus-types.c
3861         (compile_cplus_instance::decl_name): Handle changes to
3862         cp_func_name.
3863         * cp-support.c (cp_func_name): Update header comment, update
3864         return type.
3865         * cp-support.h (cp_func_name): Update return type in declaration.
3866         * valops.c (find_overload_match): Move temp_func local to top
3867         level of function and change its type.  Use temp_func to hold and
3868         delete temporary string obtained from cp_func_name.
3869
3870 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3871
3872         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3873         gdb::char_vector, remove cleanup, and update uses of `msg`.
3874
3875 2019-01-03  Jim Wilson  <jimw@sifive.com>
3876
3877         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3878
3879 2019-01-02  Tom Tromey  <tom@tromey.com>
3880
3881         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3882         (tdesc_parse_xml): Remove cleanups.
3883         * target-descriptions.h (make_cleanup_free_target_description):
3884         Don't declare.
3885         (target_desc_deleter): New struct.
3886         (target_desc_up): New typedef.
3887         * target-descriptions.c (target_desc_deleter::operator()): Rename
3888         from free_target_description.
3889         (make_cleanup_free_target_description): Remove.
3890
3891 2019-01-02  Tom Tromey  <tom@tromey.com>
3892
3893         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3894         constructor, destructor.
3895         (linespec_parser): Remove typedef.
3896         (~linespec_parser): Rename from linespec_parser_delete.
3897         (linespec_lex_to_end, linespec_complete_label)
3898         (linespec_complete): Update.
3899         (decode_line_full): Remove cleanups.
3900         (decode_line_1): Update.
3901
3902 2019-01-02  Tom Tromey  <tom@tromey.com>
3903
3904         * python/python-internal.h (inferior_to_inferior_object): Change
3905         return type.
3906         * python/py-exitedevent.c (create_exited_event_object): Update.
3907         * python/py-inferior.c (inferior_to_inferior_object): Return
3908         gdbpy_ref.
3909         (python_new_inferior, python_inferior_deleted)
3910         (thread_to_thread_object, delete_thread_object)
3911         (build_inferior_list, gdbpy_selected_inferior): Update.
3912         * python/py-infthread.c (create_thread_object): Update.  Also fail
3913         if inferior_to_inferior_object fails.
3914
3915 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3916
3917         * inferior.h (class inferior) <displaced_step_state>: New field.
3918         * infrun.h (struct displaced_step_state): Move here from
3919         infrun.c.  Initialize fields, add constructor.
3920         <inf>: Remove field.
3921         <reset>: New method.
3922         * infrun.c (struct displaced_step_inferior_state): Move to
3923         infrun.h.
3924         (displaced_step_inferior_states): Remove.
3925         (get_displaced_stepping_state): Adust.
3926         (displaced_step_in_progress_any_inferior): Adjust.
3927         (displaced_step_in_progress_thread): Adjust.
3928         (displaced_step_in_progress): Adjust.
3929         (add_displaced_stepping_state): Remove.
3930         (get_displaced_step_closure_by_addr): Adjust.
3931         (remove_displaced_stepping_state): Remove.
3932         (infrun_inferior_exit): Call displaced_step_state.reset.
3933         (use_displaced_stepping): Don't check for NULL.
3934         (displaced_step_prepare_throw): Call
3935         get_displaced_stepping_state.
3936         (displaced_step_fixup): Don't check for NULL.
3937         (prepare_for_detach): Don't check for NULL.
3938
3939 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3940
3941         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3942          in case of call that did not complete.
3943
3944 2019-01-02  Andrey Utkin  <autkin@undo.io>
3945
3946         * symfile.c (find_separate_debug_file): Fix search of debug files for
3947         remote debuggee.
3948
3949 2019-01-02  Tom Tromey  <tom@tromey.com>
3950
3951         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3952         indentation.
3953         * python/py-frame.c (frapy_older): Remove cast.
3954         (frapy_newer): Likewise.
3955         * python/py-breakpoint.c (local_setattro): Remove cast.
3956         * python/py-arch.c (archpy_name): Remove local variable.
3957         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3958
3959 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3960
3961         * unittests/basic_string_view/element_access/char/empty.cc:
3962         Fix year range in copyright header.
3963
3964 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3965
3966         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3967         Delete.
3968         <operator==>: Update with for removed field.
3969         <hash>: Likewise.
3970         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3971         <isa_features>: ...this.
3972         <abi_features>: New field.
3973         (riscv_isa_flen): Update comment.
3974         (riscv_abi_xlen): New declaration.
3975         (riscv_abi_flen): New declaration.
3976         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3977         isa_features.
3978         (riscv_abi_xlen): New function.
3979         (riscv_isa_flen): Update to get answer from isa_features.
3980         (riscv_abi_flen): New function.
3981         (riscv_has_fp_abi): Update to get answer from abi_features.
3982         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3983         xlen and flen.
3984         (riscv_call_info) <xlen, flen>: Update comment.
3985         (riscv_call_arg_struct): Remove invalid assertions
3986         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3987         is removed.
3988         (riscv_gdbarch_init): Gather isa features and abi features
3989         separately, ensure both match on the gdbarch when reusing an old
3990         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3991         a target with 64-bit float hardware.
3992
3993 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3994
3995         * source.c (search_command_helper): Stop reverse search
3996         when line 1 has been searched.
3997
3998 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3999
4000         * record-full.c (record_full_base_target::close): Rewrite
4001         record_full_core_buf_list free logic.
4002
4003 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4004
4005         * break-catch-syscall.c (print_one_catch_syscall): xfree
4006         the last text.
4007
4008 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4009
4010         * top.c (print_gdb_version): Update Copyright year in version
4011         message.
4012
4013 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
4014
4015         Update copyright year range in all GDB files.
4016
4017 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
4018
4019         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
4020
4021 For older changes see ChangeLog-2018.
4022 \f
4023 Local Variables:
4024 mode: change-log
4025 left-margin: 8
4026 fill-column: 74
4027 version-control: never
4028 coding: utf-8
4029 End:
4030