gdb/ChangeLog

   1 2019-08-15  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-wingeneral.h (tui_make_window): Update.
   4         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
   5         parameter.
   6         (tui_gen_win_info::make_visible): Update.
   7         * tui/tui-regs.c (tui_data_window::display_registers_from):
   8         Update.
   9         * tui/tui-layout.c (show_source_disasm_command)
  10         (show_source_or_disasm_and_command): Update.
  11         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
  12         (enum tui_box): Remove.
  13         (struct tui_win_info) <can_box>: New method.
  14         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
  15         method.
  16
  17 2019-08-15  Tom de Vries  <tdevries@suse.de>
  18
  19         * linux-nat-trad.c: Include gdbarch.h.
  20
  21 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
  22
  23         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
  24         register sizes.
  25
  26 2019-08-14  Tom Tromey  <tromey@adacore.com>
  27
  28         * darwin-nat.c: Include gdbarch.h.
  29         * darwin-nat-info.c: Include gdbarch.h.
  30
  31 2019-08-13  Tom Tromey  <tom@tromey.com>
  32
  33         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
  34         Remove.
  35         * tui/tui-data.c (tui_initialize_static_data): Update.
  36
  37 2019-08-13  Tom Tromey  <tom@tromey.com>
  38
  39         * tui/tui-winsource.h (struct tui_exec_info_window)
  40         <~tui_exec_info_window, maybe_allocate_content, get_content,
  41         m_content>: Remove.
  42         (struct tui_source_window_base) <set_exec_info_content,
  43         show_exec_info_content>: Don't declare.
  44         * tui/tui-winsource.c
  45         (tui_exec_info_window::maybe_allocate_content): Remove.
  46         (tui_source_window_base::update_exec_info): Rename from
  47         set_exec_info_content.
  48         (tui_source_window_base::show_exec_info_content)
  49         (tui_source_window_base::update_exec_info): Remove.
  50
  51 2019-08-13  Tom Tromey  <tom@tromey.com>
  52
  53         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
  54         declare.
  55         * tui/tui-winsource.c (tui_update_source_window_as_is)
  56         (tui_update_source_windows_with_addr, tui_erase_source_content):
  57         Update.
  58         (tui_clear_exec_info_content): Remove.
  59
  60 2019-08-13  Tom Tromey  <tom@tromey.com>
  61
  62         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
  63         declare.
  64         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
  65         call tui_erase_exec_info_content.
  66         (tui_clear_exec_info_content): Rename from
  67         tui_erase_exec_info_content.
  68         (tui_clear_exec_info_content): Delete.
  69
  70 2019-08-13  Tom Tromey  <tom@tromey.com>
  71
  72         * tui/tui-winsource.h (struct tui_source_window_base)
  73         <show_exec_info_content>: Declare.
  74         (tui_show_exec_info_content): Don't declare.
  75         * tui/tui-winsource.c
  76         (tui_source_window_base::show_exec_info_content): Rename from
  77         tui_show_exec_info_content.
  78         (tui_source_window_base::update_exec_info): Update.
  79
  80 2019-08-13  Tom Tromey  <tom@tromey.com>
  81
  82         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
  83         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
  84         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
  85         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
  86         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
  87         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
  88         ... here.
  89
  90 2019-08-13  Tom Tromey  <tom@tromey.com>
  91
  92         * tui/tui-winsource.h (struct tui_source_window_base)
  93         <update_exec_info>: Declare.
  94         (tui_update_exec_info): Don't declare.
  95         * tui/tui-winsource.c (tui_update_source_window_as_is)
  96         (tui_source_window_base::refresh_all)
  97         (tui_update_all_breakpoint_info): Update.
  98         (tui_source_window_base::update_exec_info): Rename from
  99         tui_update_exec_info.
 100         * tui/tui-stack.c (tui_show_frame_info): Update.
 101
 102 2019-08-13  Tom Tromey  <tom@tromey.com>
 103
 104         * tui/tui-winsource.h (struct tui_source_window_base)
 105         <set_exec_info_content>: Declare.
 106         (tui_set_exec_info_content): Don't declare.
 107         * tui/tui-winsource.c
 108         (tui_source_window_base::set_exec_info_content): Rename from
 109         tui_set_exec_info_content.
 110         (tui_update_exec_info): Update.
 111
 112 2019-08-13  Tom Tromey  <tom@tromey.com>
 113
 114         * tui/tui-winsource.h (struct tui_source_window_base)
 115         <show_source_content>: Declare.
 116         (tui_show_source_content): Don't declare.
 117         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 118         (tui_source_window_base::show_source_content): Rename from
 119         tui_show_source_content.
 120         (tui_source_window_base::refresh_all): Update.
 121         * tui/tui-layout.c (show_source_disasm_command)
 122         (show_source_or_disasm_and_command): Update.
 123
 124 2019-08-13  Tom Tromey  <tom@tromey.com>
 125
 126         * tui/tui-winsource.c (tui_erase_source_content)
 127         (tui_show_source_content, tui_source_window_base::refresh_all):
 128         Update.
 129         * tui/tui-wingeneral.h
 130         (tui_check_and_display_highlight_if_needed): Don't declare.
 131         * tui/tui-wingeneral.c
 132         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 133         check_and_display_highlight_if_needed.
 134         * tui/tui-win.c (tui_rehighlight_all)
 135         (tui_win_info::make_visible_with_new_height): Update.
 136         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 137         (tui_data_window::erase_data_content)
 138         (tui_data_window::display_all_data): Update.
 139         * tui/tui-data.h (struct tui_win_info)
 140         <check_and_display_highlight_if_needed>: Declare.
 141
 142 2019-08-13  Tom Tromey  <tom@tromey.com>
 143
 144         * tui/tui-win.c (tui_resize_all): Call
 145         tui_delete_invisible_windows.
 146         * tui/tui-layout.c (show_layout): Call
 147         tui_delete_invisible_windows.
 148         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 149         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 150
 151 2019-08-13  Tom Tromey  <tom@tromey.com>
 152
 153         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 154         tui_add_win_to_layout.
 155
 156 2019-08-13  Tom Tromey  <tom@tromey.com>
 157
 158         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 159         * tui/tui-layout.c (tui_default_win_height): Now static.
 160
 161 2019-08-13  Tom Tromey  <tom@tromey.com>
 162
 163         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 164         single switch.
 165         (show_source_disasm_command, show_source_or_disasm_and_command):
 166         Don't check current layout.
 167
 168 2019-08-13  Tom Tromey  <tom@tromey.com>
 169
 170         * tui/tui-wingeneral.c (make_all_visible): Remove.
 171         (tui_make_all_invisible): Simplify.
 172         * tui/tui-layout.c (tui_make_all_invisible): Move from
 173         tui-wingeneral.c; simplify.
 174         (show_layout): Hoist call to tui_make_all_invisible.
 175         (show_data): Don't call tui_make_all_invisible.
 176
 177 2019-08-13  Tom Tromey  <tom@tromey.com>
 178
 179         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 180         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 181
 182 2019-08-13  Tom Tromey  <tom@tromey.com>
 183
 184         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 185         tui-data.c.
 186         (show_source_disasm_command, show_data)
 187         (show_source_or_disasm_and_command): Don't use
 188         tui_set_current_layout_to.
 189         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 190         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 191         tui-layout.c.
 192         (tui_set_current_layout_to): Remove.
 193
 194 2019-08-13  Tom Tromey  <tom@tromey.com>
 195
 196         * tui/tui-layout.c (tui_set_layout): Update.
 197         * tui/tui-data.h (struct tui_layout_def): Remove.
 198         (tui_layout_def): Don't declare.
 199         * tui/tui-data.c (layout_def): Remove.
 200         (tui_layout_def): Remove.
 201
 202 2019-08-13  Tom Tromey  <tom@tromey.com>
 203
 204         * tui/tui-winsource.h (struct tui_source_window_base)
 205         <clear_detail>: No longer "override".
 206         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 207         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 208         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 209         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 210         Remove.
 211         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 212
 213 2019-08-13  Tom Tromey  <tromey@adacore.com>
 214
 215         * tracepoint.c: Don't include readline.h or history.h.
 216
 217 2019-08-12  Tom Tromey  <tom@tromey.com>
 218
 219         * configure: Rebuild.
 220         * configure.ac: Check for readline 7.
 221         * NEWS: Mention readline 7 requirement.
 222         * README: Update.
 223
 224 2019-08-12  Tom Tromey  <tom@tromey.com>
 225
 226         * mingw-hdep.c (gdb_select): Remove readline hack.
 227
 228 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 229
 230         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 231         when the function fails.
 232
 233 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 234
 235         * s390-tdep.c (s390_type_align): New function.
 236         (s390_gdbarch_init): Set it as type_align gdbarch method.
 237
 238 2019-08-09  Tom de Vries  <tdevries@suse.de>
 239
 240         PR gdb/24591
 241         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 242         pc_low with relocation offset.
 243
 244 2019-08-07  Tom Tromey  <tromey@adacore.com>
 245
 246         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 247         (print_frame_args): Update.
 248         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 249         Update.
 250         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 251         * frame.h (struct frame_arg): Add initializers.
 252         <error>: Now a unique_xmalloc_ptr.
 253
 254 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 255
 256         * NEWS: Expand the Pointer Authentication entry.
 257         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 258         (aarch64_frame_unmask_lr): ... to this.
 259         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 260         Call aarch64_frame_unmask_lr.
 261         * frame.c (struct frame_info): Add "masked" variable.
 262         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 263         (fprint_frame): Check for masked pc.
 264         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 265         declarations.
 266         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 267         * stack.c (print_frame): Check for masked pc.
 268
 269 2019-08-06  Tom Tromey  <tom@tromey.com>
 270
 271         * stabsread.c (patch_block_stabs, read_one_struct_field)
 272         (read_enum_type): Use obstack_strndup.
 273         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 274         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 275         * dwarf2read.c (guess_full_die_structure_name)
 276         (anonymous_struct_prefix): Use obstack_strndup.
 277         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 278         * c-exp.y (yylex): Use obstack_strndup.
 279         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 280         (write_var_or_type): Use obstack_strndup.
 281
 282 2019-08-06  Tom Tromey  <tom@tromey.com>
 283
 284         * symfile.c (reread_symbols): Use obstack_strdup.
 285         * stabsread.c (read_type): Use obstack_strdup.
 286         * gdb_obstack.h (obstack_strdup): New overload.
 287         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 288         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 289         (dwarf2_canonicalize_name): Use obstack_strdup.
 290         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 291         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 292         Use obstack_strdup.
 293
 294 2019-08-06  Tom Tromey  <tom@tromey.com>
 295
 296         * gdb_obstack.h (obstack_strdup): Define.
 297         * gdb_obstack.c (obstack_strdup): Don't define.
 298
 299 2019-08-06  Tom Tromey  <tom@tromey.com>
 300
 301         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 302         obstack_strdup.
 303         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 304         obstack_strdup.
 305         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 306         * stabsread.c (common_block_start): Use obstack_strdup.
 307         * objfiles.c (set_objfile_main_name, objfile): Use
 308         obstack_strdup.
 309         * namespace.c (add_using_directive): Use obstack_strdup.
 310         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 311         * jit.c (finalize_symtab): Use obstack_strdup.
 312         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 313         (guess_partial_die_structure_name, partial_die_info::fixup)
 314         (dwarf2_name): Use obstack_strdup.
 315         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 316         obstack_strdup.
 317         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 318         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 319         obstack_strdup.
 320         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 321
 322 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 323
 324         * unittests/help-doc-selftests.c: New file.
 325         * Makefile.in: Add the new file.
 326
 327 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 328
 329         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 330         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 331         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 332         the trailing '.' is not output, and the first character is uppercased.
 333         (print_help_for_command): Update call to print_doc_line.
 334         (print_doc_of_command): Likewise.
 335         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 336         * cli/cli-option.c (append_indented_doc): Do not append newline.
 337         (build_help_option): Append newline after first appended_indented_doc
 338         only if a second call is done.
 339         (build_help): Append 2 new lines before each option, except the first
 340         one.
 341         * compile/compile.c (_initialize_compile): Add new lines after
 342         %OPTIONS%, when not at the end of the help.
 343         Change help doc or code
 344         producing the help doc to respect the invariants.
 345         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 346         Also removed the new line after 'Options:', as all other commands
 347         do not put an empty line between 'Options:' and the first option.
 348         * printcmd.c (_initialize_printcmd): Likewise.
 349         * stack.c (_initialize_stack): Likewise.
 350         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 351         incorrectly telling COMMAND is optional.
 352         * ada-lang.c (_initialize_ada_language): Change help doc or code
 353         producing the help doc to respect the invariants.
 354         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 355         * breakpoint.c (_initialize_breakpoint): Likewise.
 356         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 357         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 358         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 359         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 360         _initialize_cli_style): Likewise.
 361         * corelow.c (core_target_info): Likewise.
 362         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 363         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 364         * filesystem.c (_initialize_filesystem): Likewise.
 365         * frame.c (_initialize_frame): Likewise.
 366         * gnu-nat.c (add_task_commands): Likewise.
 367         * infcall.c (_initialize_infcall): Likewise.
 368         * infcmd.c (_initialize_infcmd): Likewise.
 369         * interps.c (_initialize_interpreter): Likewise.
 370         * language.c (_initialize_language): Likewise.
 371         * linux-fork.c (_initialize_linux_fork): Likewise.
 372         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 373         * maint.c (_initialize_maint_cmds): Likewise.
 374         * memattr.c (_initialize_mem): Likewise.
 375         * printcmd.c (_initialize_printcmd): Likewise.
 376         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 377         _RegEx): Likewise.
 378         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 379         * record-btrace.c (_initialize_record_btrace): Likewise.
 380         * record-full.c (_initialize_record_full): Likewise.
 381         * record.c (_initialize_record): Likewise.
 382         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 383         * regcache.c (_initialize_regcache): Likewise.
 384         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 385         _initialize_remote): Likewise.
 386         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 387         * serial.c (_initialize_serial): Likewise.
 388         * skip.c (_initialize_step_skip): Likewise.
 389         * source.c (_initialize_source): Likewise.
 390         * stack.c (_initialize_stack): Likewise.
 391         * symfile.c (_initialize_symfile): Likewise.
 392         * symtab.c (_initialize_symtab): Likewise.
 393         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 394         * top.c (init_main): Likewise.
 395         * tracefile-tfile.c (tfile_target_info): Likewise.
 396         * tracepoint.c (_initialize_tracepoint): Likewise.
 397         * tui/tui-win.c (_initialize_tui_win): Likewise.
 398         * utils.c (add_internal_problem_command): Likewise.
 399         * valprint.c (value_print_option_defs): Likewise.
 400
 401 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 402
 403         PR build/24886
 404         * configure.ac: Drop enable-libmcheck support.
 405         * configure, config.in: Rebuild.
 406         * libmcheck.m4: Remove.
 407         * acinclude.m4: Don't include it.
 408         * Makefile.in: Don't distribute it.
 409         * top.c (print_gdb_configuration): Don't mention it.
 410
 411 2019-08-06  Tom Tromey  <tom@tromey.com>
 412
 413         * utils.c (set_output_style): Sometimes pass stream to
 414         emit_style_escape.
 415         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 416         * record-btrace.c (btrace_insn_history): Update.
 417         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 418         method.
 419         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 420         Update initializers.
 421         <m_uiout>: New field.
 422         <m_di>: Move lower.
 423         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 424         Remove "uiout" parameter.
 425         (dump_insns): Update.
 426         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 427         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 428
 429 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 430
 431         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 432         (error_in_psymtab_expansion): Likewise.
 433         (lookup_symbol_via_quick_fns): Likewise.
 434         (basic_lookup_transparent_type_quick): Likewise.
 435         (basic_lookup_transparent_type_1): Likewise.
 436
 437 2019-08-06  Tom Tromey  <tromey@adacore.com>
 438
 439         * source.c (last_source_error): Now bool.
 440         (print_source_lines_base): Make "noprint" bool.  Only open
 441         source file when last_source_visited changes.
 442
 443 2019-08-06  Tom Tromey  <tromey@adacore.com>
 444
 445         * annotate.c (annotate_source_line): Use g_source_cache.
 446         * source-cache.c (source_cache::get_plain_source_lines): Change
 447         parameters.  Populate m_offset_cache.
 448         (source_cache::ensure): New method.
 449         (source_cache::get_line_charpos): New method.
 450         (extract_lines): Move lower.  Change parameters.
 451         (source_cache::get_source_lines): Move lower.
 452         * source-cache.h (class source_cache): Update comment.
 453         <get_line_charpos>: New method.
 454         <get_source_lines>: Update comment.
 455         <clear>: Clear m_offset_cache.
 456         <get_plain_source_lines>: Change parameters.
 457         <ensure>: New method
 458         <m_offset_cache>: New member.
 459         * source.c (forget_cached_source_info_for_objfile): Update.
 460         (info_source_command): Use g_source_cache.
 461         (find_source_lines, open_source_file_with_line_charpos): Remove.
 462         (print_source_lines_base, search_command_helper): Use g_source_cache.
 463         * source.h (open_source_file_with_line_charpos): Don't declare.
 464         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 465         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 466         Use g_source_cache.
 467
 468 2019-08-06  Tom Tromey  <tromey@adacore.com>
 469
 470         * source-cache.c (source_cache::get_plain_source_lines):
 471         Remove "first_line" and "last_line" parameters.
 472         (source_cache::get_source_lines): Cache plain text.
 473         * source-cache.h (class source_cache)
 474         <get_plain_source_lines>: Update.
 475
 476 2019-08-06  Tom Tromey  <tromey@adacore.com>
 477
 478         * source-cache.c (extract_lines): No longer a method.
 479         Changed type of parameter.  Include final newline.
 480         (selftests::extract_lines_test): New function.
 481         (_initialize_source_cache): Likewise.
 482         * source-cache.h (class source_cache)
 483         <extract_lines>: Don't declare.
 484
 485 2019-08-06  Tom Tromey  <tromey@adacore.com>
 486
 487         * breakpoint.c (init_breakpoint_sal): Update.
 488         (breakpoint): Update.
 489         * breakpoint.h (struct breakpoint) <filter>: Now a
 490         unique_xmalloc_ptr.
 491
 492 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 493
 494         * NEWS: Mention dictionary access on blocks.
 495         * python/py-block.c (blpy_getitem): New function.
 496         (block_object_as_mapping): New struct.
 497         (block_object_type): Use new struct for tp_as_mapping field.
 498
 499 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 500
 501         * objfiles.h (objfile): Add a comment describing partial symbols.
 502
 503 2019-08-05  Tom Tromey  <tromey@adacore.com>
 504
 505         * compile/compile.c (_initialize_compile): Use _(), not N_().
 506         * thread.c (_initialize_thread): Use _(), not N_().
 507         * stack.c (_initialize_stack): Use _(), not N_().
 508         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 509
 510 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 511
 512         * dwarf2read.c (struct dw2_symtab_iterator):
 513         <want_specific_block>: Remove.
 514         <block_index>: Change type to gdb::optional.
 515         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 516         change type of BLOCK_INDEX parameter to gdb::optional.
 517         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 518         (dw2_lookup_symbol): Don't pass argument for
 519         WANT_SPECIFIC_BLOCK.
 520         (dw2_expand_symtabs_for_function): Don't pass argument for
 521         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 522         (class dw2_debug_names_iterator)
 523         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 524         parameter, change BLOCK_INDEX type to gdb::optional.
 525         <m_want_specific_block>: Remove.
 526         <m_block_index>: Change type to gdb::optional.
 527         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 528         gdb::optional.  Re-write in function of gdb::optional.
 529         (dw2_debug_names_lookup_symbol): Don't pass argument for
 530         WANT_SPECIFIC_BLOCK.
 531         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 532         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 533         BLOCK_INDEX.
 534
 535 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 536
 537         * NEWS: Mention changes to "info sources" command.
 538
 539 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 540
 541         * symtab.c (filename_partial_match_opts): New struct type.
 542         (struct output_source_filename_data): New members
 543         regexp, c_regexp, partial_match.
 544         (output_source_filename): Use new members to decide to print file.
 545         (info_sources_option_defs): New variable.
 546         (make_info_sources_options_def_group, print_info_sources_header,
 547         info_sources_command_completer):
 548         New functions.
 549         (info_sources_command): Read new optional arguments.
 550         (_initialize_symtab): Update info sources help.
 551
 552 2019-08-02  Alexandre Oliva <oliva@adacore.com>
 553
 554         * ada-lang.c (exception_support_info_v0): Renamed from...
 555         (default_exception_support_info): ... this.  Create new
 556         definition for v1.
 557         (ada_has_this_exception_support): Look up catch_handlers_sym.
 558         (ada_exception_support_info_sniffer): Try v0 after default.
 559
 560 2019-08-01  Tom Tromey  <tromey@adacore.com>
 561
 562         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
 563         gdbarch.h.
 564
 565 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
 566
 567         * s12z-tdep.c: Fix include path for s12z-opc.h.
 568
 569 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
 570
 571         * NEWS: Require GNU make 3.82.
 572
 573 2019-07-16  Tom Tromey  <tom@tromey.com>
 574
 575         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 576         declare.
 577
 578 2019-07-30  Tom Tromey  <tromey@adacore.com>
 579
 580         * block.c (contained_in): Remove BLOCK_FUNCTION check.
 581
 582 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
 583
 584         * printcmd.c (print_address_symbolic): Print negative offsets.
 585         (build_address_symbolic): Force signed arithmetic when computing
 586         offset.
 587
 588 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 589
 590         PR/24474: Add a function to lookup static variables.
 591         * NEWS: Mention this new function.
 592         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 593         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 594         * python/python.c (python_GdbMethods): Add new function.
 595
 596 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 597
 598         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 599         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 600         (objfpy_lookup_static_symbol): New function.
 601         (objfile_object_methods): Add new functions.
 602
 603 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 604
 605         * NEWS: Mention 'set|show print frame-info'.  Mention new
 606         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 607         backtrace argument.  Mention that python frame filtering code
 608         is now consistent with what 'backtrace' command prints.
 609
 610 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 611
 612         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 613         comments.
 614         (print_frame_info_auto, print_frame_info_source_line,
 615         print_frame_info_location, print_frame_info_source_and_location,
 616         print_frame_info_location_and_address, print_frame_info_short_location):
 617         New declarations.
 618         (struct frame_print_options): New member print_frame_info.
 619         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 620         * stack.h (get_user_print_what_frame_info): New declaration.
 621         (frame_show_address): New declaration.
 622         * stack.c (print_frame_arguments_choices): New value 'presence'.
 623         (print_frame_info_auto, print_frame_info_source_line,
 624         print_frame_info_location, print_frame_info_source_and_location,
 625         print_frame_info_location_and_address, print_frame_info_short_location,
 626         print_frame_info_choices, print_frame_info_print_what): New definitions.
 627         (print_frame_args): Only print dots for args if print frame-arguments
 628         is 'presence'.
 629         (frame_print_option_defs): New element for "frame-info".
 630         (get_user_print_what_frame_info): New function.
 631         (frame_show_address): Make non static.  Move comment to stack.h.
 632         (print_frame_info_to_print_what): New function.
 633         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
 634         to decide what to print.
 635         (backtrace_command_1): Handle the new print_frame_arguments_presence
 636         value.
 637         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
 638         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
 639         (py_print_frame): In non-mi mode, use LOCATION as default for
 640         print_what, similarly to frame information printed directly by
 641         backtrace command. Handle frame-info user option in non MI mode.
 642
 643 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 644
 645         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
 646         Add case for debugging 32-bit target on 64-bit host.  Revise
 647         comment.
 648
 649 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 650
 651         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
 652         instead of find_function_entry_range_from_pc.
 653
 654 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 655
 656         * stack.c (find_frame_funname): Remove code which preferred
 657         minsym over symtab sym in "certain pathological cases".
 658
 659         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
 660         parameter.  Change type of "do_demangle" to bool.
 661         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 662         Pass suitable "prefer_sym_over_minsym" flag to
 663         build_address_symbolic().  Don't output "+" for negative offsets.
 664         * printcmd.c (print_address_symbolic): Update invocation of
 665         build_address_symbolic to include a "prefer_sym_over_minsym"
 666         flag.
 667         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 668         Restrict cases in which use of minimal symbol is preferred to that
 669         of a found symbol.  Update comments.
 670
 671         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 672         for entry pc when entry pc is out of range for that FDE.
 673
 674 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 675
 676         PR gdb/24839:
 677         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 678         type.
 679
 680 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 681
 682         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 683         this function's Python signature.
 684
 685
 686 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 687
 688         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 689         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 690         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 691         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 692         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 693
 694
 695 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 696
 697         * h8300-tdep.c (h8300_register_name_common): New.
 698         h8300_register_name): Use h8300_register_name_common.
 699         (h8300s_register_name): Likewise.
 700         (h8300sx_register_name): Likewise.
 701         (h8300h_register_nam): New.
 702         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 703
 704
 705 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 706
 707         * arm-tdep.c (arm_skip_cmse_entry): New function.
 708         (arm_is_sgstubs_section): New function.
 709         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 710
 711 2019-07-22  Tom Tromey  <tom@tromey.com>
 712
 713         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 714         Don't self-assign.
 715
 716 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 717
 718         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 719         type_print.
 720
 721 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 722
 723         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 724         so that GDB doesn't match any msymbols when searching in the
 725         TYPES_DOMAIN.
 726         (print_symbol_info): Print using typedef_print or type_print based
 727         on the type of the symbol.  Add updated FIXME comment moved from...
 728         (_initialize_symtab): ... move and update FIXME comment to above.
 729
 730 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 731
 732         * NEWS: Mention adding -q option to "info types".
 733         * symtab.c (struct info_types_options): New struct.
 734         (info_types_options_defs): New variable.
 735         (make_info_types_options_def_group): New function.
 736         (info_types_command): Use gdb::option framework to parse options.
 737         (info_types_command_completer): New function.
 738         (_initialize_symtab): Extend the help text on "info types" and
 739         register command completer.
 740
 741 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 742
 743         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 744         (lookup_symbol_in_objfile): Change int to block_enum and add a
 745         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 746
 747 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 748
 749         * MAINTAINERS (Write After Approval): Add self.
 750
 751 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 752
 753         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 754         instruction to the dummy code region.
 755
 756 2019-07-19  Tom Tromey  <tromey@adacore.com>
 757
 758         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 759         (ARGSUSED, PARAMS, __func__): Remove rules.
 760
 761 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 762
 763         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 764         * features/arm/arm-with-iwmmxt.c: Remove.
 765         * features/arm/arm-with-iwmmxt.xml: Remove.
 766         * features/arm/arm-with-m-fpa-layout.c: Remove.
 767         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 768         * features/arm/arm-with-m-vfp-d16.c: Remove.
 769         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 770         * features/arm/arm-with-m.c: Remove.
 771         * features/arm/arm-with-m.xml: Remove.
 772         * features/arm/arm-with-neon.c: Remove.
 773         * features/arm/arm-with-neon.xml: Remove.
 774         * features/arm/arm-with-vfpv2.c: Remove.
 775         * features/arm/arm-with-vfpv2.xml: Remove.
 776         * features/arm/arm-with-vfpv3.c: Remove.
 777         * features/arm/arm-with-vfpv3.xml: Remove.
 778
 779 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 780
 781         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 782
 783 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 784
 785         * arch/aarch32.c (aarch32_create_target_description): Create
 786         target descriptions using features.
 787         * arch/arm.c (arm_create_target_description)
 788         (arm_create_mprofile_target_description): Likewise.
 789         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 790
 791 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 792
 793         * Makefile.in: Add new files.
 794         * aarch32-tdep.c: New file.
 795         * aarch32-tdep.h: New file.
 796         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 797         Call aarch32_read_description.
 798         * arch/aarch32.c: New file.
 799         * arch/aarch32.h: New file.
 800         * arch/arm.c (arm_create_target_description)
 801         (arm_create_mprofile_target_description): New function.
 802         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 803         (arm_create_target_description)
 804         (arm_create_mprofile_target_description): New declaration.
 805         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 806         read_description functions.
 807         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 808         Likewise.
 809         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 810         * arm-tdep.c (tdesc_arm_list): New variable.
 811         (arm_register_g_packet_guesses): Call create description functions.
 812         (arm_read_description) (arm_read_mprofile_description): New
 813         function.
 814         * arm-tdep.h (arm_read_description)
 815         (arm_read_mprofile_description): Add declaration.
 816         * configure.tgt: Add new files.
 817
 818 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 819
 820         * top.c (new_ui_command): Open specified terminal just once.
 821
 822 2019-07-18  Tom Tromey  <tromey@adacore.com>
 823
 824         * symtab.c (main_name): Constify return type.
 825         * symfile.c (set_initial_language): Update.
 826         * symtab.h (main_name): Constify return type.
 827
 828 2019-07-17  Tom Tromey  <tom@tromey.com>
 829
 830         * tui/tui-winsource.c (tui_update_source_window)
 831         (tui_update_source_window_as_is)
 832         (tui_update_source_windows_with_line): Remove return.
 833         * tui/tui-disasm.c (tui_show_disassem)
 834         (tui_show_disassem_and_update_source): Remove return.
 835         * tui/tui.c (tui_reset): Remove return.
 836         * tui/tui-wingeneral.c
 837         (tui_check_and_display_highlight_if_needed): Remove return.
 838
 839 2019-07-17  Tom Tromey  <tom@tromey.com>
 840
 841         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 842
 843 2019-07-17  Tom Tromey  <tom@tromey.com>
 844
 845         * tui/tui-winsource.h (struct tui_exec_info_window)
 846         (struct tui_source_window_base): Move from tui-data.h.
 847         * tui/tui-winsource.c: Move many method definitions from
 848         elsewhere.  Remove "structuring" comments.
 849         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 850         (tui_source_window_base::refresh_window): Move to
 851         tui-winsource.c.
 852         * tui/tui-win.c (tui_source_window_base::refresh_all)
 853         (tui_source_window_base::update_tab_width)
 854         (tui_source_window_base::set_new_height)
 855         (tui_source_window_base::do_make_visible_with_new_height): Move to
 856         tui-winsource.c.
 857         * tui/tui-source.h: Update.
 858         * tui/tui-source.c (tui_source_window_base::reset): Move to
 859         tui-winsource.c.
 860         * tui/tui-disasm.h: Update.
 861         * tui/tui-data.h (struct tui_exec_info_window): Move to
 862         tui-winsource.h.
 863         (struct tui_source_window_base): Likewise.
 864         * tui/tui-data.c (tui_source_window_base::clear_detail)
 865         (tui_source_window_base, ~tui_source_window_base): Move to
 866         tui-winsource.c.
 867
 868 2019-07-17  Tom Tromey  <tom@tromey.com>
 869
 870         * tui/tui-win.c (tui_resize_all)
 871         (tui_source_window_base::update_tab_width)
 872         (tui_adjust_win_heights): Update.
 873         (tui_win_info::make_invisible_and_set_new_height): Rename from
 874         make_invisible_and_set_new_height.
 875         * tui/tui-data.h (struct tui_win_info)
 876         <make_invisible_and_set_new_height>: New method.
 877
 878 2019-07-17  Tom Tromey  <tom@tromey.com>
 879
 880         * tui/tui.c: Update.
 881         * tui/tui-source.h (struct tui_source_window): Move from
 882         tui-data.h.
 883         * tui/tui-layout.c: Update.
 884         * tui/tui-disasm.c: Update.
 885         * tui/tui-data.h (struct tui_source_window): Move to
 886         tui-source.h.
 887
 888 2019-07-17  Tom Tromey  <tom@tromey.com>
 889
 890         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 891         tui-data.h.
 892         * tui/tui-data.h (struct tui_disasm_window): Move to
 893         tui-disasm.h.
 894
 895 2019-07-17  Tom Tromey  <tom@tromey.com>
 896
 897         * tui/tui-regs.h (struct tui_data_item_window): Move from
 898         tui-data.h.
 899         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 900         * tui/tui-data.h (struct tui_data_item_window): Move to
 901         tui-regs.h.
 902         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 903
 904 2019-07-17  Tom Tromey  <tom@tromey.com>
 905
 906         * tui/tui.c: Update.
 907         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 908         (tui_cmd_window::max_height): Move to tui-command.c.
 909         * tui/tui-layout.c: Update.
 910         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 911         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 912         tui-command.c.
 913         * tui/tui-command.h (struct tui_cmd_window): Move from
 914         tui-data.h.
 915         * tui/tui-command.c: Remove "structuring" comments.
 916         (tui_cmd_window::clear_detail)
 917         (tui_cmd_window::do_make_visible_with_new_height)
 918         (tui_cmd_window::max_height): Move from elsewhere.
 919
 920 2019-07-17  Tom Tromey  <tom@tromey.com>
 921
 922         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 923         Now static.
 924         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 925         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 926
 927 2019-07-17  Tom Tromey  <tom@tromey.com>
 928
 929         * tui/tui.c: Update.
 930         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 931         tui-regs.c.
 932         * tui/tui-windata.h: Remove file.
 933         * tui/tui-windata.c: Remove file.
 934         * tui/tui-win.c (tui_data_window::set_new_height)
 935         (tui_data_window::do_make_visible_with_new_height): Move to
 936         tui-regs.c.
 937         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 938         * tui/tui-regs.c: Remove "structuring" comments.
 939         (tui_data_window::first_data_item_displayed)
 940         (tui_data_window::delete_data_content_windows)
 941         (tui_data_window::erase_data_content)
 942         (tui_data_window::display_all_data)
 943         (tui_data_window::refresh_all)
 944         (tui_data_window::do_scroll_vertical)
 945         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 946         (tui_data_window::do_make_visible_with_new_height)
 947         (tui_data_window::refresh_window): Move from elsewhere.
 948         (_initialize_tui_regs): Move to end of file.
 949         * tui/tui-layout.c: Update.
 950         * tui/tui-hooks.c: Update.
 951         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 952         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 953         tui-regs.c.
 954         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 955
 956 2019-07-17  Tom Tromey  <tom@tromey.com>
 957
 958         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 959         seen.
 960
 961 2019-07-17  Tom Tromey  <tom@tromey.com>
 962
 963         * tui/tui-win.c (tui_source_window_base::set_new_height)
 964         (tui_source_window_base::do_make_visible_with_new_height): Use
 965         m_has_locator field directly.
 966         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 967         method.
 968         (struct tui_source_window_base) <has_locator>: Likewise.
 969
 970 2019-07-17  Tom Tromey  <tom@tromey.com>
 971
 972         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 973         Don't declare.
 974         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 975         Remove.
 976         * tui/tui-win.c (tui_source_window_base::set_new_height)
 977         (tui_source_window_base::set_new_height)
 978         (make_invisible_and_set_new_height)
 979         (tui_source_window_base::do_make_visible_with_new_height)
 980         (tui_source_window_base::do_make_visible_with_new_height):
 981         Update.
 982         * tui/tui-layout.c (show_source_disasm_command, show_data)
 983         (show_source_or_disasm_and_command): Update.
 984         * tui/tui-layout.c (show_layout): Update.
 985
 986 2019-07-17  Tom Tromey  <tom@tromey.com>
 987
 988         * tui/tui-layout.c (make_data_window): Remove.
 989         (show_data): Unify creation and re-initialization cases.
 990
 991 2019-07-17  Tom Tromey  <tom@tromey.com>
 992
 993         * tui/tui-layout.c (make_source_window, make_disasm_window):
 994         Remove.
 995         (show_data): Unify creation and re-initialization cases.
 996
 997 2019-07-17  Tom Tromey  <tom@tromey.com>
 998
 999         * tui/tui-layout.c (make_command_window): Remove.
1000         (show_source_disasm_command, show_source_or_disasm_and_command):
1001         Unify creation and re-initialization cases.
1002
1003 2019-07-17  Tom Tromey  <tom@tromey.com>
1004
1005         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1006         creation and re-initialization cases.
1007
1008 2019-07-17  Tom Tromey  <tom@tromey.com>
1009
1010         * tui/tui-regs.c (tui_get_register): Return void.
1011
1012 2019-07-17  Tom Tromey  <tom@tromey.com>
1013
1014         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1015         Simplify.
1016
1017 2019-07-17  Tom Tromey  <tom@tromey.com>
1018
1019         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1020         resetting.
1021
1022 2019-07-17  Tom Tromey  <tom@tromey.com>
1023
1024         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1025         * tui/tui-regs.c (tui_reg_layout): New function.
1026         (tui_show_registers, tui_reg_command): Use it.
1027         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1028         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1029         parameters.
1030         (tui_layout_command): Remove.
1031
1032 2019-07-17  Tom Tromey  <tom@tromey.com>
1033
1034         * tui/tui-layout.h (tui/tui-layout): Return void.
1035         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1036
1037 2019-07-17  Tom Tromey  <tom@tromey.com>
1038
1039         * tui/tui-layout.c (show_source_disasm_command, show_data):
1040         Update.
1041         (reset_locator): Remove.
1042         (show_source_or_disasm_and_command): Update.
1043
1044 2019-07-17  Tom Tromey  <tom@tromey.com>
1045
1046         * tui/tui-source.c (tui_source_window_base::reset): Remove
1047         win_type parameter.
1048         * tui/tui-layout.c (make_command_window, make_source_window)
1049         (make_disasm_window, make_data_window)
1050         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1051         (reset_locator, show_source_or_disasm_and_command): Update.
1052         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1053         win_type parameter.
1054         (struct tui_source_window_base) <reset>: Likewise.
1055
1056 2019-07-17  Tom Tromey  <tom@tromey.com>
1057
1058         * tui/tui-layout.c (show_source_disasm_command): Use
1059         reset_locator.
1060         (reset_locator): New function.
1061         (init_and_make_win): Remove.
1062         (show_source_or_disasm_and_command): Use reset_locator.
1063
1064 2019-07-17  Tom Tromey  <tom@tromey.com>
1065
1066         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1067         condition.
1068         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1069         Remove condition.
1070         * tui/tui-source.c (tui_source_window_base::reset): New method.
1071         * tui/tui-layout.c (make_command_window): Don't call
1072         init_and_make_win.
1073         (make_source_window, make_disasm_window): Don't call
1074         make_source_or_disasm_window.
1075         (make_data_window): Don't call init_and_make_win.  Change calling
1076         convention.
1077         (show_source_disasm_command, show_data): Simplify.
1078         (make_source_or_disasm_window): Remove.
1079         (show_source_or_disasm_and_command): Simplify.
1080         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1081         (struct tui_source_window_base) <reset>: Likewise.
1082         <execution_info>: Remove initializer.
1083         * tui/tui-data.c (tui_source_window_base): Initialize
1084         execution_info.
1085
1086 2019-07-17  Tom Tromey  <tom@tromey.com>
1087
1088         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1089         variable.
1090
1091 2019-07-17  Tom Tromey  <tom@tromey.com>
1092
1093         * tui/tui.c (tui_rl_other_window): Update.
1094         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1095         superclass method first.  Always iterate over regs_content.
1096         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1097         method.
1098         * tui/tui-win.c (tui_set_focus_command): Update.
1099
1100 2019-07-17  Tom Tromey  <tom@tromey.com>
1101
1102         * tui/tui-win.c (tui_set_focus_command): Rename from
1103         tui_set_focus.  Call tui_enable.
1104         (tui_set_focus_command): Remove.
1105
1106 2019-07-17  Tom Tromey  <tom@tromey.com>
1107
1108         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1109         refresh_window.
1110         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1111         touchwin.
1112         (tui_data_window::refresh_window): Call refresh_window on data
1113         items.  Always call superclass refresh_window.
1114         (tui_win_info::refresh): Remove.
1115         (tui_source_window_base::refresh_window): Update.
1116         (tui_refresh_all): Update.
1117         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1118         refresh_window.
1119         (show_source_or_disasm_and_command): Likewise.
1120         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1121         (struct tui_source_window_base) <refresh>: Likewise.
1122
1123 2019-07-17  Tom Tromey  <tom@tromey.com>
1124
1125         * tui/tui-winsource.c (tui_clear_source_content)
1126         (tui_show_source_content): Update.
1127         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1128         whether content is empty.
1129         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1130         Remove.
1131
1132 2019-07-17  Tom Tromey  <tom@tromey.com>
1133
1134         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1135         window's contents.
1136         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1137         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1138
1139 2019-07-17  Tom Tromey  <tom@tromey.com>
1140
1141         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1142         (struct tui_data_item_window): Update.
1143
1144 2019-07-17  Tom Tromey  <tom@tromey.com>
1145
1146         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1147         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1148         defines.
1149
1150 2019-07-17  Tom Tromey  <tom@tromey.com>
1151
1152         * tui/tui-winsource.h (tui_erase_source_content)
1153         (tui_clear_source_content): Remove "display_prompt" parameter.
1154         * tui/tui-winsource.c (tui_update_source_window_as_is)
1155         (tui_update_source_windows_with_addr): Update.
1156         (tui_clear_source_content): Remove "display_prompt" parameter.
1157         (tui_erase_source_content): Likewise.  Simplify.
1158         (tui_show_source_content): Update.
1159         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1160         * tui/tui-stack.c (tui_show_frame_info): Update.
1161         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1162         Remove defines.
1163
1164 2019-07-17  Tom Tromey  <tom@tromey.com>
1165
1166         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1167         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1168         parameter.
1169         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1170         parameter.
1171
1172 2019-07-17  Tom Tromey  <tom@tromey.com>
1173
1174         * tui/tui-winsource.c (tui_clear_source_content)
1175         (tui_show_source_content, tui_show_exec_info_content)
1176         (tui_clear_exec_info_content): Update.
1177         * tui/tui-stack.c (tui_show_locator_content): Update.
1178         (tui_show_frame_info): Update.
1179         * tui/tui-source.h (tui_source_window): Don't declare.
1180         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1181         from tui_source_is_displayed.
1182         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1183         Remove field.
1184         (struct tui_source_window_base) <content_in_use>: New field.  Now
1185         bool.
1186         (struct tui_source_window) <showing_source_p>: New method.
1187         (TUI_SRC_WIN): Change cast.
1188         * tui/tui-data.c (tui_initialize_static_data): Update.
1189
1190 2019-07-17  Tom Tromey  <tom@tromey.com>
1191
1192         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1193         location_matches_p.
1194         * tui/tui-source.c (tui_source_window::location_matches_p): New
1195         method.
1196         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1197         method.
1198         * tui/tui-data.h (struct tui_source_window_base)
1199         <location_matches_p>: New method.
1200         (struct tui_source_window, struct tui_disasm_window)
1201         <location_matches_p>: Likewise.
1202
1203 2019-07-17  Tom Tromey  <tom@tromey.com>
1204
1205         * tui/tui-win.c (tui_set_win_height_command): Rename from
1206         tui_set_win_height.
1207         (tui_set_win_height_command): Remove.
1208
1209 2019-07-17  Tom Tromey  <tom@tromey.com>
1210
1211         * tui/tui-source.c (tui_source_window): New constructor.  Add
1212         observer.
1213         (~tui_source_window): New destructor.
1214         (tui_source_window::style_changed): New method.
1215         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1216         (tui_attach_detach_observers): Update.
1217         * tui/tui-data.h (struct tui_source_window): Make constructor not
1218         inline.  Add destructor.
1219         (struct tui_source_window) <style_changed>: New method.
1220         <m_observable>: New member.
1221
1222 2019-07-17  Tom Tromey  <tom@tromey.com>
1223
1224         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1225         * tui/tui-win.c (tui_resize_all): Fix typo.
1226
1227 2019-07-17  Tom Tromey  <tom@tromey.com>
1228
1229         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1230         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1231         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1232         * tui/tui-win.c (window_name_completer): Use foreach.
1233         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1234         (update_tab_width): Likewise.
1235         * tui/tui-layout.c (show_layout): Update.
1236         * tui/tui-data.h (class tui_window_iterator): New.
1237         (struct all_tui_windows): New.
1238         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1239
1240 2019-07-17  Tom Tromey  <tom@tromey.com>
1241
1242         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1243         parameter.  Don't reference globals.
1244         (tui_reg_command): Update.
1245
1246 2019-07-17  Tom Tromey  <tom@tromey.com>
1247
1248         * tui/tui-regs.c (tui_show_registers): Simplify.
1249
1250 2019-07-17  Tom Tromey  <tom@tromey.com>
1251
1252         * tui/tui-regs.c (tui_show_registers): Update.
1253         (tui_show_register_group): Add win_info parameter.
1254
1255 2019-07-17  Tom Tromey  <tom@tromey.com>
1256
1257         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1258         Rename from tui_display_reg_element_at_line.
1259         (tui_data_window::display_registers_from_line): Update.
1260         * tui/tui-data.h (struct tui_data_window)
1261         <display_reg_element_at_line>: New method.
1262
1263 2019-07-17  Tom Tromey  <tom@tromey.com>
1264
1265         * tui/tui-regs.h (tui_display_registers_from)
1266         (tui_display_registers_from_line): Don't declare.
1267         * tui/tui-windata.c (tui_data_window::display_all_data)
1268         (tui_data_window::refresh_all)
1269         (tui_data_window::do_scroll_vertical): Update.
1270         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1271         from tui_display_registers_from.
1272         (tui_display_reg_element_at_line): Update.
1273         (tui_data_window::display_registers_from_line): Rename from
1274         tui_display_registers_from_line.
1275         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1276         display_registers_from_line>: New methods.
1277
1278 2019-07-17  Tom Tromey  <tom@tromey.com>
1279
1280         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1281         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1282         from tui_erase_data_content.
1283         (tui_data_window::display_all_data)
1284         (tui_data_window::refresh_all)
1285         (tui_data_window::do_scroll_vertical): Update.
1286         * tui/tui-regs.c (tui_show_registers): Update.
1287         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1288         New method.
1289
1290 2019-07-17  Tom Tromey  <tom@tromey.com>
1291
1292         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1293         declare.
1294         * tui/tui-windata.c
1295         (tui_data_window::delete_data_content_windows): Rename from
1296         tui_delete_data_content_windows.
1297         (tui_data_window::display_all_data)
1298         (tui_data_window::do_scroll_vertical): Update.
1299         * tui/tui-data.h (struct tui_data_window)
1300         <delete_data_content_windows>: New method.
1301
1302 2019-07-17  Tom Tromey  <tom@tromey.com>
1303
1304         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1305         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1306
1307 2019-07-17  Tom Tromey  <tom@tromey.com>
1308
1309         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1310         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1311         from tui_display_all_data.
1312         * tui/tui-win.c
1313         (tui_data_window::do_make_visible_with_new_height): Update.
1314         * tui/tui-regs.c (tui_show_registers): Update.
1315         * tui/tui-layout.c (tui_set_layout): Update.
1316         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1317         method.
1318
1319 2019-07-17  Tom Tromey  <tom@tromey.com>
1320
1321         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1322         * tui/tui-windata.c (tui_display_data_from): Remove.
1323         (tui_data_window::refresh_all): Update.
1324
1325 2019-07-17  Tom Tromey  <tom@tromey.com>
1326
1327         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1328         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1329         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1330         tui_display_registers_from_line.
1331         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1332         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1333         "force_display" parameter.
1334
1335 2019-07-17  Tom Tromey  <tom@tromey.com>
1336
1337         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1338         declare.
1339         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1340         Rename from tui_first_reg_element_no_inline.
1341         (tui_display_reg_element_at_line)
1342         (tui_display_registers_from_line): Update.
1343         * tui/tui-data.h (struct tui_data_window)
1344         <first_reg_element_no_inline>: New method.
1345
1346 2019-07-17  Tom Tromey  <tom@tromey.com>
1347
1348         * tui/tui-windata.c (tui_display_data_from)
1349         (tui_data_window::do_scroll_vertical): Update.
1350         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1351         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1352         Rename from tui_line_from_reg_element_no.
1353         (tui_display_registers_from_line): Update.
1354         * tui/tui-data.h (struct tui_data_window)
1355         <line_from_reg_element_no>: New method.
1356
1357 2019-07-17  Tom Tromey  <tom@tromey.com>
1358
1359         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1360         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1361         tui_last_regs_line_no.
1362         (tui_display_reg_element_at_line)
1363         (tui_display_registers_from_line): Update.
1364         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1365         method.
1366
1367 2019-07-17  Tom Tromey  <tom@tromey.com>
1368
1369         PR tui/24722:
1370         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1371         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1372         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1373         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1374         (tui_update_breakpoint_info): Likewise.
1375         * tui/tui-hooks.c (tui_event_create_breakpoint)
1376         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1377         Update.
1378
1379 2019-07-17  Tom Tromey  <tom@tromey.com>
1380
1381         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1382
1383 2019-07-17  Tom Tromey  <tom@tromey.com>
1384
1385         * tui/tui-winsource.c (tui_update_source_window_as_is)
1386         (tui_update_source_windows_with_addr): Update.
1387         * tui/tui-source.h (tui_set_source_content)
1388         (tui_show_symtab_source): Add "win_info" parameter.
1389         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1390         parameter.
1391         (tui_show_symtab_source): Likewise.
1392
1393 2019-07-17  Tom Tromey  <tom@tromey.com>
1394
1395         * tui/tui-wingeneral.c
1396         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1397
1398 2019-07-17  Tom Tromey  <tom@tromey.com>
1399
1400         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1401         (struct tui_cmd_window) <can_scroll>: New method.
1402         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1403         method.
1404
1405 2019-07-17  Tom Tromey  <tromey@adacore.com>
1406
1407         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1408         do_field_signed>: Rename.  Change type of "value".
1409         * ui-out.c (ui_out::field_signed): Rename from field_int.
1410         Change type of "value".
1411         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1412         type of "value".
1413         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1414         do_field_int.  Change type of "value".
1415         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1416         do_field_int.  Change type of "value".
1417         * tracepoint.c (trace_status_mi, tfind_1)
1418         (print_one_static_tracepoint_marker): Update.
1419         * thread.c (print_thread_info_1, print_selected_thread_frame):
1420         Update.
1421         * stack.c (print_frame, print_frame_info): Update.
1422         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1423         Update.
1424         * source.c (print_source_lines_base): Update.
1425         * skip.c (info_skip_command): Update.
1426         * record-btrace.c (btrace_ui_out_decode_error)
1427         (btrace_call_history_src_line): Update.
1428         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1429         Update.
1430         * progspace.c (print_program_space): Update.
1431         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1432         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1433         do_field_int.  Change type of "value".
1434         * mi/mi-out.c (mi_ui_out::do_table_begin)
1435         (mi_ui_out::do_table_header): Update.
1436         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1437         type of "value".
1438         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1439         (mi_cmd_data_list_changed_registers, output_register)
1440         (mi_cmd_data_read_memory, mi_load_progress)
1441         (mi_cmd_trace_frame_collected): Update.
1442         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1443         Update.
1444         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1445         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1446         (mi_cmd_var_list_children, varobj_update_one): Update.
1447         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1448         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1449         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1450         * inferior.c (print_inferior): Update.
1451         * gdb_bfd.c (print_one_bfd): Update.
1452         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1453         Update.
1454         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1455         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1456         do_field_int.  Change type of "value".
1457         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1458         do_field_int.  Change type of "value".
1459         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1460         (print_one_breakpoint_location, print_it_catch_fork)
1461         (print_one_catch_fork, print_it_catch_vfork)
1462         (print_one_catch_vfork, print_it_catch_solib)
1463         (print_it_catch_exec, print_it_ranged_breakpoint)
1464         (print_mention_watchpoint, print_mention_masked_watchpoint)
1465         (bkpt_print_it, update_static_tracepoint): Update.
1466         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1467         * break-catch-syscall.c (print_it_catch_syscall): Update.
1468         * ada-tasks.c (print_ada_task_info): Update.
1469         * ada-lang.c (print_it_exception, print_mention_exception):
1470         Update.
1471
1472 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1473
1474         PR breakpoints/24541
1475         * gdbarch.c: Regenerate.
1476         * gdbarch.h: Regenerate.
1477         * gdbarch.sh: Adjust return type and parameter types for
1478         'stap_adjust_register'.
1479         (i386_stap_adjust_register): Adjust signature and return new
1480         register name.
1481         * stap-probe.c (stap_parse_register_operand): Adjust use of
1482         'gdbarch_stap_adjust_register'.
1483
1484 2019-07-17  Tom Tromey  <tromey@adacore.com>
1485
1486         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1487         declare VEC.
1488         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1489         std::vector.
1490         (struct s390_process_info): Add initializers.
1491         (s390_add_process): Use new.
1492         (s390_linux_nat_target::low_forget_process): Use delete.
1493         (s390_linux_nat_target::low_new_fork)
1494         (s390_linux_nat_target::stopped_by_watchpoint)
1495         (s390_linux_nat_target::low_prepare_to_resume)
1496         (s390_linux_nat_target::insert_watchpoint)
1497         (s390_linux_nat_target::insert_hw_breakpoint)
1498         (s390_linux_nat_target::remove_watchpoint)
1499         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1500
1501 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1502
1503         * aarch64-fbsd-nat.c: Include regcache.h.
1504         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1505         argument.
1506         (aarch64_fbsd_nat_target::fetch_registers)
1507         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1508         variable.
1509         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1510
1511 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1512
1513         * fbsd-nat.c: Include gdbarch.h.
1514
1515 2019-07-15  Tom Tromey  <tromey@adacore.com>
1516
1517         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1518
1519 2019-07-15  Tom Tromey  <tromey@adacore.com>
1520
1521         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1522         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1523         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1524         * cli-out.c (cli_ui_out::do_field_int): New method.
1525         * ui-out.c (ui_out::field_unsigned): New method.
1526         * symfile.c (generic_load): Use field_unsigned.
1527         (print_transfer_performance): Likewise.
1528         * record-btrace.c (ui_out_field_uint): Remove.
1529         (btrace_call_history_insn_range, btrace_call_history): Use
1530         field_unsigned.
1531         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1532         field_unsigned.
1533         * ui-out.h (class ui_out) <field_unsigned>: New method.
1534         <do_field_unsigned>: Likewise.
1535
1536 2019-07-15  Tom Tromey  <tromey@adacore.com>
1537
1538         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1539         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1540         * target.c (flash_erase_command): Use field_string.
1541         * infrun.c (print_signal_received_reason): Use field_string.
1542         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1543         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1544         field_string.
1545         * ada-tasks.c (print_ada_task_info): Use field_string.
1546
1547 2019-07-15  Tom Tromey  <tromey@adacore.com>
1548
1549         * target.c (flash_erase_command): Use field_core_addr.
1550         * symfile.c (generic_load): Use field_core_addr.
1551         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1552         Use field_core_addr.
1553         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1554         field_core_addr.
1555
1556 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1557
1558         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1559         value if its desired type is smaller than a CORE_ADDR and signed.
1560
1561 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1562
1563         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1564         of changes to field names, and use new is_reference field to
1565         decide if a property is a reference or not.
1566         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1567         field.
1568         (struct dwarf2_property_baton): Update header comment, rename
1569         'referenced_type' to 'property_type' and update comments.
1570         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1571         default property type, store in property baton, update to take
1572         accound of renamed field.
1573         (read_func_scope): Update call to attr_to_dynamic_prop.
1574         (read_array_type): Likewise.
1575         (dwarf2_per_cu_addr_sized_int_type): New function.
1576         (read_subrange_index_type): Move type finding code to
1577         dwarf2_per_cu_addr_sized_int_type.
1578         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1579         (dwarf2_per_cu_addr_type): New function.
1580         (set_die_type): Update calls to attr_to_dynamic_prop.
1581
1582 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1583
1584         * dwarf2read.c (read_subrange_index_type): New function.
1585         (read_subrange_type): Move code into new function and call it.
1586         * gdbtypes.c (create_range_type): Add some asserts.
1587
1588 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1589
1590         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1591         update return statements.
1592         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1593         declaration, and update comment to match.
1594         * gdbtypes.c (resolve_dynamic_array): Update call to
1595         dwarf2_evaluate_property to match new return type.
1596
1597 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1598
1599         * valarith.c (value_subscripted_rvalue): Change lowerbound
1600         parameter type from int to LONGEST.
1601         * value.h (value_subscripted_rvalue): Likewise in declaration.
1602
1603 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1604
1605         * cli/cli-utils.c (info_print_command_completer): New function.
1606         * cli/cli-utils.h: Add 'completer.h' include, and forward
1607         declaration for 'struct cmd_list_element'.
1608         (info_print_command_completer): Declare.
1609         * stack.c (_initialize_stack): Add completer for 'info locals' and
1610         'info args'.
1611         * symtab.c (_initialize_symtab): Add completer for 'info
1612         variables' and 'info functions'.
1613         * NEWS: Mention completion for additional info commands.
1614
1615 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1616
1617         * cli/cli-utils.c (extract_info_print_args): Delete.
1618         (extract_arg_maybe_quoted): Delete.
1619         (info_print_options_defs): New variable.
1620         (make_info_print_options_def_group): New function.
1621         (extract_info_print_options): Define new function.
1622         * cli/cli-utils.h (extract_info_print_args): Delete.
1623         (struct info_print_options): New structure.
1624         (extract_info_print_options): Declare new function.
1625         * stack.c (info_locals_command): Update to use new
1626         extract_info_print_options, also add a header comment.
1627         (info_args_command): Likewise.
1628         * symtab.c (info_variables_command): Likewise.
1629         (info_functions_command): Likewise.
1630
1631 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1632
1633         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1634         to extract string arguments.
1635         * common/common-utils.c (extract_string_maybe_quoted): New function.
1636         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1637
1638 2019-07-11  Tom Tromey  <tromey@adacore.com>
1639
1640         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1641         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1642         * top.h (gdbinit): Don't declare.
1643         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1644         into...
1645         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1646         * top.c (gdb_init): Don't call init_cli_cmds.
1647         (gdbinit): Remove.
1648         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1649
1650 2019-07-11  Tom Tromey  <tromey@adacore.com>
1651
1652         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1653         after it has been moved.
1654
1655 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1656
1657         * valops.c (value_must_coerce_to_target): Change return type to
1658         bool.
1659         * value.h (value_must_coerce_to_target): Likewise.
1660
1661 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1662
1663         * breakpoint.c (is_hardware_watchpoint): Remove
1664         forward-declaration.
1665         (is_masked_watchpoint): Change return type to bool.
1666         (is_tracepoint): Likewise.
1667         (is_breakpoint): Likewise.
1668         (is_hardware_watchpoint): Likewise.
1669         (is_watchpoint): Likewise.
1670         (is_no_memory_software_watchpoint): Likewise.
1671         (is_catchpoint): Likewise.
1672         (breakpoint_1): Make FILTER parameter's return type bool.
1673         is_masked_watchpoint): Change return type to bool.
1674         (save_breakpoints): Make FILTER parameter's return type bool.
1675         * breakpoint.h (is_breakpoint): Change return type to bool.
1676         (is_watchpoint): Likewise.
1677         (is_catchpoint): Likewise.
1678         (is_tracepoint): Likewise.
1679
1680 2019-07-10  Tom Tromey  <tom@tromey.com>
1681
1682         * defs.h: Don't include gdbarch.h.
1683         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1684         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1685         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1686         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1687         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1688         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1689         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1690         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1691         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1692         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1693         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1694         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1695         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1696         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1697         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1698         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1699         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1700         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1701         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1702         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1703         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1704         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1705         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1706         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1707         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1708         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1709         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1710
1711 2019-07-10  Tom Tromey  <tromey@adacore.com>
1712
1713         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1714         * breakpoint.c (init_ada_exception_breakpoint): Register as
1715         bp_catchpoint.
1716         (print_one_breakpoint_location, print_one_breakpoint): Use
1717         is_ada_exception_catchpoint.
1718         * ada-lang.c (class ada_catchpoint_location): Pass
1719         bp_loc_software_breakpoint to bp_location constructor.
1720         (is_ada_exception_catchpoint): New function.
1721
1722 2019-07-10  Tom Tromey  <tromey@adacore.com>
1723
1724         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1725         VEC.
1726         (struct arm_exidx_entry): New method operator<.
1727         (struct arm_exidx_data) <section_maps>: Change type.
1728         (arm_exidx_data_free): Remove.
1729         (arm_exidx_data_key): Change type.  Move lower.
1730         (arm_exidx_new_objfile): Update.
1731         (arm_compare_exidx_entries): Remove.
1732         (arm_find_exidx_entry, _initialize_arm_tdep)
1733
1734 2019-07-10  Tom Tromey  <tromey@adacore.com>
1735
1736         * solib-spu.c (ocl_program_data_key): Change type.
1737         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1738         Update.
1739
1740 2019-07-10  Tom Tromey  <tromey@adacore.com>
1741
1742         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1743         (struct solib_aix_inferior_data) <library_list>: Change type.
1744         (solib_aix_inferior_data_handle): Change type.
1745         (get_solib_aix_inferior_data): Update.
1746         (solib_aix_free_library_list): Remove.
1747         (library_list_start_library): Update.
1748         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1749         return type.
1750         (solib_aix_get_library_list)
1751         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1752         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1753
1754 2019-07-10  Tom Tromey  <tromey@adacore.com>
1755
1756         * solib-dsbt.c (struct dsbt_info): Add initializers.
1757         (solib_dsbt_pspace_data): Change type.
1758         (dsbt_pspace_data_cleanup): Remove.
1759         (get_dsbt_info, _initialize_dsbt_solib): Update.
1760
1761 2019-07-10  Tom Tromey  <tromey@adacore.com>
1762
1763         * spu-tdep.c (spu_overlay_data): Change type.
1764         (spu_get_overlay_table, spu_overlay_new_objfile)
1765         (_initialize_spu_tdep): Update.
1766
1767 2019-07-10  Tom Tromey  <tromey@adacore.com>
1768
1769         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1770         destructor.
1771         (dbx_objfile_data_key): Change type and declare later.
1772         (DBX_SYMFILE_INFO): Rewrite.
1773         * dbxread.c (dbx_objfile_data_key): Change type.
1774         (dbx_symfile_init): Update.
1775         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1776         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1777         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1778
1779 2019-07-10  Tom Tromey  <tromey@adacore.com>
1780
1781         * jit.c (jit_program_space_key): Change type.  Move lower.
1782         (get_jit_program_space_data): Update.
1783         (jit_program_space_data_cleanup): Remove.
1784         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1785         Update.
1786         (struct jit_program_space_data): Add initializers.
1787
1788 2019-07-10  Tom Tromey  <tromey@adacore.com>
1789
1790         * solib-darwin.c (struct darwin_info): Add initializers.
1791         (solib_darwin_pspace_data): Change type.
1792         (darwin_pspace_data_cleanup): Remove.
1793         (get_darwin_info, _initialize_darwin_solib): Update.
1794
1795 2019-07-10  Tom Tromey  <tromey@adacore.com>
1796
1797         * remote-sim.c (struct sim_inferior_data): Add initializers,
1798         constructor, and destructor.
1799         (sim_inferior_data_key): Change type.  Move lower.
1800         (check_for_duplicate_sim_descriptor): Update.
1801         (get_sim_inferior_data): Use new.  Update.
1802         (~sim_inferior_data_cleanup): Rename from
1803         sim_inferior_data_cleanup.  Simplify.
1804         (gdbsim_close_inferior, simulator_command)
1805         (sim_command_completer, _initialize_remote_sim): Update.
1806         (next_pid, INITIAL_PID): Move earlier.
1807
1808 2019-07-10  Tom Tromey  <tromey@adacore.com>
1809
1810         * python/python-internal.h (create_thread_object): Return
1811         gdbpy_ref.
1812         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1813         * python/py-inferior.c (struct threadlist_entry): Add
1814         constructor.
1815         <thread_obj>: Now a gdbpy_ref.
1816         (thread_to_thread_object): Update.
1817         (add_thread_object): Use new.
1818         (delete_thread_object): Use delete.
1819         (infpy_threads): Update.
1820         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1821         GIL.
1822
1823 2019-07-10  Tom Tromey  <tromey@adacore.com>
1824
1825         * valops.c (value_cast): Specialize error message for Ada.
1826
1827 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1828
1829         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1830
1831 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1832
1833         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1834         bpstat_should_step): Return bool, adjust comments.
1835         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1836         bpstat_should_step): Likewise.
1837
1838 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1839
1840         * features/Makefile: Use feature target descriptions for Arm.
1841         * features/arm/arm-core.c: Generate new file.
1842         * features/arm/arm-fpa.c: Likewise.
1843         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1844         * features/arm/arm-m-profile.c: Likewise.
1845         * features/arm/arm-vfpv2.c: Likewise.
1846         * features/arm/arm-vfpv3.c: Likewise.
1847         * features/arm/xscale-iwmmxt.c: Likewise.
1848         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1849
1850 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1851
1852         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1853         ptrace earlier.
1854
1855 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1856
1857         * features/aarch64-pauth.c: Regenerate.
1858
1859 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1860
1861         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1862         bool.
1863         (bpstat_what): Use false instead of 0.
1864
1865 2019-07-09  Pedro Alves  <palves@redhat.com>
1866
1867         * break-catch-throw.c (is_exception_catchpoint): New.
1868         * breakpoint.c (print_one_breakpoint_location): New parameter
1869         'raw_loc'.  Handle it.  Use
1870         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1871         looking at the breakpoint's type.
1872         (print_one_breakpoint): If handling "maint info breakpoints", also
1873         print locations of exception catchpoints.
1874         * breakpoint.h (is_exception_catchpoint): Declare.
1875
1876 2019-07-09  Pedro Alves  <palves@redhat.com>
1877
1878         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1879         "addr" field.
1880         (allocate_location_exception_catchpoint): New.
1881         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1882         (initialize_throw_catchpoint_ops): Install
1883         allocate_location_exception_catchpoint as allocate_location
1884         method.
1885         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1886         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1887         bp_loc_other.
1888         (breakpoint_address_is_meaningful): Delete.
1889         (bl_address_is_meaningful): New.
1890         (breakpoint_locations_match): Adjust comment.
1891         (bp_location_from_bp_type): New, factored out of...
1892         (bp_location::bp_location(breakpoint *)): ... this.
1893         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1894         factored out of...
1895         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1896         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1897         breakpoint_address_is_meaningful.
1898         (bp_locations_compare): Adjust comment.
1899         (update_global_location_list): Use bl_address_is_meaningful
1900         instead of breakpoint_address_is_meaningful.
1901         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1902         explicit.
1903         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1904         * python/py-breakpoint.c (bppy_get_location): No longer check
1905         whether location is null.
1906
1907 2019-07-09  Pedro Alves  <palves@redhat.com>
1908
1909         PR c++/15468
1910         * breakpoint.c (print_one_breakpoint_location): Remove
1911         single-location assert.
1912
1913 2019-07-09  Tom Tromey  <tom@tromey.com>
1914
1915         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1916         * configure: Rebuild.
1917         * configure.ac: Change common to gdbsupport.
1918         * gdbsupport: Rename from common.
1919         * acinclude.m4: Change common to gdbsupport.
1920         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1921         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1922         gdbsupport.
1923         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1924         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1925         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1926         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1927         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1928         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1929         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1930         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1931         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1932         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1933         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1934         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1935         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1936         coff-pe-read.c, command.h, compile/compile-c-support.c,
1937         compile/compile-c.h, compile/compile-cplus-symbols.c,
1938         compile/compile-cplus-types.c, compile/compile-cplus.h,
1939         compile/compile-loc2c.c, compile/compile.c, completer.c,
1940         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1941         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1942         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1943         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1944         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1945         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1946         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1947         features/aarch64-core.c, features/aarch64-fpu.c,
1948         features/aarch64-pauth.c, features/aarch64-sve.c,
1949         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1950         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1951         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1952         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1953         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1954         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1955         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1956         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1957         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1958         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1959         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1960         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1961         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1962         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1963         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1964         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1965         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1966         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1967         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1968         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1969         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1970         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1971         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1972         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1973         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1974         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1975         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1976         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1977         minsyms.c, mips-linux-tdep.c, namespace.h,
1978         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1979         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1980         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1981         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1982         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1983         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1984         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1985         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1986         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1987         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1988         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1989         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1990         procfs.c, producer.c, progspace.h, psymtab.h,
1991         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1992         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1993         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1994         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1995         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1996         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1997         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1998         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1999         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2000         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2001         target-memory.c, target.c, target.h, target/waitstatus.c,
2002         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2003         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2004         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2005         unittests/array-view-selftests.c,
2006         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2007         unittests/common-utils-selftests.c,
2008         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2009         unittests/format_pieces-selftests.c,
2010         unittests/function-view-selftests.c,
2011         unittests/lookup_name_info-selftests.c,
2012         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2013         unittests/mkdir-recursive-selftests.c,
2014         unittests/observable-selftests.c,
2015         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2016         unittests/parse-connection-spec-selftests.c,
2017         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2018         unittests/scoped_fd-selftests.c,
2019         unittests/scoped_mmap-selftests.c,
2020         unittests/scoped_restore-selftests.c,
2021         unittests/string_view-selftests.c, unittests/style-selftests.c,
2022         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2023         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2024         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2025         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2026         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2027         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2028
2029 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2030
2031         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2032         bool value.
2033         (decode_digits_ordinary): Set explicit_line field in sal.
2034         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2035         symtab_and_line that was set on an explicit line number in
2036         assembler code.  Do always update the recorded symtab and line if
2037         we do skip the prologue.
2038
2039 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2040
2041         * breakpoint.c (set_breakpoint_location_function): Remove
2042         explicit_loc parameter.
2043         (momentary_breakpoint_from_master): Update call to
2044         set_breakpoint_location_function.
2045         (add_location_to_breakpoint): Likewise.
2046
2047 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2048
2049         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2050         required features based on default bfd type when no specific bfd
2051         is present.
2052
2053 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2054
2055         * NEWS: Mention that GDB printf and eval commands can now print
2056         C-style and Ada-style convenience var strings without
2057         calling the inferior.
2058         * printcmd.c (printf_c_string): Locally print GDB internal var
2059         instead of transiting via the inferior.
2060         (printf_wide_c_string): Likewise.
2061
2062 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2063
2064         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2065
2066 2019-07-04  Tom Tromey  <tom@tromey.com>
2067
2068         PR tui/24724:
2069         * tui/tui-winsource.c (tui_clear_source_content): Update.
2070         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2071         (tui_update_breakpoint_info): Update.
2072         (tui_set_exec_info_content): Update.
2073         * tui/tui-source.c (tui_set_source_content_nil): Update.
2074         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2075         has_break.
2076         * tui/tui-data.h (enum tui_bp_flag): New.
2077         (tui_bp_flags): New enum flags type.
2078         (struct tui_source_element) <break_mode>: Change type.  Rename
2079         from has_break.
2080         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2081         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2082         constants.
2083         * tui/tui-winsource.h: Fix comment.
2084
2085 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2086
2087         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2088         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2089         (store_fpregs_to_thread)
2090         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2091         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2092         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2093         (IWMMXT_REGS_SIZE): Add define.
2094         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2095         (fetch_vfp_regs, store_vfp_regs)
2096         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2097         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2098
2099 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2100
2101         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2102         defines.
2103         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2104         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2105         (ARM_INT_REGISTER_SIZE): ...to this.
2106         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2107         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2108         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2109         (arm_linux_collect_gregset, supply_nwfpe_register)
2110         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2111         defines.
2112         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2113         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2114         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2115         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2116         (arm_return_in_memory, arm_store_return_value)
2117         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2118         (arm_record_ld_st_multiple): Likewise.
2119         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2120         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2121
2122 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2123
2124         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2125         AARCH64_DISPLACED_MODIFIED_INSNS.
2126         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2127         (aarch64_displaced_step_copy_insn): Likewise.
2128         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2129         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2130         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2131         ARM_DISPLACED_MODIFIED_INSNS.
2132         * arm-tdep.c (arm_gdbarch_init): Likewise.
2133         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2134         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2135         (struct arm_displaced_step_closure): Use
2136         ARM_DISPLACED_MODIFIED_INSNS.
2137
2138 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2139
2140         * features/Makefile: Remove unused xml files.
2141         * features/aarch64.xml: Remove.
2142         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2143         * features/i386/amd64-avx-avx512.xml: Remove.
2144         * features/i386/amd64-avx-linux.xml: Remove.
2145         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2146         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2147         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2148         * features/i386/amd64-avx-mpx.xml: Remove.
2149         * features/i386/amd64-avx.xml: Remove.
2150         * features/i386/amd64-linux.xml: Remove.
2151         * features/i386/amd64-mpx-linux.xml: Remove.
2152         * features/i386/amd64-mpx.xml: Remove.
2153         * features/i386/amd64.xml: Remove.
2154         * features/i386/i386-avx-avx512-linux.xml: Remove.
2155         * features/i386/i386-avx-avx512.xml: Remove.
2156         * features/i386/i386-avx-linux.xml: Remove.
2157         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2158         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2159         * features/i386/i386-avx-mpx-linux.xml: Remove.
2160         * features/i386/i386-avx-mpx.xml: Remove.
2161         * features/i386/i386-avx.xml: Remove.
2162         * features/i386/i386-linux.xml: Remove.
2163         * features/i386/i386-mmx-linux.xml: Remove.
2164         * features/i386/i386-mmx.xml: Remove.
2165         * features/i386/i386-mpx-linux.xml: Remove.
2166         * features/i386/i386-mpx.xml: Remove.
2167         * features/i386/i386.xml: Remove.
2168         * features/i386/x32-avx-avx512-linux.xml: Remove.
2169         * features/i386/x32-avx-linux.xml: Remove.
2170         * features/i386/x32-linux.xml: Remove.
2171
2172 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2173
2174         * regformats/aarch64.dat: Remove.
2175         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2176         * regformats/i386/amd64-avx-linux.dat: Remove.
2177         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2178         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2179         * regformats/i386/amd64-linux.dat: Remove.
2180         * regformats/i386/amd64-mpx-linux.dat: Remove.
2181         * regformats/i386/amd64.dat: Remove.
2182         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2183         * regformats/i386/i386-avx-linux.dat: Remove.
2184         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2185         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2186         * regformats/i386/i386-linux.dat: Remove.
2187         * regformats/i386/i386-mmx-linux.dat: Remove.
2188         * regformats/i386/i386-mpx-linux.dat: Remove.
2189         * regformats/i386/i386.dat: Remove.
2190         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2191         * regformats/i386/x32-avx-linux.dat: Remove.
2192         * regformats/i386/x32-linux.dat: Remove.
2193
2194 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2195
2196         * aarch64-tdep.c: Remove xml self tests.
2197         * amd64-linux-tdep.c: Likewise.
2198         * amd64-tdep.c: Likewise.
2199         * i386-linux-tdep.c: Likewise.
2200         * i386-tdep.c: Likewise.
2201
2202 2019-07-03  Pedro Alves  <palves@redhat.com>
2203
2204         PR cli/24732
2205         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2206         (pipe_cmd_option_defs): New.
2207         (make_pipe_cmd_options_def_group): New.
2208         (pipe_command): Use gdb::option::process_options.
2209         (pipe_command_completer): New function.
2210         (_initialize_cli_cmds): Install completer for "pipe" command.
2211
2212 2019-07-03  Pedro Alves  <palves@redhat.com>
2213
2214         * cli/cli-option.c (union option_value) <string>: New field.
2215         (struct option_def_and_value): Add ctor, move ctor, dtor and
2216         use DISABLE_COPY_AND_ASSIGN.
2217         (option_def_and_value::clear_value): New.
2218         (parse_option, save_option_value_in_ctx, get_val_type_str)
2219         (add_setshow_cmds_for_options): Handle var_string.
2220         * cli-option.h (union option_def::var_address) <string>: New
2221         field.
2222         (struct string_option_def): New.
2223         * maint-test-options.c (struct test_options_opts): Add default
2224         ctor and use DISABLE_COPY_AND_ASSIGN.
2225         <string_opt>: New field.
2226         (test_options_opts::~test_options_opts): New.
2227         (test_options_opts::dump): Also dump "-string".
2228         (test_options_option_defs): Install "string.
2229
2230 2019-07-03  Pedro Alves  <palves@redhat.com>
2231
2232         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2233         option_value with a null enumeration.
2234         (complete_options): Save the option values in the context.
2235         (save_option_value_in_ctx): New, factored out from ...
2236         (process_options): ... here.
2237         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2238         of the function.
2239         * maint-test-options.c (test_options_opts::dump): New, factored
2240         out from ...
2241         (maintenance_test_options_command_mode): ... here.
2242         (maintenance_test_options_command_completion_result): Delete.
2243         (maintenance_test_options_command_completion_text): Update
2244         comment.
2245         (maintenance_show_test_options_completion_result): Change
2246         prototype.  Just print
2247         maintenance_test_options_command_completion_text.
2248         (save_completion_result): New.
2249         (maintenance_test_options_completer_mode): Pass options context to
2250         complete_options, and then save a dump.
2251         (_initialize_maint_test_options): Use add_cmd to install "maint
2252         show test-options-completion-result".
2253
2254 2019-07-03  Pedro Alves  <palves@redhat.com>
2255
2256         * NEWS (New commands): Mention "with" and "maint with".
2257         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2258         (with_command, with_command_completer): New.
2259         (pipe_command): Adjust to new repeat_previous
2260         interface.
2261         (_initialize_cli_cmds): Install the "with" command and its "w"
2262         alias.
2263         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2264         declarations.
2265         * cli/cli-setshow.c (parse_cli_var_uinteger)
2266         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2267         argument strings for all var_types.
2268         (get_setshow_command_value_string): New, factored out from ...
2269         (do_show_command): ... this.
2270         * cli/cli-setshow.h: Include <string>.
2271         (get_setshow_command_value_string): Declare.
2272         * command.h (repeat_previous): Now returns const char *.  Adjust
2273         comment.
2274         * maint.c: Include "cli/cli-cmds.h".
2275         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2276         (_initialize_maint_cmds): Register the "maintenance with" command.
2277         * top.c (repeat_previous): Move bits from pipe_command here:
2278         Return the saved command line, if any; error out if there's no
2279         command to relaunch.
2280
2281 2019-07-03  Pedro Alves  <palves@redhat.com>
2282
2283         * NEWS (New commands): Mention "maint set/show test-settings"
2284         instead of "maint test-settings".
2285         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2286         (maintenance_test_settings_set_list): Rename to ...
2287         (maintenance_set_test_settings_list): ... this.
2288         (maintenance_test_settings_show_list): Rename to  ...
2289         (maintenance_show_test_settings_list): ... this.
2290         (maintenance_test_settings_cmd): Delete.
2291         (maintenance_test_settings_set_cmd): ...
2292         (maintenance_set_test_settings_cmd): ... this.
2293         (maintenance_test_settings_show_cmd): ...
2294         (maintenance_show_test_settings_cmd): ... this.
2295         (maintenance_test_settings_show_value_cmd):
2296         (maintenance_show_test_settings_value_cmd): ... this.
2297         (_initialize_maint_test_settings): No longer install the "maint
2298         test-settings" prefix command.  Rename "maint test-settings set"
2299         to "maint set test-settings", and "maint test-settings show" to
2300         "maint show test-settings".  Adjust all subcommands.
2301
2302 2019-07-03  Pedro Alves  <palves@redhat.com>
2303
2304         * maint-test-settings.c: Fix file's intro comment.  Replace all
2305         references to "test-options" with references to "test-settings",
2306         in comments.
2307
2308 2019-07-03  Pedro Alves  <palves@redhat.com>
2309
2310         * maint-test-settings.c (maintenance_test_settings_xxx)
2311         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2312         New.
2313         (maintenance_test_settings_enums): Use them.
2314         (maintenance_test_settings_enum): Default to
2315         maintenance_test_settings_xxx.
2316         (_initialize_maint_test_settings): Initialize
2317         MAINTENANCE_TEST_SETTINGS_FILENAME.
2318
2319 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2320
2321         * breakpoint.h (remove_breakpoints_inf): Change return type to
2322         void, move function documentation here.
2323         * breakpoint.c (remove_breakpoints_inf): Change return type to
2324         void, move function documentation to header.
2325
2326 2019-07-02  Pedro Alves  <palves@redhat.com>
2327
2328         * NEWS (Completion improvements): Mention "info threads".
2329         * thread.c (struct info_threads_opts, info_threads_option_defs)
2330         (make_info_threads_options_def_group): New.
2331         (info_threads_command): Use gdb::option::process_options.
2332         (info_threads_command_completer): New.
2333         (_initialize_thread): Use gdb::option::build_help to build the
2334         help text for "info threads".
2335
2336 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2337
2338         * defs.h (generic_load): Move from here...
2339         * symfile.h (generic_load): ... to here.  Rename name parameter
2340         to args.
2341         * symfile.c (generic_load): Add comment.
2342
2343 2019-07-01  Tom Tromey  <tromey@adacore.com>
2344
2345         * dwarf2read.c
2346         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2347         declaration of without_params.  Fix formatting.
2348
2349 2019-07-01  Tom Tromey  <tromey@adacore.com>
2350
2351         * ada-exp.y (find_primitive_type): Update.
2352         * ada-lang.h (ada_lookup_symbol): Update.
2353         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2354         parameter.
2355         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2356
2357 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2358
2359         PR breakpoints/24541
2360         * gdbarch.c: Regenerate.
2361         * gdbarch.h: Regenerate.
2362         * gdbarch.sh: Add 'stap_adjust_register'.
2363         * i386-tdep.c: Include '<unordered_set>'.
2364         (i386_stap_adjust_register): New function.
2365         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2366         * stap-probe.c (stap_parse_register_operand): Call
2367         'gdbarch_stap_adjust_register'.
2368
2369 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2370
2371         PR python/24742
2372         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2373         * python/python.c (do_start_initialization): Use 'xmalloc'
2374         instead of 'PyMem_Malloc'.
2375
2376 2019-06-28  Tom Tromey  <tromey@adacore.com>
2377
2378         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2379         for Ada.
2380
2381 2019-06-27  Tom Tromey  <tromey@adacore.com>
2382
2383         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2384         objfile_key.
2385         (arm_find_mapping_symbol, arm_record_special_symbol)
2386         (_initialize_arm_tdep): Update.
2387         (arm_objfile_data_free): Remove.
2388
2389 2019-06-27  Tom Tromey  <tromey@adacore.com>
2390
2391         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2392         to cp_print_static_field.
2393
2394 2019-06-26  Tom Tromey  <tromey@adacore.com>
2395
2396         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2397         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2398         declare.
2399
2400 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2401
2402         * features/aarch64-core.c (create_feature_aarch64_core):
2403         Regenerate.
2404         * features/aarch64-core.xml: Add cpsr flags.
2405
2406 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2407
2408         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2409         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2410
2411 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2412
2413         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2414         field.
2415         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2416         use.
2417         (arm_record_special_symbol): Don't insert new symbol in sorted
2418         position, push it at the end.
2419
2420 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2421
2422         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2423         (arm_mapping_symbol_s): Remove.
2424         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2425         (arm_mapping_symbol_vec): New typedef.
2426         (struct arm_per_objfile): Add constructor.
2427         <section_maps>: Change type to
2428         std::unique_ptr<arm_mapping_symbol_vec[]>.
2429         (arm_compare_mapping_symbols): Remove.
2430         (arm_find_mapping_symbol): Adjust to section_maps type change.
2431         (arm_objfile_data_free): Call delete on arm_per_objfile.
2432         (arm_record_special_symbol): Adjust to section_maps type change.
2433         Allocate arm_per_objfile with new.
2434
2435 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2436
2437         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2438         with the command prefix.
2439
2440 2019-06-25  Tom Tromey  <tom@tromey.com>
2441
2442         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2443         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2444
2445 2019-06-25  Tom Tromey  <tom@tromey.com>
2446
2447         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2448         type.
2449         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2450         protected.
2451
2452 2019-06-25  Tom Tromey  <tom@tromey.com>
2453
2454         * tui/tui-winsource.c
2455         (tui_source_window_base::set_is_exec_point_at): Add check against
2456         LOA_ADDRESS.
2457
2458 2019-06-25  Tom Tromey  <tom@tromey.com>
2459
2460         * tui/tui-source.c (tui_set_source_content): Don't check before
2461         xfree.
2462         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2463
2464 2019-06-25  Tom Tromey  <tom@tromey.com>
2465
2466         * tui/tui-winsource.h (tui_update_source_window_as_is)
2467         (tui_alloc_source_buffer, tui_line_is_displayed)
2468         (tui_addr_is_displayed): Change type of win_info.
2469         * tui/tui-winsource.c (tui_update_source_window_as_is)
2470         (tui_clear_source_content, tui_show_source_line)
2471         (tui_show_source_content, tui_source_window_base::refill)
2472         (tui_source_window_base::set_is_exec_point_at)
2473         (tui_source_window_base::set_is_exec_point_at)
2474         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2475         (tui_alloc_source_buffer, tui_line_is_displayed)
2476         (tui_addr_is_displayed): Change type of win_info.  Update.
2477         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2478         (tui_source_window_base::do_make_visible_with_new_height):
2479         Update.
2480         * tui/tui-source.c (tui_set_source_content)
2481         (tui_set_source_content_nil)
2482         (tui_source_window::do_scroll_vertical): Update.
2483         * tui/tui-layout.c (show_layout): Update.
2484         * tui/tui-disasm.c (tui_set_disassem_content)
2485         (tui_disasm_window::do_scroll_vertical): Update.
2486         * tui/tui-data.h (tui_win_content): Remove.
2487         (struct tui_gen_win_info) <content, content_size>: Remove.
2488         (struct tui_source_element): Add initializers and destructor.
2489         (union tui_which_element, struct tui_win_element): Remove.
2490         (struct tui_source_window_base) <content>: New field.
2491         (struct tui_data_window): Remove destructor.
2492         (tui_alloc_content, tui_free_win_content)
2493         (tui_free_all_source_wins_content): Don't declare.
2494         * tui/tui-data.c (tui_initialize_static_data): Update.
2495         (init_content_element, tui_alloc_content): Remove.
2496         (~tui_gen_win_info): Update.
2497         (~tui_data_window, tui_free_all_source_wins_content)
2498         (tui_free_win_content, free_content, free_content_elements):
2499         Remove.
2500
2501 2019-06-25  Tom Tromey  <tom@tromey.com>
2502
2503         * tui/tui-winsource.h (tui_clear_source_content)
2504         (tui_erase_source_content, tui_show_source_content): Change type
2505         of win_info.
2506         * tui/tui-winsource.c (tui_clear_source_content)
2507         (tui_erase_source_content, tui_show_source_content): Change type
2508         of win_info.
2509         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2510         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2511         win_info.
2512         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2513         win_info.
2514         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2515
2516 2019-06-25  Tom Tromey  <tom@tromey.com>
2517
2518         * tui/tui-winsource.c (tui_clear_source_content)
2519         (tui_source_window_base::set_is_exec_point_at): Update.
2520         * tui/tui-source.c (tui_set_source_content_nil): Update.
2521         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2522         a bool.
2523         * tui/tui-data.c (init_content_element): Update.
2524
2525 2019-06-25  Tom Tromey  <tom@tromey.com>
2526
2527         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2528         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2529         * tui/tui-layout.c (init_and_make_win): Update.
2530         * tui/tui.h (enum tui_win_type): Update.
2531         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2532         tui_win_is_auxillary.
2533         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2534         tui_win_is_auxillary.
2535
2536 2019-06-25  Tom Tromey  <tom@tromey.com>
2537
2538         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2539         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2540         (tui_delete_data_content_windows, tui_display_all_data)
2541         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2542         Update.
2543         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2544         * tui/tui-regs.c (tui_last_regs_line_no)
2545         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2546         (tui_show_registers): Update.
2547         (tui_show_register_group): Return void.  Update.
2548         (tui_display_registers_from, tui_display_reg_element_at_line)
2549         (tui_display_registers_from_line, tui_check_register_values):
2550         Update.
2551         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2552         member.
2553         (struct tui_data_window) <regs_content>: Now a std::vector.
2554         <regs_content_count>: Remove.
2555         (tui_add_content_elements, tui_free_data_content): Don't declare.
2556         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2557         (init_content_element): Remove DATA_WIN case.  Add assert.
2558         (tui_add_content_elements): Remove.
2559         (tui_data_window): Update.
2560         (tui_free_data_content): Remove.
2561         (free_content_elements): Remove DATA_WIN case.
2562
2563 2019-06-25  Tom Tromey  <tom@tromey.com>
2564
2565         * tui/tui-data.c (tui_data_item_window): Update.
2566         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2567         * tui/tui-windata.c (tui_display_all_data)
2568         (tui_display_data_from_line): Update.
2569         (tui_check_data_values): Remove.
2570         * tui/tui-regs.c (tui_show_register_group)
2571         (tui_display_reg_element_at_line): Update.
2572         * tui/tui-hooks.c (tui_register_changed)
2573         (tui_refresh_frame_and_register_information): Call
2574         tui_check_register_values.
2575         * tui/tui-data.h (struct tui_data_window) <data_content,
2576         data_content_count, data_type>: Remove.
2577         (enum tui_data_type): Remove.
2578
2579         * tui/tui-data.c (tui_data_window::clear_detail)
2580         (~tui_data_window): Update.
2581
2582 2019-06-25  Tom Tromey  <tom@tromey.com>
2583
2584         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2585         declare.
2586         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2587         Rename from tui_first_data_item_displayed.  Update.
2588         (tui_data_window::refresh_all)
2589         (tui_data_window::do_scroll_vertical): Update.
2590         * tui/tui-data.h (struct tui_data_window)
2591         <first_data_item_displayed>: Declare new method.
2592
2593 2019-06-25  Tom Tromey  <tom@tromey.com>
2594
2595         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2596         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2597         contents...
2598         (tui_initialize_static_data): ...here.
2599
2600 2019-06-25  Tom Tromey  <tom@tromey.com>
2601
2602         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2603         (tui_display_registers_from, tui_check_register_values): Update.
2604         (tui_display_register): Remove win_info parameter; update.
2605         (tui_get_register): Change type of parameters.
2606         * tui/tui-data.h (struct tui_data_element): Remove.
2607         (union tui_which_element) <data>: Remove.
2608         <data_window>: Change type.
2609         (struct tui_data_item_window): New.
2610         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2611         case.  Add assert.
2612         (~tui_data_item_window): New destructor.
2613         (free_content_elements): Remove DATA_ITEM_WIN case.
2614
2615 2019-06-25  Tom Tromey  <tom@tromey.com>
2616
2617         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2618         Remove.
2619
2620 2019-06-25  Tom Tromey  <tom@tromey.com>
2621
2622         * tui/tui-data.h (struct tui_command_element): Remove.
2623         (union tui_which_element) <command>: Remove.
2624         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2625         assert.
2626         (free_content_elements): Remove CMD_WIN case.
2627
2628 2019-06-25  Tom Tromey  <tom@tromey.com>
2629
2630         * tui/tui-layout.c (tui_set_layout): Update.
2631         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2632         * tui/tui-data.c (layout_def): Update.
2633
2634 2019-06-25  Tom Tromey  <tom@tromey.com>
2635
2636         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2637         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2638         (tui_source_window_base::set_new_height): Update.
2639         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2640         Update.
2641         (tui_set_locator_fullname, tui_set_locator_info)
2642         (tui_show_frame_info): Update.
2643         * tui/tui-source.c (tui_set_source_content)
2644         (tui_source_is_displayed): Update.
2645         * tui/tui-layout.c (show_source_disasm_command, show_data)
2646         (show_source_or_disasm_and_command): Update.
2647         * tui/tui-disasm.c (tui_set_disassem_content)
2648         (tui_get_begin_asm_address): Update.
2649         * tui/tui-data.h (struct tui_locator_element): Remove.
2650         (union tui_which_element) <locator>: Remove.
2651         (struct tui_locator_window): New.
2652         (tui_locator_win_info_ptr): Change return type.
2653         * tui/tui-data.c (_locator): Change type.
2654         (tui_locator_win_info_ptr): Change return type.
2655         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2656         (tui_alloc_content): Add assert.
2657
2658 2019-06-25  Tom Tromey  <tom@tromey.com>
2659
2660         * tui/tui-winsource.c
2661         (tui_exec_info_window::maybe_allocate_content): New method.
2662         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2663         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2664         (make_source_or_disasm_window): Add cast.
2665         * tui/tui-data.h (union tui_which_element) <simple_string>:
2666         Remove.
2667         (struct tui_source_info): New.
2668         (struct tui_source_window_base) <execution_info>: Change type.
2669         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2670         case, and add assert.
2671         (tui_alloc_content): Add assert.
2672
2673 2019-06-25  Tom Tromey  <tom@tromey.com>
2674
2675         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2676         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2677         * tui/tui-data.c (tui_alloc_win_info): Remove.
2678
2679 2019-06-25  Tom Tromey  <tom@tromey.com>
2680
2681         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2682         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2683         can_highlight.
2684
2685 2019-06-25  Tom Tromey  <tom@tromey.com>
2686
2687         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2688         make_visible_with_new_height method.
2689         (tui_win_info::make_visible_with_new_height): New method.
2690         (tui_source_window_base::do_make_visible_with_new_height)
2691         (tui_data_window::do_make_visible_with_new_height)
2692         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2693         (make_visible_with_new_height): Remove.
2694         (tui_resize_all, tui_adjust_win_heights): Use
2695         make_visible_with_new_height method.
2696         * tui/tui-data.h (struct tui_win_info)
2697         <do_make_visible_with_new_height, make_visible_with_new_height>:
2698         New methods.
2699         (struct tui_source_window_base, struct tui_data_window)
2700         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2701         methods.
2702
2703 2019-06-25  Tom Tromey  <tom@tromey.com>
2704
2705         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2706         method.
2707         (update_tab_width): Call update_tab_width method.
2708         * tui/tui-data.h (struct tui_win_info)
2709         (struct tui_source_window_base) <update_tab_width>: New methods.
2710
2711 2019-06-25  Tom Tromey  <tom@tromey.com>
2712
2713         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2714         parameter.
2715         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2716         parameter.
2717         (tui_gen_win_info::make_visible): Update.
2718         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2719         parameter.
2720         * tui/tui-data.h (enum tui_box): New enum.
2721         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2722
2723 2019-06-25  Tom Tromey  <tom@tromey.com>
2724
2725         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2726         init_and_make_win for EXEC_INFO_WIN.
2727         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2728         longer inline.
2729         (struct tui_win_info) <~tui_win_info>: Inline.
2730         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2731         Don't declare.
2732         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2733         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2734         Remove.
2735         (tui_initialize_static_data): Update.
2736         (~tui_gen_win_info): Handle more cleanup here.
2737         (~tui_source_window_base): Delete "execution_info".
2738         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2739
2740 2019-06-25  Tom Tromey  <tom@tromey.com>
2741
2742         * tui/tui-layout.c (make_command_window): Don't set
2743         can_highlight.
2744         (show_source_disasm_command): Call the reset method.
2745         (show_data): Don't set can_highlight.  Call the reset method.
2746         (tui_gen_win_info::reset): Rename from init_gen_win_info
2747         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2748         (show_source_or_disasm_and_command): Call the reset method.
2749         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2750         (struct tui_cmd_window): Set can_highlight.
2751
2752 2019-06-25  Tom Tromey  <tom@tromey.com>
2753
2754         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2755         from make_visible.
2756         (tui_make_visible, tui_make_invisible): Rewrite.
2757         (tui_win_info::make_visible): Remove.
2758         (tui_source_window_base::make_visible): Update.
2759         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2760         method.  Moved from...
2761         (struct tui_win_info) <make_visible>: ...here.
2762
2763 2019-06-25  Tom Tromey  <tom@tromey.com>
2764
2765         * tui/tui-winsource.c
2766         (tui_source_window_base::do_scroll_horizontal): Remove direction
2767         parameter.
2768         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2769         direction parameter.
2770         * tui/tui-win.c (tui_win_info::forward_scroll)
2771         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2772         (tui_win_info::right_scroll): Update.
2773         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2774         direction parameter.
2775         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2776         direction parameter.
2777         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2778         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2779         Remove direction parameter.
2780         (struct tui_source_window_base, struct tui_source_window)
2781         (struct tui_disasm_window, struct tui_data_window)
2782         (struct tui_cmd_window): Update.
2783
2784 2019-06-25  Tom Tromey  <tom@tromey.com>
2785
2786         * tui/tui-winsource.h (tui_set_exec_info_content)
2787         (tui_show_exec_info_content, tui_erase_exec_info_content)
2788         (tui_clear_exec_info_content, tui_update_exec_info): Change
2789         argument to tui_source_window_base.
2790         * tui/tui-winsource.c (tui_set_exec_info_content)
2791         (tui_show_exec_info_content, tui_erase_exec_info_content)
2792         (tui_clear_exec_info_content, tui_update_exec_info): Change
2793         argument to tui_source_window_base.
2794
2795 2019-06-25  Tom Tromey  <tom@tromey.com>
2796
2797         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2798         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2799
2800 2019-06-25  Tom Tromey  <tom@tromey.com>
2801
2802         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2803         check.
2804
2805 2019-06-25  Tom Tromey  <tom@tromey.com>
2806
2807         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2808         type to void.
2809         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2810         type to void.
2811         * tui/tui-source.c (tui_set_source_content): Update.
2812         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2813
2814 2019-06-25  Tom Tromey  <tom@tromey.com>
2815
2816         * tui/tui-win.c (window_name_completer, tui_set_focus)
2817         (tui_all_windows_info): Use name method.
2818         * tui/tui-data.h (struct tui_gen_win_info)
2819         (struct tui_source_window, struct tui_disasm_window)
2820         (struct tui_data_window, struct tui_cmd_window) <name>: New
2821         method.
2822         (tui_win_name): Don't declare.
2823         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2824         (tui_win_name): Remove.
2825
2826 2019-06-25  Tom Tromey  <tom@tromey.com>
2827
2828         * tui/tui-winsource.h (tui_update_source_window)
2829         (tui_update_source_window_as_is): Change parameter type.
2830         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2831         to be a tui_source_window_base.
2832         (tui_update_source_window_as_is): Likewise.
2833         * tui/tui-win.c (make_visible_with_new_height): Update.
2834
2835 2019-06-25  Tom Tromey  <tom@tromey.com>
2836
2837         * tui/tui-winsource.c (tui_erase_source_content)
2838         (tui_show_source_content, tui_show_exec_info_content)
2839         (tui_erase_exec_info_content): Use refresh_window method.
2840         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2841         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2842         from tui_refresh_win.
2843         (tui_data_window::refresh_window): New method.
2844         (tui_win_info::refresh, tui_source_window_base::refresh)
2845         (tui_refresh_all): Use refresh_window method.
2846         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2847         method.
2848         * tui/tui-regs.c (tui_display_register): Call refresh_window
2849         method.
2850         * tui/tui-layout.c (show_source_disasm_command)
2851         (show_source_or_disasm_and_command): Call refresh_window method.
2852         * tui/tui-data.h (struct tui_gen_win_info)
2853         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2854         New method.
2855
2856 2019-06-25  Tom Tromey  <tom@tromey.com>
2857
2858         * tui/tui.c (tui_rl_other_window, tui_enable)
2859         (tui_is_window_visible, tui_get_command_dimension): Update.
2860         * tui/tui-winsource.c (tui_update_source_window_as_is)
2861         (tui_clear_source_content, tui_erase_source_content)
2862         (tui_show_source_line, tui_source_window_base::refill)
2863         (tui_source_window_base::do_scroll_horizontal)
2864         (tui_source_window_base::set_is_exec_point_at)
2865         (tui_update_breakpoint_info, tui_set_exec_info_content)
2866         (tui_alloc_source_buffer, tui_line_is_displayed)
2867         (tui_addr_is_displayed): Update.
2868         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2869         (tui_check_and_display_highlight_if_needed)
2870         (tui_win_info::make_visible, tui_win_info::refresh)
2871         (tui_refresh_all): Update.
2872         * tui/tui-windata.c (tui_first_data_item_displayed)
2873         (tui_delete_data_content_windows, tui_erase_data_content)
2874         (tui_display_all_data, tui_data_window::refresh_all)
2875         (tui_check_data_values): Update.
2876         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2877         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2878         (tui_win_info::backward_scroll, tui_refresh_all_win)
2879         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2880         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2881         (tui_source_window_base::set_new_height)
2882         (tui_data_window::set_new_height)
2883         (make_invisible_and_set_new_height)
2884         (make_visible_with_new_height, new_height_ok)
2885         (parse_scrolling_args): Update.
2886         * tui/tui-stack.c (tui_show_frame_info): Update.
2887         * tui/tui-source.c (tui_set_source_content)
2888         (tui_set_source_content_nil, tui_source_is_displayed)
2889         (tui_source_window::do_scroll_vertical): Update.
2890         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2891         (tui_display_registers_from, tui_display_reg_element_at_line)
2892         (tui_check_register_values, tui_reg_command): Update.
2893         * tui/tui-layout.c (tui_default_win_height)
2894         (show_source_disasm_command, show_data, init_and_make_win)
2895         (show_source_or_disasm_and_command): Update.
2896         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2897         (tui_redisplay_readline, tui_mld_flush)
2898         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2899         (tui_getc): Update.
2900         * tui/tui-disasm.c (tui_set_disassem_content)
2901         (tui_disasm_window::do_scroll_vertical): Update.
2902         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2903         Now virtual.
2904         (struct tui_win_info): Derive from tui_gen_win_info.
2905         <~tui_win_info>: Mark as override.
2906         <generic>: Remove member.
2907         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2908         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2909         (~tui_data_window, ~tui_win_info)
2910         (tui_free_all_source_wins_content): Update.
2911         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2912
2913 2019-06-25  Tom Tromey  <tom@tromey.com>
2914
2915         * tui/tui-layout.c (init_and_make_win): Use new.
2916         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2917         destructor, initializers.
2918         (tui_alloc_generic_win_info): Don't declare.
2919         * tui/tui-data.c (_locator): Add argument to constructor.
2920         (source_win, disasm_win): New globals.
2921         (exec_info): Remove.
2922         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2923         Update.
2924         (tui_alloc_generic_win_info): Remove.
2925         (init_content_element): Use new.
2926         (tui_win_info::tui_win_info): Update.
2927         (free_content_elements) <case DATA_WIN>: Use delete.
2928
2929 2019-06-25  Tom Tromey  <tom@tromey.com>
2930
2931         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2932         * tui/tui-windata.c (tui_first_data_item_displayed)
2933         (tui_delete_data_content_windows): Update.
2934         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2935         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2936         (tui_display_registers_from, tui_check_register_values): Update.
2937         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2938         pointer.
2939         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2940         window.
2941         (tui_free_data_content): Update.
2942         (free_content_elements) <case DATA_WIN>: Free the window.
2943
2944 2019-06-25  Tom Tromey  <tom@tromey.com>
2945
2946         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2947         Update.
2948         * tui/tui-layout.c (make_command_window)
2949         (show_source_disasm_command, show_data, init_and_make_win)
2950         (show_source_or_disasm_and_command): Update.
2951         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2952         method.
2953         <can_highight, is_highlighted>: Now bool.
2954         (tui_set_win_highlight): Don't declare.
2955         * tui/tui-data.c (tui_set_win_highlight): Remove.
2956
2957 2019-06-25  Tom Tromey  <tom@tromey.com>
2958
2959         * tui/tui-wingeneral.c (make_visible): Remove check of window
2960         type.
2961
2962 2019-06-25  Tom Tromey  <tom@tromey.com>
2963
2964         * tui/tui-win.c (tui_win_info::max_height)
2965         (tui_cmd_window::max_height): New methods.
2966         (new_height_ok): Call max_height.
2967         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2968         <max_height>: New method.
2969
2970 2019-06-25  Tom Tromey  <tom@tromey.com>
2971
2972         * tui/tui-win.c (tui_source_window_base::set_new_height)
2973         (tui_data_window::set_new_height): New methods.
2974         (make_invisible_and_set_new_height): Call set_new_height method.
2975         * tui/tui-data.h (struct tui_win_info)
2976         (struct tui_source_window_base, struct tui_data_window)
2977         <set_new_height>: New method.
2978
2979 2019-06-25  Tom Tromey  <tom@tromey.com>
2980
2981         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2982         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2983         tui_refresh_data_win.
2984         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2985         method.
2986         (tui_refresh_all_win): Call the refresh_all method.
2987         (tui_set_focus): Likewise.
2988         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2989         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2990         Likewise.
2991
2992 2019-06-25  Tom Tromey  <tom@tromey.com>
2993
2994         * tui/tui-winsource.h (tui_refill_source_window)
2995         (tui_set_is_exec_point_at): Don't declare.
2996         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2997         (tui_source_window_base::refill): Rename from
2998         tui_refill_source_window.
2999         (tui_source_window_base::do_scroll_horizontal): Update.
3000         (tui_source_window_base::set_is_exec_point_at): Rename from
3001         tui_set_is_exec_point_at.
3002         (tui_update_all_breakpoint_info): Update.
3003         * tui/tui-stack.c (tui_show_frame_info): Update.
3004         * tui/tui-layout.c (show_data): Add cast.
3005         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3006         * tui/tui-data.h (struct tui_source_window_base) <refill,
3007         set_is_exec_point_at>: New methods.
3008         (tui_source_windows, tui_add_to_source_windows): Update types.
3009         (tui_add_to_source_windows): Remove redundant declaration.
3010         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3011         (tui_source_windows): Change return type.
3012         (tui_clear_source_windows_detail): Update.
3013         (tui_add_to_source_windows): Change type of parameter.
3014         (tui_free_all_source_wins_content): Update.
3015
3016 2019-06-25  Tom Tromey  <tom@tromey.com>
3017
3018         * tui/tui-wingeneral.c (tui_win_info::refresh)
3019         (tui_source_window_base::refresh): New methods.
3020         (tui_refresh_all): Call the refresh method.
3021         * tui/tui-data.h (struct tui_win_info)
3022         (struct tui_source_window_base) <refresh>: New method.
3023
3024 2019-06-25  Tom Tromey  <tom@tromey.com>
3025
3026         * tui/tui.h (tui_is_window_visible): Return bool.
3027         * tui/tui.c (tui_is_window_visible): Return bool.
3028         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3029         (tui_make_visible, tui_make_invisible)
3030         (tui_win_info::make_visible)
3031         (tui_source_window_base::make_visible, make_all_visible)
3032         (tui_make_all_visible, tui_make_all_invisible): Update.
3033         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3034         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3035         bool.
3036         (struct tui_win_info, struct tui_source_window_base)
3037         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3038         * tui/tui-data.c (tui_init_generic_part): Update.
3039
3040 2019-06-25  Tom Tromey  <tom@tromey.com>
3041
3042         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3043         (tui_source_window_base::make_visible): New methods.
3044         (make_all_visible): Make method call.
3045         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3046         (struct tui_source_window_base, struct tui_cmd_window): Override
3047         make_visible.
3048         (tui_win_is_source_type): Don't declare.
3049         * tui/tui-data.c (tui_win_is_source_type): Remove.
3050
3051 2019-06-25  Tom Tromey  <tom@tromey.com>
3052
3053         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3054         NULL check.
3055
3056 2019-06-25  Tom Tromey  <tom@tromey.com>
3057
3058         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3059         Inline constructor.  Add initializers for members.
3060         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3061         constructors; now inline in class.
3062
3063 2019-06-25  Tom Tromey  <tom@tromey.com>
3064
3065         * tui/tui-regs.c (tui_show_registers): Update.
3066         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3067         bool.
3068         * tui/tui-data.c (tui_data_window::clear_detail)
3069         (tui_data_window): Update.
3070
3071 2019-06-25  Tom Tromey  <tom@tromey.com>
3072
3073         * tui/tui-windata.c (tui_display_all_data)
3074         (tui_display_data_from_line, tui_display_data_from)
3075         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3076         Update.
3077         * tui/tui-regs.c (tui_last_regs_line_no)
3078         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3079         (tui_show_registers, tui_show_register_group)
3080         (tui_display_registers_from, tui_display_reg_element_at_line)
3081         (tui_display_registers_from_line, tui_check_register_values)
3082         (tui_reg_next, tui_reg_prev): Update.
3083         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3084         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3085         tui_data_window.
3086         (struct tui_win_info) <detail>: Remove.  Add new fields from
3087         tui_data_info.
3088         (TUI_DATA_WIN): Add cast.
3089         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3090         (~tui_data_window): Simplify.
3091
3092 2019-06-25  Tom Tromey  <tom@tromey.com>
3093
3094         * tui/tui-layout.c (show_source_disasm_command)
3095         (show_source_or_disasm_and_command): Update.
3096         * tui/tui-io.c (update_cmdwin_start_line)
3097         (tui_redisplay_readline): Update.
3098         * tui/tui-data.h (struct tui_command_info): Remove.
3099         (struct tui_win_info) <detail>: Remove command_info member.
3100         (struct tui_data_window) <start_line>: New member, from
3101         tui_command_info.
3102         (TUI_CMD_WIN): Add casts.
3103
3104 2019-06-25  Tom Tromey  <tom@tromey.com>
3105
3106         * tui/tui-winsource.c (tui_update_source_window)
3107         (tui_refill_source_window)
3108         (tui_source_window_base::do_scroll_horizontal)
3109         (tui_update_breakpoint_info, tui_set_exec_info_content)
3110         (tui_show_exec_info_content, tui_erase_exec_info_content)
3111         (tui_clear_exec_info_content): Update.
3112         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3113         Update.
3114         * tui/tui-win.c (make_invisible_and_set_new_height)
3115         (make_visible_with_new_height): Update.
3116         * tui/tui-source.c (tui_set_source_content)
3117         (tui_show_symtab_source): Update.
3118         * tui/tui-layout.c (extract_display_start_addr)
3119         (show_source_disasm_command, show_data)
3120         (make_source_or_disasm_window)
3121         (show_source_or_disasm_and_command): Update.
3122         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3123         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3124         "gdbarch".
3125         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3126         to tui_source_window_base.
3127         (struct tui_win_info) <detail>: Remove source_info member.
3128         (struct tui_source_window_base) <has_locator>: Inline.
3129         Move contents from tui_source_info; rename has_locator member to
3130         m_has_locator.
3131         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3132         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3133         header file.
3134         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3135         Simplify.
3136         (tui_free_all_source_wins_content): Cast to
3137         tui_source_window_base.
3138
3139 2019-06-25  Tom Tromey  <tom@tromey.com>
3140
3141         * tui/tui-win.c (make_invisible_and_set_new_height)
3142         (make_visible_with_new_height): Call has_locator method.
3143         * tui/tui-layout.c (show_source_disasm_command, show_data)
3144         (show_source_or_disasm_and_command): Update for bool change.
3145         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3146         (tui_win_info) <has_locator>: New method.
3147         (struct tui_source_window_base) <has_locator>: New method.
3148         (tui_win_has_locator): Don't declare.
3149         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3150         from tui_win_has_locator.
3151         (tui_source_window_base): Use false, not FALSE.
3152
3153 2019-06-25  Tom Tromey  <tom@tromey.com>
3154
3155         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3156         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3157         clear_detail method directly.
3158         (tui_clear_win_detail): Remove.
3159
3160 2019-06-25  Tom Tromey  <tom@tromey.com>
3161
3162         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3163         "this", not TUI_DISASM_WIN.
3164
3165 2019-06-25  Tom Tromey  <tom@tromey.com>
3166
3167         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3168         declare.
3169         * tui/tui-winsource.c
3170         (tui_source_window_base::do_scroll_horizontal): Rename from
3171         tui_horizontal_source_scroll.
3172         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3173         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3174         from tui_vertical_data_scroll.
3175         * tui/tui-win.h (tui_scroll): Don't declare.
3176         * tui/tui-win.c (tui_win_info::forward_scroll)
3177         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3178         (tui_win_info::right_scroll): Rename and update.
3179         (tui_scroll_forward_command, tui_scroll_backward_command)
3180         (tui_scroll_left_command, tui_scroll_right_command): Update.
3181         (tui_scroll): Remove.
3182         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3183         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3184         from tui_vertical_source_scroll.
3185         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3186         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3187         from tui_vertical_disassem_scroll.
3188         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3189         do_scroll_horizontal>: New methods.
3190         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3191         Likewise.
3192         (struct tui_source_window_base): Add do_scroll_horizontal.
3193         (struct tui_source_window, struct tui_disasm_window): Add
3194         do_scroll_vertical.
3195         (struct tui_data_window, struct tui_cmd_window): Add
3196         do_scroll_horizontal and do_scroll_vertical.
3197         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3198
3199 2019-06-25  Tom Tromey  <tom@tromey.com>
3200
3201         * tui/tui-data.h (struct tui_source_window_base): New struct.
3202         (struct tui_source_window): Derive from tui_source_window_base.
3203         (struct tui_disasm_window): New struct.
3204         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3205         from tui_source_window::clear_detail.
3206         (tui_source_window_base): Rename from tui_source_window.
3207         (~tui_source_window_base): Rename from ~tui_source_window.
3208         (tui_alloc_win_info): Create a tui_disasm_window.
3209
3210 2019-06-25  Tom Tromey  <tom@tromey.com>
3211
3212         * tui/tui-data.h (struct tui_source_window)
3213         (struct tui_data_window): Declare destructors.
3214         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3215         destructors.
3216         (tui_win_info): Simplify.
3217
3218 2019-06-25  Tom Tromey  <tom@tromey.com>
3219
3220         * tui/tui-winsource.c (tui_display_main)
3221         (tui_update_source_windows_with_addr)
3222         (tui_update_all_breakpoint_info): Update.
3223         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3224         (new_height_ok, parse_scrolling_args): Update.
3225         * tui/tui-stack.c (tui_show_frame_info): Update.
3226         * tui/tui-data.h (struct tui_list): Remove.
3227         (tui_source_windows): Return a reference to a std::vector.
3228         * tui/tui-data.c (source_windows): Now a std::vector.
3229         (tui_source_windows): Change return type.
3230         (tui_clear_source_windows): Rewrite.
3231         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3232         (tui_free_all_source_wins_content): Rewrite.
3233
3234 2019-06-25  Tom Tromey  <tom@tromey.com>
3235
3236         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3237         (struct tui_data_window, struct tui_cmd_window): Declare
3238         clear_detail method.
3239         * tui/tui-data.c (tui_source_window::clear_detail)
3240         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3241         methods.
3242         (tui_clear_win_detail): Simplify.
3243
3244 2019-06-25  Tom Tromey  <tom@tromey.com>
3245
3246         * tui/tui-layout.c (make_source_window, make_disasm_window)
3247         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3248         Return the new window.
3249         (show_source_disasm_command, show_data)
3250         (show_source_or_disasm_and_command): Update.
3251
3252 2019-06-25  Tom Tromey  <tom@tromey.com>
3253
3254         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3255         parameter.  Return the new window.
3256         (show_source_disasm_command): Update and remove NULL check.
3257         (show_source_or_disasm_and_command): Update.
3258
3259 2019-06-25  Tom Tromey  <tom@tromey.com>
3260
3261         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3262
3263 2019-06-25  Tom Tromey  <tom@tromey.com>
3264
3265         * tui/tui-data.h (struct tui_win_info): Make constructor
3266         protected.  Make destructor virtual.  Add initializers.
3267         (tui_source_window, tui_data_window, tui_cmd_window): New
3268         classes.
3269         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3270         constructor.  Add "type" parameter.
3271         (tui_source_window, tui_data_window, tui_cmd_window): New
3272         constructors.
3273         (tui_alloc_win_info): Instantiate the appropriate subclass.
3274
3275 2019-06-25  Tom Tromey  <tom@tromey.com>
3276
3277         * tui/tui-win.c (tui_resize_all): Use delete.
3278         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3279         destructor.
3280         (tui_free_window): Don't declare.
3281         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3282         Update.
3283
3284 2019-06-25  Tom Tromey  <tom@tromey.com>
3285
3286         * tui/tui-data.h (struct tui_win_info): Add constructor.
3287         * tui/tui-data.c (tui_alloc_win_info): Use new.
3288         (tui_free_window): Use delete.
3289
3290 2019-06-22  Tom Tromey  <tom@tromey.com>
3291
3292         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3293         declare.
3294         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3295
3296 2019-06-22  Tom Tromey  <tom@tromey.com>
3297
3298         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3299         declare.
3300         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3301
3302 2019-06-22  Tom de Vries  <tdevries@suse.de>
3303
3304         * dwarf2read.c (create_addrmap_from_aranges)
3305         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3306         instead of '%zu'.
3307
3308 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3309
3310         * dwarf2read.h (dwarf2_section_info_def): Remove.
3311         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3312         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3313         std::vector<dwarf2_section_info>.
3314         (struct dwo_file) <~dwo_file>: Remove.
3315         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3316         types field.
3317         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3318         (dwarf2_read_debug_names): Likewise.
3319         (create_debug_types_hash_table): Change parameter type to
3320         array_view, adjust code accordingly.
3321         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3322         (partial_die_info::fixup): Likewise.
3323         (determine_prefix): Likewise.
3324         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3325
3326 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3327
3328         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3329         gdb_bfd_ref_ptr.
3330         <~dwo_file>: Remove call to gdb_bfd_unref.
3331         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3332         gdb_bfd_ref_ptr::get.
3333
3334 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3335
3336         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3337         type to htab_up.
3338         * dwarf2read.c (struct dwo_file): Initialize fields.
3339         <~dwo_file>: New.
3340         (free_dwo_file): Remove, move content to ~dwo_file.
3341         (struct dwo_file_deleter): Remove.
3342         (dwo_file_up>: Remove custom deleter.
3343         (free_dwo_files): Remove.
3344         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3345         dwo_files.
3346         (process_skeletonless_type_units): Call unique_ptr::get.
3347         (allocate_dwo_file_hash_table): Add deleter to created hash
3348         table.  Change return type to htab_up.
3349         (lookup_dwo_file_slot): Don't memset dwo_file, call
3350         unique_ptr::get.
3351         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3352         (create_dwo_unit_in_dwp_v2): Likewise.
3353         (open_and_init_dwo_file): Likewise.
3354         (free_dwo_file_from_slot): Remove.
3355
3356 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3357
3358         * dwarf2read.h (struct dwarf2_section_info) <readin,
3359         is_virtual>: Change type to bool.
3360         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3361         true instead of 1.
3362
3363 2019-06-19  Tom Tromey  <tom@tromey.com>
3364
3365         * tui/tui-data.h (tui_init_content_element): Don't declare.
3366
3367 2019-06-19  Tom Tromey  <tom@tromey.com>
3368
3369         * tui/tui-data.h (tui_init_win_info): Don't declare.
3370
3371 2019-06-19  Tom de Vries  <tdevries@suse.de>
3372
3373         * dwarf2read.h (abstract_to_concrete): Change type to
3374         std::unordered_map<sect_offset, std::vector<sect_offset>,
3375         gdb::hash_enum<sect_offset>>.
3376
3377 2019-06-19  Tom Tromey  <tromey@adacore.com>
3378
3379         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3380         EVAL_AVOID_SIDE_EFFECTS specially.
3381
3382 2019-06-19  Tom Tromey  <tromey@adacore.com>
3383
3384         * source-cache.c (highlighter): New global.
3385         (source_cache::get_source_lines): Create a highlighter on demand.
3386
3387 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3388
3389         * defs.h (deprecated_interactive_hook): Delete declaration.
3390         * interps.c (clear_interpreter_hooks): Remove use of
3391         deprecated_interactive_hook.
3392         * top.c (deprecated_interactive_hook): Delete definition.
3393         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3394
3395 2019-06-18  Tom de Vries  <tdevries@suse.de>
3396
3397         PR gdb/24515
3398         * dwarf2read.h (abstract_to_concrete): Change type from
3399         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3400         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3401         * dwarf2read.c (read_variable): Update.
3402         (dwarf2_fetch_die_loc_sect_off): Update.
3403
3404 2019-06-17  Tom de Vries  <tdevries@suse.de>
3405
3406         PR gdb/24617
3407         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3408         accessing parent[parent_len - 1].
3409
3410 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3411
3412         PR gdb/24364
3413         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3414         call dtrace_process_dof with NULL dof.
3415
3416 2019-06-16  Tom de Vries  <tdevries@suse.de>
3417
3418         PR gdb/24445
3419         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3420
3421 2019-06-16  Tom Tromey  <tom@tromey.com>
3422
3423         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3424         (make_all_visible): Use address of member.
3425
3426 2019-06-16  Tom Tromey  <tom@tromey.com>
3427
3428         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3429         (tui_free_window, free_content, free_content_elements): Remove
3430         unnecessary cast.
3431         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3432         cast.
3433         * tui/tui-regs.c (tui_show_register_group)
3434         (tui_display_registers_from, tui_display_reg_element_at_line):
3435         Remove unnecessary cast.
3436
3437 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3438
3439         * linux-nat.c (normal_mask): Delete.
3440         (_initialize_linux_nat): Don't initialise normal_mask.
3441
3442 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3443
3444         PR gdb/24445
3445         * dwarf-index-write.h (write_psymtabs_to_index): Add
3446         dwz_basename parameter.
3447         * dwarf-index-write.c (write_gdbindex): Move file writing to
3448         write_gdbindex_1.  Change return type void.
3449         (assert_file_size): Move up, remove filename parameter.
3450         (write_gdbindex_1): New function.
3451         (write_debug_names): Change return type to void, call
3452         assert_file_size.
3453         (struct index_wip_file): New struct.
3454         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3455         file logic to index_wip_file.  Write index for dwz file if
3456         needed.
3457         (save_gdb_index_command): Pass basename of dwz file, if present.
3458         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3459         build-id of dwz file, if present.
3460         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3461         (dwarf2_get_dwz_file): Likewise.
3462         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3463         (dwarf2_get_dwz_file): Likewise.
3464
3465 2019-06-16  Tom Tromey  <tom@tromey.com>
3466
3467         * coffread.c (process_coff_symbol): Use xstrdup.
3468         * value.c (create_internalvar): Use xstrdup.
3469
3470 2019-06-16  Tom Tromey  <tom@tromey.com>
3471
3472         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3473         * breakpoint.c (stopin_command, stopat_command)
3474         (until_break_command, decode_location_default): Remove unnecessary
3475         cast.
3476         * utils.c (subset_compare): Remove unnecessary cast.
3477         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3478         cast.
3479         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3480         cast.
3481         * infcmd.c (path_command): Remove unnecessary cast.
3482         * coffread.c (decode_type): Remove unnecessary cast.
3483         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3484         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3485         * tui/tui-stack.c (tui_show_locator_content)
3486         (tui_show_frame_info): Remove unnecessary cast.
3487         * tui/tui-win.c (tui_scroll_forward_command)
3488         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3489         (parse_scrolling_args): Remove unnecessary cast.
3490         * tui/tui-data.c (init_win_info, tui_del_window)
3491         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3492         (free_content_elements): Remove unnecessary cast.
3493         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3494         unnecessary cast.
3495         * tui/tui-source.c (tui_set_source_content)
3496         (tui_vertical_source_scroll): Remove unnecessary cast.
3497         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3498         cast.
3499         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3500         * tui/tui-regs.c (tui_display_registers_from)
3501         (tui_display_register): Remove unnecessary cast.
3502         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3503         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3504         (make_visible): Remove unnecessary cast.
3505         * tui/tui-winsource.c (tui_erase_source_content)
3506         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3507         unnecessary cast.
3508         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3509         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3510         * stabsread.c (read_type, read_array_type, read_range_type):
3511         Remove unnecessary cast.
3512         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3513         (parse_symbol, parse_type, upgrade_type, parse_external)
3514         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3515         unnecessary cast.
3516         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3517
3518 2019-06-16  Tom Tromey  <tom@tromey.com>
3519
3520         * tui/tui-data.c (tui_alloc_generic_win_info)
3521         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3522         checks.
3523
3524 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3525             Andrew Burgess  <andrew.burgess@embecosm.com>
3526
3527         * f-typeprint.c (f_print_type): Don't return early for not
3528         associated or not allocated types.
3529         (f_type_print_varspec_suffix): Add print_rank parameter and print
3530         ranks of array types in case they dangling.
3531         (f_type_print_base): Add print_rank parameter.
3532
3533 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3534
3535         * NEWS: Mention new MI commands.
3536         * break-catch-throw.c (enum exception_event_kind): Move to
3537         breakpoint.h.
3538         (print_mention_exception_catchpoint): Output text as a single
3539         message.
3540         (catch_exception_command_1): Rename to...
3541         (catch_exception_event): ...this, make non-static, update header
3542         command, and change some parameter types.
3543         (catch_catch_command): Update for changes to
3544         catch_exception_command_1.
3545         (catch_throw_command): Likewise.
3546         (catch_rethrow_command): Likewise.
3547         * breakpoint.c (enum exception_event_kind): Delete.
3548         * breakpoint.h (enum exception_event_kind): Moved here from
3549         break-catch-throw.c.
3550         (catch_exception_event): Declare.
3551         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3552         (mi_cmd_catch_throw): New function.
3553         (mi_cmd_catch_rethrow): New function.
3554         (mi_cmd_catch_catch): New function.
3555         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3556         'catch-catch' entries.
3557         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3558         (mi_cmd_catch_rethrow): Declare.
3559         (mi_cmd_catch_catch): Declare.
3560
3561 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3562
3563         * annotate.c (annotate_source_line): Change return type to void,
3564         update implementation to match.
3565         * annotate.h (annotate_source_line): Change return type to void,
3566         update header comment.
3567         * stack.c (print_frame_info): Don't change what frame information
3568         is printed based on whether annotations are on or not.
3569
3570 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3571
3572         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3573         (annotate_source): Make static.
3574         (annotate_source_line): Moved from source.c and renamed from
3575         identify_source_line.  Update the return type.
3576         * annotate.h (annotate_source): Delete declaration.
3577         (annotate_source_line): Declaration moved from source.h, and
3578         renamed from identify_source_line.  Return type updated.
3579         * source.c (identify_source_line): Moved to annotate.c and renamed
3580         to annotate_source_line.
3581         (info_line_command): Remove check of annotation_level.
3582         * source.h (identify_source_line): Move declaration to annotate.h
3583         and rename to annotate_source_line.
3584         * stack.c: Add 'annotate.h' include.
3585         (print_frame_info): Remove check of annotation_level before
3586         calling annotate_source_line.
3587
3588 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3589
3590         * source-cache.c (source_cache::get_plain_source_lines): Use
3591         open_source_file_with_line_charpos instead of just
3592         open_source_file, remove call to find_source_lines.
3593         (source_cache::get_source_lines): Likewise.
3594         * source.c (find_source_lines): Make static.
3595         (get_filename_and_charpos): Renamed into...
3596         (open_source_file_with_line_charpos): ..this along with changes to
3597         return a scoped_fd, and some other minor clean ups.
3598         (identify_source_line): Use open_source_file_with_line_charpos.
3599         (search_command_helper): Use open_source_file_with_line_charpos
3600         instead of just open_source_file, remove call to
3601         find_source_lines.
3602         * source.h (open_source_file_with_line_charpos): Declare new
3603         function.
3604         (find_source_lines): Delete declaration.
3605
3606 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3607
3608         * source.c (get_filename_and_charpos): Remove fullname
3609         parameter.
3610         (identify_source_line): Update call to get_filename_and_charpos.
3611
3612 2019-06-14  Tom Tromey  <tromey@adacore.com>
3613
3614         PR gdb/24502:
3615         * ui-style.h (skip_ansi_escape): Update comment.
3616         * ui-file.h (class no_terminal_escape_file): New class.
3617         * ui-file.c (no_terminal_escape_file::write)
3618         (no_terminal_escape_file::puts): New methods.
3619         * cli/cli-logging.c (handle_redirections): Use
3620         no_terminal_escape_file.
3621
3622 2019-06-14  Tom Tromey  <tromey@adacore.com>
3623
3624         * NEWS: Move convenience variable news above Python news.
3625
3626 2019-06-14  Tom Tromey  <tom@tromey.com>
3627
3628         * gnulib: Move directory to top-level.
3629         * configure.ac: Don't configure gnulib.
3630         * configure: Rebuild.
3631         * common/common-defs.h: Use new path to gnulib.
3632         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3633         (GNULIB_H): Remove.
3634         (INCGNU): Look in new gnulib location.
3635         (HFILES_NO_SRCDIR): Remove gnulib files.
3636         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3637         (generated_files): Remove GNULIB_H.
3638         ($(LIBGNU), all-lib): Remove targets.
3639         (distclean): Don't mention GNULIB_BUILDDIR.
3640         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3641
3642 2019-06-14  Tom Tromey  <tromey@adacore.com>
3643
3644         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3645         Warn if symbol file does not provide any symbols.
3646
3647 2019-06-14  Tom Tromey  <tromey@adacore.com>
3648
3649         * source.c (find_and_open_source): Respect basenames_may_differ.
3650
3651 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3652
3653         * annotate.c (annotate_breakpoints_invalid): Make use of
3654         scoped_restore_terminal_state.
3655         (annotate_frames_invalid): Likewise.
3656
3657 2019-06-14  Tom Tromey  <tromey@adacore.com>
3658
3659         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3660         allow assignment to an internalvar.
3661
3662 2019-06-14  Tom Tromey  <tromey@adacore.com>
3663
3664         * ada-lex.l: Allow "_" in attribute names.
3665
3666 2019-06-14  Tom Tromey  <tromey@adacore.com>
3667
3668         PR gdb/24653:
3669         * regcache.c (registers_changed): Don't call alloca.
3670         * top.c (execute_command): Don't call alloca.
3671
3672 2019-06-13  Pedro Alves  <palves@redhat.com>
3673
3674         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3675         'expression'.  When parsing an expression, error out if there's
3676         junk after "unlimited".
3677         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3678         (do_set_command): Adjust calls to is_unlimited_literal.
3679
3680 2019-06-13  Pedro Alves  <palves@redhat.com>
3681
3682         * compile/compile.c (make_compile_options_def_group): Add braces
3683         around array_view initializer.
3684         * thread.c (make_thread_apply_all_options_def_group)
3685         (make_thread_apply_all_options_def_group): Likewise.
3686
3687 2019-06-13  Pedro Alves  <palves@redhat.com>
3688
3689         * NEWS (New commands): Mention "maint test-options
3690         require-delimiter", "maint test-options unknown-is-error", "maint
3691         test-options unknown-is-operand" and "maint show
3692         test-options-completion-result".
3693         (New command options, command completion): New section.
3694         (Completion improvements): New section.
3695         Mention that you can abbreviate "unlimited".
3696
3697 2019-06-13  Pedro Alves  <palves@redhat.com>
3698
3699         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3700         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3701         * unittests/cli-utils-selftests.c (test_parse_flags)
3702         (test_parse_flags_qcs): Delete.
3703         (test_cli_utils): Don't call deleted functions.
3704
3705 2019-06-13  Pedro Alves  <palves@redhat.com>
3706
3707         * thread.c: Include "cli/cli-option.h".
3708         (tp_array_compar_ascending): Global.
3709         (tp_array_compar): Delete function.
3710         (tp_array_compar_ascending, tp_array_compar_descending): New
3711         functions.
3712         (ascending_option_def, qcs_flag_option_def)
3713         (thr_qcs_flags_option_defs)
3714         (make_thread_apply_all_options_def_group)
3715         (make_thread_apply_options_def_group): New.
3716         (thread_apply_all_command): Use gdb::option::process_options.
3717         (thread_apply_command_completer)
3718         (thread_apply_all_command_completer): New.
3719         (thread_apply_command): Use gdb::option::process_options.
3720         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3721         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3722         to generate help text of "thread apply".  Adjust "taas"'s help.
3723         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3724         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3725
3726 2019-06-13  Pedro Alves  <palves@redhat.com>
3727
3728         * thread.c (thread_apply_command): Check for invalid TID with
3729         isdigit instead of !isalpha.
3730
3731 2019-06-13  Pedro Alves  <palves@redhat.com>
3732
3733         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3734         (validate_flags_qcs): New.
3735         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3736         (validate_flags_qcs): Declare.
3737         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3738         (make_frame_apply_options_def_group): New.
3739         (frame_apply_command_count): Process options with
3740         gdb::option::process_options.
3741         (frame_apply_completer): New.
3742         (frame_apply_level_completer, frame_apply_all_completer)
3743         (frame_apply_completer): New.
3744         (_initialize_stack): Update help of "frame apply", "frame apply
3745         level", "frame apply all" and "faas" to mention supported options
3746         and install command completers.
3747         * stack.h (frame_apply_all_completer): Declare.
3748         * thread.c: Include "stack.h".
3749         (tfaas_command): Add "--".
3750         (_initialize_thread): Update help "tfaas" to mention supported
3751         options and install command completer.
3752
3753 2019-06-13  Pedro Alves  <palves@redhat.com>
3754
3755         * completer.c (complete_nested_command_line): New.
3756         (gdb_completion_word_break_characters_throw): Add assertion.
3757         * completer.h (complete_nested_command_line): Declare.
3758
3759 2019-06-13  Pedro Alves  <palves@redhat.com>
3760
3761         * stack.c (parse_backtrace_qualifiers): New.
3762         (backtrace_command): Use it.
3763         (backtrace_command_completer): Complete on qualifiers.
3764
3765 2019-06-13  Pedro Alves  <palves@redhat.com>
3766
3767         * frame.c: Include "cli/cli-option.h.
3768         (user_set_backtrace_options): New.
3769         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3770         Delete.
3771         (get_prev_frame): Adjust.
3772         (boolean_option_def, uinteger_option_def)
3773         (set_backtrace_option_defs): New.
3774         (_initialize_frame): Adjust and use
3775         gdb::option::add_setshow_cmds_for_options to install "set
3776         backtrace past-main" and "set backtrace past-entry".
3777         * frame.h: Include "cli/cli-option.h".
3778         (struct frame_print_options): Forward declare.
3779         (print_frame_arguments_all, print_frame_arguments_scalars)
3780         (print_frame_arguments_none): Declare.
3781         (print_entry_values): Delete declaration.
3782         (struct frame_print_options, user_frame_print_options): New.
3783         (struct set_backtrace_options): New.
3784         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3785         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3786         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3787         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3788         (list_args_or_locals): Add frame_print_options parameter.
3789         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3790         * python/py-framefilter.c (enumerate_args): Pass down
3791         USER_FRAME_PRINT_OPTIONS.
3792         * stack.c: Include "cli/cli-option.h".
3793         (print_frame_arguments_all, print_frame_arguments_scalars)
3794         (print_frame_arguments_none): Declare.
3795         (print_raw_frame_arguments, print_entry_values): Delete.
3796         (user_frame_print_options): New.
3797         (boolean_option_def, enum_option_def, frame_print_option_defs):
3798         New.
3799         (struct backtrace_cmd_options): New.
3800         (bt_flag_option_def): New.
3801         (backtrace_command_option_defs): New.
3802         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3803         (print_frame_arg, read_frame_arg, print_frame_args)
3804         (print_frame_info, print_frame): Add frame_print_options parameter
3805         and use it.
3806         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3807         (backtrace_command_1): Add frame_print_options and
3808         backtrace_cmd_options parameters and use them.
3809         (make_backtrace_options_def_group): New.
3810         (backtrace_command): Process command options with
3811         gdb::option::process_options.
3812         (backtrace_command_completer): New.
3813         (_initialize_stack): Extend "backtrace"'s help to mention
3814         supported options.  Install completer for "backtrace".
3815         Install some settings commands with add_setshow_cmds_for_options.
3816
3817 2019-06-13  Pedro Alves  <palves@redhat.com>
3818
3819         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3820         and that "set/show print raw frame-arguments" are now deprecated.
3821
3822         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3823         command.
3824         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3825         * stack.c (_initialize_stack): Install "set/show print
3826         raw-frame-arguments", and deprecate "set/show print raw
3827         frame-arguments".
3828         * valprint.c (_initialize_valprint): Deprecate "set/show print
3829         raw".
3830
3831 2019-06-13  Pedro Alves  <palves@redhat.com>
3832
3833         * compile/compile.c (struct compile_options): New.
3834         (compile_flag_option_def, compile_command_option_defs)
3835         (make_compile_options_def_group): New.
3836         (compile_file_command): Handle options with
3837         gdb::option::process_options.
3838         (compile_file_command_completer): New function.
3839         (compile_code_command): Handle options with
3840         gdb::option::process_options.
3841         (compile_code_command_completer): New function.
3842         (_initialize_compiler): Install completers for "compile code" and
3843         "compile file".  Mention available options in "compile code" and
3844         "compile code"'s help.
3845         * completer.c (advance_to_completion_word): New, factored out from
3846         ...
3847         (advance_to_expression_complete_word_point): ... this.
3848         (advance_to_filename_complete_word_point): New.
3849         * completer.h (advance_to_filename_complete_word_point): New
3850         declaration.
3851
3852 2019-06-13  Pedro Alves  <palves@redhat.com>
3853
3854         * compile/compile.c: Include "cli/cli-option.h".
3855         (compile_print_value): Scope data pointer is now a
3856         value_print_options pointer; adjust.
3857         (compile_print_command): Process options.  Scope data pointer is
3858         now a value_print_options pointer; adjust.
3859         (_initialize_compile): Update "compile print"'s help to include
3860         supported options.  Install a completer for "compile print".
3861         * cp-valprint.c (show_vtblprint, show_objectprint)
3862         (show_static_field_print): Delete.
3863         (_initialize_cp_valprint): Don't install "set print
3864         static-members", "set print vtbl", "set print object" here.
3865         * printcmd.c: Include "cli/cli-option.h" and
3866         "common/gdb_optional.h".
3867         (print_command_parse_format): Rework to fill in a
3868         value_print_options instead of a format_data.
3869         (print_value): Change parameter type from format_data pointer to
3870         value_print_options reference.  Adjust.
3871         (print_command_1): Process options.  Adjust to pass down a
3872         value_print_options.
3873         (print_command_completer): New.
3874         (_initialize_printcmd): Install print_command_completer as
3875         handle_brkchars completer for the "print" command.  Update
3876         "print"'s help to include supported options.
3877         * valprint.c: Include "cli/cli-option.h".
3878         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3879         here from cp-valprint.c.
3880         (boolean_option_def, uinteger_option_def)
3881         (value_print_option_defs, make_value_print_options_def_group):
3882         New.  Use gdb::option::add_setshow_cmds_for_options to install
3883         "set print elements", "set print null-stop", "set print repeats",
3884         "set print pretty", "set print union", "set print array", "set
3885         print address", "set print symbol", "set print array-indexes".
3886         * valprint.h: Include <string> and "cli/cli-option.h".
3887         (make_value_print_options_def_group): Declare.
3888         (print_value): Change parameter type from format_data pointer to
3889         value_print_options reference.
3890         (print_command_completer): Declare.
3891
3892 2019-06-13  Pedro Alves  <palves@redhat.com>
3893
3894         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3895         (COMMON_SFILES): Add maint-test-settings.c.
3896         * cli/cli-decode.c (boolean_enums): New global, factored out from
3897         ...
3898         (add_setshow_boolean_cmd): ... here.
3899         * cli/cli-decode.h (boolean_enums): Declare.
3900         * cli/cli-option.c: New file.
3901         * cli/cli-option.h: New file.
3902         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3903         factored out from ...
3904         (parse_cli_boolean_value(const char *)): ... this.
3905         (is_unlimited_literal): Change parameter type to pointer to
3906         pointer.  Adjust and advance ARG pointer.
3907         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3908         (parse_cli_var_enum): New, factored out from ...
3909         (do_set_command): ... this.  Adjust.
3910         * cli/cli-setshow.h (parse_cli_boolean_value)
3911         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3912         (parse_cli_var_enum): Declare.
3913         * cli/cli-utils.c: Include "cli/cli-option.h".
3914         (get_ulongest): New.
3915         * cli/cli-utils.h (get_ulongest): Declare.
3916         (check_for_argument): New overloads.
3917         * maint-test-options.c: New file.
3918
3919 2019-06-13  Pedro Alves  <palves@redhat.com>
3920
3921         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3922         parse a range if "-" is at the end of the string.
3923
3924 2019-06-13  Pedro Alves  <palves@redhat.com>
3925
3926         * cli/cli-setshow.c (parse_auto_binary_operation)
3927         (parse_cli_boolean_value): Don't allow "o".
3928
3929 2019-06-13  Pedro Alves  <palves@redhat.com>
3930
3931         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3932         * NEWS: Mention maint test-settings KIND.
3933         * maint-test-settings.c: New file.
3934
3935 2019-06-13  Pedro Alves  <palves@redhat.com>
3936
3937         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3938         completer.
3939         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3940         "set" completers.
3941
3942 2019-06-13  Pedro Alves  <palves@redhat.com>
3943
3944         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3945         after item.
3946
3947 2019-06-13  Pedro Alves  <palves@redhat.com>
3948
3949         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3950
3951 2019-06-13  Pedro Alves <palves@redhat.com>
3952
3953         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3954         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3955         call.
3956         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3957         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3958         calls.
3959         (check_for_argument): Skip spaces after argument.
3960
3961 2019-06-13  Pedro Alves  <palves@redhat.com>
3962
3963         * thread.c (thread_apply_command): Adjust TID parsing.
3964         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3965         detected before end of string.
3966         (tid_is_in_list): Error out if LIST is invalid.
3967
3968 2019-06-13  Pedro Alves  <palves@redhat.com>
3969
3970         * completer.c (complete_line_internal_1): Rewind completion word
3971         point.
3972         (completion_tracker::advance_custom_word_point_by): Change
3973         parameter type to int.
3974         * completer.h (completion_tracker::advance_custom_word_point_by):
3975         Likewise.
3976
3977 2019-06-13  Pedro Alves  <palves@redhat.com>
3978
3979         * completer.c (advance_to_completion_word): Handle delimiters.
3980
3981 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3982
3983         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3984
3985 2019-06-11  Tom Tromey  <tom@tromey.com>
3986
3987         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3988         (xmalloc_failed): Move to alloc.c.
3989         * alloc.c: New file.
3990         * Makefile.in (COMMON_SFILES): Add alloc.c.
3991
3992 2019-06-11  Tom Tromey  <tom@tromey.com>
3993
3994         * nat/linux-waitpid.c: Don't include server.h.
3995         (linux_debug): Remove.
3996         (my_waitpid): Update.
3997
3998 2019-06-11  Tom Tromey  <tromey@adacore.com>
3999
4000         * infcall.c (_initialize_infcall): Remove trailing newline from
4001         help.
4002         * user-regs.c (_initialize_user_regs): Remove trailing newline
4003         from help.
4004         * typeprint.c (_initialize_typeprint): Remove trailing newline
4005         from help.
4006         * reverse.c (_initialize_reverse): Remove trailing newlines from
4007         help.
4008         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4009         from help.
4010         * language.c (add_set_language_command): Remove trailing newline
4011         from help.
4012         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4013         help.
4014         * disasm.c (_initialize_disasm): Remove trailing newline from
4015         help.
4016         * top.c (init_main): Remove trailing newline from help.
4017         * interps.c (_initialize_interpreter): Remove trailing newline
4018         from help.
4019         * btrace.c (_initialize_btrace): Remove trailing newlines from
4020         help.
4021         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4022         from help.
4023         * python/python.c (_initialize_python): Remove trailing newline
4024         from help.
4025         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4026         help.
4027         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4028         from help.  Reformat some text.
4029         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4030         from help.
4031         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4032         newline from help.
4033
4034 2019-06-11  Tom Tromey  <tromey@adacore.com>
4035
4036         * darwin-nat.c (darwin_decode_exception_message)
4037         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4038
4039 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4040
4041         * valops.c (value_slice): Check for not allocated or not
4042         associated values.
4043
4044 2019-06-10  Tom de Vries  <tdevries@suse.de>
4045
4046         PR gdb/24618
4047         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4048         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4049         invalid.
4050
4051 2019-06-10  Tom de Vries  <tdevries@suse.de>
4052
4053         PR gdb/24611
4054         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4055         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4056
4057 2019-06-10  Tom de Vries  <tdevries@suse.de>
4058
4059         PR symtab/24545
4060         * symtab.c (struct demangled_name_entry): Add language field.
4061         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4062         static minimal symbol".  Set and use language field.
4063
4064 2019-06-10  Tom Tromey  <tromey@adacore.com>
4065
4066         * ada-lang.c (_initialize_ada_language): Update help text.
4067
4068 2019-06-10  Tom Tromey  <tromey@adacore.com>
4069
4070         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4071         with a newline.
4072         * guile/guile.c (handle_boot_error): Don't end warning with a
4073         newline.
4074         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4075         warning with a newline.
4076         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4077         newline.
4078         (s12z_frame_cache): Likewise.
4079         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4080         a newline.
4081         * solib-svr4.c (disable_probes_interface): Don't end warning with
4082         a newline.
4083         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4084         newline.
4085         * python/python.c (do_finish_initialization): Don't end warning
4086         with a newline.
4087
4088 2019-06-10  Tom Tromey  <tom@tromey.com>
4089
4090         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4091         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4092         gdbpy_enter.
4093
4094 2019-06-10  Tom Tromey  <tromey@adacore.com>
4095
4096         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4097         data.
4098         (elf_new_init): Don't call stabsread_new_init.
4099         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4100         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4101         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4102
4103 2019-06-10  Tom de Vries  <tdevries@suse.de>
4104
4105         PR symtab/16264
4106         PR symtab/24517
4107         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4108
4109 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4110
4111         * source.c (find_and_open_source): Also rewrite relative file
4112         names.
4113
4114 2019-04-26  Amos Bird  <amosbird@gmail.com>
4115
4116         * annotate.c (annotate_thread_exited): Add "thread-exited"
4117         annotation.
4118
4119 2019-06-06  Tom Tromey  <tromey@adacore.com>
4120
4121         * maint.h (class scoped_command_stats): Use
4122         DISABLE_COPY_AND_ASSIGN.
4123         <print_time>: New method.
4124         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4125         print_time.
4126         (scoped_command_stats::print_time): New method.
4127
4128 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4129
4130         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4131         instructions of lengths 6 or 8 bytes.
4132
4133 2019-06-04  Pedro Alves  <palves@redhat.com>
4134
4135         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4136
4137         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4138         * breakpoint.c (condition_completer): Likewise.
4139         * cli/cli-dump.c (scan_expression): Likewise.
4140         * common/filestuff.c (mkdir_recursive): Likewise.
4141         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4142         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4143         (gdb_abspath): Likewise.
4144         * compile/compile-cplus-types.c
4145         (compile_cplus_instance::decl_name): Likewise.
4146         * completer.c (complete_explicit_location):
4147         (signal_completer, reg_or_group_completer_1): Likewise.
4148         * cp-support.c (cp_remove_params_if_any): Likewise.
4149         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4150         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4151         * infcmd.c (strip_bg_char): Likewise.
4152         * linespec.c (copy_token_string): Likewise.
4153         * mi/mi-main.c (output_cores): Likewise.
4154         * psymtab.c (psymtab_search_name):
4155         * symfile.c (test_set_ext_lang_command): Likewise.
4156         * target.c (target_fileio_read_stralloc): Likewise.
4157         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4158         * value.c (complete_internalvar): Likewise.
4159
4160 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4161
4162         Add objfile property to gdb.Type.
4163         * NEWS: Mention Python API addition.
4164         * python/py-type.c (typy_get_objfile): New method.
4165
4166 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4167
4168         * NEWS: Mention the new set|show style [title|highlight].
4169         Mention changes to "show style", "help" and "apropos".
4170
4171 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4172
4173         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4174         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4175         instead of print_help_for_command.
4176         (print_doc_of_command): New function.
4177         (help_list): Add 'apropos -v word' suggestion.
4178         (print_help_for_command): Style the command name using title style.
4179         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4180         (_initialize_cli_cmds): Describe -v in apropos_command help.
4181
4182 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4183
4184         * cli/cli-style.h (cli_style_option): Add name in constructor,
4185         add m_name class member, add constructor with intensity,
4186         add name class function.
4187         (cli_style_option::add_setshow_commands): Remove name argument.
4188         (highlight_style, title_style): New styles.
4189         * cli/cli-style.c (do_show): New function that shows a style
4190         characteristic styling the style name with itself.
4191         (set_style_name): New function.
4192         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4193         Update all callers according to the changes in cli/cli-style.h.
4194         * utils.h (fputs_highlighted): New function.
4195         * utils.c (fputs_highlighted): Likewise.
4196
4197 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4198
4199         * NEWS: Mention new pipe command and new convenience variables.
4200
4201 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4202
4203         * cli/cli-cmds.c (pipe_command): New function.
4204         (_initialize_cli_cmds): Call add_com for pipe_command.
4205         Define | as an alias for pipe.
4206         (exit_status_set_internal_vars): New function.
4207         (shell_escape): Call exit_status_set_internal_vars.
4208         cli/cli-decode.c (find_command_name_length): Recognize | as
4209         a single character command.
4210
4211 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4212
4213         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4214         top.c (execute_command_to_ui_file): New function, mostly a copy
4215         of execute_command_to_string.
4216         (execute_command_to_string): Implement by calling
4217         execute_command_to_ui_file.
4218
4219 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4220
4221         * top.h (saved_command_line): Remove declaration.
4222         * top.c (previous_saved_command_line, previous_repeat_arguments):
4223         New variables.
4224         (saved_command_line): Make static, define together with other
4225         'repeat variables'.
4226         (dont_repeat): Clear repeat_arguments.
4227         (repeat_previous, get_saved_command_line, save_command_line):
4228         New functions.
4229         (gdb_init): Initialize saved_command_line
4230         and previous_saved_command_line.
4231         * main.c (captured_main_1): Remove saved_command_line initialization.
4232         * event-top.c (handle_line_of_input): Update to use
4233         the new 'repeat' related functions instead of direct access to
4234         saved_command_line.
4235         * command.h (repeat_previous, get_saved_command_line,
4236         save_command_line): New declarations.
4237         (dont_repeat): Add comment.
4238
4239 2019-05-30  Tom Tromey  <tromey@adacore.com>
4240
4241         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4242         Fix comment.
4243         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4244
4245 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4246
4247         PR cli/24587
4248         * completer.c (complete): Initialize variable word.
4249
4250 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4251
4252         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4253         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4254         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4255         'body' is NULL to the outter 'if', protecting the '!is_define'
4256         situation as well.
4257
4258 2019-05-29  Tom Tromey  <tromey@adacore.com>
4259
4260         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4261         (dwarf_unknown): New function.
4262         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4263         (dwarf_type_encoding_name): Use dwarf_unknown.
4264
4265 2019-05-29  Tom Tromey  <tromey@adacore.com>
4266
4267         PR c++/20020:
4268         * cp-valprint.c (cp_print_value_fields): Call
4269         cp_print_static_field inside "try".
4270
4271 2019-05-29  Tom Tromey  <tromey@adacore.com>
4272
4273         * inflow.c (struct terminal_info): Add default operator=.
4274         * configure: Rebuild.
4275         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4276         -Wdeprecated-copy-dtor, -Wredundant-move.
4277
4278 2019-05-29  Tom Tromey  <tromey@adacore.com>
4279
4280         * NEWS: Add entry.
4281         * infcmd.c (print_return_value_1): Handle finish_print
4282         option.
4283         (show_print_finish): New function.
4284         (_initialize_infcmd): Add "set/show print finish" commands.
4285         * valprint.c (user_print_options): Initialize new member.
4286         * valprint.h (struct value_print_options) <finish_print>: New
4287         member.
4288
4289 2019-05-28  Tom Tromey  <tromey@adacore.com>
4290
4291         * ada-lang.c (ada_remove_Xbn_suffix)
4292         (find_old_style_renaming_symbol)
4293         (parse_old_style_renaming): Remove.
4294         (ada_find_renaming_symbol): Don't call
4295         find_old_style_renaming_symbol.
4296         (ada_is_renaming_symbol): Rename from
4297         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4298         bool.  Now static.
4299         (ada_read_var_value): Update and simplify.
4300         * ada-exp.y (write_var_or_type): Remove old code.
4301
4302 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4303
4304         * event-top.c: Remove include comment.
4305         * inflow.c (class scoped_ignore_sigttou): Move from here...
4306         * inflow.h (class scoped_ignore_sigttou): ...to here.
4307         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4308         * top.c:  Remove include comment.
4309
4310 2019-05-27  Tom Tromey  <tom@tromey.com>
4311
4312         * NEWS: Fix typo.
4313
4314 2019-05-22  Tom Tromey  <tromey@adacore.com>
4315
4316         * target.c (target_follow_exec): Constify parameter.
4317         * target-delegates.c: Rebuild.
4318         * remote.c (remote_target::follow_exec): Constify parameter.
4319         * infrun.c (follow_exec): Constify parameter.
4320         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4321         (target_follow_exec): Likewise.
4322
4323 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4324
4325         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4326         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4327
4328 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4329
4330         * NEWS: Add debugredirect and testsuite sections.
4331
4332 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4333
4334         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4335         target descriptions using exclusively floating point register name
4336         aliases.
4337
4338 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4339
4340         PR gdb/18644:
4341         * f-lang.c (build_fortran_types): Handle the case where
4342         gdbarch_floatformat_for_type returns a nullptr.
4343
4344 2019-05-21  Tom de Vries  <tdevries@suse.de>
4345
4346         PR cli/24587
4347         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4348
4349 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4350
4351         PR gdb/18644:
4352         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4353         16-byte floats.
4354         * i386-tdep.c (i386_floatformat_for_type): Use
4355         floatformats_ia64_quad for the 16-byte floating point component
4356         within a fortran 32-byte complex number.
4357
4358 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4359
4360         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4361         delete default constructor.
4362         (find_partial_die): Update to return const struct.
4363         (partial_die_parent_scope): Move variable declaration into scope
4364         of its use and change its type to auto.
4365         (guess_partial_die_structure_name): Likewise.
4366         (partial_die_info::fixup): Likewise.
4367
4368 2019-05-17  Tom Tromey  <tromey@adacore.com>
4369
4370         * source.c (find_and_open_source): Remove cast.
4371
4372 2019-05-17  Tom Tromey  <tromey@adacore.com>
4373
4374         * annotate.c (annotate_source): Make "filename" const.
4375         * annotate.h (annotate_source): Use const.
4376
4377 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4378
4379         * disasm.c (set_disassembler_options): Send errors to stderr.
4380
4381 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4382
4383         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4384         (cli_interp_base::set_logging): Check debug_redirect.
4385         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4386         * cli/cli-logging.c (debug_redirect): Add static variable.
4387         (pop_output_files): Add default param.
4388         (handle_redirections): Print debug setting.
4389         (show_logging_command): Likewise.
4390         (_initialize_cli_logging): Add debugredirect command.
4391         * interps.c (current_interp_set_logging): Add debug_redirect
4392         parameter.
4393         * interps.h (set_logging): Add debug_redirect parameter.
4394         (current_interp_set_logging): Likewise.
4395         * mi/mi-common.h: Likewise.
4396         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4397
4398 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4399             Tom Tromey  <tromey@adacore.com>
4400
4401         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4402         directly.
4403         * cli/cli-interp.h (make_logging_output): Remove declaration.
4404         * cli/cli-logging.c (make_logging_output): Remove function.
4405         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4406         directly.
4407         * ui-file.c (tee_file::tee_file): Remove bools.
4408         (tee_file::~tee_file): Remove deletes.
4409         * ui-file.h (tee_file): Remove bools.
4410
4411 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4412
4413         * mi/mi-cmds.h (mi_cmd_complete): New function.
4414         * mi/mi-main.c (mi_cmd_complete): Likewise.
4415         * mi/mi-cmds.c: Define new MI command -complete.
4416         * NEWS: Mention new -complete command.
4417
4418 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4419
4420         * completer.h (complete): New function.
4421         * completer.c (complete): Likewise.
4422         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4423         function defined in completer.h.
4424
4425 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4426
4427         * MAINTAINERS (Write After Approval): Add myself.
4428
4429 2019-05-17  Tom de Vries  <tdevries@suse.de>
4430
4431         PR gdb/24094
4432         * dwarf2read.c (struct cu_partial_die_info): New struct.
4433         (find_partial_die): Return cu_partial_die_info.
4434         (partial_die_parent_scope, guess_partial_die_structure_name)
4435         (partial_die_info::fixup): Handle new return type of find_partial_die.
4436
4437 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4438
4439         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4440         "std::string", simplifying the algorithm.
4441
4442 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4443
4444         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4445         (stap_static_probe_ops::get_probes): Likewise.
4446
4447 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4448
4449         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4450         '-')" and "else if".
4451         (stap_parse_single_operand): Join checks for
4452         "gdbarch_stap_parse_special_token_p" and
4453         "gdbarch_stap_parse_special_token" in the same "if" statement.
4454         Invert check when verifying for operation on register
4455         displacement.
4456
4457 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4458
4459         * stap-probe.c (stap_get_opcode): Update comment.
4460         (stap_get_expected_argument_type): Likewise.
4461         (handle_stap_probe): Likewise.
4462
4463 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4464
4465         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4466         return type to 'bool'.  Adjust comment.  Use 'bool' when
4467         appropriate.
4468         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4469         * stap-probe.c (stap_parse_argument_1): Likewise.
4470         (stap_is_operator): Likewise.
4471         (stap_is_generic_prefix): Likewise.
4472         (stap_is_register_prefix): Likewise.
4473         (stap_is_register_indirection_prefix): Likewise.
4474         (stap_is_integer_prefix): Likewise.
4475         (stap_generic_check_suffix): Likewise.
4476         (stap_check_integer_suffix): Likewise.
4477         (stap_check_register_suffix): Likewise.
4478         (stap_check_register_indirection_suffix): Likewise.
4479         (stap_parse_register_operand): Likewise.
4480         (stap_parse_single_operand): Likewise.
4481         (stap_parse_argument_1): Likewise.
4482         (stap_probe::get_argument_count): Likewise.
4483         (stap_is_operator): Likewise.
4484
4485 2019-05-16  Tom Tromey  <tromey@adacore.com>
4486
4487         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4488         keyword to foreach.
4489
4490 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4491
4492         * linux-thread-db.c (try_thread_db_load_1): Change return type
4493         to bool.
4494         (try_thread_db_load): Likewise.
4495         (try_thread_db_load_from_pdir_1): Likewise.
4496         (try_thread_db_load_from_pdir): Likewise.
4497         (try_thread_db_load_from_sdir): Likewise.
4498         (try_thread_db_load_from_dir): Likewise.
4499         (thread_db_load_search): Likewise.
4500         (has_libpthread): Likewise.
4501         (thread_db_load): Likewise.
4502
4503 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4504
4505         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4506         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4507         NULL, and complain/return if that's the case.
4508
4509 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4510
4511         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4512         (advance, posn, abstract_read_memory): New functions.
4513         [struct mem_read_abstraction]: New struct.
4514         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4515
4516 2019-05-14  Tom Tromey  <tromey@adacore.com>
4517
4518         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4519         value is not lval_memory.
4520
4521 2019-05-14  Tom Tromey  <tromey@adacore.com>
4522
4523         * solib.c (info_sharedlibrary_command): Style the file name.
4524
4525 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4526
4527         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4528         (aarch64_vnv_type): Likewise.
4529         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4530         * common/tdesc.c: Likewise.
4531         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4532         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4533         * features/aarch64-fpu.xml: Add ieee half view.
4534         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4535         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4536         * gdbtypes.h (struct builtin_type): Likewise.
4537         (struct objfile_type): Likewise.
4538
4539 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4540
4541         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4542         typo.
4543         * location.h (string_to_event_location): Likewise.
4544
4545 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4546
4547         GDB 8.3 released.
4548
4549 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4550
4551         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4552         New variable declaration.
4553         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4554         New variable.
4555         (print_one_breakpoint): Use ui_out::test_flags and new global
4556         variable to compute use_fixed_output.
4557         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4558         Remove.
4559         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4560         (mi_multi_location_breakpoint_output_fixed): Remove.
4561         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4562         new variable.
4563         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4564         fix_multi_location_breakpoint_output flag if version >= 3.
4565         * ui-out.h (enum ui_out_flag)
4566         <fix_multi_location_breakpoint_output>: New enumerator.
4567
4568 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4569
4570         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4571
4572 2019-05-10  Tom Tromey  <tromey@adacore.com>
4573
4574         * ada-lang.c (catch_ada_completer): New function.
4575         (_initialize_ada_language): Use it.
4576
4577 2019-05-10  Tom Tromey  <tromey@adacore.com>
4578
4579         * thread.c (print_thread_info): Make "requested_threads" const.
4580         * gdbthread.h (print_thread_info): Make "requested_threads"
4581         const.
4582         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4583         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4584
4585 2019-05-08  Tom Tromey  <tom@tromey.com>
4586
4587         * gdbtypes.c (objfile_type_data): Change type.
4588         (objfile_type, _initialize_gdbtypes): Update.
4589
4590 2019-05-08  Tom Tromey  <tom@tromey.com>
4591
4592         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4593         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4594         (_initialize_dwarf2_frame): Update.
4595
4596 2019-05-08  Tom Tromey  <tom@tromey.com>
4597
4598         * objc-lang.c (objc_objfile_data): Change type.
4599         (find_methods): Update.
4600         (_initialize_objc_lang): Remove.
4601
4602 2019-05-08  Tom Tromey  <tom@tromey.com>
4603
4604         * stabsread.c (rs6000_builtin_type_data): Change type.
4605         (rs6000_builtin_type, _initialize_stabsread): Update.
4606
4607 2019-05-08  Tom Tromey  <tom@tromey.com>
4608
4609         * mips-tdep.c (mips_pdr_data): Remove.
4610         (_initialize_mips_tdep): Update.
4611
4612 2019-05-08  Tom Tromey  <tom@tromey.com>
4613
4614         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4615         (hppa_init_objfile_priv_data, read_unwind_info)
4616         (find_unwind_entry, _initialize_hppa_tdep): Update.
4617
4618 2019-05-08  Tom Tromey  <tom@tromey.com>
4619
4620         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4621         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4622         on obstack.
4623         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4624
4625 2019-05-08  Tom Tromey  <tom@tromey.com>
4626
4627         * mdebugread.c (basic_type_data): Change type.
4628         (basic_type, _initialize_mdebugread): Update.
4629
4630 2019-05-08  Tom Tromey  <tom@tromey.com>
4631
4632         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4633
4634 2019-05-08  Tom Tromey  <tom@tromey.com>
4635
4636         * nto-tdep.c (nto_inferior_data_reg): Change type.
4637         (nto_inferior_data): Update.
4638         (nto_inferior_data_cleanup, nto_new_inferior_data)
4639         (_initialize_nto_tdep): Remove.
4640         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4641
4642 2019-05-08  Tom Tromey  <tom@tromey.com>
4643
4644         * ada-lang.c (struct ada_inferior_data): Add initializers.
4645         (ada_inferior_data): Change type.
4646         (ada_inferior_data_cleanup): Remove.
4647         (get_ada_inferior_data, ada_inferior_exit)
4648         (struct ada_pspace_data): Add initializers, destructor.
4649         (ada_pspace_data_handle): Change type.
4650         (get_ada_pspace_data): Update.
4651         (ada_pspace_data_cleanup): Remove.
4652
4653 2019-05-08  Tom Tromey  <tom@tromey.com>
4654
4655         * coffread.c (struct coff_symfile_info): Add initializers.
4656         (coff_objfile_data_key): Move lower.  Change type.
4657         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4658         Update.
4659         (coff_free_info): Remove.
4660
4661 2019-05-08  Tom Tromey  <tom@tromey.com>
4662
4663         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4664         (fbsd_pspace_data_handle): Move lower.  Change type.
4665         (get_fbsd_pspace_data): Update.
4666         (fbsd_pspace_data_cleanup): Remove.
4667         (_initialize_fbsd_tdep): Update.
4668
4669 2019-05-08  Tom Tromey  <tom@tromey.com>
4670
4671         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4672         (get_ada_tasks_pspace_data): Update.
4673         (ada_tasks_pspace_data_cleanup): Remove.
4674         (_initialize_tasks): Update.
4675         (ada_tasks_inferior_data_handle): Change type.
4676         (get_ada_tasks_inferior_data): Update.
4677         (ada_tasks_inferior_data_cleanup): Remove.
4678         (struct ada_tasks_pspace_data): Add initializers.
4679
4680 2019-05-08  Tom Tromey  <tom@tromey.com>
4681
4682         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4683         * symfile-debug.c (debug_sym_get_probes): Change type.
4684         * stap-probe.c (handle_stap_probe):
4685         (stap_static_probe_ops::get_probes): Change type.
4686         * probe.h (class static_probe_ops) <get_probes>: Change type.
4687         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4688         (parse_probes_in_pspace): Update.
4689         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4690         Update.
4691         (any_static_probe_ops::get_probes): Change type.
4692         * elfread.c (elfread_data): New typedef.
4693         (probe_key): Change type.
4694         (elf_get_probes): Likewise.  Update.
4695         (probe_key_free): Remove.
4696         (_initialize_elfread): Update.
4697         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4698         Change type.
4699         (dtrace_process_dof_probe, dtrace_process_dof)
4700         (dtrace_static_probe_ops::get_probe): Change type.
4701
4702 2019-05-08  Tom Tromey  <tom@tromey.com>
4703
4704         * xcoffread.c (struct xcoff_symfile_info): Rename from
4705         coff_symfile_info.  Add initializers.
4706         (xcoff_objfile_data_key): Move lower.  Change type.
4707         (XCOFF_DATA): Rewrite.
4708         (xcoff_free_info): Remove.
4709         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4710         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4711         (xcoff_initial_scan): Update.
4712
4713 2019-05-08  Tom Tromey  <tom@tromey.com>
4714
4715         * solib-svr4.c (struct svr4_info): Add initializers and
4716         destructor.
4717         <probes_table>: Now an htab_up.
4718         (solib_svr4_pspace_data): Change type.
4719         (free_probes_table): Simplify.
4720         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4721         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4722         (probes_table_remove_objfile_probes, register_solib_event_probe)
4723         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4724         (_initialize_svr4_solib): Update.
4725
4726 2019-05-08  Tom Tromey  <tom@tromey.com>
4727
4728         * remote.c (remote_pspace_data): Change type.
4729         (remote_pspace_data_cleanup): Remove.
4730         (get_remote_exec_file, set_pspace_remote_exec_file)
4731         (_initialize_remote): Update.
4732
4733 2019-05-08  Tom Tromey  <tom@tromey.com>
4734
4735         * breakpoint.c (breakpoint_objfile_key): Change type.
4736         (get_breakpoint_objfile_data): Update.
4737         (free_breakpoint_objfile_data): Remove.
4738         (_initialize_breakpoint): Update.
4739
4740 2019-05-08  Tom Tromey  <tom@tromey.com>
4741
4742         * linux-tdep.c (struct linux_info): Add initializers.
4743         (linux_inferior_data): Move.  Change type.
4744         (invalidate_linux_cache_inf): Update.
4745         (linux_inferior_data_cleanup): Remove.
4746         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4747
4748 2019-05-08  Tom Tromey  <tom@tromey.com>
4749
4750         * auxv.c (auxv_inferior_data): Move.  Change type.
4751         (auxv_inferior_data_cleanup): Remove.
4752         (invalidate_auxv_cache_inf): Rewrite.
4753         (get_auxv_inferior_data, _initialize_auxv): Update.
4754
4755 2019-05-08  Tom Tromey  <tom@tromey.com>
4756
4757         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4758         (symfile_debug_objfile_data_key): Change type.
4759         (symfile_debug_installed, debug_qf_has_symbols)
4760         (debug_qf_find_last_source_symtab)
4761         (debug_qf_forget_cached_source_info)
4762         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4763         (debug_qf_print_stats, debug_qf_dump)
4764         (debug_qf_expand_symtabs_for_function)
4765         (debug_qf_expand_all_symtabs)
4766         (debug_qf_expand_symtabs_with_fullname)
4767         (debug_qf_map_matching_symbols)
4768         (debug_qf_expand_symtabs_matching)
4769         (debug_qf_find_pc_sect_compunit_symtab)
4770         (debug_qf_map_symbol_filenames)
4771         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4772         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4773         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4774         (debug_sym_read_linetable, debug_sym_relocate): Update.
4775         (symfile_debug_free_objfile): Remove.
4776         (install_symfile_debug_logging, _initialize_symfile_debug):
4777         Update.
4778
4779 2019-05-08  Tom Tromey  <tom@tromey.com>
4780
4781         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4782         allocate_on_obstack.
4783         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4784         (get_dwarf2_per_objfile): Update.
4785         (set_dwarf2_per_objfile): Remove.
4786         (dwarf2_has_info, dwarf2_get_section_info): Update.
4787         (dwarf2_free_objfile): Remove.
4788         (_initialize_dwarf2_read): Update.
4789
4790 2019-05-08  Tom Tromey  <tom@tromey.com>
4791
4792         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4793         initializers.
4794         <unsupported_script_warning_printed,
4795         script_not_found_warning_printed>: Now bool.
4796         (auto_load_pspace_data): Change type.
4797         (~auto_load_pspace_info): Rename from
4798         auto_load_pspace_data_cleanup.
4799         (get_auto_load_pspace_data, init_loaded_scripts_info)
4800         (clear_section_scripts, maybe_print_unsupported_script_warning)
4801         (maybe_print_script_not_found_warning, _initialize_auto_load):
4802         Update.
4803
4804 2019-05-08  Tom Tromey  <tom@tromey.com>
4805
4806         * objfiles.c (objfile_pspace_info): Add destructor and
4807         initializers.
4808         (objfiles_pspace_data): Change type.
4809         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4810         (get_objfile_pspace_data): Update.
4811         (objfiles_bfd_data): Change type.
4812         (get_objfile_bfd_data): Update.
4813         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4814
4815 2019-05-08  Tom Tromey  <tom@tromey.com>
4816
4817         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4818         Change type.
4819         (get_catch_syscall_inferior_data): Update.
4820         (catch_syscall_inferior_data_cleanup): Remove.
4821         (_initialize_break_catch_syscall): Update.
4822
4823 2019-05-08  Tom Tromey  <tom@tromey.com>
4824
4825         * inflow.c (struct terminal_info): Add destructor and
4826         initializers.
4827         (inflow_inferior_data): Change type.
4828         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4829         (get_inflow_inferior_data, inflow_inferior_exit)
4830         (swap_terminal_info, _initialize_inflow): Update.
4831
4832 2019-05-08  Tom Tromey  <tom@tromey.com>
4833
4834         * target-dcache.c (target_dcache_cleanup): Remove.
4835         (target_dcache_aspace_key): Change type.
4836         (target_dcache_init_p, target_dcache_invalidate)
4837         (target_dcache_get, target_dcache_get_or_init)
4838         (_initialize_target_dcache): Update.
4839         * dcache.h (struct dcache_deleter): New.
4840
4841 2019-05-08  Tom Tromey  <tom@tromey.com>
4842
4843         * symtab.c (struct symbol_cache): Add destructor and
4844         initializers.
4845         (symbol_cache_key): Move.  Change type.
4846         (make_symbol_cache, free_symbol_cache): Remove.
4847         (get_symbol_cache): Update.
4848         (symbol_cache_cleanup): Remove.
4849         (ALL_PSPACES, symbol_cache_flush)
4850         (maintenance_print_symbol_cache)
4851         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4852         Update.
4853
4854 2019-05-08  Tom Tromey  <tom@tromey.com>
4855
4856         * symtab.c (struct main_info): Add destructor and initializers.
4857         (main_progspace_key): Move.  Change type.
4858         (get_main_info): Update.
4859         (main_info_cleanup): Remove.
4860         (_initialize_symtab): Update.
4861
4862 2019-05-08  Tom Tromey  <tom@tromey.com>
4863
4864         * registry.h (DECLARE_REGISTRY): Define the _key class.
4865
4866 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4867
4868         * NEWS: Merge two 'New commands' sections.
4869
4870 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4871
4872         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4873         parameter and use Ada language definition instead.
4874         (ada_val_print_ptr): Remove unused language parameter.
4875         (ada_val_print_num): Remove language parameter and use Ada language
4876         definition instead.
4877         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4878         parameter.
4879         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4880         parameter and use Ada language definition instead.
4881         (ada_val_print_1): Update all ada_val_print_xxx calls.
4882         Remove language parameter.
4883         (ada_val_print): Update ada_val_print_1 call.
4884
4885 2019-05-08  Tom Tromey  <tromey@adacore.com>
4886
4887         * remote.c (remote_hw_watchpoint_limit)
4888         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4889         Now static.
4890
4891 2019-05-08  Tom Tromey  <tromey@adacore.com>
4892
4893         * maint.c (_initialize_maint_cmds): Move initialization code to
4894         remote.c.
4895         (watchdog, show_watchdog): Move to remote.c.
4896         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4897         "watchdog" static.
4898         (_initialize_remote): Move initialization code from maint.c.
4899         * defs.h (watchdog): Don't declare.
4900
4901 2019-05-08  Tom Tromey  <tromey@adacore.com>
4902
4903         * tui/tui-interp.c: Include main.h.
4904         * interps.c: Include main.h.
4905         * main.h (interpreter_p): Declare.
4906         * defs.h (interpreter_p): Don't declare.
4907
4908 2019-05-08  Tom Tromey  <tromey@adacore.com>
4909
4910         * dwarf2loc.c: Include dwarf2read.h.
4911         * defs.h (read_unsigned_leb128): Don't declare.
4912         * dwarf2read.h (read_unsigned_leb128): Declare.
4913
4914 2019-05-08  Tom Tromey  <tromey@adacore.com>
4915
4916         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4917         method.
4918
4919 2019-05-08  Tom Tromey  <tromey@adacore.com>
4920
4921         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4922         when no wrap column is set.
4923
4924 2019-05-08  Tom Tromey  <tromey@adacore.com>
4925
4926         * c-lang.c (c_get_string): Handle non-C-style arrays.
4927
4928 2019-05-08  Tom Tromey  <tromey@adacore.com>
4929
4930         * typeprint.c (print_offset_data::update): Print the bit offset,
4931         not the number of bits remaining.
4932
4933 2019-05-08  Tom Tromey  <tromey@adacore.com>
4934
4935         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4936         padding at end of comment.
4937
4938 2019-05-08  Tom Tromey  <tromey@adacore.com>
4939
4940         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4941         Compare main types.
4942
4943 2019-05-06  Tom Tromey  <tom@tromey.com>
4944
4945         * common/scoped_mmap.c: Include common-defs.h.
4946         * common/scoped_mmap.h: Don't include config.h.
4947
4948 2019-05-04  Tom Tromey  <tom@tromey.com>
4949
4950         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4951         (struct aarch64_call_info): Add initializers.
4952         <si>: Now a std::vector.
4953         (pass_on_stack, aarch64_push_dummy_call): Update.
4954
4955 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4956             Tom Tromey  <tom@tromey.com>
4957
4958         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4959         (ppc_threads): Now a std::vector.  Now static.
4960         (hwdebug_find_thread_points_by_tid)
4961         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4962         Update.
4963
4964 2019-05-04  Tom Tromey  <tom@tromey.com>
4965
4966         * arc-tdep.c (arc_tdesc_init): Return bool.
4967
4968 2019-05-04  Tom Tromey  <tom@tromey.com>
4969
4970         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4971         Use gdb_assert_not_reached.
4972
4973 2019-05-04  Tom Tromey  <tom@tromey.com>
4974
4975         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4976         "false".
4977
4978 2019-05-04  Tom Tromey  <tom@tromey.com>
4979
4980         * arc-tdep.c (arc_tdesc_init): Use bool.
4981
4982 2019-05-04  Tom Tromey  <tom@tromey.com>
4983
4984         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4985
4986 2019-05-04  Tom Tromey  <tom@tromey.com>
4987
4988         * cli/cli-cmds.c (valid_command_p): Return bool.
4989
4990 2019-05-04  Tom Tromey  <tom@tromey.com>
4991
4992         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4993         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4994
4995 2019-05-04  Raul Tambre  <raul@tambre.ee>
4996
4997         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4998         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4999         operator for comparison.
5000
5001 2019-05-04  Tom Tromey  <tom@tromey.com>
5002
5003         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5004         (lookup_partial_symbol, print_partial_symbols)
5005         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5006         (psymbol_compare): Update.
5007         (add_psymbol_to_bcache): Clear the entire psymbol.
5008         (maintenance_check_psymtabs): Update.
5009         * psympriv.h (struct partial_symbol): Don't derive from
5010         general_symbol_info.
5011         <obj_section, unrelocated_address, address,
5012         set_unrelocated_address>: Update.
5013         <ginfo>: New member.
5014         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5015         (debug_names::write_psymbols): Update.
5016
5017 2019-05-04  Tom de Vries  <tdevries@suse.de>
5018
5019         * contrib/cc-with-tweaks.sh: Support -n arg.
5020
5021 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5022
5023         * corelow.c (core_target::detach): Ensure frame cache and
5024         register caches are cleared.
5025         inferior.c (exit_inferior_1): Likewise.
5026
5027 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5028             Tom Tromey  <tom@tromey.com>
5029
5030         * dictionary.c (collate_pending_symbols_by_language): Remove
5031         "struct" from foreach.
5032         * symtab.c (lookup_global_symbol_from_objfile)
5033         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5034         foreach.
5035         * ser-tcp.c (net_open): Remove "struct" from foreach.
5036         * objfiles.c (objfile_relocate, objfile_rebase)
5037         (objfile_has_symbols): Remove "struct" from foreach.
5038         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5039         from foreach.
5040         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5041         foreach.
5042         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5043         "struct" from foreach.
5044         * ada-lang.c (create_excep_cond_exprs)
5045         (ada_exception_catchpoint_cond_string): Remove "struct" from
5046         foreach.
5047
5048 2019-05-03  Tom Tromey  <tromey@adacore.com>
5049
5050         * ada-exp.y (convert_char_literal): Check suffix of each
5051         enumerator.
5052
5053 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5054
5055         PR ada/21406:
5056         * ada-exp.y (yywrap): Don't define.
5057         * ada-lex.l (%option): Add noyywrap
5058         (yywrap): Remove.
5059
5060 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5061
5062         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5063         _WIN32_WINNT to the XP level, unless already defined to a higher
5064         level.
5065
5066         * unittests/parse-connection-spec-selftests.c:
5067         * ser-tcp.c:
5068         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5069         override.
5070
5071         * symfile.c (find_separate_debug_file): Remove colon from the
5072         drive spec of DOS/Windows file names of the target, so that the
5073         file name produced from DEBUGDIR and the target's directory will
5074         be valid on DOS/Windows systems.
5075
5076 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5077
5078         * rust-lang.c (val_print_struct): Handle printing structures
5079         containing strings.
5080
5081 2019-05-02  Tom Tromey  <tromey@adacore.com>
5082
5083         * valarith.c (_initialize_valarith): Remove.
5084
5085 2019-05-01  Tom Tromey  <tromey@adacore.com>
5086
5087         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5088         bitfields.
5089
5090 2019-05-01  Tom Tromey  <tromey@adacore.com>
5091
5092         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5093         for big-endian copies.
5094
5095 2019-04-30  Ali Tamur  <tamur@google.com>
5096         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5097         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5098         (read_3_bytes): New function.
5099
5100 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5101
5102         * windows-nat.c (main_thread_id): Delete.
5103         (handle_output_debug_string): Replace main_thread_id by
5104         current_event.dwThreadId.
5105         (fake_create_process): Likewise.
5106         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5107         Do not set main_thread_id.
5108         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5109         current_event.dwThreadId.
5110         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5111
5112 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5113
5114         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5115         Use current_event.dwThreadId instead of main_thread_id.
5116
5117 2019-04-30  Tom Tromey  <tromey@adacore.com>
5118
5119         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5120         (create_excep_cond_exprs): Iterate over program spaces.
5121         (ada_exception_catchpoint_cond_string): Examine all minimal
5122         symbols for exception types.
5123
5124 2019-04-30  Tom Tromey  <tromey@adacore.com>
5125
5126         PR c++/24470:
5127         * dwarf2read.c (process_structure_scope): Handle case where type
5128         has template parameters but no symbol was created.
5129
5130 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5131             Chris January  <chris.january@arm.com>
5132
5133         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5134         qualifier.
5135         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5136
5137 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5138
5139         * f-typeprint.c (f_print_type): Update rules for printing
5140         whitespace.
5141         (f_type_print_varspec_suffix): Likewise.
5142
5143 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5144             Chris January  <chris.january@arm.com>
5145
5146         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5147         function arguments.
5148
5149 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5150
5151         * f-lang.c (build_fortran_types): Change name of void type to
5152         lower case.
5153         * f-typeprint.c (f_type_print_base): Print the name of the void
5154         type, rather than a fixed string.
5155         * f-valprint.c (f_decorations): Use lower case void string.
5156
5157 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5158             Chris January  <chris.january@arm.com>
5159
5160         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5161         types for Fortran.
5162
5163 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5164             Chris January  <chris.january@arm.com>
5165             David Lecomber  <david.lecomber@arm.com>
5166
5167         * f-exp.y (BINOP_INTRINSIC): New token.
5168         (exp): New parser rule handling BINOP_INTRINSIC.
5169         (f77_keywords): Add new builtin procedures.
5170         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5171         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5172         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5173         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5174         (print_unop_subexp_f): New function.
5175         (print_binop_subexp_f): New function.
5176         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5177         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5178         (dump_subexp_body_f): Likewise.
5179         (operator_check_f): Likewise.
5180         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5181         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5182
5183 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5184
5185         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5186         UNOP_KIND.
5187         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5188         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5189         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5190         (operator_length_f): New fuction.
5191         (print_subexp_f): New function.
5192         (op_name_f): New function.
5193         (dump_subexp_body_f): New function.
5194         (operator_check_f): New function.
5195         (exp_descriptor_f): Replace standard expression handling functions
5196         with new functions.
5197         * gdb/fortran-operator.def: New file.
5198         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5199         * gdb/std-operator.def: Remove UNOP_KIND.
5200
5201 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5202
5203         * std-operator.def: Remove unbalanced, stray double quote
5204         character.
5205
5206 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5207             Chris January  <chris.january@arm.com>
5208             Daniel Everett  <daniel.everett@arm.com>
5209             Nick Forrington  <nick.forrington@arm.com>
5210             Richard Bunt  <richard.bunt@arm.com>
5211
5212         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5213         of depth when printing anonymous structs or unions.
5214         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5215         Don't print either the top-level value, or the children if the
5216         max-depth is exceeded.
5217         (ppscm_print_children): When printing the key of a map, allow one
5218         extra level of depth.
5219         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5220         print either the top-level value, or the children if the max-depth
5221         is exceeded.
5222         (print_children): When printing the key of a map, allow one extra
5223         level of depth.
5224         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5225         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5226         (user_print_options): Initialise max_depth field.
5227         (val_print_scalar_or_string_type_p): New function.
5228         (val_print): Check to see if the max depth has been reached.
5229         (val_print_check_max_depth): Define new function.
5230         (show_print_max_depth): New function.
5231         (_initialize_valprint): Add 'print max-depth' option.
5232         * valprint.h (struct value_print_options) <max_depth>: New field.
5233         (val_print_check_max_depth): Declare new function.
5234         * NEWS: Document new feature.
5235
5236 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5237
5238         * ada-lang.c (ada_language_defn): Initialise new field.
5239         * c-lang.c (c_is_string_type_p): New function.
5240         (c_language_defn): Initialise new field.
5241         (cplus_language_defn): Initialise new field.
5242         (asm_language_defn): Initialise new field.
5243         (minimal_language_defn): Initialise new field.
5244         * c-lang.h (c_is_string_type_p): Declare new function.
5245         * d-lang.c (d_language_defn): Initialise new field.
5246         * f-lang.c (f_is_string_type_p): New function.
5247         (f_language_defn): Initialise new field.
5248         * go-lang.c (go_is_string_type_p): New function.
5249         (go_language_defn): Initialise new field.
5250         * language.c (default_is_string_type_p): New function.
5251         (unknown_language_defn): Initialise new field.
5252         (auto_language_defn): Initialise new field.
5253         * language.h (struct language_defn) <la_is_string_type_p>: New
5254         member variable.
5255         (default_is_string_type_p): Declare new function.
5256         * m2-lang.c (m2_language_defn): Initialise new field.
5257         * objc-lang.c (objc_language_defn): Initialise new field.
5258         * opencl-lang.c (opencl_language_defn): Initialise new field.
5259         * p-lang.c (pascal_is_string_type_p): New function.
5260         (pascal_language_defn): Initialise new field.
5261         * rust-lang.c (rust_is_string_type_p): New function.
5262         (rust_language_defn): Initialise new field.
5263
5264 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5265
5266         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5267         New field.
5268         * ada-lang.c (ada_language_defn): Initialise new field.
5269         * c-lang.c (c_language_defn): Likewise.
5270         (cplus_language_defn): Likewise.
5271         (asm_language_defn): Likewise.
5272         (minimal_language_defn): Likewise.
5273         * d-lang.c (d_language_defn): Likewise.
5274         * f-lang.c (f_language_defn): Likewise.
5275         * go-lang.c (go_language_defn): Likewise.
5276         * language.c (unknown_language_defn): Likewise.
5277         (auto_language_defn): Likewise.
5278         * m2-lang.c (m2_language_defn): Likewise.
5279         * objc-lang.c (objc_language_defn): Likewise.
5280         * opencl-lang.c (opencl_language_defn): Likewise.
5281         * p-lang.c (pascal_language_defn): Likewise.
5282         * rust-lang.c (rust_language_defn): Likewise.
5283
5284 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5285
5286         * ada-lang.c (ada_is_character_type): Change return type to bool.
5287         (ada_is_string_type): Likewise.
5288         * ada-lang.h (ada_is_character_type): Update declaration
5289         (ada_is_string_type): Likewise.
5290
5291 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5292
5293         Support style in 'frame|thread apply'
5294
5295         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5296         * record.c (record_start, record_stop): Update callers of
5297         execute_command_to_string with false.
5298         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5299         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5300         methods.
5301         (class string_file): New constructor with term_out parameter.
5302         Override methods term_out and can_emit_style_escape.  New member
5303         term_out.
5304         (class stdio_file): Override can_emit_style_escape.
5305         (class tee_file): Override term_out and can_emit_style_escape.
5306         * utils.h (can_emit_style_escape): Remove.
5307         * utils.c (can_emit_style_escape): Likewise.
5308         Update all callers of can_emit_style_escape (SOMESTREAM) to
5309         SOMESTREAM->can_emit_style_escape.
5310         * source-cache.c (source_cache::get_source_lines): Likewise.
5311         * stack.c (frame_apply_command_count): Call execute_command_to_string
5312         passing the term_out characteristic of the current gdb_stdout.
5313         * thread.c (thr_try_catch_cmd): Likewise.
5314         * top.c (execute_command_to_string): pass term_out parameter
5315         to construct the string_file for the command output.
5316         * ui-file.c (term_cli_styling): New function (most code moved
5317         from utils.c can_emit_style_escape).
5318         (string_file::string_file, string_file::can_emit_style_escape,
5319         stdio_file::can_emit_style_escape, tee_file::term_out,
5320         tee_file::can_emit_style_escape): New functions.
5321
5322 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5323
5324         * NEWS: Mention the new set|show may-call-functions.
5325         * infcall.c (may_call_functions_p): New variable.
5326         (show_may_call_functions_p): New function.
5327         (call_function_by_hand_dummy): Throws an error if not
5328         may-call-functions.
5329         (_initialize_infcall): Call add_setshow_boolean_cmd for
5330         may-call-functions.
5331
5332 2019-04-25  Keith Seitz  <keiths@redhat.com>
5333
5334         PR c++/24367
5335         * cp-support.c (inspect_type): Don't attempt substitutions
5336         of symbol with the same name.
5337
5338 2019-04-25  Tom Tromey  <tromey@adacore.com>
5339
5340         PR gdb/24475:
5341         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5342         static.
5343
5344 2019-04-25  Tom Tromey  <tromey@adacore.com>
5345
5346         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5347         rvalue reference.
5348         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5349         (gdb_xml_parser::parse): Use std::move.
5350         * python/python-internal.h (gdbpy_convert_exception): Take a const
5351         reference.
5352         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5353         std::move.
5354         * python/py-utils.c (gdbpy_convert_exception): Take a const
5355         reference.
5356         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5357         Use std::move.
5358         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5359         Use std::move.
5360         * mi/mi-main.c (mi_print_exception): Take a const reference.
5361         * main.c (handle_command_errors): Take a const reference.
5362         * linespec.c (parse_linespec): Use std::move.
5363         * infcall.c (run_inferior_call): Use std::move.
5364         (call_function_by_hand_dummy): Use std::move.
5365         * exec.c (try_open_exec_file): Use std::move.
5366         * exceptions.h (exception_print, exception_fprintf)
5367         (exception_print_same): Update.
5368         * exceptions.c (print_exception, exception_print)
5369         (exception_fprintf, exception_print_same): Change parameters to
5370         const reference.
5371         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5372         * common/new-op.c: Use std::move.
5373         * common/common-exceptions.h (struct gdb_exception): Add move
5374         constructor.
5375         (struct gdb_exception_error, struct gdb_exception_quit, struct
5376         gdb_quit_bad_alloc): Change constructor to move constructor.
5377         (throw_exception): Change parameter to rvalue reference.
5378         * common/common-exceptions.c (throw_exception): Take rvalue
5379         reference.
5380         * cli/cli-interp.c (safe_execute_command): Use std::move.
5381         * breakpoint.c (insert_bp_location, location_to_sals): Use
5382         std::move.
5383
5384 2019-04-25  Tom Tromey  <tromey@adacore.com>
5385
5386         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5387         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5388         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5389         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5390         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5391         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5392         guile/scm-value.c: Use unpack.
5393         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5394         gdbscm_gdb_exception.
5395         (gdbscm_throw_gdb_exception): Likewise.
5396         (struct gdbscm_gdb_exception): New.
5397         (unpack): New function.
5398         (gdbscm_wrap): Use unpack.
5399
5400 2019-04-25  Tom Tromey  <tromey@adacore.com>
5401
5402         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5403         (gdb_rl_callback_handler): Use std::move.
5404         * common/common-exceptions.h (struct gdb_exception): Add move
5405         assignment operator.
5406         (throw_exception_sjlj): Change "exception" to const reference.
5407         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5408         (throw_exception_sjlj): Change "exception" to const reference.
5409
5410 2019-04-25  Tom Tromey  <tromey@adacore.com>
5411
5412         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5413         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5414         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5415         Update.
5416         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5417         Update.
5418         * mi/mi-interp.c (mi_interp::exec): Update.
5419         * linespec.c (parse_linespec): Update.
5420         * infcall.c (run_inferior_call): Update.
5421         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5422         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5423         (gdbscm_lookup_global_symbol): Update.
5424         * guile/scm-param.c (gdbscm_parameter_value): Update.
5425         * guile/scm-frame.c (gdbscm_frame_read_register)
5426         (gdbscm_frame_read_var): Update.
5427         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5428         * exec.c (try_open_exec_file): Update.
5429         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5430         (gdb_rl_callback_handler): Update.
5431         * common/common-exceptions.h (exception_none): Don't declare.
5432         * common/common-exceptions.c (exception_none): Don't define.
5433         (struct catcher) <exception>: Update.
5434         * cli/cli-interp.c (safe_execute_command): Update.
5435         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5436
5437 2019-04-25  Ali Tamur  <tamur@google.com>
5438
5439         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5440         (read_attribute_value): Likewise.
5441         (dwarf2_read_addr_index): Update comment.
5442         (read_str_index): Add DW_FORM_strx.
5443         (dwarf2_string_attr): Likewise.
5444         (dwarf2_const_value_attr): Likewise.
5445         (dump_die_shallow): Likewise.
5446         (dwarf2_fetch_constant_bytes): Likewise.
5447         (skip_form_bytes): Likewise.
5448         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5449
5450 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5451
5452         PR corefiles/11608
5453         PR corefiles/18187
5454         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5455         OFFSET.  Verify if current mapping contains an ELF header.
5456         (linux_find_memory_regions_full): Adjust call to
5457         dump_mapping_p.
5458
5459 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5460             Kang Li <kanglictf@gmail.com>
5461
5462         PR gdb/21600
5463
5464         * dwarf2-frame.c (read_initial_length): Be consistent about using
5465         unsigned representation of length.
5466         (decode_frame_entry_1): Likewise.  Check for wraparound of
5467         end pointer as well as buffer overflow.
5468
5469 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5470
5471         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5472         "vq".
5473
5474 2019-04-24  Tom Tromey  <tromey@adacore.com>
5475
5476         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5477
5478 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5479
5480         * s12z-tdep.c (s12z_unwind_pc): Delete.
5481         (s12z_unwind_sp): Delete.
5482         (s12z_gdbarch_init): Don't register deleted functions with
5483         gdbarch.
5484
5485 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5486
5487         * rl78-tdep.c (rl78_unwind_sp): Delete.
5488         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5489
5490 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5491
5492         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5493         (xstormy16_unwind_pc): Delete.
5494         (xstormy16_dummy_id): Delete.
5495         (xstormy16_gdbarch_init): Don't register deleted functions with
5496         gdbarch.
5497
5498 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5499
5500         * vax-tdep.c (vax_unwind_pc): Delete.
5501         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5502
5503 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5504
5505         * v850-tdep.c (v850_unwind_sp): Delete.
5506         (v850_unwind_pc): Delete.
5507         (v850_dummy_id): Delete.
5508         (v850_gdbarch_init): Don't register deleted functions with
5509         gdbarch.
5510
5511 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5512
5513         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5514         (tilegx_unwind_pc): Delete.
5515         (tilegx_unwind_dummy_id): Delete.
5516         (tilegx_gdbarch_init): Don't register deleted functions with
5517         gdbarch.
5518
5519 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5520
5521         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5522         (tic6x_dummy_id): Delete.
5523         (tic6x_gdbarch_init): Don't register deleted functions with
5524         gdbarch.
5525
5526 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5527
5528         * sparc-tdep.c (sparc_unwind_pc): Delete.
5529         (sparc32_gdbarch_init): Don't register deleted function with
5530         gdbarch.
5531
5532 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5533
5534         * sh-tdep.c (sh_unwind_sp): Delete.
5535         (sh_unwind_pc): Delete.
5536         (sh_dummy_id): Delete.
5537         (sh_gdbarch_init): Don't register deleted functions with
5538         gdbarch.
5539
5540 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5541
5542         * score-tdep.c (score_unwind_sp): Delete.
5543         (score_unwind_pc): Delete.
5544         (score_dummy_id): Delete.
5545         (score_gdbarch_init): Don't register deleted functions with
5546         gdbarch.
5547
5548 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5549
5550         * rx-tdep.c (rx_unwind_pc): Delete.
5551         (rx_unwind_sp): Delete.
5552         (rx_dummy_id): Delete.
5553         (rx_gdbarch_init): Don't register deleted functions with
5554         gdbarch.  Update comment.
5555
5556 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5557
5558         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5559         (rs6000_dummy_id): Delete.
5560         (rs6000_gdbarch_init): Don't register deleted functions with
5561         gdbarch.
5562
5563 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5564
5565         * or1k-tdep.c (or1k_dummy_id): Delete.
5566         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5567
5568 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5569
5570         * nios2-tdep.c (nios2_dummy_id): Delete.
5571         (nios2_unwind_sp): Delete.
5572         (nios2_gdbarch_init): Don't register deleted functions with
5573         gdbarch.
5574
5575 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5576
5577         * nds32-tdep.c (nds32_dummy_id): Delete.
5578         (nds32_unwind_pc): Delete.
5579         (nds32_unwind_sp): Delete.
5580         (nds32_gdbarch_init): Don't register deleted functions with
5581         gdbarch.
5582
5583 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5584
5585         * msp430-tdep.c (msp430_unwind_pc): Delete.
5586         (msp430_unwind_sp): Delete.
5587         (msp430_dummy_id): Delete.
5588         (msp430_gdbarch_init): Don't register deleted functions with
5589         gdbarch.
5590
5591 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5592
5593         * moxie-tdep.c (moxie_unwind_sp): Delete.
5594         (moxie_unwind_pc): Delete.
5595         (moxie_dummy_id): Delete.
5596         (moxie_gdbarch_init): Don't register deleted functions with
5597         gdbarch.
5598
5599 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5600
5601         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5602         (mn10300_unwind_pc): Delete.
5603         (mn10300_unwind_sp): Delete.
5604         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5605         mn10300_unwind_sp.
5606         (mn10300_frame_unwind_init): Don't register deleted functions with
5607         gdbarch.
5608
5609 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5610
5611         * mep-tdep.c (mep_unwind_pc): Delete.
5612         (mep_unwind_sp): Delete.
5613         (mep_dummy_id): Delete.
5614         (mep_gdbarch_init): Don't register deleted functions with
5615         gdbarch.
5616
5617 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5618
5619         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5620         (m68hc11_unwind_sp): Delete.
5621         (m68hc11_gdbarch_init): Don't register deleted functions with
5622         gdbarch.
5623
5624 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5625
5626         * m32r-tdep.c (m32r_unwind_sp): Delete.
5627         (m32r_unwind_pc): Delete.
5628         (m32r_dummy_id): Delete.
5629         (m32r_gdbarch_init): Don't register deleted functions with
5630         gdbarch.
5631
5632 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5633
5634         * m32c-tdep.c (m32c_unwind_pc): Delete.
5635         (m32c_unwind_sp): Delete.
5636         (m32c_dummy_id): Delete.
5637         (m32c_gdbarch_init): Don't register deleted functions with
5638         gdbarch.
5639
5640 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5641
5642         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5643         (lm32_unwind_pc): Delete.
5644         (lm32_dummy_id): Delete.
5645         (lm32_gdbarch_init): Don't register deleted functions with
5646         gdbarch.
5647
5648 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5649
5650         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5651         (iq2000_unwind_pc): Delete.
5652         (iq2000_dummy_id): Delete.
5653         (iq2000_gdbarch_init): Don't register deleted functions with
5654         gdbarch.
5655
5656 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5657
5658         * nds32-tdep.c (nds32_type_align): Delete.
5659         (nds32_push_dummy_call): Use type_align instead.
5660
5661 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5662
5663         * arm-tdep.c (arm_type_align): Only handle vector override case.
5664         (arm_push_dummy_call): Use type_align.
5665         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5666
5667 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5668
5669         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5670         case.
5671         (pass_on_stack): Use type_align.
5672         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5673         function.
5674
5675 2019-04-23  Tom Tromey  <tromey@adacore.com>
5676
5677         * dwarf2read.c (line_header::file_name_at): Remove unused
5678         overload.
5679
5680 2019-04-23  Tom de Vries  <tdevries@suse.de>
5681
5682         PR gdb/24438
5683         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5684         invocation.
5685
5686
5687 2019-03-27  Ali Tamur  <tamur@google.com>
5688
5689         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5690         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5691         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5692         (dwarf_expr_context::get_addr_index): Likewise
5693         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5694         (symbol_needs_eval_context::get_addr_index): Likewise
5695         (disassemble_dwarf_expression): Add DW_OP_addrx
5696         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5697         (read_cutu_die_from_dwo): Update comment
5698         (skip_one_die): Add DW_FORM_addrx
5699         (read_attribute_value): Likewise
5700         (var_decode_location): Add DW_OP_addrx
5701         (dwarf2_const_value_attr): Add DW_FORM_addrx
5702         (dump_die_shallow): Likewise
5703         (dwarf2_fetch_constant_bytes): Likewise
5704         (decode_locdesc): Add DW_OP_addrx
5705         (skip_form_bytes): Add DW_FORM_addrx
5706
5707 2019-04-22  Ali Tamur  <tamur@google.com>
5708
5709         * MAINTAINERS (Write After Approval): Add self.
5710
5711 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5712
5713         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5714         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5715         (open_symbol_file_object): Likewise.
5716         (svr4_default_sos): Add info parameter.
5717         (svr4_read_so_list): Likewise.
5718         (svr4_current_sos_direct): Adjust functions calls to pass down
5719         info.
5720         (svr4_current_sos_1): Add info parameter.
5721         (svr4_current_sos): Call get_svr4_info, pass info down to
5722         svr4_current_sos_1.
5723         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5724         get_svr4_info.
5725         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5726         get_svr4_info.
5727         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5728         to get_svr4_info.
5729         (probes_table_remove_objfile_probes): Likewise.
5730         (register_solib_event_probe): Add info parameter.
5731         (solist_update_incremental): Pass info parameter down to
5732         svr4_read_so_list.
5733         (disable_probes_interface): Add info parameter.
5734         (svr4_handle_solib_event): Pass current_program_space to
5735         get_svr4_info.  Adjust disable_probes_interface cleanup.
5736         (svr4_create_probe_breakpoints): Add info parameter, pass it
5737         down to register_solib_event_probe.
5738         (svr4_create_solib_event_breakpoints): Add info parameter,
5739         pass it down to svr4_create_probe_breakpoints.
5740         (enable_break): Pass info down to
5741         svr4_create_solib_event_breakpoints.
5742         (svr4_solib_create_inferior_hook): Pass current_program_space to
5743         get_svr4_info.
5744         (svr4_clear_solib): Likewise.
5745
5746 2019-04-22  Pedro Alves  <palves@redhat.com>
5747
5748         * solib-svr4.c (svr4_free_objfile_observer): New.
5749         (probe_and_action::objfile): New field.
5750         (probes_table_htab_remove_objfile_probes)
5751         (probes_table_remove_objfile_probes): New functions.
5752         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5753         in the new probe_and_action.  Don't store the probe in 'lookup'.
5754         (svr4_create_probe_breakpoints): Pass objfile to
5755         register_solib_event_probe.
5756         (_initialize_svr4_solib): Register a free_objfile observer.
5757
5758 2019-04-19  Tom Tromey  <tom@tromey.com>
5759
5760         * common/queue.h: Remove.
5761
5762 2019-04-19  Tom Tromey  <tom@tromey.com>
5763
5764         * event-loop.c: Don't include "common/queue.h".
5765
5766 2019-04-19  Tom Tromey  <tom@tromey.com>
5767
5768         * remote.c (remote_target): Use delete.
5769         * remote-notif.h: Include <list>, not "common/queue.h".
5770         (notif_client_p): Remove typedef.
5771         (remote_notif_state): Add constructor, destructor, initializer.
5772         <notif_queue>: Now a std::list.
5773         (remote_notif_state_xfree): Don't declare.
5774         * remote-notif.c (remote_notif_process, handle_notification)
5775         (remote_notif_state_allocate): Update.
5776         (~remote_notif_state): Rename from remote_notif_state_xfree.
5777
5778 2019-04-19  Tom Tromey  <tom@tromey.com>
5779
5780         * symfile.c (reread_symbols): Update.
5781         * objfiles.c (objfile_register_static_link)
5782         (objfile_lookup_static_link): Update
5783         (~objfile) Don't delete static_links.
5784         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5785
5786 2019-04-19  Tom Tromey  <tom@tromey.com>
5787
5788         * type-stack.h (struct type_stack) <insert>: Constify string.
5789         * type-stack.c (type_stack::insert): Constify string.
5790         * gdbtypes.h (lookup_template_type): Update.
5791         (address_space_name_to_int): Update.
5792         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5793         const.
5794         (lookup_template_type): Make name const.
5795         * c-exp.y: Update rules.
5796         (lex_one_token, classify_name, classify_inner_name)
5797         (c_print_token): Update.
5798         * p-exp.y: Update rules.
5799         (yylex): Update.
5800         * f-exp.y: Update rules.
5801         (yylex): Update.
5802         * d-exp.y: Update rules.
5803         (lex_one_token, classify_name, classify_inner_name): Update.
5804         * parse.c (write_dollar_variable, copy_name): Return std::string.
5805         * parser-defs.h (copy_name): Change return type.
5806         * m2-exp.y: Update rules.
5807         (yylex): Update.
5808         * go-exp.y (lex_one_token): Update.
5809         Update rules.
5810         (classify_unsafe_function, classify_packaged_name)
5811         (classify_name, yylex): Update.
5812
5813 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5814
5815         * configure.ac: add --enable-source-highlight switch.
5816         * configure: Regenerate.
5817         * top.c (print_gdb_version): plumb --enable-source-highlight
5818         status to "show configuration".
5819
5820 2019-04-19  Tom Tromey  <tromey@adacore.com>
5821
5822         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5823         Check ADA_TYPE_P.
5824         (empty_record, ada_template_to_fixed_record_type_1)
5825         (template_to_static_fixed_type)
5826         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5827         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5828         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5829         macros.
5830
5831 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5832
5833         PR symtab/24423:
5834         * source.c (print_source_lines_base): Advance "iter" when a
5835         control character is seen.
5836
5837 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5838
5839         * inferior.h (struct infcall_suspend_state_deleter):
5840         Catch exception in destructor to avoid crash.
5841
5842 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5843
5844         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5845         close to the add_com "shell".
5846
5847 2019-04-18  Tom Tromey  <tromey@adacore.com>
5848
5849         * process-stratum-target.h (class process_stratum_target)
5850         <stratum>: Add "final".
5851
5852 2019-04-17  Tom Tromey  <tromey@adacore.com>
5853
5854         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5855         against nullptr before use.
5856
5857 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5858
5859         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5860
5861 2019-04-17  Jim Wilson  <jimw@sifive.com>
5862             Andrew Burgess  <andrew.burgess@embecosm.com>
5863
5864         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5865         code read might fail, assume 4-byte breakpoint in that case.
5866
5867 2019-04-15  Leszek Swirski  <leszeks@google.com>
5868
5869         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5870         rather than a hand-rolled POD check when checking for forced MEMORY
5871         classification.
5872
5873 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5874
5875         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5876         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5877         function.
5878         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5879         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5880         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5881         declaration.
5882
5883 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5884
5885         * aarch64-linux-nat.c
5886         (aarch64_linux_nat_target::thread_architecture): Add override.
5887         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5888         each VQ.
5889
5890 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5891
5892         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5893
5894 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5895
5896         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5897         target types of size 96-bits, add some additional comments, and
5898         check that the builtin type we found was the correct size.
5899
5900 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5901
5902         * utils.c (prompt_for_continue): Don't restore the styling at the
5903         end, as applied_style has the wrong value.  This fixes styling in
5904         long lists of file names that are interrupted by the "Continue?"
5905         prompt.
5906
5907 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5908
5909         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5910         * c-lang.c (c_language_defn): Likewise.
5911         (cplus_language_defn): Likewise.
5912         (asm_language_defn): Likewise.
5913         (minimal_language_defn): Likewise.
5914         * d-lang.c (d_language_defn): Likewise.
5915         * f-lang.c (f_language_defn): Likewise.
5916         * go-lang.c (go_language_defn): Likewise.
5917         * language.c (unknown_language_defn): Likewise.
5918         (auto_language_defn): Likewise.
5919         * language.h (struct language_defn): Remove la_magic field.
5920         (LANG_MAGIC): Delete.
5921         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5922         * objc-lang.c (objc_language_defn): Likewise.
5923         * opencl-lang.c (opencl_language_defn): Likewise.
5924         * p-lang.c (pascal_language_defn): Likewise.
5925         * rust-lang.c (rust_language_defn): Likewise.
5926
5927 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5928
5929         * riscv-tdep.c (riscv_type_align): New function.
5930         (riscv_type_alignment): Delete.
5931         (riscv_arg_location): Use 'type_align'.
5932         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5933
5934 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5935
5936         * gdbtypes.c (type_align): A struct with no non-static fields also
5937         has alignment of 1.
5938
5939 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5940
5941         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5942         component to 0.
5943         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5944         member.
5945         (riscv_struct_info::analyse): New implementation using new
5946         analyse_inner member function.
5947         (riscv_struct_info::field_offset): New member function.
5948         (riscv_struct_info::m_offsets): New member variable.
5949         (riscv_struct_info::analyse_inner): New private member function,
5950         takes the old implementation of riscv_struct_info::analyse but
5951         extended to track field offsets.
5952         (riscv_call_arg_struct): Update the struct folding special cases
5953         to handle cases where empty C++ structs, which are non-zero
5954         length, are found.
5955         (riscv_arg_location): Initialise the length of each location, a
5956         non-zero length now indicates the location is in use.
5957         (riscv_push_dummy_call): Allow for the first location having a
5958         non-zero offset when setting up arguments.
5959         (riscv_return_value): Likewise, but for return values.
5960
5961 2019-04-11  Tom Tromey  <tromey@adacore.com>
5962
5963         * utils.c (internal_vproblem): Make "msg" const.
5964
5965 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5966
5967         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5968         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5969         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5970         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5971
5972 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5973
5974         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5975         function.
5976         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5977         of amd64_collect_native_gregset.
5978         (amd64_linux_nat_target::store_registers): Likewise.
5979
5980 2019-04-10  Tom Tromey  <tom@tromey.com>
5981
5982         * symtab.c (lookup_global_symbol_from_objfile)
5983         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5984         * objfiles.h (class separate_debug_iterator): New.
5985         (class separate_debug_range): New.
5986         (struct objfile) <separate_debug_objfiles>: New method.
5987         (objfile_separate_debug_iterate): Don't declare.
5988         * objfiles.c (separate_debug_iterator::operator++): Rename from
5989         objfile_separate_debug_iterate.
5990         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5991         iterator.
5992         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5993         iterator.
5994
5995 2019-04-10  Tom Tromey  <tom@tromey.com>
5996
5997         * symfile.c (reread_symbols): Remove old comment.
5998         * objfiles.c (free_all_objfiles): Fix a typo.
5999
6000 2019-04-10  Tom Tromey  <tom@tromey.com>
6001
6002         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6003         * minsyms.c (lookup_minimal_symbol): Use foreach.
6004         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6005         (lookup_minimal_symbol_solib_trampoline): Likewise.
6006         * symfile.c (reread_symbols): Use foreach.
6007
6008 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6009             Tom Tromey  <tromey@adacore.com>
6010
6011         PR rust/24414:
6012         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6013         (rust_lex_int_test): Change "value" to be LONGEST.
6014         (rust_lex_tests): Add test for long integer literal.
6015
6016 2019-04-09  Tom Tromey  <tromey@adacore.com>
6017
6018         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6019         to bool.
6020         (extended_remote_target::attach): Update.
6021         (remote_target::remote_notice_new_inferior): Update.
6022         (remote_target::add_current_inferior_and_thread): Update.
6023         * inferior.c (exit_inferior_1): Use "false".
6024         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6025
6026 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6027
6028         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6029         the "start" command.
6030
6031 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6032
6033         * python/py-inferior.c (infpy_thread_from_thread_handle):
6034         Adjust comments to reflect renaming of thread_from_thread_handle
6035         to thread_from_handle.  Adjust keywords.  Fix type error message.
6036         (inferior_object_methods): Add thread_from_handle.  Retain
6037         thread_from_thread_handle, but mark it as deprecated.
6038
6039 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6040
6041         * gdbthread.h (find_thread_by_handle): Revise declaration.
6042         * thread.c (find_thread_by_handle): Likewise.  Adjust
6043         implementation too.
6044         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6045         support for buffer objects as handles.
6046
6047 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6048
6049         * python/py-infthread.c (thpy_thread_handle): New function.
6050         (thread_object_methods): Register thpy_thread_handle.
6051
6052 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6053
6054         * gdbthread.h (thread_to_thread_handle): Declare.
6055         * thread.c (gdbtypes.h): Include.
6056         (thread_to_thread_handle): New function.
6057
6058         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6059         (target_thread_info_to_thread_handle): Declare.
6060         * target.c (target_thread_info_to_thread_handle): New function.
6061         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6062         * target-delegates.c: Regenerate.
6063
6064         * linux-thread-db.c (class thread_db_target): Add method
6065         thread_info_to_thread_handle.
6066         (thread_db_target::thread_info_to_thread_handle): Define.
6067         * remote.c (class remote_target): Add new method
6068         thread_info_to_thread_handle.
6069         (remote_target::thread_info_to_thread_handle): Define.
6070
6071 2019-04-08  Pedro Alves  <palves@redhat.com>
6072
6073         * common/common-exceptions.c (throw_exception): Don't create
6074         named object to throw; throw directly.
6075         (throw_it): Likewise.  Don't initialize gdb_exception::message
6076         here, with new; pass FMT and AP to the ctor instead.
6077         * common/common-exceptions.h: Include <string>.
6078         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6079         const char *, va_list)): New ctor.  Use std::make_shared.
6080         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6081         errors)): Delete.
6082         (gdb_exception_error::gdb_exception_error(enum errors, const char
6083         *, va_list)): New.
6084         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6085         Add assertion.
6086         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6087         errors)): Delete.
6088         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6089         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6090         Add assertion.
6091
6092 2019-04-08  Tom Tromey  <tom@tromey.com>
6093
6094         * valops.c (value_rtti_indirect_type): Replace throw_exception
6095         with throw.
6096         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6097         with throw.
6098         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6099         throw.
6100         * target.c (target_translate_tls_address): Replace throw_exception
6101         with throw.
6102         * stack.c (frame_apply_command_count): Replace throw_exception
6103         with throw.
6104         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6105         throw.
6106         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6107         with throw.
6108         * rs6000-tdep.c (rs6000_frame_cache)
6109         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6110         * remote.c: Replace throw_exception with throw.
6111         * record-full.c (record_full_message, record_full_wait_1)
6112         (record_full_restore): Replace throw_exception with throw.
6113         * record-btrace.c:
6114         (get_thread_current_frame_id, record_btrace_start_replaying)
6115         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6116         (cmd_record_btrace_start): Replace throw_exception with throw.
6117         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6118         throw.
6119         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6120         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6121         * linespec.c:
6122         (find_linespec_symbols): Replace throw_exception with throw.
6123         * infrun.c (displaced_step_prepare, resume): Replace
6124         throw_exception with throw.
6125         * infcmd.c (post_create_inferior): Replace throw_exception with
6126         throw.
6127         * inf-loop.c (inferior_event_handler): Replace throw_exception
6128         with throw.
6129         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6130         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6131         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6132         (get_prev_frame_always, get_frame_pc_if_available)
6133         (get_frame_address_in_block_if_available, get_frame_language):
6134         Replace throw_exception with throw.
6135         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6136         throw_exception with throw.
6137         * eval.c (fetch_subexp_value, evaluate_var_value)
6138         (evaluate_funcall, evaluate_subexp_standard): Replace
6139         throw_exception with throw.
6140         * dwarf2loc.c (call_site_find_chain)
6141         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6142         Replace throw_exception with throw.
6143         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6144         with throw.
6145         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6146         throw.
6147         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6148         * completer.c (complete_line_internal): Replace throw_exception
6149         with throw.
6150         * compile/compile-object-run.c (compile_object_run): Replace
6151         throw_exception with throw.
6152         * cli/cli-script.c (process_next_line): Replace throw_exception
6153         with throw.
6154         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6155         (btrace_enable, btrace_maint_update_pt_packets): Replace
6156         throw_exception with throw.
6157         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6158         throw_exception with throw.
6159         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6160         throw_exception with throw.
6161         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6162         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6163         * aarch64-tdep.c (aarch64_make_prologue_cache)
6164         (aarch64_make_stub_cache): Replace throw_exception with throw.
6165
6166 2019-04-08  Tom Tromey  <tom@tromey.com>
6167
6168         * common/common-exceptions.c (throw_exception): Rename from
6169         throw_exception_cxx.  Remove old copy.  Make argument const.
6170         (throw_it): Create and throw exception objects directly.
6171         * common/common-exceptions.h (throw_exception): Make argument
6172         const.
6173         (struct gdb_exception_error): Add constructor.
6174         (struct gdb_exception_quit): Add constructor.
6175
6176 2019-04-08  Tom Tromey  <tom@tromey.com>
6177
6178         * common/common-exceptions.h (exception_rethrow): Don't declare.
6179         (TRY_SJLJ): Update comment.
6180         (TRY, CATCH, END_CATCH): Remove.
6181         * common/common-exceptions.c (exception_rethrow): Remove.
6182
6183 2019-04-08  Tom Tromey  <tom@tromey.com>
6184
6185         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6186         Remove.
6187         (gdb_exception_error): Rename from
6188         gdb_exception_RETURN_MASK_ERROR.
6189         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6190         (gdb_quit_bad_alloc): Update.
6191         * aarch64-tdep.c: Update.
6192         * ada-lang.c: Update.
6193         * ada-typeprint.c: Update.
6194         * ada-valprint.c: Update.
6195         * amd64-tdep.c: Update.
6196         * arch-utils.c: Update.
6197         * break-catch-throw.c: Update.
6198         * breakpoint.c: Update.
6199         * btrace.c: Update.
6200         * c-varobj.c: Update.
6201         * cli/cli-cmds.c: Update.
6202         * cli/cli-interp.c: Update.
6203         * cli/cli-script.c: Update.
6204         * common/common-exceptions.c: Update.
6205         * common/new-op.c: Update.
6206         * common/selftest.c: Update.
6207         * compile/compile-c-symbols.c: Update.
6208         * compile/compile-cplus-symbols.c: Update.
6209         * compile/compile-object-load.c: Update.
6210         * compile/compile-object-run.c: Update.
6211         * completer.c: Update.
6212         * corelow.c: Update.
6213         * cp-abi.c: Update.
6214         * cp-support.c: Update.
6215         * cp-valprint.c: Update.
6216         * darwin-nat.c: Update.
6217         * disasm-selftests.c: Update.
6218         * dtrace-probe.c: Update.
6219         * dwarf-index-cache.c: Update.
6220         * dwarf-index-write.c: Update.
6221         * dwarf2-frame-tailcall.c: Update.
6222         * dwarf2-frame.c: Update.
6223         * dwarf2loc.c: Update.
6224         * dwarf2read.c: Update.
6225         * eval.c: Update.
6226         * event-loop.c: Update.
6227         * event-top.c: Update.
6228         * exec.c: Update.
6229         * f-valprint.c: Update.
6230         * fbsd-tdep.c: Update.
6231         * frame-unwind.c: Update.
6232         * frame.c: Update.
6233         * gdbtypes.c: Update.
6234         * gnu-v3-abi.c: Update.
6235         * guile/guile-internal.h: Update.
6236         * guile/scm-block.c: Update.
6237         * guile/scm-breakpoint.c: Update.
6238         * guile/scm-cmd.c: Update.
6239         * guile/scm-disasm.c: Update.
6240         * guile/scm-frame.c: Update.
6241         * guile/scm-lazy-string.c: Update.
6242         * guile/scm-math.c: Update.
6243         * guile/scm-param.c: Update.
6244         * guile/scm-ports.c: Update.
6245         * guile/scm-pretty-print.c: Update.
6246         * guile/scm-symbol.c: Update.
6247         * guile/scm-symtab.c: Update.
6248         * guile/scm-type.c: Update.
6249         * guile/scm-value.c: Update.
6250         * i386-linux-tdep.c: Update.
6251         * i386-tdep.c: Update.
6252         * inf-loop.c: Update.
6253         * infcall.c: Update.
6254         * infcmd.c: Update.
6255         * infrun.c: Update.
6256         * jit.c: Update.
6257         * language.c: Update.
6258         * linespec.c: Update.
6259         * linux-fork.c: Update.
6260         * linux-nat.c: Update.
6261         * linux-tdep.c: Update.
6262         * linux-thread-db.c: Update.
6263         * main.c: Update.
6264         * mi/mi-cmd-break.c: Update.
6265         * mi/mi-cmd-stack.c: Update.
6266         * mi/mi-interp.c: Update.
6267         * mi/mi-main.c: Update.
6268         * objc-lang.c: Update.
6269         * p-valprint.c: Update.
6270         * parse.c: Update.
6271         * ppc-linux-tdep.c: Update.
6272         * printcmd.c: Update.
6273         * python/py-arch.c: Update.
6274         * python/py-breakpoint.c: Update.
6275         * python/py-cmd.c: Update.
6276         * python/py-finishbreakpoint.c: Update.
6277         * python/py-frame.c: Update.
6278         * python/py-framefilter.c: Update.
6279         * python/py-gdb-readline.c: Update.
6280         * python/py-inferior.c: Update.
6281         * python/py-infthread.c: Update.
6282         * python/py-lazy-string.c: Update.
6283         * python/py-linetable.c: Update.
6284         * python/py-objfile.c: Update.
6285         * python/py-param.c: Update.
6286         * python/py-prettyprint.c: Update.
6287         * python/py-progspace.c: Update.
6288         * python/py-record-btrace.c: Update.
6289         * python/py-record.c: Update.
6290         * python/py-symbol.c: Update.
6291         * python/py-type.c: Update.
6292         * python/py-unwind.c: Update.
6293         * python/py-utils.c: Update.
6294         * python/py-value.c: Update.
6295         * python/python.c: Update.
6296         * record-btrace.c: Update.
6297         * record-full.c: Update.
6298         * remote-fileio.c: Update.
6299         * remote.c: Update.
6300         * riscv-tdep.c: Update.
6301         * rs6000-aix-tdep.c: Update.
6302         * rs6000-tdep.c: Update.
6303         * rust-exp.y: Update.
6304         * rust-lang.c: Update.
6305         * s390-tdep.c: Update.
6306         * selftest-arch.c: Update.
6307         * solib-dsbt.c: Update.
6308         * solib-frv.c: Update.
6309         * solib-spu.c: Update.
6310         * solib-svr4.c: Update.
6311         * solib.c: Update.
6312         * sparc64-linux-tdep.c: Update.
6313         * stack.c: Update.
6314         * symfile-mem.c: Update.
6315         * symmisc.c: Update.
6316         * target.c: Update.
6317         * thread.c: Update.
6318         * top.c: Update.
6319         * tracefile-tfile.c: Update.
6320         * tui/tui.c: Update.
6321         * typeprint.c: Update.
6322         * unittests/cli-utils-selftests.c: Update.
6323         * unittests/parse-connection-spec-selftests.c: Update.
6324         * valops.c: Update.
6325         * valprint.c: Update.
6326         * value.c: Update.
6327         * varobj.c: Update.
6328         * windows-nat.c: Update.
6329         * x86-linux-nat.c: Update.
6330         * xml-support.c: Update.
6331
6332 2019-04-08  Tom Tromey  <tom@tromey.com>
6333
6334         * xml-support.c: Use C++ exception handling.
6335         * x86-linux-nat.c: Use C++ exception handling.
6336         * windows-nat.c: Use C++ exception handling.
6337         * varobj.c: Use C++ exception handling.
6338         * value.c: Use C++ exception handling.
6339         * valprint.c: Use C++ exception handling.
6340         * valops.c: Use C++ exception handling.
6341         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6342         handling.
6343         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6344         * typeprint.c: Use C++ exception handling.
6345         * tui/tui.c: Use C++ exception handling.
6346         * tracefile-tfile.c: Use C++ exception handling.
6347         * top.c: Use C++ exception handling.
6348         * thread.c: Use C++ exception handling.
6349         * target.c: Use C++ exception handling.
6350         * symmisc.c: Use C++ exception handling.
6351         * symfile-mem.c: Use C++ exception handling.
6352         * stack.c: Use C++ exception handling.
6353         * sparc64-linux-tdep.c: Use C++ exception handling.
6354         * solib.c: Use C++ exception handling.
6355         * solib-svr4.c: Use C++ exception handling.
6356         * solib-spu.c: Use C++ exception handling.
6357         * solib-frv.c: Use C++ exception handling.
6358         * solib-dsbt.c: Use C++ exception handling.
6359         * selftest-arch.c: Use C++ exception handling.
6360         * s390-tdep.c: Use C++ exception handling.
6361         * rust-lang.c: Use C++ exception handling.
6362         * rust-exp.y: Use C++ exception handling.
6363         * rs6000-tdep.c: Use C++ exception handling.
6364         * rs6000-aix-tdep.c: Use C++ exception handling.
6365         * riscv-tdep.c: Use C++ exception handling.
6366         * remote.c: Use C++ exception handling.
6367         * remote-fileio.c: Use C++ exception handling.
6368         * record-full.c: Use C++ exception handling.
6369         * record-btrace.c: Use C++ exception handling.
6370         * python/python.c: Use C++ exception handling.
6371         * python/py-value.c: Use C++ exception handling.
6372         * python/py-utils.c: Use C++ exception handling.
6373         * python/py-unwind.c: Use C++ exception handling.
6374         * python/py-type.c: Use C++ exception handling.
6375         * python/py-symbol.c: Use C++ exception handling.
6376         * python/py-record.c: Use C++ exception handling.
6377         * python/py-record-btrace.c: Use C++ exception handling.
6378         * python/py-progspace.c: Use C++ exception handling.
6379         * python/py-prettyprint.c: Use C++ exception handling.
6380         * python/py-param.c: Use C++ exception handling.
6381         * python/py-objfile.c: Use C++ exception handling.
6382         * python/py-linetable.c: Use C++ exception handling.
6383         * python/py-lazy-string.c: Use C++ exception handling.
6384         * python/py-infthread.c: Use C++ exception handling.
6385         * python/py-inferior.c: Use C++ exception handling.
6386         * python/py-gdb-readline.c: Use C++ exception handling.
6387         * python/py-framefilter.c: Use C++ exception handling.
6388         * python/py-frame.c: Use C++ exception handling.
6389         * python/py-finishbreakpoint.c: Use C++ exception handling.
6390         * python/py-cmd.c: Use C++ exception handling.
6391         * python/py-breakpoint.c: Use C++ exception handling.
6392         * python/py-arch.c: Use C++ exception handling.
6393         * printcmd.c: Use C++ exception handling.
6394         * ppc-linux-tdep.c: Use C++ exception handling.
6395         * parse.c: Use C++ exception handling.
6396         * p-valprint.c: Use C++ exception handling.
6397         * objc-lang.c: Use C++ exception handling.
6398         * mi/mi-main.c: Use C++ exception handling.
6399         * mi/mi-interp.c: Use C++ exception handling.
6400         * mi/mi-cmd-stack.c: Use C++ exception handling.
6401         * mi/mi-cmd-break.c: Use C++ exception handling.
6402         * main.c: Use C++ exception handling.
6403         * linux-thread-db.c: Use C++ exception handling.
6404         * linux-tdep.c: Use C++ exception handling.
6405         * linux-nat.c: Use C++ exception handling.
6406         * linux-fork.c: Use C++ exception handling.
6407         * linespec.c: Use C++ exception handling.
6408         * language.c: Use C++ exception handling.
6409         * jit.c: Use C++ exception handling.
6410         * infrun.c: Use C++ exception handling.
6411         * infcmd.c: Use C++ exception handling.
6412         * infcall.c: Use C++ exception handling.
6413         * inf-loop.c: Use C++ exception handling.
6414         * i386-tdep.c: Use C++ exception handling.
6415         * i386-linux-tdep.c: Use C++ exception handling.
6416         * guile/scm-value.c: Use C++ exception handling.
6417         * guile/scm-type.c: Use C++ exception handling.
6418         * guile/scm-symtab.c: Use C++ exception handling.
6419         * guile/scm-symbol.c: Use C++ exception handling.
6420         * guile/scm-pretty-print.c: Use C++ exception handling.
6421         * guile/scm-ports.c: Use C++ exception handling.
6422         * guile/scm-param.c: Use C++ exception handling.
6423         * guile/scm-math.c: Use C++ exception handling.
6424         * guile/scm-lazy-string.c: Use C++ exception handling.
6425         * guile/scm-frame.c: Use C++ exception handling.
6426         * guile/scm-disasm.c: Use C++ exception handling.
6427         * guile/scm-cmd.c: Use C++ exception handling.
6428         * guile/scm-breakpoint.c: Use C++ exception handling.
6429         * guile/scm-block.c: Use C++ exception handling.
6430         * guile/guile-internal.h: Use C++ exception handling.
6431         * gnu-v3-abi.c: Use C++ exception handling.
6432         * gdbtypes.c: Use C++ exception handling.
6433         * frame.c: Use C++ exception handling.
6434         * frame-unwind.c: Use C++ exception handling.
6435         * fbsd-tdep.c: Use C++ exception handling.
6436         * f-valprint.c: Use C++ exception handling.
6437         * exec.c: Use C++ exception handling.
6438         * event-top.c: Use C++ exception handling.
6439         * event-loop.c: Use C++ exception handling.
6440         * eval.c: Use C++ exception handling.
6441         * dwarf2read.c: Use C++ exception handling.
6442         * dwarf2loc.c: Use C++ exception handling.
6443         * dwarf2-frame.c: Use C++ exception handling.
6444         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6445         * dwarf-index-write.c: Use C++ exception handling.
6446         * dwarf-index-cache.c: Use C++ exception handling.
6447         * dtrace-probe.c: Use C++ exception handling.
6448         * disasm-selftests.c: Use C++ exception handling.
6449         * darwin-nat.c: Use C++ exception handling.
6450         * cp-valprint.c: Use C++ exception handling.
6451         * cp-support.c: Use C++ exception handling.
6452         * cp-abi.c: Use C++ exception handling.
6453         * corelow.c: Use C++ exception handling.
6454         * completer.c: Use C++ exception handling.
6455         * compile/compile-object-run.c: Use C++ exception handling.
6456         * compile/compile-object-load.c: Use C++ exception handling.
6457         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6458         * compile/compile-c-symbols.c: Use C++ exception handling.
6459         * common/selftest.c: Use C++ exception handling.
6460         * common/new-op.c: Use C++ exception handling.
6461         * cli/cli-script.c: Use C++ exception handling.
6462         * cli/cli-interp.c: Use C++ exception handling.
6463         * cli/cli-cmds.c: Use C++ exception handling.
6464         * c-varobj.c: Use C++ exception handling.
6465         * btrace.c: Use C++ exception handling.
6466         * breakpoint.c: Use C++ exception handling.
6467         * break-catch-throw.c: Use C++ exception handling.
6468         * arch-utils.c: Use C++ exception handling.
6469         * amd64-tdep.c: Use C++ exception handling.
6470         * ada-valprint.c: Use C++ exception handling.
6471         * ada-typeprint.c: Use C++ exception handling.
6472         * ada-lang.c: Use C++ exception handling.
6473         * aarch64-tdep.c: Use C++ exception handling.
6474
6475 2019-04-08  Tom Tromey  <tom@tromey.com>
6476
6477         * xml-support.c (gdb_xml_parser::parse): Update.
6478         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6479         * value.c (show_convenience): Update.
6480         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6481         (test_parse_flags_qcs): Update.
6482         * thread.c (thr_try_catch_cmd): Update.
6483         * target.c (target_translate_tls_address): Update.
6484         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6485         (info_frame_command_core, frame_apply_command_count): Update.
6486         * rust-exp.y (rust_lex_exception_test): Update.
6487         * riscv-tdep.c (riscv_print_one_register_info): Update.
6488         * remote.c (remote_target::enable_btrace): Update.
6489         * record-btrace.c (record_btrace_enable_warn): Update.
6490         * python/py-utils.c (gdbpy_convert_exception): Update.
6491         * printcmd.c (do_one_display, print_variable_and_value): Update.
6492         * mi/mi-main.c (mi_print_exception): Update.
6493         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6494         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6495         * linux-nat.c (linux_nat_target::attach): Update.
6496         * linux-fork.c (class scoped_switch_fork_info): Update.
6497         * infrun.c (displaced_step_prepare): Update.
6498         * infcall.c (call_function_by_hand_dummy): Update.
6499         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6500         * gnu-v3-abi.c (print_one_vtable): Update.
6501         * frame.c (get_prev_frame_always): Update.
6502         * f-valprint.c (info_common_command_for_block): Update.
6503         * exec.c (try_open_exec_file): Update.
6504         * exceptions.c (print_exception, exception_print)
6505         (exception_fprintf, exception_print_same): Update.
6506         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6507         * dwarf-index-cache.c (index_cache::store)
6508         (index_cache::lookup_gdb_index): Update.
6509         * darwin-nat.c (maybe_cache_shell): Update.
6510         * cp-valprint.c (cp_print_value_fields): Update.
6511         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6512         (gcc_cplus_symbol_address): Update.
6513         * compile/compile-c-symbols.c (gcc_convert_symbol)
6514         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6515         * common/selftest.c: Update.
6516         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6517         a std::string.
6518         (exception_try_scope_entry, exception_try_scope_exit): Don't
6519         declare.
6520         (struct exception_try_scope): Remove.
6521         (TRY): Don't use exception_try_scope.
6522         (struct gdb_exception): Add constructor, operator=.
6523         <what>: New method.
6524         (struct gdb_exception_RETURN_MASK_ALL)
6525         (struct gdb_exception_RETURN_MASK_ERROR)
6526         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6527         (struct gdb_quit_bad_alloc): Update.
6528         * common/common-exceptions.c (exception_none): Change
6529         initializer.
6530         (struct catcher) <state, exception>: Initialize inline.
6531         <prev>: Remove member.
6532         (current_catcher): Remove.
6533         (catchers): New global.
6534         (exceptions_state_mc_init): Simplify.
6535         (catcher_pop): Remove.
6536         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6537         (try_scope_depth, exception_try_scope_entry)
6538         (exception_try_scope_exit): Remove.
6539         (throw_exception_sjlj): Update.
6540         (exception_messages, exception_messages_size): Remove.
6541         (throw_it): Simplify.
6542         (gdb_exception_sliced_copy): Remove.
6543         (throw_exception_cxx): Update.
6544         * cli/cli-script.c (script_from_file): Update.
6545         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6546         Update.
6547         * ada-valprint.c (ada_val_print): Update.
6548         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6549         (create_excep_cond_exprs): Update.
6550
6551 2019-04-08  Tom Tromey  <tom@tromey.com>
6552
6553         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6554         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6555         (TRY, CATCH, END_CATCH): Remove some definitions.
6556         * common/common-exceptions.c: Don't use GDB_XCPT.
6557         (catcher_list_size): Remove.
6558         (throw_exception, throw_it): Simplify.
6559
6560 2019-04-05  Tom Tromey  <tom@tromey.com>
6561
6562         Revert the header-sorting patch.
6563         * ft32-tdep.c: Revert.
6564         * frv-tdep.c: Revert.
6565         * frv-linux-tdep.c: Revert.
6566         * frame.c: Revert.
6567         * frame-unwind.c: Revert.
6568         * frame-base.c: Revert.
6569         * fork-child.c: Revert.
6570         * findvar.c: Revert.
6571         * findcmd.c: Revert.
6572         * filesystem.c: Revert.
6573         * filename-seen-cache.h: Revert.
6574         * filename-seen-cache.c: Revert.
6575         * fbsd-tdep.c: Revert.
6576         * fbsd-nat.h: Revert.
6577         * fbsd-nat.c: Revert.
6578         * f-valprint.c: Revert.
6579         * f-typeprint.c: Revert.
6580         * f-lang.c: Revert.
6581         * extension.h: Revert.
6582         * extension.c: Revert.
6583         * extension-priv.h: Revert.
6584         * expprint.c: Revert.
6585         * exec.h: Revert.
6586         * exec.c: Revert.
6587         * exceptions.c: Revert.
6588         * event-top.c: Revert.
6589         * event-loop.c: Revert.
6590         * eval.c: Revert.
6591         * elfread.c: Revert.
6592         * dwarf2read.h: Revert.
6593         * dwarf2read.c: Revert.
6594         * dwarf2loc.c: Revert.
6595         * dwarf2expr.h: Revert.
6596         * dwarf2expr.c: Revert.
6597         * dwarf2-frame.c: Revert.
6598         * dwarf2-frame-tailcall.c: Revert.
6599         * dwarf-index-write.h: Revert.
6600         * dwarf-index-write.c: Revert.
6601         * dwarf-index-common.c: Revert.
6602         * dwarf-index-cache.h: Revert.
6603         * dwarf-index-cache.c: Revert.
6604         * dummy-frame.c: Revert.
6605         * dtrace-probe.c: Revert.
6606         * disasm.h: Revert.
6607         * disasm.c: Revert.
6608         * disasm-selftests.c: Revert.
6609         * dictionary.c: Revert.
6610         * dicos-tdep.c: Revert.
6611         * demangle.c: Revert.
6612         * dcache.h: Revert.
6613         * dcache.c: Revert.
6614         * darwin-nat.h: Revert.
6615         * darwin-nat.c: Revert.
6616         * darwin-nat-info.c: Revert.
6617         * d-valprint.c: Revert.
6618         * d-namespace.c: Revert.
6619         * d-lang.c: Revert.
6620         * ctf.c: Revert.
6621         * csky-tdep.c: Revert.
6622         * csky-linux-tdep.c: Revert.
6623         * cris-tdep.c: Revert.
6624         * cris-linux-tdep.c: Revert.
6625         * cp-valprint.c: Revert.
6626         * cp-support.c: Revert.
6627         * cp-namespace.c: Revert.
6628         * cp-abi.c: Revert.
6629         * corelow.c: Revert.
6630         * corefile.c: Revert.
6631         * continuations.c: Revert.
6632         * completer.h: Revert.
6633         * completer.c: Revert.
6634         * complaints.c: Revert.
6635         * coffread.c: Revert.
6636         * coff-pe-read.c: Revert.
6637         * cli-out.h: Revert.
6638         * cli-out.c: Revert.
6639         * charset.c: Revert.
6640         * c-varobj.c: Revert.
6641         * c-valprint.c: Revert.
6642         * c-typeprint.c: Revert.
6643         * c-lang.c: Revert.
6644         * buildsym.c: Revert.
6645         * buildsym-legacy.c: Revert.
6646         * build-id.h: Revert.
6647         * build-id.c: Revert.
6648         * btrace.c: Revert.
6649         * bsd-uthread.c: Revert.
6650         * breakpoint.h: Revert.
6651         * breakpoint.c: Revert.
6652         * break-catch-throw.c: Revert.
6653         * break-catch-syscall.c: Revert.
6654         * break-catch-sig.c: Revert.
6655         * blockframe.c: Revert.
6656         * block.c: Revert.
6657         * bfin-tdep.c: Revert.
6658         * bfin-linux-tdep.c: Revert.
6659         * bfd-target.c: Revert.
6660         * bcache.c: Revert.
6661         * ax-general.c: Revert.
6662         * ax-gdb.h: Revert.
6663         * ax-gdb.c: Revert.
6664         * avr-tdep.c: Revert.
6665         * auxv.c: Revert.
6666         * auto-load.c: Revert.
6667         * arm-wince-tdep.c: Revert.
6668         * arm-tdep.c: Revert.
6669         * arm-symbian-tdep.c: Revert.
6670         * arm-pikeos-tdep.c: Revert.
6671         * arm-obsd-tdep.c: Revert.
6672         * arm-nbsd-tdep.c: Revert.
6673         * arm-nbsd-nat.c: Revert.
6674         * arm-linux-tdep.c: Revert.
6675         * arm-linux-nat.c: Revert.
6676         * arm-fbsd-tdep.c: Revert.
6677         * arm-fbsd-nat.c: Revert.
6678         * arm-bsd-tdep.c: Revert.
6679         * arch-utils.c: Revert.
6680         * arc-tdep.c: Revert.
6681         * arc-newlib-tdep.c: Revert.
6682         * annotate.h: Revert.
6683         * annotate.c: Revert.
6684         * amd64-windows-tdep.c: Revert.
6685         * amd64-windows-nat.c: Revert.
6686         * amd64-tdep.c: Revert.
6687         * amd64-sol2-tdep.c: Revert.
6688         * amd64-obsd-tdep.c: Revert.
6689         * amd64-obsd-nat.c: Revert.
6690         * amd64-nbsd-tdep.c: Revert.
6691         * amd64-nbsd-nat.c: Revert.
6692         * amd64-nat.c: Revert.
6693         * amd64-linux-tdep.c: Revert.
6694         * amd64-linux-nat.c: Revert.
6695         * amd64-fbsd-tdep.c: Revert.
6696         * amd64-fbsd-nat.c: Revert.
6697         * amd64-dicos-tdep.c: Revert.
6698         * amd64-darwin-tdep.c: Revert.
6699         * amd64-bsd-nat.c: Revert.
6700         * alpha-tdep.c: Revert.
6701         * alpha-obsd-tdep.c: Revert.
6702         * alpha-nbsd-tdep.c: Revert.
6703         * alpha-mdebug-tdep.c: Revert.
6704         * alpha-linux-tdep.c: Revert.
6705         * alpha-linux-nat.c: Revert.
6706         * alpha-bsd-tdep.c: Revert.
6707         * alpha-bsd-nat.c: Revert.
6708         * aix-thread.c: Revert.
6709         * agent.c: Revert.
6710         * addrmap.c: Revert.
6711         * ada-varobj.c: Revert.
6712         * ada-valprint.c: Revert.
6713         * ada-typeprint.c: Revert.
6714         * ada-tasks.c: Revert.
6715         * ada-lang.c: Revert.
6716         * aarch64-tdep.c: Revert.
6717         * aarch64-ravenscar-thread.c: Revert.
6718         * aarch64-newlib-tdep.c: Revert.
6719         * aarch64-linux-tdep.c: Revert.
6720         * aarch64-linux-nat.c: Revert.
6721         * aarch64-fbsd-tdep.c: Revert.
6722         * aarch64-fbsd-nat.c: Revert.
6723         * aarch32-linux-nat.c: Revert.
6724
6725 2019-04-05  Tom Tromey  <tom@tromey.com>
6726
6727         * ft32-tdep.c: Sort headers.
6728         * frv-tdep.c: Sort headers.
6729         * frv-linux-tdep.c: Sort headers.
6730         * frame.c: Sort headers.
6731         * frame-unwind.c: Sort headers.
6732         * frame-base.c: Sort headers.
6733         * fork-child.c: Sort headers.
6734         * findvar.c: Sort headers.
6735         * findcmd.c: Sort headers.
6736         * filesystem.c: Sort headers.
6737         * filename-seen-cache.h: Sort headers.
6738         * filename-seen-cache.c: Sort headers.
6739         * fbsd-tdep.c: Sort headers.
6740         * fbsd-nat.h: Sort headers.
6741         * fbsd-nat.c: Sort headers.
6742         * f-valprint.c: Sort headers.
6743         * f-typeprint.c: Sort headers.
6744         * f-lang.c: Sort headers.
6745         * extension.h: Sort headers.
6746         * extension.c: Sort headers.
6747         * extension-priv.h: Sort headers.
6748         * expprint.c: Sort headers.
6749         * exec.h: Sort headers.
6750         * exec.c: Sort headers.
6751         * exceptions.c: Sort headers.
6752         * event-top.c: Sort headers.
6753         * event-loop.c: Sort headers.
6754         * eval.c: Sort headers.
6755         * elfread.c: Sort headers.
6756         * dwarf2read.h: Sort headers.
6757         * dwarf2read.c: Sort headers.
6758         * dwarf2loc.c: Sort headers.
6759         * dwarf2expr.h: Sort headers.
6760         * dwarf2expr.c: Sort headers.
6761         * dwarf2-frame.c: Sort headers.
6762         * dwarf2-frame-tailcall.c: Sort headers.
6763         * dwarf-index-write.h: Sort headers.
6764         * dwarf-index-write.c: Sort headers.
6765         * dwarf-index-common.c: Sort headers.
6766         * dwarf-index-cache.h: Sort headers.
6767         * dwarf-index-cache.c: Sort headers.
6768         * dummy-frame.c: Sort headers.
6769         * dtrace-probe.c: Sort headers.
6770         * disasm.h: Sort headers.
6771         * disasm.c: Sort headers.
6772         * disasm-selftests.c: Sort headers.
6773         * dictionary.c: Sort headers.
6774         * dicos-tdep.c: Sort headers.
6775         * demangle.c: Sort headers.
6776         * dcache.h: Sort headers.
6777         * dcache.c: Sort headers.
6778         * darwin-nat.h: Sort headers.
6779         * darwin-nat.c: Sort headers.
6780         * darwin-nat-info.c: Sort headers.
6781         * d-valprint.c: Sort headers.
6782         * d-namespace.c: Sort headers.
6783         * d-lang.c: Sort headers.
6784         * ctf.c: Sort headers.
6785         * csky-tdep.c: Sort headers.
6786         * csky-linux-tdep.c: Sort headers.
6787         * cris-tdep.c: Sort headers.
6788         * cris-linux-tdep.c: Sort headers.
6789         * cp-valprint.c: Sort headers.
6790         * cp-support.c: Sort headers.
6791         * cp-namespace.c: Sort headers.
6792         * cp-abi.c: Sort headers.
6793         * corelow.c: Sort headers.
6794         * corefile.c: Sort headers.
6795         * continuations.c: Sort headers.
6796         * completer.h: Sort headers.
6797         * completer.c: Sort headers.
6798         * complaints.c: Sort headers.
6799         * coffread.c: Sort headers.
6800         * coff-pe-read.c: Sort headers.
6801         * cli-out.h: Sort headers.
6802         * cli-out.c: Sort headers.
6803         * charset.c: Sort headers.
6804         * c-varobj.c: Sort headers.
6805         * c-valprint.c: Sort headers.
6806         * c-typeprint.c: Sort headers.
6807         * c-lang.c: Sort headers.
6808         * buildsym.c: Sort headers.
6809         * buildsym-legacy.c: Sort headers.
6810         * build-id.h: Sort headers.
6811         * build-id.c: Sort headers.
6812         * btrace.c: Sort headers.
6813         * bsd-uthread.c: Sort headers.
6814         * breakpoint.h: Sort headers.
6815         * breakpoint.c: Sort headers.
6816         * break-catch-throw.c: Sort headers.
6817         * break-catch-syscall.c: Sort headers.
6818         * break-catch-sig.c: Sort headers.
6819         * blockframe.c: Sort headers.
6820         * block.c: Sort headers.
6821         * bfin-tdep.c: Sort headers.
6822         * bfin-linux-tdep.c: Sort headers.
6823         * bfd-target.c: Sort headers.
6824         * bcache.c: Sort headers.
6825         * ax-general.c: Sort headers.
6826         * ax-gdb.h: Sort headers.
6827         * ax-gdb.c: Sort headers.
6828         * avr-tdep.c: Sort headers.
6829         * auxv.c: Sort headers.
6830         * auto-load.c: Sort headers.
6831         * arm-wince-tdep.c: Sort headers.
6832         * arm-tdep.c: Sort headers.
6833         * arm-symbian-tdep.c: Sort headers.
6834         * arm-pikeos-tdep.c: Sort headers.
6835         * arm-obsd-tdep.c: Sort headers.
6836         * arm-nbsd-tdep.c: Sort headers.
6837         * arm-nbsd-nat.c: Sort headers.
6838         * arm-linux-tdep.c: Sort headers.
6839         * arm-linux-nat.c: Sort headers.
6840         * arm-fbsd-tdep.c: Sort headers.
6841         * arm-fbsd-nat.c: Sort headers.
6842         * arm-bsd-tdep.c: Sort headers.
6843         * arch-utils.c: Sort headers.
6844         * arc-tdep.c: Sort headers.
6845         * arc-newlib-tdep.c: Sort headers.
6846         * annotate.h: Sort headers.
6847         * annotate.c: Sort headers.
6848         * amd64-windows-tdep.c: Sort headers.
6849         * amd64-windows-nat.c: Sort headers.
6850         * amd64-tdep.c: Sort headers.
6851         * amd64-sol2-tdep.c: Sort headers.
6852         * amd64-obsd-tdep.c: Sort headers.
6853         * amd64-obsd-nat.c: Sort headers.
6854         * amd64-nbsd-tdep.c: Sort headers.
6855         * amd64-nbsd-nat.c: Sort headers.
6856         * amd64-nat.c: Sort headers.
6857         * amd64-linux-tdep.c: Sort headers.
6858         * amd64-linux-nat.c: Sort headers.
6859         * amd64-fbsd-tdep.c: Sort headers.
6860         * amd64-fbsd-nat.c: Sort headers.
6861         * amd64-dicos-tdep.c: Sort headers.
6862         * amd64-darwin-tdep.c: Sort headers.
6863         * amd64-bsd-nat.c: Sort headers.
6864         * alpha-tdep.c: Sort headers.
6865         * alpha-obsd-tdep.c: Sort headers.
6866         * alpha-nbsd-tdep.c: Sort headers.
6867         * alpha-mdebug-tdep.c: Sort headers.
6868         * alpha-linux-tdep.c: Sort headers.
6869         * alpha-linux-nat.c: Sort headers.
6870         * alpha-bsd-tdep.c: Sort headers.
6871         * alpha-bsd-nat.c: Sort headers.
6872         * aix-thread.c: Sort headers.
6873         * agent.c: Sort headers.
6874         * addrmap.c: Sort headers.
6875         * ada-varobj.c: Sort headers.
6876         * ada-valprint.c: Sort headers.
6877         * ada-typeprint.c: Sort headers.
6878         * ada-tasks.c: Sort headers.
6879         * ada-lang.c: Sort headers.
6880         * aarch64-tdep.c: Sort headers.
6881         * aarch64-ravenscar-thread.c: Sort headers.
6882         * aarch64-newlib-tdep.c: Sort headers.
6883         * aarch64-linux-tdep.c: Sort headers.
6884         * aarch64-linux-nat.c: Sort headers.
6885         * aarch64-fbsd-tdep.c: Sort headers.
6886         * aarch64-fbsd-nat.c: Sort headers.
6887         * aarch32-linux-nat.c: Sort headers.
6888
6889 2019-04-04  Tom Tromey  <tom@tromey.com>
6890
6891         * varobj.c (varobj_create): Update.
6892         * rust-exp.y (struct rust_parser) <update_innermost_block,
6893         lookup_symbol>: New methods.
6894         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6895         Rename.
6896         (rust_parser::rust_lookup_type)
6897         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6898         * printcmd.c (display_command, do_one_display): Update.
6899         * parser-defs.h (struct parser_state) <parser_state>: Add
6900         "tracker" parameter.
6901         (block_tracker): New member.
6902         (class innermost_block_tracker) <innermost_block_tracker>: Add
6903         "types" parameter.
6904         <reset>: Remove method.
6905         (innermost_block): Don't declare.
6906         (null_post_parser): Update.
6907         * parse.c (innermost_block): Remove global.
6908         (write_dollar_variable): Update.
6909         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6910         Remove "tracker_types" parameter.
6911         (parse_expression): Add "tracker" parameter.
6912         (parse_expression_for_completion): Update.
6913         (null_post_parser): Add "tracker" parameter.
6914         * p-exp.y: Update rules.
6915         * m2-exp.y: Update rules.
6916         * language.h (struct language_defn) <la_post_parser>: Add
6917         "tracker" parameter.
6918         * go-exp.y: Update rules.
6919         * f-exp.y: Update rules.
6920         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6921         parameter.
6922         * d-exp.y: Update rules.
6923         * c-exp.y: Update rules.
6924         * breakpoint.c (set_breakpoint_condition): Create an
6925         innermost_block_tracker.
6926         (watch_command_1): Likewise.
6927         * ada-lang.c (resolve): Add "tracker" parameter.
6928         (resolve_subexp): Likewise.
6929         * ada-exp.y (write_var_from_sym): Update.
6930
6931 2019-04-04  Tom Tromey  <tom@tromey.com>
6932
6933         * type-stack.h: New file.
6934         * type-stack.c: New file.
6935         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6936         type-stack.h.
6937         (insert_into_type_stack, insert_type, push_type, push_type_int)
6938         (insert_type_address_space, pop_type, pop_type_int)
6939         (pop_typelist, pop_type_stack, append_type_stack)
6940         (push_type_stack, get_type_stack, push_typelist)
6941         (follow_type_instance_flags, follow_types): Don't declare.
6942         * parse.c (type_stack): Remove global.
6943         (parse_exp_in_context): Update.
6944         (insert_into_type_stack, insert_type, push_type, push_type_int)
6945         (insert_type_address_space, pop_type, pop_type_int)
6946         (pop_typelist, pop_type_stack, append_type_stack)
6947         (push_type_stack, get_type_stack, push_typelist)
6948         (follow_type_instance_flags, follow_types): Remove (moved to
6949         type-stack.c).
6950         * f-exp.y (type_stack): New global.
6951         Update rules.
6952         (push_kind_type, f_parse): Update.
6953         * d-exp.y (type_stack): New global.
6954         Update rules.
6955         (d_parse): Update.
6956         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6957         Update rules.
6958         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6959         (HFILES_NO_SRCDIR): Add type-stack.h.
6960
6961 2019-04-04  Tom Tromey  <tom@tromey.com>
6962
6963         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6964         (rust_parser::convert_ast_to_expression, rust_parse)
6965         (rust_lex_test_completion, rust_lex_tests): Update.
6966         * parser-defs.h (struct expr_completion_state): New.
6967         (struct parser_state) <parser_state>: Add completion parameter.
6968         <mark_struct_expression, mark_completion_tag>: New methods.
6969         <parse_completion, m_completion_state>: New members.
6970         (prefixify_expression, null_post_parser): Update.
6971         (mark_struct_expression, mark_completion_tag): Don't declare.
6972         * parse.c (parse_completion, expout_last_struct)
6973         (expout_tag_completion_type, expout_completion_name): Remove
6974         globals.
6975         (parser_state::mark_struct_expression)
6976         (parser_state::mark_completion_tag): Now methods.
6977         (prefixify_expression): Add last_struct parameter.
6978         (prefixify_subexp): Likewise.
6979         (parse_exp_1): Update.
6980         (parse_exp_in_context): Add cstate parameter.  Update.
6981         (parse_expression_for_completion): Create an
6982         expr_completion_state.
6983         (null_post_parser): Add "completion" parameter.
6984         * p-exp.y: Update rules.
6985         (yylex): Update.
6986         * language.h (struct language_defn) <la_post_parser>: Add
6987         "completing" parameter.
6988         * go-exp.y: Update rules.
6989         (lex_one_token): Update.
6990         * expression.h (parse_completion): Don't declare.
6991         * d-exp.y: Update rules.
6992         (lex_one_token): Update rules.
6993         * c-exp.y: Update rules.
6994         (lex_one_token): Update.
6995         * ada-lang.c (resolve): Add "parse_completion" parameter.
6996         (resolve_subexp): Likewise.
6997         (ada_resolve_function): Likewise.
6998
6999 2019-04-04  Tom Tromey  <tom@tromey.com>
7000
7001         * parser-defs.h (struct parser_state) <start_arglist,
7002         end_arglist>: New methods.
7003         <arglist_len, m_funcall_chain>: New members.
7004         (arglist_len, start_arglist, end_arglist): Don't declare.
7005         * parse.c (arglist_len, funcall_chain): Remove global.
7006         (start_arglist, end_arglist): Remove functions.
7007         (parse_exp_in_context): Update.
7008         * p-exp.y: Update rules.
7009         * m2-exp.y: Update rules.
7010         * go-exp.y: Update rules.
7011         * f-exp.y: Update rules.
7012         * d-exp.y: Update rules.
7013         * c-exp.y: Update rules.
7014
7015 2019-04-04  Tom Tromey  <tom@tromey.com>
7016
7017         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7018         lex_operator, push_back>: New methods.
7019         Update all rules.
7020         (rust_parser::lex_hex, lex_escape): Rename and update.
7021         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7022         (rust_parser::lex_operator): Rename and update.
7023         (rust_parser::lex_number, rustyylex, rustyyerror)
7024         (rust_lex_test_init, rust_lex_test_sequence)
7025         (rust_lex_test_push_back, rust_lex_tests): Update.
7026         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7027         parameter.
7028         <lexptr, prev_lexptr>: New members.
7029         (lexptr, prev_lexptr): Don't declare.
7030         * parse.c (lexptr, prev_lexptr): Remove globals.
7031         (parse_exp_in_context): Update.
7032         * p-exp.y (yylex, yyerror): Update.
7033         * m2-exp.y (parse_number, yylex, yyerror): Update.
7034         * go-exp.y (lex_one_token, yyerror): Update.
7035         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7036         * d-exp.y (lex_one_token, yyerror): Update.
7037         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7038         (lex_one_token, yyerror): Update.
7039         * ada-lex.l (YY_INPUT): Update.
7040         (rewind_to_char): Update.
7041         * ada-exp.y (yyerror): Update.
7042
7043 2019-04-04  Tom Tromey  <tom@tromey.com>
7044
7045         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7046         * parser-defs.h (struct parser_state) <parser_state>: Add new
7047         parameter.
7048         <comma_terminates>: New member.
7049         (comma_terminates): Don't declare global.
7050         * parse.c (comma_terminates): Remove global.
7051         (parse_exp_in_context): Update.
7052         * p-exp.y (yylex): Update.
7053         * m2-exp.y (yylex): Update.
7054         * go-exp.y (lex_one_token): Update.
7055         * f-exp.y (yylex): Update.
7056         * d-exp.y (lex_one_token): Update.
7057         * c-exp.y (lex_one_token): Update.
7058         * ada-lex.l: Update.
7059
7060 2019-04-04  Tom Tromey  <tom@tromey.com>
7061
7062         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7063         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7064         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7065         * parser-defs.h (paren_depth): Don't declare.
7066         * parse.c (paren_depth): Remove global.
7067         (parse_exp_in_context): Update.
7068         * p-exp.y (paren_depth): New global.
7069         (pascal_parse): Initialize it.
7070         * m2-exp.y (paren_depth): New global.
7071         (m2_parse): Initialize it.
7072         * go-exp.y (paren_depth): New global.
7073         (go_parse): Initialize it.
7074         * f-exp.y (paren_depth): New global.
7075         (f_parse): Initialize it.
7076         * d-exp.y (paren_depth): New global.
7077         (d_parse): Initialize it.
7078         * c-exp.y (paren_depth): New global.
7079         (c_parse): Initialize it.
7080         * ada-lex.l (paren_depth): New global.
7081         (lexer_init): Initialize it.
7082
7083 2019-04-04  Tom Tromey  <tom@tromey.com>
7084
7085         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7086         (rust_parser::convert_ast_to_type)
7087         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7088         * parser-defs.h (struct parser_state) <parser_state>: Add
7089         parameters.  Initialize new members.
7090         <expression_context_block, expression_context_pc>: New members.
7091         * parse.c (expression_context_block, expression_context_pc):
7092         Remove globals.
7093         (parse_exp_in_context): Update.
7094         * p-exp.y: Update all rules.
7095         (yylex): Update.
7096         * m2-exp.y: Update all rules.
7097         (yylex): Update.
7098         * go-exp.y (yylex): Update.
7099         * f-exp.y (yylex): Update.
7100         * d-exp.y: Update all rules.
7101         (yylex): Update.
7102         * c-exp.y: Update all rules.
7103         (lex_one_token, classify_name, yylex, c_parse): Update.
7104         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7105
7106 2019-04-04  Tom Tromey  <tom@tromey.com>
7107
7108         * gdbarch.h, gdbarch.c: Rebuild.
7109         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7110         * stap-probe.h:
7111         (struct stap_parse_info): Replace "parser_state" with
7112         "expr_builder".
7113         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7114         (parser_state): New class.
7115         * parse.c (expr_builder): Rename.
7116         (expr_builder::release): Rename.
7117         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7118         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7119         (write_exp_elt_longcst, write_exp_elt_floatcst)
7120         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7121         (write_exp_string_vector, write_exp_bitstring)
7122         (write_exp_msymbol, mark_struct_expression)
7123         (write_dollar_variable)
7124         (insert_type_address_space, increase_expout_size): Replace
7125         "parser_state" with "expr_builder".
7126         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7127         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7128         "parser_state" with "expr_builder".
7129
7130 2019-04-04  Tom Tromey  <tom@tromey.com>
7131
7132         * rust-exp.y: Replace "parse_language" with method call.
7133         * p-exp.y:
7134         (yylex): Replace "parse_language" with method call.
7135         * m2-exp.y:
7136         (yylex): Replace "parse_language" with method call.
7137         * go-exp.y (classify_name): Replace "parse_language" with method
7138         call.
7139         * f-exp.y (yylex): Replace "parse_language" with method call.
7140         * d-exp.y (lex_one_token): Replace "parse_language" with method
7141         call.
7142         * c-exp.y:
7143         (lex_one_token, classify_name, yylex): Replace "parse_language"
7144         with method call.
7145         * ada-exp.y (find_primitive_type, type_char)
7146         (type_system_address): Replace "parse_language" with method call.
7147
7148 2019-04-04  Tom Tromey  <tom@tromey.com>
7149
7150         * rust-exp.y: Replace "parse_gdbarch" with method call.
7151         * parse.c (write_dollar_variable, insert_type_address_space):
7152         Replace "parse_gdbarch" with method call.
7153         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7154         call.
7155         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7156         call.
7157         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7158         "parse_gdbarch" with method call.
7159         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7160         with method call.
7161         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7162         "parse_gdbarch" with method call.
7163         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7164         "parse_gdbarch" with method call.
7165         * c-exp.y (parse_type, parse_number, classify_name): Replace
7166         "parse_gdbarch" with method call.
7167         * ada-lex.l: Replace "parse_gdbarch" with method call.
7168         * ada-exp.y (parse_type, find_primitive_type, type_char)
7169         (type_system_address): Replace "parse_gdbarch" with method call.
7170
7171 2019-04-04  Tom Tromey  <tom@tromey.com>
7172
7173         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7174         * stap-probe.c (stap_parse_argument): Update.
7175         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7176         initial_size parameter.
7177         * rust-exp.y (rust_lex_tests): Update.
7178         * parse.c (parser_state): Update.
7179         (parse_exp_in_context): Update.
7180         * parser-defs.h (struct parser_state) <parser_state>: Remove
7181         "initial_size" parameter.
7182
7183 2019-04-04  Tom Tromey  <tom@tromey.com>
7184
7185         * parser-defs.h (increase_expout_size): Don't declare.
7186         * parse.c (increase_expout_size): Now static.
7187
7188 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7189
7190         * gnu-nat.c (gnu_nat_target::wait): Fix
7191         target_waitstatus_to_string call.
7192
7193 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7194
7195         * eval.c (evaluate_subexp_standard): Handle internal functions
7196         during Fortran function call handling.
7197
7198 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7199
7200         * NEWS: Mention new internal functions.
7201         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7202         (read_base_type): Use dwarf2_init_complex_target_type.
7203         * value.c (creal_internal_fn): New function.
7204         (cimag_internal_fn): New function.
7205         (_initialize_values): Register new internal functions.
7206
7207 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7208
7209         * infrun.c (stop_all_threads): If debug_infrun, always
7210         trace the wait status after wait_one, using
7211         target_waitstatus_to_string and target_pid_to_str.
7212         (handle_inferior_event): Replace various trace of
7213         wait status kind by a single trace.
7214         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7215         wait status kind image by target_waitstatus_to_string.
7216         * target/waitstatus.c (target_waitstatus_to_string): Fix
7217         obsolete comment.
7218
7219 2019-04-01  Tom Tromey  <tromey@adacore.com>
7220
7221         PR symtab/23331:
7222         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7223
7224 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7225             Pedro Alves  <palves@redhat.com>
7226
7227         * top.c (quit_force): Call 'finalize_values'.
7228         * value.c (finalize_values): New function.
7229         * value.h (finalize_values): Declare.
7230
7231 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7232
7233         * NEWS: Announce $_gdb_major and $_gdb_minor.
7234
7235         * top.c (init_gdb_version_vars): New function.
7236         (gdb_init): Call init_gdb_version_vars.
7237
7238 2019-03-29  Tom Tromey  <tromey@adacore.com>
7239
7240         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7241         help text.  Remove dead code.
7242
7243 2019-03-29  Keith Seitz  <keiths@redhat.com>
7244
7245         From Siddhesh Poyarekar:
7246         * f-lang.h (f77_get_upperbound): Return LONGEST.
7247         (f77_get_lowerbound): Likewise.
7248         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7249         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7250         print them.
7251         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7252         plongest to format print it.
7253         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7254         (f77_get_upperbound): Likewise.
7255         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7256         LOWER_BOUND to LONGEST.
7257         (f77_create_arrayprint_offset_tbl): Likewise.
7258
7259 2019-03-29  Keith Seitz  <keiths@redhat.com>
7260
7261         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7262         %s/pulongest for TYPE_LENGTH instead of %d in format
7263         strings.
7264         * ada-typerint.c (ada_print_type): Likewise.
7265         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7266         * compile/compile-c-support.c (generate_register_struct): Likewise.
7267         * gdbtypes.c (recursive_dump_type): Likewise.
7268         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7269         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7270         instead of %d in format strings.
7271         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7272         to std::min to ULONGEST.
7273         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7274         instead of %d in format strings.
7275         * tracepoint.c (info_scope_command): Likewise.
7276         * typeprint.c (print_offset_data::update)
7277         (print_offset_data::finish): Likewise.
7278         * xtensa-tdep.c (xtensa_store_return_value)
7279         (xtensa_push_dummy_call): Likewise.
7280
7281 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7282
7283         * windows-nat.c (display_selector): Fixed format specifications
7284         for 64-bit Cygwin.
7285
7286 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7287
7288         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7289
7290 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7291
7292         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7293         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7294         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7295         (nios2_linux_init_abi): Install it.
7296
7297 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7298
7299         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7300
7301 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7302
7303         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7304
7305 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7306             Tom Tromey  <tromey@adacore.com>
7307
7308         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7309
7310 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7311
7312         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7313         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7314         method to compute the bounds of range types. Also print "[evaluated]"
7315         if the bounds' values come from a dynamic evaluation.
7316
7317 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7318
7319         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7320         whitespace when pretty printing is on.
7321
7322 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7323
7324         * ppc-linux-nat.c: Add include.
7325
7326 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7327
7328         * NEWS: Mention AArch64 Pointer Authentication.
7329
7330 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7331
7332         * arm-linux-nat.c: Add include.
7333
7334 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7335
7336         * source-cache.c (source_cache::get_source_lines): Re-read
7337         fullname after calling open_source_file.
7338
7339 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7340
7341         * NEWS: Mention TLS support for FreeBSD.
7342
7343 2019-03-25  Tom Tromey  <tromey@adacore.com>
7344
7345         * minsyms.c (BUNCH_SIZE): Update comment.
7346         (~minimal_symbol_reader): Remove old comment.
7347         (compact_minimal_symbols): Update comment.
7348         (minimal_symbol_reader::install): Remove old comment.  Update
7349         other comments.
7350
7351 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7352
7353         * s390-linux-nat.c: Add include.
7354
7355 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7356
7357         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7358         Call linux_get_hwcap.
7359         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7360         Likewise.
7361         (aarch64_linux_get_hwcap): Remove function.
7362         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7363         declaration.
7364         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7365         linux_get_hwcap.
7366         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7367         * linux-tdep.c (linux_get_hwcap): Add function.
7368         (linux_get_hwcap2): Likewise.
7369         * linux-tdep.h (linux_get_hwcap): Add declaration.
7370         (linux_get_hwcap2): Likewise.
7371         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7372         (ppc_linux_get_hwcap2): Likewise.
7373         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7374         linux_get_hwcap.
7375         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7376         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7377         (ppc_linux_nat_target::read_description): Likewise.
7378         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7379         * s390-linux-nat.c: Likewise.
7380         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7381
7382 2019-03-24  Tom Tromey  <tom@tromey.com>
7383
7384         * ada-lang.c (standard_lookup): Simplify initialization.
7385         (ada_lookup_symbol_nonlocal): Simplify return.
7386         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7387         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7388         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7389         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7390         initialization.
7391         * solib.c (solib_global_lookup): Simplify.
7392         * symtab.c (null_block_symbol): Remove.
7393         (symbol_cache_lookup): Simplify returns.
7394         (lookup_language_this): Simplify returns.
7395         (lookup_symbol_aux): Simplify return.
7396         (lookup_local_symbol): Simplify returns.
7397         (lookup_global_symbol_from_objfile): Simplify return.
7398         (lookup_symbol_in_objfile_symtabs)
7399         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7400         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7401         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7402         * cp-namespace.c (cp_lookup_bare_symbol)
7403         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7404         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7405         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7406         (cp_lookup_symbol_via_imports): Simplify initialization.
7407         (find_symbol_in_baseclass): Likewise.
7408         * symtab.h (null_block_symbol): Remove.
7409         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7410         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7411         (d_lookup_symbol_module): Likewise.
7412         (find_symbol_in_baseclass): Simplify initialization.
7413
7414 2019-03-24  Tom Tromey  <tom@tromey.com>
7415
7416         * expression.h: Don't include symtab.h.
7417         (struct block): Forward declare.
7418
7419 2019-03-24  Tom Tromey  <tom@tromey.com>
7420
7421         * c-exp.y (typebase): Remove casts.
7422         * gdbtypes.c (lookup_unsigned_typename, )
7423         (lookup_signed_typename): Remove cast.
7424         * eval.c (parse_to_comma_and_eval): Remove cast.
7425         * parse.c (write_dollar_variable): Remove cast.
7426         * block.h (struct block) <superblock>: Now const.
7427         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7428         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7429         (map_block): Make "block" const.
7430         * symfile.h (struct quick_symbol_functions)
7431         <map_matching_symbols>: Constify block argument to "callback".
7432         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7433         const.
7434         (find_pc_sect_compunit_symtab): Make "b" const.
7435         (find_symbol_at_address): Likewise.
7436         (search_symbols): Likewise.
7437         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7438         (dw2_debug_names_lookup_symbol): Likewise.
7439         (dw2_map_matching_symbols): Update.
7440         * p-valprint.c (pascal_val_print): Remove "block".
7441         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7442         (aux_add_nonlocal_symbols): Make "block" const.
7443         (resolve_subexp): Remove cast.
7444         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7445         const.
7446         (iterate_over_file_blocks): Likewise.
7447         * f-exp.y (%union) <bval>: Remove.
7448         * coffread.c (patch_opaque_types): Make "b" const.
7449         * spu-tdep.c (spu_catch_start): Make "block" const.
7450         * c-valprint.c (print_unpacked_pointer): Remove "block".
7451         * symmisc.c (dump_symtab_1): Make "b" const.
7452         (block_depth): Make "block" const.
7453         * d-exp.y (%union) <bval>: Remove.
7454         * cp-support.h (cp_lookup_rtti_type): Update.
7455         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7456         * psymtab.c (psym_lookup_symbol): Make "block" const.
7457         (maintenance_check_psymtabs): Make "b" const.
7458         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7459         (enumerate_locals, enumerate_args): Update.
7460         * python/py-symtab.c (stpy_global_block): Make "block" const.
7461         (stpy_static_block): Likewise.
7462         * inline-frame.c (block_starting_point_at): Make "new_block"
7463         const.
7464         * block.c (find_block_in_blockvector): Make return type const.
7465         (blockvector_for_pc_sect): Make "b" const.
7466         (find_block_in_blockvector): Make "b" const.
7467
7468 2019-03-23  Tom Tromey  <tom@tromey.com>
7469
7470         * varobj.c (varobj_create): Update.
7471         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7472         * printcmd.c (display_command, do_one_display): Don't reset
7473         innermost_block.
7474         * parser-defs.h (enum innermost_block_tracker_type): Move to
7475         expression.h.
7476         (innermost_block): Update comment.
7477         * parse.c (parse_exp_1): Add tracker_types parameter.
7478         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7479         tracker_types parameter.  Reset innermost_block.
7480         (parse_exp_in_context): Remove.
7481         (parse_expression_for_completion): Update.
7482         * objfiles.c (~objfile): Don't reset expression_context_block or
7483         innermost_block.
7484         * expression.h (enum innermost_block_tracker_type): Move from
7485         parser-defs.h.
7486         (parse_exp_1): Add tracker_types parameter.
7487         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7488         reset innermost_block.
7489
7490 2019-03-23  Tom Tromey  <tom@tromey.com>
7491
7492         * objfiles.h: Include bcache.h.
7493
7494 2019-03-23  Tom Tromey  <tom@tromey.com>
7495
7496         * linespec.c (get_current_search_block): Use
7497         scoped_restore_current_language.
7498         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7499
7500 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7501             Jiong Wang  <jiong.wang@arm.com>
7502
7503         * aarch64-linux-tdep.c
7504         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7505         section.
7506         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7507
7508 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7509             Jiong Wang  <jiong.wang@arm.com>
7510
7511         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7512         instructions.
7513         (aarch64_analyze_prologue_test): Add PACIASP test.
7514         (aarch64_prologue_prev_register): Unmask PC value.
7515
7516 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7517             Jiong Wang  <jiong.wang@arm.com>
7518
7519         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7520         (aarch64_dwarf2_prev_register): Unmask PC value.
7521         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7522         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7523         DW_CFA_AARCH64_negate_ra_state.
7524         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7525
7526 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7527             Jiong Wang  <jiong.wang@arm.com>
7528
7529         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7530         registers.
7531         (aarch64_pseudo_register_name): Likewise.
7532         (aarch64_pseudo_register_type): Likewise.
7533         (aarch64_pseudo_register_reggroup_p): Likewise.
7534         (aarch64_gdbarch_init): Add pauth registers.
7535         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7536         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7537         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7538         (struct gdbarch_tdep): Add regnum for ra_state.
7539
7540 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7541             Jiong Wang  <jiong.wang@arm.com>
7542
7543         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7544
7545 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7546             Jiong Wang  <jiong.wang@arm.com>
7547
7548         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7549         function.
7550         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7551         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7552         (aarch64_gdbarch_init): Add puth registers.
7553         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7554         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7555         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7556
7557 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7558             Jiong Wang  <jiong.wang@arm.com>
7559
7560         * aarch64-linux-nat.c
7561         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7562         * aarch64-linux-tdep.c
7563         (aarch64_linux_core_read_description): Likewise.
7564         (aarch64_linux_get_hwcap): New function.
7565         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7566         (aarch64_linux_get_hwcap): New declaration.
7567
7568 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7569             Jiong Wang  <jiong.wang@arm.com>
7570
7571         * aarch64-linux-nat.c
7572         (aarch64_linux_nat_target::read_description): Add pauth param.
7573         * aarch64-linux-tdep.c
7574         (aarch64_linux_core_read_description): Likewise.
7575         * aarch64-tdep.c (struct target_desc): Add in pauth.
7576         (aarch64_read_description): Add pauth param.
7577         (aarch64_gdbarch_init): Likewise.
7578         * aarch64-tdep.h (aarch64_read_description): Likewise.
7579         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7580         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7581         * features/Makefile: Add new files.
7582         * features/aarch64-pauth.c: New file.
7583         * features/aarch64-pauth.xml: New file.
7584
7585 2019-03-20  Tom Tromey  <tromey@adacore.com>
7586
7587         * infrun.c (handle_inferior_event): Rename from
7588         handle_inferior_event_1.  Create a scoped_value_mark.
7589         (handle_inferior_event): Remove.
7590
7591 2019-03-19  Tom Tromey  <tromey@adacore.com>
7592
7593         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7594         * infrun.h (print_stop_event): Add "displays" parameter.
7595         * infrun.c (print_stop_event): Add "displays" parameter.
7596
7597 2019-03-19  Pedro Alves  <palves@redhat.com>
7598
7599         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7600         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7601         to -1.  Fix TABs vs spaces.
7602         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7603         * tui/tui-out.h (tui_ui_out) Add intro comments.
7604         <m_line, m_start_of_line>: In-class initialize, and add describing
7605         comment.
7606
7607 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7608
7609         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7610         variable names.
7611         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7612
7613 2019-03-18  Pedro Alves  <palves@redhat.com>
7614             Eli Zaretskii <eliz@gnu.org>
7615
7616         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7617         m_line and m_start_of_line.
7618
7619 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7620
7621         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7622         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7623         it returns a newline.  This fixes a regression in TU mode, whereby
7624         the next line is output on the same screen line as the user input.
7625
7626 2019-03-18  Tom Tromey  <tromey@adacore.com>
7627
7628         * minsyms.c (minimal_symbol_reader::install): Remove call to
7629         obstack_blank.
7630
7631 2019-03-18  Pedro Alves  <palves@redhat.com>
7632
7633         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7634         New globals.
7635         (apply_style): New, factored out from ...
7636         (apply_ansi_escape): ... this.  Handle reverse video mode.
7637         (tui_set_reverse_mode): New function.
7638         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7639         * tui/tui-winsource.c (tui_show_source_line): Use
7640         tui_set_reverse_mode instead of setting A_STANDOUT.
7641         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7642         New setter methods.
7643
7644 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7645
7646         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7647         Handle tabs.
7648
7649 2019-03-18  Tom Tromey  <tromey@adacore.com>
7650
7651         * ada-lang.c (empty_array): Add "high" parameter.
7652         (ada_evaluate_subexp): Update.
7653
7654 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7655
7656         * unittests/string_view-selftests.c: Define
7657         _initialize_string_view_selftests unconditionally.
7658
7659 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7660
7661         PR gdb/24350
7662         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7663
7664 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7665
7666         PR gdb/24351
7667         * windows-nat.c (display_selector): Fix format specifiers.
7668
7669 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7670
7671         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7672         tui_refill_source_window instead of tui_refresh_win, to update the
7673         current execution line.  This fixes redisplay of the current line
7674         when stepping through the code with "next" or "step".
7675
7676 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7677
7678         * source-cache.c (source_cache::get_source_lines): Call
7679         find_source_lines to initialize s->nlines.  This fixes vertical
7680         scrolling of TUI source window when the DOWN arrow is pressed.
7681
7682 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7683
7684         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7685         linux-thread-db.c (_initialize_thread_db): Likewise.
7686
7687 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7688
7689         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7690         wclrtoeol in tui_show_source_line".  This reverts changes made in
7691         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7692
7693 2019-03-15  Tom Tromey  <tom@tromey.com>
7694
7695         * symtab.h (struct minimal_symbol): Derive from
7696         general_symbol_info.
7697         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7698         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7699         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7700         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7701         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7702         (MSYMBOL_SEARCH_NAME): Update.
7703         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7704         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7705         * minsyms.c (minimal_symbol_reader::record_full): Update.
7706
7707 2019-03-15  Tom Tromey  <tom@tromey.com>
7708
7709         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7710
7711 2019-03-15  Tom Tromey  <tom@tromey.com>
7712
7713         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7714         unique_xmalloc_ptr.
7715         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7716         Update.
7717         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7718         (build_minimal_symbol_hash_tables)
7719         (minimal_symbol_reader::install): Update.
7720
7721 2019-03-15  Tom Tromey  <tom@tromey.com>
7722
7723         * symtab.c (create_demangled_names_hash): Update.
7724         (symbol_set_names): Update.
7725         * objfiles.h (struct objfile_per_bfd_storage)
7726         <demangled_names_hash>: Now an htab_up.
7727         * objfiles.c (objfile_per_bfd_storage): Simplify.
7728
7729 2019-03-15  Tom Tromey  <tom@tromey.com>
7730
7731         * objfiles.h (struct objfile_per_bfd_storage): Declare
7732         destructor.
7733         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7734         New.
7735         (get_objfile_bfd_data): Use new.  Don't initialize
7736         language_of_main.
7737         (free_objfile_per_bfd_storage): Remove.
7738         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7739
7740 2019-03-15  Tom Tromey  <tom@tromey.com>
7741
7742         * symfile.c (reread_symbols): Update.
7743         * objfiles.c (objfile::objfile): Update.
7744         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7745         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7746         comment.
7747         (minimal_symbol_reader::install): Update.
7748         (terminate_minimal_symbol_table): Remove.
7749         * jit.c (jit_object_close_impl): Update.
7750
7751 2019-03-15  Tom Tromey  <tom@tromey.com>
7752
7753         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7754         initializations.
7755
7756 2019-03-15  Tom Tromey  <tom@tromey.com>
7757
7758         * objfiles.h (struct objfile_per_bfd_storage)
7759         <demangled_hash_languages>: Now a bitset.
7760         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7761         (lookup_minimal_symbol): Update.
7762
7763 2019-03-15  Tom Tromey  <tom@tromey.com>
7764
7765         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7766         Don't return the symbol.
7767         * coffread.c (record_minimal_symbol): Use record_full.
7768
7769 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7770
7771         The MS-Windows port of ncurses fails to switch to a color pair if
7772         one or both of the colors are the implicit default colors.  This
7773         change records the default colors when TUI is initialized, and
7774         then specifies them explicitly when a color pair uses the default
7775         colors.  This allows color styling in TUI mode on MS-Windows.
7776
7777         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7778         ncurses_norm_attr.
7779         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7780         colors in ncurses_norm_attr.
7781         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7782         "none", replace it with the default color recorded in
7783         ncurses_norm_attr.
7784
7785 2019-03-14  Tom Tromey  <tromey@adacore.com>
7786
7787         * source-cache.h (class source_cache) <get_source_lines>: Return
7788         std::string.
7789         * source-cache.c (source_cache::extract_lines): Handle case where
7790         first_pos==npos.  Return std::string.
7791         (source_cache::get_source_lines): Update.
7792
7793 2019-03-14  Tom Tromey  <tromey@adacore.com>
7794
7795         * NEWS: Add item for "style sources" commands.
7796         * source-cache.c (source_cache::get_source_lines): Check
7797         source_styling.
7798         * cli/cli-style.c (source_styling): New global.
7799         (_initialize_cli_style): Add "style sources" commands.
7800         (show_style_sources): New function.
7801         * cli/cli-style.h (source_styling): Declare.
7802
7803 2019-03-14  Pedro Alves  <palves@redhat.com>
7804             Tom Tromey  <tromey@adacore.com>
7805
7806         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7807         * tui/tui-winsource.c (tui_refill_source_window): New function,
7808         from...
7809         (tui_horizontal_source_scroll): ... here.  Move some logic.
7810         * cli/cli-style.c (set_style_enabled): Notify new observable.
7811         * tui/tui-hooks.c (tui_redisplay_source): New function.
7812         (tui_attach_detach_observers): Attach or detach
7813         tui_redisplay_source.
7814         * observable.h (source_styling_changed): New observable.
7815         * observable.c: Define source_styling_changed observable.
7816
7817 2019-03-13  Tom Tromey  <tromey@adacore.com>
7818
7819         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7820         (i386_gnu_nat_target::store_registers): Update.
7821         * target-debug.h (target_debug_print_std_string): New macro.
7822         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7823         * windows-tdep.c (display_one_tib): Update.
7824         * tui/tui-stack.c (tui_make_status_line): Update.
7825         * top.c (print_inferior_quit_action): Update.
7826         * thread.c (thr_try_catch_cmd): Update.
7827         (add_thread_with_info): Update.
7828         (thread_target_id_str): Update.
7829         (thr_try_catch_cmd): Update.
7830         (thread_command): Update.
7831         (thread_find_command): Update.
7832         * record-btrace.c (record_btrace_target::info_record)
7833         (record_btrace_resume_thread, record_btrace_target::resume)
7834         (record_btrace_cancel_resume, record_btrace_step_thread)
7835         (record_btrace_target::wait, record_btrace_target::wait)
7836         (record_btrace_target::wait, record_btrace_target::stop): Update.
7837         * progspace.c (print_program_space): Update.
7838         * process-stratum-target.c
7839         (process_stratum_target::thread_address_space): Update.
7840         * linux-fork.c (linux_fork_mourn_inferior)
7841         (detach_checkpoint_command, info_checkpoints_command)
7842         (linux_fork_context): Update.
7843         (linux_fork_detach): Update.
7844         (class scoped_switch_fork_info): Update.
7845         (delete_checkpoint_command): Update.
7846         * infrun.c (follow_fork_inferior): Update.
7847         (follow_fork_inferior): Update.
7848         (proceed_after_vfork_done): Update.
7849         (handle_vfork_child_exec_or_exit): Update.
7850         (follow_exec): Update.
7851         (displaced_step_prepare_throw): Update.
7852         (displaced_step_restore): Update.
7853         (start_step_over): Update.
7854         (resume_1): Update.
7855         (clear_proceed_status_thread): Update.
7856         (proceed): Update.
7857         (print_target_wait_results): Update.
7858         (do_target_wait): Update.
7859         (context_switch): Update.
7860         (stop_all_threads): Update.
7861         (restart_threads): Update.
7862         (finish_step_over): Update.
7863         (handle_signal_stop): Update.
7864         (switch_back_to_stepped_thread): Update.
7865         (keep_going_pass_signal): Update.
7866         (print_exited_reason): Update.
7867         (normal_stop): Update.
7868         * inferior.c (inferior_pid_to_str): Change return type.
7869         (print_selected_inferior): Update.
7870         (add_inferior): Update.
7871         (detach_inferior): Update.
7872         * dummy-frame.c (fprint_dummy_frames): Update.
7873         * dcache.c (dcache_info_1): Update.
7874         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7875         (btrace_fetch, btrace_clear): Update.
7876         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7877         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7878         type.
7879         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7880         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7881         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7882         * gdbarch.c, gdbarch.h: Rebuild.
7883         * gdbarch.sh (core_pid_to_str): Change return type.
7884         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7885         return type.
7886         (windows_nat_target::pid_to_str): Change return type.
7887         (windows_delete_thread): Update.
7888         (windows_nat_target::attach): Update.
7889         (windows_nat_target::files_info): Update.
7890         * target-delegates.c: Rebuild.
7891         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7892         return type.
7893         (sol_thread_target::pid_to_str): Change return type.
7894         * remote.c (class remote_target) <pid_to_str>: Change return
7895         type.
7896         (remote_target::pid_to_str): Change return type.
7897         (extended_remote_target::attach, remote_target::remote_stop_ns)
7898         (remote_target::remote_notif_remove_queued_reply)
7899         (remote_target::push_stop_reply, remote_target::disable_btrace):
7900         Update.
7901         (extended_remote_target::attach): Update.
7902         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7903         type.
7904         (gdbsim_target::pid_to_str): Change return type.
7905         * ravenscar-thread.c (struct ravenscar_thread_target)
7906         <pid_to_str>: Change return type.
7907         (ravenscar_thread_target::pid_to_str): Change return type.
7908         * procfs.c (class procfs_target) <pid_to_str>: Change return
7909         type.
7910         (procfs_target::pid_to_str): Change return type.
7911         (procfs_target::attach): Update.
7912         (procfs_target::detach): Update.
7913         (procfs_target::fetch_registers): Update.
7914         (procfs_target::store_registers): Update.
7915         (procfs_target::wait): Update.
7916         (procfs_target::files_info): Update.
7917         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7918         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7919         return type.
7920         (nto_procfs_target::pid_to_str): Change return type.
7921         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7922         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7923         return type.
7924         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7925         (exit_lwp): Update.
7926         (attach_proc_task_lwp_callback, get_detach_signal)
7927         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7928         (linux_nat_target::resume, wait_lwp, stop_callback)
7929         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7930         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7931         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7932         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7933         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7934         type.
7935         (inf_ptrace_target::attach): Update.
7936         (inf_ptrace_target::files_info): Update.
7937         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7938         type.
7939         (go32_nat_target::pid_to_str): Change return type.
7940         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7941         (gnu_nat_target::wait): Update.
7942         (gnu_nat_target::wait): Update.
7943         (gnu_nat_target::resume): Update.
7944         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7945         (fbsd_nat_target::wait): Update.
7946         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7947         type.
7948         (darwin_nat_target::attach): Update.
7949         * corelow.c (class core_target) <pid_to_str>: Change return type.
7950         (core_target::pid_to_str): Change return type.
7951         * target.c (normal_pid_to_str): Change return type.
7952         (default_pid_to_str): Likewise.
7953         (target_pid_to_str): Change return type.
7954         (target_translate_tls_address): Update.
7955         (target_announce_detach): Update.
7956         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7957         return type.
7958         (bsd_uthread_target::pid_to_str): Change return type.
7959         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7960         type.
7961         (bsd_kvm_target::pid_to_str): Change return type.
7962         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7963         return type.
7964         (aix_thread_target::pid_to_str): Change return type.
7965         * target.h (struct target_ops) <pid_to_str>: Change return type.
7966         (target_pid_to_str, normal_pid_to_str): Likewise.
7967         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7968         type.
7969         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7970         type.
7971         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7972         return type.
7973         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7974         type.
7975         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7976         type.
7977         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7978         return type.
7979
7980 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7981
7982         * NEWS: Mention that the new default MI version is 3.  Mention
7983         changes to the output of commands and events that deal with
7984         multi-location breakpoints.
7985         * breakpoint.c: Include "mi/mi-out.h".
7986         (print_one_breakpoint): Change output syntax if using MI version
7987         >= 3.
7988         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7989         New.
7990         (mi_multi_location_breakpoint_output_fixed): New.
7991         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7992         (mi_cmd_fix_multi_location_breakpoint_output): New.
7993         (mi_multi_location_breakpoint_output_fixed): New.
7994         * mi/mi-cmds.c (mi_cmds): Register command
7995         -fix-multi-location-breakpoint-output.
7996         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7997         interpreter "mi".
7998
7999 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8000
8001         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8002         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8003         instantiate mi_ui_out based on interpreter name.
8004         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8005         * mi/mi-main.c (mi_load_progress): Likewise.
8006
8007 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8008
8009         * NEWS: Combine separate "New targets" sections for 8.3.
8010
8011 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8012
8013         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8014         (ppcfbsd_init_abi): Install gdbarch
8015         "fetch_tls_load_module_address" and "get_thread_local_address"
8016         methods.
8017
8018 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8019
8020         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8021         (riscv_fbsd_init_abi): Install gdbarch
8022         "fetch_tls_load_module_address" and "get_thread_local_address"
8023         methods.
8024
8025 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8026
8027         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8028         (i386fbsd_init_abi): Install gdbarch
8029         "fetch_tls_load_module_address" and "get_thread_local_address"
8030         methods.
8031
8032 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8033
8034         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8035         (amd64fbsd_init_abi): Install gdbarch
8036         "fetch_tls_load_module_address" and "get_thread_local_address"
8037         methods.
8038
8039 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8040
8041         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8042         (struct fbsd_pspace_data): New type.
8043         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8044         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8045         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8046         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8047         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8048
8049 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8050
8051         * gdbtypes.c (lookup_struct_elt): New function.
8052         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8053         * gdbtypes.h (struct struct_elt): New type.
8054         (lookup_struct_elt): New prototype.
8055
8056 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8057
8058         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8059         remove disabled code block.
8060
8061 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8062
8063         * gdbarch.sh (get_thread_local_address): New method.
8064         * gdbarch.h, gdbarch.c: Regenerate.
8065         * target.c (target_translate_tls_address): Use
8066         gdbarch_get_thread_local_address if present instead of
8067         target::get_thread_local_address.
8068
8069 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8070
8071         * target.h (target::get_thread_local_address): Update comment.
8072
8073 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8074
8075         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8076         objfile->separate_debug_objfile_backlink if not NULL.
8077
8078 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8079
8080         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8081         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8082         (amd64bsd_store_inferior_registers): Likewise.
8083         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8084         Enable segment base registers.
8085         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8086         PT_GETFSBASE and PT_GETGSBASE.
8087         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8088         PT_SETGSBASE.
8089         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8090         segment base registers.
8091         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8092
8093 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8094
8095         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8096         Update calls to i386_target_description to add 'segments'
8097         parameter.
8098         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8099         add segment base registers.
8100         * arch/i386.c (i386_create_target_description): Add 'segments'
8101         parameter to enable segment base registers.
8102         * arch/i386.h (i386_create_target_description): Likewise.
8103         * features/i386/32bit-segments.xml: New file.
8104         * features/i386/32bit-segments.c: Generate.
8105         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8106         call to i386_target_description to add 'segments' parameter.
8107         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8108         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8109         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8110         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8111         if feature is present.
8112         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8113         Add 'segments' parameter to call to i386_target_description.
8114         (i386_target_description): Add 'segments' parameter to enable
8115         segment base registers.
8116         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8117         to call to i386_target_description.
8118         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8119         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8120         Define I386_NUM_REGS.
8121         (i386_target_description): Add 'segments' parameter to enable
8122         segment base registers.
8123
8124 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8125
8126         PR/24325
8127         * source-cache.c: #undef open and close, to avoid unresolved
8128         externals during linking.
8129
8130 2019-03-12  Tom Tromey  <tromey@adacore.com>
8131
8132         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8133         const.  Add initializers.
8134         (_initialize_remote): Don't initialize ptid globals.
8135
8136 2019-03-12  Pedro Alves  <palves@redhat.com>
8137
8138         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8139
8140 2019-03-12  Pedro Alves  <palves@redhat.com>
8141
8142         * cp-name-parser.y (main): Remove unused 'len' variable.
8143
8144 2019-03-12  Tom Tromey  <tromey@adacore.com>
8145
8146         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8147         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8148
8149 2019-03-12  Tom Tromey  <tromey@adacore.com>
8150
8151         * linux-nat.c (iterate_over_lwps): Update.
8152         (stop_callback): Remove parameter.
8153         (stop_wait_callback, detach_callback, resume_set_callback)
8154         (select_singlestep_lwp_callback, set_ignore_sigint)
8155         (status_callback, resumed_callback, resume_clear_callback)
8156         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8157         data parameter.
8158         (linux_nat_target::detach, linux_nat_target::resume)
8159         (linux_stop_and_wait_all_lwps, select_event_lwp)
8160         (linux_nat_filter_event, linux_nat_wait_1)
8161         (linux_nat_target::kill, linux_nat_target::stop)
8162         (linux_nat_target::stop): Update.
8163         (linux_nat_resume_callback): Change type.
8164         (resume_stopped_resumed_lwps, count_events_callback)
8165         (select_event_lwp_callback): Likewise.
8166         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8167         * arm-linux-nat.c (struct update_registers_data): Remove.
8168         (update_registers_callback): Change type.
8169         (arm_linux_insert_hw_breakpoint1): Update.
8170         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8171         parameter.
8172         (x86_linux_dr_set_addr): Update.
8173         (x86_linux_dr_set_control): Update.
8174         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8175         (iterate_over_lwps): Use gdb::function_view.
8176         * nat/aarch64-linux-hw-point.c (struct
8177         aarch64_dr_update_callback_param): Remove.
8178         (debug_reg_change_callback): Change type.
8179         (aarch64_notify_debug_reg_change): Update.
8180         * s390-linux-nat.c (s390_refresh_per_info): Update.
8181
8182 2019-03-11  Tom Tromey  <tromey@adacore.com>
8183
8184         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8185         redundant assignment to "this_cu".
8186
8187 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8188
8189         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8190
8191 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8192
8193         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8194         from...
8195         (rank_one_type): ... this.
8196
8197 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8198
8199         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8200         from...
8201         (rank_one_type): ... this.
8202
8203 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8204
8205         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8206         from...
8207         (rank_one_type): ... this.
8208
8209 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8210
8211         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8212         from...
8213         (rank_one_type): ... this.
8214
8215 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8216
8217         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8218         from...
8219         (rank_one_type): ... this.
8220
8221 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8222
8223         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8224         from...
8225         (rank_one_type): ... this.
8226
8227 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8228
8229         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8230         from...
8231         (rank_one_type): ... this.
8232
8233 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8234
8235         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8236         from...
8237         (rank_one_type): ... this.
8238
8239 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8240
8241         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8242         from...
8243         (rank_one_type): ... this.
8244
8245 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8246
8247         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8248         from...
8249         (rank_one_type): ... this.
8250
8251 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8252
8253         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8254         from...
8255         (rank_one_type): ... this.
8256
8257 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8258
8259         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8260         from...
8261         (rank_one_type): ... this.
8262
8263 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8264
8265         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8266         inferior-events' shows the example events.
8267
8268 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8269
8270         Support styling on native MS-Windows console
8271
8272         PR/24315
8273         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8274         on MS-Windows if $TERM is not defined.
8275
8276         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8277
8278         * posix-hdep.c (gdb_console_fputs):
8279         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8280         functions.
8281         * ui-file.h (gdb_console_fputs): Add prototype.
8282
8283         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8284         back to fputs only if the former returns zero.
8285
8286 2019-03-07  Tom Tromey  <tom@tromey.com>
8287
8288         * symmisc.c (print_symbol_bcache_statistics): Update.
8289         (print_objfile_statistics): Update.
8290         * symfile.c (allocate_symtab): Update.
8291         * stabsread.c: Don't include bcache.h.
8292         * psymtab.h (struct psymbol_bcache): Don't declare.
8293         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8294         (psymbol_bcache_init, psymbol_bcache_free)
8295         (psymbol_bcache_get_bcache): Don't declare.
8296         * psymtab.c (struct psymbol_bcache): Remove.
8297         (psymtab_storage::psymtab_storage): Update.
8298         (psymtab_storage::~psymtab_storage): Update.
8299         (psymbol_bcache_init, psymbol_bcache_free)
8300         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8301         (add_psymbol_to_bcache): Update.
8302         (allocate_psymtab): Update.
8303         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8304         macro_cache>: No longer pointers.
8305         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8306         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8307         * macrotab.c (macro_bcache): Update.
8308         * macroexp.c: Don't include bcache.h.
8309         * gdbtypes.c (check_types_worklist): Update.
8310         (types_deeply_equal): Remove TRY/CATCH.  Update.
8311         * elfread.c (elf_symtab_read): Update.
8312         * dwarf2read.c: Don't include bcache.h.
8313         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8314         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8315         (print_bcache_statistics, bcache_memory_used): Don't declare.
8316         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8317         methods.  Rename all data members.
8318         * bcache.c (struct bcache): Move to bcache.h.
8319         (bcache::expand_hash_table): Rename from expand_hash_table.
8320         (bcache): Remove.
8321         (bcache::insert): Rename from bcache_full.
8322         (bcache::compare): Rename from bcache_compare.
8323         (bcache_xmalloc): Remove.
8324         (bcache::~bcache): Rename from bcache_xfree.
8325         (bcache::print_statistics): Rename from print_bcache_statistics.
8326         (bcache::memory_used): Rename from bcache_memory_used.
8327
8328 2019-03-07  Pedro Alves  <palves@redhat.com>
8329
8330         * infrun.c (normal_stop): Also check for
8331         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8332
8333 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8334
8335         * f-lang.c (value_from_host_double): Moved to...
8336         * value.c (value_from_host_double): ...here.
8337         * value.h (value_from_host_double): Declare.
8338         * guile/scm-math.c (vlscm_convert_typed_number): Use
8339         value_from_host_double.
8340         (vlscm_convert_number): Likewise.
8341         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8342         * python/py-value.c (convert_value_from_python): Likewise.
8343
8344 2019-03-06  Tom Tromey  <tom@tromey.com>
8345
8346         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8347
8348 2019-03-06  Tom Tromey  <tom@tromey.com>
8349
8350         * utils.h (free_current_contents): Don't declare.
8351         * utils.c (free_current_contents): Remove.
8352
8353 2019-03-06  Tom Tromey  <tom@tromey.com>
8354
8355         * top.c (quit_force): Update.
8356         * main.c (captured_command_loop): Update.
8357         * common/new-op.c (operator new): Update.
8358         * common/common-exceptions.c (struct catcher)
8359         <save_cleanup_chain>: Remove member.
8360         (exceptions_state_mc_init): Update.
8361         (exception_try_scope_entry): Return nullptr.
8362         (exception_try_scope_exit, exception_rethrow)
8363         (throw_exception_sjlj, throw_exception_cxx): Update.
8364         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8365         (all_cleanups, do_cleanups, discard_cleanups)
8366         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8367         (restore_cleanups, restore_final_cleanups): Don't declare.
8368         (do_final_cleanups): Remove parameter.
8369         * common/cleanups.c (cleanup_chain, make_cleanup)
8370         (make_cleanup_dtor, all_cleanups, do_cleanups)
8371         (discard_my_cleanups, discard_cleanups)
8372         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8373         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8374         (null_cleanup): Remove.
8375         (do_final_cleanups): Remove parameter.
8376
8377 2019-03-06  Tom Tromey  <tom@tromey.com>
8378
8379         * remote.c (remote_target::remote_parse_stop_reply): Use
8380         unique_xmalloc_ptr.
8381
8382 2019-03-06  Tom Tromey  <tom@tromey.com>
8383
8384         * stabsread.c (struct stabs_field_info): Rename from field_info.
8385         <list, fnlist>: Add initializers.
8386         <obstack>: New member.
8387         (read_member_functions, read_struct_fields, read_baseclasses):
8388         Allocate on obstack.  Don't use cleanups.
8389         (read_one_struct_field, read_member_functions, read_struct_fields)
8390         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8391         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8392         (read_struct_type): Update.
8393
8394 2019-03-06  Tom Tromey  <tom@tromey.com>
8395
8396         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8397         * common/filestuff.h (make_cleanup_close): Don't declare.
8398         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8399         Remove.
8400
8401 2019-03-06  Tom Tromey  <tom@tromey.com>
8402
8403         * solib-aix.c: Use make_scope_exit.
8404
8405 2019-03-06  Tom Tromey  <tom@tromey.com>
8406
8407         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8408         Use make_scope_exit.
8409
8410 2019-03-06  Tom Tromey  <tom@tromey.com>
8411
8412         * solib-svr4.c (disable_probes_interface): Remove parameter.
8413         (svr4_handle_solib_event): Use make_scope_exit.
8414
8415 2019-03-06  Tom Tromey  <tom@tromey.com>
8416
8417         * remote.c (struct stop_reply_deleter): Remove.
8418         (stop_reply_up): Update.
8419         (struct stop_reply): Derive from notif_event.  Don't typedef.
8420         <regcache>: Now a std::vector.
8421         (stop_reply_xfree): Remove.
8422         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8423         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8424         (remote_target::discard_pending_stop_replies): Use delete.
8425         (remote_target::remote_parse_stop_reply): Update.
8426         (remote_target::process_stop_reply): Update.
8427         * remote-notif.h (struct notif_event): Add virtual destructor.
8428         Remove "dtr" member.
8429         (struct notif_client) <alloc_event>: Return a unique_ptr.
8430         (notif_event_xfree): Don't declare.
8431         (notif_event_up): New typedef.
8432         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8433         (notif_event_xfree, do_notif_event_xfree): Remove.
8434         (remote_notif_state_xfree): Update.
8435
8436 2019-03-06  Tom Tromey  <tom@tromey.com>
8437
8438         * infrun.c (displaced_step_clear_cleanup): Now a
8439         forward_scope_exit type.
8440         (displaced_step_prepare_throw): Update.
8441         (displaced_step_fixup): Update.
8442
8443 2019-03-06  Tom Tromey  <tom@tromey.com>
8444
8445         * inferior.h (class inferior): Update comment.
8446         * gdbthread.h (class thread_info): Update comment.
8447
8448 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8449             Tom Tromey  <tom@tromey.com>
8450
8451         * stabsread.h (struct stab_section_list): Remove.
8452         (coffstab_build_psymtabs): Update.
8453         * dbxread.c (symbuf_sections): Now a std::vector.
8454         (sect_idx): New global.
8455         (fill_symbuf): Update.
8456         (coffstab_build_psymtabs): Change type of stabsects parameter.
8457         Update.
8458         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8459         std::vector.
8460         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8461         (coff_locate_sections): Update.
8462         (coff_symfile_read): Remove cleanups.  Update.
8463         (init_stringtab): Add storage parameter.
8464         (free_stringtab, free_stringtab_cleanup): Remove.
8465         (init_lineno): Add storage parameter.
8466         (free_linetab, free_linetab_cleanup): Remove.
8467
8468 2019-03-06  Pedro Alves  <palves@redhat.com>
8469
8470         * linux-fork.c (fork_info::clobber_regs): Delete.
8471         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8472         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8473         comment.  Adjust.
8474         (scoped_switch_fork_info::scoped_switch_fork_info)
8475         (checkpoint_command, linux_fork_context): Adjust
8476         fork_save_infrun_state calls.
8477
8478 2019-03-06  Pedro Alves  <palves@redhat.com>
8479
8480         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8481         (inf_has_multiple_threads): Return 'bool' and rewrite using
8482         inferior_info::threads().
8483
8484 2019-03-06  Pedro Alves  <palves@redhat.com>
8485
8486         * linux-fork.c: Include <list>.
8487         (fork_list): Now a std::list instance.
8488         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8489         (forks_exist_p, find_last_fork): Adjust.
8490         (new_fork): Delete.
8491         (one_fork_p): New.
8492         (add_fork): Adjust.
8493         (free_fork): Delete, folded into fork_info::~fork_info().
8494         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8495         Adjust.
8496         (init_fork_list): Delete.
8497         (linux_fork_killall, linux_fork_mourn_inferior)
8498         (linux_fork_detach, info_checkpoints_command): Adjust.
8499         (_initialize_linux_fork): No longer call init_fork_list.
8500
8501 2019-03-06  Pedro Alves  <palves@redhat.com>
8502
8503         * linux-fork.c (new_fork): New, split out of ...
8504         (add_fork): ... this.  Return void.  Move "first fork" special
8505         case from here, to ...
8506         (checkpoint_command): ... here.
8507         * linux-linux.h (add_fork): Return void.
8508
8509 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8510
8511         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8512
8513 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8514             Chris January  <chris.january@arm.com>
8515             David Lecomber  <david.lecomber@arm.com>
8516
8517         * f-exp.y: New token, UNOP_INTRINSIC.
8518         (exp): New pattern using UNOP_INTRINSIC token.
8519         (f77_keywords): Add 'abs' keyword.
8520         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8521         (value_from_host_double): New function.
8522         (evaluate_subexp_f): Support UNOP_ABS.
8523
8524 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8525
8526         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8527         types.
8528
8529 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8530
8531         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8532         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8533         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8534
8535 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8536
8537         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8538
8539 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8540             Chris January  <chris.january@arm.com>
8541
8542         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8543         * f-exp.y: Define 'KIND' token.
8544         (exp): New pattern for KIND expressions.
8545         (ptype): Handle types with a kind extension.
8546         (direct_abs_decl): Extend to spot kind extensions.
8547         (f77_keywords): Add 'kind' to the list.
8548         (push_kind_type): New function.
8549         (convert_to_kind_type): New function.
8550         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8551         * parse.c (operator_length_standard): Likewise.
8552         * parser-defs.h (enum type_pieces): Add tp_kind.
8553         * std-operator.def: Add UNOP_KIND.
8554
8555 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8556
8557         * f-exp.y (f_parse): Set yydebug.
8558
8559 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8560
8561         * f-lang.c (evaluate_subexp_f): New function.
8562         (exp_descriptor_f): New global.
8563         (f_language_defn): Use exp_descriptor_f instead of
8564         exp_descriptor_standard.
8565
8566 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8567
8568         * f-exp.y (struct token): Add comments.
8569         (dot_ops): Remove uppercase versions and the end marker.
8570         (f77_keywords): Likewise.
8571         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8572         entries in the dot_ops array are case insensitive, and use
8573         strncasecmp to compare strings.  Also some whitespace cleanup in
8574         this area.  Similar for the f77_keywords array, except entries in
8575         this list might be case sensitive.
8576
8577 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8578
8579         * f-exp.y (struct f77_boolean_val): Add comments.
8580         (boolean_values): Remove uppercase versions, and end marker.
8581         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8582         and use strncasecmp to achieve case insensitivity.  Additionally,
8583         perform whitespace cleanup around this code.
8584
8585 2019-03-06  Tom Tromey  <tromey@adacore.com>
8586
8587         * remote-sim.c (gdbsim_target_open): Use result of
8588         gdb_argv::release.
8589
8590 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8591         Dirk Schubert  <dirk.schubert@arm.com>
8592         Chris January  <chris.january@arm.com>
8593
8594         * eval.c (evaluate_subexp_standard): Call Fortran argument
8595         wrapping logic.
8596         * f-lang.c (struct value): A value which can be passed into a
8597         Fortran function call.
8598         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8599         where appropriate.
8600         (struct type): Value ready for a Fortran function call.
8601         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8602         is needed.
8603         * f-lang.h (fortran_argument_convert): Declaration.
8604         (fortran_preserve_arg_pointer): Declaration.
8605         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8606
8607 2019-03-05  Tom Tromey  <tromey@adacore.com>
8608
8609         * python/py-prettyprint.c (print_string_repr): Remove #if.
8610         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8611
8612 2019-03-05  Tom Tromey  <tromey@adacore.com>
8613
8614         * target.c (the_dummy_target): Move later.  Change type to
8615         "dummy_target".
8616         (initialize_targets): Don't initialize the_dummy_target.
8617
8618 2019-03-05  Tom Tromey  <tromey@adacore.com>
8619
8620         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8621         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8622
8623 2019-03-05  Tom Tromey  <tromey@adacore.com>
8624
8625         * windows-nat.c (windows_nat_target::attach)
8626         (windows_nat_target::detach): Don't call gdb_flush.
8627         * valprint.c (generic_val_print, val_print, val_print_string):
8628         Don't call gdb_flush.
8629         * utils.c (defaulted_query): Don't call gdb_flush.
8630         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8631         * target.c (target_announce_detach): Don't call gdb_flush.
8632         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8633         * remote.c (extended_remote_target::attach): Don't call
8634         gdb_flush.
8635         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8636         * printcmd.c (do_examine): Don't call gdb_flush.
8637         (info_display_command): Don't call gdb_flush.
8638         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8639         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8640         * memattr.c (info_mem_command): Don't call gdb_flush.
8641         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8642         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8643         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8644         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8645         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8646         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8647         (gnu_nat_target::detach): Don't call gdb_flush.
8648         * f-valprint.c (f_val_print): Don't call gdb_flush.
8649         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8650         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8651         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8652         gdb_flush.
8653         * c-valprint.c (c_val_print): Don't call gdb_flush.
8654         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8655
8656 2019-03-05  Tom Tromey  <tromey@adacore.com>
8657
8658         * varobj.c (update_dynamic_varobj_children): Update.
8659         (install_default_visualizer): Use reset, not release.
8660         * value.c (set_internalvar): Update.
8661         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8662         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8663         ATTRIBUTE_UNUSED_RESULT.
8664
8665 2019-03-05  Tom Tromey  <tromey@adacore.com>
8666
8667         * remote.c (class scoped_remote_fd) <release>: Add
8668         ATTRIBUTE_UNUSED_RESULT.
8669
8670 2019-03-05  Tom Tromey  <tromey@adacore.com>
8671
8672         * macroexp.c (struct macro_buffer) <release>: Add
8673         ATTRIBUTE_UNUSED_RESULT.
8674
8675 2019-03-05  Tom Tromey  <tromey@adacore.com>
8676
8677         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8678         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8679         ATTRIBUTE_UNUSED_RESULT.
8680
8681 2019-03-05  Tom Tromey  <tromey@adacore.com>
8682
8683         * common/scoped_fd.h (class scoped_fd) <release>: Add
8684         ATTRIBUTE_UNUSED_RESULT.
8685
8686 2019-03-05  Tom Tromey  <tromey@adacore.com>
8687
8688         * parser-defs.h (struct parser_state) <release>: Add
8689         ATTRIBUTE_UNUSED_RESULT.
8690
8691 2019-03-05  Tom Tromey  <tromey@adacore.com>
8692
8693         * utils.h (class gdb_argv) <release>: Add
8694         ATTRIBUTE_UNUSED_RESULT.
8695         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8696
8697 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8698
8699         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8700         for-loop range, to avoid compiler warnings.
8701
8702         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8703         avoid compiler warnings about unused variables.
8704
8705         * NEWS: Mention end of support for native debugging on MS-Windows
8706         before XP.
8707
8708         PR gdb/24292
8709         * common/netstuff.c:
8710         * gdbserver/gdbreplay.c
8711         * gdbserver/remote-utils.c:
8712         * ser-tcp.c:
8713         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8714         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8715         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8716         'getaddrinfo' and 'freeaddrinfo' were not available before
8717         Windows XP, and mingw.org's MinGW headers by default define
8718         _WIN32_WINNT to 0x500.
8719
8720 2019-03-01  Gary Benson <gbenson@redhat.com>
8721
8722         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8723
8724 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8725             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8726
8727         PR gdb/8527
8728         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8729         set_sigint_trap, clear_sigint_trap.
8730
8731 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8732
8733         * target.c (target_detach): Clear the regcache and the
8734         frame cache.
8735
8736 2019-02-27  Pedro Alves  <palves@redhat.com>
8737
8738         * utils.c (set_screen_size): When we cap the height/width sizes,
8739         tweak the corresponding command variable to show "unlimited":
8740
8741 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8742             Pedro Alves  <palves@redhat.com>
8743
8744         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8745         before calling rl_set_screen_size.
8746
8747 2019-02-27  Tom Tromey  <tromey@adacore.com>
8748
8749         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8750         define.
8751         * python/py-value.c: Remove Python 2.4 workaround.
8752         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8753         workaround.
8754         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8755         Python 2.4 workaround.
8756         * python/python-internal.h: Remove Python 2.4 comment.
8757         (Py_ssize_t): Don't define.
8758         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8759         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8760         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8761         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8762         * python/python.c (do_start_initialization): Remove Python 2.4
8763         workaround.
8764         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8765         (print_children): Remove Python 2.4 workaround.
8766         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8767         workaround.
8768         (CHARBUFFERPROC_NAME): Remove.
8769         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8770         Python 2.4 workaround.
8771
8772 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8773
8774         * NEWS: Note minimum Python version.
8775
8776 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8777
8778         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8779         code from these functions.  Remove corresponding ifdefs.  Use
8780         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8781         Remove gotos and target of gotos.
8782         (infpy_search_memory): Likewise.
8783
8784 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8785
8786         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8787         (hppa_gdbarch_init): Don't register deleted functions with
8788         gdbarch.
8789
8790 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8791
8792         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8793         (h8300_unwind_sp): Delete.
8794         (h8300_dummy_id): Delete.
8795         (h8300_gdbarch_init): Don't register deleted functions with
8796         gdbarch.
8797
8798 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8799
8800         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8801         (ft32_unwind_pc): Delete.
8802         (ft32_unwind_sp): Delete.
8803         (ft32_gdbarch_init): Don't register deleted functions with
8804         gdbarch.
8805
8806 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8807
8808         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8809         (frv_unwind_pc): Delete.
8810         (frv_unwind_sp): Delete.
8811         (frv_gdbarch_init): Don't register deleted functions with
8812         gdbarch.
8813
8814 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8815
8816         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8817         (riscv_unwind_pc): Delete.
8818         (riscv_unwind_sp): Delete.
8819         (riscv_gdbarch_init): Don't register deleted functions with
8820         gdbarch.
8821
8822 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8823
8824         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8825         (csky_unwind_pc): Delete.
8826         (csky_unwind_sp): Delete.
8827         (csky_gdbarch_init): Don't register deleted functions with
8828         gdbarch.
8829
8830 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8831
8832         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8833         (cris_unwind_pc): Delete.
8834         (cris_unwind_sp): Delete.
8835         (cris_gdbarch_init): Don't register deleted functions with
8836         gdbarch.
8837
8838 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8839
8840         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8841         (bfin_unwind_pc): Delete.
8842         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8843
8844 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8845
8846         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8847         (arm_unwind_pc): Delete.
8848         (arm_unwind_sp): Delete.
8849         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8850
8851 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8852
8853         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8854         (arc_unwind_pc): Delete.
8855         (arc_unwind_sp): Delete.
8856         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8857
8858 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8859
8860         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8861         (alpha_unwind_pc): Delete.
8862         (alpha_gdbarch_init): Don't register deleted functions with
8863         gdbarch.
8864
8865 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8866
8867         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8868         (aarch64_unwind_pc): Delete.
8869         (aarch64_unwind_sp): Delete.
8870         (aarch64_gdbarch_init): Don't register deleted functions with
8871         gdbarch.
8872
8873 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8874
8875         * gdbtypes.c (type_align): Don't consider static members when
8876         computing structure alignment.
8877
8878 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8879
8880         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8881         return 0 for other types.
8882         * arch-utils.c (default_type_align): Always return 0.
8883         * gdbarch.h: Regenerate.
8884         * gdbarch.sh (type_align): Extend comment.
8885         * gdbtypes.c (type_align): Add additional comments, always call
8886         gdbarch_type_align before applying the default rules.
8887         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8888         generic code will then apply a suitable default.
8889         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8890         types, return 0 for other types.
8891
8892 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8893
8894         * NEWS: Create a new section for the next release branch.
8895         Rename the section of the current branch, now that it has
8896         been cut.
8897
8898 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8899
8900         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8901         * version.in: Bump version to 8.3.50.DATE-git.
8902
8903 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8904
8905         * aix-thread.c (ptid_cmp): Remove unused variable.
8906         (get_signaled_thread): Likewise.
8907         (store_regs_user_thread): Likewise.
8908         (store_regs_kernel_thread): Likewise.
8909         (fetch_regs_kernel_thread): Remove shadowed variable.
8910
8911 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8912
8913         * features/riscv/32bit-cpu.xml: Add register numbers.
8914         * features/riscv/32bit-fpu.c: Regenerate.
8915         * features/riscv/32bit-fpu.xml: Add register numbers.
8916         * features/riscv/64bit-cpu.xml: Add register numbers.
8917         * features/riscv/64bit-fpu.c: Regenerate.
8918         * features/riscv/64bit-fpu.xml: Add register numbers.
8919
8920 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8921
8922         * NEWS: Mention two argument form of gdb.Value constructor.
8923         * python/py-value.c (convert_buffer_and_type_to_value): New
8924         function.
8925         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8926         Add support for handling an optional second argument.  Call
8927         convert_buffer_and_type_to_value as appropriate.
8928         * python/python-internal.h (Py_buffer_deleter): New struct.
8929         (Py_buffer_up): New typedef.
8930
8931 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8932
8933         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8934         instead of releasing ownership.
8935
8936 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8937
8938         * dwarf2read.c (open_and_init_dwp_file): Call
8939         elf_numsections instead of bfd_count_sections to initialize
8940         dwp_file->num_sections.
8941
8942 2019-02-25  Tom Tromey  <tromey@adacore.com>
8943
8944         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8945
8946 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8947
8948         * gcore.in: Add '--readnever' option when invoking GDB.
8949
8950 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8951
8952         * MAINTAINERS: Update my email address.
8953
8954 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8955
8956         * build-id.c (build_id_to_debug_bfd_1): New function.
8957         (build_id_to_debug_bfd): Look for separate debug file in
8958         sysroot.
8959
8960 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8961
8962         * gdbarch.sh: Update the copyright year range that is placed into
8963         generated files.
8964
8965 2019-02-22  Keith Seitz  <keiths@redhat.com>
8966
8967         PR symtab/23853
8968         * linespec.c (create_sals_line_offset): Search for the default
8969         symtab's filename instead of its fullname.
8970
8971 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8972
8973         * NEWS: Update style defaults.
8974
8975 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8976
8977         * main.c (captured_main_1): Disable styling in batch mode.
8978
8979 2019-02-20  Tom Tromey  <tom@tromey.com>
8980
8981         * symtab.c (symtab_symbol_info): Fix typos.
8982
8983 2019-02-20  Tom Tromey  <tromey@adacore.com>
8984
8985         * findcmd.c (_initialize_mem_search): Use upper case for
8986         metasyntactic variables.
8987
8988 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8989
8990         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8991         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8992
8993 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8994
8995         * top.h (source_file_name): Change to std::string.
8996         * top.c (source_file_name): Likewise.
8997         (command_line_input): Adjust.
8998         * cli/cli-script.c (script_from_file): Adjust.
8999
9000 2019-02-19  Tom Tromey  <tromey@adacore.com>
9001
9002         * ravenscar-thread.c
9003         (ravenscar_thread_target::update_thread_list): Don't call
9004         ada_build_task_list.
9005         * ada-lang.h (ada_build_task_list): Don't declare.
9006         * ada-tasks.c (struct ada_tasks_inferior_data)
9007         <task_list_valid_p>: Now bool.
9008         (read_known_tasks, ada_task_list_changed)
9009         (ada_tasks_invalidate_inferior_data): Update.
9010         (read_known_tasks_array): Return bool.
9011         (read_known_tasks_list): Likewise.
9012         (read_known_tasks): Return void.
9013         (ada_build_task_list): Now static.
9014
9015 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9016
9017         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9018         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9019
9020 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9021
9022         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9023         variant for ada_tasks_pspace_data_handle and
9024         ada_tasks_inferior_data_handle.
9025         (ada_tasks_pspace_data_cleanup): New function.
9026         (ada_tasks_inferior_data_cleanup): New function.
9027
9028 2019-02-17  Tom Tromey  <tom@tromey.com>
9029
9030         * macrotab.h (macro_source_fullname): Return a std::string.
9031         * macrotab.c (macro_include, check_for_redefinition)
9032         (macro_undef, macro_lookup_definition, foreach_macro)
9033         (foreach_macro_in_scope): Update.
9034         (macro_source_fullname): Return a std::string.
9035         * macrocmd.c (show_pp_source_pos): Update.
9036
9037 2019-02-17  Tom Tromey  <tom@tromey.com>
9038
9039         * macrocmd.c (show_pp_source_pos): Style the file names.
9040
9041 2019-02-17  Tom Tromey  <tom@tromey.com>
9042
9043         PR tui/24197:
9044         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9045
9046 2019-02-17  Tom Tromey  <tom@tromey.com>
9047
9048         * ada-lang.c (user_select_syms): Use filtered printing.
9049         * utils.c (wrap_style): New global.
9050         (desired_style): Remove.
9051         (emit_style_escape): Add stream parameter.
9052         (set_output_style, reset_terminal_style, prompt_for_continue):
9053         Update.
9054         (flush_wrap_buffer): Only flush gdb_stdout.
9055         (wrap_here): Set wrap_style.
9056         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9057         treat escape sequences as a character.  Change when wrap buffer is
9058         flushed.
9059         (fputs_styled): Do not set the output style when the default is
9060         requested.
9061         * ui-style.h (struct ui_file_style) <is_default>: New method.
9062         * source.c (print_source_lines_base): Emit escape sequences in one
9063         piece.
9064
9065 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9066
9067         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9068         integers and enumeration types.
9069
9070 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9071
9072         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9073         instead of lookup_symbol_in_language
9074         (do_exact_match): New function.
9075         (ada_get_symbol_name_matcher): Return do_exact_match when
9076         doing a verbatim match.
9077
9078 2019-02-15  Tom Tromey  <tromey@adacore.com>
9079
9080         * ravenscar-thread.c (ravenscar_thread_target::resume)
9081         (ravenscar_thread_target::wait): Special case wildcard requests.
9082
9083 2019-02-15  Tom Tromey  <tromey@adacore.com>
9084
9085         * ravenscar-thread.c (base_ptid): Remove.
9086         (struct ravenscar_thread_target) <close>: New method.
9087         <m_base_ptid>: New member.
9088         <update_inferior_ptid, active_task, task_is_currently_active,
9089         runtime_initialized>: Declare methods.
9090         <ravenscar_thread_target>: Add constructor.
9091         (ravenscar_thread_target::task_is_currently_active)
9092         (ravenscar_thread_target::update_inferior_ptid)
9093         (ravenscar_runtime_initialized): Rename.  Now methods.
9094         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9095         (ravenscar_thread_target::update_thread_list): Update.
9096         (ravenscar_thread_target::active_task): Now method.
9097         (ravenscar_thread_target::store_registers)
9098         (ravenscar_thread_target::prepare_to_store)
9099         (ravenscar_thread_target::prepare_to_store)
9100         (ravenscar_thread_target::mourn_inferior): Update.
9101         (ravenscar_inferior_created): Use "new" to create target.
9102         (ravenscar_thread_target::get_ada_task_ptid): Update.
9103         (_initialize_ravenscar): Don't initialize base_ptid.
9104         (ravenscar_ops): Remove global.
9105
9106 2019-02-15  Tom Tromey  <tromey@adacore.com>
9107
9108         * target.h (push_target): Declare new overload.
9109         * target.c (push_target): New overload, taking an rvalue reference.
9110         * remote.c (remote_target::open_1): Use push_target overload.
9111         * corelow.c (core_target_open): Use push_target overload.
9112
9113 2019-02-15  Tom Tromey  <tromey@adacore.com>
9114
9115         * ravenscar-thread.c (is_ravenscar_task)
9116         (ravenscar_task_is_currently_active): Return bool.
9117         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9118         (_initialize_ravenscar): Remove "(void)".
9119         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9120         Return bool.
9121
9122 2019-02-15  Tom Tromey  <tromey@adacore.com>
9123
9124         * ravenscar-thread.c (ravenscar_runtime_initializer)
9125         (has_ravenscar_runtime, get_running_thread_id)
9126         (ravenscar_thread_target::resume): Fix indentation.
9127
9128 2019-02-15  Tom Tromey  <tromey@adacore.com>
9129
9130         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9131         from ravenscar_arch_ops.
9132         (sparc_ravenscar_ops::fetch_registers)
9133         (sparc_ravenscar_ops::store_registers): Now methods.
9134         (sparc_ravenscar_prepare_to_store): Remove.
9135         (sparc_ravenscar_ops): Redefine.
9136         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9137         methods and destructor.  Remove members.
9138         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9139         (ravenscar_thread_target::store_registers)
9140         (ravenscar_thread_target::prepare_to_store): Update.
9141         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9142         Remove.
9143         (struct ppc_ravenscar_powerpc_ops): Derive from
9144         ravenscar_arch_ops.
9145         (ppc_ravenscar_powerpc_ops::fetch_registers)
9146         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9147         (ppc_ravenscar_powerpc_ops): Redefine.
9148         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9149         (ppc_ravenscar_e500_ops::fetch_registers)
9150         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9151         (ppc_ravenscar_e500_ops): Redefine.
9152         * aarch64-ravenscar-thread.c
9153         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9154         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9155         (aarch64_ravenscar_fetch_registers)
9156         (aarch64_ravenscar_store_registers): Now methods.
9157         (aarch64_ravenscar_ops): Redefine.
9158
9159 2019-02-15  Tom Tromey  <tromey@adacore.com>
9160
9161         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9162         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9163         (ravenscar_thread_target::stopped_by_watchpoint)
9164         (ravenscar_thread_target::stopped_data_address)
9165         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9166
9167 2019-02-15  Tom Tromey  <tromey@adacore.com>
9168
9169         * ravenscar-thread.c: Fix some typos.
9170
9171 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9172             Tom Tromey  <tromey@adacore.com>
9173
9174         * ada-lang.c (ada_exception_sal): Change addr_string to a
9175         std::string.
9176         (create_ada_exception_catchpoint): Update.
9177
9178 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9179             Tom Tromey  <tromey@adacore.com>
9180
9181         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9182         (bp_location_ops): Remove.
9183         (base_breakpoint_allocate_location): Update.
9184         (free_bp_location): Update.
9185         * ada-lang.c (class ada_catchpoint_location)
9186         <ada_catchpoint_location>: Remove ops parameter.
9187         (ada_catchpoint_location_dtor): Remove.
9188         (ada_catchpoint_location_ops): Remove.
9189         (allocate_location_exception): Update.
9190         * breakpoint.h (struct bp_location_ops): Remove.
9191         (class bp_location) <bp_location>: Remove bp_location_ops
9192         parameter.
9193         <~bp_location>: Add destructor.
9194         <ops>: Remove.
9195
9196 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9197             Pedro Alves  <palves@redhat.com>
9198
9199         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9200         'PATH_MAX'.
9201
9202 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9203             Samuel Thibault  <samuel.thibault@gnu.org>
9204             Thomas Schwinge  <thomas@codesourcery.com>
9205
9206         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9207         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9208
9209 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9210
9211         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9212         (check_empty): Use "const char *".
9213
9214         * gnu-nat.c (gnu_nat_target::detach): Instead of
9215         'detach_inferior (pid)' call
9216         'detach_inferior (find_inferior_pid (pid))'.
9217
9218         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9219         'nat/fork-inferior.o'.
9220         * gnu-nat.c: #include "nat/fork-inferior.h".
9221
9222         * gnu-nat.c (gnu_nat_target::detach): Instead of
9223         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9224         * gnu-nat.h: #include "inf-child.h".
9225         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9226         'i386_gnu_nat_target::fetch_registers'.
9227         (gnu_store_registers): Rename/move to
9228         'i386_gnu_nat_target::store_registers'.
9229
9230         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9231         * gnu-nat.h (mach_thread_info): New function.
9232         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9233
9234         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9235
9236 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9237
9238         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9239
9240 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9241
9242         * windows-nat.c (windows_add_thread): Add new parameter
9243         "main_thread_p" with default value set to false.  Update
9244         function documentation as well as all callers.
9245         (windows_delete_thread): Likewise.
9246         (fake_create_process): Update call to windows_add_thread.
9247         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9248         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9249         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9250         call to windows_delete_thread.
9251
9252 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9253
9254         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9255
9256 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9257
9258         * symfile.c (find_separate_debug_file): Use canonical path of
9259         sysroot with child_path instead of gdb_sysroot if it is valid.
9260
9261 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9262
9263         * symfile.c (find_separate_debug_file): Use child_path to
9264         determine if an object file is under a sysroot.
9265
9266 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9267
9268         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9269         unittests/child-path-selftests.c.
9270         * common/pathstuff.c (child_path): New function.
9271         * common/pathstuff.h (child_path): New prototype.
9272         * unittests/child-path-selftests.c: New file.
9273
9274 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9275
9276         * symfile.c (find_separate_debug_file): Look for separate debug
9277         files in debug directories under the sysroot.
9278
9279 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9280
9281         * symtab.h (struct minimal_symbol data_p): New const method.
9282         (struct minimal_symbol text_p): Likewise.
9283         * symtab.c (output_source_filename): Use file name style
9284         to print file name.
9285         (print_symbol_info): Likewise.
9286         (print_msymbol_info): Use address style to print addresses.
9287         Use function name style to print executable text symbols.
9288         (expand_symtab_containing_pc): Use data_p.
9289         (find_pc_sect_compunit_symtab): Likewise.
9290
9291 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9292
9293         * breakpoint.c (describe_other_breakpoints): Use address style
9294         to print addresses.
9295         (say_where): Likewise.
9296
9297 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9298
9299         * ada-typeprint.c (print_func_type): Print function name
9300         style to print function name.
9301         * c-typeprint.c (c_print_type_1): Likewise.
9302
9303 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9304
9305         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9306         for execve.
9307
9308 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9309
9310         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9311         type_stack.
9312
9313 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9314
9315         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9316         TYPE_CODE_REF types.
9317
9318 2019-02-08  Jim Wilson  <jimw@sifive.com>
9319
9320         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9321         (riscv_linux_fregset): New.
9322         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9323
9324 2019-02-07  Tom Tromey  <tom@tromey.com>
9325
9326         * thread.c (thread_cancel_execution_command): Update.
9327         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9328         methods.
9329         (struct thread_fsm_ops): Remove.
9330         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9331         (thread_fsm_should_stop, thread_fsm_return_value)
9332         (thread_fsm_set_finished, thread_fsm_finished_p)
9333         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9334         Don't declare.
9335         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9336         * infrun.c (clear_proceed_status_thread)
9337         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9338         (print_stop_event): Update.
9339         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9340         Add constructor.
9341         (step_command_fsm_ops): Remove.
9342         (new_step_command_fsm): Remove.
9343         (step_1): Update.
9344         (step_command_fsm::should_stop): Rename from
9345         step_command_fsm_should_stop.
9346         (step_command_fsm::clean_up): Rename from
9347         step_command_fsm_clean_up.
9348         (step_command_fsm::do_async_reply_reason): Rename from
9349         step_command_fsm_async_reply_reason.
9350         (struct until_next_fsm): Inherit from thread_fsm.  Add
9351         constructor.
9352         (until_next_fsm_ops): Remove.
9353         (new_until_next_fsm): Remove.
9354         (until_next_fsm::should_stop): Rename from
9355         until_next_fsm_should_stop.
9356         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9357         (until_next_fsm::do_async_reply_reason): Rename from
9358         until_next_fsm_async_reply_reason.
9359         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9360         constructor.  Change type of breakpoint.
9361         (finish_command_fsm_ops): Remove.
9362         (new_finish_command_fsm): Remove.
9363         (finish_command_fsm::should_stop): Rename from
9364         finish_command_fsm_should_stop.
9365         (finish_command_fsm::clean_up): Rename from
9366         finish_command_fsm_clean_up.
9367         (finish_command_fsm::return_value): Rename from
9368         finish_command_fsm_return_value.
9369         (finish_command_fsm::do_async_reply_reason): Rename from
9370         finish_command_fsm_async_reply_reason.
9371         (finish_command): Update.
9372         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9373         Add constructor.
9374         (call_thread_fsm_ops): Remove.
9375         (call_thread_fsm::call_thread_fsm): Rename from
9376         new_call_thread_fsm.
9377         (call_thread_fsm::should_stop): Rename from
9378         call_thread_fsm_should_stop.
9379         (call_thread_fsm::should_notify_stop): Rename from
9380         call_thread_fsm_should_notify_stop.
9381         (run_inferior_call, call_function_by_hand_dummy): Update.
9382         * cli/cli-interp.c (should_print_stop_to_console): Update.
9383         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9384         Add constructor.  Change type of location_breakpoint,
9385         caller_breakpoint.
9386         (until_break_fsm_ops): Remove.
9387         (new_until_break_fsm): Remove.
9388         (until_break_fsm::should_stop): Rename from
9389         until_break_fsm_should_stop.
9390         (until_break_fsm::clean_up): Rename from
9391         until_break_fsm_clean_up.
9392         (until_break_fsm::do_async_reply_reason): Rename from
9393         until_break_fsm_async_reply_reason.
9394         (until_break_command): Update.
9395         * thread-fsm.c: Remove.
9396         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9397
9398 2019-02-07  Tom Tromey  <tom@tromey.com>
9399
9400         * yy-remap.h: Add include guard.
9401         * xtensa-tdep.h: Add include guard.
9402         * xcoffread.h: Rename include guard.
9403         * varobj-iter.h: Add include guard.
9404         * tui/tui.h: Rename include guard.
9405         * tui/tui-winsource.h: Rename include guard.
9406         * tui/tui-wingeneral.h: Rename include guard.
9407         * tui/tui-windata.h: Rename include guard.
9408         * tui/tui-win.h: Rename include guard.
9409         * tui/tui-stack.h: Rename include guard.
9410         * tui/tui-source.h: Rename include guard.
9411         * tui/tui-regs.h: Rename include guard.
9412         * tui/tui-out.h: Rename include guard.
9413         * tui/tui-layout.h: Rename include guard.
9414         * tui/tui-io.h: Rename include guard.
9415         * tui/tui-hooks.h: Rename include guard.
9416         * tui/tui-file.h: Rename include guard.
9417         * tui/tui-disasm.h: Rename include guard.
9418         * tui/tui-data.h: Rename include guard.
9419         * tui/tui-command.h: Rename include guard.
9420         * tic6x-tdep.h: Add include guard.
9421         * target/waitstatus.h: Rename include guard.
9422         * target/wait.h: Rename include guard.
9423         * target/target.h: Rename include guard.
9424         * target/resume.h: Rename include guard.
9425         * target-float.h: Rename include guard.
9426         * stabsread.h: Add include guard.
9427         * rs6000-tdep.h: Add include guard.
9428         * riscv-fbsd-tdep.h: Add include guard.
9429         * regformats/regdef.h: Rename include guard.
9430         * record.h: Rename include guard.
9431         * python/python.h: Rename include guard.
9432         * python/python-internal.h: Rename include guard.
9433         * python/py-stopevent.h: Rename include guard.
9434         * python/py-ref.h: Rename include guard.
9435         * python/py-record.h: Rename include guard.
9436         * python/py-record-full.h: Rename include guard.
9437         * python/py-record-btrace.h: Rename include guard.
9438         * python/py-instruction.h: Rename include guard.
9439         * python/py-events.h: Rename include guard.
9440         * python/py-event.h: Rename include guard.
9441         * procfs.h: Add include guard.
9442         * proc-utils.h: Add include guard.
9443         * p-lang.h: Add include guard.
9444         * or1k-tdep.h: Rename include guard.
9445         * observable.h: Rename include guard.
9446         * nto-tdep.h: Rename include guard.
9447         * nat/x86-linux.h: Rename include guard.
9448         * nat/x86-linux-dregs.h: Rename include guard.
9449         * nat/x86-gcc-cpuid.h: Add include guard.
9450         * nat/x86-dregs.h: Rename include guard.
9451         * nat/x86-cpuid.h: Rename include guard.
9452         * nat/ppc-linux.h: Rename include guard.
9453         * nat/mips-linux-watch.h: Rename include guard.
9454         * nat/linux-waitpid.h: Rename include guard.
9455         * nat/linux-ptrace.h: Rename include guard.
9456         * nat/linux-procfs.h: Rename include guard.
9457         * nat/linux-osdata.h: Rename include guard.
9458         * nat/linux-nat.h: Rename include guard.
9459         * nat/linux-namespaces.h: Rename include guard.
9460         * nat/linux-btrace.h: Rename include guard.
9461         * nat/glibc_thread_db.h: Rename include guard.
9462         * nat/gdb_thread_db.h: Rename include guard.
9463         * nat/gdb_ptrace.h: Rename include guard.
9464         * nat/fork-inferior.h: Rename include guard.
9465         * nat/amd64-linux-siginfo.h: Rename include guard.
9466         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9467         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9468         * nat/aarch64-linux.h: Rename include guard.
9469         * nat/aarch64-linux-hw-point.h: Rename include guard.
9470         * mn10300-tdep.h: Add include guard.
9471         * mips-linux-tdep.h: Add include guard.
9472         * mi/mi-parse.h: Rename include guard.
9473         * mi/mi-out.h: Rename include guard.
9474         * mi/mi-main.h: Rename include guard.
9475         * mi/mi-interp.h: Rename include guard.
9476         * mi/mi-getopt.h: Rename include guard.
9477         * mi/mi-console.h: Rename include guard.
9478         * mi/mi-common.h: Rename include guard.
9479         * mi/mi-cmds.h: Rename include guard.
9480         * mi/mi-cmd-break.h: Rename include guard.
9481         * m2-lang.h: Add include guard.
9482         * location.h: Rename include guard.
9483         * linux-record.h: Rename include guard.
9484         * linux-nat.h: Add include guard.
9485         * linux-fork.h: Add include guard.
9486         * i386-darwin-tdep.h: Rename include guard.
9487         * hppa-linux-offsets.h: Add include guard.
9488         * guile/guile.h: Rename include guard.
9489         * guile/guile-internal.h: Rename include guard.
9490         * gnu-nat.h: Rename include guard.
9491         * gdb-stabs.h: Rename include guard.
9492         * frv-tdep.h: Add include guard.
9493         * f-lang.h: Add include guard.
9494         * event-loop.h: Add include guard.
9495         * darwin-nat.h: Rename include guard.
9496         * cp-abi.h: Rename include guard.
9497         * config/sparc/nm-sol2.h: Rename include guard.
9498         * config/nm-nto.h: Rename include guard.
9499         * config/nm-linux.h: Add include guard.
9500         * config/i386/nm-i386gnu.h: Rename include guard.
9501         * config/djgpp/nl_types.h: Rename include guard.
9502         * config/djgpp/langinfo.h: Rename include guard.
9503         * compile/gcc-cp-plugin.h: Add include guard.
9504         * compile/gcc-c-plugin.h: Add include guard.
9505         * compile/compile.h: Rename include guard.
9506         * compile/compile-object-run.h: Rename include guard.
9507         * compile/compile-object-load.h: Rename include guard.
9508         * compile/compile-internal.h: Rename include guard.
9509         * compile/compile-cplus.h: Rename include guard.
9510         * compile/compile-c.h: Rename include guard.
9511         * common/xml-utils.h: Rename include guard.
9512         * common/x86-xstate.h: Rename include guard.
9513         * common/version.h: Rename include guard.
9514         * common/vec.h: Rename include guard.
9515         * common/tdesc.h: Rename include guard.
9516         * common/selftest.h: Rename include guard.
9517         * common/scoped_restore.h: Rename include guard.
9518         * common/scoped_mmap.h: Rename include guard.
9519         * common/scoped_fd.h: Rename include guard.
9520         * common/safe-iterator.h: Rename include guard.
9521         * common/run-time-clock.h: Rename include guard.
9522         * common/refcounted-object.h: Rename include guard.
9523         * common/queue.h: Rename include guard.
9524         * common/ptid.h: Rename include guard.
9525         * common/print-utils.h: Rename include guard.
9526         * common/preprocessor.h: Rename include guard.
9527         * common/pathstuff.h: Rename include guard.
9528         * common/observable.h: Rename include guard.
9529         * common/netstuff.h: Rename include guard.
9530         * common/job-control.h: Rename include guard.
9531         * common/host-defs.h: Rename include guard.
9532         * common/gdb_wait.h: Rename include guard.
9533         * common/gdb_vecs.h: Rename include guard.
9534         * common/gdb_unlinker.h: Rename include guard.
9535         * common/gdb_unique_ptr.h: Rename include guard.
9536         * common/gdb_tilde_expand.h: Rename include guard.
9537         * common/gdb_sys_time.h: Rename include guard.
9538         * common/gdb_string_view.h: Rename include guard.
9539         * common/gdb_splay_tree.h: Rename include guard.
9540         * common/gdb_setjmp.h: Rename include guard.
9541         * common/gdb_ref_ptr.h: Rename include guard.
9542         * common/gdb_optional.h: Rename include guard.
9543         * common/gdb_locale.h: Rename include guard.
9544         * common/gdb_assert.h: Rename include guard.
9545         * common/filtered-iterator.h: Rename include guard.
9546         * common/filestuff.h: Rename include guard.
9547         * common/fileio.h: Rename include guard.
9548         * common/environ.h: Rename include guard.
9549         * common/common-utils.h: Rename include guard.
9550         * common/common-types.h: Rename include guard.
9551         * common/common-regcache.h: Rename include guard.
9552         * common/common-inferior.h: Rename include guard.
9553         * common/common-gdbthread.h: Rename include guard.
9554         * common/common-exceptions.h: Rename include guard.
9555         * common/common-defs.h: Rename include guard.
9556         * common/common-debug.h: Rename include guard.
9557         * common/cleanups.h: Rename include guard.
9558         * common/buffer.h: Rename include guard.
9559         * common/btrace-common.h: Rename include guard.
9560         * common/break-common.h: Rename include guard.
9561         * cli/cli-utils.h: Rename include guard.
9562         * cli/cli-style.h: Rename include guard.
9563         * cli/cli-setshow.h: Rename include guard.
9564         * cli/cli-script.h: Rename include guard.
9565         * cli/cli-interp.h: Rename include guard.
9566         * cli/cli-decode.h: Rename include guard.
9567         * cli/cli-cmds.h: Rename include guard.
9568         * charset-list.h: Add include guard.
9569         * buildsym-legacy.h: Rename include guard.
9570         * bfin-tdep.h: Add include guard.
9571         * ax.h: Rename include guard.
9572         * arm-linux-tdep.h: Add include guard.
9573         * arm-fbsd-tdep.h: Add include guard.
9574         * arch/xtensa.h: Rename include guard.
9575         * arch/tic6x.h: Add include guard.
9576         * arch/i386.h: Add include guard.
9577         * arch/arm.h: Rename include guard.
9578         * arch/arm-linux.h: Rename include guard.
9579         * arch/arm-get-next-pcs.h: Rename include guard.
9580         * arch/amd64.h: Add include guard.
9581         * arch/aarch64-insn.h: Rename include guard.
9582         * arch-utils.h: Rename include guard.
9583         * annotate.h: Add include guard.
9584         * amd64-darwin-tdep.h: Rename include guard.
9585         * aarch64-linux-tdep.h: Add include guard.
9586         * aarch64-fbsd-tdep.h: Add include guard.
9587         * aarch32-linux-nat.h: Add include guard.
9588
9589 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9590
9591         * macrotab.c (macro_define_internal): New function that
9592         factorizes macro_define_object_internal and macro_define_function
9593         code.
9594         (macro_define_object_internal): Use macro_define_internal.
9595         (macro_define_function): Likewise.
9596
9597 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9598
9599         * macrocmd.c (extract_identifier): Return
9600         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9601         callers.
9602
9603 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9604
9605         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9606
9607 2019-02-05  Tom Tromey  <tom@tromey.com>
9608
9609         * target.c (target_stack::unpush): Move assertion earlier.
9610
9611 2019-01-30  Tom Tromey  <tom@tromey.com>
9612
9613         PR python/23615:
9614         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9615         (gdbpy_parse_and_eval): Likewise.
9616         * python/python-internal.h (gdbpy_allow_threads): New class.
9617
9618 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9619
9620         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9621         (aarch64_fbsd_fpregmap): Move earlier.
9622         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9623         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9624         instead of individual calls to trad_frame_set_reg_addr.
9625         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9626         earlier.
9627         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9628         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9629         instead of individual calls to trad_frame_set_reg_addr.
9630
9631 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9632
9633         * CONTRIBUTE: Replace contribution list with wiki link.
9634
9635 2019-01-25  Tom Tromey  <tom@tromey.com>
9636
9637         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9638
9639 2019-01-25  Tom Tromey  <tom@tromey.com>
9640
9641         * xtensa-linux-nat.c: Fix common/ includes.
9642         * xml-support.h: Fix common/ includes.
9643         * xml-support.c: Fix common/ includes.
9644         * x86-linux-nat.c: Fix common/ includes.
9645         * windows-nat.c: Fix common/ includes.
9646         * varobj.h: Fix common/ includes.
9647         * varobj.c: Fix common/ includes.
9648         * value.c: Fix common/ includes.
9649         * valops.c: Fix common/ includes.
9650         * utils.c: Fix common/ includes.
9651         * unittests/xml-utils-selftests.c: Fix common/ includes.
9652         * unittests/utils-selftests.c: Fix common/ includes.
9653         * unittests/unpack-selftests.c: Fix common/ includes.
9654         * unittests/tracepoint-selftests.c: Fix common/ includes.
9655         * unittests/style-selftests.c: Fix common/ includes.
9656         * unittests/string_view-selftests.c: Fix common/ includes.
9657         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9658         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9659         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9660         * unittests/rsp-low-selftests.c: Fix common/ includes.
9661         * unittests/parse-connection-spec-selftests.c: Fix common/
9662         includes.
9663         * unittests/optional-selftests.c: Fix common/ includes.
9664         * unittests/offset-type-selftests.c: Fix common/ includes.
9665         * unittests/observable-selftests.c: Fix common/ includes.
9666         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9667         * unittests/memrange-selftests.c: Fix common/ includes.
9668         * unittests/memory-map-selftests.c: Fix common/ includes.
9669         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9670         * unittests/function-view-selftests.c: Fix common/ includes.
9671         * unittests/environ-selftests.c: Fix common/ includes.
9672         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9673         * unittests/common-utils-selftests.c: Fix common/ includes.
9674         * unittests/cli-utils-selftests.c: Fix common/ includes.
9675         * unittests/array-view-selftests.c: Fix common/ includes.
9676         * ui-file.c: Fix common/ includes.
9677         * tui/tui-io.c: Fix common/ includes.
9678         * tracepoint.h: Fix common/ includes.
9679         * tracepoint.c: Fix common/ includes.
9680         * tracefile-tfile.c: Fix common/ includes.
9681         * top.h: Fix common/ includes.
9682         * top.c: Fix common/ includes.
9683         * thread.c: Fix common/ includes.
9684         * target/waitstatus.h: Fix common/ includes.
9685         * target/waitstatus.c: Fix common/ includes.
9686         * target.h: Fix common/ includes.
9687         * target.c: Fix common/ includes.
9688         * target-memory.c: Fix common/ includes.
9689         * target-descriptions.c: Fix common/ includes.
9690         * symtab.h: Fix common/ includes.
9691         * symfile.c: Fix common/ includes.
9692         * stap-probe.c: Fix common/ includes.
9693         * spu-linux-nat.c: Fix common/ includes.
9694         * sparc-nat.c: Fix common/ includes.
9695         * source.c: Fix common/ includes.
9696         * solib.c: Fix common/ includes.
9697         * solib-target.c: Fix common/ includes.
9698         * ser-unix.c: Fix common/ includes.
9699         * ser-tcp.c: Fix common/ includes.
9700         * ser-pipe.c: Fix common/ includes.
9701         * ser-base.c: Fix common/ includes.
9702         * selftest-arch.c: Fix common/ includes.
9703         * s12z-tdep.c: Fix common/ includes.
9704         * rust-exp.y: Fix common/ includes.
9705         * rs6000-aix-tdep.c: Fix common/ includes.
9706         * riscv-tdep.c: Fix common/ includes.
9707         * remote.c: Fix common/ includes.
9708         * remote-notif.h: Fix common/ includes.
9709         * remote-fileio.h: Fix common/ includes.
9710         * remote-fileio.c: Fix common/ includes.
9711         * regcache.h: Fix common/ includes.
9712         * regcache.c: Fix common/ includes.
9713         * record-btrace.c: Fix common/ includes.
9714         * python/python.c: Fix common/ includes.
9715         * python/py-type.c: Fix common/ includes.
9716         * python/py-inferior.c: Fix common/ includes.
9717         * progspace.h: Fix common/ includes.
9718         * producer.c: Fix common/ includes.
9719         * procfs.c: Fix common/ includes.
9720         * proc-api.c: Fix common/ includes.
9721         * printcmd.c: Fix common/ includes.
9722         * ppc-linux-nat.c: Fix common/ includes.
9723         * parser-defs.h: Fix common/ includes.
9724         * osdata.c: Fix common/ includes.
9725         * obsd-nat.c: Fix common/ includes.
9726         * nat/x86-linux.c: Fix common/ includes.
9727         * nat/x86-linux-dregs.c: Fix common/ includes.
9728         * nat/x86-dregs.h: Fix common/ includes.
9729         * nat/x86-dregs.c: Fix common/ includes.
9730         * nat/ppc-linux.c: Fix common/ includes.
9731         * nat/mips-linux-watch.h: Fix common/ includes.
9732         * nat/mips-linux-watch.c: Fix common/ includes.
9733         * nat/linux-waitpid.c: Fix common/ includes.
9734         * nat/linux-ptrace.h: Fix common/ includes.
9735         * nat/linux-ptrace.c: Fix common/ includes.
9736         * nat/linux-procfs.c: Fix common/ includes.
9737         * nat/linux-personality.c: Fix common/ includes.
9738         * nat/linux-osdata.c: Fix common/ includes.
9739         * nat/linux-namespaces.c: Fix common/ includes.
9740         * nat/linux-btrace.h: Fix common/ includes.
9741         * nat/linux-btrace.c: Fix common/ includes.
9742         * nat/fork-inferior.c: Fix common/ includes.
9743         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9744         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9745         * nat/aarch64-linux.c: Fix common/ includes.
9746         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9747         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9748         * namespace.h: Fix common/ includes.
9749         * mips-linux-tdep.c: Fix common/ includes.
9750         * minsyms.c: Fix common/ includes.
9751         * mi/mi-parse.h: Fix common/ includes.
9752         * mi/mi-main.c: Fix common/ includes.
9753         * mi/mi-cmd-env.c: Fix common/ includes.
9754         * memrange.h: Fix common/ includes.
9755         * memattr.c: Fix common/ includes.
9756         * maint.h: Fix common/ includes.
9757         * maint.c: Fix common/ includes.
9758         * main.c: Fix common/ includes.
9759         * machoread.c: Fix common/ includes.
9760         * location.c: Fix common/ includes.
9761         * linux-thread-db.c: Fix common/ includes.
9762         * linux-nat.c: Fix common/ includes.
9763         * linux-fork.c: Fix common/ includes.
9764         * inline-frame.c: Fix common/ includes.
9765         * infrun.c: Fix common/ includes.
9766         * inflow.c: Fix common/ includes.
9767         * inferior.h: Fix common/ includes.
9768         * inferior.c: Fix common/ includes.
9769         * infcmd.c: Fix common/ includes.
9770         * inf-ptrace.c: Fix common/ includes.
9771         * inf-child.c: Fix common/ includes.
9772         * ia64-linux-nat.c: Fix common/ includes.
9773         * i387-tdep.c: Fix common/ includes.
9774         * i386-tdep.c: Fix common/ includes.
9775         * i386-linux-tdep.c: Fix common/ includes.
9776         * i386-linux-nat.c: Fix common/ includes.
9777         * i386-go32-tdep.c: Fix common/ includes.
9778         * i386-fbsd-tdep.c: Fix common/ includes.
9779         * i386-fbsd-nat.c: Fix common/ includes.
9780         * guile/scm-type.c: Fix common/ includes.
9781         * guile/guile.c: Fix common/ includes.
9782         * go32-nat.c: Fix common/ includes.
9783         * gnu-nat.c: Fix common/ includes.
9784         * gdbthread.h: Fix common/ includes.
9785         * gdbarch-selftests.c: Fix common/ includes.
9786         * gdb_usleep.c: Fix common/ includes.
9787         * gdb_select.h: Fix common/ includes.
9788         * gdb_bfd.c: Fix common/ includes.
9789         * gcore.c: Fix common/ includes.
9790         * fork-child.c: Fix common/ includes.
9791         * findvar.c: Fix common/ includes.
9792         * fbsd-nat.c: Fix common/ includes.
9793         * event-top.c: Fix common/ includes.
9794         * event-loop.c: Fix common/ includes.
9795         * dwarf2read.c: Fix common/ includes.
9796         * dwarf2loc.c: Fix common/ includes.
9797         * dwarf2-frame.c: Fix common/ includes.
9798         * dwarf-index-cache.c: Fix common/ includes.
9799         * dtrace-probe.c: Fix common/ includes.
9800         * disasm-selftests.c: Fix common/ includes.
9801         * defs.h: Fix common/ includes.
9802         * csky-tdep.c: Fix common/ includes.
9803         * cp-valprint.c: Fix common/ includes.
9804         * cp-support.h: Fix common/ includes.
9805         * cp-support.c: Fix common/ includes.
9806         * corelow.c: Fix common/ includes.
9807         * completer.h: Fix common/ includes.
9808         * completer.c: Fix common/ includes.
9809         * compile/compile.c: Fix common/ includes.
9810         * compile/compile-loc2c.c: Fix common/ includes.
9811         * compile/compile-cplus-types.c: Fix common/ includes.
9812         * compile/compile-cplus-symbols.c: Fix common/ includes.
9813         * command.h: Fix common/ includes.
9814         * cli/cli-dump.c: Fix common/ includes.
9815         * cli/cli-cmds.c: Fix common/ includes.
9816         * charset.c: Fix common/ includes.
9817         * build-id.c: Fix common/ includes.
9818         * btrace.h: Fix common/ includes.
9819         * btrace.c: Fix common/ includes.
9820         * breakpoint.h: Fix common/ includes.
9821         * breakpoint.c: Fix common/ includes.
9822         * ax.h:
9823         (enum agent_op): Fix common/ includes.
9824         * ax-general.c (struct aop_map): Fix common/ includes.
9825         * ax-gdb.c: Fix common/ includes.
9826         * auxv.c: Fix common/ includes.
9827         * auto-load.c: Fix common/ includes.
9828         * arm-tdep.c: Fix common/ includes.
9829         * arch/riscv.c: Fix common/ includes.
9830         * arch/ppc-linux-common.c: Fix common/ includes.
9831         * arch/i386.c: Fix common/ includes.
9832         * arch/arm.c: Fix common/ includes.
9833         * arch/arm-linux.c: Fix common/ includes.
9834         * arch/arm-get-next-pcs.c: Fix common/ includes.
9835         * arch/amd64.c: Fix common/ includes.
9836         * arch/aarch64.c: Fix common/ includes.
9837         * arch/aarch64-insn.c: Fix common/ includes.
9838         * arch-utils.c: Fix common/ includes.
9839         * amd64-windows-tdep.c: Fix common/ includes.
9840         * amd64-tdep.c: Fix common/ includes.
9841         * amd64-sol2-tdep.c: Fix common/ includes.
9842         * amd64-obsd-tdep.c: Fix common/ includes.
9843         * amd64-nbsd-tdep.c: Fix common/ includes.
9844         * amd64-linux-tdep.c: Fix common/ includes.
9845         * amd64-linux-nat.c: Fix common/ includes.
9846         * amd64-fbsd-tdep.c: Fix common/ includes.
9847         * amd64-fbsd-nat.c: Fix common/ includes.
9848         * amd64-dicos-tdep.c: Fix common/ includes.
9849         * amd64-darwin-tdep.c: Fix common/ includes.
9850         * agent.c: Fix common/ includes.
9851         * ada-lang.h: Fix common/ includes.
9852         * ada-lang.c: Fix common/ includes.
9853         * aarch64-tdep.c: Fix common/ includes.
9854
9855 2019-01-25  Tom Tromey  <tom@tromey.com>
9856
9857         * common/create-version.sh: Use common/version.h.
9858
9859 2019-01-24  Pedro Alves  <palves@redhat.com>
9860
9861         * infrun.c (signal_stop, signal_print, signal_program)
9862         (signal_catch, signal_pass): Now arrays instead of pointers.
9863         (update_signals_program_target, do_target_resume)
9864         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9865         * linux-nat.c (linux_nat_target::pass_signals)
9866         (linux_nat_target::create_inferior, linux_nat_target::attach):
9867         Adjust.
9868         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9869         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9870         * procfs.c (procfs_target::pass_signals): Adjust.
9871         * record-full.c (record_full_target::resume): Adjust.
9872         * remote.c (remote_target::pass_signals)
9873         (remote_target::program_signals): Adjust.
9874         * target-debug.h (target_debug_print_signals): Now takes a
9875         gdb::array_view as parameter.  Adjust.
9876         * target.h (target_ops) <pass_signals, program_signals>: Replace
9877         pointer and length parameters with gdb::array_view.
9878         (target_pass_signals, target_program_signals): Likewise.
9879         * target-delegates.c: Regenerate.
9880
9881 2019-01-24  Pedro Alves  <palves@redhat.com>
9882
9883         * common/forward-scope-exit.h
9884         (forward_scope_exit::forward_scope_exit): Pass arguments to
9885         m_bind_function directly, instead of creating a std::bind and
9886         copying that.
9887
9888 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9889
9890         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9891         for static members.
9892         (pass_in_v_vfp_candidate): Likewise.
9893
9894 2019-01-23  Tom Tromey  <tom@tromey.com>
9895             Pedro Alves  <palves@redhat.com>
9896
9897         * regcache.c (class regcache_invalidator): Remove.
9898         (regcache::raw_write): Use make_scope_exit.
9899
9900 2019-01-23  Tom Tromey  <tom@tromey.com>
9901
9902         * ui-out.h (class ui_out_emit_type): Update comment.
9903
9904 2019-01-23  Tom Tromey  <tom@tromey.com>
9905
9906         * infrun.c (fetch_inferior_event): Update comment.
9907
9908 2019-01-23  Tom Tromey  <tom@tromey.com>
9909             Pedro Alves  <palves@redhat.com>
9910
9911         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9912         parameter.
9913         (fetch_inferior_event): Use SCOPE_EXIT.
9914
9915
9916 2019-01-23  Tom Tromey  <tom@tromey.com>
9917             Pedro Alves  <palves@redhat.com>
9918
9919         * infrun.c (disable_thread_events): Delete.
9920         (stop_all_threads): Use SCOPE_EXIT.
9921
9922 2019-01-23  Tom Tromey  <tom@tromey.com>
9923             Pedro Alves  <palves@redhat.com>
9924
9925         * symfile.c: Include forward-scope-exit.h.
9926         (clear_symtab_users_cleanup): Replace forward declaration with
9927         a FORWARD_SCOPE_EXIT.
9928         (syms_from_objfile_1): Use the forward_scope_exit and
9929         gdb::optional instead of cleanup_function.
9930         (reread_symbols): Use the forward_scope_exit instead of
9931         cleanup_function.
9932         (clear_symtab_users_cleanup): Remove function.
9933
9934 2019-01-23  Tom Tromey  <tom@tromey.com>
9935             Pedro Alves  <palves@redhat.com>
9936
9937         * linux-nat.c: Include scope-exit.h.
9938         (cleanup_target_stop): Remove.
9939         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9940         SCOPE_EXIT.
9941
9942 2019-01-23  Tom Tromey  <tom@tromey.com>
9943             Pedro Alves  <palves@redhat.com>
9944
9945         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9946         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9947
9948 2019-01-23  Tom Tromey  <tom@tromey.com>
9949             Andrew Burgess  <andrew.burgess@embecosm.com>
9950             Pedro Alves  <palves@redhat.com>
9951
9952         * infrun.c (fetch_inferior_event): Use scope_exit.
9953         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9954         * top.c (execute_command): Use scope_exit.
9955         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9956         * utils.c (do_bpstat_clear_actions_cleanup)
9957         (make_bpstat_clear_actions_cleanup): Remove.
9958
9959 2019-01-23  Tom Tromey  <tom@tromey.com>
9960             Pedro Alves  <palves@redhat.com>
9961
9962         * infrun.c: Include "common/scope-exit.h"
9963         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9964         (wait_for_inferior): Use SCOPE_EXIT.
9965         (fetch_inferior_event): Use scope_exit.
9966
9967 2019-01-23  Tom Tromey  <tom@tromey.com>
9968             Pedro Alves  <palves@redhat.com>
9969
9970         * breakpoint.c (create_breakpoint): Remove cleanup.
9971
9972 2019-01-23  Tom Tromey  <tom@tromey.com>
9973             Andrew Burgess  <andrew.burgess@embecosm.com>
9974             Pedro Alves  <palves@redhat.com>
9975
9976 2019-01-23  Pedro Alves  <palves@redhat.com>
9977
9978         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9979
9980 2019-01-23  Pedro Alves  <palves@redhat.com>
9981             Andrew Burgess  <andrew.burgess@embecosm.com>
9982
9983         * gdbthread.h: Include "common/forward-scope-exit.h".
9984         (scoped_finish_thread_state): Redefine custom class in terms of
9985         forward_scope_exit.
9986
9987 2019-01-23  Pedro Alves  <palves@redhat.com>
9988             Andrew Burgess  <andrew.burgess@embecosm.com>
9989
9990         * common/forward-scope-exit.h: New file.
9991
9992 2019-01-23  Pedro Alves  <palves@redhat.com>
9993             Andrew Burgess  <andrew.burgess@embecosm.com>
9994             Tom Tromey  <tom@tromey.com>
9995
9996         * common/scope-exit.h: New file.
9997
9998 2019-01-23  Pedro Alves  <palves@redhat.com>
9999
10000         * common/preprocessor.h (ESC): Rename to ...
10001         (ESC_PARENS): ... this.
10002         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10003         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10004
10005 2019-01-23  Tom Tromey  <tom@tromey.com>
10006
10007         * language.h (class scoped_switch_to_sym_language_if_auto):
10008         Initialize m_lang in both cases.
10009
10010 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10011
10012         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10013         with XCNEW.
10014
10015 2019-01-22  Tom Tromey  <tom@tromey.com>
10016
10017         * corelow.c: Do not include sys/file.h.
10018
10019 2019-01-22  Tom Tromey  <tom@tromey.com>
10020
10021         * tui/tui-wingeneral.h: Include gdb_curses.h.
10022
10023 2019-01-22  Tom Tromey  <tom@tromey.com>
10024
10025         * source-cache.h (class source_cache) <get_source_lines,
10026         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10027
10028 2019-01-22  Tom Tromey  <tom@tromey.com>
10029
10030         * remote-fileio.h (struct remote_target): Declare.
10031
10032 2019-01-22  Tom Tromey  <tom@tromey.com>
10033
10034         * python/py-arch.c: Do not include py-ref.h.
10035         * python/py-bpevent.c: Do not include py-ref.h.
10036         * python/py-cmd.c: Do not include py-ref.h.
10037         * python/py-continueevent.c: Do not include py-ref.h.
10038         * python/py-event.h: Do not include py-ref.h.
10039         * python/py-evtregistry.c: Do not include py-ref.h.
10040         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10041         * python/py-frame.c: Do not include py-ref.h.
10042         * python/py-framefilter.c: Do not include py-ref.h.
10043         * python/py-function.c: Do not include py-ref.h.
10044         * python/py-infevents.c: Do not include py-ref.h.
10045         * python/py-linetable.c: Do not include py-ref.h.
10046         * python/py-objfile.c: Do not include py-ref.h.
10047         * python/py-param.c: Do not include py-ref.h.
10048         * python/py-prettyprint.c: Do not include py-ref.h.
10049         * python/py-progspace.c: Do not include py-ref.h.
10050         * python/py-symbol.c: Do not include py-ref.h.
10051         * python/py-symtab.c: Do not include py-ref.h.
10052         * python/py-type.c: Do not include py-ref.h.
10053         * python/py-unwind.c: Do not include py-ref.h.
10054         * python/py-utils.c: Do not include py-ref.h.
10055         * python/py-value.c: Do not include py-ref.h.
10056         * python/py-varobj.c: Do not include py-ref.h.
10057         * python/py-xmethods.c: Do not include py-ref.h.
10058         * python/python.c: Do not include py-ref.h.
10059         * varobj.c: Do not include py-ref.h.
10060
10061 2019-01-22  Tom Tromey  <tom@tromey.com>
10062
10063         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10064         keyword for bcache.
10065
10066 2019-01-22  Tom Tromey  <tom@tromey.com>
10067
10068         * compile/compile-cplus-types.c: Remove a comment by #include.
10069
10070 2019-01-22  Tom Tromey  <tom@tromey.com>
10071
10072         * compile/gcc-c-plugin.h: Include compile-internal.h.
10073
10074 2019-01-22  Tom Tromey  <tom@tromey.com>
10075
10076         * stabsread.c (EXTERN): Do not define.
10077         (symnum, next_symbol_text_func, processing_gcc_compilation)
10078         (within_function, global_sym_chain, global_stabs)
10079         (previous_stab_code, this_object_header_files)
10080         (n_this_object_header_files)
10081         (n_allocated_this_object_header_files): Define.
10082         * stabsread.h (EXTERN): Never define.  Use "extern".
10083
10084 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10085
10086         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10087         history_value.
10088
10089 2019-01-21  Tom Tromey  <tom@tromey.com>
10090
10091         * ui-out.c: Fix includes.
10092         * tui/tui-source.c: Fix includes.
10093         * target.c: Fix includes.
10094         * remote.c: Fix includes.
10095         * regcache.c: Fix includes.
10096         * python/py-block.c: Fix includes.
10097         * printcmd.c: Fix includes.
10098         * or1k-tdep.c: Fix includes.
10099         * mi/mi-main.c: Fix includes.
10100         * m32r-tdep.c: Fix includes.
10101         * csky-tdep.c: Fix includes.
10102         * compile/compile-cplus-types.c: Fix includes.
10103         * cli/cli-interp.c: Fix includes.
10104
10105 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10106
10107         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10108         for padding.
10109
10110 2019-01-16  Tom Tromey  <tom@tromey.com>
10111
10112         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10113         earlier.
10114         (struct objfile) <msymbols_range>: Move from top level.
10115         <msymbols>: New method.
10116         (class objfile_msymbols): Remove.
10117         * symtab.c (default_collect_symbol_completion_matches_break_on):
10118         Update.
10119         * symmisc.c (dump_msymbols): Update.
10120         * stabsread.c (scan_file_globals): Update.
10121         * objc-lang.c (info_selectors_command, info_classes_command)
10122         (find_methods): Update.
10123         * minsyms.c (find_solib_trampoline_target): Update.
10124         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10125         * coffread.c (coff_symfile_read): Update.
10126         * ada-lang.c (ada_lookup_simple_minsym)
10127         (ada_collect_symbol_completion_matches): Update.
10128
10129 2019-01-16  Tom Tromey  <tom@tromey.com>
10130
10131         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10132         type.  Remove no-argument constructor.
10133         <iterator::operator++>: Simplify.
10134         <begin>: Update.
10135         <end>: Use minimal_symbol_count.
10136
10137 2019-01-16  Tom Tromey  <tom@tromey.com>
10138
10139         * objfiles.h (struct objfile) <psymtabs>: New method.
10140         (class objfile_psymtabs): Remove.
10141         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10142         typedef.
10143         <range>: New method.
10144         (require_partial_symbols): Change return type.
10145         * psymtab.c (require_partial_symbols)
10146         (psym_expand_symtabs_matching): Update.
10147         * mdebugread.c (parse_partial_symbols): Update.
10148         * dbxread.c (dbx_end_psymtab): Update.
10149
10150 2019-01-15  Tom Tromey  <tom@tromey.com>
10151
10152         * symtab.c (lookup_objfile_from_block)
10153         (lookup_symbol_in_objfile_symtabs)
10154         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10155         (find_line_symtab, info_sources_command)
10156         (default_collect_symbol_completion_matches_break_on)
10157         (make_source_files_completion_list): Update.
10158         * symmisc.c (print_objfile_statistics, dump_objfile)
10159         (maintenance_print_symbols, maintenance_info_symtabs)
10160         (maintenance_check_symtabs, maintenance_info_line_tables):
10161         Update.
10162         * source.c (select_source_symtab)
10163         (forget_cached_source_info_for_objfile): Update.
10164         * objfiles.h (class objfile_compunits): Remove.
10165         (struct objfile) <compunits_range>: New typedef.
10166         (compunits): New method.
10167         * objfiles.c (objfile_relocate1): Update.
10168         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10169         * maint.c (count_symtabs_and_blocks): Update.
10170         * linespec.c (iterate_over_all_matching_symtabs): Update.
10171         * cp-support.c (add_symbol_overload_list_qualified): Update.
10172         * coffread.c (coff_symtab_read): Update.
10173         * ada-lang.c (add_nonlocal_symbols)
10174         (ada_collect_symbol_completion_matches)
10175         (ada_add_global_exceptions): Update.
10176
10177 2019-01-15  Tom Tromey  <tom@tromey.com>
10178
10179         * progspace.h (program_space) <objfiles_safe_range>: New
10180         typedef.
10181         <objfiles_safe>: New method.
10182         * objfiles.h (class all_objfiles_safe): Remove.
10183         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10184         * jit.c (jit_inferior_exit_hook): Update.
10185
10186 2019-01-17  Tom Tromey  <tom@tromey.com>
10187
10188         * progspace.h (program_space) <objfiles_range>: New typedef.
10189         <objfiles>: New method.
10190         <objfiles_head>: Rename from objfiles.
10191         (object_files): Update.
10192         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10193         * guile/scm-pretty-print.c
10194         (ppscm_find_pretty_printer_from_objfiles): Update.
10195         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10196         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10197         Update.
10198         * python/py-progspace.c (pspy_get_objfiles): Update.
10199         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10200         Update.
10201         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10202         (objfpy_lookup_objfile_by_build_id): Update.
10203         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10204         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10205         Update.
10206         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10207         (expand_symtab_containing_pc, lookup_objfile_from_block)
10208         (lookup_static_symbol, basic_lookup_transparent_type)
10209         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10210         (find_line_symtab, info_sources_command)
10211         (default_collect_symbol_completion_matches_break_on)
10212         (make_source_files_completion_list, find_main_name): Update.
10213         * symmisc.c (print_symbol_bcache_statistics)
10214         (print_objfile_statistics, maintenance_print_symbols)
10215         (maintenance_print_msymbols, maintenance_print_objfiles)
10216         (maintenance_info_symtabs, maintenance_check_symtabs)
10217         (maintenance_expand_symtabs, maintenance_info_line_tables):
10218         Update.
10219         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10220         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10221         (map_overlay_command, unmap_overlay_command)
10222         (simple_overlay_update, expand_symtabs_matching)
10223         (map_symbol_filenames): Update.
10224         * symfile-debug.c (set_debug_symfile): Update.
10225         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10226         Update.
10227         * source.c (select_source_symtab, forget_cached_source_info):
10228         Update.
10229         * solib.c (solib_read_symbols): Update.
10230         * solib-spu.c (append_ocl_sos): Update.
10231         * psymtab.c (maintenance_print_psymbols)
10232         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10233         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10234         * printcmd.c (info_symbol_command): Update.
10235         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10236         Update.
10237         * objfiles.h (class all_objfiles): Remove.
10238         * objfiles.c (have_partial_symbols, have_full_symbols)
10239         (have_minimal_symbols, qsort_cmp, update_section_map)
10240         (shared_objfile_contains_address_p)
10241         (default_iterate_over_objfiles_in_search_order): Update.
10242         * objc-lang.c (info_selectors_command, info_classes_command)
10243         (find_methods): Update.
10244         * minsyms.c (find_solib_trampoline_target): Update.
10245         * maint.c (maintenance_info_sections)
10246         (maintenance_translate_address, count_symtabs_and_blocks):
10247         Update.
10248         * main.c (captured_main_1): Update.
10249         * linux-thread-db.c (try_thread_db_load_from_pdir)
10250         (has_libpthread): Update.
10251         * linespec.c (iterate_over_all_matching_symtabs)
10252         (search_minsyms_for_name): Update.
10253         * jit.c (jit_find_objf_with_entry_addr): Update.
10254         * hppa-tdep.c (find_unwind_entry)
10255         (hppa_lookup_stub_minimal_symbol): Update.
10256         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10257         Update.
10258         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10259         (elf_gnu_ifunc_resolve_by_got): Update.
10260         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10261         * dwarf-index-write.c (save_gdb_index_command): Update.
10262         * cp-support.c (add_symbol_overload_list_qualified): Update.
10263         * breakpoint.c (create_overlay_event_breakpoint)
10264         (create_longjmp_master_breakpoint)
10265         (create_std_terminate_master_breakpoint)
10266         (create_exception_master_breakpoint): Update.
10267         * blockframe.c (find_pc_partial_function): Update.
10268         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10269         (ada_collect_symbol_completion_matches)
10270         (ada_add_global_exceptions): Update.
10271
10272 2019-01-17  Tom Tromey  <tom@tromey.com>
10273
10274         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10275         declare VEC.
10276         (solib_target_parse_libraries): Change return type.
10277         (library_list_start_segment, library_list_start_section)
10278         (library_list_end_library, library_list_start_library); Update.
10279         (solib_target_free_library_list): Remove.
10280         (solib_target_parse_libraries): Remove cleanup.  Change return
10281         type.
10282         (solib_target_current_sos): Update.
10283
10284 2019-01-17  Tom Tromey  <tromey@bapiya>
10285
10286         * valprint.c: Replace "the the" with "the".
10287         * symtab.c: Replace "the the" with "the".
10288         * solib.c: Replace "the the" with "the".
10289         * solib-dsbt.c: Replace "the the" with "the".
10290         * linespec.c: Replace "the the" with "the".
10291         * dwarf2loc.h: Replace "the the" with "the".
10292         * amd64-windows-tdep.c: Replace "the the" with "the".
10293         * aarch64-tdep.c: Replace "the the" with "the".
10294
10295 2019-01-16  Keith Seitz  <keiths@redhat.com>
10296
10297         PR gdb/23773
10298         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10299         <builder>: Rename to ..
10300         <m_builder>: ... this and make private.
10301         (dwarf2_cu::get_builder): New method.  Change all users of
10302         `builder' to use this method.
10303         (dwarf2_start_symtab): Move to ...
10304         (dwarf2_cu::start_symtab): ... here.  Update all callers
10305         (setup_type_unit_groups): Move to ...
10306         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10307         callers.
10308         (dwarf2_cu::reset_builder): New method.
10309         (process_full_compunit, process_full_type_unit): Use
10310         dwarf2_cu::reset_builder.
10311         (follow_die_offset): Record the ancestor CU if it is different
10312         from the followed DIE's CU.
10313         (follow_die_sig_1): Likewise.
10314
10315 2019-01-15  Tom Tromey  <tom@tromey.com>
10316
10317         * remote.c (class remote_state) <buf>: Now a char_vector.
10318         <buf_size>: Remove.
10319         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10320         parameter.
10321         (remote_target::getpkt_or_notif_sane_1)
10322         (remote_target::getpkt_sane)
10323         (remote_target::getpkt_or_notif_sane): Likewise.
10324         (class remote_target) <putpkt>: New overload.
10325         (remote_target::read_frame): Change type of "buf_p".  Remove
10326         sizeof_p parameter.
10327         (packet_ok): New overload.
10328         (packet_check_result): New overload.
10329         Update all uses.
10330
10331 2019-01-14  Tom Tromey  <tom@tromey.com>
10332
10333         * remote-notif.c (handle_notification, remote_notif_ack)
10334         (remote_notif_parse): Make "buf" const.
10335         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10336         const.
10337         (remote_notif_parse, remote_notif_ack, handle_notification):
10338         Likewise.
10339         * remote.c (remote_notif_stop_parse): Make "buf" const.
10340         (remote_target::remote_parse_stop_reply): Make "buf" const.
10341         (remote_notif_stop_ack): Make "buf" const.
10342
10343 2019-01-14  Tom Tromey  <tom@tromey.com>
10344
10345         * remote.c (remote_console_output): Make parameter const.
10346
10347 2019-01-14  Tom Tromey  <tom@tromey.com>
10348
10349         * target-debug.h (target_debug_print_signals): Constify.
10350         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10351         * procfs.c (procfs_target::pass_signals): Update.
10352         * linux-nat.c (linux_nat_target::pass_signals): Update.
10353         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10354         * target-delegates.c: Rebuild.
10355         * remote.c (remote_target::program_signals): Update.
10356         (remote_target::pass_signals): Update.
10357         * target.c (target_pass_signals): Constify argument.
10358         (target_program_signals): Likewise.
10359         * target.h (struct target_ops) <pass_signals, program_signals>:
10360         Constify argument.
10361         (target_pass_signals, target_program_signals): Constify argument.
10362
10363 2019-01-14  Tom Tromey  <tom@tromey.com>
10364
10365         PR tui/28819:
10366         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10367
10368 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10369
10370         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10371         field.
10372         * rs6000-tdep.c: Include reggroups.h.
10373         (IS_V_ALIAS_PSEUDOREG): Define.
10374         (rs6000_register_name): Return names for the "vX" aliases.
10375         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10376         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10377         aliases.  Call default_register_reggroup_p for all other
10378         pseudo-registers.
10379         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10380         New functions.
10381         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10382         Handle "vX" aliases.
10383         (v_alias_pseudo_register_collect): New function.
10384         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10385         (rs6000_gdbarch_init): Initialize "vX" aliases as
10386         pseudo-registers.  Restore registration of
10387         rs6000_pseudo_register_reggroup_p with
10388         set_tdesc_pseudo_register_reggroup_p.
10389
10390 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10391
10392         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10393         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10394         set_gdbarch_num_pseudo_regs.
10395
10396 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10397
10398         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10399         Remove arg prefixname, add do_set and do_show.
10400         Add member functions set_list and show_list.
10401         * cli/cli-style.c (class cli_style_option): Update accordingly.
10402         (style_set_list): Move to file scope.
10403         (style_show_list): Likewise.
10404         (set_style): Call help_list.
10405         (show_style): Call cmd_show_list.
10406         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10407         Update to use the new macro.
10408
10409 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10410
10411         * ada-lang.c (_initialize_ada_language): Expand the help text
10412         for the "catch exception" command.
10413
10414 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10415
10416         * symtab.c (matching_obj_sections): Initialize obj,
10417         declare it closer to its usage.
10418
10419 2019-01-10  Tom Tromey  <tom@tromey.com>
10420
10421         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10422         (basic_inf_threads_range): Remove.
10423         (inf_threads_range, inf_non_exited_threads_range)
10424         (safe_inf_threads_range): Use next_adapter.
10425
10426 2019-01-10  Keith Seitz  <keiths@redhat.com>
10427
10428         PR gdb/23712
10429         PR symtab/23010
10430         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10431         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10432
10433 2019-01-10  Keith Seitz  <keiths@redhat.com>
10434
10435         PR gdb/23712
10436         PR symtab/23010
10437         * dictionary.c (pending_to_vector): Remove.
10438         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10439         Remove _1 suffix, replacing functions of the same name.  Update
10440         all callers.
10441         (dict_create_hashed, dict_create_hashed_expandable)
10442         (dict_create_linear, dict_create_linear_expandable, dict_free)
10443         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10444         Make functions static.
10445
10446 2019-01-10  Keith Seitz  <keiths@redhat.com>
10447
10448         PR gdb/23712
10449         PR symtab/23010
10450         * dictionary.h (struct dictionary): Replace declaration with
10451         multidictionary.
10452         (dict_create_hashed, dict_create_hashed_expandable)
10453         (dict_create_linear, dict_create_linear_expandable)
10454         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10455         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10456         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10457         taking multidictionary argument.
10458         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10459         * block.h (struct block) <dict>: Change to multidictionary
10460         and rename `multidict'.
10461         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10462         symmisc.c: Update all dictionary references to multidictionary.
10463
10464 2019-01-10  Keith Seitz  <keiths@redhat.com>
10465
10466         PR gdb/23712
10467         PR symtab/23010
10468         * dictionary.c: Include unordered_map.
10469         (pending_to_vector): New function.
10470         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10471         Rewrite the non-"_1" functions to take vector instead
10472         of linked list.
10473         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10474         "new" _1 versions of the same name.
10475         (multidictionary): Define.
10476         (std::hash<enum language): New definition.
10477         (collate_pending_symbols_by_language, mdict_create_hashed)
10478         (mdict_create_hashed_expandable, mdict_create_linear)
10479         (mdict_create_linear_expandable, mdict_free)
10480         (find_language_dictionary, create_new_language_dictionary)
10481         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10482         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10483         (mdict_size, mdict_empty): New functions.
10484         * dictionary.h (mdict_iterator): Define.
10485
10486 2019-01-10  Pedro Alves  <palves@redhat.com>
10487
10488         * breakpoint.c (read_uploaded_action)
10489         (create_tracepoint_from_upload): Adjust to use
10490         gdb::unique_xmalloc_ptr.
10491         * ctf.c (ctf_write_uploaded_tp):
10492         (SET_ARRAY_FIELD): Use emplace_back.
10493         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10494         * tracefile-tfile.c (tfile_write_uploaded_tp):
10495         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10496         gdb::unique_xmalloc_ptr.
10497         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10498         at_string, cond_string, cmd_strings>: Replace char pointers
10499         with gdb::unique_xmalloc_ptr.
10500
10501 2019-01-10  Pedro Alves  <palves@redhat.com>
10502
10503         * solib-target.c (library_list_start_library): Don't xstrdup name.
10504
10505 2019-01-10  Pedro Alves  <palves@redhat.com>
10506
10507         * mdebugread.c (parse_partial_symbols): Use
10508         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10509
10510 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10511
10512         * linux-fork.c (scoped_switch_fork_info)
10513         <~scoped_switch_fork_info>: Fix incorrect variable name.
10514
10515 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10516
10517         * linux-fork.c (scoped_switch_fork_info)
10518         <scoped_switch_fork_info>: Make explicit.
10519         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10520
10521 2019-01-10  Tom Tromey  <tom@tromey.com>
10522
10523         * objfiles.h (objfile::reset_psymtabs): Update.
10524         * objfiles.c (objfile::objfile): Update.
10525         * psymtab.h (psymtab_storage::obstack): Update.
10526         (psymtab_storage::m_obstack): Use gdb::optional.
10527         (class psymtab_storage): Update comment.  Remove objfile
10528         parameter.
10529         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10530
10531 2019-01-10  Tom Tromey  <tom@tromey.com>
10532
10533         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10534         <free_psymtabs>: Now private.
10535         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10536         (allocate_psymtab): Use new method.
10537
10538 2019-01-10  Tom Tromey  <tom@tromey.com>
10539
10540         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10541         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10542         * mdebugread.c (parse_partial_symbols): Use
10543         allocate_dependencies.
10544         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10545         allocate_dependencies.
10546         (process_psymtab_comp_unit_reader)
10547         (build_type_psymtab_dependencies): Likewise.
10548         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10549
10550 2019-01-10  Tom Tromey  <tom@tromey.com>
10551
10552         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10553         PSYMBOL_SET_LANGUAGE.
10554         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10555
10556 2019-01-10  Tom Tromey  <tom@tromey.com>
10557
10558         * psymtab.h (psymtab_storage::obstack): New method.
10559         <m_obstack>: Rename from obstack; now private.
10560         * psymtab.c (psymtab_storage): Update.
10561         * dwarf2read.c (create_addrmap_from_index)
10562         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10563         Update.
10564
10565 2019-01-10  Tom Tromey  <tom@tromey.com>
10566
10567         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10568         * objfiles.h (objfile::reset_psymtabs): New method.
10569
10570 2019-01-10  Tom Tromey  <tom@tromey.com>
10571
10572         * symmisc.c (print_symbol_bcache_statistics): Update.
10573         (print_objfile_statistics): Update.
10574         * symfile.c (reread_symbols): Update.
10575         * psymtab.h (class psymtab_storage): New.
10576         * psymtab.c (psymtab_storage): New constructor.
10577         (~psymtab_storage): New destructor.
10578         (require_partial_symbols): Update.
10579         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10580         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10581         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10582         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10583         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10584         (start_psymtab_common, end_psymtab_common)
10585         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10586         (allocate_psymtab): Update.
10587         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10588         Update.
10589         (dump_psymtab_addrmap, maintenance_print_psymbols)
10590         (maintenance_check_psymtabs): Update.
10591         (class objfile_psymtabs): Move to objfiles.h.
10592         * psympriv.h (discard_psymtab): Now inline.
10593         (psymtab_discarder::psymtab_discarder): Update.
10594         (psymtab_discarder::~psymtab_discarder): Update.
10595         (ALL_OBJFILE_PSYMTABS): Rewrite.
10596         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10597         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10598         Remove fields.
10599         <partial_symtabs>: New field.
10600         (class objfile_psymtabs): Move from psymtab.h.  Update.
10601         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10602         psymbol_cache.
10603         (objfile::~objfile): Don't destroy psymbol_cache.
10604         * mdebugread.c (parse_partial_symbols): Update.
10605         * dwarf2read.c (create_addrmap_from_index)
10606         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10607         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10608         (add_partial_subprogram, dwarf2_ranges_read): Update.
10609         * dwarf-index-write.c (write_address_map)
10610         (write_one_signatured_type, recursively_write_psymbols)
10611         (class debug_names, class debug_names, write_psymtabs_to_index):
10612         Update.
10613
10614 2019-01-10  Tom Tromey  <tom@tromey.com>
10615
10616         * symtab.h (SYMBOL_SET_NAMES): Update.
10617         (symbol_set_names): Update.
10618         (MSYMBOL_SET_NAMES): Update.
10619         * symtab.c (symbol_set_names): Change argument to be an
10620         objfile_per_bfd_storage.
10621         * psymtab.c (add_psymbol_to_bcache): Update.
10622         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10623
10624 2019-01-10  Tom Tromey  <tom@tromey.com>
10625
10626         * symtab.c (create_demangled_names_hash): Change argument to be an
10627         objfile_per_bfd_storage.
10628         (symbol_set_names): Update.
10629
10630 2019-01-10  Tom Tromey  <tom@tromey.com>
10631
10632         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10633         init_psymbol_list.
10634         * psymtab.c (init_psymbol_list): Do nothing if already called.
10635         * psympriv.h (init_psymbol_list): Add comment.
10636         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10637         init_psymbol_list.
10638         * dbxread.c (dbx_symfile_read): Unconditionally call
10639         init_psymbol_list.
10640
10641 2019-01-10  Tom Tromey  <tom@tromey.com>
10642
10643         * xcoffread.c (scan_xcoff_symtab): Update.
10644         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10645         "where".
10646         * mdebugread.c (parse_partial_symbols)
10647         (handle_psymbol_enumerators): Update.
10648         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10649         * dbxread.c (read_dbx_symtab): Update.
10650         * psympriv.h (psymbol_placement): New enum.
10651         (add_psymbol_to_list): Update.
10652
10653 2019-01-10  Tom Tromey  <tom@tromey.com>
10654
10655         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10656         static_psymbols parameters.
10657         (scan_xcoff_symtab): Update.
10658         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10659         static_psymbols parameters.
10660         * psympriv.h (start_psymtab_common): Update.
10661         * mdebugread.c (parse_partial_symbols): Update.
10662         * dwarf2read.c (create_partial_symtab): Update.
10663         * dbxread.c (read_dbx_symtab): Update.
10664         (start_psymtab): Remove global_psymbols and static_psymbols
10665         parameters.
10666
10667 2019-01-10  Tom Tromey  <tom@tromey.com>
10668
10669         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10670         * psymtab.c (allocate_psymtab): Add comment.
10671         * psympriv.h (allocate_psymtab): Add comment.
10672         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10673         initializations.
10674         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10675
10676 2019-01-10  Tom Tromey  <tom@tromey.com>
10677
10678         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10679         Don't declare.
10680         * mipsread.c: Include mdebugread.h.
10681         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10682         Declare.
10683         * elfread.c: Include mdebugread.h.
10684
10685 2019-01-09  Tom Tromey  <tom@tromey.com>
10686
10687         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10688         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10689         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10690         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10691         (psym_lookup_symbol, psym_find_last_source_symtab)
10692         (psym_forget_cached_source_info, psym_print_stats)
10693         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10694         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10695         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10696         (psym_find_compunit_symtab_by_address)
10697         (maintenance_print_psymbols, maintenance_info_psymtabs)
10698         (maintenance_check_psymtabs): Use ranged for.
10699         * psymtab.h (class objfile_psymtabs): New.
10700         (require_partial_symbols): Return objfile_psymtabs.
10701         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10702
10703 2019-01-09  Tom Tromey  <tom@tromey.com>
10704
10705         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10706         (find_pc_mapped_section, list_overlays_command)
10707         (map_overlay_command, unmap_overlay_command)
10708         (simple_overlay_update): Use all_objfiles.
10709         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10710         * printcmd.c (info_symbol_command): Use all_objfiles.
10711         * objfiles.h (ALL_OBJSECTIONS): Remove.
10712         * maint.c (maintenance_translate_address): Use all_objfiles.
10713         * gcore.c (gcore_create_callback): Use all_objfiles.
10714         (objfile_find_memory_regions): Likewise.
10715
10716 2019-01-09  Tom Tromey  <tom@tromey.com>
10717
10718         * symtab.c (find_line_symtab, info_sources_command)
10719         (make_source_files_completion_list): Use objfile_compunits.
10720         * source.c (select_source_symtab): Use objfile_compunits.
10721         * objfiles.h (struct objfile): Update comment.
10722         (ALL_OBJFILES): Remove.
10723         (ALL_FILETABS): Remove.
10724         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10725         objfile_compunits.
10726
10727 2019-01-09  Tom Tromey  <tom@tromey.com>
10728
10729         * symmisc.c (print_objfile_statistics, dump_objfile)
10730         (maintenance_print_symbols): Use compunit_filetabs.
10731         * source.c (forget_cached_source_info_for_objfile): Use
10732         compunit_filetabs.
10733         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10734         (ALL_FILETABS): Use compunit_filetabs.
10735         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10736         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10737
10738 2019-01-09  Tom Tromey  <tom@tromey.com>
10739
10740         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10741         (compunit_filetabs): New.
10742         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10743         compunit_filetabs.
10744         (info_sources_command, make_source_files_completion_list): Remove
10745         declaration.
10746         * symmisc.c (print_objfile_statistics, dump_objfile)
10747         (maintenance_print_symbols): Remove declaration.
10748         (maintenance_info_symtabs): Use compunit_filetabs.
10749         (maintenance_info_line_tables): Likewise.
10750         * source.c (select_source_symtab): Change local variable name.
10751         (forget_cached_source_info_for_objfile): Remove declaration.
10752         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10753         * objfiles.c (objfile_relocate1): Remove declaration.
10754         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10755         declaration.
10756         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10757         * coffread.c (coff_symtab_read): Remove declaration.
10758         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10759         compunit_filetabs.
10760
10761 2019-01-09  Tom Tromey  <tom@tromey.com>
10762
10763         * symtab.c (lookup_objfile_from_block)
10764         (find_pc_sect_compunit_symtab, search_symbols)
10765         (default_collect_symbol_completion_matches_break_on): Use
10766         objfile_compunits.
10767         * objfiles.h (ALL_COMPUNITS): Remove.
10768         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10769         * cp-support.c (add_symbol_overload_list_qualified): Use
10770         objfile_compunits.
10771         * ada-lang.c (ada_collect_symbol_completion_matches)
10772         (ada_add_global_exceptions): Use objfile_compunits.
10773
10774 2019-01-09  Tom Tromey  <tom@tromey.com>
10775
10776         * source.c (select_source_symtab)
10777         (forget_cached_source_info_for_objfile): Remove declaration.
10778         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10779         declaration.
10780         * maint.c (count_symtabs_and_blocks): Remove declaration.
10781         * cp-support.c (add_symbol_overload_list_qualified): Remove
10782         declaration.
10783         * coffread.c (coff_symtab_read): Remove declaration.
10784         * symtab.c (lookup_symbol_in_objfile_symtabs)
10785         (basic_lookup_transparent_type_1): Use objfile_compunits.
10786         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10787         (info_sources_command, search_symbols)
10788         (default_collect_symbol_completion_matches_break_on)
10789         (make_source_files_completion_list): Remove declaration.
10790         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10791         (ada_collect_symbol_completion_matches)
10792         (ada_add_global_exceptions): Remove declaration.
10793         * linespec.c (iterate_over_all_matching_symtabs): Use
10794         objfile_compunits.
10795         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10796         (class objfile_compunits): New.
10797         (ALL_COMPUNITS): Use objfile_compunits.
10798         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10799         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10800         objfile_compunits.
10801         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10802
10803 2019-01-09  Tom Tromey  <tom@tromey.com>
10804
10805         * symtab.c (search_symbols)
10806         (default_collect_symbol_completion_matches_break_on): Use
10807         objfile_msymbols.
10808         * ada-lang.c (ada_lookup_simple_minsym)
10809         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10810         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10811         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10812         objfile_msymbols.
10813         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10814         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10815         * objc-lang.c (find_methods): Use objfile_msymbols.
10816         (info_selectors_command, info_classes_command): Likewise.
10817         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10818         * objfiles.h (class objfile_msymbols): New.
10819         (ALL_OBJFILE_MSYMBOLS): Remove.
10820         (ALL_MSYMBOLS): Remove.
10821
10822 2019-01-09  Tom Tromey  <tom@tromey.com>
10823
10824         * common/next-iterator.h (next_adapter): Add Iterator template
10825         parameter.
10826         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10827         (class all_objfiles_safe): New.
10828         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10829         * objfiles.c (put_objfile_before): Update comment.
10830         (add_separate_debug_objfile): Likewise.
10831         (free_all_objfiles): Use all_objfiles_safe.
10832         (objfile_purge_solibs): Likewise.
10833
10834 2019-01-09  Tom Tromey  <tom@tromey.com>
10835
10836         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10837         (expand_symtab_containing_pc, lookup_static_symbol)
10838         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10839         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10840         all_objfiles.
10841         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10842         * breakpoint.c (create_overlay_event_breakpoint)
10843         (create_longjmp_master_breakpoint)
10844         (create_std_terminate_master_breakpoint)
10845         (create_exception_master_breakpoint): Use all_objfiles.
10846         * linux-thread-db.c (try_thread_db_load_from_pdir)
10847         (has_libpthread): Use all_objfiles.
10848         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10849         * linespec.c (iterate_over_all_matching_symtabs)
10850         (search_minsyms_for_name): Use all_objfiles.
10851         * maint.c (maintenance_info_sections): Use all_objfiles.
10852         * main.c (captured_main_1): Use all_objfiles.
10853         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10854         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10855         * guile/scm-pretty-print.c
10856         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10857         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10858         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10859         (maintenance_print_msymbols): Use all_objfiles.
10860         * source.c (select_source_symtab): Use all_objfiles.
10861         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10862         * symfile.c (remove_symbol_file_command)
10863         (expand_symtabs_matching, map_symbol_filenames): Use
10864         all_objfiles.
10865         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10866         all_objfiles.
10867         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10868         * objc-lang.c (find_methods): Use all_objfiles.
10869         * objfiles.c (have_partial_symbols, have_full_symbols)
10870         (have_minimal_symbols, qsort_cmp)
10871         (default_iterate_over_objfiles_in_search_order): Use
10872         all_objfiles.
10873         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10874         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10875         (maintenance_check_psymtabs): Use all_objfiles.
10876         (ALL_PSYMTABS): Remove.
10877         * compile/compile-object-run.c (do_module_cleanup): Use
10878         all_objfiles.
10879         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10880         * cp-support.c (add_symbol_overload_list_qualified): Use
10881         all_objfiles.
10882         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10883         Use all_objfiles.
10884         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10885         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10886         all_objfiles.
10887         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10888         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10889         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10890         Uses all_objfiles.
10891         * solib.c (solib_read_symbols): Use all_objfiles
10892
10893 2019-01-09  Tom Tromey  <tom@tromey.com>
10894
10895         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10896         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10897         all_objfiles.
10898         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10899         * symmisc.c (print_symbol_bcache_statistics)
10900         (print_objfile_statistics, maintenance_print_objfiles)
10901         (maintenance_info_symtabs, maintenance_check_symtabs)
10902         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10903         all_objfiles.
10904         * source.c (forget_cached_source_info): Use all_objfiles.
10905         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10906         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10907         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10908         * objfiles.c (update_section_map): Use all_objfiles.
10909         (shared_objfile_contains_address_p): Likewise.
10910         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10911         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10912
10913 2019-01-09  Tom Tromey  <tom@tromey.com>
10914
10915         * common/next-iterator.h: New file.
10916         * objfiles.h (class all_objfiles): New.
10917         (struct objfile_iterator): New.
10918
10919 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10920
10921         * NEWS: Move the description of the changed "frame", "select-frame",
10922          and "info frame" commands to the Changed commands section.
10923
10924 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10925
10926         * gdbtypes.c (check_stub_method_group): Remove handling of old
10927         mangling schemes.
10928         * linespec.c (find_methods): Likewise.
10929         * stabsread.c (read_member_functions): Likewise.
10930         * valops.c (search_struct_method): Likewise.
10931         (value_struct_elt_for_reference): Likewise.
10932         * NEWS: Mention this change.
10933
10934 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10935
10936         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10937         print_source_lines.
10938         * source.c (print_source_lines_base): Update line number check.
10939         (print_source_lines): New function.
10940         (source_lines_range::source_lines_range): New function.
10941         * source.h (class source_lines_range): New class.
10942         (print_source_lines): New declaration.
10943
10944 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10945
10946         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10947
10948 2019-01-08  Tom Tromey  <tom@tromey.com>
10949             Simon Marchi  <simon.marchi@ericsson.com>
10950
10951         PR gdb/24060
10952         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10953         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10954         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10955         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10956         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10957         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10958
10959 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10960
10961         * source.c (select_source_symtab): Move header comment to
10962         declaration in source.h.
10963         (forget_cached_source_info_for_objfile): Likewise.
10964         (forget_cached_source_info): Likewise.
10965         (identify_source_line): Likewise.
10966         * source.h (identify_source_line): Move declaration from symtab.h
10967         and add comment from source.c
10968         (print_source_lines): Likewise.
10969         (forget_cached_source_info_for_objfile): Likewise.
10970         (forget_cached_source_info): Likewise.
10971         (select_source_symtab): Likewise.
10972         (enum print_source_lines_flag): Move definition from symtab.h.
10973         * symtab.h (identify_source_line): Move declaration to source.h.
10974         (print_source_lines): Likewise.
10975         (forget_cached_source_info_for_objfile): Likewise.
10976         (forget_cached_source_info): Likewise.
10977         (select_source_symtab): Likewise.
10978         (enum print_source_lines_flag): Move definition to source.h.
10979         * tui/tui-hooks.c: Add 'source.h' include.
10980
10981 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10982
10983         * source.c (print_source_lines_base): Handle requests to print
10984         reverse line number sequences, and guard against empty lines
10985         string.
10986
10987 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10988
10989         * source.c (print_source_lines_base): Fix skip of '\r' if next
10990         character is '\n'.
10991
10992 2019-01-06  Tom Tromey  <tom@tromey.com>
10993
10994         * c-exp.y (struct c_parse_state) <macro_original_text,
10995         expansion_obstack>: New member.
10996         (macro_original_text, expansion_obstack): Remove globals.
10997         (scan_macro_expansion, scanning_macro_expansion)
10998         (finished_macro_expansion): Update.
10999         (scan_macro_cleanup): Remove.
11000         (yylex, c_parse): Update.
11001
11002 2019-01-06  Tom Tromey  <tom@tromey.com>
11003
11004         * c-exp.y (struct c_parse_state) <strings>: New member.
11005         (operator_stoken): Update.
11006
11007 2019-01-06  Tom Tromey  <tom@tromey.com>
11008
11009         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11010         (union type_stack_elt) <typelist_val>: Now a pointer to
11011         std::vector.
11012         (type_stack_cleanup): Don't declare.
11013         (push_typelist): Update.
11014         * parse.c (pop_typelist): Return a std::vector.
11015         (push_typelist): Take a std::vector.
11016         (follow_types): Update.  Do not free args.
11017         (type_stack_cleanup): Remove.
11018         * c-exp.y (struct c_parse_state): New.
11019         (cpstate): New global.
11020         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11021         (nonempty_typelist): Update.
11022         (func_mod): Create a new vector.
11023         (c_parse): Create a c_parse_state.
11024         (check_parameter_typelist): Do not delete params.
11025         (function_method): Update.  Do not delete type_list.
11026
11027 2019-01-06  Tom Tromey  <tom@tromey.com>
11028
11029         PR gdb/28155:
11030         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11031         check_typedef.
11032         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11033         (print_return_value): Likewise.
11034
11035 2019-01-05  Tom Tromey  <tom@tromey.com>
11036
11037         * contrib/cleanup_check.py: Remove.
11038         * contrib/gcc-with-excheck: Remove.
11039         * contrib/exsummary.py: Remove.
11040         * contrib/excheck.py: Remove.
11041
11042 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11043
11044         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11045         NULL. Initialize tpprev to NULL instead of assigning it
11046         to NULL on the next statement.
11047         * windows-nat.c (windows_delete_thread): Remove check for
11048         main_thread_id before printing thread exit notifications.
11049         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11050         Remove thread ID check against main_thread_id.
11051         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11052         windows_delete_thread.
11053         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11054
11055 2019-01-04  Tom Tromey  <tom@tromey.com>
11056
11057         * compile/compile.c (_initialize_compile): Use upper case for
11058         metasyntactic variables.
11059         * symmisc.c (_initialize_symmisc): Use upper case for
11060         metasyntactic variables.
11061         * psymtab.c (_initialize_psymtab): Use upper case for
11062         metasyntactic variables.
11063         * demangle.c (demangle_command): Use upper case for metasyntactic
11064         variables.
11065         (_initialize_demangler): Likewise.
11066         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11067         variables.
11068
11069 2019-01-03  Tom Tromey  <tom@tromey.com>
11070
11071         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11072
11073 2019-01-03  Tom Tromey  <tom@tromey.com>
11074
11075         * python/py-symtab.c (salpy_str): Update.
11076         (struct salpy_sal_object) <symtab>: Now a PyObject.
11077         (salpy_dealloc): Update.
11078         (del_objfile_sal): Use gdbpy_ref.
11079
11080 2019-01-03  Tom Tromey  <tom@tromey.com>
11081
11082         * python/py-type.c (convert_field): Use new_reference.  Return
11083         gdbpy_ref.
11084         (make_fielditem): Return gdbpy_ref.
11085         (typy_fields): Update.
11086         (typy_getitem): Update.
11087         (field_name): Return gdbpy_ref.  Use new_reference.
11088         (typy_iterator_iternext): Update.
11089
11090 2019-01-03  Tom Tromey  <tom@tromey.com>
11091
11092         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11093
11094 2019-01-03  Tom Tromey  <tom@tromey.com>
11095
11096         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11097         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11098         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11099         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11100         (pspy_set_type_printers): Likewise.
11101         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11102         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11103         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11104         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11105         (objfpy_set_type_printers): Likewise.
11106
11107 2019-01-03  Tom Tromey  <tom@tromey.com>
11108
11109         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11110         (gdbpy_print_stack): Use gdbpy_err_fetch.
11111         * python/python-internal.h (class gdbpy_err_fetch): New class.
11112         (class gdbpy_enter) <m_error_type, m_error_value,
11113         m_error_traceback>: Remove.
11114         <m_error>: New member.
11115         (gdbpy_exception_to_string): Don't declare.
11116         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11117         * python/py-value.c (convert_value_from_python): Use
11118         gdbpy_err_fetch.
11119         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11120         gdbpy_exception_to_string.
11121         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11122         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11123         gdbpy_err_fetch.
11124
11125 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11126
11127         * linux-nat.c (delete_lwp_cleanup): Delete.
11128         (struct lwp_deleter): New struct.
11129         (lwp_info_up): New typedef.
11130         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11131         lwp_info_up.
11132
11133 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11134
11135         * linux-fork.c (class scoped_switch_fork_info): New class.
11136         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11137
11138 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11139
11140         * valops.c (find_overload_match): Remove use of null_cleanup, and
11141         calls to do_cleanups.
11142
11143 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11144
11145         * compile/compile-cplus-types.c
11146         (compile_cplus_instance::decl_name): Handle changes to
11147         cp_func_name.
11148         * cp-support.c (cp_func_name): Update header comment, update
11149         return type.
11150         * cp-support.h (cp_func_name): Update return type in declaration.
11151         * valops.c (find_overload_match): Move temp_func local to top
11152         level of function and change its type.  Use temp_func to hold and
11153         delete temporary string obtained from cp_func_name.
11154
11155 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11156
11157         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11158         gdb::char_vector, remove cleanup, and update uses of `msg`.
11159
11160 2019-01-03  Jim Wilson  <jimw@sifive.com>
11161
11162         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11163
11164 2019-01-02  Tom Tromey  <tom@tromey.com>
11165
11166         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11167         (tdesc_parse_xml): Remove cleanups.
11168         * target-descriptions.h (make_cleanup_free_target_description):
11169         Don't declare.
11170         (target_desc_deleter): New struct.
11171         (target_desc_up): New typedef.
11172         * target-descriptions.c (target_desc_deleter::operator()): Rename
11173         from free_target_description.
11174         (make_cleanup_free_target_description): Remove.
11175
11176 2019-01-02  Tom Tromey  <tom@tromey.com>
11177
11178         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11179         constructor, destructor.
11180         (linespec_parser): Remove typedef.
11181         (~linespec_parser): Rename from linespec_parser_delete.
11182         (linespec_lex_to_end, linespec_complete_label)
11183         (linespec_complete): Update.
11184         (decode_line_full): Remove cleanups.
11185         (decode_line_1): Update.
11186
11187 2019-01-02  Tom Tromey  <tom@tromey.com>
11188
11189         * python/python-internal.h (inferior_to_inferior_object): Change
11190         return type.
11191         * python/py-exitedevent.c (create_exited_event_object): Update.
11192         * python/py-inferior.c (inferior_to_inferior_object): Return
11193         gdbpy_ref.
11194         (python_new_inferior, python_inferior_deleted)
11195         (thread_to_thread_object, delete_thread_object)
11196         (build_inferior_list, gdbpy_selected_inferior): Update.
11197         * python/py-infthread.c (create_thread_object): Update.  Also fail
11198         if inferior_to_inferior_object fails.
11199
11200 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11201
11202         * inferior.h (class inferior) <displaced_step_state>: New field.
11203         * infrun.h (struct displaced_step_state): Move here from
11204         infrun.c.  Initialize fields, add constructor.
11205         <inf>: Remove field.
11206         <reset>: New method.
11207         * infrun.c (struct displaced_step_inferior_state): Move to
11208         infrun.h.
11209         (displaced_step_inferior_states): Remove.
11210         (get_displaced_stepping_state): Adust.
11211         (displaced_step_in_progress_any_inferior): Adjust.
11212         (displaced_step_in_progress_thread): Adjust.
11213         (displaced_step_in_progress): Adjust.
11214         (add_displaced_stepping_state): Remove.
11215         (get_displaced_step_closure_by_addr): Adjust.
11216         (remove_displaced_stepping_state): Remove.
11217         (infrun_inferior_exit): Call displaced_step_state.reset.
11218         (use_displaced_stepping): Don't check for NULL.
11219         (displaced_step_prepare_throw): Call
11220         get_displaced_stepping_state.
11221         (displaced_step_fixup): Don't check for NULL.
11222         (prepare_for_detach): Don't check for NULL.
11223
11224 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11225
11226         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11227          in case of call that did not complete.
11228
11229 2019-01-02  Andrey Utkin  <autkin@undo.io>
11230
11231         * symfile.c (find_separate_debug_file): Fix search of debug files for
11232         remote debuggee.
11233
11234 2019-01-02  Tom Tromey  <tom@tromey.com>
11235
11236         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11237         indentation.
11238         * python/py-frame.c (frapy_older): Remove cast.
11239         (frapy_newer): Likewise.
11240         * python/py-breakpoint.c (local_setattro): Remove cast.
11241         * python/py-arch.c (archpy_name): Remove local variable.
11242         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11243
11244 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11245
11246         * unittests/basic_string_view/element_access/char/empty.cc:
11247         Fix year range in copyright header.
11248
11249 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11250
11251         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11252         Delete.
11253         <operator==>: Update with for removed field.
11254         <hash>: Likewise.
11255         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11256         <isa_features>: ...this.
11257         <abi_features>: New field.
11258         (riscv_isa_flen): Update comment.
11259         (riscv_abi_xlen): New declaration.
11260         (riscv_abi_flen): New declaration.
11261         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11262         isa_features.
11263         (riscv_abi_xlen): New function.
11264         (riscv_isa_flen): Update to get answer from isa_features.
11265         (riscv_abi_flen): New function.
11266         (riscv_has_fp_abi): Update to get answer from abi_features.
11267         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11268         xlen and flen.
11269         (riscv_call_info) <xlen, flen>: Update comment.
11270         (riscv_call_arg_struct): Remove invalid assertions
11271         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11272         is removed.
11273         (riscv_gdbarch_init): Gather isa features and abi features
11274         separately, ensure both match on the gdbarch when reusing an old
11275         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11276         a target with 64-bit float hardware.
11277
11278 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11279
11280         * source.c (search_command_helper): Stop reverse search
11281         when line 1 has been searched.
11282
11283 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11284
11285         * record-full.c (record_full_base_target::close): Rewrite
11286         record_full_core_buf_list free logic.
11287
11288 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11289
11290         * break-catch-syscall.c (print_one_catch_syscall): xfree
11291         the last text.
11292
11293 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11294
11295         * top.c (print_gdb_version): Update Copyright year in version
11296         message.
11297
11298 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11299
11300         Update copyright year range in all GDB files.
11301
11302 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11303
11304         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11305
11306 For older changes see ChangeLog-2018.
11307 \f
11308 Local Variables:
11309 mode: change-log
11310 left-margin: 8
11311 fill-column: 74
11312 version-control: never
11313 coding: utf-8
11314 End:
11315