gdb/ChangeLog

   1 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
   2
   3         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
   4         with XCNEW.
   5
   6 2019-01-22  Tom Tromey  <tom@tromey.com>
   7
   8         * corelow.c: Do not include sys/file.h.
   9
  10 2019-01-22  Tom Tromey  <tom@tromey.com>
  11
  12         * tui/tui-wingeneral.h: Include gdb_curses.h.
  13
  14 2019-01-22  Tom Tromey  <tom@tromey.com>
  15
  16         * source-cache.h (class source_cache) <get_source_lines,
  17         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
  18
  19 2019-01-22  Tom Tromey  <tom@tromey.com>
  20
  21         * remote-fileio.h (struct remote_target): Declare.
  22
  23 2019-01-22  Tom Tromey  <tom@tromey.com>
  24
  25         * python/py-arch.c: Do not include py-ref.h.
  26         * python/py-bpevent.c: Do not include py-ref.h.
  27         * python/py-cmd.c: Do not include py-ref.h.
  28         * python/py-continueevent.c: Do not include py-ref.h.
  29         * python/py-event.h: Do not include py-ref.h.
  30         * python/py-evtregistry.c: Do not include py-ref.h.
  31         * python/py-finishbreakpoint.c: Do not include py-ref.h.
  32         * python/py-frame.c: Do not include py-ref.h.
  33         * python/py-framefilter.c: Do not include py-ref.h.
  34         * python/py-function.c: Do not include py-ref.h.
  35         * python/py-infevents.c: Do not include py-ref.h.
  36         * python/py-linetable.c: Do not include py-ref.h.
  37         * python/py-objfile.c: Do not include py-ref.h.
  38         * python/py-param.c: Do not include py-ref.h.
  39         * python/py-prettyprint.c: Do not include py-ref.h.
  40         * python/py-progspace.c: Do not include py-ref.h.
  41         * python/py-symbol.c: Do not include py-ref.h.
  42         * python/py-symtab.c: Do not include py-ref.h.
  43         * python/py-type.c: Do not include py-ref.h.
  44         * python/py-unwind.c: Do not include py-ref.h.
  45         * python/py-utils.c: Do not include py-ref.h.
  46         * python/py-value.c: Do not include py-ref.h.
  47         * python/py-varobj.c: Do not include py-ref.h.
  48         * python/py-xmethods.c: Do not include py-ref.h.
  49         * python/python.c: Do not include py-ref.h.
  50         * varobj.c: Do not include py-ref.h.
  51
  52 2019-01-22  Tom Tromey  <tom@tromey.com>
  53
  54         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
  55         keyword for bcache.
  56
  57 2019-01-22  Tom Tromey  <tom@tromey.com>
  58
  59         * compile/compile-cplus-types.c: Remove a comment by #include.
  60
  61 2019-01-22  Tom Tromey  <tom@tromey.com>
  62
  63         * compile/gcc-c-plugin.h: Include compile-internal.h.
  64
  65 2019-01-22  Tom Tromey  <tom@tromey.com>
  66
  67         * stabsread.c (EXTERN): Do not define.
  68         (symnum, next_symbol_text_func, processing_gcc_compilation)
  69         (within_function, global_sym_chain, global_stabs)
  70         (previous_stab_code, this_object_header_files)
  71         (n_this_object_header_files)
  72         (n_allocated_this_object_header_files): Define.
  73         * stabsread.h (EXTERN): Never define.  Use "extern".
  74
  75 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  76
  77         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
  78         history_value.
  79
  80 2019-01-21  Tom Tromey  <tom@tromey.com>
  81
  82         * ui-out.c: Fix includes.
  83         * tui/tui-source.c: Fix includes.
  84         * target.c: Fix includes.
  85         * remote.c: Fix includes.
  86         * regcache.c: Fix includes.
  87         * python/py-block.c: Fix includes.
  88         * printcmd.c: Fix includes.
  89         * or1k-tdep.c: Fix includes.
  90         * mi/mi-main.c: Fix includes.
  91         * m32r-tdep.c: Fix includes.
  92         * csky-tdep.c: Fix includes.
  93         * compile/compile-cplus-types.c: Fix includes.
  94         * cli/cli-interp.c: Fix includes.
  95
  96 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
  97
  98         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
  99         for padding.
 100
 101 2019-01-16  Tom Tromey  <tom@tromey.com>
 102
 103         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
 104         earlier.
 105         (struct objfile) <msymbols_range>: Move from top level.
 106         <msymbols>: New method.
 107         (class objfile_msymbols): Remove.
 108         * symtab.c (default_collect_symbol_completion_matches_break_on):
 109         Update.
 110         * symmisc.c (dump_msymbols): Update.
 111         * stabsread.c (scan_file_globals): Update.
 112         * objc-lang.c (info_selectors_command, info_classes_command)
 113         (find_methods): Update.
 114         * minsyms.c (find_solib_trampoline_target): Update.
 115         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 116         * coffread.c (coff_symfile_read): Update.
 117         * ada-lang.c (ada_lookup_simple_minsym)
 118         (ada_collect_symbol_completion_matches): Update.
 119
 120 2019-01-16  Tom Tromey  <tom@tromey.com>
 121
 122         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
 123         type.  Remove no-argument constructor.
 124         <iterator::operator++>: Simplify.
 125         <begin>: Update.
 126         <end>: Use minimal_symbol_count.
 127
 128 2019-01-16  Tom Tromey  <tom@tromey.com>
 129
 130         * objfiles.h (struct objfile) <psymtabs>: New method.
 131         (class objfile_psymtabs): Remove.
 132         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
 133         typedef.
 134         <range>: New method.
 135         (require_partial_symbols): Change return type.
 136         * psymtab.c (require_partial_symbols)
 137         (psym_expand_symtabs_matching): Update.
 138         * mdebugread.c (parse_partial_symbols): Update.
 139         * dbxread.c (dbx_end_psymtab): Update.
 140
 141 2019-01-15  Tom Tromey  <tom@tromey.com>
 142
 143         * symtab.c (lookup_objfile_from_block)
 144         (lookup_symbol_in_objfile_symtabs)
 145         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
 146         (find_line_symtab, info_sources_command)
 147         (default_collect_symbol_completion_matches_break_on)
 148         (make_source_files_completion_list): Update.
 149         * symmisc.c (print_objfile_statistics, dump_objfile)
 150         (maintenance_print_symbols, maintenance_info_symtabs)
 151         (maintenance_check_symtabs, maintenance_info_line_tables):
 152         Update.
 153         * source.c (select_source_symtab)
 154         (forget_cached_source_info_for_objfile): Update.
 155         * objfiles.h (class objfile_compunits): Remove.
 156         (struct objfile) <compunits_range>: New typedef.
 157         (compunits): New method.
 158         * objfiles.c (objfile_relocate1): Update.
 159         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 160         * maint.c (count_symtabs_and_blocks): Update.
 161         * linespec.c (iterate_over_all_matching_symtabs): Update.
 162         * cp-support.c (add_symbol_overload_list_qualified): Update.
 163         * coffread.c (coff_symtab_read): Update.
 164         * ada-lang.c (add_nonlocal_symbols)
 165         (ada_collect_symbol_completion_matches)
 166         (ada_add_global_exceptions): Update.
 167
 168 2019-01-15  Tom Tromey  <tom@tromey.com>
 169
 170         * progspace.h (program_space) <objfiles_safe_range>: New
 171         typedef.
 172         <objfiles_safe>: New method.
 173         * objfiles.h (class all_objfiles_safe): Remove.
 174         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
 175         * jit.c (jit_inferior_exit_hook): Update.
 176
 177 2019-01-17  Tom Tromey  <tom@tromey.com>
 178
 179         * progspace.h (program_space) <objfiles_range>: New typedef.
 180         <objfiles>: New method.
 181         <objfiles_head>: Rename from objfiles.
 182         (object_files): Update.
 183         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
 184         * guile/scm-pretty-print.c
 185         (ppscm_find_pretty_printer_from_objfiles): Update.
 186         * guile/scm-objfile.c (gdbscm_objfiles): Update.
 187         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
 188         Update.
 189         * python/py-progspace.c (pspy_get_objfiles): Update.
 190         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 191         Update.
 192         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 193         (objfpy_lookup_objfile_by_build_id): Update.
 194         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 195         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 196         Update.
 197         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 198         (expand_symtab_containing_pc, lookup_objfile_from_block)
 199         (lookup_static_symbol, basic_lookup_transparent_type)
 200         (find_pc_sect_compunit_symtab, find_symbol_at_address)
 201         (find_line_symtab, info_sources_command)
 202         (default_collect_symbol_completion_matches_break_on)
 203         (make_source_files_completion_list, find_main_name): Update.
 204         * symmisc.c (print_symbol_bcache_statistics)
 205         (print_objfile_statistics, maintenance_print_symbols)
 206         (maintenance_print_msymbols, maintenance_print_objfiles)
 207         (maintenance_info_symtabs, maintenance_check_symtabs)
 208         (maintenance_expand_symtabs, maintenance_info_line_tables):
 209         Update.
 210         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
 211         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
 212         (map_overlay_command, unmap_overlay_command)
 213         (simple_overlay_update, expand_symtabs_matching)
 214         (map_symbol_filenames): Update.
 215         * symfile-debug.c (set_debug_symfile): Update.
 216         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
 217         Update.
 218         * source.c (select_source_symtab, forget_cached_source_info):
 219         Update.
 220         * solib.c (solib_read_symbols): Update.
 221         * solib-spu.c (append_ocl_sos): Update.
 222         * psymtab.c (maintenance_print_psymbols)
 223         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
 224         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
 225         * printcmd.c (info_symbol_command): Update.
 226         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
 227         Update.
 228         * objfiles.h (class all_objfiles): Remove.
 229         * objfiles.c (have_partial_symbols, have_full_symbols)
 230         (have_minimal_symbols, qsort_cmp, update_section_map)
 231         (shared_objfile_contains_address_p)
 232         (default_iterate_over_objfiles_in_search_order): Update.
 233         * objc-lang.c (info_selectors_command, info_classes_command)
 234         (find_methods): Update.
 235         * minsyms.c (find_solib_trampoline_target): Update.
 236         * maint.c (maintenance_info_sections)
 237         (maintenance_translate_address, count_symtabs_and_blocks):
 238         Update.
 239         * main.c (captured_main_1): Update.
 240         * linux-thread-db.c (try_thread_db_load_from_pdir)
 241         (has_libpthread): Update.
 242         * linespec.c (iterate_over_all_matching_symtabs)
 243         (search_minsyms_for_name): Update.
 244         * jit.c (jit_find_objf_with_entry_addr): Update.
 245         * hppa-tdep.c (find_unwind_entry)
 246         (hppa_lookup_stub_minimal_symbol): Update.
 247         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
 248         Update.
 249         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 250         (elf_gnu_ifunc_resolve_by_got): Update.
 251         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
 252         * dwarf-index-write.c (save_gdb_index_command): Update.
 253         * cp-support.c (add_symbol_overload_list_qualified): Update.
 254         * breakpoint.c (create_overlay_event_breakpoint)
 255         (create_longjmp_master_breakpoint)
 256         (create_std_terminate_master_breakpoint)
 257         (create_exception_master_breakpoint): Update.
 258         * blockframe.c (find_pc_partial_function): Update.
 259         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
 260         (ada_collect_symbol_completion_matches)
 261         (ada_add_global_exceptions): Update.
 262
 263 2019-01-17  Tom Tromey  <tom@tromey.com>
 264
 265         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
 266         declare VEC.
 267         (solib_target_parse_libraries): Change return type.
 268         (library_list_start_segment, library_list_start_section)
 269         (library_list_end_library, library_list_start_library); Update.
 270         (solib_target_free_library_list): Remove.
 271         (solib_target_parse_libraries): Remove cleanup.  Change return
 272         type.
 273         (solib_target_current_sos): Update.
 274
 275 2019-01-17  Tom Tromey  <tromey@bapiya>
 276
 277         * valprint.c: Replace "the the" with "the".
 278         * symtab.c: Replace "the the" with "the".
 279         * solib.c: Replace "the the" with "the".
 280         * solib-dsbt.c: Replace "the the" with "the".
 281         * linespec.c: Replace "the the" with "the".
 282         * dwarf2loc.h: Replace "the the" with "the".
 283         * amd64-windows-tdep.c: Replace "the the" with "the".
 284         * aarch64-tdep.c: Replace "the the" with "the".
 285
 286 2019-01-16  Keith Seitz  <keiths@redhat.com>
 287
 288         PR gdb/23773
 289         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
 290         <builder>: Rename to ..
 291         <m_builder>: ... this and make private.
 292         (dwarf2_cu::get_builder): New method.  Change all users of
 293         `builder' to use this method.
 294         (dwarf2_start_symtab): Move to ...
 295         (dwarf2_cu::start_symtab): ... here.  Update all callers
 296         (setup_type_unit_groups): Move to ...
 297         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
 298         callers.
 299         (dwarf2_cu::reset_builder): New method.
 300         (process_full_compunit, process_full_type_unit): Use
 301         dwarf2_cu::reset_builder.
 302         (follow_die_offset): Record the ancestor CU if it is different
 303         from the followed DIE's CU.
 304         (follow_die_sig_1): Likewise.
 305
 306 2019-01-15  Tom Tromey  <tom@tromey.com>
 307
 308         * remote.c (class remote_state) <buf>: Now a char_vector.
 309         <buf_size>: Remove.
 310         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
 311         parameter.
 312         (remote_target::getpkt_or_notif_sane_1)
 313         (remote_target::getpkt_sane)
 314         (remote_target::getpkt_or_notif_sane): Likewise.
 315         (class remote_target) <putpkt>: New overload.
 316         (remote_target::read_frame): Change type of "buf_p".  Remove
 317         sizeof_p parameter.
 318         (packet_ok): New overload.
 319         (packet_check_result): New overload.
 320         Update all uses.
 321
 322 2019-01-14  Tom Tromey  <tom@tromey.com>
 323
 324         * remote-notif.c (handle_notification, remote_notif_ack)
 325         (remote_notif_parse): Make "buf" const.
 326         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
 327         const.
 328         (remote_notif_parse, remote_notif_ack, handle_notification):
 329         Likewise.
 330         * remote.c (remote_notif_stop_parse): Make "buf" const.
 331         (remote_target::remote_parse_stop_reply): Make "buf" const.
 332         (remote_notif_stop_ack): Make "buf" const.
 333
 334 2019-01-14  Tom Tromey  <tom@tromey.com>
 335
 336         * remote.c (remote_console_output): Make parameter const.
 337
 338 2019-01-14  Tom Tromey  <tom@tromey.com>
 339
 340         * target-debug.h (target_debug_print_signals): Constify.
 341         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
 342         * procfs.c (procfs_target::pass_signals): Update.
 343         * linux-nat.c (linux_nat_target::pass_signals): Update.
 344         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
 345         * target-delegates.c: Rebuild.
 346         * remote.c (remote_target::program_signals): Update.
 347         (remote_target::pass_signals): Update.
 348         * target.c (target_pass_signals): Constify argument.
 349         (target_program_signals): Likewise.
 350         * target.h (struct target_ops) <pass_signals, program_signals>:
 351         Constify argument.
 352         (target_pass_signals, target_program_signals): Constify argument.
 353
 354 2019-01-14  Tom Tromey  <tom@tromey.com>
 355
 356         PR tui/28819:
 357         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
 358
 359 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 360
 361         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
 362         field.
 363         * rs6000-tdep.c: Include reggroups.h.
 364         (IS_V_ALIAS_PSEUDOREG): Define.
 365         (rs6000_register_name): Return names for the "vX" aliases.
 366         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
 367         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
 368         aliases.  Call default_register_reggroup_p for all other
 369         pseudo-registers.
 370         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
 371         New functions.
 372         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
 373         Handle "vX" aliases.
 374         (v_alias_pseudo_register_collect): New function.
 375         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
 376         (rs6000_gdbarch_init): Initialize "vX" aliases as
 377         pseudo-registers.  Restore registration of
 378         rs6000_pseudo_register_reggroup_p with
 379         set_tdesc_pseudo_register_reggroup_p.
 380
 381 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
 382
 383         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
 384         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
 385         set_gdbarch_num_pseudo_regs.
 386
 387 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 388
 389         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
 390         Remove arg prefixname, add do_set and do_show.
 391         Add member functions set_list and show_list.
 392         * cli/cli-style.c (class cli_style_option): Update accordingly.
 393         (style_set_list): Move to file scope.
 394         (style_show_list): Likewise.
 395         (set_style): Call help_list.
 396         (show_style): Call cmd_show_list.
 397         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
 398         Update to use the new macro.
 399
 400 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
 401
 402         * ada-lang.c (_initialize_ada_language): Expand the help text
 403         for the "catch exception" command.
 404
 405 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 406
 407         * symtab.c (matching_obj_sections): Initialize obj,
 408         declare it closer to its usage.
 409
 410 2019-01-10  Tom Tromey  <tom@tromey.com>
 411
 412         * thread-iter.h (inf_threads_iterator): Use next_iterator.
 413         (basic_inf_threads_range): Remove.
 414         (inf_threads_range, inf_non_exited_threads_range)
 415         (safe_inf_threads_range): Use next_adapter.
 416
 417 2019-01-10  Keith Seitz  <keiths@redhat.com>
 418
 419         PR gdb/23712
 420         PR symtab/23010
 421         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
 422         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
 423
 424 2019-01-10  Keith Seitz  <keiths@redhat.com>
 425
 426         PR gdb/23712
 427         PR symtab/23010
 428         * dictionary.c (pending_to_vector): Remove.
 429         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 430         Remove _1 suffix, replacing functions of the same name.  Update
 431         all callers.
 432         (dict_create_hashed, dict_create_hashed_expandable)
 433         (dict_create_linear, dict_create_linear_expandable, dict_free)
 434         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
 435         Make functions static.
 436
 437 2019-01-10  Keith Seitz  <keiths@redhat.com>
 438
 439         PR gdb/23712
 440         PR symtab/23010
 441         * dictionary.h (struct dictionary): Replace declaration with
 442         multidictionary.
 443         (dict_create_hashed, dict_create_hashed_expandable)
 444         (dict_create_linear, dict_create_linear_expandable)
 445         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
 446         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
 447         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
 448         taking multidictionary argument.
 449         [ALL_DICT_SYMBOLS]: Update for multidictionary.
 450         * block.h (struct block) <dict>: Change to multidictionary
 451         and rename `multidict'.
 452         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
 453         symmisc.c: Update all dictionary references to multidictionary.
 454
 455 2019-01-10  Keith Seitz  <keiths@redhat.com>
 456
 457         PR gdb/23712
 458         PR symtab/23010
 459         * dictionary.c: Include unordered_map.
 460         (pending_to_vector): New function.
 461         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 462         Rewrite the non-"_1" functions to take vector instead
 463         of linked list.
 464         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
 465         "new" _1 versions of the same name.
 466         (multidictionary): Define.
 467         (std::hash<enum language): New definition.
 468         (collate_pending_symbols_by_language, mdict_create_hashed)
 469         (mdict_create_hashed_expandable, mdict_create_linear)
 470         (mdict_create_linear_expandable, mdict_free)
 471         (find_language_dictionary, create_new_language_dictionary)
 472         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
 473         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
 474         (mdict_size, mdict_empty): New functions.
 475         * dictionary.h (mdict_iterator): Define.
 476
 477 2019-01-10  Pedro Alves  <palves@redhat.com>
 478
 479         * breakpoint.c (read_uploaded_action)
 480         (create_tracepoint_from_upload): Adjust to use
 481         gdb::unique_xmalloc_ptr.
 482         * ctf.c (ctf_write_uploaded_tp):
 483         (SET_ARRAY_FIELD): Use emplace_back.
 484         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
 485         * tracefile-tfile.c (tfile_write_uploaded_tp):
 486         * tracepoint.c (parse_tracepoint_definition): Adjust to use
 487         gdb::unique_xmalloc_ptr.
 488         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
 489         at_string, cond_string, cmd_strings>: Replace char pointers
 490         with gdb::unique_xmalloc_ptr.
 491
 492 2019-01-10  Pedro Alves  <palves@redhat.com>
 493
 494         * solib-target.c (library_list_start_library): Don't xstrdup name.
 495
 496 2019-01-10  Pedro Alves  <palves@redhat.com>
 497
 498         * mdebugread.c (parse_partial_symbols): Use
 499         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
 500
 501 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 502
 503         * linux-fork.c (scoped_switch_fork_info)
 504         <~scoped_switch_fork_info>: Fix incorrect variable name.
 505
 506 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 507
 508         * linux-fork.c (scoped_switch_fork_info)
 509         <scoped_switch_fork_info>: Make explicit.
 510         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
 511
 512 2019-01-10  Tom Tromey  <tom@tromey.com>
 513
 514         * objfiles.h (objfile::reset_psymtabs): Update.
 515         * objfiles.c (objfile::objfile): Update.
 516         * psymtab.h (psymtab_storage::obstack): Update.
 517         (psymtab_storage::m_obstack): Use gdb::optional.
 518         (class psymtab_storage): Update comment.  Remove objfile
 519         parameter.
 520         * psymtab.c (psymtab_storage::psymtab_storage): Update.
 521
 522 2019-01-10  Tom Tromey  <tom@tromey.com>
 523
 524         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
 525         <free_psymtabs>: Now private.
 526         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
 527         (allocate_psymtab): Use new method.
 528
 529 2019-01-10  Tom Tromey  <tom@tromey.com>
 530
 531         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
 532         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
 533         * mdebugread.c (parse_partial_symbols): Use
 534         allocate_dependencies.
 535         * dwarf2read.c (dwarf2_create_include_psymtab): Use
 536         allocate_dependencies.
 537         (process_psymtab_comp_unit_reader)
 538         (build_type_psymtab_dependencies): Likewise.
 539         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
 540
 541 2019-01-10  Tom Tromey  <tom@tromey.com>
 542
 543         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
 544         PSYMBOL_SET_LANGUAGE.
 545         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
 546
 547 2019-01-10  Tom Tromey  <tom@tromey.com>
 548
 549         * psymtab.h (psymtab_storage::obstack): New method.
 550         <m_obstack>: Rename from obstack; now private.
 551         * psymtab.c (psymtab_storage): Update.
 552         * dwarf2read.c (create_addrmap_from_index)
 553         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
 554         Update.
 555
 556 2019-01-10  Tom Tromey  <tom@tromey.com>
 557
 558         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
 559         * objfiles.h (objfile::reset_psymtabs): New method.
 560
 561 2019-01-10  Tom Tromey  <tom@tromey.com>
 562
 563         * symmisc.c (print_symbol_bcache_statistics): Update.
 564         (print_objfile_statistics): Update.
 565         * symfile.c (reread_symbols): Update.
 566         * psymtab.h (class psymtab_storage): New.
 567         * psymtab.c (psymtab_storage): New constructor.
 568         (~psymtab_storage): New destructor.
 569         (require_partial_symbols): Update.
 570         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
 571         (find_pc_sect_psymtab, find_pc_sect_psymbol)
 572         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
 573         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
 574         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
 575         (start_psymtab_common, end_psymtab_common)
 576         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
 577         (allocate_psymtab): Update.
 578         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
 579         Update.
 580         (dump_psymtab_addrmap, maintenance_print_psymbols)
 581         (maintenance_check_psymtabs): Update.
 582         (class objfile_psymtabs): Move to objfiles.h.
 583         * psympriv.h (discard_psymtab): Now inline.
 584         (psymtab_discarder::psymtab_discarder): Update.
 585         (psymtab_discarder::~psymtab_discarder): Update.
 586         (ALL_OBJFILE_PSYMTABS): Rewrite.
 587         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
 588         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
 589         Remove fields.
 590         <partial_symtabs>: New field.
 591         (class objfile_psymtabs): Move from psymtab.h.  Update.
 592         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
 593         psymbol_cache.
 594         (objfile::~objfile): Don't destroy psymbol_cache.
 595         * mdebugread.c (parse_partial_symbols): Update.
 596         * dwarf2read.c (create_addrmap_from_index)
 597         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 598         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
 599         (add_partial_subprogram, dwarf2_ranges_read): Update.
 600         * dwarf-index-write.c (write_address_map)
 601         (write_one_signatured_type, recursively_write_psymbols)
 602         (class debug_names, class debug_names, write_psymtabs_to_index):
 603         Update.
 604
 605 2019-01-10  Tom Tromey  <tom@tromey.com>
 606
 607         * symtab.h (SYMBOL_SET_NAMES): Update.
 608         (symbol_set_names): Update.
 609         (MSYMBOL_SET_NAMES): Update.
 610         * symtab.c (symbol_set_names): Change argument to be an
 611         objfile_per_bfd_storage.
 612         * psymtab.c (add_psymbol_to_bcache): Update.
 613         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
 614
 615 2019-01-10  Tom Tromey  <tom@tromey.com>
 616
 617         * symtab.c (create_demangled_names_hash): Change argument to be an
 618         objfile_per_bfd_storage.
 619         (symbol_set_names): Update.
 620
 621 2019-01-10  Tom Tromey  <tom@tromey.com>
 622
 623         * xcoffread.c (xcoff_initial_scan): Unconditionally call
 624         init_psymbol_list.
 625         * psymtab.c (init_psymbol_list): Do nothing if already called.
 626         * psympriv.h (init_psymbol_list): Add comment.
 627         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
 628         init_psymbol_list.
 629         * dbxread.c (dbx_symfile_read): Unconditionally call
 630         init_psymbol_list.
 631
 632 2019-01-10  Tom Tromey  <tom@tromey.com>
 633
 634         * xcoffread.c (scan_xcoff_symtab): Update.
 635         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
 636         "where".
 637         * mdebugread.c (parse_partial_symbols)
 638         (handle_psymbol_enumerators): Update.
 639         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
 640         * dbxread.c (read_dbx_symtab): Update.
 641         * psympriv.h (psymbol_placement): New enum.
 642         (add_psymbol_to_list): Update.
 643
 644 2019-01-10  Tom Tromey  <tom@tromey.com>
 645
 646         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
 647         static_psymbols parameters.
 648         (scan_xcoff_symtab): Update.
 649         * psymtab.c (start_psymtab_common): Remove global_psymbols and
 650         static_psymbols parameters.
 651         * psympriv.h (start_psymtab_common): Update.
 652         * mdebugread.c (parse_partial_symbols): Update.
 653         * dwarf2read.c (create_partial_symtab): Update.
 654         * dbxread.c (read_dbx_symtab): Update.
 655         (start_psymtab): Remove global_psymbols and static_psymbols
 656         parameters.
 657
 658 2019-01-10  Tom Tromey  <tom@tromey.com>
 659
 660         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
 661         * psymtab.c (allocate_psymtab): Add comment.
 662         * psympriv.h (allocate_psymtab): Add comment.
 663         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
 664         initializations.
 665         * dbxread.c (dbx_end_psymtab): Remove some initializations.
 666
 667 2019-01-10  Tom Tromey  <tom@tromey.com>
 668
 669         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 670         Don't declare.
 671         * mipsread.c: Include mdebugread.h.
 672         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 673         Declare.
 674         * elfread.c: Include mdebugread.h.
 675
 676 2019-01-09  Tom Tromey  <tom@tromey.com>
 677
 678         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
 679         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
 680         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
 681         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 682         (psym_lookup_symbol, psym_find_last_source_symtab)
 683         (psym_forget_cached_source_info, psym_print_stats)
 684         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 685         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 686         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 687         (psym_find_compunit_symtab_by_address)
 688         (maintenance_print_psymbols, maintenance_info_psymtabs)
 689         (maintenance_check_psymtabs): Use ranged for.
 690         * psymtab.h (class objfile_psymtabs): New.
 691         (require_partial_symbols): Return objfile_psymtabs.
 692         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
 693
 694 2019-01-09  Tom Tromey  <tom@tromey.com>
 695
 696         * symfile.c (overlay_invalidate_all, find_pc_overlay)
 697         (find_pc_mapped_section, list_overlays_command)
 698         (map_overlay_command, unmap_overlay_command)
 699         (simple_overlay_update): Use all_objfiles.
 700         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
 701         * printcmd.c (info_symbol_command): Use all_objfiles.
 702         * objfiles.h (ALL_OBJSECTIONS): Remove.
 703         * maint.c (maintenance_translate_address): Use all_objfiles.
 704         * gcore.c (gcore_create_callback): Use all_objfiles.
 705         (objfile_find_memory_regions): Likewise.
 706
 707 2019-01-09  Tom Tromey  <tom@tromey.com>
 708
 709         * symtab.c (find_line_symtab, info_sources_command)
 710         (make_source_files_completion_list): Use objfile_compunits.
 711         * source.c (select_source_symtab): Use objfile_compunits.
 712         * objfiles.h (struct objfile): Update comment.
 713         (ALL_OBJFILES): Remove.
 714         (ALL_FILETABS): Remove.
 715         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
 716         objfile_compunits.
 717
 718 2019-01-09  Tom Tromey  <tom@tromey.com>
 719
 720         * symmisc.c (print_objfile_statistics, dump_objfile)
 721         (maintenance_print_symbols): Use compunit_filetabs.
 722         * source.c (forget_cached_source_info_for_objfile): Use
 723         compunit_filetabs.
 724         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
 725         (ALL_FILETABS): Use compunit_filetabs.
 726         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
 727         * coffread.c (coff_symtab_read): Use compunit_filetabs.
 728
 729 2019-01-09  Tom Tromey  <tom@tromey.com>
 730
 731         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
 732         (compunit_filetabs): New.
 733         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
 734         compunit_filetabs.
 735         (info_sources_command, make_source_files_completion_list): Remove
 736         declaration.
 737         * symmisc.c (print_objfile_statistics, dump_objfile)
 738         (maintenance_print_symbols): Remove declaration.
 739         (maintenance_info_symtabs): Use compunit_filetabs.
 740         (maintenance_info_line_tables): Likewise.
 741         * source.c (select_source_symtab): Change local variable name.
 742         (forget_cached_source_info_for_objfile): Remove declaration.
 743         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
 744         * objfiles.c (objfile_relocate1): Remove declaration.
 745         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 746         declaration.
 747         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
 748         * coffread.c (coff_symtab_read): Remove declaration.
 749         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 750         compunit_filetabs.
 751
 752 2019-01-09  Tom Tromey  <tom@tromey.com>
 753
 754         * symtab.c (lookup_objfile_from_block)
 755         (find_pc_sect_compunit_symtab, search_symbols)
 756         (default_collect_symbol_completion_matches_break_on): Use
 757         objfile_compunits.
 758         * objfiles.h (ALL_COMPUNITS): Remove.
 759         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
 760         * cp-support.c (add_symbol_overload_list_qualified): Use
 761         objfile_compunits.
 762         * ada-lang.c (ada_collect_symbol_completion_matches)
 763         (ada_add_global_exceptions): Use objfile_compunits.
 764
 765 2019-01-09  Tom Tromey  <tom@tromey.com>
 766
 767         * source.c (select_source_symtab)
 768         (forget_cached_source_info_for_objfile): Remove declaration.
 769         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 770         declaration.
 771         * maint.c (count_symtabs_and_blocks): Remove declaration.
 772         * cp-support.c (add_symbol_overload_list_qualified): Remove
 773         declaration.
 774         * coffread.c (coff_symtab_read): Remove declaration.
 775         * symtab.c (lookup_symbol_in_objfile_symtabs)
 776         (basic_lookup_transparent_type_1): Use objfile_compunits.
 777         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
 778         (info_sources_command, search_symbols)
 779         (default_collect_symbol_completion_matches_break_on)
 780         (make_source_files_completion_list): Remove declaration.
 781         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
 782         (ada_collect_symbol_completion_matches)
 783         (ada_add_global_exceptions): Remove declaration.
 784         * linespec.c (iterate_over_all_matching_symtabs): Use
 785         objfile_compunits.
 786         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
 787         (class objfile_compunits): New.
 788         (ALL_COMPUNITS): Use objfile_compunits.
 789         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
 790         (maintenance_check_symtabs, maintenance_info_line_tables): Use
 791         objfile_compunits.
 792         * objfiles.c (objfile_relocate1): Use objfile_compunits.
 793
 794 2019-01-09  Tom Tromey  <tom@tromey.com>
 795
 796         * symtab.c (search_symbols)
 797         (default_collect_symbol_completion_matches_break_on): Use
 798         objfile_msymbols.
 799         * ada-lang.c (ada_lookup_simple_minsym)
 800         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
 801         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
 802         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
 803         objfile_msymbols.
 804         * coffread.c (coff_symfile_read): Use objfile_msymbols.
 805         * symmisc.c (dump_msymbols): Use objfile_msymbols.
 806         * objc-lang.c (find_methods): Use objfile_msymbols.
 807         (info_selectors_command, info_classes_command): Likewise.
 808         * stabsread.c (scan_file_globals): Use objfile_msymbols.
 809         * objfiles.h (class objfile_msymbols): New.
 810         (ALL_OBJFILE_MSYMBOLS): Remove.
 811         (ALL_MSYMBOLS): Remove.
 812
 813 2019-01-09  Tom Tromey  <tom@tromey.com>
 814
 815         * common/next-iterator.h (next_adapter): Add Iterator template
 816         parameter.
 817         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
 818         (class all_objfiles_safe): New.
 819         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
 820         * objfiles.c (put_objfile_before): Update comment.
 821         (add_separate_debug_objfile): Likewise.
 822         (free_all_objfiles): Use all_objfiles_safe.
 823         (objfile_purge_solibs): Likewise.
 824
 825 2019-01-09  Tom Tromey  <tom@tromey.com>
 826
 827         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 828         (expand_symtab_containing_pc, lookup_static_symbol)
 829         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
 830         (find_symbol_at_address, find_line_symtab, find_main_name): Use
 831         all_objfiles.
 832         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
 833         * breakpoint.c (create_overlay_event_breakpoint)
 834         (create_longjmp_master_breakpoint)
 835         (create_std_terminate_master_breakpoint)
 836         (create_exception_master_breakpoint): Use all_objfiles.
 837         * linux-thread-db.c (try_thread_db_load_from_pdir)
 838         (has_libpthread): Use all_objfiles.
 839         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
 840         * linespec.c (iterate_over_all_matching_symtabs)
 841         (search_minsyms_for_name): Use all_objfiles.
 842         * maint.c (maintenance_info_sections): Use all_objfiles.
 843         * main.c (captured_main_1): Use all_objfiles.
 844         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
 845         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
 846         * guile/scm-pretty-print.c
 847         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
 848         * solib-spu.c (append_ocl_sos): Use all_objfiles.
 849         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
 850         (maintenance_print_msymbols): Use all_objfiles.
 851         * source.c (select_source_symtab): Use all_objfiles.
 852         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
 853         * symfile.c (remove_symbol_file_command)
 854         (expand_symtabs_matching, map_symbol_filenames): Use
 855         all_objfiles.
 856         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
 857         all_objfiles.
 858         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
 859         * objc-lang.c (find_methods): Use all_objfiles.
 860         * objfiles.c (have_partial_symbols, have_full_symbols)
 861         (have_minimal_symbols, qsort_cmp)
 862         (default_iterate_over_objfiles_in_search_order): Use
 863         all_objfiles.
 864         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
 865         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
 866         (maintenance_check_psymtabs): Use all_objfiles.
 867         (ALL_PSYMTABS): Remove.
 868         * compile/compile-object-run.c (do_module_cleanup): Use
 869         all_objfiles.
 870         * blockframe.c (find_pc_partial_function): Use all_objfiles.
 871         * cp-support.c (add_symbol_overload_list_qualified): Use
 872         all_objfiles.
 873         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 874         Use all_objfiles.
 875         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
 876         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
 877         all_objfiles.
 878         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 879         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
 880         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 881         Uses all_objfiles.
 882         * solib.c (solib_read_symbols): Use all_objfiles
 883
 884 2019-01-09  Tom Tromey  <tom@tromey.com>
 885
 886         * probe.c (parse_probes_in_pspace): Use all_objfiles.
 887         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
 888         all_objfiles.
 889         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
 890         * symmisc.c (print_symbol_bcache_statistics)
 891         (print_objfile_statistics, maintenance_print_objfiles)
 892         (maintenance_info_symtabs, maintenance_check_symtabs)
 893         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
 894         all_objfiles.
 895         * source.c (forget_cached_source_info): Use all_objfiles.
 896         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
 897         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 898         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
 899         * objfiles.c (update_section_map): Use all_objfiles.
 900         (shared_objfile_contains_address_p): Likewise.
 901         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
 902         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
 903
 904 2019-01-09  Tom Tromey  <tom@tromey.com>
 905
 906         * common/next-iterator.h: New file.
 907         * objfiles.h (class all_objfiles): New.
 908         (struct objfile_iterator): New.
 909
 910 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 911
 912         * NEWS: Move the description of the changed "frame", "select-frame",
 913          and "info frame" commands to the Changed commands section.
 914
 915 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
 916
 917         * gdbtypes.c (check_stub_method_group): Remove handling of old
 918         mangling schemes.
 919         * linespec.c (find_methods): Likewise.
 920         * stabsread.c (read_member_functions): Likewise.
 921         * valops.c (search_struct_method): Likewise.
 922         (value_struct_elt_for_reference): Likewise.
 923         * NEWS: Mention this change.
 924
 925 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 926
 927         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
 928         print_source_lines.
 929         * source.c (print_source_lines_base): Update line number check.
 930         (print_source_lines): New function.
 931         (source_lines_range::source_lines_range): New function.
 932         * source.h (class source_lines_range): New class.
 933         (print_source_lines): New declaration.
 934
 935 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 936
 937         * linespec.c (linespec_state_destructor): Free self->canonical_names.
 938
 939 2019-01-08  Tom Tromey  <tom@tromey.com>
 940             Simon Marchi  <simon.marchi@ericsson.com>
 941
 942         PR gdb/24060
 943         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
 944         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
 945         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 946         * f-exp.y (DOLLAR_VARIABLE): Likewise.
 947         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
 948         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 949
 950 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 951
 952         * source.c (select_source_symtab): Move header comment to
 953         declaration in source.h.
 954         (forget_cached_source_info_for_objfile): Likewise.
 955         (forget_cached_source_info): Likewise.
 956         (identify_source_line): Likewise.
 957         * source.h (identify_source_line): Move declaration from symtab.h
 958         and add comment from source.c
 959         (print_source_lines): Likewise.
 960         (forget_cached_source_info_for_objfile): Likewise.
 961         (forget_cached_source_info): Likewise.
 962         (select_source_symtab): Likewise.
 963         (enum print_source_lines_flag): Move definition from symtab.h.
 964         * symtab.h (identify_source_line): Move declaration to source.h.
 965         (print_source_lines): Likewise.
 966         (forget_cached_source_info_for_objfile): Likewise.
 967         (forget_cached_source_info): Likewise.
 968         (select_source_symtab): Likewise.
 969         (enum print_source_lines_flag): Move definition to source.h.
 970         * tui/tui-hooks.c: Add 'source.h' include.
 971
 972 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 973
 974         * source.c (print_source_lines_base): Handle requests to print
 975         reverse line number sequences, and guard against empty lines
 976         string.
 977
 978 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 979
 980         * source.c (print_source_lines_base): Fix skip of '\r' if next
 981         character is '\n'.
 982
 983 2019-01-06  Tom Tromey  <tom@tromey.com>
 984
 985         * c-exp.y (struct c_parse_state) <macro_original_text,
 986         expansion_obstack>: New member.
 987         (macro_original_text, expansion_obstack): Remove globals.
 988         (scan_macro_expansion, scanning_macro_expansion)
 989         (finished_macro_expansion): Update.
 990         (scan_macro_cleanup): Remove.
 991         (yylex, c_parse): Update.
 992
 993 2019-01-06  Tom Tromey  <tom@tromey.com>
 994
 995         * c-exp.y (struct c_parse_state) <strings>: New member.
 996         (operator_stoken): Update.
 997
 998 2019-01-06  Tom Tromey  <tom@tromey.com>
 999
1000         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1001         (union type_stack_elt) <typelist_val>: Now a pointer to
1002         std::vector.
1003         (type_stack_cleanup): Don't declare.
1004         (push_typelist): Update.
1005         * parse.c (pop_typelist): Return a std::vector.
1006         (push_typelist): Take a std::vector.
1007         (follow_types): Update.  Do not free args.
1008         (type_stack_cleanup): Remove.
1009         * c-exp.y (struct c_parse_state): New.
1010         (cpstate): New global.
1011         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1012         (nonempty_typelist): Update.
1013         (func_mod): Create a new vector.
1014         (c_parse): Create a c_parse_state.
1015         (check_parameter_typelist): Do not delete params.
1016         (function_method): Update.  Do not delete type_list.
1017
1018 2019-01-06  Tom Tromey  <tom@tromey.com>
1019
1020         PR gdb/28155:
1021         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1022         check_typedef.
1023         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1024         (print_return_value): Likewise.
1025
1026 2019-01-05  Tom Tromey  <tom@tromey.com>
1027
1028         * contrib/cleanup_check.py: Remove.
1029         * contrib/gcc-with-excheck: Remove.
1030         * contrib/exsummary.py: Remove.
1031         * contrib/excheck.py: Remove.
1032
1033 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1034
1035         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1036         NULL. Initialize tpprev to NULL instead of assigning it
1037         to NULL on the next statement.
1038         * windows-nat.c (windows_delete_thread): Remove check for
1039         main_thread_id before printing thread exit notifications.
1040         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1041         Remove thread ID check against main_thread_id.
1042         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1043         windows_delete_thread.
1044         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1045
1046 2019-01-04  Tom Tromey  <tom@tromey.com>
1047
1048         * compile/compile.c (_initialize_compile): Use upper case for
1049         metasyntactic variables.
1050         * symmisc.c (_initialize_symmisc): Use upper case for
1051         metasyntactic variables.
1052         * psymtab.c (_initialize_psymtab): Use upper case for
1053         metasyntactic variables.
1054         * demangle.c (demangle_command): Use upper case for metasyntactic
1055         variables.
1056         (_initialize_demangler): Likewise.
1057         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1058         variables.
1059
1060 2019-01-03  Tom Tromey  <tom@tromey.com>
1061
1062         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1063
1064 2019-01-03  Tom Tromey  <tom@tromey.com>
1065
1066         * python/py-symtab.c (salpy_str): Update.
1067         (struct salpy_sal_object) <symtab>: Now a PyObject.
1068         (salpy_dealloc): Update.
1069         (del_objfile_sal): Use gdbpy_ref.
1070
1071 2019-01-03  Tom Tromey  <tom@tromey.com>
1072
1073         * python/py-type.c (convert_field): Use new_reference.  Return
1074         gdbpy_ref.
1075         (make_fielditem): Return gdbpy_ref.
1076         (typy_fields): Update.
1077         (typy_getitem): Update.
1078         (field_name): Return gdbpy_ref.  Use new_reference.
1079         (typy_iterator_iternext): Update.
1080
1081 2019-01-03  Tom Tromey  <tom@tromey.com>
1082
1083         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1084
1085 2019-01-03  Tom Tromey  <tom@tromey.com>
1086
1087         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1088         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1089         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1090         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1091         (pspy_set_type_printers): Likewise.
1092         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1093         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1094         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1095         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1096         (objfpy_set_type_printers): Likewise.
1097
1098 2019-01-03  Tom Tromey  <tom@tromey.com>
1099
1100         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1101         (gdbpy_print_stack): Use gdbpy_err_fetch.
1102         * python/python-internal.h (class gdbpy_err_fetch): New class.
1103         (class gdbpy_enter) <m_error_type, m_error_value,
1104         m_error_traceback>: Remove.
1105         <m_error>: New member.
1106         (gdbpy_exception_to_string): Don't declare.
1107         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1108         * python/py-value.c (convert_value_from_python): Use
1109         gdbpy_err_fetch.
1110         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1111         gdbpy_exception_to_string.
1112         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1113         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1114         gdbpy_err_fetch.
1115
1116 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1117
1118         * linux-nat.c (delete_lwp_cleanup): Delete.
1119         (struct lwp_deleter): New struct.
1120         (lwp_info_up): New typedef.
1121         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1122         lwp_info_up.
1123
1124 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1125
1126         * linux-fork.c (class scoped_switch_fork_info): New class.
1127         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1128
1129 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1130
1131         * valops.c (find_overload_match): Remove use of null_cleanup, and
1132         calls to do_cleanups.
1133
1134 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1135
1136         * compile/compile-cplus-types.c
1137         (compile_cplus_instance::decl_name): Handle changes to
1138         cp_func_name.
1139         * cp-support.c (cp_func_name): Update header comment, update
1140         return type.
1141         * cp-support.h (cp_func_name): Update return type in declaration.
1142         * valops.c (find_overload_match): Move temp_func local to top
1143         level of function and change its type.  Use temp_func to hold and
1144         delete temporary string obtained from cp_func_name.
1145
1146 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1147
1148         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1149         gdb::char_vector, remove cleanup, and update uses of `msg`.
1150
1151 2019-01-03  Jim Wilson  <jimw@sifive.com>
1152
1153         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1154
1155 2019-01-02  Tom Tromey  <tom@tromey.com>
1156
1157         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1158         (tdesc_parse_xml): Remove cleanups.
1159         * target-descriptions.h (make_cleanup_free_target_description):
1160         Don't declare.
1161         (target_desc_deleter): New struct.
1162         (target_desc_up): New typedef.
1163         * target-descriptions.c (target_desc_deleter::operator()): Rename
1164         from free_target_description.
1165         (make_cleanup_free_target_description): Remove.
1166
1167 2019-01-02  Tom Tromey  <tom@tromey.com>
1168
1169         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1170         constructor, destructor.
1171         (linespec_parser): Remove typedef.
1172         (~linespec_parser): Rename from linespec_parser_delete.
1173         (linespec_lex_to_end, linespec_complete_label)
1174         (linespec_complete): Update.
1175         (decode_line_full): Remove cleanups.
1176         (decode_line_1): Update.
1177
1178 2019-01-02  Tom Tromey  <tom@tromey.com>
1179
1180         * python/python-internal.h (inferior_to_inferior_object): Change
1181         return type.
1182         * python/py-exitedevent.c (create_exited_event_object): Update.
1183         * python/py-inferior.c (inferior_to_inferior_object): Return
1184         gdbpy_ref.
1185         (python_new_inferior, python_inferior_deleted)
1186         (thread_to_thread_object, delete_thread_object)
1187         (build_inferior_list, gdbpy_selected_inferior): Update.
1188         * python/py-infthread.c (create_thread_object): Update.  Also fail
1189         if inferior_to_inferior_object fails.
1190
1191 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1192
1193         * inferior.h (class inferior) <displaced_step_state>: New field.
1194         * infrun.h (struct displaced_step_state): Move here from
1195         infrun.c.  Initialize fields, add constructor.
1196         <inf>: Remove field.
1197         <reset>: New method.
1198         * infrun.c (struct displaced_step_inferior_state): Move to
1199         infrun.h.
1200         (displaced_step_inferior_states): Remove.
1201         (get_displaced_stepping_state): Adust.
1202         (displaced_step_in_progress_any_inferior): Adjust.
1203         (displaced_step_in_progress_thread): Adjust.
1204         (displaced_step_in_progress): Adjust.
1205         (add_displaced_stepping_state): Remove.
1206         (get_displaced_step_closure_by_addr): Adjust.
1207         (remove_displaced_stepping_state): Remove.
1208         (infrun_inferior_exit): Call displaced_step_state.reset.
1209         (use_displaced_stepping): Don't check for NULL.
1210         (displaced_step_prepare_throw): Call
1211         get_displaced_stepping_state.
1212         (displaced_step_fixup): Don't check for NULL.
1213         (prepare_for_detach): Don't check for NULL.
1214
1215 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1216
1217         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
1218          in case of call that did not complete.
1219
1220 2019-01-02  Andrey Utkin  <autkin@undo.io>
1221
1222         * symfile.c (find_separate_debug_file): Fix search of debug files for
1223         remote debuggee.
1224
1225 2019-01-02  Tom Tromey  <tom@tromey.com>
1226
1227         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
1228         indentation.
1229         * python/py-frame.c (frapy_older): Remove cast.
1230         (frapy_newer): Likewise.
1231         * python/py-breakpoint.c (local_setattro): Remove cast.
1232         * python/py-arch.c (archpy_name): Remove local variable.
1233         * python/py-type.c (gdbpy_lookup_type): Remove cast.
1234
1235 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
1236
1237         * unittests/basic_string_view/element_access/char/empty.cc:
1238         Fix year range in copyright header.
1239
1240 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1241
1242         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
1243         Delete.
1244         <operator==>: Update with for removed field.
1245         <hash>: Likewise.
1246         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
1247         <isa_features>: ...this.
1248         <abi_features>: New field.
1249         (riscv_isa_flen): Update comment.
1250         (riscv_abi_xlen): New declaration.
1251         (riscv_abi_flen): New declaration.
1252         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
1253         isa_features.
1254         (riscv_abi_xlen): New function.
1255         (riscv_isa_flen): Update to get answer from isa_features.
1256         (riscv_abi_flen): New function.
1257         (riscv_has_fp_abi): Update to get answer from abi_features.
1258         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
1259         xlen and flen.
1260         (riscv_call_info) <xlen, flen>: Update comment.
1261         (riscv_call_arg_struct): Remove invalid assertions
1262         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
1263         is removed.
1264         (riscv_gdbarch_init): Gather isa features and abi features
1265         separately, ensure both match on the gdbarch when reusing an old
1266         gdbarch.  Relax an error check to allow 32-bit abi float to run on
1267         a target with 64-bit float hardware.
1268
1269 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1270
1271         * source.c (search_command_helper): Stop reverse search
1272         when line 1 has been searched.
1273
1274 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1275
1276         * record-full.c (record_full_base_target::close): Rewrite
1277         record_full_core_buf_list free logic.
1278
1279 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1280
1281         * break-catch-syscall.c (print_one_catch_syscall): xfree
1282         the last text.
1283
1284 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1285
1286         * top.c (print_gdb_version): Update Copyright year in version
1287         message.
1288
1289 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1290
1291         Update copyright year range in all GDB files.
1292
1293 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
1294
1295         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
1296
1297 For older changes see ChangeLog-2018.
1298 \f
1299 Local Variables:
1300 mode: change-log
1301 left-margin: 8
1302 fill-column: 74
1303 version-control: never
1304 coding: utf-8
1305 End:
1306