gdb/ChangeLog

   1 2019-03-14  Tom Tromey  <tromey@adacore.com>
   2
   3         * source-cache.h (class source_cache) <get_source_lines>: Return
   4         std::string.
   5         * source-cache.c (source_cache::extract_lines): Handle case where
   6         first_pos==npos.  Return std::string.
   7         (source_cache::get_source_lines): Update.
   8
   9 2019-03-14  Tom Tromey  <tromey@adacore.com>
  10
  11         * NEWS: Add item for "style sources" commands.
  12         * source-cache.c (source_cache::get_source_lines): Check
  13         source_styling.
  14         * cli/cli-style.c (source_styling): New global.
  15         (_initialize_cli_style): Add "style sources" commands.
  16         (show_style_sources): New function.
  17         * cli/cli-style.h (source_styling): Declare.
  18
  19 2019-03-14  Pedro Alves  <palves@redhat.com>
  20             Tom Tromey  <tromey@adacore.com>
  21
  22         * tui/tui-winsource.h (tui_refill_source_window): Declare.
  23         * tui/tui-winsource.c (tui_refill_source_window): New function,
  24         from...
  25         (tui_horizontal_source_scroll): ... here.  Move some logic.
  26         * cli/cli-style.c (set_style_enabled): Notify new observable.
  27         * tui/tui-hooks.c (tui_redisplay_source): New function.
  28         (tui_attach_detach_observers): Attach or detach
  29         tui_redisplay_source.
  30         * observable.h (source_styling_changed): New observable.
  31         * observable.c: Define source_styling_changed observable.
  32
  33 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
  34
  35         PR/24325
  36         * source-cache.c: #undef open and close, to avoid unresolved
  37         externals during linking.
  38
  39 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
  40
  41         Support styling on native MS-Windows console
  42
  43         PR/24315
  44         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
  45         on MS-Windows if $TERM is not defined.
  46
  47         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
  48
  49         * posix-hdep.c (gdb_console_fputs):
  50         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
  51         functions.
  52         * ui-file.h (gdb_console_fputs): Add prototype.
  53
  54         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
  55         back to fputs only if the former returns zero.
  56
  57 2019-03-07  Brian Vandenberg  <phantall@gmail.com>
  58             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
  59
  60         PR gdb/8527
  61         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
  62         set_sigint_trap, clear_sigint_trap.
  63
  64 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
  65
  66         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
  67         for-loop range, to avoid compiler warnings.
  68
  69         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
  70         avoid compiler warnings about unused variables.
  71
  72 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
  73
  74         * NEWS: Mention end of support for native debugging on MS-Windows
  75         before XP.
  76
  77 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
  78
  79         PR gdb/24292
  80         * common/netstuff.c:
  81         * gdbserver/gdbreplay.c
  82         * gdbserver/remote-utils.c:
  83         * ser-tcp.c:
  84         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
  85         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
  86         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
  87         'getaddrinfo' and 'freeaddrinfo' were not available before
  88         Windows XP, and mingw.org's MinGW headers by default define
  89         _WIN32_WINNT to 0x500.
  90
  91 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
  92
  93         * NEWS: Note minimum Python version.
  94
  95 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
  96
  97         * version.in: Set GDB version number to 8.2.90.DATE-git.
  98
  99 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 100
 101         GDB 8.2.90 released.
 102
 103 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 104
 105         * version.in: Set GDB version number to 8.2.90.
 106
 107 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 108
 109         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
 110
 111 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 112
 113         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
 114         * version.in: Bump version to 8.2.90.DATE-git.
 115
 116 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
 117
 118         * aix-thread.c (ptid_cmp): Remove unused variable.
 119         (get_signaled_thread): Likewise.
 120         (store_regs_user_thread): Likewise.
 121         (store_regs_kernel_thread): Likewise.
 122         (fetch_regs_kernel_thread): Remove shadowed variable.
 123
 124 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 125
 126         * features/riscv/32bit-cpu.xml: Add register numbers.
 127         * features/riscv/32bit-fpu.c: Regenerate.
 128         * features/riscv/32bit-fpu.xml: Add register numbers.
 129         * features/riscv/64bit-cpu.xml: Add register numbers.
 130         * features/riscv/64bit-fpu.c: Regenerate.
 131         * features/riscv/64bit-fpu.xml: Add register numbers.
 132
 133 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
 134
 135         * NEWS: Mention two argument form of gdb.Value constructor.
 136         * python/py-value.c (convert_buffer_and_type_to_value): New
 137         function.
 138         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
 139         Add support for handling an optional second argument.  Call
 140         convert_buffer_and_type_to_value as appropriate.
 141         * python/python-internal.h (Py_buffer_deleter): New struct.
 142         (Py_buffer_up): New typedef.
 143
 144 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
 145
 146         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
 147         instead of releasing ownership.
 148
 149 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
 150
 151         * dwarf2read.c (open_and_init_dwp_file): Call
 152         elf_numsections instead of bfd_count_sections to initialize
 153         dwp_file->num_sections.
 154
 155 2019-02-25  Tom Tromey  <tromey@adacore.com>
 156
 157         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
 158
 159 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 160
 161         * gcore.in: Add '--readnever' option when invoking GDB.
 162
 163 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 164
 165         * MAINTAINERS: Update my email address.
 166
 167 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 168
 169         * build-id.c (build_id_to_debug_bfd_1): New function.
 170         (build_id_to_debug_bfd): Look for separate debug file in
 171         sysroot.
 172
 173 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 174
 175         * gdbarch.sh: Update the copyright year range that is placed into
 176         generated files.
 177
 178 2019-02-22  Keith Seitz  <keiths@redhat.com>
 179
 180         PR symtab/23853
 181         * linespec.c (create_sals_line_offset): Search for the default
 182         symtab's filename instead of its fullname.
 183
 184 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 185
 186         * NEWS: Update style defaults.
 187
 188 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 189
 190         * main.c (captured_main_1): Disable styling in batch mode.
 191
 192 2019-02-20  Tom Tromey  <tom@tromey.com>
 193
 194         * symtab.c (symtab_symbol_info): Fix typos.
 195
 196 2019-02-20  Tom Tromey  <tromey@adacore.com>
 197
 198         * findcmd.c (_initialize_mem_search): Use upper case for
 199         metasyntactic variables.
 200
 201 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
 202
 203         * aarch64-tdep.c (aarch64_add_reggroups): New function.
 204         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
 205
 206 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
 207
 208         * top.h (source_file_name): Change to std::string.
 209         * top.c (source_file_name): Likewise.
 210         (command_line_input): Adjust.
 211         * cli/cli-script.c (script_from_file): Adjust.
 212
 213 2019-02-19  Tom Tromey  <tromey@adacore.com>
 214
 215         * ravenscar-thread.c
 216         (ravenscar_thread_target::update_thread_list): Don't call
 217         ada_build_task_list.
 218         * ada-lang.h (ada_build_task_list): Don't declare.
 219         * ada-tasks.c (struct ada_tasks_inferior_data)
 220         <task_list_valid_p>: Now bool.
 221         (read_known_tasks, ada_task_list_changed)
 222         (ada_tasks_invalidate_inferior_data): Update.
 223         (read_known_tasks_array): Return bool.
 224         (read_known_tasks_list): Likewise.
 225         (read_known_tasks): Return void.
 226         (ada_build_task_list): Now static.
 227
 228 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 229
 230         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
 231         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
 232
 233 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 234
 235         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
 236         variant for ada_tasks_pspace_data_handle and
 237         ada_tasks_inferior_data_handle.
 238         (ada_tasks_pspace_data_cleanup): New function.
 239         (ada_tasks_inferior_data_cleanup): New function.
 240
 241 2019-02-17  Tom Tromey  <tom@tromey.com>
 242
 243         * macrotab.h (macro_source_fullname): Return a std::string.
 244         * macrotab.c (macro_include, check_for_redefinition)
 245         (macro_undef, macro_lookup_definition, foreach_macro)
 246         (foreach_macro_in_scope): Update.
 247         (macro_source_fullname): Return a std::string.
 248         * macrocmd.c (show_pp_source_pos): Update.
 249
 250 2019-02-17  Tom Tromey  <tom@tromey.com>
 251
 252         * macrocmd.c (show_pp_source_pos): Style the file names.
 253
 254 2019-02-17  Tom Tromey  <tom@tromey.com>
 255
 256         PR tui/24197:
 257         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 258
 259 2019-02-17  Tom Tromey  <tom@tromey.com>
 260
 261         * ada-lang.c (user_select_syms): Use filtered printing.
 262         * utils.c (wrap_style): New global.
 263         (desired_style): Remove.
 264         (emit_style_escape): Add stream parameter.
 265         (set_output_style, reset_terminal_style, prompt_for_continue):
 266         Update.
 267         (flush_wrap_buffer): Only flush gdb_stdout.
 268         (wrap_here): Set wrap_style.
 269         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 270         treat escape sequences as a character.  Change when wrap buffer is
 271         flushed.
 272         (fputs_styled): Do not set the output style when the default is
 273         requested.
 274         * ui-style.h (struct ui_file_style) <is_default>: New method.
 275         * source.c (print_source_lines_base): Emit escape sequences in one
 276         piece.
 277
 278 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 279
 280         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 281         integers and enumeration types.
 282
 283 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 284
 285         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 286         instead of lookup_symbol_in_language
 287         (do_exact_match): New function.
 288         (ada_get_symbol_name_matcher): Return do_exact_match when
 289         doing a verbatim match.
 290
 291 2019-02-15  Tom Tromey  <tromey@adacore.com>
 292
 293         * ravenscar-thread.c (ravenscar_thread_target::resume)
 294         (ravenscar_thread_target::wait): Special case wildcard requests.
 295
 296 2019-02-15  Tom Tromey  <tromey@adacore.com>
 297
 298         * ravenscar-thread.c (base_ptid): Remove.
 299         (struct ravenscar_thread_target) <close>: New method.
 300         <m_base_ptid>: New member.
 301         <update_inferior_ptid, active_task, task_is_currently_active,
 302         runtime_initialized>: Declare methods.
 303         <ravenscar_thread_target>: Add constructor.
 304         (ravenscar_thread_target::task_is_currently_active)
 305         (ravenscar_thread_target::update_inferior_ptid)
 306         (ravenscar_runtime_initialized): Rename.  Now methods.
 307         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 308         (ravenscar_thread_target::update_thread_list): Update.
 309         (ravenscar_thread_target::active_task): Now method.
 310         (ravenscar_thread_target::store_registers)
 311         (ravenscar_thread_target::prepare_to_store)
 312         (ravenscar_thread_target::prepare_to_store)
 313         (ravenscar_thread_target::mourn_inferior): Update.
 314         (ravenscar_inferior_created): Use "new" to create target.
 315         (ravenscar_thread_target::get_ada_task_ptid): Update.
 316         (_initialize_ravenscar): Don't initialize base_ptid.
 317         (ravenscar_ops): Remove global.
 318
 319 2019-02-15  Tom Tromey  <tromey@adacore.com>
 320
 321         * target.h (push_target): Declare new overload.
 322         * target.c (push_target): New overload, taking an rvalue reference.
 323         * remote.c (remote_target::open_1): Use push_target overload.
 324         * corelow.c (core_target_open): Use push_target overload.
 325
 326 2019-02-15  Tom Tromey  <tromey@adacore.com>
 327
 328         * ravenscar-thread.c (is_ravenscar_task)
 329         (ravenscar_task_is_currently_active): Return bool.
 330         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 331         (_initialize_ravenscar): Remove "(void)".
 332         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 333         Return bool.
 334
 335 2019-02-15  Tom Tromey  <tromey@adacore.com>
 336
 337         * ravenscar-thread.c (ravenscar_runtime_initializer)
 338         (has_ravenscar_runtime, get_running_thread_id)
 339         (ravenscar_thread_target::resume): Fix indentation.
 340
 341 2019-02-15  Tom Tromey  <tromey@adacore.com>
 342
 343         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 344         from ravenscar_arch_ops.
 345         (sparc_ravenscar_ops::fetch_registers)
 346         (sparc_ravenscar_ops::store_registers): Now methods.
 347         (sparc_ravenscar_prepare_to_store): Remove.
 348         (sparc_ravenscar_ops): Redefine.
 349         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 350         methods and destructor.  Remove members.
 351         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 352         (ravenscar_thread_target::store_registers)
 353         (ravenscar_thread_target::prepare_to_store): Update.
 354         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 355         Remove.
 356         (struct ppc_ravenscar_powerpc_ops): Derive from
 357         ravenscar_arch_ops.
 358         (ppc_ravenscar_powerpc_ops::fetch_registers)
 359         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 360         (ppc_ravenscar_powerpc_ops): Redefine.
 361         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 362         (ppc_ravenscar_e500_ops::fetch_registers)
 363         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 364         (ppc_ravenscar_e500_ops): Redefine.
 365         * aarch64-ravenscar-thread.c
 366         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 367         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 368         (aarch64_ravenscar_fetch_registers)
 369         (aarch64_ravenscar_store_registers): Now methods.
 370         (aarch64_ravenscar_ops): Redefine.
 371
 372 2019-02-15  Tom Tromey  <tromey@adacore.com>
 373
 374         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 375         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 376         (ravenscar_thread_target::stopped_by_watchpoint)
 377         (ravenscar_thread_target::stopped_data_address)
 378         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 379
 380 2019-02-15  Tom Tromey  <tromey@adacore.com>
 381
 382         * ravenscar-thread.c: Fix some typos.
 383
 384 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 385             Tom Tromey  <tromey@adacore.com>
 386
 387         * ada-lang.c (ada_exception_sal): Change addr_string to a
 388         std::string.
 389         (create_ada_exception_catchpoint): Update.
 390
 391 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 392             Tom Tromey  <tromey@adacore.com>
 393
 394         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 395         (bp_location_ops): Remove.
 396         (base_breakpoint_allocate_location): Update.
 397         (free_bp_location): Update.
 398         * ada-lang.c (class ada_catchpoint_location)
 399         <ada_catchpoint_location>: Remove ops parameter.
 400         (ada_catchpoint_location_dtor): Remove.
 401         (ada_catchpoint_location_ops): Remove.
 402         (allocate_location_exception): Update.
 403         * breakpoint.h (struct bp_location_ops): Remove.
 404         (class bp_location) <bp_location>: Remove bp_location_ops
 405         parameter.
 406         <~bp_location>: Add destructor.
 407         <ops>: Remove.
 408
 409 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 410             Pedro Alves  <palves@redhat.com>
 411
 412         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 413         'PATH_MAX'.
 414
 415 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 416             Samuel Thibault  <samuel.thibault@gnu.org>
 417             Thomas Schwinge  <thomas@codesourcery.com>
 418
 419         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 420         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 421
 422 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 423
 424         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 425         (check_empty): Use "const char *".
 426
 427         * gnu-nat.c (gnu_nat_target::detach): Instead of
 428         'detach_inferior (pid)' call
 429         'detach_inferior (find_inferior_pid (pid))'.
 430
 431         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 432         'nat/fork-inferior.o'.
 433         * gnu-nat.c: #include "nat/fork-inferior.h".
 434
 435         * gnu-nat.c (gnu_nat_target::detach): Instead of
 436         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 437         * gnu-nat.h: #include "inf-child.h".
 438         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 439         'i386_gnu_nat_target::fetch_registers'.
 440         (gnu_store_registers): Rename/move to
 441         'i386_gnu_nat_target::store_registers'.
 442
 443         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 444         * gnu-nat.h (mach_thread_info): New function.
 445         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 446
 447         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 448
 449 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 450
 451         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 452
 453 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 454
 455         * windows-nat.c (windows_add_thread): Add new parameter
 456         "main_thread_p" with default value set to false.  Update
 457         function documentation as well as all callers.
 458         (windows_delete_thread): Likewise.
 459         (fake_create_process): Update call to windows_add_thread.
 460         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 461         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 462         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 463         call to windows_delete_thread.
 464
 465 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 466
 467         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 468
 469 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 470
 471         * symfile.c (find_separate_debug_file): Use canonical path of
 472         sysroot with child_path instead of gdb_sysroot if it is valid.
 473
 474 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 475
 476         * symfile.c (find_separate_debug_file): Use child_path to
 477         determine if an object file is under a sysroot.
 478
 479 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 480
 481         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 482         unittests/child-path-selftests.c.
 483         * common/pathstuff.c (child_path): New function.
 484         * common/pathstuff.h (child_path): New prototype.
 485         * unittests/child-path-selftests.c: New file.
 486
 487 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 488
 489         * symfile.c (find_separate_debug_file): Look for separate debug
 490         files in debug directories under the sysroot.
 491
 492 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 493
 494         * symtab.h (struct minimal_symbol data_p): New const method.
 495         (struct minimal_symbol text_p): Likewise.
 496         * symtab.c (output_source_filename): Use file name style
 497         to print file name.
 498         (print_symbol_info): Likewise.
 499         (print_msymbol_info): Use address style to print addresses.
 500         Use function name style to print executable text symbols.
 501         (expand_symtab_containing_pc): Use data_p.
 502         (find_pc_sect_compunit_symtab): Likewise.
 503
 504 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 505
 506         * breakpoint.c (describe_other_breakpoints): Use address style
 507         to print addresses.
 508         (say_where): Likewise.
 509
 510 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 511
 512         * ada-typeprint.c (print_func_type): Print function name
 513         style to print function name.
 514         * c-typeprint.c (c_print_type_1): Likewise.
 515
 516 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 517
 518         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 519         for execve.
 520
 521 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 522
 523         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 524         type_stack.
 525
 526 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 527
 528         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 529         TYPE_CODE_REF types.
 530
 531 2019-02-08  Jim Wilson  <jimw@sifive.com>
 532
 533         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 534         (riscv_linux_fregset): New.
 535         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 536
 537 2019-02-07  Tom Tromey  <tom@tromey.com>
 538
 539         * thread.c (thread_cancel_execution_command): Update.
 540         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 541         methods.
 542         (struct thread_fsm_ops): Remove.
 543         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 544         (thread_fsm_should_stop, thread_fsm_return_value)
 545         (thread_fsm_set_finished, thread_fsm_finished_p)
 546         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 547         Don't declare.
 548         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 549         * infrun.c (clear_proceed_status_thread)
 550         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 551         (print_stop_event): Update.
 552         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 553         Add constructor.
 554         (step_command_fsm_ops): Remove.
 555         (new_step_command_fsm): Remove.
 556         (step_1): Update.
 557         (step_command_fsm::should_stop): Rename from
 558         step_command_fsm_should_stop.
 559         (step_command_fsm::clean_up): Rename from
 560         step_command_fsm_clean_up.
 561         (step_command_fsm::do_async_reply_reason): Rename from
 562         step_command_fsm_async_reply_reason.
 563         (struct until_next_fsm): Inherit from thread_fsm.  Add
 564         constructor.
 565         (until_next_fsm_ops): Remove.
 566         (new_until_next_fsm): Remove.
 567         (until_next_fsm::should_stop): Rename from
 568         until_next_fsm_should_stop.
 569         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 570         (until_next_fsm::do_async_reply_reason): Rename from
 571         until_next_fsm_async_reply_reason.
 572         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 573         constructor.  Change type of breakpoint.
 574         (finish_command_fsm_ops): Remove.
 575         (new_finish_command_fsm): Remove.
 576         (finish_command_fsm::should_stop): Rename from
 577         finish_command_fsm_should_stop.
 578         (finish_command_fsm::clean_up): Rename from
 579         finish_command_fsm_clean_up.
 580         (finish_command_fsm::return_value): Rename from
 581         finish_command_fsm_return_value.
 582         (finish_command_fsm::do_async_reply_reason): Rename from
 583         finish_command_fsm_async_reply_reason.
 584         (finish_command): Update.
 585         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 586         Add constructor.
 587         (call_thread_fsm_ops): Remove.
 588         (call_thread_fsm::call_thread_fsm): Rename from
 589         new_call_thread_fsm.
 590         (call_thread_fsm::should_stop): Rename from
 591         call_thread_fsm_should_stop.
 592         (call_thread_fsm::should_notify_stop): Rename from
 593         call_thread_fsm_should_notify_stop.
 594         (run_inferior_call, call_function_by_hand_dummy): Update.
 595         * cli/cli-interp.c (should_print_stop_to_console): Update.
 596         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 597         Add constructor.  Change type of location_breakpoint,
 598         caller_breakpoint.
 599         (until_break_fsm_ops): Remove.
 600         (new_until_break_fsm): Remove.
 601         (until_break_fsm::should_stop): Rename from
 602         until_break_fsm_should_stop.
 603         (until_break_fsm::clean_up): Rename from
 604         until_break_fsm_clean_up.
 605         (until_break_fsm::do_async_reply_reason): Rename from
 606         until_break_fsm_async_reply_reason.
 607         (until_break_command): Update.
 608         * thread-fsm.c: Remove.
 609         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 610
 611 2019-02-07  Tom Tromey  <tom@tromey.com>
 612
 613         * yy-remap.h: Add include guard.
 614         * xtensa-tdep.h: Add include guard.
 615         * xcoffread.h: Rename include guard.
 616         * varobj-iter.h: Add include guard.
 617         * tui/tui.h: Rename include guard.
 618         * tui/tui-winsource.h: Rename include guard.
 619         * tui/tui-wingeneral.h: Rename include guard.
 620         * tui/tui-windata.h: Rename include guard.
 621         * tui/tui-win.h: Rename include guard.
 622         * tui/tui-stack.h: Rename include guard.
 623         * tui/tui-source.h: Rename include guard.
 624         * tui/tui-regs.h: Rename include guard.
 625         * tui/tui-out.h: Rename include guard.
 626         * tui/tui-layout.h: Rename include guard.
 627         * tui/tui-io.h: Rename include guard.
 628         * tui/tui-hooks.h: Rename include guard.
 629         * tui/tui-file.h: Rename include guard.
 630         * tui/tui-disasm.h: Rename include guard.
 631         * tui/tui-data.h: Rename include guard.
 632         * tui/tui-command.h: Rename include guard.
 633         * tic6x-tdep.h: Add include guard.
 634         * target/waitstatus.h: Rename include guard.
 635         * target/wait.h: Rename include guard.
 636         * target/target.h: Rename include guard.
 637         * target/resume.h: Rename include guard.
 638         * target-float.h: Rename include guard.
 639         * stabsread.h: Add include guard.
 640         * rs6000-tdep.h: Add include guard.
 641         * riscv-fbsd-tdep.h: Add include guard.
 642         * regformats/regdef.h: Rename include guard.
 643         * record.h: Rename include guard.
 644         * python/python.h: Rename include guard.
 645         * python/python-internal.h: Rename include guard.
 646         * python/py-stopevent.h: Rename include guard.
 647         * python/py-ref.h: Rename include guard.
 648         * python/py-record.h: Rename include guard.
 649         * python/py-record-full.h: Rename include guard.
 650         * python/py-record-btrace.h: Rename include guard.
 651         * python/py-instruction.h: Rename include guard.
 652         * python/py-events.h: Rename include guard.
 653         * python/py-event.h: Rename include guard.
 654         * procfs.h: Add include guard.
 655         * proc-utils.h: Add include guard.
 656         * p-lang.h: Add include guard.
 657         * or1k-tdep.h: Rename include guard.
 658         * observable.h: Rename include guard.
 659         * nto-tdep.h: Rename include guard.
 660         * nat/x86-linux.h: Rename include guard.
 661         * nat/x86-linux-dregs.h: Rename include guard.
 662         * nat/x86-gcc-cpuid.h: Add include guard.
 663         * nat/x86-dregs.h: Rename include guard.
 664         * nat/x86-cpuid.h: Rename include guard.
 665         * nat/ppc-linux.h: Rename include guard.
 666         * nat/mips-linux-watch.h: Rename include guard.
 667         * nat/linux-waitpid.h: Rename include guard.
 668         * nat/linux-ptrace.h: Rename include guard.
 669         * nat/linux-procfs.h: Rename include guard.
 670         * nat/linux-osdata.h: Rename include guard.
 671         * nat/linux-nat.h: Rename include guard.
 672         * nat/linux-namespaces.h: Rename include guard.
 673         * nat/linux-btrace.h: Rename include guard.
 674         * nat/glibc_thread_db.h: Rename include guard.
 675         * nat/gdb_thread_db.h: Rename include guard.
 676         * nat/gdb_ptrace.h: Rename include guard.
 677         * nat/fork-inferior.h: Rename include guard.
 678         * nat/amd64-linux-siginfo.h: Rename include guard.
 679         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 680         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 681         * nat/aarch64-linux.h: Rename include guard.
 682         * nat/aarch64-linux-hw-point.h: Rename include guard.
 683         * mn10300-tdep.h: Add include guard.
 684         * mips-linux-tdep.h: Add include guard.
 685         * mi/mi-parse.h: Rename include guard.
 686         * mi/mi-out.h: Rename include guard.
 687         * mi/mi-main.h: Rename include guard.
 688         * mi/mi-interp.h: Rename include guard.
 689         * mi/mi-getopt.h: Rename include guard.
 690         * mi/mi-console.h: Rename include guard.
 691         * mi/mi-common.h: Rename include guard.
 692         * mi/mi-cmds.h: Rename include guard.
 693         * mi/mi-cmd-break.h: Rename include guard.
 694         * m2-lang.h: Add include guard.
 695         * location.h: Rename include guard.
 696         * linux-record.h: Rename include guard.
 697         * linux-nat.h: Add include guard.
 698         * linux-fork.h: Add include guard.
 699         * i386-darwin-tdep.h: Rename include guard.
 700         * hppa-linux-offsets.h: Add include guard.
 701         * guile/guile.h: Rename include guard.
 702         * guile/guile-internal.h: Rename include guard.
 703         * gnu-nat.h: Rename include guard.
 704         * gdb-stabs.h: Rename include guard.
 705         * frv-tdep.h: Add include guard.
 706         * f-lang.h: Add include guard.
 707         * event-loop.h: Add include guard.
 708         * darwin-nat.h: Rename include guard.
 709         * cp-abi.h: Rename include guard.
 710         * config/sparc/nm-sol2.h: Rename include guard.
 711         * config/nm-nto.h: Rename include guard.
 712         * config/nm-linux.h: Add include guard.
 713         * config/i386/nm-i386gnu.h: Rename include guard.
 714         * config/djgpp/nl_types.h: Rename include guard.
 715         * config/djgpp/langinfo.h: Rename include guard.
 716         * compile/gcc-cp-plugin.h: Add include guard.
 717         * compile/gcc-c-plugin.h: Add include guard.
 718         * compile/compile.h: Rename include guard.
 719         * compile/compile-object-run.h: Rename include guard.
 720         * compile/compile-object-load.h: Rename include guard.
 721         * compile/compile-internal.h: Rename include guard.
 722         * compile/compile-cplus.h: Rename include guard.
 723         * compile/compile-c.h: Rename include guard.
 724         * common/xml-utils.h: Rename include guard.
 725         * common/x86-xstate.h: Rename include guard.
 726         * common/version.h: Rename include guard.
 727         * common/vec.h: Rename include guard.
 728         * common/tdesc.h: Rename include guard.
 729         * common/selftest.h: Rename include guard.
 730         * common/scoped_restore.h: Rename include guard.
 731         * common/scoped_mmap.h: Rename include guard.
 732         * common/scoped_fd.h: Rename include guard.
 733         * common/safe-iterator.h: Rename include guard.
 734         * common/run-time-clock.h: Rename include guard.
 735         * common/refcounted-object.h: Rename include guard.
 736         * common/queue.h: Rename include guard.
 737         * common/ptid.h: Rename include guard.
 738         * common/print-utils.h: Rename include guard.
 739         * common/preprocessor.h: Rename include guard.
 740         * common/pathstuff.h: Rename include guard.
 741         * common/observable.h: Rename include guard.
 742         * common/netstuff.h: Rename include guard.
 743         * common/job-control.h: Rename include guard.
 744         * common/host-defs.h: Rename include guard.
 745         * common/gdb_wait.h: Rename include guard.
 746         * common/gdb_vecs.h: Rename include guard.
 747         * common/gdb_unlinker.h: Rename include guard.
 748         * common/gdb_unique_ptr.h: Rename include guard.
 749         * common/gdb_tilde_expand.h: Rename include guard.
 750         * common/gdb_sys_time.h: Rename include guard.
 751         * common/gdb_string_view.h: Rename include guard.
 752         * common/gdb_splay_tree.h: Rename include guard.
 753         * common/gdb_setjmp.h: Rename include guard.
 754         * common/gdb_ref_ptr.h: Rename include guard.
 755         * common/gdb_optional.h: Rename include guard.
 756         * common/gdb_locale.h: Rename include guard.
 757         * common/gdb_assert.h: Rename include guard.
 758         * common/filtered-iterator.h: Rename include guard.
 759         * common/filestuff.h: Rename include guard.
 760         * common/fileio.h: Rename include guard.
 761         * common/environ.h: Rename include guard.
 762         * common/common-utils.h: Rename include guard.
 763         * common/common-types.h: Rename include guard.
 764         * common/common-regcache.h: Rename include guard.
 765         * common/common-inferior.h: Rename include guard.
 766         * common/common-gdbthread.h: Rename include guard.
 767         * common/common-exceptions.h: Rename include guard.
 768         * common/common-defs.h: Rename include guard.
 769         * common/common-debug.h: Rename include guard.
 770         * common/cleanups.h: Rename include guard.
 771         * common/buffer.h: Rename include guard.
 772         * common/btrace-common.h: Rename include guard.
 773         * common/break-common.h: Rename include guard.
 774         * cli/cli-utils.h: Rename include guard.
 775         * cli/cli-style.h: Rename include guard.
 776         * cli/cli-setshow.h: Rename include guard.
 777         * cli/cli-script.h: Rename include guard.
 778         * cli/cli-interp.h: Rename include guard.
 779         * cli/cli-decode.h: Rename include guard.
 780         * cli/cli-cmds.h: Rename include guard.
 781         * charset-list.h: Add include guard.
 782         * buildsym-legacy.h: Rename include guard.
 783         * bfin-tdep.h: Add include guard.
 784         * ax.h: Rename include guard.
 785         * arm-linux-tdep.h: Add include guard.
 786         * arm-fbsd-tdep.h: Add include guard.
 787         * arch/xtensa.h: Rename include guard.
 788         * arch/tic6x.h: Add include guard.
 789         * arch/i386.h: Add include guard.
 790         * arch/arm.h: Rename include guard.
 791         * arch/arm-linux.h: Rename include guard.
 792         * arch/arm-get-next-pcs.h: Rename include guard.
 793         * arch/amd64.h: Add include guard.
 794         * arch/aarch64-insn.h: Rename include guard.
 795         * arch-utils.h: Rename include guard.
 796         * annotate.h: Add include guard.
 797         * amd64-darwin-tdep.h: Rename include guard.
 798         * aarch64-linux-tdep.h: Add include guard.
 799         * aarch64-fbsd-tdep.h: Add include guard.
 800         * aarch32-linux-nat.h: Add include guard.
 801
 802 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 803
 804         * macrotab.c (macro_define_internal): New function that
 805         factorizes macro_define_object_internal and macro_define_function
 806         code.
 807         (macro_define_object_internal): Use macro_define_internal.
 808         (macro_define_function): Likewise.
 809
 810 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 811
 812         * macrocmd.c (extract_identifier): Return
 813         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 814         callers.
 815
 816 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 817
 818         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 819
 820 2019-02-05  Tom Tromey  <tom@tromey.com>
 821
 822         * target.c (target_stack::unpush): Move assertion earlier.
 823
 824 2019-01-30  Tom Tromey  <tom@tromey.com>
 825
 826         PR python/23615:
 827         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 828         (gdbpy_parse_and_eval): Likewise.
 829         * python/python-internal.h (gdbpy_allow_threads): New class.
 830
 831 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 832
 833         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 834         (aarch64_fbsd_fpregmap): Move earlier.
 835         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 836         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 837         instead of individual calls to trad_frame_set_reg_addr.
 838         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 839         earlier.
 840         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 841         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 842         instead of individual calls to trad_frame_set_reg_addr.
 843
 844 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 845
 846         * CONTRIBUTE: Replace contribution list with wiki link.
 847
 848 2019-01-25  Tom Tromey  <tom@tromey.com>
 849
 850         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 851
 852 2019-01-25  Tom Tromey  <tom@tromey.com>
 853
 854         * xtensa-linux-nat.c: Fix common/ includes.
 855         * xml-support.h: Fix common/ includes.
 856         * xml-support.c: Fix common/ includes.
 857         * x86-linux-nat.c: Fix common/ includes.
 858         * windows-nat.c: Fix common/ includes.
 859         * varobj.h: Fix common/ includes.
 860         * varobj.c: Fix common/ includes.
 861         * value.c: Fix common/ includes.
 862         * valops.c: Fix common/ includes.
 863         * utils.c: Fix common/ includes.
 864         * unittests/xml-utils-selftests.c: Fix common/ includes.
 865         * unittests/utils-selftests.c: Fix common/ includes.
 866         * unittests/unpack-selftests.c: Fix common/ includes.
 867         * unittests/tracepoint-selftests.c: Fix common/ includes.
 868         * unittests/style-selftests.c: Fix common/ includes.
 869         * unittests/string_view-selftests.c: Fix common/ includes.
 870         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 871         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 872         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 873         * unittests/rsp-low-selftests.c: Fix common/ includes.
 874         * unittests/parse-connection-spec-selftests.c: Fix common/
 875         includes.
 876         * unittests/optional-selftests.c: Fix common/ includes.
 877         * unittests/offset-type-selftests.c: Fix common/ includes.
 878         * unittests/observable-selftests.c: Fix common/ includes.
 879         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 880         * unittests/memrange-selftests.c: Fix common/ includes.
 881         * unittests/memory-map-selftests.c: Fix common/ includes.
 882         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 883         * unittests/function-view-selftests.c: Fix common/ includes.
 884         * unittests/environ-selftests.c: Fix common/ includes.
 885         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 886         * unittests/common-utils-selftests.c: Fix common/ includes.
 887         * unittests/cli-utils-selftests.c: Fix common/ includes.
 888         * unittests/array-view-selftests.c: Fix common/ includes.
 889         * ui-file.c: Fix common/ includes.
 890         * tui/tui-io.c: Fix common/ includes.
 891         * tracepoint.h: Fix common/ includes.
 892         * tracepoint.c: Fix common/ includes.
 893         * tracefile-tfile.c: Fix common/ includes.
 894         * top.h: Fix common/ includes.
 895         * top.c: Fix common/ includes.
 896         * thread.c: Fix common/ includes.
 897         * target/waitstatus.h: Fix common/ includes.
 898         * target/waitstatus.c: Fix common/ includes.
 899         * target.h: Fix common/ includes.
 900         * target.c: Fix common/ includes.
 901         * target-memory.c: Fix common/ includes.
 902         * target-descriptions.c: Fix common/ includes.
 903         * symtab.h: Fix common/ includes.
 904         * symfile.c: Fix common/ includes.
 905         * stap-probe.c: Fix common/ includes.
 906         * spu-linux-nat.c: Fix common/ includes.
 907         * sparc-nat.c: Fix common/ includes.
 908         * source.c: Fix common/ includes.
 909         * solib.c: Fix common/ includes.
 910         * solib-target.c: Fix common/ includes.
 911         * ser-unix.c: Fix common/ includes.
 912         * ser-tcp.c: Fix common/ includes.
 913         * ser-pipe.c: Fix common/ includes.
 914         * ser-base.c: Fix common/ includes.
 915         * selftest-arch.c: Fix common/ includes.
 916         * s12z-tdep.c: Fix common/ includes.
 917         * rust-exp.y: Fix common/ includes.
 918         * rs6000-aix-tdep.c: Fix common/ includes.
 919         * riscv-tdep.c: Fix common/ includes.
 920         * remote.c: Fix common/ includes.
 921         * remote-notif.h: Fix common/ includes.
 922         * remote-fileio.h: Fix common/ includes.
 923         * remote-fileio.c: Fix common/ includes.
 924         * regcache.h: Fix common/ includes.
 925         * regcache.c: Fix common/ includes.
 926         * record-btrace.c: Fix common/ includes.
 927         * python/python.c: Fix common/ includes.
 928         * python/py-type.c: Fix common/ includes.
 929         * python/py-inferior.c: Fix common/ includes.
 930         * progspace.h: Fix common/ includes.
 931         * producer.c: Fix common/ includes.
 932         * procfs.c: Fix common/ includes.
 933         * proc-api.c: Fix common/ includes.
 934         * printcmd.c: Fix common/ includes.
 935         * ppc-linux-nat.c: Fix common/ includes.
 936         * parser-defs.h: Fix common/ includes.
 937         * osdata.c: Fix common/ includes.
 938         * obsd-nat.c: Fix common/ includes.
 939         * nat/x86-linux.c: Fix common/ includes.
 940         * nat/x86-linux-dregs.c: Fix common/ includes.
 941         * nat/x86-dregs.h: Fix common/ includes.
 942         * nat/x86-dregs.c: Fix common/ includes.
 943         * nat/ppc-linux.c: Fix common/ includes.
 944         * nat/mips-linux-watch.h: Fix common/ includes.
 945         * nat/mips-linux-watch.c: Fix common/ includes.
 946         * nat/linux-waitpid.c: Fix common/ includes.
 947         * nat/linux-ptrace.h: Fix common/ includes.
 948         * nat/linux-ptrace.c: Fix common/ includes.
 949         * nat/linux-procfs.c: Fix common/ includes.
 950         * nat/linux-personality.c: Fix common/ includes.
 951         * nat/linux-osdata.c: Fix common/ includes.
 952         * nat/linux-namespaces.c: Fix common/ includes.
 953         * nat/linux-btrace.h: Fix common/ includes.
 954         * nat/linux-btrace.c: Fix common/ includes.
 955         * nat/fork-inferior.c: Fix common/ includes.
 956         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 957         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 958         * nat/aarch64-linux.c: Fix common/ includes.
 959         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 960         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 961         * namespace.h: Fix common/ includes.
 962         * mips-linux-tdep.c: Fix common/ includes.
 963         * minsyms.c: Fix common/ includes.
 964         * mi/mi-parse.h: Fix common/ includes.
 965         * mi/mi-main.c: Fix common/ includes.
 966         * mi/mi-cmd-env.c: Fix common/ includes.
 967         * memrange.h: Fix common/ includes.
 968         * memattr.c: Fix common/ includes.
 969         * maint.h: Fix common/ includes.
 970         * maint.c: Fix common/ includes.
 971         * main.c: Fix common/ includes.
 972         * machoread.c: Fix common/ includes.
 973         * location.c: Fix common/ includes.
 974         * linux-thread-db.c: Fix common/ includes.
 975         * linux-nat.c: Fix common/ includes.
 976         * linux-fork.c: Fix common/ includes.
 977         * inline-frame.c: Fix common/ includes.
 978         * infrun.c: Fix common/ includes.
 979         * inflow.c: Fix common/ includes.
 980         * inferior.h: Fix common/ includes.
 981         * inferior.c: Fix common/ includes.
 982         * infcmd.c: Fix common/ includes.
 983         * inf-ptrace.c: Fix common/ includes.
 984         * inf-child.c: Fix common/ includes.
 985         * ia64-linux-nat.c: Fix common/ includes.
 986         * i387-tdep.c: Fix common/ includes.
 987         * i386-tdep.c: Fix common/ includes.
 988         * i386-linux-tdep.c: Fix common/ includes.
 989         * i386-linux-nat.c: Fix common/ includes.
 990         * i386-go32-tdep.c: Fix common/ includes.
 991         * i386-fbsd-tdep.c: Fix common/ includes.
 992         * i386-fbsd-nat.c: Fix common/ includes.
 993         * guile/scm-type.c: Fix common/ includes.
 994         * guile/guile.c: Fix common/ includes.
 995         * go32-nat.c: Fix common/ includes.
 996         * gnu-nat.c: Fix common/ includes.
 997         * gdbthread.h: Fix common/ includes.
 998         * gdbarch-selftests.c: Fix common/ includes.
 999         * gdb_usleep.c: Fix common/ includes.
1000         * gdb_select.h: Fix common/ includes.
1001         * gdb_bfd.c: Fix common/ includes.
1002         * gcore.c: Fix common/ includes.
1003         * fork-child.c: Fix common/ includes.
1004         * findvar.c: Fix common/ includes.
1005         * fbsd-nat.c: Fix common/ includes.
1006         * event-top.c: Fix common/ includes.
1007         * event-loop.c: Fix common/ includes.
1008         * dwarf2read.c: Fix common/ includes.
1009         * dwarf2loc.c: Fix common/ includes.
1010         * dwarf2-frame.c: Fix common/ includes.
1011         * dwarf-index-cache.c: Fix common/ includes.
1012         * dtrace-probe.c: Fix common/ includes.
1013         * disasm-selftests.c: Fix common/ includes.
1014         * defs.h: Fix common/ includes.
1015         * csky-tdep.c: Fix common/ includes.
1016         * cp-valprint.c: Fix common/ includes.
1017         * cp-support.h: Fix common/ includes.
1018         * cp-support.c: Fix common/ includes.
1019         * corelow.c: Fix common/ includes.
1020         * completer.h: Fix common/ includes.
1021         * completer.c: Fix common/ includes.
1022         * compile/compile.c: Fix common/ includes.
1023         * compile/compile-loc2c.c: Fix common/ includes.
1024         * compile/compile-cplus-types.c: Fix common/ includes.
1025         * compile/compile-cplus-symbols.c: Fix common/ includes.
1026         * command.h: Fix common/ includes.
1027         * cli/cli-dump.c: Fix common/ includes.
1028         * cli/cli-cmds.c: Fix common/ includes.
1029         * charset.c: Fix common/ includes.
1030         * build-id.c: Fix common/ includes.
1031         * btrace.h: Fix common/ includes.
1032         * btrace.c: Fix common/ includes.
1033         * breakpoint.h: Fix common/ includes.
1034         * breakpoint.c: Fix common/ includes.
1035         * ax.h:
1036         (enum agent_op): Fix common/ includes.
1037         * ax-general.c (struct aop_map): Fix common/ includes.
1038         * ax-gdb.c: Fix common/ includes.
1039         * auxv.c: Fix common/ includes.
1040         * auto-load.c: Fix common/ includes.
1041         * arm-tdep.c: Fix common/ includes.
1042         * arch/riscv.c: Fix common/ includes.
1043         * arch/ppc-linux-common.c: Fix common/ includes.
1044         * arch/i386.c: Fix common/ includes.
1045         * arch/arm.c: Fix common/ includes.
1046         * arch/arm-linux.c: Fix common/ includes.
1047         * arch/arm-get-next-pcs.c: Fix common/ includes.
1048         * arch/amd64.c: Fix common/ includes.
1049         * arch/aarch64.c: Fix common/ includes.
1050         * arch/aarch64-insn.c: Fix common/ includes.
1051         * arch-utils.c: Fix common/ includes.
1052         * amd64-windows-tdep.c: Fix common/ includes.
1053         * amd64-tdep.c: Fix common/ includes.
1054         * amd64-sol2-tdep.c: Fix common/ includes.
1055         * amd64-obsd-tdep.c: Fix common/ includes.
1056         * amd64-nbsd-tdep.c: Fix common/ includes.
1057         * amd64-linux-tdep.c: Fix common/ includes.
1058         * amd64-linux-nat.c: Fix common/ includes.
1059         * amd64-fbsd-tdep.c: Fix common/ includes.
1060         * amd64-fbsd-nat.c: Fix common/ includes.
1061         * amd64-dicos-tdep.c: Fix common/ includes.
1062         * amd64-darwin-tdep.c: Fix common/ includes.
1063         * agent.c: Fix common/ includes.
1064         * ada-lang.h: Fix common/ includes.
1065         * ada-lang.c: Fix common/ includes.
1066         * aarch64-tdep.c: Fix common/ includes.
1067
1068 2019-01-25  Tom Tromey  <tom@tromey.com>
1069
1070         * common/create-version.sh: Use common/version.h.
1071
1072 2019-01-24  Pedro Alves  <palves@redhat.com>
1073
1074         * infrun.c (signal_stop, signal_print, signal_program)
1075         (signal_catch, signal_pass): Now arrays instead of pointers.
1076         (update_signals_program_target, do_target_resume)
1077         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1078         * linux-nat.c (linux_nat_target::pass_signals)
1079         (linux_nat_target::create_inferior, linux_nat_target::attach):
1080         Adjust.
1081         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1082         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1083         * procfs.c (procfs_target::pass_signals): Adjust.
1084         * record-full.c (record_full_target::resume): Adjust.
1085         * remote.c (remote_target::pass_signals)
1086         (remote_target::program_signals): Adjust.
1087         * target-debug.h (target_debug_print_signals): Now takes a
1088         gdb::array_view as parameter.  Adjust.
1089         * target.h (target_ops) <pass_signals, program_signals>: Replace
1090         pointer and length parameters with gdb::array_view.
1091         (target_pass_signals, target_program_signals): Likewise.
1092         * target-delegates.c: Regenerate.
1093
1094 2019-01-24  Pedro Alves  <palves@redhat.com>
1095
1096         * common/forward-scope-exit.h
1097         (forward_scope_exit::forward_scope_exit): Pass arguments to
1098         m_bind_function directly, instead of creating a std::bind and
1099         copying that.
1100
1101 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1102
1103         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1104         for static members.
1105         (pass_in_v_vfp_candidate): Likewise.
1106
1107 2019-01-23  Tom Tromey  <tom@tromey.com>
1108             Pedro Alves  <palves@redhat.com>
1109
1110         * regcache.c (class regcache_invalidator): Remove.
1111         (regcache::raw_write): Use make_scope_exit.
1112
1113 2019-01-23  Tom Tromey  <tom@tromey.com>
1114
1115         * ui-out.h (class ui_out_emit_type): Update comment.
1116
1117 2019-01-23  Tom Tromey  <tom@tromey.com>
1118
1119         * infrun.c (fetch_inferior_event): Update comment.
1120
1121 2019-01-23  Tom Tromey  <tom@tromey.com>
1122             Pedro Alves  <palves@redhat.com>
1123
1124         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1125         parameter.
1126         (fetch_inferior_event): Use SCOPE_EXIT.
1127
1128
1129 2019-01-23  Tom Tromey  <tom@tromey.com>
1130             Pedro Alves  <palves@redhat.com>
1131
1132         * infrun.c (disable_thread_events): Delete.
1133         (stop_all_threads): Use SCOPE_EXIT.
1134
1135 2019-01-23  Tom Tromey  <tom@tromey.com>
1136             Pedro Alves  <palves@redhat.com>
1137
1138         * symfile.c: Include forward-scope-exit.h.
1139         (clear_symtab_users_cleanup): Replace forward declaration with
1140         a FORWARD_SCOPE_EXIT.
1141         (syms_from_objfile_1): Use the forward_scope_exit and
1142         gdb::optional instead of cleanup_function.
1143         (reread_symbols): Use the forward_scope_exit instead of
1144         cleanup_function.
1145         (clear_symtab_users_cleanup): Remove function.
1146
1147 2019-01-23  Tom Tromey  <tom@tromey.com>
1148             Pedro Alves  <palves@redhat.com>
1149
1150         * linux-nat.c: Include scope-exit.h.
1151         (cleanup_target_stop): Remove.
1152         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1153         SCOPE_EXIT.
1154
1155 2019-01-23  Tom Tromey  <tom@tromey.com>
1156             Pedro Alves  <palves@redhat.com>
1157
1158         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1159         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1160
1161 2019-01-23  Tom Tromey  <tom@tromey.com>
1162             Andrew Burgess  <andrew.burgess@embecosm.com>
1163             Pedro Alves  <palves@redhat.com>
1164
1165         * infrun.c (fetch_inferior_event): Use scope_exit.
1166         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1167         * top.c (execute_command): Use scope_exit.
1168         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1169         * utils.c (do_bpstat_clear_actions_cleanup)
1170         (make_bpstat_clear_actions_cleanup): Remove.
1171
1172 2019-01-23  Tom Tromey  <tom@tromey.com>
1173             Pedro Alves  <palves@redhat.com>
1174
1175         * infrun.c: Include "common/scope-exit.h"
1176         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1177         (wait_for_inferior): Use SCOPE_EXIT.
1178         (fetch_inferior_event): Use scope_exit.
1179
1180 2019-01-23  Tom Tromey  <tom@tromey.com>
1181             Pedro Alves  <palves@redhat.com>
1182
1183         * breakpoint.c (create_breakpoint): Remove cleanup.
1184
1185 2019-01-23  Tom Tromey  <tom@tromey.com>
1186             Andrew Burgess  <andrew.burgess@embecosm.com>
1187             Pedro Alves  <palves@redhat.com>
1188
1189 2019-01-23  Pedro Alves  <palves@redhat.com>
1190
1191         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1192
1193 2019-01-23  Pedro Alves  <palves@redhat.com>
1194             Andrew Burgess  <andrew.burgess@embecosm.com>
1195
1196         * gdbthread.h: Include "common/forward-scope-exit.h".
1197         (scoped_finish_thread_state): Redefine custom class in terms of
1198         forward_scope_exit.
1199
1200 2019-01-23  Pedro Alves  <palves@redhat.com>
1201             Andrew Burgess  <andrew.burgess@embecosm.com>
1202
1203         * common/forward-scope-exit.h: New file.
1204
1205 2019-01-23  Pedro Alves  <palves@redhat.com>
1206             Andrew Burgess  <andrew.burgess@embecosm.com>
1207             Tom Tromey  <tom@tromey.com>
1208
1209         * common/scope-exit.h: New file.
1210
1211 2019-01-23  Pedro Alves  <palves@redhat.com>
1212
1213         * common/preprocessor.h (ESC): Rename to ...
1214         (ESC_PARENS): ... this.
1215         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1216         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1217
1218 2019-01-23  Tom Tromey  <tom@tromey.com>
1219
1220         * language.h (class scoped_switch_to_sym_language_if_auto):
1221         Initialize m_lang in both cases.
1222
1223 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1224
1225         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1226         with XCNEW.
1227
1228 2019-01-22  Tom Tromey  <tom@tromey.com>
1229
1230         * corelow.c: Do not include sys/file.h.
1231
1232 2019-01-22  Tom Tromey  <tom@tromey.com>
1233
1234         * tui/tui-wingeneral.h: Include gdb_curses.h.
1235
1236 2019-01-22  Tom Tromey  <tom@tromey.com>
1237
1238         * source-cache.h (class source_cache) <get_source_lines,
1239         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1240
1241 2019-01-22  Tom Tromey  <tom@tromey.com>
1242
1243         * remote-fileio.h (struct remote_target): Declare.
1244
1245 2019-01-22  Tom Tromey  <tom@tromey.com>
1246
1247         * python/py-arch.c: Do not include py-ref.h.
1248         * python/py-bpevent.c: Do not include py-ref.h.
1249         * python/py-cmd.c: Do not include py-ref.h.
1250         * python/py-continueevent.c: Do not include py-ref.h.
1251         * python/py-event.h: Do not include py-ref.h.
1252         * python/py-evtregistry.c: Do not include py-ref.h.
1253         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1254         * python/py-frame.c: Do not include py-ref.h.
1255         * python/py-framefilter.c: Do not include py-ref.h.
1256         * python/py-function.c: Do not include py-ref.h.
1257         * python/py-infevents.c: Do not include py-ref.h.
1258         * python/py-linetable.c: Do not include py-ref.h.
1259         * python/py-objfile.c: Do not include py-ref.h.
1260         * python/py-param.c: Do not include py-ref.h.
1261         * python/py-prettyprint.c: Do not include py-ref.h.
1262         * python/py-progspace.c: Do not include py-ref.h.
1263         * python/py-symbol.c: Do not include py-ref.h.
1264         * python/py-symtab.c: Do not include py-ref.h.
1265         * python/py-type.c: Do not include py-ref.h.
1266         * python/py-unwind.c: Do not include py-ref.h.
1267         * python/py-utils.c: Do not include py-ref.h.
1268         * python/py-value.c: Do not include py-ref.h.
1269         * python/py-varobj.c: Do not include py-ref.h.
1270         * python/py-xmethods.c: Do not include py-ref.h.
1271         * python/python.c: Do not include py-ref.h.
1272         * varobj.c: Do not include py-ref.h.
1273
1274 2019-01-22  Tom Tromey  <tom@tromey.com>
1275
1276         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1277         keyword for bcache.
1278
1279 2019-01-22  Tom Tromey  <tom@tromey.com>
1280
1281         * compile/compile-cplus-types.c: Remove a comment by #include.
1282
1283 2019-01-22  Tom Tromey  <tom@tromey.com>
1284
1285         * compile/gcc-c-plugin.h: Include compile-internal.h.
1286
1287 2019-01-22  Tom Tromey  <tom@tromey.com>
1288
1289         * stabsread.c (EXTERN): Do not define.
1290         (symnum, next_symbol_text_func, processing_gcc_compilation)
1291         (within_function, global_sym_chain, global_stabs)
1292         (previous_stab_code, this_object_header_files)
1293         (n_this_object_header_files)
1294         (n_allocated_this_object_header_files): Define.
1295         * stabsread.h (EXTERN): Never define.  Use "extern".
1296
1297 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1298
1299         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1300         history_value.
1301
1302 2019-01-21  Tom Tromey  <tom@tromey.com>
1303
1304         * ui-out.c: Fix includes.
1305         * tui/tui-source.c: Fix includes.
1306         * target.c: Fix includes.
1307         * remote.c: Fix includes.
1308         * regcache.c: Fix includes.
1309         * python/py-block.c: Fix includes.
1310         * printcmd.c: Fix includes.
1311         * or1k-tdep.c: Fix includes.
1312         * mi/mi-main.c: Fix includes.
1313         * m32r-tdep.c: Fix includes.
1314         * csky-tdep.c: Fix includes.
1315         * compile/compile-cplus-types.c: Fix includes.
1316         * cli/cli-interp.c: Fix includes.
1317
1318 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1319
1320         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1321         for padding.
1322
1323 2019-01-16  Tom Tromey  <tom@tromey.com>
1324
1325         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1326         earlier.
1327         (struct objfile) <msymbols_range>: Move from top level.
1328         <msymbols>: New method.
1329         (class objfile_msymbols): Remove.
1330         * symtab.c (default_collect_symbol_completion_matches_break_on):
1331         Update.
1332         * symmisc.c (dump_msymbols): Update.
1333         * stabsread.c (scan_file_globals): Update.
1334         * objc-lang.c (info_selectors_command, info_classes_command)
1335         (find_methods): Update.
1336         * minsyms.c (find_solib_trampoline_target): Update.
1337         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1338         * coffread.c (coff_symfile_read): Update.
1339         * ada-lang.c (ada_lookup_simple_minsym)
1340         (ada_collect_symbol_completion_matches): Update.
1341
1342 2019-01-16  Tom Tromey  <tom@tromey.com>
1343
1344         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1345         type.  Remove no-argument constructor.
1346         <iterator::operator++>: Simplify.
1347         <begin>: Update.
1348         <end>: Use minimal_symbol_count.
1349
1350 2019-01-16  Tom Tromey  <tom@tromey.com>
1351
1352         * objfiles.h (struct objfile) <psymtabs>: New method.
1353         (class objfile_psymtabs): Remove.
1354         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1355         typedef.
1356         <range>: New method.
1357         (require_partial_symbols): Change return type.
1358         * psymtab.c (require_partial_symbols)
1359         (psym_expand_symtabs_matching): Update.
1360         * mdebugread.c (parse_partial_symbols): Update.
1361         * dbxread.c (dbx_end_psymtab): Update.
1362
1363 2019-01-15  Tom Tromey  <tom@tromey.com>
1364
1365         * symtab.c (lookup_objfile_from_block)
1366         (lookup_symbol_in_objfile_symtabs)
1367         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1368         (find_line_symtab, info_sources_command)
1369         (default_collect_symbol_completion_matches_break_on)
1370         (make_source_files_completion_list): Update.
1371         * symmisc.c (print_objfile_statistics, dump_objfile)
1372         (maintenance_print_symbols, maintenance_info_symtabs)
1373         (maintenance_check_symtabs, maintenance_info_line_tables):
1374         Update.
1375         * source.c (select_source_symtab)
1376         (forget_cached_source_info_for_objfile): Update.
1377         * objfiles.h (class objfile_compunits): Remove.
1378         (struct objfile) <compunits_range>: New typedef.
1379         (compunits): New method.
1380         * objfiles.c (objfile_relocate1): Update.
1381         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1382         * maint.c (count_symtabs_and_blocks): Update.
1383         * linespec.c (iterate_over_all_matching_symtabs): Update.
1384         * cp-support.c (add_symbol_overload_list_qualified): Update.
1385         * coffread.c (coff_symtab_read): Update.
1386         * ada-lang.c (add_nonlocal_symbols)
1387         (ada_collect_symbol_completion_matches)
1388         (ada_add_global_exceptions): Update.
1389
1390 2019-01-15  Tom Tromey  <tom@tromey.com>
1391
1392         * progspace.h (program_space) <objfiles_safe_range>: New
1393         typedef.
1394         <objfiles_safe>: New method.
1395         * objfiles.h (class all_objfiles_safe): Remove.
1396         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1397         * jit.c (jit_inferior_exit_hook): Update.
1398
1399 2019-01-17  Tom Tromey  <tom@tromey.com>
1400
1401         * progspace.h (program_space) <objfiles_range>: New typedef.
1402         <objfiles>: New method.
1403         <objfiles_head>: Rename from objfiles.
1404         (object_files): Update.
1405         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1406         * guile/scm-pretty-print.c
1407         (ppscm_find_pretty_printer_from_objfiles): Update.
1408         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1409         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1410         Update.
1411         * python/py-progspace.c (pspy_get_objfiles): Update.
1412         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1413         Update.
1414         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1415         (objfpy_lookup_objfile_by_build_id): Update.
1416         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1417         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1418         Update.
1419         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1420         (expand_symtab_containing_pc, lookup_objfile_from_block)
1421         (lookup_static_symbol, basic_lookup_transparent_type)
1422         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1423         (find_line_symtab, info_sources_command)
1424         (default_collect_symbol_completion_matches_break_on)
1425         (make_source_files_completion_list, find_main_name): Update.
1426         * symmisc.c (print_symbol_bcache_statistics)
1427         (print_objfile_statistics, maintenance_print_symbols)
1428         (maintenance_print_msymbols, maintenance_print_objfiles)
1429         (maintenance_info_symtabs, maintenance_check_symtabs)
1430         (maintenance_expand_symtabs, maintenance_info_line_tables):
1431         Update.
1432         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1433         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1434         (map_overlay_command, unmap_overlay_command)
1435         (simple_overlay_update, expand_symtabs_matching)
1436         (map_symbol_filenames): Update.
1437         * symfile-debug.c (set_debug_symfile): Update.
1438         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1439         Update.
1440         * source.c (select_source_symtab, forget_cached_source_info):
1441         Update.
1442         * solib.c (solib_read_symbols): Update.
1443         * solib-spu.c (append_ocl_sos): Update.
1444         * psymtab.c (maintenance_print_psymbols)
1445         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1446         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1447         * printcmd.c (info_symbol_command): Update.
1448         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1449         Update.
1450         * objfiles.h (class all_objfiles): Remove.
1451         * objfiles.c (have_partial_symbols, have_full_symbols)
1452         (have_minimal_symbols, qsort_cmp, update_section_map)
1453         (shared_objfile_contains_address_p)
1454         (default_iterate_over_objfiles_in_search_order): Update.
1455         * objc-lang.c (info_selectors_command, info_classes_command)
1456         (find_methods): Update.
1457         * minsyms.c (find_solib_trampoline_target): Update.
1458         * maint.c (maintenance_info_sections)
1459         (maintenance_translate_address, count_symtabs_and_blocks):
1460         Update.
1461         * main.c (captured_main_1): Update.
1462         * linux-thread-db.c (try_thread_db_load_from_pdir)
1463         (has_libpthread): Update.
1464         * linespec.c (iterate_over_all_matching_symtabs)
1465         (search_minsyms_for_name): Update.
1466         * jit.c (jit_find_objf_with_entry_addr): Update.
1467         * hppa-tdep.c (find_unwind_entry)
1468         (hppa_lookup_stub_minimal_symbol): Update.
1469         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1470         Update.
1471         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1472         (elf_gnu_ifunc_resolve_by_got): Update.
1473         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1474         * dwarf-index-write.c (save_gdb_index_command): Update.
1475         * cp-support.c (add_symbol_overload_list_qualified): Update.
1476         * breakpoint.c (create_overlay_event_breakpoint)
1477         (create_longjmp_master_breakpoint)
1478         (create_std_terminate_master_breakpoint)
1479         (create_exception_master_breakpoint): Update.
1480         * blockframe.c (find_pc_partial_function): Update.
1481         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1482         (ada_collect_symbol_completion_matches)
1483         (ada_add_global_exceptions): Update.
1484
1485 2019-01-17  Tom Tromey  <tom@tromey.com>
1486
1487         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1488         declare VEC.
1489         (solib_target_parse_libraries): Change return type.
1490         (library_list_start_segment, library_list_start_section)
1491         (library_list_end_library, library_list_start_library); Update.
1492         (solib_target_free_library_list): Remove.
1493         (solib_target_parse_libraries): Remove cleanup.  Change return
1494         type.
1495         (solib_target_current_sos): Update.
1496
1497 2019-01-17  Tom Tromey  <tromey@bapiya>
1498
1499         * valprint.c: Replace "the the" with "the".
1500         * symtab.c: Replace "the the" with "the".
1501         * solib.c: Replace "the the" with "the".
1502         * solib-dsbt.c: Replace "the the" with "the".
1503         * linespec.c: Replace "the the" with "the".
1504         * dwarf2loc.h: Replace "the the" with "the".
1505         * amd64-windows-tdep.c: Replace "the the" with "the".
1506         * aarch64-tdep.c: Replace "the the" with "the".
1507
1508 2019-01-16  Keith Seitz  <keiths@redhat.com>
1509
1510         PR gdb/23773
1511         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1512         <builder>: Rename to ..
1513         <m_builder>: ... this and make private.
1514         (dwarf2_cu::get_builder): New method.  Change all users of
1515         `builder' to use this method.
1516         (dwarf2_start_symtab): Move to ...
1517         (dwarf2_cu::start_symtab): ... here.  Update all callers
1518         (setup_type_unit_groups): Move to ...
1519         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1520         callers.
1521         (dwarf2_cu::reset_builder): New method.
1522         (process_full_compunit, process_full_type_unit): Use
1523         dwarf2_cu::reset_builder.
1524         (follow_die_offset): Record the ancestor CU if it is different
1525         from the followed DIE's CU.
1526         (follow_die_sig_1): Likewise.
1527
1528 2019-01-15  Tom Tromey  <tom@tromey.com>
1529
1530         * remote.c (class remote_state) <buf>: Now a char_vector.
1531         <buf_size>: Remove.
1532         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1533         parameter.
1534         (remote_target::getpkt_or_notif_sane_1)
1535         (remote_target::getpkt_sane)
1536         (remote_target::getpkt_or_notif_sane): Likewise.
1537         (class remote_target) <putpkt>: New overload.
1538         (remote_target::read_frame): Change type of "buf_p".  Remove
1539         sizeof_p parameter.
1540         (packet_ok): New overload.
1541         (packet_check_result): New overload.
1542         Update all uses.
1543
1544 2019-01-14  Tom Tromey  <tom@tromey.com>
1545
1546         * remote-notif.c (handle_notification, remote_notif_ack)
1547         (remote_notif_parse): Make "buf" const.
1548         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1549         const.
1550         (remote_notif_parse, remote_notif_ack, handle_notification):
1551         Likewise.
1552         * remote.c (remote_notif_stop_parse): Make "buf" const.
1553         (remote_target::remote_parse_stop_reply): Make "buf" const.
1554         (remote_notif_stop_ack): Make "buf" const.
1555
1556 2019-01-14  Tom Tromey  <tom@tromey.com>
1557
1558         * remote.c (remote_console_output): Make parameter const.
1559
1560 2019-01-14  Tom Tromey  <tom@tromey.com>
1561
1562         * target-debug.h (target_debug_print_signals): Constify.
1563         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1564         * procfs.c (procfs_target::pass_signals): Update.
1565         * linux-nat.c (linux_nat_target::pass_signals): Update.
1566         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1567         * target-delegates.c: Rebuild.
1568         * remote.c (remote_target::program_signals): Update.
1569         (remote_target::pass_signals): Update.
1570         * target.c (target_pass_signals): Constify argument.
1571         (target_program_signals): Likewise.
1572         * target.h (struct target_ops) <pass_signals, program_signals>:
1573         Constify argument.
1574         (target_pass_signals, target_program_signals): Constify argument.
1575
1576 2019-01-14  Tom Tromey  <tom@tromey.com>
1577
1578         PR tui/28819:
1579         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1580
1581 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1582
1583         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1584         field.
1585         * rs6000-tdep.c: Include reggroups.h.
1586         (IS_V_ALIAS_PSEUDOREG): Define.
1587         (rs6000_register_name): Return names for the "vX" aliases.
1588         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1589         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1590         aliases.  Call default_register_reggroup_p for all other
1591         pseudo-registers.
1592         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1593         New functions.
1594         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1595         Handle "vX" aliases.
1596         (v_alias_pseudo_register_collect): New function.
1597         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1598         (rs6000_gdbarch_init): Initialize "vX" aliases as
1599         pseudo-registers.  Restore registration of
1600         rs6000_pseudo_register_reggroup_p with
1601         set_tdesc_pseudo_register_reggroup_p.
1602
1603 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1604
1605         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1606         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1607         set_gdbarch_num_pseudo_regs.
1608
1609 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1610
1611         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1612         Remove arg prefixname, add do_set and do_show.
1613         Add member functions set_list and show_list.
1614         * cli/cli-style.c (class cli_style_option): Update accordingly.
1615         (style_set_list): Move to file scope.
1616         (style_show_list): Likewise.
1617         (set_style): Call help_list.
1618         (show_style): Call cmd_show_list.
1619         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1620         Update to use the new macro.
1621
1622 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1623
1624         * ada-lang.c (_initialize_ada_language): Expand the help text
1625         for the "catch exception" command.
1626
1627 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1628
1629         * symtab.c (matching_obj_sections): Initialize obj,
1630         declare it closer to its usage.
1631
1632 2019-01-10  Tom Tromey  <tom@tromey.com>
1633
1634         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1635         (basic_inf_threads_range): Remove.
1636         (inf_threads_range, inf_non_exited_threads_range)
1637         (safe_inf_threads_range): Use next_adapter.
1638
1639 2019-01-10  Keith Seitz  <keiths@redhat.com>
1640
1641         PR gdb/23712
1642         PR symtab/23010
1643         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1644         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1645
1646 2019-01-10  Keith Seitz  <keiths@redhat.com>
1647
1648         PR gdb/23712
1649         PR symtab/23010
1650         * dictionary.c (pending_to_vector): Remove.
1651         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1652         Remove _1 suffix, replacing functions of the same name.  Update
1653         all callers.
1654         (dict_create_hashed, dict_create_hashed_expandable)
1655         (dict_create_linear, dict_create_linear_expandable, dict_free)
1656         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1657         Make functions static.
1658
1659 2019-01-10  Keith Seitz  <keiths@redhat.com>
1660
1661         PR gdb/23712
1662         PR symtab/23010
1663         * dictionary.h (struct dictionary): Replace declaration with
1664         multidictionary.
1665         (dict_create_hashed, dict_create_hashed_expandable)
1666         (dict_create_linear, dict_create_linear_expandable)
1667         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1668         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1669         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1670         taking multidictionary argument.
1671         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1672         * block.h (struct block) <dict>: Change to multidictionary
1673         and rename `multidict'.
1674         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1675         symmisc.c: Update all dictionary references to multidictionary.
1676
1677 2019-01-10  Keith Seitz  <keiths@redhat.com>
1678
1679         PR gdb/23712
1680         PR symtab/23010
1681         * dictionary.c: Include unordered_map.
1682         (pending_to_vector): New function.
1683         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1684         Rewrite the non-"_1" functions to take vector instead
1685         of linked list.
1686         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1687         "new" _1 versions of the same name.
1688         (multidictionary): Define.
1689         (std::hash<enum language): New definition.
1690         (collate_pending_symbols_by_language, mdict_create_hashed)
1691         (mdict_create_hashed_expandable, mdict_create_linear)
1692         (mdict_create_linear_expandable, mdict_free)
1693         (find_language_dictionary, create_new_language_dictionary)
1694         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1695         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1696         (mdict_size, mdict_empty): New functions.
1697         * dictionary.h (mdict_iterator): Define.
1698
1699 2019-01-10  Pedro Alves  <palves@redhat.com>
1700
1701         * breakpoint.c (read_uploaded_action)
1702         (create_tracepoint_from_upload): Adjust to use
1703         gdb::unique_xmalloc_ptr.
1704         * ctf.c (ctf_write_uploaded_tp):
1705         (SET_ARRAY_FIELD): Use emplace_back.
1706         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1707         * tracefile-tfile.c (tfile_write_uploaded_tp):
1708         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1709         gdb::unique_xmalloc_ptr.
1710         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1711         at_string, cond_string, cmd_strings>: Replace char pointers
1712         with gdb::unique_xmalloc_ptr.
1713
1714 2019-01-10  Pedro Alves  <palves@redhat.com>
1715
1716         * solib-target.c (library_list_start_library): Don't xstrdup name.
1717
1718 2019-01-10  Pedro Alves  <palves@redhat.com>
1719
1720         * mdebugread.c (parse_partial_symbols): Use
1721         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1722
1723 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1724
1725         * linux-fork.c (scoped_switch_fork_info)
1726         <~scoped_switch_fork_info>: Fix incorrect variable name.
1727
1728 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1729
1730         * linux-fork.c (scoped_switch_fork_info)
1731         <scoped_switch_fork_info>: Make explicit.
1732         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1733
1734 2019-01-10  Tom Tromey  <tom@tromey.com>
1735
1736         * objfiles.h (objfile::reset_psymtabs): Update.
1737         * objfiles.c (objfile::objfile): Update.
1738         * psymtab.h (psymtab_storage::obstack): Update.
1739         (psymtab_storage::m_obstack): Use gdb::optional.
1740         (class psymtab_storage): Update comment.  Remove objfile
1741         parameter.
1742         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1743
1744 2019-01-10  Tom Tromey  <tom@tromey.com>
1745
1746         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1747         <free_psymtabs>: Now private.
1748         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1749         (allocate_psymtab): Use new method.
1750
1751 2019-01-10  Tom Tromey  <tom@tromey.com>
1752
1753         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1754         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1755         * mdebugread.c (parse_partial_symbols): Use
1756         allocate_dependencies.
1757         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1758         allocate_dependencies.
1759         (process_psymtab_comp_unit_reader)
1760         (build_type_psymtab_dependencies): Likewise.
1761         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1762
1763 2019-01-10  Tom Tromey  <tom@tromey.com>
1764
1765         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1766         PSYMBOL_SET_LANGUAGE.
1767         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1768
1769 2019-01-10  Tom Tromey  <tom@tromey.com>
1770
1771         * psymtab.h (psymtab_storage::obstack): New method.
1772         <m_obstack>: Rename from obstack; now private.
1773         * psymtab.c (psymtab_storage): Update.
1774         * dwarf2read.c (create_addrmap_from_index)
1775         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1776         Update.
1777
1778 2019-01-10  Tom Tromey  <tom@tromey.com>
1779
1780         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1781         * objfiles.h (objfile::reset_psymtabs): New method.
1782
1783 2019-01-10  Tom Tromey  <tom@tromey.com>
1784
1785         * symmisc.c (print_symbol_bcache_statistics): Update.
1786         (print_objfile_statistics): Update.
1787         * symfile.c (reread_symbols): Update.
1788         * psymtab.h (class psymtab_storage): New.
1789         * psymtab.c (psymtab_storage): New constructor.
1790         (~psymtab_storage): New destructor.
1791         (require_partial_symbols): Update.
1792         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1793         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1794         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1795         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1796         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1797         (start_psymtab_common, end_psymtab_common)
1798         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1799         (allocate_psymtab): Update.
1800         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1801         Update.
1802         (dump_psymtab_addrmap, maintenance_print_psymbols)
1803         (maintenance_check_psymtabs): Update.
1804         (class objfile_psymtabs): Move to objfiles.h.
1805         * psympriv.h (discard_psymtab): Now inline.
1806         (psymtab_discarder::psymtab_discarder): Update.
1807         (psymtab_discarder::~psymtab_discarder): Update.
1808         (ALL_OBJFILE_PSYMTABS): Rewrite.
1809         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1810         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1811         Remove fields.
1812         <partial_symtabs>: New field.
1813         (class objfile_psymtabs): Move from psymtab.h.  Update.
1814         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1815         psymbol_cache.
1816         (objfile::~objfile): Don't destroy psymbol_cache.
1817         * mdebugread.c (parse_partial_symbols): Update.
1818         * dwarf2read.c (create_addrmap_from_index)
1819         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1820         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1821         (add_partial_subprogram, dwarf2_ranges_read): Update.
1822         * dwarf-index-write.c (write_address_map)
1823         (write_one_signatured_type, recursively_write_psymbols)
1824         (class debug_names, class debug_names, write_psymtabs_to_index):
1825         Update.
1826
1827 2019-01-10  Tom Tromey  <tom@tromey.com>
1828
1829         * symtab.h (SYMBOL_SET_NAMES): Update.
1830         (symbol_set_names): Update.
1831         (MSYMBOL_SET_NAMES): Update.
1832         * symtab.c (symbol_set_names): Change argument to be an
1833         objfile_per_bfd_storage.
1834         * psymtab.c (add_psymbol_to_bcache): Update.
1835         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1836
1837 2019-01-10  Tom Tromey  <tom@tromey.com>
1838
1839         * symtab.c (create_demangled_names_hash): Change argument to be an
1840         objfile_per_bfd_storage.
1841         (symbol_set_names): Update.
1842
1843 2019-01-10  Tom Tromey  <tom@tromey.com>
1844
1845         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1846         init_psymbol_list.
1847         * psymtab.c (init_psymbol_list): Do nothing if already called.
1848         * psympriv.h (init_psymbol_list): Add comment.
1849         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1850         init_psymbol_list.
1851         * dbxread.c (dbx_symfile_read): Unconditionally call
1852         init_psymbol_list.
1853
1854 2019-01-10  Tom Tromey  <tom@tromey.com>
1855
1856         * xcoffread.c (scan_xcoff_symtab): Update.
1857         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1858         "where".
1859         * mdebugread.c (parse_partial_symbols)
1860         (handle_psymbol_enumerators): Update.
1861         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1862         * dbxread.c (read_dbx_symtab): Update.
1863         * psympriv.h (psymbol_placement): New enum.
1864         (add_psymbol_to_list): Update.
1865
1866 2019-01-10  Tom Tromey  <tom@tromey.com>
1867
1868         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1869         static_psymbols parameters.
1870         (scan_xcoff_symtab): Update.
1871         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1872         static_psymbols parameters.
1873         * psympriv.h (start_psymtab_common): Update.
1874         * mdebugread.c (parse_partial_symbols): Update.
1875         * dwarf2read.c (create_partial_symtab): Update.
1876         * dbxread.c (read_dbx_symtab): Update.
1877         (start_psymtab): Remove global_psymbols and static_psymbols
1878         parameters.
1879
1880 2019-01-10  Tom Tromey  <tom@tromey.com>
1881
1882         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1883         * psymtab.c (allocate_psymtab): Add comment.
1884         * psympriv.h (allocate_psymtab): Add comment.
1885         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1886         initializations.
1887         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1888
1889 2019-01-10  Tom Tromey  <tom@tromey.com>
1890
1891         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1892         Don't declare.
1893         * mipsread.c: Include mdebugread.h.
1894         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1895         Declare.
1896         * elfread.c: Include mdebugread.h.
1897
1898 2019-01-09  Tom Tromey  <tom@tromey.com>
1899
1900         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1901         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1902         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1903         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1904         (psym_lookup_symbol, psym_find_last_source_symtab)
1905         (psym_forget_cached_source_info, psym_print_stats)
1906         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1907         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1908         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1909         (psym_find_compunit_symtab_by_address)
1910         (maintenance_print_psymbols, maintenance_info_psymtabs)
1911         (maintenance_check_psymtabs): Use ranged for.
1912         * psymtab.h (class objfile_psymtabs): New.
1913         (require_partial_symbols): Return objfile_psymtabs.
1914         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1915
1916 2019-01-09  Tom Tromey  <tom@tromey.com>
1917
1918         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1919         (find_pc_mapped_section, list_overlays_command)
1920         (map_overlay_command, unmap_overlay_command)
1921         (simple_overlay_update): Use all_objfiles.
1922         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1923         * printcmd.c (info_symbol_command): Use all_objfiles.
1924         * objfiles.h (ALL_OBJSECTIONS): Remove.
1925         * maint.c (maintenance_translate_address): Use all_objfiles.
1926         * gcore.c (gcore_create_callback): Use all_objfiles.
1927         (objfile_find_memory_regions): Likewise.
1928
1929 2019-01-09  Tom Tromey  <tom@tromey.com>
1930
1931         * symtab.c (find_line_symtab, info_sources_command)
1932         (make_source_files_completion_list): Use objfile_compunits.
1933         * source.c (select_source_symtab): Use objfile_compunits.
1934         * objfiles.h (struct objfile): Update comment.
1935         (ALL_OBJFILES): Remove.
1936         (ALL_FILETABS): Remove.
1937         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1938         objfile_compunits.
1939
1940 2019-01-09  Tom Tromey  <tom@tromey.com>
1941
1942         * symmisc.c (print_objfile_statistics, dump_objfile)
1943         (maintenance_print_symbols): Use compunit_filetabs.
1944         * source.c (forget_cached_source_info_for_objfile): Use
1945         compunit_filetabs.
1946         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1947         (ALL_FILETABS): Use compunit_filetabs.
1948         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1949         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1950
1951 2019-01-09  Tom Tromey  <tom@tromey.com>
1952
1953         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1954         (compunit_filetabs): New.
1955         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1956         compunit_filetabs.
1957         (info_sources_command, make_source_files_completion_list): Remove
1958         declaration.
1959         * symmisc.c (print_objfile_statistics, dump_objfile)
1960         (maintenance_print_symbols): Remove declaration.
1961         (maintenance_info_symtabs): Use compunit_filetabs.
1962         (maintenance_info_line_tables): Likewise.
1963         * source.c (select_source_symtab): Change local variable name.
1964         (forget_cached_source_info_for_objfile): Remove declaration.
1965         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1966         * objfiles.c (objfile_relocate1): Remove declaration.
1967         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1968         declaration.
1969         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1970         * coffread.c (coff_symtab_read): Remove declaration.
1971         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1972         compunit_filetabs.
1973
1974 2019-01-09  Tom Tromey  <tom@tromey.com>
1975
1976         * symtab.c (lookup_objfile_from_block)
1977         (find_pc_sect_compunit_symtab, search_symbols)
1978         (default_collect_symbol_completion_matches_break_on): Use
1979         objfile_compunits.
1980         * objfiles.h (ALL_COMPUNITS): Remove.
1981         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1982         * cp-support.c (add_symbol_overload_list_qualified): Use
1983         objfile_compunits.
1984         * ada-lang.c (ada_collect_symbol_completion_matches)
1985         (ada_add_global_exceptions): Use objfile_compunits.
1986
1987 2019-01-09  Tom Tromey  <tom@tromey.com>
1988
1989         * source.c (select_source_symtab)
1990         (forget_cached_source_info_for_objfile): Remove declaration.
1991         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1992         declaration.
1993         * maint.c (count_symtabs_and_blocks): Remove declaration.
1994         * cp-support.c (add_symbol_overload_list_qualified): Remove
1995         declaration.
1996         * coffread.c (coff_symtab_read): Remove declaration.
1997         * symtab.c (lookup_symbol_in_objfile_symtabs)
1998         (basic_lookup_transparent_type_1): Use objfile_compunits.
1999         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2000         (info_sources_command, search_symbols)
2001         (default_collect_symbol_completion_matches_break_on)
2002         (make_source_files_completion_list): Remove declaration.
2003         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2004         (ada_collect_symbol_completion_matches)
2005         (ada_add_global_exceptions): Remove declaration.
2006         * linespec.c (iterate_over_all_matching_symtabs): Use
2007         objfile_compunits.
2008         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2009         (class objfile_compunits): New.
2010         (ALL_COMPUNITS): Use objfile_compunits.
2011         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2012         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2013         objfile_compunits.
2014         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2015
2016 2019-01-09  Tom Tromey  <tom@tromey.com>
2017
2018         * symtab.c (search_symbols)
2019         (default_collect_symbol_completion_matches_break_on): Use
2020         objfile_msymbols.
2021         * ada-lang.c (ada_lookup_simple_minsym)
2022         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2023         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2024         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2025         objfile_msymbols.
2026         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2027         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2028         * objc-lang.c (find_methods): Use objfile_msymbols.
2029         (info_selectors_command, info_classes_command): Likewise.
2030         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2031         * objfiles.h (class objfile_msymbols): New.
2032         (ALL_OBJFILE_MSYMBOLS): Remove.
2033         (ALL_MSYMBOLS): Remove.
2034
2035 2019-01-09  Tom Tromey  <tom@tromey.com>
2036
2037         * common/next-iterator.h (next_adapter): Add Iterator template
2038         parameter.
2039         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2040         (class all_objfiles_safe): New.
2041         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2042         * objfiles.c (put_objfile_before): Update comment.
2043         (add_separate_debug_objfile): Likewise.
2044         (free_all_objfiles): Use all_objfiles_safe.
2045         (objfile_purge_solibs): Likewise.
2046
2047 2019-01-09  Tom Tromey  <tom@tromey.com>
2048
2049         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2050         (expand_symtab_containing_pc, lookup_static_symbol)
2051         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2052         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2053         all_objfiles.
2054         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2055         * breakpoint.c (create_overlay_event_breakpoint)
2056         (create_longjmp_master_breakpoint)
2057         (create_std_terminate_master_breakpoint)
2058         (create_exception_master_breakpoint): Use all_objfiles.
2059         * linux-thread-db.c (try_thread_db_load_from_pdir)
2060         (has_libpthread): Use all_objfiles.
2061         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2062         * linespec.c (iterate_over_all_matching_symtabs)
2063         (search_minsyms_for_name): Use all_objfiles.
2064         * maint.c (maintenance_info_sections): Use all_objfiles.
2065         * main.c (captured_main_1): Use all_objfiles.
2066         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2067         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2068         * guile/scm-pretty-print.c
2069         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2070         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2071         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2072         (maintenance_print_msymbols): Use all_objfiles.
2073         * source.c (select_source_symtab): Use all_objfiles.
2074         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2075         * symfile.c (remove_symbol_file_command)
2076         (expand_symtabs_matching, map_symbol_filenames): Use
2077         all_objfiles.
2078         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2079         all_objfiles.
2080         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2081         * objc-lang.c (find_methods): Use all_objfiles.
2082         * objfiles.c (have_partial_symbols, have_full_symbols)
2083         (have_minimal_symbols, qsort_cmp)
2084         (default_iterate_over_objfiles_in_search_order): Use
2085         all_objfiles.
2086         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2087         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2088         (maintenance_check_psymtabs): Use all_objfiles.
2089         (ALL_PSYMTABS): Remove.
2090         * compile/compile-object-run.c (do_module_cleanup): Use
2091         all_objfiles.
2092         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2093         * cp-support.c (add_symbol_overload_list_qualified): Use
2094         all_objfiles.
2095         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2096         Use all_objfiles.
2097         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2098         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2099         all_objfiles.
2100         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2101         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2102         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2103         Uses all_objfiles.
2104         * solib.c (solib_read_symbols): Use all_objfiles
2105
2106 2019-01-09  Tom Tromey  <tom@tromey.com>
2107
2108         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2109         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2110         all_objfiles.
2111         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2112         * symmisc.c (print_symbol_bcache_statistics)
2113         (print_objfile_statistics, maintenance_print_objfiles)
2114         (maintenance_info_symtabs, maintenance_check_symtabs)
2115         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2116         all_objfiles.
2117         * source.c (forget_cached_source_info): Use all_objfiles.
2118         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2119         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2120         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2121         * objfiles.c (update_section_map): Use all_objfiles.
2122         (shared_objfile_contains_address_p): Likewise.
2123         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2124         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2125
2126 2019-01-09  Tom Tromey  <tom@tromey.com>
2127
2128         * common/next-iterator.h: New file.
2129         * objfiles.h (class all_objfiles): New.
2130         (struct objfile_iterator): New.
2131
2132 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2133
2134         * NEWS: Move the description of the changed "frame", "select-frame",
2135          and "info frame" commands to the Changed commands section.
2136
2137 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2138
2139         * gdbtypes.c (check_stub_method_group): Remove handling of old
2140         mangling schemes.
2141         * linespec.c (find_methods): Likewise.
2142         * stabsread.c (read_member_functions): Likewise.
2143         * valops.c (search_struct_method): Likewise.
2144         (value_struct_elt_for_reference): Likewise.
2145         * NEWS: Mention this change.
2146
2147 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2148
2149         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2150         print_source_lines.
2151         * source.c (print_source_lines_base): Update line number check.
2152         (print_source_lines): New function.
2153         (source_lines_range::source_lines_range): New function.
2154         * source.h (class source_lines_range): New class.
2155         (print_source_lines): New declaration.
2156
2157 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2158
2159         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2160
2161 2019-01-08  Tom Tromey  <tom@tromey.com>
2162             Simon Marchi  <simon.marchi@ericsson.com>
2163
2164         PR gdb/24060
2165         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2166         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2167         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2168         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2169         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2170         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2171
2172 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2173
2174         * source.c (select_source_symtab): Move header comment to
2175         declaration in source.h.
2176         (forget_cached_source_info_for_objfile): Likewise.
2177         (forget_cached_source_info): Likewise.
2178         (identify_source_line): Likewise.
2179         * source.h (identify_source_line): Move declaration from symtab.h
2180         and add comment from source.c
2181         (print_source_lines): Likewise.
2182         (forget_cached_source_info_for_objfile): Likewise.
2183         (forget_cached_source_info): Likewise.
2184         (select_source_symtab): Likewise.
2185         (enum print_source_lines_flag): Move definition from symtab.h.
2186         * symtab.h (identify_source_line): Move declaration to source.h.
2187         (print_source_lines): Likewise.
2188         (forget_cached_source_info_for_objfile): Likewise.
2189         (forget_cached_source_info): Likewise.
2190         (select_source_symtab): Likewise.
2191         (enum print_source_lines_flag): Move definition to source.h.
2192         * tui/tui-hooks.c: Add 'source.h' include.
2193
2194 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2195
2196         * source.c (print_source_lines_base): Handle requests to print
2197         reverse line number sequences, and guard against empty lines
2198         string.
2199
2200 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2201
2202         * source.c (print_source_lines_base): Fix skip of '\r' if next
2203         character is '\n'.
2204
2205 2019-01-06  Tom Tromey  <tom@tromey.com>
2206
2207         * c-exp.y (struct c_parse_state) <macro_original_text,
2208         expansion_obstack>: New member.
2209         (macro_original_text, expansion_obstack): Remove globals.
2210         (scan_macro_expansion, scanning_macro_expansion)
2211         (finished_macro_expansion): Update.
2212         (scan_macro_cleanup): Remove.
2213         (yylex, c_parse): Update.
2214
2215 2019-01-06  Tom Tromey  <tom@tromey.com>
2216
2217         * c-exp.y (struct c_parse_state) <strings>: New member.
2218         (operator_stoken): Update.
2219
2220 2019-01-06  Tom Tromey  <tom@tromey.com>
2221
2222         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2223         (union type_stack_elt) <typelist_val>: Now a pointer to
2224         std::vector.
2225         (type_stack_cleanup): Don't declare.
2226         (push_typelist): Update.
2227         * parse.c (pop_typelist): Return a std::vector.
2228         (push_typelist): Take a std::vector.
2229         (follow_types): Update.  Do not free args.
2230         (type_stack_cleanup): Remove.
2231         * c-exp.y (struct c_parse_state): New.
2232         (cpstate): New global.
2233         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2234         (nonempty_typelist): Update.
2235         (func_mod): Create a new vector.
2236         (c_parse): Create a c_parse_state.
2237         (check_parameter_typelist): Do not delete params.
2238         (function_method): Update.  Do not delete type_list.
2239
2240 2019-01-06  Tom Tromey  <tom@tromey.com>
2241
2242         PR gdb/28155:
2243         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2244         check_typedef.
2245         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2246         (print_return_value): Likewise.
2247
2248 2019-01-05  Tom Tromey  <tom@tromey.com>
2249
2250         * contrib/cleanup_check.py: Remove.
2251         * contrib/gcc-with-excheck: Remove.
2252         * contrib/exsummary.py: Remove.
2253         * contrib/excheck.py: Remove.
2254
2255 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2256
2257         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2258         NULL. Initialize tpprev to NULL instead of assigning it
2259         to NULL on the next statement.
2260         * windows-nat.c (windows_delete_thread): Remove check for
2261         main_thread_id before printing thread exit notifications.
2262         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2263         Remove thread ID check against main_thread_id.
2264         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2265         windows_delete_thread.
2266         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2267
2268 2019-01-04  Tom Tromey  <tom@tromey.com>
2269
2270         * compile/compile.c (_initialize_compile): Use upper case for
2271         metasyntactic variables.
2272         * symmisc.c (_initialize_symmisc): Use upper case for
2273         metasyntactic variables.
2274         * psymtab.c (_initialize_psymtab): Use upper case for
2275         metasyntactic variables.
2276         * demangle.c (demangle_command): Use upper case for metasyntactic
2277         variables.
2278         (_initialize_demangler): Likewise.
2279         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2280         variables.
2281
2282 2019-01-03  Tom Tromey  <tom@tromey.com>
2283
2284         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2285
2286 2019-01-03  Tom Tromey  <tom@tromey.com>
2287
2288         * python/py-symtab.c (salpy_str): Update.
2289         (struct salpy_sal_object) <symtab>: Now a PyObject.
2290         (salpy_dealloc): Update.
2291         (del_objfile_sal): Use gdbpy_ref.
2292
2293 2019-01-03  Tom Tromey  <tom@tromey.com>
2294
2295         * python/py-type.c (convert_field): Use new_reference.  Return
2296         gdbpy_ref.
2297         (make_fielditem): Return gdbpy_ref.
2298         (typy_fields): Update.
2299         (typy_getitem): Update.
2300         (field_name): Return gdbpy_ref.  Use new_reference.
2301         (typy_iterator_iternext): Update.
2302
2303 2019-01-03  Tom Tromey  <tom@tromey.com>
2304
2305         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2306
2307 2019-01-03  Tom Tromey  <tom@tromey.com>
2308
2309         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2310         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2311         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2312         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2313         (pspy_set_type_printers): Likewise.
2314         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2315         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2316         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2317         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2318         (objfpy_set_type_printers): Likewise.
2319
2320 2019-01-03  Tom Tromey  <tom@tromey.com>
2321
2322         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2323         (gdbpy_print_stack): Use gdbpy_err_fetch.
2324         * python/python-internal.h (class gdbpy_err_fetch): New class.
2325         (class gdbpy_enter) <m_error_type, m_error_value,
2326         m_error_traceback>: Remove.
2327         <m_error>: New member.
2328         (gdbpy_exception_to_string): Don't declare.
2329         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2330         * python/py-value.c (convert_value_from_python): Use
2331         gdbpy_err_fetch.
2332         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2333         gdbpy_exception_to_string.
2334         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2335         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2336         gdbpy_err_fetch.
2337
2338 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2339
2340         * linux-nat.c (delete_lwp_cleanup): Delete.
2341         (struct lwp_deleter): New struct.
2342         (lwp_info_up): New typedef.
2343         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2344         lwp_info_up.
2345
2346 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2347
2348         * linux-fork.c (class scoped_switch_fork_info): New class.
2349         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2350
2351 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2352
2353         * valops.c (find_overload_match): Remove use of null_cleanup, and
2354         calls to do_cleanups.
2355
2356 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2357
2358         * compile/compile-cplus-types.c
2359         (compile_cplus_instance::decl_name): Handle changes to
2360         cp_func_name.
2361         * cp-support.c (cp_func_name): Update header comment, update
2362         return type.
2363         * cp-support.h (cp_func_name): Update return type in declaration.
2364         * valops.c (find_overload_match): Move temp_func local to top
2365         level of function and change its type.  Use temp_func to hold and
2366         delete temporary string obtained from cp_func_name.
2367
2368 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2369
2370         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2371         gdb::char_vector, remove cleanup, and update uses of `msg`.
2372
2373 2019-01-03  Jim Wilson  <jimw@sifive.com>
2374
2375         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2376
2377 2019-01-02  Tom Tromey  <tom@tromey.com>
2378
2379         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2380         (tdesc_parse_xml): Remove cleanups.
2381         * target-descriptions.h (make_cleanup_free_target_description):
2382         Don't declare.
2383         (target_desc_deleter): New struct.
2384         (target_desc_up): New typedef.
2385         * target-descriptions.c (target_desc_deleter::operator()): Rename
2386         from free_target_description.
2387         (make_cleanup_free_target_description): Remove.
2388
2389 2019-01-02  Tom Tromey  <tom@tromey.com>
2390
2391         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2392         constructor, destructor.
2393         (linespec_parser): Remove typedef.
2394         (~linespec_parser): Rename from linespec_parser_delete.
2395         (linespec_lex_to_end, linespec_complete_label)
2396         (linespec_complete): Update.
2397         (decode_line_full): Remove cleanups.
2398         (decode_line_1): Update.
2399
2400 2019-01-02  Tom Tromey  <tom@tromey.com>
2401
2402         * python/python-internal.h (inferior_to_inferior_object): Change
2403         return type.
2404         * python/py-exitedevent.c (create_exited_event_object): Update.
2405         * python/py-inferior.c (inferior_to_inferior_object): Return
2406         gdbpy_ref.
2407         (python_new_inferior, python_inferior_deleted)
2408         (thread_to_thread_object, delete_thread_object)
2409         (build_inferior_list, gdbpy_selected_inferior): Update.
2410         * python/py-infthread.c (create_thread_object): Update.  Also fail
2411         if inferior_to_inferior_object fails.
2412
2413 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2414
2415         * inferior.h (class inferior) <displaced_step_state>: New field.
2416         * infrun.h (struct displaced_step_state): Move here from
2417         infrun.c.  Initialize fields, add constructor.
2418         <inf>: Remove field.
2419         <reset>: New method.
2420         * infrun.c (struct displaced_step_inferior_state): Move to
2421         infrun.h.
2422         (displaced_step_inferior_states): Remove.
2423         (get_displaced_stepping_state): Adust.
2424         (displaced_step_in_progress_any_inferior): Adjust.
2425         (displaced_step_in_progress_thread): Adjust.
2426         (displaced_step_in_progress): Adjust.
2427         (add_displaced_stepping_state): Remove.
2428         (get_displaced_step_closure_by_addr): Adjust.
2429         (remove_displaced_stepping_state): Remove.
2430         (infrun_inferior_exit): Call displaced_step_state.reset.
2431         (use_displaced_stepping): Don't check for NULL.
2432         (displaced_step_prepare_throw): Call
2433         get_displaced_stepping_state.
2434         (displaced_step_fixup): Don't check for NULL.
2435         (prepare_for_detach): Don't check for NULL.
2436
2437 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2438
2439         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2440          in case of call that did not complete.
2441
2442 2019-01-02  Andrey Utkin  <autkin@undo.io>
2443
2444         * symfile.c (find_separate_debug_file): Fix search of debug files for
2445         remote debuggee.
2446
2447 2019-01-02  Tom Tromey  <tom@tromey.com>
2448
2449         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2450         indentation.
2451         * python/py-frame.c (frapy_older): Remove cast.
2452         (frapy_newer): Likewise.
2453         * python/py-breakpoint.c (local_setattro): Remove cast.
2454         * python/py-arch.c (archpy_name): Remove local variable.
2455         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2456
2457 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2458
2459         * unittests/basic_string_view/element_access/char/empty.cc:
2460         Fix year range in copyright header.
2461
2462 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2463
2464         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2465         Delete.
2466         <operator==>: Update with for removed field.
2467         <hash>: Likewise.
2468         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2469         <isa_features>: ...this.
2470         <abi_features>: New field.
2471         (riscv_isa_flen): Update comment.
2472         (riscv_abi_xlen): New declaration.
2473         (riscv_abi_flen): New declaration.
2474         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2475         isa_features.
2476         (riscv_abi_xlen): New function.
2477         (riscv_isa_flen): Update to get answer from isa_features.
2478         (riscv_abi_flen): New function.
2479         (riscv_has_fp_abi): Update to get answer from abi_features.
2480         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2481         xlen and flen.
2482         (riscv_call_info) <xlen, flen>: Update comment.
2483         (riscv_call_arg_struct): Remove invalid assertions
2484         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2485         is removed.
2486         (riscv_gdbarch_init): Gather isa features and abi features
2487         separately, ensure both match on the gdbarch when reusing an old
2488         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2489         a target with 64-bit float hardware.
2490
2491 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2492
2493         * source.c (search_command_helper): Stop reverse search
2494         when line 1 has been searched.
2495
2496 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2497
2498         * record-full.c (record_full_base_target::close): Rewrite
2499         record_full_core_buf_list free logic.
2500
2501 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2502
2503         * break-catch-syscall.c (print_one_catch_syscall): xfree
2504         the last text.
2505
2506 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2507
2508         * top.c (print_gdb_version): Update Copyright year in version
2509         message.
2510
2511 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2512
2513         Update copyright year range in all GDB files.
2514
2515 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2516
2517         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2518
2519 For older changes see ChangeLog-2018.
2520 \f
2521 Local Variables:
2522 mode: change-log
2523 left-margin: 8
2524 fill-column: 74
2525 version-control: never
2526 coding: utf-8
2527 End:
2528