gdb/ChangeLog

   1 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
   2
   3         PR gdb/24292
   4         * common/netstuff.c:
   5         * gdbserver/gdbreplay.c
   6         * gdbserver/remote-utils.c:
   7         * ser-tcp.c:
   8         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
   9         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
  10         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
  11         'getaddrinfo' and 'freeaddrinfo' were not available before
  12         Windows XP, and mingw.org's MinGW headers by default define
  13         _WIN32_WINNT to 0x500.
  14
  15 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
  16
  17         * NEWS: Note minimum Python version.
  18
  19 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
  20
  21         * version.in: Set GDB version number to 8.2.90.DATE-git.
  22
  23 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
  24
  25         GDB 8.2.90 released.
  26
  27 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
  28
  29         * version.in: Set GDB version number to 8.2.90.
  30
  31 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
  32
  33         * NEWS: Change "Changes since GDB 8.2" into "Changes in GDB 8.3".
  34
  35 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
  36
  37         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
  38         * version.in: Bump version to 8.2.90.DATE-git.
  39
  40 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
  41
  42         * aix-thread.c (ptid_cmp): Remove unused variable.
  43         (get_signaled_thread): Likewise.
  44         (store_regs_user_thread): Likewise.
  45         (store_regs_kernel_thread): Likewise.
  46         (fetch_regs_kernel_thread): Remove shadowed variable.
  47
  48 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
  49
  50         * features/riscv/32bit-cpu.xml: Add register numbers.
  51         * features/riscv/32bit-fpu.c: Regenerate.
  52         * features/riscv/32bit-fpu.xml: Add register numbers.
  53         * features/riscv/64bit-cpu.xml: Add register numbers.
  54         * features/riscv/64bit-fpu.c: Regenerate.
  55         * features/riscv/64bit-fpu.xml: Add register numbers.
  56
  57 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
  58
  59         * NEWS: Mention two argument form of gdb.Value constructor.
  60         * python/py-value.c (convert_buffer_and_type_to_value): New
  61         function.
  62         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
  63         Add support for handling an optional second argument.  Call
  64         convert_buffer_and_type_to_value as appropriate.
  65         * python/python-internal.h (Py_buffer_deleter): New struct.
  66         (Py_buffer_up): New typedef.
  67
  68 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
  69
  70         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
  71         instead of releasing ownership.
  72
  73 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
  74
  75         * dwarf2read.c (open_and_init_dwp_file): Call
  76         elf_numsections instead of bfd_count_sections to initialize
  77         dwp_file->num_sections.
  78
  79 2019-02-25  Tom Tromey  <tromey@adacore.com>
  80
  81         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
  82
  83 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
  84
  85         * gcore.in: Add '--readnever' option when invoking GDB.
  86
  87 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
  88
  89         * MAINTAINERS: Update my email address.
  90
  91 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
  92
  93         * build-id.c (build_id_to_debug_bfd_1): New function.
  94         (build_id_to_debug_bfd): Look for separate debug file in
  95         sysroot.
  96
  97 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
  98
  99         * gdbarch.sh: Update the copyright year range that is placed into
 100         generated files.
 101
 102 2019-02-22  Keith Seitz  <keiths@redhat.com>
 103
 104         PR symtab/23853
 105         * linespec.c (create_sals_line_offset): Search for the default
 106         symtab's filename instead of its fullname.
 107
 108 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 109
 110         * NEWS: Update style defaults.
 111
 112 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 113
 114         * main.c (captured_main_1): Disable styling in batch mode.
 115
 116 2019-02-20  Tom Tromey  <tom@tromey.com>
 117
 118         * symtab.c (symtab_symbol_info): Fix typos.
 119
 120 2019-02-20  Tom Tromey  <tromey@adacore.com>
 121
 122         * findcmd.c (_initialize_mem_search): Use upper case for
 123         metasyntactic variables.
 124
 125 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
 126
 127         * aarch64-tdep.c (aarch64_add_reggroups): New function.
 128         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
 129
 130 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
 131
 132         * top.h (source_file_name): Change to std::string.
 133         * top.c (source_file_name): Likewise.
 134         (command_line_input): Adjust.
 135         * cli/cli-script.c (script_from_file): Adjust.
 136
 137 2019-02-19  Tom Tromey  <tromey@adacore.com>
 138
 139         * ravenscar-thread.c
 140         (ravenscar_thread_target::update_thread_list): Don't call
 141         ada_build_task_list.
 142         * ada-lang.h (ada_build_task_list): Don't declare.
 143         * ada-tasks.c (struct ada_tasks_inferior_data)
 144         <task_list_valid_p>: Now bool.
 145         (read_known_tasks, ada_task_list_changed)
 146         (ada_tasks_invalidate_inferior_data): Update.
 147         (read_known_tasks_array): Return bool.
 148         (read_known_tasks_list): Likewise.
 149         (read_known_tasks): Return void.
 150         (ada_build_task_list): Now static.
 151
 152 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 153
 154         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
 155         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
 156
 157 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 158
 159         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
 160         variant for ada_tasks_pspace_data_handle and
 161         ada_tasks_inferior_data_handle.
 162         (ada_tasks_pspace_data_cleanup): New function.
 163         (ada_tasks_inferior_data_cleanup): New function.
 164
 165 2019-02-17  Tom Tromey  <tom@tromey.com>
 166
 167         * macrotab.h (macro_source_fullname): Return a std::string.
 168         * macrotab.c (macro_include, check_for_redefinition)
 169         (macro_undef, macro_lookup_definition, foreach_macro)
 170         (foreach_macro_in_scope): Update.
 171         (macro_source_fullname): Return a std::string.
 172         * macrocmd.c (show_pp_source_pos): Update.
 173
 174 2019-02-17  Tom Tromey  <tom@tromey.com>
 175
 176         * macrocmd.c (show_pp_source_pos): Style the file names.
 177
 178 2019-02-17  Tom Tromey  <tom@tromey.com>
 179
 180         PR tui/24197:
 181         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 182
 183 2019-02-17  Tom Tromey  <tom@tromey.com>
 184
 185         * ada-lang.c (user_select_syms): Use filtered printing.
 186         * utils.c (wrap_style): New global.
 187         (desired_style): Remove.
 188         (emit_style_escape): Add stream parameter.
 189         (set_output_style, reset_terminal_style, prompt_for_continue):
 190         Update.
 191         (flush_wrap_buffer): Only flush gdb_stdout.
 192         (wrap_here): Set wrap_style.
 193         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 194         treat escape sequences as a character.  Change when wrap buffer is
 195         flushed.
 196         (fputs_styled): Do not set the output style when the default is
 197         requested.
 198         * ui-style.h (struct ui_file_style) <is_default>: New method.
 199         * source.c (print_source_lines_base): Emit escape sequences in one
 200         piece.
 201
 202 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 203
 204         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 205         integers and enumeration types.
 206
 207 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 208
 209         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 210         instead of lookup_symbol_in_language
 211         (do_exact_match): New function.
 212         (ada_get_symbol_name_matcher): Return do_exact_match when
 213         doing a verbatim match.
 214
 215 2019-02-15  Tom Tromey  <tromey@adacore.com>
 216
 217         * ravenscar-thread.c (ravenscar_thread_target::resume)
 218         (ravenscar_thread_target::wait): Special case wildcard requests.
 219
 220 2019-02-15  Tom Tromey  <tromey@adacore.com>
 221
 222         * ravenscar-thread.c (base_ptid): Remove.
 223         (struct ravenscar_thread_target) <close>: New method.
 224         <m_base_ptid>: New member.
 225         <update_inferior_ptid, active_task, task_is_currently_active,
 226         runtime_initialized>: Declare methods.
 227         <ravenscar_thread_target>: Add constructor.
 228         (ravenscar_thread_target::task_is_currently_active)
 229         (ravenscar_thread_target::update_inferior_ptid)
 230         (ravenscar_runtime_initialized): Rename.  Now methods.
 231         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 232         (ravenscar_thread_target::update_thread_list): Update.
 233         (ravenscar_thread_target::active_task): Now method.
 234         (ravenscar_thread_target::store_registers)
 235         (ravenscar_thread_target::prepare_to_store)
 236         (ravenscar_thread_target::prepare_to_store)
 237         (ravenscar_thread_target::mourn_inferior): Update.
 238         (ravenscar_inferior_created): Use "new" to create target.
 239         (ravenscar_thread_target::get_ada_task_ptid): Update.
 240         (_initialize_ravenscar): Don't initialize base_ptid.
 241         (ravenscar_ops): Remove global.
 242
 243 2019-02-15  Tom Tromey  <tromey@adacore.com>
 244
 245         * target.h (push_target): Declare new overload.
 246         * target.c (push_target): New overload, taking an rvalue reference.
 247         * remote.c (remote_target::open_1): Use push_target overload.
 248         * corelow.c (core_target_open): Use push_target overload.
 249
 250 2019-02-15  Tom Tromey  <tromey@adacore.com>
 251
 252         * ravenscar-thread.c (is_ravenscar_task)
 253         (ravenscar_task_is_currently_active): Return bool.
 254         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 255         (_initialize_ravenscar): Remove "(void)".
 256         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 257         Return bool.
 258
 259 2019-02-15  Tom Tromey  <tromey@adacore.com>
 260
 261         * ravenscar-thread.c (ravenscar_runtime_initializer)
 262         (has_ravenscar_runtime, get_running_thread_id)
 263         (ravenscar_thread_target::resume): Fix indentation.
 264
 265 2019-02-15  Tom Tromey  <tromey@adacore.com>
 266
 267         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 268         from ravenscar_arch_ops.
 269         (sparc_ravenscar_ops::fetch_registers)
 270         (sparc_ravenscar_ops::store_registers): Now methods.
 271         (sparc_ravenscar_prepare_to_store): Remove.
 272         (sparc_ravenscar_ops): Redefine.
 273         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 274         methods and destructor.  Remove members.
 275         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 276         (ravenscar_thread_target::store_registers)
 277         (ravenscar_thread_target::prepare_to_store): Update.
 278         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 279         Remove.
 280         (struct ppc_ravenscar_powerpc_ops): Derive from
 281         ravenscar_arch_ops.
 282         (ppc_ravenscar_powerpc_ops::fetch_registers)
 283         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 284         (ppc_ravenscar_powerpc_ops): Redefine.
 285         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 286         (ppc_ravenscar_e500_ops::fetch_registers)
 287         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 288         (ppc_ravenscar_e500_ops): Redefine.
 289         * aarch64-ravenscar-thread.c
 290         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 291         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 292         (aarch64_ravenscar_fetch_registers)
 293         (aarch64_ravenscar_store_registers): Now methods.
 294         (aarch64_ravenscar_ops): Redefine.
 295
 296 2019-02-15  Tom Tromey  <tromey@adacore.com>
 297
 298         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 299         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 300         (ravenscar_thread_target::stopped_by_watchpoint)
 301         (ravenscar_thread_target::stopped_data_address)
 302         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 303
 304 2019-02-15  Tom Tromey  <tromey@adacore.com>
 305
 306         * ravenscar-thread.c: Fix some typos.
 307
 308 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 309             Tom Tromey  <tromey@adacore.com>
 310
 311         * ada-lang.c (ada_exception_sal): Change addr_string to a
 312         std::string.
 313         (create_ada_exception_catchpoint): Update.
 314
 315 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 316             Tom Tromey  <tromey@adacore.com>
 317
 318         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 319         (bp_location_ops): Remove.
 320         (base_breakpoint_allocate_location): Update.
 321         (free_bp_location): Update.
 322         * ada-lang.c (class ada_catchpoint_location)
 323         <ada_catchpoint_location>: Remove ops parameter.
 324         (ada_catchpoint_location_dtor): Remove.
 325         (ada_catchpoint_location_ops): Remove.
 326         (allocate_location_exception): Update.
 327         * breakpoint.h (struct bp_location_ops): Remove.
 328         (class bp_location) <bp_location>: Remove bp_location_ops
 329         parameter.
 330         <~bp_location>: Add destructor.
 331         <ops>: Remove.
 332
 333 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 334             Pedro Alves  <palves@redhat.com>
 335
 336         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 337         'PATH_MAX'.
 338
 339 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 340             Samuel Thibault  <samuel.thibault@gnu.org>
 341             Thomas Schwinge  <thomas@codesourcery.com>
 342
 343         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 344         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 345
 346 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 347
 348         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 349         (check_empty): Use "const char *".
 350
 351         * gnu-nat.c (gnu_nat_target::detach): Instead of
 352         'detach_inferior (pid)' call
 353         'detach_inferior (find_inferior_pid (pid))'.
 354
 355         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 356         'nat/fork-inferior.o'.
 357         * gnu-nat.c: #include "nat/fork-inferior.h".
 358
 359         * gnu-nat.c (gnu_nat_target::detach): Instead of
 360         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 361         * gnu-nat.h: #include "inf-child.h".
 362         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 363         'i386_gnu_nat_target::fetch_registers'.
 364         (gnu_store_registers): Rename/move to
 365         'i386_gnu_nat_target::store_registers'.
 366
 367         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 368         * gnu-nat.h (mach_thread_info): New function.
 369         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 370
 371         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 372
 373 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 374
 375         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 376
 377 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 378
 379         * windows-nat.c (windows_add_thread): Add new parameter
 380         "main_thread_p" with default value set to false.  Update
 381         function documentation as well as all callers.
 382         (windows_delete_thread): Likewise.
 383         (fake_create_process): Update call to windows_add_thread.
 384         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 385         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 386         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 387         call to windows_delete_thread.
 388
 389 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 390
 391         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 392
 393 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 394
 395         * symfile.c (find_separate_debug_file): Use canonical path of
 396         sysroot with child_path instead of gdb_sysroot if it is valid.
 397
 398 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 399
 400         * symfile.c (find_separate_debug_file): Use child_path to
 401         determine if an object file is under a sysroot.
 402
 403 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 404
 405         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 406         unittests/child-path-selftests.c.
 407         * common/pathstuff.c (child_path): New function.
 408         * common/pathstuff.h (child_path): New prototype.
 409         * unittests/child-path-selftests.c: New file.
 410
 411 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 412
 413         * symfile.c (find_separate_debug_file): Look for separate debug
 414         files in debug directories under the sysroot.
 415
 416 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 417
 418         * symtab.h (struct minimal_symbol data_p): New const method.
 419         (struct minimal_symbol text_p): Likewise.
 420         * symtab.c (output_source_filename): Use file name style
 421         to print file name.
 422         (print_symbol_info): Likewise.
 423         (print_msymbol_info): Use address style to print addresses.
 424         Use function name style to print executable text symbols.
 425         (expand_symtab_containing_pc): Use data_p.
 426         (find_pc_sect_compunit_symtab): Likewise.
 427
 428 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 429
 430         * breakpoint.c (describe_other_breakpoints): Use address style
 431         to print addresses.
 432         (say_where): Likewise.
 433
 434 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 435
 436         * ada-typeprint.c (print_func_type): Print function name
 437         style to print function name.
 438         * c-typeprint.c (c_print_type_1): Likewise.
 439
 440 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 441
 442         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 443         for execve.
 444
 445 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 446
 447         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 448         type_stack.
 449
 450 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 451
 452         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 453         TYPE_CODE_REF types.
 454
 455 2019-02-08  Jim Wilson  <jimw@sifive.com>
 456
 457         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 458         (riscv_linux_fregset): New.
 459         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 460
 461 2019-02-07  Tom Tromey  <tom@tromey.com>
 462
 463         * thread.c (thread_cancel_execution_command): Update.
 464         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 465         methods.
 466         (struct thread_fsm_ops): Remove.
 467         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 468         (thread_fsm_should_stop, thread_fsm_return_value)
 469         (thread_fsm_set_finished, thread_fsm_finished_p)
 470         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 471         Don't declare.
 472         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 473         * infrun.c (clear_proceed_status_thread)
 474         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 475         (print_stop_event): Update.
 476         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 477         Add constructor.
 478         (step_command_fsm_ops): Remove.
 479         (new_step_command_fsm): Remove.
 480         (step_1): Update.
 481         (step_command_fsm::should_stop): Rename from
 482         step_command_fsm_should_stop.
 483         (step_command_fsm::clean_up): Rename from
 484         step_command_fsm_clean_up.
 485         (step_command_fsm::do_async_reply_reason): Rename from
 486         step_command_fsm_async_reply_reason.
 487         (struct until_next_fsm): Inherit from thread_fsm.  Add
 488         constructor.
 489         (until_next_fsm_ops): Remove.
 490         (new_until_next_fsm): Remove.
 491         (until_next_fsm::should_stop): Rename from
 492         until_next_fsm_should_stop.
 493         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 494         (until_next_fsm::do_async_reply_reason): Rename from
 495         until_next_fsm_async_reply_reason.
 496         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 497         constructor.  Change type of breakpoint.
 498         (finish_command_fsm_ops): Remove.
 499         (new_finish_command_fsm): Remove.
 500         (finish_command_fsm::should_stop): Rename from
 501         finish_command_fsm_should_stop.
 502         (finish_command_fsm::clean_up): Rename from
 503         finish_command_fsm_clean_up.
 504         (finish_command_fsm::return_value): Rename from
 505         finish_command_fsm_return_value.
 506         (finish_command_fsm::do_async_reply_reason): Rename from
 507         finish_command_fsm_async_reply_reason.
 508         (finish_command): Update.
 509         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 510         Add constructor.
 511         (call_thread_fsm_ops): Remove.
 512         (call_thread_fsm::call_thread_fsm): Rename from
 513         new_call_thread_fsm.
 514         (call_thread_fsm::should_stop): Rename from
 515         call_thread_fsm_should_stop.
 516         (call_thread_fsm::should_notify_stop): Rename from
 517         call_thread_fsm_should_notify_stop.
 518         (run_inferior_call, call_function_by_hand_dummy): Update.
 519         * cli/cli-interp.c (should_print_stop_to_console): Update.
 520         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 521         Add constructor.  Change type of location_breakpoint,
 522         caller_breakpoint.
 523         (until_break_fsm_ops): Remove.
 524         (new_until_break_fsm): Remove.
 525         (until_break_fsm::should_stop): Rename from
 526         until_break_fsm_should_stop.
 527         (until_break_fsm::clean_up): Rename from
 528         until_break_fsm_clean_up.
 529         (until_break_fsm::do_async_reply_reason): Rename from
 530         until_break_fsm_async_reply_reason.
 531         (until_break_command): Update.
 532         * thread-fsm.c: Remove.
 533         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 534
 535 2019-02-07  Tom Tromey  <tom@tromey.com>
 536
 537         * yy-remap.h: Add include guard.
 538         * xtensa-tdep.h: Add include guard.
 539         * xcoffread.h: Rename include guard.
 540         * varobj-iter.h: Add include guard.
 541         * tui/tui.h: Rename include guard.
 542         * tui/tui-winsource.h: Rename include guard.
 543         * tui/tui-wingeneral.h: Rename include guard.
 544         * tui/tui-windata.h: Rename include guard.
 545         * tui/tui-win.h: Rename include guard.
 546         * tui/tui-stack.h: Rename include guard.
 547         * tui/tui-source.h: Rename include guard.
 548         * tui/tui-regs.h: Rename include guard.
 549         * tui/tui-out.h: Rename include guard.
 550         * tui/tui-layout.h: Rename include guard.
 551         * tui/tui-io.h: Rename include guard.
 552         * tui/tui-hooks.h: Rename include guard.
 553         * tui/tui-file.h: Rename include guard.
 554         * tui/tui-disasm.h: Rename include guard.
 555         * tui/tui-data.h: Rename include guard.
 556         * tui/tui-command.h: Rename include guard.
 557         * tic6x-tdep.h: Add include guard.
 558         * target/waitstatus.h: Rename include guard.
 559         * target/wait.h: Rename include guard.
 560         * target/target.h: Rename include guard.
 561         * target/resume.h: Rename include guard.
 562         * target-float.h: Rename include guard.
 563         * stabsread.h: Add include guard.
 564         * rs6000-tdep.h: Add include guard.
 565         * riscv-fbsd-tdep.h: Add include guard.
 566         * regformats/regdef.h: Rename include guard.
 567         * record.h: Rename include guard.
 568         * python/python.h: Rename include guard.
 569         * python/python-internal.h: Rename include guard.
 570         * python/py-stopevent.h: Rename include guard.
 571         * python/py-ref.h: Rename include guard.
 572         * python/py-record.h: Rename include guard.
 573         * python/py-record-full.h: Rename include guard.
 574         * python/py-record-btrace.h: Rename include guard.
 575         * python/py-instruction.h: Rename include guard.
 576         * python/py-events.h: Rename include guard.
 577         * python/py-event.h: Rename include guard.
 578         * procfs.h: Add include guard.
 579         * proc-utils.h: Add include guard.
 580         * p-lang.h: Add include guard.
 581         * or1k-tdep.h: Rename include guard.
 582         * observable.h: Rename include guard.
 583         * nto-tdep.h: Rename include guard.
 584         * nat/x86-linux.h: Rename include guard.
 585         * nat/x86-linux-dregs.h: Rename include guard.
 586         * nat/x86-gcc-cpuid.h: Add include guard.
 587         * nat/x86-dregs.h: Rename include guard.
 588         * nat/x86-cpuid.h: Rename include guard.
 589         * nat/ppc-linux.h: Rename include guard.
 590         * nat/mips-linux-watch.h: Rename include guard.
 591         * nat/linux-waitpid.h: Rename include guard.
 592         * nat/linux-ptrace.h: Rename include guard.
 593         * nat/linux-procfs.h: Rename include guard.
 594         * nat/linux-osdata.h: Rename include guard.
 595         * nat/linux-nat.h: Rename include guard.
 596         * nat/linux-namespaces.h: Rename include guard.
 597         * nat/linux-btrace.h: Rename include guard.
 598         * nat/glibc_thread_db.h: Rename include guard.
 599         * nat/gdb_thread_db.h: Rename include guard.
 600         * nat/gdb_ptrace.h: Rename include guard.
 601         * nat/fork-inferior.h: Rename include guard.
 602         * nat/amd64-linux-siginfo.h: Rename include guard.
 603         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 604         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 605         * nat/aarch64-linux.h: Rename include guard.
 606         * nat/aarch64-linux-hw-point.h: Rename include guard.
 607         * mn10300-tdep.h: Add include guard.
 608         * mips-linux-tdep.h: Add include guard.
 609         * mi/mi-parse.h: Rename include guard.
 610         * mi/mi-out.h: Rename include guard.
 611         * mi/mi-main.h: Rename include guard.
 612         * mi/mi-interp.h: Rename include guard.
 613         * mi/mi-getopt.h: Rename include guard.
 614         * mi/mi-console.h: Rename include guard.
 615         * mi/mi-common.h: Rename include guard.
 616         * mi/mi-cmds.h: Rename include guard.
 617         * mi/mi-cmd-break.h: Rename include guard.
 618         * m2-lang.h: Add include guard.
 619         * location.h: Rename include guard.
 620         * linux-record.h: Rename include guard.
 621         * linux-nat.h: Add include guard.
 622         * linux-fork.h: Add include guard.
 623         * i386-darwin-tdep.h: Rename include guard.
 624         * hppa-linux-offsets.h: Add include guard.
 625         * guile/guile.h: Rename include guard.
 626         * guile/guile-internal.h: Rename include guard.
 627         * gnu-nat.h: Rename include guard.
 628         * gdb-stabs.h: Rename include guard.
 629         * frv-tdep.h: Add include guard.
 630         * f-lang.h: Add include guard.
 631         * event-loop.h: Add include guard.
 632         * darwin-nat.h: Rename include guard.
 633         * cp-abi.h: Rename include guard.
 634         * config/sparc/nm-sol2.h: Rename include guard.
 635         * config/nm-nto.h: Rename include guard.
 636         * config/nm-linux.h: Add include guard.
 637         * config/i386/nm-i386gnu.h: Rename include guard.
 638         * config/djgpp/nl_types.h: Rename include guard.
 639         * config/djgpp/langinfo.h: Rename include guard.
 640         * compile/gcc-cp-plugin.h: Add include guard.
 641         * compile/gcc-c-plugin.h: Add include guard.
 642         * compile/compile.h: Rename include guard.
 643         * compile/compile-object-run.h: Rename include guard.
 644         * compile/compile-object-load.h: Rename include guard.
 645         * compile/compile-internal.h: Rename include guard.
 646         * compile/compile-cplus.h: Rename include guard.
 647         * compile/compile-c.h: Rename include guard.
 648         * common/xml-utils.h: Rename include guard.
 649         * common/x86-xstate.h: Rename include guard.
 650         * common/version.h: Rename include guard.
 651         * common/vec.h: Rename include guard.
 652         * common/tdesc.h: Rename include guard.
 653         * common/selftest.h: Rename include guard.
 654         * common/scoped_restore.h: Rename include guard.
 655         * common/scoped_mmap.h: Rename include guard.
 656         * common/scoped_fd.h: Rename include guard.
 657         * common/safe-iterator.h: Rename include guard.
 658         * common/run-time-clock.h: Rename include guard.
 659         * common/refcounted-object.h: Rename include guard.
 660         * common/queue.h: Rename include guard.
 661         * common/ptid.h: Rename include guard.
 662         * common/print-utils.h: Rename include guard.
 663         * common/preprocessor.h: Rename include guard.
 664         * common/pathstuff.h: Rename include guard.
 665         * common/observable.h: Rename include guard.
 666         * common/netstuff.h: Rename include guard.
 667         * common/job-control.h: Rename include guard.
 668         * common/host-defs.h: Rename include guard.
 669         * common/gdb_wait.h: Rename include guard.
 670         * common/gdb_vecs.h: Rename include guard.
 671         * common/gdb_unlinker.h: Rename include guard.
 672         * common/gdb_unique_ptr.h: Rename include guard.
 673         * common/gdb_tilde_expand.h: Rename include guard.
 674         * common/gdb_sys_time.h: Rename include guard.
 675         * common/gdb_string_view.h: Rename include guard.
 676         * common/gdb_splay_tree.h: Rename include guard.
 677         * common/gdb_setjmp.h: Rename include guard.
 678         * common/gdb_ref_ptr.h: Rename include guard.
 679         * common/gdb_optional.h: Rename include guard.
 680         * common/gdb_locale.h: Rename include guard.
 681         * common/gdb_assert.h: Rename include guard.
 682         * common/filtered-iterator.h: Rename include guard.
 683         * common/filestuff.h: Rename include guard.
 684         * common/fileio.h: Rename include guard.
 685         * common/environ.h: Rename include guard.
 686         * common/common-utils.h: Rename include guard.
 687         * common/common-types.h: Rename include guard.
 688         * common/common-regcache.h: Rename include guard.
 689         * common/common-inferior.h: Rename include guard.
 690         * common/common-gdbthread.h: Rename include guard.
 691         * common/common-exceptions.h: Rename include guard.
 692         * common/common-defs.h: Rename include guard.
 693         * common/common-debug.h: Rename include guard.
 694         * common/cleanups.h: Rename include guard.
 695         * common/buffer.h: Rename include guard.
 696         * common/btrace-common.h: Rename include guard.
 697         * common/break-common.h: Rename include guard.
 698         * cli/cli-utils.h: Rename include guard.
 699         * cli/cli-style.h: Rename include guard.
 700         * cli/cli-setshow.h: Rename include guard.
 701         * cli/cli-script.h: Rename include guard.
 702         * cli/cli-interp.h: Rename include guard.
 703         * cli/cli-decode.h: Rename include guard.
 704         * cli/cli-cmds.h: Rename include guard.
 705         * charset-list.h: Add include guard.
 706         * buildsym-legacy.h: Rename include guard.
 707         * bfin-tdep.h: Add include guard.
 708         * ax.h: Rename include guard.
 709         * arm-linux-tdep.h: Add include guard.
 710         * arm-fbsd-tdep.h: Add include guard.
 711         * arch/xtensa.h: Rename include guard.
 712         * arch/tic6x.h: Add include guard.
 713         * arch/i386.h: Add include guard.
 714         * arch/arm.h: Rename include guard.
 715         * arch/arm-linux.h: Rename include guard.
 716         * arch/arm-get-next-pcs.h: Rename include guard.
 717         * arch/amd64.h: Add include guard.
 718         * arch/aarch64-insn.h: Rename include guard.
 719         * arch-utils.h: Rename include guard.
 720         * annotate.h: Add include guard.
 721         * amd64-darwin-tdep.h: Rename include guard.
 722         * aarch64-linux-tdep.h: Add include guard.
 723         * aarch64-fbsd-tdep.h: Add include guard.
 724         * aarch32-linux-nat.h: Add include guard.
 725
 726 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 727
 728         * macrotab.c (macro_define_internal): New function that
 729         factorizes macro_define_object_internal and macro_define_function
 730         code.
 731         (macro_define_object_internal): Use macro_define_internal.
 732         (macro_define_function): Likewise.
 733
 734 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 735
 736         * macrocmd.c (extract_identifier): Return
 737         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 738         callers.
 739
 740 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 741
 742         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 743
 744 2019-02-05  Tom Tromey  <tom@tromey.com>
 745
 746         * target.c (target_stack::unpush): Move assertion earlier.
 747
 748 2019-01-30  Tom Tromey  <tom@tromey.com>
 749
 750         PR python/23615:
 751         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 752         (gdbpy_parse_and_eval): Likewise.
 753         * python/python-internal.h (gdbpy_allow_threads): New class.
 754
 755 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 756
 757         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 758         (aarch64_fbsd_fpregmap): Move earlier.
 759         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 760         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 761         instead of individual calls to trad_frame_set_reg_addr.
 762         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 763         earlier.
 764         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 765         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 766         instead of individual calls to trad_frame_set_reg_addr.
 767
 768 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 769
 770         * CONTRIBUTE: Replace contribution list with wiki link.
 771
 772 2019-01-25  Tom Tromey  <tom@tromey.com>
 773
 774         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 775
 776 2019-01-25  Tom Tromey  <tom@tromey.com>
 777
 778         * xtensa-linux-nat.c: Fix common/ includes.
 779         * xml-support.h: Fix common/ includes.
 780         * xml-support.c: Fix common/ includes.
 781         * x86-linux-nat.c: Fix common/ includes.
 782         * windows-nat.c: Fix common/ includes.
 783         * varobj.h: Fix common/ includes.
 784         * varobj.c: Fix common/ includes.
 785         * value.c: Fix common/ includes.
 786         * valops.c: Fix common/ includes.
 787         * utils.c: Fix common/ includes.
 788         * unittests/xml-utils-selftests.c: Fix common/ includes.
 789         * unittests/utils-selftests.c: Fix common/ includes.
 790         * unittests/unpack-selftests.c: Fix common/ includes.
 791         * unittests/tracepoint-selftests.c: Fix common/ includes.
 792         * unittests/style-selftests.c: Fix common/ includes.
 793         * unittests/string_view-selftests.c: Fix common/ includes.
 794         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 795         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 796         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 797         * unittests/rsp-low-selftests.c: Fix common/ includes.
 798         * unittests/parse-connection-spec-selftests.c: Fix common/
 799         includes.
 800         * unittests/optional-selftests.c: Fix common/ includes.
 801         * unittests/offset-type-selftests.c: Fix common/ includes.
 802         * unittests/observable-selftests.c: Fix common/ includes.
 803         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 804         * unittests/memrange-selftests.c: Fix common/ includes.
 805         * unittests/memory-map-selftests.c: Fix common/ includes.
 806         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 807         * unittests/function-view-selftests.c: Fix common/ includes.
 808         * unittests/environ-selftests.c: Fix common/ includes.
 809         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 810         * unittests/common-utils-selftests.c: Fix common/ includes.
 811         * unittests/cli-utils-selftests.c: Fix common/ includes.
 812         * unittests/array-view-selftests.c: Fix common/ includes.
 813         * ui-file.c: Fix common/ includes.
 814         * tui/tui-io.c: Fix common/ includes.
 815         * tracepoint.h: Fix common/ includes.
 816         * tracepoint.c: Fix common/ includes.
 817         * tracefile-tfile.c: Fix common/ includes.
 818         * top.h: Fix common/ includes.
 819         * top.c: Fix common/ includes.
 820         * thread.c: Fix common/ includes.
 821         * target/waitstatus.h: Fix common/ includes.
 822         * target/waitstatus.c: Fix common/ includes.
 823         * target.h: Fix common/ includes.
 824         * target.c: Fix common/ includes.
 825         * target-memory.c: Fix common/ includes.
 826         * target-descriptions.c: Fix common/ includes.
 827         * symtab.h: Fix common/ includes.
 828         * symfile.c: Fix common/ includes.
 829         * stap-probe.c: Fix common/ includes.
 830         * spu-linux-nat.c: Fix common/ includes.
 831         * sparc-nat.c: Fix common/ includes.
 832         * source.c: Fix common/ includes.
 833         * solib.c: Fix common/ includes.
 834         * solib-target.c: Fix common/ includes.
 835         * ser-unix.c: Fix common/ includes.
 836         * ser-tcp.c: Fix common/ includes.
 837         * ser-pipe.c: Fix common/ includes.
 838         * ser-base.c: Fix common/ includes.
 839         * selftest-arch.c: Fix common/ includes.
 840         * s12z-tdep.c: Fix common/ includes.
 841         * rust-exp.y: Fix common/ includes.
 842         * rs6000-aix-tdep.c: Fix common/ includes.
 843         * riscv-tdep.c: Fix common/ includes.
 844         * remote.c: Fix common/ includes.
 845         * remote-notif.h: Fix common/ includes.
 846         * remote-fileio.h: Fix common/ includes.
 847         * remote-fileio.c: Fix common/ includes.
 848         * regcache.h: Fix common/ includes.
 849         * regcache.c: Fix common/ includes.
 850         * record-btrace.c: Fix common/ includes.
 851         * python/python.c: Fix common/ includes.
 852         * python/py-type.c: Fix common/ includes.
 853         * python/py-inferior.c: Fix common/ includes.
 854         * progspace.h: Fix common/ includes.
 855         * producer.c: Fix common/ includes.
 856         * procfs.c: Fix common/ includes.
 857         * proc-api.c: Fix common/ includes.
 858         * printcmd.c: Fix common/ includes.
 859         * ppc-linux-nat.c: Fix common/ includes.
 860         * parser-defs.h: Fix common/ includes.
 861         * osdata.c: Fix common/ includes.
 862         * obsd-nat.c: Fix common/ includes.
 863         * nat/x86-linux.c: Fix common/ includes.
 864         * nat/x86-linux-dregs.c: Fix common/ includes.
 865         * nat/x86-dregs.h: Fix common/ includes.
 866         * nat/x86-dregs.c: Fix common/ includes.
 867         * nat/ppc-linux.c: Fix common/ includes.
 868         * nat/mips-linux-watch.h: Fix common/ includes.
 869         * nat/mips-linux-watch.c: Fix common/ includes.
 870         * nat/linux-waitpid.c: Fix common/ includes.
 871         * nat/linux-ptrace.h: Fix common/ includes.
 872         * nat/linux-ptrace.c: Fix common/ includes.
 873         * nat/linux-procfs.c: Fix common/ includes.
 874         * nat/linux-personality.c: Fix common/ includes.
 875         * nat/linux-osdata.c: Fix common/ includes.
 876         * nat/linux-namespaces.c: Fix common/ includes.
 877         * nat/linux-btrace.h: Fix common/ includes.
 878         * nat/linux-btrace.c: Fix common/ includes.
 879         * nat/fork-inferior.c: Fix common/ includes.
 880         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 881         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 882         * nat/aarch64-linux.c: Fix common/ includes.
 883         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 884         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 885         * namespace.h: Fix common/ includes.
 886         * mips-linux-tdep.c: Fix common/ includes.
 887         * minsyms.c: Fix common/ includes.
 888         * mi/mi-parse.h: Fix common/ includes.
 889         * mi/mi-main.c: Fix common/ includes.
 890         * mi/mi-cmd-env.c: Fix common/ includes.
 891         * memrange.h: Fix common/ includes.
 892         * memattr.c: Fix common/ includes.
 893         * maint.h: Fix common/ includes.
 894         * maint.c: Fix common/ includes.
 895         * main.c: Fix common/ includes.
 896         * machoread.c: Fix common/ includes.
 897         * location.c: Fix common/ includes.
 898         * linux-thread-db.c: Fix common/ includes.
 899         * linux-nat.c: Fix common/ includes.
 900         * linux-fork.c: Fix common/ includes.
 901         * inline-frame.c: Fix common/ includes.
 902         * infrun.c: Fix common/ includes.
 903         * inflow.c: Fix common/ includes.
 904         * inferior.h: Fix common/ includes.
 905         * inferior.c: Fix common/ includes.
 906         * infcmd.c: Fix common/ includes.
 907         * inf-ptrace.c: Fix common/ includes.
 908         * inf-child.c: Fix common/ includes.
 909         * ia64-linux-nat.c: Fix common/ includes.
 910         * i387-tdep.c: Fix common/ includes.
 911         * i386-tdep.c: Fix common/ includes.
 912         * i386-linux-tdep.c: Fix common/ includes.
 913         * i386-linux-nat.c: Fix common/ includes.
 914         * i386-go32-tdep.c: Fix common/ includes.
 915         * i386-fbsd-tdep.c: Fix common/ includes.
 916         * i386-fbsd-nat.c: Fix common/ includes.
 917         * guile/scm-type.c: Fix common/ includes.
 918         * guile/guile.c: Fix common/ includes.
 919         * go32-nat.c: Fix common/ includes.
 920         * gnu-nat.c: Fix common/ includes.
 921         * gdbthread.h: Fix common/ includes.
 922         * gdbarch-selftests.c: Fix common/ includes.
 923         * gdb_usleep.c: Fix common/ includes.
 924         * gdb_select.h: Fix common/ includes.
 925         * gdb_bfd.c: Fix common/ includes.
 926         * gcore.c: Fix common/ includes.
 927         * fork-child.c: Fix common/ includes.
 928         * findvar.c: Fix common/ includes.
 929         * fbsd-nat.c: Fix common/ includes.
 930         * event-top.c: Fix common/ includes.
 931         * event-loop.c: Fix common/ includes.
 932         * dwarf2read.c: Fix common/ includes.
 933         * dwarf2loc.c: Fix common/ includes.
 934         * dwarf2-frame.c: Fix common/ includes.
 935         * dwarf-index-cache.c: Fix common/ includes.
 936         * dtrace-probe.c: Fix common/ includes.
 937         * disasm-selftests.c: Fix common/ includes.
 938         * defs.h: Fix common/ includes.
 939         * csky-tdep.c: Fix common/ includes.
 940         * cp-valprint.c: Fix common/ includes.
 941         * cp-support.h: Fix common/ includes.
 942         * cp-support.c: Fix common/ includes.
 943         * corelow.c: Fix common/ includes.
 944         * completer.h: Fix common/ includes.
 945         * completer.c: Fix common/ includes.
 946         * compile/compile.c: Fix common/ includes.
 947         * compile/compile-loc2c.c: Fix common/ includes.
 948         * compile/compile-cplus-types.c: Fix common/ includes.
 949         * compile/compile-cplus-symbols.c: Fix common/ includes.
 950         * command.h: Fix common/ includes.
 951         * cli/cli-dump.c: Fix common/ includes.
 952         * cli/cli-cmds.c: Fix common/ includes.
 953         * charset.c: Fix common/ includes.
 954         * build-id.c: Fix common/ includes.
 955         * btrace.h: Fix common/ includes.
 956         * btrace.c: Fix common/ includes.
 957         * breakpoint.h: Fix common/ includes.
 958         * breakpoint.c: Fix common/ includes.
 959         * ax.h:
 960         (enum agent_op): Fix common/ includes.
 961         * ax-general.c (struct aop_map): Fix common/ includes.
 962         * ax-gdb.c: Fix common/ includes.
 963         * auxv.c: Fix common/ includes.
 964         * auto-load.c: Fix common/ includes.
 965         * arm-tdep.c: Fix common/ includes.
 966         * arch/riscv.c: Fix common/ includes.
 967         * arch/ppc-linux-common.c: Fix common/ includes.
 968         * arch/i386.c: Fix common/ includes.
 969         * arch/arm.c: Fix common/ includes.
 970         * arch/arm-linux.c: Fix common/ includes.
 971         * arch/arm-get-next-pcs.c: Fix common/ includes.
 972         * arch/amd64.c: Fix common/ includes.
 973         * arch/aarch64.c: Fix common/ includes.
 974         * arch/aarch64-insn.c: Fix common/ includes.
 975         * arch-utils.c: Fix common/ includes.
 976         * amd64-windows-tdep.c: Fix common/ includes.
 977         * amd64-tdep.c: Fix common/ includes.
 978         * amd64-sol2-tdep.c: Fix common/ includes.
 979         * amd64-obsd-tdep.c: Fix common/ includes.
 980         * amd64-nbsd-tdep.c: Fix common/ includes.
 981         * amd64-linux-tdep.c: Fix common/ includes.
 982         * amd64-linux-nat.c: Fix common/ includes.
 983         * amd64-fbsd-tdep.c: Fix common/ includes.
 984         * amd64-fbsd-nat.c: Fix common/ includes.
 985         * amd64-dicos-tdep.c: Fix common/ includes.
 986         * amd64-darwin-tdep.c: Fix common/ includes.
 987         * agent.c: Fix common/ includes.
 988         * ada-lang.h: Fix common/ includes.
 989         * ada-lang.c: Fix common/ includes.
 990         * aarch64-tdep.c: Fix common/ includes.
 991
 992 2019-01-25  Tom Tromey  <tom@tromey.com>
 993
 994         * common/create-version.sh: Use common/version.h.
 995
 996 2019-01-24  Pedro Alves  <palves@redhat.com>
 997
 998         * infrun.c (signal_stop, signal_print, signal_program)
 999         (signal_catch, signal_pass): Now arrays instead of pointers.
1000         (update_signals_program_target, do_target_resume)
1001         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1002         * linux-nat.c (linux_nat_target::pass_signals)
1003         (linux_nat_target::create_inferior, linux_nat_target::attach):
1004         Adjust.
1005         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1006         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1007         * procfs.c (procfs_target::pass_signals): Adjust.
1008         * record-full.c (record_full_target::resume): Adjust.
1009         * remote.c (remote_target::pass_signals)
1010         (remote_target::program_signals): Adjust.
1011         * target-debug.h (target_debug_print_signals): Now takes a
1012         gdb::array_view as parameter.  Adjust.
1013         * target.h (target_ops) <pass_signals, program_signals>: Replace
1014         pointer and length parameters with gdb::array_view.
1015         (target_pass_signals, target_program_signals): Likewise.
1016         * target-delegates.c: Regenerate.
1017
1018 2019-01-24  Pedro Alves  <palves@redhat.com>
1019
1020         * common/forward-scope-exit.h
1021         (forward_scope_exit::forward_scope_exit): Pass arguments to
1022         m_bind_function directly, instead of creating a std::bind and
1023         copying that.
1024
1025 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1026
1027         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1028         for static members.
1029         (pass_in_v_vfp_candidate): Likewise.
1030
1031 2019-01-23  Tom Tromey  <tom@tromey.com>
1032             Pedro Alves  <palves@redhat.com>
1033
1034         * regcache.c (class regcache_invalidator): Remove.
1035         (regcache::raw_write): Use make_scope_exit.
1036
1037 2019-01-23  Tom Tromey  <tom@tromey.com>
1038
1039         * ui-out.h (class ui_out_emit_type): Update comment.
1040
1041 2019-01-23  Tom Tromey  <tom@tromey.com>
1042
1043         * infrun.c (fetch_inferior_event): Update comment.
1044
1045 2019-01-23  Tom Tromey  <tom@tromey.com>
1046             Pedro Alves  <palves@redhat.com>
1047
1048         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1049         parameter.
1050         (fetch_inferior_event): Use SCOPE_EXIT.
1051
1052
1053 2019-01-23  Tom Tromey  <tom@tromey.com>
1054             Pedro Alves  <palves@redhat.com>
1055
1056         * infrun.c (disable_thread_events): Delete.
1057         (stop_all_threads): Use SCOPE_EXIT.
1058
1059 2019-01-23  Tom Tromey  <tom@tromey.com>
1060             Pedro Alves  <palves@redhat.com>
1061
1062         * symfile.c: Include forward-scope-exit.h.
1063         (clear_symtab_users_cleanup): Replace forward declaration with
1064         a FORWARD_SCOPE_EXIT.
1065         (syms_from_objfile_1): Use the forward_scope_exit and
1066         gdb::optional instead of cleanup_function.
1067         (reread_symbols): Use the forward_scope_exit instead of
1068         cleanup_function.
1069         (clear_symtab_users_cleanup): Remove function.
1070
1071 2019-01-23  Tom Tromey  <tom@tromey.com>
1072             Pedro Alves  <palves@redhat.com>
1073
1074         * linux-nat.c: Include scope-exit.h.
1075         (cleanup_target_stop): Remove.
1076         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1077         SCOPE_EXIT.
1078
1079 2019-01-23  Tom Tromey  <tom@tromey.com>
1080             Pedro Alves  <palves@redhat.com>
1081
1082         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1083         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1084
1085 2019-01-23  Tom Tromey  <tom@tromey.com>
1086             Andrew Burgess  <andrew.burgess@embecosm.com>
1087             Pedro Alves  <palves@redhat.com>
1088
1089         * infrun.c (fetch_inferior_event): Use scope_exit.
1090         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1091         * top.c (execute_command): Use scope_exit.
1092         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1093         * utils.c (do_bpstat_clear_actions_cleanup)
1094         (make_bpstat_clear_actions_cleanup): Remove.
1095
1096 2019-01-23  Tom Tromey  <tom@tromey.com>
1097             Pedro Alves  <palves@redhat.com>
1098
1099         * infrun.c: Include "common/scope-exit.h"
1100         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1101         (wait_for_inferior): Use SCOPE_EXIT.
1102         (fetch_inferior_event): Use scope_exit.
1103
1104 2019-01-23  Tom Tromey  <tom@tromey.com>
1105             Pedro Alves  <palves@redhat.com>
1106
1107         * breakpoint.c (create_breakpoint): Remove cleanup.
1108
1109 2019-01-23  Tom Tromey  <tom@tromey.com>
1110             Andrew Burgess  <andrew.burgess@embecosm.com>
1111             Pedro Alves  <palves@redhat.com>
1112
1113 2019-01-23  Pedro Alves  <palves@redhat.com>
1114
1115         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1116
1117 2019-01-23  Pedro Alves  <palves@redhat.com>
1118             Andrew Burgess  <andrew.burgess@embecosm.com>
1119
1120         * gdbthread.h: Include "common/forward-scope-exit.h".
1121         (scoped_finish_thread_state): Redefine custom class in terms of
1122         forward_scope_exit.
1123
1124 2019-01-23  Pedro Alves  <palves@redhat.com>
1125             Andrew Burgess  <andrew.burgess@embecosm.com>
1126
1127         * common/forward-scope-exit.h: New file.
1128
1129 2019-01-23  Pedro Alves  <palves@redhat.com>
1130             Andrew Burgess  <andrew.burgess@embecosm.com>
1131             Tom Tromey  <tom@tromey.com>
1132
1133         * common/scope-exit.h: New file.
1134
1135 2019-01-23  Pedro Alves  <palves@redhat.com>
1136
1137         * common/preprocessor.h (ESC): Rename to ...
1138         (ESC_PARENS): ... this.
1139         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1140         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1141
1142 2019-01-23  Tom Tromey  <tom@tromey.com>
1143
1144         * language.h (class scoped_switch_to_sym_language_if_auto):
1145         Initialize m_lang in both cases.
1146
1147 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1148
1149         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1150         with XCNEW.
1151
1152 2019-01-22  Tom Tromey  <tom@tromey.com>
1153
1154         * corelow.c: Do not include sys/file.h.
1155
1156 2019-01-22  Tom Tromey  <tom@tromey.com>
1157
1158         * tui/tui-wingeneral.h: Include gdb_curses.h.
1159
1160 2019-01-22  Tom Tromey  <tom@tromey.com>
1161
1162         * source-cache.h (class source_cache) <get_source_lines,
1163         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1164
1165 2019-01-22  Tom Tromey  <tom@tromey.com>
1166
1167         * remote-fileio.h (struct remote_target): Declare.
1168
1169 2019-01-22  Tom Tromey  <tom@tromey.com>
1170
1171         * python/py-arch.c: Do not include py-ref.h.
1172         * python/py-bpevent.c: Do not include py-ref.h.
1173         * python/py-cmd.c: Do not include py-ref.h.
1174         * python/py-continueevent.c: Do not include py-ref.h.
1175         * python/py-event.h: Do not include py-ref.h.
1176         * python/py-evtregistry.c: Do not include py-ref.h.
1177         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1178         * python/py-frame.c: Do not include py-ref.h.
1179         * python/py-framefilter.c: Do not include py-ref.h.
1180         * python/py-function.c: Do not include py-ref.h.
1181         * python/py-infevents.c: Do not include py-ref.h.
1182         * python/py-linetable.c: Do not include py-ref.h.
1183         * python/py-objfile.c: Do not include py-ref.h.
1184         * python/py-param.c: Do not include py-ref.h.
1185         * python/py-prettyprint.c: Do not include py-ref.h.
1186         * python/py-progspace.c: Do not include py-ref.h.
1187         * python/py-symbol.c: Do not include py-ref.h.
1188         * python/py-symtab.c: Do not include py-ref.h.
1189         * python/py-type.c: Do not include py-ref.h.
1190         * python/py-unwind.c: Do not include py-ref.h.
1191         * python/py-utils.c: Do not include py-ref.h.
1192         * python/py-value.c: Do not include py-ref.h.
1193         * python/py-varobj.c: Do not include py-ref.h.
1194         * python/py-xmethods.c: Do not include py-ref.h.
1195         * python/python.c: Do not include py-ref.h.
1196         * varobj.c: Do not include py-ref.h.
1197
1198 2019-01-22  Tom Tromey  <tom@tromey.com>
1199
1200         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1201         keyword for bcache.
1202
1203 2019-01-22  Tom Tromey  <tom@tromey.com>
1204
1205         * compile/compile-cplus-types.c: Remove a comment by #include.
1206
1207 2019-01-22  Tom Tromey  <tom@tromey.com>
1208
1209         * compile/gcc-c-plugin.h: Include compile-internal.h.
1210
1211 2019-01-22  Tom Tromey  <tom@tromey.com>
1212
1213         * stabsread.c (EXTERN): Do not define.
1214         (symnum, next_symbol_text_func, processing_gcc_compilation)
1215         (within_function, global_sym_chain, global_stabs)
1216         (previous_stab_code, this_object_header_files)
1217         (n_this_object_header_files)
1218         (n_allocated_this_object_header_files): Define.
1219         * stabsread.h (EXTERN): Never define.  Use "extern".
1220
1221 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1222
1223         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1224         history_value.
1225
1226 2019-01-21  Tom Tromey  <tom@tromey.com>
1227
1228         * ui-out.c: Fix includes.
1229         * tui/tui-source.c: Fix includes.
1230         * target.c: Fix includes.
1231         * remote.c: Fix includes.
1232         * regcache.c: Fix includes.
1233         * python/py-block.c: Fix includes.
1234         * printcmd.c: Fix includes.
1235         * or1k-tdep.c: Fix includes.
1236         * mi/mi-main.c: Fix includes.
1237         * m32r-tdep.c: Fix includes.
1238         * csky-tdep.c: Fix includes.
1239         * compile/compile-cplus-types.c: Fix includes.
1240         * cli/cli-interp.c: Fix includes.
1241
1242 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1243
1244         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1245         for padding.
1246
1247 2019-01-16  Tom Tromey  <tom@tromey.com>
1248
1249         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1250         earlier.
1251         (struct objfile) <msymbols_range>: Move from top level.
1252         <msymbols>: New method.
1253         (class objfile_msymbols): Remove.
1254         * symtab.c (default_collect_symbol_completion_matches_break_on):
1255         Update.
1256         * symmisc.c (dump_msymbols): Update.
1257         * stabsread.c (scan_file_globals): Update.
1258         * objc-lang.c (info_selectors_command, info_classes_command)
1259         (find_methods): Update.
1260         * minsyms.c (find_solib_trampoline_target): Update.
1261         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1262         * coffread.c (coff_symfile_read): Update.
1263         * ada-lang.c (ada_lookup_simple_minsym)
1264         (ada_collect_symbol_completion_matches): Update.
1265
1266 2019-01-16  Tom Tromey  <tom@tromey.com>
1267
1268         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1269         type.  Remove no-argument constructor.
1270         <iterator::operator++>: Simplify.
1271         <begin>: Update.
1272         <end>: Use minimal_symbol_count.
1273
1274 2019-01-16  Tom Tromey  <tom@tromey.com>
1275
1276         * objfiles.h (struct objfile) <psymtabs>: New method.
1277         (class objfile_psymtabs): Remove.
1278         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1279         typedef.
1280         <range>: New method.
1281         (require_partial_symbols): Change return type.
1282         * psymtab.c (require_partial_symbols)
1283         (psym_expand_symtabs_matching): Update.
1284         * mdebugread.c (parse_partial_symbols): Update.
1285         * dbxread.c (dbx_end_psymtab): Update.
1286
1287 2019-01-15  Tom Tromey  <tom@tromey.com>
1288
1289         * symtab.c (lookup_objfile_from_block)
1290         (lookup_symbol_in_objfile_symtabs)
1291         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1292         (find_line_symtab, info_sources_command)
1293         (default_collect_symbol_completion_matches_break_on)
1294         (make_source_files_completion_list): Update.
1295         * symmisc.c (print_objfile_statistics, dump_objfile)
1296         (maintenance_print_symbols, maintenance_info_symtabs)
1297         (maintenance_check_symtabs, maintenance_info_line_tables):
1298         Update.
1299         * source.c (select_source_symtab)
1300         (forget_cached_source_info_for_objfile): Update.
1301         * objfiles.h (class objfile_compunits): Remove.
1302         (struct objfile) <compunits_range>: New typedef.
1303         (compunits): New method.
1304         * objfiles.c (objfile_relocate1): Update.
1305         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1306         * maint.c (count_symtabs_and_blocks): Update.
1307         * linespec.c (iterate_over_all_matching_symtabs): Update.
1308         * cp-support.c (add_symbol_overload_list_qualified): Update.
1309         * coffread.c (coff_symtab_read): Update.
1310         * ada-lang.c (add_nonlocal_symbols)
1311         (ada_collect_symbol_completion_matches)
1312         (ada_add_global_exceptions): Update.
1313
1314 2019-01-15  Tom Tromey  <tom@tromey.com>
1315
1316         * progspace.h (program_space) <objfiles_safe_range>: New
1317         typedef.
1318         <objfiles_safe>: New method.
1319         * objfiles.h (class all_objfiles_safe): Remove.
1320         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1321         * jit.c (jit_inferior_exit_hook): Update.
1322
1323 2019-01-17  Tom Tromey  <tom@tromey.com>
1324
1325         * progspace.h (program_space) <objfiles_range>: New typedef.
1326         <objfiles>: New method.
1327         <objfiles_head>: Rename from objfiles.
1328         (object_files): Update.
1329         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1330         * guile/scm-pretty-print.c
1331         (ppscm_find_pretty_printer_from_objfiles): Update.
1332         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1333         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1334         Update.
1335         * python/py-progspace.c (pspy_get_objfiles): Update.
1336         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1337         Update.
1338         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1339         (objfpy_lookup_objfile_by_build_id): Update.
1340         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1341         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1342         Update.
1343         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1344         (expand_symtab_containing_pc, lookup_objfile_from_block)
1345         (lookup_static_symbol, basic_lookup_transparent_type)
1346         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1347         (find_line_symtab, info_sources_command)
1348         (default_collect_symbol_completion_matches_break_on)
1349         (make_source_files_completion_list, find_main_name): Update.
1350         * symmisc.c (print_symbol_bcache_statistics)
1351         (print_objfile_statistics, maintenance_print_symbols)
1352         (maintenance_print_msymbols, maintenance_print_objfiles)
1353         (maintenance_info_symtabs, maintenance_check_symtabs)
1354         (maintenance_expand_symtabs, maintenance_info_line_tables):
1355         Update.
1356         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1357         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1358         (map_overlay_command, unmap_overlay_command)
1359         (simple_overlay_update, expand_symtabs_matching)
1360         (map_symbol_filenames): Update.
1361         * symfile-debug.c (set_debug_symfile): Update.
1362         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1363         Update.
1364         * source.c (select_source_symtab, forget_cached_source_info):
1365         Update.
1366         * solib.c (solib_read_symbols): Update.
1367         * solib-spu.c (append_ocl_sos): Update.
1368         * psymtab.c (maintenance_print_psymbols)
1369         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1370         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1371         * printcmd.c (info_symbol_command): Update.
1372         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1373         Update.
1374         * objfiles.h (class all_objfiles): Remove.
1375         * objfiles.c (have_partial_symbols, have_full_symbols)
1376         (have_minimal_symbols, qsort_cmp, update_section_map)
1377         (shared_objfile_contains_address_p)
1378         (default_iterate_over_objfiles_in_search_order): Update.
1379         * objc-lang.c (info_selectors_command, info_classes_command)
1380         (find_methods): Update.
1381         * minsyms.c (find_solib_trampoline_target): Update.
1382         * maint.c (maintenance_info_sections)
1383         (maintenance_translate_address, count_symtabs_and_blocks):
1384         Update.
1385         * main.c (captured_main_1): Update.
1386         * linux-thread-db.c (try_thread_db_load_from_pdir)
1387         (has_libpthread): Update.
1388         * linespec.c (iterate_over_all_matching_symtabs)
1389         (search_minsyms_for_name): Update.
1390         * jit.c (jit_find_objf_with_entry_addr): Update.
1391         * hppa-tdep.c (find_unwind_entry)
1392         (hppa_lookup_stub_minimal_symbol): Update.
1393         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1394         Update.
1395         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1396         (elf_gnu_ifunc_resolve_by_got): Update.
1397         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1398         * dwarf-index-write.c (save_gdb_index_command): Update.
1399         * cp-support.c (add_symbol_overload_list_qualified): Update.
1400         * breakpoint.c (create_overlay_event_breakpoint)
1401         (create_longjmp_master_breakpoint)
1402         (create_std_terminate_master_breakpoint)
1403         (create_exception_master_breakpoint): Update.
1404         * blockframe.c (find_pc_partial_function): Update.
1405         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1406         (ada_collect_symbol_completion_matches)
1407         (ada_add_global_exceptions): Update.
1408
1409 2019-01-17  Tom Tromey  <tom@tromey.com>
1410
1411         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1412         declare VEC.
1413         (solib_target_parse_libraries): Change return type.
1414         (library_list_start_segment, library_list_start_section)
1415         (library_list_end_library, library_list_start_library); Update.
1416         (solib_target_free_library_list): Remove.
1417         (solib_target_parse_libraries): Remove cleanup.  Change return
1418         type.
1419         (solib_target_current_sos): Update.
1420
1421 2019-01-17  Tom Tromey  <tromey@bapiya>
1422
1423         * valprint.c: Replace "the the" with "the".
1424         * symtab.c: Replace "the the" with "the".
1425         * solib.c: Replace "the the" with "the".
1426         * solib-dsbt.c: Replace "the the" with "the".
1427         * linespec.c: Replace "the the" with "the".
1428         * dwarf2loc.h: Replace "the the" with "the".
1429         * amd64-windows-tdep.c: Replace "the the" with "the".
1430         * aarch64-tdep.c: Replace "the the" with "the".
1431
1432 2019-01-16  Keith Seitz  <keiths@redhat.com>
1433
1434         PR gdb/23773
1435         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1436         <builder>: Rename to ..
1437         <m_builder>: ... this and make private.
1438         (dwarf2_cu::get_builder): New method.  Change all users of
1439         `builder' to use this method.
1440         (dwarf2_start_symtab): Move to ...
1441         (dwarf2_cu::start_symtab): ... here.  Update all callers
1442         (setup_type_unit_groups): Move to ...
1443         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1444         callers.
1445         (dwarf2_cu::reset_builder): New method.
1446         (process_full_compunit, process_full_type_unit): Use
1447         dwarf2_cu::reset_builder.
1448         (follow_die_offset): Record the ancestor CU if it is different
1449         from the followed DIE's CU.
1450         (follow_die_sig_1): Likewise.
1451
1452 2019-01-15  Tom Tromey  <tom@tromey.com>
1453
1454         * remote.c (class remote_state) <buf>: Now a char_vector.
1455         <buf_size>: Remove.
1456         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1457         parameter.
1458         (remote_target::getpkt_or_notif_sane_1)
1459         (remote_target::getpkt_sane)
1460         (remote_target::getpkt_or_notif_sane): Likewise.
1461         (class remote_target) <putpkt>: New overload.
1462         (remote_target::read_frame): Change type of "buf_p".  Remove
1463         sizeof_p parameter.
1464         (packet_ok): New overload.
1465         (packet_check_result): New overload.
1466         Update all uses.
1467
1468 2019-01-14  Tom Tromey  <tom@tromey.com>
1469
1470         * remote-notif.c (handle_notification, remote_notif_ack)
1471         (remote_notif_parse): Make "buf" const.
1472         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1473         const.
1474         (remote_notif_parse, remote_notif_ack, handle_notification):
1475         Likewise.
1476         * remote.c (remote_notif_stop_parse): Make "buf" const.
1477         (remote_target::remote_parse_stop_reply): Make "buf" const.
1478         (remote_notif_stop_ack): Make "buf" const.
1479
1480 2019-01-14  Tom Tromey  <tom@tromey.com>
1481
1482         * remote.c (remote_console_output): Make parameter const.
1483
1484 2019-01-14  Tom Tromey  <tom@tromey.com>
1485
1486         * target-debug.h (target_debug_print_signals): Constify.
1487         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1488         * procfs.c (procfs_target::pass_signals): Update.
1489         * linux-nat.c (linux_nat_target::pass_signals): Update.
1490         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1491         * target-delegates.c: Rebuild.
1492         * remote.c (remote_target::program_signals): Update.
1493         (remote_target::pass_signals): Update.
1494         * target.c (target_pass_signals): Constify argument.
1495         (target_program_signals): Likewise.
1496         * target.h (struct target_ops) <pass_signals, program_signals>:
1497         Constify argument.
1498         (target_pass_signals, target_program_signals): Constify argument.
1499
1500 2019-01-14  Tom Tromey  <tom@tromey.com>
1501
1502         PR tui/28819:
1503         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1504
1505 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1506
1507         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1508         field.
1509         * rs6000-tdep.c: Include reggroups.h.
1510         (IS_V_ALIAS_PSEUDOREG): Define.
1511         (rs6000_register_name): Return names for the "vX" aliases.
1512         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1513         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1514         aliases.  Call default_register_reggroup_p for all other
1515         pseudo-registers.
1516         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1517         New functions.
1518         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1519         Handle "vX" aliases.
1520         (v_alias_pseudo_register_collect): New function.
1521         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1522         (rs6000_gdbarch_init): Initialize "vX" aliases as
1523         pseudo-registers.  Restore registration of
1524         rs6000_pseudo_register_reggroup_p with
1525         set_tdesc_pseudo_register_reggroup_p.
1526
1527 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1528
1529         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1530         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1531         set_gdbarch_num_pseudo_regs.
1532
1533 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1534
1535         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1536         Remove arg prefixname, add do_set and do_show.
1537         Add member functions set_list and show_list.
1538         * cli/cli-style.c (class cli_style_option): Update accordingly.
1539         (style_set_list): Move to file scope.
1540         (style_show_list): Likewise.
1541         (set_style): Call help_list.
1542         (show_style): Call cmd_show_list.
1543         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1544         Update to use the new macro.
1545
1546 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1547
1548         * ada-lang.c (_initialize_ada_language): Expand the help text
1549         for the "catch exception" command.
1550
1551 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1552
1553         * symtab.c (matching_obj_sections): Initialize obj,
1554         declare it closer to its usage.
1555
1556 2019-01-10  Tom Tromey  <tom@tromey.com>
1557
1558         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1559         (basic_inf_threads_range): Remove.
1560         (inf_threads_range, inf_non_exited_threads_range)
1561         (safe_inf_threads_range): Use next_adapter.
1562
1563 2019-01-10  Keith Seitz  <keiths@redhat.com>
1564
1565         PR gdb/23712
1566         PR symtab/23010
1567         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1568         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1569
1570 2019-01-10  Keith Seitz  <keiths@redhat.com>
1571
1572         PR gdb/23712
1573         PR symtab/23010
1574         * dictionary.c (pending_to_vector): Remove.
1575         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1576         Remove _1 suffix, replacing functions of the same name.  Update
1577         all callers.
1578         (dict_create_hashed, dict_create_hashed_expandable)
1579         (dict_create_linear, dict_create_linear_expandable, dict_free)
1580         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1581         Make functions static.
1582
1583 2019-01-10  Keith Seitz  <keiths@redhat.com>
1584
1585         PR gdb/23712
1586         PR symtab/23010
1587         * dictionary.h (struct dictionary): Replace declaration with
1588         multidictionary.
1589         (dict_create_hashed, dict_create_hashed_expandable)
1590         (dict_create_linear, dict_create_linear_expandable)
1591         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1592         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1593         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1594         taking multidictionary argument.
1595         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1596         * block.h (struct block) <dict>: Change to multidictionary
1597         and rename `multidict'.
1598         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1599         symmisc.c: Update all dictionary references to multidictionary.
1600
1601 2019-01-10  Keith Seitz  <keiths@redhat.com>
1602
1603         PR gdb/23712
1604         PR symtab/23010
1605         * dictionary.c: Include unordered_map.
1606         (pending_to_vector): New function.
1607         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1608         Rewrite the non-"_1" functions to take vector instead
1609         of linked list.
1610         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1611         "new" _1 versions of the same name.
1612         (multidictionary): Define.
1613         (std::hash<enum language): New definition.
1614         (collate_pending_symbols_by_language, mdict_create_hashed)
1615         (mdict_create_hashed_expandable, mdict_create_linear)
1616         (mdict_create_linear_expandable, mdict_free)
1617         (find_language_dictionary, create_new_language_dictionary)
1618         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1619         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1620         (mdict_size, mdict_empty): New functions.
1621         * dictionary.h (mdict_iterator): Define.
1622
1623 2019-01-10  Pedro Alves  <palves@redhat.com>
1624
1625         * breakpoint.c (read_uploaded_action)
1626         (create_tracepoint_from_upload): Adjust to use
1627         gdb::unique_xmalloc_ptr.
1628         * ctf.c (ctf_write_uploaded_tp):
1629         (SET_ARRAY_FIELD): Use emplace_back.
1630         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1631         * tracefile-tfile.c (tfile_write_uploaded_tp):
1632         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1633         gdb::unique_xmalloc_ptr.
1634         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1635         at_string, cond_string, cmd_strings>: Replace char pointers
1636         with gdb::unique_xmalloc_ptr.
1637
1638 2019-01-10  Pedro Alves  <palves@redhat.com>
1639
1640         * solib-target.c (library_list_start_library): Don't xstrdup name.
1641
1642 2019-01-10  Pedro Alves  <palves@redhat.com>
1643
1644         * mdebugread.c (parse_partial_symbols): Use
1645         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1646
1647 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1648
1649         * linux-fork.c (scoped_switch_fork_info)
1650         <~scoped_switch_fork_info>: Fix incorrect variable name.
1651
1652 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1653
1654         * linux-fork.c (scoped_switch_fork_info)
1655         <scoped_switch_fork_info>: Make explicit.
1656         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1657
1658 2019-01-10  Tom Tromey  <tom@tromey.com>
1659
1660         * objfiles.h (objfile::reset_psymtabs): Update.
1661         * objfiles.c (objfile::objfile): Update.
1662         * psymtab.h (psymtab_storage::obstack): Update.
1663         (psymtab_storage::m_obstack): Use gdb::optional.
1664         (class psymtab_storage): Update comment.  Remove objfile
1665         parameter.
1666         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1667
1668 2019-01-10  Tom Tromey  <tom@tromey.com>
1669
1670         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1671         <free_psymtabs>: Now private.
1672         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1673         (allocate_psymtab): Use new method.
1674
1675 2019-01-10  Tom Tromey  <tom@tromey.com>
1676
1677         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1678         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1679         * mdebugread.c (parse_partial_symbols): Use
1680         allocate_dependencies.
1681         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1682         allocate_dependencies.
1683         (process_psymtab_comp_unit_reader)
1684         (build_type_psymtab_dependencies): Likewise.
1685         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1686
1687 2019-01-10  Tom Tromey  <tom@tromey.com>
1688
1689         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1690         PSYMBOL_SET_LANGUAGE.
1691         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1692
1693 2019-01-10  Tom Tromey  <tom@tromey.com>
1694
1695         * psymtab.h (psymtab_storage::obstack): New method.
1696         <m_obstack>: Rename from obstack; now private.
1697         * psymtab.c (psymtab_storage): Update.
1698         * dwarf2read.c (create_addrmap_from_index)
1699         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1700         Update.
1701
1702 2019-01-10  Tom Tromey  <tom@tromey.com>
1703
1704         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1705         * objfiles.h (objfile::reset_psymtabs): New method.
1706
1707 2019-01-10  Tom Tromey  <tom@tromey.com>
1708
1709         * symmisc.c (print_symbol_bcache_statistics): Update.
1710         (print_objfile_statistics): Update.
1711         * symfile.c (reread_symbols): Update.
1712         * psymtab.h (class psymtab_storage): New.
1713         * psymtab.c (psymtab_storage): New constructor.
1714         (~psymtab_storage): New destructor.
1715         (require_partial_symbols): Update.
1716         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1717         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1718         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1719         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1720         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1721         (start_psymtab_common, end_psymtab_common)
1722         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1723         (allocate_psymtab): Update.
1724         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1725         Update.
1726         (dump_psymtab_addrmap, maintenance_print_psymbols)
1727         (maintenance_check_psymtabs): Update.
1728         (class objfile_psymtabs): Move to objfiles.h.
1729         * psympriv.h (discard_psymtab): Now inline.
1730         (psymtab_discarder::psymtab_discarder): Update.
1731         (psymtab_discarder::~psymtab_discarder): Update.
1732         (ALL_OBJFILE_PSYMTABS): Rewrite.
1733         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1734         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1735         Remove fields.
1736         <partial_symtabs>: New field.
1737         (class objfile_psymtabs): Move from psymtab.h.  Update.
1738         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1739         psymbol_cache.
1740         (objfile::~objfile): Don't destroy psymbol_cache.
1741         * mdebugread.c (parse_partial_symbols): Update.
1742         * dwarf2read.c (create_addrmap_from_index)
1743         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1744         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1745         (add_partial_subprogram, dwarf2_ranges_read): Update.
1746         * dwarf-index-write.c (write_address_map)
1747         (write_one_signatured_type, recursively_write_psymbols)
1748         (class debug_names, class debug_names, write_psymtabs_to_index):
1749         Update.
1750
1751 2019-01-10  Tom Tromey  <tom@tromey.com>
1752
1753         * symtab.h (SYMBOL_SET_NAMES): Update.
1754         (symbol_set_names): Update.
1755         (MSYMBOL_SET_NAMES): Update.
1756         * symtab.c (symbol_set_names): Change argument to be an
1757         objfile_per_bfd_storage.
1758         * psymtab.c (add_psymbol_to_bcache): Update.
1759         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1760
1761 2019-01-10  Tom Tromey  <tom@tromey.com>
1762
1763         * symtab.c (create_demangled_names_hash): Change argument to be an
1764         objfile_per_bfd_storage.
1765         (symbol_set_names): Update.
1766
1767 2019-01-10  Tom Tromey  <tom@tromey.com>
1768
1769         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1770         init_psymbol_list.
1771         * psymtab.c (init_psymbol_list): Do nothing if already called.
1772         * psympriv.h (init_psymbol_list): Add comment.
1773         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1774         init_psymbol_list.
1775         * dbxread.c (dbx_symfile_read): Unconditionally call
1776         init_psymbol_list.
1777
1778 2019-01-10  Tom Tromey  <tom@tromey.com>
1779
1780         * xcoffread.c (scan_xcoff_symtab): Update.
1781         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1782         "where".
1783         * mdebugread.c (parse_partial_symbols)
1784         (handle_psymbol_enumerators): Update.
1785         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1786         * dbxread.c (read_dbx_symtab): Update.
1787         * psympriv.h (psymbol_placement): New enum.
1788         (add_psymbol_to_list): Update.
1789
1790 2019-01-10  Tom Tromey  <tom@tromey.com>
1791
1792         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1793         static_psymbols parameters.
1794         (scan_xcoff_symtab): Update.
1795         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1796         static_psymbols parameters.
1797         * psympriv.h (start_psymtab_common): Update.
1798         * mdebugread.c (parse_partial_symbols): Update.
1799         * dwarf2read.c (create_partial_symtab): Update.
1800         * dbxread.c (read_dbx_symtab): Update.
1801         (start_psymtab): Remove global_psymbols and static_psymbols
1802         parameters.
1803
1804 2019-01-10  Tom Tromey  <tom@tromey.com>
1805
1806         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1807         * psymtab.c (allocate_psymtab): Add comment.
1808         * psympriv.h (allocate_psymtab): Add comment.
1809         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1810         initializations.
1811         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1812
1813 2019-01-10  Tom Tromey  <tom@tromey.com>
1814
1815         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1816         Don't declare.
1817         * mipsread.c: Include mdebugread.h.
1818         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1819         Declare.
1820         * elfread.c: Include mdebugread.h.
1821
1822 2019-01-09  Tom Tromey  <tom@tromey.com>
1823
1824         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1825         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1826         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1827         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1828         (psym_lookup_symbol, psym_find_last_source_symtab)
1829         (psym_forget_cached_source_info, psym_print_stats)
1830         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1831         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1832         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1833         (psym_find_compunit_symtab_by_address)
1834         (maintenance_print_psymbols, maintenance_info_psymtabs)
1835         (maintenance_check_psymtabs): Use ranged for.
1836         * psymtab.h (class objfile_psymtabs): New.
1837         (require_partial_symbols): Return objfile_psymtabs.
1838         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1839
1840 2019-01-09  Tom Tromey  <tom@tromey.com>
1841
1842         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1843         (find_pc_mapped_section, list_overlays_command)
1844         (map_overlay_command, unmap_overlay_command)
1845         (simple_overlay_update): Use all_objfiles.
1846         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1847         * printcmd.c (info_symbol_command): Use all_objfiles.
1848         * objfiles.h (ALL_OBJSECTIONS): Remove.
1849         * maint.c (maintenance_translate_address): Use all_objfiles.
1850         * gcore.c (gcore_create_callback): Use all_objfiles.
1851         (objfile_find_memory_regions): Likewise.
1852
1853 2019-01-09  Tom Tromey  <tom@tromey.com>
1854
1855         * symtab.c (find_line_symtab, info_sources_command)
1856         (make_source_files_completion_list): Use objfile_compunits.
1857         * source.c (select_source_symtab): Use objfile_compunits.
1858         * objfiles.h (struct objfile): Update comment.
1859         (ALL_OBJFILES): Remove.
1860         (ALL_FILETABS): Remove.
1861         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1862         objfile_compunits.
1863
1864 2019-01-09  Tom Tromey  <tom@tromey.com>
1865
1866         * symmisc.c (print_objfile_statistics, dump_objfile)
1867         (maintenance_print_symbols): Use compunit_filetabs.
1868         * source.c (forget_cached_source_info_for_objfile): Use
1869         compunit_filetabs.
1870         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1871         (ALL_FILETABS): Use compunit_filetabs.
1872         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1873         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1874
1875 2019-01-09  Tom Tromey  <tom@tromey.com>
1876
1877         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1878         (compunit_filetabs): New.
1879         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1880         compunit_filetabs.
1881         (info_sources_command, make_source_files_completion_list): Remove
1882         declaration.
1883         * symmisc.c (print_objfile_statistics, dump_objfile)
1884         (maintenance_print_symbols): Remove declaration.
1885         (maintenance_info_symtabs): Use compunit_filetabs.
1886         (maintenance_info_line_tables): Likewise.
1887         * source.c (select_source_symtab): Change local variable name.
1888         (forget_cached_source_info_for_objfile): Remove declaration.
1889         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1890         * objfiles.c (objfile_relocate1): Remove declaration.
1891         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1892         declaration.
1893         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1894         * coffread.c (coff_symtab_read): Remove declaration.
1895         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1896         compunit_filetabs.
1897
1898 2019-01-09  Tom Tromey  <tom@tromey.com>
1899
1900         * symtab.c (lookup_objfile_from_block)
1901         (find_pc_sect_compunit_symtab, search_symbols)
1902         (default_collect_symbol_completion_matches_break_on): Use
1903         objfile_compunits.
1904         * objfiles.h (ALL_COMPUNITS): Remove.
1905         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1906         * cp-support.c (add_symbol_overload_list_qualified): Use
1907         objfile_compunits.
1908         * ada-lang.c (ada_collect_symbol_completion_matches)
1909         (ada_add_global_exceptions): Use objfile_compunits.
1910
1911 2019-01-09  Tom Tromey  <tom@tromey.com>
1912
1913         * source.c (select_source_symtab)
1914         (forget_cached_source_info_for_objfile): Remove declaration.
1915         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1916         declaration.
1917         * maint.c (count_symtabs_and_blocks): Remove declaration.
1918         * cp-support.c (add_symbol_overload_list_qualified): Remove
1919         declaration.
1920         * coffread.c (coff_symtab_read): Remove declaration.
1921         * symtab.c (lookup_symbol_in_objfile_symtabs)
1922         (basic_lookup_transparent_type_1): Use objfile_compunits.
1923         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1924         (info_sources_command, search_symbols)
1925         (default_collect_symbol_completion_matches_break_on)
1926         (make_source_files_completion_list): Remove declaration.
1927         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1928         (ada_collect_symbol_completion_matches)
1929         (ada_add_global_exceptions): Remove declaration.
1930         * linespec.c (iterate_over_all_matching_symtabs): Use
1931         objfile_compunits.
1932         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1933         (class objfile_compunits): New.
1934         (ALL_COMPUNITS): Use objfile_compunits.
1935         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1936         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1937         objfile_compunits.
1938         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1939
1940 2019-01-09  Tom Tromey  <tom@tromey.com>
1941
1942         * symtab.c (search_symbols)
1943         (default_collect_symbol_completion_matches_break_on): Use
1944         objfile_msymbols.
1945         * ada-lang.c (ada_lookup_simple_minsym)
1946         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1947         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1948         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1949         objfile_msymbols.
1950         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1951         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1952         * objc-lang.c (find_methods): Use objfile_msymbols.
1953         (info_selectors_command, info_classes_command): Likewise.
1954         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1955         * objfiles.h (class objfile_msymbols): New.
1956         (ALL_OBJFILE_MSYMBOLS): Remove.
1957         (ALL_MSYMBOLS): Remove.
1958
1959 2019-01-09  Tom Tromey  <tom@tromey.com>
1960
1961         * common/next-iterator.h (next_adapter): Add Iterator template
1962         parameter.
1963         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1964         (class all_objfiles_safe): New.
1965         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1966         * objfiles.c (put_objfile_before): Update comment.
1967         (add_separate_debug_objfile): Likewise.
1968         (free_all_objfiles): Use all_objfiles_safe.
1969         (objfile_purge_solibs): Likewise.
1970
1971 2019-01-09  Tom Tromey  <tom@tromey.com>
1972
1973         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1974         (expand_symtab_containing_pc, lookup_static_symbol)
1975         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1976         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1977         all_objfiles.
1978         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1979         * breakpoint.c (create_overlay_event_breakpoint)
1980         (create_longjmp_master_breakpoint)
1981         (create_std_terminate_master_breakpoint)
1982         (create_exception_master_breakpoint): Use all_objfiles.
1983         * linux-thread-db.c (try_thread_db_load_from_pdir)
1984         (has_libpthread): Use all_objfiles.
1985         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1986         * linespec.c (iterate_over_all_matching_symtabs)
1987         (search_minsyms_for_name): Use all_objfiles.
1988         * maint.c (maintenance_info_sections): Use all_objfiles.
1989         * main.c (captured_main_1): Use all_objfiles.
1990         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1991         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1992         * guile/scm-pretty-print.c
1993         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1994         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1995         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1996         (maintenance_print_msymbols): Use all_objfiles.
1997         * source.c (select_source_symtab): Use all_objfiles.
1998         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1999         * symfile.c (remove_symbol_file_command)
2000         (expand_symtabs_matching, map_symbol_filenames): Use
2001         all_objfiles.
2002         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2003         all_objfiles.
2004         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2005         * objc-lang.c (find_methods): Use all_objfiles.
2006         * objfiles.c (have_partial_symbols, have_full_symbols)
2007         (have_minimal_symbols, qsort_cmp)
2008         (default_iterate_over_objfiles_in_search_order): Use
2009         all_objfiles.
2010         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2011         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2012         (maintenance_check_psymtabs): Use all_objfiles.
2013         (ALL_PSYMTABS): Remove.
2014         * compile/compile-object-run.c (do_module_cleanup): Use
2015         all_objfiles.
2016         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2017         * cp-support.c (add_symbol_overload_list_qualified): Use
2018         all_objfiles.
2019         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2020         Use all_objfiles.
2021         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2022         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2023         all_objfiles.
2024         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2025         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2026         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2027         Uses all_objfiles.
2028         * solib.c (solib_read_symbols): Use all_objfiles
2029
2030 2019-01-09  Tom Tromey  <tom@tromey.com>
2031
2032         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2033         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2034         all_objfiles.
2035         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2036         * symmisc.c (print_symbol_bcache_statistics)
2037         (print_objfile_statistics, maintenance_print_objfiles)
2038         (maintenance_info_symtabs, maintenance_check_symtabs)
2039         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2040         all_objfiles.
2041         * source.c (forget_cached_source_info): Use all_objfiles.
2042         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2043         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2044         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2045         * objfiles.c (update_section_map): Use all_objfiles.
2046         (shared_objfile_contains_address_p): Likewise.
2047         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2048         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2049
2050 2019-01-09  Tom Tromey  <tom@tromey.com>
2051
2052         * common/next-iterator.h: New file.
2053         * objfiles.h (class all_objfiles): New.
2054         (struct objfile_iterator): New.
2055
2056 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2057
2058         * NEWS: Move the description of the changed "frame", "select-frame",
2059          and "info frame" commands to the Changed commands section.
2060
2061 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2062
2063         * gdbtypes.c (check_stub_method_group): Remove handling of old
2064         mangling schemes.
2065         * linespec.c (find_methods): Likewise.
2066         * stabsread.c (read_member_functions): Likewise.
2067         * valops.c (search_struct_method): Likewise.
2068         (value_struct_elt_for_reference): Likewise.
2069         * NEWS: Mention this change.
2070
2071 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2072
2073         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2074         print_source_lines.
2075         * source.c (print_source_lines_base): Update line number check.
2076         (print_source_lines): New function.
2077         (source_lines_range::source_lines_range): New function.
2078         * source.h (class source_lines_range): New class.
2079         (print_source_lines): New declaration.
2080
2081 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2082
2083         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2084
2085 2019-01-08  Tom Tromey  <tom@tromey.com>
2086             Simon Marchi  <simon.marchi@ericsson.com>
2087
2088         PR gdb/24060
2089         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2090         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2091         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2092         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2093         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2094         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2095
2096 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2097
2098         * source.c (select_source_symtab): Move header comment to
2099         declaration in source.h.
2100         (forget_cached_source_info_for_objfile): Likewise.
2101         (forget_cached_source_info): Likewise.
2102         (identify_source_line): Likewise.
2103         * source.h (identify_source_line): Move declaration from symtab.h
2104         and add comment from source.c
2105         (print_source_lines): Likewise.
2106         (forget_cached_source_info_for_objfile): Likewise.
2107         (forget_cached_source_info): Likewise.
2108         (select_source_symtab): Likewise.
2109         (enum print_source_lines_flag): Move definition from symtab.h.
2110         * symtab.h (identify_source_line): Move declaration to source.h.
2111         (print_source_lines): Likewise.
2112         (forget_cached_source_info_for_objfile): Likewise.
2113         (forget_cached_source_info): Likewise.
2114         (select_source_symtab): Likewise.
2115         (enum print_source_lines_flag): Move definition to source.h.
2116         * tui/tui-hooks.c: Add 'source.h' include.
2117
2118 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2119
2120         * source.c (print_source_lines_base): Handle requests to print
2121         reverse line number sequences, and guard against empty lines
2122         string.
2123
2124 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2125
2126         * source.c (print_source_lines_base): Fix skip of '\r' if next
2127         character is '\n'.
2128
2129 2019-01-06  Tom Tromey  <tom@tromey.com>
2130
2131         * c-exp.y (struct c_parse_state) <macro_original_text,
2132         expansion_obstack>: New member.
2133         (macro_original_text, expansion_obstack): Remove globals.
2134         (scan_macro_expansion, scanning_macro_expansion)
2135         (finished_macro_expansion): Update.
2136         (scan_macro_cleanup): Remove.
2137         (yylex, c_parse): Update.
2138
2139 2019-01-06  Tom Tromey  <tom@tromey.com>
2140
2141         * c-exp.y (struct c_parse_state) <strings>: New member.
2142         (operator_stoken): Update.
2143
2144 2019-01-06  Tom Tromey  <tom@tromey.com>
2145
2146         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2147         (union type_stack_elt) <typelist_val>: Now a pointer to
2148         std::vector.
2149         (type_stack_cleanup): Don't declare.
2150         (push_typelist): Update.
2151         * parse.c (pop_typelist): Return a std::vector.
2152         (push_typelist): Take a std::vector.
2153         (follow_types): Update.  Do not free args.
2154         (type_stack_cleanup): Remove.
2155         * c-exp.y (struct c_parse_state): New.
2156         (cpstate): New global.
2157         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2158         (nonempty_typelist): Update.
2159         (func_mod): Create a new vector.
2160         (c_parse): Create a c_parse_state.
2161         (check_parameter_typelist): Do not delete params.
2162         (function_method): Update.  Do not delete type_list.
2163
2164 2019-01-06  Tom Tromey  <tom@tromey.com>
2165
2166         PR gdb/28155:
2167         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2168         check_typedef.
2169         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2170         (print_return_value): Likewise.
2171
2172 2019-01-05  Tom Tromey  <tom@tromey.com>
2173
2174         * contrib/cleanup_check.py: Remove.
2175         * contrib/gcc-with-excheck: Remove.
2176         * contrib/exsummary.py: Remove.
2177         * contrib/excheck.py: Remove.
2178
2179 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2180
2181         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2182         NULL. Initialize tpprev to NULL instead of assigning it
2183         to NULL on the next statement.
2184         * windows-nat.c (windows_delete_thread): Remove check for
2185         main_thread_id before printing thread exit notifications.
2186         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2187         Remove thread ID check against main_thread_id.
2188         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2189         windows_delete_thread.
2190         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2191
2192 2019-01-04  Tom Tromey  <tom@tromey.com>
2193
2194         * compile/compile.c (_initialize_compile): Use upper case for
2195         metasyntactic variables.
2196         * symmisc.c (_initialize_symmisc): Use upper case for
2197         metasyntactic variables.
2198         * psymtab.c (_initialize_psymtab): Use upper case for
2199         metasyntactic variables.
2200         * demangle.c (demangle_command): Use upper case for metasyntactic
2201         variables.
2202         (_initialize_demangler): Likewise.
2203         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2204         variables.
2205
2206 2019-01-03  Tom Tromey  <tom@tromey.com>
2207
2208         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2209
2210 2019-01-03  Tom Tromey  <tom@tromey.com>
2211
2212         * python/py-symtab.c (salpy_str): Update.
2213         (struct salpy_sal_object) <symtab>: Now a PyObject.
2214         (salpy_dealloc): Update.
2215         (del_objfile_sal): Use gdbpy_ref.
2216
2217 2019-01-03  Tom Tromey  <tom@tromey.com>
2218
2219         * python/py-type.c (convert_field): Use new_reference.  Return
2220         gdbpy_ref.
2221         (make_fielditem): Return gdbpy_ref.
2222         (typy_fields): Update.
2223         (typy_getitem): Update.
2224         (field_name): Return gdbpy_ref.  Use new_reference.
2225         (typy_iterator_iternext): Update.
2226
2227 2019-01-03  Tom Tromey  <tom@tromey.com>
2228
2229         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2230
2231 2019-01-03  Tom Tromey  <tom@tromey.com>
2232
2233         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2234         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2235         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2236         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2237         (pspy_set_type_printers): Likewise.
2238         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2239         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2240         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2241         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2242         (objfpy_set_type_printers): Likewise.
2243
2244 2019-01-03  Tom Tromey  <tom@tromey.com>
2245
2246         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2247         (gdbpy_print_stack): Use gdbpy_err_fetch.
2248         * python/python-internal.h (class gdbpy_err_fetch): New class.
2249         (class gdbpy_enter) <m_error_type, m_error_value,
2250         m_error_traceback>: Remove.
2251         <m_error>: New member.
2252         (gdbpy_exception_to_string): Don't declare.
2253         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2254         * python/py-value.c (convert_value_from_python): Use
2255         gdbpy_err_fetch.
2256         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2257         gdbpy_exception_to_string.
2258         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2259         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2260         gdbpy_err_fetch.
2261
2262 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2263
2264         * linux-nat.c (delete_lwp_cleanup): Delete.
2265         (struct lwp_deleter): New struct.
2266         (lwp_info_up): New typedef.
2267         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2268         lwp_info_up.
2269
2270 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2271
2272         * linux-fork.c (class scoped_switch_fork_info): New class.
2273         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2274
2275 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2276
2277         * valops.c (find_overload_match): Remove use of null_cleanup, and
2278         calls to do_cleanups.
2279
2280 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2281
2282         * compile/compile-cplus-types.c
2283         (compile_cplus_instance::decl_name): Handle changes to
2284         cp_func_name.
2285         * cp-support.c (cp_func_name): Update header comment, update
2286         return type.
2287         * cp-support.h (cp_func_name): Update return type in declaration.
2288         * valops.c (find_overload_match): Move temp_func local to top
2289         level of function and change its type.  Use temp_func to hold and
2290         delete temporary string obtained from cp_func_name.
2291
2292 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2293
2294         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2295         gdb::char_vector, remove cleanup, and update uses of `msg`.
2296
2297 2019-01-03  Jim Wilson  <jimw@sifive.com>
2298
2299         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2300
2301 2019-01-02  Tom Tromey  <tom@tromey.com>
2302
2303         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2304         (tdesc_parse_xml): Remove cleanups.
2305         * target-descriptions.h (make_cleanup_free_target_description):
2306         Don't declare.
2307         (target_desc_deleter): New struct.
2308         (target_desc_up): New typedef.
2309         * target-descriptions.c (target_desc_deleter::operator()): Rename
2310         from free_target_description.
2311         (make_cleanup_free_target_description): Remove.
2312
2313 2019-01-02  Tom Tromey  <tom@tromey.com>
2314
2315         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2316         constructor, destructor.
2317         (linespec_parser): Remove typedef.
2318         (~linespec_parser): Rename from linespec_parser_delete.
2319         (linespec_lex_to_end, linespec_complete_label)
2320         (linespec_complete): Update.
2321         (decode_line_full): Remove cleanups.
2322         (decode_line_1): Update.
2323
2324 2019-01-02  Tom Tromey  <tom@tromey.com>
2325
2326         * python/python-internal.h (inferior_to_inferior_object): Change
2327         return type.
2328         * python/py-exitedevent.c (create_exited_event_object): Update.
2329         * python/py-inferior.c (inferior_to_inferior_object): Return
2330         gdbpy_ref.
2331         (python_new_inferior, python_inferior_deleted)
2332         (thread_to_thread_object, delete_thread_object)
2333         (build_inferior_list, gdbpy_selected_inferior): Update.
2334         * python/py-infthread.c (create_thread_object): Update.  Also fail
2335         if inferior_to_inferior_object fails.
2336
2337 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2338
2339         * inferior.h (class inferior) <displaced_step_state>: New field.
2340         * infrun.h (struct displaced_step_state): Move here from
2341         infrun.c.  Initialize fields, add constructor.
2342         <inf>: Remove field.
2343         <reset>: New method.
2344         * infrun.c (struct displaced_step_inferior_state): Move to
2345         infrun.h.
2346         (displaced_step_inferior_states): Remove.
2347         (get_displaced_stepping_state): Adust.
2348         (displaced_step_in_progress_any_inferior): Adjust.
2349         (displaced_step_in_progress_thread): Adjust.
2350         (displaced_step_in_progress): Adjust.
2351         (add_displaced_stepping_state): Remove.
2352         (get_displaced_step_closure_by_addr): Adjust.
2353         (remove_displaced_stepping_state): Remove.
2354         (infrun_inferior_exit): Call displaced_step_state.reset.
2355         (use_displaced_stepping): Don't check for NULL.
2356         (displaced_step_prepare_throw): Call
2357         get_displaced_stepping_state.
2358         (displaced_step_fixup): Don't check for NULL.
2359         (prepare_for_detach): Don't check for NULL.
2360
2361 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2362
2363         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2364          in case of call that did not complete.
2365
2366 2019-01-02  Andrey Utkin  <autkin@undo.io>
2367
2368         * symfile.c (find_separate_debug_file): Fix search of debug files for
2369         remote debuggee.
2370
2371 2019-01-02  Tom Tromey  <tom@tromey.com>
2372
2373         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2374         indentation.
2375         * python/py-frame.c (frapy_older): Remove cast.
2376         (frapy_newer): Likewise.
2377         * python/py-breakpoint.c (local_setattro): Remove cast.
2378         * python/py-arch.c (archpy_name): Remove local variable.
2379         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2380
2381 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2382
2383         * unittests/basic_string_view/element_access/char/empty.cc:
2384         Fix year range in copyright header.
2385
2386 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2387
2388         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2389         Delete.
2390         <operator==>: Update with for removed field.
2391         <hash>: Likewise.
2392         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2393         <isa_features>: ...this.
2394         <abi_features>: New field.
2395         (riscv_isa_flen): Update comment.
2396         (riscv_abi_xlen): New declaration.
2397         (riscv_abi_flen): New declaration.
2398         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2399         isa_features.
2400         (riscv_abi_xlen): New function.
2401         (riscv_isa_flen): Update to get answer from isa_features.
2402         (riscv_abi_flen): New function.
2403         (riscv_has_fp_abi): Update to get answer from abi_features.
2404         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2405         xlen and flen.
2406         (riscv_call_info) <xlen, flen>: Update comment.
2407         (riscv_call_arg_struct): Remove invalid assertions
2408         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2409         is removed.
2410         (riscv_gdbarch_init): Gather isa features and abi features
2411         separately, ensure both match on the gdbarch when reusing an old
2412         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2413         a target with 64-bit float hardware.
2414
2415 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2416
2417         * source.c (search_command_helper): Stop reverse search
2418         when line 1 has been searched.
2419
2420 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2421
2422         * record-full.c (record_full_base_target::close): Rewrite
2423         record_full_core_buf_list free logic.
2424
2425 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2426
2427         * break-catch-syscall.c (print_one_catch_syscall): xfree
2428         the last text.
2429
2430 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2431
2432         * top.c (print_gdb_version): Update Copyright year in version
2433         message.
2434
2435 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2436
2437         Update copyright year range in all GDB files.
2438
2439 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2440
2441         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2442
2443 For older changes see ChangeLog-2018.
2444 \f
2445 Local Variables:
2446 mode: change-log
2447 left-margin: 8
2448 fill-column: 74
2449 version-control: never
2450 coding: utf-8
2451 End:
2452