gdb/ChangeLog

   1 2019-02-17  Tom Tromey  <tom@tromey.com>
   2
   3         * macrocmd.c (show_pp_source_pos): Style the file names.
   4
   5 2019-02-17  Tom Tromey  <tom@tromey.com>
   6
   7         PR tui/24197:
   8         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
   9
  10 2019-02-17  Tom Tromey  <tom@tromey.com>
  11
  12         * ada-lang.c (user_select_syms): Use filtered printing.
  13         * utils.c (wrap_style): New global.
  14         (desired_style): Remove.
  15         (emit_style_escape): Add stream parameter.
  16         (set_output_style, reset_terminal_style, prompt_for_continue):
  17         Update.
  18         (flush_wrap_buffer): Only flush gdb_stdout.
  19         (wrap_here): Set wrap_style.
  20         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
  21         treat escape sequences as a character.  Change when wrap buffer is
  22         flushed.
  23         (fputs_styled): Do not set the output style when the default is
  24         requested.
  25         * ui-style.h (struct ui_file_style) <is_default>: New method.
  26         * source.c (print_source_lines_base): Emit escape sequences in one
  27         piece.
  28
  29 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
  30
  31         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
  32         integers and enumeration types.
  33
  34 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
  35
  36         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
  37         instead of lookup_symbol_in_language
  38         (do_exact_match): New function.
  39         (ada_get_symbol_name_matcher): Return do_exact_match when
  40         doing a verbatim match.
  41
  42 2019-02-15  Tom Tromey  <tromey@adacore.com>
  43
  44         * ravenscar-thread.c (ravenscar_thread_target::resume)
  45         (ravenscar_thread_target::wait): Special case wildcard requests.
  46
  47 2019-02-15  Tom Tromey  <tromey@adacore.com>
  48
  49         * ravenscar-thread.c (base_ptid): Remove.
  50         (struct ravenscar_thread_target) <close>: New method.
  51         <m_base_ptid>: New member.
  52         <update_inferior_ptid, active_task, task_is_currently_active,
  53         runtime_initialized>: Declare methods.
  54         <ravenscar_thread_target>: Add constructor.
  55         (ravenscar_thread_target::task_is_currently_active)
  56         (ravenscar_thread_target::update_inferior_ptid)
  57         (ravenscar_runtime_initialized): Rename.  Now methods.
  58         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
  59         (ravenscar_thread_target::update_thread_list): Update.
  60         (ravenscar_thread_target::active_task): Now method.
  61         (ravenscar_thread_target::store_registers)
  62         (ravenscar_thread_target::prepare_to_store)
  63         (ravenscar_thread_target::prepare_to_store)
  64         (ravenscar_thread_target::mourn_inferior): Update.
  65         (ravenscar_inferior_created): Use "new" to create target.
  66         (ravenscar_thread_target::get_ada_task_ptid): Update.
  67         (_initialize_ravenscar): Don't initialize base_ptid.
  68         (ravenscar_ops): Remove global.
  69
  70 2019-02-15  Tom Tromey  <tromey@adacore.com>
  71
  72         * target.h (push_target): Declare new overload.
  73         * target.c (push_target): New overload, taking an rvalue reference.
  74         * remote.c (remote_target::open_1): Use push_target overload.
  75         * corelow.c (core_target_open): Use push_target overload.
  76
  77 2019-02-15  Tom Tromey  <tromey@adacore.com>
  78
  79         * ravenscar-thread.c (is_ravenscar_task)
  80         (ravenscar_task_is_currently_active): Return bool.
  81         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
  82         (_initialize_ravenscar): Remove "(void)".
  83         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
  84         Return bool.
  85
  86 2019-02-15  Tom Tromey  <tromey@adacore.com>
  87
  88         * ravenscar-thread.c (ravenscar_runtime_initializer)
  89         (has_ravenscar_runtime, get_running_thread_id)
  90         (ravenscar_thread_target::resume): Fix indentation.
  91
  92 2019-02-15  Tom Tromey  <tromey@adacore.com>
  93
  94         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
  95         from ravenscar_arch_ops.
  96         (sparc_ravenscar_ops::fetch_registers)
  97         (sparc_ravenscar_ops::store_registers): Now methods.
  98         (sparc_ravenscar_prepare_to_store): Remove.
  99         (sparc_ravenscar_ops): Redefine.
 100         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 101         methods and destructor.  Remove members.
 102         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 103         (ravenscar_thread_target::store_registers)
 104         (ravenscar_thread_target::prepare_to_store): Update.
 105         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 106         Remove.
 107         (struct ppc_ravenscar_powerpc_ops): Derive from
 108         ravenscar_arch_ops.
 109         (ppc_ravenscar_powerpc_ops::fetch_registers)
 110         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 111         (ppc_ravenscar_powerpc_ops): Redefine.
 112         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 113         (ppc_ravenscar_e500_ops::fetch_registers)
 114         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 115         (ppc_ravenscar_e500_ops): Redefine.
 116         * aarch64-ravenscar-thread.c
 117         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 118         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 119         (aarch64_ravenscar_fetch_registers)
 120         (aarch64_ravenscar_store_registers): Now methods.
 121         (aarch64_ravenscar_ops): Redefine.
 122
 123 2019-02-15  Tom Tromey  <tromey@adacore.com>
 124
 125         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 126         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 127         (ravenscar_thread_target::stopped_by_watchpoint)
 128         (ravenscar_thread_target::stopped_data_address)
 129         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 130
 131 2019-02-15  Tom Tromey  <tromey@adacore.com>
 132
 133         * ravenscar-thread.c: Fix some typos.
 134
 135 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 136             Tom Tromey  <tromey@adacore.com>
 137
 138         * ada-lang.c (ada_exception_sal): Change addr_string to a
 139         std::string.
 140         (create_ada_exception_catchpoint): Update.
 141
 142 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 143             Tom Tromey  <tromey@adacore.com>
 144
 145         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 146         (bp_location_ops): Remove.
 147         (base_breakpoint_allocate_location): Update.
 148         (free_bp_location): Update.
 149         * ada-lang.c (class ada_catchpoint_location)
 150         <ada_catchpoint_location>: Remove ops parameter.
 151         (ada_catchpoint_location_dtor): Remove.
 152         (ada_catchpoint_location_ops): Remove.
 153         (allocate_location_exception): Update.
 154         * breakpoint.h (struct bp_location_ops): Remove.
 155         (class bp_location) <bp_location>: Remove bp_location_ops
 156         parameter.
 157         <~bp_location>: Add destructor.
 158         <ops>: Remove.
 159
 160 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 161             Pedro Alves  <palves@redhat.com>
 162
 163         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 164         'PATH_MAX'.
 165
 166 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 167             Samuel Thibault  <samuel.thibault@gnu.org>
 168             Thomas Schwinge  <thomas@codesourcery.com>
 169
 170         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 171         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 172
 173 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 174
 175         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 176         (check_empty): Use "const char *".
 177
 178         * gnu-nat.c (gnu_nat_target::detach): Instead of
 179         'detach_inferior (pid)' call
 180         'detach_inferior (find_inferior_pid (pid))'.
 181
 182         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 183         'nat/fork-inferior.o'.
 184         * gnu-nat.c: #include "nat/fork-inferior.h".
 185
 186         * gnu-nat.c (gnu_nat_target::detach): Instead of
 187         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 188         * gnu-nat.h: #include "inf-child.h".
 189         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 190         'i386_gnu_nat_target::fetch_registers'.
 191         (gnu_store_registers): Rename/move to
 192         'i386_gnu_nat_target::store_registers'.
 193
 194         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 195         * gnu-nat.h (mach_thread_info): New function.
 196         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 197
 198         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 199
 200 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 201
 202         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 203
 204 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 205
 206         * windows-nat.c (windows_add_thread): Add new parameter
 207         "main_thread_p" with default value set to false.  Update
 208         function documentation as well as all callers.
 209         (windows_delete_thread): Likewise.
 210         (fake_create_process): Update call to windows_add_thread.
 211         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 212         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 213         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 214         call to windows_delete_thread.
 215
 216 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 217
 218         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 219
 220 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 221
 222         * symfile.c (find_separate_debug_file): Use canonical path of
 223         sysroot with child_path instead of gdb_sysroot if it is valid.
 224
 225 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 226
 227         * symfile.c (find_separate_debug_file): Use child_path to
 228         determine if an object file is under a sysroot.
 229
 230 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 231
 232         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 233         unittests/child-path-selftests.c.
 234         * common/pathstuff.c (child_path): New function.
 235         * common/pathstuff.h (child_path): New prototype.
 236         * unittests/child-path-selftests.c: New file.
 237
 238 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 239
 240         * symfile.c (find_separate_debug_file): Look for separate debug
 241         files in debug directories under the sysroot.
 242
 243 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 244
 245         * symtab.h (struct minimal_symbol data_p): New const method.
 246         (struct minimal_symbol text_p): Likewise.
 247         * symtab.c (output_source_filename): Use file name style
 248         to print file name.
 249         (print_symbol_info): Likewise.
 250         (print_msymbol_info): Use address style to print addresses.
 251         Use function name style to print executable text symbols.
 252         (expand_symtab_containing_pc): Use data_p.
 253         (find_pc_sect_compunit_symtab): Likewise.
 254
 255 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 256
 257         * breakpoint.c (describe_other_breakpoints): Use address style
 258         to print addresses.
 259         (say_where): Likewise.
 260
 261 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 262
 263         * ada-typeprint.c (print_func_type): Print function name
 264         style to print function name.
 265         * c-typeprint.c (c_print_type_1): Likewise.
 266
 267 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 268
 269         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 270         for execve.
 271
 272 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 273
 274         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 275         type_stack.
 276
 277 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 278
 279         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 280         TYPE_CODE_REF types.
 281
 282 2019-02-08  Jim Wilson  <jimw@sifive.com>
 283
 284         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 285         (riscv_linux_fregset): New.
 286         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 287
 288 2019-02-07  Tom Tromey  <tom@tromey.com>
 289
 290         * thread.c (thread_cancel_execution_command): Update.
 291         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 292         methods.
 293         (struct thread_fsm_ops): Remove.
 294         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 295         (thread_fsm_should_stop, thread_fsm_return_value)
 296         (thread_fsm_set_finished, thread_fsm_finished_p)
 297         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 298         Don't declare.
 299         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 300         * infrun.c (clear_proceed_status_thread)
 301         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 302         (print_stop_event): Update.
 303         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 304         Add constructor.
 305         (step_command_fsm_ops): Remove.
 306         (new_step_command_fsm): Remove.
 307         (step_1): Update.
 308         (step_command_fsm::should_stop): Rename from
 309         step_command_fsm_should_stop.
 310         (step_command_fsm::clean_up): Rename from
 311         step_command_fsm_clean_up.
 312         (step_command_fsm::do_async_reply_reason): Rename from
 313         step_command_fsm_async_reply_reason.
 314         (struct until_next_fsm): Inherit from thread_fsm.  Add
 315         constructor.
 316         (until_next_fsm_ops): Remove.
 317         (new_until_next_fsm): Remove.
 318         (until_next_fsm::should_stop): Rename from
 319         until_next_fsm_should_stop.
 320         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 321         (until_next_fsm::do_async_reply_reason): Rename from
 322         until_next_fsm_async_reply_reason.
 323         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 324         constructor.  Change type of breakpoint.
 325         (finish_command_fsm_ops): Remove.
 326         (new_finish_command_fsm): Remove.
 327         (finish_command_fsm::should_stop): Rename from
 328         finish_command_fsm_should_stop.
 329         (finish_command_fsm::clean_up): Rename from
 330         finish_command_fsm_clean_up.
 331         (finish_command_fsm::return_value): Rename from
 332         finish_command_fsm_return_value.
 333         (finish_command_fsm::do_async_reply_reason): Rename from
 334         finish_command_fsm_async_reply_reason.
 335         (finish_command): Update.
 336         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 337         Add constructor.
 338         (call_thread_fsm_ops): Remove.
 339         (call_thread_fsm::call_thread_fsm): Rename from
 340         new_call_thread_fsm.
 341         (call_thread_fsm::should_stop): Rename from
 342         call_thread_fsm_should_stop.
 343         (call_thread_fsm::should_notify_stop): Rename from
 344         call_thread_fsm_should_notify_stop.
 345         (run_inferior_call, call_function_by_hand_dummy): Update.
 346         * cli/cli-interp.c (should_print_stop_to_console): Update.
 347         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 348         Add constructor.  Change type of location_breakpoint,
 349         caller_breakpoint.
 350         (until_break_fsm_ops): Remove.
 351         (new_until_break_fsm): Remove.
 352         (until_break_fsm::should_stop): Rename from
 353         until_break_fsm_should_stop.
 354         (until_break_fsm::clean_up): Rename from
 355         until_break_fsm_clean_up.
 356         (until_break_fsm::do_async_reply_reason): Rename from
 357         until_break_fsm_async_reply_reason.
 358         (until_break_command): Update.
 359         * thread-fsm.c: Remove.
 360         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 361
 362 2019-02-07  Tom Tromey  <tom@tromey.com>
 363
 364         * yy-remap.h: Add include guard.
 365         * xtensa-tdep.h: Add include guard.
 366         * xcoffread.h: Rename include guard.
 367         * varobj-iter.h: Add include guard.
 368         * tui/tui.h: Rename include guard.
 369         * tui/tui-winsource.h: Rename include guard.
 370         * tui/tui-wingeneral.h: Rename include guard.
 371         * tui/tui-windata.h: Rename include guard.
 372         * tui/tui-win.h: Rename include guard.
 373         * tui/tui-stack.h: Rename include guard.
 374         * tui/tui-source.h: Rename include guard.
 375         * tui/tui-regs.h: Rename include guard.
 376         * tui/tui-out.h: Rename include guard.
 377         * tui/tui-layout.h: Rename include guard.
 378         * tui/tui-io.h: Rename include guard.
 379         * tui/tui-hooks.h: Rename include guard.
 380         * tui/tui-file.h: Rename include guard.
 381         * tui/tui-disasm.h: Rename include guard.
 382         * tui/tui-data.h: Rename include guard.
 383         * tui/tui-command.h: Rename include guard.
 384         * tic6x-tdep.h: Add include guard.
 385         * target/waitstatus.h: Rename include guard.
 386         * target/wait.h: Rename include guard.
 387         * target/target.h: Rename include guard.
 388         * target/resume.h: Rename include guard.
 389         * target-float.h: Rename include guard.
 390         * stabsread.h: Add include guard.
 391         * rs6000-tdep.h: Add include guard.
 392         * riscv-fbsd-tdep.h: Add include guard.
 393         * regformats/regdef.h: Rename include guard.
 394         * record.h: Rename include guard.
 395         * python/python.h: Rename include guard.
 396         * python/python-internal.h: Rename include guard.
 397         * python/py-stopevent.h: Rename include guard.
 398         * python/py-ref.h: Rename include guard.
 399         * python/py-record.h: Rename include guard.
 400         * python/py-record-full.h: Rename include guard.
 401         * python/py-record-btrace.h: Rename include guard.
 402         * python/py-instruction.h: Rename include guard.
 403         * python/py-events.h: Rename include guard.
 404         * python/py-event.h: Rename include guard.
 405         * procfs.h: Add include guard.
 406         * proc-utils.h: Add include guard.
 407         * p-lang.h: Add include guard.
 408         * or1k-tdep.h: Rename include guard.
 409         * observable.h: Rename include guard.
 410         * nto-tdep.h: Rename include guard.
 411         * nat/x86-linux.h: Rename include guard.
 412         * nat/x86-linux-dregs.h: Rename include guard.
 413         * nat/x86-gcc-cpuid.h: Add include guard.
 414         * nat/x86-dregs.h: Rename include guard.
 415         * nat/x86-cpuid.h: Rename include guard.
 416         * nat/ppc-linux.h: Rename include guard.
 417         * nat/mips-linux-watch.h: Rename include guard.
 418         * nat/linux-waitpid.h: Rename include guard.
 419         * nat/linux-ptrace.h: Rename include guard.
 420         * nat/linux-procfs.h: Rename include guard.
 421         * nat/linux-osdata.h: Rename include guard.
 422         * nat/linux-nat.h: Rename include guard.
 423         * nat/linux-namespaces.h: Rename include guard.
 424         * nat/linux-btrace.h: Rename include guard.
 425         * nat/glibc_thread_db.h: Rename include guard.
 426         * nat/gdb_thread_db.h: Rename include guard.
 427         * nat/gdb_ptrace.h: Rename include guard.
 428         * nat/fork-inferior.h: Rename include guard.
 429         * nat/amd64-linux-siginfo.h: Rename include guard.
 430         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 431         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 432         * nat/aarch64-linux.h: Rename include guard.
 433         * nat/aarch64-linux-hw-point.h: Rename include guard.
 434         * mn10300-tdep.h: Add include guard.
 435         * mips-linux-tdep.h: Add include guard.
 436         * mi/mi-parse.h: Rename include guard.
 437         * mi/mi-out.h: Rename include guard.
 438         * mi/mi-main.h: Rename include guard.
 439         * mi/mi-interp.h: Rename include guard.
 440         * mi/mi-getopt.h: Rename include guard.
 441         * mi/mi-console.h: Rename include guard.
 442         * mi/mi-common.h: Rename include guard.
 443         * mi/mi-cmds.h: Rename include guard.
 444         * mi/mi-cmd-break.h: Rename include guard.
 445         * m2-lang.h: Add include guard.
 446         * location.h: Rename include guard.
 447         * linux-record.h: Rename include guard.
 448         * linux-nat.h: Add include guard.
 449         * linux-fork.h: Add include guard.
 450         * i386-darwin-tdep.h: Rename include guard.
 451         * hppa-linux-offsets.h: Add include guard.
 452         * guile/guile.h: Rename include guard.
 453         * guile/guile-internal.h: Rename include guard.
 454         * gnu-nat.h: Rename include guard.
 455         * gdb-stabs.h: Rename include guard.
 456         * frv-tdep.h: Add include guard.
 457         * f-lang.h: Add include guard.
 458         * event-loop.h: Add include guard.
 459         * darwin-nat.h: Rename include guard.
 460         * cp-abi.h: Rename include guard.
 461         * config/sparc/nm-sol2.h: Rename include guard.
 462         * config/nm-nto.h: Rename include guard.
 463         * config/nm-linux.h: Add include guard.
 464         * config/i386/nm-i386gnu.h: Rename include guard.
 465         * config/djgpp/nl_types.h: Rename include guard.
 466         * config/djgpp/langinfo.h: Rename include guard.
 467         * compile/gcc-cp-plugin.h: Add include guard.
 468         * compile/gcc-c-plugin.h: Add include guard.
 469         * compile/compile.h: Rename include guard.
 470         * compile/compile-object-run.h: Rename include guard.
 471         * compile/compile-object-load.h: Rename include guard.
 472         * compile/compile-internal.h: Rename include guard.
 473         * compile/compile-cplus.h: Rename include guard.
 474         * compile/compile-c.h: Rename include guard.
 475         * common/xml-utils.h: Rename include guard.
 476         * common/x86-xstate.h: Rename include guard.
 477         * common/version.h: Rename include guard.
 478         * common/vec.h: Rename include guard.
 479         * common/tdesc.h: Rename include guard.
 480         * common/selftest.h: Rename include guard.
 481         * common/scoped_restore.h: Rename include guard.
 482         * common/scoped_mmap.h: Rename include guard.
 483         * common/scoped_fd.h: Rename include guard.
 484         * common/safe-iterator.h: Rename include guard.
 485         * common/run-time-clock.h: Rename include guard.
 486         * common/refcounted-object.h: Rename include guard.
 487         * common/queue.h: Rename include guard.
 488         * common/ptid.h: Rename include guard.
 489         * common/print-utils.h: Rename include guard.
 490         * common/preprocessor.h: Rename include guard.
 491         * common/pathstuff.h: Rename include guard.
 492         * common/observable.h: Rename include guard.
 493         * common/netstuff.h: Rename include guard.
 494         * common/job-control.h: Rename include guard.
 495         * common/host-defs.h: Rename include guard.
 496         * common/gdb_wait.h: Rename include guard.
 497         * common/gdb_vecs.h: Rename include guard.
 498         * common/gdb_unlinker.h: Rename include guard.
 499         * common/gdb_unique_ptr.h: Rename include guard.
 500         * common/gdb_tilde_expand.h: Rename include guard.
 501         * common/gdb_sys_time.h: Rename include guard.
 502         * common/gdb_string_view.h: Rename include guard.
 503         * common/gdb_splay_tree.h: Rename include guard.
 504         * common/gdb_setjmp.h: Rename include guard.
 505         * common/gdb_ref_ptr.h: Rename include guard.
 506         * common/gdb_optional.h: Rename include guard.
 507         * common/gdb_locale.h: Rename include guard.
 508         * common/gdb_assert.h: Rename include guard.
 509         * common/filtered-iterator.h: Rename include guard.
 510         * common/filestuff.h: Rename include guard.
 511         * common/fileio.h: Rename include guard.
 512         * common/environ.h: Rename include guard.
 513         * common/common-utils.h: Rename include guard.
 514         * common/common-types.h: Rename include guard.
 515         * common/common-regcache.h: Rename include guard.
 516         * common/common-inferior.h: Rename include guard.
 517         * common/common-gdbthread.h: Rename include guard.
 518         * common/common-exceptions.h: Rename include guard.
 519         * common/common-defs.h: Rename include guard.
 520         * common/common-debug.h: Rename include guard.
 521         * common/cleanups.h: Rename include guard.
 522         * common/buffer.h: Rename include guard.
 523         * common/btrace-common.h: Rename include guard.
 524         * common/break-common.h: Rename include guard.
 525         * cli/cli-utils.h: Rename include guard.
 526         * cli/cli-style.h: Rename include guard.
 527         * cli/cli-setshow.h: Rename include guard.
 528         * cli/cli-script.h: Rename include guard.
 529         * cli/cli-interp.h: Rename include guard.
 530         * cli/cli-decode.h: Rename include guard.
 531         * cli/cli-cmds.h: Rename include guard.
 532         * charset-list.h: Add include guard.
 533         * buildsym-legacy.h: Rename include guard.
 534         * bfin-tdep.h: Add include guard.
 535         * ax.h: Rename include guard.
 536         * arm-linux-tdep.h: Add include guard.
 537         * arm-fbsd-tdep.h: Add include guard.
 538         * arch/xtensa.h: Rename include guard.
 539         * arch/tic6x.h: Add include guard.
 540         * arch/i386.h: Add include guard.
 541         * arch/arm.h: Rename include guard.
 542         * arch/arm-linux.h: Rename include guard.
 543         * arch/arm-get-next-pcs.h: Rename include guard.
 544         * arch/amd64.h: Add include guard.
 545         * arch/aarch64-insn.h: Rename include guard.
 546         * arch-utils.h: Rename include guard.
 547         * annotate.h: Add include guard.
 548         * amd64-darwin-tdep.h: Rename include guard.
 549         * aarch64-linux-tdep.h: Add include guard.
 550         * aarch64-fbsd-tdep.h: Add include guard.
 551         * aarch32-linux-nat.h: Add include guard.
 552
 553 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 554
 555         * macrotab.c (macro_define_internal): New function that
 556         factorizes macro_define_object_internal and macro_define_function
 557         code.
 558         (macro_define_object_internal): Use macro_define_internal.
 559         (macro_define_function): Likewise.
 560
 561 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 562
 563         * macrocmd.c (extract_identifier): Return
 564         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 565         callers.
 566
 567 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 568
 569         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 570
 571 2019-02-05  Tom Tromey  <tom@tromey.com>
 572
 573         * target.c (target_stack::unpush): Move assertion earlier.
 574
 575 2019-01-30  Tom Tromey  <tom@tromey.com>
 576
 577         PR python/23615:
 578         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 579         (gdbpy_parse_and_eval): Likewise.
 580         * python/python-internal.h (gdbpy_allow_threads): New class.
 581
 582 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 583
 584         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 585         (aarch64_fbsd_fpregmap): Move earlier.
 586         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 587         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 588         instead of individual calls to trad_frame_set_reg_addr.
 589         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 590         earlier.
 591         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 592         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 593         instead of individual calls to trad_frame_set_reg_addr.
 594
 595 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 596
 597         * CONTRIBUTE: Replace contribution list with wiki link.
 598
 599 2019-01-25  Tom Tromey  <tom@tromey.com>
 600
 601         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 602
 603 2019-01-25  Tom Tromey  <tom@tromey.com>
 604
 605         * xtensa-linux-nat.c: Fix common/ includes.
 606         * xml-support.h: Fix common/ includes.
 607         * xml-support.c: Fix common/ includes.
 608         * x86-linux-nat.c: Fix common/ includes.
 609         * windows-nat.c: Fix common/ includes.
 610         * varobj.h: Fix common/ includes.
 611         * varobj.c: Fix common/ includes.
 612         * value.c: Fix common/ includes.
 613         * valops.c: Fix common/ includes.
 614         * utils.c: Fix common/ includes.
 615         * unittests/xml-utils-selftests.c: Fix common/ includes.
 616         * unittests/utils-selftests.c: Fix common/ includes.
 617         * unittests/unpack-selftests.c: Fix common/ includes.
 618         * unittests/tracepoint-selftests.c: Fix common/ includes.
 619         * unittests/style-selftests.c: Fix common/ includes.
 620         * unittests/string_view-selftests.c: Fix common/ includes.
 621         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 622         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 623         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 624         * unittests/rsp-low-selftests.c: Fix common/ includes.
 625         * unittests/parse-connection-spec-selftests.c: Fix common/
 626         includes.
 627         * unittests/optional-selftests.c: Fix common/ includes.
 628         * unittests/offset-type-selftests.c: Fix common/ includes.
 629         * unittests/observable-selftests.c: Fix common/ includes.
 630         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 631         * unittests/memrange-selftests.c: Fix common/ includes.
 632         * unittests/memory-map-selftests.c: Fix common/ includes.
 633         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 634         * unittests/function-view-selftests.c: Fix common/ includes.
 635         * unittests/environ-selftests.c: Fix common/ includes.
 636         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 637         * unittests/common-utils-selftests.c: Fix common/ includes.
 638         * unittests/cli-utils-selftests.c: Fix common/ includes.
 639         * unittests/array-view-selftests.c: Fix common/ includes.
 640         * ui-file.c: Fix common/ includes.
 641         * tui/tui-io.c: Fix common/ includes.
 642         * tracepoint.h: Fix common/ includes.
 643         * tracepoint.c: Fix common/ includes.
 644         * tracefile-tfile.c: Fix common/ includes.
 645         * top.h: Fix common/ includes.
 646         * top.c: Fix common/ includes.
 647         * thread.c: Fix common/ includes.
 648         * target/waitstatus.h: Fix common/ includes.
 649         * target/waitstatus.c: Fix common/ includes.
 650         * target.h: Fix common/ includes.
 651         * target.c: Fix common/ includes.
 652         * target-memory.c: Fix common/ includes.
 653         * target-descriptions.c: Fix common/ includes.
 654         * symtab.h: Fix common/ includes.
 655         * symfile.c: Fix common/ includes.
 656         * stap-probe.c: Fix common/ includes.
 657         * spu-linux-nat.c: Fix common/ includes.
 658         * sparc-nat.c: Fix common/ includes.
 659         * source.c: Fix common/ includes.
 660         * solib.c: Fix common/ includes.
 661         * solib-target.c: Fix common/ includes.
 662         * ser-unix.c: Fix common/ includes.
 663         * ser-tcp.c: Fix common/ includes.
 664         * ser-pipe.c: Fix common/ includes.
 665         * ser-base.c: Fix common/ includes.
 666         * selftest-arch.c: Fix common/ includes.
 667         * s12z-tdep.c: Fix common/ includes.
 668         * rust-exp.y: Fix common/ includes.
 669         * rs6000-aix-tdep.c: Fix common/ includes.
 670         * riscv-tdep.c: Fix common/ includes.
 671         * remote.c: Fix common/ includes.
 672         * remote-notif.h: Fix common/ includes.
 673         * remote-fileio.h: Fix common/ includes.
 674         * remote-fileio.c: Fix common/ includes.
 675         * regcache.h: Fix common/ includes.
 676         * regcache.c: Fix common/ includes.
 677         * record-btrace.c: Fix common/ includes.
 678         * python/python.c: Fix common/ includes.
 679         * python/py-type.c: Fix common/ includes.
 680         * python/py-inferior.c: Fix common/ includes.
 681         * progspace.h: Fix common/ includes.
 682         * producer.c: Fix common/ includes.
 683         * procfs.c: Fix common/ includes.
 684         * proc-api.c: Fix common/ includes.
 685         * printcmd.c: Fix common/ includes.
 686         * ppc-linux-nat.c: Fix common/ includes.
 687         * parser-defs.h: Fix common/ includes.
 688         * osdata.c: Fix common/ includes.
 689         * obsd-nat.c: Fix common/ includes.
 690         * nat/x86-linux.c: Fix common/ includes.
 691         * nat/x86-linux-dregs.c: Fix common/ includes.
 692         * nat/x86-dregs.h: Fix common/ includes.
 693         * nat/x86-dregs.c: Fix common/ includes.
 694         * nat/ppc-linux.c: Fix common/ includes.
 695         * nat/mips-linux-watch.h: Fix common/ includes.
 696         * nat/mips-linux-watch.c: Fix common/ includes.
 697         * nat/linux-waitpid.c: Fix common/ includes.
 698         * nat/linux-ptrace.h: Fix common/ includes.
 699         * nat/linux-ptrace.c: Fix common/ includes.
 700         * nat/linux-procfs.c: Fix common/ includes.
 701         * nat/linux-personality.c: Fix common/ includes.
 702         * nat/linux-osdata.c: Fix common/ includes.
 703         * nat/linux-namespaces.c: Fix common/ includes.
 704         * nat/linux-btrace.h: Fix common/ includes.
 705         * nat/linux-btrace.c: Fix common/ includes.
 706         * nat/fork-inferior.c: Fix common/ includes.
 707         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 708         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 709         * nat/aarch64-linux.c: Fix common/ includes.
 710         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 711         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 712         * namespace.h: Fix common/ includes.
 713         * mips-linux-tdep.c: Fix common/ includes.
 714         * minsyms.c: Fix common/ includes.
 715         * mi/mi-parse.h: Fix common/ includes.
 716         * mi/mi-main.c: Fix common/ includes.
 717         * mi/mi-cmd-env.c: Fix common/ includes.
 718         * memrange.h: Fix common/ includes.
 719         * memattr.c: Fix common/ includes.
 720         * maint.h: Fix common/ includes.
 721         * maint.c: Fix common/ includes.
 722         * main.c: Fix common/ includes.
 723         * machoread.c: Fix common/ includes.
 724         * location.c: Fix common/ includes.
 725         * linux-thread-db.c: Fix common/ includes.
 726         * linux-nat.c: Fix common/ includes.
 727         * linux-fork.c: Fix common/ includes.
 728         * inline-frame.c: Fix common/ includes.
 729         * infrun.c: Fix common/ includes.
 730         * inflow.c: Fix common/ includes.
 731         * inferior.h: Fix common/ includes.
 732         * inferior.c: Fix common/ includes.
 733         * infcmd.c: Fix common/ includes.
 734         * inf-ptrace.c: Fix common/ includes.
 735         * inf-child.c: Fix common/ includes.
 736         * ia64-linux-nat.c: Fix common/ includes.
 737         * i387-tdep.c: Fix common/ includes.
 738         * i386-tdep.c: Fix common/ includes.
 739         * i386-linux-tdep.c: Fix common/ includes.
 740         * i386-linux-nat.c: Fix common/ includes.
 741         * i386-go32-tdep.c: Fix common/ includes.
 742         * i386-fbsd-tdep.c: Fix common/ includes.
 743         * i386-fbsd-nat.c: Fix common/ includes.
 744         * guile/scm-type.c: Fix common/ includes.
 745         * guile/guile.c: Fix common/ includes.
 746         * go32-nat.c: Fix common/ includes.
 747         * gnu-nat.c: Fix common/ includes.
 748         * gdbthread.h: Fix common/ includes.
 749         * gdbarch-selftests.c: Fix common/ includes.
 750         * gdb_usleep.c: Fix common/ includes.
 751         * gdb_select.h: Fix common/ includes.
 752         * gdb_bfd.c: Fix common/ includes.
 753         * gcore.c: Fix common/ includes.
 754         * fork-child.c: Fix common/ includes.
 755         * findvar.c: Fix common/ includes.
 756         * fbsd-nat.c: Fix common/ includes.
 757         * event-top.c: Fix common/ includes.
 758         * event-loop.c: Fix common/ includes.
 759         * dwarf2read.c: Fix common/ includes.
 760         * dwarf2loc.c: Fix common/ includes.
 761         * dwarf2-frame.c: Fix common/ includes.
 762         * dwarf-index-cache.c: Fix common/ includes.
 763         * dtrace-probe.c: Fix common/ includes.
 764         * disasm-selftests.c: Fix common/ includes.
 765         * defs.h: Fix common/ includes.
 766         * csky-tdep.c: Fix common/ includes.
 767         * cp-valprint.c: Fix common/ includes.
 768         * cp-support.h: Fix common/ includes.
 769         * cp-support.c: Fix common/ includes.
 770         * corelow.c: Fix common/ includes.
 771         * completer.h: Fix common/ includes.
 772         * completer.c: Fix common/ includes.
 773         * compile/compile.c: Fix common/ includes.
 774         * compile/compile-loc2c.c: Fix common/ includes.
 775         * compile/compile-cplus-types.c: Fix common/ includes.
 776         * compile/compile-cplus-symbols.c: Fix common/ includes.
 777         * command.h: Fix common/ includes.
 778         * cli/cli-dump.c: Fix common/ includes.
 779         * cli/cli-cmds.c: Fix common/ includes.
 780         * charset.c: Fix common/ includes.
 781         * build-id.c: Fix common/ includes.
 782         * btrace.h: Fix common/ includes.
 783         * btrace.c: Fix common/ includes.
 784         * breakpoint.h: Fix common/ includes.
 785         * breakpoint.c: Fix common/ includes.
 786         * ax.h:
 787         (enum agent_op): Fix common/ includes.
 788         * ax-general.c (struct aop_map): Fix common/ includes.
 789         * ax-gdb.c: Fix common/ includes.
 790         * auxv.c: Fix common/ includes.
 791         * auto-load.c: Fix common/ includes.
 792         * arm-tdep.c: Fix common/ includes.
 793         * arch/riscv.c: Fix common/ includes.
 794         * arch/ppc-linux-common.c: Fix common/ includes.
 795         * arch/i386.c: Fix common/ includes.
 796         * arch/arm.c: Fix common/ includes.
 797         * arch/arm-linux.c: Fix common/ includes.
 798         * arch/arm-get-next-pcs.c: Fix common/ includes.
 799         * arch/amd64.c: Fix common/ includes.
 800         * arch/aarch64.c: Fix common/ includes.
 801         * arch/aarch64-insn.c: Fix common/ includes.
 802         * arch-utils.c: Fix common/ includes.
 803         * amd64-windows-tdep.c: Fix common/ includes.
 804         * amd64-tdep.c: Fix common/ includes.
 805         * amd64-sol2-tdep.c: Fix common/ includes.
 806         * amd64-obsd-tdep.c: Fix common/ includes.
 807         * amd64-nbsd-tdep.c: Fix common/ includes.
 808         * amd64-linux-tdep.c: Fix common/ includes.
 809         * amd64-linux-nat.c: Fix common/ includes.
 810         * amd64-fbsd-tdep.c: Fix common/ includes.
 811         * amd64-fbsd-nat.c: Fix common/ includes.
 812         * amd64-dicos-tdep.c: Fix common/ includes.
 813         * amd64-darwin-tdep.c: Fix common/ includes.
 814         * agent.c: Fix common/ includes.
 815         * ada-lang.h: Fix common/ includes.
 816         * ada-lang.c: Fix common/ includes.
 817         * aarch64-tdep.c: Fix common/ includes.
 818
 819 2019-01-25  Tom Tromey  <tom@tromey.com>
 820
 821         * common/create-version.sh: Use common/version.h.
 822
 823 2019-01-24  Pedro Alves  <palves@redhat.com>
 824
 825         * infrun.c (signal_stop, signal_print, signal_program)
 826         (signal_catch, signal_pass): Now arrays instead of pointers.
 827         (update_signals_program_target, do_target_resume)
 828         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 829         * linux-nat.c (linux_nat_target::pass_signals)
 830         (linux_nat_target::create_inferior, linux_nat_target::attach):
 831         Adjust.
 832         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 833         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 834         * procfs.c (procfs_target::pass_signals): Adjust.
 835         * record-full.c (record_full_target::resume): Adjust.
 836         * remote.c (remote_target::pass_signals)
 837         (remote_target::program_signals): Adjust.
 838         * target-debug.h (target_debug_print_signals): Now takes a
 839         gdb::array_view as parameter.  Adjust.
 840         * target.h (target_ops) <pass_signals, program_signals>: Replace
 841         pointer and length parameters with gdb::array_view.
 842         (target_pass_signals, target_program_signals): Likewise.
 843         * target-delegates.c: Regenerate.
 844
 845 2019-01-24  Pedro Alves  <palves@redhat.com>
 846
 847         * common/forward-scope-exit.h
 848         (forward_scope_exit::forward_scope_exit): Pass arguments to
 849         m_bind_function directly, instead of creating a std::bind and
 850         copying that.
 851
 852 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 853
 854         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 855         for static members.
 856         (pass_in_v_vfp_candidate): Likewise.
 857
 858 2019-01-23  Tom Tromey  <tom@tromey.com>
 859             Pedro Alves  <palves@redhat.com>
 860
 861         * regcache.c (class regcache_invalidator): Remove.
 862         (regcache::raw_write): Use make_scope_exit.
 863
 864 2019-01-23  Tom Tromey  <tom@tromey.com>
 865
 866         * ui-out.h (class ui_out_emit_type): Update comment.
 867
 868 2019-01-23  Tom Tromey  <tom@tromey.com>
 869
 870         * infrun.c (fetch_inferior_event): Update comment.
 871
 872 2019-01-23  Tom Tromey  <tom@tromey.com>
 873             Pedro Alves  <palves@redhat.com>
 874
 875         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 876         parameter.
 877         (fetch_inferior_event): Use SCOPE_EXIT.
 878
 879
 880 2019-01-23  Tom Tromey  <tom@tromey.com>
 881             Pedro Alves  <palves@redhat.com>
 882
 883         * infrun.c (disable_thread_events): Delete.
 884         (stop_all_threads): Use SCOPE_EXIT.
 885
 886 2019-01-23  Tom Tromey  <tom@tromey.com>
 887             Pedro Alves  <palves@redhat.com>
 888
 889         * symfile.c: Include forward-scope-exit.h.
 890         (clear_symtab_users_cleanup): Replace forward declaration with
 891         a FORWARD_SCOPE_EXIT.
 892         (syms_from_objfile_1): Use the forward_scope_exit and
 893         gdb::optional instead of cleanup_function.
 894         (reread_symbols): Use the forward_scope_exit instead of
 895         cleanup_function.
 896         (clear_symtab_users_cleanup): Remove function.
 897
 898 2019-01-23  Tom Tromey  <tom@tromey.com>
 899             Pedro Alves  <palves@redhat.com>
 900
 901         * linux-nat.c: Include scope-exit.h.
 902         (cleanup_target_stop): Remove.
 903         (linux_nat_target::static_tracepoint_markers_by_strid): Use
 904         SCOPE_EXIT.
 905
 906 2019-01-23  Tom Tromey  <tom@tromey.com>
 907             Pedro Alves  <palves@redhat.com>
 908
 909         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
 910         (call_function_by_hand_dummy): Use SCOPE_EXIT.
 911
 912 2019-01-23  Tom Tromey  <tom@tromey.com>
 913             Andrew Burgess  <andrew.burgess@embecosm.com>
 914             Pedro Alves  <palves@redhat.com>
 915
 916         * infrun.c (fetch_inferior_event): Use scope_exit.
 917         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
 918         * top.c (execute_command): Use scope_exit.
 919         * breakpoint.c (bpstat_do_actions): Use scope_exit.
 920         * utils.c (do_bpstat_clear_actions_cleanup)
 921         (make_bpstat_clear_actions_cleanup): Remove.
 922
 923 2019-01-23  Tom Tromey  <tom@tromey.com>
 924             Pedro Alves  <palves@redhat.com>
 925
 926         * infrun.c: Include "common/scope-exit.h"
 927         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
 928         (wait_for_inferior): Use SCOPE_EXIT.
 929         (fetch_inferior_event): Use scope_exit.
 930
 931 2019-01-23  Tom Tromey  <tom@tromey.com>
 932             Pedro Alves  <palves@redhat.com>
 933
 934         * breakpoint.c (create_breakpoint): Remove cleanup.
 935
 936 2019-01-23  Tom Tromey  <tom@tromey.com>
 937             Andrew Burgess  <andrew.burgess@embecosm.com>
 938             Pedro Alves  <palves@redhat.com>
 939
 940 2019-01-23  Pedro Alves  <palves@redhat.com>
 941
 942         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
 943
 944 2019-01-23  Pedro Alves  <palves@redhat.com>
 945             Andrew Burgess  <andrew.burgess@embecosm.com>
 946
 947         * gdbthread.h: Include "common/forward-scope-exit.h".
 948         (scoped_finish_thread_state): Redefine custom class in terms of
 949         forward_scope_exit.
 950
 951 2019-01-23  Pedro Alves  <palves@redhat.com>
 952             Andrew Burgess  <andrew.burgess@embecosm.com>
 953
 954         * common/forward-scope-exit.h: New file.
 955
 956 2019-01-23  Pedro Alves  <palves@redhat.com>
 957             Andrew Burgess  <andrew.burgess@embecosm.com>
 958             Tom Tromey  <tom@tromey.com>
 959
 960         * common/scope-exit.h: New file.
 961
 962 2019-01-23  Pedro Alves  <palves@redhat.com>
 963
 964         * common/preprocessor.h (ESC): Rename to ...
 965         (ESC_PARENS): ... this.
 966         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
 967         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
 968
 969 2019-01-23  Tom Tromey  <tom@tromey.com>
 970
 971         * language.h (class scoped_switch_to_sym_language_if_auto):
 972         Initialize m_lang in both cases.
 973
 974 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
 975
 976         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
 977         with XCNEW.
 978
 979 2019-01-22  Tom Tromey  <tom@tromey.com>
 980
 981         * corelow.c: Do not include sys/file.h.
 982
 983 2019-01-22  Tom Tromey  <tom@tromey.com>
 984
 985         * tui/tui-wingeneral.h: Include gdb_curses.h.
 986
 987 2019-01-22  Tom Tromey  <tom@tromey.com>
 988
 989         * source-cache.h (class source_cache) <get_source_lines,
 990         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
 991
 992 2019-01-22  Tom Tromey  <tom@tromey.com>
 993
 994         * remote-fileio.h (struct remote_target): Declare.
 995
 996 2019-01-22  Tom Tromey  <tom@tromey.com>
 997
 998         * python/py-arch.c: Do not include py-ref.h.
 999         * python/py-bpevent.c: Do not include py-ref.h.
1000         * python/py-cmd.c: Do not include py-ref.h.
1001         * python/py-continueevent.c: Do not include py-ref.h.
1002         * python/py-event.h: Do not include py-ref.h.
1003         * python/py-evtregistry.c: Do not include py-ref.h.
1004         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1005         * python/py-frame.c: Do not include py-ref.h.
1006         * python/py-framefilter.c: Do not include py-ref.h.
1007         * python/py-function.c: Do not include py-ref.h.
1008         * python/py-infevents.c: Do not include py-ref.h.
1009         * python/py-linetable.c: Do not include py-ref.h.
1010         * python/py-objfile.c: Do not include py-ref.h.
1011         * python/py-param.c: Do not include py-ref.h.
1012         * python/py-prettyprint.c: Do not include py-ref.h.
1013         * python/py-progspace.c: Do not include py-ref.h.
1014         * python/py-symbol.c: Do not include py-ref.h.
1015         * python/py-symtab.c: Do not include py-ref.h.
1016         * python/py-type.c: Do not include py-ref.h.
1017         * python/py-unwind.c: Do not include py-ref.h.
1018         * python/py-utils.c: Do not include py-ref.h.
1019         * python/py-value.c: Do not include py-ref.h.
1020         * python/py-varobj.c: Do not include py-ref.h.
1021         * python/py-xmethods.c: Do not include py-ref.h.
1022         * python/python.c: Do not include py-ref.h.
1023         * varobj.c: Do not include py-ref.h.
1024
1025 2019-01-22  Tom Tromey  <tom@tromey.com>
1026
1027         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1028         keyword for bcache.
1029
1030 2019-01-22  Tom Tromey  <tom@tromey.com>
1031
1032         * compile/compile-cplus-types.c: Remove a comment by #include.
1033
1034 2019-01-22  Tom Tromey  <tom@tromey.com>
1035
1036         * compile/gcc-c-plugin.h: Include compile-internal.h.
1037
1038 2019-01-22  Tom Tromey  <tom@tromey.com>
1039
1040         * stabsread.c (EXTERN): Do not define.
1041         (symnum, next_symbol_text_func, processing_gcc_compilation)
1042         (within_function, global_sym_chain, global_stabs)
1043         (previous_stab_code, this_object_header_files)
1044         (n_this_object_header_files)
1045         (n_allocated_this_object_header_files): Define.
1046         * stabsread.h (EXTERN): Never define.  Use "extern".
1047
1048 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1049
1050         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1051         history_value.
1052
1053 2019-01-21  Tom Tromey  <tom@tromey.com>
1054
1055         * ui-out.c: Fix includes.
1056         * tui/tui-source.c: Fix includes.
1057         * target.c: Fix includes.
1058         * remote.c: Fix includes.
1059         * regcache.c: Fix includes.
1060         * python/py-block.c: Fix includes.
1061         * printcmd.c: Fix includes.
1062         * or1k-tdep.c: Fix includes.
1063         * mi/mi-main.c: Fix includes.
1064         * m32r-tdep.c: Fix includes.
1065         * csky-tdep.c: Fix includes.
1066         * compile/compile-cplus-types.c: Fix includes.
1067         * cli/cli-interp.c: Fix includes.
1068
1069 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1070
1071         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1072         for padding.
1073
1074 2019-01-16  Tom Tromey  <tom@tromey.com>
1075
1076         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1077         earlier.
1078         (struct objfile) <msymbols_range>: Move from top level.
1079         <msymbols>: New method.
1080         (class objfile_msymbols): Remove.
1081         * symtab.c (default_collect_symbol_completion_matches_break_on):
1082         Update.
1083         * symmisc.c (dump_msymbols): Update.
1084         * stabsread.c (scan_file_globals): Update.
1085         * objc-lang.c (info_selectors_command, info_classes_command)
1086         (find_methods): Update.
1087         * minsyms.c (find_solib_trampoline_target): Update.
1088         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1089         * coffread.c (coff_symfile_read): Update.
1090         * ada-lang.c (ada_lookup_simple_minsym)
1091         (ada_collect_symbol_completion_matches): Update.
1092
1093 2019-01-16  Tom Tromey  <tom@tromey.com>
1094
1095         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1096         type.  Remove no-argument constructor.
1097         <iterator::operator++>: Simplify.
1098         <begin>: Update.
1099         <end>: Use minimal_symbol_count.
1100
1101 2019-01-16  Tom Tromey  <tom@tromey.com>
1102
1103         * objfiles.h (struct objfile) <psymtabs>: New method.
1104         (class objfile_psymtabs): Remove.
1105         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1106         typedef.
1107         <range>: New method.
1108         (require_partial_symbols): Change return type.
1109         * psymtab.c (require_partial_symbols)
1110         (psym_expand_symtabs_matching): Update.
1111         * mdebugread.c (parse_partial_symbols): Update.
1112         * dbxread.c (dbx_end_psymtab): Update.
1113
1114 2019-01-15  Tom Tromey  <tom@tromey.com>
1115
1116         * symtab.c (lookup_objfile_from_block)
1117         (lookup_symbol_in_objfile_symtabs)
1118         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1119         (find_line_symtab, info_sources_command)
1120         (default_collect_symbol_completion_matches_break_on)
1121         (make_source_files_completion_list): Update.
1122         * symmisc.c (print_objfile_statistics, dump_objfile)
1123         (maintenance_print_symbols, maintenance_info_symtabs)
1124         (maintenance_check_symtabs, maintenance_info_line_tables):
1125         Update.
1126         * source.c (select_source_symtab)
1127         (forget_cached_source_info_for_objfile): Update.
1128         * objfiles.h (class objfile_compunits): Remove.
1129         (struct objfile) <compunits_range>: New typedef.
1130         (compunits): New method.
1131         * objfiles.c (objfile_relocate1): Update.
1132         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1133         * maint.c (count_symtabs_and_blocks): Update.
1134         * linespec.c (iterate_over_all_matching_symtabs): Update.
1135         * cp-support.c (add_symbol_overload_list_qualified): Update.
1136         * coffread.c (coff_symtab_read): Update.
1137         * ada-lang.c (add_nonlocal_symbols)
1138         (ada_collect_symbol_completion_matches)
1139         (ada_add_global_exceptions): Update.
1140
1141 2019-01-15  Tom Tromey  <tom@tromey.com>
1142
1143         * progspace.h (program_space) <objfiles_safe_range>: New
1144         typedef.
1145         <objfiles_safe>: New method.
1146         * objfiles.h (class all_objfiles_safe): Remove.
1147         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1148         * jit.c (jit_inferior_exit_hook): Update.
1149
1150 2019-01-17  Tom Tromey  <tom@tromey.com>
1151
1152         * progspace.h (program_space) <objfiles_range>: New typedef.
1153         <objfiles>: New method.
1154         <objfiles_head>: Rename from objfiles.
1155         (object_files): Update.
1156         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1157         * guile/scm-pretty-print.c
1158         (ppscm_find_pretty_printer_from_objfiles): Update.
1159         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1160         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1161         Update.
1162         * python/py-progspace.c (pspy_get_objfiles): Update.
1163         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1164         Update.
1165         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1166         (objfpy_lookup_objfile_by_build_id): Update.
1167         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1168         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1169         Update.
1170         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1171         (expand_symtab_containing_pc, lookup_objfile_from_block)
1172         (lookup_static_symbol, basic_lookup_transparent_type)
1173         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1174         (find_line_symtab, info_sources_command)
1175         (default_collect_symbol_completion_matches_break_on)
1176         (make_source_files_completion_list, find_main_name): Update.
1177         * symmisc.c (print_symbol_bcache_statistics)
1178         (print_objfile_statistics, maintenance_print_symbols)
1179         (maintenance_print_msymbols, maintenance_print_objfiles)
1180         (maintenance_info_symtabs, maintenance_check_symtabs)
1181         (maintenance_expand_symtabs, maintenance_info_line_tables):
1182         Update.
1183         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1184         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1185         (map_overlay_command, unmap_overlay_command)
1186         (simple_overlay_update, expand_symtabs_matching)
1187         (map_symbol_filenames): Update.
1188         * symfile-debug.c (set_debug_symfile): Update.
1189         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1190         Update.
1191         * source.c (select_source_symtab, forget_cached_source_info):
1192         Update.
1193         * solib.c (solib_read_symbols): Update.
1194         * solib-spu.c (append_ocl_sos): Update.
1195         * psymtab.c (maintenance_print_psymbols)
1196         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1197         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1198         * printcmd.c (info_symbol_command): Update.
1199         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1200         Update.
1201         * objfiles.h (class all_objfiles): Remove.
1202         * objfiles.c (have_partial_symbols, have_full_symbols)
1203         (have_minimal_symbols, qsort_cmp, update_section_map)
1204         (shared_objfile_contains_address_p)
1205         (default_iterate_over_objfiles_in_search_order): Update.
1206         * objc-lang.c (info_selectors_command, info_classes_command)
1207         (find_methods): Update.
1208         * minsyms.c (find_solib_trampoline_target): Update.
1209         * maint.c (maintenance_info_sections)
1210         (maintenance_translate_address, count_symtabs_and_blocks):
1211         Update.
1212         * main.c (captured_main_1): Update.
1213         * linux-thread-db.c (try_thread_db_load_from_pdir)
1214         (has_libpthread): Update.
1215         * linespec.c (iterate_over_all_matching_symtabs)
1216         (search_minsyms_for_name): Update.
1217         * jit.c (jit_find_objf_with_entry_addr): Update.
1218         * hppa-tdep.c (find_unwind_entry)
1219         (hppa_lookup_stub_minimal_symbol): Update.
1220         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1221         Update.
1222         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1223         (elf_gnu_ifunc_resolve_by_got): Update.
1224         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1225         * dwarf-index-write.c (save_gdb_index_command): Update.
1226         * cp-support.c (add_symbol_overload_list_qualified): Update.
1227         * breakpoint.c (create_overlay_event_breakpoint)
1228         (create_longjmp_master_breakpoint)
1229         (create_std_terminate_master_breakpoint)
1230         (create_exception_master_breakpoint): Update.
1231         * blockframe.c (find_pc_partial_function): Update.
1232         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1233         (ada_collect_symbol_completion_matches)
1234         (ada_add_global_exceptions): Update.
1235
1236 2019-01-17  Tom Tromey  <tom@tromey.com>
1237
1238         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1239         declare VEC.
1240         (solib_target_parse_libraries): Change return type.
1241         (library_list_start_segment, library_list_start_section)
1242         (library_list_end_library, library_list_start_library); Update.
1243         (solib_target_free_library_list): Remove.
1244         (solib_target_parse_libraries): Remove cleanup.  Change return
1245         type.
1246         (solib_target_current_sos): Update.
1247
1248 2019-01-17  Tom Tromey  <tromey@bapiya>
1249
1250         * valprint.c: Replace "the the" with "the".
1251         * symtab.c: Replace "the the" with "the".
1252         * solib.c: Replace "the the" with "the".
1253         * solib-dsbt.c: Replace "the the" with "the".
1254         * linespec.c: Replace "the the" with "the".
1255         * dwarf2loc.h: Replace "the the" with "the".
1256         * amd64-windows-tdep.c: Replace "the the" with "the".
1257         * aarch64-tdep.c: Replace "the the" with "the".
1258
1259 2019-01-16  Keith Seitz  <keiths@redhat.com>
1260
1261         PR gdb/23773
1262         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1263         <builder>: Rename to ..
1264         <m_builder>: ... this and make private.
1265         (dwarf2_cu::get_builder): New method.  Change all users of
1266         `builder' to use this method.
1267         (dwarf2_start_symtab): Move to ...
1268         (dwarf2_cu::start_symtab): ... here.  Update all callers
1269         (setup_type_unit_groups): Move to ...
1270         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1271         callers.
1272         (dwarf2_cu::reset_builder): New method.
1273         (process_full_compunit, process_full_type_unit): Use
1274         dwarf2_cu::reset_builder.
1275         (follow_die_offset): Record the ancestor CU if it is different
1276         from the followed DIE's CU.
1277         (follow_die_sig_1): Likewise.
1278
1279 2019-01-15  Tom Tromey  <tom@tromey.com>
1280
1281         * remote.c (class remote_state) <buf>: Now a char_vector.
1282         <buf_size>: Remove.
1283         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1284         parameter.
1285         (remote_target::getpkt_or_notif_sane_1)
1286         (remote_target::getpkt_sane)
1287         (remote_target::getpkt_or_notif_sane): Likewise.
1288         (class remote_target) <putpkt>: New overload.
1289         (remote_target::read_frame): Change type of "buf_p".  Remove
1290         sizeof_p parameter.
1291         (packet_ok): New overload.
1292         (packet_check_result): New overload.
1293         Update all uses.
1294
1295 2019-01-14  Tom Tromey  <tom@tromey.com>
1296
1297         * remote-notif.c (handle_notification, remote_notif_ack)
1298         (remote_notif_parse): Make "buf" const.
1299         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1300         const.
1301         (remote_notif_parse, remote_notif_ack, handle_notification):
1302         Likewise.
1303         * remote.c (remote_notif_stop_parse): Make "buf" const.
1304         (remote_target::remote_parse_stop_reply): Make "buf" const.
1305         (remote_notif_stop_ack): Make "buf" const.
1306
1307 2019-01-14  Tom Tromey  <tom@tromey.com>
1308
1309         * remote.c (remote_console_output): Make parameter const.
1310
1311 2019-01-14  Tom Tromey  <tom@tromey.com>
1312
1313         * target-debug.h (target_debug_print_signals): Constify.
1314         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1315         * procfs.c (procfs_target::pass_signals): Update.
1316         * linux-nat.c (linux_nat_target::pass_signals): Update.
1317         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1318         * target-delegates.c: Rebuild.
1319         * remote.c (remote_target::program_signals): Update.
1320         (remote_target::pass_signals): Update.
1321         * target.c (target_pass_signals): Constify argument.
1322         (target_program_signals): Likewise.
1323         * target.h (struct target_ops) <pass_signals, program_signals>:
1324         Constify argument.
1325         (target_pass_signals, target_program_signals): Constify argument.
1326
1327 2019-01-14  Tom Tromey  <tom@tromey.com>
1328
1329         PR tui/28819:
1330         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1331
1332 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1333
1334         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1335         field.
1336         * rs6000-tdep.c: Include reggroups.h.
1337         (IS_V_ALIAS_PSEUDOREG): Define.
1338         (rs6000_register_name): Return names for the "vX" aliases.
1339         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1340         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1341         aliases.  Call default_register_reggroup_p for all other
1342         pseudo-registers.
1343         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1344         New functions.
1345         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1346         Handle "vX" aliases.
1347         (v_alias_pseudo_register_collect): New function.
1348         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1349         (rs6000_gdbarch_init): Initialize "vX" aliases as
1350         pseudo-registers.  Restore registration of
1351         rs6000_pseudo_register_reggroup_p with
1352         set_tdesc_pseudo_register_reggroup_p.
1353
1354 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1355
1356         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1357         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1358         set_gdbarch_num_pseudo_regs.
1359
1360 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1361
1362         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1363         Remove arg prefixname, add do_set and do_show.
1364         Add member functions set_list and show_list.
1365         * cli/cli-style.c (class cli_style_option): Update accordingly.
1366         (style_set_list): Move to file scope.
1367         (style_show_list): Likewise.
1368         (set_style): Call help_list.
1369         (show_style): Call cmd_show_list.
1370         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1371         Update to use the new macro.
1372
1373 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1374
1375         * ada-lang.c (_initialize_ada_language): Expand the help text
1376         for the "catch exception" command.
1377
1378 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1379
1380         * symtab.c (matching_obj_sections): Initialize obj,
1381         declare it closer to its usage.
1382
1383 2019-01-10  Tom Tromey  <tom@tromey.com>
1384
1385         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1386         (basic_inf_threads_range): Remove.
1387         (inf_threads_range, inf_non_exited_threads_range)
1388         (safe_inf_threads_range): Use next_adapter.
1389
1390 2019-01-10  Keith Seitz  <keiths@redhat.com>
1391
1392         PR gdb/23712
1393         PR symtab/23010
1394         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1395         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1396
1397 2019-01-10  Keith Seitz  <keiths@redhat.com>
1398
1399         PR gdb/23712
1400         PR symtab/23010
1401         * dictionary.c (pending_to_vector): Remove.
1402         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1403         Remove _1 suffix, replacing functions of the same name.  Update
1404         all callers.
1405         (dict_create_hashed, dict_create_hashed_expandable)
1406         (dict_create_linear, dict_create_linear_expandable, dict_free)
1407         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1408         Make functions static.
1409
1410 2019-01-10  Keith Seitz  <keiths@redhat.com>
1411
1412         PR gdb/23712
1413         PR symtab/23010
1414         * dictionary.h (struct dictionary): Replace declaration with
1415         multidictionary.
1416         (dict_create_hashed, dict_create_hashed_expandable)
1417         (dict_create_linear, dict_create_linear_expandable)
1418         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1419         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1420         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1421         taking multidictionary argument.
1422         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1423         * block.h (struct block) <dict>: Change to multidictionary
1424         and rename `multidict'.
1425         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1426         symmisc.c: Update all dictionary references to multidictionary.
1427
1428 2019-01-10  Keith Seitz  <keiths@redhat.com>
1429
1430         PR gdb/23712
1431         PR symtab/23010
1432         * dictionary.c: Include unordered_map.
1433         (pending_to_vector): New function.
1434         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1435         Rewrite the non-"_1" functions to take vector instead
1436         of linked list.
1437         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1438         "new" _1 versions of the same name.
1439         (multidictionary): Define.
1440         (std::hash<enum language): New definition.
1441         (collate_pending_symbols_by_language, mdict_create_hashed)
1442         (mdict_create_hashed_expandable, mdict_create_linear)
1443         (mdict_create_linear_expandable, mdict_free)
1444         (find_language_dictionary, create_new_language_dictionary)
1445         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1446         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1447         (mdict_size, mdict_empty): New functions.
1448         * dictionary.h (mdict_iterator): Define.
1449
1450 2019-01-10  Pedro Alves  <palves@redhat.com>
1451
1452         * breakpoint.c (read_uploaded_action)
1453         (create_tracepoint_from_upload): Adjust to use
1454         gdb::unique_xmalloc_ptr.
1455         * ctf.c (ctf_write_uploaded_tp):
1456         (SET_ARRAY_FIELD): Use emplace_back.
1457         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1458         * tracefile-tfile.c (tfile_write_uploaded_tp):
1459         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1460         gdb::unique_xmalloc_ptr.
1461         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1462         at_string, cond_string, cmd_strings>: Replace char pointers
1463         with gdb::unique_xmalloc_ptr.
1464
1465 2019-01-10  Pedro Alves  <palves@redhat.com>
1466
1467         * solib-target.c (library_list_start_library): Don't xstrdup name.
1468
1469 2019-01-10  Pedro Alves  <palves@redhat.com>
1470
1471         * mdebugread.c (parse_partial_symbols): Use
1472         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1473
1474 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1475
1476         * linux-fork.c (scoped_switch_fork_info)
1477         <~scoped_switch_fork_info>: Fix incorrect variable name.
1478
1479 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1480
1481         * linux-fork.c (scoped_switch_fork_info)
1482         <scoped_switch_fork_info>: Make explicit.
1483         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1484
1485 2019-01-10  Tom Tromey  <tom@tromey.com>
1486
1487         * objfiles.h (objfile::reset_psymtabs): Update.
1488         * objfiles.c (objfile::objfile): Update.
1489         * psymtab.h (psymtab_storage::obstack): Update.
1490         (psymtab_storage::m_obstack): Use gdb::optional.
1491         (class psymtab_storage): Update comment.  Remove objfile
1492         parameter.
1493         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1494
1495 2019-01-10  Tom Tromey  <tom@tromey.com>
1496
1497         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1498         <free_psymtabs>: Now private.
1499         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1500         (allocate_psymtab): Use new method.
1501
1502 2019-01-10  Tom Tromey  <tom@tromey.com>
1503
1504         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1505         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1506         * mdebugread.c (parse_partial_symbols): Use
1507         allocate_dependencies.
1508         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1509         allocate_dependencies.
1510         (process_psymtab_comp_unit_reader)
1511         (build_type_psymtab_dependencies): Likewise.
1512         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1513
1514 2019-01-10  Tom Tromey  <tom@tromey.com>
1515
1516         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1517         PSYMBOL_SET_LANGUAGE.
1518         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1519
1520 2019-01-10  Tom Tromey  <tom@tromey.com>
1521
1522         * psymtab.h (psymtab_storage::obstack): New method.
1523         <m_obstack>: Rename from obstack; now private.
1524         * psymtab.c (psymtab_storage): Update.
1525         * dwarf2read.c (create_addrmap_from_index)
1526         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1527         Update.
1528
1529 2019-01-10  Tom Tromey  <tom@tromey.com>
1530
1531         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1532         * objfiles.h (objfile::reset_psymtabs): New method.
1533
1534 2019-01-10  Tom Tromey  <tom@tromey.com>
1535
1536         * symmisc.c (print_symbol_bcache_statistics): Update.
1537         (print_objfile_statistics): Update.
1538         * symfile.c (reread_symbols): Update.
1539         * psymtab.h (class psymtab_storage): New.
1540         * psymtab.c (psymtab_storage): New constructor.
1541         (~psymtab_storage): New destructor.
1542         (require_partial_symbols): Update.
1543         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1544         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1545         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1546         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1547         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1548         (start_psymtab_common, end_psymtab_common)
1549         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1550         (allocate_psymtab): Update.
1551         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1552         Update.
1553         (dump_psymtab_addrmap, maintenance_print_psymbols)
1554         (maintenance_check_psymtabs): Update.
1555         (class objfile_psymtabs): Move to objfiles.h.
1556         * psympriv.h (discard_psymtab): Now inline.
1557         (psymtab_discarder::psymtab_discarder): Update.
1558         (psymtab_discarder::~psymtab_discarder): Update.
1559         (ALL_OBJFILE_PSYMTABS): Rewrite.
1560         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1561         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1562         Remove fields.
1563         <partial_symtabs>: New field.
1564         (class objfile_psymtabs): Move from psymtab.h.  Update.
1565         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1566         psymbol_cache.
1567         (objfile::~objfile): Don't destroy psymbol_cache.
1568         * mdebugread.c (parse_partial_symbols): Update.
1569         * dwarf2read.c (create_addrmap_from_index)
1570         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1571         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1572         (add_partial_subprogram, dwarf2_ranges_read): Update.
1573         * dwarf-index-write.c (write_address_map)
1574         (write_one_signatured_type, recursively_write_psymbols)
1575         (class debug_names, class debug_names, write_psymtabs_to_index):
1576         Update.
1577
1578 2019-01-10  Tom Tromey  <tom@tromey.com>
1579
1580         * symtab.h (SYMBOL_SET_NAMES): Update.
1581         (symbol_set_names): Update.
1582         (MSYMBOL_SET_NAMES): Update.
1583         * symtab.c (symbol_set_names): Change argument to be an
1584         objfile_per_bfd_storage.
1585         * psymtab.c (add_psymbol_to_bcache): Update.
1586         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1587
1588 2019-01-10  Tom Tromey  <tom@tromey.com>
1589
1590         * symtab.c (create_demangled_names_hash): Change argument to be an
1591         objfile_per_bfd_storage.
1592         (symbol_set_names): Update.
1593
1594 2019-01-10  Tom Tromey  <tom@tromey.com>
1595
1596         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1597         init_psymbol_list.
1598         * psymtab.c (init_psymbol_list): Do nothing if already called.
1599         * psympriv.h (init_psymbol_list): Add comment.
1600         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1601         init_psymbol_list.
1602         * dbxread.c (dbx_symfile_read): Unconditionally call
1603         init_psymbol_list.
1604
1605 2019-01-10  Tom Tromey  <tom@tromey.com>
1606
1607         * xcoffread.c (scan_xcoff_symtab): Update.
1608         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1609         "where".
1610         * mdebugread.c (parse_partial_symbols)
1611         (handle_psymbol_enumerators): Update.
1612         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1613         * dbxread.c (read_dbx_symtab): Update.
1614         * psympriv.h (psymbol_placement): New enum.
1615         (add_psymbol_to_list): Update.
1616
1617 2019-01-10  Tom Tromey  <tom@tromey.com>
1618
1619         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1620         static_psymbols parameters.
1621         (scan_xcoff_symtab): Update.
1622         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1623         static_psymbols parameters.
1624         * psympriv.h (start_psymtab_common): Update.
1625         * mdebugread.c (parse_partial_symbols): Update.
1626         * dwarf2read.c (create_partial_symtab): Update.
1627         * dbxread.c (read_dbx_symtab): Update.
1628         (start_psymtab): Remove global_psymbols and static_psymbols
1629         parameters.
1630
1631 2019-01-10  Tom Tromey  <tom@tromey.com>
1632
1633         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1634         * psymtab.c (allocate_psymtab): Add comment.
1635         * psympriv.h (allocate_psymtab): Add comment.
1636         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1637         initializations.
1638         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1639
1640 2019-01-10  Tom Tromey  <tom@tromey.com>
1641
1642         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1643         Don't declare.
1644         * mipsread.c: Include mdebugread.h.
1645         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1646         Declare.
1647         * elfread.c: Include mdebugread.h.
1648
1649 2019-01-09  Tom Tromey  <tom@tromey.com>
1650
1651         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1652         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1653         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1654         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1655         (psym_lookup_symbol, psym_find_last_source_symtab)
1656         (psym_forget_cached_source_info, psym_print_stats)
1657         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1658         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1659         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1660         (psym_find_compunit_symtab_by_address)
1661         (maintenance_print_psymbols, maintenance_info_psymtabs)
1662         (maintenance_check_psymtabs): Use ranged for.
1663         * psymtab.h (class objfile_psymtabs): New.
1664         (require_partial_symbols): Return objfile_psymtabs.
1665         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1666
1667 2019-01-09  Tom Tromey  <tom@tromey.com>
1668
1669         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1670         (find_pc_mapped_section, list_overlays_command)
1671         (map_overlay_command, unmap_overlay_command)
1672         (simple_overlay_update): Use all_objfiles.
1673         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1674         * printcmd.c (info_symbol_command): Use all_objfiles.
1675         * objfiles.h (ALL_OBJSECTIONS): Remove.
1676         * maint.c (maintenance_translate_address): Use all_objfiles.
1677         * gcore.c (gcore_create_callback): Use all_objfiles.
1678         (objfile_find_memory_regions): Likewise.
1679
1680 2019-01-09  Tom Tromey  <tom@tromey.com>
1681
1682         * symtab.c (find_line_symtab, info_sources_command)
1683         (make_source_files_completion_list): Use objfile_compunits.
1684         * source.c (select_source_symtab): Use objfile_compunits.
1685         * objfiles.h (struct objfile): Update comment.
1686         (ALL_OBJFILES): Remove.
1687         (ALL_FILETABS): Remove.
1688         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1689         objfile_compunits.
1690
1691 2019-01-09  Tom Tromey  <tom@tromey.com>
1692
1693         * symmisc.c (print_objfile_statistics, dump_objfile)
1694         (maintenance_print_symbols): Use compunit_filetabs.
1695         * source.c (forget_cached_source_info_for_objfile): Use
1696         compunit_filetabs.
1697         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1698         (ALL_FILETABS): Use compunit_filetabs.
1699         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1700         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1701
1702 2019-01-09  Tom Tromey  <tom@tromey.com>
1703
1704         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1705         (compunit_filetabs): New.
1706         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1707         compunit_filetabs.
1708         (info_sources_command, make_source_files_completion_list): Remove
1709         declaration.
1710         * symmisc.c (print_objfile_statistics, dump_objfile)
1711         (maintenance_print_symbols): Remove declaration.
1712         (maintenance_info_symtabs): Use compunit_filetabs.
1713         (maintenance_info_line_tables): Likewise.
1714         * source.c (select_source_symtab): Change local variable name.
1715         (forget_cached_source_info_for_objfile): Remove declaration.
1716         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1717         * objfiles.c (objfile_relocate1): Remove declaration.
1718         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1719         declaration.
1720         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1721         * coffread.c (coff_symtab_read): Remove declaration.
1722         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1723         compunit_filetabs.
1724
1725 2019-01-09  Tom Tromey  <tom@tromey.com>
1726
1727         * symtab.c (lookup_objfile_from_block)
1728         (find_pc_sect_compunit_symtab, search_symbols)
1729         (default_collect_symbol_completion_matches_break_on): Use
1730         objfile_compunits.
1731         * objfiles.h (ALL_COMPUNITS): Remove.
1732         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1733         * cp-support.c (add_symbol_overload_list_qualified): Use
1734         objfile_compunits.
1735         * ada-lang.c (ada_collect_symbol_completion_matches)
1736         (ada_add_global_exceptions): Use objfile_compunits.
1737
1738 2019-01-09  Tom Tromey  <tom@tromey.com>
1739
1740         * source.c (select_source_symtab)
1741         (forget_cached_source_info_for_objfile): Remove declaration.
1742         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1743         declaration.
1744         * maint.c (count_symtabs_and_blocks): Remove declaration.
1745         * cp-support.c (add_symbol_overload_list_qualified): Remove
1746         declaration.
1747         * coffread.c (coff_symtab_read): Remove declaration.
1748         * symtab.c (lookup_symbol_in_objfile_symtabs)
1749         (basic_lookup_transparent_type_1): Use objfile_compunits.
1750         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1751         (info_sources_command, search_symbols)
1752         (default_collect_symbol_completion_matches_break_on)
1753         (make_source_files_completion_list): Remove declaration.
1754         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1755         (ada_collect_symbol_completion_matches)
1756         (ada_add_global_exceptions): Remove declaration.
1757         * linespec.c (iterate_over_all_matching_symtabs): Use
1758         objfile_compunits.
1759         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1760         (class objfile_compunits): New.
1761         (ALL_COMPUNITS): Use objfile_compunits.
1762         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1763         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1764         objfile_compunits.
1765         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1766
1767 2019-01-09  Tom Tromey  <tom@tromey.com>
1768
1769         * symtab.c (search_symbols)
1770         (default_collect_symbol_completion_matches_break_on): Use
1771         objfile_msymbols.
1772         * ada-lang.c (ada_lookup_simple_minsym)
1773         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1774         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1775         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1776         objfile_msymbols.
1777         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1778         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1779         * objc-lang.c (find_methods): Use objfile_msymbols.
1780         (info_selectors_command, info_classes_command): Likewise.
1781         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1782         * objfiles.h (class objfile_msymbols): New.
1783         (ALL_OBJFILE_MSYMBOLS): Remove.
1784         (ALL_MSYMBOLS): Remove.
1785
1786 2019-01-09  Tom Tromey  <tom@tromey.com>
1787
1788         * common/next-iterator.h (next_adapter): Add Iterator template
1789         parameter.
1790         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1791         (class all_objfiles_safe): New.
1792         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1793         * objfiles.c (put_objfile_before): Update comment.
1794         (add_separate_debug_objfile): Likewise.
1795         (free_all_objfiles): Use all_objfiles_safe.
1796         (objfile_purge_solibs): Likewise.
1797
1798 2019-01-09  Tom Tromey  <tom@tromey.com>
1799
1800         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1801         (expand_symtab_containing_pc, lookup_static_symbol)
1802         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1803         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1804         all_objfiles.
1805         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1806         * breakpoint.c (create_overlay_event_breakpoint)
1807         (create_longjmp_master_breakpoint)
1808         (create_std_terminate_master_breakpoint)
1809         (create_exception_master_breakpoint): Use all_objfiles.
1810         * linux-thread-db.c (try_thread_db_load_from_pdir)
1811         (has_libpthread): Use all_objfiles.
1812         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1813         * linespec.c (iterate_over_all_matching_symtabs)
1814         (search_minsyms_for_name): Use all_objfiles.
1815         * maint.c (maintenance_info_sections): Use all_objfiles.
1816         * main.c (captured_main_1): Use all_objfiles.
1817         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1818         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1819         * guile/scm-pretty-print.c
1820         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1821         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1822         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1823         (maintenance_print_msymbols): Use all_objfiles.
1824         * source.c (select_source_symtab): Use all_objfiles.
1825         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1826         * symfile.c (remove_symbol_file_command)
1827         (expand_symtabs_matching, map_symbol_filenames): Use
1828         all_objfiles.
1829         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1830         all_objfiles.
1831         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1832         * objc-lang.c (find_methods): Use all_objfiles.
1833         * objfiles.c (have_partial_symbols, have_full_symbols)
1834         (have_minimal_symbols, qsort_cmp)
1835         (default_iterate_over_objfiles_in_search_order): Use
1836         all_objfiles.
1837         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1838         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1839         (maintenance_check_psymtabs): Use all_objfiles.
1840         (ALL_PSYMTABS): Remove.
1841         * compile/compile-object-run.c (do_module_cleanup): Use
1842         all_objfiles.
1843         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1844         * cp-support.c (add_symbol_overload_list_qualified): Use
1845         all_objfiles.
1846         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1847         Use all_objfiles.
1848         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1849         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1850         all_objfiles.
1851         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1852         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1853         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1854         Uses all_objfiles.
1855         * solib.c (solib_read_symbols): Use all_objfiles
1856
1857 2019-01-09  Tom Tromey  <tom@tromey.com>
1858
1859         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1860         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1861         all_objfiles.
1862         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1863         * symmisc.c (print_symbol_bcache_statistics)
1864         (print_objfile_statistics, maintenance_print_objfiles)
1865         (maintenance_info_symtabs, maintenance_check_symtabs)
1866         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1867         all_objfiles.
1868         * source.c (forget_cached_source_info): Use all_objfiles.
1869         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1870         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1871         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1872         * objfiles.c (update_section_map): Use all_objfiles.
1873         (shared_objfile_contains_address_p): Likewise.
1874         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1875         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1876
1877 2019-01-09  Tom Tromey  <tom@tromey.com>
1878
1879         * common/next-iterator.h: New file.
1880         * objfiles.h (class all_objfiles): New.
1881         (struct objfile_iterator): New.
1882
1883 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1884
1885         * NEWS: Move the description of the changed "frame", "select-frame",
1886          and "info frame" commands to the Changed commands section.
1887
1888 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1889
1890         * gdbtypes.c (check_stub_method_group): Remove handling of old
1891         mangling schemes.
1892         * linespec.c (find_methods): Likewise.
1893         * stabsread.c (read_member_functions): Likewise.
1894         * valops.c (search_struct_method): Likewise.
1895         (value_struct_elt_for_reference): Likewise.
1896         * NEWS: Mention this change.
1897
1898 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1899
1900         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1901         print_source_lines.
1902         * source.c (print_source_lines_base): Update line number check.
1903         (print_source_lines): New function.
1904         (source_lines_range::source_lines_range): New function.
1905         * source.h (class source_lines_range): New class.
1906         (print_source_lines): New declaration.
1907
1908 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1909
1910         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1911
1912 2019-01-08  Tom Tromey  <tom@tromey.com>
1913             Simon Marchi  <simon.marchi@ericsson.com>
1914
1915         PR gdb/24060
1916         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1917         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1918         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1919         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1920         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1921         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1922
1923 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1924
1925         * source.c (select_source_symtab): Move header comment to
1926         declaration in source.h.
1927         (forget_cached_source_info_for_objfile): Likewise.
1928         (forget_cached_source_info): Likewise.
1929         (identify_source_line): Likewise.
1930         * source.h (identify_source_line): Move declaration from symtab.h
1931         and add comment from source.c
1932         (print_source_lines): Likewise.
1933         (forget_cached_source_info_for_objfile): Likewise.
1934         (forget_cached_source_info): Likewise.
1935         (select_source_symtab): Likewise.
1936         (enum print_source_lines_flag): Move definition from symtab.h.
1937         * symtab.h (identify_source_line): Move declaration to source.h.
1938         (print_source_lines): Likewise.
1939         (forget_cached_source_info_for_objfile): Likewise.
1940         (forget_cached_source_info): Likewise.
1941         (select_source_symtab): Likewise.
1942         (enum print_source_lines_flag): Move definition to source.h.
1943         * tui/tui-hooks.c: Add 'source.h' include.
1944
1945 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1946
1947         * source.c (print_source_lines_base): Handle requests to print
1948         reverse line number sequences, and guard against empty lines
1949         string.
1950
1951 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1952
1953         * source.c (print_source_lines_base): Fix skip of '\r' if next
1954         character is '\n'.
1955
1956 2019-01-06  Tom Tromey  <tom@tromey.com>
1957
1958         * c-exp.y (struct c_parse_state) <macro_original_text,
1959         expansion_obstack>: New member.
1960         (macro_original_text, expansion_obstack): Remove globals.
1961         (scan_macro_expansion, scanning_macro_expansion)
1962         (finished_macro_expansion): Update.
1963         (scan_macro_cleanup): Remove.
1964         (yylex, c_parse): Update.
1965
1966 2019-01-06  Tom Tromey  <tom@tromey.com>
1967
1968         * c-exp.y (struct c_parse_state) <strings>: New member.
1969         (operator_stoken): Update.
1970
1971 2019-01-06  Tom Tromey  <tom@tromey.com>
1972
1973         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1974         (union type_stack_elt) <typelist_val>: Now a pointer to
1975         std::vector.
1976         (type_stack_cleanup): Don't declare.
1977         (push_typelist): Update.
1978         * parse.c (pop_typelist): Return a std::vector.
1979         (push_typelist): Take a std::vector.
1980         (follow_types): Update.  Do not free args.
1981         (type_stack_cleanup): Remove.
1982         * c-exp.y (struct c_parse_state): New.
1983         (cpstate): New global.
1984         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1985         (nonempty_typelist): Update.
1986         (func_mod): Create a new vector.
1987         (c_parse): Create a c_parse_state.
1988         (check_parameter_typelist): Do not delete params.
1989         (function_method): Update.  Do not delete type_list.
1990
1991 2019-01-06  Tom Tromey  <tom@tromey.com>
1992
1993         PR gdb/28155:
1994         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1995         check_typedef.
1996         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1997         (print_return_value): Likewise.
1998
1999 2019-01-05  Tom Tromey  <tom@tromey.com>
2000
2001         * contrib/cleanup_check.py: Remove.
2002         * contrib/gcc-with-excheck: Remove.
2003         * contrib/exsummary.py: Remove.
2004         * contrib/excheck.py: Remove.
2005
2006 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2007
2008         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2009         NULL. Initialize tpprev to NULL instead of assigning it
2010         to NULL on the next statement.
2011         * windows-nat.c (windows_delete_thread): Remove check for
2012         main_thread_id before printing thread exit notifications.
2013         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2014         Remove thread ID check against main_thread_id.
2015         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2016         windows_delete_thread.
2017         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2018
2019 2019-01-04  Tom Tromey  <tom@tromey.com>
2020
2021         * compile/compile.c (_initialize_compile): Use upper case for
2022         metasyntactic variables.
2023         * symmisc.c (_initialize_symmisc): Use upper case for
2024         metasyntactic variables.
2025         * psymtab.c (_initialize_psymtab): Use upper case for
2026         metasyntactic variables.
2027         * demangle.c (demangle_command): Use upper case for metasyntactic
2028         variables.
2029         (_initialize_demangler): Likewise.
2030         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2031         variables.
2032
2033 2019-01-03  Tom Tromey  <tom@tromey.com>
2034
2035         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2036
2037 2019-01-03  Tom Tromey  <tom@tromey.com>
2038
2039         * python/py-symtab.c (salpy_str): Update.
2040         (struct salpy_sal_object) <symtab>: Now a PyObject.
2041         (salpy_dealloc): Update.
2042         (del_objfile_sal): Use gdbpy_ref.
2043
2044 2019-01-03  Tom Tromey  <tom@tromey.com>
2045
2046         * python/py-type.c (convert_field): Use new_reference.  Return
2047         gdbpy_ref.
2048         (make_fielditem): Return gdbpy_ref.
2049         (typy_fields): Update.
2050         (typy_getitem): Update.
2051         (field_name): Return gdbpy_ref.  Use new_reference.
2052         (typy_iterator_iternext): Update.
2053
2054 2019-01-03  Tom Tromey  <tom@tromey.com>
2055
2056         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2057
2058 2019-01-03  Tom Tromey  <tom@tromey.com>
2059
2060         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2061         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2062         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2063         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2064         (pspy_set_type_printers): Likewise.
2065         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2066         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2067         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2068         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2069         (objfpy_set_type_printers): Likewise.
2070
2071 2019-01-03  Tom Tromey  <tom@tromey.com>
2072
2073         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2074         (gdbpy_print_stack): Use gdbpy_err_fetch.
2075         * python/python-internal.h (class gdbpy_err_fetch): New class.
2076         (class gdbpy_enter) <m_error_type, m_error_value,
2077         m_error_traceback>: Remove.
2078         <m_error>: New member.
2079         (gdbpy_exception_to_string): Don't declare.
2080         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2081         * python/py-value.c (convert_value_from_python): Use
2082         gdbpy_err_fetch.
2083         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2084         gdbpy_exception_to_string.
2085         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2086         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2087         gdbpy_err_fetch.
2088
2089 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2090
2091         * linux-nat.c (delete_lwp_cleanup): Delete.
2092         (struct lwp_deleter): New struct.
2093         (lwp_info_up): New typedef.
2094         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2095         lwp_info_up.
2096
2097 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2098
2099         * linux-fork.c (class scoped_switch_fork_info): New class.
2100         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2101
2102 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2103
2104         * valops.c (find_overload_match): Remove use of null_cleanup, and
2105         calls to do_cleanups.
2106
2107 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2108
2109         * compile/compile-cplus-types.c
2110         (compile_cplus_instance::decl_name): Handle changes to
2111         cp_func_name.
2112         * cp-support.c (cp_func_name): Update header comment, update
2113         return type.
2114         * cp-support.h (cp_func_name): Update return type in declaration.
2115         * valops.c (find_overload_match): Move temp_func local to top
2116         level of function and change its type.  Use temp_func to hold and
2117         delete temporary string obtained from cp_func_name.
2118
2119 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2120
2121         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2122         gdb::char_vector, remove cleanup, and update uses of `msg`.
2123
2124 2019-01-03  Jim Wilson  <jimw@sifive.com>
2125
2126         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2127
2128 2019-01-02  Tom Tromey  <tom@tromey.com>
2129
2130         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2131         (tdesc_parse_xml): Remove cleanups.
2132         * target-descriptions.h (make_cleanup_free_target_description):
2133         Don't declare.
2134         (target_desc_deleter): New struct.
2135         (target_desc_up): New typedef.
2136         * target-descriptions.c (target_desc_deleter::operator()): Rename
2137         from free_target_description.
2138         (make_cleanup_free_target_description): Remove.
2139
2140 2019-01-02  Tom Tromey  <tom@tromey.com>
2141
2142         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2143         constructor, destructor.
2144         (linespec_parser): Remove typedef.
2145         (~linespec_parser): Rename from linespec_parser_delete.
2146         (linespec_lex_to_end, linespec_complete_label)
2147         (linespec_complete): Update.
2148         (decode_line_full): Remove cleanups.
2149         (decode_line_1): Update.
2150
2151 2019-01-02  Tom Tromey  <tom@tromey.com>
2152
2153         * python/python-internal.h (inferior_to_inferior_object): Change
2154         return type.
2155         * python/py-exitedevent.c (create_exited_event_object): Update.
2156         * python/py-inferior.c (inferior_to_inferior_object): Return
2157         gdbpy_ref.
2158         (python_new_inferior, python_inferior_deleted)
2159         (thread_to_thread_object, delete_thread_object)
2160         (build_inferior_list, gdbpy_selected_inferior): Update.
2161         * python/py-infthread.c (create_thread_object): Update.  Also fail
2162         if inferior_to_inferior_object fails.
2163
2164 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2165
2166         * inferior.h (class inferior) <displaced_step_state>: New field.
2167         * infrun.h (struct displaced_step_state): Move here from
2168         infrun.c.  Initialize fields, add constructor.
2169         <inf>: Remove field.
2170         <reset>: New method.
2171         * infrun.c (struct displaced_step_inferior_state): Move to
2172         infrun.h.
2173         (displaced_step_inferior_states): Remove.
2174         (get_displaced_stepping_state): Adust.
2175         (displaced_step_in_progress_any_inferior): Adjust.
2176         (displaced_step_in_progress_thread): Adjust.
2177         (displaced_step_in_progress): Adjust.
2178         (add_displaced_stepping_state): Remove.
2179         (get_displaced_step_closure_by_addr): Adjust.
2180         (remove_displaced_stepping_state): Remove.
2181         (infrun_inferior_exit): Call displaced_step_state.reset.
2182         (use_displaced_stepping): Don't check for NULL.
2183         (displaced_step_prepare_throw): Call
2184         get_displaced_stepping_state.
2185         (displaced_step_fixup): Don't check for NULL.
2186         (prepare_for_detach): Don't check for NULL.
2187
2188 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2189
2190         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2191          in case of call that did not complete.
2192
2193 2019-01-02  Andrey Utkin  <autkin@undo.io>
2194
2195         * symfile.c (find_separate_debug_file): Fix search of debug files for
2196         remote debuggee.
2197
2198 2019-01-02  Tom Tromey  <tom@tromey.com>
2199
2200         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2201         indentation.
2202         * python/py-frame.c (frapy_older): Remove cast.
2203         (frapy_newer): Likewise.
2204         * python/py-breakpoint.c (local_setattro): Remove cast.
2205         * python/py-arch.c (archpy_name): Remove local variable.
2206         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2207
2208 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2209
2210         * unittests/basic_string_view/element_access/char/empty.cc:
2211         Fix year range in copyright header.
2212
2213 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2214
2215         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2216         Delete.
2217         <operator==>: Update with for removed field.
2218         <hash>: Likewise.
2219         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2220         <isa_features>: ...this.
2221         <abi_features>: New field.
2222         (riscv_isa_flen): Update comment.
2223         (riscv_abi_xlen): New declaration.
2224         (riscv_abi_flen): New declaration.
2225         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2226         isa_features.
2227         (riscv_abi_xlen): New function.
2228         (riscv_isa_flen): Update to get answer from isa_features.
2229         (riscv_abi_flen): New function.
2230         (riscv_has_fp_abi): Update to get answer from abi_features.
2231         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2232         xlen and flen.
2233         (riscv_call_info) <xlen, flen>: Update comment.
2234         (riscv_call_arg_struct): Remove invalid assertions
2235         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2236         is removed.
2237         (riscv_gdbarch_init): Gather isa features and abi features
2238         separately, ensure both match on the gdbarch when reusing an old
2239         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2240         a target with 64-bit float hardware.
2241
2242 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2243
2244         * source.c (search_command_helper): Stop reverse search
2245         when line 1 has been searched.
2246
2247 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2248
2249         * record-full.c (record_full_base_target::close): Rewrite
2250         record_full_core_buf_list free logic.
2251
2252 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2253
2254         * break-catch-syscall.c (print_one_catch_syscall): xfree
2255         the last text.
2256
2257 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2258
2259         * top.c (print_gdb_version): Update Copyright year in version
2260         message.
2261
2262 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2263
2264         Update copyright year range in all GDB files.
2265
2266 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2267
2268         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2269
2270 For older changes see ChangeLog-2018.
2271 \f
2272 Local Variables:
2273 mode: change-log
2274 left-margin: 8
2275 fill-column: 74
2276 version-control: never
2277 coding: utf-8
2278 End:
2279