Removing lookup_minimal_symbol_and_objfile
[external/binutils.git] / gdb / ChangeLog
1 2018-05-29  Weimin Pan  <weimin.pan@oracle.com>
2
3         * minsyms.h (lookup_minimal_symbol_and_objfile): Remove declaration.
4         * minsyms.c (lookup_minimal_symbol_and_objfile): Remove definition.
5         * coff-pe-read.c (add_pe_forwarded_sym): Replace
6         lookup_minimal_symbol_and_objfile with lookup_bound_minimal_symbol.
7         * glibc-tdep.c (glibc_skip_solib_resolver): Likewise.
8         * jit.c (jit_breakpoint_re_set_internal): Likewise.
9         * printcmd.c (info_address_command): Likewise.
10
11 2018-05-29  Tom Tromey  <tom@tromey.com>
12
13         * windows-nat.c (handle_exception): Update fall-through comment.
14
15 2018-05-29  Tom Tromey  <tom@tromey.com>
16
17         * progspace.h (so_list_ptr): Remove typedef.  Don't declare VEC.
18         (struct program_space) <added_solibs>: Now a std::vector.
19         * breakpoint.c (print_solib_event): Update.
20         (check_status_catch_solib): Update.
21         * progspace.c (clear_program_space_solib_cache): Update.
22         * solib.c (update_solib_list): Update.
23
24 2018-05-29  Tom Tromey  <tom@tromey.com>
25
26         * python/py-type.c (typy_richcompare): Update.
27         * guile/scm-type.c (tyscm_equal_p_type_smob): Update.
28         * gdbtypes.h (types_deeply_equal): Return bool.
29         (types_equal): Likewise.
30         * gdbtypes.c (type_equality_entry_d): Remove typedef.  Don't
31         declare VEC.
32         (check_types_equal): Change worklist to std::vector.  Return
33         bool.
34         (struct type_equality_entry): Add constructor.
35         (compare_maybe_null_strings): Return bool.
36         (check_types_worklist): Return bool.  Change worklist to
37         std::vector.
38         (types_deeply_equal): Use std::vector.
39         (types_equal): Return bool.
40         (compare_maybe_null_strings): Simplify.
41
42 2018-05-29  Tom Tromey  <tom@tromey.com>
43
44         * record-btrace.c (tp_t): Remove typedef.  Don't declare VEC.
45
46 2018-05-29  Tom Tromey  <tom@tromey.com>
47
48         * objc-lang.h: Don't include cp-support.h.
49         * common/gdb_vecs.h (const_char_ptr): Remove typedef.  Don't
50         declare VEC.
51
52 2018-05-27  Tom Tromey  <tom@tromey.com>
53
54         * Makefile.in (DEPFILES): Don't reference REMOTE_OBS.
55
56 2018-05-25  Tom Tromey  <tom@tromey.com>
57
58         * value.c (value::location): Initialize.
59
60 2018-05-25  Tom Tromey  <tom@tromey.com>
61
62         * dbxread.c (init_bincl_list): Remove.
63         (bincl_list): Now a std::vector.
64         (bincls_allocated, next_bincl): Remove.
65         (free_bincl_list, do_free_bincl_list_cleanup)
66         (make_cleanup_free_bincl_list): Remove.
67         (dbx_read_symtab, elfstab_build_psymtabs): Use scoped_restore,
68         unique_xmalloc_ptr.
69         (find_corresponding_bincl_psymtab, read_dbx_symtab): Update.
70         (struct header_file_location): Add constructor.
71         (add_bincl_to_list): Remove.
72
73 2018-05-25  Tom Tromey  <tom@tromey.com>
74
75         * tui/tui.c (tui_enable): Update.
76         * mi/mi-interp.c (mi_interp::init): Update.
77         * interps.h (class interp) <name>: New method.
78         <m_name>: Rename from name.
79         (~scoped_restore_interp): Update.
80         * interps.c (interp::interp): Update.
81         (interp_add, interp_set, interp_lookup_existing)
82         (current_interp_named_p): Update.
83
84 2018-05-25  Tom Tromey  <tom@tromey.com>
85
86         * interps.c (interp_name): Remove.
87         * mi/mi-interp.c (mi_interp::init): Update.
88         * interps.h (interp_name): Remove.
89         (~scoped_restore_interp): Update.
90         * tui/tui.c (tui_enable): Update.
91
92 2018-05-25  Tom Tromey  <tom@tromey.com>
93
94         * utils.c (fputs_maybe_filtered): Update.
95         * linespec.c (decode_line_full): Update.
96         * mi/mi-interp.c (mi_on_normal_stop_1, mi_tsv_modified)
97         (mi_print_breakpoint_for_event, mi_solib_loaded)
98         (mi_solib_unloaded, mi_command_param_changed, mi_memory_changed)
99         (mi_user_selected_context_changed): Update.
100         * mi/mi-main.c (mi_execute_command): Update.
101         * cli/cli-script.c (execute_control_command): Update.
102         * python/python.c (execute_gdb_command): Update.
103         * solib.c (info_sharedlibrary_command): Update.
104         * interps.c (interp_ui_out): Remove.
105         * interps.h (interp_ui_out): Remove.
106
107 2018-05-25  Tom Tromey  <tom@tromey.com>
108
109         * tui/tui-interp.c (as_tui_interp): Use dynamic_cast.
110         * mi/mi-interp.c (as_mi_interp): Use dynamic_cast.
111         * cli/cli-interp.c (as_cli_interp): Use dynamic_cast.
112
113 2018-05-25  Tom Tromey  <tom@tromey.com>
114
115         * cli/cli-interp.c (safe_execute_command): Use scoped_restore.
116         * interps.c (interp_exec): Use scoped_restore.
117
118 2018-05-25  Tom Tromey  <tom@tromey.com>
119
120         * remote.c (remote_target::remote_file_get): Use
121         gdb::byte_vector.
122         (remote_target::remote_file_put): Likewise.
123
124 2018-05-25  Tom Tromey  <tom@tromey.com>
125
126         * coff-pe-read.c (struct read_pe_section_data) <section_name>: Now
127         a std::string.
128         (get_pe_section_index, add_pe_exported_sym): Update.
129         (read_pe_exported_syms): Use gdb::def_vector.
130
131 2018-05-25  Tom Tromey  <tom@tromey.com>
132
133         * frame.c (remove_prev_frame): Remove.
134         (get_prev_frame_if_no_cycle): Use TRY/CATCH.
135
136 2018-05-25  Maciej W. Rozycki  <macro@mips.com>
137
138         * mips-linux-tdep.h (mips_supply_fpregset, mips_fill_fpregset):
139         Remove prototypes.
140         * mips-linux-nat.c (supply_fpregset): Always call
141         `mips64_supply_fpregset' rather than `mips_supply_fpregset'.
142         (fill_fpregset): Always call `mips64_fill_fpregset' rather than
143         `mips_fill_fpregset'.
144         * mips-linux-tdep.c (mips_supply_fpregset)
145         (mips_supply_fpregset_wrapper, mips_fill_fpregset)
146         (mips_fill_fpregset_wrapper): Remove functions.
147         (mips64_supply_fpregset, mips64_fill_fpregset): Update comments.
148         (mips_linux_fpregset): Remove variable.
149         (mips_linux_iterate_over_regset_sections): Use
150         `mips64_linux_fpregset' in place of `mips_linux_fpregset'.
151         (mips_linux_o32_sigframe_init): Remove comment.
152
153 2018-05-25  Pedro Alves  <palves@redhat.com>
154
155         * remote.c (struct vCont_action_support, MAXTHREADLISTRESULTS)
156         (struct readahead_cache, struct packet_reg, struct
157         remote_arch_state, class remote_state): Move higher up in the
158         file.
159         (remote_target::m_remote_state): Now an object instead of a pointer.
160         (remote_target::get_remote_state): Adjust.
161
162 2018-05-24  Andrew Burgess  <andrew.burgess@embecosm.com>
163
164         * stack.c (select_and_print_frame): Delete.
165         (struct function_bounds): Move struct within function.
166         (func_command): Most content moved into new function
167         find_frame_for_function, use new function, print result, add
168         function comment.
169         (find_frame_for_function): New function, now returns a result.
170
171 2018-05-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
172
173         * stack.c (iterate_over_block_arg_vars): Fix comment.
174         (print_frame_arg_vars): Pass stream in cb_data, not gdb_stdout.
175
176 2018-05-24  Andrew Burgess  <andrew.burgess@embecosm.com>
177
178         PR gdb/23203
179         * frame.c
180         (scoped_restore_selected_frame::scoped_restore_selected_frame):
181         Define.
182         (scoped_restore_selected_frame::~scoped_restore_selected_frame):
183         Define.
184         * frame.h (class scoped_restore_selected_frame): New class.
185         * stack.c (print_frame_local_vars): Remove catching and rethrowing
186         of any exception, use scoped_restore_selected_frame to restore the
187         frame instead.
188
189 2018-05-24  Pedro Alves  <palves@redhat.com>
190
191         * darwin-nat.h (darwin_nat_target::create_inferior): Mark with
192         override.
193
194 2018-05-23  Tom Tromey  <tom@tromey.com>
195
196         * complaints.c (struct complaints): Remove.
197         (symfile_complaint_book): Remove.
198         (series): New global.
199         (complaint_internal): Update.
200         (clear_complaints): Update.
201
202 2018-05-23  Tom Tromey  <tom@tromey.com>
203
204         * complaints.c (counters): New global.
205         (struct complain): Remove.
206         (struct complaints) <root>: Remove.
207         (complaint_sentinel): Remove.
208         (symfile_complaint_book): Update.
209         (find_complaint) Remove.
210         (complaint_internal, clear_complaints): Update.
211
212 2018-05-23  Tom Tromey  <tom@tromey.com>
213
214         * complaints.c (struct complain) <file, line>: Remove.
215         (find_complaint): Remove file, line parameters.
216         (complaint_internal): Update.
217
218 2018-05-23  Tom Tromey  <tom@tromey.com>
219
220         * complaints.c (vcomplaint): Remove.
221         (complaint_internal) Merge in contents of vcomplaint.
222
223 2018-05-23  Tom Tromey  <tom@tromey.com>
224
225         * complaints.c (struct complaints) <explanation>: Remove.
226         (symfile_explanations): Remove.
227         (symfile_complaint_book): Update.
228         (vcomplaint): Update.
229         (struct explanation): Remove.
230
231 2018-05-23  Tom Tromey  <tom@tromey.com>
232
233         * complaints.c (symfile_complaints): Remove.
234         (complaint_internal): Remove "complaints" parameter.
235         (clear_complaints, vcomplaint): Remove "c" parameter.
236         (get_complaints): Remove.
237         * dwarf2read.c (dwarf2_statement_list_fits_in_line_number_section_complaint)
238         (dwarf2_debug_line_missing_file_complaint)
239         (dwarf2_debug_line_missing_end_sequence_complaint)
240         (dwarf2_complex_location_expr_complaint)
241         (dwarf2_const_value_length_mismatch_complaint)
242         (dwarf2_section_buffer_overflow_complaint)
243         (dwarf2_macro_malformed_definition_complaint)
244         (dwarf2_invalid_attrib_class_complaint)
245         (create_addrmap_from_index, dw2_symtab_iter_next)
246         (dw2_expand_marked_cus)
247         (dw2_debug_names_iterator::find_vec_in_debug_names)
248         (dw2_debug_names_iterator::next, dw2_debug_names_iterator::next)
249         (create_debug_type_hash_table, init_cutu_and_read_dies)
250         (partial_die_parent_scope, add_partial_enumeration)
251         (skip_one_die, fixup_go_packaging, quirk_rust_enum, process_die)
252         (dwarf2_compute_name, dwarf2_physname, read_namespace_alias)
253         (read_import_statement, read_file_scope, create_dwo_cu_reader)
254         (create_cus_hash_table, create_dwp_hash_table)
255         (inherit_abstract_dies, read_func_scope, read_call_site_scope)
256         (dwarf2_rnglists_process, dwarf2_ranges_process)
257         (dwarf2_add_type_defn, dwarf2_attach_fields_to_type)
258         (dwarf2_add_member_fn, get_alignment, maybe_set_alignment)
259         (handle_struct_member_die, process_structure_scope)
260         (read_array_type, read_common_block, read_module_type)
261         (read_tag_pointer_type, read_typedef, read_base_type)
262         (read_subrange_type, load_partial_dies, partial_die_info::read)
263         (partial_die_info::read, partial_die_info::read)
264         (partial_die_info::read, read_checked_initial_length_and_offset)
265         (dwarf2_string_attr, read_formatted_entries)
266         (dwarf_decode_line_header)
267         (lnp_state_machine::check_line_address, dwarf_decode_lines_1)
268         (new_symbol, dwarf2_const_value_attr, lookup_die_type)
269         (read_type_die_1, determine_prefix, dwarf2_get_ref_die_offset)
270         (dwarf2_get_attr_constant_value, dwarf2_fetch_constant_bytes)
271         (get_signatured_type, get_DW_AT_signature_type)
272         (decode_locdesc, file_file_name, consume_improper_spaces)
273         (skip_form_bytes, skip_unknown_opcode, dwarf_parse_macro_header)
274         (dwarf_decode_macro_bytes, dwarf_decode_macros)
275         (dwarf2_symbol_mark_computed, set_die_type)
276         (read_attribute_value): Update.
277         * stap-probe.c (handle_stap_probe, get_stap_base_address):
278         Update.
279         * dbxread.c (unknown_symtype_complaint)
280         (lbrac_mismatch_complaint, repeated_header_complaint)
281         (set_namestring, function_outside_compilation_unit_complaint)
282         (read_dbx_symtab, process_one_symbol): Update.
283         * gdbtypes.c (stub_noname_complaint): Update.
284         * windows-nat.c (handle_unload_dll): Update.
285         * coffread.c (coff_symtab_read, enter_linenos, decode_type)
286         (decode_base_type): Update.
287         * xcoffread.c (bf_notfound_complaint, ef_complaint)
288         (eb_complaint, record_include_begin, record_include_end)
289         (enter_line_range, xcoff_next_symbol_text, read_xcoff_symtab)
290         (process_xcoff_symbol, read_symbol)
291         (function_outside_compilation_unit_complaint)
292         (scan_xcoff_symtab): Update.
293         * machoread.c (macho_symtab_read, macho_add_oso_symfile): Update.
294         * buildsym.c (finish_block_internal, make_blockvector)
295         (end_symtab_get_static_block, augment_type_symtab): Update.
296         * dtrace-probe.c (dtrace_process_dof)
297         (dtrace_static_probe_ops::get_probes): Update.
298         * complaints.h (struct complaint): Don't declare.
299         (symfile_complaints): Remove.
300         (complaint_internal): Remove "complaints" parameter.
301         (complaint): Likewise.
302         (clear_complaints): Likewise.
303         * symfile.c (syms_from_objfile_1, finish_new_objfile)
304         (reread_symbols): Update.
305         * dwarf2-frame.c (dwarf2_restore_rule, execute_cfa_program)
306         (dwarf2_frame_cache, decode_frame_entry): Update.
307         * dwarf2loc.c (dwarf_reg_to_regnum): Update.
308         * objc-lang.c (lookup_objc_class, lookup_child_selector)
309         (info_selectors_command): Update.
310         * macrotab.c (macro_include, check_for_redefinition)
311         (macro_undef): Update.
312         * objfiles.c (filter_overlapping_sections): Update.
313         * stabsread.c (invalid_cpp_abbrev_complaint)
314         (reg_value_complaint, stabs_general_complaint, dbx_lookup_type)
315         (define_symbol, error_type, read_type, rs6000_builtin_type)
316         (stabs_method_name_from_physname, read_member_functions)
317         (read_cpp_abbrev, read_baseclasses, read_tilde_fields)
318         (attach_fields_to_type, complain_about_struct_wipeout)
319         (read_range_type, read_args, common_block_start)
320         (common_block_end, cleanup_undefined_types_1, scan_file_globals):
321         Update.
322         * mdebugread.c (index_complaint, unknown_ext_complaint)
323         (basic_type_complaint, bad_tag_guess_complaint)
324         (bad_rfd_entry_complaint, unexpected_type_code_complaint)
325         (reg_value_complaint, parse_symbol, parse_type, upgrade_type)
326         (parse_procedure, parse_lines)
327         (function_outside_compilation_unit_complaint)
328         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref)
329         (bad_tag_guess_complaint, reg_value_complaint): Update.
330         * cp-support.c (demangled_name_complaint): Update.
331         * macroscope.c (sal_macro_scope): Update.
332         * dwarf-index-write.c (class debug_names): Update.
333
334 2018-05-23  Tom Tromey  <tom@tromey.com>
335
336         * complaints.c (clear_complaints): Remove "noisy" parameter.
337         * complaints.h (clear_complaints): Update.
338         * symfile.c (syms_from_objfile_1, finish_new_objfile)
339         (reread_symbols): Update.
340
341 2018-05-23  Tom Tromey  <tom@tromey.com>
342
343         * complaints.c (enum complaint_series): Remove FIRST_MESSAGE,
344         SUBSEQUENT_MESSAGE.
345         (vcomplaint, clear_complaints): Update.
346         (symfile_explanations): Remove some messages.
347
348 2018-05-23  Tom Tromey  <tom@tromey.com>
349
350         * complaints.c (internal_complaint): Remove.
351         * complaints.h (internal_complaint): Remove.
352
353 2018-05-22  Maciej W. Rozycki  <macro@mips.com>
354
355         * i387-tdep.c (i387_collect_xsave): Make `i' unsigned.
356
357 2018-05-22  Pedro Alves  <palves@redhat.com>
358
359         * remote-fileio.c (remote_fileio_reply, remote_fileio_ioerror)
360         (remote_fileio_badfd, remote_fileio_return_errno)
361         (remote_fileio_return_success, remote_fileio_func_open)
362         (remote_fileio_func_open, remote_fileio_func_close)
363         (remote_fileio_func_read, remote_fileio_func_write)
364         (remote_fileio_func_lseek, remote_fileio_func_rename)
365         (remote_fileio_func_unlink, remote_fileio_func_stat)
366         (remote_fileio_func_fstat, remote_fileio_func_gettimeofday)
367         (remote_fileio_func_isatty, remote_fileio_func_system): Add
368         remote_target parameter.
369         (remote_fio_func_map) <func>: Add remote_target parameter.
370         (do_remote_fileio_request, remote_fileio_request):
371         * remote-fileio.h (remote_fileio_request):
372         * remote-notif.c (remote_notif_ack, remote_notif_parse, ): Add
373         remote_target parameter.
374         (remote_notif_process, handle_notification): Adjust to pass down
375         the remote.
376         (remote_notif_state_allocate): Add remote_target parameter.  Save
377         it.
378         * remote-notif.h (struct remote_target): Forward declare.
379         (struct notif_client) <parse, ack, can_get_pending_events>: Add
380         remote_target parameter.
381         (struct remote_notif_state) <remote>: New field.
382         (remote_notif_ack, remote_notif_parse): Add remote_target
383         parameter.
384         (remote_notif_state_allocate, remote_notif_state_allocate): Add
385         remote_target parameter.
386         * remote.c (OPAQUETHREADBYTES, threadref, gdb_ext_thread_info)
387         (threads_listing_context, rmt_thread_action, protocol_feature)
388         (packet_reg, stop_reply, stop_reply_p, enum packet_support)
389         (packet_result, struct threads_listing_context, remote_state):
390         Move definitions and declarations higher up.
391         (remote_target) <~remote_target>: Declare.
392         (remote_download_command_source, remote_file_put, remote_file_get)
393         (remote_file_delete, remote_hostio_pread, remote_hostio_pwrite)
394         (remote_hostio_pread_vFile, remote_hostio_send_command)
395         (remote_hostio_set_filesystem, remote_hostio_open)
396         (remote_hostio_close, remote_hostio_unlink, remote_state)
397         (get_remote_state, get_remote_packet_size, get_memory_packet_size)
398         (get_memory_write_packet_size, get_memory_read_packet_size)
399         (append_pending_thread_resumptions, remote_detach_1)
400         (append_resumption, remote_resume_with_vcont)
401         (add_current_inferior_and_thread, wait_ns, wait_as)
402         (process_stop_reply, remote_notice_new_inferior)
403         (process_initial_stop_replies, remote_add_thread)
404         (btrace_sync_conf, remote_btrace_maybe_reopen)
405         (remove_new_fork_children, kill_new_fork_children)
406         (discard_pending_stop_replies, stop_reply_queue_length)
407         (check_pending_events_prevent_wildcard_vcont)
408         (discard_pending_stop_replies_in_queue, stop_reply)
409         (remote_notif_remove_queued_reply, stop_reply *queued_stop_reply)
410         (peek_stop_reply, remote_parse_stop_reply, remote_stop_ns)
411         (remote_interrupt_as, remote_interrupt_ns)
412         (remote_get_noisy_reply, remote_query_attached)
413         (remote_add_inferior, remote_current_thread, get_current_thread)
414         (set_thread, set_general_thread, set_continue_thread)
415         (set_general_process, write_ptid)
416         (remote_unpack_thread_info_response, remote_get_threadinfo)
417         (parse_threadlist_response, remote_get_threadlist)
418         (remote_threadlist_iterator, remote_get_threads_with_ql)
419         (remote_get_threads_with_qxfer)
420         (remote_get_threads_with_qthreadinfo, extended_remote_restart)
421         (get_offsets, remote_check_symbols, remote_supported_packet)
422         (remote_query_supported, remote_packet_size)
423         (remote_serial_quit_handler, remote_detach_pid)
424         (remote_vcont_probe, remote_resume_with_hc)
425         (send_interrupt_sequence, interrupt_query)
426         (remote_notif_get_pending_events, fetch_register_using_p)
427         (send_g_packet, process_g_packet, fetch_registers_using_g)
428         (store_register_using_P, store_registers_using_G)
429         (set_remote_traceframe, check_binary_download)
430         (remote_write_bytes_aux, remote_write_bytes, remote_read_bytes_1)
431         (remote_xfer_live_readonly_partial, remote_read_bytes)
432         (remote_send_printf, remote_flash_write, readchar)
433         (remote_serial_write, putpkt, putpkt_binary, skip_frame)
434         (read_frame, getpkt, getpkt_or_notif_sane_1, getpkt_sane)
435         (getpkt_or_notif_sane, remote_vkill, remote_kill_k)
436         (extended_remote_disable_randomization, extended_remote_run)
437         (send_environment_packet, extended_remote_environment_support)
438         (extended_remote_set_inferior_cwd, remote_write_qxfer)
439         (remote_read_qxfer, push_stop_reply, vcont_r_supported)
440         (packet_command): Now methods of ...
441         (remote_target): ... this class.
442         (m_remote_state) <remote_target>: New field.
443         (struct remote_state) <stop_reply_queue,
444         remote_async_inferior_event_token, wait_forever_enabled_p>: New
445         fields.
446         (remote_state::remote_state): Allocate stop_reply_queue.
447         (remote_state): Delete global.
448         (get_remote_state_raw): Delete.
449         (remote_target::get_remote_state): Allocate m_remote_state on
450         demand.
451         (get_current_remote_target): New.
452         (remote_ops, extended_remote_ops): Delete.
453         (wait_forever_enabled_p, remote_async_inferior_event_token):
454         Delete, moved to struct remote_state.
455         (remote_target::close): Delete self.  Destruction bits split to
456         ...
457         (remote_target::~remote_target): ... this.
458         (show_memory_packet_size): Adjust to use
459         get_current_remote_target.
460         (struct protocol_feature) <func>: Add remote_target parameter.
461         All callers adjusted.
462         (curr_quit_handler_target): New.
463         (remote_serial_quit_handler): Reimplement.
464         (remote_target::open_1): Adjust to use get_current_remote_target.
465         Heap-allocate remote_target/extended_remote_target instances.
466         (vcont_builder::vcont_builder): Add remote_target parameter, and
467         save it in m_remote.  All callers adjusted.
468         (vcont_builder::m_remote): New field.
469         (vcont_builder::restart, vcont_builder::flush)
470         (vcont_builder::push_action): Use it.
471         (remote_target::commit_resume): Use it.
472         (struct queue_iter_param) <remote>: New field.
473         (remote_target::remove_new_fork_children): Fill in 'remote' field.
474         (check_pending_event_prevents_wildcard_vcont_callback_data): New.
475         (check_pending_event_prevents_wildcard_vcont_callback)
476         (remote_target::check_pending_events_prevent_wildcard_vcont)
477         (remote_target::discard_pending_stop_replies)
478         (remote_target::discard_pending_stop_replies_in_queue)
479         (remote_target::remote_notif_remove_queued_reply): Fill in
480         'remote' field.
481         (remote_notif_get_pending_events): New.
482         (remote_target::readchar, remote_target::remote_serial_write):
483         Save/restore curr_quit_handler_target.
484         (putpkt): New.
485         (kill_new_fork_children): Fill in 'remote' field.
486         (packet_command): Use get_current_remote_target, defer to
487         remote_target method of same name.
488         (scoped_remote_fd::scoped_remote_fd): Add 'remote_target'
489         parameter, and save it in m_remote.  All callers adjusted.
490         (scoped_remote_fd::release): Use m_remote.
491         (scoped_remote_fd::m_remote): New field.
492         (remote_file_put, remote_file_get, remote_file_delete): Use
493         get_current_remote_target, defer to remote_target method of same
494         name.
495         (remote_btrace_reset): Add remote_state paremeter.  Update all
496         callers.
497         (remote_async_inferior_event_handler). Pass down 'data'.
498         (remote_new_objfile): Use get_current_remote_target.
499         (remote_target::vcont_r_supported): New.
500         (set_range_stepping): Use get_current_remote_target and
501         remote_target::vcont_r_supported.
502         (_initialize_remote): Don't allocate 'remote_state' and
503         'stop_reply_queue' globals.
504         * remote.h (struct remote_target): Forward declare.
505         (getpkt, putpkt, remote_notif_get_pending_events): Add
506         'remote_target' parameter.
507
508 2018-05-22  Pedro Alves  <palves@redhat.com>
509
510         * remote.c (vcont_builder): Now a class.  Make all data members
511         private.
512         (vcont_builder) <vcont_builder, restart, flush, push_action>:
513         Declare methods.
514         (vcont_builder_restart): Rename to ...
515         (vcont_builder::restart): ... this.
516         (vcont_builder_flush): Rename to ...
517         (vcont_builder::flush): ... this.
518         (vcont_builder_push_action): Rename to ...
519         (vcont_builder::push_action): ... this.
520         (remote_target::commit_resume): Adjust.
521
522 2018-05-22  Pedro Alves  <palves@redhat.com>
523
524         * remote.c (DEFAULT_MAX_MEMORY_PACKET_SIZE): Rename to ...
525         (DEFAULT_MAX_MEMORY_PACKET_SIZE_FIXED): ... this.
526         (get_fixed_memory_packet_size): New.
527         (get_memory_packet_size): Use it.
528         (set_memory_packet_size): Don't override the config size with
529         DEFAULT_MAX_MEMORY_PACKET_SIZE.
530         (show_memory_packet_size): Use get_fixed_memory_packet_size.
531         Don't refer to get_memory_packet_size if not connected to a remote
532         target.  Show "(default)" if configured size is 0.
533
534 2018-05-22  Pedro Alves  <palves@redhat.com>
535
536         * remote.c (remote_target::mourn_inferior): Move
537         discard_pending_stop_replies call here from ...
538         (_initialize_remote): ... here.
539
540 2018-05-22  Pedro Alves  <palves@redhat.com>
541
542         * remote.c (compare_section_command): Remove set_general_process
543         call.
544
545 2018-05-22  Pedro Alves  <palves@redhat.com>
546
547         * remote.c (struct packet_reg, struct remote_arch_state):
548         Move higher up in the file.
549         (remote_state) <m_arch_states>: Store remote_arch_state values
550         instead of remote_arch_state pointers.
551         (remote_state::get_remote_arch_state): Adjust.
552
553 2018-05-22  Pedro Alves  <palves@redhat.com>
554
555         * remote.c: Include <unordered_map>.
556         (remote_state): Now a class.
557         (remote_state) <get_remote_arch_state>: Declare method.
558         <get_remote_arch_state>: New field.
559         (remote_arch_state) <remote_arch_state>: Declare ctor.
560         <regs>: Now a unique_ptr.
561         (remote_gdbarch_data_handle): Delete.
562         (get_remote_arch_state): Delete.
563         (remote_state::get_remote_arch_state): New.
564         (get_remote_state): Adjust to call remote_state's
565         get_remote_arch_state method.
566         (init_remote_state): Delete, bits factored out to ...
567         (remote_arch_state::remote_arch_state): ... this new method.
568         (get_remote_packet_size, get_memory_packet_size)
569         (process_g_packet, remote_target::fetch_registers)
570         (remote_target::prepare_to_store, store_registers_using_G)
571         (remote_target::store_registers, remote_target::get_trace_status):
572         Adjust to call remote_state's method.
573         (_initialize_remote): Remove reference to
574         remote_gdbarch_data_handle.
575
576 2018-05-22  Pedro Alves  <palves@redhat.com>
577
578         * remote.c (struct readahead_cache) <invalidate, invalidate_fd,
579         pread>: New method declarations.
580         (remote_target::open_1): Adjust.
581         (readahead_cache_invalidate): Rename to ...
582         (readahead_cache::invalidate): ... this, and adjust to be a class
583         method.
584         (readahead_cache_invalidate_fd): Rename to ...
585         (readahead_cache::invalidate_fd): ... this, and adjust to be a
586         class method.
587         (remote_hostio_pwrite): Adjust.
588         (remote_hostio_pread_from_cache): Rename to ...
589         (readahead_cache::pread): ... this, and adjust to be a class
590         method.
591         (remote_hostio_close): Adjust.
592
593 2018-05-22  Pedro Alves  <palves@redhat.com>
594
595         * remote.c (remote_hostio_close_cleanup): Delete.
596         (class scoped_remote_fd): New.
597         (remote_file_put, remote_file_get): Use it.
598
599 2018-05-22  Pedro Alves  <palves@redhat.com>
600
601         (struct vCont_action_support): Use bool and initialize all fields.
602         (struct readahead_cache): Initialize all fields.
603         (remote_state): Use bool and initialize all fields.
604         (remote_state::remote_state, remote_state::~remote_state): New.
605         (new_remote_state): Delete.
606         (_initialize_remote): Use new to allocate remote_state.
607
608 2018-05-22  Pedro Alves  <palves@redhat.com>
609             張俊芝  <zjz@zjz.name>
610
611         PR gdb/22973
612         * c-exp.y: Include "c-support.h".
613         (parse_number, c_parse_escape, lex_one_token): Use TOLOWER instead
614         of tolower.  Use c_ident_is_alpha to scan names.
615         * c-lang.c: Include "c-support.h".
616         (convert_ucn, convert_octal, convert_hex, convert_escape): Use
617         ISXDIGIT instead of isxdigit and ISDIGIT instead of isdigit.
618         * c-support.h: New file, with bits factored out from ...
619         * cp-name-parser.y: ... this file.
620         Include "c-support.h".
621         (cp_ident_is_alpha, cp_ident_is_alnum): Deleted, moved to
622         c-support.h and renamed.
623         (symbol_end, yylex): Adjust.
624
625 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
626
627         * arch/ppc-linux-common.c (ppc_linux_has_isa205): Change the
628         parameter type to CORE_ADDR.
629         * arch/ppc-linux-common.h (ppc_linux_has_isa205): Change the
630         parameter type in declaration to CORE_ADDR.
631         * ppc-linux-tdep.c (ppc_linux_core_read_description): Call
632         target_auxv_search to get AT_HWCAP and use the result to get the
633         target description.
634         * ppc-linux-nat.c (ppc_linux_get_hwcap): Change the return type
635         to CORE_ADDR. Remove the cast of the return value to unsigned
636         long. Fix error predicate of target_auxv_search.
637         (ppc_linux_nat_target::read_description): Change the type of the
638         hwcap variable to CORE_ADDR.
639
640 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
641
642         * rs6000-tdep.c (rs6000_gdbarch_init): Assign 1 to have_dfp only
643         if the size of fpscr is larger than 32 bits.
644
645 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
646
647         * ppc-linux-tdep.c (ppc_linux_vsxregset): New function.
648         (ppc32_linux_vsxregmap): New global.
649         (ppc32_linux_vsxregset): Initialize with ppc32_linux_vsxregmap,
650         regcache_supply_regset, and regcache_collect_regset.
651         * ppc-linux-tdep.h (ppc_linux_vsxregset): Declare.
652         * ppc-linux-nat.c (supply_vsxregset, fill_vsxregset): Remove.
653         (fetch_vsx_register, store_vsx_register): Remove.
654         (fetch_vsx_registers): Add regno parameter. Get regset using
655         ppc_linux_vsxregset. Use regset to supply registers.
656         (store_vsx_registers): Add regno parameter. Get regset using
657         ppc_linux_vsxregset. Use regset to collect registers.
658         (fetch_register): Call fetch_vsx_registers instead of
659         fetch_vsx_register.
660         (store_register): Call store_vsx_registers instead of
661         store_vsx_register.
662         (fetch_ppc_registers): Call fetch_vsx_registers with -1 for the
663         new regno parameter.
664         (store_ppc_registers): Call store_vsx_registers with -1 for the
665         new regno parameter.
666         * rs6000-tdep.c (ppc_vsx_support_p, ppc_supply_vsxreget)
667         (ppc_collect_vsxregset): Remove.
668
669 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
670
671         * ppc-tdep.h (struct ppc_reg_offsets): Remove vector register
672         offset fields.
673         * ppc-fbsd-tdep.c (ppc32_fbsd_reg_offsets): Remove initializers
674         for vector register offset fields.
675         (ppc64_fbsd_reg_offsets): Likewise.
676         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment
677         to vector register offset fields.
678         * ppc-obsd-tdep.c (_initialize_ppcnbsd_tdep): Remove assignment
679         to vector register offset fields.
680         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Remove assignment to
681         vector register offset fields.
682         * rs6000-aix-tdep.c (rs6000_aix32_reg_offsets): Remove
683         initializers for vector register offset fields.
684         (rs6000_aix64_reg_offsets): Likewise.
685         * rs6000-tdep.c (ppc_vrreg_offset): Remove.
686         (ppc_supply_vrregset): Remove.
687         (ppc_collect_vrregset): Remove.
688         * ppc-linux-tdep.c (ppc_linux_collect_vrregset): New function.
689         (ppc_linux_vrregset) : New function.
690         (ppc32_le_linux_vrregmap, ppc32_be_linux_vrregmap)
691         (ppc32_le_linux_vrregset, ppc32_be_linux_vrregset): New globals.
692         (ppc32_linux_vrregset): Remove.
693         (ppc_linux_iterate_over_regset_sections): Call ppc_linux_vrregset
694         and use result instead of ppc32_linux_vrregset.
695         (ppc32_linux_reg_offsets): Remove initializers for vector register
696         offset fields.
697         (ppc64_linux_reg_offsets): Likewise.
698         * ppc-linux-tdep.h (ppc_linux_vrregset): New declaration.
699         * ppc-linux-nat.c: Include regset.h.
700         (gdb_vrregset_t): Adjust comment to account for little-endian
701         mode.
702         (supply_vrregset, fill_vrregset): Remove.
703         (fetch_altivec_register, store_altivec_register): Remove.
704         (fetch_altivec_registers): Add regno parameter. Get regset using
705         ppc_linux_vrregset. Use regset to supply registers.
706         (store_altivec_registers): Add regno parameter. Get regset using
707         ppc_linux_vrregset. Use regset to collect registers.
708         (fetch_register): Call fetch_altivec_registers instead of
709         fetch_altivec_register.
710         (store_register): Call store_altivec_registers instead of
711         store_altivec_register.
712         (fetch_ppc_registers): Call fetch_altivec_registers with -1 for
713         the new regno parameter.
714         (store_ppc_registers): Call store_altivec_registers with -1 for
715         the new regno parameter.
716
717 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
718
719         * arch/ppc-linux-common.h (PPC_LINUX_SIZEOF_VRREGSET)
720         (PPC_LINUX_SIZEOF_VSXREGSET): Define.
721         * ppc-linux-nat.c (SIZEOF_VSXREGS, SIZEOF_VRREGS): Remove.
722         (gdb_vrregset_t): Change array type size to
723         PPC_LINUX_SIZEOF_VRREGSET.
724         (gdb_vsxregset_t): Change array type size to
725         PPC_LINUX_SIZEOF_VSXREGSET.
726         * ppc-linux-tdep.c (ppc_linux_iterate_over_regset_sections):
727         Change integer literals to PPC_LINUX_SIZEOF_VRREGSET and
728         PPC_LINUX_SIZEOF_VSXREGSET.
729
730 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
731
732         * configure.nat <linux powerpc>: Add ppc-linux.o to NATDEPFILES.
733         * ppc-linux-nat.c (ppc_linux_target_wordsize): Move to
734         nat/ppc-linux.c.
735         (ppc_linux_nat_target::auxv_parse): Get thread id tid. Call
736         ppc_linux_target_wordsize with tid.
737         (ppc_linux_nat_target::read_description): Call ppc_linux_target
738         wordsize with tid.
739         * nat/ppc-linux.c: Include nat/gdb_ptrace.h.
740         (ppc64_64bit_inferior_p): Add static and inline specifiers.
741         (ppc_linux_target_wordsize): Move here from ppc-linux-nat.c. Add
742         tid parameter. Remove static specifier.
743         * nat/ppc-linux.h (ppc64_64bit_inferior_p): Remove declaration.
744         (ppc_linux_target_wordsize): New declaration.
745
746 2018-05-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
747
748         * arch/ppc-linux-common.c: New file.
749         * arch/ppc-linux-common.h: New file.
750         * arch/ppc-linux-tdesc.h: New file.
751         * configure.tgt (powerpc*-*-linux*): Add arch/ppc-linux-common.o.
752         * Makefile.in (ALL_TARGET_OBS): Add arch/ppc-linux-common.o.
753         (HFILES_NO_SRCDIR): Add arch/ppc-linux-common.h and
754         arch/ppc-linux-tdesc.h.
755         * ppc-linux-nat.c: Include arch/ppc-linux-common.h and
756         arch/ppc-linux-tdesc.h.
757         (ppc_linux_nat_target::read_description): Remove target
758         description matching code. Fill a ppc_linux_features struct and
759         call ppc_linux_match_description with it. Move comment about ISA
760         2.05 to ppc-linux-common.c.
761         * ppc-linux-tdep.c: Include arch/ppc-linux-common.h and
762         arch/ppc-linux-tdesc.h.
763         (ppc_linux_core_read_description): Remove target description
764         matching code. Fill a ppc_linux_features struct and call
765         ppc_linux_match_description with it.
766         * ppc-linux-tdep.h (tdesc_powerpc_32l, tdesc_powerpc_64l)
767         (tdesc_powerpc_altivec32l, tdesc_powerpc_altivec64l)
768         (tdesc_powerpc_cell32l, tdesc_powerpc_cell64l)
769         (tdesc_powerpc_vsx32l, tdesc_powerpc_vsx64l)
770         (tdesc_powerpc_isa205_32l, tdesc_powerpc_isa205_64l)
771         (tdesc_powerpc_isa205_altivec32l, tdesc_powerpc_isa205_altivec64l)
772         (tdesc_powerpc_isa205_vsx32l, tdesc_powerpc_isa205_vsx64l)
773         (tdesc_powerpc_e500l): Remove.
774
775 2018-05-22  Joel Brobecker  <brobecker@adacore.com>
776
777         * ada-lang.c (catch_assert_command): Pass empty string instead
778         of NULL for excep_string argument.
779
780 2018-05-22  Maciej W. Rozycki  <macro@mips.com>
781
782         * mips-linux-nat.c (mips64_linux_register_addr): Return -1 if
783         the width of the requested register exceeds the width of the
784         `ptrace' data type.
785
786 2018-05-21  Tom Tromey  <tom@tromey.com>
787
788         * printcmd.c (output_command): Remove.
789         (output_command_const): Rename to output_command.
790         * valprint.h (output_command): Rename from output_command_const.
791         * tracepoint.c (trace_dump_actions): Call output_command.
792
793 2018-05-21  Tom Tromey  <tom@tromey.com>
794
795         * mi/mi-cmd-catch.c (mi_cmd_catch_assert)
796         (mi_cmd_catch_exception, mi_cmd_catch_handlers): Update.
797         * ada-lang.h (create_ada_exception_catchpoint): Update.
798         * ada-lang.c (struct ada_catchpoint) <excep_string>: Now a
799         std::string.
800         (create_excep_cond_exprs, ~ada_catchpoint)
801         (should_stop_exception, print_one_exception)
802         (print_mention_exception, print_recreate_exception): Update.
803         (ada_get_next_arg): Remove.
804         (catch_ada_exception_command_split): Use std::string.  Change type
805         of "excep_string", "cond_string".
806         (catch_ada_exception_command): Update.
807         (create_ada_exception_catchpoint): Change type of excep_string.
808         (ada_exception_sal): Remove excep_string parameter.
809         (~ada_catchpoint): Remove.
810
811 2018-05-21  Tom Tromey  <tom@tromey.com>
812
813         * ada-lang.c (ada_collect_symbol_completion_matches): Remove
814         cleanup.
815
816 2018-05-21  Tom Tromey  <tom@tromey.com>
817
818         * ada-lang.c (ada_exception_message_1, ada_exception_message):
819         Return unique_xmalloc_ptr.
820         (print_it_exception): Update.
821
822 2018-05-21  Tom Tromey  <tom@tromey.com>
823
824         * tracepoint.c (trace_dump_actions): Use std::string.
825
826 2018-05-21  Tom Tromey  <tom@tromey.com>
827
828         * symfile.c (reread_symbols): Use std::string for original_name.
829
830 2018-05-21  Tom Tromey  <tom@tromey.com>
831
832         * dwarf2read.c (dwarf2_read_debug_names): Use std::unique_ptr.
833         (mapped_index_base): Use DISABLE_COPY_AND_ASSIGN.  Default
834         constructor.
835
836 2018-05-20  Simon Marchi  <simon.marchi@polymtl.ca>
837
838         * common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Rename the wrong
839         instance to...
840         (HAVE_IS_TRIVIALLY_CONSTRUCTIBLE): ... this.
841         * objfiles.c (get_objfile_bfd_data): Allocate
842         objfile_per_bfd_storage with obstack_new when allocating on
843         obstack.
844
845 2018-05-20  Simon Marchi  <simon.marchi@ericsson.com>
846
847         * ada-lang.c (cache_symbol): Use XOBNEW and/or XOBNEWVEC and/or
848         OBSTACK_ZALLOC.
849         * dwarf2-frame.c (dwarf2_build_frame_info): Likewise.
850         * hppa-tdep.c (hppa_init_objfile_priv_data): Likewise.
851         * mdebugread.c (mdebug_build_psymtabs): Likewise.
852         (add_pending): Likewise.
853         (parse_symbol): Likewise.
854         (parse_partial_symbols): Likewise.
855         (psymtab_to_symtab_1): Likewise.
856         (new_psymtab): Likewise.
857         (elfmdebug_build_psymtabs): Likewise.
858         * minsyms.c (terminate_minimal_symbol_table): Likewise.
859         * objfiles.c (get_objfile_bfd_data): Likewise.
860         (objfile_register_static_link): Likewise.
861         * psymtab.c (allocate_psymtab): Likewise.
862         * stabsread.c (read_member_functions): Likewise.
863         * xcoffread.c (xcoff_end_psymtab): Likewise.
864
865 2018-05-20  Simon Marchi  <simon.marchi@ericsson.com>
866
867         * common/traits.h (HAVE_IS_TRIVIALLY_COPYABLE): Define if
868         compiler supports std::is_trivially_constructible.
869         * common/poison.h: Include obstack.h.
870         (IsMallocable): Define to is_trivially_constructible if the
871         compiler supports it, define to true_type otherwise.
872         (xobnew): New.
873         (XOBNEW): Redefine.
874         (xobnewvec): New.
875         (XOBNEWVEC): Redefine.
876         * gdb_obstack.h (obstack_zalloc): New.
877         (OBSTACK_ZALLOC): Redefine.
878         (obstack_calloc): New.
879         (OBSTACK_CALLOC): Redefine.
880         (obstack_new): New.
881         * gdbarch.sh: Include gdb_obstack in gdbarch.h.
882         (gdbarch_obstack): New declaration in gdbarch.h, definition in
883         gdbarch.c.
884         (GDBARCH_OBSTACK_CALLOC, GDBARCH_OBSTACK_ZALLOC): Use
885         obstack_calloc/obstack_zalloc.
886         (gdbarch_obstack_zalloc): Remove.
887         * target-descriptions.c (tdesc_data_init): Use obstack_new.
888
889 2018-05-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
890
891         * stack.c (backtrace_command_1): Remove useless variable int i.
892
893 2018-05-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
894
895         * stack.c (print_frame_info): Fix comment.
896
897 2018-05-18  Tom Tromey  <tom@tromey.com>
898
899         * dwarf2read.c (struct dwz_file): Add constructor, initializers.
900         <dwz_bfd>: Now a gdb_bfd_ref_ptr.
901         (~dwarf2_per_objfile): Update
902         (dwarf2_get_dwz_file): Use new.
903         * dwarf2read.h (struct dwarf2_per_objfile) <dwz_file>: Now a
904         unique_ptr.
905
906 2018-05-18  Tom Tromey  <tom@tromey.com>
907
908         * dwarf2read.h (struct dwarf2_per_objfile) <dwp_file>: Now a
909         unique_ptr.
910         * dwarf2read.c (struct dwp_file): Add constructor and
911         initializers.
912         (open_and_init_dwp_file): Return a unique_ptr.
913         (dwarf2_per_objfile, create_dwp_hash_table)
914         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2)
915         (lookup_dwo_unit_in_dwp): Update.
916         (open_and_init_dwp_file, get_dwp_file): Update.
917
918 2018-05-18  Tom Tromey  <tom@tromey.com>
919
920         * dwarf2read.c (dwarf2_per_objfile): Update.
921         (struct mapped_index): Add initializers.
922         (dwarf2_read_index): Use new.
923         (dw2_symtab_iter_init): Update.
924         * dwarf2read.h (struct dwarf2_per_objfile) <index_table>: Now a
925         unique_ptr.
926
927 2018-05-18  Simon Marchi  <simon.marchi@ericsson.com>
928
929         * dwarf2read.c (mapped_index) <total_size>: Remove.
930
931 2018-05-18  Simon Marchi  <simon.marchi@ericsson.com>
932
933         * unittests/format_pieces-selftests.c (test_format_specifier):
934         Add ARI comments.
935
936 2018-05-18  Tom Tromey  <tom@tromey.com>
937
938         * c-typeprint.c (maybe_print_hole): New function.
939         (c_print_type_struct_field_offset): Update.
940         (c_type_print_base_struct_union): Call maybe_print_hole.
941
942 2018-05-17  Keith Seitz  <keiths@redhat.com>
943
944         * breakpoint.c (build_bpstat_chain): New function, moved from
945         bpstat_stop_status.
946         (bpstat_stop_status): Add optional parameter, `stop_chain'.
947         If no stop chain is passed, call build_bpstat_chain to build it.
948         * breakpoint.h (build_bpstat_chain): Declare.
949         (bpstat_stop_status): Move documentation here from breakpoint.c.
950         * infrun.c (handle_signal_stop): Before eliding inlined frames,
951         build the stop chain and pass it to skip_inline_frames.
952         Pass this stop chain to bpstat_stop_status.
953         * inline-frame.c: Include breakpoint.h.
954         (stopped_by_user_bp_inline_frame): New function.
955         (skip_inline_frames): Add parameter `stop_chain'.
956         Move documention to inline-frame.h.
957         If non-NULL, use stopped_by_user_bp_inline_frame to determine
958         whether the frame should be elided.
959         * inline-frame.h (skip_inline_frames): Add parameter `stop_chain'.
960         Add moved documentation and update for new parameter.
961
962 2018-05-17  Simon Marchi  <simon.marchi@ericsson.com>
963
964         PR cli/14975
965         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
966         unittests/format_pieces-selftests.c.
967         * common/format.h (format_piece) <operator==>: New.
968         (format_pieces) <operator[]>: Remove.
969         * common/format.c (format_pieces::format_pieces): Handle \e.
970         * unittests/format_pieces-selftests.c: New.
971
972 2018-05-17  Tom Tromey  <tom@tromey.com>
973
974         PR symtab/23010:
975         * dwarf2read.c (load_cu, dw2_do_instantiate_symtab)
976         (dw2_instantiate_symtab): Add skip_partial parameter.
977         (dw2_find_last_source_symtab, dw2_map_expand_apply)
978         (dw2_lookup_symbol, dw2_expand_symtabs_for_function)
979         (dw2_expand_all_symtabs, dw2_expand_symtabs_with_fullname)
980         (dw2_expand_symtabs_matching_one)
981         (dw2_find_pc_sect_compunit_symtab)
982         (dw2_debug_names_lookup_symbol)
983         (dw2_debug_names_expand_symtabs_for_function): Update.
984         (init_cutu_and_read_dies): Add skip_partial parameter.
985         (process_psymtab_comp_unit, build_type_psymtabs_1)
986         (process_skeletonless_type_unit, load_partial_comp_unit)
987         (psymtab_to_symtab_1): Update.
988         (load_full_comp_unit): Add skip_partial parameter.
989         (process_imported_unit_die, dwarf2_read_addr_index)
990         (follow_die_offset, dwarf2_fetch_die_loc_sect_off)
991         (dwarf2_fetch_constant_bytes, dwarf2_fetch_die_type_sect_off)
992         (read_signatured_type): Update.
993
994 2018-05-17  Simon Marchi  <simon.marchi@ericsson.com>
995
996         * value.c (release_value): Remove unused variable.
997         (record_latest_value): Likewise.
998         (access_value_history): Likewise.
999         (preserve_values): Likewise.
1000
1001 2018-05-17  Tom Tromey  <tom@tromey.com>
1002
1003         * extension.h (struct ext_lang_type_printers) <py_type_printers>:
1004         Initialize.
1005
1006 2018-05-16  Maciej W. Rozycki  <macro@mips.com>
1007
1008         PR gdb/22286
1009         * linux-nat-trad.c (linux_nat_trad_target::fetch_register):
1010         Also handle registers whose width is not a multiple of
1011         PTRACE_TYPE_RET.
1012         (linux_nat_trad_target::store_register): Likewise.
1013
1014 2018-05-16  Tom Tromey  <tom@tromey.com>
1015
1016         * gdbcore.h (core_bfd): Redefine.
1017         * corelow.c (core_target::close): Update.
1018         (core_target_open): Update.
1019         * progspace.h (struct program_space) <cbfd>: Now a
1020         gdb_bfd_ref_ptr.
1021
1022 2018-05-16  Tom Tromey  <tom@tromey.com>
1023
1024         PR cli/19551:
1025         * symfile-add-flags.h (enum symfile_add_flags)
1026         <SYMFILE_NOT_FILENAME>: New constant.
1027         * symfile.c (read_symbols): Use SYMFILE_NOT_FILENAME.  Get
1028         objfile name from BFD.
1029         (symbol_file_add_with_addrs): Check SYMFILE_NOT_FILENAME.
1030         * minidebug.c (find_separate_debug_file_in_section): Put
1031         ".gnu_debugdata" into BFD's file name.
1032
1033 2018-05-16  Simon Marchi  <simon.marchi@ericsson.com>
1034
1035         * regcache.c (regcache_read_ftype, regcache_write_ftype):
1036         Remove.
1037
1038 2018-05-15  Tamar Christina  <tamar.christina@arm.com>
1039
1040         PR binutils/21446
1041         * aarch64-tdep.c (aarch64_analyze_prologue,
1042         aarch64_software_single_step, aarch64_displaced_step_copy_insn):
1043         Indicate not interested in errors.
1044
1045 2018-05-15  Maciej W. Rozycki  <macro@mips.com>
1046
1047         * mips-linux-nat.c (mips_linux_nat_target::fetch_registers):
1048         Supply the MIPS_ZERO_REGNUM register.
1049
1050 2018-05-15  Maciej W. Rozycki  <macro@mips.com>
1051
1052         * mips-tdep.c (mask_address_var): Make variable static.
1053
1054 2018-05-14  Tom Tromey  <tom@tromey.com>
1055
1056         * dwarf2read.c (rust_union_quirks): Clear rust_unions.
1057
1058 2018-05-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1059
1060         * i387-tdep.c (i387_collect_xsave): Use FXSAVE_MXCSR_ADDR not
1061         FXSAVE_ADDR for the mxcsr register.
1062
1063 2018-05-11  Max Filippov  <jcmvbkbc@gmail.com>
1064
1065         * configure.tgt (xtensa*-*-linux*): Drop gdb_target definition.
1066
1067 2018-05-11  Pedro Alves  <palves@redhat.com>
1068
1069         * corelow.c (core_target) <core_target>: No longer inline.
1070         Initialize m_core_gdbarch, m_core_vec and build the section table
1071         here.
1072         <~core_target>: New.
1073         <core_gdbarch, get_core_register_section>: New methods.
1074         <m_core_section_table, m_core_vec, m_core_gdbarch>: New fields,
1075         factored out from ...
1076         <core_data, core_vec, core_gdbarch>: ... these deleted globals.
1077         (core_ops): Delete.
1078         (sniff_core_bfd): Add gdbarch parameter.
1079         (core_close): Delete, merged into ...
1080         (core_target::close): ... here.  Delete self.
1081         (core_close_cleanup): Delete.
1082         (core_target_open): Allocate a core_target on the heap.  Use a
1083         unique_ptr instead of a cleanup.  Bits moved into the core_target
1084         ctor.  Adjust to use core_target methods instead of globals.
1085         (get_core_register_section): Rename to ...
1086         (core_target::get_core_register_section): ... this and adjust.
1087         (struct get_core_registers_cb_data): New.
1088         (get_core_registers_cb): Use it.  Use bool.
1089         (core_target::fetch_registers, core_target::files_info)
1090         (core_target::xfer_partial, core_target::read_description)
1091         (core_target::pid_to, core_target::thread_name): Adjust to
1092         reference class fields instead of globals.
1093         * target.h (struct target_ops_deleter, target_ops_up): New.
1094
1095 2018-05-11  Pedro Alves  <palves@redhat.com>
1096
1097         * corefile.c (core_file_command): Move to corelow.c.
1098         * corelow.c (the_core_target): Delete.
1099         (core_file_command): Moved from corefile.c.  Check exec_bfd
1100         instead of the_core_target.  Use target_detach instead of calling
1101         into the_core_target directly.
1102         (maybe_say_no_core_file_now): New.
1103         (core_target::detach): Use it.
1104         (_initialize_corelow): Remove references to the_core_target.
1105         * gdbcore.h (the_core_target): Delete.
1106
1107 2018-05-11  Tom Tromey  <tromey@redhat.com>
1108             Pedro Alves  <palves@redhat.com>
1109
1110         * corefile.c (core_bfd): Remove.
1111         * gdbcore.h (core_bfd): Now a macro.
1112         * progspace.h (struct program_space) <cbfd>: New field.
1113
1114 2018-05-11  Tom Tromey  <tom@tromey.com>
1115
1116         * mdebugread.c (parse_partial_symbols, psymtab_to_symtab_1): Use
1117         gdb::def_vector.
1118
1119 2018-05-10  Tom Tromey  <tom@tromey.com>
1120
1121         * configure: Rebuild.
1122         * warning.m4 (AM_GDB_WARNINGS): Use -Wimplicit-fallthrough=3.
1123
1124 2018-05-10  Joel Brobecker  <brobecker@adacore.com>
1125
1126         PR server/23158:
1127         * regformats/regdat.sh: Adjust script, following the addition
1128         of the new expedite_regs parameter to init_target_desc.
1129
1130 2018-05-10  Omair Javaid  <omair.javaid@linaro.org>
1131     
1132         PR gdb/23127
1133         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Add call to
1134         set_gdbarch_significant_addr_bit.
1135         * aarch64-tdep.c (aarch64_gdbarch_init): Remove call to
1136         set_gdbarch_significant_addr_bit.
1137         * utils.c (address_significant): Update to sign extend addr.
1138
1139 2018-05-09  Max Filippov  <jcmvbkbc@gmail.com>
1140
1141         * xtensa-linux-tdep.c (xtensa-tdep.h): New include.
1142         (xtensa_linux_init_abi): Limit tdep->num_regs by
1143         tdep->num_nopriv_regs.
1144         * xtensa-tdep.c (xtensa_derive_tdep): Calculate
1145         tdep->num_nopriv_regs and only copy it to tdep->num_regs if it's
1146         not initialized.
1147
1148 2018-05-08  Simon Marchi  <simon.marchi@ericsson.com>
1149
1150         * unittests/string_view-selftests.c: Define GNULIB_NAMESPACE.
1151
1152 2018-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1153
1154         * common/x86-xstate.h (I387_FCTRL_INIT_VAL): New constant.
1155         (I387_MXCSR_INIT_VAL): New constant.
1156         * amd64-tdep.c (amd64_supply_xsave): Only read state from xsave
1157         buffer if it was supplied by the inferior.
1158         * i387-tdep.c (i387_supply_fsave): Use I387_MXCSR_INIT_VAL.
1159         (i387_xsave_get_clear_bv): New function.
1160         (i387_supply_xsave): Only read x87 control registers from the
1161         xsave buffer if the feature is enabled, and the state will have
1162         been written, otherwise, provide a suitable default.
1163         (i387_collect_xsave): Pre-clear all registers in xsave buffer,
1164         including x87 control registers.  Update control registers if they
1165         have changed from the default value, and mark features as enabled
1166         as required.
1167         * i387-tdep.h (i387_xsave_get_clear_bv): Declare.
1168
1169 2018-05-08  Ulrich Weigand  <uweigand@de.ibm.com>
1170
1171         * spu-tdep.c (info_spu_event_command): Fix output formatting.
1172
1173 2018-05-07  Tom Tromey  <tom@tromey.com>
1174
1175         * configure: Rebuild.
1176         * warning.m4 (AM_GDB_WARNINGS): Add -Wduplicated-cond.
1177
1178 2018-05-07  Tom Tromey  <tom@tromey.com>
1179
1180         PR tdep/20362:
1181         * arm-tdep.c (arm_record_vfp_data_proc_insn): Properly mask off D
1182         bit.  Use correct value for VDIV.
1183
1184 2018-05-04  Tom Tromey  <tom@tromey.com>
1185
1186         * configure: Rebuild.
1187         * warning.m4 (AM_GDB_WARNINGS): Add -Wimplicit-fallthrough.
1188
1189 2018-05-04  Tom Tromey  <tom@tromey.com>
1190
1191         * linux-record.c (record_linux_system_call) <case
1192         RECORD_SYS_RECVFROM>: Add "break".
1193
1194 2018-05-04  Tom Tromey  <tom@tromey.com>
1195
1196         * mi/mi-main.c (mi_cmd_trace_frame_collected) <REGISTERS_FORMAT>:
1197         Add missing "break".
1198         * mi/mi-cmd-stack.c (mi_cmd_stack_list_locals) <NO_FRAME_FILTERS>:
1199         Add missing "break".
1200
1201 2018-05-04  Tom Tromey  <tom@tromey.com>
1202
1203         * rs6000-tdep.c (ppc_process_record_op4)
1204         (ppc_process_record_op63): Add fall-through comment.
1205
1206 2018-05-04  Tom Tromey  <tom@tromey.com>
1207
1208         * i386-tdep.c (i386_process_record): Add fall-through comment.
1209
1210 2018-05-04  Tom Tromey  <tom@tromey.com>
1211
1212         * stabsread.c (define_symbol) <case 'p'>: Add fall-through
1213         comment.
1214
1215 2018-05-04  Tom Tromey  <tom@tromey.com>
1216
1217         * riscv-tdep.c (riscv_isa_xlen): Add fall-through comment.
1218         * utils.c (can_dump_core) <LIMIT_CUR>: Add fall-through comment.
1219         * eval.c (fetch_subexp_value) <MEMORY_ERROR>: Add fall-through
1220         comment.
1221         * d-valprint.c (d_val_print) <TYPE_CODE_STRUCT>: Add fall-through
1222         comment.
1223         * coffread.c (coff_symtab_read) <C_LABEL>: Add fall-through
1224         comment.
1225
1226 2018-05-04  Tom Tromey  <tom@tromey.com>
1227
1228         * dwarf2loc.c (unimplemented): Add ATTRIBUTE_NORETURN.
1229
1230 2018-05-04  Tom Tromey  <tom@tromey.com>
1231
1232         * s390-tdep.c (s390_process_record): Fix fall-through comments.
1233         * xcoffread.c (scan_xcoff_symtab): Move comment later.
1234         * symfile.c (section_is_mapped): Fix fall-through comment.
1235         * stabsread.c (define_symbol, read_member_functions): Fix
1236         fall-through comment.
1237         * s390-linux-tdep.c (s390_process_record): Fix fall-through
1238         comment.
1239         * remote.c (remote_wait_as): Fix fall-through comment.
1240         * p-exp.y (yylex): Fix fall-through comment.
1241         * nat/x86-dregs.c (x86_length_and_rw_bits): Fix fall-through
1242         comment.
1243         * msp430-tdep.c (msp430_gdbarch_init): Fix fall-through comment.
1244         * mdebugread.c (parse_partial_symbols): Fix fall-through comment.
1245         * jv-exp.y (yylex): Fix fall-through comment.
1246         * go-exp.y (lex_one_token): Fix fall-through comment.
1247         * gdbtypes.c (get_discrete_bounds, rank_one_type): Fix
1248         fall-through comment.
1249         * f-exp.y (yylex): Fix fall-through comment.
1250         * dwarf2read.c (process_die): Fix fall-through comments.
1251         * dbxread.c (process_one_symbol): Fix fall-through comment.
1252         * d-exp.y (lex_one_token): Fix fall-through comment.
1253         * cp-name-parser.y (yylex): Fix fall-through comment.
1254         * coffread.c (coff_symtab_read): Fix fall-through comment.
1255         * c-exp.y (lex_one_token): Fix fall-through comment.
1256         * arm-tdep.c (arm_decode_miscellaneous): Fix fall-through
1257         comment.
1258         * arch/arm.c (arm_instruction_changes_pc): Fix fall-through
1259         comment.
1260
1261 2018-05-04  Tom Tromey  <tom@tromey.com>
1262
1263         PR python/22730:
1264         * NEWS: Mention gdb.execute change.
1265         * gdbcmd.h (execute_control_command): Don't declare.
1266         * python/python.c (execute_gdb_command): Use read_command_lines_1,
1267         execute_control_commands, execute_control_commands_to_string.
1268         * cli/cli-script.h (execute_control_commands)
1269         (execute_control_commands_to_string): Declare.
1270         (execute_control_command): Add from_tty parameter.
1271         * cli/cli-script.c (execute_control_commands)
1272         (execute_control_commands_to_string): New functions.
1273         (execute_user_command): Use execute_control_commands.
1274         (execute_control_command_1): Add "from_tty" parameter.  Update.
1275         (execute_control_command): Likewise.
1276
1277 2018-05-04  Tom Tromey  <tom@tromey.com>
1278
1279         PR python/22731:
1280         * NEWS: Mention that breakpoint commands are writable.
1281         * python/py-breakpoint.c (bppy_set_commands): New function.
1282         (breakpoint_object_getset) <"commands">: Use it.
1283
1284 2018-05-04  Tom Tromey  <tom@tromey.com>
1285
1286         * tracepoint.c (actions_command): Update.
1287         * mi/mi-cmd-break.c (mi_command_line_array)
1288         (mi_command_line_array_cnt, mi_command_line_array_ptr)
1289         (mi_read_next_line): Remove.
1290         (mi_cmd_break_commands): Update.
1291         * cli/cli-script.h (read_command_lines, read_command_lines_1): Use
1292         function_view.
1293         * cli/cli-script.c (get_command_line): Update.
1294         (process_next_line): Use function_view.  Constify.
1295         (recurse_read_control_structure, read_command_lines)
1296         (read_command_lines_1): Change argument types to function_view.
1297         (do_define_command, document_command): Update.
1298         * breakpoint.h (check_tracepoint_command): Don't declare.
1299         * breakpoint.c (check_tracepoint_command): Remove.
1300         (commands_command_1, create_tracepoint_from_upload): Update.
1301
1302 2018-05-04  Tom Tromey  <tom@tromey.com>
1303
1304         PR gdb/11750:
1305         * cli/cli-script.h (enum command_control_type) <define_control>:
1306         New constant.
1307         * cli/cli-script.c (multi_line_command_p): Handle define_control.
1308         (build_command_line, execute_control_command_1)
1309         (process_next_line): Likewise.
1310         (do_define_command): New function, extracted from define_command.
1311         (define_command): Use it.
1312
1313 2018-05-04  Tom Tromey  <tom@tromey.com>
1314
1315         * tracepoint.c (actions_command): Update.
1316         * cli/cli-script.h (read_command_lines): Update.
1317         * cli/cli-script.c (read_command_lines): Constify prompt_arg.
1318         (MAX_TMPBUF): Remove define.
1319         (define_command): Use string_printf.
1320         (document_command): Likewise.
1321         * breakpoint.c (commands_command_1): Update.
1322
1323 2018-05-04  Tom Tromey  <tom@tromey.com>
1324
1325         * top.c (execute_command): Update.
1326         * cli/cli-script.h (print_command_lines): Now varargs.
1327         * cli/cli-script.c (print_command_lines): Now varargs.
1328         (execute_control_command_1) <case while_control, case if_control>:
1329         Update.
1330
1331 2018-05-04  Tom Tromey  <tom@tromey.com>
1332
1333         * tracepoint.c (all_tracepoint_actions): Rename from
1334         all_tracepoint_actions_and_cleanup.  Change return type.
1335         (actions_command, encode_actions_1, encode_actions)
1336         (trace_dump_actions, tdump_command): Update.
1337         * remote.c (remote_download_command_source): Update.
1338         * python/python.c (gdbpy_eval_from_control_command)
1339         (python_command, python_interactive_command): Update.
1340         * mi/mi-cmd-break.c (mi_cmd_break_commands): Update.
1341         * guile/guile.c (guile_command)
1342         (gdbscm_eval_from_control_command, guile_command): Update.
1343         * compile/compile.c (compile_code_command)
1344         (compile_print_command, compile_to_object): Update.
1345         * cli/cli-script.h (struct command_lines_deleter): New.
1346         (counted_command_line): New typedef.
1347         (struct command_line): Add constructor, destructor.
1348         <body_list>: Remove.
1349         <body_list_0, body_list_1>: New members.
1350         (command_line_up): Remove typedef.
1351         (read_command_lines, read_command_lines_1, get_command_line):
1352         Update.
1353         (copy_command_lines): Don't declare.
1354         * cli/cli-script.c (build_command_line): Use "new".
1355         (get_command_line): Return counted_command_line.
1356         (print_command_lines, execute_user_command)
1357         (execute_control_command_1, while_command, if_command): Update.
1358         (realloc_body_list): Remove.
1359         (process_next_line, recurse_read_control_structure): Update.
1360         (read_command_lines, read_command_lines_1): Return counted_command_line.
1361         (free_command_lines): Use "delete".
1362         (copy_command_lines): Remove.
1363         (define_command, document_command, show_user_1): Update.
1364         * cli/cli-decode.h (struct cmd_list_element) <user_commands>: Now
1365         a counted_command_line.
1366         * breakpoint.h (counted_command_line): Remove typedef.
1367         (breakpoint_set_commands): Update.
1368         * breakpoint.c (check_no_tracepoint_commands)
1369         (validate_commands_for_breakpoint): Update.
1370         (breakpoint_set_commands): Change commands to be a
1371         counted_command_line.
1372         (commands_command_1, update_dprintf_command_list)
1373         (create_tracepoint_from_upload): Update.
1374
1375 2018-05-04  Tom Tromey  <tom@tromey.com>
1376
1377         * cli/cli-decode.h (cmd_list_element): New constructor.
1378         (~cmd_list_element): New destructor.
1379         (struct cmd_list_element): Add initializers.
1380         * cli/cli-decode.c (do_add_cmd): Use "new".
1381         (delete_cmd): Use "delete".
1382
1383 2018-05-04  Jan Kratochvil  <jan.kratochvil@redhat.com>
1384             Pedro Alves <palves@redhat.com>
1385
1386         PR breakpoints/19806 and support for PR external/20207.
1387         * NEWS: Mention Aarch64 watchpoint improvements.
1388         * aarch64-linux-nat.c (aarch64_linux_stopped_data_address): Fix missed
1389         watchpoints and PR external/20207 watchpoints.
1390         * nat/aarch64-linux-hw-point.c
1391         (kernel_supports_any_contiguous_range): New.
1392         (aarch64_watchpoint_offset): New.
1393         (aarch64_watchpoint_length): Support PR external/20207 watchpoints.
1394         (aarch64_point_encode_ctrl_reg): New parameter offset, new asserts.
1395         (aarch64_point_is_aligned): Support PR external/20207 watchpoints.
1396         (aarch64_align_watchpoint): New parameters aligned_offset_p and
1397         next_addr_orig_p.  Support PR external/20207 watchpoints.
1398         (aarch64_downgrade_regs): New.
1399         (aarch64_dr_state_insert_one_point): New parameters offset and
1400         addr_orig.
1401         (aarch64_dr_state_remove_one_point): Likewise.
1402         (aarch64_handle_breakpoint): Update caller.
1403         (aarch64_handle_aligned_watchpoint): Likewise.
1404         (aarch64_handle_unaligned_watchpoint): Support addr_orig and
1405         aligned_offset.
1406         (aarch64_linux_set_debug_regs): Remove const from state.  Call
1407         aarch64_downgrade_regs.
1408         (aarch64_show_debug_reg_state): Print also dr_addr_orig_wp.
1409         * nat/aarch64-linux-hw-point.h (DR_CONTROL_LENGTH): Rename to ...
1410         (DR_CONTROL_MASK): ... this.
1411         (struct aarch64_debug_reg_state): New field dr_addr_orig_wp.
1412         (unsigned int aarch64_watchpoint_offset): New prototype.
1413         (aarch64_linux_set_debug_regs): Remove const from state.
1414         * utils.c (align_up, align_down): Move to ...
1415         * common/common-utils.c (align_up, align_down): ... here.
1416         * utils.h (align_up, align_down): Move to ...
1417         * common/common-utils.h (align_up, align_down): ... here.
1418
1419 2018-05-04  Joel Brobecker  <brobecker@adacore.com>
1420
1421         * sparc-tdep.c (sparc_structure_return_p): Re-implement to
1422         match the ABI as summarized in GCC's gcc/config/sparc/sparc.c.
1423         (sparc_arg_by_memory_p): Renamed from sparc_arg_on_registers_p.
1424         Re-implement to match the ABI as summarized in GCC's
1425         gcc/config/sparc/sparc.c.  All callers updated.
1426         (sparc32_store_arguments): Remove assertion.
1427
1428 2018-05-04  Tom Tromey  <tom@tromey.com>
1429
1430         * printcmd.c: Don't include tui.h.
1431         (decode_format): Use skip_spaces.
1432
1433 2018-05-04  Tom Tromey  <tom@tromey.com>
1434
1435         PR gdb/22619:
1436         * printcmd.c (last_count): New global.
1437         (x_command): Use saved count when repeating.
1438
1439 2018-05-04  Tom Tromey  <tom@tromey.com>
1440
1441         * nto-procfs.c (do_closedir_cleanup): Remove.
1442         (procfs_pidlist): Use gdb_dir_up.
1443         * procfs.c (do_closedir_cleanup): Remove.
1444         (proc_update_threads): Use gdb_dir_up.
1445         * common/filestuff.h (struct gdb_dir_deleter): New.
1446         (gdb_dir_up): New typedef.
1447
1448 2018-05-04  Tom Tromey  <tom@tromey.com>
1449
1450         * ada-lang.c (print_mention_exception): Use std::string.
1451
1452 2018-05-04  Tom Tromey  <tom@tromey.com>
1453
1454         * ada-lang.c (create_excep_cond_exprs): Update.
1455         (ada_exception_catchpoint_cond_string): Use std::string.
1456
1457 2018-05-04  Tom Tromey  <tom@tromey.com>
1458
1459         * ada-lang.c (xget_renaming_scope): Return std::string.
1460         (old_renaming_is_invisible): Update.
1461
1462 2018-05-04  Tom Tromey  <tom@tromey.com>
1463
1464         * bfd-target.c (target_bfd::m_bfd): Now a gdb_bfd_ref_ptr.
1465         (target_bfd::target_bfd, target_bfd::~target_bfd): Update.
1466
1467 2018-05-04  Ulrich Weigand  <uweigand@de.ibm.com>
1468
1469         * spu-linux-nat.c (spu_linux_nat_target::wait): Fix syntax error.
1470
1471 2018-05-04  Tom Tromey  <tom@tromey.com>
1472
1473         * remote.c (remote_query_supported_append): Change type.
1474         (remote_check_symbols): Update.
1475
1476 2018-05-04  Paul Pluzhnikov  <ppluzhnikov@google.com>
1477
1478         PR gdb/11420
1479         * configure.ac: Prepend libpython.
1480         * python/python-config.py: Likewise.
1481         * configure: Regenerate.
1482
1483 2018-05-03  Simon Marchi  <simon.marchi@ericsson.com>
1484
1485         * Makefile.in (%.c: %.l): Use -t instead of --stdout.
1486
1487 2018-05-03  Pedro Alves  <palves@redhat.com>
1488
1489         * s390-linux-nat.c
1490         (s390_linux_nat_target::have_continuable_watchpoint): Mark with
1491         override.  Write 'true' instead of '1'.
1492         (s390_linux_nat_target::watchpoint_addr_within_range): Remove
1493         declaration.
1494
1495 2018-05-02  Pedro Alves  <palves@redhat.com>
1496
1497         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Use
1498         add_inf_child_target.
1499         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Use
1500         add_inf_child_target.
1501         * aix-thread.c (aix_thread_target_info): New.
1502         (aix_thread_target) <shortname, longname, doc>: Delete.
1503         <info>: New.
1504         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Use
1505         add_inf_child_target.
1506         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Use
1507         add_inf_child_target.
1508         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Use
1509         add_inf_child_target.
1510         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Use
1511         add_inf_child_target.
1512         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Use
1513         add_inf_child_target.
1514         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Use
1515         add_inf_child_target.
1516         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Use
1517         add_inf_child_target.
1518         * arm-linux-nat.c (_initialize_arm_linux_nat): Use
1519         add_inf_child_target.
1520         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Use
1521         add_inf_child_target.
1522         * bfd-target.c (target_bfd_target_info): New.
1523         (target_bfd) <shortname, longname, doc>: Delete.
1524         <info>: New.
1525         * bsd-kvm.c (bsd_kvm_target_info): New.
1526         (bsd_kvm_target) <shortname, longname, doc>: Delete.
1527         <info>: New.
1528         (bsd_kvm_target::open): Rename to ...
1529         (bsd_kvm_target_open): ... this.  Adjust.
1530         * bsd-uthread.c (bsd_uthread_target_info): New.
1531         (bsd_uthread_target) <shortname, longname, doc>: Delete.
1532         <info>: New.
1533         * corefile.c (core_file_command): Adjust.
1534         * corelow.c (core_target_info): New.
1535         (core_target) <shortname, longname, doc>: Delete.
1536         <info>: New.
1537         (core_target::open): Rename to ...
1538         (core_target_open): ... this.  Adjust.
1539         * ctf.c (ctf_target_info): New.
1540         (ctf_target) <shortname, longname, doc>: Delete.
1541         <info>: New.
1542         (ctf_target::open): Rename to ...
1543         (ctf_target_open): ... this.
1544         (_initialize_ctf): Adjust.
1545         * exec.c (exec_target_info): New.
1546         (exec_target) <shortname, longname, doc>: Delete.
1547         <info>: New.
1548         (exec_target::open): Rename to ...
1549         (exec_target_open): ... this.
1550         * gdbcore.h (core_target_open): Declare.
1551         * go32-nat.c (_initialize_go32_nat): Use add_inf_child_target.
1552         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Use
1553         add_inf_child_target.
1554         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Use
1555         add_inf_child_target.
1556         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Use
1557         add_inf_child_target.
1558         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Use
1559         add_inf_child_target.
1560         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Use
1561         add_inf_child_target.
1562         * i386-gnu-nat.c (_initialize_i386gnu_nat): Use
1563         add_inf_child_target.
1564         * i386-linux-nat.c (_initialize_i386_linux_nat): Use
1565         add_inf_child_target.
1566         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Use
1567         add_inf_child_target.
1568         * i386-obsd-nat.c (_initialize_i386obsd_nat): Use
1569         add_inf_child_target.
1570         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Use
1571         add_inf_child_target.
1572         * inf-child.c (inf_child_target_info): New.
1573         (inf_child_target::info): New.
1574         (inf_child_open_target): Remove 'target' parameter.  Use
1575         get_native_target instead.
1576         (inf_child_target::open): Delete.
1577         (add_inf_child_target): New.
1578         * inf-child.h (inf_child_target) <shortname, longname, doc, open>:
1579         Delete.
1580         <info>: New.
1581         (add_inf_child_target): Declare.
1582         (inf_child_open_target): Declare.
1583         * linux-thread-db.c (thread_db_target_info): New.
1584         (thread_db_target) <shortname, longname, doc>: Delete.
1585         <info>: New.
1586         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Use
1587         add_inf_child_target.
1588         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Use
1589         add_inf_child_target.
1590         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Use
1591         add_inf_child_target.
1592         * m88k-bsd-nat.c (_initialize_m88kbsd_nat): Use
1593         add_inf_child_target.
1594         * make-target-delegates (print_class): Adjust.
1595         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Use
1596         add_inf_child_target.
1597         * mips-linux-nat.c (_initialize_mips_linux_nat): Use
1598         add_inf_child_target.
1599         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Use
1600         add_inf_child_target.
1601         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Use
1602         add_inf_child_target.
1603         * nto-procfs.c (nto_native_target_info): New.
1604         (nto_procfs_target_native) <shortname, longname, doc>:
1605         Delete.
1606         <info>: New.
1607         (nto_procfs_target_info): New.
1608         (nto_procfs_target_procfs) <shortname, longname, doc>:
1609         Delete.
1610         <info>: New.
1611         (init_procfs_targets): Adjust.
1612         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Use
1613         add_inf_child_target.
1614         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Use
1615         add_inf_child_target.
1616         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Use
1617         add_inf_child_target.
1618         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Use
1619         add_inf_child_target.
1620         * ravenscar-thread.c (ravenscar_target_info): New.
1621         (ravenscar_thread_target) <shortname, longname, doc>:
1622         Delete.
1623         <info>: New.
1624         * record-btrace.c (record_btrace_target_info):
1625         (record_btrace_target) <shortname, longname, doc>: Delete.
1626         <info>: New.
1627         (record_btrace_target::open): Rename to ...
1628         (record_btrace_target_open): ... this.  Adjust.
1629         * record-full.c (record_longname, record_doc): New.
1630         (record_full_base_target) <shortname, longname, doc>: Delete.
1631         <info>: New.
1632         (record_full_target_info): New.
1633         (record_full_target): <shortname>: Delete.
1634         <info>: New.
1635         (record_full_core_open_1, record_full_open_1): Update comments.
1636         (record_full_base_target::open): Rename to ...
1637         (record_full_open): ... this.
1638         (cmd_record_full_restore): Update.
1639         (_initialize_record_full): Update.
1640         * remote-sim.c (remote_sim_target_info): New.
1641         (gdbsim_target) <shortname, longname, doc>: Delete.
1642         <info>: New.
1643         (gdbsim_target::open): Rename to ...
1644         (gdbsim_target_open): ... this.
1645         (_initialize_remote_sim): Adjust.
1646         * remote.c (remote_doc): New.
1647         (remote_target_info): New.
1648         (remote_target) <shortname, longname, doc>: Delete.
1649         <info>: New.
1650         (extended_remote_target_info): New.
1651         (extended_remote_target) <shortname, longname, doc>: Delete.
1652         <info>: New.
1653         (remote_target::open_1): Make static.  Adjust.
1654         * rs6000-nat.c (_initialize_rs6000_nat): Use add_inf_child_target.
1655         * s390-linux-nat.c (_initialize_s390_nat): Use
1656         add_inf_child_target.
1657         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Use
1658         add_inf_child_target.
1659         * sol-thread.c (thread_db_target_info): New.
1660         (sol_thread_target) <shortname, longname, doc>: Delete.
1661         <info>: New.
1662         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Use
1663         add_inf_child_target.
1664         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Use
1665         add_inf_child_target.
1666         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Use
1667         add_inf_child_target.
1668         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Use
1669         add_inf_child_target.
1670         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Use
1671         add_inf_child_target.
1672         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Use
1673         add_inf_child_target.
1674         * spu-linux-nat.c (_initialize_spu_nat): Use
1675         add_inf_child_target.
1676         * spu-multiarch.c (spu_multiarch_target_info): New.
1677         (spu_multiarch_target) <shortname, longname, doc>: Delete.
1678         <info>: New.
1679         * target-delegates.c: Regenerate.
1680         * target.c: Include <unordered_map>.
1681         (target_ops_p): Delete.
1682         (DEF_VEC_P(target_ops_p)): Delete.
1683         (target_factories): New.
1684         (test_target_info): New.
1685         (test_target_ops::info): New.
1686         (open_target): Adjust to use target_factories.
1687         (add_target_with_completer): Rename to ...
1688         (add_target): ... this.  Change prototype.  Register target_info
1689         and open callback in target_factories.  Register target_info in
1690         command context instead of target_ops.
1691         (add_target): Delete old implementation.
1692         (add_deprecated_target_alias): Change prototype.  Adjust.
1693         (the_native_target): New.
1694         (set_native_target, get_native_target): New.
1695         (find_default_run_target): Use the_native_target.
1696         (find_attach_target, find_run_target): Simplify.
1697         (target_ops::open): Delete.
1698         (dummy_target_info): New.
1699         (dummy_target::shortname, dummy_target::longname)
1700         (dummy_target::doc): Delete.
1701         (dummy_target::info): New.
1702         (debug_target::shortname, debug_target::longname)
1703         (debug_target::doc): Delete.
1704         (debug_target::info): New.
1705         * target.h (struct target_info): New.
1706         (target_ops::~target_ops): Add comment.
1707         (target_ops::info): New.
1708         (target_ops::shortname, target_ops::longname, target_ops::doc): No
1709         longer virtual.  Implement in terms of target_info.
1710         (set_native_target, get_native_target): Declare.
1711         (target_open_ftype): New.
1712         (add_target, add_target_with_completer)
1713         (add_deprecated_target_alias): Change prototype.
1714         (test_target) <shortname, longname, doc>: Delete.
1715         <info>: New.
1716         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Use
1717         add_inf_child_target.
1718         * tracefile-tfile.c (tfile_target_info): New.
1719         (tfile_target) <shortname, longname, doc>: Delete.
1720         <info>: New.
1721         (tfile_target::open): Rename to ...
1722         (tfile_target_open): ... this.
1723         (_initialize_tracefile_tfile): Adjust.
1724         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Use
1725         add_inf_child_target.
1726         * windows-nat.c (_initialize_windows_nat): Use
1727         add_inf_child_target.
1728         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Use
1729         add_inf_child_target.
1730
1731 2018-05-02  Pedro Alves  <palves@redhat.com>
1732
1733         * linux-nat.h (linux_nat_target) <low_new_thread,
1734         low_delete_thread, low_new_fork, low_forget_process,
1735         low_prepare_to_resume, low_siginfo_fixup, low_status_is_event>:
1736         New virtual methods.
1737         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
1738         (linux_nat_new_fork_ftype, linux_nat_set_new_fork)
1739         (linux_nat_forget_process_ftype, linux_nat_set_forget_process)
1740         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
1741         (linux_nat_set_prepare_to_resume, linux_nat_set_status_is_event):
1742         Delete.
1743         * linux-fork.c (delete_fork): Adjust to call low method.
1744         * linux-nat.c (linux_nat_new_thread, linux_nat_delete_thread)
1745         (linux_nat_new_fork, linux_nat_forget_process_hook)
1746         (linux_nat_prepare_to_resume, linux_nat_siginfo_fixup)
1747         (linux_nat_status_is_event):
1748         (linux_nat_target::follow_fork, lwp_free, add_lwp, detach_one_lwp)
1749         (linux_resume_one_lwp_throw, linux_handle_extended_wait): Adjust
1750         to call low method.
1751         (sigtrap_is_event): Rename to ...
1752         (linux_nat_target::low_status_is_event): ... this.
1753         (linux_nat_set_status_is_event): Delete.
1754         (save_stop_reason, linux_nat_wait_1)
1755         (linux_nat_target::mourn_inferior, siginfo_fixup): Adjust to call
1756         low methods.
1757         (linux_nat_set_new_thread, linux_nat_set_delete_thread)
1758         (linux_nat_set_new_fork, linux_nat_set_forget_process)
1759         (linux_nat_forget_process, linux_nat_set_siginfo_fixup)
1760         (linux_nat_set_prepare_to_resume): Delete.
1761         * aarch64-linux-nat.c: All linux_nat_set_* callbacks converted to
1762         low virtual methods.
1763         * amd64-linux-nat.c: Likewise.
1764         * arm-linux-nat.c: Likewise.
1765         * i386-linux-nat.c: Likewise.
1766         * ia64-linux-nat.c: Likewise.
1767         * mips-linux-nat.c: Likewise.
1768         * ppc-linux-nat.c: Likewise.
1769         * s390-linux-nat.c: Likewise.
1770         * sparc64-linux-nat.c: Likewise.
1771         * x86-linux-nat.c: Likewise.
1772         * x86-linux-nat.h: Include "nat/x86-linux.h".
1773         (x86_linux_nat_target) <low_new_fork, low_forget_process,
1774         low_prepare_to_resume, low_new_thread, low_delete_thread>:
1775         Override methods.
1776
1777 2018-05-02  Pedro Alves  <palves@redhat.com>
1778
1779         * target.h (target_ops)
1780         <stopped_by_sw_breakpoint, supports_stopped_by_sw_breakpoint,
1781         stopped_by_hw_breakpoint, supports_stopped_by_hw_breakpoint,
1782         stopped_by_watchpoint, have_continuable_watchpoint,
1783         stopped_data_address, watchpoint_addr_within_range,
1784         can_accel_watchpoint_condition, can_run, thread_alive,
1785         has_all_memory, has_memory, has_stack, has_registers,
1786         has_execution, can_async_p, is_async_p, supports_non_stop,
1787         always_non_stop_p, can_execute_reverse, supports_multi_process,
1788         supports_enable_disable_tracepoint,
1789         supports_disable_randomization, supports_string_tracing,
1790         supports_evaluation_of_breakpoint_conditions,
1791         can_run_breakpoint_commands, filesystem_is_local,
1792         can_download_tracepoint, get_trace_state_variable_value,
1793         set_trace_notes, get_tib_address, use_agent, can_use_agent,
1794         record_is_replaying, record_will_replay,
1795         augmented_libraries_svr4_read>: Adjust to return bool.
1796         * aarch64-linux-nat.c: All implementations adjusted.
1797         * aix-thread.c: All implementations adjusted.
1798         * arm-linux-nat.c: All implementations adjusted.
1799         * breakpoint.c: All implementations adjusted.
1800         * bsd-kvm.c: All implementations adjusted.
1801         * bsd-uthread.c: All implementations adjusted.
1802         * corelow.c: All implementations adjusted.
1803         * ctf.c: All implementations adjusted.
1804         * darwin-nat.c: All implementations adjusted.
1805         * darwin-nat.h: All implementations adjusted.
1806         * exec.c: All implementations adjusted.
1807         * fbsd-nat.c: All implementations adjusted.
1808         * fbsd-nat.h: All implementations adjusted.
1809         * gnu-nat.c: All implementations adjusted.
1810         * gnu-nat.h: All implementations adjusted.
1811         * go32-nat.c: All implementations adjusted.
1812         * ia64-linux-nat.c: All implementations adjusted.
1813         * inf-child.c: All implementations adjusted.
1814         * inf-child.h: All implementations adjusted.
1815         * inf-ptrace.c: All implementations adjusted.
1816         * inf-ptrace.h: All implementations adjusted.
1817         * linux-nat.c: All implementations adjusted.
1818         * linux-nat.h: All implementations adjusted.
1819         * mips-linux-nat.c: All implementations adjusted.
1820         * nto-procfs.c: All implementations adjusted.
1821         * ppc-linux-nat.c: All implementations adjusted.
1822         * procfs.c: All implementations adjusted.
1823         * ravenscar-thread.c: All implementations adjusted.
1824         * record-btrace.c: All implementations adjusted.
1825         * record-full.c: All implementations adjusted.
1826         * remote-sim.c: All implementations adjusted.
1827         * remote.c: All implementations adjusted.
1828         * s390-linux-nat.c: All implementations adjusted.
1829         * sol-thread.c: All implementations adjusted.
1830         * spu-multiarch.c: All implementations adjusted.
1831         * target-delegates.c: All implementations adjusted.
1832         * target.c: All implementations adjusted.
1833         * target.h: All implementations adjusted.
1834         * tracefile-tfile.c: All implementations adjusted.
1835         * tracefile.c: All implementations adjusted.
1836         * tracefile.h: All implementations adjusted.
1837         * windows-nat.c: All implementations adjusted.
1838         * x86-linux-nat.h: All implementations adjusted.
1839         * x86-nat.h: All implementations adjusted.
1840
1841 2018-05-02  Pedro Alves  <palves@redhat.com>
1842
1843         * make-target-delegates (scan_target_h): Don't trim lines here.
1844         Replace sequences of tabs and/or whitespace with a single
1845         whitespace.
1846         (top level, parsing methods): Trim each line before processing it
1847         here.
1848
1849 2018-05-02  Pedro Alves  <palves@redhat.com>
1850             John Baldwin  <jhb@freebsd.org>
1851
1852         * target.h (enum strata) <debug_stratum>: New.
1853         (struct target_ops) <all delegation methods>: Replace by C++
1854         virtual methods, and drop "to_" prefix.  All references updated
1855         throughout.
1856         <to_shortname, to_longname, to_doc, to_data,
1857         to_have_steppable_watchpoint, to_have_continuable_watchpoint,
1858         to_has_thread_control, to_attach_no_wait>: Delete, replaced by
1859         virtual methods.  All references updated throughout.
1860         <can_attach, supports_terminal_ours, can_create_inferior,
1861         get_thread_control_capabilities, attach_no_wait>: New
1862         virtual methods.
1863         <insert_breakpoint, remove_breakpoint>: Now
1864         TARGET_DEFAULT_NORETURN methods.
1865         <info_proc>: Now returns bool.
1866         <to_magic>: Delete.
1867         (OPS_MAGIC): Delete.
1868         (current_target): Delete.  All references replaced by references
1869         to ...
1870         (target_stack): ... this.  New.
1871         (target_shortname, target_longname): Adjust.
1872         (target_can_run): Now a function declaration.
1873         (default_child_has_all_memory, default_child_has_memory)
1874         (default_child_has_stack, default_child_has_registers)
1875         (default_child_has_execution): Remove target_ops parameter.
1876         (complete_target_initialization): Delete.
1877         (memory_breakpoint_target): New template class.
1878         (test_target_ops): Refactor as a C++ class with virtual methods.
1879         * make-target-delegates (NAME_PART): Tighten.
1880         (POINTER_PART, CP_SYMBOL): New.
1881         (SIMPLE_RETURN_PART): Reimplement.
1882         (VEC_RETURN_PART): Expect less.
1883         (RETURN_PART, VIRTUAL_PART): New.
1884         (METHOD): Adjust to C++ virtual methods.
1885         (scan_target_h): Remove reference to C99.
1886         (dname): Output "target_ops::" prefix.
1887         (write_function_header): Adjust to output a C++ class method.
1888         (write_declaration): New.
1889         (write_delegator): Adjust to output a C++ class method.
1890         (tdname): Output "dummy_target::" prefix.
1891         (write_tdefault, write_debugmethod): Adjust to output a C++ class
1892         method.
1893         (tdefault_names, debug_names): Delete.
1894         (return_types, tdefaults, styles, argtypes_array): New.
1895         (top level): All methods are delegators.
1896         (print_class): New.
1897         (top level): Print dummy_target and debug_target classes.
1898         * target-delegates.c: Regenerate.
1899         * target-debug.h (target_debug_print_enum_info_proc_what)
1900         (target_debug_print_thread_control_capabilities)
1901         (target_debug_print_thread_info_p): New.
1902         * target.c (dummy_target): Delete.
1903         (the_dummy_target, the_debug_target): New.
1904         (target_stack): Now extern.
1905         (set_targetdebug): Push/unpush debug target.
1906         (default_child_has_all_memory, default_child_has_memory)
1907         (default_child_has_stack, default_child_has_registers)
1908         (default_child_has_execution): Remove target_ops parameter.
1909         (complete_target_initialization): Delete.
1910         (add_target_with_completer): No longer call
1911         complete_target_initialization.
1912         (target_supports_terminal_ours): Use regular delegation.
1913         (update_current_target): Delete.
1914         (push_target): No longer check magic number.  Don't call
1915         update_current_target.
1916         (unpush_target): Don't call update_current_target.
1917         (target_is_pushed): No longer check magic number.
1918         (target_require_runnable): Skip for all stratums over
1919         process_stratum.
1920         (target_ops::info_proc): New.
1921         (target_info_proc): Use find_target_at and
1922         find_default_run_target.
1923         (target_supports_disable_randomization): Use regular delegation.
1924         (target_get_osdata): Use find_target_at.
1925         (target_ops::open, target_ops::close, target_ops::can_attach)
1926         (target_ops::attach, target_ops::can_create_inferior)
1927         (target_ops::create_inferior, target_ops::can_run)
1928         (target_can_run): New.
1929         (default_fileio_target): Use regular delegation.
1930         (target_ops::fileio_open, target_ops::fileio_pwrite)
1931         (target_ops::fileio_pread, target_ops::fileio_fstat)
1932         (target_ops::fileio_close, target_ops::fileio_unlink)
1933         (target_ops::fileio_readlink): New.
1934         (target_fileio_open_1, target_fileio_unlink)
1935         (target_fileio_readlink): Always call the target method.  Handle
1936         FILEIO_ENOSYS.
1937         (return_zero, return_zero_has_execution): Delete.
1938         (init_dummy_target): Delete.
1939         (dummy_target::dummy_target, dummy_target::shortname)
1940         (dummy_target::longname, dummy_target::doc)
1941         (debug_target::debug_target, debug_target::shortname)
1942         (debug_target::longname, debug_target::doc): New.
1943         (target_supports_delete_record): Use regular delegation.
1944         (setup_target_debug): Delete.
1945         (maintenance_print_target_stack): Skip debug_stratum.
1946         (initialize_targets): Instantiate the_dummy_target and
1947         the_debug_target.
1948         * auxv.c (target_auxv_parse): Remove 'ops' parameter.  Adjust to
1949         use target_stack.
1950         (target_auxv_search, fprint_target_auxv): Adjust.
1951         (info_auxv_command): Adjust to use target_stack.
1952         * auxv.h (target_auxv_parse): Remove 'ops' parameter.
1953         * exceptions.c (print_flush): Handle a NULL target_stack.
1954         * regcache.c (target_ops_no_register): Refactor as class with
1955         virtual methods.
1956
1957         * exec.c (exec_target): New class.
1958         (exec_ops): Now an exec_target.
1959         (exec_open, exec_close_1, exec_get_section_table)
1960         (exec_xfer_partial, exec_files_info, exec_has_memory)
1961         (exec_make_note_section): Refactor as exec_target methods.
1962         (exec_file_clear, ignore, exec_remove_breakpoint, init_exec_ops):
1963         Delete.
1964         (exec_target::find_memory_regions): New.
1965         (_initialize_exec): Don't call init_exec_ops.
1966         * gdbcore.h (exec_file_clear): Delete.
1967
1968         * corefile.c (core_target): Delete.
1969         (core_file_command): Adjust.
1970         * corelow.c (core_target): New class.
1971         (the_core_target): New.
1972         (core_close): Remove target_ops parameter.
1973         (core_close_cleanup): Adjust.
1974         (core_target::close): New.
1975         (core_open, core_detach, get_core_registers, core_files_info)
1976         (core_xfer_partial, core_thread_alive, core_read_description)
1977         (core_pid_to_str, core_thread_name, core_has_memory)
1978         (core_has_stack, core_has_registers, core_info_proc): Rework as
1979         core_target methods.
1980         (ignore, core_remove_breakpoint, init_core_ops): Delete.
1981         (_initialize_corelow): Initialize the_core_target.
1982         * gdbcore.h (core_target): Delete.
1983         (the_core_target): New.
1984
1985         * ctf.c: (ctf_target): New class.
1986         (ctf_ops): Now a ctf_target.
1987         (ctf_open, ctf_close, ctf_files_info, ctf_fetch_registers)
1988         (ctf_xfer_partial, ctf_get_trace_state_variable_value)
1989         (ctf_trace_find, ctf_traceframe_info): Refactor as ctf_target
1990         methods.
1991         (init_ctf_ops): Delete.
1992         (_initialize_ctf): Don't call it.
1993         * tracefile-tfile.c (tfile_target): New class.
1994         (tfile_ops): Now a tfile_target.
1995         (tfile_open, tfile_close, tfile_files_info)
1996         (tfile_get_tracepoint_status, tfile_trace_find)
1997         (tfile_fetch_registers, tfile_xfer_partial)
1998         (tfile_get_trace_state_variable_value, tfile_traceframe_info):
1999         Refactor as tfile_target methods.
2000         (tfile_xfer_partial_features): Remove target_ops parameter.
2001         (init_tfile_ops): Delete.
2002         (_initialize_tracefile_tfile): Don't call it.
2003         * tracefile.c (tracefile_has_all_memory, tracefile_has_memory)
2004         (tracefile_has_stack, tracefile_has_registers)
2005         (tracefile_thread_alive, tracefile_get_trace_status): Refactor as
2006         tracefile_target methods.
2007         (init_tracefile_ops): Delete.
2008         (tracefile_target::tracefile_target): New.
2009         * tracefile.h: Include "target.h".
2010         (tracefile_target): New class.
2011         (init_tracefile_ops): Delete.
2012
2013         * spu-multiarch.c (spu_multiarch_target): New class.
2014         (spu_ops): Now a spu_multiarch_target.
2015         (spu_thread_architecture, spu_region_ok_for_hw_watchpoint)
2016         (spu_fetch_registers, spu_store_registers, spu_xfer_partial)
2017         (spu_search_memory, spu_mourn_inferior): Refactor as
2018         spu_multiarch_target methods.
2019         (init_spu_ops): Delete.
2020         (_initialize_spu_multiarch): Remove references to init_spu_ops,
2021         complete_target_initialization.
2022
2023         * ravenscar-thread.c (ravenscar_thread_target): New class.
2024         (ravenscar_ops): Now a ravenscar_thread_target.
2025         (ravenscar_resume, ravenscar_wait, ravenscar_update_thread_list)
2026         (ravenscar_thread_alive, ravenscar_pid_to_str)
2027         (ravenscar_fetch_registers, ravenscar_store_registers)
2028         (ravenscar_prepare_to_store, ravenscar_stopped_by_sw_breakpoint)
2029         (ravenscar_stopped_by_hw_breakpoint)
2030         (ravenscar_stopped_by_watchpoint, ravenscar_stopped_data_address)
2031         (ravenscar_mourn_inferior, ravenscar_core_of_thread)
2032         (ravenscar_get_ada_task_ptid): Refactor as ravenscar_thread_target
2033         methods.
2034         (init_ravenscar_thread_ops): Delete.
2035         (_initialize_ravenscar): Remove references to
2036         init_ravenscar_thread_ops and complete_target_initialization.
2037
2038         * bsd-uthread.c (bsd_uthread_ops_hack): Delete.
2039         (bsd_uthread_target): New class.
2040         (bsd_uthread_ops): Now a bsd_uthread_target.
2041         (bsd_uthread_activate): Adjust to refer to bsd_uthread_ops.
2042         (bsd_uthread_close, bsd_uthread_mourn_inferior)
2043         (bsd_uthread_fetch_registers, bsd_uthread_store_registers)
2044         (bsd_uthread_wait, bsd_uthread_resume, bsd_uthread_thread_alive)
2045         (bsd_uthread_update_thread_list, bsd_uthread_extra_thread_info)
2046         (bsd_uthread_pid_to_str): Refactor as bsd_uthread_target methods.
2047         (bsd_uthread_target): Delete function.
2048         (_initialize_bsd_uthread): Remove reference to
2049         complete_target_initialization.
2050
2051         * bfd-target.c (target_bfd_data): Delete.  Fields folded into ...
2052         (target_bfd): ... this new class.
2053         (target_bfd_xfer_partial, target_bfd_get_section_table)
2054         (target_bfd_close): Refactor as target_bfd methods.
2055         (target_bfd::~target_bfd): New.
2056         (target_bfd_reopen): Adjust.
2057         (target_bfd::close): New.
2058
2059         * record-btrace.c (record_btrace_target): New class.
2060         (record_btrace_ops): Now a record_btrace_target.
2061         (record_btrace_open, record_btrace_stop_recording)
2062         (record_btrace_disconnect, record_btrace_close)
2063         (record_btrace_async, record_btrace_info)
2064         (record_btrace_insn_history, record_btrace_insn_history_range)
2065         (record_btrace_insn_history_from, record_btrace_call_history)
2066         (record_btrace_call_history_range)
2067         (record_btrace_call_history_from, record_btrace_record_method)
2068         (record_btrace_is_replaying, record_btrace_will_replay)
2069         (record_btrace_xfer_partial, record_btrace_insert_breakpoint)
2070         (record_btrace_remove_breakpoint, record_btrace_fetch_registers)
2071         (record_btrace_store_registers, record_btrace_prepare_to_store)
2072         (record_btrace_to_get_unwinder)
2073         (record_btrace_to_get_tailcall_unwinder, record_btrace_resume)
2074         (record_btrace_commit_resume, record_btrace_wait)
2075         (record_btrace_stop, record_btrace_can_execute_reverse)
2076         (record_btrace_stopped_by_sw_breakpoint)
2077         (record_btrace_supports_stopped_by_sw_breakpoint)
2078         (record_btrace_stopped_by_hw_breakpoint)
2079         (record_btrace_supports_stopped_by_hw_breakpoint)
2080         (record_btrace_update_thread_list, record_btrace_thread_alive)
2081         (record_btrace_goto_begin, record_btrace_goto_end)
2082         (record_btrace_goto, record_btrace_stop_replaying_all)
2083         (record_btrace_execution_direction)
2084         (record_btrace_prepare_to_generate_core)
2085         (record_btrace_done_generating_core): Refactor as
2086         record_btrace_target methods.
2087         (init_record_btrace_ops): Delete.
2088         (_initialize_record_btrace): Remove reference to
2089         init_record_btrace_ops.
2090         * record-full.c (RECORD_FULL_IS_REPLAY): Adjust to always refer to
2091         the execution_direction global.
2092         (record_full_base_target, record_full_target)
2093         (record_full_core_target): New classes.
2094         (record_full_ops): Now a record_full_target.
2095         (record_full_core_ops): Now a record_full_core_target.
2096         (record_full_target::detach, record_full_target::disconnect)
2097         (record_full_core_target::disconnect)
2098         (record_full_target::mourn_inferior, record_full_target::kill):
2099         New.
2100         (record_full_open, record_full_close, record_full_async): Refactor
2101         as methods of the record_full_base_target class.
2102         (record_full_resume, record_full_commit_resume): Refactor
2103         as methods of the record_full_target class.
2104         (record_full_wait, record_full_stopped_by_watchpoint)
2105         (record_full_stopped_data_address)
2106         (record_full_stopped_by_sw_breakpoint)
2107         (record_full_supports_stopped_by_sw_breakpoint)
2108         (record_full_stopped_by_hw_breakpoint)
2109         (record_full_supports_stopped_by_hw_breakpoint): Refactor as
2110         methods of the record_full_base_target class.
2111         (record_full_store_registers, record_full_xfer_partial)
2112         (record_full_insert_breakpoint, record_full_remove_breakpoint):
2113         Refactor as methods of the record_full_target class.
2114         (record_full_can_execute_reverse, record_full_get_bookmark)
2115         (record_full_goto_bookmark, record_full_execution_direction)
2116         (record_full_record_method, record_full_info, record_full_delete)
2117         (record_full_is_replaying, record_full_will_replay)
2118         (record_full_goto_begin, record_full_goto_end, record_full_goto)
2119         (record_full_stop_replaying): Refactor as methods of the
2120         record_full_base_target class.
2121         (record_full_core_resume, record_full_core_kill)
2122         (record_full_core_fetch_registers)
2123         (record_full_core_prepare_to_store)
2124         (record_full_core_store_registers, record_full_core_xfer_partial)
2125         (record_full_core_insert_breakpoint)
2126         (record_full_core_remove_breakpoint)
2127         (record_full_core_has_execution): Refactor
2128         as methods of the record_full_core_target class.
2129         (record_full_base_target::supports_delete_record): New.
2130         (init_record_full_ops): Delete.
2131         (init_record_full_core_ops): Delete.
2132         (record_full_save): Refactor as method of the
2133         record_full_base_target class.
2134         (_initialize_record_full): Remove references to
2135         init_record_full_ops and init_record_full_core_ops.
2136
2137         * remote.c (remote_target, extended_remote_target): New classes.
2138         (remote_ops): Now a remote_target.
2139         (extended_remote_ops): Now an extended_remote_target.
2140         (remote_insert_fork_catchpoint, remote_remove_fork_catchpoint)
2141         (remote_insert_vfork_catchpoint, remote_remove_vfork_catchpoint)
2142         (remote_insert_exec_catchpoint, remote_remove_exec_catchpoint)
2143         (remote_pass_signals, remote_set_syscall_catchpoint)
2144         (remote_program_signals, )
2145         (remote_thread_always_alive): Remove target_ops parameter.
2146         (remote_thread_alive, remote_thread_name)
2147         (remote_update_thread_list, remote_threads_extra_info)
2148         (remote_static_tracepoint_marker_at)
2149         (remote_static_tracepoint_markers_by_strid)
2150         (remote_get_ada_task_ptid, remote_close, remote_start_remote)
2151         (remote_open): Refactor as methods of remote_target.
2152         (extended_remote_open, extended_remote_detach)
2153         (extended_remote_attach, extended_remote_post_attach):
2154         (extended_remote_supports_disable_randomization)
2155         (extended_remote_create_inferior): : Refactor as method of
2156         extended_remote_target.
2157         (remote_set_permissions, remote_open_1, remote_detach)
2158         (remote_follow_fork, remote_follow_exec, remote_disconnect)
2159         (remote_resume, remote_commit_resume, remote_stop)
2160         (remote_interrupt, remote_pass_ctrlc, remote_terminal_inferior)
2161         (remote_terminal_ours, remote_wait, remote_fetch_registers)
2162         (remote_prepare_to_store, remote_store_registers)
2163         (remote_flash_erase, remote_flash_done, remote_files_info)
2164         (remote_kill, remote_mourn, remote_insert_breakpoint)
2165         (remote_remove_breakpoint, remote_insert_watchpoint)
2166         (remote_watchpoint_addr_within_range)
2167         (remote_remove_watchpoint, remote_region_ok_for_hw_watchpoint)
2168         (remote_check_watch_resources, remote_stopped_by_sw_breakpoint)
2169         (remote_supports_stopped_by_sw_breakpoint)
2170         (remote_stopped_by_hw_breakpoint)
2171         (remote_supports_stopped_by_hw_breakpoint)
2172         (remote_stopped_by_watchpoint, remote_stopped_data_address)
2173         (remote_insert_hw_breakpoint, remote_remove_hw_breakpoint)
2174         (remote_verify_memory): Refactor as methods of remote_target.
2175         (remote_write_qxfer, remote_read_qxfer): Remove target_ops
2176         parameter.
2177         (remote_xfer_partial, remote_get_memory_xfer_limit)
2178         (remote_search_memory, remote_rcmd, remote_memory_map)
2179         (remote_pid_to_str, remote_get_thread_local_address)
2180         (remote_get_tib_address, remote_read_description): Refactor as
2181         methods of remote_target.
2182         (remote_target::fileio_open, remote_target::fileio_pwrite)
2183         (remote_target::fileio_pread, remote_target::fileio_close): New.
2184         (remote_hostio_readlink, remote_hostio_fstat)
2185         (remote_filesystem_is_local, remote_can_execute_reverse)
2186         (remote_supports_non_stop, remote_supports_disable_randomization)
2187         (remote_supports_multi_process, remote_supports_cond_breakpoints)
2188         (remote_supports_enable_disable_tracepoint)
2189         (remote_supports_string_tracing)
2190         (remote_can_run_breakpoint_commands, remote_trace_init)
2191         (remote_download_tracepoint, remote_can_download_tracepoint)
2192         (remote_download_trace_state_variable, remote_enable_tracepoint)
2193         (remote_disable_tracepoint, remote_trace_set_readonly_regions)
2194         (remote_trace_start, remote_get_trace_status)
2195         (remote_get_tracepoint_status, remote_trace_stop)
2196         (remote_trace_find, remote_get_trace_state_variable_value)
2197         (remote_save_trace_data, remote_get_raw_trace_data)
2198         (remote_set_disconnected_tracing, remote_core_of_thread)
2199         (remote_set_circular_trace_buffer, remote_traceframe_info)
2200         (remote_get_min_fast_tracepoint_insn_len)
2201         (remote_set_trace_buffer_size, remote_set_trace_notes)
2202         (remote_use_agent, remote_can_use_agent, remote_enable_btrace)
2203         (remote_disable_btrace, remote_teardown_btrace)
2204         (remote_read_btrace, remote_btrace_conf)
2205         (remote_augmented_libraries_svr4_read, remote_load)
2206         (remote_pid_to_exec_file, remote_can_do_single_step)
2207         (remote_execution_direction, remote_thread_handle_to_thread_info):
2208         Refactor as methods of remote_target.
2209         (init_remote_ops, init_extended_remote_ops): Delete.
2210         (remote_can_async_p, remote_is_async_p, remote_async)
2211         (remote_thread_events, remote_upload_tracepoints)
2212         (remote_upload_trace_state_variables): Refactor as methods of
2213         remote_target.
2214         (_initialize_remote): Remove references to init_remote_ops and
2215         init_extended_remote_ops.
2216
2217         * remote-sim.c (gdbsim_target): New class.
2218         (gdbsim_fetch_register, gdbsim_store_register, gdbsim_kill)
2219         (gdbsim_load, gdbsim_create_inferior, gdbsim_open, gdbsim_close)
2220         (gdbsim_detach, gdbsim_resume, gdbsim_interrupt)
2221         (gdbsim_wait, gdbsim_prepare_to_store, gdbsim_xfer_partial)
2222         (gdbsim_files_info, gdbsim_mourn_inferior, gdbsim_thread_alive)
2223         (gdbsim_pid_to_str, gdbsim_has_all_memory, gdbsim_has_memory):
2224         Refactor as methods of gdbsim_target.
2225         (gdbsim_ops): Now a gdbsim_target.
2226         (init_gdbsim_ops): Delete.
2227         (gdbsim_cntrl_c): Adjust.
2228         (_initialize_remote_sim): Remove reference to init_gdbsim_ops.
2229
2230         * amd64-linux-nat.c (amd64_linux_nat_target): New class.
2231         (the_amd64_linux_nat_target): New.
2232         (amd64_linux_fetch_inferior_registers)
2233         (amd64_linux_store_inferior_registers): Refactor as methods of
2234         amd64_linux_nat_target.
2235         (_initialize_amd64_linux_nat): Adjust.  Set linux_target.
2236         * i386-linux-nat.c: Don't include "linux-nat.h".
2237         (i386_linux_nat_target): New class.
2238         (the_i386_linux_nat_target): New.
2239         (i386_linux_fetch_inferior_registers)
2240         (i386_linux_store_inferior_registers, i386_linux_resume): Refactor
2241         as methods of i386_linux_nat_target.
2242         (_initialize_i386_linux_nat): Adjust.  Set linux_target.
2243         * inf-child.c (inf_child_ops): Delete.
2244         (inf_child_fetch_inferior_registers)
2245         (inf_child_store_inferior_registers): Delete.
2246         (inf_child_post_attach, inf_child_prepare_to_store): Refactor as
2247         methods of inf_child_target.
2248         (inf_child_target::supports_terminal_ours)
2249         (inf_child_target::terminal_init)
2250         (inf_child_target::terminal_inferior)
2251         (inf_child_target::terminal_ours_for_output)
2252         (inf_child_target::terminal_ours, inf_child_target::interrupt)
2253         (inf_child_target::pass_ctrlc, inf_child_target::terminal_info):
2254         New.
2255         (inf_child_open, inf_child_disconnect, inf_child_close)
2256         (inf_child_mourn_inferior, inf_child_maybe_unpush_target)
2257         (inf_child_post_startup_inferior, inf_child_can_run)
2258         (inf_child_pid_to_exec_file): Refactor as methods of
2259         inf_child_target.
2260         (inf_child_follow_fork): Delete.
2261         (inf_child_target::can_create_inferior)
2262         (inf_child_target::can_attach): New.
2263         (inf_child_target::has_all_memory, inf_child_target::has_memory)
2264         (inf_child_target::has_stack, inf_child_target::has_registers)
2265         (inf_child_target::has_execution): New.
2266         (inf_child_fileio_open, inf_child_fileio_pwrite)
2267         (inf_child_fileio_pread, inf_child_fileio_fstat)
2268         (inf_child_fileio_close, inf_child_fileio_unlink)
2269         (inf_child_fileio_readlink, inf_child_use_agent)
2270         (inf_child_can_use_agent): Refactor as methods of
2271         inf_child_target.
2272         (return_zero, inf_child_target): Delete.
2273         (inf_child_target::inf_child_target): New.
2274         * inf-child.h: Include "target.h".
2275         (inf_child_target): Delete function prototype.
2276         (inf_child_target): New class.
2277         (inf_child_open_target, inf_child_mourn_inferior)
2278         (inf_child_maybe_unpush_target): Delete.
2279         * inf-ptrace.c (inf_ptrace_target::~inf_ptrace_target): New.
2280         (inf_ptrace_follow_fork, inf_ptrace_insert_fork_catchpoint)
2281         (inf_ptrace_remove_fork_catchpoint, inf_ptrace_create_inferior)
2282         (inf_ptrace_post_startup_inferior, inf_ptrace_mourn_inferior)
2283         (inf_ptrace_attach, inf_ptrace_post_attach, inf_ptrace_detach)
2284         (inf_ptrace_detach_success, inf_ptrace_kill, inf_ptrace_resume)
2285         (inf_ptrace_wait, inf_ptrace_xfer_partial)
2286         (inf_ptrace_thread_alive, inf_ptrace_files_info)
2287         (inf_ptrace_pid_to_str, inf_ptrace_auxv_parse): Refactor as
2288         methods of inf_ptrace_target.
2289         (inf_ptrace_target): Delete function.
2290         * inf-ptrace.h: Include "inf-child.h".
2291         (inf_ptrace_target): Delete function declaration.
2292         (inf_ptrace_target): New class.
2293         (inf_ptrace_trad_target, inf_ptrace_detach_success): Delete.
2294         * linux-nat.c (linux_target): New.
2295         (linux_ops, linux_ops_saved, super_xfer_partial): Delete.
2296         (linux_nat_target::~linux_nat_target): New.
2297         (linux_child_post_attach, linux_child_post_startup_inferior)
2298         (linux_child_follow_fork, linux_child_insert_fork_catchpoint)
2299         (linux_child_remove_fork_catchpoint)
2300         (linux_child_insert_vfork_catchpoint)
2301         (linux_child_remove_vfork_catchpoint)
2302         (linux_child_insert_exec_catchpoint)
2303         (linux_child_remove_exec_catchpoint)
2304         (linux_child_set_syscall_catchpoint, linux_nat_pass_signals)
2305         (linux_nat_create_inferior, linux_nat_attach, linux_nat_detach)
2306         (linux_nat_resume, linux_nat_stopped_by_watchpoint)
2307         (linux_nat_stopped_data_address)
2308         (linux_nat_stopped_by_sw_breakpoint)
2309         (linux_nat_supports_stopped_by_sw_breakpoint)
2310         (linux_nat_stopped_by_hw_breakpoint)
2311         (linux_nat_supports_stopped_by_hw_breakpoint, linux_nat_wait)
2312         (linux_nat_kill, linux_nat_mourn_inferior)
2313         (linux_nat_xfer_partial, linux_nat_thread_alive)
2314         (linux_nat_update_thread_list, linux_nat_pid_to_str)
2315         (linux_nat_thread_name, linux_child_pid_to_exec_file)
2316         (linux_child_static_tracepoint_markers_by_strid)
2317         (linux_nat_is_async_p, linux_nat_can_async_p)
2318         (linux_nat_supports_non_stop, linux_nat_always_non_stop_p)
2319         (linux_nat_supports_multi_process)
2320         (linux_nat_supports_disable_randomization, linux_nat_async)
2321         (linux_nat_stop, linux_nat_close, linux_nat_thread_address_space)
2322         (linux_nat_core_of_thread, linux_nat_filesystem_is_local)
2323         (linux_nat_fileio_open, linux_nat_fileio_readlink)
2324         (linux_nat_fileio_unlink, linux_nat_thread_events): Refactor as
2325         methods of linux_nat_target.
2326         (linux_nat_wait_1, linux_xfer_siginfo, linux_proc_xfer_partial)
2327         (linux_proc_xfer_spu, linux_nat_xfer_osdata): Remove target_ops
2328         parameter.
2329         (check_stopped_by_watchpoint): Adjust.
2330         (linux_xfer_partial): Delete.
2331         (linux_target_install_ops, linux_target, linux_nat_add_target):
2332         Delete.
2333         (linux_nat_target::linux_nat_target): New.
2334         * linux-nat.h: Include "inf-ptrace.h".
2335         (linux_nat_target): New.
2336         (linux_target, linux_target_install_ops, linux_nat_add_target):
2337         Delete function declarations.
2338         (linux_target): Declare global.
2339         * linux-thread-db.c (thread_db_target): New.
2340         (thread_db_target::thread_db_target): New.
2341         (thread_db_ops): Delete.
2342         (the_thread_db_target): New.
2343         (thread_db_detach, thread_db_wait, thread_db_mourn_inferior)
2344         (thread_db_update_thread_list, thread_db_pid_to_str)
2345         (thread_db_extra_thread_info)
2346         (thread_db_thread_handle_to_thread_info)
2347         (thread_db_get_thread_local_address, thread_db_get_ada_task_ptid)
2348         (thread_db_resume): Refactor as methods of thread_db_target.
2349         (init_thread_db_ops): Delete.
2350         (_initialize_thread_db): Remove reference to init_thread_db_ops.
2351         * x86-linux-nat.c: Don't include "linux-nat.h".
2352         (super_post_startup_inferior): Delete.
2353         (x86_linux_nat_target::~x86_linux_nat_target): New.
2354         (x86_linux_child_post_startup_inferior)
2355         (x86_linux_read_description, x86_linux_enable_btrace)
2356         (x86_linux_disable_btrace, x86_linux_teardown_btrace)
2357         (x86_linux_read_btrace, x86_linux_btrace_conf): Refactor as
2358         methods of x86_linux_nat_target.
2359         (x86_linux_create_target): Delete.  Bits folded ...
2360         (x86_linux_add_target): ... here.  Now takes a linux_nat_target
2361         pointer.
2362         * x86-linux-nat.h: Include "linux-nat.h" and "x86-nat.h".
2363         (x86_linux_nat_target): New class.
2364         (x86_linux_create_target): Delete.
2365         (x86_linux_add_target): Now takes a linux_nat_target pointer.
2366         * x86-nat.c (x86_insert_watchpoint, x86_remove_watchpoint)
2367         (x86_region_ok_for_watchpoint, x86_stopped_data_address)
2368         (x86_stopped_by_watchpoint, x86_insert_hw_breakpoint)
2369         (x86_remove_hw_breakpoint, x86_can_use_hw_breakpoint)
2370         (x86_stopped_by_hw_breakpoint): Remove target_ops parameter and
2371         make extern.
2372         (x86_use_watchpoints): Delete.
2373         * x86-nat.h: Include "breakpoint.h" and "target.h".
2374         (x86_use_watchpoints): Delete.
2375         (x86_can_use_hw_breakpoint, x86_region_ok_for_hw_watchpoint)
2376         (x86_stopped_by_watchpoint, x86_stopped_data_address)
2377         (x86_insert_watchpoint, x86_remove_watchpoint)
2378         (x86_insert_hw_breakpoint, x86_remove_hw_breakpoint)
2379         (x86_stopped_by_hw_breakpoint): New declarations.
2380         (x86_nat_target): New template class.
2381
2382         * ppc-linux-nat.c (ppc_linux_nat_target): New class.
2383         (the_ppc_linux_nat_target): New.
2384         (ppc_linux_fetch_inferior_registers)
2385         (ppc_linux_can_use_hw_breakpoint)
2386         (ppc_linux_region_ok_for_hw_watchpoint)
2387         (ppc_linux_ranged_break_num_registers)
2388         (ppc_linux_insert_hw_breakpoint, ppc_linux_remove_hw_breakpoint)
2389         (ppc_linux_insert_mask_watchpoint)
2390         (ppc_linux_remove_mask_watchpoint)
2391         (ppc_linux_can_accel_watchpoint_condition)
2392         (ppc_linux_insert_watchpoint, ppc_linux_remove_watchpoint)
2393         (ppc_linux_stopped_data_address, ppc_linux_stopped_by_watchpoint)
2394         (ppc_linux_watchpoint_addr_within_range)
2395         (ppc_linux_masked_watch_num_registers)
2396         (ppc_linux_store_inferior_registers, ppc_linux_auxv_parse)
2397         (ppc_linux_read_description): Refactor as methods of
2398         ppc_linux_nat_target.
2399         (_initialize_ppc_linux_nat): Adjust.  Set linux_target.
2400
2401         * procfs.c (procfs_xfer_partial): Delete forward declaration.
2402         (procfs_target): New class.
2403         (the_procfs_target): New.
2404         (procfs_target): Delete function.
2405         (procfs_auxv_parse, procfs_attach, procfs_detach)
2406         (procfs_fetch_registers, procfs_store_registers, procfs_wait)
2407         (procfs_xfer_partial, procfs_resume, procfs_pass_signals)
2408         (procfs_files_info, procfs_kill_inferior, procfs_mourn_inferior)
2409         (procfs_create_inferior, procfs_update_thread_list)
2410         (procfs_thread_alive, procfs_pid_to_str)
2411         (procfs_can_use_hw_breakpoint, procfs_stopped_by_watchpoint)
2412         (procfs_stopped_data_address, procfs_insert_watchpoint)
2413         (procfs_remove_watchpoint, procfs_region_ok_for_hw_watchpoint)
2414         (proc_find_memory_regions, procfs_info_proc)
2415         (procfs_make_note_section): Refactor as methods of procfs_target.
2416         (_initialize_procfs): Adjust.
2417         * sol-thread.c (sol_thread_target): New class.
2418         (sol_thread_ops): Now a sol_thread_target.
2419         (sol_thread_detach, sol_thread_resume, sol_thread_wait)
2420         (sol_thread_fetch_registers, sol_thread_store_registers)
2421         (sol_thread_xfer_partial, sol_thread_mourn_inferior)
2422         (sol_thread_alive, solaris_pid_to_str, sol_update_thread_list)
2423         (sol_get_ada_task_ptid): Refactor as methods of sol_thread_target.
2424         (init_sol_thread_ops): Delete.
2425         (_initialize_sol_thread): Adjust.  Remove references to
2426         init_sol_thread_ops and complete_target_initialization.
2427
2428         * windows-nat.c (windows_nat_target): New class.
2429         (windows_fetch_inferior_registers)
2430         (windows_store_inferior_registers, windows_resume, windows_wait)
2431         (windows_attach, windows_detach, windows_pid_to_exec_file)
2432         (windows_files_info, windows_create_inferior)
2433         (windows_mourn_inferior, windows_interrupt, windows_kill_inferior)
2434         (windows_close, windows_pid_to_str, windows_xfer_partial)
2435         (windows_get_tib_address, windows_get_ada_task_ptid)
2436         (windows_thread_name, windows_thread_alive): Refactor as
2437         windows_nat_target methods.
2438         (do_initial_windows_stuff): Adjust.
2439         (windows_target): Delete function.
2440         (_initialize_windows_nat): Adjust.
2441
2442         * darwin-nat.c (darwin_resume, darwin_wait_to, darwin_interrupt)
2443         (darwin_mourn_inferior, darwin_kill_inferior)
2444         (darwin_create_inferior, darwin_attach, darwin_detach)
2445         (darwin_pid_to_str, darwin_thread_alive, darwin_xfer_partial)
2446         (darwin_pid_to_exec_file, darwin_get_ada_task_ptid)
2447         (darwin_supports_multi_process): Refactor as darwin_nat_target
2448         methods.
2449         (darwin_resume_to, darwin_files_info): Delete.
2450         (_initialize_darwin_inferior): Rename to ...
2451         (_initialize_darwin_nat): ... this.  Adjust to C++ification.
2452         * darwin-nat.h: Include "inf-child.h".
2453         (darwin_nat_target): New class.
2454         (darwin_complete_target): Delete.
2455         * i386-darwin-nat.c (i386_darwin_nat_target): New class.
2456         (darwin_target): New.
2457         (i386_darwin_fetch_inferior_registers)
2458         (i386_darwin_store_inferior_registers): Refactor as methods of
2459         darwin_nat_target.
2460         (darwin_complete_target): Delete, with ...
2461         (_initialize_i386_darwin_nat): ... bits factored out here.
2462
2463         * alpha-linux-nat.c (alpha_linux_nat_target): New class.
2464         (the_alpha_linux_nat_target): New.
2465         (alpha_linux_register_u_offset): Refactor as
2466         alpha_linux_nat_target method.
2467         (_initialize_alpha_linux_nat): Adjust.
2468         * linux-nat-trad.c (inf_ptrace_register_u_offset): Delete.
2469         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
2470         (inf_ptrace_store_register, inf_ptrace_store_registers): Refact as
2471         methods of linux_nat_trad_target.
2472         (linux_trad_target): Delete.
2473         * linux-nat-trad.h (linux_trad_target): Delete function.
2474         (linux_nat_trad_target): New class.
2475         * mips-linux-nat.c (mips_linux_nat_target): New class.
2476         (super_fetch_registers, super_store_registers, super_close):
2477         Delete.
2478         (the_mips_linux_nat_target): New.
2479         (mips64_linux_regsets_fetch_registers)
2480         (mips64_linux_regsets_store_registers)
2481         (mips64_linux_fetch_registers, mips64_linux_store_registers)
2482         (mips_linux_register_u_offset, mips_linux_read_description)
2483         (mips_linux_can_use_hw_breakpoint)
2484         (mips_linux_stopped_by_watchpoint)
2485         (mips_linux_stopped_data_address)
2486         (mips_linux_region_ok_for_hw_watchpoint)
2487         (mips_linux_insert_watchpoint, mips_linux_remove_watchpoint)
2488         (mips_linux_close): Refactor as methods of mips_linux_nat.
2489         (_initialize_mips_linux_nat): Adjust to C++ification.
2490
2491         * aix-thread.c (aix_thread_target): New class.
2492         (aix_thread_ops): Now an aix_thread_target.
2493         (aix_thread_detach, aix_thread_resume, aix_thread_wait)
2494         (aix_thread_fetch_registers, aix_thread_store_registers)
2495         (aix_thread_xfer_partial, aix_thread_mourn_inferior)
2496         (aix_thread_thread_alive, aix_thread_pid_to_str)
2497         (aix_thread_extra_thread_info, aix_thread_get_ada_task_ptid):
2498         Refactor as methods of aix_thread_target.
2499         (init_aix_thread_ops): Delete.
2500         (_initialize_aix_thread): Remove references to init_aix_thread_ops
2501         and complete_target_initialization.
2502         * rs6000-nat.c (rs6000_xfer_shared_libraries): Delete.
2503         (rs6000_nat_target): New class.
2504         (the_rs6000_nat_target): New.
2505         (rs6000_fetch_inferior_registers, rs6000_store_inferior_registers)
2506         (rs6000_xfer_partial, rs6000_wait, rs6000_create_inferior)
2507         (rs6000_xfer_shared_libraries): Refactor as rs6000_nat_target methods.
2508         (super_create_inferior): Delete.
2509         (_initialize_rs6000_nat): Adjust to C++ification.
2510
2511         * arm-linux-nat.c (arm_linux_nat_target): New class.
2512         (the_arm_linux_nat_target): New.
2513         (arm_linux_fetch_inferior_registers)
2514         (arm_linux_store_inferior_registers, arm_linux_read_description)
2515         (arm_linux_can_use_hw_breakpoint, arm_linux_insert_hw_breakpoint)
2516         (arm_linux_remove_hw_breakpoint)
2517         (arm_linux_region_ok_for_hw_watchpoint)
2518         (arm_linux_insert_watchpoint, arm_linux_remove_watchpoint)
2519         (arm_linux_stopped_data_address, arm_linux_stopped_by_watchpoint)
2520         (arm_linux_watchpoint_addr_within_range): Refactor as methods of
2521         arm_linux_nat_target.
2522         (_initialize_arm_linux_nat): Adjust to C++ification.
2523
2524         * aarch64-linux-nat.c (aarch64_linux_nat_target): New class.
2525         (the_aarch64_linux_nat_target): New.
2526         (aarch64_linux_fetch_inferior_registers)
2527         (aarch64_linux_store_inferior_registers)
2528         (aarch64_linux_child_post_startup_inferior)
2529         (aarch64_linux_read_description)
2530         (aarch64_linux_can_use_hw_breakpoint)
2531         (aarch64_linux_insert_hw_breakpoint)
2532         (aarch64_linux_remove_hw_breakpoint)
2533         (aarch64_linux_insert_watchpoint, aarch64_linux_remove_watchpoint)
2534         (aarch64_linux_region_ok_for_hw_watchpoint)
2535         (aarch64_linux_stopped_data_address)
2536         (aarch64_linux_stopped_by_watchpoint)
2537         (aarch64_linux_watchpoint_addr_within_range)
2538         (aarch64_linux_can_do_single_step): Refactor as methods of
2539         aarch64_linux_nat_target.
2540         (super_post_startup_inferior): Delete.
2541         (_initialize_aarch64_linux_nat): Adjust to C++ification.
2542
2543         * hppa-linux-nat.c (hppa_linux_nat_target): New class.
2544         (the_hppa_linux_nat_target): New.
2545         (hppa_linux_fetch_inferior_registers)
2546         (hppa_linux_store_inferior_registers): Refactor as methods of
2547         hppa_linux_nat_target.
2548         (_initialize_hppa_linux_nat): Adjust to C++ification.
2549
2550         * ia64-linux-nat.c (ia64_linux_nat_target): New class.
2551         (the_ia64_linux_nat_target): New.
2552         (ia64_linux_insert_watchpoint, ia64_linux_remove_watchpoint)
2553         (ia64_linux_stopped_data_address)
2554         (ia64_linux_stopped_by_watchpoint, ia64_linux_fetch_registers)
2555         (ia64_linux_store_registers, ia64_linux_xfer_partial): Refactor as
2556         ia64_linux_nat_target methods.
2557         (super_xfer_partial): Delete.
2558         (_initialize_ia64_linux_nat): Adjust to C++ification.
2559
2560         * m32r-linux-nat.c (m32r_linux_nat_target): New class.
2561         (the_m32r_linux_nat_target): New.
2562         (m32r_linux_fetch_inferior_registers)
2563         (m32r_linux_store_inferior_registers): Refactor as
2564         m32r_linux_nat_target methods.
2565         (_initialize_m32r_linux_nat): Adjust to C++ification.
2566
2567         * m68k-linux-nat.c (m68k_linux_nat_target): New class.
2568         (the_m68k_linux_nat_target): New.
2569         (m68k_linux_fetch_inferior_registers)
2570         (m68k_linux_store_inferior_registers): Refactor as
2571         m68k_linux_nat_target methods.
2572         (_initialize_m68k_linux_nat): Adjust to C++ification.
2573
2574         * s390-linux-nat.c (s390_linux_nat_target): New class.
2575         (the_s390_linux_nat_target): New.
2576         (s390_linux_fetch_inferior_registers)
2577         (s390_linux_store_inferior_registers, s390_stopped_by_watchpoint)
2578         (s390_insert_watchpoint, s390_remove_watchpoint)
2579         (s390_can_use_hw_breakpoint, s390_insert_hw_breakpoint)
2580         (s390_remove_hw_breakpoint, s390_region_ok_for_hw_watchpoint)
2581         (s390_auxv_parse, s390_read_description): Refactor as methods of
2582         s390_linux_nat_target.
2583         (_initialize_s390_nat): Adjust to C++ification.
2584
2585         * sparc-linux-nat.c (sparc_linux_nat_target): New class.
2586         (the_sparc_linux_nat_target): New.
2587         (_initialize_sparc_linux_nat): Adjust to C++ification.
2588         * sparc-nat.c (sparc_fetch_inferior_registers)
2589         (sparc_store_inferior_registers): Remove target_ops parameter.
2590         * sparc-nat.h (sparc_fetch_inferior_registers)
2591         (sparc_store_inferior_registers): Remove target_ops parameter.
2592         * sparc64-linux-nat.c (sparc64_linux_nat_target): New class.
2593         (the_sparc64_linux_nat_target): New.
2594         (_initialize_sparc64_linux_nat): Adjust to C++ification.
2595
2596         * spu-linux-nat.c (spu_linux_nat_target): New class.
2597         (the_spu_linux_nat_target): New.
2598         (spu_child_post_startup_inferior, spu_child_post_attach)
2599         (spu_child_wait, spu_fetch_inferior_registers)
2600         (spu_store_inferior_registers, spu_xfer_partial)
2601         (spu_can_use_hw_breakpoint): Refactor as spu_linux_nat_target
2602         methods.
2603         (_initialize_spu_nat): Adjust to C++ification.
2604
2605         * tilegx-linux-nat.c (tilegx_linux_nat_target): New class.
2606         (the_tilegx_linux_nat_target): New.
2607         (fetch_inferior_registers, store_inferior_registers):
2608         Refactor as methods.
2609         (_initialize_tile_linux_nat): Adjust to C++ification.
2610
2611         * xtensa-linux-nat.c (xtensa_linux_nat_target): New class.
2612         (the_xtensa_linux_nat_target): New.
2613         (xtensa_linux_fetch_inferior_registers)
2614         (xtensa_linux_store_inferior_registers): Refactor as
2615         xtensa_linux_nat_target methods.
2616         (_initialize_xtensa_linux_nat): Adjust to C++ification.
2617
2618         * fbsd-nat.c (USE_SIGTRAP_SIGINFO): Delete.
2619         (fbsd_pid_to_exec_file, fbsd_find_memory_regions)
2620         (fbsd_find_memory_regions, fbsd_info_proc, fbsd_xfer_partial)
2621         (fbsd_thread_alive, fbsd_pid_to_str, fbsd_thread_name)
2622         (fbsd_update_thread_list, fbsd_resume, fbsd_wait)
2623         (fbsd_stopped_by_sw_breakpoint)
2624         (fbsd_supports_stopped_by_sw_breakpoint, fbsd_follow_fork)
2625         (fbsd_insert_fork_catchpoint, fbsd_remove_fork_catchpoint)
2626         (fbsd_insert_vfork_catchpoint, fbsd_remove_vfork_catchpoint)
2627         (fbsd_post_startup_inferior, fbsd_post_attach)
2628         (fbsd_insert_exec_catchpoint, fbsd_remove_exec_catchpoint)
2629         (fbsd_set_syscall_catchpoint)
2630         (super_xfer_partial, super_resume, super_wait)
2631         (fbsd_supports_stopped_by_hw_breakpoint): Delete.
2632         (fbsd_handle_debug_trap): Remove target_ops parameter.
2633         (fbsd_nat_add_target): Delete.
2634         * fbsd-nat.h: Include "inf-ptrace.h".
2635         (fbsd_nat_add_target): Delete.
2636         (USE_SIGTRAP_SIGINFO): Define.
2637         (fbsd_nat_target): New class.
2638
2639         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers)
2640         (amd64bsd_store_inferior_registers): Remove target_ops parameter.
2641         (amd64bsd_target): Delete.
2642         * amd64-bsd-nat.h: New file.
2643         * amd64-fbsd-nat.c: Include "amd64-bsd-nat.h" instead of
2644         "x86-bsd-nat.h".
2645         (amd64_fbsd_nat_target): New class.
2646         (the_amd64_fbsd_nat_target): New.
2647         (amd64fbsd_read_description): Refactor as method of
2648         amd64_fbsd_nat_target.
2649         (amd64_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
2650         (_initialize_amd64fbsd_nat): Adjust to C++ification.
2651         * amd64-nat.h (amd64bsd_target): Delete function declaration.
2652         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers)
2653         (i386bsd_store_inferior_registers): Remove target_ops parameter.
2654         (i386bsd_target): Delete.
2655         * i386-bsd-nat.h (i386bsd_target): Delete function declaration.
2656         (i386bsd_fetch_inferior_registers)
2657         (i386bsd_store_inferior_registers): Declare.
2658         (i386_bsd_nat_target): New class.
2659         * i386-fbsd-nat.c (i386_fbsd_nat_target): New class.
2660         (the_i386_fbsd_nat_target): New.
2661         (i386fbsd_resume, i386fbsd_read_description): Refactor as
2662         i386_fbsd_nat_target methods.
2663         (i386_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New.
2664         (_initialize_i386fbsd_nat): Adjust to C++ification.
2665         * x86-bsd-nat.c (super_mourn_inferior): Delete.
2666         (x86bsd_mourn_inferior, x86bsd_target): Delete.
2667         (_initialize_x86_bsd_nat): Adjust to C++ification.
2668         * x86-bsd-nat.h: Include "x86-nat.h".
2669         (x86bsd_target): Delete declaration.
2670         (x86bsd_nat_target): New class.
2671
2672         * aarch64-fbsd-nat.c (aarch64_fbsd_nat_target): New class.
2673         (the_aarch64_fbsd_nat_target): New.
2674         (aarch64_fbsd_fetch_inferior_registers)
2675         (aarch64_fbsd_store_inferior_registers): Refactor as methods of
2676         aarch64_fbsd_nat_target.
2677         (_initialize_aarch64_fbsd_nat): Adjust to C++ification.
2678         * alpha-bsd-nat.c (alpha_bsd_nat_target): New class.
2679         (the_alpha_bsd_nat_target): New.
2680         (alphabsd_fetch_inferior_registers)
2681         (alphabsd_store_inferior_registers): Refactor as
2682         alpha_bsd_nat_target methods.
2683         (_initialize_alphabsd_nat): Refactor as methods of
2684         alpha_bsd_nat_target.
2685         * amd64-nbsd-nat.c: Include "amd64-bsd-nat.h".
2686         (the_amd64_nbsd_nat_target): New.
2687         (_initialize_amd64nbsd_nat): Adjust to C++ification.
2688         * amd64-obsd-nat.c: Include "amd64-bsd-nat.h".
2689         (the_amd64_obsd_nat_target): New.
2690         (_initialize_amd64obsd_nat): Adjust to C++ification.
2691         * arm-fbsd-nat.c (arm_fbsd_nat_target): New.
2692         (the_arm_fbsd_nat_target): New.
2693         (arm_fbsd_fetch_inferior_registers)
2694         (arm_fbsd_store_inferior_registers, arm_fbsd_read_description):
2695         (_initialize_arm_fbsd_nat): Refactor as methods of
2696         arm_fbsd_nat_target.
2697         (_initialize_arm_fbsd_nat): Adjust to C++ification.
2698         * arm-nbsd-nat.c (arm_netbsd_nat_target): New class.
2699         (the_arm_netbsd_nat_target): New.
2700         (armnbsd_fetch_registers, armnbsd_store_registers): Refactor as
2701         arm_netbsd_nat_target.
2702         (_initialize_arm_netbsd_nat): Adjust to C++ification.
2703         * hppa-nbsd-nat.c (hppa_nbsd_nat_target): New class.
2704         (the_hppa_nbsd_nat_target): New.
2705         (hppanbsd_fetch_registers, hppanbsd_store_registers): Refactor as
2706         hppa_nbsd_nat_target methods.
2707         (_initialize_hppanbsd_nat): Adjust to C++ification.
2708         * hppa-obsd-nat.c (hppa_obsd_nat_target): New class.
2709         (the_hppa_obsd_nat_target): New.
2710         (hppaobsd_fetch_registers, hppaobsd_store_registers): Refactor as
2711         methods of hppa_obsd_nat_target.
2712         (_initialize_hppaobsd_nat): Adjust to C++ification.  Use
2713         add_target.
2714         * i386-nbsd-nat.c (the_i386_nbsd_nat_target): New.
2715         (_initialize_i386nbsd_nat): Adjust to C++ification.  Use
2716         add_target.
2717         * i386-obsd-nat.c (the_i386_obsd_nat_target): New.
2718         (_initialize_i386obsd_nat): Use add_target.
2719         * m68k-bsd-nat.c (m68k_bsd_nat_target): New class.
2720         (the_m68k_bsd_nat_target): New.
2721         (m68kbsd_fetch_inferior_registers)
2722         (m68kbsd_store_inferior_registers): Refactor as methods of
2723         m68k_bsd_nat_target.
2724         (_initialize_m68kbsd_nat): Adjust to C++ification.
2725         * mips-fbsd-nat.c (mips_fbsd_nat_target): New class.
2726         (the_mips_fbsd_nat_target): New.
2727         (mips_fbsd_fetch_inferior_registers)
2728         (mips_fbsd_store_inferior_registers): Refactor as methods of
2729         mips_fbsd_nat_target.
2730         (_initialize_mips_fbsd_nat): Adjust to C++ification.  Use
2731         add_target.
2732         * mips-nbsd-nat.c (mips_nbsd_nat_target): New class.
2733         (the_mips_nbsd_nat_target): New.
2734         (mipsnbsd_fetch_inferior_registers)
2735         (mipsnbsd_store_inferior_registers): Refactor as methods of
2736         mips_nbsd_nat_target.
2737         (_initialize_mipsnbsd_nat): Adjust to C++ification.
2738         * mips64-obsd-nat.c (mips64_obsd_nat_target): New class.
2739         (the_mips64_obsd_nat_target): New.
2740         (mips64obsd_fetch_inferior_registers)
2741         (mips64obsd_store_inferior_registers): Refactor as methods of
2742         mips64_obsd_nat_target.
2743         (_initialize_mips64obsd_nat): Adjust to C++ification.  Use
2744         add_target.
2745         * nbsd-nat.c (nbsd_pid_to_exec_file): Refactor as method of
2746         nbsd_nat_target.
2747         * nbsd-nat.h: Include "inf-ptrace.h".
2748         (nbsd_nat_target): New class.
2749         * obsd-nat.c (obsd_pid_to_str, obsd_update_thread_list)
2750         (obsd_wait): Refactor as methods of obsd_nat_target.
2751         (obsd_add_target): Delete.
2752         * obsd-nat.h: Include "inf-ptrace.h".
2753         (obsd_nat_target): New class.
2754         * ppc-fbsd-nat.c (ppc_fbsd_nat_target): New class.
2755         (the_ppc_fbsd_nat_target): New.
2756         (ppcfbsd_fetch_inferior_registers)
2757         (ppcfbsd_store_inferior_registers): Refactor as methods of
2758         ppc_fbsd_nat_target.
2759         (_initialize_ppcfbsd_nat): Adjust to C++ification.  Use
2760         add_target.
2761         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): New class.
2762         (the_ppc_nbsd_nat_target): New.
2763         (ppcnbsd_fetch_inferior_registers)
2764         (ppcnbsd_store_inferior_registers): Refactor as methods of
2765         ppc_nbsd_nat_target.
2766         (_initialize_ppcnbsd_nat): Adjust to C++ification.
2767         * ppc-obsd-nat.c (ppc_obsd_nat_target): New class.
2768         (the_ppc_obsd_nat_target): New.
2769         (ppcobsd_fetch_registers, ppcobsd_store_registers): Refactor as
2770         methods of ppc_obsd_nat_target.
2771         (_initialize_ppcobsd_nat): Adjust to C++ification.  Use
2772         add_target.
2773         * sh-nbsd-nat.c (sh_nbsd_nat_target): New class.
2774         (the_sh_nbsd_nat_target): New.
2775         (shnbsd_fetch_inferior_registers)
2776         (shnbsd_store_inferior_registers): Refactor as methods of
2777         sh_nbsd_nat_target.
2778         (_initialize_shnbsd_nat): Adjust to C++ification.
2779         * sparc-nat.c (sparc_xfer_wcookie): Make extern.
2780         (inf_ptrace_xfer_partial): Delete.
2781         (sparc_xfer_partial, sparc_target): Delete.
2782         * sparc-nat.h (sparc_fetch_inferior_registers)
2783         (sparc_store_inferior_registers, sparc_xfer_wcookie): Declare.
2784         (sparc_target): Delete function declaration.
2785         (sparc_target): New template class.
2786         * sparc-nbsd-nat.c (the_sparc_nbsd_nat_target): New.
2787         (_initialize_sparcnbsd_nat): Adjust to C++ification.
2788         * sparc64-fbsd-nat.c (the_sparc64_fbsd_nat_target): New.
2789         (_initialize_sparc64fbsd_nat): Adjust to C++ification.  Use
2790         add_target.
2791         * sparc64-nbsd-nat.c (the_sparc64_nbsd_nat_target): New.
2792         (_initialize_sparc64nbsd_nat): Adjust to C++ification.
2793         * sparc64-obsd-nat.c (the_sparc64_obsd_nat_target): New.
2794         (_initialize_sparc64obsd_nat): Adjust to C++ification.  Use
2795         add_target.
2796         * vax-bsd-nat.c (vax_bsd_nat_target): New class.
2797         (the_vax_bsd_nat_target): New.
2798         (vaxbsd_fetch_inferior_registers)
2799         (vaxbsd_store_inferior_registers): Refactor as vax_bsd_nat_target
2800         methods.
2801         (_initialize_vaxbsd_nat): Adjust to C++ification.
2802
2803         * bsd-kvm.c (bsd_kvm_target): New class.
2804         (bsd_kvm_ops): Now a bsd_kvm_target.
2805         (bsd_kvm_open, bsd_kvm_close, bsd_kvm_xfer_partial)
2806         (bsd_kvm_files_info, bsd_kvm_fetch_registers)
2807         (bsd_kvm_thread_alive, bsd_kvm_pid_to_str): Refactor as methods of
2808         bsd_kvm_target.
2809         (bsd_kvm_return_one): Delete.
2810         (bsd_kvm_add_target): Adjust to C++ification.
2811
2812         * nto-procfs.c (nto_procfs_target, nto_procfs_target_native)
2813         (nto_procfs_target_procfs): New classes.
2814         (procfs_open_1, procfs_thread_alive, procfs_update_thread_list)
2815         (procfs_files_info, procfs_pid_to_exec_file, procfs_attach)
2816         (procfs_post_attach, procfs_wait, procfs_fetch_registers)
2817         (procfs_xfer_partial, procfs_detach, procfs_insert_breakpoint)
2818         (procfs_remove_breakpoint, procfs_insert_hw_breakpoint)
2819         (procfs_remove_hw_breakpoint, procfs_resume)
2820         (procfs_mourn_inferior, procfs_create_inferior, procfs_interrupt)
2821         (procfs_kill_inferior, procfs_store_registers)
2822         (procfs_pass_signals, procfs_pid_to_str, procfs_can_run): Refactor
2823         as methods of nto_procfs_target.
2824         (nto_procfs_ops): Now an nto_procfs_target_procfs.
2825         (nto_native_ops): Delete.
2826         (procfs_open, procfs_native_open): Delete.
2827         (nto_native_ops): Now an nto_procfs_target_native.
2828         (init_procfs_targets): Adjust to C++ification.
2829         (procfs_can_use_hw_breakpoint, procfs_remove_hw_watchpoint)
2830         (procfs_insert_hw_watchpoint, procfs_stopped_by_watchpoint):
2831         Refactor as methods of nto_procfs_target.
2832
2833         * go32-nat.c (go32_nat_target): New class.
2834         (the_go32_nat_target): New.
2835         (go32_attach, go32_resume, go32_wait, go32_fetch_registers)
2836         (go32_store_registers, go32_xfer_partial, go32_files_info)
2837         (go32_kill_inferior, go32_create_inferior, go32_mourn_inferior)
2838         (go32_terminal_init, go32_terminal_info, go32_terminal_inferior)
2839         (go32_terminal_ours, go32_pass_ctrlc, go32_thread_alive)
2840         (go32_pid_to_str): Refactor as methods of go32_nat_target.
2841         (go32_target): Delete.
2842         (_initialize_go32_nat): Adjust to C++ification.
2843
2844         * gnu-nat.c (gnu_wait, gnu_resume, gnu_kill_inferior)
2845         (gnu_mourn_inferior, gnu_create_inferior, gnu_attach, gnu_detach)
2846         (gnu_stop, gnu_thread_alive, gnu_xfer_partial)
2847         (gnu_find_memory_regions, gnu_pid_to_str): Refactor as methods of
2848         gnu_nat_target.
2849         (gnu_target): Delete.
2850         * gnu-nat.h (gnu_target): Delete.
2851         (gnu_nat_target): New class.
2852         * i386-gnu-nat.c (gnu_base_target): New.
2853         (i386_gnu_nat_target): New class.
2854         (the_i386_gnu_nat_target): New.
2855         (_initialize_i386gnu_nat): Adjust to C++ification.
2856
2857 2018-05-02  Pedro Alves  <palves@redhat.com>
2858
2859         * bfd-target.c (target_bfd_xclose): Rename to ...
2860         (target_bfd_close): ... this.
2861         (target_bfd_reopen): Adjust.
2862         * target.c (target_close): Remove references to to_xclose.
2863         * target.h (target_ops::to_xclose): Delete.
2864         (target_ops::to_close): Update comments.
2865
2866 2018-05-02  Pedro Alves  <palves@redhat.com>
2867
2868         * alpha-linux-nat.c: Include "linux-nat-trad.h" instead of
2869         "linux-nat.h".
2870         * configure.nat (alpha-linux, linux-mips): Add linux-nat-trad.o.
2871         * inf-ptrace.c (inf_ptrace_register_u_offset)
2872         (inf_ptrace_fetch_register, inf_ptrace_fetch_registers)
2873         (inf_ptrace_store_register, inf_ptrace_store_registers)
2874         (inf_ptrace_trad_target): Move to ...
2875         * linux-nat-trad.c: ... this new file.
2876         * linux-nat-trad.h: New file.
2877         * linux-nat.c (linux_target_install_ops): Make extern.
2878         (linux_trad_target): Delete.
2879         * linux-nat.h (linux_trad_target): Delete declaration.
2880         (linux_target_install_ops): Declare.
2881         * mips-linux-nat.c: Include "linux-nat-trad.h" instead of
2882         "linux-nat.h".
2883
2884 2018-05-02  Pedro Alves  <palves@redhat.com>
2885
2886         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
2887         procfs_target/add_target here.
2888         * procfs.c (procfs_target): Make static.
2889         (_initialize_procfs): Call add_target here.
2890         * procfs.h (struct target_ops): Remove forward declaration.
2891         (procfs_target): Remove declaration.
2892         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Delete.
2893
2894 2018-05-02  Pedro Alves  <palves@redhat.com>
2895
2896         * procfs.c (procfs_stopped_by_watchpoint)
2897         (procfs_insert_watchpoint, procfs_remove_watchpoint)
2898         (procfs_region_ok_for_hw_watchpoint, procfs_stopped_data_address):
2899         Forward declare.
2900         (procfs_use_watchpoints): Delete, move contents...
2901         (procfs_target): ... here.
2902         * procfs.h (procfs_use_watchpoints): Delete declaration.
2903         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
2904         procfs_use_watchpoints.
2905         * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Don't call
2906         procfs_use_watchpoints.
2907
2908 2018-05-02  Tom Tromey  <tom@tromey.com>
2909
2910         PR python/20084:
2911         * python/python.c (gdbpy_parameter_value): Handle var_zuinteger
2912         and var_zuinteger_unlimited.
2913         * python/py-param.c (struct parm_constant): Add PARAM_ZUINTEGER
2914         and PARAM_ZUINTEGER_UNLIMITED.
2915         (set_parameter_value): Handle var_zuinteger and
2916         var_zuinteger_unlimited.
2917         (add_setshow_generic): Likewise.
2918         (parmpy_init): Likewise.
2919
2920 2018-04-28  Dan Robertson  <danlrobertson89@gmail.com>
2921
2922         PR rust/23124
2923         * gdb/rust-exp.y (convert_params_to_types): Ensure that the params
2924         pointer is not null before dereferencing it.
2925
2926 2018-04-30  Tom Tromey  <tom@tromey.com>
2927
2928         * darwin-nat-info.c (darwin_debug_regions_recurse): Remove use of
2929         is_mi_like_p.
2930
2931 2018-04-30  Tom Tromey  <tom@tromey.com>
2932
2933         * breakpoint.c (mention): Remove use of is_mi_like_p.
2934         (print_mention_ranged_breakpoint): Likewise.
2935         * break-catch-throw.c (print_it_exception_catchpoint): Remove use
2936         of is_mi_like_p.
2937
2938 2018-04-30  Tom Tromey  <tom@tromey.com>
2939
2940         * tracepoint.c (tvariables_info_1): Remove use of is_mi_like_p.
2941
2942 2018-04-30  Tom Tromey  <tom@tromey.com>
2943
2944         * spu-tdep.c (info_spu_mailbox_list, info_spu_dma_cmdlist)
2945         (info_spu_event_command): Remove some uses of is_mi_like_p.
2946
2947 2018-04-30  Tom Tromey  <tom@tromey.com>
2948
2949         * python/py-framefilter.c (py_print_single_arg)
2950         (enumerate_locals, py_print_args, py_print_frame): Remove some
2951         uses of is_mi_like_p.
2952
2953 2018-04-30  Tom Tromey  <tom@tromey.com>
2954
2955         * ui-out.c: Update.
2956         * cli-out.h (cli_ui_out::do_is_mi_like_p): Update.
2957         * ui-out.h (ui_out::is_mi_like_p): Now const.
2958         (ui_out::do_is_mi_like_p): Now const.
2959         * mi/mi-out.h (mi_ui_out::do_is_mi_like_p): Update.
2960
2961 2018-04-30  Tom Tromey  <tom@tromey.com>
2962
2963         * varobj.c (varobj_set_visualizer): Use new_reference.
2964         * python/python.c (gdbpy_decode_line): Use new_reference.
2965         * python/py-cmd.c (cmdpy_function, cmdpy_completer_helper): Use
2966         new_reference.
2967
2968 2018-04-30  Tom Tromey  <tom@tromey.com>
2969
2970         * varobj.c (install_new_value): Use new_reference.
2971         * value.h (value_incref): Return void.  Swap intro comment with
2972         value_decref.
2973         * value.c (set_value_parent): Use new_reference.
2974         (value_incref): Return void.  Update intro comment.
2975         (release_value): Use new_reference.
2976         * dwarf2loc.c (dwarf2_evaluate_loc_desc_full): Use new_reference.
2977
2978 2018-04-30  Tom Tromey  <tom@tromey.com>
2979
2980         * symfile-mem.c (symbol_file_add_from_memory): Use new_reference.
2981         * gdb_bfd.h (new_bfd_ref): Remove.
2982         (gdb_bfd_open): Update comment.
2983         * gdb_bfd.c (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr)
2984         (gdb_bfd_openw, gdb_bfd_openr_iovec, gdb_bfd_record_inclusion)
2985         (gdb_bfd_fdopenr): Use new_reference.
2986         * exec.c (exec_file_attach): Use new_reference.
2987
2988 2018-04-30  Tom Tromey  <tom@tromey.com>
2989
2990         * common/gdb_ref_ptr.h (ref_ptr::new_reference): New static
2991         method.
2992
2993 2018-04-30  Tom Tromey  <tom@tromey.com>
2994
2995         * jit.c (jit_read_code_entry): Use type_align.
2996         * i386-tdep.c (i386_gdbarch_init): Don't call
2997         set_gdbarch_long_long_align_bit.
2998         * gdbarch.sh: Remove long_long_align_bit.
2999         * gdbarch.c, gdbarch.h: Rebuild.
3000         * arc-tdep.c (arc_type_align): New function.
3001         (arc_gdbarch_init): Use arc_type_align.  Don't call
3002         set_gdbarch_long_long_align_bit.
3003
3004 2018-04-30  Tom Tromey  <tom@tromey.com>
3005
3006         * rust-lang.c (rust_type_alignment): Remove.
3007         (rust_composite_type): Use type_align.
3008
3009 2018-04-30  Tom Tromey  <tom@tromey.com>
3010
3011         * NEWS: Mention Type.align.
3012         * python/py-type.c (typy_get_alignof): New function.
3013         (type_object_getset): Add "alignof".
3014
3015 2018-04-30  Tom Tromey  <tom@tromey.com>
3016
3017         PR exp/17095:
3018         * NEWS: Update.
3019         * std-operator.def (UNOP_ALIGNOF): New operator.
3020         * expprint.c (dump_subexp_body_standard) <case UNOP_ALIGNOF>:
3021         New.
3022         * eval.c (evaluate_subexp_standard) <case UNOP_ALIGNOF>: New.
3023         * c-lang.c (c_op_print_tab): Add alignof.
3024         * c-exp.y (ALIGNOF): New token.
3025         (exp): Add "ALIGNOF" production.
3026         (ident_tokens): Add _Alignof and alignof.
3027
3028 2018-04-30  Tom Tromey  <tom@tromey.com>
3029
3030         * i386-tdep.c (i386_type_align): New function.
3031         (i386_gdbarch_init): Update.
3032         * gdbarch.sh (type_align): New method.
3033         * gdbarch.c, gdbarch.h: Rebuild.
3034         * arch-utils.h (default_type_align): Declare.
3035         * arch-utils.c (default_type_align): New function.
3036         * gdbtypes.h (TYPE_ALIGN_BITS): New define.
3037         (struct type) <align_log2>: New field.
3038         <instance_flags>: Now a bitfield.
3039         (TYPE_RAW_ALIGN): New macro.
3040         (type_align, type_raw_align, set_type_align): Declare.
3041         * gdbtypes.c (type_align, type_raw_align, set_type_align): New
3042         functions.
3043         * dwarf2read.c (quirk_rust_enum): Set type alignment.
3044         (get_alignment, maybe_set_alignment): New functions.
3045         (read_structure_type, read_enumeration_type, read_array_type)
3046         (read_set_type, read_tag_pointer_type, read_tag_reference_type)
3047         (read_subrange_type, read_base_type): Set type alignment.
3048
3049 2018-04-30  Simon Marchi  <simon.marchi@ericsson.com>
3050
3051         * dwarf2read.c (read_index_from_section): Use bool.
3052
3053 2018-04-29  Fabian Groffen  <grobian@gentoo.org>
3054
3055         PR gdb/22950
3056         * proc-events.c (init_syscall_table): Guard usage os SYS_uuidsys
3057         with #ifdef.
3058
3059 2018-04-29  John Reiser  <jreiser@BitWagon.com>
3060
3061         PR build/22873
3062         * gdb/Makefile.in: (.c:.l, .c:.y): Write the target only in the
3063         last step, and do it atomically.
3064
3065 2018-04-27  Alexandre Oliva  <aoliva@redhat.com>
3066
3067         * compile/compile-c-types.c (convert_int, convert_float):
3068         Update for C FE v1.
3069
3070 2018-04-27  Tom Tromey  <tom@tromey.com>
3071
3072         PR rust/22545:
3073         * rust-lang.c (rust_inclusive_range_type_p): New function.
3074         (rust_range): Handle inclusive ranges.
3075         (rust_compute_range): Likewise.
3076         * rust-exp.y (struct rust_op) <inclusive>: New field.
3077         (DOTDOTEQ): New constant.
3078         (range_expr): Add "..=" productions.
3079         (operator_tokens): Add "..=" token.
3080         (ast_range): Add "inclusive" parameter.
3081         (convert_ast_to_expression) <case OP_RANGE>: Handle inclusive
3082         ranges.
3083         * parse.c (operator_length_standard) <case OP_RANGE>: Handle new
3084         bounds values.
3085         * expression.h (enum range_type) <NONE_BOUND_DEFAULT_EXCLUSIVE,
3086         LOW_BOUND_DEFAULT_EXCLUSIVE>: New constants.
3087         Update comments.
3088         * expprint.c (print_subexp_standard): Handle new bounds values.
3089         (dump_subexp_body_standard): Likewise.
3090
3091 2018-04-27  Tom Tromey  <tom@tromey.com>
3092
3093         * configure: Rebuild.
3094         * warning.m4 (AM_GDB_WARNINGS): Add -Wsuggest-override.
3095         * dwarf2loc.c (class dwarf_evaluate_loc_desc): Use "override", not
3096         "OVERRIDE".
3097         (class symbol_needs_eval_context): Likewise.
3098         * dwarf2read.c (mock_mapped_index::symbol_name_count)
3099         (mock_mapped_index::symbol_name_at): Use "override".  Remove
3100         "virtual".
3101         * dwarf2-frame.c (dwarf_expr_executor::get_addr_index): Use
3102         "override".
3103         (class dwarf_expr_executor): Use "override", not "OVERRIDE".
3104         * aarch64-tdep.c (instruction_reader::read): Use "override".
3105         (instruction_reader_test::read): Likewise.
3106         * arm-tdep.c (instruction_reader::read): Use "override".
3107         (instruction_reader_thumb::read): Likewise.
3108
3109 2018-04-26  Andrzej Kaczmarek  <andrzej.kaczmarek@codecoup.pl>
3110
3111         PR remote/9665
3112         * remote.c (send_g_packet): Use putpkt/getpkt/packet_check_result
3113         instead of remote_send.
3114         (remote_send): Remove.
3115
3116 2018-04-26  Pedro Alves  <palves@redhat.com>
3117
3118         * elfread.c (elf_gnu_ifunc_resolver_return_stop): Use
3119         find_function_start_sal instead of find_pc_line.
3120
3121 2018-04-26  Pedro Alves  <palves@redhat.com>
3122
3123         * breakpoint.c (set_breakpoint_location_function): Handle
3124         mst_data_gnu_ifunc.
3125         * c-exp.y (variable production): Handle mst_data_gnu_ifunc.
3126         * elfread.c (elf_symtab_read): Give data symbols with
3127         BSF_GNU_INDIRECT_FUNCTION set mst_data_gnu_ifunc type.
3128         (elf_rel_plt_read): Update comment.
3129         * linespec.c (convert_linespec_to_sals): Handle
3130         mst_data_gnu_ifunc.
3131         (minsym_found): Handle mst_data_gnu_ifunc.
3132         * minsyms.c (msymbol_is_function, minimal_symbol_reader::record)
3133         (find_solib_trampoline_target): Handle mst_data_gnu_ifunc.
3134         * parse.c (find_minsym_type_and_address): Handle
3135         mst_data_gnu_ifunc.
3136         * symmisc.c (dump_msymbols): Handle mst_data_gnu_ifunc.
3137         * symtab.c (find_gnu_ifunc): Handle mst_data_gnu_ifunc.
3138         * symtab.h (minimal_symbol_type) <mst_text_gnu_ifunc>: Update
3139         comment.
3140         <mst_data_gnu_ifunc>: New enumerator.
3141
3142 2018-04-26  Pedro Alves  <palves@redhat.com>
3143
3144         * minsyms.c (lookup_minimal_symbol_by_pc_section_1): Rename to ...
3145         (lookup_minimal_symbol_by_pc_section): ... this.  Replace
3146         'want_trampoline' parameter by a lookup_msym_prefer parameter.
3147         Handle it.
3148         (lookup_minimal_symbol_by_pc_section): Delete old implementation.
3149         (lookup_minimal_symbol_by_pc): Adjust.
3150         (in_gnu_ifunc_stub): Prefer GNU ifunc symbols.
3151         (lookup_solib_trampoline_symbol_by_pc): Adjust.
3152         * minsyms.h (lookup_msym_prefer): New enum.
3153         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
3154         parameter by a lookup_msym_prefer parameter.
3155
3156 2018-04-26  Pedro Alves  <palves@redhat.com>
3157
3158         * elfread.c (elf_gnu_ifunc_record_cache): Check if the symbol name
3159         ends in "@plt" instead of looking at the symbol's section.
3160
3161 2018-04-26  Pedro Alves  <palves@redhat.com>
3162
3163         * blockframe.c (cache_pc_function_is_gnu_ifunc): Delete.  Remove
3164         all references.
3165         (find_pc_partial_function_gnu_ifunc): Rename to ...
3166         (find_pc_partial_function): ... this, and remove references to
3167         'is_gnu_ifunc_p'.
3168         (find_pc_partial_function): Delete old implementation.
3169         * symtab.h (find_pc_partial_function_gnu_ifunc): Delete.
3170
3171 2018-04-26  Pedro Alves  <palves@redhat.com>
3172
3173         * linespec.c (struct bound_minimal_symbol_search_key): New.
3174         (convert_linespec_to_sals): Sort minimal symbols earlier.  Don't
3175         skip first line if we found a GNU ifunc minimal symbol by name.
3176         (compare_msymbols): Change parameters to work with a destructured
3177         lhs minsym.
3178         (compare_msymbols_for_qsort, compare_msymbols_for_bsearch): New
3179         functions.
3180
3181 2018-04-26  Pedro Alves  <palves@redhat.com>
3182
3183         * breakpoint.c (set_breakpoint_location_function): Don't resolve
3184         ifunc targets here.  Instead, if we have an ifunc minsym, use its
3185         address/name.
3186         (add_location_to_breakpoint): Store the minsym and the objfile in
3187         the breakpoint location.
3188         * breakpoint.h (bp_location) <msymbol, objfile>: New fields.
3189         * linespec.c (minsym_found): Resolve GNU ifunc targets here.
3190         Record the minsym in the sal.
3191         * symtab.h (symtab_and_line) <msymbol>: New field.
3192
3193 2018-04-26  Pedro Alves  <palves@redhat.com>
3194
3195         * elfread.c (elf_gnu_ifunc_resolve_by_got): Don't write to *ADDR_P
3196         unless we actually resolved the ifunc.
3197
3198 2018-04-26  Pedro Alves  <palves@redhat.com>
3199
3200         * c-exp.y (variable production): Prefer ifunc minsyms over
3201         regular function symbols.
3202         * symtab.c (find_gnu_ifunc): New function.
3203         * minsyms.h (lookup_msym_prefer): New enum.
3204         (lookup_minimal_symbol_by_pc_section): Replace 'want_trampoline'
3205         parameter by a lookup_msym_prefer parameter.
3206         * symtab.h (find_gnu_ifunc): New declaration.
3207
3208 2018-04-26  Pedro Alves  <palves@redhat.com>
3209
3210         * blockframe.c (find_gnu_ifunc_target_type): New function.
3211         (find_function_type): New.
3212         * eval.c (evaluate_var_msym_value): For GNU ifunc types, always
3213         return a value with a memory address.
3214         (eval_call): For calls to GNU ifunc functions, try to find the
3215         type of the target function from the type that the resolver
3216         returns.
3217         * gdbtypes.c (objfile_type): Don't install a return type for ifunc
3218         symbols.
3219         * infcall.c (find_function_return_type): Delete.
3220         (find_function_addr): Add 'function_type' parameter.  For calls to
3221         GNU ifunc functions, try to find the type of the target function
3222         from the type that the resolver returns, and return it via
3223         FUNCTION_TYPE.
3224         (call_function_by_hand_dummy): Adjust to use the function type
3225         returned by find_function_addr.
3226         (find_function_addr): Add 'function_type' parameter and move
3227         description here.
3228         * symtab.h (find_function_type, find_gnu_ifunc_target_type): New
3229         declarations.
3230
3231 2018-04-26  Pedro Alves  <palves@redhat.com>
3232
3233         * c-exp.y (variable production): Skip finding an alias for ifunc
3234         symbols.
3235
3236 2018-04-26  Pedro Alves  <palves@redhat.com>
3237
3238         * elfread.c (elf_rel_plt_read): Look for relocations for .got.plt too.
3239
3240 2018-04-25  Pedro Alves  <palves@redhat.com>
3241
3242         * infcmd.c (kill_command): Print the pid as string, not the whole
3243         thread's ptid.  Add comment.  s/has been killed/killed/ in output
3244         message.
3245         * remote.c (remote_detach_1): Print the pid as string, not the
3246         whole thread's ptid.
3247
3248 2018-04-24  Jan Kratochvil  <jan.kratochvil@redhat.com>
3249             Sergio Durigan Junior  <sergiodj@redhat.com>
3250             Pedro Alves  <palves@redhat.com>
3251
3252         * infcmd.c (kill_command): Print message when inferior has
3253         been killed.
3254         * inferior.c (print_inferior_events): Remove 'static'.  Set as
3255         '1'.
3256         (add_inferior): Improve message printed when
3257         'print_inferior_events' is on.
3258         (exit_inferior): Remove message printed when
3259         'print_inferior_events' is on.
3260         (detach_inferior): Improve message printed when
3261         'print_inferior_events' is on.
3262         (initialize_inferiors): Use 'add_inferior_silent' to set
3263         'current_inferior_'.
3264         * inferior.h (print_inferior_events): Declare here as
3265         'extern'.
3266         * infrun.c (follow_fork_inferior): Print '[Attaching...]' or
3267         '[Detaching...]' messages when 'print_inferior_events' is on.
3268         Use 'add_thread_silent' instead of 'add_thread'.  Add '[' and ']'
3269         as prefix/suffix for messages.  Remove periods.  Fix erroneous
3270         'Detaching after fork from child...', replace it by '... from
3271         parent...'.
3272         (handle_vfork_child_exec_or_exit): Add '[' and ']' as
3273         prefix/suffix when printing 'Detaching...' messages.  Print
3274         them when 'print_inferior_events' is on.
3275         * remote.c (remote_detach_1): Print message when detaching
3276         from inferior and '!is_fork_parent'.
3277
3278 2018-04-24  Tom Tromey  <tom@tromey.com>
3279
3280         * cli-out.h: Reindent.
3281
3282 2018-04-24  Tom Tromey  <tom@tromey.com>
3283
3284         * cli-out.c (cli_ui_out::out_field_fmt): Remove.
3285         (cli_ui_out::do_field_string): Use fputs_filtered.
3286         * cli-out.h (class cli_ui_out) <out_field_fmt>: Remove.
3287
3288 2018-04-23  Tom Tromey  <tom@tromey.com>
3289
3290         * guile/scm-frame.c (gdbscm_frame_read_var): Use
3291         gdb::unique_xmalloc_ptr.
3292
3293 2018-04-23  Tom Tromey  <tom@tromey.com>
3294
3295         * configure: Rebuild.
3296
3297 2018-04-22  Rajendra SY  <rajendra.sy@gmail.com>
3298
3299         PR gdb/23095
3300         * gdb/testsuite/gdb.base/break-probes.exp: Pass shlib_load to
3301         prepare_for_testing.  Set normal_bp to r_debug_state if target
3302         is bsd.
3303
3304 2018-04-21  Pedro Alves  <palves@redhat.com>
3305             Rajendra SY  <rajendra.sy@gmail.com>
3306
3307         * inf-ptrace.c (inf_ptrace_attach): Mark the thread as executing.
3308         * remote.c (extended_remote_attach): In all-stop mode, mark the
3309         thread as executing.
3310
3311 2018-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3312
3313         * thread.c (thread_apply_all_command): Fix comment.
3314         (thread_command): Fix comment.
3315
3316 2018-04-10  Alan Hayward  <alan.hayward@arm.com>
3317
3318         * common/tdesc.h (tdesc_create_feature): Remove xml filename
3319         parameter.
3320         * features/aarch64-core.c (create_feature_aarch64_core):
3321         Regenerate.
3322         * features/aarch64-fpu.c (create_feature_aarch64_fpu):
3323         Likewise.
3324         * features/i386/32bit-avx.c (create_feature_i386_32bit_avx):
3325         Likewise.
3326         * features/i386/32bit-avx512.c
3327         (create_feature_i386_32bit_avx512): Likewise.
3328         * features/i386/32bit-core.c (create_feature_i386_32bit_core):
3329         Likewise.
3330         * features/i386/32bit-linux.c (create_feature_i386_32bit_linux):
3331         Likewise.
3332         * features/i386/32bit-mpx.c (create_feature_i386_32bit_mpx):
3333         Likewise.
3334         * features/i386/32bit-pkeys.c (create_feature_i386_32bit_pkeys):
3335         Likewise.
3336         * features/i386/32bit-sse.c (create_feature_i386_32bit_sse):
3337         Likewise.
3338         * features/i386/64bit-avx.c (create_feature_i386_64bit_avx):
3339         Likewise.
3340         * features/i386/64bit-avx512.c
3341         (create_feature_i386_64bit_avx512): Likewise.
3342         * features/i386/64bit-core.c (create_feature_i386_64bit_core):
3343         Likewise.
3344         * features/i386/64bit-linux.c (create_feature_i386_64bit_linux):
3345         Likewise.
3346         * features/i386/64bit-mpx.c (create_feature_i386_64bit_mpx):
3347         Likewise.
3348         * features/i386/64bit-pkeys.c (create_feature_i386_64bit_pkeys):
3349         Likewise.
3350         * features/i386/64bit-segments.c
3351         (create_feature_i386_64bit_segments): Likewise.
3352         * features/i386/64bit-sse.c (create_feature_i386_64bit_sse):
3353         Likewise.
3354         * features/i386/x32-core.c
3355         (create_feature_i386_x32_core): Likewise.
3356         * features/tic6x-c6xp.c (create_feature_tic6x_c6xp): Likewise.
3357         * features/tic6x-core.c (create_feature_tic6x_core): Likewise.
3358         * features/tic6x-gp.c (create_feature_tic6x_gp): Likewise.
3359         * target-descriptions.c: In generated code, don't pass xml
3360         filename.
3361
3362 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3363
3364         * common/tdesc.c (print_xml_feature::visit_pre): Add xml parsing.
3365         (print_xml_feature::visit_post): Likewise.
3366         (print_xml_feature::visit): Likewise.
3367         * common/tdesc.h (tdesc_get_features_xml): Use const tdesc.
3368         (print_xml_feature): Add new class.
3369         * regformats/regdat.sh: Null xmltarget on feature targets.
3370         * target-descriptions.c (struct target_desc): Add xmltarget.
3371         (maintenance_check_tdesc_xml_convert): Add unittest function.
3372         (tdesc_get_features_xml): Add function to get xml.
3373         (maintenance_check_xml_descriptions): Test xml generation.
3374         * xml-tdesc.c (string_read_description_xml): Add function.
3375         * xml-tdesc.h (string_read_description_xml): Add declaration.
3376
3377 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3378
3379         * features/Makefile: Add feature marker to targets with new style
3380         target descriptions.
3381         * regformats/aarch64.dat: Regenerate.
3382         * regformats/i386/amd64-avx-avx512-linux.dat: Likewise.
3383         * regformats/i386/amd64-avx-linux.dat: Likewise.
3384         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Likewise.
3385         * regformats/i386/amd64-avx-mpx-linux.dat: Likewise.
3386         * regformats/i386/amd64-linux.dat: Likewise.
3387         * regformats/i386/amd64-mpx-linux.dat: Likewise.
3388         * regformats/i386/amd64.dat: Likewise.
3389         * regformats/i386/i386-avx-avx512-linux.dat: Likewise.
3390         * regformats/i386/i386-avx-linux.dat: Likewise.
3391         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Likewise.
3392         * regformats/i386/i386-avx-mpx-linux.dat: Likewise.
3393         * regformats/i386/i386-linux.dat: Likewise.
3394         * regformats/i386/i386-mmx-linux.dat: Likewise.
3395         * regformats/i386/i386-mpx-linux.dat: Likewise.
3396         * regformats/i386/i386.dat: Likewise.
3397         * regformats/i386/x32-avx-avx512-linux.dat: Likewise.
3398         * regformats/i386/x32-avx-linux.dat: Likewise.
3399         * regformats/i386/x32-linux.dat: Likewise.
3400         * regformats/tic6x-c62x-linux.dat: Likewise.
3401         * regformats/tic6x-c64x-linux.dat: Likewise.
3402         * regformats/tic6x-c64xp-linux.dat: Likewise.
3403         * regformats/regdat.sh: Parse feature marker.
3404
3405 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3406
3407         * common/tdesc.h (tdesc_architecture_name): Add new declaration.
3408         (tdesc_osabi_name): Likewise.
3409         * target-descriptions.c (tdesc_architecture_name): Add new
3410         function.
3411         (tdesc_osabi_name): Likewise.
3412
3413 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3414
3415         * common/tdesc.c (tdesc_predefined_type): Move to here.
3416         (tdesc_named_type): Likewise.
3417         (tdesc_create_vector): Likewise.
3418         (tdesc_create_struct): Likewise.
3419         (tdesc_set_struct_size): Likewise.
3420         (tdesc_create_union): Likewise.
3421         (tdesc_create_flags): Likewise.
3422         (tdesc_create_enum): Likewise.
3423         (tdesc_add_field): Likewise.
3424         (tdesc_add_typed_bitfield): Likewise.
3425         (tdesc_add_bitfield): Likewise.
3426         (tdesc_add_flag): Likewise.
3427         (tdesc_add_enum_value): Likewise.
3428         * common/tdesc.h (struct tdesc_type_builtin): Likewise.
3429         (struct tdesc_type_vector): Likewise.
3430         (struct tdesc_type_field): Likewise.
3431         (struct tdesc_type_with_fields): Likewise.
3432         (tdesc_create_enum): Add declaration.
3433         (tdesc_add_typed_bitfield): Likewise.
3434         (tdesc_add_enum_value): Likewise.
3435         * target-descriptions.c (tdesc_type_field): Move from here.
3436         (tdesc_type_builtin): Likewise.
3437         (tdesc_type_vector): Likewise.
3438         (tdesc_type_with_fields): Likewise.
3439         (tdesc_predefined_types): Likewise.
3440         (tdesc_named_type): Likewise.
3441         (tdesc_create_vector): Likewise.
3442         (tdesc_create_struct): Likewise.
3443         (tdesc_set_struct_size): Likewise.
3444         (tdesc_create_union): Likewise.
3445         (tdesc_create_flags): Likewise.
3446         (tdesc_create_enum): Likewise.
3447         (tdesc_add_field): Likewise.
3448         (tdesc_add_typed_bitfield): Likewise.
3449         (tdesc_add_bitfield): Likewise.
3450         (tdesc_add_flag): Likewise.
3451         (tdesc_add_enum_value): Likewise.
3452         * gdb/target-descriptions.h (tdesc_create_enum): Likewise.
3453         (tdesc_add_typed_bitfield): Likewise.
3454         (tdesc_add_enum_value): Likewise.
3455
3456 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3457
3458         * common/tdesc.c (tdesc_feature::accept): Move to here.
3459         (tdesc_feature::operator==): Likewise.
3460         (tdesc_create_reg): Likewise.
3461         * common/tdesc.h (tdesc_type_kind): Likewise.
3462         (struct tdesc_type): Likewise.
3463         (struct tdesc_feature): Likewise.
3464         * regformats/regdat.sh: Create a feature.
3465         * target-descriptions.c (tdesc_type_kind): Move from here.
3466         (tdesc_type): Likewise.
3467         (tdesc_type_up): Likewise.
3468         (tdesc_feature): Likewise.
3469         (tdesc_create_reg): Likewise.
3470
3471 2018-04-18  Alan Hayward  <alan.hayward@arm.com>
3472
3473         * Makefile.in: Add arch/tdesc.c
3474         * common/tdesc.c: New file.
3475         * common/tdesc.h (tdesc_element_visitor): Move to here.
3476         (tdesc_element): Likewise.
3477         (tdesc_reg): Likewise.
3478         (tdesc_reg_up): Likewise.
3479         * regformats/regdef.h (reg): Add offset to constructors.
3480         * target-descriptions.c (tdesc_element_visitor): Move from here.
3481         (tdesc_element): Likewise.
3482         (tdesc_reg): Likewise.
3483         (tdesc_reg_up): Likewise.
3484
3485 2018-04-17  Tom Tromey  <tom@tromey.com>
3486
3487         * dwarf2read.c (quirk_rust_enum): Conditionally drop the
3488         discriminant field.
3489
3490 2018-04-17  Tom Tromey  <tom@tromey.com>
3491
3492         * dwarf2read.c (quirk_rust_enum): Handle unions correctly.
3493
3494 2018-04-17  Andreas Arnez  <arnez@linux.vnet.ibm.com>
3495
3496         * symtab.c (print_symbol_info): Skip printing filename and line
3497         number when `last' is NULL.
3498         (symtab_symbol_info): Use empty string instead of NULL for first
3499         invocation of print_symbol_info.
3500         (rbreak_command): Pass NULL to `last' parameter of
3501         print_symbol_info.
3502
3503 2018-04-16  Simon Marchi  <simon.marchi@ericsson.com>
3504
3505         * linux-tdep.c (linux_spu_make_corefile_notes): Return note_data
3506         instead of nullptr.
3507
3508 2018-04-16  Pedro Alves  <palves@redhat.com>
3509
3510         * MAINTAINERS (sh): Remove.
3511         * Makefile.in (ALL_TARGET_OBS): Remove sh64-tdep.o.
3512         (HFILES_NO_SRCDIR): Remove sh64-tdep.h.
3513         (ALLDEPFILES): Remove sh64-tdep.c.
3514         * NEWS: Mentions that support for SH-5/SH64 is removed.
3515         * configure.tgt (sh*-*-linux*): Remove reference to sh64-tdep.o.
3516         (sh*-*-openbsd*): Ditto.
3517         (sh64-*-elf*): Remove.
3518         (sh*): Remove.
3519         * regcache.c (cooked_write_test): Remove bfd_mach_sh5 case.
3520         * sh-linux-tdep.c: Remove reference to bfd_mach_sh5.
3521         * sh-tdep.c: No longer include "sh64-tdep.h".
3522         (sh_gdbarch_init): Remove reference to bfd_mach_sh5.
3523         * sh64-tdep.c, sh64-tdep.h: Remove files.
3524
3525 2018-04-16  Pedro Alves  <palves@redhat.com>
3526
3527         * MAINTAINERS: Remove m88k.
3528         * Makefile.in (ALL_TARGET_OBS): Remove m88k-tdep.o.
3529         (HFILES_NO_SRCDIR): Remove m88k-tdep.h.
3530         (ALLDEPFILES): Remove m88k-bsd-nat.c and m88k-tdep.c.
3531         * NEWS: Mention that support for m88k was removed.
3532         * configure.host (m88*-*-*): Remove support.
3533         * configure.nat (m88k-*-*): Remove support.
3534         * configure.tgt (m88*-*-openbsd*): Remove.
3535         * m88k-bsd-nat.c, m88k-tdep.c, m88k-tdep.h: Delete.
3536
3537 2018-04-15  Simon Marchi  <simon.marchi@polymtl.ca>
3538
3539         * configure.tgt (x86_tobjs): New variable.
3540         (amd64_tobjs, i386_tobjs): Use it.
3541
3542 2018-04-13  Andreas Arnez  <arnez@linux.vnet.ibm.com>
3543
3544         * symtab.c (print_symbol_info): Precede the symbol definition by
3545         the line number when available.
3546         * NEWS: Advertise this enhancement.
3547
3548 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3549
3550         * NEWS (New options): announce set/show record btrace cpu.
3551         * btrace.c: Include record-btrace.h.
3552         (btrace_compute_ftrace_pt): Skip enabling errata workarounds if
3553         the vendor is unknown.
3554         (btrace_compute_ftrace_1): Add cpu parameter.  Update callers.
3555         Maybe overwrite the btrace configuration's cpu.
3556         (btrace_compute_ftrace): Add cpu parameter.  Update callers.
3557         (btrace_fetch): Add cpu parameter.  Update callers.
3558         (btrace_maint_update_pt_packets): Call record_btrace_get_cpu.
3559         Maybe overwrite the btrace configuration's cpu.  Skip enabling
3560         errata workarounds if the vendor is unknown.
3561         * python/py-record-btrace.c: Include record-btrace.h.
3562         (recpy_bt_begin, recpy_bt_end, recpy_bt_instruction_history)
3563         (recpy_bt_function_call_history): Call record_btrace_get_cpu.
3564         * record-btrace.c (record_btrace_cpu_state_kind): New.
3565         (record_btrace_cpu): New.
3566         (set_record_btrace_cpu_cmdlist): New.
3567         (record_btrace_get_cpu): New.
3568         (require_btrace_thread, record_btrace_info)
3569         (record_btrace_resume_thread): Call record_btrace_get_cpu.
3570         (cmd_set_record_btrace_cpu_none): New.
3571         (cmd_set_record_btrace_cpu_auto): New.
3572         (cmd_set_record_btrace_cpu): New.
3573         (cmd_show_record_btrace_cpu): New.
3574         (_initialize_record_btrace): Initialize set/show record btrace cpu
3575         commands.
3576         * record-btrace.h (record_btrace_get_cpu): New.
3577
3578 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3579
3580         * record.c (set_record_command): Fix typo in message.
3581
3582 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3583
3584         * record-btrace.c (cmd_set_record_btrace): Print sub-commands.
3585
3586 2018-04-13  Markus Metzger  <markus.t.metzger@intel.com>
3587
3588         * infrun.c (process_event_stop_test): Call
3589         gdbarch_in_indirect_branch_thunk.
3590         * gdbarch.sh (in_indirect_branch_thunk): New.
3591         * gdbarch.c: Regenerated.
3592         * gdbarch.h: Regenerated.
3593         * x86-tdep.h: New.
3594         * x86-tdep.c: New.
3595         * Makefile.in (ALL_TARGET_OBS): Add x86-tdep.o.
3596         (HFILES_NO_SRCDIR): Add x86-tdep.h.
3597         (ALLDEPFILES): Add x86-tdep.c.
3598         * arch-utils.h (default_in_indirect_branch_thunk): New.
3599         * arch-utils.c (default_in_indirect_branch_thunk): New.
3600         * i386-tdep: Include x86-tdep.h.
3601         (i386_in_indirect_branch_thunk): New.
3602         (i386_elf_init_abi): Set in_indirect_branch_thunk gdbarch
3603         function.
3604         * amd64-tdep: Include x86-tdep.h.
3605         (amd64_in_indirect_branch_thunk): New.
3606         (amd64_init_abi): Set in_indirect_branch_thunk gdbarch function.
3607
3608 2018-04-12  Jan Kratochvil  <jan.kratochvil@redhat.com>
3609
3610         PR gdb/23053
3611         * dwarf-index-write.c (data_buf::grow) (write_one_signatured_type)
3612         (recursively_write_psymbols) (debug_names::recursively_write_psymbols)
3613         (debug_names::write_one_signatured_type): Fix -D_GLIBCXX_DEBUG
3614         regression.
3615
3616 2018-04-12  Tom Tromey  <tom@tromey.com>
3617
3618         * rust-lang.c (rust_print_struct_def): Remove univariant code.
3619         (rust_evaluate_subexp): Likewise.
3620
3621 2018-04-12  Pedro Alves  <palves@redhat.com>
3622
3623         * procfs.c (procfs_detach): Make forward declaration's prototype
3624         match definition's protototype.
3625         (proc_get_LDT_entry): Remove stale do_cleanups call.
3626
3627 2018-04-12  Pedro Alves  <palves@redhat.com>
3628
3629         * target.h (target_ops::to_has_exited): Delete.
3630         (target_has_exited): Delete.
3631         * target-delegates.c: Regenerate.
3632
3633 2018-04-11  Pedro Alves  <palves@redhat.com>
3634
3635         * target.c (fileio_fh_t::t): Add comment.
3636         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
3637         (target_fileio_close): Handle a NULL target.
3638         (invalidate_fileio_fh): New.
3639         (target_close): Call it.
3640         * remote.c (remote_hostio_send_command): No longer check whether
3641         remote_desc is open.
3642
3643 2018-04-11  Pedro Alves  <palves@redhat.com>
3644
3645         * target.c (fileio_fh_t): Make it a named struct instead of a
3646         typedef.
3647         (fileio_fh_t::is_closed): New method.
3648         (DEF_VEC_O (fileio_fh_t)): Remove.
3649         (fileio_fhandles): Now a std::vector.
3650         (is_closed_fileio_fh): Delete.
3651         (acquire_fileio_fd): Adjust.  Rename parameters.
3652         (release_fileio_fd): Adjust.
3653         (fileio_fd_to_fh): Reimplement as a function instead of a macro.
3654         (target_fileio_pwrite, target_fileio_pread, target_fileio_fstat)
3655         (target_fileio_close): Adjust.
3656
3657 2018-04-10  Simon Marchi  <simon.marchi@ericsson.com>
3658
3659         * auto-load.c (auto_load_safe_path_vec_update): Iterate by
3660         index.
3661
3662 2018-04-10  Pedro Alves  <palves@redhat.com>
3663
3664         * gdbthread.h (finish_thread_state_cleanup): Delete declaration.
3665         (scoped_finish_thread_state): New class.
3666         * infcmd.c (run_command_1): Use it instead of finish_thread_state
3667         cleanup.
3668         * infrun.c (proceed, prepare_for_detach, wait_for_inferior)
3669         (fetch_inferior_event, normal_stop): Likewise.
3670         * thread.c (finish_thread_state_cleanup): Delete.
3671
3672 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3673             Pedro Alves  <palves@redhat.com>
3674
3675         * value.c: Include "selftest.h" and "common/array-view.h".
3676         (struct range) <operator ==>: New.
3677         (test_ranges_contain): New.
3678         (check_ranges_vector): New.
3679         (test_insert_into_bit_range_vector): New.
3680         (_initialize_values): Register selftests.
3681         * common/array-view.h (operator==, operator!=): New.
3682
3683 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3684
3685         * common/gdb_vecs.h (unordered_remove): Add overload that takes
3686         an iterator.
3687         * inline-frame.c: Include <algorithm>.
3688         (struct inline_state): Add constructor.
3689         (inline_state_s): Remove.
3690         (DEF_VEC_O(inline_state_s)): Remove.
3691         (inline_states): Change type to std::vector.
3692         (find_inline_frame_state): Adjust to std::vector.
3693         (allocate_inline_frame_state): Remove.
3694         (clear_inline_frame_state): Adjust to std::vector.
3695         (skip_inline_frames): Adjust to std::vector.
3696
3697 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3698
3699         * tracepoint.h (struct trace_state_variable): Add constructor.
3700         <name>: Change type to std::string.
3701         * tracepoint.c (tsv_s): Remove.
3702         (DEF_VEC_O(tsv_s)): Remove.
3703         (tvariables): Change to std::vector.
3704         (create_trace_state_variable): Adjust to std::vector.
3705         (find_trace_state_variable): Likewise.
3706         (find_trace_state_variable_by_number): Likewise.
3707         (delete_trace_state_variable): Likewise.
3708         (trace_variable_command): Adjust to std::string.
3709         (delete_trace_variable_command): Likewise.
3710         (tvariables_info_1): Adjust to std::vector.
3711         (save_trace_state_variables): Likewise.
3712         (start_tracing): Likewise.
3713         (merge_uploaded_trace_state_variables): Adjust to std::vector
3714         and std::string.
3715         * target.h (struct target_ops)
3716         <to_download_trace_state_variable>: Pass reference to
3717         trace_state_variable.
3718         * target-debug.h (target_debug_print_const_trace_state_variable_r): New.
3719         * target-delegates.c: Re-generate.
3720         * mi/mi-interp.c (mi_tsv_created): Adjust to std::string.
3721         (mi_tsv_deleted): Likewise.
3722         * mi/mi-main.c (mi_cmd_trace_frame_collected): Likewise.
3723         * remote.c (remote_download_trace_state_variable): Change
3724         pointer to reference and adjust.
3725         * make-target-delegates (parse_argtypes): Handle references.
3726         (write_function_header): Likewise.
3727         (munge_type): Likewise.
3728
3729 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3730
3731         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3732         string_view-selftests.c.
3733         * unittests/basic_string_view/capacity/1.cc: Adapt to GDB
3734         testsuite.
3735         * unittests/basic_string_view/cons/char/1.cc: Likewise.
3736         * unittests/basic_string_view/cons/char/2.cc: Likewise.
3737         * unittests/basic_string_view/cons/char/3.cc: Likewise.
3738         * unittests/basic_string_view/element_access/char/1.cc:
3739         Likewise.
3740         * unittests/basic_string_view/element_access/char/empty.cc:
3741         Likewise.
3742         * unittests/basic_string_view/element_access/char/front_back.cc:
3743         Likewise.
3744         * unittests/basic_string_view/inserters/char/2.cc: Likewise.
3745         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc:
3746         Likewise.
3747         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc:
3748         Likewise.
3749         * unittests/basic_string_view/modifiers/swap/char/1.cc:
3750         Likewise.
3751         * unittests/basic_string_view/operations/compare/char/1.cc:
3752         Likewise.
3753         * unittests/basic_string_view/operations/compare/char/13650.cc:
3754         Likewise.
3755         * unittests/basic_string_view/operations/copy/char/1.cc:
3756         Likewise.
3757         * unittests/basic_string_view/operations/data/char/1.cc:
3758         Likewise.
3759         * unittests/basic_string_view/operations/find/char/1.cc:
3760         Likewise.
3761         * unittests/basic_string_view/operations/find/char/2.cc:
3762         Likewise.
3763         * unittests/basic_string_view/operations/find/char/3.cc:
3764         Likewise.
3765         * unittests/basic_string_view/operations/find/char/4.cc:
3766         Likewise.
3767         * unittests/basic_string_view/operations/rfind/char/1.cc:
3768         Likewise.
3769         * unittests/basic_string_view/operations/rfind/char/2.cc:
3770         Likewise.
3771         * unittests/basic_string_view/operations/rfind/char/3.cc:
3772         Likewise.
3773         * unittests/basic_string_view/operations/substr/char/1.cc:
3774         Likewise.
3775         * unittests/basic_string_view/operators/char/2.cc: Likewise.
3776         * unittests/string_view-selftests.c: New file.
3777
3778 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3779
3780         * unittests/basic_string_view/capacity/1.cc: New file.
3781         * unittests/basic_string_view/capacity/empty_neg.cc: New file.
3782         * unittests/basic_string_view/cons/char/1.cc: New file.
3783         * unittests/basic_string_view/cons/char/2.cc: New file.
3784         * unittests/basic_string_view/cons/char/3.cc: New file.
3785         * unittests/basic_string_view/cons/wchar_t/1.cc: New file.
3786         * unittests/basic_string_view/cons/wchar_t/2.cc: New file.
3787         * unittests/basic_string_view/cons/wchar_t/3.cc: New file.
3788         * unittests/basic_string_view/element_access/char/1.cc: New file.
3789         * unittests/basic_string_view/element_access/char/2.cc: New file.
3790         * unittests/basic_string_view/element_access/char/empty.cc: New file.
3791         * unittests/basic_string_view/element_access/char/front_back.cc: New file.
3792         * unittests/basic_string_view/element_access/wchar_t/1.cc: New file.
3793         * unittests/basic_string_view/element_access/wchar_t/2.cc: New file.
3794         * unittests/basic_string_view/element_access/wchar_t/empty.cc: New file.
3795         * unittests/basic_string_view/element_access/wchar_t/front_back.cc: New file.
3796         * unittests/basic_string_view/include.cc: New file.
3797         * unittests/basic_string_view/inserters/char/1.cc: New file.
3798         * unittests/basic_string_view/inserters/char/2.cc: New file.
3799         * unittests/basic_string_view/inserters/char/3.cc: New file.
3800         * unittests/basic_string_view/inserters/pod/10081-out.cc: New file.
3801         * unittests/basic_string_view/inserters/wchar_t/1.cc: New file.
3802         * unittests/basic_string_view/inserters/wchar_t/2.cc: New file.
3803         * unittests/basic_string_view/inserters/wchar_t/3.cc: New file.
3804         * unittests/basic_string_view/literals/types.cc: New file.
3805         * unittests/basic_string_view/literals/values.cc: New file.
3806         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc: New file.
3807         * unittests/basic_string_view/modifiers/remove_prefix/wchar_t/1.cc: New file.
3808         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc: New file.
3809         * unittests/basic_string_view/modifiers/remove_suffix/wchar_t/1.cc: New file.
3810         * unittests/basic_string_view/modifiers/swap/char/1.cc: New file.
3811         * unittests/basic_string_view/modifiers/swap/wchar_t/1.cc: New file.
3812         * unittests/basic_string_view/operations/compare/char/1.cc: New file.
3813         * unittests/basic_string_view/operations/compare/char/13650.cc: New file.
3814         * unittests/basic_string_view/operations/compare/char/2.cc: New file.
3815         * unittests/basic_string_view/operations/compare/char/70483.cc: New file.
3816         * unittests/basic_string_view/operations/compare/wchar_t/1.cc: New file.
3817         * unittests/basic_string_view/operations/compare/wchar_t/13650.cc: New file.
3818         * unittests/basic_string_view/operations/compare/wchar_t/2.cc: New file.
3819         * unittests/basic_string_view/operations/copy/char/1.cc: New file.
3820         * unittests/basic_string_view/operations/copy/wchar_t/1.cc: New file.
3821         * unittests/basic_string_view/operations/data/char/1.cc: New file.
3822         * unittests/basic_string_view/operations/data/wchar_t/1.cc: New file.
3823         * unittests/basic_string_view/operations/find/char/1.cc: New file.
3824         * unittests/basic_string_view/operations/find/char/2.cc: New file.
3825         * unittests/basic_string_view/operations/find/char/3.cc: New file.
3826         * unittests/basic_string_view/operations/find/char/4.cc: New file.
3827         * unittests/basic_string_view/operations/find/wchar_t/1.cc: New file.
3828         * unittests/basic_string_view/operations/find/wchar_t/2.cc: New file.
3829         * unittests/basic_string_view/operations/find/wchar_t/3.cc: New file.
3830         * unittests/basic_string_view/operations/find/wchar_t/4.cc: New file.
3831         * unittests/basic_string_view/operations/rfind/char/1.cc: New file.
3832         * unittests/basic_string_view/operations/rfind/char/2.cc: New file.
3833         * unittests/basic_string_view/operations/rfind/char/3.cc: New file.
3834         * unittests/basic_string_view/operations/rfind/wchar_t/1.cc: New file.
3835         * unittests/basic_string_view/operations/rfind/wchar_t/2.cc: New file.
3836         * unittests/basic_string_view/operations/rfind/wchar_t/3.cc: New file.
3837         * unittests/basic_string_view/operations/string_conversion/1.cc: New file.
3838         * unittests/basic_string_view/operations/substr/char/1.cc: New file.
3839         * unittests/basic_string_view/operations/substr/wchar_t/1.cc: New file.
3840         * unittests/basic_string_view/operators/char/2.cc: New file.
3841         * unittests/basic_string_view/operators/wchar_t/2.cc: New file.
3842         * unittests/basic_string_view/range_access/char/1.cc: New file.
3843         * unittests/basic_string_view/range_access/wchar_t/1.cc: New file.
3844         * unittests/basic_string_view/requirements/explicit_instantiation/1.cc: New file.
3845         * unittests/basic_string_view/requirements/explicit_instantiation/char/1.cc: New file.
3846         * unittests/basic_string_view/requirements/explicit_instantiation/char16_t/1.cc: New file.
3847         * unittests/basic_string_view/requirements/explicit_instantiation/char32_t/1.cc: New file.
3848         * unittests/basic_string_view/requirements/explicit_instantiation/wchar_t/1.cc: New file.
3849         * unittests/basic_string_view/requirements/typedefs.cc: New file.
3850         * unittests/basic_string_view/typedefs.cc: New file.
3851         * unittests/basic_string_view/types/1.cc: New file.
3852
3853 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3854
3855         * common/gdb_string_view.h: Remove libstdc++ implementation
3856         details, adjust to gdb reality.
3857         * common/gdb_string_view.tcc: Likewise.
3858         * cli/cli-script.c (struct string_view): Remove.
3859         (user_args) <m_args>: Change element type to gdb::string_view.
3860         (user_args::insert_args): Adjust.
3861
3862 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3863
3864         * common/gdb_string_view.h: New file.
3865         * common/gdb_string_view.tcc: New file.
3866
3867 2018-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3868
3869         * ax_cxx_compile_stdcxx.m4: Sync with upstream.
3870         * configure: Re-generate.
3871
3872 2018-04-09  Pedro Alves  <palves@redhat.com>
3873
3874         * gdbarch.sh: Include "observable.h" instead of "observer.h".
3875         (set_target_gdbarch): Call
3876         gdb::observers::architecture_changed.notify instead of
3877         observer_notify_architecture_changed.
3878
3879 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3880
3881         * tracepoint.c (struct current_traceframe_cleanup): Remove.
3882         (do_restore_current_traceframe_cleanup): Remove.
3883         (restore_current_traceframe_cleanup_dtor): Remove.
3884         (make_cleanup_restore_current_traceframe): Remove.
3885         (scoped_restore_current_traceframe::scoped_restore_current_traceframe):
3886         New.
3887         * tracepoint.h (struct scoped_restore_current_traceframe): New.
3888         * infrun.c (fetch_inferior_event): Use
3889         scoped_restore_current_traceframe.
3890
3891 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3892
3893         * dwarf2read.h (struct dwarf2_per_objfile) <n_type_units>:
3894         Remove.
3895         <n_allocated_type_units>: Remove.
3896         <all_type_units>: Change to std::vector.
3897         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
3898         to std::vector change.
3899         (dwarf2_per_objfile::get_cutu): Likewise.
3900         (dwarf2_per_objfile::get_tu): Likewise.
3901         (create_signatured_type_table_from_index): Likewise.
3902         (create_signatured_type_table_from_debug_names): Likewise.
3903         (dw2_symtab_iter_next): Likewise.
3904         (dw2_print_stats): Likewise.
3905         (dw2_expand_all_symtabs): Likewise.
3906         (dw2_expand_marked_cus): Likewise.
3907         (dw2_debug_names_iterator::next): Likewise.
3908         (dwarf2_initialize_objfile): Likewise.
3909         (add_signatured_type_cu_to_table): Likewise.
3910         (create_all_type_units): Likewise.
3911         (add_type_unit): Likewise.
3912         (struct tu_abbrev_offset): Add constructor.
3913         (build_type_psymtabs_1): Adjust to std::vector change.
3914         (print_tu_stats): Likewise.
3915         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
3916         (write_debug_names): Likewise.
3917
3918 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3919
3920         * dwarf2read.h (struct dwarf2_per_objfile) <all_comp_units>: Likewise.
3921         Make an std::vector.
3922         <n_comp_units>: Remove.
3923         * dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile): Adjust
3924         to std::vector change.
3925         (dwarf2_per_objfile::get_cutu): Likewise.
3926         (dwarf2_per_objfile::get_cu): Likewise.
3927         (create_cus_from_index): Likewise.
3928         (create_addrmap_from_index): Likewise.
3929         (create_addrmap_from_aranges): Likewise.
3930         (dwarf2_read_index): Likewise.
3931         (dw2_find_last_source_symtab): Likewise.
3932         (dw2_map_symtabs_matching_filename): Likewise.
3933         (dw2_symtab_iter_next): Likewise.
3934         (dw2_print_stats): Likewise.
3935         (dw2_expand_all_symtabs): Likewise.
3936         (dw2_expand_symtabs_with_fullname): Likewise.
3937         (dw2_expand_marked_cus): Likewise.
3938         (dw2_map_symbol_filenames): Likewise.
3939         (create_cus_from_debug_names): Likewise.
3940         (dwarf2_read_debug_names): Likewise.
3941         (dw2_debug_names_iterator::next): Likewise.
3942         (dwarf2_initialize_objfile): Likewise.
3943         (set_partial_user): Likewise.
3944         (dwarf2_build_psymtabs_hard): Likewise.
3945         (read_comp_units_from_section): Remove arguments, adjust to
3946         std::vector change.
3947         (create_all_comp_units): Adjust to std::vector and
3948         read_comp_units_from_section changes.
3949         (dwarf2_find_containing_comp_unit): Adjust to std::vector
3950         change.
3951         * dwarf-index-write.c (check_dwarf64_offsets): Likewise.
3952         (psyms_seen_size): Likewise.
3953         (write_gdbindex): Likewise.
3954         (write_debug_names): Likewise.
3955
3956 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3957
3958         * dwarf2read.c (create_cus_from_index_list): Replace objfile arg
3959         with dwarf2_per_objfile.
3960         (create_cus_from_index): Likewise.
3961         (create_signatured_type_table_from_index): Likewise.
3962         (dwarf2_read_index): Likewise.
3963         (dwarf2_initialize_objfile): Likewise.
3964         (dwarf2_fetch_die_loc_sect_off):  Get dwarf2_per_objfile from
3965         per_cu rather than get_dwarf2_per_objfile.
3966
3967 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3968
3969         * dwarf2read.h (struct signatured_type): Forward declare.
3970         (struct dwarf2_per_objfile) <get_cutu, get_cu, get_tu>:
3971         New methods.
3972         * dwarf2read.c (dwarf2_per_objfile::get_cutu): Rename from...
3973         (dw2_get_cutu): ...this.
3974         (dwarf2_per_objfile::get_cu): Rename from...
3975         (dw2_get_cu): ...this.
3976         (dwarf2_per_objfile::get_tu): New.
3977         (create_addrmap_from_index): Adjust.
3978         (create_addrmap_from_aranges): Adjust.
3979         (dw2_find_last_source_symtab): Adjust.
3980         (dw2_map_symtabs_matching_filename): Adjust.
3981         (dw2_symtab_iter_next): Adjust.
3982         (dw2_print_stats): Adjust.
3983         (dw2_expand_all_symtabs): Adjust.
3984         (dw2_expand_symtabs_with_fullname): Adjust.
3985         (dw2_expand_marked_cus): Adjust.
3986         (dw_expand_symtabs_matching_file_matcher): Adjust.
3987         (dw2_map_symbol_filenames): Adjust.
3988         (dw2_debug_names_iterator::next): Adjust.
3989         (dwarf2_initialize_objfile): Adjust.
3990         (set_partial_user): Adjust.
3991         (dwarf2_build_psymtabs_hard): Adjust.
3992
3993 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
3994
3995         * dwarf2read.c (create_signatured_type_table_from_debug_names):
3996         Remove unused variables.
3997         (dw2_map_symtabs_matching_filename): Likewise.
3998         (dwarf2_record_block_ranges): Likewise.
3999         (dwarf2_read_addr_index): Likewise.
4000         (follow_die_offset): Likewise.
4001
4002 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4003
4004         * progspace.c (clone_program_space): Pass SYMFILE_DEFER_BP_RESET
4005         to symbol_file_add_main.
4006
4007 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4008
4009         PR mi/22299
4010         * mi/mi-console.c (do_fputc_async_safe): New.
4011         (mi_console_file::write_async_safe): New.
4012         (mi_console_file::flush): Adjust calls to fputstrn_unfiltered.
4013         * mi/mi-console.h (class mi_console_file) <write_async_safe>:
4014         New.
4015         * ui-file.c (ui_file::putstrn): Adjust call to
4016         fputstrn_unfiltered.
4017         * utils.c (printchar): Replace do_fputs and do_fprintf
4018         parameters by do_fputc.
4019         (fputstr_filtered): Adjust call to printchar.
4020         (fputstr_unfiltered): Likewise.
4021         (fputstrn_filtered): Likewise.
4022         (fputstrn_unfiltered): Add do_fputc parameter, pass to
4023         printchar.
4024         * utils.h (do_fputc_ftype): New typedef.
4025         (fputstrn_unfiltered): Add do_fputc parameter.
4026
4027 2018-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4028
4029         * regformats/i386/i386-avx.dat: Remove.
4030
4031 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
4032
4033         PR gdb/22979
4034         * amd64-tdep.c (amd64_none_init_abi): New function.
4035         (amd64_x32_none_init_abi): New function.
4036         (_initialize_amd64_tdep): Register handlers for x86-64 and
4037         x64_32 with GDB_OSABI_NONE.
4038         * osabi.c (gdbarch_init_osabi): Allow running handlers for the
4039         GDB_OSABI_NONE osabi.
4040
4041 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
4042
4043         PR gdb/22980
4044         * defs.h (enum gdb_osabi): Remove GDB_OSABI_UNINITIALIZED, add
4045         GDB_OSABI_NONE.
4046         * arch-utils.c (gdbarch_info_init): Don't set info->osabi.
4047         * osabi.c (gdb_osabi_names): Add "unknown" entry.
4048
4049 2018-04-07  Simon Marchi  <simon.marchi@ericsson.com>
4050
4051         * common/byte-vector.h (char_vector): New type.
4052         * target.h (target_read_alloc): Return
4053         gdb::optional<byte_vector>.
4054         (target_read_stralloc): Return gdb::optional<char_vector>.
4055         (target_get_osdata): Return gdb::optional<char_vector>.
4056         * target.c (target_read_alloc_1): Templatize.  Replacement
4057         manual memory management with vector.
4058         (target_read_alloc): Change return type, adjust.
4059         (target_read_stralloc): Change return type, adjust.
4060         (target_get_osdata): Change return type, adjust.
4061         * auxv.c (struct auxv_info) <length>: Remove.
4062         <data>: Change type to gdb::optional<byte_vector>.
4063         (auxv_inferior_data_cleanup): Free auxv_info with delete.
4064         (get_auxv_inferior_data): Allocate auxv_info with new, adjust.
4065         (target_auxv_search): Adjust.
4066         (fprint_target_auxv): Adjust.
4067         * avr-tdep.c (avr_io_reg_read_command): Adjust.
4068         * linux-tdep.c (linux_spu_make_corefile_notes): Adjust.
4069         (linux_make_corefile_notes): Adjust.
4070         * osdata.c (get_osdata): Adjust.
4071         * remote.c (remote_get_threads_with_qxfer): Adjust.
4072         (remote_memory_map): Adjust.
4073         (remote_traceframe_info): Adjust.
4074         (btrace_read_config): Adjust.
4075         (remote_read_btrace): Adjust.
4076         (remote_pid_to_exec_file): Adjust.
4077         * solib-aix.c (solib_aix_get_library_list): Adjust.
4078         * solib-dsbt.c (decode_loadmap): Don't free buf.
4079         (dsbt_get_initial_loadmaps): Adjust.
4080         * solib-svr4.c (svr4_current_sos_via_xfer_libraries): Adjust.
4081         * solib-target.c (solib_target_current_sos): Adjust.
4082         * tracepoint.c (sdata_make_value): Adjust.
4083         * xml-support.c (xinclude_start_include): Adjust.
4084         (xml_fetch_content_from_file): Adjust.
4085         * xml-support.h (xml_fetch_another): Change return type.
4086         (xml_fetch_content_from_file): Change return type.
4087         * xml-syscall.c (xml_init_syscalls_info): Adjust.
4088         * xml-tdesc.c (file_read_description_xml): Adjust.
4089         (fetch_available_features_from_target): Change return type.
4090         (target_fetch_description_xml): Adjust.
4091         (target_read_description_xml): Adjust.
4092
4093 2018-04-06  Tom Tromey  <tom@tromey.com>
4094
4095         * value.c (~value): Update.
4096         (struct value) <contents>: Now unique_xmalloc_ptr.
4097         (value_contents_bits_eq, allocate_value_contents)
4098         (value_contents_raw, value_contents_all_raw)
4099         (value_contents_for_printing, value_contents_for_printing_const)
4100         (set_value_enclosing_type): Update.
4101
4102 2018-04-06  Tom Tromey  <tom@tromey.com>
4103
4104         * value.c (range_s): Remove typedef, VEC.
4105         (struct range): Add operator<.
4106         (range_lessthan): Remove.
4107         (ranges_contain): Change type.
4108         (~value): Update.
4109         (struct value) <unavailable, optimized_out>: Now std::vector.
4110         (value_entirely_available)
4111         (value_entirely_covered_by_range_vector)
4112         (value_entirely_unavailable, value_entirely_optimized_out):
4113         Update.
4114         (insert_into_bit_range_vector): Change argument type.
4115         (find_first_range_overlap): Likewise.
4116         (struct ranges_and_idx, value_contents_bits_eq)
4117         (require_not_optimized_out, require_available): Update.
4118         (ranges_copy_adjusted): Change argument types.
4119         (value_optimized_out, value_copy, value_fetch_lazy): Update.
4120
4121 2018-04-06  Tom Tromey  <tom@tromey.com>
4122
4123         * value.c (~value): Update.
4124         (struct value) <parent>: Now a value_ref_ptr.
4125         (value_parent, set_value_parent, value_address, value_copy):
4126         Update.
4127
4128 2018-04-06  Tom Tromey  <tom@tromey.com>
4129
4130         * value.c (struct value): Add constructor, destructor, and member
4131         initializers.
4132         (allocate_value_lazy, value_decref): Update.
4133
4134 2018-04-06  Tom Tromey  <tom@tromey.com>
4135
4136         * value.c (struct value) <released, next>: Remove.
4137         (all_values): Now a std::vector.
4138         (allocate_value_lazy): Update.
4139         (value_next): Remove.
4140         (value_mark, value_free_to_mark, release_value)
4141         (value_release_to_mark): Update.
4142
4143 2018-04-06  Tom Tromey  <tom@tromey.com>
4144
4145         * value.h (fetch_subexp_value, value_release_to_mark): Update.
4146         (free_value_chain): Remove.
4147         * value.c (free_value_chain): Remove.
4148         (value_release_to_mark): Return a std::vector.
4149         * ppc-linux-nat.c (num_memory_accesses): Change "chain" to a
4150         std::vector.
4151         (check_condition): Update.
4152         * eval.c (fetch_subexp_value): Change "val_chain" to a
4153         std::vector.
4154         * breakpoint.c (update_watchpoint): Update.
4155         (can_use_hardware_watchpoint): Change "vals" to a std::vector.
4156
4157 2018-04-06  Tom Tromey  <tom@tromey.com>
4158
4159         * value.h (free_all_values): Remove.
4160         * value.c (free_all_values): Remove.
4161
4162 2018-04-06  Tom Tromey  <tom@tromey.com>
4163
4164         * value.c (VALUE_HISTORY_CHUNK, struct value_history_chunk)
4165         (value_history_chain, value_history_count): Remove.
4166         (value_history): New global.
4167         (record_latest_value, access_value_history, show_values)
4168         (preserve_values): Update.
4169
4170 2018-04-06  Tom Tromey  <tom@tromey.com>
4171
4172         * varobj.h (struct varobj) <value>: Now a value_ref_ptr.
4173         * varobj.c (varobj_set_display_format, varobj_set_value)
4174         (install_default_visualizer, construct_visualizer)
4175         (install_new_value, ~varobj, varobj_get_value_type)
4176         (my_value_of_variable, varobj_editable_p): Update.
4177         * c-varobj.c (c_describe_child, c_value_of_variable)
4178         (cplus_number_of_children, cplus_describe_child): Update.
4179         * ada-varobj.c (ada_number_of_children, ada_name_of_child)
4180         (ada_path_expr_of_child, ada_value_of_child, ada_type_of_child)
4181         (ada_value_of_variable, ada_value_is_changeable_p): Update.
4182
4183 2018-04-06  Tom Tromey  <tom@tromey.com>
4184
4185         * printcmd.c (last_examine_address): Change type to
4186         value_ref_ptr.
4187         (do_examine, x_command): Update.
4188
4189 2018-04-06  Tom Tromey  <tom@tromey.com>
4190
4191         * value.c (release_value): Update.
4192         * breakpoint.h (struct watchpoint) <val>: Now a value_ref_ptr.
4193         (struct bpstats) <val>: Now a value_ref_ptr.
4194         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
4195         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
4196         (~watchpoint, print_it_watchpoint, watch_command_1)
4197         (invalidate_bp_value_on_memory_change): Update.
4198
4199 2018-04-06  Tom Tromey  <tom@tromey.com>
4200
4201         * varobj.c (varobj_clear_saved_item)
4202         (update_dynamic_varobj_children, install_new_value, ~varobj):
4203         Update.
4204         * value.h (value_incref): Move declaration earlier.
4205         (value_decref): Rename from value_free.
4206         (struct value_ref_policy): New.
4207         (value_ref_ptr): New typedef.
4208         (struct value_deleter): Remove.
4209         (gdb_value_up): Remove typedef.
4210         (release_value): Change return type.
4211         (release_value_or_incref): Remove.
4212         * value.c (set_value_parent): Update.
4213         (value_incref): Change return type.
4214         (value_decref): Rename from value_free.
4215         (value_free_to_mark, free_all_values, free_value_chain): Update.
4216         (release_value): Return value_ref_ptr.
4217         (release_value_or_incref): Remove.
4218         (record_latest_value, set_internalvar, clear_internalvar):
4219         Update.
4220         * stack.c (info_frame_command): Don't call value_free.
4221         * python/py-value.c (valpy_dealloc, valpy_new)
4222         (value_to_value_object): Update.
4223         * printcmd.c (do_examine): Update.
4224         * opencl-lang.c (lval_func_free_closure): Update.
4225         * mi/mi-main.c (register_changed_p): Don't call value_free.
4226         * mep-tdep.c (mep_frame_prev_register): Don't call value_free.
4227         * m88k-tdep.c (m88k_frame_prev_register): Don't call value_free.
4228         * m68hc11-tdep.c (m68hc11_frame_prev_register): Don't call
4229         value_free.
4230         * guile/scm-value.c (vlscm_free_value_smob)
4231         (vlscm_scm_from_value): Update.
4232         * frame.c (frame_register_unwind, frame_unwind_register_signed)
4233         (frame_unwind_register_unsigned, get_frame_register_bytes)
4234         (put_frame_register_bytes): Don't call value_free.
4235         * findvar.c (address_from_register): Don't call value_free.
4236         * dwarf2read.c (dwarf2_compute_name): Don't call value_free.
4237         * dwarf2loc.c (entry_data_value_free_closure)
4238         (value_of_dwarf_reg_entry, free_pieced_value_closure)
4239         (dwarf2_evaluate_loc_desc_full): Update.
4240         * breakpoint.c (update_watchpoint, breakpoint_init_inferior)
4241         (~bpstats, bpstats, bpstat_clear_actions, watchpoint_check)
4242         (~watchpoint, watch_command_1)
4243         (invalidate_bp_value_on_memory_change): Update.
4244         * alpha-tdep.c (alpha_register_to_value): Don't call value_free.
4245
4246 2018-04-06  Simon Marchi  <simon.marchi@polymtl.ca>
4247
4248         PR gdb/23022
4249         * warning.m4: Add -Wno-error=deprecated-register.
4250         * configure: Re-generate.
4251
4252 2018-04-05  Tom Tromey  <tom@tromey.com>
4253
4254         * linespec.h: Remove include of "vec.h".
4255
4256 2018-04-05  Tom Tromey  <tom@tromey.com>
4257
4258         * linespec.c (typep): Remove typedef.
4259         (find_methods, find_superclass_methods): Take a std::vector.
4260         (find_method): Use std::vector.
4261
4262 2018-04-05  Tom Tromey  <tom@tromey.com>
4263
4264         * utils.c (compare_strings): Remove.
4265         * utils.h (compare_strings): Remove.
4266         * objc-lang.h (find_imps): Update.
4267         * objc-lang.c (find_methods): Take a std::vector.
4268         (uniquify_strings, find_imps): Likewise.
4269         * linespec.c (find_methods): Take a std::vector.
4270         (decode_objc): Use std::vector.
4271         (add_all_symbol_names_from_pspace, find_superclass_methods): Take
4272         a std::vector.
4273         (find_method, find_function_symbols): Use std::vector.
4274
4275 2018-04-05  Tom Tromey  <tom@tromey.com>
4276
4277         * completer.c (completion_tracker::completion_tracker): Remove
4278         cast.
4279         (completion_tracker::discard_completions): Likewise.
4280         * breakpoint.c (ambiguous_names_p): Remove cast.
4281         * ada-lang.c (_initialize_ada_language): Remove cast.
4282         * utils.h (streq): Update.
4283         (streq_hash): Add new declaration.
4284         * utils.c (streq): Return bool.
4285         (streq_hash): New function.
4286
4287 2018-04-05  Tom Tromey  <tom@tromey.com>
4288
4289         * linespec.c (event_location_to_sals) <case ADDRESS_LOCATION>:
4290         Remove a string copy.
4291
4292 2018-04-05  Tom Tromey  <tom@tromey.com>
4293
4294         * linespec.c (filter_results): Use std::vector.
4295         (decode_line_2, decode_line_full): Update.
4296
4297 2018-04-05  Tom Tromey  <tom@tromey.com>
4298
4299         * linespec.c (canonical_to_fullform): Return std::string.
4300         (filter_results): Update.
4301         (struct decode_line_2_item): Add constructor.
4302         <fullform, displayform>: Now std::string.
4303         (decode_line_2_compare_items): Now a std::sort comparator.
4304         (decode_line_2): Update.
4305
4306 2018-04-05  Tom Tromey  <tom@tromey.com>
4307
4308         * linespec.c (copy_token_string): Return a unique_xmalloc_ptr.
4309         (unexpected_linespec_error): Update.
4310         (linespec_parse_basic, parse_linespec): Update.
4311
4312 2018-04-05  Tom Tromey  <tom@tromey.com>
4313
4314         * linespec.c (linespec_parse_basic): Reindent.
4315
4316 2018-04-05  Tom Tromey  <tom@tromey.com>
4317
4318         * minsyms.h (iterate_over_minimal_symbols): Update.
4319         * minsyms.c (iterate_over_minimal_symbols): Take a
4320         gdb::function_view.
4321         * linespec.c (struct collect_minsyms): Remove.
4322         (compare_msyms): Now a std::sort comparator.
4323         (add_minsym): Add parameters.
4324         (search_minsyms_for_name): Update.  Use std::vector.
4325
4326 2018-04-03  Tom Tromey  <tom@tromey.com>
4327
4328         * mipsread.c (read_alphacoff_dynamic_symtab): Use
4329         gdb::byte_vector.
4330
4331 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
4332
4333         * MAINTAINERS (Write After Approval): Add Weimin Pan.
4334
4335 2018-04-02  Weimin Pan  <weimin.pan@oracle.com>
4336
4337         PR gdb/16959
4338         * cp-valprint.c: (cp_print_static_field) Fix infinite recursion when 
4339         printing static type.
4340
4341 2018-04-01  Tom Tromey  <tom@tromey.com>
4342
4343         * rs6000-nat.c (rs6000_ptrace_ldinfo): Return a byte_vector.
4344         (rs6000_xfer_shared_libraries): Update.
4345
4346 2018-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
4347
4348         * common/gdb_vecs.h (char_ptr): Remove.
4349         * tracepoint.c (encode_actions_1): Remove usage of char_ptr.
4350
4351 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
4352
4353         * guile/scm-utils.c (gdbscm_parse_function_args): Replace VEC
4354         with std::vector.
4355         * common/gdb_vecs.h (DEF_VEC_P (char_ptr)): Remove.
4356
4357 2018-03-30  Simon Marchi  <simon.marchi@polymtl.ca>
4358
4359         * tracepoint.h (struct uploaded_tp): Initialize fields.
4360         <actions, step_actions, cmd_strings>: Change type to
4361         std::vector<char *>.
4362         * tracepoint.c (get_uploaded_tp): Allocate with new.
4363         (free_uploaded_tps): Free with delete.
4364         (parse_tracepoint_definition): Adjust to std::vector change.
4365         * breakpoint.c (read_uploaded_action): Likewise.
4366         (create_tracepoint_from_upload): Likewise.
4367         * ctf.c (ctf_write_uploaded_tp): Likewise.
4368         (SET_ARRAY_FIELD): Likewise.
4369         * tracefile-tfile.c (tfile_write_uploaded_tp): Likewise.
4370
4371 2018-03-30  Tom Tromey  <tom@tromey.com>
4372
4373         * solib-svr4.c (lm_info_read): Use gdb::byte_vector.  Return
4374         std::unique_ptr.
4375         (svr4_keep_data_in_core): Update.
4376         (svr4_read_so_list): Update.
4377
4378 2018-03-30  Tom Tromey  <tom@tromey.com>
4379
4380         * windows-nat.c (handle_output_debug_string, handle_exception):
4381         Update.
4382         * target.h (target_read_string): Update.
4383         * target.c (target_read_string): Change "string" to
4384         unique_xmalloc_ptr.
4385         * solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
4386         Update.
4387         * solib-frv.c (frv_current_sos): Update.
4388         * solib-dsbt.c (dsbt_current_sos): Update.
4389         * solib-darwin.c (darwin_current_sos): Update.
4390         * linux-thread-db.c (inferior_has_bug): Update.
4391         * expprint.c (print_subexp_standard) <case OP_OBJC_MSGCALL>:
4392         Update.  Remove alloca.
4393         * ada-lang.c (ada_main_name): Update.
4394
4395 2018-03-30  Tom Tromey  <tom@tromey.com>
4396
4397         * dwarf2read.c (struct free_dwo_file_cleanup_data): Remove.
4398         (struct dwo_file_deleter): New.
4399         (dwo_file_up): New typedef.
4400         (open_and_init_dwo_file): Use dwo_file_up.
4401         (free_dwo_file_cleanup): Remove.
4402
4403 2018-03-30  Tom Tromey  <tom@tromey.com>
4404
4405         * dwarf2read.c (free_dwo_file): Remove "objfile" parameter.
4406         (free_dwo_file_cleanup, free_dwo_file_from_slot): Update.
4407
4408 2018-03-30  Tom Tromey  <tom@tromey.com>
4409
4410         * dwarf2read.c (class free_cached_comp_units): New class.
4411         (dw2_instantiate_symtab, dwarf2_build_psymtabs_hard): Use it.
4412         (free_cached_comp_units): Remove function.
4413
4414 2018-03-30  Tom Tromey  <tom@tromey.com>
4415
4416         * utils.h (make_cleanup_unpush_target): Remove.
4417         * inf-ptrace.c (struct target_unpusher): New.
4418         (target_unpush_up) New typedef.
4419         (inf_ptrace_create_inferior, inf_ptrace_attach): Use
4420         target_unpush_up.
4421         * utils.c (do_unpush_target, make_cleanup_unpush_target): Remove.
4422
4423 2018-03-27  Tom Tromey  <tom@tromey.com>
4424
4425         * utils.c (prompt_for_continue): Use unique_xmalloc_ptr.
4426
4427 2018-03-27  Pedro Alves  <palves@redhat.com>
4428             Tom Tromey  <tom@tromey.com>
4429
4430         * top.c (class gdb_readline_wrapper_cleanup): Add constructor,
4431         destructor.  Now a class.
4432         (gdb_readline_wrapper_cleanup): Remove function.
4433         (gdb_readline_wrapper): Remove cleanups.
4434
4435 2018-03-27  Tom Tromey  <tom@tromey.com>
4436
4437         * typeprint.h (struct type_print_options) <local_typedefs,
4438         global_typedefs>: Remove "struct" keyword.
4439         (class typedef_hash_table): New class.
4440         (recursively_update_typedef_hash, add_template_parameters)
4441         (create_typedef_hash, free_typedef_hash, copy_typedef_hash)
4442         (find_typedef_in_hash): Don't declare.
4443         * typeprint.c (struct typedef_hash_table): Move to typeprint.h.
4444         (typedef_hash_table::recursively_update): Rename from
4445         recursively_update_typedef_hash.  Now a member.
4446         (typedef_hash_table::add_template_parameters): Rename from
4447         add_template_parameters.  Now a member.
4448         (typedef_hash_table::typedef_hash_table): Now a constructor;
4449         rename from create_typedef_hash.
4450         (typedef_hash_table::~typedef_hash_table): Now a destructor;
4451         rename from free_typedef_hash.
4452         (do_free_typedef_hash, make_cleanup_free_typedef_hash)
4453         (do_free_global_table): Remove.
4454         (typedef_hash_table::typedef_hash_table): New constructor; renamed
4455         from copy_type_recursive.
4456         (create_global_typedef_table): Remove.
4457         (typedef_hash_table::find_global_typedef): Now a member of
4458         typedef_hash_table.
4459         (typedef_hash_table::find_typedef): Rename from
4460         find_typedef_in_hash; now a member.
4461         (whatis_exp): Update.
4462         * extension.h (struct ext_lang_type_printers): Add constructor and
4463         destructor.
4464         (start_ext_lang_type_printers, free_ext_lang_type_printers): Don't
4465         declare.
4466         * extension.c (ext_lang_type_printers::ext_lang_type_printers):
4467         Now a constructor; rename from start_ext_lang_type_printers.
4468         (ext_lang_type_printers): Now a destructor; rename from
4469         free_ext_lang_type_printers.
4470         * c-typeprint.c (find_typedef_for_canonicalize, c_print_type_1):
4471         Update.
4472         (c_type_print_base_struct_union): Update.  Remove cleanups.
4473
4474 2018-03-27  Tom Tromey  <tom@tromey.com>
4475
4476         * dwarf-index-write.c: Include <cmath>.
4477
4478 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
4479
4480         * NEWS: Add entry describing new "set|show varsize-limit" command.
4481         * ada-lang.c (_initialize_ada_language): Add "set/show varsize-limit"
4482         command.
4483         * printcmd.c (_initialize_printcmd): Add "set var" alias of
4484         "set variable".
4485
4486 2018-03-27  Simon Marchi  <simon.marchi@ericsson.com>
4487
4488         * Makefile.in (COMMON_SFILES): Add dwarf-index-common.c and
4489         dwarf-index-write.c
4490         (HFILES_NO_SRCDIR): Add dwarf-index-common.h and dwarf2read.h.
4491         * dwarf-index-common.c: New file.
4492         * dwarf-index-common.h: New file.
4493         * dwarf-index-write.c: New file.
4494         * dwarf2read.c: Include dwarf2read.h and dwarf-index-common.h.
4495         (struct dwarf2_section_info): Move from here.
4496         (dwarf2_section_info_def): Likewise.
4497         (DEF_VEC_O (dwarf2_section_info_def)): Likewise.
4498         (offset_type): Likewise.
4499         (DW2_GDB_INDEX_SYMBOL_STATIC_SET_VALUE): Likewise.
4500         (DW2_GDB_INDEX_SYMBOL_KIND_SET_VALUE): Likewise.
4501         (DW2_GDB_INDEX_CU_SET_VALUE): Likewise.
4502         (byte_swap): Likewise.
4503         (MAYBE_SWAP): Likewise.
4504         (dwarf2_per_cu_ptr): Likewise.
4505         (DEF_VEC_P (dwarf2_per_cu_ptr)): Likewise.
4506         (struct tu_stats): Likewise.
4507         (struct dwarf2_per_objfile): Likewise.
4508         (struct dwarf2_per_cu_data): Likewise.
4509         (struct signatured_type): Likewise.
4510         (sig_type_ptr): Likewise.
4511         (DEF_VEC_P (sig_type_ptr)): Likewise.
4512         (INDEX4_SUFFIX): Likewise.
4513         (INDEX5_SUFFIX): Likewise.
4514         (DEBUG_STR_SUFFIX): Likewise.
4515         (dwarf2_read_section): Make non-static.
4516         (mapped_index_string_hash): Move from here.
4517         (dwarf5_djb_hash): Likewise.
4518         (file_write): Likewise.
4519         (class data_buf): Likewise.
4520         (struct symtab_index_entry): Likewise.
4521         (struct mapped_symtab): Likewise.
4522         (find_slot): Likewise.
4523         (hash_expand): Likewise.
4524         (add_index_entry): Likewise.
4525         (uniquify_cu_indices): Likewise.
4526         (class c_str_view): Likewise.
4527         (class c_str_view_hasher): Likewise.
4528         (class vector_hasher): Likewise.
4529         (write_hash_table): Likewise.
4530         (psym_index_map): Likewise.
4531         (struct addrmap_index_data): Likewise.
4532         (add_address_entry): Likewise.
4533         (add_address_entry_worker): Likewise.
4534         (write_address_map): Likewise.
4535         (symbol_kind): Likewise.
4536         (write_psymbols): Likewise.
4537         (struct signatured_type_index_data): Likewise.
4538         (write_one_signatured_type): Likewise.
4539         (recursively_count_psymbols): Likewise.
4540         (recursively_write_psymbols): Likewise.
4541         (class debug_names): Likewise.
4542         (check_dwarf64_offsets): Likewise.
4543         (psyms_seen_size): Likewise.
4544         (write_gdbindex): Likewise.
4545         (write_debug_names): Likewise.
4546         (assert_file_size): Likewise.
4547         (write_psymtabs_to_index): Likewise.
4548         (save_gdb_index_command): Likewise.
4549         (_initialize_dwarf2_read): Don't register the "save gdb-index"
4550         command.
4551         * dwarf2read.h: New file.
4552
4553 2018-03-27  Joel Brobecker  <brobecker@adacore.com>
4554
4555         PR gdb/22670
4556         * dwarf2read.c (dwarf2_physname): Do not return the demangled
4557         symbol name if the CU's language stores symbol names in linkage
4558         format.
4559         * language.h (struct language_defn)
4560         <la_store_sym_names_in_linkage_form_p>: New field.  Adjust
4561         all instances of this struct.
4562
4563 2018-03-26  Tom Tromey  <tom@tromey.com>
4564
4565         * stack.c (backtrace_command_1): Remove verbose code.
4566
4567 2018-03-26  Tom Tromey  <tom@tromey.com>
4568
4569         * python/py-framefilter.c (py_print_type): Don't catch
4570         exceptions.  Return void.
4571         (py_print_value): Likewise.
4572         (py_print_single_arg): Likewise.
4573         (enumerate_args): Don't catch exceptions.
4574         (py_print_args): Likewise.
4575         (py_print_frame): Likewise.
4576         (gdbpy_apply_frame_filter): Catch exceptions here.
4577
4578 2018-03-26  Tom Tromey  <tom@tromey.com>
4579
4580         * stack.c (_initialize_stack): Remove trailing newlines from help
4581         text.  Add "Usage" line to "backtrace" help.
4582
4583 2018-03-26  Tom Tromey  <tom@tromey.com>
4584
4585         PR python/16486:
4586         * python/py-framefilter.c (py_print_args): Call wrap_hint.
4587
4588 2018-03-26  Tom Tromey  <tom@tromey.com>
4589
4590         * python/py-framefilter.c (py_print_single_arg): Return
4591         EXT_LANG_BT_ERROR from catch.
4592
4593 2018-03-26  Tom Tromey  <tom@tromey.com>
4594
4595         PR backtrace/15584:
4596         * stack.c (backtrace_command_1): Move some code into no-filters
4597         "if".
4598
4599 2018-03-26  Tom Tromey  <tom@tromey.com>
4600
4601         * python/py-framefilter.c (throw_quit_or_print_exception): New
4602         function.
4603         (gdbpy_apply_frame_filter): Use it.
4604
4605 2018-03-26  Tom Tromey  <tom@tromey.com>
4606
4607         PR cli/17716:
4608         * python/py-framefilter.c (py_print_type, py_print_value)
4609         (enumerate_args, py_print_args, gdbpy_apply_frame_filter): Use
4610         RETURN_MASK_ERROR.
4611
4612 2018-03-26  Tom Tromey  <tom@tromey.com>
4613
4614         * python/py-framefilter.c (enumerate_args): Use
4615         gdb::unique_xmalloc_ptr.
4616
4617 2018-03-26  Tom Tromey  <tom@tromey.com>
4618
4619         * python/py-framefilter.c (py_print_frame): Return
4620         EXT_LANG_BT_OK.
4621         (gdbpy_apply_frame_filter): Update comment.
4622         * extension.h (enum ext_lang_bt_status) <EXT_LANG_BT_COMPLETED>:
4623         Remove.
4624         <EXT_LANG_BT_NO_FILTERS>: Change value.
4625
4626 2018-03-26  Tom Tromey  <tom@tromey.com>
4627
4628         PR backtrace/15582:
4629         * stack.c (backtrace_command): Parse "hide" argument.
4630         * python/py-framefilter.c (py_print_frame): Handle PRINT_HIDE.
4631         * extension.h (enum frame_filter_flags) <PRINT_HIDE>: New
4632         constant.
4633
4634 2018-03-26  Tom Tromey  <tom@tromey.com>
4635
4636         * stack.c (backtrace_command_1): Remove "show_locals" parameter,
4637         add "flags".
4638         (backtrace_command): Remove "fulltrace", add "flags".
4639
4640 2018-03-26  Tom Tromey  <tom@tromey.com>
4641
4642         * stack.c (backtrace_command): Rewrite command line parsing.
4643
4644 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
4645
4646         * dwarf2read.c (DEF_VEC_I(offset_type)): Remove.
4647
4648 2018-03-26  Simon Marchi  <simon.marchi@ericsson.com>
4649
4650         * filename-seen-cache.h: Add include guard.
4651
4652 2018-03-26  Keith Seitz  <keiths@redhat.com>
4653
4654         * symfile.c (place_section): Remove "struct" from section_addr_info
4655         in comment.
4656         * windows-nat.c (struct safe_symbol_file_add_args) <addrs>: Remove
4657         "struct" keyword from section_addr_info.
4658
4659 2018-03-26  Alan Hayward  <alan.hayward@arm.com>
4660
4661         * regformats/regdef.h (reg): Add constructors.
4662
4663 2018-03-25  Pedro Alves  <palves@redhat.com>
4664
4665         * eval.c (evaluate_funcall): Swap OP_VAR_MSYM_VALUE/OP_VAR_VALUE
4666         if then/else bodies in var_func_name extraction.
4667
4668 2018-03-23  Weimin Pan  <weimin.pan@oracle.com>
4669
4670         * minsyms.c (lookup_minimal_symbol_and_objfile): Use
4671         lookup_minimal_symbol() to find symbol entry.
4672         * minsyms.h (lookup_minimal_symbol_and_objfile): Update comment.
4673
4674 2018-03-23  Keith Seitz  <keiths@redhat.com>
4675
4676         PR c++/22968
4677         * dwarf2read.c (scan_partial_symbols): Scan structs/classes for
4678         nested type definitions for C++, too.
4679
4680 2018-03-23  Tom Tromey  <tom@tromey.com>
4681
4682         * machoread.c (struct oso_el): Add a constructor.  Don't define as
4683         a typedef.
4684         (macho_register_oso): Remove.
4685         (macho_symtab_read): Take a std::vector.
4686         (oso_el_compare_name): Now a std::sort comparator.
4687         (macho_symfile_read_all_oso): Take a std::vector.
4688         (macho_symfile_read): Use std::vector.  Remove cleanups.
4689
4690 2018-03-22  Tom Tromey  <tom@tromey.com>
4691
4692         * record-full.c (record_full_exec_insn): Use gdb::byte_vector.
4693         (record_full_goto_bookmark): Use std::string.
4694
4695 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4696
4697         PR tdep/18295
4698         * rs6000-tdep.c (skip_prologue): Match both stwux and stdux
4699         a single mask.
4700
4701 2018-03-22  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4702
4703         * rs6000-tdep.c (store_insn_p): New function.
4704         (skip_prologue): New variable alloca_reg_offset. Set lr_reg
4705         and cr_reg to their unshifted values. Use store_insn_p to
4706         match LR saves using either R1 or fdata->alloca_reg. Use
4707         store_insn_p to match CR saves. Set alloca_reg_offset
4708         when alloca_reg and framep are set. Remove lr_reg shift
4709         when assigning to fdata->lr_register.
4710
4711 2018-03-22  Andreas Arnez  <arnez@linux.vnet.ibm.com>
4712
4713         * linux-tdep.c (linux_info_proc): For "info proc cmdline", print
4714         command line args instead of emitting a warning.
4715
4716 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
4717
4718         * tracepoint.h (struct static_tracepoint_marker): Initialize
4719         fields, define default constructor, move constructor and move
4720         assignment, disable the rest.
4721         <str_id, extra>: Make std::string.
4722         (release_static_tracepoint_marker): Remove.
4723         (free_current_marker): Remove.
4724         * tracepoint.c (free_current_marker): Remove.
4725         (parse_static_tracepoint_marker_definition): Adjust to
4726         std::string, use new hex2str overload.
4727         (release_static_tracepoint_marker): Remove.
4728         (print_one_static_tracepoint_marker): Get marker by reference
4729         and adjust to std::string.
4730         (info_static_tracepoint_markers_command): Adjust to std::vector
4731         changes
4732         * target.h (static_tracepoint_marker_p): Remove typedef.
4733         (DEF_VEC_P(static_tracepoint_marker_p)): Remove.
4734         (struct target_ops) <to_static_tracepoint_marker_at>: Return
4735         bool.
4736         <to_static_tracepoint_markers_by_strid>: Return std::vector.
4737         * target-debug.h
4738         (target_debug_print_VEC_static_tracepoint_marker_p_p): Remove.
4739         (target_debug_print_std_vector_static_tracepoint_marker): New.
4740         (target_debug_print_struct_static_tracepoint_marker_p): Rename
4741         to...
4742         (target_debug_print_static_tracepoint_marker_p): ... this.
4743         * target-delegates.c: Re-generate.
4744         * breakpoint.h (struct tracepoint) <static_trace_marker_id>:
4745         Make std::string.
4746         * breakpoint.c (init_breakpoint_sal): Adjust to std::string.
4747         (decode_static_tracepoint_spec): Adjust to std::vector.
4748         (tracepoint_print_one_detail): Adjust to std::string.
4749         (strace_marker_decode_location): Adjust to std::string.
4750         (update_static_tracepoint): Adjust to std::string, remove call
4751         to release_static_tracepoint_marker.
4752         * linux-nat.c (linux_child_static_tracepoint_markers_by_strid):
4753         Adjust to std::vector.
4754         * remote.c (remote_static_tracepoint_marker_at): Return bool.
4755         (remote_static_tracepoint_markers_by_strid): Adjust to
4756         std::vector.
4757         * common/rsp-low.h (hex2str): New overload with explicit count
4758         of bytes.
4759         * common/rsp-low.c (hex2str): New overload with explicit count
4760         of bytes.
4761         * unittests/rsp-low-selftests.c (test_hex2str): New function.
4762         (_initialize_rsp_low_selftests): Add test_hex2str test.
4763         * unittests/tracepoint-selftests.c
4764         (test_parse_static_tracepoint_marker_definition): Adjust to
4765         std::string.
4766
4767 2018-03-22  Simon Marchi  <simon.marchi@polymtl.ca>
4768
4769         * tracepoint.c (parse_static_tracepoint_marker_definition):
4770         Consider case where the definition is followed by more
4771         definitions.
4772         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4773         tracepoint-selftests.c.
4774         * unittests/tracepoint-selftests.c: New.
4775
4776 2018-03-21  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
4777
4778         * MAINTAINERS (Write After Approval): Add Pedro Franco de
4779         Carvalho.
4780
4781 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
4782
4783         * symtab.c (find_pc_sect_line): fixed indentation.
4784
4785 2018-03-20  Stephen Roberts  <stephen.roberts@arm.com>
4786
4787         * symtab.c (find_pc_sect_line): now uses binary search.
4788
4789 2018-03-19  Tom Tromey  <tom@tromey.com>
4790
4791         * rust-exp.y (struct_expr_tail, struct_expr_list): Add plain
4792         "IDENT" production.
4793
4794 2018-03-19  Pedro Alves  <palves@redhat.com>
4795             Tom Tromey  <tom@tromey.com>
4796
4797         * unittests/observable-selftests.c: New file.
4798         * common/observable.h: New file.
4799         * observable.h: New file.
4800         * ada-lang.c, ada-tasks.c, agent.c, aix-thread.c, annotate.c,
4801         arm-tdep.c, auto-load.c, auxv.c, break-catch-syscall.c,
4802         breakpoint.c, bsd-uthread.c, cli/cli-interp.c, cli/cli-setshow.c,
4803         corefile.c, dummy-frame.c, event-loop.c, event-top.c, exec.c,
4804         extension.c, frame.c, gdbarch.c, guile/scm-breakpoint.c,
4805         infcall.c, infcmd.c, inferior.c, inflow.c, infrun.c, jit.c,
4806         linux-tdep.c, linux-thread-db.c, m68klinux-tdep.c,
4807         mi/mi-cmd-break.c, mi/mi-interp.c, mi/mi-main.c, objfiles.c,
4808         ppc-linux-nat.c, ppc-linux-tdep.c, printcmd.c, procfs.c,
4809         python/py-breakpoint.c, python/py-finishbreakpoint.c,
4810         python/py-inferior.c, python/py-unwind.c, ravenscar-thread.c,
4811         record-btrace.c, record-full.c, record.c, regcache.c, remote.c,
4812         riscv-tdep.c, sol-thread.c, solib-aix.c, solib-spu.c, solib.c,
4813         spu-multiarch.c, spu-tdep.c, stack.c, symfile-mem.c, symfile.c,
4814         symtab.c, thread.c, top.c, tracepoint.c, tui/tui-hooks.c,
4815         tui/tui-interp.c, valops.c: Update all users.
4816         * tui/tui-hooks.c (tui_bp_created_observer)
4817         (tui_bp_deleted_observer, tui_bp_modified_observer)
4818         (tui_inferior_exit_observer, tui_before_prompt_observer)
4819         (tui_normal_stop_observer, tui_register_changed_observer):
4820         Remove.
4821         (tui_observers_token): New global.
4822         (attach_or_detach, tui_attach_detach_observers): New functions.
4823         (tui_install_hooks, tui_remove_hooks): Use
4824         tui_attach_detach_observers.
4825         * record-btrace.c (record_btrace_thread_observer): Remove.
4826         (record_btrace_thread_observer_token): New global.
4827         * observer.sh: Remove.
4828         * observer.c: Rename to observable.c.
4829         * observable.c (namespace gdb_observers): Define new objects.
4830         (observer_debug): Move into gdb_observers namespace.
4831         (struct observer, struct observer_list, xalloc_observer_list_node)
4832         (xfree_observer_list_node, generic_observer_attach)
4833         (generic_observer_detach, generic_observer_notify): Remove.
4834         (_initialize_observer): Update.
4835         Don't include observer.inc.
4836         * Makefile.in (generated_files): Remove observer.h, observer.inc.
4837         (clean mostlyclean): Likewise.
4838         (observer.h, observer.inc): Remove targets.
4839         (SUBDIR_UNITTESTS_SRCS): Add observable-selftests.c.
4840         (COMMON_SFILES): Use observable.c, not observer.c.
4841         * .gitignore: Remove observer.h.
4842
4843 2018-03-18  Tom Tromey  <tom@tromey.com>
4844
4845         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Use
4846         gdb::def_vector.
4847         (bfd_lookup_symbol_from_dyn_symtab): Likewise.
4848
4849 2018-03-17  Tom Tromey  <tom@tromey.com>
4850
4851         * auto-load.c (auto_load_objfile_script_1): Use std::string.
4852
4853 2018-03-17  Tom Tromey  <tom@tromey.com>
4854
4855         * target.c (class scoped_target_fd): New.
4856         (target_fileio_close_cleanup): Remove.
4857         (target_fileio_read_alloc_1): Use scoped_target_fd.
4858
4859 2018-03-16  Simon Marchi  <simon.marchi@polymtl.ca>
4860
4861         * silent-rules.mk: New.
4862         * Makefile.in: Include silent-rules.mk
4863         (srcdir, VPATH, top_srcdir): Move up.
4864         (COMPILE): Add ECHO_CXX.
4865         (test-cp-name-parser$(EXEEXT)): Add ECHO_CXXLD.
4866         (init.c): Add ECHO_INIT_C.
4867         (gdb$(EXEEXT)): Add SILENCE and ECHO_CXXLD.
4868         (version.c): Add ECHO_GEN.
4869         (printcmd.o): Add ECHO_CXX.
4870         (target-float.o): Add ECHO_CXX.
4871         (ada-exp.o): Add ECHO_CXX.
4872         (stamp-xml): Add SILENCE and ECHO_GEN_XML_BUILTIN.
4873         (insight$(EXEEXT)): Add ECHO_CXXLD.
4874         * gnulib/configure.ac: Add AM_SILENT_RULES.
4875         * gnulib/aclocal.m4: Re-generate.
4876         * gnulib/configure: Re-generate.
4877         * gnulib/import/Makefile.in: Re-generate.
4878
4879 2018-03-16  Tom Tromey  <tom@tromey.com>
4880
4881         * xcoffread.c (xcoff_symfile_offsets): Change type of "addrs".
4882         * utils.h (make_cleanup_free_section_addr_info): Don't declare.
4883         * utils.c (do_free_section_addr_info)
4884         (make_cleanup_free_section_addr_info): Remove.
4885         * symfile.h (struct other_sections): Add constructor.
4886         (struct section_addr_info): Remove.
4887         (section_addr_info): New typedef.
4888         (struct sym_fns) <sym_offsets>: Change type of parameter.
4889         (build_section_addr_info_from_objfile)
4890         (relative_addr_info_to_section_offsets, addr_info_make_relative)
4891         (default_symfile_offsets, symbol_file_add)
4892         (symbol_file_add_from_bfd)
4893         (build_section_addr_info_from_section_table): Update.
4894         (alloc_section_addr_info, free_section_addr_info): Don't declare.
4895         * symfile.c (alloc_section_addr_info): Remove.
4896         (build_section_addr_info_from_section_table): Change return type.
4897         Update.
4898         (build_section_addr_info_from_bfd)
4899         (build_section_addr_info_from_objfile): Likewise.
4900         (free_section_addr_info): Remove.
4901         (relative_addr_info_to_section_offsets): Change type of "addrs".
4902         (addrs_section_compar): Now a std::sort comparator.
4903         (addrs_section_sort): Change return type.
4904         (addr_info_make_relative): Change type of "addrs".  Update.
4905         (default_symfile_offsets, syms_from_objfile_1)
4906         (syms_from_objfile, symbol_file_add_with_addrs): Likewise.
4907         (symbol_file_add_separate): Update.
4908         (symbol_file_add): Change type of "addrs".  Update.
4909         (add_symbol_file_command): Update.  Remove cleanups.
4910         * symfile-mem.c (symbol_file_add_from_memory): Update.  Remove
4911         cleanups.
4912         * symfile-debug.c (debug_sym_offsets): Change type of "info".
4913         * solib.c (solib_read_symbols): Update.
4914         * objfiles.c (objfile_relocate): Update.  Remove cleanups.
4915         * machoread.c (macho_symfile_offsets): Update.
4916         * jit.c (jit_bfd_try_read_symtab): Update.
4917
4918 2018-03-15  Simon Marchi  <simon.marchi@polymtl.ca>
4919
4920         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4921         unittests/utils-selftests.c.
4922         * unittests/utils-selftests.c: New file.
4923
4924 2018-03-14  Tom Tromey  <tom@tromey.com>
4925
4926         PR cli/14977:
4927         * printcmd.c (printf_c_string, printf_wide_c_string): Special case
4928         for NULL.
4929
4930 2018-03-14  Tom Tromey  <tom@tromey.com>
4931
4932         PR cli/19918:
4933         * printcmd.c (printf_pointer): Allow "-" in format.
4934
4935 2018-03-14  Tom Tromey  <tom@tromey.com>
4936
4937         * printcmd.c (_initialize_printcmd): Add usage to printf.
4938
4939 2018-03-14  Yao Qi  <qiyao@sourceware.org>
4940
4941         * MAINTAINERS: Update my email address.
4942
4943 2018-03-13  Tom Tromey  <tom@tromey.com>
4944
4945         * machoread.c (macho_check_dsym): Change filenamep to a
4946         std::string*.
4947         (macho_symfile_read): Update.
4948         * symfile.c (load_command): Use std::string.
4949
4950 2018-03-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4951
4952         * riscv-tdep.c (riscv_sw_breakpoint_from_kind): Add localization
4953         to error message string.
4954         (riscv_register_name): Use xsnprintf instead of sprintf.
4955         (riscv_insn::fetch_instruction): Use gdb_assert instead of
4956         internal_error.
4957         (riscv_print_arg_location): Use gdb_assert_not_reached instead of
4958         error.
4959         (riscv_push_dummy_call): Likewise.
4960
4961 2018-03-12  Tom Tromey  <tom@tromey.com>
4962
4963         * rs6000-aix-tdep.c (rs6000_aix_core_xfer_shared_libraries_aix):
4964         Use gdb::byte_vector.
4965         * arm-tdep.c (arm_exidx_new_objfile): Use gdb::byte_vector.
4966
4967 2018-03-12  Yao Qi  <yao.qi@linaro.org>
4968
4969         * ia64-libunwind-tdep.c (libunwind_get_reg_special): Change
4970         parameter type to readable_regcache.
4971         * ia64-libunwind-tdep.h (libunwind_get_reg_special): Update
4972         the declaration.
4973
4974 2018-03-11  Tom Tromey  <tom@tromey.com>
4975
4976         * dwarf2read.c (struct nextfield): Add initializers.
4977         (struct nextfnfield): Remove.
4978         (struct fnfieldlist): Add initializers.  Remove "length" and
4979         "head", use std::vector.
4980         (struct decl_field_list): Remove.
4981         (struct field_info): Add initializers.
4982         <fields, baseclasses>: Now std::vector.
4983         <nbaseclasses, nfnfields, typedef_field_list_count,
4984         nested_types_list_count>: Remove.
4985         (dwarf2_add_field, dwarf2_add_type_defn)
4986         (dwarf2_attach_fields_to_type, dwarf2_add_member_fn)
4987         (dwarf2_attach_fn_fields_to_type, handle_struct_member_die)
4988         (process_structure_scope): Update.
4989
4990 2018-03-11  Tom Tromey  <tom@tromey.com>
4991
4992         * dwarf2read.c (sort_tu_by_abbrev_offset): Change to be suitable
4993         for use by std::sort.
4994         (build_type_psymtabs_1): Use std::vector.
4995
4996 2018-03-09  Eli Zaretskii  <eliz@gnu.org>
4997
4998         * top.c (print_gdb_configuration): Reflect LIBIPT, LIBMEMCHECK,
4999         and LIBMPFR in the printed configuration.
5000
5001 2018-03-08  Tom Tromey  <tom@tromey.com>
5002
5003         * source.c (get_filename_and_charpos): Use scoped_fd.
5004         * nto-procfs.c (procfs_open_1): Use scoped_fd.
5005         (procfs_pidlist): Likewise.
5006         * procfs.c (proc_get_LDT_entry): Use scoped_fd.
5007         (iterate_over_mappings): Likewise.
5008
5009 2018-03-08  Tom Tromey  <tom@tromey.com>
5010
5011         * infcall.c (struct call_return_meta_info)
5012         <stack_temporaries_enabled>: Remove.
5013         (get_call_return_value, call_function_by_hand_dummy): Update.
5014         * thread.c (disable_thread_stack_temporaries): Remove.
5015         (enable_thread_stack_temporaries): Remove.
5016         (thread_stack_temporaries_enabled_p): Return bool.
5017         (push_thread_stack_temporary, value_in_thread_stack_temporaries)
5018         (get_last_thread_stack_temporary): Update.
5019         * eval.c (evaluate_subexp): Update.
5020         * gdbthread.h (class enable_thread_stack_temporaries): Now a
5021         class, not a function.
5022         (value_ptr, value_vec): Remove typedefs.
5023         (class thread_info) <stack_temporaries_enabled>: Now bool.
5024         <stack_temporaries>: Now a std::vector.
5025         (thread_stack_temporaries_enabled_p)
5026         (value_in_thread_stack_temporaries): Return bool.
5027
5028 2018-03-08  Simon Marchi  <simon.marchi@ericsson.com>
5029
5030         * remote.c (putpkt_binary): Fix omitted bytes reporting.
5031         (getpkt_or_notif_sane_1): Likewise.
5032
5033 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
5034
5035         * build-id.c (build_id_to_debug_bfd): Use std::string.
5036
5037 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
5038
5039         * build-id.c (find_separate_debug_file_by_buildid): Return
5040         std::string.
5041         * build-id.h (find_separate_debug_file_by_buildid): Return
5042         std::string.
5043         * coffread.c (coff_symfile_read): Adjust to std::string.
5044         * elfread.c (elf_symfile_read): Adjust to std::string.
5045         * symfile.c (separate_debug_file_exists): Change parameter to
5046         std::string.
5047         (find_separate_debug_file): Return std::string.
5048         (find_separate_debug_file_by_debuglink): Return std::string.
5049         * symfile.h (find_separate_debug_file_by_debuglink): Return
5050         std::string.
5051
5052 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
5053
5054         * common/xml-utils.c (xml_escape_text): Move code to...
5055         (xml_escape_text_append): ... this new function.
5056         * common/xml-utils.h (xml_escape_text_append): New declaration.
5057         * unittests/xml-utils-selftests.c (test_xml_escape_text_append):
5058         New function.
5059         (_initialize_xml_utils): register test_xml_escape_text_append as
5060         a selftest.
5061
5062 2018-03-07  Alan Hayward  <alan.hayward@arm.com>
5063
5064         * defs.h: Remove MAX_REGISTER_SIZE.
5065         * regcache.c (init_regcache_descr): Remove MAX_REGISTER_SIZE
5066         asserts.
5067         * python/py-unwind.c (pyuw_sniffer): Likewise.
5068
5069 2018-03-07  Tom Tromey  <tom@tromey.com>
5070
5071         * linux-tdep.c (linux_info_proc): Update.
5072         * target.h (struct target_ops) <to_fileio_readlink>: Return
5073         optional<string>.
5074         (target_fileio_readlink): Return optional<string>.
5075         * remote.c (remote_hostio_readlink): Return optional<string>.
5076         * inf-child.c (inf_child_fileio_readlink): Return
5077         optional<string>.
5078         * target.c (target_fileio_readlink): Return optional<string>.
5079
5080 2018-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5081
5082         * regcache.c (cooked_read_test): Add riscv to the list of
5083         architectures that have a save_reggroup.
5084
5085 2018-03-07  Andreas Arnez  <arnez@linux.vnet.ibm.com>
5086
5087         * gnu-v3-abi.c (gnuv3_rtti_type): Add early exit if the given
5088         value is not a dynamic class object.
5089
5090 2018-03-06  Tom Tromey  <tom@tromey.com>
5091
5092         * rust-exp.y: Formatting fixes.
5093
5094 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5095
5096         * riscv-tdep.c (riscv_register_name): Remove target description
5097         support.
5098         (riscv_gdbarch_init): Remove target description check.
5099
5100 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5101
5102         * riscv-tdep.c: Remove 'Contributed by ...' lines from header
5103         comment.
5104         * riscv-tdep.h: Likewise.
5105
5106 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5107
5108         * riscv-tdep.c (riscv_pseudo_register_read): Delete.
5109         (riscv_pseudo_register_write): Delete.
5110         (riscv_gdbarch_init): Remove all use of pseudo registers.
5111
5112 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
5113
5114         * record-btrace.c (btrace_print_lines): Replace cleanup
5115         parameter with RAII equivalents.
5116         (btrace_insn_history): Replace cleanup with RAII equivalents.
5117         * ui-out.h (make_cleanup_ui_out_list_begin_end,
5118         make_cleanup_ui_out_tuple_begin_end): Remove.
5119         * ui-out.c (struct ui_out_end_cleanup_data, do_cleanup_end,
5120         make_cleanup_ui_out_end, make_cleanup_ui_out_tuple_begin_end,
5121         make_cleanup_ui_out_list_begin_end): Remove.
5122
5123 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
5124
5125         * record-btrace.c (record_btrace_maybe_mark_async_event): Change
5126         parameter types to std::vector.  Use bool.
5127         (record_btrace_wait): Replace VEC(tp_t) with
5128         std::vector<thread_info *>.
5129         * common/gdb_vecs.h (unordered_remove, ordered_remove): New.
5130
5131 2018-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
5132
5133         * record-btrace.c (record_btrace_disable_callback): Remove.
5134         (struct scoped_btrace_disable): New.
5135         (record_btrace_open): Use scoped_btrace_disable.
5136
5137 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5138
5139         * riscv-tdep.c (riscv_return_value): Change type to ULONGEST for
5140         reading values from registers.
5141
5142 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5143
5144         * riscv-tdep.c (riscv_push_dummy_call): Use core_addr_to_string_nz
5145         where appropriate.
5146
5147 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5148
5149         * riscv-tdep.c (riscv_print_arg_location): Add header comment,
5150         change parameter type.  Use GDB's print functions, and use
5151         core_addr_to_string where appropriate.
5152         (riscv_push_dummy_call): Use core_addr_to_string where
5153         appropriate, update call to riscv_print_arg_location, and reindent
5154         a few lines.
5155         (riscv_return_value): Update call to riscv_print_arg_location.
5156
5157 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5158             Tim Newsome <tim@sifive.com>
5159             Albert Ou <a0u@eecs.berkeley.edu>
5160             Darius Rad <darius@bluespec.com>
5161
5162         * Makefile.in (ALL_TARGET_OBS): Add riscv-tdep.o
5163         (HFILES_NO_SRCDIR): Add riscv-tdep.h.
5164         (ALLDEPFILES): Add riscv-tdep.c
5165         * configure.tgt: Add riscv support.
5166         * riscv-tdep.c: New file.
5167         * riscv-tdep.h: New file.
5168         * NEWS: Mention new target.
5169         * MAINTAINERS: Add entry for riscv.
5170
5171 2018-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5172
5173         * amd64-tdep.c (amd64_classify_aggregate): Ignore zero sized
5174         fields within aggregates.
5175
5176 2018-03-04  Simon Marchi  <simon.marchi@polymtl.ca>
5177
5178         * record-btrace.c (btrace_print_lines): Change type of flags to
5179         gdb_disassembly_flags.
5180
5181 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
5182
5183         * fbsd-nat.c: Include "inf-ptrace.h".
5184         (USE_SIGTRAP_SIGINFO): Conditionally define.
5185         [USE_SIGTRAP_SIGINFO] (fbsd_handle_debug_trap): New function.
5186         (fbsd_wait) [USE_SIGTRAP_SIGINFO]: Call "fbsd_handle_debug_trap".
5187         [USE_SIGTRAP_SIGINFO] (fbsd_stopped_by_sw_breakpoint): New
5188         function.
5189         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_sw_breakpoint):
5190         Likewise.
5191         [USE_SIGTRAP_SIGINFO] (fbsd_supports_stopped_by_hw_breakpoint):
5192         Likewise.
5193         (fbsd_nat_add_target) [USE_SIGTRAP_SIGINFO]: Set
5194         "stopped_by_sw_breakpoint", "supports_stopped_by_sw_breakpoint",
5195         "supports_stopped_by_hw_breakpoint" target methods.
5196
5197 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
5198
5199         * NEWS (Changes since GDB 8.1): Add "set/show debug fbsd-nat".
5200         * fbsd-nat.c (debug_fbsd_nat): New variable.
5201         (show_fbsd_nat_debug): New function.
5202         (fbsd_wait): Log LWP info if "debug_fbsd_nat" is enabled.
5203         (_initialize_fbsd_nat): Add "fbsd-nat" debug boolean command.
5204
5205 2018-03-04  John Baldwin  <jhb@FreeBSD.org>
5206
5207         * nat/x86-dregs.c (x86_dr_stopped_by_hw_breakpoint): New function.
5208         * nat/x86-dregs.h (x86_dr_stopped_by_hw_breakpoint): New
5209         prototype.
5210         * x86-nat.c (x86_stopped_by_hw_breakpoint): New function.
5211         (x86_use_watchpoints): Set "stopped_by_hw_breakpoint" target
5212         method.
5213
5214 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5215
5216         * common/gdb_vecs.c (free_char_ptr_vec): Remove.
5217         * common/gdb_vecs.h (free_char_ptr_vec): Remove.
5218
5219 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5220
5221         * charset.c (struct charset_vector): New.
5222         (charsets): Change type to charset_vector.
5223         (find_charset_names): Adjust.
5224         (add_one): Adjust.
5225         (_initialize_charset): Adjust.
5226
5227 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5228
5229         * progspace.h (struct program_space) <deleted_solibs>: Change
5230         type to std::vector<std::string>.
5231         * progspace.c (clear_program_space_solib_cache): Adjust.
5232         * breakpoint.c (print_solib_event): Adjust.
5233         (check_status_catch_solib): Adjust.
5234         * solib.c (update_solib_list): Adjust.
5235         * ui-out.h (class ui_out) <field_string>: New overload.
5236         * ui-out.c (ui_out::field_string): New overload.
5237
5238 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5239
5240         * progspace.h (struct program_space): Add constructor and
5241         destructor, initialize fields.
5242         (add_program_space): Remove.
5243         * progspace.c (add_program_space): Rename to...
5244         (program_space::program_space): ... this.
5245         (release_program_space): Rename to...
5246         (program_space::~program_space): ... this.
5247         (delete_program_space): Use delete to delete program_space.
5248         (initialize_progspace): Use new to allocate program_space.
5249         * inferior.c (add_inferior_with_spaces): Likewise.
5250         (clone_inferior_command): Likewise.
5251         * infrun.c (follow_fork_inferior): Likewise.
5252         (handle_vfork_child_exec_or_exit): Likewise.
5253
5254 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
5255
5256         * common/gdb_vecs.h (make_cleanup_free_char_ptr_vec): Remove.
5257         (delim_string_to_char_ptr_vec): Return std::vector of
5258         gdb::unique_xmalloc_ptr.
5259         (dirnames_to_char_ptr_vec_append): Take std::vector of
5260         gdb::unique_xmalloc_ptr.
5261         (dirnames_to_char_ptr_vec): Return std::vector of
5262         gdb::unique_xmalloc_ptr.
5263         * common/gdb_vecs.c (delim_string_to_char_ptr_vec_append):
5264         Take std::vector of gdb::unique_xmalloc_ptr, adjust the code.
5265         (delim_string_to_char_ptr_vec): Return an std::vector of
5266         gdb::unique_xmalloc_ptr, adjust the code.
5267         (dirnames_to_char_ptr_vec_append): Take an std::vector of
5268         gdb::unique_xmalloc_ptr, adjust the code.
5269         (dirnames_to_char_ptr_vec): Return an std::vector of
5270         gdb::unique_xmalloc_ptr, adjust the code.
5271         * auto-load.c (auto_load_safe_path_vec): Change type to
5272         std::vector of gdb::unique_xmalloc_ptr.
5273         (auto_load_expand_dir_vars): Return an std::vector of
5274         gdb::unique_xmalloc_ptr, adjust the code.
5275         (auto_load_safe_path_vec_update): Adjust.
5276         (filename_is_in_auto_load_safe_path_vec): Adjust.
5277         (auto_load_objfile_script_1): Adjust.
5278         * build-id.c (build_id_to_debug_bfd): Adjust.
5279         * linux-thread-db.c (thread_db_load_search): Adjust.
5280         * source.c (add_path): Adjust.
5281         (openp): Adjust.
5282         * symfile.c (find_separate_debug_file): Adjust.
5283         * utils.c (do_free_char_ptr_vec): Remove.
5284         (make_cleanup_free_char_ptr_vec): Remove.
5285
5286 2018-03-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5287
5288         PR gdb/22907
5289         * common/pathstuff.c: Conditionally include "<windows.h>".
5290
5291 2018-03-01  Georg Sauthoff  <mail@georg.so>
5292
5293         PR gdb/22888
5294         * gcore.in: Quote variables and switch interpreter to bash.
5295
5296 2018-03-01  Tom Tromey  <tom@tromey.com>
5297
5298         * dwarf2read.c (alloc_discriminant_info): Fix default_index
5299         assertion.  Add assertion for discriminant_index.
5300         (quirk_rust_enum): Use correct base type name in univariant case.
5301
5302 2018-03-01  Simon Marchi  <simon.marchi@ericsson.com>
5303
5304         * record.c (get_call_history_modifiers): Return a
5305         record_print_flags.
5306         (cmd_record_call_history): Adjust.
5307         * record-btrace.c (record_btrace_call_history): Adjust.
5308         (record_btrace_call_history_range): Adjust.
5309         (record_btrace_call_history_from): Adjust.
5310         * target-debug.h (target_debug_print_record_print_flags): New.
5311         * target-delegates.c: Re-generate.
5312         * target.c (target_call_history): Change flags type.
5313         (target_call_history_from): Likewise.
5314         (target_call_history_range): Likewise.
5315         * target.h (struct target_ops) <target_call_history>: Likewise.
5316         (target_call_history_from): Likewise.
5317         (target_call_history_range): Likewise.
5318
5319 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5320             Simon Marchi  <simon.marchi@polymtl.ca>
5321
5322         * common/common-utils.c: Include "sys/stat.h".
5323         (is_regular_file): Move here from "source.c"; change return
5324         type to "bool".
5325         * common/common-utils.h (is_regular_file): New prototype.
5326         * common/pathstuff.c (contains_dir_separator): New function.
5327         * common/pathstuff.h (contains_dir_separator): New prototype.
5328         * source.c: Don't include "sys/stat.h".
5329         (is_regular_file): Move to "common/common-utils.c".
5330
5331 2018-02-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5332
5333         * Makefile.in (COMMON_SFILES): Add "common/pathstuff.c".
5334         (HFILES_NO_SRCDIR): Add "common/pathstuff.h".
5335         * auto-load.c: Include "common/pathstuff.h".
5336         * common/common-def.h (current_directory): Move here.
5337         * common/gdb_tilde_expand.c (gdb_tilde_expand_up): New
5338         function.
5339         * common/gdb_tilde_expand.h (gdb_tilde_expand_up): New
5340         prototype.
5341         * common/pathstuff.c: New file.
5342         * common/pathstuff.h: New file.
5343         * compile/compile.c: Include "common/pathstuff.h".
5344         * defs.h (current_directory): Move to "common/common-defs.h".
5345         * dwarf2read.c: Include "common/pathstuff.h".
5346         * exec.c: Likewise.
5347         * guile/scm-safe-call.c: Likewise.
5348         * linux-thread-db.c: Likewise.
5349         * main.c: Likewise.
5350         * nto-tdep.c: Likewise.
5351         * objfiles.c: Likewise.
5352         * source.c: Likewise.
5353         * symtab.c: Likewise.
5354         * utils.c: Include "common/pathstuff.h".
5355         (gdb_realpath): Move to "common/pathstuff.c".
5356         (gdb_realpath_keepfile): Likewise.
5357         (gdb_abspath): Likewise.
5358         * utils.h (gdb_realpath): Move to "common/pathstuff.h".
5359         (gdb_realpath_keepfile): Likewise.
5360         (gdb_abspath): Likewise.
5361
5362 2018-02-28  John Baldwin  <jhb@FreeBSD.org>
5363
5364         * fbsd-nat.c (fbsd_resume): Use PT_SETSTEP for stepping and a
5365         wildcard process pid for super_resume for kernels with a
5366         specific bug.
5367
5368 2018-02-27  Phil Muldoon  <pmuldoon@redhat.com>
5369
5370         * compile/compile.c (get_args): Add additional comments
5371         explaining function.
5372
5373 2018-02-27  Simon Marchi  <simon.marchi@polymtl.ca>
5374             Tom Tromey  <tom@tromey.com>
5375
5376         * target.h (memory_write_request_s): Remove typedef.  Don't define
5377         VEC.
5378         (target_write_memory_blocks): Change argument to std::vector.
5379         (struct memory_write_request): Add constructor.
5380         * target-memory.c (compare_block_starting_address): Return bool.
5381         Change argument types.
5382         (claim_memory): Change arguments to use std::vector.
5383         (split_regular_and_flash_blocks, blocks_to_erase)
5384         (compute_garbled_blocks): Likewise.
5385         (cleanup_request_data, cleanup_write_requests_vector): Remove.
5386         (target_write_memory_blocks): Change argument to std::vector.
5387         * symfile.c (struct load_section_data): Add constructor and
5388         destructor.  Use std::vector for "requests".
5389         (struct load_progress_data): Add initializers.
5390         (load_section_callback): Update.  Use "new".
5391         (clear_memory_write_data): Remove.
5392         (generic_load): Update.
5393
5394 2018-02-27  Alan Hayward  <alan.hayward@arm.com>
5395
5396         * arch/aarch64.h: Use common/tdesc.h.
5397
5398 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
5399
5400         * mips-tdep.c (mips_gdbarch_init): Don't use a 32-bit BFD
5401         architecture with a 64-bit ABI.
5402
5403 2018-02-26  Maciej W. Rozycki  <macro@mips.com>
5404
5405         * gdb/mips-tdep.c (mips_gdbarch_init): Reorder ABI determination
5406         ahead of target description loading.
5407
5408 2018-02-26  Tom Tromey  <tom@tromey.com>
5409
5410         * stack.c (backtrace_command_1): Update.
5411         * python/python-internal.h (gdbpy_apply_frame_filter): Change type
5412         of "flags".
5413         * python/py-framefilter.c (py_print_frame)
5414         (gdbpy_apply_frame_filter): Change type of "flags".
5415         * mi/mi-cmd-stack.c (mi_apply_ext_lang_frame_filter): Change type
5416         of "flags".
5417         (mi_cmd_stack_list_frames, mi_cmd_stack_list_locals)
5418         (mi_cmd_stack_list_args, mi_cmd_stack_list_variables): Update.
5419         * extension.h (enum frame_filter_flag): Rename from
5420         frame_filter_flags.
5421         (frame_filter_flags): Define using DEF_ENUM_FLAGS_TYPE.
5422         (apply_ext_lang_frame_filter): Change type of "flags".
5423         * extension.c (apply_ext_lang_frame_filter): Change type of
5424         "flags".
5425         * extension-priv.h (struct extension_language_ops)
5426         <apply_frame_filter>: Change type of "flags".
5427
5428 2018-02-26  Tom Tromey  <tom@tromey.com>
5429
5430         PR python/16497:
5431         * stack.c (backtrace_command_1): Set PRINT_MORE_FRAMES flag.  Fix
5432         off-by-one in py_end computation.
5433         * python/py-framefilter.c (gdbpy_apply_frame_filter): Handle
5434         PRINT_MORE_FRAMES.
5435         * extension.h (enum frame_filter_flags) <PRINT_MORE_FRAMES>: New
5436         constant.
5437
5438 2018-02-26  Tom Tromey  <tom@tromey.com>
5439
5440         * dwarf2read.c (struct variant_field): New.
5441         (struct nextfield) <variant>: New field.
5442         (dwarf2_add_field): Handle DW_TAG_variant_part.
5443         (dwarf2_attach_fields_to_type): Attach a discriminant_info to a
5444         discriminated union.
5445         (read_structure_type): Handle DW_TAG_variant_part.
5446         (handle_struct_member_die): New function, extracted from
5447         process_structure_scope.  Handle DW_TAG_variant.
5448         (process_structure_scope): Handle discriminated unions.  Call
5449         handle_struct_member_die.
5450
5451 2018-02-26  Tom Tromey  <tom@tromey.com>
5452
5453         * rust-lang.h (rust_last_path_segment): Declare.
5454         * rust-lang.c (rust_last_path_segment): Now public.  Change
5455         contract.
5456         (struct disr_info): Remove.
5457         (RUST_ENUM_PREFIX, RUST_ENCODED_ENUM_REAL)
5458         (RUST_ENCODED_ENUM_HIDDEN, rust_union_is_untagged)
5459         (rust_get_disr_info, rust_tuple_variant_type_p): Remove.
5460         (rust_enum_p, rust_enum_variant): New function.
5461         (rust_underscore_fields): Remove "offset" parameter.
5462         (rust_print_enum): New function.
5463         (rust_val_print) <TYPE_CODE_UNION>: Remove enum code.
5464         <TYPE_CODE_STRUCT>: Call rust_print_enum when appropriate.
5465         (rust_print_struct_def): Add "for_rust_enum" parameter.  Handle
5466         enums.
5467         (rust_internal_print_type): New function, from rust_print_type.
5468         Remove enum code.
5469         (rust_print_type): Call rust_internal_print_type.
5470         (rust_evaluate_subexp) <STRUCTOP_ANONYMOUS, STRUCTOP_STRUCT>:
5471         Update enum handling.
5472         * dwarf2read.c (struct dwarf2_cu) <rust_unions>: New field.
5473         (rust_fully_qualify, alloc_discriminant_info, quirk_rust_enum)
5474         (rust_union_quirks): New functions.
5475         (process_full_comp_unit, process_full_type_unit): Call
5476         rust_union_quirks.
5477         (process_structure_scope): Update rust_unions if necessary.
5478
5479 2018-02-26  Tom Tromey  <tom@tromey.com>
5480
5481         * value.h (value_union_variant): Declare.
5482         * valops.c (value_union_variant): New function.
5483         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): New macro.
5484         (struct discriminant_info): New.
5485         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: New
5486         enumerator.
5487         (struct main_type) <flag_discriminated_union>: New field.
5488
5489 2018-02-26  Tom Tromey  <tom@tromey.com>
5490
5491         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5492         unittests/unpack-selftests.c.
5493         * unittests/unpack-selftests.c: New file.
5494         * value.c (unpack_bits_as_long): Fix bugs in non-bitfield cases.
5495
5496 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5497
5498         * dwarf2read.c (struct partial_die_info) <read>: New method.
5499         (read_partial_die): Remove the declaration.
5500         (load_partial_dies): Update.
5501         (partial_die_info::partial_die_info):
5502         (read_partial_die): Change it to partial_die_info::read.
5503
5504 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5505
5506         * dwarf2read.c (struct partial_die_info) <fixup>: New method.
5507         (fixup_partial_die): Remove declaration.
5508         (scan_partial_symbols): Update.
5509         (partial_die_parent_scope): Likewise.
5510         (partial_die_full_name): Likewise.
5511         (fixup_partial_die): Change it to partial_die_info::fixup.
5512
5513 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5514
5515         * dwarf2read.c (read_partial_die): Update the declaration.
5516         (load_partial_dies): Caller update.
5517         (read_partial_die): Remove one argument abbrev_len.
5518
5519 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5520
5521         * dwarf2read.c (struct partial_die_info): Add ctor, delete
5522         assignment operator.
5523         (load_partial_dies): Use ctor and copy ctor.
5524         (read_partial_die): Update.
5525         (dwarf2_cu::find_partial_die): Use ctor.
5526
5527 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5528
5529         * dwarf2read.c (struct dwarf2_cu) <find_partial_die>: New method.
5530         (find_partial_die_in_comp_unit): Change it to
5531         dwarf2_cu::find_partial_die.
5532         (find_partial_die): Update.
5533
5534 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5535
5536         * dwarf2read.c (read_partial_die): Remove the code checking abbrev
5537         is NULL.
5538
5539 2018-02-26  Yao Qi  <yao.qi@linaro.org>
5540
5541         * dwarf2read.c (load_partial_dies): Move the location of XOBNEW.
5542
5543 2018-02-26  Alan Hayward  <alan.hayward@arm.com>
5544
5545         * arch/amd64.h: Use common/tdesc.h.
5546         * arch/i386.c: Likewise.
5547         * arch/i386.h: Likewise.
5548         * arch/tic6x.c: Likewise.
5549         * arch/tdesc.h: Move file from here...
5550         * common/tdesc.h: ...to here.
5551         * features/aarch64-core.c: Regenerate.
5552         * features/aarch64-fpu.c: Regenerate.
5553         * features/i386/32bit-avx.c: Regenerate.
5554         * features/i386/32bit-avx512.c: Regenerate.
5555         * features/i386/32bit-core.c: Regenerate.
5556         * features/i386/32bit-linux.c: Regenerate.
5557         * features/i386/32bit-mpx.c: Regenerate.
5558         * features/i386/32bit-pkeys.c: Regenerate.
5559         * features/i386/32bit-sse.c: Regenerate.
5560         * features/i386/64bit-avx.c: Regenerate.
5561         * features/i386/64bit-avx512.c: Regenerate.
5562         * features/i386/64bit-core.c: Regenerate.
5563         * features/i386/64bit-linux.c: Regenerate.
5564         * features/i386/64bit-mpx.c: Regenerate.
5565         * features/i386/64bit-pkeys.c: Regenerate.
5566         * features/i386/64bit-segments.c: Regenerate.
5567         * features/i386/64bit-sse.c: Regenerate.
5568         * features/i386/x32-core.c: Regenerate.
5569         * features/tic6x-c6xp.c: Regenerate.
5570         * features/tic6x-core.c: Regenerate.
5571         * features/tic6x-gp.c: Regenerate.
5572         * target-descriptions.c: Use common/tdesc.h.
5573         * target-descriptions.h: Likewise.
5574
5575 2018-02-24  Tom Tromey  <tom@tromey.com>
5576
5577         * linux-thread-db.c (try_thread_db_load_from_pdir_1)
5578         (try_thread_db_load_from_dir, thread_db_load_search): Use
5579         std::string.
5580         (info_auto_load_libthread_db_compare): Return bool.  Change
5581         argument types.
5582         (info_auto_load_libthread_db): Use std::vector, std::string.
5583         Remove cleanups.
5584
5585 2018-02-24  Tom Tromey  <tom@tromey.com>
5586
5587         * i386-tdep.c (i386_fast_tracepoint_valid_at): "msg" now a
5588         std::string.
5589         * gdbarch.sh (fast_tracepoint_valid_at): Change "msg" to a
5590         std::string*.
5591         * gdbarch.c: Rebuild.
5592         * gdbarch.h: Rebuild.
5593         * breakpoint.c (check_fast_tracepoint_sals): Use std::string.
5594         * arch-utils.h (default_fast_tracepoint_valid_at): Update.
5595         * arch-utils.c (default_fast_tracepoint_valid_at): "msg" now a
5596         std::string*.
5597
5598 2018-02-23  Simon Marchi  <simon.marchi@polymtl.ca>
5599
5600         * gdbtypes.h (sect_offset): Change type to uint64_t.
5601         (sect_offset_str): New function.
5602         * dwarf2read.c (create_addrmap_from_aranges): Use
5603         sect_offset_str.
5604         (error_check_comp_unit_head): Likewise.
5605         (create_debug_type_hash_table): Likewise.
5606         (read_cutu_die_from_dwo): Likewise.
5607         (init_cutu_and_read_dies): Likewise.
5608         (init_cutu_and_read_dies_no_follow): Likewise.
5609         (process_psymtab_comp_unit_reader): Likewise.
5610         (partial_die_parent_scope): Likewise.
5611         (peek_die_abbrev): Likewise.
5612         (process_queue): Likewise.
5613         (dwarf2_physname): Likewise.
5614         (read_namespace_alias): Likewise.
5615         (read_import_statement): Likewise.
5616         (create_dwo_cu_reader): Likewise.
5617         (create_cus_hash_table): Likewise.
5618         (lookup_dwo_cutu): Likewise.
5619         (inherit_abstract_dies): Likewise.
5620         (read_func_scope): Likewise.
5621         (read_call_site_scope): Likewise.
5622         (dwarf2_add_member_fn): Likewise.
5623         (read_common_block): Likewise.
5624         (read_module_type): Likewise.
5625         (read_typedef): Likewise.
5626         (read_subrange_type): Likewise.
5627         (load_partial_dies): Likewise.
5628         (read_partial_die): Likewise.
5629         (find_partial_die): Likewise.
5630         (read_str_index): Likewise.
5631         (dwarf2_string_attr): Likewise.
5632         (build_error_marker_type): Likewise.
5633         (lookup_die_type): Likewise.
5634         (dump_die_shallow): Likewise.
5635         (follow_die_ref): Likewise.
5636         (dwarf2_fetch_die_loc_sect_off): Likewise.
5637         (dwarf2_fetch_constant_bytes): Likewise.
5638         (follow_die_sig): Likewise.
5639         (get_signatured_type): Likewise.
5640         (get_DW_AT_signature_type): Likewise.
5641         (dwarf2_find_containing_comp_unit): Likewise.
5642         (set_die_type): Likewise.
5643
5644 2018-02-21  John Baldwin  <jhb@FreeBSD.org>
5645
5646         * arch/aarch64.c: Include "common-defs.h".
5647         * arch/amd64.c: Likewise.
5648         * arch/i386.c: Likewise.
5649
5650 2018-02-21  Tom Tromey  <tom@tromey.com>
5651
5652         * value.h: (extract_field_op): Update.
5653         * eval.c (extract_field_op): Return a const char *.
5654         * expression.h (parse_expression_for_completion): Update.
5655         * completer.c (complete_expression): Update.
5656         (add_struct_fields): Make fieldname const.
5657         * parse.c (expout_completion_name): Now a unique_xmalloc_ptr.
5658         (mark_completion_tag, parse_exp_in_context_1): Update.
5659         (parse_expression_for_completion): Change "name" to
5660         unique_xmalloc_ptr*.
5661
5662 2018-02-21  Tom Tromey  <tom@tromey.com>
5663
5664         * infcall.c (call_function_by_hand_dummy): Use std::vector.
5665
5666 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5667
5668         * avr-tdep.c (avr_read_pc): Change parameter type to
5669         readable_regcache.
5670         * gdbarch.sh (read_pc): Likewise.
5671         * gdbarch.c: Re-generated.
5672         * gdbarch.h: Re-generated.
5673         * hppa-tdep.c (hppa_read_pc): Change parameter type to
5674         readable_regcache.
5675         * ia64-tdep.c (ia64_read_pc): Likewise.
5676         * mips-tdep.c (mips_read_pc): Likewise.
5677         * spu-tdep.c (spu_read_pc): Likewise.
5678
5679 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5680
5681         * Makefile.in (COMMON_SFILES): Add regcache-dump.c
5682         * regcache-dump.c: New file.
5683         * regcache.c: Move register_dump to regcache-dump.c.
5684         (maintenance_print_registers): Likewise.
5685         (maintenance_print_raw_registers): Likewise.
5686         (maintenance_print_cooked_registers): Likewise.
5687         (maintenance_print_register_groups): Likewise.
5688         (maintenance_print_remote_registers): Likewise.
5689         (_initialize_regcache): Likewise.
5690         * regcache.h (register_dump): Moved from regcache.c.
5691
5692 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5693
5694         * regcache.c (regcache::regcache): Update.
5695         (regcache::invalidate): Move it to detached_regcache::invalidate.
5696         (get_thread_arch_aspace_regcache): Update.
5697         (regcache::raw_update): Update.
5698         (regcache::cooked_read): Remove some code.
5699         (regcache::cooked_read_value): Likewise.
5700         (regcache::raw_write): Remove assert on m_readonly_p.
5701         (regcache::raw_supply_integer): Move it to
5702         detached_regcache::raw_supply_integer.
5703         (regcache::raw_supply_zeroed): Likewise.
5704         * regcache.h (detached_regcache) <raw_supply_integer>: New
5705         declaration.
5706         <raw_supply_zeroed, invalidate>: Likewise.
5707         (regcache) <raw_supply_integer, raw_supply_zeroed>: Removed.
5708         <invalidate>: Likewise.
5709         <m_readonly_p>: Removed.
5710
5711 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5712
5713         * infcmd.c (get_return_value): Let stop_regs point to
5714         get_current_regcache.
5715         * regcache.c (regcache::regcache): Remove.
5716         (register_dump_reg_buffer): New class.
5717         (regcache_print): Adjust.
5718         * regcache.h (regcache): Remove constructors.
5719
5720 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5721
5722         * regcache.c (class register_dump): New class.
5723         (register_dump_regcache, register_dump_none): New class.
5724         (register_dump_remote, register_dump_groups): New class.
5725         (regcache_print): Update.
5726         * regcache.h (regcache_dump_what): Move it to regcache.c.
5727         (regcache) <dump>: Remove.
5728
5729 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5730
5731         * jit.c (struct jit_unwind_private) <regcache>: Change its type to
5732          reg_buffer_rw *.
5733         (jit_unwind_reg_set_impl): Call raw_supply.
5734         (jit_frame_sniffer): Use reg_buffer_rw.
5735         * record-full.c (record_full_core_regbuf): Change its type.
5736         (record_full_core_open_1): Use reg_buffer_rw.
5737         (record_full_close): Likewise.
5738         (record_full_core_fetch_registers): Use regcache->raw_supply.
5739         (record_full_core_store_registers): Likewise.
5740         * regcache.c (regcache::get_register_status): Move it to
5741         reg_buffer.
5742         (regcache_raw_set_cached_value): Remove.
5743         (regcache::raw_set_cached_value): Remove.
5744         (regcache::raw_write): Call raw_supply.
5745         (regcache::raw_supply): Move it to reg_buffer_rw.
5746         * regcache.h (regcache_raw_set_cached_value): Remove.
5747         (reg_buffer_rw): New class.
5748
5749 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5750
5751         * dummy-frame.c (dummy_frame_cache) <prev_regcache>: Use
5752         readonly_detached_regcache.
5753         (dummy_frame_prev_register): Use regcache->cooked_read.
5754         * frame.c (frame_save_as_regcache): Change return type.
5755         (frame_pop): Update.
5756         * frame.h (frame_save_as_regcache): Update declaration.
5757         * inferior.h (get_infcall_suspend_state_regcache): Update
5758         declaration.
5759         * infrun.c (infcall_suspend_state) <registers>: use
5760         readonly_detached_regcache.
5761         (save_infcall_suspend_state): Don't use regcache_dup.
5762         (get_infcall_suspend_state_regcache): Change return type.
5763         * linux-fork.c (struct fork_info) <savedregs>: Change to
5764         readonly_detached_regcache.
5765         <pc>: New field.
5766         (fork_save_infrun_state): Don't use regcache_dup.
5767         (info_checkpoints_command): Adjust.
5768         * mi/mi-main.c (register_changed_p): Update declaration.
5769         (mi_cmd_data_list_changed_registers): Use
5770         readonly_detached_regcache.
5771         (register_changed_p): Change parameter type to
5772         readonly_detached_regcache.
5773         * ppc-linux-tdep.c (ppu2spu_cache) <regcache>: Use
5774         readonly_detached_regcache.
5775         (ppu2spu_sniffer): Construct a new readonly_detached_regcache.
5776         * regcache.c (readonly_detached_regcache::readonly_detached_regcache):
5777         New.
5778         (regcache::save): Move it to reg_buffer.
5779         (regcache::restore): Change parameter type.
5780         (regcache_dup): Remove.
5781         * regcache.h (reg_buffer) <save>: New method.
5782         (readonly_detached_regcache): New class.
5783         * spu-tdep.c (spu2ppu_cache) <regcache>: Use
5784         readonly_detached_regcache.
5785         (spu2ppu_sniffer): Construct a new readonly_detached_regcache.
5786
5787 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5788
5789         * frame.c (frame_save_as_regcache): Use regcache method save.
5790         (frame_pop): Use regcache method restore.
5791         * infrun.c (restore_infcall_suspend_state): Likewise.
5792         * linux-fork.c (fork_load_infrun_state): Likewise.
5793         * ppc-linux-tdep.c (ppu2spu_sniffer): User regcache method
5794         save.
5795         * regcache.c (regcache_save): Remove.
5796         (regcache::restore): More asserts.
5797         (regcache_cpy): Remove.
5798         * regcache.h (regcache_save): Remove the declaration.
5799         (regcache::restore): Move from private to public.
5800         Remove the friend declaration of regcache_cpy.
5801         (regcache_cpy): Remove declaration.
5802
5803 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5804
5805         * aarch64-tdep.c (aarch64_pseudo_register_read_value): Change
5806         parameter type to 'readable_regcache *'.
5807         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
5808         * arm-tdep.c (arm_neon_quad_read): Likewise.
5809         (arm_pseudo_read): Likewise.
5810         * avr-tdep.c (avr_pseudo_register_read): Likewise.
5811         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
5812         * frv-tdep.c (frv_pseudo_register_read): Likewise.
5813         * gdbarch.c: Re-generated.
5814         * gdbarch.h: Re-generated.
5815         * gdbarch.sh (pseudo_register_read): Change parameter type to
5816         'readable_regcache *'.
5817         (pseudo_register_read_value): Likewise.
5818         * h8300-tdep.c (pseudo_from_raw_register): Likewise.
5819         (h8300_pseudo_register_read): Likewise.
5820         * hppa-tdep.c (hppa_pseudo_register_read): Likewise.
5821         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
5822         (i386_pseudo_register_read_into_value): Likewise.
5823         (i386_pseudo_register_read_value): Likewise.
5824         * i386-tdep.h (i386_pseudo_register_read_into_value): Update
5825         declaration.
5826         * ia64-tdep.c (ia64_pseudo_register_read): Likewise.
5827         * m32c-tdep.c (m32c_raw_read): Likewise.
5828         (m32c_read_flg): Likewise.
5829         (m32c_banked_register): Likewise.
5830         (m32c_banked_read): Likewise.
5831         (m32c_sb_read): Likewise.
5832         (m32c_part_read): Likewise.
5833         (m32c_cat_read): Likewise.
5834         (m32c_r3r2r1r0_read): Likewise.
5835         (m32c_pseudo_register_read): Likewise.
5836         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
5837         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
5838         (mep_pseudo_cr64_read): Likewise.
5839         (mep_pseudo_register_read): Likewise.
5840         * mips-tdep.c (mips_pseudo_register_read): Likewise.
5841         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
5842         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
5843         * regcache.c (regcache::raw_read): Move it to readable_regcache.
5844         (regcache::cooked_read): Likewise.
5845         (regcache::cooked_read_value): Likewise.
5846         (regcache_cooked_read_signed):
5847         (regcache::cooked_read): Likewise.
5848         * regcache.h (readable_regcache): New class.
5849         (regcache): Inherit readable_regcache.  Move some methods to
5850         readable_regcache.
5851         * rl78-tdep.c (rl78_pseudo_register_read): Change
5852         parameter type to 'readable_regcache *'.
5853         * rs6000-tdep.c (do_regcache_raw_read): Remove.
5854         (e500_pseudo_register_read): Change parameter type to
5855         'readable_regcache *'.
5856         (dfp_pseudo_register_read): Likewise.
5857         (vsx_pseudo_register_read): Likewise.
5858         (efpr_pseudo_register_read): Likewise.
5859         * s390-tdep.c (s390_pseudo_register_read): Likewise.
5860         * sh-tdep.c (sh_pseudo_register_read): Likewise.
5861         * sh64-tdep.c (pseudo_register_read_portions): Likewise.
5862         (sh64_pseudo_register_read): Likewise.
5863         * sparc-tdep.c (sparc32_pseudo_register_read): Likewise.
5864         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
5865         * spu-tdep.c (spu_pseudo_register_read_spu): Likewise.
5866         (spu_pseudo_register_read): Likewise.
5867         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
5868         (xtensa_pseudo_register_read): Likewise.
5869
5870 2018-02-21  Yao Qi  <yao.qi@linaro.org>
5871
5872         * regcache.c (regcache::regcache): Call reg_buffer ctor.
5873         (regcache::arch): Move it to reg_buffer::arch.
5874         (regcache::register_buffer): Likewise.
5875         (regcache::assert_regnum): Likewise.
5876         (regcache::num_raw_registers): Likewise.
5877         * regcache.h (reg_buffer): New class.
5878         (regcache): Inherit reg_buffer.
5879
5880 2018-02-20  Simon Marchi  <simon.marchi@ericsson.com>
5881
5882         * remote-sim.c (gdb_os_printf_filtered, gdb_os_vprintf_filtered,
5883         gdb_os_evprintf_filtered, gdb_os_error): Add ATTRIBUTE_PRINTF.
5884
5885 2018-02-20  Markus Metzger  <markus.t.metzger@intel.com>
5886
5887         * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add mkstemp.
5888
5889 2018-02-19  Alan Hayward  <alan.hayward@arm.com>
5890
5891         * Makefile.in: (COMMON_SFILES): Add common/*.c files.
5892         (SFILES): Remove common/*.c files.
5893         (COMMON_OBS): Remove some *.o files built from common/*.c files.
5894         * common/common.host: Add common reference.
5895         * configure.ac: Likewise.
5896         * configure: Regenerate.
5897
5898 2018-02-16  Yao Qi  <yao.qi@linaro.org>
5899
5900         * block.c (block_namespace_info): Inherit allocate_on_obstack.
5901         (block_initialize_namespace): Use new.
5902         * dwarf2read.c (dwarf2_per_objfile): Inherit allocate_on_obstack.
5903         (dwarf2_free_objfile): Use delete.
5904         * gdbtypes.c (type_pair): Inherit allocate_on_obstack.
5905         (copy_type_recursive): Use new.
5906         * gdb_obstack.h (allocate_on_obstack): New.
5907
5908 2018-02-15  Yao Qi  <yao.qi@linaro.org>
5909
5910         PR gdb/22849
5911         * inferior.c (exit_inferior_1): Reset inf->control.
5912
5913 2018-02-15  Joel Brobecker  <brobecker@adacore.com>
5914
5915         * ada-lang.c (ada_to_fixed_value_create): Delete advance
5916         declaration.
5917
5918 2018-02-14  Pedro Alves  <palves@redhat.com>
5919
5920         * frame-unwind.c (frame_unwind_try_unwinder): Always call
5921         frame_cleanup_after_sniffer on exception.
5922
5923 2018-02-14  Tom Tromey  <tom@tromey.com>
5924
5925         * solist.h (struct target_so_ops) <bfd_open>: Make pathname
5926         const.
5927         (solib_bfd_open): Make pathname const.
5928         * solib.c (solib_bfd_open): Make pathname const.
5929         * solib-spu.c (spu_bfd_fopen): Make name const.
5930         (spu_bfd_open): Make pathname const.
5931         * solib-darwin.c (darwin_bfd_open): Make pathname const.
5932         * solib-aix.c (solib_aix_bfd_open): Make pathname const.
5933
5934 2018-02-14  Tom Tromey  <tom@tromey.com>
5935
5936         * symfile.c (symfile_bfd_open): Update.
5937         * source.h (openp, source_full_path_of, find_and_open_source):
5938         Change argument type to unique_xmalloc_ptr.
5939         * source.c (openp): Take a unique_xmalloc_ptr.
5940         (source_full_path_of, find_and_open_source): Likewise.
5941         (open_source_file, symtab_to_fullname): Update.
5942         * solist.h (struct target_so_ops) <find_and_open_solib>: Take a
5943         unique_xmalloc_ptr.
5944         * solib.c (solib_find_1): Use unique_xmalloc_ptr.
5945         (exec_file_find): Update.
5946         * psymtab.c (psymtab_to_fullname): Update.
5947         * nto-tdep.h (nto_find_and_open_solib): Update.
5948         * nto-tdep.c (nto_find_and_open_solib): Change temp_path to a
5949         unique_xmalloc_ptr.
5950         * exec.c (exec_file_attach): Update.
5951         * dwarf2read.c (try_open_dwop_file): Use unique_xmalloc_ptr.
5952         * cli/cli-cmds.c (find_and_open_script): Use unique_xmalloc_ptr.
5953
5954 2018-02-14  Tom Tromey  <tom@tromey.com>
5955
5956         * solib.c: Include source.h.
5957         * nto-tdep.c: Include source.h.
5958         * mi/mi-cmd-env.c: Include source.h.
5959         * infcmd.c: Include source.h.
5960         * exec.c: Include source.h.
5961         * defs.h (enum openp_flag, openp, source_full_path_of, mod_path)
5962         (add_path, directory_switch, source_path, init_source_path): Move
5963         declarations...
5964         * source.h (enum openp_flag, openp, source_full_path_of, mod_path)
5965         (add_path, directory_switch, source_path, init_source_path):
5966         ...here.
5967
5968 2018-02-14  Tom Tromey  <tom@tromey.com>
5969
5970         * solist.h (exec_file_find, solib_find): Return
5971         unique_xmalloc_ptr.
5972         (solib_bfd_fopen): Take a const char *.
5973         * solib.c (solib_find_1): Return unique_xmalloc_ptr.
5974         (exec_file_find, solib_find): Likewise.
5975         (solib_bfd_fopen): Do not take ownership of "pathname".
5976         (solib_bfd_open): Use unique_xmalloc_ptr.
5977         * solib-darwin.c (darwin_bfd_open): Use unique_xmalloc_ptr.
5978         * solib-aix.c (solib_aix_bfd_open): Use unique_xmalloc_ptr.
5979         * infrun.c (follow_exec): Use unique_xmalloc_ptr.
5980         * exec.c (exec_file_locate_attach): Use unique_xmalloc_ptr.
5981
5982 2018-02-14  Joel Brobecker  <brobecker@adacore.com>
5983
5984         * ada-lang.c (name_match_type_from_name): Remove reference to
5985         ada_name_for_lookup in function's documentation.
5986         * ada-lang.h (ada_name_for_lookup): Delete declaration.
5987
5988 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
5989
5990         * defs.h (enum openp_flags): New enum.
5991         (OPF_TRY_CWD_FIRST, OPF_SEARCH_IN_PATH, OPF_RETURN_REALPATH):
5992         Move to enum openp_flags.
5993         (openp_flags): New enum flags.
5994         (openp): Change parameter type to openp_flags.
5995         * source.c (openp): Change parameter type to openp_flags.
5996         * cli/cli-cmds.c (find_and_open_script): Use openp_flags.
5997         * dwarf2read.c (try_open_dwop_file): Use openp_flags.
5998
5999 2018-02-13  Simon Marchi  <simon.marchi@polymtl.ca>
6000
6001         * maint.c (_initialize_maint_cmds): Fix prefix of maint set/show
6002         per-command.
6003
6004 2018-02-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6005
6006         * dwarf2read.c (dwarf2_release_queue): Delete function, move body
6007         into...
6008         (class dwarf2_queue_guard): ...the destructor of this new class.
6009         (dw2_do_instantiate_symtab): Create instance of the new class
6010         dwarf2_queue_guard, remove cleanup.
6011
6012 2018-02-09  Tom Tromey  <tom@tromey.com>
6013
6014         * source.c (find_source_lines): Don't reference past the end of
6015         the vector.
6016
6017 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6018
6019         * remote.c (remote_btrace_maybe_reopen): Change error message.
6020         * btrace.c (btrace_enable): Likewise.
6021         (parse_xml_btrace): Likewise.
6022         (parse_xml_btrace_conf): Likewise.
6023
6024 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6025
6026         * nat/linux-btrace.c (diagnose_perf_event_open_fail): New.
6027         (linux_enable_pt, linux_enable_bts): Call
6028         diagnose_perf_event_open_fail.
6029
6030 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6031
6032         * nat/linux-btrace.c (perf_event_pt_event_type): Improve error message.
6033         Remove parameter and change return type.  Update callers.  Move it.
6034         (linux_enable_bts, linux_enable_pt): Improve error message.
6035         (linux_enable_pt): Remove zero buffer size check.
6036         (linux_enable_btrace): Improve error messages.  Remove NULL return
6037         check.
6038
6039 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6040
6041         * btrace.c (btrace_enable): Remove target_supports_btrace call.
6042         * nat/linux-btrace.c (perf_event_pt_event_type): Move.
6043         (kernel_supports_bts, kernel_supports_pt, linux_supports_bts)
6044         (linux_supports_pt, linux_supports_btrace): Remove.
6045         (linux_enable_bts): Call cpu_supports_bts.
6046         * nat/linux-btrace.h (linux_supports_btrace): Remove.
6047         * remote.c (remote_supports_btrace): Remove.
6048         (init_remote_ops): Remove remote_supports_btrace.
6049         * target-delegates.c: Regenerated.
6050         * target.c (target_supports_btrace): Remove.
6051         * target.h (target_ops) <to_supports_btrace>: Remove
6052         (target_supports_btrace): Remove.
6053         * x86-linux-nat.c (x86_linux_create_target): Remove
6054         linux_supports_btrace.
6055
6056 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6057
6058         * nat/linux-btrace.c (linux_enable_btrace): Throw exception if enabling
6059         btrace failed.
6060         * x86-linux-nat.c (x86_linux_enable_btrace): Catch btrace enabling
6061         exception and use message in own exception.
6062
6063 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6064
6065         * nat/linux-btrace.c: Include scoped_fd.h and scoped_mmap.h.
6066         (perf_event_pt_event_type): Use gdb_file_up.
6067         (linux_enable_bts, linux_enable_pt): Use gdb::unique_xmalloc_ptr,
6068         scoped_fd, and scoped_mmap.
6069
6070 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6071
6072         * common/scoped_mmap.h: New.
6073         * unittests/scoped_mmap-selftest.c: New.
6074         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6075         unittests/scoped_mmap-selftest.c.
6076
6077 2018-02-09  Markus Metzger  <markus.t.metzger@intel.com>
6078
6079         * common/scoped_fd.h: New.
6080         * unittests/scoped_fd-selftest.c: New.
6081         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6082         unittests/scoped_fd-selftest.c.
6083
6084 2018-02-09  Tom Tromey  <tom@tromey.com>
6085
6086         * auto-load.c (auto_load_section_scripts): Use
6087         gdb::unique_xmalloc_ptr.
6088
6089 2018-02-09  Tom Tromey  <tom@tromey.com>
6090
6091         * auto-load.c (execute_script_contents): Use std::string.
6092
6093 2018-02-09  Joel Brobecker  <brobecker@adacore.com>
6094
6095         * NEWS <Changes in GDB 8.1>: Clarify that "rbreak" is a new
6096         Python function, rather than a new command.
6097
6098 2018-02-08  Tom Tromey  <tom@tromey.com>
6099
6100         * solib.c (solib_find_1): Use std::string.
6101         (solib_bfd_fopen): Use unique_xmalloc_ptr.
6102
6103 2018-02-08  Tom Tromey  <tom@tromey.com>
6104
6105         * build-id.c (build_id_to_debug_bfd): Use unique_xmalloc_ptr.
6106
6107 2018-02-08  Tom Tromey  <tom@tromey.com>
6108
6109         * source.c (find_source_lines): Use gdb::def_vector.
6110
6111 2018-02-08  Tom Tromey  <tom@tromey.com>
6112
6113         * macrocmd.c (struct temporary_macro_definition): New.
6114         (macro_define_command): Use temporary_macro_definition.  Remove
6115         cleanups.
6116         (free_macro_definition_ptr): Remove.
6117
6118 2018-02-08  Tom Tromey  <tom@tromey.com>
6119
6120         * macroexp.c (maybe_expand): Use std::string.
6121
6122 2018-02-08  Tom Tromey  <tom@tromey.com>
6123
6124         * macroexp.c (struct macro_buffer): Add initializers for some
6125         members.
6126         (init_buffer, init_shared_buffer, free_buffer)
6127         (free_buffer_return_text): Remove.
6128         (macro_buffer): New constructors.
6129         (~macro_buffer): New destructor.
6130         (macro_buffer::set_shared): New method.
6131         (macro_buffer::resize_buffer, macro_buffer::appendc)
6132         (macro_buffer::appendmem): Now methods, not free functions.
6133         (set_token, append_tokens_without_splicing, stringify)
6134         (macro_stringify): Update.
6135         (gather_arguments): Change return type.  Remove argc_p argument,
6136         add args_ptr argument.  Use std::vector.
6137         (substitute_args): Remove argc argument.  Accept std::vector.
6138         (expand): Update.  Use std::vector.
6139         (scan, macro_expand, macro_expand_next): Update.
6140
6141 2018-02-08  Tom Tromey  <tom@tromey.com>
6142
6143         * symtab.c (default_collect_symbol_completion_matches_break_on):
6144         Use unique_xmalloc_ptr.
6145         * macroscope.h: (sal_macro_scope, user_macro_scope)
6146         (default_macro_scope): Return unique_xmalloc_ptr.
6147         * macroscope.c (sal_macro_scope, user_macro_scope)
6148         (default_macro_scope): Return unique_xmalloc_ptr.
6149         * macroexp.h (macro_expand, macro_expand_once): Return
6150         unique_xmalloc_ptr.
6151         * macroexp.c (macro_expand, macro_expand_once): Return
6152         unique_xmalloc_ptr.
6153         * macrocmd.c (macro_expand_command, macro_expand_once_command)
6154         (info_macro_command, info_macros_command): Use
6155         unique_xmalloc_ptr.
6156         * compile/compile-c-support.c (write_macro_definitions): Use
6157         unique_xmalloc_ptr.
6158         * c-exp.y (c_parse): Use unique_xmalloc_ptr.
6159
6160 2018-02-07  Simon Marchi  <simon.marchi@ericsson.com>
6161
6162         * value.c (value_static_field): Assign field type instead of
6163         containing type when returning an optimized out value.
6164
6165 2018-02-06  Yao Qi  <yao.qi@linaro.org>
6166
6167         * ft32-tdep.c (ft32_read_pc): Remove.
6168         (ft32_write_pc): Remove.
6169         (ft32_gdbarch_init): Update.
6170         * m32r-tdep.c (m32r_read_pc): Remove.
6171         (m32r_gdbarch_init): Update.
6172         * mep-tdep.c (mep_read_pc): Remove.
6173         (mep_gdbarch_init): Update.
6174         * microblaze-tdep.c (microblaze_write_pc): Remove.
6175         (microblaze_gdbarch_init): Update.
6176         * mn10300-tdep.c (mn10300_read_pc): Remove.
6177         (mn10300_write_pc): Remove.
6178         (mn10300_gdbarch_init): Update.
6179         * moxie-tdep.c (moxie_read_pc): Remove.
6180         (moxie_write_pc): Remove.
6181         (moxie_gdbarch_init): Update.
6182
6183 2018-02-06  Yao Qi  <yao.qi@linaro.org>
6184
6185         * expprint.c (print_subexp_standard): Handle
6186         OP_F77_UNDETERMINED_ARGLIST.
6187         (dump_subexp_body_standard): Likewise.
6188
6189 2018-02-05  Alan Hayward  <alan.hayward@arm.com>
6190
6191         * target-descriptions.c (tdesc_element_visitor) Add empty
6192         implementations.
6193         (tdesc_type): Move make_gdb_type from here.
6194         (tdesc_type_builtin): Likewise.
6195         (tdesc_type_vector): Likewise.
6196         (tdesc_type_with_fields): Move make_gdb_type_ functions from here.
6197         (make_gdb_type_struct): Move from tdesc_type_with_fields.
6198         (make_gdb_type_union): Likewise.
6199         (make_gdb_type_flags): Likewise.
6200         (make_gdb_type_enum): Likewise.
6201         (make_gdb_type): New function.
6202         (tdesc_register_type): Use static make_gdb_type.
6203
6204 2018-02-05  Ruslan Kabatsayev <b7.10110111@gmail.com>
6205
6206         * infcmd.c (default_print_one_register_info): Align natural-format
6207         column values consistently one under another.
6208         (pad_to_column): New function.
6209
6210 2018-02-05  Joel Brobecker  <brobecker@adacore.com>
6211
6212         * dwarf2read.c (dwarf2_physname): Move commment.
6213
6214 2018-02-01  Leszek Swirski  <leszeks@google.com>
6215
6216         * varobj.c (varobj_formatted_print_options): Allow recursive
6217         pretty printing if pretty printing is enabled.
6218
6219 2018-02-01  Leszek Swirski  <leszeks@google.com>
6220
6221         * c-exp.y (lex_one_token, classify_name, yylex): Don't classify
6222         names after a structop as a filename.
6223
6224 2018-02-01  Yao Qi  <yao.qi@linaro.org>
6225
6226         * arm-tdep.c (arm_record_data_proc_misc_ld_str): Rewrite it.
6227         (arm_record_coproc_data_proc): Likewise.
6228
6229 2018-02-01  Yao Qi  <yao.qi@linaro.org>
6230
6231         * arm-tdep.c (arm_record_extension_space): Change ret to signed.
6232
6233 2018-01-31  Nikola Prica  <nikola.prica@rt-rk.com>
6234
6235         * rs6000-tdep.c (skip_prologue): Remove shifting for lr_reg and
6236         assign shifted lr_reg to fdata->lr_register when lr_reg is set.
6237
6238 2018-01-31  Pedro Alves  <palves@redhat.com>
6239
6240         * darwin-nat.c (darwin_interrupt): Remove ptid_t parameter.
6241         * inflow.c (child_terminal_save_inferior): Wrap reference to
6242         tcgetpgrp in HAVE_TERMIOS_H.
6243         (child_interrupt, child_pass_ctrlc): Wrap references to signal in
6244         _WIN32.
6245         * remote-sim.c (gdbsim_interrupt): Remove ptid_t parameter and
6246         always iterate over all inferiors.
6247         (gdbsim_cntrl_c): Adjust.
6248         * windows-nat.c (windows_interrupt): Remove 'ptid_t' parameter.
6249
6250 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
6251
6252         * gdbtypes.c (lookup_array_range_type): Make sure the array's
6253         index type is objfile-owned if the element type is as well.
6254
6255 2018-01-31  Joel Brobecker  <brobecker@adacore.com>
6256
6257         GDB 8.1 released.
6258
6259 2018-01-30  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6260
6261         * s390-linux-tdep.c: Remove includes "features/s390-linux32.c" and
6262         "features/s390x-linux64.c".
6263         (_initialize_s390_linux_tdep): Remove initialization of tdescs
6264         s390_linux32 and s390x_linux64.
6265         (s390_linux_init_abi_31, s390_linux_init_abi_64): Don't set
6266         default tdesc.
6267         * s390-tdep.c: Include "features/s390-linux32.c" and
6268         "features/s390x-linux64.c".
6269         (s390_tdesc_valid): Add check for tdesc_has_registers.
6270         (s390_gdbarch_init): Make sure there is always a valid tdesc.
6271         (_initialize_s390_tdep): Initialize tdesc_s390_linux32 and
6272         tdesc_s390x_linux64.
6273         * s390-linux-tdep.h: Move export of tdesc_s390_linux32 and
6274         tdesc_s390x_linux64 to...
6275         * s390-tdep.h: ...here.
6276
6277 2018-01-30  Pedro Alves  <palves@redhat.com>
6278
6279         PR gdb/13211
6280         * config.in, configure: Regenerate.
6281         * configure.ac: Check for getpgid.
6282         * go32-nat.c (go32_pass_ctrlc): New.
6283         (go32_target): Install it.
6284         * inf-child.c (inf_child_target): Install
6285         child_terminal_save_inferior, child_pass_ctrlc and
6286         child_interrupt.
6287         * inf-ptrace.c (inf_ptrace_interrupt): Delete.
6288         (inf_ptrace_target): No longer install it.
6289         * infcmd.c (interrupt_target_1): Adjust.
6290         * inferior.h (child_terminal_save_inferior, child_pass_ctrlc)
6291         (child_interrupt): Declare.
6292         (inferior::terminal_state): New.
6293         * inflow.c (struct terminal_info): Update comments.
6294         (inferior_process_group): Delete.
6295         (terminal_is_ours): Delete.
6296         (gdb_tty_state): New.
6297         (child_terminal_init): Adjust.
6298         (is_gdb_terminal, sharing_input_terminal_1)
6299         (sharing_input_terminal): New functions.
6300         (child_terminal_inferior): Adjust.  Use sharing_input_terminal.
6301         Set the process's actual process group in the foreground if
6302         possible.  Handle is_ours_for_output/is_ours distinction.  Don't
6303         mark terminal as the inferior's if not sharing GDB's terminal.
6304         Don't check attach_flag.
6305         (child_terminal_ours_for_output, child_terminal_ours): Adjust to
6306         pass down a target_terminal_state.
6307         (child_terminal_save_inferior): New, factored out from ...
6308         (child_terminal_ours_1): ... this.  Handle
6309         target_terminal_state::is_ours_for_output.
6310         (child_interrupt, child_pass_ctrlc): New.
6311         (inflow_inferior_exit): Clear the inferior's terminal_state.
6312         (copy_terminal_info): Copy the inferior's terminal state.
6313         (_initialize_inflow): Remove reference to terminal_is_ours.
6314         * inflow.h (inferior_process_group): Delete.
6315         * nto-procfs.c (nto_handle_sigint, procfs_interrupt): Adjust.
6316         * procfs.c (procfs_target): Don't install procfs_interrupt.
6317         (procfs_interrupt): Delete.
6318         * remote.c (remote_serial_quit_handler): Adjust.
6319         (remote_interrupt): Remove ptid parameter.  Adjust.
6320         * target-delegates.c: Regenerate.
6321         * target.c: Include "terminal.h".
6322         (target_terminal::terminal_state): Rename to ...
6323         (target_terminal::m_terminal_state): ... this.
6324         (target_terminal::init): Adjust.
6325         (target_terminal::inferior): Adjust to per-inferior
6326         terminal_state.
6327         (target_terminal::restore_inferior, target_terminal_is_ours_kind): New.
6328         (target_terminal::ours, target_terminal::ours_for_output): Use
6329         target_terminal_is_ours_kind.
6330         (target_interrupt): Remove ptid parameter.  Adjust.
6331         (default_target_pass_ctrlc): Adjust.
6332         * target.h (target_ops::to_terminal_save_inferior): New field.
6333         (target_ops::to_interrupt): Remove ptid_t parameter.
6334         (target_interrupt): Remove ptid_t parameter.  Update comment.
6335         (target_pass_ctrlc): Update comment.
6336         * target/target.h (target_terminal_state): New scoped enum,
6337         factored out of ...
6338         (target_terminal::terminal_state): ... here.
6339         (target_terminal::inferior): Update comments.
6340         (target_terminal::restore_inferior): New.
6341         (target_terminal::is_inferior, target_terminal::is_ours)
6342         (target_terminal::is_ours_for_output): Adjust.
6343         (target_terminal::scoped_restore_terminal_state): Adjust to
6344         rename, and call restore_inferior() instead of inferior().
6345         (target_terminal::scoped_restore_terminal_state::m_state): Change
6346         type.
6347         (target_terminal::terminal_state): Rename to ...
6348         (target_terminal::m_terminal_state): ... this and change type.
6349
6350 2018-01-30  Pedro Alves  <palves@redhat.com>
6351
6352         * linux-nat.c (wait_for_signal): New function.
6353         (wait_lwp, linux_nat_wait_1): Use it instead of calling sigsuspend
6354         directly.
6355         (async_terminal_is_ours)
6356         (linux_nat_terminal_inferior, linux_nat_terminal_ours): Delete.
6357         (linux_nat_add_target): Don't override
6358         to_terminal_inferior/to_terminal_ours.
6359
6360 2018-01-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6361
6362         * remote.c (remote_follow_fork): Don't call "detach_inferior".
6363
6364 2018-01-28  Simon Marchi  <simon.marchi@ericsson.com>
6365
6366         * dwarf2read.c (free_dwo_files): Add forward-declaration.
6367         (dwarf2_per_objfile::~dwarf2_per_objfile): Move content from
6368         dwarf2_per_objfile_free here.
6369         (dwarf2_per_objfile_free): Remove.
6370         (_initialize_dwarf2_read): Don't register
6371         dwarf2_per_objfile_free as a registry cleanup.
6372
6373 2018-01-27  Eli Zaretskii  <eliz@gnu.org>
6374
6375         Avoid compilation errors in MinGW native builds
6376
6377         The error is triggered by including python-internal.h, and the
6378         error message is:
6379
6380              In file included from d:\usr\lib\gcc\mingw32\6.3.0\include\c++\math.h:36:0,
6381                       from build-gnulib/import/math.h:27,
6382                       from d:/usr/Python26/include/pyport.h:235,
6383                       from d:/usr/Python26/include/Python.h:58,
6384                       from python/python-internal.h:94,
6385                       from python/py-arch.c:24:
6386              d:\usr\lib\gcc\mingw32\6.3.0\include\c++\cmath:1157:11: error: '::hypot' has not been declared
6387         using ::hypot;
6388                 ^~~~~
6389
6390         This happens because Python headers define 'hypot' to expand t
6391         '_hypot' in the Windows builds.
6392         * python/python-internal.h (_hypot) [__MINGW32__]: Define back to
6393         'hypoth'.  This avoids a compilation error.
6394
6395 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
6396
6397         * MAINTAINERS (Write After Approval): Fix ordering.
6398
6399 2018-01-26  Alan Hayward  <alan.hayward@arm.com>
6400
6401         * MAINTAINERS (Write After Approval): Add Alan Hayward.
6402
6403 2018-01-26  Alan Modra  <amodra@gmail.com>
6404
6405         * ppc-linux-tdep.c (powerpc32_plt_stub): Make const.
6406         (powerpc32_plt_stub_so_1): Rename from powerpc32_plt_stub_so.
6407         Remove nop.  Make const.  Comment.
6408         (powerpc32_plt_stub_so_2): New.
6409         (POWERPC32_PLT_CHECK_LEN): Rename from POWERPC32_PLT_STUB_LEN.
6410         Correct count.  Update uses.
6411         (ppc_skip_trampoline_code): Match powerpc32_plt_stub_so_2 too.
6412         Move common code reading PLT entry word.  Correct
6413         powerpc32_plt_stub PLT address calculation.
6414         * ppc64-tdep.c (ppc64_standard_linkage1): Make const.
6415         (ppc64_standard_linkage2, ppc64_standard_linkage3): Likewise.
6416         (ppc64_standard_linkage4, ppc64_standard_linkage5): Likewise.
6417         (ppc64_standard_linkage6, ppc64_standard_linkage7): Likewise.
6418         (ppc64_standard_linkage8): Likewise.
6419         * rs6000-tdep.c (ppc_insns_match_pattern): Make pattern const.
6420         Correct insns description.
6421         * ppc-tdep.h (ppc_insns_match_pattern): Update prototype.
6422
6423 2018-01-24  Pedro Alves  <palves@redhat.com>
6424
6425         GCC PR libstdc++/83906
6426         * gdbtypes.c (operator==(const dynamic_prop &,
6427         const dynamic_prop &)): New.
6428         (operator==(const range_bounds &, const range_bounds &)): New.
6429         (check_types_equal): Use them instead of memcmp.
6430         * gdbtypes.h (operator==(const dynamic_prop &,
6431         const dynamic_prop &)): Declare.
6432         (operator!=(const dynamic_prop &, const dynamic_prop &)): Declare.
6433         (operator==(const range_bounds &, const range_bounds &)): Declare.
6434         (operator!=(const range_bounds &, const range_bounds &)): Declare.
6435
6436 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6437
6438         * s390-linux-tdep.c (s390_record_address_mask)
6439         (s390_record_calc_disp_common, s390_record_calc_disp)
6440         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
6441         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
6442         (s390_process_record): Move to s390-tdep.c.
6443         (s390_linux_init_abi_any): Adjust.
6444         * s390-tdep.c (s390_record_address_mask)
6445         (s390_record_calc_disp_common, s390_record_calc_disp)
6446         (s390_record_calc_disp_vsce, s390_record_calc_rl, s390_popcnt)
6447         (s390_record_gpr_g, s390_record_gpr_h, s390_record_vr)
6448         (s390_process_record): Moved from s390-linux-tdep.c
6449         (s390_gdbarch_init): Adjust.
6450
6451 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6452
6453         * s390-linux-nat.c (s390-tdep.h): New include.
6454         * Makefile.in (ALL_TARGET_OBS): Add s390-tdep.o.
6455         (HFILES_NO_SRCDIR): Add s390-tdep.h.
6456         (ALLDEPFILES): Add s390-tdep.c.
6457         * configure.tgt (s390*-*-linux*): Add s390-tdep.o.
6458         * s390-linux-tdep.h (HWCAP_S390_*, S390_*_REGNUM): Move to...
6459         * s390-tdep.h: ...this.  New file.
6460         * s390-linux-tdep.c (s390-tdep.h): New include.
6461         (_initialize_s390_tdep): Rename to...
6462         (_initialize_s390_linux_tdep): ...this and adjust.
6463         (s390_abi_kind, s390_vector_abi_kind, gdbarch_tdep)
6464         (enum named opcodes, S390_NUM_GPRS, S390_NUM_FPRS): Move to
6465         s390-tdep.h.
6466         (s390_break_insn, s390_breakpoint, s390_readinstruction, is_ri)
6467         (is_ril, is_rr, is_rre, is_rs, is_rsy, is_rx, is_rxy)
6468         (s390_is_partial_instruction, s390_software_single_step)
6469         (is_non_branch_ril, s390_displaced_step_copy_insn)
6470         (s390_displaced_step_fixup, s390_displaced_step_hw_singlestep)
6471         (s390_prologue_data, s390_addr, s390_store, s390_load)
6472         (s390_check_for_saved, s390_analyze_prologue, s390_skip_prologue)
6473         (s390_register_call_saved, s390_guess_tracepoint_registers)
6474         (s390_register_name, s390_dwarf_regmap, s390_dwarf_reg_to_regnum)
6475         (regnum_is_gpr_full, regnum_is_vxr_full, s390_value_from_register)
6476         (s390_pseudo_register_name, s390_pseudo_register_type)
6477         (s390_pseudo_register_read, s390_pseudo_register_write)
6478         (s390_pseudo_register_reggroup_p, s390_ax_pseudo_register_collect)
6479         (s390_ax_pseudo_register_push_stack, s390_gen_return_address)
6480         (s390_addr_bits_remove, s390_address_class_type_flags)
6481         (s390_address_class_type_flags_to_name)
6482         (s390_address_class_name_to_type_flags, s390_effective_inner_type)
6483         (s390_function_arg_float, s390_function_arg_vector)
6484         (is_power_of_two, s390_function_arg_integer, s390_arg_state)
6485         (s390_handle_arg, s390_push_dummy_call, s390_dummy_id)
6486         (s390_frame_align, s390_register_return_value, s390_return_value)
6487         (s390_stack_frame_destroyed_p, s390_unwind_pc, s390_unwind_sp)
6488         (s390_unwind_pseudo_register, s390_adjust_frame_regnum)
6489         (s390_dwarf2_prev_register, s390_dwarf2_frame_init_reg)
6490         (s390_trad_frame_prev_register, s390_unwind_cache)
6491         (s390_prologue_frame_unwind_cache)
6492         (s390_backchain_frame_unwind_cache, s390_frame_unwind_cache)
6493         (s390_frame_this_id, s390_frame_prev_register, s390_frame_unwind)
6494         (s390_stub_unwind_cache, s390_stub_frame_unwind_cache)
6495         (s390_stub_frame_this_id, s390_stub_frame_prev_register)
6496         (s390_stub_frame_sniffer, s390_stub_frame_unwind)
6497         (s390_frame_base_address, s390_local_base_address)
6498         (s390_frame_base, s390_gcc_target_options)
6499         (s390_gnu_triplet_regexp, s390_stap_is_single_operand)
6500         (s390_validate_reg_range, s390_tdesc_valid)
6501         (s390_gdbarch_tdep_alloc, s390_gdbarch_init): Move to...
6502         * s390-tdep.c: ...this.  New file.
6503
6504 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6505
6506         * s390-linux-tdep.c (gdbarch_tdep.s390_syscall_record): New hook.
6507         (s390_process_record, s390_gdbarch_tdep_alloc)
6508         (s390_linux_init_abi_any): Use/set new hook.
6509
6510 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6511
6512         * s390-linux-tdep.c (osabi.h): New include.
6513         (s390_linux_init_abi_31, s390_linux_init_abi_64)
6514         (s390_linux_init_abi_any): New functions.
6515         (s390_gdbarch_init, _initialize_s390_tdep): Adjust.
6516
6517 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6518
6519         * s390-linux-tdep.c (s390_gdbarch_init): Use gdb_assert for
6520         tdesc_has_registers check
6521
6522 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6523
6524         * s390-linux-tdep.c (s390_tdesc_valid): New function.
6525         (s390_validate_reg_range): New macro.
6526         (s390_gdbarch_init): Adjust.
6527
6528 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6529
6530         * s390-linux-tdep.c (gdbarch_tdep) <tdesc>: New field.
6531         (s390_gdbarch_tdep_alloc): Adjust.
6532         (s390_gdbarch_init): Adjust.
6533
6534 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6535
6536         * s390-linux-tdep.c (gdbarch_tdep) <have_linux_v1, have_linux_v2>
6537         <have_tdb>: Change type to bool.
6538         (s390_gdbarch_tdep_alloc): Adjust.
6539         (s390_gdbarch_init): Adjust.
6540
6541 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6542
6543         * s390-linux-tdep (s390_abi_kind) <ABI_NONE>: New default field.
6544         (gdbarch_tdep) <have_upper, have_vx>: New fields.
6545         (s390_gdbarch_tdep_alloc): New function.
6546         (s390_gdbarch_init): Allocate tdep at start and use its fields
6547         instead of separate variables.
6548
6549 2018-01-23  Philipp Rudo  <prudo@linux.vnet.ibm.com>
6550
6551         * s390-linux-tdep.c (s390_gdbarch_init): Remove duplicate checks
6552         when looking for cached gdbarch and add comment for remaining.
6553
6554 2018-01-22  Pedro Alves  <palves@redhat.com>
6555             Sergio Durigan Junior  <sergiodj@redhat.com>
6556
6557         * typeprint.c (whatis_exp): Initialize "val" in the "whatis type"
6558         case.
6559
6560 2018-01-22  Maciej W. Rozycki  <macro@mips.com>
6561
6562         * MAINTAINERS: Update my company e-mail address.
6563
6564 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6565
6566         * regcache.c (cooked_write_test): New function.
6567         (_initialize_regcache): Register the test.
6568
6569 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6570
6571         * ia64-tdep.c (ia64_pseudo_register_read): Call
6572         regcache->cooked_read instead of regcache_cooked_read_unsigned.
6573         * m32c-tdep.c (m32c_cat_read): Likewise.
6574         (m32c_r3r2r1r0_read): Likewise.
6575         * m68hc11-tdep.c (m68hc11_pseudo_register_read): Likewise.
6576         * xtensa-tdep.c (xtensa_register_read_masked): Likewise.
6577
6578 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6579
6580         * aarch64-tdep.c (aarch64_pseudo_read_value): Call regcache
6581         method raw_read instead of regcache_raw_read.
6582         * amd64-tdep.c (amd64_pseudo_register_read_value): Likewise.
6583         * arm-tdep.c (arm_neon_quad_read): Likewise.
6584         * avr-tdep.c (avr_pseudo_register_read): Likewise.
6585         * bfin-tdep.c (bfin_pseudo_register_read): Likewise.
6586         * frv-tdep.c (frv_pseudo_register_read): Likewise.
6587         * h8300-tdep.c (h8300_pseudo_register_read): Likewise.
6588         * i386-tdep.c (i386_mmx_regnum_to_fp_regnum): Likewise.
6589         (i386_pseudo_register_read_into_value): Likewise.
6590         * mep-tdep.c (mep_pseudo_cr32_read): Likewise.
6591         * msp430-tdep.c (msp430_pseudo_register_read): Likewise.
6592         * nds32-tdep.c (nds32_pseudo_register_read): Likewise.
6593         * rl78-tdep.c (rl78_pseudo_register_read): Likewise.
6594         * s390-linux-tdep.c (s390_pseudo_register_read): Likewise.
6595         * sparc-tdep.c (sparc32_pseudo_register_read):  Likewise.
6596         * sparc64-tdep.c (sparc64_pseudo_register_read): Likewise.
6597         * spu-tdep.c (spu_pseudo_register_read_spu):  Likewise.
6598         * xtensa-tdep.c (xtensa_pseudo_register_read): Likewise.
6599
6600 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6601
6602         * Makefile.in (ALL_TARGET_OBS): Remove mt-tdep.o.
6603         * configure.tgt: Remove target mt.
6604         * mt-tdep.c: Remove.
6605         * regcache.c (cooked_read_test): Remove the check for mt.
6606
6607 2018-01-22  Yao Qi  <yao.qi@linaro.org>
6608
6609         * jit.c (jit_frame_prev_register): Call regcache::cooked_read
6610         instead of gdbarch_pseudo_register_read_value.
6611
6612 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
6613
6614         * dwarf2read.c (need_gnat_info): Return nonzero if the cu's
6615         language is Ada.
6616
6617 2018-01-22  Joel Brobecker  <brobecker@adacore.com>
6618
6619         * linespec.c (create_sals_line_offset): Remove code that preserved
6620         the symtab_and_line's line number.
6621
6622 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6623
6624         * varobj.c (varobj_create): Don't set valid_block when creating a
6625         floating varobj.
6626
6627 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6628
6629         * varobj.c (varobj_create): Remove out of date comment.
6630
6631 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6632
6633         PR mi/20395
6634         * ada-exp.y (write_var_from_sym): Pass extra parameter when
6635         updating innermost block.
6636         * parse.c (innermost_block_tracker::update): Take extra type
6637         parameter, and check types match before updating innermost block.
6638         (write_dollar_variable): Update innermost block for registers.
6639         * parser-defs.h (enum innermost_block_tracker_type): New enum.
6640         (innermost_block_tracker::innermost_block_tracker): Initialise
6641         m_types member.
6642         (innermost_block_tracker::reset): Take type parameter.
6643         (innermost_block_tracker::update): Take type parameter, and pass
6644         type through as needed.
6645         (innermost_block_tracker::m_types): New member.
6646         * varobj.c (varobj_create): Pass type when reseting innermost
6647         block.
6648
6649 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6650
6651         * ada-exp.y (write_var_from_sym): Switch to innermost_block API.
6652         * ada-lang.c (resolve_subexp): Likewise.
6653         * breakpoint.c (set_breakpoint_condition) Likewise.
6654         (watch_command_1) Likewise.
6655         * c-exp.y (variable): Likewise.
6656         * d-exp.y (PrimaryExpression): Likewise.
6657         * f-exp.y (variable): Likewise.
6658         * go-exp.y (variable): Likewise.
6659         * m2-exp.y (variable): Likewise.
6660         * objfiles.c (objfile::~objfile): Likewise.
6661         * p-exp.y (variable): Likewise.
6662         * parse.c (innermost_block): Change type.
6663         * parser-defs.h (class innermost_block_tracker): New.
6664         (innermost_block): Change to innermost_block_tracker.
6665         * printcmd.c (display_command): Switch to innermost_block API.
6666         (do_one_display): Likewise.
6667         * rust-exp.y (do_one_display): Likewise.
6668         * symfile.c (clear_symtab_users): Likewise.
6669         * varobj.c (varobj_create): Switch to innermost_block API, replace
6670         use of innermost_block with block stored on varobj object.
6671
6672 2018-01-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6673
6674         * expression.h (innermost_block): Remove declaration.
6675         * varobj.c: Add 'parser-defs.h' include.
6676
6677 2018-01-19  Tom Tromey  <tom@tromey.com>
6678
6679         * rust-lang.c (rust_lookup_symbol_nonlocal): Look up qualified
6680         symbols in the static and global blocks.
6681
6682 2018-01-19  James Clarke  <jrtc27@jrtc27.com>
6683
6684         * nat/linux-ptrace.c: Remove unnecessary reinclusion of
6685         gdb_ptrace.h, and move including gdb_wait.h ...
6686         * nat/linux-ptrace.h: ... to here.
6687
6688 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
6689
6690         * inf-ptrace.c (inf_ptrace_detach): Adjust call to
6691         inf_ptrace_detach_success.
6692         (inf_ptrace_detach_success): Add inferior parameter, use it
6693         instead of inferior_ptid, pass it to detach_inferior.
6694         * inf-ptrace.h (inf_ptrace_detach_success): Add inferior
6695         parameter.
6696         * inferior.c (detach_inferior): Add overload that takes an
6697         inferior object.
6698         * inferior.h (detach_inferior): Likewise.
6699         * linux-nat.c (linux_nat_detach): Use the inf parameter, don't
6700         use inferior_ptid, adjust call to inf_ptrace_detach_success.
6701         * linux-thread-db.c (thread_db_detach): Use inf parameter.
6702
6703 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
6704
6705         * target.h (struct target_ops) <to_detach>: Add inferior
6706         parameter.
6707         (target_detach): Likewise.
6708         * target.c (dispose_inferior): Pass inferior down.
6709         (target_detach): Pass inferior down.  Assert that it is equal to
6710         the current inferior.
6711         * aix-thread.c (aix_thread_detach): Pass inferior down.
6712         * corefile.c (core_file_command): Pass current_inferior() down.
6713         * corelow.c (core_detach): Add inferior parameter.
6714         * darwin-nat.c (darwin_detach): Likewise.
6715         * gnu-nat.c (gnu_detach): Likewise.
6716         * inf-ptrace.c (inf_ptrace_detach): Likewise.
6717         * infcmd.c (detach_command): Pass current_inferior() down to
6718         target_detach.
6719         * infrun.c (follow_fork_inferior): Pass parent_inf to
6720         target_detach.
6721         (handle_vfork_child_exec_or_exit): Pass inf->vfork_parent to
6722         target_detach.
6723         * linux-nat.c (linux_nat_detach): Add inferior parameter.
6724         * linux-thread-db.c (thread_db_detach): Likewise.
6725         * nto-procfs.c (procfs_detach): Likewise.
6726         * procfs.c (procfs_detach): Likewise.
6727         * record.c (record_detach): Likewise.
6728         * record.h (struct inferior): Forward-declare.
6729         (record_detach): Add inferior parameter.
6730         * remote-sim.c (gdbsim_detach): Likewise.
6731         * remote.c (remote_detach_1): Likewise.
6732         (remote_detach): Likewise.
6733         (extended_remote_detach): Likewise.
6734         * sol-thread.c (sol_thread_detach): Likewise.
6735         * target-debug.h (target_debug_print_inferior_p): New macro.
6736         * target-delegates.c: Re-generate.
6737         * top.c (kill_or_detach): Pass inferior down to target_detach.
6738         * windows-nat.c (windows_detach): Add inferior parameter.
6739
6740 2018-01-19  Simon Marchi  <simon.marchi@ericsson.com>
6741
6742         * target.h (struct target_ops) <to_detach>: Remove args
6743         parameter.
6744         (target_detach): Likewise.
6745         * target.c (dispose_inferior): Adjust.
6746         (target_detach): Remove args parameter, adjust.
6747         * aix-thread.c (aix_thread_detach): Adjust.
6748         * corefile.c (core_file_command): Adjust.
6749         * corelow.c (core_detach): Adjust.
6750         * darwin-nat.c (darwin_detach): Adjust.
6751         * gnu-nat.c (gnu_detach): Adjust.
6752         * inf-ptrace.c (inf_ptrace_detach): Adjust.
6753         * infcmd.c (detach_command): Adjust
6754         * infrun.c (follow_fork_inferior): Adjust.
6755         (handle_vfork_child_exec_or_exit): Adjust.
6756         * linux-fork.c (linux_fork_detach): Remove args parameter.
6757         * linux-fork.h (linux_fork_detach): Likewise.
6758         * linux-nat.c (linux_nat_detach): Likewise, and adjust.
6759         * linux-thread-db.c (thread_db_detach): Likewise.
6760         * nto-procfs.c (procfs_detach): Likewise.
6761         * procfs.c (procfs_detach): Likewise.
6762         (do_detach): Remove signo parameter.
6763         * record.c (record_detach): Remove args parameter.
6764         * record.h (record_detach): Likewise.
6765         * remote-sim.c (gdbsim_detach): Likewise.
6766         * remote.c (remote_detach_1): Likewise.
6767         (remote_detach): Likewise.
6768         (extended_remote_detach): Likewise.
6769         * sol-thread.c (sol_thread_detach): Likewise.
6770         * target-delegates.c: Re-generate.
6771         * top.c (struct qt_args) <args>: Remove field.
6772         (kill_or_detach): Don't pass args.
6773         (quit_force): Don't set args.
6774         * windows-nat.c (windows_detach): Remove args parameter.
6775
6776 2018-01-19  Yao Qi  <yao.qi@linaro.org>
6777
6778         * arm-linux-tdep.c (arm_linux_gcc_target_options): New function.
6779         (arm_linux_init_abi): Install it.
6780
6781 2018-01-19  Yao Qi  <yao.qi@linaro.org>
6782
6783         * osabi.c (gdb_osabi_names): Extend the regexp for
6784         arm-linux-gnueabihf.
6785
6786 2018-01-18  Yao Qi  <yao.qi@linaro.org>
6787
6788         * dwarf2read.c (abbrev_table) <abbrevs>: Rename it to
6789         m_abbrevs.
6790         (abbrev_table::add_abbrev): Update.
6791         (abbrev_table::lookup_abbrev): Update.
6792
6793 2018-01-18  Yao Qi  <yao.qi@linaro.org>
6794
6795         * ppc-linux-tdep.c (ppu2spu_prev_register): Call cooked_read.
6796
6797 2018-01-17  Sergio Durigan Junior  <sergiodj@redhat.com>
6798
6799         * compile/compile.c (compile_to_object): Convert "triplet_rx"
6800         to "std::string".
6801
6802 2018-01-17  Tom Tromey  <tom@tromey.com>
6803
6804         * dwarf2read.c (symbolp): Remove typedef.  Don't instantiate VEC.
6805
6806 2018-01-17  Tom Tromey  <tom@tromey.com>
6807
6808         * gdbtypes.h (add_dyn_prop): Remove objfile parameter.
6809         * gdbtypes.c (add_dyn_prop): Remove objfile parameter.
6810         (create_array_type_with_stride): Update.
6811         * dwarf2read.c (set_die_type): Update.
6812
6813 2018-01-17  Tom Tromey  <tom@tromey.com>
6814
6815         * dwarf2read.c (delayed_method_info): Remove typedef.
6816         (dwarf2_cu::method_info): Now a std::vector.
6817         (add_to_method_list): Update.
6818         (free_delayed_list): Remove.
6819         (compute_delayed_physnames): Update.
6820         (process_full_comp_unit, process_full_type_unit): Clear the method
6821         list.  Remove cleanups.
6822         (psymtab_include_file_name): Add name_holder parameter.  Use
6823         unique_xmalloc_ptr.
6824         (dwarf_decode_lines): Update.
6825
6826 2018-01-17  Tom Tromey  <tom@tromey.com>
6827             Simon Marchi  <simon.marchi@ericsson.com>
6828
6829         * dwarf2read.c (struct dwarf2_cu): Add constructor, destructor.
6830         (dwarf2_per_objfile::free_cached_comp_units)
6831         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
6832         (init_cutu_and_read_dies_no_follow): Update.
6833         (dwarf2_cu::dwarf2_cu): Rename from init_one_comp_unit.
6834         (dwarf2_cu::~dwarf2_cu): New.
6835         (free_heap_comp_unit, free_stack_comp_unit): Remove.
6836         (age_cached_comp_units, free_one_cached_comp_unit): Update.
6837
6838 2018-01-17  Tom Tromey  <tom@tromey.com>
6839             Simon Marchi  <simon.marchi@ericsson.com>
6840
6841         * dwarf2read.c (struct dwarf2_cu) <abbrev_table>: Remove.
6842         (struct die_reader_specs) <abbrev_table>: New member.
6843         (struct abbrev_table): Add constructor.
6844         <alloc_abbrev, add_abbrev, lookup_abbrev>: Declare.
6845         <abbrev_obstack>: Now an auto_obstack.
6846         (abbrev_table_up): New typedef.
6847         (init_cu_die_reader): Add abbrev_table parameter.
6848         (read_cutu_die_from_dwo): Remove abbrev_table_provided parameter.
6849         Add result_dwo_abbrev_table.
6850         (init_tu_and_read_dwo_dies, init_cutu_and_read_dies)
6851         (init_cutu_and_read_dies_no_follow, build_type_psymtabs_1):
6852         Update.
6853         (peek_die_abbrev): Take die_reader_specs, not dwarf_cu as
6854         parameter.
6855         (skip_children): Update.
6856         (abbrev_table::alloc_abbrev): Rename from
6857         abbrev_table_alloc_abbrev.
6858         (abbrev_table::add_abbrev): Rename from abbrev_table_add_abbrev.
6859         (abbrev_table::lookup_abbrev): Rename from
6860         abbrev_table_lookup_abbrev.
6861         (abbrev_table_read_table): Return abbrev_table_up.
6862         (abbrev_table_free, abbrev_table_free_cleanup)
6863         (dwarf2_read_abbrevs, dwarf2_free_abbrev_table): Remove.
6864         (load_partial_dies): Update.
6865
6866 2018-01-17  Tom Tromey  <tom@tromey.com>
6867
6868         * dwarf2read.c (dwarf2_compute_name): Update comment.
6869         (read_func_scope, read_variable): Update.
6870         (new_symbol): Remove.
6871         (new_symbol_full): Rename to new_symbol.
6872
6873 2018-01-17  Mike Gulick  <mgulick@mathworks.com>
6874
6875         PR gdb/16577
6876         * gdb_bfd.c (gdb_bfd_map_section): If unable to read object file, issue
6877         a warning instead of throwing an error, set section size to 0 and return
6878         NULL.
6879         * gdb_bfd.h (gdb_bfd_map_section): Update description.
6880
6881 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
6882
6883         * nat/linux-ptrace.h (linux_ptrace_attach_fail_reason): Return
6884         std::string.
6885         (linux_ptrace_attach_fail_reason_string): Likewise.
6886         * nat/linux-ptrace.c (linux_ptrace_attach_fail_reason):
6887         Likewise.
6888         (linux_ptrace_attach_fail_reason_string): Likewise.
6889         * linux-nat.c (attach_proc_task_lwp_callback): Adjust.
6890
6891 2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
6892
6893         * linux-nat.c (linux_nat_attach): Remove xstrdup.
6894
6895 2018-01-17  Eldar Abusalimov  <eldar.abusalimov@jetbrains.com>
6896
6897         PR gdb/21559
6898         * configure.ac: Include <sys/types.h> prior to <sys/user.h> when
6899         checking for fs_base/gs_base fields in struct user_regs_struct.
6900         * configure: Regenerate.
6901
6902 2018-01-17  Yao Qi  <yao.qi@linaro.org>
6903
6904         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): New
6905         function.
6906         (aarch64_linux_init_abi): Install it to gdbarch hook
6907         gcc_target_options.
6908
6909 2018-01-15  Pedro Alves  <palves@redhat.com>
6910
6911         * common/signals-state-save-restore.c
6912         (save_original_signals_state): Fix typos.
6913
6914 2017-01-12  Tom Tromey  <tom@tromey.com>
6915             Sergio Durigan Junior  <sergiodj@redhat.com>
6916
6917         * Makefile.in (install-only): Install gdb-add-index.
6918
6919 2018-01-12  John Baldwin  <jhb@FreeBSD.org>
6920
6921         * fbsd-tdep.c (KVE_PROTECTION): Correct value.
6922
6923 2018-01-12  Andreas Arnez  <arnez@linux.vnet.ibm.com>
6924
6925         * infrun.c (keep_going_pass_signal): Clear step-over info when
6926         insert_breakpoints fails.
6927
6928 2018-01-11  Pedro Alves  <palves@redhat.com>
6929
6930         PR gdb/22583
6931         * infrun.c (resume): Rename to ...
6932         (resume_1): ... this.
6933         (resume): Reimplement as wrapper around resume_1.
6934
6935 2018-01-11  Pedro Alves  <palves@redhat.com>
6936
6937         PR remote/22597
6938         * remote.c (remote_parse_stop_reply): Default to the last-set
6939         general thread instead of to 'magic_null_ptid'.
6940
6941 2018-01-10  Pedro Alves  <palves@redhat.com>
6942
6943         * language.h (language_get_symbol_name_matcher): Rename ...
6944         (get_symbol_name_matcher): ... this.
6945         * language.c (language_get_symbol_name_matcher): Ditto.
6946         * dictionary.c, linespec.c, minsyms.c, psymtab.c, symtab.c: All
6947         callers adjusted.
6948
6949 2018-01-10  Pedro Alves  <palves@redhat.com>
6950
6951         PR gdb/22670
6952         * dwarf2read.c
6953         (gdb_index_symbol_name_matcher::gdb_index_symbol_name_matcher):
6954         Adjust to use language_get_symbol_name_matcher instead of
6955         language_defn::la_get_symbol_name_matcher.
6956         * language.c (language_get_symbol_name_matcher): If in Ada mode
6957         and the lookup name is a verbatim match, return Ada's matcher.
6958         * language.h (language_get_symbol_name_matcher): Adjust comment.
6959         (ada_lookup_name_info::verbatim_p):: New method.
6960
6961 2018-01-10  Pedro Alves  <palves@redhat.com>
6962
6963         PR gdb/22670
6964         * ada-lang.c (ada_collect_symbol_completion_matches): If the
6965         minsym's language is language_auto or language_cplus, pass down
6966         language_ada instead.
6967         * symtab.c (compare_symbol_name): Don't frob symbol language here.
6968
6969 2018-01-10  Pedro Alves  <palves@redhat.com>
6970
6971         PR gdb/22670
6972         * minsyms.c (linkage_name_str): New function.
6973         (iterate_over_minimal_symbols): Use it.
6974
6975 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6976
6977         * NEWS: Document that 'info proc' now works on FreeBSD.
6978
6979 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6980
6981         * configure.ac: Check for kinfo_getfile in libutil.
6982         * configure: Regenerate.
6983         * config.in: Regenerate.
6984         * fbsd-nat.c: Include "fbsd-tdep.h".
6985         (fbsd_fetch_cmdline): New.
6986         (fbsd_fetch_kinfo_proc): Move earlier and change to return a bool
6987         rather than calling error.
6988         (fbsd_info_proc): New.
6989         (fbsd_thread_name): Report error if fbsd_fetch_kinfo_proc fails.
6990         (fbsd_wait): Report warning if fbsd_fetch_kinfo_proc fails.
6991         (fbsd_nat_add_target): Set "to_info_proc" to "fbsd_info_proc".
6992
6993 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6994
6995         * fbsd-nat.c (struct free_deleter): Remove.
6996         (fbsd_find_memory_regions): Use gdb::unique_xmalloc_ptr<>.
6997
6998 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
6999
7000         * fbsd-nat.c (fbsd_pid_to_exec_file) [KERN_PROC_PATHNAME]: Return
7001         NULL for an empty pathname.
7002
7003 2018-01-09  John Baldwin  <jhb@FreeBSD.org>
7004
7005         * fbsd-tdep.c (KVE_STRUCTSIZE, KVE_START, KVE_END, KVE_OFFSET)
7006         (KVE_FLAGS, KVE_PROTECTION, KVE_PATH, KINFO_VME_PROT_READ)
7007         (KINFO_VME_PROT_WRITE, KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
7008         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
7009         (KINFO_VME_FLAG_SUPER, KINFO_VME_FLAG_GROWS_UP)
7010         (KINFO_VME_FLAG_GROWS_DOWN, KF_STRUCTSIZE, KF_TYPE, KF_FD)
7011         (KF_PATH, KINFO_FILE_TYPE_VNODE, KINFO_FILE_FD_TYPE_CWD)
7012         (KINFO_FILE_FD_TYPE_TEXT, SIG_WORDS, struct kinfo_proc_layout)
7013         (kinfo_proc_layout_32, kinfo_proc_layout_i386)
7014         (kinfo_proc_layout_64, fbsd_vm_map_entry_flags)
7015         (fbsd_core_info_proc_mappings, fbsd_core_vnode_path)
7016         (fbsd_core_fetch_timeval, fbsd_print_sigset)
7017         (fbsd_core_info_proc_status, fbsd_core_info_proc): New.
7018         (fbsd_init_abi):  Install gdbarch "core_info_proc" method.
7019         * fbsd-tdep.h (fbsd_vm_map_entry_flags): New.
7020
7021 2018-01-08  Samuel Thibault  <samuel.thibault@ens-lyon.org>
7022
7023         * gdb/gnu-nat.c: Include <elf.h> and <link.h>.
7024         (gnu_xfer_auxv): New function.
7025         (gnu_xfer_partial): Call gnu_xfer_auxv when `object' is
7026         TARGET_OBJECT_AUXV.
7027
7028 2018-01-08  Yao Qi  <yao.qi@linaro.org>
7029             Simon Marchi  <simon.marchi@ericsson.com>
7030
7031         * Makefile.in (COMMON_SFILES): Remove selftest-arch.c and
7032         common/selftest.c.
7033         (COMMON_OBS): Remove selftest.o.
7034         * configure.ac: Append selftest-arch.c and common/selftest.c to
7035         CONFIG_SRCS.  Append selftest-arch.o and selftest.o to COMMON_OBS.
7036         * configure: Re-generated.
7037         * maint.c (maintenance_selftest): Wrap selftests::run_tests with
7038         GDB_SELF_TEST.
7039         (maintenance_info_selftests): Likewise.
7040
7041 2018-01-08  Xavier Roirand  <roirand@adacore.com>
7042
7043         * ada-valprint.c (val_print_packed_array_elements): Use
7044         proper number of elements when printing an array indexed
7045         by an enumeration type.
7046
7047 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
7048
7049         * dwarf2read.c (struct dwarf2_cu) <dwarf2_per_objfile>: Remove.
7050         (dw2_get_file_names_reader): Adjust.
7051         (lookup_dwo_signatured_type): Adjust.
7052         (lookup_dwp_signatured_type): Adjust.
7053         (lookup_signatured_type): Adjust.
7054         (create_type_unit_group): Adjust.
7055         (get_type_unit_group): Adjust.
7056         (process_psymtab_comp_unit_reader): Adjust.
7057         (build_type_psymtabs_reader): Adjust.
7058         (scan_partial_symbols): Adjust.
7059         (add_partial_symbol): Adjust.
7060         (add_partial_subprogram): Adjust.
7061         (peek_die_abbrev): Adjust.
7062         (fixup_go_packaging): Adjust.
7063         (process_imported_unit_die): Adjust.
7064         (dwarf2_compute_name): Adjust.
7065         (dwarf2_physname): Adjust.
7066         (read_import_statement): Adjust.
7067         (handle_DW_AT_stmt_list): Adjust.
7068         (read_file_scope): Adjust.
7069         (read_func_scope): Adjust.
7070         (read_lexical_block_scope): Adjust.
7071         (read_call_site_scope): Adjust.
7072         (read_variable): Adjust.
7073         (dwarf2_rnglists_process): Adjust.
7074         (dwarf2_ranges_process): Adjust.
7075         (dwarf2_ranges_read): Adjust.
7076         (dwarf2_get_pc_bounds): Adjust.
7077         (dwarf2_record_block_ranges): Adjust.
7078         (dwarf2_add_field): Adjust.
7079         (dwarf2_add_member_fn): Adjust.
7080         (read_structure_type): Adjust.
7081         (process_structure_scope): Adjust.
7082         (read_enumeration_type): Adjust.
7083         (read_array_type): Adjust.
7084         (mark_common_block_symbol_computed): Adjust.
7085         (read_common_block): Adjust.
7086         (read_namespace_type): Adjust.
7087         (read_namespace): Adjust.
7088         (read_module_type): Adjust.
7089         (read_tag_pointer_type): Adjust.
7090         (read_tag_ptr_to_member_type): Adjust.
7091         (read_tag_string_type): Adjust.
7092         (read_subroutine_type): Adjust.
7093         (read_typedef): Adjust.
7094         (read_base_type): Adjust.
7095         (attr_to_dynamic_prop): Adjust.
7096         (read_subrange_type): Adjust.
7097         (read_unspecified_type): Adjust.
7098         (dwarf2_read_abbrevs): Adjust.
7099         (load_partial_dies): Adjust.
7100         (read_partial_die): Adjust.
7101         (find_partial_die): Adjust.
7102         (guess_partial_die_structure_name): Adjust.
7103         (fixup_partial_die): Adjust.
7104         (read_attribute_value): Adjust.
7105         (read_addr_index): Adjust.
7106         (read_addr_index_from_leb128): Adjust.
7107         (read_str_index): Adjust.
7108         (dwarf2_string_attr): Adjust.
7109         (get_debug_line_section): Adjust.
7110         (dwarf_decode_line_header): Adjust.
7111         (lnp_state_machine::check_line_address): Adjust.
7112         (dwarf_decode_lines_1): Adjust.
7113         (dwarf_decode_lines): Adjust.
7114         (dwarf2_start_symtab): Adjust.
7115         (var_decode_location): Adjust.
7116         (new_symbol_full): Adjust.
7117         (dwarf2_const_value_data): Adjust.
7118         (dwarf2_const_value_attr): Adjust.
7119         (dwarf2_const_value): Adjust.
7120         (die_type): Adjust.
7121         (die_containing_type): Adjust.
7122         (build_error_marker_type): Adjust.
7123         (lookup_die_type): Adjust.
7124         (guess_full_die_structure_name): Adjust.
7125         (anonymous_struct_prefix): Adjust.
7126         (determine_prefix): Adjust.
7127         (dwarf2_name): Adjust.
7128         (follow_die_ref_or_sig): Adjust.
7129         (follow_die_offset): Adjust.
7130         (follow_die_ref): Adjust.
7131         (follow_die_sig_1): Adjust.
7132         (follow_die_sig): Adjust.
7133         (get_signatured_type): Adjust.
7134         (get_DW_AT_signature_type): Adjust.
7135         (decode_locdesc): Adjust.
7136         (dwarf_decode_macros): Adjust.
7137         (cu_debug_loc_section): Adjust.
7138         (fill_in_loclist_baton): Adjust.
7139         (dwarf2_symbol_mark_computed): Adjust.
7140         (init_one_comp_unit): Don't assign
7141         dwarf2_cu::dwarf2_per_objfile.
7142         (set_die_type): Adjust.
7143
7144 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
7145
7146         * dwarf2read.c (struct mapped_debug_names): Add constructor.
7147         <dwarf2_per_objfile>: New field.
7148         (dwarf2_per_objfile): Remove global.
7149         (get_dwarf2_per_objfile): New function.
7150         (set_dwarf2_per_objfile): New function.
7151         (dwarf2_build_psymtabs_hard): Change objfile parameter to
7152         dwarf2_per_objfile.
7153         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
7154         (read_abbrev_offset): Likewise.
7155         (read_indirect_string): Likewise.
7156         (read_indirect_line_string): Likewise.
7157         (read_indirect_string_at_offset): Likewise.
7158         (read_indirect_string_from_dwz): Likewise.
7159         (dwarf2_find_containing_comp_unit): Change objfile parameter to
7160         dwarf2_per_objfile.
7161         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
7162         (create_all_comp_units): Change objfile parameter to
7163         dwarf2_per_objfile.
7164         (create_all_type_units): Likewise.
7165         (process_queue): Add dwarf2_per_objfile parameter.
7166         (read_and_check_comp_unit_head): Likewise.
7167         (lookup_dwo_unit_in_dwp): Likewise.
7168         (get_dwp_file): Likewise.
7169         (process_cu_includes): Likewise.
7170         (struct free_dwo_file_cleanup_data): New struct.
7171         (dwarf2_has_info): Use get_dwarf2_per_objfile and
7172         set_dwarf2_per_objfile.
7173         (dwarf2_get_dwz_file): Add dwarf2_per_objfile parameter.
7174         (dw2_do_instantiate_symtab): Get dwarf2_per_objfile from
7175         context, adjust calls.
7176         (dw2_instantiate_symtab): Likewise.
7177         (dw2_get_cutu): Add dwarf2_per_objfile parameter.
7178         (dw2_get_cu): Likewise.
7179         (create_cu_from_index_list): Change objfile parameter to
7180         dwarf2_per_objfile.
7181         (create_cus_from_index_list): Get dwarf2_per_objfile from
7182         context, adjust calls.
7183         (create_cus_from_index): Likewise.
7184         (create_signatured_type_table_from_index): Change objfile
7185         parameter to dwarf2_per_objfile.
7186         (create_signatured_type_table_from_debug_names): Change objfile
7187         parameter to dwarf2_per_objfile.
7188         (create_addrmap_from_index): Likewise.
7189         (create_addrmap_from_aranges): Likewise.
7190         (dwarf2_read_index): Use get_dwarf2_per_objfile, adjust calls.
7191         (dw2_setup): Remove.
7192         (dw2_get_file_names_reader): Get dwarf2_per_objfile from
7193         context.
7194         (dw2_find_last_source_symtab): Get dwarf2_per_objfile using
7195         get_dwarf2_per_objfile.
7196         (dw2_forget_cached_source_info): Likewise.
7197         (dw2_map_symtabs_matching_filename): Likewise.
7198         (struct dw2_symtab_iterator) <index>: Remove.
7199         <dwarf2_per_objfile>: New field.
7200         (dw2_symtab_iter_init): Replace index parameter with
7201         dwarf2_per_objfile.
7202         (dw2_symtab_iter_next): Use dwarf2_per_objfile from iter.
7203         (dw2_lookup_symbol): Use get_dwarf2_per_objfile and adjust.
7204         (dw2_print_stats): Likewise.
7205         (dw2_dump): Likewise.
7206         (dw2_expand_symtabs_for_function): Likewise.
7207         (dw2_expand_all_symtabs): Likewise.
7208         (dw2_expand_symtabs_with_fullname): Likewise.
7209         (dw2_expand_marked_cus): Replace index and objfile parameters
7210         with dwarf2_per_objfile.
7211         (dw_expand_symtabs_matching_file_matcher): Add
7212         dwarf2_per_objfile parameter and adjust calls.
7213         (dw2_expand_symtabs_matching): Use get_dwarf2_per_objfile and
7214         adjust calls.
7215         (dw2_find_pc_sect_compunit_symtab): Don't call dw2_setup.
7216         (dw2_map_symbol_filenames): Use get_dwarf2_per_objfile and
7217         adjust calls.
7218         (create_cus_from_debug_names_list): Replace objfile parameter
7219         with dwarf2_per_objfile and adjust calls.
7220         (create_cus_from_debug_names): Likewise.
7221         (dwarf2_read_debug_names): Likewise.
7222         (mapped_debug_names::namei_to_name): Adjust call.
7223         (dw2_debug_names_iterator::next): Likewise.
7224         (dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
7225         (dw2_debug_names_lookup_symbol): Use get_dwarf2_per_objfile.
7226         (dw2_debug_names_dump): Likewise.
7227         (dw2_debug_names_expand_symtabs_for_function): Likewise.
7228         (dw2_debug_names_expand_symtabs_matching): Likewise.
7229         (dwarf2_initialize_objfile): Likewise.
7230         (dwarf2_build_psymtabs): Likewise.
7231         (get_abbrev_section_for_cu): Get dwarf2_per_objfile from
7232         this_cu.
7233         (error_check_comp_unit_head): Add dwarf2_per_objfile parameter.
7234         (read_and_check_comp_unit_head): Likewise.
7235         (read_abbrev_offset): Likewise.
7236         (create_debug_type_hash_table): Likewise.
7237         (create_debug_types_hash_table): Likewise.
7238         (create_all_type_units): Replace objfile parameter with
7239         dwarf2_per_objfile.
7240         (add_type_unit): Add dwarf2_per_objfile parameter.
7241         (fill_in_sig_entry_from_dwo_entry): Replace objfile parameter
7242         with dwarf2_per_objfile.
7243         (lookup_dwo_signatured_type): Get dwarf2_per_objfile from cu.
7244         (lookup_dwp_signatured_type): Likewise.
7245         (lookup_signatured_type): Likewise.
7246         (read_cutu_die_from_dwo): Likewise.
7247         (init_tu_and_read_dwo_dies): Likewise.
7248         (init_cutu_and_read_dies): Likewise.
7249         (init_cutu_and_read_dies_no_follow): Likewise.
7250         (allocate_type_unit_groups_table): Add objfile parameter.
7251         (create_type_unit_group): Use dwarf2_per_objfile from cu.
7252         (get_type_unit_group): Likewise.
7253         (process_psymtab_comp_unit): Update call.
7254         (build_type_psymtabs_reader): Use dwarf2_per_objfile from cu.
7255         (build_type_psymtabs_1): Add dwarf2_per_objfile parameter.
7256         (print_tu_stats): Likewise.
7257         (build_type_psymtab_dependencies): Use dwarf2_per_objfile passed
7258         in void* parameter.
7259         (build_type_psymtabs): Change objfile parameter to
7260         dwarf2_per_objfile.
7261         (process_skeletonless_type_unit): Use dwarf2_per_objfile
7262         passed in void* parameter.
7263         (process_skeletonless_type_units): Change objfile parameter to
7264         dwarf2_per_objfile.
7265         (set_partial_user): Likewise.
7266         (dwarf2_build_psymtabs_hard): Likewise.
7267         (read_comp_units_from_section): Likewise.
7268         (create_all_comp_units): Likewise.
7269         (scan_partial_symbols): Update calls.
7270         (add_partial_symbol): Likewise.
7271         (dwarf2_read_symtab): Use get_dwarf2_per_objfile.
7272         (maybe_queue_comp_unit): Use dwarf2_read_symtab from cu.
7273         (process_queue): Add dwarf2_per_objfile parameter.
7274         (get_compunit_symtab): Use dwarf2_per_objfile from cu.
7275         (compute_compunit_symtab_includes): Likewise.
7276         (process_cu_includes): Add dwarf2_per_objfile parameter.
7277         (process_full_comp_unit): Use dwarf2_per_objfile from cu.
7278         (process_full_type_unit): Likewise.
7279         (process_imported_unit_die): Update call.
7280         (handle_DW_AT_stmt_list): Use dwarf2_per_objfile from cu.
7281         (read_file_scope): Likewise.
7282         (allocate_dwo_file_hash_table): Add objfile parameter.
7283         (lookup_dwo_file_slot): Add dwarf2_per_objfile parameter.
7284         (create_cus_hash_table): Likewise.
7285         (create_dwp_hash_table): Likewise.
7286         (create_dwo_unit_in_dwp_v1): Likewise.
7287         (create_dwp_v2_section): Likewise.
7288         (create_dwo_unit_in_dwp_v2): Likewise.
7289         (lookup_dwo_unit_in_dwp): Likewise.
7290         (try_open_dwop_file): Likewise.
7291         (open_dwo_file): Likewise. Use dwarf2_per_objfile from cu.
7292         (open_and_init_dwo_file): Use dwarf2_per_objfile from cu, update
7293         cleanup to include a reference to dwarf2_per_objfile.
7294         (open_dwp_file): Add dwarf2_per_objfile parameter.
7295         (open_and_init_dwp_file): Likewise.
7296         (get_dwp_file): Likewise.
7297         (lookup_dwo_cutu): Use dwarf2_per_objfile from cu.
7298         (queue_and_load_all_dwo_tus): Update call.
7299         (free_dwo_file_cleanup): Use dwarf2_per_objfile from cleanup
7300         data.
7301         (dwarf2_rnglists_process): Use dwarf2_per_objfile from cu.
7302         (dwarf2_ranges_process): Likewise.
7303         (dwarf2_get_pc_bounds): Likewise.
7304         (mark_common_block_symbol_computed): Likewise.
7305         (abbrev_table_read_table): Add dwarf2_per_objfile parameter.
7306         (dwarf2_read_abbrevs): Update call.
7307         (read_partial_die): Use dwarf2_per_objfile from cu.
7308         (find_partial_die): Likewise.
7309         (fixup_partial_die): Likewise.
7310         (read_attribute_value): Likewise.
7311         (read_indirect_string_at_offset_from): Add objfile parameter.
7312         (read_indirect_string_at_offset): Add dwarf2_per_objfile
7313         parameter.
7314         (read_indirect_string_from_dwz): Add objfile parameter.
7315         (read_indirect_string): Add objfile parameter.
7316         (read_addr_index_1): Add dwarf2_per_objfile parameter.
7317         (read_addr_index): Use dwarf2_per_objfile from cu.
7318         (dwarf2_read_addr_index): Use dwarf2_per_objfile from cu, don't
7319         call dw2_setup.
7320         (read_str_index): Use dwarf2_per_objfile from cu.
7321         (get_debug_line_section): Likewise.
7322         (read_formatted_entries): Add dwarf2_per_objfile parameter.
7323         (dwarf_decode_line_header): Use dwarf2_per_objfile from cu.
7324         (new_symbol_full): Use dwarf2_per_objfile from cu.
7325         (build_error_marker_type): Likewise.
7326         (lookup_die_type): Likewise.
7327         (determine_prefix): Likewise.
7328         (follow_die_offset): Likewise.
7329         (dwarf2_fetch_die_loc_sect_off): Use get_dwarf2_per_objfile.
7330         (dwarf2_fetch_constant_bytes): Don't call dw2_setup.
7331         (dwarf2_fetch_die_type_sect_off): Likewise.
7332         (dwarf2_get_die_type): Likewise.
7333         (follow_die_sig_1): Use dwarf2_per_objfile from cu.
7334         (get_signatured_type): Likewise.
7335         (get_DW_AT_signature_type): Likewise.
7336         (dwarf_decode_macro_bytes): Add dwarf2_per_objfile parameter.
7337         (dwarf_decode_macros): Use dwarf2_per_objfile from cu.
7338         (cu_debug_loc_section): Likewise.
7339         (fill_in_loclist_baton): Likewise.
7340         (dwarf2_symbol_mark_computed): Likewise.
7341         (dwarf2_find_containing_comp_unit): Change objfile parameter to
7342         dwarf2_per_objfile.
7343         (free_cached_comp_units): Use dwarf2_per_objfile passed in void*
7344         parameter.
7345         (age_cached_comp_units): Add dwarf2_per_objfile parameter.
7346         (free_one_cached_comp_unit): Use dwarf2_per_objfile from cu.
7347         (dwarf2_free_objfile): Use get_dwarf2_per_objfile.
7348         (set_die_type): Use dwarf2_free_objfile from cu.
7349         (get_die_type_at_offset): Likewise.
7350         (dwarf2_per_objfile_free): Don't assign global variable.
7351         (debug_names) <constructor>: Add dwarf2_per_objfile
7352         parameter, update m_debugstrlookup construction.
7353         (debug_names::debug_str_lookup): Add dwarf2_per_objfile
7354         parameter.
7355         <m_dwarf2_per_objfile>: New field.
7356         <lookup>: Use m_dwarf2_per_objfile.
7357         (check_dwarf64_offsets): Add dwarf2_per_objfile parameter.
7358         (psyms_seen_size): Likewise.
7359         (write_gdbindex): Replace objfile parameter with
7360         dwarf2_per_objfile.
7361         (write_debug_names): Likewise.
7362         (write_psymtabs_to_index): Likewise.
7363         (save_gdb_index_command): Use get_dwarf2_per_objfile, update
7364         calls.
7365
7366 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
7367
7368         * dwarf2read.c (struct dwarf2_cu) <objfile>: Remove.
7369         <dwarf2_per_objfile>: New field.
7370         (struct dwarf2_per_cu_data) <objfile>: Remove.
7371         <dwarf2_per_objfile>: New field.
7372         (create_cu_from_index_list): Assign dwarf2_per_objfile instead
7373         of objfile.
7374         (create_signatured_type_table_from_index): Likewise.
7375         (create_debug_type_hash_table): Likewise.
7376         (fill_in_sig_entry_from_dwo_entry): Likewise.
7377         (lookup_dwo_unit): Access objfile through dwarf2_per_objfile.
7378         (create_type_unit_group): Assign dwarf2_per_objfile instead of
7379         objfile.
7380         (create_partial_symtab): Access objfile through
7381         dwarf2_per_objfile.
7382         (process_psymtab_comp_unit_reader): Likewise.
7383         (read_comp_units_from_section): Likewise.
7384         (scan_partial_symbols): Likewise.
7385         (add_partial_symbol): Likewise.
7386         (add_partial_subprogram): Likewise.
7387         (peek_die_abbrev): Likewise.
7388         (fixup_go_packaging): Likewise.
7389         (process_full_comp_unit): Likewise.
7390         (process_full_type_unit): Likewise.
7391         (process_imported_unit_die): Likewise.
7392         (dwarf2_compute_name): Likewise.
7393         (dwarf2_physname): Likewise.
7394         (read_import_statement): Likewise.
7395         (create_cus_hash_table): Assign dwarf2_physname instead of
7396         objfile.
7397         (read_func_scope): Access objfile through dwarf2_per_objfile.
7398         (read_lexical_block_scope): Likewise.
7399         (read_call_site_scope): Likewise.
7400         (read_variable): Likewise.
7401         (dwarf2_rnglists_process): Likewise.
7402         (dwarf2_ranges_process): Likewise.
7403         (dwarf2_ranges_read): Likewise.
7404         (dwarf2_record_block_ranges): Likewise.
7405         (dwarf2_add_field): Likewise.
7406         (dwarf2_add_member_fn): Likewise.
7407         (read_structure_type): Likewise.
7408         (process_structure_scope): Likewise.
7409         (read_enumeration_type): Likewise.
7410         (read_array_type): Likewise.
7411         (read_common_block): Likewise.
7412         (read_namespace_type): Likewise.
7413         (read_namespace): Likewise.
7414         (read_module_type): Likewise.
7415         (read_tag_pointer_type): Likewise.
7416         (read_tag_ptr_to_member_type): Likewise.
7417         (read_tag_string_type): Likewise.
7418         (read_subroutine_type): Likewise.
7419         (read_typedef): Likewise.
7420         (read_base_type): Likewise.
7421         (attr_to_dynamic_prop): Likewise.
7422         (read_subrange_type): Likewise.
7423         (read_unspecified_type): Likewise.
7424         (load_partial_dies): Likewise.
7425         (read_partial_die): Likewise.
7426         (find_partial_die): Likewise.
7427         (guess_partial_die_structure_name): Likewise.
7428         (fixup_partial_die): Likewise.
7429         (read_attribute_value): Likewise.
7430         (read_addr_index_from_leb128): Likewise.
7431         (dwarf2_read_addr_index): Likewise.
7432         (dwarf2_string_attr): Likewise.
7433         (lnp_state_machine::check_line_address): Likewise.
7434         (dwarf_decode_lines_1): Likewise.
7435         (dwarf_decode_lines): Likewise.
7436         (dwarf2_start_symtab): Likewise.
7437         (var_decode_location): Likewise.
7438         (new_symbol_full): Likewise.
7439         (dwarf2_const_value_data): Likewise.
7440         (dwarf2_const_value_attr): Likewise.
7441         (dwarf2_const_value): Likewise.
7442         (die_type): Likewise.
7443         (die_containing_type): Likewise.
7444         (lookup_die_type): Likewise.
7445         (guess_full_die_structure_name): Likewise.
7446         (anonymous_struct_prefix): Likewise.
7447         (dwarf2_name): Likewise.
7448         (follow_die_ref_or_sig): Likewise.
7449         (follow_die_offset): Likewise.
7450         (follow_die_ref): Likewise.
7451         (dwarf2_fetch_die_loc_sect_off): Likewise.
7452         (dwarf2_fetch_constant_bytes): Likewise.
7453         (dwarf2_fetch_die_type_sect_off): Likewise.
7454         (dwarf2_get_die_type): Likewise.
7455         (follow_die_sig): Likewise.
7456         (decode_locdesc): Likewise.
7457         (dwarf2_per_cu_objfile): Likewise.
7458         (dwarf2_per_cu_text_offset): Likewise.
7459         (init_one_comp_unit): Assign dwarf2_per_objfile instead of
7460         objfile.
7461         (set_die_type): Access objfile through
7462         dwarf2_per_objfile.
7463
7464 2018-01-07  Simon Marchi  <simon.marchi@ericsson.com>
7465
7466         * valprint.c (converted_character_d): Remove typedef.
7467         (DEF_VEC_O (converted_character_d)): Remove.
7468         (count_next_character): Use std::vector.
7469         (print_converted_chars_to_obstack): Likewise.
7470         (generic_printstr): Likewise.
7471
7472 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
7473
7474         * xml-support.h (struct gdb_xml_value): Add constructor.
7475         <value>: Change type to unique_xmalloc_ptr.
7476         (gdb_xml_value_s): Remove typedef.
7477         (DEF_VEC_O (gdb_xml_value_s)): Remove.
7478         (gdb_xml_element_start_handler): Change parameter type to
7479         std::vector.
7480         (xml_find_attribute): Likewise.
7481         * xml-support.c (xml_find_attribute): Change parameter type to
7482         std::vector and adjust.
7483         (gdb_xml_values_cleanup): Remove.
7484         (gdb_xml_parser::start_element): Adjust to std::vector.
7485         (xinclude_start_include): Change paraeter type to std::vector
7486         and adjust.
7487         * btrace.c (check_xml_btrace_version): Likewise.
7488         (parse_xml_btrace_block): Likewise.
7489         (parse_xml_btrace_pt_config_cpu): Likewise.
7490         (parse_xml_btrace_pt): Likewise.
7491         (parse_xml_btrace_conf_bts): Likewise.
7492         (parse_xml_btrace_conf_pt): Likewise.
7493         * memory-map.c (memory_map_start_memory): Likewise.
7494         (memory_map_start_property): Likewise.
7495         * osdata.c (osdata_start_osdata): Likewise.
7496         (osdata_start_item): Likewise.
7497         (osdata_start_column): Likewise.
7498         * remote.c (start_thread): Likewise.
7499         * solib-aix.c (library_list_start_library): Likewise.
7500         (library_list_start_list): Likewise.
7501         * solib-svr4.c (library_list_start_library): Likewise.
7502         (svr4_library_list_start_list): Likewise.
7503         * solib-target.c (library_list_start_segment): Likewise.
7504         (library_list_start_section): Likewise.
7505         (library_list_start_library): Likewise.
7506         (library_list_start_list): Likewise.
7507         * tracepoint.c (traceframe_info_start_memory): Likewise.
7508         (traceframe_info_start_tvar): Likewise.
7509         * xml-syscall.c (syscall_start_syscall): Likewise.
7510         * xml-tdesc.c (tdesc_start_target): Likewise.
7511         (tdesc_start_feature): Likewise.
7512         (tdesc_start_reg): Likewise.
7513         (tdesc_start_union): Likewise.
7514         (tdesc_start_struct): Likewise.
7515         (tdesc_start_flags): Likewise.
7516         (tdesc_start_enum): Likewise.
7517         (tdesc_start_field): Likewise.
7518         (tdesc_start_enum_value): Likewise.
7519         (tdesc_start_vector): Likewise.
7520
7521 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
7522
7523         * extension.h (struct xmethod_worker) <clone>: Remove.
7524         * python/py-xmethods.c (struct python_xmethod_worker) <clone>:
7525         Remove.
7526         (python_xmethod_worker::clone): Remove.
7527         * valops.c (find_overload_match): Use std::move instead of
7528         clone.
7529
7530 2018-01-07  Simon Marchi  <simon.marchi@polymtl.ca>
7531
7532         * extension-priv.h (enum ext_lang_rc): Remove, move to extension.h.
7533         (struct extension_language_ops) <clone_xmethod_worker_data>: Remove.
7534         <free_xmethod_worker_data>: Remove.
7535         <get_matching_xmethod_workers>: Chance VEC to std::vector.
7536         <get_xmethod_arg_types>: Remove.
7537         <get_xmethod_result_type>: Remove.
7538         <invoke_xmethod>: Remove.
7539         * extension.c (new_xmethod_worker): Remove.
7540         (clone_xmethod_worker): Remove.
7541         (get_matching_xmethod_workers): Return void, pass std::vector by
7542         pointer.
7543         (get_xmethod_arg_types): Rename to...
7544         (xmethod_worker::get_arg_types): ... this, and adjust.
7545         (get_xmethod_result_type): Rename to...
7546         (xmethod_worker::get_result_type): ... this, and adjust.
7547         (invoke_xmethod): Remove.
7548         (free_xmethod_worker): Remove.
7549         (free_xmethod_worker_vec): Remove.
7550         * extension.h (enum ext_lang_rc): Move here from
7551         extension-priv.h.
7552         (struct xmethod_worker): Add constructor and destructor.
7553         <data>: Remove.
7554         <value>: Remove.
7555         <invoke, clone, do_get_result_type, do_get_arg_types>: New
7556         virtual pure methods.
7557         <get_arg_types, get_result_type>: New methods.
7558         (xmethod_worker_ptr): Remove typedef.
7559         (DEF_VEC_P (xmethod_worker_ptr)): Remove.
7560         (xmethod_worker_vec): Remove typedef.
7561         (xmethod_worker_up): New typedef.
7562         (invoke_xmethod): Remove.
7563         (clone_xmethod_worker): Remove.
7564         (free_xmethod_worker): Remove.
7565         (free_xmethod_worker_vec): Remove.
7566         (get_xmethod_arg_types): Remove.
7567         (get_xmethod_result_type): Remove.
7568         * valops.c (find_method_list): Use std::vector, don't use
7569         intermediate vector.
7570         (value_find_oload_method_list): Use std::vector.
7571         (find_overload_match): Use std::vector.
7572         (find_oload_champ): Use std::vector.
7573         * value.c (value_free): Use operator delete.
7574         (value_of_xmethod): Rename to...
7575         (value_from_xmethod): ... this.  Don't assign
7576         xmethod_worker::value, take rvalue-reference.
7577         (result_type_of_xmethod): Adjust.
7578         (call_xmethod): Adjust.
7579         * value.h: Include extension.h.
7580         (struct xmethod_worker): Don't forward-declare.
7581         (value_of_xmethod): Rename to...
7582         (value_from_xmethod): ... this, take rvalue-reference.
7583         * python/py-xmethods.c (struct gdbpy_worker_data): Rename to...
7584         (struct python_xmethod_worker): ... this, add constructor and
7585         destructor.
7586         <invoke, clone, do_get_arg_types, do_get_result_type>: Implement.
7587         (gdbpy_free_xmethod_worker_data): Rename to...
7588         (python_xmethod_worker::~python_xmethod_worker): ... this and
7589         adjust.
7590         (gdbpy_clone_xmethod_worker_data): Rename to...
7591         (python_xmethod_worker::clone): ... this and adjust.
7592         (gdbpy_get_matching_xmethod_workers): Use std::vector, don't use
7593         temporary vector.
7594         (gdbpy_get_xmethod_arg_types): Rename to...
7595         (python_xmethod_worker::do_get_arg_types): ... this and adjust.
7596         (gdbpy_get_xmethod_result_type): Rename to...
7597         (python_xmethod_worker::do_get_result_type): ... this and
7598         adjust.
7599         (gdbpy_invoke_xmethod): Rename to...
7600         (python_xmethod_worker::invoke): ... this and adjust.
7601         (new_python_xmethod_worker): Rename to...
7602         (python_xmethod_worker::python_xmethod_worker): ... this and
7603         adjust.
7604         * python/python-internal.h (gdbpy_clone_xmethod_worker_data):
7605         Remove.
7606         (gdbpy_free_xmethod_worker_data): Remove.
7607         (gdbpy_get_matching_xmethod_workers): Use std::vector.
7608         (gdbpy_get_xmethod_arg_types): Remove.
7609         (gdbpy_get_xmethod_result_type): Remove.
7610         (gdbpy_invoke_xmethod): Remove.
7611         * python/python.c (python_extension_ops): Remove obsolete
7612         callbacks.
7613
7614 2018-01-05  Pedro Alves  <palves@redhat.com>
7615
7616         PR gdb/18653
7617         * common/signals-state-save-restore.c
7618         (save_original_signals_state): New parameter 'quiet'.  Warn if we
7619         find a custom handler preinstalled, instead of internal erroring.
7620         But only warn if !quiet.
7621         * common/signals-state-save-restore.h
7622         (save_original_signals_state): New parameter 'quiet'.
7623         * main.c (captured_main_1): Move save_original_signals_state call
7624         after option handling, and pass QUIET.
7625
7626 2018-01-05  Pedro Alves  <palves@redhat.com>
7627
7628         * spu-tdep.c (spu_catch_start): Pass
7629         symbol_name_match_type::SEARCH_NAME to block_lookup_symbol.
7630
7631 2018-01-05  Pedro Alves  <palves@redhat.com>
7632
7633         PR gdb/22670
7634         * ada-lang.c (literal_symbol_name_matcher): New function.
7635         (ada_get_symbol_name_matcher): Use it for
7636         symbol_name_match_type::SEARCH_NAME.
7637         * block.c (block_lookup_symbol): New parameter 'match_type'.  Pass
7638         it down instead of assuming symbol_name_match_type::FULL.
7639         * block.h (block_lookup_symbol): New parameter 'match_type'.
7640         * c-valprint.c (print_unpacked_pointer): Use
7641         lookup_symbol_search_name instead of lookup_symbol.
7642         * compile/compile-object-load.c (get_out_value_type): Pass down
7643         symbol_name_match_type::SEARCH_NAME.
7644         * cp-namespace.c (cp_basic_lookup_symbol): Pass down
7645         symbol_name_match_type::FULL.
7646         * cp-support.c (cp_get_symbol_name_matcher): Handle
7647         symbol_name_match_type::SEARCH_NAME.
7648         * infrun.c (insert_exception_resume_breakpoint): Use
7649         lookup_symbol_search_name.
7650         * p-valprint.c (pascal_val_print): Use lookup_symbol_search_name.
7651         * psymtab.c (maintenance_check_psymtabs): Use
7652         symbol_name_match_type::SEARCH_NAME and SYMBOL_SEARCH_NAME.
7653         * stack.c (print_frame_args): Use lookup_symbol_search_name and
7654         SYMBOL_SEARCH_NAME.
7655         * symtab.c (lookup_local_symbol): Don't demangle the lookup name
7656         if symbol_name_match_type::SEARCH_NAME.
7657         (lookup_symbol_in_language): Pass down
7658         symbol_name_match_type::FULL.
7659         (lookup_symbol_search_name): New.
7660         (lookup_language_this): Pass down
7661         symbol_name_match_type::SEARCH_NAME.
7662         (lookup_symbol_aux, lookup_local_symbol): New parameter
7663         'match_type'.  Pass it down.
7664         * symtab.h (symbol_name_match_type::SEARCH_NAME): New enumerator.
7665         (lookup_symbol_search_name): New declaration.
7666         (lookup_symbol_in_block): New 'match_type' parameter.
7667
7668 2018-01-05  Pedro Alves  <palves@redhat.com>
7669
7670         PR gdb/22670
7671         * ada-lang.c (ada_lookup_encoded_symbol): Reimplement in terms of
7672         ada_lookup_symbol.
7673         (ada_lookup_symbol): Reimplement in terms of
7674         ada_lookup_symbol_list, bits factored out from
7675         ada_lookup_encoded_symbol.
7676
7677 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7678
7679         * ada-exp.y (write_object_renaming): When subscripting an array
7680         using a symbol as the index, pass the block in call to
7681         ada_lookup_encoded_symbol when looking that symbol up.
7682
7683 2018-01-05  Jerome Guitton  <guitton@adacore.com>
7684
7685         * ada-lang.c (ada_array_length): Use ada_index_type instead of
7686         TYPE_INDEX_TYPE.
7687
7688 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7689
7690         * ada-lang.c (ada_to_fixed_value_create): Add handling of
7691         the case where VALUE_LVAL (val0) is not lval_memory.
7692
7693 2018-01-05  Xavier Roirand  <roirand@adacore.com>
7694
7695         * ada-valprint.c (print_optional_low_bound): Handle
7696         character-indexed array printing like boolean-indexed array
7697         printing.
7698
7699 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7700
7701         * NEWS: Create a new section for the next release branch.
7702         Rename the section of the current branch, now that it has
7703         been cut.
7704
7705 2018-01-05  Joel Brobecker  <brobecker@adacore.com>
7706
7707         GDB 8.1 branch created (5219ac6237c272b938c28517bf371429260c71e7):
7708         * version.in: Bump version to 8.1.50.DATE-git.
7709
7710 2018-01-03  Xavier Roirand  <roirand@adacore.com>
7711
7712         * ada-lang.h (ada_exception_catchpoint_kind) <ada_catch_handlers>:
7713         Add field.
7714         * ada-lang.c (struct exception_support_info) <catch_handlers_sym>:
7715         Add field.
7716         (default_exception_support_info) <catch_handlers_sym>: Add field.
7717         (exception_support_info_fallback) <catch_handlers_sym>: Add field.
7718         (ada_exception_name_addr_1): Add "catch handlers" handling.
7719         (ada_exception_catchpoint_cond_string) <ex>: New parameter.
7720         Update all callers.
7721         (create_excep_cond_exprs) <ex>: Add parameter.
7722         (re_set_exception): Update create_excep_cond_exprs call.
7723         (print_it_exception, print_one_exception, print_mention_exception)
7724         (print_recreate_exception): Add "catch handler" handling.
7725         (allocate_location_catch_handlers, re_set_catch_handlers)
7726         (check_status_catch_handlers, print_it_catch_handlers)
7727         (print_one_catch_handlers, print_mention_catch_handlers)
7728         (print_recreate_catch_handlers): New function.
7729         (catch_handlers_breakpoint_ops): New variable.
7730         (catch_ada_exception_command_split) <is_catch_handlers_cmd>:
7731         Add parameter.  Add "catch handler" handling.
7732         (ada_exception_sym_name, ada_exception_breakpoint_ops):
7733         Add "catch handler" handling.
7734         (ada_exception_catchpoint_cond_string): Add "catch handler"
7735         handling.
7736         (create_ada_exception_catchpoint): Update create_excep_cond_exprs
7737         call.
7738         (catch_ada_handlers_command): New function.
7739         (initialize_ada_catchpoint_ops): Initialize "catch handlers"
7740         operations structure.
7741         (_initialize_ada_language): Add "catch handlers" command entry.
7742         * NEWS: Document "catch handlers" feature.
7743
7744 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
7745
7746         * ada-lang.c (ada_value_slice_from_ptr): Take array stride into
7747         account when creating the array type of the slice.
7748         (ada_value_slice): Likewise.
7749
7750 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
7751
7752         * gdbtypes.h (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_STRIDE>:
7753         New enum value.
7754         (create_array_type_with_stride): Add byte_stride_prop parameter.
7755         * gdbtypes.c (create_array_type_with_stride) <byte_stride_prop>:
7756         New parameter.  Update all callers in this file.
7757         (array_type_has_dynamic_stride): New function.
7758         (is_dynamic_type_internal, resolve_dynamic_array): Add handling
7759         of arrays with dynamic byte strides.
7760         * dwarf2read.c (read_array_type): Add support for dynamic
7761         DW_AT_byte_stride attributes.
7762
7763 2018-01-02  Joel Brobecker  <brobecker@adacore.com>
7764
7765         * dwarf2read.c (read_unspecified_type): Treat
7766         DW_TAG_enumeration_type DIEs from Ada units as stubs.
7767
7768 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7769
7770         Update copyright year range in all GDB files.
7771
7772 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7773
7774         * copyright.py (BY_HAND): Remove gdb/testsuite/gdb.base/step-line.inp
7775         and gdb/testsuite/gdb.base/step-line.c.
7776
7777 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7778
7779         * copyright.py (main): Dump the contents of
7780         MULTIPLE_COPYRIGHT_HEADERS (separately) from BY_HAND,
7781         even if BY_HAND is empty.
7782
7783 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7784
7785         * top.c (print_gdb_version): Update Copyright year in version
7786         message.
7787
7788 2018-01-01  Joel Brobecker  <brobecker@adacore.com>
7789
7790         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2017.
7791
7792 For older changes see ChangeLog-2017.
7793 \f
7794 Local Variables:
7795 mode: change-log
7796 left-margin: 8
7797 fill-column: 74
7798 version-control: never
7799 coding: utf-8
7800 End: