Fix "list" when control characters are seen
[external/binutils.git] / gdb / ChangeLog
1 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2
3         PR symtab/24423:
4         * source.c (print_source_lines_base): Advance "iter" when a
5         control character is seen.
6
7 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8
9         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
10         close to the add_com "shell".
11
12 2019-04-18  Tom Tromey  <tromey@adacore.com>
13
14         * process-stratum-target.h (class process_stratum_target)
15         <stratum>: Add "final".
16
17 2019-04-17  Tom Tromey  <tromey@adacore.com>
18
19         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
20         against nullptr before use.
21
22 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
23
24         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
25
26 2019-04-17  Jim Wilson  <jimw@sifive.com>
27             Andrew Burgess  <andrew.burgess@embecosm.com>
28
29         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
30         code read might fail, assume 4-byte breakpoint in that case.
31
32 2019-04-15  Leszek Swirski  <leszeks@google.com>
33
34         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
35         rather than a hand-rolled POD check when checking for forced MEMORY
36         classification.
37
38 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
39
40         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
41         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
42         function.
43         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
44         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
45         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
46         declaration.
47
48 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
49
50         * aarch64-linux-nat.c
51         (aarch64_linux_nat_target::thread_architecture): Add override.
52         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
53         each VQ.
54
55 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
56
57         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
58
59 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
60
61         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
62         target types of size 96-bits, add some additional comments, and
63         check that the builtin type we found was the correct size.
64
65 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
66
67         * utils.c (prompt_for_continue): Don't restore the styling at the
68         end, as applied_style has the wrong value.  This fixes styling in
69         long lists of file names that are interrupted by the "Continue?"
70         prompt.
71
72 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
73
74         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
75         * c-lang.c (c_language_defn): Likewise.
76         (cplus_language_defn): Likewise.
77         (asm_language_defn): Likewise.
78         (minimal_language_defn): Likewise.
79         * d-lang.c (d_language_defn): Likewise.
80         * f-lang.c (f_language_defn): Likewise.
81         * go-lang.c (go_language_defn): Likewise.
82         * language.c (unknown_language_defn): Likewise.
83         (auto_language_defn): Likewise.
84         * language.h (struct language_defn): Remove la_magic field.
85         (LANG_MAGIC): Delete.
86         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
87         * objc-lang.c (objc_language_defn): Likewise.
88         * opencl-lang.c (opencl_language_defn): Likewise.
89         * p-lang.c (pascal_language_defn): Likewise.
90         * rust-lang.c (rust_language_defn): Likewise.
91
92 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
93
94         * riscv-tdep.c (riscv_type_align): New function.
95         (riscv_type_alignment): Delete.
96         (riscv_arg_location): Use 'type_align'.
97         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
98
99 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
100
101         * gdbtypes.c (type_align): A struct with no non-static fields also
102         has alignment of 1.
103
104 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
105
106         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
107         component to 0.
108         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
109         member.
110         (riscv_struct_info::analyse): New implementation using new
111         analyse_inner member function.
112         (riscv_struct_info::field_offset): New member function.
113         (riscv_struct_info::m_offsets): New member variable.
114         (riscv_struct_info::analyse_inner): New private member function,
115         takes the old implementation of riscv_struct_info::analyse but
116         extended to track field offsets.
117         (riscv_call_arg_struct): Update the struct folding special cases
118         to handle cases where empty C++ structs, which are non-zero
119         length, are found.
120         (riscv_arg_location): Initialise the length of each location, a
121         non-zero length now indicates the location is in use.
122         (riscv_push_dummy_call): Allow for the first location having a
123         non-zero offset when setting up arguments.
124         (riscv_return_value): Likewise, but for return values.
125
126 2019-04-11  Tom Tromey  <tromey@adacore.com>
127
128         * utils.c (internal_vproblem): Make "msg" const.
129
130 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
131
132         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
133         * trad-frame.c (trad_frame_reset_saved_regs): New function.
134         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
135         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
136
137 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
138
139         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
140         function.
141         (fill_gregset): Call amd64_linux_collect_native_gregset instead
142         of amd64_collect_native_gregset.
143         (amd64_linux_nat_target::store_registers): Likewise.
144
145 2019-04-10  Tom Tromey  <tom@tromey.com>
146
147         * symtab.c (lookup_global_symbol_from_objfile)
148         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
149         * objfiles.h (class separate_debug_iterator): New.
150         (class separate_debug_range): New.
151         (struct objfile) <separate_debug_objfiles>: New method.
152         (objfile_separate_debug_iterate): Don't declare.
153         * objfiles.c (separate_debug_iterator::operator++): Rename from
154         objfile_separate_debug_iterate.
155         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
156         iterator.
157         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
158         iterator.
159
160 2019-04-10  Tom Tromey  <tom@tromey.com>
161
162         * symfile.c (reread_symbols): Remove old comment.
163         * objfiles.c (free_all_objfiles): Fix a typo.
164
165 2019-04-10  Tom Tromey  <tom@tromey.com>
166
167         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
168         * minsyms.c (lookup_minimal_symbol): Use foreach.
169         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
170         (lookup_minimal_symbol_solib_trampoline): Likewise.
171         * symfile.c (reread_symbols): Use foreach.
172
173 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
174             Tom Tromey  <tromey@adacore.com>
175
176         PR rust/24414:
177         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
178         (rust_lex_int_test): Change "value" to be LONGEST.
179         (rust_lex_tests): Add test for long integer literal.
180
181 2019-04-09  Tom Tromey  <tromey@adacore.com>
182
183         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
184         to bool.
185         (extended_remote_target::attach): Update.
186         (remote_target::remote_notice_new_inferior): Update.
187         (remote_target::add_current_inferior_and_thread): Update.
188         * inferior.c (exit_inferior_1): Use "false".
189         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
190
191 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
192
193         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
194         the "start" command.
195
196 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
197
198         * python/py-inferior.c (infpy_thread_from_thread_handle):
199         Adjust comments to reflect renaming of thread_from_thread_handle
200         to thread_from_handle.  Adjust keywords.  Fix type error message.
201         (inferior_object_methods): Add thread_from_handle.  Retain
202         thread_from_thread_handle, but mark it as deprecated.
203
204 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
205
206         * gdbthread.h (find_thread_by_handle): Revise declaration.
207         * thread.c (find_thread_by_handle): Likewise.  Adjust
208         implementation too.
209         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
210         support for buffer objects as handles.
211
212 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
213
214         * python/py-infthread.c (thpy_thread_handle): New function.
215         (thread_object_methods): Register thpy_thread_handle.
216
217 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
218
219         * gdbthread.h (thread_to_thread_handle): Declare.
220         * thread.c (gdbtypes.h): Include.
221         (thread_to_thread_handle): New function.
222
223         * target.h (struct target_ops): Add thread_info_to_thread_handle.
224         (target_thread_info_to_thread_handle): Declare.
225         * target.c (target_thread_info_to_thread_handle): New function.
226         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
227         * target-delegates.c: Regenerate.
228
229         * linux-thread-db.c (class thread_db_target): Add method
230         thread_info_to_thread_handle.
231         (thread_db_target::thread_info_to_thread_handle): Define.
232         * remote.c (class remote_target): Add new method
233         thread_info_to_thread_handle.
234         (remote_target::thread_info_to_thread_handle): Define.
235
236 2019-04-08  Pedro Alves  <palves@redhat.com>
237
238         * common/common-exceptions.c (throw_exception): Don't create
239         named object to throw; throw directly.
240         (throw_it): Likewise.  Don't initialize gdb_exception::message
241         here, with new; pass FMT and AP to the ctor instead.
242         * common/common-exceptions.h: Include <string>.
243         (gdb_exception::gdb_exception(enum return_reason, enum errors,
244         const char *, va_list)): New ctor.  Use std::make_shared.
245         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
246         errors)): Delete.
247         (gdb_exception_error::gdb_exception_error(enum errors, const char
248         *, va_list)): New.
249         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
250         Add assertion.
251         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
252         errors)): Delete.
253         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
254         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
255         Add assertion.
256
257 2019-04-08  Tom Tromey  <tom@tromey.com>
258
259         * valops.c (value_rtti_indirect_type): Replace throw_exception
260         with throw.
261         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
262         with throw.
263         * thread.c (thr_try_catch_cmd): Replace throw_exception with
264         throw.
265         * target.c (target_translate_tls_address): Replace throw_exception
266         with throw.
267         * stack.c (frame_apply_command_count): Replace throw_exception
268         with throw.
269         * solib-spu.c (append_ocl_sos): Replace throw_exception with
270         throw.
271         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
272         with throw.
273         * rs6000-tdep.c (rs6000_frame_cache)
274         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
275         * remote.c: Replace throw_exception with throw.
276         * record-full.c (record_full_message, record_full_wait_1)
277         (record_full_restore): Replace throw_exception with throw.
278         * record-btrace.c:
279         (get_thread_current_frame_id, record_btrace_start_replaying)
280         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
281         (cmd_record_btrace_start): Replace throw_exception with throw.
282         * parse.c (parse_exp_in_context_1): Replace throw_exception with
283         throw.
284         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
285         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
286         * linespec.c:
287         (find_linespec_symbols): Replace throw_exception with throw.
288         * infrun.c (displaced_step_prepare, resume): Replace
289         throw_exception with throw.
290         * infcmd.c (post_create_inferior): Replace throw_exception with
291         throw.
292         * inf-loop.c (inferior_event_handler): Replace throw_exception
293         with throw.
294         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
295         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
296         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
297         (get_prev_frame_always, get_frame_pc_if_available)
298         (get_frame_address_in_block_if_available, get_frame_language):
299         Replace throw_exception with throw.
300         * frame-unwind.c (frame_unwind_try_unwinder): Replace
301         throw_exception with throw.
302         * eval.c (fetch_subexp_value, evaluate_var_value)
303         (evaluate_funcall, evaluate_subexp_standard): Replace
304         throw_exception with throw.
305         * dwarf2loc.c (call_site_find_chain)
306         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
307         Replace throw_exception with throw.
308         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
309         with throw.
310         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
311         throw.
312         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
313         * completer.c (complete_line_internal): Replace throw_exception
314         with throw.
315         * compile/compile-object-run.c (compile_object_run): Replace
316         throw_exception with throw.
317         * cli/cli-script.c (process_next_line): Replace throw_exception
318         with throw.
319         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
320         (btrace_enable, btrace_maint_update_pt_packets): Replace
321         throw_exception with throw.
322         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
323         throw_exception with throw.
324         * break-catch-throw.c (re_set_exception_catchpoint): Replace
325         throw_exception with throw.
326         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
327         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
328         * aarch64-tdep.c (aarch64_make_prologue_cache)
329         (aarch64_make_stub_cache): Replace throw_exception with throw.
330
331 2019-04-08  Tom Tromey  <tom@tromey.com>
332
333         * common/common-exceptions.c (throw_exception): Rename from
334         throw_exception_cxx.  Remove old copy.  Make argument const.
335         (throw_it): Create and throw exception objects directly.
336         * common/common-exceptions.h (throw_exception): Make argument
337         const.
338         (struct gdb_exception_error): Add constructor.
339         (struct gdb_exception_quit): Add constructor.
340
341 2019-04-08  Tom Tromey  <tom@tromey.com>
342
343         * common/common-exceptions.h (exception_rethrow): Don't declare.
344         (TRY_SJLJ): Update comment.
345         (TRY, CATCH, END_CATCH): Remove.
346         * common/common-exceptions.c (exception_rethrow): Remove.
347
348 2019-04-08  Tom Tromey  <tom@tromey.com>
349
350         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
351         Remove.
352         (gdb_exception_error): Rename from
353         gdb_exception_RETURN_MASK_ERROR.
354         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
355         (gdb_quit_bad_alloc): Update.
356         * aarch64-tdep.c: Update.
357         * ada-lang.c: Update.
358         * ada-typeprint.c: Update.
359         * ada-valprint.c: Update.
360         * amd64-tdep.c: Update.
361         * arch-utils.c: Update.
362         * break-catch-throw.c: Update.
363         * breakpoint.c: Update.
364         * btrace.c: Update.
365         * c-varobj.c: Update.
366         * cli/cli-cmds.c: Update.
367         * cli/cli-interp.c: Update.
368         * cli/cli-script.c: Update.
369         * common/common-exceptions.c: Update.
370         * common/new-op.c: Update.
371         * common/selftest.c: Update.
372         * compile/compile-c-symbols.c: Update.
373         * compile/compile-cplus-symbols.c: Update.
374         * compile/compile-object-load.c: Update.
375         * compile/compile-object-run.c: Update.
376         * completer.c: Update.
377         * corelow.c: Update.
378         * cp-abi.c: Update.
379         * cp-support.c: Update.
380         * cp-valprint.c: Update.
381         * darwin-nat.c: Update.
382         * disasm-selftests.c: Update.
383         * dtrace-probe.c: Update.
384         * dwarf-index-cache.c: Update.
385         * dwarf-index-write.c: Update.
386         * dwarf2-frame-tailcall.c: Update.
387         * dwarf2-frame.c: Update.
388         * dwarf2loc.c: Update.
389         * dwarf2read.c: Update.
390         * eval.c: Update.
391         * event-loop.c: Update.
392         * event-top.c: Update.
393         * exec.c: Update.
394         * f-valprint.c: Update.
395         * fbsd-tdep.c: Update.
396         * frame-unwind.c: Update.
397         * frame.c: Update.
398         * gdbtypes.c: Update.
399         * gnu-v3-abi.c: Update.
400         * guile/guile-internal.h: Update.
401         * guile/scm-block.c: Update.
402         * guile/scm-breakpoint.c: Update.
403         * guile/scm-cmd.c: Update.
404         * guile/scm-disasm.c: Update.
405         * guile/scm-frame.c: Update.
406         * guile/scm-lazy-string.c: Update.
407         * guile/scm-math.c: Update.
408         * guile/scm-param.c: Update.
409         * guile/scm-ports.c: Update.
410         * guile/scm-pretty-print.c: Update.
411         * guile/scm-symbol.c: Update.
412         * guile/scm-symtab.c: Update.
413         * guile/scm-type.c: Update.
414         * guile/scm-value.c: Update.
415         * i386-linux-tdep.c: Update.
416         * i386-tdep.c: Update.
417         * inf-loop.c: Update.
418         * infcall.c: Update.
419         * infcmd.c: Update.
420         * infrun.c: Update.
421         * jit.c: Update.
422         * language.c: Update.
423         * linespec.c: Update.
424         * linux-fork.c: Update.
425         * linux-nat.c: Update.
426         * linux-tdep.c: Update.
427         * linux-thread-db.c: Update.
428         * main.c: Update.
429         * mi/mi-cmd-break.c: Update.
430         * mi/mi-cmd-stack.c: Update.
431         * mi/mi-interp.c: Update.
432         * mi/mi-main.c: Update.
433         * objc-lang.c: Update.
434         * p-valprint.c: Update.
435         * parse.c: Update.
436         * ppc-linux-tdep.c: Update.
437         * printcmd.c: Update.
438         * python/py-arch.c: Update.
439         * python/py-breakpoint.c: Update.
440         * python/py-cmd.c: Update.
441         * python/py-finishbreakpoint.c: Update.
442         * python/py-frame.c: Update.
443         * python/py-framefilter.c: Update.
444         * python/py-gdb-readline.c: Update.
445         * python/py-inferior.c: Update.
446         * python/py-infthread.c: Update.
447         * python/py-lazy-string.c: Update.
448         * python/py-linetable.c: Update.
449         * python/py-objfile.c: Update.
450         * python/py-param.c: Update.
451         * python/py-prettyprint.c: Update.
452         * python/py-progspace.c: Update.
453         * python/py-record-btrace.c: Update.
454         * python/py-record.c: Update.
455         * python/py-symbol.c: Update.
456         * python/py-type.c: Update.
457         * python/py-unwind.c: Update.
458         * python/py-utils.c: Update.
459         * python/py-value.c: Update.
460         * python/python.c: Update.
461         * record-btrace.c: Update.
462         * record-full.c: Update.
463         * remote-fileio.c: Update.
464         * remote.c: Update.
465         * riscv-tdep.c: Update.
466         * rs6000-aix-tdep.c: Update.
467         * rs6000-tdep.c: Update.
468         * rust-exp.y: Update.
469         * rust-lang.c: Update.
470         * s390-tdep.c: Update.
471         * selftest-arch.c: Update.
472         * solib-dsbt.c: Update.
473         * solib-frv.c: Update.
474         * solib-spu.c: Update.
475         * solib-svr4.c: Update.
476         * solib.c: Update.
477         * sparc64-linux-tdep.c: Update.
478         * stack.c: Update.
479         * symfile-mem.c: Update.
480         * symmisc.c: Update.
481         * target.c: Update.
482         * thread.c: Update.
483         * top.c: Update.
484         * tracefile-tfile.c: Update.
485         * tui/tui.c: Update.
486         * typeprint.c: Update.
487         * unittests/cli-utils-selftests.c: Update.
488         * unittests/parse-connection-spec-selftests.c: Update.
489         * valops.c: Update.
490         * valprint.c: Update.
491         * value.c: Update.
492         * varobj.c: Update.
493         * windows-nat.c: Update.
494         * x86-linux-nat.c: Update.
495         * xml-support.c: Update.
496
497 2019-04-08  Tom Tromey  <tom@tromey.com>
498
499         * xml-support.c: Use C++ exception handling.
500         * x86-linux-nat.c: Use C++ exception handling.
501         * windows-nat.c: Use C++ exception handling.
502         * varobj.c: Use C++ exception handling.
503         * value.c: Use C++ exception handling.
504         * valprint.c: Use C++ exception handling.
505         * valops.c: Use C++ exception handling.
506         * unittests/parse-connection-spec-selftests.c: Use C++ exception
507         handling.
508         * unittests/cli-utils-selftests.c: Use C++ exception handling.
509         * typeprint.c: Use C++ exception handling.
510         * tui/tui.c: Use C++ exception handling.
511         * tracefile-tfile.c: Use C++ exception handling.
512         * top.c: Use C++ exception handling.
513         * thread.c: Use C++ exception handling.
514         * target.c: Use C++ exception handling.
515         * symmisc.c: Use C++ exception handling.
516         * symfile-mem.c: Use C++ exception handling.
517         * stack.c: Use C++ exception handling.
518         * sparc64-linux-tdep.c: Use C++ exception handling.
519         * solib.c: Use C++ exception handling.
520         * solib-svr4.c: Use C++ exception handling.
521         * solib-spu.c: Use C++ exception handling.
522         * solib-frv.c: Use C++ exception handling.
523         * solib-dsbt.c: Use C++ exception handling.
524         * selftest-arch.c: Use C++ exception handling.
525         * s390-tdep.c: Use C++ exception handling.
526         * rust-lang.c: Use C++ exception handling.
527         * rust-exp.y: Use C++ exception handling.
528         * rs6000-tdep.c: Use C++ exception handling.
529         * rs6000-aix-tdep.c: Use C++ exception handling.
530         * riscv-tdep.c: Use C++ exception handling.
531         * remote.c: Use C++ exception handling.
532         * remote-fileio.c: Use C++ exception handling.
533         * record-full.c: Use C++ exception handling.
534         * record-btrace.c: Use C++ exception handling.
535         * python/python.c: Use C++ exception handling.
536         * python/py-value.c: Use C++ exception handling.
537         * python/py-utils.c: Use C++ exception handling.
538         * python/py-unwind.c: Use C++ exception handling.
539         * python/py-type.c: Use C++ exception handling.
540         * python/py-symbol.c: Use C++ exception handling.
541         * python/py-record.c: Use C++ exception handling.
542         * python/py-record-btrace.c: Use C++ exception handling.
543         * python/py-progspace.c: Use C++ exception handling.
544         * python/py-prettyprint.c: Use C++ exception handling.
545         * python/py-param.c: Use C++ exception handling.
546         * python/py-objfile.c: Use C++ exception handling.
547         * python/py-linetable.c: Use C++ exception handling.
548         * python/py-lazy-string.c: Use C++ exception handling.
549         * python/py-infthread.c: Use C++ exception handling.
550         * python/py-inferior.c: Use C++ exception handling.
551         * python/py-gdb-readline.c: Use C++ exception handling.
552         * python/py-framefilter.c: Use C++ exception handling.
553         * python/py-frame.c: Use C++ exception handling.
554         * python/py-finishbreakpoint.c: Use C++ exception handling.
555         * python/py-cmd.c: Use C++ exception handling.
556         * python/py-breakpoint.c: Use C++ exception handling.
557         * python/py-arch.c: Use C++ exception handling.
558         * printcmd.c: Use C++ exception handling.
559         * ppc-linux-tdep.c: Use C++ exception handling.
560         * parse.c: Use C++ exception handling.
561         * p-valprint.c: Use C++ exception handling.
562         * objc-lang.c: Use C++ exception handling.
563         * mi/mi-main.c: Use C++ exception handling.
564         * mi/mi-interp.c: Use C++ exception handling.
565         * mi/mi-cmd-stack.c: Use C++ exception handling.
566         * mi/mi-cmd-break.c: Use C++ exception handling.
567         * main.c: Use C++ exception handling.
568         * linux-thread-db.c: Use C++ exception handling.
569         * linux-tdep.c: Use C++ exception handling.
570         * linux-nat.c: Use C++ exception handling.
571         * linux-fork.c: Use C++ exception handling.
572         * linespec.c: Use C++ exception handling.
573         * language.c: Use C++ exception handling.
574         * jit.c: Use C++ exception handling.
575         * infrun.c: Use C++ exception handling.
576         * infcmd.c: Use C++ exception handling.
577         * infcall.c: Use C++ exception handling.
578         * inf-loop.c: Use C++ exception handling.
579         * i386-tdep.c: Use C++ exception handling.
580         * i386-linux-tdep.c: Use C++ exception handling.
581         * guile/scm-value.c: Use C++ exception handling.
582         * guile/scm-type.c: Use C++ exception handling.
583         * guile/scm-symtab.c: Use C++ exception handling.
584         * guile/scm-symbol.c: Use C++ exception handling.
585         * guile/scm-pretty-print.c: Use C++ exception handling.
586         * guile/scm-ports.c: Use C++ exception handling.
587         * guile/scm-param.c: Use C++ exception handling.
588         * guile/scm-math.c: Use C++ exception handling.
589         * guile/scm-lazy-string.c: Use C++ exception handling.
590         * guile/scm-frame.c: Use C++ exception handling.
591         * guile/scm-disasm.c: Use C++ exception handling.
592         * guile/scm-cmd.c: Use C++ exception handling.
593         * guile/scm-breakpoint.c: Use C++ exception handling.
594         * guile/scm-block.c: Use C++ exception handling.
595         * guile/guile-internal.h: Use C++ exception handling.
596         * gnu-v3-abi.c: Use C++ exception handling.
597         * gdbtypes.c: Use C++ exception handling.
598         * frame.c: Use C++ exception handling.
599         * frame-unwind.c: Use C++ exception handling.
600         * fbsd-tdep.c: Use C++ exception handling.
601         * f-valprint.c: Use C++ exception handling.
602         * exec.c: Use C++ exception handling.
603         * event-top.c: Use C++ exception handling.
604         * event-loop.c: Use C++ exception handling.
605         * eval.c: Use C++ exception handling.
606         * dwarf2read.c: Use C++ exception handling.
607         * dwarf2loc.c: Use C++ exception handling.
608         * dwarf2-frame.c: Use C++ exception handling.
609         * dwarf2-frame-tailcall.c: Use C++ exception handling.
610         * dwarf-index-write.c: Use C++ exception handling.
611         * dwarf-index-cache.c: Use C++ exception handling.
612         * dtrace-probe.c: Use C++ exception handling.
613         * disasm-selftests.c: Use C++ exception handling.
614         * darwin-nat.c: Use C++ exception handling.
615         * cp-valprint.c: Use C++ exception handling.
616         * cp-support.c: Use C++ exception handling.
617         * cp-abi.c: Use C++ exception handling.
618         * corelow.c: Use C++ exception handling.
619         * completer.c: Use C++ exception handling.
620         * compile/compile-object-run.c: Use C++ exception handling.
621         * compile/compile-object-load.c: Use C++ exception handling.
622         * compile/compile-cplus-symbols.c: Use C++ exception handling.
623         * compile/compile-c-symbols.c: Use C++ exception handling.
624         * common/selftest.c: Use C++ exception handling.
625         * common/new-op.c: Use C++ exception handling.
626         * cli/cli-script.c: Use C++ exception handling.
627         * cli/cli-interp.c: Use C++ exception handling.
628         * cli/cli-cmds.c: Use C++ exception handling.
629         * c-varobj.c: Use C++ exception handling.
630         * btrace.c: Use C++ exception handling.
631         * breakpoint.c: Use C++ exception handling.
632         * break-catch-throw.c: Use C++ exception handling.
633         * arch-utils.c: Use C++ exception handling.
634         * amd64-tdep.c: Use C++ exception handling.
635         * ada-valprint.c: Use C++ exception handling.
636         * ada-typeprint.c: Use C++ exception handling.
637         * ada-lang.c: Use C++ exception handling.
638         * aarch64-tdep.c: Use C++ exception handling.
639
640 2019-04-08  Tom Tromey  <tom@tromey.com>
641
642         * xml-support.c (gdb_xml_parser::parse): Update.
643         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
644         * value.c (show_convenience): Update.
645         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
646         (test_parse_flags_qcs): Update.
647         * thread.c (thr_try_catch_cmd): Update.
648         * target.c (target_translate_tls_address): Update.
649         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
650         (info_frame_command_core, frame_apply_command_count): Update.
651         * rust-exp.y (rust_lex_exception_test): Update.
652         * riscv-tdep.c (riscv_print_one_register_info): Update.
653         * remote.c (remote_target::enable_btrace): Update.
654         * record-btrace.c (record_btrace_enable_warn): Update.
655         * python/py-utils.c (gdbpy_convert_exception): Update.
656         * printcmd.c (do_one_display, print_variable_and_value): Update.
657         * mi/mi-main.c (mi_print_exception): Update.
658         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
659         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
660         * linux-nat.c (linux_nat_target::attach): Update.
661         * linux-fork.c (class scoped_switch_fork_info): Update.
662         * infrun.c (displaced_step_prepare): Update.
663         * infcall.c (call_function_by_hand_dummy): Update.
664         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
665         * gnu-v3-abi.c (print_one_vtable): Update.
666         * frame.c (get_prev_frame_always): Update.
667         * f-valprint.c (info_common_command_for_block): Update.
668         * exec.c (try_open_exec_file): Update.
669         * exceptions.c (print_exception, exception_print)
670         (exception_fprintf, exception_print_same): Update.
671         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
672         * dwarf-index-cache.c (index_cache::store)
673         (index_cache::lookup_gdb_index): Update.
674         * darwin-nat.c (maybe_cache_shell): Update.
675         * cp-valprint.c (cp_print_value_fields): Update.
676         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
677         (gcc_cplus_symbol_address): Update.
678         * compile/compile-c-symbols.c (gcc_convert_symbol)
679         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
680         * common/selftest.c: Update.
681         * common/common-exceptions.h (struct gdb_exception) <message>: Now
682         a std::string.
683         (exception_try_scope_entry, exception_try_scope_exit): Don't
684         declare.
685         (struct exception_try_scope): Remove.
686         (TRY): Don't use exception_try_scope.
687         (struct gdb_exception): Add constructor, operator=.
688         <what>: New method.
689         (struct gdb_exception_RETURN_MASK_ALL)
690         (struct gdb_exception_RETURN_MASK_ERROR)
691         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
692         (struct gdb_quit_bad_alloc): Update.
693         * common/common-exceptions.c (exception_none): Change
694         initializer.
695         (struct catcher) <state, exception>: Initialize inline.
696         <prev>: Remove member.
697         (current_catcher): Remove.
698         (catchers): New global.
699         (exceptions_state_mc_init): Simplify.
700         (catcher_pop): Remove.
701         (exceptions_state_mc, exceptions_state_mc_catch): Update.
702         (try_scope_depth, exception_try_scope_entry)
703         (exception_try_scope_exit): Remove.
704         (throw_exception_sjlj): Update.
705         (exception_messages, exception_messages_size): Remove.
706         (throw_it): Simplify.
707         (gdb_exception_sliced_copy): Remove.
708         (throw_exception_cxx): Update.
709         * cli/cli-script.c (script_from_file): Update.
710         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
711         Update.
712         * ada-valprint.c (ada_val_print): Update.
713         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
714         (create_excep_cond_exprs): Update.
715
716 2019-04-08  Tom Tromey  <tom@tromey.com>
717
718         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
719         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
720         (TRY, CATCH, END_CATCH): Remove some definitions.
721         * common/common-exceptions.c: Don't use GDB_XCPT.
722         (catcher_list_size): Remove.
723         (throw_exception, throw_it): Simplify.
724
725 2019-04-05  Tom Tromey  <tom@tromey.com>
726
727         Revert the header-sorting patch.
728         * ft32-tdep.c: Revert.
729         * frv-tdep.c: Revert.
730         * frv-linux-tdep.c: Revert.
731         * frame.c: Revert.
732         * frame-unwind.c: Revert.
733         * frame-base.c: Revert.
734         * fork-child.c: Revert.
735         * findvar.c: Revert.
736         * findcmd.c: Revert.
737         * filesystem.c: Revert.
738         * filename-seen-cache.h: Revert.
739         * filename-seen-cache.c: Revert.
740         * fbsd-tdep.c: Revert.
741         * fbsd-nat.h: Revert.
742         * fbsd-nat.c: Revert.
743         * f-valprint.c: Revert.
744         * f-typeprint.c: Revert.
745         * f-lang.c: Revert.
746         * extension.h: Revert.
747         * extension.c: Revert.
748         * extension-priv.h: Revert.
749         * expprint.c: Revert.
750         * exec.h: Revert.
751         * exec.c: Revert.
752         * exceptions.c: Revert.
753         * event-top.c: Revert.
754         * event-loop.c: Revert.
755         * eval.c: Revert.
756         * elfread.c: Revert.
757         * dwarf2read.h: Revert.
758         * dwarf2read.c: Revert.
759         * dwarf2loc.c: Revert.
760         * dwarf2expr.h: Revert.
761         * dwarf2expr.c: Revert.
762         * dwarf2-frame.c: Revert.
763         * dwarf2-frame-tailcall.c: Revert.
764         * dwarf-index-write.h: Revert.
765         * dwarf-index-write.c: Revert.
766         * dwarf-index-common.c: Revert.
767         * dwarf-index-cache.h: Revert.
768         * dwarf-index-cache.c: Revert.
769         * dummy-frame.c: Revert.
770         * dtrace-probe.c: Revert.
771         * disasm.h: Revert.
772         * disasm.c: Revert.
773         * disasm-selftests.c: Revert.
774         * dictionary.c: Revert.
775         * dicos-tdep.c: Revert.
776         * demangle.c: Revert.
777         * dcache.h: Revert.
778         * dcache.c: Revert.
779         * darwin-nat.h: Revert.
780         * darwin-nat.c: Revert.
781         * darwin-nat-info.c: Revert.
782         * d-valprint.c: Revert.
783         * d-namespace.c: Revert.
784         * d-lang.c: Revert.
785         * ctf.c: Revert.
786         * csky-tdep.c: Revert.
787         * csky-linux-tdep.c: Revert.
788         * cris-tdep.c: Revert.
789         * cris-linux-tdep.c: Revert.
790         * cp-valprint.c: Revert.
791         * cp-support.c: Revert.
792         * cp-namespace.c: Revert.
793         * cp-abi.c: Revert.
794         * corelow.c: Revert.
795         * corefile.c: Revert.
796         * continuations.c: Revert.
797         * completer.h: Revert.
798         * completer.c: Revert.
799         * complaints.c: Revert.
800         * coffread.c: Revert.
801         * coff-pe-read.c: Revert.
802         * cli-out.h: Revert.
803         * cli-out.c: Revert.
804         * charset.c: Revert.
805         * c-varobj.c: Revert.
806         * c-valprint.c: Revert.
807         * c-typeprint.c: Revert.
808         * c-lang.c: Revert.
809         * buildsym.c: Revert.
810         * buildsym-legacy.c: Revert.
811         * build-id.h: Revert.
812         * build-id.c: Revert.
813         * btrace.c: Revert.
814         * bsd-uthread.c: Revert.
815         * breakpoint.h: Revert.
816         * breakpoint.c: Revert.
817         * break-catch-throw.c: Revert.
818         * break-catch-syscall.c: Revert.
819         * break-catch-sig.c: Revert.
820         * blockframe.c: Revert.
821         * block.c: Revert.
822         * bfin-tdep.c: Revert.
823         * bfin-linux-tdep.c: Revert.
824         * bfd-target.c: Revert.
825         * bcache.c: Revert.
826         * ax-general.c: Revert.
827         * ax-gdb.h: Revert.
828         * ax-gdb.c: Revert.
829         * avr-tdep.c: Revert.
830         * auxv.c: Revert.
831         * auto-load.c: Revert.
832         * arm-wince-tdep.c: Revert.
833         * arm-tdep.c: Revert.
834         * arm-symbian-tdep.c: Revert.
835         * arm-pikeos-tdep.c: Revert.
836         * arm-obsd-tdep.c: Revert.
837         * arm-nbsd-tdep.c: Revert.
838         * arm-nbsd-nat.c: Revert.
839         * arm-linux-tdep.c: Revert.
840         * arm-linux-nat.c: Revert.
841         * arm-fbsd-tdep.c: Revert.
842         * arm-fbsd-nat.c: Revert.
843         * arm-bsd-tdep.c: Revert.
844         * arch-utils.c: Revert.
845         * arc-tdep.c: Revert.
846         * arc-newlib-tdep.c: Revert.
847         * annotate.h: Revert.
848         * annotate.c: Revert.
849         * amd64-windows-tdep.c: Revert.
850         * amd64-windows-nat.c: Revert.
851         * amd64-tdep.c: Revert.
852         * amd64-sol2-tdep.c: Revert.
853         * amd64-obsd-tdep.c: Revert.
854         * amd64-obsd-nat.c: Revert.
855         * amd64-nbsd-tdep.c: Revert.
856         * amd64-nbsd-nat.c: Revert.
857         * amd64-nat.c: Revert.
858         * amd64-linux-tdep.c: Revert.
859         * amd64-linux-nat.c: Revert.
860         * amd64-fbsd-tdep.c: Revert.
861         * amd64-fbsd-nat.c: Revert.
862         * amd64-dicos-tdep.c: Revert.
863         * amd64-darwin-tdep.c: Revert.
864         * amd64-bsd-nat.c: Revert.
865         * alpha-tdep.c: Revert.
866         * alpha-obsd-tdep.c: Revert.
867         * alpha-nbsd-tdep.c: Revert.
868         * alpha-mdebug-tdep.c: Revert.
869         * alpha-linux-tdep.c: Revert.
870         * alpha-linux-nat.c: Revert.
871         * alpha-bsd-tdep.c: Revert.
872         * alpha-bsd-nat.c: Revert.
873         * aix-thread.c: Revert.
874         * agent.c: Revert.
875         * addrmap.c: Revert.
876         * ada-varobj.c: Revert.
877         * ada-valprint.c: Revert.
878         * ada-typeprint.c: Revert.
879         * ada-tasks.c: Revert.
880         * ada-lang.c: Revert.
881         * aarch64-tdep.c: Revert.
882         * aarch64-ravenscar-thread.c: Revert.
883         * aarch64-newlib-tdep.c: Revert.
884         * aarch64-linux-tdep.c: Revert.
885         * aarch64-linux-nat.c: Revert.
886         * aarch64-fbsd-tdep.c: Revert.
887         * aarch64-fbsd-nat.c: Revert.
888         * aarch32-linux-nat.c: Revert.
889
890 2019-04-05  Tom Tromey  <tom@tromey.com>
891
892         * ft32-tdep.c: Sort headers.
893         * frv-tdep.c: Sort headers.
894         * frv-linux-tdep.c: Sort headers.
895         * frame.c: Sort headers.
896         * frame-unwind.c: Sort headers.
897         * frame-base.c: Sort headers.
898         * fork-child.c: Sort headers.
899         * findvar.c: Sort headers.
900         * findcmd.c: Sort headers.
901         * filesystem.c: Sort headers.
902         * filename-seen-cache.h: Sort headers.
903         * filename-seen-cache.c: Sort headers.
904         * fbsd-tdep.c: Sort headers.
905         * fbsd-nat.h: Sort headers.
906         * fbsd-nat.c: Sort headers.
907         * f-valprint.c: Sort headers.
908         * f-typeprint.c: Sort headers.
909         * f-lang.c: Sort headers.
910         * extension.h: Sort headers.
911         * extension.c: Sort headers.
912         * extension-priv.h: Sort headers.
913         * expprint.c: Sort headers.
914         * exec.h: Sort headers.
915         * exec.c: Sort headers.
916         * exceptions.c: Sort headers.
917         * event-top.c: Sort headers.
918         * event-loop.c: Sort headers.
919         * eval.c: Sort headers.
920         * elfread.c: Sort headers.
921         * dwarf2read.h: Sort headers.
922         * dwarf2read.c: Sort headers.
923         * dwarf2loc.c: Sort headers.
924         * dwarf2expr.h: Sort headers.
925         * dwarf2expr.c: Sort headers.
926         * dwarf2-frame.c: Sort headers.
927         * dwarf2-frame-tailcall.c: Sort headers.
928         * dwarf-index-write.h: Sort headers.
929         * dwarf-index-write.c: Sort headers.
930         * dwarf-index-common.c: Sort headers.
931         * dwarf-index-cache.h: Sort headers.
932         * dwarf-index-cache.c: Sort headers.
933         * dummy-frame.c: Sort headers.
934         * dtrace-probe.c: Sort headers.
935         * disasm.h: Sort headers.
936         * disasm.c: Sort headers.
937         * disasm-selftests.c: Sort headers.
938         * dictionary.c: Sort headers.
939         * dicos-tdep.c: Sort headers.
940         * demangle.c: Sort headers.
941         * dcache.h: Sort headers.
942         * dcache.c: Sort headers.
943         * darwin-nat.h: Sort headers.
944         * darwin-nat.c: Sort headers.
945         * darwin-nat-info.c: Sort headers.
946         * d-valprint.c: Sort headers.
947         * d-namespace.c: Sort headers.
948         * d-lang.c: Sort headers.
949         * ctf.c: Sort headers.
950         * csky-tdep.c: Sort headers.
951         * csky-linux-tdep.c: Sort headers.
952         * cris-tdep.c: Sort headers.
953         * cris-linux-tdep.c: Sort headers.
954         * cp-valprint.c: Sort headers.
955         * cp-support.c: Sort headers.
956         * cp-namespace.c: Sort headers.
957         * cp-abi.c: Sort headers.
958         * corelow.c: Sort headers.
959         * corefile.c: Sort headers.
960         * continuations.c: Sort headers.
961         * completer.h: Sort headers.
962         * completer.c: Sort headers.
963         * complaints.c: Sort headers.
964         * coffread.c: Sort headers.
965         * coff-pe-read.c: Sort headers.
966         * cli-out.h: Sort headers.
967         * cli-out.c: Sort headers.
968         * charset.c: Sort headers.
969         * c-varobj.c: Sort headers.
970         * c-valprint.c: Sort headers.
971         * c-typeprint.c: Sort headers.
972         * c-lang.c: Sort headers.
973         * buildsym.c: Sort headers.
974         * buildsym-legacy.c: Sort headers.
975         * build-id.h: Sort headers.
976         * build-id.c: Sort headers.
977         * btrace.c: Sort headers.
978         * bsd-uthread.c: Sort headers.
979         * breakpoint.h: Sort headers.
980         * breakpoint.c: Sort headers.
981         * break-catch-throw.c: Sort headers.
982         * break-catch-syscall.c: Sort headers.
983         * break-catch-sig.c: Sort headers.
984         * blockframe.c: Sort headers.
985         * block.c: Sort headers.
986         * bfin-tdep.c: Sort headers.
987         * bfin-linux-tdep.c: Sort headers.
988         * bfd-target.c: Sort headers.
989         * bcache.c: Sort headers.
990         * ax-general.c: Sort headers.
991         * ax-gdb.h: Sort headers.
992         * ax-gdb.c: Sort headers.
993         * avr-tdep.c: Sort headers.
994         * auxv.c: Sort headers.
995         * auto-load.c: Sort headers.
996         * arm-wince-tdep.c: Sort headers.
997         * arm-tdep.c: Sort headers.
998         * arm-symbian-tdep.c: Sort headers.
999         * arm-pikeos-tdep.c: Sort headers.
1000         * arm-obsd-tdep.c: Sort headers.
1001         * arm-nbsd-tdep.c: Sort headers.
1002         * arm-nbsd-nat.c: Sort headers.
1003         * arm-linux-tdep.c: Sort headers.
1004         * arm-linux-nat.c: Sort headers.
1005         * arm-fbsd-tdep.c: Sort headers.
1006         * arm-fbsd-nat.c: Sort headers.
1007         * arm-bsd-tdep.c: Sort headers.
1008         * arch-utils.c: Sort headers.
1009         * arc-tdep.c: Sort headers.
1010         * arc-newlib-tdep.c: Sort headers.
1011         * annotate.h: Sort headers.
1012         * annotate.c: Sort headers.
1013         * amd64-windows-tdep.c: Sort headers.
1014         * amd64-windows-nat.c: Sort headers.
1015         * amd64-tdep.c: Sort headers.
1016         * amd64-sol2-tdep.c: Sort headers.
1017         * amd64-obsd-tdep.c: Sort headers.
1018         * amd64-obsd-nat.c: Sort headers.
1019         * amd64-nbsd-tdep.c: Sort headers.
1020         * amd64-nbsd-nat.c: Sort headers.
1021         * amd64-nat.c: Sort headers.
1022         * amd64-linux-tdep.c: Sort headers.
1023         * amd64-linux-nat.c: Sort headers.
1024         * amd64-fbsd-tdep.c: Sort headers.
1025         * amd64-fbsd-nat.c: Sort headers.
1026         * amd64-dicos-tdep.c: Sort headers.
1027         * amd64-darwin-tdep.c: Sort headers.
1028         * amd64-bsd-nat.c: Sort headers.
1029         * alpha-tdep.c: Sort headers.
1030         * alpha-obsd-tdep.c: Sort headers.
1031         * alpha-nbsd-tdep.c: Sort headers.
1032         * alpha-mdebug-tdep.c: Sort headers.
1033         * alpha-linux-tdep.c: Sort headers.
1034         * alpha-linux-nat.c: Sort headers.
1035         * alpha-bsd-tdep.c: Sort headers.
1036         * alpha-bsd-nat.c: Sort headers.
1037         * aix-thread.c: Sort headers.
1038         * agent.c: Sort headers.
1039         * addrmap.c: Sort headers.
1040         * ada-varobj.c: Sort headers.
1041         * ada-valprint.c: Sort headers.
1042         * ada-typeprint.c: Sort headers.
1043         * ada-tasks.c: Sort headers.
1044         * ada-lang.c: Sort headers.
1045         * aarch64-tdep.c: Sort headers.
1046         * aarch64-ravenscar-thread.c: Sort headers.
1047         * aarch64-newlib-tdep.c: Sort headers.
1048         * aarch64-linux-tdep.c: Sort headers.
1049         * aarch64-linux-nat.c: Sort headers.
1050         * aarch64-fbsd-tdep.c: Sort headers.
1051         * aarch64-fbsd-nat.c: Sort headers.
1052         * aarch32-linux-nat.c: Sort headers.
1053
1054 2019-04-04  Tom Tromey  <tom@tromey.com>
1055
1056         * varobj.c (varobj_create): Update.
1057         * rust-exp.y (struct rust_parser) <update_innermost_block,
1058         lookup_symbol>: New methods.
1059         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1060         Rename.
1061         (rust_parser::rust_lookup_type)
1062         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1063         * printcmd.c (display_command, do_one_display): Update.
1064         * parser-defs.h (struct parser_state) <parser_state>: Add
1065         "tracker" parameter.
1066         (block_tracker): New member.
1067         (class innermost_block_tracker) <innermost_block_tracker>: Add
1068         "types" parameter.
1069         <reset>: Remove method.
1070         (innermost_block): Don't declare.
1071         (null_post_parser): Update.
1072         * parse.c (innermost_block): Remove global.
1073         (write_dollar_variable): Update.
1074         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1075         Remove "tracker_types" parameter.
1076         (parse_expression): Add "tracker" parameter.
1077         (parse_expression_for_completion): Update.
1078         (null_post_parser): Add "tracker" parameter.
1079         * p-exp.y: Update rules.
1080         * m2-exp.y: Update rules.
1081         * language.h (struct language_defn) <la_post_parser>: Add
1082         "tracker" parameter.
1083         * go-exp.y: Update rules.
1084         * f-exp.y: Update rules.
1085         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1086         parameter.
1087         * d-exp.y: Update rules.
1088         * c-exp.y: Update rules.
1089         * breakpoint.c (set_breakpoint_condition): Create an
1090         innermost_block_tracker.
1091         (watch_command_1): Likewise.
1092         * ada-lang.c (resolve): Add "tracker" parameter.
1093         (resolve_subexp): Likewise.
1094         * ada-exp.y (write_var_from_sym): Update.
1095
1096 2019-04-04  Tom Tromey  <tom@tromey.com>
1097
1098         * type-stack.h: New file.
1099         * type-stack.c: New file.
1100         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1101         type-stack.h.
1102         (insert_into_type_stack, insert_type, push_type, push_type_int)
1103         (insert_type_address_space, pop_type, pop_type_int)
1104         (pop_typelist, pop_type_stack, append_type_stack)
1105         (push_type_stack, get_type_stack, push_typelist)
1106         (follow_type_instance_flags, follow_types): Don't declare.
1107         * parse.c (type_stack): Remove global.
1108         (parse_exp_in_context): Update.
1109         (insert_into_type_stack, insert_type, push_type, push_type_int)
1110         (insert_type_address_space, pop_type, pop_type_int)
1111         (pop_typelist, pop_type_stack, append_type_stack)
1112         (push_type_stack, get_type_stack, push_typelist)
1113         (follow_type_instance_flags, follow_types): Remove (moved to
1114         type-stack.c).
1115         * f-exp.y (type_stack): New global.
1116         Update rules.
1117         (push_kind_type, f_parse): Update.
1118         * d-exp.y (type_stack): New global.
1119         Update rules.
1120         (d_parse): Update.
1121         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1122         Update rules.
1123         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1124         (HFILES_NO_SRCDIR): Add type-stack.h.
1125
1126 2019-04-04  Tom Tromey  <tom@tromey.com>
1127
1128         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1129         (rust_parser::convert_ast_to_expression, rust_parse)
1130         (rust_lex_test_completion, rust_lex_tests): Update.
1131         * parser-defs.h (struct expr_completion_state): New.
1132         (struct parser_state) <parser_state>: Add completion parameter.
1133         <mark_struct_expression, mark_completion_tag>: New methods.
1134         <parse_completion, m_completion_state>: New members.
1135         (prefixify_expression, null_post_parser): Update.
1136         (mark_struct_expression, mark_completion_tag): Don't declare.
1137         * parse.c (parse_completion, expout_last_struct)
1138         (expout_tag_completion_type, expout_completion_name): Remove
1139         globals.
1140         (parser_state::mark_struct_expression)
1141         (parser_state::mark_completion_tag): Now methods.
1142         (prefixify_expression): Add last_struct parameter.
1143         (prefixify_subexp): Likewise.
1144         (parse_exp_1): Update.
1145         (parse_exp_in_context): Add cstate parameter.  Update.
1146         (parse_expression_for_completion): Create an
1147         expr_completion_state.
1148         (null_post_parser): Add "completion" parameter.
1149         * p-exp.y: Update rules.
1150         (yylex): Update.
1151         * language.h (struct language_defn) <la_post_parser>: Add
1152         "completing" parameter.
1153         * go-exp.y: Update rules.
1154         (lex_one_token): Update.
1155         * expression.h (parse_completion): Don't declare.
1156         * d-exp.y: Update rules.
1157         (lex_one_token): Update rules.
1158         * c-exp.y: Update rules.
1159         (lex_one_token): Update.
1160         * ada-lang.c (resolve): Add "parse_completion" parameter.
1161         (resolve_subexp): Likewise.
1162         (ada_resolve_function): Likewise.
1163
1164 2019-04-04  Tom Tromey  <tom@tromey.com>
1165
1166         * parser-defs.h (struct parser_state) <start_arglist,
1167         end_arglist>: New methods.
1168         <arglist_len, m_funcall_chain>: New members.
1169         (arglist_len, start_arglist, end_arglist): Don't declare.
1170         * parse.c (arglist_len, funcall_chain): Remove global.
1171         (start_arglist, end_arglist): Remove functions.
1172         (parse_exp_in_context): Update.
1173         * p-exp.y: Update rules.
1174         * m2-exp.y: Update rules.
1175         * go-exp.y: Update rules.
1176         * f-exp.y: Update rules.
1177         * d-exp.y: Update rules.
1178         * c-exp.y: Update rules.
1179
1180 2019-04-04  Tom Tromey  <tom@tromey.com>
1181
1182         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1183         lex_operator, push_back>: New methods.
1184         Update all rules.
1185         (rust_parser::lex_hex, lex_escape): Rename and update.
1186         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1187         (rust_parser::lex_operator): Rename and update.
1188         (rust_parser::lex_number, rustyylex, rustyyerror)
1189         (rust_lex_test_init, rust_lex_test_sequence)
1190         (rust_lex_test_push_back, rust_lex_tests): Update.
1191         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1192         parameter.
1193         <lexptr, prev_lexptr>: New members.
1194         (lexptr, prev_lexptr): Don't declare.
1195         * parse.c (lexptr, prev_lexptr): Remove globals.
1196         (parse_exp_in_context): Update.
1197         * p-exp.y (yylex, yyerror): Update.
1198         * m2-exp.y (parse_number, yylex, yyerror): Update.
1199         * go-exp.y (lex_one_token, yyerror): Update.
1200         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1201         * d-exp.y (lex_one_token, yyerror): Update.
1202         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1203         (lex_one_token, yyerror): Update.
1204         * ada-lex.l (YY_INPUT): Update.
1205         (rewind_to_char): Update.
1206         * ada-exp.y (yyerror): Update.
1207
1208 2019-04-04  Tom Tromey  <tom@tromey.com>
1209
1210         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1211         * parser-defs.h (struct parser_state) <parser_state>: Add new
1212         parameter.
1213         <comma_terminates>: New member.
1214         (comma_terminates): Don't declare global.
1215         * parse.c (comma_terminates): Remove global.
1216         (parse_exp_in_context): Update.
1217         * p-exp.y (yylex): Update.
1218         * m2-exp.y (yylex): Update.
1219         * go-exp.y (lex_one_token): Update.
1220         * f-exp.y (yylex): Update.
1221         * d-exp.y (lex_one_token): Update.
1222         * c-exp.y (lex_one_token): Update.
1223         * ada-lex.l: Update.
1224
1225 2019-04-04  Tom Tromey  <tom@tromey.com>
1226
1227         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1228         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1229         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1230         * parser-defs.h (paren_depth): Don't declare.
1231         * parse.c (paren_depth): Remove global.
1232         (parse_exp_in_context): Update.
1233         * p-exp.y (paren_depth): New global.
1234         (pascal_parse): Initialize it.
1235         * m2-exp.y (paren_depth): New global.
1236         (m2_parse): Initialize it.
1237         * go-exp.y (paren_depth): New global.
1238         (go_parse): Initialize it.
1239         * f-exp.y (paren_depth): New global.
1240         (f_parse): Initialize it.
1241         * d-exp.y (paren_depth): New global.
1242         (d_parse): Initialize it.
1243         * c-exp.y (paren_depth): New global.
1244         (c_parse): Initialize it.
1245         * ada-lex.l (paren_depth): New global.
1246         (lexer_init): Initialize it.
1247
1248 2019-04-04  Tom Tromey  <tom@tromey.com>
1249
1250         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1251         (rust_parser::convert_ast_to_type)
1252         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1253         * parser-defs.h (struct parser_state) <parser_state>: Add
1254         parameters.  Initialize new members.
1255         <expression_context_block, expression_context_pc>: New members.
1256         * parse.c (expression_context_block, expression_context_pc):
1257         Remove globals.
1258         (parse_exp_in_context): Update.
1259         * p-exp.y: Update all rules.
1260         (yylex): Update.
1261         * m2-exp.y: Update all rules.
1262         (yylex): Update.
1263         * go-exp.y (yylex): Update.
1264         * f-exp.y (yylex): Update.
1265         * d-exp.y: Update all rules.
1266         (yylex): Update.
1267         * c-exp.y: Update all rules.
1268         (lex_one_token, classify_name, yylex, c_parse): Update.
1269         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1270
1271 2019-04-04  Tom Tromey  <tom@tromey.com>
1272
1273         * gdbarch.h, gdbarch.c: Rebuild.
1274         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1275         * stap-probe.h: 
1276         (struct stap_parse_info): Replace "parser_state" with
1277         "expr_builder".
1278         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1279         (parser_state): New class.
1280         * parse.c (expr_builder): Rename.
1281         (expr_builder::release): Rename.
1282         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1283         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1284         (write_exp_elt_longcst, write_exp_elt_floatcst)
1285         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1286         (write_exp_string_vector, write_exp_bitstring)
1287         (write_exp_msymbol, mark_struct_expression)
1288         (write_dollar_variable)
1289         (insert_type_address_space, increase_expout_size): Replace
1290         "parser_state" with "expr_builder".
1291         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1292         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1293         "parser_state" with "expr_builder".
1294
1295 2019-04-04  Tom Tromey  <tom@tromey.com>
1296
1297         * rust-exp.y: Replace "parse_language" with method call.
1298         * p-exp.y: 
1299         (yylex): Replace "parse_language" with method call.
1300         * m2-exp.y: 
1301         (yylex): Replace "parse_language" with method call.
1302         * go-exp.y (classify_name): Replace "parse_language" with method
1303         call.
1304         * f-exp.y (yylex): Replace "parse_language" with method call.
1305         * d-exp.y (lex_one_token): Replace "parse_language" with method
1306         call.
1307         * c-exp.y: 
1308         (lex_one_token, classify_name, yylex): Replace "parse_language"
1309         with method call.
1310         * ada-exp.y (find_primitive_type, type_char)
1311         (type_system_address): Replace "parse_language" with method call.
1312
1313 2019-04-04  Tom Tromey  <tom@tromey.com>
1314
1315         * rust-exp.y: Replace "parse_gdbarch" with method call.
1316         * parse.c (write_dollar_variable, insert_type_address_space):
1317         Replace "parse_gdbarch" with method call.
1318         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
1319         call.
1320         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
1321         call.
1322         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
1323         "parse_gdbarch" with method call.
1324         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
1325         with method call.
1326         * f-exp.y (parse_type, parse_f_type, yylex): Replace
1327         "parse_gdbarch" with method call.
1328         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
1329         "parse_gdbarch" with method call.
1330         * c-exp.y (parse_type, parse_number, classify_name): Replace
1331         "parse_gdbarch" with method call.
1332         * ada-lex.l: Replace "parse_gdbarch" with method call.
1333         * ada-exp.y (parse_type, find_primitive_type, type_char)
1334         (type_system_address): Replace "parse_gdbarch" with method call.
1335
1336 2019-04-04  Tom Tromey  <tom@tromey.com>
1337
1338         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
1339         * stap-probe.c (stap_parse_argument): Update.
1340         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
1341         initial_size parameter.
1342         * rust-exp.y (rust_lex_tests): Update.
1343         * parse.c (parser_state): Update.
1344         (parse_exp_in_context): Update.
1345         * parser-defs.h (struct parser_state) <parser_state>: Remove
1346         "initial_size" parameter.
1347
1348 2019-04-04  Tom Tromey  <tom@tromey.com>
1349
1350         * parser-defs.h (increase_expout_size): Don't declare.
1351         * parse.c (increase_expout_size): Now static.
1352
1353 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1354
1355         * gnu-nat.c (gnu_nat_target::wait): Fix
1356         target_waitstatus_to_string call.
1357
1358 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1359
1360         * eval.c (evaluate_subexp_standard): Handle internal functions
1361         during Fortran function call handling.
1362
1363 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1364
1365         * NEWS: Mention new internal functions.
1366         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1367         (read_base_type): Use dwarf2_init_complex_target_type.
1368         * value.c (creal_internal_fn): New function.
1369         (cimag_internal_fn): New function.
1370         (_initialize_values): Register new internal functions.
1371
1372 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1373
1374         * infrun.c (stop_all_threads): If debug_infrun, always
1375         trace the wait status after wait_one, using
1376         target_waitstatus_to_string and target_pid_to_str.
1377         (handle_inferior_event): Replace various trace of
1378         wait status kind by a single trace.
1379         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
1380         wait status kind image by target_waitstatus_to_string.
1381         * target/waitstatus.c (target_waitstatus_to_string): Fix
1382         obsolete comment.
1383
1384 2019-04-01  Tom Tromey  <tromey@adacore.com>
1385
1386         PR symtab/23331:
1387         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
1388
1389 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1390             Pedro Alves  <palves@redhat.com>
1391
1392         * top.c (quit_force): Call 'finalize_values'.
1393         * value.c (finalize_values): New function.
1394         * value.h (finalize_values): Declare.
1395
1396 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
1397
1398         * NEWS: Announce $_gdb_major and $_gdb_minor.
1399
1400         * top.c (init_gdb_version_vars): New function.
1401         (gdb_init): Call init_gdb_version_vars.
1402
1403 2019-03-29  Tom Tromey  <tromey@adacore.com>
1404
1405         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
1406         help text.  Remove dead code.
1407
1408 2019-03-29  Keith Seitz  <keiths@redhat.com>
1409
1410         From Siddhesh Poyarekar:
1411         * f-lang.h (f77_get_upperbound): Return LONGEST.
1412         (f77_get_lowerbound): Likewise.
1413         * f-typeprint.c (f_type_print_varspec_suffix): Expand
1414         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
1415         print them.
1416         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
1417         plongest to format print it.
1418         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
1419         (f77_get_upperbound): Likewise.
1420         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
1421         LOWER_BOUND to LONGEST.
1422         (f77_create_arrayprint_offset_tbl): Likewise.
1423
1424 2019-03-29  Keith Seitz  <keiths@redhat.com>
1425
1426         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
1427         %s/pulongest for TYPE_LENGTH instead of %d in format
1428         strings.
1429         * ada-typerint.c (ada_print_type): Likewise.
1430         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
1431         * compile/compile-c-support.c (generate_register_struct): Likewise.
1432         * gdbtypes.c (recursive_dump_type): Likewise.
1433         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
1434         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
1435         instead of %d in format strings.
1436         * riscv-tdep.c (riscv_type_alignment): Cast second argument
1437         to std::min to ULONGEST.
1438         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
1439         instead of %d in format strings.
1440         * tracepoint.c (info_scope_command): Likewise.
1441         * typeprint.c (print_offset_data::update)
1442         (print_offset_data::finish): Likewise.
1443         * xtensa-tdep.c (xtensa_store_return_value)
1444         (xtensa_push_dummy_call): Likewise.
1445
1446 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
1447
1448         * windows-nat.c (display_selector): Fixed format specifications
1449         for 64-bit Cygwin.
1450
1451 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1452
1453         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
1454
1455 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
1456
1457         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
1458         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
1459         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
1460         (nios2_linux_init_abi): Install it.
1461
1462 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1463
1464         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
1465
1466 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1467
1468         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
1469
1470 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1471             Tom Tromey  <tromey@adacore.com>
1472
1473         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
1474
1475 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
1476
1477         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
1478         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
1479         method to compute the bounds of range types. Also print "[evaluated]"
1480         if the bounds' values come from a dynamic evaluation.
1481
1482 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1483
1484         * cp-valprint.c (cp_print_value_fields): Don't print trailing
1485         whitespace when pretty printing is on.
1486
1487 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1488
1489         * ppc-linux-nat.c: Add include.
1490
1491 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1492
1493         * NEWS: Mention AArch64 Pointer Authentication.
1494
1495 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1496
1497         * arm-linux-nat.c: Add include.
1498
1499 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
1500
1501         * source-cache.c (source_cache::get_source_lines): Re-read
1502         fullname after calling open_source_file.
1503
1504 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
1505
1506         * NEWS: Mention TLS support for FreeBSD.
1507
1508 2019-03-25  Tom Tromey  <tromey@adacore.com>
1509
1510         * minsyms.c (BUNCH_SIZE): Update comment.
1511         (~minimal_symbol_reader): Remove old comment.
1512         (compact_minimal_symbols): Update comment.
1513         (minimal_symbol_reader::install): Remove old comment.  Update
1514         other comments.
1515
1516 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1517
1518         * s390-linux-nat.c: Add include.
1519
1520 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1521
1522         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1523         Call linux_get_hwcap.
1524         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
1525         Likewise.
1526         (aarch64_linux_get_hwcap): Remove function.
1527         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
1528         declaration.
1529         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
1530         linux_get_hwcap.
1531         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1532         * linux-tdep.c (linux_get_hwcap): Add function.
1533         (linux_get_hwcap2): Likewise.
1534         * linux-tdep.h (linux_get_hwcap): Add declaration.
1535         (linux_get_hwcap2): Likewise.
1536         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
1537         (ppc_linux_get_hwcap2): Likewise.
1538         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
1539         linux_get_hwcap.
1540         (ppc_linux_nat_target::insert_watchpoint): Likewise.
1541         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
1542         (ppc_linux_nat_target::read_description): Likewise.
1543         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
1544         * s390-linux-nat.c: Likewise.
1545         * s390-linux-tdep.c (s390_core_read_description): Likewise.
1546
1547 2019-03-24  Tom Tromey  <tom@tromey.com>
1548
1549         * ada-lang.c (standard_lookup): Simplify initialization.
1550         (ada_lookup_symbol_nonlocal): Simplify return.
1551         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
1552         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
1553         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
1554         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
1555         initialization.
1556         * solib.c (solib_global_lookup): Simplify.
1557         * symtab.c (null_block_symbol): Remove.
1558         (symbol_cache_lookup): Simplify returns.
1559         (lookup_language_this): Simplify returns.
1560         (lookup_symbol_aux): Simplify return.
1561         (lookup_local_symbol): Simplify returns.
1562         (lookup_global_symbol_from_objfile): Simplify return.
1563         (lookup_symbol_in_objfile_symtabs)
1564         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
1565         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
1566         (lookup_static_symbol, lookup_global_symbol): Simplify return.
1567         * cp-namespace.c (cp_lookup_bare_symbol)
1568         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
1569         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
1570         (cp_lookup_nested_symbol): Don't use null_block_symbol.
1571         (cp_lookup_symbol_via_imports): Simplify initialization.
1572         (find_symbol_in_baseclass): Likewise.
1573         * symtab.h (null_block_symbol): Remove.
1574         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
1575         (d_lookup_nested_symbol, d_lookup_symbol_imports)
1576         (d_lookup_symbol_module): Likewise.
1577         (find_symbol_in_baseclass): Simplify initialization.
1578
1579 2019-03-24  Tom Tromey  <tom@tromey.com>
1580
1581         * expression.h: Don't include symtab.h.
1582         (struct block): Forward declare.
1583
1584 2019-03-24  Tom Tromey  <tom@tromey.com>
1585
1586         * c-exp.y (typebase): Remove casts.
1587         * gdbtypes.c (lookup_unsigned_typename, )
1588         (lookup_signed_typename): Remove cast.
1589         * eval.c (parse_to_comma_and_eval): Remove cast.
1590         * parse.c (write_dollar_variable): Remove cast.
1591         * block.h (struct block) <superblock>: Now const.
1592         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
1593         * psymtab.c (psym_map_matching_symbols): Make "block" const.
1594         (map_block): Make "block" const.
1595         * symfile.h (struct quick_symbol_functions)
1596         <map_matching_symbols>: Constify block argument to "callback".
1597         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
1598         const.
1599         (find_pc_sect_compunit_symtab): Make "b" const.
1600         (find_symbol_at_address): Likewise.
1601         (search_symbols): Likewise.
1602         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
1603         (dw2_debug_names_lookup_symbol): Likewise.
1604         (dw2_map_matching_symbols): Update.
1605         * p-valprint.c (pascal_val_print): Remove "block".
1606         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
1607         (aux_add_nonlocal_symbols): Make "block" const.
1608         (resolve_subexp): Remove cast.
1609         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
1610         const.
1611         (iterate_over_file_blocks): Likewise.
1612         * f-exp.y (%union) <bval>: Remove.
1613         * coffread.c (patch_opaque_types): Make "b" const.
1614         * spu-tdep.c (spu_catch_start): Make "block" const.
1615         * c-valprint.c (print_unpacked_pointer): Remove "block".
1616         * symmisc.c (dump_symtab_1): Make "b" const.
1617         (block_depth): Make "block" const.
1618         * d-exp.y (%union) <bval>: Remove.
1619         * cp-support.h (cp_lookup_rtti_type): Update.
1620         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
1621         * psymtab.c (psym_lookup_symbol): Make "block" const.
1622         (maintenance_check_psymtabs): Make "b" const.
1623         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
1624         (enumerate_locals, enumerate_args): Update.
1625         * python/py-symtab.c (stpy_global_block): Make "block" const.
1626         (stpy_static_block): Likewise.
1627         * inline-frame.c (block_starting_point_at): Make "new_block"
1628         const.
1629         * block.c (find_block_in_blockvector): Make return type const.
1630         (blockvector_for_pc_sect): Make "b" const.
1631         (find_block_in_blockvector): Make "b" const.
1632
1633 2019-03-23  Tom Tromey  <tom@tromey.com>
1634
1635         * varobj.c (varobj_create): Update.
1636         * symfile.c (clear_symtab_users): Don't reset innermost_block.
1637         * printcmd.c (display_command, do_one_display): Don't reset
1638         innermost_block.
1639         * parser-defs.h (enum innermost_block_tracker_type): Move to
1640         expression.h.
1641         (innermost_block): Update comment.
1642         * parse.c (parse_exp_1): Add tracker_types parameter.
1643         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
1644         tracker_types parameter.  Reset innermost_block.
1645         (parse_exp_in_context): Remove.
1646         (parse_expression_for_completion): Update.
1647         * objfiles.c (~objfile): Don't reset expression_context_block or
1648         innermost_block.
1649         * expression.h (enum innermost_block_tracker_type): Move from
1650         parser-defs.h.
1651         (parse_exp_1): Add tracker_types parameter.
1652         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
1653         reset innermost_block.
1654
1655 2019-03-23  Tom Tromey  <tom@tromey.com>
1656
1657         * objfiles.h: Include bcache.h.
1658
1659 2019-03-23  Tom Tromey  <tom@tromey.com>
1660
1661         * linespec.c (get_current_search_block): Use
1662         scoped_restore_current_language.
1663         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
1664
1665 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1666             Jiong Wang  <jiong.wang@arm.com>
1667
1668         * aarch64-linux-tdep.c
1669         (aarch64_linux_iterate_over_regset_sections): Check for pauth
1670         section.
1671         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
1672
1673 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1674             Jiong Wang  <jiong.wang@arm.com>
1675
1676         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
1677         instructions.
1678         (aarch64_analyze_prologue_test): Add PACIASP test.
1679         (aarch64_prologue_prev_register): Unmask PC value.
1680
1681 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1682             Jiong Wang  <jiong.wang@arm.com>
1683
1684         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
1685         (aarch64_dwarf2_prev_register): Unmask PC value.
1686         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
1687         (aarch64_execute_dwarf_cfa_vendor_op): Check for
1688         DW_CFA_AARCH64_negate_ra_state.
1689         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
1690
1691 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1692             Jiong Wang  <jiong.wang@arm.com>
1693
1694         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
1695         registers.
1696         (aarch64_pseudo_register_name): Likewise.
1697         (aarch64_pseudo_register_type): Likewise.
1698         (aarch64_pseudo_register_reggroup_p): Likewise.
1699         (aarch64_gdbarch_init): Add pauth registers.
1700         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
1701         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
1702         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
1703         (struct gdbarch_tdep): Add regnum for ra_state.
1704
1705 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1706             Jiong Wang  <jiong.wang@arm.com>
1707
1708         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
1709
1710 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1711             Jiong Wang  <jiong.wang@arm.com>
1712
1713         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
1714         function.
1715         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
1716         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
1717         (aarch64_gdbarch_init): Add puth registers.
1718         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
1719         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
1720         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
1721
1722 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1723             Jiong Wang  <jiong.wang@arm.com>
1724
1725         * aarch64-linux-nat.c
1726         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
1727         * aarch64-linux-tdep.c
1728         (aarch64_linux_core_read_description): Likewise.
1729         (aarch64_linux_get_hwcap): New function.
1730         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
1731         (aarch64_linux_get_hwcap): New declaration.
1732
1733 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1734             Jiong Wang  <jiong.wang@arm.com>
1735
1736         * aarch64-linux-nat.c
1737         (aarch64_linux_nat_target::read_description): Add pauth param.
1738         * aarch64-linux-tdep.c
1739         (aarch64_linux_core_read_description): Likewise.
1740         * aarch64-tdep.c (struct target_desc): Add in pauth.
1741         (aarch64_read_description): Add pauth param.
1742         (aarch64_gdbarch_init): Likewise.
1743         * aarch64-tdep.h (aarch64_read_description): Likewise.
1744         * arch/aarch64.c (aarch64_create_target_description): Likewise.
1745         * arch/aarch64.h (aarch64_create_target_description): Likewise.
1746         * features/Makefile: Add new files.
1747         * features/aarch64-pauth.c: New file.
1748         * features/aarch64-pauth.xml: New file.
1749
1750 2019-03-20  Tom Tromey  <tromey@adacore.com>
1751
1752         * infrun.c (handle_inferior_event): Rename from
1753         handle_inferior_event_1.  Create a scoped_value_mark.
1754         (handle_inferior_event): Remove.
1755
1756 2019-03-19  Tom Tromey  <tromey@adacore.com>
1757
1758         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
1759         * infrun.h (print_stop_event): Add "displays" parameter.
1760         * infrun.c (print_stop_event): Add "displays" parameter.
1761
1762 2019-03-19  Pedro Alves  <palves@redhat.com>
1763
1764         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
1765         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
1766         to -1.  Fix TABs vs spaces.
1767         (tui_ui_out::tui_ui_out): Don't initialize fields here.
1768         * tui/tui-out.h (tui_ui_out) Add intro comments.
1769         <m_line, m_start_of_line>: In-class initialize, and add describing
1770         comment.
1771
1772 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
1773
1774         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
1775         variable names.
1776         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
1777
1778 2019-03-18  Pedro Alves  <palves@redhat.com>
1779             Eli Zaretskii <eliz@gnu.org>
1780
1781         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
1782         m_line and m_start_of_line.
1783
1784 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
1785
1786         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
1787         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
1788         it returns a newline.  This fixes a regression in TU mode, whereby
1789         the next line is output on the same screen line as the user input.
1790
1791 2019-03-18  Tom Tromey  <tromey@adacore.com>
1792
1793         * minsyms.c (minimal_symbol_reader::install): Remove call to
1794         obstack_blank.
1795
1796 2019-03-18  Pedro Alves  <palves@redhat.com>
1797
1798         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
1799         New globals.
1800         (apply_style): New, factored out from ...
1801         (apply_ansi_escape): ... this.  Handle reverse video mode.
1802         (tui_set_reverse_mode): New function.
1803         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
1804         * tui/tui-winsource.c (tui_show_source_line): Use
1805         tui_set_reverse_mode instead of setting A_STANDOUT.
1806         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
1807         New setter methods.
1808
1809 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
1810
1811         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
1812         Handle tabs.
1813
1814 2019-03-18  Tom Tromey  <tromey@adacore.com>
1815
1816         * ada-lang.c (empty_array): Add "high" parameter.
1817         (ada_evaluate_subexp): Update.
1818
1819 2019-03-17  Sergei Trofimovich <siarheit@google.com>
1820
1821         * unittests/string_view-selftests.c: Define
1822         _initialize_string_view_selftests unconditionally.
1823
1824 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1825
1826         PR gdb/24350
1827         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
1828
1829 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
1830
1831         PR gdb/24351
1832         * windows-nat.c (display_selector): Fix format specifiers.
1833
1834 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
1835
1836         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
1837         tui_refill_source_window instead of tui_refresh_win, to update the
1838         current execution line.  This fixes redisplay of the current line
1839         when stepping through the code with "next" or "step".
1840
1841 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1842
1843         * source-cache.c (source_cache::get_source_lines): Call
1844         find_source_lines to initialize s->nlines.  This fixes vertical
1845         scrolling of TUI source window when the DOWN arrow is pressed.
1846
1847 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1848
1849         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
1850         linux-thread-db.c (_initialize_thread_db): Likewise.
1851
1852 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
1853
1854         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
1855         wclrtoeol in tui_show_source_line".  This reverts changes made in
1856         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
1857
1858 2019-03-15  Tom Tromey  <tom@tromey.com>
1859
1860         * symtab.h (struct minimal_symbol): Derive from
1861         general_symbol_info.
1862         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
1863         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
1864         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
1865         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
1866         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
1867         (MSYMBOL_SEARCH_NAME): Update.
1868         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
1869         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
1870         * minsyms.c (minimal_symbol_reader::record_full): Update.
1871
1872 2019-03-15  Tom Tromey  <tom@tromey.com>
1873
1874         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
1875
1876 2019-03-15  Tom Tromey  <tom@tromey.com>
1877
1878         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
1879         unique_xmalloc_ptr.
1880         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
1881         Update.
1882         * minsyms.c (lookup_minimal_symbol_by_pc_section)
1883         (build_minimal_symbol_hash_tables)
1884         (minimal_symbol_reader::install): Update.
1885
1886 2019-03-15  Tom Tromey  <tom@tromey.com>
1887
1888         * symtab.c (create_demangled_names_hash): Update.
1889         (symbol_set_names): Update.
1890         * objfiles.h (struct objfile_per_bfd_storage)
1891         <demangled_names_hash>: Now an htab_up.
1892         * objfiles.c (objfile_per_bfd_storage): Simplify.
1893
1894 2019-03-15  Tom Tromey  <tom@tromey.com>
1895
1896         * objfiles.h (struct objfile_per_bfd_storage): Declare
1897         destructor.
1898         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
1899         New.
1900         (get_objfile_bfd_data): Use new.  Don't initialize
1901         language_of_main.
1902         (free_objfile_per_bfd_storage): Remove.
1903         (objfile_bfd_data_free, objfile::~objfile): Use delete.
1904
1905 2019-03-15  Tom Tromey  <tom@tromey.com>
1906
1907         * symfile.c (reread_symbols): Update.
1908         * objfiles.c (objfile::objfile): Update.
1909         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
1910         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
1911         comment.
1912         (minimal_symbol_reader::install): Update.
1913         (terminate_minimal_symbol_table): Remove.
1914         * jit.c (jit_object_close_impl): Update.
1915
1916 2019-03-15  Tom Tromey  <tom@tromey.com>
1917
1918         * minsyms.c (minimal_symbol_reader::record_full): Remove some
1919         initializations.
1920
1921 2019-03-15  Tom Tromey  <tom@tromey.com>
1922
1923         * objfiles.h (struct objfile_per_bfd_storage)
1924         <demangled_hash_languages>: Now a bitset.
1925         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
1926         (lookup_minimal_symbol): Update.
1927
1928 2019-03-15  Tom Tromey  <tom@tromey.com>
1929
1930         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
1931         Don't return the symbol.
1932         * coffread.c (record_minimal_symbol): Use record_full.
1933
1934 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
1935
1936         The MS-Windows port of ncurses fails to switch to a color pair if
1937         one or both of the colors are the implicit default colors.  This
1938         change records the default colors when TUI is initialized, and
1939         then specifies them explicitly when a color pair uses the default
1940         colors.  This allows color styling in TUI mode on MS-Windows.
1941
1942         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
1943         ncurses_norm_attr.
1944         (tui_initialize_io) [__MINGW32__]: Record the default terminal
1945         colors in ncurses_norm_attr.
1946         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
1947         "none", replace it with the default color recorded in
1948         ncurses_norm_attr.
1949
1950 2019-03-14  Tom Tromey  <tromey@adacore.com>
1951
1952         * source-cache.h (class source_cache) <get_source_lines>: Return
1953         std::string.
1954         * source-cache.c (source_cache::extract_lines): Handle case where
1955         first_pos==npos.  Return std::string.
1956         (source_cache::get_source_lines): Update.
1957
1958 2019-03-14  Tom Tromey  <tromey@adacore.com>
1959
1960         * NEWS: Add item for "style sources" commands.
1961         * source-cache.c (source_cache::get_source_lines): Check
1962         source_styling.
1963         * cli/cli-style.c (source_styling): New global.
1964         (_initialize_cli_style): Add "style sources" commands.
1965         (show_style_sources): New function.
1966         * cli/cli-style.h (source_styling): Declare.
1967
1968 2019-03-14  Pedro Alves  <palves@redhat.com>
1969             Tom Tromey  <tromey@adacore.com>
1970
1971         * tui/tui-winsource.h (tui_refill_source_window): Declare.
1972         * tui/tui-winsource.c (tui_refill_source_window): New function,
1973         from...
1974         (tui_horizontal_source_scroll): ... here.  Move some logic.
1975         * cli/cli-style.c (set_style_enabled): Notify new observable.
1976         * tui/tui-hooks.c (tui_redisplay_source): New function.
1977         (tui_attach_detach_observers): Attach or detach
1978         tui_redisplay_source.
1979         * observable.h (source_styling_changed): New observable.
1980         * observable.c: Define source_styling_changed observable.
1981
1982 2019-03-13  Tom Tromey  <tromey@adacore.com>
1983
1984         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
1985         (i386_gnu_nat_target::store_registers): Update.
1986         * target-debug.h (target_debug_print_std_string): New macro.
1987         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1988         * windows-tdep.c (display_one_tib): Update.
1989         * tui/tui-stack.c (tui_make_status_line): Update.
1990         * top.c (print_inferior_quit_action): Update.
1991         * thread.c (thr_try_catch_cmd): Update.
1992         (add_thread_with_info): Update.
1993         (thread_target_id_str): Update.
1994         (thr_try_catch_cmd): Update.
1995         (thread_command): Update.
1996         (thread_find_command): Update.
1997         * record-btrace.c (record_btrace_target::info_record)
1998         (record_btrace_resume_thread, record_btrace_target::resume)
1999         (record_btrace_cancel_resume, record_btrace_step_thread)
2000         (record_btrace_target::wait, record_btrace_target::wait)
2001         (record_btrace_target::wait, record_btrace_target::stop): Update.
2002         * progspace.c (print_program_space): Update.
2003         * process-stratum-target.c
2004         (process_stratum_target::thread_address_space): Update.
2005         * linux-fork.c (linux_fork_mourn_inferior)
2006         (detach_checkpoint_command, info_checkpoints_command)
2007         (linux_fork_context): Update.
2008         (linux_fork_detach): Update.
2009         (class scoped_switch_fork_info): Update.
2010         (delete_checkpoint_command): Update.
2011         * infrun.c (follow_fork_inferior): Update.
2012         (follow_fork_inferior): Update.
2013         (proceed_after_vfork_done): Update.
2014         (handle_vfork_child_exec_or_exit): Update.
2015         (follow_exec): Update.
2016         (displaced_step_prepare_throw): Update.
2017         (displaced_step_restore): Update.
2018         (start_step_over): Update.
2019         (resume_1): Update.
2020         (clear_proceed_status_thread): Update.
2021         (proceed): Update.
2022         (print_target_wait_results): Update.
2023         (do_target_wait): Update.
2024         (context_switch): Update.
2025         (stop_all_threads): Update.
2026         (restart_threads): Update.
2027         (finish_step_over): Update.
2028         (handle_signal_stop): Update.
2029         (switch_back_to_stepped_thread): Update.
2030         (keep_going_pass_signal): Update.
2031         (print_exited_reason): Update.
2032         (normal_stop): Update.
2033         * inferior.c (inferior_pid_to_str): Change return type.
2034         (print_selected_inferior): Update.
2035         (add_inferior): Update.
2036         (detach_inferior): Update.
2037         * dummy-frame.c (fprint_dummy_frames): Update.
2038         * dcache.c (dcache_info_1): Update.
2039         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2040         (btrace_fetch, btrace_clear): Update.
2041         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2042         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2043         type.
2044         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2045         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2046         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2047         * gdbarch.c, gdbarch.h: Rebuild.
2048         * gdbarch.sh (core_pid_to_str): Change return type.
2049         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2050         return type.
2051         (windows_nat_target::pid_to_str): Change return type.
2052         (windows_delete_thread): Update.
2053         (windows_nat_target::attach): Update.
2054         (windows_nat_target::files_info): Update.
2055         * target-delegates.c: Rebuild.
2056         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2057         return type.
2058         (sol_thread_target::pid_to_str): Change return type.
2059         * remote.c (class remote_target) <pid_to_str>: Change return
2060         type.
2061         (remote_target::pid_to_str): Change return type.
2062         (extended_remote_target::attach, remote_target::remote_stop_ns)
2063         (remote_target::remote_notif_remove_queued_reply)
2064         (remote_target::push_stop_reply, remote_target::disable_btrace):
2065         Update.
2066         (extended_remote_target::attach): Update.
2067         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2068         type.
2069         (gdbsim_target::pid_to_str): Change return type.
2070         * ravenscar-thread.c (struct ravenscar_thread_target)
2071         <pid_to_str>: Change return type.
2072         (ravenscar_thread_target::pid_to_str): Change return type.
2073         * procfs.c (class procfs_target) <pid_to_str>: Change return
2074         type.
2075         (procfs_target::pid_to_str): Change return type.
2076         (procfs_target::attach): Update.
2077         (procfs_target::detach): Update.
2078         (procfs_target::fetch_registers): Update.
2079         (procfs_target::store_registers): Update.
2080         (procfs_target::wait): Update.
2081         (procfs_target::files_info): Update.
2082         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2083         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2084         return type.
2085         (nto_procfs_target::pid_to_str): Change return type.
2086         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2087         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2088         return type.
2089         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2090         (exit_lwp): Update.
2091         (attach_proc_task_lwp_callback, get_detach_signal)
2092         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2093         (linux_nat_target::resume, wait_lwp, stop_callback)
2094         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2095         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2096         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2097         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2098         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2099         type.
2100         (inf_ptrace_target::attach): Update.
2101         (inf_ptrace_target::files_info): Update.
2102         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2103         type.
2104         (go32_nat_target::pid_to_str): Change return type.
2105         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2106         (gnu_nat_target::wait): Update.
2107         (gnu_nat_target::wait): Update.
2108         (gnu_nat_target::resume): Update.
2109         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2110         (fbsd_nat_target::wait): Update.
2111         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2112         type.
2113         (darwin_nat_target::attach): Update.
2114         * corelow.c (class core_target) <pid_to_str>: Change return type.
2115         (core_target::pid_to_str): Change return type.
2116         * target.c (normal_pid_to_str): Change return type.
2117         (default_pid_to_str): Likewise.
2118         (target_pid_to_str): Change return type.
2119         (target_translate_tls_address): Update.
2120         (target_announce_detach): Update.
2121         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2122         return type.
2123         (bsd_uthread_target::pid_to_str): Change return type.
2124         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2125         type.
2126         (bsd_kvm_target::pid_to_str): Change return type.
2127         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2128         return type.
2129         (aix_thread_target::pid_to_str): Change return type.
2130         * target.h (struct target_ops) <pid_to_str>: Change return type.
2131         (target_pid_to_str, normal_pid_to_str): Likewise.
2132         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2133         type.
2134         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2135         type.
2136         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2137         return type.
2138         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2139         type.
2140         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2141         type.
2142         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2143         return type.
2144
2145 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2146
2147         * NEWS: Mention that the new default MI version is 3.  Mention
2148         changes to the output of commands and events that deal with
2149         multi-location breakpoints.
2150         * breakpoint.c: Include "mi/mi-out.h".
2151         (print_one_breakpoint): Change output syntax if using MI version
2152         >= 3.
2153         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2154         New.
2155         (mi_multi_location_breakpoint_output_fixed): New.
2156         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2157         (mi_cmd_fix_multi_location_breakpoint_output): New.
2158         (mi_multi_location_breakpoint_output_fixed): New.
2159         * mi/mi-cmds.c (mi_cmds): Register command
2160         -fix-multi-location-breakpoint-output.
2161         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2162         interpreter "mi".
2163
2164 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2165
2166         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2167         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2168         instantiate mi_ui_out based on interpreter name.
2169         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2170         * mi/mi-main.c (mi_load_progress): Likewise.
2171
2172 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2173
2174         * NEWS: Combine separate "New targets" sections for 8.3.
2175
2176 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2177
2178         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2179         (ppcfbsd_init_abi): Install gdbarch
2180         "fetch_tls_load_module_address" and "get_thread_local_address"
2181         methods.
2182
2183 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2184
2185         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2186         (riscv_fbsd_init_abi): Install gdbarch
2187         "fetch_tls_load_module_address" and "get_thread_local_address"
2188         methods.
2189
2190 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2191
2192         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2193         (i386fbsd_init_abi): Install gdbarch
2194         "fetch_tls_load_module_address" and "get_thread_local_address"
2195         methods.
2196
2197 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2198
2199         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2200         (amd64fbsd_init_abi): Install gdbarch
2201         "fetch_tls_load_module_address" and "get_thread_local_address"
2202         methods.
2203
2204 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2205
2206         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2207         (struct fbsd_pspace_data): New type.
2208         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2209         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2210         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2211         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2212         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2213
2214 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2215
2216         * gdbtypes.c (lookup_struct_elt): New function.
2217         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2218         * gdbtypes.h (struct struct_elt): New type.
2219         (lookup_struct_elt): New prototype.
2220
2221 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2222
2223         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2224         remove disabled code block.
2225
2226 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2227
2228         * gdbarch.sh (get_thread_local_address): New method.
2229         * gdbarch.h, gdbarch.c: Regenerate.
2230         * target.c (target_translate_tls_address): Use
2231         gdbarch_get_thread_local_address if present instead of
2232         target::get_thread_local_address.
2233
2234 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2235
2236         * target.h (target::get_thread_local_address): Update comment.
2237
2238 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2239
2240         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2241         objfile->separate_debug_objfile_backlink if not NULL.
2242
2243 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2244
2245         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2246         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2247         (amd64bsd_store_inferior_registers): Likewise.
2248         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2249         Enable segment base registers.
2250         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2251         PT_GETFSBASE and PT_GETGSBASE.
2252         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2253         PT_SETGSBASE.
2254         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2255         segment base registers.
2256         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2257
2258 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2259
2260         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2261         Update calls to i386_target_description to add 'segments'
2262         parameter.
2263         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2264         add segment base registers.
2265         * arch/i386.c (i386_create_target_description): Add 'segments'
2266         parameter to enable segment base registers.
2267         * arch/i386.h (i386_create_target_description): Likewise.
2268         * features/i386/32bit-segments.xml: New file.
2269         * features/i386/32bit-segments.c: Generate.
2270         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2271         call to i386_target_description to add 'segments' parameter.
2272         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2273         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2274         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2275         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2276         if feature is present.
2277         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2278         Add 'segments' parameter to call to i386_target_description.
2279         (i386_target_description): Add 'segments' parameter to enable
2280         segment base registers.
2281         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2282         to call to i386_target_description.
2283         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2284         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2285         Define I386_NUM_REGS.
2286         (i386_target_description): Add 'segments' parameter to enable
2287         segment base registers.
2288
2289 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2290
2291         PR/24325
2292         * source-cache.c: #undef open and close, to avoid unresolved
2293         externals during linking.
2294
2295 2019-03-12  Tom Tromey  <tromey@adacore.com>
2296
2297         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2298         const.  Add initializers.
2299         (_initialize_remote): Don't initialize ptid globals.
2300
2301 2019-03-12  Pedro Alves  <palves@redhat.com>
2302
2303         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
2304
2305 2019-03-12  Pedro Alves  <palves@redhat.com>
2306
2307         * cp-name-parser.y (main): Remove unused 'len' variable.
2308
2309 2019-03-12  Tom Tromey  <tromey@adacore.com>
2310
2311         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
2312         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
2313
2314 2019-03-12  Tom Tromey  <tromey@adacore.com>
2315
2316         * linux-nat.c (iterate_over_lwps): Update.
2317         (stop_callback): Remove parameter.
2318         (stop_wait_callback, detach_callback, resume_set_callback)
2319         (select_singlestep_lwp_callback, set_ignore_sigint)
2320         (status_callback, resumed_callback, resume_clear_callback)
2321         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
2322         data parameter.
2323         (linux_nat_target::detach, linux_nat_target::resume)
2324         (linux_stop_and_wait_all_lwps, select_event_lwp)
2325         (linux_nat_filter_event, linux_nat_wait_1)
2326         (linux_nat_target::kill, linux_nat_target::stop)
2327         (linux_nat_target::stop): Update.
2328         (linux_nat_resume_callback): Change type.
2329         (resume_stopped_resumed_lwps, count_events_callback)
2330         (select_event_lwp_callback): Likewise.
2331         (linux_stop_lwp, linux_nat_stop_lwp): Update.
2332         * arm-linux-nat.c (struct update_registers_data): Remove.
2333         (update_registers_callback): Change type.
2334         (arm_linux_insert_hw_breakpoint1): Update.
2335         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
2336         parameter.
2337         (x86_linux_dr_set_addr): Update.
2338         (x86_linux_dr_set_control): Update.
2339         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
2340         (iterate_over_lwps): Use gdb::function_view.
2341         * nat/aarch64-linux-hw-point.c (struct
2342         aarch64_dr_update_callback_param): Remove.
2343         (debug_reg_change_callback): Change type.
2344         (aarch64_notify_debug_reg_change): Update.
2345         * s390-linux-nat.c (s390_refresh_per_info): Update.
2346
2347 2019-03-11  Tom Tromey  <tromey@adacore.com>
2348
2349         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2350         redundant assignment to "this_cu".
2351
2352 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2353
2354         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2355
2356 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2357
2358         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2359         from...
2360         (rank_one_type): ... this.
2361
2362 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2363
2364         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2365         from...
2366         (rank_one_type): ... this.
2367
2368 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2369
2370         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
2371         from...
2372         (rank_one_type): ... this.
2373
2374 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2375
2376         * gdbtypes.c (rank_one_type_parm_float): New function extracted
2377         from...
2378         (rank_one_type): ... this.
2379
2380 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2381
2382         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
2383         from...
2384         (rank_one_type): ... this.
2385
2386 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2387
2388         * gdbtypes.c (rank_one_type_parm_range): New function extracted
2389         from...
2390         (rank_one_type): ... this.
2391
2392 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2393
2394         * gdbtypes.c (rank_one_type_parm_char): New function extracted
2395         from...
2396         (rank_one_type): ... this.
2397
2398 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2399
2400         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
2401         from...
2402         (rank_one_type): ... this.
2403
2404 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2405
2406         * gdbtypes.c (rank_one_type_parm_int): New function extracted
2407         from...
2408         (rank_one_type): ... this.
2409
2410 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2411
2412         * gdbtypes.c (rank_one_type_parm_func): New function extracted
2413         from...
2414         (rank_one_type): ... this.
2415
2416 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2417
2418         * gdbtypes.c (rank_one_type_parm_array): New function extracted
2419         from...
2420         (rank_one_type): ... this.
2421
2422 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2423
2424         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
2425         from...
2426         (rank_one_type): ... this.
2427
2428 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2429
2430         * inferior.c (initialize_inferiors): Ensure 'help set/show print
2431         inferior-events' shows the example events.
2432
2433 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
2434
2435         Support styling on native MS-Windows console
2436
2437         PR/24315
2438         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
2439         on MS-Windows if $TERM is not defined.
2440
2441         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
2442
2443         * posix-hdep.c (gdb_console_fputs):
2444         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
2445         functions.
2446         * ui-file.h (gdb_console_fputs): Add prototype.
2447
2448         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
2449         back to fputs only if the former returns zero.
2450
2451 2019-03-07  Tom Tromey  <tom@tromey.com>
2452
2453         * symmisc.c (print_symbol_bcache_statistics): Update.
2454         (print_objfile_statistics): Update.
2455         * symfile.c (allocate_symtab): Update.
2456         * stabsread.c: Don't include bcache.h.
2457         * psymtab.h (struct psymbol_bcache): Don't declare.
2458         (class psymtab_storage) <psymbol_cache>: Now a bcache.
2459         (psymbol_bcache_init, psymbol_bcache_free)
2460         (psymbol_bcache_get_bcache): Don't declare.
2461         * psymtab.c (struct psymbol_bcache): Remove.
2462         (psymtab_storage::psymtab_storage): Update.
2463         (psymtab_storage::~psymtab_storage): Update.
2464         (psymbol_bcache_init, psymbol_bcache_free)
2465         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
2466         (add_psymbol_to_bcache): Update.
2467         (allocate_psymtab): Update.
2468         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2469         macro_cache>: No longer pointers.
2470         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
2471         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
2472         * macrotab.c (macro_bcache): Update.
2473         * macroexp.c: Don't include bcache.h.
2474         * gdbtypes.c (check_types_worklist): Update.
2475         (types_deeply_equal): Remove TRY/CATCH.  Update.
2476         * elfread.c (elf_symtab_read): Update.
2477         * dwarf2read.c: Don't include bcache.h.
2478         * buildsym.c (buildsym_compunit::get_macro_table): Update.
2479         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
2480         (print_bcache_statistics, bcache_memory_used): Don't declare.
2481         (struct bcache): Move from bcache.c.  Add constructor, destructor,
2482         methods.  Rename all data members.
2483         * bcache.c (struct bcache): Move to bcache.h.
2484         (bcache::expand_hash_table): Rename from expand_hash_table.
2485         (bcache): Remove.
2486         (bcache::insert): Rename from bcache_full.
2487         (bcache::compare): Rename from bcache_compare.
2488         (bcache_xmalloc): Remove.
2489         (bcache::~bcache): Rename from bcache_xfree.
2490         (bcache::print_statistics): Rename from print_bcache_statistics.
2491         (bcache::memory_used): Rename from bcache_memory_used.
2492
2493 2019-03-07  Pedro Alves  <palves@redhat.com>
2494
2495         * infrun.c (normal_stop): Also check for
2496         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
2497
2498 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2499
2500         * f-lang.c (value_from_host_double): Moved to...
2501         * value.c (value_from_host_double): ...here.
2502         * value.h (value_from_host_double): Declare.
2503         * guile/scm-math.c (vlscm_convert_typed_number): Use
2504         value_from_host_double.
2505         (vlscm_convert_number): Likewise.
2506         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
2507         * python/py-value.c (convert_value_from_python): Likewise.
2508
2509 2019-03-06  Tom Tromey  <tom@tromey.com>
2510
2511         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
2512
2513 2019-03-06  Tom Tromey  <tom@tromey.com>
2514
2515         * utils.h (free_current_contents): Don't declare.
2516         * utils.c (free_current_contents): Remove.
2517
2518 2019-03-06  Tom Tromey  <tom@tromey.com>
2519
2520         * top.c (quit_force): Update.
2521         * main.c (captured_command_loop): Update.
2522         * common/new-op.c (operator new): Update.
2523         * common/common-exceptions.c (struct catcher)
2524         <save_cleanup_chain>: Remove member.
2525         (exceptions_state_mc_init): Update.
2526         (exception_try_scope_entry): Return nullptr.
2527         (exception_try_scope_exit, exception_rethrow)
2528         (throw_exception_sjlj, throw_exception_cxx): Update.
2529         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
2530         (all_cleanups, do_cleanups, discard_cleanups)
2531         (discard_final_cleanups, save_cleanups, save_final_cleanups)
2532         (restore_cleanups, restore_final_cleanups): Don't declare.
2533         (do_final_cleanups): Remove parameter.
2534         * common/cleanups.c (cleanup_chain, make_cleanup)
2535         (make_cleanup_dtor, all_cleanups, do_cleanups)
2536         (discard_my_cleanups, discard_cleanups)
2537         (discard_final_cleanups, save_my_cleanups, save_cleanups)
2538         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
2539         (null_cleanup): Remove.
2540         (do_final_cleanups): Remove parameter.
2541
2542 2019-03-06  Tom Tromey  <tom@tromey.com>
2543
2544         * remote.c (remote_target::remote_parse_stop_reply): Use
2545         unique_xmalloc_ptr.
2546
2547 2019-03-06  Tom Tromey  <tom@tromey.com>
2548
2549         * stabsread.c (struct stabs_field_info): Rename from field_info.
2550         <list, fnlist>: Add initializers.
2551         <obstack>: New member.
2552         (read_member_functions, read_struct_fields, read_baseclasses):
2553         Allocate on obstack.  Don't use cleanups.
2554         (read_one_struct_field, read_member_functions, read_struct_fields)
2555         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
2556         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
2557         (read_struct_type): Update.
2558
2559 2019-03-06  Tom Tromey  <tom@tromey.com>
2560
2561         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
2562         * common/filestuff.h (make_cleanup_close): Don't declare.
2563         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
2564         Remove.
2565
2566 2019-03-06  Tom Tromey  <tom@tromey.com>
2567
2568         * solib-aix.c: Use make_scope_exit.
2569
2570 2019-03-06  Tom Tromey  <tom@tromey.com>
2571
2572         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
2573         Use make_scope_exit.
2574
2575 2019-03-06  Tom Tromey  <tom@tromey.com>
2576
2577         * solib-svr4.c (disable_probes_interface): Remove parameter.
2578         (svr4_handle_solib_event): Use make_scope_exit.
2579
2580 2019-03-06  Tom Tromey  <tom@tromey.com>
2581
2582         * remote.c (struct stop_reply_deleter): Remove.
2583         (stop_reply_up): Update.
2584         (struct stop_reply): Derive from notif_event.  Don't typedef.
2585         <regcache>: Now a std::vector.
2586         (stop_reply_xfree): Remove.
2587         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
2588         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
2589         (remote_target::discard_pending_stop_replies): Use delete.
2590         (remote_target::remote_parse_stop_reply): Update.
2591         (remote_target::process_stop_reply): Update.
2592         * remote-notif.h (struct notif_event): Add virtual destructor.
2593         Remove "dtr" member.
2594         (struct notif_client) <alloc_event>: Return a unique_ptr.
2595         (notif_event_xfree): Don't declare.
2596         (notif_event_up): New typedef.
2597         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
2598         (notif_event_xfree, do_notif_event_xfree): Remove.
2599         (remote_notif_state_xfree): Update.
2600
2601 2019-03-06  Tom Tromey  <tom@tromey.com>
2602
2603         * infrun.c (displaced_step_clear_cleanup): Now a
2604         forward_scope_exit type.
2605         (displaced_step_prepare_throw): Update.
2606         (displaced_step_fixup): Update.
2607
2608 2019-03-06  Tom Tromey  <tom@tromey.com>
2609
2610         * inferior.h (class inferior): Update comment.
2611         * gdbthread.h (class thread_info): Update comment.
2612
2613 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
2614             Tom Tromey  <tom@tromey.com>
2615
2616         * stabsread.h (struct stab_section_list): Remove.
2617         (coffstab_build_psymtabs): Update.
2618         * dbxread.c (symbuf_sections): Now a std::vector.
2619         (sect_idx): New global.
2620         (fill_symbuf): Update.
2621         (coffstab_build_psymtabs): Change type of stabsects parameter.
2622         Update.
2623         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
2624         std::vector.
2625         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
2626         (coff_locate_sections): Update.
2627         (coff_symfile_read): Remove cleanups.  Update.
2628         (init_stringtab): Add storage parameter.
2629         (free_stringtab, free_stringtab_cleanup): Remove.
2630         (init_lineno): Add storage parameter.
2631         (free_linetab, free_linetab_cleanup): Remove.
2632
2633 2019-03-06  Pedro Alves  <palves@redhat.com>
2634
2635         * linux-fork.c (fork_info::clobber_regs): Delete.
2636         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
2637         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
2638         comment.  Adjust.
2639         (scoped_switch_fork_info::scoped_switch_fork_info)
2640         (checkpoint_command, linux_fork_context): Adjust
2641         fork_save_infrun_state calls.
2642
2643 2019-03-06  Pedro Alves  <palves@redhat.com>
2644
2645         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
2646         (inf_has_multiple_threads): Return 'bool' and rewrite using
2647         inferior_info::threads().
2648
2649 2019-03-06  Pedro Alves  <palves@redhat.com>
2650
2651         * linux-fork.c: Include <list>.
2652         (fork_list): Now a std::list instance.
2653         (fork_info): Add ctor, dtor, and in-class initialize all fields.
2654         (forks_exist_p, find_last_fork): Adjust.
2655         (new_fork): Delete.
2656         (one_fork_p): New.
2657         (add_fork): Adjust.
2658         (free_fork): Delete, folded into fork_info::~fork_info().
2659         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
2660         Adjust.
2661         (init_fork_list): Delete.
2662         (linux_fork_killall, linux_fork_mourn_inferior)
2663         (linux_fork_detach, info_checkpoints_command): Adjust.
2664         (_initialize_linux_fork): No longer call init_fork_list.
2665
2666 2019-03-06  Pedro Alves  <palves@redhat.com>
2667
2668         * linux-fork.c (new_fork): New, split out of ...
2669         (add_fork): ... this.  Return void.  Move "first fork" special
2670         case from here, to ...
2671         (checkpoint_command): ... here.
2672         * linux-linux.h (add_fork): Return void.
2673
2674 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2675
2676         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
2677
2678 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2679             Chris January  <chris.january@arm.com>
2680             David Lecomber  <david.lecomber@arm.com>
2681
2682         * f-exp.y: New token, UNOP_INTRINSIC.
2683         (exp): New pattern using UNOP_INTRINSIC token.
2684         (f77_keywords): Add 'abs' keyword.
2685         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
2686         (value_from_host_double): New function.
2687         (evaluate_subexp_f): Support UNOP_ABS.
2688
2689 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2690
2691         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
2692         types.
2693
2694 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2695
2696         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
2697         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
2698         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
2699
2700 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2701
2702         * f-exp.y (convert_to_kind_type): Handle more type kinds.
2703
2704 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2705             Chris January  <chris.january@arm.com>
2706
2707         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
2708         * f-exp.y: Define 'KIND' token.
2709         (exp): New pattern for KIND expressions.
2710         (ptype): Handle types with a kind extension.
2711         (direct_abs_decl): Extend to spot kind extensions.
2712         (f77_keywords): Add 'kind' to the list.
2713         (push_kind_type): New function.
2714         (convert_to_kind_type): New function.
2715         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
2716         * parse.c (operator_length_standard): Likewise.
2717         * parser-defs.h (enum type_pieces): Add tp_kind.
2718         * std-operator.def: Add UNOP_KIND.
2719
2720 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2721
2722         * f-exp.y (f_parse): Set yydebug.
2723
2724 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2725
2726         * f-lang.c (evaluate_subexp_f): New function.
2727         (exp_descriptor_f): New global.
2728         (f_language_defn): Use exp_descriptor_f instead of
2729         exp_descriptor_standard.
2730
2731 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2732
2733         * f-exp.y (struct token): Add comments.
2734         (dot_ops): Remove uppercase versions and the end marker.
2735         (f77_keywords): Likewise.
2736         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
2737         entries in the dot_ops array are case insensitive, and use
2738         strncasecmp to compare strings.  Also some whitespace cleanup in
2739         this area.  Similar for the f77_keywords array, except entries in
2740         this list might be case sensitive.
2741
2742 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2743
2744         * f-exp.y (struct f77_boolean_val): Add comments.
2745         (boolean_values): Remove uppercase versions, and end marker.
2746         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
2747         and use strncasecmp to achieve case insensitivity.  Additionally,
2748         perform whitespace cleanup around this code.
2749
2750 2019-03-06  Tom Tromey  <tromey@adacore.com>
2751
2752         * remote-sim.c (gdbsim_target_open): Use result of
2753         gdb_argv::release.
2754
2755 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
2756         Dirk Schubert  <dirk.schubert@arm.com>
2757         Chris January  <chris.january@arm.com>
2758
2759         * eval.c (evaluate_subexp_standard): Call Fortran argument
2760         wrapping logic.
2761         * f-lang.c (struct value): A value which can be passed into a
2762         Fortran function call.
2763         (fortran_argument_convert): Wrap Fortran arguments in a pointer
2764         where appropriate.
2765         (struct type): Value ready for a Fortran function call.
2766         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
2767         is needed.
2768         * f-lang.h (fortran_argument_convert): Declaration.
2769         (fortran_preserve_arg_pointer): Declaration.
2770         * infcall.c (value_arg_coerce): Call Fortran argument logic.
2771
2772 2019-03-05  Tom Tromey  <tromey@adacore.com>
2773
2774         * python/py-prettyprint.c (print_string_repr): Remove #if.
2775         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
2776
2777 2019-03-05  Tom Tromey  <tromey@adacore.com>
2778
2779         * target.c (the_dummy_target): Move later.  Change type to
2780         "dummy_target".
2781         (initialize_targets): Don't initialize the_dummy_target.
2782
2783 2019-03-05  Tom Tromey  <tromey@adacore.com>
2784
2785         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
2786         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
2787
2788 2019-03-05  Tom Tromey  <tromey@adacore.com>
2789
2790         * windows-nat.c (windows_nat_target::attach)
2791         (windows_nat_target::detach): Don't call gdb_flush.
2792         * valprint.c (generic_val_print, val_print, val_print_string):
2793         Don't call gdb_flush.
2794         * utils.c (defaulted_query): Don't call gdb_flush.
2795         * typeprint.c (print_type_scalar): Don't call gdb_flush.
2796         * target.c (target_announce_detach): Don't call gdb_flush.
2797         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
2798         * remote.c (extended_remote_target::attach): Don't call
2799         gdb_flush.
2800         * procfs.c (procfs_target::detach): Don't call gdb_flush.
2801         * printcmd.c (do_examine): Don't call gdb_flush.
2802         (info_display_command): Don't call gdb_flush.
2803         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
2804         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
2805         * memattr.c (info_mem_command): Don't call gdb_flush.
2806         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
2807         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
2808         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
2809         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
2810         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
2811         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
2812         (gnu_nat_target::detach): Don't call gdb_flush.
2813         * f-valprint.c (f_val_print): Don't call gdb_flush.
2814         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
2815         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
2816         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
2817         gdb_flush.
2818         * c-valprint.c (c_val_print): Don't call gdb_flush.
2819         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
2820
2821 2019-03-05  Tom Tromey  <tromey@adacore.com>
2822
2823         * varobj.c (update_dynamic_varobj_children): Update.
2824         (install_default_visualizer): Use reset, not release.
2825         * value.c (set_internalvar): Update.
2826         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
2827         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
2828         ATTRIBUTE_UNUSED_RESULT.
2829
2830 2019-03-05  Tom Tromey  <tromey@adacore.com>
2831
2832         * remote.c (class scoped_remote_fd) <release>: Add
2833         ATTRIBUTE_UNUSED_RESULT.
2834
2835 2019-03-05  Tom Tromey  <tromey@adacore.com>
2836
2837         * macroexp.c (struct macro_buffer) <release>: Add
2838         ATTRIBUTE_UNUSED_RESULT.
2839
2840 2019-03-05  Tom Tromey  <tromey@adacore.com>
2841
2842         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
2843         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
2844         ATTRIBUTE_UNUSED_RESULT.
2845
2846 2019-03-05  Tom Tromey  <tromey@adacore.com>
2847
2848         * common/scoped_fd.h (class scoped_fd) <release>: Add
2849         ATTRIBUTE_UNUSED_RESULT.
2850
2851 2019-03-05  Tom Tromey  <tromey@adacore.com>
2852
2853         * parser-defs.h (struct parser_state) <release>: Add
2854         ATTRIBUTE_UNUSED_RESULT.
2855
2856 2019-03-05  Tom Tromey  <tromey@adacore.com>
2857
2858         * utils.h (class gdb_argv) <release>: Add
2859         ATTRIBUTE_UNUSED_RESULT.
2860         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
2861
2862 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
2863
2864         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
2865         for-loop range, to avoid compiler warnings.
2866
2867         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
2868         avoid compiler warnings about unused variables.
2869
2870         * NEWS: Mention end of support for native debugging on MS-Windows
2871         before XP.
2872
2873         PR gdb/24292
2874         * common/netstuff.c:
2875         * gdbserver/gdbreplay.c
2876         * gdbserver/remote-utils.c:
2877         * ser-tcp.c:
2878         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
2879         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
2880         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
2881         'getaddrinfo' and 'freeaddrinfo' were not available before
2882         Windows XP, and mingw.org's MinGW headers by default define
2883         _WIN32_WINNT to 0x500.
2884
2885 2019-03-01  Gary Benson <gbenson@redhat.com>
2886
2887         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
2888
2889 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
2890             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2891
2892         PR gdb/8527
2893         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
2894         set_sigint_trap, clear_sigint_trap.
2895
2896 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2897
2898         * target.c (target_detach): Clear the regcache and the
2899         frame cache.
2900
2901 2019-02-27  Pedro Alves  <palves@redhat.com>
2902
2903         * utils.c (set_screen_size): When we cap the height/width sizes,
2904         tweak the corresponding command variable to show "unlimited":
2905
2906 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
2907             Pedro Alves  <palves@redhat.com>
2908
2909         * utils.c (set_screen_size): Reduce "infinite" rows and columns
2910         before calling rl_set_screen_size.
2911
2912 2019-02-27  Tom Tromey  <tromey@adacore.com>
2913
2914         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
2915         define.
2916         * python/py-value.c: Remove Python 2.4 workaround.
2917         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
2918         workaround.
2919         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
2920         Python 2.4 workaround.
2921         * python/python-internal.h: Remove Python 2.4 comment.
2922         (Py_ssize_t): Don't define.
2923         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
2924         (gdb_Py_DECREF): Remove Python 2.4 workaround.
2925         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
2926         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
2927         * python/python.c (do_start_initialization): Remove Python 2.4
2928         workaround.
2929         * python/py-prettyprint.c (class dummy_python_frame): Remove.
2930         (print_children): Remove Python 2.4 workaround.
2931         * python/py-inferior.c (buffer_procs): Remove Python 2.4
2932         workaround.
2933         (CHARBUFFERPROC_NAME): Remove.
2934         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
2935         Python 2.4 workaround.
2936
2937 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2938
2939         * NEWS: Note minimum Python version.
2940
2941 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
2942
2943         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
2944         code from these functions.  Remove corresponding ifdefs.  Use
2945         Py_buffer_up instead of explicit calls to PyBuffer_Release.
2946         Remove gotos and target of gotos.
2947         (infpy_search_memory): Likewise.
2948
2949 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2950
2951         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
2952         (hppa_gdbarch_init): Don't register deleted functions with
2953         gdbarch.
2954
2955 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2956
2957         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
2958         (h8300_unwind_sp): Delete.
2959         (h8300_dummy_id): Delete.
2960         (h8300_gdbarch_init): Don't register deleted functions with
2961         gdbarch.
2962
2963 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2964
2965         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
2966         (ft32_unwind_pc): Delete.
2967         (ft32_unwind_sp): Delete.
2968         (ft32_gdbarch_init): Don't register deleted functions with
2969         gdbarch.
2970
2971 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2972
2973         * gdb/frv-tdep.c (frv_dummy_id): Delete.
2974         (frv_unwind_pc): Delete.
2975         (frv_unwind_sp): Delete.
2976         (frv_gdbarch_init): Don't register deleted functions with
2977         gdbarch.
2978
2979 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2980
2981         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
2982         (riscv_unwind_pc): Delete.
2983         (riscv_unwind_sp): Delete.
2984         (riscv_gdbarch_init): Don't register deleted functions with
2985         gdbarch.
2986
2987 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2988
2989         * gdb/csky-tdep.c (csky_dummy_id): Delete.
2990         (csky_unwind_pc): Delete.
2991         (csky_unwind_sp): Delete.
2992         (csky_gdbarch_init): Don't register deleted functions with
2993         gdbarch.
2994
2995 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2996
2997         * gdb/cris-tdep.c (cris_dummy_id): Delete.
2998         (cris_unwind_pc): Delete.
2999         (cris_unwind_sp): Delete.
3000         (cris_gdbarch_init): Don't register deleted functions with
3001         gdbarch.
3002
3003 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3004
3005         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3006         (bfin_unwind_pc): Delete.
3007         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3008
3009 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3010
3011         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3012         (arm_unwind_pc): Delete.
3013         (arm_unwind_sp): Delete.
3014         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3015
3016 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3017
3018         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3019         (arc_unwind_pc): Delete.
3020         (arc_unwind_sp): Delete.
3021         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3022
3023 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3024
3025         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3026         (alpha_unwind_pc): Delete.
3027         (alpha_gdbarch_init): Don't register deleted functions with
3028         gdbarch.
3029
3030 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3031
3032         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3033         (aarch64_unwind_pc): Delete.
3034         (aarch64_unwind_sp): Delete.
3035         (aarch64_gdbarch_init): Don't register deleted functions with
3036         gdbarch.
3037
3038 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3039
3040         * gdbtypes.c (type_align): Don't consider static members when
3041         computing structure alignment.
3042
3043 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3044
3045         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3046         return 0 for other types.
3047         * arch-utils.c (default_type_align): Always return 0.
3048         * gdbarch.h: Regenerate.
3049         * gdbarch.sh (type_align): Extend comment.
3050         * gdbtypes.c (type_align): Add additional comments, always call
3051         gdbarch_type_align before applying the default rules.
3052         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3053         generic code will then apply a suitable default.
3054         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3055         types, return 0 for other types.
3056
3057 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3058
3059         * NEWS: Create a new section for the next release branch.
3060         Rename the section of the current branch, now that it has
3061         been cut.
3062
3063 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3064
3065         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3066         * version.in: Bump version to 8.3.50.DATE-git.
3067
3068 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3069
3070         * aix-thread.c (ptid_cmp): Remove unused variable.
3071         (get_signaled_thread): Likewise.
3072         (store_regs_user_thread): Likewise.
3073         (store_regs_kernel_thread): Likewise.
3074         (fetch_regs_kernel_thread): Remove shadowed variable.
3075
3076 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3077
3078         * features/riscv/32bit-cpu.xml: Add register numbers.
3079         * features/riscv/32bit-fpu.c: Regenerate.
3080         * features/riscv/32bit-fpu.xml: Add register numbers.
3081         * features/riscv/64bit-cpu.xml: Add register numbers.
3082         * features/riscv/64bit-fpu.c: Regenerate.
3083         * features/riscv/64bit-fpu.xml: Add register numbers.
3084
3085 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3086
3087         * NEWS: Mention two argument form of gdb.Value constructor.
3088         * python/py-value.c (convert_buffer_and_type_to_value): New
3089         function.
3090         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3091         Add support for handling an optional second argument.  Call
3092         convert_buffer_and_type_to_value as appropriate.
3093         * python/python-internal.h (Py_buffer_deleter): New struct.
3094         (Py_buffer_up): New typedef.
3095
3096 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3097
3098         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3099         instead of releasing ownership.
3100
3101 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3102
3103         * dwarf2read.c (open_and_init_dwp_file): Call
3104         elf_numsections instead of bfd_count_sections to initialize
3105         dwp_file->num_sections.
3106
3107 2019-02-25  Tom Tromey  <tromey@adacore.com>
3108
3109         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3110
3111 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3112
3113         * gcore.in: Add '--readnever' option when invoking GDB.
3114
3115 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3116
3117         * MAINTAINERS: Update my email address.
3118
3119 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3120
3121         * build-id.c (build_id_to_debug_bfd_1): New function.
3122         (build_id_to_debug_bfd): Look for separate debug file in
3123         sysroot.
3124
3125 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3126
3127         * gdbarch.sh: Update the copyright year range that is placed into
3128         generated files.
3129
3130 2019-02-22  Keith Seitz  <keiths@redhat.com>
3131
3132         PR symtab/23853
3133         * linespec.c (create_sals_line_offset): Search for the default
3134         symtab's filename instead of its fullname.
3135
3136 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3137
3138         * NEWS: Update style defaults.
3139
3140 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3141
3142         * main.c (captured_main_1): Disable styling in batch mode.
3143
3144 2019-02-20  Tom Tromey  <tom@tromey.com>
3145
3146         * symtab.c (symtab_symbol_info): Fix typos.
3147
3148 2019-02-20  Tom Tromey  <tromey@adacore.com>
3149
3150         * findcmd.c (_initialize_mem_search): Use upper case for
3151         metasyntactic variables.
3152
3153 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3154
3155         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3156         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3157
3158 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3159
3160         * top.h (source_file_name): Change to std::string.
3161         * top.c (source_file_name): Likewise.
3162         (command_line_input): Adjust.
3163         * cli/cli-script.c (script_from_file): Adjust.
3164
3165 2019-02-19  Tom Tromey  <tromey@adacore.com>
3166
3167         * ravenscar-thread.c
3168         (ravenscar_thread_target::update_thread_list): Don't call
3169         ada_build_task_list.
3170         * ada-lang.h (ada_build_task_list): Don't declare.
3171         * ada-tasks.c (struct ada_tasks_inferior_data)
3172         <task_list_valid_p>: Now bool.
3173         (read_known_tasks, ada_task_list_changed)
3174         (ada_tasks_invalidate_inferior_data): Update.
3175         (read_known_tasks_array): Return bool.
3176         (read_known_tasks_list): Likewise.
3177         (read_known_tasks): Return void.
3178         (ada_build_task_list): Now static.
3179
3180 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3181
3182         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3183         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3184
3185 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3186
3187         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3188         variant for ada_tasks_pspace_data_handle and
3189         ada_tasks_inferior_data_handle.
3190         (ada_tasks_pspace_data_cleanup): New function.
3191         (ada_tasks_inferior_data_cleanup): New function.
3192
3193 2019-02-17  Tom Tromey  <tom@tromey.com>
3194
3195         * macrotab.h (macro_source_fullname): Return a std::string.
3196         * macrotab.c (macro_include, check_for_redefinition)
3197         (macro_undef, macro_lookup_definition, foreach_macro)
3198         (foreach_macro_in_scope): Update.
3199         (macro_source_fullname): Return a std::string.
3200         * macrocmd.c (show_pp_source_pos): Update.
3201
3202 2019-02-17  Tom Tromey  <tom@tromey.com>
3203
3204         * macrocmd.c (show_pp_source_pos): Style the file names.
3205
3206 2019-02-17  Tom Tromey  <tom@tromey.com>
3207
3208         PR tui/24197:
3209         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3210
3211 2019-02-17  Tom Tromey  <tom@tromey.com>
3212
3213         * ada-lang.c (user_select_syms): Use filtered printing.
3214         * utils.c (wrap_style): New global.
3215         (desired_style): Remove.
3216         (emit_style_escape): Add stream parameter.
3217         (set_output_style, reset_terminal_style, prompt_for_continue):
3218         Update.
3219         (flush_wrap_buffer): Only flush gdb_stdout.
3220         (wrap_here): Set wrap_style.
3221         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3222         treat escape sequences as a character.  Change when wrap buffer is
3223         flushed.
3224         (fputs_styled): Do not set the output style when the default is
3225         requested.
3226         * ui-style.h (struct ui_file_style) <is_default>: New method.
3227         * source.c (print_source_lines_base): Emit escape sequences in one
3228         piece.
3229
3230 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3231
3232         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3233         integers and enumeration types.
3234
3235 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3236
3237         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3238         instead of lookup_symbol_in_language
3239         (do_exact_match): New function.
3240         (ada_get_symbol_name_matcher): Return do_exact_match when
3241         doing a verbatim match.
3242
3243 2019-02-15  Tom Tromey  <tromey@adacore.com>
3244
3245         * ravenscar-thread.c (ravenscar_thread_target::resume)
3246         (ravenscar_thread_target::wait): Special case wildcard requests.
3247
3248 2019-02-15  Tom Tromey  <tromey@adacore.com>
3249
3250         * ravenscar-thread.c (base_ptid): Remove.
3251         (struct ravenscar_thread_target) <close>: New method.
3252         <m_base_ptid>: New member.
3253         <update_inferior_ptid, active_task, task_is_currently_active,
3254         runtime_initialized>: Declare methods.
3255         <ravenscar_thread_target>: Add constructor.
3256         (ravenscar_thread_target::task_is_currently_active)
3257         (ravenscar_thread_target::update_inferior_ptid)
3258         (ravenscar_runtime_initialized): Rename.  Now methods.
3259         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3260         (ravenscar_thread_target::update_thread_list): Update.
3261         (ravenscar_thread_target::active_task): Now method.
3262         (ravenscar_thread_target::store_registers)
3263         (ravenscar_thread_target::prepare_to_store)
3264         (ravenscar_thread_target::prepare_to_store)
3265         (ravenscar_thread_target::mourn_inferior): Update.
3266         (ravenscar_inferior_created): Use "new" to create target.
3267         (ravenscar_thread_target::get_ada_task_ptid): Update.
3268         (_initialize_ravenscar): Don't initialize base_ptid.
3269         (ravenscar_ops): Remove global.
3270
3271 2019-02-15  Tom Tromey  <tromey@adacore.com>
3272
3273         * target.h (push_target): Declare new overload.
3274         * target.c (push_target): New overload, taking an rvalue reference.
3275         * remote.c (remote_target::open_1): Use push_target overload.
3276         * corelow.c (core_target_open): Use push_target overload.
3277
3278 2019-02-15  Tom Tromey  <tromey@adacore.com>
3279
3280         * ravenscar-thread.c (is_ravenscar_task)
3281         (ravenscar_task_is_currently_active): Return bool.
3282         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3283         (_initialize_ravenscar): Remove "(void)".
3284         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3285         Return bool.
3286
3287 2019-02-15  Tom Tromey  <tromey@adacore.com>
3288
3289         * ravenscar-thread.c (ravenscar_runtime_initializer)
3290         (has_ravenscar_runtime, get_running_thread_id)
3291         (ravenscar_thread_target::resume): Fix indentation.
3292
3293 2019-02-15  Tom Tromey  <tromey@adacore.com>
3294
3295         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3296         from ravenscar_arch_ops.
3297         (sparc_ravenscar_ops::fetch_registers)
3298         (sparc_ravenscar_ops::store_registers): Now methods.
3299         (sparc_ravenscar_prepare_to_store): Remove.
3300         (sparc_ravenscar_ops): Redefine.
3301         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
3302         methods and destructor.  Remove members.
3303         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
3304         (ravenscar_thread_target::store_registers)
3305         (ravenscar_thread_target::prepare_to_store): Update.
3306         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
3307         Remove.
3308         (struct ppc_ravenscar_powerpc_ops): Derive from
3309         ravenscar_arch_ops.
3310         (ppc_ravenscar_powerpc_ops::fetch_registers)
3311         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
3312         (ppc_ravenscar_powerpc_ops): Redefine.
3313         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
3314         (ppc_ravenscar_e500_ops::fetch_registers)
3315         (ppc_ravenscar_e500_ops::store_registers): Now methods.
3316         (ppc_ravenscar_e500_ops): Redefine.
3317         * aarch64-ravenscar-thread.c
3318         (aarch64_ravenscar_generic_prepare_to_store): Remove.
3319         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
3320         (aarch64_ravenscar_fetch_registers)
3321         (aarch64_ravenscar_store_registers): Now methods.
3322         (aarch64_ravenscar_ops): Redefine.
3323
3324 2019-02-15  Tom Tromey  <tromey@adacore.com>
3325
3326         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
3327         (ravenscar_thread_target::stopped_by_hw_breakpoint)
3328         (ravenscar_thread_target::stopped_by_watchpoint)
3329         (ravenscar_thread_target::stopped_data_address)
3330         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
3331
3332 2019-02-15  Tom Tromey  <tromey@adacore.com>
3333
3334         * ravenscar-thread.c: Fix some typos.
3335
3336 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3337             Tom Tromey  <tromey@adacore.com>
3338
3339         * ada-lang.c (ada_exception_sal): Change addr_string to a
3340         std::string.
3341         (create_ada_exception_catchpoint): Update.
3342
3343 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3344             Tom Tromey  <tromey@adacore.com>
3345
3346         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3347         (bp_location_ops): Remove.
3348         (base_breakpoint_allocate_location): Update.
3349         (free_bp_location): Update.
3350         * ada-lang.c (class ada_catchpoint_location)
3351         <ada_catchpoint_location>: Remove ops parameter.
3352         (ada_catchpoint_location_dtor): Remove.
3353         (ada_catchpoint_location_ops): Remove.
3354         (allocate_location_exception): Update.
3355         * breakpoint.h (struct bp_location_ops): Remove.
3356         (class bp_location) <bp_location>: Remove bp_location_ops
3357         parameter.
3358         <~bp_location>: Add destructor.
3359         <ops>: Remove.
3360
3361 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3362             Pedro Alves  <palves@redhat.com>
3363
3364         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3365         'PATH_MAX'.
3366
3367 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3368             Samuel Thibault  <samuel.thibault@gnu.org>
3369             Thomas Schwinge  <thomas@codesourcery.com>
3370
3371         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
3372         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
3373
3374 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3375
3376         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
3377         (check_empty): Use "const char *".
3378
3379         * gnu-nat.c (gnu_nat_target::detach): Instead of
3380         'detach_inferior (pid)' call
3381         'detach_inferior (find_inferior_pid (pid))'.
3382
3383         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
3384         'nat/fork-inferior.o'.
3385         * gnu-nat.c: #include "nat/fork-inferior.h".
3386
3387         * gnu-nat.c (gnu_nat_target::detach): Instead of
3388         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
3389         * gnu-nat.h: #include "inf-child.h".
3390         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
3391         'i386_gnu_nat_target::fetch_registers'.
3392         (gnu_store_registers): Rename/move to
3393         'i386_gnu_nat_target::store_registers'.
3394
3395         * config/i386/nm-i386gnu.h: Don't "#include" any files.
3396         * gnu-nat.h (mach_thread_info): New function.
3397         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
3398
3399         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
3400
3401 2019-02-14  Frederic Konrad  <konrad@adacore.com>
3402
3403         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
3404
3405 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
3406
3407         * windows-nat.c (windows_add_thread): Add new parameter
3408         "main_thread_p" with default value set to false.  Update
3409         function documentation as well as all callers.
3410         (windows_delete_thread): Likewise.
3411         (fake_create_process): Update call to windows_add_thread.
3412         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
3413         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
3414         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
3415         call to windows_delete_thread.
3416
3417 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
3418
3419         * MAINTAINERS: Add Andrew Burgess as global maintainer.
3420
3421 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3422
3423         * symfile.c (find_separate_debug_file): Use canonical path of
3424         sysroot with child_path instead of gdb_sysroot if it is valid.
3425
3426 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3427
3428         * symfile.c (find_separate_debug_file): Use child_path to
3429         determine if an object file is under a sysroot.
3430
3431 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3432
3433         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3434         unittests/child-path-selftests.c.
3435         * common/pathstuff.c (child_path): New function.
3436         * common/pathstuff.h (child_path): New prototype.
3437         * unittests/child-path-selftests.c: New file.
3438
3439 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3440
3441         * symfile.c (find_separate_debug_file): Look for separate debug
3442         files in debug directories under the sysroot.
3443
3444 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3445
3446         * symtab.h (struct minimal_symbol data_p): New const method.
3447         (struct minimal_symbol text_p): Likewise.
3448         * symtab.c (output_source_filename): Use file name style
3449         to print file name.
3450         (print_symbol_info): Likewise.
3451         (print_msymbol_info): Use address style to print addresses.
3452         Use function name style to print executable text symbols.
3453         (expand_symtab_containing_pc): Use data_p.
3454         (find_pc_sect_compunit_symtab): Likewise.
3455
3456 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3457
3458         * breakpoint.c (describe_other_breakpoints): Use address style
3459         to print addresses.
3460         (say_where): Likewise.
3461
3462 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3463
3464         * ada-typeprint.c (print_func_type): Print function name
3465         style to print function name.
3466         * c-typeprint.c (c_print_type_1): Likewise.
3467
3468 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
3469
3470         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
3471         for execve.
3472
3473 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3474
3475         * c-exp.y (direct_abs_decl): Use emplace_back to record the
3476         type_stack.
3477
3478 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
3479
3480         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
3481         TYPE_CODE_REF types.
3482
3483 2019-02-08  Jim Wilson  <jimw@sifive.com>
3484
3485         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
3486         (riscv_linux_fregset): New.
3487         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
3488
3489 2019-02-07  Tom Tromey  <tom@tromey.com>
3490
3491         * thread.c (thread_cancel_execution_command): Update.
3492         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
3493         methods.
3494         (struct thread_fsm_ops): Remove.
3495         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
3496         (thread_fsm_should_stop, thread_fsm_return_value)
3497         (thread_fsm_set_finished, thread_fsm_finished_p)
3498         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
3499         Don't declare.
3500         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
3501         * infrun.c (clear_proceed_status_thread)
3502         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
3503         (print_stop_event): Update.
3504         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
3505         Add constructor.
3506         (step_command_fsm_ops): Remove.
3507         (new_step_command_fsm): Remove.
3508         (step_1): Update.
3509         (step_command_fsm::should_stop): Rename from
3510         step_command_fsm_should_stop.
3511         (step_command_fsm::clean_up): Rename from
3512         step_command_fsm_clean_up.
3513         (step_command_fsm::do_async_reply_reason): Rename from
3514         step_command_fsm_async_reply_reason.
3515         (struct until_next_fsm): Inherit from thread_fsm.  Add
3516         constructor.
3517         (until_next_fsm_ops): Remove.
3518         (new_until_next_fsm): Remove.
3519         (until_next_fsm::should_stop): Rename from
3520         until_next_fsm_should_stop.
3521         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
3522         (until_next_fsm::do_async_reply_reason): Rename from
3523         until_next_fsm_async_reply_reason.
3524         (struct finish_command_fsm): Inherit from thread_fsm.  Add
3525         constructor.  Change type of breakpoint.
3526         (finish_command_fsm_ops): Remove.
3527         (new_finish_command_fsm): Remove.
3528         (finish_command_fsm::should_stop): Rename from
3529         finish_command_fsm_should_stop.
3530         (finish_command_fsm::clean_up): Rename from
3531         finish_command_fsm_clean_up.
3532         (finish_command_fsm::return_value): Rename from
3533         finish_command_fsm_return_value.
3534         (finish_command_fsm::do_async_reply_reason): Rename from
3535         finish_command_fsm_async_reply_reason.
3536         (finish_command): Update.
3537         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
3538         Add constructor.
3539         (call_thread_fsm_ops): Remove.
3540         (call_thread_fsm::call_thread_fsm): Rename from
3541         new_call_thread_fsm.
3542         (call_thread_fsm::should_stop): Rename from
3543         call_thread_fsm_should_stop.
3544         (call_thread_fsm::should_notify_stop): Rename from
3545         call_thread_fsm_should_notify_stop.
3546         (run_inferior_call, call_function_by_hand_dummy): Update.
3547         * cli/cli-interp.c (should_print_stop_to_console): Update.
3548         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
3549         Add constructor.  Change type of location_breakpoint,
3550         caller_breakpoint.
3551         (until_break_fsm_ops): Remove.
3552         (new_until_break_fsm): Remove.
3553         (until_break_fsm::should_stop): Rename from
3554         until_break_fsm_should_stop.
3555         (until_break_fsm::clean_up): Rename from
3556         until_break_fsm_clean_up.
3557         (until_break_fsm::do_async_reply_reason): Rename from
3558         until_break_fsm_async_reply_reason.
3559         (until_break_command): Update.
3560         * thread-fsm.c: Remove.
3561         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
3562
3563 2019-02-07  Tom Tromey  <tom@tromey.com>
3564
3565         * yy-remap.h: Add include guard.
3566         * xtensa-tdep.h: Add include guard.
3567         * xcoffread.h: Rename include guard.
3568         * varobj-iter.h: Add include guard.
3569         * tui/tui.h: Rename include guard.
3570         * tui/tui-winsource.h: Rename include guard.
3571         * tui/tui-wingeneral.h: Rename include guard.
3572         * tui/tui-windata.h: Rename include guard.
3573         * tui/tui-win.h: Rename include guard.
3574         * tui/tui-stack.h: Rename include guard.
3575         * tui/tui-source.h: Rename include guard.
3576         * tui/tui-regs.h: Rename include guard.
3577         * tui/tui-out.h: Rename include guard.
3578         * tui/tui-layout.h: Rename include guard.
3579         * tui/tui-io.h: Rename include guard.
3580         * tui/tui-hooks.h: Rename include guard.
3581         * tui/tui-file.h: Rename include guard.
3582         * tui/tui-disasm.h: Rename include guard.
3583         * tui/tui-data.h: Rename include guard.
3584         * tui/tui-command.h: Rename include guard.
3585         * tic6x-tdep.h: Add include guard.
3586         * target/waitstatus.h: Rename include guard.
3587         * target/wait.h: Rename include guard.
3588         * target/target.h: Rename include guard.
3589         * target/resume.h: Rename include guard.
3590         * target-float.h: Rename include guard.
3591         * stabsread.h: Add include guard.
3592         * rs6000-tdep.h: Add include guard.
3593         * riscv-fbsd-tdep.h: Add include guard.
3594         * regformats/regdef.h: Rename include guard.
3595         * record.h: Rename include guard.
3596         * python/python.h: Rename include guard.
3597         * python/python-internal.h: Rename include guard.
3598         * python/py-stopevent.h: Rename include guard.
3599         * python/py-ref.h: Rename include guard.
3600         * python/py-record.h: Rename include guard.
3601         * python/py-record-full.h: Rename include guard.
3602         * python/py-record-btrace.h: Rename include guard.
3603         * python/py-instruction.h: Rename include guard.
3604         * python/py-events.h: Rename include guard.
3605         * python/py-event.h: Rename include guard.
3606         * procfs.h: Add include guard.
3607         * proc-utils.h: Add include guard.
3608         * p-lang.h: Add include guard.
3609         * or1k-tdep.h: Rename include guard.
3610         * observable.h: Rename include guard.
3611         * nto-tdep.h: Rename include guard.
3612         * nat/x86-linux.h: Rename include guard.
3613         * nat/x86-linux-dregs.h: Rename include guard.
3614         * nat/x86-gcc-cpuid.h: Add include guard.
3615         * nat/x86-dregs.h: Rename include guard.
3616         * nat/x86-cpuid.h: Rename include guard.
3617         * nat/ppc-linux.h: Rename include guard.
3618         * nat/mips-linux-watch.h: Rename include guard.
3619         * nat/linux-waitpid.h: Rename include guard.
3620         * nat/linux-ptrace.h: Rename include guard.
3621         * nat/linux-procfs.h: Rename include guard.
3622         * nat/linux-osdata.h: Rename include guard.
3623         * nat/linux-nat.h: Rename include guard.
3624         * nat/linux-namespaces.h: Rename include guard.
3625         * nat/linux-btrace.h: Rename include guard.
3626         * nat/glibc_thread_db.h: Rename include guard.
3627         * nat/gdb_thread_db.h: Rename include guard.
3628         * nat/gdb_ptrace.h: Rename include guard.
3629         * nat/fork-inferior.h: Rename include guard.
3630         * nat/amd64-linux-siginfo.h: Rename include guard.
3631         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
3632         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
3633         * nat/aarch64-linux.h: Rename include guard.
3634         * nat/aarch64-linux-hw-point.h: Rename include guard.
3635         * mn10300-tdep.h: Add include guard.
3636         * mips-linux-tdep.h: Add include guard.
3637         * mi/mi-parse.h: Rename include guard.
3638         * mi/mi-out.h: Rename include guard.
3639         * mi/mi-main.h: Rename include guard.
3640         * mi/mi-interp.h: Rename include guard.
3641         * mi/mi-getopt.h: Rename include guard.
3642         * mi/mi-console.h: Rename include guard.
3643         * mi/mi-common.h: Rename include guard.
3644         * mi/mi-cmds.h: Rename include guard.
3645         * mi/mi-cmd-break.h: Rename include guard.
3646         * m2-lang.h: Add include guard.
3647         * location.h: Rename include guard.
3648         * linux-record.h: Rename include guard.
3649         * linux-nat.h: Add include guard.
3650         * linux-fork.h: Add include guard.
3651         * i386-darwin-tdep.h: Rename include guard.
3652         * hppa-linux-offsets.h: Add include guard.
3653         * guile/guile.h: Rename include guard.
3654         * guile/guile-internal.h: Rename include guard.
3655         * gnu-nat.h: Rename include guard.
3656         * gdb-stabs.h: Rename include guard.
3657         * frv-tdep.h: Add include guard.
3658         * f-lang.h: Add include guard.
3659         * event-loop.h: Add include guard.
3660         * darwin-nat.h: Rename include guard.
3661         * cp-abi.h: Rename include guard.
3662         * config/sparc/nm-sol2.h: Rename include guard.
3663         * config/nm-nto.h: Rename include guard.
3664         * config/nm-linux.h: Add include guard.
3665         * config/i386/nm-i386gnu.h: Rename include guard.
3666         * config/djgpp/nl_types.h: Rename include guard.
3667         * config/djgpp/langinfo.h: Rename include guard.
3668         * compile/gcc-cp-plugin.h: Add include guard.
3669         * compile/gcc-c-plugin.h: Add include guard.
3670         * compile/compile.h: Rename include guard.
3671         * compile/compile-object-run.h: Rename include guard.
3672         * compile/compile-object-load.h: Rename include guard.
3673         * compile/compile-internal.h: Rename include guard.
3674         * compile/compile-cplus.h: Rename include guard.
3675         * compile/compile-c.h: Rename include guard.
3676         * common/xml-utils.h: Rename include guard.
3677         * common/x86-xstate.h: Rename include guard.
3678         * common/version.h: Rename include guard.
3679         * common/vec.h: Rename include guard.
3680         * common/tdesc.h: Rename include guard.
3681         * common/selftest.h: Rename include guard.
3682         * common/scoped_restore.h: Rename include guard.
3683         * common/scoped_mmap.h: Rename include guard.
3684         * common/scoped_fd.h: Rename include guard.
3685         * common/safe-iterator.h: Rename include guard.
3686         * common/run-time-clock.h: Rename include guard.
3687         * common/refcounted-object.h: Rename include guard.
3688         * common/queue.h: Rename include guard.
3689         * common/ptid.h: Rename include guard.
3690         * common/print-utils.h: Rename include guard.
3691         * common/preprocessor.h: Rename include guard.
3692         * common/pathstuff.h: Rename include guard.
3693         * common/observable.h: Rename include guard.
3694         * common/netstuff.h: Rename include guard.
3695         * common/job-control.h: Rename include guard.
3696         * common/host-defs.h: Rename include guard.
3697         * common/gdb_wait.h: Rename include guard.
3698         * common/gdb_vecs.h: Rename include guard.
3699         * common/gdb_unlinker.h: Rename include guard.
3700         * common/gdb_unique_ptr.h: Rename include guard.
3701         * common/gdb_tilde_expand.h: Rename include guard.
3702         * common/gdb_sys_time.h: Rename include guard.
3703         * common/gdb_string_view.h: Rename include guard.
3704         * common/gdb_splay_tree.h: Rename include guard.
3705         * common/gdb_setjmp.h: Rename include guard.
3706         * common/gdb_ref_ptr.h: Rename include guard.
3707         * common/gdb_optional.h: Rename include guard.
3708         * common/gdb_locale.h: Rename include guard.
3709         * common/gdb_assert.h: Rename include guard.
3710         * common/filtered-iterator.h: Rename include guard.
3711         * common/filestuff.h: Rename include guard.
3712         * common/fileio.h: Rename include guard.
3713         * common/environ.h: Rename include guard.
3714         * common/common-utils.h: Rename include guard.
3715         * common/common-types.h: Rename include guard.
3716         * common/common-regcache.h: Rename include guard.
3717         * common/common-inferior.h: Rename include guard.
3718         * common/common-gdbthread.h: Rename include guard.
3719         * common/common-exceptions.h: Rename include guard.
3720         * common/common-defs.h: Rename include guard.
3721         * common/common-debug.h: Rename include guard.
3722         * common/cleanups.h: Rename include guard.
3723         * common/buffer.h: Rename include guard.
3724         * common/btrace-common.h: Rename include guard.
3725         * common/break-common.h: Rename include guard.
3726         * cli/cli-utils.h: Rename include guard.
3727         * cli/cli-style.h: Rename include guard.
3728         * cli/cli-setshow.h: Rename include guard.
3729         * cli/cli-script.h: Rename include guard.
3730         * cli/cli-interp.h: Rename include guard.
3731         * cli/cli-decode.h: Rename include guard.
3732         * cli/cli-cmds.h: Rename include guard.
3733         * charset-list.h: Add include guard.
3734         * buildsym-legacy.h: Rename include guard.
3735         * bfin-tdep.h: Add include guard.
3736         * ax.h: Rename include guard.
3737         * arm-linux-tdep.h: Add include guard.
3738         * arm-fbsd-tdep.h: Add include guard.
3739         * arch/xtensa.h: Rename include guard.
3740         * arch/tic6x.h: Add include guard.
3741         * arch/i386.h: Add include guard.
3742         * arch/arm.h: Rename include guard.
3743         * arch/arm-linux.h: Rename include guard.
3744         * arch/arm-get-next-pcs.h: Rename include guard.
3745         * arch/amd64.h: Add include guard.
3746         * arch/aarch64-insn.h: Rename include guard.
3747         * arch-utils.h: Rename include guard.
3748         * annotate.h: Add include guard.
3749         * amd64-darwin-tdep.h: Rename include guard.
3750         * aarch64-linux-tdep.h: Add include guard.
3751         * aarch64-fbsd-tdep.h: Add include guard.
3752         * aarch32-linux-nat.h: Add include guard.
3753
3754 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3755
3756         * macrotab.c (macro_define_internal): New function that
3757         factorizes macro_define_object_internal and macro_define_function
3758         code.
3759         (macro_define_object_internal): Use macro_define_internal.
3760         (macro_define_function): Likewise.
3761
3762 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3763
3764         * macrocmd.c (extract_identifier): Return
3765         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
3766         callers.
3767
3768 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
3769
3770         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
3771
3772 2019-02-05  Tom Tromey  <tom@tromey.com>
3773
3774         * target.c (target_stack::unpush): Move assertion earlier.
3775
3776 2019-01-30  Tom Tromey  <tom@tromey.com>
3777
3778         PR python/23615:
3779         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
3780         (gdbpy_parse_and_eval): Likewise.
3781         * python/python-internal.h (gdbpy_allow_threads): New class.
3782
3783 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
3784
3785         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
3786         (aarch64_fbsd_fpregmap): Move earlier.
3787         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
3788         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3789         instead of individual calls to trad_frame_set_reg_addr.
3790         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
3791         earlier.
3792         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
3793         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
3794         instead of individual calls to trad_frame_set_reg_addr.
3795
3796 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
3797
3798         * CONTRIBUTE: Replace contribution list with wiki link.
3799
3800 2019-01-25  Tom Tromey  <tom@tromey.com>
3801
3802         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
3803
3804 2019-01-25  Tom Tromey  <tom@tromey.com>
3805
3806         * xtensa-linux-nat.c: Fix common/ includes.
3807         * xml-support.h: Fix common/ includes.
3808         * xml-support.c: Fix common/ includes.
3809         * x86-linux-nat.c: Fix common/ includes.
3810         * windows-nat.c: Fix common/ includes.
3811         * varobj.h: Fix common/ includes.
3812         * varobj.c: Fix common/ includes.
3813         * value.c: Fix common/ includes.
3814         * valops.c: Fix common/ includes.
3815         * utils.c: Fix common/ includes.
3816         * unittests/xml-utils-selftests.c: Fix common/ includes.
3817         * unittests/utils-selftests.c: Fix common/ includes.
3818         * unittests/unpack-selftests.c: Fix common/ includes.
3819         * unittests/tracepoint-selftests.c: Fix common/ includes.
3820         * unittests/style-selftests.c: Fix common/ includes.
3821         * unittests/string_view-selftests.c: Fix common/ includes.
3822         * unittests/scoped_restore-selftests.c: Fix common/ includes.
3823         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
3824         * unittests/scoped_fd-selftests.c: Fix common/ includes.
3825         * unittests/rsp-low-selftests.c: Fix common/ includes.
3826         * unittests/parse-connection-spec-selftests.c: Fix common/
3827         includes.
3828         * unittests/optional-selftests.c: Fix common/ includes.
3829         * unittests/offset-type-selftests.c: Fix common/ includes.
3830         * unittests/observable-selftests.c: Fix common/ includes.
3831         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
3832         * unittests/memrange-selftests.c: Fix common/ includes.
3833         * unittests/memory-map-selftests.c: Fix common/ includes.
3834         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
3835         * unittests/function-view-selftests.c: Fix common/ includes.
3836         * unittests/environ-selftests.c: Fix common/ includes.
3837         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
3838         * unittests/common-utils-selftests.c: Fix common/ includes.
3839         * unittests/cli-utils-selftests.c: Fix common/ includes.
3840         * unittests/array-view-selftests.c: Fix common/ includes.
3841         * ui-file.c: Fix common/ includes.
3842         * tui/tui-io.c: Fix common/ includes.
3843         * tracepoint.h: Fix common/ includes.
3844         * tracepoint.c: Fix common/ includes.
3845         * tracefile-tfile.c: Fix common/ includes.
3846         * top.h: Fix common/ includes.
3847         * top.c: Fix common/ includes.
3848         * thread.c: Fix common/ includes.
3849         * target/waitstatus.h: Fix common/ includes.
3850         * target/waitstatus.c: Fix common/ includes.
3851         * target.h: Fix common/ includes.
3852         * target.c: Fix common/ includes.
3853         * target-memory.c: Fix common/ includes.
3854         * target-descriptions.c: Fix common/ includes.
3855         * symtab.h: Fix common/ includes.
3856         * symfile.c: Fix common/ includes.
3857         * stap-probe.c: Fix common/ includes.
3858         * spu-linux-nat.c: Fix common/ includes.
3859         * sparc-nat.c: Fix common/ includes.
3860         * source.c: Fix common/ includes.
3861         * solib.c: Fix common/ includes.
3862         * solib-target.c: Fix common/ includes.
3863         * ser-unix.c: Fix common/ includes.
3864         * ser-tcp.c: Fix common/ includes.
3865         * ser-pipe.c: Fix common/ includes.
3866         * ser-base.c: Fix common/ includes.
3867         * selftest-arch.c: Fix common/ includes.
3868         * s12z-tdep.c: Fix common/ includes.
3869         * rust-exp.y: Fix common/ includes.
3870         * rs6000-aix-tdep.c: Fix common/ includes.
3871         * riscv-tdep.c: Fix common/ includes.
3872         * remote.c: Fix common/ includes.
3873         * remote-notif.h: Fix common/ includes.
3874         * remote-fileio.h: Fix common/ includes.
3875         * remote-fileio.c: Fix common/ includes.
3876         * regcache.h: Fix common/ includes.
3877         * regcache.c: Fix common/ includes.
3878         * record-btrace.c: Fix common/ includes.
3879         * python/python.c: Fix common/ includes.
3880         * python/py-type.c: Fix common/ includes.
3881         * python/py-inferior.c: Fix common/ includes.
3882         * progspace.h: Fix common/ includes.
3883         * producer.c: Fix common/ includes.
3884         * procfs.c: Fix common/ includes.
3885         * proc-api.c: Fix common/ includes.
3886         * printcmd.c: Fix common/ includes.
3887         * ppc-linux-nat.c: Fix common/ includes.
3888         * parser-defs.h: Fix common/ includes.
3889         * osdata.c: Fix common/ includes.
3890         * obsd-nat.c: Fix common/ includes.
3891         * nat/x86-linux.c: Fix common/ includes.
3892         * nat/x86-linux-dregs.c: Fix common/ includes.
3893         * nat/x86-dregs.h: Fix common/ includes.
3894         * nat/x86-dregs.c: Fix common/ includes.
3895         * nat/ppc-linux.c: Fix common/ includes.
3896         * nat/mips-linux-watch.h: Fix common/ includes.
3897         * nat/mips-linux-watch.c: Fix common/ includes.
3898         * nat/linux-waitpid.c: Fix common/ includes.
3899         * nat/linux-ptrace.h: Fix common/ includes.
3900         * nat/linux-ptrace.c: Fix common/ includes.
3901         * nat/linux-procfs.c: Fix common/ includes.
3902         * nat/linux-personality.c: Fix common/ includes.
3903         * nat/linux-osdata.c: Fix common/ includes.
3904         * nat/linux-namespaces.c: Fix common/ includes.
3905         * nat/linux-btrace.h: Fix common/ includes.
3906         * nat/linux-btrace.c: Fix common/ includes.
3907         * nat/fork-inferior.c: Fix common/ includes.
3908         * nat/amd64-linux-siginfo.c: Fix common/ includes.
3909         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
3910         * nat/aarch64-linux.c: Fix common/ includes.
3911         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
3912         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
3913         * namespace.h: Fix common/ includes.
3914         * mips-linux-tdep.c: Fix common/ includes.
3915         * minsyms.c: Fix common/ includes.
3916         * mi/mi-parse.h: Fix common/ includes.
3917         * mi/mi-main.c: Fix common/ includes.
3918         * mi/mi-cmd-env.c: Fix common/ includes.
3919         * memrange.h: Fix common/ includes.
3920         * memattr.c: Fix common/ includes.
3921         * maint.h: Fix common/ includes.
3922         * maint.c: Fix common/ includes.
3923         * main.c: Fix common/ includes.
3924         * machoread.c: Fix common/ includes.
3925         * location.c: Fix common/ includes.
3926         * linux-thread-db.c: Fix common/ includes.
3927         * linux-nat.c: Fix common/ includes.
3928         * linux-fork.c: Fix common/ includes.
3929         * inline-frame.c: Fix common/ includes.
3930         * infrun.c: Fix common/ includes.
3931         * inflow.c: Fix common/ includes.
3932         * inferior.h: Fix common/ includes.
3933         * inferior.c: Fix common/ includes.
3934         * infcmd.c: Fix common/ includes.
3935         * inf-ptrace.c: Fix common/ includes.
3936         * inf-child.c: Fix common/ includes.
3937         * ia64-linux-nat.c: Fix common/ includes.
3938         * i387-tdep.c: Fix common/ includes.
3939         * i386-tdep.c: Fix common/ includes.
3940         * i386-linux-tdep.c: Fix common/ includes.
3941         * i386-linux-nat.c: Fix common/ includes.
3942         * i386-go32-tdep.c: Fix common/ includes.
3943         * i386-fbsd-tdep.c: Fix common/ includes.
3944         * i386-fbsd-nat.c: Fix common/ includes.
3945         * guile/scm-type.c: Fix common/ includes.
3946         * guile/guile.c: Fix common/ includes.
3947         * go32-nat.c: Fix common/ includes.
3948         * gnu-nat.c: Fix common/ includes.
3949         * gdbthread.h: Fix common/ includes.
3950         * gdbarch-selftests.c: Fix common/ includes.
3951         * gdb_usleep.c: Fix common/ includes.
3952         * gdb_select.h: Fix common/ includes.
3953         * gdb_bfd.c: Fix common/ includes.
3954         * gcore.c: Fix common/ includes.
3955         * fork-child.c: Fix common/ includes.
3956         * findvar.c: Fix common/ includes.
3957         * fbsd-nat.c: Fix common/ includes.
3958         * event-top.c: Fix common/ includes.
3959         * event-loop.c: Fix common/ includes.
3960         * dwarf2read.c: Fix common/ includes.
3961         * dwarf2loc.c: Fix common/ includes.
3962         * dwarf2-frame.c: Fix common/ includes.
3963         * dwarf-index-cache.c: Fix common/ includes.
3964         * dtrace-probe.c: Fix common/ includes.
3965         * disasm-selftests.c: Fix common/ includes.
3966         * defs.h: Fix common/ includes.
3967         * csky-tdep.c: Fix common/ includes.
3968         * cp-valprint.c: Fix common/ includes.
3969         * cp-support.h: Fix common/ includes.
3970         * cp-support.c: Fix common/ includes.
3971         * corelow.c: Fix common/ includes.
3972         * completer.h: Fix common/ includes.
3973         * completer.c: Fix common/ includes.
3974         * compile/compile.c: Fix common/ includes.
3975         * compile/compile-loc2c.c: Fix common/ includes.
3976         * compile/compile-cplus-types.c: Fix common/ includes.
3977         * compile/compile-cplus-symbols.c: Fix common/ includes.
3978         * command.h: Fix common/ includes.
3979         * cli/cli-dump.c: Fix common/ includes.
3980         * cli/cli-cmds.c: Fix common/ includes.
3981         * charset.c: Fix common/ includes.
3982         * build-id.c: Fix common/ includes.
3983         * btrace.h: Fix common/ includes.
3984         * btrace.c: Fix common/ includes.
3985         * breakpoint.h: Fix common/ includes.
3986         * breakpoint.c: Fix common/ includes.
3987         * ax.h: 
3988         (enum agent_op): Fix common/ includes.
3989         * ax-general.c (struct aop_map): Fix common/ includes.
3990         * ax-gdb.c: Fix common/ includes.
3991         * auxv.c: Fix common/ includes.
3992         * auto-load.c: Fix common/ includes.
3993         * arm-tdep.c: Fix common/ includes.
3994         * arch/riscv.c: Fix common/ includes.
3995         * arch/ppc-linux-common.c: Fix common/ includes.
3996         * arch/i386.c: Fix common/ includes.
3997         * arch/arm.c: Fix common/ includes.
3998         * arch/arm-linux.c: Fix common/ includes.
3999         * arch/arm-get-next-pcs.c: Fix common/ includes.
4000         * arch/amd64.c: Fix common/ includes.
4001         * arch/aarch64.c: Fix common/ includes.
4002         * arch/aarch64-insn.c: Fix common/ includes.
4003         * arch-utils.c: Fix common/ includes.
4004         * amd64-windows-tdep.c: Fix common/ includes.
4005         * amd64-tdep.c: Fix common/ includes.
4006         * amd64-sol2-tdep.c: Fix common/ includes.
4007         * amd64-obsd-tdep.c: Fix common/ includes.
4008         * amd64-nbsd-tdep.c: Fix common/ includes.
4009         * amd64-linux-tdep.c: Fix common/ includes.
4010         * amd64-linux-nat.c: Fix common/ includes.
4011         * amd64-fbsd-tdep.c: Fix common/ includes.
4012         * amd64-fbsd-nat.c: Fix common/ includes.
4013         * amd64-dicos-tdep.c: Fix common/ includes.
4014         * amd64-darwin-tdep.c: Fix common/ includes.
4015         * agent.c: Fix common/ includes.
4016         * ada-lang.h: Fix common/ includes.
4017         * ada-lang.c: Fix common/ includes.
4018         * aarch64-tdep.c: Fix common/ includes.
4019
4020 2019-01-25  Tom Tromey  <tom@tromey.com>
4021
4022         * common/create-version.sh: Use common/version.h.
4023
4024 2019-01-24  Pedro Alves  <palves@redhat.com>
4025
4026         * infrun.c (signal_stop, signal_print, signal_program)
4027         (signal_catch, signal_pass): Now arrays instead of pointers.
4028         (update_signals_program_target, do_target_resume)
4029         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4030         * linux-nat.c (linux_nat_target::pass_signals)
4031         (linux_nat_target::create_inferior, linux_nat_target::attach):
4032         Adjust.
4033         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4034         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4035         * procfs.c (procfs_target::pass_signals): Adjust.
4036         * record-full.c (record_full_target::resume): Adjust.
4037         * remote.c (remote_target::pass_signals)
4038         (remote_target::program_signals): Adjust.
4039         * target-debug.h (target_debug_print_signals): Now takes a
4040         gdb::array_view as parameter.  Adjust.
4041         * target.h (target_ops) <pass_signals, program_signals>: Replace
4042         pointer and length parameters with gdb::array_view.
4043         (target_pass_signals, target_program_signals): Likewise.
4044         * target-delegates.c: Regenerate.
4045
4046 2019-01-24  Pedro Alves  <palves@redhat.com>
4047
4048         * common/forward-scope-exit.h
4049         (forward_scope_exit::forward_scope_exit): Pass arguments to
4050         m_bind_function directly, instead of creating a std::bind and
4051         copying that.
4052
4053 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4054
4055         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4056         for static members.
4057         (pass_in_v_vfp_candidate): Likewise.
4058
4059 2019-01-23  Tom Tromey  <tom@tromey.com>
4060             Pedro Alves  <palves@redhat.com>
4061
4062         * regcache.c (class regcache_invalidator): Remove.
4063         (regcache::raw_write): Use make_scope_exit.
4064
4065 2019-01-23  Tom Tromey  <tom@tromey.com>
4066
4067         * ui-out.h (class ui_out_emit_type): Update comment.
4068
4069 2019-01-23  Tom Tromey  <tom@tromey.com>
4070
4071         * infrun.c (fetch_inferior_event): Update comment.
4072
4073 2019-01-23  Tom Tromey  <tom@tromey.com>
4074             Pedro Alves  <palves@redhat.com>
4075
4076         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4077         parameter.
4078         (fetch_inferior_event): Use SCOPE_EXIT.
4079
4080
4081 2019-01-23  Tom Tromey  <tom@tromey.com>
4082             Pedro Alves  <palves@redhat.com>
4083
4084         * infrun.c (disable_thread_events): Delete.
4085         (stop_all_threads): Use SCOPE_EXIT.
4086
4087 2019-01-23  Tom Tromey  <tom@tromey.com>
4088             Pedro Alves  <palves@redhat.com>
4089
4090         * symfile.c: Include forward-scope-exit.h.
4091         (clear_symtab_users_cleanup): Replace forward declaration with
4092         a FORWARD_SCOPE_EXIT.
4093         (syms_from_objfile_1): Use the forward_scope_exit and
4094         gdb::optional instead of cleanup_function.
4095         (reread_symbols): Use the forward_scope_exit instead of
4096         cleanup_function.
4097         (clear_symtab_users_cleanup): Remove function.
4098
4099 2019-01-23  Tom Tromey  <tom@tromey.com>
4100             Pedro Alves  <palves@redhat.com>
4101
4102         * linux-nat.c: Include scope-exit.h.
4103         (cleanup_target_stop): Remove.
4104         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4105         SCOPE_EXIT.
4106
4107 2019-01-23  Tom Tromey  <tom@tromey.com>
4108             Pedro Alves  <palves@redhat.com>
4109
4110         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4111         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4112
4113 2019-01-23  Tom Tromey  <tom@tromey.com>
4114             Andrew Burgess  <andrew.burgess@embecosm.com>
4115             Pedro Alves  <palves@redhat.com>
4116
4117         * infrun.c (fetch_inferior_event): Use scope_exit.
4118         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4119         * top.c (execute_command): Use scope_exit.
4120         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4121         * utils.c (do_bpstat_clear_actions_cleanup)
4122         (make_bpstat_clear_actions_cleanup): Remove.
4123
4124 2019-01-23  Tom Tromey  <tom@tromey.com>
4125             Pedro Alves  <palves@redhat.com>
4126
4127         * infrun.c: Include "common/scope-exit.h"
4128         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4129         (wait_for_inferior): Use SCOPE_EXIT.
4130         (fetch_inferior_event): Use scope_exit.
4131
4132 2019-01-23  Tom Tromey  <tom@tromey.com>
4133             Pedro Alves  <palves@redhat.com>
4134
4135         * breakpoint.c (create_breakpoint): Remove cleanup.
4136
4137 2019-01-23  Tom Tromey  <tom@tromey.com>
4138             Andrew Burgess  <andrew.burgess@embecosm.com>
4139             Pedro Alves  <palves@redhat.com>
4140
4141 2019-01-23  Pedro Alves  <palves@redhat.com>
4142
4143         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4144
4145 2019-01-23  Pedro Alves  <palves@redhat.com>
4146             Andrew Burgess  <andrew.burgess@embecosm.com>
4147
4148         * gdbthread.h: Include "common/forward-scope-exit.h".
4149         (scoped_finish_thread_state): Redefine custom class in terms of
4150         forward_scope_exit.
4151
4152 2019-01-23  Pedro Alves  <palves@redhat.com>
4153             Andrew Burgess  <andrew.burgess@embecosm.com>
4154
4155         * common/forward-scope-exit.h: New file.
4156
4157 2019-01-23  Pedro Alves  <palves@redhat.com>
4158             Andrew Burgess  <andrew.burgess@embecosm.com>
4159             Tom Tromey  <tom@tromey.com>
4160
4161         * common/scope-exit.h: New file.
4162
4163 2019-01-23  Pedro Alves  <palves@redhat.com>
4164
4165         * common/preprocessor.h (ESC): Rename to ...
4166         (ESC_PARENS): ... this.
4167         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4168         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4169
4170 2019-01-23  Tom Tromey  <tom@tromey.com>
4171
4172         * language.h (class scoped_switch_to_sym_language_if_auto):
4173         Initialize m_lang in both cases.
4174
4175 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4176
4177         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4178         with XCNEW.
4179
4180 2019-01-22  Tom Tromey  <tom@tromey.com>
4181
4182         * corelow.c: Do not include sys/file.h.
4183
4184 2019-01-22  Tom Tromey  <tom@tromey.com>
4185
4186         * tui/tui-wingeneral.h: Include gdb_curses.h.
4187
4188 2019-01-22  Tom Tromey  <tom@tromey.com>
4189
4190         * source-cache.h (class source_cache) <get_source_lines,
4191         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4192
4193 2019-01-22  Tom Tromey  <tom@tromey.com>
4194
4195         * remote-fileio.h (struct remote_target): Declare.
4196
4197 2019-01-22  Tom Tromey  <tom@tromey.com>
4198
4199         * python/py-arch.c: Do not include py-ref.h.
4200         * python/py-bpevent.c: Do not include py-ref.h.
4201         * python/py-cmd.c: Do not include py-ref.h.
4202         * python/py-continueevent.c: Do not include py-ref.h.
4203         * python/py-event.h: Do not include py-ref.h.
4204         * python/py-evtregistry.c: Do not include py-ref.h.
4205         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4206         * python/py-frame.c: Do not include py-ref.h.
4207         * python/py-framefilter.c: Do not include py-ref.h.
4208         * python/py-function.c: Do not include py-ref.h.
4209         * python/py-infevents.c: Do not include py-ref.h.
4210         * python/py-linetable.c: Do not include py-ref.h.
4211         * python/py-objfile.c: Do not include py-ref.h.
4212         * python/py-param.c: Do not include py-ref.h.
4213         * python/py-prettyprint.c: Do not include py-ref.h.
4214         * python/py-progspace.c: Do not include py-ref.h.
4215         * python/py-symbol.c: Do not include py-ref.h.
4216         * python/py-symtab.c: Do not include py-ref.h.
4217         * python/py-type.c: Do not include py-ref.h.
4218         * python/py-unwind.c: Do not include py-ref.h.
4219         * python/py-utils.c: Do not include py-ref.h.
4220         * python/py-value.c: Do not include py-ref.h.
4221         * python/py-varobj.c: Do not include py-ref.h.
4222         * python/py-xmethods.c: Do not include py-ref.h.
4223         * python/python.c: Do not include py-ref.h.
4224         * varobj.c: Do not include py-ref.h.
4225
4226 2019-01-22  Tom Tromey  <tom@tromey.com>
4227
4228         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4229         keyword for bcache.
4230
4231 2019-01-22  Tom Tromey  <tom@tromey.com>
4232
4233         * compile/compile-cplus-types.c: Remove a comment by #include.
4234
4235 2019-01-22  Tom Tromey  <tom@tromey.com>
4236
4237         * compile/gcc-c-plugin.h: Include compile-internal.h.
4238
4239 2019-01-22  Tom Tromey  <tom@tromey.com>
4240
4241         * stabsread.c (EXTERN): Do not define.
4242         (symnum, next_symbol_text_func, processing_gcc_compilation)
4243         (within_function, global_sym_chain, global_stabs)
4244         (previous_stab_code, this_object_header_files)
4245         (n_this_object_header_files)
4246         (n_allocated_this_object_header_files): Define.
4247         * stabsread.h (EXTERN): Never define.  Use "extern".
4248
4249 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4250
4251         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4252         history_value.
4253
4254 2019-01-21  Tom Tromey  <tom@tromey.com>
4255
4256         * ui-out.c: Fix includes.
4257         * tui/tui-source.c: Fix includes.
4258         * target.c: Fix includes.
4259         * remote.c: Fix includes.
4260         * regcache.c: Fix includes.
4261         * python/py-block.c: Fix includes.
4262         * printcmd.c: Fix includes.
4263         * or1k-tdep.c: Fix includes.
4264         * mi/mi-main.c: Fix includes.
4265         * m32r-tdep.c: Fix includes.
4266         * csky-tdep.c: Fix includes.
4267         * compile/compile-cplus-types.c: Fix includes.
4268         * cli/cli-interp.c: Fix includes.
4269
4270 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4271
4272         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4273         for padding.
4274
4275 2019-01-16  Tom Tromey  <tom@tromey.com>
4276
4277         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4278         earlier.
4279         (struct objfile) <msymbols_range>: Move from top level.
4280         <msymbols>: New method.
4281         (class objfile_msymbols): Remove.
4282         * symtab.c (default_collect_symbol_completion_matches_break_on):
4283         Update.
4284         * symmisc.c (dump_msymbols): Update.
4285         * stabsread.c (scan_file_globals): Update.
4286         * objc-lang.c (info_selectors_command, info_classes_command)
4287         (find_methods): Update.
4288         * minsyms.c (find_solib_trampoline_target): Update.
4289         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4290         * coffread.c (coff_symfile_read): Update.
4291         * ada-lang.c (ada_lookup_simple_minsym)
4292         (ada_collect_symbol_completion_matches): Update.
4293
4294 2019-01-16  Tom Tromey  <tom@tromey.com>
4295
4296         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4297         type.  Remove no-argument constructor.
4298         <iterator::operator++>: Simplify.
4299         <begin>: Update.
4300         <end>: Use minimal_symbol_count.
4301
4302 2019-01-16  Tom Tromey  <tom@tromey.com>
4303
4304         * objfiles.h (struct objfile) <psymtabs>: New method.
4305         (class objfile_psymtabs): Remove.
4306         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
4307         typedef.
4308         <range>: New method.
4309         (require_partial_symbols): Change return type.
4310         * psymtab.c (require_partial_symbols)
4311         (psym_expand_symtabs_matching): Update.
4312         * mdebugread.c (parse_partial_symbols): Update.
4313         * dbxread.c (dbx_end_psymtab): Update.
4314
4315 2019-01-15  Tom Tromey  <tom@tromey.com>
4316
4317         * symtab.c (lookup_objfile_from_block)
4318         (lookup_symbol_in_objfile_symtabs)
4319         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
4320         (find_line_symtab, info_sources_command)
4321         (default_collect_symbol_completion_matches_break_on)
4322         (make_source_files_completion_list): Update.
4323         * symmisc.c (print_objfile_statistics, dump_objfile)
4324         (maintenance_print_symbols, maintenance_info_symtabs)
4325         (maintenance_check_symtabs, maintenance_info_line_tables):
4326         Update.
4327         * source.c (select_source_symtab)
4328         (forget_cached_source_info_for_objfile): Update.
4329         * objfiles.h (class objfile_compunits): Remove.
4330         (struct objfile) <compunits_range>: New typedef.
4331         (compunits): New method.
4332         * objfiles.c (objfile_relocate1): Update.
4333         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4334         * maint.c (count_symtabs_and_blocks): Update.
4335         * linespec.c (iterate_over_all_matching_symtabs): Update.
4336         * cp-support.c (add_symbol_overload_list_qualified): Update.
4337         * coffread.c (coff_symtab_read): Update.
4338         * ada-lang.c (add_nonlocal_symbols)
4339         (ada_collect_symbol_completion_matches)
4340         (ada_add_global_exceptions): Update.
4341
4342 2019-01-15  Tom Tromey  <tom@tromey.com>
4343
4344         * progspace.h (program_space) <objfiles_safe_range>: New
4345         typedef.
4346         <objfiles_safe>: New method.
4347         * objfiles.h (class all_objfiles_safe): Remove.
4348         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4349         * jit.c (jit_inferior_exit_hook): Update.
4350
4351 2019-01-17  Tom Tromey  <tom@tromey.com>
4352
4353         * progspace.h (program_space) <objfiles_range>: New typedef.
4354         <objfiles>: New method.
4355         <objfiles_head>: Rename from objfiles.
4356         (object_files): Update.
4357         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4358         * guile/scm-pretty-print.c
4359         (ppscm_find_pretty_printer_from_objfiles): Update.
4360         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4361         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4362         Update.
4363         * python/py-progspace.c (pspy_get_objfiles): Update.
4364         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4365         Update.
4366         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4367         (objfpy_lookup_objfile_by_build_id): Update.
4368         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4369         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4370         Update.
4371         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4372         (expand_symtab_containing_pc, lookup_objfile_from_block)
4373         (lookup_static_symbol, basic_lookup_transparent_type)
4374         (find_pc_sect_compunit_symtab, find_symbol_at_address)
4375         (find_line_symtab, info_sources_command)
4376         (default_collect_symbol_completion_matches_break_on)
4377         (make_source_files_completion_list, find_main_name): Update.
4378         * symmisc.c (print_symbol_bcache_statistics)
4379         (print_objfile_statistics, maintenance_print_symbols)
4380         (maintenance_print_msymbols, maintenance_print_objfiles)
4381         (maintenance_info_symtabs, maintenance_check_symtabs)
4382         (maintenance_expand_symtabs, maintenance_info_line_tables):
4383         Update.
4384         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
4385         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
4386         (map_overlay_command, unmap_overlay_command)
4387         (simple_overlay_update, expand_symtabs_matching)
4388         (map_symbol_filenames): Update.
4389         * symfile-debug.c (set_debug_symfile): Update.
4390         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
4391         Update.
4392         * source.c (select_source_symtab, forget_cached_source_info):
4393         Update.
4394         * solib.c (solib_read_symbols): Update.
4395         * solib-spu.c (append_ocl_sos): Update.
4396         * psymtab.c (maintenance_print_psymbols)
4397         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
4398         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
4399         * printcmd.c (info_symbol_command): Update.
4400         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
4401         Update.
4402         * objfiles.h (class all_objfiles): Remove.
4403         * objfiles.c (have_partial_symbols, have_full_symbols)
4404         (have_minimal_symbols, qsort_cmp, update_section_map)
4405         (shared_objfile_contains_address_p)
4406         (default_iterate_over_objfiles_in_search_order): Update.
4407         * objc-lang.c (info_selectors_command, info_classes_command)
4408         (find_methods): Update.
4409         * minsyms.c (find_solib_trampoline_target): Update.
4410         * maint.c (maintenance_info_sections)
4411         (maintenance_translate_address, count_symtabs_and_blocks):
4412         Update.
4413         * main.c (captured_main_1): Update.
4414         * linux-thread-db.c (try_thread_db_load_from_pdir)
4415         (has_libpthread): Update.
4416         * linespec.c (iterate_over_all_matching_symtabs)
4417         (search_minsyms_for_name): Update.
4418         * jit.c (jit_find_objf_with_entry_addr): Update.
4419         * hppa-tdep.c (find_unwind_entry)
4420         (hppa_lookup_stub_minimal_symbol): Update.
4421         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
4422         Update.
4423         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4424         (elf_gnu_ifunc_resolve_by_got): Update.
4425         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
4426         * dwarf-index-write.c (save_gdb_index_command): Update.
4427         * cp-support.c (add_symbol_overload_list_qualified): Update.
4428         * breakpoint.c (create_overlay_event_breakpoint)
4429         (create_longjmp_master_breakpoint)
4430         (create_std_terminate_master_breakpoint)
4431         (create_exception_master_breakpoint): Update.
4432         * blockframe.c (find_pc_partial_function): Update.
4433         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
4434         (ada_collect_symbol_completion_matches)
4435         (ada_add_global_exceptions): Update.
4436
4437 2019-01-17  Tom Tromey  <tom@tromey.com>
4438
4439         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
4440         declare VEC.
4441         (solib_target_parse_libraries): Change return type.
4442         (library_list_start_segment, library_list_start_section)
4443         (library_list_end_library, library_list_start_library); Update.
4444         (solib_target_free_library_list): Remove.
4445         (solib_target_parse_libraries): Remove cleanup.  Change return
4446         type.
4447         (solib_target_current_sos): Update.
4448
4449 2019-01-17  Tom Tromey  <tromey@bapiya>
4450
4451         * valprint.c: Replace "the the" with "the".
4452         * symtab.c: Replace "the the" with "the".
4453         * solib.c: Replace "the the" with "the".
4454         * solib-dsbt.c: Replace "the the" with "the".
4455         * linespec.c: Replace "the the" with "the".
4456         * dwarf2loc.h: Replace "the the" with "the".
4457         * amd64-windows-tdep.c: Replace "the the" with "the".
4458         * aarch64-tdep.c: Replace "the the" with "the".
4459
4460 2019-01-16  Keith Seitz  <keiths@redhat.com>
4461
4462         PR gdb/23773
4463         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
4464         <builder>: Rename to ..
4465         <m_builder>: ... this and make private.
4466         (dwarf2_cu::get_builder): New method.  Change all users of
4467         `builder' to use this method.
4468         (dwarf2_start_symtab): Move to ...
4469         (dwarf2_cu::start_symtab): ... here.  Update all callers
4470         (setup_type_unit_groups): Move to ...
4471         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
4472         callers.
4473         (dwarf2_cu::reset_builder): New method.
4474         (process_full_compunit, process_full_type_unit): Use
4475         dwarf2_cu::reset_builder.
4476         (follow_die_offset): Record the ancestor CU if it is different
4477         from the followed DIE's CU.
4478         (follow_die_sig_1): Likewise.
4479
4480 2019-01-15  Tom Tromey  <tom@tromey.com>
4481
4482         * remote.c (class remote_state) <buf>: Now a char_vector.
4483         <buf_size>: Remove.
4484         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
4485         parameter.
4486         (remote_target::getpkt_or_notif_sane_1)
4487         (remote_target::getpkt_sane)
4488         (remote_target::getpkt_or_notif_sane): Likewise.
4489         (class remote_target) <putpkt>: New overload.
4490         (remote_target::read_frame): Change type of "buf_p".  Remove
4491         sizeof_p parameter.
4492         (packet_ok): New overload.
4493         (packet_check_result): New overload.
4494         Update all uses.
4495
4496 2019-01-14  Tom Tromey  <tom@tromey.com>
4497
4498         * remote-notif.c (handle_notification, remote_notif_ack)
4499         (remote_notif_parse): Make "buf" const.
4500         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
4501         const.
4502         (remote_notif_parse, remote_notif_ack, handle_notification):
4503         Likewise.
4504         * remote.c (remote_notif_stop_parse): Make "buf" const.
4505         (remote_target::remote_parse_stop_reply): Make "buf" const.
4506         (remote_notif_stop_ack): Make "buf" const.
4507
4508 2019-01-14  Tom Tromey  <tom@tromey.com>
4509
4510         * remote.c (remote_console_output): Make parameter const.
4511
4512 2019-01-14  Tom Tromey  <tom@tromey.com>
4513
4514         * target-debug.h (target_debug_print_signals): Constify.
4515         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
4516         * procfs.c (procfs_target::pass_signals): Update.
4517         * linux-nat.c (linux_nat_target::pass_signals): Update.
4518         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
4519         * target-delegates.c: Rebuild.
4520         * remote.c (remote_target::program_signals): Update.
4521         (remote_target::pass_signals): Update.
4522         * target.c (target_pass_signals): Constify argument.
4523         (target_program_signals): Likewise.
4524         * target.h (struct target_ops) <pass_signals, program_signals>:
4525         Constify argument.
4526         (target_pass_signals, target_program_signals): Constify argument.
4527
4528 2019-01-14  Tom Tromey  <tom@tromey.com>
4529
4530         PR tui/28819:
4531         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
4532
4533 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4534
4535         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
4536         field.
4537         * rs6000-tdep.c: Include reggroups.h.
4538         (IS_V_ALIAS_PSEUDOREG): Define.
4539         (rs6000_register_name): Return names for the "vX" aliases.
4540         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
4541         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
4542         aliases.  Call default_register_reggroup_p for all other
4543         pseudo-registers.
4544         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
4545         New functions.
4546         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
4547         Handle "vX" aliases.
4548         (v_alias_pseudo_register_collect): New function.
4549         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
4550         (rs6000_gdbarch_init): Initialize "vX" aliases as
4551         pseudo-registers.  Restore registration of
4552         rs6000_pseudo_register_reggroup_p with
4553         set_tdesc_pseudo_register_reggroup_p.
4554
4555 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
4556
4557         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
4558         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
4559         set_gdbarch_num_pseudo_regs.
4560
4561 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4562
4563         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
4564         Remove arg prefixname, add do_set and do_show.
4565         Add member functions set_list and show_list.
4566         * cli/cli-style.c (class cli_style_option): Update accordingly.
4567         (style_set_list): Move to file scope.
4568         (style_show_list): Likewise.
4569         (set_style): Call help_list.
4570         (show_style): Call cmd_show_list.
4571         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
4572         Update to use the new macro.
4573
4574 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
4575
4576         * ada-lang.c (_initialize_ada_language): Expand the help text
4577         for the "catch exception" command.
4578
4579 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4580
4581         * symtab.c (matching_obj_sections): Initialize obj,
4582         declare it closer to its usage.
4583
4584 2019-01-10  Tom Tromey  <tom@tromey.com>
4585
4586         * thread-iter.h (inf_threads_iterator): Use next_iterator.
4587         (basic_inf_threads_range): Remove.
4588         (inf_threads_range, inf_non_exited_threads_range)
4589         (safe_inf_threads_range): Use next_adapter.
4590
4591 2019-01-10  Keith Seitz  <keiths@redhat.com>
4592
4593         PR gdb/23712
4594         PR symtab/23010
4595         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
4596         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
4597
4598 2019-01-10  Keith Seitz  <keiths@redhat.com>
4599
4600         PR gdb/23712
4601         PR symtab/23010
4602         * dictionary.c (pending_to_vector): Remove.
4603         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4604         Remove _1 suffix, replacing functions of the same name.  Update
4605         all callers.
4606         (dict_create_hashed, dict_create_hashed_expandable)
4607         (dict_create_linear, dict_create_linear_expandable, dict_free)
4608         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
4609         Make functions static.
4610
4611 2019-01-10  Keith Seitz  <keiths@redhat.com>
4612
4613         PR gdb/23712
4614         PR symtab/23010
4615         * dictionary.h (struct dictionary): Replace declaration with
4616         multidictionary.
4617         (dict_create_hashed, dict_create_hashed_expandable)
4618         (dict_create_linear, dict_create_linear_expandable)
4619         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
4620         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
4621         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
4622         taking multidictionary argument.
4623         [ALL_DICT_SYMBOLS]: Update for multidictionary.
4624         * block.h (struct block) <dict>: Change to multidictionary
4625         and rename `multidict'.
4626         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
4627         symmisc.c: Update all dictionary references to multidictionary.
4628
4629 2019-01-10  Keith Seitz  <keiths@redhat.com>
4630
4631         PR gdb/23712
4632         PR symtab/23010
4633         * dictionary.c: Include unordered_map.
4634         (pending_to_vector): New function.
4635         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4636         Rewrite the non-"_1" functions to take vector instead
4637         of linked list.
4638         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
4639         "new" _1 versions of the same name.
4640         (multidictionary): Define.
4641         (std::hash<enum language): New definition.
4642         (collate_pending_symbols_by_language, mdict_create_hashed)
4643         (mdict_create_hashed_expandable, mdict_create_linear)
4644         (mdict_create_linear_expandable, mdict_free)
4645         (find_language_dictionary, create_new_language_dictionary)
4646         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
4647         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
4648         (mdict_size, mdict_empty): New functions.
4649         * dictionary.h (mdict_iterator): Define.
4650
4651 2019-01-10  Pedro Alves  <palves@redhat.com>
4652
4653         * breakpoint.c (read_uploaded_action)
4654         (create_tracepoint_from_upload): Adjust to use
4655         gdb::unique_xmalloc_ptr.
4656         * ctf.c (ctf_write_uploaded_tp):
4657         (SET_ARRAY_FIELD): Use emplace_back.
4658         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
4659         * tracefile-tfile.c (tfile_write_uploaded_tp):
4660         * tracepoint.c (parse_tracepoint_definition): Adjust to use
4661         gdb::unique_xmalloc_ptr.
4662         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
4663         at_string, cond_string, cmd_strings>: Replace char pointers
4664         with gdb::unique_xmalloc_ptr.
4665
4666 2019-01-10  Pedro Alves  <palves@redhat.com>
4667
4668         * solib-target.c (library_list_start_library): Don't xstrdup name.
4669
4670 2019-01-10  Pedro Alves  <palves@redhat.com>
4671
4672         * mdebugread.c (parse_partial_symbols): Use
4673         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
4674
4675 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4676
4677         * linux-fork.c (scoped_switch_fork_info)
4678         <~scoped_switch_fork_info>: Fix incorrect variable name.
4679
4680 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4681
4682         * linux-fork.c (scoped_switch_fork_info)
4683         <scoped_switch_fork_info>: Make explicit.
4684         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
4685
4686 2019-01-10  Tom Tromey  <tom@tromey.com>
4687
4688         * objfiles.h (objfile::reset_psymtabs): Update.
4689         * objfiles.c (objfile::objfile): Update.
4690         * psymtab.h (psymtab_storage::obstack): Update.
4691         (psymtab_storage::m_obstack): Use gdb::optional.
4692         (class psymtab_storage): Update comment.  Remove objfile
4693         parameter.
4694         * psymtab.c (psymtab_storage::psymtab_storage): Update.
4695
4696 2019-01-10  Tom Tromey  <tom@tromey.com>
4697
4698         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
4699         <free_psymtabs>: Now private.
4700         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
4701         (allocate_psymtab): Use new method.
4702
4703 2019-01-10  Tom Tromey  <tom@tromey.com>
4704
4705         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
4706         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
4707         * mdebugread.c (parse_partial_symbols): Use
4708         allocate_dependencies.
4709         * dwarf2read.c (dwarf2_create_include_psymtab): Use
4710         allocate_dependencies.
4711         (process_psymtab_comp_unit_reader)
4712         (build_type_psymtab_dependencies): Likewise.
4713         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
4714
4715 2019-01-10  Tom Tromey  <tom@tromey.com>
4716
4717         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
4718         PSYMBOL_SET_LANGUAGE.
4719         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
4720
4721 2019-01-10  Tom Tromey  <tom@tromey.com>
4722
4723         * psymtab.h (psymtab_storage::obstack): New method.
4724         <m_obstack>: Rename from obstack; now private.
4725         * psymtab.c (psymtab_storage): Update.
4726         * dwarf2read.c (create_addrmap_from_index)
4727         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
4728         Update.
4729
4730 2019-01-10  Tom Tromey  <tom@tromey.com>
4731
4732         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
4733         * objfiles.h (objfile::reset_psymtabs): New method.
4734
4735 2019-01-10  Tom Tromey  <tom@tromey.com>
4736
4737         * symmisc.c (print_symbol_bcache_statistics): Update.
4738         (print_objfile_statistics): Update.
4739         * symfile.c (reread_symbols): Update.
4740         * psymtab.h (class psymtab_storage): New.
4741         * psymtab.c (psymtab_storage): New constructor.
4742         (~psymtab_storage): New destructor.
4743         (require_partial_symbols): Update.
4744         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
4745         (find_pc_sect_psymtab, find_pc_sect_psymbol)
4746         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
4747         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
4748         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
4749         (start_psymtab_common, end_psymtab_common)
4750         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
4751         (allocate_psymtab): Update.
4752         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
4753         Update.
4754         (dump_psymtab_addrmap, maintenance_print_psymbols)
4755         (maintenance_check_psymtabs): Update.
4756         (class objfile_psymtabs): Move to objfiles.h.
4757         * psympriv.h (discard_psymtab): Now inline.
4758         (psymtab_discarder::psymtab_discarder): Update.
4759         (psymtab_discarder::~psymtab_discarder): Update.
4760         (ALL_OBJFILE_PSYMTABS): Rewrite.
4761         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
4762         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
4763         Remove fields.
4764         <partial_symtabs>: New field.
4765         (class objfile_psymtabs): Move from psymtab.h.  Update.
4766         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
4767         psymbol_cache.
4768         (objfile::~objfile): Don't destroy psymbol_cache.
4769         * mdebugread.c (parse_partial_symbols): Update.
4770         * dwarf2read.c (create_addrmap_from_index)
4771         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4772         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
4773         (add_partial_subprogram, dwarf2_ranges_read): Update.
4774         * dwarf-index-write.c (write_address_map)
4775         (write_one_signatured_type, recursively_write_psymbols)
4776         (class debug_names, class debug_names, write_psymtabs_to_index):
4777         Update.
4778
4779 2019-01-10  Tom Tromey  <tom@tromey.com>
4780
4781         * symtab.h (SYMBOL_SET_NAMES): Update.
4782         (symbol_set_names): Update.
4783         (MSYMBOL_SET_NAMES): Update.
4784         * symtab.c (symbol_set_names): Change argument to be an
4785         objfile_per_bfd_storage.
4786         * psymtab.c (add_psymbol_to_bcache): Update.
4787         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
4788
4789 2019-01-10  Tom Tromey  <tom@tromey.com>
4790
4791         * symtab.c (create_demangled_names_hash): Change argument to be an
4792         objfile_per_bfd_storage.
4793         (symbol_set_names): Update.
4794
4795 2019-01-10  Tom Tromey  <tom@tromey.com>
4796
4797         * xcoffread.c (xcoff_initial_scan): Unconditionally call
4798         init_psymbol_list.
4799         * psymtab.c (init_psymbol_list): Do nothing if already called.
4800         * psympriv.h (init_psymbol_list): Add comment.
4801         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
4802         init_psymbol_list.
4803         * dbxread.c (dbx_symfile_read): Unconditionally call
4804         init_psymbol_list.
4805
4806 2019-01-10  Tom Tromey  <tom@tromey.com>
4807
4808         * xcoffread.c (scan_xcoff_symtab): Update.
4809         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
4810         "where".
4811         * mdebugread.c (parse_partial_symbols)
4812         (handle_psymbol_enumerators): Update.
4813         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
4814         * dbxread.c (read_dbx_symtab): Update.
4815         * psympriv.h (psymbol_placement): New enum.
4816         (add_psymbol_to_list): Update.
4817
4818 2019-01-10  Tom Tromey  <tom@tromey.com>
4819
4820         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
4821         static_psymbols parameters.
4822         (scan_xcoff_symtab): Update.
4823         * psymtab.c (start_psymtab_common): Remove global_psymbols and
4824         static_psymbols parameters.
4825         * psympriv.h (start_psymtab_common): Update.
4826         * mdebugread.c (parse_partial_symbols): Update.
4827         * dwarf2read.c (create_partial_symtab): Update.
4828         * dbxread.c (read_dbx_symtab): Update.
4829         (start_psymtab): Remove global_psymbols and static_psymbols
4830         parameters.
4831
4832 2019-01-10  Tom Tromey  <tom@tromey.com>
4833
4834         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
4835         * psymtab.c (allocate_psymtab): Add comment.
4836         * psympriv.h (allocate_psymtab): Add comment.
4837         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
4838         initializations.
4839         * dbxread.c (dbx_end_psymtab): Remove some initializations.
4840
4841 2019-01-10  Tom Tromey  <tom@tromey.com>
4842
4843         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4844         Don't declare.
4845         * mipsread.c: Include mdebugread.h.
4846         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
4847         Declare.
4848         * elfread.c: Include mdebugread.h.
4849
4850 2019-01-09  Tom Tromey  <tom@tromey.com>
4851
4852         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
4853         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
4854         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
4855         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
4856         (psym_lookup_symbol, psym_find_last_source_symtab)
4857         (psym_forget_cached_source_info, psym_print_stats)
4858         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
4859         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
4860         (psym_map_matching_symbols, psym_expand_symtabs_matching)
4861         (psym_find_compunit_symtab_by_address)
4862         (maintenance_print_psymbols, maintenance_info_psymtabs)
4863         (maintenance_check_psymtabs): Use ranged for.
4864         * psymtab.h (class objfile_psymtabs): New.
4865         (require_partial_symbols): Return objfile_psymtabs.
4866         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
4867
4868 2019-01-09  Tom Tromey  <tom@tromey.com>
4869
4870         * symfile.c (overlay_invalidate_all, find_pc_overlay)
4871         (find_pc_mapped_section, list_overlays_command)
4872         (map_overlay_command, unmap_overlay_command)
4873         (simple_overlay_update): Use all_objfiles.
4874         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
4875         * printcmd.c (info_symbol_command): Use all_objfiles.
4876         * objfiles.h (ALL_OBJSECTIONS): Remove.
4877         * maint.c (maintenance_translate_address): Use all_objfiles.
4878         * gcore.c (gcore_create_callback): Use all_objfiles.
4879         (objfile_find_memory_regions): Likewise.
4880
4881 2019-01-09  Tom Tromey  <tom@tromey.com>
4882
4883         * symtab.c (find_line_symtab, info_sources_command)
4884         (make_source_files_completion_list): Use objfile_compunits.
4885         * source.c (select_source_symtab): Use objfile_compunits.
4886         * objfiles.h (struct objfile): Update comment.
4887         (ALL_OBJFILES): Remove.
4888         (ALL_FILETABS): Remove.
4889         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
4890         objfile_compunits.
4891
4892 2019-01-09  Tom Tromey  <tom@tromey.com>
4893
4894         * symmisc.c (print_objfile_statistics, dump_objfile)
4895         (maintenance_print_symbols): Use compunit_filetabs.
4896         * source.c (forget_cached_source_info_for_objfile): Use
4897         compunit_filetabs.
4898         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
4899         (ALL_FILETABS): Use compunit_filetabs.
4900         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
4901         * coffread.c (coff_symtab_read): Use compunit_filetabs.
4902
4903 2019-01-09  Tom Tromey  <tom@tromey.com>
4904
4905         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
4906         (compunit_filetabs): New.
4907         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
4908         compunit_filetabs.
4909         (info_sources_command, make_source_files_completion_list): Remove
4910         declaration.
4911         * symmisc.c (print_objfile_statistics, dump_objfile)
4912         (maintenance_print_symbols): Remove declaration.
4913         (maintenance_info_symtabs): Use compunit_filetabs.
4914         (maintenance_info_line_tables): Likewise.
4915         * source.c (select_source_symtab): Change local variable name.
4916         (forget_cached_source_info_for_objfile): Remove declaration.
4917         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
4918         * objfiles.c (objfile_relocate1): Remove declaration.
4919         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4920         declaration.
4921         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
4922         * coffread.c (coff_symtab_read): Remove declaration.
4923         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4924         compunit_filetabs.
4925
4926 2019-01-09  Tom Tromey  <tom@tromey.com>
4927
4928         * symtab.c (lookup_objfile_from_block)
4929         (find_pc_sect_compunit_symtab, search_symbols)
4930         (default_collect_symbol_completion_matches_break_on): Use
4931         objfile_compunits.
4932         * objfiles.h (ALL_COMPUNITS): Remove.
4933         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
4934         * cp-support.c (add_symbol_overload_list_qualified): Use
4935         objfile_compunits.
4936         * ada-lang.c (ada_collect_symbol_completion_matches)
4937         (ada_add_global_exceptions): Use objfile_compunits.
4938
4939 2019-01-09  Tom Tromey  <tom@tromey.com>
4940
4941         * source.c (select_source_symtab)
4942         (forget_cached_source_info_for_objfile): Remove declaration.
4943         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
4944         declaration.
4945         * maint.c (count_symtabs_and_blocks): Remove declaration.
4946         * cp-support.c (add_symbol_overload_list_qualified): Remove
4947         declaration.
4948         * coffread.c (coff_symtab_read): Remove declaration.
4949         * symtab.c (lookup_symbol_in_objfile_symtabs)
4950         (basic_lookup_transparent_type_1): Use objfile_compunits.
4951         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
4952         (info_sources_command, search_symbols)
4953         (default_collect_symbol_completion_matches_break_on)
4954         (make_source_files_completion_list): Remove declaration.
4955         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
4956         (ada_collect_symbol_completion_matches)
4957         (ada_add_global_exceptions): Remove declaration.
4958         * linespec.c (iterate_over_all_matching_symtabs): Use
4959         objfile_compunits.
4960         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
4961         (class objfile_compunits): New.
4962         (ALL_COMPUNITS): Use objfile_compunits.
4963         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
4964         (maintenance_check_symtabs, maintenance_info_line_tables): Use
4965         objfile_compunits.
4966         * objfiles.c (objfile_relocate1): Use objfile_compunits.
4967
4968 2019-01-09  Tom Tromey  <tom@tromey.com>
4969
4970         * symtab.c (search_symbols)
4971         (default_collect_symbol_completion_matches_break_on): Use
4972         objfile_msymbols.
4973         * ada-lang.c (ada_lookup_simple_minsym)
4974         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
4975         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
4976         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
4977         objfile_msymbols.
4978         * coffread.c (coff_symfile_read): Use objfile_msymbols.
4979         * symmisc.c (dump_msymbols): Use objfile_msymbols.
4980         * objc-lang.c (find_methods): Use objfile_msymbols.
4981         (info_selectors_command, info_classes_command): Likewise.
4982         * stabsread.c (scan_file_globals): Use objfile_msymbols.
4983         * objfiles.h (class objfile_msymbols): New.
4984         (ALL_OBJFILE_MSYMBOLS): Remove.
4985         (ALL_MSYMBOLS): Remove.
4986
4987 2019-01-09  Tom Tromey  <tom@tromey.com>
4988
4989         * common/next-iterator.h (next_adapter): Add Iterator template
4990         parameter.
4991         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
4992         (class all_objfiles_safe): New.
4993         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
4994         * objfiles.c (put_objfile_before): Update comment.
4995         (add_separate_debug_objfile): Likewise.
4996         (free_all_objfiles): Use all_objfiles_safe.
4997         (objfile_purge_solibs): Likewise.
4998
4999 2019-01-09  Tom Tromey  <tom@tromey.com>
5000
5001         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5002         (expand_symtab_containing_pc, lookup_static_symbol)
5003         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5004         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5005         all_objfiles.
5006         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5007         * breakpoint.c (create_overlay_event_breakpoint)
5008         (create_longjmp_master_breakpoint)
5009         (create_std_terminate_master_breakpoint)
5010         (create_exception_master_breakpoint): Use all_objfiles.
5011         * linux-thread-db.c (try_thread_db_load_from_pdir)
5012         (has_libpthread): Use all_objfiles.
5013         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5014         * linespec.c (iterate_over_all_matching_symtabs)
5015         (search_minsyms_for_name): Use all_objfiles.
5016         * maint.c (maintenance_info_sections): Use all_objfiles.
5017         * main.c (captured_main_1): Use all_objfiles.
5018         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5019         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5020         * guile/scm-pretty-print.c
5021         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5022         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5023         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5024         (maintenance_print_msymbols): Use all_objfiles.
5025         * source.c (select_source_symtab): Use all_objfiles.
5026         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5027         * symfile.c (remove_symbol_file_command)
5028         (expand_symtabs_matching, map_symbol_filenames): Use
5029         all_objfiles.
5030         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5031         all_objfiles.
5032         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5033         * objc-lang.c (find_methods): Use all_objfiles.
5034         * objfiles.c (have_partial_symbols, have_full_symbols)
5035         (have_minimal_symbols, qsort_cmp)
5036         (default_iterate_over_objfiles_in_search_order): Use
5037         all_objfiles.
5038         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5039         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5040         (maintenance_check_psymtabs): Use all_objfiles.
5041         (ALL_PSYMTABS): Remove.
5042         * compile/compile-object-run.c (do_module_cleanup): Use
5043         all_objfiles.
5044         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5045         * cp-support.c (add_symbol_overload_list_qualified): Use
5046         all_objfiles.
5047         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5048         Use all_objfiles.
5049         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5050         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5051         all_objfiles.
5052         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5053         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5054         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5055         Uses all_objfiles.
5056         * solib.c (solib_read_symbols): Use all_objfiles
5057
5058 2019-01-09  Tom Tromey  <tom@tromey.com>
5059
5060         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5061         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5062         all_objfiles.
5063         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5064         * symmisc.c (print_symbol_bcache_statistics)
5065         (print_objfile_statistics, maintenance_print_objfiles)
5066         (maintenance_info_symtabs, maintenance_check_symtabs)
5067         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5068         all_objfiles.
5069         * source.c (forget_cached_source_info): Use all_objfiles.
5070         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5071         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5072         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5073         * objfiles.c (update_section_map): Use all_objfiles.
5074         (shared_objfile_contains_address_p): Likewise.
5075         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5076         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5077
5078 2019-01-09  Tom Tromey  <tom@tromey.com>
5079
5080         * common/next-iterator.h: New file.
5081         * objfiles.h (class all_objfiles): New.
5082         (struct objfile_iterator): New.
5083
5084 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5085
5086         * NEWS: Move the description of the changed "frame", "select-frame",
5087          and "info frame" commands to the Changed commands section.
5088
5089 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5090
5091         * gdbtypes.c (check_stub_method_group): Remove handling of old
5092         mangling schemes.
5093         * linespec.c (find_methods): Likewise.
5094         * stabsread.c (read_member_functions): Likewise.
5095         * valops.c (search_struct_method): Likewise.
5096         (value_struct_elt_for_reference): Likewise.
5097         * NEWS: Mention this change.
5098
5099 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5100
5101         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5102         print_source_lines.
5103         * source.c (print_source_lines_base): Update line number check.
5104         (print_source_lines): New function.
5105         (source_lines_range::source_lines_range): New function.
5106         * source.h (class source_lines_range): New class.
5107         (print_source_lines): New declaration.
5108
5109 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5110
5111         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5112
5113 2019-01-08  Tom Tromey  <tom@tromey.com>
5114             Simon Marchi  <simon.marchi@ericsson.com>
5115
5116         PR gdb/24060
5117         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5118         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5119         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5120         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5121         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5122         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5123
5124 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5125
5126         * source.c (select_source_symtab): Move header comment to
5127         declaration in source.h.
5128         (forget_cached_source_info_for_objfile): Likewise.
5129         (forget_cached_source_info): Likewise.
5130         (identify_source_line): Likewise.
5131         * source.h (identify_source_line): Move declaration from symtab.h
5132         and add comment from source.c
5133         (print_source_lines): Likewise.
5134         (forget_cached_source_info_for_objfile): Likewise.
5135         (forget_cached_source_info): Likewise.
5136         (select_source_symtab): Likewise.
5137         (enum print_source_lines_flag): Move definition from symtab.h.
5138         * symtab.h (identify_source_line): Move declaration to source.h.
5139         (print_source_lines): Likewise.
5140         (forget_cached_source_info_for_objfile): Likewise.
5141         (forget_cached_source_info): Likewise.
5142         (select_source_symtab): Likewise.
5143         (enum print_source_lines_flag): Move definition to source.h.
5144         * tui/tui-hooks.c: Add 'source.h' include.
5145
5146 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5147
5148         * source.c (print_source_lines_base): Handle requests to print
5149         reverse line number sequences, and guard against empty lines
5150         string.
5151
5152 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5153
5154         * source.c (print_source_lines_base): Fix skip of '\r' if next
5155         character is '\n'.
5156
5157 2019-01-06  Tom Tromey  <tom@tromey.com>
5158
5159         * c-exp.y (struct c_parse_state) <macro_original_text,
5160         expansion_obstack>: New member.
5161         (macro_original_text, expansion_obstack): Remove globals.
5162         (scan_macro_expansion, scanning_macro_expansion)
5163         (finished_macro_expansion): Update.
5164         (scan_macro_cleanup): Remove.
5165         (yylex, c_parse): Update.
5166
5167 2019-01-06  Tom Tromey  <tom@tromey.com>
5168
5169         * c-exp.y (struct c_parse_state) <strings>: New member.
5170         (operator_stoken): Update.
5171
5172 2019-01-06  Tom Tromey  <tom@tromey.com>
5173
5174         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5175         (union type_stack_elt) <typelist_val>: Now a pointer to
5176         std::vector.
5177         (type_stack_cleanup): Don't declare.
5178         (push_typelist): Update.
5179         * parse.c (pop_typelist): Return a std::vector.
5180         (push_typelist): Take a std::vector.
5181         (follow_types): Update.  Do not free args.
5182         (type_stack_cleanup): Remove.
5183         * c-exp.y (struct c_parse_state): New.
5184         (cpstate): New global.
5185         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5186         (nonempty_typelist): Update.
5187         (func_mod): Create a new vector.
5188         (c_parse): Create a c_parse_state.
5189         (check_parameter_typelist): Do not delete params.
5190         (function_method): Update.  Do not delete type_list.
5191
5192 2019-01-06  Tom Tromey  <tom@tromey.com>
5193
5194         PR gdb/28155:
5195         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5196         check_typedef.
5197         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5198         (print_return_value): Likewise.
5199
5200 2019-01-05  Tom Tromey  <tom@tromey.com>
5201
5202         * contrib/cleanup_check.py: Remove.
5203         * contrib/gcc-with-excheck: Remove.
5204         * contrib/exsummary.py: Remove.
5205         * contrib/excheck.py: Remove.
5206
5207 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5208
5209         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5210         NULL. Initialize tpprev to NULL instead of assigning it
5211         to NULL on the next statement.
5212         * windows-nat.c (windows_delete_thread): Remove check for
5213         main_thread_id before printing thread exit notifications.
5214         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5215         Remove thread ID check against main_thread_id.
5216         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5217         windows_delete_thread.
5218         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5219
5220 2019-01-04  Tom Tromey  <tom@tromey.com>
5221
5222         * compile/compile.c (_initialize_compile): Use upper case for
5223         metasyntactic variables.
5224         * symmisc.c (_initialize_symmisc): Use upper case for
5225         metasyntactic variables.
5226         * psymtab.c (_initialize_psymtab): Use upper case for
5227         metasyntactic variables.
5228         * demangle.c (demangle_command): Use upper case for metasyntactic
5229         variables.
5230         (_initialize_demangler): Likewise.
5231         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5232         variables.
5233
5234 2019-01-03  Tom Tromey  <tom@tromey.com>
5235
5236         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5237
5238 2019-01-03  Tom Tromey  <tom@tromey.com>
5239
5240         * python/py-symtab.c (salpy_str): Update.
5241         (struct salpy_sal_object) <symtab>: Now a PyObject.
5242         (salpy_dealloc): Update.
5243         (del_objfile_sal): Use gdbpy_ref.
5244
5245 2019-01-03  Tom Tromey  <tom@tromey.com>
5246
5247         * python/py-type.c (convert_field): Use new_reference.  Return
5248         gdbpy_ref.
5249         (make_fielditem): Return gdbpy_ref.
5250         (typy_fields): Update.
5251         (typy_getitem): Update.
5252         (field_name): Return gdbpy_ref.  Use new_reference.
5253         (typy_iterator_iternext): Update.
5254
5255 2019-01-03  Tom Tromey  <tom@tromey.com>
5256
5257         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5258
5259 2019-01-03  Tom Tromey  <tom@tromey.com>
5260
5261         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5262         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5263         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5264         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5265         (pspy_set_type_printers): Likewise.
5266         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5267         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5268         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5269         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5270         (objfpy_set_type_printers): Likewise.
5271
5272 2019-01-03  Tom Tromey  <tom@tromey.com>
5273
5274         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5275         (gdbpy_print_stack): Use gdbpy_err_fetch.
5276         * python/python-internal.h (class gdbpy_err_fetch): New class.
5277         (class gdbpy_enter) <m_error_type, m_error_value,
5278         m_error_traceback>: Remove.
5279         <m_error>: New member.
5280         (gdbpy_exception_to_string): Don't declare.
5281         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5282         * python/py-value.c (convert_value_from_python): Use
5283         gdbpy_err_fetch.
5284         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5285         gdbpy_exception_to_string.
5286         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5287         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5288         gdbpy_err_fetch.
5289
5290 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5291
5292         * linux-nat.c (delete_lwp_cleanup): Delete.
5293         (struct lwp_deleter): New struct.
5294         (lwp_info_up): New typedef.
5295         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5296         lwp_info_up.
5297
5298 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5299
5300         * linux-fork.c (class scoped_switch_fork_info): New class.
5301         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
5302
5303 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5304
5305         * valops.c (find_overload_match): Remove use of null_cleanup, and
5306         calls to do_cleanups.
5307
5308 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5309
5310         * compile/compile-cplus-types.c
5311         (compile_cplus_instance::decl_name): Handle changes to
5312         cp_func_name.
5313         * cp-support.c (cp_func_name): Update header comment, update
5314         return type.
5315         * cp-support.h (cp_func_name): Update return type in declaration.
5316         * valops.c (find_overload_match): Move temp_func local to top
5317         level of function and change its type.  Use temp_func to hold and
5318         delete temporary string obtained from cp_func_name.
5319
5320 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5321
5322         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
5323         gdb::char_vector, remove cleanup, and update uses of `msg`.
5324
5325 2019-01-03  Jim Wilson  <jimw@sifive.com>
5326
5327         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
5328
5329 2019-01-02  Tom Tromey  <tom@tromey.com>
5330
5331         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
5332         (tdesc_parse_xml): Remove cleanups.
5333         * target-descriptions.h (make_cleanup_free_target_description):
5334         Don't declare.
5335         (target_desc_deleter): New struct.
5336         (target_desc_up): New typedef.
5337         * target-descriptions.c (target_desc_deleter::operator()): Rename
5338         from free_target_description.
5339         (make_cleanup_free_target_description): Remove.
5340
5341 2019-01-02  Tom Tromey  <tom@tromey.com>
5342
5343         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
5344         constructor, destructor.
5345         (linespec_parser): Remove typedef.
5346         (~linespec_parser): Rename from linespec_parser_delete.
5347         (linespec_lex_to_end, linespec_complete_label)
5348         (linespec_complete): Update.
5349         (decode_line_full): Remove cleanups.
5350         (decode_line_1): Update.
5351
5352 2019-01-02  Tom Tromey  <tom@tromey.com>
5353
5354         * python/python-internal.h (inferior_to_inferior_object): Change
5355         return type.
5356         * python/py-exitedevent.c (create_exited_event_object): Update.
5357         * python/py-inferior.c (inferior_to_inferior_object): Return
5358         gdbpy_ref.
5359         (python_new_inferior, python_inferior_deleted)
5360         (thread_to_thread_object, delete_thread_object)
5361         (build_inferior_list, gdbpy_selected_inferior): Update.
5362         * python/py-infthread.c (create_thread_object): Update.  Also fail
5363         if inferior_to_inferior_object fails.
5364
5365 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5366
5367         * inferior.h (class inferior) <displaced_step_state>: New field.
5368         * infrun.h (struct displaced_step_state): Move here from
5369         infrun.c.  Initialize fields, add constructor.
5370         <inf>: Remove field.
5371         <reset>: New method.
5372         * infrun.c (struct displaced_step_inferior_state): Move to
5373         infrun.h.
5374         (displaced_step_inferior_states): Remove.
5375         (get_displaced_stepping_state): Adust.
5376         (displaced_step_in_progress_any_inferior): Adjust.
5377         (displaced_step_in_progress_thread): Adjust.
5378         (displaced_step_in_progress): Adjust.
5379         (add_displaced_stepping_state): Remove.
5380         (get_displaced_step_closure_by_addr): Adjust.
5381         (remove_displaced_stepping_state): Remove.
5382         (infrun_inferior_exit): Call displaced_step_state.reset.
5383         (use_displaced_stepping): Don't check for NULL.
5384         (displaced_step_prepare_throw): Call
5385         get_displaced_stepping_state.
5386         (displaced_step_fixup): Don't check for NULL.
5387         (prepare_for_detach): Don't check for NULL.
5388
5389 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5390
5391         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
5392          in case of call that did not complete.
5393
5394 2019-01-02  Andrey Utkin  <autkin@undo.io>
5395
5396         * symfile.c (find_separate_debug_file): Fix search of debug files for
5397         remote debuggee.
5398
5399 2019-01-02  Tom Tromey  <tom@tromey.com>
5400
5401         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
5402         indentation.
5403         * python/py-frame.c (frapy_older): Remove cast.
5404         (frapy_newer): Likewise.
5405         * python/py-breakpoint.c (local_setattro): Remove cast.
5406         * python/py-arch.c (archpy_name): Remove local variable.
5407         * python/py-type.c (gdbpy_lookup_type): Remove cast.
5408
5409 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
5410
5411         * unittests/basic_string_view/element_access/char/empty.cc:
5412         Fix year range in copyright header.
5413
5414 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5415
5416         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
5417         Delete.
5418         <operator==>: Update with for removed field.
5419         <hash>: Likewise.
5420         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
5421         <isa_features>: ...this.
5422         <abi_features>: New field.
5423         (riscv_isa_flen): Update comment.
5424         (riscv_abi_xlen): New declaration.
5425         (riscv_abi_flen): New declaration.
5426         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
5427         isa_features.
5428         (riscv_abi_xlen): New function.
5429         (riscv_isa_flen): Update to get answer from isa_features.
5430         (riscv_abi_flen): New function.
5431         (riscv_has_fp_abi): Update to get answer from abi_features.
5432         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
5433         xlen and flen.
5434         (riscv_call_info) <xlen, flen>: Update comment.
5435         (riscv_call_arg_struct): Remove invalid assertions
5436         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
5437         is removed.
5438         (riscv_gdbarch_init): Gather isa features and abi features
5439         separately, ensure both match on the gdbarch when reusing an old
5440         gdbarch.  Relax an error check to allow 32-bit abi float to run on
5441         a target with 64-bit float hardware.
5442
5443 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5444
5445         * source.c (search_command_helper): Stop reverse search
5446         when line 1 has been searched.
5447
5448 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5449
5450         * record-full.c (record_full_base_target::close): Rewrite
5451         record_full_core_buf_list free logic.
5452
5453 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5454
5455         * break-catch-syscall.c (print_one_catch_syscall): xfree
5456         the last text.
5457
5458 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5459
5460         * top.c (print_gdb_version): Update Copyright year in version
5461         message.
5462
5463 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5464
5465         Update copyright year range in all GDB files.
5466
5467 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
5468
5469         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
5470
5471 For older changes see ChangeLog-2018.
5472 \f
5473 Local Variables:
5474 mode: change-log
5475 left-margin: 8
5476 fill-column: 74
5477 version-control: never
5478 coding: utf-8
5479 End:
5480